===== git log ====
commit d1c74321570e3ec77c1d91293549900f4605d613
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Tue Sep 20 13:04:56 2022 +0530
Add GlusterFS 10.3 release notes (#3821)
Updates: #3820
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 58cd388770d9c027b801b5acafcc421d57e1bfcf
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Tue Sep 20 12:39:22 2022 +0530
posix_disk_space_check, dht_disk_usage: save multiplcation if using percentage (#3040) (#3818)
If we are using percentage of free space, there's no need to multiply
both the free space and the and the total size by buf.f_bsize,
as we compare one to each other.
Similar work in DHT's code.
Also, switched from using a char ('p') to signify we are using percentage
for disk usage to a simple boolean. True means we are using percentage.
>Updates: #1000
>Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Signed-off-by: Shwetha K Acharya
Signed-off-by: Shwetha K Acharya
Co-authored-by: Yaniv Kaul <ykaul@redhat.com>
commit 8ca6f5c72aaffb09e207c4eb8117f33872c9d657
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Mon Sep 19 11:42:10 2022 +0530
lock/clear: Perform stack unwind outside of the inode lock (#3775) (#3808)
While we handle lock interrupt xatrrs, the blocked locks
are unwind with EINTR inside pl_inode lock. This is not
a good idea, since the stack unwind may choose to wind
a fop, and there can be deadlock if the wind fop requested
for the pl_inode lock. One such example would be a EINTR
call on a blocked lock with an fd having only one ref.
This will result in calling pl_release while holding
a lock on pl_inode. Since there is an pl_inode lock
request inside a pl_release too, it will end up in a
dead lock.
This patch will send the stack unwind call for an interrupt
from outside of pl_lock.
>Change-Id: I3178843d184a3cf5151b9adb76cee91906c87fc4
>Fixes: #3774
>Signed-off-by: Mohammed Rafi KC <rafi.kavungal@iternity.com>
Change-Id: I3178843d184a3cf5151b9adb76cee91906c87fc4
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
Co-authored-by: Rafi KC <rafi.kavungal@iternity.com>
commit 363f857a876862b7a2bad5153b594ed65bd9ef58
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Fri Sep 16 11:35:46 2022 +0530
Fix qemu-img crash on a distributed volume (#3720) (#3736)
Fix 'qemu-img' crash discovered as follows:
$ gluster volume info test0
Volume Name: test0
Type: Distribute
Volume ID: dc5607a7-fadc-42fd-a532-de0b791097ef
Status: Started
Snapshot Count: 0
Number of Bricks: 3
Transport-type: tcp
Bricks:
Brick1: 192.168.222.111:/pool/0
Brick2: 192.168.222.111:/pool/1
Brick3: 192.168.222.111:/pool/2
Options Reconfigured:
storage.fips-mode-rchecksum: on
transport.address-family: inet
nfs.disable: on
$ qemu-img info gluster://192.168.222.111/test0/test0.img
[2022-08-17 08:15:46.704459 +0000] I [io-stats.c:3797:ios_sample_buf_size_configure]
0-test0: Configure ios_sample_buf size is 1024 because ios_sample_interval is 0
Segmentation fault (core dumped)
$ gdb -q qemu-img core
...
Program terminated with signal SIGSEGV, Segmentation fault.
#0 dict_ref (this=this@entry=0x48003278) at dict.c:655
655 GF_ATOMIC_INC(this->refcount);
...
(gdb) p *this
Cannot access memory at address 0x48003278
(gdb) bt 4
#0 dict_ref (this=this@entry=0x48003278) at dict.c:655
#1 0x00007fb96f34e695 in syncop_seek_cbk (frame=frame@entry=0x55a04de5a2c8, cookie=0x7ffea4b96340,
this=<optimized out>, op_ret=op_ret@entry=-1, op_errno=op_errno@entry=77, offset=offset@entry=0,
xdata=0x48003278) at syncop.c:3167
#2 0x00007fb9669e7a42 in io_stats_seek_cbk (frame=frame@entry=0x55a04de5a3b8, cookie=<optimized out>,
this=<optimized out>, op_ret=op_ret@entry=-1, op_errno=op_errno@entry=77, offset=offset@entry=0,
xdata=0x48003278) at io-stats.c:2610
#3 0x00007fb96f39d47d in default_seek_cbk (frame=0x55a04de5b698, cookie=<optimized out>,
this=<optimized out>, op_ret=-1, op_errno=77, offset=0, xdata=0x48003278) at defaults.c:1615
#4 0x00007fb96c174f47 in client4_0_seek (frame=0x7fb948000eb8, this=<optimized out>, data=<optimized out>)
at client-rpc-fops_v2.c:5299
(More stack frames follow...)
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Co-authored-by: Dmitry Antipov <dantipov@cloudlinux.com>
commit 3be046c047ca12231e4a2d18f4df650566fef4e7
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Sep 16 11:33:19 2022 +0530
dht: Implement seek fop at dht level (#3811)
Before kernel minor version (.24) fuse does not
wind a seek fop but after that fuse winds a seek
fop so implement the fop at dht level.
> Fixes: #3373
> Change-Id: Ie9ef2f941099157996ab353fc4dc208a28fa8fc6
> Signed-off-by: Mohit Agrawal moagrawa@redhat.com
> (Reviewed on upstream link https://github.com/gluster/glusterfs/pull/3792)
Fixes: #3373
Change-Id: Ie9ef2f941099157996ab353fc4dc208a28fa8fc6
Signed-off-by: Mohit Agrawal moagrawa@redhat.com
Signed-off-by: Mohit Agrawal moagrawa@redhat.com
commit db158045e5b50c25db5c4688541fdfd98a9d1b51
Author: Anoop C S <anoopcs@cryptolab.net>
Date: Tue Sep 13 11:54:59 2022 +0530
Allow opening snapshot directory(entrypoint) via `glfs_open()`/`glfs_h_open()` (#3667) (#3756)
* snapview-server: Allow opening snap entrypoint with svs_open()
Recent changes made gfapi capable of opening directories via _open() and
not just _opendir(). Thus there is no point in rejecting such a open
request and should succeed without terminating with SIGABRT
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
* snapview-server: Fix releasedir to close dir properly
Existing directory opens can very well be initiated via _open(). Let's
just use _close() instead of _closedir() to avoid possible crashes on
closing directories which were not initiated by _opendir().
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
(cherry picked from commit 37f6ced36792e42b98160f9cfffdbf307421e155)
commit 06efc217ac26b4c07859aacd47a35c30dc2f4c3f
Author: Anoop C S <anoopcs@cryptolab.net>
Date: Fri Sep 9 11:46:13 2022 +0530
Allow opening directories using `glfs_open()` / `glfs_h_open()` from libgfapi (#3307, #3650) (#3755)
* gfapi: Fix return from glfs_open() to honour O_DIRECTORY flag
As per POSIX[1] specifications honour O_DIRECTORY flag during open as
follows:
O_DIRECTORY
If path resolves to a non-directory file, fail and set errno to
[ENOTDIR].
ERRORS
* [EISDIR]
The named file is a directory and oflag includes O_WRONLY or O_RDWR,
or includes O_CREAT without O_DIRECTORY
* [ENOTDIR]
A component of the path prefix names an existing file that is neither
a directory nor a symbolic link to a directory; or O_CREAT and O_EXCL
are not specified, the path argument contains at least one non-<slash>
character and ends with one or more trailing <slash> characters, and
the last pathname component names an existing file that is neither a
directory nor a symbolic link to a directory; or O_DIRECTORY was
specified and the path argument resolves to a non-directory file.
The presence of O_DIRECTORY is to ensure the file being opened is a
directory.
[1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/open.html
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
(cherry picked from commit 754a8a8e8ec8ea3a9949ecfd4e3ce149e0bd99b8)
* api: Fix return from `glfs_h_open()` to honour `O_DIRECTORY` flag (#3650)
This is more or less the same change done previously for glfs_open().
See commit message from 754a8a8e8ec8ea3a9949ecfd4e3ce149e0bd99b8 for
more details.
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
(cherry picked from commit 260485f88a2a19809236ad31bb0d0eea58ec8048)
commit 9efffe5e0fc5c8e5eef8967f996f8b4cfaa40774
Author: Anoop C S <anoopcs@cryptolab.net>
Date: Fri Sep 9 11:44:00 2022 +0530
posix: Handle get_real_filename in fgetxattr() (#3726) (#3757)
Treat the special case of "glusterfs.get_real_filename:<name>" xattr in
fgetxattr() in the same way as getxattr(). This fixes the mismatch in
error code returned for fgetxattr() and getxattr().
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
(cherry picked from commit c57f93529a0192cb7f2f45817b9a398618ae81d1)
commit 3c8f877ca9aff68bfd44cc054e9ab776e29458e5
Author: mohit84 <moagrawa@redhat.com>
Date: Mon Sep 5 15:05:56 2022 +0530
tests: Increase timeout for sparse_file_rebalance.t test case (#3779)
The test (./tests/basic/distribute/sparse_file_rebalance.t ) is
not finished within default time(200s), It is taking
time while a test is calling seek at 2M offset and trying to copy
sparse file.
Change-Id: Id174f4a9d66d1caaf69f495c3cf62a2e09e87b80
Fixes: #3778
Solution: To pass regression jobs increase the timeout to 300s
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 282e438af430015d4a476c27b3311d0297bd69e4
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Fri May 13 14:59:06 2022 +0530
Add GlusterFS 10.2 release notes (#3520)
* Add GlusterFS 10.2 release notes
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
* 10.2.md: update tentative release date
commit 5d487b90bc40389a425d775fc472190abcdafb5b
Author: JamesWSWu <34566858+JamesWSWu@users.noreply.github.com>
Date: Thu May 12 15:03:04 2022 +0800
Fixes:3177 (#3310)
Signed-off-by: 10255046 <wu.shiwei@zte.com.cn>
Co-authored-by: 10255046 <wu.shiwei@zte.com.cn>
commit 5a54ccc24575cb835d23774047a2da102098489e
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Mon May 2 07:30:24 2022 +0200
socket: fix user-after-free on name resolution error (#3488)
When a connection attempt fails, a new thread is created to clean it up
due to some potential deadlocks. However this new thread was executed
without a reference on the rpc transport when name resolution failed,
making it use stale pointer in some cases and causing a crash.
The fix makes sure that the thread always has a valid reference.
Fixes: #3470
Change-Id: Iebff6cd95602a6cfc3f81a0c6781f20fd1a76638
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 5075006ace173d5e772d6a9d8beaf05faf140886
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Apr 19 12:09:41 2022 +0200
xlator_t: remove inconsistent alignment attribute (#3423)
The 'stats' array inside 'xlator_t' was explicitly aligned to 128 bytes
(CAA_CACHE_LINE_SIZE = 128). Since this is a structure definition, it
caused the whole structure to be considered aligned to 128. That's not
problematic by itself as long as we really allocate the memory blocks
for 'xlator_t' objects at addresses multiple of 128 bytes, because the
compiler may use this fact to generate aligned access instructions
which are faster than unaligned ones.
Since we are not really allocating 'xlator_t' objects at that alignment,
the assumption that the compiler does is wrong, causing a crash.
Fixes: #3417
Change-Id: I33b5021035aae24f0b5ea14e255873da79fc0625
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 53f0b7182ed415aec6c276bdcb8e9f9ba62561ab
Author: mohit84 <moagrawa@redhat.com>
Date: Wed Apr 6 11:22:29 2022 +0530
glusterd: After node reboot not able to start all bricks successfully (#3398)
The glusterd is not able to start all bricks successfully after node reboot
if brick count is high(>750).The glusterd has attempted all the bricks to
start but brick process is not able to get a response from glusterd because glusterd
is busy to start the volumes so it has disconnect with glusterd.
Solution: Start the volumes with wait flag to true so that at the time
of making a connection with brick process the brick process
has started successfully.
Fixes: #3375
Note: To validate the patch follow the steps
1) Setup 400 1x3 volumes on a single node(without brick_mux)
2) Start all the volumes
3) kill all the gluster processes
pkill -f gluster
4) Start glusterd
5) No volume should throw "disconnected from glusterd"
Change-Id: Id050153c581dd74539cb0a8e65270adf216c9b26
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 53417877626823b5e2042fc1e6eeccd5b5c8f550
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Mar 25 11:45:12 2022 +0530
rpc: avoid restarting the bail out timer after initiating shut down (#3349)
glfs_fini takes time (20s) and slows down qemu-img, the time
is taken by due to timer_thread behavior. The timer thread
reregister function unless the timer event has not been
removed from a list.To avoid the delay the even needs
to add only if cleanup has not started.In case if cleanup
has started there is no need to add the event again in
timer thread list.
Fixes: #3334
Change-Id: I179c63c656c2917de9eb2bb44664453a1b6fc471
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 828f691de885b1c8c2f84ee38e46b6798d522999
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Mar 25 11:33:07 2022 +0530
dht: Synchronize layout_(ref|unref) during layout_(get|set) in dht code (#3352)
Currently dht_layout(ref|unref) is happening after increase/decreate
atomic counter. There is some race condition during new layout has been
changed at the same time old layout is using in other thread.Due to this
a client process is getting crashed.
Solution: Remove layout->ref_lock and use inode->lock to synchronize
layout.
Fixes: #3262
Change-Id: I55952484bd651176f818b9cab54274f37dbca1a6
Signed-off-by: Mohit Agrawal moagrawa@redhat.com
commit c1c149cc41f8c0fd9e1f166d259c9c5f405ff54e
Author: mohit84 <moagrawa@redhat.com>
Date: Thu Mar 24 14:43:45 2022 +0530
server:Optimize server_process_event_upcall code path (#3350)
The function server_process_event_upcall handles upcall event and send a
notification to client. To send a notification to client it has taken
a lock to access xprt and the lock has not released until the event has not
been sent to the client, It means at a time it will not able to process
more than one notification it has lock contention while a brick process is trying
to send more than one upcall event notification.
Solution: Instead of sending an event under critical section take a reference
on the xprt.
Fixes: #3321
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: Ibaab1626ab6e0c318df77e8efe528e71f3802517
commit 341579b2770698692f9542777ee50a64b5f3a6ff
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Thu Mar 24 14:31:06 2022 +0530
rfc.sh: update branch number for release 10 (#3354)
commit e9abe23e00262a335cb5568dc6506b70e219767b
Author: Harshita Shree <97235968+harshita-shree@users.noreply.github.com>
Date: Thu Mar 24 12:10:09 2022 +0530
garbage value fix (#3333)
Change-Id: I3307c318acb60cc105ab59f44132d751046b2bac
Signed-off-by: harshita-shree <hshree@redhat.com>
commit 1037f9ee815daf0096ae5b8d0ee431501b7db3c4
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Mon Mar 7 08:07:34 2022 +0100
configure: Fix incorrect directory check (#3271)
Running 'test -d $VAR' with 'VAR' empty should fail, but it actually
succeeds. To fix this problem, the variables have been enclosed in
quotes.
Updates: #3234
Change-Id: Ic0ba43eec06335b905caf93520cade5ef019c36a
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit ebb75cb947f461f31369ec2a3264419040446a5d
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Feb 22 08:20:26 2022 +0100
locks: fix fd leaks (#3244)
In some cases fd's were not released after waking a blocked lock.
Fixes: #3187
Change-Id: I4c138acf1d3b38334539334be3f68ec9c6b583f2
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit ff304f29c5d1875527a4d17bc1cc264d69799874
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Feb 22 08:08:01 2022 +0100
locks: fix race on client disconnect to avoid stale locks (#3243)
* locks: fix race on client disconnect to avoid stale locks
The following sequence of actions leads to a stale posix lock:
1. Client C1 sends write lock request L1. It's granted.
2. Client C2 sends write lock request L2.
3. L2 starts being processed by the brick's locks xlator, but nothing
is created yet (an fd reference is held for this request).
4. C2 disconnects.
5. Brick's server xlator flushes all open fd's. This causes the removal
of all locks from C2 (none in this case).
6. Brick's server releases it's fd reference (in normal circumstances
this should be the last one, but not in this case).
7. Locks xlator continues processing L2 and adds it to the blocked
list.
8. Eventually C1 releases L1. L2 is granted.
9. At this point the fd reference of L2 request is released. If it's
the last one, pl_release() is called, which removes all locks on the
fd. Otherwise L2 remains active indefinitely and blocks all other
requests.
This patch makes sure that the client is alive before adding a new lock.
Fixes: #3182
Change-Id: I8f2afa310388fbee159a60478ac72e371cd030e1
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
* Define constants for return values
Change-Id: I19d7c143ab009623ae21db37722c32a4505b5e79
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 853f4af380e7eaf7595bf33ffe79621df3322ba7
Author: Nikhil Ladha <nladha@redhat.com>
Date: Wed Feb 16 18:18:56 2022 +0530
Fix "unexpected operator" error resulting from using bash syntax in sh (#3174) (#3211)
* Use universal string equality test operator
Change-Id: I2d4ab89d3903b490ece0773c067cc8a936af360f
Signed-off-by: nik-redhat <nladha@redhat.com>
Co-authored-by: Brian Turek <brian.turek@gmail.com>
commit a79411a4c0eadbccad10621dd2965f51ee24dba8
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Feb 4 12:16:18 2022 +0530
dht: Resolve double free in function dht_common_mark_mdsxattr_cbk (#3199)
During fresh lookup for directory dht set and heal mds xattr on the directory.
The function dht_common_mark_mdsxattr_cbk is trying to destroy frame->root
even the same frame is passed to the function(dht_selfheal_dir_setattr) to
heal the xattr.Ideally we have this bug from the day when a feature was
implemented but the bug is not caught till today.After move on tcmalloc
it was easily caught and a client process was crashed.It depends memory
allocator behavior and we can't expect every time an allocator should crash.
As per free man page the behavior is undefined in case if ptr has already
been called before so it was expected.
Solution: After call dht_selfheal_dir_setattr return 0 to avoid stack cleanup.
> Change-Id: I6a6c3aff1b9984ee764948c754731574433b1d28
> Updates: #3191
> Credits: Xavi Hernandez xhernandez@redhat.com
> Signed-off-by: Mohit Agrawal moagrawa@redhat.com
> (Reviewed on upstream link #3192)
> (Cherry-pick from commit 2c85059)
Change-Id: I04d944c78cd03f60842576807ea2bf0cffc3cb9f
Updates: #3191
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 52d2c12e96e72fd228a5ce2a5560cfff5a36d734
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Tue Jan 18 22:33:25 2022 +0530
Add GlusterFS 10.1 release notes (#3129)
* Add GlusterFS 10.1 release notes
Updates: #3099
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
* Add #3133 to GlusterFS 10.1 release notes
* Update 10.1.md
* Update 10.1.md
* Add #2962 to GlusterFS 10.1 release notes
commit 9cffdc486cdca0a0a6348a134525a48dc8e1882c
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Jan 18 11:45:23 2022 +0100
libglusterfs: Set errno on integer parse failure (#3125)
The _gf_string2long() function didn't set the errno code correctly
when the parsed string started by a number but wasn't really a
number, like a numeric IP address for example.
This patch ensures the errno is properly set before returning an
error.
Fixes: #2962
Change-Id: I33e6f75201da8bfc5c76089d8b30f1e3c0214857
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 047c95f72e87e9be56a0c8dfca9ab81766048457
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Mon Jan 17 11:40:40 2022 +0530
glusterd: add stripe_count in volume info (#3070) (#3133)
* glusterd: add stripe_count in volume info
Change-Id: Ib04434b41b7c299cee0ed8d81deb5a68a17b0c0a
Fixes: #3066
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
* Add stipe-count only if version is less than 10
Change-Id: Ibb589df2bb4c00c71850d787c998aff746321a17
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit a804f8eef5fad0bc5fe835b1c08be1c02df9151a
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Mon Jan 10 14:57:19 2022 +0530
geo-rep: AttributeError: 'list' object has no attribute 'join' (#3102)
Probelm: prelude.join(' ') operation is performed to
convert prelude(which of list data type) into a string.
This is erraneous as we cannot perform join on a list:
Traceback (most recent call last):
File "/usr/libexec/glusterfs/python/syncdaemon/gsyncd.py", line 332, in main
func(args)
File "/usr/libexec/glusterfs/python/syncdaemon/subcmds.py", line 60, in subcmd_monitor
return monitor.monitor(local, remote)
File "/usr/libexec/glusterfs/python/syncdaemon/monitor.py", line 431, in monitor
return Monitor().multiplex(*distribute(local, remote))
File "/usr/libexec/glusterfs/python/syncdaemon/monitor.py", line 390, in distribute
svol = Volinfo(slave.volume, "localhost", prelude, master=False)
File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 921, in init
via = '(via %s) ' % prelude.join(' ')
AttributeError: 'list' object has no attribute 'join'
Solution: we should perform ' '.join(prelude).
This will serve the purpose of converting prelude
into a string, and continue to support the
existing logic.
Added code change to support the same.
Fixes: #2903
Change-Id: I29c8523ad78a31e68ef473df7c579950664c5184
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 8a2aeaeb77420e7ca941a5e8ea7fe8010ea5a5d7
Author: Amar Tumballi <amar@kadalu.io>
Date: Fri Jan 7 18:43:59 2022 +0530
dict: handle excessive log in case dict is NULL in some path (#3086) (#3087)
* dict: handle excessive log in case dict is NULL in some path
Fixes: #3071
Change-Id: I01cbda322238ef3429fa46c485a86cfd1d950099
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 5f5d24c87da7ae23db8c69656b9450d8372ec1d9
Author: Nikhil Ladha <nladha@redhat.com>
Date: Fri Jan 7 18:38:07 2022 +0530
gluster: Removed the deprecated log commands from gluster man page (#2942) (#3019)
Description:
The log commands in the gluster man page still has
the `volume log locate` and `volume log filename` commands
which are deprecated and not available anymore.
Fix:
Removed those deprecated commands and fixed the `volume log rotate`
command.
Updates: #2939
> Fixes: #2939
> Change-Id: Ica55aa3f532fbfbb7bda8adbbfe20443f4f8464b
> Signed-off-by: nik-redhat <nladha@redhat.com>
Change-Id: I314859e4868b0703365d33b2023df44ac0e45445
Signed-off-by: nik-redhat <nladha@redhat.com>
commit b035b8b0009ccff69d2b25defe6e44413320655a
Author: Nikhil Ladha <nladha@redhat.com>
Date: Fri Jan 7 18:32:41 2022 +0530
glusterd: Updated the log level to DEBUG for redundant logs (#2887) (#3017)
*Description:*
The `dict get failed` log msgs of the options
`cluster.server-quorum-type` and `cluster.server-quorum-ratio`
where redundant considering the fact that these options are only
availbale in the volume info when they are manually set by the user
for a volume.
Updates: #2846
> Fixes: #2846
> Change-Id: If5c7690b5e6605c154ac962cbfff9b4321388989
> Signed-off-by: nik-redhat <nladha@redhat.com>
Change-Id: I91ebba939b1c59589a73c89e4e04a64fe16baf92
Signed-off-by: nik-redhat <nladha@redhat.com>
commit a244933aa410c1a419663bd35b14b09b9e8f7f0f
Author: Nikhil Ladha <nladha@redhat.com>
Date: Fri Jan 7 18:32:02 2022 +0530
glusterd: Added a check for available ports in the port_range (#3015)
**Issue:**
After the latest update to use randomized ports, if all ports
till the max-port value in the glusterd.vol are occupied then,
volume start doesn't fails with the error that "All ports are
exhausted", rather it hangs. The reason is there ins't any check
in the function `pmap_port_alloc` to check for the occupied ports
within the permissible range and the loop goes on infinitely.
**Fix:**:
Added a check for the available ports within the max-port range
and fail with correct error msg (already implemented) if all ports
are occupied.
Updates: #2910
>Fixes: #2910
>Change-Id: I862822ce573c8b78cf0fb5dd2db95667aa4581d3
>Signed-off-by: nik-redhat <nladha@redhat.com>
Change-Id: I3b5a6b985a5d5010be238585edde687b745dc8c5
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 1e0732d927905ae36df2380d0e913775e59319c3
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Jan 7 18:12:27 2022 +0530
ec: IO failure when shrinking dispersed volume during io running (#2948) (#2951)
* ec: IO failure when shrinking dispersed volume during io running
IO Failures are found when performing a shrink operation on a
distributed-dispersed volume, while IO is in progress.
RCA: During rebalance operation execution while layout has changed
dht_creaete_cbk retry create operation under lock in 2nd attempt.
It takes decision based on error set by posix_create in xdata
in first attempt. ec(ec_manager_create) does not pass xdata to the
upper xlator so dht_create is not able to take decision to
reattempt fop creation in case if layout has changed and throw
an EIO error.
Solution: Pass the xdata to the upper xlator to avoid an issue.
> Fixes: #2947
> Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
> (Cherry picked from commit f81bf52a9b00a3436128a3ba0672159c5d61a7cb)
> (Reviewed on upstream link https://github.com/gluster/glusterfs/pull/2948)
Fixes: #2947
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit bf4352dab52cc8c371cfef0cf88386501d26c32e
Author: Nikhil Ladha <nladha@redhat.com>
Date: Fri Jan 7 18:01:44 2022 +0530
glusterd: Update cutom log directory option (#2957) (#3020)
**Description:**
Currently option `cluster-test-mode` was used to set
a user-defined logging directory for gluster related logs which
doesn't seem to be an appropriate name for the option.
**Fix:**
Updated the option to be `logging-directory` keeping in mind the
naming convention of other options like `working-directory`,
`run-directory`.
**NOTE:**
This option doesn't updates the path for cli and glusterd log file,
that still needs to be set manually via command line or through the
sysconfig file.
Updates: #2939
> Updates: #2939
> Change-Id: I5fbbeff21ea1a89d439537311a81389b57e7acde
> Signed-off-by: nik-redhat <nladha@redhat.com>
Change-Id: I137b0aa529f17c6bf95018db6ad28fbfd8681e75
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 05b48a44eeeb2c5b3000c144c3ee630c7c86162c
Author: mohit84 <moagrawa@redhat.com>
Date: Thu Dec 23 09:53:08 2021 +0530
configure: Enable ltcmalloc_minimal instead of ltcmalloc (#3000)
The gluster process is getting crashed while ltcmalloc library
init/fini related functions are called in two different
threads during a library loaded/unloaded.The process is getting
crashed during access of tls variables in heap profiler
api. Though the issue is already fixed(gperftools/gperftools#786)
in gperftool-9 but the rpm has not been build for rhel-(7|8).
The heap profile api is access by an application while application is linked with libtcamlloc.
Solution: To avoid a crash linked library with ltcmalloc_minimal
> Fixes: #2971
> Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
> (Cherry picked from upstream https://github.com/gluster/glusterfs/pull/2994)
Fixes: #2971
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 5a0319abff2e190f8f2df3756f14f7d0ad14b7ee
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Fri Oct 29 14:32:03 2021 +0530
Add GlusterFS 10.0 release notes (#2911)
Change-Id: Idaae5b31ebda9ebfdc5d61ed545d8341fc57d8f7
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 387fcb01e2a47a848462ae6835ab8b04b60d9c73
Author: Amar Tumballi <amar@kadalu.io>
Date: Mon Oct 18 19:27:26 2021 +0530
fuse: handle pid 0 (#2468)
* There was no clue on which operation caused the pid to be '0' - Added relevant op in log.
* When the error happened without setting ngroups, it crashed the process.
* Looks like in container usecases, when namespace pid is different, there are chances of
fuse not getting proper pid, hence would have it as 0. Handled the crash, and treated it
as 'root' user.
Fixes: #2467
Change-Id: Ic3a4561f73947c4acfeef40028c3a6cf3975392e
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 438b844e357d5dbc99a49ee160048548cb1d638c
Author: mohit84 <moagrawa@redhat.com>
Date: Mon Oct 18 16:09:26 2021 +0530
test: the test case tests/basic/0symbol-check.t is failing (#2866)
The test case is throwing below error
./glusterfsd/src/gf_attach.o should call sys_lstat, not lstat
./libglusterfs/src/.libs/libglusterfs_la-gf-io-uring.o should call sys_close, not close
Solution: Call sys_(lstat|close) to avoid an error
Fixes: #2865
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 5189d19280d10f0cfbb0853dac942e1b0dc48ab3
Author: Nikhil Ladha <nladha@redhat.com>
Date: Mon Oct 18 11:02:55 2021 +0530
Maintainers Update: Management Daemon -glusterd (#2867)
Hello Maitainers, requesting permission to be a peer in
the management daemon component. I have been actively helping
and looking after issues around glusterd, cli and will
continue to do so in future as well.
Change-Id: I253e411513bb42dd7e7cea4c4f54f1f9acb13d7f
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 9cdefcf63238d0528bce0209b007db173426c10f
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Oct 14 11:06:34 2021 +0300
mem-pool: remove unneeded atomic counters (#2757)
They don't seem to be used, but they are incremented and
decremented in the 'hot' paths. Just removed them.
Next patch may be to move that single parameter left in the structure,
to reduce indirection.
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 9d1b8b8470fe89584f43e75c9f512596392e31cb
Author: mohit84 <moagrawa@redhat.com>
Date: Wed Oct 13 23:20:29 2021 +0530
test: test case bug-1702299.t is failing on centos-8 (#2864)
The test case is throwing "No such file or directory"
error while running stat after run add-brick operation.
Solution: Need to check brick_count after run add-brick to avoid an issue.
Fixes: #2862
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 65bd844b22a5c0b37c469c44fb920e69adbd63c9
Author: Tamar Shacked <tshacked@redhat.com>
Date: Wed Oct 13 11:23:15 2021 +0300
dht/posix: rename fop handle a case of a stale linkto to dst file (#2804)
Problem during rename(src, dst):
when a stale linkto for dst is present in the src cached-location,
link creation fails with EEXIST and returns to the user.
Fix:
In the rename-path use the FORCE_REPLACE key
for unlinking the stale file if it exists.
Updates: #1723
Change-Id: Id43ca4798ae72aada6a37cd92ec6ecfcf96006fe
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit d3af082a68df24f715670e84d0913125329aed64
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Mon Oct 11 23:15:12 2021 +0530
Doc: Developer session 13-15 (#2856)
These sessions cover replication xlator introduction, update, read
transactions along with normal fops both explanation and code
walkthrough
Change-Id: Ic895b02aa2a7021bd423f0b407ff90951ceebc69
updates: #2308
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 0f2b25ccd446699596056c97b6bde0a290281dc2
Author: XiJinyu <52778639+XiJinyu@users.noreply.github.com>
Date: Tue Oct 12 01:44:41 2021 +0800
nit: the "data" was used twice. (#2858)
dict_t *dict = data;
dict = data;
Change-Id: I578ce05dd5a18b62eac6632778e94044c028951b
Updates: #2857
Signed-off-by: Xi Jinyu <xijinyu_yewu@cmss.chinamobile.com>
commit de9fe49b38306f562e213b0913b672d5b40b9da9
Author: Saju <63098029+msaju@users.noreply.github.com>
Date: Wed Oct 6 22:56:07 2021 +0530
Added quick links (#2842)
Added quick links for various Gluster details like -
* Slack channel,
* mailing list,
* twitter,
* documentation (release notes, quick start guide, community)
* as well as daily nightly build status and coverity details.
Signed-off-by: msaju <sajmoham@redhat.com>
commit 5ce47c2d87b8456e910e233e6366bfeaead4e6ee
Author: mohit84 <moagrawa@redhat.com>
Date: Tue Oct 5 12:50:59 2021 +0530
mem_acct: Move size variable to debug build from mem_acct_rec (#2828)
The size variable does not necessary to debug mem leak from
mem_acct so move the variable for debug build.
Updates: #2771
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit daaa2b3a75d7290f5feb95fd1d0bca3f663a3e53
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Oct 1 14:52:53 2021 +0530
server: glusterfsd has memory leak while mount a subdir volume (#2826)
The do_path_lookup has leak while a client has tried to mount
a volume with subdir mount.During path lookup the function has
populated a loc_t object for every inode but it forgot to cleanup
loc_t object.
Solution: Cleanup loc_t object to avoid a leak
Fixes: #2816
Credits: wenxiaobao <1187873955@qq.com>
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 63dcb985a8ad7878def9e1e6fc4d32314eb3475f
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Oct 1 06:59:19 2021 +0530
dht: found anomalies in dht_layout (#2836)
In the recent commit c4cbdbcb3d02fb56a62effda7ff90ae97f89546c we
have changed the sorting alogorithm to qsort from selection sort
to sort the layout but the qsort comparison function has a bug.
Current dht_layout_entry_t has start/stop variable data type is
unit32_t and comparison function (dht_layout_entry_cmp) consider
difference of start/stop is integer so in case of overflow of value
the behavior of the comparison function chaged due to that layout
has not set first time.After found the anamaly the layout has been
set but performance has been reduced significantly.
Solution: Correct the data type in comparison function
(dht_layout_entry_cmp) to avoid an issue.
Fixes: #2835
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I1a9bf458757fdf07bd409b6eebad347427f33f1e
commit 5c3e1b9a040ef163440002fdca8ffa5f955bb123
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Wed Sep 29 10:20:50 2021 +0300
dht: use qsort to sort layout entries (#2807)
Drop weird sorting quirks and use standard qsort()
to sort DHT layout entries, simplify related code.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 21e6443751dd7126b8a52e1de7f18e81abfaf76e
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Tue Sep 28 12:35:15 2021 +0530
Coverity: API usage error (#2824)
Problem:
Lock is taken on prive->lock before initializing the variable
in function gf_quiesce_populate_failover_hosts() and in the later
stage it is being initialized.
CID: 1462030
Fix:
Initialize the priv->lock variable before trying to take a lock
in function gf_quiesce_populate_failover_hosts().
Change-Id: Id2450310b84fca407fe34af7c16e419829f2a2a0
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1060
commit f58c979855c322ea6eb91bd551a0850959a0e750
Author: ryancaicse <73822648+ryancaicse@users.noreply.github.com>
Date: Mon Sep 27 12:18:51 2021 +0800
Fix a bug due to the unreleased lock (#2823)
Fix a bug due to the unreleased lock in the upcall_cleanup_expired_clients
Updates: #2789
Signed-off-by: Ryan Cai <ryancaicse@gmail.com>
commit 6be68d69def6f50b2292dcf6b7f521f2274bc52e
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Mon Sep 27 07:17:56 2021 +0300
build: do not ignore compiler flags from an environment (#2822)
Do not ignore CFLAGS from the build environment when
checking for the function to set thread name. This is
important when the build environment passes flags which
changes PIC- and PIE-related code generation and linking
options.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Credits: Mohit Agrawal <moagrawa@redhat.com>
Updates: #1000
commit 5bc7fc03095749935dbd0c82c71977421093861f
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Sep 24 07:22:10 2021 +0530
mem_acct: Make mem_accounting lock free (#2797)
* mem_acct: Make mem_accounting lock free
The __gf_(c|m)alloc and __gf_free memory allocation api calls
gf_mem_set_acct_info function to save memory accounting
on xlator and to update the record it takes lock.During
testing we have observed the mem_acct mutex has contention.
Solution: To avoid contention make it lock free and the data
is available at github issue #2771
Updates #2771
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Credits: Xavi Hernandez <xhernandez@redhat.com>
Change-Id: I9ab2a2e5b7d64e98aad92cecaa3bebc914e0a55b
commit 3e663171de32ff51d7ff71efd5ee9fb4e293e433
Author: Sunil Kumar H G <sheggodu@redhat.com>
Date: Thu Sep 23 15:32:58 2021 +0530
[Coverity Fix] Use After free. (#2810)
CID: 1430119
Updates: #1060
Change-Id: If18fda9da38efed77d37be164218646fbb376440
Signed-off-by: Sunil Kumar H G <sheggodu@redhat.com>
commit b48e64cebcad958ac7ddf38ef4f20d011d1ed0e4
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Wed Sep 22 13:34:10 2021 +0300
cli: drop global RPC client contexts (#2767)
Embed glusterd and quotad RPC client context pointers
into CLI state instead of using global variables, adjust
related initialization functions and comments.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 6a14d2b3e33aa59e9b14bdbb4395fb529c3c2616
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue Sep 21 14:48:21 2021 +0300
afr: fix possible string buffer overflow and format truncation (#2786)
Fix -Wstringop-overflow and -Wformat-truncation warnings reported
as below, adjust related comments.
In file included from afr.c:18:
afr-common.c: In function ‘afr_serialize_xattrs_with_delimiter’:
afr-common.c:7519:19: warning: ‘strncat’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
7519 | buf = strncat(buf, xattr, str_len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
afr-common.c:7518:23: note: length computed here
7518 | str_len = strlen(xattr);
| ^~~~~~~~~~~~~
afr-common.c:7504:19: warning: ‘strncat’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
7504 | buf = strncat(buf, default_str, str_len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
afr-common.c:7503:23: note: length computed here
7503 | str_len = strlen(default_str);
| ^~~~~~~~~~~~~~~~~~~
afr.c: In function ‘afr_handle_anon_inode_options’:
afr.c:150:78: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
150 | snprintf(priv->anon_inode_name, sizeof(priv->anon_inode_name), "%s-%s",
| ^
afr.c:150:9: note: ‘snprintf’ output between 28 and 257 bytes into a destination of size 256
150 | snprintf(priv->anon_inode_name, sizeof(priv->anon_inode_name), "%s-%s",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
151 | AFR_ANON_DIR_PREFIX, volfile_id_str);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit b980af7853198783987087c262a475c778eafe3d
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Mon Sep 20 10:11:35 2021 +0300
build, libglusterfs: detect function to set thread name (#2791)
Avoid hardcoded OS-specific #ifdefs and attempt to detect
OS-specfic function to set thread name, move platform-
dependent quirks to '__gf_thread_set_name()' and use it
where appropriate.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 56032141312900df8f993a7ef9c2f60e609c7e3a
Author: Ravishankar N <ravishankar.n@pavilion.io>
Date: Mon Sep 20 11:07:19 2021 +0530
MAINTAINERS: Change my communication email-id (#2800)
Change-Id: I7bb4f145f93605cfaf49564d5d24dce6114494f9
Updates: #1002
Signed-off-by: Ravishankar N <ravishankar.n@pavilion.io>
commit 103ff0b365edd18570c4bbfbadd743e6b23c3dc9
Author: Ravishankar N <ravishankar.n@pavilion.io>
Date: Mon Sep 20 09:56:58 2021 +0530
mount: expose the localtime-logging option to mount-helper (#2799)
...in order for it to be recognized as a valid option.
i.e. mount -t glusterfs $IP:$VOLUME -o localtime-logging /path/to/mount
Change-Id: I8859b31d92b54d1e0f877728a1bfff8b4ac37e56
Fixes: #2798
Signed-off-by: Ravishankar N <ravishankar.n@pavilion.io>
commit 491e9ec38bbfedf3caed52535b718efdc2dd6117
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Sep 17 20:06:31 2021 +0530
iobuf: Call standard allocation api in iobuf if page_size is less than equal to 128KB (#2792)
* iobuf: Call standard allocation api in iobuf if page_size is less than equal 128KB
During smallfile testing we have observed the performance
has been improved significantly in case while iobuf use standard
allocation api to allocate buffer while requested page_size is less
than or equal to 128KB.The performance data is available at the
github issue https://github.com/gluster/glusterfs/issues/2771
Change-Id: I9aebb19e15640aedea8c78efb366703dbdebb5fd
Updates: #2771
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 63bfdbc3d6829e0a6fff60ce8b21a8dd2f050ec3
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Thu Sep 16 20:21:54 2021 +0300
libglusterfs, xlators: add and use range info option flag (#2732)
Add OPT_FLAG_RANGE flag to denote the numerical volume option
with specified minimum and maximum values, display an allowed
range as a part of option's help text, and use new flag for
some threading-related options here and there. Adjust option
descriptions and comments as well.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 3067f544c2f1e7b30eb65d215ee466878326478e
Author: Pavel Matěja <lemrouch@users.noreply.github.com>
Date: Thu Sep 16 19:19:34 2021 +0200
Start when only IPv4 or IPv6 is available (#2784)
Fixes: #2782
commit ae85973e0fb81ff97219b53dbee9cd631048fa72
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Thu Sep 16 07:03:45 2021 +0530
geo-rep: Changelog History Crawl failure (#2768)
* geo-rep: Changelog History Crawl failure
Issue:
glusterfs-georep-upgrade.py is designed to be run
before the upgrade.
However, many users missed to run it before the
upgrade. When they ran it after the upgrade, following issue
was encountered:
Traceback (most recent call last):
File "./glusterfs-georep-upgrade.py", line 77, in <module>
modify_htime_file(args.brick_path)
File "./glusterfs-georep-upgrade.py", line 61, in modify_htime_file
shutil.copyfile(pth, os.path.join(path, changelog))
File "/usr/lib/python3.7/shutil.py", line 104, in copyfile
raise SameFileError("{!r} and {!r} are the same file".format(src, dst))
shutil.SameFileError: '/storage/glusterfs/guacamole/.glusterfs/changelogs/
2020/12/30/CHANGELOG.1609357688' and '/storage/glusterfs/guacamole/.glusterfs/
changelogs/2020/12/30/CHANGELOG.1609357688' are the same file
This happened because, new changelogs formed after the
upgrade were already in required directories, thus making
the source and destination same for shutil.copyfile
Solution:
Added exception handling for shutil.copyfile inorder to pass the
situation where source and destination are same.
Fixes: #2133
Change-Id: I3752ac304bd393f6b786bd67a63360f68bf8b8db
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
* Update glusterfs-georep-upgrade.py
commit 8e37df3092919f2ebb67309d06c7c77af6afa05a
Author: mohit84 <moagrawa@redhat.com>
Date: Wed Sep 15 18:34:38 2021 +0530
configure: Enable tcmalloc and disable mempool as a default option (#2787)
The data is already available on github issue(#2771)
specific to getting improvement after enable tcmalloc and
disable mempool so enable tcmalloc and disable mempool
as a default option.
Updates: #2771
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit db36432eece9cc849d896f7d77812507a250362e
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue Sep 14 09:25:59 2021 +0300
cli: fix a few memory use-after-free and leak errors (#2737)
Fix a few use-after-free error detected by ASan, for example:
==1089284==ERROR: AddressSanitizer: heap-use-after-free on address ...
WRITE of size 8 at 0x61100001ffd0 thread T2
#0 0x7fa6ab385633 in dict_unref libglusterfs/src/dict.c:798
#1 0x41664a in cli_cmd_volume_stop_cbk cli/src/cli-cmd-volume.c:564
#2 0x40f2d6 in cli_cmd_process cli/src/cli-cmd.c:133
#3 0x40e772 in cli_batch cli/src/input.c:29
#4 0x7fa6aae3e298 in start_thread (/lib64/libpthread.so.0+0x9298)
#5 0x7fa6aaa78352 in clone (/lib64/libc.so.6+0x100352)
0x61100001ffd0 is located 80 bytes inside of 224-byte region ...
freed by thread T2 here:
#0 0x7fa6ab732647 in free (/lib64/libasan.so.6+0xae647)
#1 0x7fa6ab43171a in __gf_free libglusterfs/src/mem-pool.c:362
#2 0x7fa6ab38559b in dict_destroy libglusterfs/src/dict.c:782
#3 0x7fa6ab38565e in dict_unref libglusterfs/src/dict.c:801
#4 0x40cd28 in cli_local_wipe cli/src/cli.c:783
#5 0x4165c4 in cli_cmd_volume_stop_cbk cli/src/cli-cmd-volume.c:562
#6 0x40f2d6 in cli_cmd_process cli/src/cli-cmd.c:133
#7 0x40e772 in cli_batch cli/src/input.c:29
#8 0x7fa6aae3e298 in start_thread (/lib64/libpthread.so.0+0x9298)
previously allocated by thread T2 here:
#0 0x7fa6ab732af7 in calloc (/lib64/libasan.so.6+0xaeaf7)
#1 0x7fa6ab430a91 in __gf_calloc libglusterfs/src/mem-pool.c:151
#2 0x7fa6ab382562 in get_new_dict_full libglusterfs/src/dict.c:84
#3 0x7fa6ab38268d in dict_new libglusterfs/src/dict.c:127
#4 0x415fcf in cli_cmd_volume_stop_cbk cli/src/cli-cmd-volume.c:501
#5 0x40f2d6 in cli_cmd_process cli/src/cli-cmd.c:133
#6 0x40e772 in cli_batch cli/src/input.c:29
#7 0x7fa6aae3e298 in start_thread (/lib64/libpthread.so.0+0x9298)
Thread T2 created by T0 here:
#0 0x7fa6ab6da8d6 in pthread_create (/lib64/libasan.so.6+0x568d6)
#1 0x40eb2b in cli_input_init cli/src/input.c:76
#2 0x40d0ee in main cli/src/cli.c:863
#3 0x7fa6aa99fb74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
Also tweak CLI_LOCAL_INIT() to take an extra reference to related
'dict_t' object and ensure correct reference counting sequence for
the most of CLI commands, which should follow the scheme below:
int
cli_cmd_xxx(...)
{
int ret = -1;
dict_t *options = NULL;
...
ret = cli_cmd_xxx_parse(..., &options); /* refcount 1 */
if (!ret)
goto out;
...
CLI_LOCAL_INIT(..., options); /* refcount 2 */
...
ret = proc->fn(..., options);
...
out:
CLI_STACK_DESTROY(...); /* refcount 1 */
if (options)
dict_unref(options); /* freed due to refcount 0 */
return ret;
}
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit f59a8faacfd92810c0d4ce2531dd95d5b8b858bc
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Sep 14 06:57:49 2021 +0200
io_uring: make fatal timeouts longer (#2769)
The hardcoded timeouts for initialization of io_uring where a bit
small for some cases, causing aborts that stopped the process.
To allow longer timeouts but without losing the information of a
slow initialization (which probably will translate in a slow operation
later), this patch defines a small timeout that will write a log
message each time it expires, but the initialization won't be aborted
until a specified number of retries have also timed out.
For now these values are still hardcoded, but using macros instead
of numbers in functions calls.
Change-Id: I8ec74f7715cb90ba70735a2fc8b7eb5fb14979de
Updates: #2123
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 2936241ea9940171cebcede16498852dd79061e7
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Sep 10 07:26:04 2021 +0530
Revert "libglusterfs: drop core infrastructure of memory pools (#2675)" (#2777)
In case of glibc_pool it is good to use glusterfs mempool so revert
the commit 9cd6735ff5d2f56f13078ac17743d1caa6db4267.
Change-Id: I780f0a1b7dae815becfd8c072735b6fdecb936f8
Updates: #1000
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 76fb94f5054282a07c56a617653da44d33a02246
Author: Tamar Shacked <tshacked@redhat.com>
Date: Thu Sep 9 17:35:13 2021 +0300
cli: fix coverity issue (#2766)
fixing null dereference reported by coverity
CID: 1462029
Updates: #1060
Change-Id: I2c42a677b02ea23da4d18d4c662a020f40081e03
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit 5f27f2294f731658779cd45d1305913d519a52d6
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Sep 7 09:38:35 2021 +0200
io_uring: fix signature of io_uring_enter() (#2770)
The signature of io_uring_enter() defined in the man page is not
correct. This patch fixes the signature by adding the last argument.
Change-Id: Ia6da98f04ba5f55fe19a3a0d21792cf9e7f5e7f1
Updates: #2123
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 20757666a51be0045c46906f1b15da2a776205a8
Author: JamesWSWu <34566858+JamesWSWu@users.noreply.github.com>
Date: Tue Sep 7 10:22:24 2021 +0800
Fixes:#2754 (#2759)
In order to solve the time-consuming problem of DNS caused by the non local node's hostname, cache the non local node's hostname.
The solution refers to the modification idea of #1663
It took up to 58 seconds to run the "gluster volume set "command before the code modification. The test case is as follows.
[root@paas-controller-1:~]$ time gluster --log-level=ERROR volume set ebf69045-0087-49df-bcd0-5e8b75288764 diagnostics.brick-log-level WARNING
volume set: success
real 0m58.209s
user 0m0.044s
sys 0m0.050s
It takes about 1 second after the code modification. The test case is as follows.
[root@paas-controller-1:~]$ time gluster --log-level=ERROR volume set ebf69045-0087-49df-bcd0-5e8b75288764 diagnostics.brick-log-level WARNING
volume set: success
real 0m0.660s
user 0m0.043s
sys 0m0.062s
Signed-off-by: JamesWSWu wu.shiwei@zte.com.cn
commit 3ca55e3032c248c1c0dc2e50fec56747f956ef6f
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sat Sep 4 10:47:19 2021 +0300
build: do not check for file existence when cross compiling (#2727)
Do not issue AC_CHECK_FILE([...]) when cross compiling
since this is explicitly rejected by configure script.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 2530de8ce5462b829d115dc381733a9518bfe533
Author: Tamar Shacked <tshacked@redhat.com>
Date: Sat Sep 4 10:46:48 2021 +0300
dht/posix: rename fop handle a case of a stale linkto's gfid (#2708)
Problem:
subvol-0: src located on the hashed subvol
subvol-1: stale linkto to src located on a non-hashed subvol (with a diff gfid)
During rename(src,dst): if a stale linkto to src is present in the dst
hashed, linkto creation (a stage in rename fop) fails with EEXIST.
Fix:
populate the MKNOD_REPLACE key for "forcing" posix the creation of the linkto with correct gfid.
Change-Id: I07f4df1b7028ce15eb65bb5d60df1d5375c5243e
Updates: #1723
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit 38f7a8ef9a5da7e8ab4b114b1d4939868bd44ed5
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sat Sep 4 10:43:54 2021 +0300
rpc, glusterd: drop tier leftover macro (#2709)
Since tiering feature is mostly dropped, GD_VOLUME_NAME_MAX_TIER quirk
is no longer needed and may be replaced with plain GD_VOLUME_NAME_MAX.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 3ffd07915f7b9e63f192a158f541307512a6b01e
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sat Sep 4 10:43:14 2021 +0300
glusterd: drop glusterd_op_sm_state_info_t and simplify related code (#2723)
Drop 'glusterd_op_sm_state_info_t' since its 'time' field is not
used anymore, adjust related code and comments here and there.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 77b9bf1034379a388b14d4fd92eec200fb074aac
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sat Sep 4 10:41:35 2021 +0300
cli: drop global state variable (#2753)
Drop 'global_state' and pass CLI state as a parameter
or indirectly via call frame or THIS where appropriate.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 368d5b5891339bad1de8461b4d2bf77585a9192b
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sat Sep 4 10:38:58 2021 +0300
glusterd, cli: more time_t usage where appropriate (#2749)
More time_t values for time intervals and timeouts,
drop weird is_valid_int() since strtol() is capable
enough to handle errors, adjust relevant comments.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 555ee014afcf1de07e3ef62b7eebb08cacd63041
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sat Sep 4 10:37:52 2021 +0300
glusterd: fix invalid pointer dereference during volume stop (#2740)
When handling RPC_CLNT_DISCONNECT event, glustershd may be already
disconnected and removed from the list of services, and an attempt
to extract an entry from empty list causes the following error:
==1364671==ERROR: AddressSanitizer: heap-buffer-overflow on address ...
READ of size 1 at 0x60d00001c48f thread T23
#0 0x7ff1a5f6db8c in __interceptor_fopen64.part.0 (/lib64/libasan.so.6+0x53b8c)
#1 0x7ff1a5c63717 in gf_is_service_running libglusterfs/src/common-utils.c:4180
#2 0x7ff190178ad3 in glusterd_proc_is_running xlators/mgmt/glusterd/src/glusterd-proc-mgmt.c:157
#3 0x7ff19017ce29 in glusterd_muxsvc_common_rpc_notify xlators/mgmt/glusterd/src/glusterd-svc-mgmt.c:440
#4 0x7ff190176e75 in __glusterd_muxsvc_conn_common_notify xlators/mgmt/glusterd/src/glusterd-conn-mgmt.c:172
#5 0x7ff18fee0940 in glusterd_big_locked_notify xlators/mgmt/glusterd/src/glusterd-handler.c:66
#6 0x7ff190176ec7 in glusterd_muxsvc_conn_common_notify xlators/mgmt/glusterd/src/glusterd-conn-mgmt.c:183
#7 0x7ff1a5b57b60 in rpc_clnt_handle_disconnect rpc/rpc-lib/src/rpc-clnt.c:821
#8 0x7ff1a5b58082 in rpc_clnt_notify rpc/rpc-lib/src/rpc-clnt.c:882
#9 0x7ff1a5b4da47 in rpc_transport_notify rpc/rpc-lib/src/rpc-transport.c:520
#10 0x7ff18fba1d4f in socket_event_poll_err rpc/rpc-transport/socket/src/socket.c:1370
#11 0x7ff18fbb223c in socket_event_handler rpc/rpc-transport/socket/src/socket.c:2971
#12 0x7ff1a5d646ff in event_dispatch_epoll_handler libglusterfs/src/event-epoll.c:638
#13 0x7ff1a5d6539c in event_dispatch_epoll_worker libglusterfs/src/event-epoll.c:749
#14 0x7ff1a5917298 in start_thread /usr/src/debug/glibc-2.33-20.fc34.x86_64/nptl/pthread_create.c:481
#15 0x7ff1a5551352 in clone (/lib64/libc.so.6+0x100352)
0x60d00001c48f is located 12 bytes to the right of 131-byte region [0x60d00001c400,0x60d00001c483)
freed by thread T19 here:
#0 0x7ff1a5fc8647 in free (/lib64/libasan.so.6+0xae647)
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 9cd6735ff5d2f56f13078ac17743d1caa6db4267
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sat Sep 4 09:32:48 2021 +0300
libglusterfs: drop core infrastructure of memory pools (#2675)
Separate memory allocation type tracking from core infrastructure of
memory pools and drop the latter alongside with '--disable-mempool'
configuration option, provide '--disable-allocation-tracking' to control
the former instead.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 21f1d246a9a6777cc95f541244ee142b3931bb9d
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Wed Sep 1 11:57:16 2021 +0300
build: use pkg-config to check whether readline is available
Use convenient PKG_CHECK_MODULES macro to check whether readline
library is present, drop specific check for rl_do_undo() since
it is available since ancient readiline 2.0 or maybe even older.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 9ae23a3bd713e5ee66f6c9bb814cb10e8b263100
Author: Paul Jakma <paul+github@jakma.org>
Date: Thu Sep 2 05:42:22 2021 +0100
mem-pool: Fix unaligned access causing fatal SIGBUS on sparc (#2669)
* mem-pool: Use a zero-length array to automatically get the best padding
Can put a ZLA at the end of the mem header to automatically get generally
the optimal padding at the end of the struct for the following data.
* mem-pool: Fix unaligned access causing fatal SIGBUS on sparc
The mem-pool code writes a trailer marker at the end of memory allocations
to sanity check for memory write over-runs. The code does not align the
marker on its required boundary though. Causing unaligned accesses.
Unaligned access may be just slower on some platforms, but on others it can
cause faults and abnormal exits. E.g., this was causing a SIGBUS on
Linux/SPARC64.
Possible approaches for a fix:
1. Round up the header+data size to the needed alignment for the
trailer.
2. Use byte-by-byte memory accesses to write and read the trailer.
Option 1 may sometimes leave a small gap between the end of the allocation
and the trailer, a gap where memory write overruns of the allocations would
not be detected by the trailer check. Additionally, Option 1 was found to
be slower than Option 2.
Discussion: https://github.com/gluster/glusterfs/pull/2669
So fix the trailer via option 2.
* mem-pool: re-order mem header struct to minimise padding
As per mykaul's suggestion, try re-arrange the struct to minimise padding.
Move the obviously larger types to earlier in the struct.
Updates: #1000
commit adbd412a1b61661c960c7963f7729f7e1f4f0918
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue Aug 31 08:13:51 2021 +0300
build: check for legacy RPC header if libtirpc is disabled (#2743)
Since modern Linux distributions tends to remove glibc RPC code,
for example https://fedoraproject.org/wiki/Changes/SunRPCRemoval,
using '--without-libtirpc' on such systems causes compilation
errors due to missing RPC headers. So here is a configure check
whether one of the legacy RPC core headers is present.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 325bb1e296db01f2f4547dfb8a9d17da6c4336f7
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Mon Aug 30 18:54:15 2021 +0530
glusterfs.spec.in: remove condtionals from tar dependency (#2734)
* glusterfs.spec.in: remove condtionals from tar dependency
The conditional on rhel minor version fails and tar is not
marked as required.
As there is not any universal macro to specify the
minor release, removing the conditionals above the
"Requires: tar" statement
with this change irrespective of rhel 8.3 and
above, tar will be marked required for geo-rep.
Change-Id: Id1e3320a0b1a245fc9cd8c7acb09cc119fca18b8
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
* Update glusterfs.spec.in
commit 006f3d4b2be76d7989747d452381073b892c1818
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Mon Aug 30 17:46:40 2021 +0530
cluster/afr: Avoid unnecessary new-entry-marking (#2627)
Problem:
afr is doing an xattrop to do new-entry-pending heals marking for files
that are created as part of heal. For this:
- Lookup on sink brick is done to check if the gfid exists or not
- If it is not present then sequentially new entry marking is done on
each of the source bricks before creating the file.
In most cases by the time afr detects that it needs to do new entry
marking, it would have already done a named lookup which would lead to
possession of the xattrs to make the decision without the lookup. If all
source bricks contain file with pending marking on the sink brick, there
is no need for new entry marking. This would save 3 sequential network
calls LOOKUP, 2 XATTROPs(In replica-3 or arbiter setup).
Fix:
If named lookup xattrs already have pending markers to the new entry
brick, then skip new entry marking.
fixes: #2626
Change-Id: Ife949fe6fe4e08408332bafd8f13baedcec1827a
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 35039253bac67be83ecf786c4ceb8aefd503e355
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Mon Aug 30 14:40:20 2021 +0300
libglusterfs, cli, rpc, xlators: consistently use time_t (#2710)
Tweak dict and xlator interfaces to allow explicit values of 'time_t' type
and consistently use it for timeouts, time intervals, and whatever similar.
Adjust related tests to prefer 0 over -1 for disabled timeouts.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit ac7a8f4dcf099a8f2775e8228af19fdc644dca11
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Wed Aug 25 17:38:06 2021 +0530
Doc: Developer session 11 (#2715)
This session covers entrylk part of locks xlator along with its
connection to inodelk in deletion code path.
updates: #2308
Change-Id: Ie52af7529b9a744f9352df589291cab6b794a125
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 2497f5260d37589fc6d71e04551fd146a37060a3
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Wed Aug 25 07:33:51 2021 +0530
tests: Test phase1 migration of dht operations (#2724)
Change-Id: I20e940c921a9990855ea5591212086ed64ed0ab2
commit 45dd5077507032a9073ebed419a6af8dc6dcdbf6
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue Aug 24 20:24:31 2021 +0300
libglusterfs, xlators: cleanup threading and timeout parameters (#2720)
Avoid hardcoded integers and lookalike string constants for the
threading and timeout parameters here and there, provide meaningful
macros and adjust related comments.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit bcf09403edd9b748081297ff7f1d21c4d158d887
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Fri Aug 20 16:53:52 2021 +0300
cli: do not allow to use help as the volume name (#2721)
Add 'help' to the list of unacceptable volume names because using
it as such silently confuses the most of CLI commands, for example:
$ gluster volume info
Volume Name: abcd
Type: Replicate
Volume ID: db862536-61da-404b-98c9-b5450eb1f80d
Status: Created
Snapshot Count: 0
Number of Bricks: 1 x 3 = 3
Transport-type: tcp
Bricks:
Brick1: 192.168.222.110:/home/pool/3
Brick2: 192.168.222.110:/home/pool/4
Brick3: 192.168.222.110:/home/pool/5
Options Reconfigured:
cluster.granular-entry-heal: on
storage.fips-mode-rchecksum: on
transport.address-family: inet
nfs.disable: on
performance.client-io-threads: off
Volume Name: help
Type: Replicate
Volume ID: 10442b69-18fa-4ad8-8dc9-3867c0598523
Status: Created
Snapshot Count: 0
Number of Bricks: 1 x 3 = 3
Transport-type: tcp
Bricks:
Brick1: 192.168.222.110:/home/pool/0
Brick2: 192.168.222.110:/home/pool/1
Brick3: 192.168.222.110:/home/pool/2
Options Reconfigured:
cluster.granular-entry-heal: on
storage.fips-mode-rchecksum: on
transport.address-family: inet
nfs.disable: on
performance.client-io-threads: off
$ gluster volume set abcd performance.cache-size 256MB
volume set: success
$ gluster volume set help performance.cache-size 256MB
volume set: failed
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit ccb97ee499ec5826fc5a3c49ff50d2693e4bfc03
Author: jifengzhou <85270487+jifengzhou@users.noreply.github.com>
Date: Fri Aug 20 14:47:56 2021 +0800
debug/io-stats: Modify the trusted.io-stats Usage description (#2591)
Fixes: #2590
Signed-off-by: Jifeng Zhou <z583340363@gmail.com>
Co-authored-by: Pranith Kumar Karampuri <pranith.k@gmail.com>
commit abff1d42c826ca09be64c9f8e5a55e13f9764671
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue Aug 17 15:05:58 2021 +0300
glusterd: cleanup defrag info (#2661)
Remove unused members of 'struct glusterd_defrag_info_'
and prefer 'gf_boolean_t' where appropriate.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 68e29953109f218326c0f6016dc8a60e1ece3fa7
Author: Cheng Lin <cheng.lin130@zte.com.cn>
Date: Fri Jul 23 14:20:21 2021 +0800
rpc: bind retry when EADDRINUSE
Socket release is asynchronous in kernel.
If failed with "already in use", better retry.
Fixes: #2649
Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
commit f834946c9970a11632805364787ee3fae6d40fba
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Mon Aug 16 08:50:13 2021 +0300
libglusterfs: annotate synctasks with valgrind API (#2505)
If '--enable-valgrind[=memcheck,drd]' is specified and API headers
are detected, annotate synctask context initialization and context
switch with valgrind API.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Fixes: #2075
commit 2924e99b577d2a2e29e5b84dec5bc9e13e710334
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Mon Aug 16 08:48:25 2021 +0300
build, xlators: cleanup configure and automake usage (#2695)
Define only GF_LINUX_HOST_OS and GF_DARWIN_HOST_OS as automake
conditions since others aren't used through Makefile.am files,
drop duplicated '-D$(GF_HOST_OS)' from changelog and cdc xlator
makefiles, detect zlib only once and tweak both cdc xlator and
glusterd to use zlib unconditionally.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit c521d1271ae10cadd3c8551e828b8e92a5961ac1
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Fri Aug 13 15:05:11 2021 +0300
libglusterfs, xlators: cache hostname in global context (#2679)
Call gethostname() at the very beginning of global context
initialization and then use the hostname where appropriate.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 88ac5202acd0a878b59992ae375b319beea1405e
Author: mohit84 <moagrawa@redhat.com>
Date: Wed Aug 11 19:43:56 2021 +0530
glusterd: auth.allow value is corrupted after add-brick operation (#2703)
glusterd_add_peers_to_auth_list function added peer names in auth.allow
list along with a user configured auth.allow and saved user configured
auth.allow as a old.auth.allow. After add brick ran successfully it
call glusterd_replace_old_auth_allow_list to swap the key and regenerate
a volume graph.The list is corrupted because during dict_del (auth.allow)
(and old.auth.allow) buffer is clean up and same buffer is used to
save a new key.
Solution: Save auth.allow and old.auth.allow as a key after calling the
function dict_set_dynstr_with_alloc, the fuction allocate a new buffer
to save a key value in dictionary.
Fixes: #2625
Change-Id: I359bf906d3521f1644db6b16948c62198a58ac93
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 22eed34454b7b4f82fd8dbddb843e24f02065212
Author: nik-redhat <nladha@redhat.com>
Date: Fri Jul 9 11:35:22 2021 +0530
firewall: Updated the range of open ports by firewall
Issue:
The ports for brick process are now randomized and doesn't do a
sequestial probing from 49152 to the max-port. Hence, if the port number
outside the allowed range of the firewall is alloted to the brick, there
can be connectivity issues.
Fix:
Updated the range to allow all the ports(upto the max-port) for gluster
bricks, in firewall service file.
Note:
I am aware this is not the best security practice, but to have a failure
proof sceanrio this needs to be done. The user can always modify the max
range of ports manually after installing gluster, if they want to.
Fixes: #2515
Change-Id: Ib48c6bfba0ecbf995c07e4690eb9a0a718433718
Signed-off-by: nik-redhat <nladha@redhat.com>
commit a3623fec8fa8ee0c042d227901a9bde7d7e115f2
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Fri Aug 6 19:05:05 2021 +0530
tests/georep: replace find command with file path (#2692)
find / -type f -name glusterfs-georep-upgrade.py
with exact path of the file for better clarity
and performance.
Change-Id: Id4c9061312c2996076fda1ede20af2cfb2849a24
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 2c38de5432dd0dd811980a82656606e43d8723ab
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Aug 6 06:08:58 2021 +0530
dht: dht_local_wipe is crashed while running rename operation (#2694)
dht_local_wipe is crashed while dht is winding a rename_dir
operation if some of the subvol has killed.The dht_local_wipe
is crashed during cleanup of ret_cache due to ret_cache corrupted
by dht_rename_dir function at the time of updating the status.
Solution: Check the subvol_cnt (index) it should be positive to
avoid a buffer corruption.
Change-Id: I84775e2a436c3f08e068d2c8925d3369a2872c0b
Fixes: #2693
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 40378ec11bc26e0c30f2eddab3f9aa77e6bf1229
Author: Yoann Laissus <yoann.laissus@gmail.com>
Date: Thu Aug 5 15:24:51 2021 +0200
Fix broken gf_history_b_search with geo replication (#2400)
For some weird reasons, sometimes the last entries of the htime file don't match the index value from the trusted.glusterfs.htime xattr.
So if we try to search a value from an out of bound index in the file, it returns the end index because of a wrong check.
commit 7ca5f0668bd0db3a591c43afcb3a8323137391c1
Author: renlei4 <ren.lei4@zte.com.cn>
Date: Thu Aug 5 12:50:17 2021 +0800
glusterd: reset mgmt_v3_lock_timeout after it be used (#2687)
Problem:
in mgmt v3, lock will be released after 3 minutes by default.
for those commands which will take more time, it can recieve
a timeout parameter instead of the default 3 minutes.
but commit 91cbcd1 broke this method, reset timeout before it be used.
so that lock release timeout is always 3 minutes.
Solution:
reset mgmt_v3_lock_timeout to default after it be used.
fixes: 91cbcd1 glusterd-locks: misc. changes
Signed-off-by: Ren Lei <ren.lei4@zte.com.cn>
commit f73b84f018339d3d233d2880ddf1c25125100524
Author: mscherer <mscherer@users.noreply.github.com>
Date: Tue Jul 27 15:56:31 2021 +0200
Use gzip for the logs (#2665)
Since that's mostly text files, that would compress well, and help
using less disk on the builders.
Fixes: #2664
Signed-off-by: Michael Scherer <misc@redhat.com>
commit c3b960e2cd7914230a45d904b7a6115a029930bb
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Tue Jul 27 19:24:07 2021 +0530
nl-cache: add test for symbolic link (#2657)
Updates: #1052
Change-Id: I8737d4cb7116c76ef4ec45dc4092166e46aa3a14
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 39307b7a06fd372cafc893fb1025a82532413416
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Jul 27 10:26:13 2021 +0530
afr: check for valid iatt (#2660)
Problem:
If the entry being processed by afr_shd_anon_inode_cleaner() is no
longer present, gfid lookup fails with ENOENT on all bricks and iatt
will never be assigned, causing a crash due to null dereference.
Fix:
Add a null-check for iatt.
Fixes: #2659
Change-Id: I6abfc8063677861ce9388ca4efdf491ec956dc74
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 42c48c767609a5077a34160cff947f0549148f2c
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Jul 27 06:55:46 2021 +0200
configure: Honor --disable-linux-io_uring option (#2651)
When --disable-linux-io_uring was used, only the liburing support
was disabled. Raw io_uring components inside the I/O framework were
still compiled in.
Now, when this option is specified, both raw io_uring access and
liburing are disabled.
Change-Id: Id9f73333a34a96a3f0b28b677097c122e5dfccbd
Updates: #2123
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit ef54f3d96e22c3b8433ccc2c95c2c315d8ce8cd8
Author: schaffung <ssivakum@redhat.com>
Date: Mon Jul 26 19:06:03 2021 +0530
Renaming deprecated message id in *-messages.h (#2658)
With the pump xlator now not part of code, renaming
the concerned message IDs as DEPRECATED_<current_name>
Fixes: #2652
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit e9b5671c50eba5802926640966a6056799828b72
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Sun Jul 25 09:42:01 2021 +0530
Doc: Developer session 10 (#2643)
This session covers locks xlator introduction and inodelk code
walk through.
updates: #2308
Change-Id: Id583af4a29b67fd44d72d81ec11ffe5c4d5b1bc4
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit bcd4591e39e822ae871fb77bb34976da97a36398
Author: schaffung <ssivakum@redhat.com>
Date: Sun Jul 25 09:41:15 2021 +0530
[Cleanup] Pump xlator deadcode removal (#2653)
Removing the function being invoked during brick addition
and replacement -> brick_graph_add_pump. This function fails
due to non-availability of the key `enable-pump`. On analysis
as well as checking with maintainers, it is found that this
is remenant of an old xlator called pump.
Hence this patch removes this function, its reference in the
server_graph_table as well as some macros and comments related
to pump.
Now we do have a function called posix_handle_pump in posix. But that
is not related to this pump xlator.
Fixes: #2652
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit 2f2787a0a35affaaa4f1b987d12fb2cbc5ca6a7b
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Tue Jul 20 14:24:53 2021 +0530
line-coverage: Improve glusterd line coverage (#2615)
Problem:
The current glusterd-coverage.t case has a syntax error for
replace-brick test cases, which will prevent it from covering
other failure code paths which are intended by the tests.
Fix:
1. This patch fixes the syntax error so that it will hit different
failure paths in multiple glusterd files.
2. Added a negative test to improve the reste-brick coverage.
Change-Id: I077b7a3738949e0d86c4e826fa3dd302ea326b6c
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1052
commit 5f1277ba7e2435c75d43da54d37a4fe0988e10c9
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue Jul 20 11:53:47 2021 +0300
libglusterfs: avoid mutex reinitialization (#2504)
Found with 'valgrind --tool=drd':
Mutex reinitialization: mutex 0x53e3928, recursion count 0, owner 0.
at 0x4850666: pthread_mutex_init_intercept (drd_pthread_intercepts.c:831)
by 0x4850666: pthread_mutex_init (drd_pthread_intercepts.c:840)
by 0x493696C: __event_slot_alloc (event-epoll.c:122)
by 0x4936B49: event_slot_alloc (event-epoll.c:157)
by 0x49372BF: event_register_epoll (event-epoll.c:391)
by 0x48F4D3B: gf_event_register (event.c:63)
by 0x16D8841A: socket_listen (socket.c:3748)
by 0x49E013A: rpc_transport_listen (rpc-transport.c:424)
by 0x49DBD01: rpcsvc_create_listener (rpcsvc.c:1991)
by 0x49DC046: rpcsvc_create_listeners (rpcsvc.c:2075)
by 0x168DE134: init (glusterd.c:1837)
by 0x48B9A13: __xlator_init (xlator.c:612)
by 0x48B9B52: xlator_init (xlator.c:637)
mutex 0x53e3928 was first observed at:
at 0x4850666: pthread_mutex_init_intercept (drd_pthread_intercepts.c:831)
by 0x4850666: pthread_mutex_init (drd_pthread_intercepts.c:840)
by 0x49366AD: __event_newtable (event-epoll.c:55)
by 0x4936815: __event_slot_alloc (event-epoll.c:92)
by 0x4936B49: event_slot_alloc (event-epoll.c:157)
by 0x49372BF: event_register_epoll (event-epoll.c:391)
by 0x48F4D3B: gf_event_register (event.c:63)
by 0x16D8841A: socket_listen (socket.c:3748)
by 0x49E013A: rpc_transport_listen (rpc-transport.c:424)
by 0x49DBD01: rpcsvc_create_listener (rpcsvc.c:1991)
by 0x49DC046: rpcsvc_create_listeners (rpcsvc.c:2075)
by 0x168DE134: init (glusterd.c:1837)
by 0x48B9A13: __xlator_init (xlator.c:612)
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 812c3175a96eab5c6b00188d9f96486e6d2e5f9e
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Tue Jul 20 14:20:12 2021 +0530
coverity: Uninitialized scalar variable (#2636)
Probem:
In gf_io_thread_pool_start() if it fails to create threads there is
a chance that the variable 'pending' will have some garbage value
since it is not initialized.
CID: #1458456
Fix:
Set value to the variable 'pending' if gf_io_thread_create() fails,
before jumping to done_sync.
Change-Id: Ib326dd7493bd4e27eb0be5b836f20ee0828c3e73
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1060
commit ecc99cc5249e0451fdf16be597cf38ee97fe461f
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Mon Jul 19 15:37:02 2021 +0200
locks: Fix null gfid in lock contention notifications (#2553)
This patch fixes 3 problems:
First problem:
After commit c0bd592e, the pl_inode_t object was also created in the
cbk of lookup requests. Lookup requests are a bit different than any
other request because the inode received may not be completely
initialized. In particular, inode->gfid may be null.
This caused that the gfid stored in the pl_inode_t object was null in
some cases. This gfid is used mostly for logs, but also to send lock
contention notifications. This meant that some notifications could be
sent with a null gfid, making impossible for the client xlator to
correctly identify the contending inode, so the lock was not released
immediately when eager-lock was also enabled.
Second problem:
The feature introduced by c0bd592e needed to track the number of
hardlinks of each inode to detect when it was deleted. However it
was done using the 'get-link-count' special xattr on lookup, while
posix only implements it for unlink and rename.
Also, the number of hardlinks was not incremented for mkdir, mknod,
rename, ..., so it didn't work correctly for directories.
Third problem:
When the last hardlink of an open file is deleted, all locks will be
denied with ESTALE error, but that's not correct. Access to the open
fd must succeed.
The first problem is fixed by avoiding creating pl_inode_t objects
during lookup. Second and third problems are fixed by completely
ignoring if the file has been deleted or not. Even if we grant a
lock on a non-existing file, the next operation done by the client
inside the lock will return the correct error, which should be enough.
Fixes: #2551
Change-Id: Ic73e82f6b725b838c1600b6a128ea36a75f13253
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 186cb7ad2043c8e1accda78798d881c0ce86bea6
Author: chenglin130 <35245387+chenglin130@users.noreply.github.com>
Date: Mon Jul 19 12:59:08 2021 +0800
mount: no mount over /tmp (#2567)
Accessing /tmp appears in mount process, should not mount
glusterfs over /tmp.
Otherwise, the thread will hang. And result in other problems
because the inaccessable /tmp.
Fixes:#2565
Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
commit 46893769145a7b3d79122a2c6caa0c34c2313f08
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Mon Jul 19 07:57:50 2021 +0300
libglusterfs: remove dead monitoring code (#2593)
Drop dump_global_memory_accounting() since
MEMORY_ACCOUNTING_STATS was dropped as well.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit f4fdeaff06ef21a90132bcffd44186ffb375ea3f
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Mon Jul 19 10:27:10 2021 +0530
cluster/afr: Use tie-breaker-inodelk for metadata heal (#2633)
Problem:
Metadata heal uses normal inodelk. If 2 metadata heals are triggered on
the same file, one progresses after the other leading to extra delay and
an unnecessary lookup only to find there is nothing to heal.
Fix:
Use tie-breaker inodelk so that only 1 heal takes the responsibility to
complete heal.
Change-Id: I9537cc2de19ae37c77b91a1a7f4bfb4cc8bcd3e3
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit d61dd979ae871bda74b811d79c4e3cf9cfa8a337
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Mon Jul 19 06:56:18 2021 +0200
md-cache: fix integer signedness mismatch (#2619)
md-cache uses a mechanism based on a generation number to detect
modifications made by other clients to the entries and invalidate
the cached data.
This generation number is a 32 bit integer. When it overflows,
special management is done to avoid problems. This overflow condition
is tracked with a single bit.
For many fops, when they are received, the overflow bit and the
current generation number are recorded in a single 64-bit value
which is used later in the cbk.
This is the problematic function:
uint64_t
__mdc_get_generation(xlator_t *this, struct md_cache *mdc)
{
uint64_t gen = 0, rollover;
struct mdc_conf *conf = NULL;
conf = this->private;
gen = GF_ATOMIC_INC(conf->generation);
if (gen == 0) {
gf_log("MDC", GF_LOG_NOTICE, "%p Reset 1", mdc);
mdc->gen_rollover = !mdc->gen_rollover;
gen = GF_ATOMIC_INC(conf->generation);
mdc->ia_time = 0;
mdc->generation = 0;
mdc->invalidation_time = gen - 1;
}
rollover = mdc->gen_rollover;
gen |= (rollover << 32);
return gen;
}
'conf->generation' is declared as an atomic signed 32-bit integer,
and 'gen' is an unsigned 64-bit value. When 'gen' is assigned from
a signed int, the sign bit is extended to fill the high 32 bits of
'gen'. If the counter has overflown the maximum signed positive
value, it will become negative (sign bit = 1).
In this case, when 'rollover' is later combined with 'gen', all the
high bits remain at '1'.
This value is used later in 'mdc_inode_iatt_set_validate' during
callback processing. The overflow condition and generation numbers
from when the operation was received are recovered this way:
rollover = incident_time >> 32;
incident_time = (incident_time & 0xffffffff);
('incident_time' is the saved value from '__mdc_get_generation').
So here rollover will be 0xffffffff, when it's expected to be 0
or 1 only. When this is compared later with the cached overflow
bit, it doesn't match, which prevents updating the cached info.
This is bad in general, but it's even worse when an entry is not
cached and 'rollover' is 0xffffffff the first time. When md-cache
doesn't have cached data it assumes it's everything 0. This causes
a mismatch, which sends an invalidation request to the kernel, but
since the 'rollover' doesn't match, the cached data is not updated.
So the next time the cached data is checked, it will also send an
invalidation to the kernel, indefinitely.
This patch fixes two things:
1. The 'generation' field is made unsigned to avoid sign extension.
2. Invalidation requests are only sent if we already had valid cached
data. Otherwise it doesn't make sense to send an invalidation.
Fixes: #2617
Change-Id: Ie40e68288cf143e1bc1a40f46da98f51bb2d6864
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 383d4f1fa1877ef0fee0cb1752de0c9c99d87e80
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Mon Jul 19 07:55:52 2021 +0300
libglusterfs: drop unused directory reading support code (#2629)
Drop unused 'GF_DIR_ALIGN()' macro and 'dirent_size()' function.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 6e1cc48967c5a89a41c0001d8438edd3558bda17
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Mon Jul 19 10:24:45 2021 +0530
protocol/server: Honor don't care in resolution (#2635)
When a lookup on a gfid comes, if the inode corresponding to gfid is not
present in the inode table, then both resolution and actual lookup fops
will do lookups which is redundant. I found that entry lookup prevents
this by honoring RESOLVE_DONTCARE part in resolution where as the same
check is not present in resolving inode. We need to add that to reduce
the number of lookups in case of some operations like Self-heal.
Change-Id: I00599e79c0ec0a2628de211aa614717c09fcc06f
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit b1be7209c6984021ad62b60ea2ad390b3643b79c
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Mon Jul 19 09:45:09 2021 +0530
protocol/server: Don't resolve parent gfid if already resolved (#2621)
Problem:
server_resolve_entry() does LOOKUP on parent directory even when the
pargfid is already resolved. Then it proceeds to do LOOKUP on the name.
Fix:
If the parent directory is already resolved, do LOOKUP only on the name.
fixes: #2620
Change-Id: I6fd2ee4e1b985018397687ef3cbf4bf44890e2b9
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 1164ba0fda92fa3c251538b1ca14af4def5a5560
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Jul 16 10:29:07 2021 +0200
io_uring: fix compilation issues with older glibc
Some glibc versions don't contain all io_uring definitions needed to
compile the code.
A compatibility include has been created to define the missing values,
if any. Gluster's io_uring implementation dynamically detects the
kernel support and available features, so this patch doesn't change
any functionality.
Change-Id: Ie6e0cc6b89deded527cc091b41a91754a5332eaf
Updates: #2123
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 6ce5f18a2dc172218896d1f71c791fd7406e2789
Author: jifengzhou <85270487+jifengzhou@users.noreply.github.com>
Date: Fri Jul 16 18:31:19 2021 +0800
features/locks: Remove common.c duplicate code (#2584)
The add_locks function has already called __insert_and_merge once,
so the repeated calls are deleted
Fixes: #2502
Signed-off-by: Jifeng Zhou <z583340363@gmail.com>
commit 44d18cfb6c3e8382da146a18382579b2e0ed1128
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Fri Jul 16 12:24:33 2021 +0530
cluster/afr: Don't check for stale entry-index (#2612)
Problem:
In every entry index heal there is a check to see if the
index is stale or not.
1. If a file is created when the brick is down this
will lead to an extra index lookup because the name is not stale.
2. If a file is deleted when the brick is down this will also lead to
and extra index lookup because the name is not stale.
3. If a file is created and deleted when the brick is down then the
index is stale and this will save entry-heal i.e. 2 entrylks and 2 lookups
Since 1, 2 happen significantly more than 3, this is a bad tradeoff.
Fix:
Let stale index be removed as part of normal entry heal detecting 'the
name is already deleted' code path.
fixes: #2611
Change-Id: I29bcc07f2480877a83b30dbd7e2e5631a74df8e8
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 927b0f6ed52222a58ab0e7f1beffa33ba76682cb
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Jul 15 18:14:09 2021 +0200
core: implement I/O framework (#2124)
This patch implements the new I/O framework that supports the current
legacy mode and a new mode based on io_uring in a compatible way so that
users of the framework don't need (in most cases) to have different
implementations depending on what mode the system is using.
This patch only introduces the framework but it's not yet used by any
component. Migration to this framework will happen in future patches.
The framework is integrated with glusterd, glusterfs and glusterfsd.
Updates: #2123
Change-Id: I5f041fdb524d7a299f77c1a468791a6322aa7bfd
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit a1b52b36a8faef64c04a2b9eae50f994f93abb87
Author: Nikhil Ladha <nladha@redhat.com>
Date: Thu Jul 8 11:26:54 2021 +0530
coverity: resource leak (#2321)
Issue:
Variable `arg` is not freed before the function exits,
and leads to resource leak.
Fix:
Free the arg variable if the status of function call
`glusterd_compare_friend_volume` is
`GLUSTERD_VOL_COMP_UPDATE_REQ`, or if the `glusterd_launch_synctask`
fails to start the process.
And, added a check for return value on calling
`glusterd_launch_synctask` function and exit if the
thread creation fails.
CID: 1401716
Updates: #1060
Change-Id: I4abd621771f88853d8d01e9039cdee2f3d862c4f
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 43f5d7b081c5f2e2c2de8042592e00329d1b5d8f
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Mon Jul 5 10:23:31 2021 +0530
protocol/client: Do not reopen fd post handshake if posix lock is held (#2582)
Problem:
With client.strict-locks enabled, in some cases where the posix lock is
taken after a brick gets disconnected, the fd is getting reopened when
the brick gets reconnected to the client as part of client_post_handshake.
In such cases the saved fdctx's lock_list may not have the latest
information.
Fix:
Check the lock information in the fdctx->lk_ctx as well post handshake
which will have the latest information on the locks.
Also check for this field in other places as well to prevent writes
happening with anonymous fd even without re-opening the fd on the
restarted brick.
Fixes: #2581
Change-Id: I7a0799e242ce188c6597dec0a65b4dae7dcd815b
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 3e1ed126ba001a3ca25611a8e8d690ea00cd2fbd
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Thu Jul 1 19:40:23 2021 +0300
libglusterfs: drop iobuf RDMA leftovers (#2569)
Drop unused RDMA leftovers from 'struct iobuf_pool'.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit f0b83865bbb65adce8a0ba8f64ffcfce5117e854
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Thu Jul 1 22:09:43 2021 +0530
Doc: Developer session 9 (#2589)
This session covers index xlator design and implementation
updates: #2308
Change-Id: I2eef965b073d4a3e95b0db808aee5eb3053dfc1f
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 4b774a6c2d42aef49f05a24c23d7db9269dc2453
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue Jun 29 10:59:25 2021 +0300
libglusterfs, rpc: cleanup iovec macros
Define MAX_IOVEC once, move IOV_MIN closer to its actual use.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit bec1453f3549e2b97ce412d286278a279794f2de
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Fri Jun 25 10:16:31 2021 +0300
io-stats: use timespec to match call frame data
In is_fop_latency_started(), prefer 'struct timespec'
to match corresponding 'call_frame_t' field, remove
unused 'struct ios_local' declaration as well.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit c7f6a6b398d402d86b5818785d218495d07bdb9c
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Jun 23 15:17:57 2021 +0530
line-coverage: Improve cli-cmd-volume.c coverage
Fix:
Adding negative test cases to improve the code coverage of
cli-cmd-volume.c and few other files.
Change-Id: I6289e7b496407ebeb79334793ac3e2badba3e13f
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1052
commit fb87f16ee17d14f39069d3448c6b082d80daf4e0
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Thu Jun 24 16:46:23 2021 +0300
rpc: drop unused condition variable (#2561)
Drop unused 'struct rpcsvc_program' condition variable.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit a0f4a085e1b8adbdb16af016162a4a6dac7f46ce
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Wed Jun 23 09:44:44 2021 +0300
changelog: fix strncat usage warning (#2530)
changelog-helpers.c: In function 'resolve_pargfid_to_path':
changelog-helpers.c:1971:9: warning: 'strncat' specified bound depends
on the length of the source argument [-Wstringop-overflow=]
1971 | strncat(result, bname, strlen(bname) + 1);
| ^
changelog-helpers.c:1971:32: note: length computed here
1971 | strncat(result, bname, strlen(bname) + 1);
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit ddda9ae995a0fe3a9a0c0d591e43e70aba3b2ae2
Author: Sam Wong <sam@hellosam.net>
Date: Mon Jun 14 12:07:02 2021 +0800
Fix #2524: Buffer overflow corrupting auth.allow by adding brick from nodes which are not part of it
commit 8d62c8b8a20bd1f55b67bc3329f22bd2a260f63a
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sun Jun 20 18:01:06 2021 +0300
socket: drop unused synchronization primitives (#2550)
Drop unused 'socket_private_t' mutex and condition variable.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 80fd5821c37e5c6b149507b00697c8f6eca5482b
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Sun Jun 20 20:30:27 2021 +0530
Doc: Developer session 8 (#2556)
Added links to the session that covers memory-tracking in glusterfs and
io-threads xlator
Change-Id: I593db4aa3d8613a4b8e6e4596035c8a9dfeff0dc
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 6af12cb32c8c816991a7c95c3c0fac9efc132eed
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sun Jun 20 08:37:34 2021 +0300
rpc: use the only pthread_mutexattr_t object (#2544)
Use the only pthread_mutexattr_t object to initialize
all related mutexes as PTHREAD_MUTEX_ADAPTIVE_NP,
add missing pthread_mutexattr_destroy() call as well.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit ee5bafc5a3073fd8c5d32f6c3df08b25534680ef
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Fri Jun 18 14:45:59 2021 +0300
xlators: fix all -Wold-style-declaration warnings (#2545)
dht-rebalance.c:2524:1: warning: ‘static’ is not at beginning
of declaration [-Wold-style-declaration]
2524 | int static gf_defrag_ctx_subvols_init(dht_dfoffset_ctx_t *offset_var,
dht-rebalance.c:3087:1: warning: ‘static’ is not at beginning
of declaration [-Wold-style-declaration]
3087 | int static gf_defrag_get_entry(xlator_t *this, int i,
posix.c:2070:1: warning: ‘static’ is not at beginning
of declaration [-Wold-style-declaration]
2070 | gf_boolean_t static within_range(posix_lock_t *existing, posix_lock_t *new)
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit b2761b57492e70691df981c89e57118aa06b12c0
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Jun 18 06:19:29 2021 +0200
delay-gen: Fix duration overflow (#2541)
The delay duration was defined as a 32-bit signed integer, but was
implicitly converted to a 64-bit unsigned value, which caused some
conversion issues.
Fixes: #2540
Change-Id: I282f0146e8a00ab7b1cb8329469c2c5b5c370ec6
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit e25bb74896f4985553173211243c504d31bb9724
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Thu Jun 17 19:13:02 2021 +0530
logging: Avoiding a call to strerror while logging (#2168)
* logging: Avoiding a call to strerror while logging
As strerror is already printed if there is an errnum
avoiding a redundant call to it while logging.
Fixes: #782
Change-Id: I1cde45342e439f821e2d19ca8d90e54906f7a5b2
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
* logging: Avoiding a call to strerror while logging
As per review comments removed trailing spaces and
joined some strings.
Fixes: #782
Change-Id: Ibe406830c9bde9ffd85d48749f43c755ef54ac8e
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 6721efa944a4cb17b34472ef8c5f9768ea3a11c9
Author: Mohammed Rafi KC <rafi.kavungal@iternity.com>
Date: Mon Jun 7 16:26:35 2021 +0530
glusterd/brick: Do not connect into the backup volfile server
A brick process requires portmap with it's local glusterd. Since
the portmapper is not a centralized one, the informations are stored
locally in each glusterd. When a glusterd goes down, connecting to
a backup volfile server will result in undefined behaviour especially
when the portmap signin and signout requests are send to a different
glusterd than it is intended. If that happens then there can be
undefined behaviour when there are bricks with the same path are present
in differnt nodes.
In this patch, we will prevent bricks connecting to a backup volfile
servers. Which means that the bricks won't be connected to any other
glusterd's to receive a management update if the glusterd on the local
node goes down.
THANKS TO PRANITH FOR THE RCA HERE
https://github.com/gluster/glusterfs/issues/2480
Fixes: #2480
Change-Id: Iddd6f1d0f0da1cf0c90729043f23a293d478bf7c
Signed-off-by: Mohammed Rafi KC <rafi.kavungal@iternity.com>
commit 91daea0001269a09c50bf0fbe99b805f232f2d9b
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Wed Jun 16 11:38:05 2021 +0530
Avoiding unnecessary calls to MY_UUID (#2269)
Instead of calling the MY_UUID multiple times, sometimes even
in loop we are calling it once and saving the result for reuse.
fixes: #1600
Change-Id: Ic8dae5ad7edeeba470bbc2d7ad950d065132a1b8
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 9fbc7f0d49f49a4857ac35391c744c0d9a03eb69
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue Jun 15 07:26:40 2021 +0300
tests: remove extra binary produced by glfs-lease (#2501)
Remove 'glfs-lease-recall' binary produced during the test.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 051999ef949246cfbe3284957f80ab7b85320395
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue Jun 15 07:10:14 2021 +0300
libglusterfs: use cache line size from userspace-rcu (#2510)
Do not define CAA_CACHE_LINE_SIZE but rely on the value
from URCU header instead.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 8ec66a43eedd505ec0b40f55c05f13a77fe8074e
Author: kalebskeithley <kaleb@redhat.com>
Date: Mon Jun 14 12:30:54 2021 -0400
ganesha_ha: ganesha_grace RA fails in start() and/or fails in (#2523)
monitor()
shell [[ ]] string compare fails to match returned attr to the
pattern and subsequently returns status of "not running", resulting
in dependencies such as the IPaddr (cluster_ip) RA not starting
Change-Id: I2c8d6f5c4cf0480672d52d8aa0d9226950441dc9
Fixes: #2522
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 9ddac5962b00335cb18b6ccf4c955c0cca94ed2f
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sun Jun 13 13:14:08 2021 +0300
glusterfsd: fix getcwd usage warning (#2518)
glusterfsd.c: In function ‘parse_opts’:
glusterfsd.c:863:23: error: argument 1 is null but the
corresponding size argument 2 value is 4096 [-Werror=nonnull]
863 | pwd = getcwd(NULL, PATH_MAX);
| ^~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 3e1a1ae77e133422cff06108bacebcb76327b7de
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Wed Jun 9 15:24:20 2021 +0530
Errno replaced by ret (#2336)
'errno' is not set by any dictionary functions, so 'errno'
that is displayed in the error message is whatever it was
set previously. This patch fixes that by replacing ret
with the errno.
Fixes: #2083
Change-Id: Ief807d1001b062e5a7620d94441d16ecb1d32dba
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 4f62332a8ae164282d7df4bd72d9c55888be65d0
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Wed Jun 9 10:56:07 2021 +0530
cluster/afr: Use appropriate msgid in afr_is_reopen_allowed_cbk() (#2508)
Problem:
In one of the gf_msg log in function afr_is_reopen_allowed_cbk()
it uses the msgid AFR_MSG_LK_HEAL_DOM when it fails to get whether
reopen is allowed or not on a FD. The msgid AFR_MSG_LK_HEAL_DOM is
introduced specifically to identify lock heal related messages.
Fix:
Since the fuction afr_is_reopen_allowed_cbk() depends on whether
the reopen can be allowed or not based on the values set in the
dict, use the msgid AFR_MSG_DICT_GET_FAILED if it failed to get
the status of reopen, which would be more appropriate.
Fixes: #2507
Change-Id: I249b917f47377677cf917471a171e27c2ea13dff
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 365207864e06819d41af0c8aa98543ae1a08e9e0
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Fri Jun 4 11:24:07 2021 +0530
Doc: Developer session 7 (#2496)
Added links to the session which covers client, server interaction in
connect/disconnect/reconnect code paths.
updates: #2308
Change-Id: I0ed43e5555397e63c29f532d2fc16e84a0398fc6
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit e35bb759b56f8b305e42be2232ab915154341cc2
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Wed Jun 2 21:57:25 2021 +0530
shard: avoid calling shard function when possible (#1857)
When the pid is GF_CLIENT_PID_GSYNCD then just skip
calling any shard functions and wind the call.
Fixes: #1702
Change-Id: Ia04e3586fb17159e1cb27348ac835af7771327a7
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit e6fdd2544650499c1aed6692042db0edb6893771
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Mon May 31 12:43:11 2021 +0300
libglusterfs: drop unused THIS accessors
Drop unused glusterfs_this_get() and glusterfs_this_set().
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 0a8573a2c313c537edcc79e0528822ccdf713989
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Thu May 27 17:51:33 2021 +0530
extras/glusterfs-georep-upgrade.py: Remove try except block
Use "exist_ok = True" option as a cleaner approach
Credits: @xhernandez
Change-Id: I7b114407646ee5cd9fee607a529445699a5eb4fd
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 28fc572f3a2c4d8b63248471f14bd555c896b39c
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Wed Jun 2 14:50:49 2021 +0530
rsync tries to sync glusterfs.lockinfo which is an internal xattr (#2481)
Inorder to fix the above stated issue, added glusterfs.lockinfo
among the set of xattrs that are to be ignored by rsync
Fixes: #2421
Change-Id: I1eb6903fa60791032dacaab2b5a2bed0962bf24f
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 88ae17ff684b327133625f49e2047624fe9748d8
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Wed Jun 2 12:34:42 2021 +0530
Taking new_client_lock outside the spinlock (#2488)
* Taking new_client_lock outside the spinlock
This will avoid taking a spin lock if new_client_lock
does not succeed.
Fixes: #2446
Change-Id: I35520d2fb4d33b4821de9efabf6557af050247f3
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
* Taking new_client_lock outside the spinlock
Addressing review comment to release the spin
lock immediately.
Fixes: #2446
Change-Id: I1623897385c8f472537887fe93af761fe5b0ea7d
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit ef223b9e1d39545cf0d7a5b2b9e2513ace6db6bd
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Tue May 25 18:03:31 2021 +0530
src/gsyncd.c: Null pointer passed to 1st parameter expecting 'nonnull'
Clang suspects argv[0] to be null.
Added a check for argc to solve the same.
Updates: #1096
Change-Id: Ie0088a2b364396d2eade8c68fd39a7d409c71b8e
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit bb3c167d370ce633166051fa69090549887b0300
Author: nik-redhat <nladha@redhat.com>
Date: Thu May 20 17:27:21 2021 +0530
glusterd: save lock backtrace only in DEBUG builds
Fix:
Save the backtrace for locking only in case of DEBUG builds.
Fixes: #705
Change-Id: Ie80183db73ea2129334989636358ee4e0790b144
Signed-off-by: nik-redhat <nladha@redhat.com>
commit be52a6222e4d10e624529c68a94e206fe713526c
Author: nik-redhat <nladha@redhat.com>
Date: Wed May 12 11:52:04 2021 +0530
coverity: waiting while holding a lock
Fix:
For CID: 1404316
Sleep was added in the socket bind code due to
regression. But, just doing a retry after a failure works fine.
So, reduced the sleep time to 2secs in case of normal build.
Kept sleep time to 5secs in case of DEBUG build.
For CID: 1382404
Marking it as false positiv to keep it as a record. It can be ignored
as the the code is expected to handle the sleep based on the comment
at line: 3293.
Updates: #1060
Change-Id: I688cce317feac0efd494395d18966cb9cc5477db
Signed-off-by: nik-redhat <nladha@redhat.com>
commit d8bace71e9dcfc5b63c2ef4a8a960a1db7f02d43
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Wed May 26 14:51:53 2021 +0300
tests: fix library location for ipc test
Since ${prefix}/lib is not always equal to ${libdir} (64-bit
build may be configured with '--libdir=/usr/lib64' for example),
prefer convenient ${libdir} for LD_PRELOAD'ing libglusterfs.so.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit acebfa50d54052d1553ad0ae6fd380f130db7462
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Mon May 24 16:31:13 2021 +0300
protocol/server: cleanup server configuration data
Drop the reference to non-existing 'limits.transaction-size'
option, cleanup 'struct server_conf' and related bits.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit a7dc43f533ad4b8ff68bf57704fefc614da65493
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue May 18 17:09:26 2021 +0300
build, rpc, tests: detect path to OpenSSL trusted certificates
Use 'openssl version -d' to detect path to OpenSSL trusted
certificates and prefer it over the system-dependent hardcoded
values and shell scripting quirks. Adjust related tests to
use 'create_self_signed_certs()' function.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit ad2e52b771031f321472cfa81b2e458e5cf0f628
Author: Vinayak hariharmath <65405035+v-harihar@users.noreply.github.com>
Date: Thu May 27 15:48:07 2021 +0530
features/sharding: wrong dname resuls in dentry not found error (#2475)
Due to wrong dname passed to inode_unlink in
shard_evicted_inode_fsync_cbk() resulting in dentry not found
error.
This patch addresses the issue.
Fixes: #2470
Change-Id: I6c479980ae3fa7ba558327055a9e5e5c2d2a850f
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
commit 96ff8ec64fc472a7c08d75404fc58bb84a723860
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Thu May 27 13:20:50 2021 +0530
Coverity: Fix copy into fixed size buffer (CID: 1325542) (#2474)
Problem:
In __mnt3_fresh_lookup() mres->resolveloc.path is being copied into
a fixed size string mres->remainingdir, with strncpy without checking
the size of the source string. This could lead to string overflow.
Fix:
Copy only till the destination string length and check whether the
soruce string overflows. If so log an error message and return.
Change-Id: I26dd0653d2636c667ad4e356d12d3d51956c77c3
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1060
commit ecbc7e71f1bb0ab16d2cd966add904f479e029c6
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue May 25 14:18:12 2021 +0300
glusterd, server: remove volfile checksum leftovers (#2460)
Remove volfile checksum leftovers which aren't actually used since 4.1.6.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 6279c5b96770c641fcfb3f212ecdc0755af6ff9c
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue May 25 14:17:21 2021 +0300
libglusterfs, glusterd: fix possible mutex and syncbarrier leak (#2435)
Consistently use gd_syncargs_init() and matching gd_syncargs_fini()
to release barrier and mutex internally owned by 'struct syncargs'.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit b666f6030b868fc3ed694dc47aa46ec44bdc7645
Author: Pranith Kumar K <pranith.karampuri@phonepe.com>
Date: Thu May 20 07:19:10 2021 +0530
protocol/client: Initialize list head to prevent NULL de-reference
fixes: #2443
Change-Id: I86ef0270d41d6fb924db97fde3196d7c98c8b564
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 68ed7930f49b10844d675b56bdb9a0e7e6ac3426
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Sun May 23 06:53:40 2021 +0530
tests: Execute statistics command after shd is up (#2465)
Change-Id: I13c6728f06ed48db7752eab28af6c141f08c23a3
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 1d534b57d279a59b8bded3a5fe57801c20a3e32c
Author: Michael Fellinger <github@manveru.dev>
Date: Sun May 23 03:22:04 2021 +0200
Fix unrecognized flags in ganesha start hook (#2375)
Also fixes all issues pointed out by shellcheck
commit f0c12e87707f4e3672e0302a047ba3697d6a63fc
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sun May 23 04:18:26 2021 +0300
performance/md-cache: add missing calls to free locking primitives (#2455)
Add missing LOCK_DESTROY() and pthread_mutex_destroy() calls
in mdc_inode_wipe(), mdc_inode_prep() and mdc_fini().
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 329491acaef04efd9b70ae7f59e74ce888ffd077
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sun May 23 04:17:18 2021 +0300
xlators, cli: prefer timespec over timeval (#2458)
Prefer timespec_now_realtime() over gettimeofday() to simplify and
avoid extra multiply by 1000.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 634db840005280a9363f670829053e9f7ea6a668
Author: nik-redhat <nladha@redhat.com>
Date: Tue May 11 17:29:13 2021 +0530
glusterd: improved line/function coverage
Fix:
Added a new `.t` file for improving line/function
coverage for glusterd component
Updates: #1052
Change-Id: I7e1bf72c6aa923f2a0d6a915e43795eb47698db0
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 6e5d886e45eb51d3fc024a18a25f6b603fa17916
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Wed May 19 20:16:19 2021 +0530
Doc: Developer session 6 (#2454)
Added links to the session which covers communication layer in
glusterfs.
Change-Id: I144dc8d758db477a3aa1d1994a3a51cb60c74390
updates: #2308
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 26630721dfacf63d3d3c3b8b41274c4fbf29ef95
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Wed May 19 07:09:55 2021 +0300
cluster/afr: drop self-heal-readdir-size (#2448)
Drop the long-standing 'sh_readdir_size' leftover but
retain a no-op option to ensure backward compatibility.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit ad91156af4ff20a1c4ba2b61a425eae85b5d0051
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Thu May 13 16:29:00 2021 +0300
storage/posix: cleanup AIO completion callbacks
Convert AIO completion callbacks to static functions and
remove unused arguments.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1000
commit 36b37221af28c77a0e5c84294d4b1aa6a411bcfb
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon May 17 12:44:31 2021 +0530
tests: fix yet another afr-lock-heal-basic.t spurious failure (#2438)
* tests: fix yet another afr-lock-heal-basic.t spurious failure
From the logs, it appears as if the lock info was not present in the
statedump when it was generated. Changed the logic to check for the lock
info in successive statedumps within PROCESS_UP_TIMEOUT.
Fixes: #2394
Change-Id: I5b071299d05a8c68b02735dfd8b510b0485dc9ce
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
* remove sleep
Change-Id: I822446222d2fbf824c6eaf42f3c72808356071e3
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit d148d1918552bfca30a003ac7cc84afde944d7b7
Author: Anton Korshikov <chado@chado.by>
Date: Mon May 17 07:54:13 2021 +0200
geo-replication: use is_alive for Python 3.9 compatibility (#2441)
Threading.Thread.isAlive() was removed in Python 3.9 this cause sync
daemon to fail. Threading.Thread.is_alive() already exists in python 2
and 3 so backward compatibility should work as expected.
Fixes: #2440
Signed-off-by: Anton Korshikov <chado@chado.by>
commit cfcb7984970168a1cf1b0821c49f21e14c16426f
Author: Vinayak hariharmath <65405035+v-harihar@users.noreply.github.com>
Date: Fri May 14 17:21:22 2021 +0530
coverity: missing break in shard xlator (#2437)
CID: 1453117
Missing break in switch
This mistake happened through the commit #2372.
Submitting patch to correc the fault.
Change-Id: I6d1f77ea21a81ddef3734879cc4dd90565eecdfd
Updates: #1060
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
commit 9c7e6594ae2954bbda042735652f16fc06d193fb
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Fri May 7 13:41:43 2021 +0300
libglusterfs: prefer mallinfo2() to mallinfo() if available
Since glibc 2.33, mallinfo() is marked obsolete due to the limited
range of 'int' type used in 'struct mallinfo', and new 'size_t'-based
counterpart 'struct mallinfo2' with corresponding function mallinfo2()
should be preferred instead. To avoid compatibility mess, it's also
reasonable to use 'uint64_t' values for storing and operating with
mallinfo data internally, as suggested by Xavi Hernandez.
Fixes: #2414
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
commit d4e668040c54cc98a642871526a134135f0d4eb5
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sat May 8 13:56:37 2021 +0300
storage/posix: support timestamps with nanosecond precision
If futimens() available, prefer it over futimes()
to support timestamps with nanosecond precision.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Fixes: #2429
commit e210d5c61a3f085ad9824dbcb61bd67716108616
Author: nik-redhat <nladha@redhat.com>
Date: Fri Apr 30 18:54:28 2021 +0530
cli-line-coverage: Added test for negative case, removed stale code
Fix:
Added new .t file for increasing the line,function coverage
in cli component, and removed/commented out stale code.
Updates: #1052
Change-Id: I0a3c12a12f18bee39824157129c1d0187f4030d4
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 069e293683aa21b46899cfa9371d01aa4b4f63a3
Author: Ayush Ujjwal <77244483+aujjwal-redhat@users.noreply.github.com>
Date: Thu May 13 13:29:57 2021 +0530
CID: 1351700 : Result not floating point (#2434)
Description:
The result of the division is truncated to an integer (a whole number), which is usually a loss of precision in a calculation.
Type casted bricks_to_use to double.
Updates: #1060
Change-Id: I7e6aa29dbe27f2bb8e17231cc87c405798557694
Signed-off-by: Ayush Ujjwal <aujjwal@redhat.com>
commit 1fafd1344f52ee2d628973af3dbcf14b1e8abacd
Author: Vinayak hariharmath <65405035+v-harihar@users.noreply.github.com>
Date: Thu May 13 12:54:23 2021 +0530
features/shard: files larger than shard_block_size show the wrong size (#2372)
issue:
When the user executes 'ls' command, shard fetches the actual file-size
extended attribute from the file and displays the correct size to the user.
When parallel-readdir/readdir-ahead features are enabled, readdir of the
brick happens in the background which will not fetch actual file-size xattr
from the brick and caches it. When the user does 'ls' the entries are served
from this cache which doesn't have actual file size, so shard translator
thinks these files are created before sharding is enabled and shows the user
shard block size instead of the actual file size.
Solution:
Send xdata request to server to fetch the actual size of the sharded file
from the server.
fixes: #1384
Change-Id: Id756b07b0ff1f746b0bf6d4081b6a1fd9e76adfb
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
commit 4e35455716962a25c28d46c547dfeb3447c09468
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Sat May 8 10:10:39 2021 +0300
libglusterfs: add missing LOCK_DESTROY() calls
Add missing LOCK_DESTROY() calls in __event_slot_dealloc()
and rbthash_table_destroy().
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Updates: #1960
commit 71594cdd741deb5197392d046b904efe3b5479f5
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Tue May 11 16:52:21 2021 +0300
build: drop --disable-syslog
Since syslog is unconditionally used in libglusterfs/src/logging.c,
this configuration option makes no sense anymore.
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Fixes: #2431
commit 7f4fd47faa441b53b8025234822e06448d2d9030
Author: Ayush Ujjwal <77244483+aujjwal-redhat@users.noreply.github.com>
Date: Wed May 12 17:07:12 2021 +0530
Changed value of gfs_id (#2396)
Changed the value of gfs_id from 0xbabe to a more appropriate value
0xcaed.
Fixes: #2024
Change-Id: Ic3fdd60479caec8e3927d2fa7d2752df3bab9ef9
Signed-off-by: Ayush Ujjwal <aujjwal@redhat.com>
commit e661d6202796c4d8446f53264c5304fab1008e87
Author: nik-redhat <nladha@redhat.com>
Date: Mon May 3 19:42:19 2021 +0530
Updated configure script to do runtime check of posix_spawn compatibility
Issue:
Recently, we migrated from `fork()` to `posix_sapwn()`, but
the due to issues with the `posix_spawn` implementation in older versions
of glibc, it returns incorrect value for a non-existent child process
Fix:
Updated the configure script to do a runtime check of the
`posix_spawn` compatibility with the env, and build gluster using
either using `posix_spawn` if the env is compatible or use the earlier
implementation of `fork()`. For that added, the previous runner
implementation using `fork` as `run_fork.c` file.
Fixes: #2287
Change-Id: I7c5ccfa5e5108a430e7456ba29e0f7eecdd89997
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 8ee590edfc41f7b53d8ec3a88d1c01960cc323dd
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Wed May 12 17:00:01 2021 +0530
dict: Compilation should check string literal (#2409)
Recently I made a mistake where a variable is passed instead of string
literal to _sizen variant but the compilation succeeded. This can lead
to serious bugs. Added guard rails to prevent this from happening in
future.
fixes: #2410
Change-Id: I8cf1408b4a0a497903162de32e2cfb008ad7853c
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 6411dcebc3fe359e4977b8d110f5b7bae8021ce9
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue May 11 09:44:34 2021 +0530
coverity: sanitize arguments to gf_attach (#2413)
* coverity: sanitize arguments to gf_attach
CID 1452749 :
> Untrusted value as argument (TAINTED_SCALAR)13. tainted_data:
>Passing tainted expression **argv to dict_set_str, which uses it as an offset.
>ret = dict_set_str(options, "transport.socket.connect-path", argv[optind]);
As far as I understood, untainting the arguments by checking it meets
the required expectations should make coverity not complain anymore. I
have therefore added checks to verify the file-type of the expected
arguments to gf_attach.
Updates: #1060
Change-Id: Ia8608d844ca3ede6d43f7ee5a793820b9a7bae52
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
* Update glusterfsd/src/gf_attach.c
Added 'static' keyword.
Co-authored-by: Yaniv Kaul <ykaul@redhat.com>
commit 13cc69fbe417f90f98f98f661f5547a04b8001fd
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Tue May 11 07:25:02 2021 +0530
Coverity: Fix unused value issue (CID: 1422183) (#2412)
Problem:
In mq_initiate_quota_task() and mq_reduce_parent_size_task()
the return value from mq_mark_dirty() is not being used and
is being overwritten in the later part.
Fix:
Since the return value is not used to take any decision in any
part of the code, changing the fucntion to return void instead
of int.
Change-Id: I2c97af6f8e4389ae275d8cf0054f006278f8e6b7
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1060
commit 614fee253852166fb3a5209db1acd75508bc1390
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Tue May 11 07:23:55 2021 +0530
cluster/afr: Code coverage improvement for afr-transaction.c (#2424)
Problem:
The function afr_post_lower_unlock_cbk() is not called in any place.
This internally calles afr_post_blocking_rename_cbk(), which is also
not used/called in any other part of the code.
Fix:
Removed the dead code to improve the code coverage.
Change-Id: I2a700776babbefea3c61254d98677154500b3286
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1000
commit 5a6e268cd9699b97cbae4f178ee29cae67dac955
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue May 4 22:39:03 2021 +0200
geo-rep: Improve handling of gfid mismatches
In some circumstances geo-replication can detect mismatching gfids
between primary and secondary. These entries are fixed in an iterative
way, assuming that after a fix, a previously failing entry could
succeed.
Previous code was trying to fix them in a loop that can be executed
up to 10 times. If some entry cannot be fixed after 10 attempts, it's
discarded. These fixes are very slow, so trying to do them many times
causes geo-replication to get out of sync.
To minimize the number of iterations done, this patch checks if the
number of entries and failures remains constant after each iteration.
If they are constant, it means that nothing else can be fixed, so it
makes no sense to do more iterations. This reduces the number of
iterations to 2 or 3 in most of the cases, improving geo-replication
performance.
Fixes: #2388
Change-Id: I6d9a623a60045694e1a832195e1dc1fb9e88ae54
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 17b3faa8fe37aa3500d405a0df47701370334791
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Sat May 8 06:08:20 2021 +0530
Doc: Developer session 5 (#2411)
Added links to the session which covers lifecycles of inode_t, fd_t and
how to debug ref leaks.
updates: #2308
Change-Id: Ib5378718423e65cd08e43ab7ec3a02bbac578b51
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit d94fad7d0a5827b114932eb0a4b8efddfbeb5274
Author: Dmitry Antipov <dantipov@cloudlinux.com>
Date: Fri May 7 13:03:41 2021 +0300
build: extract major compiler version (#2406)
Since 'clang -dumpversion' reports the version in major.minor.patchlevel
format, major version number should be extracted to avoid
./configure: line 16445: test: 12.0.0: integer expression expected
when configuring with CC=clang.
Fixes: #2407
Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
commit c87c097e69fd8288c33c14a6399a9d8b74a347a9
Author: Pranith Kumar K <pranith.karampuri@phonepe.com>
Date: Sun May 2 13:14:44 2021 +0530
storage/posix: Remove unnecessary sys_lstat
fixes: #2380
Change-Id: Id9974b7e554780ae5648d99e926460f6dd0cbe77
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 10ce65db3e1a4e19766a7776f580de71c9d0bef8
Author: schaffung <ssivakum@redhat.com>
Date: Fri May 7 09:08:47 2021 +0530
Bitrot and scrub process cmdline arg addition (#2402)
* Bitrot and scrub process cmdline arg addition
The bitd and scrubd services when viewed from the
perspective of the `gluster volume status <volname> client-list`
returned `unknown` as the `--process-name` cmdline
arg wasn't provided when starting up these services.
Fixes: #2398
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
* Modifying an existing bitrot TC
After fixing the output for the client-list output
for bitd and scrub, modified an existing TC to
verify the scenario.
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
* Removed duplicate functions.
Replaced the functions glusterd_bitdsvc_start and
glusterd_scrubsvc_start with glusterd_genericsvc_start.
Updates: #2398
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
* Update glusterd-svc-mgmt.c
Simplified the return structure by removing a goto.
commit 7211cba9bd785928d2bfced531f3a1ef2c1d0e98
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Thu May 6 19:52:32 2021 +0530
tests: Bricks should be online in shd gefore heal-full (#2405)
fixes: #2404
Change-Id: I2b6fa9fcff684b86936d5add25e34a649d62fea7
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit b4314878f9b4fadfbb7f1abcd6e10ed1fc5fc9d3
Author: Ayush Ujjwal <aujjwal@redhat.com>
Date: Mon May 3 14:01:32 2021 +0530
Coverity : Use after free
CID: 1430111
Description:
The previous condition `if(tmp)` was freeing `tmp` always.
Hence, replaced the condition with a new condition which checks if `rv >= 0`.
Updates: #1060
Change-Id: I0ebe18d1978b73b577ded259915b7305a58253ff
Signed-off-by: Ayush Ujjwal <aujjwal@redhat.com>
commit 8ce957bcbdd7e7ad7c65eba399f7e454eeef0b8d
Author: Nikhil Ladha <nladha@redhat.com>
Date: Thu May 6 10:45:46 2021 +0530
coverity: null dereference (#2395)
Fix:
Updated the code to make it more readable and fixed
the NULL dereferencing.
CID: 1234622
Updates: #1060
Change-Id: I05bd203bc46fe84be86398bd664a3485409c3bfe
Signed-off-by: nik-redhat <nladha@redhat.com>
commit fda14cf6557559d161130513826d6548f27b0dd9
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Apr 29 18:34:57 2021 +0530
glusterd: handle custom xlator failure cases
Problem-1:
custom xlator insertion was failing for those xlators in the brick graph
whose dbg_key was NULL in the server_graph_table. Looking at the git log,
the dbg_key was added in commit d1397dbd7d6cdbd2d81d5d36d608b6175d449db4
for inserting debug xlators.
Fix: I think it is fine to define it for all brick xlators below server.
Problem-2:
In the commit-op phase, glusterd_op_set_volume() updates the volinfo
dict with the key-value pairs and then proceeds to create the volfiles.
If any of the steps fail, the volinfo dict retains those key-values,
until glusterd is restarted or `gluster vol reset $VOLNAME` is issued.
Fix:
Make a copy of the volinfo dict and if there are any failures in
proceeding with the set volume logic, restore the dict to its original
state.
Change-Id: I9010dab33d0139b8e6d603308e331b6d220a4849
Updates: #2370
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 91206dd3cf796616c9a506d8b4f34a1520dd28ca
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Wed May 5 09:59:35 2021 +0530
Revert "fuse - remove unnecessary code block" (#2385)
As per the discussion on #2353 it is decided to revert this patch to fix
the acl regression issue.
This reverts commit 07bb13291fbb92632d01d8c215b93e31ec9ae313.
fixes: #2353
Change-Id: Ie47479d9f894bac9c5d8a83b05c42e1ee98230dc
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 11b7266be2f133ca3c97207191c13c3d3eee888b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue May 4 09:27:57 2021 +0300
call-stub: remove unused fields (#2055)
- Cleaned up the call stub structure from some unused fields.
- Moved some members from char/boolean to uint32_t.
- Reordered initialization according to member order
- Moved from mempool to regular GF_CALLOC/GF_FREE to avoid long
unneeded indirection.
Overall, it causes all members to be on the same cacheline.
In my tests, I'm getting higher performance of up to 10-15% (but
I'm testing only a simple fio randrw on my local machine) initially.
Fixes: #2054
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit cd7dc6854bf2f58d0d90a3ea5cf92ef0ecfb3db5
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Mon May 3 19:23:20 2021 +0530
storage/posix: Removed unnecessary sys_fstatat (#2379)
* storage/posix: Removed unnecessary sys_fstatat
sys_unlinkat() will handle error cases. There is no need to do
a sys_fstatat()
fixes: #2378
Change-Id: I45282fb11e041221d2e8fe3d7e93360a2ebf8860
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
Co-authored-by: Yaniv Kaul <ykaul@redhat.com>
commit 803d53103fe1465eb5c21415fbecd12d9b545c5d
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Mon May 3 16:34:44 2021 +0530
cluster/afr: Code coverage improvement for afr-self-heald.c & cli-rpc-ops.c (#2366)
Problem 1:
The code to handle the volume heal split-brain was there in both
glfs-heal.c and afr-self-heald.c. The code path in the later file
was never hit since it will always be handled by self-heal.c.
Fix:
Removed the code to handle heal info split-brain request from
afr-self-heald.c and cli-rpc-ops.c files.
Problem 2:
The volume heal statistics was never called in any of the test cases.
Fix:
Calling volume heal statistics in afr-heal-info.t which will increase
the code coverage of both afr-self-heald.c an cli-rpc-ops.c.
Change-Id: I242ef088bb2da9c8d9a200986514758cb0f08b37
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1000
commit 5c61d3747dd4a635c9a8d74e2a9b540f91538e9c
Author: nishith-vihar <77044911+nishith-vihar@users.noreply.github.com>
Date: Mon May 3 13:22:28 2021 +0530
String not null terminated CID:1452739 (#2373)
Null character is added to the buffer variable
if n_read is greater than 0
Change-Id: I0c82a462b8deb608008a1ccf7b299964dc940294
Updates: #1060
Signed-off-by: Nishith Vihar Sakinala <nsakinal@redhat.com>
commit 0fed71fac2bf019a8281c677671808b572eb7d99
Author: Nikhil Ladha <nladha@redhat.com>
Date: Mon May 3 10:03:21 2021 +0530
coverity: resource leaks, bypass rand() security check (#2363)
* coverity: resource leaks, bypass rand() security check
Fix:
Marked the security issue of using `rand()` as false-positive,
as we don't use `rand()` for any cryptographic things.
And, fixed the resource leak of a variable.
CID: 1452732, 1452733
Updates: #1060
Change-Id: Id4cb2eb1cf7ce6f814752a4fb23bdd41ec94592c
Signed-off-by: nik-redhat <nladha@redhat.com>
* Remove extra call to strdup()
Change-Id: Ie28c98432edecc5162821d670f3276b6858a4f6b
Signed-off-by: nik-redhat <nladha@redhat.com>
* Reverting to usage of strdup()
Change-Id: I8f219bbedf9602e6d069e390bd6d9c48d4107443
Signed-off-by: nik-redhat <nladha@redhat.com>
* Avoid use of strdup
Change-Id: I4225c29b4f138bfc01400a89cecdf73f3f95a3cb
Signed-off-by: nik-redhat <nladha@redhat.com>
commit f2247eb159f80cd535baa11a6379088b2df54efe
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Mon May 3 10:00:14 2021 +0530
mgmt/glusterd: Fix Handle leak (#2377)
fixes: #2364
Change-Id: Id7d073c8fb14490e99271763c377b92df05eb64b
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 1179a5e0a9db5c6694ba8510f16dd23762dc36f0
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Fri Apr 30 16:37:57 2021 +0530
Coverity: Fix dereference before null check (CID: 1391415) (#2369)
Problem:
In function gf_client_dump_inodes_to_dict() there is a null check for
a variable which is already dereferenced in the previous line. This
means that there could be a chance that this variable is null. But it
is not being validate for null before dereferencing it in the first
place.
Fix:
Added null check before dereferencing the variable at the first place.
Change-Id: I988b0e93542782353a8059e33db1522b6a5e55f8
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1060
commit 612f2a7ac1e71f110748ceb65b9168e506376ad4
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Wed Apr 28 15:07:52 2021 +0530
Coverity: Resource leak fix (CID: 1356547) (#2362)
Issue:
In function gf_svc_readdirp() there is a chance that 'local' will be allocated
memory but not released in the failure path.
Fix:
Assign 'local' to 'frame->local' immediately after the successful allocation, so
it will be released by the existing failure path code itself.
Change-Id: I4474dc4d4be5432d169cb7d434728f211054997e
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1060
commit 93083f990561c257f97b865f44509a9a339bf80f
Author: Nikhil Ladha <nladha@redhat.com>
Date: Wed Apr 28 02:14:27 2021 +0530
extras: fix for postscript failure on logrotation of snapd logs (#2310)
Issue:
On executing the logrotate command, the postscript runs as a separate process,
and when we do a grep for the snapd process it returns the PID of that
short-term process as well, and executing a kill on that throws the error.
To check a similar error could be seen if we replace the killall for bricks
log rotation with a for loop on PIDs.
Fix:
Use the killall command on the list of snapd processes instead of
using the kill command to individually kill them.
Fixes: #2360
Change-Id: I1ad6e3e4d74128706e71900d02e715635294ff72
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 678230de40491f6f4834224d83902f0e8d7fff7d
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Tue Apr 27 18:21:08 2021 +0530
storage/posix: Remove unnecessary stat (#2335)
This particular stat serves no purpose. If symlink succeeds, then the
stat will succeed. Next sys_stat will fail if there is something wrong
with this symlink. So there is no use for this stat.
fixes: #2334
Change-Id: Ice8b2041cd3e761d959821bf6adf38656f750f93
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 1b4bccd5b07d599631746e280c561ad71638170d
Author: Nikhil Ladha <nladha@redhat.com>
Date: Tue Apr 27 14:43:02 2021 +0530
glusterd: enhancement around port mapper (#1670)
Issue:
pmap_registry_new() tests bind() for all ports from base_port
to max_port for pmap registry initialization. The initialized
data will be stale when we want to use the ports, so we avoid
keeping any entry of free ports at the beginning and check the
port if its free or not only before using it.
Fix:
1.Modified the code for the port mapper completely, that is removed
unwanted code from the file glusterd_pmap.c as now we are not
using the array for storing the port number, instead randomizing
the port number within the base port and max port in the func
pmap_port_alloc() and then just treturing the port number.
2.Removed few unwanted operations like search, bind, extend, remove
registry as we are not using the array anymore.
3.Modified few required functions so as to work without storing
the results in the array.
Fixes: #786
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 802c99889aae66135a08c04197485c101b5789c4
Author: Pranith Kumar K <pranith.karampuri@phonepe.com>
Date: Mon Apr 26 20:27:15 2021 +0530
Doc: Developer session 4
Adding links to developer session 4 which covers programming model used
in gluster.
updates: #2308
Change-Id: Ia45b6ea25fb2300e380a6c624dd6821a87e1af52
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit dbbad5d69c73a62888a22adf40901e9a578c6518
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Apr 23 19:26:49 2021 +0530
glusterd: After upgrade on release 9.1 glusterd protocol is broken (#2352)
* glusterd: After upgrade on release 9.1 glusterd protocol is broken
After upgrade on release-9 glusterd protocol is broken
because on the upgraded nodes glusterd is not able to find an
actor at expected index in rpc procedure table.The new proc (GLUSTERD_MGMT_V3_POST_COMMIT)
was introduced from a patch(https://review.gluster.org/#/c/glusterfs/+/24771/)
in the middle due to that index of existing actor is changed on new upgraded nodes
glusterd is failing.
Solution: Change the proc(GLUSTERD_MGMT_V3_POST_COMMIT) position at
last in proc table to avoid an issue.
Fixes: #2351
Change-Id: I36575fd4302944336a75a8d4a305401a7128fd84
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 6a43697a6c2f41336a4ce6b85ea2b50c449fc7d0
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Apr 23 14:52:56 2021 +0200
tests: avoid empty paths in environment variables (#2349)
* tests: avoid empty paths in environment variables
Many variables containing paths in env.rc.in are defined in a way
that leave a trailing ':' in the variable when the previous value
was empty or undefined.
In the particular case of 'LD_PRELOAD_PATH' variable, this causes
that the system looks for dynamic libraries in the current working
directory. When this directory is inside a Gluster mount point, a
significant delay is caused each time a program is run (and testing
framework can run lots of programs for each test).
This patch prevents that variables containing paths could end with
a trailing ':'.
Fixes: #2348
Change-Id: I669f5a78e14f176c0a58824ba577330989d84769
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
* Fix PYTHONPATH name and duplicity
Change-Id: Iaa0b092118bb86856bbe621eb03fef6fa7478971
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 4230e21f7c60387f818bdbbd3008484ca61640b2
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Thu Apr 22 11:23:05 2021 +0530
protocol/client: Fix lock memory leak (#2338)
Problem-1:
When an overlapping lock is issued the merged lock is not assigned the
owner. When flush is issued on the fd, this particular lock is not freed
leading to memory leak
Fix-1:
Assign the owner while merging the locks.
Problem-2:
On fd-destroy lock structs could be present in fdctx. For some reason
with flock -x command and closing of the bash fd, it leads to this code
path. Which leaks the lock structs.
Fix-2:
When fdctx is being destroyed in client, make sure to cleanup any lock
structs.
fixes: #2337
Change-Id: I298124213ce5a1cf2b1f1756d5e8a9745d9c0a1c
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 7602b74b71897e5b3d07cbcd66a36dba511345b5
Author: Nikhil Ladha <nladha@redhat.com>
Date: Mon Apr 19 13:55:16 2021 +0530
coverity: Removed structural dead code (#2320)
Issue:
`for` loop was executed only once, leading to structural
dead code in coverity
Fix:
Updated the code to use `if` condition instead of
`for` loop for the same.
CID: 1437779
Updates: #1060
Change-Id: I2ca1d2c9d2842d586161fe971bb8c7b3444dfb2b
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 6dbb5e312a2fd9a59197bb4155d9fb69a8825239
Author: chenglin130 <35245387+chenglin130@users.noreply.github.com>
Date: Thu Apr 15 15:53:38 2021 +0800
logging: fix a relock deadlock (#2332)
In gf_log_inject_timer_event(), got lock log.log_buf_lock. Then,
under the lock, any call to gf_msg will hang the thread. Because
in _gf_msg_internal(), it will relock log.log_buf_lock.
Use a PTHREAD_MUTEX_RECURSIVE type instead of the default type for
this mutex to fix this deadlock.
Fixes: #2330
Signed-off-by: Cheng Lin cheng.lin130@zte.com.cn
commit e499d5d547e399353b7189bb512888e5164af522
Author: Günther Deschner <gd@samba.org>
Date: Wed Apr 14 13:49:20 2021 +0200
group-samba: disable performance.write-behind translator. (#2329)
Fixes: #2328
From the vfs_glusterfs(8) manpage:
"The GlusterFS write-behind performance translator, when used with
Samba, could be a source of data corruption. The translator, while
processing a write call, immediately returns success but continues
writing the data to the server in the background. This can cause data
corruption when two clients relying on Samba to provide data consistency
are operating on the same file."
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
commit 4336edecaf74b52c94c2e8d663610c8b0936c645
Author: Nikhil Ladha <nladha@redhat.com>
Date: Tue Apr 13 17:55:12 2021 +0530
cli: Increased spacing in cli for option table (#2322)
* cli: Increased spacing in cli for option table
Issue:
Some options have name larger than length 40,
due to which the output of command `gluster vol get <volname> all`
mixes up the option, value for long option names.
Fix:
Increased the spacing in cli for `gluster vol get <volname> all`
output to 50.
Fixes: #2313
Change-Id: I841730ced074547a81171a4432d15ec9c35f39cd
Signed-off-by: nik-redhat <nladha@redhat.com>
* Added separator
Change-Id: I210877c89bc468ed6a3090cd14fde7ecee1d33b6
Signed-off-by: nik-redhat <nladha@redhat.com>
* Removed separator and added space
Change-Id: Ic0eb9c9bc39a354465aabd939f72bc65be738f6c
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 5b635f69a74ccc6dbf7a1a112b271741bdbcea36
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Sat Apr 10 16:11:03 2021 +0530
Doc: Developer session 3 (#2323)
Adding links to developer session 3 which covers xlator interface in
gluster.
updates: #2308
Change-Id: I8dc84263c19613dba665a080d8adb99cdfe677b0
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit a62c5666e2b58668d0ddec7f3331446313539e72
Author: Xavi Hernandez <xhernandez@gmail.com>
Date: Fri Apr 9 18:13:30 2021 +0200
dht: fix rebalance of sparse files (#2318)
Current implementation of rebalance for sparse files has a bug that,
in some cases, causes a read of 0 bytes from the source subvolume.
Posix xlator doesn't allow 0 byte reads and fails them with EINVAL,
which causes rebalance to abort the migration.
This patch implements a more robust way of finding data segments in
a sparse file that avoids 0 byte reads, allowing the file to be
migrated successfully.
Fixes: #2317
Change-Id: Iff168dda2fb0f2edf716b21eb04cc2cc8ac3915c
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 7a9f7cb3f6929ed2d4af603f1aa64ca967140940
Author: Jamie Nguyen <j@jamielinux.com>
Date: Thu Apr 8 02:23:44 2021 +0000
tests: Fix incorrect variables in throttle-rebal.t (#2316)
The final test doesn't test what it means to test. It still fails as
expected, but only because at this point `THROTTLE_LEVEL` is still set
to `garbage`.
Easily fixed by correcting the typos in the variable names, and thus
fixes https://github.com/gluster/glusterfs/issues/2315
Signed-off-by: Jamie Nguyen <j@jamielinux.com>
commit 5fd3d4175fc2ba16fe92129ff43fb7fb23d8615a
Author: nishith-vihar <77044911+nishith-vihar@users.noreply.github.com>
Date: Tue Apr 6 19:40:50 2021 +0530
Removal of force option in snapshot create (#2110)
The force option does fail for snapshot create command even though
the quorum is satisfied and is redundant.
The change deprecates the force option for snapshot create command
and checks if all bricks are online instead of checking for quorum
for creating a snapshot.
Fixes: #2099
Change-Id: I45d866e67052fef982a60aebe8dec069e78015bd
Signed-off-by: Nishith Vihar Sakinala <nsakinal@redhat.com>
commit 0494b9cba5712c5e9d0231a570379c433743b457
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Tue Apr 6 12:07:19 2021 +0530
Remove some strlen() calls if using DICT_LIST_IMP (#2311)
The code was optimized by avoiding some strlen()
calls if using DICT_LIST_IMP
fixes: #2294
Change-Id: Ic5e784edb9538feb1d1b441c8514c76ba5266832
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 4c853e7bcdf6124abad0eb97dfec9c26c08c61e9
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Sun Apr 4 10:02:11 2021 +0530
Doc: Developer session 1, 2 (#2291)
Adding links to recordings, slides of the dev-session 1, 2
updates: #2308
Change-Id: I9e10173e2b3b0d70304fa8fa050734aba06a2c6b
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 34f854ad2f5d53578d7a4543f837cf0fb0f1a76a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Apr 2 08:52:07 2021 +0300
list.h: remove offensive language, introduce _list_del() (#2132)
1. Replace offensive variables with the values the Linux kernel uses.
2. Introduce an internal function - _list_del() that can be used
when list->next and list->prev are going to be assigned later on.
(too bad in the code we do not have enough uses of list_move() and
list_move() tail, btw. Would have contributed also to code readability)
* list.h: defined LIST_POSION1, LIST_POISION2 similar to Linux kernel
defines
Fixes: #2025
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit a23fcdf13fce0c9c606ac18b791ceccc3bceb7eb
Author: chenglin130 <35245387+chenglin130@users.noreply.github.com>
Date: Thu Apr 1 22:03:34 2021 +0800
marker: initiate xattrs QUOTA_SIZE_KEY for empty volume (#2261)
* marker: initiate quota xattrs for empty volume
When a VOL is empty, it's failed to list quota info after setting limit-usage.
# gluster volume quota gv0 list
/ N/A N/A N/A N/A N/A N/A
Because there is no QUOTA_SIZE_KEY in the xattrs of the VOL directory.
# getfattr -d -m. -e hex /data/brick2/gv0
getfattr: Removing leading '/' from absolute path names
# file: data/brick2/gv0
security.selinux=0x73797374656d5f753a6f626a6563745f723a676c7573746572645f627269636b5f743a733000
trusted.gfid=0x00000000000000000000000000000001
trusted.glusterfs.mdata=0x01000000000000000000000000603e70f6000000003b3f3c8000000000603e70f6000000003351d14000000000603e70f9000000000ff95b00
trusted.glusterfs.quota.limit-set.1=0x0000000000a00000ffffffffffffffff
trusted.glusterfs.volume-id=0xe27d61be048c4195a9e1ee349775eb59
This patch fix it by setting QUOTA_SIZE_KEY for the empty VOL directory when quota enable.
# gluster volume quota gv0 list
Path Hard-limit Soft-limit Used Available Soft-limit exceeded? Hard-limit exceeded?
-------------------------------------------------------------------------------------------------------------------------------
/ 4.0MB 80%(3.2MB) 0Bytes 4.0MB No No
Fixes: #2260
Change-Id: I6ab3e43d6ef33e5ce9531b48e62fce9e8b3fc555
Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
commit 7f313485ce018a0ddf7d2f0f745a9fb70bc4b3a6
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Feb 9 16:43:35 2021 +0530
xlaotrs/mgmt: Fixing coverity issue 1445996
Fixing "Null pointer dereferences"
fixes: #2129
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 2a524ad0738be491dcac3cc96db1411320168c72
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Sat Mar 27 15:44:04 2021 +0530
afr: don't reopen fds on which POSIX locks are held (#1980)
When client.strict-locks is enabled on a volume and there are POSIX
locks held on the files, after disconnect and reconnection of the
clients do not re-open such fds which might lead to multiple clients
acquiring the locks and cause data corruption.
Change-Id: I8777ffbc2cc8d15ab57b58b72b56eb67521787c5
Fixes: #1977
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit a249b9020d281d0482db0aeb52e8856acd931e02
Author: kalebskeithley <kaleb@redhat.com>
Date: Thu Mar 25 20:50:10 2021 -0400
common-ha: ensure shared_storage is mounted before setup (#2296)
If gluster shared-storage isn't mounted, ganesha will fail to start
Change-Id: I6ed7044ea6b6c61b013ebe17088bfde311b109b7
fixes: #2278
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
commit 51c91bea1d844544bd17b13c4ee4d2beeacb2e3b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Mar 25 11:52:13 2021 +0530
afr: make fsync post-op aware of inodelk count (#2273)
Problem:
Since commit bd540db1e, eager-locking was enabled for fsync. But on
certain VM workloads wit sharding enabled, shard xlator keeps sending
fsync on the base shard. This can cause blocked inodelks from other
clients (including shd) to time out due to call bail.
Fix:
Make afr fsync aware of inodelk count and not delay post-op + unlock
when inodelk count > 1, just like writev.
Code is restructured so that any fd based AFR_DATA_TRANSACTION can be made
aware by setting GLUSTERFS_INODELK_DOM_COUNT in xdata request.
Note: We do not know yet why VMs go in to paused state because of the
blocked inodelks but this patch should be a first step in reducing the
occurence.
Updates: #2198
Change-Id: Ib91ebdd3101d590c326e69c829cf9335003e260b
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 9bd2c697686ec40e2c4f711df961860c8a735baa
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu Mar 18 09:22:54 2021 -0400
common-ha: stability fixes for ganesha_grace and ganesha_mon RAs
Include fixes suggested by ClusterHA devs.
1) It turns out that crm_attribute attrs and attrd_updater attrs really are one and the same,
despite what I was told years ago.
attrs created with crm_attribute ... --lifetime=reboot ... or attrd_updater are one and same. As
per ClusterHA devs having an attr created with crm_attribute ... --lifetime=forever and also
creating/updating the same attr with attrd_updater is a recipe for weird things to happen that
will be difficult to debug.
2) using hostname -s or hostname for node names in crm_attribute and attrd_updater potentially
could use the wrong name if the host has been renamed; use ocf_local_nodename() (in ocf-
shellfuncs) instead.
fixes:#2276
Change-Id:If572d396fae9206628714fb2ce00f72e94f2258f
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
commit d1cd048d62c5661aa6219eb270aad31db3c71078
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Mar 24 14:44:40 2021 +0530
configure: add linux-io_uring flag (#2060)
By default, if liburing is not present on the machine where gluster rpms are
being built, then the built rpm won't have the feature present in posix.so.
While this is obviously displayed in the ./configure's summary, it means the
feature won't work on a target machine where the rpm is installed, even if the
target has Linux kernel >=5.1 and liburing installed.
I think it is better to have a configure option `--enable-linux-io_uring` which
is on by default. That way, the build machines will error out by default and
will need to `./configure --disable-linux-io_uring` to compile or install the
lbirary and headers on the build machine.
Fixes: #2063
Change-Id: Ide1daa11b3513210d12be8d2cb683a4084d41e18
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit cbdd7dc11189187e3a8191ed35de47b4715e6e21
Author: Ayush Ujjwal <77244483+aujjwal-redhat@users.noreply.github.com>
Date: Mon Mar 22 15:37:20 2021 +0530
CID 1412333 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) (#2264)
* CID 1412333 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)
CID: 1412333
Description:
`path` length might overrun the 108-character fixed-size string. Added a condition to check the size of `path`.
Updates: #1060
Change-Id: I4e7c58ab3a3f6807992dfc3023c21f762bff6b32
Signed-off-by: aujjwal-redhat <aujjwal@redhat.com>
* refactored the code
Change-Id: I1eaa6fc59e43f76224f44b5f8c54495b67076651
Signed-off-by: aujjwal-redhat <aujjwal@redhat.com>
* added strncpy in place of strcpy to store only the number of characters as much is size of addr-sunppath
Change-Id: I9b4eeed3dd0c00d052dcaaf6b34597fbfe7fe1a2
Signed-off-by: aujjwal-redhat <aujjwal@redhat.com>
* Removed goto err as it was already going to err
Change-Id: Ib40c11537b57aea72d3095eda86bd5b541930550
Signed-off-by: aujjwal-redhat <aujjwal@redhat.com>
commit ec189a499d85c2aad1d54e55e47df6b95ba02922
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Mon Mar 22 10:19:27 2021 +0530
cluster/dht: use readdir for fix-layout in rebalance (#2243)
Problem:
On a cluster with 15 million files, when fix-layout was started, it was
not progressing at all. So we tried to do a os.walk() + os.stat() on the
backend filesystem directly. It took 2.5 days. We removed os.stat() and
re-ran it on another brick with similar data-set. It took 15 minutes. We
realized that readdirp is extremely costly compared to readdir if the
stat is not useful. fix-layout operation only needs to know that the
entry is a directory so that fix-layout operation can be triggered on
it. Most of the modern filesystems provide this information in readdir
operation. We don't need readdirp i.e. readdir+stat.
Fix:
Use readdir operation in fix-layout. Do readdir+stat/lookup for
filesystems that don't provide d_type in readdir operation.
fixes: #2241
Change-Id: I5fe2ecea25a399ad58e31a2e322caf69fc7f49eb
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 1da141ab38463c4a26474456eec81c5992367af9
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Mon Mar 22 10:18:15 2021 +0530
Cleanup unused this pointers (#2282)
fixes: #2268
Change-Id: If00ee847e15ac7f7e5b0e12125a7d02a610b9708
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit bb0130d3df0a1f32e23eabca0bf559f4de1bbb55
Author: Pranith Kumar K <pranith.karampuri@phonepe.com>
Date: Wed Mar 17 18:04:00 2021 +0530
afr, dht: Add ramifications of disabling ensure-durability
Also moved options to NO_DOC
Change-Id: I86623f4139d156812e622a87655483c9d2491052
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit d84292de5706424e60d230f71ccfffe29ba9c48b
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Mar 18 17:39:59 2021 +0530
Coverity Issues: 1447088, 1447089 (#2217)
1447088 - Resource leak
1447089 - Buffer not null terminated
updates: #2216
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 41c3947e3a12b38c5fed7bbdcb75b0bdcab144ec
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Mar 17 20:41:23 2021 +0530
afr: remove priv->root_inode (#2244)
priv->root_inode seems to be a remenant of pump xlator and was getting
populated in discover code path. thin-arbiter code used it to populate
loc info but it seems that in case of some daemons like quotad, the
discover path for root gfid is not hit, causing it to crash.
Fix:
root inode can be accessed via this->itable->root, so use that and
remove priv->rot_inode instances from the afr code.
Fixes: #2234
Change-Id: Iec59c157f963a4dc455652a5c85a797d00cba52a
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 2b3e3ef08d98271d21473a5bdc341e4f2367ee56
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Mar 17 10:59:54 2021 +0100
extras: disable lookup-optimize in virt and block groups (#2254)
lookup-optimize doesn't provide any benefit for virtualized
environments and gluster-block workloads, but it's known to cause
corruption in some cases when sharding is also enabled and the volume
is expanded or shrunk.
For this reason, we disable lookup-optimize by default on those
environments.
Fixes: #2253
Change-Id: I25861aa50b335556a995a9c33318dd3afb41bf71
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 088d8a575c59479defb5dbe8bf03f4211156df7f
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Wed Mar 17 11:02:21 2021 +0530
cluster/dht: Provide option to disable fsync in data migration (#2259)
At the moment dht rebalance doesn't give any option to disable fsync
after data migration. Making this an option would give admins take
responsibility of data in a way that is suitable for their cluster.
Default value is still 'on', so that the behavior is intact for people
who don't care about this.
For example: If the data that is going to be migrated is already backed
up or snapshotted, there is no need for fsync to happen right after
migration which can affect active I/O on the volume from applications.
fixes: #2258
Change-Id: I7a50b8d3a2f270d79920ef306ceb6ba6451150c4
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit d96e4c8dc5e7095aac0f81852d342e7a7c6238cc
Author: nishith-vihar <77044911+nishith-vihar@users.noreply.github.com>
Date: Thu Mar 11 22:09:42 2021 +0530
String not null terminated (#2219)
CID: 1214629,1274235,1437648
The buffer has been null terminated thus resolving the issue
Change-Id: Ieb1d067d8dd860c55a8091dd6fbba1bcbb4dc19f
Updates: #1060
Signed-off-by: Nishith Vihar Sakinala <nsakinal@redhat.com>
commit 45ca8e8650439e2c3cb028f68e1cfd98cb999258
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Thu Mar 11 09:05:43 2021 +0530
cluster/dht: Fix use-after-free bug dht_queue_readdir(p) (#2242)
Problem:
In dht_queue_readdir(p) 'frame' is accessed after unwind. This will lead to
undefined behavior as frame would be freed upon unwind.
Fix:
Store the variables that are needed in local variables and use them
instead.
fixes: #2239
Change-Id: I6b2e48e87c85de27fad67a12d97abd91fa27c0c1
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 46949c4951eb1d2eb0a90c21db66c31e444bffe8
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Wed Mar 10 10:43:24 2021 +0530
features/index: Optimize link-count fetching code path (#1789)
* features/index: Optimize link-count fetching code path
Problem:
AFR requests 'link-count' in lookup to check if there are any pending
heals. Based on this information, afr will set dirent->inode to NULL in
readdirp when heals are ongoing to prevent serving bad data. When heals
are completed, link-count xattr is leading to doing an opendir of
xattrop directory and then reading the contents to figure out that there
is no healing needed for every lookup. This was not detected until this
github issue because ZFS in some cases can lead to very slow readdir()
calls. Since Glusterfs does lot of lookups, this was slowing down
all operations increasing load on the system.
Code problem:
index xlator on any xattrop operation adds index to the relevant dirs
and after the xattrop operation is done, will delete/keep the index in
that directory based on the value fetched in xattrop from posix. AFR
sends all-zero xattrop for changelog xattrs. This is leading to
priv->pending_count manipulation which sets the count back to -1. Next
Lookup operation triggers opendir/readdir to find the actual link-count in
lookup because in memory priv->pending_count is -ve.
Fix:
1) Don't add to index on all-zero xattrop for a key.
2) Set pending-count to -1 when the first gfid is added into xattrop
directory, so that the next lookup can compute the link-count.
fixes: #1764
Change-Id: I8a02c7e811a72c46d78ddb2d9d4fdc2222a444e9
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
* addressed comments
Change-Id: Ide42bb1c1237b525d168bf1a9b82eb1bdc3bc283
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
* tests: Handle base index absence
Change-Id: I3cf11a8644ccf23e01537228766f864b63c49556
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
* Addressed LOCK based comments, .t comments
Change-Id: I5f53e40820cade3a44259c1ac1a7f3c5f2f0f310
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit dc9bab7959b068617ef00f355c63bdca060b9605
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Mar 9 00:24:07 2021 +0100
afr: fix directory entry count (#2233)
AFR may hide some existing entries from a directory when reading it
because they are generated internally for private management. However
the returned number of entries from readdir() function is not updated
accordingly. So it may return a number higher than the real entries
present in the gf_dirent list.
This may cause unexpected behavior of clients, including gfapi which
incorrectly assumes that there was an entry when the list was actually
empty.
This patch also makes the check in gfapi more robust to avoid similar
issues that could appear in the future.
Fixes: #2232
Change-Id: I81ba3699248a53ebb0ee4e6e6231a4301436f763
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit d917bc3299f6f1b89ca61971b04c41e70bedb24b
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Tue Mar 2 14:59:04 2021 +0200
EC - Fixing a Coverity issue (Uninitialized lock use)
CID: 1444461
A lock is being destroyed, but in some code-flows might be used later
on, modified code-flow to make sure the destroyed lock is not being used
in all cases.
Change-Id: I9610d56d9cb8a8ab7062e9094493dba9afdd0b30
updates: #1060
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 43f1a83298d068b010fca94a7f13e7cc566e1b71
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Fri Mar 5 17:18:38 2021 +0530
quiesce: Resource leak coverity fix (#2215)
Fixes CID: 1124725
Updates: #1060
Change-Id: Iced092c5ad1a9445e4c758f09a481501bae7275f
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit f41f7dec05e71809a8b386132d24e6970e1c04d5
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Mar 5 11:54:46 2021 +0530
cli: syntax check for arbiter volume creation (#2207)
commit 8e7bfd6a58b444b26cb50fb98870e77302f3b9eb changed the syntax for
arbiter volume creation to 'replica 2 arbiter 1', while still allowing
the old syntax of 'replica 3 arbiter 1'. But while doing so, it also
removed a conditional check, thereby allowing replica count > 3. This
patch fixes it.
Fixes: #2192
Change-Id: Ie109325adb6d78e287e658fd5f59c26ad002e2d3
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 082014c1de47ebe9bc2c021b66e36b2141f3cbbe
Author: zhangxianwei8 <33945019+zhangxianwei8@users.noreply.github.com>
Date: Thu Mar 4 18:25:00 2021 +0800
glusterd: Fix deadlock while concurrent quota enable (#2118)
in glusterd_svc_start:
1) synctaskA gets attach_lock and then releases big_lock to execute runner_run.
2) synctaskB then gets big_lock but can not gets attach_lock and then wait.
3) After executes runner_run, synctaskA then gets big_lock but synctaskB holds it, wait.
This leads to deadlock.
This patch uses runner_run_nowait to avoid the deadlock.
fixes: #2117
Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
commit 72a9fc8ca1acad32803755aad4593bf499cc2354
Author: Aravinda Vishwanathapura <aravinda@kadalu.io>
Date: Tue Feb 23 18:43:07 2021 +0530
api: Fix a function name in the API doc
Wrong function name was mentioned in API doc
for `glfs_get_volfile`.
Change-Id: Id2251837f53270f1f03b8a5501ea335b7995873b
Updates: #1000
Signed-off-by: Aravinda Vishwanathapura <aravinda@kadalu.io>
commit 089f2c5737d06781c50e9dc327d66779f2234c35
Author: Tamar Shacked <tshacked@redhat.com>
Date: Mon Mar 1 12:41:14 2021 +0200
dict: avoid hash calculation when hash_size=1 (link list imp) (#2171)
* dict: avoid hash calculation when hash_size=1 (link list imp)
Currently dict_t always constructs with dict::hash_size = 1.
With this initializing the dict implemented as a link-list
and searching for a key is done by iteration using key comparison.
Therfore we can avoid the hash-calculation done each set()/get() in this case.
Fixes: #2013
Change-Id: Id93286a8036064d43142bc2b2f8d5a3be4e97fc4
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
* dict: avoid hash calculation when hash_size=1 (list imp)
Currently dict_t always constructs with dict::hash_size = 1.
With this initializing the dict implemented as a link-list
and searching for a key is done by iteration using key comparison.
Therfore we can avoid the hash-calculation done each set()/get() in this case.
Fix:
using new macro to delimit and avoid blocks related to hash imp
Fixes: #2013
Change-Id: I31180b434a6e9e7bbb456c7ad888c147c4ce3308
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit 45877363ce5dbb9b86138b4f6548a6b8ff747251
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Mon Mar 1 05:19:39 2021 +0100
afr: fix coverity issue introduced by 90cefde (#2201)
Fixes coverity issues 1447029 and 1447028.
Updates: #2161
Change-Id: I6a564231d6aeb76de20675b7ced5d45eed8c377f
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 759ec2877c5d044af0f2739cd543fbbbb0c26c00
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Feb 26 07:47:02 2021 +0100
dht: fix use-after-free introduced by 70e6ee2
Change-Id: I97e73c0aae74fc5d80c975f56f2f7a64e3e1ae95
Updates: #2169
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 90cefde4b5936594e3bc953b500f52ce9799f94d
Author: Xavi Hernandez <xhernandez@users.noreply.github.com>
Date: Wed Feb 24 16:44:55 2021 +0100
cluster/afr: Fix race in lockinfo (f)getxattr (#2162)
* cluster/afr: Fix race in lockinfo (f)getxattr
A shared dictionary was updated outside the lock after having updated
the number of remaining answers. This means that one thread may be
processing the last answer and unwinding the request before another
thread completes updating the dict.
Thread 1 Thread 2
LOCK()
call_cnt-- (=1)
UNLOCK()
LOCK()
call_cnt-- (=0)
UNLOCK()
update_dict(dict)
if (call_cnt == 0) {
STACK_UNWIND(dict);
}
update_dict(dict)
if (call_cnt == 0) {
STACK_UNWIND(dict);
}
The updates from thread 1 are lost.
This patch also reduces the work done inside the locked region and
reduces code duplication.
Fixes: #2161
Change-Id: Idc0d34ab19ea6031de0641f7b05c624d90fac8fa
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 70e6ee279e173651ac6c68c996914440ac4d8f0e
Author: Xavi Hernandez <xhernandez@users.noreply.github.com>
Date: Wed Feb 24 15:04:23 2021 +0100
cluster/dht: Fix stack overflow in readdir(p) (#2170)
When parallel-readdir is enabled, readdir(p) requests sent by DHT can be
immediately processed and answered in the same thread before the call to
STACK_WIND_COOKIE() completes.
This means that the readdir(p) cbk is processed synchronously. In some
cases it may decide to send another readdir(p) request, which causes a
recursive call.
When some special conditions happen and the directories are big, it's
possible that the number of nested calls is so high that the process
crashes because of a stack overflow.
This patch fixes this by not allowing nested readdir(p) calls. When a
nested call is detected, it's queued instead of sending it. The queued
request is processed when the current call finishes by the top level
stack function.
Fixes: #2169
Change-Id: Id763a8a51fb3c3314588ec7c162f649babf33099
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 80b65bc2ff4709f5a5d3dccaea24ccf9a3401337
Author: mohit84 <moagrawa@redhat.com>
Date: Wed Feb 24 18:17:18 2021 +0530
dht: Ongoing IO is failed during volume shrink operation (#2188)
In the commit (c878174) we have introduced a check
to avoid stale layout issue.To avoid a stale layout
issue dht has set a key along with layout at the time
of wind a create fop and posix validates the parent
layout based on the key value. If layout does not match
it throw and error.In case of volume shrink layout has
been changed by reabalance daemon and if layout does not
matches dht is not able to wind a create fop successfully.
Solution: To avoid the issue populate a key only while
dht has wind a fop first time. After got an
error in 2nd attempt dht takes a lock and then
reattempt to wind a fop again.
Fixes: #2187
Change-Id: Ie018386e7823a11eea415496bb226ca032453a55
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit d858f3bc135238f3809e488441f25bba0efd6bd7
Author: mohit84 <moagrawa@redhat.com>
Date: Wed Feb 24 12:28:10 2021 +0530
tests: Move tests/basic/glusterd-restart-shd-mux.t to flaky (#2191)
The test case ( tests/basic/glusterd-restart-shd-mux.t ) was
introduced as a part of shd mux feature but we observed the
feature is not stable and we already planned to revert a feature.
For the time being I am moving a test case to flaky to
avoid a frequent regression failure.
Fixes: #2190
Change-Id: I4a06a5d9212fb952a864d0f26db8323690978bfc
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 14c578e9f3be7afbb5d088f0fe4921b67a969ea7
Author: Amar Tumballi <amar@kadalu.io>
Date: Mon Feb 22 23:36:53 2021 +0530
fuse: add an option to specify the mount display name (#1989)
* fuse: add an option to specify the mount display name
There are two things this PR is fixing.
1. When a mount is specified with volfile (-f) option, today, you can't make it out its from glusterfs as only volfile is added as 'fsname', so we add it as 'glusterfs:/<volname>'.
2. Provide an options for admins who wants to show the source of mount other than default (useful when one is not providing 'mount.glusterfs', but using their own scripts.
Updates: #1000
Change-Id: I19e78f309a33807dc5f1d1608a300d93c9996a2f
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 839e4796d2ea92a97001d1af34837467da4a05cd
Author: zhangxyue <77471026+zhangxyue@users.noreply.github.com>
Date: Mon Feb 22 04:05:28 2021 -0800
glusterfs:the mount operation will get stuck when the vol isn't exist (#2177)
when passing wrong volume-name which doesn't exits, it will get stuck.
The errno is 0 inited in glusterd-handshake.c. After initing the errno,
the process blocks in gf_fuse_umount.
commit adf95699621f084f2503d8dd15e519bab778906f
Author: mohit84 <moagrawa@redhat.com>
Date: Mon Feb 22 10:09:34 2021 +0530
glusterd: Resolve use after free bug (#2181)
In the commit 61ae58e67567ea4de8f8efc6b70a9b1f8e0f1bea
introduced a coverity bug use object after cleanup
the object.
Cleanup memory after comeout from a critical section
Fixes: #2180
Change-Id: Iee2050c4883a0dd44b8523bb822b664462ab6041
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 1ce8e8f5ea5d18f7e5ac669cd1c79b6966533f74
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Sun Jan 24 12:06:53 2021 +0200
dht/linkfile - Remove unused code
A couple of methods are not being used, removing them.
Change-Id: I5bb4b7f04bae9486cf9b7960cf5ed91d0b59c8c7
updates: #1000
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 61ae58e67567ea4de8f8efc6b70a9b1f8e0f1bea
Author: mohit84 <moagrawa@redhat.com>
Date: Thu Feb 18 09:40:44 2021 +0530
glusterd: Rebalance cli is not showing correct status after reboot (#2172)
Rebalance cli is not showing correct status after reboot.
The CLI is not correct status because defrag object is not
valid at the time of creating a rpc connection to show the status.
The defrag object is not valid because at the time of start a glusterd
glusterd_restart_rebalance can be call almost at the same time by two
different synctask and glusterd got a disconnect on rpc object and it
cleanup the defrag object.
Solution: To avoid the defrag object populate a reference count before
create a defrag rpc object.
Fixes: #1339
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: Ia284015d79beaa3d703ebabb92f26870a5aaafba
commit 1f8247c54c47bb24b862786c80e5ce865683b8ec
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Feb 16 13:56:14 2021 +0200
iobuf: use lists instead of iobufs in iobuf_arena struct (#2097)
We only need passive and active lists, there's no need for a full
iobuf variable.
Also ensured passive_list is before active_list, as it's always accessed
first.
Note: this almost brings us to using 2 cachelines only for that structure.
We can easily make other variables smaller (page_size could be 4 bytes) and fit
exactly 2 cache lines.
Fixes: #2096
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 2170ac242fd8e94035a73feafeb6c43d33ee9978
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Sat Feb 13 17:44:49 2021 +0530
Remove tests from components that are no longer in the tree (#2160)
fixes: #2159
Change-Id: Ibaaebc48b803ca6ad4335c11818c0c71a13e9f07
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 6fad53370c93023be3ab945fbf8eb4154b800995
Author: chenglin130 <35245387+chenglin130@users.noreply.github.com>
Date: Fri Feb 12 00:01:54 2021 +0800
mount: optimize parameter backup-volfile-servers (#2043)
Optimize parameter backup-volfile-servers to support IPv6 address.
Fixes: #2042
Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
commit 796ad4c4a10e03648499e4aedb9337e26706f505
Author: nishith-vihar <77044911+nishith-vihar@users.noreply.github.com>
Date: Thu Feb 11 21:29:39 2021 +0530
Stirng not null terminated (#2112)
CID: 1214629,1274235,1430115,1437648
Null character is added at the end of buffer which corrects the
issue.
Change-Id: I8f7016520ffd41b2c68fe3c7f053e0e04f306c84
Updates: #1060
Signed-off-by: Nishith Vihar Sakinala <nsakinal@redhat.com>
commit af5c2cb320068bd154caf54f063fa1787ae19995
Author: Xavi Hernandez <xhernandez@users.noreply.github.com>
Date: Thu Feb 11 16:11:19 2021 +0100
posix: fix chmod error on symlinks (#2155)
After glibc 2.32, lchmod() is returning EOPNOTSUPP instead of ENOSYS when
called on symlinks. The man page says that the returned code is ENOTSUP.
They are the same in linux, but this patch correctly handles all errors.
Fixes: #2154
Change-Id: Ib3bb3d86d421cba3d7ec8d66b6beb131ef6e0925
Signed-off-by: Xavi Hernandez xhernandez@redhat.com
commit 5223300bc65eb88a1fbe27bd2702dbb92768cb27
Author: Nikhil Ladha <nladha@redhat.com>
Date: Wed Feb 10 15:07:32 2021 +0530
glusterd: fix for starting brick on new port (#2090)
The Errno set by the runner code was not correct when the bind() fails
to assign an already occupied port in the __socket_server_bind().
Fix:
Updated the code to return the correct errno from the
__socket_server_bind() if the bind() fails due to EADDRINUSE error. And,
use the returned errno from runner_run() to retry allocating a new port
to the brick process.
Fixes: #1101
Change-Id: If124337f41344a04f050754e402490529ef4ecdc
Signed-off-by: nik-redhat nladha@redhat.com
commit 2572f096b2e6477e49009550d68e761e67676cc4
Author: schaffung <ssivakum@redhat.com>
Date: Wed Feb 10 13:43:48 2021 +0530
Glustereventsd Default port change (#2091)
Issue : The default port of glustereventsd is currently 24009
which is preventing glustereventsd from binding to the UDP port
due to selinux policies.
Fix: Changing the default port to be bound by chanding it to something
in the ephemeral range.
Fixes: #2080
Change-Id: Ibdc87f83f82f69660dca95d6d14b226e10d8bd33
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit 6fcff3901d9e886494ad065d70a5a2557da71710
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Tue Feb 9 06:44:49 2021 +0530
gfapi: avoid crash while logging message. (#2139)
Breaking parameter into two different parameter
to avoid a crash.
fixes: #2138
Change-Id: Idd5f3631488c1d892748f83e6847fb6fd2d0802a
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit b818cdde534743fccca5cd91b4a7298e2d0d601e
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Feb 5 13:15:23 2021 +0200
stack.h/c: remove unused variable and reorder struct
- Removed unused ref_count variable
- Reordered the struct to get related variables closer together.
- Changed 'complete' from a '_Bool' to a 'int32_t'
Before:
```
struct _call_frame {
call_stack_t * root; /* 0 8 */
call_frame_t * parent; /* 8 8 */
struct list_head frames; /* 16 16 */
void * local; /* 32 8 */
xlator_t * this; /* 40 8 */
ret_fn_t ret; /* 48 8 */
int32_t ref_count; /* 56 4 */
/* XXX 4 bytes hole, try to pack */
/* --- cacheline 1 boundary (64 bytes) --- */
gf_lock_t lock; /* 64 40 */
void * cookie; /* 104 8 */
_Bool complete; /* 112 1 */
/* XXX 3 bytes hole, try to pack */
glusterfs_fop_t op; /* 116 4 */
struct timespec begin; /* 120 16 */
/* --- cacheline 2 boundary (128 bytes) was 8 bytes ago --- */
struct timespec end; /* 136 16 */
const char * wind_from; /* 152 8 */
const char * wind_to; /* 160 8 */
const char * unwind_from; /* 168 8 */
const char * unwind_to; /* 176 8 */
/* size: 184, cachelines: 3, members: 17 */
/* sum members: 177, holes: 2, sum holes: 7 */
/* last cacheline: 56 bytes */
```
After:
```
struct _call_frame {
call_stack_t * root; /* 0 8 */
call_frame_t * parent; /* 8 8 */
struct list_head frames; /* 16 16 */
struct timespec begin; /* 32 16 */
struct timespec end; /* 48 16 */
/* --- cacheline 1 boundary (64 bytes) --- */
void * local; /* 64 8 */
gf_lock_t lock; /* 72 40 */
void * cookie; /* 112 8 */
xlator_t * this; /* 120 8 */
/* --- cacheline 2 boundary (128 bytes) --- */
ret_fn_t ret; /* 128 8 */
glusterfs_fop_t op; /* 136 4 */
int32_t complete; /* 140 4 */
const char * wind_from; /* 144 8 */
const char * wind_to; /* 152 8 */
const char * unwind_from; /* 160 8 */
const char * unwind_to; /* 168 8 */
/* size: 176, cachelines: 3, members: 16 */
/* last cacheline: 48 bytes */
```
Fixes: #2130
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 00f141018f23d05703c8e3a730bb5134f95e6b60
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Mon Feb 8 14:29:08 2021 +0530
tests: Handle nanosecond duration in profile info (#2135)
Problem:
volume profile info now prints duration in nano seconds. Tests were
written when the duration was printed in micro seconds. This leads to
spurious failures.
Fix:
Change tests to handle nano second durations
fixes: #2134
Change-Id: I94722be87000a485d98c8b0f6d8b7e1a526b07e7
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit a37518f37d21eadc41b6ec5d544100a38c7a8bac
Author: Xavi Hernandez <xhernandez@users.noreply.github.com>
Date: Sat Feb 6 01:53:28 2021 +0100
cluster/ec: Change self-heal-window-size to 4MiB by default (#2071)
The current block size used for self-heal by default is 128 KiB. This
requires a significant amount of management requests for a very small
portion of data healed.
With this patch the block size is increased to 4 MiB. For a standard
EC volume configuration of 4+2, this means that each healed block of
a file will update 1 MiB on each brick.
Change-Id: Ifeec4a2d54988017d038085720513c121b03445b
Updates: #2067
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 39f75094e604798a3c938e7801510d835f41b4e9
Author: renlei4 <70688659+renlei4@users.noreply.github.com>
Date: Sat Feb 6 08:50:14 2021 +0800
introduce microsleep to improve sleep precision (#2104)
* syncop: introduce microsecond sleep support
Introduce microsecond sleep function synctask_usleep,
which can be used to improve precision instead of synctask_sleep.
Change-Id: Ie7a15dda4afc09828bfbee13cb8683713d7902de
* glusterd: use synctask_usleep in glusterd_proc_stop()
glusterd_proc_stop() sleep 1s for proc stop before force kill.
but in most cases, process can be stopped in 100ms.
This patch use synctask_usleep to check proc running state
every 100ms instead of sleep 1, can reduce up to 1s stop time.
in some cases like enable 100 volumes quota, average execution
time reduced from 2500ms to 500ms.
fixes: #2116
Change-Id: I645e083076c205aa23b219abd0de652f7d95dca7
commit ea86b664f3b1f54901ce1b7d7fba7d80456f2089
Author: Ryo Furuhashi <76208814+bonfffire@users.noreply.github.com>
Date: Fri Feb 5 12:56:03 2021 +0900
glusterd-volgen: Add functionality to accept any custom xlator (#1974)
* glusterd-volgen: Add functionality to accept any custom xlator
Add new function which allow users to insert any custom xlators.
It makes to provide a way to add any processing into file operations.
Users can deploy the plugin(xlator shared object) and integrate it to glusterfsd.
If users want to enable a custom xlator, do the follows:
1. put xlator object(.so file) into "XLATOR_DIR/user/"
2. set the option user.xlator.<xlator> to the existing xlator-name to specify of the position in graph
3. restart gluster volume
Options for custom xlator are able to set in "user.xlator.<xlator>.<optkey>".
Fixes: #1943
Signed-off-by:Ryo Furuhashi <ryo.furuhashi.nh@hitachi.com>
Co-authored-by: Yaniv Kaul <ykaul@redhat.com>
Co-authored-by: Xavi Hernandez <xhernandez@users.noreply.github.com>
commit 73ad20e5863a63625cd4e0a94b4393d98dc7393f
Author: Michael Scherer <misc@redhat.com>
Date: Mon Feb 1 16:37:34 2021 +0100
Fix comments format, remove 'is a folder' warning
// is for C and C++, shell use #. Vim syntax coloration is
misleading.
This displayed in each jenkins log:
./tests/00-geo-rep/../include.rc: line 1: //: is a folder
Likely no impact besides a wrong warning.
Fix #2093
commit 34b9f13c5232f106e5736c60ed6d7d5ad515d2c8
Author: Tamar Shacked <tshacked@redhat.com>
Date: Thu Feb 4 10:39:00 2021 +0200
dht: don't parse decommissioned-bricks option when in decommission (#2088)
Scenario:
1) decommission start: the option decommissioned-bricks is added to the vol file
and being parsed by dht.
2) another configuration change (like setting a new loglevel): the decommissioned-bricks option
still exists on the vol file and being parsed again, this leads to invalid data.
Fix:
Prevent the parsing of "decommissioned-bricks" when decommission is running.
This counts on the fact that once a decommission is running it cannot be started again.
Fixes: #1992
Change-Id: I7a016750e2f865aee4cd620bd9033ec19421d47d
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit 449ef110446891eec44e329dc30112225872bccd
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Wed Feb 3 21:32:45 2021 +0530
cluster/dht: Allow fix-layout only on directories (#2109)
Problem:
fix-layout operation assumes that the directory passed is directory i.e.
layout->cnt == conf->subvolume_cnt. This will lead to a crash when
fix-layout is attempted on a file.
Fix:
Disallow fix-layout on files
fixes: #2107
Change-Id: I2116b8773059f67e3260e9207e20eab3de711417
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 8bc83c331b7dd159f5eb56e0ab5362450d473364
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Wed Feb 3 18:10:40 2021 +0530
cluster/afr: Change default self-heal-window-size to 1MB (#2068)
At the moment self-heal-window-size is 128KB. This leads to healing data
in 128KB chunks. With the growth of data and the avg file sizes
nowadays, 1MB seems like a better default.
Change-Id: I70c42c83b16c7adb53d6b5762969e878477efb5c
Fixes: #2067
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 8bebb100868fa018007c120474280aed0717312d
Author: Vinayak hariharmath <65405035+VHariharmath-rh@users.noreply.github.com>
Date: Wed Feb 3 17:04:25 2021 +0530
features/shard: delay unlink of a file that has fd_count > 0 (#1563)
* features/shard: delay unlink of a file that has fd_count > 0
When there are multiple processes working on a file and if any
process unlinks that file then unlink operation shouldn't harm
other processes working on it. This is a posix a compliant
behavior and this should be supported when shard feature is
enabled also.
Problem description:
Let's consider 2 clients C1 and C2 working on a file F1 with 5
shards on gluster mount and gluster server has 4 bricks
B1, B2, B3, B4.
Assume that base file/shard is present on B1, 1st, 2nd shards
on B2, 3rd and 4th shards on B3 and 5th shard falls on B4 C1
has opened the F1 in append mode and is writing to it. The
write FOP goes to 5th shard in this case. So the
inode->fd_count = 1 on B1(base file) and B4 (5th shard).
C2 at the same time issued unlink to F1. On the server, the
base file has fd_count = 1 (since C1 has opened the file),
the base file is renamed under .glusterfs/unlink and
returned to C2. Then unlink will be sent to shards on all
bricks and shards on B2 and B3 will be deleted which have
no open reference yet. C1 starts getting errors while
accessing the remaining shards though it has open references
for the file.
This is one such undefined behavior. Likewise we will
encounter many such undefined behaviors as we dont have one
global lock to access all shards as one. Of Course having such
global lock will lead to performance hit as it reduces window
for parallel access of shards.
Solution:
The above undefined behavior can be addressed by delaying the
unlink of a file when there are open references on it.
File unlink happens in 2 steps.
step 1: client creates marker file under .shard/remove_me and
sends unlink on base file to the server
step 2: on return from the server, the associated shards will
be cleaned up and finally marker file will be removed.
In step 2, the back ground deletion process does nameless
lookup using marker file name (marker file is named after the
gfid of the base file) in glusterfs/unlink dir. If the nameless
look up is successful then that means the gfid still has open
fds and deletion of shards has to be delayed. If nameless
lookup fails then that indicates the gfid is unlinked and no
open fds on that file (the gfid path is unlinked during final
close on the file). The shards on which deletion is delayed
are unlinked one the all open fds are closed and this is
done through a thread which wakes up every 10 mins.
Also removed active_fd_count from inode structure and
referring fd_count wherever active_fd_count was used.
fixes: #1358
Change-Id: I8985093386e26215e0b0dce294c534a66f6ca11c
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
* features/shard: delay unlink of a file that has fd_count > 0
When there are multiple processes working on a file and if any
process unlinks that file then unlink operation shouldn't harm
other processes working on it. This is a posix a compliant
behavior and this should be supported when shard feature is
enabled also.
Problem description:
Let's consider 2 clients C1 and C2 working on a file F1 with 5
shards on gluster mount and gluster server has 4 bricks
B1, B2, B3, B4.
Assume that base file/shard is present on B1, 1st, 2nd shards
on B2, 3rd and 4th shards on B3 and 5th shard falls on B4 C1
has opened the F1 in append mode and is writing to it. The
write FOP goes to 5th shard in this case. So the
inode->fd_count = 1 on B1(base file) and B4 (5th shard).
C2 at the same time issued unlink to F1. On the server, the
base file has fd_count = 1 (since C1 has opened the file),
the base file is renamed under .glusterfs/unlink and
returned to C2. Then unlink will be sent to shards on all
bricks and shards on B2 and B3 will be deleted which have
no open reference yet. C1 starts getting errors while
accessing the remaining shards though it has open references
for the file.
This is one such undefined behavior. Likewise we will
encounter many such undefined behaviors as we dont have one
global lock to access all shards as one. Of Course having such
global lock will lead to performance hit as it reduces window
for parallel access of shards.
Solution:
The above undefined behavior can be addressed by delaying the
unlink of a file when there are open references on it.
File unlink happens in 2 steps.
step 1: client creates marker file under .shard/remove_me and
sends unlink on base file to the server
step 2: on return from the server, the associated shards will
be cleaned up and finally marker file will be removed.
In step 2, the back ground deletion process does nameless
lookup using marker file name (marker file is named after the
gfid of the base file) in glusterfs/unlink dir. If the nameless
look up is successful then that means the gfid still has open
fds and deletion of shards has to be delayed. If nameless
lookup fails then that indicates the gfid is unlinked and no
open fds on that file (the gfid path is unlinked during final
close on the file). The shards on which deletion is delayed
are unlinked one the all open fds are closed and this is
done through a thread which wakes up every 10 mins.
Also removed active_fd_count from inode structure and
referring fd_count wherever active_fd_count was used.
fixes: #1358
Change-Id: Iec16d7ff5e05f29255491a43fbb6270c72868999
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
* features/shard: delay unlink of a file that has fd_count > 0
When there are multiple processes working on a file and if any
process unlinks that file then unlink operation shouldn't harm
other processes working on it. This is a posix a compliant
behavior and this should be supported when shard feature is
enabled also.
Problem description:
Let's consider 2 clients C1 and C2 working on a file F1 with 5
shards on gluster mount and gluster server has 4 bricks
B1, B2, B3, B4.
Assume that base file/shard is present on B1, 1st, 2nd shards
on B2, 3rd and 4th shards on B3 and 5th shard falls on B4 C1
has opened the F1 in append mode and is writing to it. The
write FOP goes to 5th shard in this case. So the
inode->fd_count = 1 on B1(base file) and B4 (5th shard).
C2 at the same time issued unlink to F1. On the server, the
base file has fd_count = 1 (since C1 has opened the file),
the base file is renamed under .glusterfs/unlink and
returned to C2. Then unlink will be sent to shards on all
bricks and shards on B2 and B3 will be deleted which have
no open reference yet. C1 starts getting errors while
accessing the remaining shards though it has open references
for the file.
This is one such undefined behavior. Likewise we will
encounter many such undefined behaviors as we dont have one
global lock to access all shards as one. Of Course having such
global lock will lead to performance hit as it reduces window
for parallel access of shards.
Solution:
The above undefined behavior can be addressed by delaying the
unlink of a file when there are open references on it.
File unlink happens in 2 steps.
step 1: client creates marker file under .shard/remove_me and
sends unlink on base file to the server
step 2: on return from the server, the associated shards will
be cleaned up and finally marker file will be removed.
In step 2, the back ground deletion process does nameless
lookup using marker file name (marker file is named after the
gfid of the base file) in glusterfs/unlink dir. If the nameless
look up is successful then that means the gfid still has open
fds and deletion of shards has to be delayed. If nameless
lookup fails then that indicates the gfid is unlinked and no
open fds on that file (the gfid path is unlinked during final
close on the file). The shards on which deletion is delayed
are unlinked one the all open fds are closed and this is
done through a thread which wakes up every 10 mins.
Also removed active_fd_count from inode structure and
referring fd_count wherever active_fd_count was used.
fixes: #1358
Change-Id: I07e5a5bf9d33c24b63da72d4f3f59392c5421652
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
* features/shard: delay unlink of a file that has fd_count > 0
When there are multiple processes working on a file and if any
process unlinks that file then unlink operation shouldn't harm
other processes working on it. This is a posix a compliant
behavior and this should be supported when shard feature is
enabled also.
Problem description:
Let's consider 2 clients C1 and C2 working on a file F1 with 5
shards on gluster mount and gluster server has 4 bricks
B1, B2, B3, B4.
Assume that base file/shard is present on B1, 1st, 2nd shards
on B2, 3rd and 4th shards on B3 and 5th shard falls on B4 C1
has opened the F1 in append mode and is writing to it. The
write FOP goes to 5th shard in this case. So the
inode->fd_count = 1 on B1(base file) and B4 (5th shard).
C2 at the same time issued unlink to F1. On the server, the
base file has fd_count = 1 (since C1 has opened the file),
the base file is renamed under .glusterfs/unlink and
returned to C2. Then unlink will be sent to shards on all
bricks and shards on B2 and B3 will be deleted which have
no open reference yet. C1 starts getting errors while
accessing the remaining shards though it has open references
for the file.
This is one such undefined behavior. Likewise we will
encounter many such undefined behaviors as we dont have one
global lock to access all shards as one. Of Course having such
global lock will lead to performance hit as it reduces window
for parallel access of shards.
Solution:
The above undefined behavior can be addressed by delaying the
unlink of a file when there are open references on it.
File unlink happens in 2 steps.
step 1: client creates marker file under .shard/remove_me and
sends unlink on base file to the server
step 2: on return from the server, the associated shards will
be cleaned up and finally marker file will be removed.
In step 2, the back ground deletion process does nameless
lookup using marker file name (marker file is named after the
gfid of the base file) in glusterfs/unlink dir. If the nameless
look up is successful then that means the gfid still has open
fds and deletion of shards has to be delayed. If nameless
lookup fails then that indicates the gfid is unlinked and no
open fds on that file (the gfid path is unlinked during final
close on the file). The shards on which deletion is delayed
are unlinked one the all open fds are closed and this is
done through a thread which wakes up every 10 mins.
Also removed active_fd_count from inode structure and
referring fd_count wherever active_fd_count was used.
fixes: #1358
Change-Id: I3679de8545f2e5b8027c4d5a6fd0592092e8dfbd
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
* Update xlators/storage/posix/src/posix-entry-ops.c
Co-authored-by: Xavi Hernandez <xhernandez@users.noreply.github.com>
* features/shard: delay unlink of a file that has fd_count > 0
When there are multiple processes working on a file and if any
process unlinks that file then unlink operation shouldn't harm
other processes working on it. This is a posix a compliant
behavior and this should be supported when shard feature is
enabled also.
Problem description:
Let's consider 2 clients C1 and C2 working on a file F1 with 5
shards on gluster mount and gluster server has 4 bricks
B1, B2, B3, B4.
Assume that base file/shard is present on B1, 1st, 2nd shards
on B2, 3rd and 4th shards on B3 and 5th shard falls on B4 C1
has opened the F1 in append mode and is writing to it. The
write FOP goes to 5th shard in this case. So the
inode->fd_count = 1 on B1(base file) and B4 (5th shard).
C2 at the same time issued unlink to F1. On the server, the
base file has fd_count = 1 (since C1 has opened the file),
the base file is renamed under .glusterfs/unlink and
returned to C2. Then unlink will be sent to shards on all
bricks and shards on B2 and B3 will be deleted which have
no open reference yet. C1 starts getting errors while
accessing the remaining shards though it has open references
for the file.
This is one such undefined behavior. Likewise we will
encounter many such undefined behaviors as we dont have one
global lock to access all shards as one. Of Course having such
global lock will lead to performance hit as it reduces window
for parallel access of shards.
Solution:
The above undefined behavior can be addressed by delaying the
unlink of a file when there are open references on it.
File unlink happens in 2 steps.
step 1: client creates marker file under .shard/remove_me and
sends unlink on base file to the server
step 2: on return from the server, the associated shards will
be cleaned up and finally marker file will be removed.
In step 2, the back ground deletion process does nameless
lookup using marker file name (marker file is named after the
gfid of the base file) in glusterfs/unlink dir. If the nameless
look up is successful then that means the gfid still has open
fds and deletion of shards has to be delayed. If nameless
lookup fails then that indicates the gfid is unlinked and no
open fds on that file (the gfid path is unlinked during final
close on the file). The shards on which deletion is delayed
are unlinked one the all open fds are closed and this is
done through a thread which wakes up every 10 mins.
Also removed active_fd_count from inode structure and
referring fd_count wherever active_fd_count was used.
fixes: #1358
Change-Id: I8985093386e26215e0b0dce294c534a66f6ca11c
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
* Update fd.c
* features/shard: delay unlink of a file that has fd_count > 0
When there are multiple processes working on a file and if any
process unlinks that file then unlink operation shouldn't harm
other processes working on it. This is a posix a compliant
behavior and this should be supported when shard feature is
enabled also.
Problem description:
Let's consider 2 clients C1 and C2 working on a file F1 with 5
shards on gluster mount and gluster server has 4 bricks
B1, B2, B3, B4.
Assume that base file/shard is present on B1, 1st, 2nd shards
on B2, 3rd and 4th shards on B3 and 5th shard falls on B4 C1
has opened the F1 in append mode and is writing to it. The
write FOP goes to 5th shard in this case. So the
inode->fd_count = 1 on B1(base file) and B4 (5th shard).
C2 at the same time issued unlink to F1. On the server, the
base file has fd_count = 1 (since C1 has opened the file),
the base file is renamed under .glusterfs/unlink and
returned to C2. Then unlink will be sent to shards on all
bricks and shards on B2 and B3 will be deleted which have
no open reference yet. C1 starts getting errors while
accessing the remaining shards though it has open references
for the file.
This is one such undefined behavior. Likewise we will
encounter many such undefined behaviors as we dont have one
global lock to access all shards as one. Of Course having such
global lock will lead to performance hit as it reduces window
for parallel access of shards.
Solution:
The above undefined behavior can be addressed by delaying the
unlink of a file when there are open references on it.
File unlink happens in 2 steps.
step 1: client creates marker file under .shard/remove_me and
sends unlink on base file to the server
step 2: on return from the server, the associated shards will
be cleaned up and finally marker file will be removed.
In step 2, the back ground deletion process does nameless
lookup using marker file name (marker file is named after the
gfid of the base file) in glusterfs/unlink dir. If the nameless
look up is successful then that means the gfid still has open
fds and deletion of shards has to be delayed. If nameless
lookup fails then that indicates the gfid is unlinked and no
open fds on that file (the gfid path is unlinked during final
close on the file). The shards on which deletion is delayed
are unlinked one the all open fds are closed and this is
done through a thread which wakes up every 10 mins.
Also removed active_fd_count from inode structure and
referring fd_count wherever active_fd_count was used.
fixes: #1358
Change-Id: I8985093386e26215e0b0dce294c534a66f6ca11c
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
* features/shard: delay unlink of a file that has fd_count > 0
When there are multiple processes working on a file and if any
process unlinks that file then unlink operation shouldn't harm
other processes working on it. This is a posix a compliant
behavior and this should be supported when shard feature is
enabled also.
Problem description:
Let's consider 2 clients C1 and C2 working on a file F1 with 5
shards on gluster mount and gluster server has 4 bricks
B1, B2, B3, B4.
Assume that base file/shard is present on B1, 1st, 2nd shards
on B2, 3rd and 4th shards on B3 and 5th shard falls on B4 C1
has opened the F1 in append mode and is writing to it. The
write FOP goes to 5th shard in this case. So the
inode->fd_count = 1 on B1(base file) and B4 (5th shard).
C2 at the same time issued unlink to F1. On the server, the
base file has fd_count = 1 (since C1 has opened the file),
the base file is renamed under .glusterfs/unlink and
returned to C2. Then unlink will be sent to shards on all
bricks and shards on B2 and B3 will be deleted which have
no open reference yet. C1 starts getting errors while
accessing the remaining shards though it has open references
for the file.
This is one such undefined behavior. Likewise we will
encounter many such undefined behaviors as we dont have one
global lock to access all shards as one. Of Course having such
global lock will lead to performance hit as it reduces window
for parallel access of shards.
Solution:
The above undefined behavior can be addressed by delaying the
unlink of a file when there are open references on it.
File unlink happens in 2 steps.
step 1: client creates marker file under .shard/remove_me and
sends unlink on base file to the server
step 2: on return from the server, the associated shards will
be cleaned up and finally marker file will be removed.
In step 2, the back ground deletion process does nameless
lookup using marker file name (marker file is named after the
gfid of the base file) in glusterfs/unlink dir. If the nameless
look up is successful then that means the gfid still has open
fds and deletion of shards has to be delayed. If nameless
lookup fails then that indicates the gfid is unlinked and no
open fds on that file (the gfid path is unlinked during final
close on the file). The shards on which deletion is delayed
are unlinked one the all open fds are closed and this is
done through a thread which wakes up every 10 mins.
Also removed active_fd_count from inode structure and
referring fd_count wherever active_fd_count was used.
fixes: #1358
Change-Id: I8985093386e26215e0b0dce294c534a66f6ca11c
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
Co-authored-by: Xavi Hernandez <xhernandez@users.noreply.github.com>
commit 74b9d50461367e95b73235d71b4deb25a8dd5587
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Wed Feb 3 11:25:46 2021 +0530
tests: 00-georep-verify-non-root-setup.t back to tests/00-geo-rep/ (#2102)
00-georep-verify-non-root-setup.t should be moved back to
tests/00-geo-rep/ from tests/000-flaky/ directory as the recent
failures encountered on the stated test case were not linked
to the test case instead they were linked to installed
libtirpc in the build environment.
Fixes: #2101
Change-Id: I2b35e9ed95ad3de68ad8574ff76805f5db64c0b2
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 88b34f842d9a0d0d6443c042cc7cf0445cc7ab95
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Mon Feb 1 11:08:42 2021 +0530
Move 00-georep-verify-non-root-setup.t to tests/000-flaky/ (#2087)
Spurious failures of 00-georep-verify-non-root-setup.t
seen only on build machines. These failures are not
reproducible even on softserve / centos / fedora machines.
So, moving test 00-georep-verify-non-root-setup.t to
tests/000-flaky/ untill the issue is RCAd at build
machines.
Fixes: #2086
Change-Id: Id1eab598fa0f9ba5ba019e6b3f057a5b10fdb0ea
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 22910dcc1046e3d7eeaba89b05093a6fcc37e172
Author: Vinayakswami Hariharmath <vharihar@redhat.com>
Date: Mon Jan 25 17:32:14 2021 +0530
features/shard: unlink fails due to nospace to mknod marker file
When we hit the max capacity of the storage space, shard_unlink()
starts failing if there is no space left on the brick to create a
marker file.
shard_unlink() happens in below steps:
1. create a marker file in the name of gfid of the base file under
BRICK_PATH/.shard/.remove_me
2. unlink the base file
3. shard_delete_shards() deletes the shards in background by
picking the entries in BRICK_PATH/.shard/.remove_me
If a marker file creation fails then we can't really delete the
shards which eventually a problem for user who is looking to make
space by deleting unwanted data.
Solution:
Create the marker file by marking xdata = GLUSTERFS_INTERNAL_FOP_KEY
which is considered to be internal op and allowed to create under
reserved space.
Fixes: #2038
Change-Id: I7facebab940f9aeee81d489df429e00ef4fb7c5d
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
commit aff178134ac8fe3b81f117df4df35cf873904493
Author: Vinayak hariharmath <65405035+VHariharmath-rh@users.noreply.github.com>
Date: Tue Jan 26 05:53:20 2021 +0530
Revert "skip the lock when refcount is not zero" (#2053)
This reverts commit 50e953e2450b5183988c12e87bdfbc997e0ad8a8.
Fixes: #2052
Change-Id: Ic0670a63423b5d79c3d48001e18910b1dbf7e98d
commit 1d90a30ab5caad4c631d8c9b9dd0f487bd343ad1
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri Jan 22 12:55:08 2021 +0300
glusterd: do not allow changing storage.linux-aio for running volume
Do not allow changing storage.linux-aio for running volume,
cleanup nearby storage.linux-io_uring error message as well.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #2039
commit de19b9a00ea35cf01076c9eb48067ad8a2e1c4aa
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Fri Jan 22 14:19:31 2021 +0200
AFR - fixing coverity issue (Argument cannot be negative) (#2026)
CID 1430124
A negative value is being passed to a parameter hat cannot be negative.
Modified the value which is being passed.
Change-Id: I06dca105f7a78ae16145b0876910851fb631e366
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 8d1bb816ad50da53882daa443ba8b724ac5babdf
Author: Xavi Hernandez <xhernandez@users.noreply.github.com>
Date: Thu Jan 21 19:45:50 2021 +0100
tests: fix tests/bugs/nfs/bug-1053579.t (#2034)
* tests: fix tests/bugs/nfs/bug-1053579.t
On NFS the number of groups associated to a user that can be passed
to the server is limited. This test created a user with 200 groups
and checked that a file owned by the latest created group couldn't
be accessed, under the assumption that the last group won't be passed
to the server.
However there's no guarantee on how the list of groups is generated,
so the latest created group could be passed as one of the initial
groups, making the allowing access to the file and causing the test
to fail (because it was expecting to not be possible).
Given that there's no way to be sure which groups will be passed, this
patch changes the test so that a check is done for each group the user
belongs to. Then we check that there have been some successes and some
failures.
Once 'manage-gids' is set, we do the same, but this time the number of
failures must be 0.
Fixes: #2033
Change-Id: Ide06da2861fcade2166372d1f3e9eb4ff2dd5f58
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 15e111418d5854db8b328e2273c91d60912a83c3
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Wed Dec 23 14:58:40 2020 +0200
posix - fix coverity issue (Unchecked return value)
CID 1291733
The return value of the method pthread_cancel was not being checked.
Added a retun value check and proper error handling.
Change-Id: I8c52b0e462461fc59718deb3b7c2f1b4e55613c7
updates: #1060
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 6cece6e03239f7e68cd0cb89e5bdff569802cda7
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Thu Jan 21 12:52:52 2021 +0200
glusterd - fixing coverity issues (#1947)
* glusterd - fixing coverity issues
- Dereference after null check (CID 1437686)
- Dereference null return value (CID 1437687)
- A check for the return value of a memory allocation was missing, added
it.
- A value of a pointer was being dereferenced after a NULL-pointer check.
With this change the pointer is no longer dereferenced.
Change-Id: I10bf8a2cb08612981dbb788315dad7dbb4efe2cb
updates: #1060
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit ca389d89f3393c05e93ff21db906f0ee73ac89d8
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Jan 21 07:45:57 2021 +0300
posix: implement AIO-based GF_FOP_FSYNC (#1953)
Implement GF_FOP_FSYNC using io_submit() with IOCB_CMD_FSYNC
and IOCB_CMD_FDSYNC operations.
Refactor common code to posix_aio_cb_init() and posix_aio_cb_fini()
as suggested by Ravishankar N.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1952
commit 01baeecff7f1e1da55543b7f79b4b519b5bec267
Author: nishith-vihar <77044911+nishith-vihar@users.noreply.github.com>
Date: Wed Jan 20 17:11:45 2021 +0530
Dereference after null reference (CID:1124543) (#2023)
'this' pointer was being dereferenced after null check. This change avoids it.
Change-Id: I7dedee44c08df481d2a037eb601f3d5c4d9284f5
Updates: #1060
Signed-off-by: Nishith Vihar Sakinala <nsakinal@redhat.com>
commit 4fac2f73bfc3211e7b33b38f38c83ff39dbd1694
Author: winndows <winndows@163.com>
Date: Wed Jan 20 01:04:39 2021 +0800
doc: Remove the unneeded backslash for glusterfs manpage (#2003)
Remove the unneeded backslash for glusterfs manpage, so
we can get "PATH" instead of "PATHR":
--dump-fuse=PATHR -> --dump-fuse=PATH
Updates: #1000
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
commit e950c6e9dd7f990fca80c0e7d5a4f624e69852ec
Author: Xavi Hernandez <xhernandez@users.noreply.github.com>
Date: Tue Jan 19 18:03:33 2021 +0100
dht: don't ignore xdata in fgetxattr (#2020)
DHT was passing NULL for xdata in fgetxattr() request, ignoring any
data sent by upper xlators.
This patch fixes the issue by sending the received xdata to lower
xlators, as it's currently done for getxattr().
Fixes: #1991
Change-Id: If3d3f1f2ce6215f3b1acc46480e133cb4294eaec
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 5b690a85baf7f6949174254127ef84fc3544902e
Author: Vinayak hariharmath <65405035+VHariharmath-rh@users.noreply.github.com>
Date: Tue Jan 19 15:39:35 2021 +0530
locks: remove unused conditional switch to spin_lock code (#2007)
* locks: remove ununsed conditional switch to spin_lock code
use of spin_locks is depend on the variable use_spinlocks
but the same is commented in the current code base through
https://review.gluster.org/#/c/glusterfs/+/14763/. So it is
of no use to have conditional switching to spin_lock or
mutex. Removing the dead code as part of the patch
Fixes: #1996
Change-Id: Ib005dd86969ce33d3409164ef3e1011bb3169129
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
* locks: remove unused conditional switch to spin_lock code
use of spin_locks is depend on the variable use_spinlocks
but the same is commented in the current code base through
https://review.gluster.org/#/c/glusterfs/+/14763/. So it is
of no use to have conditional switching to spin_lock or
mutex. Removing the dead code as part of the patch
Fixes: #1996
Change-Id: Ib005dd86969ce33d3409164ef3e1011bb3169129
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
* locks: remove unused conditional switch to spin_lock code
use of spin_locks is depend on the variable use_spinlocks
but the same is commented in the current code base through
https://review.gluster.org/#/c/glusterfs/+/14763/. So it is
of no use to have conditional switching to spin_lock or
mutex. Removing the dead code as part of the patch
Fixes: #1996
Change-Id: Ib005dd86969ce33d3409164ef3e1011bb3169129
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
commit 981fea1746253fd074b2bae2799784253d592b11
Author: Tamar Shacked <tshacked@redhat.com>
Date: Mon Jan 18 17:55:29 2021 +0200
dict: dict_reset() delete all elements using iteration
Enhance dict_reset() imp by deleting all elements using iteration
Fixes: #1536
Change-Id: Ib4d4f80bd30d52c891eb0fd4b563db19134e2328
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit 4bb3bad2ed588951a7f8cb6ac4524f539397012c
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Mon Jan 18 21:11:24 2021 +0530
shard: Fixed redundant checks done (#1769)
This patch fixes redundant checks done while calling
shard_modify_size_and_block_count.
Fixes: #1703
Change-Id: I735e532c78cbb181afa4b51480ad742ef4a75f77
Signed-off-by: Rinku Kothiya rkothiya@redhat.com
commit 541d78c4b417249a0c42ec18733e4e5c510b93dd
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Tue Jan 12 07:04:31 2021 +0000
Removing unused memory allocation
Removing extra unused type.
Removing leftovers from the RDMA
Fixes: #904
Change-Id: Id5d28622120578b7076d112e355ad8df116021dd
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 3813ffafb12d20d2b728d43b3f0eb5201e6fb7c2
Author: schaffung <ssivakum@redhat.com>
Date: Mon Jan 18 10:29:42 2021 +0530
glusterd: Removing redundant NULL checks for this and other cleanups. (#1735)
* glusterd: Removing redundant NULL checks for this
Issue: It has been noticed that the NULL checks performed
on `this` are actually being done on `THIS` as `this` is
derived from `THIS`. If the `THIS` had been NULL, the
crash would have happened before itself.
Fix: Basically removing the validations and assertion
functions which check if `this` is NULL.
Fixes: #1596
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
* Made changes wrt review comments received.
Fixes: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>
* glusterd: The efficient usage of `THIS` and `this`.
This commit addresses the review comments and tries to
change code in more places wherein the `THIS` and `this` can
be handled efficiently.
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>
* Updated commit to address review comments.
Updates: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>
* Addressing Review comments.
Updates: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>
* Made changes after regression failure.
Updates: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>
* One has to be careful while working with c
Instead of a `||` operation, the cleanup left out
with `|`. Does the compiler ceck for these things?
Updates: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>
* Fixing clang-format issues.
Change-Id: I68c52249af66080f59f57e558901f2654bd43cd8
Updates: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>
Co-authored-by: srijan-sivakumar <ssivakumar@redhat.com>
commit bc38c4ccf2d00225313d531ba1059e9d9ae59b83
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jan 15 17:03:35 2021 +0530
afr: remove memcpy() + ntoh32() pattern (#1998)
Remove memcpy and/or byte order conversions when fetching values from
the dictionary.
Fixes: #504
Change-Id: Idf2367bac8cc592c419a11ea751495e1c664ec4d
Reported-by: Yaniv Kaul <ykaul@redhat.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 7a0040b2c93a798cb9ad99d2d77eb277aacec3a3
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Jan 15 16:53:07 2021 +0530
posix: Reduce posix_fdstat() calls in IO paths (#1994)
The fops(posix_seek, posix_open, posix_readv) are calling
posix_fdstat even cloud sync is not enabled, for these specific
fops prestat is use by only cloud specific function(posix_cs_maintenance)
Fixes: #1981
Change-Id: I4d3b6c41e88925456d2f957aba6b1d2441904f73
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 8338d9a64229f79e04861944377909adbee56e00
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jan 15 10:27:56 2021 +0530
posix: use malloc in page_aligned_alloc() when possible (#2009)
- Some callers of this function do not require that the allocated buffer
be zeroed out. Use GF_MALLOC instead of GF_CALLOC for such cases.
- posix_rchecksum seems to be using the incorrect bufer size for
computing the checksum. Fixed it.
Updates: #1885
Reported-by: Yaniv Kaul <ykaul@redhat.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: I44413b1efd7b69d3a4d318639d5ebdb38a99af7f
commit d9c9367742aa29d841c737128ce3fc256e547acd
Author: Karthik Subrahmanya <ksubrahm@redhat.com>
Date: Fri Jan 15 08:07:29 2021 +0530
core: Reduce calls to THIS wherever possible (#2010)
In few functions 'THIS' is called inside a loop and saved for later
use in 'old_THIS'. Instead we can call 'THIS' only when 'old_THIS'
is NULL and reuse that itself to reduce redundant calls.
Change-Id: Ie5d4e5fe42bd4df02d101b4c199759cb84e6aee1
Fixes: #1755
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 90f18d12f581e15e398ec84fe9355ad9b63b020a
Author: mohit84 <moagrawa@redhat.com>
Date: Wed Jan 13 17:58:28 2021 +0530
tests: ./tests/bugs/replicate/bug-921231.t is continuously failing (#2006)
The test case (./tests/bugs/replicate/bug-921231.t )
is continuously failing.The test case is failing because
inodelk_max_latency is showing wrong value in profile.
The value is not correct because recently the profile
timestamp is changed from microsec to nanosec from
the patch #1833.
Fixes: #2005
Change-Id: Ieb683836938d986b56f70b2380103efe95657821
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 31895408f080c5b367c957901cdc9bb73c5c18cd
Author: Leela Venkaiah G <gleelavenkaiah@gmail.com>
Date: Wed Jan 13 16:02:25 2021 +0530
glusterfs-events: Fix incorrect attribute access (#2002)
Issue: When GlusterCmdException is raised, current code try to access
message atrribute which doesn't exist and resulting in a malformed
error string on failure operations
Code Change: Replace `message` with `args[0]`
Fixes: #2001
Change-Id: I65c9f0ee79310937a384025b8d454acda154e4bb
Signed-off-by: Leela Venkaiah G <lgangava@redhat.com>
commit 2d8c88db4e39f6434f9d385bc5a47ad41b8fc2cb
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Fri Jan 8 12:48:06 2021 +0000
avoiding memory allocation while printing trace
Printing trace can fail due to memory allocation issues
this patch avoids that.
Fixes: #1966
Change-Id: I14157303a2ff5d19de0e4ece0a460ff0cbd58c26
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit a4a97c430765bc068d8c1ffe012afd507995cdef
Author: Vinayak hariharmath <65405035+VHariharmath-rh@users.noreply.github.com>
Date: Mon Jan 11 12:34:55 2021 +0530
features/shard: avoid repeatative calls to gf_uuid_unparse() (#1689)
The issue is shard_make_block_abspath() calls gf_uuid_unparse()
every time while constructing shard path. The gfid can be parsed
and saved once and passed while constructing the path. Thus
we can avoid calling gf_uuid_unparse().
Fixes: #1423
Change-Id: Ia26fbd5f09e812bbad9e5715242f14143c013c9c
Signed-off-by: Vinayakswami Hariharmath vharihar@redhat.com
commit d0e59df00d7c00c3b8948a78bf4b9a4c1f0cc8ae
Author: schaffung <ssivakum@redhat.com>
Date: Sat Jan 9 15:41:15 2021 +0530
geo-rep : Change in attribute for getting function name in py 3 (#1900)
Issue: The schedule_geo-rep script uses `func_name` to obtain
the name of the function being referred to but from python3
onwards, the attribute has been changed to `__name__`.
Code Change:
Changing `func_name` to `__name__`.
Fixes: #1898
Change-Id: I4ed69a06cffed9db17c8f8949b8000c74be1d717
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
Co-authored-by: srijan-sivakumar <ssivakumar@redhat.com>
commit 2be07284a22508007e0f83b4b0706da28a7a774e
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Fri Jan 8 20:05:53 2021 +0530
glusterd: fix resource leak (#1970)
* glusterd: fix resource leak
Change-Id: I03b4ad477b70eeeda387ff0d161d08a7353f147e
CID: 1438341, 1438342
Updates: #1060
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
* Add check for resource leak
Change-Id: If34c8074fa4b70184d8103fd4d09695c84b907f5
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 50e953e2450b5183988c12e87bdfbc997e0ad8a8
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Thu Dec 10 15:54:10 2020 +0000
skip the lock when refcount is not zero
Fixes: #1380
Change-Id: I68bb46d2cf8b41c8e709fbeee4778e3cdfc2d46c
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit b101a90898617a542565bd61dd70d1addc9b14b2
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Jan 7 10:18:45 2021 +0530
./tests/bugs/core/bug-1432542-mpx-restart-crash.t is getting crashed
The test case ./tests/bugs/core/bug-1432542-mpx-restart-crash.t
is getting crashed at the time of detaching a brick.The brick
process is getting crashed because there is a race condition
to send a disconnect on rpc associated with victim brick and
handling GF_EVENT_CLEANUP for the victim brick.
Solution: Save victim_name on local variable to avoid crash.
Fixes: #1978
Change-Id: I76877f20b6ac0eecc39f1fa7d82afc9744dc5e04
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 1c7613520912f78c521e7be2f0fcdf4de5577d3f
Author: Nikhil Ladha <nladha@redhat.com>
Date: Fri Jan 8 13:12:46 2021 +0530
glusterd: Fix for shared storage in ipv6 env (#1972)
Change-Id: Ib38993724c709b35b603f9ac666630c50c932c3e
Fixes: #1406
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 0ed6489bd2bb8b872f4a976f15958daf322226aa
Author: Tamar Shacked <tshacked@redhat.com>
Date: Wed Jan 6 16:22:03 2021 +0200
configure: disable LTO when building with debug (#1967)
LTO isn't added to the build when it is
configured with "--enable-debug"
Fixes: #1772
Change-Id: I87300d950871bdda6542d9bbfb6bdffd500585cc
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit 1d74669ab9cce2d32abd089e806d65a5d25c64ce
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Tue Jan 5 20:00:32 2021 +0530
stripe cleanup: Remove the option from create and add-brick cmds (#1812)
* stripe cleanup: Remove the option from create and add-brick cmds
This patch aims to remove the code for stripe option instead
of keeping a default values of stripe/stripe-count variables and
setting and getting dict options and similar redundant operations.
Also removing tests for stripe volumes that have been already
marked bad.
Updates: #1000
Change-Id: Ic2b3cabd671f0c8dc0521384b164c3078f7ca7c6
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
* Fix regression error
tests/000-flaky/basic_changelog_changelog-snapshot.t
was failing due to 0 return value
Change-Id: I8ea0443669c63768760526db5aa1f205978e1dbb
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
* add constant stripe_count value for upgrade scenerios
Change-Id: I49f3da4f106c55f9da20d0b0a299275a19daf4ba
* Fix clang-format warning
Change-Id: I83bae85d10c8c5b3c66f56c9f8de1ec81d0bbc95
commit 738b23b25ef1d8998a06e2a90018d1d234e53296
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Tue Jan 5 12:29:03 2021 +0530
posix: avoiding redundant access of dictionary (#1786)
* posix: avoiding redundant access of dictionary
This patch fixes the redundant access of dictionary
for the same information by the macro PL_LOCAL_GET_REQUESTS
fixes: #1707
Change-Id: I48047537436ce920e74bc11cecd9773d7fe4457c
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
* posix: avoiding redundant access of dictionary
- Converted the macro SET_BIT to function set_bit
- Removed the code to delete the key GLUSTERFS_INODELK_DOM_COUNT
- Assigned the value to local->bitfield
Change-Id: I101f3fda65e9e75e05907d671203c5d7f072fa8f
Fixes: #1707
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
* posix: avoiding redundant access of dictionary
deleted GLUSTERFS_INODELK_DOM_COUNT key
Change-Id: I638269e6a9f6fc11351eaede4c103e032881fe12
Fixes: #1707
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
* posix: avoiding redundant access of dictionary
Smoke test warnings fixed.
Fixes: #1707
Change-Id: I8682bd0e49f44cbc1442324e1756b56481f18ccd
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit bba4e92de9f93020f36976e66f36440386f38a3d
Author: Mohammed Ashour <m.aly.ashour@gmail.com>
Date: Thu Dec 31 06:15:47 2020 +0200
Fixing the split-brain link where going for a 2 replicated volume. (#1964)
Fixes in functions:
- cli_cmd_volume_create_parse()
- cli_cmd_volume_add_brick_parse()
- cli_cmd_volume_remove_brick_parse()
Fixes: #1959
Signed-off-by: Mohammed Ali Ashour <m.aly.ashour@gmail.com>
commit 146b35d1ba57f4d99ae5046307c53b8952413ce7
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Nov 25 12:12:58 2020 +0530
extras, tools, doc: remove offensive language
Replace master and slave terminology in geo-replication with primary and
secondary respectively.
Change-Id: I3eb9242d2ce8340435265b764d28221d50f872c8
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 53344d8dae0db54568c5952d7bd117e36a4af829
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Nov 23 16:53:42 2020 +0530
geo-rep: remove offensive language
Change-Id: I9e34ccfd28029209262874993836dd36ad3c9c01
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 6c446ee57ca85653650fe0a2c94c57ebfeb302fc
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Nov 11 16:43:03 2020 +0530
tests: remove offensive language
TODO:
Remove 'slave-timeout' and 'slave-gluster-command-dir'.
These variables are defined in geo-replication/gsyncd.conf.in.
So I will remove them when I change that folder.
Change-Id: Ib9167ca586d83e01f8ec755cdf58b3438184c9dd
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit aa29aaf1c982c95c7df9d765288c2f779ac4bfb2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Oct 8 11:07:03 2020 +0530
cli/glusterd: conscious language changes for geo-rep
Replace master and slave terminology in geo-replication with primary and
secondary respectively.
All instances are replaced in cli and glusterd.
Changes to other parts of the code to follow in separate patches.
tests/00-geo-rep/* are passing thus far.
Updates: #1415
Change-Id: Ifb12b7f5ce927a4a61bda1e953c1eb0fdfc8a7c5
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 5704411b5e464ab3ddfad6d224f43f58eff2f1ed
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Wed Dec 23 13:40:07 2020 +0200
DHT/Rebalance - removing an unneeded subvol calculation and comparison (#1803)
* DHT/Rebalance - removing an unneeded subvol calculation and comparison
During the data migration phase of rebalance, an unneeded calculation
and comparison is made. These operations are not required, as the
information is already cached.
Removing the unneeded operations.
fixes: ##1801
Change-Id: I9bce8152c7936a73edc4704b2f9d4f0f241ce13e
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 579d2307ed10c2179973a50d175516b3a99328a4
Author: Tamar Shacked <tshacked@redhat.com>
Date: Tue Dec 22 16:00:50 2020 +0200
DHT: fix coverity issue - argument cannot be negative (#1942)
CID 1438086:
Initialize op_errno to a positive error, because it
might be passed to a parameter that cannot be negative.
updates: #1060
Change-Id: I1b5fda4dbbd5b1a50ea1c293af3b265d385d891c
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit ff3445dcb5482d6b5c10fe95e81d5587ff2f9c07
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Mon Dec 21 05:42:36 2020 +0200
NFS - Fixing a clang issue (#1938)
Smoke tests verified PR https://github.com/gluster/glusterfs/pull/1894
even though there was a clang issue present and the PR was merged.
Smoke tests have been fixed so sending this PR to rectify the clang
issue.
Change-Id: I3df5d2c77d9f3dd1872f2f28824565d5f24d82ec
updates: #1060
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit c601eda7c954a6846a3101e76b24cbdb2bdae56c
Author: Amar Tumballi <amar@kadalu.io>
Date: Sun Dec 20 19:10:49 2020 +0530
glusterd: start brick process with proper logger option (#1936)
Check if 'glusterd' is started with `--logger` option as syslog, and
use the same option to brick processes.
Updates: #1935
Change-Id: Ib0ea76322d48cccf6db30097bffe01903125650e
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit e7e417b6aaa23c8c596c7109e11071e38725b1cd
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Sun Dec 20 11:02:12 2020 +0200
DHT - Remove redundant lookup operation in Rebalance (#1696)
* DHT - Remove redundant lookup operation in Rebalance
Remove a redundant lookup (and correlated operations)
and slightly changed error handling.
- The lookup which is removed is redundant as a lookup
on the dir specified by "loc" is done at the entry to
the method.
- Error handling was changed a bit to remove special handling
for "root" dir (as it is not necessary).
In addition, error handling was changed so increments of
defrag->total_failures in case of a failure will done inside the
error-checking blocks of the operations inside gf_defrag_fix_layout
instead of in the calling methods.
fixes: #1695
Change-Id: I85c8791988bd314ce706d3627e01e15e4f983329
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 260e9765d698702fb9852db8c5d73d0148a5b17d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Dec 18 16:28:29 2020 +0530
dht: handle DHT_SUBVOL_STATUS_KEY in dht_pt_getxattr (#1934)
In non distribute volumes (plain replicate, ec), DHT uses pass-through
FOPs (dht_pt_getxattr) instead of the usual FOPS (dht_getxattr). The
pass through FOP was not handling the DHT_SUBVOL_STATUS_KEY virtual
xattr because of which geo-rep session was going into a faulty state.
Fixing it now.
updates: #1925
Change-Id: I766b5b5c047c954a9957ab78aca680eedef1ff1f
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 2a4e041470ae80d0cb3427a04964b73ce89a6778
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Fri Dec 18 06:20:08 2020 +0200
AFR - Fixing Coverity issue (Illegal memory access) (#1893)
CID 1437682
Fixing use-after-free bug by setting the released pointer to NULL
Change-Id: Id08f415577df86245e3926f59ac0ba2c23a663dc
updates: #1060
Signed-off-by: Barak Sason Rofman bsasonro@redhat.com
commit 085790d71c8de4551688ce07b88bdbb6f98c6d69
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Thu Dec 17 11:30:20 2020 +0200
NFS - Fixing Coverity issue (Dereference null return value) (#1894)
CID 1430123
Fixing dereference null return value by checking the value returned by
an allocating method
Change-Id: I3fc18208fd4cec2db4b2b5d1f47ef7d7f1c9a4b3
updates: #1060
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 6e5fc2756368f38a99c11a4895beeadf644b756f
Author: Shree Vatsa N <vatsa@kadalu.io>
Date: Thu Dec 17 09:20:24 2020 +0530
io-stats: Change latency to nanoseconds from microseconds (#1833)
- In 'BUMP_THROUGHPUT' macro changed 'elapsed' from microseconds to nanoseconds.
- In 'update_ios_latency' function 'elapsed' is now in nanoseconds.
- In 'collect_ios_latency_sample' function removed conversion from nano to micro,
instead directly assigned as 'nano' to 'tv_nsec' of 'timespec' macro
- in 'ios_sample_t' macro changed 'timeval' to 'timespec' to support above change.
- In '_io_stats_write_latency_sample' function changed formula to from 1e+6 to 1e+9
since 'ios_sample_t' macro now has 'timespec'
- In 'BUMP_THROUGHPUT','_ios_sample_t','collect_ios_latency_sample' & update_ios_latency'
changed 'elapsed' datatype from 'double' to 'int64_t'
- In glusterfs/libglusterfs/src/glusterfs/common-utils.h changed return type of
'gf_tsdiff' function from 'double' to 'int64_t' since it can return negative values.
- In glusterfs/libglusterfs/src/latency.c, libglusterfs/src/glusterfs/common-utils.h,
xlators/debug/io-stats/src/io-stats.c & xlators/storage/posix/src/posix-helpers.c
'elapsed' is now of type 'int64_t'
Fixes: #1825
Signed-off-by: Shree Vatsa N <vatsa@kadalu.io>
commit 222b92d951a8e6aef59a9c8f4170bc72a6dddb82
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Dec 16 14:17:14 2020 +0100
run-tests.sh: check for killall (#1920)
Inspired by getting bitten by a misbehaving
run-tests.sh on a fresly created VM which
lacked killall(1).
Change-Id: I810e3e9e6c2947829011f7d15009598390408f7b
Updates: #1000
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 5ab07676a1c0d56710d5201643d0ea03ef378b7f
Author: Tamar Shacked <tshacked@redhat.com>
Date: Wed Dec 16 08:42:50 2020 +0200
configure: enabling LTO with gcc 10 or above (#1791)
* configure: enabling LTO with gcc 10 or above
Adding LTO to the build when gcc_version >= 10
Applicable for source and RPMs build
To disable: ./configure --disable-lto
Fixes: #1772
Change-Id: Ia50210af2e88a5cc188c47b4e61a66397e179257
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit a7761a483dd43e5973e00d79cd0947aab789179a
Author: mohit84 <moagrawa@redhat.com>
Date: Wed Dec 16 11:35:31 2020 +0530
core: Implement gracefull shutdown for a brick process (#1751)
* core: Implement gracefull shutdown for a brick process
glusterd sends a SIGTERM to brick process at the time
of stopping a volume if brick_mux is not enabled.In case
of brick_mux at the time of getting a terminate signal
for last brick a brick process sends a SIGTERM to own
process for stop a brick process.The current approach
does not cleanup resources in case of either last brick
is detached or brick_mux is not enabled.
Solution: glusterd sends a terminate notification to a
brick process at the time of stopping a volume for gracefull
shutdown
Change-Id: I49b729e1205e75760f6eff9bf6803ed0dbf876ae
Fixes: #1749
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
* core: Implement gracefull shutdown for a brick process
Resolve some reviwere comment
Fixes: #1749
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I50e6a9e2ec86256b349aef5b127cc5bbf32d2561
* core: Implement graceful shutdown for a brick process
Implement a key cluster.brick-graceful-cleanup to enable graceful
shutdown for a brick process.If key value is on glusterd sends a
detach request to stop the brick.
Fixes: #1749
Change-Id: Iba8fb27ba15cc37ecd3eb48f0ea8f981633465c3
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
* core: Implement graceful shutdown for a brick process
Resolve reviewer comments
Fixes: #1749
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I2a8eb4cf25cd8fca98d099889e4cae3954c8579e
* core: Implement gracefull shutdown for a brick process
Resolve reviewer comment specific to avoid memory leak
Fixes: #1749
Change-Id: Ic2f09efe6190fd3776f712afc2d49b4e63de7d1f
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
* core: Implement gracefull shutdown for a brick process
Resolve reviewer comment specific to avoid memory leak
Fixes: #1749
Change-Id: I68fbbb39160a4595fb8b1b19836f44b356e89716
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 459c5a004137123c6529124a1596b4cccaccbee7
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Oct 15 21:06:16 2020 +0200
fuse: render gfid only once in fuse_invalidate_entry()
Change-Id: I6073489a8308c6f518438d2ad2348a0c4cd5f805
Fixes: #1545
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 14d0f9b32693402695544fa0a0ba772252876784
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Oct 28 20:58:52 2020 +0100
fuse: fix dispatch of requests when dumping
fuse_dumper() is a wrapper for fuse request
handlers that performs its specific task
(dumping the request), then delegates to the
standard handler for the given FUSE opcode.
This should be a faithful delegation, the
standard handlers should be invoked the same
way as without passing through fuse_dumper().
However, the call to the handler has nulled
out the last argument, iobuf.
This gets fixed here.
Change-Id: I7bd9a20dfdc46f162076f350826cadf69f9c78a7
Updates: #1000
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 68987b050cc1a0fcf088ab981acbe6a2d1b22972
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Oct 15 23:31:08 2020 +0200
fuse: sanitize FUSE_OP_HIGH
The idea behind FUSE_OP_HIGH was that it should be
the upper limit for the opcodes we can ever get from kernel
(maximum opcode that can occur plus one).
The problem with this idea is that this depends on the FUSE
protocol version; and since the fuse proto header does not export
this value, it has to be retroactively defined considering
the particular opcode values in the protocol header. That is, not
just the value, but the definition itself depends on the FUSE
protocol version. So we ended up maintaining -- or indeed, not
even maintaining, just living with -- a mess of conditional
defines for FUSE_OP_HIGH.
Now we change the meaning of it: FUSE_OP_HIGH will simply be
upper limit of the opcodes for which we define a handler
(the highest such opcode plus one, which is the same as the
size of the fuse optable).
The practical implication of this change is as follows.
Potentially there is a gap between the new and the old value
of FUSE_OP_HIGH: those opcodes which might occur in requests
but are higher than any opcode we handle. With the old definition
of FUSE_OP_HIGH we could statically dispatch these opcodes to
fuse_enosys() (a function that sends a FUSE response with error
ENOSYS).
With the new definition we don't know the upper limit of this gap,
so we need to dispatch the opcodes of the gap to fuse_enosys()
dynamically (perform a runtime check if the opcode is
greater-or-equal than the new FUSE_OP_HIGH, and if yes, then call
fuse_enosys()).
Change-Id: I8cd26ead538de8ce36c91feaf938e4c5dc59c88c
Updates: #1000
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 9c2bd7cbf6c00604d12a42de463e09739f6a84bc
Author: Amar Tumballi <amar@kadalu.io>
Date: Tue Dec 15 02:13:47 2020 +0530
CONTRIBUTING: Update details on how to join the team (#1895)
Updates: #1584
Change-Id: Ib9e577c04ccf13167bfe605ddc9b6b27c2720f5c
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 715d1c73860266442cfe424ab0cfa96448726f99
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Mon Dec 14 17:46:46 2020 +0530
core: Updated the GD_OP_VERSION (#1889)
fixes: #1888
Change-Id: Ibe336f6f7f19cd148523f65b6fa2b81dca1bd7b6
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 5d577d509cfff9ed12fe33e581ab3d318483f84c
Author: mohit84 <moagrawa@redhat.com>
Date: Mon Dec 14 15:37:35 2020 +0530
core: Convert mem_get(0) and mem_put functions to Macors (#1908)
* core: Convert mem_get(0) and mem_put functions to Macors
Problem: Currently mem_get(0) and mem_put functions access
memory pools those are not required while mem-pool
is disabled.
Change-Id: Ief9bdaeb8637f5bc2b097eb6099fb942130e08ae
Solution: Convert mem_get(0) functions as a Macros
Fixes: #1359
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
* core: Convert mem_get(0) and mem_put functions to Macors
Resolver reviewer comments
Fixes: #1359
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I8dfdfc1a1cd9906e442271abefc7a635e632581e
commit ee46e28c4c4fbf109883039c9d57f0c6bfb405da
Author: Nikhil Ladha <nladha@redhat.com>
Date: Sat Dec 12 09:28:14 2020 +0530
runner: fix for coverity issues in runner_start() (#1902)
Fix:
Fixed dead code and few unused assignments in the runner_start()
in run.c file.
CID:1437641
CID:1437644
CID:1437646
Updates: #1060
Change-Id: I30ac234e9ff1f768b0e33a81eb3ffbf0de576784
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 9c16588e53d736252a99a8711c44a4cbf4eaec2b
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Sat Dec 12 09:25:47 2020 +0530
Improve error handling (#1914)
Fixes: #1678
Change-Id: I566cd8bfd22c0ef63fcd44a8cea32366388a93e5
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit de1b26d68e31b029a59e59a47b51a7e3e6fbfe22
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Dec 11 18:19:37 2020 +0530
core: Avoid several dict OR key is NULL message in brick logs (#1910)
Problem: dict_get_with_ref throw a message "dict or key is NULL"
if dict or key is NULL.
Solution: Before access a key check if dictionary is valid.
Fixes: #1909
Change-Id: I50911679142b52f854baf20c187962a2a3698f2d
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit ae8cfe5baaff5b3e4c55f49ec71811e32a885271
Author: Tamar Shacked <tshacked@redhat.com>
Date: Tue Dec 8 12:51:35 2020 +0200
glusterd/cli: enhance rebalance-status after replace/reset-brick (#1869)
* glusterd/cli: enhance rebalance-status after replace/reset-brick
Rebalance status is being reset during replace/reset-brick operations.
This cause 'volume status' to shows rebalance as "not started".
Fix:
change rebalance-status to "reset due to (replace|reset)-brick"
Change-Id: I6e3372d67355eb76c5965984a23f073289d4ff23
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
* glusterd/cli: enhance rebalance-status after replace/reset-brick
Rebalance status is being reset during replace/reset-brick operations.
This cause 'volume status' to shows rebalance as "not started".
Fix: change rebalance-status to "reset due to (replace|reset)-brick"
Fixes: #1717
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
Change-Id: I1e3e373ca3b2007b5b7005b6c757fb43801fde33
* cli: changing rebal task ID to "None" in case status is being reset
Rebalance status is being reset during replace/reset-brick operations.
This cause 'volume status' to shows rebalance as "not started".
Fix:
change rebalance-status to "reset due to (replace|reset)-brick"
Fixes: #1717
Change-Id: Ia73a8bea3dcd8e51acf4faa6434c3cb0d09856d0
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit 3da6ae5edc4b8cd7a922769bb973365f1b4399a5
Author: schaffung <ssivakum@redhat.com>
Date: Tue Dec 8 10:14:35 2020 +0530
CONTRIBUTING.md Regression rights changed. (#1762)
Regression can now be run by people part of gluster org.
The contributing markdown should reflect the same.
Fixes: #1761
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>
commit f8bd04fb3ba0fff04abd0c6fff19f42c59376617
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Mon Dec 7 11:24:43 2020 +0530
glusterd: modify logic for checking hostname in add-brick (#1781)
* glusterd: modify logic for checking hostname in add-brick
Problem: add-brick command parses only the bricks provided
in cli for a subvolume. If in same subvolume bricks are
increased, these are not checked with present volume bricks.
Fixes: #1779
Change-Id: I768bcf7359a008f2d6baccef50e582536473a9dc
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
* removed assignment of unused variable
Fixes: #1779
Change-Id: Id5ed776b28343e1225b9898e81502ce29fb480fa
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
* few more changes
Change-Id: I7bacedb984f968939b214f9d13546f4bf92e9df7
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
* few more changes
Change-Id: I7bacedb984f968939b214f9d13546f4bf92e9df7
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
* correction in last commit
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
Change-Id: I1fd0d941cf3f32aa6e8c7850def78e5af0d88782
commit 7fe657b8bec2b7020979de32088164e5c254adce
Author: 川島和津実 <Kawashima-Azumi@users.noreply.github.com>
Date: Mon Dec 7 12:04:54 2020 +0800
configure.ac: correct withval logic (#1861)
for `--without-server` check
commit e49ad9497f73c3a145357a72d6ea28c4f26b082e
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Dec 4 15:33:29 2020 +0530
cluster/afr: Remove redundant afr_fd_ctx_get calls (#1718)
Description:
__afr_fd_ctx_get() is calling __fd_ctx_get().
If that fails, it goes to __afr_fd_ctx_set().
__afr_fd_ctx_set() is now calling __fd_ctx_get() again.
When we get back from __afr_fd_ctx_set(), we are calling
__fd_ctx_get() again.
we could just change __afr_fd_ctx_set() to return ctx as
the return value and NULL in case of failure.
Change-Id: Ifdb9b86984a3438abac52b2b74a8f0e0a4966093
updates: #1251
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit dac553ce97bac23477109180b3c57280aa688d0d
Author: Amar Tumballi <amar@kadalu.io>
Date: Fri Dec 4 09:51:15 2020 +0530
glfsheal: provide an option to provide volfile as an option (#1875)
with this option, `glfsheal` command can now work with a volume file.
This is helpful to provide quick access to tools which can work without
glusterd support.
Fixes: #1872
Change-Id: Ibad329735d4e17cecc3a77b5067d1e8f8c4eb4e2
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 1bb967c0c245e80107c5526f031cfc8a90b78af6
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Fri Dec 4 06:20:59 2020 +0200
DHT/Rebalance -removing unused variable (#1795)
Removing an unused variable from rebalance data migration path
fixes: #1773
Change-Id: I5f9f8d2a25e888cfc79978170809c7ae66ad839a
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit d84a9b1ab0ceb2642e7c38b6d6c74ce5180b33da
Author: schaffung <ssivakum@redhat.com>
Date: Fri Dec 4 09:50:27 2020 +0530
MAINTAINERS: Events API (#1758)
Added Srijan as peer in events API
Updates: #1584
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit 323478dbb0058f34ae404c1f2981fea29c65cf3f
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Dec 4 09:23:05 2020 +0530
core: Optimize _xlator->stats structure to make memory access friendly (#1866)
* core: Optimize _xlator->stats structure to make memory access friendly
Current xlator->stats is not efficient for frequently access memroy
variables, to make it friendly optimize stats structure.
Fixes: #1583
Change-Id: I5c9d263b11d9bbf0bf5501e461bdd3cce03591f9
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
* core: Optimize _xlator->stats structure to make memory access friendly
Resolve reviewer comments
Fixes: #1583
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I44a728263bfc397158dc95e4a9bae393fd3c9883
* core: Optimize _xlator->stats structure to make memory access friendly
Resolve reviewer comments
Fixes: #1583
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I55e093e3f639052644ce6379cbbe2a15b0ef4be7
commit b9a4120b2bb77b23c43982e3579f4569a2608fde
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Dec 1 18:00:59 2020 +0530
all: change 'primary' to 'root' where it makes sense
As a part of offensive language removal, we changed 'master' to 'primary' in
some parts of the code that are *not* related to geo-replication via
commits e4c9a14429c51d8d059287c2a2c7a76a5116a362 and
0fd92465333be674485b984e54b08df3e431bb0d.
But it is better to use 'root' in some places to distinguish it from the
geo-rep changes which use 'primary/secondary' instead of 'master/slave'.
This patch mainly changes glusterfs_ctx_t->primary to
glusterfs_ctx_t->root. Other places like meta xlator is also changed.
gf-changelog.c is not changed since it is related to geo-rep.
Updates: #1000
Change-Id: I3cd610f7bea06c7a28ae2c0104f34291023d1daf
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 76c8def3b5cc827006c38c8dda4ea467d8bb22be
Author: Nikhil Ladha <nladha@redhat.com>
Date: Wed Dec 2 13:12:18 2020 +0530
runner: moving to posix_spawnp instead of fork (#1644)
* runner: moving to posix_spawnp instead of fork
Removed the fork(), and implemented the
posix_spwanp() acccrodingly, as it provides much better
performance than fork(). More detailed description about
the benefits can be found in the description of the issue
linked below.
Fixes:#810
Signed-off-by: nik-redhat <nladha@redhat.com>
* Added the close_fds_except call
Signed-off-by: nik-redhat <nladha@redhat.com>
* Added comments
Signed-off-by: nik-redhat <nladha@redhat.com>
* Made the functions static
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 12545d91eed27ff9abb0505a12c7d4e75b45a53e
Author: mohit84 <moagrawa@redhat.com>
Date: Mon Nov 30 17:39:53 2020 +0530
glusterd[brick_mux]: Optimize friend handshake code to avoid call_bail (#1614)
During glusterd handshake glusterd received a volume dictionary
from peer end to compare the own volume dictionary data.If the options
are differ it sets the key to recognize volume options are changed
and call import syntask to delete/start the volume.In brick_mux
environment while number of volumes are high(5k) the dict api in function
glusterd_compare_friend_volume takes time because the function
glusterd_handle_friend_req saves all peer volume data in a single dictionary.
Due to time taken by the function glusterd_handle_friend RPC requests receives
a call_bail from a peer end gluster(CLI) won't be able to show volume status.
Solution: To optimize the code done below changes
1) Populate a new specific dictionary to save the peer end version specific
data so that function won't take much time to take the decision about the
peer end has some volume updates.
2) In case of volume has differ version set the key in status_arr instead
of saving in a dictionary to make the operation is faster.
Note: To validate the changes followed below procedure
1) Setup 5100 distributed volumes 3x1
2) Enable brick_mux
3) Start all the volumes
4) Kill all gluster processes on 3rd node
5) Run a loop to update volume option on a 1st node
for i in {1..5100}; do gluster v set vol$i performance.open-behind off; done
6) Start the glusterd process on the 3rd node
7) Wait to finish handshake and check there should not be any call_bail message
in the logs
Change-Id: Ibad7c23988539cc369ecc39dea2ea6985470bee1
Fixes: #1613
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 0fd92465333be674485b984e54b08df3e431bb0d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Nov 26 11:11:16 2020 +0530
change 'master' xlator to 'primary' xlator
These were the only offensive language occurences in the code (.c) after
making the changes for geo-rep (whichis tracked in issue 1415).
Change-Id: I21cd558fdcf8098e988617991bd3673ef86e120d
Updates: #1000
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit de4861c88c189f302b86e96d11b689fa7ab1078d
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Sun Nov 29 12:30:08 2020 +0530
Add tar as dependency to geo-rep rpm for RHEL 8.3 and above (#1850)
Reason: from RHEL 8.3, tar is not bundled by default
Fixes: #1849
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
Change-Id: Ic1424e0550cef6a78e3e9e7b42665ab01016436f
commit 4a6506c6c9d754f80537d74cb6f2a265edddcc84
Author: chenglin130 <35245387+chenglin130@users.noreply.github.com>
Date: Sun Nov 29 14:58:47 2020 +0800
build: introduce a check before use git (#1856)
When compile GlusterFS without git repository, a git error will fail the make.
Avoid to execute git commands when there is no git repository.
Fixes: #1855
Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
commit 31fd279699b67550f56454379a91648e1c3b670a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Nov 26 20:28:13 2020 +0530
afr: return -EIO for gfid split-brains. (#1819)
Problem:
entry-self-heal-anon-dir-off.t was failing occasionally because
afr_gfid_split_brain_source() returned -1 instead of -EIO for
split-brains, causing the code to proceed to afr_lookup_done(), which
in turn succeeded the lookup if there was a parallel client side heal
going on.
Fix:
Return -EIO instead of -1 so that lookp fails.
Also, afr_selfheal_name() was using the same dict to get and set values. This
could be problematic if the caller passed local->xdata_req, since
setting a response in a request dict can lead to bugs.So changed it to use
separate request and response dicts.
Fixes: #1739
Credits Pranith Karampuri <pranith.karampuri@phonepe.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: I5cb4c547fb25e6bfc8bec1740f7eb64e1a5ad443
commit 177563263ddc0bb69b1ae8debacc900cab9fdac4
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Tue Nov 24 12:56:10 2020 +0200
DHT/Rebalance - Ensure Rebalance reports status only once upon stopping (#1783)
DHT/Rebalance - Ensure Rebalance reports status only once upon stopping
Upon issuing rebalance stop command, the status of rebalance is being
logged twice to the log file, which can sometime result in an
inconsistent reports (one report states status stopped, while the other
may report something else).
This fix ensures rebalance reports it's status only once and that the
correct status is being reported.
fixes: #1782
Change-Id: Id3206edfad33b3db60e9df8e95a519928dc7cb37
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 0e6eacdb51f69c560832d502de418a197cdcdf98
Author: mohit84 <moagrawa@redhat.com>
Date: Tue Nov 24 16:00:17 2020 +0530
posix: In the commit 2f044c4587c6db3cb82b6128f056ec2ea2bc1b98 the ret (#1837)
update was missed in the function posix_get_gfid2path if
GF_MALLOC is failed.
Solution: Update the ret value to -1 if GF_MALLOC is failed
Fixes: #1836
Change-Id: I510ebf0605ee49b84ff3570948771319f283b10e
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 06d5cd06724bbef7970167df1cdd191717672cff
Author: mohit84 <moagrawa@redhat.com>
Date: Tue Nov 24 15:29:58 2020 +0530
core: tcmu-runner process continuous growing logs lru_size showing -1 (#1776)
* core: tcmu-runner process continuous growing logs lru_size showing -1
At the time of calling inode_table_prune it checks if current lru_size
is greater than lru_limit but lru_list is empty it throws a log message
"Empty inode lru list found but with (%d) lru_size".As per code reading
it seems lru_size is out of sync with the actual number of inodes in
lru_list. Due to throwing continuous error messages entire disk is
getting full and the user has to restart the tcmu-runner process to use
the volumes.The log message was introduce by a patch
https://review.gluster.org/#/c/glusterfs/+/15087/.
Solution: Introduce a flag in_lru_list to take decision about inode is
being part of lru_list or not.
Fixes: #1775
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I4b836bebf4b5db65fbf88ff41c6c88f4a7ac55c1
* core: tcmu-runner process continuous growing logs lru_size showing -1
Update in_lru_list flag only while modify lru_size
Fixes: #1775
Change-Id: I3bea1c6e748b4f50437999bae59edeb3d7677f47
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
* core: tcmu-runner process continuous growing logs lru_size showing -1
Resolve comments in inode_table_destroy and inode_table_prune
Fixes: #1775
Change-Id: I5aa4d8c254f0fe374daa5ec604f643dea8dd56ff
Signed-off-by: Mohit Agrawal moagrawa@redhat.com
* core: tcmu-runner process continuous growing logs lru_size showing -1
Update in_lru_list only while update lru_size
Fixes: #1775
Change-Id: I950eb1f0010c3d4bcc44a33225a502d2291d1a83
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 4d336a753b67a7ac000d4989d6d36e9ba78b5c99
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Tue Nov 24 08:15:57 2020 +0530
remove ganesha from Obsoletes in glusterfs.spec.in (#1823)
Change-Id: I65d488674763160b06d8f248ff74ea4d144ecf8b
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit f74d3ab643a00632fdeb9b4912211b1767fa120a
Author: Vinayak hariharmath <65405035+VHariharmath-rh@users.noreply.github.com>
Date: Mon Nov 23 08:09:44 2020 +0530
enahancement/debug: Option to generate core dump without killing the process (#1814)
Comments and idea proposed by: Xavi Hernandez(jahernan@redhat.com):
On production systems sometimes we see a log message saying that an assertion
has failed. But it's hard to track why it failed without additional information
(on debug builds, a GF_ASSERT() generates a core dump and kills the process,
so it can be used to debug the issue, but many times we are only able to
reproduce assertion failures on production systems, where GF_ASSERT() only logs
a message and continues).
In other cases we may have a core dump caused by a bug, but the core dump doesn't
necessarily happen when the bug has happened. Sometimes the crash happens so much
later that the causes that triggered the bug are lost. In these cases we can add
more assertions to the places that touch the potential candidates to cause the bug,
but the only thing we'll get is a log message, which may not be enough.
One solution would be to always generate a core dump in case of assertion failure,
but this was already discussed and it was decided that it was too drastic. If a
core dump was really needed, a new macro was created to do so: GF_ABORT(),
but GF_ASSERT() would continue to not kill the process on production systems.
I'm proposing to modify GF_ASSERT() on production builds so that it conditionally
triggers a signal when a debugger is attached. When this happens, the debugger
will generate a core dump and continue the process as if nothing had happened.
If there's no debugger attached, GF_ASSERT() will behave as always.
The idea I have is to use SIGCONT to do that. This signal is harmless, so we can
unmask it (we currently mask all unneeded signals) and raise it inside a GF_ASSERT()
when some global variable is set to true.
To produce the core dump, run the script under extras/debug/gfcore.py on other
terminal. gdb breaks and produces coredump when GF_ASSERT is hit.
The script is copied from #1810 which is written by Xavi Hernandez(jahernan@redhat.com)
Fixes: #1810
Change-Id: I6566ca2cae15501d8835c36f56be4c6950cb2a53
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
commit da5ac9ae437079b20d5d559171be16d2d90ec46a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Nov 19 11:16:30 2020 +0530
glusterd: fix a bug in enabling nfs ganesha (#1813)
As detailed in the github issue,`gluster volume set Svolname ganesha.enable on`
is currently broken due to a minor typo in the commit e081ac683b6a5bda548913,
Fixing it now.
Updates: #1778
Change-Id: I99276fedc43f40e8a439e545bd2b8d1698aa03ee
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Strahil Nikolov <hunter86_bg@yahoo.com>
commit ec023965a224b88f97c2c0e50015280393f76c5a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Nov 17 15:37:52 2020 +0530
posix: fix io_uring crash in reconfigure (#1804)
Call posix_io_uring_fini only if it was inited to begin with.
Fixes: #1794
Reported-by: Mohit Agrawal <moagrawa@redhat.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: I0e840b6b1d1f26b104b30c8c4b88c14ce4aaac0d
commit 438fc46c0bef91019483962dfec56a5520158058
Author: mohit84 <moagrawa@redhat.com>
Date: Tue Nov 17 12:41:57 2020 +0530
afr: call afr_is_lock_mode_mandatory only while xdata is valid (#1797)
afr_is_lock_mode_mandatory throws a warning message while xdata
is not valid, to avoid a message call a function only while xdata
is valid.
Fixes: #1796
Change-Id: I32d37960ea4e936ba87e65811c1792a2f1158c0d
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit b8ad18a260bf1fb34af92bd948df9142e0a08f51
Author: Nikhil Ladha <nladha@redhat.com>
Date: Thu Nov 12 14:04:27 2020 +0530
glusterd: resource leaks (#1748)
Issue:
iobref was not freed before exiting the function
if all the checks were OK, which caused the resource
leak.
Fix:
Modified the code a bit to avoid use of an extra reference
to the label, and to free the iobref and iobuf if not NULL,
and then exit the function.
CID: 1430118
Updates: #1060
commit 4026fe9a956238d8e4785cf39c3b7290eae90f03
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Nov 6 16:52:07 2020 -0500
ganesha-ha: revised regex exprs for --status
better whitespace in regex
This has worked for years, but somehow no longer works on rhel8
Updates: #1000
Change-Id: I2c1a3537573d125608334772ba1a263c55407dd4
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 3f93be77e1acf5baacafa97a320e91e6879d1c0e
Author: mohit84 <moagrawa@redhat.com>
Date: Mon Nov 9 17:15:42 2020 +0530
posix: Attach a posix_spawn_disk_thread with glusterfs_ctx (#1595)
Currently posix xlator spawns posix_disk_space_threads per brick and in
case of brick_mux environment while glusterd attached bricks at maximum
level(250) with a single brick process in that case 250 threads are
spawned for all bricks and brick process memory size also increased.
Solution: Attach a posix_disk_space thread with glusterfs_ctx to
spawn a thread per process basis instead of spawning a per brick
Fixes: #1482
Change-Id: I8dd88f252a950495b71742e2a7588bd5bb019ec7
Signed-off-by: Mohit Agrawal moagrawa@redhat.com
commit 6562347ab9525f6e8c4fa9e6d40626ef572604ce
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Nov 9 10:42:34 2020 +0530
Modify templet to file an issue on gluster (#1759)
Add more sections to get more information from user to avoid back and forth queries.
This will help community to provide faster resolution.
Change-Id: I88be0214cea7cfa979bedb4aab7c312e0ff8d5f3
Updates: #1743
commit 4344103ab36c55525d130c1096454c0499db60c6
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Sat Nov 7 12:09:36 2020 +0530
logger: Always print errors in english (#1657)
fixes: #1302
Change-Id: If0e21f016155276a953c64a8dd13ff3eb281d09d
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 7875a5564c0f87ff0a8ef15963d242bda09661fa
Author: Xavi Hernandez <xhernandez@users.noreply.github.com>
Date: Fri Nov 6 12:00:18 2020 +0100
tests: Fix issues in CentOS 8 (#1756)
* tests: Fix issues in CentOS 8
Due to some configuration changes in CentOS 8/RHEL 8, ssl-ciphers.t
and bug-1053579.t were failing.
The first one was failing because TLS v1.0 is disabled by default. The
test hash been updated to check that at least one of TLS v1.0, v1.1 or
v1.2 succeeds.
For the second case, the issue is that the test assumed that the
latest added group to a user should always be listed the last, but
this is not always true because nsswitch.conf now uses 'sss' before
'files', which means that data comes from a db that could not be
sorted.
Updates: #1009
Change-Id: I4ca01a099854ec25926c3d76b3a98072175bab06
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
* tests: Fix TLS version detection
The old test didn't correctly determine which version of TLS should
be allowed by openssl.
Change-Id: Ic081c329d5ed1842fa9f5fd23742ae007738aec0
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 24fbfad8f6508c1ede893e57ef87eb0bcdb3430c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Nov 5 18:34:39 2020 +0530
glusterd: fix bug in enabling granular-entry-heal (#1752)
commit f5e1eb87d4af44be3b317b7f99ab88f89c2f0b1a meant to enable the
volume option only for replica volumes but inadvertently enabled
it for all volume types. Fixing it now.
Also found a bug in glusterd where disabling the option on plain
distribute was succeeding even though setting it in the fist place
fails. Fixed that too.
Fixes: #1483
Change-Id: Icb6c169a8eec44cc4fb4dd636405d3b3485e91b4
Reported-by: Sheetal Pamecha <spamecha@redhat.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 680e1bbfbc2923bad93f448e96a15897bb74682d
Author: nik-redhat <nladha@redhat.com>
Date: Tue Nov 3 11:48:02 2020 +0530
CLI: added an error message in case of timeout
Added an error message in CLI when there are volumes present in cluster
but timeout happens on fetching them.
This PR fixes #1738
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 9d6c316f35c3de23334cf65591e6142f7ed303c5
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Nov 4 09:39:12 2020 +0530
api: conscious language changes (#1737)
-Removed the occurences of 'master' in api.
-Some changes threw up clang-format errors, so fixed them as well.
-Renamed api/src/{glfs-master.c => glfs-primary.c}
Fixes: #1733
Change-Id: I57aea9d93e219305e87985bc2f81ac47cdebb72f
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 2f044c4587c6db3cb82b6128f056ec2ea2bc1b98
Author: mohit84 <moagrawa@redhat.com>
Date: Wed Nov 4 09:02:03 2020 +0530
posix: Use CALLOC instead of alloca to allocate memory for xattrs list (#1730)
In case of file is having huge xattrs on backend a brick process is
crashed while alloca(size) limit has been crossed 256k because iot_worker
stack size is 256k.
Use MALLOC to allocate memory instead of using alloca
Fixes: #1699
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I100468234f83329a7d65b43cbe4e10450c1ccecd
commit 7ccb1f1878c864e9e06547cad883bf12a90147b3
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Thu Sep 24 12:43:51 2020 +0000
gfapi: give appropriate error when size exceeds
This patch help generate appropriate error message
when the gfapi tries to write data equal to or
greater than 1 Gb due to the limitation at the
socket layer.
fixes: #1518
Change-Id: I1234a0b5a6e675a0b20c6b1afe0f4390fd721f6f
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 8c0a1047c16dc9e80bc094cd0a825511252d7035
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Oct 15 10:03:11 2020 +0200
write-behind: Implement 'pass-through' option
The pass-through option was implemented for all performance xlators
in commit 549b547, but write-behind was missed.
This patch implements the functionality for write-behind.
Given that it's not safe to enable or disable this option while the
volume is mounted, it cannot be reconfigured online. A change will
only take effect after a remount.
Fixes: #1565
Change-Id: I189a48e0044b292e1d6c3b77751ff25045531883
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit e4c9a14429c51d8d059287c2a2c7a76a5116a362
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Nov 2 18:03:01 2020 +0530
xlators: misc conscious language changes (#1715)
core:change xlator_t->ctx->master to xlator_t->ctx->primary
afr: just changed comments.
meta: change .meta/master to .meta/primary. Might break scripts.
changelog: variable/function name changes only.
These are unrelated to geo-rep.
Fixes: #1713
Change-Id: I58eb5fcd75d65fc8269633acc41313503dccf5ff
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 3b6be62cf386640fb48e62d18e5339e8092ef0e2
Author: schaffung <ssivakum@redhat.com>
Date: Mon Nov 2 11:18:01 2020 +0530
cli-rpc: conditional init of global quota rpc (#1578)
Issue: It is seem that the initialization of rpc to
connect with quotad is done in every glusterfs cli command,
irrespective of whether the quota feature is enabled or disabled.
This seems to be an overkill.
Code change: The file /var/run/quotad/quotad.pid is present
signals that quotad is enabled. Hence we can put a conditional
check for seeing when this file exists and if it doesn't we
just skip over the initialization of the global quotad rpc.
This will go on to reduce the extra rpc calls and operations
being performed in the kernel space.
Fixes: #1577
Change-Id: Icb69d35330f76ce95626f59af75a12726eb620ff
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>
Co-authored-by: srijan-sivakumar <ssivakumar@redhat.com>
commit 8b9c2e1cb66fb1ddc932f85c0dc2bccdfbfdd621
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Fri Oct 30 11:59:04 2020 +0530
extras/rebalance: Script to perform directory rebalance (#1676)
* extras/rebalance: Script to perform directory rebalance
How should the script be executed?
$ /path/to/directory-rebalance.py <dir-to-rebalance>
will do rebalance just for that directory. The script assumes that fix-layout
operation is completed for all the directories present inside the
<dir-to-rebalance>
How does it work?
For the given directory path that needs to be rebalanced, full crawl is
performed and the files that need to be healed and the size of each file
is first written to the index. Once building the index is completed, the
index is read and for each file the script executes equivalent of
setfattr -n trusted.distribute.migrate-data -v 1 <path/to/file>
Why does the script take two passes?
Printing a sensible ETA has been a primary goal of the script. Without
knowing the approximate size that will be rebalanced, it is difficult to
find ETA. Hence the script does one pass to find files, sizes which it
writes to the index file and then the next pass is done on the
index file. It takes a minute or two for the ETA to converge but in our
testing it has been giving a reasonable ETA
What versions does the script support?
For the script to work correctly, dht should handle
"trusted.distribute.migrate-data" setxattr correctly.
fixes: #1654
Change-Id: Ie5070127bd45f1a1b9cd18ed029e364420c971c1
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 877b18531d01e3eb8053fb549f6435f1a090f017
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Fri Oct 30 08:27:47 2020 +0200
DHT - Fixing rebalance failure on issuing stop command (#1628)
Issuing a stop command for an ongoing rebalance process results in an error.
This issue was brought up in https://bugzilla.redhat.com/1286171 and a patch
(https://review.gluster.org/24103/) was submitted to resolve the issue.
However the submitted patch resolved only part of the
problem by reducing the number of log messages that were printed (since
rebalnace is currently a recursive process, an error message was printed
for every directory) but didn't fully resolve the root cause for the
failure.
This patch fixes the issue by modifying the code-path which handles the
termination of the rebalance process by issuing a stop command.
fixes: #1627
Change-Id: I604f2b0f8b1ccb1026b8425a14200bbd1dc5bd03
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit e6897d4667f79c2805c5f49b2b6cad6230da4e2b
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Oct 30 10:57:36 2020 +0530
glusterd: Resolve coverity bug CID1435891 (#1716)
The PR #1672 has introduced a coverity bug, this fixes it.
Change-Id: I1140bf7527b6466f4210809a74dc3e59ecf02b6e
Fixes: #1663
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 02074cfe3b02f229f0c0ff468debf5e29adfdb62
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Thu Oct 29 09:52:20 2020 +0530
cluster/dht: Perform migrate-file with lk-owner (#1581)
* cluster/dht: Perform migrate-file with lk-owner
1) Added GF_ASSERT() calls in client-xlator to find these
issues sooner.
2) Fuse is setting zero-lkowner with len as 8 when the fop
doesn't have any lk-owner. Changed this to have len as 0
just as we have in fops triggered from xlators lower to
fuse.
* syncop: Avoid frame allocation if we can
* cluster/dht: Set lkowner in daemon rebalance code path
* cluster/afr: Set lkowner for ta-selfheal
* cluster/ec: Destroy frame after heal is done
* Don't assert for lk-owner in lk call
* set lkowner for mandatory lock heal tests
fixes: #1529
Change-Id: Ia803db6b00869316893abb1cf435b898eec31228
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit fd8546370a95c216df08cf2901705e6ba989fa16
Author: Shree Vatsa N <i.mnshreevatsa@gmail.com>
Date: Wed Oct 28 08:03:57 2020 +0530
io-cache: Minor Performance Optimization (#1656)
move trace logs after mutex unlock in some macros
* Also removed unused macros - ioc_page_lock and ioc_page_unlock
Fixes: #1653
Signed-off-by: Shreevatsa N <i.mnshreevatsa@gmail.com>
commit e2c609e4c505c15f60e614467fef855a35f671ab
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue Oct 27 17:14:56 2020 +0300
tests: exclude more contrib/fuse-lib objects (#1694)
Exclude more contrib/fuse-lib objects to avoid
silly tests/basic/0symbol-check.t breakage.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1692
commit 03d9cd7284403499287643a77fb1700a97cde588
Author: Rafi KC <rafi.kavungal@iternity.com>
Date: Tue Oct 27 12:42:03 2020 +0530
rpcsvc/transport: gracefully disconnect when graph is not ready (#1671)
* rpcsvc/transport: gracefully disconnect when graph is not ready.
There was a crash reported when the brick rpc get's an accept
request from a client before the server xlator is fully inited.
The fix https://review.gluster.org/22339/ solves
the crash, but it leaves the connection alive with out adding
the rpc to xprts list of server conf. This will leads to problems
with upcall, dump, and other cleanup codes.
So this patch will make the rpc to fail and disconnect if a
connection attempted before the server is fully inited.
Change-Id: I3bf1113c0da4c2614afaa2c0f4eb6abfb0d26ed0
Signed-off-by: Mohammed Rafi KC <rafi.kavungal@iternity.com>
commit fc129cc2226884cbf59409256823fd9c147391be
Author: mohit84 <moagrawa@redhat.com>
Date: Tue Oct 27 12:40:39 2020 +0530
tests: ./tests/bugs/core/bug-1650403.t is getting timed out (#1672)
The test case ./tests/bugs/core/bug-1650403.t is consuming more than
500s while running a regression job so the regression is failing.
After executed the test case in softserve environment i have found it is getting timed-out
because DNS call is consuming time by glusterd while it is trying to disbale/enable shd.
time ./tests/bugs/core/bug-1650403.t
real 20m52.952s
user 0m20.842s
sys 0m9.824s
After save the local IP address into glusterd_conf_t list test case time
is reduced
time ./tests/bugs/core/bug-1650403.t
real 1m29.467s
user 0m23.366s
sys 0m10.395s
Fixes: #1663
Change-Id: Iee3462075f84897faa294e48d81af9761929613a
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 729f3812de3a4afb75b20b4a8b076b4155866820
Author: Xavi Hernandez <xhernandez@users.noreply.github.com>
Date: Sat Oct 24 04:33:53 2020 +0200
nfs: Fix inconsistency between glibc and libtirpc (#1698)
* nfs: Fix inconsistency between glibc and libtirpc
There's a critical difference between RPC implementation in glibc
and libtirpc.
In libtirpc, svc_run() starts a polling loop that listens from all
registered connections and handles requests. When this is done from
multiple threads, a race can happen where both threads are trying
to process the same connection simultaneously. This causes memory
corruption.
However, in glibc, svc_run() only handles the registered connections
on the current thread, so it's necessary to call svc_run() on all
threads that register services.
This patch fixes that problem by calling svc_run() from all threads
only if libtirpc is not used. Otherwise it's called only once.
Change-Id: I97c3c39a9aad90115e7e23c70884a4ee7769a2dd
Updates: #1009
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
* nfs: Use an atomic instead of a mutex
Instead of using a mutex to synchronize the call to svc_run(), we
use an atomic operation to update the flag.
Change-Id: I401481d1d0308a557271f99a32527a2ab3c4542f
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
* nfs: Align fields of struct nfs_state
Change-Id: Ib0da4911533ffd9c08636457b664eaa45172e975
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 4b9f95b6993b606b2f97d55694910c2cbe3107a2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Sep 4 10:37:32 2020 +0530
posix: add io_uring support
This patch adds support for reads, writes and fsyncs using io-uring in
posix xlator. A volume option 'storage.linux-io_uring' is introduced to turn
it on or off.
When I ran tests with fio and iozone on physical machines on a 2x3
volume + single client, the numbers were not any worse than regular
pwrite/pread syscalls which posix does with default volume
configurations. But given that io_uring itself undergoing rapid
improvement and bug fixes,it is good to have an intial working implementation
in gluster and iteratively develop on top of it.
Updates: #1398
Change-Id: Ia47456ebb4c16a3b66ad9beb6a9043cc090fed2b
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit f5e1eb87d4af44be3b317b7f99ab88f89c2f0b1a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Oct 22 15:06:41 2020 +0530
glusterd/afr: enable granular-entry-heal by default (#1621)
1. The option has been enabled and tested for quite some time now in RHHI-V
downstream and I think it is safe to make it 'on' by default. Since it
is not possible to simply change it from 'off' to 'on' without breaking
rolling upgrades, old clients etc., I have made it default only for new volumes
starting from op-verison GD_OP_VERSION_9_0.
Note: If you do a volume reset, the option will be turned back off.
This is okay as the dir's gfid will be captured in 'xattrop' folder and heals
will proceed. There might be stale entries inside entry-changes' folder,
which will be removed when we enable the option again.
2. I encountered a cust. issue where entry heal was pending on a dir. with
236436 files in it and the glustershd.log output was just stuck at
"performing entry selfheal", so I have added logs to give us
more info in DEBUG level about whether entry heal and data heal are
progressing (metadata heal doesn't take much time). That way, we have a
quick visual indication to say things are not 'stuck' if we briefly
enable debug logs, instead of taking statedumps or checking profile info
etc.
Fixes: #1483
Change-Id: I4f116f8c92f8cd33f209b758ff14f3c7e1981422
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 2675b811782a139bd5620ed9277a4bf0b935d2bc
Author: schaffung <ssivakum@redhat.com>
Date: Thu Oct 22 13:07:09 2020 +0530
glusterd: brick sock file deleted, log error (#1560)
Issue: The satus of the brick as tracked by glusterd is
stopped if the socket file corresponding to a running
brick process is absent in /var/run/gluster. The glusterd
keeps on trying to reconnect ( rpc layer ) but it fails.
Code change: Rather than registering the rpc connection
with the help of the given sockfilepath which is not
even present as it keeps on reconnecting, why not log
this as an error and not try to reconnect using the
non-existing sock file path.
Fixes: #1526
Change-Id: I6c81691ab1624c66dec74f5ffcc6c383201ac757
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>
Co-authored-by: srijan-sivakumar <ssivakumar@redhat.com>
commit e85e7bc3ac888339f96a57b8290a69f349164c23
Author: mohit84 <moagrawa@redhat.com>
Date: Thu Oct 22 13:05:40 2020 +0530
trash: Create inode_table only while feature is enabled (#1626)
Currently trash xlator create a inode table(1M) even if
feature is not enabled.In brick_mux environment while 250
bricks are attached with a single brick process and feature
is not enable brick process increase RSS size unnecessarily.
Solution: Create inode_table only while a feature is enabled.
The patch reduces 250M RSS size per brick process
if trash feature is not enabled.
Change-Id: I11a6fd2b8419fe2988f398be6ec30fb4f3b99a5d
Fixes: #1543
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit caa6105e9be3e3f5a80ba894c23eeee02df9a3e3
Author: Tamar Shacked <tshacked@redhat.com>
Date: Thu Oct 22 04:51:34 2020 +0300
afr: fixing null dereference reported by coverity (#1570)
Added a null check to avoid a null pointer dereference
CID: 1433222
Updates: #1060
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit d61ee46e8b4df97605cb5d34f9460300609a5c1b
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Oct 21 22:54:10 2020 +0530
geo-rep: Enable rsync verbose logging for debugging (#1588)
By default rsync command is run without --verbose argument.
The rsync command takes "--verbose" or "-vv" which prints
verbal output which helps in debugging rsync errors. The
verbose argument can be passed by setting geo-rep config
option "rsync_options" to required verbose string. If set,
this patch logs rsync verbose output in the geo-rep log file.
Fixes: #1587
Change-Id: I0b7e1e813eb7e90f1c2ba885b42fd52dbd44386a
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit bf2a76da976f90ba9e7ac049575b8620505b62a7
Author: Vinayak hariharmath <65405035+VHariharmath-rh@users.noreply.github.com>
Date: Wed Oct 21 16:14:29 2020 +0530
libglusterfs/coverity: pointer to local outside the scope (#1675)
issue: gf_store_read_and_tokenize() returns the address
of the locally referred string.
fix: pass the buf to gf_store_read_and_tokenize() and
use it for tokenize.
CID: 1430143
Updates: #1060
Change-Id: Ifc346540c263f58f4014ba2ba8c1d491c20ac609
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
commit 30ee9b58ee871517b6f631412879da9559bcbb3b
Author: mohit84 <moagrawa@redhat.com>
Date: Wed Oct 21 15:25:43 2020 +0530
glusterd: wrong comparison in glusterd_brick_start() function (#1665)
Call gf_uuid_compare in glusterd_brick_start to compare two
uuid instead of calling strncmp.
Fixes: #1659
Change-Id: Icd1bdcc1ed4dfab4407fc51ae4ba248989a32f17
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit c047c66e0152aa9ae522b9fcabaefa6b36a42650
Author: Tamar Shacked <tshacked@redhat.com>
Date: Wed Oct 21 08:25:59 2020 +0300
dht/rebalance - fixed dhtfcnt_thread wakeup time to be in absolute time (#1667)
The dhtfcnt_thread is designed to wakeup each 10min.
Changed the time units passed to pthread_cond_timedwait()
to be in absolute time (epoch time)
todo: verify the values of total_file_size
updates: #1507
Change-Id: I1a81ff23ff2c313463add9e0a5fc05c84ac1b4a5
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit b5dff6679ac70eee466911aa9fcc4d3b9704b4c3
Author: schaffung <ssivakum@redhat.com>
Date: Tue Oct 20 10:28:56 2020 +0530
Maintainers List Update : Management daemon. (#1633)
Hello Maintainers, requesting permission to be a peer in the
management daemon component. I believe I can actively help in the
maintenance as well as the enhancement of the component.
Updates: #1584
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit faee969c7d630dec69de4329f787bab190549a5a
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Mon Oct 19 13:28:37 2020 +0530
Update maintainers list of geo-rep and glusterfind (#1629)
Change-Id: I6afd762ca9d9a7f6d2fb83256cb6edffb37b67a3
Updates: #1584
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 87ee78672bdb429504f58e7f7ae7379f7c312c6c
Author: mohit84 <moagrawa@redhat.com>
Date: Mon Oct 19 13:28:17 2020 +0530
test: The test case tests/bugs/bug-1064147.t is failing (#1662)
The test case tests/bugs/bug-1064147.t is failing at
the time of comparing root permission with permission changed
while one of the brick was down.The permission was not matching
because layout was not existing on root at the time of healing
a permission, so correct permission was not healed on
newly started brick
Fixes: #1661
Change-Id: If63ea47576dd14f4b91681dd390e2f84f8b6ac18
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 6046f4c65d8505dd3c6866a5b1f51ead2a88fe58
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Thu Oct 15 17:35:40 2020 +0530
tests/00-geo-rep: 00-georep-verify-non-root-setup.t fails on devel branch (#1639)
Increasing the timeout value to overcome the encountered
delay in execution of test
Change-Id: Id40d92366738439634a6b06d447a43a2c6cdbf44
Updates: #1594
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit f71660eb879a9cd5761e5adbf10c783e959a990a
Author: mohit84 <moagrawa@redhat.com>
Date: Thu Oct 15 16:28:58 2020 +0530
io-stats: Configure ios_sample_buf_size based on sample_interval value (#1574)
io-stats xlator declares a ios_sample_buf_size 64k object(10M) per xlator
but in case of sample_interval is 0 this big buffer is not required so
declare the default value only while sample_interval is not 0.The new
change would be helpful to reduce RSS size for a brick and shd process
while the number of volumes are huge.
Change-Id: I3e82cca92e40549355edfac32580169f3ce51af8
Fixes: #1542
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 07e37295f7a90ae293f68d04a6b2fc65ab3f0f51
Author: mohit84 <moagrawa@redhat.com>
Date: Tue Oct 13 20:09:45 2020 +0530
glusterd: Resolve clang format issue (#1622)
In the commit 8d54899724a31f29848e1461f68ce2cf40585056 clang
format issue was introduced in patch but clang check was not
complained at the time of running regression.
Fixes: #1569
Change-Id: Ib1fb039ebe3c77f39b8c686eb4699327256ac494
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit f26bca53468093dd84b68c11840b550cffe22b02
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Tue Oct 13 09:46:46 2020 +0530
tests/00-geo-rep: 00-georep-verify-non-root-setup.t fails on devel branch (#1617)
ssh -oPasswordAuthentication=no -oStrictHostKeyChecking=no -i
/var/lib/glusterd/geo-replication/secret.pem -p 22 nroot@127.0.0.1
/build/install/sbin/gluster --xml --remote-host=localhost volume info
slave failes with error 255.
Adding ssh key clean up code at the beginning of the test, inorder to
clean any stale entries
Updates: #1594
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 91daeae369bd5a4e05ea51d8f2b4a2d84ffd38b4
Author: Amar Tumballi <amar@kadalu.io>
Date: Mon Oct 12 14:24:39 2020 +0530
MAINTAINERS: update Amar's contact (#1598)
* Also add Deepshika to Platform section!
Updates: #1584
Change-Id: I9846fb1a16ad536e0a23d606d308a61e2ff60b54
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit ecdc77ceb9a5864be1fd0b3d7f919fa9ce60132e
Author: mohit84 <moagrawa@redhat.com>
Date: Sun Oct 11 10:56:57 2020 +0530
core: configure optimum inode table hash_size for shd (#1576)
In brick_mux environment a shd process consume high memory.
After print the statedump i have found it allocates 1M per afr xlator
for all bricks.In case of configure 4k volumes it consumes almost total
6G RSS size in which 4G consumes by inode_tables
[cluster/replicate.test1-replicate-0 - usage-type gf_common_mt_list_head memusage]
size=1273488
num_allocs=2
max_size=1273488
max_num_allocs=2
total_allocs=2
inode_new_table function allocates memory(1M) for a list of inode and dentry hash.
For shd lru_limit size is 1 so we don't need to create a big hash table so to reduce
RSS size for shd process pass optimum bucket count at the time of creating inode_table.
Change-Id: I039716d42321a232fdee1ee8fd50295e638715bb
Fixes: #1538
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 8d54899724a31f29848e1461f68ce2cf40585056
Author: mohit84 <moagrawa@redhat.com>
Date: Fri Oct 9 20:42:43 2020 +0530
configure.ac: Add --enable-brickmux (#1572)
Introduce an --enable-brickmux configure option to
enable brick_mux as a default option.
Fixes: gluster#1569
Change-Id: Id0c61ee3500630889e2cb2b5816cd40f68d47c94
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 7b9380f23ab7164c7a1097537f25068ee72572ec
Author: Aravinda Vishwanathapura <aravinda@kadalu.io>
Date: Fri Oct 9 19:01:29 2020 +0530
MAINTAINERS: Updated Email address (#1567)
Change-Id: I867809cc2015869e480389caef22695862ccda9a
Signed-off-by: Aravinda Vishwanathapura <aravinda@kadalu.io>
commit c3d5689703d024880e4c712cb02c26f1eb7e04e8
Author: Pranith Kumar Karampuri <pranith.karampuri@phonepe.com>
Date: Fri Oct 9 17:08:30 2020 +0530
rfc.sh: Handle remote-repo with .git extension (#1586)
fixes: #1582
Change-Id: I8ad01b05f3d4befb1b502e853b4d4ee1ea8d038c
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 35a68e3cdcfd2f4dca94c38f3f0cd26ac0cebe12
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Fri Oct 9 17:07:54 2020 +0530
Update maintainer list of EC (#1585)
Change-Id: I40caa4b7355c4b48ef18c45e46f5dbecb7ae538a
Updates: #1584
Signed-off-by: Sheetal <spamecha@redhat.com>
commit 821bf16376eede6792c8f805d14bd897def2bb98
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Fri Oct 9 14:35:52 2020 +0300
Update maintainer list of DHT (#1551)
Update maintainers list to reflect current status of DHT.
fixes: #1550
Change-Id: Ie5ddd0255a53da1ac2b4dd1b210d69e78ca6c85a
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 8129a622bd2e4c9df53242dc62141708a18d1c59
Author: Amar Tumballi <amar@kadalu.io>
Date: Wed Oct 7 22:35:17 2020 +0530
rfc.sh: make proper changes to work on github (#1547)
Change-Id: Ie02ae47c766f2caaece827f0d98862f2f4589c9c
Updates: #1000
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 0bbad69fea9e1eff7f9561e63f58a7545232f963
Author: Amar Tumballi <amar@kadalu.io>
Date: Wed Oct 7 12:50:16 2020 +0530
Contributing: update about who can trigger the build
Currently only maintainers listed in github group can trigger the
regression runs, it may change in future!
Updates: #1000
Change-Id: I3b5f1cace8a433886d725539198998875dcdce36
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 4cf7154f115ec238564974a8eb0e1f5cd036455b
Author: Amar Tumballi <amar@kadalu.io>
Date: Wed Aug 12 18:47:56 2020 +0530
Migration: update the docs
* Make CONTRIBUTING.md have complete workflow documented.
* Change './rfc.sh' to reflect the new workflow
Updates: #1000
Also Updates: gluster/project-infrastructure#62
Change-Id: I31becd7cdb35cb68048b662786c31694791d50fe
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit dea69c12711fb1e9f9e7b0cfeafd2f2057f96340
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Mon Sep 21 11:51:07 2020 +0300
DHT - Removing commit hash and 'magical' return value from rebalance
The order of operation in rebalance is as follows:
gf_defrag_fix_layout - > gf_defrag_process_dir - > gf_defrag_get_entry
gf_defrag_process_dir is passing to gf_defrag_get_entry a pointer to a
variable 'gf_defrag_get_entry', however this value is ignored (remains
unchanged in the method).
Based on the return value from gf_defrag_get_entry,
gf_defrag_process_dir may change it's return value to the 'magical'
number 2, however since the value of 'should_commit_hash' never changes,
this never happnes.
All of this is propagated back to gf_defrag_fix_layout and is now
removed from there as well.
Change-Id: Ibff297650cf84139bd26c830bfa44f81119b60d4
updates: #1002
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 61d6b18c82e4710bd240df9bd28afde5ca4cb86c
Author: Pranith Kumar K <pranith.karampuri@phonepe.com>
Date: Mon Oct 5 13:15:07 2020 +0530
mount/fuse: Fix graph-switch when reader-thread-count is set
Problem:
The current graph-switch code sets priv->handle_graph_switch to false even
when graph-switch is in progress which leads to crashes in some cases
Fix:
priv->handle_graph_switch should be set to false only when graph-switch
completes.
fixes: #1539
Change-Id: I5b04f7220a0a6e65c5f5afa3e28d1afe9efcdc31
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 0361a70e32793d89762cd056e9f9fb4fbae7fb5d
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Wed Sep 16 13:22:57 2020 +0300
dht - Remove "tier" code (part 2)
Part 1 of this patch https://review.gluster.org/#/c/glusterfs/+/24328/
Following part 1, this patch complety removes all traces of
"tier" feature in dht.
This is based in the work done in
https://review.gluster.org/#/c/glusterfs/+/23935/
Change-Id: I7fba1ab7249719301ca578b4a6f4acac748da145
updates: #1097
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 7ca317e7f82863b07d1473fe1b61577b6d2243c5
Author: perrynzhou <perrynzhou@gmail.com>
Date: Tue Sep 29 17:22:42 2020 +0800
fixed AFR_READ_POLICY_GFID_PID_HASH policy bug
Change-Id: Ib927a770a486c95e4b157e76ba96e9904d1a9716
Fixes: #1499
Signed-off-by: perrynzhou <perrynzhou@gmail.com>
commit 2d58ec85816d3f03cfde23eea8b8ba03ce50a3a6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Apr 13 19:31:51 2020 +0530
cluster/afr: Heal directory rename without rmdir/mkdir
Problem1:
When a directory is renamed while a brick
is down entry-heal always did an rm -rf on that directory on
the sink on old location and did mkdir and created the directory
hierarchy again in the new location. This is inefficient.
Problem2:
Renamedir heal order may lead to a scenario where directory in
the new location could be created before deleting it from old
location leading to 2 directories with same gfid in posix.
Fix:
As part of heal, if oldlocation is healed first and is not present in
source-brick always rename it into a hidden directory inside the
sink-brick so that when heal is triggered in new-location shd can
rename it from this hidden directory to the new-location.
If new-location heal is triggered first and it detects that the
directory already exists in the brick, then it should skip healing the
directory until it appears in the hidden directory.
Credits: Ravi for rename-data-loss.t script
Fixes: #1211
Change-Id: I0cba2006f35cd03d314d18211ce0bd530e254843
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit a058a607f59b9873380e6fae6216f68432507369
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Wed Sep 23 11:40:16 2020 +0300
build: drop -rdynamic from compiler flags
Since -rdynamic is meaningless during compilation, drop it from
GF_CFLAGS. Note GF_LDFLAGS unconditionally use -rdynamic anyway.
Change-Id: I07c7086a8a6adad8358b88999d98828c1cbfb464
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit c4f480202e2aeb8ca85436dc410f073812a7a1de
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Thu Sep 24 16:46:46 2020 +0300
DHT - Fixing memory allocation crash
The allocation
dir_dfmeta = GF_CALLOC(1, sizeof(*dir_dfmeta), gf_common_mt_pointer);
seems to cause a crash.
From the logs:
[2020-09-24 13:10:13.225935 +0000] I [dht-rebalance.c:3273:gf_defrag_process_dir]
0-dist-dht: migrate data called on /dir1
[2020-09-24 13:10:13.226587 +0000] E [mem-pool.c:61:gf_mem_set_acct_info]
(-->/usr/local/lib/glusterfs/9dev/xlator/cluster/distribute.so(+0x18e60)
[0x7f4b1f71ee60] -->/usr/local/lib/glusterfs/9dev/xlator/cluster/distribute.so(+0x173ab)
[0x7f4b1f71d3ab] -->/usr/local/lib/libglusterfs.so.0(+0x4d8e5) [0x7f4b357668e5] )
0-: Assertion failed: type <= mem_acct->num_types
[2020-09-24 13:10:13.226623 +0000] E [mem-pool.c:61:gf_mem_set_acct_info]
(-->/usr/local/lib/glusterfs/9dev/xlator/cluster/distribute.so(+0x18e60)
[0x7f4b1f71ee60] -->/usr/local/lib/glusterfs/9dev/xlator/cluster/distribute.so(+0x173d3)
[0x7f4b1f71d3d3] -->/usr/local/lib/libglusterfs.so.0(+0x4d8e5) [0x7f4b357668e5] )
0-: Assertion failed: type <= mem_acct->num_types
The following change fixes that crash.
fixes: #1511
Change-Id: Ibf605648981f7108e863c91a80370cf077ad7c4a
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 55dd209ea24276e16d61cd81cc2fd483b5423537
Author: Mohammed Rafi KC <rafi.kavungal@iternity.com>
Date: Tue Sep 1 00:49:26 2020 +0530
bitrot/stub: Fix memory leak gf_br_stub_mt_version_t
The data type gf_br_stub_mt_version_t is leaking because the
data type has been added to the dict as static type and the memory
is not free'd from anywhere else
Change-Id: Ib10134f41f45a39be849af1708b1960c77fb62fd
Fixes: #1427
Signed-off-by: Mohammed Rafi KC <rafi.kavungal@iternity.com>
commit 4bb100174c2c7f4748d1174b8756d49bea08a2b9
Author: Mohammed Rafi KC <rafi.kavungal@iternity.com>
Date: Wed Sep 30 16:29:34 2020 +0530
MAINTAINERS: Changing communication email
Change-Id: I5ae3161d0357ddd62fb6409933837ffd94610d83
Updates: #1002
Signed-off-by: Mohammed Rafi KC <rafi.kavungal@iternity.com>
commit 8f0dc5655616a913dcc5b1d85b9a79454ec80132
Author: Môshe van der Sterre <me@moshe.nl>
Date: Mon Sep 28 06:12:32 2020 +0200
gfapi: Move the SECURE_ACCESS_FILE check out of glfs_mgmt_init
glfs_mgmt_init is only called for glfs_set_volfile_server, but
secure_mgmt is also required to use glfs_set_volfile with SSL.
fixes: #829
Change-Id: Ibc769fe634d805e085232f85ce6e1c48bf4acc66
commit 0d1f0cd95a3bd325d59fcbee81c43e611101722c
Author: nik-redhat <nladha@redhat.com>
Date: Fri Sep 25 18:39:51 2020 +0530
dht: explicit null dereference
Added a null check for uuid_list_copy, to avoid
null dereference in strtok_r() in case of strdup()
failure.
CID: 1325612
CID: 1274223
Updates: #1060
Change-Id: I641a5068cd76d7b2ed92eccf39e7f97d6f7b2480
Signed-off-by: nik-redhat <nladha@redhat.com>
commit c83ab52bee7cbd45a74643189c798f7d527295ac
Author: nik-redhat <nladha@redhat.com>
Date: Fri Sep 25 18:19:39 2020 +0530
locks: null dereference
Added a null check before executing the strtok_r()
to avoid null dereference in case of strdup() failure.
CID: 1407938
Updates: #1060
Change-Id: Iec6e72ae8cb54f6d0a287615c43756325b2026ec
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 22166e80ccd3a3c07fb1987491a3a40ccabe6667
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Aug 26 20:05:35 2020 +0530
glusterd: start the brick on a different port
Problem: brick fails to start when the port provided by
glusterd is in use by any other process
Solution: glusterd should check errno set by runner_run()
and if it is set to EADDRINUSE, it should allocate a new
port to the brick and try to start it again.
Previously ret value is checked instead of errno, so the
retry part never executed. Now, we initialize errno to 0
before calling runner framework. and afterwards store the
errno into ret to avoid modification of errno in subsequent
function calls.
fixes: #1101
Change-Id: I1aa048a77c5f8b035dece36976d60602d9753b1a
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
Signed-off-by: nik-redhat <nladha@redhat.com>
commit bfbee4edffc935f016644c570b2e83636cc9af70
Author: pranith.karampuri <pranith.karampuri@phonepe.com>
Date: Thu Sep 24 06:33:57 2020 +0530
MAINTAINERS: Changing communication email
Updates: #1002
Change-Id: I1b8fb6430a6a64fc813bdd111a31b3574ffc06a1
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
commit 63838e9403f22e7b9b9038093a5e1fe7f40e7560
Author: srijan-sivakumar <ssivakum@redhat.com>
Date: Sat Sep 26 19:17:41 2020 +0530
glusterd: Replacing str with ptr in strchr to reduce comparison
Issue: On seeing the function glusterd_replace_slash_with_hyphen
we see that the strchr inside the while loop takes str as a
parameter, that'd mean repeated comparison from index 0 of str
even though the characters have already been compared. Why not
use ptr instead which points to the latest replacement in the
string.
Code change: replacing str with ptr inside the strchr function.
Fixes: #1516
Change-Id: Id049ec2ad9800a01730f2a0263d9e0528557ae81
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit 86e0323feeabf74059c28d74ba89f42c2face53a
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Sep 23 09:26:03 2020 +0530
dht: Ongoing IO is failing on non-distribute volumes after just add-brick
Problem: On a non-distributed volumes linux kernel untar is failed
after running add-brick operation
Solution:
1) Save hashed subvol as a MDS in case while MDS has not been
populated
Fixes: #1328
Change-Id: I9967e136da008c6367973a7346637617dfa8f934
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 12def3064bdddf2be23bb63929c28563471df8fa
Author: nik-redhat <nladha@redhat.com>
Date: Fri Sep 25 17:56:19 2020 +0530
glusterd: resource leaks
Issue:
iobref was not freed before exiting the function.
Fix:
Modified the code to free iobref before exiting.
CID: 1430107
Updates: #1060
Change-Id: I89351b3aa645792eb8dda6292d1e559057b02d8b
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 0b512035e3c19578607b3cae5813fdff23684c7d
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Sep 23 12:50:07 2020 +0200
gfapi: Check the fd argument before accessing it
Some public GFAPI functions did access the fd object without verifying
that it wasn't NULL, causing crashes in some cases.
This patch returns an error code in case it's NULL.
Updates: #1009
Change-Id: I8cadde87ae8d542e0af9b55aa866fe763f97d4fb
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 8a581014c477dca8774719dc1ad56898f40ae9f0
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Thu Sep 24 12:34:23 2020 +0300
DHT - fixing a bug in thread creation
The 3rd argument of gf_thread_create is a pointer to a method, however
in this case, a pointer to a pointer to a method is passed (2 levels of
indirection instead of 1).
Change-Id: Ic2d4ea75aa54c6bc85a80bd0277a0efa5e5814ad
updates: #1002
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit adbb679370810b1802ac1791f44f9232c8f15f65
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Wed Sep 23 17:41:46 2020 +0530
glusterd: Fix Add-brick with increasing replica count failure
Problem: add-brick operation fails with multiple bricks on same
server error when replica count is increased.
This was happening because of extra runs in a loop to compare
hostnames and if bricks supplied were less than "replica" count,
the bricks will get compared to itself resulting in above error.
Fixes: #1508
Change-Id: I8668e964340b7bf59728bb838525d2db062197ed
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit e87c4e7d45e48e4ac24318704a92d422af2ae647
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 22 08:17:05 2020 -0400
build: when building with tirpc, link with libtirpc
uncovered on Ubuntu Groovy (20.10, ubuntu's bleeding edge devel dist),
seems to now have stricter link semantics than it did when we last
built 8.1 and 7.5.
Many xlators actually do have direct calls to xdr_sizeof(), so strictly
speaking they should be linked with libtirpc.
Change-Id: Iee1fd3528fde19db397c4eae6978d9b9a2c3e17f
Updates: #1002
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 8638100259c05212a0d49933c9b8f2ed0d6d1b10
Author: srijan-sivakumar <ssivakum@redhat.com>
Date: Mon Sep 21 19:14:01 2020 +0530
glusterd: Removing strlen and using existing len field of data_t
Issue: The strlen being used to find the length of the dictionary is
an extra step as there already exists len field in data_t which contains
the same value.
Code Change :
1. Replacing the strlen with len.
2. Removing a typecast which wasn't required.
Fixes: #1497
Change-Id: I2780c3876b17b8825038d222fb489a87e090411f
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit 5f14b669f17f958c216c37aad6d87958c836175e
Author: srijan-sivakumar <ssivakum@redhat.com>
Date: Mon Sep 21 19:31:08 2020 +0530
glusterd: Fixing coverity issues.
Fixing Incorrect expression (IDENTICAL_BRANCHES) reported by
the coverity scan.
CID: 1432721
Change-Id: If6ab3a129dffb6c5fcc618e775f99bc1125003ab
Updates: #1060
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit ee5f696f3034874894999d4805f7d46e285596d0
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue Sep 22 17:21:26 2020 +0530
nfs: test case bugs_nfs_bug-1116503.t is crashed
test case is crashed because GF_ASSERT is failing
in gf_mem_set_acct_info function due to access global
xlator instead of accessing nfs xlator.To avoid the
crash pass nfsx at the time of calling nsm_thread
to set the THIS.
Fixes: #1506
Change-Id: Ifd8afcdf39578aa44332d1b79744a4e9910fe7c6
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit a6b3699bf93b151d2504bc3da35ae37b88967901
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Aug 28 16:03:54 2020 +0530
cluster/ec: Track heal statistics in shd
With this change we should be able to inspect number of heals
attempted and completed by each shd.
fixes: #1453
Change-Id: I10f5d86efcc0a8e4d648da808751d37725682c39
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 96d976e6be70d075639e69f2bab70b7de783c520
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Jul 24 14:11:24 2020 +0530
glusterd: add post-commit phase to the transaction
This is part 2 of the fix. part 1 is at
https://review.gluster.org/#/c/glusterfs/+/24325/
This patch adds post commit phase to the mgmt v3 transaction
framework.
In post commit phase we replace the old auth.allow list
in case of add-brick and replace-brick.
fixes: #1391
Change-Id: I41c871d59e6252d27163b042ad710e929d7d0399
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 1eb5260bac5f5f2b26cca048fff36eeb0c0e0c62
Author: nik-redhat <nladha@redhat.com>
Date: Tue Sep 15 16:20:19 2020 +0530
glusterd: mount directory getting truncated on mounting shared_storage
Issue:
In case of a user created volume the mount point
is the brick path 'ex: /data/brick' but in case of
shared_storage the mount point is '/'.So, here
we increment the array by one so as to get the exact
path of brick without '/', which works fine for other
volumes as the pointer of the brick_dir variable is
at '/', but for shared_storage it is at 'v'(where v is
starting letter of 'var' directory). So, on incrementing
the path we get in case of shared_storage starts from
'ar/lib/glusterd/...'
Fix:
Only, increment the pointer if the current position is '/',
else the path will be wrong.
Fixes: #1480
Change-Id: Id31bb13f58134ae2099884fbc5984c4e055fb357
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 139a419c471e80662177341e84f095f9570d1530
Author: Srijan Sivakumar <ssivakum@redhat.com>
Date: Tue Jun 2 16:47:24 2020 +0530
glusterd:Reducing file operations when writing options into volfile.
Issue: The options to be written into the volfile are in form of
key-value pairs and the current approach taken to write them into
a file is to invoke the write syscall for each key-value pair.
This implies an increased number of system calls.
Code Changes:
1. Addition of a structure, glusterd_volinfo_data_store_t in
glusterd-store.h, containing a character buffer, a pointer to
gf_store_handle_t, the current length of data in the buffer as
well as a flag for checking key while storing in the buffer.
This is used for passing the required file descriptor as well
having a character buffer for storing multiple options before
being written into a file.
2. Modification of function, _storeopts in glusterd-store.c, which
now invokes the gf_store_save_items when buffer is to be emptied
into the volfile before further write into it. Also, it has
replaced the function _storeslaves, _gd_store_rebalance_dict
and _store_global_opts.
3. Modification of function, glusterd_store_volinfo_write in
glusterd-store.c, wherein a pointer of type
glusterd_volinfo_data_store_t is initialized for further
operation. Also, the buffer is emptied into the volfile before
it is freed.
4. Modification of function, glusterd_store_node_state_write in
glusterd-store.c, wherein the a pointer of type
glusterd_volinfo_data_store_t is initialized for further operations.
Also, the buffer is emptied into the volfile before it is freed.
5. Addition of enum into glusterd-mem-types.h
6. Modification of function, glusterd_store_options in
glusterd-store.c, wherein a pointer of type
glusterd_volinfo_data_store_t is initialized for further opertaions.
Also, the buffer is emptied into the volfile before it is freed.
Reasoning behind the approach:
1.Instead of a dynamic allocation of buffer or increasing the buffer
size with increased number of options, it, the current approach takes
a buffer of fixed size (VOLINFO_BUFFER_SIZE). Before any write into
the buffer, the size is checked and if it exceeds the available space,
the contents of the buffer are written to the file before copying new
contents. Dynamic allocation can lead to increased memory usage as one
doesn't know the number of options that could be added in time and may
go on to occupy more space than mandated.
2.The function dict_foreach is a generic function used across different
modules. It made sense not to change its implementation as it might
affect other Functionalities. Hence a structure was added which could
just be passed as one of the parameter to this function (as it takes
a void*).
3. Reduced number of system calls implies an increase in execution speed.
Also, these modified functions come into play whenever the volume is
started or modified.
4. The functions _storeslaves, _gd_store_rebalace_dict and
_store_global_opts were doing the same set of operations as that of
_storeopts except the checking for the key. This has been handled
with the help of a flag in the glusterd_volinfo_data_store_t structure.
This reduces the duplicate code present.
Signed-off-by: Srijan Sivakumar <ssivakum@redhat.com>
Change-Id: I22e6e91c78ed51e3a171482054d77bf793b9ab16
Fixes: #718
commit e5e511b81dcb7600127ef0a1040bb3d87ebc03bb
Author: srijan-sivakumar <ssivakum@redhat.com>
Date: Wed Sep 16 08:55:22 2020 +0530
quota_fsck.py fails with UnicodeDecodeError
Issue: While decoding the byte characters the quota_fsck
script stumbled across a corner case wherein the file names
given by the getfattr dump will cause the decoding to UTF-8
to fail with UnicodeDecodeError.
Code Change:
On looking through the quota_fsck.py script, it seems like
the file path is actually not needed when decoding for the
xattr parsing, hence the code change reflects that. Also,
removed a comparison which previously existed to skip the
file names as that won't be required now.
Fixes: #1487
Change-Id: I8a13ab07be6c9cfafae996f17764fbb4a285bd8c
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit c2214ba16f8a109b919346d909a897895e0e9a90
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Sep 10 15:36:38 2020 +0530
nfs: Use static api to set static data in dict
fixes: #1477
Change-Id: I8b9f76887f4617f82d09291205e28e3fb5ddc8e0
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 96bd63bd191c70a8636de75b6437487c1152e677
Author: nik-redhat <nladha@redhat.com>
Date: Thu Sep 10 14:55:35 2020 +0530
glusterd: readdir-ahead off by default
Changing the default value of readdir-ahead to
off, but it can be enabled/disabled later on if with
gluster vol set <volname> performance.readdir-ahead enabel/disable
command.
Fixes: #1472
Change-Id: Idb3e16e8be98d7a811fc8e5d09906919ef50fbab
Signed-off-by: nik-redhat <nladha@redhat.com>
commit d9664114d11874d81d164a47169ccd79500e6c00
Author: nik-redhat <nladha@redhat.com>
Date: Wed Sep 9 12:19:45 2020 +0530
glusterd: fixing coverity issues
In the last patch merge for the performance.readdir
-ahead dependencies, there was few issues with return
check and NULL derefencing. So, fixed that as per
the coverity scanner.
CID: 1432493
CID: 1432492
Updates: #1060
Change-Id: I6dee6d35ef41ab8d6322f1b2e3734c4796ee2804
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 3d2de9d89b27639c8e65379143e6ad4a9505d3fd
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Thu Sep 10 13:16:12 2020 +0530
nfs-ganesha: gluster_shared_storage fails to automount on node reboot on rhel 8
The patch https://review.gluster.org/#/c/glusterfs/+/24934/, changes mount point
of gluster_shared_storage from /var/run to /run to address the issue of symlink
at mount path in fstab.
NOTE: mount point /var/run is symlink to /run
The required changes with respect to gluster_shared_storage mount path are
introduced with this patch in nfs-ganesha.
Fixes: #1475
Change-Id: I9c7677a053e1291f71476d47ba6fa2e729f59625
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 6c9c5bece3d4cec278b64239f5e3147729ef5ced
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Thu Sep 10 13:49:09 2020 +0530
extras/snap_scheduler: changes in gluster-shared-storage mount path
The patch https://review.gluster.org/#/c/glusterfs/+/24934/, changes mount point
of gluster_shared_storage from /var/run to /run to address the issue of symlink
at mount path in fstab.
NOTE: mount point /var/run is symlink to /run
The required changes with respect to gluster_shared_storage mount path are
introduced with this patch in snap_scheduler.
Fixes: #1476
Change-Id: I9ce88c2f624c6aa5982de04edfee2d0a9f160d62
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 254f8650372407dc1a68b46615e1e05cba20795b
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Mon Aug 31 20:08:39 2020 +0530
geo-rep: gluster_shared_storage fails to automount on node reboot on rhel 8.
Issue: On reboot, all the mounts get wiped out.
Only the mounts mentioned in /etc/fstab automatically gets mounted
during boot/reboot.
But /etc/fstab complains on not getting a canonical path
(it gets path containing a symlink)
This is because the gluster_shared_storage, is mounted to
/var/run which is symlink to /run. This is a general practice
followed by most operating systems.
[root@ ~]# ls -lsah /var/run
0 lrwxrwxrwx. 1 root root 6 Jul 22 19:39 /var/run -> ../run
Fix: Mount gluster_shared_storage on /run.
(Also It is seen that /var/run is mostly
used by old or legacy systems, thus it is a good practice to
update /var/run to /run)
fixes: #1459
Change-Id: I8c16653be8cd746c84f01abf0eea19284fb97c77
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit e3be6eda5ce07f7ed6d167f4f0cbcea4030e6a77
Author: nik-redhat <nladha@redhat.com>
Date: Tue Aug 4 06:37:00 2020 +0530
glusterd: automatically turn on dependencies for parallel-readdir
Issue:
On setting the performance.parallel-readdir to "on"
the dependencies of it should automatically be
turned on and readdir-ahead should be the parent
of each dht subvolume.
Fix:
On enabling the parallel-readdir, the dependencies
are turned on by enabling readdir-ahead simultaneously,
and readdir-ahead will be seen as the parent of each
dht subvolume.
Fixes: #1416
Change-Id: Ic83ae470152b88edddc274d5e6c4d74169d23c15
Signed-off-by: nik-redhat <nladha@redhat.com>
commit da3835971a5fa1b29fd792faa8339be428a5116c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Sep 4 10:44:17 2020 +0530
rpcsvc: Add latency tracking for rpc programs
Added latency tracking of rpc-handling code. With this change we
should be able to monitor the amount of time rpc-handling code is
consuming for each of the rpc call.
fixes: #1466
Change-Id: I04fc7f3b12bfa5053c0fc36885f271cb78f581cd
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 2c349f933df091bd2b346c6fa33473663a41ba8f
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Sep 3 11:17:07 2020 +0300
xlators: prefer libglusterfs time API
Prefer timespec_now_realtime() and gf_time() over clock_gettime()
and time(), use gf_tvdiff() and gf_tsdiff() where appropriate,
drop unused time_elapsed() and leftovers in 'struct posix_private'.
Change-Id: Ie1f0229df5b03d0862193ce2b7fb91d27b0981b6
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit ef01c5297938b5b016bb82c859a05532750c91d9
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Sep 4 14:49:50 2020 +0200
open-behind: implement create fop
Open behind didn't implement create fop. This caused that files created
were not accounted for the number of open fd's. This could cause future
opens to be delayed when they shouldn't.
This patch implements the create fop. It also fixes a problem when
destroying the stack: when frame->local was not NULL, STACK_DESTROY()
tried to mem_put() it, which is not correct.
Fixes: #1440
Change-Id: Ic982bad07d4af30b915d7eb1fbcef7a847a45869
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit a0b5c8642373508b1428e8d2dee76449042161a6
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Sep 3 11:11:31 2020 +0300
glusterfsd, libglusterfs, rpc: prefer libglusterfs time API
Use timespec_now_realtime() rather than clock_gettime().
Change-Id: I8fa00b7c0f7b388305c7d19574be3b409db68558
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit 9ed1558ed088c8c4ddc372cb50a9ef8a04679f8f
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Mon Aug 31 14:17:24 2020 +0300
build: extend --enable-valgrind to support Memcheck and DRD
Extend '-enable-valgrind' to '--enable=valgrind[=memcheck,drd]'
to enable Memcheck or DRD Valgrind tool, respectively.
Change-Id: I80d13d72ba9756e0cbcdbeb6766b5c98e3e8c002
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit 585c4e965d963acc75c20b28ce5cee89fd6cee6a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Sep 1 11:36:42 2020 +0530
libglusterfs: fix dict leak
Problem:
gf_rev_dns_lookup_cached() allocated struct dnscache->dict if it was null
but the freeing was left to the caller.
Fix:
Moved dict allocation and freeing into corresponding init and fini
routines so that its easier for the caller to avoid such leaks.
Updates: #1000
Change-Id: I90d6a6f85ca2dd4fe0ab461177aaa9ac9c1fbcf9
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 92e9a8f19cc8b130bb1f355a65ab5ce88fbbe5c9
Author: nik-redhat <nladha@redhat.com>
Date: Thu Sep 3 15:42:45 2020 +0530
glusterd: use after free (coverity issue)
Issue:
dict_unref is called on the same dict again,
in the out label of the code, which causes the
use after free issue.
Fix:
Set the dict to NULL after unref, to avoid
use after free issue.
CID: 1430127
Updates: #1060
Change-Id: Ide9a5cbc5f496705c671e72b0260da6d4c06f16d
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 8c5d98802cfbdfb3bc84f1ccee5a49730fb56dcd
Author: nik-redhat <nladha@redhat.com>
Date: Wed Aug 26 15:08:56 2020 +0530
glusterd: cksum mismatch on upgrading to latest gluster
Issue:
In gluster versions less than 7, the checksums were calculated
whether or not the quota is enabled or not, and that cksum value
was also getting stored in the quota.cksum file. But, from gluster
7 version onwards cksum was calculated only if the quota is enabled.
Due to this, the cksums in quota.cksum files differ after upgrading.
Fix:
Added a check to see if the OP_VERSION is less than 7 then, follow
the previous method otherwise, move as per the latest changes for
cksum calculation.
This changes for the cksum calculation was done in
this commit : https://github.com/gluster/glusterfs/commit/3b5eb592f5
Fixes: #1332
Change-Id: I7a95e5e5f4d4be4983fb7816225bf9187856c003
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 4f3fe254022c472927fcad0753e9549e0a50328b
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Sep 3 19:21:16 2020 +0530
core: Avoid dict OR key is NULL message in brick logs
Problem: At the time of mount a volume server_first_lookup
call's syncop_lookup with a NULL xattr so index_lookup
is throwing a message at the time of fetching "link-count"
from a dictionary
Solution: Call dict_get_str_sizen instead of calling dict_get_str
to avoid a warning message
Fixes: #1464
Change-Id: I2b1ee3123ab817fa09f3abe39998c0d66ac0b824
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 1c1508bcb8d0a5cb3357c11830bf4b15631cf7a2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Aug 31 12:22:05 2020 +0530
cluster/ec: Don't trigger heal for stale index
Fixes: #1385
Change-Id: I3609dd2e1f63c4bd6a19d528b935bf5b05443824
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit d37e8070f697b207d520ad328402bc6ad741617d
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Sun Aug 16 13:07:17 2020 +0000
build: Added dependency for glusterfs-selinux
Fixes: #1442
Change-Id: I7d79bceff329db4d525bc8a77ba7ffe41bf53c97
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 99a085a3f98d1798c621b2050f3a577a6510405a
Author: Srijan Sivakumar <ssivakum@redhat.com>
Date: Tue Sep 1 12:48:48 2020 +0530
Events: Fixing coverity issues.
Fixing resource leak reported by coverity scan.
CID: 1431237
Change-Id: I2bed106b3dc4296c50d80542ee678d32c6928c25
Updates: #1060
Signed-off-by: Srijan Sivakumar <ssivakum@redhat.com>
commit d9635a30945eda1d02146d42d307a496d54530cb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Sep 2 09:30:45 2020 +0530
Revert "dht: optimize rebalance crawl path"
Based on the discussion on the issue, it is decided that it is
better to not have this implementation of the feature.
This reverts commit 3af9443c770837abe4f54db399623380ab9767a7.
Change-Id: I4e3bf18fc376cdb0cf29f1d98a915deca17c3496
Updates: #1422
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 639bae9fbc3b4df4edfcc20941d57b011c3bb961
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Aug 25 04:19:54 2020 +0530
cluster/ec: Change stale index handling
Problem:
Earlier approach is setting dirty bit which requires extra heal
Fix:
Send zero-xattrop which deletes stale index without any need
for extra heal.
Fixes: #1385
Change-Id: I7e97a1d8b5516f7be47cae55d0e56b14332b6cae
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 46536bfb75a5b88886fc73278b5d7123779946fe
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed May 20 11:30:17 2020 +0530
cluster/ec: Inform failure when some bricks are unavailable.
Provide proper information about failure when a fop
fails on some of the brick.
Also provide information about parent fop and
the map of the bricks on which it is failing.
Change-Id: If812739617df65cd146c8e667fbacff653717248
updates #1434
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 54faafa7568dc6df4e3de37efea1f810bece65dd
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Mon Aug 24 17:08:07 2020 +0300
performance/md-cache: simplify and cleanup internal time management
Since this xlator measures time intervals in seconds, timespec_now()
may be replaced with simpler gf_time(). Consistently use time_t and
uint32_t for timeouts, better error checking in mdc_reconfigure(),
adjust comments and messages as well.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Change-Id: I757c988e52db9d92348a900a43c617022a3d62af
Updates: #1002
commit 79edff6228be6fc0d7879c2994607fa0b242f029
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue Aug 18 13:10:42 2020 +0300
debug/io-stats: simplify and cleanup internal time management
Except latencies, this xlator measures time intervals in seconds,
so gettimeofday() may be replaced with simpler gf_time() where
appropriate. Simplify io_stats_clear() as well.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Change-Id: Iecaf416012da494eb4de502f915bb02ee3b4f64c
Updates: #1002
commit edd174f44d827332a77738e49d55c17e1aea4e42
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri Aug 7 15:18:21 2020 +0300
features/quota: simplify and cleanup internal time management
Since this xlator measures time intervals in seconds,
gettimeofday() may be replaced with simpler gf_time().
Simplify and convert quota_timeout() to static as well.
Change-Id: I0e042cdd759dd9fca25fcf8bc780e5fc4934f7e1
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit fa92e707cc00c9528ce4a5e499305f2b3b666cb2
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue Aug 11 11:28:16 2020 +0300
performance/quick-read: simplify and cleanup internal time management
Since this xlator measures time intervals in seconds,
gettimeofday() may be replaced with simpler gf_time().
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Change-Id: I5962771acbe8553dca51970183a55786a5289828
Updates: #1002
commit e3343bb292faa6d217ec1493b23859a89ed7f456
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Aug 6 15:19:50 2020 +0300
features/changelog: simplify and cleanup internal time management
Drop extra point of failure in changelog_fill_rollover_data(),
changelog_init() and reconfigure(), consistently use time_t
and gf_time() where appropriate, adjust all related users.
Change-Id: Id8e4236e96789cd74da5fdc3da05f0c1df98a62b
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit 5d69bed78527e0ed6a782c427e699cfc718cba53
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Jul 17 11:33:36 2020 +0200
fuse: fetch arbitrary number of groups from /proc/[pid]/status
Glusterfs so far constrained itself with an arbitrary limit (32)
for the number of groups read from /proc/[pid]/status (this was
the number of groups shown there prior to Linux commit
v3.7-9553-g8d238027b87e (v3.8-rc1~74^2~59); since this commit, all
groups are shown).
With this change we'll read groups up to the number Glusterfs
supports in general (64k).
Note: the actual number of groups that are made use of in a
regular Glusterfs setup shall still be capped at ~93 due to limitations
of the RPC transport. To be able to handle more groups than that,
brick side gid resolution (server.manage-gids option) can be used along
with NIS, LDAP or other such networked directory service (see
https://github.com/gluster/glusterdocs/blob/5ba15a2/docs/Administrator%20Guide/Handling-of-users-with-many-groups.md#limit-in-the-glusterfs-protocol
).
Also adding some diagnostic messages to frame_fill_groups().
Change-Id: I271f3dc3e6d3c44d6d989c7a2073ea5f16c26ee0
fixes: #1075
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 868541b36fbb599ef388e2d6152adb7c4be0c49d
Author: Sheena Artrip <sheenobu@fb.com>
Date: Wed Jan 29 15:12:17 2020 -0800
metadisp: new translator for data and metadata separation
Summary:
feature/metadisp is an xlator for performing "metadata dispersal" across
multiple children. it does this by flattening the complex
POSIX paths into /$GFID style paths, then forwarding the
metadata operations to its first child and forwarding the
data operations to its second child.
The purpose of this xlator is to allow separation of data and metadata,
in cases where metadata might be stored in another format (embedded kv?),
on another disk (ssd), on another host (dht2).
Change-Id: I392c8bd0c867a3237d144aea327323f700a2728d
Updates: #816
Signed-Off-By: Sheena Artrip <sheenobu@fb.com>
Tested-By: Amar Tumballi <amar@kadalu.io>
commit e1d7454edfe403d69a5dadcc253be2ca55df4999
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Mon Aug 10 13:01:33 2020 +0300
performance/io-cache: simplify and cleanup internal time management
Since this xlator measures time intervals in seconds, gettimeofday()
may be replaced with simpler gf_time(). Simplify and convert to
static ioc_inode_need_revalidate() as well.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Change-Id: Iaf13ecbf527589286ab3331c37429dd04bf6fa2c
Updates: #1002
commit 19bd2523253a73d5cf977d5890ba450c241daf4c
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri Aug 7 12:43:44 2020 +0300
features/locks: simplify and cleanup internal time management
Since this xlator measures time intervals in seconds,
gettimeofday() may be replaced with simpler gf_time().
Change-Id: Ib2c81376c093613124bdbed184516077cbe80dac
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit 0f1ea955a9df6dbdacf7e762006433279646e158
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue Aug 11 11:44:18 2020 +0300
cluster/dht: simplify and cleanup internal time management
Prefer time_t and gf_time() over 'struct timeval' and gettimeofday()
where microseconds are not really used, drop unneeded 'struct timeval'
to 'struct timespec' conversion in dht_file_counter_thread().
Change-Id: Ibd802f79b8848df3f6175ca1fd82e93532bba38d
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit e239fb6b015c08b1c8153d5ecf91e2bd257b0859
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue Aug 18 12:50:23 2020 +0300
features/bit-rot: simplify and cleanup internal time management
Since this xlator measures time intervals in seconds, gettimeofday() may
be replaced with simpler gf_time(). Adjust comments and style as well.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Change-Id: I2e5900ccb5da2478656d80e5f570487e3ba70966
Updates: #1002
commit a938601aef9e694940d7edb03f9b9e2946ee7b3d
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jan 21 19:01:33 2020 +0530
snapshot/ganesha: Modify ganesha export file while creating clone
A snapshot clone is nothing but a volume, So if the ganesha is
enabled for the parent volume, the clone should also have the
ganesha enabled.
This patch add clonename to the export file.
Change-Id: I847f23e62036aee02fb9e6adbc868aec6455d86e
Fixes: #1043
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit ba7f24b1cedf2549394c21b3f0df1661227cefae
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri Aug 14 11:05:12 2020 +0300
libglusterfs: add functions to calculate time difference
Add gf_tvdiff() and gf_tsdiff() to calculate the difference
between 'struct timeval' and 'struct timespec' values, use
them where appropriate.
Change-Id: I172be06ee84e99a1da76847c15e5ea3fbc059338
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit 3c9d5578a623ed1da20e435ddb1283f7b1e7e965
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Jul 27 18:08:00 2020 +0530
posix: Implement a janitor thread to close fd
Problem: In the commit fb20713b380e1df8d7f9e9df96563be2f9144fd6 we use
syntask to close fd but we have found the patch is reducing the
performance
Solution: Use janitor thread to close fd's and save the pfd ctx into
ctx janitor list and also save the posix_xlator into pfd object to
avoid the race condition during cleanup in brick_mux environment
Change-Id: Ifb3d18a854b267333a3a9e39845bfefb83fbc092
Fixes: #1396
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 0f61678b809f764290b43542fd9a00e93c59448a
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Aug 19 23:27:38 2020 +0200
open-behind: fix call_frame leak
When an open was delayed, a copy of the frame was created because the
current frame was used to unwind the "fake" open. When the open was
actually sent, the frame was correctly destroyed. However if the file
was closed before needing to send the open, the frame was not destroyed.
This patch correctly destroys the frame in all cases.
Change-Id: I8c00fc7f15545c240e8151305d9e4cf06d653926
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
Fixes: #1440
commit 233d144da236055a646cfca9135102929afb22c2
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Thu Aug 6 18:52:28 2020 +0530
dict: Remove redundant checks
fixes: #1428
Change-Id: I0cb1c42d620ac1aeab8da25a2e1d7835219d2e4a
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 372d4a75aed5ad41e007de5124bd3a32bff0c2a9
Author: Daniel Morante <daniel@morante.net>
Date: Sun Aug 9 21:58:37 2020 -0400
Remove need for /proc on FreeBSD
Change-Id: Ieebd9a54307813954011ac8833824831dce6da10
Fixes: #1376
commit 5731d25c9ff6a907fe68b99d1e79505b2331259d
Author: Amar Tumballi <amar@kadalu.io>
Date: Tue Aug 18 14:08:20 2020 +0530
tests: provide an option to mark tests as 'flaky'
* also add some time gap in other tests to see if we get things properly
* create a directory 'tests/000/', which can host any tests, which are flaky.
* move all the tests mentioned in the issue to above directory.
* as the above dir gets tested first, all flaky tests would be reported quickly.
* change `run-tests.sh` to continue tests even if flaky tests fail.
Reference: gluster/project-infrastructure#72
Updates: #1000
Change-Id: Ifdafa38d083ebd80f7ae3cbbc9aa3b68b6d21d0e
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 99c026b6989758901ef95f517a8bd652e8181927
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Aug 19 11:14:25 2020 +0530
afr: add null check for thin-arbiter gfid.
Problem:
Lookup/creation of thin-arbiter ID file happens in background during
mounting. On new volumes, if the ID file creation is in progress, and a
FOP fails on data brick, a post-op (xattrop) is attemtped on TA. Since
the TA file's gfid is null at this point, the ASSERT checks in protocol/
client causes a crash.
Fix:
Given that we decided to do Lookup/creation of thin-arbiter in
background, fail the other AFR FOPS on TA if the ID file's gfid is null
instead of winding it down to protocol/client.
Also remove afr_changelog_thin_arbiter_post_op() which seems to be dead
code.
Updates: #763
Change-Id: I70dc666faf55cc5c8f7cf8e7d36085e4fa399c4d
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit ba0f3d1e85f59ce6c745d30cf200c49d15bc7c14
Author: Vinayakswami Hariharmath <vharihar@redhat.com>
Date: Thu Aug 6 14:39:59 2020 +0530
features/shard: optimization over shard lookup in case of prealloc
Assume that we are preallocating a VM of size 1TB with a shard
block size of 64MB then there will be ~16k shards.
This creation happens in 2 steps shard_fallocate() path i.e
1. lookup for the shards if any already present and
2. mknod over those shards do not exist.
But in case of fresh creation, we dont have to lookup for all
shards which are not present as the the file size will be 0.
Through this, we can save lookup on all shards which are not
present. This optimization is quite useful in the case of
preallocating big vm.
Also if the file is already present and the call is to
extend it to bigger size then we need not to lookup for non-
existent shards. Just lookup preexisting shards, populate
the inodes and issue mknod on extended size.
Fixes: #1425
Change-Id: I60036fe8302c696e0ca80ff11ab0ef5bcdbd7880
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
commit b05aa0eadce60328205d4a453574c4c13049d4a8
Author: Rafi KC <rafi.kavungal@iternity.com>
Date: Fri Jun 12 15:36:00 2020 +0530
afr/halo: Halo is not showing any split-brain info
heal info command uses a gfapi based daemon to fetch the
split-brain info. Since they are using the same graph as
client, if the latency is high then one node will be
considered as down. Hence it cannot detect any split-brain
info
Change-Id: Id1b72f9c0e49cc0d35ad751b8a17d64da41a5d39
Fixes: #1355
Signed-off-by: Mohammed Rafi KC <rafi.kavungal@iternity.com>
commit ad2889dc5195c834136e1d74caf679089c8c6690
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Wed Jul 29 11:21:16 2020 +0300
libglusterfs: cleanup --disable-mempool
Use trivial no-op mempool if configured with --disable-mempool.
Cleanup OLD_MEM_POOLS leftovers, adjust related statedumps.
Change-Id: Ibaa90e538a34f6dcd216e45c05dd32d955b151f6
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1359
commit 578443ebabf9cce7b466eeba4a28c03047a69265
Author: srijan-sivakumar <ssivakum@redhat.com>
Date: Tue Jul 28 22:27:34 2020 +0530
Quota quota_fsck.py, converting byte string to string
Issue: The quota_fsck.py script throws an TypeError
due to the fact that the data is read as bytes and then
the string operations are applied on the. Now, in python3
string is unicode and hence we get the type error.
Code Changes:
Decoding the bytes value into utf-8 format.
Change-Id: Ia1ff52a821d664a371c8166692ff506ae39f6e40
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
Fixes: #1401
commit 0d79397fb1d0e6c51f53035d4a91fc8024e4c967
Author: srijan-sivakumar <ssivakum@redhat.com>
Date: Sat Jul 18 05:59:09 2020 +0530
Events: Socket creation after getaddrinfo and IPv4 and IPv6 packet capture
Issue: Currently, the socket creation is done
prior to getaddrinfo function being invoked. This
can cause mismatch in the protocol and address
families of the created socket and the result
of the getaddrinfo api. Also, the glustereventsd
UDP server by default only captures IPv4 packets
hence IPv6 packets are not even captured.
Code Changes:
1. Modified the socket creation in such a way that
the parameters taken in are dependent upon the
result of the getaddrinfo function.
2. Created a subclass for adding address family
in glustereventsd.py for both AF_INET and AF_INET6.
3. Modified addresses in the eventsapiconf.py.in
Reasoning behind the approach:
1. If we are using getaddrinfo function then
socket creation should happen only after we
check if we received back valid addresses.
Hence socket creation should come after the call
to getaddrinfo
2. The listening server which pushes the events
to the webhook has to listen for both IPv4
and IPv6 messages as we would not be sure as to
what address family is picked in _gf_event.
Fixes: #1377
Change-Id: I568dcd1a977c8832f0fef981e1f81cac7043c760
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit 2643f44103ad45580912c5202988823e01489061
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri Aug 14 13:47:13 2020 +0300
build: add custom clean rules
Make 'clean' and 'gitclean' even more cleaner by removing extra
build leftovers.
Change-Id: I9c261e1f029b8486f328aaa330f0476d44b58eac
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit 14200438772e70a66309e5017a2228ecb1dd181e
Author: Daniel Morante <daniel@morante.net>
Date: Sun Aug 9 21:44:33 2020 -0400
Use sysctl for get_mem_size() on FreeBSD
Change-Id: Iab2600260707af02e2b8da9e489cbb12b9fc14a6
Fixes: #1376
commit 7286d21cca261bb5e61deb4d231a8c4ec1860c0e
Author: Daniel Morante <daniel@morante.net>
Date: Sun Aug 9 21:40:59 2020 -0400
Add missing links to userspace RCU
Change-Id: I77519eb5ffb6a4a1f51f8c60f3fdd0eb0576c4ee
Fixes: #1376
commit 2c37b5c86f51e940f6125ab1b663f65a375b2c77
Author: Daniel Morante <daniel@morante.net>
Date: Sun Aug 9 21:38:52 2020 -0400
BSD: extattr_set_link and extattr_set_fd return bytes written not 0
Change-Id: I120006dab4e199ad3d3f4a5ebc9c352f3c49ea7d
Fixes: #1376
commit 30b5588c964d948898c33f8b06b2dc5047d65d3e
Author: Daniel Morante <daniel@morante.net>
Date: Sun Aug 9 21:35:07 2020 -0400
Missing link to mntent_compat for glusterd
Change-Id: I5d6d38759de4492de3256995e79d01b9ed7befef
Fixes: #1376
commit 21b490b0735fc28f58f1978b4e7571e4bc2be5a1
Author: Daniel Morante <daniel@morante.net>
Date: Sun Aug 9 21:30:45 2020 -0400
FreeBSD patches for fuse mount utility
Change-Id: Ib2bac85c28905bb8997fbb64db2308f2a6f31720
Fixes: #1376
commit 0d791811522bccf3993f2f1768f33ff0ecf1f68a
Author: nik-redhat <nladha@redhat.com>
Date: Tue Jul 28 11:45:09 2020 +0530
glusterd: performance improvement
Issue:
In the glusertd_op_stage_create_volume(), fetching of values
from the dict is done, whereas same values are fetched
by glusterd_check_brick_order() which is called from
that function. This leads to unnecssary performance overhead.
Fix:
Instead of fetching the values again, passing the
values to the glusterd_check_brick_order()
if it's fethced before, else a NULL is passed
and then only fetching is done here.
Also, few changes are made to the code to reduce
the cost of operations such as 'fast fail' for
false conditions and a bit of code clean up.
Fixes: #1397
Change-Id: Ic7b523adbca8eb63ef9eb29c206e3b19e05c0815
Signed-off-by: nik-redhat <nladha@redhat.com>
commit d4f01009e4e88e6be7c403a5f91f32ca00668e81
Author: nik-redhat <nladha@redhat.com>
Date: Tue Aug 11 23:12:26 2020 +0530
glusterd: memory deallocated twice
Issue:
If the the pointer tmptier is destroyed in the function
code it still it checks for the same in the out label.
And tries to destroy the same pointer again.
Fix:
So, instead of passing the ptr by value, if we
pass it by reference then, on making the ptr in the
function the value will persist, in the calling
function and next time when the gf_store_iter_destory()
is called it won't try to free the ptr again.
CID: 1430122
Updates: #1060
Change-Id: I019cea8e301c7cc87be792c03b58722fc96f04ef
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 047140b93f1acdff2f943faa3d2643217d3a1f97
Author: nik-redhat <nladha@redhat.com>
Date: Thu Jul 30 13:04:52 2020 +0530
glusterd: shared storage mount fails in ipv6 environment
Issue:
In case of ipv6 environment, the mounting of glusterd_shared_storage
volume fails as it doesn't recognises the ipv6 enviornment.
Fix:
In case of ipv6 environment, the address-family is passed
to the hooks script on creating shared-storage, then depending
upon the address-family --xlator-option=transport.address-family=inet6
option is added to the mount command, and the mounting succeeds.
Fixes: #1406
Change-Id: Ib1888c34d85e6c01618b0ba214cbe1f57576908d
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 22a2a78c416e27f588bc222f3cadf1e237eee401
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Mon Aug 10 11:45:58 2020 +0300
libglusterfs: add library wrapper for time()
Add thin convenient library wrapper gf_time(),
adjust related users and comments as well.
Change-Id: If8969af2f45ee69c30c3406bce5baa8305fb7f80
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit fac11b282400f43db4af575ea92575ade7dfc610
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Aug 13 18:21:19 2020 +0530
geo-rep: Fix string comparison
Fixes: #1438
Change-Id: If9f1c2e89e504512bcf77608fb4a4fedb19f0399
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit c893e652eff29cc702ee7b352eec1fab28bbb9e0
Author: Leonid Ishimnikov <lishim@fastmail.com>
Date: Thu Aug 13 15:37:50 2020 -0400
glusterd: dump SSL error stack on disconnect
Problem: When a non-SSL connection is attempted on an SSL-enabled
management port, unrelated peers are subsequently disconnected
from the node with a misleading error message.
Cause: A non-SSL client causes OpenSSL to push a wrong version error
into its thread-local error stack, but this error is never
cleared, and it lingers in the stack until the thread is used
by another SSL session, and a certain condition requires the error
stack to be examined, at which time the old error is discovered and
the connection is terminated.
Solution: Log and clear the error stack upon terminating the connection.
Change-Id: I82f3a723285df24dafc88850ae4fca65b69f6ae4
Fixes: #1418
Signed-off-by: Leonid Ishimnikov <lishim@fastmail.com>
commit 38f923c7dedf2d2131e6199493fa1be724bb1662
Author: Amar Tumballi <amar@kadalu.io>
Date: Wed Aug 12 17:58:51 2020 +0530
run-tests.sh: add index of the test being run
By showing details as (NNN / MMM) where NNN is the
index and MMM is the total test count. This helps
anyone looking at the console while tests are running
to figure out progress.
Updates: #1000
Change-Id: Id42435fada5325484d1bbc5fad8676af5dd1b5b0
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 268d6dcdbd9cbcac1b62f621f44df3ea4a14d083
Author: Mohammed Rafi KC <rafi.kavungal@iternity.com>
Date: Wed Jul 29 13:42:53 2020 +0530
afr/split-brain: fix client side split-brain resolution when quorum is enabled
Problem:
If we set favourite child policy, then automatic split-brain resolution
should work in all cases. This was failing when quorum count was set to
a non-zero value. The initial lookup before the read txn was failing
with ENOTCONN. Since we don't have a readable subvol, we were failing it.
We were only looking to the split brain resolution choice set through the
cli command.
Fix:
We will now consider the favourite child policy if split-brain choice
has not been set via cli command.
Change-Id: Id2016c3a90d0763ac6f1a0131571053f595576f0
Fixes: #1404
Signed-off-by: Mohammed Rafi KC <rafi.kavungal@iternity.com>
commit f1cac63a893161ff0fd58f32dab6bdf28dcbbafd
Author: srijan-sivakumar <ssivakum@redhat.com>
Date: Fri Aug 7 15:02:07 2020 +0530
Events: Log file not re-opened after logrotate.
Issue: The logging is being done in the same file
even after the logrotate utility has changed the file.
This causes the logfile to grow indefinitely.
Code Changes: Using the WatchedFileHandler class instead
of FileHandler class. This watches the file it is logging
into and if the file changes, it is closed and reopened
using the file name. Hence after file rotate, a new file
will be used for logging instead of continuing with
the same old file.
Fixes: #1289
Change-Id: I773d04f17613a03709cb682692efb39fd8e664e2
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
commit 673acf79880c640c3846e940d90236e185895d44
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue Jul 28 16:38:29 2020 +0300
libglusterfs: annotate synctasks with ThreadSanitizer API
If --enable-tsan is specified and API headers are detected,
annotate synctask context initialization and context switch
with ThreadSanitizer API.
Change-Id: I7ac4085d7ed055448f1fc80df7d59905d129f186
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1400
commit 64c31b275739db97d6561ffd621e34ac73a61f39
Author: Saju-Mohammed <sajmoham@redhat.com>
Date: Tue Aug 4 21:41:24 2020 +0530
glusterfs: infinite loop in common-utils.c
Issue: function - gf_rev_dns_lookup_cache having an infinite
loop when gf_dnscache_entry_init() returns NULL.
Also when ip address is coming in as NULL.
Fix: Code change has been done to handle the loop.
Also minor CLINT warnings removed for common-utils.c
Added review comment changes.
Code changes for #790
Change-Id: I24446dc64c0409009e91e0bf57a699c85337c578
Fixes: #790
Signed-off-by: msaju <sajmoham@redhat.com>
commit e79fb9be65daee34ebedc0fcd125846654384fcb
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Sat Aug 1 09:28:47 2020 +0530
glusterd: Increase buffer length to save multiple hostnames in peer file
Problem: At the time of handling friend update request glusterd updates peer
file and if DNS has returned multiple hostnames for the same IP, glusterd
saves all hostnames in peer file.In commit 1fa089e7a2b180e0bdcc1e7e09a63934a2a0c0ef
We changed the approach to save all key value pairs in single shot.
In case of a buffer is not having space to store the hostnames glusterd
writes partial hostname in peer file.
Solution: To avoid the failure increase the buffer length
Change-Id: Iee969d165333e9c5ba69431d474c541b8f12d442
Fixes: #1407
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit f6e5a16bf8fc5eb79b4a19ba66d344153a3baca0
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Mon Aug 3 20:09:49 2020 +0530
tests: Fix regression failures of 01-georep-glusterd-tests.t
TEST $GEOREP_CLI $master $slave1 create push-pem force
times out on Centos 7 builders.
Increasing the GEO_REP_TIMEOUT and SCRIPT_TIMEOUT
to address the same.
Fixes: #1410
Change-Id: I81b5590e33f40ea4210cc56d18e2b9fa34033cd8
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 3c12da2de10c020bd1a8acd13f642d5f0eabec7c
Author: Susant Palai <spalai@redhat.com>
Date: Mon Apr 27 16:59:16 2020 +0530
dht: optimize rebalance crawl path
For distribute only volumes we can use the information for
local subvolumes to avoid syncop calls which goes through the
whole stack to fetch stat and entries.
A separate function gf_defrag_fix_layout_puredist is introduced.
TODO: A glusterd flag needs to be introduced in case we want to
fall back to run the old way.
Perf numbers:
DirSize - 1Million Old New %diff
Depth - 100 (Run 1) 353 74 +377%
Depth - 100 (Run 2) 348 72 +377~%
Depth - 50 246 122 +100%
Depth - 3 174 114 +52%
Change-Id: I67cc136cebd34092fd775e69f74c2d5b33d3156d
Fixes: #1242
Signed-off-by: Susant Palai <spalai@redhat.com>
commit df55806608eef2e29f51519ff272a48cdc0b2541
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Sat Jul 25 11:28:43 2020 +0530
dict: optimize dict_serialized_length_lk function
To return the length of searlized dictionary the function
iterates full dictionary and access every key value member
of the dictionary.Instead of iterating full dictionary introduce
a variable totkvlen at dictionary to save the key value length
at the time of storing key/value pair in the dictionary.
Change-Id: Ie8cfdea1cc335bce51f59179281df3c89afab68b
Fixes: #1395
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit f6d4465535c67268cb2054309b687c56dec4b99e
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Jul 30 10:01:28 2020 +0530
test: ./tests/features/ssl-ciphers.t fail on centos 8
Check the tlsv1 openssl connection based on openssl version.
If openssl version is 1.1 it supports tls1 protocol otherwise
it supports tlsv1_2 protocol.
Fixes: #1403
Change-Id: I3ca286492049e6f84de70e3b969fa41db10378ab
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit bfdc20cf7e8cc829b9e5d8a8f7947ad9508b1c30
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sat Apr 11 08:56:24 2020 +0530
glusterd/auth.allow : allow add-brick from peers
Problem: When auth.allow list is set to some ip's, add-brick
operation is failing.
Cause: add-brick commands creates a temparary mount on the
bricks to set the extended attributes on the brick mount
points. When auth.allow list is set to default i.e, * (all)
we will not see any issue, but when it is set to certain ip's
add-brick operation fails as temparory mount on the bricks
fails because the peers are not part of auth.allow list.
Solution: When auth.allow list is already set, add all the
peers to the auth.allow list during add-brick operation.
the old list will be replaced in post commit phase.
As this can happen with replace-brick operation as well,
added code to handle it.
updates: #1391
Change-Id: I5ede8c35f05ab25ff431b88e074ddbe9c10a90f1
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 92bc0051a21f492580cd0e7fa02caaf2997cd0a4
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Jul 23 11:07:32 2020 +0530
cluster/ec: Remove stale entries from indices/xattrop folder
Problem:
If a gfid is present in indices/xattrop folder while
the file/dir is actaully healthy and all the xattrs are healthy,
it causes lot of lookups by shd on an entry which does not need
to be healed.
This whole process eats up lot of CPU usage without doing meaningful
work.
Solution:
Set trusted.ec.dirty xattr of the entry so that actual heal process
happens and at the end of it, during unset of dirty, gfid enrty from
indices/xattrop will be removed.
Change-Id: Ib1b9377d8dda384bba49523e9ff6ba9f0699cc1b
Fixes: #1385
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 52f318f8ccade8e3f0e187c12e1c71a0da60b9ad
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 28 18:31:23 2020 +0530
statedump: Dump xlator-name for mem-pool object
Fixes: #1399
Change-Id: I11cf75a0ea9a16724f36f73feb1c90dabed25c4b
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit beb4f905f00040ac75050e13661fae0841660280
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Sun Jul 26 17:06:55 2020 +0530
glusterd: fix resource leak
CID: 1430146
Change-Id: Icce4ffa0e78575b110e0cfd9d5cfd133141680c1
Updates: #1060
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit e909b532caf36c854c350173fa932a05ec11fe4c
Author: nik-redhat <nladha@redhat.com>
Date: Tue Jul 21 12:44:41 2020 +0530
libglusterfs/xlator: undefined symbol xlator_api
Issue:
On executiing the command gluster vol set help, an error
comes up in glusterd logs stating `undefined symbol: xlator_api`.
This issue is seen for the rpc-transport/socket.so file.
Fix:
The symbol `xlator_api` is not found in rpc-transport/socket.so
file as it is not a xlator but a shared object for transport.
In the `xlator.c` file, there is a function `xlator_volopt_dynload`,
which looks for the default values of the options available in gluster,
which is stored inside the respective xlator files for different voltypes.
In each of these files the `options` object is present which contains
the default values, which is therefore referenced from the `options` data
member of `xlator_api` object in case of xlators.But, since
`rpc-transport/socket.so` is not an xlator we don't have the `xlator_api`
object present to point to that object. So, in case of
`rpc-transport/socket.so` type we are accesing the `options` object
directly from the `xlator_volopt_dynload` function to fetch the default
values for the available options.
Fixes: #827
Change-Id: I3b2b0c1f2a11896be250aaca1a33a65b044991d5
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 6736b6be760d495f2351fd3b20a4cde3562626f5
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Jul 9 13:22:18 2020 +0200
extras/statedumpparse.rb updates
- allow reusing JSON formatted output with --input-format=json
- improve code readability
- improve human readable number formatting
- represent empty sections with {} rather than nil
- add memstat subformats (plain, human, json)
- make parsing of numerals more strict
Updates: #1000
Change-Id: I75833543c85ad2b9c2233a4a22b1ea53d24431b9
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit cd0332f0140a7173606c08faa6779677d69a3745
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Jul 14 19:22:19 2020 +0200
fuse: change setlk interrupt strategy to 'sync'
The setlk interrupt handler uses a 'fork' of the resolved
fuse state from setlk (a copy with some edits) to initiate
its own auxiliary fop. Thus the references stored in the
fuse states of the setlk fop and of its interrupt handler
are shared (apart from the ones edited by the interrupt
handler -- but the bulk of them remain as is). The lifetimes
of these references are tied to the setlk fop, which has
established them by properly claiming their backing
resources. To guarantee the validity of these references in
the interrupt context, we need to make sure that the setlk
fop did not reclaim the fuse state while the interrupt
handler is running.
In other words, the setlk fop needs to wait for the
termination of the interrupt handler, which is accomplished
by the 'sync' strategy of the interrupt API (passing
true for the 'sync' argument of
fuse_interrupt_finish_{fop,interrupt} functions).
Change-Id: I9a6dc76972507be4b7ba8d023cc876e5fddf813f
Updates: #1374
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 129bf4673b18c1b513d2d249e454b0c0fc008fb1
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Jul 15 20:33:07 2020 +0200
fuse: fix waiting for interrupt handler
With 'sync' strategy, a fop's cbk waits for
the interrupt handler to finish by making a
call to fuse_interrupt_finish_fop() with
sync = true.
The wait is implemented by monitoring an
interrupt_state struct member via a condition
variable. However, due to broken code logic,
the pthread_cond_wait() call is never reached.
This change introduces a new member to the
fuse_interrupt_state_t enum (the type of
aforementioned struct member),
FUSE_INTERRUPT_WAITING_HANDLER, which is then
used for indicating the state of waiting for
the interrupt handler.
Change-Id: I72ab06c37f45ff8f212a6a632bac1f647af05cbd
Updates: #1374
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 391978ec25e69e8bbe89bdd2d27d86be7f52163a
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Jul 22 02:42:44 2020 +0200
Make FUSE notification optional at configure time
NetBSD FUSE does not implement FUSE notification yet. This changes
makes this feature a configure time option so that it can be disabled.
Fixes: #1381
Change-Id: I3d977d8d69b57e1ac6957be84a9ddbb69b100893
Type: Bug
Signed-off-by: Emmanuel Dreyfus manu@netbsd.org
commit bb10f9f86fcdf6fb9b4c9dc0e4c7ef3a88ccd44b
Author: Tamar Shacked <tshacked@redhat.com>
Date: Tue Jul 21 09:31:18 2020 +0300
glusterd: getspec() returns wrong response when volfile not found
In a cluster env: getspec() detects that volfile not found.
but further on, this return code is set by another call
so the error is lost and not handled.
As a result the server responds with ambiguous message:
{op_ret = -1, op_errno = 0..} - which cause the client to stuck.
Fix:
server side: don't override the failure error.
fixes: #1375
Change-Id: Id394954d4d0746570c1ee7d98969649c305c6b0d
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit a28f998c794def14b8c8d843060a6172d86ba5b4
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Jul 20 07:54:39 2020 +0200
Screen the .attribute directory on NetBSD
This directory holds the extended attribute backing store on FFSv1
filesystems. It should be ignored by glusterfs just like the .glusterfs
directory.
Fixes: #1361
Change-Id: Ia259be2af722a651473a312b5044b431c2b01b10
Type: Bug
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
commit 50c9f7441cafa6f653319352a193e433a5a960fa
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Jul 22 11:03:51 2020 +0300
contrib: remove contrib/sunrpc/xdr_sizeof.c
It's not needed, and it has a license that Fedora is not very happy with.
Just removed that file.
Change-Id: Ia753f0058c8a7c6482aca40c3b3dc8f6aa4a266d
Fixes: #1383
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit e7a2f26539aa49990faff80ab36f20835f3496b7
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Jul 16 12:58:55 2020 +0300
multiple xlators: wording - replace blacklist, whitelist
Replace the use of blacklist and whitelist within the code.
No functional changes.
Fixes: #1378
Change-Id: Iaa10e31c3d460f52bfd12da906789fccca5ba4d4
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 420b322015f7025a8265517a81348c8c82a7f54e
Author: Barak Sason Rofman <sason922@gmail.com>
Date: Tue Jul 7 20:55:35 2020 +0300
dht - fixing xattr inconsistency
The scenario of setting an xattr to a dir, killing one of the bricks,
removing the xattr, bringing back the brick results in xattr
inconsistency - The downed brick will still have the xattr, but the rest
won't.
This patch add a mechanism that will remove the extra xattrs during
lookup.
This patch is a modification to a previous patch based on comments that
were made after merge:
https://review.gluster.org/#/c/glusterfs/+/24613/
fixes: #1324
Change-Id: Ifec0b7aea6cd40daa8b0319b881191cf83e031d1
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 0c6e82839f97fab7b950da61ab7cd88d3b98d9d8
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Jul 2 18:08:52 2020 +0200
cluster/ec: Improve detection of new heals
When EC successfully healed a directory it assumed that maybe other
entries inside that directory could have been created, which could
require additional heal cycles. For this reason, when the heal happened
as part of one index heal iteration, it triggered a new iteration.
The problem happened when the directory was healthy, so no new entries
were added, but its index entry was not removed for some reason. In
this case self-heal started and endless loop healing the same directory
continuously, cause high CPU utilization.
This patch improves detection of new files added to the heal index so
that a new index heal iteration is only triggered if there is new work
to do.
Change-Id: I2355742b85fbfa6de758bccc5d2e1a283c82b53f
Fixes: #1354
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit b5ae673bf1facc1ac4212a1629b67427b27da453
Author: Amar Tumballi <amar@kadalu.io>
Date: Mon Jul 20 23:05:10 2020 +0530
glusterfs.h: add IS_ERROR() and IS_SUCCESS() macro
These macros helps to clearly identify all negetive checks are 'errors',
and all 0 and above are success. With this clasification, we can add more
error codes to the process / method / function.
Updates: #280
Change-Id: I0ebc5c4ad41eb78e4f2c1b98648986be62e7b521
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit d1b953e05bec4be2ac3471d1c1088fe8883875e4
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Jul 20 11:53:10 2020 +0530
glusterd: avoid crash
When dirp is null, we should not call sys_closedir() on it.
fixes: #1379
Change-Id: I33633df983aeea11e9d685e41ed9ec58644b6258
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 68ba8094785bf19ccdaf6c0cd34e3e7d4cc05d98
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Jul 10 18:50:12 2020 +0200
doc: update fuse interrupt documentation
As Issue #1310 pointed out, for fops that
have interrupt handlers the fop handler
needs to pay attention to give the proper
FUSE response when it's interrupted.
This change extends the interrupt documentation
with guidelines regarding the FUSE response.
Also:
- improve wording
- add an 'Overview' section to explain the
code flow before going in to the technical
details
Change-Id: I852bfb717b1bde73f220878d6376429564413820
updates: #1374
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 38308b970d8b1f51911de4e6a4e2139ae037f37e
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Jul 8 19:05:50 2020 +0200
run-tests.sh improvements
Added --help and -R options.
-R sets $retry to "no"; so far there was no way
to disable retrying (default value for $retry is
yes and threre was an option only for enablement).
Change-Id: Ia7cedac52be72fe2abd60fb6bdd1927cfda0e229
Updates: #1000
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 4242a21d67497044b9bcd5469ac59c260daba434
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Jul 9 12:32:38 2020 +0300
libglusterfs: fix warnings issued with gcc-10 -Wtype-limits
dict.c:1129:16: warning: comparison is always false due to limited range of data type [-Wtype-limits]
dict.c:1129:38: warning: comparison is always false due to limited range of data type [-Wtype-limits]
dict.c:1151:16: warning: comparison is always false due to limited range of data type [-Wtype-limits]
dict.c:1151:39: warning: comparison is always false due to limited range of data type [-Wtype-limits]
Improve error checking and unify to common style as well.
Change-Id: Ia4f890bfaaf4e29c8514ee7e4d824d69020b9332
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: #1002
commit 510fd619bf9d16e3a9ecafeee769949ce609e04d
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jul 7 10:29:31 2020 -0400
xlators/cluster/afr: lto-type-mismatch
[ 144s] afr-dir-read.h:15:1: warning: type of 'afr_opendir' does not match original declaration [-Wlto-type-mismatch]
[ 144s] 15 | afr_opendir(call_frame_t *frame, xlator_t *this, loc_t *loc, fd_t *fd, dict_t *xdata)
[ 144s] | ^
[ 144s] afr-dir-read.c:71:1: note: type mismatch in parameter 5
[ 144s] 71 | afr_opendir(call_frame_t *frame, xlator_t *this, loc_t *loc, fd_t *fd)
[ 144s] | ^
[ 144s] afr-dir-read.c:71:1: note: 'afr_opendir' was previously declared here
only a warning, more of a truth-and-beauty thing
Change-Id: I2d6ff3fa0a8c5e6ef36e090a6545eaf638752192
Updates: #1002
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit decab80adb418a7679e17964b6cdd106c31b5134
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Jul 8 21:48:46 2020 +0200
tests/features/interrupt.t: fixes
- Modify the patterns for which we grep the logs so
that they don't match themselves. The test runner
inserts the invocation of the cases to the log, thus
the patterns will occur in the logs verbatim. So if
the pattern matches itself, the test case will be
moot (always reporting success).
- Invoke the test utility (open-and-sleep) on
unique paths so that the file at the passed
path shall be created on each invocation.
The kernel does not send an interrupt if
the file is extant. (This was shadowed by
the above mistske with result evaluation.)
- Modify the pattern for which we grep the log in
the test case where interrupt handling is expected
so that it asserts that the interrupt was handled.
(So far we did not exclude the possibility of the
interrupt triggered but not handled due to a race;
however, it seems to be the case that this theoretic
race does not have the potential to prevent interrupt
handling. And if this ever changes in the future we'd
rather be notified about that.)
Change-Id: I606da2b4064c1ecc4781c7dfdefed95a433478ce
Updates: #1374
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit e30e8c01f85ea8cdb7a4ed65c3515a37d0f4bebe
Author: Tamar Shacked <tshacked@redhat.com>
Date: Wed Jul 15 10:20:54 2020 +0300
cluster/dht: suppress file migration error for node not supposed to migrate file
A rebalance process does a lookup for every file in the dir it is processing
before checking if it supposed to migrate the file.
In this issue there are two rebalance processses running on a replica subvol:
R1 is migrating the FILE.
R2 is not supposed to migrate the FILE, but it does a lookup and
finds a stale linkfile which is mostly due to a stale layout.
Then, it tries to unlink the stale linkfile and gets EBUSY
as the linkfile fd is open due R1 migration.
As a result a misleading error msg about FILE migration failure
due EBUSY is logged in R2 logfile.
Fix:
suppress the error in case it occured in a node that
is not supposed to migrate the file.
fixes: #1371
Change-Id: I37832b404e2b0cc40ac5caf45f14c32c891e71f3
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit 5b467d177f296d09464a70ff047c24a5fc0bef42
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Jul 13 16:37:30 2020 +0530
cluster/afr: Fixing coverity issues
Fixing the unchecked return value issues reported by coverity scan
CID: 1400734
CID: 1400750
Change-Id: I3c953df9ade4a1548e41e18018edb1b041f7e15e
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Updates: #1060
commit c808f4bda2839bbe0691215a1e69efff36f8a7cd
Author: Aravinda Vishwanathapura <aravinda@kadalu.io>
Date: Sun Jul 12 12:42:36 2020 +0530
geo-replication: Fix IPv6 parsing
Brick paths in Volinfo used `:` as delimiter, Geo-rep uses split
based on `:` char. This will go wrong with IPv6.
This patch handles the IPv6 case and handles the split properly.
Fixes: #1366
Change-Id: I25e88d693744381c0ccf3c1dbf1541b84be2499d
Signed-off-by: Aravinda Vishwanathapura <aravinda@kadalu.io>
commit 081c71d7f2aac6828ac42718da3afa38b5418e37
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Jul 7 21:49:50 2020 +0300
glusterd-utils.c: display which options have changed
Display which options were not changed from the default.
The user may have opted to change some global or volume options
from the default they were initially. Display '(DEFAULT)' if the values
used are those that were not explicitly set by the user.
Example output:
Option Value
------ -----
cluster.server-quorum-ratio 50
cluster.enable-shared-storage disable (DEFAULT)
cluster.op-version 80000
cluster.max-op-version 90000
cluster.brick-multiplex disable (DEFAULT)
cluster.max-bricks-per-process 250 (DEFAULT)
glusterd.vol_count_per_thread 100 (DEFAULT)
cluster.localtime-logging disable (DEFAULT)
cluster.daemon-log-level INFO (DEFAULT)
Since glusterfind uses the value, it is now filtering the value
and only picking the 1st word (which is the value itself) and ignores
the rest, which may now be '(DEFAULT)'.
Fixes: #1357
Change-Id: I7c59055158d099a5de38943f2169fd02c77f5d09
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 23da3f43fba0e475d7b7d4aa1be5544f067b7fe7
Author: nik-redhat <nladha@redhat.com>
Date: Thu Jul 9 03:59:48 2020 +0530
glusterd: dereference of null pointer
Issue:
'this' is used before it is defined,
therefore it can lead to a NULL dereference.
Fix:
Moved the definition of 'this', before it's use
to avoid NULL dereference.
Change-Id: I6ad382192129dfa3a206426e5610040e7a905be6
Updates: #1096
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 24bc52d4b7a47c3f128f5bb4e0de365979b39285
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jul 7 10:51:58 2020 -0400
xlators/protocol/server: lto-type-mismatch
[ 202s] server-common.h:192:1: warning: type of 'server4_post_link' does not match original declaration [-Wlto-type-mismatch]
[ 202s] 192 | server4_post_link(server_state_t *state, gfx_common_3iatt_rsp *rsp, inode_t *inode, struct iatt *stbuf, struct iatt *pre, struct iatt *post);
[ 202s] | ^
[ 202s] server-common.c:847:1: note: type mismatch in parameter 7
[ 202s] 847 | server4_post_link(server_state_t *state, gfx_common_3iatt_rsp *rsp,inode_t *inode, struct iatt *stbuf, struct iatt *pre, struct iatt *post, dict_t *xdata)
[ 202s] | ^
[ 202s] server-common.c:847:1: note: 'server4_post_link' was previously declared here
goes back to glusterfs-6 at least.
Only a warning, more of a truth-and-beauty thing.
Change-Id: Ib4a74b2d00aec519e9d80a4bdeca20eb6273777f
Updates: #1002
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 64967fd5c37f16785b170c7603244586c1fdaa68
Author: Susant Palai <spalai@redhat.com>
Date: Tue Jun 23 12:13:44 2020 +0530
dht: Heal missing dir entry on brick in revalidate path
Mark dir as missing in layout structure to be healed in
dht_selfheal_directory.
fixes: #1327
Change-Id: If2c69294bd8107c26624cfe220f008bc3b952a4e
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 3b49953196a0d7f3494e12192dc370cbf25d5161
Author: Barak Sason Rofman <sason922@gmail.com>
Date: Sun Jul 5 13:40:23 2020 +0300
glusterd - fixing coverity issues
Fixing double free issues
Change-Id: Ie56753196335080f32f061329644ac462998ada2
CID: 1430112, 1430122
updates: #1202
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit e8ca4d3fed516cd94500c576c17300f2ccb4c3c7
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Sun Jul 5 11:15:16 2020 +0300
nfs - fixing coverity issues
Fixing use-after-free issues
Change-Id: I33e599da6b8159695e2c9e989421b5877d7200b5
CID: 1430117, 1430138, 1430116
updates: #1202
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 0f9797a931f999fa34fc39dcc032cfe33b1aec12
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jul 6 16:19:08 2020 -0400
cli: type mismatch global_quotad_rpc in cli-quotad-client.c
...
[ 236s] (.text+0x0): multiple definition of `cli_default_conn_timeout'; cli.o (symbol from plugin):(.text+0x0): first defined here
[ 236s] cli-quotad-client.c:13:24: warning: type of 'global_quotad_rpc' does not match original declaration [-Wlto-type-mismatch]
[ 236s] 13 | extern struct rpc_clnt global_quotad_rpc;
[ 236s] | ^
[ 236s] cli.c:80:18: note: 'global_quotad_rpc' was previously declared here
[ 236s] 80 | struct rpc_clnt *global_quotad_rpc;
[ 236s] | ^
[ 236s] cli.c:80:18: note: code may be misoptimized unless '-fno-strict-aliasing' is used
[ 239s] collect2: error: ld returned 1 exit status
...
move several global extern decls to cli.h.
Found on SUSE Tumbleweed w/ gcc-10 and LTO. This bug goes back
at least as far as release-6. Curiously this only popped up as an
error when building 6.9, not 7.4 or 8.0. And not when building
8.0 on Fedora rawhide/33.
Change-Id: I765642cea77b524a36368a7ff1a2976ef049dd0f
Fixes: #1356
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 349c3f086960df7b11a37cbbc686ff22b7576164
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jul 7 09:59:51 2020 -0400
xlator/mgmt/glusterd: lto-type-mismatch
Seen in fedora rawhide/33, and SUSE tumbleweed, in all versions
going back at least as far as glusterfs-6.
[ 351s] glusterd.c:68:13: warning: type of 'snap_mount_dir' does not match original declaration [-Wlto-type-mismatch]
[ 351s] 68 | extern char snap_mount_dir[PATH_MAX];
[ 351s] | ^
[ 351s] glusterd-snapshot.c:65:6: note: array types have different bounds
[ 351s] 65 | char snap_mount_dir[VALID_GLUSTERD_PATHMAX];
[ 351s] | ^
[ 351s] glusterd-snapshot.c:65:6: note: 'snap_mount_dir' was previously declared here
In this case it's only a warning, but certainly merits fixing.
Another case where a decl in a header file instead of open-coding
extern decls in multiple .c files would have been preferable.
Change-Id: Idc91e536a56a1a7717be83ed27698069e71dff67
Updates: #1002
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit fb3515304af828a999698f221900754f9fc5efef
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Sep 12 11:07:10 2019 +0530
features/shard: Convert shard block indices to uint64
This patch fixes a crash in FOPs that operate on really large sharded
files where number of participant shards could sometimes exceed
signed int32 max.
The patch also adds GF_ASSERTs to ensure that number of participating
shards is always greater than 0 for files that do have more than one
shard.
Change-Id: I354de58796f350eb1aa42fcdf8092ca2e69ccbb6
Fixes: #1348
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 9137c5089d1f57f92f43b6599d1fbc025b5c93c3
Author: nik-redhat <nladha@redhat.com>
Date: Thu Jul 2 18:10:32 2020 +0530
glusterd: null dereference
Issue:
There has been either an explicit null
dereference or a dereference after null
check in some cases.
Fix:
Added the proper condition for null check
and fixed null derefencing.
CID: 1430106 : Dereference after null check
CID: 1430120 : Explicit null dereferenced
CID: 1430132 : Dereference after null check
CID: 1430134 : Dereference after null check
Change-Id: I7e795cf9f7146a633097c26a766f16b159881fa3
Updates: #1060
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 2cfe6594aa97fb1c4c56e40c11c28c39775c2a62
Author: nik-redhat <nladha@redhat.com>
Date: Fri Jul 3 17:18:33 2020 +0530
afr: null dereference & nagative value
Added a check for NULL before dereferencing
the object as it may be NULL in few cases
inside the funtion. Also, added a check for
the negative value of gfid_idx.
CID: 1430140
CID: 1430145
Change-Id: Ib7d23459b48bbc471dbcccab6d20572261882d11
Updates: #1060
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 32ed15d3630fa1e139ba7e345fb9a9c166745f6d
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Wed Jul 1 12:19:05 2020 +0300
libglusterfs, glusterd: tweak directory scanning
Replace an over-engineered GF_SKIP_IRRELEVANT_ENTRIES() with
inline function gf_irrelevant_entry(), adjust related users.
Change-Id: I6f66c460f22a82dd9ebeeedc2c55fdbc10f4eec5
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1350
commit 070630974f6f38ef35aa45b82a75f540eba709c6
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue May 19 16:13:01 2020 +0100
geo-rep: Fix corner case in rename on mkdir during hybrid crawl
Problem:
The issue is being hit during hybrid mode while handling rename on slave.
In this special case the rename is recorded as mkdir and geo-rep process it
by resolving the path form backend.
While resolving the backend path during this special handling one corner case is not considered.
<snip>
Traceback (most recent call last):
File "/usr/libexec/glusterfs/python/syncdaemon/repce.py", line 118, in worker
res = getattr(self.obj, rmeth)(*in_data[2:])
File "/usr/libexec/glusterfs/python/syncdaemon/resource.py", line 588, in entry_ops
src_entry = get_slv_dir_path(slv_host, slv_volume, gfid)
File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 710, in get_slv_dir_path
dir_entry = os.path.join(pfx, pargfid, basename)
File "/usr/lib64/python2.7/posixpath.py", line 75, in join
if b.startswith('/'):
AttributeError: 'int' object has no attribute 'startswith'
In pyhthon3:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib64/python3.8/posixpath.py", line 90, in join
genericpath._check_arg_types('join', a, *p)
File "/usr/lib64/python3.8/genericpath.py", line 152, in _check_arg_types
raise TypeError(f'{funcname}() argument must be str, bytes, or '
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'int'
</snip>
Change-Id: I8b926899c60ad8c4ffc886d57028ba70fd21e332
Fixes: #1250
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 267c612dd72dd9698391ebb36ec13898364f469f
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Jun 18 15:57:25 2020 +0300
build: improve support for sanitizers
Fix --enable-asan and --enable-tsan, add --enable-ubsan.
Change-Id: Ifb3c44107ecaee4cad4bc88dd81c49c6cd691764
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1320
commit bf2e48fdf45d06987c57afab30def47a789e5a7e
Author: Barak Sason Rofman <sason922@gmail.com>
Date: Sun Jul 5 19:53:30 2020 +0300
glusterfsd - fixing a coverity issue
Fixing a resource leak issue
Change-Id: I6c75de02887ddd59f7edfd65ebeca9d9629c6f1f
CID: 1430129
updates: #1202
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit dbaa39f0e4704323bccf9e6ee31498ec2dc725ab
Author: nik-redhat <nladha@redhat.com>
Date: Tue May 26 18:45:46 2020 +0530
tests: added volume operations to increase code coverage
Added test for volume options like
localtime-logging, fixed enable-shared-storage
to include function coverage and few negative
tests for other volume options to increase the
code coverage in the glusterd component.
Change-Id: Ib1706c1fd5bc98a64dcb5c8b15a121d639a597d7
Updates: #1052
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 0e54a58b7998d0411a65283030f50133a689099c
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Jul 3 13:45:00 2020 +0530
glusterd: change the log-level to Warning
Reason for changing the log-level stated at the github isse
fixes: #1353
Change-Id: I21202075916c5a7525e5f26e7fb595efe7717b66
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit aed59161bdf09238db47c54f7e7413b3fe3b2907
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jul 2 15:52:15 2020 -0400
api: libgfapi symbol versions break LTO in Fedora rawhide/f33
The way symbol versions are implemented is incompatible with gcc-10 and LTO.
Fedora provenpackager Jeff Law (law [at] redhat.com) writes in the
Fedora dist-git glusterfs.spec:
This package uses top level ASM constructs which are incompatible with LTO.
Top level ASMs are often used to implement symbol versioning. gcc-10
introduces a new mechanism for symbol versioning which works with LTO.
Converting packages to use that mechanism instead of toplevel ASMs is
recommended.
In particular, note that the version of gluster in Fedora rawhide/f33 is
glusterfs-8.0RC0. Once this fix is merged it will be necessary to backport
it to the release-8 branch.
At the time that gfapi symbol versions were first implemented we copied
the GNU libc (glibc) symbol version implementation following Uli Drepper's
symbol versioning HOWTO.
Now gcc-10 has a symver attribute that can be used instead. (Maybe it
has been there all along?)
Both the original implemenation and this implemenation yield the same
symbol versions. This can be seen by running
`nm -D --with-symbol-versions libgfapi.so`
on the libgfapi.so built before and after applying this fix.
Change-Id: I05fda580afacfff1bfc07be810dd1afc08a92fb8
Fixes: #1352
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 83f4145fe885414b4b3070f56aabfd90253687af
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jul 2 02:07:56 2020 +0530
Issue with gf_fill_iatt_for_dirent
In "gf_fill_iatt_for_dirent()", while calculating inode_path for loc,
the inode should be of parent's. Instead it is loc.inode which results in error
and eventually lookup/readdirp fails.
This patch fixes the same.
Change-Id: Ied086234a4634e8cb13520521ac547c87b3c76b5
Fixes: #1351
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 7c733e6efa2aba2fc7a3b49a07e2356aa382ca56
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Jun 26 12:10:31 2020 +0530
glusterd: rebalance status displays stats as 0 after reboot
problem: while the rebalance is in progress, if a node is
rebooted rebalance v status shows the stats of this node as
0 once the node is back.
Reason: when the node is rebooted, once it is back
glusterd_volume_defrag_restart() starts the rebalance and
creates the rpc. but due to some race, rebalance process is
sending disconnect event, so rpc object is getting destroyed. As
the rpc object is null, request for fetching the latest stats is
not sent to rebalance process. and stats are shows as default values
which is 0.
Solution: When the rpc object null, we should create the rpc if the
rebalance process is up. so that request can be sent to rebalance
process using the rpc.
fixes: #1339
Change-Id: I1c7533fedd17dcaffc0f7a5a918c87356133a81c
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit b071a182029ef37210f941657a34b7be71b0f7bf
Author: Anoop C S <anoopcs@redhat.com>
Date: Sat Jun 20 13:26:13 2020 +0530
build: Pass $(LIB_DL) using prog_LDADD or lib_LIBADD
"Program and Library Variables" section from Automake manual suggests
the following:
. . .
_LDADD and _LIBADD are inappropriate for passing program-specific linker
flags (except for -l, -L, -dlopen and -dlpreopen). Use the _LDFLAGS
variable for this purpose.
. . .
Therefore it is reasonable to move $(LIB_DL) additon from _LDFLAGS to
_LDADD and _LIBADD variables for program and library respectively.
Change-Id: Id8b4734c207ab28a08bcce683d316cdc7acb0bcd
Updates: #1000
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit c743d0dcc7809632d1e98ef12378d04eb806ec8c
Author: nik-redhat <nladha@redhat.com>
Date: Mon Jun 29 17:14:03 2020 +0530
glusterd: removing unused macro
Removed the macro 'GD_MSG_DICT_SERL_LENGTH_GET_FAIL'
from the glusterd-messages file as
'GD_MSG_DICT_ALLOC_AND_SERL_LENGTH_GET_FAIL' is
used in it's place
Change-Id: I69d7d95b5cb8f1bdd7e616d7a3e9539e891ba378
Fixes: #874
Signed-off-by: nik-redhat <nladha@redhat.com>
commit cc72654782a03375210822cf76a7bb97faceef43
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Jul 1 09:09:47 2020 +0530
MAINTAINERS: update to AFR maintainers
-P: Ravishankar N <ravishankar@redhat.com>
+M: Ravishankar N <ravishankar@redhat.com>
+P: Karthik US <ksubrahm@redhat.com>
Based on contributions + subject matter knowledge and ack from current
maintainer and project architects.
updates: #1000
Change-Id: Iae7770094adda24331f17c260e9966816d9cf9be
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit b6a657e8eb764cc0c0b0cec9d9c87234fc8b1fc4
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Jun 30 16:42:36 2020 +0200
NetBSD build fixes
- Make sure -largp is used at link time
- PTHREAD_MUTEX_ADAPTIVE_NP is not available, use PTHREAD_MUTEX_DEFAULT instead
- Avoid non POSIX [[ ]] in scripts
- Do not check of lock.spinlock is NULL since it is not a pointer
(it is not a pointer on Linux either)
Change-Id: I5e04a7c552d24f8a473c2b837828d1bddfa7e128
Fixes: #1347
Type: Bug
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
commit 9c3c834f7b83334330f09357be16c379017e2db3
Author: nik-redhat <nladha@redhat.com>
Date: Tue Mar 24 16:48:21 2020 +0530
glusterd: additional log information
Issue:
Some of the functions didn't had sufficient
logging of information in case of failure.
Fix:
Added log information in few functions in
case of failure indicating the cause of
such event.
Change-Id: I301cf3a1c8d2c94505c6ae0d83072b0241c36d84
fixes: #874
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 0845c72996ffd1240397974db849d748dd2ff5bb
Author: Barak Sason Rofman <sason922@gmail.com>
Date: Thu Jun 25 12:51:04 2020 +0300
Revert "dht - fixing xattr inconsistency"
This reverts commit 620158475f462251c996901a8e24306ef6cb4c42.
The patch to revert is https://review.gluster.org/#/c/glusterfs/+/24613/
Reverting is required as comments were posted regarding a more
efficient implementation were made after the patch was merged.
A new patch will be posted to adress the comments will be posted.
updates: #1324
Change-Id: I59205baefe1cada033c736d41ce9c51b21727d3f
Signed-off-by: Barak Sason Rofman <redhat@gmail.com>
commit 92b87da1e296e458c270b50fe70e010748b6b55c
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Sun Jun 21 14:38:56 2020 +0300
dht - fixing xattr inconsistency
The scenario of setting an xattr to a dir, killing one of the bricks,
removing the xattr, bringing back the brick results in xattr
inconsistency - The downed brick will still have the xattr, but the rest
won't.
This patch add a mechanism that will remove the extra xattrs during
lookup.
fixes: #1324
Change-Id: Ibcc449bad6c7cb46bcae380e42e4496d733b453d
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 61f0684ea9aba7e54de66e02762c789a3d081197
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Mon Jun 22 16:43:26 2020 +0300
storage/posix, libglusterfs: library function to sync filesystem
Convert an ad-hoc hack to a regular library function gf_syncfs().
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Change-Id: I3ed93e9f28f22c273df1466ba4a458eacb8df395
Fixes: #1329
commit 3ba1feb1608c94d34367fe903ec4bed4871db0ea
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Jun 16 18:03:21 2020 +0530
glusterd: add-brick command failure
Problem: add-brick operation is failing when replica or disperse
count is not mentioned in the add-brick command.
Reason: with commit a113d93 we are checking brick order while
doing add-brick operation for replica and disperse volumes. If
replica count or disperse count is not mentioned in the command,
the dict get is failing and resulting add-brick operation failure.
fixes: #1306
Change-Id: Ie957540e303bfb5f2d69015661a60d7e72557353
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 3959584b17e31da6b2510320bf5d4ddebf9bd27b
Author: Anoop C S <anoopcs@redhat.com>
Date: Fri Jun 19 11:27:38 2020 +0530
extras/systemd: Move StartLimitIntervalSec to [Unit] section
It has been a while since systemd moved[1] StartLimitInterval= and
StartLimitBurst= options(along with some others) from [Service] to
[Unit] section. Additionally StartLimitInterval= got renamed[2] to
StartLimitIntervalSec= and can be configured only in [Service] section.
Therefore making necessary modifications to avoid following warning:
$ sudo systemd-analyze verify glusterd.service
/usr/local/lib/systemd/system/glusterd.service:21: Unknown key name 'StartLimitIntervalSec' in section 'Service', ignoring.
For backward compatability reasons those options configured in [Service]
section are also honoured but officially documented in man
systemd.unit(5)[3].
[1] https://github.com/systemd/systemd/commit/6bf0f408e4833152197fb38fb10a9989c89f3a59
[2] https://github.com/systemd/systemd/commit/f0367da7d1a61ad698a55d17b5c28ddce0dc265a
[3] https://www.freedesktop.org/software/systemd/man/systemd.unit.html
Change-Id: I72a5b65930ddcf1d84c7e66f11685fa9a6fbda9a
Updates: #1000
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 8fe08736f1189ba169d77aab5fad57ab60e939c1
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue Jun 16 14:45:03 2020 +0300
cli: fix data race when handling connection status
Found with GCC ThreadSanitizer:
WARNING: ThreadSanitizer: data race (pid=287943)
Write of size 4 at 0x00000047dfa0 by thread T4:
#0 cli_rpc_notify /path/to/glusterfs/cli/src/cli.c:313 (gluster+0x40a6df)
#1 rpc_clnt_handle_disconnect /path/to/glusterfs/rpc/rpc-lib/src/rpc-clnt.c:821 (libgfrpc.so.0+0x13f04)
#2 rpc_clnt_notify /path/to/glusterfs/rpc/rpc-lib/src/rpc-clnt.c:882 (libgfrpc.so.0+0x13f04)
#3 rpc_transport_notify /path/to/glusterfs/rpc/rpc-lib/src/rpc-transport.c:520 (libgfrpc.so.0+0xf070)
#4 socket_event_poll_err /path/to/glusterfs/rpc/rpc-transport/socket/src/socket.c:1364 (socket.so+0x812c)
#5 socket_event_handler /path/to/glusterfs/rpc/rpc-transport/socket/src/socket.c:2958 (socket.so+0xc453)
#6 socket_event_handler /path/to/glusterfs/rpc/rpc-transport/socket/src/socket.c:2854 (socket.so+0xc453)
#7 event_dispatch_epoll_handler /path/to/glusterfs/libglusterfs/src/event-epoll.c:640 (libglusterfs.so.0+0xcaf23)
#8 event_dispatch_epoll_worker /path/to/glusterfs/libglusterfs/src/event-epoll.c:751 (libglusterfs.so.0+0xcaf23)
#9 <null> <null> (libtsan.so.0+0x2d33f)
Previous read of size 4 at 0x00000047dfa0 by thread T3 (mutexes: write M3587):
#0 cli_cmd_await_connected /path/to/glusterfs/cli/src/cli-cmd.c:321 (gluster+0x40ca37)
#1 cli_cmd_process /path/to/glusterfs/cli/src/cli-cmd.c:123 (gluster+0x40cc74)
#2 cli_batch /path/to/glusterfs/cli/src/input.c:29 (gluster+0x40c2b9)
#3 <null> <null> (libtsan.so.0+0x2d33f)
Location is global 'connected' of size 4 at 0x00000047dfa0 (gluster+0x00000047dfa0)
Change-Id: Ie85a8a80a2c5b82252c0c1d45e68ebe9938da2eb
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1311
commit 69d58b18813785820d8699a18b23dc3d95733627
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jun 17 10:45:19 2020 +0530
mount/fuse: use cookies to get fuse-interrupt-record instead of xdata
Problem:
On executing tests/features/flock_interrupt.t the following error log
appears
[2020-06-16 11:51:54.631072 +0000] E
[fuse-bridge.c:4791:fuse_setlk_interrupt_handler_cbk] 0-glusterfs-fuse:
interrupt record not found
This happens because fuse-interrupt-record is never sent on the wire by
getxattr fop and there is no guarantee that in the cbk it will be
available in case of failures.
Fix:
wind getxattr fop with fuse-interrupt-record as cookie and recover it
in the cbk
Fixes: #1310
Change-Id: I4cfff154321a449114fc26e9440db0f08e5c7daa
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 1966619ed0a3cff11fe7213dc4b5bd85f1c2b0ed
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jun 17 10:44:37 2020 +0530
features/locks: posixlk-clear-lock should set error as EINTR
Problem:
fuse on receiving interrupt for setlk sends clear-lock "fop"
using virtual-getxattr. At the moment blocked locks which are
cleared return EAGAIN errno as opposed to EINTR errno
Fix:
Return EINTR errno.
Updates: #1310
Change-Id: I47de0fcaec370b267f2f5f89deeb37e1b9c0ee9b
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit a5aab919f8880d5ff03e395946ca00ec077d2278
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Jun 4 16:42:30 2020 +0300
rpc: fix undefined behaviour in __builtin_ctz
Found with GCC UBsan:
rpcsvc.c:102:36: runtime error: passing zero to ctz(), which is not a valid argument
#0 0x7fcd1ff6faa4 in rpcsvc_get_free_queue_index /path/to/glusterfs/rpc/rpc-lib/src/rpcsvc.c:102
#1 0x7fcd1ff81e12 in rpcsvc_handle_rpc_call /path/to/glusterfs/rpc/rpc-lib/src/rpcsvc.c:837
#2 0x7fcd1ff833ad in rpcsvc_notify /path/to/glusterfs/rpc/rpc-lib/src/rpcsvc.c:1000
#3 0x7fcd1ff8829d in rpc_transport_notify /path/to/glusterfs/rpc/rpc-lib/src/rpc-transport.c:520
#4 0x7fcd0dd72f16 in socket_event_poll_in_async /path/to/glusterfs/rpc/rpc-transport/socket/src/socket.c:2502
#5 0x7fcd0dd8986a in gf_async ../../../../libglusterfs/src/glusterfs/async.h:189
#6 0x7fcd0dd8986a in socket_event_poll_in /path/to/glusterfs/rpc/rpc-transport/socket/src/socket.c:2543
#7 0x7fcd0dd8986a in socket_event_handler /path/to/glusterfs/rpc/rpc-transport/socket/src/socket.c:2934
#8 0x7fcd0dd8986a in socket_event_handler /path/to/glusterfs/rpc/rpc-transport/socket/src/socket.c:2854
#9 0x7fcd2048aff7 in event_dispatch_epoll_handler /path/to/glusterfs/libglusterfs/src/event-epoll.c:640
#10 0x7fcd2048aff7 in event_dispatch_epoll_worker /path/to/glusterfs/libglusterfs/src/event-epoll.c:751
...
Fix, simplify, and prefer 'unsigned long' as underlying bitmap type.
Change-Id: If3f24dfe7bef8bc7a11a679366e219a73caeb9e4
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1283
commit c8c1829f68e5abb1fa9efad426142517112b4837
Author: Amar Tumballi <amar@kadalu.io>
Date: Tue Apr 21 22:23:47 2020 +0530
volgen: add an option to disable acl
Also add a message saying this is to be used only
for 'debug' purpose only. This is helpful to corner the
issue to acl. There were recently many issues reported
related to permissions, and acl access denied bugs.
The bugs were elsewhere, but to validate them and to
get people back to service (in certain cases like oVirt,
where gluster volumes are used mostly by single user),
this option can be used.
Updates: #876
Change-Id: I7be4401153607e11c9efb831ab794df4176604df
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 0d2ab3b4f3ccbeefeec03d93ae07d9357de6224d
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri May 29 10:53:11 2020 +0530
tests/glusterd: spurious failure of tests/bugs/glusterd/mgmt-handshake-and-volume-sync-post-glusterd-restart.t
Test Summary Report
-------------------
tests/bugs/glusterd/mgmt-handshake-and-volume-sync-post-glusterd-restart.t
(Wstat: 0 Tests: 23 Failed: 3)
Failed tests: 21-23
After glusterd restart, volume start is failing. Looks like, it need some
time to sync the data. Adding sleep for the same.
Note: All other changes are made to avoid spurious failures in the future.
fixes: #1272
Change-Id: Ib184757fb936e03b5b6208465e44a8e790b71c1c
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit c0bd592e2470d23069a6bda4de8c03c6fa7bdf55
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Jun 12 00:06:36 2020 +0200
locks: prevent deletion of locked entries
To keep consistency inside transactions started by locking an entry or
an inode, this change delays the removal of entries that are currently
locked by one or more clients. Once all locks are released, the removal
is processed.
It has also been improved the detection of stale inodes in the locking
code of EC.
Fixes: #990
Change-Id: Ic8ba23d9480f80c7f74e7a310bf8a15922320fd5
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 410bf4f33521d3494c0678f8bdb0aa13fb7b3e13
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sun Apr 12 08:09:10 2020 +0530
glusterd: migrating remove-brick commands to mgmt v3 framework
Currently remove-brick commands follow sync-op framework. For code
extensibility (like, adding more phases in the trnasaction) we are
migrating the command to mgmt v3 framework.
fixes: #1164
Change-Id: I5d363223d6f9dc7a70b61adb9d3a5250e84a71b4
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit ed82fde357276dac97b8398fbf7cae41707f4dfb
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jun 11 06:46:56 2020 -0400
packaging: refactor to align with common practices
Apparently some sdditional Obsoletes: are required
Change-Id: I919ae5a0fcc6f720e3eab4784af36977b9eef044
Fixes: #1126
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 26bb3f0b23a561e7f0311326893e18dd99845793
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed May 27 20:50:46 2020 +0530
afr: more quorum checks in lookup and new entry marking
Problem: See github issue for details.
Fix:
-In lookup if the entry exists in 2 out of 3 bricks, don't fail the
lookup with ENOENT just because there is an entrylk on the parent.
Consider quorum before deciding.
-If entry FOP does not succeed on quorum no. of bricks, do not perform
new entry mark.
Fixes: #1303
Change-Id: I56df8c89ad53b29fa450c7930a7b7ccec9f4a6c5
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 00d5a4bd193c24f1a9b4e230b59d52388fd8d747
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon May 4 14:30:57 2020 +0530
extras: Modify group 'virt' to include network-related options
This is needed to work around an issue seen where vms running on
online hosts are getting killed when a different host is rebooted
in ovirt-gluster hyperconverged environments. Actual RCA is quite
lengthy and documented in the github issue. Please refer to it
for more details.
Change-Id: Ic25b5f50144ad42458e5c847e1e7e191032396c1
Fixes: #1217
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 8cb23ee277c9bfd9d002ba657b88d8c2178fd0b5
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Mar 12 08:20:31 2020 +0100
Indicate timezone offsets in timestamps
Logs and other output carrying timestamps
will have now timezone offsets indicated, eg.:
[2020-03-12 07:01:05.584482 +0000] I [MSGID: 106143] [glusterd-pmap.c:388:pmap_registry_remove] 0-pmap: removing brick (null) on port 49153
To this end,
- gf_time_fmt() now inserts timezone offset via %z strftime(3) template.
- A new utility function has been added, gf_time_fmt_tv(), that
takes a struct timeval pointer (*tv) instead of a time_t value to
specify the time. If tv->tv_usec is negative,
gf_time_fmt_tv(... tv ...)
is equivalent to
gf_time_fmt(... tv->tv_sec ...)
Otherwise it also inserts tv->tv_usec to the formatted string.
- Building timestamps of usec precision has been converted to
gf_time_fmt_tv, which is necessary because the method of appending
a period and the usec value to the end of the timestamp does not work
if the timestamp has zone offset, but it's also beneficial in terms of
eliminating repetition.
- The buffer passed to gf_time_fmt/gf_time_fmt_tv has been unified to
be of GF_TIMESTR_SIZE size (256). We need slightly larger buffer space
to accommodate the zone offset and it's preferable to use a buffer
which is undisputedly large enough.
This change does *not* do the following:
- Retaining a method of timestamp creation without timezone offset.
As to my understanding we don't need such backward compatibility
as the code just emits timestamps to logs and other diagnostic
texts, and doesn't do any later processing on them that would rely
on their format. An exception to this, ie. a case where timestamp
is built for internal use, is graph.c:fill_uuid(). As far as I can
see, what matters in that case is the uniqueness of the produced
string, not the format.
- Implementing a single-token (space free) timestamp format.
While some timestamp formats used to be single-token, now all of
them will include a space preceding the offset indicator. Again,
I did not see a use case where this could be significant in terms
of representation.
- Moving the codebase to a single unified timestamp format and
dropping the fmt argument of gf_time_fmt/gf_time_fmt_tv.
While the gf_timefmt_FT format is almost ubiquitous, there are
a few cases where different formats are used. I'm not convinced
there is any reason to not use gf_timefmt_FT in those cases too,
but I did not want to make a decision in this regard.
Change-Id: I0af73ab5d490cca7ed8d07a2ce7ac22a6df2920a
Updates: #837
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 5d042a6bd19a0f49db47f2685363adcbacc054d8
Author: Vinayakswami Hariharmath <vharihar@redhat.com>
Date: Wed Jun 3 18:58:56 2020 +0530
features/shard: Use fd lookup post file open
Issue:
When a process has the open fd and the same file is
unlinked in middle of the operations, then file based
lookup fails with ENOENT or stale file
Solution:
When the file already open and fd is available, use fstat
to get the file attributes
Change-Id: I0e83aee9f11b616dcfe13769ebfcda6742e4e0f4
Fixes: #1281
Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
commit 166afdd8cb6901362a0e8d2f1954060483d9c54b
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri Jun 5 12:51:28 2020 +0300
libglusterfs: fix use-after-destroy mutex error
Found with GCC ThreadSanitizer:
WARNING: ThreadSanitizer: use of an invalid mutex (e.g. uninitialized or destroyed) (pid=188590)
#0 pthread_mutex_lock <null> (libtsan.so.0+0x528ac)
#1 client_ctx_del /path/to/glusterfs/libglusterfs/src/client_t.c:535 (libglusterfs.so.0+0xc681a)
#2 client_destroy_cbk /path/to/glusterfs/xlators/protocol/server/src/server.c:944 (server.so+0xaf6e)
#3 gf_client_destroy_recursive /path/to/glusterfs/libglusterfs/src/client_t.c:295 (libglusterfs.so.0+0xc5058)
#4 client_destroy /path/to/glusterfs/libglusterfs/src/client_t.c:330 (libglusterfs.so.0+0xc60e4)
...
Location is heap block of size 272 at 0x7b440001a180 allocated by thread T7:
#0 calloc <null> (libtsan.so.0+0x3075a)
#1 __gf_calloc /path/to/glusterfs/libglusterfs/src/mem-pool.c:151 (libglusterfs.so.0+0x6e42b)
#2 gf_client_get /path/to/glusterfs/libglusterfs/src/client_t.c:155 (libglusterfs.so.0+0xc571a)
...
The problem is that client_destroy() may call client_ctx_del() (which attempts to lock
'sratch_ctx.lock') via recursive deletion from gf_client_destroy_recursive(), so
destroying mutex before entering recursive deletion is an error. It should be destroyed
later - just before the client context is freed.
Change-Id: I730a628714d2b404e3f019ae552403da16b51b68
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1285
commit 91c99f46ba8a5fca54660cb39879abbd84654352
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue Jun 9 15:57:28 2020 +0300
glusterd: destroy all volume info locks and mutexes
Add destroy calls for 'store_volinfo_lock' and 'lock' of volume info.
Move initialization of 'store_volinfo_lock' from glusterd_op_create_volume()
to common place, which is glusterd_volinfo_new() indeed.
Change-Id: I5fae4469f28eab80c4fa6f5947646528e6aedad7
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1291
commit 58d0e43ee0b273ceec540b54825b509fb5ea7c8b
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue Jun 2 12:28:17 2020 +0300
cli: fix several signed integer overflows and format specifiers
Initially found with GCC UBsan:
cli/src/cli-rpc-ops.c:5347:73: runtime error: left shift of 1 by 31
places cannot be represented in type 'int'
cli/src/cli-rpc-ops.c:5355:74: runtime error: left shift of 1 by 31
places cannot be represented in type 'int'
Ditto in cli/src/cli-xml-output.c.
Change-Id: I14ed51d06dafe5039f154b0c4edf25a0997d696e
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1279
commit 372881377ccef2dd34412ae9c70f3d3ab1aa60c5
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Jun 9 15:38:12 2020 +0530
test: Test case brick-mux-validation-in-cluster.t is failing on RHEL-8
Brick process are not properly attached on any cluster node while
some volume options are changed on peer node and glusterd is down on
that specific node.
Solution: At the time of restart glusterd it got a friend update request
from a peer node if peer node having some changes on volume.If the brick
process is started before received a friend update request in that case
brick_mux behavior is not workingproperly. All bricks are attached to
the same process even volumes options are not the same. To avoid the
issue introduce an atomic flag volpeerupdate and update the value while
glusterd has received a friend update request from peer for a specific
volume.If volpeerupdate flag is 1 volume is started by
glusterd_import_friend_volume synctask
Change-Id: I4c026f1e7807ded249153670e6967a2be8d22cb7
Credit: Sanju Rakaonde <srakonde@redhat.com>
fixes: #1290
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 24781bf6a57f4d15fb09c1744f2f0813444bc881
Author: yinkui <13965432176@163.com>
Date: Fri Jun 28 13:57:30 2019 +0800
glusterd: To do full heal in different online node when do ec/afr full heal
For example:
We have 3 nodes and create ec 3*(2+1) volume for
test-disperse-0/test-disperse-1/test-disperse-2 when we do
'gluster v heal test full' in node-1 that can in node-1/
node-2/node-3 glustershd's get op=GF_EVENT_TRANSLATOR_OP
and then do full heal in different disperse group.
Let us say we have 2X(2+1) disperse with each brick
from different machine m0, m1, m2, m3, m4, m5. and candidate_max is m5.
and do full heal so '*index' is 3 and !gf_uuid_compare(MY_UUID, brickinfo->uuid)
will be true in m3,and then m3's glustershd will be the heal-xlator.
Id: I5c6762e6cfb375aed32d3fc11fe5eae3ee41aab4
Signed-off-by: yinkui <13965432176@163.com>
Change-Id: Ic7ef3ddfd30b5f4714ba99b4e7b708c927d68764
fixes: bz#1724948
commit cf1bfb2cb2a2674f7288f0413ee1823139feda24
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu May 14 06:47:17 2020 -0400
packaging: refactor to align with common practices
The claim that Fedora package guidelines do not require this
scheme is a non-argument. Not only do they not require it, they
don't prohibit it either. (And you can't prove a negative. It's
a specious argument.)
Change-Id: I7748c7531d52dedd71b3a7f5df049742258a6aba
Fixes: #1126
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit f874daa317a4717f34a67e93cfda309bf2d0883f
Author: Florian Smeets <flo@FreeBSD.org>
Date: Sun May 31 16:20:20 2020 +0200
Make glusterfs compile on all recent and supported FreeBSD releases.
I'm currently trying to update the FreeBSD port of glusterfs from 3.11 to
7.6. With this change I was able to compile everything again on 11.3,
11.4RC1, 12.1 and 13 (head)
Change-Id: I867fa51e931f7ef486529eecb58d903d2d23f79a
Fixes: #1275
Signed-off-by: Florian Smeets <flo@FreeBSD.org>
commit ca401fcb5ea4736b1cdc547eb53edf80276761bc
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue May 19 16:06:43 2020 +0300
libglusterfs: drop useless 'const' on function return type
Using 'const' qualifier on function return type makes no effect in
ISO C, as reported with -Wignored-qualifiers of gcc-10 and clang-10.
Change-Id: I83de7ab4c8255284683bb462cd9f584ebf0f983b
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1249
commit 579aaddc3a1554bc787542e88d1d2cd815502f3a
Author: Tamar Shacked <tshacked@redhat.com>
Date: Thu Jun 4 11:35:30 2020 +0300
When creating new file don't set xatrr "trusted.glusterfs.dht"
The curr call to delete the xattr from the dict fails to find the key: dict_del_sizen(xdata, xattr_name);
This is beacuse keysize is calculated as sizeof of xattr_name which is a pointer, this lead to wrong size -> hash.
Fix: call to dict_deln which get keysize using strlen.
fixes: #1282
Change-Id: I23ce1f8f7928e9daa43bc3a9fa8d3611e81bbc36
Signed-off-by: Tamar Shacked <tshacked@redhat.com>
commit bd540db1e7fa8f4beb13d0a7cd1d426f48a37ba4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 29 14:24:53 2020 +0530
cluster/afr: Delay post-op for fsync
Problem:
AFR doesn't delay post-op for fsync fop. For fsync heavy workloads
this leads to un-necessary fxattrop/finodelk for every fsync leading
to bad performance.
Fix:
Have delayed post-op for fsync. Add special flag in xdata to indicate
that afr shouldn't delay post-op in cases where either the
process will terminate or graph-switch would happen. Otherwise it leads
to un-necessary heals when the graph-switch/process-termination
happens before delayed-post-op completes.
Fixes: #1253
Change-Id: I531940d13269a111c49e0510d49514dc169f4577
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 481a70319ab9000c47a8af44c9b0f84695c7e93b
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Wed Nov 20 12:42:12 2019 +0530
glusterd: check for same node while adding bricks in disperse volume
The optimal way for configuring disperse and replicate volumes
is to have all bricks in different nodes.
During create operation it fails saying it is not optimal, user
must use force to over-ride this behavior. Implementing same
during add-brick operation to avoid situation where all the added
bricks end up from same host. Operation will error out accordingly.
and this can be over-ridden by using force same as create.
fixes: #1047
Change-Id: I3ee9c97c1a14b73f4532893bc00187ef9355238b
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 56ff1f220f218c55f9e22b3b0715d8c5205c7684
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Tue May 26 15:26:24 2020 +0300
glusterd: fix memory leak in glusterd_store_retrieve_bricks()
Found with GCC's address sanitizer:
==67190==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 24624 byte(s) in 6 object(s) allocated from:
#0 0x7f62535c0837 in __interceptor_calloc (/usr/lib64/libasan.so.6+0xb0837)
#1 0x7f62532a1690 in __gf_default_calloc glusterfs/mem-pool.h:122
#2 0x7f62532a20ca in __gf_calloc /path/to/glusterfs/libglusterfs/src/mem-pool.c:144
#3 0x7f62532c8128 in gf_store_iter_new /path/to/glusterfs/libglusterfs/src/store.c:511
#4 0x7f623e2f9ed7 in glusterd_store_retrieve_bricks /path/to/glusterfs/xlators/mgmt/glusterd/src/glusterd-store.c:2389
Direct leak of 8208 byte(s) in 2 object(s) allocated from:
#0 0x7f62535c0837 in __interceptor_calloc (/usr/lib64/libasan.so.6+0xb0837)
#1 0x7f62532a1690 in __gf_default_calloc glusterfs/mem-pool.h:122
#2 0x7f62532a20ca in __gf_calloc /path/to/glusterfs/libglusterfs/src/mem-pool.c:144
#3 0x7f62532c8128 in gf_store_iter_new /path/to/glusterfs/libglusterfs/src/store.c:511
#4 0x7f623e2f9cf0 in glusterd_store_retrieve_bricks /path/to/glusterfs/xlators/mgmt/glusterd/src/glusterd-store.c:2363
#5 0x7fff5cb70bcf ([stack]+0x15bcf)
#6 0x7f623e309113 in glusterd_store_retrieve_volumes /path/to/glusterfs/xlators/mgmt/glusterd/src/glusterd-store.c:3505
#7 0xfffeb96e61d (<unknown module>)
#8 0x7f623e4586d7 (/usr/lib64/glusterfs/9dev/xlator/mgmt/glusterd.so+0x2f86d7)
Change-Id: I9b2a543dc095f4fa739cd664fd4d608bf8c87d60
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1263
commit e2235217a1a76ffad8b6b2f445dc081570e72cf6
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu May 21 15:18:59 2020 +0530
cluster/afr: Prioritize ENOSPC over other errors
Problem:
In a replicate/arbiter volume if file creations or writes fails on
quorum number of bricks and on one brick it is due to ENOSPC and
on other brick it fails for a different reason, it may fail with
errors other than ENOSPC in some cases.
Fix:
Prioritize ENOSPC over other lesser priority errors and do not set
op_errno in posix_gfid_set if op_ret is 0 to avoid receiving any
error_no which can be misinterpreted by __afr_dir_write_finalize().
Also removing the function afr_has_arbiter_fop_cbk_quorum() which
might consider a successful reply form a single brick as quorum
success in some cases, whereas we always need fop to be successful
on quorum number of bricks in arbiter configuration.
Change-Id: I106e267f8b9451f681022f1cccb410d9bc824c08
Fixes: #1254
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit db9538870666ccdb5d5c4a508872d37318905f20
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue May 12 23:54:54 2020 +0200
open-behind: rewrite of internal logic
There was a critical flaw in the previous implementation of open-behind.
When an open is done in the background, it's necessary to take a
reference on the fd_t object because once we "fake" the open answer,
the fd could be destroyed. However as long as there's a reference,
the release function won't be called. So, if the application closes
the file descriptor without having actually opened it, there will
always remain at least 1 reference, causing a leak.
To avoid this problem, the previous implementation didn't take a
reference on the fd_t, so there were races where the fd could be
destroyed while it was still in use.
To fix this, I've implemented a new xlator cbk that gets called from
fuse when the application closes a file descriptor.
The whole logic of handling background opens have been simplified and
it's more efficient now. Only if the fop needs to be delayed until an
open completes, a stub is created. Otherwise no memory allocations are
needed.
Correctly handling the close request while the open is still pending
has added a bit of complexity, but overall normal operation is simpler.
Change-Id: I6376a5491368e0e1c283cc452849032636261592
Fixes: #1225
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 024152a1476b4073cf1a63f8eb377713db712414
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri May 22 15:06:57 2020 +0300
rpc, gf_attach: add minimal proper synchronization
Implement minimal proper synchronization between gf_attach
and underlying RPC layer using convenient POSIX primitives.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1260
Change-Id: Ib5130b586a8b65ed5cf5f9156c111b161570224b
commit 255408094b2b57ed24fefc3f25785e354a403279
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Apr 21 23:55:46 2020 +0200
meta: indicate writability of tunables in file mode
All files under .meta (synthetic subtree facilitating
reflection for glusterfs clients, implemented by meta
xlator) were shown as writable, but the vast majority of
them are usable only for querying parameters or stats, not
for setting them. (The exceptions are loglevel and
measure_latency.)
However, one could only find out about this only by trial
and error, or reading the code.
With this change we align file permissions with
tunability, stripping the writable bits for those nodes
which are only for querying.
Also strip writable bits from directory permissions.
updates: #1000
Change-Id: I82954e165ffc31cdf7307f4d990ef60b8154a2e2
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit f8bae595a6aacd15076c6e4f17f73eaf25622ca8
Author: Ritesh Chikatwar <rchikatw@redhat.com>
Date: Mon May 11 18:20:48 2020 +0530
events: fix python3 compatibility As there is no "unicode" in py3 so removing it.
Problem: vdsm-client command failing below traceback
[root@dhcp35-179 ~]# cat <<EOF | vdsm-client --gluster-enabled -f - GlusterEvent webhookUpdate
{
"url": "https://mail.google.com/mail/u/1/#inbox",
"bearerToken": "ritesh"
}
EOF
vdsm-client: Command GlusterEvent.webhookUpdate with args
{'url': 'https://mail.google.com/mail/u/1/#inbox', 'bearerToken': 'ritesh'} failed:
(code=4752, message=Failed to update webhook: rc=1 out=()
err=b'Traceback (most recent call last): File "/sbin/gluster-eventsapi", line 673,
in <module> runcli()
File "/usr/lib/python3.6/site-packages/gluster/cliutils/cliutils.py", line 232,
in runcli cls.run(args)\n
File "/sbin/gluster-eventsapi", line 357,
in run
isinstance(data[args.url], unicode):NameError: name \'unicode\' is not defined')
Solution:
In py3 str can hold unicode string.
Change-Id: I3dc59df8b812f236380d2d57cfcf8e3aba91e582
Fixes: #1226
Signed-off-by: Ritesh Chikatwar <rchikatw@redhat.com>
commit 07bb13291fbb92632d01d8c215b93e31ec9ae313
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Tue May 19 14:05:24 2020 +0300
fuse - remove unnecessary code block
Per a "TODO" comment in the code, a code block can be removed as it's no
longer required
Change-Id: I60e064ece985ff2ea2a686bbd2f0e6cc850899e9
updates: #1000
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit ed5a49cbde9e56a4ab5dc47ad0a5284d23455729
Author: Csaba Henk <csaba@redhat.com>
Date: Thu May 14 17:46:09 2020 +0200
io-cache,quick-read: deprecate volume options with flawed semantics or naming
- performance.cache-size has a flawed semantics, as it's
dispatched on two independent translators, io-cache
and quick-read.
- performance.qr-cache-timeout has a confusing name, as
other options affecting quick-read have an unabbreviated
"quick-read-..." prefix in their names.
We keep these options with unchanged operation, but in the
help output we indicate their deprecation.
The following better alternatives are introduced:
- performance.io-cache-size to tune cache-size option of io-cache
- performance.quick-read-cache-size to tune cache-size option of
quick-read
- performance.quick-read-cache-timeout as a preferred synonym for
performance.qr-cache-timeout
Fixes: #952
Change-Id: Ibd04fb638de8cac450ba992ad8a415154f9f4281
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 7334b233ae7358eb08b6610024c3089c9e36aab3
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Mon Jun 1 15:32:23 2020 +0300
afr: fix memory leak in afr_priv_destroy()
Found with GCC ASan:
Direct leak of 202 byte(s) in 2 object(s) allocated from:
#0 0x7fc6c6ef0667 in __interceptor_malloc (/usr/lib64/libasan.so.6+0xb0667)
#1 0x7fc6c6bd145b in __gf_malloc /path/to/glusterfs/libglusterfs/src/mem-pool.c:175
#2 0x7fc6c6bd17a3 in gf_vasprintf /path/to/glusterfs/libglusterfs/src/mem-pool.c:223
#3 0x7fc6c6bd1993 in gf_asprintf /path/to/glusterfs/libglusterfs/src/mem-pool.c:243
#4 0x7fc6b0dc92f6 in init /path/to/glusterfs/xlators/cluster/afr/src/afr.c:590
...
Change-Id: I29feb1d30a045fb70472758e6ed4e195888090b2
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1278
commit 1bd5c47f3176b9251bdc0c1d8050cb8edf12afe3
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Wed May 6 13:28:40 2020 +0300
dht - sparse files rebalance enhancements
Currently data migration in rebalance reads sparse file sequentially,
disregarding which segments are holes and which are data. This can lead
to extremely long migration time for large sparse file.
Data migration mechanism needs to be enhanced so only data segments are
read and migrated. This can be achieved using lseek to seek for holes
and data in the file.
This enhancement is a consequence of
https://bugzilla.redhat.com/show_bug.cgi?id=1823703
fixes: #1222
Change-Id: If5f448a0c532926464e1f34f504c5c94749b08c3
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 7e0d3eb61a49d57595cd78035d57805e00a929b4
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri May 22 11:27:29 2020 +0300
cli: fix memory leak in gf_cli_gsync_status_output()
In gf_cli_gsync_status_output(), call to gf_cli_read_status_data()
overwrites 'sts_vals' pointers to areas allocated by GF_CALLOC()
with pointers to dict data, thus making the allocated areas not
accessible.
Change-Id: I00c310aec1a1413caf13ade14dc4fed37b51962c
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1259
commit 3f2d80cfe1b110d89d4126c5bd9e6bb7f4661798
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu May 28 08:26:47 2020 -0400
common-ha: ganesha-ha.sh bad test for {rhel,centos} for pcs options
bash [[ ... =~ ... ]] built-in returns _0_ when the regex matches,
not 1, thus the sense of the test is backwards and never correctly
detects rhel or centos.
Change-Id: Ic9e60aae4ea38aff8f13979080995e60621a68fe
Fixes: #1269
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 8ea71cc6ac2090fd6169fbd6c27b6c2250f18103
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri May 22 13:25:26 2020 +0530
features/shard: Aggregate file size, block-count before unwinding removexattr
Posix translator returns pre and postbufs in the dict in {F}REMOVEXATTR fops.
These iatts are further cached at layers like md-cache.
Shard translator, in its current state, simply returns these values without
updating the aggregated file size and block-count.
This patch fixes this problem.
Change-Id: I4b2dd41ede472c5829af80a67401ec5a6376d872
Fixes: #1243
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 56f2edf8f3b14ce518e27f863702c54bbd0ebc07
Author: Susant Palai <spalai@redhat.com>
Date: Fri May 22 13:47:14 2020 +0530
dht: add null check in gf_defrag_free_dir_dfmeta
fixes: #1258
Change-Id: I9d1fb512072bcc540d21d47da5b15ae1b79cf2b8
Signed-off-by: Susant Palai <spalai@redhat.com>
commit ffb0197cd35012feeff2e79428433e4ce82a7683
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Apr 28 11:31:17 2020 +0530
afr/changelog: fix NULL dereferences and error handling
This patch includes the following CID from Coverity Scan:
*1419116
*1420206
Change-Id: Id92fd6a78c8a00726a61aa4697b5c126ced8ed4d
Updates: #1202
commit 28c2e91c4f20985db7923e291c11e741746e6576
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Jan 2 10:23:52 2020 +0530
socket: Use AES128 cipher in SSL if AES is supported by CPU
SSL performance is improved after configuring AES128 cipher
so use AES128 cipher as a default cipher on the CPU those
enabled AES bits otherwise ssl use AES256 cipher
Change-Id: I91c50fe987cbb22ed76f8012094730c592c63506
Fixes: #1050
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 6a055bde4ae0dcd90461e972bcc4e0ab6df25a63
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu May 21 16:04:33 2020 +0530
glusterd/snapshot: Improve log message during snapshot clone
While taking a snapshot clone, if the snapshot is not activated,
th cli was returning that the bricks are down.
This patch clearly print tha the error is due to the snapshot
state.
Change-Id: Ia840e6e071342e061ad38bf15e2e2ff2b0dacdfa
Fixes: #1255
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit ae5801e2cd5564e3d4317ce12b39369e2ed3caf8
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri May 15 11:29:36 2020 +0530
features/shard: Aggregate size, block-count in iatt before unwinding setxattr
Posix translator returns pre and postbufs in the dict in {F}SETXATTR fops.
These iatts are further cached at layers like md-cache.
Shard translator, in its current state, simply returns these values without
updating the aggregated file size and block-count.
This patch fixes this problem.
Change-Id: I4da0eceb4235b91546df79270bcc0af8cd64e9ea
Fixes: #1243
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 5c9b893efb1b9ff0d30a048d4e45c0a0ae4e1372
Author: Csaba Henk <csaba@redhat.com>
Date: Fri May 8 23:01:04 2020 +0200
fuse: occasional logging for fuse device 'weird' write errors
This change is a followup to
I510158843e4b1d482bdc496c2e97b1860dc1ba93.
In referred change we pushed log messages about 'weird'
write errors to fuse device out of sight, by reporting
them at Debug loglevel instead of Error (where
'weird' means errno is not POSIX compliant but having
meaningful semantics for FUSE protocol).
This solved the issue of spurious error reporting.
And so far so good: these messages don't indicate
an error condition by themselves. However, when they
come in high repetitions, that indicates a suboptimal
condition which should be reported.[1]
Therefore now we shall emit a Warning if a certain
errno occurs a certain number of times[2] as the
outcome of a write to the fuse device.
___
[1] typically ENOENTs and ENOTDIRs accumulate
when glusterfs' inode invalidation lags behind
the kernel's internal inode garbage collection
(in this case above errnos mean that the inode
which we requested to be invalidated is not found
in kernel). This can be mitigated with the
invalidate-limit command line / mount option,
cf. bz#1732717.
[2] 256, as of the current implementation.
Change-Id: I8cc7fe104da43a88875f93b0db49d5677cc16045
Updates: #1000
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 3af2f3eda95fa9ce2825db425f0787c796b2c7de
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu May 21 08:26:11 2020 +0200
glusterd: add missing synccond_broadcast()
After the changes in commit 3da22f8cb08b05562a4c6bd2694f2f19199cff7f,
there was a place where synccond_broadcast() was missing. It could
cause a hang if another synctask was waiting on the condition variable.
Change-Id: I92bfe4e15c5c3591e4854a64aa9e1566d50dd204
Fixes: #1116
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit e73750d337f687da6c66250bf40d6a1c8f48ff11
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Mon May 18 18:49:19 2020 +0300
storage/posix: fix thread name to comply with common convention
Rename disk space checking thread to comply with
common convention, adjust related docs as well.
Change-Id: I36d642cf09773a28abd95bbe337ce29134ad96a4
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1248
commit 1434530e545931a88b4f62f11ed0d87fdc49b820
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Wed May 6 08:29:48 2020 +0300
features/bit-rot: invalid snprintf() buffer size
Found with clang-10 -Wfortify-source:
bit-rot-scrub.c:1802:15: warning: 'snprintf' size argument is too large;
destination buffer has size 32, but size argument is 4096 [-Wfortify-source]
len = snprintf(key, PATH_MAX, "quarantine-%d", j);
^
bit-rot-scrub.c:1813:9: warning: 'snprintf' size argument is too large;
destination buffer has size 32, but size argument is 4096 [-Wfortify-source]
snprintf(main_key, PATH_MAX, "quarantine-%d", tmp_count);
Change-Id: I9b9c09ef2223ed181d81215154345de976b82f13
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1221
commit 2057ee71cdb0d3d6e031306e53a16dea5cd801d7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 13 21:53:23 2020 +0530
mgmt/glusterd: Stop old shd before increasing replica count
Problem:
In add-brick that increases replica count
SHD was restarted after pending xattrs are set on the new bricks and
adding bricks. But before restarting SHD there is a possibility that
old SHD would do a scan on root-directory see no heal is needed and
delete index for root-dir leading to no heals until lookup is executed
on the mount
Fix:
Stop shd, perform pending-xattr setting/adding new bricks and
then restart shd
Fixes: #1240
Change-Id: I94fd7c6c909211b597185dfe097a559db6c0d00f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 1d23a3b4857d4561f2abeb67bdabaf3e1ee5f092
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat May 16 08:58:26 2020 +0530
MAINTAINERS: Add Raghavendra Gowdappa to Past contributors
updates: #1000
Change-Id: I2840ef1909cb0b4ae3d0f7fbaf11cfc9b8c0831f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 53d823e7ad1ed0db11f68adbbeab0343b031f6c0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 15 07:11:06 2020 +0530
tests: Disable client-heals
Problem:
ok 32 [ 11/ 9] < 46> 'gf_rm_file_and_gfid_link /d/backends/patchy0 del-file'
not ok 33 [ 13/ 131] < 48> '! dd if=/dev/zero of=/mnt/glusterfs/0/del-file bs=1M count=1 oflag=direct' -> ''
The assumption in the test above is that the file wouldn't exist when dd
happens. But heal can lead to creation of the file in some cases leading to
spurious failures.
Fix:
Disable client side heal.
Fixes: #1245
Change-Id: I96b2b45528f9dfb3199d503a467cafafba9b387f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 473bf33508bf65a16314a4e60e4f8cc3bfda9121
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 11 10:26:56 2020 +0530
Fix ./tests/basic/fencing/afr-lock-heal-basic.t failure
In brick-mux tests, all bricks of the volume have same pid.
"generate_brick_statedump" cleans up the older statedumps
with same brick pid. So successive calls to this function
will delete previous brick's statedump as all bricks share
same pid. So grep calls to the statedump were failing leading
to failure of the .t
To fix this, stored the result we need from statedump before calling
next brick's statedump
Fixes: #1234
Change-Id: I824ed4dff79e7242b3e980364836b9af0e87a6ee
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 6f79c28cf04349bec91886164ee218e5aa5de1e5
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Apr 30 11:19:01 2020 +0200
syncop: improve scaling and implement more tools
The current scaling of the syncop thread pool is not working properly
and can leave some tasks in the run queue more time than necessary
when the maximum number of threads is not reached.
This patch provides a better scaling condition to react faster to
pending work.
Condition variables and sleep in the context of a synctask have also
been implemented. Their purpose is to replace regular condition
variables and sleeps that block synctask threads and prevent other
tasks to be executed.
The new features have been applied to several places in glusterd.
Change-Id: Ic50b7c73c104f9e41f08101a357d30b95efccfbf
Fixes: #1116
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 65943bf2001cd09e47bb0908f822c46fd5839bf1
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon May 11 10:02:08 2020 +0100
build: geo-rep sub-pkg requires policycoreutils-python-utils on rhel8
glusterfs-geo-replication sub-package requires policycoreutils-python-utilson rhel8 to set relevant selinux boolean to allow rsync.
Change-Id: Ia0fdcfdd8c7d18cd194e011f6b365bf5cb70a20a
Fixes: #1236
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit e734ea43411e2bdc887104c8bf36cf231b5e15ed
Author: Susant Palai <spalai@redhat.com>
Date: Mon May 4 19:09:00 2020 +0530
dht: Do opendir selectively in gf_defrag_process_dir
Currently opendir is done from the cluster view. Hence, even if
one opendir is successful, the opendir operation as a whole is considered
successful.
But since in gf_defrag_get_entry we fetch entries selectively from
local_subvols, we need to opendir individually on those local subvols
and keep track of fds separately. Otherwise it is possible that opendir
failed on one of the subvol and we wind readdirp call on the fd to the
corresponding subvol, which will ultimately result in EINVAL error.
fixes: #1218
Change-Id: I50dd88b9597852a15579f4ee325918979417f570
Signed-off-by: Susant Palai <spalai@redhat.com>
commit ba5e847501b5da30913d153fbf3beb89f6af03c3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat May 9 09:27:20 2020 +0530
debug/error-gen: Don't return EBADF for loc fops
The following crash happens when EBADF is returned
for some of the loc operations. EBADF should be returned only
for fd based fops
(data=0x7ff1700606e8) at
/home/jenkins/root/workspace/centos7-regression/xlators/cluster/dht/src/dht-helper.c:502
loc = {path = 0x0, name = 0x0, inode = 0x0, parent = 0x0, gfid = '\000'
<repeats 15 times>, pargfid = '\000' <repeats 15 times>}
ret = -1
frame = 0x7ff1700606e8
local = 0x7ff170049208
fd = 0x0
this = 0x7ff17c01d720
subvol = 0x7ff17c0197f0
__FUNCTION__ = "dht_check_and_open_fd_on_subvol_task"
/home/jenkins/root/workspace/centos7-regression/libglusterfs/src/syncop.c:279
task = 0x7ff17c0b4920
Fixes: #1230
Change-Id: I24c11a8820a3c8b4070127e69c520e2c61e70930
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit be95e0e49f7d78157c45e8c899afba13e124f41e
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue May 5 18:17:49 2020 +0530
cluster/ec: Return correct error code and log message
In case of readdir was send with an FD on which opendir
was failed, this FD will be useless and we return it with error.
For now, we are returning it with EINVAL without logging any
message in log file.
Return a correct error code and also log the message to improve thing to debug.
fixes: #1220
Change-Id: Iaf035254b9c5aa52fa43ace72d328be622b06169
commit 4579245e5374f461702a0a49da7d41e0465e42bb
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Thu May 7 18:57:37 2020 +0300
posix - fix seek functionality
A wrong pointer check causes the offset returned by seek to be always
wrong
fixes: #1228
Change-Id: Iac4c6a163175617ac4f14544fc6b7c6fb4041cd6
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 2ef4392799d47ddcd80f8f485fa0461dca5fd535
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 6 17:36:20 2020 +0530
tests: skip tests on absence of reflink in xfs
Fixes: #1223
Change-Id: I36cb72d920ffd77405051546615c5262c392daef
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 84b07b42a954304e83b20468365b20b4a1206c92
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon May 4 09:11:03 2020 -0400
common-ha: cluster status shows "FAILOVER" when actually HEALTHY
pacemaker devs change the format of the ouput of `pcs status`
Expected to find a line in the format:
Online: ....
but now it's
* Online: ...
And the `grep -E "^Online:" no longer finds the list of nodes that
are online.
Also other lines now have '*' in first few characters of the line
throwing off `grep -x ...`
Change-Id: Ia04a89e76914f2a455a755f0a93fa415f60aefd0
Fixes: #1169
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit aca7961dae0f6d5444c1db5897677eb8a2b518f4
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Wed Apr 15 15:03:03 2020 +0300
core, cli, quota: cleanup malloc debugging and stats
1. Since mcheck()/mprobe() etc. features are no longer used,
mcheck.h isn't required to be included.
2. Since mallinfo() is used to obtain malloc statistics,
it should be detected instead of malloc_stats().
Change-Id: I54c7d2ee568e06ab29938efc01d1a2153c5bd5db
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: #1172
commit 7cef8f1fd1cfdb9472a53ac1a5309ec5fbc19734
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun May 3 09:59:41 2020 +0530
cluster/dht: Don't access local after STACK_DESTROY
There is a possibility that 'frame' could have been
destroyed in dht_selfheal_dir_setattr() which can
lead to local->mds_heal_fresh_lookup showing junk
non-zero number. That will lead to double
STACK_DESTROY. Remembered the value of the variable
before the call to fix the access.
Fixes: #1214
Change-Id: I37d1657798bfb549bb3887e260484d58fff42c91
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 9f3783034a3dd11b04e53b1994595eed05cb5d34
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Apr 24 15:17:12 2020 +0100
test: improve geo-rep non root test
Make sure bricks are up before mounting volume.
Also made sure that mount is available before creating test data.
Change-Id: I4915b837df46e43be5678dac8ae5602021c52685
Updates: #1197
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit d4ca408066353f36b86ed8cf5ab518c77f5a080e
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Wed Apr 29 10:47:31 2020 +0300
cluster/ec: Fix varargs warning reported with clang-10
Found with clang-10 -Wvarargs:
xlators/cluster/ec/src/ec-combine.c:360:20: warning: passing an object that undergoes
default argument promotion to 'va_start' has undefined behavior [-Wvarargs]
va_start(args, global);
^
xlators/cluster/ec/src/ec-combine.c:348:34: note: parameter of type 'bool' is declared here
gf_boolean_t global, ...)
According to The C11 Standard, 7.16.1.4p4:
If the parameter parmN is declared with the register storage class, with a function
or array type, or with a type that is not compatible with the type that results after
application of the default argument promotions, the behavior is undefined.
Fixes: #1207
Change-Id: I527527845b2d574000d736c278be87cf19504761
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
commit 28603988321f14cccb4a31630df9bb39fc11429c
Author: Charles Celerier <charles@chckyn.org>
Date: Thu Apr 23 08:25:13 2020 -0700
Use already expanded SYSCONF_DIR in glusterd.service instead of sysconfdir
The generated glusterd.service file included the Automake artifact
`${prefix}` in the EnvironmentFile definition. When an actual value for
`${prefix}` is specified by Automake, this is not properly passed on
to glusterd.service's EnvironmentFile variable since `${prefix}` will
not be expanded once it is no longer in the control of Automake.
Because this artifact was left by the sysconfdir variable, we substitute
it with the SYSCONF_DIR variable that configure.ac expands earlier.
Change-Id: I980b27590c15facb567b153bd57078fed320ff87
Updates: #1135
Signed-off-by: Charles Celerier <charles@chckyn.org>
commit 337b0e51f74940daee105f291b1410dbfb7a07b7
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Wed Apr 29 12:16:04 2020 +0300
storage/posix: fix initialization warning reported with clang-10
xlators/storage/posix/src/posix-common.c:1440:18: warning: initializer overrides prior
initialization of this subobject [-Winitializer-overrides]
.validate = GF_OPT_VALIDATE_MAX,
^~~~~~~~~~~~~~~~~~~
xlators/storage/posix/src/posix-common.c:1439:18: note: previous initialization is here
.validate = GF_OPT_VALIDATE_MIN,
^~~~~~~~~~~~~~~~~~~
[4 times]
Use GF_OPT_VALIDATE_BOTH for min/max-bounded values.
Fixes: #1208
Change-Id: I073a27d23176f3b4a126f2eb50c079374a11418d
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
commit 7ebaea1f4c1485b1caa2ac045a9abb30a92f357c
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Tue Apr 28 14:39:14 2020 +0000
core: Updated the GD_OP_VERSION
fixes: #1204
Change-Id: Ied5d4d553771ff315ed3f1a7229f96733fe7ed00
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit d663c342f185419fb535b0a914095820229fd9e5
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Apr 29 12:53:59 2020 +0100
tests: fix georep-upgrade.t failure
This patch fixes georep-upgrade.t test failure.
Problem:
`TEST upgrade_script=$(find / -type f -name glusterfs-georep-upgrade.py)`
Multiple files with the same name can exist for temp fix picking only the 1st result.
The proper fix should be finding a proper place for this upgrade script and use that.
Change-Id: I8b388e30a30bc4a9a2f392bed42ceee7e8bc250a
Updates: #1209
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 8820960232512cb06dc5f934db7290b16a5577c8
Author: Amar Tumballi <amar@kadalu.io>
Date: Tue Apr 28 15:17:38 2020 +0530
github/stale-bot: close issues automatically
Updates: #824
Change-Id: I18e0a93c39e82bba74cc163457344fa6ce4d7fbb
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 63012b942f954a2d853c7010195f3555a2eb5198
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Apr 9 13:11:47 2020 +0530
tests: Fix bug-1101647.t test case failure
Problem: tests/bugs/replicate/bug-1101647.t test case fails sporadically
in the volume heal since connection to the bricks with shd was not being
checked before running the index heal.
Build link: https://build.gluster.org/job/regression-test-burn-in/5007/
Fix: Check for the connection status of the bricks with shd before
performing the index heal.
Change-Id: Ie7060f379b63bef39fd4f9804f6e22e0a25680c1
Updates: #1154
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit d896c40e8a5646c9ed5e30e49e6790439c1b53c3
Author: Amar Tumballi <amar@kadalu.io>
Date: Fri Feb 28 19:21:13 2020 +0530
rfc.sh: remove reference to bugzilla
Updates: #824
Change-Id: I2eb1b43f01ca0e705110bd5d28f204065e611d3e
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 168ca37202cde722cc54e73239bd07d012c4b744
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Thu Apr 2 14:58:55 2020 +0530
Github template: release tracker template added
Have made minor changes to issue template to fix the nits
Change-Id: Iadaee1289a98427c15ea03dd0a7c77a8e3ac3f7f
Updates: #824
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
commit efa556bf6b4d42145dd5e6a0908447d1e5293674
Author: nik-redhat <nladha@redhat.com>
Date: Thu Apr 9 11:36:34 2020 +0530
dht xlator: integer handling issue
Issue: The ret value is passed to the function
instead of the proper errno value
Fix: Passing the errno generated to
the log function
CID: 1415824 : Improper use of negative value
CID: 1420205 : Improper use of negative value
Change-Id: Iaa7407ebd03eda46a2c027695e6bf0f598b371b2
Updates: #1060
Signed-off-by: nik-redhat <nladha@redhat.com>
commit 9b9717089e694ea0f485156e2ccb79d09be995d4
Author: Susant Palai <spalai@redhat.com>
Date: Fri Apr 24 13:32:51 2020 +0530
dht: Handle setxattr and rm race for directory in rebalance
Problem: Selfheal as part of directory does not return an error if
the layout setxattr fails. This is because the actual lookup fop
must have been successful to proceed for layout heal. Hence, we could
not tell if fix-layout failed in rebalance.
Solution: We can check this information in the layout structure that
whether all the xlators have returned error.
fixes: #1200
Change-Id: I3e5f2a36c0d934c21476a73a9a5473d8e490cde7
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 8b48b1eb59a34c5da2a2b61e1ec73006ec0a62ae
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Apr 22 15:09:16 2020 +0100
snapshot: fix python3 issue in gcron
`$gcron.py test_vol Job`
Traceback:
File "/usr/sbin/gcron.py", line 189, in <module>
main()
File "/usr/sbin/gcron.py", line 121, in main
initLogger(script_name)
File "/usr/sbin/gcron.py", line 44, in initLogger
logfile = os.path.join(out.strip(), script_name[:-3]+".log")
File "/usr/lib64/python3.6/posixpath.py", line 94, in join
genericpath._check_arg_types('join', a, *p)
File "/usr/lib64/python3.6/genericpath.py", line 151, in _check_arg_types
raise TypeError("Can't mix strings and bytes in path components") from None
TypeError: Can't mix strings and bytes in path components
Solution: Added the 'universal_newlines' flag to Popen.
Change-Id: I4c7a0e5bce605e4c134f6786c9dd8162b89fc77f
Fixes: #1193
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 390a1b5c38d335f01b1a9940566a09d7104652e8
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Apr 23 11:49:32 2020 +0530
socket: Resolve ssl_ctx leak for a brick while only mgmt SSL is enabled
Problem: While only mgmt SSL is enabled for a brick process use_ssl flag
is false for a brick process and socket api's cleanup ssl_ctx only
while use_ssl and ssl_ctx both are valid
Solution: To avoid a leak check only ssl_ctx, if it is valid cleanup
ssl_ctx
Fixes: #1196
Change-Id: I2f4295478f4149dcb7d608ea78ee5104f28812c3
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 0dc40b3a78e9c3c73a7e747b360fefedf2403f25
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Apr 20 12:15:42 2020 +0100
build: geo-rep requires relevant selinux permission for rsync
If selinux is set in enforcing mode geo-rep goes into faulty state.
To avoid this from happening some relevant selinux booleans need to be set
in 'on' state to allow rsync operation.
Change-Id: Ia8ce530d6548c2a545f4c99c600f5aac2bbb3363
Fixes: #1182
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit f5ae1dc7f4444896f161b9486f6afd39d445bf1c
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Thu Feb 13 16:57:13 2020 +0530
extras: upgrade script for geo-rep
The patch https://review.gluster.org/#/c/glusterfs/+/23733/( which
optimizes the changelog) introduces change in dirctory structure
which is above changelog files.
Thus, before upgrade, old version should get updated, with respect
to the corresponding changes made by the above qouted patch.
This upgrade script,
1) creates a temp htime file, with updated paths from the htime file.
Updates temp htime file as htime file.
2) places the changelog files under the required directory structure.
Updates: #154
Change-Id: I4b5a6cb9a9266a65972b419b329bc958de8fdf8a
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 2b08cb8a5bb9cffd4425d2da88e7dcd3cd6c8bee
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Apr 10 14:30:57 2020 +0530
afr: event gen changes
The general idea of the changes is to prevent resetting event generation
to zero in the inode ctx, since event gen is something that should
follow 'causal order'.
Change #1:
For a read txn, in inode refresh cbk, if event_generation is
found zero, we are failing the read fop. This is not needed
because change in event gen is only a marker for the next inode refresh to
happen and should not be taken into account by the current read txn.
Change #2:
The event gen being zero above can happen if there is a racing lookup,
which resets even get (in afr_lookup_done) if there are non zero afr
xattrs. The resetting is done only to trigger an inode refresh and a
possible client side heal on the next lookup. That can be acheived by
setting the need_refresh flag in the inode ctx. So replaced all
occurences of resetting even gen to zero with a call to
afr_inode_need_refresh_set().
Change #3:
In both lookup and discover path, we are doing an inode refresh which is
not required since all 3 essentially do the same thing- update the inode
ctx with the good/bad copies from the brick replies. Inode refresh also
triggers background heals, but I think it is okay to do it when we call
refresh during the read and write txns and not in the lookup path.
The .ts which relied on inode refresh in lookup path to trigger heals are
now changed to do read txn so that inode refresh and the heal happens.
Change-Id: Iebf39a9be6ffd7ffd6e4046c96b0fa78ade6c5ec
Fixes: #1179
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reported-by: Erik Jacobson <erik.jacobson at hpe.com>
commit 214701518529d37fa43e229d0af947a53da9b977
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Tue Apr 21 19:13:41 2020 +0300
dht - fixing rebalance failures for files with holes
Rebalance process handling of files which contains holes casued
rebalance to fail with "No space left on device" errors.
This patch modifies the code-flow in such a way that files with holes
will be rebalanced correctly.
fixes: #1187
Change-Id: I89bc3d4ea7f074db7213d759c49307f379543932
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit bc0842d412a028267216abe85cd182b7d1dc339a
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Apr 17 12:10:05 2020 +0200
md-cache: fix several NULL dereferences
This patch includes the following CID from Coverity Scan:
* 1425196
* 1425197
* 1425198
* 1425199
* 1525200
Change-Id: Iddcfea449d3dd56d4dfcc39f4c3c608518e611e4
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
Updates: #1060
commit 00df59b5f5c80f315f007b1cf355b05cf927e842
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 22 08:52:41 2020 +0530
tests: Fix spurious failure of tests/basic/quick-read-with-upcall.t
Problem:
The test is failing at
14:56:41 ok 13, LINENUM:38
14:56:41 not ok 14 Got "test-message0" instead of "test-message1", LINENUM:41
14:56:41 FAILED COMMAND: test-message1 cat /mnt/glusterfs/1/test.txt
This happens because fuse sometimes doesn't send 'read' fop to glusterfs
and is served from cache.
Fix:
Mount with direct-io-mode=yes so that read is always received by
gluster
Fixes: #1190
Change-Id: I369e2024a85dc492dc24c7579b161fb965f55d19
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit c916821bf9247bbc719fdaa84536c0ca5105c8ba
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Tue Mar 10 11:23:37 2020 +0200
dht/rebalance - fixing recursive failure issue
If rebalance process is failing, recursive failures appear in the log
file, which is distracting from the root cause.
In order to avoid recursive failure, error handling mechanism has
been modified.
fixes: #1072
Change-Id: Iae19430323630acd97c2c8d35685626d8da747a7
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 0357330237cc87fd54656fe7c8040c44966fb6a4
Author: Barak Sason Rofman <sason922@gmail.com>
Date: Sun Apr 12 18:19:41 2020 +0300
dht - Remove "tier" code (part 1)
This patch is removing some of the "tier" code in dht xlator, as it is no longer
being used.
Not all of the not-needed code is removed at once, so reviewing is easier.
Follow up patches removing additional unused code will follow.
This is based in the work done in https://review.gluster.org/#/c/glusterfs/+/23935/
Change-Id: I3cb6a0c5d8f14afcd87cf021ef8f74b91c0f908a
updates: #1097
Signed-off-by: Barak Sason Rofman <bsaonro@redhat.com>
commit 4eb2885c9fede01f47c730b771f01056d6ff5e74
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri Apr 10 13:45:50 2020 +0530
tests: Fix for spurious failure for some test cases
Problem: Sometimes test case is failing at the time of creating files
on mount point after mounting the volume
Solution: After started the volume need to wait to make sure all
bricks instances are completely started so put a online_brick_count
check after just started the volume
Change-Id: I5020e7e417539377277ca00189f9c51d2cf877a6
Fixes: #1162
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit dd7c0181b5c3d4dd32b6829b2da017a95e8dd8b9
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Mon Mar 30 11:09:39 2020 +0200
md-cache: avoid clearing cache when not necessary
mdc_inode_xatt_set() blindly cleared current cache when dict was not
NULL, even if there was no xattr requested.
This patch fixes this by only calling mdc_inode_xatt_set() when we have
explicitly requested something to cache.
Change-Id: Idc91a4693f1ff39f7059acde26682ccc361b947d
Fixes: #1140
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 0e073e4977be4480b7678b25d9be60c804f5bd90
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Dec 25 22:56:12 2019 +0530
posix: fix GF_VALIDATE_OR_GOTO(this->name, this, out)
Remove GF_VALIDATE_OR_GOTO(this->name, this, out) when this
is passed as an argument and is checked for NULL in the caller
itself.
GF_VALIDATE_OR_GOTO(this->name, this, out) is modified to use
xlator name instead of this->name as we are still verifying
whether this is NULL.
updates: #1000
Change-Id: Ide3180da29d0d4a35b2c5b9a7604fdf2ff4a9ffb
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit c3645dce6e5af5c24c15f8a4750eec19afc108c5
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Apr 9 13:08:23 2020 +0530
test: tests/bugs/rpc/bug-847624.t is crashed
Problem: glusterfs(GNFS) is crashing at the time of handling
Pollerr event in rpcsvc_drc_client_unref.GNFS is crashed
because ref was 0 at the time of unref and ref was taken
while Pollin event successfully handled.
Solution: Convert drc_client ref to atomic ref to avoid the crash
Change-Id: Ia4c054f2f388032a5cd99597d0cfa18b003ca690
Fixes: #1038
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 5dcda95cf37495f11935777874481fd505949889
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri Apr 10 11:13:12 2020 +0300
tests: do not truncate file offsets and sizes to 32-bit
Do not truncate file offsets and sizes to 32-bit to
prevent tests from spurious failures on >2Gb files.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Change-Id: I2a77ea5f9f415249b23035eecf07129f19194ac2
Fixes: #1161
commit f47b39a204fa6658f5160bb47c6d6b249db5cf85
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Apr 14 07:59:22 2020 -0400
common-ha: cluster status shows "FAILOVER" when actually HEALTHY
pacemaker devs change the format of the ouput of `pcs status`
Expected to find a line in the format:
Online: ....
but now it's
* Online: ...
And the `grep -E "^Online:" no longer finds the list of nodes that
are online.
Change-Id: If2aa1e7b53c766c625d7b4cc222a83ea2c0bd72d
Fixes: #1169
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 390bd1c97b793d81a736673ec76528df3702cce1
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Thu Apr 9 13:51:22 2020 +0000
tests: Fix spurious failure of worm.t
When the output of date command is a single digit
number it is preceded by zero which is getting
considered as an octal number. Removing the leading
zero from the number solved the problem.
Fixes: #1156
Change-Id: Iac4fa20607c0bb90d94dd8ff157ef6b60932c560
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit c741aa7d20e8bea0fe2916adfdb4b1f20d2efc4e
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri Apr 10 10:47:17 2020 +0300
mgmt/glusterd: use stat() syscall wrapper
Found with 0-symbol-check.t:
./tests/basic/0symbol-check.t ..
1..2
./xlators/mgmt/glusterd/src/.libs/glusterd_la-glusterd-volume-set.o should call sys_stat, not stat
ok 1 [ 40/ 41011] < 40> 'find . -name *.o -exec ./tests/basic/symbol-check.sh {} \;'
not ok 2 [ 11/ 1] < 42> '[ ! -e ./.symbol-check-errors ]' -> ''
Failed 1/2 subtests
Change-Id: I8962f487cd88738a1f7a962049d513712687088c
Fixes: #1160
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
commit 1082d26b58ff9a281b80b1a952063a1f62cabd84
Author: Barak Sason Rofman <sason922@gmail.com>
Date: Sun Apr 12 13:50:33 2020 +0300
test: Fix test "bug-1064148" to pass in mux
Parts of the test weren't designed to run in mux mode, this is now fixed
Change-Id: I428c2fcce6d047e324ca5dcaef677ee1794e3dfe
updates: #1154
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit e58a10c3283c3176ce3efc3957be0b878742aa65
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Apr 9 21:55:46 2020 +0530
tests: Fix spurious failure of tests/bugs/glusterd/serialize-shd-manager-glusterd-restart.t
Problem: Sometime volume status is failed after restart glusterd
in one cluster node
Solution: Wait to finish glusterd handshake on down cluster node
Change-Id: Ib23ca41c943caf2903c61ebf42dc437c1b9d6054
Fixes: #1158
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit d11c51ccf2970e65224c6680a179e61a97d58c90
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Thu Apr 9 01:59:03 2020 +0530
protocol/server: Fix coverity issue RESOURCE_LEAK
Handle case of arg not freed
CID: 1422174
Updates: #1060
Change-Id: Ibd03908a3ea8369035c2b7f6e024b3e5be48f436
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit e6ba6df08e28d5e4b229753b7ecad7149c720fa5
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Tue Jan 14 08:26:12 2020 +0530
Adding basic glusterfind test case
This test case includes all the basic glusterfind scenarios.
fixes: #1044
Change-Id: I6021443729e35769fe855c5cc41bb3fbc6365ef0
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 971565a77659aa33fa6d91378adf7ee70726c5bc
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Apr 6 21:58:03 2020 +0530
posix: Avoid dict_del logs in posix_is_layout_stale while key is NULL
Problem: The key "GF_PREOP_PARENT_KEY" has been populated by dht and
for non-distribute volume like 1x3 key is not populated so
posix_is_layout stale throw a message while a file is created
Solution: To avoid a log put a condition before delete a key
Change-Id: I813ee7960633e7f9f5e9ad2f42f288053d9eb71f
Fixes: #1150
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit eb69b3253016d6cddfbf2a37f02208c7afa984fc
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Apr 7 16:05:16 2020 +0530
mount/fuse: Wait for 'mount' child to exit before dying
Problem:
tests/bugs/protocol/bug-1433815-auth-allow.t fails
sometimes because of stale mount. This stale mount
comes into picture when parent process dies without
waiting for the child process which mounts fuse fs
to die
Fix:
Wait for mounting child process to die before dying.
Fixes: #1152
Change-Id: I8baee8720e88614fdb762ea822d5877973eef8dc
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 45a17db955f0171e7d75b98faa5adc12ef13863b
Author: kshithijiyer <kshithij.ki@gmail.com>
Date: Fri Mar 27 11:13:29 2020 +0530
Merging multiple import into single import
Geo-replication has a large number of repeated imports as shown below:
```
from syncdutils import set_term_handler, finalize, lf
from syncdutils import log_raise_exception, FreeObject, escape
```
There imports can be clubbed together as shown below:
``
from syncdutils import (set_term_handler, finalize, lf,
log_raise_exception, FreeObject, escape)
```
Fixes: #1105
Change-Id: I59a48dd57a70fc851d93150b85e736ce41e8b793
Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
commit 462b316314d4cf56b425cab66036aef540c90674
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Wed Jan 15 12:02:05 2020 +0200
dht - fixing a permission update issue
When bringing back a downed brick and performing lookup from the client
side, the permission on said brick aren't updated on the first lookup,
but only on the second.
This patch modifies permission update logic so the first lookup will
trigger a permission update on the downed brick.
LIMITATIONS OF THE PATCH:
As the choice of source depends on whether the directory has layout or not.
Even the directories on the newly added brick will have layout xattr[zeroed], but the same is not true for a root directory.
Hence, in case in the entire cluster only the newly added bricks are up [and others are down], then any change in permission during this time will be overwritten by the older permissions when the cluster is restarted.
fixes: #999
Change-Id: Ieb70246d41e59f9cae9f70bc203627a433dfbd33
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit dceb33e49112c9a174e2d6bb89be8ef1521ac495
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Apr 7 20:55:19 2020 +0530
tests: Fix spurious failure of tests/bugs/snapshot/bug-1111041.t
Test should wait for process down notification to be received
by glusterd.
Fixes: #1153
Change-Id: I9162b58a92c1a909ca98097f14c0714f9086bdd1
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 4bff77920d9654d73dc6069f49ea72e2057b339f
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Apr 6 12:36:44 2020 +0530
gfapi: Suspend synctasks instead of blocking them
There are certain conditions which blocks the current
execution thread (like waiting on mutex lock or condition
variable or I/O response). In such cases, if it is a
synctask thread, we should suspend the task instead
of blocking it (like done in SYNCOP using synctask_yield)
This is to avoid deadlock like the one mentioned below -
1) synctaskA sets fs->migration_in_progress to 1 and
does I/O (LOOKUP)
2) Other synctask threads wait for fs->migration_in_progress
to be reset to 0 by synctaskA and hence blocked
3) but synctaskA cannot resume as all synctask threads are blocked
on (2).
Note: this same approach is already used by few other components
like syncbarrier etc.
Change-Id: If90f870d663bb242c702a5b86ac52eeda67c6f0d
Fixes: #1146
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit df296f8f312435445d58fa5a06509ca66c3ae8af
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Apr 2 13:03:35 2020 +0530
cluster/afr: Removing unsupported options from code base to improve coverage
Support for gluster volume heal <volname> info healed/heal-failed
was removed by commit bb02cfb56ae08f56df4452c2b948fa962ae1212b in
release-3.6. cli parser will display the usage message in all the
supported versions whenever these clis are run, leading to some
dead code in the latest branches. Since support for these clis
were removed long back, this should not give any backward
compatibility issues as well. Hence removing the dead code from
the code base which will lead to better code coverage by the
regression runs as well.
Updates: #1052
Change-Id: I0c2b061469caf233c06d9699b0d159ce48e240b9
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 1982f15db3c37be01eb56f1c1955111e8aab1f2a
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Dec 19 08:32:19 2019 +0530
Posix: Optimize posix code to improve file creation
Problem: Before executing a fop in POSIX xlator it builds an internal
path based on GFID.To validate the path it call's (l)stat
system call and while .glusterfs is heavily loaded kernel takes
time to lookup inode and due to that performance drops
Solution: In this patch we followed two ways to improve the performance.
1) Keep open fd specific to first level directory(gfid[0])
in .glusterfs, it would force to kernel keep the inodes
from all those files in cache. In case of memory pressure
kernel won't uncache first level inodes. We need to open
256 fd's per brick to access the entry faster.
2) Use at based call's to access relative path to reduce
path based lookup time.
Note: To verify the patch we have executed kernel untar 100 times on 6
different clients after enabling metadata group-cache and some
other option.We were getting more than 20 percent improvement in
kenel untar after applying the patch.
Credits: Xavi Hernandez <xhernandez@redhat.com>
Change-Id: I1643e6b01ed669b2bb148d02f4e6a8e08da45343
updates: #891
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit a2b1f02165436bd409999b6be347695aec862992
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Apr 1 13:31:50 2020 +0530
cluster/ec: Add test for reset-brick command
Following tests are done -
1 - After finishing reset-brick all the bricks should be up.
2 - Heal should be completed.
3 - Check number of entries present on brick which was reset.
Change-Id: I9314bed180293a99d400d94bb8cc7ece999da29e
Updates: #1144
commit 76647a24fc97ba0644a583dacf1e445691d4c71a
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Apr 3 12:34:07 2020 -0700
mgmt/glusterd: Reduce log level of repetitive log
Noticed that the following message repeats quite a bit in log files when
an external monitoring tool queries gluster for list of volumes
periodically:
"Received get vol req"
As there's not much value in having this log message at log level INFO,
changing the log level to DEBUG to make glusterd.log a bit quieter.
Change-Id: I4e791fc65b9a4f813d295e7b2b6a05f3c0782e69
Updates: #1000
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 1d687e38db92e5a8f415ae4902cba6edae7f3587
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Apr 3 15:25:44 2020 +0530
fuse: Add error-logs to debug bug-1433815-auth-allow.t failures
Fixes: #1149
Change-Id: I38483fc7d76d7fe0ac9fb649669a46bdf9c82234
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 93a8afb6a1d02e2d2a82e37869ed5aa9c987e923
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Mar 31 11:25:51 2020 -0400
storage/posix: log the ENOENT errors in posix_pstat
Change-Id: I93f11dae6e4939ab79b0481ead2a4f7bb3085b70
Fixes: #1142
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 685118900fe6a82ceefc13d0b3e488c538783c84
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Mar 27 23:56:15 2020 +0100
write-behind: fix data corruption
There was a bug in write-behind that allowed a previous completed write
to overwrite the overlapping region of data from a future write.
Suppose we want to send three writes (W1, W2 and W3). W1 and W2 are
sequential, and W3 writes at the same offset of W2:
W2.offset = W3.offset = W1.offset + W1.size
Both W1 and W2 are sent in parallel. W3 is only sent after W2 completes.
So W3 should *always* overwrite the overlapping part of W2.
Suppose write-behind processes the requests from 2 concurrent threads:
Thread 1 Thread 2
<received W1>
<received W2>
wb_enqueue_tempted(W1)
/* W1 is assigned gen X */
wb_enqueue_tempted(W2)
/* W2 is assigned gen X */
wb_process_queue()
__wb_preprocess_winds()
/* W1 and W2 are sequential and all
* other requisites are met to merge
* both requests. */
__wb_collapse_small_writes(W1, W2)
__wb_fulfill_request(W2)
__wb_pick_unwinds() -> W2
/* In this case, since the request is
* already fulfilled, wb_inode->gen
* is not updated. */
wb_do_unwinds()
STACK_UNWIND(W2)
/* The application has received the
* result of W2, so it can send W3. */
<received W3>
wb_enqueue_tempted(W3)
/* W3 is assigned gen X */
wb_process_queue()
/* Here we have W1 (which contains
* the conflicting W2) and W3 with
* same gen, so they are interpreted
* as concurrent writes that do not
* conflict. */
__wb_pick_winds() -> W3
wb_do_winds()
STACK_WIND(W3)
wb_process_queue()
/* Eventually W1 will be
* ready to be sent */
__wb_pick_winds() -> W1
__wb_pick_unwinds() -> W1
/* Here wb_inode->gen is
* incremented. */
wb_do_unwinds()
STACK_UNWIND(W1)
wb_do_winds()
STACK_WIND(W1)
So, as we can see, W3 is sent before W1, which shouldn't happen.
The problem is that wb_inode->gen is only incremented for requests that
have not been fulfilled but, after a merge, the request is marked as
fulfilled even though it has not been sent to the brick. This allows
that future requests are assigned to the same generation, which could
be internally reordered.
Solution:
Increment wb_inode->gen before any unwind, even if it's for a fulfilled
request.
Special thanks to Stefan Ring for writing a reproducer that has been
crucial to identify the issue.
Change-Id: Id4ab0f294a09aca9a863ecaeef8856474662ab45
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
Fixes: #884
commit 031580326e7a1230e00940fef5dc7cc47bf20d8d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Apr 2 15:30:28 2020 +0530
features/utime: Don't access frame after stack-wind
Problem:
frame is accessed after stack-wind. This can lead to crash
if the cbk frees the frame.
Fix:
Use new frame for the wind instead.
Updates: #832
Change-Id: I64754609f1114b0bbd4d1336fa81a56f2cca6e03
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 5cfbe65a993fce6eb346505be2231529b06f7479
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Mar 26 10:46:16 2020 +0000
snap_scheduler: python3 compatibility and new test case
Problem:
"snap_scheduler.py init" command failing with the below traceback:
[root@dhcp43-104 ~]# snap_scheduler.py init
Traceback (most recent call last):
File "/usr/sbin/snap_scheduler.py", line 941, in <module>
sys.exit(main(sys.argv[1:]))
File "/usr/sbin/snap_scheduler.py", line 851, in main
initLogger()
File "/usr/sbin/snap_scheduler.py", line 153, in initLogger
logfile = os.path.join(process.stdout.read()[:-1], SCRIPT_NAME + ".log")
File "/usr/lib64/python3.6/posixpath.py", line 94, in join
genericpath._check_arg_types('join', a, *p)
File "/usr/lib64/python3.6/genericpath.py", line 151, in _check_arg_types
raise TypeError("Can't mix strings and bytes in path components") from None
TypeError: Can't mix strings and bytes in path components
Solution:
Added the 'universal_newlines' flag to Popen to support backward compatibility.
Added a basic test for snapshot scheduler.
Change-Id: I78e8fabd866fd96638747ecd21d292f5ca074a4e
Fixes: #1134
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit a835f51214a543eca5d6bf0586d66788f5e51b58
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Mar 31 16:45:35 2020 +0530
rpc: Make ssl log more useful
Currently, ssl_setup_connection_params throws 4 messages for every
rpc connection that irritates a user while reading the logs. The same
info we can print in a single log with peerinfo to make it more
useful.ssl_setup_connection_params try to load dh_param even user
has not configured it and if a dh_param file is not available it throws
a failure message.To avoid the message load dh_param only while the user
has configured it.
Change-Id: I9ddb57f86a3fa3e519180cb5d88828e59fe0e487
Fixes: #1141
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 3fd5dfda6a957c2eb10022dfb39a6b74ed3cbedf
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Dec 24 13:00:19 2018 +0530
afr: mark pending xattrs as a part of metadata heal
...if pending xattrs are zero for all children.
Problem:
If there are no pending xattrs and a metadata heal needs to be
performed, it can be possible that we end up with xattrs inadvertendly
deleted from all bricks, as explained in the BZ.
Fix:
After picking one among the sources as the good copy, mark pending xattrs on
all sources to blame the sinks. Now even if this metadata heal fails midway,
a subsequent heal will still choose one of the valid sources that it
picked previously.
Fixes: #1067
Change-Id: If1b050b70b0ad911e162c04db4d89b263e2b8d7b
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit d342c17c998957a12618aac0c784c1e963a3894e
Author: l17zhou <cynthia.zhou@nokia-sbell.com>
Date: Tue Dec 3 07:43:35 2019 +0200
add clean local after grant lock
found by flock test, without correct ref number of fd,
lock will not be correctly released.
Fixes: bz#1779089
Change-Id: I3e466b17c852eb219c8778e43af8ad670a8449cc
Signed-off-by: l17zhou <cynthia.zhou@nokia-sbell.com>
commit 08369a6e3167dc328a7a1155521340add23d02b4
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Mon Mar 30 14:08:09 2020 +0530
Marker: Logically deadcode found by coverity
Have removed the deadcode found by the coverity id:1356503
Change-Id: Ieaa41e864538fb82dc967b4a214d4db09e267098
Updates: #1060
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
commit 273bf372416ab313aeed24fcc315b48d8de24981
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Mar 4 09:17:26 2020 +0530
core[brick_mux]: brick crashed when creating and deleting volumes over time
Problem: In brick_mux environment, while volumes are created/stopped in a loop
after running a long time the main brick is crashed.The brick is crashed
because the main brick process was not cleaned up memory for all objects
at the time of detaching a volume.
Below are the objects that are missed at the time of detaching a volume
1) xlator object for a brick graph
2) local_pool for posix_lock xlator
3) rpc object cleanup at quota xlator
4) inode leak at brick xlator
Solution: To avoid the crash resolve all leak at the time of detaching a brick
Change-Id: Ibb6e46c5fba22b9441a88cbaf6b3278823235913
updates: #977
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit b3029e8d9c0284c9bafa5275341c4bd2aa09577a
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Mar 23 11:47:10 2020 +0530
features/shard: Fix crash during shards cleanup in error cases
A crash is seen during a reattempt to clean up shards in background
upon remount. And this happens even on remount (which means a remount
is no workaround for the crash).
In such a situation, the in-memory base inode object will not be
existent (new process, non-existent base shard).
So local->resolver_base_inode will be NULL.
In the event of an error (in this case, of space running out), the
process would crash at the time of logging the error in the following line -
gf_msg(this->name, GF_LOG_ERROR, local->op_errno, SHARD_MSG_FOP_FAILED,
"failed to delete shards of %s",
uuid_utoa(local->resolver_base_inode->gfid));
Fixed that by using local->base_gfid as the source of gfid when
local->resolver_base_inode is NULL.
Change-Id: I0b49f2b58becd0d8874b3d4b14ff8d92a89d02d5
Fixes: #1127
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 63a1ddf858717e449bda98057f96c2496b260c64
Author: Susant Palai <spalai@redhat.com>
Date: Mon Mar 16 11:39:56 2020 +0530
dht: gf_defrag_process_dir is called even if gf_defrag_fix_layout has failed
Currently even though gf_defrag_fix_layout fails with ENOENT or ESTALE, a
subsequent call is made to gf_defrag_process_dir leading to rebalance failure.
fixes: #1102
Change-Id: Ib0c309fd78e89a000fed3feb4bbe2c5b48e61478
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 205794936cdb0cd10563283185227b24e847e966
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Mar 17 15:42:59 2020 +0000
worm-xlator: fix newly introduced coverity issue
This patch fixes CID: 1420405
updates: #1060
Change-Id: I0524e999fa1d36ed5a713eabf65482c04ad43a1a
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 92294ea0e622a204da201490acc3de210b4f0555
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Mar 12 21:12:13 2020 +0530
Posix: Use simple approach to close fd
Problem: posix_release(dir) functions add the fd's into a ctx->janitor_fds
and janitor thread closes the fd's.In brick_mux environment it is
difficult to handle race condition in janitor threads because brick
spawns a single janitor thread for all bricks.
Solution: Use synctask to execute posix_release(dir) functions instead of
using background a thread to close fds.
Credits: Pranith Karampuri <pkarampu@redhat.com>
Change-Id: Iffb031f0695a7da83d5a2f6bac8863dad225317e
Fixes: bz#1811631
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 75e1c20d60ec661eb7b0a6c6b16b24519b9f6a4e
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Mar 16 15:17:23 2020 +0000
geo-rep: descriptive message when worker crashes due to EIO
With this patch now you can notice log if it is due to EIO:
[2020-03-16 16:24:48.293837] E [syncdutils(worker /bricks/brick1/mbr3):348:log_raise_exception] <top>: Getting "Input/Output error" is most likely due to a. Brick is down or b. Split brain issue.
[2020-03-16 16:24:48.293915] E [syncdutils(worker /bricks/brick1/mbr3):352:log_raise_exception] <top>: This is expected as per design to keep the consistency of the file system. Once the above issue is resolved geo-rep would automatically proceed further.
Change-Id: Ie33f2440bc96089731ce12afa8dab91d9550a7ca
Fixes: #1104
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 95457cca2168389652d63ab980caa995fd87be85
Author: David Spisla <david.spisla@iternity.com>
Date: Tue Feb 25 10:57:36 2020 +0100
WORM-Xlator: Initial write of a file succeeds if auto-commit-period 0
If worm-file-level enabled and auto-commit-period 0 an initial write
of a file (e.g. $ echo test >> file1.txt) would lead to an zero byte
file because the WORM xlator immediately WORMed the file when it was
created.
To avoid this we move the setting of trusted.worm_file from
worm_create_cbk to worm_release . This means that this xattr will set
when the filehandle is closed and all initial WRITE FOPs succeed.
Finally we also perform gf_worm_state_transition in worm_release to
ensure that the file will be immediately WORMed after the file handle
was closed.
Change-Id: I5d02e18975b646ca1a27ed41d836e9d0dc333204
Fixes: bz#1808421
Signed-off-by: David Spisla <david.spisla@iternity.com>
commit 4b269c493672bcd81952d33de201e336c17a394f
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Sun Mar 8 18:36:45 2020 +0100
open-behind: fix missing fd reference
Open behind was not keeping any reference on fd's pending to be
opened. This makes it possible that a concurrent close and en entry
fop (unlink, rename, ...) caused destruction of the fd while it
was still being used.
Change-Id: Ie9e992902cf2cd7be4af1f8b4e57af9bd6afd8e9
Fixes: bz#1810934
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit a29a97a0d55b786c27df23da23b7abb370315d18
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Feb 21 18:13:57 2020 +0530
tests: fix afr-lock-heal-* failure
When brick-mux is enabled:
i)brick statedumps seem to be listing the same lock information multiple times.
While that is getting fixed, make changes to the .ts to check for unique values.
ii)detecting a brick as online via brick_up_status() seems to be taking
longer time when delaygen is enabled. Hence bump up PROCESS_UP_TIMEOUT to
90 for afr-lock-heal-advanced.t
Updates: #1042
Change-Id: Ife76008f7a99dd1f1fe5791a32577366baaab4b3
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 4bb65d6b6ee3b48130d8aaaee4a4ddb85897a5a9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Feb 4 18:42:33 2020 +0530
cluster/afr: Fixes for halo
Current implementation assumes that ping-event will come after connect event
but that may not be the case in the cases where after socket connection fds
need to be re-opened which would consume more time. So handle any order of the
ping/child-up events.
fixes: bz#1800583
Change-Id: I6bcdc0caa503bdc039ef2b4739fbf4afae121f05
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit bb5e7f309e4c032854c581ae5018c6f9848f2f8a
Author: Amar Tumballi <amar@kadalu.io>
Date: Wed Mar 4 00:46:08 2020 +0530
utime: resolve an issue of permission denied logs
In case where uid is not set to be 0, there are possible errors
from acl xlator. So, set `uid = 0;` with pid indicating this is
set from UTIME activity.
The message "E [MSGID: 148002] [utime.c:146:gf_utime_set_mdata_setxattr_cbk] 0-dev_SNIP_data-utime: dict set of key for set-ctime-mdata failed [Permission denied]" repeated 2 times between [2019-12-19 21:27:55.042634] and [2019-12-19 21:27:55.047887]
Change-Id: Ieadf329835a40a13ac0bf908dac776e66954466c
Fixes: #832
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit abd56b0fd4857f8481d73ad4978168a884f7463c
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Mar 10 15:05:08 2020 +0530
cli: display the error while probing the localhost
With bc6e206c6, we regressed in displaying the error
message when a user tries to probe localhost. With
this change, we display "probe on localhost not needed"
message to the user.
credits: Sachin Prabhu <sprabhu@redhat.com>
fixes: bz#1810042
Change-Id: Ibf82b5a658c371c08290a0b4f655e5ac5f436c06
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit d5082c10fc9798e6934c3b6394c5ce5ccb2a48b2
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Mar 10 21:06:20 2020 +0530
glusterd/snapshot: Add a warning message when a volume config changes
While changing a volume configuration, there is a chance that the
brick layout on the disk might be changed. If snapshot is present
on such volumes that will effects it's working. So this patch adds
a warning message if snapshot is present while a volume config change
happen.
Change-Id: I7256863fef734841fce0bc9ad94d5d201b1813d5
Fixes: bz#1812144
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit bf939da700cfc6f2bf72a117f015bdab56f09025
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Sun Mar 8 17:27:47 2020 +0200
dht - selfheal code cleaning
1 - Converted methods to static
2 - Removed unused code
Change-Id: I49db3e28116da1c3c9ff0a33dcce7281bc3856f7
updates: bz#1193929
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit f68387a87f1fb129536333beb32be158449bf237
Author: Arjun Sharma <arjsharm@redhat.com>
Date: Wed Mar 11 11:37:48 2020 +0530
Updating create-ganesha-config script:
Adding the Security_Label parameter for labelled nfs
Change-Id: I26d332bc30c767093cfa5d6e63a3b0268fc8a60b
Fixes: bz#1812353
Signed-off-by: Arjun Sharma <arjsharm@redhat.com>
commit 9736d6821f237d2e0607aaf327d3b68cb55f5850
Author: l17zhou <cynthia.zhou@nokia-sbell.com>
Date: Fri Mar 6 03:54:02 2020 +0200
protocol/client: fallback to anonymous fd for fsync
Change-Id: I32f801206ce7fbd05aa693f44c2f140304f2e275
Fixes: bz#1810842
commit 12e7063c0681e8d42de31054163a482a83617f21
Author: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
Date: Wed Oct 30 12:42:16 2019 +0530
Posix: structs re-aligned and manual padding added
All the structs present inside xlators/storage/posix have been re-aligned
into memory efficient way. Manual padding has been added to remove
compile time padding. This manual padding is for development and
debugging benefits. It lets to use -Wpadded option and raise warnings
from the remaining structs where compile time padding happens.
Change-Id: Ie72c02810803eae29fca435c71aa131a1315b8a8
Updates: bz#1754448
Signed-off-by: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
commit b28aaf62bc8e7a79e40d98e49cc9e5001b11092f
Author: yatipadia <ypadia@redhat.com>
Date: Tue Dec 31 14:47:03 2019 +0530
mgmt/glusterd: Adding validation for statedump path
Description of problem:
server.statedump-path is the path where statedumps are stored,
by default it is /var/run/gluster. And can be set to any valid
directory path. It was observed that server.statedump-path was
also accepting file, non-existent file and non-existent paths
as well. And statedump command was successful even when
statedumps with all the invalid paths.
a. A file
b. A non-existent path
Solution:
Added a validation function in gluster-volume-set.c which will
allow volume set to success if it's a valid directory
and in all other cases, volume set should fail.
Fixes: bz#1787122
Change-Id: Ia66e2b3d35f23efc5444c829928779a79d827b42
Signed-off-by: yatipadia <ypadia@redhat.com>
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 0353086433b8276b7f06761747163cccb6a7c863
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Sun Feb 9 15:09:30 2020 +0200
dht/rebalance - fixing failure occurace due to rebalance stop
Probelm description:
When topping rebalance, the following error messages appear in the
rebalance log file:
[2020-01-28 14:31:42.452070] W [dht-rebalance.c:3447:gf_defrag_process_dir] 0-distrep-dht: Found error from gf_defrag_get_entry
[2020-01-28 14:31:42.452764] E [MSGID: 109111] [dht-rebalance.c:3971:gf_defrag_fix_layout] 0-distrep-dht: gf_defrag_process_dir failed for directory: /0/1/2/3/4/5/6/7/8/9/10/11/12/13/14/15/16/17/18/19/20/21/22/23/24/25/26/27/28/29/30/31
[2020-01-28 14:31:42.453498] E [MSGID: 109016] [dht-rebalance.c:3906:gf_defrag_fix_layout] 0-distrep-dht: Fix layout failed for /0/1/2/3/4/5/6/7/8/9/10/11/12/13/14/15/16/17/18/19/20/21/22/23/24/25/26/27/28/29/30
In order to avoid seing these error messages, a modification to the
error handling mechanism has been made.
In addition, several log messages had been added in order to improve debugging efficiency
fixes: bz#1800956
Change-Id: Ifc82dae79ab3da9fe22ee25088a2a6b855afcfcf
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 715dc0d6e9cdbd9e178afa826de429083395e903
Author: yatipadia <ypadia@redhat.com>
Date: Wed Dec 11 15:58:46 2019 +0530
xlator/dht-helper: structure logging
convert gf_msg() to gf_smsg()
Updates: #657
Change-Id: Iab35ac89b7d7fb6fb0074fc61b11bf679c517c9d
Signed-off-by: yatipadia <ypadia@redhat.com>
Signed-off-by: yatip <ypadia@redhat.com>
commit 3b17ef8d57cac2a841613ca641f6506723ca8ed0
Author: yatip <ypadia@redhat.com>
Date: Mon Feb 3 17:36:00 2020 +0530
protocol/client: structure logging
convert gf_msg() to gf_smsg()
Updates: #657
Change-Id: I76a09cfd283bb4ec5c4358536da66547aaf0de31
Signed-off-by: yatip <ypadia@redhat.com>
commit 7985ac82a50175136a19bedf9a5e67f96b1a79e4
Author: yatip <ypadia@redhat.com>
Date: Thu Feb 27 18:48:16 2020 +0530
protocol/server-helpers: structure logging
convert gf_msg() to gf_smsg()
Updates: #657
Change-Id: Ic7b38b646fa0932f7c1562467866137c4567e1f1
Signed-off-by: yatip <ypadia@redhat.com>
commit 026fac1d087167da60d3b902ea1773f0c753b411
Author: yatip <ypadia@redhat.com>
Date: Thu Feb 27 14:34:56 2020 +0530
protocol/server-rpc-fops_v2: structure logging
convert gf_msg() to gf_smsg()
Updates: #657
Change-Id: I01146bcd06bca44faeca29da48fab1ee3fc51e00
Signed-off-by: yatip <ypadia@redhat.com>
commit 010558f839da3b8e595444be271628515a61ffac
Author: yatip <ypadia@redhat.com>
Date: Thu Feb 20 14:14:43 2020 +0530
protocol/server: structure logging
Convert all gf_msg() to gf_smsg()
Updates: #657
Change-Id: Ic54b03f05e2766c87f50df0b3a66803b5519fad9
Signed-off-by: yatip <ypadia@redhat.com>
commit 34718d72093ca25d258345787e9bf68b2568746f
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Sun Mar 1 19:49:04 2020 +0100
cluster/afr: fix race when bricks come up
The was a problem when self-heal was sending lookups at the same time
that one of the bricks was coming up. In this case there was a chance
that the number of 'up' bricks changes in the middle of sending the
requests to subvolumes which caused a discrepancy in the expected
number of replies and the actual number of sent requests.
This discrepancy caused that AFR continued executing requests before
all requests were complete. Eventually, the frame of the pending
request was destroyed when the operation terminated, causing a use-
after-free issue when the answer was finally received.
In theory the same thing could happen in the reverse way, i.e. AFR
tries to wait for more replies than sent requests, causing a hang.
Change-Id: I7ed6108554ca379d532efb1a29b2de8085410b70
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
Fixes: bz#1808875
commit c0b3c761ce11af8460a238439f6e442c75f155f3
Author: Amar Tumballi <amar@kadalu.io>
Date: Tue Feb 4 22:46:38 2020 +0530
github templates: Change to reflect the future workflow
* Issue template changed to remove reference to bugzilla
* PR template removed.
CONTRIBUTING made .md friendly (will be renamed once we shift review process)
Updates: #824
Change-Id: Ifd6f93ad9b7be97d8eb950a141fe585d3e5ed021
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit c277942cc96d1b5b8b5b5de27749bb1b157252e7
Author: yatipadia <ypadia@redhat.com>
Date: Wed Dec 11 14:29:50 2019 +0530
xlator/dht-lock: structure logging
convert gf_msg() to gf_smsg()
Change-Id: If540ca921b1cd8ca75b92b3d72eb9eb61bdaaa10
Updates: #657
Signed-off-by: yatip <ypadia@redhat.com>
commit 3999d6ee1dda044a3b877b8cc3443a5a16451755
Author: kinsu <vpolakis@gmail.com>
Date: Thu Sep 19 08:34:32 2019 +0000
Segmentation fault occurs during truncate
Problem:
Segmentation fault occurs when bricks are nearly full 100% and in
parallel truncate of a file is attempted (No space left on device).
Prerequicite is that performance xlators are activated
(read-ahead, write-behind etc)
while stack unwind of the frames following an error responce
from brick (No space left on device) frame->local includes a memory
location that is not allocated via mem_get but via calloc.
The destroyed frame is always ra_truncate_cbk winded from ra_ftruncate
and the inode ptr is copied to the frame local in the wb_ftruncate.
Fix:
extra check is added for the pool ptr
Change-Id: Ic5d3bd0ab7011e40b2811c6dece063b256e4d9d1
Fixes: bz#1797882
Signed-off-by: kinsu <vpolakis@gmail.com>
commit bdb938336136eee0b6119a2ac45dff9c9a0d5503
Author: Andreas Loibl <andreas.loibl@check24.de>
Date: Thu Feb 20 14:05:35 2020 +0100
mount.glusterfs: don't strip / from subdir-mounts
Change-Id: Ib07c31dc6669aa9d9f84a21e6160237290ed9afb
Fixes: bz#1804786
commit f6890402f919e8fdb1e1beacc385990480f45494
Author: Vishal Pandey <vpandey@redhat.com>
Date: Tue Nov 19 11:39:22 2019 +0530
glusterd: Brick process fails to come up with brickmux on
Issue:
1- In a cluster of 3 Nodes N1, N2, N3. Create 3 volumes vol1,
vol2, vol3 with 3 bricks (one from each node)
2- Set cluster.brick-multiplex on
3- Start all 3 volumes
4- Check if all bricks on a node are running on same port
5- Kill N1
6- Set performance.readdir-ahead for volumes vol1, vol2, vol3
7- Bring N1 up and check volume status
8- All bricks processes not running on N1.
Root Cause -
Since, There is a diff in volfile versions in N1 as compared
to N2 and N3 therefore glusterd_import_friend_volume() is called.
glusterd_import_friend_volume() copies the new_volinfo and deletes
old_volinfo and then calls glusterd_start_bricks().
glusterd_start_bricks() looks for the volfiles and sends an rpc
request to glusterfs_handle_attach(). Now, since the volinfo
has been deleted by glusterd_delete_stale_volume()
from priv->volumes list before glusterd_start_bricks() and
glusterd_create_volfiles_and_notify_services() and
glusterd_list_add_order is called after glusterd_start_bricks(),
therefore the attach RPC req gets an empty volfile path
and that causes the brick to crash.
Fix- Call glusterd_list_add_order() and
glusterd_create_volfiles_and_notify_services before
glusterd_start_bricks() cal is made in glusterd_import_friend_volume
Change-Id: Idfe0e8710f7eb77ca3ddfa1cabeb45b2987f41aa
Fixes: bz#1773856
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 33d48923e575ee9130e45152223f6e1740eb8a2c
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Feb 19 12:24:15 2020 +0100
core: Prevent crash on process termination
A previous patch (ce61da816a) has fixed a use-after-free issue,
but it doesn't work well when the final cleanup is done at process
termination because gluster doesn't stop other threads before
calling exit().
For this reason, the final cleanup is removed to avoid the crash,
at least until the termination sequence properly stops all gluster
threads before exiting the program.
Change-Id: Id7cfb4407fcf208e28f03a7c3cdc3ef9c1f3bf9b
Fixes: bz#1801684
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 9fd62a1eb6c34e52c81e3964e774eeaf877ab326
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Feb 12 12:47:57 2020 -0500
ganesha-ha: updates for pcs-0.10.x (i.e. in Fedora-29 and RHEL-8)
pcs-0.10 has introduced changes options to pcs commands
pcs-0.10.x is in Fedora-29 and later and RHEL-8.
Also some minor cleanup. Namely use bash built-in [[...]] in a few
more places instead of test(1), i.e. [...], and use correct "==" for
comparison.
Change-Id: I3fb2fcd71406964c77fdc4f18580ca133f365fd6
Fixes: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit cdce76be18a5889618b94c69e8b3f8606fe33063
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Feb 7 10:19:57 2020 +0100
core: fix memory pool management races
Objects allocated from a per-thread memory pool keep a reference to it
to be able to return the object to the pool when not used anymore. The
object holding this reference can have a long life cycle that could
survive a glfs_fini() call.
This means that it's unsafe to destroy memory pools from glfs_fini().
Another side effect of destroying memory pools from glfs_fini() is that
the TLS variable that points to one of those pools cannot be reset for
all alive threads. This means that any attempt to allocate memory from
those threads will access already free'd memory, which is very
dangerous.
To fix these issues, mem_pools_fini() doesn't destroy pool lists
anymore. Only at process termination the pools are destroyed.
Change-Id: Ib189a5510ab6bdac78983c6c65a022e9634b0965
Fixes: bz#1801684
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 095c3b80e836815e148d5095a1faaa4b9177bd9a
Author: Rishubh Jain <risjain@redhat.com>
Date: Sun Aug 18 18:02:57 2019 +0530
Updating gluster manual.
Adding disperse-data to gluster manual under
volume create command
Change-Id: Ic9eb47c9e71a1d7a11af9394c615c8e90f8d1d69
Fixes: bz#1668239
Signed-off-by: Rishubh Jain <risjain@redhat.com>
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 6f0dafe60363148cb86c69a2733cffa63698a652
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Feb 11 14:34:48 2020 +0530
afr: prevent spurious entry heals leading to gfid split-brain
Problem:
In a hyperconverged setup with granular-entry-heal enabled, if a file is
recreated while one of the bricks is down, and an index heal is triggered
(with the brick still down), entry-self heal was doing a spurious heal
with just the 2 good bricks. It was doing a post-op leading to removal
of the filename from .glusterfs/indices/entry-changes as well as
erroneous setting of afr xattrs on the parent. When the brick came up,
the xattrs were cleared, resulting in the renamed file not getting
healed and leading to gfid split-brain and EIO on the mount.
Fix:
Proceed with entry heal only when shd can connect to all bricks of the replica,
just like in data and metadata heal.
fixes: bz#1801624
Change-Id: I916ae26ad1fabf259bc6362da52d433b7223b17e
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 144a155d4bc6b61241c5480baeb75a8ad61854a5
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Jan 3 16:54:33 2020 +0530
cluster/thin-arbiter: Wait for TA connection before ta-file lookup
Problem:
When we mount a ta volume, as soon as 2 data bricks are connected
we consider that the mount is done and then send a lookup/create on
ta file on ta node. However, this connection with ta node might not
have been completed.
Due to this delay, ta replica id file will not be created and we
will see ENOTCONN error in log file if we do lookup.
Solution:
As we know that this ta node could have a higher latency, we should
wait for reasonable time for connection to happen before sending
lookup/create on replica id file.
fixes: bz#1720463
Change-Id: I36f90865afe617e4e84cee57fec832a16f5dd6cc
commit ab706acd144b4b7f74d28fe9eb066c73443b8efe
Author: yatipadia <ypadia@redhat.com>
Date: Tue Nov 19 18:59:28 2019 +0530
libglusterfs-xlator: structure logging
convert all gf_msg() to gf_smsg()
Change-Id: Id542e05faadb8041b472a2298c71fe62730e65fc
Updates: #657
Signed-off-by: yatipadia <ypadia@redhat.com>
commit 24794e6a093fb08d85c9c76af91ee57874dbfe58
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Wed Dec 18 19:18:40 2019 +0200
dht - Reducing methods scope
1. Reduced methods scope in the following:
inode read&write, layout, linkfile, shard
2. Removed dead code @ dht-linkkile.c:174-228 & dht-shard.c:44
Change-Id: I2d08a10c7b074fccdb0c020845cad60c6ea32db5
updates: bz#1193929
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit ad5affbbd8ef13711858ea3a879f66c05b37353f
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Mar 13 13:00:47 2019 +0530
cluster/afr: Check for lock on source & sink before doing data heal
Problem:
In function afr_selfheal_data_block(), we only check for the lock count
to be equal to or greater than the number of sinks. There can be a case
where we have 2 source bricks and one sink and the locking is successful
on only the source brick(s). In this case we continue with the healing
on sink without having a lock, which is not correct.
Fix:
Check for lock on atleast source & one sink before starting the data heal.
Change-Id: Iebcb57dcaa4b31831fedfee63d6ca16e9d6c8df8
fixes: bz#1688115
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 75834dee315dbec8021e282fd2f90ec7d4d1f0be
Author: Amar Tumballi <amar@kadalu.io>
Date: Tue Feb 4 23:02:51 2020 +0530
volgen: make thin-arbiter name unique in 'pending-xattr' option
Thin-arbiter module makes use of 'pending-xattr' name for the translator
as the filename which gets created in thin-arbiter node. By making this
unique, we can host single thin-arbiter node for multiple clusters.
Updates: #763
Change-Id: Ib3c732e7e04e6dba229e71ae3e64f1f3cb6d794d
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 34b028237eb23041c27d7f4abd172fb38a3765b6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Feb 11 15:42:05 2020 +0530
tests: Fix spurious self-heald.t failure
Problem:
heal-info code assumes that all indices in xattrop directory
definitely need heal. There is one corner case.
The very first xattrop on the file will lead to adding the
gfid to 'xattrop' index in fop path and in _cbk path it is
removed because the fop is zero-xattr xattrop in success case.
These gfids could be read by heal-info and shown as needing heal.
Fix:
Check the pending flag to see if the file definitely needs or
not instead of which index is being crawled at the moment.
fixes: bz#1801623
Change-Id: I79f00dc7366fedbbb25ec4bec838dba3b34c7ad5
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit ca44f0e08f029a758897394edec00c7900c8b355
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Sat Sep 29 13:15:35 2018 +0530
feature/changelog: Avoid thread creation if xlator is not enabled
Problem:
Changelog creates threads even if the changelog is not enabled
Background:
Changelog xlator broadly does two things
1. Journalling - Cosumers are geo-rep and glusterfind
2. Event Notification for registered events like (open, release etc) -
Consumers are bitrot, geo-rep
The existing option "changelog.changelog" controls journalling and
there is no option to control event notification and is enabled by
default. So when bitrot/geo-rep is not enabled on the volume, threads
and resources(rpc and rbuf) related to event notifications consumes
resources and cpu cycle which is unnecessary.
Solution:
The solution is to have two different options as below.
1. changelog-notification : Event notifications
2. changelog : Journalling
This patch introduces the option "changelog-notification" which is
not exposed to user. When either bitrot or changelog (journalling)
is enabled, it internally enbales 'changelog-notification'. But
once the 'changelog-notification' is enabled, it will not be disabled
for the life time of the brick process even after bitrot and changelog
is disabled. As of now, rpc resource cleanup has lot of races and is
difficult to cleanup cleanly. If allowed, it leads to memory leaks
and crashes on enable/disable of bitrot or changelog (journal) in a
loop. Hence to be safer, the event notification is not disabled within
lifetime of process once enabled.
Change-Id: Ifd00286e0966049e8eb9f21567fe407cf11bb02a
Updates: #475
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 874b7fb96f7b0e483c4bb1ff2a7b3611cb56d26e
Author: yatipadia <ypadia@redhat.com>
Date: Sat Nov 23 14:03:41 2019 +0530
libglusterfs-options: structure logging
convert all gf_msg() to gf_smsg()
Change-Id: I8f1ff462b9c8012ed676c51450930a65ac403bf3
Updates: #657
Signed-off-by: yatipadia <ypadia@redhat.com>
commit df6053a9eb32c7b9ae4127ab466785aab0054595
Author: Susant Palai <spalai@redhat.com>
Date: Fri Dec 27 12:06:19 2019 +0530
dht: Fix stale-layout and create issue
Problem: With lookup-optimize set to on by default, a client with
stale-layout can create a new file on a wrong subvol. This will lead to
possible duplicate files if two different clients attempt to create the
same file with two different layouts.
Solution: Send in-memory layout to be cross checked at posix before
commiting a "create". In case of a mismatch, sync the client layout with
that of the server and attempt the create fop one more time.
test: Manual, testcase(attached)
fixes: bz#1786679
Change-Id: Ife0941f105113f1c572f4363cbcee65e0dd9bd6a
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 8c6406e46b9540b084e1b36a74a864f3cb7e0de6
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Feb 3 18:10:17 2020 +0530
bitrot: Make number of signer threads configurable
The number of signing process threads (glfs_brpobj)
is set to 4 by default. The recommendation is to set
it to number of cores available. This patch makes it
configurable as follows
gluster vol bitrot <volname> signer-threads <count>
fixes: bz#1797869
Change-Id: Ia883b3e5e34e0bc8d095243508d320c9c9c58adc
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 0cf0fe4fc46e43fe1f6f404b33a7dd9c940e613f
Author: yatipadia <ypadia@redhat.com>
Date: Fri Nov 22 19:00:00 2019 +0530
libglusterfs-event-epoll: structure logging
convert gf_msg() to gf_smsg()
Change-Id: Idf5bfc826b0c9f1a2674eea2a2e6164f30806b00
Updates: #657
Signed-off-by: yatipadia <ypadia@redhat.com>
commit f76cfa2de38b40736b7ec4ab98170193e5893fec
Author: yatipadia <ypadia@redhat.com>
Date: Tue Nov 5 21:44:54 2019 +0530
glusterfsd: structure logging
convert gf_msg() to gf_smsg()
Change-Id: I1cd6a5ac6f4361195d5d925efb2cc194045d0bba
Updates: #657
Signed-off-by: yatip <ypadia@redhat.com>
commit 6851e60ce9e0f08bebbc300805819116c234db40
Author: yatip <ypadia@redhat.com>
Date: Thu Jan 30 18:59:54 2020 +0530
protocol/client-rpc-fops: structure logging
convert all gf_msg() to gf_smsg()
Updates: #657
Change-Id: Ia9d4fb17579af6586bc13d69ec7990c6cf220aac
Signed-off-by: yatip <ypadia@redhat.com>
commit c0813643f37a23ea6e6ec6d7fc3b4bdbcb399f20
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Aug 1 15:44:15 2019 +0530
configure: add an option to build with tcmalloc library
With this patch, one can now use '--enable-tcmalloc' while running
configure, and they can see that their glusterfs is linked with
libtcmalloc.
[atumball@local build]$ ldd /usr/local/sbin/glusterfs | grep tcmalloc
libtcmalloc.so.4 => /lib64/libtcmalloc.so.4 (0x00007feec0b87000)
Once we establish a standard performance number with and without this option,
we will see how to make it default.
Updates: #237
Change-Id: I3377f57bfe4e17f101a212e1914a6d3c1687d528
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 1a5ec9dfd340a1567f2facf9b113a37da0546304
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Feb 4 14:43:35 2020 +0530
protocol/client: Maintain connection to brick status
Problem:
The current version of the code depends on the non-zero-port information to
propagate ping event from brick to parent layers. But as and when connection
succeeds, port is set to zero in rpc layer.So ping event is never propagated to
parent layers. Halo doesn't work without this.
Fix:
Remember the status of connection in 'private' structure and use that to decide
to propagate ping event to parent xlator.
fixes: bz#1797934
Change-Id: Ia578ba9fb3813953d2068dbba5c982ab27cc3429
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 2729cf4bd57fe9b44cf3734e238ef05982887290
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Jan 21 10:16:29 2020 +0200
dht-hashfn.c: ensure we do not try to calculate hash on NULL path
For some reason, dht_selfheal_layout_alloc_start() sends a NULL
loc->path string to dht_hash_compute().
Until we understand why it happens, we should strive not to crash
on a strlen of a NULL pointer.
Change-Id: I8c2a22602cfccba9af85f432a1841556f6978450
updates: bz#1793378
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 32d67d4c30827a91efcbcf638c27f3225d25a492
Author: yatipadia <ypadia@redhat.com>
Date: Tue Dec 10 17:10:44 2019 +0530
xlator/dht-selfheal: structure logging
Convert gf_msg() to gf_smsg()
Change-Id: Ic72f2513e641cfcbe074933cb2697ee9fc05a766
Updates: #657
Signed-off-by: yatip <ypadia@redhat.com>
commit d35f95b14ea1325780075315e7e9837624089d2d
Author: yatipadia <ypadia@redhat.com>
Date: Wed Dec 11 19:54:45 2019 +0530
xlator/bit-rot: structure logging
convert all gf_msg() to gf_smsg()
Change-Id: Ifa45b5089f83ddfcf69132bb8d9c0dc6d012464b
Updates: #657
Signed-off-by: yatipadia <ypadia@redhat.com>
commit 6bd2bb96c7be5406ab05e51da3b7cd18786cd1b7
Author: yatip <ypadia@redhat.com>
Date: Fri Jan 17 15:00:12 2020 +0530
xlator/snapview: structure logging
convert gf_msg() to gf_smsg()
Updates: #657
Change-Id: I2dd09a205c11d1c05abc7106e67802d2aa3bca79
Signed-off-by: yatip <ypadia@redhat.com>
commit 84ad23ad696610effea73ca9ef606b108c9d8fdc
Author: yatipadia <ypadia@redhat.com>
Date: Sun Nov 17 12:35:20 2019 +0530
libglusterfs/common-utils: structure logging
changes all the gf_msg() to gf_smgs()
Change-Id: I3524bbd8f8070df2f2c888ea9b0fb7db1ee44453
Updates: #657
Signed-off-by: yatipadia <ypadia@redhat.com>
commit 45728cff832c7f01e6075f8237295ef6f6b0057c
Author: yatip <ypadia@redhat.com>
Date: Thu Jan 16 12:54:43 2020 +0530
xlator/dht-linkfile: structure logging
convert all gf_msg() to gf_smsg()
Updates: #657
Change-Id: I9104ba8a8102f04d031a208abb06b6cf8ea8fd13
Signed-off-by: yatip <ypadia@redhat.com>
commit 66e6a48cdf44532a295dc1e33f7ddf68c7b77ac9
Author: yatip <ypadia@redhat.com>
Date: Wed Jan 29 18:02:05 2020 +0530
protocol/client: structure logging
convert all gf_msg() to gf_smsg()
Updates: #657
Change-Id: I69b228d7c7a8bc6263f9bd33710e880678d8c017
Signed-off-by: yatip <ypadia@redhat.com>
commit ccd0102f782bb1a9fb2b7a4e4aed9338f828b55b
Author: yatip <ypadia@redhat.com>
Date: Fri Jan 24 20:58:06 2020 +0530
protocol/client-handshake: structure logging
convert gf_msg() to gf_smsg()
Updates: #657
Change-Id: Iee07228cfc3a9a9cd10e89ae9eb918681b072585
Signed-off-by: yatip <ypadia@redhat.com>
commit a801c3c8af596da1c55c5346c998c14f84903498
Author: yatip <ypadia@redhat.com>
Date: Fri Jan 24 19:01:15 2020 +0530
protocol/client-rpc-fops_v2: structure logging
convert gf_msg() to gf_smsg()
Updates: #657
Change-Id: Ib45f121f583c2af09bfddb23391f73a117e63213
Signed-off-by: yatip <ypadia@redhat.com>
commit 4212f3fea5660a5f7cc8eb2114a7bd6b7887f64d
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Sun Dec 22 22:52:30 2019 +0530
ec: change error message for heal commands for disperse volume
Currently when we issue a heal statistics or similar commands
for disperse volume, it fails with message "Volume is not of
type replicate." Adding message "this command is supported for
volumes of type replicate" to reflect supportability and better
understanding of heal functionality for disperse volumes.
fixes: bz#1785998
Change-Id: I9688a9fdf427cb6f657cfd5b8db2f76a6c56f6e2
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 4a29d6173482fbe72c314d928ccc38781a9082ee
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Jan 31 15:27:46 2020 +0000
libgfapi: fix resource leak
This patch fixes resource leak in glfs-fops.c.
CID : 1403873 : Resource leak
updates: bz#789278
Change-Id: I589d4d65d2b074801f7b4b0afd7dc4607d79420e
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 097a8c6a5170bd93456cef09c83c2e36885f307a
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Dec 4 17:06:18 2019 +0530
Improve logging in EC, client and lock translator
Change-Id: I98af8672a25ff9fd9dba91a2e1384719f9155255
Fixes: bz#1779760
commit e5dc8496204126dc9304baf8c0fd87e6851fb6bd
Author: Harpreet Kaur <hlalwani@redhat.com>
Date: Mon Jan 7 16:38:25 2019 +0530
geo-rep: Fix for "Transport End Point not connected" issue
problem: Geo-rep gsyncd process mounts the master and slave volume
on master nodes and slave nodes respectively and starts
the sync. But it doesn't wait for the mount to be in ready
state to accept I/O. The gluster mount is considered to be
ready when all the distribute sub-volumes is up. If the all
the distribute subvolumes are not up, it can cause ENOTCONN
error, when lookup on file comes and file is on the subvol
that is down.
solution: Added a Virtual Xattr "dht.subvol.status" which returns "1"
if all subvols are up and "0" if all subvols are not up.
Geo-rep then uses this virtual xattr after a fresh mount, to
check whether all subvols are up or not and then starts the
I/O.
fixes: bz#1664335
Change-Id: If3ad01d728b1372da7c08ccbe75a45bdc1ab2a91
Signed-off-by: Harpreet Kaur <hlalwani@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit ca0677305675602eaa3d8f2938299e75da96ab8a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Jan 22 14:37:04 2020 -0500
build: glusterfs-ganesha pkg requires python3-policycoreutils on rhel8
glusterfs-ganesha pkg requires policycoreutils-python-utils on rhel8,
not policycoreutils-python
Also needs nfs-ganesha-selinux on recent fedora and rhel/centos 8
Change-Id: Ia97b4dabdc098fb76e3f60e8b48ea4191e677136
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 89be5e60b7900e8b2f07ffe20c2d16715c0a6564
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Thu Nov 14 09:24:26 2019 +0530
tests: fix test failures for nfsnobody user and group
'nfsnobody' user and group is merged with
'nobody' user and group in RHEL8.
Tests are modified to use appropriate user and group.
BUG: 1756900
Change-Id: I59863da2262283b00b1cb417d3652ebe29a36407
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit d650a2546508f908bd27b19c58f53e98d5a98d18
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Thu Jan 2 12:05:12 2020 +0530
afr: restore timestamp of files during metadata heal
For files: During metadata heal, we restore timestamps
only for non-regular (char, block etc.) files.
Extenting it for regular files as timestamp is updated
via touch command also
fixes: bz#1787274
Change-Id: I26fe4fb6dff679422ba4698a7f828bf62ca7ca18
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit b3d23d87cf07c29c1beec59a4f9cf3d58410d336
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Sun Jan 19 17:54:51 2020 +0800
snapview: fix memory leak
Setting frame->local = local immediately after mem_get0.
In this case, SVC_STACK_UNWIND will take of freeing the memory.
Change-Id: If6433be0e14ed0f4ab4127f70a8875f81bb3e6b8
updates: bz#789278
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit d144ff8d7117c7d21606273e5a6d9db13d54f208
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Jan 14 17:11:15 2020 +0200
server.c: fix Coverity issue 1405844 (memory - illegal access)
We can use memcpy() instead of strncpy() as both are strings that are
37 bytes (GF_UUID_BUF_SIZE) long.
fixes: CID#1405844
Change-Id: Ic74e8817cd790c13e29f3e6be8f18f2bfff77115
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit b1c36086f2e95feb6c99908ed2ba59ecf4831a91
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Jan 22 15:50:27 2020 +0200
multiple files: ensure nfs_svc functions are available
When gNFS is disabled in build time, we have to ensure
taht the .stop(), .start() and other functions of the nfs_svc
are not called, otherwise we'd crash.
In addition, #ifdef more code that is gNFS related.
updates: bz#1793995
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I5081f1670c04ca306aeaab7208829b0f2f149a42
commit f69d981212c717ae9deeba64c7de101b614f8703
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Jan 21 21:09:56 2020 +0530
server: Mount fails after reboot 1/3 gluster nodes
Problem: At the time of coming up one server node(1x3) after reboot
client is unmounted.The client is unmounted because a client
is getting AUTH_FAILED event and client call fini for the graph.The
client is getting AUTH_FAILED because brick is not attached with a
graph at that moment
Solution: To avoid the unmounting the client graph throw ENOENT error
from server in case if brick is not attached with server at
the time of authenticate clients.
Credits: Xavi Hernandez <xhernandez@redhat.com>
Change-Id: Ie6fbd73cbcf23a35d8db8841b3b6036e87682f5e
Fixes: bz#1793852
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit b43c383818825eaca2206b767ffe27229a829c68
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Oct 21 20:56:23 2019 +0300
posix-entry-ops.c/posix.h: improve GFID_NULL_CHECK_AND_GOTO macro
The macro already fetches from the dictionary the gfid-req variable.
Instead of throwing it away, keep it and in 2 cases,
re-use it later.
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Id6d42535132805ab69e7e3b802c140b90f2f8958
commit 03f10c305979785f6afc7e8ad15814c5d0994b9f
Author: Xi Jinyu <xijinyu@cmss.chinamobile.com>
Date: Tue Jan 14 22:29:06 2020 -0500
Fix possible resource leaks.
xlators/features/quota/src/quota.c quota_log_usage function.
The quota_log_helper() function applies memory
for path through inode_path(), should be GF_FREE().
fixes: bz#1792707
Change-Id: I33143bdf272bf10837061df4a1b7b2fc146162d5
Signed-off-by: Xi Jinyu <xijinyu@cmss.chinamobile.com>
commit a248368e74d7aba66e789184b6f26e76fe72beb7
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Wed Dec 4 18:48:23 2019 +0200
cli - removing fetch of unnecessary items.
Somem methods dict_get...(...) values and then not use them anywhere.
Removed found occurrences.
fixes: #753
Change-Id: Iaeb8f4cec18f76078f6b2f4e4bd6f9795a3467bc
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 612fb78eefc46aabff6e47d95afcb0dafaf71d4b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Jan 12 16:33:54 2020 +0200
dictionary: remove the 'extra_free' parameter
This parameter may have been used in the past, but is no longer
needed. Removing it and the few locations it was actually referenced.
This allows to remove an extra memdup as well, that was not needed
in the 1st place in server_setvolume() and unserialize_rsp_direntp()
functions.
A followup separate patch will remove extra_stdfree parmeter
from the dictionary structure.
Change-Id: Ica0ff0a330672373aaa60e808b7e76ec489a0fe3
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 4e376f3b1ee8f15e066a47971139a3be038a37ad
Author: Amar Tumballi <amar@kadalu.io>
Date: Mon Jan 13 13:07:47 2020 +0530
pkg-version: fix warning due to wrong check.
using '==' operator is bash specific, and was giving
warnings like below when we ran `./autogen.sh`
```
build-aux/pkg-version: 26: [: x8dev: unexpected operator
build-aux/pkg-version: 49: [: x384.git22c2725bb: unexpected operator
```
This was not seen where 'sh' is linked to 'bash'.
Updates: bz#1193929
Change-Id: Ied0d6707dd8b5d78756f302b6319b6ef75143018
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit a86c5e803dd4a7c4f87309cd49ec1f7fe7804ca3
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Thu Jan 16 10:00:41 2020 +0800
glusterd: fix use after free
updates: bz#789278
Change-Id: I652d8d4428cf6ce61b712a66d309e78030a5f911
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit 11c3113db4600bcafadcd58e6529f293ca355418
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Jan 14 16:55:32 2020 +0200
name.c: fix Coverity issues 1412332/3 - strcat into uninitialized value
Check limit to 108 bytes before strcpy().
fixes: CID#1412332
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I8b26b1e1d2daca98ff36db531539bec0a405769c
commit e651a2a624c09bc6d793a24bf218f494cc82e2e7
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Jan 17 11:03:46 2020 +0000
geo-rep: Fix ssh-port validation
If non-standard ssh-port is used, Geo-rep can be configured to use ssh port
by using config option, the value should be in allowed port range and non negative.
At present it can accept negative value and outside allowed port range which is incorrect.
Many Linux kernels use the port range 32768 to 61000.
IANA suggests it should be in the range 1 to 2^16 - 1, so keeping the same.
$ gluster volume geo-replication master 127.0.0.1::slave config ssh-port -22
geo-replication config updated successfully
$ gluster volume geo-replication master 127.0.0.1::slave config ssh-port 22222222
geo-replication config updated successfully
This patch fixes the above issue and have added few validations around this
in test cases.
Change-Id: I9875ab3f00d7257370fbac6f5ed4356d2fed3f3c
Fixes: bz#1792276
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 9be14dc3206db3df2de14cda3d93da9aa3159774
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Jan 14 13:28:47 2020 +0100
events: fix IPv6 memory corruption
When an event was generated and the target host was resolved to an IPv6
address, there was a memory overflow when that address was copied to a
fixed IPv4 structure (IPv6 addresses are longer than IPv4 ones).
This fix correctly handles IPv4 and IPv6 addresses returned by
getaddrinfo()
Change-Id: I5864a0c6e6f1b405bd85988529570140cf23b250
Fixes: bz#1790870
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 91afc5e2f33a77af7f0c3ec7931e148056bda38d
Author: Michael Scherer <misc@fedoraproject.org>
Date: Thu Jan 16 11:21:09 2020 +0100
Be explicit on this being a python3 script
While the script seems to work on both python3 and python2, this
break the build of rawhide RPM who requires script to be either
using python2 or python3.
Since python2 is going to be deprecated, I guess we should aim for
python3.
Change-Id: Ic6322ad47772d708b60b96652a1122ee4a54141d
Fixes: bz#1791682
Signed-off-by: Michael Scherer <misc@fedoraproject.org>
commit 046b71dfa9f034abcabc2497fc64950657481b6c
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Dec 10 11:43:30 2019 +0530
protocol/client: Fix a log entry
It has been a while since we removed lock healing logic from protocol
client. So no need to mention that we healed locks after fd reopen.
Change-Id: I24bd3f9e9f2942e306714b2cb83c229ae57c60ae
Fixes: bz#1193929
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit d06ed0b40df3e46a9a1244a8b4d25667172c8167
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Dec 9 23:17:16 2019 +0200
dht-hashfn.c: remove a strlen()
We already have the length of the name, or when we munge it,
we can return the length of it instead of strlen() again.
Also, reduce a bit the code under the lock.
Change-Id: I0141b0725ed1a4134d8d9f81ed1187b551b038b5
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 89c88e45bb59eb593d313ddb7f49b4e3036820c2
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Dec 9 21:28:00 2019 +0200
multiple xlators: reduce key length
In many cases, we were freely allocating long keys with no need.
Smaller char arrays are just fine almost anywhere, so just went ahead
and looked where they we can use smaller ones.
In some cases, annotated the functions as static and the prefixes
passed as const as it was easier to read and understand.
Where relevant, converted the dict functions to use known key length.
Change-Id: I882ab33ea20d90b63278336cd1370c09ffdab7f2
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 6b4651a484d31441f17f7533bedebb43b6111649
Author: yatipadia <ypadia@redhat.com>
Date: Wed Dec 4 12:09:12 2019 +0530
xlator/changelog: structure logging
convert all gf_msg() to gf_smsg()
Change-Id: I2303aeaa0775b663e2ea5741166a457cd747d2ac
Updates: #657
Signed-off-by: yatipadia <ypadia@redhat.com>
Signed-off-by: yatip <ypadia@redhat.com>
commit 29634da26247ab1f0386de43832348ad5a85d293
Author: yatipadia <ypadia@redhat.com>
Date: Mon Nov 25 19:57:09 2019 +0530
api-glfs-fops: structure logging
Convert gf_msg() to gf_smsg()
Change-Id: Iceb40d60a75106c7b4b0a2487b611f7376bccc46
Updates: #657
Signed-off-by: yatipadia <ypadia@redhat.com>
commit fb45a0639e27339b12798f90f93332f822f70620
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Tue Jan 14 10:51:06 2020 +0530
tools/glusterfind: Remove an extra argument
fixes: bz#1790748
Change-Id: I1cb12c975142794139456d0f8e99fbdbb03c53a1
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit c41d97d8704d0271477a597c7d998e6555918077
Author: yatipadia <ypadia@redhat.com>
Date: Thu Dec 12 16:17:22 2019 +0530
xlator/bit-rot-stub-helpers: structure logging
convert gf_msg() to gf_smsg()
Change-Id: Id03b6a2f6817101650ea6eeffb10e91c09e6ef80
Updates: #657
Signed-off-by: yatipadia <ypadia@redhat.com>
commit c68efe3d00a3a0075cf151e68ae3d9f378a4a5c7
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri Jan 10 13:44:53 2020 +0300
xlators/storage: remove duplicated includes
Do not include ftw.h twice.
Change-Id: Id9e8d1813aafd890940adcd6883d90fa1b4beaf9
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: bz#1193929
commit 2fb31d5d41ec3e0710abb19b8b36028f0f025995
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Jan 9 16:17:57 2020 +0300
xlators/storage: prefer HAVE_xxx to host C library predefines
Rely on configure-time HAVE_SET_FSID instead of predefined
linux and __GLIBC__, in the same way as fusermount.c does.
Change-Id: If81f821014bbf3fdc43950670e316b4d178b4cac
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: bz#1193929
commit 9db595a6c08453f0240427d584b1400606f3c420
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Oct 23 22:38:59 2019 +0300
dict: use the free_pair's key presence or NULL as a sign of use.
Instead of using a boolean parameter, we can use the key variable.
If it's NULL, the pair is not used and can be used.
Otherwise, it's in use - don't use.
It saves this annoying boolean, which causes the compiler
(or us explicitly) to pad with additional bytes the dict struct.
Change-Id: I89f52db57f35b3ef8acf57b7de2cee37f5d18e06
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 57ac39284ff5371c6d3bc6c1c39bb78ddfe65304
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Dec 31 09:11:08 2019 +0200
socket.c/name.c: minor changes
- Move functions to static
- Remove redundant checks
- Use dict_get_...sizen() where applicable
- Remove unused variables.
- Moved some code to be executed only if relevant.
~3% object size reduction.
Change-Id: Id9b8414e0a17442f1dac10ba77014d565756c935
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit ca46efd9f00383999c24330c7e8f8276fd95f121
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Dec 31 15:11:42 2019 +0200
rpc-transport: minor changes
- Removed dead code
- Remove redundant checks
- Changed dict functions to use dict_..._sizen() functions.
Change-Id: If00aaa90eef4078effd5b7fed2294f872e001b0a
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 5c3b5e2736c46290340b04849fddc939c37afb43
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Jan 10 08:24:35 2020 +0200
glusterd-volgen.c: fix to disable property when gNFS disabled.
The code was not ifdef'ed properly when gNFS was not enabled.
Strangely, I could not reproduce the failure on my system (Fedora 31),
but it was reproduced elsehwere and the fix was verified to correct it.
The failure:
gluster volume create testvol replica 3 127.0.0.2:/tests/brick{1..3} force
gluster v set testvol write-behind off
grep -rne write-behind /var/lib/glusterd/vols/testvol/trusted-testvol.tcp-fuse.vol
The last grep was supposed to come out empty.
The issue was that perfxl_option_handler may not have been called when it should
have been.
Change-Id: Ie9f8ec87dabeef6624527c2266ddf9af01ca7373
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit fe0fd5241aec7f574fde05f13d6d58da32210b00
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Jan 10 14:28:35 2020 +0000
glusterfind: python3 compatibility
Problem:
While we delete gluster volume the hook script 'S57glusterfind-delete-post.py'
is failed to execute and error message can be observed in glusterd log.
Traceback:
File "/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post", line 69, in <module>
main()
File "/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post", line 39, in main
glusterfind_dir = os.path.join(get_glusterd_workdir(), "glusterfind")
File "/usr/lib64/python3.7/posixpath.py", line 94, in join
genericpath._check_arg_types('join', a, *p)
File "/usr/lib64/python3.7/genericpath.py", line 155, in _check_arg_types
raise TypeError("Can't mix strings and bytes in path components") from None
TypeError: Can't mix strings and bytes in path components
Solution:
Added the 'universal_newlines' flag to Popen to support backward compatibility.
Change-Id: Ie5655b11b55535c5ad2338108d0448e6fdaacf4f
Fixes: bz#1789478
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 5fb713fde7a839f5575cd0d84a68ca5f075ca503
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Jan 10 16:48:14 2020 +0530
glusterfind: Fix py2/py3 issues
1. In dictionary values(), returns list in py2 and not in py3.
So explicitly convert it into list.
2. xattr module returns values in bytes. So explicitly convert
them to str to work both with py2 and py3
fixes: bz#1789439
Change-Id: I27a639cda4f7a4ece9744a97c3d16e247906bd94
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit a0bde5bbabfc4b434343de15bf7727ae6f0c6cfe
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Jan 7 12:57:29 2020 +0200
dht-rename.c: fix Coverity issues 1397018/7 - strcat into uninitialized value
initialize both src and dst if they were not initialized already.
fixes: CID#1397018
Change-Id: Ic91954423953e8bf24eaa11fc2798c554f304d28
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 8a5f8e73cd8e479cc0d075318e14e323d8ab9525
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Dec 20 14:14:32 2019 +0100
multiple: fix bad type cast
When using inode_ctx_get() or inode_ctx_set(), a 'uint64_t *' is expected.
In many cases, the value to retrieve or store is a pointer, which will be
of smaller size in some architectures (for example 32-bits). In this case,
directly passing the address of the pointer casted to an 'uint64_t *' is
wrong and can cause memory corruption.
Change-Id: Iae616da9dda528df6743fa2f65ae5cff5ad23258
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
Fixes: bz#1785611
commit 91f144bfc8251f70ffdd7022e79f6a8021a80a97
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Jan 7 19:43:05 2020 +0100
fuse: degrade logging of write failure to fuse device
Problem:
FUSE uses failures of communicating with /dev/fuse with various
errnos to indicate in-kernel conditions to userspace. Some of these
shouldn't be handled as an application error. Also the standard
POSIX errno description should not be shown as they are misleading
in this context.
Solution:
When writing to the fuse device, the caller of the respective
convenience routine can mask those errnos which don't qualify to
be an error for the application in that context, so then those
shall be reported at DEBUG level.
The possible non-standard errnos are reported with their
POSIX name instead of their description to avoid confusion.
(Eg. for ENOENT we don't log "no such file or directory",
we log indeed literal "ENOENT".)
Change-Id: I510158843e4b1d482bdc496c2e97b1860dc1ba93
updates: bz#1193929
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 75fe8c9efd10187636b55f0ee450ccc9e92f12f0
Author: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
Date: Fri Oct 25 11:28:00 2019 +0530
leases: re-alignment of structures
All the structs present inside xlators/features/leases have been
re-aligned into memory efficient way. Changes are made in such a way
that every members are 8 byte aligned and no padding is left out in
the 8 byte line. Manual padding has been added to remove compile time
padding (which happens at the end of the struct). This manual padding
is for development and debugging benefits. It lets to use -Wpadded
option and raise warnings from the remaining structs where compile time
padding happens.
Change-Id: I083d2de80e24f363c97adadcba64825e213050fc
Updates: bz#1754448
Signed-off-by: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
commit 261392d03081ae5563181584f32ef89aa3e2ab4b
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Jan 7 15:32:13 2020 +0530
glusterd: increase the StartLimitBurst
Based on https://bugzilla.redhat.com/show_bug.cgi?id=1782200#c6
increasing the limit.
fixes: bz#1782200
Change-Id: Ia885c7bdb2a90f0946c5268da894f6a4da5a69b7
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 10723d7b8650097af798f06b2eb41116398c59ad
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jan 3 09:59:29 2020 +0530
afr: expose cluster.optimistic-change-log to CLI.
This volume option was not made avaialble to `gluster volume set` CLI.
Reported-by: epolakis(https://github.com/kinsu) in
https://github.com/gluster/glusterfs/issues/781
fixes: bz#1787554
Change-Id: I7141bdd4e53ee99e22b354edde8d023bfc0b2cd7
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit a4c627a643336e4550a7ddf75a3534e4c6c7dfd9
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Sun Jan 5 12:11:07 2020 +0200
cli - fixing a coverity issue
Removed unused variable.
fixes: CID#1412106
updates: bz#789278
Change-Id: I1d4e1c1625cecf882d51e9cf4f5290383f63d405
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 71bf5fadaece78254cda98b1c7fe4a83a07510e2
Author: He Min <hemin@cmss.chinamobile.com>
Date: Thu Jan 2 14:26:22 2020 +0800
mgmt/glusterd: Correct the log path of valgrind.
Problem: Currently enabling run-with-valgrind will cause the gnfs and quota to
fail to start. The phenomenon is as follows.
------------------------------------------------------------------------------
NFS Server on localhost 2049 0 N 48406
Quota Daemon on localhost N/A N/A N 48428
------------------------------------------------------------------------------
Solution: The cause of the above phenomenon is that the log path of valgrind is
set incorrectly. Gnfs and quota can start with valgrind normally after correcting
the log path.
Updates: #788
Change-Id: Ib91408c08522ff66afff908fbff3fce4b93ea770
Signed-off-by: He Min <hemin@cmss.chinamobile.com>
commit 66b3a30d7c3844277ecf1d26769494c22c2ad0c8
Author: yatipadia <ypadia@redhat.com>
Date: Tue Dec 17 12:55:02 2019 +0530
xlator/performance/io-threads: structure logging
convert gf_msg() to gf_smsg()
Change-Id: I35c6f62c346a75ecb22cd3a4346ad4dc48f09a91
Updates: #657
commit 85d1e078b25b105aa315a156ef52a938918d879f
Author: yatipadia <ypadia@redhat.com>
Date: Wed Dec 18 17:25:51 2019 +0530
xlator/io-cache: structure logging
Convert all gf_msg() to gf_smsg()
Updates: #657
Change-Id: I72215b2518df78174dda8a7bc8de6f21fe1ba10f
Signed-off-by: yatipadia <ypadia@redhat.com>
commit e9ab8474b9454b695289f6304535b43dd380971a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Dec 1 13:57:28 2019 +0200
posix-metadata.c: try to getxattr in one call.
Another location where instead of 2 sys calls we strive to get the
xattr in a single call, by guesstimating the required size
And avoid (or try to) not to first read the xattr len,
then another call to actually fetch. Instead, use a sane size
(256 bytes - worth checking if it makes sense or by default
use a larger size), and see if we can fetch it.
If we fail, we'll read the size and re-fetch.
Such changes are needed elsewhere too (see
https://github.com/gluster/glusterfs/issues/720 )
Change-Id: I466cea9d8b12fc45f6b37d202b1294ca28cd1fdd
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit a68516d55dc3d2db0873acfd4481541e62d753c3
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jan 2 07:46:23 2020 -0500
cli: duplicate defns of cli_default_conn_timeout and cli_ten_minutes_timeout
Winter is coming. So is gcc-10.
Compiling with gcc-10-20191219 snapshot reveals dupe defns of
cli_default_conn_timeout and cli_ten_minutes_timeout in
.../cli/src/cli.[ch] due to missing extern decl.
There are many changes coming in gcc-10 described in
https://gcc.gnu.org/gcc-10/changes.html
compiling cli.c with gcc-9 we see:
...
.quad .LC88
.comm cli_ten_minutes_timeout,4,4
.comm cli_default_conn_timeout,4,4
.text
.Letext0:
...
and with gcc-10:
...
.quad .LC88
.globl cli_ten_minutes_timeout
.bss
.align 4
.type cli_ten_minutes_timeout, @object
.size cli_ten_minutes_timeout, 4
cli_ten_minutes_timeout:
.zero 4
.globl cli_default_conn_timeout
.align 4
.type cli_default_conn_timeout, @object
.size cli_default_conn_timeout, 4
cli_default_conn_timeout:
.zero 4
.text
.Letext0:
...
which is reflected in the .o file as (gcc-9):
...
0000000000000004 C cli_ten_minutes_timeout
0000000000000004 C cli_default_conn_timeout
...
and (gcc-10):
...
0000000000000020 B cli_ten_minutes_timeout
0000000000000024 B cli_default_conn_timeout
...
See nm(1) and ld(1) for a description C (common) and B (BSS) and how
they are treated by the linker.
Note: there is still a small chance that gcc-10 will land in Fedora-32,
despite 31 Dec. 2019 having been the deadline for that to happen.
Change-Id: I54ea485736a4910254eeb21222ad263721cdef3c
Fixes: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit bee9dd77356dd68e90c3f1dbb277db52cc435fd3
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Mon Jan 6 10:11:32 2020 +0800
lock: fix Coverity CID 1412107
To avoid memory leak.
Change-Id: Ib802be310fe989223afd623d3e5a9c9016d4fd38
updates: bz#789278
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit b241cc5f0fda5bce26c9b04be73976eca9475d4d
Author: kshithijiyer <kshithij.ki@gmail.com>
Date: Tue Dec 24 13:02:21 2019 +0530
Improving help message in schedule_georep.py.in
SLAVE positional argument doesn't provide a clear
picture of what it is when compared to mastervol and slavevol
in schedule_georep.py.in. It would be better if we change it to
something like "Slave hostame (<username>@SLAVEHOST or SLAVEHOST)"
Present:
----------
positional arguments:
mastervol Master Volume Name
SLAVE SLAVEHOST or root@SLAVEHOST or user@SLAVEHOST
slavevol Slave Volume Name
Suggested:
-----------
positional arguments:
mastervol Master Volume Name
SLAVE Slave hostname (<username>@SLAVEHOST or SLAVEHOST)
slavevol Slave Volume Name
fixes: bz#1786276
Change-Id: I73d52247997d623f77d55e51cbb6eccc08eb95ff
Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
commit ee1a43824a25ead77c28f87f7b7687c5551fd5ca
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Wed Jul 31 11:34:19 2019 +0530
geo-rep: Note section is required for ignore_deletes
There exists a window of 15 sec, where the deletes are picked up
by history crawl when the ignore_deletes is set to true.
And it eventually deletes the file/s from slave which is/are not
supposed to be deleted. Though it is working as per design, a
note regarding this is needed.
Added a warning message indicating the same.
Also logged info when the worker restarts after ignore-deletes
option set.
fixes: bz#1708603
Change-Id: I103be882fac18b4cef935efa355f5037a396f7c1
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 93b0b2ab603de6cad89c5a7a251402d57af8f1fe
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Dec 10 10:56:55 2019 +0200
posix: improve posix_{set_gfid2path_xattr|remove_gfid2path_xattr} funcs
1. Move them to posix-entry-ops.c and make them static.
2. Remove useless 'val' parameter allocation and snprintf() in
posix_set_gfid2path_xattr(), as it was identical to pgfid_bname.
Change-Id: I41f3946c6c42aee9d7cf1150e21b442438fbcce2
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit de3742fd881f621be3ce2659c2b3376169e769af
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Dec 29 17:35:13 2019 +0200
afr: simplify afr_has_quorum()
1. Perform AFR_COUNT() once, in afr_has_quorum() and pass the result
to afr_lookup_has_quorum()
2. Simplify afr_lookup_has_quorum() - pass less parameters to it.
(Via the change in item 1 above).
3. Make afr_is_add_replica_mount_lookup_on_root() static function.
4. Remove dead code - afr_decide_heal_info() which was not used.
Change-Id: If9168cd01e22788a0e60b91e315787d2aa60e97b
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 2cd837c869d5d2eacd36eecc5430fb6b69176329
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Dec 26 09:29:00 2019 +0200
Remove some compiler warnings when not compiling gNFS
As a follow up to https://review.gluster.org/#/c/glusterfs/+/23799/
When compiling without gNFS, there were some 'unused' warnings by
the compiler. This patch fixes them.
Change-Id: I621562261f53950e821a450e0e7da304d00ae557
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 27f175423fda4d1f5735e374c24e31bff1e90eb9
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Dec 25 21:56:32 2019 +0530
glusterd: deafult options after volume reset
Problem: default option itransport.address-family is disappered
in volume info output after a volume reset.
Cause: with 3.8.0 onwards volume option transport.address-family
has default value, any volume which is created will have this
option set. So, volume info will show this in its output. But,
with reset volume, this option is not handled.
Solution: In glusterd_enable_default_options(), we should add this
option along with other default options. This function is called
by glusterd_options_reset() with volume reset command.
fixes: bz#1786478
Change-Id: I58f7aa24cf01f308c4efe6cae748cc3bc8b99b1d
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 67f54115e2c135276349d3bc45617de467c17527
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Fri Dec 27 13:35:33 2019 +0300
cli, libglusterfs: rely on libpthread static initializers
cli-cmd.c: drop cli_cmd_cond_init() because static mutex and
condition variable are initialized with PTHREAD_xxx_INITIALIZERs.
syncop-utils.c: since assignment PTHREAD_xxx_INITIALIZERs are
never failed, a few overengineered bits may be simplified.
Change-Id: Ic4d250a1697047386989f73f058b0abc8b55627b
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Updates: bz#1193929
commit af2ef118078a83aad73aea6dc997ae6fb0c70cb2
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Dec 27 21:30:21 2019 +0200
posix-inode-fd-ops.c: fix a compiler warning - real_path may be NULL
Fixes the following:
posix-inode-fd-ops.c: In function ‘posix_common_removexattr’:
../../../../libglusterfs/src/glusterfs/logging.h:231:9: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
231 | _gf_msg(dom, __FILE__, __FUNCTION__, __LINE__, level, errnum, 0, \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
232 | msgid, ##fmt); \
| ~~~~~~~~~~~~~
posix-inode-fd-ops.c:4401:13: note: in expansion of macro ‘gf_msg’
4401 | gf_msg(this->name, GF_LOG_WARNING, errno, P_MSG_FDSTAT_FAILED,
| ^~~~~~
posix-inode-fd-ops.c:4402:47: note: format string is defined here
4402 | "fdstat operaton failed on %s", real_path);
| ^~
Change-Id: I3f2278d3a05a569dde257d66f44a8655491b4013
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit af21cce150d1e42a45168627ab0d1754f0580142
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Thu Nov 14 12:37:24 2019 +0530
features/changelog: Optimization in changelog
Problem: Currently changelog is written in one directory, which over
time, results in very large changelog files.
Solution: Seperate directory under the changelogs directory
is created on daily basis following the format year/month/day.
Updates: #154
Change-Id: I1cdabe33728a0ba1f298c8908bd8c323b1871bda
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit f4fbdd34d4f4d6f96f167645c0dbe65e80426817
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Sun Oct 20 22:01:01 2019 +0530
posix: Avoid diskpace error in case of overwriting the data
Problem: Sometime fops like posix_writev, posix_fallocate, posix_zerofile
failed and throw error ENOSPC if storage.reserve threshold limit
has reached even fops is overwriting the data
Solution: Retry the fops in case of overwrite if diskspace check
is failed
Credits: kinsu <vpolakis@gmail.com>
Change-Id: I987d73bcf47ed1bb27878df40c39751296e95fe8
Updates: #745
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 80e479ae3b49e7a95a092b24e9c36e67f2fd37cb
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Dec 29 11:03:40 2019 +0200
posix-entry-ops.c: remove some tier related code
Remove TIER_LINKFILE_GFID related code from posix
Tier xlator was removed, but there are some code related to it scattered
around in DHT and Posix xlators. Remove some of it.
Change-Id: I3a878b31ed4a045ed419f936aa1d567ded1a273f
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 13182f288cbee5184cd45b9085b1654ea8eea113
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Dec 18 13:16:39 2019 +0530
mgmt/brick-mux: Avoid sending two response when attach is failed.
We were sending two response back to glusterd when an attach is
failed. One from the handler function glusterfs_handle_attach and
another from rpcsvc_check_and_reply_error. It was causing problems
like ref leaks, transport disconnect etc.
Change-Id: I3bb5b59959530760b568d52becb519499b3dcd2b
updates: bz#1785143
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit fa1bbd4c7b1d300dcb8a4a106df7dd1131045b8a
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Dec 26 13:50:20 2019 +0300
transport/socket: destroy notify mutex and condition variable
Change-Id: Id74f829dc5c6a30d19e3c3ef42bcb938afc0d8e4
Updates: bz#1430623
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
commit 2e27ae7e55e540d95aad03d81ede5cc9698ff87e
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Dec 26 14:22:56 2019 +0300
socket: fix typos and drop unused members/options
Consistently fix 'configued' -> 'configured' typo, remove useless
members from 'socket_private_t' and unused 'transport.socket.lowlat'
option. Adjust tests as well.
Change-Id: I285be196457763aec16b184acd26b90623074dec
Updates: bz#1193929
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
commit f2c8d914ed9fea4d2e43bac5287ea87f5ad68a9f
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Dec 27 13:26:04 2019 +0000
extras: enable log rotation for USS logs
Added logrotate support for user serviceable snapshot's logs.
Change-Id: Ic920eaa8ab5e44daf5937a027c6913d7bb26d517
Fixes: bz#1786722
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit ee1773e12150411ec91e024454668e023627a878
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Dec 26 15:25:35 2019 +0300
Avoid buffer overwrite due to uuid_utoa() misuse
Code like:
f(..., uuid_utoa(x), uuid_utoa(y));
is not valid (causes undefined behaviour) because uuid_utoa()
uses the only static thread-local buffer which will be overwritten
by the subsequent call. All such cases should be converted to use
uuid_utoa_r() with explicitly specified buffer.
Change-Id: I5e72bab806d96a9dd1707c28ed69ca033b9c8d6c
Updates: bz#1193929
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
commit 942500afe3e3c2c20d95df240b4e28548cd3a37a
Author: yatipadia <ypadia@redhat.com>
Date: Thu Dec 12 14:40:03 2019 +0530
xlator/bit-rot-stub: structure logging
convert gf_msg() to gf_smsg()
Change-Id: I3072ba4305b720bea053688d140660d7d5c2d267
Updates: #657
Signed-off-by: yatipadia <ypadia@redhat.com>
commit dde289ad39278a6a18f4141f61a08df9d7020b56
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Dec 19 11:58:54 2019 +0100
timer: fix event destruction race
In current timer implementation, each event has an absolute time at which
it will be fired. When the first timer of the queue has not elapsed yet,
a pthread_cond_timedwait() is used to wait until the expected time.
Apparently that's fine. However the time passed to that function was a
pointer to the timespec structure contained in the event itself. This is
problematic because of how pthread_cond_timedwait() works internally.
Simplifying a bit, pthread_cond_timedwait() basically queues itself as a
waiter for the given condition variable and releases the mutex. Then it
does the timed wait using the passed value.
With that in mind, the follwing case is possible:
Timer Thread Other Thread
------------ ------------
gf_timer_call_cancel()
pthread_mutex_lock() |
+ pthread_mutex_lock()
event = current_event() |
pthread_cond_timedwait(&event->at) |
+ pthread_mutex_unlock() |
| + remove_event()
| + destroy_event()
+ timed_wait(&event->at)
As we can see, the time is used after it has been destroyed, which means
we have a use-after-free problem.
This patch fixes the problem by copying the time to a local variable
before calling pthread_cond_timedwait()
Change-Id: I0f4e8eded24fe3a1276dc75c6cf093bae973d26b
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
Fixes: bz#1785208
commit a389680e4979de1e7affc02dc9d6102b992d59fd
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Dec 24 13:53:16 2019 +0530
Revert "store.c: remove a sys_stat() call - just open the file"
This reverts commit da735ad9b58b76d27c580a9feb63f14b2cc0669d.
This commit is changing the behaviour of glusterd during its
initialization. The removed piece of code checks whether the
file mentioned in the path exists or not, if not it returns
-1. This return value is considered for the sub sequent
operations. By removing this code, we always return 0 and
some part of the code will not be executed in the following
code path.
glusterd_options_init() -> glusterd_store_retrieve_options() ->
gf_store_handle_retrieve()
In glusterd_options_init(), we are not executing any code
if the ret value is 0.
ret = glusterd_store_retrieve_options(this);
if (ret == 0) {
goto out;
}
as we are not executing any code if the return value is 0,
we are unable to enable the brick-multiplex feature using
volume set.
fixes: bz#1786459
Change-Id: I4f52b7b2ea8adb8df5087bb96927e9bb7db5b491
commit 9266ab94a55d5c4c49b5df4429fd11293907ae70
Author: Barak Sason <bsasonro@redhat.com>
Date: Thu Oct 24 16:28:31 2019 +0300
libglusterfs/logger - code cleaning
Fixes: bz#1765186
1 - Removed code duplication of 'log_levles' array
2 - Declared all static methods at the begining of the .c file
3 - Removed unused structs that existed in the .c file
Change-Id: I37330cb133fc65deac69b7ca60779f70501c24ea
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit 5b0c0bff48fd233c6621611b9a6658431cab575f
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Dec 3 15:28:13 2019 +0200
md-cache.c: move cache-swift-metadata to off by default
This causes mdc_xattr_list_populate() NOT to add "user.swift.metadata"
as an xattr in the list of attrs we look at in some paths of the code.
This is documented @
https://github.com/gluster/glusterfs/issues/775
Change-Id: Ie3d676c74a2f333beeacc302e253efe9f9942d1a
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit d06ddec591119c67644069daad4d03b7f71da3eb
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Nov 25 15:45:27 2019 +0200
store.c: remove a sys_stat() call - just open the file
I don't see the value on performing a sys_stat() on a path
instead of just trying to open the file.
Change-Id: Ib3f88d8c45aea091eafea17c4be02e2acdb713f1
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 33136e61814dbeffc60bf966f2b53b109f317d95
Author: yatipadia <ypadia@redhat.com>
Date: Mon Nov 4 21:04:45 2019 +0530
afr_inode/xlator: structure logging
convert gf_msg() into gf_smsg()
Change-Id: I8f5b7bbb9caa78902b06f67257502b67adab7405
Updates: #657
Signed-off-by: yatipadia <ypadia@redhat.com>
commit c969b93d06f95eaf76025b1e747a5d9f37b0841b
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Nov 20 22:31:48 2019 +0530
tests/fuse/bug-965974.t: turn off md-cache, to fix failure of the test
Imagine the following set of operations:
1. touch $M0/file
2. ln $M0/file $M0/file.lnk
3. rm $M1/file
4. wait for md-cache-timeout
5. stat $M0/file.lnk $M0/file
stat on $M0/file in step 5 succeeds when md-cache-timeout is non-zero
even though it was removed from $M1. The reason is
1. fuse-bridge on $M0 would resolve both file and file.lnk to same
inode. This inode i1 is cached in md-cache.
2. After md-cache-timeout lookup on $M0/file.lnk would be sent to
backend. This lookup will be successful as file.lnk is present on
backend and would refresh the md-cache.
3. The lookup on $M0/file sent within md-cache-timeout after lookup on
$M0/file.lnk would be sent with i1. Since i1 was refreshed by
lookup on $M0/file.lnk, the cache is deemed valid and md-cache
responds lookup on $M0/file as success
To fix this failure we can either:
1. remove lookup on $M0/file.lnk, so that lookup on $M0/file is
actually sent to backend.
2. turn off md-cache
This patch chooses option 2.
credits: Csaba Henk <csaba@redhat.com>
Change-Id: I352c2acd377fe10c4bdf3b6e53c1de86a4e544c7
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1756900
commit 63386b5e41eeba0f5a1e7027f2fae3cf7642205d
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Thu Dec 5 16:57:28 2019 +0300
glfsheal: install as architecture-dependent binary helper
Since glfsheal is a binary helper which is not intented to be
invoked directly, install it under %{libexecdir}/glusterfs rather
than %{sbindir}, adjust invocation from CLI code and RPM spec.
Credits: Ravishankar N <ravishankar@redhat.com>.
Fixes: bz#1780190
Change-Id: I4b41892d96b89c24a332470ac8c1e82f6795159a
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
commit 97d798869aabc5ad08c9b8dc1110684d2b1b8124
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Oct 28 21:29:50 2019 +0200
cli-rpc-ops.c: cleanups
1. Move functions and structs to static
2. Use dictionary functions with fixed key length.
3. Reduce key length when not needed.
4. Use const char* for some messages.
5. Use fixed strings for some logs which is repeated in the code.
6. Remove redundant checks. Specifically, cli_to_glusterd() does
NULL checks already, so no need to do it before calling it.
7. Aligned some messages - not sure why they were cut over several
lines, but it made grep on the code harder.
8. Move dictionary fetching of values closer to where they are
actually used.
Overall, object size is ~4 smaller, hopefully without functional changes.
There's more that can be done, but as this is a very long (>10K lines)
file, I think it's enough for one change.
Specifically, some functions fetch values from the dictionary
without using it - this is a bit of a waste.
Filed https://github.com/gluster/glusterfs/issues/753 about it.
Change-Id: I31f88d94ab25398e00aef2ea84a8c4af9383b75b
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 42e1764f5994087b8633e1367f465e092b41a391
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Tue Nov 5 15:54:29 2019 +0200
glusterd: refactoring long method
- Refactored set_fuse_mount_options(...) in order to shorten it.
- Removed dead code and moved some method to it's apropriate
location.
- Converted loggin in set_fuse_mount_options(...) to structured logs
fixes: bz#1768896
Change-Id: If865833d4c60d517da202871978691ef21235fe4
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 1be8c13808610814eccfba9e698ada5f9ae2ad75
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Dec 16 12:52:41 2019 +0000
test: fix non-root test case for geo-rep
Problem:
On a freshly installed system non-root geo-rep test case gets blocked.
Solution:
On a freshly installed system, the remote key need to be accepted automatically by ssh-copy-id.
Credits: M. Scherer <mscherer@redhat.com>
Change-Id: I5077f99a6681660f7e3e84c25ef216f521b7c29c
Fixes: bz#1779742
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 05c8a92ee95ae1be1209c21758cb7010a2e1f4c4
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Dec 3 12:57:13 2019 +0200
#ifdef gNFS related code if we are not compiling gNFS
If we are not compiling gNFS (--enable-gnfs is not given in the
./configure script params), there is little point in compiling code
that is related to it.
This patch tries to eliminate it.
My hope (and it's not clear from the code ) is that I did not break
the NFS Ganesha support as well.
Other than that, tried to compile with and without anad it looks sane.
Change-Id: I8d6c98066b9fceab4ec10fc6f5e81ab069e853bd
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit ee6817cf21e3a1ee34f78e98f631748185927010
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Dec 17 15:52:30 2019 +0530
glusterd: unlink the file after killing the process
In glusterd_proc_stop(), after killing the pid
we should remove the pidfile.
fixes: bz#1784375
Change-Id: Ib6367aed590932c884b0f6f892fc40542aa19686
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 311e64ea710337cbd3acc262e436c93fd54a7772
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Dec 12 08:12:44 2019 +0200
call-stub.c: remove redundant validation
GF_VALIDATE_OR_GOTO("call-stub", frame, out) is removed.
It's not needed, since we are testing via the creation of a stub,
in stub_new() that frame is not NULL.
Removed all redundant checks, which saves >10% in object size.
Change-Id: If4ce3a3dc506a5e65e98b59fa51b1fdd389a85ba
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit e1fa3dacf83e0f16aae0888b4c9e96a1497ac74c
Author: kshithijiyer <kshithij.ki@gmail.com>
Date: Sat Nov 30 15:25:11 2019 +0530
Removing old log rotate command.
The old command for log rotate is still present removing
it completely. Also adding testcase to test the
log rotate command with both the old as well as the new command
and fixing testcase which use the old syntax to use the new
one.
Code to be removed:
1. In cli-cmd-volume.c from struct cli_cmd volume_cmds[]:
{"volume log rotate <VOLNAME> [BRICK]", cli_cmd_log_rotate_cbk,
"rotate the log file for corresponding volume/brick"
" NOTE: This is an old syntax, will be deprecated from next release."},
2. In cli-cmd-volume.c from cli_cmd_log_rotate_cbk():
||(strcmp("rotate", words[2]) == 0)))
3. In cli-cmd-parser.c from cli_cmd_log_rotate_parse()
if (strcmp("rotate", words[2]) == 0)
volname = (char *)words[3];
else
fixes: bz#1750387
Change-Id: I56e4d295044e8d5fd1fc0d848bc87e135e9e32b4
Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
commit 5b1483e636634b8d5bbd30804e6ccb4d376f872a
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Tue Nov 26 12:36:16 2019 +0200
DHT - Reduce methods scope (dht-common.c)
Methods that should have been static were defined as global, and the
other way around.
This patch fixes the issue in order to enforce encapsulation.
updates: bz#1776757
Change-Id: I3eb5781849c5e597c1dd347e03f356c00db62a39
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 45ba451af561d3f5b489195b5ff048833f7af571
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Oct 22 15:41:41 2019 +0300
dht-common.h/dht-helper.c: exctract the LOCK() from DHT_UPDATE_TIME
Currently, the code (and only place) that is using this macro is
in dht_inode_ctx_time_update() where it is called 3 times in a row,
which is essentially 3 cycles of LOCK/UNLOCK on the same lock.
Instead, extract the LOCK()/UNLOCK() part of the macro
and wrap those calls with it.
Change-Id: I6312b985e3d97517857b55f342440accc4063db6
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 0b89e83265e3ef2a391314a485cb7a6fb764bd7a
Author: Andrew Miloradovsky <andrew@interpretmath.pw>
Date: Mon Dec 2 17:36:48 2019 +0300
rpc: define xdr_sizeof regardless of whether IPv6 is the default
Change-Id: I4f20f376d82b28e1c572c0fd0b6cd38e97b133da
Fixes: bz#1780260
commit c6be8553496cf18e86aedcec0ba7c868a0cd86ce
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Dec 11 18:21:14 2019 +0100
socket: fix error handling
When __socket_proto_state_machine() detected a problem in the size of
the request or it couldn't allocate an iobuf of the requested size, it
returned -ENOMEM (-12). However the caller was expecting only -1 in
case of error. For this reason the error passes undetected initially,
adding back the socket to the epoll object. On further processing,
however, the error is finally detected and the connection terminated.
Meanwhile, another thread could receive a poll_in event from the same
connection, which could cause races with the connection destruction.
When this happened, the process crashed.
To fix this, all error detection conditions have been hardened to be
more strict on what is valid and what not. Also, we don't return
-ENOMEM anymore. We always return -1 in case of error.
An additional change has been done to prevent destruction of the
transport object while it may still be needed.
Change-Id: I6e59cd81cbf670f7adfdde942625d4e6c3fbc82d
Fixes: bz#1782495
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 12e8c36f55c357a9f03f6c85695e0a7aaf41ed15
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Nov 7 15:18:30 2019 +0530
afr: make heal info lockless
Changes in locks xlator:
Added support for per-domain inodelk count requests.
Caller needs to set GLUSTERFS_MULTIPLE_DOM_LK_CNT_REQUESTS key in the
dict and then set each key with name
'GLUSTERFS_INODELK_DOM_PREFIX:<domain name>'.
In the response dict, the xlator will send the per domain count as
values for each of these keys.
Changes in AFR:
Replaced afr_selfheal_locked_inspect() with afr_lockless_inspect(). Logic has
been added to make the latter behave same as the former, thus not
breaking the current heal info output behaviour.
fixes: bz#1774011
Change-Id: Ie9e83c162aa77f44a39c2ba7115de558120ada4d
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 8609b7b41c1fa0d9d2fe5a8a4de073fb54b0d381
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Tue Dec 3 13:53:34 2019 +0800
contributors: map domain names for CMSS
updates: bz#1193929
Change-Id: Iaf1e1e3f787855ede1e94101ec0364084e534d61
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit 55226c97f76cf4f25f8756bf7c119afdd4c33f3f
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Mon Dec 2 13:20:02 2019 +0800
fuse: add missing unlock
updates: bz#1193929
Change-Id: I50f75f730ea6970e99347fcee661ce9dc8477725
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit 125f76d6e39a255ca3ada8d56155dcaca766b455
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Dec 10 08:35:23 2019 +0530
rpc: event_slot_alloc converted infinite loop after reach slot_used to 1024
Problem: In the commit faf5ac13c4ee00a05e9451bf8da3be2a9043bbf2 missed one
condition to come out from the loop so after reach the slot_used to
1024 loop has become infinite loop
Solution: Correct the code path to avoid the infinite loop
Change-Id: Ia02a109571f0d8cc9902c32db3e9b9282ee5c1db
Fixes: bz#1781440
Credits: Xavi Hernandez <xhernandez@redhat.com>
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit d2672b07042df68ea3bd84a43c845cc67c71e09a
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Sun Dec 1 12:26:53 2019 +0200
afr/self-heald - Missing error logs
As a follow up on https://review.gluster.org/#/c/glusterfs/+/23749/,
adding error logging for the entire method.
In addition, converted logging to structured logging in the method.
Fixes: bz#1778457
Change-Id: I1f412159e6849d6f6ddbde53ec4a85ad709bbdf4
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit 98d0f1f31ec0e2b1679e49e971456833a9ec04b3
Author: Anoop C S <anoopcs@redhat.com>
Date: Fri Nov 22 17:36:55 2019 +0530
extras/hooks: Remove smb.conf parameter allowing guest access
Change-Id: I88f494f16153d27ab6e2f2faf4d557e075671b10
Fixes: bz#1775612
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit e291ce5f48189ba7c1e108b94bbc860777282d7f
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Tue Dec 3 12:13:16 2019 +0200
cloudsync - fixing a coverity issue
A negative value was being passed where it shouldn't have been passed
to. Modified code so only a positive value will be passed.
fixes: CID#1274209
Change-Id: I5452ddded77664fdd8b5c975af6bc77806a7ffb1
updates: bz#789278
commit 1dec1d663be75e05816feee9dc1754f4ea2d9870
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Nov 18 05:24:33 2019 -0500
ctime: Fix ctime inconsisteny with utimensat
Problem:
When touch is used to create a file, the ctime is not matching
atime and mtime which ideally should match. There is a difference
in nano seconds.
Cause:
When touch is used modify atime or mtime to current time (UTIME_NOW),
the current time is taken from kernel. The ctime gets updated to current
time when atime or mtime is updated. But the current time to update
ctime is taken from utime xlator. Hence the difference in nano seconds.
Fix:
When utimesat uses UTIME_NOW, use the current time from kernel.
fixes: bz#1773530
Change-Id: I9ccfa47dcd39df23396852b4216f1773c49250ce
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit fec995d4e63c1038c01bb51507efd990abd1ce1f
Author: Andrew Miloradovsky <andrew@interpretmath.pw>
Date: Mon Dec 2 13:23:16 2019 +0300
git-ignore .dirstamp
Change-Id: I8a0191252c017bda9e9d42f9622504698bf6e7da
Fixes: bz#1776892
commit ce8dd1f28069df69772e427f9e19edfd5f875b2d
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Dec 3 10:29:37 2019 +0530
cluster/dht: Add comments to code
Change-Id: Ieb7531af19ae89fb8a8387e81663c7f157b10c02
Updates: bz#1765421
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 300fc42e74eef939b51ea08c013c65f6d64e1f96
Author: HuangShujun <549702281@qq.com>
Date: Thu Dec 5 10:07:10 2019 +0200
To fix readdir-ahead memory leak
Glusterfs client process has memory leak if create serveral files under one folder, and delete the folder.
According to statedump, the ref counts of readdir-ahead is bigger than zero in the inode table. Readdir-ahead get parent inode by inode_parent in rda_mark_inode_dirty when each rda_writev_cbk,the inode ref count of parent folder will be increased in inode_parent, but readdir-ahead do not unref it later.
The correction is unref the parent inode at the end of rda_mark_inode_dirty
Fixes: bz#1779055
Signed-off-by: HuangShujun <549702281@qq.com>
Change-Id: Iee68ab1089cbc2fbc4185b93720fb1f66ee89524
commit 5bbb64fdd3fb9022757368a51fa2f0bd9cfc7857
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Sep 6 14:47:04 2019 +0530
cluster/ec: Scripts to find and reset files which can be healed.
gfid_needing_heal_parallel.sh - Finds out if a file is healable or not.
correct_pending_heals.sh - Makes necessary changes in xattrs to enable
heal for those files which could be healed.
fixes: #723
Change-Id: I38177888df0fda9486343ee546dc02836b06a5fc
commit f4edf41c30904052922be3ae08ca63c0e6179439
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Oct 22 19:03:13 2019 +0530
core: fix spelling mistakes
fixes: bz#1728554
credits: Patrick Matthäi <pmatthaei@debian.org>
Change-Id: Id08dabf54a529dbb86666b544b1f0859aab75aac
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 4b3e55b61e133d526086f0812ca7e5ea86b6d6f6
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date: Wed Dec 4 15:46:16 2019 +0300
core: avoid NULL pointer dereference
Since low-level __gf_xxx allocation function may be called before
ctx is initialized, add extra check for NULL where appropriate.
Fixes: bz#1776784
Change-Id: I3127fa4b93f8e3e5846106aadcfed1baa27ac43f
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
commit ac27bea7a4880f50f5f331d1fe27e8d30ee583f2
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Nov 26 17:03:44 2019 +0530
glusterd: set xaatrs after checking the brick order
Problem: When volume creation fails complaining about
the bricks from same hosts for replica volumes, the
bricks can't be re-used to create any volume without
using force at the end. It says, brick is already part
of a volume.
Reason: When volume create opeartion issued, we set
xattrs on the bricks. If the transaction fails in later
checks, the xattrs will remain on the brick. When the
brick is re-used, by looking at the xattrs, glusterd
thinks it is already part of volume.
Solution: Check the brick order for replica and disperse
volumes before setting the xattrs.
fixes: bz#1776801
Change-Id: I44a971b37f520e5a20dc9fad6520286d315063b9
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit e1f6a22635e233a5c5451e6baf1c45367e379a1d
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Nov 25 16:35:42 2019 +0530
glusterd: start glusterd automatically on abnormal shutdown
If glusterd crashes or goes down abnormally, systemd should
automatically bring the glusterd up.
With this change, systemd brings glusterd up for atmost 3 times
within time period of 1 hour. If the limit exceeds, we have to
start the glusterd manually and reset the failure count using
systemctl reset-failed.
credits: John Strunk <jstrunk@redhat.com>
fixes: bz#1776264
Change-Id: I312d243652fb13ba028814a2ea615b67e3b10b6a
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 7fa5ea1b381f23a67fa1cc7325e6371d2677d138
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Tue Dec 3 13:39:47 2019 +0800
glusterd-store: fix Coverity CID 1407767
To avoid memory leak.
updates: bz#789278
Change-Id: I321c65a66c9ac372d059aa3ca89a989c6089979e
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit 165c0010280713e213af2b06f2c24558740ee9da
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Fri Nov 29 17:07:14 2019 +0530
MAINTAINERS: add Xie Changlong and Amar Tumballi as peers for gNFS
* Change status of gNFS from Deprecated to Odd Fixes
More discussion on this @ thread in gluster-devel:
https://lists.gluster.org/pipermail/gluster-devel/2019-November/056685.html
Change-Id: I119f588f3ad07fa55764ee7cf7db42905e19ee1b
Updates: bz#1193929
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit e9f1fb6718af6101d15c4cddfa52c46fd9674747
Author: Vishal Pandey <vpandey@redhat.com>
Date: Thu Nov 21 12:56:34 2019 +0530
man/gluster: Add volume top command to gluster man page
Change-Id: Ib74607d2b2e5a1a0316221f1176a7dcccea632d4
Fixes: bz#1774866
Signed-off-by: Vishal Pandey <vpandey@redhat.com>
commit e081ac683b6a5bda54891318fa1e3ffac981e553
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Nov 3 15:21:05 2019 +0200
glusterd-op-sm.c (and others) - improve glusterd_op_stage_set_volume()
Multiple changes to the function in the hope to make it somewhat faster.
1. Checking for key length against constant strings before calling
strcmp() to save some calls.
2. Verifying if a match was already made against the key to reduce
yet more checks.
3. Alignment of error message when they can fit on less lines - just
makes 'grep' on the code for error messages easier and it's more
readable.
4. Multiple functions where call _gd_get_vmep() one by one.
Instead, extracted it to be callable (it was static) and re-used
its result, instead of calling it again and again.
5. Removed some unneeded include statement.
6. Removed redundant null checks.
Hopefully, no functional changes.
Change-Id: Id281224e49adeca6757f96653b4cb13c7c9ba8c9
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 9c96b89ec86e35850888eadee9cfb6a4e7229ecc
Author: Amar Tumballi <amar@kadalu.io>
Date: Sun Nov 17 11:00:50 2019 +0530
debug/io-stats: add an option to set volume-id
'volume-id' is good to have for a graph for uniquely identifying it.
Add it to graph->volume_id while generating volfile itself.
This can be further used in many other places.
Updates: #763
Change-Id: I80516d62d28a284e8ff4707841570ced97a37e73
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit 248bcecccb454576174dff22ff6bbf33bc1ebb63
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Nov 28 10:31:11 2019 +0530
MAINTAINERS: Add Nithya to past contributors section
Change-Id: I18195a61314946930db669fcf72703a7a18f43a1
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
updates: bz#1193929
commit 5c7c95a06a2c97f29ab52885112f4deb79a2f349
Author: Barak Sason Rofman <bsasonro@redhat.com>
Date: Sun Nov 24 18:16:54 2019 +0200
cluster/afr - coverity issue fix
Added a log for a failure in order to avoid "unused variable" coverity
issue.
fixes: CID#1274209
Change-Id: Ibc6b0ab4bdff482096e42e88fd4c8c7eadfeeadb
Updates: bz#789278
Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
commit d1ea46c6e283daf72b5303af7a07887fa89cf456
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Nov 28 07:19:13 2019 +0000
Revert "afr: make heal info lockless"
This reverts commit fce5f68bc72d448490a0d41be494ac54a9181b3c.
I merged the wrong patch by mistake! Hence reverting it.
updates: bz#1774011
Change-Id: Id7d6ed1d727efc02467c8a9aea3374331261ebd5
commit b7dc465ea116f9404f0dba594859099a92e00e46
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Nov 7 15:18:30 2019 +0530
afr: make heal info lockless
Changes in locks xlator:
Added support for per-domain inodelk count requests.
Caller needs to set GLUSTERFS_MULTIPLE_DOM_LK_CNT_REQUESTS key in the
dict and then set each key with name
'GLUSTERFS_INODELK_DOM_PREFIX:<domain name>'.
In the response dict, the xlator will send the per domain count as
values for each of these keys.
Changes in AFR:
Replaced afr_selfheal_locked_inspect() with afr_lockless_inspect(). Logic has
been added to make the latter behave same as the former, thus not
breaking the current heal info output behaviour.
fixes: bz#1774011
Change-Id: I9ae08ce768b39aeb6ee230207b5b7fa744176952
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 3d2e2a51c2e52381c56bd0aa113247595d529722
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Nov 5 20:37:38 2019 +0200
common-utils.c: add gf_strn2boolean() function
The function takes a string and its length and based on it
returns if it's a boolean. It's identical in functionality
to gf_string2boolean only with far less string comparisons since
it takes into account the length of the string.
dict_get_str_boolean() has been converted to use it.
Other cases of gf_string2boolean() across the code base can be
converted as well, but more importantly, they should be converted
from dict_get_str() and then calling to gf_string2boolean to
simply call dict_get_str_boolean(), which would take care of this
for them.
This is therefore a first step in the conversion.
Change-Id: I9ee93abfc676f6e123a3919d8df8c25e8848b799
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 63bbe4b491e18ee2f86e11297f99978c5a17961d
Author: root <root@dhcp35-62.lab.eng.blr.redhat.com>
Date: Tue Nov 26 10:30:17 2019 +0530
Maintainers: Remove Nithya as maintainer/peer
Change-Id: I9512a70622b51416174ff0936f8d02e3c0178e19
Updates: bz#1193929
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
commit ea18a98aa1fe20b1587816f3368bad5eabcf072c
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Nov 25 17:39:07 2019 +0200
glusterfsd.c: remove sys_lstat() call
get_volfp() in glfs.c doesn't use it, so get_volfp() in glusterfsd.c
can just open the file without the stat call as well, IMHO.
Change-Id: I3cb5bf12a09b5be42aa2ee4f432f8d351eee5b9e
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 1d2a3608623d5bb0883240832c6fa9e0cf0cc7b4
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Nov 25 15:37:46 2019 +0200
store.c/glusterd-store.c: remove sys_stat calls
Instead of querying for the file size and allocating a char array
according to its size, let's just use a fixed size.
Those calls are not really needed, and are either expensive or
cached anyway. Since we do dynamic allocation/free, let's just use
a fixed array instead.
I'll see if there are other sys_stat() calls that are not really
useful and try to eliminate them in separate patches.
Change-Id: I76b40e78a52ab38f613fc0cdef4be60e6253bf20
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit f01d4aacc7d6e6b62b59547a70bb97587da32c27
Author: Amar Tumballi <amar@kadalu.io>
Date: Tue Nov 26 12:53:11 2019 +0530
pcsvc: fix subnet_mask_v4 check
The check we had for subnet mask validation wasn't checking in
proper sequence. Corrected the order of calling `inet_pton()` as
the fix.
Fixes: #765
Change-Id: I5d31468eb917aa94cbb85f573b37c60023e9daf3
Signed-off-by: Amar Tumballi <amar@kadalu.io>
commit c8730249a38d88bfb3c177690e3dd33b377fbc4d
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Nov 25 21:00:59 2019 +0200
posix-inode-fd-ops.c: excute sys_fstat() only when needed
It appears that in posix_do_futimes() we may not need to
unconditionally execute sys_fstat(). Avoid it and use the
existing stbuf atime and mtime if possible.
If not, we execute it.
Change-Id: I0bdd471e5c821fcd28f057c75046c673a212d347
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 2def277c56ba7100531d129ac07e3ad1f889b2e3
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Oct 4 23:14:08 2019 +0300
cli-*: make some structs static to reduce space consumed.
There's a small difference when structs are defined static.
Whenever possible, define them as such.
Specifically, before:
text data bss dec hex filename
678 216 0 894 37e ./cli/src/cli-cmd-misc.o
150024 1264 16 151304 24f08 ./cli/src/cli-rpc-ops.o
71980 64 0 72044 1196c ./cli/src/cli-cmd-parser.o
66189 4 16 66209 102a1 ./cli/src/cli-xml-output.o
After:
text data bss dec hex filename
670 216 0 886 376 ./cli/src/cli-cmd-misc.o
149848 1392 16 151256 24ed8 ./cli/src/cli-rpc-ops.o
70346 1320 0 71666 117f2 ./cli/src/cli-cmd-parser.o
66157 4 16 66177 10281 ./cli/src/cli-xml-output.o
Change-Id: I206bd895290595d79fac7b26eee66f4279b50f92
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 9694991904274ca64ab829728f08d514aeda848c
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Nov 18 22:20:01 2019 +0200
glusterfsd-mgmt.c: move INFO log outside a LOCK
In glusterfs_handle_attach() we can:
1. Move an INFO level to be executed before the LOCK.
2. Skip the LOCK altogether, if there's no active graph.
I hope it's safe - I've seen that in other functions
you could look at ctx->active outside of a lock.
Change-Id: I3e1ec5b1430d5fddee46883d468ff4f5bd6ca54b
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 3937315690eac84c0c34075607c231385279a2d3
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Nov 4 15:25:27 2019 +0200
socket.c: minor changes
1. Remove dead code and declarations
2. Move some dict functions to use more efficient ones.
3. Use more constants, where possible.
4. Align messages - easier to grep the code for them.
5. Aligned structures and adding padding where needed.
Change-Id: Ifc2639afe65a935fab5238d3e4a121b662836d3d
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 863bf73255cd6bda9d9b9f3458fa38b4d5d753a8
Author: Amar Tumballi <amarts@gmail.com>
Date: Thu Oct 17 12:39:02 2019 +0530
libglusterfs: remove unused gfdb specific files from repo
Updates: bz#1193929
Change-Id: Idb98394c51917e9b132aeb32facccd112effe672
Signed-off-by: Amar Tumballi <amarts@gmail.com>
commit 430c5a100565d28d9623a19a136778f169bb1a43
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Oct 28 21:53:01 2019 +0530
posix: Improve MAKE_HANDLE_PATH
Pass the maximum buffer (PATH_MAX) to posix_handle_path to
avoid the posix_handle_path call again.
Change-Id: I7d18313870218dc028c5f7fc94d6ec85a2bdb332
Updates #761
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 8c3fa162faa2e0908771b81f2005f59508cd267e
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Nov 5 18:05:38 2019 +0200
glusterd-volgen.c: improve volgen_graph_set_options_generic()
Skip fetching "skip-CLIOT" unconditionally on every
invocation of volgen_graph_set_options_generic().
Instead, fetch only if the vme->key matches to it.
We calculate the length of vme->key (but we would have
done it anyway in dict_get() later on, so now we can use
dict_getn() instead and re-use that key length) and check
if the lengths match before doing a strcmp() between them.
Lastly, if they match, we actually do the fetch.
Change-Id: I9d9a7104f9e920bf81477128adb5fc87f5d30627
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 1fcca058bc20cb3bc0dd49d0b4acfdd0e6a5d18a
Author: Amar Tumballi <amarts@gmail.com>
Date: Wed Nov 13 11:12:02 2019 +0530
extras: fix the remote subvol name in case of thin-arbiter
* Also make sure to provide log-level in systemd file,
instead of volfile itself.
Updates: bz#1193929
Change-Id: I45a0b0ff3ebb4b3e095b4eed14b7bdf5816926d0
Signed-off-by: Amar Tumballi <amarts@gmail.com>
commit a697772a2172a69e0b755d4ce5e58a43f0921920
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Oct 25 11:25:06 2019 +0530
cluster/dht: Add comments to the code
Add comments to the code to explain what is
being done and why.
Change-Id: I50831d7bd4bb73e75f6cda05fafaeb5a8619baae
Updates: bz#1765421
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 1f20eaca94a239790164ac6888342aabfa3fb2b8
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Nov 13 15:39:59 2019 +0530
afr: fix log flooding
Commit "ccf33e789 - dict.c: remove redundant checks"
removed some NULL checks in certain dict functions. This caused
flooding of fuse mount logs when I/O was done on the mount on a replica
volume:
Message:
W [dict.c:1478:dict_get_with_refn]
(-->/usr/local/lib/libglusterfs.so.0(dict_get_uint32+0x4d)
[0x7ff9121ec963] -->/usr/local/lib/libglusterfs.so.0(dict_get_with_ref+0x90)
[0x7ff9121eb93f] -->/usr/local/lib/libglusterfs.so.0(+0x229be)
[0x7ff9121eb9be] ) 0-dict: dict OR key (glusterfs.lk.lkmode) is NULL [Invalid argument]
Fix:
In the relevant AFR functions, check that dict is not NULL before trying
to perform operations on it.
See bug description for more details.
fixes: bz#1772006
Change-Id: I30c89c0b5d6c80cc86a6047aae70127769412120
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 620b7bf7694c2ff203b835a9fddd361672acebff
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Nov 13 08:23:09 2019 +0530
ssl/test: ssl test case is failing when using specific cipher
Problem: On RHEL-8 ssl test case is failing when trying to
connect with a peer after using the specific cipher.
Solution: If cipher is not supported by openssl on rhel-8 then
test case is failed.To avoid the issue validate the
cipher before connecting with peer.
Change-Id: I96d92d3602cf7fd40337126c8305a3f8925faf9b
Fixes: bz#1756900
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 3775ec87ab472914f3a830c2e3b84f917d428d9d
Author: MOHIT AGRAWAL <moagrawa@redhat.com>
Date: Wed Nov 13 12:42:13 2019 +0000
Revert "dict.c: remove redundant checks"
This patch floods of dict_log at the time accessing key from dict if
dict is not valid so revert the patch.
This reverts commit ccf33e789f2cbd202e21340f684e2140d844a129.
Change-Id: I81fa3b080a2f784254b519044ad284858583ec66
updates: bz#1193929
commit 1881eb91426412cd14667b3c591f68d3bf5a9843
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Nov 13 13:48:28 2019 +0530
geo-rep: Improve debugging
When gsyncd failed with tracebacks during start, it prints
only exception object but not the error string. This patch
adds the error string as well.
Earlier:
"failed with ImportError"
Now:
"failed with ImportError: No module named _io."
fixes: bz#1771895
Change-Id: I0d772a250d4c2010a0c35053aa7b165b71f8434e
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 23fc10db0785716d600d5f88db6b066486890682
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Nov 11 11:25:03 2019 +0530
cluster/dht: Don't skip entries with invalid stat
Don't strip out entries with invalid stats in
dht_readdirp_cbk.
Change-Id: I136ab342762d020a3c0f43e51e0090aed2af4120
Fixes: bz#1769754
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit aeb0081996aff71d8586e9be768972f039542778
Author: Niklas Hambüchen <mail@nh2.me>
Date: Wed Nov 13 12:19:54 2019 +0530
api: Fix documentation path in README
Ref: #84
Updates: bz#1193929
Change-Id: If346dbe421d3e301ae035165b2e01ee0a7176d36
Signed-off-by: Amar Tumballi <amarts@gmail.com>
commit 39c26800c8cd757a6eb5cd5bbd8a7177a4e852a2
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Nov 6 09:52:56 2019 +0200
gluster-volgen.c: remove more of JBR and FDL xlators
the JBR and FDL experimental xlators were apparently removed.
Removed additional leftovers scattered in the code.
Change-Id: I78b6fa5fd9044dc48cdcb1fb094b8c267c2d1323
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit cdc88eabbb97da251684719e79fe61fcaca8c130
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Nov 12 21:53:20 2019 +0530
geo-rep: Fix py2/py3 compatibility in repce
Geo-rep fails to start on python2 only machine like
centos6. It fails with "ImportError no module named _io".
This patch fixes the same.
fixes: bz#1771577
Change-Id: I8228458a853a230546f9faf29a0e9e0f23b3efec
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 6e17986fb1cf71472a8e90706a3f41abf7748cef
Author: Xi Jinyu <xijinyu@cmss.chinamobile.com>
Date: Tue Nov 12 01:37:40 2019 -0500
libglusterfs/dict.c: Fix memory leaks.
fixes: bz#1771365
Change-Id: Id31687c4704cbbfea1084f912ed0420c7d1cc1ec
Signed-off-by: Xi Jinyu <xijinyu@cmss.chinamobile.com>
commit b38f5a96c7ac0d75662a8529b12e3d724d92e9da
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Thu Nov 7 17:35:45 2019 +0800
gluster: check ctx->active
To avoid process "TRANSLATOR INFO" "BARRIER" if graph is not ready,
also see commit ee630e25.
Updates: bz#1769712
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Change-Id: Ibd446a35962206d3689667cda7e6712d72e4ec2f
commit ba7fb89382a41b32441165c9ea475f2173cb21f7
Author: Amar Tumballi <amarts@gmail.com>
Date: Fri Oct 25 22:57:04 2019 +0530
MAINTAINERS: revised the maintainers list after 2 years
The last major change to the file happened 2 years 5 months back.
For the better health of the project, and to motivate the active
contributors, and keeping the file up-to-date with who is working
on what, it is critical for us to keep refreshing the file once
every 2 years (at least).
This is one such effort.
Highlighted changes:
* Moving both Jeff and Vijay from Maintainers to 'Special Thanks'
section.
* Moving Amar and Xavi as Maintainers, and Atin as Peer, mainly
looking at the activities (patches, reviews, merges) across
the codebase, and also the contributions in discussions.
* Moving Shyam and Niels out of Peer list highlighting the 6+
months of changed priorities.
* Changed Xavi's contact from Datalab's to Red Hat's
* Changed Amar's contact from Red Hat's to his Personal.
* Removed:
- Block Device (BD)
- Experimental (RIO / JBR)
- Gluster Object
- Gluster Hadoop Plugin
- Nagios Monitoring
- GlusterD2 (and renamed glusterd1 to glusterd)
* Marked 'NFS (gluster-NFS)' component as 'Deprecated / Orphan'
* Moved few people, who stopped major contribution, mainly
because of changing companies, changing projects inside
their own company etc, to 'Special Thanks' section.
* Additions:
- Kotresh added as Peer in Posix
- Raghavendra Gowdappa added as Peer in FUSE Bridge,
Maintainer of readdir-ahead
- Nithya Added as peer in readdir-ahead
- Hari Gowtham as Peer in Quota, Maintainer in Releases
- Yaniv Kaul for xxhash
- Rinku Kothiya added as Peer in releases.
- Sheetal Pamecha and Shwetha Acharya added as Peers in
packaging for Debian/Ubuntu and OpenSUSE.
Updates: bz#1193929
Change-Id: I0d6eccfee4306e26cdbc2b94f43ac493e2c25a61
Signed-off-by: Amar Tumballi <amarts@gmail.com>
commit d453680922b18cde874b7c6c3ea2a63f69e51d79
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Nov 6 10:32:04 2019 +0530
glusterd: Client Handling of Elastic Clusters
Configure the list of gluster servers in the key
GLUSTERD_BRICK_SERVERS at the time of GETSPEC RPC CALL
and access the value in client side to update volfile
serve list so that client would be able to connect
next volfile server in case of current volfile server
is down
Updates #741
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I23f36ddb92982bb02ffd83937a8bd8a2c97e8104
commit 3d8c095063b35096e7f5c905e170d22efed6b846
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Oct 22 15:06:29 2019 +0530
cli: display detailed rebalance info
Problem: When one of the node is down in cluster,
rebalance status is not displaying detailed
information.
Cause: In glusterd_volume_rebalance_use_rsp_dict()
we are aggregating rsp from all the nodes into a
dictionary and sending it to cli for printing. While
assigning a index to keys we are considering all the
peers instead of considering only the peers which are
up. Because of which, index is not reaching till 1.
while parsing the rsp cli unable to find status-1
key in dictionary and going out without printing
any information.
Solution: The simplest fix for this without much
code change is to continue to look for other keys
when status-1 key is not found.
fixes: bz#1764119
Change-Id: I0062839933c9706119eb85416256eade97e976dc
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 4f086c73bfacd5c5c1026cb22eeba36ccf926887
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Oct 28 18:42:41 2019 +0530
posix: Improve MAKE_HANDLE_GFID_PATH and MAKE_HANDLE_RELPATH
Avoid one function call to set the gfid_path in buffer
Change-Id: If9b95801b05c34d262fac9a275492c794d12bf58
Updates #748
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 7b2f59ae92a979e1c7035204908a39e4ff3db82a
Author: l17zhou <cynthia.zhou@nokia-sbell.com.cn>
Date: Mon Nov 4 08:45:52 2019 +0200
rpc: Cleanup SSL specific data at the time of freeing rpc object
Problem: At the time of cleanup rpc object ssl specific data
is not freeing so it has become a leak.
Solution: To avoid the leak cleanup ssl specific data at the
time of cleanup rpc object
Credits: l17zhou <cynthia.zhou@nokia-sbell.com.cn>
Fixes: bz#1768407
Change-Id: I37f598673ae2d7a33c75f39eb8843ccc6dffaaf0
commit e8b923186ab13c5b2ac9cb8ed191637ceeeafd18
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Sep 27 12:22:23 2019 +0300
glusterfsd-mgmt: unify read and write tests
1. Both read and write tests required writing first. Either just
writing (write test) or write and then read (read test).
So the code is now unified.
2. There's no reason to read zeros from /dev/zero. Just use a
CALLOC'ed buffer.
I don't think we should read and write zeros, but I did not change
the code yet (I think compression and/or dedup will offset results)
It appears neither read-perf nor write-perf were tested, so added
basic tests for them.
Change-Id: I24b1f249fa0335ed652a8982e99c0687d940230e
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 29480543738b5d3e7f3a5cc8fc82e09b7c6141c6
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Oct 9 21:27:54 2019 +0300
dict.c: remove redundant checks
It removes ~2% of the object size, and did not add meaningful checks
whatsoever or to readability (IMHO).
Change-Id: I54346c2af47dcab13bd8d5c8ad52fc765e6afad4
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit db301b7c5acf07abdf3c4deec9c8eac68720b5b5
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Oct 2 08:13:57 2019 +0300
iobuf.c, h: minor fixes
- Align structures
- gf_iobuf_get_pagesize() will now also return the index, reducing the need
for an additional very similar call.
- Removal of an inefficient loop I've inadvertently added previously.
It was harmless, but just inefficient.
- New pool initialization does not need to be done under lock - no
one can touch that pool yet, so no need to protect it.
Change-Id: I61c50f2f14fa79edc131e515e9615a9928ee2dca
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit aa82b4af3ac67ecd303edf7d4c3536ea6150ce7c
Author: Csaba Henk <csaba@redhat.com>
Date: Sat Sep 21 00:00:07 2019 +0200
extras: add statedumpparse.rb
By default, the script mangles statedump records
to JSON, which has two benefits:
- easier machine processing
- more friendly with line oriented tools, as one
line will correspond to one record
'--format=memstat' is also available which displays
memory allocation types along the size of their allocations.
Change-Id: I1685d3afcea6009fbcfafb33798f85bcd645c82f
updates: bz#1193929
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 24a03f70fc5ed76566ccfa905772eeb293973979
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Jul 25 08:27:24 2019 +0200
Improve logging of fusedump creation failure
updates bz#1193929
Signed-off-by: Csaba Henk <csaba@redhat.com>
Change-Id: I12cbe1d87f60fb497654d0e13e12171940867f76
commit 531a86bae8366744122835090ef8335a3d6fe8cf
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Oct 23 10:10:12 2019 +0530
georep: Merge Worker and Agent as a single process
- libgfchangelog is simplified by removing unnecessary API Class
- Merged Agent logic into Worker instead of running Worker and Agent as
two separate processes and maintaining RPC between Worker and Agent.
- Geo-rep command Pause and Resume will continue without any changes.
But Agent functionality also gets paused with that.
Updates: #755
Change-Id: Ie2c00fa7dddf21f180f0649e0aaf084d29023c98
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 37c6280711161f8e0b7bff4d64a8314dce5b9267
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Oct 11 01:21:43 2019 +0300
cloudsync: remove dead code, unused variable
Minor changes - remove unused functions and unused variables.
Switch dict functions to use sizen() when relevant.
Change-Id: I737ce04a4beaf4df9b1eea25a90100d315627c14
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit bacb84095597f51648cd50f8e113c66e266043c5
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Oct 20 09:12:20 2019 +0300
posix-helpers.c (and others): minor changes to posix_xattr_fill()
posix_xattr_fill() is called from several POSIX functions.
Made minor changes to it and the functions called from it:
1. Dict functions to use known lengths (dict_getn() instead of dict_get(), etc.)
2. Re-ordered some static char[] arrays, to account (hopefully)
to the frequency of the xattrs usage (based on grep in the code...)
3. Before strcmp(), check if the strings lengths match.
4. Removed some dead code.
Hopefully, no functional changes.
Change-Id: I510c0d2785e54ffe0f82c4c449782f2302d63a32
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit bdee18a3cf42a271ca8448d9e5934f1c6117e78c
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Thu Oct 24 17:40:44 2019 +0530
scripts: quota_fsck script TypeError: %d format:not dict
Problem: One of the prints in the script have been using
%i as the format for printing which doesn't work.
Fix: use %s as the format in the place of %i
Fixes: bz#1764129
Change-Id: I4480ede7bf62906ddedbe5f880a1e89c76946641
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
commit 365a3e1e836d7055e4c77ec7719135098d7f4a52
Author: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
Date: Fri Oct 18 12:22:13 2019 +0530
barrier: structs re-alignment
Re-aligned a struct and added manual padding to avoid compile time padding.
Change-Id: I8c6fc67a1b635dc7d8e2522bd4fd8587c09f74e9
Updates: bz#1754448
Signed-off-by: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
commit 95c71aed856ff17f30a1823d017024bef7cd0277
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed May 22 17:36:11 2019 +0300
dict.c: remove one strlen() done under lock.
It's not needed in some cases, where we can pass the key length.
Change-Id: I2e8ed0b69c50a35f5858bae7c1755a0dfd2c77e5
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 5e3de5ce4d17e042b620c6c62a570251495dc652
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Jul 11 16:52:49 2019 +0530
cluster/ec: Change handling of heal failure to avoid crash
Problem:
ec_getxattr_heal_cbk was called with NULL as second argument
in case heal was failing.
This function was dereferencing "cookie" argument which caused crash.
Solution:
Cookie is changed to carry the value that was supposed to be
stored in fop->data, so even in the case when fop is NULL in error
case, there won't be any NULL dereference.
Thanks to Xavi for the suggestion about the fix.
Change-Id: I0798000d5cadb17c3c2fbfa1baf77033ffc2bb8c
fixes: bz#1729085
commit 252f936d89272556a3152a053ce66ec6d5386bcc
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Oct 31 18:13:16 2019 +0200
posix-entry-ops.c: pass correct key length in posix_skip_non_linkto_unlink()
As was found out in a different patch, passing a pointer
to a constant string still calculates the size of the pointer
and not the string. This is not catastrophic as the dictionary
is matching not just hashes but key names, but is certainly what
was intended to be done.
Instead, pass explicitly the key lenth.
I've looked for additional cases for such an issue and did not
find them, luckily.
Change-Id: I644a07a77dd541e9cf4886811ab54897e0c9d483
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 59c8b554ff37af4753dd24c300cde733224565bd
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Tue Oct 22 14:34:06 2019 +0530
tests/shard: fix tests/bugs/shard/unlinks-and-renames.t failure
on rhel8 machine cleanup of shards is not happening properly for a
sharded file with hard-links. It needs to refresh the hard link count
to make it successful
The problem occurs when a sharded file with hard-links gets removed.
When the last link file is removed, all shards need to be cleaned up.
But in the current code structure shard xlator, instead of sending a lookup
to get the link count uses stale cache values of inodectx. Therby removing
the base shard but not the shards present in /.shard directory.
This fix will make sure that it marks in the first unlink's callback that
the inode ctx needs a refresh so that in the next operation, it will be
refreshed by looking up the file on-disk.
fixes: bz#1764110
Change-Id: I81625c7451dabf006c0864d859b1600f3521b648
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 994f4f8f31293aac1ecedeb06969a50e29683b44
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Jan 5 19:53:19 2017 +0530
tools/glusterfind: handle offline bricks
Problem:
glusterfind is unable to copy remote output file to local node when a
remove-brick is in progress on the remote node. After copying remote
files, in the --full output listing path, a "sort -u" command is run on
the collected files. However, "sort" exits with an error code if it
finds any file missing.
Solution:
Maintain a map of (pid, output file) when the node commands are started
and remove the mapping for the pid for which the command returns an
error. Use the list of files present in the map for the "sort" command.
Change-Id: Ie6e019037379f4cb163f24b1c65eb382efc2fb3b
fixes: bz#1410439
Signed-off-by: Milind Changire <mchangir@redhat.com>
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 05d0d38c302fac63f32009082c9404de7c5c0970
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Oct 25 17:02:30 2019 +0530
MAINTAINERS: Add Sunny Kumar as co-maintainer of geo-rep
Change-Id: I774710273702f1d093601035435989d3caba449c
Signed-off-by: Kotresh HR <khiremat@redhat.com>
fixes: bz#1765542
commit c87552785ae54d223cf9057a4813d96550f4043f
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Oct 23 09:19:19 2019 +0530
MAINTAINERS: Add Sanju & Mohit as glusterd/cli maintainers
Fixes: bz#1764418
Change-Id: If14c5ce4527844df5251b4b5a720b617815fb1a1
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 3b90883ce7ed9b727bec85b02872dc7674d53117
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Oct 16 13:06:29 2019 +0530
afr: lock healing changes
Implements lock healing for gluster-block fencing use case.
If mandatory lock is enabled:
- Add domain lock/unlock to afr_lk fop.
- Maintain a list of locks to be healed in afr_private_t.
- Add lock to the list if afr_lk(F_SETLK or F_SETLKW) was sucessful.
- Remove it from the list during afr_lk(F_UNLCK).
- On child_down, mark lock as needing heal on that child. If lock is
lost on quorum no. of bricks, remove it from the list and mark fd bad.
- For fds marked as bad, fail the subsequent fd based fops.
- On parent up, traverse the list and heal the locks IFF the client is
the lk owner and has quorum. (shd does not heal any locks).
updates: #613
Change-Id: I03c46ceaea30f5e6236d5ec13f71d843d827f1bc
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit d28f01b63f9a27e33daf1777d7be61da6664b543
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Oct 24 17:58:03 2019 +0530
cluster/afr: Take a copy of xattr-req
Afr adds its own xattrs to the req, so it should take a copy of the
dictionary to prevent parent xlator re-using the modified xattr-req
to another subvolume
fixes: bz#1765155
Change-Id: I268e2dbd1b12323135d369e90a22a8bdde2cf7c2
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 9f58efb8d653d88d5f5729f5a1525675d67b5bca
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Mon Oct 28 17:43:28 2019 +0800
glusterd/ganesha: fix Coverity CID 1405785
To avoid double free
updates: bz#789278
Change-Id: I15ae54ed696295d4cb015668722e77983b062ccb
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit 55eb460da0cfc65f4d7fd050f196612f18e44b5a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Oct 24 12:24:35 2019 +0530
gf-event: Handle unix volfile-servers
Problem:
glfsheal program uses unix-socket-based volfile server.
volfile server will be the path to socket in this case.
gf_event expects this to be hostname in all cases. So getaddrinfo
will fail on the unix-socket path, events won't be sent in this case.
Fix:
In case of unix sockets, default to localhost
fixes: bz#1765017
Change-Id: I60d27608792c29d83fb82beb5fde5ef4754bece8
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit ef2887e304ccb0e9ed7491f0a3a3f4f39988dd9f
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Oct 22 16:02:28 2019 +0530
ssl/test: Change the rsa key length to 2048
On a rhel-8 machine, we need to have a key length
greater than or eaual to 2048. So changing the values
to 2048 to pass the test.
Credits: Mohit Agrawal <moagrawal@redhat.com>
Change-Id: I0f21db4d737203d0b2e44e7e61f50ae1279795ad
Updates: bz#1756900
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 8a1fd235ffe1442622f9f86327a2918280fc8eba
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Oct 22 18:52:25 2019 +0530
extras: Cgroup(CPU/Mem) restriction are not working on gluster process
Problem: After Configure the Cgroup(CPU/MEM) limit to a gluster processes
resource(CPU/MEM) limits are not applicable to the gluster
processes.Cgroup limits are not applicable because all threads are
not moved into a newly created cgroup to apply restriction.
Solution: To move a gluster thread to newly created cgroup change the
condition in script
Change-Id: I8ad81c69200e4ec43a74f6052481551cf835354c
Fixes: bz#1764208
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit e0ee27f9f6f38bf1514f1bb94f004c075b5d833e
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Oct 24 14:40:37 2019 +0530
test: fix suspicous non-root geo-rep test failures
Export of env variable is required for ssh-copy-id command.
fixes: bz#1765426
Change-Id: Icaf7a848cb8f4ae9f887d885a8c5bb71f26633b4
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit caa839e4d882b27500599823eb1442da1b5f22c4
Author: Vishal Pandey <vpandey@redhat.com>
Date: Thu Aug 8 11:46:46 2019 +0530
Worm: xattr update on changing access time of a WORM-Retained file
Retention-period must be updated on changing the access time
of a worm-retained file. Retention-period must be changed in the
"trusted.reten-state" xattr
Change-Id: Ieab758a4cf6da3b4bb1d6a3e4f95f400c8a11f1d
Fixes: bz#1554286
commit 549286458e347938ab0a0ae9a32a7152ed38ca50
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Oct 22 15:11:03 2019 +0530
Scripts: quota_fsck script KeyError: 'contri_size'
Problem: In a certain code flow, we weren't handling the
unavailability of the contri value in the dict. Trying to print
without the value resulted in erroring out.
Fix: Have printed the whole of dictionary as the values will be
helpful in understanding the state of the file/dir
Fixes: bz#1764129
Change-Id: I99c538adb712f281ca10e4e0088f404f515b9725
Signed-off-by: hari gowtham <hgowtham@redhat.com>
commit b7917c9e62cda468d47bc7e91772555cd2c7ba54
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Oct 3 14:06:52 2019 +0530
rpc: Synchronize slot allocation code
Problem: Current slot allocation/deallocation code path is not
synchronized.There are scenario when due to race condition
in slot allocation/deallocation code path brick is crashed.
Solution: Synchronize slot allocation/deallocation code path to
avoid the issue
Change-Id: I4fb659a75234218ffa0e5e0bf9308f669f75fc25
Fixes: bz#1763036
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 8d31fc4c7c6c2a11d75cffb2c5ccf8fb724f9d93
Author: Kotresh HR <khiremat@redhat.com>
Date: Sun Oct 20 01:01:39 2019 +0530
geo-rep: Fix Permission denied traceback on non root setup
Problem:
While syncing rename of directory in hybrid crawl, geo-rep
crashes as below.
Traceback (most recent call last):
File "/usr/local/libexec/glusterfs/python/syncdaemon/repce.py", line 118, in worker
res = getattr(self.obj, rmeth)(*in_data[2:])
File "/usr/local/libexec/glusterfs/python/syncdaemon/resource.py", line 588, in entry_ops
src_entry = get_slv_dir_path(slv_host, slv_volume, gfid)
File "/usr/local/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 687, in get_slv_dir_path
[ENOENT], [ESTALE])
File "/usr/local/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 546, in errno_wrap
return call(*arg)
PermissionError: [Errno 13] Permission denied: '/bricks/brick1/b1/.glusterfs/8e/c0/8ec0fcd4-d50f-4a6e-b473-a7943ab66640'
Cause:
Conversion of gfid to path for a directory uses readlink on backend
.glusterfs gfid path. But this fails for non root user with
permission denied.
Fix:
Use gfid2path interface to get the path from gfid
Change-Id: I9d40c713a1b32cea95144cbc0f384ada82972222
fixes: bz#1763439
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit ffabe70786384f37be0dd3764f276613ba74bdde
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Oct 18 20:18:21 2019 +0300
posix-entry-ops: do not copy when reading xattr
The code is simplified to avoid needless copy as well as simplified
overall for readability.
Such changes are needed elsewhere too (see
https://github.com/gluster/glusterfs/issues/720 )
Few other minor changes here and there, nothing functional.
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I14f9dd2c32a8932bfcc80ebe92c9aa77701095ff
commit ae34151f684a493e320d0f4fbe1a1e69f546c245
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Oct 18 10:46:14 2019 +0300
posix-helper.c: fix compile warn: ‘timeout’ may be used uninitialized
https://review.gluster.org/#/c/glusterfs/+/23439/ introduced this warning:
In file included from posix-helpers.c:50:
posix-helpers.c: In function ‘posix_health_check_thread_proc’:
../../../../libglusterfs/src/glusterfs/events.h:31:9: warning: ‘timeout’ may be used uninitialized in this function [-Wmaybe-uninitialized]
31 | _gf_event(event, ##fmt); \
| ^~~~~~~~~
posix-helpers.c:2024:9: note: ‘timeout’ was declared here
2024 | int timeout;
This patch fixes it, by re-setting the initial value to 0.
Change-Id: I90aee4a1366e21a00f5e138f44247d8c42b0f5ae
updates: bz#789278
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit e30f1a8fd4a365265941667a21989938f0a8bf13
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Oct 16 23:26:03 2019 +0530
glusterd: display correct rebalance data size after glusterd restart
Problem: After completion of rebalance, if glusterd is restarted,
rebalance status displays wrong rebalance data size in its output.
Cause: While glusterd restoring the information from /var/lib/glusterd/
into its memory, glusterd fetches rebalance_data from
/var/lib/glusterd/vols/volname/node_state.info. This value is
converted into an integer using atoi(), which is returning
incorrect value for larger values.
Solution: use sscanf() instead of atoi() to convert string to
integer(in this case it is unsigned long)
fixes: bz#1762438
Change-Id: Icbdb096919612b4a1d6fb0e315f09d38900abf4e
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit d25dbf486d3108e4ffee3e5f7f10c7068088468c
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Wed Oct 16 14:53:22 2019 +0530
build: var data is saved under $prefix instead of localstatedir
Problem:glusterfind saves var data under $prefix,
even though the localstatedir is mentioned while installing i.e, when we
install glusterfs with ./configure --prefix=/path/to/prefix
--localstatedir=/path/to/var
This happens because, glusterfind stores working dir as,
working_dir=@GLUSTERFSD_MISCDIR@/glusterfind/
and in configure.ac, GLUSTERFSD_MISCDIR is defined as:
GLUSTERFSD_MISCDIR="$(eval echo $prefix)/var/lib/misc/glusterfsd"
Solution: $localstatedir is used instead of $prefix while defining,
GLUSTERFSD_MISCDIR to avoid such anomaly.
fixes: bz#1489610
Change-Id: I431a63c14bee23a1aac612a3dcb0431cb29ca4a2
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit d3a0a5c28cf6afb4b66c29a5a72eb1e26147ed55
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Sep 13 21:27:44 2019 +0300
rpc: align structs
squash tens of warnings on padding of structs in afr structures.
The warnings were found by manually added '-Wpadded' to the GCC
command line.
Also made relevant structs and definitions static, where it
was applicable.
Change-Id: Ib71a7e9c6179378f072d796d11172d086c343e53
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit f688c650f71278a55b6291414fad312db349f54e
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Oct 16 14:25:47 2019 +0530
geo-rep: Fix config upgrade on non-participating node
After upgrade, if the config files are of old format, it
gets migrated to new format. Monitor process migrates it.
Since monitor doesn't run on nodes where bricks are not
hosted, it doesn't get migrated there. So this patch fixes
the config upgrade on nodes which doesn't host bricks.
This happens during config either on get/set/reset.
Change-Id: Ibade2f2310b0f3affea21a3baa1ae0eb71162cba
Signed-off-by: Kotresh HR <khiremat@redhat.com>
fixes: bz#1762220
commit 9e1d1bf845867c1d5b75d5213efbbfdf6927fcae
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Oct 10 21:59:59 2019 +0530
tests: add tests for bz#1758878
updates: bz#1193929
Change-Id: I517fa29e57bde970c2c22ebc2de80fec1509cd2d
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit fb36895d62d45929ca21ad571fe4f5f1e297e566
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Oct 14 10:29:31 2019 +0530
tests: Fix spurious failure
fixes: bz#1759002
Change-Id: I4d49e1c2ca9b3c1d74b9dd5a30f1c66983a76529
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit cbbed998f3aa264c86814b93e639e7dbc3039519
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Oct 15 16:11:00 2019 +0530
tests: Specify bs for dd
On some distros default bs is very slow and the test takes
close to 2 minutes instead of 20 seconds.
fixes: bz#1761769
Change-Id: If10d595a7ca05f053237f3c5ffbb09c5151eab35
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit dac2fa1b8ef375461c24fa7794a9275f0682b446
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Oct 15 15:29:48 2019 +0530
tests: Remove hard-coding of lower bound
Problem:
Total blocks of XFS partition are dependent on XFS parameters used
for formatting. So hardcoded lower-bound may not be the lower bound
for different default parameters.
Used blocks are lesser on my machine for a freshly formatted XFS partition
compared to where the test fails.
On my machine:
Filesystem 1024-blocks Used Available Capacity Mounted on
/dev/loop0 98980 5472 93508 6% /d/backends/patchy1
/dev/loop1 98980 5472 93508 6% /d/backends/patchy2
On a machine where this test fails:
Filesystem 1024-blocks Used Available Capacity Mounted on
/dev/loop0 96928 6112 90816 7% /d/backends/patchy1
/dev/loop1 96928 6112 90816 7% /d/backends/patchy2
Fix:
Make lower bound 2% less than the brick-blocks available
fixes: bz#1761759
Change-Id: I974d5e75766f7ff44780a2e4c2a19cd5d1d14a79
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 93acace65c088f9a3e8271861bb103047fd3355f
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Oct 14 15:42:31 2019 +0530
dht: Rebalance causing IO Error - File descriptor in bad state
Problem : When a file is migrated, dht attempts to re-open all open
fds on the new cached subvol. Earlier, if dht had not opened the fd,
the client xlator would be unable to find the remote fd and would
fall back to using an anon fd for the fop. That behavior changed with
https://review.gluster.org/#/c/glusterfs/+/15804, causing fops to fail
with EBADFD if the fd was not available on the cached subvol.
The client xlator returns EBADFD if the remote fd is not found but
dht only checks for EBADF before re-opening fds on the new cached subvol.
Solution: Handle EBADFD at dht code path to avoid the issue
Change-Id: I43c51995cdd48d05b12e4b2889c8dbe2bb2a72d8
Fixes: bz#1758579
commit aa910f70c126c2a1cdadc420e35c507e896e7256
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Sep 18 21:14:40 2019 +0300
posix-helpers.c: minor changes to posix_fs_health_check
Do not sprintf the path in every invocation.
Initialize parameters sooner.
Change-Id: I26bfffc5dab6530937a50eee1e7fc4982e9b2a7c
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 841832ccedfaef711aaa63f3f1106a9b49d477b0
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Oct 14 18:16:21 2019 +0530
tests: mark tests/bugs/glusterd/quorum-value-check.t as NFS test
Fixes: bz#1665358
Change-Id: Iea000dd839d4e4dbef45941f97ab3725a2aa1726
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 42cc6f2488ffd4b6eb50ea13c1a20b2221a80e75
Author: yatipadia <ypadia@redhat.com>
Date: Fri Sep 13 13:52:38 2019 +0530
glusterfsd: fix unused value coverity issues
This patch addresses CID-1398624 and CID-1398631
removed the unused variable brick_name
Change-Id: I4f40bd76cb4c94b28589c2333e29d4623da339d0
Updates: bz#789278
Signed-off-by: yati <ypadia@redhat.com>
commit 1180f4d8287eac80ac5580dd85fdbfde58f162a8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Oct 10 09:37:24 2019 +0530
cluster/afr: Add afr_seek to fops table
fixes: bz#1760189
Change-Id: Iffbf8d6f4c50b8e2de8364658697bdbe96549f5d
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 8e5faf686021ddabc0dd82cd1a7b0843d34a8bf9
Author: Vishal Pandey <vpandey@redhat.com>
Date: Mon Sep 23 20:12:21 2019 +0530
cli: raise error in cli when replica != 2 while ta vol creation
When creating a thin-arbiter volume, if the replica-count
provided is other than 2, the cli command
fails(which is the expected behaviour) but it fails
while transaction is being committed on localhost.
This, ideally should be handled in cli itself.
Change-Id: I52ecdaf49a7df85670505e4743cdcf3101c71c9f
Signed-off-by: Vishal Pandey <vpandey@redhat.com>
Fixes: bz#1754477
commit 05004c16e6a1ce08c6fc89881b2a6dbfc5e0ce4a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Sep 30 20:27:27 2019 +0300
glusterd-volgen.c: fix setting the key export-dir
The return value of gf_asprintf() was used as the key length,
and it was stored into ret.
ret was re-used before the dict function was called, therefore was invalid
as the real key length and contained a different value.
That was masked by the fact the key length was only used in key hash, so
while it was incorrect, it was harmless. The hash was consistent and
the key length was re-calculated anyway in dict_set_lk().
This patch fixes it, so later on we can use the key length also in
dict_set_lk() to save another strlen() (sent in a different patch).
However, in the course of this patch I've also decided to reduce the
copy-pasta in this code path and put all NFS options in an array
and iterate through them. This makes the code shorter and easier to read.
(It's also more efficient since once an entry was found, there's no
additional strcmp()'s as the previous code did).
Change-Id: I968ed50a55f3b1a7ad027c72b06e0fa3788eaa9b
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 9c67e9c0c429b99841d3974ee8f5ceb14a26af1b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Oct 4 11:17:44 2019 +0300
Multiple files: make root gfid a static variable
In many places we use it, compare to it, etc. It could be a static variable,
as it really doesn't change. I think it's better than initializing to 0
and then doing gfid[15] = 1 or other tricks.
I think there are additional oppportunuties to make more variables static.
This is an attempt at an easy one.
Change-Id: I7f23a30a94056d8f043645371ab841cbd0f90d19
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit c64086d61ffb8f7324f275234b0a0af731bc7081
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Sep 13 09:20:33 2019 +0300
afr: align structs
squash >50 warnings on padding of structs in afr structures.
The warnings were found by manually added '-Wpadded' to the GCC
command line.
Change-Id: I961fbdeb33715cedf3dd10db8e4f8ef40cd3e867
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit ddb56b791881772ef361f872ff92687cacc8c845
Author: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
Date: Mon Sep 23 15:36:16 2019 +0530
glusterd: Re-alignment of structure attributes in glusterd.
Structures defined in few files of glusterd src have been modified into
memory efficient manner.
Change-Id: Ie712b41cc74b04d5169bfd2402bff3b9c0d8c95b
Updates: bz#1754448
Signed-off-by: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
commit c4f2009ecfe449dcb78a06627f9635c26bc632a8
Author: yatipadia <ypadia@redhat.com>
Date: Fri Oct 4 18:21:42 2019 +0530
POSIX/xlators: Unused and unchecked value coverity issue
This patch addresses CID-1274094 and CID-1382354
Problem(1): "ret" was assigned a value which was never used,
it was overwritten by 0 and hence has no use.
Problem(2): function was called without checking the return value.
Solution(1): Removed the assignment and just called the function
whose value was being written in ret.
Solution(2): There was no need to check for the return value as at
the end 0 is returned, so typecasted the return value as void.
Change-Id: Iefd0e9000c466ef2428c754c31370263bf1ca0d0
updates: bz#789278
commit 873e349bc7dd5a6bbba6a69efd6b79e62e010ae9
Author: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
Date: Thu Sep 12 19:50:35 2019 +0530
Posix: UNUSED VALUE coverity fix
This patch fixes Coverity issue with CID 1274206
Problem : -1 is assigned to op_ret, but that stored value is overwritten before it can be used.
Fix : Removal of the line that assigns -1 to op_ret which has no significance.
Change-Id: Icb881549ac946003710551c9b9e88b33b6a06239
Updates: bz#789278
Signed-off-by: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
commit b2f59ac5801f4562df34309964db03e15bbadbc4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Oct 10 10:50:59 2019 +0530
performance/open-behind: seek fop should open_and_resume
fixes: bz#1760187
Change-Id: I4c6ad13194d4fc5c7705e35bf9a27fce504b51f9
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 913d8e629578ea25eaeeacb085a6eb8c16ad11c2
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Sep 19 20:22:56 2019 +0530
performance/read-ahead: update expected offset before unwinding read response
With the current code there is a window of time between unwinding
response to a read request and internal offset is updated to account
the read just done. If new sequential read request comes in this time
window, it is incorrectly identified as non-sequential read.
Fix is to update the file offset to account for a read request before
sending back the response to it.
Change-Id: Iff0c59c769e1eb15f262257763026657e2d4785d
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1753843
commit 552f9f9a9efbe82eea1a7cb3ea019626fe8b63a0
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sun Oct 6 19:05:28 2019 +0530
cli: fix distCount value
gluster volume info --xml id displaying wrong distCount
value. This patch addresses it.
fixes: bz#1758878
Change-Id: I64081597e06018361e6524587b433b0c4b2a0260
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit bcc2164dbe2fef8b667d585e17d62e608ef2574d
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Sep 11 17:53:39 2019 +0300
client xlator: misc. cleanups
- remove dead code
- move functions to be static
- move some code that only needs to be executed under if branch
- remove some dead assignments and redundant checks.
No functional change, I hope.
Change-Id: I93d952408197ecd2fa91c3f812a73c54242342fa
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 925c2427e2f3d4846427adb33fae2bffd5d828c3
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Oct 9 00:25:42 2019 +0300
dict.{c,h}: remove the lock from the _data struct
I'm not sure why it was there and I did not see any use for it.
In the hope I did not miss anything, I removed it.
Change-Id: I02fa2e8e2a598b488fddbff4c7168dc4a41929b2
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 7b7194248c477d0ee37d1ee6a6b007755f84842c
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Oct 3 15:20:20 2019 +0300
glusterd-utils.c: attach_brick() - remove dead code
pidfile1 and pidfile2 were not used anywhere.
Removed the assignment and the variables.
Change-Id: Ic5fe091ba28bb500c370410a63440953048fd0b7
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 16600356c0e51c0b7e9d2b97145e1541991f4086
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sat Oct 5 00:20:49 2019 +0300
posix-helpers.c: do not copy when reading xattr
The code is simplified to avoid needless copy as well as simplified
overall for readability.
Such changes are needed elsewhere too (see
https://github.com/gluster/glusterfs/issues/720 )
Few other minor changes here and there, nothing functional.
Change-Id: Ia1167849f54d9cacbfe32ddd712dc1699760daf5
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 5c7dd1bda6278d4d5e1bb7477e3886a8a636f9b7
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Oct 10 20:40:49 2019 +0530
glusterd: rebalance start should fail when quorum is not met
rebalance start should not succeed if quorum is not met.
this patch adds a condition to check whether quorum is met
in pre-validation stage.
fixes: bz#1760467
Change-Id: Ic7d0d08f69e4bc6d5e7abae713ec1881531c8ad4
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 7947cfc5fe94369a24a12d2d0157bb9aea1898e9
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Oct 9 10:26:39 2019 -0400
packaging: remove leftover bd cruft in rpm .spec
$subject
Change-Id: Ifd8e3340ae6868ea1fd2d0b53f02b093cc23f2cb
Fixes: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit c687120b1d9187755dc5684042c56d953ccc6c52
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Oct 7 12:27:01 2019 +0530
Fix spurious failure in bug-1744548-heal-timeout.t
Script was assuming that the heal would have triggered
by the time test was executed, which may not be the case.
It can lead to following failures when the race happens:
...
18:29:45 not ok 14 [ 85/ 1] < 26> '[ 331 == 333 ]' -> ''
...
18:29:45 not ok 16 [ 10097/ 1] < 33> '[ 668 == 666 ]' -> ''
Heal on 3rd brick didn't start completely first time the command was executed.
So the extra count got added to the next profile info.
Fixed it by depending on cumulative stats and waiting until the count is
satisfied using EXPECT_WITHIN
fixes: bz#1759002
Change-Id: I3b410671c902d6b1458a757fa245613cb29d967d
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 62a934f29f78ff7ef4b061aed05b494626bdce9f
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Sep 5 16:14:50 2019 +0530
cluster/afr: Heal entries when there is a source & no healed_sinks
Problem:
In a situation where B1 blames B2, B2 blames B1 and B3 doesn't blame
anything for entry heal, heal will not complete even though we have
clear source and sinks. This will happen because while doing
afr_selfheal_find_direction() only the bricks which are blamed by
non-accused bricks are considered as sinks. Later in
__afr_selfheal_entry_finalize_source() when it tries to mark all the
non-sources as sinks it fails to do so because there won't be any
healed_sinks marked, no witness present and there will be a source.
Fix:
If there is a source and no healed_sinks, then reset all the locked
sources to 0 and healed sinks to 1 to do conservative merge.
Change-Id: If40d8bc95d52a52b2730f55bdcf135109b421548
Fixes: bz#1749322
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 1d27fd0739079792c462de6b961b4bf9c5f165cf
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Oct 7 16:59:20 2019 +0530
tests: Fix spurious failure in bug-1134691-afr-lookup-metadata-heal.t
Problem:
The .t was examining the sink brick's iatt value before the launched
client-side metadata heal got a chance to complete.
Fix:
Wait for heal completion.
Fixes: bz#1759081
Change-Id: I4dd4e3a1cccf35fd18e8cdfea6aa76a726a4763b
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 1456dd82859fd8eba33570bc67b997e47a527637
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sat Sep 28 08:53:08 2019 +0530
afr: support split-brain CLI for replica 3
Ever since we added quorum checks for lookups in afr via commit
bd44d59741bb8c0f5d7a62c5b1094179dd0ce8a4, the split-brain resolution
commands would not work for replica 3 because there would be no
readables for the lookup fop.
The argument was that split-brains do not occur in replica 3 but we do
see (data/metadata) split-brain cases once in a while which indicate that there are
a few bugs/corner cases yet to be discovered and fixed.
Fortunately, commit 8016d51a3bbd410b0b927ed66be50a09574b7982 added
GF_CLIENT_PID_GLFS_HEALD as the pid for all fops made by glfsheal. If we
leverage this and allow lookups in afr when pid is GF_CLIENT_PID_GLFS_HEALD,
split-brain resolution commands will work for replica 3 volumes too.
Likewise, the check is added in shard_lookup as well to permit resolving
split-brains by specifying "/.shard/shard-file.xx" as the file name
(which previously used to fail with EPERM).
Change-Id: I3c543dea79caf7cfbc1633e9089cb1cdd2538ba9
Fixes: bz#1756938
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 9212e88b8c819243db1132c84e0f4cfd33bc3b13
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Sep 11 14:57:29 2019 +0530
extras: Enable direct-io options in group virt
Direct-io options are currently enabled in the ovirt-gluster
installation through cockpit ui whereas all the other optimizations in
gluster for virt are enabled through the group-virt option using
'volume-set' command. For the sake of completeness and to avoid any
confusion, it would be better to set the o-direct gluster options also
as part of group virt.
Change-Id: Iac4c443c2a8239effeb05a52344e563f1d877916
Fixes: bz#1758984
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit c41ec46515ff35c13c5d851c1952fcbb5ba875c5
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Sep 19 20:52:46 2019 +0300
afr: replace afr_frame_return() when possible with direct call
If you are already under lock, just decrement the call count
directly instead of removing the lock, re-taking the lock
and decrementing.
Implements https://github.com/gluster/glusterfs/issues/728
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I3fa20b4651fbdb826655c5a03baeed46e99b5487
commit 9a5909e67da72be0d732f58e366de097d46fad83
Author: yatipadia <ypadia@redhat.com>
Date: Mon Sep 16 14:45:12 2019 +0530
xlators: fixes logically dead code.
This patch addresses CID-1124388.
Problem: When we reach the "out" section in ra_priv_dump(), if the condition
(ret && conf) holds true, then the value of "add_section" will always be true.
So the condition (add_section == _gf_false) will be a dead code.
Fix:"add_section" has no use in the whole block and was making part of the
block as logically dead code and hence, removed it.
Change-Id: Id7e0105fc9a5ca5b2c2d098c665e6e32ecc6b62b
updates: bz#789278
Signed-off-by: yatipadia <ypadia@redhat.com>
commit aafdd0e7ac4aeb8ba8188f1163f786e554f67f36
Author: Amar Tumballi <amarts@gmail.com>
Date: Tue Oct 1 15:49:18 2019 +0530
tests: add a pending test case
While merging the protocol handshake fixes (bz#1620580), there was
a case which was left out. Adding it separately now.
Change-Id: I52133d5fe160b4567400a65e60aac8f7bc20697f
Updates: bz#1193929
Signed-off-by: Amar Tumballi <amarts@gmail.com>
commit 2ac16ce2f03b1f6118e2c5776e7830f38ab8506e
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Oct 1 17:37:15 2019 +0530
cluster/dht: Correct fd processing loop
The fd processing loops in the
dht_migration_complete_check_task and the
dht_rebalance_inprogress_task functions were unsafe
and could cause an open to be sent on an already freed
fd. This has been fixed.
Change-Id: I0a3c7d2fba314089e03dfd704f9dceb134749540
Fixes: bz#1757399
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit b585e5021f655dc9b971de85480fe31ba6502521
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Wed Jan 24 16:06:08 2018 +0800
rpc: fix missing unref on reconnect
On protocol client connecting to brick, client will firstly contact
glusterd to get port, then reconnect to glusterfsd. Reconnect cancels
the reconnect timer and start a new one. However, cancelling the timer
does not unref rpc ref-ed for it. That leads to refcount leak.
Fix this issue by unref-ing rpc if reconnect timer is canceled.
Change-Id: Ice89dcd93cb283a0c7250c369cc8961d52fb2022
Fixes: bz#1538900
BUG: 1538900
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit 39b39196b1719f8a8c0c7acf2452420ebe8a705c
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Sep 30 13:14:06 2019 +0530
ssl: fix RHEL8 regression failure
This tests is failing with
"SSL routines:SSL_CTX_use_certificate:ee key too small"
in RHEL8. This change is made according to
https://access.redhat.com/solutions/4157431
updates: bz#1756900
Change-Id: Ib436372c3bd94bcf7324976337add7da4088b3d5
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 613e73559cb485fdc39263cb50e0af713ee25c74
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Sep 26 20:07:11 2019 +0530
glusterd: improve logging
updates: bz#1193929
Change-Id: I5b4a39fbdaa43642a322440d550ca24df815cae9
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 5c40a1a648c50b2fa145e1cd28c1801beaec2b0d
Author: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
Date: Mon Sep 16 11:05:23 2019 +0530
libgfapi : Dereference after null check - coverity fix
This patch fixes coverity issue with CID 1405581
A pointer 'volname' is being deferenced (by passing it as an argument to strncmp), even when it points to NULL, leading to segmentation fault.
fix : Adding a NULL check condition beforehand and returning NULL
Change-Id: I18685fa1cb251253996051b83b6790a5d5f0aff9
Updates: bz#789278
Signed-off-by: Purna Pavan Chandra Aekkaladevi <paekkala@redhat.com>
commit b24586ff80043d0a6049aecf8d94515b3c4b18a8
Author: Amar Tumballi <amarts@gmail.com>
Date: Tue Aug 6 23:20:02 2019 +0300
protocol/handshake: pass volume-id for extra check
With added check of volume-id during handshake, we can be sure to not
connect with a brick if this gets re-used in another volume. This
prevents any accidental issues which can happen with a stale client
process lurking along.
Also added test case for testing same volume name which would fetch a
different volfile (ie, different bricks, different type), and a
different volume name, but same brick.
For reference:
Currently a client<->server handshake happens in glusterfs through
protocol/client translator (setvolume) to protocol/server using a
dictionary which containes many keys. Rejection happens in server
side if some of the required keys are missing in handshake
dictionary.
Till now, there was no single unique identifier to validate for a
client to tell server if it is actually talking to a corresponding
server. All we look in protocol/client is a key called
'remote-subvolume', which should match with a subvolume name in server
volume file, and for any volume with same brick name (can be present
in same cluster due to recreate), it would be same. This could cause
major issue, when a client was connected to a given brick, in one
volume would be connected to another volume's brick if its
re-created/re-used.
To prevent this behavior, we are now passing along 'volume-id' in
handshake, which would be preserved for the life of client process,
which can prevent this accidental connections.
NOTE: This behavior wouldn't be applicable for user-snapshot enabled
volumes, as snapshotted volume's would have different volume-id.
Fixes: bz#1620580
Change-Id: Ie98286e94ce95ae09c2135fd6ec7d7c2ca1e8095
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 32c09d5fa4928457f8b16ca6f901f28bea58f9ae
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Sep 26 17:52:30 2019 +0530
posix: heketidbstorage bricks go down during PVC creation
Problem: In OCS environment heketidbstorage is detached due
to health_check thread is failed.Sometime aio_write
is not successfully finished within default health-check-timeout
limit and the brick is detached.
Solution: To avoid the issue increase default timeout to 20s
Change-Id: Idff283d5713da571f9d20a6b296274f69c3e5b7b
Fixes: bz#1755900
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 4531bd67330855fae7bcd8e241e779d3002003b2
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Sep 18 16:32:08 2019 +0530
gfapi: Update the version of 'glfs_h_creat_open'
Change-Id: I43eaa53a7b8d876640d225e011b56192bba57eed
Fixes: bz#1753569
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 40878b8244ccb999d7963c03d0f00f2ab096dc02
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Sep 27 10:52:05 2019 +0530
tests/shard: Remove dependence on distributed cache
fixes: bz#1756211
Change-Id: Iee5b37af89ab624c16a45df364806003238280e5
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 8c68787eb37d2d043be12de5d05898c0d0e24238
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Sep 10 19:06:54 2019 +0530
cluster/ec: Implement read-mask feature
fixes: #725
Change-Id: Iaaefe6f49c8193c476b987b92df6bab3e2f62601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 7328216c99b327a70dc60b1d5a3882f05342773f
Author: Xavi Hernandez <jahernan@redhat.com>
Date: Wed Sep 25 11:56:35 2019 +0200
cluster/ec: prevent filling shd log with "table not found" messages
When self-heal daemon receives an inodelk contention notification, it tries
to locate the related inode using inode_find() and the inode table owned by
top-most xlator, which in this case doesn't have any inode table. This causes
many messages to be logged by inode_find() function because the inode table
passed is NULL.
This patch prevents this by making sure the inode table is not NULL before
calling inode_find().
Change-Id: I8d001bd180aaaf1521ba40a536b097fcf70c991f
Fixes: bz#1755344
Signed-off-by: Xavi Hernandez <jahernan@redhat.com>
commit 079c5a0522fe45017fd0719abe11db37a79ea347
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Tue Feb 12 18:33:44 2019 +0530
read-ahead/io-cache: turn off by default
We've found perf xlators io-cache and read-ahead not adding any
performance improvement. At best read-ahead is redundant due to kernel
read-ahead and at worst io-cache is degrading the performance for
workloads that doesn't involve re-read. Given that VFS already have
both these functionalities, this patch makes these two
translators turned off by default for native fuse mounts.
For non-native fuse mounts like gfapi (NFS-ganesha/samba) we can have
these xlators on by having custom profiles.
Change-Id: Ie7535788909d4c741844473696f001274dc0bb60
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
fixes: bz#1676479
commit 041c18df3f77e307aa0685f16e8b625176753c68
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Sep 18 19:11:33 2019 +0530
posix: Brick is going down unexpectedly
Problem: In brick_mux environment, while multiple volumes are
created (1-1000) sometimes brick is going down due to
health_check thread failure
Solution: Ignore EAGAIN error in health_check thread code to
avoid the issue
Change-Id: Id44c59f8e071a363a14d09d188813a6633855213
Fixes: bz#1751907
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 2df120f5b85f239653b7ce4eeb1fdcb9a1aa7f31
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Sep 25 19:50:27 2019 +0530
perf/write-behind: Clear frame->local on conflict error
WB saves the wb_inode in frame->local for the truncate and
ftruncate fops. This value is not cleared in case of error
on a conflicting write request. FRAME_DESTROY finds a non-null
frame->local and tries to free it using mem_put. However,
wb_inode is allocated using GF_CALLOC, causing the
process to crash.
credit: vpolakis@gmail.com
Change-Id: I217f61470445775e05145aebe44c814731c1b8c5
Fixes: bz#1753592
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 64ac883534b1599f00db902d50a43ea87e2dcdec
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Sep 18 16:32:08 2019 +0530
gfapi: 'glfs_h_creat_open' - new API to create handle and open fd
Right now we have two separate APIs, one
- 'glfs_h_creat_handle' to create handle & another
- 'glfs_h_open' to create a glfd to return to application
Having two separate routines can result in access errors
while trying to create and write into a read-only file.
Since a fd is opened even during file/directory creation,
introducing a new API to make these two operations atomic i.e,
which can create both handle & fd and pass them to application
Change-Id: Ibf513fcfcdad175f4d7eb6fa7a61b8feec6d33b5
Fixes: bz#1753569
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 5ded0eb37c04f2d12873fcc58a18901eee073ef1
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Sep 24 18:22:13 2019 +0530
tests : test case for non-root geo-rep setup
Added test case for non-root geo-rep setup.
Change-Id: Ib6ebee79949a9f61bdc5c7b5e11b51b262750e98
fixes: bz#1717827
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 1778e8e6141dbf496f1e36259c0e387167246cc7
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Sep 20 13:30:42 2019 +0530
glusterfs/fuse: Reduce the default lru-limit value
The current lru-limit value still uses memory for
upto 128K inodes.
Reduce the default value of lru-limit to 64K.
Change-Id: Ica2dd4f8f5fde45cb5180d8f02c3d86114ac52b3
Fixes: bz#1753880
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit d29f4779bdb307f54628008d28e1f17613ec7441
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Fri Aug 16 11:37:40 2019 +0530
geo-rep: Fix spelling errors
Fixes: bz#1741779
Change-Id: I708b6b7e6c520dee10445528e6f99ba38e141c25
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 8ba7b7fde5fa36af08c204ae69169ed65aae752e
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Sat Sep 21 01:07:30 2019 +0530
geo-rep : fix sub-command during worker connection
Problem:
Geo-rep session for non-root going faulty.
Solution:
During worker start we do not construct slave url and use 'args.resource_remote'
which is basically just slave-hostname.
This works better for root session but fails in non-root session during
ssh command.
Using slave url solves this issue.
fixes: bz#1753928
Change-Id: Ib83552fde77f81c208896494b323514ab37ebf22
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 89dfbf629d2ce83ac4648445edfe7b6982b246be
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Aug 26 11:32:18 2019 +0530
glusterd/ganesha: fixing resource leak in tear_down_cluster()
CID: 1370947
Updates: bz#789278
Change-Id: Ib694056430ff0536ed705a0e77e5ace22486891e
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit 9fdc9332e26fe906f21402665c566570b26b7bd7
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Sep 20 09:39:12 2019 +0530
geo-rep: performance improvement while syncing renames with existing gfid
Problem:
The bug[1] addresses issue of data inconsistency when handling RENAME with
existing destination. This fix requires some performance tuning considering
this issue occurs in heavy rename workload.
Solution:
If distribution count for master volume is one do not verify op's on
master and go ahead with rename.
The performance improvement with this patch can only be observed if
master volume has distribution count one.
[1]. https://bugzilla.redhat.com/show_bug.cgi?id=1694820
fixes: bz#1753857
Change-Id: I8e9bcd575e7e35f40f9f78b7961c92dee642f47b
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit a2fdd451154190aee46f0ac6958494df1413024b
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Sep 20 11:30:45 2019 +0530
mgmt/glusterd: Fixed typos and reworded logs
Fixed typos and reworded log messages for clarity.
Change-Id: I46f616ce7d3eb993c77a5812e8bc044e5f283354
Fixes: bz#1753859
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 846e9989c47389f7e390c4d1f6f3dc8e6edd759b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Sep 12 15:19:09 2019 +0300
afr-common.c, afr-self-heal.h: calloc/alloca0 -> malloc/alloca
In 3 cases, there was a memory allocation and zeroing, followed
directly by populating it with content. Replaced with memory
allocation that did not zero the memory.
Change-Id: I4fbb5c924fb3a144e415d2368126b784dde760ea
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 139cfa958a07ad9cfbea5e72138836246b8ac40e
Author: kshithijiyer <kshithij.ki@gmail.com>
Date: Wed Jul 10 18:39:51 2019 +0530
Improving help message for gluster-mountbroker
The arguments for gluster-mountbroker is missing help="< Some Text>"
parameter wherever add_argument() is used due to which gluster-mountbroker
help is missing a brief description of what the argument does in the help
of {add,setup,remove} as shown below:
usage: gluster-mountbroker remove [-h] [--volume VOLUME] [--user USER]
optional arguments:
-h, --help show this help message and exit
--volume VOLUME
--user USER
usage: gluster-mountbroker add [-h] volume user
positional arguments:
volume
user
optional arguments:
-h, --help show this help message and exit
usage: gluster-mountbroker setup [-h] mount_root group
positional arguments:
mount_root
group
optional arguments:
-h, --help show this help message and exit
fixes: bz#1728683
Change-Id: I7eabcd2c103f01e40160ba35500b0a4e5c9f5e7a
Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
commit f1daa52ac74b85d6e524ab89372e79e1c7858969
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Sep 17 15:35:21 2019 +0530
posix/ctime: Fix coverity issue
posix-metadata.c: 462 in posix_set_mdata_xattr()
...
460 GF_VALIDATE_OR_GOTO(this->name, time, out);
461
>>> CID 1405665: Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "flag->atime" inside this
>>> statement: "if (update_utime && (flag->...".
462 if (update_utime && (flag->ctime && !time) && (flag->atime && !u_atime) &&
Change-Id: Id31d81d04ea2785a669eafe0dc1307303cb2271b
updates: bz#789278
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit cf6568859eafaf51685aa12364891a384353c6e8
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Aug 27 16:35:05 2019 +0530
cluster/dht: Handle file truncates during migration
File truncate operations during a migration were not handled properly.
This has been fixed.
Change-Id: Ic642d257e893641236a4a21ab69fcc7a569dd70a
Fixes: bz#1745967
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit d3c96f8c769103fc51abd690cb6b622e4f2af55d
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Sep 16 10:04:26 2019 +0530
eventsapi: Set IPv4/IPv6 family based on input IP
server.sin_family was set to AF_INET while creating socket connection,
this was failing if the input address is IPv6(`::1`).
With this patch, sin_family is set by reading the ai_family of
`getaddrinfo` result.
Fixes: bz#1752330
Change-Id: I499f957b432842fa989c698f6e5b25b7016084eb
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 8e2b1234abdd1edf3f1fdc99c11f7a8ed3379e3f
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jul 29 18:30:42 2019 +0530
ctime/rebalance: Heal ctime xattr on directory during rebalance
After add-brick and rebalance, the ctime xattr is not present
on rebalanced directories on new brick. This patch fixes the
same.
Note that ctime still doesn't support consistent time across
distribute sub-volume.
This patch also fixes the in-memory inconsistency of time attributes
when metadata is self healed.
Change-Id: Ia20506f1839021bf61d4753191e7dc34b31bb2df
fixes: bz#1734026
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 576f653d86fec777d8eb869f4b5b30333db24c52
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sat Sep 7 11:28:58 2019 +0300
logging.c: check for log level before checking for args.
In many cases, we will not be logging at all, since the log level
is irrelevant. In that case, we can just bail out.
Worth doing this check before the args check, which may not be needed
in this case.
Change-Id: Ia90a38bb2a49b09bfea5b5abc8b5d0c3bab4e9ac
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 8012e15e30b7f40e9db0cf93f7bf270cecf2376d
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Sep 13 15:35:16 2019 +0530
tests/shd: Mark "tests/basic/volume-scale-shd-mux.t" as bad
This test case is failing in upstream. Marking this test as
bad for now.
Change-Id: I014c67628c14683c32a3c1dd770b10aaf35ad4cc
Updates: bz#1752331
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit f6ab5716b965cb2a32e9d658a493f1c25f2aa3f5
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon May 13 12:54:52 2019 +0530
protocol/client: don't reopen fds on which POSIX locks are held after a reconnect
Bricks cleanup any granted locks after a client disconnects and
currently these locks are not healed after a reconnect. This means
post reconnect a competing process could be granted a lock even though
the first process which was granted locks has not unlocked. By not
re-opening fds, subsequent operations on such fds will fail forcing
the application to close the current fd and reopen a new one. This way
we prevent any silent corruption.
A new option "client.strict-locks" is introduced to control this
behaviour. This option is set to "off" by default.
Change-Id: Ieed545efea466cb5e8f5a36199aa26380c301b9e
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
updates: bz#1694920
commit 4993c88679c1054c985b060cbaa9e9fff97ae943
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Mon Aug 19 15:27:57 2019 +0530
libgfapi: return correct errno on invalid volume name
glfs_init when called with volume name prefixed by '/'
sets errno to 0. Setting errno to EINVAL to resolve the issue.
Also volname is a parameter to glfs_new.
Thus, validating volname in glfs_new itself and
returning EINVAL from that function
fixes: bz#1507896
Change-Id: I0d4d2423e26cc07644d50ec8cce788ecc639203d
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 3a56bca07307931d4ba090541b66027a8acdfd23
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Sep 3 20:52:42 2019 +0530
core/syncop: Bail out if frame creation fails
There could be cases (either due to insufficient memory or
corrupted mem-pool) due to which frame creation fails. Bail out
with error in such cases.
Change-Id: I8cc0a5852f6f04d2bac991e4eb79ecb42577da11
Fixes: bz#1748448
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 1a0bd5cf9f7777c2c07166572f4c8311bc234925
Author: Sheetal <spamecha@redhat.com>
Date: Mon Sep 9 22:56:34 2019 +0530
api: Cleanup of executable not done
In test tests/bugs/gfapi/bug-1447266/bug-1447266.t
actual file created is -
tests/bugs/gfapi/bug-1447266/bug-1447266
which is not cleaned up later
fixes: bz#1750618
Change-Id: I93120418e54b95018a7213d106a1f1c990766281
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 617aa663114aa85456b5617a004c4af68b717390
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Aug 20 13:27:24 2019 +0530
cluster/ec: Mark release only when it is acquired
Problem:
Mount-1 Mount-2
1)Tries to acquire lock on 'dir1' 1)Tries to acquire lock on 'dir1'
2)Lock is granted on brick-0 2)Lock gets EAGAIN on brick-0 and
leads to blocking lock on brick-0
3)Gets a lock-contention 3) Doesn't matter what happens on mount-2
notification, marks lock->release from here on.
to true.
4)New fop comes on 'dir1' which will
be put in frozen list as lock->release
is set to true.
5) Lock acquisition from step-2 fails because
3 bricks went down in 4+2 setup.
Fop on mount-1 which is put in frozen list will hang because no codepath will
move it from frozen list to any other list and the lock will not be retried.
Fix:
Don't set lock->release to true if lock is not acquired at the time of
lock-contention-notification
fixes: bz#1743573
Change-Id: Ie6630db8735ccf372cc54b873a3a3aed7a6082b7
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 792e1aa505dc494884c0f17e1a2764a575aa0eea
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Jul 5 09:09:44 2019 +0530
tests: revive back volume-scale-shd-mux.t
Fixes: bz#1708929
Change-Id: I9cc81a9047ff874df752ca5552e00bf033485bd8
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 14cf5698f86f4f560cc5bb9ec659f0de83c4bb60
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Sep 11 14:41:28 2019 +0530
tests: Fix spurious failure
If heal from next brick starts after the first brick completes heal, then
opendir on the brick can change atime leading to failure of the test. When
ctime is disabled it is better to just check mtime to be same after heal.
fixes: bz#1751134
Change-Id: Ia03e30fd547e6bbe85c1e299845ffa122f3a2692
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit bc1f33fe53f98d06c59b9ba02e5e6c6895e21bb0
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Sep 9 10:01:04 2019 +0530
glusterd, rpc, glusterfsd: fix coverity defects and put required annotations
1404965 - Null pointer dereference
1404316 - Program hangs
1401715 - Program hangs
1401713 - Program hangs
Updates: bz#789278
Change-Id: I6e6575daafcb067bc910445f82a9d564f43b75a2
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 2d6e7c5fe16f8f48c1cf7a4acbf4077a2a9cf29d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Sep 5 16:12:39 2019 +0530
cluster/ec: quorum-count implementation
fixes: #721
Change-Id: I5333540e3c635ccf441cf1f4696e4c8986e38ea8
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit dccb29551ba40b0adab7a48eb473409118285c52
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Sep 7 20:18:01 2019 +0530
cluster/ec: Fix coverity issues
Fixed the following coverity issue in both flush/fsync
>>> CID 1404964: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "fd" suggests that it may be null, but it has already
been dereferenced on all paths leading to the check.
>>> if (fd != NULL) {
>>> fop->fd = fd_ref(fd);
>>> if (fop->fd == NULL) {
>>> gf_msg(this->name, GF_LOG_ERROR, 0,
>>> "Failed to reference a "
>>> "file descriptor.");
fixes bz#1748836
Change-Id: I19c05d585e23f8fbfbc195d1f3775ec528eed671
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 5943755a64954fbaede95cc23c7d714417efc41f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Sep 4 12:06:34 2019 +0530
cluster/ec: Fail fsync/flush for files on update size/version failure
Problem:
If update size/version is not successful on the file, updates on the
same stripe could lead to data corruptions if the earlier un-aligned
write is not successful on all the bricks. Application won't have
any knowledge of this because update size/version happens in the
background.
Fix:
Fail fsync/flush on fds that are opened before update-size-version
went bad.
fixes: bz#1748836
Change-Id: I9d323eddcda703bd27d55f340c4079d76e06e492
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 28dc44a26dccda3bfeb18dfd0d90d527a1941e50
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Sep 2 10:46:10 2019 +0530
glusterd: IPV6 hostname address is not parsed correctly
Problem: IPV6 hostname address is not parsed correctly in function
glusterd_check_brick_order
Solution: Update the code to parse hostname address
Change-Id: Ifb2f83f9c6e987b2292070e048e97eeb51b728ab
Fixes: bz#1747746
Credits: Amgad Saleh <amgad.saleh@nokia.com>
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 3deebc514aa3bda64135882acef9e464fb26b6a0
Author: Amar Tumballi <amarts@gmail.com>
Date: Tue Sep 3 11:32:39 2019 +0530
rpc/xdr: fixes in Makefile
there is no need to cleanup the .x files.
Fixes: bz#1743094
Change-Id: I89d8deb3939c83069709c701cb8f1972e3746168
Signed-off-by: Amar Tumballi <amarts@gmail.com>
commit de6f9d615e8d701113629bae4f9799767b79a0f9
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Jul 5 20:12:59 2019 +0530
graph/cleanup: Fix race in graph cleanup
We were unconditionally cleaning up the grap when we get
child_down followed by parent_down. But this is prone to
race condition when some of the bricks are already disconnected.
In this case, even before the last child down is executed in the
client xlator code,we might have freed the graph. Because the
child_down event is alreadt recevied.
To fix this race, we have introduced a check to see if all client
xlator have cleared thier reconnect chain, and called the child_down
for last time.
Change-Id: I7d02813bc366dac733a836e0cd7b14a6fac52042
fixes: bz#1727329
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 1180589463a57dd03e5b5629f23b43151d828583
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Jul 10 21:44:38 2019 +0530
afr/lookup: Pass xattr_req in while doing a selfheal in lookup
We were not passing xattr_req when doing a name self heal
as well as a meta data heal. Because of this, some xdata
was missing which causes i/o errors
Change-Id: Ibfb1205a7eb0195632dc3820116ffbbb8043545f
Fixes: bz#1728770
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 78a3c6cab82e6c4ef65985bc03373cf5e104018f
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Aug 28 19:38:01 2019 +0300
posix*.c: remove unneeded strlen() calls
In various places, we can re-use knowledge of string length
or result of snprintf() and such instead of strlen().
Change-Id: I4c9b1decf1169b3f8ac83699a0afbd7c38fad746
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 35596525ee6ee158e237a612e31a6aeae59f0852
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Aug 30 10:21:33 2019 +0300
glusterd-store.c: remove of dead code
These functions do not seem to be in use.
Change-Id: Ie76baf2a9727b9ba0e66f234226b1e62788245f2
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 051e3c7bd95bfb36049a88f7f090ff142fa05656
Author: kshithijiyer <kshithij.ki@gmail.com>
Date: Mon Sep 2 18:43:36 2019 +0530
Fixing 404 links in markdown files.
Problem:
While running markdown-link-checker it was
observed that there were a large number of
404 links present in the documentation present
in the form of markdown files in the project.
This was casued due to the following reasons:
1. Repos being removed.
2. Typo in markdown links.
3. Restructring of directoires.
Solution:
Fixing all the 404 links present in the project.
fixes: bz#1746810
Change-Id: I30de745f848fca2e9c92eb7493f74738f0890ed9
Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
commit 864423f13823495d5949e1705b073d2e1a0a0dc6
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Sep 4 11:27:30 2019 +0530
tests: fix spurious failure of bug-1402841.t-mt-dir-scan-race.t
Problem:
Since commit 600ba94183333c4af9b4a09616690994fd528478, shd starts
healing as soon as it is toggled from disabled to enabled. This was
causing the following line in the .t to fail on a 'fast' machine (always
on my laptop and sometimes on the jenkins slaves).
EXPECT_NOT "^0$" get_pending_heal_count $V0
because by the time shd was disabled, the heal was already completed.
Fix:
Increase the no. of files to be healed and make it a variable called
FILE_COUNT, should we need to bump it up further because the machines
become even faster. Also created pending metadata heals to increase the
time taken to heal a file.
fixes: bz#1748744
Change-Id: I5a26b08e45b8c19bce3c01ce67bdcc28ed48198d
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 74670e17bff2be8de292a88150f6147ef6deeb0b
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Sun Sep 1 12:01:09 2019 +0530
rpc: Update address family if it is not provide in cmd-line arguments
Problem: After enabling transport-type to inet6 and passed ipv6
transport.socket.bind-address in glusterd.vol clients are
not started.
Solution: Need to update address-family based on remote-address for
all gluster client process
Change-Id: Iaa3588cd87cebc45231bfd675745c1a457dc9b31
Fixes: bz#1747746
Credits: Amgad Saleh <amgad.saleh@nokia.com>
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 77e4878a9e6c3e231734e81ed6c62d2e05c18ead
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Aug 28 11:55:17 2019 +0530
debug/error-gen: Set count correctly for short-writes
vector count is reduced to 1 but it is not reflected at the time of
winding the call. This leads to crash when short-writes are done
using error-gen. Set the correct count to fix the problem.
fixes: bz#1746320
Change-Id: I037b60b7e321f2f50b71fb52c43c64707cf114ca
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 81fe8d4d987c698b3cda204795744aa0cda52105
Author: Jiri Lunacek <jiri.lunacek@hosting90.cz>
Date: Tue Aug 6 10:29:34 2019 +0200
peer_map parameter and fix in state detection when no brick is running on peer
The resource agent assumed that peer names in gluster are identical to short hostname of the machine which is not always the case. This commit adds a parameter to solve this.
Also resource agent reported brick running on cluster nodes that did not cary any brick of specified volume.
Change-Id: I90aacfc34ac0d00aae3f2abb69cacd7278b886bc
Fixes: bz#1737778
Signed-off-by: Jiri Lunacek <jiri.lunacek@hosting90.cz>
commit c4635e45a313df761ef27df7751522199a2b0df6
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Aug 29 14:27:12 2019 +0530
build: Fix libglusterd Makefile target
* Fix libglusterd.la target path in cli/src/Makefile.am
* Like libglusterfs, libgfxdr and libgfrpc, libglusterd is also
expected to be ready by the time xlators/mgmt/glusterd sources
are compiled. Therefore this change removes the additional
mentioning of libglusterd.la target in Makefile.am
Change-Id: I1b787316cfb6cd7487f49e661490b9788a0b80b3
Updates: bz#1193929
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 7ebb205c80d7dc9886ce81b964e3a02b21b082ef
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Aug 22 17:27:22 2019 +0530
afr: wake up index healer threads
...whenever shd is re-enabled after disabling or there is a change in
`cluster.heal-timeout`, without needing to restart shd or waiting for the
current `cluster.heal-timeout` seconds to expire.
See BZ 1743988 for more details.
Change-Id: Ia5ebd7c8e9f5b54cba3199c141fdd1af2f9b9bfe
fixes: bz#1744548
Reported-by: Glen Kiessling <glenk1973@hotmail.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 3d169d934715b0c91baa94e8d07ebdb019057989
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Tue Jul 16 18:43:13 2019 +0530
build: move arch-dependent files from /usr/share to /usr/libexec
All architecture-dependent data should be placed
in /usr/libexec, and architecture independent data
files in /usr/share.
fixes: bz#1387404
Change-Id: Ie3249cae37c5ee4211309ef55a7a76682e57602f
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 944ec66573794ead2f9a9d0959c3e844c54f978b
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Aug 28 09:05:20 2019 +0530
glusterd: glusterd service is getting timed out on scaled setup
Problem: On a three node cluster with 2000 replica volumes systemctl is getting
timed out for glusted service.
Solution: Configure TimeoutSec 300 to wait for glusterd startup.
Change-Id: Idb3f3f3e56e6216a0ebd754cbb9e8e37ce9e636d
Fixes: bz#1746228
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 10d95b979d0c8337e260246eef4d43cdbb127c15
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Aug 27 16:57:14 2019 +0530
glusterd: Fixed incorrect size argument
An incorrect size argument to snprintf caused
the glusterd process to crash on startup. This has been
fixed.
Change-Id: Iddafb5468866d0182cd8239210c92c893e643285
Fixes: bz#1745965
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit f9118c2c9389e0793951388c2d69ce0350bb9318
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Fri Jul 12 20:23:20 2019 +0530
build: fix rpmlint warnings in specfile
Fixed following warnings:
glusterfs.spec:286: W: unversioned-explicit-obsoletes %{name}-ufo
glusterfs.spec:288: W: unversioned-explicit-obsoletes %{name}-rdma
glusterfs.spec:290: W: unversioned-explicit-obsoletes %{name}-gnfs
fixes: bz#1183054
Change-Id: I6bc0d3afd34cda1e4a7d74b8006ce3966109638f
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit d706f43ece10e29c9fdd250ce9a92fc751f8a09e
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Aug 26 12:38:40 2019 +0530
glusterd: Unused value coverity fix
CID: 1288765
updates: bz#789278
Change-Id: Ie6b01f81339769f44d82fd7c32ad0ed1a697c69c
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit db19622bceaf46de17ba0962e8044d7e0ee42111
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jul 15 11:26:55 2019 +0530
glusterd: stop stale bricks during handshaking in brick mux mode
This patch addresses two problems:
1. During friend handshaking, if a volume is imported due to change in
the version, the old bricks were not stopped which would lead to a
situation where bricks will run with old volfiles.
2. As part of attaching shd service in glusterd_attach_svc, there might
be a case that the volume for which we're attempting to attach a shd
service might become stale and in the process of deletion and hence in
every retrials (if the rpc connection isn't ready) check for the
existance of the volume and then only attempt the further attach
request.
Fixes: bz#1733425
Change-Id: I6bac6b871f7e31cb5bf277db979289dec196a03e
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit dc2849f75c5336f4d9bd4bca56aaa90047bfbc47
Author: Vishal Pandey <vpandey@redhat.com>
Date: Wed Aug 7 12:53:06 2019 +0530
glusterd: Add warning and abort in case of failures in migration during remove-brick commit
Problem -
Currently remove-brick commit goes through even though there were files
that failed to migrate or were skipped. There is no warning raised to the user.
Solution-
Add a check in the remove brick staging phase to verify if the status of the
rebalnce process is complete but there has been failures or some skipped files
while migration, In this case user will be given a warning and remove-brick
commit. User will need to use the force option to remove the bricks.
Fixes: bz#1514683
Signed-offby- Vishal Pandey <vpandey@redhat.com>
Change-Id: I014d0f0afb4b2fac35ab0de52227f98dbae079d5
commit 2c5601979124b0b5f8262a611a34383d7d9e250f
Author: Barak Sason <bsasonro@redhat.com>
Date: Tue Aug 20 15:37:16 2019 +0300
cli - group files to set volume options supports comments
Modified parsing of group files in such a way that line that starts with
"#" would be treated as comments
Fixes: bz#1423442
Change-Id: Id85ceb49f8f9c920d4ea551f60bd28767279d4be
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit af47afb767d50e878bcfd9cae8f5125bac8b59bf
Author: Barak Sason <bsasonro@redhat.com>
Date: Sun Aug 18 15:54:11 2019 +0300
cluster/afr - Unused variables
-Minor change to if-else structure to avoid code duplication.
-Added logging in case method calls fails
CID: 1394654
Updates: bz#789278
Change-Id: Ibef4450dc89ddd3bf951303d5b87f503924fd250
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit 5e73b8b5a3fae0c6ae740bbf0fd1e5feab51eeb3
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Oct 16 14:24:29 2017 +0530
Revert "glusterd: (storhaug) remove ganesha (843e1b0)"
please note as an additional change, macro GLUSTERD_GET_SNAP_DIR
moved from glusterd-store.c to glusterd-snapshot-utils.h
Change-Id: I811efefc148453fe32e4f0d322e80455447cec71
updates: #663
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit e22ad31d47b76575af17167f8a3c7335648ca86b
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Oct 16 14:18:31 2017 +0530
Revert "packaging: (ganesha) remove glusterfs-ganesha subpackage and related files"
Until 3.12, glusterd had an option to setup HA cluster for nfs-ganesha using pacemaker
and corosync. But later infavour of "Storhaug" Project, this functionality was removed
from the codebase. Since there is not much development happening towards storhaug,
it better to keep back old working HA solution for nfs-ganesha with bit improvements.
Planned improvements :
* add an option in nfs-ganesha enable to set ganesha without HA.
* Handle usage of export id's properly in the scripts.
Change-Id: I1d60c8970bfc20035cf674d7b2705dfd4819647e
updates: #663
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit a5410f5e11f8521ec3a217217f6d65243a4b1faa
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Aug 22 15:51:43 2019 +0530
posix: log aio_error return codes in posix_fs_health_check
Problem: Sometime brick is going down to health check thread is
failed without logging error codes return by aio system calls.
As per aio_error man page it returns a positive error number
if the asynchronous I/O operation failed.
Solution: log aio_error return codes in error message
Change-Id: I2496b1bc16e602b0fd3ad53e211de11ec8c641ef
Fixes: bz#1744519
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit db71e7ddd15dceec33a930ad14b30b043d723692
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Aug 16 16:07:03 2019 +0530
geo-rep: Fix the name of changelog archive file
Background:
The processed changelogs are archived each month in a single tar file.
The default format is "archive_YYYYMM.tar" which is specified as "%%Y%%m"
in configuration file.
Problem:
The created changelog archive file didn't have corresponding year
and month. It created as "archive_%Y%m.tar" on python2 only systems.
Cause and Fix:
Geo-rep expects "%Y%m" after the ConfigParser reads it from config file.
Since it was "%%Y%%m" in config file, geo-rep used to get correct value
"%Y%m" in python3 and "%%Y%%m" in python2 which is incorrect.
The fix can be to use "%Y%m" in config file but that fails in python3.
So the fix is to use "RawConfigParser" in geo-rep and use "%Y%m". This
works both in python2 and python3.
Change-Id: Ie5b7d2bc04d0d53cd1769e064c2d67aaf95d557c
fixes: bz#1741890
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 4d25649f780d5b6d432f20d2b2e6b3db37e13ec2
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Aug 20 15:49:40 2019 +0530
ctime: Fix incorrect realtime passed to frame->root->ctime
On systems that don't support "timespec_get"(e.g., centos6), it
was using "clock_gettime" with "CLOCK_MONOTONIC" to get unix epoch
time which is incorrect. This patch introduces "timespec_now_realtime"
which uses "clock_gettime" with "CLOCK_REALTIME" which fixes
the issue.
Change-Id: I57be35ce442d7e05319e82112b687eb4f28d7612
Signed-off-by: Kotresh HR <khiremat@redhat.com>
fixes: bz#1743652
commit a6f65299260b069d70b464d4ab8213b61b890f55
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Fri Aug 9 14:19:07 2019 +0800
nlm: check if nlm4 is initialized in nlm_priv
Otherwise, gnfs will crash in following steps.
1) gluster v set <VOL> nfs.disable off
2) gluster v set <VOL> nfs.nlm off
3) kill -SIGUSR1 <GNFS_PID>
4) gnfs crash with SIGSEGV as follows:
nlm_priv (this=this@entry=0x7f1ad00173b0) at nlm4.c:2742
0x00007f1acf89d29d in nfs_priv (this=0x7f1ad00173b0) at nfs.c:1662
0x00007f1ae2941085 in gf_proc_dump_single_xlator_info (trav=trav@entry=0x7f1ad00173b0) at statedump.c:502
0x00007f1ae29410b8 in gf_proc_dump_per_xlator_info (top=top@entry=0x7f1ad00173b0) at statedump.c:519
fixes: bz#1739360
Change-Id: Ib9b207a4ccb3226dbc2c449b77de348cbc9a3d3c
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit 5f55a8dc277fb7c4dec45b74c0d080e33bd50a48
Author: Barak Sason <bsasonro@redhat.com>
Date: Sun Aug 18 17:52:04 2019 +0300
storage/posix - Fixing a coverity issue
Fixed a resource leak of variable 'pfd'
CID: 1400673
Updates: bz#789278
Change-Id: I78e1e8a89e0604b56e35a75c25d436b35db096c3
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit aa9f97a2340b50df2c5e0b0a61ff83dc8adb74cc
Author: Barak Sason <bsasonro@redhat.com>
Date: Sun Aug 18 11:02:32 2019 +0300
features/utime - fixing a coverity issue
-Modified op_errno init value to a non-negative value in order to avoid
using a negative value where it's not allowed.
-In the metod "STACK_UNWIND_STRICT" modified 3rd argument in order to
represnt the correct value to use (changed from -1 to ret).
CID: 1403650
Updates: bz#789278
Change-Id: I608031d5af13832e05e180e746b1b5280b54f559
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit 264ac88c959154c654f95ac5f5e503e0455d0a6a
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Aug 21 09:54:21 2019 +0530
geo-rep: Structured logging new format
Structured logging format changed in the below patch for better
readability and parsing. This patch changes the Geo-replication logs
to that format.
https://review.gluster.org/#/c/glusterfs/+/22987/
Before:
```
[2019-08-21 04:23:01.13672] I [monitor(monitor):157:monitor] Monitor: \
starting gsyncd worker<TAB>brick=/bricks/b1<TAB>slave_node=f29.sonne
```
After:
```
[2019-08-21 04:23:01.13672] I [monitor(monitor):157:monitor] Monitor: \
starting gsyncd worker [{brick=/bricks/b1}, {slave_node=f29.sonne}]
```
Change-Id: I65ec69a2869e2febeedc558f88620399e4a1a6a4
Updates: #657
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 6b429aff1d26af53e009ccd5754639db120d6a62
Author: yinkui <13965432176@163.com>
Date: Fri Aug 16 10:15:07 2019 +0800
gluster-smb:add smb parameter when access gluster by cifs
Change-Id: I9ff54f2ca6f86bb5b2f4740485a0159e1fd7785f
Fixes: bz#1741734
Signed-off-by: yinkui <13965432176@163.com>
commit 9a84a3877bfe13929842d1928297d887d443eb19
Author: Barak Sason <bsasonro@redhat.com>
Date: Thu Aug 15 17:23:17 2019 +0300
features/cloudsync - fix a coverity issue
All assigns to op_errno in this mehod were to the same vlaue - ENOMEM.
Removed repeted assignments and assigned as init value.
This also prevents the problem of sending a negatve value of op_errno to
CS_STACK_UNWIND method
CID: 1394645 - https://scan6.coverity.com/reports.htm#v44018/p10714/fileInstanceId=92065749&defectInstanceId=28018364&mergedDefectId=1394645
Updates: bz#789278
Change-Id: If765a9216500a38f9392617aaf06583ce36e3262
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit 3cbb5473586e72871f81642a7ddd6375d859e9f3
Author: Barak Sason <bsasonro@redhat.com>
Date: Thu Aug 15 11:06:26 2019 +0300
storage/posix - fixing a coverity issue
CID: 1394644 & 1394639
Updates: bz#789278
Added logging in case method calls fails
Change-Id: Ib833a5f68d37b98287b84c325637bc688937f647
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit 24309a5c61a9469fdf650bba07e36ec6f450755c
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Aug 8 10:05:12 2019 +0530
ctime: Fix ctime issue with utime family of syscalls
When atime|mtime is updated via utime family of syscalls,
ctime is not updated. This patch fixes the same.
Change-Id: I7f86d8f8a1e06a332c3449b5bbdbf128c9690f25
fixes: bz#1738786
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 0a7731f65c2c1ef0b2312e097ffdcf6151e28383
Author: Barak Sason <bsasonro@redhat.com>
Date: Sun Aug 18 15:36:40 2019 +0300
api: fixing a coverity issue
Added a null pointer check to avoid seg-fault
CID:1403874
Updates: bz#789278
Change-Id: Ia8ff992c9f06d79647089f296afe77519fb5af2a
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit 8fadaf88ce8258ae258a8008aaf51b094c41edf5
Author: Anoop C S <anoopcs@redhat.com>
Date: Sat Aug 10 10:30:26 2019 +0530
performance/md-cache: Do not skip caching of null character xattr values
Null character string is a valid xattr value in file system. But for
those xattrs processed by md-cache, it does not update its entries if
value is null('\0'). This results in ENODATA when those xattrs are
queried afterwards via getxattr() causing failures in basic operations
like create, copy etc in a specially configured Samba setup for Mac OS
clients.
On the other side snapview-server is internally setting empty string("")
as value for xattrs received as part of listxattr() and are not intended
to be cached. Therefore we try to maintain that behaviour using an
additional dictionary key to prevent updation of entries in getxattr()
and fgetxattr() callbacks in md-cache.
Credits: Poornima G <pgurusid@redhat.com>
Change-Id: I7859cbad0a06ca6d788420c2a495e658699c6ff7
Fixes: bz#1726205
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 8b9565fad52e2c9d150d8a1e45ce84ddd0b2b58a
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Jul 18 11:43:01 2019 +0800
features/locks: avoid use after freed of frame for blocked lock
The fop contains blocked lock may use freed frame info when other
unlock fop has unwind the blocked lock.
Because the blocked lock is added to block list in inode lock(or
other lock), after that, when out of the inode lock, the fop
contains the blocked lock should not use it.
Change-Id: Icb309a1cc78380dc982b26d50c18d67e4f2c8915
fixes: bz#1737291
Signed-off-by: Kinglong Mee <mijinlong@horiscale.com>
commit 5d644000cd40905315d2835d29ea0bbedfdac629
Author: Barak Sason <bsasonro@redhat.com>
Date: Mon Aug 19 10:34:31 2019 +0300
libglusterfs - fixing a coverity issue
Fixed resource leak of variable volfile_obj
CID: 1402936
Updates: bz#789278
Change-Id: I1537187e13693686f4ffca891dc1df287fab7a41
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit 60e1bc121271df4b5d2826a20c25eed3d9d8ab2b
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jul 3 15:08:31 2019 +0530
logging: Structured logging reference PR
To convert the existing `gf_msg` to `gf_smsg`:
- Define `_STR` of respective Message ID as below(In `*-messages.h`)
#define PC_MSG_REMOTE_OP_FAILED_STR "remote operation failed."
- Change `gf_msg` to use `gf_smsg`. Convert values into fields and
add any missing fields. Note: `errno` and `error` fields will be
added automatically to log message in case errnum is specified.
Example:
gf_smsg(
this->name, // Name or log domain
GF_LOG_WARNING, // Log Level
rsp.op_errno, // Error number
PC_MSG_REMOTE_OP_FAILED, // Message ID
"path=%s", local->loc.path, // Key Value 1
"gfid=%s", loc_gfid_utoa(&local->loc), // Key Value 2
NULL // Log End
);
Key value pairs formatting Help:
gf_slog(
this->name, // Name or log domain
GF_LOG_WARNING, // Log Level
rsp.op_errno, // Error number
PC_MSG_REMOTE_OP_FAILED, // Message ID
"op=CREATE", // Static Key and Value
"path=%s", local->loc.path, // Format for Value
"brick-%d-status=%s", brkidx, brkstatus, // Use format for key and val
NULL // Log End
);
Before:
[2019-07-03 08:16:18.226819] W [MSGID: 114031] [client-rpc-fops_v2.c \
:2633:client4_0_lookup_cbk] 0-gv3-client-0: remote operation failed. \
Path: / (00000000-0000-0000-0000-000000000001) [Transport endpoint \
is not connected]
After:
[2019-07-29 07:50:15.773765] W [MSGID: 114031] \
[client-rpc-fops_v2.c:2633:client4_0_lookup_cbk] 0-gv1-client-0: \
remote operation failed. [{path=/f1}, \
{gfid=00000000-0000-0000-0000-000000000000}, \
{errno=107}, {error=Transport endpoint is not connected}]
To add new `gf_smsg`, Add a Message ID in respective `*-messages.h` file
and the follow the steps mentioned above.
Change-Id: I4e7d37f27f106ab398e991d931ba2ac7841a44b1
Updates: #657
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit aab6819aae581d86c8bd2f826cbb97b4c45ad5d3
Author: Barak Sason <bsasonro@redhat.com>
Date: Sun Aug 18 17:38:09 2019 +0300
mount/fuse - Fixing a coverity issue
Fixed resource leak of dict_value and newkey variables
CID: 1398630
Updates: bz#789278
Change-Id: I589fdc0aecaeb4f446cd29f95bad36ccd7a35beb
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit bbff52e173c52b2e6da8ccc040d2a43d89f8ccba
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Aug 16 15:38:49 2019 +0530
geo-rep: Fix worker connection issue
All the workers connects to primary slave node. It should
connect to available slave nodes in round robin fashion
and choose different slave node if the corresponding slave
node is down. This patch fixes the same.
Thanks Aravinda for the help in root causing this.
Change-Id: I9f8e7744f4adb8a24833cf173681d109710f98cb
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Updates: bz#1737484
commit 4726e205dba765d451a18b8a1d195069a41c2d71
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Jul 16 20:36:57 2019 +0530
posix: In brick_mux brick is crashed while start/stop volume in loop
Problem: In brick_mux environment sometime brick is crashed while
volume stop/start in a loop.Brick is crashed in janitor task
at the time of accessing priv.If posix priv is cleaned up before
call janitor task then janitor task is crashed.
Solution: To avoid the crash in brick_mux environment introduce a new
flag janitor_task_stop in posix_private and before send CHILD_DOWN event
wait for update the flag by janitor_task_done
Change-Id: Id9fa5d183a463b2b682774ab5cb9868357d139a4
fixes: bz#1730409
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit d1c584e4b387d22f9a182df7c8e7a97cd0266ca3
Author: Barak Sason <bsasonro@redhat.com>
Date: Sun Aug 18 12:21:47 2019 +0300
protocol/client - fixing a coverity issue
Moved null pointer check up in order to avoid seg-fault
CID: 1404258
Updates: bz#789278
Change-Id: Ib97e05302bfeb8fe38d6ce9870b9740cb576e492
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit ca1f380859f18caf54c8078bfb25b0f6a6f0d53b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 8 22:23:04 2019 +0300
client_t.c: removal of dead code.
Change-Id: Id9f5f448db305f3135a1fdca61b1d7ec898c63a4
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit dc6d875156f1b7612f1c8c7b9bdea9d00cdefe18
Author: Barak Sason <bsasonro@redhat.com>
Date: Thu Aug 15 15:54:28 2019 +0300
storage/posix - Moved pointed validity check in order to avoid possible seg-fault
CID: 1124831
Updates: bz#789278
Change-Id: Ia6550be3742849809cf3e0a4a39d9d6e77003b35
Signed-off-by: Barak Sason <bsasonro@redhat.com>
commit b9ec76b8388a2a848679bfa5c5c19107f31ed2ce
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Aug 19 16:00:24 2019 +0530
glusterd: ./tests/bugs/glusterd/bug-1595320.t is failing
Problem: sometime ./tests/bugs/glusterd/bug-1595320.t is failing is
failing at the time of checking brick_process after sending
a kill signal to brick process
Solution: Wait sometime after just sending a kill signal to brick
process to make sure brick process is stopped
Change-Id: Iee9e91284618abfc62a550d47e4f9117785def58
Fixes: bz#1743200
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 98c282203036642ed1f037f6c6b5f73a35cb5c43
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Sep 7 20:48:59 2018 +0530
tests/dht: Add a test file for file renames
Test the various combinations of hashed and cached
subvols for the src and dst.
Change-Id: I41416f9e5f2b7ea1c880d1913fdd6576da1ee868
fixes: bz#1626543
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 2cd1a4dee4ad8aaac943b66c2cf7785912b4e16e
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Aug 19 09:40:48 2019 +0530
tests: mark bug-1482023-snpashot-issue-with-other-processes-accessing-mounted-path.t as BRICK_MUX_BAD_TEST
Updates: bz#1743069
Change-Id: I1eea0186ca0c1b1226f4b3d0d7c0e41fc7821cbd
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 32cb9c3ad653d779bdcaf87cebdd6ba18e35c4e4
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Aug 13 18:45:43 2019 +0530
rpc: glusterd start is failed and throwing an error Address already in use
Problem: Some of the .t are failed due to bind is throwing
an error EADDRINUSE
Solution: After killing all gluster processes .t is trying
to start glusterd but somehow if kernel has not cleaned
up resources(socket) then glusterd startup is failed due to
bind system call failure.To avoid the issue retries to call
bind 10 times to execute system call succesfully
Change-Id: Ia5fd6b788f7b211c1508c1b7304fc08a32266629
Fixes: bz#1743020
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 7de620e0dfa455e1af11ded1b168082baca0b17e
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jun 28 22:51:37 2019 +0530
libglusterfs: remove dependency of rpc
Goal: 'libglusterfs' files shouldn't have any dependency outside of
the tree, specially the header files, shouldn't have '#include'
from outside the tree.
Fixes:
* Had to introduce libglusterd so, methods and structures required
for only mgmt/glusterd, and cli/ are separated from 'libglusterfs/'
* Remove rpc/xdr/gen from build, which was used mainly so
dependency for libglusterfs could be properly satisfied.
* Move rpcsvc_auth_data to client_t.h, so all dependencies could
be handled.
Updates: bz#1636297
Change-Id: I0e80243a5a3f4615e6fac6e1b947ad08a9363fce
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 4e662c95bf734160a0b2ad42dc5f2bc768f7ae40
Author: Philip Spencer <pspencer@fields.utoronto.ca>
Date: Tue May 7 10:19:34 2019 -0400
mount.glusterfs: make fcache-keep-open option take a value
Fixes: bz#1158130
Change-Id: Ifdeaed7c9fbe85f7ce421f7c89cbe7265e45f77c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7171f7d47a03d883eda7272c7a1ffb92e8078060
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Jul 30 17:05:22 2019 +0530
afr: restore timestamp of parent dir during entry-heal
Fixes: bz#1734370
Change-Id: I29e338bac62104233a6f80212df8d0fb016affda
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 90cac3341bdf5932d2622baf781bf9c2da446d1a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 6 23:20:02 2019 +0300
client-handshake.c: minor changes and removal of dead code.
- Removal of quite a bit of dead code.
- Use dict_set_str_sizen and friends where applicable.
- Moved some functions to be static and initialize values right away.
Change-Id: Ic25b5da4028198694a0e24796dea375661eb66b9
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 7becd367b10adc4cab811d92af48afc7f6a49dab
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Aug 1 16:20:33 2019 -0400
posix: don't expect timer wheel to be inited
Adding a timer to timer wheel should be done only after getting the
timer wheel from the ctx using the function glusterfs_ctx_tw_get(). The
function inits the wheel if not already done.
Change-Id: I9692f84b822a02a9dc14725b7c11d26a2a634e94
Updates: #703
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
commit 676ae71771f49dfedc45e4eeb69d3903d077016c
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Jul 25 11:51:32 2019 +0530
glusterd: create separate logdirs for cluster.rc instances
Create a separate logdir for each host instance created by
cluster.rc. This makes it easier to determine the files
belonging to a particular instance.
Change-Id: Ic8321f83f98995412b7d5f095b3d3f0391767a8b
Fixes: bz#1733042
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 4801fccf2f4ffe10bb2f3072c9751a0813c3c931
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Aug 9 14:34:22 2019 +0530
fuse: Set limit on invalidate queue size
If the glusterfs fuse client process is unable to
process the invalidate requests quickly enough, the
number of such requests quickly grows large enough
to use a significant amount of memory.
We are now introducing another option to set an upper
limit on these to prevent runaway memory usage.
Change-Id: Iddfff1ee2de1466223e6717f7abd4b28ed947788
Fixes: bz#1732717
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 8f18a210a9084249857ba6aac2ef650cd06124f2
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Aug 8 11:32:56 2019 +0530
cluster/ec: Fix coverity issue.
Change-Id: I727287784a15d89441865de7f438002e4a370250
fixes: bz#1738763
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit d48138460c8b0300b83ee973893c04e5662a7894
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jul 25 13:43:37 2019 +0530
gfapi: provide version for statedump path
Updates: bz#1689097
Change-Id: I2e3c2a3aef17fda67d04fa9e604ea3f8335a2b0b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 101977c0e95983ba3076a899168a082c7a398257
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Aug 7 12:12:43 2019 +0530
features/shard: Send correct size when reads are sent beyond file size
Change-Id: I0cebaaf55c09eb1fb77a274268ff564e871b743b
fixes bz#1738419
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit b15163e747c3225ca0e0434ade9dccc66217aff7
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Aug 12 11:29:36 2019 +0530
tests: fix bug-880898.t crash
Problem:
https://build.gluster.org/job/centos7-regression/7337/consoleFull
indicates the shd crashing for this .t. On looking at the core, I see
the crash is at the time of shd init and glusterfs context is null:
(gdb) bt
(gdb) p ctx
$2 = (glusterfs_ctx_t *) 0xf00000000
The .t is killing all gluster processes immediately after volume start,
so it looks like a race between shd coming up and it being killed.
Fix: Kill gluster processes only after they are up and running.
Fixes: bz#1740017
Change-Id: I7cf589201669bd9f535e968d147015dc99e9a4b6
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit b625c70062cf8d33ed102066fb474942b923e5e4
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Apr 3 14:23:06 2019 +0200
fuse: rate limit reading from fuse device upon receiving EPERM
Fixes: bz#1644322
Change-Id: I53e8fa362cd8c7d04fb1c4abb606a9abb642c592
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 1e97dc7adedf391694cb02b0a270c6af8c09c412
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Jul 25 10:49:10 2019 +0200
build: stop suppressing "Entering/Leaving direcory..." messages
This is useful information as it allows locating build issues quickly.
The size of the build output increases roughly by half of it, which
is a tolerable trade-off for better build time diagnostics.
updates bz#1193929
Signed-off-by: Csaba Henk <csaba@redhat.com>
Change-Id: Id60c03bee558528ae804f037c93457f9d9e738c0
commit 0bc57a1a7bc50be56f4958a09f8976381475906d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Aug 2 12:05:09 2019 +0530
cluster/ec: Update lock->good_mask on parent fop failure
When discard/truncate performs write fop, it should do so
after updating lock->good_mask to make sure readv happens
on the correct mask
fixes bz#1727081
Change-Id: Idfef0bbcca8860d53707094722e6ba3f81c583b7
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit d457e0134442b41480a2e124fb52f8fa3bf3622e
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Aug 5 19:00:21 2019 +0530
geo-rep: Fix Config Get Race
When two threads(sync jobs) in Geo-rep worker calls `gconf.get` and
`gconf.getr`(realtime) at the sametime, `getr` resets the conf object
and other one gets None. Thread Lock is introduced to fix the issue.
```
File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py",
line 368, in twrap
tf(*aargs)
File "/usr/libexec/glusterfs/python/syncdaemon/master.py", line 1987,
in syncjob
po = self.sync_engine(pb, self.log_err)
File "/usr/libexec/glusterfs/python/syncdaemon/resource.py",
line 1444, in rsync
rconf.ssh_ctl_args + \
AttributeError: 'NoneType' object has no attribute 'split'
```
Change-Id: I9c245e5c36338265354e158f5baa32b119eb2da5
Updates: bz#1737484
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 3b787e8e8c0f80d53716ef857537d1e09f7b25cd
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Aug 5 21:16:35 2019 +0530
rpc/transport: have default listen-port
With release-6, we now can have transport.socket.listen-port parameter
configurable in glusterd.vol. However the default value wasn't defined
in the code and this breaks the backward compatibility where if one has
a modified glusterd.vol file, then post upgrade the same file will be
retained and the new changes introduced as part of the release wouldn't
be available in the glusterd.vol. So it's important that for each new
options introduced in glusterd.vol file backward compatibility is
guaranteed.
Fixes: bz#1737676
Change-Id: I776b28bff786320cda299fe673d824024dc9803e
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit d6d0bcce9ada5cb0a9a4f1e3c0516f20325a550e
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jul 29 15:20:22 2019 +0530
cluster/dht: Log hashes in hex
Log layout hash ranges in hex to make it easier
to compare them to the on disk xattrs.
Change-Id: Ib75c2508bf8e0ab7f5ae26d0443ef02b792b7307
Fixes: bz#1697293
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 8fc25cb11b25972d835eb11afaaa8f43ecfeaa39
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Mon Aug 5 11:08:02 2019 +0800
features/utime: always update ctime at setattr
For the nfs EXCLUSIVE mode create may sets a later time
to mtime (at verifier), it should not set to ctime for
storage.ctime does not allowed set ctime to a earlier time.
/* Earlier, mdata was updated only if the existing time is less
* than the time to be updated. This would fail the scenarios
* where mtime can be set to any time using the syscall. Hence
* just updating without comparison. But the ctime is not
* allowed to changed to older date.
*/
According to kernel's setattr, always set ctime at setattr,
and doesnot set ctime from mtime at storage.ctime.
Change-Id: I5cfde6cb7f8939da9617506e3dc80bd840e0d749
fixes: bz#1737288
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
commit f07fa6bfa6de6dad4e875d8214068d879fcd3455
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Jul 5 14:12:54 2019 +0530
graph/shd: attach volfile even if ctx->active is NULL
While we receive a graph attach request, if ctx->active is
not set we used to fail assuming that the initilization has
not completed yet for the process start.
Since the management connection is established, it will receive
attach request, even when ctx->active is NULL.
Change-Id: Ied4d1ac63e6d4ced4a9405a78e1ce39f81dfd437
fixes: bz#1727256
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit bf751fff5d6054c3f7c1c533733fb482c2c5cd93
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Jul 4 15:43:05 2019 +0530
glusterd/shd: Return null proc if process is not running.
We were ruturning first proc entry even if it is not running.
This was in an assumption that the process could have just
started and not updated the pidfile.
Now we that we have introduced the states for process state,
we can take decision based on that.
Change-Id: Ibfc11c966b0db599a8d6a08d8b975233b2bbfb8c
Fixes: bz#1728766
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 338074cd3340b2a103c6fe866c6ffa941dce5e91
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Jul 31 15:31:34 2019 +0530
tests/shd: Break down shd mux tests into multiple .t file
Test file tests/basic/shd-mux.t was taking longer than 200
seconds in some iterations. So this patch is breaking the
test case to three files
Change-Id: I1430f58798f876edf6368d6f4b8b5a75f0114c31
Updates: bz#1708929
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 800b00d64b815d5f6f2212e6287357172ae76cfb
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Jul 30 10:15:42 2019 +0300
multiple files: reduce minor work under RCU_READ_LOCK
1. Try to unlock faster - in error paths.
2. Remove memory allocations - do them before the lock.
Change-Id: I1e9ddd80b99de45ad0f557d62a5f28951dfd54c8
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit c628e2b7b754fceed56e7d5bc11c64b782b0d87c
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Aug 1 19:00:56 2019 +0530
xdr: add code so we have more xdr functions covered
Updates: bz#1693692
Change-Id: Ia10ccca5e1fed6c4269842ebb4d507662ca0f6a6
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 83b7a5b63e5fe81cfbb6ea430c2e73d2dc75e84e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Aug 1 13:37:07 2019 -0400
storage/posix: set the op_errno to proper errno during gfid set
In posix_gfid_set, the proper error is not captured in one of
the failure cases.
Change-Id: I1c13f0691a15d6893f1037b3a5fe385a99657e00
Fixes: bz#1736482
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit bb63eeb45f501e5cbd269dee98ea5636ed22dcbb
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jul 29 11:51:07 2019 +0530
tests: introduce BRICK_MUX_BAD_TESTS variable
... to ignore test failures specific to brick mux.
Change-Id: I3114f34f194f18e7fc8c02a117b295f086721226
updates: bz#1193929
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 78a2b02f99e1a0f9a5e2061096c57c0167dbf8ff
Author: Susant Palai <spalai@redhat.com>
Date: Mon Jul 22 15:20:43 2019 +0530
locks/fencing: Address hang while lock preemption
The fop_wind_count can go negative when fencing is enabled
on unwind path of the IO leading to hang.
Also changed code so that fop_wind_count needs to be maintained only
till fencing is enabled on the file.
updates: bz#1717824
Change-Id: Icd04b42bc16cd3d50eaa581ee57233910194f480
Signed-off-by: Susant Palai <spalai@redhat.com>
commit a079c0f04cdebfeb213133c402cc4ede37d672c3
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jul 31 15:40:55 2019 +0530
geo-rep: Fix mount broker setup issue
Even the use builtin 'type' command as in patch [1]
causes issues if argument in question is not part of PATH
environment variable for that user. This patch fixes the
same by doing source /etc/profile. This was already being
used in another part of script.
[1] https://review.gluster.org/23089
Change-Id: Iceb78835967ec6a4350983eec9af28398410c002
fixes: bz#1734738
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit f3edd8743f8e956477446a14c650d1e50fe1bf4a
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jul 25 12:56:12 2019 +0530
gfapi: Fix deadlock while processing upcall
As mentioned in bug1733166, there could be potential deadlock
while processing upcalls depending on how each xlator choose
to act on it. The right way of fixing such issues
is to change rpc callback communication process.
- https://github.com/gluster/glusterfs/issues/697
Till then, making changes in gfapi layer to avoid any I/O
processing.
Change-Id: I2079e95339e5d761d5060707f4555cfacab95c83
fixes: bz#1733166
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 6fcd15a70058067a892b44b9adf12822a872a6c1
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Aug 1 12:13:05 2019 +0530
lcov: check for zerofill/discard fops on arbiter
Updates: bz#1693692
Change-Id: I145df4c0d0b0ce738f1d34b02341ec606e38522e
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7d5a40f35efe69853ddae441cadb782f0f363ed5
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sat Jun 8 01:22:27 2019 +0300
Multiple files: get trivial stuff done before lock
Initialize a dictionary for example seems to be prefectly fine to be done
before taking a lock.
Change-Id: Ib29516c4efa8f0e2b526d512beab488fcd16d2e7
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit d3675e31c19df02a9040d9e9e215b9a230dd559e
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jul 29 16:22:10 2019 +0530
posix/ctime: Fix race during lookup ctime xattr heal
Problem:
Ctime heals the ctime xattr ("trusted.glusterfs.mdata") in lookup
if it's not present. In a multi client scenario, there is a race
which results in updating the ctime xattr to older value.
e.g. Let c1 and c2 be two clients and file1 be the file which
doesn't have the ctime xattr. Let the ctime of file1 be t1.
(from backend, ctime heals time attributes from backend when not present).
Now following operations are done on mount
c1 -> ls -l /mnt/file1 | c2 -> ls -l /mnt/file1;echo "append" >> /mnt/file1;
The race is that the both c1 and c2 didn't fetch the ctime xattr in lookup,
so both of them tries to heal ctime to time 't1'. If c2 wins the race and
appends the file before c1 heals it, it sets the time to 't1' and updates
it to 't2' (because of append). Now c1 proceeds to heal and sets it to 't1'
which is incorrect.
Solution:
Compare the times during heal and only update the larger time. This is the
general approach used in ctime feature but got missed with healing legacy
files.
fixes: bz#1734299
Change-Id: I930bda192c64c3d49d0aed431ce23d3bc57e51b7
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 709a3446889f3f483a97bfd0b646985465159246
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jul 25 11:00:29 2019 +0530
gfapi: increase function-coverage
* Add few more mgmt functions to the coverage
* While testing mgmt function, found an issue, where if the
'glfs_set_volfile_server()' is not called before calling
'glfs_unset_volfile_server()', unset would cause a crash.
Null check of few variables fixes the issue, which is handled
in this patch itself.
* Added a test for volfile API
Updates: bz#1693692
Change-Id: Iba151f8da1b64107e2f436ddbfef9da45b1c1588
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 55abe05e23155a5dd7882da60b56158a99ca2854
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jul 30 17:12:58 2019 +0530
tests: heal-info add --xml option for more coverage
Updates: bz#1693692
Change-Id: I13de7cf4c380b9663e6258e2fd62ce1f180591b4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 0712d19e4f270f2a30c4e42ae936bfe1acd77f7c
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jul 25 10:55:01 2019 +0530
error-gen: increase coverage by reducing error-rate
Updates: bz#1693692
Change-Id: I07371ea1e2613fed6dd9ea67c40cbb3ebcb9387e
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7ff32f91b2a5d2d95fec01ca9135f5ff05ab2b8d
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jul 29 15:07:58 2019 +0530
trace: add more coverage by testing it with glfs-coverage too.
make sure to provide 'log-file' option, so we can see the logs.
This test does test volgen inserting the trace xlator in server
graph.
Updates: bz#1693692
Change-Id: I26c736b04376674b4c094d48060660421e6c983c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 880e76947d78b64e0459e7e98604595590151d0c
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Jul 30 10:32:39 2019 +0530
cluster/ec: Create heal task with heal process id
Problem:
ec_data_undo_pending calls syncop_fxattrop->SYNCOP without
a frame. In this case SYNCOP gets the frame of the task.
However, when we create a synctask for heal we provide
frame as NULL.
Now, if the read-only feature is ON, it will receive the
process ID of the shd as 0 and will consider that it as
not an internal process. This will prevent healing of a
file with "Read-only file system" error message log.
Solution:
While launching heal, create a synctask using frame and set
process id of the SHD which is -6.
Change-Id: I37195399c85de322cbcac75633888922c4e3db4a
Fixes: bz#1734252
commit 3f7656a15089cea7c6c99ea4dff45538d5cec424
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 29 14:08:37 2019 +0530
cluster/ec: Fix reopen flags to avoid misbehavior
Problem:
when a file needs to be re-opened O_APPEND and O_EXCL
flags are not filtered in EC.
- O_APPEND should be filtered because EC doesn't send O_APPEND below EC for
open to make sure writes happen on the individual fragments instead of at the
end of the file.
- O_EXCL should be filtered because shd could have created the file so even
when file exists open should succeed
- O_CREAT should be filtered because open happens with gfid as parameter. So
open fop will create just the gfid which will lead to problems.
Fix:
Filter out these two flags in reopen.
Change-Id: Ia280470fcb5188a09caa07bf665a2a94bce23bc4
Fixes: bz#1733935
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit b604a63580e77a2c5b47cdf4430992d9e2b31b80
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Jul 3 10:07:29 2019 +0300
dict.c: dict_unserialize() can use dict_addn()
Since we know the keylen, we can use dict_addn() instead of dict_add().
Change-Id: Iebe77faa1a20ec132cba5fb85b3d2ea63339181d
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 2b3786e446a0ebc982a447e7aca08c84791cd325
Author: Xiubo Li <xiubli@redhat.com>
Date: Fri Jul 26 12:34:52 2019 +0800
event: rename event_XXX with gf_ prefixed
I hit one crash issue when using the libgfapi.
In the libgfapi it will call glfs_poller() --> event_dispatch()
in file api/src/glfs.c:721, and the event_dispatch() is defined
by libgluster locally, the problem is the name of event_dispatch()
is the extremly the same with the one from libevent package form
the OS.
For example, if a executable program Foo, which will also use and
link the libevent and the libgfapi at the same time, I can hit the
crash, like:
kernel: glfs_glfspoll[68486]: segfault at 1c0 ip 00007fef006fd2b8 sp
00007feeeaffce30 error 4 in libevent-2.0.so.5.1.9[7fef006ed000+46000]
The link for Foo is:
lib_foo_LADD = -levent $(GFAPI_LIBS)
It will crash.
This is because the glfs_poller() is calling the event_dispatch() from
the libevent, not the libglsuter.
The gfapi link info :
GFAPI_LIBS = -lacl -lgfapi -lglusterfs -lgfrpc -lgfxdr -luuid
If I link Foo like:
lib_foo_LADD = $(GFAPI_LIBS) -levent
It will works well without any problem.
And if Foo call one private lib, such as handler_glfs.so, and the
handler_glfs.so will link the GFAPI_LIBS directly, while the Foo won't
and it will dlopen(handler_glfs.so), then the crash will be hit everytime.
The link info will be:
foo_LADD = -levent
libhandler_glfs_LIBADD = $(GFAPI_LIBS)
I can avoid the crash temporarily by linking the GFAPI_LIBS in Foo too like:
foo_LADD = $(GFAPI_LIBS) -levent
libhandler_glfs_LIBADD = $(GFAPI_LIBS)
But this is ugly since the Foo won't use any APIs from the GFAPI_LIBS.
And in some cases when the --as-needed link option is added(on many dists
it is added as default), then the crash is back again, the above workaround
won't work.
Fixes: #699
Change-Id: I38f0200b941bd1cff4bf3066fca2fc1f9a5263aa
Signed-off-by: Xiubo Li <xiubli@redhat.com>
commit b9661932e1fdad323602a5402e5a5928f27c797b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Jul 25 23:36:56 2019 +0300
glusterd: write voldir once in glusterd-store and don't attempt again.
glusterd_store_brickinfos() is calling per each brick the
function glusterd_store_brickinfo().
In it, we call:
ret = glusterd_store_create_brick_dir(volinfo);
However, volinfo is the same for all those bricks - no need to again
and again call it (which tries to mkdir that dir).
We can do it once above the loops in glusterd_store_brickinfos()
While at, combine two similar functions that write additional dirs.
Change-Id: I5858cf7783f088ea13a8fa20115118efa816f4cb
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 1fb96fe0383a022395346835ac9dde24a124b3c3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jul 18 11:25:31 2019 +0530
cluster/ec: Always read from good-mask
There are cases where fop->mask may have fop->healing added
and readv shouldn't be wound on fop->healing. To avoid this
always wind readv to lock->good_mask
fixes bz#1727081
Change-Id: I2226ef0229daf5ff315d51e868b980ee48060b87
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 86b4dd40cd08662a6bf9b0367415dbc46df348b7
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Jul 9 11:06:49 2019 +0200
fuse: add missing GF_FREE to fuse_interrupt
Change-Id: Id7e003e4a53d0a0057c1c84e1cd704c80a6cb015
Fixes: bz#1728047
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 4a488cdf830d62b7957b85a34d2ca8d8af2c4b74
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jul 25 12:29:15 2019 +0530
quiesce: add missing fops
Updates: bz#1693692
Change-Id: I4f005e7168c201709a85db443d643b81e6d3d282
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit b80622373d7cfcd87a96ddfe60a01dfa25361927
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Tue Jul 23 13:16:04 2019 +0000
fix return of local in __nlc_inode_ctx_get
__nlc_inode_ctx_get assigns a value to nlc_pe_p which is never used by
its parent function or any of the predecessor hence remove the
assignment and also that function argument as it is not being used
anywhere.
fixes: bz#1732496
Change-Id: I5b950e1e251bd50a646616da872a4efe9d2ff8c9
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 6de11bfdd28a2eeb51ff6ba40090b39b106ba6c4
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Jul 17 14:50:22 2019 +0200
cluster/ec: fix EIO error for concurrent writes on sparse files
EC doesn't allow concurrent writes on overlapping areas, they are
serialized. However non-overlapping writes are serviced in parallel.
When a write is not aligned, EC first needs to read the entire chunk
from disk, apply the modified fragment and write it again.
The problem appears on sparse files because a write to an offset
implicitly creates data on offsets below it (so, in some way, they
are overlapping). For example, if a file is empty and we read 10 bytes
from offset 10, read() will return 0 bytes. Now, if we write one byte
at offset 1M and retry the same read, the system call will return 10
bytes (all containing 0's).
So if we have two writes, the first one at offset 10 and the second one
at offset 1M, EC will send both in parallel because they do not overlap.
However, the first one will try to read missing data from the first chunk
(i.e. offsets 0 to 9) to recombine the entire chunk and do the final write.
This read will happen in parallel with the write to 1M. What could happen
is that half of the bricks process the write before the read, and the
half do the read before the write. Some bricks will return 10 bytes of
data while the otherw will return 0 bytes (because the file on the brick
has not been expanded yet).
When EC tries to recombine the answers from the bricks, it can't, because
it needs more than half consistent answers to recover the data. So this
read fails with EIO error. This error is propagated to the parent write,
which is aborted and EIO is returned to the application.
The issue happened because EC assumed that a write to a given offset
implies that offsets below it exist.
This fix prevents the read of the chunk from bricks if the current size
of the file is smaller than the read chunk offset. This size is
correctly tracked, so this fixes the issue.
Also modifying ec-stripe.t file for Test #13 within it.
In this patch, if a file size is less than the offset we are writing, we
fill zeros in head and tail and do not consider it strip cache miss.
That actually make sense as we know what data that part holds and there is
no need of reading it from bricks.
Change-Id: Ic342e8c35c555b8534109e9314c9a0710b6225d6
Fixes: bz#1730715
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 90b7c8c4045ca9fb166c0e2b2d0f17f676d6b692
Author: MPLX <mplx+redhat@donotreply.at>
Date: Thu Jul 18 12:13:09 2019 +0530
extras/mount-shared-storage.sh: consider options to mount
If different mount options are given to glusterfs in /etc/fstab, it
was not considered in the script.
Fixes: bz#1690454
Change-Id: If829b3d6ab79755647626edcb31f38a3716989db
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 77fb9474fd9021825c31c64a9c6ac7a68f16e4a6
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Thu Jun 27 13:18:32 2019 +0530
gluster-block: tuning perf options
As per the perf experiment run by Elvir, with NVME devices used for OCP (gluster)
it was seen that particularly read operations (read/randread) benefited from
these options.
Change-Id: Ibec4b96afd28e6f7e757b6ef203ccdbc0d9854d5
Fixes: bz#1727852
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
commit fb4059911b00b3f8d3851e2e28c3566421848e5d
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Jul 8 11:34:49 2019 +0530
core: use more restrictive mode while creating the directories
fixes: bz#1724024
Change-Id: I539fb7248b2cfc037ec29f1413ea648f9ec21ef2
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit c6bb0884d1b2ec0200d02a7ed0485bb7a696edf0
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jul 22 17:35:21 2019 +0530
geo-rep: Fix mount broker setup issue
The patch [1] added validation in gverify.sh to check if the gluster
binary on slave by executing gluster directly on slave. But for
non-root users, even though gluster binary is present, path is not
found when executed via ssh. Hence validate the gluster binary using
bash builtin 'type' command.
[1] https://review.gluster.org/19224
Change-Id: I93ca62c0c5b1e16263e586ddbbca8407d60ca126
fixes: bz#1731920
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 8851a2082b75293e53704dc004ff52ac6a555298
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jul 22 10:23:56 2019 +0530
backup-volfile-server: ignore duplicate entries
Erroring out for duplicate entries for backup_volfile_servers would
cause failures for some script. This option is harmless if it is
duplicate, we just need to ignore this.
Fixes: bz#1730953
Change-Id: I950064501a7bb61b90e99f2c079564f9c923d4c1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 5ab0c31cee959499f74e451b3c0e679834d7eb82
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 22 20:55:33 2019 +0530
features/utime: Fix mem_put crash
Problem:
When frame->local is not null FRAME_DESTROY calls mem_put on it.
Since the stub is already destroyed in call_resume(), it leads
to crash
Fix:
Set frame->local to NULL before calling call_resume()
fixes: bz#1593542
Change-Id: I0f8adf406f4cefdb89d7624ba7a9d9c2eedfb1de
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 8a69f45541d8a2d7e41591aeae550ff5341f24f0
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Jun 2 21:14:18 2019 +0300
(multiple files) use dict_allocate_and_serialize() where applicable.
This function does length, allocation and serialization for you.
Change-Id: I142a259952a2fe83dd719442afaefe4a43a8e55e
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 66f3205eb239a2c6b61269fef5d34c846b332d3a
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jun 24 13:06:49 2019 +0530
ctime: Set mdata xattr on legacy files
Problem:
The files which were created before ctime enabled would not
have "trusted.glusterfs.mdata"(stores time attributes) xattr.
Upon fops which modifies either ctime or mtime, the xattr
gets created with latest ctime, mtime and atime, which is
incorrect. It should update only the corresponding time
attribute and rest from backend
Solution:
Creating xattr with values from brick is not possible as
each brick of replica set would have different times.
So create the xattr upon successful lookup if the xattr
is not created
Note To Reviewers:
The time attributes used to set xattr is got from successful
lookup. Instead of sending the whole iatt over the wire via
setxattr, a structure called mdata_iatt is sent. The mdata_iatt
contains only time attributes.
Change-Id: I5e535631ddef04195361ae0364336410a2895dd4
fixes: bz#1593542
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 532c81d727ed8d577a2d0152fa47205e440ba04c
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Tue Jul 2 15:00:25 2019 +0530
geo-rep: Test case for upgrading config file
Added test case for the patch
https://review.gluster.org/#/c/glusterfs/+/22894/4
Also updated if else structure in gsyncdconfig.py to avoid
repeated occurance of values in new configfile.
fixes: bz#1707731
Change-Id: If97e1d37ac52dbd17d47be6cb659fc5a3ccab6d7
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit d85df9cc9b36043854051d282ba9c98c361bd7f0
Author: Susant Palai <spalai@redhat.com>
Date: Tue Jul 16 10:31:46 2019 +0530
dht: log getxattr failure for node-uuid at "DEBUG"
There are two ways to fetch node-uuid information from dht.
1 - #define GF_XATTR_LIST_NODE_UUIDS_KEY "trusted.glusterfs.list-node-uuids"
This key is used by AFR.
2 - #define GF_REBAL_FIND_LOCAL_SUBVOL "glusterfs.find-local-subvol"
This key is used for non-afr volume type.
We do two getxattr operations. First on the #1 key followed by on #2 if
getxattr on #1 key fails.
Since the parent function "dht_init_local_subvols_and_nodeuuids" logs failure,
moving the log-level to DEBUG in dht_find_local_subvol_cbk.
fixes: bz#1730175
Change-Id: I4d88244dc26587b111ca5b00d4c00118efdaac14
Signed-off-by: Susant Palai <spalai@redhat.com>
commit afd6e5c2b200d7b8f4968d70f32e78ac0d1454bf
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Jul 11 18:57:13 2019 +0800
cluster/ec: skip updating ctx->loc again when ec_fix_open/opendir
The ec_manager_open/opendir memsets ctx->loc which causes
memory/inode leak, and ec_fheal uses ctx->loc out of fd->lock
that loc_copy may copy bad data when memset it.
This patch skips updating ctx->loc when it is initilizaed.
With it, ctx->loc is filled once, and never updated.
Change-Id: I3bf5ffce4caf4c1c667f7acaa14b451d37a3550a
fixes: bz#1729772
Signed-off-by: Kinglong Mee <mijinlong@horiscale.com>
commit 18e5def492a0610f59f6223ce007e3e25ad93cfd
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Jul 3 20:47:52 2019 +0300
logging.c: check for skip_logging() in _gf_slog(), _gf_smsg()
Before processing anything, check if we actually need to do any logging,
based on the log level.
Change-Id: Iec5b9869831e1bdf22d12becc5e3d3ece87906a7
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit f121d78cfeb6a8a4d0d526dba5db65c069ea908a
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Mon Jul 8 21:13:28 2019 +0800
cluster/ec: inherit healing from lock when it has info
If lock has info, fop should inherit healing mask from it.
Otherwise, fop cannot inherit right healing when changed_flags is zero.
Change-Id: Ife80c9169d2c555024347a20300b0583f7e8a87f
fixes: bz#1727081
Signed-off-by: Kinglong Mee <mijinlong@horiscale.com>
commit 6e08269e5939095fcd1d7a45bf0ff37467878f1e
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Jun 5 20:16:40 2019 +0300
cli: defer create_frame() (and dict creation) to later stages.
Where possible, defer create_frame() - whenever possible, after
command line verification, for example.
Change-Id: Id6606e90e7ea6190f30b225c4733b229c519bb2f
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 103692d4ea30b923be78bf06ab7ffafa5fc8de60
Author: Homma <homma@allworks.co.jp>
Date: Fri Jul 5 16:10:41 2019 +0530
system/posix-acl: update ctx only if iatt is non-NULL
We need to safe-guard against possible zero'ing out of iatt
structure in acl ctx, which can cause many issues.
fixes: bz#1668286
Change-Id: Ie81a57d7453a6624078de3be8c0845bf4d432773
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit a5c0eb01e05a9a601953a347a5e9fd1db25eccc9
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Jul 15 11:51:58 2019 +0530
tests: Fix bug-1717819-metadata-split-brain-detection.t failure
Problem:
tests/bugs/replicate/bug-1717819-metadata-split-brain-detection.t fails
intermittently in test cases #49 & #50, which compare the values of the
user set xattr values after enabling the heal. We are not waiting for
the heal to complete before comparing those values, which might lead
those tests to fail.
Fix:
Wait till the HEAL-TIMEOUT before comparing the xattr values.
Also cheking for the shd to come up and the bricks to connect to the shd
process in another case.
Change-Id: I0e245b328da9df23ce70c5300278fad1c1d9f7ff
Fixes: bz#1729847
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 4a6c665869e6ab6ee4b45251c5b3eb6f6a251123
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sat Apr 20 19:11:33 2019 +0300
dht-common.h: reorder variables to reduce padding.
Manually added '-Wpadded' to get warnings on padding, and reordered
structs to reduce most of them.
Change-Id: I0c505fcb3dfef76399ac9d5d33bfb235354532de
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 63edce254985c0ee9f3a05c52e131c88bbd0c7b2
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Jul 4 13:21:33 2019 +0200
core: fix deadlock between statedump and fd_anonymous()
There exists a deadlock between statedump generation and fd_anonymous()
function because they are acquiring inode table lock and inode lock in
reverse order.
This patch modifies fd_anonymous() so that it takes inode lock only when
it's really necessary, avoiding the deadlock.
Change-Id: I24355447f0ea1b39e2546782ad07f0512cc381e7
Fixes: bz#1727068
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 2a5bdb12bfd59f6ec9387f90294c6ad373f1530a
Author: Liguang Li <liguang.lee6@gmail.com>
Date: Fri Jun 21 12:18:58 2019 +0800
Detach iot_worker to release its resources
When iot_worker terminates, its resources have not been reaped, which
will consumes lots of memory.
Detach iot_worker to automically release its resources back to the
system.
fixes: bz#1729107
Change-Id: I71fabb2940e76ad54dc56b4c41aeeead2644b8bb
Signed-off-by: Liguang Li <liguang.lee6@gmail.com>
commit 7065309f24f2078ff07f7e4b7ddedbb1630f1a16
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Jul 12 16:28:04 2019 +0530
glusterd: do not mark skip_locking as true for geo-rep operations
We need to send the commit req to peers in case of geo-rep
operations even though it is a no volname operation. In commit
phase peers try to set the txn_opinfo which will fail because
it is a no volname operation where we don't require a commit
phase. We mark skip_locking as true for no volname operations,
but we have to give an exception to geo-rep operations, so that
they can set txn_opinfo in commit phase.
Please refer to detailed RCA at the bug: 1729463
fixes: bz#1729463
Change-Id: I9f2478b12a281f6e052035c0563c40543493a3fc
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 628aff12a5768a63a966eabfe4861f0b825d574a
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jul 10 12:34:34 2019 +0530
Fix spelling errors
Fixes: bz#1728554
Change-Id: I88357aed7c14988a12616035c3738c32c09a8f9a
Signed-off-by: Patrick Matthäi <pmatthaei@debian.org>
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 4af8d2f0281897c258bd91da459daad8010eb9b3
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 12 16:12:18 2019 +0530
ibverbs/rdma: remove from build
We have proposed about this an year ago, and with recent smoke
failures, it looks like the right time to take such call.
ref: https://lists.gluster.org/pipermail/gluster-users/2018-July/034400.html
With this, glusterfs-8.0 wouldn't have rdma feature, and would
allow some modularity changes possible with rpc layer (as we would
have just 1 transport)
Updates: bz#1635688
Change-Id: Ia277dca4d4b1f0cffae20819024a52b075b775e5
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit dea13c83eaf252061ccaa191b9d1814b821ba25d
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jul 2 16:50:23 2019 -0400
features/snapview-server: obtain the list of snapshots inside the lock
The current list of snapshots from priv->dirents is obtained outside
the lock.
Change-Id: I8876ec0a38308da5db058397382fbc82cc7ac177
Fixes: bz#1726783
commit 9b94cbcb9f72ee3a0f7f8cf00ee570697631fc39
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Jun 26 12:19:07 2019 +0530
cluster/ta: Notify the clients only if there are pending heals
Problem:
In case of thin arbiter, before index healer starts crawling the
indices at every heal-timeout interval, even if there is nothing to
be healed it will send an upcall notification to all the clients to
release any AFR_TA_DOM_NOTIFY locks that they hold. SHD will wait
for the upcall to return before proceeding with the heal even though
there is nothing to be healed. This will also invalidates the cached
information about the bricks states on the clients which leads to
extra calls on TA from clients for the next reads & writes if needed.
This will impact the IO performance.
Fix:
- Before sending the upcall to the clients, check for any pending heals
on TA without taking any locks.
- If there is nothing marked bad on TA, then continue with the index
crawl to heal any dirty markings present on the files due to any post-op
failure.
- If there is a brick marked as bad on TA, then take the
AFR_TA_DOM_NOTIFY lock on TA from SHD, get the state on TA and
continue with the current healing process.
Change-Id: Ieb477bc6cb18bbdfd4e7a0453c5ed79b574ec9d6
fixes: bz#1724184
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit c06ba5f17e5489f4a3192ff7fbcb622b13789e2b
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Jun 12 11:57:02 2019 +0530
cluster/afr: Fix incorrect reporting of gfid & type mismatch
Problems:
1. When checking for type and gfid mismatch, if the type or gfid
is unknown because of missing gfid handle and the gfid xattr
it will be reported as type or gfid mismatch and the heal will
not complete.
2. If the source selected during entry heal has null gfid the same
will be sent to afr_lookup_and_heal_gfid(). In this function when
we try to assign the gfid on the bricks where it does not exist,
we are considering the same gfid and try to assign that on those
bricks. This will fail in posix_gfid_set() since the gfid sent
is null.
Fix:
If the gfid sent to afr_lookup_and_heal_gfid() is null choose a
valid gfid before proceeding to assign the gfid on the bricks
where it is missing.
In afr_selfheal_detect_gfid_and_type_mismatch(), do not report
type/gfid mismatch if the type/gfid is unknown or not set.
Change-Id: Ia06552e4dc4a9f89cb7f5302833604bd21bbf7da
fixes: bz#1722507
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 4ef26f1519eaaabfc2b1e6cc9ba808cf2ebf9db7
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Jun 20 15:50:01 2019 -0700
Replace usleep() with nanosleep()
As usleep has been obsoleted, changed all invocations of usleep
to nanosleep. From man 3 usleep:
"4.3BSD, POSIX.1-2001. POSIX.1-2001 declares this function
obsolete; use nanosleep(2) instead. POSIX.1-2008 removes the
specification of usleep()."
Added a helper function gf_nanosleep() to have a single place
for handling edge cases that might arise from the conversion of
usleep to nanosleep and allow the sleep to resume with right
remaining value upon being interrupted.
Fixes: bz#1721686
Change-Id: Ia39ab82c9e0f4669d2c00d4cdf25e38d94ef9f62
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit ece98805a5a2317a563dfc07f68e533d2c21d4dd
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Jul 9 16:32:36 2019 -0700
Remove hadoop related code from the codebase
As Hadoop is no longer supported, dropping code for
handling Hadoop access.
Fixes: bz#1728417
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Change-Id: I8fcf4faacb364f1c9a8abb0c48faec337087f845
commit 319d6a15db0484acf4a24b8d727b056a939e70f5
Author: kshithijiyer <kshithij.ki@gmail.com>
Date: Thu Jul 4 19:03:34 2019 +0530
geo-replication/setup.py missing license details in setup()
geo-replication/setup.py is missing license details in
setup() and is using string 'syncdaemon' instead
of using the variable name which has the same value.
Present:
setup(
name=name,
version="",
description='GlusterFS Geo Replication',
license='',
author='Red Hat, Inc.',
author_email='gluster-devel@gluster.org',
url='http://www.gluster.org',
packages=['syncdaemon', ],
test_suite='nose.collector',
install_requires=[],
scripts=[],
entry_points={},
)
Changing to:
setup(
name=name,
version="",
description='GlusterFS Geo Replication',
license='GPLV2 and LGPLV3+',
author='Red Hat, Inc.',
author_email='gluster-devel@gluster.org',
url='http://www.gluster.org',
packages=[name, ],
test_suite='nose.collector',
install_requires=[],
scripts=[],
entry_points={},
)
fixes: bz#1727107
Change-Id: I742c4c510da55a22256c819da7e2fc9622119f63
Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
commit 160fc2914a0d1a0b47c1502a9646f097e96d21fc
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun May 5 13:19:31 2019 +0530
rpc/xdr: include nfs specific files in build only if gNFS is enabled
updates: bz#1193929
Change-Id: I2b85fd0a04c77815a154f445ec8fb4da37dcbe40
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit c106e8983e85bf6441275e535fbc1050443b6a5c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Jun 24 12:00:20 2019 +0530
glusterd/svc: update pid of mux volumes from the shd process
For a normal volume, we are updating the pid from a the
process while we do a daemonization or at the end of the
init if it is no-daemon mode. Along with updating the pid
we also lock the file, to make sure that the process is
running fine.
With brick mux, we were updating the pidfile from gluterd
after an attach/detach request.
There are two problems with this approach.
1) We are not holding a pidlock for any file other than parent
process.
2) There is a chance for possible race conditions with attach/detach.
For example, shd start and a volume stop could race. Let's say
we are starting an shd and it is attached to a volume.
While we trying to link the pid file to the running process,
this would have deleted by the thread that doing a volume stop.
Change-Id: I29a00352102877ce09ea3f376ca52affceb5cf1a
Updates: bz#1722541
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit aaed4eba9118519c24fa648d3d0c14cdc595b013
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Mon Jul 8 15:09:39 2019 +0530
posix: fix Wformat-overflow warning
warning: ‘%s’ directive argument is null
Change-Id: I2ce9560f98a8310886c31384e40c2e101ad2c719
updates: bz#1193929
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 7f8377ef33bf47c3c7b9d72efac7302ed2e5c9fe
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Fri Jul 5 16:51:45 2019 +0530
glusterd: fix packed member address warning
warning: taking address of packed member of
‘struct _quota_limits’ may result in an
unaligned pointer value.
Change-Id: Ib889c99184560f0d24dbcc4fae10b563a2b9b7fd
updates: bz#1193929
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit eb4c7b7c6de67be936f3cb185c496765ac6dbb6a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 9 19:02:53 2019 +0530
quick-read: rename cache-invalidation key to avoid redundant keys
With group-metadata-cache group profile settings
performance.cache-invalidation option when turned on enables both md-cache
and quick-read xlator's cache-invalidation feature. While the intent of
the group-metadata-cache is to set md-cache xlator's cache-invalidation
feature, quick-read xlator also gets affected due to the same. While
md-cache feature and it's profile existed since release-3.9,
quick-read cache-invalidation was introduced in release-4 and due to
this op-version mismatch on any cluster which is >= glusterfs-4 when
this group profile is applied it breaks backward compatibility with the
old clients.
The proposed fix here is to rename the key in quick-read to
'quick-read-cache-invalidation' so that both these features have
distinct identification. While this brings in by itself a backward
compatibility challenge where this feature is enabled in an existing
cluster and when the same is upgraded to a version where this change
exists, it will lead to an unidentified old key. But as a workaround we
can always ask users upgrading to release-7 version to turn off this
option, upgrade the cluster and turn it back on with the new key. This
needs to be documented once the patch is accepted.
Fixes: bz#1698042
Change-Id: I30422ba6496208e21191a8d78ad29b2e21078664
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 26431d24eab4c54314eb694abbcb2f848dc04e9a
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Fri Jul 5 15:16:23 2019 +0800
gnfs: use strcpy to prevent memory overflow
fixes: bz#1727248
Change-Id: Iea289032a8feecf2945668d3fb44a6a53089fdea
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit 0de037a62ba48b26f71216e4bf6be0aa60a3eb22
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Jun 21 14:24:42 2019 +0300
glusterd.h: align structs
Move some variables around to reduce compiler padding.
Change-Id: I9cd53ce257fb169270c295ac60d58d4a6a950d4f
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 10241892e26c851d2fc16dbd3b4200dbaa610909
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Jul 3 15:22:38 2019 +0530
glusterd: Show the correct brick status in get-state
Problem: get-state does not show correct brick status if brick
status is not Started, it always shows started if any value
is set brickinfo->status
Solution: Check the value of brickinfo->status to show correct status
in get-state
Change-Id: I12a79619024c2cf59f338220d144f2f034059b3b
fixes: bz#1726906
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit fe5be85b9b1f803a81dcce600db3544d2625835b
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Jul 2 15:23:00 2019 +0530
glusterd: don't log a warning message for tier-enabled key
We are logging a warning message saying unknown-key for
tier-enabled kay. although the tier xlator is deprecated,
this key is left behind for handling the peer rejection
issues in a heterogeneous cluster. We need not to log if
this key is not found/recognised.
updates: bz#1193929
Change-Id: Ia68661898a618f99a240ca8d8a124ff6a65ebe9d
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit f8a3f60f462c743d6b0e56d4bcddd97d8a6bc60c
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jun 25 10:51:33 2019 -0400
features/snapview-server: use the same volfile server for gfapi options
snapview server xlator makes use of "localhost" as the volfile server while
initing the new glfs instance to talk to a snapshot. While localhost is fine,
better use the same volfile server that was used to start the snapshot
daemon containing the snapview-server xlator.
Change-Id: I4485d39b0e3d066f481adc6958ace53ea33237f7
fixes: bz#1725211
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 27ba29eb55ad3e110d50ad09ea5b4186184ffab4
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Jun 21 09:04:19 2019 +0530
cluster/dht: Fixed a memleak in dht_rename_cbk
Fixed a memleak in dht_rename_cbk when creating
a linkto file.
Change-Id: I705adef3cb79e33806520fc2b15558e90e2c211c
fixes: bz#1722698
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 86a1d0004116aaccad36dcf02f4463494f5e1874
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Mon Jul 1 20:48:31 2019 +0530
cli: Remove Wformat-truncation compiler warning
This warning is issued due to unhandled output truncation.
As in the code, truncation is expected, we can remove this
warning by placing a check on the return value of the function
and handling it.
In this way, the warning will not be issued.
Change-Id: I1820b58fe9a7601961c20944b259df322db35057
updates: bz#1193929
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit bb209d42b655f292045a434e4342292122df67c5
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jun 24 19:24:05 2019 +0530
glusterfs-fops: fix the modularity
glusterfs-fops.h was moved to rpc/xdr to support compound fops.
(ref: https://review.gluster.org/14032, 2f945b86d3)
This was fine as long as all these header files were in single
include directory after 'install'. With the move to separate out
glusterfs specific header files into another directory inside
/usr/include (ref: https://review.gluster.org/21746, 20ef211cfa),
glusterfs-fops.h file was not in the proper path when an external
.c file tried to include any of glusterfs specific .h file (like
xlator.h).
Now, we have removed compound-fops, with that, none of the enums
declared in glusterfs-fops.h are actually getting used on wire
anymore. Hence, it makes sense to get this to libglusterfs/src
as a single point of definition. With this change, the external
programs can use glusterfs header files.
also remove some enum definitions which are not used in code
anymore.
Updates: bz#1636297
Change-Id: I423c44d3dbe2efc777299c544ece3cb172fc7e44
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 1b2b4ca4023874b95d37e99dbc51c443d4f76f70
Author: kshithijiyer <kshithij.ki@gmail.com>
Date: Fri Jun 28 15:32:31 2019 +0530
Removing one top command from gluster v help
The current help show 2 different top commands
intead of one single top command which can be
easily observed when "# gluster v help" command
is issued. Removing one "volume top <VOLNAME>"
and clubbing into them into a single command.
Current help:
volume top <VOLNAME> {open|read|write|opendir|readdir|clear}
[nfs|brick <brick>] [list-cnt <value>] |
volume top <VOLNAME> {read-perf|write-perf}
[bs <size> count <count>] [brick <brick>]
[list-cnt <value>] - volume top operations
Expected help:
volume top <VOLNAME> {open|read|write|opendir|readdir|clear}
[nfs|brick <brick>] [list-cnt <value>] | {read-perf|write-perf}
[bs <size> count <count>] [brick <brick>] [list-cnt <value>]
- volume top operations
fixes: bz#1725034
Change-Id: Ifbc4c95f2558286e27dfc5e9667046b80eb1715d
Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
commit 887f03e46aff909c493a4447eaed4feb89f6a47f
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Jun 17 17:54:01 2019 +0530
core: use multiple servers while mounting a volume using ipv6
According to man page:
mount -t glusterfs [-o <options>] <server1>,<server2>,
<server3>,..<serverN>:/<volname>[/<subdir>] <mount_point>
When we try
mount -t glusterfs 52:54:00:23:5a:b6,52:54:00:a0:be:ed:/ta-vol1 /mnt/ta
we see the below msg in log:
[2019-06-17 11:41:36.085809] I [MSGID: 100030] [glusterfsd.c:2867:main] 0-/usr/local/sbin/glusterfs: Started running /usr/local/sbin/glusterfs version 7dev (args: /usr/local/sbin/glusterfs --process-name fuse --volfile-server=52:54:00:23:5a --volfile-id=/ta-vol1 /mnt/ta)
With this change, we'll able to give multiple volfile servers
while mounting the volume using ipv6.
After the change, I see the following in log:
[2019-06-17 12:00:21.183658] I [MSGID: 100030] [glusterfsd.c:2867:main] 0-/usr/local/sbin/glusterfs: Started running /usr/local/sbin/glusterfs version 7dev (args: /usr/local/sbin/glusterfs --process-name fuse --volfile-server=52:54:00:23:5a:b6 --volfile-server=52:54:00:a0:be:ed --volfile-id=/ta-vol1 /mnt/ta)
fixes: bz#1719290
credits: Aga <aga_1990@hotmail.com>
Change-Id: Icf89bea3ba15d8374ef428aeb59f2ef55ad544ec
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 41ce71f40b94f1559742136c49389191346be4ae
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jun 27 10:49:30 2019 +0530
glusterd: fix clang scan defects
Fixes following:
https://build.gluster.org/job/clang-scan/744/clangScanBuildBugs/browse/report-dd8d31.html#EndPath
https://build.gluster.org/job/clang-scan/744/clangScanBuildBugs/browse/report-89a1cd.html#EndPath
Updates: bz#1622665
Change-Id: Ibd201fb2ca54ae7ae3fed8a8d87815358b614349
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit be390f0e5d5670281193e4fc818c347ce67473cf
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Jun 26 16:23:15 2019 +0200
rfc.sh: Improve bug identification
When a backport is done and there is more than one bug reference in the
commit message (normally we include the old bug reference in the commit
message), old rfc.sh may choose the incorrect bug id.
This patch improves the regular expression to locate the bug id.
Updates: bz#1193929
Change-Id: Ifaa4e50c0ddba21c16ef0c5a1f6d46c315cf3378
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit cc51d2ab9834f4fc01fcf219bb727d089d5fc271
Author: Vishal Pandey <vpandey@redhat.com>
Date: Wed Apr 24 13:37:16 2019 +0530
glusterd/thin-arbiter: Thin-arbiter integration with GD1
gluster volume create <VOLNAME> replica 2 thin-arbiter 1 <host1>:<brick1> <host2>:<brick2>
<thin-arbiter-host>:<path-to-store-replica-id-file> [force]
The changes have been made in a way that the last brick in the bricks list
will be treated as the thin-arbiter.
GD1 will be manipulated to consider replica count to be as 2 and continue creating the
volume like any other replica 2 volume but since thin-arbiter volumes need ta-brick
client xlator entries for each subvolume in fuse volfile, volfile generation is
modified in a way to inject these entries seperately in the volfile for every subvolume.
Few more additions -
1- Save the volinfo with new fields ta_bricks list and thin_arbiter_count.
2- Introduce a new option client.ta-brick-port to add remote-port to ta-brick xlator entry
in fuse volfiles. The option can be set using the following CLI syntax -
gluster volume set <VOLNAME> client.ta-brick-port <PORTNO.>
3- Volume Info will contain a Thin-Arbiter-path entry to distinguish
from other replicate volumes.
Change-Id: Ib434e2313b29716f32476c6c211d282c4ef39406
Updates #687
Signed-off-by: Vishal Pandey <vpandey@redhat.com>
commit 0b767519bee0fbfdd03c830212a1247ad8fe13a4
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Jun 20 18:47:45 2019 +0530
geo-rep : fix gluster command path for non-root session
Problem:
gluster command not found.
Cause:
In Volinfo class we issue command 'gluster vol info' to get information
about volume like getting brick_root to perform various operation.
When geo-rep session is configured for non-root user Volinfo class
fails to issue gluster command due to unavailability of gluster
binary path for non-root user.
Solution:
Use config value 'slave-gluster-command-dir'/'gluster-command-dir' to get path
for gluster command based on caller.
fixes: bz#1722740
Change-Id: I4ec46373da01f5d00ecd160c4e8c6239da8b3859
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 1f03309f3f7a251de26c10cfc8a64650a20a2790
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Jun 26 17:34:23 2019 +0200
run-tests.sh: stop test on Ctrl-C
When a test is run through 'timeout' command, Ctrl-C becomes useless and
the test cannot be stopped.
Added '--foreground' option to 'timeout' command that makes it possible
to use Ctrl-C.
Updates: bz#1193929
Change-Id: I160984d1aba470e3a4a1135bd5fa57471046f52f
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 887a890d1c07834c99f26fbb8faac8421ad2145a
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Jun 27 19:17:29 2019 +0530
graph/shd: Use top down approach while cleaning xlator
We were cleaning xlator from botton to top, which might
lead to problems when upper xlators trying to access
the xlator object loaded below.
One such scenario is when fd_unref happens as part of the
fini call which might lead to calling the releasedir to
lower xlator. This will lead to invalid mem access
Change-Id: I8a6cb619256fab0b0c01a2d564fc88287c4415a0
Updates: bz#1716695
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 8c85d83b5e38334a5f7e5416547140137a2a2689
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Jun 4 19:22:45 2019 +0530
protocol/client: propagte GF_EVENT_CHILD_PING only for connections to brick
Two reasons:
* ping responses from glusterd may not be relevant for Halo
replication. Instead, it might be interested in only knowing whether
the brick itself is responsive.
* When a brick is killed, propagating GF_EVENT_CHILD_PING of ping
response from glusterd results in GF_EVENT_DISCONNECT spuriously
propagated to parent xlators. These DISCONNECT events are from the
connections client establishes with glusterd as part of its
reconnect logic. Without GF_EVENT_CHILD_PING, the last event
propagated to parent xlators would be the first DISCONNECT event
from brick and hence subsequent DISCONNECTS to glusterd are not
propagated as protocol/client prevents same event being propagated
to parent xlators consecutively. propagating GF_EVENT_CHILD_PING for
ping responses from glusterd would change the last_sent_event to
GF_EVENT_CHILD_PING and hence protocol/client cannot prevent
subsequent DISCONNECT events
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1716979
Change-Id: I50276680c52f05ca9e12149a3094923622d6eaef
commit 9e5a7127b68c6785c7e0310b03a608975e718b32
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Jun 26 15:58:33 2019 +0530
posix : add posix_set_ctime() in posix_ftruncate()
Change-Id: I0cb5320fea71306e0283509ae47024f23874b53b
fixes: bz#1723761
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit 3aaf3f9b06499fc101b38c4ba734acb34ca64d14
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Jun 24 15:49:04 2019 +0530
graph/shd: Use glusterfs_graph_deactivate to free the xl rec
We were using glusterfs_graph_fini to free the xl rec from
glusterfs_process_volfp as well as glusterfs_graph_cleanup.
Instead we can use glusterfs_graph_deactivate, which is does
fini as well as other common rec free.
Change-Id: Ie4a5f2771e5254aa5ed9f00c3672a6d2cc8e4bc1
Updates: bz#1716695
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 31c075931b56468a110aac32334c151dcf3b5b8f
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Wed May 29 16:49:01 2019 +0530
geo-rep: Upgrading config file to new version
- configuration handling is enhanced with patch
https://review.gluster.org/#/c/glusterfs/+/18257/
- hence, the old configurations are not applied when
Geo-rep session is created in the old version and upgraded.
This patch solves the issue. It,
- checks if the config file is old.
- parses required values from old config file and stores in new
config file, which ensures that configerations are applied on
upgrade.
- stores old config file as backup.
- handles changes in options introduced in
https://review.gluster.org/#/c/glusterfs/+/18257/
fixes: bz#1707731
Change-Id: Iad8da6c1e1ae8ecf7c84dfdf8ea3ac6966d8a2a0
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit a706974a1272df475b6904774fc7e790c1acaa94
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Wed Jun 19 15:08:58 2019 +0530
posix: modify storage.reserve option to take size and percent
* reverting changes made in
https://review.gluster.org/#/c/glusterfs/+/21686/
* Now storage.reserve can take value in percent or bytes
fixes: bz#1651445
Change-Id: Id4826210ec27991c55b17d1fecd90356bff3e036
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 20b19cd45b0cdea2d151c3af060c46524661a795
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Jun 21 11:28:08 2019 +0200
core: fix memory allocation issues
Two problems have been identified that caused that gluster's memory
usage were twice higher than required.
1. An off by 1 error caused that all objects allocated from the memory
pools were taken from a pool bigger than required. Since each pool
corresponds to a size equal to a power of two, this was wasting half
of the available memory.
2. The header information used for accounting on each memory object was
not taken into consideration when searching for a suitable memory
pool. It was added later when each individual block was allocated.
This made this space "invisible" to memory accounting.
Credits: Thanks to Nithya Balachandran for identifying this problem and
testing this patch.
Fixes: bz#1722802
Change-Id: I90e27ad795fe51ca11c13080f62207451f6c138c
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 02fd490bed9b4aeccf812a74e34d38e907adf154
Author: Michael Adam <obnox@samba.org>
Date: Thu Jun 20 13:09:37 2019 +0200
change get_real_filename implementation to use ENOATTR instead of ENOENT
get_real_filename is implemented as a virtual extended attribute to help
Samba implement the case-insensitive but case preserving SMB protocol
more efficiently. It is implemented as a getxattr call on the parent directory
with the virtual key of "get_real_filename:<entryname>" by looking for a
spelling with different case for the provided file/dir name (<entryname>)
and returning this correct spelling as a result if the entry is found.
Originally (05aaec645a6262d431486eb5ac7cd702646cfcfb), the
implementation used the ENOENT errno to return the authoritative answer
that <entryname> does not exist in any case folding.
Now this implementation is actually a violation or misuse of the defined
API for the getxattr call which returns ENOENT for the case that the dir
that the call is made against does not exist and ENOATTR (or the synonym
ENODATA) for the case that the xattr does not exist.
This was not a problem until the gluster fuse-bridge was changed
to do map ENOENT to ESTALE in 59629f1da9dca670d5dcc6425f7f89b3e96b46bf,
after which we the getxattr call for get_real_filename returned an
ESTALE instead of ENOENT breaking the expectation in Samba.
It is an independent problem that ESTALE should not leak out to user
space but is intended to trigger retries between fuse and gluster.
But nevertheless, the semantics seem to be incorrect here and should
be changed.
This patch changes the implementation of the get_real_filename virtual
xattr to correctly return ENOATTR instead of ENOENT if the file/directory
being looked up is not found.
The Samba glusterfs_fuse vfs module which takes advantage of the
get_real_filename over a fuse mount will receive a corresponding change
to map ENOATTR to ENOENT. Without this change, it will still work
correctly, but the performance optimization for nonexisting files is
lost. On the other hand side, this change removes the distinction
between the old not-implemented case and the implemented case.
So Samba changed to treat ENOATTR like ENOENT will not work correctly
any more against old servers that don't implement get_real_filename.
I.e. existing files will be reported as non-existing
Change-Id: I971b427ab8410636d5d201157d9af70e0d075b67
fixes: bz#1722977
Signed-off-by: Michael Adam <obnox@samba.org>
commit 98effe301783780f48b17eb82ec0b9a5eddd6361
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Jun 6 08:12:34 2019 +0200
locks: enable notify-contention by default
This patch enables the lock contention notification by default.
Change-Id: I10131b026a7cb09fc7c93e1e6c8549988c1d7751
Fixes: bz#1717754
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 80f29976043fdeab9691d070ae24b0fe81ca599c
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jun 20 11:19:47 2019 -0400
statedump: dump the minimum and maximum latency seen by each xlator
Change-Id: Ie9661282694eb9dcfb0d0bc6af512610e02f7347
fixes: bz#1722598
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 2c4a0ff257eab48418124d9109abee1c408618d2
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Jun 25 18:00:06 2019 +0200
glusterd: fix use-after-free of a dict_t
A dict was passed to a function that calls dict_unref() without taking
any additional reference. Given that the same dict is also used after
the function returns, this was causing a use-after-free situation.
To fix the issue, we simply take an additional reference before calling
the function.
Fixes: bz#1723890
Change-Id: I98c6b76b08fe3fa6224edf281a26e9ba1ffe3017
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit a4f8c34e7ce11720787704f747665265025c075e
Author: Kinglong Mee <mijinlong@horiscale.com>
Date: Mon May 13 16:42:01 2019 +0800
gfapi: set right pargfid according to parent's inode
EC updates parent's inode from loc, when pargfid is not the parent's inode's,
a warnning message is print, and an error is returned to up xlator.
[ec-helpers.c:400:ec_loc_gfid_check] 0-openfs1-disperse-0: Mismatching GFID's in loc
Change-Id: Ie8036be91f039083a1e3fe17ec235a222df84b97
fixes: bz#1723280
Signed-off-by: Kinglong Mee <mijinlong@horiscale.com>
commit 6957a8b21078d330e67ba734f6cb497bc1211f47
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Apr 30 15:38:55 2019 -0400
* core: do not assert in inode_unref if the inode table cleanup has started
There is a good chance that, the inode on which unref came has already been
zero refed and added to the purge list. This can happen when inode table is
being destroyed (glfs_fini is something which destroys the inode table).
Consider a directory 'a' which has a file 'b'. Now as part of inode table destruction
zero refing of inodes does not happen from leaf to the root. It happens in the order
inodes are present in the list. So, in this example, the dentry of 'b' would have its
parent set to the inode of 'a'. So if 'a' gets zero refed first (as part of
inode table cleanup) and then 'b' has to zero refed, then dentry_unset is called on
the dentry of 'b' and it further goes on to call inode_unref on b's parent which is
'a'. In this situation, GF_ASSERT would be called as the refcount of 'a' has been
already set to zero.
So, return the inode (in the function inode_unref without doing anything) if the
inode table cleanup has already started and inode's refcount is zero.
Change-Id: I91e0a807d5c9ce0daae5a611c38da379fd11076e
fixes: bz#1722546
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit cf89456e99788e6c41c930f9ed0204104e18679d
Author: kshithijiyer <kshithij.ki@gmail.com>
Date: Mon Jun 24 20:08:48 2019 +0530
Adding white spaces to description of set group.
The description of set group is missing spaces which
leads to the description look like:
volume set <VOLNAME> group <GROUP> - This option can be used for
setting multiple pre-defined volume optionswhere group_name is a
file under /var/lib/glusterd/groups containing onekey, value pair
per line
Instead of:
volume set <VOLNAME> group <GROUP> - This option can be used for
setting multiple pre-defined volume options where group_name is a
file under /var/lib/glusterd/groups containing one key value
pair per line
Fixes: bz#1723455
Change-Id: I4957988c0c1f35f043db3f64089c049193e60e8f
Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
commit 2fae23198ad161d6fc5544db697bea9680f36e04
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jun 25 11:11:10 2019 +0530
glusterd: conditionally clear txn_opinfo in stage op
...otherwise this leads to a crash when volume status is run on a
heterogeneous mode.
Fixes: bz#1723658
Change-Id: I0d39f412b2e5e9d3ef0a3462b90b38bb5364b09d
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 4aba3ec5c27689668f0a08378109ae146ca54631
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Jun 24 10:57:49 2019 +0530
glusterd: Can't run rebalance due to long unix socket
Problem: glusterd populate unix socket file name based
on volname and if volname is lengthy socket
system call's are failed due to breach maximum length
is defined in the kernel.
Solution:Convert unix socket name to hash to resolve the issue
Change-Id: I5072e8184013095587537dbfa4767286307fff65
fixes: bz#1720566
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit fd5de6bc229a6dca1e081b363cd4a88864cd2ddc
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jun 24 18:32:52 2019 +0530
glusterd: ignore user.* options from compatibility check in brick mux
user.* options are just custom and they don't contribute anything in
terms of determining the volume compatibility in brick multiplexing
Fixes: bz#1723402
Change-Id: Ic7e0181ab72993d29cab345cde64ae1340bf4faf
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 38d47e6616748518ce9fce52f578ba07bde000ae
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jun 18 11:00:38 2019 +0530
lcov: add more tests to glfsxmp-coverage
* found a bug with quiesce fallocate() - fixed.
* found a bug with cloudsync part of code in posix - fixed
updates: bz#1693692
Change-Id: I4f315ffebb612de072ae08761b8cd0f47714080a
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit c116097799fbbbac9040d065015ae05d6ebe9b6c
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Jun 13 16:22:44 2019 +0300
glusterd.h: remove unneeded macros or move them to their users.
Some macros were not used, so removed.
Some macros were quite local, so moved to the respective users.
Some macros simplified (removed an allocation here and there)
Change-Id: Ifaf1aff15a78f105b1549ab8053378933b35df43
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 147a58e386bea3587e409f11246f5a4a6967d273
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Jun 24 21:08:34 2019 +0530
test: Fix spurious failures in bug-1040275-brick-uid-reset-on-volume-restart.t
Problem: test case is failing after just starting the volume at the
time of running stat command on mount point and client is
getting error transport endpoint is not conencted
Solution: To avoid the error make sure all brick instance should be
up and mount point should be active
Change-Id: I49553a04d5b13e155ee02f4a1888a07fe3ee2ff5
fixes: bz#1721590
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 8460058ae2722f220790427b4004f50315982607
Author: Dan <dan@d3fy.net>
Date: Tue Jun 18 09:46:15 2019 +0530
compat.h: fix a \#pragma poisoning error
Fixes a failure to compile glusterfs with glibc 2.25 (on Gentoo and other systems)
Making all in src
CC libglusterfs_la-dict.lo
In file included from iatt.h:16:0,
from common-utils.h:44,
from dict.c:20:
/usr/include/sys/sysmacros.h:57:45: error: attempt to use poisoned "system"
directly. If you did not intend to use a system-defined macro\n\
^
make[4]: *** [Makefile:959: libglusterfs_la-dict.lo] Error 1
Fixes: bz#1494654
Change-Id: I09b910b5772f52e853f87d81f3923eed9a90f7a1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 628bc598a15cec372ee7c6f9f2ea40c38752f3b0
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jun 18 22:15:37 2019 +0530
glusterd/shd: Change shd logfile to a unique name
With the shd mux changes, shd was havinga a logfile
with volname of the first started volume.
This was creating a lot confusion, as other volumes data
is also logging to a logfile which has a different vol name.
With this changes the logfile will be changed to a unique name
ie "/var/log/glusterfs/glustershd.log". This was the same
logfile name before the shd mux
Change-Id: I2b94c1f0b2cf3c9493505dddf873687755a46dda
fixes: bz#1721601
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 4324fef9e39d759aac523cbece9df11a22bb0ed9
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Fri Jun 14 07:53:06 2019 +0000
core: replace inet_addr with inet_pton
Fixes warning raised by RPMDiff on the use of inet_addr, which may
impact Ipv6 support
fixes: bz#1721385
Change-Id: Id2d9afa1747efa64bc79d90dd2566bff54deedeb
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 4b48066150c8f80581bca448f4927625fcc6bdfd
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Jun 20 20:43:24 2019 +0530
shd/mux: Fix race between mux_proc unlink and stop
There is a small race window, where we have a shd proc
without having a connection. That is when we stopped the
last shd running on a process. The list was removed
outside of a lock just after stopping the process.
So there is a window where we stopped the process, but
the shd proc list contains the entry.
Change-Id: Id82a82509e5cd72acac24e8b7b87197626525441
fixes: bz#1722541
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit a9b6e5b74d71d8438f47f02a5860f9a816ed66d2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jun 20 17:05:49 2019 +0530
cluster/ec: Prevent double pre-op xattrops
Problem:
Race:
Thread-1 Thread-2
1) Does ec_get_size_version() to perform
pre-op fxattrop as part of write-1
2) Calls ec_set_dirty_flag() in
ec_get_size_version() for write-2.
This sets dirty[] to 1
3) Completes executing
ec_prepare_update_cbk leading to
ctx->dirty[] = '1'
4) Takes LOCK(inode->lock) to check if there are
any flags and sets dirty-flag because
lock->waiting_flag is 0 now. This leads to
fxattrop to increment on-disk dirty[] to '2'
At the end of the writes the file will be marked for heal even when it doesn't need heal.
Fix:
Perform ec_set_dirty_flag() and other checks inside LOCK() to prevent dirty[] to be marked
as '1' in step 2) above
Updates bz#1593224
Change-Id: Icac2ab39c0b1e7e154387800fbededc561612865
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 3566cf72d37912054294e4a5ce74a35c6e32991d
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jun 13 16:23:21 2019 +0530
posix/ctime: Fix ctime upgrade issue
Problem:
On a EC volume, during upgrade from the older version where
ctime feature is not enabled(or not present) to the newer
version where the ctime feature is available (enabled default),
the self heal hangs and doesn't complete.
Cause:
The ctime feature has both client side code (utime) and
server side code (posix). The feature is driven from client.
Only if the client side sets the time in the frame, should
the server side sets the time attributes in xattr. But posix
setattr/fseattr was not doing that. When one of the server
nodes is updated, since ctime is enabled by default, it
starts setting xattr on setattr/fseattr on the updated node/brick.
On a EC volume the first two updated nodes(bricks) are not a
problem because there are 4 other bricks with consistent data.
However once the third brick is updated, the new attribute(mdata xattr)
will cause an inconsistency on metadata on 3 bricks, which
prevents the file to be repaired.
Fix:
Don't create mdata xattr with utimes/utimensat system call.
Only update if already present.
Change-Id: Ieacedecb8a738bb437283ef3e0f042fd49dc4c8c
fixes: bz#1720201
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit f6cbf58ec1dfe19b31a87a626e796415b32b7844
Author: David Spisla <david.spisla@iternity.com>
Date: Wed Jun 19 13:07:56 2019 +0200
WORM-Xlator: Avoid performing fsetxattr if fd is NULL
If worm_create_cbk receives an error (op_ret == -1) fd will be NULL
and therefore performing fsetxattr would lead to a segfault and the
brick process crashes. To avoid this we allow setting fsetxattr only
if op_ret >= 0 . If an error happens we explicitly unwind
Change-Id: Ie7f8a198add93e5cd908eb7029cffc834c3b58a6
fixes: bz#1717757
Signed-off-by: David Spisla <david.spisla@iternity.com>
commit 65c8b525fa64a4040118a8671f45a762660a1420
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Tue Apr 23 11:03:24 2019 +0800
ec-heal: check file's gfid when deleting stale name
A name-less lookup does not contain parent's stat,
It is hard to check the lookuped file is at the right path.
This patch changes to a name lookup, and check file's gfid with
expected gfid. If the gfid is different, mark it estale.
fixes: bz#1702131
Change-Id: I2de20b10d680eed1e2fb1d3830b3b3dec4520dbf
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
commit c5bc49e1d42a095287191b9b36a7ee0e9c164fa6
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jun 20 09:17:36 2019 +0530
fix template file after clang-format
clang-format gets applied for all the files ending with .c or .h
but in this case, new-xlator.c was a template file. hence
change the suffix to reflect the same, also to avoid the
auto-formatting on template file.
updates: bz#1193929
Change-Id: I1c00a28f165f34dbe00fd3b6b070d868a56f9157
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 4c685dd26785029b29082611de567ea618da3612
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Jun 19 15:11:59 2019 +0530
afr/read: Implement latency based read child selection
Network latency is an important factor selecting a read subvolume.
So this patch is adding two new policy.
1) We measure the latency of a child during a GF_DUMP rpc call.
Then use this latency to pick a read subvol having the least
latency.
2) Second one is an hybrid mode where it calculates the effective
latency by multiplying outstanding pending read request and
latency, and choose the least one.
Change-Id: Ia49c8a08ab61f7dcdad8b8950aa4d338e7accf97
fixes: #520
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 909df8dd774d44daf8d1c0ca7d3d55102f595802
Author: Susant Palai <spalai@redhat.com>
Date: Tue Jun 18 16:43:43 2019 +0530
posix: fix crash in posix_cs_set_state
Fixes: bz#1721474
Change-Id: Ic2a53fa3d1e9e23424c6898e0986f80d52c5e3f6
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 07a2a7abae1b1195a2a82d4f983733e10a1d767c
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jun 17 16:49:48 2019 +0530
encryption/crypt: remove from volume file
The feature is not supported and is moved out of the codebase from
glusterfs-5.x release. Doesn't make sense to keep the code to
support it.
For those who want to upgrade from an version supporting it to higher
version, please do a 'gluster volume reset $VOL encryption reset' and
then continue with the upgrade process.
updates: bz#1648169
Change-Id: I8cf822c0d7195940bd37f6af2432a3cac68d44d1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 17c24b20ea5560c8684c5b7787b1c51e6780fe48
Author: Milind Changire <mchangir@redhat.com>
Date: Tue Feb 19 12:49:12 2019 +0530
glusterfind: integrate with gfid2path
Integration with gfid2path helps avoid file-system crawl and saves
precious time. Extended attributes starting with "trusted.gfid2path."
are read and the <PGFID>/<BN> values are extracted and the <PGFID> is
iteratively resolved from the brick backend to arrive at the full path.
Change-Id: I593b02880e3413b77bfceed4a36b00d401f03bc0
fixes: #529
Signed-off-by: Milind Changire <mchangir@redhat.com>
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit f841cab74a899f76351cc08539b482b335046ed7
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Jun 12 15:41:27 2019 +0530
extras/hooks: Install and package newly added post add-brick hook script
https://review.gluster.org/c/glusterfs/+/22834 added a new SELinux hook
script as a post add-brick operation to label new brick paths. But the
change failed to install and package new script. Therefore making
necessary changes to Makefile and spec file to get it installed and
packaged.
Change-Id: I67b8f4982c2783c34a4bc749fb4387c19a038225
fixes: bz#1717953
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit a747af8241147ca7d1f6d171c9ee3b2c363668a3
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Tue Feb 26 15:20:33 2019 +0800
md-cache: only update generation for inode at upcall and NULL stat
1. For parallel writes from nfs-ganesha, two fops with two generations,
but the fops reply maybe returned disordered.
2. The inode md-cache timeout should not increase conf->generation.
With this patch,
1, Fop only gets generation from inode md-cache or conf, does not increase it.
2. The generation is increased at upcall invalidate, estal/enoent error
invalidate, reply with zeroed out stat from write-behind.
Change-Id: I897ecaa143fd18bc024c1948c7d1a6f831fd53da
Updates: bz#1683594
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 058cfbeeba0d0aa404d7ae0cc27849e0acb41ea3
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Jun 18 15:33:29 2019 +0530
cluster/dht: Strip out dht xattrs
Some internal DHT xattrs were not being
removed when calling getxattr in pass-through mode.
This has been fixed.
Change-Id: If7e3dbc7b495db88a566bd560888e3e9c167defa
fixes: bz#1721435
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 0329415d4592961617c693042bba842db89d8a3d
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Jun 18 16:25:35 2019 +0530
geo-rep: Fix permissions for GEOREP_DIR in non-root setup
During mountbroker setup: 'gluster-mountbroker <mountbroker-root> <group>'
commad to set the permission and group for GEOREP_DIR directory
(/var/lib/glusterd/geo-replication) fails due to extra argument, which is
enssential for non-root geo-rep setup.
fixes: bz#1721441
Change-Id: Ia83442733bf0b29f630e8c9e398097316efca092
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 6bb54ba5536dd71daaad978f4633352bd58951f1
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun May 26 11:18:05 2019 +0300
glusterd-volgen.c: remove BD xlator from the graph
The BD xlator was removed some time ago. Remove it from the graph.
We can also remove the caps settings - only the BD xlator
was using it.
Lastly, remove the caps (which only BD was using) and the document
describing the translator.
Change-Id: Id0adcb2952f4832a5dc6301e726874522e07935d
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 5675caadd95f00adceb823922194e79f7e48b742
Author: SheetalPamecha <spamecha@redhat.com>
Date: Mon Jun 17 15:42:20 2019 +0530
core: fedora 30 compiler warnings
warning: ‘%s’ directive argument is null [-Wformat-overflow=]
Change-Id: I69b8d47f0002c58b00d1cc947fac6f1c64e0b295
updates: bz#1193929
Signed-off-by: SheetalPamecha <spamecha@redhat.com>
commit 5323a59a2dfd3137c78b7266d1dd78aefd28f21c
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Jun 17 11:10:42 2019 +0530
tests: subdir-mount.t is failing for brick_mux regrssion
To avoid the failure wait to run hook script S13create-subdir-mounts.sh
after executed add-brick command by test case.
Change-Id: I063b6d0f86a550ed0a0527255e4dfbe8f0a8c02e
fixes: bz#1720993
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit c94271dfe384dfcb65c44378bde112345a560f08
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Fri Jan 19 12:18:13 2018 +0100
core: improve timer accuracy
Also fixed some issues on test ec-1468261.t.
Change-Id: If156f86af986d9eed13cdd1f15c5a7214cd11706
Updates: bz#1193929
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit f0c06dd684a980697466abd4a1c8287bbee65e35
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Jun 13 16:28:04 2019 +0530
glusterd: log error message only when rsp.op_ret is negative
Problem: commit d42221bec9 added a log message based on rsp.op_ret
check. but while running subdir-mount.t, this message is seen even on
successful mounts.
Solution: in __server_getspec(), return value of sys_read() is assigned to
ret, which will be a non-negative number in when sys_read() is success.
This non-zero value is assigned to rsp.op_ret. We should log an error only
when rsp.op_ret is negative.
fixes: bz#1718848
Change-Id: Ieef8ba33c2c7b4a97d4aef17543f58e66fd3b341
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 8c74a26c95e69061c77aecfaec12db8e1b740571
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jun 11 09:52:06 2019 +0530
glusterd: add GF_TRANSPORT_BOTH_TCP_RDMA in glusterd_get_gfproxy_client_volfile
... with out which volume creation fails with "volume create: <xyz>: failed:
Failed to create volume files"
Fixes: bz#1716812
Change-Id: I2f4c2c6d5290f066b54e1c1db19e25db9937bedb
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit e063aa05fed18df840a1133f001b6529b49d70bf
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jun 13 22:43:47 2019 +0530
uss: Fix tar issue with ctime and uss enabled
Problem:
If ctime and uss enabled, tar still complains with 'file
changed as we read it'
Cause:
To clear nfs cache (gluster-nfs), the ctime was incremented
in snap-view client on stat cbk.
Fix:
The ctime should not be incremented manually. Since gluster-nfs
is planning to be deprecated, this code is being removed to
fix the issue.
Change-Id: Iae7f100c20fce880a50b008ba716077350281404
fixes: bz#1720290
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 76fb93b3145ea8a76b5000a622cb631b13b7755b
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jun 4 05:37:57 2019 +0530
afr/fini: Free local_pool data during an afr fini
We should free the mem_pool local_pool during an afr_fini.
Otherwise this will lead to mem leak for shd
Change-Id: I805a34a88077bf7b886c28b403798bf9eeeb1c0b
Updates: bz#1716695
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit fe827d30643d76153033f5fdd57f7f2b48dab4d7
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jun 14 15:00:12 2019 +0530
cli: don't fail if logging initialize fails
in many cases, gluster's cli can run as non-privileged mode
(like in geo-rep non-root setup). Just because logging fails
in cli, lets not fail the overall process. Not much of
debugging help in CLI logs anyways. Most of the debugging
happens once the call reaches server (glusterd).
Fixes: bz#1535511
Change-Id: I9f07c61b8c3acc95ec08230ff539a35dfd0ff9dc
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 279b618c7014ac473caa5cd08f51253946867c1e
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Fri May 31 17:21:22 2019 +0530
geo-rep/gsyncd: name is not freed in one of the cases
CID: 1400730
updates: bz#789278
Change-Id: I0f6924050a31d3d2cc0b555f859920e349728e0a
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 1c8fe5626684ce681f564bf0a0b57be7a554a515
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jun 14 12:43:45 2019 +0200
build: always build glusterfs-cli to allow monitoring/managing from clients
Fixes: bz#1720615
Change-Id: I5071f3255ff615113b36b08cd5326be6e37d907d
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 16795d9b1181506e4d5274821a06b35f024311ea
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jun 14 17:34:34 2019 +0530
tests: Add missing NFS test tag to the testfile
$SRC/glusterfs/bugs/nfs/showmount-many-clients.t
Change-Id: I48758cc66fcb55f48c4a8a0a738b06867f6814a1
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Updates: bz#1193929
commit dc01ad51859ba9e2342a2727c9dcc03f1b54ffe4
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jun 14 12:53:15 2019 +0530
clang-scan: resolve warning
dht-common.c: because there was a 'goto err' before assigning
the 'local' variable, there is possibility of NULL
dereference. As the check which was done wouldn't
ever be true, removed the check.
glusterd-geo-rep.c: a possible path where 'slave_host' could be
NULL when it gets passed to strcmp() is found.
strcmp() expects a valid string. Add a NULL check.
Updates: bz#1622665
Change-Id: I64c280bc1beac9a2b109e8fa88f2a5ce8b823c3a
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 5a1d28c1b56f897dbd9a21aaa6eb62e142a0e18d
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jun 14 22:38:10 2019 +0530
glfs: add syscall.h after header cleanup
in one of the recent patches, we cleaned-up the unneccesary header
file includes. In the order of merging the patches, there cropped
up an compile error.
updates: bz#1193929
Change-Id: I2ad52aa918f9c698d5273bb293838de6dd50ac31
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 1ccf7b423da3698ffe490a76f518b0ce463379f0
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Jun 9 13:31:31 2019 +0300
multiple files: another attempt to remove includes
There are many include statements that are not needed.
A previous more ambitious attempt failed because of *BSD plafrom
(see https://review.gluster.org/#/c/glusterfs/+/21929/ )
Now trying a more conservative reduction.
It does not solve all circular deps that we have, but it
does reduce some of them. There is just too much to handle
reasonably (dht-common.h includes dht-lock.h which includes
dht-common.h ...), but it does reduce the overall number of lines
of include we need to look at in the future to understand and fix
the mess later one.
Change-Id: I550cd001bdefb8be0fe67632f783c0ef6bee3f9f
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit e542d08bd07c5a36e38f7818fab08eeb7afcbaee
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jun 14 16:11:37 2019 +0530
eventsapi: Fix Exception class for Python3
Python2 exception provides message attribute for custom exceptions.
But it is not available in Python3. Add init method for custom exception
to handle the same.
Original crash(IndexError reported in the bug) was fixed with
https://review.gluster.org/#/c/glusterfs/+/22294/ But that patch only
works in Python2 and fails in Python3 since Exception in Python 3
doesn't have "message" attribute.
Fixes: bz#1573226
Change-Id: If9117048f9ff0615f5da1880075ec12c0ff4855e
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 48bda317b8ec8acbbcd4c5a6eefc8b44ffe81991
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Mar 14 10:04:28 2019 +0530
gfapi: provide an api for setting statedump path
Currently for an application using glfsapi to use glusterfs, when a
statedump is taken, it uses /var/run/gluster dir to dump info.
There can be concerns as this directory may be owned by some other
user, and hence it may fail taking statedump. Such applications
should have an option to use different path.
This patch provides an API to do so.
Updates: bz#1689097
Change-Id: I8918e002bc823d83614c972b6c738baa04681b23
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 8c66ebe35a0c423773a229a1ec7ab509c8e9cb55
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Mon Jun 3 15:59:38 2019 +0800
gnfs: support inode dump
So, we will get more debug info.
fixes: #679
Change-Id: I3588e204ad25c20b69271c1a4ee17d0d158bd794
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit c643942635c5f9cf6959e08a8509ef33cb1e0bf3
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Jun 7 19:33:07 2019 +0530
upcall: Avoid sending notifications for invalid inodes
For nameless LOOKUPs, server creates a new inode which shall
remain invalid until the fop is successfully processed post
which it is linked to the inode table.
But incase if there is an already linked inode for that entry,
it discards that newly created inode which results in upcall
notification. This may result in client being bombarded with
unnecessary upcalls affecting performance if the data set is huge.
This issue can be avoided by looking up and storing the upcall
context in the original linked inode (if exists), thus saving up on
those extra callbacks.
Change-Id: I044a1737819bb40d1a049d2f53c0566e746d2a17
fixes: bz#1718338
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 8cab5e6288bd4888b3083c443af9414aae66bc3d
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Jun 7 17:20:15 2019 +0530
gfapi: fix incorrect initialization of upcall syncop arguments
While sending upcall notifications via synctasks, the argument used to
carry relevant data for these tasks is not initialized properly. This patch
is to fix the same.
Change-Id: I9fa8f841e71d3c37d3819fbd430382928c07176c
fixes: bz#1718316
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 0e5d8a1e76f7af9c88d88eccb066a0daa6b4b1e2
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Mon Jun 3 18:05:24 2019 +0530
cli: Remove-brick warning seems unnecessary
As force-migration option is disabled by default,
the warning seems unnessary.
Rephrased the warning to make best sense out of it.
fixes: bz#1712668
Change-Id: Ia18c3c5e7b3fec808fce2194ca0504a837708822
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit f00ac55679d1248a7fe248001ec071379029a8da
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Jun 6 18:33:19 2019 +0530
extras/hooks: Add SELinux label on new bricks during add-brick
Change-Id: Ifd8ae5eeb91b968cc1a9a9b5d15844c5233d56db
fixes: bz#1717953
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 963c900c1c412c74dbdbffb7591efadd5fe3f5ae
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon May 13 14:32:53 2019 +0530
geo-rep : fix mountbroker setup
Problem:
Unable to setup mountbroker root directory while creating geo-replication
session for non-root user.
Casue:
With patch[1] which defines the max-port for glusterd one extra sapce
got added in field of 'option max-port'.
[1]. https://review.gluster.org/#/c/glusterfs/+/21872/
In geo-rep spliting of key-value pair form vol file was done on the
basis of space so this additional space caused "ValueError: too many values
to unpack".
Solution:
Use split so that it can treat consecutive whitespace as a single separator.
Fixes: bz#1709248
Change-Id: Ia22070a43f95d66d84cb35487f23f9ee58b68c73
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit c5f9106de1beb4681ad6a336d87ac8f79b2a4168
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri May 31 18:40:30 2019 +0200
libglusterfs: cleanup iovec functions
This patch cleans some iovec code and creates two additional helper
functions to simplify management of iovec structures.
iov_range_copy(struct iovec *dst, uint32_t dst_count, uint32_t dst_offset,
struct iovec *src, uint32_t src_count, uint32_t src_offset,
uint32_t size);
This function copies up to 'size' bytes from 'src' at offset
'src_offset' to 'dst' at 'dst_offset'. It returns the number of
bytes copied.
iov_skip(struct iovec *iovec, uint32_t count, uint32_t size);
This function removes the initial 'size' bytes from 'iovec' and
returns the updated number of iovec vectors remaining.
The signature of iov_subset() has also been modified to make it safer
and easier to use. The new signature is:
iov_subset(struct iovec *src, int src_count, uint32_t start, uint32_t size,
struct iovec **dst, int32_t dst_count);
This function creates a new iovec array containing the subset of the
'src' vector starting at 'start' with size 'size'. The resulting
array is allocated if '*dst' is NULL, or copied to '*dst' if it fits
(based on 'dst_count'). It returns the number of iovec vectors used.
A new set of functions to iterate through an iovec array have been
created. They can be used to simplify the implementation of other
iovec-based helper functions.
Change-Id: Ia5fe57e388e23392a8d6cdab17670e337cadd587
Updates: bz#1193929
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit fcf7d94bc0e196691bfa9df6824c6fe0c346f3d1
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jun 10 09:39:38 2019 +0530
tests: keep glfsxmp in tests directory
this is critical so all the tests will be contained in the same
directory, and one can just 'cp -a tests/ <any-location>/' and
run glusterfs tests.
only 'glfsxmp.c' was an exception as it was just copying the
file from api example directory. Now moved it to tests.
updates: bz#1193929
Change-Id: I00359d64be580bffc5b3c3a090968d86c2c6952a
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit c1783777be16440fc25bc87c6fd995327df7f1f6
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Jun 10 23:19:44 2019 +0530
tests: Fix split-brain-favorite-child-policy.t failure
Problem:
The test case is failing to heal the volume within $HEAL_TIMEOUT @195.
This is happening because as part of split-brain resolution the file
gets expunged from the sink and the new entry mark for that file will
be done on the source bricks as part of impunging. Since the source
bricks shd-threads failed to get the heal-domain lock, they will wait
for the heal-timeout of 10 minutes, which is greater than $HEAL_TIMEOUT.
Fix:
Set the cluster.heal-timeout to 5 seconds to trigger the heal so that
one of the source brick heals the file within the $HEAL_TIMEOUT.
Change-Id: Ie73c578cc5361c0d617a48ccc86026734d20ba8c
fixes: bz#1718998
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit cf7be8aabbfa4489950eaf40ba536c5f9ee8a80b
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Jun 6 10:59:42 2019 +0530
Cluster/afr: Don't treat all bricks having metadata pending as split-brain
Problem:
We currently don't have a roll-back/undoing of post-ops if quorum is not met.
Though the FOP is still unwound with failure, the xattrs remain on the disk.
Due to these partial post-ops and partial heals (healing only when 2 bricks
are up), we can end up in metadata split-brain purely from the afr xattrs
point of view i.e each brick is blamed by atleast one of the others for
metadata. These scenarios are hit when there is frequent connect/disconnect
of the client/shd to the bricks.
Fix:
Pick a source based on the xattr values. If 2 bricks blame one, the blamed
one must be treated as sink. If there is no majority, all are sources. Once
we pick a source, self-heal will then do the heal instead of erroring out
due to split-brain.
This patch also adds restriction of all the bricks to be up to perform
metadata heal to avoid any metadata loss.
Removed the test case tests/bugs/replicate/bug-1468279-source-not-blaming-sinks.t
as it was doing metadata heal even when only 2 of 3 bricks were up.
Change-Id: I07a9d62f84ceda329dcab1f02a33aeed258dcb09
fixes: bz#1717819
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 2453647d7283a81315dd5218cd7579d73bd4a155
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Jun 10 15:16:48 2019 +0530
tests: added cleanup for lock files
Problem: useradd fails with: Cannot allocate memory
useradd: cannot lock /etc/passwd; try again later.
Solution:
Lock files should get automatically removed once "usradd" or "groupadd"
command finishes. But sometimes we encounter situations (bugs) where
some of these files may not get properly unlocked after the execution of
the command. In that case, when we execute useradd next time, it may show
the error “cannot lock /etc/password” or “unable to lock group file”.
So, to avoid any such errors, check for any lock files under /etc and
remove those.
updates: bz#1193929
Change-Id: If6456a271c2bc0717f768d7101a40ce44a9af3d7
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit ea957f8e018267d0a3e569e4cfc66de309e4158f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Apr 5 12:29:23 2019 +0530
features/shard: Fix extra unref when inode object is lru'd out and added back
Long tale of double unref! But do read...
In cases where a shard base inode is evicted from lru list while still
being part of fsync list but added back soon before its unlink, there
could be an extra inode_unref() leading to premature inode destruction
leading to crash.
One such specific case is the following -
Consider features.shard-deletion-rate = features.shard-lru-limit = 2.
This is an oversimplified example but explains the problem clearly.
First, a file is FALLOCATE'd to a size so that number of shards under
/.shard = 3 > lru-limit.
Shards 1, 2 and 3 need to be resolved. 1 and 2 are resolved first.
Resultant lru list:
1 -----> 2
refs on base inode - (1) + (1) = 2
3 needs to be resolved. So 1 is lru'd out. Resultant lru list -
2 -----> 3
refs on base inode - (1) + (1) = 2
Note that 1 is inode_unlink()d but not destroyed because there are
non-zero refs on it since it is still participating in this ongoing
FALLOCATE operation.
FALLOCATE is sent on all participant shards. In the cbk, all of them are
added to fync_list.
Resulting fsync list -
1 -----> 2 -----> 3 (order doesn't matter)
refs on base inode - (1) + (1) + (1) = 3
Total refs = 3 + 2 = 5
Now an attempt is made to unlink this file. Background deletion is triggered.
The first $shard-deletion-rate shards need to be unlinked in the first batch.
So shards 1 and 2 need to be resolved. inode_resolve fails on 1 but succeeds
on 2 and so it's moved to tail of list.
lru list now -
3 -----> 2
No change in refs.
shard 1 is looked up. In lookup_cbk, it's linked and added back to lru list
at the cost of evicting shard 3.
lru list now -
2 -----> 1
refs on base inode: (1) + (1) = 2
fsync list now -
1 -----> 2 (again order doesn't matter)
refs on base inode - (1) + (1) = 2
Total refs = 2 + 2 = 4
After eviction, it is found 3 needs fsync. So fsync is wound, yet to be ack'd.
So it is still inode_link()d.
Now deletion of shards 1 and 2 completes. lru list is empty. Base inode unref'd and
destroyed.
In the next batched deletion, 3 needs to be deleted. It is inode_resolve()able.
It is added back to lru list but base inode passed to __shard_update_shards_inode_list()
is NULL since the inode is destroyed. But its ctx->inode still contains base inode ptr
from first addition to lru list for no additional ref on it.
lru list now -
3
refs on base inode - (0)
Total refs on base inode = 0
Unlink is sent on 3. It completes. Now since the ctx contains ptr to base_inode and the
shard is part of lru list, base shard is unref'd leading to a crash.
FIX:
When shard is readded back to lru list, copy the base inode pointer as is into its inode ctx,
even if it is NULL. This is needed to prevent double unrefs at the time of deleting it.
Change-Id: I99a44039da2e10a1aad183e84f644d63ca552462
Updates: bz#1696136
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 90765bae2d64a0c4689acb94441ab7af05132016
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Sun Jun 2 01:36:33 2019 +0530
ec/fini: Fix race between xlator cleanup and on going async fop
Problem:
While we process a cleanup, there is a chance for a race between
async operations, for example ec_launch_replace_heal. So this can
lead to invalid mem access.
Solution:
Just like we track on going heal fops, we can also track fops like
ec_launch_replace_heal, so that we can decide when to send a
PARENT_DOWN request.
Change-Id: I055391c5c6c34d58aef7336847f3b570cb831298
fixes: bz#1703948
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 36cef7f81d0242ae0a7a62f1e483d31aa348ee94
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jun 4 11:13:50 2019 +0530
xlator/log: Add more logging in xlator_is_cleanup_starting
This patch will add two extra logs for invalid argument
Change-Id: I3950b4f4b9d88b1f1e788ef93d8f09d4bd8d4d8b
updates: bz#1703948
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit fc8e95f332f39560a20f6e2d4b1b7a6cf6e8474b
Author: kshithijiyer <kshithij.ki@gmail.com>
Date: Wed Jun 5 19:40:29 2019 +0530
Fixing formatting errors in markdown files
There are a lot of fromatting error is markdown
files peresent under /doc directiory of the project.
Fixing formatting errors and sending a patch.
Fixes: bz#1718273
Change-Id: I08f938088bbaaafddf634f73616ea0dbfe7aedf3
Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
commit c39c132a39c332568cd319f92dcb0d070ec15251
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue May 14 10:56:15 2019 -0400
uss: Ensure that snapshot is deleted before creating a new snapshot
* Also some logging enhancements in snapview-server
Change-Id: I6a7646771cedf4bd1c62806eea69d720bbaf0c83
fixes: bz#1715921
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit f868c22856c495c1ecf54bf6df8135531cc5cda6
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Jun 4 11:17:21 2019 +0530
cluster/replicate: Modify command in unit file to assign port correctly
Problem:
In unit file of TA process we have been using ta-vol as
volume id and also ta-vol-server.transport.socket.listen-port=24007
In volume file for TA process we only consider volname
as "ta" and not as "ta-vol". That's why it was not able to assign
this port number to ta process as in volume file it will try to
find server xlator as ta-vol
volume ta-server <<<<<<<<< not ta-vol-server
46 type protocol/server
47 option transport.listen-backlog 10
48 option transport.socket.keepalive-count 9
49 option transport.socket.keepalive-interval 2
50 option transport.socket.keepalive-time 20
51 option transport.tcp-user-timeout 0
52 option transport.socket.keepalive 1
53 option auth.addr./mnt/thin-arbiter.allow *
54 option auth-path /mnt/thin-arbiter
55 option transport.address-family inet
56 option transport-type tcp
57 subvolumes ta-io-stats
58 end-volume
Solution:
Provide "ta" as vol id for the command which Unit file
is going to execute.
Also, made changes in setup-thin-arbiter.sh to correctly
identify the directory of Unit file irrespective of the location from
where we are executing this script.
Change-Id: Ia7bbccdc0304e7dfaaa732bebb726fba731d1d33
fixes: bz#1716766
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit caf13daf50c9b5f15e65601e87159d5ad660287c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jun 6 13:19:29 2019 +0530
glusterd: store fips-mode-rchecksum option in the info file
commit 146e4b45d0ce906ae50fd6941a1efafd133897ea enabled
storage.fips-mode-rchecksum option for all new volumes with op-version
>=GD_OP_VERSION_7_0 but `gluster vol get $volname
storage.fips-mode-rchecksum` was displaying it as 'off'. This patch fixes it.
fixes: bz#1717782
Change-Id: Ie09f89838893c5776a3f60569dfe8d409d1494dd
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 231819e97165944f97662fea84fe8def4375ce9f
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Jun 6 15:46:15 2019 +0530
glusterd: Fix typos
Change-Id: I8cf0a153f84ef2d162e6dd03261441d211c07d40
updates: bz#1193929
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 1b8e5a74bbb11ce1571f02c1a256b546474b082e
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jun 6 12:54:04 2019 +0530
tests/utils: Fix py2/py3 util python scripts
Following files are fixed.
tests/bugs/distribute/overlap.py
tests/utils/changelogparser.py
tests/utils/create-files.py
tests/utils/gfid-access.py
tests/utils/libcxattr.py
Change-Id: I3db857cc19e19163d368d913eaec1269fbc37140
updates: bz#1193929
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit a0e0890e39595cdd00de3121ce24323e43d11149
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jun 7 13:55:12 2019 +0530
tests/quick-read-upcall: mark it bad
Frequent intermittent failures observed.
```
08:59:24 ok 11 [ 10/ 3] < 36> 'write_to /mnt/glusterfs/0/test.txt test-message1'
08:59:24 ok 12 [ 10/ 6] < 37> 'test-message1 cat /mnt/glusterfs/0/test.txt'
08:59:24 ok 13 [ 10/ 4] < 38> 'test-message0 cat /mnt/glusterfs/1/test.txt'
08:59:24 not ok 14 [ 3715/ 6] < 45> 'test-message1 cat /mnt/glusterfs/1/test.txt' -> 'Got "test-message0" instead of "test-message1"'
08:59:24 ok 15 [ 10/ 162] < 47> 'gluster --mode=script --wignore volume set patchy features.cache-invalidation on'
08:59:24 ok 16 [ 10/ 148] < 48> 'gluster --mode=script --wignore volume set patchy performance.qr-cache-timeout 15'
```
updates: bz#1718191
Change-Id: Ieb9e5a9a428995ff178f77bc4a5155b8298d3fa0
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 416eda0e89ee06ca23573f801f5619ec4a7e357b
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jun 7 13:58:48 2019 +0530
tests/volume-scale-shd-mux: mark as bad test
The test is giving frequent failures in regression.
Error seen is normally like below:
`09:09:24 not ok 58 [ 14/ 80343] < 104> '^3$ number_healer_threads_shd patchy_distribute1 __afr_shd_healer_wait' -> 'Got "1" instead of "^3$"'`
updates: bz#1708929
Change-Id: I240bdcfb76b1f953d75937a53c5dfabba134f282
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 84ec60a986fa08be63419a17ae5b1e8d6fa5e487
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu May 9 14:07:48 2019 +0530
tests/shd: Add test coverage for shd mux
This patch add more test cases for shd mux test cases
The test case includes
1) Createing multiple volumes to check the attach and detach
of self heal daemon requests.
2) Make sure the healing happens in all sceanarios
3) After a volume detach make sure the threads of the detached
volume is all cleaned.
4) Repeat all the above tests for ec volume
5) Node Reboot case
6) glusterd restart cases
7) Add-brick/remove brick
8) Convert a distributed volume to disperse volume
9) Convert a replicated volume to distributed volume
Change-Id: I7c317ef9d23a45ffd831157e4890d7c83a8fce7b
fixes: bz#1708929
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 9960a1f09c2e78659398fdef2bbe9f4def9d219b
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jun 4 15:10:39 2019 +0530
tests/geo-rep: Add geo-rep cli testcases
Change-Id: Icf93b90bcac022a355d4718220698987dbc91ecf
Signed-off-by: Kotresh HR <khiremat@redhat.com>
updates: bz#1693692
commit f7de3d22d52f529821fef44400bce6e048813998
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Jun 4 14:51:44 2019 +0530
cluster/dht: Fix directory perms during selfheal
Fixed a bug in the revalidate code path that wiped out
directory permissions if no mds subvol was found.
Change-Id: I8b4239ffee7001493c59d4032a2d3062586ea115
fixes: bz#1716830
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit c1a1d125e9e0b0e20a62aa9fee7e54aaa1bb69d6
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon May 20 11:11:39 2019 +0530
across: clang-scan: fix NULL dereferencing warnings
All these checks are done after analyzing clang-scan report produced
by the CI job @ https://build.gluster.org/job/clang-scan
updates: bz#1622665
Change-Id: I590305af4ceb779be952974b2a36066ffc4865ca
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 0df9e2870ca55934f9cbddbbe7be6e77528a42e1
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Jun 1 22:43:03 2019 +0530
lcov: run more fops on translators
Translators covered:
* playground/template
* debug/delay-gen
* debug/error-gen
* features/namespace
* features/quiesce
* meta
updates: bz#1693692
Change-Id: Ic8fde8efcb309ea492d8e819241f786f7ff467a1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 81cfa0035e7f2925d64ccd8811ce39ba65ee8eb4
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed May 8 13:00:51 2019 +0530
features/shard: Fix block-count accounting upon truncate to lower size
The way delta_blocks is computed in shard is incorrect, when a file
is truncated to a lower size. The accounting only considers change
in size of the last of the truncated shards.
FIX:
Get the block-count of each shard just before an unlink at posix in
xdata. Their summation plus the change in size of last shard
(from an actual truncate) is used to compute delta_blocks which is
used in the xattrop for size update.
Change-Id: I9128a192e9bf8c3c3a959e96b7400879d03d7c53
fixes: bz#1705884
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 42ebca6177c119c6904d3bb583b7704eee23d2c3
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jun 3 13:25:16 2019 +0530
tests/geo-rep: Add geo-rep glusterd test cases
1. Add geo-rep fanout test case
2. Add glusterd geo-rep negative test cases
3. Add glusterd geo-rep config test cases
Change-Id: I856c087eb3216d8f0ffd1f266deac88e9a4effec
Signed-off-by: Kotresh HR <khiremat@redhat.com>
updates: bz#1693692
commit c46967e19e6f6c14b296b1a73be669117d35825b
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jun 3 14:15:51 2019 +0530
tests/geo-rep: Remove a rename test case on EC volume
Rename with existing name testcase is occasionaly
failing on EC volume. Hence commenting the same
until it's analysed
Change-Id: Icb2ad189b9e4d12101e8f5abcb8a033181360386
Signed-off-by: Kotresh HR <khiremat@redhat.com>
updates: bz#1193929
commit 78090b7d7c6a050949061af69ac4d9588058a602
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Jun 3 09:49:30 2019 +0530
glusterd: coverity fix
1401716: Resource leak
1401714: Dereference before null check
updates: bz#789278
Change-Id: I8fb0b143a1d4b37ee6be7d880d9b5b84ba00bf36
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 63f4cc9fa1ce292575e2a8099058783c881e6a3d
Author: hari gowtham <hgowtham@redhat.com>
Date: Wed May 29 12:26:01 2019 +0530
glusterd/tier: gluster upgrade broken because of tier
Problem: While tier code was removed, the is_tier_enabled
related to tier wasn't handled for upgrade.
As this option was missing in the info file, the checksum
mismatch issue happens during upgrade.
This results in the peer rejections happening.
Fix: use the op_version check and note down the is_tier_enabled
always. This way it will be dummy key, but the future upgrades
will work fine.
NOTE: Just having the key from 3.10 to 7 will cause issues when
upgraded from 5 to 8 or any such upgrade which skips the version
where we handle it.
Change-Id: I9951e2b74f16e58e884e746c34dcf53e559c7143
fixes: bz#1714973
Signed-off-by: hari gowtham <hgowtham@redhat.com>
commit 1b8cabe2f5c4986883b62eac30b63f05e22168d9
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu May 30 15:25:01 2019 +0530
lcov: improve line coverage
upcall: remove extra variable assignment and use just one
initialization.
open-behind: reduce the overall number of lines, in functions
not frequently called
selinux: reduce some lines in init failure cases
updates: bz#1693692
Change-Id: I7c1de94f2ec76a5bfe1f48a9632879b18e5fbb95
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 57c32f6e9b406279e6e874049944b337d77ed5af
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri May 17 11:04:45 2019 +0530
across: coverity fixes
* locks/posix.c: key was not freed in one of the cases.
* locks/common.c: lock was being free'd out of context.
* nfs/exports: handle case of missing free.
* protocol/client: handle case of entry not freed.
* storage/posix: handle possible case of double free
CID: 1398628, 1400731, 1400732, 1400756, 1124796, 1325526
updates: bz#789278
Change-Id: Ieeaca890288bc4686355f6565f853dc8911344e8
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 288f3e18bd806b8239b4af50bf7e5b750a353b81
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Mon Nov 19 22:15:25 2018 +0530
posix: add storage.reserve-size option
storage.reserve-size option will take size as input
instead of percentage. If set, priority will be given to
storage.reserve-size over storage.reserve. Default value
of this option is 0.
fixes: bz#1651445
Change-Id: I7a7342c68e436e8bf65bd39c567512ee04abbcea
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 679c018031dca730686af906df34256c5c78a6a6
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sat Jun 1 18:36:55 2019 +0530
glusterd: remove trivial conditions
updates: bz#1193929
Change-Id: Ieb5e35d454498bc389972f9f15fe46b640f1b97d
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 95097cae20a42cbfb99aa34af80e4403d48dfe01
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri May 17 19:26:48 2019 +0530
glusterd: Optimize code to copy dictionary in handshake code path
Problem: While high no. of volumes are configured around 2000
glusterd has bottleneck during handshake at the time
of copying dictionary
Solution: To avoid the bottleneck serialize a dictionary instead
of copying key-value pair one by one
Change-Id: I9fb332f432e4f915bc3af8dcab38bed26bda2b9a
fixes: bz#1711297
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit af0b430203678114ee756f89729a3f03edff6917
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri May 31 16:52:04 2019 +0530
tests/geo-rep: Add tests to cover glusterd geo-rep
Change-Id: Ide59a3fde11b23f654b1ec03d72b4ec53b36a03b
Signed-off-by: Kotresh HR <khiremat@redhat.com>
updates: bz#1693692
commit 38ad6d92d4c4d5b507c814cdcd14270e25ff24dd
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue May 14 23:12:44 2019 +0530
glusterd/shd: Optimize the glustershd manager to send reconfigure
Traditionally all svc manager will execute process stop and then
followed by start each time when they called. But that is not
required by shd, because the attach request implemented in the shd
multiplex has the intelligence to check whether a detach is required
prior to attaching the graph. So there is no need to send an explicit
detach request if we are sure that the next call is an attach request
Change-Id: I9157c8dcaffdac038f73286bcf5646a3f1d3d8ec
fixes: bz#1710054
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 79c63544411992063c90cd91015ebd0c18215cba
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Sat May 11 22:40:22 2019 +0530
glusterfsd/cleanup: Protect graph object under a lock
While processing a cleanup_and_exit function, we are
accessing a graph object. But this has not been protected
under a lock. Because a parallel cleanup of a graph is quite
possible which might lead to an invalid memory access
Change-Id: Id05ca70d5b57e172b0401d07b6a1f5386c044e79
fixes: bz#1708926
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit b074de447a4adb53ed3266f8ee59b6325298d1d0
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Fri May 17 12:24:50 2019 +0530
tests/geo-rep: Add EC volume test case
Added geo-rep regression tests with EC volume.
fixes: bz#1650095
Change-Id: Ifb6e68e0a6103a98fced7f84d3088b8edf33d52f
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 1732a4a2896a202ca6436eecb1c02820782ead3f
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri May 31 08:53:58 2019 +0530
lcov: more coverage to shard, old-protocol, sdfs
updates: bz#1693692
Change-Id: If4c30572d4501d169bb4b0871c677d974515867c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 6e1029f8c9b3706fafa58fca6bfea56a822e2dea
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu May 30 23:48:05 2019 +0530
glusterd/svc: Stop stale process using the glusterd_proc_stop
While restarting a glusterd process, when we have a stale pid
we were doing a simple kill. Instead we can use glusterd_proc_stop
Because it has more logging plus force kill in case if there is
any problem with kill signal handling.
Change-Id: I4a2dadc210a7a65762dd714e809899510622b7ec
updates: bz#1710054
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 2f068c32f7fa525a6c3ae162e05417c8ad352402
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed May 22 13:32:23 2019 +0530
glusterd/svc: glusterd_svcs_stop should call individual wrapper function
glusterd_svcs_stop should call individual wrapper function to stop a
daemon rather than calling glusterd_svc_stop. For example for shd,
it should call glusterd_shdsvc_stop instead of calling basic API
function to stop. Because the individual functions for each daemon
could be doing some specific operation in their wrapper function.
Change-Id: Ie6d40590251ad470ef3901d1141ab7b22c3498f5
fixes: bz#1712741
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit c8522abbea167f3ea2ebae94a661981b2c102174
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed May 15 07:35:45 2019 +0530
glusterd: add an op-version check
Problem: "gluster v status" is hung in heterogenous cluster
when issued from a non-upgraded node.
Cause: commit 34e010d64 fixes the txn-opinfo mem leak
in op-sm framework by not setting the txn-opinfo if some
conditions are true. When vol status is issued from a
non-upgraded node, command is hanging in its upgraded peer
as the upgraded node setting the txn-opinfo based on new
conditions where as non-upgraded nodes are following diff
conditions.
Fix: Add an op-version check, so that all the nodes follow
same set of conditions to set txn-opinfo.
fixes: bz#1710159
Change-Id: Ie1f353212c5931ddd1b728d2e6949dfe6225c4ab
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 95a04aa500f6f8d78945d7da78d640caabb71515
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 27 19:00:20 2019 +0530
scripts: Find hung frames given a directory with statedumps
Given a directory with statedumps captured at different times if
there are any stacks that appear in multiple statedumps, it prints
them.
Sample output:
glusterdump.25425.dump repeats=5 stack=0x7f53642cb968 pid=0 unique=0 lk-owner=
glusterdump.25427.dump repeats=5 stack=0x7f85002cb968 pid=0 unique=0 lk-owner=
glusterdump.25428.dump repeats=5 stack=0x7f962c2cb968 pid=0 unique=0 lk-owner=
glusterdump.25428.dump repeats=2 stack=0x7f962c329f18 pid=60830 unique=0 lk-owner=88f50620967f0000
glusterdump.25429.dump repeats=5 stack=0x7f20782cb968 pid=0 unique=0 lk-owner=
glusterdump.25472.dump repeats=5 stack=0x7f27ac2cb968 pid=0 unique=0 lk-owner=
glusterdump.25473.dump repeats=5 stack=0x7f4fbc2cb9d8 pid=0 unique=0 lk-owner=
NOTE: stacks with lk-owner=""/lk-owner=0000000000000000/unique=0 may not be hung frames and need further inspection
fixes bz#1714415
Change-Id: Ib64a3fca63f49df2fafedcd4baa57e9b25411b08
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 4b4581bcf7bcc215ade0c35709b67844a08b5e29
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 27 11:43:26 2019 +0530
stack: Make sure to have unique call-stacks in all cases
At the moment new stack doesn't populate frame->root->unique in all cases. This
makes it difficult to debug hung frames by examining successive state dumps.
Fuse and server xlators populate it whenever they can, but other xlators won't
be able to assign 'unique' when they need to create a new frame/stack because
they don't know what 'unique' fuse/server xlators already used. What we need is
for unique to be correct. If a stack with same unique is present in successive
statedumps, that means the same operation is still in progress. This makes
'finding hung frames' part of debugging hung frames easier.
fixes bz#1714098
Change-Id: I3e9a8f6b4111e260106c48a2ac3a41ef29361b9e
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 6bbe1b659aa9b87091eb9214b36187c6e1713fe2
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue May 28 11:52:46 2019 +0530
glusterd: coverity fix
1401590: Deadcode
updates: bz#789278
Change-Id: I3aa1d3aa9769e6990f74b6a53e288e788173c5e0
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 07f3f62a60a5fec0bee3bb6ad8dccbf7ab4a1c8d
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed May 29 17:54:45 2019 +0530
marker: remove some unused functions
After basic analysis, found that these methods were not being
used at all.
updates: bz#1693692
Change-Id: If9cfa1ab189e6e7b56230c4e1d8e11f9694a9a65
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 3ffeba95f8797300345a77220545f332ba47bd00
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Apr 12 08:16:56 2019 +0530
tests: add tests for different signal handling
Also some cleanup:
* old-protocol.t was actually added to make sure we have line-coverage
* first-test.t should have been removed as per the comment. It doesn't do anything.
* add statvfs to rpc-coverage so we can cover statvfs in few xlators.
updates: bz#1693692
Change-Id: Ie8651ce007de484c4abced16b4de765aa5e517be
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 83322dde6019598183c9773ec077a067bd483d12
Author: Amgad Saleh <amgad.saleh@nokia.com>
Date: Thu May 23 20:27:03 2019 -0500
If bind-address is IPv6 return it successfully
Change-Id: Ibd37b6ea82b781a1a266b95f7596874134f30079
fixes: bz#1713730
Signed-off-by: Amgad Saleh <amgad.saleh@nokia.com>
commit dd978ade048e7ab5ee414dfe245d961385daf760
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri May 17 18:10:47 2019 +0530
glusterd: bulkvoldict thread is not handling all volumes
Problem: In commit ac70f66c5805e10b3a1072bd467918730c0aeeb4 I
missed one condition to populate volume dictionary in
multiple threads while brick_multiplex is enabled.Due
to that glusterd is not sending volume dictionary for
all volumes to peer.
Solution: Update the condition in code as well as update test case
also to avoid the issue
Change-Id: I06522dbdfee4f7e995d9cc7b7098fdf35340dc52
fixes: bz#1711250
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit e637a0649ee88394fe9955da7ecd803176e17d10
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed May 22 12:23:07 2019 +0530
tests: Add changelog api tests
updates: bz#1193929
Change-Id: Iee9aab8140882069165621189741f189fb2cc884
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 962e9d2758d1509faf8031dfe68b8919942d0411
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Thu May 2 18:33:34 2019 +0530
glusterd/tier: remove tier related code from glusterd
The handler functions are pointed to dummy functions.
The switch case handling for tier also have been moved to
point default case to avoid issues, if reintroduced.
The tier changes in DHT still remain as such.
updates: bz#1693692
Change-Id: I80d80c9a3eb862b4440a36b31ae82b2e9d92e4dc
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
commit ecd62f0b8aff2517906361110e7ca29cc844528f
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue May 21 15:28:10 2019 +0530
tests: Add history api tests
updates: bz#1193929
Change-Id: Ic26ab5277f720c734f083150c1c541763dfa64aa
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 68f8e873e0049c89509e38d429acef7965733105
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Tue May 7 09:55:08 2019 +0530
gfapi:add missng api to increase code coverage
add test for async Read/Write combinations
glfs_read_async/write_async
glfs_pread_async/pwrite_async
glfs_readv_async/writev_async
glfs_preadv_async/pwritev_async
ftruncate/ftruncate_async
fsync/fsync_async
fdatasync/fdatasync_async
Updates: #655
Change-Id: I12beb97029fd60bce79650a376d8fcd8d383ef16
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 27245a89e5e13eda13cde03d9796392d55d35c1e
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Mon Apr 15 14:59:37 2019 +0530
api/glfsxmp.c: minor fixes
* add more fops: f{get,set,list,remove}xattr(), access(), fstat(), fsetattr(),
getxattr(), lgetxattr(), llistxattr(), lsetxattr(), fgetxattr()
* handle some error cases (like volume not found)
Updates: #655
Change-Id: I3334bdf3090eafd83a54e1be12036ea01b181089
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 08b48e27cabd7063ebc39e2f73fdc2193acbfbb7
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed May 22 17:46:19 2019 +0200
Fix some "Null pointer dereference" coverity issues
This patch fixes the following CID's:
* 1124829
* 1274075
* 1274083
* 1274128
* 1274135
* 1274141
* 1274143
* 1274197
* 1274205
* 1274210
* 1274211
* 1288801
* 1398629
Change-Id: Ia7c86cfab3245b20777ffa296e1a59748040f558
Updates: bz#789278
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit d92d74aa7285e7f878965e12851223f69e79b02e
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu May 9 11:07:18 2019 +0200
cluster/ec: honor contention notifications for partially acquired locks
EC was ignoring lock contention notifications received while a lock was
being acquired. When a lock is partially acquired (some bricks have
granted the lock but some others not yet) we can receive notifications
from acquired bricks, which should be honored, since we may not receive
more notifications after that.
Since EC was ignoring them, once the lock was acquired, it was not
released until the eager-lock timeout, causing unnecessary delays on
other clients.
This fix takes into consideration the notifications received before
having completed the full lock acquisition. After that, the lock will
be releaed as soon as possible.
Fixes: bz#1708156
Change-Id: I2a306dbdb29fb557dcab7788a258bd75d826cc12
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 5e79aa0f8e8940d72dbb7d3a2079c860374f19f7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue May 21 10:58:44 2019 +0530
tests: Fix spurious failures in ta-write-on-bad-brick.t
Problem:
afr_child_up_status_meta works only when LOOKUP on $M0 is successful.
There are cases where quorum is not met and LOOKUP fails on $M0 which
leads to failures similar to:
grep: /mnt/glusterfs/0/.meta/graphs/active/patchy-replicate-0/private: Transport endpoint is not connected
This was happening once in a while based on attribute-timeout and
md-cache not serving the lookup.
Fix:
Find child-up status based on statedump instead. Also changed mount
options to include --entry-timeout=0 and --attribute-timeout=0
updates bz#1193929
Change-Id: Ic0de72c3006d7399a5feb3e4d10d4748949b2ab3
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit e16dd14a023b3643c96f7ce06825551cd0555c5d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 6 15:27:44 2019 +0530
tests: Test openfd heal doesn't truncate files
fixes bz#1706603
Change-Id: I0bfd30f787f157b7a54f71088f767ccfd7621208
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 00cb426e863f55d15522f9eb542e85bd0f0a55a8
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri May 17 14:27:58 2019 +0530
glusterd: coverity fix
CID: 1401345 - Unused value
updates: bz#789278
Change-Id: I6b8f2611151ce0174042384b7632019c312ebae3
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 6096f08d6283c7d72c5a4d91b5adab4fc2cd381b
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Thu May 9 10:43:01 2019 +0530
geo-rep: Geo-rep help text issue
Modified Geo-rep help text for better sanity.
fixes: bz#1652887
Change-Id: I40ef7ef709eaecf0125ab4b4a7517e2c5d1ef4a0
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 25e93feae604c2635b93f71880c2020d03377bd5
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue May 7 13:33:30 2019 +0300
glusterd-utils.c: skip checksum when possible.
We only need to calculate and write the checksum in case of
!is_quota_conf .
Align the code in accordance.
Also, use a smaller buffer (to write few chars).
Change-Id: I40c83ce10447df77ff9975d314d768ec2c0087c2
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit eb4fcbfd7d5cf2f710a1718a08169b2cd5194a23
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue May 21 16:51:09 2019 +0530
cli: Fixed typos
Change-Id: I14957c5161f31d5dfc6cf56f8d7ccf4d39372f39
fixes: bz#1711820
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit e3ab184e7f8648b2b903f0ccbd3235d47a0283bc
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Fri May 17 18:33:11 2019 +0800
inode: fix wrong loop count in __inode_ctx_free
Avoid serious memory leak
fixes: bz#1711240
Change-Id: Ic61a8fdd0e941e136c98376a87b5a77fa8c22316
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit 12ffd2c54cb6d1942957543304d90d6e3aaf4bf9
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon May 20 15:23:42 2019 +0530
cluster/dht: Lookup all files when processing directory
A rebalance process currently only looks up files
that it is supposed to migrate. This could cause issues
when lookup-optimize is enabled as the dir layout can be
updated with the commit hash before all files are looked up.
This is expecially problematic of one of the rebalance processes
fails to complete as clients will try to access files whose
linkto files might not have been created.
Each process will now lookup every file in the directory it is
processing.
Pros: Less likely that files will be inaccessible.
Cons: More lookup requests sent to the bricks and a potential
performance hit.
Note: this does not handle races such as when a layout is updated on disk
just as the create fop is sent by the client.
Change-Id: I22b55846effc08d3b827c3af9335229335f67fb8
fixes: bz#1711764
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 59b440aea311517e7db7923fbefbd53001fea52c
Author: Susant Palai <spalai@redhat.com>
Date: Tue May 21 16:17:09 2019 +0530
lock: check null value of dict to avoid log flooding
updates: bz#1712322
Change-Id: I120a1d23506f9ebcf88c7ea2f2eff4978a61cf4a
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 48e9b77c7bb5a682ddf0875fc7b8f1d6cc44fa1a
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue May 21 17:15:07 2019 +0530
ec/fini: Fix race with ec_fini and ec_notify
During a graph cleanup, we first sent a PARENT_DOWN and wait for
a child down to ultimately free the xlator and the graph.
In the ec xlator, we cleanup the threads when we get a PARENT_DOWN event.
But a racing event like CHILD_UP or event xl_op may trigger healing threads
after threads cleanup.
So there is a chance that the threads might access a freed private variabe
Change-Id: I252d10181bb67b95900c903d479de707a8489532
fixes: bz#1703948
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 04f11a2f629bebe5dde2a435296e86ec8a15afbd
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue May 21 11:20:01 2019 +0530
tests/quick-read-with-upcall.t: increase the timeout
Running with 2 second sleep at this place caused failures like:
`not ok 14 [ 2014/ 7] < 41> 'test-message1 cat /mnt/glusterfs/1/test.txt' -> 'Got "test-message0" instead of "test-message1"'`
in few runs in 100 iterations. But when increased to higher than sleep 3,
have not seen any failures in 100 runs.
While I don't know the exact reasons for the behavior yet, looks like this
increase in wait helps to pass the regression without failures.
updates: bz#1693692
Change-Id: I0610b79bea53e36de3eea6c11234b7fc9dfd6232
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit d48653a917a5f3a554a8438c9c01b08e295c1e52
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri May 17 23:03:35 2019 +0530
afr/frame: Destroy frame after afr_selfheal_entry_granular
In function "afr_selfheal_entry_granular", after completing the
heal we are not destroying the frame. This will lead to crash.
when we execute statedump operation, where it tried to access
xlator object. If this xlator object is freed as part of the
graph destroy this will lead to an invalid memory access
Change-Id: I0a5e78e704ef257c3ac0087eab2c310e78fbe36d
fixes: bz#1708926
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 66931357b02036434830c71f0db4407ab1152588
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue May 21 01:37:47 2019 +0000
Revert "rpc: implement reconnect back-off strategy"
This reverts commit 59841f7e1ff0511b04884015441a181a56d07bea.
This revert is done as a 'possible' fix for frequent regression
failures, which are random in nature too (ie, different tests fails
in different runs).
Why exactly this patch? Because this patch seemed like most probable
candidate which got merged in last 15days, and after which regressions
are failing more often.
Updates: bz#1711827
Change-Id: I35333162fcd4064f9609525ca93c666053c6d959
commit 3b429397ba421c365fe66c2f7e10eea4e712eaf7
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu May 16 18:37:48 2019 +0530
tests: change usleep() to sleep()
While running a test case the following warning messages are seen
on the display. To avoid suh warnings changing usleep() to sleep().
warning: usleep is deprecated, and will be removed in near future!
warning: use "sleep 0.25" instead...
updates: bz#1193929
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
Change-Id: I48b79ede1c70b101f654635dd4cc83e50ea55b73
commit ab6f7dc29a9757f1c0669322c676fed3a6263bd7
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Apr 5 10:30:23 2019 +0530
features/shard: Fix crash during background shard deletion in a specific case
Consider the following case -
1. A file gets FALLOCATE'd such that > "shard-lru-limit" number of
shards are created.
2. And then it is deleted after that.
The unique thing about FALLOCATE is that unlike WRITE, all of the
participant shards are resolved and created and fallocated in a single
batch. This means, in this case, after the first "shard-lru-limit"
number of shards are resolved and added to lru list, as part of
resolution of the remaining shards, some of the existing shards in lru
list will need to be evicted. So these evicted shards will be
inode_unlink()d as part of eviction. Now once the fop gets to the actual
FALLOCATE stage, the lru'd-out shards get added to fsync list.
2 things to note at this point:
i. the lru'd out shards are only part of fsync list, so each holds 1 ref
on base shard
ii. and the more recently used shards are part of both fsync and lru list.
So each of these shards holds 2 refs on base inode - one for being
part of fsync list, and the other for being part of lru list.
FALLOCATE completes successfully and then this very file is deleted, and
background shard deletion launched. Here's where the ref counts get mismatched.
First as part of inode_resolve()s during the deletion, the lru'd-out inodes
return NULL, because they are inode_unlink()'d by now. So these inodes need to
be freshly looked up. But as part of linking them in lookup_cbk (precisely in
shard_link_block_inode()), inode_link() returns the lru'd-out inode object.
And its inode ctx is still valid and ctx->base_inode valid from the last
time it was added to list.
But shard_common_lookup_shards_cbk() passes NULL in the place of base_pointer
to __shard_update_shards_inode_list(). This means, as part of adding the lru'd out
inode back to lru list, base inode is not ref'd since its NULL.
Whereas post unlinking this shard, during shard_unlink_block_inode(),
ctx->base_inode is accessible and is unref'd because the shard was found to be part
of LRU list, although the matching ref didn't occur. This at some point leads to
base_inode refcount becoming 0 and it getting destroyed and released back while some
of its associated shards are continuing to be unlinked in parallel and the client crashes
whenever it is accessed next.
Fix is to pass base shard correctly, if available, in shard_link_block_inode().
Also, the patch fixes the ret value check in tests/bugs/shard/shard-fallocate.c
Change-Id: Ibd0bc4c6952367608e10701473cbad3947d7559f
Updates: bz#1696136
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 23c2704445b54fb8dbeaedfbf742873a93ec3300
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue May 14 11:05:45 2019 +0530
geo-rep: Convert gfid conflict resolutiong logs into debug
The gfid conflict resolution code path is not supposed
to hit in generic code path. But few of the heavy rename
workload (BUG: 1694820) makes it a generic case. So
logging the entries to be fixed as INFO floods the log
in these particular workloads. Hence convert them to DEBUG.
fixes: bz#1709653
Change-Id: I4d5e102b87be5fe5b54f78f329e588882d72b9d9
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 84902679086c4595c16e612a9c658fa9a4c1d98e
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed May 8 11:26:06 2019 +0530
geo-rep: Fix sync hang with tarssh
Problem:
Geo-rep sync hangs when tarssh is used as sync
engine at heavy workload.
Analysis and Root cause:
It's found out that the tar process was hung.
When debugged further, it's found out that stderr
buffer of tar process on master was full i.e., 64k.
When the buffer was copied to a file from /proc/pid/fd/2,
the hang is resolved.
This can happen when files picked by tar process
to sync doesn't exist on master anymore. If this count
increases around 1k, the stderr buffer is filled up.
Fix:
The tar process is executed using Popen with stderr as PIPE.
The final execution is something like below.
tar | ssh <args> root@slave tar --overwrite -xf - -C <path>
It was waiting on ssh process first using communicate() and then tar.
Note that communicate() reads stdout and stderr. So when stderr of tar
process is filled up, there is no one to read until untar via ssh is
completed. This can't happen and leads to deadlock.
Hence we should be waiting on both process parallely, so that stderr is
read on both processes.
Change-Id: I609c7cc5c07e210c504771115b4d551a2e891adf
fixes: bz#1707728
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 557e26df5aa53aa95a32ff1a0dd31ff2cf3c06d1
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Apr 29 13:22:32 2019 +0530
ec/shd: Cleanup self heal daemon resources during ec fini
We were not properly cleaning self-heal daemon resources
during ec fini. With shd multiplexing, it is absolutely
necessary to cleanup all the resources during ec fini.
Change-Id: Iae4f1bce7d8c2e1da51ac568700a51088f3cc7f2
fixes: bz#1703948
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit da526eadd02d4eb169aec464ef96bc38c0ea1665
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Fri Jan 19 12:18:13 2018 +0100
rpc: implement reconnect back-off strategy
When a connection failure happens, gluster tries to reconnect every 3
seconds. In some cases the failure is spurious, so a delay of 3 seconds
could be unnecessarily long.
This patch implements a back-off strategy that tries a reconnect as soon
as 1 tenth of a second. If this fails, the time is doubled until it's
around 3 seconds. After that, the reconnect is attempted every 3 seconds
as before.
Change-Id: Icb3fbe20d618f50cbbb599dce542b4e871c22149
Updates: bz#1193929
Signed-off-by: Xavier Hernandez <xhernandez@redhat.com>
commit d7299f1169aec34d4008686824d67fbea9a28794
Author: Anoop C S <anoopcs@redhat.com>
Date: Fri May 10 12:21:31 2019 +0530
libglusterfs: Remove decompunder helper routines from symbol export
decompounder and related sources were removed via the following commits:
https://review.gluster.org/#/c/glusterfs/+/22627/
https://review.gluster.org/#/c/glusterfs/+/22629/
Therefore taking out symbol exports for those removed routines.
Change-Id: I2ef99a318de1e4b512cabd2fa923225c5b79b1e5
updates: bz#1193929
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit c4c59ea5694ab2aab9fe05203f5fa3d9d66698a2
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu May 9 10:08:25 2019 +0530
core: Capture process memory usage at the time of call gf_msg_nomem
Problem: All gluster processes call gf_mgm_nomem while calloc/malloc/realloc
throw an error but the message does not capture current memory usage of
gluster process
Solution: Call getrusage to capture current memory usage of gluster
process
Change-Id: I2e0319da1f33b177fa042fdc9e7268068576c9c3
fixes: bz#1708051
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 95cb6d8b7cba9a800aaab48b515026d9cf862865
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Apr 23 12:41:32 2019 +0530
cli: Validate invalid slave url
This patch validates the invalid slave url
in cli itself and throws appropriate error.
fixes: bz#1098991
Change-Id: I278e2a04a4d619d2c2d1db0dd56ab5bdf7e7f469
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 0f2e78a0115d1d8b3d601214f8f699eeb7d6e5f6
Author: Vishal Pandey <vpandey@redhat.com>
Date: Thu May 9 14:37:22 2019 +0530
glusterd: Add gluster volume stop operation to glusterd_validate_quorum()
ISSUE: gluster volume stop succeeds even if quorum is not met.
Fix: Add GD_OP_STOP_VOLUME to gluster_validate_quorum in
glusterd_mgmt_v3_pre_validate ().
Since the volume stop command has been ported from synctask to mgmt_v3,
the quorum check was missed out.
Change-Id: I7a634ad89ec2e286ea262d7952061efad5360042
fixes: bz#1690753
Signed-off-by: Vishal Pandey <vpandey@redhat.com>
commit 6dc2b5040897f9541eb8741a02eb7eafb8862429
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu May 9 14:43:06 2019 +0530
tests: fix bug-1319374.c compile warnings.
I was looking at a downstream failure of bug-1319374-THIS-crash.t when I
saw the compiler was throwing a warning while running the test:
tests/bugs/gfapi/bug-1319374.c:17:61: warning: implicit declaration of function ‘strerror’; did you mean ‘perror’? [-Wimplicit-function-declaration]
fprintf(stderr, "\nglfs_new: returned NULL (%s)\n", strerror(errno));
^~~~~~~~
perror
So I compiled the .c with -Wall and saw a lot many more warnings, all
due of a missing header. This patch fixes it.
fixes: bz#1708163
Change-Id: I8b6dd8e1404178a3d99b2d92d01f4575f5203e58
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 03ee8ec13be3b3a128f1b50489a38532f4891c10
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon May 6 23:35:08 2019 +0530
shd/glusterd: Serialize shd manager to prevent race condition
At the time of a glusterd restart, while doing a handshake
there is a possibility that multiple shd manager might get
executed. Because of this, there is a chance that multiple
shd get spawned during a glusterd restart
Change-Id: Ie20798441e07d7d7a93b7d38dfb924cea178a920
fixes: bz#1707081
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 9723abbd479c4b28c7b518a31e5cf1d2abcdba84
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Apr 9 09:44:33 2019 +0530
afr: thin-arbiter lock release fixes
- pass fop state instead of afr local to
afr_ta_dom_lock_check_and_release()
- avoid afr_lock_release_synctask() being called simultaneosuly from
notify code path and transaction (post-op) code path due to races.
- Check if the post-op on TA is valid based on event_gen checks.
- Invalidate in-memory information when we get TA child down.
Note: Thi patch addresses some pending review comments of commit
053b1309dc8fbc05fcde5223e734da9f694cf5cc
(https://review.gluster.org/#/c/glusterfs/+/20095/)
fixes: bz#1698449
Change-Id: I2ccd7e1b53362f9f3fed8680aecb23b5011eb18c
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 59da30c0cca668608a11fadf6ea490ea704b4600
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed May 8 12:13:59 2019 +0530
glusterd: fix inconsistent global option output in volume get
volume get all all | grep <key> & volume get <volname> all | grep <key>
dumps two different output value for cluster.brick-multiplex and
cluster.server-quorum-ratio
Fixes: bz#1707700
Change-Id: Id131734e0502aa514b84768cf67fce3c22364eae
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit dcca18418b3005cc5855ad551daba6a0d604aa19
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu May 2 18:06:13 2019 +0300
glusterd: reduce some work in glusterd-utils.c
Similar to https://review.gluster.org/#/c/glusterfs/+/22652/ ,
reduce some of the work by using smaller buffers and less
conversion of parameters when snprintf()'ing them.
On the way, remove some clang warnings, mainly on dead assignment.
Change-Id: Ie51e6d6f14df6b2ccbebba314cf937af08839741
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit eb1845d162353f41757db40c321b4927f1464355
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Fri Jan 19 12:18:13 2018 +0100
tests: improve and fix some test scripts
Change-Id: Iceefe22af754096c599dc570d4894d14fce4deae
Updates: bz#1193929
Signed-off-by: Xavier Hernandez <xhernandez@redhat.com>
commit cace148e3ed19c1b4db98bdd29bbeb1273179753
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed May 8 10:56:31 2019 +0530
geo-rep: Fix sync-method config
Problem:
When 'use_tarssh' is set to true, it exits with successful
message but the default 'rsync' was used as sync-engine.
The new config 'sync-method' is not allowed to set from cli.
Analysis and Fix:
The 'use_tarssh' config is deprecated with new
config framework and 'sync-method' is the new
config to choose sync-method i.e. tarssh or rsync.
This patch fixes the 'sync-method' config. The allowed
values are tarssh and rsync.
Change-Id: I0edb0319cad0455b29e49f2f08a64ce324735e84
fixes: bz#1707686
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 14eb7d718cff2eaf38358233b43674e1904b60bd
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed May 8 14:10:05 2019 +0530
tests/geo-rep: Fix arequal checksum comparison
The arequal checkusm comparison was always returning
as successful, eventhough, if it was not. Fixed the same.
Change-Id: I5083da25c0954126e452d06311d2d376f8540555
fixes: bz#1707742
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 9adf474a02b5627600fcf83abaf2b4ad8cfb19e2
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed May 8 07:58:27 2019 +0530
glusterd: improve logging in __server_getspec()
updates: bz#1193929
Change-Id: Idad745d5869c92e6bed71842f14bc1a3362ca4bd
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 97bcc5c5357c2e2b615126a1dcc07b23253b3b4c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed May 8 04:51:27 2019 -0400
afr: log before attempting data self-heal.
I was working on a blog about troubleshooting AFR issues and I wanted to copy
the messages logged by self-heal for my blog. I then realized that AFR-v2 is not
logging *before* attempting data heal while it logs it for metadata and entry
heals.
I [MSGID: 108026] [afr-self-heal-entry.c:883:afr_selfheal_entry_do]
0-testvol-replicate-0: performing entry selfheal on
d120c0cf-6e87-454b-965b-0d83a4c752bb
I [MSGID: 108026] [afr-self-heal-common.c:1741:afr_log_selfheal]
0-testvol-replicate-0: Completed entry selfheal on
d120c0cf-6e87-454b-965b-0d83a4c752bb. sources=[0] 2 sinks=1
I [MSGID: 108026] [afr-self-heal-common.c:1741:afr_log_selfheal]
0-testvol-replicate-0: Completed data selfheal on
a9b5f183-21eb-4fb3-a342-287d3a7dddc5. sources=[0] 2 sinks=1
I [MSGID: 108026] [afr-self-heal-metadata.c:52:__afr_selfheal_metadata_do]
0-testvol-replicate-0: performing metadata selfheal on
a9b5f183-21eb-4fb3-a342-287d3a7dddc5
I [MSGID: 108026] [afr-self-heal-common.c:1741:afr_log_selfheal]
0-testvol-replicate-0: Completed metadata selfheal on
a9b5f183-21eb-4fb3-a342-287d3a7dddc5. sources=[0] 2 sinks=1
Adding it in this patch. Now there is a 'performing' and a corresponding
'Completed' message for every type of heal.
fixes: bz#1707746
Change-Id: I0b954cf1e17b48280aefa76640b5119b92133d61
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit b017d9fd19810623637e8bf161ec6f5d12d7abec
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Apr 1 10:57:58 2019 +0530
tests: enhance the auth.allow test to validate all failures of 'login' module
now the enhanced test covers most of the code in auth.login and auth.addr module.
updates: bz#1693692
Change-Id: I1f43c7dc414e2e4d443a93e9a37051359fd46ea4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 89cded138a1611c24f07169cd71f8d3530c4a580
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue May 7 13:35:47 2019 +0530
geo-rep: fix incorrectly formatted authorized_keys
There are two ways for creating secret pem pub file during geo-rep
setup.
1. gluster-georep-sshkey generate
2. gluster system:: execute gsec_create
Below patch solves this problem for `gluster-georep-sshkey generate`
method.
Patch link: https://review.gluster.org/#/c/glusterfs/+/22246/
This patch is added to support old way of creating secret pem pub file
`gluster system:: execute gsec_create`.
Problem: While Geo-rep setup when creating an ssh authorized_keys
the geo-rep setup inserts an extra space before the "ssh-rsa" label.
This gets flagged by an enterprise customer's security scan as a
security violation.
Solution: Remove extra space while creating secret key.
fixes: bz#1679401
Change-Id: I92ba7e25aaa5123dae9ebe2f3c68d14315aa5f0e
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 8aa645c3eed3ae94f5af40fdc3685561f338b772
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Apr 28 22:05:44 2019 +0300
glusterd/store: store all key-values in one shot
Instead of saving each key-value separately, which is slow (
especially as we fflush() after each!), store them all as one
string and write all together.
Implements https://github.com/gluster/glusterfs/issues/629
Change-Id: Ie77a272446b0b6785584b710a4fdd9c613dd9578
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat,.com>
commit 9908abceb39d124372bcd109664a1b2527db1014
Author: root <root@localhost.localdomain>
Date: Sun Apr 7 19:31:17 2019 +0530
dht: Custom xattrs are not healed in case of add-brick
Problem: If any custom xattrs are set on the directory before
add a brick, xattrs are not healed on the directory
after adding a brick.
Solution: xattr are not healed because dht_selfheal_dir_mkdir_lookup_cbk
checks the value of MDS and if MDS value is not negative
selfheal code path does not take reference of MDS xattrs.Change the
condition to take reference of MDS xattr so that custom xattrs are
populated on newly added brick
Updates: bz#1702299
Change-Id: Id14beedb98cce6928055f294e1594b22132e811c
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit fa97b35aeb13757e918d1ea504dc5bf9bf0933d2
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Tue Apr 23 15:55:22 2019 +0000
afr : fix Coverity CID 1398627
Fixed coverity error, "Unchecked return value (CHECKED_RETURN)".
Checking return value & logging error message if afr_set_pending_dict
fails.
updates: bz#789278
Change-Id: Iab7da6b4f3cd0622b95b8e1c412b007a330467e5
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit d5de17f14fcef44680e8c548c26c02e623358421
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 6 15:57:16 2019 +0530
libglusterfs: Fix compilation when --disable-mempool is used
updates bz#1193929
Change-Id: I245c065b209bcce5db939b6a0a934ba6fd393b47
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit f107fd3bd7ac2cb8c77609be0821a3b88e8f66f6
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri May 3 10:14:48 2019 +0530
performance/write-behind: remove request from wip list in wb_writev_cbk
There is a race in the way O_DIRECT writes are handled. Assume two
overlapping write requests w1 and w2.
* w1 is issued and is in wb_inode->wip queue as the response is still
pending from bricks. Also wb_request_unref in wb_do_winds is not yet
invoked.
list_for_each_entry_safe (req, tmp, tasks, winds) {
list_del_init (&req->winds);
if (req->op_ret == -1) {
call_unwind_error_keep_stub (req->stub, req->op_ret,
req->op_errno);
} else {
call_resume_keep_stub (req->stub);
}
wb_request_unref (req);
}
* w2 is issued and wb_process_queue is invoked. w2 is not picked up
for winding as w1 is still in wb_inode->wip. w1 is added to todo
list and wb_writev for w2 returns.
* response to w1 is received and invokes wb_request_unref. Assume
wb_request_unref in wb_do_winds (see point 1) is not invoked
yet. Since there is one more refcount, wb_request_unref in
wb_writev_cbk of w1 doesn't remove w1 from wip.
* wb_process_queue is invoked as part of wb_writev_cbk of w1. But, it
fails to wind w2 as w1 is still in wip.
* wb_requet_unref is invoked on w1 as part of wb_do_winds. w1 is
removed from all queues including w1.
* After this point there is no invocation of wb_process_queue unless
new request is issued from application causing w2 to be hung till
the next request.
This bug is similar to bz 1626780 and bz 1379655.
Change-Id: Iaa47437613591699d4c8ad18bc0b32de6affcc31
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1705865
commit 2adbff606e636a43b741ed8c23731e120994f3c1
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Feb 27 15:48:42 2019 +0200
mem-pool.{c|h}: minor changes
1. Removed some code that was not needed. It did not really do anything.
2. CALLOC -> MALLOC in one place.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I4419161e1bb636158e32b5d33044b06f1eef2449
commit 38bd08c6d7098d5bf7452c00f846421677131e4e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Apr 30 14:06:03 2019 -0400
tests: delete the snapshots and the volume after the tests
In uss.t multiple snapshots are taken and after all the tests
things are left for the cleanup () function to get removed.
Instead of that, delete the snapshots and the volume once all
the tests are over so that cleanup operation becomes relatively
a light operation.
Change-Id: I2342740bbb185cd6c9a450eb3b4f5cbbba78974c
fixes: bz#1704888
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit f8d5387c5062dd97625d702ba935159e03368ca5
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Apr 12 07:55:04 2019 +0530
tests: validate volfile grammar - strings in volfile
* libglusterfs/graph-print: remove unused code
updates: bz#1693692
Change-Id: Iae81bb6a3af5911c3da07ab8f1d8f58f27e06905
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit df0e652678c9e446cf2225d8727142d810254ffb
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon May 6 10:35:23 2019 +0530
glusterd: coverity fix
CID: 1382403 (CHECKED_RETURN)
Updates: bz#789278
Change-Id: I4c57b93fd3d14c524ff8519ed876f029834de306
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 46c2a450415fb76122ce9273dfc8017892a203bc
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Apr 25 18:20:25 2019 +0800
cluster/ec: fix shd healer wait timeout
Right now, the timeout is written by hard code,
fix it by using heal-timeout.
fixes: bz#1703020
Change-Id: I0d154e7807f9dba7efc3896805559bbfaa7af2ad
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
commit cb8f883b6a33e40518c8f851a18156dbfc47edf0
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri May 3 10:50:40 2019 +0530
features/shard: Fix integer overflow in block count accounting
... by holding delta_blocks in 64-bit int as opposed to 32-bit int.
Change-Id: I2c1ddab17457f45e27428575ad16fa678fd6c0eb
updates: bz#1705884
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 81b6481c789801b5b57c65b432c36f5308f52ff7
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri May 3 09:18:31 2019 +0200
glusterd: prevent use-after-free in glusterd_op_ac_send_brick_op()
Coverity reported that GF_FREE(req_ctx) could be called 2x on req_ctx.
Change-Id: I9120686e5920de8c27688e10de0db6aa26292064
CID: 1401115
Updates: bz#789278
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 46f6c118053bd16b99af733f608054768a755320
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun May 5 21:17:24 2019 +0530
cluster/ec: Reopen shouldn't happen with O_TRUNC
Problem:
Doing re-open with O_TRUNC will truncate the fragment even when it is not
needed needing extra heals
Fix:
At the time of re-open don't use O_TRUNC.
fixes bz#1706603
Change-Id: Idc6408968efaad897b95a5a52481c66e843d3fb8
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit ddf2a199dd613492d3546030a60a752b61d71058
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed May 1 15:45:09 2019 +0300
glusterd-utils.c: reduce work in glusterd_add_volume_to_dict()
1. Use small arrays, 32 or 64 bytes should suffice.
2. Do not repeat the pattern of
snprintf '%s.%d', prefix, count
over and over.
Change-Id: Ief6de78b766d9a07acb6256fc4830f4f3cfba7c9
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 097da4d14ec70f29b7310eae8fa8945503e6895b
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Apr 25 12:00:52 2019 +0530
glusterd: Fix coverity defects & put coverity annotations
Along with fixing few defect, put the required annotations for the defects which
are marked ignore/false positive/intentional as per the coverity defect sheet.
This should avoid the per component graph showing many defects as open in the
coverity glusterfs web page.
Updates: bz#789278
Change-Id: I19461dc3603a3bd8f88866a1ab3db43d783af8e4
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 0370ca3462e0676c65182b426342b91959589a23
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Apr 25 19:02:39 2019 +0530
tests/cli: add .t file to increase line coverage in cli
updates: bz#1693692
Change-Id: Ib188c5fddea8c762e89ff15aa83b08c35cdb21e1
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit bdc1bf48524b016c35e2d7fd6c8a5d67f68c5b0a
Author: rishubhjain <rishubhjain47@gmail.com>
Date: Thu Apr 25 18:44:44 2019 +0530
tests: add .t files to increase cli code coverage
different volume profile sub options are added in the test.
Change-Id: I93100c37f51afc10870e60b91fcd86e7859e734a
updates: bz#1693692
Signed-off-by: rishubhjain <rishubhjain47@gmail.com>
commit 9233cf53689dfabc5a24b3bcd27f0b4fe7b10d6b
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Apr 16 20:54:24 2019 +0530
tests: Add changelog snapshot testcase
Add testcase to test snapshot creation
while I/O is happening with changelog
enabled.
updates: bz#1193929
Change-Id: Ice4cb596286c583ed7308484d65902007a48396c
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 3e80cc2fbc3c42b63a3c2b52c5bea79f5de4044f
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Apr 29 18:48:36 2019 +0530
glusterd: Fix bulkvoldict thread logic in brick multiplexing
Problem: Currently glusterd spawn bulkvoldict in brick_mux
environment while no. of volumes are less than configured
glusterd.vol_count_per_thread
Solution: Correct the logic to spawn bulkvoldict thread
1) Calculate endindex only while total thread is non zero
2) Update end index correctly to pass index for bulkvoldict
thread
Fixes: bz#1704252
Change-Id: I1def847fbdd6a605e7687bfc4e42b706bf0eb70b
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 7131384c8dd45ff4444135d3e709702dc6915e06
Author: Susant Palai <spalai@redhat.com>
Date: Mon Apr 29 11:36:16 2019 +0530
cloudsync/plugin: coverity fixes
CID 1401087: Null pointer dereferences (REVERSE_INULL)
CID 1401088: Null pointer dereferences (FORWARD_NULL)
Change-Id: I71bf67af80e1b22bcd2eb997b01a1a5ef0b4d80b
Updates: bz#789278
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 504f1f42a617e664875dd3dbb20c7cf54f08e5cd
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Apr 22 21:34:19 2019 +0300
options.c,h: minor changes to GF_OPTION_RECONF
Minor code changes (less variables and if statements)
and use dict_get_strn(), since all options are fixed strings.
Similar changes could be done to GF_OPTION_INIT() as well.
Change-Id: I4a523f67183f4c4852a3d4de5e3cac52df68d3cf
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 625b66ca8dff14153c756f847dd7be4fc1164e82
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Apr 24 22:29:55 2019 +0530
libglusterfs: remove compound-fop helper functions
updates: bz#1693692
Change-Id: If69702990af273be1f38855ba56b3b89fabff167
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit e34c69f1a068b57e9ef54e5caa274c762765aef0
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Fri Jan 19 12:18:13 2018 +0100
storage/posix: fix fresh file detection delay
Current implementation made it possible to consider that a file was not
fresh even if it was created less than a second ago. This patch fixes
the way in which the delay is computed to ensure that at least one
second has elapsed.
Change-Id: I05f7b99e7e8dd97e31f7ebaaec6c39eecf98b00f
Updates: bz#1193929
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit f9a4da7949f09b6eef7ed3310f01fdf4bca82c45
Author: Sheetal Pamecha <spamecha@redhat.com>
Date: Thu Apr 25 14:46:37 2019 +0530
nl-cache:add test to increase code coverage
Change-Id: Ie0a5c522dfa0123ca45f9decf5015d39b92cb0f3
updates: bz#1693692
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
commit 03621f812036d4b41f396a28f893b116a497b939
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Apr 20 11:55:12 2019 +0530
protocol: remove compound fop
Compound fops are kept on wire as a backward compatibility with
older AFR modules. The AFR module used beyond 4.x releases are
not using compound fops. Hence removing the compound fop in the
protocol code.
Note that, compound-fops was already an 'option' in AFR, and
completely removed since 4.1.x releases.
So, point to note is, with this change, we have 2 ways to upgrade
when clients of 3.x series are present.
i) set 'use-compound-fops' option to 'false' on any volume which
is of replica type. And then upgrade the servers.
ii) Do a two step upgrade. First from current version (which will
already be EOL if it's using compound) to a 4.1..6.x version,
and then an upgrade to 7.x.
Consider the overall code which we are removing for the option
seems quite high, I believe it is worth it.
updates: bz#1693692
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Change-Id: I0a8876d0367a15e1410ec845f251d5d3097ee593
commit 8664f9696134251218ad14d147342cfe8a3c7035
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Apr 24 22:23:36 2019 +0530
performance/decompounder: remove the translator as the feature is not used anymore
updates: bz#1693692
Change-Id: Id5932b11e115ca6da1c2bfff7ae1460787109e06
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit b4da07f3079d88c61c77c119131d352584748424
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Apr 26 22:28:53 2019 +0530
glusterd: define dumpops in the xlator_api of glusterd
Problem: statedump is not capturing information related to glusterd
Solution: statdump is not capturing glusterd info because
trav->dumpops is null in gf_proc_dump_single_xlator_info ()
where trav is glusterd xlator object. trav->dumpops is null
because we missed to define dumpops in xlator_api of glusterd.
defining dumpops in xlator_api of glusterd fixes the issue.
fixes: bz#1703629
Change-Id: If85429ecb1ef580aced8d5b88d09fc15258bfc4c
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 55b326e95a0da7379867b6acaa18ae5e323357b6
Author: Anuradha Talur <atalur@commvault.com>
Date: Wed Apr 24 12:35:08 2019 -0700
cloudsync: Fix bug in cloudsync-fops-c.py
In some of the fops generated by generator.py, xdata request
was not being wound to the child xlator correctly.
This was happening because when though the logic in
cloudsync-fops-c.py was correct, generator.py was generating
a resultant code that omits this logic.
Made changes in cloudsync-fops-c.py so that correct code is
produced.
Change-Id: I6f25bdb36ede06fd03be32c04087a75639d79150
updates: bz#1642168
Signed-off-by: Anuradha Talur <atalur@commvault.com>
commit 0b7b710fae41b466336e461ccd57d27de09fd654
Author: Anuradha Talur <atalur@commvault.com>
Date: Fri Nov 30 11:23:07 2018 -0800
cloudsync/cvlt: Cloudsync plugin for commvault store
Change-Id: Icbe53e78e9c4f6699c7a26a806ef4b14b39f5019
updates: bz#1642168
Signed-off-by: Anuradha Talur <atalur@commvault.com>
commit 0858be408fd1b8ba0ebd82830952671ea2e84c68
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Apr 26 08:47:12 2019 +0530
glusterd: coverity fixes
1400775 - USE_AFTER_FREE
1400742 - Missing Unlock
1400736 - CHECKED_RETURN
1398470 - Missing Unlock
Missing unlock is the tricky one, we have had annotation added, but
coverity still continued to complaint. Added pthread_mutex_unlock to
clean up the lock before destroying it to see if it makes coverity
happy.
Updates: bz#789278
Change-Id: I1d892612a17f805144d96c1b15004a85a1639414
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit cb9e1c5036378f7d357daa1adf709399a9e8f5d1
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Apr 23 18:05:36 2019 +0530
glusterd: enable fips-mode-rchecksum for new volumes
...during volume create if the cluster op-version is >=GD_OP_VERSION_7_0.
This option itself was introduced in GD_OP_VERSION_4_0_0 via commit 6daa65356.
We missed enabling it by default for new volume creates in that commit.
If we are to do it now safely, we need to use op version
GD_OP_VERSION_7_0 and target it for release-7.
fixes: bz#1702303
Change-Id: I7c6d4a8abe0816367e7069cb5cad01744f04858f
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 5a21722eb4fc009125e1cd20be8d73162d7eb931
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Thu Jul 9 15:56:28 2015 +0530
tools/glusterfind : validate session name
Validate a session name(during create) for the following:
1. minimum 2 character length.
2. Maximum 256 characters.
3. No special characters apart from underscore, hyphen allowed.
Also, validate volume(expect, while using glusterfind list).
Change-Id: I1b1e64e218f93d0a531d3cf69fc2ce7e2ed11d01
BUG: 1241494
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
commit b0c9e63e3a6ee899b42ee022b9cc00d2df688918
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Apr 2 12:38:09 2019 +0530
geo-rep: Fix rename with existing destination with same gfid
Problem:
Geo-rep fails to sync the rename properly if destination exists.
It results in source to be remained on slave causing more number of
files on slave. Also heavy rename workload like logrotate caused
lot of ESTALE errors
Cause:
Geo-rep fails to sync rename if destination exists if creation
of source file also falls into single batch of changelogs being
processed. This is because, after fixing problematic gfids verifying
from master, while re-processing original entries, CREATE also was
re-processed causing more files on slave and rename to be failed.
Solution:
Entries need to be removed from retrial list after fixing
problematic gfids on slave so that it's not re-created again on slave.
Also treat ESTALE as EEXIST so that the error is properly handled
verifying the op on master volume.
Change-Id: I50cf289e06b997adddff0552bf2466d9201dd1f9
fixes: bz#1694820
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 31f8f1f6f527adfb9b6126216e12ecc6688c1b10
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Apr 1 11:14:56 2019 +0530
features/locks: error-out {inode,entry}lk fops with all-zero lk-owner
Problem:
Sometimes we find that developers forget to assign lk-owner for an
inodelk/entrylk/lk before writing code to wind these fops. locks
xlator at the moment allows this operation. This leads to multiple
threads in the same client being able to get locks on the inode
because lk-owner is same and transport is same. So isolation
with locks can't be achieved.
Fix:
Disallow locks with lk-owner zero.
fixes bz#1624701
Change-Id: I1aadcfbaaa4d49308f7c819505857e201809b3bc
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 59b85d95e3d95648e94d94960c6408d6d9cdb363
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Apr 25 14:12:28 2019 +0530
man/gluster: remove tier information from gluster manual page
fixes: bz#1702952
Change-Id: I650a3695d702c03dc60660ff197676c6d536a2ea
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit d30c3125873503469841d7f525851d6900be9b73
Author: Anuradha Talur <atalur@commvault.com>
Date: Wed Apr 24 12:06:23 2019 -0700
cloudsync: Make readdirp return stat info of all the dirents
This change got missed while the initial changes were sent.
Should have been a part of :
https://review.gluster.org/#/c/glusterfs/+/21757/
Gist of the change:
Function that fills in stat info for dirents is
invoked in readdirp in posix when cloudsync populates xdata
request with GF_CS_OBJECT_STATUS.
Change-Id: Ide0c4e80afb74cd2120f74ba934ed40123152d69
updates: bz#1642168
Signed-off-by: Anuradha Talur <atalur@commvault.com>
commit e6d22da556b97cb97111913d65b00316802c8a45
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Apr 22 19:50:19 2019 +0530
tier/cli: remove tier code to increase code coverage in cli
Change-Id: I56cc09243dab23b3be86a7faac45001dda77181f
updates: bz#1693692
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit bc610fb14f4794df062c340275025e15c4bd8212
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Apr 24 22:02:51 2019 +0530
glusterd: coverity fixes
Addresses the following:
* CID 1124776: Resource leaks (RESOURCE_LEAK) - Variable "aa" going out
of scope leaks the storage it points to in glusterd-volgen.c
* Bunch of CHECKED_RETURN defects in the callers of synctask_barrier_init
* CID 1400755: Error handling issues (CHECKED_RETURN) - Calling
"gf_is_service_running" without checking return value in
xlators/mgmt/glusterd/src/glusterd-shd-svc.c: 671 in
glusterd_shdsvc_stop()
* CID 1400745: Memory - illegal accesses (USE_AFTER_FREE) - Dereferencing
freed pointer "volinfo" in /xlators/mgmt/glusterd/src/glusterd-shd-svc.c: 460 in glusterd_shdsvc_start()
* CID 1400742: Program hangs (LOCK) - adding annotation to fix this
false positive
Updates: bz#789278
Change-Id: I02f16e7eeb8c5cf72f7d0b29d00df4f03b3718b3
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 9849715d74677766cab0eba9d5a5677e5f1d1c25
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Mar 11 12:16:50 2019 -0400
features/bit-rot: Unconditionally sign the files during oneshot crawl
Currently bit-rot feature has an issue with disabling and reenabling it
on the same volume. Consider enabling bit-rot detection which goes on to
crawl and sign all the files present in the volume. Then some files are
modified and the bit-rot daemon goes on to sign the modified files with
the correct signature. Now, disable bit-rot feature. While, signing and
scrubbing are not happening, previous checksums of the files continue to
exist as extended attributes. Now, if some files with checksum xattrs get
modified, they are not signed with new signature as the feature is off.
At this point, if the feature is enabled again, the bit rot daemon will
go and sign those files which does not have any bit-rot specific xattrs
(i.e. those files which were created after bit-rot was disabled). Whereas
the files with bit-rot xattrs wont get signed with proper new checksum.
At this point if scrubber runs, it finds the on disk checksum and the actual
checksum of the file to be different (because the file got modified) and
marks the file as corrupted.
FIX:
The fix is to unconditionally sign the files when the bit-rot daemon
comes up (instead of skipping the files with bit-rot xattrs).
Change-Id: Iadfb47dd39f7e2e77f22d549a4a07a385284f4f5
fixes: bz#1700078
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit b2eb427a97e8ffa4fa0661615df81634e01c326f
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Apr 13 11:19:20 2019 +0530
build-aux/pkg-version: provide option for depth=1
Change-Id: I385063b757ae71db70f22a2f7c94e6abeedff426
updates: bz#1701337
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 6bb248099b275d1051a133bb4fb77a7c8c050d4c
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Mar 8 14:13:32 2019 +0200
logging.c/h: aggressively remove sprintfs()
Try to reduce the number of sprintf() and string copies until we finally
log a log line.
Specifically, do not sprintf separately the timestr string and
do not sprintf/strcpy the appmsgstr separately - just stick it with
the header.
Hoping I did not leak anything or changed the log line formatting.
Also, allocate 4K (GF_LOG_BACKTRACE_SIZE) of memory
dynamically for trace output -
only if trace was actually requested (previously, it was
unconditionally)
In addition, some minor code formatting (unrelated to the above).
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Id2ccc85f9213a2b1c6eaa4a2f58ce043eac1824f
commit 358a69fa19457bd61ea75c06c666152e5b1cda9c
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Apr 10 14:28:55 2019 +0530
cluster/dht: Refactor dht lookup functions
Part 2: Modify dht_revalidate_cbk to call
dht_selfheal_directory instead of separate calls
to heal attrs and xattrs.
Change-Id: Id41ac6c4220c2c35484812bbfc6157fc3c86b142
updates: bz#1590385
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 7013c84e7ade84012f425d6bdcaeb1bfd723b5cc
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Apr 23 10:45:25 2019 +0530
geo-rep: Fix entries and metadata counters in geo-rep status
Entries counter was incremented twice and decremented only
once. And entries count was being used in place of metadata
entries. This patch fixes both of them.
fixes: bz#1512093
Change-Id: I5601a5fe8d25c9d65b72eb529171e7117ebbb67f
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 453e50d1118cee79d29c4117c9b0cf096ede639f
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Mon Apr 1 17:04:01 2019 +0530
tests/geo-rep: Add pause and resume test case for geo-rep
Added pause and resume test case for geo-rep
fixes: bz#1696077
Change-Id: Ib6fcc1926c3be1263bca1235194f737b895c8333
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 0a118bf8395e4123ce7600d4aae187b2575a993b
Author: rishubhjain <rishubhjain47@gmail.com>
Date: Mon Apr 22 20:48:02 2019 +0530
tests: add .t files to increase cli code coverage
Tests added for gluster volume top and profile
with and without xml output
Change-Id: I66aa6390b53ca448014059a3d27dc72e405216d2
updates: bz#1693692
Signed-off-by: rishubhjain <rishubhjain47@gmail.com>
commit 17c26b3b0a6bb737b31ba6b625efa56a557cf042
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Apr 22 18:10:05 2019 +0530
tests: add .t file to increase cli code coverage
updates: bz#1693692
Change-Id: I848e622d7b8562e864f0e208aafdc21d9cb757d3
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 1c751cf82980c35af08830164b5d1fb72bc2e84f
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Apr 19 11:34:37 2019 +0530
ctime: Fix log repeated logging during open
The log "posix set mdata failed, No ctime" logged repeatedly
after the fix [1]. Those could be internal fops. This patch
fixes the same.
[1] https://review.gluster.org/22540
fixes: bz#1701457
Change-Id: I42799a90b976982cedb0ca11fa224d555eb05650
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit dae78d39bf60d470f67a23f47a715b477aed60f2
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Mar 5 18:58:20 2019 +0100
core: avoid dynamic TLS allocation when possible
Some interdependencies between logging and memory management functions
make it impossible to use the logging framework before initializing
memory subsystem because they both depend on Thread Local Storage
allocated through pthread_key_create() during initialization.
This causes a crash when we try to log something very early in the
initialization phase.
To prevent this, several dynamically allocated TLS structures have
been replaced by static TLS reserved at compile time using '__thread'
keyword. This also reduces the number of error sources, making
initialization simpler.
Updates: bz#1193929
Change-Id: I8ea2e072411e30790d50084b6b7e909c7bb01d50
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 2e28915803782f7c5dbc2a461235e80fc20b0ae4
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Apr 23 13:03:28 2019 +0530
glusterd/shd: Keep a ref on volinfo until attach rpc execute cbk
When svc attach execute for multiplexing a daemon, we have to keep
a ref on volinfo until it finish the execution. Because, if the attach
is an aysnc call, then a parallel volume delete can lead to free the
volinfo
Change-Id: Ibc02b89557baaed2f63db63d7fb1a7480444ae0d
fixes: bz#1702185
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit fbdcc585356e2f12cefa2bf1ff7a437e14d6e376
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Apr 1 09:03:12 2019 -0400
build: conditional rpcbind for gnfs in glusterd.service
Don't Require: rpcbind in glusterd.service when gnfs isn't built
Also add .../gluster-ta-volume.service to .gitignore
See https://github.com/gluster/glusterfs/issues/647
Change-Id: I4d90cf66b12c378c0a9aace89a3a4bbf3784c284
Fixes: #647
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 0c00c387637317a8001fe0ceb81d5b0b0faed9fa
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Apr 12 17:54:44 2019 +0200
cluster/ec: fix fd reopen
Currently EC tries to reopen fd's that have been opened while a brick
was down. This is done as part of regular write operations, just after
having acquired the locks, and it's sent as a sub-fop of the main write
fop.
There were two problems:
1. The reopen was attempted on all UP bricks, even if a previous lock
didn't succeed. This is incorrect because most probably the open will
fail.
2. If reopen is sent and fails, the error is propagated to the main
operation, causing it to fail when it shouldn't.
To fix this, we only attempt reopens on bricks where the current fop
owns a lock, and we prevent any error to be propagated to the main
fop.
To implement this behaviour an argument used to indicate the minimum
number of required answers has overloaded to also include some flags. To
make the change consistent, it has been necessary to rename the
argument, which means that a lot of files have been changed. However
there are no functional changes.
This change has also uncovered a problem in discard code, which didn't
correctely process requests of small sizes because no real discard fop
was being processed, only a write of 0's on some region. In this case
some fields of the fop remained uninitialized or with incorrect values.
To fix this, a new function has been created to simulate success on a
fop and it's used in the discard case.
Thanks to Pranith for providing a test script that has also detected an
issue in this patch. This patch includes a small modification of this
script to force data to be written into bricks before stopping them.
Change-Id: If272343873369186c2fb8f43c1d9c52c3ea304ec
Fixes: bz#1699866
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit a0aa4eb12ff515d3259a23fabe9f9b67928d1413
Author: Susant Palai <spalai@redhat.com>
Date: Mon Apr 22 21:18:30 2019 +0530
core: fix hang issue in __gf_free
Currently GF_ASSERT is done under mem_accounting lock at some places.
On a GF_ASSERT failure, gf_msg_callingfn is called which calls gf_malloc
internally and it takes the same mem_accounting lock leading to deadlock.
This is a temporary fix to avoid any hang issue in master.
https://review.gluster.org/#/c/glusterfs/+/22589/ is being worked on
in the mean while so that GF_ASSERT can be used under mem_accounting
lock.
Change-Id: I6d67f23979e7edd2695bdc6aab2997dae4a4060a
updates: bz#1700865
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 14cc01d9ee27c5bb6c3bfaaac592dc35dbd13468
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 17 00:16:49 2019 +0530
features/sdfs: Assign unique lk-owner for entrylk fop
sdfs is supposed to serialize entry fops by doing entrylk, but all the locks
are being done with all-zero lk-owner. In essence sdfs doesn't achieve its goal
of mutual exclusion when conflicting operations are executed by same client
because two locks on same entry with same all-zero-owner will get locks.
Fixed this up by assigning lk-owner before taking entrylk
updates bz#1624701
Change-Id: Ifabfc998c9f1724915d38e90ed8287e05797d769
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit f1f8695426bc62b13b2fa35535ca0d4e4d2c64ab
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 17 13:58:21 2019 +0530
cluster/afr: Set lk-owner before inodelk/entrylk/lk
Updates: bz#1624701
Change-Id: I7152c28ad85925abccdcc4cd6de8cb2a2b847a51
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 8b8234a0dddd08f1e0d8c310e539c3dd558d13f8
Author: rishubhjain <rishubhjain47@gmail.com>
Date: Mon Apr 8 20:20:12 2019 +0530
GlusterD:Checking for null value to void explicit dereferencing of null pointer
Before calling strtok_r a check for null pointer is necessary to avoid
dereferencing of null pointer
CID:1398617
CID:1274074
Change-Id: I34956c6e04af1faa22d550e6474909ecd36f5d6c
updates: bz#789278
Signed-off-by: rishubhjain <rishubhjain47@gmail.com>
commit 6959a92d4fd097f20d6775aee889375da157ab46
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Apr 12 13:40:59 2019 +0200
core: handle memory accounting correctly
When a translator stops, memory accounting for that translator is not
destroyed (because there could remain memory allocated that references
it), but mutexes that coordinate updates of memory accounting were
destroyed. This caused incorrect memory accounting and even crashes in
debug mode.
This patch also fixes some other things:
* Reduce the number of atomic operations needed to manage memory
accounting.
* Correctly account memory when realloc() is used.
* Merge two critical sections into one.
* Cleaned the code a bit.
Change-Id: Id5eaee7338729b9bc52c931815ca3ff1e5a7dcc8
Updates: bz#1659334
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 5e33dffee9c69561374619da678c609a92917e5f
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Apr 17 08:58:57 2019 +0200
features/locks: fix coverity issues
This patch fixes the following NULL dereferences identified by Coverity:
* CID 1398619
* CID 1398621
* CID 1398623
* CID 1398625
* CID 1398626
Change-Id: Id6af0d7cba0bb3346005376bc27180e8476255a4
Updates: bz#789278
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 6d34960bc7be834ed36b286833b7ee8b65aafcf6
Author: Milan Zink <mzink@redhat.com>
Date: Mon Feb 5 15:04:37 2018 +0100
extras/hooks: syntactical errors in SELinux hooks, scipt logic improved
Fixes: bz#1542072
Change-Id: Ia5fa1df81bbaec3a84653d136a331c76b457f42c
Signed-off-by: Milan Zink <zeten30@gmail.com>
commit f35d0dfcc8862e707e2bc26fd01789a955c3f769
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 16 17:20:34 2019 +0530
glusterd: fix loading ctime in client graph logic
Commit efbf8ab wasn't handling all the scenarios of toggling ctime
option correctly and more over a ! had completely tossed up the logic.
Fixes: bz#1697907
Change-Id: If12e2f69045e59878992ee2cd0518cc0eabcce0d
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 8516b3e9be6e2cb4250545a6177b11774f6b3a19
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 16 22:14:47 2019 +0530
Revert "features/locks: error-out {inode,entry}lk fops with all-zero lk-owner"
This reverts commit 3883887427a7f2dc458a9773e05f7c8ce8e62301 as it has
broken sdfs-sanity.t.
Updates: bz#1624701
Change-Id: Icb2b0d6bfcce4d556f1cd0f11695c03ffc138736
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 069fb154cd4059b255dde5f4c34fbf5565b1b9a8
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Apr 15 14:09:34 2019 -0400
features/bit-rot-stub: clean the mutex after cancelling the signer thread
When bit-rot feature is disabled, the signer thread from the bit-rot-stub
xlator (the thread which performs the setxattr of the signature on to the
disk) is cancelled. But, if the cancelled signer thread had already held
the mutex (&priv->lock) which it uses to monitor the queue of files to
be signed, then the mutex is never released. This creates problems in
future when the feature is enabled again. Both the new instance of the
signer thread and the regular thread which enqueues the files to be
signed will be blocked on this mutex.
So, as part of cancelling the signer thread, unlock the mutex associated
with it as well using pthread_cleanup_push and pthread_cleanup_pop.
Change-Id: Ib761910caed90b268e69794ddeb108165487af40
updates: bz#1700078
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit d2193c8a028a4a7f07e6e584a55bece4d5ca5e66
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 16 08:46:21 2019 +0530
glusterd: fix op-version of glusterd.vol_count_per_thread
It was hardcoded and with a wrong value.
Fixes: bz#1699339
Change-Id: Ibabe2424a0d35e172a9259bd8849c9bb7cebff1e
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 7ce53b229089b7090ecfda2e32a4f54409d73d8c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Apr 16 14:19:47 2019 +0530
tests: Heal should fail when read/write fails
updates: bz#1699866
Change-Id: I7ccd1fc5fc134eeb6d443c755962a20819320d48
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit c2bcbadf0bbbaa88c25780839db6c7e7a2710f43
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Apr 1 11:14:56 2019 +0530
features/locks: error-out {inode,entry}lk fops with all-zero lk-owner
Problem:
Sometimes we find that developers forget to assign lk-owner for an
inodelk/entrylk/lk before writing code to wind these fops. locks
xlator at the moment allows this operation. This leads to multiple
threads in the same client being able to get locks on the inode
because lk-owner is same and transport is same. So isolation
with locks can't be achieved.
Fix:
Disallow locks with lk-owner zero.
fixes bz#1624701
Change-Id: I1c816280cffd150ebb392e3dcd4d21007cdd767f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 94cdf7345615c0273cbb01b5a545f0f04ecf89ec
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri Mar 29 11:48:32 2019 +0530
glusterd: Optimize glusterd handshaking code path
Problem: At the time of handshaking glusterd populate volume
data in a dictionary.While no. of volumes are configured
more than 1500 glusterd takes more than 10 min to generated
the data.Due to taking more time rpc request times out and
rpc start bailing of call frames.
Solution: To optimize the code done below changes
1) Spawn multiple threads to populate volumes data in bulk
in separate dictionary and introduce an option
glusterd.brick-dict-thread-count to configure no. of threads
to populate volume data.
2) Populate tier data only while volume type is tier
3) Compare snap data only while snap_count is non zero
Fixes: bz#1699339
Change-Id: I38dc71970c049217f9d1a06fc0aaf4c26eab18f5
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit dc371349900aa290343a183e7d8d63293373bc33
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Apr 12 19:55:10 2019 +0530
libgfchangelog : use find_library to locate shared library
Issue:
libgfchangelog.so: cannot open shared object file
Due to hardcoded shared library name runtime loader looks for particular version of
a shared library.
Solution:
Using find_library to locate shared library at runtime solves this issue.
Traceback (most recent call last):
File "/usr/libexec/glusterfs/python/syncdaemon/gsyncd.py", line 323, in main
func(args)
File "/usr/libexec/glusterfs/python/syncdaemon/subcmds.py", line 82, in subcmd_worker
local.service_loop(remote)
File "/usr/libexec/glusterfs/python/syncdaemon/resource.py", line 1261, in service_loop
changelog_agent.init()
File "/usr/libexec/glusterfs/python/syncdaemon/repce.py", line 233, in __call__
return self.ins(self.meth, *a)
File "/usr/libexec/glusterfs/python/syncdaemon/repce.py", line 215, in __call__
raise res
OSError: libgfchangelog.so: cannot open shared object file: No such file or directory
Change-Id: I3dd013d701ed1cd99ba7ef20d1898f343e1db8f5
fixes: bz#1699394
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit c4f01d06a1864d09d8871f8ae56c6c53e2524b7c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Apr 5 12:33:55 2019 +0530
shd/mux: Fix coverity issues introduced by shd mux patch
CID 1400475: Null pointer dereferences (FORWARD_NULL)
CID 1400474: Null pointer dereferences (FORWARD_NULL)
CID 1400471: Code maintainability issues (UNUSED_VALUE)
CID 1400470: Null pointer dereferences (FORWARD_NULL)
CID 1400469: Memory - illegal accesses (USE_AFTER_FREE)
CID 1400467: Code maintainability issues (UNUSED_VALUE)
Change-Id: I0ca1c733be335c6e5844f44850f8066626ac40d4
updates: bz#789278
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 91ba555a19ae72b6d6c269ab274e5dc5061880ac
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Apr 4 15:31:56 2019 +0530
cluster/afr: Remove local from owners_list on failure of lock-acquisition
When eager-lock lock acquisition fails because of say network failures, the
local is not being removed from owners_list, this leads to accumulation of
waiting frames and the application will hang because the waiting frames are
under the assumption that another transaction is in the process of acquiring
lock because owner-list is not empty. Handled this case as well in this patch.
Added asserts to make it easier to find these problems in future.
fixes bz#1696599
Change-Id: I3101393265e9827755725b1f2d94a93d8709e923
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 7d6655d614658875404175a7bf9864ed357397a6
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Apr 4 09:56:11 2019 +0530
core: Log level changes do not effect on running client process
Problem: commit c34e4161f3cb6539ec83a9020f3d27eb4759a975 set log-level
per xlator during reconfigure only for a brick process not for
the client process.
Solution: 1) Change per xlator log-level only if brick_mux is enabled.To make sure
about brick multiplex introudce a flag brick_mux at ctx->cmd_args.
Note: There are two other changes done with this patch
1) Ignore client-log-level option to attach a brick with
already running brick if brick_mux is enabled
2) Add a log to print pid of the running process to make easier
debugging
Change-Id: I39e85de778e150d0685cd9a79425ce8b4783f9c9
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
Fixes: bz#1696046
commit 55ba4728c7c05980efc331a4c8292cb9b0a9d4c8
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Mar 25 19:07:16 2019 +0200
graph.c: remove extra gettimeofday() - reuse the graph dob.
It was written just before fill_void() call.
Note that there was a possible overflow if the hostname was too long
(unrelated to this patch), but it is now also fixed, as we use a smaller buffer
for the hostname. This, in turn, forces us to check if gethostname() failed
and add explicitly the terminating null to it.
Change-Id: I45fbc0a8e105f1247f3cbf61befac06fabbaea06
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit acfa8c54792c30d8c76d3893a6570ebed5458155
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Apr 9 18:23:05 2019 +0530
posix/ctime: Fix stat(time attributes) inconsistency during readdirp
Problem:
Creation of tar file on gluster volume throws warning
'file changed as we read it'
Cause:
During readdirp, for few of the files whose inode is not
present, time attributes were served from backend. This caused
the ctime of few files to be different between before readdir
and after readdir by tar.
Solution:
If ctime feature is enabled and inode is not present, don't
serve the time attributes from backend file, serve it from xattr.
fixes: bz#1698078
Change-Id: I427ef865f97399475faf5aa6ca495f7e317603ae
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 8e6931705bd3b5db6a4e2829369f2ab52ca9ec77
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Apr 1 10:33:37 2019 +0530
marker-quota: remove dead code
also make minor changes for signature (int -> void) where return value
was not checked anywhere.
updates: bz#1693692
Change-Id: Iff117712eb65e0b6b8b441a779202a117fcdf1fb
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 257a2a72b0409f754264161fc67d304fe733e597
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Apr 11 20:38:53 2019 +0530
core: Brick is not able to detach successfully in brick_mux environment
Problem: In brick_mux environment, while volumes are stopped in a
loop bricks are not detached successfully. Brick's are not
detached because xprtrefcnt has not become 0 for detached brick.
At the time of initiating brick detach process server_notify
saves xprtrefcnt on detach brick and once counter has become
0 then server_rpc_notify spawn a server_graph_janitor_threads
for cleanup brick resources.xprtrefcnt has not become 0 because
socket framework is not working due to assigning 0 as a fd for socket.
In commit dc25d2c1eeace91669052e3cecc083896e7329b2
there was a change in changelog fini to close htime_fd if htime_fd is not
negative, by default htime_fd is 0 so it close 0 also.
Solution: Initialize htime_fd to -1 after just allocate changelog_priv
by GF_CALLOC
Fixes: bz#1699025
Change-Id: I5f7ca62a0eb1c0510c3e9b880d6ab8af8d736a25
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit aa9ccfe71509d5c4a1eb3b9851fd363aef609190
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Apr 9 20:51:21 2019 +0300
glusterd-volgen.c: skip fetching some vol settings in a bricks loop.
The values are per volume, and are not going to change
while processing its bricks, as far as I can understand the code.
Fetch them and store them outside the loop.
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I2bc263f92f9141ea26a9dfb8265225f38307cbac
commit 885dc2c44577df45b0fb6c447def5b2786cc0d44
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Feb 27 16:02:43 2019 -0800
Replace memdup() with gf_memdup()
memdup() and gf_memdup() have the same implementation. Removed one API
as the presence of both can be confusing.
Change-Id: I562130c668457e13e4288e592792872d2e49887e
updates: bz#1193929
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 197b0a813bdc4c468d0958163ac4c722f7465224
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Fri Apr 12 11:35:55 2019 +0800
ec: fix truncate lock to cover the write in tuncate clean
ec_truncate_clean does writing under the lock granted for truncate,
but the lock is calculated by ec_adjust_offset_up, so that,
the write in ec_truncate_clean is out of lock.
Updates: bz#1699189
Change-Id: Idbe1fd48d26afe49c36b77db9f12e0907f5a4134
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
commit 84a2a6a5f57c7528fae32f3f068e75436a754b9b
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Apr 11 12:12:12 2019 +0530
tests/dht: Test that lookups are sent post brick up
Change-Id: I3556793c5e9d58cc6a08644b41dc5740fab2610b
updates: bz#1628194
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 5fedb25845f6a5ed2407ef1855ca9a05fa315eb3
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Mar 18 11:57:28 2019 +0530
cluster/afr: Thin-arbiter SHD fixes
This patch address post-merge review comments for commit
5784a00f997212d34bd52b2303e20c097240d91c
Change-Id: I7ed954664a2ae8e1091d23ee3ceb9c66e83bfeac
fixes: bz#1697930
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 181a2c15e66270cab2d795b3391b9047784140af
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Apr 8 19:18:51 2019 +0530
test: Change glustershd_pid update in .t file
Problem: bug-1650403.t && bug-858215.t are throwing error
at the time of access glustershd pidfile
Solution: Use ps command to findout glustershd pid
Change-Id: I3477345b6220aa039e012e674cba21d741e9abab
fixes: bz#1697486
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit f960d27abd1b53f30e0726feffb1274d45eb685d
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Apr 11 18:13:31 2019 +0530
glusterd: display an error when rebalance start is failed
fixes: bz#1699176
credits: Hari Gowtham <hgowtham@redhat.com>
Change-Id: I59134336febf0dc4043483f2f413ac83e3bc79f5
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 6735de20a57e0bf4f97d6948e755743fe69c70c1
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Apr 3 16:49:19 2019 +0530
tests: make sure to traverse all of meta dir
Just to make all files will be listed, which means we have max code-coverage
updates: bz#1693692
Change-Id: I11d36ac2f4d6d4fb91223aacd423ad23242eb454
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 485513aececb3a31e978c00ea9547a3204b36f89
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Apr 8 18:54:46 2019 +0530
glusterd: remove glusterd_check_volume_exists() call
As the same functionality is covered in glusterd_volinfo_find
Updates: bz#1193929
Change-Id: I2308c5fa9b2ca9edaa95f172d0bd914103808c36
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit f002a8ad8f92ee9cea1daf243dfa6cedfbecc5de
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Apr 9 13:56:24 2019 +0530
glusterd: provide a way to detach failed node
When a gluster node in trusted storage pool has failed
due to hardware issues, volume delete operation fails
saying "Not all peers are up" and peer detach for failed
node fails saying "Brick(s) with peer <peer_ip> exists
in cluster".
The idea here is to use either replace-brick or remove-brick
command to remove all the bricks hosted by failed node and
then re-attempting the peer detach. This change adds this
trick in peer detach error message.
fixes: bz#1697866
Change-Id: I0c58887479d31db603ad8d6535ea9d547880ccc8
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 843f155e9f0a0876834580315930c5244c76cfe8
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 8 12:14:34 2019 +0200
core: only log seek errors if SEEK_HOLE/SEEK_DATA is available
On RHEL-6 there is no support for SEEK_HOLE/SEEK_DATA and this causes
the POSIX xlator to return errno=EINVAL. Because of this, the rpc-server
xlator will log all 'failed' seek attempts. When applications call
seek() often, the brick logs can grow very quickly and fill up the
disks.
Messages that get logged are like
[server-rpc-fops.c:2091:server_seek_cbk] 0-vol01-server: 4947: SEEK-2 (53920aee-062c-4598-aa50-2b4d7821b204), client: worker.example.com-7808-2019/02/08-18:04:57:903430-vol01-client-0-0-0, error-xlator: vol01-posix [Invalid argument]
The problem can be reproduced by running a Gluster Server on RHEL-6,
with a client running on RHEL-7. The client should execute an
application that calls lseek() with SEEK_HOLE/SEEK_DATA.
Change-Id: I7b6c16f8e0ba1a183e845cfdb8d5a3f8caeab138
Fixes: bz#1697316
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 39fb328229a441b27a2b53c45b7fdd0cf324b31b
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Apr 1 14:44:20 2019 +0530
client/fini: return fini after rpc cleanup
There is a race condition in rpc_transport later
and client fini.
Sequence of events to happen the race condition
1) When we want to destroy a graph, we send a parent down
event first
2) Once parent down received on a client xlator, we will
initiates a rpc disconnect
3) This will in turn generates a child down event.
4) When we process child down, we first do fini for
Every xlator
5) On successful return of fini, we delete the graph
Here after the step 5, there is a chance that the fini
on client might not be finished. Because an rpc_tranpsort
ref can race with the above sequence.
So we have to wait till all rpc's are successfully freed
before returning the fini from client
Change-Id: I20145662d71fb837e448a4d3210d1fcb2855f2d4
fixes: bz#1659708
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 36ff73731ae3bc8d0c2671f047c40482fec6acbf
Author: Anuradha Talur <atalur@commvault.com>
Date: Thu Nov 29 12:54:21 2018 -0800
features/cloudsync : Added some new functions
This patch contains the following changes:
1) Store ID info will now be stored in the inode ctx
2) Added new readv type where read is made directly
from the remote store. This choice is made by
volume set operation.
3) cs_forget() was missing. Added it.
Change-Id: Ie3232b3d7ffb5313a03f011b0553b19793eedfa2
fixes: bz#1642168
Signed-off-by: Anuradha Talur <atalur@commvault.com>
commit 02ba07b8675ab68ff060fb8695a249f4f227c006
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Apr 4 22:28:51 2019 +0200
tests: correctly check open fd's when gfid is missing
The helper funcion get_fd_count() returns how many open fd's has a given
gfid on a brick. It could happen that the brick doesn't have information
about that inode because it has not been previously accessed.
Before this patch, the function returned "" when the inode was not
present. This caused basic/ec/ec-fix-openfd.t test to fail because it
was expecting '0' as the result.
This patch forces get_fd_count() to return '0' when the gfid is not
present in the state dump.
Change-Id: I848b57744e96656bf81fbb7b126a5faf44e535eb
updates: bz#1193929
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 76339da96b2ba477cdc96fe46bcb16342b6889fd
Author: Anuradha Talur <atalur@commvault.com>
Date: Tue Nov 20 13:15:26 2018 -0800
storage/posix: changes with respect to cloudsync
Main changes include logic to update iatt buf
with file size from extended attributes in posix
rather than having this logic in cloudsync xlator.
Change-Id: I44f5f8df7a01e496372557fe2f4eff368dbdaa33
fixes: bz#1642168
Signed-off-by: Anuradha Talur <atalur@commvault.com>
commit 011755d8d334ce9326e6abb9e9d499320bd5ff12
Author: Anuradha Talur <atalur@commvault.com>
Date: Mon Nov 19 17:57:18 2018 -0800
mgmt/glusterd: Make changes related to cloudsync xlator
1) The placement of cloudsync xlator has been changed
to make it shard xlator's child. If cloudsync has to
work with shard in the graph, it needs to be child of shard.
Change-Id: Ib55424fdcb7ce8edae9f19b8a6e3d3ba86c1f0c4
fixes: bz#1642168
Signed-off-by: Anuradha Talur <atalur@commvault.com>
commit d56df273719db55fa4531e25dcae7d61a253c0f5
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Mar 29 08:30:49 2019 +0530
protocol: add an option to force using old-protocol
As protocol implements every fop, and in general a large part of
the codebase. Considering our regression is run mostly in 1 machine,
there was no way of forcing the client to use old protocol (while new
one is available). With this patch, a new 'testing' option is provided
which forces client to use old protocol if found.
This should help increase the code coverage by at least 10k lines overall.
updates: bz#1693692
Change-Id: Ie45256f7dea250671b689c72b4b6f25037cef948
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 5b7564707e9f932fa77b264abb76279d2edcd207
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Apr 4 23:57:20 2019 +0200
ec: increase line coverage of ec
Test ec-cpu-extensions.t has been modified so that it uses a bigger
matrix. This makes use of more functions from ec-code-c.c. Changing
read-policy to round-robin increases even more the functions used,
reaching 100% of line and function coverage for this file.
Change-Id: I26e4d33269cbd67f5d76d862f4cf1e69285e85e1
updates: bz#1193929
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 4d5d4ac3380e782ce90092ffb5235cf3ceb64f3e
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Mar 29 00:10:15 2019 +0530
tests: add a tests for trace xlator
this test alone covers most of code of trace xlator
updates: bz#1693692
Change-Id: I287c72ee89bd1c02d992b020d5644e8dac0b77ab
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 21a31fbf2e3d1818744f4c335decc37a50490e4e
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri Apr 5 09:17:02 2019 +0530
build: glusterfs build is failing on RHEL-6
Problem: glusterfs build is throwing error undefined
reference to `dlclose' on RHEL 6
Solution: Add LIB_DL link in Makefile.am to resolve the same
Fixes: bz#1696512
Change-Id: I58019ca9e29d569d8e6df282b8ab178ad540843b
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit fe43737005d664132ac27db36b06c22cd7e11090
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 9 14:58:29 2019 +0530
glusterd: load ctime in the client graph only if it's not turned off
Considering ctime is a client side feature, we can't blindly load ctime
xlator into the client graph if it's explicitly turned off, that'd
result into backward compatibility issue where an old client can't mount
a volume configured on a server which is having ctime feature.
Fixes: bz#1697907
Change-Id: I6ae7b96d056073aa6746de9a449cf319786d45cc
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 6571506dec86d8f24cbfbbfb88f94d7b68696344
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Apr 5 08:59:35 2019 +0300
glusterd-volgen.c: skip fetching skip-CLIOT in a loop.
Its value is not going to change within the loop, as far as I can
understand the code.
Fetch and store it outside the loop.
Change-Id: I6327c23212dceec6006349421ef185495892dd8a
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 1d2a8260c3b396ca7234869160941fb0a0437fb7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Apr 3 08:27:05 2019 +0530
glusterd: remove redundant glusterd_check_volume_exists () calls
A pattern of following was found in multiple places where both
glusterd_check_volume_exists and glusterd_volinfo_find do the same job.
We just need one of them not both. In a scaled environment having many
volumes this is a bottleneck to iterate over the volume list to find a
volume twice!
exists = glusterd_check_volume_exists(volname);
ret = glusterd_volinfo_find(volname, &volinfo);
if ((ret) || (!exists)) {
Credits: ykaul@redhat.com for finding this out
Updates: bz#1193929
Change-Id: Ie116fe5c93e261a2bddd267c28ccb20a2884a36f
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit d8a0c14b196bcf11cafda4b04d5c3f66b03f50da
Author: rishubhjain <rishubhjain47@gmail.com>
Date: Sat Mar 30 15:46:38 2019 +0530
GlusterD: Resolves the issue of referencing memory after it has been freed
Setting the pointer to NULL after GF_FREE() and checking the pointer value
before calling GF_FREE() to avoid referencing memory after its has been freed
CID: 1398622
Change-Id: Iba0d8879abccf5923a69132a207d53bb94551417
updates: bz#789278
Signed-off-by: rishubhjain <rishubhjain47@gmail.com>
commit 3ebe33ab2f3d58d9aec7b5567fccf95bbdfd33f1
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Mar 25 15:56:56 2019 +0530
cluster/dht: refactor dht lookup functions
Part 1: refactor the dht_lookup_dir_cbk
and dht_selfheal_directory functions.
Added a simple dht selfheal directory test
Change-Id: I1410c26359e3c14b396adbe751937a52bd2fcff9
updates: bz#1590385
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit b9298fa32d980d326e5ab719d91d331aace36b29
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Apr 4 12:23:11 2019 +0530
cluster/afr: Invalidate inode on change of split-brain-choice
When split-brain choice is changed from one brick to another
brick, inode-invalidate is not called so readv call is served
from cache leading to failures in split-brain-resolution.t.
Fixed it by calling inode_invaldate() when this happens.
updates bz#1193929
Change-Id: I2624614eec38c0303f3e1dc55dfae3d4b864218b
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 45016ec663503b678ef64d968e6d26c05aebceb5
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Apr 2 16:21:51 2019 -0400
tests/bitrot: enable self-heal daemon before accessing the files
For testing the recovery of bad (or corrupted files) in a dispersed
volume, first enable self-heal daemon and let heal happen.
In bitrot feature, if a file becomes corrupted, the solution recommended
is to remove that file directly from the backend and then allowing heal
to happen. Hence turn on self-heal daemon and allow the heal to happen
after removing corrupted copy from the backend.
Change-Id: I7186110398ec1aee7e5727b9d1aac9a01db4d831
fixes: bz#1695327
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit dbbc48cf8b1c1ddcba5122a7fd99d5d0b37e4052
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Mar 18 12:54:54 2019 +0530
cluster/ec: Fix handling of heal info cases without locks
When we use heal info command, it takes lot of time as in
some cases it takes lock on entries to find out if the
entry actually needs heal or not.
There are some cases where we can avoid these locks and
can conclude if the entry needs heal or not.
1 - We do a lookup (without lock) on an entry, which we found in
.glusterfs/indices/xattrop, and find that lock count is
zero. Now if the file contains dirty bit set on all or any
brick, we can say that this entry needs heal.
2 - If the lock count is one and dirty is greater than 1,
then it also means that some fop had left the dirty bit set
which made the dirty count of current fop (which has taken lock)
more than one. At this point also we can definitely say that
this entry needs heal.
This patch is modifying code to take into consideration above two
points.
It is also changing code to not to call ec_heal_inspect if ec_heal_do
was called from client side heal. Client side heal triggeres heal
only when it is sure that it requires heal.
[We have changed the code to not to call heal for lookup]
updates bz#1689799
Change-Id: I7f09f0ecd12f65a353297aefd57026fd2bebdf9c
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit e889a189922b00f3c9bcc0a8ec62b3c8c08618aa
Author: Anuradha Talur <atalur@commvault.com>
Date: Thu Oct 25 17:23:10 2018 -0400
libglusterfs: define macros needed for cloudsync
Change-Id: Iec5ce7f17fbf899f881a58cd20c4c967e3b71668
fixes: bz#1642168
Signed-off-by: Anuradha Talur <atalur@commvault.com>
commit 6296271d8457cc8108395ba989cfb1734d902910
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Mar 28 22:07:34 2019 +0530
sdfs: enable pass-through
we have 'sdfs-sanity.t' which covers at least 90% of the functions
and 70% of lines in the translator. But the recent changes to
disable it due to performance impact made even the test to not
consider the translator.
updates: bz#1693692
Change-Id: I0ebcb307c4ab48a6e59ded27bf39f72ce2304ebc
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit f0d2a71b90e9f628d59804782ecfb78b77af0644
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Mar 28 09:36:33 2019 -0400
rpclib: slow floating point math and libm
In release-6 rpc/rpc-lib (libgfrpc) added the function
get_rightmost_set_bit() which calls log2(3), a call that takes
a floating point parameter.
It's used thusly:
right_most_unset_bit = get_rightmost_set_bit(...);
(So is it really the right-most unset bit, or the right-most set bit?)
It's unclear to me whether this is in the data path or not. If it is,
it's rather scary to think about integer-to-float conversions and slow
calls to libm functions in the data path.
gcc and clang have __builtin_ctz() which returns the same result as
get_rightmost_set_bit(), and does it substantially faster. Approx
20M iterations of get_rightmost_set_bit() took ~33sec of wall clock
time on my devel machine, while 20M iterations of __builtin_ctz()
took < 9sec; get_rightmost_set_bit() is 3x slower than __builtin_ctz().
And as a side benefit, we can again eliminate the need to link libgfrpc
with libm.
Change-Id: If9e7e80874577c52223f8125b385fc930de20699
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 47071fbba1046b74d3e8822ba39d711547014f73
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Mar 20 18:10:57 2019 +0200
changelog: remove unused code.
Seems to be unused.
Change-Id: I75eed9641dd030a1fbb1b942a9d818f10a7e1437
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 8bd775f86fded9133a1578329e7a87ee55b258ad
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Apr 1 09:55:54 2019 +0530
posix-acl: remove default functions, and use library fn instead
this works as a better solution, as we reuse more functions from library.
Also just do write/read on a file when acl is enabled, so we can see
improvement in code coverage.
updates: bz#1693692
Change-Id: If3359260c8ec2cf4fcf148fb4b95fdecc922c252
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit e22eb50f429e910c5c55db6d4c589443a30d8411
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Mar 22 10:40:45 2019 +0530
transport/socket: log shutdown msg occasionally
Change-Id: If3fc0884e7e2f45de2d278b98693b7a473220a5f
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1691616
commit 1e04bd4904e41e4410167588dea993e8089bf605
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Apr 1 11:53:57 2019 +0530
cluster/afr: Send inodelk/entrylk with non-zero lk-owner
Found missing assignment of lk-owner for an inodelk/entrylk before winding
the fops. locks xlator at the moment allows this operation. This leads to
multiple threads in the same client being able to get locks on the inode
because lk-owner is same and transport is same. So isolation with locks can't
be achieved. To fix it, we need locks xlator change which will disallow
null-lk-owner based inodelk/entrylk/lk. To achieve that we need to first
fix all the places which do this mistake.
updates bz#1624701
Change-Id: Ic3431da3f451a1414f1f4fdcfc4cf41e555f69dd
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit a8a7a877b4be1625db6cf953efb32f5dc7543040
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 2 10:45:15 2019 +0530
logging: Fix GF_LOG_OCCASSIONALLY API
GF_LOG_OCCASSIONALLY doesn't log on the first instance rather at every
42nd iterations which isn't effective as in some cases we might not have
the code flow hitting the same log for as many as 42 times and we'd end
up suppressing the log.
Fixes: bz#1694925
Change-Id: Iee293281d25a652b64df111d59b13de4efce06fa
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 75c092e28a3759f81228e28fd25a1c3ea81bba37
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Mar 29 00:05:47 2019 +0530
tests: add statedump to playground
It helps in increased code coverage of playground.
updates: bz#1693692
Change-Id: I81bcf30be1450948a6360d8915f06b973387a560
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 22d0dda951eee9fe98c9068e457d2112a03465b5
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Feb 25 10:05:32 2019 +0530
mgmt/shd: Implement multiplexing in self heal daemon
Problem:
Shd daemon is per node, which means they create a graph
with all volumes on it. While this is a great for utilizing
resources, it is so good in terms of performance and managebility.
Because self-heal daemons doesn't have capability to automatically
reconfigure their graphs. So each time when any configurations
changes happens to the volumes(replicate/disperse), we need to restart
shd to bring the changes into the graph.
Because of this all on going heal for all other volumes has to be
stopped in the middle, and need to restart all over again.
Solution:
This changes makes shd as a per volume daemon, so that the graph
will be generated for each volumes.
When we want to start/reconfigure shd for a volume, we first search
for an existing shd running on the node, if there is none, we will
start a new process. If already a daemon is running for shd, then
we will simply detach a graph for a volume and reatach the updated
graph for the volume. This won't touch any of the on going operations
for any other volumes on the shd daemon.
Example of an shd graph when it is per volume
graph
-----------------------
| debug-iostat |
-----------------------
/ | \
/ | \
--------- --------- ----------
| AFR-1 | | AFR-2 | | AFR-3 |
-------- --------- ----------
A running shd daemon with 3 volumes will be like-->
graph
-----------------------
| debug-iostat |
-----------------------
/ | \
/ | \
------------ ------------ ------------
| volume-1 | | volume-2 | | volume-3 |
------------ ------------ ------------
Change-Id: Idcb2698be3eeb95beaac47125565c93370afbd99
fixes: bz#1659708
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 5c2666ee31be4af13b426973dba2bd0a9aac32dc
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 28 17:55:54 2019 +0530
protocol/client: Do not fallback to anon-fd if fd is not open
If an open comes on a file when a brick is down and after the brick comes up,
a fop comes on the fd, client xlator would still wind the fop on anon-fd
leading to wrong behavior of the fops in some cases.
Example:
If lk fop is issued on the fd just after the brick is up in the scenario above,
lk fop will be sent on anon-fd instead of failing it on that client xlator.
This lock will never be freed upon close of the fd as flush on anon-fd is
invalid and is not wound below server xlator.
As a fix, failing the fop unless the fd has FALLBACK_TO_ANON_FD flag.
Change-Id: I77692d056660b2858e323bdabdfe0a381807cccc
fixes bz#1390914
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 26f3eec38b628457a0e354ae4070dc7a512c8f9c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Mar 7 17:02:36 2019 +0530
afr: thin-arbiter read txn fixes
- Fixes afr_ta_read_txn() to handle inode refresh failures.
code-path.
- Fixes a double free issue of dict.
Note: This patch address post-merge review comments for commit
69532c141be160b3fea03c1579ae4ac13018dcdf
fixes: bz#1686398
Change-Id: Id5299b45b68569d47df6b73755918237a1592cb4
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 4f8af7f3a6aae5cb4d3173f023d73b903a4e966d
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Mar 13 08:51:31 2019 +0530
mount.glusterfs: change the error message
In scenarios where a mount fails before creating log file, doesn't
make sense to give message to 'check log file'. See below:
```
ERROR: failed to create logfile "/var/log/glusterfs/mnt.log" (No space left on device)
ERROR: failed to open logfile /var/log/glusterfs/mnt.log
Mount failed. Please check the log file for more details.
```
Fixes: bz#1688068
Change-Id: I1d837caa4f9bc9f1a37780783e95007e01ae4e3f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit dbba52d8583e091d32789a78af164d9759ef9660
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Mar 28 14:59:00 2019 +0530
gfapi: Unblock epoll thread for upcall processing
With commit#ad35193,we have made changes to offload
processing upcall notifications to synctask so as not
to block epoll threads. However seems like the issue wasnt
fully addressed.
In "glfs_cbk_upcall_data" -> "synctask_new1" after creating synctask
if there is no callback defined, the thread waits on synctask_join
till the syncfn is finished. So that way even with those changes,
epoll threads are blocked till the upcalls are processed.
Hence the right fix now is to define a callback function for that
synctask "glfs_cbk_upcall_syncop" so as to unblock epoll/notify threads
completely and the upcall processing can happen in parallel by synctask
threads.
Change-Id: I4d8645e3588fab2c3ca534e0112773aaab68a5dd
fixes: bz#1693575
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 871a023fc9b3bd0b9211b7127721b9f0ba951a27
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Mar 28 07:17:16 2019 -0400
geo-rep: Fix syncing multiple rename of symlink
Problem:
Geo-rep fails to sync rename of symlink if it's
renamed multiple times if creation and rename
happened successively
Worker crash at slave:
Traceback (most recent call last):
File "/usr/libexec/glusterfs/python/syncdaemon/repce.py", in worker
res = getattr(self.obj, rmeth)(*in_data[2:])
File "/usr/libexec/glusterfs/python/syncdaemon/resource.py", in entry_ops
[ESTALE, EINVAL, EBUSY])
File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", in errno_wrap
return call(*arg)
File "/usr/libexec/glusterfs/python/syncdaemon/libcxattr.py", in lsetxattr
cls.raise_oserr()
File "/usr/libexec/glusterfs/python/syncdaemon/libcxattr.py", in raise_oserr
raise OSError(errn, os.strerror(errn))
OSError: [Errno 12] Cannot allocate memory
Geo-rep Behaviour:
1. SYMLINK doesn't record target path in changelog.
So while syncing SYMLINK, readlink is done on
master to get target path.
2. Geo-rep will create destination if source is not
present while syncing RENAME. Hence while syncing
RENAME of SYMLINK, target path is collected from
destination.
Cause:
If symlink is created and renamed multiple times, creation of
symlink is ignored, as it's no longer present on master at
that path. While symlink is renamed multiple times at master,
when syncing first RENAME of SYMLINK, both source and destination
is not present, hence target path is not known. In this case,
while creating destination directly at slave, regular file
attributes were encoded into blob instead of symlink,
causing failure in gfid-access translator while decoding
blob.
Solution:
While syncing of RENAME of SYMLINK, when target is not known
and when src and destination is not present on the master,
don't create destination. Ignore the rename. It's ok to ignore.
If it's unliked, it's fine. If it's renamed to something else,
it will be synced then.
Change-Id: Ibdfa495513b7c05b5370ab0b89c69a6802338d87
fixes: bz#1693648
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 7d85b4d81e9d5e130cf1837768b654afcdea27db
Author: Poornima G <pgurusid@redhat.com>
Date: Sun Mar 24 09:40:50 2019 +0530
client-rpc: Fix the payload being sent on the wire
The fops allocate 3 kind of payload(buffer) in the client xlator:
- fop payload, this is the buffer allocated by the write and put fop
- rsphdr paylod, this is the buffer required by the reply cbk of
some fops like lookup, readdir.
- rsp_paylod, this is the buffer required by the reply cbk of fops like
readv etc.
Currently, in the lookup and readdir fop the rsphdr is sent as payload,
hence the allocated rsphdr buffer is also sent on the wire, increasing
the bandwidth consumption on the wire.
With this patch, the issue is fixed.
Fixes: bz#1692093
Change-Id: Ie8158921f4db319e60ad5f52d851fa5c9d4a269b
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 699c5801120dd2630b245dd3912e40590e26cbfa
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 28 11:03:34 2019 +0530
rpc: Remove duplicate code
rpc_clnt_disable() and rpc_clnt_disconnect() have same code.
Removed rpc_clnt_disconnect() and moved calls to rpc_clnt_disconnect()
to rpc_clnt_disable()
updates bz#1193929
Change-Id: I965f57cc1d5af36d266810125558b6f5e5f279d4
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit cc1a85b612809e9c8785f596c6631f8480aba0fc
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Tue Mar 26 10:08:00 2019 +0800
glusterd: fix potential locking issue on peer probe
There are two cases to restart brick, one is when glusterd starts or
quorum is met, another is when new peers are joined and quorum is
changes. In the later case, sync_lock is not taken, and may cause lock
corruption.
Change-Id: I0844e7a631350f5ee00bdacb613602bffffcdf9f
fixes: bz#1692612
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit e541b59df35fa1478b1c25802b170228b5d3018a
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Mar 26 13:20:13 2019 +0530
geo-rep: fix integer config validation
ssh-port validation is mentioned as `validation=int` in template
`gsyncd.conf`, but not handled this during geo-rep config set.
Fixes: bz#1692666
Change-Id: I3f19d9b471b0a3327e4d094dfbefcc58ed2c34f6
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit aeed4dd068ad8ac878f08dab5cf54bc245347393
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Nov 28 11:22:52 2018 +0530
cluster/ec: Don't enqueue an entry if it is already healing
Problem:
1 - heal-wait-qlength is by default 128. If shd is disabled
and we need to heal files, client side heal is needed.
If we access these files that will trigger the heal.
However, it has been observed that a file will be enqueued
multiple times in the heal wait queue, which in turn causes
queue to be filled and prevent other files to be enqueued.
2 - While a file is going through healing and a write fop from
mount comes on that file, it sends write on all the bricks including
healing one. At the end it updates version and size on all the
bricks. However, it does not unset dirty flag on all the bricks,
even if this write fop was successful on all the bricks.
After healing completion this dirty flag remain set and never
gets cleaned up if SHD is disabled.
Solution:
1 - If an entry is already in queue or going through heal process,
don't enqueue next client side request to heal the same file.
2 - Unset dirty on all the bricks at the end if fop has succeeded on
all the bricks even if some of the bricks are going through heal.
Change-Id: Ia61ffe230c6502ce6cb934425d55e2f40dd1a727
updates: bz#1593224
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 669bc7c6a3708f90894ce94b219a0939adf4fd3c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Mar 15 19:31:03 2019 +0530
afr: add client-pid to all gf_event() calls
client-pid for glustershd is GF_CLIENT_PID_SELF_HEALD
client-pid for glfsheal is GF_CLIENT_PID_GLFS_HEALD
updates: bz#1689250
Change-Id: Ib3a863af160ff48c822a5e6b0c27c575c9887470
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit e8c7592fed04e8d7a3777a547a31369b7dd0e78b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Mar 14 18:41:11 2019 +0530
gfapi: add function to set client-pid
This api offers the ability to set the pid of a client to a particular
value, identical to how gluster fuse clients provide the --client-pid
option. This is an internal API to be used by gluster processes only. See
https://lists.gluster.org/pipermail/gluster-devel/2019-March/055925.html
for more details. Currently glfsheal is the only proposed consumer.
updates: bz#1689250
Change-Id: I0620be2127d79d69cdd57cffb29bba44e6e5da1f
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 3a401817784e5874c8d88906c863b1468da483a4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Mar 21 01:21:13 2019 -0400
build: link libgfrpc with MATH_LIB (libm, -lm)
tl;dnr: libgfrpc.so calls log2(3) from libm; it should be explicitly
linked with -lm
the autoconf/automake/libtool stack is more or less forgiving on
different distributions. On forgiving systems libtool will semi-
magically link with implicit dependencies. But on Ubuntu, which
seems to be tending toward being less forgiving, the link of libgfrpc
will fail with an unresolved referencee to log2(3).
Change-Id: I9fae09ddb81e49004fbea4d7d83b95fb64a484b0
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit df0274fdeeb03271151ada845a7604f450815a8b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Mar 21 19:51:30 2019 +0200
mem-pool: remove dead code.
Change-Id: I3bbda719027b45e1289db2e6a718627141bcbdc8
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 8caea28e66504be5985b6b074cc00e0d3789b318
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 25 14:06:25 2019 +0530
cluster/afr: Remove un-used variables related to pump
updates bz#1193929
Change-Id: I01b60d644f517c00a1bcc127bf9a8ed90b6eb7a0
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 6a4d57304e59b7b223899b6062356ac0f7163de0
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Mar 18 16:08:04 2019 +0530
glusterd: fix txn-id mem leak
This commit ensures the following:
1. Don't send commit op request to the remote nodes when gluster v
status all is executed as for the status all transaction the local
commit gets the name of the volumes and remote commit ops are
technically a no-op. So no need for additional rpc requests.
2. In op state machine flow, if the transaction is in staged state and
op_info.skip_locking is true, then no need to set the txn id in the
priv->glusterd_txn_opinfo dictionary which never gets freed.
Fixes: bz#1691164
Change-Id: Ib6a9300ea29633f501abac2ba53fb72ff648c822
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 26f0e551ca65065808ad066d5a28823d058cb79b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Mar 19 16:45:06 2019 +0200
Multiple files: remove HAVE_BD_XLATOR related code.
The BD translator was removed some time ago,
(in commit a907e468e724c32b9833ce59806fc215c7122d63).
This completes the work.
Compile-tested only!
updates: bz#1635688
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I999df52e479a72d3cc9523f22f9056de17eb559c
commit f312c2c5d11800559c7c38006b0dfb4750173843
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Mar 21 09:57:10 2019 +0530
inode: fix unused vars
Commit 6d6a3b2 introduced some unused vars. This patch defines them
within #ifdef DEBUG
Fixes: bz#1580315
Change-Id: I8a332b00c3ffb66689b4b6480c490b9436c17d63
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit f3406d599f36d48ca8cfc30988c6b325be797eab
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Mar 19 22:51:14 2019 +0530
fuse : fix high sev coverity issue
This patch fixed coverity issue in fuse-bridge.c.
CID : 1398630 : Resource leak
CID : 1399757 : Uninitialized pointer read
updates: bz#789278
Change-Id: I69f8591400ee56a5d215eeac443a8e3d7777db27
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit d35736d9badaecad7d3ce8afea4c92f98b55061a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Mar 20 13:05:44 2019 +0200
server.c: fix Coverity CID 1399758
1399758 Dereference before null check
It was introduced @ commit 67f48bfcc16a38052e6c9ae7c25e69b03b8ae008
updates: bz#789278
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I1424b008b240691fe2a8924e31c708d0fb4f362d
commit c1b3de38ef67678a136868584a4221ca3d0f1a09
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Feb 26 18:04:18 2019 +0530
rpc/transport: Missing a ref on dict while creating transport object
while creating rpc_tranpsort object, we store a dictionary without
taking a ref on dict but it does an unref during the cleaning of the
transport object.
So the rpc layer expect the caller to take a ref on the dictionary
before passing dict to rpc layer. This leads to a lot of confusion
across the code base and leads to ref leaks.
Semantically, this is not correct. It is the rpc layer responsibility
to take a ref when storing it, and free during the cleanup.
I'm listing down the total issues or leaks across the code base because
of this confusion. These issues are currently present in the upstream
master.
1) changelog_rpc_client_init
2) quota_enforcer_init
3) rpcsvc_create_listeners : when there are two transport, like tcp,rdma.
4) quotad_aggregator_init
5) glusterd: init
6) nfs3_init_state
7) server: init
8) client:init
This patch does the cleanup according to the semantics.
Change-Id: I46373af9630373eb375ee6de0e6f2bbe2a677425
updates: bz#1659708
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit bd7f1b9d74b2d7b5792fdc056f953656e6da1a67
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Mar 13 09:42:33 2019 +0530
inode: don't dump the whole table to CLI
dumping the whole inode table detail to screen doesn't solve any
purpose. We should be getting only toplevel details on CLI, and then
if one wants to debug further, then they need to get to 'statedump'
to get full details.
Fixes: bz#1580315
Change-Id: Iaf3de94602f9c76832c3c918ffe2ad13c0b0e448
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 91cbcd17e4cb5745c141948a01eaf918a5f75505
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Mar 18 11:16:49 2019 +0200
glusterd-locks: misc. changes.
Move to use dict_*n() functions, where it made sense.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ie9c4b2021d2229ea9a815cc75e9eb8c3945c109e
commit f9b91b6b60c46b687b5ce31335923181352f85af
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Mar 14 10:55:52 2019 +0530
socket/ssl: fix crl handling
Problem:
Just setting the path to the CRL directory in socket_init() wasn't working.
Solution:
Need to use special API to retrieve and set X509_VERIFY_PARAM and set
the CRL checking flags explicitly.
Also, setting the CRL checking flags is a big pain, since the connection
is declared as failed if any CRL isn't found in the designated file or
directory. A comment has been added to the code appropriately.
Change-Id: I8a8ed2ddaf4b5eb974387d2f7b1a85c1ca39fe79
fixes: bz#1687326
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 8e8f9e4d653776342ffc3f41ef477190fc8608ac
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Mon Mar 18 20:47:54 2019 +0800
cluster-syncop: avoid duplicate unlock of inodelk/entrylk
When using ec, there are many messages at brick log as,
[inodelk.c:514:__inode_unlock_lock] 0-test-locks: Matching lock not found for unlock 0-9223372036854775807, lo=68e040a84b7f0000 on 0x7f208c006f78
[MSGID: 115053] [server-rpc-fops_v2.c:280:server4_inodelk_cbk] 0-test-server: 2557439: INODELK <gfid:df4e41be-723f-4289-b7af-b4272b3e880c> (df4e41be-723f-4289-b7af-b4272b3e880c), client: CTX_ID:67d4a7f3-605a-4965-89a5-31309d62d1fa-GRAPH_ID:0-PID:1659-HOST:openfs-node2-PC_NAME:test-client-1-RECON_NO:-28, error-xlator: test-locks [Invalid argument]
Change-Id: Ib164d29ebb071f620a4ca9679c4345ef7c88512a
Updates: bz#1689920
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 326b0db89e3085235dbfd6a59fbcd21ed9f8a858
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Feb 26 14:27:33 2019 +0530
mount/fuse: Fix spelling mistake
updates bz#1193929
Change-Id: I55ffa8f086ad9570f2526d91c196d7de9ffe6add
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 9f3a5993d4b8fec0ea04a6a01b4cbf7884f12c36
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Mar 14 20:06:54 2019 +0530
geo-rep: IPv6 support
`address_family=inet6` needs to be added while mounting master and
slave volumes in gverify script.
New option introduced to gluster cli(`--inet6`) which will be used
internally by geo-rep while calling `gluster volume info
--remote-host=<ipv6>`.
Fixes: bz#1688833
Change-Id: I1e0d42cae07158df043e64a2f991882d8c897837
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 89fcf2831fa7cfb57fa512f8a3d18c45551d6119
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Wed Mar 13 21:13:38 2019 +0800
shard: fix crash caused by using null inode
Change-Id: I156bf962223304e586b83a36be59a0ca74589b43
Updates: bz#1688287
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 7a32de6f888572ff133467589f2397ce57284ebe
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Mar 8 10:42:12 2019 +0530
cluster/afr : TA: Return actual error code in case of failure
In afr_ta_post_op_do, we were sending EIO for every failure.
However, the original error code should be sent.
Change-Id: I9fdc15dac00d758baf8e6f14db244f526481a63a
updates: bz#1686711
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 0fefd85cd1ed5840620b9fb06c0309256f8fc86e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 11 14:04:39 2019 +0530
storage/posix: Remove nr_files usage
nr_files is supposed to represent the number of files opened in posix.
Present logic doesn't seem to handle anon-fds because of which the
counts would always be wrong.
I don't remember anyone using this value in debugging any problem probably
because we always have 'ls -l /proc/<pid>/fd' which not only prints the
fds that are active but also prints their paths. It also handles directories
and anon-fds which actually opened the file. So removing this code
instead of fixing the buggy logic to have the nr_files.
fixes bz#1688106
Change-Id: Ibf8713fdfdc1ef094e08e6818152637206a54040
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 5054d2f818f0da274d1b6a51e85e38e6a592c0ff
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Mar 13 12:56:58 2019 +0530
tests/bug-844688.t: test bug-844688.t is failing on master
Test case bug-844688.t is failing quite frequently on master.
This test check for the existence of call_stack, frame creation
time.
But there is a chance that at a point in time, the stack count
might become zero. So doing the check in EXPECT_WITHIN make
more sense.
Change-Id: Id2ede7f6fdcb5f016f52c5c0557ce6ac510d4e96
updates: bz#1688116
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 086b511506b31f3e4fedc4517e20a08f966dcd42
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Mar 12 13:27:34 2019 +0530
glusterfsd: Brick is getting crash at the time of startup
Problem: Brick is getting crash because graph was not activated
at the time of accessing server_conf
Solution: To avoid the crash check ctx->active before processing
a request
Change-Id: Ib112e0eace19189e45f430abdac5511c026bed47
fixes: bz#1687705
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 1a7731a9016f45113baaa1a1b2c378d6c356adce
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Mar 13 13:05:59 2019 +0530
test: Fix a missing a '$' symbol
While checking a test case using EXPECT_WITHIN, the
argument is actually missing a '$' symbol to denote
the token as a variable in bash
Change-Id: I5b9150acdea000b29e94cfb01d975c77f5ece3e5
fixes: bz#1688116
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit bad519e8cfce19c5fc3a686bb44102c63590505c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Mar 12 18:00:37 2019 +0530
dht: NULL check before setting error flag
Function dht_common_mark_mdsxattr blindly setting value for
an integer pointer without validating it. In fact there are
two callers of this function that passes NULL value to the
same pointer which leads to a crash.
Change-Id: Id94ffe216f6a21f007b3291bff0b1e1c1989075c
fixes: bz#1687811
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit e503a21814830ec91dfbcd5e685f622999922dfc
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri Mar 1 13:41:24 2019 +0530
glusterfsd: Multiple shd processes are spawned on brick_mux environment
Problem: Multiple shd processes are spawned while starting volumes
in the loop on brick_mux environment.glusterd spawn a process
based on a pidfile and shd daemon is taking some time to
update pid in pidfile due to that glusterd is not able to
get shd pid
Solution: Commit cd249f4cb783f8d79e79468c455732669e835a4f changed
the code to update pidfile in parent for any gluster daemon
after getting the status of forking child in parent.To resolve
the same correct the condition update pidfile in parent only
for glusterd and for rest of the daemon pidfile is updated in
child
Change-Id: Ifd14797fa949562594a285ec82d58384ad717e81
fixes: bz#1684404
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit e345e963ab5f7e95a7c5c2b481f3f873c5774b0b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Feb 27 22:05:51 2019 +0200
io-threads.c: Potentially skip a lock.
Before going into the lock, verify stub_cnt != 0.
Otherwise, let's skip this code.
Unrelated, switch a CALLOC to MALLOC, as we
initialize all members right away. This allocation
is done also under lock, so also should help a bit.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ie2fe6adff41ae4969abff95eff945b54e1a01d32
commit 3cbffdbab681dd13bd881f9221a1eadf7b8d9615
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Mar 7 22:26:49 2019 +0530
cluster/afr: Send truncate on arbiter brick from SHD
Problem:
In an arbiter volume configuration SHD will not send any writes onto the arbiter
brick even if there is data pending marker for the arbiter brick. If we have a
arbiter setup on the geo-rep master and there are data pending markers for the files
on arbiter brick, SHD will not mark any data changelog during healing. While syncing
the data from master to slave, if the arbiter-brick is considered as ACTIVE, then
there is a chance that slave will miss out some data. If the arbiter brick is being
newly added or replaced there is a chance of slave missing all the data during sync.
Fix:
If there is data pending marker for the arbiter brick, send truncate on the arbiter
brick during heal, so that it will record truncate as the data transaction in changelog.
Change-Id: I3242ba6cea6da495c418ef860d9c3359c5459dec
fixes: bz#1686568
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 59c68b73b8974d5e2ae9a899d46da0569e20cfae
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Mar 8 11:12:29 2019 +0530
glusterd: change the op-version
as commit 073444 is backported to release-5.4 branch, op-version
for this change should 5.4 instead of 6.
fixes: bz#1685120
Change-Id: Id504b9a1446125cea7c6a32117ccc44f28e73aa7
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit afe6cd21a6549aa088bbb85ac2391a2f2e647835
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Jan 30 14:24:14 2019 +0530
rpm: add thin-arbiter package
Discussion on thin arbiter volume -
https://github.com/gluster/glusterfs/issues/352#issuecomment-350981148
Main idea of having this rpm package is to deploy thin-arbiter
without glusterd and other commands on a node, and all we need
on that tie-breaker node is to run a single glusterfs command.
Also note that, no other glusterfs installation needs
thin-arbiter.so.
Make sure RPM contains sample vol file, which can work by default,
and a script to configure that volfile, along with translator image.
Change-Id: Ibace758373d8a991b6a19b2ecc60c93b2f8fc489
updates: bz#1674389
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 6efbe15aa4fdf132b319ba06a734b2be68cf6b17
Author: Michael Scherer <misc@redhat.com>
Date: Thu Mar 7 11:58:23 2019 +0100
Remove Nigel as requested by him
Change-Id: I0be4038790b56f67d75a61bb8b346d9b4e0d8cce
updates: bz#1686371
Signed-off-by: Michael Scherer <misc@redhat.com>
commit 82f06e94cb32a18592ec36ea5221331532dd97fe
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Mar 5 08:39:16 2019 +0530
dict: handle STR_OLD data type in xdr conversions
Currently a dict conversion on wire for 3.x protocol happens using
`dict_unserialize()`, which sets the type of data as STR_OLD. But the
new protocol doesn't send it over the wire as its not considered as a
valid format in new processes.
But considering we deal with old and new protocol when we do a rolling
upgrade, it will allow us to get all the information properly with new
protocol.
Credits: Krutika Dhananjay
Fixes: bz#1684385
Change-Id: I165c0021fb195b399790b9cf14a7416ae75ec84f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 842a95f780ce25cdc779c9314e910c91dd4ff016
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Mar 7 08:00:47 2019 -0500
packaging: remove unnecessary ldconfig in scriptlets
see https://src.fedoraproject.org/rpms/glusterfs/pull-request/5
Reported-By: Igor Gnatenko
Change-Id: I914f36290e96a387cdd64ee633e75c2940ec1e56
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 2a9426c13b8c99c0b01b9a7ef17ff9bea6305877
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Feb 21 16:17:44 2019 +0530
cluster/afr: Add quorum checks to open & opendir fops
Problem:
Currently even if open & opendir fails on quorum number of bricks,
but succeeds on atleast one brick, it will result in success. This leads
to inconsistency in the behaviour with other operations following the
open, which has quorum checks.
Fix:
Add quorum checks to open & opendir fops to avoid inconsistency.
Change-Id: If8fcb82072a6dc45ea6d4a6754b79763215eba2a
fixes: bz#1634664
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 4ba8028669f239f64c6b958b538f89556fd6c47d
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Thu Mar 7 16:35:33 2019 +0530
performance/readdir-ahead: fix deadlock
This deadlock happens while processing dentry corresponding to current
directory (.) in rda_fill_readdirp. In this case following order is
followed:
LOCK(directory_fd_ctx->lock);
rda_inode_ctx_get_iatt -> LOCK(directory_inode->lock);
However, in rda_mark_inode_dirty following lock order is followed:
LOCK(directory_inode->lock);
LOCK(directory_fd_ctx->lock);
these two codepaths when executed concurrently resulted in a deadlock.
Current patch fixes this by removing locking directory inode and
fd-ctx in rda_fill_readdirp. This is fine as directory inode's stat
won't change due to writes to files within directory.
Change-Id: Ic93a67a0dac8229bb0d79582e526a512e6f2569c
fixes: bz#1674412
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
Fixes:bz#1674412
commit d961a459ce582dc30c22e2a7520b79ada7049157
Author: David Spisla <david.spisla@iternity.com>
Date: Wed Mar 6 12:21:18 2019 +0100
WORM-Xlator: Maybe integer overflow when computing new atime
The structs worm_reten_state_t and read_only_priv_t from read-only.h are
using uint64_t values to store periods of retention and autocommmit.
This seems to be dangerous since in worm-helper.c the function
worm_set_state computes in line 97:
stbuf->ia_atime = time(NULL) + retention_state->ret_period;
stbuf->ia_atime is using int64_t because of the settings of struct
iattr. So if there is a very very high retention period stored, there
is maybe an integer overflow.
What can be the solution? Using int64_t instead if uint64_t may reduce
the probability of the occurance.
Change-Id: Id1e86c6b20edd53f171c4cfcb528804ba7881f65
fixes: bz#1685944
Signed-off-by: David Spisla <david.spisla@iternity.com>
commit 41efbe776a4d3e72566937b41f3e65319c11bc71
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Mar 4 10:11:15 2019 -0500
packaging: s390x has RDMA support
Since around fedora27, and in RHEL7 since July 2016.
Reported-By: Dan Horák <dan@danny.cz>
Change-Id: Idad29425495f9c69bfd84b53b009a607abb418f0
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit c056e87dd4a38fccbc12de62da24096ce2cf69a1
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Mar 4 16:53:01 2019 +0530
core: make compute_cksum function op_version compatible
Problem: commit 5a152a changed the mechansim of computing the
checksum. In heterogeneous cluster, peers are running into
rejected state because we have different cksum computation
mechansims in upgraded and non-upgraded nodes.
Solution: add a check for op-version so that all the nodes
in the cluster follow the same mechanism for computing the
cksum.
Change-Id: I1508f000e8c9895588b6011b8b6cc0eda7102193
fixes: bz#1685120
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 6f04046dc5559eb1a7e530ec61119241e12fb05b
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Mar 4 13:39:18 2019 +0530
eventsapi: Fix error while handling GlusterCmdException
`GlusterCmdException` was wrongly accessed instead of accessing
`GlusterCmdException.message`.
Fixes: bz#1685027
Change-Id: I35ec1b05726050bfd8761e05ad9b9e47917dc0c6
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 95e661375694673fca3b7fda4418d25041cb8bf5
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Feb 27 23:15:58 2019 +0530
leases: Do not process internal fops
fops marked internal are used to maintain data integrity
and ideally do not intervene with application client leases.
Hence it seems safe to ignore them by lease xlator.
Change-Id: I887b6f2da7ec0081442cc4b572a7a9e110f79eb2
updates: bz#1648768
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 1cd54e926796324d7ba4e71683c0c99669c1b627
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Mar 5 13:39:46 2019 +0530
glusterd: glusterd memory leak while running "gluster v profile" in a loop
Problem: glusterd has memory leak while running "gluster v profile"
in a loop
Solution: Resolve leak code path to avoid leak
Change-Id: Id608703ff6d0ad34ed8f921a5d25544e24cfadcd
fixes: bz#1685414
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 7f46fe1246171fb6db212f3443c6f774bb57a1ca
Author: Susant Palai <spalai@redhat.com>
Date: Wed Feb 20 15:52:55 2019 +0530
io-threads: Prioritize fops with NO_ROOT_SQUASH pid
There was 30% regression observed in mkdir path with commit
b139bc58eb504adf5ef81658896c9283ae21f390. On analysis it is found
that io-threads xlator deprioritzes fops with all -ve pid.
Some context in to the no-root-squash pid requirement:
DHT xlator does some of the internal fops with root privileges. This is
needed so that operations like layout healing should not be abandoned
because a non root user is operating. If root-squash option is enabled
the layout set operation looses its root privilege as server xlator
converts the uid and pid to random numbers. Hence, the above mentioned
commit converted pid to GF_CLIENT_PID_NO_ROOT_SQUASH to continue fops
as root.
Combining the above I am proposing not to deprioritize fops with
no-root-squash pid.
Change-Id: I54d056c01b25729304a77f9242fbaff39c5672ba
fixes: bz#1676430
Signed-off-by: Susant Palai <spalai@redhat.com>
commit aec7a4c45f351b3f29c62831447814cdfefd445c
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Feb 27 22:44:10 2019 +0530
afr: mark changelog_fsync as internal
As afr_changelog_fsync is used for internal operations, use
GLUSTERFS_INTERNAL_FOP_KEY so that lease xlator can avoid treating
it as conflicting fop and recall lease.
Change-Id: I52cdc161002e840199d24439231a8bfa4f98b1b6
updates: bz#1648768
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit be324e2561eb2f63f1bc365a31ddb709facae218
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Thu Feb 14 10:49:58 2019 +0000
core: fix volume heal to avoid "invalid argument"
This patch avoids printing of "invalid argument" unless
loglevel is set to GF_LOG_DEBUG.
fixes : bz#1654021
Change-Id: I0e3d43bc627526f696b12921081342ca9b4a5f84
fixes: bz#1654021
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 0fae3511dc5c1b490e644464d88db0069d7c9dc9
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Feb 14 02:01:38 2019 +0100
fuse lock interrupt: fix flock_interrupt.t
updates: bz#1193929
Change-Id: I347de62755100cd69e3cf341434767ae23fd1ba4
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 30df535c731eb6cf96177cf55520b7d4fbc4371c
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Fri Jan 18 11:00:56 2019 +0800
quotad: fix passing GF_DATA_TYPE_STR_OLD dict data to v4 protocol
quotad prints many logs as,
[glusterfs3.h:752:dict_to_xdr] 0-dict: key 'trusted.glusterfs.quota.size' is not sent on wire [Invalid argument]
[glusterfs3.h:752:dict_to_xdr] 0-dict: key 'volume-uuid' is not sent on wire [Invalid argument]
For quota, there is a deamon named quotad which has a rpcsvc_program
quotad_aggregator_prog that only supports v3 right now.
Quotad has two actors (LOOKUP,GETLIMIT) that contains a dict in request,
quotad just decodes the dict by dict_unserialize, those dict dates's type
is GF_DATA_TYPE_STR_OLD, which type is not supported at glusterfs v4.
Change-Id: Ib649d7a2e3c68c32dc26bc0f88923a0ba967ebd7
Updates: bz#1596787
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit fea3e86c04aa188e89a73d4b65596d096b864bdf
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Feb 27 13:38:33 2019 -0800
mgmt/glusterd: Fix a memory leak when peer detach fails
Dictionary object is not being unref'd when an error happens
in __glusterd_handle_cli_deprobe(). This patch addresses that problem.
Change-Id: I11e1f92d06dc9edd1260845256f435ea31ef1a87
fixes: bz#1683816
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit cf48224a3a47a01d7b73db501cca73196c457cc3
Author: Arjun Sharma <arjsharm@redhat.com>
Date: Thu Feb 21 18:09:50 2019 +0530
Updating the glfs_setattr and glfs_fsetattr public APIs to use glfs_stat
Change-Id: I0e86c8222c88b4c71087ec287ba81f8353d70822
updates: #389
Signed-off-by: Arjun <arjsharm@redhat.com>
commit 22c4a95d167a904a452d9e811b274e1b30b0e6c0
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Feb 26 21:48:21 2019 +0530
glusterd: remove experimental xlator options from glusterd-volume-set.c
experimental xlators have been removed from the codebase. But we
missed to remove the options related to experimental xlators from
the codebase. This patch removes those options.
fixes: bz#1683352
Change-Id: I3fa7e14c6cd8ebde5cebc8d2b0cb2409bf37c1ae
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit d31a45b27e20f7f777a79a678355aa4cc3f21435
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Feb 25 12:32:21 2019 +0100
build: do not install service related files when building --without-server
It seems that glusterfs-6 disables building the server (./configure
--without-server) on el6 and hence the installed but unpackaged files
should not get installed in the first place.
Change-Id: I7bea08202dd59ac309de8bc861da920ed3600bc6
Fixes: bz#1680587
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 1f874f4220802335e351f3ef13d44013e7a13c62
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Feb 22 09:25:26 2019 -0500
glusterfind: revert shebangs to #!/usr/bin/python3
Using #!/usr/bin/env python is illegal in Fedora and RHEL packaging.
(Debian and SUSE packaging will complain about it too but don't
enforce it like Fedora packaging does. Yet.)
We went through a giant exercise fixing these once already.
The python needs to be python2/python3 clean. There is a build
scriptlet that converts the shebangs back to /usr/bin/python on rhel7.
Change-Id: If208a2557f7e5d727cda98c27905e249cf485d5b
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 658a84c5f453b642cc2adff073134b50cc32c888
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sat Feb 16 10:24:28 2019 +0200
leases-internal.c: minor reduction of work under lock.
Minor changes to reduce work done under a lock.
Changed few CALLOC() to MALLOC(), and moved some
time(NULL) outside the lock.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I4683d0d6e0b653a6adefff87b43ae717fd46843a
commit c502cd989e14b2e8bac0604cc0766ea037a54cbb
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Feb 21 11:25:55 2019 +0530
eventsapi: Fix Python3 compatibility issues
- Fixed Relative import and non-package import related issues.
- socketserver import issues fix
- Renamed installed directory name to `gfevents` from `events`(To
avoid any issues with other global libs)
Fixes: bz#1679406
Change-Id: I3dc38bc92b23387a6dfbcc0ab8283178235bf756
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 13389781888c7e27c7d6c1b6208e5f26d6b0fcf7
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Feb 20 14:49:24 2019 +0530
fuse : fix memory leak
This patch fixes memory leak reported by ASan.
Tracebacks:
ERROR: LeakSanitizer: detected memory leaks
Direct leak of 712 byte(s) in 1 object(s) allocated from:
#0 0x7f35139dc848 in __interceptor_malloc (/lib64/libasan.so.5+0xef848)
#1 0x7f35136efb29 in __gf_malloc ../libglusterfs/src/mem-pool.c:136
#2 0x7f3510591ce9 in fuse_thread_proc ../xlators/mount/fuse/src/fuse-bridge.c:5929
#3 0x7f351336d58d in start_thread (/lib64/libpthread.so.0+0x858d)
SUMMARY: AddressSanitizer: 712 byte(s) leaked in 1 allocation(s).
updates: bz#1633930
Change-Id: Ie5b4da6b338d8e5fc770c5b2da1238e3462468ac
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 160a2b997a9da1f9de49cd5b7aba1e7c22d3cfd4
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Feb 21 10:51:13 2019 +0530
geo-rep : fix incorrectly formatted authorized_keys
Problem : While Geo-rep setup when creating an ssh authorized_keys
the geo-rep setup inserts an extra space before the "ssh-rsa" label.
This gets flagged by an enterprise customer's security scan as a
security violation.
Solution: Remove extra space in GSYNCD_CMD & TAR_CMD.
Change-Id: I956f938faef0e0883703bbc337b1dc2770e4a921
fixes: bz#1679401
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 29cd2e760da3cf7299e8e978e388d9b262c370a8
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Feb 22 15:17:48 2019 +0100
build: include gluster/__init__.* files for python packaging
The gluster/__init__.py file was originaly part of the glupy
installation. This file is required to have the python-gluster package
function correctly, it is expected to provide the 'gluster' namespace
for other python packages (like from the libgfapi-python project).
Because glupy does not exist anymore, this file is now added to in a new
extras/python directory.
Change-Id: I14fe959778ee3344d7d54ba342c7928a4d8080a2
Fixes: c3fcff9ccbfcec1be242fd5cf210c9995586b078
Fixes: 8293d21280fd6ddfc9bb54068cf87794fc6be207
Updates: bz#1642810
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 7d46dbb543b723e698a6ceef7d694c23a9aff40c
Author: Sahina Bose <sabose@redhat.com>
Date: Mon Feb 11 11:07:49 2019 +0530
packaging: Obsoleting glusterfs-gnfs for upgrade
fixes: bz#1672711
Change-Id: Iad7194e788a8eeecd617614e9f8a1fe3264a384d
Signed-off-by: Sahina Bose <sabose@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit eb46abcbec42159303a7d7a53224e15a9061a8ca
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Feb 19 14:07:43 2019 +0530
glusterd: fix get-state leak
Updates: bz#1193929
Change-Id: I95897fd4d3102b4fa2b8b2864116b1bf24491cf9
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 008201a4bca2d49261ead33add04bc747b3792c8
Author: David Spisla <david.spisla@iternity.com>
Date: Tue Feb 19 14:56:11 2019 +0100
md-cache: Adapt integer data types to avoid integer overflow
The "struct iatt" in iatt.h is using int64_t types for storing
the atime, mtime and ctime. Therefore the struct 'struct md_cache' in
md-cache.c should also use this types to avoid an integer overflow.
This can happen e.g. if someone uses a very high default-retention-period
in the WORM-Xlator.
Change-Id: I605268d300ab622b9c8ab30e459dc00d9340aad1
fixes: bz#1678726
Signed-off-by: David Spisla <david.spisla@iternity.com>
commit 0b8ff9e9cf3b6e410e69122739080577e6c78911
Author: hujianfei <hujianfei@cmss.chinamobile.com>
Date: Fri Feb 15 04:07:46 2019 -0500
glusterfsd: Do not process PROFILE_NFS_INFO if graph is not ready
Otherwise, gnfs will crash in following situation.
Also see commit 2f9e555f.
Reproducible Steps:
1. kill gnfs process
2. service glusterd restart;gluster volume profile [vol] info nfs
dump trace info:
/lib64/libglusterfs.so.0(_gf_msg_backtrace_nomem+0xc2)[0x7fcf5cb6a872]
/lib64/libglusterfs.so.0(gf_print_trace+0x324)[0x7fcf5cb743a4]
/lib64/libc.so.6(+0x35670)[0x7fcf5b1d5670]
/usr/sbin/glusterfs(glusterfs_handle_nfs_profile+0x114)[0x7fcf5d066474]
/lib64/libglusterfs.so.0(synctask_wrap+0x12)[0x7fcf5cba1502]
/lib64/libc.so.6(+0x47110)[0x7fcf5b1e7110]
Fixes: bz#1677559
Change-Id: Id68edb3e4646c39544e0b4c90b5e0a9083b37b0d
Signed-off-by: hujianfei <hujianfei@cmss.chinamobile.com>
commit 3a91622210f9f507abebc53de578cfc4b2db34bf
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Feb 14 08:53:58 2019 +0200
upcall: some modifications to reduce work under lock
1. Reduced the number of times we call time(). This may affect accuracy
of access time and so on - please review carefully. I think the resolution is OK'ish.
2. Removed dead code.
3. Changed from CALLOC() to MALLOC() where it made sense.
4. Moved some bits of work outside of a lock.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I9fb8ca5d79b0e9126c1eb07e1a1ab5dbd8bf3f79
commit 7217c40d29798d964fdbf4320ab032282da0b1fa
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Feb 4 14:17:16 2019 +0530
glusterd: adding a comment for code readability
Adding a comment in the source code, so that anyone reading
the code will understand the changes done by d4fa29 better.
fixes: bz#1654270
Change-Id: I75aff4243420c434c47d69a4b310f77bf161bb29
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit cf2aea2499318b2e0750ff9646c13f4c9ba34425
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Tue Feb 19 08:04:52 2019 +0530
performance/write-behind: handle call-stub leaks
Change-Id: I7be9a5f48dcad1b136c479c58b1dca1e0488166d
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
Fixes: bz#1674406
commit 8c809b3d61bd6d09ce30b770d11d4985f02f27ef
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Wed Feb 13 17:08:14 2019 +0530
performance/write-behind: fix use-after-free in readdirp
Two issues were found:
1. in wb_readdirp_cbk, inode should unrefed after wb_inode is
unlocked. Otherwise, inode and hence the context wb_inode can be freed
by the type we try to unlock wb_inode
2. wb_readdirp_mark_end iterates over a list of wb_inodes of children
of a directory. But inodes could've been freed and hence the list
might be corrupted. To fix take a reference on inode before adding it
to invalidate_list of parent.
Change-Id: I911b0e0b2060f7f41ded0b05db11af6f9b7c09c5
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
Updates: bz#1674406
commit 0b5485f96b75e7cf9ceeb8231642d9f422b51c56
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Jan 24 12:14:48 2019 +0530
cli : fix mem leak during cli_cmd_volume_gsync_set_cbk
This patch fixes mem-leak due to excessive use of gf_asprintf
to form dynamic growing string.
Problem: each call to asprintf/vsprintf for extending existing string causes
a memory leak, because the blob at the original address of existing
string is not freed and a new location is generated by asprintf.
Tracebacks:
#2 0x7fdf191b8b3b in gf_vasprintf ../libglusterfs/src/mem-pool.c:236
#3 0x7fdf191b8d0a in gf_asprintf ../libglusterfs/src/mem-pool.c:256
#4 0x420cd3 in cli_cmd_volume_gsync_set_cbk ../cli/src/cli-cmd-volume.c:2576
SUMMARY: AddressSanitizer: 255 byte(s) leaked in 3 allocation(s).
....
SUMMARY: AddressSanitizer: 431 byte(s) leaked in 4 allocation(s).
....
SUMMARY: AddressSanitizer: 449 byte(s) leaked in 4 allocation(s).
....
SUMMARY: AddressSanitizer: 397 byte(s) leaked in 4 allocation(s).
....
SUMMARY: AddressSanitizer: 160 byte(s) leaked in 2 allocation(s).
....
updates: bz#1633930
Change-Id: I7e8902f0ed23e640dc17e3dcbdab7ae0579d2dc6
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit ae6fff2f43ad3bb7c5e5774e2aa20b364f9f0893
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Feb 14 17:48:26 2019 +0530
tests/dht: Remove hardcoded brick paths
The tests assumed that the file is created on a
particular brick.This need not be the case
in all scenarios and has been removed.
Change-Id: Id420f43d7f72d983a7c6f16ea8fed273d46c4824
updates: bz#1672480
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 31cba940742561a9026269813eed1b054e4142e9
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Jan 24 18:44:06 2019 +0100
core: implement a global thread pool
This patch implements a thread pool that is wait-free for adding jobs to
the queue and uses a very small locked region to get jobs. This makes it
possible to decrease contention drastically. It's based on wfcqueue
structure provided by urcu library.
It automatically enables more threads when load demands it, and stops
them when not needed. There's a maximum number of threads that can be
used. This value can be configured.
Depending on the workload, the maximum number of threads plays an
important role. So it needs to be configured for optimal performance.
Currently the thread pool doesn't self adjust the maximum for the
workload, so this configuration needs to be changed manually.
For this reason, the global thread pool has been made optional, so that
volumes can still use the thread pool provided by io-threads.
To enable it for bricks, the following option needs to be set:
config.global-threading = on
This option has no effect if bricks are already running. A restart is
required to activate it. It's recommended to also enable the following
option when running bricks with the global thread pool:
performance.iot-pass-through = on
To enable it for a FUSE mount point, the option '--global-threading'
must be added to the mount command. To change it, an umount and remount
is needed. It's recommended to disable the following option when using
global threading on a mount point:
performance.client-io-threads = off
To enable it for services managed by glusterd, glusterd needs to be
started with option '--global-threading'. In this case all daemons, like
self-heal, will be using the global thread pool.
Currently it can only be enabled for bricks, FUSE mounts and glusterd
services.
The maximum number of threads for clients and bricks can be configured
using the following options:
config.client-threads
config.brick-threads
These options can be applied online and its effect is immediate most of
the times. If one of them is set to 0, the maximum number of threads
will be calcutated as #cores * 2.
Some distributions use a very old userspace-rcu library (version 0.7)
for this reason, some header files from version 0.10 have been copied
into contrib/userspace-rcu and are used if the detected version is 0.7
or older.
An additional change has been made to io-threads to prevent that threads
are started when iot-pass-through is set.
Change-Id: I09d19e246b9e6d53c6247b29dfca6af6ee00a24b
updates: #532
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit c3a66b324d08eff2f8ed09b2bc51ab5196e15fb5
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Feb 12 11:17:37 2019 +0200
auth-cache.c: minor reduction of work under lock.
Minor change to reduce work done under a lock.
Also, remove unused variable (unrelated to the above).
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I1dfb55823c3db7c638d8a34288423bd1faa37c32
commit d9bd1f59428447a06e8039d7e9213a97fc23b162
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Feb 12 11:25:04 2019 +0200
server.c: use dict_() funcs with key length.
Changed to use the dict_() funcs which take the key length.
This happens to also reduce work under the lock in one case as well.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I958fcc29e95286fe3c74178cae3f01a8b2db26f2
commit 7da42f190541f609961ba0ba2a0a80196266867d
Author: Milind Changire <mchangir@redhat.com>
Date: Fri Feb 15 14:20:07 2019 +0530
socket: socket event handlers now return void
Problem:
Returning any value from socket event handlers to the event sub-system
doesn't make sense since event sub-system cannot handle socket
sub-system errors.
Solution:
Change return type of all socket event handlers to 'void'
Change-Id: I70dc2c57f12b7ea2fae41120f71aa0d7fe0b2b6f
Fixes: bz#1651246
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit e411966e01dadef446055aee028622274a358c5b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Feb 12 11:19:26 2019 +0200
md-cache.c: minor reduction of work under lock.
Take the time before taking the lock, not under lock.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I6cd05d8556a9bcc015e1be53f6ba46854e52a380
commit 73170047d957390e3415bfd30c7c21ac5f6d4d56
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 13 13:10:34 2019 +0530
protocol/server: Use SERVER_REQ_SET_ERROR correctly for dicts
Removed op_errno based SERVER_REQ_SET_ERROR() calls which was
dead-code. xdr_to_dict() calls have this check which is used
in 4.0 version of xdr-to-dict.
fixes bz#1676797
Change-Id: I6f56907c85576f1263a6ec04ed7e37f723b01ac3
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 57ea17f4fa448050a0bc8d69c65bef7891b2302f
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Feb 12 11:05:58 2019 +0200
dht-shared.c: minor reduction of work under lock.
Minor changes to reduce work done under a lock.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ia58adfb5125129e5d1f3bbf2202f38520fdbc29f
commit 722328303c6e14538c4e9d0cf688df01ee52fa3a
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Feb 11 14:03:50 2019 -0500
storage/posix: print the actual file path
posix converts incoming operations on files to operations on
corresponding gfid handles. While this in itself is not a problem,
logging of those gfid handles in place of actual file paths can
create confusions during debugging. The best way would be to
print both the actual file (recieved as an argument) for path
based operations and the gfid handle associated with it.
Change-Id: I408c36ca6456f2e3981b93151c19ef7f60085ad6
fixes: bz#1675076
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit bc79bb1fc1c4c389f91ef1bf667dd203a82af459
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 13 14:56:17 2019 +0530
Fix compilation for fops-sanity.c
Without this patch the following error is seen:
....
warning: implicit declaration of function ‘makedev’ [-Wimplicit-function-declaration]
ret = mknod("cspecial", S_IFCHR | S_IRWXU | S_IRWXG, makedev(2, 3));
^~~~~~~
/usr/bin/ld: /tmp/ccIVwT46.o: in function `path_based_fops':
/home/pk/workspace/gerrit-repo/tests/basic/fops-sanity.c:478:
undefined reference to `makedev'
....
updates bz#1676797
Change-Id: I8a17c38fdfd458dd2dc75f4c7e2bf20ce555a042
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 16cbc601fa097b648056e9f10e449f7b78f92ee5
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Feb 13 16:00:27 2019 +0100
docs: fix typo in Developer Guide Readme
updates: bz#1193929
Change-Id: I3e13e5a2d7347cf2a4e3717e93b5e97325e2de97
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 1ba2c15a8ebe200f4483229526c9906015232033
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Feb 6 09:58:55 2019 +0530
cluster/dht: Request linkto xattrs in dht_rmdir opendir
If parallel-readdir is enabled, the rda xlator is loaded
below dht in the graph and proactively lists and caches
entries when an opendir is performed. dht_rmdir checks if
the directory being deleted contains stale linkto files by
performing a readdirp on its child subvols. However, as
the entries are actually read in during the opendir operation
which does not request the linkto xattr,no linkto xattrs are
present for the entries causing dht to incorrectly identify
them as data files and fail the rmdir operation with ENOTEMPTY.
DHT now always adds the linkto xattr in the list of xattrs
requested in the opendir.
Change-Id: I0711198e66c59146282eb8b88084170bedfb4018
fixes: bz#1672851
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit c2229975196b5ca13224ddc9dd076fd2eab21672
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Tue Jan 8 16:38:45 2019 +0800
dht: fix double extra unref of inode at heal path
The loc_wipe is done in the _out_ section, inode_unref(loc.parent) here
casues a double extra unref of loc.parent.
Change-Id: I2dc809328d3d34bf7b02c7df9a4f97788af511e6
updates: bz#1651439
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 757b2f6276156ba2d68482abaf0f37397b7e678b
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Feb 12 13:58:54 2019 +0530
cluster/dht: Fix lookup selfheal and rmdir race
A race between the lookup selfheal and rmdir can cause
directories to be healed only on non-hashed subvols.
This can prevent the directory from being listed from
the mount point and in turn causes rm -rf to fail with
ENOTEMPTY.
Fix: Update the layout information correctly and reduce
the call count only after processing the response.
Change-Id: I812779aaf3d7bcf24aab1cb158cb6ed50d212451
fixes: bz#1676400
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 0f87ac15151d9407ca8d1a7b260009a3b70e8221
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Feb 9 13:23:06 2019 +0530
inode: make critical section smaller
do all the 'static' tasks outside of locked region.
* hash_dentry() and hash_gfid() are now called outside locked region.
* remove extra __dentry_hash exported in libglusterfs.sym
* avoid checks in locked functions, if the check is done in calling
function.
* implement dentry_destroy(), which handles freeing of dentry separately,
from that of dentry_unset (which takes care of separating dentry from
inode, and table)
Updates: bz#1670031
Change-Id: I584213e0748464bb427fbdef3c4ab6615d7d5eb0
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 1292b5c15789f5915606d542582755c88b2c7c2a
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Feb 13 10:20:29 2019 +0530
tests/dht: Stop volume before unmounting bricks
The bricks are loopback devices. Unmounting them is done
before the cleanup and leads to "target is busy" messages.
Change-Id: Ia808c2c9580273e1bf0595ecf53c210847c44577
fixes: bz#1676736
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit a60300ff3b34f91712f9dfabf42d43628de6bfca
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Feb 13 10:08:34 2019 +0530
rfc.sh: fix the missing rebase issue
When we decided to use clang-format for coding-style, and not bother
about local `check-patch.pl`, we had commented out coding style check
method in `./rfc.sh`. While it was intended and valid, we missed to
see one major issue with that. `git fetch` command, which fetched
latest code of the project, was inside the check_patches method, which
also got missed.
Even though we had an explicit 'rebase_orgin' method, it did nothing
because the git fetch was not done before this. Now, calling an explicit
git fetch, and removing dead code of check patches, as we are all fine
with coding-style changes in last 4+ months.
updates: bz#1193929
Change-Id: I3779096a527b93e780858ada8d988fdcdd6e2928
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7604927a57e8119938fba93aea5178490c80507c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Jan 3 17:44:18 2019 +0530
afr/shd: Cleanup self heal daemon resources during afr fini
We were not properly cleaning self-heal daemon resources
during afr fini. This patch will clean the same.
Change-Id: I597860be6f781b195449e695d871b8667a418d5a
updates: bz#1659708
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 15af2e3d6c2163c8675fb179fa2f8149fe97f242
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Tue Feb 12 09:11:34 2019 +0530
performance/md-cache: change the op-version of "global-cache-invalidation"
Since release-6 is not done yet, this option can be introduced with
GD_OP_VERSION_6_0.
Change-Id: I8a0867e5b8b23d0d485704a2fc7a3efc4a90f637
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
updates: bz#1664934
commit f4b52554d05e94a79a4b29ab8ee5891ab30cf387
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Jan 23 21:55:01 2019 +0530
clnt/rpc: ref leak during disconnect.
During disconnect cleanup, we are not cancelling reconnect
timer, which causes a ref leak each time when a disconnect
happen.
Change-Id: I9d05d1f368d080e04836bf6a0bb018bf8f7b5b8a
updates: bz#1659708
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit f8d0950154880fe1f042b0fe626af46c133ca0b8
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Feb 9 13:00:21 2019 +0530
fuse: reflect the actual default for lru-limit option
in both `--help` text and man page
updates: bz#1193929
Change-Id: I9aa9367c6863ac8e2403255280697c9e6be26cf0
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 2a6e24d5dd5d8595120c995cd666c18f11b46593
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Fri Feb 8 09:51:17 2019 +0530
performance/md-cache: introduce an option to control invalidation of inodes
Explicit invalidation by calling inode_invalidate is necessary when
same (meta)data is shared/access across multiple mounts. Without an
explicit inode_invalidate call, caches in the mount which didn't
witness writes wouldn't be aware of changes as writes wouldn't have
passed through them. However, if (meta)data is not shared, all
relevant I/O goes through the cache of single mount and hence is
coherent with (meta)data on bricks always. So, explicit inode
invalidation can be disabled for this case which gives a huge
performance boost for workloads that write data and then immediately
read the data they just wrote. Note that otherwise, local writes
(which pass through the cache) will change ctime and cause unnecessary
invalidations.
The name of the option that controls this behavior is
"performance.global-cache-invalidation". This option is global and it
purges caches both in glusterfs and kernel stack for native FUSE
mounts. For non-native FUSE mounts, it purges cache only from
glusterfs stack. This option is effective only when
performance.stat-prefetch is on.
Note that there is a similar option "performance.cache-invalidation",
but the scope of that option is limited to quick-read and md-cache.
Change-Id: I462bb4b65ff9aae1f6ba76f50b1f2f94fb10323b
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
updates: bz#1664934
commit b13f0b94e6291e71377247e06a8aef444e185b0e
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Feb 9 13:13:47 2019 +0530
inode: create inode outside locked region
Only linking of inode to the table, and inserting it in
a list needs to be in locked region.
Updates: bz#1670031
Change-Id: I6ea7e956b80cf2765c2233d761909c4bf9c7253c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 44e9c4b87d0219ae9455607cf81a1e509cf9d10d
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Fri Feb 8 17:39:49 2019 +0530
mount/fuse: fix bug related to --auto-invalidation in mount script
When "auto-invalidation" option was not specified for mount script,
glusterfs cmdline ended with "--auto-invalidation=" option. This patch
fixes that bug in mount script.
Thanks to Amar for reporting it.
Change-Id: Ie5cd4c6ffb3ac644d9d2b032035f914a935d05a8
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
updates: bz#1664934
commit 4fa3e2ddb07b81b17dde1b4d4210f091cdc35cbb
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Feb 7 14:45:39 2019 +0530
glusterd: improve logging
glusterd_resolve_all_bricks failure log should highlight the brick
identifier.
Updates: bz#1193929
Change-Id: I035b4650ef6a14bb1e1221d3bad1c40f9d43dbdd
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 10016c55fe0fe82397529465d6fbe2166fe861db
Author: ShyamsundarR <srangana@redhat.com>
Date: Tue Feb 5 20:44:28 2019 -0500
api: Update all future API versions to rel-6
As release 6 is branched, all future APIs now become 6.0
This change implements the same.
Change-Id: I6db368b4dc8585278ec11d4a411adcd04635de53
Updates: bz#1193929
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit bd61b1ffad1074a9c27da042342d23763bb531c4
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Feb 5 16:57:52 2019 +0100
fuse: correctly handle setxattr values
The setxattr function receives a pointer to raw data, which may not be
null-terminated. When this data needs to be interpreted as a string, an
explicit null termination needs to be added before using the value.
Change-Id: Id110f9b215b22786da5782adec9449ce38d0d563
updates: bz#1193929
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit a486e14cadf46553254bf7f3256321a9bce10b2a
Author: Nigel Babu <nigelb@redhat.com>
Date: Mon Jan 21 12:17:04 2019 +0530
Bump up timeout for tests on AWS
Fixes: bz#1672727
Change-Id: I2b9be45f199f6436b858536c6f49be85902217f0
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit 59536b6c556203a33ca84c266b5c38780f49efec
Author: ShyamsundarR <srangana@redhat.com>
Date: Tue Feb 5 20:14:07 2019 -0500
glusterd: Update op-version for release 7
Change-Id: I0f3978d7e603e6e767dc7aa2a23ef35b1f2b43f7
Updates: bz#1193929
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 4cbe1e7ba8edabd6b394f87907e8e3acc3727c9e
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Feb 4 15:07:14 2019 +0530
glusterd: get-state command should not fail if any brick is gone bad
Problem: get-state command will error out, if any of the underlying
brick(s) of volume(s) in the cluster go bad.
It is expected that get-state command should not error out, but
should generate an output successfully.
Solution: In glusterd_get_state(), a statfs call is made on the
brick path for every bricks of the volumes to calculate the total
and free memory available. If any of statfs call fails on any
brick, we should not error out and should report total memory and free
memory of that brick as 0.
This patch also handles a statfs failure scenario in
glusterd_store_retrieve_bricks().
fixes: bz#1672205
Change-Id: Ia9e8a1d8843b65949d72fd6809bd21d39b31ad83
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 6dad8648320707587ce3bfcdb01de718f4048369
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Feb 1 12:24:14 2019 +0530
geo-rep: Fix configparser import issue
'configparser' is backported to python2 and can
be installed using pip (pip install configparser).
So trying to import 'configparser' first and later
'ConfigParser' can cause issues w.r.t unicode strings.
Always try importing 'ConfigParser' first and then
'configparser'. This solves python2/python3 compat
issues.
Change-Id: I2a87c3fc46476296b8cb547338f35723518751cc
fixes: bz#1671637
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit a9996a62fd784f72e53087dd8124a00f18bb843d
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Mon Jan 21 11:16:09 2019 +0000
cli: Added the group option for volume set
gluster volume set <VOLUME> group <GROUP> is used for setting multiple
pre-defined volume options, but this was undocumented. This patch doc-
ments this feature.
fixes: bz#1243991
Change-Id: Id346cf2537f85179caff32479f09555ce2e72e76
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 3d0c9d094a0a9540771073e412942e200c0fe21b
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Dec 17 14:16:21 2018 +0530
glusterd: manage upgrade to current master
Scenarios tested:
* Upgrade the node when there are stripe / tiering and regular
type of volumes are present.
- All volumes are started fine (as the change was not on brick volfile)
- For tier, the functionality may not even work, as changetimerecorder
is not present.
- 'gluster volume info' properly shows as 'NOT SUPPORTED' for stripe and
tier type of volume.
* Upgrade in a rolling upgrade scenario, where an old version is
able to connect to higher master.
- on a normal volume, if the volfile-server was new, the newer client
volfiles needed to have utime xlator conditionally.
- with this one change, all other changes seem to work fine.
Change-Id: Ib2d3b69dafa02b2c695a735b13c1aa70aba07cb8
updates: bz#1635688
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 2e4f6f24e4e2656cbb431e9ea34150acb6896a33
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Jan 29 09:47:32 2019 +0530
cluster/dht: Do not use gfid-req in fresh lookup
Fuse sets a random gfid-req value for a fresh lookup. Posix
lookup will set this gfid on entries with missing gfids causing
a GFID mismatch for directories.
DHT will now ignore the Fuse provided gfid-req and use the GFID
returned from other subvols to heal the missing gfid.
Change-Id: I5f541978808f246ba4542564251e341ec490db14
fixes: bz#1670259
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit e94abcf65c17cea7e8c4fc6e7f54def48e2929b2
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Mon Dec 10 13:45:34 2018 +0530
glusterfind: python2 to python3 compat
Made necessary modifications to ensure python3 compatibilty.
fixes: bz#1658116
Change-Id: I5cf1d0447eaf3c44eb444245d1f67aadd60705c3
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit fc95a46f0c7170790b8cf36411af6068ca395984
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Tue Jan 29 08:05:07 2019 +0530
mount/fuse: expose auto-invalidation as a mount option
Auto invalidation is necessary when same (meta)data is shared/access
across multiple mounts. However, if (meta)data is not shared, all
relevant I/O goes through the cache of single mount and hence is
coherent with (meta)data on bricks always. So, fuse-auto-invalidation
can be disabled for this case which gives a huge performance boost for
workloads that write data and then immediately read the data they just
wrote.
From glusterfs --help,
<snip>
--auto-invalidation[=BOOL] controls whether fuse-kernel can
auto-invalidate attribute, dentry and page-cache.
Disable this only if same files/directories are
not accessed across two different mounts
concurrently [default: "on"]
</snip>
Details on how disabling auto-invalidation helped to reduce pgbench
init times can be found at [1]. Time taken for pgbench init of scale
8000 was 8340s. That will be an improvement of 86% (59280s vs 8340s)
with auto-invalidations turned off along with other
optimizations. Just disabling auto-invalidation contributed 56%
improvement by reducing the total time taken by 33260s.
[1] https://www.spinics.net/lists/gluster-devel/msg25907.html
Change-Id: I0ed730dba9064bd9c576ad1800170a21e100e1ce
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
updates: bz#1664934
commit f7d366e90acc63d83dafd27bfbf144f54cd54b29
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Jan 24 18:31:10 2019 +0100
core: make gf_thread_create() easier to use
This patch creates a specific function to set the thread name using a
string format and a variable argument list, like printf().
This function is used to set the thread name from gf_thread_create(),
which now accepts a variable argument list to create the full name. It's
not necessary anymore to use a local array to build the name of the
thread. This is done automatically.
Change-Id: Idd8d01fd462c227359b96e98699f8c6d962dc17c
Updates: bz#1193929
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit fabf80079e5ccba7494143b84b0f9558a0702384
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Dec 21 14:31:15 2018 +0530
cluster/thin-arbiter: Consider thin-arbiter before marking new entry changelog
If a fop to create an entry fails on one of the data brick,
we mark the pending changelog on the entry on brick for which
it was successful. This is done as part of post op phase to
make sure that entry gets healed even if it gets renamed to
some other path where its parent was not marked as bad.
As it happens as part of post op, we should consider thin-arbiter
to check if the brick, which was successful, is the good brick or not.
This will avoide split brain and other issues.
Change-Id: I12686675be98f02f70a5186b3ed748c541514d53
updates: bz#1662264
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 1ffcb4169b9a48c1c4b195e3eeb06853237b7852
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jan 28 11:55:17 2019 +0530
cluster/dht: Remove internal permission bits
Rebalance sets the sgid and t bits on a file
that is being migrated. These permissions are
not removed in dht_readdirp_cbk when listing files
causing them to show up on the mountpoint.
We now remove these permissions if a non-linkto
file has the linkto xattr set.
Change-Id: I5c69b2ecfe2df804fe50faea903b242d01729596
fixes: bz#1669937
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit eb0fc8aa3103cc6d3acc9a9a7590f18b50c92772
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Jan 31 11:30:27 2019 +0530
core: move "dict is NULL" logs to DEBUG log level
Too many logs get printed if dict_ref() and dict_unref() are passed NULL
pointer.
fixes: bz#1671213
Change-Id: I18afd849d64318f68baa7b549ee310dac0e1e786
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit f54671b03c451eb42e02127d719d3ee234401fc1
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Jan 31 08:13:58 2019 +0100
syncop: remove unnecessary call to gf_backtrace_save()
A call to gf_backtrace_save() was done on each context switch of a
synctask. The backtrace is generated writing to the filesystem, so it
can have an important impact on latency.
The generated backtrace was not used anywhere, so it's been removed.
Change-Id: I399a93b932c5b6e981c696c72c3e1ef44710ba52
Updates: bz#1193929
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit c3623c25f6bc41ecf33702264c7a7940f13b5f03
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Sat Sep 29 13:15:35 2018 +0530
feature/bitrot: Avoid thread creation if xlator is not enabled
Problem: Avoid thread creation for bitrot-stub
for a volume if feature is not enabled
Solution: Before thread creation check the flag if feature
is enabled
Updates: #475
Change-Id: I2c6cc35bba142d4b418cc986ada588e558512c8e
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit dd673a5882d5978a45f4d995ff23051a8393d90a
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Jan 28 21:28:45 2019 +0530
core: heketi-cli is throwing error "target is busy"
Problem: When rpc-transport-disconnect happens, server_connection_cleanup_flush_cbk()
is supposed to call rpc_transport_unref() after open-files on
that transport are flushed per transport.But open-fd-count is
maintained in bound_xl->fd_count, which can be incremented/decremented
cumulatively in server_connection_cleanup() by all transport
disconnect paths. So instead of rpc_transport_unref() happening
per transport, it ends up doing it only once after all the files
on all the transports for the brick are flushed leading to
rpc-leaks.
Solution: To avoid races maintain fd_cnt at client instead of maintaining
on brick
Credits: Pranith Kumar Karampuri
Change-Id: I6e8ea37a61f82d9aefb227c5b3ab57a7a36850e6
fixes: bz#1668190
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 03ef8950953b2acb72a51c2c7fca421787c413af
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Jan 29 11:51:16 2019 +0530
readdir-ahead: do not zero-out iatt in fop cbk
...when ctime is zero. ia_type and ia_gfid always need to be non-zero
for things to work correctly.
Problem:
Commit c9bde3021202f1d5c5a2d19ac05a510fc1f788ac zeroed out the iatt
buffer in the cbks of modification fops before unwinding if the ctime in
the buffer was zero. This was causing the fops to fail: noticeable when
AFR's 'consistent-metadata' option was enabled. (AFR zeros out the ctime
when the option is set. See commit
4c4624c9bad2edf27128cb122c64f15d7d63bbc8).
Fixes:
-Do not zero out the ia_type and ia_gfid of the iatt buff under any
circumstance.
-Also, fixed _rda_inode_ctx_update_iatts() to always update these values from
the incoming buf when ctime is zero. Otherwise we end up with zero
ia_type and ia_gfid the first time the function is called *and* the
incoming buf has ctime set to zero.
fixes: bz#1670253
Reported-By:Michael Hanselmann <public@hansmi.ch>
Change-Id: Ib72228892d42c3513c19fc6dfb543f2aa3489eca
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 739e846ebc1739e16da8824ab93493b70dca5630
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jan 29 03:16:16 2019 -0500
api: bad GFAPI_4.1.6 block
missing global: line, tabs not spaces
Change-Id: Icdbc23b4e4cd608da1d764e81757201c4b1269a6
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 3e83f342cce80c26138d8f99770270ad154b885d
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jan 28 18:30:24 2019 +0530
features/sdfs: disable by default
With the feature enabled, some of the performance testing results,
specially those which create millions of small files, got approximately
4x regression compared to version before enabling this.
On master without this patch: 765 creates/sec
On master with this patch : 3380 creates/sec
Also there seems to be regression caused by this in 'ls -l' workload.
On master without this patch: 3030 files/sec
On master with this patch : 16610 files/sec
This is a feature added to handle multiple clients parallely operating
(specially those which race for file creates with same name) on a single
namespace/directory. Considering that is < 3% of Gluster's usecase right
now, it makes sense to disable the feature by default, so we don't
penalize the default users who doesn't bother about this usecase.
Also note that the client side translators, specially, distribute,
replicate and disperse already handle the issue upto 99.5% of the cases
without SDFS, so it makes sense to keep the feature disabled by default.
Credits: Shyamsunder <srangana@redhat.com> for running the tests and
getting the numbers.
Change-Id: Iec49ce1d82e621e9db25eb633fcb1d932e74f4fc
Updates: bz#1670031
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit b1ffaf46ac2d5b55af84fbbf72d29ea38853f5b9
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Dec 27 18:56:16 2018 +0200
Multiple files: reduce work while under lock.
Mostly, unlock before logging.
In some cases, moved different code that was not needed
to be under lock (for example, taking time, or malloc'ing)
to be executed before taking the lock.
Note: logging might be slightly less accurate in order, since it may
not be done now under the lock, so order of logs is racy. I think
it's a reasonable compromise.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I2438710016afc9f4f62a176ef1a0d3ed793b4f89
commit b80f0e0e02c91d2ca7abbd7467673da64507382e
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Tue Jan 8 16:17:06 2019 +0800
socket: fix issue on concurrent handle of a socket
Found an issue on concurrent invoke of event handler to the same socket
fd, causing memory corruption. This issue arises after applying commit
"socket: Remove redundant in_lock in incoming message handling" that
removes priv->in_lock to serialize socket read.
The following call sequence describes how concurrent socket event handle
happens.
thread 1 thread 2 thread 3
epoll_wait() return
(slot->in_handler is 0) call select_on_epoll()
and epoll_ctl() on fd
epoll_wait() return
slot->in_handler++
(slot->in_handler is 1)
slot->in_handler++
(slot->in_handler is 2)
call handler() call handler()
Fix this issue by skip invoke of handler if there is already a handler
inprogress.
Change-Id: I437126ac772debcadb00993a948919c931cd607b
updates: bz#1467614
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit e995b36050c5017399de067b1ad39fecb01fd3d3
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jan 24 14:14:39 2019 +0530
features/shard: Ref shard inode while adding to fsync list
PROBLEM:
Lot of the earlier changes in the management of shards in lru, fsync
lists assumed that if a given shard exists in fsync list, it must be
part of lru list as well. This was found to be not true.
Consider this - a file is FALLOCATE'd to a size which would make the
number of participant shards to be greater than the lru list size.
In this case, some of the resolved shards that are to participate in
this fop will be evicted from lru list to give way to the rest of the
shards. And once FALLOCATE completes, these shards are added to fsync
list but without a ref. After the fop completes, these shard inodes
are unref'd and destroyed while their inode ctxs are still part of
fsync list. Now when an FSYNC is called on the base file and the
fsync-list traversed, the client crashes due to illegal memory access.
FIX:
Hold a ref on the shard inode when adding to fsync list as well.
And unref under following conditions:
1. when the shard is evicted from lru list
2. when the base file is fsync'd
3. when the shards are deleted.
Change-Id: Iab460667d091b8388322f59b6cb27ce69299b1b2
fixes: bz#1669077
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit ec8fc5c29c5c159cc0c49fca1b5357e4fe67eb23
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jan 11 11:57:07 2019 +0530
tests: run nfs tests only if --enable-gnfs is provided
Fixes: bz#1665358
Change-Id: Idbf88ec3ac683733b32c313377eeb72f2819bf0d
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit cb56b6e6a948d05b2759f5da81d96a6833e35674
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jan 24 12:14:11 2019 +0530
afr/self-heal:Fix wrong type checking
gf_dirent struct has d_type variable which should check
with DT_DIR istead of IA_IFDIR or IA_IFDIR has to compare
with entry->d_stat.ia_type
Change-Id: Idf1059ce2a590734bc5b6adaad73604d9a708804
updates: bz#1653359
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 96f83a104dc1fcfebeda6dea0e528a467c1f7cc4
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Jan 22 12:57:50 2019 +0530
core: heketi-cli is throwing error "target is busy"
Problem: At the time of deleting block hosting volume
through heketi-cli , it is throwing an error "target is busy".
cli is throwing an error because brick is not detached successfully
and brick is not detached due to race condition to cleanp xprt
associated with detached brick
Solution: To avoid xprt specifc race condition introduce an atomic flag
on rpc_transport
Change-Id: Id4ff1fe8375a63be71fb3343f455190a1b8bb6d4
fixes: bz#1668190
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 1dfb9a4c94be4b2ddea56b09400a45f9cdb3a9b9
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jan 22 13:30:34 2019 +0530
tests/bug-brick-mux-restart: add extra information
so that we can understand more about process memory and thread consumptions
With this, we will also be able to understand more about the process details
with brick-mux.
updates: bz#1193929
Change-Id: I147a3e3814fc37dfb635217d0a0f0184fae0994f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 610274f2fd1595f1747e7d3ab96dedb6932a44d0
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Jan 16 20:24:06 2019 +0530
core: move logs which are only developer relevant to DEBUG level
We had only changed the log level to DEBUG in release branch earlier.
But considering 90%+ of our deployments happen in same env, we can look
at these specific logs on need basis. With this change, the master
branch will be easier to debug with lesser logs.
Change-Id: I4157a7ec7d5ec9c2948b2bbc1e4cb8317f28d6b8
Updates: bz#1666833
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 73a415617485875aac2501b3370300c48bf43594
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Jan 21 17:01:33 2019 +0530
performance/readdir-ahead: Fix deadlock in readdir ahead.
This patch fixes a lock contention in reaadir-ahead xlator.
There are two issues, one is the processing of "." ".."
entry while holding an fd_ctx lock. The other one is destroying
the stack inside a fd_ctx lock.
Change-Id: Id0bf83a3d9fea6b40015b8d167525c59c6cfa25e
updates: bz#1659708
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit c5bcb983312ece9359001282c9192efb4f5fc91a
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Mon Dec 31 10:55:21 2018 +0530
tools/glusterfind: option to display only files/directories
Updated full find to filter for files and directories.
--full --type f lists only the files,
--full --type d lists only the directories,
--full (by default) lists both files and directories.
fixes: #579
Change-Id: If2c91a21a131667d5de34635c1846013e8fa20b7
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit e134bba41f601227307dbd700dcbe2af107c0e95
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Jan 22 18:01:40 2019 +0530
posix: Change data type to dump nr_files to statedump
Problem: In commit 2261e444a47ffffb5d64305efceee1d5a734cd75
wrong data type of nr_files was changed to dump
nr_files to statedump so build is failing on 32bit
environment
Solution: Change data type to avoid errors
Change-Id: Ifb4b19feda6e0e56d110b23351e7a0efd5bfa29b
fixes: bz#1657607
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 18a2145084539795e7fcb0d9fcd8673ef11aa8fa
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Jan 22 16:07:52 2019 +0530
rpc: Fix double free
The value rsp.xdata.xdata_val was being freed twice. It was assigned
to dict->extra_stdfree, dict_destroy would free it and also there was
an explicit free. Getting rid of explicit free in this patch.
Change-Id: Ia9c73454bec3970b33f154fa754398bf3b045645
fixes: bz#1668268
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 51f4a483842d91d794a166079d8f277fefffacbe
Author: Milind Changire <mchangir@redhat.com>
Date: Tue Jan 22 12:10:59 2019 +0530
rpc: use address-family option from vol file
This patch helps enable IPv6 connections in the cluster.
The default address-family is IPv4 without using this option explicitly.
When address-family is set to "inet6" in the /etc/glusterfs/glusterd.vol
file, the mount command-line also needs to have
-o xlator-option="transport.address-family=inet6" added to it.
This option also gets added to the brick command-line.
Snapshot and gfapi use-cases should also use this option to pass in the
inet6 address-family.
Change-Id: I97db91021af27bacb6d7578e33ea4817f66d7270
fixes: bz#1635863
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit dbb7dba5e78270052a3ae49cc2382632da213735
Author: Iraj Jamali <ijamali@redhat.com>
Date: Fri Nov 30 17:23:57 2018 +0530
afr: not resolve splitbrains when copies are of same size
Automatic Splitbrain with size as policy must
not resolve splitbrains when the copies are of same size.
Determining if the sizes of copies are same and
returning -1 in that case.
updates: bz#1655052
Change-Id: I3d8e8b4d7962b070ed16c3ee02a1e5a926fd5eab
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit 9ac5df6e17f03e29bed5c621b9e32a4e79ba0430
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Thu Jan 3 17:57:38 2019 +0800
socket: don't pass return value from protocol handler to event handler
Event handler handles socket level error only, while protocol handler
handles in protocol level error. If protocol handler decides to
disconnect on error in any case, it should call disconnect instead of
return an error back to event handler.
Change-Id: I9375be98cc52cb969085333f3c7229a91207d1bd
updates: bz#1666143
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit 5ac05d58eb77c75d04e01212ea3971a51a4e5921
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Sat Dec 29 16:26:58 2018 +0800
socket: fix issue when socket read return with EAGAIN
In the case socket read returns EAGAIN, positive value about remaining
vector to send is returned. This return value will be passed all the way
back to event handler, making it complains.
[2018-12-29 08:02:25.603199] T [socket.c:1640:__socket_read_simple_payload] 0-test-client-0-extra.0: partial read on non-blocking socket.
[2018-12-29 08:02:25.603201] T [rpc-clnt.c:654:rpc_clnt_reply_init] 0-test-client-2-extra.1: received rpc message (RPC XID: 0xfa6 Program: GlusterFS 4.x v1, ProgVers: 400, Proc: 12) from rpc-transport (test-client-2-extra.1)
[2018-12-29 08:02:25.603207] T [socket.c:3129:socket_event_handler] 0-test-client-0-extra.0: (sock:32) socket_event_poll_in returned 1
Formerly, in socket_proto_state_machine, return value of socket_readv is
used to check if message is all read-in. In this commit, it is checked
whether size of bytes indicated in header are all read in. In this way,
only 0 and -1 will be returned from socket_proto_state_machine(),
indicating whether there is error in the underlying socket.
Change-Id: I8be0d178b049f0720d738a03aec41c4b375d2972
updates: bz#1666143
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit 09e7eca47d8474970b5afc737f1c4894921dffb6
Author: Susant Palai <spalai@redhat.com>
Date: Fri Jan 18 17:26:36 2019 +0530
locks/fencing: Add a security knob for fencing
There is a low level security issue with fencing since one client
can preempt another client's lock.
This patch does not completely eliminate the issue of a client
misbehaving, but certainly it adds a security layer for default use cases
that does not need fencing.
Change-Id: I55cd15f2ed1ae0f2556e3d27a2ef4bc10fdada1c
updates: #466
Signed-off-by: Susant Palai <spalai@redhat.com>
commit b383197684fb3ae8df61e58fba6e8f44c94bb188
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jan 21 15:15:51 2019 +0530
cluster/dht: Delete invalid linkto files in rmdir
rm -rf <dir> fails on dirs which contain linkto files
that point to themselves because dht incorrectly thought
that they were cached files after looking them up.
The fix now treats them as invalid linkto files
and deletes them.
Change-Id: I376c72a5309714ee339c74485e02cfb4e29be643
fixes: bz#1667804
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 12d760ea4aa22ccaca9b5ae12f1cfba8b5e7c1e7
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Jan 21 17:53:12 2019 +0530
glusterd: Avoid dict_leak in __glusterd_handle_cli_uuid_get function
Change-Id: Iefe08b136044495f6fa2b092c9e8c833efee1400
fixes: bz#1667905
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit d082c1ae15465aacda89f925690702afeccbfbce
Author: Xiubo Li <xiubli@redhat.com>
Date: Sun Jan 13 17:30:11 2019 +0800
common-utils: make vector a const parameter
To avoid the warning and preparing for adding writesame support.
Updates: #617
Change-Id: I0710b1e4c240368a9bf52968bddc6e250ae2028d
Signed-off-by: Xiubo Li <xiubli@redhat.com>
commit 76f15e7059d51095f2a55a9d98b5a25da8e969e5
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Jan 21 09:12:30 2019 +0530
glusterd: Resolve memory leak in get-state command
In gluster get-state volumeoptions command there was some amount of leak
observed. This fix resolves the identified leaks.
Change-Id: Ibde5743d1136fa72c531d48bb1b0b5da0c0b82a1
fixes: bz#1667779
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 8adb332e2386e36bf06e703c4b73038fb033b4c8
Author: Iraj Jamali <ijamali@redhat.com>
Date: Mon Jan 7 15:19:18 2019 +0530
posix: fix coverity issue
Logically dead code
CID: 1398468
Updates: bz#789278
Change-Id: I8713a0c51777eb64e617d00ab72fd1db4994b6ab
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit 028a960d3640e47857b3ae64fa78ffcadbdc14b2
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Fri Nov 30 19:49:59 2018 +0530
afr: Splitbrain with size as policy must not resolve for directory
In automatic Splitbrain resolution when favorite child policy
is set as size, split brain resolution must not work for
directories.
Currently, if a directory is in split brain with both copies
having same size, the source is selected arbitrarily
and healed.
fixes: bz#1655050
Change-Id: I5739498639c17c89874cc577362e543adab55f5d
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit af59b2e282f889e9d3887c88bd28fa9a7b2fb706
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Mon Jan 14 13:24:20 2019 +0000
cli: Added a welcome and help message
When gluster command is fired without any arguments it just shows the
prompt, so added a welcome message and info to get help.
fixes: bz#1535528
Change-Id: I627b66b67443716e9270025c1e47b98b6facba13
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit 8be61bbd5719ffb4ba97a6a2b0d35a4ba02e5263
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Fri Jan 18 10:38:14 2019 +0800
quotad: fix wrong memory free
1. cli_req.dict.dict_val,
It must be freed no metter operation error or success.
Fix it as lookup "alloca" memory before decode.
2. args.xdata.xdata_val,
It is allocated by "alloca", free is unneeded.
3. qd_nameless_lookup,
It olny needs gfid, a gfs3_lookup_req argument is unneeded.
Change-Id: I746dddf7f3d1465b1885af2644afe0bcf0a5665b
fixes: bz#1656682
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit e3bc979671ed0889d1c25f95acc31df295a27c12
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Tue Jan 1 21:06:05 2019 +0530
core: Feature added to accept CidrIp in auth.allow
Added functionality to gluster volume set auth.allow command to
accept CIDR IP addresses. Modified few functions to isolate cidr
feature so that it prevents other gluster commands such as peer
probe to use cidr format ip. The functions are modified in such
a way that they have an option to enable accepting of cidr
format for other gluster commands if required in furture.
updates: bz#1138841
Change-Id: Ie6734002a7078f1820e5df42d404411cce945e8b
Credits: Mohit Agrawal
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit deea53b9feec4407f08f41c4e3bd46f789fd2bcf
Author: Susant Palai <spalai@redhat.com>
Date: Fri Nov 30 15:04:17 2018 +0530
lock: Add fencing support
design reference: https://review.gluster.org/#/c/glusterfs-specs/+/21925/
This patch adds the lock preempt support.
Note: The current model stores lock enforcement information as separate
xattr on disk. There is another effort going in parallel to store this
in stat(x) of the file. This patch is self sufficient to add fencing
support. Based on the availability of the stat(x) support either I will
rebase this patch or we can modify the necessary bits post merging this
patch.
Change-Id: If4a42f3e0afaee1f66cdb0360ad4e0c005b5b017
updates: #466
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 3eeba9e18967c407a0077df3b1b44b4976a6a5cc
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Jan 14 11:48:55 2019 +0530
geo-rep : fix rename sync on hybrid crawl
Problem: When geo-rep is configured as hybrid crawl
directory renames are not synced to the slave.
Solution: Rename sync of directory was failing due to incorrect
destination path calculation.
During check for existence on slave we miscalculated
realpath. <host:brickpath/dir>.
Change-Id: I23f1ea60e86a917598fe869d5d24f8da654d8a0a
fixes: bz#1665826
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 5e8c8d2fbc8849af261a19009b6cbadae4681290
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Sat Dec 29 15:51:13 2018 +0800
socket: fix issue when socket write return with EAGAIN
In the case socket write return with EAGAIN, the remaining vector count
is return all way back to event handler, making followup pollin event to
skip handling and dispatch loop complains about failure. Even thought
temporary write failure is not an error.
[2018-12-29 07:31:41.772310] E [MSGID: 101191] [event-epoll.c:674:event_dispatch_epoll_worker] 0-epoll: Failed to dispatch handler
Change-Id: Idf03d120b5f7619eda19720a583cbcc3e7da2504
updates: bz#1666143
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit 1ed40798797ee2c3469f7333f3d22136a8159722
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Thu Dec 27 14:13:48 2018 +0800
socket: fix counting of socket total_bytes_read and total_bytes_write
Change-Id: If35d0dbae963facf00ab6bcf07c6e4d1706ed982
updates: bz#1666143
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit e0d15f1cfeb8c128bac89e392f8f9dae057babcb
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri Dec 7 14:36:45 2018 +0530
core: Resolve memory leak for brick
Problem: Some functions are not freeing memory allocated by
xdr_to_genric so it has become leak
Solution: Call free to avoid leak
Change-Id: I3524fe2831d1511d378a032f21467edae3850314
fixes: bz#1656682
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 866f554ec651a788c4d86ec0e5523733d6dc00d4
Author: Arjun <arjsharm@redhat.com>
Date: Tue Dec 4 11:02:37 2018 +0530
gfapi : making glfs_setattr/glfs_fsetattr as public
Initially glfs_fsetattr and glfs_setattr, both functions accepted iatt as arguements
but now they accept stat and later in the function the stat is being converted to iatt
so that it can be passed to syncop_fsetattr/syncop_setattr.
Change-Id: I41a9e0124785a32ca19ef4d492c5ed5002e66ede
updates: #389
Signed-off-by: Arjun Sharma <arjsharm@redhat.com>
commit b967e272ffadd875830ffde063c60e756a9d862e
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Dec 10 11:14:04 2018 +0530
posix: Convert several posix_private members to gf_atomic
Change-Id: I629698d8ddf6f15428880bdc1501d36bc37b8ebb
fixes: bz#1657607
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 66cce9d9883d696d116b56b0365be0beaf939490
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Sat Jan 12 11:17:23 2019 +0530
core: glusterd/add-brick-and-validate-replicated-volume-options.t is crash
Problem: Sometime brick is getting crash at the time of handling
pmap signin request
Solution: glusterfs_mgmt_pamp_signin is using same frame to send
pmap signin request so to avoid crash send signin request
on separate frame
Change-Id: I443f854171ec4372e8d5f84bdc576c468e92c493
fixes: bz#1665656
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 2ea320984c80a68d1b92e9d7eb21e41cb622e472
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri Nov 30 16:07:39 2018 +0530
core: Resolve dict_leak at the time of destroying graph
Problem: In gluster code some of the places it call's get_new_dict
to create a dictionary without taking reference so at the time
of dict_unref it has become a leak
Solution: To resolve the same call dict_new instead of get_new_dict
updates bz#1650403
Change-Id: I3ccbbf5af07079a4fa09aad2cd0458c8625b2f06
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 4a8948da1be111fcc39fe1b1b109b3afec1657f3
Author: Xiubo Li <xiubli@redhat.com>
Date: Fri Jan 4 15:22:24 2019 +0800
cluster/afr: fix zerofill transaction.start
This maybe one mistake when coding.
Fixes: bz#1665332
Change-Id: Ia8f8dadf4a71579240ff9950b141ca528bd342b3
Signed-off-by: Xiubo Li <xiubli@redhat.com>
commit d03563b26f59eaffbce6467354795658d108a912
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Jan 10 16:17:39 2019 +0530
glusterd: fix crash
Problem: running "gluster get-state glusterd odir /get-state"
resulted in glusterd crash.
Cause: In the above command output directory has been specified
without "/" at the end. If "/" is not given at the end, "/" will
be added to path using "strcat", so the added character "/" is
not having memory allocated. When tried to free, glusterd will
crash as"/" has no memory allocated.
Solution: Instead of concatenating "/" to output directory, add
it to output filename.
Change-Id: I5dc00a71e46fbef4d07fe99ae23b36fb60dec1c2
fixes: bz#1665038
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 47bb0666624fcb1ac32a86215b53c79bb9f5b115
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Jan 10 23:00:49 2019 -0800
features/index: Correct incorrect definition in header
s/QUIESCE/INDEX/
fixes: bz#1665363
Change-Id: I6dc4fde682cedeaa10d870267b8909af1a9449c0
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 2d05018bd5ab9c2799b1fb942bdc0cc4d68ce0c7
Author: Iraj Jamali <ijamali@redhat.com>
Date: Mon Dec 17 11:23:59 2018 +0530
fix 32-bit-build-smoke warnings
fixes: bz#1622665
Change-Id: I777d67b1b62c284c62a02277238ad7538eef001e
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit 85785765d6bfe3cc98ef7e23a5b08e347981fea9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Dec 28 18:53:15 2018 +0530
features/shard: Fix launch of multiple synctasks for background deletion
PROBLEM:
When multiple sharded files are deleted in quick succession, multiple
issues were observed:
1. misleading logs corresponding to a sharded file where while one log
message said the shards corresponding to the file were deleted
successfully, this was followed by multiple logs suggesting the very
same operation failed. This was because of multiple synctasks
attempting to clean up shards of the same file and only one of them
succeeding (the one that gets ENTRYLK successfully), and the rest of
them logging failure.
2. multiple synctasks to do background deletion would be launched, one
for each deleted file but all of them could readdir entries from
.remove_me at the same time could potentially contend for ENTRYLK on
.shard for each of the entry names. This is undesirable and wasteful.
FIX:
Background deletion will now follow a state machine. In the event that
there are multiple attempts to launch synctask for background deletion,
one for each file deleted, only the first task is launched. And if while
this task is doing the cleanup, more attempts are made to delete other
files, the state of the synctask is adjusted so that it restarts the
crawl even after reaching end-of-directory to pick up any files it may
have missed in the previous iteration.
This patch also fixes uninitialized lk-owner during syncop_entrylk()
which was leading to multiple background deletion synctasks entering
the critical section at the same time and leading to illegal memory access
of base inode in the second syntcask after it was destroyed post shard deletion
by the first synctask.
Change-Id: Ib33773d27fb4be463c7a8a5a6a4b63689705324e
updates: bz#1662368
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit b91325caa3b26549f20cb244686902d00378def5
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Dec 28 17:45:58 2018 +0530
configure: fix the duplicate CFLAGS options
updates: bz#1193929
Change-Id: I403878719a3f81fb2ea951a951f84880fb54f3cc
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7c716350b91c80bcc2739694f338729061c9a6d4
Author: Varsha Rao <varao@redhat.com>
Date: Wed Jan 9 15:10:37 2019 +0530
libglusterfs/common-utils.c: Fix buffer size for checksum computation
Problem: When quorum count option is updated, the change is not reflected in
the nfs-server.vol file. This is because in get_checksum_for_file(), when the
last part of the file read has size less than buffer size, the read buffer
stores old data value along with correct data value.
Solution: Pass the bytes read instead of fixed buffer size, for calculating
checksum.
Change-Id: I4b641607c8a262961b3f3da0028a54e08c3f8589
fixes: bz#1657744
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 16dc9bc2ca6df2e5212c4cf8476bd1d2b6a927e5
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Wed Jan 9 14:09:03 2019 +0800
doc: fix wrong description of localtime-logging in manpages
-L is the short option of --log-level, not --localtime-logging,
and also, --localtime-logging does not contain an argument.
Change-Id: I7e1163cb88b84ab5faecd0a65a1f7257e731d2a7
updates: bz#1664551
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 4e086a1c547ed2aba4b2a4e348df0831a77b0b99
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Nov 27 11:47:12 2018 +0530
extras/systemd: Remove socket activated syslog.target and add documentation keys
Adopting patch provided by Patrick Matthäi <pmatthaei@debian.org> at:
https://bugzilla.redhat.com/attachment.cgi?id=1470751
fixes: bz#1560561
Change-Id: I363a049c743c65823e6c4f153cbe20b47fcb64fb
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 889c0bb474ebd1ce2350a63196ae686ff10cacac
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Jan 2 16:25:35 2019 +0530
core: brick process is crashed at the time of spawn thread
Problem: brick is getting crashed at the time of calling
pthread_detach after just call gf_thread_create.If
sufficient resources are not available on the system
pthread_create returns EAGAIN (non-negative) but the
caller function expects negative error code in case of failure
Solution: Change the condition in caller function to avoid the crash
Change-Id: Ifeaa49f809957eb6c33aa9792f5af1b55566756d
fixes: bz#1662906
commit 8d7f5f879c71eceb45347f9c9e8bd028a3266222
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Jan 10 11:08:49 2019 -0800
performance/md-cache: Fix a crash when statfs caching is enabled
mem_put() in STACK_UNWIND_STRICT causes a crash if frame->local is not null
as md-cache obtains local from CALLOC.
Changed two occurrences of STACK_UNWIND_STRICT to MDC_STACK_UNWIND as
the latter macro does not rely on STACK_UNWIND_STRICT for cleaning up
frame->local.
fixes: bz#1632503
Change-Id: I1b3edcb9372a164ef73119e99a49e747765d7166
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 603ab87c8a9e7cbebeab15d78d2b2018409615f1
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jan 10 17:12:53 2019 +0530
tests: increase the timeout for distribute bug 1117851.t
The test is in borderline of 200seconds, and many a times, randomly
takes little more time, and fails the whole regression. Better to keep
timeout high, so we don't 'randomly' fail regression tests.
updates: bz#1193929
Change-Id: Ib0d3a9f7a75ee44446ec6da5e0510cccf83eecaa
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 440c828417ca1f29007ba4e3bae4eaecb4027dce
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Jan 8 16:35:35 2019 +0530
afr : fix memory leak
This patch fixes memory leak reported by ASan.
The fix was first merged by
https://review.gluster.org/#/c/glusterfs/+/21805.
But later change was reverted due to this patch
https://review.gluster.org/#/c/glusterfs/+/21178/.
updates: bz#1633930
Change-Id: I1febe121e0be33a637397a0b54d6b78391692b0d
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 51d1aa80b35fe4fea9ae0799723d87591d05bfc7
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Thu Dec 27 19:18:35 2018 +0530
cluster/afr: Disable client side heals in AFR by default.
With this changeset, default value for the AFR client side
heal volume option is set to "off"
fixes: bz#1663102
Change-Id: Ie4016932339c4896487e3e7cb5caca68739b7ba2
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit ba0880099906686ac6d15cdba414ec61dbcfe280
Author: Susant Palai <spalai@redhat.com>
Date: Wed Jan 9 16:57:21 2019 +0530
dht: Add NULL check for stbuf in dht_rmdir_lookup_cbk
Change-Id: I2ced288113a369cc6497a77ac1871007df434da4
fixes: bz#1664647
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 1c616c7d3d270e7d42165640c4661412c5f8a6aa
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Dec 21 20:51:03 2018 +0530
features/locks: Dump connection_id even for posix locks
... in statedump for a better debugging experience.
BEFORE:
posixlk.posixlk[0](ACTIVE)=type=WRITE, whence=0, start=0, len=0,
pid = 13635, owner=2dd2c3a11706dc8c, client=0x7f159012b000,
connection-id=(null), granted at 2018-12-31 14:20:42
connection-id is null above.
AFTER:
posixlk.posixlk[0](ACTIVE)=type=WRITE, whence=0, start=0, len=0,
pid = 10977, owner=b485e33df21bdaa2, client=0x7fa24c01ab90,
connection-id=CTX_ID:68e12340-eed2-4386-bf5e-1f43cf8693d9-GRAPH_ID:0-
PID:10901-HOST:dhcp35-215.lab.eng.blr.redhat.com-PC_NAME:patchy-client-0-
RECON_NO:-0, granted at 2018-12-31 14:33:50
Change-Id: I4608994bacabb558a3be8c1634ee6b1d2d3022e2
fixes: bz#1662679
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 9b777852e79e8dab4ce693a98e2e56bf20ec3748
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Jan 2 18:20:07 2019 +0530
timer-wheel: run the timer function outside of locked region
Surprizingly this also reduced 80% CPU overhead 'perf record' tool reported
in posix_spin_lock in a brick-mux test volume initialization process.
updates: bz#1193929
Change-Id: I4e1df60d6fd094105c312df39f1527d3f07bed68
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit a166f4bfbcd5c41ef97510d271833844d08027dd
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Dec 28 07:27:11 2018 +0530
features/shard: Assign fop id during background deletion to prevent excessive logging
... of the kind
"[2018-12-26 05:22:44.195019] E [MSGID: 133010]
[shard.c:2253:shard_common_lookup_shards_cbk] 0-volume1-shard: Lookup
on shard 785 failed. Base file gfid = cd938e64-bf06-476f-a5d4-d580a0d37416
[No such file or directory]"
shard_common_lookup_shards_cbk() has a specific check to ignore ENOENT error without
logging them during specific fops. But because background deletion is done in a new
frame (with local->fop being GF_FOP_NULL), the ENOENT check is skipped and the
absence of shards gets logged everytime.
To fix this, local->fop is initialized to GF_FOP_UNLINK during background deletion.
Change-Id: I0ca8d3b3bfbcd354b4a555eee520eb0479bcda35
updates: bz#1662368
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit a0481ad515e4ed4e80b688c31ebb32ce11a3983e
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jan 4 07:04:50 2019 +0000
Revert "iobuf: Get rid of pre allocated iobuf_pool and use per thread mem pool"
This reverts commit b87c397091bac6a4a6dec4e45a7671fad4a11770.
There seems to be some performance regression with the patch and hence recommended to have it reverted.
Updates: #325
Change-Id: Id85d6203173a44fad6cf51d39b3e96f37afcec09
commit 4477d426b9d3f0269a19e3baf5d9607d1b8105a7
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jan 7 13:58:01 2019 -0500
features/bit-rot: do not send version and signature keys in dict
In lookup, if the file has been marked as bad, then bit-rot-stub
was sending the version and signature xattr values as well in the
response dictinary. This is not needed. Only bad file marker has
to be sent.
Change-Id: Id59c02e9857577c60849fd28ef657f71e0b15207
fixes: bz#1664122
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 6c8eaf9c9de8d11e77c9116bd00332623a35d740
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Nov 16 23:26:35 2018 +0530
performance/io-threads: Improve debuggability in statedump
statedump from io-threads lacked information to understand the number of
running threads & number of requests in each priority queue. This patch
addresses that.
Sample statedump output w/ this patch:
current_high_priority_threads=7
current_normal_priority_threads=9
current_low_priority_threads=0
current_least_priority_threads=0
fast_priority_queue_length=32
normal_priority_queue_length=45
Also, changed the wording for least priority queue in
iot_get_pri_meaning().
Change-Id: Ic5f6391a15cc28884383f5185fce1cb52e0d10a5
fixes: bz#1664124
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 46bfc0c53c56b9f48ef770958f4dd2cf2c444182
Author: ShyamsundarR <srangana@redhat.com>
Date: Thu Dec 20 15:28:37 2018 -0500
gfapi: update returned/callback pre/post attributes to glfs_stat
Change-Id: Ie0fe971e694101aa011d66aa496d0644669c2c5a
Updates: #389
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit dd94955dfef945c469593b3114682dbc40e1eef3
Author: ShyamsundarR <srangana@redhat.com>
Date: Wed Nov 21 09:43:23 2018 -0500
gfapi: new api glfs_statx as linux's statx
Change-Id: I44dd6ceef0954ae7fc13f920e84d81bbd3f6a774
Updates: #389
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 50179aa2909451e3a71984985240e4146f99d5e4
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Thu Jan 3 17:07:27 2019 +0800
glfs-fops.c: fix the bad string length for snprintf
Snprintf reserves one byte for the ending '\0'.
A NAME_MAX bytes d_name is truncated to NAME_MAX - 1 bytes.
Change-Id: Ic884d18cee24360e55ddb896dc587b0b74ef97fe
updates: bz#1193929
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 5ad6037ff541e2918294a69017fc53b6a87f67e6
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Dec 25 13:29:15 2018 -0500
leases: Reset lease_ctx->timer post deletion
To avoid use_after_free, reset lease_ctx->timer back to NULL
after the structure has been freed.
Change-Id: Icd213ec809b8af934afdb519c335a4680a1d6cdc
updates: bz#1648768
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit a8f44aeeccf789a3c7793b22dd27475b752bab24
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Dec 20 16:58:34 2018 +0800
rpc-clnt: reduce transport connect log for EINPROGRESS
quotad and ganesha.nfsd prints many logs as,
[rpc-clnt.c:1739:rpc_clnt_submit ] 0-<VOLUME_NAME>-quota: error returned while attempting to connect to host: (null), port 0
Change-Id: Ic0c815400619e4a87a772a51b19822920228c1ef
Updates: bz#1596787
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 3876cc73a27a208a3d600e774163b2de6327603f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jan 2 18:42:19 2019 +0530
rpcsvc: Don't expect dictionary values to be available
When reconfigure happens, string values from one dictionary
are directly set in another dictionary. This can lead to
invalid memory when the first dictionary is freed up.
So do dict_set_dynstr_with_alloc instead of dict_set_str
updates bz#1650403
Change-Id: Id53236467521cfdeb07e7178d87ba6cf88d17003
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit a4969e6db8e52c79c9d590166a0a39497afbf918
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Jan 4 15:49:53 2019 +0530
glusterd: rebalance status should display information of localhost
Problem:
https://review.gluster.org/#/c/glusterfs/+/21762/ has migrated
rebalance commands from op-sm framework to mgmt v3 framework.
In a heterogenous cluster, if rebalance commands follow op-sm
framework, localhost information is not displayed in the
output of "gluster v rebalance <volname> status".
Cause:
Previously without https://review.gluster.org/#/c/glusterfs/+/21762/
rebalance commands were following op-sm framework.
In glusterd_volume_rebalance_use_rsp_dict() current_index variable
keeps track of number/count of peers in trusted storage pool.
In op-sm, glusterd_volume_rebalance_use_rsp_dict() will be called
only for the peers. So the current index should start from 2
assuming local host as node 1.
With the above patch, rebalance commands are following mgmt v3
framework. In mgmt v3, glusterd_volume_rebalance_use_rsp_dict()
is called for all nodes. For localhost it is called from
brick-op function and for peers it is called from brick-op
call back function. So the current index value should start
from 1.
https://review.gluster.org/#/c/glusterfs/+/21762/ has changed the
value of current index to 1. Because of this, In heterogenous cluster,
local host's information is overwritten by one of the peers information.
And rebalance status will not display localhost's information in
the output.
Solution: assign a value to current index based on a op-version
check.
Change-Id: I2dfba1f007e908cf160acc4a4a5d8ef672572e4d
fixes: bz#1663243
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 8c5fd2f67696417665da56ba8956b304c9ac4e68
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Jan 3 10:52:22 2019 +0530
extras: Add readdir-ahead to samba group command
Change-Id: I310f014a9ab8416d9833f5711ff902da1457f415
updates: bz#1193929
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 22cbc5d2af7dfbbe42ad7c7aac4c22b37268b02c
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Jan 3 19:09:36 2019 +0530
glusterd: aggregate rsp from peers for profile command
When we run profile info command, it should display statistics
of all the bricks of the volume. To display information of bricks
which are hosted on peers, we need to aggregate the response from
peers.
For profile info command, all the statistics will be added into
the dictionary in brick-op phase. To aggregate the information from
peers, we need to call glusterd_syncop_aggr_rsp_dict() in brick-op
call back function.
fixes: bz#1663223
Change-Id: I5f5890c3d01974747f829128ab74be6071f4aa30
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit f0e0cf5398c4c0aa5a9a1038258c6b19e81a175d
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Fri Dec 28 16:08:50 2018 +0800
glusterd: fix memory leak in handshake
Add missing unref to req_dict to fix memory leak in handle of
handshake.
Change-Id: I0d8573fc3668c1a0ccc9030e3a096bbe20ed5c36
fixes: bz#1663077
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit eefb2f46b91455328984fc2e2a189bfca891b123
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Jan 2 12:29:53 2019 +0530
glusterd: kill the process without releasing the cleanup mutex lock
Problem:
glusterd acquires a cleanup mutex lock before it starts
cleanup process, so that any other thread which tries to acquire
lock on any resource will be blocked on cleanup mutex lock.
We don't want any thread to try to acquire any resource, once
the cleanup is started. because other threads might try to acquire
lock on resources which are already freed by the thread which is
going though the cleanup phase.
previously we were releasing the cleanup mutex lock before the
process exit. As we are releasing the cleanup mutex lock, before
the process can exit some other thread which is blocked on
cleanup mutex lock is acquiring the cleanup mutex lock and
trying to acquire some resources which are already freed as a
part of cleanup. This is leading glusterd to crash.
Solution: We should exit the process without releasing the
cleanup mutex lock.
Change-Id: Ibae1c62260f141019017f7a547519a5d38dc2bb6
fixes: bz#1654270
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit f3c7a7f3853c3e5ab7af7b1437c8849feb716dec
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Dec 26 15:24:49 2018 +0530
gfapi: nit cleanup related to releasing fs->mutex lock
This is follow-up patch to the comment received for
- https://review.gluster.org/#/c/glusterfs/+/21882
We need not hold the fs->mutex lock to log error message.
Change-Id: I29d2ea2e6cfecc3dd94982bd48f4bc9f11cc3aac
fixes: bz#1660577
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 6b0cab14ca04d71ee87cb5a4f76fb2944d702ec1
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Dec 28 13:04:36 2018 +0530
libgfapi : fix coverity issue
This patch fixes coverity issue in api/src/glfs-fops.c.
CID: 1389247, 1389296, 1389369, 1389392.
All coverity defects are of type Mixing enum types (MIXED_ENUMS).
updates: bz#789278
Change-Id: I007bb317ed5f0b8ddaf94a93b3a4d02b1e74cb8d
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit e7e0a97b437891558194d4ec13fe84556790764d
Author: Harpreet Kaur <hlalwani@redhat.com>
Date: Thu Dec 27 20:20:56 2018 +0530
posix: buffer_size_warning coverity fix
Defect: CID 1398469- Calling strncpy with a maximum size argument
of 4096 bytes on destination array key of size 4096 bytes might
leave the destination string unterminated.
Fix: Using snprintf instead of strncpy.
updates: bz#789278
Change-Id: I4fdcd0cbf3af8b2ded94603d92d1ceb4112284c4
Signed-off-by: Harpreet Kaur <hlalwani@redhat.com>
commit ca019d27344caaabc461ca2e885e43aa443a840e
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Dec 28 09:56:20 2018 +0530
multiple-files: clang-scan fixes
updates: bz#1622665
Change-Id: I9f3a75ed9be3d90f37843a140563c356830ef945
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 84c5fa697209479deb33b683d0faa4f553e4f4a4
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Nov 15 22:05:32 2018 +0200
libglusterfs/src/mem-types.h: remove unused common enums from mem-types.h
They were not used at all, just taking space.
I've also marked all those that are not common really, but used
in just one place - they probably should move there (in follow-up
patches)
As a test, I've removed from the stripe xlator unused private
enums and moved one that was in the common list, but only
used in the stripe code, to be a private enum.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I1158dc1d259f1fd3f69904336c46c9d83cea799f
commit d4b2c9dc17b351c26fb765884e47ee735ddb8784
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Sep 28 23:20:28 2018 +0530
configure: add a message about asan option
This added hint helps to get ASan logs for the daemon processes, with
this one can start using asan for regression tests.
updates: bz#1633930
Change-Id: I3b39892d45d29ae514dad8ab10f65703c02003f1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit dbfe9fff9d946a4644df02b132c644e3819805f3
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Thu Dec 13 17:59:20 2018 +0530
glusterd: NULL pointer dereferencing clang fix
Added ternary operator to avoid this issue
Updates: bz#1622665
Change-Id: I163d0628304a0d61249d1d97a4a3d3bee4ba4927
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 2da8d552729f1385a86cdc0a6736b175a9ad0af6
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Fri Dec 21 03:59:16 2018 +0530
mgmt/glusterd: fix clang warning
Attempt to free rsp.dict.dict_val twice
Change-Id: I5dbc50430f59ca8d0c739b0fbe95d71981852889
Updates: bz#1622665
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 7c613321bdc3539c0bdefbd3db8234cf57a4a57e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 18 14:38:22 2018 +0530
cluster/afr: Refactor internal locking code to allow multiple inodelks
For implementing copy_file_range fop, AFR needs to perform two inodelks in the
same transaction. This patch brings in the necessary structure to make it
easier to do so.
Entry-locks in AFR were already taking multiple entry-locks on different inodes
with the respective basenames. This patch extends the logic in inodelks to use
the same lockee_t structure. This lead to removal of quite a lot of duplicate
code present in afr-lk-common.c as both the locks are doing same things except
'winding' part.
updates: #536
Change-Id: Ibfce7e3f260bb27b18645152ec680c33866fe0ae
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 1b5eee1aba30bd8f4728a1ac4524dac3afdb6340
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Fri Dec 28 10:44:32 2018 +0530
rpc/rpc-lib: fix coverity issue
Defect: Code can never be reached because of the
condition queue_index > 1024 cannot be true.
CID: 1398471 Logically dead code
updates: bz#789278
Change-Id: I367cda7e734f6d774900a58d8664cffcab69126f
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 60406372e063d0bb14cb7ca9e9700873f34e0225
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Dec 28 08:38:24 2018 +0530
rpc : fix coverity in rpc/rpc-lib/src/rpcsvc.c
This patch fixes newly introduced coverity.
CID: 1398472: Dereference before null check.
updates: bz#789278
Change-Id: Ie9b13084097de8f24b138acd7608c3e15b3bba9c
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 5840778b2cd859ece7e529e2787739ec2635101e
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Dec 27 13:21:57 2018 +0100
barrier: replace boolean-switch statement with if/else
Squash some ugly warnings, and make the code a little bit simpler by
removing some unneeded goto jumps.
On Ubuntu 16.04 the following warnings were reported by Amudhan:
CC barrier.lo
barrier.c: In function ‘notify’:
barrier.c:499:33: warning: switch condition has boolean value [-Wswitch-bool]
switch (past) {
^
barrier.c: In function ‘reconfigure’:
barrier.c:565:25: warning: switch condition has boolean value [-Wswitch-bool]
switch (past) {
^
Change-Id: Ifb6b75058dff8c789b729c76530a1358d391f4d1
Updates: bz#1193929
Reported-by: Amudhan P <amudhan83@gmail.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit ce3bd1fbab8078949799e77908ed7b59416be002
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Dec 27 14:54:28 2018 +0530
glusterd: coverity fixes
This patch addresses coverity issues with CID 1398470 and 1398475
1398470 - Missing unlock - False positive, Added a annotation to
make coverity happy
1398475 - Unused value
Change-Id: I1bb3df0b716690fad8fc52c393c8b2b6c41f7860
updates: bz#789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit d87038ea1e159d36085c678b66eecb7bb3e81e08
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Oct 23 18:03:45 2018 +0530
cluster/ta: Check number/type of locks held on ta file
Change-Id: Iec47856ce2819e7d7d38a60279602e53ba45858d
updates: bz#1624332
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 1348c0d592ad4ab383d0806f925cffa900ac636c
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Dec 26 11:40:26 2018 +0530
core: Fixed typos in nl-cache and logging-guidelines.md
Replaced "recieve" with "receive".
Change-Id: I58a3d3d4a0093df4743de9fae4d8ff152d4b216c
fixes: bz#1662089
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 9c1704fef29acef8a9c8c3e8f5e1a1d6703c7b8c
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Dec 6 19:25:06 2018 +0530
cluster/dht: refactor dht_lookup_cbk
Rearrange the dht_lookup_cbk code to make
it easier to understand.
Corrected a message in dht_linkfile_create_lookup_cbk
Change-Id: Id41db9ef901732f0410f1c007807362c630218ff
fixes: bz#1590385
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 9f091783994b7b8388214abc4913ff0d3b8852ca
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Dec 21 09:58:16 2018 +0530
socket: Remove redundant in_lock in incoming message handling
A given epoll thread can handle only one incoming (POLLIN) request.
And until the socket is rearmed for listening, it is guaranteed that
there won't be any new incoming requests. As a result, the priv->in_lock
which guards the socket proto state machine seems redundant.
This patch removes priv->in_lock.
Change-Id: I26b6ddd852aba8c10385833b85ffd2e53e46cb8c
updates: bz#1467614
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 43722d60c4a55a059b9265ca00dcd31033e6b145
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Dec 20 02:41:17 2018 +0530
cli: fix memory leak
This patch fixes memory leak in cli/src/cli.c.
Change-Id: I4956c4180b34d4a9e3e6e60eeafba8cb2031896e
updates: bz#1633930
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 1657420c768291c328a13067e9a7e6e71a1bf955
Author: Harpreet Kaur <hlalwani@redhat.com>
Date: Fri Dec 14 13:12:26 2018 +0530
posix: stack-buffer-overflow reported by asan
This patch fixes buffer overflow in
$SRC/xlators/storage/posix/src/posix-inode-fd-ops.c
Memory access at offset 432 overflows "md5_checksum" variable.
SUMMARY: AddressSanitizer: stack-buffer-overflow (/lib64/libasan.so.5+0xb825a)
updates: bz#1633930
Change-Id: I46010a09161d02cdf0c69679a334ec1d3d49cffb
Signed-off-by: Harpreet Kaur <hlalwani@redhat.com>
commit f3583278536ac9e7dca23fe6a9000a56ab2f05e0
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Dec 18 22:07:55 2018 +0530
gfapi: Access fs->oldvolfile under mutex lock
In some cases (for eg., when there are multiple
RPC_CLNT_CONNECT notifications), multiple threads may fetch
volfile and try to update it in 'fs' object simultaneously.
Hence protect those variables' access under fs->mutex lock.
Change-Id: Idaee9548560db32d83f4c04ebb1f375fee7864a9
fixes: bz#1660577
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 25512ac5b19851abeb0fa13d7a32ed3ca844c0bc
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Dec 21 23:50:00 2018 +0530
meta : fix coverity issue
This patch fixes coverity issue possible null dereference.
Change-Id: I93c0847c3d93b29a1e001ed044a63e908c670167
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 9708266ee6b3df92ee762063e90c58d8b9c82620
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Dec 20 16:41:37 2018 +0530
tests: Brick is getting OOM in ./tests/bugs/core/bug-1432542-mpx-restart-crash.t
This test "tests/bugs/core/bug-1432542-mpx-restart-crash.t" case creates 20 2x3
volumes after enabling brick_mux.At the time of creating last volume brick is getting
OOM because brick consumption has increased from previous consumption due to these patches
https://review.gluster.org/#/c/glusterfs/+/19997/,
https://review.gluster.org/#/c/glusterfs/+/20362/
To avoid OOM reduce NUM_VOLS to 15 so that brick consumption has reduced
Change-Id: Ib98b47a3db6b990ff22c7e57396d51e7fef5c7e8
fixes: bz#1661214
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 7348f9d0d03398864ee5c58deb0fbf6e9d7240f5
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Dec 19 08:14:44 2018 +0530
rpc: Use adaptive mutex in rpcsvc_program_register
Adaptive mutexes are used to protect critical/shared data items that
are held for short periods.It provides a balance between spin locks
and traditional mutex.We have observed after use adaptive mutex in
rpcsvc_program_register got some improvement.
Change-Id: I7905744b32516ac4e4ca3c83c2e8e5e306093add
fixes: bz#1660701
commit 71b6d3feaa58221c06e3337326d0d6c510851fbd
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Dec 19 10:25:44 2018 +0530
all: handle string-overflow warnings of coverity
updates: bz#789278
Change-Id: I7de800b90a614e3666e965b0cafc70026a844b2d
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit cf3dc51375dbfc50d8aaef49b810266c87031f6a
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Dec 19 09:45:42 2018 +0530
all: handle USE_AFTER_FREE warnings
* we shouldn't be using 'local' after DHT_STACK_UNWIND() as it frees
the content of local. Add a 'goto out' or similar logic to handle
the situation.
* fix possible overlook of unref(dict), instead of unref(xdata).
* make coverity happy by re-ordering unref in meta-defaults.
* gfid-access: re-order dictionary allocation so we don't have to
do a extra unref.
* other obvious errors reported.
updates: bz#789278
Change-Id: If05961ee946b0c4868df19861d7e4a927a2a2489
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 936747bbb7ccdeac14a400e7b256654cdf2468f2
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Dec 19 17:57:58 2018 +0530
tests: Fix zero-flag.t script
The default value of shard-block-size was changed from 4MB
to 64MB sometime back. The script "fallocate"s a 6MB file
and expects it to have 1 shard under .shard. This worked when
the shard-block-size was 4MB. With the default value now at 64MB,
file "file1" won't have any shards under .shard and the stat on the
1st shard's path fails with ENOENT.
Changed the script to explicitly set shard-block-size to 4MB.
Change-Id: I7f1785922287d16d74c95fa57cbbe12e6e66e4f7
fixes: bz#1656264
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 81e9895ccdb1e598b6422df1124ad1b2a341b137
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Aug 16 16:36:08 2018 +0530
posix: use synctask for janitor
With brick mux, the number of threads increases as the number of
bricks increases. As an initiative to reduce the number of
threads in brick mux scenario, replacing janitor thread to use
synctask infra.
Now close() and closedir() handle by separate janitor
thread which is linked with glusterfs_ctx.
Updates #475
Change-Id: I0c4aaf728125ab7264442fde59f3d08542785f73
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 4b44e432fe4cf3572021cc1e69144c7fee85df2b
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Mon Dec 17 19:55:20 2018 +0530
rdma: fix possible buffer overflow
used snprintf instead of sprintf and if the source string is bigger
than destination then logged a warning message.
clang warning: ‘%s’ directive writing up to 1024 bytes into a region
of size 108.
updates: bz#1622665
Change-Id: Ia5e7c53d35d8178dd2c75708698599fe8bded5de
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit b94080e650fd4fa1050193d6e9bf00492dbb216d
Author: karthik-us <ksubrahm@redhat.com>
Date: Tue Dec 4 11:19:27 2018 +0530
cluster/afr: Allow lookup on root if it is from ADD_REPLICA_MOUNT
Problem: When trying to convert a plain distribute volume to replica-3
or arbiter type it is failing with ENOTCONN error as the lookup on
the root will fail as there is no quorum.
Fix: Allow lookup on root if it is coming from the ADD_REPLICA_MOUNT
which is used while adding bricks to a volume. It will try to set the
pending xattrs for the newly added bricks to allow the heal to happen
in the right direction and avoid data loss scenarios.
Note: This fix will solve the problem of type conversion only in the
case where the volume was mounted at least once. The conversion of
non mounted volumes will still fail since the dht selfheal tries to
set the directory layout will fail as they do that with the PID
GF_CLIENT_PID_NO_ROOT_SQUASH set in the frame->root.
Change-Id: Ic511939981dad118cc946754341318b164954b3b
fixes: bz#1655854
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit fa512583c2324dd8f7b9069844e45be59f8aedf5
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Nov 21 12:09:39 2018 +0530
iobuf: Get rid of pre allocated iobuf_pool and use per thread mem pool
The current implementation of iobuf_pool has two problems:
- prealloc of 12.5MB memory, this limits the scale factor of the gluster
processes due to RAM requirements
- lock contention, as the current implementation has one global
iobuf_pool lock. Credits for debugging and addressing the same goes to
Krutika Dhananjay <kdhananj@redhat.com>. Issue: #410
Hence changing the iobuf implementation to use per thread mem pool.
This may theoritically appear to cause perf dip as there is no preallocation.
But per thread mem pool will not have significant perf impact as the last
allocated memory is kept alive for subsequent allocs, for some time.
The worst case would be if iobufs requested are of random sizes each time.
The best case is, if we get iobuf request of the same size. From the perf
tests, this patch did not seem to cause any perf decrease.
Note that, with this patch, the rdma performance is going to degrade
drastically. In one of the previous patchsets we had fixes to not
degrade rdma perf, but rdma is not supported and also not tested [1].
Hence the decision was to not have code in rdma that is not tested
and not supported.
[1] https://lists.gluster.org/pipermail/gluster-users.old/2018-July/034400.html
Updates: #325
Change-Id: Ic2ef3bd498f9250dea25f25ba0c01fde19584b27
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 97d1cb602f68a58c9101dfa82a775a3b1b6fcb47
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Fri Oct 12 10:03:31 2018 +0530
performance/io-cache: update pages with write data
Currently io-cache invalidate pages falling in the range of write. But
instead it can update pages with same data so that reads can make use
of the cache.
credits: Xavi Hernandez <xhernandez@redhat.com>
Change-Id: I932bd3da97ddfd464187f3009b1013eb334f00a7
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
updates: bz#1659869
commit 39bda221b0194cdb22221f3ec2cd6f85cb4262aa
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Fri Dec 14 11:27:33 2018 +0530
performance/ob: make open-behind as a child of quick-read
With read-after-open being set to yes by default, if open-behind sees
any reads, it'll do an open on backend (and hence flush/release
later). This means with the current order of quick-read and
open-behind, open-behind sees all reads and hence also does open
bringing down performance for small file reads.
Since for small files, reads are absorbed by quick-read, if quick-read
is made a parent of open-behind, ob doesn't witness any reads. For
read-only workloads, this means ob doen't do any opens (even with
read-after-open yes and use-anonymous-fd no).
Change-Id: I138a42b006d104cff43ee6f07829e39c36f6f234
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
Fixes: bz#1659327
commit 22bc91850f36bdf050631dc537d7289ca040a73d
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Dec 14 19:18:20 2018 +0200
xlators/cluster/afr/src/afr-self-heal-common.c: remove a variable array.
Added '-Wvla' and saw this - gcc doesn't like variable arrays.
There are plenty of others in the EC code, but this seems OK to remove:
there is no use for the array members (I hope - that was from reading
the code).
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I350f4520e52b86c8bbcd60eea1b27ef99cd119aa
commit a6444c3be02ffb1aebee6848b8e7cbabf7ddc9fc
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Dec 17 09:17:44 2018 +0530
glusterd: define max-port to 60999
As glusterd scans through all the ports in its defined range, with RHEL
7.3 onwards any port beyond 60999 isn't within the ephemeral port range
and following AVC denial message is seen.
type=AVC msg=audit(1471946614.154:109): avc: denied { name_bind } for
pid=2302 comm="glusterd" src=61000 scontext=system_u:system_r:glusterd_t:s0
tcontext=system_u:object_r:ephemeral_port_t:s0 tclass=tcp_socket
Fix is to define the max port range to 60999 in glusterd.vol file. The
port range can be tweaked through a reconfigure of this configuration
file though.
Fixes: bz#1659857
Change-Id: I60fd4a421d8509b8dca4ca13b73999ae33965f72
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 9047c15bfe599858f4061c730a938e7d9ed31d0b
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Nov 30 16:16:55 2018 +0530
glusterd: migrating rebalance commands to mgmt_v3 framework
Current rebalance commands use the op_state machine framework.
Porting it to use the mgmt_v3 framework.
Change-Id: I6faf4a6335c2e2f3d54bbde79908a7749e4613e7
fixes: bz#1655827
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit e372147e231e09311457bfd122030d42ca3325d1
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Nov 21 10:01:08 2018 +0530
mem-pool: Add api to mem_get based on requested size
Currently mem-pool implementation provides api to get from the
mem pool based on the struct type. This is to retain api
compatibility with the old implementation of mem pool. Internally
in the mem pool structure there is a mapping from struct to size
based pools.
In this patch, we are adding new APIs to fetch memory from mem pool,
given a size.
Change-Id: Ib220ee45ebd134a7be8f6482db5a592dbb7b9211
Updates: #325
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit df6f9f7a6071808f530c702b27c8583b01bee0cf
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Dec 17 14:07:27 2018 +0530
geo-rep : fix slave volume read-only option
Problem: When separate ssh key is given for non root user setting slave volume
read-only option results in failure.
Solution: Check for extra param in case separate key is given for non-root user
and take action accordingly.
Change-Id: Iafe9a2aa6b86cde1dcd7d63771048a6ae33c2cde
fixes: bz#1659971
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 45c922b6f64b3f89113a81921b97f402aa0772c1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Dec 2 15:35:09 2018 +0530
Don't depend on string options to be valid always
updates bz#1650403
Change-Id: Ib5a11e691599ce4bd93c1ed5aca6060592893961
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 95c68d520a0f4ff963683edbc0bf57d2c64ecdd4
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Dec 3 11:23:20 2018 -0500
features/snapview-client: access priv->path inside lock
To handle the race condition of a fop or a function accessing priv->path
and a reconfigure changing priv->path (because entry point directory
changed), the private structure's path is guarded by the lock.
updates bz#1650403
Change-Id: I61c539da06d68d38eafcf2155699c7702f31323e
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 07f21a550aa7daba78f863dd124970c1f60f0220
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Sep 13 16:03:23 2018 +0300
AFR xlator: use dict_{setn|getn|deln|get_int32n|set_int32n|set_strn}
In a previous patch (https://review.gluster.org/20769) we've
added the key length to be passed to dict_* funcs, to remove the need
to strlen() it. This patch moves some xlators to use it.
- In some cases, moved strlen() of the key length outside of locks,
which is usually a good thing. Please verify it's safe to do so.
- In some cases, created a prefix for the keys, replacing something like
"%d-%d" with a "%s" in snprintf(). Not sure it adds value, but improves
readability.
Please review carefully.
Compile-tested only!
Change-Id: I04f2a1eb2ecfc3283d849d150d10d088ae7aa7f1
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 6f8aa0e6702c12fad403b22740f7c852cf3cf2c2
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Dec 12 12:10:44 2018 +0530
selinux/glusterd : add "features.selinux" to glusterd-volume-set.c
Fixes: bz#1659868
Change-Id: I38675ba4d47c8ba7f94cfb4734692683ddb3dcfd
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit 1274903671f5be70bdaace280d9050b752c62b82
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Dec 5 17:27:07 2018 +0530
cluster/afr: Fix mem leak reported by ASAN
Traceback:
Direct leak of 765 byte(s) in 9 object(s) allocated from:
#0 0x7ffb9cad2c48 in malloc (/lib64/libasan.so.5+0xeec48)
#1 0x7ffb9c5f8949 in __gf_malloc ./libglusterfs/src/mem-pool.c:136
#2 0x7ffb9c5f91bb in gf_vasprintf ./libglusterfs/src/mem-pool.c:236
#3 0x7ffb9c5f938a in gf_asprintf ./libglusterfs/src/mem-pool.c:256
#4 0x7ffb826714ab in afr_get_heal_info ./xlators/cluster/afr/src/afr-common.c:6204
#5 0x7ffb825765e5 in afr_handle_heal_xattrs ./xlators/cluster/afr/src/afr-inode-read.c:1481
#6 0x7ffb825765e5 in afr_getxattr ./xlators/cluster/afr/src/afr-inode-read.c:1571
#7 0x7ffb9c635af7 in syncop_getxattr ./libglusterfs/src/syncop.c:1680
#8 0x406c78 in glfsh_process_entries ./heal/src/glfs-heal.c:810
#9 0x408555 in glfsh_crawl_directory ./heal/src/glfs-heal.c:898
#10 0x408cc0 in glfsh_print_pending_heals_type ./heal/src/glfs-heal.c:970
#11 0x408fc5 in glfsh_print_pending_heals ./heal/src/glfs-heal.c:1012
#12 0x409546 in glfsh_gather_heal_info ./heal/src/glfs-heal.c:1154
#13 0x403e96 in main ./heal/src/glfs-heal.c:1745
#14 0x7ffb99bc411a in __libc_start_main ../csu/libc-start.c:308
The dictionary is referenced by caller to print the status.
So set it as dynstr, the last unref of dictionary will free it.
updates: bz#1633930
Change-Id: Ib5a7cb891e6f7d90560859aaf6239e52ff5477d0
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit e4af87b286574aea965a21c915c4857788ad0f72
Author: ShyamsundarR <srangana@redhat.com>
Date: Fri Dec 14 16:57:01 2018 -0500
dht: Fix clang warnings in dht-common.c
Change-Id: I0894d62edd68e13d123aaa5ca1827b98283f0d3e
Updates: bz#1622665
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 0fcb20376bc554177ceb64e0561a48122c5d39a5
Author: Csaba Henk <csaba@redhat.com>
Date: Mon Oct 22 00:59:05 2018 +0200
fuse: SETLKW interrupt
Use the (f)getxattr based clearlocks interface to
interrupt a pending lock request.
updates: #465
Change-Id: I4e91a4d8791fc688fed400a02de4c53487e61be2
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 06982c48f9a47ce8e06ab98b449dfe6bcdf9d7e0
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Oct 16 16:31:49 2018 +0530
fuse: add --lru-limit option
The inode LRU mechanism is moot in fuse xlator (ie. there is no
limit for the LRU list), as fuse inodes are referenced from
kernel context, and thus they can only be dropped on request of
the kernel. This might results in a high number of passive
inodes which are useless for the glusterfs client, causing a
significant memory overhead.
This change tries to remedy this by extending the LRU semantics
and allowing to set a finite limit on the fuse inode LRU.
A brief history of problem:
When gluster's inode table was designed, fuse didn't have any
'invalidate' method, which means, userspace application could
never ask kernel to send a 'forget()' fop, instead had to wait
for kernel to send it based on kernel's parameters. Inode table
remembers the number of times kernel has cached the inode based
on the 'nlookup' parameter. And 'nlookup' field is not used by
no other entry points (like server-protocol, gfapi etc).
Hence the inode_table of fuse module always has to have lru-limit
as '0', which means no limit. GlusterFS always had to keep all
inodes in memory as kernel would have had a reference to it.
Again, the reason for this is, kernel's glusterfs inode reference
was pointer of 'inode_t' structure in glusterfs. As it is a
pointer, we could never free it (to prevent segfault, or memory
corruption).
Solution:
In the inode table, handle the prune case of inodes with 'nlookup'
differently, and call a 'invalidator' method, which in this case is
fuse_invalidate(), and it sends the request to kernel for getting
the forget request.
When the kernel sends the forget, it means, it has dropped all
the reference to the inode, and it will send the forget with the
'nlookup' parameter too. We just need to make sure to reduce the
'nlookup' value we have when we get forget. That automatically
cause the relevant prune to happen.
Credits: Csaba Henk, Xavier Hernandez, Raghavendra Gowdappa, Nithya B
fixes: bz#1560969
Change-Id: Ifee0737b23b12b1426c224ec5b8f591f487d83a2
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit ccb9ecb5e8f2f3f40e2beb1d0273ba675365a72b
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Dec 14 16:42:26 2018 +0530
performance/rda: Fixed dict_t memory leak
Removed all references to dict_t xdata_from_req which is
allocated but not used anywhere. It is also not cleaned up
and hence causes a memory leak.
Change-Id: I2edb857696191e872ad12a12efc36999626bacc7
fixes: bz#1659432
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 36b00eec10e68ba3f1b95842471e8244a60cea6c
Author: Iraj Jamali <ijamali@redhat.com>
Date: Fri Nov 23 01:58:44 2018 +0530
glusterfsd: Fix coverity issue
Problem reported: value assigned to a variable is never used
Fixes CID : 1274230
updates: bz#789278
Change-Id: I7afcb411876dea81c6820c5b31ae0a2896f9ca15
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit 5889dbb7616e770c50402a1495728d0cd10df9a6
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Dec 6 15:05:20 2018 +0530
extras: New group volume set command for Samba integration
# gluster volume set <VOLNAME> group samba
List of volume set options from group-samba are aimed at improving the below
workloads which consumes time and network hops in SMB world:
* Listing of large directories
* Negative lookups during creation of files
Caching the necessary metadata required for these workloads saves us time and
network hops. On the other side we have to ensure correctness(avoiding stale
cache) in caching(via md-cache) with the help of cache invalidation in an
environment where multiple client access is expected.
Change-Id: Icdd2d8e5eb290e12bc509105418c668f432f4eae
fixes: bz#1656771
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit f80ca98a113ae6144205d83ad98b19bdf6f9db00
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Dec 6 16:13:46 2018 +0100
locks: handle "clear locks" xattr in fgetxattr too
The lock clearing procedure was kicked in only in
getxattr context. We need it to work the same way
if it's triggered via fgetxattr (as is the case
with interrupt handling).
Also cleaned up the instrumentation a bit (more logs,
proper management of allocated data).
updates: #465
Change-Id: Icfca26ee181da3b8e15ca3fcf61cd5702e2730c8
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 89275ce3516248ac2382c04c617c06d124eccc79
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Dec 2 23:19:46 2018 +0200
Multiple posix related files: several modifications
Just looked at posix.c and related code and performed
some changes and cleanups. The only important one is #3 below,
but surely the others (#2 and #4) need careful review.
Changes to other files are as they were related to code paths
in posix.c.
I'll send a separate patch for other posix related files.
Main changes:
1. Proper initializtion for parameters, where it made sense.
2. Logged outside the lock in several places.
3. Moved from CALLOC to MALLOC where it made sense.
4. Aligned structures.
5. moved dictionary functions to use _sizen where possible.
(dict_get() -> dict_get_sizen() for example)
Compile-tested only!
Change-Id: Ia84699fb495e06d095339c91c1ba770d1393bb6c
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 4e54a3ebebec56baefe97a47ac89629265102853
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Mon Dec 10 18:02:19 2018 +0530
cli: variable-length array declaration clang fix
Problem: Declared variable-length array can have zero size
Added a goto statement to address this issue.
Updates: bz#1622665
Change-Id: Ibf80643490367a5f7e50f66f87e4296380be45de
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit a99e143a3ab601d5791bd7569b4fd22c0be639c3
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Thu Dec 13 11:14:10 2018 +0530
cluster/ec: NULL pointer deferencing clang fix
Removing VALIDATE_OR_GOTO check on "this"
Change-Id: I154deaca5302b41c1cafd87077de880dd03ec613
Updates: bz#1622665
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit ce574823bcb00a93539accdcd9732bf894c46973
Author: ShyamsundarR <srangana@redhat.com>
Date: Wed Dec 12 16:45:09 2018 -0500
clang: Fix various missing checks for empty list
When using list_for_each_entry(_safe) functions, care needs
to be taken that the list passed in are not empty, as these
functions are not empty list safe.
clag scan reported various points where this this pattern
could be caught, and this patch fixes the same.
Additionally the following changes are present in this patch,
- Added an explicit op_ret setting in error case in the
macro MAKE_INODE_HANDLE to address another clang issue reported
- Minor refactoring of some functions in quota code, to address
possible allocation failures in certain functions (which in turn
cause possible empty lists to be passed around)
Change-Id: I1e761a8d218708f714effb56fa643df2a3ea2cc7
Updates: bz#1622665
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 8d2bd96228a9c0a4ddb23eaf4b121d7ff58eecc3
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Dec 6 12:29:25 2018 +0530
all: remove code which is not being considered in build
These xlators are now removed from build as per discussion/announcement
done at https://lists.gluster.org/pipermail/gluster-users/2018-July/034400.html
* move rot-13 to playground, as it is used only as demo
purpose, and is documented in many places.
* Removed code of below xlators:
- cluster/stripe
- cluster/tier
- features/changetimerecorder
- features/glupy
- performance/symlink-cache
- encryption/crypt
- storage/bd
- experimental/posix2
- experimental/dht2
- experimental/fdl
- experimental/jbr
updates: bz#1635688
Change-Id: I1d2d63c32535e149bc8dcb2daa76236c707996e8
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 67bbd5471a05fe54af2e57b03560fbc2d4569e40
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Dec 6 16:24:52 2018 +0530
xlator: make 'xlator_api' mandatory
* Remove the options to load old symbol.
* keep only 'xlator_api' symbol from being exported using xlator.sym
* add xlator_api to all the xlators where its missing
NOTE: This covers all the xlators which has at least a test case
to validate its loading. If there is a translator, which doesn't
have any test, then we should probably remove that from codebase.
fixes: #164
Change-Id: Ibcdc8c9844cda6b4463d907a15813745d14c1ebb
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7fd7f81ea20ed94a5e9f4cd1eb6cb9e0ee1614c1
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Dec 11 16:20:58 2018 +0530
symlink-cache: remove from the build
symlink-cache was written as an experiment to reduce the load
on 'build' systems, which keep doing symlink resolution to get
the proper header files. But since last 6+ years, there was no
way to add it to the volfile using gluster cli, and hence was
not supported anymore. As it is not maintained, and as announced
on [1], we are planning to remove it from the build system.
[1]- https://lists.gluster.org/pipermail/gluster-users/2018-July/034400.html
updates: bz#1635688
Change-Id: Iaa25069bceed04cf65f79a4b4a02c05cee848eb5
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 31b4b08576fff2e62174a6cb5ef87065c2d353d8
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri Nov 23 09:39:43 2018 +0530
Worker still ACTIVE after killing bricks
Problem: In changelog xlator after destroying listener it call's
unlink to delete changelog socket file but socket file
reference is not cleaned up from process memory
Solution: 1) To cleanup reference completely from process memory
serialize transport cleanup for changelog and then
unlink socket file
2) Brick xlator will notify GF_EVENT_PARENT_DOWN to next
xlator only after cleanup all xprts
Test: To test the same run below steps
1) Setup some volume and enable brick mux
2) kill anyone brick with gf_attach
3) check changelog socket for specific to killed brick
in lsof, it should cleanup completely
fixes: bz#1600145
Change-Id: Iba06cbf77d8a87b34a60fce50f6d8c0d427fa491
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 283853248e97a2c136b25ed1282fda58e9f2da14
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Dec 11 15:32:03 2018 +0530
afr: some minor itable related cleanups
- this->itable always needs to be allocated, hence move it outside
afr_selfheal_daemon_init().
- Invoke afr_selfheal_daemon_init() only for self-heal daemon case.
- remove redundant itable allocation in afr_discover().
- destroy itable in fini.
Updates bz#1193929
Change-Id: Ib28b50b607386f5a5aa7d2f743c8b506ccb10eae
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit f6c415fca438d93c411f451ca22ac345f4c9b07f
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Nov 21 14:33:53 2018 +0530
rpc: Resolve memory leak in mgmt_pmap_signout_cbk
Problem: At the time of submit signout request to mgmt
rpc_clnt_mgmt_pmap_signout create a frame but in cbk
frame is not destroyed
Solution: cleanup frame in mgmt_pmap_signout_cbk to avoid leak
Change-Id: I9961cacb2e02c8023c4c99e22e299b8729c2b09f
fixes: bz#1658045
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit a6fa15cf31793ff6c08899e4b0dc763aedd2fe1f
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Dec 12 09:23:11 2018 +0530
core: move invalid port logs to DEBUG log level
Stop spamming "invalid port" logs in case sysadmin has reserved a large
number of ports.
Change-Id: I244ef7693560cc404b36cadc6b05d92ec0e908d3
fixes: bz#1656517
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 9fda5e5aac797ae1561c2bde30c3fa08ae807001
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Nov 6 15:27:31 2018 -0500
copy_file_range support in GlusterFS
* libglusterfs changes to add new fop
* Fuse changes:
- Changes in fuse bridge xlator to receive and send responses
* posix changes to perform the op on the backend filesystem
* protocol and rpc changes for sending and receiving the fop
* gfapi changes for performing the fop
* tools: glfs-copy-file-range tool for testing copy_file_range fop
- Although, copy_file_range support has been added to the upstream
fuse kernel module, no release has been made yet of a kernel
which contains the support. It is expected to come in the
upcoming release of linux-4.20
So, as of now, executing copy_file_range fop on a fused based
filesystem results in fuse kernel module sending read on the
source fd and write on the destination fd.
Therefore a small gfapi based tool has been written to be able
test the copy_file_range fop. This tool is similar (in functionality)
to the example program given in copy_file_range man page.
So, running regular copy_file_range on a fuse mount point and
running gfapi based glfs-copy-file-range tool gives some idea about
how fast, the copy_file_range (or reflink) can be.
On the local machine this was the result obtained.
mount -t glusterfs workstation:new /mnt/glusterfs
[root@workstation ~]# cd /mnt/glusterfs/
[root@workstation glusterfs]# ls
file
[root@workstation glusterfs]# cd
[root@workstation ~]# time /tmp/a.out /mnt/glusterfs/file /mnt/glusterfs/new
real 0m6.495s
user 0m0.000s
sys 0m1.439s
[root@workstation ~]# time glfs-copy-file-range $(hostname) new /tmp/glfs.log /file /rrr
OPEN_SRC: opening /file is success
OPEN_DST: opening /rrr is success
FSTAT_SRC: fstat on /rrr is success
copy_file_range successful
real 0m0.309s
user 0m0.039s
sys 0m0.017s
This tool needs following arguments
1) hostname
2) volume name
3) log file path
4) source file path (relative to the gluster volume root)
5) destination file path (relative to the gluster volume root)
"glfs-copy-file-range <hostname> <volume> <log file path> <source> <destination>"
- Added a testcase as well to run glfs-copy-file-range tool
* io-stats changes to capture the fop for profiling
* NOTE:
- Added conditional check to see whether the copy_file_range syscall
is available or not. If not, then return ENOSYS.
- Added conditional check for kernel minor version in fuse_kernel.h
and fuse-bridge while referring to copy_file_range. And the kernel
minor version is kept as it is. i.e. 24. Increment it in future
when there is a kernel release which contains the support for
copy_file_range fop in fuse kernel module.
* The document which contains a writeup on this enhancement can be found at
https://docs.google.com/document/d/1BSILbXr_knynNwxSyyu503JoTz5QFM_4suNIh2WwrSc/edit
Change-Id: I280069c814dd21ce6ec3be00a884fc24ab692367
updates: #536
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 102d556d5ff68e4d6ce812a7bffc7d05066b4b43
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Dec 10 18:13:19 2018 +0530
cluster/afr: Do not update read_subvol in inode_ctx after rename/link fop
Since rename/link fops on a file will not change any data in it, it should
not update the read_subvol values in the inode_ctx, which interprets the
data & metadata readable subvols for that file. The old read_subvol values
should be retained even after the rename/link operations.
Change-Id: I068044a426823a566f5bea8aa063cd689199d6dd
fixes: bz#1657783
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit dab1a5e7d3043d166ef8932086f9ac27daa24718
Author: Harpreet Kaur <hlalwani@redhat.com>
Date: Tue Dec 11 15:07:56 2018 +0530
tools: stack-buffer-overflow reported by asan
This patch fixes buffer overflow in $SRC/tools/setgfid2path/src/main.c
Memory access at offset 196 overflows "pgfid" variable
SUMMARY: AddressSanitizer: stack-buffer-overflow (/lib64/libasan.so.5+0x4e935)
updates: bz#1633930
Change-Id: Ib508c57e96c46b628f63c511437b853b39ae7955
Signed-off-by: Harpreet Kaur <hlalwani@redhat.com>
commit d87a035ee06929eb74460339b487881e83e0f660
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Thu Dec 6 15:04:55 2018 +0530
afr: Resource leak coverity fixes
Problem reported by Coverity: Leak of memory or pointers to
system resources.
Deallocate the memory pointed to by xattr_serz as the memory
reference is not stored anywhere.
Fixes CID: 1124760, 124787, 1382418
Change-Id: Ib9c2ef28c52e2d43de2552cfd959a98b26272bc1
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit 1e4ae7c8e317d8d5eab38ca56763886faf4b3020
Author: rishubhjain <rishubhjain47@gmail.com>
Date: Mon Dec 10 13:04:13 2018 -0500
write-behind/bit-rot: fix identifier
Rename the identifiers, bit-rot-server to bit-rot in bit-rot.c & write-ahead to
write-behind in write-behind.c to ensure GD2 understands the options
Change-Id: Id271ae97de2e54f4e30174482c4e1fb6afc728d3
Fixes: #164
Signed-off-by: rishubhjain <rishubhjain47@gmail.com>
commit 310cfcc3264e9e2b40442fdcbc60e2e955275d10
Author: Harpreet Kaur <hlalwani@redhat.com>
Date: Mon Dec 10 16:14:54 2018 +0530
nfs: memory leak issue reported by asan
This patch fixes Direct leaks in exports.c
Leaks are happening in exp_file_parse
SUMMARY: AddressSanitizer: 5120 byte(s) leaked in 20 allocation(s).
SUMMARY: AddressSanitizer: 512 byte(s) leaked in 4 allocation(s).
Updates: bz#1633930
Change-Id: Ib4474f8f6c65d737ed54ed35b4234410d1fd673e
Signed-off-by: Harpreet Kaur <hlalwani@redhat.com>
commit 4c1550c33c2b8171ec55c72f700dc391b333009d
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Dec 5 20:37:53 2018 +0530
encryption: remove crypt xlator from build
Based on the proposal to remove few features as they are not
actively maintained [1], removing crypt translator from the build.
[1] - https://lists.gluster.org/pipermail/gluster-users/2018-July/034400.html
Crypt xlator helped in on-disk / at-rest encryption of data. But
currently as there are no maintainers for this, planning to remove
it from master codebase. We are planning to host these experimental/
tech-preview xlators in another repository, so people who want to
contribute can still use the bits.
updates: bz#1635688
Change-Id: I7f2453907a595c34f635a88c49aab0845369c6e7
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 2f2061db8759d20b4d53c18885b2c6ad5fc2ca89
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Nov 26 14:40:00 2018 +0530
posix: posix_health_check_thread_proc crash due to priv is NULL
Problem: posix_fini sends a cancellation request to health_check
thread and cleanup priv without ensuring health_check thread
is running
Solution: Make health_check && disk_space thread joinable and call
gf_thread_cleanup_xint to wait unless thread is not finished
Change-Id: I4d37b08138766881dab0922a47ed68a2c3411f13
fixes: bz#1636570
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit f23e861e8f985ef7712d900a1e037159362ae762
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri Dec 7 12:35:20 2018 +0530
glusterd: Resolve memory leak in some glusterd functions
Problem: Functions allocate memory for req structure but after submit
request they missed to cleanup memory
Solution: After submit request cleanup allocated mmeory
Change-Id: I8f995787ed8986b882f008ccd588670b5d4139f5
updates: bz#1633930
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 8721f54902bd89e639482822e7109224521db8e4
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Dec 7 10:53:44 2018 +0530
cli : fix memory leak in cli-cmd-volume.c
This patch fixes ememory leak reported by ASan.
Tracebacks:
Direct leak of 84 byte(s) in 1 object(s) allocated from:
#0 0x7f71ea107848 in __interceptor_malloc (/lib64/libasan.so.5+0xef848)
#1 0x7f71e9e2ac49 in __gf_malloc ./libglusterfs/src/mem-pool.c:136
#2 0x7f71e9e2b4bb in gf_vasprintf ./libglusterfs/src/mem-pool.c:236
#3 0x7f71e9e2b68a in gf_asprintf ./libglusterfs/src/mem-pool.c:256
#4 0x41e8ec in cli_cmd_bitrot_cbk ./cli/src/cli-cmd-volume.c:1847
#5 0x410b39 in cli_cmd_process ./cli/src/cli-cmd.c:137
#6 0x40fe9d in cli_batch ./cli/src/input.c:29
#7 0x7f71e989558d in start_thread (/lib64/libpthread.so.0+0x858d)
updates: bz#1633930
Change-Id: I8977e45add742e67047291f398f0ee79eb09afe4
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 38ad4b50b6d898a9cc7803dd712d60206224ecd8
Author: Harpreet Kaur <hlalwani@redhat.com>
Date: Wed Nov 28 14:06:36 2018 +0530
geo-rep: Make slave volume read-only (by default)
Added a command to set "features.read-only" option
to a default value "on" for slave volume.
Changes are made in:
$SRC//extras/hook-scripts/S56glusterd-geo-rep-create-post.sh
for root geo-rep and
$SRC/geo-replication/src/set_geo_rep_pem_keys.sh
for non-root geo-rep.
Fixes: bz#1654187
Change-Id: I15beeae3506f3f6b1dcba0a5c50b6344fd468c7c
Signed-off-by: Harpreet Kaur <hlalwani@redhat.com>
commit 79c6ecfed3b190c0327fa313231f777fa5d5a380
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Dec 6 23:14:57 2018 +0530
glusterd: fix get_mux_limit_per_process to read default value
get_mux_limit_per_process () reads the global option dictionary and in
case it doesn't find out a key, assumes that
cluster.max-bricks-per-process option isn't configured however the
default value should be picked up in such case.
Change-Id: I35dd8da084adbf59793d58557e818d8e6c17f9f3
Fixes: bz#1656951
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 261c5457fe189883b9fb75935ebc0d01843b5feb
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Thu Dec 6 13:24:40 2018 +0530
performance/readdir-ahead: update stats from prefetched dentries
stats from prefetched dentries should be invalidated only if the
files pointed to those dentries were written in the window of
prefetching. Otherwise its safe to use these stats.
Change-Id: I9ea5aeea4c75dfa03387fca32c626cb4e693290d
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
Fixes: bz#1656348
commit cf6948d6dd726fd953b685b8338612816ebefdc8
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Dec 6 15:09:26 2018 +0530
New xlator option to control enable/disable of xlators in Gd2
Since glusterd2 don't maintain the xlator option details in code, it
directly reads the xlators options table from `*.so` files. To support
enable and disable of xlator new option added to the option table with
the name same as xlator name itself.
This change will not affect the functionality with glusterd1.
Change-Id: I23d9e537f3f422de72ddb353484466d3519de0c1
updates: #302
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit c5d1824e8f3ca952075b1e8402ebd6975e377403
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Dec 6 22:02:28 2018 +0530
cli: fix memory leak in cli rpc ops
Problem: In some of the cli fops dict_allocate_and_serialize
allocate memory for req structure but after submit
request it missed to cleanup memory fo req.dict.dict_val
Solution: Call GF_FREE for req.dict.dict_val after submit
cli request
Change-Id: I76c6b3082fa0be21dc595f87701550a318734ea5
updates: bz#1633930
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit c87ba9e7962ad6c1f66839586fefd6301c16c923
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Wed Dec 5 19:18:17 2018 +0530
cli: fix a memory leak reported by ASan.
Fixed a leak in cli_cmd_volume_remove_brick_cbk.
SUMMARY: AddressSanitizer: 1152 byte(s) leaked in 8 allocation(s)
updates: bz#1633930
Credits: Mohit Agrawal
Change-Id: Idb59c3880329fde59c415c84d7f0bb09ae879a1a
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit c9026b4500e9b7506b1a9b1264180b3310765b0d
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Dec 5 12:55:14 2018 +0530
cli: Fix mem-leaks reported by ASAN
Tracebacks:
Direct leak of 96 byte(s) in 1 object(s) allocated from:
#0 0x7f3acf9eac48 in malloc (/lib64/libasan.so.5+0xeec48)
#1 0x7f3acf510949 in __gf_malloc ./libglusterfs/src/mem-pool.c:136
#2 0x7f3acf5111bb in gf_vasprintf ./libglusterfs/src/mem-pool.c:236
#3 0x7f3acf51138a in gf_asprintf ./libglusterfs/src/mem-pool.c:256
#4 0x421611 in cli_cmd_volume_set_cbk ./cli/src/cli-cmd-volume.c:868
#5 0x410599 in cli_cmd_process ./cli/src/cli-cmd.c:135
#6 0x40f90d in cli_batch ./cli/src/input.c:29
#7 0x7f3acd78c593 in start_thread pthread_create.c:463
Direct leak of 73 byte(s) in 1 object(s) allocated from:
#0 0x7f3acf9eac48 in malloc (/lib64/libasan.so.5+0xeec48)
#1 0x7f3acf510949 in __gf_malloc ./libglusterfs/src/mem-pool.c:136
#2 0x421519 in gf_strndup ../../libglusterfs/src/mem-pool.h:167
#3 0x421519 in gf_strdup ../../libglusterfs/src/mem-pool.h:184
#4 0x421519 in cli_cmd_volume_set_cbk cli/src/cli-cmd-volume.c:859
#5 0x410599 in cli_cmd_process cli/src/cli-cmd.c:135
#6 0x40f90d in cli_batch cli/src/input.c:29
#7 0x7f3acd78c593 in start_thread pthread_create.c:463
Change-Id: I3312751c1e3178672360a678fe15b1f7f1054b22
updates: bz#1633930
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 1741b22dacea9475febecf32bc0d9d9a1dcc0323
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Nov 28 10:05:39 2018 +0530
all: add xlator_api to many translators
Fixes: #164
Change-Id: I93ad6f0232a1dc534df099059f69951e1339086f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7f2dc1969127aa44325c34418918ab256d8014e5
Author: Rinku Kothiya <rkothiya@redhat.com>
Date: Tue Dec 4 19:27:27 2018 +0530
cli: memory leak issue reported by asan
This patch fixes dict leak in cli_cmd_volume_stop_cbk.
SUMMARY: AddressSanitizer: 640 byte(s) leaked in 4 allocation(s)
Credits: Mohit Agrawal
Change-Id: If14983b8588e68d16d6bbb04b87e2f06fb97023d
fixes: bz#1633930
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
commit c9a3f1e267129eea9e8f4720c9d6356532020f7a
Author: ShyamsundarR <srangana@redhat.com>
Date: Thu Nov 29 14:08:06 2018 -0500
libglusterfs: Move devel headers under glusterfs directory
libglusterfs devel package headers are referenced in code using
include semantics for a program, this while it works can be better
especially when dealing with out of tree xlator builds or in
general out of tree devel package usage.
Towards this, the following changes are done,
- moved all devel headers under a glusterfs directory
- Included these headers using system header notation <> in all
code outside of libglusterfs
- Included these headers using own program notation "" within
libglusterfs
This change although big, is just moving around the headers and
making it correct when including these headers from other sources.
This helps us correctly include libglusterfs includes without
namespace conflicts.
Change-Id: Id2a98854e671a7ee5d73be44da5ba1a74252423b
Updates: bz#1193929
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 2785fd0774661bb783f10e169fb37b098adaadbb
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Mon Dec 3 19:02:32 2018 +0800
protocol/server: support server.all-squash
We still use gnfs on our side, so do a little work to support
server.all-squash. Just like server.root-squash, it's also a
volume wide option. Also see bz#1285126
$ gluster volume set <VOLNAME> server.all-squash on
Note: If you enable server.root-squash and server.all-squash
at the same time, only server.all-squash works. Please refer
to following table
+---------------+-----------------+---------------------------+
| |all_squash | no_all_squash |
+-------------------------------------------------------------+
| | |anonuid/anongid for root |
|root_squash |anonuid/anongid |useruid/usergid for no-root|
+-------------------------------------------------------------+
|no_root_squash |anonuid/anongid |useruid/usergid |
+-------------------------------------------------------------+
Updates bz#1285126
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Signed-off-by: Xue Chuanyu <xuechuanyu@cmss.chinamobile.com>
Change-Id: Iea043318fe6e9a75fa92b396737985062a26b47e
commit 3dd38f47488fb40e3279aaf41faed54ae8914bc5
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Dec 5 12:33:48 2018 +0530
cli: fix memory leak in cli/src/cli-rpc-ops.c
This Patch fixes memory leak reported by ASan.
Leaks are in gf_cli_status_cbk as a result of allocatating memory
using gf_asprintf in loop.
SUMMARY: AddressSanitizer: 535 byte(s) leaked in 7 allocation(s).
Change-Id: If2fd76c7c1ea6fc44baca295050800074f9d1323
updates: bz#1633930
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit e94f00bbe37f0ca59a4d8a98365baa974832c7cc
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Nov 20 12:32:32 2018 +0530
glusterd: glusterd to regenerate volfiles when GD_OP_VERSION_MAX changes
While glusterd has an infra to allow post install of spec to bring it up
in the interim upgrade mode to allow all the volfiles to be regenerated
with the latest executable, in container world the same methodology is
not followed as container image always point to the specific gluster rpm
and gluster rpm doesn't go through an upgrade process.
This fix does the following:
1. If glusterd.upgrade file doesn't exist, regenerate the volfiles
2. If maximum-operating-version read from glusterd.upgrade doesn't match
with GD_OP_VERSION_MAX, glusterd detects it to be a version where new
options are introduced and regenerate the volfiles.
Tests done:
1. Bring up glusterd, check if glusterd.upgrade file has been created
with GD_OP_VERSION_MAX value.
2. Post 1, restart glusterd and check glusterd hasn't regenerated the
volfiles as there's is no change in the GD_OP_VERSION_MAX vs the
op_version read from the file.
3. Bump up the GD_OP_VERSION_MAX in the code by 1 and post compilation
restart glusterd where the volfiles should be again regenerated.
Note: The old way of having volfiles regenerated during an rpm upgrade
is kept as it is for now but eventually this can be sunset later.
Change-Id: I75b49a1601c71e99f6a6bc360dd12dd03a96414b
Fixes: bz#1651463
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit acd121b17dcbd9a584396e94ed65b8313f59cb3c
Author: Harpreet kaur <hlalwani@redhat.com>
Date: Tue Dec 4 18:09:49 2018 +0530
cli: memory leak issue reported by asan
This patch fixes Indirect leaks in cli-cmd-volume.c
Leaks are happening in cli_cmd_quota_cbk and
cli_cmd_quota_handle_list_all.
SUMMARY: AddressSanitizer: 1152 byte(s) leaked in 8 allocation(s)
Updates: bz#1633930
Change-Id: Ia6c0306e88bd81f74d1220303ead8095fbcf5623
Signed-off-by: Harpreet kaur <hlalwani@redhat.com>
commit 500a5f0a7f0c5e781e2da5e25ab768d23e5f21c6
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Dec 4 05:01:54 2018 -0500
tests/geo-rep: Mask failure of geo-rep arbiter test
Comment out the particular test which is failing
arbitrarily. Also changed the code to differentiate
error cases. There could be some race because of
which it's failing arbitrarily. This will be debugged
and fixed in separate patch.
Change-Id: I925df6421737d7a9abd9446a9d85029b4285ad2c
updates: bz#1193929
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit da5e0b127bec3c2029a028fb821f42f2ae631504
Author: Chris Holcombe <xfactor973@gmail.com>
Date: Thu Nov 29 10:26:44 2018 -0800
debug/io-stats: Fix json output
Summary: The json being output by the io-stats debug xlator
quotes the numbers. This is not necessary and makes parsing
in strongly typed languages more difficult.
Change-Id: I3ac13700e2c52dbdc29d0bcdd39896d7871f36fe
fixes: bz#1654521
Signed-off-by: Chris Holcombe <xfactor973@gmail.com>
commit 2f6659b09b392c96664ffbdf1cbc589ba4b07af8
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Fri Nov 30 22:01:53 2018 +0530
rpc-transport/socket: NULL pointer dereferencing clang fix
Problem: res->ai_addr could be NULL
Added a check to address this issue
Change-Id: Iac88a8d6dc1f009836554448afbc228df93decd6
Updates: bz#1622665
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit cbf8db110ff18426bf484aa3dfe94f3e20488039
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Nov 25 11:22:30 2018 +0200
xlators/mgmt/glusterd/src/glusterd-volgen.c: use dict_ new functions
In a previous patch (https://review.gluster.org/20769) we've
added the key length to be passed to dict_* funcs, to remove the need
to strlen() it. This patches makes use of these functions over
this whole file.
Please review carefully, as there are many many changes there.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I2e1ee340300ec330936c31becda6bfe1b6533281
commit 36e442400678743a21de7b07863b8ac522fc938d
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Dec 5 10:52:30 2018 +0530
tests: Mark tests/bugs/shard/zero-flag.t bad
Change-Id: I2f4ca470c6666584e0feb129ab712f06772a86c2
Updates: bz#1656264
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 5768451586324fd958253d464b51278d0cddb2cd
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Dec 4 19:19:58 2018 +0530
glusterd: set cluster.max-bricks-per-process to 250
Commit 6821cec changed this default from 0 to 250 in the option table,
however the same wasn't done in the global option table.
Change-Id: I6075f2ebc51e839510d6492fb62e706deb2d845b
Fixes: bz#1652118
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 18f611a75b0b13bec856124a3366bda7d272d949
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Nov 28 12:39:31 2018 +0530
extras: Add group-distributed-virt for single-brick ovirt-gluster use-case
Change-Id: I930011327332b7ba30cc76f614efaf5932eb4f3d
fixes: bz#1654138
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit bfbf4305cb2cc87b7b5ecd0a480b4b02ab656407
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Nov 7 10:27:15 2018 +0200
libglusterfs/src/iobuf.c: small refactor to re-use code.
No functional changes (I hope).
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ifbec21c18a6dbe27c5271db156bff4d30ca85dbf
commit 68ed09796925374274c2ac4428e364fea98789a6
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Dec 4 00:18:42 2018 +0530
cli: fix memory leak in cli-cmd-system.c
This patch fixes memory leak reported by ASan.
SUMMARY: AddressSanitizer: 384 byte(s) leaked in 2 allocation(s).
updates: bz#1633930
Change-Id: I93ebddcfeea3d51547e00775db2c9d99f5dfafea
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 8d50fcd638326b9f645ee750ac740f7af63ca352
Author: Eli Schwartz <eschwartz@archlinux.org>
Date: Tue Dec 4 11:38:48 2018 -0500
configure.ac: fix option to stop automake aborting on pointless error
glusterfs does not follow the GNU coding standards and therefore must
use the "foreign" strictness. Without this, autoreconf -fi would fail to
execute successfully because automake returned non-zero.
This change ensures that people using autoreconf, the GNU preferred
invocation method for the autotools build system, can successfully set
up the build.
Remove the pointless --foreign argument from the autogen.sh invocation
of automake. Not only is configure.ac the preferred way to define such
options (rather than handwritten, piecemeal invocations of every tool in
the autotools toolchain), it was never needed in the autogen.sh as that
script provides no error handling at all and always (incorrectly)
returns successfully as long as autotools itself is installed (no matter
how broken glusterfs itself is).
Change-Id: Ib0246d5368a54594f517a322465cffb9a85c1b49
fixes: bz#1656100
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
commit 25ac2b002b10359339f31cc98a6c41313a6c5534
Author: Milan Zink <mzink@redhat.com>
Date: Tue Jan 16 13:48:49 2018 +0100
Do not blindly add volume share section to smb.conf
With this change, by default GlusterFS volume share section will
no longer be added to smb.conf for client access unless user.cifs
or user.smb volume set options are enabled. This also fixes the
hook script to check for presence of all configuration possibilities
for those volume set options like 'enable' or 'on'.
Change-Id: Ibecf7fffb4507d7255d963c3b1482afb0d0db984
Signed-off-by: Milan Zink <mzink@redhat.com>
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Fixes: bz#1575836
commit b3adfeffd750580e111e04018dc57e7c295e7c27
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Nov 8 18:50:18 2018 +0530
glusterd: migrating profile commands to mgmt_v3 framework
Current profile commands use the op_state machine framework.
Porting it to use the mgmt_v3 framework.
The following tests were performed on the patch:
case 1:
1. On a 3 node cluster, created and started 3 volumes
2. Mounted all the three volumes and wrote some data
3. Started profile operation for all the volumes
4. Ran "gluster v status" from N1,
"gluster v profile <volname1> info" form N2,
"gluster v profile <volname2> info" from N3 simultaneously in a
loop for around 10000 times
5. Didn't find any cores generated.
case 2:
1. Repeat the steps 1,2 and 3 from case 1.
2. Ran "gluster v status" from N1,
"gluster v profile <volname1> info" form N2(terminal 1),
"gluster v profile <volname2> info" from N2(terminal 2)
simultaneously in a loop.
3. No cores were generated.
fixes: bz#1654181
Change-Id: I83044cf5aee3970ef94066c89fcc41783ed468a6
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit c1cc39fe1c55a767ea1608005fd2122b18fa5e65
Author: Harpreet Kaur Lalwani <hlalwani@redhat.com>
Date: Wed Nov 21 16:13:36 2018 +0530
cli: "usage()" and "--help" for gluster cli
Added a usage message which will be shown when a user enters an
"unrecognized word" or an "unrecognized command" on the cli.
Also added a "--help" option for gluster cli.
fixes: bz#1535495
Change-Id: Ibcfb3d1c84daa1054e09c5cdfa6a5dab19f534a6
Signed-off-by: Harpreet Kaur Lalwani <hlalwani@redhat.com>
commit 82a4c953862665e84c1c3871c21d717aa82848bf
Author: Kotresh HR <khiremat@redhat.com>
Date: Sat Nov 17 13:14:24 2018 +0530
geo-rep: Fix syncing of files with non-ascii filenames
Problem:
Creation of files/directories with non-ascii names fails
to sync to the slave. It crashes with below traceback on
slave.
...
File "/usr/lib/x86_64-linux-gnu/glusterfs/python/syncdaemon/repce.py", line 118, in worker
res = getattr(self.obj, rmeth)(*in_data[2:])
File "/usr/lib/x86_64-linux-gnu/glusterfs/python/syncdaemon/resource.py", line 709, in entry_ops
[ESTALE, EINVAL, EBUSY])
File "/usr/lib/x86_64-linux-gnu/glusterfs/python/syncdaemon/syncdutils.py", line 546, in errno_wrap
return call(*arg)
File "/usr/lib/x86_64-linux-gnu/glusterfs/python/syncdaemon/libcxattr.py", line 83, in lsetxattr
cls.raise_oserr()
File "/usr/lib/x86_64-linux-gnu/glusterfs/python/syncdaemon/libcxattr.py", line 38, in raise_oserr
raise OSError(errn, os.strerror(errn))
OSError: [Errno 12] Cannot allocate memory
Cause:
The length calculation arguments passed to blob creation was done before encoding. Hence
was failing in gfid-access layer.
Fix:
It appears that the calculating lenght properly fixes this issue. But it will cause
issues in other places in 'python2' and not in 'python3'. So encoding and decoding
each required string to make geo-rep compatible with both 'python2' and 'python3'
is a nightmare and is not fool proof. Hence kept 'python2' code as is with out
encode/decode and applied encode/decode only to 'python3'
Added non-ascii filename tests to regression
fixes: bz#1650893
Change-Id: I35cfaf848e07b1a0b5cb93c01b98b472f08271a6
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 01014f481c7c506c09a007cce2968b35be4ce0d3
Author: Milind Changire <mchangir@redhat.com>
Date: Tue Nov 27 11:43:04 2018 +0530
rpc: bump up server.event-threads
Problem:
A single event-thread causes performance issues in the system.
Solution:
Bump up event-threads to 2 to make the system more performant.
This helps in making the system more responsive and helps avoid the
ping-timer-expiry problem as well. However, setting the event-threads
to 2 is not the only thing required to avoid ping-timer-expiry issues.
Change-Id: Idb0fd49e078db3bd5085dd083b0cdc77b59ddb00
fixes: bz#1653277
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit b9800d757fd3ebec0ce61dd8ec66c5d00b25b58c
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Nov 28 14:14:00 2018 +0530
io-cache: xdata needs to be passed for readv operations
io-cache xlator has been skipping xdata references when the
date needs to be read into page cache. This patch fixes the same.
Note: similar changes may be needed for other fops as well
which are handled by io-cache.
Change-Id: I28d73d4ba471d13eb55d0fd0b5197d222df77a2a
updates: bz#1648768
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 43227d272686f7647c7a734204fa767c582f0238
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Dec 3 11:51:52 2018 -0500
rpc: check if fini is there before calling it
The rpc_transport_t structure is allocated and filled in the
rpc_transport_load function. If filling the fileds of the rpc
structure fails, then in the failure handling the structure is
freed by rpc_transport_cleanup. There, it unconditionally calls
fini. But, if the failure handling was invoked because of any
failure in between the allocation of rpc_transport_t and filling
the transport->fini (including the failure to fill fini ()), then
rpc_transport_cleanup can lead to a segfault.
Change-Id: I8be9b84cd6b19933c559c9736198a6e440373f68
fixes: bz#1654917
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 215a22eeffcfaefa380acb314e72781623e055df
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Nov 28 16:13:58 2018 +0530
glusterd: perform rcu_read_lock/unlock() under cleanup_lock mutex
Problem: glusterd should not try to acquire locks on any resources,
when it already received a SIGTERM and cleanup is started. Otherwise
we might hit segfault, since the thread which is going through
cleanup path will be freeing up the resouces and some other thread
might be trying to acquire locks on freed resources.
Solution: perform rcu_read_lock/unlock() under cleanup_lock mutex.
fixes: bz#1654270
Change-Id: I87a97cfe4f272f74f246d688660934638911ce54
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 43f9c01382851741b6f71797999f48978c421097
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Nov 30 17:46:59 2018 +0530
cli : Memeory leak fix reported by ASAN
This patch fixes memory leak in cli-rpc-ops.c.
Functions: gf_cli_create_volume_cbk, gf_cli_delete_volume_cbk,
gf_cli_start_volume_cbk, gf_cli_remove_tier_brick_cbk,
gf_cli_list_volume_cbk.
updates: bz#1633930
Change-Id: I68a650fb972db18c90e6581a960eae3018f32d40
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit a3bfcf37861181716ff63cfa538a8c15ce372274
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Nov 29 19:55:39 2018 +0530
server: Resolve memory leak path in server_init
Problem: 1) server_init does not cleanup allocate resources
while it is failed before return error
2) dict leak at the time of graph destroying
Solution: 1) free resources in case of server_init is failed
2) Take dict_ref of graph xlator before destroying
the graph to avoid leak
Change-Id: I9e31e156b9ed6bebe622745a8be0e470774e3d15
fixes: bz#1654917
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 02634802dee7a93ef3eea962482ad87d51b3f8ec
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Nov 29 12:04:45 2018 -0500
features/bitrot: compare the signature with proper length
* The scrubber was comparing the checksum of the file that it
calculated (by reading the file) with the on disk signature
(stored via xattr) wrongly. It was using strlen to calculate
the signature, while the actual length of the signature is
given by the brick. Just use the actual length that the brick
provides instead of trying to calculate the signature length via
strlen API.
* In posix, gfid2path was using the same string that contains the
list of all the xattrs of file to save the value of the gfid2path
xattr as well. This causes confusion when gfid2path xattr is queried
by scrubber for getting the actual path of a corrupted file. Use
separate string to fetch the value of the xattr instead of the string
that contains the list of xattrs.
Change-Id: I2d664ab524d2b312233476cb35863dde3122e9a9
fixes: bz#1654805
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit d41bf7f530100cbd1263797beca821228e5e66d9
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Sep 28 17:00:00 2018 +0530
afr: assign gfid during name heal when no 'source' is present.
Problem:
If parent dir is in split-brain or has dirty xattrs set, and the file
has gfid missing on one of the bricks, then name heal won't assign the
gfid.
Fix:
Use the brick we select the gfid from as the 'source'.
Note: Problem was found while trying to debug a split-brain issue on
Cynthia Zhou's setup.
updates: bz#1637249
Change-Id: Id088d4f0fb017aa35122de426654194e581ed742
Reported-by: Cynthia Zhou <cynthia.zhou@nokia-sbell.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 7e76cae01955a6df1666212185fab1bb4f9020ce
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Nov 20 14:11:08 2018 +0530
doc: Add brick mux thread reduction design doc in developer guide
Change-Id: I5309efb5826d4385eadea29c1cf973f504eef9e5
Updates: #475
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 89ce41cd1a72529a853fff2cf9c0466fd7977420
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Nov 28 12:45:41 2018 +0530
leases: Do not conflict with internal fops
Internal fops (with frame->root->pid < 0) are used to heal
or move data and maintains data integrity. That is they do not
modify client data which holds the lease. Hence no need to recall
Lease for such fops.
Note: Like for locks, we would need rebalance and self-heal
daemon process to heal lease state as well.
Change-Id: I8988693fef8d00e17c19dcc842e2238f9eb5ab48
updates: bz#1648768
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 9150720edbb9a60c60323d4d604a7d2a2636facc
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Nov 23 12:14:59 2018 +0200
rpc *.h fles: align structs
Make an effort to slightly better align the structures.
Change-Id: I6f80a451f2ffbf15adfb986cedc24c2799787b49
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 08e3f742f7c7c05190940e6a7fd463fae764642e
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Nov 29 19:22:40 2018 +0530
nfs : set ctx for every inode looked up nfs3_fh_resolve_inode_lookup_cbk()
The inode ctx for nfs xlator is set with help nfs_fix_generation.
But currently gnfs is crashing because inode_ctx is becoming null
nfs3_resolve_inode_hard() is used to perform a lookup on entire
path and looks like function is missing to set the ctx for inode.
This patch will set ctx for the inode which it looked on.
Change-Id: I464fa7f78df1bae990ebe97de8ccf6d5fb74fc9f
fixes: bz#1651439
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit c79eecfb7dbcf486ec2ba552c21431cefc01140d
Author: Harpreet Lalwani <hlalwani@redhat.com>
Date: Mon Oct 15 12:41:17 2018 +0530
cli: memory leak issue reported by asan
This patch fixes Indirect leaks in tests/bugs/heal-symlinks.t.
Leaks are happening in cli_cmd_volume_heal_cbk.
SUMMARY: AddressSanitizer: 640 byte(s) leaked in 4 allocation(s).
Updates: bz#1633930
Change-Id: I970b4229630fdaf01aec66581c1287beef7560a3
Signed-off-by: Harpreet Lalwani <hlalwani@redhat.com>
commit ca5fccc0a85c8ca4dc85e2f50603e68e75b80b9c
Author: ShyamsundarR <srangana@redhat.com>
Date: Fri Nov 30 11:58:57 2018 -0500
clang: Fix io-stats.c NULL pointer issue reported by clang
The issue pertains to checking if conf is NULL in BUMP_FOP
but not providing that safety in io_stats_release when using
conf to lock and bump nr_opens.
This is now corrected to check if conf is non-NULL before
attempting the lock and bump nr_opens.
Tested with local clang analyzer to ensure this fixes the
problem.
Change-Id: Iffd6a97c2060d0a6930a8dc5914b1956c192cab1
Updates: bz#1622665
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 8eae790fd5cb8128fe51b589a3b95fd6ef19b9fb
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Nov 30 16:39:32 2018 +0530
cli : Memeory leak fix reported by ASAN
This patch fixes memory leak in cli-rpc-ops.c.
All leaks are happening in gf_cli_remove_brick_cbk.
SUMMARY: AddressSanitizer: 2944 byte(s) leaked in 22 allocation(s).
updates: bz#1633930
Change-Id: I1e58d538eb9135f1aadcdb54d10b72f55e8a53d1
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit d4518889adb141f38841bcea13a7499bb3887501
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Nov 29 22:27:59 2018 +0200
Multiple xlator .h files: remove unused private gf_* memory types.
It seems there were quite a few unused enums (that in turn
cause unndeeded memory allocation) in some xlators.
I've removed them, hopefully not causing any damage.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I8252bd763dc1506e2d922496d896cd2fc0886ea7
commit 91e470d8e1b442859e294d6fa35fabca450f5870
Author: ShyamsundarR <srangana@redhat.com>
Date: Thu Nov 29 15:37:23 2018 -0500
clang: Fix clang warnings in snapview-server.c
The warning by clang is due to the fact that we check for
frame->root to be NULL, but in stack unwind, we ignore the
same.
If frame is non-NULL then frame->root is non-NULL as frame
creation ensures this. Further, across the code we do not
check both frame and frame->root for validity.
Hence to fix these clang issues, removing the check for
frame->root in the various functions.
NOTE: Initially clang reported 14 issues in the file, but
post commit 6eabefe6 the number reduced to 4, unsure why as
that commit does not address this issue.
Change-Id: I04b63f2d006a1f95773aae9f904b4bd3d5118e62
Updates: bz#1622665
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 935f9b4106e06c13aec9c95d04721c677ec46425
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Wed Oct 31 16:10:58 2018 +0530
rpcsvc: provide each request handler thread its own queue
A single global per program queue is contended by all request handler
threads and event threads. This can lead to high contention. So,
reduce the contention by providing each request handler thread its own
private queue.
Thanks to "Manoj Pillai"<mpillai@redhat.com> for the idea of pairing a
single queue with a fixed request-handler-thread and event-thread,
which brought down the performance regression due to overhead of
queuing significantly.
Thanks to "Xavi Hernandez"<xhernandez@redhat.com> for discussion on
how to communicate the event-thread death to request-handler-thread.
Thanks to "Karan Sandha"<ksandha@redhat.com> for voluntarily running
the perf benchmarks to qualify that performance regression introduced
by ping-timer-fixes is fixed with this patch and patiently running
many iterations of regression tests while RCAing the issue.
Thanks to "Milind Changire"<mchangir@redhat.com> for patiently running
the many iterations of perf benchmarking tests while RCAing the
regression caused by ping-timer-expiry fixes.
Change-Id: I578c3fc67713f4234bd3abbec5d3fbba19059ea5
Fixes: bz#1644629
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
commit 03a21977ef1dca30c34e4dc8859240e8abbeef87
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Nov 27 11:19:59 2018 -0500
core: ctx calls naked calloc()
liblglusterfs provides wrapper functions MALLOC/__gf_default_malloc,
CALLOC/__gf_default_calloc, and REALLOC/__gf_default_realloc for those
few places outside of mempool.c that need to call malloc/calloc/realloc
directly.
Notable exceptions are "contrib" code, e.g. rbtree and timer-wheel,
and perhaps parsers generated by yacc+lex. But even parsers can be
fixed to at least call the wrappers mentioned above, if not our own
allocators.
Change-Id: Ib8069815eba9b6c04c3adaf59727ec8d8795c4d1
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit bab4939b2f38b9aa31b29490dd907b7ef62a7fc1
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Fri Nov 16 16:27:17 2018 +0530
libglusterfs: rename macros roof and floor to not conflict with math.h
Change-Id: I666eeb63ebd000711b3f793b948d4e0c04b1a242
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
Updates: bz#1644629
commit adbc607f76fcf6f02bec2c9bcd6e162e9bd8549a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Nov 27 14:24:15 2018 -0500
glusterd: volume-ops calls naked malloc
libglusterfs provides wrapper functions MALLOC/__gf_default_malloc,
CALLOC/__gf_default_calloc, and REALLOC/__gf_default_realloc for those
few places outside of mempool.c that need to call malloc/calloc/realloc
directly.
Notable exceptions are "contrib" code, e.g. rbtree and timer-wheel,
and perhaps parsers generated by yacc+lex. But even parsers can be
fixed to at least call the wrappers mentioned above, if not our own
allocators
Change-Id: Ie6156307b6d2183be9c9aff153afb7598974f4e4
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 3f2e40f0eee4c263a1af01914d77c5fd86820946
Author: Harpreet Kaur <hlalwani@redhat.com>
Date: Tue Nov 27 12:17:38 2018 +0530
tests/geo-rep: Add Arbiter volume test case
Added geo-rep regression tests with Arbiter volume.
Fixes: bz#1653565
Change-Id: Id99523c1f1d3d301fbe871aa0641d9ae4ed7b8d7
Signed-off-by: Harpreet Kaur <hlalwani@redhat.com>
commit 3fd493c32cc1df69dbdfc78a1e811bab8a5c4e05
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Nov 25 11:01:01 2018 +0530
posix: fix memory leak
Direct leak of 609960 byte(s) in 4485 object(s) allocated from:
#0 0x7f0d719bea50 in __interceptor_calloc (/lib64/libasan.so.5+0xefa50)
#1 0x7f0d716dc08f in __gf_calloc ../../../libglusterfs/src/mem-pool.c:111
#2 0x7f0d5d41d9b2 in __posix_get_mdata_xattr ../../../../../xlators/storage/posix/src/posix-metadata.c:240
#3 0x7f0d5d41dd6b in posix_get_mdata_xattr ../../../../../xlators/storage/posix/src/posix-metadata.c:317
#4 0x7f0d5d39e855 in posix_fdstat ../../../../../xlators/storage/posix/src/posix-helpers.c:685
#5 0x7f0d5d3d65ec in posix_create ../../../../../xlators/storage/posix/src/posix-entry-ops.c:2173
Direct leak of 609960 byte(s) in 4485 object(s) allocated from:
#0 0x7f0d719bea50 in __interceptor_calloc (/lib64/libasan.so.5+0xefa50)
#1 0x7f0d716dc08f in __gf_calloc ../../../libglusterfs/src/mem-pool.c:111
#2 0x7f0d5d41ced2 in posix_set_mdata_xattr ../../../../../xlators/storage/posix/src/posix-metadata.c:359
#3 0x7f0d5d41e70f in posix_set_ctime ../../../../../xlators/storage/posix/src/posix-metadata.c:616
#4 0x7f0d5d3d662c in posix_create ../../../../../xlators/storage/posix/src/posix-entry-ops.c:2181
We were freeing only the first context in inode during forget, and not the second.
updates: bz#1633930
Change-Id: Ib61b4453aa3d2039d6ce660f52ef45390539b9db
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 271803cb396f06b04c7022eb946fb274c97684e8
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Nov 27 12:21:01 2018 +0100
mem-pool: minor fix and clarification
A comment has been added to pool_destructor() function to explain why
locks are not needed there. Also, the initialization of 'poison' field
has been moved inside a locked region for further safety and clarity.
Change-Id: Idbf23bda7f9228d60c644a1bea4b6c2cfc582090
updates: bz#1193929
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit d000f18733c8ebd611655ebd343c1efb80138cc8
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Fri Nov 23 17:28:07 2018 +0530
geo-rep: Geo-rep help text issue
Modified Geo-rep help text for better sanity.
Change-Id: I48f4d0fd60c1ffcde753b37416e0c73afd0b5702
fixes: bz#1652887
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit 5004394fb85a93a917ae41e6346b044140c6745b
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Nov 22 09:58:52 2018 +0530
glusterd: perform store operation in cleanup lock
All glusterd store operation and cleanup thread should work under a
critical section to avoid any partial store write.
Change-Id: I4f12e738f597a1f925c87ea2f42565dcf9ecdb9d
Fixes: bz#1652430
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 789480df2b37fb90a9af5093f77005f87b45d1b9
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Nov 23 12:23:05 2018 +0530
glusterd : fix high sev coverity issue
This patch fixes CID : 1174824 : RESOURCE_LEAK
Change-Id: I59d2d6ebc1fa3d7ebe0b97c7dbe3c5539128522a
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit be2dee93f29bd3532d379a9abb2663162f607ae2
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Nov 25 12:04:50 2018 +0200
libglusterfs/src/dict.c : consistent initialization of parameters.
Some were assigned NULL, for no good reason, some were assigned proper
initial value. Made them all consistent, as much as possible, to be
assigned reasonable initial values.
No expected functional changes (and I also assume the compiler
already did most of this work behind the scenes anyway, so no
performance implications either).
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I2bc0d4f2221124b5f9ef6150c86b7259074e7013
commit a75fada5ca61cb4264ebce05c759a6636b8e314f
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Nov 13 12:53:17 2018 +0100
build: add option to compile with ThreadSanitizer
ThreadSanitizer is a debugging tool that can detect threads that race
for data modifications. These races can result in data corruption and
are difficult to track and fix.
Change-Id: Ibbdaf17c811e30e79cd5bdcf9cd9ff2d0cdb2abb
URL: https://github.com/google/sanitizers/wiki/ThreadSanitizerCppManual
Reported-by: Yaniv Kaul <ykaul@redhat.com>
Fixes: #543
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit e7dd46ae544390da7058fb2c147be34f1d168592
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Oct 26 17:51:38 2018 +0530
glfsheal: add a '--nolog' flag
....and if set, change the log level to GF_LOG_NONE. This is useful for
monitoring applications which invoke the heal info set of commands once
every minute, leading to un-necessary glfsheal* logs in
/var/log/glusterfs/. For example, we can now run
`gluster volume heal <VOLNAME> info --nolog`
`gluster volume heal <VOLNAME> info split-brain --nolog` etc.
The default log level is still retained at GF_LOG_INFO.
The patch also changes glfsheal internally to accept '--xml' instead of 'xml'.
Note: The --nolog flag is *not* displayed in the help anywhere, for the
sake of consistency in how the other flags are not displayed anywhere in
the help.
fixes: bz#1643519
Change-Id: Ia08b6aa6e4a0548379db7e313dd4411ebc66f206
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit f39dd7633338cff32b10b60cfab0bd8a75c0da01
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Aug 31 14:20:23 2018 +0530
cluster/afr: Add test for thin-arbiter feature
Test : Check success/failure of write fop while
different bricks/ta process are down.
Change-Id: I3c376935df93ebf1f794c964bd19bc1280d91c59
updates: bz#1624332
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit a2ca86c46ced86522200a446a8dc17e7c5dab4cf
Author: Susant Palai <spalai@redhat.com>
Date: Fri Aug 3 17:43:28 2018 +0530
coding-standard: memset before string functions similar to sprintf/snprintf etc
String functions like sprintf/snprintf/vprintf etc terminates the string with a
null character. This makes meset redundant and also incurs some performance
penalty.
Also added a comment about using GF_MALLOC instead of GF_CALLOC for allocating
buffer for strings, targeted by such functions.
Fixes: bz#1193929
Change-Id: I4f40d4fd5342b70983936119606c6c9f352c303c
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 744db37cc1fb3f751dffb1dc2304de749da75a93
Author: root <Shwetha Acharya>
Date: Fri Nov 23 19:30:01 2018 +0530
geo-rep: add no-verify and ssh-port options for create command
Added the missing options and their description.
fixes: bz#1652911
Change-Id: Id9135953bc6d32e645f004e1c77449899ca3d67c
Signed-off-by: root <Shwetha Acharya>
commit 87546861ef749f697622977ff2da23c42a367eb2
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Nov 7 18:54:23 2018 +0100
libglusterfs: fix memory corruption caused by per-thread mem pools
There was a race in the per-thread memory pool management that could lead
to memory corruption. The race appeared when the following sequence of
events happened:
1. Thread T1 allocated a memory object O1 from its own private pool P1
2. T1 terminates and P1 is marked to be destroyed
3. The mem-sweeper thread is woken up and scans all private pools
4. It detects that P1 needs to be destroyed and starts releasing the
objects from hot and cold lists.
5. Thread T2 releases O1
6. O1 is added to the hot list of P1
The problem happens because steps 4 and 6 are protected by diferent locks,
so they can run concurrently. This means that both T1 and T2 are modifying
the same list at the same time, potentially causing corruption.
This patch fixes the problem using the following approach:
1. When an object is released, it's only returned to the hot list of the
corresponding memory pool if it's not marked to be destroyed. Otherwise
the memory is released to the system.
2. Object release and mem-sweeper thread synchronize access to the deletion
mark of the memory pool to prevent simultaneous access to the list.
Some other minor adjustments are made to reduce the lengths of the locked
regions.
Fixes: bz#1651165
Change-Id: I63be3893f92096e57f54a6150e0461340084ddde
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 231cb28d373d742d7c7e6584aba49b5358b74cef
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Nov 20 12:36:55 2018 +0530
geo-rep: Fix permissions with non-root setup
Problem:
In non-root fail-over/fail-back(FO/FB), when slave is
promoted as master, the session goes to 'Faulty'
Cause:
The command 'gluster-mountbroker <mountbroker-root> <group>'
is run as a pre-requisite on slave in non-root setup.
It modifies the permission and group of following required
directories and files recursively
[1] /var/lib/glusterd/geo-replication
[2] /var/log/glusterfs/geo-replication-slaves
In a normal setup, this is executed on slave node and hence
doing it recursively is not an issue on [1]. But when original
master becomes slave in non-root during FO/FB, it contains
ssh public keys and modifying permissions on them causes
geo-rep to fail with incorrect permissions.
Fix:
Don't do permission change recursively. Fix permissions for
required files.
fixes: bz#1651498
Change-Id: I68a744644842e3b00abc26c95c06f123aa78361d
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit c4c7d4c3b3ac80dca1621c87cfe447b8e8ec82d1
Author: Soumya Koduri <skoduri@redhat.com>
Date: Sun Nov 18 23:38:08 2018 +0530
gfapi: Offload callback notifications to synctask
Upcall notifications are received from server via epoll
and same thread is used to forward these notifications
to the application. This may lead to deadlock and hang
in the following scenario.
Consider if as part of handling these callbacks,
application has to do some operations which involve
sending I/Os to gfapi stack which inturn have to wait for
epoll threads to receive repsonse. Thus this may lead to
deadlock if all the epoll threads are waiting to complete
these callback notifications.
To address it, instead of using epoll thread itself,
make use of synctask to send those notificaitons to the
application.
Change-Id: If614e0d09246e4279b9d1f40d883a32a39c8fd90
updates: bz#1648768
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit b479db3c6c1cde9fb967ceedd582689e50f9e23e
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Nov 23 11:31:38 2018 +0530
coverity: Fix coverity issues
This patch fixes coverity
CID : 1356537
https://scan6.coverity.com/reports.htm#v42907/p10714/fileInstanceId=87389108&defectInstanceId=26791927&mergedDefectId=1356537
CID : 1395666
https://scan6.coverity.com/reports.htm#v42907/p10714/fileInstanceId=87389187&defectInstanceId=26791932&mergedDefectId=1395666
CID : 1351707
https://scan6.coverity.com/reports.htm#v42907/p10714/fileInstanceId=87389027&defectInstanceId=26791973&mergedDefectId=1351707
CID : 1396910
https://scan6.coverity.com/reports.htm#v42907/p10714/fileInstanceId=87389027&defectInstanceId=26791973&mergedDefectId=13596910
Change-Id: I8094981a741f4d61b083c05a98df23dcf5b022a2
updates: bz#789278
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit c5632daf22cad791ac371287d73b62410f62af21
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Nov 21 07:49:07 2018 +0530
glusterd: make max-bricks-per-process default value to 250
Change-Id: Ia2c6a10e2b76a4aa8bd4ea97e5ce33bdc813942e
Fixes: bz#1652118
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 197e905ed56641e748f1cfbfe82612390a0e70cd
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Nov 19 15:13:02 2018 +0530
glusterd: volume status should not show NFS daemon
With commit 8ad159b2a7, bz#1511339 got reintroduced.
fixes: bz#1511339
Change-Id: I1e34c1fc60c6dda04af25d123f1ca40964cadb7a
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 94bf622d1aa5a8253b7d04555bef275fc64d0200
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Nov 23 12:38:44 2018 +0530
meta/coverity: Fix coverity in meta xlator
CID : 1356536 Macro compares unsigned to 0
https://scan6.coverity.com/reports.htm#v42907/p10714/fileInstanceId=87389645&defectInstanceId=26791929&mergedDefectId=1356536
CID : 1356535 Macro compares unsigned to 0
https://scan6.coverity.com/reports.htm#v42907/p10714/fileInstanceId=87389645&defectInstanceId=26791926&mergedDefectId=1356535
Change-Id: Icb1c9035589fa871c7223f767adbe0dfa672a9b4
updates: bz#789278
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 9894a9d7435e5d11bde01c50c84eb00442ea8bc9
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Nov 22 21:41:37 2018 +0530
Coverity fix for calling risky function - fscanf
fscanf with %s reads a word, there is no restriction on the length
of that word, and the caller is required to pass a sufficiently
large buffer for storing thw word. If the input word exceeds the
buffer size, it will cause buffer overflow.
To fix this, use fscanf with width parameter. Width specifies
the maximum number of characters to be read in the current reading
operation.
Change-Id: If250abf5eb637b9fc2a79047e3599f83254cd4e5
updates: bz#1193929
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit f102f30d6295ba8c1458ec06688ec91d4c64544e
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Nov 23 10:37:40 2018 +0100
core: create a constant for default network timeout
A new constant named GF_NETWORK_TIMEOUT has been defined and all
references to the hard-coded timeout of 42 seconds have been
replaced with this constant.
Change-Id: Id30f5ce4f1230f9288d9e300538624bcf1a6da27
fixes: bz#1652852
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 0dc50ec283c8c648c3fa0dfefdc83bc6f306e7cc
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Nov 16 11:18:27 2018 +0530
features/changelog: Fix dictionary-leak
rpcsvc_transport_unix_options_build() allocates the dictionary and sets
it in the options variable, there is no need to allocate it before passing
to the function in changelog_rpc_server_init()
updates bz#1650403
Change-Id: I5b4caedba6bda706dee723a2be34c3981bf971fb
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit f79b7db1577983ed05c0b364cca964dd63c15b65
Author: Susant Palai <spalai@redhat.com>
Date: Wed Nov 21 11:45:23 2018 +0530
dht: fix buffer overflow
CID: 1382461
Change-Id: I25b5edf7fd5fdaa52079d0348ebb7f5de9f11503
updates: bz#789278
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 0aded78edead3e7c6f2d2e2d1dafdb5544a763b4
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Nov 22 09:56:55 2018 +0530
rpc: stop log flooding about ENODATA
Problem:
Logs are being flooded with ENODATA errors.
This log was introduced via https://review.gluster.org/c/glusterfs/+/21481
Solution:
Add a flag to remember that ENODATA error was logged for a
socket/transport
Change-Id: I54c10b87e46c2592339cc8b966333b8d08331750
fixes: bz#1650389
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit c1ccf1dc08e9020f6408edcea9abfb87e5d30e64
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Nov 21 19:02:42 2018 +0530
core: Resolve memory leak at the time of graph init
Problem: In the commit 751b14f2bfd40e08ad395ccd98c6eb0a41ac4e91
one code path is missed to avoid leak at the time
of calling graph init
Solution: Before destroying graph call xlator fini to avoid leak for
server-side xlators those call init during graph init
Credit: Pranith Kumar Karampuri
fixes: bz#1651431
Change-Id: I6e7cff0d792ab9d954524b28667e94f2d9ec19a2
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 5b029bfcb8fb6ee87e2ab771c493978ab23889ef
Author: Shwetha Acharya <sacharya@gmail.com>
Date: Wed Nov 21 12:24:00 2018 +0530
geo-rep: validate the config checkpoint date format
Added a strlen check to ensure that the format is (Y-m-d H:M:S).
Change-Id: I8844aaa33418d43ffe2320c4a05eb1eddd306903
updates: bz#1651584
Signed-off-by: Shwetha Acharya <sacharya@gmail.com>
commit 2560308aab119c6b0b5f3ff62012a3a5ad6321bc
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Thu Nov 15 15:24:22 2018 +0530
protocol/client: unchecked return value
Problem: In client_process_response_v2, value returned from
function client_post_common_dict is not checked for errors
before being used.
Solution: Added a check condition to resolve the issue.
CID: 1390020
Change-Id: I4d297f33c8dd332ae5f6f21667a4871133b2b570
updates: bz#789278
Signed-off-by: Shwetha Acharya <sacharya@redhat.com>
commit 4d31a84218d5b4a1e3e692d447315e1ec8901a08
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Oct 31 16:31:35 2018 -0400
snapview-server: close the gfapi handle present in a forgotten inode
Currently, the snapdaemon can reach the lru limit of the inode table
and start sending forgets on the inodes that are least recently used.
snapview-server maintains the mapping between the domain of the
snapdaemon and the gfapi instance which it uses to access the snapshots
via a handle that is stored in the inode context of snapdaemon's inode.
The handle is glfs_h_object structure which itself points to the actual
inode present in the gfapi world.
But, when snapview-server receives forget on a inode, it deleted the
inode context without actually closing the handle it had obtained to
map the inode from snapdaemon to the inode in gfapi world.
So, this change makes sure that, the handle is closed as part of the
inode forget. And this closure of the handle will result in gfapi
world receiving forget and unref on its corresponding inode. But
care must be taken to ensure before the closure to ensure that
the gfapi instance from which the handle came from, is still valid
and not destroyed. Otherwise, sending a forget downward to the gfapi
world might result in the access of freed pointers. Hence, the
snapview-server xlator first checks whether that gfapi instance is
still there or not and then proceeds with closure of the handle.
Change-Id: Ia7bb45112d0c651cc95f2e54d33d925dbd6955b0
fixes: bz#1646728
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit e960825b2b5de1bef32ee95084da01f78d9c425d
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri Nov 16 09:25:02 2018 +0530
core: Resolve memory leak at the time of graph init
Problem: Memory leak when graph init fails as during volfile
exchange between brick and glusterd
Solution: Fix the error code path in glusterfs_graph_init
Change-Id: If62bee61283fccb7fd60abc6ea217cfac12358fa
fixes: bz#1651431
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit d44ee65e26ffd31e65c024fe0ee5445a5cf4dfe7
Author: Iraj Jamali <ijamali@redhat.com>
Date: Tue Oct 23 14:18:40 2018 +0530
glusterfsd: NULL pointer dereferencing clang fix
Added a check to avoid clang warning
Updates: bz#1622665
Change-Id: If9ae4e4f2ae13c85dad0e87d8dd6930dde74bbda
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit a86b11064a2b4311dc968f357aab1c76dc665355
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Mon Nov 19 10:26:54 2018 +0530
core: Retrieving the value of "client.ssl" option, before SSL is set up, fails
Added a default value "off" for (client|server).ssl
fixes: bz#1651059
Change-Id: I3d9c80093ac471d9d770fbd6c67f945491cf726e
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 987454ad40bebc26ce8d74405fafa72629cb5429
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Nov 16 12:32:22 2018 +0200
libglusterfs/src/common-utils.h: faster mem_0filled() function
based on the amusing discussion @ https://rusty.ozlabs.org/?p=560
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I1cac54067eb44801b216d5620fc5ee2c89befdd0
commit e5a4ece7c35e3b8674b99b938d7ac21dc083346b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Nov 16 12:46:49 2018 -0500
core: fix strncpy, coverity annotation
For added fun, coverity is not smart enough to detect that the
strncpy() is safe, and for extra laughs, using coverity annotations
doesn't do anything either; but we're adding them anyway, along
with marking the BUFFER_SIZE_WARNINGS as false positives on
scan.coverity.com.
Change-Id: If7fa157eca565842109f32fee0399ac183b19ec7
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 11384643eb956ceae9c4473544e89e2842f5bc2c
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Nov 16 11:25:16 2018 +0530
features/locks: Move logging outside of a locked region
In pl_metalk(), logging was being done in a synchronized region.
Moving the log out of the synchronized region to avoid other threads
from being blocked on the lock.
Thanks to Yaniv Kaul for pointing this out.
Change-Id: I0cb39fb23ae7c798ca9c42c390500491aa8e622b
updates: bz#1644758
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 68dd1f8f166afde46203bf7bcd1def143c7d7672
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Nov 9 17:06:22 2018 +0530
cluster/dht: sync brick root perms on add brick
If a single brick is added to the volume and the
newly added brick is the first to respond to a
dht_revalidate call, its stbuf will not be merged
into local->stbuf as the brick does not yet have
a layout. The is_permission_different check therefore
fails to detect that an attr heal is required as it
only considers the stbuf values from existing bricks.
To fix this, merge all stbuf values into local->stbuf
and use local->prebuf to store the correct directory
attributes.
Change-Id: Ic9e8b04a1ab9ed1248b6b056e3450bbafe32e1bc
fixes: bz#1648298
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 8dd92f79038f1988bfcb049f6abbf695062991d2
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Aug 30 14:48:51 2018 +0530
cli : fix coverity issue in cli-xml-output.c
This patch fixes 1124659, 1241480 and 1274196.
Change-Id: Ib89f53b8e34fcc47184d08ad57f2ee32fd00d78c
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 54df6374faf210663d3c5e992065ba4f554120f9
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Nov 15 13:18:36 2018 +0530
glusterd/mux: Optimize brick disconnect handler code
Removed unnecessary iteration during brick disconnect
handler when multiplex is enabled.
Change-Id: I62dd3337b7e7da085da5d76aaae206e0b0edff9f
fixes: bz#1650115
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 31d8947a35fc59b6b9dc9c2e8b61721d0316a333
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Oct 29 14:41:26 2018 +0530
lease: Treat unlk request as noop if lease not found
When the glusterfs server recalls the lease, it expects
client to flush data and unlock the lease. If not it sets
a timer (starting from the time it sends RECALL request) and post
timeout, it revokes it.
Here we could have a race where in client did send UNLK
lease request but because of network delay it may have reached
after server revokes it. To handle such situations, treat
such requests as noop and return sucesss.
Change-Id: I166402d10273f4f115ff04030ecbc14676a01663
updates: bz#1648768
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 474a0533a9aa8ff13eb4007cb75e98e88c4e4931
Author: Soumya Koduri <skoduri@redhat.com>
Date: Sun Nov 11 22:53:07 2018 +0530
leases: Fix incorrect inode_ref/unrefs
From testing & code-reading, found couple of places where
we incorrectly unref the inode resulting in use_after_free
crash or ref leaks. This patch addresses couple of them.
a) When we try to grant the very first lease for a inode,
inode_ref is taken in __add_lease. This ref should be active
till all the leases granted to that inode are released (i.e,
till lease_cnt > 0). In addition even after lease_cnt becomes '0',
the inode should be active till all the blocked fops are resumed.
Hence release this ref, after resuming all those fops. To avoid
granting new leases while resuming those fops, defined a new boolean
(blocked_fops_resuming) to flag it in the lease_ctx.
b) 'new_lease_inode' which creates new lease_inode_entry and
takes ref on inode, is used while adding that entry to
client_list and recall_list.
Use its counter function '__destroy_lease_inode' which does unref
while removing those entries from those lists.
c) inode ref is also taken when added to timer->data. Unref the same
after processing timer->data.
Change-Id: Ie77c78ff4a971e0d9a66178597fb34faf39205fb
updates: bz#1648768
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit fe014a6fbdd0d4bc0065db12e04f90ba5cfd5241
Author: Soumya Koduri <skoduri@redhat.com>
Date: Sat Nov 10 05:55:29 2018 -0500
gfapi: Send fop_attr dict as part of syncop_open
Leaseid (stored in thread locals) is sent to server via xdata.
This dict variable is set but not passed as argument in glfs_h_open().
Fixed the same.
Change-Id: Idd2f8a0ec184b4b6b1ad1e6e5d75df551c36a96d
updates: bz#1648768
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit a18310c29d2a78c2f488048b8db98fc6492b2476
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Nov 13 08:12:06 2018 +0530
glusterd: fix Resource leak coverity issue
Problem: In commit bcf1e8b07491b48c5372924dbbbad5b8391c6d81 code
was missed to free path return by function search_brick_path_from_proc
This patch fixes CID:
1396668: Resource leak
Change-Id: I4888c071c1058023c7e138a8bcb94ec97305fadf
fixes: bz#1646892
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit b025d1e907b5bd94431c9d91abd57bad221e5e9d
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Wed Nov 14 16:28:03 2018 +0530
cli: cluster.server-quorum-type help text is missing
Added a default value "none" and additional description.
Change-Id: I3a5c06f8ec1e502fc399860e4b5cb835102cd71d
Updates: bz#1608512
Signed-off-by: Shwetha Acharya <sacharya@redhat.com>
commit c69214316e01ceb0fff7447ccd716a2e6e7cb28f
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Nov 9 02:29:52 2018 -0500
afr: open_ftruncate_cbk should read fd from local->cont.open struct
afr_open stores the fd as part of its local->cont.open struct
but when it calls ftruncate (if open flags contain O_TRUNC), the
corresponding cbk function (afr_ open_ftruncate_cbk) is
incorrectly referencing uninitialized local->fd. This patch fixes
the same.
Change-Id: Icbdedbd1b8cfea11d8f41b6e5c4cb4b44d989aba
updates: bz#1648687
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit d66ff3b8da7ab9f29ecab9acb0ab5daf1241aad0
Author: Kaleb S. KEITHLE <kkeithle@redhat.com>
Date: Fri Nov 9 09:45:05 2018 -0500
core: fix strncpy warnings
Since gcc-8.2.x (fedora-28 or so) gcc has been emitting warnings
about buggy use of strncpy.
Most uses that gcc warns about in our sources are exactly backwards;
the 'limit' or len is the strlen/size of the _source param_, giving
exactly zero protection against overruns. (Which was, after all, one
of the points of using strncpy in the first place.)
IOW, many warnings are about uses that look approximately like this:
...
char dest[8];
char src[] = "this is a string longer than eight chars";
...
strncpy (dest, src, sizeof(src)); /* boom */
...
The len/limit should be sizeof(dest).
Note: the above example has a definite over-run. In our source the
overrun is typically only theoretical (but possibly exploitable.)
Also strncpy doesn't null-terminate on truncation; snprintf does; prefer
snprintf over strncpy.
Mildly surprising that coverity doesn't warn/isn't warning about this.
Change-Id: I022d5c6346a751e181ad44d9a099531c1172626e
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLE <kkeithle@redhat.com>
commit 43f5563f0a3293984a532b456cb8b3c1ac6bd965
Author: Kaleb S. KEITHLE <kkeithle@redhat.com>
Date: Fri Nov 9 11:27:11 2018 -0500
core: fix strncpy warnings
Since gcc-8.2.x (fedora-28 or so) gcc has been emitting warnings
about buggy use of strncpy.
e.g.
warning: ‘strncpy’ output truncated before terminating nul
copying as many bytes from a string as its length
and
warning: ‘strncpy’ specified bound depends on the length of the
source argument
Since we're copying string fragments and explicitly null terminating
use memcpy to silence the warning
Change-Id: I413d84b5f4157f15c99e9af3e154ce594d5bcdc1
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit fd48e70f613a03d9d4e4630d03570f806b8f2ff9
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Nov 8 08:25:00 2018 +0200
rpc/rpc-lib/src/rpc-clnt.c: unlock sooner, if we fail to connect.
Previously, we did not go to unlock the mutex if we failed
to connect. This patch fixes it.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I0fcca066a2601dba6bc3e9eb8b3c9fc757ffe4db
commit 91d2c9ac2ef2194ba8dca7669d911d1cdbdcdb73
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Nov 14 15:26:30 2018 +0530
glusterfsd: Make io-stats xlator search position independent
Problem:
glusterfsd notify trigger for profile info command expects
decompounder xlator to have the name of the brick and its
immediate child to be io-stats xlator. In GD2 decompounder
xlator doesn't exist, so this is preventing io-stats xlator
from receiving the profile info collection notification.
Fix:
search for io-stats xlator below server xlator till the first
instance is found and send notification for it.
fixes bz#1649709
Change-Id: I92a1d9019bbd5546050ab43d50d571c444e027ed
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 68ae1cf95afbb556e046f51e4c93b2a84a40fa41
Author: Susant Palai <spalai@redhat.com>
Date: Tue Nov 13 12:13:03 2018 +0530
posix: Fix null pointer dererfence
CID: 1124799 1214618
Change-Id: Iff05180983fe9600be0a2ce015a137e4efb8f533
updates: bz#789278
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 2ed9fd80a90779929b58238ad7c4f56716e104c1
Author: Susant Palai <spalai@redhat.com>
Date: Thu Nov 8 12:27:07 2018 +0530
feature/shard: Fix coverity issue - Use after free
CID: 1325524
Change-Id: Ic713285bd9e76d8e4dc1815aa471087d279008b5
updates: bz#789278
Signed-off-by: Susant Palai <spalai@redhat.com>
commit e2f7bf1dcb9c5aa87e11aa130f49292f6b64e052
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Nov 13 10:56:05 2018 +0530
glusterd/snapshot: copy-paste typo
Change-Id: Ice3663084b2d0a0a10d75ad68fe5fe494f928250
updates: bz#1193929
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 72c17ffad6678147e5ac39b76b3910a5d974daf9
Author: Susant Palai <spalai@redhat.com>
Date: Thu Nov 8 14:47:27 2018 +0530
features/ctime: Fix Coverity issue
CID : 1394632 Dereference after null check
Change-Id: If0bef48b070935854e9d2988393dba07c9001cd2
updates: bz#789278
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 9b078353503764674fd57643ebf496763b75d996
Author: Prashanth Pai <ppai@redhat.com>
Date: Sat Oct 27 16:32:05 2018 +0530
glusterfsd: Make each multiplexed brick sign in
NOTE: This change will be consumed by brick mux implementation of
glusterd2 only. No corresponsing change in glusterd1 has been made.
When a multiplexed brick process is shutting down, it sends sign out
requests to glusterd for all bricks that it contains. However, sign in
request is only sent for a single brick. Consequently, glusterd has to
use some tricky means to repopulate pmap registry with information of
multiplexed bricks during glusterd restart.
This change makes each multiplexed brick send a sign in request to
glusterd2 which ensures that glusterd2 can easily repopulate pmap
registry with port information.
As a bonus, sign in request will now also contain PID of the brick
sending the request so that glusterd2 can rely on this instead of
having to read/manage brick pidfiles.
Change-Id: I409501515bd9a28ee7a960faca080e97cabe5858
updates: bz#1193929
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit 94328535e968ff50ac08c4bcdf4931d299c8a483
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Sat Sep 29 11:32:17 2018 +0800
md-cache: request ACLs related xattrs when mode change
If glusterfs client changes mode, ACLs related xattrs may changed too.
Change-Id: Ifa5bff1f77ab7b176e54da4607ea9c1e66fc5588
Updates: bz#1634220
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 694c704653df1e061c3683b0542c1f4fb0b9bfc9
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Nov 9 12:44:20 2018 +0530
glusterd: don't call svcs_reconfigure for all volumes during op-version bump up
With having large number of volumes in a configuration having
svcs_reconfigure () called for every volumes makes cluster.op-version bump up to
time out. Instead call svcs_reconfigure () only once.
Change-Id: Ic6a133d77113c992a4dbeaf7f5663b7ffcbb0ae9
Fixes: bz#1648237
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 4368649df53efdeb0a14331ff8e234c83d629f6d
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Nov 8 14:14:04 2018 +0530
quiesce : fix coverity issue
This patch fixes 1388996 : Dereference null return value
updates: bz#789278
Change-Id: I9351ae43736efd2f9abe4e1888dba89b6b3e1fe3
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit b0c4100a5e7dcc327fdfcf22a126862cac194b94
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Nov 7 06:31:19 2018 -0800
features/changelog: Avoid a potential null dereference
Addresses CID 1396292
Change-Id: I9141502a12fb3e18c04d07c79da87a5ebb2cfc23
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit b9c9feb2d752364449280e144d24c81406d1ad86
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Nov 6 16:23:51 2018 +0530
core: Portmap entries showing stale brick entries when bricks are down
Problem: pmap is showing stale brick entries after down the brick
because of glusterd_brick_rpc_notify call gf_is_service_running
before call pmap_registry_remove to ensure about brick instance.
Solutiom: 1) Change the condition in gf_is_pid_running to ensure about
process existence, use open instead of access to achieve
the same
2) Call search_brick_path_from_proc in __glusterd_brick_rpc_notify
along with gf_is_service_running
Change-Id: Ia663ac61c01fdee6c12f47c0300cdf93f19b6a19
fixes: bz#1646892
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 5144d58967571673e016c2f3c26cd01530f0db37
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Nov 8 07:50:48 2018 +0200
rpc-clnt*: several code changes to reduce conn lock times
Assorted code refactoring to reduce lock contention.
Also, took the opportunity to reorder structs more properly.
Removed dead code.
Hopefully, no functional changes.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I5de6124ad071fd5e2c31832364d602b5f6d6fe28
commit f33e6ce97659b09bdb6086542b1b8c84ee6df8d8
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Oct 21 03:55:04 2018 +0300
libglusterfs multiple files: remove dead initilization
Per newer GCC releases and clang-scan, some trivial
dead initialization (values that were set but were never
read) were removed.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ia9959b2ff87d2e9cb46864e68ffe7dccb984db34
commit c9dbcdae7a4c08e2a45a6d90a7f9ac2fb8d3f820
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Nov 8 16:03:23 2018 +0530
cli: avoid unnecessary strtail for geo rep config.
Found while looking at this function for another patch.
Compile Tested Only!
Updates bz#1193929
Change-Id: I46a9e95bf4d6609bc122edf86418659369258abe
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 1ddf6929ec0fef2e6ed7ea7f51e5e3f03088d9af
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Nov 2 09:08:42 2018 +0530
ctime: Enable ctime feature by default
This patch does following.
1. Enable ctime feature by default.
2. Earlier, to enable the ctime feature, two options
needed to be enabled
a. gluster vol set <volname> utime on
b. gluster vol set <volname> ctime on
This is inconvenient from the usability point of
view. Hence changed it to following single option
a. gluster vol set <volname> ctime on
fixes: bz#1624724
Change-Id: I04af0e5de1ea6126c58a06ba8a26e22f9f06344e
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 7c6b30df5d099f365e3176421f84df7e70cefe6b
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Nov 6 21:35:36 2018 +0530
cli: add a warning/confirmation message in peer detach code path
On a multi node cluster if one of the node is detached which had active
clients mounted through the same server address, this can cause all the
clients to loose any volfile changes. This is due to the lack of infra
in glusterd to let client know the list of IPs and attempt to connect to
other active nodes as failback. Such framework does exist in GD2 but not
in GD1.
This patch ensures to take a preventive measure to have a warning
message thrown to user to ensure all such connected clients are
remounted through a different IP.
Change-Id: I740b01868abbd75bf0a609cfaf00114d4d78aa96
Fixes: bz#1647074
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 0196842bfdb6468a4500ba80acf5f51f3bdea152
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Nov 8 10:21:29 2018 +0800
gfapi: fix bad dict setting of lease-id
lease_id is a 16 bits opaque data, copying it by gf_strdup is wrong.
Invalid read of size 2
at 0x483FA2F: memmove (vg_replace_strmem.c:1270)
by 0xE2EF6FB: ??? (in /usr/lib64/libtirpc.so.3.0.0)
by 0xE2EE047: xdr_opaque (in /usr/lib64/libtirpc.so.3.0.0)
by 0x107A97DC: xdr_gfx_value (glusterfs4-xdr.c:207)
by 0x107A98C0: xdr_gfx_dict_pair (glusterfs4-xdr.c:321)
by 0xE2EF35E: xdr_array (in /usr/lib64/libtirpc.so.3.0.0)
by 0x107A9A89: xdr_gfx_dict (glusterfs4-xdr.c:335)
by 0x107AA97B: xdr_gfx_write_req (glusterfs4-xdr.c:897)
by 0x107A181E: xdr_serialize_generic (xdr-generic.c:25)
by 0x231044A2: client_submit_request (client.c:205)
by 0x2314D3C1: client4_0_writev (client-rpc-fops_v2.c:3863)
by 0x230FD5FA: client_writev (client.c:956)
Address 0xad659e18 is 72 bytes inside a block of size 73 alloc'd
at 0x483880B: malloc (vg_replace_malloc.c:299)
by 0x106BA7EC: __gf_malloc (mem-pool.c:136)
by 0x1064521E: gf_strndup (mem-pool.h:166)
by 0x1064521E: gf_strdup (mem-pool.h:183)
by 0x1064521E: get_fop_attr_thrd_key (glfs.c:627)
by 0x1064D8E9: glfs_pwritev@@GFAPI_3.4.0 (glfs-fops.c:1154)
by 0x10610C0C: glusterfs_write2 (handle.c:2092)
by 0x54D30C: mdcache_write2 (mdcache_file.c:647)
by 0x48A3FC: nfs4_write (nfs4_op_write.c:459)
by 0x48A44D: nfs4_op_write (nfs4_op_write.c:487)
by 0x4634F5: nfs4_Compound (nfs4_Compound.c:947)
by 0x460155: nfs_rpc_process_request (nfs_worker_thread.c:1329)
by 0x4608A3: nfs_rpc_valid_NFS (nfs_worker_thread.c:1539)
by 0x488F12F: svc_vc_decode (svc_vc.c:825)
Updates bz#1647651
Change-Id: Ib9fff55c897bc43c15036a869888e763df133757
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit d050aa8f468a1cd49a2a40b48f442aa31db12433
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Nov 6 19:44:16 2018 +0530
glusterd: allow shared-storage to use bricks under glusterd working directory
With commit 44e4db, we are not allowing user to create a volume
using glusterd's working directory as a brick or any sub directory
under glusterd's working directory as a brick.This has broken
shared-storage since the volume "gluster-shared-storage" is
created using the bricks under glusterd's working directory.
With this patch, we let the "gluster-shared-storage" volume
to use bricks under glusterd's working directory.
fixes: bz#1647029
Change-Id: Ifcbcf4576eea12cf46f199dea287b29bd3ec3bfd
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 7f52271dd4c5814c144127fff173ae5c17420ffb
Author: ShyamsundarR <srangana@redhat.com>
Date: Wed Nov 7 15:17:55 2018 -0500
coverity: ignore tainted access reported in gf_free
Earlier commit had the annotation incorrect, and also did not
wrap the sanitization in a separate function. (see commit 39a1db1)
The issues are corrected in this patch, and also a coverity
stand alone run has been tested to ensure the annotations are
respected by coverity.
Change-Id: I4a93b6981e2ff4bba9a29e590b17da248931c8ae
Updates: bz#789278
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 4b90fb21e9a1ed8c535d866cc958e5a1f41fa0e0
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Aug 10 15:57:50 2018 +0530
bd: remove from the build
Based on the proposal to remove few features as they are not
actively maintained [1], removed BD (block device) translator
from the build.
[1] - https://lists.gluster.org/pipermail/gluster-users/2018-July/034400.html
Updates: bz#1635688
Change-Id: Ia96db406c58a7aef355dde6bc33523bb2492b1a9
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 736830209d64b5ce56d2efabd7493b573317dfb4
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Nov 6 10:12:10 2018 -0800
features/locks:Use pthread_mutex_unlock() instead of pthread_mutex_lock()
Fixes CID 1396581
Change-Id: Ic04091b5783a75d8e1e605a9c1c28b77fea048d3
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 556647fcb8fea962209d032383bbcab1a788da12
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Oct 3 17:13:09 2018 +0530
glupy: remove from the build
Based on the proposal to remove few features as they are not
actively maintained [1], removing 'glupy' translator from the
build.
[1] https://lists.gluster.org/pipermail/gluster-users/2018-July/034400.html
This patch aims at clearing the translator from build and tests.
A followup is needed to remove the code from repository.
Updates: bz#1642810
Change-Id: I41d0c1956330c3bbca62c540ccf9ab01bbf3a092
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 970f2dc06bfffea4e1732bd458b1cdfffc0924a6
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Nov 2 10:39:58 2018 +0530
xlators/experimental: remove from the build
Based on the proposal to remove few features as they are not
actively maintained [1], removing all experimental translators
from the build.
[1] https://lists.gluster.org/pipermail/gluster-users/2018-July/034400.html
Note that as followup patch, there would be a patch to remove the code.
Updates: bz#1635688
Change-Id: I8ebc256517feb37fc7580104e8bebe27d047f959
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit e7d924d17b31069b94459e1b9960749ab8fbdaae
Author: Hu Jianfei <hujianfei@cmss.chinamobile.com>
Date: Tue Nov 6 06:47:08 2018 -0500
glusterfsd: Do not process GLUSTERD_NODE_STATUS if graph is not ready
Otherwise, gnfs will crash if we try to get nfs clients status in
following situation. Also see commit 2f9e555f.
Reproducible Steps:
1. systemctl restart glusterd; gluster volume status rep
2. systemctl restart glusterd; gluster volume status rep nfs clients
step 1 works ok, but step 2 will lead localhost gnfs crash with
certain probability.
/lib64/libglusterfs.so.0(+0x270f0)[0x7effb6c7b0f0]
/lib64/libglusterfs.so.0(gf_print_trace+0x334)[0x7effb6c854a4]
/lib64/libc.so.6(+0x35270)[0x7effb52e7270]
/usr/sbin/glusterfs(glusterfs_handle_node_status+0x155)[0x7effb7196905]
/lib64/libglusterfs.so.0(+0x63f40)[0x7effb6cb7f40]
/lib64/libc.so.6(+0x46d40)[0x7effb52f8d40]
Updates: bz#1646869
Change-Id: Ia4cb009f821d32b2d18ba48d3467cc81a4b07747
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Signed-off-by: Hu Jianfei <hujianfei@cmss.chinamobile.com>
commit 92e41834e03721053cdb599ff08db89497d01782
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Nov 6 21:27:33 2018 +0530
cluster/afr: s/uuid_is_null/gf_uuid_is_null
Updates bz#1193929
Change-Id: I1b312dabffac7e101df8ce15557527fd28a2c61f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit c3b2078d7cdcaa24530a8f829b9888d30af857a2
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Nov 6 18:18:30 2018 +0200
libglusterfs/src/iobuf.c: don't forget to unlock a mutex
commit ed83a4ee7b73e6b04694d1ac11ed25d2983ac943 changed locking
order and forgot to unlock in a negative path (when index was -1).
Coverity caught it (thanks!) as CID 1396581: Program hangs (LOCK)
Note: I'm unlocking before logging the failure. I think it's the right
order - logging can take a while (especially if your disk is slow).
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I82ac241edf1d511bf6807cf9c46c538ab9f4acc4
commit e45ec16ef091bc58aec16cf19c36915c16eb1b4e
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Nov 6 15:58:45 2018 +0530
tests/interrupt.t: remove 'stripe' volume type
Merged the patch which introduced this testcase after the
'remove stripe' patch got merged, and hence the confusion.
Updates: bz#1193929
Change-Id: Ia08552debb111292caf14e51ea6a27334fe5c788
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 9008f79d2376e092c161f1053182920b7d40b66d
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Mon Oct 15 15:41:23 2018 +0800
md-cache: new option "cache-glusterfs-acl" for virtual glusterfs ACLs
Change-Id: I020ab08dba48f13cf7b8908e96280f1e92e9b9db
Updates: bz#1634220
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit b5bc17c36ef88b02ec64656d68aec84b58720ec2
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Sat Sep 29 11:54:07 2018 +0800
md-cache: request cached xattrs at getxattr/fgetxattr
Change-Id: I8e3ad961164815683776850e3a5fd4f510003690
Updates: bz#1634220
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 7cda866f421b9b853770b6b126ff3e15990076b4
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Sat Sep 29 11:45:11 2018 +0800
md-cache: extends xa_time when previous attributes equals cached attributes
Some operations like read/write only update iatt and ia_time,
without any operion request xattrs from glusterfsd,
the xa_time is timeout before ia_time always.
This patch updates xa_time when update ia_ttime.
Change-Id: I77e3984f38c1c4dbebfde9729b8117fbacde9674
Updates: bz#1634220
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 258e4bcb7baf0da7d79bf058a4a440498a1cf795
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Mon Oct 15 16:15:17 2018 +0800
md-cache: remove xattr setting after new file created
Fops of creating file does not request cached xattrs,
the xattr in reply is not cached xattrs.
Change-Id: Iab2db686e92466e72cfee8ac494e851d797c10b3
Updates: bz#1634220
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 05fca0545a940412c74d59db41eff6df4551f693
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Nov 5 11:28:46 2018 +0530
glusterd: initialise caps inside #ifdef HAVE_BD_XLATOR block
Note: The problem is seen when we disable bd xlator.
Problem: When we create a volume, volume info file is having
caps value as 15 in nodes which hosts bricks for that volume.
Remainig nodes in cluster are not having caps field. When
glusterd is restarted, peers are going into rejected state,
because of this mismacth in configuration files.
Cause: In glusterd_op_create_volume(), we initialise caps
value as 15 in the beginning. Later, we check whether brick
belongs to the same node or not. If brick doesn't belong to
the same node, caps value will be set to 0. If brick belongs
to the same node, we will change the caps value inside
Solution: If brick doesn't belongs to the same node,caps is
set to 0 and if brick belongs to same brick caps value is
changed inside #ifdef HAVE_BD_XLATOR block. So, to have the
consistency across the cluster, we need to initialise caps
value inside #ifdef HAVE_BD_XLATOR block, only when brick
belongs to the same node.
fixes: bz#1645986
Change-Id: I2648f420b21d6e69e7c38b0f4736d41e0f15a7f5
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 9322e22cb014422b1603ea77786ddebc524b6f2d
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Sep 20 23:19:39 2018 +0530
doc: add a new contributor 'hints' guide
Keeping this in glusterfs Repo for glusterfs specific improvements.
There would be a link to this page, and some more similar pages from
docs.gluster.org
updates: bz#1193929
Change-Id: Ie98670cc32e62951f1b1880b1ae39f5cc2b45329
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit c1559c49ef699cd69fe489ffad642023dcf11915
Author: Susant Palai <spalai@redhat.com>
Date: Fri Nov 2 09:23:42 2018 +0530
lock: Do not allow meta-lock count to be more than one
In the current scheme of glusterfs where lock migration is
experimental, (ideally) the rebalance process which is migrating
the file should request for a metalock. Hence, the metalock count
should not be more than one for an inode. In future, if there is a
need for meta-lock from other clients, this patch can be reverted.
Since pl_metalk is called as part of setxattr operation, any client
process(non-rebalance) residing outside trusted network can exhaust
memory of the server node by issuing setxattr repetitively on the
metalock key. The current patch makes sure that more than
one metalock cannot be granted on an inode.
Fixes CVE-2018-14660
updates: bz#1644758
Change-Id: Ie1e697766388718804a9551bc58351808fe71069
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 291eeb156e43e524ee2ae0da9988afbb83bc7185
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Aug 21 12:44:54 2018 +0200
fuse: diagnostic FLUSH interrupt
We add dummy interrupt handling for the FLUSH
fuse message. It can be enabled by the
"--fuse-flush-handle-interrupt" hidden command line
option, or "-ofuse-flush-handle-interrupt=yes"
mount option.
It serves no other than diagnostic & demonstational
purposes -- to exercise the interrupt handling framework
a bit and to give an usage example.
Documentation is also provided that showcases interrupt
handling via FLUSH.
Change-Id: I522f1e798501d06b74ac3592a5f73c1ab0590c60
updates: #465
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit efb5902add43c1ddf55c527687f3c3bcb2872138
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Aug 9 11:46:33 2018 +0200
fuse: interrupt handling framework
- add sub-framework to send timed responses to kernel
- add interrupt handler queue
- implement INTERRUPT
fuse_interrupt looks up handlers for interrupted messages
in the queue. If found, it invokes the handler function.
Else responds with EAGAIN with a delay.
See spec at
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/filesystems/fuse.txt?h=v4.17#n148
and explanation in comments.
Change-Id: I1a79d3679b31f36e14b4ac8f60b7f2c1ea2badfb
updates: #465
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 8d9e18ae391cbf04937b78b872dcb4d5d506d8ed
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Nov 4 16:17:27 2018 +0200
libglusterfs/src/iobuf.c: where possible, pass the index parameter
Don't 'calculate' again where it can be passed.
If possible, do not perform under lock.
Also remove some NULL checks, assuming they were done by the callers.
Left a remark for each such change.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ia5c2851506da3388cb2d4445334c58881e2c4416
commit 6a625724cdd39d17870283f13a1a1ca1ebedf321
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Nov 4 13:47:25 2018 +0200
libglusterfs/src/iobuf.c: take the pool lock once in new pool
When creating a new pool, take the pool lock once and create
all arenas, instead of taking and releasing for each arena.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I7daa39de960e47e66a32ecab724cf3a61ccdc01b
commit 9c494bb7101f8c5cd20555d451a9fd7ccf21bb42
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Nov 4 11:00:11 2018 +0200
libglusterfs/src/iobuf.c: remove some if statements
Small code refactoring to remove some if statements
in several functions. No functional changes expected.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: If9f8d5d53c9688fb994b6d690aea66f65fa01c55
commit b7a6006b69a9cc910000beee679478316aba786c
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Nov 2 10:39:18 2018 +0530
logging: create parent dir if not available
As glusterfs logging uses different directory than /var/log
(ie, /var/log/glusterfs), there is a chance it may not be
present when starting glusterfs. Create parent dir if it
doesn't exist.
Updates: bz#1193929
Change-Id: I8d6f7e5a608ba53258b14617f5d103d1e98b95c1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 417c19f0b736bca5b7f3d7fad2120b26a7473bf7
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Nov 5 11:46:41 2018 +0530
geo-rep: Fix traceback with symlink metadata sync
While syncing metadata, 'os.chmod', 'os.chown',
'os.utime' should be used without de-reference.
But python supports only 'os.chown' without
de-reference. That's mostly because Linux
doesn't support 'chmod' on symlink file itself
but it does support 'chown'.
So while syncing metadata ops, if it's symlink
we should only sync 'chown' and not do 'chmod'
and 'utime'. It will lead to tracebacks with
errors like EROFS, EPERM, ACCESS, ENOENT.
All the three errors (EPERM, ACCESS, ENOENT)
were handled except EROFS. But the way it was
handled was not fool proof. The operation is
tried and failure was handled based on the errors.
All the errors with symlink file for 'chown',
'utime' had to be passed to safe errors list of
'errno_wrap'. This patch handles it better by
avoiding 'chmod' and 'utime' if it's symlink
file.
fixes: bz#1646104
Change-Id: Ic354206455cdc7ab2a87d741d81f4efe1f19d77d
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 713a90b20be8d3d8fbb773e1f644db6811b2589b
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Nov 1 07:25:25 2018 +0530
all: fix the format string exceptions
Currently, there are possibilities in few places, where a user-controlled
(like filename, program parameter etc) string can be passed as 'fmt' for
printf(), which can lead to segfault, if the user's string contains '%s',
'%d' in it.
While fixing it, makes sense to make the explicit check for such issues
across the codebase, by making the format call properly.
Fixes: CVE-2018-14661
Fixes: bz#1644763
Change-Id: Ib547293f2d9eb618594cbff0df3b9c800e88bde4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit f5929c1f903b5c174a2f6897bd366da841fdf826
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Nov 1 07:16:32 2018 +0530
protocol: remove the option 'verify-volfile-checksum'
'getspec' operation is not used between 'client' and 'server' ever since
we have off-loaded volfile management to glusterd, ie, at least 7 years.
No reason to keep the dead code! The removed option had no meaning,
as glusterd didn't provide a way to set (or unset) this option. So,
no regression should be observed from any of the existing glusterfs
deployment, supported or unsupported.
Updates: CVE-2018-14653
Updates: bz#1644756
Change-Id: I4a2e0f673c5bcd4644976a61dbd2d37003a428eb
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 147ee90be7e15aa5b172c847c9b030347b177420
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Nov 1 07:02:11 2018 +0530
server: don't allow '/' in basename
Server stack needs to have all the sort of validation, assuming
clients can be compromized. It is possible for a compromized
client to send basenames with paths with '/', and with that
create files without permission on server. By sanitizing the basename,
and not allowing anything other than actual directory as the parent
for any entry creation, we can mitigate the effects of clients
not able to exploit the server.
Fixes: CVE-2018-14651
Fixes: bz#1644755
Change-Id: I5dc0da0da2713452ff2b65ac2ddbccf1a267dc20
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit d51da0c3ec2bba15c3f12db5d88614b252d1f75e
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Nov 1 07:21:41 2018 +0530
io-stats: prevent taking file dump on server side
By allowing clients taking dump in a file on brick process, we are
allowing compromised clients to create io-stats dumps on server,
which can exhaust all the available inodes.
Fixes: CVE-2018-14659
Fixes: bz#1644757
Change-Id: I32bfde9d4fe646d819a45e627805b928cae2e1ca
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 54b5e082628fa80e08280fb7c544325b21f21198
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Sat Nov 3 23:09:40 2018 +0530
glusterd : fix high sev coverity issue
This patch fixes CID : 1174824 : RESOURCE_LEAK
updates: bz#789278
Change-Id: I2a4f8b508995de112fa16e1094e44ecd4b625312
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 2109ec7d2856b7abae01bb81b1879412764fc433
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Nov 1 21:31:41 2018 +0530
index: prevent arbitrary file creation outside entry-changes folder
Problem:
A compromised client can set arbitrary values for the GF_XATTROP_ENTRY_IN_KEY
and GF_XATTROP_ENTRY_OUT_KEY during xattrop fop. These values are
consumed by index as a filename to be created/deleted according to the key.
Thus it is possible to create/delete random files even outside the gluster
volume boundary.
Fix:
Index expects the filename to be a basename, i.e. it must not contain any
pathname components like "/" or "../". Enforce this.
Fixes: CVE-2018-14654
Fixes: bz#1644760
Change-Id: I35f2a39257b5917d17283d0a4f575b92f783f143
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 72efdb99e3c4b28f0edae56389739a0a4b9c6056
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Oct 16 15:34:20 2018 -0400
features/snapview-server: change gf_log instances to gf_msg
Change-Id: Ib8bdf210a896423abcd7413dd4896d424ac0f561
fixes: bz#1626610
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit ef0b44306616f23a6ca0b21cec1af276ceb7a2fc
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Oct 18 17:46:26 2018 +0800
dht: fix use after free in dht_rmdir_readdirp_cbk
The frame is freed when linkfile exist in dht_rmdir_is_subvol_empty(),
the following message use the freed local.
Change-Id: I41191e8bd477f031a2444d5f15e578dc4f086e6b
Updates: bz#1640489
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 216b801160258161aba5ce63c3b6a255df524374
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sat Nov 3 12:13:29 2018 +0530
glusterd: coverity fixes
Addresses CIDs : 1124769, 1124852, 1124864, 1134024, 1229876, 1382382
Also addressed a spurious failure in
tests/bugs/glusterd/df-results-post-replace-brick-operations.t to ensure
post replace brick operation and before triggering 'df' from mount,
client has connection to the newly replaced bricks.
Change-Id: Ie5d7e02f89400a661491d7fc2a120d6f6a83a1cc
Updates: bz#789278
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 1d044c94f3385fa50204badc75f264dadda5da72
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Oct 30 20:22:41 2018 +0530
posix : fix coverity issues in posix-entry-ops.c
This patch fixes CID:
1. 1389762 : Explicit null dereferenced
2. 1390462 : Argument cannot be negative
3. 1124552 : Explicit null dereferenced
4. 1356522 : Argument cannot be negative
updates: bz#789278
Change-Id: I1262f3b4b61a6e65bb34884f46df9a24b8dd03f1
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 7fe55146b00d16a1ef1d1ac175f7ca4a7d98d141
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Sep 26 00:30:26 2018 +0530
glusterd : fix high coverity issues glusterd-store.c
This patch fixes CID 1224305, 1202395, 1202394, 1174824, 1174825, 1174826
and 1202397.
All issues are of RESOURCE_LEAK type.
Change-Id: Ie9944d5bdd0bd2788afdb1b6bb329aa3c44b90d0
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit db28cc34273bfdf35ecaf9b26dd49e14fc7b8862
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Oct 18 19:42:48 2018 +0800
md-cache: removexattr must be send to glusterfsd
Change-Id: I53a583ec14bce65e8914bc496123dee3abe61f6c
Updates: bz#1634220
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 0cb33598d32876bddd0a5321b0b91982429e557c
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Oct 17 23:03:04 2018 +0530
xlator: add generic option parsing framework
As an example, and also as an enhancement, added 'log-level'
as a default option to every translator (glusterfs already
support infrastructure to handle xl->loglevel).
Corresponding infrastructure to add per xlator log-level
is not present in glusterd volume-set. Plan is to get it
sorted out in later patches or in GD2.
* Why this is needed? - Mainly because we need to only add
different log-level to some xlator to debug few things in a
production system, while not changing overall log-level. This
helps in better debug-ability.
Updates: bz#1193929
Change-Id: Ia4098ce39197cd423345b3d31fe8315481681ab8
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 4114d71175d39638d931b0a3ec3a98083a55afbc
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Oct 3 17:00:24 2018 +0530
tiering: remove the translator from build and glusterd
Based on the proposal to remove few features as they are not
actively maintained [1], removing tier translator from the
build. Also make sure there are no regression tests involving
tiering feature are present.
[1] https://lists.gluster.org/pipermail/gluster-users/2018-July/034400.html
Change-Id: I2c177f711f9b54b7b24e1a13525ff3132bd9a9c5
updates: bz#1642807
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit ee4823ab165a2647a7f1a5177007c7fd2c811df1
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Oct 30 16:36:50 2018 +0530
glusterd: set fsid while performing replace brick
While performing the replace-brick operation, we should set
fsid value to the new brick.
fixes: bz#1637196
Change-Id: I9e9a4962fc0c2f5dff43e4ac11767814a0c0beaf
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit a207d2c30ffb40161809bf35c91a145fbd30132b
Author: Varsha Rao <varao@redhat.com>
Date: Mon Oct 29 09:53:27 2018 +0530
posix: Fix coverity issue
This patch fixes the unchecked return value, coverity issue.
CID: 1391412
Change-Id: If85f4afdf8c6d37602c62fbf4d7c730e18be81e7
updates: bz#789278
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 701014ef4f2033ea540a98c0c35b505c388357d3
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Oct 30 10:56:52 2018 +0530
posix/ctime: Avoid log flood in posix_update_utime_in_mdata
posix_update_utime_in_mdata() unconditionally logs an error if
consistent time attributes features is not enabled. This log
does not add any value, prints an incorrect errno & floods
the log file. Hence nuking this log message in this patch.
fixes: bz#1644129
Change-Id: I9a1f9e7ada3366d2830f18d81f16a1461040092e
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 606976cc862bb6910ea1a8b0162aecea5e9d262c
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Nov 1 07:08:29 2018 +0530
glusterd-handshake: prevent a buffer overflow
as key size in xdr can be anything, it can be bigger than the
'NAME_MAX' allowed in the structure, which can allow for service denial
attacks.
Fixes: CVE-2018-14653
Fixes: bz#1644756
Change-Id: I2dc5e99af27ddf44c12c94b07e51adb8674cce80
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 74b236658d390b28974f7e7d526785e151b28cc5
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Oct 29 14:16:20 2018 +0530
mem-pool: change the values to 64bits
total_allocs of certain type of variables can be 4billion in a
single day depending on load. So, 32 bits for that is not enough.
Also, size_t is good variable size for one allocation, but the
sum of allocations, should be 64bits to make sure we don't
overflow the variable.
Updates: bz#1639599
Change-Id: If3b19687f94425e913a0201ae5d73661eda51f06
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 1b80ae60d3070e6dafc3a1722cda4d7d3ccfe2b1
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Oct 31 12:26:43 2018 +0100
cluster/ec: prevent infinite loop in self-heal full
There was a problem in commit 7f81067 that caused infinite loop when
full heal was triggered.
The previous commit was made to prevent self-heal to go idle after a
replace brick operation. One of the changes consisted on setting a
flag to force an immediate scan of the dirty directory if a heal on
a directory succeeded (assuming it could have generated newer entries).
However that change was causing an issue with a full self-heal, since
every time an already healed directory was checked and it returned
suceessfully, it was also setting the flag, forcing self-heal to start
over again.
This patch fixes this issue by only setting the flag if the heal is not
full. It's assumed that a full self-heal will already traverse all
entries automatically, so there's no need to force a new scan later.
Change-Id: Id12dbfc04e622b18183e796cc6cc87ccc30a6d55
fixes: bz#1636631
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 058e9d7db0ba9fcdac2abb7b8ff989192030279a
Author: Harpreet Lalwani <hlalwani@redhat.com>
Date: Thu Oct 4 16:09:08 2018 +0530
cluster/dht: NULL pointer dereferencing clang fix
Dereferencing NUll pointers this,local and stbuf.
1.Replaced this->name with "dht".
2.Removed GF_VALIDATE_OR_GOTO.
3.Removed the check for "stbuf" and "this".
Updates: bz#1622665
Change-Id: Id2fb2270d5ec37b76fa2aae1f1c8dca72dcc728a
Signed-off-by: Harpreet Lalwani <hlalwani@redhat.com>
commit 72581a98c5188c81defbfee0a8877cba3df876a6
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Oct 17 15:18:34 2018 +0530
cluster/ec: Change log level to DEBUG for lookup combine
As lookup is not a locked fop, we can not trust the
data received in this to be same.
Changing the log level to DEBUG in case lookup finds any
difference.
Change-Id: I39499c44688a2455c7c6c69a798762d045d21b39
updates: bz#1640066
BUG: 1640066
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit ef9581cb473ac1cbb8c338e84fa99993859bc14c
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Oct 25 12:37:42 2018 +0530
tests: brick-mux-fd-cleanup.t should be under core directory
Fixes: bz#1637934
Change-Id: I5f95beab62bd2bdde3bbee94c308b0ad03e94379
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 2e542e011fd919994e45b79568865e12c69c6902
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Oct 3 15:30:10 2018 +0530
stripe: remove the translator from build and glusterd
Based on the proposal to remove few features as they are not
actively maintained [1], removing stripe translator from the
build. Also make sure there are no regression tests involving
stripe translator.
[1] https://lists.gluster.org/pipermail/gluster-users/2018-July/034400.html
Note that this patch aims at removing the translator from build, and
a followup patch is needed to remove the code from repository.
Updates: bz#1364707
Change-Id: I235b305338f138e29e9f30cba65bc0dadbebbbd5
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit ccf90d6cc4e9401e13373a1777372f0d339752f0
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Oct 26 03:45:46 2018 -0400
geo-rep: Add more intelligence to automatic error handling
Geo-rep's automatic error handling does gfid conflict
resolution. But if there are ENOENT errors because the
parent is not synced to slave, it doesn' handle them.
This patch adds the intelligence to create missing
parent directories on slave. It can create the missing
directories upto the depth of 10.
fixes: bz#1643402
Change-Id: Ic97ed1fa5899c087e404d559e04f7963ed7bb54c
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 364e2b29e180357b7d04f38ae14e9299391b64ea
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Oct 29 18:23:17 2018 +0530
geo-rep/scripts: Fix traceback in gluster-mountbroker
When 'gluster-mountbroker status' was issued, it
crashes in a corner case with 'str object has not
attribute get'. Fixed the same.
fixes: bz#1643929
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Change-Id: Iaf1a937ed0136b3b2058230c75fa89a215d8a5eb
commit 9855738123a7d1ba1fde2d3b5d43c634008be42a
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Oct 29 17:55:28 2018 +0530
georep: python2 to python3 compat - scheduler
1. scheduler - Popen
2. syncdutils - corner case on failure
fixes: bz#1643932
Change-Id: I65af97a244a8790e976acedc2728db6ebbf2ae10
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit d0e9309c6da82485b94c8d153006915162196924
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Oct 30 12:35:59 2018 +0530
core: Use GF_ATOMIC ops to update inode->nlookup
fixes: bz#1644164
Change-Id: I0ac5aff565b3a30d5ff25ec5a3f20e0bda424a5d
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 7981dcc12f2e401f333230c741c22f35cd2e2e43
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Oct 29 18:08:28 2018 +0530
cliutils: python2 to python3 compat
Make Popen py2 and py3 compatiable
fixes: bz#1643935
Change-Id: Ife34cb38024dcdc0420436e7d76fd208223f9d86
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 54fe7d5e5a91acd7ae5ce93e28faea1260262637
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Tue Oct 23 12:57:45 2018 +0530
rpc-transport/socket: NULL pointer dereferencing clang fix
Problem: ctx and res can be NULL.
Solution: introduced a VALIDATE_OR_GOTO statement, hence removed
the null check for ctx; added a check for res.
Updates: bz#1622665
Change-Id: Ifee4c73e260530ab44c0a34c5ff5568f38f92c94
Signed-off-by: Shwetha Acharya <sacharya@redhat.com>
commit 3f6b32732e529988e9fe56fedbbf55bdad38750d
Author: Harpreet Kaur Lalwani <hlalwani@redhat.com>
Date: Thu Oct 25 18:48:22 2018 +0530
core: auth.ssl-allow has no option description
Added a description for auth.ssl-allow
Change-Id: I50cd7c738007c3d7a1b333dae62dbb5e46a7ee67
fixes: bz#1643349
Signed-off-by: Harpreet Kaur Lalwani <hlalwani@redhat.com>
commit 4faf8892dbf93221bab53a605a6ce299d037f7bb
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Oct 26 09:28:59 2018 -0400
build/packaging: el-X (x > 7) isms
lvm2(-devel) 2.03.00 no longer has liblvm2app.so. (I expect a
similar change in fedora-30 before too much longer, but for
now fedora-30 still has lvm2 and lvm2-devel 2.02.181
rpcgen has been removed from glibc-common and unbundled rpcgen
is now required.
And I guess nobody has ever built rpms with '--without bd' or we
would have discovered the attempted inclusion of .../storage/bd.so
in the rpm when it hadn't actually been built.
Change-Id: I71e26c3d06af5d329ae89cc249a4ad88664ddf53
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit e7c268caa245e93ce89a03caf72a48d6f32486f1
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Oct 12 22:23:17 2018 +0530
server-protocol: set the frame type to TYPE_FOP
This will allow proper printing of exact 'fop' type to be logged in
string, not number, during backtraces.
Considering this was not done on brick processes, we have no easy
way to glance and understand which fops were pending.
What gets changed:
After a crash, most of the core-dumps logged were of the form:
```
pending frames:
frame : type(0) op(18)
frame : type(0) op(18)
frame : type(0) op(28)
```
would change to
```
pending frames:
frame : type(1) op(SETXATTR)
frame : type(1) op(SETXATTR)
frame : type(1) op(READDIR)
```
updates: bz#1639599
Change-Id: I0e3d2a8dee9cfde7ed0112a948f5213f546efb80
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit b19445ad60ee1920eebc604e2b3be6e28868bbe4
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Oct 25 03:23:56 2018 -0400
geo-rep: Fix issue in gfid-conflict-resolution
Problem:
During gfid-conflict-resolution, geo-rep crashes
with 'ValueError: list.remove(x): x not in list'
Cause and Analysis:
During gfid-conflict-resolution, the entry blob is
passed back to master along with additional
information to verify it's integrity. If everything
looks fine, the entry creation is ignored and is
deleted from the original list. But it is crashing
during removal of entry from the list saying entry
not in list. The reason is that the stat information
in the entry blob was modified and sent back to
master if present.
Fix:
Send back the correct stat information for
gfid-conflict-resolution.
fixes: bz#1642865
Change-Id: I47a6aa60b2a495465aa9314eebcb4085f0b1c4fd
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 536d38c0cffa29521d74c6a5c50bb746f583b6de
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Oct 25 13:05:13 2018 +0530
transport: log socket closures more verbose
Problem:
Intentional and unintentional socket closures cannot be identified
Solution:
Log intentional socket closures with at least INFO log level
Change-Id: Ic02c882b16ab2193e57f8c3e6c3a82c4fe0f6875
fixes: bz#1642800
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 49f9cbf0b30ba26c4cdd13189240cd6ba9bb1998
Author: Harpreet Lalwani <hlalwani@redhat.com>
Date: Tue Oct 23 18:23:53 2018 +0530
posix: Null pointer dereferencing clang fix
Added a check for "top"
Updates: bz#1622665
Change-Id: I354fdc7150b2f1eb452702ddb653e2d6ed609c10
Signed-off-by: Harpreet Lalwani <hlalwani@redhat.com>
commit 637e4f227cb17dfc05587ab5460e470885129fa2
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Oct 25 19:48:37 2018 +0530
statedump: fix clang null dereference error
ctx->active can be null, and is checked elsewhere in the
same function. In another case, where 'ctx->active' gets
dereferenced, it needs to be validated before the loop
is hit.
Updates: bz#1622665
Change-Id: I4ec917e96c0756586fc7a74c76848bb9589a0293
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 40845db6a75a2c9a5b78fe027e77277da7d5bc45
Author: root <root@rhs-srv-17.storage-dev.lab.eng.bos.redhat.com>
Date: Thu Oct 25 05:47:23 2018 -0400
afr/lease: Read child nodes from lease structure
For lease operation, we allocate and store child nodes
data in lease structure. Use the same in afr_lease_cbk()
while checking for the quorum.
Change-Id: If1fdd5a0798888afd39ad3df57d96487baf9d1e6
updates: #350
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 4879a1b70ea1472eb0bd2967101e9c97385cda93
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Oct 25 14:03:07 2018 +0530
glusterd: raise default transport.listen-backlog
Problem:
data center setups with large number of bricks with replication
causes a flood of connections from bricks and self-heal daemons
to glusterd causing connections to be dropped due to insufficient
listener socket backlog queue length
Solution:
raise default value of transport.listen-backlog to 1024
Change-Id: I879e4161a88f1e30875046dff232499a8e2e6c51
fixes: bz#1642850
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit be7bc03f39cbe97bd944cf67cf32ef3c51746c83
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Sep 23 16:59:58 2018 +0530
afr: thin-arbiter 2 domain locking and in-memory state
2 domain locking + xattrop for write-txn failures:
--------------------------------------------------
- A post-op wound on TA takes AFR_TA_DOM_NOTIFY range lock and
AFR_TA_DOM_MODIFY full lock, does xattrop on TA and releases
AFR_TA_DOM_MODIFY lock and stores in-memory which brick is bad.
- All further write txn failures are handled based on this in-memory
value without querying the TA.
- When shd heals the files, it does so by requesting full lock on
AFR_TA_DOM_NOTIFY domain. Client uses this as a cue (via upcall),
releases AFR_TA_DOM_NOTIFY range lock and invalidates its in-memory
notion of which brick is bad. The next write txn failure is wound on TA
to again update the in-memory state.
- Any incomplete write txns before the AFR_TA_DOM_NOTIFY upcall release
request is got is completed before the lock is released.
- Any write txns got after the release request are maintained in a ta_waitq.
- After the release is complete, the ta_waitq elements are spliced to a
separate queue which is then processed one by one.
- For fops that come in parallel when the in-memory bad brick is still
unknown, only one is wound to TA on wire. The other ones are maintained
in a ta_onwireq which is then processed after we get the response from
TA.
Change-Id: I32c7b61a61776663601ab0040e2f0767eca1fd64
updates: bz#1579788
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 669228ed82f965bb36b0da853bcdf7df8b0d2fb4
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Oct 3 23:58:37 2018 +0530
glusterd: ensure volinfo->caps is set to correct value.
With the commit febf5ed4848, during the volume create op,
we are setting volinfo->caps to 0, only if any of the bricks
belong to the same node and brickinfo->vg[0] is null.
Previously, we used to set volinfo->caps to 0, when
either brick doesn't belong to the same node or brickinfo->vg[0]
is null.
With this patch, we set volinfo->caps to 0, when either brick
doesn't belong to the same node or brickinfo->vg[0] is null.
(as we do earlier without commit febf5ed4848).
fixes: bz#1635820
Change-Id: I00a97415786b775fb088ac45566ad52b402f1a49
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 9fd7f0281e1338d194dbd29e74f19f23c6639b9c
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Oct 24 15:23:34 2018 +0530
posix : fix coverity issues in posix-inode-fd-ops.c
This patch fixes CID: 1356526 and 1382369 : Argument cannot be negative
Change-Id: I1aab5be2d217479db9f67a26b62854a0b38c1747
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 68c9163dbc4717d7fdac63c3c0b6f2015709780b
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Oct 8 19:33:58 2018 +0530
tests: correction in tests/bugs/glusterd/optimized-basic-testcases-in-cluster.t
Patch https://review.gluster.org/#/c/glusterfs/+/19135/ has
optimised glusterd test cases by clubbing the similar test
cases into a single test case.
https://review.gluster.org/#/c/glusterfs/+/19135/15/tests/bugs/glusterd/bug-1293414-import-brickinfo-uuid.t
test case has been deleted and added as a part of
tests/bugs/glusterd/optimized-basic-testcases-in-cluster.t
In the original test case, we create a volume with two bricks,
each on a separate node(N1 & N2). From another node in cluster(N3),
we try to detach a node which is hosting bricks. It fails.
In the new test, we created volume with single brick on N1.
and from another node in cluster, we tried to detach N1. we
expect peer detach to fail, but peer detach was success as
the node is hosting all the bricks of volume.
Now, changing the new test case to cover the original test case scenario.
Please refer https://bugzilla.redhat.com/show_bug.cgi?id=1642597#c1 to
understand why the new test case is not failing in centos-regression.
fixes: bz#1642597
Change-Id: Ifda12b5677143095f263fbb97a6808573f513234
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit a116dbc2b4ce13bfee31046f8e73e141c8a43f2c
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Tue Oct 9 11:34:08 2018 +0530
features/namespace: NULL pointer deferencing clang fix
Removed VALIDATE_OR_GOTO check on "this"
Updates: bz#1622665
Change-Id: Ie0d74525901ebf9daa1a5e788a035db6dc5d8c06
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 142aac00daa12763a8a18fa0f874269506170bc0
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Oct 24 18:09:09 2018 +0530
geo-rep : fix high sev coverity isuue
This patch fixes CID: 1382374: USE_AFTER_FREE.
Change-Id: If408f52ee291312fb83095126ebd6bb79ae95e26
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit aaf59f78a533478d0eb83471a6986f3e185a46bc
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Oct 16 14:06:10 2018 +0530
shard : fix coverity issue in shard.c
This patch fixes CID:
1394664 : CHECKED_RETURN
1356534 : Macro compares unsigned to 0 (NO_EFFECT)
1356532 : Macro compares unsigned to 0 (NO_EFFECT)
updates: bz#789278
Change-Id: I04d64fd8c007627611710dc56109b76eeb59333a
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 3c8b994d892caa4ef1d5e1ce3f8eb9000810a2b4
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Wed Oct 24 18:11:13 2018 +0530
cluster/ec : Prevent volume create without redundant brick
Problem:
EC volumes can be created without any redundant brick.
Solution:
Updated the conditional check to avoid volume create without
redundant brick.
fixes: bz#1642448
Change-Id: I0cb334b1b9378d67fcb8abf793dbe312c3179c0b
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit dec839bb6b36582f30d577b9ee64edc80cdd7a34
Author: Han Han <hhan@redhat.com>
Date: Mon Oct 15 09:53:06 2018 +0800
mount.glusterfs: A more explicit check to avoid identical mounts
Change check condition from
"[[:space:]+]${mount_point}[[:space:]+]fuse" to
"[[:space:]+]${mount_point}[[:space:]+]fuse.glusterfs". Fix false
postive check result for mount points of other FUSEes, such as "fuse.sshfs".
Change-Id: I13898b50a651a8f5ecc3a94d01b3b5de37ec4cbc
fixes: bz#1640026
Signed-off-by: Han Han <hhan@redhat.com>
commit fbe59cefc61e45d71a043f8587d9c683891b6ce5
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Oct 22 21:16:53 2018 +0530
leases:Mark the fop conflicting if lease_id not set
Glusterfs leases expects lease_id to be set and sent
for each fop to determine conflict resolution with the
existing lease.
Incase if not set (most likely if there is an older
client in a mixed cluster), it makes sense to consider
it as conflicitng fop and recall the lease.
Also fixed the return status check for __remove_lease(),
wherein non-negative value is considered as success case.
Change-Id: I5bcfba4f7c71a5af7cdedeb03436d0b818e85783
updates: #350
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 4ae5980cccf461a64c11f230ef044cef1c42cfe2
Author: Arjun <arjsharm@redhat.com>
Date: Mon Oct 22 13:08:53 2018 +0530
src/glusterd-snapshot-utils.c: dereferencing the snap_vol before freeing it
The patch fixes CID: 1325520
Change-Id: Ic7d3fac6adabe96d1d44f13b57d6dc67da0476d1
updates: bz#789278
Signed-off-by: Arjun <arjsharm@redhat.com>
commit 57a438567dafa930bb91d2bd3d1725659dfa0247
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Oct 18 14:06:04 2018 +0530
glusterfs: During reconfigure set log-level per xlator level
Problem: In brick_mux environment, while a user has enabled brick-log-level
for anyone volume, it automatically enables for other volumes
also those are attached with same brick.
Solution: A log-level option is automatically enabled for other volumes
because log-level saved in glusterfsd_ctx and ctx is common for
volumes those are attached with same brick. To resolve it
set log level for all children xlator's at the time of the graph
reconfigure at io-stat xlator.
Change-Id: Id9a6efa05d286e0bea2d47f49292d084e7bb2fcf
fixes: bz#1640495
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 12a1bab80bb8ac75ecbfb82d5faa5482b7e7a07b
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sun Oct 7 17:44:19 2018 +0530
glusterd: set integer instead of string
dict_get_str_boolean expects a integer, so we need
to set all the boolean variables as integers to
avoid log messages like below:
[2018-09-10 03:55:19.236387] I [dict.c:2838:dict_get_str_boolean] (-->/usr/local/lib/libgfrpc.so.0(rpc_clnt_reconnect+0xc2) [0x7ff7a83d0452] -->/usr/local/lib/glusterfs/4.2dev/rpc-transport/socket.so(+0x65b0) [0x7ff7a06cf5b0] -->/usr/local/lib/libglusterfs.so.0(dict_get_str_boolean+0xcf) [0x7ff7a85fc58f] ) 0-dict: key transport.socket.ignore-enoent, integer type asked, has string type [Invalid argument]
This patch addresses all such instances in glusterd.
Change-Id: I7e1979fcf381363943f4d09b94c3901c403727da
updates: bz#1193929
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit fcfd035ac29e0ea5e65cc7582532160ff626c3ab
Author: Kotresh HR <khiremat@redhat.com>
Date: Sun Oct 14 19:54:48 2018 +0530
cli: Fix heap-buffer-overflow issue reported by ASAN
GF_MALLOC was being used to allocate memory which is
not initialized. strcat is used on it which could
result in buffer overflow if it contains garbage before
'\0'. So changed it to GF_CALLOC.
Traceback:
==23427==ERROR: AddressSanitizer: heap-buffer-overflow ...
WRITE of size 5 at 0x6080000083fe thread T3
#0 0x7fb60966991c in __interceptor_strcat ...
#1 0x48adc0 in config_parse ...
#2 0x48cde8 in cli_cmd_gsync_set_parse ...
...
Updates: bz#1633930
Change-Id: I3710f011d8139984b1898265d84d150c9bdc962b
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit b2e0558156f87ab0467df97c42f32adcb2a80529
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Oct 18 17:15:58 2018 +0530
cluster/afr : Check for UP bricks before starting heal
Problem:
Currently for replica volume, even if only one brick is UP
SHD will keep crawling index entries even if it can not
heal anything.
In thin-arbiter volume which is also a replica 2 volume,
this causes inode lock contention which in turn sends
upcall to all the clients to release notify locks, even
if it can not do anything for healing.
This will slow down the client performance and kills the
purpose of keeping in memory information about bad brick.
Solution: Before starting heal or even crawling, check if
sufficient number of children are UP and available to check
and heal entries.
Change-Id: I011c9da3b37cae275f791affd56b8f1c1ac9255d
updates: bz#1640581
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit b263a5932e3c06a54419d7a18e0b3b1e446bc8fa
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Oct 23 11:50:37 2018 +0530
glusterd: improve logging for stage_deleted flag
Change-Id: I5f0667a47ddd24cb00949c875c19f3d1dbd8d603
fixes: bz#1605077
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 08cbb7db353a41b2bd9b3b1c1f64770d3b8c4172
Author: Harpreet Lalwani <hlalwani@redhat.com>
Date: Mon Oct 8 15:58:17 2018 +0530
rpc/rpc-lib: Uninitialized argument value of a function
trav->saved_at.tv_sec is not initialized.
Calling "list_empty" function before initializing "trav".
Updates: bz#1622665
Change-Id: Ib5c2703a07a9c56ccd115001aca500f7a23c4a2e
Signed-off-by: Harpreet Lalwani <hlalwani@redhat.com>
commit 2b4a093651934e2649b81a86c8b15ef3d367f673
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Sat Sep 29 11:02:58 2018 +0800
md-cache: request cached xattrs at stat/fstat
Ganesha always operate file by filehandle, and translates to
glusterfs's stat/fstat many time.
Change-Id: Idd0dc33c31131331ac948754c8b7f898777c31d3
Updates: bz#1634220
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 7b718c6cceebae38ef7d2bb8f13cec5646bab288
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Oct 21 17:32:52 2018 +0530
tests: check for shd up status in bug-1637802-arbiter-stale-data-heal-lock.t
Problem:
https://review.gluster.org/#/c/glusterfs/+/21427/ seems to be failing
this .t spuriously. On checking one of the failure logs, I see:
22:05:44 Launching heal operation to perform index self heal on volume patchy has been unsuccessful:
22:05:44 Self-heal daemon is not running. Check self-heal daemon log file.
22:05:44 not ok 20 , LINENUM:38
In glusterd log:
[2018-10-18 22:05:44.298832] E [MSGID: 106301] [glusterd-syncop.c:1352:gd_stage_op_phase] 0-management: Staging of operation 'Volume Heal' failed on localhost : Self-heal daemon is not running. Check self-heal daemon log file
But the tests which preceed this check whether via a statedump if the shd is
conected to the bricks, and they have succeeded and even started
healing. From glustershd.log:
[2018-10-18 22:05:40.975268] I [MSGID: 108026] [afr-self-heal-common.c:1732:afr_log_selfheal] 0-patchy-replicate-0: Completed data selfheal on 3b83d2dd-4cf2-4ea3-a33e-4275be40f440. sources=[0] 1 sinks=2
So the only reason I can see launching heal via cli failing is a race where
shd has been spawned but glusterd has not yet updated in-memory that it is up,
and hence failing the CLI.
Fix:
Check for shd up status before launching heal via CLI
Change-Id: Ic88abf14ad3d51c89cb438db601fae4df179e8f4
fixes: bz#1641344
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 37aa0ff5cbe4b813cc9d77d350cd87f3e3ad58d6
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Sat Sep 29 11:58:42 2018 +0800
posix: fill glusterfs.posix.* acl xattrs at dict
Change-Id: I0730a037f96c4386c72ecf2f61c71ec17ffbc1b0
Updates: bz#1634220
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 74ef7e073ce5e19fb19e4b045a6fc747c8e8ba75
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Oct 18 19:35:40 2018 +0800
md-cache: fix dict leak of cached xattr
Change-Id: I52f8e13e68528ba9679537ffdddf58ec08f9fd0c
Updates: bz#1634220
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 507a9a5d166c85f146ff92191bbcf7758646f278
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Thu Oct 18 17:30:09 2018 +0530
xlators: some high severity coverity fixes
Fixes: 124759 1288787
Change-Id: Ib8999242fc3ea5f4ea80246659899d2d4f06c506
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit ad78d488b9d4e9938750a379732dadf41888b272
Author: Varsha Rao <varao@redhat.com>
Date: Thu Oct 18 12:03:37 2018 +0530
performance/write-behind: Fix NULL dereference issue
This patches fixes the following coverity issues:
CID: 1396101, 1396102 - Dereference null return value.
Change-Id: I7ec783a61c06a1378863e974ff6e0baae418aec2
updates: bz#789278
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 464ac759c150fe797aeaac7ac346a063cf260906
Author: Arjun Sharma <arjsharm@redhat.com>
Date: Mon Oct 15 17:37:36 2018 +0530
protocol/server: added check for positve value in server-handshake.c
This patch fixes CID 1124651
Change-Id: I6f33954f08cfdd7cb4236f9a81ec7980f81d19e7
updates: bz#789278
Signed-off-by: Arjun <arjsharm@redhat.com>
commit 40b3fcc9858ff4efe96eb09c2c80d108b54fb0fc
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Thu Oct 18 14:15:40 2018 +0530
rdma: coverity fixes
Fixes CID: 1382442 1382415 1382379 1382355
Change-Id: Ia712e37cb5a6db452d3178386394f87f83b85d38
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit 3b38d74ec9d0af27af8b7fa029435ff770354ff6
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Thu Oct 18 18:25:46 2018 +0530
mount/fuse: return ESTALE instead of ENOENT on all inode based operations
This patch is continuation of commit
fb4b914ce84bc83a5f418719c5ba7c25689a9251. This patch extends that
logic to all inode based operations and not just open(dir).
<snip>
mount/fuse: never fail open(dir) with ENOENT
open(dir) being an operation on inode should never fail with
ENOENT. If gfid is not present, the appropriate error is ESTALE. This
will enable kernel to retry open after a revalidate lookup.
</snip>
Change-Id: I6313f520827e9af725485631cb6a9d9718243bc4
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1627620
commit 501f5133dd1856aac5c28788becfcb09eafc233d
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Tue Sep 25 16:58:24 2018 +0530
cluster/ec: NULL pointer deferencing clang fix
Removing VALIDATE_OR_GOTO check on "this"
Updates: bz#1622665
Change-Id: Ic7cffbb697da814f835d0ad46e25256da6afb406
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 7307649952cd7b8dbf549415479f8a5e5c0c3bc2
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Oct 17 14:26:14 2018 +0530
storage/posix: Do not fail entry creation fops if gfid handle already exists
PROBLEM:
tests/bugs/shard/bug-1251824.t fails occasionally with EIO due to gfid
mismatch across replicas on the same shard when dd is executed.
CAUSE:
Turns out this is due to a race between posix_mknod() and posix_lookup().
posix mknod does 3 operations, among other things:
1. creation of the entry itself under its parent directory
2. setting the gfid xattr on the file, and
3. creating the gfid link under .glusterfs.
Consider a case where the thread doing posix_mknod() (initiated by shard)
has executed steps 1 and 2 and is on its way to executing 3. And a
parallel LOOKUP from another thread on noting that loc->inode->gfid is NULL,
tries to perform gfid_heal where it attempts to create the gfid link
under .glusterfs and succeeds. As a result, posix_gfid_set() through
MKNOD (step 3) fails with EEXIST.
In the older code, MKNOD under such conditions was NOT being treated
as a failure. But commit e37ee6d changes this behavior by failing MKNOD,
causing the entry creation to be undone in posix_mknod() (it's another
matter that the stale gfid handle gets left behind if lookup has gone
ahead and gfid-healed it).
All of this happens on only one replica while on the other MKNOD succeeds.
Now if a parallel write causes shard translator to send another MKNOD
of the same shard (shortly after AFR releases entrylk from the first
MKNOD), the file is created on the other replica too, although with a
new gfid (since "gfid-req" that is passed now is a new UUID. This leads
to a gfid-mismatch across the replicas.
FIX:
The solution is to not fail MKNOD (or any other entry fop for that matter
that does posix_gfid_set()) if the .glusterfs link creation fails with EEXIST.
Change-Id: I84a5e54d214b6c47ed85671a880bb1c767a29f4d
fixes: bz#1638453
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit ba800910eb291c6466d209cf3e8106dc83c2da73
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Oct 17 13:08:59 2018 +0530
ctr: fix coverity issue in changetimerecorder.c
This patch fixes CID:
1396179: Read from pointer after free
1396178: Use after free
Change-Id: I47a2e4aa257e0c4dbdf2e1fd2e0748902764463f
fixes: bz#789278
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 3021083e9ca300729d101bd1426174842b9836de
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Oct 17 15:40:04 2018 +0530
shard : fix newly introduced coverity
This patch fixes CID: 1396177: NULL dereference.
updates: bz#789278
Change-Id: Ic5d302a5e32d375acf8adc412763ab94e6dabc3d
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit fe2d428af2693a0badd41a7397361b7e4adef673
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Oct 17 18:48:19 2018 +0530
debug/io-stats: io stats filenames contain garbage
As dict_unserialize does not null terminate the value,
using snprintf adds garbage characters to the buffer
used to create the filename.
The code also used this->name in the filename which
will be the same for all bricks for a volume. The
files were thus overwritten if a node contained
multiple bricks for a volume. The code now uses
the conf->unique instead if available.
Change-Id: I2c72534b32634b87961d3b3f7d53c5f2ca2c068c
fixes: bz#1640165
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 79a6018d411af0dd6ada854458d2721ead462393
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Fri Oct 12 10:31:04 2018 +0530
api: fill out attribute information if not valid
translators like readdir-ahead selectively retain entry information of
iatt (gfid and type) when rest of the iatt is invalidated (for write
invalidating ia_size, (m)(c)times etc). Fuse-bridge uses this
information and sends only entry information in readdirplus
response. However such option doesn't exist in gfapi. This patch
modifies gfapi to populate the stat by forcing an extra lookup.
Thanks to Shyamsundar Ranganathan <srangana@redhat.com> and Prashanth
Pai <ppai@redhat.com> for tests.
Change-Id: Ieb5f8fc76359c327627b7d8420aaf20810e53000
Fixes: bz#1630804
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 45da7cbe8fa3d0a427100a2b971ef0deada900ac
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Sat Sep 29 12:10:46 2018 +0800
posix: return more xattrs at getxattr/fgetxattr when client request
Change-Id: I37ac6186b3631979d2503d1b185a61b8094dbd0d
Updates: bz#1634220
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit d412691bcea83e8a3a9d35c0a1902f10d1cdcf2a
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Oct 16 16:45:34 2018 +0530
nfs : fix coverity issue in nfs3.c
This patch fixes CID 1274073.
updates: bz#789278
Change-Id: I34146bfdfe19bae4592062e710a89ab07b2c5c07
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 0754ac6627687e6bd2e319da11bfb20db6c68c7d
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Oct 16 14:48:00 2018 +0530
trash : fix high sev coverity issue in trash.c
This patch fixes CID 1288790: RESOURCE_LEAK.
updates: bz#789278
Change-Id: I34bb410f1d3027e2d4c21044e87e319360344e04
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 24d7bb81f6ab99586c073f692daf03e9681e72e4
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Oct 8 19:22:53 2018 +0530
glusterfsd: fix the asan leak message
Fixes below trace of ASan:
Direct leak of 130 byte(s) in 1 object(s) allocated from:
#0 0x7fa794bb5850 in malloc (/lib64/libasan.so.4+0xde850)
#1 0x7fa7944e5de9 in __gf_malloc ../../../libglusterfs/src/mem-pool.c:136
#2 0x40b85c in gf_strndup ../../../libglusterfs/src/mem-pool.h:166
#3 0x40b85c in gf_strdup ../../../libglusterfs/src/mem-pool.h:183
#4 0x40b85c in parse_opts ../../../glusterfsd/src/glusterfsd.c:1049
#5 0x7fa792a98720 in argp_parse (/lib64/libc.so.6+0x101720)
#6 0x40d89f in parse_cmdline ../../../glusterfsd/src/glusterfsd.c:2041
#7 0x406d07 in main ../../../glusterfsd/src/glusterfsd.c:2625
updates: bz#1633930
Change-Id: I394b3fc24b7a994c1b03635cb5e973e7290491d3
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 1e13703c7e4dc2208722e0f150a2306ee452194a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Oct 14 02:15:40 2018 +0300
servers-helpers.c: reduce clang warnings on dead initialization.
Assign a value to a parameter on its definition.
Removes tens of clang warnings.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I828bacb4033111af6162772a554cc5c6b2820169
commit 0b3dd07c39aacb07c2099b4acd3887c50d0579d5
Author: ShyamsundarR <srangana@redhat.com>
Date: Mon Oct 15 20:45:18 2018 -0400
coverity: ignore tainted access reported in gf_free
Coverity reports tainted pointer access in _gf_free if the pointer passed in
was used by any IO related function by the caller. The taint within gf_free
is a false positive, as the tainted region is from the passed in pointer
till its allocated lenght, and not for contents before the pointer (i.e
the GF_MEM_HEADER_SIZE bytes before the passed in pointer), as that is
exclusively handled by the gf_alloc family of functions.
CID: 1228602, 1292646, 1292647, 1292648, 1292649, 1383192, 1383195, 1389691
Should additionally fix,
CID: 1292650, 1292651, 1357874, 1382373, 1382404, 1382407
Change-Id: I48c5a4028e7b0224c432bbc30f8c29408c2a466b
Updates: bz#789278
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 0aeebc140e829aa31dcbdad9f6ea5b7ffff42e56
Author: ShyamsundarR <srangana@redhat.com>
Date: Mon Oct 15 20:50:26 2018 -0400
glusterfsd: Fix coverity issues around unused values
This patch fixes,
CID: 1274064, 1274232
The fix is to not add into the return dict the throughput
and time values on error computing the same. The pattern
applied is the same as when an error occurs during adding
either the throughput or the time value to the dict.
Change-Id: I33e21e75efbc691f18b818934ef3bf70dd075097
Updates: bz#789278
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 7e59e3c321b850248e1667e24e972d3e0eedac8a
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Tue Oct 9 15:57:31 2018 +0800
libgfapi: Send path with "." for the root when loc.parent is set
fixes: bz#1582516
Change-Id: Ia9649d7c3c0930dfec656d364cf6e9a98c774dd2
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 14bb546fbbd2d1f17c66159086658d1de32a719b
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Oct 10 21:37:07 2018 +0530
gfapi: Bug fixes in leases processing code-path
This patch fixes below issues in gfapi lease code-path
* 'glfs_setfsleasid' should allow NULL input to be
able to reset leaseid
* Applications should be allowed to (un)register for
upcall notifications of type GLFS_EVENT_LEASE_RECALL
* APIs added to read contents of GLFS_EVENT_LEASE_RECALL
argument which is of type "struct glfs_upcall_lease"
Change-Id: I3320ddf235cc82fad561e13b9457ebd64db6c76b
updates: #350
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 029cdac41bab171486a847159b24ef2ff20961bf
Author: Milind Changire <mchangir@redhat.com>
Date: Sat Oct 13 10:15:42 2018 +0530
libglusterfs: fix sys_socket coverity issue
CID 1396081: Control flow issues (UNREACHABLE)
Change-Id: Ifad303853224cb9abc91c1083bb1529f4c13b1d3
updates: bz#789278
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 5ebfa62f31b680f38ba89973bac43b285b2b20c5
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sat Oct 13 00:56:42 2018 +0300
Multiple xlators: perform gettimeofday() not under lock
While it may slightly reduce accuracy, I think it's better to
acquire the time outside a lock and then memcpy the value while
under lock.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ic8fb94a56c4fa2d3b13e59767e13646fb39342ba
commit 5956c0777db7ea8347f19cb64853eb214d9c5d7a
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Oct 10 01:25:41 2018 +0530
mount : fix high sev coverity issues in mount3.c
This patch fixes CID 1395067, 1388767 and 1395068.
updates: bz#789278
Change-Id: Ie92252281bf559dd29fab462e121445ff4d3b865
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 4d9b820aa13ac5cc915c40da6791b27f36fa8c08
Author: Raghavendra Gowdappa <rgowdapp@redhat.com>
Date: Thu Oct 11 16:22:28 2018 +0530
cluster/dht: fixes to unlinking invalid linkto file
If unlinking of an invalid linkto file failed in lookup-everywhere
codepath, lookup was failed with EIO. The rational as per the comment
was,
<snip>
/* When dht_lookup_everywhere is performed, one cached
*and one hashed file was found and hashed file does
*not point to the above mentioned cached node. So it
*was considered as stale and an unlink was performed.
*But unlink fails. So may be rebalance is in progress.
*now ideally we have two data-files. One obtained during
*lookup_everywhere and one where unlink-failed. So
*at this point in time we cannot decide which one to
*choose because there are chances of first cached
*file is truncated after rebalance and if it is chosen
*as cached node, application will fail. So return EIO.
*/
</snip>
However, this reasoning is only valid when
* op_errno is EBUSY, indicating rebalance is in progress
* op_errno is ENOTCONN as wecannot determine what was the status of
file on brick.
Hence this patch doesn't fail lookup unless unlink fails with an
either EBUSY or ENOTCONN
Change-Id: Ife55f3d97fe557f3db05beae0c2d786df31e8e55
Fixes: bz#1635145
Signed-off-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
commit 99578dffb974161c3cf6713246fdd6e2e037394d
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Oct 15 08:26:32 2018 -0400
core: libuuid-devel breakage
The #include "uuid.h" left over from using .../contrib/uuid is debatably
incorrect now that we use the "system header" file /usr/include/uuid/uuid.h
from libuuid-devel.
Unfortunately this is complicated by things like FreeBSD having its own
/usr/include/uuid.h, and the e2fsprogs-libuuid uuid.h in installed - as
most third-party packages in FreeBSD are - in /usr/local as
/usr/local/include/uuid/uuid.h
With a system header file it should at least be #include <uuid.h>, and
even better as #include <uuid/uuid.h>, much like the way <sys/types.h>
and <net/if.h> are included. Using #include <uuid/uuid.h> guarantees
not getting the /usr/include/uuid.h on FreeBSD, but clang/cc knows to
find "system" header files like this in /usr/local/include; with or
without the -I/... from uuid.pc. Also using #include "uuid.h" leaves
the compiler free to find a uuid.h from any -I option it might be passed.
(Fortunately we don't have any at this time.)
As we now require libuuid-devel or e2fsprogs-libuuid and configure will
exit with an error if the uuid.pc file doesn't exist, the HAVE_LIBUUID
(including the #elif FreeBSD) tests in compat-uuid.h are redundant. We
are guaranteed to have it, so testing for it is a bit silly IMO. It may
also break building third party configure scripts if they omit defining
it. (Just how hard do we want to make things for third party developers?)
Change-Id: I7317f63c806281a5d27de7d3b2208d86965545e1
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit cefad5bb5588f0b228d626ddfaa792b6aa9fe0fa
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Oct 5 11:32:21 2018 +0530
features/shard: Hold a ref on base inode when adding a shard to lru list
In __shard_update_shards_inode_list(), previously shard translator
was not holding a ref on the base inode whenever a shard was added to
the lru list. But if the base shard is forgotten and destroyed either
by fuse due to memory pressure or due to the file being deleted at some
point by a different client with this client still containing stale
shards in its lru list, the client would crash at the time of locking
lru_base_inode->lock owing to illegal memory access.
So now the base shard is ref'd into the inode ctx of every shard that
is added to lru list until it gets lru'd out.
The patch also handles the case where none of the shards associated
with a file that is about to be deleted are part of the LRU list and
where an unlink at the beginning of the operation destroys the base
inode (because there are no refkeepers) and hence all of the shards
that are about to be deleted will be resolved without the existence
of a base shard in-memory. This, if not handled properly, could lead
to a crash.
Change-Id: Ic15ca41444dd04684a9458bd4a526b1d3e160499
updates: bz#1605056
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit ce3b417b8d13734951ac1681ee2b3c6a43e686dc
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Sep 28 13:03:38 2018 +0530
libglusterfs/dict: Add sizeof()-1 variants of dict functions
One needs to be very careful about giving same key for the key and
SLEN(key) arguments in dict_xxxn() functions. Writing macros that
would take care of passing the SLEN(key) would help reduce this
burden on the developer and reviewer.
updates: bz#1193929
Change-Id: I312c479b919826570b47ae2c219c53e2f9b2ddef
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit f88a401bc1334e9ec94385b53b668b988af8f6cc
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Oct 12 14:25:00 2018 +0530
glusterd/geo-rep: Fix memory corruption
Problem and Analysis:
The length of canonical format of uuid is 36 but
'GF_UUID_BUF_SIZE 50' was being used everywhere.
glusterd/geo-rep code was earlier using strncpy,
but recently changes to memcpy with the drive
to avoid strncpys. This leads to memory corruption
and glusterd is crashing without a core with geo-rep
creation with ASAN build.
Fix:
'GF_UUID_BUF_SIZE 37' (+ 1 for NULL byte)
And change geo-rep to use UUID_CANONICAL_FORM_LEN
instead
Updates: bz#1633930
Change-Id: Ibd347d542b92e64a96ce06780cda643557233bc7
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 6a0be4253d664924c75a1d1b3ca6352009c59454
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Oct 11 23:39:13 2018 +0530
cli: Fix memory leaks reported by ASAN
This patch addresses memory leaks other than
'gf_cli_rsp' response structure.
Updates: bz#1633930
Change-Id: Idc5940dca623e33bc01004a9324bc435fc60b006
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 5a2fd38a98bcc5260e7e8bfb2096d8fe3632a33f
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Oct 11 12:20:10 2018 +0530
libglusterfs : fix newly introduced coverity defect
CID: 1396060
updates: bz#789278
Change-Id: Ia25aa9a4ca7505e747aa92bb3ae81415da7d19d1
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit df373ebb13c0be8210a87f580edcd7c7121120d3
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Oct 10 10:31:18 2018 +0530
core: glusterfsd keeping fd open in index xlator
Problem: At the time of processing GF_EVENT_PARENT_DOWN
at brick xlator, it forwards the event to next xlator
only while xlator ensures no stub is in progress.
At io-thread xlator it decreases stub_cnt before the process
a stub and notify EVENT to next xlator
Solution: Introduce a new counter to save stub_cnt and decrease
the counter after process the stub completely at io-thread
xlator.
To avoid brick crash at the time of call xlator_mem_cleanup
move only brick xlator if detach brick name has found in
the graph
Note: Thanks to pranith for sharing a simple reproducer to
reproduce the same
fixes bz#1637934
Change-Id: I1a694a001f7a5417e8771e3adf92c518969b6baa
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 079a3777366c3f86b5415d0a2a1f5e9e756fcd15
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Thu Oct 11 04:00:08 2018 +0530
libglusterfs: fix log message in options.c
This patch fixes https://github.com/gluster/glusterfs/issues/519
Credits: "Fabian Wannenmacher <@wanneut>"
Updates: bz#1193929
Change-Id: If8d60c3379093a868ad6ba8c2ad86a4b99d35f2c
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 8f9f51347193cfb251eadd207c4883c092e04ad6
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Oct 11 12:12:38 2018 +0530
features/locks: Fix Coverity issues
CID:
1395812 Explicit null dereferenced
1356542 Dereference null return value
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=86261835&defectInstanceId=26407100&mergedDefectId=1395812
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=86261835&defectInstanceId=26407215&mergedDefectId=1356542
Change-Id: I2c20972a8080fa7a70b88eab0688b9cf734bbf24
updates: bz#789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 7a6e79820fa2c7807d336f42d0486153d6f07195
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Oct 11 17:36:43 2018 +0530
snapshot : fix high sev coverity on snapview-server.c
This patch fixes CID 1325525 (double free).
updates: bz#789278
Change-Id: I26a5f428dde83dd7708815f06830decf4068b94c
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 7ce1480f38db18c4754690b14e6c5f255b5957b2
Author: Iraj Jamali <ijamali@redhat.com>
Date: Tue Oct 9 12:07:11 2018 +0530
performance/nl-cache: clang fix
Argument with 'nonnull' attribute passed null.
Adding a check to avoid the issue.
Updates: bz#1622665
Change-Id: I1d3a166e154a51da59bebb93a49f5174e593c98e
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit 9f55d94d9e3641ed4524a8a6f9e6aea7553c654a
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Oct 11 12:51:03 2018 +0530
cli: Fix memory leaks reported by ASAN
'gf_cli_rsp' structure has 'op_errstr' and 'dict.dict_val'
which could get allocated by xdr and should be freed. This
patch takes care of all instances of the same.
Updates: bz#1633930
Change-Id: I2a5d129ffe85cfca743c89edb45b658f3ce688cb
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit f05b6841e063da5d55d67756f5057107a95f0940
Author: Iraj Jamali <ijamali@redhat.com>
Date: Wed Oct 10 12:29:21 2018 +0530
mgmt/glusterd: clang fix
Argument with 'nonnull' attribute passed null.
Added checks to avoid the issues.
Updates: bz#1622665
Change-Id: I0dba1185cee5baba3c124d687560a06fe182381e
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit f5094ee3e39ed85dfa0fcddaaff755632d29b531
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Mon Oct 1 12:39:48 2018 +0530
mgmt/glusterd: NULL pointer dereferencing clang fix
Problem: dereferencing of this->name; volinfo and xl
can be null.
Solution: Replaced this->name with apropriate names in few places,
added a null check to avoid dereferencing of volinfo,
and introduced a goto out statement, such that null pointer value is
not passed to the function volgen_xlator_link when xl becomes NULL.
Updates: bz#1622665
Change-Id: I77616bd23f58328cb6dbe681914a028991d49abb
Signed-off-by: Shwetha Acharya <sacharya@redhat.com>
commit b2b7eaceacc9ed38bdcc2768201cc6dfccec6037
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Oct 11 15:16:41 2018 +0530
socket: use accept4/paccept for nonblocking socket
This reduces the no. of syscalls on Linux systems from 2, accept(2) and
fcntl(2) for setting O_NONBLOCK, to a single accept4(2). On NetBSD, we
have paccept(2) that does the same, if we leave signal masking aside.
Added sys_accept which accepts an extra flags argument than accept(2).
This would opportunistically use accept4/paccept as available. It would
fallback to accept(2) and fcntl(2) otherwise.
While at this, the patch sets FD_CLOEXEC flag on the accepted socket fd.
BUG: 1236272
Change-Id: I41e43fd3e36d6dabb07e578a1cea7f45b7b4e37f
fixes: bz#1236272
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 7b0ae25afb6e99447aa701e48e76b3f88a4b1b08
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Thu Oct 11 11:27:44 2018 +0530
performance/write-behind: NULL pointer passed to a nonnull parameter
Problem: wb_directory_inode->lock can be null.
Solution: added a condition, if(!wb_directory_inode->lock.spinlock)
to address the issue (checked one of the attributes of union lock
to ensure that union is not null).
Updates: bz#1622665
Change-Id: I0749ee16aa2c23f51d4b4c7b0979d494bcd4d90e
Signed-off-by: Shwetha Acharya <sacharya@redhat.com>
commit b21e3aea64a465ec353d5dbfe730b7d90f1bc680
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Oct 9 15:17:57 2018 +0530
socket: set FD_CLOEXEC on all sockets
For more information, see http://udrepper.livejournal.com/20407.html
BUG: 1236272
Change-Id: I25a645c10bdbe733a81d53cb714eb036251f8129
fixes: bz#1236272
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 23f018c0b6282af2af08d9ce61c71e6a31d6e4d9
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 24 10:31:23 2018 +0530
README: add a section for giving hints on testing
Change-Id: I1529494504c38172f56759c0f06231864e32df24
updates: bz#1193929
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 6b0bfecd8819629435e726b4499d276a8d301cd1
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Oct 10 13:46:22 2018 +0530
cluster/dht : Fix coverity issue
To check if the gfid is null or not
we should use function gf_uuid_is_null
CID: 1382364
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=86243257&defectInstanceId=26374360&mergedDefectId=1382364
Change-Id: I81944b823c9ee6e6dcc9695f64f7e5966e0d7030
updates: bz#789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit e46f57a7bb99986d561ff92de4b62ca0e8b61573
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Wed Sep 19 03:35:38 2018 -0400
gfapi: fix crash of using uninitialized fs->ctx
0 0x00007fb3db3a2ee4 in pub_glfs_fini (fs=0x7f8977d63f00) at glfs.c:1236
1 0x00007fb3db3a2065 in pub_glfs_new (volname=0x7f80de4d4d40 "openfs1")
at glfs.c:784
2 0x00007fb3db5cf089 in glusterfs_get_fs (params=...,
up_ops=up_ops@entry=0x7fb3ca643130)
at /usr/src/debug/nfs-ganesha/src/FSAL/FSAL_GLUSTER/export.c:889
3 0x00007fb3db5cf99a in glusterfs_create_export (
fsal_hdl=0x7fb3db7e2490 <GlusterFS+112>, parse_node=0x7fb3ca6387d0,
err_type=<optimized out>, up_ops=0x7fb3ca643130)
at /usr/src/debug/nfs-ganesha/src/FSAL/FSAL_GLUSTER/export.c:1011
4 0x00007fb3e11c485f in mdcache_fsal_create_export (
sub_fsal=0x7fb3db7e2490 <GlusterFS+112>,
parse_node=parse_node@entry=0x7fb3ca6387d0,
err_type=err_type@entry=0x7fb3c0bef140, super_up_ops=<optimized out>)
at /usr/src/debug/nfs-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c:281
(gdb) p errno
$1 = 12
Change-Id: I3dd5b84b52962ceb0b5d4f9b4f475bf4aa724292
updates: bz#1626313
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit f18b6e80263820d33c924db64ef6f388ca329686
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Oct 10 12:18:55 2018 +0530
afr: prevent winding inodelks twice for arbiter volumes
Problem:
In an arbiter volume, if there is a pending data heal of a file only on
arbiter brick, self-heal takes inodelks twice due to a code-bug but unlocks
it only once, leaving behind a stale lock on the brick. This causes
the next write to the file to hang.
Fix:
Fix the code-bug to take lock only once. This bug was introduced master
with commit eb472d82a083883335bc494b87ea175ac43471ff
Thanks to Pranith Kumar K <pkarampu@redhat.com> for finding the RCA.
fixes: bz#1637802
Change-Id: I15ad969e10a6a3c4bd255e2948b6be6dcddc61e1
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 3d9ee4210becefc9f7d2b99100ef7233fffe4d18
Author: Iraj Jamali <ijamali@redhat.com>
Date: Thu Oct 4 14:22:23 2018 +0530
libglusterfs: NULL pointer dereferencing clang fix
Avoided NULL pointer dereferencing by doing GF_VALIDATE_OR_GOTO for rvec
Updates: bz#1622665
Change-Id: I650e0203796dd705d79060f9506fc6c559b30f56
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit d5270f5cf82f2d246b2076b5a508079d871e29c2
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Oct 9 19:40:31 2018 +0530
locks : fix coverity issue
This patch fixes CID 1356544 and 1356539.
Both are of type NULL_RETURNS.
Change-Id: I2ef7c3ff9929c4d85b79fff00e835ebee3ff3ce0
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit b27b4339bd4c6cdddaafce49f26e149200f3a31b
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Tue Sep 25 03:40:44 2018 -0400
socket: clear return value if error is going to be handled in event thread
Change-Id: Ibce94f282b0aafaa1ca60ab927a469b70595e81f
updates: bz#1626313
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit d67f4f2743b52d5972aaf4e63c987d05377fbd40
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Sep 25 13:22:47 2018 +0200
all: fix warnings on non 64-bits architectures
When compiling in other architectures there appear many warnings. Some
of them are actual problems that prevent gluster to work correctly on
those architectures.
Change-Id: Icdc7107a2bc2da662903c51910beddb84bdf03c0
fixes: bz#1632717
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit c4c08f5e8b0fd7335c013863ac4ef94e2b9e3d4a
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Tue Sep 25 03:42:47 2018 -0400
logging: fix file handle leak when calls glfs_set_logging more times
Closes the log file and reopens it to prevent leakage of file handles.
Change-Id: Idfaa479961bb0088004d0d5558bdb0eb32cff632
updates: bz#1626313
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 6df911a188e666a970581595e06153950f646b4a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Oct 7 20:39:22 2018 +0300
libglusterfs/src/logging.c: reduce the use of strings
I did not see a good reason to copy the temp strings str1 and str2
into msg string, and just used str1 (sprintf'ed str2 into it first).
Hope it makes logging somewhat faster, but I also hope there's more
room for improvement for faster logging.
Renamed str1 to logline and str2 to msg for better readability.
Also, remove dead assignment in _gf_msg() (clang complained).
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I19457d705c0b043937d96a4db35d087bb8e9b35a
commit 994fd1aafec8419d0af17e2c54e75ca2696993c8
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Sep 5 15:30:25 2018 -0400
features/snapview-client: replace gf_log with gf_msg
Change-Id: I87f01d86f50eb2fca21febb0ea3e77fbd152eb93
updates: bz#1626610
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 6044ea945676ed8329cc86fda8c7705c25a4c467
Author: Susant Palai <spalai@redhat.com>
Date: Thu Oct 4 19:17:56 2018 +0530
cloudsync: coverity fix
CID: 1394649 1394657
Issue: Explicit null dereferenced
Change-Id: Ic1040ffa5548e1ecd49cfdc9a8716be445cbdf0f
Updates: bz#789278
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 94e07d59cf27be859c4bc7987cf218ab75bc637b
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Oct 8 13:21:38 2018 +0530
cli: memory leak issues reported by asan
With this fix, a run on 'rpc-coverage.t' passes properly.
This should help to get started with other fixes soon!
Change-Id: I257ae4e28b9974998a451d3b490cc18c02650ba2
updates: bz#1633930
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit bbc7352ebe2be495b5f5265dfe184d8d516dd767
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Oct 9 12:43:32 2018 +0530
cliutils : python2 to python3 compat
This patch fixes import issue in cliutils.
Provided solution is to use relative import.
Change-Id: I14c9a0b528ef52e7c91f6b17b569c68c2ced8912
updates: #411
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 09ff9c818a4ce5396d6650b4b247f720c76490fe
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Sep 28 11:10:46 2018 +0530
extras: Script to collect system-stats
For debugging performance issues we found that this script is very
useful. Script collects the stats of vmstat/iostat/top/sar to get
metrics about memory/disk/cpu/network respectively at the configured
interval. It is very important to collect all these metrics at the
same time so that they can be correlated easily, so made this into a
script
fixes bz#1633926
Change-Id: Iea52e55179b21c505953722c8898293fe92cb8de
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 5e8503658c3a5899c5e40d3ff18c5afd88017445
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Wed Sep 26 05:39:47 2018 -0400
syncop: check syncenv status before pthread_cond_timedwait() to avoid 600s timeout
If a syncenv_task starts after syncenv_destroy, the syncenv_task enters
a 600s timeout cond timedwait, and syncenv_destroy must waits it timeout.
Change-Id: I972a2b231e50cbebd3c71707800e58033e40c29d
updates: bz#1626313
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 7e789986b9911403ce0977bcc66f6918433d5c3d
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Oct 8 21:35:04 2018 +0530
rpc: coverity fixes
CID: [1] 1394646 Unchecked return value from library
CID: [2] 1394633 Unused value
CID: 1382443 Sleeping while holding a lock [This is intentional]
[1] https://scan6.coverity.com/reports.htm#v40014/p10714/fileInstanceId=86159112&defectInstanceId=26360786&mergedDefectId=1394646
[2] https://scan6.coverity.com/reports.htm#v40014/p10714/fileInstanceId=86159365&defectInstanceId=26360919&mergedDefectId=1394633
Change-Id: I03086f7a9672c9f50a2bc44cdbce0006c887357b
updates: bz#789278
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 27bcb5c4b847b8efa78b75d01f8a8f099a9ab532
Author: Kotresh HR <khiremat@redhat.com>
Date: Sat Oct 6 09:20:24 2018 +0530
events: python2 to python3 compat
1. Fix imports
2. Use universal_newlines flag in Popen
3. encode msg used in 'sendto'
Updates: #411
Change-Id: Ieacdc2ba86953ff3a2e9d9b9a97157e8e0e36836
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit ed7aa3c83e1bbb016493d051a6de39b164fd2fa9
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Oct 3 00:45:09 2018 -0400
georep: python2 to python3 compat - syscalls
1. ctypes/syscalls
A) arguments is expected to be encoded
B) Raw conversion of return value from bytearray into string
2. struct pack/unpack - Raw converstion of string to bytearray
3. basestring -> str
Updates: #411
Change-Id: I80f939adcdec0ed0022c87c0b76d057ad5559e5a
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit efc9f50348ae28f880245e7b489fb8a319f28e7c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Oct 5 13:28:03 2018 -0400
packaging: remove RHEL5-isms from glusterfs.spec(.in)
CentOS5 too
It's been a couple of years since we stopped doing anything with
RHEL/CentOS 5
Change-Id: I83e78fa84b93fa5baddaf3fab92736d692a9bbca
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit dc08d6a2a24b48287b126b9db88180109b86c394
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Oct 2 08:54:28 2018 +0530
core: glusterfsd keeping fd open in index xlator
Problem: Current resource cleanup sequence is not
perfect while brick mux is enabled
Solution: 1) Destroying xprt after cleanup all fd associated
with a client
2) Before call fini for brick xlators ensure no stub
should be running on a brick
Change-Id: I86195785e428f57d3ef0da3e4061021fafacd435
fixes: bz#1631357
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit d31deb98592a82739e41859a764eeaaa3f2039d6
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sun Oct 7 14:22:06 2018 +0530
cli: Resource leak coverity fix
This patch fixes CID 1175017.
Change-Id: I4968c35489aeb5bfa0461b2edf2a0d73b7f03c14
updates: bz#789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 68acbf8de3b8714e8dbe0ff766c23588792c1fee
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Oct 5 01:38:15 2018 +0530
changetimerecorder : fix coverity issue
This patch fixes CID : 1124725
Issue : Resource leak
updates: bz#789278
Change-Id: I2afe65875fa393fd2d2f90b6f7cf7f6782dabf89
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 4a418487cc5a3b64fd6003f53ffcb6dfd271a8d0
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Mon Oct 1 17:02:09 2018 +0530
features/bit-rot: NULL pointer deferencing clang fix
Problem: local could be NULL
Added condition checks to address this issue
Updates: bz#1622665
Change-Id: I7be7dacc5386a77441385240b43f22d85074b69d
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 76067edf589b04e13fcbbf77089279ca701d315a
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sun Oct 7 15:47:13 2018 +0530
tests: add get-state command to test
When geo-replication session is running, run
"gluster get-state" command to test.
https://review.gluster.org/#/c/glusterfs/+/20461/
patch fixes glusterd crash, when we run get-state
command with geo-rep session configured.
Adding the test now.
Fixes: bz#1598345
Change-Id: I56283fba2c782f83669923ddfa4af3400255fed6
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit aea01f35c7e943976b2272cbb51852f813720b71
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 17 17:17:54 2018 +0530
xlators/experimental: move template files to '.c.in' type
This is critical because we shouldn't be applying the automated
coding standard (clang-format) tool on these files.
This patchset is done by below steps:
* clang-format -i ${filename}
This creates syntax errors. Fix them using below two commands:
* sed -i -e 's/ @/@/g' ${filename}
* sed -i -e 's/,@/, @/g' ${filename}
With this, these files are having minimum changes requried to
compile, and is as close to the coding standard as possible.
* git rename ${filename} ${filename}.in
Updates: bz#1564149
Change-Id: Icf90f7f81d6fa4400be4826e094fdff8e64508d0
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit d74831ce26c57f42d6e49e5eaafc99007932c4c3
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Oct 4 19:20:30 2018 +0530
cli : coverity fix in cli-rl.c
This patch fixes CID 1395248.
Issue : Resource leak
updates: bz#789278
Change-Id: I2fd4e36ac2c2a034e56883436abfc5199b095026
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 293a98b0c61028e3068adcff7bd2dfae48fa3a0d
Author: Susant Palai <spalai@redhat.com>
Date: Wed Oct 3 20:40:12 2018 +0530
dht: coverity fixes
CID: 1356541 Issue: Dereference null return value
CID: 1382411 Issue: Dereference after null check
CID: 1391409 Issue: Unchecked return value
Change-Id: Id3d4feb4e88df424003cc8e8a1540e77bbe030e3
Updates: bz#789278
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 92cf105d9fe3e993c81c46ec6387a35e13483d72
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Oct 5 01:14:34 2018 +0530
libglusterfs : fix coverity issue in stack.c
This patch fixes CID : 1395323.
Issue : Uninitialized scalar variable (UNINIT)
updates: bz#789278
Change-Id: Id9567ca2ff9b5a36b9014afa70cc5795fe67161d
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit aa3d015b63de1fc08fde40ee47771835990136b6
Author: Harpreet Lalwani <hlalwani@redhat.com>
Date: Mon Sep 24 14:53:18 2018 +0530
features/compress: NULL pointer dereferencing clang fix
Added a Label "err" to avoid NULL pointer dereferencing
Updates: bz#1622665
Change-Id: I7ec02a9cbbc482c2cf77f66e5692e86cd251cd53
Signed-off-by: Harpreet Lalwani <hlalwani@redhat.com>
commit dcf8f1df37bfde77dca7612417b591415c3e7f8b
Author: Susant Palai <spalai@redhat.com>
Date: Thu Oct 4 16:40:08 2018 +0530
cloudsync: coverity fix
CID: 1394631 1394634 1394643 1394645 1394652 1394655 1394661 1394666
1394669 1394670 1394671
Issue: Argument cannot be negative
Change-Id: Id4a9b1adcc271374971e788f161d91e8c9ac442f
Updates: bz#789278
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 74af7e129146c4f203616cd9bae69dfdfce541f8
Author: Susant Palai <spalai@redhat.com>
Date: Wed Oct 3 21:09:15 2018 +0530
libglusterfs: coverity fix
CID: 1395829 Issue: Uninitialized pointer read
Change-Id: I2e03d7b2a2f28f4a46408402ae03beba0f4c8308
Updates: bz#789278
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 81586a84a9287f26a1f31312805bec1764edf67b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Oct 1 14:09:03 2018 -0400
dht: volume_options 'options' collision with nfs-ganesha's 'options'
When dht was converted to xlator_api, the variable 'options' was not
changed to dht_options, the same as was done to all the other xlators
that were converted to xlator_api.
Thus the reference to 'options' in dht.c is not resolved until runtime,
and the RTlinker's search path starts with symbols in the executable,
i.e. ganesha.nfsd's 'options'. (Which is obviously not the right one.)
The unused extern references to 'options' (now dht_options) in nufa.c
and switch.c is curious.
Change-Id: Idf4a5d5fbd39aadfa5a4b529bceea65a3cbdf8f3
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit b714309e39d0b242cca33cf8b9b6d531a3f1d467
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Oct 4 10:31:45 2018 +0200
Reduce execution time of bug-1559004-EMLINK-handling.t
This patch reduces the execution time of bug-1559004-EMLINK-handling.t
from ~14 minutes to ~90 seconds. To do so, it creates some fake hard
links directly on the brick instead of creating them through the
volume.
Change-Id: I9715ff1a4eba47574c733d4f28e68f42f56a7d3f
updates: bz#1193929
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 4c2fedb02b7464acc2c4766ccb89e37643558c40
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Oct 1 17:30:19 2018 -0400
mgmt/glusterd: use proper path to the volfile
Till now, glusterd was generating the volfile path for the snapshot
volume's bricks like this.
/snaps/<snap name>/<brick volfile>
But in reality, the path to the brick volfile for a snapshot volume is
/snaps/<snap name>/<snap volume name>/<brick volfile>
The above workaround was used to distinguish between a mount command used
to mount the snapshot volume, and a brick of the snapshot volume, so that
based on what is actually happening, glusterd can return the proper volfile
(client volfile for the former and the brick volfile for the latter). But,
this was causing problems for snapshot restore when brick multiplexing is
enabled. Because, with brick multiplexing, it tries to find the volfile
and sends GETSPEC rpc call to glusterd using the 2nd style of path i.e.
/snaps/<snap name>/<snap volume name>/<brick volfile>
So, when the snapshot brick (which is multiplexed) sends a GETSPEC rpc
request to glusterd for obtaining the brick volume file, glusterd was
returning the client volume file of the snapshot volume instead of the
brick volume file.
Change-Id: I28b2dfa5d9b379fe943db92c2fdfea879a6a594e
fixes: bz#1635050
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 9dab580c47615bead17dc2cd52b552b076faf4db
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Oct 3 16:34:54 2018 +0530
glusterd: ignore RPC events when glusterd is shutting down
When glusterd receives a SIGTERM while it receives RPC
connect/disconnect/destroy events, the thread might lead to a crash
while accessing rcu_read_lock () as the clean up thread might have
already freed up the resources. This is more observable when glusterd
comes up with upgrade mode = on during upgrade process.
The solution is to ignore these events if glusterd is already in the
middle of cleanup_and_exit ().
Fixes: bz#1635593
Change-Id: I12831d31c2f689d4deb038b83b9421bd5cce26d9
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 4bdfec78557a75c8d7cc0dea4eb19d29bdfd498d
Author: Iraj Jamali <ijamali@redhat.com>
Date: Mon Sep 24 16:44:45 2018 +0530
mgmt/glusterd: NULL pointer dereferencing clang fix
Added checks to avoid NULL pointer dereferencing
Updates: bz#1622665
Change-Id: I745c1f3ba4df0e486ce99301843f9f13d01c00e0
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit 1150be07865ac54d5aba8e1ad789a6b956183e30
Author: shujun10086 <shujun.huang@nokia-sbell.com>
Date: Tue Oct 2 08:37:17 2018 +0000
cli: fix glusterd memory leak cause by "gluster v status volume_name"
If use this command every some seconds for example 15s to check gluster brick
status, the glusterd will use about 1G memory in a year. free the value of rsp
in gf_cli_status_cbk. glusterd allocate the value of rsp and send it to cli, but
cli do not free the value, that cause glusterd memory leak.
fixes: bz#1635480
Change-Id: I3f19cd0d4b791ae1b35f9664b3a668b1579f1178
Signed-off-by: shujun10086 <shujun.huang@nokia-sbell.com>
commit 9f63a5bd165572eb0f5038b27ed61c4c5e9510a4
Author: Iraj Jamali <ijamali@redhat.com>
Date: Tue Sep 25 16:45:48 2018 +0530
mgmt/glusterd: NULL pointer deferencing clang fix
Changed this->name to "glusterd"
Updates: bz#1622665
Change-Id: Ic8ce428cefd6a5cecf5547769d8b13f530065c56
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit c118504241363e2f25c19b78c395907248f4f34e
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Sep 30 16:54:03 2018 +0200
python: remove shebangs of non-main scripts and make others executable
Some of the scripts that have a #!/usr/bin/python3 shebang do not have a
main() like function. These scripts will not get executed but only
imported. They do not need the shebang.
A few others are not installed with 'make install', but do have a main()
like function. These scripts are expected to be used by developers for
different tasks (mostly code generation). Marking these scripts
executable to make it easier to identify them.
Change-Id: I73541471deb7e0830766b804786244e73dfe4221
Updates: #411
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 34ff315b35fcf3145580b7095f898b8c37f98a15
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Sep 23 23:53:39 2018 +0530
rpc: make binding to port 0 as the default if no option is provided
Right now, if no option is provided, the default port is assumed,
which is 24007. Ideally, for 'glusterfsd' processes, it is better
to not assume there are any ports given, so it can start listening
on any port which is available.
This helps us to cleanup the dependencies on glusterd from glusterfsd
at the moment. No changes would be done to glusterd code, but making
the right defaults helps to make glusterfsd more independent process
later.
NOTE: This patch is a reduced version of below set of patches:
* https://review.gluster.org/14613/ &
* https://review.gluster.org/14670/ &
* https://review.gluster.org/14671/
Credits: Prasanna Kumar Kalever <pkalever@redhat.com>
updates: bz#1343926
Change-Id: Ib874e10505e7366dc56ba754458252b67052e653
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 34f62e63281ea89adf137e53bd9b7a8197c87d54
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Sep 28 06:11:52 2018 -0400
georep: python2 to python3 compat - pickle
Handle py2 and py3 compatibility for pickling and unpickling.
Geo-rep pickles and unpickles reading sys.stdin and sys.stdout streams.
py2 and py3 compatibility expects the streams to be opened in binary
mode but the sys.stdout objects are different in python2
and python3
python2:
>>> type(sys.stdout)
<type 'file'>
python3:
>>> type(sys.stdout)
<class '_io.TextIOWrapper'>
So in order to access binary stream, using sys.stdin.buffer in python3
Updates: #411
Change-Id: I1a633ccdddff5baf0cf05a8b493add39ddf75bd7
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 7ab7308cf7b4119849109ca6f94168cf64295293
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Sep 28 05:52:36 2018 -0400
georep: python2 and python3 compat - bytes-str
1. Fix fdopen used for pid file
2. Fix sha256 checksum calculation
Updates: #411
Change-Id: Ic173d104a73822c29aca260ba6de872cd8d23f86
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 8308bca8fcee9df71abf24dc1ea17681f0242740
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Sep 28 07:48:13 2018 -0400
georep: python2 to python3 compatibility-mount write
python3 expects byte string for os.write. This works
for both py2 and py3. Fixed the same for geo-rep
mount testing code path.
Updates: #411
Change-Id: I2dfedcb0869457707bcca4d2847ef0d52bff1987
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 58618f8e485f1767651ddf5b7400ffdf78a76845
Author: Raghavendra Manjunath <raghavendra@redhat.com>
Date: Wed Sep 12 10:24:23 2018 -0400
MAINTAINERS: Add Sunny Kumar as a peer for snapshots
Change-Id: I691a56125143fb60735073595d8c5e43273c9bc1
fixes: bz#1634102
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 59d6ba52d8cacf63f7e581858227f8004f58d138
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sun Sep 23 16:42:54 2018 +0530
cli: handle negative scenarios
When control flow reaches negative case code block, we added
"goto out" statement without assigning ret to -1.
This patch assigns return value to -1, before going to the lable "out".
Change-Id: I6db651a3c9ca285ade9ee1ca23d0abe6b36fda3a
updates: bz#1193929
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 241e747bcf41b03e8c3ec327beaaab240ca468ba
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Sep 26 02:58:10 2018 +0530
index : fix coverity issues in index.c
This patch fixes CID 1356508 and 1356577.
Change-Id: I09bc5398fbf6ee49fc066b42aaedf1170df39df8
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 1219bbb4398e5bb277eddc77b6a8f165b6871c72
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Sep 28 10:46:46 2018 +0200
fuse: prevent error message "can't shift that many"
On systems where /bin/sh is not Bash, running plain mount.glusterfs
gives the unhelpful error "can't shift that many".
The argument parsing can be a little improved. Adding a check for the
number of arguments, minimal two (Gluster ip:/volume, and mountpoint),
but possibly more (-o, -v etc.).
With the additional check, running 'mount.glusterfs -h' now shows the
following messags:
Usage: /sbin/mount.glusterfs <server>:<volume/subdir> <mountpoint> -o<options>
Options:
man 8 mount.glusterfs
To display the version number of the mount helper: /sbin/mount.glusterfs -V
Change-Id: I50e3ade0c6217fab4155f35ad8cb35d99d52e133
Fixes: bz#1564890
Reported-by: Alexander Zimmermann <alexander.zimmermann96@gmail.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 855bd4a008e49896da917bc093bb1efafc735613
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Sep 20 18:45:14 2018 +0530
glusterd: fix coverity issues
This patch fixes CID 1274175, 1175018.
1274175: Buffer size warning
1175018: Resource leak
Change-Id: Id18960c249447b8dae35de3ad92bc570e62ddb09
updates: bz#789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 253d453be0d0b81901cc81222de5b4aada6a6c2f
Author: ShyamsundarR <srangana@redhat.com>
Date: Fri Sep 28 13:47:33 2018 -0400
mdcache: Fix asan reported potential heap buffer overflow
The char pointer mdc_xattr_str in function mdc_xattr_list_populate
is malloc'd and doing a strcat into a malloc'd region can
overflow content allocated based on prior contents of the
memory region.
Added a NULL terimation to the malloc'd region to prevent
the overflow, and treat it as an empty string.
Change-Id: If0decab669551581230a8ede4c44c319ff04bac9
Updates: bz#1633930
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 639981356bb1667066e179e6481edfc840a1ffd8
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Sep 26 21:54:06 2018 +0530
libglusterfs : fix coverity issue in store.c
This patch fixes CID 1395102 and 1395103.
Change-Id: Ia6093dc6a04dce3f523e015cf1d6d4c6bfccc1f6
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 001a6304eed6279f812b1fd4c483ea9f8dc62a30
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Sep 24 14:12:45 2018 -0400
python3: assume python3 unless building _packages_ on sys without py3
The jenkins release-new job runs on a CentOS 7 box, which does not
have python3. As a result it runs (autogen.sh and) configure before
producing the dist tar file, converting all the python3 shebangs to
python2 shebangs in the dist tar file.
Then when that tar file is "carried" to, e.g. Fedora koji build
system to build packages, the shebangs are incorrect, despite having
originally been correct in the git repo.
Change-Id: I5154baba3f6d29d3c4823bafc2b57abecbf90e5b
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 0ef554e77cfb51dfa2fa5f668e702cf01b8ce3e4
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Tue Sep 18 07:58:58 2018 -0400
rpc: failed requests immediately if rpc connection is down
In the case glfs_fini is ongoing, some cache xlators like readdir-ahead,
continues to submit requests. Current rpc submit code ignores
connection status and queues these internally generated requests. These
requests then got cleaned up after inode table has been destroyed,
causing crash.
Change-Id: Ife6b17d8592a054f7a7f310c79d07af005087017
updates: bz#1626313
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit b78f18c24d9860472a2e76bbcf72720889b8af3c
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 10 19:28:12 2018 +0530
monitoring: create dump dir if it doesn't exist
Fixes: bz#1624006
Change-Id: Ie78be72e2492cd02c1376852bb90f1e6661d9bea
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 3efb7d1a81df7cd97ad895c3c401b060e1f45e58
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Sep 25 23:36:48 2018 +0530
glusterd: make sure that brickinfo->uuid is not null
Problem: After an upgrade from the version where shared-brick-count
option is not present to a version which introduced this option
causes issue at the mount point i.e, size of the volume at mount
point will be reduced by shared-brick-count value times.
Cause: shared-brick-count is equal to the number of bricks that
are sharing the file system. gd_set_shared_brick_count() calculates
the shared-brick-count value based on uuid of the node and fsid of
the brick. https://review.gluster.org/#/c/glusterfs/+/19484 handles
setting of fsid properly during an upgrade path. This patch assumed
that when the code path is reached, brickinfo->uuid is non-null.
But brickinfo->uuid is null for all the bricks, as the uuid is null
https://review.gluster.org/#/c/glusterfs/+/19484 couldn't reached the
code path to set the fsid for bricks. So, we had fsid as 0 for all
bricks, which resulted in gd_set_shared_brick_count() to calculate
shared-brick-count in a wrong way. i.e, the logic written in
gd_set_shared_brick_count() didn't work as expected since fsid is 0.
Solution: Before control reaches the code path written by
https://review.gluster.org/#/c/glusterfs/+/19484,
adding a check for whether brickinfo->uuid is null and
if brickinfo->uuid is having null value, calling
glusterd_resolve_brick will set the brickinfo->uuid to a
proper value. When we have proper uuid, fsid for the bricks
will be set properly and shared-brick-count value will be
caluculated correctly.
Please take a look at the bug https://bugzilla.redhat.com/show_bug.cgi?id=1632889
for complete RCA
Steps followed to test the fix:
1. Created a 2 node cluster, the cluster is running with binary
which doesn't have shared-brick-count option
2. Created a 2x(2+1) volume and started it
3. Mouted the volume, checked size of volume using df
4. Upgrade to a version where shared-brick-count is introduced
(upgraded the nodes one by one i.e, stop the glusterd, upgrade the node
and start the glusterd).
5. after upgrading both the nodes, bumped up the cluster.op-version
6. At mount point, df shows the correct size for volume.
fixes: bz#1632889
Change-Id: Ib9f078aafb15e899a01086eae113270657ea916b
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 8e6916b9728378d1ce3d7c5875bf8e6d37ee439c
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Tue Sep 18 07:38:48 2018 -0400
libgfapi: fix use after freed of clnt when dispatching events
Avoid dispatching events to mgmt after freed,
unreference mgmt after the event_dispatch_destroy.
Change-Id: I5b762b37901de70a955661df0aff95bf055ba4ea
updates: bz#1626313
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 4339155c0f2cc74a0e43a49f9f4d96dad2d20770
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Sep 23 11:04:22 2018 +0300
Quota related files: use dict_{setn|getn|deln|get_int32n|set_int32n|set_strn}
In a previous patch (https://review.gluster.org/20769) we've
added the key length to be passed to dict_* funcs, to remove the need
to strlen() it. This patch moves some code to use it.
Please review carefully.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: If4f425a9827be7c36ccfbb9761006ae824a818c6
commit e75412e3f95b399195dd649668fd261796b837f1
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Mon Sep 24 16:37:51 2018 +0530
cluster/ec: variable-length array (VLA) declaration clang fix
Problem: variable-length array size becomes zero
Modified array size to size+1 while declaring
Updates: bz#1622665
Change-Id: I98ee8447c87f37c36c49f50058292e8c1757a1f9
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit a65ddd0099d42afb4a77a65abd0f3d71a80c75b9
Author: Iraj Jamali <ijamali@redhat.com>
Date: Mon Sep 24 15:12:25 2018 +0530
features/locks: NULL pointer deferencing clang fix
Added checks to avoid NULL pointer dereferencing
Updates: bz#1622665
Change-Id: I8e441c2931f406a6012e418127550bdf454a599a
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit 1df2af1d9782f9e60ba99ac0d1ca886114b0dda7
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Sep 24 21:18:30 2018 +0530
georep: python3 compatibility (Popen)
The file objects for python3 by default is opened
in binary mode where as in python2 it's opened
as text by default.
The geo-rep code parses the output of Popen assuming
it as text, hence used the 'universal_newlines' flag
which provides backward compatibility for the same.
Change-Id: I371a03b6348af9666164cb2e8b93d47475431ad9
Updates: #411
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit d2f384e847924d03bda71f75e193bf5681056831
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Sep 3 09:07:58 2018 -0400
ctime: Provide noatime option
Most of the applications are {c|m}time dependant
and very few are atime dependant. So provide noatime
option to not update atime when ctime feature is
enabled.
Also this option has to be enabled with ctime
feature to avoid unnecessary self heal. Since
AFR/EC reads data from single subvolume, atime
is only updated in one subvolume triggering self
heal.
updates: bz#1593538
Change-Id: I085fb33c882296545345f5df194cde7b6cbc337e
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit a9a6b38ecd948992c8b3023f169275dc4125692a
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Aug 20 17:54:32 2018 +0530
nfs : fix coverity issues
Fixes 1388608 and 1274073.
updates: bz#789278
Change-Id: Ibe2b948ae3b02feb938caffe81b2e484b4c7b221
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit fc7c3607c3ab30dd9997b026f201b4dbfc6cba04
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Sep 24 20:43:54 2018 +0530
georep: Fix python3 compatibility (configparser)
'%' needs special handling in config and also removed
duplicate misspelled 'changelog-archive-format' config.
Updates: #411
Change-Id: I33621a62bdf5f781ee62e6cedec0c2df3f5d70cf
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit b56ff4fa364f22215b88304a6849917afce82df2
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Sep 24 20:56:21 2018 +0530
georep: Fix python3 compatibility (os.pipe)
'os.pipe' returns pair of file descriptors
which are non-inheritable by child processes.
But geo-rep uses te inheritable nature of
pipe fds to communicate between parent and
child processes. Hence wrote a compatiable
pipe routine which works well both with python2
and python3 with inheritable nature.
Updates: #411
Change-Id: I869d7a52eeecdecf3851d44ed400e69b32a612d9
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit a24da8b7ab243e435288cec03c5c5e82541c416b
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Sep 24 13:21:58 2018 -0700
features/marker: Avoid passing structures as parameters to functions
Fixes CIDs: 1388779,1390242,1390057
The patch does the following:
1. Changes the prototype of mq_inspect_file_xattr() and mq_xattr_state()
to have a parameter of struct iatt * instead of struct iatt.
2. Remove unneeded struct iatt parameter from
mq_inspect_directory_xattr()
Change-Id: I1f6eabda042f0fe56d8c9bca010302f5e518dbe4
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit b48074a6f646f1abaf968767ac8ad1c35c4c420d
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Sep 21 16:03:22 2018 +0530
glusterd: fix coverity issues
This patch addreeses CID 1124812, 11248123, 1124833,
and 1351706
1. We have a null check after GF_ASSERT. GF_ASSERT does
a null check and fails if it is null. So removing the
redundant null checks.
2. Added a log message to avoid unused value coverity issue
Change-Id: Ib0d6dad8f40474afc8e5e60a531d37247cc8a081
updates: bz#789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 3372206edb584fdce31f316c318b7b05ca171a85
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Mon Sep 24 15:03:18 2018 +0530
mgmt/glusterd: NULL pointer dereferencing clang fix
Added a condition check to resolve the issue
Change-Id: I1954e91f7487c052caf5cf98c954d204242f0af9
Updates: bz#1622665
Signed-off-by: Shwetha Acharya <sacharya@redhat.com>
commit 9c010483e7596866fabd4d5d80dabbe59133dd41
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Sep 24 14:50:24 2018 +0530
cluster/ec: Fix failure of tests/basic/ec/ec-1468261.t
Problem:
In this test we are relying on eager-lock time
duration of 1 second to delay the post op + unlock phase
of an entry fop so that in this 1 second we can kill 2
bricks and dirty on directory could be set.
Solution:
To fix this issue, we should set the others.eager-lock
option to "ON" explicitly in the beginning of this test.
Change-Id: I19bbb9c15d7bdf96a96b20587c618192d0b740ef
fixes bz#1632161
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 7e01e5110b73dff48d9f70c6691f75f2d7ff8c42
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Sep 14 13:42:20 2018 -0400
api: old and new versioned symbols must appear in each section of gfapi.map
It's probably not clear in .../doc/developer-guide/gfapi-symbol-versions.md
that this is necessary, but it is.
Change-Id: I0a8a74e3ecf474c93583f5ebc97507c4277542b0
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit adc1ef4541a2bf7b93aa192c6c1803b6f94e3117
Author: Susant Palai <spalai@redhat.com>
Date: Mon Sep 17 12:18:13 2018 +0530
dht: Coverity fixes
CID: 1274236 Issue: Logically dead code (op_errno will never be -1)
CID: 1351652 Issue: Dereference after null check.
(local->fd is dereferenced anyway and it should not be NULL ever for
dht_readdirp_cbk.)
Change-Id: Ied9c5f5b72536be1ca944237165acdc62b792e58
updates: bz#789278
Signed-off-by: Susant Palai <spalai@redhat.com>
commit c9c0a48eaef0dfd1362acc9ee5ef2e5a2e094761
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Sep 24 17:53:35 2018 +0530
glusterfind: add logs to identify parsing phases
Add logs to idenitfy start and finish of changelog parsing phases.
Change-Id: Id250231f2af7829f887401d30ac98875ae1ae793
fixes: bz#1632236
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 3d5f1e7af9c1435d800f7d586198eb67aefa2ae1
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Sep 21 21:51:46 2018 +0200
Update database profile group
Some performance testing has revealed that pgbench performs 3x better
when these options are set:
performance.client-io-threads=on
performance.open-behind=on
performance.read-after-open=yes
server.event-threads=4
client.event-threads=4
Change-Id: I36ce389f893a8af13aac5f8285104d749b73d098
fixes: bz#1631886
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 4b73f116bc95190a286ce3938822c10fc1fc012d
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Sep 24 15:26:01 2018 +0530
geo-rep : fix log message in master.py
This patch fixes spell mistake in log message.
Change-Id: I84779c64aef6698cbc1a60ae1a82533e8a6a6e3d
updates: bz#1193929
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 2907f1fdbc8b3c09971a1947ab8a6c1099701e25
Author: Nigel Babu <nigelb@redhat.com>
Date: Fri Sep 14 19:06:41 2018 +0530
python3: Fix python3 compatibility
Updates: #411
Change-Id: I7c1eaa92cd4ac05c3667b760e0db2cddcfbbaed8
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit 95513d26b2a75ce6f5a8c14264c5736a7280e24f
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Sep 21 12:45:12 2018 +0530
glusterd: reduce length allocated to name
In glusterd_proc_ and glusterd_svc_ structures name is having
length of PATH_MAX, allocating NAME_MAX will be sufficient.
Change-Id: I637ba00e1a80ca6a1ecc0c2dbf180c4633c1ca5b
updates: bz#1193929
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 1be693501073848bc589b3bcacb302973fb8ba7f
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Sep 21 11:55:12 2018 +0530
glusterd: fix resource leak coverity issues
This patch addresses CID 1288098,1370948 and 1382454
key_fixed is allocated with memory but missed to free it.
updates: bz#789278
Change-Id: Iea805c668ba89759313f9e21b328757e570be97b
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 0005b3a24e962479796200a246f2625d6dc5ada6
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Sep 20 11:37:36 2018 +0530
glusterd: fix coverity issues in glusterd-locks.c
This patch addresses CID 1395254, CID 1382436.
We are allocating memory to mgmt_lock_timer and key_dup. while doing
GF_VALIDATE_OR_GOTO for mgmt_lock_timer_xl or mgmt_lock_timer_ctx,
if it is null going to out without freeing the memory. This patch
will fix the issues.
updates: bz#789278
Change-Id: Ic6bfb2052982b16373f90cbbc53d2b2da052c01f
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 28ea164f38d2fdba8905cb047f24df2f33d7bd49
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Sep 21 12:11:40 2018 +0530
glusterd: don't wait for blockers flag for stop volume
With commit 4f6ae8 even though the overall transaction time for gluster
volume stop can be reduced, but based on testing it can't be guaranteed
that the transaction can finish in 3 minutes before the unlock timer
gets kicked in. The ground problem to this is the command serialization
which atomic field 'blockers' does for volume stop operation.
This patch removes that dependency for volume stop not to wait for
blockers.
Change-Id: Ifaf120115dc7ed21cf21e65e25c4ec7c61ab8258
Fixes: bz#1631128
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 089ccd24ffcf4c1b0dc7c06eac465649aae4463a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Sep 20 10:14:26 2018 +0530
afr: fix incorrect reporting of directory split-brain
Problem:
When a directory has dirty xattrs due to failed post-ops or when
replace/reset brick is performed, AFR does a conservative merge as
expected, but heal-info reports it as split-brain because there are no
clear sources.
Fix:
Modify pending flag to contain information about pending heals and
split-brains. For directories, if spit-brain flag is not set,just show
them as needing heal and not being in split-brain.
Fixes: bz#1626994
Change-Id: I09ef821f6887c87d315ae99e6b1de05103cd9383
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 91a251977cda957ae79067fca555654af164a02d
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Sep 18 14:51:10 2018 +0530
glusterfsd/mgmt : Check for NULL after creating frame
CID: 1382390
https://scan6.coverity.com/reports.htm#v42607/p10714fileInstanceId=85472585&defectInstanceId=26074725&mergedDefectId=1382390
Change-Id: Iade073a5e72f29ad5e8f372955869bc287eb9793
updates: bz#789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit abdace1094cf96cc66fa348f66991ac6401d9110
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Tue Sep 18 16:34:07 2018 +0530
ctr: NULL pointer dereferencing clang fix
Replaced this->name with "ctr"
Updates: bz#1622665
Change-Id: I49af42a5d77c98ffb34224c8800757b8986012ea
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 3e8250a20f56261ce4cf014163b0dc761839d999
Author: Shwetha Acharya <sacharya@redhat.com>
Date: Tue Sep 18 15:40:29 2018 +0530
nfs/server: NULL pointer dereferencing clang fix
Added some condition checks in nfs3.c and nlm4.c
Updates: bz#1622665
Change-Id: Ia10b8fff14f651df1360c9bb79d4476b282f54b5
Signed-off-by: Shwetha Acharya <sacharya@redhat.com>
commit e5edde9f35a2a02f373e758d9dd8fc5f5b75deb3
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Sep 21 00:40:46 2018 +0530
block : fix coverity in bd.c
This patch fixes CID 1288097, 1128921, and 1128918
all of type RESOURCE_LEAK.
Change-Id: If39be19c6310eab9880de6f0bebb4f38604a40b2
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 389d3ea7b01fabc14a038d6b4457d1ba1e6b4cd7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Sep 18 12:15:57 2018 +0530
cluster/afr: Make data eager-lock decision based on number of locks
For both Virt and block workloads the file is opened multiple times
leading to dynamically setting eager-lock to off for the workload.
Instead of depending on the number-of-open-fds, if we change the
logic to depend on number of inodelks, then it will give better
performance than the earlier logic. When there is an eager-lock
and number of inodelks is more than 1 we know that there is a
conflicting lock, so depend on that information to decide whether
to keep the current transaction go through delayed-post-op or not.
Locks xlator doesn't have implementation to query number of locks in
fxattrop in releases older than 3.10 so to keep things backward
compatible in 3.12, data transactions will use new logic where as
fxattrop transactions will use old logic. I am planning to send one
more patch which makes metadata domain locks also depend on
inodelk-count
Profile info for a dd of 500MB to a file with another fd opened
on the file using exec 250>filename
Without this patch:
0.14 67.41 us 16.72 us 3870.82 us 892 FINODELK
0.59 279.87 us 95.71 us 2085.89 us 898 FXATTROP
3.46 366.43 us 81.75 us 6952.79 us 4000 WRITE
95.79 148733.99 us 50568.12 us 919127.86 us 273 FSYNC
With this patch:
0.00 51.01 us 38.07 us 80.16 us 4 FINODELK
0.00 235.43 us 235.43 us 235.43 us 1 TRUNCATE
0.00 125.07 us 56.80 us 193.33 us 2 GETXATTR
0.00 135.86 us 62.13 us 209.59 us 2 INODELK
0.00 197.88 us 155.39 us 253.90 us 4 FXATTROP
0.00 450.59 us 394.28 us 506.89 us 2 XATTROP
0.00 56.96 us 19.06 us 406.59 us 23 FLUSH
37.81 273648.93 us 48.43 us 6017657.05 us 44 LOOKUP
62.18 4951.86 us 93.80 us 1143154.75 us 3999 WRITE
postgresql benchmark performance changed from ~1130 TPS to ~2300TPS
randio fio job inside Ovirt based VM went from ~600IOPs to ~2000IOPS
fixes bz#1630368
Change-Id: If7f7388d2f08cf7f17ca517a4ea222560661dc36
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 15d17af0d3ddeca0274c78fb9b2d56eeb11201ba
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Sep 19 15:49:27 2018 +0530
extras: Add new options to group "virt"
In some of the recent performance tests on gluster-as-vm-image-store
use-case, it has been observed that sometimes the lone fuse thread can
hit near-100% CPU utilization and become a performance bottleneck.
Enabling client-io-threads (in addition to bumping up epoll threads on
server and client side) has shown to be helpful in getting around this
bottleneck and pushing more IOPs.
Change-Id: I231db309de0e37c79cd44f5666da4cd776fefa04
fixes: bz#1630798
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit b03e2e76ea00f67c9735238eb649b447c4fb7452
Author: Susant Palai <spalai@redhat.com>
Date: Mon Sep 3 15:49:02 2018 +0530
dht: Operate internal fops with negative pid
With root-squash on, all root credentials are converted to a
random uid, gid(65535). And ideally this does not carry the necessary
permission bits to carry out the operation. But posix-acl will allow
operations from this inode as long as its ctx has the ngroup information
and ngroup has the owner group information.
The problem we ran into recently was somehow posix-acl xlator did not
cache the ngroup info and some of the dht internal fops(layout setxattr)
failed with root-squash enabled.
DHT internal fops now use a negative pid to pretend that the operation
is from an internal client so posix-acl allows them to pass
Change-Id: I5bb8d068389bf4c94629d668a16015a95ccb53ab
fixes: bz#1624796
Signed-off-by: Susant Palai <spalai@redhat.com>
commit e8d770c1845d5a44184e5dfd475959ac00267e48
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Sep 19 18:38:01 2018 +0530
tests: fix test case failure
tests/bugs/glusterd/bug-1595320.t is failing in downstream.
In downstream repo, enabling the brick multiplexing made
interactive, so it will throw an prompt for the user input.
As no input is provided during the test case execution, the
test is failing.
Using macro CLI instead of using gluster command, will
bypass the interacive commands. so replacing the gluster
command with CLI macro will address the issue.
Change-Id: I6b39052d8e415a8ed08de7c80a91dadce155146a
updates: bz#1193929
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 81a1152ae7cb043df01eb30886ee0d7dfa147323
Author: Harpreet Lalwani <hlalwani@redhat.com>
Date: Tue Sep 18 12:31:02 2018 +0530
Quota: NULL pointer dereferencing clang Fix
Added ternary operator to avoid NULL pointer dereferencing
Updates: bz#1622665
Change-Id: I903ec1973fd4bb6473d16e2680bd86ac3a20e093
Signed-off-by: Harpreet Lalwani <hlalwani@redhat.com>
commit 30260c3337307c2276a1b7f36440b3a295f8d2db
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Sep 18 17:09:28 2018 +0530
storage/posix: Check if fd->inode is NULL before using it
CID: 1395473, 1395472
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85588219&defectInstanceId=26115956&mergedDefectId=1395472
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85588219&defectInstanceId=26115961&mergedDefectId=1395473
Change-Id: I2c3cc350e0ac156616df6f568ba28dbfa68064bf
updates: bz#789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit a17486bdc327468a7be85ddfce174eaabb239754
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed May 30 15:27:52 2018 +0530
cluster/afr: Use 2 domain locking in SHD for thin-arbiter
With this change when SHD starts the index crawl it requests
all the clients to release the AFR_TA_DOM_NOTIFY lock so that
clients will know the in memory state is no more valid and
any new operations needs to query the thin-arbiter if required.
When SHD completes healing all the files without any failure, it
will again take the AFR_TA_DOM_NOTIFY lock and gets the xattrs on
TA to see whether there are any new failures happened by that time.
If there are new failures marked on TA, SHD will start the crawl
immediately to heal those failures as well. If there are no new
failures, then SHD will take the AFR_TA_DOM_MODIFY lock and unsets
the xattrs on TA, so that both the data bricks will be considered
as good there after.
Change-Id: I037b89a0823648f314580ba0716d877bd5ddb1f1
fixes: bz#1579788
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 62cdfeae25a3cea85a03c7ae6aa013f372bdfbee
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Sep 19 14:32:22 2018 +0530
glusterd: Use GF_ATOMIC to update 'blockers' counter at glusterd_conf
Problem:
Currently in glusterd code uses sync_lock/sync_unlock to update blockers
counter which could add delays to the overall transaction phase
escpecially when there's a batch of volume stop operations processed by
glusterd in brick multiplexing mode.
Solution: Use GF_ATOMIC to update blocker counter to ensure unnecessary
context switching can be avoided.
Change-Id: Ie13177dfee2af66687ae7cf5c67405c152853990
Fixes: bz#1631128
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 54929275f281966be45dddc907d178a3cb34fef1
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Sep 19 19:49:51 2018 +0530
glusterd: fix crash
When huge number of volumes are created, glusterd crash is seen.
With the core dump, got to know that mgmt_lock_timer became NULL.
Adding a null check for the same, need to explore about the root
cause.
updates: bz#1630922
Change-Id: I0770063fcbbbf4b24bef29e94b857b20bdfb5b85
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 8a1c6cb3423aa768158733486e17200587e75c80
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Sep 17 16:56:48 2018 +0530
geo-rep : fix coverity issues in glusterd-geo-rep.c
This patch fixes CID 1210979, 1214614, 1292650, 1357874, 1382404.
1. overflowed or a truncated value : call to sys_read has been reduced
to 'sizeof(buf) -1' and after operation buf is properly terminated.
2. tainted_data_argument : truncation due to cast operation on operand :
resulted form call to strtol: chaged data type from pid_t to long.
3. tainted_data_argument : call to fgets is reduced by 2 to make space
for the '\n' and '\0'.
updates: bz#789278
Change-Id: Ib883501205c85007771213071c8e182286eb0bc0
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 12919ed17e8a9e43698e8c6003acb7daa0a5848b
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Sep 18 12:07:29 2018 +0530
glusterd: Improve logging in gd_mgmt_v3_unlock_timer_cbk
Change-Id: I3335e7df3256d97c2211b64cfcaac9a016723471
Updates: bz#1193929
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit d3e2f183accb044576df10b3ec2dde06646db84f
Author: Iraj Jamali <ijamali@redhat.com>
Date: Tue Sep 18 15:40:45 2018 +0530
libglusterfs: NULL pointer dereferencing clang fix
Problem: trav could be NULL.
Solution: Adding a check to avoid clang error.
Updates: bz#1622665
Change-Id: If26be82edea5e33c2356cea3769496f1cbd3774c
Signed-off-by: Iraj Jamali <ijamali@redhat.com>
commit 93ab73c3488628b6314c89e63f17b7e330175c99
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Sep 6 15:09:42 2018 +0530
cluster/afr: Batch writes in same lock even when multiple fds are open
Problem:
When eager-lock is disabled because of multiple-fds opened and app
writes come on conflicting regions, the number of locks grows very
fast leading to all the CPU being spent just in locking and unlocking
by traversing huge queues in locks xlator for granting locks.
Fix:
Reduce the number of locks in transit by bundling the writes in the
same lock and disable delayed piggy-pack when we learn that multiple
fds are open on the file. This will reduce the size of queues in the
locks xlator. This also reduces the number of network calls like
inodelk/fxattrop.
Please note that this problem can still happen if eager-lock is
disabled as the writes will not be bundled in the same lock.
fixes bz#1625961
Change-Id: I8fd1cf229aed54ce5abd4e6226351a039924dd91
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit b13b7855e5014e916fc64eb7a89c0ad3e8d70901
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 17 14:25:16 2018 +0530
dht: utilize the framework to pass-through xlator tasks
Also fixes the issue caused due to not converting back the fn function
to after getting its address. We wanted the value of the field, not
the address of the pt_fop field.
With this patch, DHT will always be started in pass-through
mode if the number of subvols is just 1.
Fixes some tests to make sure DHT is in full config (ie, subvols > 1).
- increased timeout of brick-mux test as it was bordering on 300 seconds.
- Also change the volume type to supported 'replica 3' from 'replica 2'.
- also no DHT tests should assume presence of DHT when there is
just 1 brick in volume
Credits: Nithya B <nbalacha@redhat.com>
fixes: #405
Change-Id: I8e55239ce58d6ac6ae1901e2e384be1ecbd33d6e
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7f3ce1f6a24299e0b48fca5a4ff935792cd632e0
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Mar 9 14:29:37 2017 +0530
extras/devel-tools: script to strace processes
Script to strace processes at high priority.
Script should be run at high priority, like nice value of -19, to help
get a trace of a run-away process consuming high CPU.
eg.
$ nice -n -19 ./strace-brick.sh glusterfsd 50
will strace glusterfsd processes for 60 seconds which are consuming a
minimum of 50% CPU.
Change-Id: I6374054c7342b19122a3588d982388199f955930
BUG: 1427397
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 8bac93f12830bf856ed88c5a81bfada03cca1ca5
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 17 11:57:22 2018 +0530
logrotate: utilize the new 'maxsize' option
Since logrotate 3.8.x version, a new option 'maxsize' is supported,
which helps in rotating the logs before the specified time if the
size exceeds maxsize limit. This should help in reducing the
overflow of gluster logs.
Updates: bz#1193929
Change-Id: Id33c34d72f1931e7996893de9338db667e1e900d
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 63d84df3b77af2af2a81138a3086b702c21c8f40
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Aug 30 09:29:49 2017 +0530
extras/devel-tools: script to resolve backtraces
print-backtrace.sh
script to resolve backtraces
Change-Id: I24688ae5160cc706d9f4794521d17290bef6765b
BUG: 1486532
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 22cf6109c05fe0f591b4d9294acf38924775097b
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Sep 18 14:19:11 2018 +0530
tests/dht: Uncomment cleanup steps
I had forgotten to uncomment the cleanup
steps for file-create.t. Fixed.
Change-Id: Id702b99b8e09f56b7333491a477828b4a37b2687
updates: bz#1628194
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit cfa5fb65c0a4dccc8e06dfe46bdf44abd2ff4b7e
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Sep 6 10:46:43 2018 +0530
tests: fixes to bug-1015990-rep.t
- check that the shd is connected to brick before running statistics command
- remove sleep statements
- remove unneeded ($count-$value==0) test when it is known that both values will
be same
Fixes: bz#1625850
Change-Id: Ifcd4887f0238031e5bca803cd9bfdb75a6e6c01b
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 3ff07aa762495c88c9821ada915a7bbb8f780410
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Sep 17 14:16:09 2018 +0530
posix: Fix exporting default value for `export-statfs-size`
No default value was specified for `export-statfs-size` in posix
option table. Glusterd2 sets default value as `off` since the
option type is `bool`. Posix treats `export-statfs-size=on` if
not specified in volfile(That means default value is `on`)
This patch sets default value as `on`
Change-Id: I5c6341183be9b62a78fdbc94621220f9284e1382
updates: #302
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 157b77ef1c8f552dd196d4fc34a0062442f708cb
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Sep 14 03:42:26 2018 -0400
geo-rep: Fix issues related config set
1. '--ignore-mising-args' option for rsync is not
being used even though the rsync version is
greater than 3.1.0. Fixed the same.
2. '--existing' option for rsync is also not being
used. Fixed the same.
3. geo-rep config fails to set rsync-options as the
value contains '--'. Interestingly, python argsparse
treats the value with '--' (e.g., --ignore-missing-args)
as option. But when passed with something like
--value=--ignore-missing-args, it succeeds. Fixed the
same.
Change-Id: Iaeb838acaff1c2920fee9c7f920c99edce13a0a1
Signed-off-by: Kotresh HR <khiremat@redhat.com>
fixes: bz#1629561
commit c8a9a5cfbc0acbbc6a448ceb5c82353356c9fd2a
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Sep 11 14:19:42 2018 +0530
glusterd: acquire lock to update volinfo structure
Problem: With commit cb0339f92, we are using a separate syntask
for restart_bricks. There can be a situation where two threads
are accessing the same volinfo structure at the same time and
updating volinfo structure. This can lead volinfo to have
inconsistent values and assertion failures because of unexpected
values.
Solution: While updating the volinfo structure, acquire a
store_volinfo_lock, and release the lock only when the thread
completed its critical section part.
Fixes: bz#1627610
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
Change-Id: I545e4e2368e3285d8f7aa28081ff4448abb72f5d
commit 5882aee9f4cf2d1a4346513c057c7ada84c5748e
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Thu Sep 6 18:17:14 2018 +0800
event: get time by clock_gettime as pthread_cond_timedwait using
Debug information shows time() has a delay between seconds increase,
get the right time by clock_gettime as pthread_cond_timedwait using.
ret = pthread_cond_timedwait (&event_pool->cond,
&event_pool->mutex,
&sleep_till);
+ gf_msg ("epoll", GF_LOG_INFO, 0,
+ LG_MSG_EXITED_EPOLL_THREAD,
+ "pthread_cond_timedwait %lu %p return %d (active %d:%d)",
+ sleep_till.tv_sec, event_pool, ret,
+ event_pool->activethreadcount, threadcount);
}
}
pthread_mutex_unlock (&event_pool->mutex);
[2018-09-06 18:33:57.000879] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.000916] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.000931] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.000945] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.000957] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.000970] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.000983] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.000997] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.001010] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.001022] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.001034] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.001060] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230037 0x1f48e60 return 110 (active 5:4)
[2018-09-06 18:33:57.003085] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230038 0x1f48e60 return 0 (active 4:4)
[2018-09-06 18:33:57.014142] I [event.c:284:event_dispatch_destroy] 0-epoll: pthread_cond_timedwait 1536230038 0x1f48e60 return 0 (active 3:4)
Change-Id: I735249eee9a6f8284392b69e501479ac163b8409
fixes: bz#1626313
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 880f89398111a3c8e94156ee3a2ea4a3c73b0a19
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Fri Sep 14 10:27:56 2018 +0530
protocol/server: NULL pointer dereferencing clang fix
Problem: Access to field fop_length results in null pointer dereferencing.
Solution: Added condition checks fix the issue.
Change-Id: Id408e3ac62ea9574f0cd9aecce5434add09eb7d0
Updates: bz#1622665
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit e958b2ccd74920da4eb56755abc91abcbc5bc8ab
Author: Harpreet Lalwani <hlalwani@redhat.com>
Date: Tue Sep 11 23:00:14 2018 +0530
glusterd: NULL pointer dereferencing clang Fix
Added ternary operator to avoid NULL pointer dereferencing
Updates: bz#1622665
Change-Id: I855f6caf720b28af1564898d75c6c965bcc58c5c
Signed-off-by: Harpreet Lalwani <hlalwani@redhat.com>
commit b2855c91bd26b184f3e0a3ffe23f599d420a2463
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Sep 11 16:53:29 2018 +0530
glusterd : fix coverity issue in glusterd-store.c
This patch fixes CID 1124356: Unchecked return value (CHECKED_RETURN)
updates: bz#789278
Change-Id: I81f4637f19b81f820a2deb70cc7f84b79fe70236
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit f8a6c9075e97b2b34c825ea78f394cd6dbe12484
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Sep 12 18:19:09 2018 +0530
tests/dht: Add tests for file create
Test dht file creates
Change-Id: I7aba710f4911432bd3b86834efecae8f01e4052f
updates: bz#1628194
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 29e98010dc7b9c671432e0edec870b364b200eb8
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Sep 10 09:02:33 2018 -0400
packaging: glusterfs.spec(.in) cleanup
Someone (not me) once alphabetized all the %package, %files, and etc.
sections, with a comment to keep them alphabetized. Move cloudsync
sections to their correct locations in the spec.
Also reorder testing and playground within %files section, keep testing
%dirs together.
Change-Id: I79e2e7a82d20275fd61d018880bcb5913c8f75f3
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit d88548b32d78aee45c06a07f022822469f669e9f
Author: ShyamsundarR <srangana@redhat.com>
Date: Fri Sep 14 12:06:28 2018 -0400
gfapi: Cleanup alias file
2 extra symbols were in the alias file, that are not exported
this is cleaned up with this patch.
Change-Id: I1ab54b9fb6b0d455884fbbfd89820c60bb861e6f
Updates: bz#1193929
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 1d8e13631cd4f05eb0607069a28a3f7a8c280c0d
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Sep 11 11:42:19 2018 +0300
libglusterfs/src/dict.c : use xxhash64 for hashing.
As part of a larger effort to consolidate hash functions
and use a faster, with less collissions, I've moved to use
xxhash as the hashing function for the dictionary.
Note: I'm using only 32 bits of the hashes, as the hash field
is currently a 32 bit variable. There's room (since the struct
is not packed) to move to use a 64bit variable. Donno how it'll
affect performance.
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ie244efd1368234e54dd5957ee1ae5bebd7d9409a
commit 7df25c74a70c2fba3d61c60b9821b7aa152f3180
Author: Anoop C S <anoopcs@redhat.com>
Date: Sun Sep 9 11:39:47 2018 +0530
extras/hooks: General improvements to S30samba-start.sh
Based on https://review.gluster.org/c/glusterfs/+/19204 from
Milan Zink <mzink@redhat.com>
Change-Id: I61f62407a62475a74a6cc046c24748a31c66e6cd
Updates: bz#1193929
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 91dbe062f921069b9f197b1b077f58991b79dff0
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Sep 13 15:44:15 2018 +0200
socket: set 42 as default tpc-user-timeout
The 'tcp-user-timeout' option is define in the 'socket' module, but it's
configured in 'protocol/server' and 'protocol/client', which are the
parents of the 'socket' module.
However, current options management logic only takes into consideration
default values specified in the 'socket' module itself, ignoring values
defined in the owner xlator.
This patch simply sets the default value of tcp-user-timeout in the
'socket' module so that server and client use the expected value.
Change-Id: Ib8ad7c4ac6aac725b01a78f8c3d10cf4063d2ee6
fixes: bz#1628605
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 55028a70c4af853fdc17cbb120cd695546fbf0e2
Author: ShyamsundarR <srangana@redhat.com>
Date: Thu Sep 13 12:50:30 2018 -0400
glusterd: Update op-version from 4.2 to 5.0
Post changing the max op-version to 4.2, after release
4.1 branching, the decision was to go with increasing
release numbers. Thus this needs to change to 5.0.
This commit addresses the above change.
Fixes: bz#1628664
Change-Id: Ifcc0c6da90fdd51e4eceea40749511110a432cce
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit db54bbaacb916ca5b9f620bb9ed454dc561f165c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 11 14:17:02 2018 -0400
build: cleanup xlator link, --no-undefined, libuuid
While attempting to build a (pre-)5.0 of glusterfs on Ubuntu
bionic and cosmic, it became apparent that there are some gremlins
hiding in the combination of the xlator export-symbols, the newish
addition of -Wl,--no-undefined, and the new switch to libuuid from
the old contrib/uuid.
Note: even though Fedora 28 (and later) and Ubuntu bionic (and
later) have the same nominal version of libtool, the Fedora version
appears to do a better job of recursing through dependencies to
determine the libraries to link with.
Examination of the build logs showed that despite appearing to work
on Fedora, not all xlators and shared libs were linked with -Wl,
--no-undefined, and -luuid. And in the case of the gnfs xlator, it
was not only not linked with -Wl,--no-undefined but alsos not linked
with -lgfxdr and -lgfrpc.
Added GF_XLATOR_LDFLAGS, similar to GF_XLATOR_DEFAULT_LDFLAGS.
GF_XLATOR_DEFAULT_LDFLAGS is for xlators that export/expose the
default or common set of symbols. GF_XLATOR_LDFLAGS is for those
remaining xlators that export/expose non-default symbols, e.g. dht
and glupy. This removes the need in the future to add things like
$(UUID_LIBS) to every xlator's Makefile.am. Just add it to
GF_XLATOR_LDFLAGS and GF_XLATOR_DEFAULT_LDFLAGS in configure.ac
and you're done.
This patch was tested on Fedora 28 (build, rpmbuild), Fedora
Rawhide/30 (rpmbuild), RHEL8 (rpmbuild), CentOS7 (rpmbuild), Fedora
koji --scratch build for f30/rawhide, and a Launchpad build for
Ubuntu cosmic/18.10.
Change-Id: Ieca104fa5c5d3c094e701c8ca4a73754dd0292b0
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit d125e4fe6f454f6d88b5750a2f0fd0f696818d42
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Sep 12 18:35:59 2018 +0530
template files: revert clang
Change-Id: If3925191d23afe83cbbdbc3cf0554c0a9c76d043
updates: bz#1564149
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 968d41ae2bf6ab1b3ab4658f82db11d85276a019
Author: Gluster Ant <bugzilla-bot@gluster.org>
Date: Wed Sep 12 17:52:45 2018 +0530
Land part 2 of clang-format changes
Change-Id: Ia84cc24c8924e6d22d02ac15f611c10e26db99b4
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit 44d72ea7c7a87eef58c9382dc50de0fe95f25b88
Author: Gluster Ant <bugzilla-bot@gluster.org>
Date: Wed Sep 12 17:22:48 2018 +0530
Land clang-format changes
Change-Id: I6f5d8140a06f3c1b2d196849299f8d483028d33b
commit a0508d27bbc6cfdae2702bc96b311bb224b36113
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Aug 22 12:31:48 2018 +0530
clang-format: add the config file
Also update the required documents and scripts to enable clang-format
Change-Id: I73aae6db06c2f732a1779d59a73bc05e28beafba
updates: bz#1564149
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit bc84233b1c93a10e5c439142ce61f49e69496645
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Sep 11 16:09:55 2018 +0530
doc: make developer-index.md as README
This helps to traverse the docs well as README.md is rendered
by default in github pages, and would help to provide better indexed
document for new users.
updates: bz#1193929
Change-Id: I4130dfd16aed924ecab17f96326cedb86892d6a6
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 532780c18efb6591a74c13424b572203948dd558
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Sep 7 11:39:39 2018 +0530
dht: Use snprintf instead of strncpy
The recent changes to use malloc instead
of calloc left the new_name and new_path
non-null terminated. We now use snprintf
instead of strncpy to fix this.
Change-Id: I1a31701ca9447efde38921be0ba2c73cde2e7976
fixes: bz#1626346
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 86eaf5cfa5f1f3056641c701f6952c5721933693
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 20 10:34:28 2018 +0530
doc: add coding-standard and commit-msg link in README
Having the links in README makes people follow it if they browse
through github.
Updates: bz#1193929
Change-Id: I580332a41d9b52858aa9796a74a563ff57a60b4b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 2dbcabd340ef7f34b1d9c5c6e8be6ddb2a9a3a81
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Sep 11 10:31:27 2018 +0530
mount/fuse: convert ENOENT to ESTALE in open(dir)_resume
This patch is continuation of commit
fb4b914ce84bc83a5f418719c5ba7c25689a9251.
<snip>
mount/fuse: never fail open(dir) with ENOENT
open(dir) being an operation on inode should never fail with
ENOENT. If gfid is not present, the appropriate error is
ESTALE. This will enable kernel to retry open after a revalidate
lookup.
</snip>
Earlier commit failed to fix codepath where error response is sent
back on gfid resolution failures in fuse_open(dir)_resume. Current
patch completes that work
Change-Id: Ia07e3cece404811703c8cfbac9b402ca5fe98c1e
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
updates: bz#1627620
commit 187bdff0c710b3ae32173e1a501113e1a104b574
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Sep 10 17:04:30 2018 +0300
mgmt xlators: store boolean fields using integer
Surprisingly, there is not set_boolean() as there is a get_boolean()
In fact, it is stored as an INT dictionary type.
In some occasions it was stored using a string, and this caused
errors such as:
key gfproxy-server, integer type asked, has string type [Invalid argument]
I've fixed what I saw in some logs, I'm sure there are more.
The CORRECT fix is to create a boolean set and use it, but this
requires a bit more work. I'll see if I can do it later on.
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I45fd0c7a0824b2f42b8ce510296c9dfa4f32ad66
commit 8c077a79e2b7b24cf4921ffd8d6a9c9017420329
Author: Harpreet Lalwani <hlalwani@redhat.com>
Date: Mon Sep 10 11:37:35 2018 +0530
glusterd: NULL pointer dereferencing clang fix
problem: NULL point dereferencing
solution: Adding a conditional statement before and then dereferencing it.
Updates: bz#1622665
Change-Id: I562ca90aebf2a4882cfea10114a90364d9ef1996
Signed-off-by: Harpreet Lalwani <hlalwani@redhat.com>
commit f563c73be8c7ea0eaa30c8ed037552e435440088
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Sep 10 09:21:27 2018 -0400
misc: fix misc. shebangs
* One #!/usr/bin/env python and three #!/usr/bin/python were overlooked
in all the other python fixups. Ugh.
* Two new python files missed the memo about #!/usr/bin/python3.
* One #!/usr/bin/env bash.
Various distribution packaging policies have strong wording about
the use of #!/usr/bin/env ...
Note: this patch does not change the use of #!/usr/bin/env bash in
the two files extras/{clang-checker.sh,check_goto.pl} as these are
not included in any packages. (Although I'm not actually sure why
anyone would ever use '/usr/bin/env {sh,bash}' as I'm not aware of
any version-specific differences like there are with, e.g., python.)
* One #!/usr/bin/bash.
On Fedora and CentOS > 6, /bin is a symlink to /usr/bin, so it
makes little difference. But Debian & Ubuntu still have separate
/bin and /usr/bin; and sh and bash are in /bin, not /usr/bin.
(Historically, in BSD and SYSV Unix it was /bin/sh.)
Note: Fedora and CentOS package build runs a script that converts
all /bin/sh and /bin/bash to /usr/bin/sh and /usr/bin/bash.
Change-Id: I9171265829af78dd0cd7622c22b56d22179ff8a3
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 96c02e9bbd5480f7570c4557c6437e28cfad34c0
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Aug 10 01:32:22 2018 +0200
rpm: add "--with asan" build option
RHEL-6 does not have libasan, enabling the "--with asan" option is a
no-op there.
RHEL-7 has an earlier version of libasan, and that does not have the
__asan_init symbol. Test for __asan_report_error in confiure.as instead.
Change-Id: I6322e832c5cfbd7d750f5c32c84c28771674ced6
Updates: #492
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 25323d836a1f4b2d77846bb546bd789946eaa647
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Sep 6 16:15:01 2018 +0530
storage/posix: Fix coverity issue - Unchecked return value
Fixes CID: 1388886
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85287446&defectInstanceId=25997291&mergedDefectId=1388886
Change-Id: Ic4e558bba7e15d213c07bc31affb2e175ace5502
updates: bz#789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit e842e35b34fce9a9e009cb1d8ad88d32bd81cea8
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sat Sep 8 19:53:07 2018 +0530
performance/write-behind: remove the request from wip queue in wb_fulfill_request
The bug is very similar to bz 1379655 and the fix too very similar to
commit a8b2a981881221925bb5edfe7bb65b25ad855c04.
Before this patch, a request is removed from wip queue only when ref
count of request hits 0. Though, wb_fulfill_request does an unref,
it need not be the last unref and hence the request may survive in
wip queue till the last unref. Let,
T1: the time at which wb_fulfill_request is invoked
T2: the time at which last unref is done on request
Let's consider a case of T2 > T1. In the time window between T1 and
T2, any other request (waiter) conflicting with request in liability
queue (blocker - basically a write which has been lied) is blocked
from winding. If T2 happens to be when wb_do_unwinds is invoked, no
further processing of request list happens and "waiter" would get
blocked forever. An example imaginary sequence of events is given
below:
1. A write request w1 is picked up for winding in __wb_pick_winds
and w1 is moved to wip queue. Let's call this
invocation of wb_process_queue by wb_writev as PQ1. Note w1 is not
unwound.
2. A dependent write (w2) hits write-behind and is unwound followed by
a flush (f1) request. Since the liability queue
of inode is not empty, w2 and f1 are not picked for unwinding. Let's call
the invocation of wb_process_queue by wb_flush as PQ2. Note that
invocation of wb_process_queue by w2 doesn't wind w2 instead
unwinds it after which we hit PQ2
3. PQ2 continues and picks w1 for fulfilling and invokes
wb_fulfill. As part of successful wb_fulfill_cbk,
wb_fulfill_request (w1) is invoked. But, w1 is not freed (and hence
not removed from wip queue) as w1 is not unwound _yet_ and a
ref remains (PQ1 has not invoked wb_do_unwinds _yet_).
4. wb_fulfill_cbk (triggered by PQ2) invokes a wb_process_queue (let's
say PQ3). w2 is not picked up for winding in PQ3 as w1 is still in wip
queue. At this time, PQ2 and PQ3 are complete.
5. PQ1 continues, unwinds w1 and does last unref on w1 and w1 is freed
(and removed from wip queue). Since PQ1 didn't invoke
wb_fulfill on any other write requests, there won't be any future
codepaths that would invoke wb_process_queue and w2 is stuck
forever. This will prevent f2 too and hence close syscall is hung
With this fix, w1 is removed from liability queue in step 3 above and
PQ3 winds w2 in step 4 (as there are no requests conflicting with w2
in liability queue during execution of PQ3). Once w2 is complete, f1
is resumed.
Change-Id: Ia972fad0858dc4abccdc1227cb4d880f85b3b89b
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1626787
commit abb7f279ba51715a9b7496b5e23da8b2731c6060
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Sep 10 15:07:43 2018 +0530
cli: Add warning message while converting to replica 2 configuration
Currently while creating replica 2 volume we display a warning message
of ending up in split-brain. But while converting an existing volume
from other configuration to replica 2 by add-brick or remove-brick
operations we do not show any such messages.
With this fix in add-brick and remove-brick cases also we will display
the same warning message and prompt for confirmation if the configuration
changes to replica 2.
Change-Id: Ifc4ed6994a087d2403894f4e743c4eb41633276b
fixes: bz#1627044
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit bdb49fac103503010ee1f58b82aa3ef6d3e816ee
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Sep 10 16:35:25 2018 +0530
mgmt/glusterd : Fix coverity issue
CID: 727146, 727066
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85393035&defectInstanceId=26034751&mergedDefectId=727146
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85392913&defectInstanceId=26034571&mergedDefectId=727066
updates: bz#789278
Change-Id: Ieaef33829ec88e68690dabce4ea21d2e61dad9f6
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 40599a195056f48515546485684087030f2b5b23
Author: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
Date: Mon Sep 10 11:01:38 2018 +0530
glusterd: NULL pointer dereferencing clang fix
Added ternary operator to avoid NULL pointer dereferencing
Updates: bz#1622665
Change-Id: I4b970176b6b555c2eda1da2848c493e45b1e4217
Signed-off-by: Sheetal Pamecha <sheetal.pamecha08@gmail.com>
commit 7c9f4e83930fbe5d0676254efd75bb1abda04aca
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Sep 7 14:00:59 2018 -0400
features/snapview-server: remove the ret variable
Used only once to store the return value of a function.
Change-Id: Ib2b9db847b5f652ce46f220297d9c7c3503eaea2
fixes: #230
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 9ccaed5cbd00c2235d9cd3e72b3547090e92166a
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 20 10:33:58 2018 +0530
doc: add details on how the commit should be structured
Detailing how the commit message should be is very important for imposing
some structure, and good practises. Also it helps new developers to do the
right things.
This is mostly copied from the OpenStack commit message reference, as it
was overlapping with most of the things we follow in GlusterFS. Made
minor changes to make it suitable for Gluster project.
Updates: bz#1193929
Change-Id: I4dcd7ff366edfc6c1727a287f32bcf7270c86b11
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 75cae9dc36174996f83ece87306e72d0e13e473e
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Sep 5 09:10:39 2018 +0530
rfc.sh: use 'git log -n1' instead of 'git show'
This is required mainly because if we use any format in a
documentation, and it has strings which are looking for commit
msg format (like fixes: bz...) in document, that too will be
considered in checks, even though it is not part of commit msg.
By using git log -n1, we would only check the content of commit
msg.
Updates: bz#1193929
Change-Id: I498590de6d3daa6be7bcbee1f083ef3fa6ecc96f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 027c1b4eefa33535f234a738be4eac86a00afd67
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Sep 7 14:10:37 2018 +0530
cluster/dht: Create a linkto file if required
Using the dht_filter_loc_subvol_key to create
files on specific subvols did not create a linkto
file. This can make the file inaccessible as
lookup-optimize is now enabled by default.
Change-Id: I78add5a31887378a479cb9c746b91678876b0dbe
fixes: bz#1626394
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit dcfe0ecc8e78f885ed1940a0c49aa9ded8e439e0
Author: Anoop C S <anoopcs@redhat.com>
Date: Fri Sep 7 13:50:47 2018 +0530
build: Make building of glupy more obvious
Yet again glupy..!!
Core changes:
* Provide --disable-glupy(instead of --enable-glupy) since we try to
build it by default.
* AC_SUBST macro is considered/executed even if it is inside an if
condition. As a result GLUPY_SUBDIR was always substituted which in
turn would make compilation enter glupy/ translator sources in absence
of python{2/3}-devel and fails.
Miscellaneous changes:
* Remove an explicit echo for printing PYTHON version.
* Replace hard coded python version in warning message displayed in
absence of python{2/3}-devel.
* Redirect pushd and popd output to /dev/null
Change-Id: If1ba30a12a8bda5763ef528787fccb2f7946b136
Updates: bz#1193929
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 7268e0af76f9832bbdf97f956f65f2038fd43757
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 10 11:38:26 2018 +0530
posix: fix the duplicate macro definitions
the macro 'PATH_SET_TIMESPEC_OR_TIMEVAL' is defined in posix.h,
which seems to be good place for it
updates: bz#1193929
Change-Id: I521a2a6efeb26891c24637a5f06b1d90c00b1135
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 674d40182238c11f6b2a27eacbfde5ed91911067
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Jul 27 15:19:46 2018 +0530
cluster/dht: optimize readdir for 1xn vols
Skip the hashed subvol check for volumes with
distribute count of 1.
Change-Id: I5703508b54a17c49a217c8a8e09884980705953a
fixes: bz#1608175
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 09fad1f4adaa299e410404d9ce084824e5d44525
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 10 11:14:09 2018 +0530
ec-heal: remove a duplicate definition of alloca0
the same macro is defined in common-utils.h, which seems to be
much better place for the same.
Updates: bz#1193929
Change-Id: I409b719c291102136500b955e5827a550142ed96
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit e44a1b8c5cbb748584bacf1c82f15e982c453e7c
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 23:36:51 2018 +0300
xlators/cluster/dht/src/tier-common.c:move to GF_MALLOC() instead of GF_CALLOC() when
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
Change-Id: I7d38a7d576f6777976fe86e5351a8d95caddbb9c
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 62e8877b2988d1d4c0e68c4b7f01c059f2ed6da4
Author: Omar Kohl <omarkohl@gmail.com>
Date: Thu Sep 6 13:57:33 2018 +0200
Modify log message 'DH ciphers are disabled' from ERROR to INFO
Per the latest comment in bz#1398237 this message is confusing for users
because it suggests an error where none exists.
Fixes: bz#1626319
Change-Id: I2f05999da157b11e225bf3d95edb597e964f9923
Signed-off-by: Omar Kohl <omarkohl@gmail.com>
commit 78ad7ced333642c726ab141814132289c910dbd8
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sun Sep 9 22:54:08 2018 +0530
glusterd: Fix unused value coverity fix
Commit 09198e203e has introduced a new coverity with ID 1395635.
keylen variable is assigned to some value but stored value is
overwritten before it is used. This patch addresses the issue.
updates: bz#789278
Change-Id: Ice290dcb9d703cd2131b0f0803436660e670e10a
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 05e731d92ae218b6475729cf587bb50fea1d734d
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Sep 3 13:55:01 2018 +0300
Some (mgmt) xlators: use dict_{setn|getn|deln|get_int32n|set_int32n|set_strn}
In a previous patch (https://review.gluster.org/20769) we've
added the key length to be passed to dict_* funcs, to remove the need
to strlen() it. This patch moves some xlators to use it.
- It also adds dict_get_int32n which was missing.
- It also reduces the size of some key variables.
They were set to 1024b or PATH_MAX, where sometimes 64 bytes were
really enough.
Please review carefully:
1. That I did not reduce some the size of the key variables too much.
2. That I did not mix up some keys.
Compile-tested only!
Change-Id: Ic729baf179f40e8d02bc2350491d4bb9b6934266
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 015a629ac2eefaa34a2fb168634fb62787bebbbb
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Sep 3 16:26:56 2018 +0530
glusterd: avoid using glusterd's working directory as a brick
Adding checks for avoiding glusterd's working directory used as
a brick for volume creation.
fixes: bz#853601
Change-Id: I4b16a05f752e92216aa628f542a4fdbf59b3c669
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 96ac56c1e9ab6853f2eb19dd381535dd83c291db
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 20:41:20 2018 +0300
multiple xlators (mgmt): strncpy()->sprintf(), reduce strlen()'s
xlators/mgmt/glusterd/src/glusterd-geo-rep.c
xlators/mgmt/glusterd/src/glusterd-handshake.c
xlators/mgmt/glusterd/src/glusterd-sm.c
xlators/mgmt/glusterd/src/glusterd-store.c
xlators/mgmt/glusterd/src/glusterd-utils.c
xlators/mgmt/glusterd/src/glusterd-volgen.c
xlators/mgmt/glusterd/src/glusterd-volume-ops.c
xlators/mgmt/glusterd/src/glusterd.c
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf(). Try to ensure output is not
truncated.
Also:
- save the result of strlen() and re-use it when possible.
- move from strlen to SLEN (sizeof() ) for const strings.
Compile-tested only!
Change-Id: Ib5d001857236f43e41c4a51b5f48e1a33110aaeb
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit d75723c53dc887c7d52e3524720bd743908d0c0e
Author: Shwetha K Acharya <sacharya@redhat.com>
Date: Fri Sep 7 11:20:49 2018 +0530
glusterd-sm: NULL pointer dereferencing clang fix
Problem: new_event could be NULL.
Solution: Added a goto statement to address this issue.
Updates: bz#1193929
Change-Id: Id3ce28fc53ad2cc8b9fcb63f7774568d31073b9e
Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
commit c84473880a2222b25bbcde9439dd9d6844900ddd
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Aug 31 12:25:32 2018 +0530
cluster/dht: Rework the debug xattr to get hashed subvol
The earlier implementation required the file to already exist
when trying to get the hashed subvol. The reworked implementation
allows a user to get the hashed subvol for any filename, whether
it exists or not.
Usage: getfattr -n "dht.file.hashed-subvol.<filename>" <parent dir>
Eg:To get the hashed subvol for file-1 inside dir-1
getfattr -n "dht.file.hashed-subvol.file-1" /mnt/gluster/dir1
credit: rgowdapp@redhat.com
Change-Id: Iae20bd5f56d387ef48c1c0a4ffa9f692866bf739
fixes: bz#1624244
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 8940a39aec99902f059931bc85d6902d31a86f17
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Sep 6 11:20:32 2018 +0530
cluster/ec: Don't update trusted.ec.version if fop succeeds
If a fop has succeeded on all the bricks and trying to release
the lock, there is no need to update the version for the
file/entry. All it will do is to increase the version from
x to x+1 on all the bricks.
If this update (x to x+1) fails on some brick, this will indicate
that the entry is unhealthy while in realty everything is fine
with the entry.
Avoiding this update will help to not to send one xattrop
at the end of the fops. Which will decrease the chances
of entries being in unhealthy state and also improve the
performance.
Change-Id: Id9fca6bd2991425db6ed7d1f36af27027accb636
fixes: bz#1623759
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit a3285ce4bc3d1d95077d534c7e8f16fafa515733
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Sep 3 14:01:23 2018 +0530
cluster/ec: Improve logging for some critical error messages
Change-Id: I037e52a3467467b81a1ba5416317870864060d4d
updates: bz#1615703
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 9946b663de28eb50afbb320f9d69bb953008737a
Author: sanoj-unnikrishnan <sunnikri@redhat.com>
Date: Wed Aug 29 14:45:50 2018 +0530
Quota: Fix for clang issues
Updates: bz#1193929
Change-Id: I549f741fbf97ee3fa2d63edacee5b705ef37c49a
Signed-off-by: sanoj-unnikrishnan <sunnikri@redhat.com>
commit fd19f240fb8d3b28446a57b284698dd84062b678
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 23:36:28 2018 +0300
xlators/cluster/dht/src/dht-common.c :move to GF_MALLOC() instead of GF_CALLOC() when
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
Please review carefully, especially for string allocation, with the
terminating NULL string (added another byte to ensure it's there).
Only compile-tested!
Change-Id: Ia5e4f50dfb0c29809c2019fcfd8079507813249e
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 0ad49e12a94af055fc682274f6ee38e921ab497a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Aug 8 21:41:21 2018 +0300
glusterfsd/src/glusterfsd.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
In some cases, also changed allocation size to be sizeof some
struct or type instead of a pointer - easier to read.
In some cases, removed redundant strlen() calls by saving the result
into a variable.
1. Only done for the straightforward cases. There's room for improvement.
2. Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Iaed86fcc909022c5158c3e08a9106b1110b9df0a
commit 3b355fd2f0e2cd32f4cad548276b3213df3d5733
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 20:39:16 2018 +0300
multiple xlators: strncpy()->sprintf(), reduce strlen()'s
xlators/cluster/afr/src/afr-common.c
xlators/cluster/dht/src/dht-common.c
xlators/cluster/dht/src/dht-rebalance.c
xlators/cluster/stripe/src/stripe-helpers.c
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf().
Also:
- save the result of strlen() and re-use it when possible.
- move from strlen to SLEN (sizeof() ) for const strings.
Compile-tested only!
Change-Id: Icdf79dd3d9f9ff120e4720ff2b8bd016df575c38
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 734dfb10f1147c16ceb7b522c09efab46478afaf
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Sep 5 04:30:35 2018 -0400
multiple: Fix python2 to python3 compat
Change-Id: Iac241166d7a35dc7cc6cf07850f9f1bce38fe207
Updates: #411
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit e0615ae7f6a6c3df5b48f3b5445378fff571080c
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 30 10:54:54 2018 +0300
libglusterfs/src/dict.c: remove memcpy(), gf_asprintf -> asprintf
1. We don't need a temp. string to strotol(), we can use data->data.
2. We don't need the gf_asprintf, when a regular asprintf would do.
3. No need to CALLOC the data, can MALLOC, since
we are going to populate most of the fields anyway.
4. Removed is_const member - it was not used.
5. Turned is_static to a gf_boolean_t
6. Turned another get_mem0 to get_mem (in dict_set_lk() func)
7. Remove dict_set_ptr - was exactly the same as dict_set_static_ptr
(apart from the 'static' bit) and no one was using it.
8. Removed is_static from the dictionary object. Did not seem to be
very useful.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I7b1f6320867b154be4a94033819407f7e51cf38c
commit 7d4c9a79a7d0b3f8fa15c24baf11669e9e126aa9
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:18:31 2018 +0300
xlators/mgmt/glusterd/src/glusterd-log-ops.c : reduce size or re-scope message variable
The the error and/or message variable was either:
- Reduced in size - from 2048 bytes to 64 bytes, for example.
or
- Changed in scope - defined in a smaller scope.
Compile-tested only!
Change-Id: Ib8617db6c3646954c0225d12b904d668bf0f7046
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 1aa2d0249011038e104521b772ee97c3dc0f4613
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Sep 5 19:03:08 2018 +0530
posix: disable open/read/write on special files
In the file system, the responsibility w.r.to the block and char device
files is related to only support for 'creating' them (using mknod(2)).
Once the device files are created, the read/write syscalls for the specific
devices are handled by the device driver registered for the specific major
number, and depending on the minor number, it knows where to read from.
Hence, we are at risk of reading contents from devices which are handled
by the host kernel on server nodes.
By disabling open/read/write on the device file, we would be safe with
the bypass one can achieve from client side (using gfapi)
Fixes: bz#1625096
Change-Id: I48c776b0af1cbd2a5240862826d3d8918601e47f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7a149636649518e0abf198682c3c0447e9917dd3
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Sep 5 18:16:37 2018 +0530
cluster/dht: Initialise pointers to null
Use calloc in dht_layouts_init so to as to
prevent dht_init from attempting to free
invalid memory in case of failure.
There are other ways to do this (set first failure
to null and break there when cleaning up) but
I prefer having all pointers initialized to null.
This is a one time operation so it should not be
too expensive.
Change-Id: Ie22246047448f1cae971d48fa5aaf2efcaeb42c0
fixes: bz#1625643
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 86ec9b118bb2cf7dc2b06d2a9a77aa71ea97e82f
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Aug 8 21:42:45 2018 +0300
cli/src/cli-cmd-parser.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
In some cases, also changed allocation size to be sizeof some
struct or type instead of a pointer - easier to read.
In some cases, removed redundant strlen() calls by saving the result
into a variable.
1. Only done for the straightforward cases. There's room for improvement.
2. Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ic1531afbf614823628cc8d70bae782d4db7ec033
commit 15b0c9149ef60e087c603c7324b4e523518056ba
Author: Raghavendra Manjunath <raghavendr@redhat.com>
Date: Thu Aug 23 22:24:25 2018 -0400
features/uss: Use xxh64 to generate gfid instead of md5sum
* This is to ensure FIPS support
* Also changed the signature of svs_uuid_generate to
get xlator argument
* Added xxh64 wrapper functions in common-utils to
generate gfid using xxh64
- Those wrapper functions can be used by other xlators
as well to generate gfids using xxh64. But as of now
snapview-server is going to be the only consumer.
Change-Id: Ide66573125dd74122430cccc4c4dc2a376d642a2
Updates: #230
Signed-off-by: Raghavendra Manjunath <raghavendra@redhat.com>
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit ef72fd5f5d58da1e63cd815d6790b02c3076ff18
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jul 24 15:42:28 2018 +0530
io-stats: dump io-stats info in /var/run/gluster
It wouldn't make sense to allow iostats file to be written in
*any* directory. While the formating makes sure we try to append
io-stats-name for the file, so overwriting existing file is slim,
but in any case it makes sense to restrict dumping to one directory.
Below are the sample commands, and files created for the corresponding
values:
$ setfattr -n trusted.io-stats-dump -v file-for-dump $M0
In this case, the file would be in /var/run/gluster/file-for-dump
$ setfattr -n trusted.io-stats-dump -v /dir1/dir2/file-for-dump $M0
In this case, then the dump file is in /var/run/gluster/dir1-dir2-file-for-dump
Note that the value passed for this virtual xattr would be treated as a
file, and even if the value has '/' in it, it would be changed to '-'
for sanity.
Fixes: bz#1625106
Change-Id: Id9ae6a40a190b8937c51662e6e1c2a0f6c86a0e0
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit e41deaba2ab67e12e6ad7e9e50ede98e85cb5207
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jul 24 13:56:56 2018 +0530
protocol: don't use alloca
current implementation of alloca can cause issues when strings larger
than the allocated buffer is passed to the xdr. Hence it makes sense
to allow XDR decode functions to deal with memory allocations, which
we can free later.
Fixes: bz#1625097
Change-Id: I3a05553f5702de9575c244649ca0e5ac9abaac94
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 708d113a8a1e0ba94be8d418cdd231060a436072
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Aug 9 13:00:01 2018 +0530
server-protocol: don't allow '../' path in 'name'
This will prevent any arbitrary file creation through glusterfs
by modifying the client bits.
Also check for the similar flaw inside posix too, so we prevent any
changes in layers in-between.
Fixes: bz#1625095
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Change-Id: Id9fe0ef6e86459e8ed85ab947d977f058c5ae06e
commit 17682a12785613dd6b7b586ebf204c9e7e4bcb17
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jul 24 13:25:12 2018 +0530
dict: handle negative key/value length while unserialize
Fixes: bz#1625089
Change-Id: Ie56df0da46c242846a1ba51ccb9e011af118b119
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit bacb682a12a045d5bf47da979fbb463fb6d5921c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Aug 31 10:32:20 2018 +0530
afr: thin-arbiter read txn changes
If both data bricks are up, read subvol will be based on read_subvols.
If only one data brick is up:
- First qeury the data-brick that is up. If it blames the other brick,
allow the reads.
- If if doesn't, query the TA to obtain the source of truth.
TODO: See if in-memory state can be maintained for read txns (BZ 1624358).
updates: bz#1579788
Change-Id: I61eec35592af3a1aaf9f90846d9a358b2e4b2fcc
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 4307f961c92b84d9bc8a13fcecc8b503cea00787
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Aug 17 09:38:39 2018 +0530
New flag to glusterfsd binary to print libexec dir
New CLI option for `glusterfsd` binary to get the path of
libexec directory. This helps glusterd2 to detect the
installed path of `gsyncd` and other binaries.
Usage: `glusterfsd --print-libexecdir`
Updates: bz#1193929
Change-Id: I8c1a74afd9acec7ee7bd3deabed9d9f20fe3fb5f
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit d13eec5737e917080c651215aad0d16bf51be632
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Aug 30 16:09:04 2018 +0530
cli : fix coverity issue in cli-cmd-parser.c
This patch fixes 1175017 and 1382401.
This patch fixes resource leak by validating brick_count is valid or
not. If brick_count is not valid we are coming out in "cli_cmd_bricks_parse"
without allocating memory to "brick_str" which is eventually pointed by bricks.
Change-Id: I8ed0f29495379ec49484c5c4069865db3653506f
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 4bfc2852f19ce36eac68625358a97ca21f532de1
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Sep 4 21:05:11 2018 +0530
core: switch to python3
Commit af0d5a9b5375a5cd87ac10b429e2b9934718ce5b changes
python2 -> python3. This patch fixes a small issue introduced
by it.
Change-Id: Ib23c73683f570e8891f41476b661f37c89635fb5
updates: #411
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 5ffd11f032b32c63abf9b88f07f869387f4d756b
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Sep 4 14:13:18 2018 +0530
glusterd : fix some coverity issues in glusterd-store.c
This patch fixes CID 1382346, 1274190 and 1382403.
Change-Id: I1968e686587719e74bd70fa1542c20bccc04a7f9
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit fc4666204cbdecd118e2820ce44c7adb2a344ef0
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Aug 29 00:18:32 2018 +0530
glusterd: Fix Buffer size issues
This patch fixes buffer size issue 1138522.
Change-Id: Ia12fc8f34f75704f8ed3efae2022c4fd67a8c76c
updates: bz#789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 7e6a9a3fe1b2dd1e105a1f3cd76a07ce8fc59e25
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jul 24 17:14:31 2018 +0530
posix: remove not supported get/set content
getting and setting a file's content using extended
attribute worked great as a GET/PUT alternative when
an object storage is supported on top of Gluster. But
it needs application changes, and also, it skips some
caching layers. It is not used over years, and not
supported any more. Remove the dead code.
Fixes: bz#1625102
Change-Id: Ide3b3f1f644f6ca58558bbe45561f346f96b95b7
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 954bd6e9dba26ad72e064f52cbb131b8bbe7b8d9
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 27 23:50:05 2018 +0530
xlators: add classification flag to some
Add classification to those translators which has `xlator_api_t`
already defined and used.
Updates: #430
Change-Id: I9d2772cb2c4ed4ab06aaa546500cf3b7d00bddac
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit f3b6d4a78e760f1d48863cb10fba005ec90c4f18
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 27 23:11:51 2018 +0530
classification: provide infra to start labelling features/components
`doc/xlator-classification.md` talks about the reasoning and expectations
Reviewers are expected to check the 'category' of new
option / translator added in the codebase, and make sure the flag
is always properly set. It helps to keep the 'expectation' proper
on the codebase.
updates: #430
Change-Id: I2bfc9934a5f6eed77fcc3e20364046242decc82c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 3b39db2ffa106160709422a8eb0b5dc081bcef63
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Sep 3 11:35:31 2018 +0530
IO cache : fix coverity issue in page.c
This patch fixes CID 1382439 and 1382412.
Change-Id: I8696623c168ba76ae2ecac7c9582b4e50437bc53
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit a0a4060b942a0bd7f2ca1ef5eebdbe52995cd471
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Aug 19 08:08:23 2018 +0300
{dht-rebalance|glusterd-geo-rep|glusterd-utils|nfs|bd}.c: no dict_del before dict_set
There is no need to remove an item before re-setting it.
Compile-tested only!
Change-Id: I2869aec9ebf474859127b8b38d284246e6097e84
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 95a929a3161bc28ca007767f648d491d21213940
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Aug 8 21:36:28 2018 +0300
multiple files: calloc -> malloc
xlators/cluster/stripe/src/stripe-helpers.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
xlators/cluster/dht/src/tier.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
xlators/cluster/dht/src/dht-layout.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
xlators/cluster/dht/src/dht-helper.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
xlators/cluster/dht/src/dht-common.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
xlators/cluster/afr/src/afr.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
xlators/cluster/afr/src/afr-inode-read.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
tests/bugs/replicate/bug-1250170-fsync.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
tests/basic/gfapi/gfapi-async-calls-test.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
tests/basic/ec/ec-fast-fgetxattr.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
rpc/xdr/src/glusterfs3.h: Move to GF_MALLOC() instead of GF_CALLOC() when possible
rpc/rpc-transport/socket/src/socket.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
rpc/rpc-lib/src/rpc-clnt.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
extras/geo-rep/gsync-sync-gfid.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
cli/src/cli-xml-output.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
cli/src/cli-rpc-ops.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
cli/src/cli-cmd-volume.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
cli/src/cli-cmd-system.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
cli/src/cli-cmd-snapshot.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
cli/src/cli-cmd-peer.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
cli/src/cli-cmd-global.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
In some cases, also changed allocation size to be sizeof some
struct or type instead of a pointer - easier to read.
In some cases, removed redundant strlen() calls by saving the result
into a variable.
1. Only done for the straightforward cases. There's room for improvement.
2. Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
updates: bz#1193929
Original-Author: Yaniv Kaul <ykaul@redhat.com>
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Change-Id: I16274dca4078a1d06ae09a0daf027d734b631ac2
commit 4fafd45f4b61d0d33f3b6f12a72b4c6b00f0d594
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sat Aug 4 09:51:26 2018 +0300
Multiple files: calloc -> malloc
xlators/storage/posix/src/posix-inode-fd-ops.c:
xlators/storage/posix/src/posix-helpers.c:
xlators/storage/bd/src/bd.c:
xlators/protocol/client/src/client-lk.c:
xlators/performance/quick-read/src/quick-read.c:
xlators/performance/io-cache/src/page.c
xlators/nfs/server/src/nfs3-helpers.c
xlators/nfs/server/src/nfs-fops.c
xlators/nfs/server/src/mount3udp_svc.c
xlators/nfs/server/src/mount3.c
xlators/mount/fuse/src/fuse-helpers.c
xlators/mount/fuse/src/fuse-bridge.c
xlators/mgmt/glusterd/src/glusterd-utils.c
xlators/mgmt/glusterd/src/glusterd-syncop.h
xlators/mgmt/glusterd/src/glusterd-snapshot.c
xlators/mgmt/glusterd/src/glusterd-rpc-ops.c
xlators/mgmt/glusterd/src/glusterd-replace-brick.c
xlators/mgmt/glusterd/src/glusterd-op-sm.c
xlators/mgmt/glusterd/src/glusterd-mgmt.c
xlators/meta/src/subvolumes-dir.c
xlators/meta/src/graph-dir.c
xlators/features/trash/src/trash.c
xlators/features/shard/src/shard.h
xlators/features/shard/src/shard.c
xlators/features/marker/src/marker-quota.c
xlators/features/locks/src/common.c
xlators/features/leases/src/leases-internal.c
xlators/features/gfid-access/src/gfid-access.c
xlators/features/cloudsync/src/cloudsync-plugins/src/cloudsyncs3/src/libcloudsyncs3.c
xlators/features/bit-rot/src/bitd/bit-rot.c
xlators/features/bit-rot/src/bitd/bit-rot-scrub.c
bxlators/encryption/crypt/src/metadata.c
xlators/encryption/crypt/src/crypt.c
xlators/performance/md-cache/src/md-cache.c:
Move to GF_MALLOC() instead of GF_CALLOC() when possible
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
In some cases, also changed allocation size to be sizeof some
struct or type instead of a pointer - easier to read.
In some cases, removed redundant strlen() calls by saving the result
into a variable.
1. Only done for the straightforward cases. There's room for improvement.
2. Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
.. and allocate memory as much as needed.
xlators/nfs/server/src/mount3.c :
Don't blindly allocate PATH_MAX, but strlen() the string and allocate
appropriately.
Also, align error messges.
updates: bz#1193929
Original-Author: Yaniv Kaul <ykaul@redhat.com>
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ibda6f33dd180b7f7694f20a12af1e9576fe197f5
commit 01819c8e3c73fe883513d68a0c45c58b7da0af68
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Aug 7 23:57:28 2018 +0530
geo-rep : fix coverity issues in glusterd-geo-rep.c
This patch fixes RESOURCE_LEAK at line number 1344, 2088, 4819, 1347,
2092, 1608, 1612, 2284, 3837.
It also fixes FORWARD_NULL at line number 2955.
CID : 1175012, 1175014, 1210989, 1223042, 1223043, 1382381, 1382429,
1389120, 1389474, 1390452, 1356512.
Change-Id: I7de239944eb61073d208ecf3899999a1ea0c8e43
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 3b81a8b11cce07602cfccb988424f5b45f5b7d91
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 23:35:58 2018 +0300
xlators/cluster/afr/src/afr-inode-read.c: move to GF_MALLOC() instead of GF_CALLOC() when
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
Change-Id: Ief156de98769fea852553044a398a309e831754b
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit ae201131af437caf75a35417fd1aec69d2be5bd8
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Aug 31 20:42:21 2018 +0530
glusterd: fail volume stop operation if brick detach fails
While sending a detach request for a brick in brick multiplexing mode,
in any situation if the brick isn't connected, glusterd will fail to
detach the brick but due to the missing error code handling, glusterd
will mark the volume as stopped.
Fix is to handle the return code of send_attach_req in
glusterd_volume_stop_glusterfs ()
Change-Id: I886202969c96eec3620f74cd7027652d6287f4be
Fixes: bz#1624440
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 0da9b8b487b00772ad5134e4744a5a2c96978d47
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Aug 27 12:40:16 2018 +0530
cluster/afr: Delegate name-heal when possible
Problem:
When name-self-heal is triggered on the mount, it blocks
lookup until name-self-heal completes. But that can lead
to hangs when lot of clients are accessing a directory which
needs name heal and all of them trigger heals waiting
for other clients to complete heal.
Fix:
When a name-heal is needed but quorum number of names have the
file and pending xattrs exist on the parent, then better to
delegate the heal to SHD which will be completed as part of
entry-heal of the parent directory. We could also do the same
for quorum-number of names not present but we don't have
any known use-case where this is a frequent occurrence so
not changing that part at the moment. When there is a gfid
mismatch or missing gfid it is important to complete the heal
so that next rename doesn't assume everything is fine and
perform a rename etc
fixes bz#1622821
Change-Id: I8b002c85dffc6eb6f2833e742684a233daefeb2c
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit e7ff03896839a5f69457570756fc0b3a8f5ef04b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Aug 29 11:09:27 2018 -0400
core: python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/,
https://review.gluster.org/#/c/19952/,
https://review.gluster.org/#/c/20104/,
https://review.gluster.org/#/c/20162/,
https://review.gluster.org/#/c/20185/,
https://review.gluster.org/#/c/20207/,
https://review.gluster.org/#/c/20227/,
https://review.gluster.org/#/c/20307/,
https://review.gluster.org/#/c/20320/,
https://review.gluster.org/#/c/20332/,
https://review.gluster.org/#/c/20364/,
https://review.gluster.org/#/c/20441/, and
https://review.gluster.org/#/c/20484
shebangs changed from /usr/bin/python2 to /usr/bin/python3.
(Reminder, various distribution packaging guidelines require use
of explicit python version and don't allow '#!/usr/bin/env python',
regardless of how handy that idiom may be.)
glusterfs.spec(.in) package python{2,3}-gluster and python2 or
python3 dependencies as appropriate.
configure(.ac):
+ test for and use python2 or python3 as appropriate. If build
machine has python2 and python3, use python3. Override by
setting PYTHON=/usr/bin/python2 when running configure.
+ PYTHONDEV_CPPFLAGS from python[23]-config --includes is a
better match to the original python sysconfig.get_python_inc().
All those other extraneous flags breaks the build.
+ Only change the shebangs once. Changing them over and over
again, e.g., during a `make glusterrpms` in extras/LinuxRPM
just sends make (is it really make that's looping?) into an
infinite loop. If you figure out why, let me know.
+ Oldest python2 is python2.6 on CentOS 6 and Debian 8 (Jessie).
Everything else has 2.7 or 3.x
+ logic from https://review.gluster.org/c/glusterfs/+/21050, which
needs to be removed/merged after that patch is merged.
Builds on CentOS 6, CentOS 7, Fedora 28, Fedora rawhide, and the
mysterious RHEL > 7.
Change-Id: Idae21d3b6f58b32372e1daa0d234e491e563198f
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit f5ff75c7b67d7b2d9c9ac2446c3087ff7a16297a
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Aug 28 12:00:33 2018 +0530
cluster/dht: In rename, unlink after creating linkto file
The linkto file creation for the dst was done in parallel with
the unlink of the old src linkto. If these operations reached
the brick out of order, we end up with a dst linkto file without
a .glusterfs handle.
Fixed by the unlinking only after the linkto file creation has
completed.
Change-Id: I4246f7655f5bc180f5ded7fd34d263b7828a8110
fixes: bz#1621981
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit aa9cea8ce1ee273e5ab846e8225edf00ef77f562
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Aug 21 06:09:44 2018 -0400
libgfchangelog: Fix changelog history API
Problem:
If requested start time and end time doesn't fall into
first HTIME file, then history API fails even though
continuous changelogs are avaiable for the requested range
in other HTIME files. This is induced by changelog disable
and enable which creates fresh HTIME index file.
Cause and Analysis:
Each HTIME index file represents the availability of
continuous changelogs. If changelog is disabled and enabled,
a new HTIME index file is created represents non availability
of continuous changelogs. So as long as the requested start
and end falls into single HTIME index file and not across,
history API should succeed.
But History API checks for the changelogs only in first
HTIME index file and errors out if not available.
Fix:
Check in all HTIME index files for availability of continuous
changelogs for requested change.
fixes: bz#1622549
Change-Id: I80eeceb5afbd1b89f86a9dc4c320e161907d3559
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit ef775808fb10ce8344f6bd2eb0877adeb52ce6b6
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 20:43:07 2018 +0300
Various files: strncpy()->sprintf(), reduce strlen()'s
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf(). Check for truncated output
where applicable.
Also:
- save the result of strlen() and re-use it when possible.
- move from strlen to SLEN (sizeof() ) for const strings.
Compile-tested only!
Change-Id: I54e80d4f4a80e98d3775e376efe05c51af0b29eb
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit ae10538f6d9b4b76f2b97d1db428e6e022f70c2b
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Aug 30 15:08:02 2018 +0530
cluster/ec: Fix Coverity issue
Fix following coverity issues-
CID:
1382378
1382459
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85091670&defectInstanceId=25915064&mergedDefectId=1382459
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85091670&defectInstanceId=25915063&mergedDefectId=1382378
Problem:
ASSERT_LOCAL(this, healer) function is supposed to get the local healer
so that we can take advantage of it while healing and reading data.
However, we are not using healer->local anywhere.
Also, this is not as useful in context of EC as it is in AFR.
In EC we have to raed fragments from 4 bricks to heal a bad
fragment on other brick.
Change-Id: Iea8ce127ea02cc84e3823cb2be82a47872217b33
updates: bz#789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 9ab4ac871fa2b873f265fe475abf90247357ecf8
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Jul 27 14:53:30 2018 +0530
thin arbiter: set notify-contention option to yes
If this option is "ON' and if there is a lock contention for
a file from 2 clients/self-heal daemon, an up call will
be sent to all the clients holding that locks. Clients
can handle this notification and may release the locks
at the right time asap.
If this option is ON, we get "instant" lock contention
notification on client side.
In next version of thin arbiter, we need to implement
lock contention notification handling and two domain
locking to synchronize update/access of xattrs of thin arbiter
replica id file. This option is an efficient way to find
out lock contention. In this case it is also helping to
implement two domain locking for replica id file.
Change-Id: I69883898d52feb425dfceb31cf12fa2157aaa314
fixes bz#1609207
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 93a41293a710fa3b7bbdfe7d293ec6fd1eb07cd3
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 20:29:17 2018 +0300
NFS server (mount3.c, nfs-inodes.c): strncpy()->sprintf(), reduce strlen()'s
xlators/nfs/server/src/mount3.c
xlators/nfs/server/src/nfs-inodes.c
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf().
Compile-tested only!
Change-Id: Ibe74ccdb67434e9a10fc1f21c0b4cd5e4b8cb589
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit bc53b1c8e7946c90471643ce3d258f03b5fa0035
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 19:25:11 2018 +0300
changetimerecoder xlator: strncpy()->sprintf(), reduce strlen()'s
xlators/features/changetimerecorder/src/changetimerecorder.c
xlators/features/changetimerecorder/src/ctr-helper.h
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf(). Check for output truncation
where applicable.
Also:
- save the result of strlen() and re-use it when possible.
- move from strlen to SLEN (sizeof() ) for const strings.
Compile-tested only!
Change-Id: I2dd5629183222da8c9251af43b8b29aacf12a20a
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 141b229272def2a2dffd36f1b87135dfb049e4a6
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 20:42:53 2018 +0300
multiple xlators (storage/posix): strncpy()->sprintf(), reduce strlen()'s
xlators/storage/posix/src/posix-gfid-path.c
xlators/storage/posix/src/posix-handle.c
xlators/storage/posix/src/posix-helpers.c
xlators/storage/posix/src/posix-inode-fd-ops.c
xlators/storage/posix/src/posix.h
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf().
Also:
- save the result of strlen() and re-use it when possible.
- move from strlen to SLEN (sizeof() ) for const strings.
Compile-tested only!
Change-Id: I056939f111a4ec6bc8ebd539ebcaf9eb67da6c95
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 01667aa65b22814e2b26a7d5d1326c69d7b03e86
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 19:23:01 2018 +0300
changelog xlator: strncpy()->sprintf(), reduce strlen()'s
xlators/features/changelog/lib/src/gf-changelog-journal-handler.c
xlators/features/changelog/lib/src/gf-changelog.c
xlators/features/changelog/src/changelog-helpers.c
xlators/features/changelog/src/changelog-misc.h
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf(). Where possible, ensure there's
no truncation of the output.
Also:
- save the result of strlen() and re-use it when possible.
- move from strlen to SLEN (sizeof() ) for const strings.
- switch a strncpy to a memcpy.
Compile-tested only!
Change-Id: Ia7a52bce0b243613ad910192ec163c93d944e077
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 027f3270cdc0d8d7ad562608de941c2462fc27a9
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 20:32:01 2018 +0300
multiple xlators: move from strlen() to sizeof()
xlators/performance/nl-cache/src/nl-cache.c
xlators/performance/md-cache/src/md-cache.c
xlators/protocol/server/src/authenticate.c
xlators/storage/bd/src/bd-helper.c
For const strings, just do compile time size calc instead of runtime.
Compile-tested only!
Change-Id: I9b98940a38d85321a69436a1871930da367b918a
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 2f2330b4b3848b8b3333383aea4c7f1da3d5bba6
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 19:33:16 2018 +0300
xlators: move from strlen() to sizeof()
xlators/features/index/src/index.c
xlators/features/shard/src/shard.c
xlators/features/upcall/src/upcall-internal.c
xlators/mgmt/glusterd/src/glusterd-bitrot.c
xlators/mgmt/glusterd/src/glusterd-locks.c
xlators/mgmt/glusterd/src/glusterd-mountbroker.c
xlators/mgmt/glusterd/src/glusterd-op-sm.c
For const strings, just do compile time size calc instead of runtime.
Compile-tested only!
Change-Id: I995b2b89f14454b3855a4cd0ca90b3f01d5e080f
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 2b452f93db23f0d2170119e4190a2f5e5550cc03
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Aug 30 17:32:55 2018 +0530
crypt : fix coverity issues in crypt.c
This patch fixes CID 1356527, 1356528, 1356529, 1356530, 1395251.
Change-Id: Ibdbc56a3221bff3535f02a9e73b57fcbe35c3fbd
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 5e8106a64343a927eea6d877d1ac76cc582f2454
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 19:20:25 2018 +0300
bit-rot xlator: strncpy()->sprintf(), reduce strlen()'s
xlators/features/bit-rot/src/bitd/bit-rot-scrub-status.c
xlators/features/bit-rot/src/stub/bit-rot-stub-helpers.c
xlators/features/bit-rot/src/stub/bit-rot-stub.c
xlators/features/bit-rot/src/stub/bit-rot-stub.h
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf(). Ensure sprintf() results do not
truncate.
Also:
- save the result of strlen() and re-use it when possible.
- move from strlen to SLEN or sizeof() for const strings.
- move ret from int32 to int.
Compile-tested only!
Change-Id: Ib9b923c45d2d59ac15a105410e8160b252061018
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 3c872783f160fdc52be4d94ff8cefbf14151696f
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Aug 13 12:18:51 2018 +0530
libglusterfs : fix coverity issues in common-utils.c
Fixes CID 1351691, 1351678, 1274192, 1274117, 1124845.
Change-Id: I65805524de85fb2186260288641390458a719499
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit cd1f2c2af011cce63611925534cb1ea7c805d008
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Aug 27 21:25:47 2018 +0300
xlators/cluster/dht/src/dht-common.c: simplify some if statements
Use goto when some vars are not set to simplify long if statements.
Please review logic has not changed!
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I45ea2e906d0ccb468af5e1fa65db008edb00d734
commit 25c5e750ced566c850e8325007a0e234011d259a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Aug 27 23:45:15 2018 +0300
libglusterfs/src/dict.c: fix to handle key=NULL.
We don't want to strlen NULL strings.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Id795998693ba410dbd80df962d48956a9e4164c4
commit 9ad8bee4310fb8d12e233fdfa16d2ddac3e48fe6
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Aug 28 00:01:26 2018 +0530
clang-scan: fix multiple issues
* Buffer overflow issue in glusterfsd
* Null argument passed to function expecting non-null (event-epoll)
* Make sure the op_ret value is set in macro (posix)
Updates: bz#1622665
Change-Id: I32b378fc40a5e3ee800c0dfbc13335d44c9db9ac
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 3f363c44d2f952ad98e672bbe0260010d87e4138
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Aug 27 18:19:58 2018 +0530
coverity: multiple fixes
CID: 1390477, 1124827
updates: bz#789278
Change-Id: I41060d131aec6e58e7267ac8531b29a70f8c4359
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 218614259c0a351fb59666b4239f0d9661eb8716
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Aug 30 16:31:39 2018 +0530
cli : fix coverity issue in cli-cmd-volume.c
This patch fixes 1389756.
Change-Id: I72d4f618368545a5dcee0ca59fe87ba6137ab4a1
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 9d16d7881251b077f1e2e0b55b15d9db659c307f
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Aug 27 16:11:03 2018 +0530
nfs-server : fix few coverity issues in mount3.c
This patch fixes 1388767 and 1389057.
Change-Id: Id4ee7c3cd72e46112315f6dccb08e76788b40d27
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit e40efc9ec35ac96fd1e267638a599789bddcea54
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Aug 27 13:48:23 2018 +0530
libglusterfs/gfdb_data_store: handle a range-overflow condition
As the value read from the file is not checked for the range,
and the same value is directly used to allocate, and read further
values, it can cause major issues.
CID: 1351699
updates: bz#789278
Change-Id: I7ff4c1791343861ebf98d1c615b52af54cb2485e
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 309ebf394176dbcc2bb3b911e12e63b1b8d4894c
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Aug 30 09:47:18 2018 +0530
rpc: log fuse unique ID along with gluster XID
for better traceability between fuse requests and gluster requests a
mapping needs to be established in the logs between the two IDs
BUG: 1623408
Change-Id: I0ef82fe69c1ad7d0ce9e3ac4f35cd82aa6e9bca9
fixes: bz#1623408
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 2bb347c43addce6b080dbfc681f74e3539187c15
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Aug 29 01:39:28 2018 +0530
glusterd : fix some coverity issues in glusterd-syncop.c
This patch fixes CID 1382344, 1124655 and 1325537.
Change-Id: I2412d6b88483e32a5de1baebb3823a985b2dcfb0
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 89bc210c5b09fbd42cf04533ccad7aff86d1bc96
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Aug 9 15:52:19 2018 +0200
build: add --enable-asan configure options
Introduce a `./configure --enable-asan` to build with
`-fsanitize=address -fno-omit-frame-pointer` options. This uses the
libasan.so shared library, so that needs to be available.
While running builds with the ASAN options, several linker issues
surfaced and these have been addressed with this change as well.
Building with --enable-asan has been tested on Fedora 28.
Change-Id: I428a9da70dd8f7d0056cfbe5c398619a571469b2
Updates: #492
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 4b7213308977a86aa370ef760867fddd6ea8d346
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Aug 24 17:24:15 2018 +0300
libglusterfs/src/dict.c: allocate memory accurately.
I suspect we've allocated and then set to '\0' an
additional byte for no reason: gf_asprintf() allocates
enough inc. the terminating null; data->len took that
additional byte into account; memcpy() it back
took care of that terminating null byte as well.
Also, unrelated, implemented str_to_data() via
strn_to_data().
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I32c90e12974f51a0fbc0cfaebf9bd0fd722adc11
commit eba6a9dea8917a892c269808770f7803317f6a09
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Aug 29 14:24:29 2018 +0530
IO cache : fix coverity issues in io-cache.c
This patch fixes CID 1382361, 1124714 and 1382432.
Change-Id: I0407f35ee44ec6e4522de46092658223d0c8ee6a
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 8ac226fe49289f405084f6c1836018760c414e24
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Aug 24 20:59:30 2018 +0300
multiple files: remove unndeeded memset()
This is a squash of multiple commits:
contrib/fuse-lib/misc.c: remove unneeded memset()
All flock variables are properly set, no need to memset it.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I8e0512c5a88daadb0e587f545fdb9b32ca8858a2
libglusterfs/src/{client_t|fd|inode|stack}.c: remove some memset()
I don't think there's a need for any of them.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I2be9ccc3a5cb5da51a92af73488cdabd1c527f59
libglusterfs/src/xlator.c: remove unneeded memset()
All xl->mem_acct members are properly set,
no need to memset it.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I7f264cd47e7a06255a3f3943c583de77ae8e3147
xlators/cluster/afr/src/afr-self-heal-common.c: remove unneeded memset()
Since we are going over the whole array anyway, initialize it
properly, to either 1 or 0.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ied4210388976b6a7a2e91cc3de334534d6fef201
xlators/cluster/dht/src/dht-common.c: remove unneeded memset()
Since we are going over the whole array anyway it is initialized
properly.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Idc436d2bd0563b6582908d7cbebf9dbc66a42c9a
xlators/cluster/ec/src/ec-helpers.c: remove unneeded memset()
Since we are going over the whole array anyway it is initialized
properly.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I81bf971f7fcecb4599e807d37f426f55711978fa
xlators/mgmt/glusterd/src/glusterd-volgen.c: remove some memset()
I don't think there's a need for any of them.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I476ea59ba53546b5153c269692cd5383da81ce2d
xlators/mgmt/glusterd/src/glusterd-geo-rep.c: read() in 4K blocks
The current 1K seems small. 4K is usually better (in Linux).
Also remove a memset() that I don't think is needed between reads.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I5fb7950c92d282948376db14919ad12e589eac2b
xlators/storage/posix/src/posix-{gfid-path|inode-fd-ops}.c: remove memset()
before sys_*xattr() functions.
I don't see a reason to memset the array sent to the functions
sys_llistxattr(), sys_lgetxattr(), sys_lgetxattr(), sys_flistxattr(),
sys_fgetxattr().
(Note: it's unclear to me why we are calling sys_*txattr() functions with
XATTR_VAL_BUF_SIZE-1 size instead of XATTR_VAL_BUF_SIZE ).
Only compile-tested!
Change-Id: Ief2103b56ba6c71e40ed343a93684eef6b771346
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit ccea0740b4660ff0f7046d60b73813524e4629d0
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Aug 28 11:03:47 2018 +0530
glusterd: Fix coverity issues
This patch fixes CID's 1395250, 1395252
1395250 - Unintialized variable
1395252 - Out of bounds access
updates: bz#789278
Change-Id: Icf646364b14d48fa2bd82ea78ca5cdb5c684355f
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit ca4b27145d7423488d7282e0e20586215dca7cd2
Author: karthik-us <ksubrahm@redhat.com>
Date: Tue Aug 28 12:51:00 2018 +0530
cluster/afr: Coverity fixes in afr
Fixes the deadcode issue in "afr-common.c" and
null pointer dereference isse in "afr-dir-read.c".
CIDs: 1395160, 1389018
Scan details:
https://scan6.coverity.com/reports.htm#v42418/p10714/fileInstanceId=85017760&defectInstanceId=25877740&mergedDefectId=1395160
https://scan6.coverity.com/reports.htm#v42418/p10714/fileInstanceId=85017734&defectInstanceId=25877951&mergedDefectId=1389018
Change-Id: I65dff57305aa3ae43544be5353f801d761193e97
updates: bz#789278
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 4e7093dfc857661f036341bc1f793e4858e85576
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 19:18:17 2018 +0300
multiple files: move from strlen() to sizeof()
{glusterfsd|glusterfsd-mgmt|quota-common-utils|xlator|tier|stripe}.c
tools/setgfid2path/src/main.c
xlators/cluster/afr/src/afr-inode-read.c
{glusterfs-acl|glusterfs}.h
For const strings, just do compile time size calc instead of runtime.
Compile-tested only!
Change-Id: I303684b1ff29b05c10126fb1057f507e404ced07
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 1065f842797e79cf9aa62dea579e02227d87be9c
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Aug 28 09:06:56 2018 +0530
cli: dereferencing null coverity fix
CID: 1124489
https://scan6.coverity.com/reports.htm#v42375/p10714/fileInstanceId=85018660&defectInstanceId=25877775&mergedDefectId=577602
updates: bz#789278
Change-Id: I0ebfbc52ecd5e3b70574df5f286116f872514cc6
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 077ecc87360024b95b5ec5a4255b01f2941fd282
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Aug 28 11:34:40 2018 +0530
snapshot : fixed coverity issue in glusterd-snapshot.c
This patch fixes CID 1395253 and indentation.
Change-Id: Iffcd992d3d49765c7e47b864724f83c7c5d57579
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit ccdc737719c734cd721d06be0e3f77d9662fe2df
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Aug 27 11:46:33 2018 +0530
cluster/afr: Delegate metadata heal with pending xattrs to SHD
Problem:
When metadata-self-heal is triggered on the mount, it blocks
lookup until metadata-self-heal completes. But that can lead
to hangs when lot of clients are accessing a directory which
needs metadata heal and all of them trigger heals waiting
for other clients to complete heal.
Fix:
Only when the heal is needed but the pending xattrs are not set,
trigger metadata heal that could block lookup. This is the only
case where different clients may give different metadata to the
clients without heals, which should be avoided.
Updates bz#1622821
Change-Id: I6089e9fda0770a83fb287941b229c882711f4e66
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit ee8894a6c726b0d4adb4485f8937b968ccd0c49e
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Aug 27 09:26:43 2018 +0530
playground: fix coverity issue
CID: 1395161
Updates: bz#789278
Change-Id: I6cc5c488a8aa12d312c34e6535786fd4debcb24c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit f9690b8f2d559769a561d99303bb748e9cf0cd6b
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Aug 27 17:31:28 2018 +0530
libglusterfs : fix coverity in store.c
This patch fixes CID 1395103 and 1395102.
Change-Id: I8c9fad85f254a55697b0bad185dcdd02be64f682
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 1669d34bd55511a92b5755c087fac4d7444bc65d
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Aug 7 19:02:48 2018 +0530
snapshot : fix few coverity issues in glusterd-snapshot-utils.c
This patch fixes CID 1210987 and 1351650.
Change-Id: Ic85bc6048651146a79fe68add19dcc095738a517
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit b263c8bc8b8a51d36b1ff6c2f91d5320b2d0e570
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Aug 17 22:29:05 2018 +0300
libglusterfs/src/dict.{c,h}: Introduce dict_setn, dict_addn, dict_addn and others.
They all take as a parameter the key length, instead of strlen() it.
In most cases, we know the key length, we just never bothered to save and pass it along.
(We most likely sprintf'ed it earlier and the return value could have been used).
A more interesting addition is dict_set_nstrn() [horrible name. Ideas are welcome].
It accepts both the string length and the key length and avoids strlen() both.
Some of it can be calculated on compile-time, btw.
For example:
dict_set_str (dict, "key", "all");
Should become:
dict_set_nstrn (dict, "key", sizeof ("key"), "all", sizeof ("all"));
Compile-tested only!
Change-Id: Ic2667f445f6c2e22e279505f5ad435788b4b668c
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit e072aaa8833ef823b78e82fdcb59d895a94959ba
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Aug 17 14:02:35 2018 +0300
libglusterfs/src/dict.c: perform hash calc not under lock.
If possible, perform the key hash calculation not under
the dictionary lock.
Compile-tested only!
Change-Id: I88b6ed4eff6660d8334bc08ca4eebf61960e3ca1
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit e59e0e068ff8a9aef0d5fe05de50139c40c9a8e2
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Fri Aug 24 16:51:54 2018 +0300
dict.c: fix indention
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I3f210ae236f778fd0e8e7a17d01da21f65cb4e4b
commit 8aa6d80b76f331fd7844a7954245e39786da78f6
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Aug 26 16:46:55 2018 -0700
features/namespace: Fix a probable null dereference
Addresses CID: 1388656
Change-Id: I614c29e993dd112ee02c5bffe8c737deb225c1f9
Updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit cbd50dc951b218d4b2b43acb6fc561618edc27a4
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Aug 22 12:03:04 2018 -0700
cluster/ec: Prevent a possible out-of-bounds read
Addresses CID 1370939
In ec_code_x64_epilog(), there is a possibility of reading from an
incorrect index of ec_code_x64_regmap array
Change-Id: Ib8a228bbe13631188343634b2bde5919cdaab5a4
Updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 0fede0f7e8e25b19bb4f75def11da4622360ce5c
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Aug 27 12:18:21 2018 +0530
glusterd: glusterd_brick_start shouldn't cleanup pidfile if only_connect is true
Problem: Sometime glusterd cleanup pidfile even brick is started
and cli shows volume status "N/A"
Solution: Update the condition in glusterd_brick_start to avoid
pidfile cleanup in case if only_connect flag is true
Fixes: bz#1622422
Change-Id: I8decb34597126b848e3a44d957e138833dd97350
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 01cd1786e5e5a8d880f471c10f284c97758ea816
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Jul 31 20:50:30 2018 +0300
dict.c: do not strlen if not needed.
Use the output of sprintf().
Also, constify and initialize parameters properly.
Only compile-tested!
Change-Id: I33870afbe14bc1292fb08115e878d48c00a43bee
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 4a592d994fb03709185b130312c48d4792e8f0bb
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Aug 24 07:16:18 2018 -0400
geo-rep: Make automatic gfid conflict resolution optional
Autmatic gfid conflict resolution needs to be disabled
during failover/failback as it might lead to data loss
in the following scenario.
1. Master went down without syncing directory "dir1" to slave.
2. When slave is failed over to master, if a new file
is written inside "dir1", creating dir1 again if not
present, "dir1" ends up with different gfid on original
slave.
3. When original master is up and failed back, due to
automatic gfid conflict resolution, "dir1" present in
original master is deleted losing all files and only
new file created on original slave is restored.
Hence during failover/failback, automatic gfid conflict
resolution should be disabled. So in these cases, appropriate
decision is taken.
fixes: bz#1622076
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Change-Id: I433616f5d3e13d4b6eb675475bd554ca34928573
commit 080d69e19543315310889ba27ce6cd6662c0434f
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Aug 23 14:24:56 2018 +0530
feature/shard: Fix Coverity issue
Fix following coverity issues-
CID:
1394660
1394668
1394667
1389008
1389434
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=84880983&defectInstanceId=25821108&mergedDefectId=1389008
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=84880983&defectInstanceId=25821101&mergedDefectId=1389434
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=84880983&defectInstanceId=25821001&mergedDefectId=1394660
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=84880983&defectInstanceId=25821010&mergedDefectId=1394667
https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=84880983&defectInstanceId=25821017&mergedDefectId=1394668
Change-Id: I08f09649dbe758ba0d367ae5330b48b18784dec3
updates: bz#789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 9577565787ac95ebc4c21b5856c72874d2001da9
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Tue Aug 7 09:30:37 2018 +0800
posix-acl: skip acl_permits check when the owner setting GF_POSIX_ACL_xxxx
Change-Id: Iaeea470d040587027f37e0760ae27c4fc205a189
fixes: bz#1613098
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 0799cda818e121f65f9708ec8780622d9a155cce
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Fri Aug 24 10:44:59 2018 +0530
ctr: skip ctr xlator init if ctr is not enabled
Problem: If ctr xlator is not required it consumes
resources unnecessarily
Solution: Call ctr xlator init only while feature is enabled
Fixes: bz#1524323
Change-Id: I378113a390a286be20c4ade1b1bac170a8ef1b14
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 5bcfea1afdb6f7b19dd14372bcae2c367c9b3c93
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Sat Aug 25 15:07:02 2018 +0530
cli : fix coverity cli-rl.c
This fixes new coverity issue introduced by commit 5acb74d7da.
Fixes 1395188.
Change-Id: I629e5f214150672e309abb2fc58f55f1f58d8fb7
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit ace97cecee16924a04c27b4ca6293fec4a9c6615
Author: ShyamsundarR <srangana@redhat.com>
Date: Tue Aug 14 14:00:41 2018 -0400
tests: Preserve tarball of tests when they timeout
When tests timeout, the timeout command sends TERM
signal to the command being executed. In the case of run-tests.sh
it invokes prove, which further invokes perl and finally the test
is run using bash. The TERM signal does not seem to be reachnig
the end bash that is actually executing the tests, and hence
when any test is terminated due to a timeout, the cleanup routine
in include.rc does not get a chance to run and preserve the
tarball.
Further, cleanup invokes tarball generation, but is invoked at
the beginning and end of every test, and at times in beteween
as well. This caused way too many tarballs in case we decide to
preserve the same whenever generated by cleanup.
This patch hence moves the tarball generation to run-tests.sh
instead, and further stores them named <test>-iteration-<n>.tar
and also prints tarball name generated and stored per iteration.
This should help relate failed runs to the tarball iteration #
and to look at relevant logs.
Further the patch also provides a -p option to run-tests.sh for
unit testing purposes, where running a test in a loop without the
option will generate as many tarballs, and using the option will
reduce this to preserving the last tarball, saving space in
smaller unit test setups.
Fixes: bz#1614062
Change-Id: I0aee76c89df0691cf4d0c1fcd4c04dffe0d7c896
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 70909bc279f27aeabc3a7853a39a9783d9143e8c
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Aug 24 09:42:12 2018 -0700
mgmt/glusterd: Coverity fixes in glusterd-utils.c
Addresses the following CIDs:
1388821: Unchecked return value from sys_lremovexattr() in
glusterd_check_and_set_brick_xattr()
1370957: Unused return value in glusterd_volume_tier_use_rsp_dict()
1370950: Memory leak in glusterd_get_global_options_for_all_vols()
1370946: Redundant gf_strdup() leading to a memory leak in
glusterd_get_global_options_for_all_vols()
Change-Id: I2ab58207bc43b40f004ee18463430a141126bf94
Updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 257efff3d3df85ca089471f8e9c14e27dba0af9b
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Aug 22 18:49:49 2018 -0700
storage/posix: Coverity fixes in posix-handle.c
Addresses the following CIDs:
1370938: Out of bounds write in posix_make_ancestryfromgfid()
1351642: UnChecked return value from sys_stat() in posix_handle_init()
Change-Id: I3483ebcd798793ce6c504e92b4ea203bcf99fc0e
Updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 5d24dd53e57884f8d15e6d521a884a3ad7be7751
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 18:56:24 2018 +0300
multiple files: move from strlen() to sizeof()
{ec-heal|ec-combine|ec-helpers|ec-inode-read}.c
For const strings, just do compile time size calc instead of runtime.
Compile-tested only!
Change-Id: If92ba0a7a20f64b898d01c6e3b6708190ca93e04
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit dc89dc958039444ac5108679c946219a7582a529
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 18:32:53 2018 +0300
extras/geo-rep/gsync-sync-gfid.c: move from strlen() to sizeof()
For const strings, just do compile-time size calc instead of runtime.
Compile-tested only!
Change-Id: I89470016389a4ecb3bed35a1c9e684f5fae79997
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 8d595692aaf3935d06ba08ed066028fe549541cf
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 18:31:03 2018 +0300
{mount-common|fusermount|mount_darwin|umountd}.c: strncpy()->sprintf(), reduce strlen()'s
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf().
Also:
- save the result of strlen() and re-use it when possible.
- move from strlen to SLEN (sizeof() ) for const strings.
Compile-tested only!
Change-Id: I369209b36d8356c3fe00d32f8bf56e74cf9963db
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 2b529c0ca4d33aa7515c6dabf80e4cb1f526d63e
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 18:25:33 2018 +0300
{cli-cmd-parser|cli-rpc-ops||cli-xml-output}.c: strncpy()->sprintf(), reduce strlen()'s
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf().
Also:
- save the result of strlen() and re-use it when possible.
- move from GF_CALLOC() to GF_MALLOC() for the strings.
- move from strlen to sizeof() for const strings.
Compile-tested only!
Change-Id: I3cf49c5401ee100a5db6a4954c3d699ec1814c17
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 96177b47f83cc36146edc87bb0c95242304fe18a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 18:21:25 2018 +0300
glfs-fops.c, glfs.c: strncpy() -> sprintf(), reduce strlen()'s
strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, use snprintf().
Also, save the result of strlen() and re-use it when possible.
Compile-tested only!
Change-Id: I4ecfb359cf0efaafeab245a8138f526b21613231
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit b248e8546e97a99029607db6aaaf7c1d67e22acd
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Aug 10 00:57:09 2018 +0530
cli : fix few coverity in cli
This patch fixes DEADCODE and FORWARD_NULL.
CID : 1124495, 1124380, 1124381
Change-Id: I79992e396dbcb1bfe6cd0614d49a8da3f67d648d
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit e73f6fadd5d84706a2349b4f59162c8c2a110d00
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Aug 23 16:11:25 2018 -0700
debug/error-gen: Prevent a possible null dereference
Addresses CID: 1124492
Change-Id: I92f807b5e45537e68c318bcbf54ccaa23d18b0dd
Updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 44f5ed0dff8ffc2287b0d300e093319688138495
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Thu Aug 23 18:22:09 2018 +0530
block : fix few coverity issue
Fixes 1128923, 1134020 and 1370936.
updates: bz#789278
Change-Id: I2cadc09ffd0814a9390ba068006fa56704d3820d
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 840d3ee398b8000033ae2f98e8e93633cb4e60f9
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Aug 12 17:28:07 2018 -0700
features/cloudsync: Fix various resource leaks
Addresses CID: 1394648, 1394653
Change-Id: Ie75d4a268bba090faa5c3fe0e87f0e5cef3ff773
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit aebf24c5d1943248460667a68b8086afc69aeca7
Author: Shwetha Acharya <shwetha174@gmail.com>
Date: Fri Aug 3 15:51:36 2018 +0530
stripe: FORWARD_NULL coverity fix
Problem: frame could be NULL.
Solution: Added condition checks to avoid NULL pointer dereferencing.
CID: 1124478, 1124501, 1124504, 1124510
BUG: 789278
Change-Id: I5c81d912102a7e672386db3fdb820f883d08666f
Signed-off-by: Shwetha Acharya <shwetha174@gmail.com>
commit 61655cf9863c16752240e2b93e98f3cf1b7ee99d
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Mon Aug 20 21:06:37 2018 +0530
locks: coverity fixes
Fixes CID: 1356583 1356582 1356581 1356580
Add logs and also replace gf_log with gf_msg_debug.
Change-Id: I348dc94f7a52034542d29096c12a2cf60aabe97f
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit 1b84b5c813da17867020829e3875c900427f824e
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Tue Aug 21 13:00:48 2018 +0530
marker: fix for coverity issues
Fixes CID: 1325591 1356503 1325540 1351704
Change-Id: I325b1184baa81402eaa009cb36ab95e5de812f6c
updates: bz#789278
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
commit 286fa49d4f48c1a79774a68f5e307cf82c26c180
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 23 09:21:02 2018 +0300
libglusterfs/src/iobuf.c: remove memset(), CALLOC -> MALLOC
I'm not sure I see the need for those memset(), I've removed them.
There's at least one easy to convert CALLOC to MALLOC - converted.
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ia019775ad5255190f5d02d948ea27db7f563387d
commit 1d5da27ab895ea697beb78801d21af7492de590b
Author: ShyamsundarR <srangana@redhat.com>
Date: Wed Aug 22 15:04:52 2018 -0400
dht/switch: Fix coverity issues
CID: 1124779: dup_childs not freed in an err path
CID: 1382398: option_string leaked
CID: 1382389: memcpy may cause string overflow
Also, fixed up NULL termination for the string
Potential use after free (or double free in this case) as below,
(link split into multiple lines)
https://download.gluster.org/pub/gluster/glusterfs/static-analysis/
master/glusterfs-coverity/2018-08-22-0ebaa9c6/html/
1/427switch.c.html#error
Change-Id: I76681af6a8091666918a3d5dff30a152a7b97905
Updates: bz#789278
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 497561dd2bc0c62e26529b0ce433f3551b981c3b
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Jun 8 09:54:00 2018 -0400
features/snapview-server: validate the fs instance before doing fop there
PROBLEM:
========
USS design depends on snapview-server translator communicating with each
individual snapshot via gfapi. So, the snapview-server xlator maintains
the glfs instance (thus the snapshot) to which a inode belongs to by
storing it inside the inode context.
Suppose, a file from a snapshot is opened by a application, and the fd
is still valid from application's point of view (i.e. application has
not yet closed fd). Now, if the snapshot to which the opened file
belongs to is deleted, then the glfs_t instance corresponding to the
snapshot is destroyed by snapview-server as part of snap deletion.
But now, if the application does IO on the fd it has kept open, then
snapview server tries to send that request to the corresponding snap
via glfs instance for that snapshot stored in the inode context for
the file on which the application is sending the fop. And this results
in freed up glfs_t pointer being accessed and causes a segfault.
FIX:
===
For fd based operations, check whether the glfs instance that the inode
contains in its context, is still valid or not.
For non fd based operations, usually lookup should guarantee that. But
if the file was already looked up, and the client accessing the snap data
(either NFS, or native glusterfs fuse) does not bother to send a lookup
and directly sends a path based fop, then that path based fop should
ensure that the fs instance is valid.
Change-Id: I881be15ec46ecb51aa844d7fd41d5630f0d644fb
updates: bz#1602070
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 4a51108ab32de695f05e896ebea6c4b04ccb3134
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Aug 13 14:52:09 2018 -0700
mgmt/glusterd: Fix resource leak & unused value issues in glusterd-volume-ops.c
Addresses CID: 1274132, 1325534
Change-Id: I176612ef5baf5618d543838a5f32db7dcd7002c3
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 66f7862a1bcc3d74ac3c35b7827b300862b5735f
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Aug 21 09:44:15 2018 +0530
performance/write-behind: fix fulfill and readdirp race
Current invalidation of stats in wb_readdirp_cbk is prone to races. As
the deleted comment explains,
<snip>
We cannot guarantee integrity of entry->d_stat as there are cached
writes. The stat is most likely stale as it doesn't account the cached
writes. However, checking for non-empty liability list here is not a
fool-proof solution as there can be races like,
1. readdirp is successful on posix
2. sync of cached write is successful on posix
3. write-behind received sync response and removed the request from
liability queue
4. readdirp response is processed at write-behind.
In the above scenario, stat for the file is sent back in readdirp
response but it is stale.
</snip>
The fix is to mark readdirp sessions (tracked in this patch by
non-zero value of "readdirps" on parent inode) and if fulfill
completes when one or more readdirp sessions are in progress, mark the
inode so that wb_readdirp_cbk doesn't send iatts for that in inode in
readdirp response. Note that wb_readdirp_cbk already checks for
presence of a non-empty liability queue and invalidates iatt. Since
the only way a liability queue can shrink is by fulfilling requests in
liability queue, wb_fulfill_cbk indicates wb_readdirp_cbk that a
potential race could've happened b/w readdirp and fulfill.
Change-Id: I12d167bf450648baa64be1cbe1ca0fddf5379521
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
updates: bz#1512691
commit 09180af76239ed549b226162bebbd2e8bbd495f7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Aug 23 12:12:36 2018 +0530
glusterd: glusterd_brick_start shouldn't try to bring up brick if only_connect is true
With the latest refactoring in glusterd_brick_start () function in case
we run into a situation where is_gf_service_running () return a valid
pid which is running but doesn't belong to a gluster process, even in
case of only_connect flag passed as gf_true we'd end up trying to start
a brick which would cause a deadlock in brick multiplexing as both
glusterd_restart_bricks () and glusterd_do_volume_quorum_action () would
cause context switching with each other for the same brick. The
following bt shows the same:
(gdb) t a a bt
Thread 8 (Thread 0x7fcced48a700 (LWP 11959)):
srch_vol=srch_vol@entry=0xbe0410, comp_vol=comp_vol@entry=0xc03680,
brickinfo=brickinfo@entry=0xc14ef0) at glusterd-utils.c:5834
brickinfo=0xc14ef0, volinfo=0xc03680, conf=<optimized out>)
at glusterd-utils.c:5902
brickinfo=brickinfo@entry=0xc14ef0, wait=wait@entry=_gf_false,
only_connect=only_connect@entry=_gf_true) at glusterd-utils.c:6251
volinfo=0xc03680, meets_quorum=_gf_true) at glusterd-server-quorum.c:402
at glusterd-server-quorum.c:443
iov=iov@entry=0x7fcce0004040, count=count@entry=1,
myframe=myframe@entry=0x7fcce00023a0) at glusterd-rpc-ops.c:542
iov=0x7fcce0004040, count=1, myframe=0x7fcce00023a0,
fn=0x7fccf12403d0 <__glusterd_friend_add_cbk>) at glusterd-rpc-ops.c:223
---Type <return> to continue, or q <return> to quit---
at rpc-transport.c:538
Thread 7 (Thread 0x7fccedc8b700 (LWP 11958)):
Thread 6 (Thread 0x7fccf1d67700 (LWP 11877)):
brickinfo=brickinfo@entry=0xc14ef0) at glusterd-utils.c:5834
at glusterd-utils.c:6251
Thread 5 (Thread 0x7fccf2568700 (LWP 11876)):
Thread 4 (Thread 0x7fccf2d69700 (LWP 11875)):
Thread 3 (Thread 0x7fccf356a700 (LWP 11874)):
Thread 2 (Thread 0x7fccf3d6b700 (LWP 11873)):
---Type <return> to continue, or q <return> to quit---
Thread 1 (Thread 0x7fccf68a8780 (LWP 11872)):
Fix:
The solution is to ensure we don't restart bricks if only_connect is
true and just ensure that the brick is attempted to be connected.
Test:
Simulated a code change to ensure gf_is_service_running () always return
to true to hit the scenario.
Change-Id: Iec184e6c9e8aabef931d310f931f4d7a580f0f48
Fixes: bz#1620544
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 615e3754445b9cff737b7c4a410fb4822c38387b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:19:55 2018 +0300
xlators/mgmt/glusterd/src/glusterd-utils.c : re-scope message variable
The the error message variable changed in scope - defined in a smaller scope.
Compile-tested only!
Change-Id: I16dda11c30099b0e448b8e44a300f153727ce8da
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 17c4d761df9d1421d9024430ea0090428032ea05
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:20:32 2018 +0300
xlators/mgmt/glusterd/src/glusterd-volume-ops.c : reduce size of message variable
Size of error message variable reduced from 2048 bytes to 64 bytes or
128 bytes.
Compile-tested only!
Change-Id: I393ba03969a6e71ccb0ce382d0e0546192897312
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit ecb06529cd0b375bb08cc056969bd18302d8309d
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:19:32 2018 +0300
xlators/mgmt/glusterd/src/glusterd-snapshot-utils.c : declare err_str as const char
declare err_str as const char and intialize it at the time of declaration.
Compile-tested only!
Change-Id: If07e1130e819ce042905a2d0be650cd7afc2b558
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit db2ccc2e938bd412045302d4e13ffcba27525684
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:18:46 2018 +0300
xlators/mgmt/glusterd/src/glusterd-replace-brick.c : reduce size of message variable
Size of error message variable reduced from 2048 bytes to 256 bytes.
Compile-tested only!
Change-Id: Ifc0f6af2256bcbec77102767ba651d5d55f8c906
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 959387b5f5f3dfeec8da423d9a1568ebaa2719ad
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:20:19 2018 +0300
xlators/mgmt/glusterd/src/glusterd-volgen.c : reduce size of message variable
Size of error message variable reduced from 4096 bytes to 128 bytes.
Compile-tested only!
Change-Id: I08c87502be791e68ab767ed96657ac89ee77fae0
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 9396a233ab3c29fae4ddfac586fc2ca0d6be417f
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 23:34:52 2018 +0300
rpc/rpc-lib/src/rpc-clnt-ping.c:move to GF_MALLOC() instead of GF_CALLOC() when
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
Change-Id: Ifb30412ddf1bfa509f52e0454454929b266e5658
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit b56c293744566b5803657a5fdabaf83a55a97a58
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Aug 21 22:16:07 2018 -0700
mgmt/glusterd: Fix memory leaks in glusterd-handler.c
Addresses the following CIDs:
1370941: Unconditional memory leak in glusterd_print_snapinfo_by_vol()
1370943: Memory leak when opendir fails for output directory in
glusterd_get_state()
Change-Id: I9536841629e1ffe1fed79a8e57d266a0e953e5af
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 7b655e104940d6d25bc757d3fd294cc0bba8f6e1
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 23:31:47 2018 +0300
cli/src/cli-cmd-parser.c:move to GF_MALLOC() instead of GF_CALLOC() when
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
Change-Id: I01c67fd535ea4a2b8fa7cb4d89bff52642dc009a
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 39054c73e2e3eb6701d981c801fb34e42cbb7654
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Aug 21 20:57:52 2018 +0530
storage/posix: Increment trusted.pgfid in posix_mknod
The value of trusted.pgfid.xx was always set to 1
in posix_mknod. This is incorrect if posix_mknod
calls posix_create_link_if_gfid_exists.
Change-Id: Ibe87ca6f155846b9a7c7abbfb1eb8b6a99a5eb68
fixes: bz#1619720
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit d1ca3afaf76a8da8e020fa6e239bc2b75a1bdefa
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Aug 16 17:28:54 2018 +0530
afr: common thin-arbiter functions
...that can be used by client and self-heal daemon, namely:
afr_ta_post_op_lock()
afr_ta_post_op_unlock()
Note: These are not yet consumed. They will be used in the write txn
changes patch which will introduce 2 domain locking.
updates: bz#1579788
Change-Id: I636d50f8fde00736665060e8f9ee4510d5f38795
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit a395eafdaeda9fcd018879b5e37ae10d167c7c66
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:19:03 2018 +0300
xlators/mgmt/glusterd/src/glusterd-rpc-ops.c : re-scope message variable
The error and/or message variable was changed in scope:
defined in a smaller scope.
Compile-tested only!
Change-Id: I5e46a1992ad35a996aa8ee58da28606ac018ab8e
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit fc27fc4ed8b4e169c5ff33b74d39c089ad6241cb
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Aug 22 02:05:59 2018 -0400
glusterfind: Fix problems in python2 -> python3 compat
1. Import configparser module correctly
2. Fix issues with urllib usage
Updates: #411
Change-Id: I060af29f1ebac3a5e2aeeee2720b7372d4c31697
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 7f906841950e9f8253327c95709fdcd6590dcc35
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:18:15 2018 +0300
xlators/mgmt/glusterd/src/glusterd-handshake.c : reduce size or re-scope message variable
The the error and/or message variable was either:
- Reduced in size - from 2048 bytes to 64 bytes, for example.
or
- Changed in scope - defined in a smaller scope.
Compile-tested only!
Change-Id: I9c609415667844ee034b7eb2b67bdbc19d38819d
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit f6a3c077a5ed76a74c2c50736fa466885c102315
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:18:00 2018 +0300
xlators/mgmt/glusterd/src/glusterd-handler.c : reduce size or re-scope message variable
The the error and/or message variable was either:
- Reduced in size - from 2048 bytes to 64 bytes, for example.
or
- Changed in scope - defined in a smaller scope.
Compile-tested only!
Change-Id: Iebb92a56d9d0ca53c80d75866bcb7848e08cf6b2
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 75771f5c8062a86cffb658baabd584f8a84729d5
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:17:42 2018 +0300
xlators/mgmt/glusterd/src/glusterd-geo-rep.c : reduce size of message variable
Size of error message variable reduced from 2048 bytes to 64 bytes.
Compile-tested only!
Change-Id: I65abd9c4f23a64ac9cda5373aff4119458addbc8
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 93cc5da32a78beef35f026d479aebae113d733d8
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:17:21 2018 +0300
xlators/mgmt/glusterd/src/glusterd-brick-ops.c : reduce size or re-scope message variable
The the error and/or message variable was either:
- Reduced in size - from 2048 bytes to 64 bytes, for example.
or
- Changed in scope - defined in a smaller scope.
Compile-tested only!
Change-Id: Ib74e5f8f4c2978f670d4708e9382e97edf5df0a7
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 3dfbe367ba22b9c1fe2c6ff2d6718d19016d58c2
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:17:01 2018 +0300
xlators/mgmt/glusterd/src/glusterd-bitrot.c : reduce size of message variable
Size of error message variable reduced from 2048 bytes to 256 bytes.
Compile-tested only!
Change-Id: Ib536451d9b562f932132b99c4eff21fc4f2775bc
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 0a32c8412a9974c6f7b533439bc395d55707b158
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Aug 21 15:07:16 2018 -0700
features/changelog: Fix a file handle leak in htime_create()
In a few error scenarios, ht_file_hd was not being cleaned up.
Addresses CID: 1325549
Change-Id: If9b4388aa700303c1eebbf1410dc35d18c4637df
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit ed9a72291b5ead93aaba2fc1d5232c391f7e8365
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Aug 3 15:23:45 2018 +0530
snapview/server: Set uid,gid,and groups for gfapi call
Before calling gfapi from snapd, we need to set uid, gid
and groups in the context. This is required to do the
validation from posix acl xlator.
Change-Id: I181bea2570a69554ff363bf5a52478ff0363ea47
fixes: bz#1614168
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 1bb2e2b2cc904dddb688428eb1117bd35be40952
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Aug 21 22:43:22 2018 -0700
mgmt/glusterd: Fix resource leaks in glusterd-handshake.c
Addresses the following CIDs:
1124768: fd leak in __server_getspec() if spec_fd happens to be 0
1202400: Memory leak in get_snap_volname_and_volinfo()
1214622: Memory leak in glusterd_create_missed_snap()
1214623: Memory leak in an error path of __server_get_volume_info()
Change-Id: I33910b4125d25205e76e0d13cf0256d47bd8fc3c
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit fb0ea0fb4d93066699e42a3321099b3439b6a700
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Aug 21 14:51:11 2018 -0700
features/leases: Initialize op_errno in leases_open()
Addresses CID: 1356483 by getting rid of an unessential assignment for
op_errno
Change-Id: I2327ac17b2875b4dd5f79b76be59e2c8e570b031
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 1445990eb0e35dea15fce01ef43ab6cffefe71c5
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Aug 21 23:33:58 2018 -0700
mgmt/glusterd: Fix memory leaks in glusterd-op-sm.c
Addresses the following CIDs:
- 1124704: Removed an unessential variable that caused a memory
leak in glusterd_op_set_volume(). Nuked an unnecessary log message upon
error as well since failure logging is being done in the caller
- 1124772: Memory leak in an error path of
glusterd_op_ac_send_brick_op()
- 1175021: Removed an unessential variable that caused a memory leak in
glusterd_op_build_payload()
Also addressed a memory leak in an error path of
glusterd_dict_set_volid()
Change-Id: I060effbbcebe9d58b91f606175080ede517ba239
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit b92de623aa8f6540bfdefbae4e813e5efe14d294
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Sat Aug 18 22:46:12 2018 +0530
crypt: fix coverity issues
Fixes CID: 130760 130759
Change-Id: I40efebd712a3bd769cb1fbc54409f1b0b35eb7b4
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit a86ba8073e6079f5621f689532fd776f1610a6ff
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Aug 22 02:08:40 2018 +0530
snapshot : fix snapshot status failure due to symlink problem
Problems : 1. Snapshot status for individual snapshots were failing after OS
upgrade from RHEL6 to RHEL7.
2. Post upgrade snapshot creation of cloned volume was failing.
Root Cause : When OS upgrade is from RHEL6 to RHEL7 there is difference in
symlink (/var/run) between these two versions.
Basically when (/var/run) is symlinked to /run, mount command
resolves path and mounts it. But at the same time call to
those functions fails who depends on absolute path.
(like strcmp in glusterd_get_mnt_entry_info)
Solution : Resolve the input path to absolute path before calling these
functions.
Test : Tested on same setup where issue was reported. After this
patch snapshot issues are completely resolved.
Change-Id: I5ba57998cea614c6072709f52f42a57562018844
fixes: bz#1619843
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 1cb0a454dd5147dc6b53106e6da6454ec2843df5
Author: ShyamsundarR <srangana@redhat.com>
Date: Tue Aug 21 21:53:35 2018 -0400
coverity: Multiple coverity fixes for issues with HIGH severity
glfs-fops.c
1391414 Uninitialized pointer read
List head needed initialization
glusterfsd-mgmt.c
graph.c
1382431 Buffer not null terminated
1382417 Dereference before null check
1382347 Buffer not null terminated
Cleaned usage of volfile_checksum member of gf_volfile_t struct
across the code base.
glusterd-tier.c
1382426 Resource leak
1370955 Dereference before null check
The function fixed needs more work, but with tier almost being
deprecated, addressed some parts of the reported coverity issues
as appropriate.
Tested using the following test cases:
./tests/basic/tier/new-tier-cmds.t
./tests/basic/tier/tier.t
./tests/basic/tier/bug-1214222-directories_missing_after_attach_tier.t
./tests/basic/tier/tier_lookup_heal.t
./tests/basic/tier/tier-heald.t
./tests/basic/tier/tier-snapshot.t
./tests/features/glfs-lease.t
Change-Id: I396f1c34bb112bb22d2745ed279e1a4850cac4af
Updates: bz#789278
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 90eb61b4236fc8ece2769d9a6ea237202b10db3f
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Aug 8 21:40:57 2018 +0300
libglusterfs/src/common-utils.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
In some cases, also changed allocation size to be sizeof some
struct or type instead of a pointer - easier to read.
In some cases, removed redundant strlen() calls by saving the result
into a variable.
1. Only done for the straightforward cases. There's room for improvement.
2. Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I579f5b405bf410aac5ab0452231124d354f94ed1
commit bd9ea86723be96a167f0a957b487d45eb65ac1e6
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jun 29 23:40:53 2018 +0530
xlators/playground: fix the template files with latest requirements
* Make use of xlator_api
* Make use of gf_msg()
* Make use of mem-pool
* Add a sample metrics dump function
* Provide an dummy option, which can be initialized, and reconfigured
* Add a test case to make sure template xlator is built and used
with default fops
* Make a change in rpc-coverage to run without lock tests.
Updates: bz#1193929
Change-Id: I377dd67b656f440f9bc7c0098e21c0c1934e9096
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit ac7a6f75844ca85aa52ba8256d0f711fc4c5918b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Aug 8 21:40:29 2018 +0300
libglusterfs/src/graph.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
In some cases, also changed allocation size to be sizeof some
struct or type instead of a pointer - easier to read.
In some cases, removed redundant strlen() calls by saving the result
into a variable.
1. Only done for the straightforward cases. There's room for improvement.
2. Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Icd990423a5e6048e76922668aab67422f4bc1867
commit f36ba4685d580afe9450962230e621134a19077b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Jul 31 20:49:52 2018 +0300
dict.c: align dictionary structures
Change-Id: Ib7250b3ff11a7ab98b578c0663dc1817624b8df1
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit b87b341e1a69a34bc8b275bb8b9b05130cc4e85f
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 23:32:39 2018 +0300
libglusterfs/src/quota-common-utils.c:move to GF_MALLOC() instead of GF_CALLOC() when
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
Change-Id: Ie2a634d768904636160582189a5f0390668b37bb
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 50e64cdda5ab29d729f7507cc66bc89a0d5716ec
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Aug 8 21:40:17 2018 +0300
libglusterfs/src/rbthash.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
In some cases, also changed allocation size to be sizeof some
struct or type instead of a pointer - easier to read.
In some cases, removed redundant strlen() calls by saving the result
into a variable.
1. Only done for the straightforward cases. There's room for improvement.
2. Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ied400a500e36373d725f9480c5ebbe0a851f7c40
commit df83143c22289f33669436901e9184abfb5e1aa1
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Aug 8 21:40:44 2018 +0300
libglusterfs/src/dict.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
In some cases, also changed allocation size to be sizeof some
struct or type instead of a pointer - easier to read.
In some cases, removed redundant strlen() calls by saving the result
into a variable.
1. Only done for the straightforward cases. There's room for improvement.
2. Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Iea9098b9ec0a82a866fbc5836514b1b317daefa1
commit 63cfa626ed617476a37d82435552ca7f34cdf654
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Aug 8 21:41:10 2018 +0300
libglusterfs/src/client_t.c: Move to GF_MALLOC() instead of GF_CALLOC() when possible
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
In some cases, also changed allocation size to be sizeof some
struct or type instead of a pointer - easier to read.
In some cases, removed redundant strlen() calls by saving the result
into a variable.
1. Only done for the straightforward cases. There's room for improvement.
2. Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I58d2604ef684f94ea782fdbb1b1462fc7be53a9e
commit 6d14f6b99d7e4e4d43651108fc701b01241021b0
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Aug 21 23:30:03 2018 +0300
api/src/glfs.c: move to GF_MALLOC() instead of GF_CALLOC()
It doesn't make sense to calloc (allocate and clear) memory
when the code right away fills that memory with data.
It may be optimized by the compiler, or have a microscopic
performance improvement.
Please review carefully, especially for string allocation, with the
terminating NULL string.
Only compile-tested!
Change-Id: Ieeb86ff5d99176250f57c0a28c215c709b83fc80
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit f2b4c35e204bb8a450cd1888c68bb6ee3491e7ee
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Sun Aug 19 01:38:53 2018 +0530
protocol: coverity fixes
Fixes CID: 1389388 1389320 1274113 1388881 1388623 1124801 1124795
Change-Id: Ia72abc0560c959b0298f42e25abdfc5523755569
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit 2c6ccbf4fdfa9f5e387f3632b49687c4ada9d196
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Aug 20 15:28:16 2018 +0200
Fix physical memory detection on NetBSD
NetBSD has two sysctl for physical memory detection: hw.physmem and
hw.physmem64. Only the later is 64-bit proof, and it has been
available for years.
That fix is important because it cause recent glusterfs to refuse
mounting fileystems when there is too much RAM, with an error loading
the quick-read xlator
[quick-read.c:838:check_cache_size_ok] 0-gfs-quick-read:
Cache size 134217728 is greater than the max size of 0
Change-Id: I957a1ff1d7018fe2f9d47384a28708e6cbdf710a
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Fixes: bz#1619475
commit 6631f2890b01b4e3f28cc680c5e20e280cade3c9
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Aug 9 11:14:11 2018 +0530
cluster/dht: coverity fixes
Fixes 1133997, 1370910, 1382387, 1382444,
1394635
Change-Id: Ie63ad47abd5519b9b9536da26b61ed4c9eaf2c75
updates: bz#789278
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 0cdcdfe208ae698c2904c4af5e957005c25dc7db
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Aug 20 14:10:52 2018 -0700
features/sdfs: Minor improvements
Addresses:
CID 1389688: Prevent op_errno from being -ve in sdfs_rename()
CID 1389286: Check for retval from loc_copy() to avoid logically dead
code
and
Initializes op_errno to ENOMEM in sdfs_link()
Change-Id: I12e17a98faa5887da94a33ba9ca775e8e0fef359
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 8edd5b17998ea2416c74f9ea20645f3ed8e5ea33
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Aug 20 16:38:41 2018 +0530
Revert "performance/write-behind: better invalidation in readdirp"
This reverts commit 4d3c62e71f3250f10aa0344085a5ec2d45458d5c.
Traversing all children of a directory in wb_readdirp caused
significant performance regression. Hence reverting this patch
Change-Id: I6c3b6cee2dd2aca41d49fe55ecdc6262e7cc5f34
updates: bz#1512691
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 9fcd8e1c1c638daae3732c62165a1ae102b2b599
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Aug 15 19:34:31 2018 +0530
glusterd: fix gcc warnings
...and also changed char array initialization to from {0,} to "".
gcc version 8.1.1 20180712 (Red Hat 8.1.1-5) (GCC) on Fedora 28.
Sample warnings:
glusterd-utils.c:7234:41: warning: ‘.hostname’ directive output may be truncated writing 9 bytes into a region of size between 1 and 1024 [-Wformat-truncation=]
snprintf (key, sizeof (key), "%s.hostname", base_key);
^~~~~~~~~
glusterd-utils.c:7234:9: note: ‘snprintf’ output between 10 and 1033 bytes into a destination of size 1024
snprintf (key, sizeof (key), "%s.hostname", base_key);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
glusterd-snapshot.c:3090:65: warning: ‘/’ directive output may be truncated writing 1 byte into a region of size between 0 and 4095 [-Wformat-truncation=]
snprintf (snap_path, sizeof (snap_path) - 1, "%s/%s",
^
glusterd-snapshot.c:3090:17: note: ‘snprintf’ output between 2 and 4351 bytes into a destination of size 4095
snprintf (snap_path, sizeof (snap_path) - 1, "%s/%s",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
snap_mount_dir, snap_vol->snapshot->snapname);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
glusterd-statedump.c:28:45: warning: ‘%s’ directive output may be truncated writing up to 4095 bytes into a region of size 144 [-Wformat-truncation=]
snprintf (subkey, sizeof (subkey), "%s%d", key, index);
^~ ~~~
glusterd-statedump.c:28:9: note: ‘snprintf’ output between 2 and 4107 bytes into a destination of size 144
snprintf (subkey, sizeof (subkey), "%s%d", key, index);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
updates: bz#1193929
Change-Id: Ic721f27b28d1221c124b570e81c55528f5b7f3cd
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit aca7c14370809ec06c4fc0e426602d0465353417
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Tue Aug 7 15:28:13 2018 +0530
xlators: protocol: Fix deferencing pointer after free coverity issues
The pointer of type struct iobuf * is getting dereferenced after
getting freed by iobuf_unref function. Therefore, move this function
after all the dereferences of this pointer type.
Also, it is useful coding standard to have iobuf_unref just after
iobref_add. So, move iobref_add too.
Occurences found using Coccinelle script:
@@
identifier rsphdr_iobuf;
expression E;
identifier func;
@@
*iobuf_unref(rsphdr_iobuf);
...
*E = func(rsphdr_iobuf);
Fixes CID: 1390517, 1390278, 1388666, 1356588, 1356587 at [1].
and also some more occurences which were found using the above script but not
caught by Coverity.
[1]. https://scan6.coverity.com/reports.htm#v42388/p10714/fileInstanceId=84384920&defectInstanceId=25600709&mergedDefectId=1388666
Change-Id: I579e9d12698f14e9e24bc926c6efef16bac5c06c
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit 1cdb6f7ab23b375da34778e3c568723453d6d67d
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 16 14:15:27 2018 +0300
glusterfsd/src/glusterfsd.c : reduce size or re-scope message variable
The the error and/or message variable was either:
- Reduced in size - from 2048 bytes to 64 bytes, for example.
or
- Changed in scope - defined in a smaller scope.
Compile-tested only!
Change-Id: I20b9fb3407a74ba96fcbc7f05fcab534ff562c09
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 889408904b4e71d0a355161c988c1473c9ec8bc3
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Aug 20 14:06:51 2018 +0530
jbr : fix coverity issue in jbr.c
This fixes CID 1395069.
Change-Id: I0d2fa8fb04adf035c358841f43dea64f6aa8a1d8
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 0477c5e80943621bf0e441214094bb452019fd8c
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Fri Jul 27 14:52:21 2018 +0800
gfapi: Use inode_forget in case of unlink/rename objects
After unlink/rename, the nonexistent inode should be remove from inode table,
that's better than put to lru list.
Change-Id: I5a40df188f3f42a2c864cfb4404b22b288fdcc12
fixes: bz#1612750
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 6f9e4cf897ae3256e7e73eec20980738ace95870
Author: ShyamsundarR <srangana@redhat.com>
Date: Mon Aug 20 16:01:47 2018 -0400
cli: Fix invalid access of option_str variable
In function cli_cmd_volume_statedump_options_parse if
the wordcount of arguments is exactly 3, then option_str
would remain NULL, and hence the function will generate
a segmentation fault on the strstr check in its body.
This can be triggered when we run the command,
`gluster volume statedump <volname>`
The fix is to check if option_str is non-NULL before use
and also to pass in a duplicated empty string to the dict
key "options" when this is NULL.
Fixes: bz#1619423
Change-Id: Ic029ab60b64890d92c7a0876a638929495d3aa59
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 88c317b3e76e585a9904bb251aa41df21151b2be
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Jul 31 19:03:05 2018 +0530
geo-rep : fix few coverity issues in procdiggy.c
This patch fixes BAD_FREE at line number 75,105 and
UNUSED_VALUE at line number 108.
CID : 1274068
scan detail at [1].
[1] https://scan6.coverity.com/reports.htm#v42401/p10714/fileInstanceId=84384726&defectInstanceId=25600457&mergedDefectId=727233
Change-Id: I8dff42546204bf78c178c9dcaba534888c5354e9
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit df4e2da481c17c55c0356552aafba6de80f2979a
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Mon Aug 20 15:40:06 2018 +0530
write-behind: coverity fixes
Fixes CID: 1124360 1291740 1370918
Change-Id: I008c7ade8f9809d040f42f6d3e9af70fff2f3dc6
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit f9512b09e0cb7d1b2c4fdab489ddfe2ceadccf1e
Author: karthik-us <ksubrahm@redhat.com>
Date: Fri Aug 3 16:37:00 2018 +0530
cluster/afr: Fix bug-1586020-mark-dirty-for-entry-txn-on-quorum-failure.t
Problem:
In line #13 of the test case, it checks whether the file is present
on first 2 bricks or not. If it is not present on even one of the bricks
it will break the loop and checks for the dirty marking on the parent
on the 3rd brick and checks for file not present on the 1st and 2nd
bricks. The below scenario can happen in this case:
- File gets created on 1st and 3rd bricks
- In line #13 it sees file is not present on both 1st & 2nd bricks and
breaks the loop
- In line #51 test fails because the file will be present on the 1st brick
- In line #53 test will fail because the file creation was not failed on
quorum bricks and dirty marking will not be there on the parent on 3rd
brick
Fix:
Don't break from the loop if file is present on either brick 1 or brick 2.
Change-Id: I918068165e4b9124c1de86cfb373801b5b432bd9
fixes: bz#1612054
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 838931c4a45d80e94ca77f222fa972a93d3f99dd
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Tue Jul 31 07:22:49 2018 +0300
dict.c: ensure hash is done in the right place.
The hash should be done outside of locks, whenever is possible.
Change-Id: I4f8f7455702e0489a57105cf79668c7fca90e1c0
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 5a119d676263706c0036b142739dff883d39b8aa
Author: Shwetha Acharya <shwetha174@gmail.com>
Date: Fri Aug 3 15:12:45 2018 +0530
marker: FORWARD_NULL coverity fix
Problem:
Coverity false positive.
Solution:
Added a comment to ignore the false positive.
CID: 1325591
BUG: 789278
Change-Id: I95037efd12c059efcfc04f3c4c13f60c530150b4
Signed-off-by: Shwetha Acharya <shwetha174@gmail.com>
commit 2593ea03edd874dca0367e9d6b7d645b877590be
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Sat Aug 18 23:36:00 2018 +0530
quota: coverity fixes
Fixes CID: 1325638 1288766 1124357
Change-Id: I425f857d0d549da2dfaa6a6e6b8440cb14c21121
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit 1dbf128b2708bb5f5b4bd2c140bf5a71bda40e68
Author: karthik-us <ksubrahm@redhat.com>
Date: Fri Aug 3 15:55:18 2018 +0530
posix: Delete the entry if gfid link creation fails
Problem:
If the gfid link file inside .glusterfs is not present for a file,
the operations which are dependent on the gfid will fail,
complaining the link file does not exists inside .glusterfs.
Fix:
If the link file creation fails, fail the entry creation operation
and delete the original file.
Change-Id: Id767511de2da46b1f45aea45cb68b98d965ac96d
fixes: bz#1612037
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 1ff08a1664dcf484bd31917400dae4d988a2576d
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Sat Aug 18 00:06:58 2018 +0530
glusterd: fix some coverity issues
Fixes CID: 1241481 1241482 1274079 1274118 1274121 1274131 1274198
1274214 1274220 1274224 1394663 1394641 382454 1382453 1382449 1288095
Link: https://scan6.coverity.com/reports.htm#v42388/p10714/fileInstanceId=84772667&defectInstanceId=25770661&mergedDefectId=744716
Change-Id: Idaf434186231c8b0fff4b27c57fa23636a89c8a7
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit 00d9f0b2dd8d90721d319495c53f38fe89bc32d3
Author: Kotresh HR <khiremat@redhat.com>
Date: Sun Aug 19 13:53:15 2018 -0400
geo-rep: Cleanup unwanted code
Cleanup the Active/Passive logging code
which is redundant. With new status infra
implmented, this is redundant as every
status switch is logged by status infra.
fixes: bz#1619027
Change-Id: I0a6644cb998f3520e62a5189f21e4d66acc0e7c5
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 4395a8704779769b09af2835c23eadb25ccc183a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Wed Aug 8 22:28:39 2018 +0300
libglusterfs/src/common-utils.c: strncpy -> sprintf, remove dead code.
strncpy may not be very efficient for sort strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.
Instead, do a quick calc to see how much we really need and use
snprintf() to copy as much.
Also, move from CALLOC to MALLOC, as we are writing to this newly
allocated memory right away and add terminating null.
Lastly, removed some dead code. I did the same optimization as above
to it, only to find out no one is using it.
Compile-tested only!
Change-Id: Ib91b9a73c3d74c511fd067446b1bf6c2e1802687
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 3225e356c9ea2652b8f0130f0bdd41cb0e1e10b4
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sat Aug 4 16:24:18 2018 +0300
libguestfs/src/mem-pool.h: switch from calloc() to malloc()
If we are going to overwrite that allocated memory, why bother zero'ing it?
Only compile-tested!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I9c9d2d8d5ab3e706c747feb1920ecd417807f7fd
commit 9e193ab7054b2e6a5980e3ab0bdbdb13e2531663
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Aug 16 08:16:54 2018 +0530
gnfs: fix gcc warnings
gcc version 8.1.1 20180712 (Red Hat 8.1.1-5) (GCC) on Fedora 28.
Sample warnings:
1)
nfs3.c:292:54: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 143 and 250 [-Wformat-truncation=]
snprintf (buf, sizeof (buf), "(%s) %s : %s", \
^~~~~~~~~~~~~~
nfs3.c:295:35:
gfid); \
~~~~
2)
nlm4.c:145:54: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 143 and 250 [-Wformat-truncation=]
snprintf (buf, sizeof (buf), "(%s) %s : %s", \
^~~~~~~~~~~~~~
nlm4.c:148:35:
gfid); \
~~~~
acl3.c:128:54: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 143 and 250 [-Wformat-truncation=]
snprintf (buf, sizeof (buf), "(%s) %s : %s", \
^~~~~~~~~~~~~~
acl3.c:131:35:
gfid); \
~~~~
updates: bz#1193929
Change-Id: I760b8176e48f1f4628a1a98afa54a7994bdf13e9
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit ae0165c772e650b11b7b20b37cb265d758c308fc
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Aug 16 17:04:22 2018 +0530
snapshot/handshake: store description after strdup
problem:
During a handshake, when we import a friend data
snap description variable was just referenced to
dictionary value.
Solution:
snap description should have a separate memory allocated
through gf_strdup
Change-Id: I94da0c57919e1228919231d1563a001362b100b8
fixes: bz#1618004
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 33d1296c0d8e89bd9a74d669c53aaa641811ba06
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Sat Aug 18 19:40:46 2018 +0530
snapshot:Fix wrong dictionary key in snapshot cleanup code
Snapshot was designed to support multiple volume snapshot,
hence the volume name keys are labelled with volume count.
So the volume key should have a volume count appended with
key
Change-Id: I044d73fc86db0e662dc914669aecfb82a6476fb5
fixes: bz#1618004
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 9034f33d1e4c83c65495707d1420cc71ffbc57e7
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Aug 13 15:52:51 2018 -0700
mgmt/glusterd: Code cleanup in glusterd-volgen.c
This patch does the following:
1. Addresses CID: 1124815,124816,1124833,1291724,1325535,1325536,1357858
- by adding some null checks
- by handling return values from functions
- by using an appropriate buffer length in strncpy
2. Cleans up some commented code
Change-Id: I5a7079f34e3e460d5a6267734c3bc84bf4ad72f5
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 48c5c051a85bf0b8fe4a53c5d4a6a90cfbb5a9ed
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Sat Aug 18 01:25:34 2018 +0530
snapshot:Fail snapshot creation if an empty description provided
Snapshot description should have a valid string. Creating a
snapshot with null value will cause reading from info file
to fail with a null exception
Change-Id: I9f84154b8e3e7ffefa5438807b3bb9b4e0d964ca
updates: bz#1618004
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 5ac1016c7da8ec395d3c7c7bb635ff2ad9784c76
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Aug 18 11:39:03 2018 +0530
coverity: libglusterfs issues
CID: 1391415, 1274122, 1274201, 1382408, 1382437, 1389436
1288798, 1288106, 1288110
updates: bz#789278
Change-Id: I48c7a50f22f5f4580310040c66463d9f7dd26204
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 52bca682ddd58c6e0ecabcfbb7f1d3e7a37b313b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Jul 30 20:43:24 2018 +0300
dict.c: copy-pasta fix (dict -> data)
Change-Id: Ifda14a1cc01e0fa99ff20d710eccb43296e22955
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 120ab7f88003a7e55483758c4702174b21ad58c3
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jan 17 16:40:04 2017 +0530
performance/readdir-ahead: keep stats of cached dentries in sync with modifications
PROBLEM:
Stats of dentries that are readdirp'd ahead can become stale due to
fops like writes, truncate etc that modify the file pointed by
dentries. When a readdir is finally wound at offset corresponding to
these entries, the iatts that are returned to the application come
from readdir-ahead's cache, which are stale by now. This problem gets
further aggravated when caching translators/modules cache and continue
to serve this stale information.
FIX:
* Store the iatt in context of the inode pointed by dentry.
* Whenever the inode pointed by dentry undergoes modification, in cbk
of modification fop, update the iatt stored in inode-ctx to reflect
the modification.
* When serving a readdirp response from application, update iatts of
dentries with the iatts stored in the context of inodes pointed by
these dentries.
* Some fops don't have valid iatts in their responses. For eg., write
response whose data is still cached in write-behind will have zeroed
out stat. In this case keep only ia_type and ia_gfid and reset rest
of the iatt members to zero.
- fuse-bridge in this case just sends "entry" information back to
kernel and attr is not sent.
- gfapi sets entry->inode to NULL and zeroes out the entire stat
* There is one tiny race between the entry creation and a readdirp on
its parent dir, which could cause the inode-ctx setting and inode
ctx reading to happen on two different inode objects. To prevent
this, when entry->inode doesn't eqaul to linked_inode,
- fuse-bridge is made to send only "entry" information without
attributes
- gfapi sets entry->inode to NULL and zeroes out the entire stat.
Change-Id: Ia27ff49a61922e88c73a1547ad8aacc9968a69df
BUG: 1390050
Updates: bz#1390050
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 697153040f7cefe338a1310aa99f0dd130818cd9
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Aug 14 15:36:00 2018 -0700
debug/error-gen: Fix null deref and out of bounds read issues
Addresses CID: 1124492, 1124700, 1124701
Change-Id: If9916df1b0a4e67ad74fe0f6ea6f2544598ddacb
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 69932c16f7efcdd04bc27c5590dca27c87df147c
Author: Bhumika Goyal <bgoyal@redhat.com>
Date: Thu Aug 16 21:32:21 2018 +0530
block xlator: fix some coverity issues
Fixes CID: 1128916, 1128917, 1128919, 1192875
Change-Id: I5276b7db4a9650e70c335e25b9b4609a887233c0
updates: bz#789278
Signed-off-by: Bhumika Goyal <bgoyal@redhat.com>
commit f5cb491027ed859682fe0d932ab2591afa748a72
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Aug 14 11:49:50 2018 +0530
tests: Add thin-arbiter.rc for writing tests for thin-arbiter
fixes bz#1615789
Change-Id: I1f42e78fec5ddaf2a425dc4b82c9a20472aa146d
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 2126975bd4d07af33bff709510d84588ad308e89
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Aug 13 00:15:59 2018 -0700
features/changelog: close htime_fd in fini()
Addresses CID: 1325549
Change-Id: Ib041c7c288db6810b2e13a05a19ee894a47c9b05
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 092dc75a0d9d60de5c200abbf54b9740954fcb46
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Aug 13 12:20:07 2018 -0700
features/changelog: Fix missing unlocks
Addresses CID 1210981
Change-Id: Icd325588ae0639e09d924fdde171931dedd06ca6
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit ac24b2f4be17b2ca512697fc347875bd53c629be
Author: ShyamsundarR <srangana@redhat.com>
Date: Thu Jul 19 08:37:15 2018 -0400
doc: Add details around xlator categories
Updates: bz#1193929
Change-Id: I6446bbdd8025f333a3e855032c0c7709bf4ae4cd
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 1ef4d61bb75c94a39ca0a9eb3b5e7cbf1e31fb71
Author: Shwetha Acharya <shwetha174@gmail.com>
Date: Mon Jul 30 10:15:34 2018 +0530
locks: FORWARD_NULL coverity fix
Problem:
"dst" could be NULL.
Solution:
Added a condition check to avoid NULL pointer dereferencing.
BUG: 789278
Change-Id: I13ccf3234eda50a197f5fdfaf35b247589302582
Signed-off-by: Shwetha Acharya <shwetha174@gmail.com>
commit 2e270fb7f9977e4d07a8e97065f875ac6472e0f6
Author: Shwetha Acharya <shwetha174@gmail.com>
Date: Sat Jul 28 18:54:47 2018 +0530
posix: FORWARD_NULL coverity fix
Problem:
filler could be null.
Solution:
Modified the condition check to avoid NULL pointer dereferencing.
BUG: 789278
Change-Id: I0c3e29ede3c226295a9860ddcb3b432832c381dd
Signed-off-by: Shwetha Acharya <shwetha174@gmail.com>
commit b738cf21803615b3daee2e2bc6d5b98e34618f35
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Aug 10 02:39:55 2018 +0530
nfs-server-mount : fix coverity issues in mount3.c
Fixes CID 1389033, 1388767, 1288782.
Change-Id: I244f88b2ca8487f8926da45d886982558ad45c7a
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit ac80f7161e809a2d19c6b40bb34cf5d26e171ed8
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Aug 14 14:41:16 2018 +0530
meta : fix coverity in meta-helpers.c
This fixes CID 1214627 and 1257625.
updates: bz#789278
Change-Id: I6eb1ccf7b498948d1c41ff830e65437ef818cd55
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 11b6af163972f16768c5dab5b3276135553c893a
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Aug 13 11:33:47 2018 -0700
features/acl: Fix a possible null dereference
Addresses CID 1370952
Change-Id: I1f157dbede32e74e38aed8a1a162e38107f2628d
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 2bd5a25ff5fa5708a1963b1b5ec43b76b23b8ae7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Aug 16 10:03:22 2018 +0530
glusterd: coverity defects fix introduced by commit 1f3bfe7
Commit 1f3bfe7 stripped down the total size of certain path related variables
in glusterd_brickinfo_t which considered couple of new coverity defects.
Fix the following:
CID : 1394969 Destination buffer too small
CID : 1394968 Out-of-bounds access
Change-Id: Ibc30eac4680cc6c83bd89d248f1435cb6a3d1b75
updates: bz#789278
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit c5b0a59aa5efaa315472496cbb6b4c65eb05c03f
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Aug 15 01:59:04 2018 +0530
statedump : fix coverity issues
Comparing an array to null is not useful, the test will always evaluate as true.
Fixes CID 1325566 and 1389371.
updates: bz#789278
Change-Id: Id51f84cc62767a432de1d12851ae2669c1596a94
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit e1b01e782251f09888eb266ac52046224e8af710
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Aug 15 02:27:53 2018 +0530
jbr : fix coverity issues in jbr
This patch fixes CID 1357875 and 1357869.
Change-Id: Ief88523e5ad92a2c884ff1b85cd613992bba0dad
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 30b1f6abec8bccf11859e578e72d21b841fefbae
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jul 31 12:33:49 2018 +0530
glusterd: ignore importing volume which is undergoing a delete operation
Problem explanation:
Assuming in a 3 nodes cluster, if N1 originates a delete operation and
while N1's commit phase completes, either glusterd service of N2 or N3
gets disconnected from N1 (before completing the commit phase), N1 will
attempt to end up importing the volume which is in-flight for a delete
in other nodes as a fresh resulting into an incorrect configuration
state.
Fix:
Mark a volume as stage deleted once a volume delete operation passes
it's staging phase and reset this flag during unlock phase. Now during
this intermediate phase if the same volume gets imported to other peers,
it shouldn't considered to be recreated.
An automated .t is quite tough to implement with the current infra.
Test Case:
1. Keep creating and deleting volumes in a loop on a 3 node cluster
2. Simulate n/w failure between the peers (ifdown followed by ifup)
3. Check if output of 'gluster v list | wc -l' is same across all 3
nodes during 1 & 2.
Change-Id: Ifdd5dc39699120258d7fdd42fe2deb9de25c6246
Fixes: bz#1605077
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 2ecac123367b5deec66e6b5a0580ad76c722c494
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jul 30 17:15:35 2018 +0200
build: use standard PKG_CHECK_MODULES for libxml2 availability
In case the development parts of libxml2 are not installed, it was
required to re-run ./autogen.sh to cleanup the cached values for the
check. This is not nice towards users. By using the standard
PKG_CHECK_MODULES for libxml-2.0 the results of the check are not cached
and will be probed again when running ./configure.
Change-Id: I3c4586e5555a521be5d4fb61bdb873ae0317311a
Fixes: bz#1599219
Reported-by: Sachidananda Urs <surs@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 4d352a34971d2ef32635e30e65551359eef6aa55
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Aug 14 14:03:16 2018 +0530
trash : fix coverity issues in trash.c
This patch fixes CID : 1382380 and 1382428.
Change-Id: Ice3c8f5c2d97a0b541665bff744f32fbea9e294f
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit d33ca8e58a59829357d120ce0ff79812fbba1736
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Mon Aug 6 22:00:00 2018 +0530
libglusterfs: FORWARD_NULL coverity fix
Fixing FORWARD_NULL coverify errors in libglusterfs.
CID: 1391407, 1391410
BUG: 789278
Change-Id: I3d20523005e4418759c8a72620edff7c977d2d00
updates: bz#789278
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit cce241029084d25d13ca50c98c79ecf9205a783f
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Mon Aug 6 20:49:12 2018 +0530
cluster/ec: FORWARD_NULL coverity fix
Fixing FORWARD_NULL coverify errors with EC.
CID: 1394650
BUG: 789278
Change-Id: I52c99dac3483ca31a86cd7e3a959d4010b195f32
updates: bz#789278
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit c3626dd439cda92439fa08503f8321122306632e
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Aug 10 02:20:01 2018 +0530
uss : fix coverity issues
This patch fixes coverity issuse in snapview-server.c
CID : 1274119, 1325525
Scan details at [1].
[1]. https://scan6.coverity.com/reports.htm#v42401/p10714/fileInstanceId=84476369&defectInstanceId=25631967&mergedDefectId=778645
Change-Id: I825f09eabf84a2262a079c1f920a673727c5792b
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 9808123a50f814acf1eecdbf60bc75904550192e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Aug 10 14:54:56 2018 +0530
tests: Increase timeout to 30 minutes to handle lcov slowness
This script on a normal setup takes 15 minutes. With lcov it needs
to be increased. Considering we did 1.5X of the default $run_timeout
in run-tests.sh, I am doing the same for this script.
fixes bz#1614718
Change-Id: Ia571b33ff13deb8cbd8e48561769e876aa0b1aff
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit f91ab61d19cb553e0234624c8e3ff3fb5a283e16
Author: ShyamsundarR <srangana@redhat.com>
Date: Mon Jul 30 20:16:21 2018 -0400
contrib: Remove gf_mkostemp copied from GLibC
gf_mkostemp is borrowed from GLibC a long time back,
we now have mkostemp or mkstemp alternatives with all
distributions and versions that we care for.
As a result removing this from the contrib directory
and modifying the one instance that is still using the
same.
This is part of code cleanup as we cleaned up coverity
SECUR_TEMP errors.
Updates: bz#1193929
Change-Id: I1ad7863043cdb0845c53748f5a0522e767079130
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 9e46c2450b783172674e7d1eca9db91ccc8decaa
Author: ShyamsundarR <srangana@redhat.com>
Date: Mon Aug 13 15:11:15 2018 -0400
tests: Fix spurious failures in stats-dump.t test
The test fails to grep and find queue_size, in a brick stats
dump, having succesfully found aggr.* values in the same.
The troubleshot is that, the writer thread in io-stats, that
dumps this in a particular interval, truncates the file just before
the grep attempts to read the contents, and hence the failure.
The fix is to stop the dumper thread, and then wait for a couple
of seconds and then check the output, so that the thread writer
does not interfere with the test.
Fixes: bz#1615582
Change-Id: I29f95488a2ad693abe1dd525b1d87a9d1eee29a2
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 23aca52c5785eadacd5b8e7b3213b4f21e29339a
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Aug 14 11:44:54 2018 -0700
performance/md-cache: Use bitwise AND instead of logical AND
Addresses CID: 1394640
Change-Id: I1139222301569d17760df74624acd301594063b9
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 97cb4a7bf621ad260aad425bbcd1d7bb8858cd5a
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sat Jul 21 12:05:30 2018 +0300
contrib/xxhash: update to latest xxHash (0.6.5)
Update to latest xxHash, which is supposed to faster with small keys.
Specifically, updated to 3064d42e7d74b0921bdd1818395d9cb37bb8976a,
which is a bit higher than 0.6.5.
Compiled hopefully with namespace (XXH_NAMESPACE=GF_),
which allows to use XXH() funcs with no fear they'll 'leak'
from our library.
Only compile tested!
xxhsum is modified to display messages which was conflicting
with regression tests (TAP harness). So modified the
gfid2path_fuse.t and gfid2path_nfs.t to adhere to that.
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I35cea5cc93f338c1023ac2c9bc6d7d13225a967b
commit 5820047457a9b5eecf0f05d87fe524855efeeab7
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Aug 14 18:59:47 2018 +0530
mountbroker : fix coverity issue in glusterd-mountbroker.c
Fixes CID : 1124789
updates: bz#789278
Change-Id: I61c70f05e6377d7ddc8961556274714dd356a117
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 4887882168d89211bf743765217c43ed1abfc662
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Aug 12 18:40:25 2018 -0700
features/changelog: Fix a resource leak
Fixes CID 1382359
Change-Id: Iaafbdb9a45496091327e3dc9092e09148fa9a5c5
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 66a11d02afb5bac539313fbee8935402e5066d46
Author: Mark Mielke <mark.mielke@gmail.com>
Date: Mon Aug 13 23:54:34 2018 -0400
Bash integration script should namespace variables
In the original submitted script, it looks like there was effort
put into namespacing all global variables. However a few mistakes
remained.
GLUSTER_TOP_SUBOPTIONSx were defined, but TOP_SUBOPTIONSx were
referenced. This was likely an unrecognized defect in the
original code submission? These are now corrected to refer to
GLUSTER_TOP_SUBOPTIONSx.
FINAL_LIST, LIST, and TOP were leaked into all Bash shells and
used by the command completion functions. The most problematic
of these was TOP, which was declared with "-i" making it an
integer. This cause other code which used TOP to define a path
to fail like this:
$ bash
$ TOP=/abc
bash: /abc: syntax error: operand expected (error token is "/abc")
These are now qualified as GLUSTER_FINAL_LIST, GLUSTER_LIST, and
GLUSTER_TOP to reduce impact on scripts that might choose to use
these extremely common variable names.
Change-Id: Ic96eda8efd1f3238bbade6c6ddb69118e8d82158
Fixes: bz#1425325
Signed-off-by: Mark Mielke <mark.mielke@gmail.com>
commit cb4f029b36a62823d3a24e70df80f20d07f76624
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 20 14:27:57 2018 +0530
glusterd: fix gcc7 warnings
[sh]$ gcc --version
gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Warnings were of the type below:
xlators/mgmt/glusterd/src/glusterd-store.c:3285:33:
warning: ‘/options’ directive output may be truncated writing 8 bytes into a region of size between 1 and 4096 [-Wformat-truncation=]
snprintf (path, len, "%s/options", conf->workdir);
^~~~~~~~
xlators/mgmt/glusterd/src/glusterd-store.c:1280:39:
warning: ‘/snaps/’ directive output may be truncated writing 7 bytes into a region of size between 1 and 4096 [-Wformat-truncation=]
snprintf (snap_fpath, len, "%s/snaps/%s/%s", priv->workdir,
^~~~~~~
* Also changed some places where there was issues with key size
* Made sure all the 'char buf[SOMESIZE] = {0,};' are changed to 'char buf[SOMESIZE] = "";`
- In the files I changed
* Also edited coding standard to reflect that.
updates: bz#1193929
Change-Id: I04c652624ac63199cea2077e46b3a5def37c3689
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 46beecc57f323341e642772ff4ba44165c0f2cd4
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Aug 12 18:02:17 2018 -0700
mgmt/glusterd: Fix possible use after free in glusterd_op_ac_commit_op()
Fixes CID 1391418
Change-Id: I60ce6cd3b2528369f4dc1be81c0c15a1a806982a
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 45c9fea9b120b7f2f8eb5ab2ac9d593e274856ac
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Aug 12 17:37:10 2018 -0700
mgmt/glusterd: Fix buffer length to prevent a memory overrun
Fixes CID 1394647, 1394658
Change-Id: I30cf6e793919a08e0a3fe10622351b8316d7767c
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 7d71592a953e3262db22792e19f0b8235f71ecbb
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Aug 10 15:49:17 2018 +0530
glusterd: remove the unused databuf in rebalance structure
While it is a one line fix, it allows a significant unwanted memory
being allocated for defrag structure.
Updates: bz#1193929
Change-Id: Idda70d1d3dc0e7be56c35e872aa6edfaf752290d
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit b0b5f8d202a2564dca0b53b49ae92746caf3192b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Aug 2 21:48:34 2018 +0530
features/shard: Fix crash and test case in RENAME fop
Setting the refresh flag in inode ctx in shard_rename_src_cbk()
is applicable only when the dst file exists and is sharded and
has a hard link > 1 at the time of rename.
But this piece of code is exercised even when dst doesn't exist.
In this case, the mount crashes because local->int_inodelk.loc.inode
is NULL.
Change-Id: Iaf85a5ee3dff8b01a76e11972f10f2bb9dcbd407
Updates: bz#1611692
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit ef1014338bc34c05558d0ca2b755242535579420
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Aug 13 22:17:17 2018 +0530
cluster/dht: Fixed rebalanced files
An error caused skipped files to be counted as
rebalanced files.
Change-Id: I02333f099fb8b73ba953f41a2922021a1e4da7be
fixes: bz#1615474
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit bfe52cc1a56cf92e13f87a3ee727a665032e388e
Author: Susant Palai <spalai@redhat.com>
Date: Mon Aug 6 15:02:58 2018 +0530
cluster/dht: fix inode ref management in dht_heal_path
In dht_heal_path, the inodes are created & looked up from top to down.
If the path is "a/b/c", then lookup will be done on a, then b and so
on. Here is a rough snippet of the function "dht_heal_path".
<snippet>
if (bname) { ref_count
- loc.inode = create/grep inode 1
- syncop_lookup (loc.inode)
- linked_inode = inode_link (loc.inode) 2
/*clean up current loc*/
- loc_wipe(&loc) 1
/*set up parent and bname for next child */
- loc.parent = inode
- bname = next_child_name
}
out:
- inode_ref (linked_inode) 2
- loc_wipe (&loc) 1
</snippet>
The problem with the above code is if _bname_ is empty ie the chain lookup is
done, then for the next iteration we populate loc.parent anyway. Now that
bname is empty, the loc_wipe is done in the _out_ section as well. Since, the
loc.parent was set to the previous inode, we lose a ref unwantedly. Now a
dht_local_wipe as part of the DHT_STACK_UNWIND takes away the last ref leading
to inode_destroy.
This problenm is observed currently with nfs-ganesha with the nameless lookup.
Post the inode_purge, gfapi does not get the new inode to link and hence, it links
the inode it sent in the lookup fop, which does not have any dht related context
(layout) leading to "invalid argument error" in lookup path done parallely with tar
operation.
test done in the following way:
- create two nfs client connected with two different nfs servers.
- run untar on one client and run lookup continuously on the other.
- Prior to this patch, invalid arguement was seen which is fixed with
the current patch.
Change-Id: Ifb90c178a2f3c16604068c7da8fa562b877f5c61
fixes: bz#1610256
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 2d24ca7a96131d52ca97a476fef16c4bb1706a56
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Aug 13 00:06:05 2018 -0700
mgmt/glusterd: Fix a memory leak in volgen
Fixes CID 1325557
Change-Id: I5e33ae19ddf4c44a49a2b3b3dea0c739bc96d3a7
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 1a110f1a19e48c66914819a9ea32db93c180d89c
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Thu Aug 2 16:02:33 2018 +0300
All: remove memset() before sprintf()
It's not needed.
There's a good chance the compiler is smart enough to remove it
anyway, but it can't hurt - I hope.
Compile-tested only!
Change-Id: Id7c054e146ba630227affa591007803f3046416b
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit bf0f8c5798cf13f15b84ff24219175f06a4ae3d5
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Aug 13 13:06:20 2018 -0700
error-gen, locks: Fix a typo in comments
s/coverty/coverity/
Change-Id: Iac7c13176162eace4247dd3236373aa76d906380
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 8879a946329037c784e64f6c2ba7c1025cc287d9
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Aug 13 16:29:49 2018 +0530
tests: Fix for gfid-mismatch-resolution-with-fav-child-policy.t failure
This test was retried once on build
https://build.gluster.org/job/regression-on-demand-multiplex/174/
(logs for the first try is not available with this build)
Test case was failing in line #47 where it was was checking for the
heal count to be 0. Line #51 had passed that means file got the gfid
split brain resolved, and both the bricks had same gfids.
At line #54 it again failed which checks for the md5sum on both the
bricks. At this point the md5sum of the brick where the file got
impunged had the md5sum same as the newly created empty file. This
means the data heal has not happened for the file.
At line #64 enabling granular-entry-heal faild, but without the logs
it is not possible to debug this issue.
Change-Id: I56d854dbb9e188cafedfd24a9d463603ae79bd06
fixes: bz#1615331
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit edafe80d57a5431c12b085218a037df01031dfbf
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Aug 12 18:33:11 2018 -0700
libglusterfs: Fix a resource leak in graph.c
Fixes CID 1382367
Change-Id: I02678fc71716ab0046ea2ef437c6594a8a34a4fc
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit c4d58aba2ad8aa99fadfba39dbae21679181f289
Author: Susant Palai <spalai@redhat.com>
Date: Thu Jul 26 00:51:33 2018 +0530
cloudsync: fix -Werror=format-truncation error on gcc8
Here is the gcc8 warning:
libcloudsyncs3.c: In function ‘aws_download_s3’:
libcloudsyncs3.c:480:48: error: ‘%s’ directive output may be
truncated writing up to 4095 bytes into a region of size
1015 [-Werror=format-truncation=]
snprintf(buf, sizeof(buf), "https://%s/%s", priv->hostname, resource);
libcloudsyncs3.c:480:9: note: ‘snprintf’ output 10 or more bytes
(assuming 4105) into a destination of size 1024
snprintf(buf, sizeof(buf), "https://%s/%s", priv->hostname, resource);
Memleak:
It fixes a memleak as well where sign_req in fn: aws_form_request was
not freed. Adjusted the calloc size for sign_req as well to match with
the demand.
Test:
Have tested the local cloudsync regression test to validate the changes.
Smoke validation will be sufficient for the gcc8 warning fixes.
Fixes: bz#1609126
Change-Id: I1c537b30168f2e0b54862344a951843e86b0b488
Signed-off-by: Susant Palai <spalai@redhat.com>
commit cbcfb492923b3204f7b526ee613cea3c603cda74
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Aug 8 10:30:31 2018 +0530
tests: fix brick check orders
fix brick checks for validating-server-quorum.t & quorum-validation.t
...and make brick_up_status_1 function more generic.
Also fix a timing issue in
bug-1482023-snpashot-issue-with-other-processes-accessing-mounted-path.t
Change-Id: I797ef4cec5b160aafa979bae7151b1e99fcb48ac
Updates: bz#1603063
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 487461b7a7eba6ed3a50f9dcfba41840f32b51a2
Author: Prashanth Pai <ppai@redhat.com>
Date: Fri Aug 3 10:20:08 2018 +0530
posix: Mark 'shared-brick-count' as settable
updates: #302
Change-Id: I9c1b9c9751c21866b074ac5d3ef15a58ae7aa707
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit 90b4db79af88a6ed925e066fe9b5aa00936f2947
Author: Nigel Babu <nigelb@redhat.com>
Date: Wed Aug 8 15:22:05 2018 +0530
Fix a grammar error in the logs
Change-Id: Ie4fe18d5094c051fa20de71f7fc841085cc6aaee
Fixes: bz#1614142
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit 114e4a094bdbae61b3db5ec2ab2091aaa2a1f7f9
Author: ShyamsundarR <srangana@redhat.com>
Date: Mon Aug 6 19:40:30 2018 -0400
coverity: last of the secure temp fixes
Coverity ignore directive is not working if the comment is
split across lines (or has an empty line at the end.
This can be seen in this report:
https://download.gluster.org/pub/gluster/glusterfs/static-analysis
/master/glusterfs-coverity/2018-08-06-b982e09f/html/1
/384glusterfsd-mgmt.c.html#error
In other places the same pattern has avoided coverity from
flagging off the same call, except here.
Updates: bz#789278
Change-Id: Ic35ff0fc91d0a42904630728ef7c18215aa277f3
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 1d161b4c61727dc6397e3e16954912176c46703a
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sun Aug 12 15:33:29 2018 +0530
tests/quick-read/bug-846240.t: fix a wrong test
Earlier this test did following things on M0 and M1 mounted on same
volume:
1 create file M0/testfile
2 open an fd on M0/testfile
3 remove the file from M1, M1/testfile
4 echo "data" >> M0/testfile
The test expects appending data to M0/testfile to fail. However,
redirector ">>" creates a file if it doesn't exist. So, the only
reason test succeeded was due to lookup succeeding due to stale stat
in md-cache. This hypothesis is verified by two experiments:
* Add a sleep of 10 seconds before append operation. md-cache cache
expires and lookup fails followed by creation of file and hence append
succeeds to new file.
* set md-cache timeout to 600 seconds and test never fails even with
sleep 10 before append operation. Reason is stale stat in md-cache
survives sleep 10.
So, the spurious nature of failure was dependent on whether lookup is
done when stat is present in md-cache or not.
The actual test should've been to write to the fd opened in step 2
above. I've changed the test accordingly. Note that this patch also
remounts M0 after initial file creation as open-behind disables
opening-behind on witnessing a setattr on the inode and touch involves
a setattr. On remount, create operation is not done and hence file is
opened-behind.
Change-Id: I739f255e0a62ff0024f0824dad3539974955df99
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1615096
commit 607b2eaff17ee62cae345d2b77cfea4500196c15
Author: karthik-us <ksubrahm@redhat.com>
Date: Fri Aug 10 15:37:15 2018 +0530
cluster/afr: Fix bug-1433571-undo-pending-only-on-up-bricks.t
Problem:
The test case was checking for the entry pending marker reset
on the root after performing client side lookup at line #60-63.
But sometimes the entry heal was not getting completed immediately.
Fix:
Wait for the entry heal to complete before checking the changelog.
Change-Id: I42fde21b04a126ab044ce58373a996d72f125d96
fixes: bz#1614730
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 82705751d7bda9ba9e0270fcca1c35d92897d695
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Aug 12 11:43:36 2018 +0530
tests: potential fixes to bugs/replicate/bug-1408712.t
See BZ for details.
Change-Id: I2cc2064f14d80271ebcc21747103ce4cee848cbf
fixes: bz#1615078
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit aad78c315c3c8e65944412b2ecb89ad2cb274aee
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Aug 13 12:03:07 2018 +0530
tests: fix replace-brick-self-heal.t failure
Please see BZ for details.
Change-Id: Id9273432874bc6a452ac96b2b8c7a61ea6c5b98d
Fixes: bz#1615239
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit c76fac5a6a917b1235b633d8a7570424038f9b1b
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Jul 31 14:52:51 2018 +0530
gfapi : Handle the path == "" glfs_resolve_at
Currently there is no check for path = "" in glfs_resolve_at.
So if application sends an empty path, then the function resolves
into the parent inode which is incorrect. Plus modified possible
of "path" with "origpath" in the same function.
Change-Id: Ie5ff9ce4b771607b7dbb3fe00704fe670421792a
fixes: bz#1610236
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit 4db4e090f77551e8b9269f9b38ade9adc32ae16c
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sat Aug 11 19:18:32 2018 +0530
performance/quick-read: handle rollover of generation counter
Change-Id: I37a6e0efda430b70d03dd431c35bef23b3d16361
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1512691
commit 85fb48889628f4926182d3223fbdc4fa29b3cc31
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun Aug 12 15:25:21 2018 +0530
tests: fix tests/bugs/shard/configure-lru-limit.t
Check for the bricks to be up before attempting to mount.
Change-Id: I1224908137016df3007f4467aa9760967ce0694d
Fixes: bz#1615092
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 45c072ffa743f8c4e64100376e654ecca6000250
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Aug 10 12:44:48 2018 +0530
tests: potential fixes for tests/basic/afr/add-brick-self-heal.t
Please see bug description for details.
Change-Id: Ieb6bce6d1d5c4c31f1878dd1a1c3d007d8ff81d5
fixes: bz#1614654
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 21b8de7bd619ff323fddcd979ab6f5e334221334
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Aug 10 08:14:14 2018 -0400
geo-rep: Fix deadlock during worker start
Analysis:
Monitor process spawns monitor threads (one per brick).
Each monitor thread, forks worker and agent processes.
Each monitor thread, while intializing, updates the
monitor status file. It is synchronized using flock.
The race is that, some thread can fork worker while
other thread opened the status file resulting in
holding the reference of fd in worker process.
Cause:
flock gets unlocked either by specifically unlocking it
or by closing all duplicate fds referring to the file.
The code was relying on fd close, hence a reference
in worker/agent process by fork could cause the deadlock.
Fix:
1. flock is unlocked specifically.
2. Also made sure to update status file in approriate places so that
the reference is not leaked to worker/agent process.
With this fix, both the deadlock and possible fd
leaks is solved.
fixes: bz#1614799
Change-Id: I0d1ce93072dab07d0dbcc7e779287368cd9f093d
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 492cf4e2c0ed98b7069cec586b89a908ce0c7ae3
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Aug 10 09:12:05 2018 +0530
glusterd: compare friend data within mutex
During friend handshake if the glusterd receives more than one friend
updates, it might very well become possible that two threads would end
up working on two different volinfo references and glusterd might end up
updating the store with a old volinfo reference. While debugging
glusterd crash from validating-server-quorum.t test file from the
line-coverage regression the same was observed.
Solution is to run glusterd_compare_friend_data under a mutex.
Test:
As the crash was more visible in the line-coverage run (given lcov does
some instrumentation and exposes the races), 6 manual lcov runs were
triggered starting from https://build.gluster.org/job/line-coverage/443
to https://build.gluster.org/job/line-coverage/449/ and no crash was
observed from validating-server-quorum.t
Change-Id: I86fce473a76fd24742d51bf17a685d28b90a8941
Fixes: bz#1603063
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 2916ed826d631afa10362163c8c323a94fdb7773
Author: ShyamsundarR <srangana@redhat.com>
Date: Sat Aug 11 13:21:36 2018 -0400
tests: Fix cleanup routine for some mux tests
Some of the mux tests, set a trap to catch test exit and
call cleanup. This will cause cleanup to be invoked twice
in case the test times out, or even otherwise, as include.rc
also sets a trap to cleanup on exit (TERM and others).
This leads to the tarballs generated on failures for these
tests to be empty and does not aid debugging.
This patch corrects this pattern across the tests to the
more standard cleanup at the end.
Fixes: bz#1615037
Change-Id: Ib83aeb09fac2aa591b390b9fb9e1f605bfef9a8b
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 15c47e12aaada65d5a4b401b0436f0b4f63373b6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Aug 10 12:46:20 2018 +0530
Make sure EXPECT_WITHIN executes the statement multiple times
When we pass a command to be executed in EXPECT_WITHIN and we use ``
the value is passed by value, so if the first execution gives a result
that is different from the expected value, EXPECT_WITHIN test will
fail because the command will not be re-evaluated. Changed the
expression with `` to a function. Added sleep(3) in afr.c for
reconfigure to both RC and re-test after the change.
fixes bz#1614662
Change-Id: I3bc8a75b996729261aa48067f6ed8da9c6273b13
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 9c1f9fd7e3b2f4f4fb029c3a5bc9de1405c3bbe0
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Sat Aug 4 12:05:03 2018 +0530
glusterd: Compare volume_id before start/attach a brick
Problem: After reboot a node brick is not coming up because
fsid comparison is failed before start a brick
Solution: Instead of comparing fsid compare volume_id to
resolve the same because fsid is changed after
reboot a node but volume_id persist as a xattr
on brick_root path at the time of creating a volume.
Change-Id: Ic289aab1b4ebfd83bbcae8438fee26ae61a0fff4
fixes: bz#1612418
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 6333e7b7913d3202a2ad908dc6b22ed66f71c477
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Wed Aug 8 08:17:28 2018 +0530
core: Update condition in get_xlator_by_name_or_type
Problem: Sometimes client connection is failed after throwing
error "cleanup flag is set for xlator Try again later".
The situation comes only after get a detach request but
the brick stack is not completely detached and at the same time
the client initiates a connection with brick
Solution: To resolve the same check cleanup_starting flag in get
xlator_by_name_or_type, this function call by server_setvolume
to attach a client with brick.
Change-Id: I3720e42642fe495dd05211e2ed2cb976db9e231b
fixes: bz#1614124
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit c1846f0430ccea61dd8cc270fb7be529fb29a617
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Aug 3 20:50:43 2018 +0530
tests: kill_brick should wait for brick status to become offline
Change-Id: I52e8eec7f334af37de433c444f4ddfc876fa56cc
Fixes: bz#1614088
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit e18e867010ca0304a5558e34b8a2b915bf4359b6
Author: ShyamsundarR <srangana@redhat.com>
Date: Wed Aug 8 18:29:01 2018 -0400
tests: Add ability to preserve older tarball for retried tests
When a test is retried, the cleanup directives overwrite the
older tarball with the latest one, thus losing the logs from
the failed run.
This patch changes run-tests.sh to rename the older tarball
when retrying a test, thus preserving the same.
The tarball is renamed using a time stamp and optionally a
trailing sequence number, in case the test fails within the
very second. Although the sequence # is not strictly required
as we retry only once, it provides a defence for any future
enhancements to the same.
Fixes: bz#1614062
Change-Id: I9afe486b0b6f6a26f2ad0642e38bc0ba15b3ecc9
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 3a606667b676622181eb1d23e8be4627386b1e7b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Aug 8 15:26:42 2018 +0530
tests: Set heal-timeout to 5 seconds
Shd keeps doing heals in a loop until it heals at least one entry in the
previous run. A heal is termed successful only if it heals both metadata and
entry/data heal i.e. the entry needs to be completely healed by just that healer.
In tests/basic/afr/granular-esh/replace-brick.t test, brick-0 is old and brick-1
is new. After replace-brick only root-gfid will be present in brick-0's index
1) shd-thread corresponding to brick-0 does metadata heal, this creates
root-gfid in brick-0's 'dirty' index.
2) Both healer threads corresponding to brick-0 and brick-1 now try to heal
root-gfid and brick-1 gets the heal-domain lock. brick-0's shd-thread will
experience a failure and it goes back to waiting for 10 minutes
(cluster.heal-timeout).
3) When brick-1's healer-thread completes healing root-gfid it creates 5 files
which create indices in brick-0, so until brick-0 doesn't trigger one more
heal, heal won't happen. $HEAL_TIMEOUT is set at 120 seconds, which is lesser
than cluster.heal-timeout, so decreasing this to 5 seconds so that the next
heal is triggered which will do the heals.
fixes bz#1613807
Change-Id: I881133fc28880d8615fbc4558a0dfa0dc63d7798
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 573f8969ec5feacaab3ca94448f2237ae2ef289d
Author: ShyamsundarR <srangana@redhat.com>
Date: Thu Jul 26 07:09:40 2018 -0400
tests: Increase timeout for mpx restart crash test
In lcov based regression testing environments, all tests take
more time than what occurs in centos7 regressions. Possibly
due to code instrumentation for lcov purposes.
Due to this the test, bug-1432542-mpx-restart-crash.t constantly
times out. This patch increases the timeout for the same to enable
lcov tests to pass on a more regular basis.
It was also noted by Nithya that the test at times generated an
OOM kill on the regression machines. In order to reduce runtime
memory foot print of the tests, FUSE mounts are unmounted as
soon as the required test is complete.
Fixes: bz#1608568
Change-Id: I37f8d4b45807a69c52c7c7df4923c0fc33fab4e4
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 5f389e1a8330c0ad0b0bea0229c827217bc6590c
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Aug 7 10:25:49 2018 +0530
glusterd: more stricter checks of if brick is running in multiplex mode
While gf_attach () utility can help in detaching a brick instance from
the brick process which the kill_brick () function in tests/volume.rc
uses it has a caveat which is as follows:
1. It doesn't ensure the respective brick is marked as stopped which
glusterd does from glusterd_brick_stop
2. Sometimes if kill_brick () is executed just after a brick stack is
up, the mgmt_rpc_notify () can take some time before marking
priv->connected to 1 and before it if kill_brick () is executed, brick
will fail to initiate the pmap_signout which would inturn cleans up the
pidfile.
To avoid such possibilities, a more stricter check on if a brick is
running or not in brick multiplexing has been brought in now where it
not only checks for its pid's existance but checks if the respective
process has the brick instance associated with it before checking for
brick's status.
Change-Id: I98b92df949076663b9686add7aab4ec2f24ad5ab
Fixes: bz#1595320
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 9b3e44d0e940c7b0fce79d9497722a578805de5f
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Aug 2 07:30:46 2018 -0400
tests/bitrot: Fix tests/bitrot/bug-1373520.t
The test was failing with brick-mux enabled
intermittently. As the test depends on lookup
to recover file via heal, it's advisable to
disable all perf xlators. Hence doing the same.
fixes: bz#1611566
Change-Id: Ib7705e7951d53c435b8e390298164d73c6d71745
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 2ee5f681585672cfbc7e60a6d1aaac4e2f045f4a
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Aug 3 14:43:30 2018 +0530
MAINTAINERS: Add Xavier Hernandez as peer for shard xlator
Shard module never had a peer, although Pranith reviewed most
of the patches. Over the past few months, Xavier has reviewed
shard patches - both big and small - and also found some great
bugs in his reviews of some complex patches. Proposing that we
add him as peer for shard translator.
Change-Id: I29487052673f3738340764aa63bdd7586fb28def
fixes: bz#1612017
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 1ba045d744d0b6c17c359b7548189fb1dc025cc6
Author: ShyamsundarR <srangana@redhat.com>
Date: Mon Aug 6 13:55:08 2018 -0400
tests: Add timeout option to run-tests.sh
Added a '-t' timeout option to run-tests.sh, to be able to
set this to higher than the default 200 in case of lcov
based tests, as those take more time due to instrumentations
added by lcov.
Change-Id: Ibaf70e881bfa94f35e822124bcf9849b309e7cc1
Updates: bz#1608564
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 5f97053e41a779dc2df5c75ae9d3f13f48ab443b
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Jul 10 08:34:48 2018 +0530
performance/quick-read: don't update with stale data after invalidation
Once invalidated, make sure that only ops incident after invalidation
update the cache. This makes sure that ops before invalidation don't
repopulate cache with stale data. This patch also uses an internal
counter instead of frame->root->unique for keeping track of
generations.
Change-Id: I6b38b141985283bd54b287775f3ec67b88bf6cb8
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1512691
commit df18741fb2cdaf7b46c1e762e7828932d3a47f75
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Aug 2 10:17:28 2018 +0530
tests: fix online_brick_count function
online_brick_count should discard Bitrot and Scrubber daemon.
Change-Id: I301373ccdbeec1d1a5e6c6b137f48ed997f22556
Fixes: bz#1611103
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit ad18857a0078820e340e8da8bf5bd57a10d8bc3e
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Aug 2 22:55:35 2018 +0200
posix: prevent crash when SEEK_DATA/HOLE is not supported
Instead of not defining the 'seek' fop when it's not supported on the
compilation platform, we simply return EINVAL when it's used.
Fixes: bz#1611834
Change-Id: I253666d8910c5e2fffa3a3ba37085e5c1c058a8e
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 338a3b55978b8b92111c012c659277176519c5ec
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Aug 3 19:06:27 2018 +0530
Revert "performance/readdir-ahead: Invalidate cached dentries if they're modified while in cache"
This reverts commit 7131de81f72dda0ef685ed60d0887c6e14289b8c.
With the latest master, I created a single brick volume and some files
inside it.
[root@rhgs313-6 ~]# umount -f /mnt/fuse1; mount -t glusterfs -s
192.168.122.6:/thunder /mnt/fuse1; ls -l /mnt/fuse1/; echo "Trying
again"; ls -l /mnt/fuse1
umount: /mnt/fuse1: not mounted
total 0
----------. 0 root root 0 Jan 1 1970 file-1
----------. 0 root root 0 Jan 1 1970 file-2
----------. 0 root root 0 Jan 1 1970 file-3
----------. 0 root root 0 Jan 1 1970 file-4
----------. 0 root root 0 Jan 1 1970 file-5
d---------. 0 root root 0 Jan 1 1970 subdir
Trying again
total 3
-rw-r--r--. 1 root root 33 Aug 3 14:06 file-1
-rw-r--r--. 1 root root 33 Aug 3 14:06 file-2
-rw-r--r--. 1 root root 33 Aug 3 14:06 file-3
-rw-r--r--. 1 root root 33 Aug 3 14:06 file-4
-rw-r--r--. 1 root root 33 Aug 3 14:06 file-5
d---------. 0 root root 0 Jan 1 1970 subdir
[root@rhgs313-6 ~]#
Conversation can be followed on gluster-devel on thread with subj:
tests/bugs/distribute/bug-1122443.t - spurious failure. git-bisected
pointed this patch as culprit.
Change-Id: I1eb46f6c196f44fde8ce991840a0e724e6f50862
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1390050
commit f329f67ce9b35a8d5f2af9ca6147d203a4b1f1fe
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sun Jul 1 06:43:51 2018 +0530
performance/ob: stringent synchronization between rename/unlink and open
Issue 1:
========
open all pending fds before resuming rename and unlink
currently ob uses fd_lookup to find out the opened-behind. But,
fd_lookup gives the recent fd opened on the inode, but the oldest
fd(s) (there can be multiple fds opened-behind when the very first
opens on an inode are issued in parallel) are the candidates for fds
with pending opens on backend. So, this patch explictily tracks the
opened-behind fds on an inode and opens them before resuming rename or
unlink.
similar code changes are also done for setattr and setxattr to make
sure pending opens are complete before permission change.
This patch also adds a check for an open-in-progress to
ob_get_wind_fd. If there is already an open-in-progress,
ob_get_wind_fd won't return an anonymous fd as a result. This is done
to make sure that rename/unlink/setattr/setxattr don't race with an
operation like readv/fstat on an anonymous fd already in progress.
Issue 2:
========
once renamed/unlinked, don't open-behind any future opens on the same
inode.
Issue 3:
========
Don't use anonymous fds by default. Note that rename/unlink can race
with a read/fd on anonymous fds and these operations can fail with
ESTALE. So, for better consistency in default mode, don't use
anonymous fds. If performance is needed with tradeoff of consistency,
one can switch on the option "use-anonymous-fd"
Change-Id: Iaf130db71ce61ac37269f422e348a45f6ae6e82c
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1512691
commit 6a226690a290cbe8666cf6034d699706072fa87f
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Aug 1 15:09:08 2018 +0530
glusterd: Bricks of a normal volumes should not attach to gluster_shared_storage bricks
Problem: In a brick multiplexing environment, Bricks of a normal volume
created by user are getting attached to the bricks of a volume
"gluster_shared_storage" which is created by enabling the
enable-shared-storage option. Mounting gluster_shared_storage
has strict authentication checks. when we attach bricks of a normal
volume to bricks of gluster_shared_storage, mounting the normal
volume created by user will fail due to strict authentication checks.
Solution: We should not attach bricks of a normal volume to brick
process of gluster_shared_storage volume and vice versa.
fixes: bz#1610726
Change-Id: If1b5a2a02675789a2915ba480fb48c145449163d
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 200bf76509ec8b6753c750a0d55fc23b9abd94c5
Author: ShyamsundarR <srangana@redhat.com>
Date: Mon Jul 30 14:09:14 2018 -0400
coverity: Fix remaining SECURE_TEMP issues reported
Two pending SECURE_TEMP issues still exist in the coverity
reports, these are fixed by this patch.
In both instances (where functions actually seem to be
duplicates of each other) the need was for a FILE * and
not an fd. Applied the same pattern in both places as in
other parts of the code where mkstemp was used and later
a FILE * was created from the resulting fd for use.
Coverity report: https://download.gluster.org/pub/gluster/
glusterfs/static-analysis/master/glusterfs-coverity/
2018-07-30-4d3c62e7/html/
Issues numbered: 382, 383 (named SECURE_TEMP)
Further added tmpfile to the blacklist, so that future code
changes do not add the same, into symbol-check.sh.
Also corrected shellcheck errors in symbol-check.sh as a
result of updating the same.
Updates: bz#789278
Change-Id: I1d572a16ca5b5df2f597aeaa5f454fad34c8296e
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit baf5e4a0a10d71b10f612e3f06dd95a54e286ec5
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jul 31 10:27:03 2018 -0400
geo-rep/hook-script: Fix ssh/scp options
Always use ssh and scp with "-oPasswordAuthentication=no"
and "-oStrictHostKeyChecking=no" options. It might hang
the post script otherwise leading geo-rep setup failure
Also increased geo-rep timeout. Occasionally, it's taking
more time to reach Active/Passive status. Especially, the
first start after create.
fixes: bz#1610405
Change-Id: I9560d64dbe0edf5db73446a9fc97dda19b88d233
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit f113b61ad4c21c5ff003977dec3cf65d12c4efed
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sat Jul 14 18:17:47 2018 +0530
performance/open-behind: don't use anonymous fds for reads by default
anonymous fds interfere with working of read-ahead as read-ahead won't
be able to store its cache in fd. Also, as seen in bz 1455872,
anonymous fds also affect performance of large file sequential reads
as the cost of opening fd for each read on brick stack is
significant. So, have a proper fd which enables read-ahead to store
its cache and brick stack to reuse the fd during reads.
With this change test
tests/bugs/snapshot/bug-1167580-set-proper-uid-and-gid-during-nfs-access.t
fails consistently. The failure can also be seen with open-behind
off. bz 1611532 has been filed to track the issue with test. Thanks to
Rafi <rkavunga@redhat.com> for assistance provided in debugging test
failure.
Change-Id: Ifa52d8ff017f115e83247f3396b9d27f0295ce3f
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1455872
commit 6198ccaa53d1c9a290ae9895e8808ec7bf5415fd
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Jun 28 05:55:09 2018 +0530
performance/md-cache: update cache only from fops issued after previous invalidation
Invalidations are triggered mainly by two codepaths - upcall and
write-behind unwinding a cached write with zeroed out stat. For the
case of upcall, following race can happen:
* stat s1 is fetched from brick
* invalidation is detected on brick
* invalidation is propagated to md-cache and cache is invalidated
* s1 updates md-cache with a stale state
For the case of write-behind, imagine following sequence of operations,
* A stat s1 was issued from application thread t1 when size of file
was s1
* stat s1 completes on brick stack, but yet to reach md-cache
* A write w1 from application thread t2 extends file to size s2 is
cached in write-behind and response is unwound with zeroed out stat
* md-cache while handling write-cbk, invalidates cache
* md-cache receives response for s1, updates cache with stale stat
with size of s1 overwriting invalidation state
Fix is to remember when s1 was incident on md-cache and update cache
with results of s1 only if the it was incident after invalidation of
cache.
This patch identified some bugs in regression tests which is tracked
in https://bugzilla.redhat.com/show_bug.cgi?id=1608158. As a stop gap
measure I am marking following tests as bad
basic/afr/split-brain-resolution.t
bugs/bug-1368312.t
bugs/replicate/bug-1238398-split-brain-resolution.t
bugs/replicate/bug-1417522-block-split-brain-resolution.t
bugs/replicate/bug-1438255-do-not-mark-self-accusing-xattrs.t
Change-Id: Ia4bb9dd36494944e2d91e9e71a79b5a3974a8c77
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1512691
commit a790f5f3898e2c345635df9724166d21feba5aee
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 20 10:33:00 2018 +0530
coding-standard: add points on structure padding
This is a recommendation for users, and reviewers can take a point from this.
Updates: bz#1193929
Change-Id: Idcd778e42a886fd79b549da4927149a07573a20b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit e749815cd2903b62eb2cd07b94d78c9e73b812ed
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sun Jul 22 11:37:24 2018 +0530
performance/write-behind: synchronize rename with cached writes on src
rename response contains a postbuf stat of src-inode. Since md-cache
caches stat in rename codepath too, we've to make sure stat accounts
any cached writes in write-behind. So, we make sure rename is resumed
only after any cached writes are committed to backend.
Change-Id: Ic9f2adf8edd0b58ebaf661f3a8d0ca086bc63111
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1512691
commit 8057fed9cc5bde55391a3a97c25f9ccb93a32d6f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jul 26 21:47:24 2018 +0530
socket: Remove code duplication
While I was reading code, I saw that socket_submit_request()
and socket_submit_reply() are identical except for @a_byte and
the source of @msg object being different.
This patch moves all of the common code to a new function with
the differing vars passed as parameters by the callers.
Change-Id: I7a62ae72f10c34dc8de01b250d89a77ec5ab490d
fixes: bz#1608991
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit cd127336e86415877d9ff0d426345edd4cf9a324
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 20 11:04:01 2018 +0530
doc: keep just one copy of a coredump analysis
Keeping two copies of the files means, one would be out-of-date soon,
and users would always be confused about which one is the source of
truth.
Updates: bz#1193929
Change-Id: I568149732fdb9d282ccd583640eee9b9056963fd
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit f6bae7f95baf7c319beacee782a53038e4168a57
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jul 29 12:28:43 2018 +0200
rpm: do not build glusterfs-resource-agents on el6
glusterfs-resource-agents depends on glusterfs-server and this is not
available on el6 with the current Gluster releases. It is not possible
to install glusterfs-resource-agents on el6 without running into
dependency problems, so do not build the sub-packae at all.
Change-Id: Ibe08ad3a1b7882559b4e445603d0508b9282b755
Fixes: bz#1609551
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 8f40d9076c31b8d748e6879f8f8f815d411c786c
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Jun 27 14:51:37 2018 +0530
performance/write-behind: better invalidation in readdirp
Current invalidation of stats in wb_readdirp_cbk is prone to races. As
the deleted comment explains,
<snip>
We cannot guarantee integrity of entry->d_stat as there are cached
writes. The stat is most likely stale as it doesn't account the cached
writes. However, checking for non-empty liability list here is not a
fool-proof solution as there can be races like,
1. readdirp is successful on posix
2. sync of cached write is successful on posix
3. write-behind received sync response and removed the request from
liability queue
4. readdirp response is processed at write-behind.
In the above scenario, stat for the file is sent back in readdirp
response but it is stale.
</snip>
Change-Id: I6ce170985cc6ce3df2382ec038dd5415beefded5
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1512691
commit 5c7d4a69c88631cfec96109eebdad88db9039458
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jul 27 08:45:48 2018 +0000
build: remove bundled arg-standalone
libargp or argp-standalone is available on all commonly used
distributions. There is no need to bundle an unmaintained version of
argp-standalone in this repository anymore.
FreeBSD places the argp.h file in /usr/local/include when
argp-standalone is installed. This path is not added to CPPFLAGS by
default, so thats done in configure.ac as well.
Change-Id: I384a53ab0a008ec9d48fd83afeaf8fbc197e91ee
Fixes: bz#1609337
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 43a3ca38da82c8734fd0983771764763abdce7a0
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jan 17 16:40:04 2017 +0530
performance/readdir-ahead: Invalidate cached dentries if they're modified while in cache
PROBLEM:
Entries that are readdirp'd ahead can undergo modification in terms
of writes, truncates which could modify their iatts. When a readdir
is finally wound at offset corresponding to these entries, the iatts
that are returned to the application come from readdir-ahead's cache,
which are stale by now. This problem gets further aggravated when caching
translators/modules cache and continue to serve this stale information.
FIX:
Whenever a dentry undergoes modification, in the cbk of the modification fop,
a "dirty" flag (default 0) is set in its inode ctx. When it's time for
readdir-ahead to serve these entries, it will read the inode ctx and check
if the entry is "dirty", and if it is, set the entry's attrs to all zeroes,
as an indicator to fuse, md-cache etc not to cache these attributes.
Also there is one tiny race between the entry creation and a readdirp on its
parent dir, which could cause the inode-ctx setting and inode ctx reading to
happen on two different inode objects. To prevent this, fuse-bridge is made to
drop entries for which dentry->inode is not the same as linked inode,
in readdirp cbk.
Change-Id: If7396507632b5268442ca580473d5155fee9cbef
BUG: 1390050
Updates: bz#1390050
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 1f2d4d6fec8d6c7da7f90a5dbfed7a7d7b1f0ac3
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Fri Jul 27 08:42:00 2018 +0800
rpc: fix return value in rpc destroy
Change-Id: I73a113e2d40f508fd53b273a990a2371692c87bf
fixes: bz#1607689
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit a281fb8cca9e1e6035cface580c2b2c5e2529044
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Mon Jul 23 16:07:59 2018 +0800
rpc: add missing free of rpc->dnscache
Change-Id: I3fa97b99bf23459cf548205d75d2cc7936b2310e
fixes: bz#1607689
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit b78cc7bdb8b449fde9cd36b89f05e788f1506d74
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Mon Jul 23 15:27:41 2018 +0800
libgfapi: fix memory leak on old volume files
Fix missing free of fs->oldvolfile. This patch uses standard
calloc/realloc to allocate memory for vol file. As by the time fs struct
is destroyed, the THIS->ctx is already gone, that causes invalid memory
access.
Change-Id: I72ae19c76eb16e61f077714f7e52405fee721997
fixes: bz#1607689
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit f9168937a2ef084a4edd79f114c2a59337ffd4fc
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Mon Jul 23 18:15:58 2018 +0800
libgfapi: add missing unref of mgmt client in glfs_fini
Change-Id: I89cdf14cb9d822eaf7c01cf0b0220b423eb5b705
fixes: bz#1607689
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit fb6dece2780cab738e506e6bfbd743f8b301d13b
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jul 23 11:35:16 2018 +0200
build: remove uuid from contrib/
Bundling libuuid is not needed anymore, all current distributions
provide it now.
Some OS's provide their own uuid_*() functions in libc. These may not be
fully compatible with libuuid.so found on Linux systems. In that case,
either e2fsprogs-libuuid can be installed, or support for the native
uuid_*() functions can be added to libglusterfs/src/compat-uuid.h.
Change-Id: Icfa48caea81307a3bca549364969c2038911942b
Fixes: bz#1607319
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 8479ee53a657a31a9cfee945b3a745e533531af5
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jul 26 13:07:04 2018 +0000
build: rename event.h to gf-event.h
Newer FreeBSD versions (noticed with 10.3-RELEASE) provide a event.h
file that on occasion gets included instead of the libglusterfs file.
When this happens, 'struct event_pool' will not be defined and building
will fail with errors like:
autoscale-threads.c:18:55: error: incomplete definition of type 'struct event_pool'
int thread_count = pool->eventthreadcount;
~~~~^
autoscale-threads.c:17:16: note: forward declaration of 'struct event_pool'
struct event_pool *pool = ctx->event_pool;
^
This problem is caused by 'pkg-config --cflags uuid' that adds
/usr/local/include to the GF_CPPFLAGS. The use of libuuid is preferred
so that the contrib/uuid/ directory can be removed.
By renaming event.h to gf-event.h there is no conflict between the
different event.h files anymore and compiling on FreeBSD works without
issues.
Change-Id: Ie69f6b8a4f8f8e9630d39a86693eb74674f0f763
Updates: bz#1607319
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 43ab4b8c949701f9efae8083b80ed9c64cf7d332
Author: ShyamsundarR <srangana@redhat.com>
Date: Thu Jul 26 13:32:52 2018 -0400
stack: Reduce stack usage for local variables to store tmpfile names
This patch moves stack based PATH_MAX allocations for tmpfile
names, to heap allocated names instead. Reducing the impact on
stack space used and accruing benefits thereof.
Change-Id: I646d9cb091018de6768b3523902788fa2ba14d96
Updates: bz#1193929
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit a55b9f4339507b7ab30dc64115e9543eebae40a1
Author: ShyamsundarR <srangana@redhat.com>
Date: Tue Jul 24 20:23:14 2018 -0400
coverity: Ignore most of SECURE_TEMP issues
mkstemp as per the Linux man page, uses 0600 as the permission
bits when creating the file. This is hence safe and a Coverity
warning that should be ignored.
Further, we are mostly a multi-threaded program in all our daemons
and cannot set and unset umask at will in a multi-threaded
program, to address the coverity issue.
This change attempts to nudge coverity to ignore this warning,
using the pattern,
/* coverity[EVENT_TAG_NAME] ... */
<line of code that has the issue>
This commit is an experiment, if post merge the next coverity
report ignores these errors, the above pattern (as found using
an internet search) works and can be applied to certain other
warnings as well.
Change-Id: I73a184ce1a54dd9e66542952b1190a74438c826a
Updates: bz#789278
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit ee1896f618d855ce1dfb6872141d37f226d13697
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Jan 29 13:35:34 2018 +0530
rpc: merge ssl infra with epoll infra
Patch attempts to use the epoll infra for handling SSL connections
as well instead of the socket_poller() thread func.
This essentially makes priv->own_thread flag redundant.
SSL_connect()/SSL_accept() is now non-blocking which has done away
with the localised poll() in ssl_do(). So, ssl_do() has been updated
appropriately.
own_thread and coincidently socket_poller() thread for SSL processing
is now deprecated.
Change-Id: I1ce54c06ddb643c16baa143598e7e4fbf16bae0a
fixes: bz#1561332
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 15646cd4fd9cd7e9ff06b4fd0943dcbd6c4f94de
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Jul 12 13:29:48 2018 +0530
glusterd: Add multiple checks before attach/start a brick
Problem: In brick mux scenario sometime glusterd is not able
to start/attach a brick and gluster v status shows
brick is already running
Solution:
1) To make sure brick is running check brick_path in
/proc/<pid>/fd , if a brick is consumed by the brick
process it means brick stack is come up otherwise not
2) Before start/attach a brick check if a brick is mounted
or not
3) At the time of printing volume status check brick is
consumed by any brick process
Test: To test the same followed procedure
1) Setup brick mux environment on a vm
2) Put a breaking point in gdb in function posix_health_check_thread_proc
at the time of notify GF_EVENT_CHILD_DOWN event
3) unmount anyone brick path forcefully
4) check gluster v status it will show N/A for the brick
5) Try to start volume with force option, glusterd throw
message "No device available for mount brick"
6) Mount the brick_root path
7) Try to start volume with force option
8) down brick is started successfully
Change-Id: I91898dad21d082ebddd12aa0d1f7f0ed012bdf69
fixes: bz#1595320
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit b05e16c72595f67e1e25c211633534e9b99d8d12
Author: Nigel Babu <nigelb@redhat.com>
Date: Thu Jul 26 13:01:04 2018 +0530
maintainers: change in glusto ownership
As the project has matured, Vijay and Akarsha have stepped up
significantly. Nigel is stepping down to peer now that there are capable
people who will be actively focusing on Glusto.
Shwetha is no longer actively contributing and has therefore agreed to
step down from peer.
Change-Id: I089eb02857d2ea353e811cb8bdf71edda96fa041
Fixes: bz#1608684
commit 75990350b7089588951a5dc837bff5a5f0997230
Author: ShyamsundarR <srangana@redhat.com>
Date: Wed Jul 25 16:45:54 2018 -0400
sdfs: Fix missing NULL option list tremination
Option list for volume_options in sdfs was not NULL
terminated. This resulted in a crash when running in
lcov based builds.
This is rectified by this patch.
fixes: bz#1608566
Change-Id: I5d8730f1ae963ed6adf21d970e4921c5d5d92f62
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit a70d6df692937ce7fcebd436fc0231c871d51286
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jul 24 14:40:51 2018 -0400
georep: fix hard-coded paths in gsyncd.conf.in
This is part of the reason why we use autoconf (i.e. configure).
For an ordinary clone+autogen.sh+configure SBIN_DIR is
/usr/local/sbin; for an rpm or dpkg build it will be /usr/sbin.
I wonder how many more are lurking in our sources? /usr/libexec is
one that frequently bites us on Debian and Ubuntu, which don't have
/usr/libexec. (But it's all Linux, right?)
See https://bugzilla.redhat.com/show_bug.cgi?id=1601532
Reported-by: lohmaier+rhbz@gmail.com
Change-Id: I6523894416cc06236ea1f99529efd36e957bd98e
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 98a8dfc0b4a825a1bd032d87abf281013de2b0c7
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Jul 24 14:48:35 2018 +0530
rpc: rpc_clnt_connection_cleanup is crashed due to double free
Problem: gfapi client is getting crashed in rpc_clnt_connection_cleanup
at the time of destroying saved_frames
Solution: gfapi client is getting crashed because saved_frame ptr is
already freed in rpc_clnt_destroy.To avoid the same update
code in rpc_clnt_destroy
Change-Id: Id8cce102b49f26cfd86ef88257032ed98f43192b
fixes: bz#1607783
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit e11ed94b9b0136b3d4167e093c12b4ba49ebc28a
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Jul 24 14:27:02 2018 +0530
glusterd: Coverity issues with type FORWARD_NULL
This patch fixes coverity issues 102, 103, 112 and 119 from [1]
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2018-07-23-5fa004f3/html/
Updates: bz#789278
Change-Id: I99762eb0bcbd974a5250434777db63520f2ce2e6
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 338780917bf633840debd7639eff51c5d1518dd4
Author: Oshank Kumar <okumar@redhat.com>
Date: Tue Jul 24 16:26:18 2018 +0530
glusterd: Deadcode Coverity issue
This patch will fix coverity issue 74 from [1].
we are updating ret value line number 5011, and
immediately checking whether ret is having non
zero value at line number 5013.If ret is 0, then
only we continue to execute and we can reach line
number 5036. By the time we reach 5036, ret value
is always 0. So this block of code is redundant
here and removing it.
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2018-07-23-5fa004f3/html/
Updates: bz#789278
Change-Id: Ia6e8ba2936e350f0d29a9151ab786622f5e750db
Signed-off-by: Oshank Kumar <okumar@redhat.com>
commit 96a785119a870a8ea8a4c9974b60a3f086501fc2
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Jul 20 10:52:22 2018 +0530
features/shard: Make lru limit of inode list configurable
Currently this lru limit is hard-coded to 16384. This patch makes it
configurable to make it easier to hit the lru limit and enable testing
of different cases that arise when the limit is reached.
The option is features.shard-lru-limit. It is by design allowed to
be configured only in init() but not in reconfigure(). This is to avoid
all the complexity associated with eviction of least recently used shards
when the list is shrunk.
Change-Id: Ifdcc2099f634314fafe8444e2d676e192e89e295
updates: bz#1605056
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit a1b9da847f1abd64a7287f1d1887cd4532cb29f0
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sat Jul 21 04:27:12 2018 -0700
storage/posix: Avoid log flood in posix_set_parent_ctime()
posix_set_parent_ctime() unconditionally logs an error if consistent
time attributes is not enabled. This log does not add any value, prints
an incorrect errno & floods the log file.
Hence nuking this log message in this patch.
Change-Id: I82a78f2f8ce5ab518f8cdf6d9086a97049712f75
fixes: bz#1607049
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit c48a78738664f0e2a0bfd2ef7e40062b291d6dd6
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Jul 17 15:56:35 2018 +0530
geo-rep : fix possible crash
Problem : In 'glusterd_verify_slave' while tokenizing error message
we call 'strtok_r' and store return value in 'tmp' which
can be NULL. We are passing this 'tmp' as 1st argument to
'strcmp' which will lead to segmentation fault.
Solution : before calling 'strcmp' we should NULL check 'tmp'.
Change-Id: Ifd3864b904afe6cd09d9e5a4b55c6d0578e22b9d
fixes: bz#1602121
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 24279e08668c708ea5d9fb5a8347875e007f3636
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 14 13:33:09 2017 -0400
core (named threads): flood of -Wformat-truncation warnings with gcc-7.1
Starting in Fedora 26 which has gcc-7.1.x, -Wformat-trunction is enabled
with -Wformat, resulting in a flood of new warnings. This many warnings
is a concern because it makes it hard(er) to see other warnings that
should be addressed.
An example is at
https://kojipkgs.fedoraproject.org//packages/glusterfs/3.12.0/1.fc28/data/logs/x86_64/build.log
For more info see https://review.gluster.org/#/c/18267/
I can't find much (or good) documentation on the heuristics the
compiler uses for this warning. In the case of printing integer types
it appears it looks at the available space in the destination and the
range of values for the variable and/or its type.
To address the specific question about why 0x3ff versus 0xfff to mask
the value, either would suffice to hint to the compiler that the
printed value will fit in three characters. But the loop is from
0...1023 (or 0...0x3ff if you prefer) so I chose that as a more
"accurate" mask to use as it exactly matches the range of values of
the loop.
Fixes: bz#1492847
Change-Id: I6e309ba42159841131d8241bfc0566ef09e00aa9
commit 7dd8b0a2df7a659fefab253f09131a1f216d9b85
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Jul 16 17:03:17 2018 +0300
All: run codespell on the code and fix issues.
Please review, it's not always just the comments that were fixed.
I've had to revert of course all calls to creat() that were changed
to create() ...
Only compile-tested!
Change-Id: I7d02e82d9766e272a7fd9cc68e51901d69e5aab5
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 3a15ec789808b88e39f742631efa1b5b05d9025c
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Fri Jun 1 12:21:18 2018 +0530
quota: new volume set option to track of quota in GD2
quota enable as volume set needs a new option to keep track of it.
Bugzilla ID:1600812
Change-Id: Ib8d770936bafe859f80e717409bd861760090e59
fixes: bz#1600812
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
commit 3dd7cc47fcaece0e699b73d850b026c5d6e4cf0c
Author: Kotresh HR <khiremat@redhat.com>
Date: Sun Jul 15 15:03:40 2018 -0400
geo-rep: Fix issues with gfid conflict handling
1. MKDIR/RMDIR is recorded on all bricks. So if
one brick succeeds creating it, other bricks
should ignore it. But this was not happening.
The fix rename of directories in hybrid crawl,
was trying to rename the directory to itself
and in the process crashing with ENOENT if the
directory is removed.
2. If file is created, deleted and a directory is
created with same name, it was failing to sync.
Again the issue is around the fix for rename
of directories in hybrid crawl. Fixed the same.
If the same case was done with hardlink present
for the file, it was failing. This patch fixes
that too.
fixes: bz#1598884
Change-Id: I6f3bca44e194e415a3d4de3b9d03cc8976439284
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 2c80ba36a719b3dd6b610ee04066b989d0d0f8c2
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Sun Jul 15 12:20:04 2018 +0300
glusterd-quota.c: fix coverity warning (BAD_COMPARE)
See https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2018-07-13-1718f9c6/html/1/6glusterd-quota.c.html#error
Only compile tested!
Change-Id: Ief42f9fcdb02ad001bd39c4a6e27e7fa86fd2496
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 273bafc771d6a856f416bd5a1d793ad1fa267663
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sat Jul 14 18:01:30 2018 +0530
performance/read-ahead: stricter adherence to force-atime-update
Throwaway read-ahead cache in fstat only if force-atime-update is
set. Note that fstat flushes read-ahead cache only for atime
consistency. However if atime consistency is needed user is required
to set force-atime-update which updates atime on backend fs even
though application reads are served from read-ahead cache. So, if user
has not set force-atime-update, atime won't be accurate and there is
no point in flushing read-ahead cache in fstats. mounts
requiring atime consistency have to mandatorily set
force-atime-update.
Also note that normally kernel interspers reads with fstat. So,
read-ahead is not effective as fstats flush read-ahead-cache. Instead
it regresses performance due to wasted network reads. It is
recommended to turn off read-ahead if applications require atime
consistency.
This patch is aimed at applications which don't require atime
consistency. Without atime consistency required, read-ahead cache is
effective and increases performance of sequential reads.
Change-Id: I122bbc410cee96661823f9c4b934383495c18446
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1601166
commit dccbbc6884e69851a8c9c453ed8db40855fe8122
Author: Nigel Babu <nigelb@redhat.com>
Date: Thu Jul 5 15:55:48 2018 +0530
extras: Remove the prot_filter.py code
This code was meant to work with the protection xlator which was removed
in Nov 2016. Unfortunately, this file remained and should be removed as
well.
Change-Id: Ia6daa06542ebc8c6fb935c352cc19924f3bb3d8a
Fixes: bz#1598390
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit 03a726a9a9f22ae5f6b01b5b90c0ac9fa39b1ad2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sat Jul 14 10:05:41 2018 +0530
posix: check before removing stale symlink
BZ 1564071 complains of directories with missing gfid symlinks and
corresponding "Found stale gfid handle" messages in the logs. Hence
add a check to see if the symlink points to an actual directory before
removing it.
Note: Removing stale symlinks was added via commit
3e9a9c029fac359477fb26d9cc7803749ba038b2
Change-Id: I5d91fab8e5f3a621a9ecad4a1f9c898a3c2d346a
Updates: bz#1564071
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit ce7f639a9cd084923ee8b9a1d67255060b1ea349
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Jul 18 22:09:19 2018 +0530
cluster/dht: Set loc->gfid before healing attr
AFR takes inodelks when setting attrs. The loc->gfid
and loc->inode->gfid were both null when dht_dir_attr_heal
was called during a fresh lookup of an existing directory.
As the gfid is null, client_pre_inodelk asserts in the gfid
check.
We now set the loc->gfid before calling dht_dir_attr_heal.
Change-Id: I457f5a73fd301d97a03ca032587e73d4803298ac
fixes: bz#1602866
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 0f8f7b11bdee01c227ebae3c532689b69eae6b5c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Jul 17 20:35:42 2018 +0530
afr: switch lk_owner only when pre-op succeeds
Problem:
In a disk full scenario, we take a failure path in afr_transaction_perform_fop()
and go to unlock phase. But we change the lk-owner before that, causing unlock
to fail. When mount issues another fop that takes locks on that file, it hangs.
Fix:
Change lk-owner only when we are about to perform the fop phase.
Also fix the same issue for arbiters when afr_txn_arbitrate_fop() fails the fop.
Also removed the DISK_SPACE_CHECK_AND_GOTO in posix_xattrop. Otherwise truncate
to zero will fail pre-op phase with ENOSPC when the user is actually trying to
freee up space.
Change-Id: Ic4c8a596b4cdf4a7fc189bf00b561113cf114353
fixes: bz#1602236
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit f136e165060e78caadc59cfb1e7170052c1f29ee
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Jul 16 15:59:36 2018 +0530
glusterd: memory leak in get-state
Problem: gluster get-state command is leaking the memory when
geo-replication session is configured.
Cause: In glusterd_print_gsync_status(), we are trying to get
reference to the keys of gsync_dict. The references to keys of
gsync_dict are stored status_vols[i]. status_vols[i] are
allocated with a memory of size of gf_gsync_status_t.
Solution: Need not to use a array of pointers(status_vals), using
a pointer to hold the reference to a key of gsync_dict is sufficient.
Followed the below steps for testing:
1. Configured geo-rep session
2. Ran gluster get-state command for 1000 times.
Without this patch, glusterd's memory was increasing significantly
(around 22000KB per 1000 times), with this patch it reduced (1500KB
per 1000 times)
fixes: bz#1601423
Change-Id: I361f5525d71f821bb345419ccfdc20ca288ca292
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit f213c6d923e9eae2d3f53de1b186a5b10b6a0a0a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jul 17 07:32:31 2018 -0400
build/core: location of xattr.h
starting with libattr-devel-2.4.48-1 in Fedora 28 <attr/xattr.h> has
been removed from the package.
On Fedora, RHEL/CentOS, and SUSE, the glibc-headers package has provided
a near identical file, <sys/xattr.h>, in all the releases that we care
about.
On Debian, libc6-dev provides <sys/xattr.h> all the way back to 8/Jessie
and presumably all Ubuntu derivatives since then.
Note that on Debian the sys headers are installed in
/usr/include/$DEB_HOST_GNU_TYPE/sys/...
Change-Id: Id07c4b225bdaa6556bd54772604e75b8f346fb60
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 8b0f1423ed502c01de383868b404a15319ad0e97
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Mon Jul 16 16:39:02 2018 +0800
dht: remove useless argument from dht_iatt_merge
The last using of the subvol argument has been removed at 4e1ec35ef4f7
("core: fill 'ia_ino' from 'ia_gfid' in 'storage/posix' ......")
7 years ago (2011-06-16).
Change-Id: I9788d79e2e40cc153cf2960e28c7c1c1033dc8f7
fixes: bz#1601683
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit c68a64a6bca4754a826a3cdce1b86f7b41b7e090
Author: dkhandel <dkhandel@localhost.localdomain>
Date: Mon Jul 9 19:46:40 2018 +0530
Add the tab space in the list of BROKEN_TESTS environment variable
Fixes: bz#1598325
Change-Id: I4c14514d33288fd33cca903853c6d5e4f70bd441
Signed-off-by: Deepshikha Khandelwal <dkhandel@redhat.com>
commit f5a790e8941db1ddb3ee855ff3c81375b89401b7
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Jul 16 15:23:52 2018 +0530
dht: delete tier related internal xattr in dht_getxattr_cbk
Use dict_del instead of GF_REMOVE_INTERNAL_XATTR.
For problem and fix related information see here -
https://review.gluster.org/20450.
This patch have some modification as requested by reviewers on already
merged patch : https://review.gluster.org/20450.
Change-Id: I50c263e3411354bb9c1e028b64b9ebfd755dfe37
fixes: bz#1597563
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit fc870acaebba57576147ecbf12ae1c8bc0ffa82f
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Jul 15 19:42:55 2018 +0530
run-tests.sh: provide option to write 'failure' output to a file
Change-Id: I42f5e0f3513ba758a09b1a7330e49fc3c8fc218e
updates: bz#1600963
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 035eae41f8660e95d27e66ee078cfe8f8183d29e
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Thu Jul 12 14:02:03 2018 +0530
core: dereference check on the variables in glusterfs_handle_brick_status
problem: In a race condition, the active->first which is supposed to be filled
is NULL and trying to dereference it crashs.
back trace:
Core was generated by `/usr/sbin/glusterfsd -s bxts470192.eu.rabonet.com --volfile-id prod_xvavol.bxts'.
Program terminated with signal 11, Segmentation fault.
1029 any = active->first;
(gdb) bt
Change-Id: Ia6291865319a9456b8b01a5251be2679c4985b7c
fixes: bz#1600451
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
commit 3ea3197ebfa6099bc51088b80d748b5169010c11
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Jul 9 13:32:26 2018 +0300
tier: Move time string formatting
There is no need to format the time, unless ret is true.
I don't think there's a reason to allocate memory for
those struct and char array unless we are formatting
either (But I'm not sure what the code convention is - are we
ok with 'local' variable declarations?)
Only compile-tested.
Change-Id: I9feb09871943764bd76bdfc9ac6ca506f329aac1
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit 3a4eac310d497a8975f86e784e355fda9257747b
Author: Yaniv Kaul <ykaul@redhat.com>
Date: Mon Jul 16 11:25:41 2018 +0300
glusterd-store: fix coverity warning
The same variable 'len' was used both in the macros and the functions.
(Introduced as part of commit 6dc5dfef819cad69d6d4b4c1c305efa74236ad84 ?)
Change-Id: If434999d6470067f8a1e501c8e132561e8cd81ef
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
commit d3188edfcf2806d1b337825266d4862a319c3e3a
Author: Nigel Babu <nigelb@redhat.com>
Date: Mon Jul 16 15:06:00 2018 +0530
testing: Fix the build environment
The build environment for FB is vastly different from us. This change
will match the config to what we use for our regression testing
Change-Id: Ib3584a02dbffb75892f2cbeebcbf51cc3aff3eb6
Fixes: bz#1601390
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit b06b8a4b746798733d43e4b672e35318aeb7fe05
Author: karthik-us <ksubrahm@redhat.com>
Date: Tue Jun 5 15:57:16 2018 +0530
cluster/afr: Mark dirty for entry transactions for quorum failures
Problem:
If an entry creation transaction fails on quprum number of bricks
it might end up setting the pending changelogs on the file itself
on the brick where it got created. But the parent does not have
any entry pending marker set. This will lead to the entry not
getting healed by the self heal daemon automatically.
Fix:
For entry transactions mark dirty on the parent if it fails on
quorum number of bricks, so that the heal can do conservative
merge and entry gets healed by shd.
Change-Id: I56448932dd409b3ddb095e2ae32e037b6157a607
fixes: bz#1586020
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 482b0726e29c0c2280213416ff9ee44b5b5e5cca
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Jul 3 13:58:23 2018 +0530
dht: delete tier related internal xattr in dht_getxattr_cbk
Problem : Hot and Cold tier brick changelogs report rsync failure
Solution : georep session is failing to sync directory
from master volume to slave volume due to lot
of changelog retries, solution would be to ignore tier
related internal xattrs trusted.tier.fix.layout.complete and
trusted.tier.tier-dht.commithash in dht_getxattr_cbk.
Change-Id: I3530ffe7c4157584b439486f33ecd82ed8d66aee
fixes: bz#1597563
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit fe8a4ba7151184e802c4855fdaf0adaa69c4dcd5
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 13 14:45:31 2018 +0530
logging: check for fmts not being NULL
this fix is just a review of possible SIGSEGV issues in line 714
as per crash report at the bug:
```
08:35:25 Program terminated with signal 11, Segmentation fault.
08:35:25 #0 0x00007f4ebb491c5c in gf_time_fmt (dst=0x7f4eb1ff9a90 "", sz_dst=256, utime=1531470915, fmt=0)
at /home/jenkins/root/workspace/centos7-regression/libglusterfs/src/common-utils.h:714
```
fixes: bz#1600878
Change-Id: I160c391f8ac1a3456e59103d293b24e0e3fae718
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit a0637bf16f99c9c526f10e72d697f01e0cbf863a
Author: Vitaly Lipatov <lav@etersoft.ru>
Date: Thu Jul 12 22:02:18 2018 +0300
add check if no matching password record was found with getpwuid_r(uid)
Change-Id: Iae712828ee656008faf5fe2bc4e6f96fa12ea4cb
fixes: bz#1600687
Signed-off-by: Vitaly Lipatov <lav@etersoft.ru>
commit 09c1a7eae03fe68c5953b2078dd9e240719e1b85
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Tue Jul 10 14:21:35 2018 +0530
glusterd: To find a compatible brick ignore diagnostics.brick-log-level option
Problem: glusterd start a volume as a separate process instead of
attaching with the already running process if volume option has
different brick-log-level. There is no functionality impact on a brick
if the option has different brick-log-level so glusterd
should attach a brick with the already running process.
Solution: Ignore brick-log-level option in unsafe_option
BUG: 1599628
Change-Id: I72638ff2026fcd9332bc38e1144b1ef4a708820b
fixes: bz#1599628
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 54c4f8b1e30debcd0b7a81eff834610ccbde4446
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 13 13:52:12 2018 +0530
tests/geo-rep: increase the timeout
since some time, geo-rep tests were in the border of 180-190 seconds to
complete. As actual test timeout is 200 seconds by default, giving
these tests some buffer time to complete properly.
updates: bz#1193929
Change-Id: I9f501a02b52585dff7d0473824bdbb229e124278
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit ecf720875b6b05d51cd722ef9f76c79c5db887c5
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jul 2 13:29:53 2018 -0400
tests/geo-rep: Add rsnapshot and hardlink rename test case
1. rsnapshot creates a I/O pattern which involves
create, rename, symlink, hardlink in specific
order.
2. Hardlink rename on master with source unlinked use case
fixes: bz#1597540
Change-Id: Iedade47e5bf9905424a974df6ec33bc6f6695082
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit d211e97a32ae4d8e9c963269355802009994e9a1
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Tue May 22 14:43:12 2018 +0530
Quota: Fix crawling of files
Problem: Running "find ." does not crawl files. It goes over the
directories and lists all dentries with getdents system call.
Hence the files are not looked up.
Solution:
explicitly triggerr stat on files with find . -exec stat {} \;
since crawl can take slightly longer, updating timeout in test case
Change-Id: If3c1fba2ed8e300c9cc08c1b5c1ba93cb8e4d6b6
fixes: bz#1533000
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
commit e3610e5691186e7035aa999bad108f5f441ab844
Author: Kotresh HR <khiremat@redhat.com>
Date: Sat Jul 7 08:58:08 2018 -0400
geo-rep/scheduler: Fix EBUSY trace back
Fix the trace back during temporary mount
cleanup. Temporary mount is done to touch
the root required for checkpoint to complete.
fixes: bz#1598977
Change-Id: I97fea538e92c4ef0747747e981ef98499504e336
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit eb5de1f520ab1b37a4f974f1aa8ef29949dff74a
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jul 12 04:31:01 2018 -0400
geo-rep: Fix symlink rename syncing issue
Problem:
Geo-rep sometimes fails to sync the rename of symlink
if the I/O is as follows
1. touch file1
2. ln -s "./file1" sym_400
3. mv sym_400 renamed_sym_400
4. mkdir sym_400
The file 'renamed_sym_400' failed to sync to slave
Cause:
Assume there are three distribute subvolume (brick1, brick2, brick3).
The changelogs are recorded as follows for above I/O pattern.
Note that the MKDIR is recorded on all bricks.
1. brick1:
-------
CREATE file1
SYMLINK sym_400
RENAME sym_400 renamed_sym_400
MKDIR sym_400
2. brick2:
-------
MKDIR sym_400
3. brick3:
-------
MKDIR sym_400
The operations on 'brick1' should be processed sequentially. But
since MKDIR is recorded on all the bricks, The brick 'brick2/brick3'
processed MKDIR first before 'brick1' causing out of order syncing
and created directory sym_400 first.
Now 'brick1' processed it's changelog.
CREATE file1 -> succeeds
SYMLINK sym_400 -> No longer present in master. Ignored
RENAME sym_400 renamed_sym_400
While processing RENAME, if source('sym_400') doesn't
present, destination('renamed_sym_400') is created. But
geo-rep stats the name 'sym_400' to confirm source file's
presence. In this race, since source name 'sym_400' is
present as directory, it doesn't create destination.
Hence RENAME is ignored.
Fix:
The fix is not rely only on stat of source name during RENAME.
It should stat the name and if the name is present, gfid should
be same. Only then it can conclude the presence of source.
fixes: bz#1600405
Change-Id: I9fbec4f13ca6a182798a7f81b356fe2003aff969
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit c735d9eb4c956f1ece216a4b85789984fa3ca705
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jul 9 10:01:06 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/,
https://review.gluster.org/#/c/19952/,
https://review.gluster.org/#/c/20104/,
https://review.gluster.org/#/c/20162/,
https://review.gluster.org/#/c/20185/,
https://review.gluster.org/#/c/20207/,
https://review.gluster.org/#/c/20227/,
https://review.gluster.org/#/c/20307/,
https://review.gluster.org/#/c/20320/,
https://review.gluster.org/#/c/20332/,
https://review.gluster.org/#/c/20364/, and
https://review.gluster.org/#/c/20441/
Fixes some overlooked string.join()s:
+ AFAICT extras/profiler/glusterfs-profiler, extras/prot_filter.py,
extras/rebalance.py, and extras/volfilter.py would only manifest at
runtime.
+ xlators/experimental/fdl/src/gen_recon.py is a build-time error when
using python3 during the build, thus was not noticed previously when
building with python2.
+ extras/create_new_xlator/generate_xlator.py seems to be example code
and does not affect the build or runtime AFAICT
Note: Fedora packaging guidelines and SUSE rpmlint require explicit
shebangs; popular practices like #!/usr/bin/env python and #!/usr/bin/python
are not allowed; they must be #!/usr/bin/python2 or #!/usr/bin/python3
Note: Selected small fixes from 2to3 utility. Specifically apply,
basestring, funcattrs, has_key, idioms, map, numliterals, raise,
set_literal, types, urllib, and zip have already been applied. Also
version agnostic imports for urllib, cpickle, socketserver, _thread,
queue, etc., suggested by Aravinda in https://review.gluster.org/#/c/19767/1
Note: these 2to3 fixes report no changes are necessary: asserts, buffer,
exec, execfile, exitfunc, filter, getcwdu, imports2, input, intern,
itertools, metaclass, methodattrs, ne, next, nonzero, operator, paren,
raw_input, reduce, reload, renames, repr, standarderror, sys_exc, throw,
tuple_params, xreadlines.
Change-Id: Ia1fe2958d136f4303e30f7e7e86b6fe7d7b52c81
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 43f5bbe19eb6969ddb538fa5f4aca13ee3194010
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Jul 3 16:03:35 2018 +0530
snapshot : remove stale entry
During snap delete after removing brick-path we should remove
snap-path too i.e. /var/run/gluster/snaps/<snap-name>.
During snap deactivate also we should remove snap-path.
Change-Id: Ib80b5d8844d6479d31beafa732e5671b0322248b
fixes: bz#1597662
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 72a2a67e49fdc4098f87f961de7b1cd7341a376c
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 10 20:56:08 2018 +0530
glusterd: _is_prefix should handle 0-length paths
If one of the paths given to _is_prefix is 0-length, then it is not a
prefix of the other. Hence, _is_prefix should return false.
Change-Id: I54aa577a64a58940ec91872d0d74dc19cff9106d
fixes: bz#1599783
Signed-off-by: Kaushal M <kaushal@redhat.com>
commit 961f618e43bd4dac94e3e043a221df8720759183
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jul 10 21:33:41 2018 +0530
glusterd: log improvements on brick creation validation
Added few log entries in glusterd_is_brickpath_available ().
Change-Id: I8b758578f9db90d2974f7c79126c50ad3a001d71
Updates: bz#1193929
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 9df2033ff2d2eb7cd12cd377071b93b848109244
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Jun 27 14:59:40 2018 +0530
md-cache: Do not invalidate cache post set/remove xattr
Since setxattr and removexattr fops cbk do not carry poststat,
the stat cache was being invalidated in setxatr/remoxattr cbk.
Hence the further lookup wouldn't be served from cache.
To prevent this invalidation, md-cache is modified to get
the poststat in set/removexattr_cbk in dict.
Co-authored with Xavi Hernandez.
Change-Id: I6b946be2d20b807e2578825743c25ba5927a60b4
fixes: bz#1586018
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 161da4aada54b55e6b41b646677484cb3f738eb8
Author: Prashanth Pai <ppai@redhat.com>
Date: Fri Jul 6 16:10:40 2018 +0530
server: Set ssl-allow option in options table and rename ID
This change explicitly adds 'ssl-allow' options to the server xlator's
options table so that glusterd2 can see it as a settable option. This
change also marks 'auth.allow' and 'auth.reject' options as a settable.
Glusterd2 doesn't maintain a separate volume options table. Glusterd2
dynamically loads shared objects of xlators to read their option table
and other information. Glusterd2 reads 'xlator_api_t' if available. If
that's not available, it falls back to reading just the options table
directly.
In glusterd2, volume set operations are performed by users on keys of
the format <xlator>.<option-name>. Glusterd2 uses xlator name set in
'xlator_api_t.identifier'. If that's not present it will use the shared
object's file name as xlator name. Hence, it is important for
'xlator_api_t.identifier' to be set properly, and in this case, the
proper value is "server". This name shall be used by users as prefix
while setting volume options implemented in server xlator. The name will
also be used in volfile.
A user in glusterd2 can authorize a client over TLS as follows:
$ glustercli volume set <volname> server.ssl-allow <client1-CN>[,<clientN-CN>]
gd2 References:
https://github.com/gluster/glusterd2/issues/971
https://github.com/gluster/glusterd2/issues/214
https://github.com/gluster/glusterd2/pull/967
Updates: bz#1193929
Change-Id: I59ef58acb8d51917e6365a83be03e79ae7c5ad17
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit d83cbe0b6e8886730ca3bccb98c6a164b30972b8
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu May 31 12:29:35 2018 +0530
dht: Inconsistent permission for directories after brick stop/start
Problem: Inconsistent access permissions on directories after
bringing back the down sub-volumes, in case of directories dht_setattr
first wind a call on MDS once call is finished on MDS then wind a call
on NON-MDS.At the time of revalidating dht just compare the uid/gid with
stbuf uid/gid and if anyone differs set a flag to heal the same.
Solution: Add a condition to compare permission also in dht_revalidate_cbk
to set a flag to call dht_dir_attr_heal.
BUG: 1584517
Change-Id: I3e039607148005015b5d93364536158380d4c5aa
fixes: bz#1584517
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 7de54500725db908b6b6a958f806e256a4d5b8e7
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Thu Jul 5 15:02:06 2018 +0530
changelog: fix br-state-check.t crash for brick_mux
Problem: br-state-check.t is getting crash
Solution: Check condition in rpcsvc_request_create
before allocate memory from rxpool
BUG: 1597776
Change-Id: I4fde1ade6073f603c32453f1840395db9a9155b7
fixes: bz#1597776
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit f483342d9902d5e9dc7bf92443d29bb340a4b323
Author: Josiah <josiahp@gmail.com>
Date: Fri Jun 29 14:14:36 2018 -0500
Update mount-shared-storage.sh to automatically include all enabled glusterfs mounts in fstab
Currently the mount-shared-storage.sh script requires manual entry of each volume and mount point. There is a TODO item from Bug 1452527 to automatically pull the list of glusterfs mounts from the /etc/fstab file, validate that they are mounted, or attempt to mount them. This is to complete that TODO item.
The extras/mount-shared-storage.sh file has been updated to read only active glusterfs mounts from the /etc/fstab file, verify if they are mounted, and attemt to mount them if they are not. It will exit with a status 0 if successfully mounted or status 1 if any of the mounts fail.
This method will allow the standard method of mounts in /etc/fstab to be utilized and will ensure they are monted following system reboots.
This can be tested by creating a volume, mounting it using the /etc/fstab method, and rebooting the server. Output will be similar to this:
Jun 29 19:09:38 localhost systemd[1]: Starting Mount glusterfs sharedstorage...
Jun 29 19:09:43 localhost mount-shared-storage.sh[4096]: /mnt/mount1 has been mounted
Jun 29 19:09:48 localhost mount-shared-storage.sh[4096]: /mnt/mount2 has been mounted
Jun 29 19:09:48 localhost systemd[1]: Started Mount glusterfs sharedstorage.
Multiple fixes based on code review suggestions and spellcheck
Removed spaces in grep for glusterfs as tabs are valid as well
Added tab as an IFS field separator for the lines read from /etc/fstab
Increased sleep time to 10 seconds before mount validation
Changed mount check to use “mountpoint -q”
Change-Id: Ib90c99ced8f7aefc8dbe87340afc73a28f6195e7
fixes: bz#1596789
Signed-off-by: Josiah <josiahp@gmail.com>
commit 6b9c7b1674f77e020bf659ad6afdd1bac5204272
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Jul 6 20:23:35 2018 +0200
Fix compile warnings
This patch fixes compile warnings that appear with newer compilers. The
solution applied is only to remove the warnings, but it doesn't always
solve the problem in the best way. It assumes that the problem will never
happen, as the previous code assumed.
Change-Id: I6e8470d6c2e2dbd3bd7d324b5fd2f92ffdc3d6ec
updates: bz#1193929
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit d0fbe2003b266fb01465bbd7b525d902376a0d9c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jul 6 12:28:53 2018 +0530
cluster/afr: Prevent execution of code after call_count decrementing
Problem:
When call_count is decremented by one thread, another thread can
go ahead with the operation leading to undefined behavior for the
thread executing statements after decrementing call count.
Fix:
Do the operations necessary before decrementing call count.
fixes bz#1598663
Change-Id: Icc90cd92ac16e5fbdfe534d9f0a61312943393fe
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 7d70693f2e3a29a4a32b5e3728339934da69a53e
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Jul 6 23:26:41 2018 +0200
posix: Do not log ENXIO errors for seek fop
When lseek is used with SEEK_DATA and SEEK_HOLE, it's expected that the
last operation fails with ENXIO when offset is beyond the end of file.
In this case it doesn't make sense to report this as an error log message.
This patch reports ENXIO failure messages for seek fops in debug level
instead of error level.
Change-Id: I62a4f61f99b0e4d7ea6a2cdcd40afe15072794ac
fixes: bz#1598926
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 23d462a24df5021dd1b870ffd8a9677cbb4b3751
Author: ShyamsundarR <srangana@redhat.com>
Date: Thu Jul 5 14:44:04 2018 -0400
io-stats: Terminate dump thread when dump interval is set to 0
_ios_dump_thread is not terminated by the function
_ios_destroy_dump_thread when the diagnostic interval is set
to 0 (which means disable auto dumping).
During reconfigure, if the value changes from 0 to another
then the thread is started, but on reconfiguring this to 0
the thread is not being terminated.
Further, if the value is changed from 0 to X to 0 to Y, where
X and Y are 2 arbitrary duration numbers, the reconfigure
code ends up starting one more thread (for each change from
0 to a valid interval).
This patch fixes the same by terminating the thread when the
value changes from non-zero to 0.
NOTE: It would seem nicer to use conf->dump_thread and check
its value for thread presence etc. but there is no documented
invalid value for the same, and hence an invalid check is not
feasible, thus introducing a new running bool to determine the
same.
Fixes: bz#1598548
Change-Id: I3e7d2ce8f033879542932ac730d57bfcaf14af73
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 796f29d908f078a27bfdad6a8b356a4fcc1996ef
Author: Mohit Agrawal <moagrawal@redhat.com>
Date: Mon Jul 9 14:22:27 2018 +0530
core: Increase SCRIPT_TIMEOUT for bug-1432542-mpx-restart-crash.t
BUG: 1599250
Change-Id: I27bda2a0764580289e7154766e13a0c358cba3a8
fixes: bz#1599250
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
commit 4d47bc4ab4f2f27433a1ba7d2174333106030347
Author: Nigel Babu <nigelb@redhat.com>
Date: Tue Jul 3 11:58:26 2018 +0530
contrib: Remove contrib/ipaddr-py entirely.
This module is no longer being used.
Fixes: bz#1597512
Change-Id: Ie5faf55c5961d9d7b5082c9c257351af712c41d7
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit 6fed1ca8ae682024b7a387665273e06682e0e97b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jul 2 08:18:54 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/,
https://review.gluster.org/#/c/19952/,
https://review.gluster.org/#/c/20104/,
https://review.gluster.org/#/c/20162/,
https://review.gluster.org/#/c/20185/,
https://review.gluster.org/#/c/20207/,
https://review.gluster.org/#/c/20227/,
https://review.gluster.org/#/c/20307/,
https://review.gluster.org/#/c/20320/,
https://review.gluster.org/#/c/20332/, and
https://review.gluster.org/#/c/20364/
Fixes glupy.py python2isms, iteritems -> items, and some overlooked
print() in georep/peer_mountbroker.in
Note: Fedora packaging guidelines and SUSE rpmlint require explicit
shebangs; popular practices like #!/usr/bin/env python and #!/usr/bin/python
are not allowed; they must be #!/usr/bin/python2 or #!/usr/bin/python3
Note: Selected small fixes from 2to3 utility. Specifically apply,
basestring, funcattrs, has_key, idioms, map, numliterals, raise,
set_literal, types, urllib, and zip have already been applied. Also
version agnostic imports for urllib, cpickle, socketserver, _thread,
queue, etc., suggested by Aravinda in https://review.gluster.org/#/c/19767/1
Note: these 2to3 fixes report no changes are necessary: asserts, buffer,
exec, execfile, exitfunc, filter, getcwdu, imports2, input, intern,
itertools, metaclass, methodattrs, ne, next, nonzero, operator, paren,
raw_input, reduce, reload, renames, repr, standarderror, sys_exc, throw,
tuple_params, xreadlines.
Change-Id: Idda031c1ec975417c79323aea33e7b694e752b2a
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 9983b3f3305d316b38b9c8cef831204c370a6a73
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Sat Jun 30 19:51:34 2018 +0530
glusterfs: Brick process is crash at the time of call server_first_lookup
Problem: Brick process is getting crash while executing test case
tests/bugs/core/bug-1432542-mpx-restart-crash.t
Solution: At the time of initiating connection with brick process by
client brick process call server_setvolume.If cleanup thread
has set cleanup_starting flag after check flag by server_setvolume
then a brick process can crash at the time of calling lookup
on brick root.To avoid crash check cleanup_starting
flag before just call server_first_lookup
BUG: 1597627
Change-Id: I12542c124c76429184df34a04c1eae1a30052ca7
fixes: bz#1597627
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Note: To test the patch executing test case
tests/bugs/core/bug-1432542-mpx-restart-crash.t in a loop
around 100 times
commit d2fe426bce6d142d99833a1fc96a96af84842830
Author: dkhandel <dkhandel@localhost.localdomain>
Date: Fri Jul 6 11:38:35 2018 +0530
Replace the BROKEN_TESTS environment variable value
In distributed-testing framework for regression, the value
of BROKEN_TESTS environment variable needs to be replaced.
This list of broken tests is different from what we have
marked as a bad test in our test suites.
Fixes: bz#1598325
Change-Id: I6a3ca5d9500170201ecaafcd5a96d9df3e46a851
Signed-off-by: Deepshikha Khandelwal <dkhandel@redhat.com>
commit 6b6416a59bbcc6258f39c1bd6c2ab8f67794cec9
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jul 3 11:47:31 2018 +0530
checkpatch.pl: fix the perl warning
Used to get the below warning:
`
Running coding guidelines check ...
Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/^(\+.*(?:do|\))){ <-- HERE / at ./build-aux/checkpatch.pl line 3102.
`
But as per the recommendation in perl document, we should escape the braces.
While this check should be removed from the codebase when we get the 'codingstandard' automated scripts, we can keep the code warning free at least till then.
updates: bz#1193929
Change-Id: I236a428174b5d16ca41baa03e96bc7aa26177b5b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit c068b06e17c2440e00e5f0b4ba5e0d6af0a1afbd
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Jul 4 14:45:51 2018 +0530
glusterd: Fix glusterd crash
Problem: gluster get-state command is crashing glusterd process, when
geo-replication session is configured.
Cause: Crash is happening due to the double free of memory. In
glusterd_print_gsync_status_by_vol we are calling dict_unref(), which
will free all the keys and values in the dictionary. Before calling
dict_unref(), glusterd_print_gsync_status_by_vol is calling
glusterd_print_gsync_status(). glusterd_print_gsync_status is freeing
up values in the dictionary and again when dict_unref() is called, it
tries to free up the values which are already freed.
Solution: Remove the code which will free the memory in
glusterd_print_gsync_status function.
Fixes: bz#1598345
Change-Id: Id3d8aae109f377b462bbbdb96a8e3c5f6b0be752
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 4d378d58117b988b85d21096be1ae8d454daf10a
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Jul 1 22:47:46 2018 +0530
protocol/client: handle the fdctx_destroy properly with different versions
while adding the new version of RPC, this part was not handled properly
Updates: bz#1193929
Change-Id: If4cc4c2db075221b9ed731bacb7cc035f7007c5b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit d29599d762d7a9d9bdd03328d4ae7a6dd6b81c30
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 3 14:14:59 2018 +0530
glusterd: show brick online after port registration even in brick-mux
Problem:
With brick-mux even before brick attach is complete on the bricks
glusterd marks them as online. This can lead to a race where
scripts that check if the bricks are online to assume that the
brick is online before it is completely online.
Fix:
Wait for the callback from the brick before marking the port
as registered so that volume status will show the correct status
of the brick.
fixes bz#1597568
Change-Id: Icd3dc62506af0cf75195e96746695db823312051
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 53a95160fc13d92e74b4ed560784dc72c9ee2130
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 3 20:38:23 2018 +0530
cluster/afr: Make sure lk-owner is assigned at the time of lock
Problem:
In the new eager-lock implementation lk-owner is assigned after the
'local' is added to the eager-lock list, so there exists a possibility
of lock being sent even before lk-owner is assigned.
Fix:
Make sure to assign lk-owner before adding local to eager-lock list
fixes bz#1597805
Change-Id: I26d1b7bcf3e8b22531f1dc0b952cae2d92889ef2
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 7b25df1f3b9bc242979f80b58918e60356b7c933
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jul 2 17:21:21 2018 +0530
stack.h: fix the pass_through logic
while fixing the coverity issues, we made a minor mistake in the
pass through logic in STACK_WIND macro.
Also, with this patch, made the code common to reduce possible
future errors creeping in due to missing one place update.
updates: bz#1193929
Change-Id: I6fcfd156d63b0a7e6208819872e565eacf774150
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 95bca96bf46a297b0b940c600e6c19eb07a52865
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jul 2 20:48:22 2018 +0530
glusterd: Introduce daemon-log-level cluster wide option
This option, applicable to the node level daemons can be very helpful in
controlling the log level of these services. Please note any daemon
which is started prior to setting the specific value of this option (if
not INFO) will need to go through a restart to have this change into
effect.
Change-Id: I7f6d2620bab2b094c737f5cc816bc093e9c9c4c9
fixes: bz#1597473
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 3172623456261a1487418c132b8f051f36d67c09
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jul 2 16:47:30 2018 +0530
glusterd: start the services after all the bricks are up
glusterd_svcs_manager () should be called post starting all the volumes
at one go.
Change-Id: I838cc50c29f3930a483aa9671958cdc186904030
Fixes: bz#1597247
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit bdfa54df30b6e8c4f22b24dbcdf6956aa18250f7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 2 10:39:56 2018 +0530
afr,ec: Print if the subvolume is up in statedump
fixes bz#1597156
Change-Id: I323eb9190e40b12df216698dcdba74a6d336beeb
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 8e7bfd6a58b444b26cb50fb98870e77302f3b9eb
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jun 28 15:47:04 2018 +0530
cli: change volume create syntax of arbiter volume
fixes: bz#1596524
updates: gluster/glusterd2#515
Change-Id: I8a46fa2fd1fd2b0e9fbcecd3bb18d348aed9c6a9
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7e4aef4100c4b904ed0f03d38dfabe39a07a0cd4
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Jun 26 10:40:08 2018 +0530
storage/posix: Add warning logs on failure
posix_readdirp_fill will fail to update the iatt
information if posix_handle_path fails.
There is currently no log message to indicate this making
debugging difficult.
Change-Id: I6bce360ea7d1696501637433f80e02794fe1368f
updates: bz#1564071
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 66cb368f46a52f016691658cc92ba192160bc033
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jun 29 11:30:37 2018 +0530
glusterfsd: Do not process GLUSTERD_BRICK_XLATOR_OP if graph is not ready
Problem:
If glustershd gets restarted by glusterd due to node reboot/volume start force/
or any thing that changes shd graph (add/remove brick), and index heal
is launched via CLI, there can be a chance that shd receives this IPC
before the graph is fully active. Thus when it accesses
glusterfsd_ctx->active, it crashes.
Fix:
Since glusterd does not really wait for the daemons it spawned to be
fully initialized and can send the request as soon as rpc initialization has
succeeded, we just handle it at shd. If glusterfs_graph_activate() is
not yet done in shd but glusterd sends GD_OP_HEAL_VOLUME to shd,
we fail the request.
Change-Id: If6cc07bc5455c4ba03458a36c28b63664496b17d
fixes: bz#1596513
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 5a36833798ab8c2d580076ee5c9ff8793e107517
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jun 27 08:26:44 2018 -0400
tests/geo-rep: Add symlink rename test case
Added a test case of symlink rename and directory
creation with the name same as original symlink
file. Also fixed few other issues in geo-rep.rc
fixes: bz#1595726
Change-Id: I8e6acd3e742f3a0104cd37b87d1c0e0c902679b5
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 4ede788e7324c2921647e849baf53011a6735d3e
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Jun 22 10:42:42 2018 +0530
cluster/dht: Do not try to use up the readdirp buffer
DHT attempts to use up the entire buffer in readdirp before
unwinding in an attempt to reduce the number of calls.
However, this has 2 disadvantages:
1. This can cause a stack overflow when parallel readdir
is enabled. If the buffer only has a little space,rda can send back
only one or two entries. If those entries are stripped out by
dht_readdirp_cbk (linkto files for example) it will once again
wind down to rda in an attempt to fill the buffer before unwinding to FUSE.
This process can continue for several iterations, causing the stack
to grow and eventually overflow, causing the process to crash.
2. If parallel readdir is disabled, dht could send readdirp
calls with small buffers to the bricks, thus increasing the
number of network calls.
We are therefore reverting to the existing behaviour.
Please note, this only mitigates the stack overflow, it does
not prevent it from happening. This is still possible if
a subvol has thousands of linkto files for instance.
Change-Id: I291bc181c5249762d0c4fe27fa4fc2631166adf5
fixes: bz#1593548
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 5b2963a43118c5cccd45e44f5e0aab3fde5c6768
Author: Varsha Rao <varao@redhat.com>
Date: Thu Jun 28 14:28:27 2018 +0530
xlators/meta: Fix resource_leak
Free priv to fix the resource_leak coverity issue.
Change-Id: Id116bd2f72332d2f665c25c9ae27241286ac570f
updates: bz#789278
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 83ed416efd281471e3f9e447dbcfd35abeeecc41
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jun 28 10:42:56 2018 +0530
extras/group : add database workload profile
Running DB workload patterns with all perf xlators enabled as default has
resulted into some inconsistency issues. Based on the internal testing done by
Elko Kuric (ekuric@redhat.com) there're certain set of perf xlators which need
to be turned off to get these types of workload supported by Gluster.
The proposal is to leverage group profile infrastructure to group together all
those tunables at one place so that users just need to apply the profile to the
volume to use it for the data base workload.
Credits : Elko Kuric (ekuric@redhat.com)
Change-Id: I8a50e915278ad4085b9aaa3f160a33af7c0b0444
fixes: bz#1596020
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit f43d55f8847bf6a5d3d266facffd8628b14cf1af
Author: Varsha Rao <varao@redhat.com>
Date: Thu Jun 28 15:31:36 2018 +0530
xlators/features/barrier: Fix RESOURCE_LEAK
Free priv to fix the resource_leak coverity issue.
Change-Id: I1f93f54d7d59eddb0b9523ac2b67ef0b279122bd
updates: bz#789278
Signed-off-by: Varsha Rao <varao@redhat.com>
commit f4f1da2f701ad392efdbeb1fea850a18d645707b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Jun 26 20:46:07 2018 +0530
tests: remove tarissue.t from BAD_TEST
BZ 1337791 marked this .t as bad based on the tar version being a likely
suspect. Undoing this to check as it passes on the latest jenkins slaves.
Change-Id: Ia581064a9c620351d3fe7aeef95d2644337952e1
fixes: bz#1595492
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reported-by: Yaniv Kaul <ykaul@redhat.com>
commit 52f1c1bbdb68e2d953a1ed8f97636779f9105d4e
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Tue Jun 26 17:39:34 2018 +0800
performance/md-cache: Fix issue on lock being used before init.
lock is used in mdc_xattr_list_populate(), but got init after call. Fix
this issue by moving initing lock ahead.
Change-Id: I94b08303a8ba74b1e9388f700587a00b7ae3fd78
fixes: bz#1595174
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit 00b7e778c4a071f9aef0064cbc9871e489c810df
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jun 26 15:58:02 2018 +0530
storage/posix: Fix posix_symlinks_match()
1) snprintf into linkname_expected should happen with PATH_MAX
2) comparison should happen with linkname_actual with complete
string linkname_expected
fixes bz#1595190
Change-Id: Ic3b3c362dc6c69c046b9a13e031989be47ecff14
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit c2a8f70ebb117b0f955284732dc67399d52234bc
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Feb 29 11:49:01 2016 +0100
tests: check for the availability of netstat
bug-924726.t calls netstat, and tests fail in case netstat is not
available.
BUG: 1312832
Change-Id: I3393778e148504326a468744d8a97d28932feed1
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit d57333af7a59312975bc926ae755559f694544be
Author: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
Date: Sat Jun 16 08:24:00 2018 +0200
cloudsync: avoid null pointer deref in error paths
In the case of OOM we would end up dereferencing priv in
the out label of aws_init(). A similar deref would happen
if a null priv is passed to aws_reconfigure().
Change-Id: I57c80aad2b52ecb1eda86a0077ed6b46816e5dea
fixes: bz#1592141
Signed-off-by: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
commit 6b46050996b5488f6a2e0586e3fcca98ea599eea
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Fri Jun 8 10:59:56 2018 +0800
nfs: add missing rpcsvc_program_unregister_rpcbind6
Otherwise, event if nfs.register-with-portmap is disabled, we could
also use ipv6 to mount nfs through portmap.
Change-Id: I7546e03d942dfaf2252d57e17be9c1cca986a715
fixes: bz#1593651
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit e752686bad6146e7ff81eac5a3e39b9a740daaed
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon May 28 03:05:26 2018 -0400
cluster/dht: Fix rename journal in changelog
With patch [1], renames are journalled only
on cached subvolume. The dht sends the special
key on the cached subvolume so that the changelog
journals the rename. With single distribute
sub-volume, the key is not being set. This patch
fixes the same.
[1] https://review.gluster.org/10410
fixes: bz#1583018
Change-Id: Ic2e35b40535916fa506a714f257ba325e22d0961
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit ab87db0acf5622af444ed6fbbe115e92be9616f3
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Jun 22 06:19:53 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/,
https://review.gluster.org/#/c/19952/,
https://review.gluster.org/#/c/20104/,
https://review.gluster.org/#/c/20162/,
https://review.gluster.org/#/c/20185/,
https://review.gluster.org/#/c/20207/,
https://review.gluster.org/#/c/20227/,
https://review.gluster.org/#/c/20307/,
https://review.gluster.org/#/c/20320/, and
https://review.gluster.org/#/c/20332/
This patch fixes the remaining comma white space (ws_comma) as suggested
by the 2to3 utility. (Earlier attempts to fix all ws_comma in one
patch did not pass centos regression, hence multiple patches to identify
the change that causes the failure.)
Note: Fedora packaging guidelines and SUSE rpmlint require explicit
shebangs; popular practices like #!/usr/bin/env python and #!/usr/bin/python
are not allowed; they must be #!/usr/bin/python2 or #!/usr/bin/python3
Note: Selected small fixes from 2to3 utility. Specifically apply,
basestring, funcattrs, has_key, idioms, map, numliterals, raise,
set_literal, types, urllib, and zip have already been applied. Also
version agnostic imports for urllib, cpickle, socketserver, _thread,
queue, etc., suggested by Aravinda in https://review.gluster.org/#/c/19767/1
Note: these 2to3 fixes report no changes are necessary: asserts, buffer,
exec, execfile, exitfunc, filter, getcwdu, imports2, input, intern,
itertools, metaclass, methodattrs, ne, next, nonzero, operator, paren,
raw_input, reduce, reload, renames, repr, standarderror, sys_exc, throw,
tuple_params, xreadlines.
Change-Id: If5aca67084a7b1c06966fed35fb35e8bb2f7d67c
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 02c7e4cb0f30363bdc48ea7e94d37b12c7b48ac1
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jun 7 04:11:25 2018 -0400
geo-rep: Fix geo-rep for older versions of unshare
Geo-rep mounts are private to worker. It uses
mount namespace using unshare command to achieve
the same. Well, the unshare command has to support
'--propagation' option. So geo-rep breaks on the
systems with older unshare version. The patch
makes it fall back to lazy umount behaviour if
the unshare does not support propagation option.
fixes: bz#1589782
Change-Id: Ia614f068aede288d63ac62fea4461b1865066054
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit a45e20c8443c6d25c9416f6f2a95ac04dabd3bb6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Jun 20 11:38:59 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/,
https://review.gluster.org/#/c/19952/,
https://review.gluster.org/#/c/20104/,
https://review.gluster.org/#/c/20162/,
https://review.gluster.org/#/c/20185/,
https://review.gluster.org/#/c/20207/,
https://review.gluster.org/#/c/20227/,
https://review.gluster.org/#/c/20307/, and
https://review.gluster.org/#/c/20320/
This patch fixes more selected comma white space (ws_comma) as suggested
by the 2to3 utility. (Earlier attempts to fix all ws_comma in one
patch did not pass centos regression, hence multiple patches to identify
the change that causes the failure.)
Note: Fedora packaging guidelines and SUSE rpmlint require explicit
shebangs; popular practices like #!/usr/bin/env python and #!/usr/bin/python
are not allowed; they must be #!/usr/bin/python2 or #!/usr/bin/python3
Note: Selected small fixes from 2to3 utility. Specifically apply,
basestring, funcattrs, has_key, idioms, map, numliterals, raise,
set_literal, types, urllib, and zip have already been applied. Also
version agnostic imports for urllib, cpickle, socketserver, _thread,
queue, etc., suggested by Aravinda in https://review.gluster.org/#/c/19767/1
Note: these 2to3 fixes report no changes are necessary: asserts, buffer,
exec, execfile, exitfunc, filter, getcwdu, imports2, input, intern,
itertools, metaclass, methodattrs, ne, next, nonzero, operator, paren,
raw_input, reduce, reload, renames, repr, standarderror, sys_exc, throw,
tuple_params, xreadlines.
Change-Id: I6e5a2408fa1fc81e00e66d6e4a7f9f6fa1d1ed15
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit a5ff7fd8ee9ab67e9797ae87e61fa2c05b719984
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jun 19 10:56:37 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/,
https://review.gluster.org/#/c/19952/,
https://review.gluster.org/#/c/20104/,
https://review.gluster.org/#/c/20162/,
https://review.gluster.org/#/c/20185/,
https://review.gluster.org/#/c/20207/,
https://review.gluster.org/#/c/20227/, and
https://review.gluster.org/#/c/20307/
This patch fixes more selected comma white space (ws_comma) as suggested
by the 2to3 utility.
Note: Fedora packaging guidelines and SUSE rpmlint require explicit
shebangs, so popular practices like #!/usr/bin/env python and
or #!/usr/bin/python3
Note: Selected small fixes from 2to3 utility. Specifically apply,
basestring, funcattrs, has_key, idioms, map, numliterals, raise,
set_literal, types, urllib, and zip have already been applied. Also
version agnostic imports for urllib, cpickle, socketserver, _thread,
queue, etc., suggested by Aravinda in https://review.gluster.org/#/c/19767/1
Note: these 2to3 fixes report no changes are necessary: asserts, buffer,
exec, execfile, exitfunc, filter, getcwdu, imports2, input, intern,
itertools, metaclass, methodattrs, ne, next, nonzero, operator, paren,
raw_input, reduce, reload, renames, repr, standarderror, sys_exc, throw,
tuple_params, xreadlines.
Change-Id: I60932030813484803f73733a9b2b7b23c7a843fd
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit aff3a462cf3d226bb0dbcdbb2e590781fd498135
Author: John Mulligan <jmulligan@redhat.com>
Date: Wed Jun 20 13:36:13 2018 -0400
fuse: avoid using the which command
In mount.glusterfs avoid using the which tool as it may not exist
on minimal system installs. Use the "command -v" builtin as
it is expected to be more portable.
Remove a extra semicolon while we're at it.
Change-Id: Ib682ed4955d5bad1beb94b65d10f4c44e9490767
fixes: bz#1593351
Signed-off-by: John Mulligan <jmulligan@redhat.com>
commit efa1dfe6a4463d9ff10df9263bb4cef7eb365450
Author: Nigel Babu <nigelb@redhat.com>
Date: Thu Jun 21 10:57:26 2018 +0530
Add Vijay and Akarsha as peers
Change-Id: I5298af937199aa5c6908aefcd968b2441b5e23d5
Fixes: bz#1593562
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit a5e76eb02f4120b1b37bf06f75c9d29a8e390870
Author: Michael Adam <obnox@samba.org>
Date: Tue May 29 11:56:13 2018 +0200
client: remove the "connecting" state - it's not used
The "connecting" state is not used anywhere really.
It's only being set and printed. So remove it.
Change-Id: I11fc8b0bdcda5a812d065543aa447d39957d3b38
fixes: bz#1583583
Signed-off-by: Michael Adam <obnox@samba.org>
commit 057cfcb9164534a601f5c2ad14215402f86096b1
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Jun 12 19:49:52 2018 +0530
cluster/dht: refactor dht_lookup
The dht lookup code is getting difficult to maintain
due to its size. Refactoring the code will make it
easier to modify it in future.
Change-Id: Ic7cb5bf4f018504dfaa7f0d48cf42ab0aa34abdd
updates: bz#1590385
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit a71368eb6792e399be305ddfb871209b4b6ef7ed
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Jun 20 16:13:00 2018 +0530
glusterfs: access trusted peer group via remote-host command
Problem: In SSL environment the user is able to access volume
via remote-host command without adding node in a trusted pool
Solution: Change the list of rpc program in glusterd.c at the
time of initialization while SSL is enabled
BUG: 1593232
Change-Id: I987e433b639e68ad17b77b6452df1e22dbe0f199
fixes: bz#1593232
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 3a4dcb64758a71988310b21e594cd7b1ac3f7d61
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Apr 12 15:47:00 2018 +0530
features/shard: Perform shards deletion in the background
A synctask is created that would scan the indices from
.shard/.remove_me, to delete the shards associated with the
gfid corresponding to the index bname and the rate of deletion
is controlled by the option features.shard-deletion-rate whose
default value is 100.
The task is launched on two accounts:
1. when shard receives its first-ever lookup on the volume
2. when a rename or unlink deleted an inode
Change-Id: Ia83117230c9dd7d0d9cae05235644f8475e97bc3
updates: bz#1568521
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit b9b01f1d6b3d383671312b1d0de98e1396195bff
Author: dkhandel <dkhandel@localhost.localdomain>
Date: Tue Jun 19 14:20:26 2018 +0530
Distributed-testing: Call the correct class i.e. GeneralXMLRPCServer
fixes: bz#1586342
Change-Id: I7a062d49f2a49ca4848ffd0b8d1e39c8b6b99815
Signed-off-by: Deepshikha Khandelwal <dkhandel@redhat.com>
commit 0f6ee06eee285894b4a26ace06934deedecd4320
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jun 18 13:40:33 2018 -0400
ctime: Fix self heal of symlink in EC volume
Since IEEE Std 1003.1-2001 does not require any
association of file times with symbolic links,
there is no requirement that file times be
updated by readlink() states [1].
stat on symlink file was generating a readlink
fop on one of the subvolumes of ec set which
in turn updates atime on that subvolume. This
causes mdata xattr to be different across ec
set and hence self heal fails. So based on [1],
atime is no longer updated by readlink fop.
[1] http://pubs.opengroup.org/onlinepubs/009695399/functions/readlink.html
fixes: bz#1592509
Change-Id: I08bd3ca3bdb222bd18160b1aa58fc2f7630c8083
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit b87017e4cf970ad8107ec637ab87f83636ceade9
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jun 14 01:08:35 2018 -0400
posix/ctime: Fix differential ctime duing entry operations
We should not be relying on backend file's time attributes
to load the initial ctime time attribute structure. This
is incorrect as each replica set would have witnessed the
file creation at different times.
For new file creation, ctime, atime and mtime should be
same, hence initiate the ctime structure with the time
from the frame. But for the files which were created
before ctime feature is enabled, this is not accurate
but still fine as the times would get eventually accurate.
fixes: bz#1592275
Change-Id: I206a469c83ee7b26da2fe096ae7bf8ff5986ad67
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit b81964c6c809f3c4507121ffe02ec02cc0252ec1
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Jun 14 12:37:52 2018 +0530
cluster/dht: Minor code cleanup
Removed extra variable.
Change-Id: If43c47f6630454aeadab357a36d061ec0b53cdb5
updates: bz#1590385
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 0df8feccbd328a542be83c5ba8fa115c490689fa
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jun 18 09:17:26 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/,
https://review.gluster.org/#/c/19952/,
https://review.gluster.org/#/c/20104/,
https://review.gluster.org/#/c/20162/,
https://review.gluster.org/#/c/20185/,
https://review.gluster.org/#/c/20207/, and
https://review.gluster.org/#/c/20227/
This patch fixes selected comma white space (ws_comma) as suggested
by the 2to3 utility.
Note: Fedora packaging guidelines and SUSE rpmlint require explicit
shebangs, so popular practices like #!/usr/bin/env python and
or #!/usr/bin/python3
Note: Selected small fixes from 2to3 utility. Specifically apply,
basestring, funcattrs, has_key, idioms, map, numliterals, raise,
set_literal, types, urllib, and zip have already been applied. Also
version agnostic imports for urllib, cpickle, socketserver, _thread,
queue, etc., suggested by Aravinda in https://review.gluster.org/#/c/19767/1
Note: these 2to3 fixes report no changes are necessary: asserts, buffer,
exec, execfile, exitfunc, filter, getcwdu, imports2, input, intern,
itertools, metaclass, methodattrs, ne, next, nonzero, operator, paren,
raw_input, reduce, reload, renames, repr, standarderror, sys_exc, throw,
tuple_params, xreadlines.
Change-Id: I691d7f86279572642902650ed1c24840e3c4b781
Updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 36980ba267f2fff64b339608359bae91d04a738d
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Dec 17 13:38:39 2017 +0100
tests/vagrant: install additional dependencies
The Vagrant box that is used by ./run-tests-in-vagrant.sh does not have
all recent dependencies installed. By using 'dnf builddep' to install
the BuildRequires from the generated .spec file, most future problems
should be prevented.
The tests/basic/afr/split-brain-favorite-child-policy.t script uses the
'bc' command. This it a run-time dependency for the test, and will not
be found with 'dnf builddep'.
Change-Id: Ifdbfc4af2997ea27815126766cc093947ddf523f
BUG: 1526780
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit f4586121c3b009175b65dc706b6e74da4bb9f47c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jun 14 12:59:06 2018 +0530
afr: heal gfids when file is not present on all bricks
commit 20fa80057eb430fd72b4fa31b9b65598b8ec1265 introduced a regression
wherein if a file is present in only 1 brick of replica *and* doesn't
have a gfid associated with it, it doesn't get healed upon the next
lookup from the client. Fix it.
Change-Id: I7d1111dcb45b1b8b8340a7d02558f05df70aa599
fixes: bz#1591193
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 403cdff32d1d7570891dbba3f81dec21a047f35f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu May 17 08:23:33 2018 +0530
afr: don't update readables if inode refresh failed on all children
Problem:
If inode refresh failed on all children of afr due to ENOENT (say file
migrated by dht), it resets the readables to zero. Any inflight txn which
then later comes on the inode fails with EIO because no readable
children present for the inode.
Fix:
Don't update readables when inode refresh fails on *all* children of
afr. In that way any inflight txns will either proceed with its own inode
refresh if needed and fail it with the right errno or use the old value
of readables and continue with the txn.
Also, add quorum checks to the beginning of afr_transaction(). Otherwise, we
seem to be winding the lock and checking for quorum only in pre-op pahse.
Note: This should ideally fix BZ 1329505 since the stop gap fix for
it is has been reverted at https://review.gluster.org/#/c/20028.
Change-Id: Ia638c092d8d12dc27afb3cdad133394845061319
updates: bz#1584483
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit c30af6eb3e7f8495fd04e8be471bcb58f4345452
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Jun 15 17:01:38 2018 +0530
performance/quick-read: provide an invalidation based on ctime
Quick-read by default uses mtime to identify changes to file
data. However there are applications like rsync which explicitly set
mtime making it unreliable for the purpose of identifying change in
file content. Since ctime also changes when content of a file changes
and it cannot be set explicitly, it becomes suitable for identifying
staleness of cached data. This option makes quick-read to prefer ctime
over mtime to validate its cache. However, using ctime can result in
false positives as ctime changes with just attribute changes like
permission without changes to file data. So, use this option only when
mtime is not reliable.
credits to Kotresh Hiremath Ravishankar <khiremat@redhat.com> for
suggestion on using ctime instead of mtime.
Change-Id: Ib3ae39a3252b2876c8ffe81f471d02a87190e9b9
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1591621
commit 11348efdb6de307c75a16bb5300cafa3c18559e0
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jun 11 03:12:10 2018 -0400
tests: Enable geo-rep test cases
Fixes: bz#1537602
Change-Id: I12314262aaa80f8b7818170112529bf62ab93d3f
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 167eebbf79d78549146da4a8d95375abec67c2dc
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jun 12 09:51:44 2018 +0200
gcron: create the lockfile if it is missing
The lockfile for the job may not exist yet. If that is the case, it
should be created upon the first time it is accessed.
Change-Id: I4da2b3ecdb79cc63ed82cc7bfa026c8f08d4d043
Fixes: bz#1590193
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 1ad2a009c2e08dc102760435f3b430e592ace5a3
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jun 11 03:06:25 2018 -0400
tests: Increase timeout for geo-rep testcases
Change-Id: I11715c23fddc1dd218a3ab88a55f1d6355dcfd43
Updates: bz#1537602
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit a16d502f7d0a79e9878ef3be11e91c750396df7b
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jun 12 09:49:09 2018 +0200
gcron: catch OSError as well as IOError
In case os.open() fails because the file does not exist, an OSError is
raised. To prevent the script to abort uncleanly, catch the OSError in
addition to the IOError.
Change-Id: I48e5b23e17d63639cc33db51b4229249a9887880
Fixes: bz#1590193
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 0dfd0e84c651e31ec1ceccc83907e00e6b0063bf
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jun 6 11:57:18 2018 +0200
MAINTAINERS: remove me from NFS maintainers
My role at Red Hat changed a little and I do not have the time to look
into gNFS anymore. If needed, I am still around to assist, but the
initial contacts should be the active maintainers and peers.
Change-Id: I3cbae3c5cbd413abb6f95be238efc685c493c392
Updates: bz#1193929
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit d6516cf1a85a2144c3a5f9b94907b87b20cd579b
Author: dkhandel <dkhandel@localhost.localdomain>
Date: Mon Jun 11 12:49:41 2018 +0530
Add a command-line argument option to use specific address family
This commit adds option to pass command-line argument to use any of IPv4 or IPv6 address family.
Also it clean all the logs in the /tmp before running the distributed-test-runner.py
fixes: bz#1586342
Change-Id: Ie55021389d454a7e3631359cbd6a1504b6661317
Signed-off-by: dkhandel <dkhandel@redhat.com>
commit a99851d6ebb568bd1724662c29bd5bf7f1400145
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jun 14 14:46:24 2018 +0530
protocol/client: Remove code duplication
client_submit_vec_request() which is used by WRITEV, and PUT
and client_submit_request() used by the rest of the fops have
almost similar code. However, there have been some more checks
- such as whether setvolume was successful or not, and one more
that is send-gid-specific - that have been missed out in the vectored
version of the function.
This patch fixes this code duplication.
Change-Id: I363a28eeead6219cb1009dc831538153e8bd7d40
fixes: bz#1591580
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit d264bc29506117b8018fce7455fc323ef4ddcc7e
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Jun 14 19:58:54 2018 +0530
glusterd: removing the unnecessary glusterd message
Fixes: bz#1589253
Change-Id: I5510250a3d094e19e471b3ee47bf13ea9ee8aff5
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit dece0eae59f5fcfed0094fa8613194cb051fbcce
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Jun 8 09:43:40 2018 -0400
features/snapview-server: properly go through the list of snapshots
The comparison code to check whether a glfs instance is valid
(i.e. whether it corresponds to one in the list of current snapshots)
was not correct and was not comparing all the snapshots
Change-Id: I87c58edb47bd9ebbb91d805e45df2c4baf2c8118
fixes: bz#1589842
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 93dcae5acc644c2740b252493f1fb2e6ea8a49e2
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Jun 13 11:44:55 2018 +0530
gfapi : Coverity Fixes
*** CID 1391419: Control flow issues (DEADCODE)
glusterfs/api/src/glfs-fops.c: 5224 in glfs_recall_lease_upcall()
*** CID 1391414: Memory - illegal accesses (UNINIT)
glusterfs/glusterfs/api/src/glfs-fops.c: 5137 in glfs_recall_lease_fd()
Fixes: #789278
Change-Id: Ie16103e7e321724d3cf1bdcb815c2e2467b9a366
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit b0ac87d44d725e8928c15c94dd68d5fba1527eef
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jun 13 12:17:28 2018 +0530
storage/posix: Handle ENOSPC correctly in zero_fill
Change-Id: Icc521d86cc510f88b67d334b346095713899087a
fixes: bz#1590710
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 025fbdc671b5b3c79f94b6b2b6ab1a40e1c19962
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Jun 8 19:39:58 2018 +0530
glusterd: Fix for shd not coming up
Problem: After creating and starting n(n is large) distribute-replicated
volumes using a script, if we create and start (n+1)th distribute-replicate
volume manually self heal daemon is down.
Solution: In glusterd_proc_stop after giving SIGTERM signal if the
process is still running, we are giving a SIGKILL. As SIGKILL will
not perform any cleanup process, we need to remove the pidfile.
Fixes: bz#1589253
Change-Id: I7c114334eec74c8d0f21b3e45cf7db6b8ef28af1
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 7bb6c5499a5268fde881956a77a1f628a4ff7f8e
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jun 11 10:55:42 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/,
https://review.gluster.org/#/c/19952/,
https://review.gluster.org/#/c/20104/,
https://review.gluster.org/#/c/20162/,
https://review.gluster.org/#/c/20185/, and
https://review.gluster.org/#/c/20207/
This patch changes uses of has_key() as suggested by the 2to3 utility.
Note: Fedora packaging guidelines require explicit shebangs, so popular
practices like #!/usr/bin/env python and #!/usr/bin/python are not
allowed; they must be #!/usr/bin/python2 or #!/usr/bin/python3
Note: Selected small fixes from 2to3 utility. Specifically apply,
basestring, funcattrs, idioms, numliterals, set_literal, types, urllib,
zip, map, and raise have already been applied. Also version agnostic
imports for urllib, cpickle, socketserver, _thread, queue, etc., suggested
by Aravinda in https://review.gluster.org/#/c/19767/1
Note: these 2to3 fixes report no changes are necessary: asserts, buffer,
exec, execfile, exitfunc, filter, getcwdu, imports2, input, intern,
itertools, metaclass, methodattrs, ne, next, nonzero, operator, paren,
raw_input, reduce, reload, renames, repr, standarderror, sys_exc, throw,
tuple_params, xreadlines.
Updates: #411
Change-Id: I79bda20f1583a0a1bb0320667498f4c137de93b3
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit ea8f34228c656ab6d757c0fa40134d217f4bd879
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jun 13 12:26:55 2018 +0530
storage/posix: Fix excessive logging in WRITE fop path
I was running some write-intensive tests on my volume, and in a matter
of 2 hrs, the 50GB space in my root partition was exhausted. On inspecting
further, figured that excessive logging in bricks was the cause -
specifically in posix write when posix_check_internal_writes() does
dict_get() without a NULL-check on xdata.
Change-Id: I89de57a3a90ca5c375e5b9477801a9e5ff018bbf
fixes: bz#1590655
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit a217e0d978d2d5f90b639b0424b06952be987134
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Mar 29 17:21:32 2018 +0530
features/shard: Introducing ".shard/.remove_me" for atomic shard deletion (part 1)
PROBLEM:
Shards are deleted synchronously when a sharded file is unlinked or
when a sharded file participating as the dst in a rename() is going to
be replaced. The problem with this approach is it makes the operation
really slow, sometimes causing the application to time out, especially
with large files.
SOLUTION:
To make this operation atomic, we introduce a ".remove_me" directory.
Now renames and unlinks will simply involve two steps:
1. creating an empty file under .remove_me named after the gfid of the file
participating in unlink/rename
2. carrying out the actual rename/unlink
A synctask is created (more on that in part 2) to scan this directory
after every unlink/rename operation (or upon a volume mount) and clean
up all shards associated with it. All of this happens in the background.
The task takes care to delete the shards associated with the gfid in
.remove_me only if this gfid doesn't exist in backend, ensuring that the
file was successfully renamed/unlinked and its shards can be discarded now
safely.
Change-Id: Ia1d238b721a3e99f951a73abbe199e4245f51a3a
updates: bz#1568521
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 927b03c05e7a7eac245ede9515cf7da36d824242
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Jun 6 12:57:50 2018 +0530
cluster/dht: Refactor rebalance code
Created init and cleanup functions for certain
functionality in order to improve readability.
Removed unused code.
Change-Id: Ia6a2f4ab64923b6ea8e10487227fb5621eec1488
updates: bz#1586363
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit cb9aff7d4531b4bd6dac1bae7fa39b825cb9e856
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sat Jun 2 01:38:10 2018 +0530
glusterd: Coverity Fixes
Fixes: #789278
Change-Id: I633704fab49992cac6ee9e05bc368f7da360d09e
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit be4f55ced743ae04b57814df06821af54d4b02f2
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon May 7 17:18:06 2018 +0530
cluster/dht: Leverage MDS subvol for dht_removexattr also
Problem: In a distributed volume situation can be arise when custom
extended attributed are not removed from all bricks after
stop/start or added newly brick.
Solution: To resolve the same use MDS subvol for remove xattr also
BUG: 1575587
Change-Id: I7701e0d3833e3064274cb269f26061bff9b71f50
fixes: bz#1575587
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 4fb0e67ea1e275a44e87dc0be957dc092b4e8dff
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon May 21 09:04:57 2018 -0400
api: cleanup headers
fix inconsistent use in headers of:
struct glfs and glfs_t
struct glfs_fd and glfs_fd_t
struct glfs_object and glfs_object_t
add typedefs to headers for various struct glfs_foos, and use them, e.g.:
struct glfs_upcall and glfs_upcall_t
fix inconsistent type naming for 'enum glfs_lock_mode_t'. (All other
enum decls are 'enum glfs_foo' not 'enum_glfs_foo_t'), and add
typedefs for all enums, and use them.
style, replace tabs with spaces and follow return value style, i.e.:
int
pub_glfs_foo()
instead of:
int pub_glfs_foo()
Update copyright dates, substantial new work has been done since 2012
Change-Id: I0a9654486ea132efde7977b655799fb37887b1d5
Updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 927b03cf3bc938632fd40ad7b5d8949450796655
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jun 11 13:03:58 2018 +0530
protocol/server: Fix xdata leak in seek fop
Change-Id: I6125283ed22c04564f0b77bb7a50579a83e02eb0
fixes: bz#1589691
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 8ef5bfcc7280893f9f49aa1dd50867c441e57562
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jun 11 02:52:16 2018 -0400
geo-rep: Fix problems in python2 -> python3 compat
1. Import configparser module correctly
2. Import thread module correctly
Updates: #411
Change-Id: I522453d23c256b694fa58d285f413b8c4dd6595c
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit cc5eb04fc1475bab5491c47d33746c20fb7e463a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jun 7 12:27:23 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/,
https://review.gluster.org/#/c/19952/, and
https://review.gluster.org/#/c/20104/
https://review.gluster.org/#/c/20162/
This patch changes uses of map() and raise(), and a few cases of print()
that were overlooked in the prior patch that fixed print.
Note: Fedora packaging guidelines require explicit shebangs, so popular
practices like #!/usr/bin/env python and #!/usr/bin/python are not
allowed; they must be #!/usr/bin/python2 or #!/usr/bin/python3
Note: Selected small fixes from 2to3 utility. Specifically apply,
basestring, funcattrs, idioms, numliterals, set_literal, types, urllib,
zip, map, and raise have already been applied. Also version agnostic
imports for urllib, cpickle, socketserver, _thread, queue, etc., suggested
by Aravinda in https://review.gluster.org/#/c/19767/1
Note: these 2to3 fixes report no changes are necessary: asserts, buffer,
exec, execfile, exitfunc, filter, getcwdu, intern, itertools, metaclass,
methodattrs, ne, next, nonzero, operator, paren, raw_input, reduce,
reload, renames, repr, standarderror, sys_exc, throw, tuple_params,
xreadlines.
Change-Id: Id62ea491e4ab5dd390075c5c6d9d889cf6f9da27
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 8c0c10db3e6f8dca6092ea50b0e90caafe53c981
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jun 5 09:49:23 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/,
https://review.gluster.org/#/c/19952/, and
https://review.gluster.org/#/c/20104/
This patch changes uses of xrange() to range(), as suggested by the
python 2to3 utility. https://www.geeksforgeeks.org/range-vs-xrange-python/
In Python 3, there is no xrange , but the range function behaves like
xrange in Python 2. (My concern is that range() in python2 may behave
differently until we "throw the switch" to switch to python3.)
Note: Fedora packaging guidelines require explicit shebangs, so
popular practices like #!/usr/bin/env python and #!/usr/bin/python
are not allowed; they must be #!/usr/bin/python2 or #!/usr/bin/python3
Note: Selected small fixes from 2to3 utility. Specifically apply,
basestring, funcattrs, idioms, numliterals, set_literal, types, urllib,
and zip have already been applied. Also version agnostic imports for
urllib, cpickle, socketserver, _thread, queue, etc., suggested by
Aravinda in https://review.gluster.org/#/c/19767/1
Note: these 2to3 fixes report no changes are necessary: asserts, buffer,
exec, execfile, exitfunc, filter, getcwdu, intern, itertools, metaclass,
methodattrs, ne, next, nonzero, operator, paren, raw_input, reduce,
reload, renames, repr, standarderror, sys_exc, throw, tuple_params,
xreadlines.
Change-Id: I16ae9f4e3a4fd02a0623fb6f9fdb7aaf65f2a8a9
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit e434e6166c2716c2a640640497225bb063842b74
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sat Jun 2 16:36:22 2018 +0530
glusterd: gluster v status is showing wrong status for glustershd
When we restart the bricks, connect and disconnect events happen
for glustershd. glusterd use two threads to handle disconnect and
connects events from glustershd. When we restart the bricks we'll
get both disconnect and connect events. So both the threads will
compete for the big lock.
We want disconnect event to finish before connect event. But If
connect thread gets the big lock first, it sets svc->online to
true, and then disconnect thread will et svc->online to false.
So, glustershd will be disconnected from glusterd and wrong status
is shown.
After killing shd, glusterd sleeps for 1 second. To avoid the problem,
If glusterd releses the lock before sleep and acquires it after sleep,
disconnect thread will get a chance to handle the
glusterd_svc_common_rpc_notify before other thread completes connect
event.
Change-Id: Ie82e823fdfc936feb7c0ae10599297b050ee9986
fixes: bz#1585391
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit e589b9717e275a91fcf27a6ef986e09b35c81f4c
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu May 31 23:00:28 2018 -0700
mgmt/glusterd: Cleanup dead code
updates: bz#789278
Change-Id: Id67ab681317eb0a69874400a40e3b249dfc7a7db
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit df9986487837f891e2b37845b6d9bd90c043ddb0
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed May 30 08:15:29 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/,
https://review.gluster.org/#/c/19871/, and
https://review.gluster.org/#/c/19952/
This patch adds version agnostic imports for urllib, cpickle,
socketserver, _thread, queue, etc., suggested by Aravinda in
https://review.gluster.org/#/c/19767/1
Note: Fedora packaging guidelines require explicit shebangs, so
popular practices like #!/usr/bin/env python and #!/usr/bin/python
are not allowed; they must be #!/usr/bin/python2 or #!/usr/bin/python3
Note: Selected small fixes from 2to3 utility. Specifically apply,
basestring, funcattrs, idioms, numliterals, set_literal, types, urllib,
and zip have already been applied.
Note: these 2to3 fixes report no changes are necessary: exec, execfile,
exitfunc, filter, getcwdu, intern, itertools, metaclass, methodattrs, ne,
next, nonzero, operator, paren, raw_input, reduce, reload, renames, repr,
standarderror, sys_exc, throw, tuple_params, xreadlines.
Change-Id: I8d393064a1837874d8b4bc87c8ce05c679664642
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 570b4d8f9528b6f29afaea5cf011af63b44e2956
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sun Jun 3 11:24:18 2018 +0530
rpc/clnt: Don't let consumers manage "connected" state
The state management of "connected" in rpc is ad-hoc as far as the
responsibility goes. Note that there is nothing wrong with
functionality itself. rpc layer manages this state in disconnect
codepath and has exposed an api to manage this one from
consumers. Note that rpc layer never sets "connected" to true by
itself, which forces the consumers to use this api to get a working
rpc connection. The situation is best captured from a comment in code
from Jeff Darcy in glusterfsd/src/gf-attach.c:
-/*
- * In a sane world, the generic RPC layer would be capable of tracking
- * connection status by itself, with no help from us. It might invoke our
- * callback if we had registered one, but only to provide information. Sadly,
- * we don't live in that world. Instead, the callback *must* exist and *must*
- * call rpc_clnt_{set,unset}_connected, because that's the only way those
- * fields get set (with RPC both above and below us on the stack). If we don't
- * do that, then rpc_clnt_submit doesn't think we're connected even when we
- * are. It calls the socket code to reconnect, but the socket code tracks this
- * stuff in a sane way so it knows we're connected and returns EINPROGRESS.
- * Then we're stuck, connected but unable to use the connection. To make it
- * work, we define and register this trivial callback.
- */
Also, consumers of rpc know about state of connection only through the
notifications sent by rpc-clnt. So, consumers don't have any extra
information to manage the state and hence letting them manage the
state is counter intuitive. This patch cleans that up and instead
moves the responsibility of state management of rpc layer into
itself.
Change-Id: I31e641a60795fc480ca753917f4b2579f1e05094
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1585585
commit 77f64903e49eb52b2ac37cc2d681637d9f55003e
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Jun 1 01:48:31 2018 -0400
posix/ctime: Fix fops racing in updating mtime/atime
In distributed systems, there could be races with fops
updating mtime/atime which could result in different
mtime/atime for same file. So updating them only if
time is greater than the existing makes sure, only
the highest time is retained. If the mtime/atime
update comes from the explicit utime syscall, it is
allowed to set to previous time.
Thanks Xavi for helping in rooting the issue.
fixes: bz#1584981
Change-Id: If1230a75b96d7f9a828795189fcc699049e7826e
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit bbf34dd7fb1f1428bdeb0d8447601328e9fe01d0
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed May 30 15:09:29 2018 +0530
dht: Delete MDS internal xattr from dict in dht_getxattr_cbk
Problem: At the time of fetching xattr to heal xattr by afr
it is not able to fetch xattr because posix_getxattr
has a check to ignore if xattr name is MDS
Solution: To ignore same xattr update a check in dht_getxattr_cbk
instead of having a check in posix_getxattr
BUG: 1584098
Change-Id: I86cd2b2ee08488cb6c12f407694219d57c5361dc
fixes: bz#1584098
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 22ba9f77677375f4ae534de28045de73f20cfcac
Author: Levi Baber <baber@iastate.edu>
Date: Thu May 31 15:17:26 2018 -0500
changed 'sometime' messsages to 'some time'
Change-Id: I0936229fc84c011db7791218bb566c971fdea174
fixes: bz#1584864
Signed-off-by: Levi Baber <baber@iastate.edu>
commit 0e11d71e6341479652fe92d2799d593bfdd462af
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu May 31 17:11:01 2018 -0700
features/shard: Fix missing unlock in shard_fsync_shards_cbk()
updates: bz#789278
Change-Id: I745a98e957cf3c6ba69247fcf6b58dd05cf59c3c
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 69504d40fabfe34709fa8ded3dd57244d0b79523
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu May 31 15:11:54 2018 -0700
call-stub: Add a missing break
updates: bz#789278
Change-Id: Id411e69505209c08f33bb77948ee81936dfaef79
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit 37c0908fdf3a2292bbbef076f09f0c6696295b19
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu May 31 16:57:02 2018 +0530
libgfchangelog: Remove duplicate includedir definition for changelog.h
includedir for changelog.h is already defined in Makefile.am under libglusterfs/src
since it was moved from xlators/features/changelog/lib/src. Therefore removing the
duplicate definition.
Change-Id: Iaff2e02fca45715820caa35b41efc2f6b656203a
updates: bz#1193929
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 0a76a84051b93f8cc52a48ee9b6f69aabff2d245
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu May 31 14:17:39 2018 -0700
performance/io-cache: fix a missing unlock
Fixes: bz789278
Change-Id: If8ca1fef8a10f1e7270390b61121f8a20a76b1d0
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
commit a02329187de7748e801d6f7f30b795d8e291c79b
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue May 15 09:22:26 2018 +0530
glusterd: address test failures with brick mux enabled
This patch addresses following:
1. On volume stop, for the last brick, pmap_registry_remove () is
invoked by glusterd.
2. If a brick process is sigkilled, remove all the associated brick
instances from the portmap.
3. Bump up PROCESS_UP_TIMEOUT to 45.
4. gf_attach to kill a brick takes more time in mux (which is an
issue that needs a fix), but in the interim, give br-state-check.t
more time to complete (there are 2 kill_bricks, each taking 120
seconds, and the test usually passes in 30 odd seconds, hence bumping
this up to 350 seconds)
5. The test bug-1559004-EMLINK-handling.t is taking ~950 seconds at
times on master without mux, in mux cases, when it fails, it is almost
at the last iteration, hence bumping the timeout for this test case
to reduce regression error rates
Updates: bz#1577672
Change-Id: I1922675e112baca4c125c4c094eaa42a11e34e67
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit ed3fb14f2d2a9f1e137389fe570b0aab0e2c5aef
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed May 30 09:34:44 2018 +0530
protocol/client: Don't send fops till SETVOLUME is complete
An earlier commit set conf->connected just after rpc layer sends
RPC_CLNT_CONNECT event. However, success of socket level connection
connection doesn't indicate brick stack is ready to receive fops, as
an handshake has to be done b/w client and server after
RPC_CLNT_CONNECT event. Any fop sent to brick in the window between,
* protocol/client receiving RPC_CLNT_CONNECT event
* protocol/client receiving a successful setvolume response
can end up accessing an uninitialized brick stack. So, set
conf->connected only after a successful SETVOLUME.
Change-Id: I139a03d2da6b0d95a0d68391fcf54b00e749decf
fixes: bz#1583937
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit d92e6c0aa1d87a4b4208b21aae48f2e0b3e39ca9
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed May 30 09:36:34 2018 +0530
cluster:dht: Corrected ret code check
syncop functions return -op_errno.
Change-Id: Ifdb1bd1d1d11972b4306a2336e6737d6236a2fb1
fixes: bz#1580238
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 84cda6024aa25e6d3984338f0d3cbd4fc2f68077
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed May 2 08:48:32 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/ and
https://review.gluster.org/#/c/19871/
Selected small fixes from 2to3 utility. Specifically apply, basestring,
funcattrs, idioms, numliterals, set_literal, types, urllib, zip
Note: these 2to3 fixes report no changes are necessary: exec, execfile,
exitfunc, filter, getcwdu, intern, itertools, metaclass, methodattrs, ne,
next, nonzero, operator, paren, raw_input, reduce, reload, renames, repr,
standarderror, sys_exc, throw, tuple_params, xreadlines.
Any 2to3 fixes not in the above two lists have more extensive changes
which will follow in separate patches.
most unicode changes suggested by 2to3 will need to be applied at the
same time as changing the shebangs from python2 to python3. Prashanth
notes that unicode strings in py2 need 'u' prefix; unicode strings in
py3 3.0, 3.1, and 3.2 a 'u' prefix will throw an error, but in py3 3.3+
it is legal (or just ignored). All Linux dists we care about have 3.3
or later so we can leave 'u' prefixes on unicode strings.
Change-Id: I49bba2f328b0ee24b9a8115a7183be979981563e
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 71eda2d21c986145a0da0c3ca07cf5339d172c18
Author: hari gowtham <hgowtham@redhat.com>
Date: Fri May 18 15:05:37 2018 +0530
Core: The lock contention on gf_client_dump_inodes_to_dict
Problem: For a distributed replicated volume, in the inode status
command the lock on gf_client_dump_inodes_to_dict is held by the
first brickop. while this is being processed, if the second brickop
comes. It fails to get the lock and the whole brick op fails.
Fix: Instead of using a TRY_LOCK which errors out if the lock is busy,
Use LOCK which will wait till the lock is acquired.
Change-Id: I768a0a1b60f28c4f7f94549e18ee3765b69cc528
fixes: bz#1579769
Signed-off-by: hari gowtham <hgowtham@redhat.com>
commit e3995d5fff9362bcee74db64859b14c9ae61a1a5
Author: Susant Palai <spalai@redhat.com>
Date: Tue May 22 19:55:27 2018 +0530
cloudsync: Adding s3 plugin for cloudsync
This is a plugin which provides an interface to retrive files from amazon-s3
which are archived in to s3.
Users need to give the above information for cloudsync to retrieve the file
from s3.
TODO:
1- A separate commit in to developer-guide will detail about the usage
of this plugin in more detail.
2- Need to create target file in aws-bucket with "gfid" names. Helps avoiding
name collisions.
Change-Id: I2e4a586f4e3f86164de9178e37673a07f317e7d9
Updates: #387
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 9223e763efaa0c36c2da4c14127bbb9727e75167
Author: Susant Palai <spalai@redhat.com>
Date: Mon May 14 11:13:23 2018 +0530
feature/cloudsync: Dev guide to write a Cloudsync Plugin
Updates: #387
Change-Id: I50ef84e5e67a648384394dfad003884d25a4c746
Signed-off-by: Susant Palai <spalai@redhat.com>
commit c23730af9dac0b330d86a7e0f68dea3d33f5b386
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue May 22 15:48:16 2018 +0530
thin-arbiter : Provide scripts and service file to start thin-arbiter process
1 - setup-thin-arbiter.sh
To setup directory path for thin-arbiter. This is the path where replica id
file will be placed and used by TA process.
By default it will be /mnt/thin-arbiter. It is better to use default path
and once set it should not be changed.
2 - gluster-ta-volume.service
This is the Unit file used by systemd to start and keep the thin-arbiter
process running.
3 - thin-arbiter.vol
This is the default volume file for thin-arbiter. It will be used to start
thin-arbiter process. This should not be modified by user except the
directory path which can be modified using [1].
Change-Id: I68f2164f24adfa326c1d1a7a98c6ac4ff04ed553
fixes: bz#1579786
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 9d1500d10afe765772082e2c8037123c594e3cee
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue May 29 14:57:44 2018 +0530
dht: Excessive 'dict is null' logs in dht_revalidate_cbk
Problem: In case of error(ESTALE/ENOENT) dht_revalidate_cbk
throws "dict is null" error because xattr is not available
Solution: To avoid the logs update condition in dht_revalidate_cbk
and dht_lookup_dir_cbk
BUG: 1583565
Change-Id: Ife6b3eeb6d91bf24403ed3100e237bb5d15b4357
fixes: bz#1583565
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 2280384630f4b9cacb1f1492f42bd1a5343bd9a1
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri May 25 12:27:43 2018 +0530
performance/open-behind: open pending fds before permission change
setattr, posix-acl and selinux changes on a file can revoke permission
to open the file after permission changes. To prevent that, make sure
the pending fd is opened before winding down setattr or setxattr (for
posix-acl and selinux) calls.
Change-Id: Ib0b91795d286072e445190f9a1b3b1e9cd363282
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
fixes: bz#1405147
commit 8c7d163b3d3f9f9de03c6317a606a7743616ea52
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Thu Jan 11 12:24:35 2018 +0530
Quota fsck script
script can be used to for 3 purposes
1) Extract marker xattr from the backend with a crawl (for analysis)
2) Report anomalies in accounting by comparing stat based accounting
with marker translator's accounting
3) Fix anomalies in the FS by marking the anamolous directories dirty
and having them heal in a bottom up fashion over the directory tree.
Change-Id: Ib4d4a6d1886d7332c80d5a93f7afccaa0f52ab58
fixes: #390
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
commit d190bc55a1dfad292ce0ad1b3552eed4f0cbe907
Author: Milind Changire <mchangir@redhat.com>
Date: Sat May 26 12:36:04 2018 +0530
rpc: conditionally cleanup event slot
Problem:
socket_server_event_handler() may call rpc_transport_unref() for a
socket which may fail registration with the event sub-system.
This causes an assert to fail in event_unregister_epoll_common()
Solution:
Conditionally cleanup event slot only if slot index >= 0
Change-Id: I6ca7c133712e894adc335c7763879691b7e4b213
fixes: bz#1582704
BUG: 1582704
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 4b9235b744a9da383994c6c4cdb271bd45d89796
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri May 25 08:50:19 2018 +0530
performance/read-ahead: throwaway read-ahead cache of all fds on writes on any fd
This is to make sure applications that read and write on different fds
of the same file work.
This patch also fixes two other issues:
1. while iterating over the list of open fds on an inode, initialize
tmp_file to 0 for each iteration before fd_ctx_get to make sure we
don't carry over the history from previous iterations.
2. remove flushing of cache in flush and fsync as by themselves, they
don't modify the data
Change-Id: Ib9959eb73702a3ebbf90badccaa16b2608050eff
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1512691
commit f16fa04b01a98193c7b388d098ac27e84b71f547
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri May 25 08:16:41 2018 +0530
Revert "performance/write-behind: fix flush stuck by former failed writes"
This reverts commit 9340b3c7a6c8556d6f1d4046de0dbd1946a64963.
operations/writes across different fds of the same file cannot be
considered as independent. For eg., man 2 fsync states,
<man 2 fsync>
fsync() transfers ("flushes") all modified in-core data of
(i.e., modified buffer cache pages for) the file referred to by the
file descriptor fd to the disk device
</man>
This means fsync is an operation on file and fd is just a way to reach
file. So, it has to sync writes done on other fds too. Patch
9340b3c7a6c, prevents this.
The problem fixed by patch 9340b3c7a6c - a flush on an fd is hung on a
failed write (held in cache for retrying) on a different fd - is
solved in this patch by making sure __wb_request_waiting_on considers
failed writes on any fd as dependent on flush/fsync on any fd (not
just the fd on which writes happened) opened on the same file. This
means failed writes on any fd are either synced or thrown away on
witnessing flush/fsync on any fd of the same file.
Change-Id: Iee748cebb6d2a5b32f9328aff2b5b7cbf6c52c05
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1512691
commit 94606303873a833851772ea2f508914940885d15
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Apr 17 18:10:01 2018 +0530
glusterd: glusterd is releasing the locks before timeout
Problem: We introduced lock timer in mgmt v3, which will realease
the lock after 3 minutes from command execution. Some commands related
to heal/profile will take more time to execute. For these comands
timeout is set to 10 minutes. As the lock timer is set to 3 minutes
glusterd is releasing the lock after 3 minutes. That means locks are
released before the command is completed its execution.
Solution: Pass a timeout parameter from cli to glusterd, when there
is a change in default timeout value(i.e, default timeout value can
be changed through command line or for the commands related to profile/heal
we will change the default timeout value to 10 minutes.) glusterd will
set the lock timer timeout according to the timeout value passed.
Change-Id: I7b7a9a4f95ed44aca39ef9d9907f546bca99c69d
fixes: bz#1577731
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 6f29738713344766162f29d38ca7b035da4fc444
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Nov 1 11:54:27 2016 +0530
performance/quick-read: Use generation numbers to avoid updating the cache with stale data
Thanks to Pranith for the example. Following is the race we are trying
to solve with this patch.
1) We have a file with content 'abc'
2) lookup and writev which replaces 'abc' with 'def' comes. Lookup
fetches abc but yet to update the cache, and then immediately
writev is wound which zeros out the cache. Now lookup_cbk updates
the buffer with 'abc' even though on disk it is 'def'. Now writev
completes and returns to application.
3) application does a readv which will be fetched from quick-read as
'abc'.
Change-Id: I9a9cab9c99652aa6d17230a4fe4dc034ec502b1b
BUG: 1390050
Updates: bz#1390050
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 5a77f3187f850b07c447fa4ed5e198cf8819f45f
Author: Susant Palai <spalai@redhat.com>
Date: Mon May 21 11:51:47 2018 +0530
cluster/dht: Increase failure count for lookup failure in remove-brick op
An entry from readdirp might get renamed just before migration leading to
lookup failures. For such lookup failure, remove-brick process does not
see any increment in failure count. Though there is a warning message
after remove-brick commit for the user to check in the decommissioned brick
for any files those are not migrated, it's better to increase the failure count
so that user can check in the decommissioned bricks for files before commit.
Note: This can result in false negative cases for rm -rf interaction with
remove-brick op, where remove-brick shows non-zero failed count, but the
entry was actually deleted by user.
Fixes :bz#1580269
Change-Id: Icd1047ab9edc1d5bfc231a1f417a7801c424917c
fixes: bz#1580269
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 30bfd785c2b703e17cebabf6ed75895c2280f949
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri May 25 08:55:11 2018 -0400
libgfapi: Fix lookup on root
Lookup on root was sending "/" as the path.
This will break the basename calculation in
loc_copy and hence lookup on root was failing
if the loc_copy was involved in the stack.
With ctime, a first lookup on root initiates
a metadata self heal because of ctime xattr
not being same on all afr subvolumes. This
results in loc_copy and hence the failure
of lookup.
Fix would be to send path with "." for the root.
fixes: bz#1582516
Change-Id: Iafe4b99f249a4f5034ad34c1d30590de0e35aa0d
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 7648f6aeae2a34e880c44fa4b6b9e0fa14350136
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Feb 16 11:29:12 2018 +0100
tests: run-tests-in-vagrant.sh should return test status
The ./run-tests-in-vagrant.sh script does not return the correct exit
status. Even if the tests in the Vagrant VM fail, the script returns
success. This throws off the expectations that any regular testers (or
CI) have.
BUG: 1546103
Change-Id: I7f00903f9fe4ef3be8ba80db0f9aa8d412502b86
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 721926662c2ff8b4ab4d4f5278404b3f788352e1
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu May 17 15:55:44 2018 +0530
feature/locks: Unwind response based on clinet version
Change-Id: I6fc7755cca0d6f61cb775363618036228925842c
fixes: bz#1570538
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 8ecb377ff15c03e0021c079aa3f1c15a5a966c96
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon May 21 16:18:53 2018 +0530
glusterd: memory leak in geo-rep status
Fixes: bz#1580352
Change-Id: I9648e73090f5a2edbac663a6fb49acdb702cdc49
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit ee1320a307d649d2c6022f1ec9ed94744f048b58
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri May 25 17:21:58 2018 +0530
tests/bug-1543279: mark it as bad
There seems to be races which are not fixed by commit
9704d203f0. Though the test itself is not bad, it is failing very
frequently. So, till the issue is fixed, marking this test as bad.
updates: bz#1543279
Change-Id: I4a5869da1586178914ffb9563414879e6beab183
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 05c30e427dd9ec0a0c18a3fb1cd0d993790221ec
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Apr 16 13:49:44 2018 +0530
add COMMITMENT file as part of GPL cure
This is part of more broader commitment Red Hat along with
IBM, Google, and Facebook did in November 2017.
More on this can be found in the blog @
https://www.redhat.com/en/blog/fostering-greater-open-source-development &
https://www.redhat.com/en/about/gplv3-enforcement-statement
fixes: bz#1569345
Change-Id: Ia78023540ab587ebe14048a67413029be309413d
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit f92540771de746efca9d14ebccfa8df84ac8e331
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed May 23 11:25:26 2018 -0400
api: missing __THROW on pub function decls
missing __THROW on pub function decls needed for C++
Change-Id: Ia0ff09d311741e4cdc8ef171e07bbd56c24b9260
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 0923383390e01d24b8d2b59d1570a29dfa91d7d1
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri May 18 20:03:32 2018 +0530
changelog: fix br-state-check.t failure for brick_mux
Problem: Sometime br-state-check.t crash while runnning
for brick multiplex and command in test case is
taking 2 minutes for detach a brick
Solution: Update code in changelog xlator specific to wait
on all connection before cleanup rpc threads and
cleanup rpc object only in non brick mux scenario
BUG: 1577672
Change-Id: I16e257c1e127744a815000b87bd8b7b8d9c51e1b
fixes: bz#1577672
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit e1b90100316917d0bb73a0f2bd5afa8ff3c8141f
Author: Poornima G <pgurusid@redhat.com>
Date: Thu May 24 11:02:53 2018 +0530
Fix a test case that can fail for certain builds
If certain builds have readdir-ahead disabled by default, the
test case fails, as it asumes readdir-ahead is enabled by
default. Hence explicitly enabling readdir-ahead.
Change-Id: Ib5bef266707c2c557aeb2cf2ffbf4d0c92025c46
fixes: bz#1582051
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit e7997094433928e69362bf2d45d24f6fce511e21
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue May 22 00:34:48 2018 -0400
posix/ctime: Fix updating mtime to older time
With ctime feature enabled, the mtime is not
updated when it's set to time older than the
existing one. Fixed the same. But the ctime
is not allowed to change to older dates.
fixes: bz#1581035
Change-Id: If520922df42d6ce084c8df3046c138f8367164e5
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit e4d60542735d92035242741b7a7c300837fa3623
Author: Susant Palai <spalai@redhat.com>
Date: Fri May 18 12:20:08 2018 +0530
core: make glfs_iobuf_copy() consumable for general purpose.
Currently plugins for cloudsync will be using it to write back data
downloaded from remote store/cloud.
Change-Id: I59f10bebed21b19568c94cbf29e3d536d5570749
Updates: #387
Signed-off-by: Susant Palai <spalai@redhat.com>
commit a3ef39d87c21e724e42c5a5b1926882b3719db1d
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon May 21 12:57:45 2018 -0400
posix/ctime: Fix gfid heal on first lookup
With ctime feature enabled, the gfid is
not healing on first lookup. The fresh
file logic depends on ctime and it was
fetching from backend instead of xattr
with ctime feature enabled. Fixed the
same.
Also fixed a possible hang with inode lock
Change-Id: I020875c0462b284d6fa0e68304a422fa3d6a3e73
fixes: bz#1580532
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit fde00a13fb429b1fcb31b375890e3bce52405020
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon May 21 14:51:44 2018 -0400
storage/posix: use proper FOP for unwinding readdir(p)
As of now, even for readdirp, posix is unwinding with readdir
signature.
Change-Id: I6440c8a253c5d78bbcc97043e4e6e208e3d47cd1
fixes: bz#1581345
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 518476cc1d2573b4d87bd13ce196c7a322a724ef
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon May 21 12:57:45 2018 -0400
posix/ctime: Fix atime update for hardlink
With ctime feature enabled, atime is not
being updated for a hardlink when the file
is accessed.
e.g., touch -a <hardlink_file> fails to
update atime. This patch fixes the same.
fixes: bz#1580529
Change-Id: I2201c88d502d0070300a1f5023af1b36951284ec
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 5e1ee9c01db812ed14f6b927c72cdbf3d5e5ede0
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon May 21 11:04:45 2018 +0530
cluster/dht: Fix rebalance log msg
Corrected the name of the xattr and fixed
the code to log an error only if op_errno
is not ENODATA or ENOATTR.
Change-Id: I42c5b1d838eec586ac7bed2471eb1d27ff09a9ea
fixes: bz#1580238
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 9d1fcd8fec20b6d66a74d770a75702b8c94bfc0a
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Apr 13 12:03:48 2018 +0530
sdfs: enable by default
also provide an option for pass-through to enable/disable xlator
fixes: #421
Change-Id: Ie30a91ad09620db62ab07b797e23123fd1200d1f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit d9e212b778a47565a668865085200bd7bb793a94
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue May 15 13:33:16 2018 -0400
ctime: Fix updating ctime in rename and unlink
1. Successful rename was not updating ctime.
Fixed the same.
2. Successful unlink when link count is more than 1
was not updating ctime. Fixed the same.
3. Copy ctime and flags during frame copy.
fixes: bz#1580020
Change-Id: Ied47275a36aea60254b2add7a59128a9c83b3645
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit a0b3a741489a96ac0c359fd97c8635b1f1ec0594
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue May 22 19:15:19 2018 +0530
features/sdfs: implement readdirp
Since readdirp acts as a batched lookup for all dentries it reads, it
has to synchronize with any entry operation within the directory being
read.
Change-Id: I923a6ebd21856dbaa5fa5db4a26a29b7b29b3159
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
fixes: #421
commit 906431686db7459e38b45d03b5a71c072dc365d2
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu May 17 05:28:24 2018 -0400
rpc: Don't reset auth_value in disconnect
The auth_value was being reset to AUTH_GLUSTERFS_v2
during rpc disconnect. It shoud not be reset. The
disconnect during portmap request can race with
handshake. If handshake happens first and
disconnect later, auth_value would set to default
value and it never sets back to actual auth_value
fixes: bz#1579276
Change-Id: Ib46c9e01a97f6defb3fd1e0423fdb4b899b4a361
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 56bfe07854894f9f8ac5a2716cdf28702f8d3885
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue May 15 11:37:16 2018 +0200
cluster/ec: Fix pre-op xattrop management
Multiple pre-op xattrop can be simultaneously being processed. On the cbk
it was checked if the fop was waiting for some specific data (like size and
version) and, if so, it was assumed that this answer should contain that
data.
This is not true, since a fop can be waiting for some data, but it may come
from the xattrop of another fop.
This patch differentiates between needing some information and providing it.
This is related to parallel writes. Disabling them fixed the problem, but
also prevented concurrent reads. A change has been made so that disabling
parallel writes still allows parallel reads.
Fixes: bz#1578325
Change-Id: I74772ad6b80b7b37805da93d5ec3ae099e96b041
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 6c48d9d5b2adb17dc191a7bb66545a9a5a6c62c5
Author: ShyamsundarR <srangana@redhat.com>
Date: Wed May 23 10:16:37 2018 -0400
test: Marking test case bug-1309462.t as bad
Details in the bug
Updates: bz#1581735
Change-Id: Id984e10b60daf274d5510e3ccbf7abf0cb19f368
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit c26ba1b3812eb52d19e0d3d2cc190f18deae9181
Author: Susant Palai <spalai@redhat.com>
Date: Thu May 3 17:41:16 2018 +0530
features/cloudsync: Make plugins configurable
This patch brings the configuration option for plugins.
For new plugins, an entry has to be created in to cs_plugin structure e.g.
struct cs_plugin plugins[] = {
{
.name = "amazons3",
.library = "libamazons3.so",
.description = "amazon s3 store."
},
{.name = NULL},
};
Library field describes the name of the shared library for the plugin.
To configure plugin type "feature.cloudsync-storetype" option need
to be set to the remote-store type. e.g.
gluster volume set VOLNAME cloudsync-storetype amazons3. This should be same
as the ".name" field in cs_plugin structure.
cs_init will pick this up in run time to load the plugin.
Change-Id: I2cec10b206f71ac4e71d472631a3a5badf278b59
fixes: bz#1576842
Signed-off-by: Susant Palai <spalai@redhat.com>
commit bbf78ee6a380acb1af7c11f7593d4d98f3244c63
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri May 18 15:38:29 2018 +0530
afr: fix bug-1363721.t failure
Problem:
In the .t, when the only good brick was brought down, writes on the fd were
still succeeding on the bad bricks. The inflight split-brain check was
marking the write as failure but since the write succeeded on all the
bad bricks, afr_txn_nothing_failed() was set to true and we were
unwinding writev with success to DHT and then catching the failure in
post-op in the background.
Fix:
Don't wind the FOP phase if the write_subvol (which is populated with readable
subvols obtained in pre-op cbk) does not have at least 1 good brick which was up
when the transaction started.
Note: This fix is not related to brick muliplexing. I ran the .t
10 times with this fix and brick-mux enabled without any failures.
Change-Id: I915c9c366aa32cd342b1565827ca2d83cb02ae85
updates: bz#1577672
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 95241913c36e894fbc765e825e55e1389260bd29
Author: Gergo Huszty <gergo.huszty@nokia.com>
Date: Wed May 16 13:28:21 2018 +0000
Fix for memory-leak in crypt xlator
Crypt xlator occasionaly uses local storage in it's call frame.
These frames are managed with common macroes, which does not take
care about cleaning up such local storages. The fix is similar to
the other xlators' solution. A crypt specific macro handles the
cleaning of the local storage when it is allocated.
Change-Id: Ibb5b91551fbe70905e9c8c688d999fe702433e35
fixes: bz#1564419
Signed-off-by: Gergo Huszty <gergo.huszty@nokia.com>
commit 4f4c66e7c1b3765f3f7091cf2f2e9eccf7309ee0
Author: Csaba Henk <csaba@redhat.com>
Date: Tue May 8 21:19:56 2018 +0200
posix: use the ctime framework to handle setattr ctime payload
Work on #208 having been been merged, we have obtained
means to associate arbitrary ctimes with files, so
we can handle setattr ctime payload with proper semantics.
Updates: #435
Change-Id: I7302a3ee2574ca9bba605c7a8586c16c452f82c1
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit cc5cb34dcaa3f1a84cdb7a869ac9c108036a3186
Author: Prashanth Pai <ppai@redhat.com>
Date: Thu May 10 18:25:56 2018 +0530
build: Disallow unresolved symbol references
In the past, it was often[1] forgotten for xlators to be linked against
the symbols they refer to. This often caused glusterd2 to fail while
loading xlator's shared object (.so) file.
This change adds "--no-undefined" as a linker flag which causes the
linker to treat unresolved symbol references as an error and hence fail
linking.
[1]:
https://review.gluster.org/#/c/19912/
https://review.gluster.org/#/c/19664/
https://review.gluster.org/#/c/19056/
https://review.gluster.org/#/c/17659/
https://bugzilla.redhat.com/show_bug.cgi?id=1532238
Bonus:
Added cloudsync and utime xlator's generated source files to .gitignore
Updates: bz#1193929
Change-Id: I9604a4a87b7313a5fa43bda5fdb37dfa7ef8facd
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit 05f0289ed6756a2727e1e23fe74c4181dc524460
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri May 4 12:25:48 2018 -0400
make posix return errors when gfid2path key is absent
Change-Id: I3a8d452d00560dac5e0b7ff0b1835d1f20a59f91
updates: bz#1570962
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 62933db7dda1889bbbfceb9b1ebbc7a6a6a9714d
Author: Poornima G <pgurusid@redhat.com>
Date: Tue May 8 10:35:35 2018 +0530
extras/create_new_xl : Fix the tool to accomodate the xl structure changes
Change-Id: I3524e62b0ed873c0763ca38f80fcd53b22ee79d1
fixes: bz#1577744
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 6af4186feff04028a612b24332a05406a6e6b080
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed May 16 18:15:02 2018 +0530
cluster/dht: Remove EIO from dht_inode_missing
Removed EIO from the list of errnos that triggered
a migrate check task.
Change-Id: I7f89c7a16056421588f1af2377cebe6affddcb47
fixes: bz#1578823
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 85682be34f90b98401cfc5f12a115ca744560e5a
Author: Poornima G <pgurusid@redhat.com>
Date: Wed May 16 11:00:32 2018 +0530
readdir-ahead: Fix an issue with parallel-readdir and readdir-optimize
Issue: When parallel-readdir is enabled, readdir-optimize automatically
stops working because of a bug in rda_opendir.
RCA: In rda_opendir, the xattrs that indicate readdir-optimize or not
is sent in xdata. This xdata is sent to all the readdirp prefetch
calls. A dict_ref is taken on xdata and kept in rda_opendir to be
used by rda_fill_fd, but dht_opendir deletes some elements in xdata
after calling rda_opendir. Hence dict_ref is not a right choice here,
dict_copy needs to used.
Change-Id: Ie7cc7ceb03117dd4179ef7905647f2f123f94966
fixes: bz#1578650
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit fbab7c22c85bf7fee2666c39a39311aa769ad024
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed May 9 00:56:11 2018 +0530
client/protocol: fix the log level for removexattr_cbk
noticed that server protocol actually logs all the errors for
removexattr as INFO, instead of WARNING like client, and hence,
doesn't create a confusion in user.
updates: bz#1576418
Change-Id: Ia6681e9ee433fda3c77a4509906c78333396e339
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 2492b1d77a218de797e1b7897b314574bff423f5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 16 14:12:21 2018 +0530
statedump: Prevent duplicate statedump for master and active
Csaba found that statedump of fusemount has two instances of
each of the mem-accounting information. On debugging, I realized
that statedump is called for both ctx->master and ctx->active.
Since ctx->active is a sub-graph of ctx->master, there are duplicate
entries. Fixed this part to prevent duplication in this patch.
fixes bz#1578721
BUG: 1578721
Change-Id: I5a63b4f5933d4d720ac010c58e6dee3b27067d42
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit a48e7b357c07b2080fbcb4743e07cba160bd87f5
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sun May 13 21:03:12 2018 +0530
cli: Fix for gluster volume info --xml
Problem: gluster volume info --xml is showing same uuid to all
the bricks of a tier volume.
Solution: While iterating over hot/cold bricks of a tier volume, use
correct iterator.
Fixes: bz#1577627
Change-Id: Icf6a9c2a10b9da453abc262a57b7884d6638e3ed
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit c5570f49caf0c0ee077943227be7e5b40b2afe5d
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Sun May 13 12:01:01 2018 +0530
glusterfs: Resolve brick crashes at the time of inode_unref
Problem: Sometimes brick process is getting crash at the time
of calling inode_unref in fd_destroy
Solution: Brick process is getting crash because inode is already
free by xlator_mem_cleanup call by server_rpc_notify.To
resolve the same move code specific to call transport_unref
in last in free_state.
BUG: 1577574
Change-Id: Ia517c230d68af4e929b6b753e4c374a26c39dc1a
fixes: bz#1577574
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit eaf70e3f2aa18f704df8c1dd17e83c7e97b0cff1
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed May 9 01:10:29 2018 -0400
geo-rep/scheduler: Fix crash
Fix crash where session_name is referenced
before assignment. Well, this is a corner
case where the geo-rep session exists and
the status output doesn't show any rows.
This might happen when glusterd is down
or when the system is in inconsistent state
w.r.t glusterd.
fixes: bz#1576179
Change-Id: Iec1557e01b35068041b4b3c1aacee2bfa0e05873
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 72ebf7b0b18a4ec7a03aeeb538e18f48f82eae1e
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon May 7 06:35:25 2018 -0400
glusterd/geo-rep: Fix glusterd crash
Using strdump instead of gf_strdup crashes
during free if mempool is being used.
gf_free checks the magic number in the
header which will not be taken care if
strdup is used.
fixes: bz#1576392
Change-Id: Iab36496554b838a036af9d863e3f5fd07fd9780e
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit e64752ca74dd98cf77e8435bbf31c68f3eae0bac
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue May 8 11:42:33 2018 +0530
Glusterfsd: brick crash during get-state
The xprt's dereferencing wasn't checked before using it for the
strcmp, which caused the segfault and crashed the brick process.
fix: Check every deferenced variable before using it.
Change-Id: I7f705d1c88a124e8219bb877156fadb17ecf11c3
fixes: bz#1575864
Signed-off-by: hari gowtham <hgowtham@redhat.com>
commit b1b7926cfba6891d6d743bf49ab9da74f6f20579
Author: Varsha Rao <varao@redhat.com>
Date: Wed Mar 21 16:29:04 2018 +0530
libglusterfs/stack: Fix coverity issue
Fix ARRAY_VS_SINGLETON coverity issue.
Change-Id: I9e70be026e80011dfc8fb0f06c4563895eb6daf4
fixes: bz#1558574
Signed-off-by: Varsha Rao <varao@redhat.com>
commit f2a32b8c4fac44b2f26cde4e07dd423a50c22711
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu May 10 16:54:44 2018 +0530
dht: Excessive 'dict is null' logs in dht_discover_complete
Problem: In Geo-Rep setup excessive "dict is null" logs in
dht_discover_complete while xattr is NULL
Solution: To avoid the logs update a condition in dht_discover_complete
BUG: 1576767
Change-Id: Ic7aad712d9b6d69b85b76e4fdf2881adb0512237
fixes: bz#1576767
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit d4359ea77e900deb6b782c9fe36778aaec907ff0
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon May 7 14:52:44 2018 -0400
gfapi: various broken symbol versions
lots of breakage in symbol versions:
symbols added in 4.1 incorrectly, and
symbols added in 4.1 but labeled 4.0.0, and
symbols added in 3.13 incorrectly
Not noticed until someone tried to build 3.13.2 on FreeBSD 11.1,
despite the fact that we build on FreeBSD 10.3 IIRC, somehow the
3.13 errors aren't a build error there.
Note: in rereading the Ulrich Drepper write-up I noticed that when
a symbol version is changed, you are supposed to leave the old
symbol in its original section in addition to adding it to its new
section. Adding back those symbols to their original sections.
Reported-by: Roman Serbski <mefystofel@gmail.com>
Change-Id: I9a883546d08e0847f7228d8ea5943bc54275b319
fixes: bz#1575716
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 41ba42f328e2dee3c213e81daa55dbfe3a7fd0c0
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue May 8 10:55:53 2018 +0530
features/cloudsync: Remove multiple definition in Makefile.am
CLOUDSYNC_SRC is defined twice in the same Makefile.am which generates
the following warning:
xlators/features/cloudsync/src/Makefile.am:9: warning: CLOUDSYNC_SRC multiply defined in condition TRUE ...
xlators/features/cloudsync/src/Makefile.am:5: ... 'CLOUDSYNC_SRC' previously defined here
Therefore removing the duplicate definition.
Change-Id: I00c3e2f3d64ad45e4080c2c82766516cd3e2bf63
fixes: bz#1193929
BUG: 1193929
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit de7b8124592aae5d537a736584823aaaa4c1cf29
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed May 9 07:06:38 2018 -0400
core: FreeBSD has pthread_set_name_np() (versus pthread_setname_np())
And has had it since at least FreeBSD 9.0
Reported-by: Roman Serbski <mefystofel@gmail.com>
Change-Id: I52cfde7f2f7a82d0e66465ac392ed7e201e1653b
updates: bz#1193929
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 7f255f26640fdcc9816ebacf6fde3f6af8c5a899
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Tue May 8 11:41:11 2018 +0530
Quota: Turn on ssl for crawler clients if needed
Problem: Quota uses per brick client generated by
glusterd_generate_client_per_brick_volfile to crawl the
individual bricks. These clients were not being configured
with ssl if volume has client.ssl turned on.
Solution: turn on client.ssl if the volume has client.ssl
option set to on.
Change-Id: Id3a13d5110c4376d734480c42da1ce6844cc8240
fixes: bz#1575858
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
commit ee32eebb952c8a9f143c0da58125ca6a08b1df42
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri May 4 10:34:13 2018 +0530
cluster/dht: Debug virtual xattrs for dht
Provide a virtual xattr with which to query
the hashed subvol for a file.
Change-Id: Ic7abd031f875da4b9084841ea7c25d6c8a851992
fixes: bz#1574421
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 0fa541b9a74135978e47d8560c357c68aed49a01
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue May 8 13:34:35 2018 +0530
cluster/dht: Debug logs in dht_readdir(p)_cbk
Additional log messages to help debug issues
with file listings.
Change-Id: Iccd07498ba01d597c0c40f026f4177dd06d7e901
fixes: bz#1575887
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 8e54a40a2530c53f51508f7e35585915f16e2982
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Apr 17 23:05:54 2018 +0530
protocol/server: don't assume there would be a volfile id
Earlier glusterfs never had an assumption someone would start it with
right arguments, and brick processes would be spawned by a management
layer. It just assume the role based on the volfile. Other than
volfile, no other arguments should be technically mandatory for
working of glusterfs. With this patch, that assumption holds true.
Updates: github issue # 352
A note on why this particular issue for this basic sanity?
As per the design of thin-arbiter/tie-breaker, it can be started
independently on any machine, without need of glusterd. So, similar
to 'glusterd', we should be able to spawn a process with any translator
without options/volume id etc.
fixes: bz#1569399
Change-Id: I5c0650fe0bfde35ad94ccba60e63f6cdcd1ae5ff
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit deb9d37f2121c99d82d9900294d7f1f19f7ec59d
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue May 8 14:52:04 2018 +0530
dht: Avoid dict log flooding for internal MDS xattr
Problem: Before populate MDS internal xattr first dht checks if MDS is
present in xattr or not.If xattr dictionary is NULL dict_get
log the message either dict or key is NULL
Solution: Before call dict_get check xattr, if it is NULL then no
need to call dict_get.
BUG: 1575910
Change-Id: I81604ec5945b85eba14b42f4583d06ec713028f4
fixes: bz#1575910
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit c7fd82649bf9226da28139ad87645d4e06948e9c
Author: ShyamsundarR <srangana@redhat.com>
Date: Mon May 7 14:51:06 2018 -0400
glusterd: Update op-version for master
Updated the op-version on master to the next release
op-version, for any future options appearing on master.
Fixes: bz#1575742
Change-Id: I861d489573360e6679c6f5ffe127835ea71f2dda
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 2b60b51f217fac265af4aebad6bd13863d1a1f40
Author: Michael Adam <obnox@samba.org>
Date: Sun May 6 14:53:08 2018 +0200
heal: improve output of heal info
The output of "gluster volume heal <volume> info" is clobbered with
extra new lines when messages "- Possibly undergoing heal" or " - Is in
split-brain" are printed for listed files.
This patch fixes the output by removing the extra new lines.
Bug: 1575381
Change-Id: Ifb614e0fb7c85f7af3a799958d3645a2bff2b53a
fixes: bz#1575381
Signed-off-by: Michael Adam <obnox@samba.org>
commit d9381d8fb776d67b94a025f358081261c17bcfd1
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Apr 13 10:28:01 2018 +0530
fuse: make sure the send lookup on root instead of getattr()
This change was done in https://review.gluster.org/16945. While the
changes added there were required, it was not necessary to remove the
getattr part. As fuse's lookup on root(/) comes as getattr only, this
change is very much required.
The previous fix for this bug was to add the check for revalidation in
lookup when it was sent on root. But I had removed the part where
getattr is coming on root. The removing was not requried to fix the
issue then. Added back this part of the code, to make sure we have
proper validation of root inode in many places like acl, etc.
updates: bz#1437780
Change-Id: I859c4ee1a3f407465cbf19f8934530848424ff50
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit bce4e10fa583eebb5809d4c5a625037e7cd7439b
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Apr 6 01:53:45 2018 +0530
glusterd: handling brick termination in brick-mux
Problem: There's a race between the glusterfs_handle_terminate()
response sent to glusterd from last brick of the process and the
socket disconnect event that encounters after the brick process
got killed.
Solution: When it is a last brick for the brick process, instead of
sending GLUSTERD_BRICK_TERMINATE to brick process, glusterd will
kill the process (same as we do it in case of non brick multiplecing).
The test case is added for https://bugzilla.redhat.com/show_bug.cgi?id=1549996
Change-Id: If94958cd7649ea48d09d6af7803a0f9437a85503
fixes: bz#1545048
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit ad4e81b67ceb22b8d082b758dcfe704ab8fb9ead
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon May 7 01:23:46 2018 -0400
geo-rep: Fix upgrade issue
Cause and Analysis:
The last synced changelog for entry operations is
marked in current version to avoid re-processing
of already processed entry operations in a batch
during crash/restart of geo-rep. This was not
present in previous versoins.
The marker is maintained in the dictionary with the
key 'last_synced_entry' and dictionary is persisted
into status file. So upgrading to current version in
which the marker is present was failing with KeyError.
Solution:
Load the dictionary with default keys first which
contains all the keys including latest ones and then
load the values from status file instead of doing
otherwise.
fixes: bz#1575490
Change-Id: Ic654e6f9a3c97f616761f1362f890352a2186fb4
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit d0fd121214daabe6f31cc91ad195bb24969ab20a
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Feb 8 17:12:41 2018 +0530
cluster/dht: fixes to parallel renames to same destination codepath
Test case:
# while true; do uuid="`uuidgen`"; echo "some data" > "test$uuid"; mv
"test$uuid" "test" -f || break; echo "done:$uuid"; done
This script was run in parallel from multiple mountpoints
Along the course of getting the above usecase working, many issues
were found:
Issue 1:
=======
consider a case of rename (src, dst). We can encounter a situation
where,
* dst is a file present at the time of lookup
* dst is removed by the time rename fop reaches glusterfs
In this scenario, acquring inodelk on dst fails with ESTALE resulting
in failure of rename. However, as per POSIX irrespective of whether
dst is present or not, rename should be successful. Acquiring entrylk
provides synchronization even in races like this.
Algorithm:
1. Take inodelks on src and dst (if dst is present) on respective
cached subvols. These inodelks are done to preserve backward
compatibility with older clients, so that synchronization is
preserved when a volume is mounted by clients of different
versions. Once relevant older versions (3.10, 3.12, 3.13) reach
EOL, this code can be removed.
2. Ignore ENOENT/ESTALE errors of inodelk on dst.
3. protect namespace of src and dst. To protect namespace of a file,
take inodelk on parent on hashed subvol, then take entrylk on the
same subvol on parent with basename of file. inodelk on parent is
done to guard against changes to parent layout so that hashed
subvol won't change during rename.
4. <rest of rename continues>
5. unlock all locks
Issue 2:
========
linkfile creation in lookup codepath can race with a rename. Imagine
the following scenario:
* lookup finds a data-file with gfid - gfid-dst - without a
corresponding linkto file on hashed-subvol. It decides to create
linkto file with gfid - gfid-dst.
- Note that some codepaths of dht-rename deletes linkto file of
dst as first step. So, a lookup racing with an in-progress
rename can easily run into this situation.
* a rename (src-path:gfid-src, dst-path:gfid-dst) renames data-file
and hence gfid of data-file changes to gfid-src with path dst-path.
* lookup proceeds and creates linkto file - dst-path - with gfid -
dst-gfid - on hashed-subvol.
* rename tries to create a linkto file dst-path with src-gfid on
hashed-subvol, but it fails with EEXIST. But EEXIST is ignored
during linkto file creation.
Now we've ended with dst-path having different gfids - dst-gfid on
linkto file and src-gfid on data file. Future lookups on dst-path will
always fail with ESTALE, due to differing gfids.
The fix is to synchronize linkfile creation in lookup path with rename
using the same mechanism of protecting namespace explained in solution
of Issue 1. Once locks are acquired, before proceeding with linkfile
creation, we check whether conditions for linkto file creation are
still valid. If not, we skip linkto file creation.
Issue 3:
========
gfid of dst-path can change by the time locks are acquired. This
means, either another rename overwrote dst-path or dst-path was
deleted and recreated by a different client. When this happens,
cached-subvol for dst can change. If rename proceeds with old-gfid and
old-cached subvol, we'll end up in inconsistent state(s) like dst-path
with different gfids on different subvols, more than one data-file
being present etc.
Fix is to do the lookup with a new inode after protecting namespace of
dst. Post lookup, we've to compare gfids and correct local state
appropriately to be in sync with backend.
Issue 4:
========
During revalidate lookup, if following a linkto file doesn't lead to a
valid data-file, local->cached-subvol was not reset to NULL. This
means we would be operating on a stale state which can lead to
inconsistency. As a fix, reset it to NULL before proceeding with
lookup everywhere.
Issue 5:
========
Stale dentries left out in inode table on brick resulted in failures
of link fop even though the file/dentry didn't exist on backend fs. A
patch is submitted to fix this issue. Please check the dependency tree
of current patch on gerrit for details
In short, we fix the problem by not blindly trusting the
inode-table. Instead we validate whether dentry is present by doing
lookup on backend fs.
Change-Id: I832e5c47d232f90c4edb1fafc512bf19bebde165
updates: bz#1543279
BUG: 1543279
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 017a33490e270b07735fe9b63112e1e0c5323dcf
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Mar 16 12:16:43 2018 +0530
cluster/dht: log error only if layout healing is required
selfhealing of directory is invoked on two conditions:
1. no layout on disk or layout has some anomalies (holes/overlaps)
2. mds xattr is not set on the directory
When dht_selfheal_directory is called with a correct layout just to
set mds xattr, we see error msgs complaining about "not able to form
layout on directory", which is misleading as the layout is
correct. So, log this msg only if layout has anomalies.
Change-Id: I4af25246fc3a2450c2426e9902d1a5b372eab125
updates: bz#1543279
BUG: 1543279
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit bee3b7b9ab8ae4bc6f58a467e2ce0a2078343f25
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Mar 21 13:09:01 2018 +0530
extras/hooks: Do not blindly remove volume share from smb.conf
When Gluster volumes are shared via Samba, any extra smb.conf parameter
setting done by administrator to those shares are lost during restart
of the volume. Instead of removing the whole share completely from
smb.conf(via hook scripts during volume stop) it is better to make it
temporarily unavailable to end-users till the volume is started again.
Therefore we make use of a smb.conf parameter named 'available'[1] to
achieve the above intend.
[1] https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html
Change-Id: I68a9055b50791f6ffd3b95a3c13d858a75fa6530
fixes: bz#1558921
BUG: 1558921
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 531320688f974fd95c55fcc2108fd7913a3f2c35
Author: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
Date: Sat May 5 20:23:32 2018 +0200
gfapi: acutally avoid recall callback when closed
Due to missing curly braces we end up calling the callback
function even when state is GLFD_CLOSE. This patch adds the
curly braces so both the log and actual callback is skipped.
Introduced in 19568 in commit b04066721bf4a240f61b83bd87bbb27437c5fe4f
Change-Id: I0b15cfe222841cfcb12f17723284acb3838d64d7
fixes: bz#1575294
Signed-off-by: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
commit 26527c7de473e99f09cf4f8d9df425b0d8fa2f7a
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Apr 30 19:34:34 2018 +0530
glusterd: Fix for memory leak in volume tier status command
Fixes: bz#1573220
Change-Id: Ia60f40fa4f1e525cae6f571a24e5385ba1e004c0
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit f85b1be6849a17539e746e797733aa5761bb8594
Author: Kotresh HR <khiremat@redhat.com>
Date: Sat May 5 00:05:09 2018 -0400
glusterd/ctime: Provide option to enable/disable ctime feature
Updates: #208
Change-Id: If6f52b9b1b5b823ad64faeed662e96ceb848c54c
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit d230dbef07c008342a84c62c41cd1b7c9ff6642b
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Apr 23 04:44:40 2018 -0400
glusterd/utime: glusterd utime changes
Load utime xlator in the client side just after (below)
performance xlators.
Updates: #208
Change-Id: Ie15f156943fa8e7dac7050e5479c906da747b568
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 22d47ae8baf7f7b35bf5da9a23e67f132b061183
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Apr 30 04:43:58 2018 -0400
utime: ctime client side xlator
The client side utime xlator does two things.
1. Update unix epoch time in frame->root->ctime
2. Update the frame->root->flags based on the fop
which indicates time attributes that should be
updated for the parent/entry.
Credits: Rafi KC <rkavunga@redhat.com>
Updates: #208
Change-Id: I9cad297040c70798a0a8468a080eb4aeff73138d
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit c0e24e288bb874101c65d8d735f2c581d6e288f2
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Apr 2 08:31:25 2018 -0400
posix/ctime: posix hook to set ctime xattr in relevant fops
This patch uses the ctime posix APIs to set consistent
time across replica on disk. It also stores the time
attributes in the inode context.
Credits: Rafi KC <rkavunga@redhat.com>
Updates: #208
Change-Id: I1a8d74d1e251f1d6d142f066fc99258025c0bcdd
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit b7c3d5078c8458a2245a0f015565a554b2b65e1a
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Apr 23 04:22:09 2018 -0400
posix/ctime: posix hooks to get consistent time xattr
This patch uses the ctime posix APIs to get consistent
time across replica. The time attributes are got from
from inode context or from on disk if not found and
merged with iatt to be returned.
Credits: Rafi KC <rkavunga@redhat.com>
Updates: #208
Change-Id: Id737038ce52468f1f5ebc8a42cbf9c6ffbd63850
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit cee5c4dae6aec5d1a39804d9fb0ad1bd2867c720
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Nov 3 09:57:08 2017 -0400
posix: APIs in posix to get and set time attributes
This is part of the effort to provide consistent time
across distribute and replica set for time attributes
(ctime, atime, mtime) of the object. This patch contains
the APIs to set and get the attributes from on disk
and in inode context.
Credits: Rafi KC <rkavunga@redhat.com>
Updates: #208
Change-Id: I5d3cba53eef90ac252cb8299c0da42ebab3bde9f
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 1f0f15cd51ad8812fd4b2eb958b362d2c3a20b49
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Apr 27 15:36:04 2018 +0530
tests: Add lease test case
Updates: #350
Change-Id: Iee78ab4baf48c481de1e13ff2b0393bc106b7d0e
Signed-off-by: Poornima G <pgurusid@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit e2b01b00985fd374a3d930f1a19bbf8288a86671
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Jul 20 16:12:31 2015 +0530
afr: Add lease() fop
Change-Id: Ied047dd5ee44e9d5a5d3db214826f7df30332ef9
updates: #350
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit 8be11e826bb85558ed67f1653fdb969b5516db58
Author: Csaba Henk <csaba@redhat.com>
Date: Thu May 3 13:35:04 2018 +0200
mount,fuse: make fuse dumping available as mount option
Updates: bz#1193929
Change-Id: I4dd4d0e607f89650ebb74b893b911b554472826d
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit a28b7ea9c07c2913ad3348a600dff32d9824940b
Author: Csaba Henk <csaba@redhat.com>
Date: Thu May 3 10:22:18 2018 +0200
fuse: add support for kernel writeback cache
- Added kernel-writeback-cache command line and xlator
option for requesting utilisation of the writeback
cache of the kernel in FUSE_INIT (see [1]).
- Added attr-times-granularity command line and xlator
option via which granularity of the {a,m,c}time in
stat (attr) data that we support can be indicated to
kernel. This is a means to avoid divergence of the
attr times between kernel and userspace that could
occur with writeback-cache, while still maintaining
maximum time precision the FUSE server is capable of
(see [2]).
- Handling FATTR_CTIME flag in FUSE_SETATTR that
indicates presence of ctime in setattr payload.
Currently we cannot associate arbitrary ctimes to
files on backend, so we just touch them to update
their ctimes to current time. Having ctimes in setattr
payload is also a side effect of writeback cache
(see [3] and [4]).
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4d99ff8,
"fuse: Turn writeback cache on"
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e27c9d3,
"fuse: fuse: add time_gran to INIT_OUT"
[3]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1e18bda,
"fuse: add .write_inode"
[4]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ab9e13f,
"fuse: allow ctime flushing to userspace"
Updates: #435
Change-Id: Id174c8e0c815c4456c35f8c53e41a6a507d91855
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 01c14e815b2cb2426af5e1c8616d342f1b01cdda
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Fri Apr 27 15:22:50 2018 +0530
feature/leases : fixing bugs found while testing glfs_test.t
Change-Id: Iee8f431601ecda184108a079f665e05902b0f78b
updates: #350
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit 9059e461dd64540521229bbf00cfbb14ad8d3a56
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Apr 27 15:12:08 2018 +0530
gfapi : RECALL_LEASE implementation
Right now there are two types of upcalls
* poll method
* registering callback
But callback can be registered per fs and same callback fn shall be used
for any lease recall with object handle as argument as done for cache
invalidation.
TODO: RECALL LEASE for each glfd (for future reference)
(may be needed fo Samba as they do not deal with
object handles.
In case of RECALL_LEASE, we could associate separate
cbk function for each glfd either by
- extending pub_glfs_lease to accept new args (recall_cbk_fn, cookie)
- or by defining new API "glfs_register_recall_cbk_fn (glfd, recall_cbk_fn, cookie)
. In such cases, flag it and instead of calling below upcall functions, define
a new one to go through the glfd list and invoke each of theirs recall_cbk_fn.
Plus added following as well
* passed lease id to dict in required arguments
* added flag check in pub_glfs_open
Updates: #350
Change-Id: I07a971f0f26ec6aae0b9f9a5613504317dee153b
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit eb684a252ef11ed786a6ee53f0fb85daaefa1f3e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Apr 20 14:54:33 2018 -0400
features/bitrot: print the path of the corrupted objects
Currently "gluster volume bitrot <volume name> scrub status"
gives the list of the corrupted objects (files as of now).
But only the gfids of those corrupted objects are seen and
one has to do getfattr, find etc operations to get the actual
path of those objects for removal etc.
This change makes an attempt to print the path of those files
as much as possible.
* Try to get the path using the on disk gfid2path xattr.
* If the above operation fails, then go for in memory path
(provided that the object has its dentry
properly created and linked in the inode table of the brick where
the corrupted object is present) So the gfid to path resolution is
a soft resolution, i.e. based on the inode and dentry cache in the
brick's memory. If the path cannot be obtained via inode table also,
then only gfid is printed.
Change-Id: Ie9a30307f43a49a2a9225821803c7d40d231de68
fixes: bz#1570962
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit a5fee6eedc32ca7ffbb52fa4386360690fe02765
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu May 3 12:15:52 2018 -0400
use awk to get a specific line from the output instead of cut
cut -d$'\n' is not separating the xattrs shown as part of getfattr output.
Hence use awk to get the nth line of getfattr output for nth iteration
in the for loop.
Change-Id: I1a96cd3f72f4f407f9a783375f78d9a69d5d3885
fixes: bz#1574606
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 06067fbabb2c7719f41e3bd1f904248624424d68
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jan 18 19:02:07 2018 +0530
glusterd: enable self-heal in daemons
..like rebalance, quota and tier because that seems to be the consensus
(see BZ).
Change-Id: I912336a12f4e33ea4ec55f804df403fab0dc89fc
BUG: 1536024
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit e5245be779b6588cf7e78551172337453cdc9c95
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Apr 23 16:03:42 2018 +0530
glusterfsd: initiate pmap_signout for all detach brick requests
In glusterfs_handle_terminate all bricks getting detached need to
initiate a pmap_signout.
Change-Id: Iacbd6fcd49215fe6a5210df7dfed1260fde9179a
Fixes: bz#1570011
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 5e9e8ba7406074a9c7b288302e194e8b8dc225c6
Author: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
Date: Thu May 3 00:58:02 2018 +0200
cli/snapshot: ignore errors for snapshot status for ALL/VOL
Currently errors are reported for snapshot status of type ALL and VOL.
The intention was to ignore those, but the code gets it wrong.
The original condition for ignoring ALL/VOL was removed in
Bug 1096610
Change-Id Ifc0ac31d2a9f91e136e87f3b51a629df7dba94e8
And the current logic introduced in
Bug 789278
Change-Id I985cea1ef787d239b2632d5a7f467070846f92e4
Change-Id: Ic02ea98fb23b1149264e91b41f2fc2ca916d405f
Fixes: bz#1574259
Signed-off-by: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
commit 47ce812a322989a68ee6d56c4b3ebea67533dcbc
Author: Susant Palai <spalai@redhat.com>
Date: Mon Feb 26 11:33:06 2018 +0530
cli/glusterd: Add warning message in cli for user to check
force-migration config for remove-brick operation.
The cli will take input from the user before starting "remove-brick"
start operation. The message/confirmation looks like the following:
<Running remove-brick with cluster.force-migration enabled can result
in data corruption. It is safer to disable this option so that files
that receive writes during migration are not migrated. Files that are
not migrated can then be manually copied after the remove-brick commit
operation. Do you want to continue with your current
cluster.force-migration settings? (y/n)>
And also question for COMMIT_FORCE is changed.
Fixes: bz#1572586
Change-Id: Ifdb6b108a646f50339dd196d6e65962864635139
Signed-off-by: Susant Palai <spalai@redhat.com>
commit b85048d1ad2de109a47941da877b6c17fbb29995
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue Apr 24 09:43:09 2018 +0530
posix: Avoid changelog retries for geo-rep
Problem: georep is slowdown to migrate directory
from master volume to slave volume due to lot
of changelog retries
Solution: Update the condition in posix_getxattr to
ignore MDS_INTERNAL_XATTR as it(posix) ignored
other internal xattrs
BUG: 1571069
Change-Id: I4d91ec73e5b1ca1cb3ecf0825ab9f49e261da70e
fixes: bz#1571069
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit cc99140d57796bf0e96ac4d4ca970a26fdb705f3
Author: Ji-Hyeon Gim <potatogim@gluesys.com>
Date: Thu Feb 1 15:14:42 2018 +0900
doc: updates Language Bindings for libgfapi-perl and gogfapi
The libgfapi-perl provides declarations and linkage for the Gluster
gfapi C library with FFI for many Perl mongers
In addition, gogfapi URI link is replaced with GitHub because Forge is
dead.
Change-Id: I773e78beb201b48ca3fde0dc72d04b64dc9697d6
Signed-off-by: Ji-Hyeon Gim <potatogim@potatogim.net>
Updates: #447
commit 7526100f2a6a027a806937c7b2a7223e4131e3f7
Author: Niklas Hambüchen <mail@nh2.me>
Date: Sat May 13 02:45:49 2017 +0200
Don't use hardcoded /sbin, /usr/bin etc. paths. Fixes #1450546
Instead, rely on programs to be in PATH, as gluster already
does in many places across its code base.
Change-Id: Id21152fe42f5b67205d8f1571b0656c4d5f74246
BUG: 1450546
Signed-off-by: Niklas Hambuechen <mail@nh2.me>
commit aa4fd5a27a4801a2a474cc1ff73d2d863448b5d7
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu May 3 09:34:39 2018 +0530
cluster/dht: unwind if dht_selfheal_dir_mkdir returns an error
If dht_selfheal_dir_mkdir returns an error, cbk passed to
dht_selfheal_directory is not invoked. So, Current codepath leaves an
unwound frame resulting in a hung fop forever.
Change-Id: I422308b8a34a074301ca46b029ffe676f5e0f66c
fixes: bz#1574305
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit af6d40d95876c3f59bb7df9f3d672b3a1b749ab2
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Apr 25 16:48:56 2018 +0530
protocol/server : unwind as per op version
Change-Id: Id6717640ac14881b490e512c4682e45ffffa7f5b
fixes: bz#1570538
BUG: 1570538
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 1484d154881a5378045638d634e7046d62274ca7
Author: Varsha Rao <varao@redhat.com>
Date: Fri Apr 13 16:16:43 2018 +0530
glusterd/geo-rep: Fix UNUSED_VALUE coverity issue
The return value of glusterd_get_local_brickpaths is unused so add
goto statement. As it is reinitialized outside the if block. Also
change the if condition to check the failure case, when return value
is -1 and path_list is NULL.
Change-Id: I6b47d7751263f704bd69a6452a7e71bfcf226d49
updates: bz#789278
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 6761b0d04bc5e0d17d2f78f30873810bf17531de
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Apr 13 09:13:16 2018 -0400
core/various: python3 compat, prepare for python2 -> python3
see https://review.gluster.org/#/c/19788/
use print fn from __future__
Change-Id: If5075d8d9ca9641058fbc71df8a52aa35804cda4
updates: #411
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit a089591b77d70ccb241eed11331d81edf16a5208
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Fri Apr 20 17:26:12 2018 +0530
block-profile: enable cluster.eager-lock in block-profile
Eager-lock gave 2.5X perf improvement. On top of that with batching
fix in tcmu-runner and client-io-threads we are seeing close to 3X perf
improvement. But we don't want to include that in the default profile
option but enable it on a case by case basis. So not adding
client-io-threads option.
BUG: 1573119
Fixes: bz#1573119
Change-Id: Ida53c3ef9a041a73b65fdd06158ac082da437206
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
commit c87b63aebf4dbfdc42562c2bb40316da303528e6
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Apr 30 11:12:34 2018 +0530
glusterd: Fix for memory leak in get-state detail
Fixes: bz#1573066
Change-Id: I76fe3bdde7351736b32eb3d6c4cc5f8f276257ed
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 8914b491b38a4377110c580e1ae73cc94222956d
Author: Susant Palai <spalai@redhat.com>
Date: Fri Apr 27 16:40:02 2018 +0530
dht: gf_defrag_settle_hash should ignore ENOENT and ESTALE error
Problem: A directory deletion can happen just before gf_defrag_settle_hash
which internally does a setxattr operation on a directory.
Solution: Ignore ENOENT and ESTALE errors
Fixes: bz#1572581
Change-Id: I2f91809f3b5e02976c4c3a5a596406a8b2f8f6f2
Signed-off-by: Susant Palai <spalai@redhat.com>
commit ed17c74eb55b1fcd2e3576f7598c6069c556d9f4
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Apr 26 00:58:12 2018 +0530
cluster/afr: shd changes for thin arbiter
Updates #352
Change-Id: I1bbb3c652ba33cec6aa37f3700370674077fb17d
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit ffb4355e7b4b6b1020c0e5f1102100dd4bc6230e
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Apr 2 13:58:23 2018 +0530
afr: initial changes for thin arbiter
1. Create thin arbiter index file during mount.
2. Set pending marker in thin arbiter id file in case of failure.
Change-Id: I269eb8d069f0323f1fc616175e5e5eb7b91d5f82
updates: #352
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 430ec3a6f4dfd88a38f247b150f338309f0f2c01
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sat Mar 17 13:16:59 2018 +0530
server/resolver: don't trust inode-table for RESOLVE_NOT
There have been known races between fops which add a dentry (like
lookup, create, mknod etc) and fops that remove a dentry (like rename,
unlink, rmdir etc) due to which stale dentries are left out in inode
table even though the dentry doesn't exist on backend. For eg.,
consider a lookup (parent/bname) and unlink (parent/bname) racing in
the following order:
* lookup hits storage/posix and finds that dentry exists
* unlink removes the dentry on storage/posix
* unlink reaches protocol/server where the dentry (parent/bname) is
unlinked from the inode
* lookup reaches protocol/server and creates a dentry (parent/bname)
on the inode
Now we've a stale dentry (parent/bname) associated with the inode in
itable. This situation is bad for fops like link, create etc which
invoke resolver with type RESOLVE_NOT. These fops fail with EEXIST
even though there is no such dentry on backend fs. This issue can be
solved in two ways:
* Enable "dentry fop serializer" xlator [1].
# gluster volume set features.sdfs on
* Make sure resolver does a lookup on backend when it finds a dentry
in itable and validates the state of itable.
- If a dentry is not found, unlink those stale dentries from itable
and continue with fop
- If dentry is found, fail the fop with EEXIST
This patch implements second solution as sdfs is not enabled by
default in brick xlator stack. Once sdfs is enabled by default, this
patch can be reverted.
[1] https://github.com/gluster/glusterfs/issues/397
Change-Id: Ia8bb0cf97f97cb0e72639bce8aadb0f6d3f4a34a
updates: bz#1543279
BUG: 1543279
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 699ca7cdce3a2a3c243096fabdcdec4954fad6b7
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Apr 26 12:38:23 2018 +0530
libglusterfs: Capture the dict response in syncop_xattrop_cbk
Problem:
Currently it is not possible to capture the xattrs values which
are set on the bricks by calling syncop_(f)xattrop, because the
response dict is not being assigned to any of the dictionaries.
Fix:
In the xattrop callback capture the response dict and send it
back to the caller if it is requested.
Change-Id: I9de9bcd97d6008091c9b060bcca3676cb9ae8ef9
fixes: bz#1572076
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 6c553197e1d77d9f3fb0b9e9a7ebde6adc08f414
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Feb 1 12:18:38 2018 +0530
feature/thin-arbiter: Implement thin-arbiter translator
Updates #352
Change-Id: I3d8caa6479dc8e48bec62a09b056971bb061f0cf
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit c7c47006e0c5688aa97045c89a0727c232f25205
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Apr 23 19:21:20 2018 +0530
performance/md-cache: purge cache on ENOENT/ESTALE errors
If not, next lookup could be served from cache and can be success,
which is wrong. This can affect retry logic of VFS when it receives an
ESTALE.
Change-Id: Iad8e564d666aa4172823343f19a60c11e4416ef6
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Fixes: bz#1566303
commit 1a960e1904ca538368d482c9dcd16efc805cff2d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Apr 13 08:52:06 2018 +0530
cluster/afr: Keep child-up until ping-event
Problem:
If we have 2 bricks, brick-A and brick-B with brick-A within halo-max-latency
and brick-B more than halo-max-latency. If we set both halo-min, halo-max replicas
as '1'. In this case, brick-A comes online and then ping-latency will be updated for it.
When brick-B comes online, we have 2 up-bricks, so the code tries to find the brick with
worst latency to mark it down. Since Brick-B just came online it always had '0' latency
so brick-B used to be marked offline and Brick-B would eventually be the one to be
online even when brick-A is more suited.
Fix:
Consider latency of just-up child as HALO_MAX_LATENCY so that worst-child until
ping-latency is found as the just-up brick. Also keep ping-latency as -1 until
child-up during initialization.
BUG: 1567881
fixes bz#1567881
Change-Id: I148262fe505468190f0eb99225d0f6d57cdb6f04
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit cb02f187f5586e2b97ab50264abbdcb661574dfe
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Apr 23 21:04:58 2018 +0530
libglusterfs/syncop: Handle barrier_{init/destroy} in error cases
BUG: 1568521
updates: bz#1568521
Change-Id: I53e60cfcaa7f8edfa5eca47307fa99f10ee64505
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit d640075df7fb35bbba5ecd79197d7bec78f55acd
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Apr 17 22:14:20 2018 +0530
features/shard: Add option to barrier parallel lookup and unlink of shards
Also move the common parallel unlink callback for GF_FOP_TRUNCATE and
GF_FOP_FTRUNCATE into a separate function.
Change-Id: Ib0f90a5f62abdfa89cda7bef9f3ff99f349ec332
updates: bz#1568521
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 69bee475e2dd7d0848dce0cc0b6bd7fa324203b7
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Apr 17 15:37:05 2018 +0530
cluster/dht: Fix dht_rename lock order
Fixed dht_order_rename_lock to use the same inodelk ordering
as that of the dht selfheal locks (dictionary order of
lock subvolumes).
Change-Id: Ia3f8353b33ea2fd3bc1ba7e8e777dda6c1d33e0d
fixes: bz#1568348
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 2421c53ec922a174205e858b3b0e6afb85833773
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Apr 2 12:20:47 2018 +0530
server/auth: add option for strict authentication
When this option is enabled, we will check for a matching
username and password, if not found then the connection will
be rejected. This also does a checksum validation of volfile
The option is invalid when SSL/TLS is in use, at which point
the SSL/TLS certificate user name is used to validate and
hence authorize the right user. This expects TLS allow rules
to be setup correctly rather than the default *.
This option is not settable, as a result this cannot be enabled
for volumes using the CLI. This is used with the shared storage
volume, to restrict access to the same in non-SSL/TLS environments
to the gluster peers only.
Tested:
./tests/bugs/protocol/bug-1321578.t
./tests/features/ssl-authz.t
- Ran tests on volumes with and without strict auth
checking (as brick vol file needed to be edited to test,
or rather to enable the option)
- Ran tests on volumes to ensure existing mounts are
disconnected when we enable strict checking
Change-Id: I2ac4f0cfa5b59cc789cc5a265358389b04556b59
fixes: bz#1568844
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 8441a8f10f56156c645e5a39bfec8bb2c16c6bb4
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Mar 26 20:27:34 2018 +0530
shared storage: Prevent mounting shared storage from non-trusted client
gluster shared storage is a volume used for internal storage for
various features including ganesha, geo-rep, snapshot.
So this volume should not be exposed to the client, as it is
a special volume for internal use.
This fix wont't generate non trusted volfile for shared storage volume.
Change-Id: I8ffe30ae99ec05196d75466210b84db311611a4c
fixes: bz#1568844
BUG: 1568844
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 988778571a1f54839905d04c26d6c1aac7b92de7
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri Apr 20 12:16:32 2018 +0530
server: fix unresolved symbols by moving them to libglusterfs
Problem: glusterd2 build is failed due to undefined symbol
(xlator_mem_cleanup , glusterfsd_ctx) in server.so
Solution: To resolve the same done below two changes
1) Move xlator_mem_cleanup code from glusterfsd-mgmt.c
to xlator.c to be part of libglusterfs.so
2) replace glusterfsd_ctx to this->ctx because symbol
glusterfsd_ctx is not part of server.so
BUG: 1544090
Change-Id: Ie5e6fba9ed458931d08eb0948d450aa962424ae5
fixes: bz#1544090
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 113cd137da1c5469bbce60b58a908fbc4938788c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Apr 19 17:13:17 2018 +0530
cluster/afr: Need heal-timeout to be configured as low as 5 seconds
In Halo replication, there are pending heals more often than not.
It makes sense to give users the capability to configure it as low
as 5 seconds.
BUG: 1569489
fixes bz#1569489
Change-Id: I451c1975827f66398b903f659c981ef3121d5376
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 651af4181f20d2d64c6d375fc66bc25b5aa05b1e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Apr 18 15:18:43 2018 -0400
features/bitrot: show the corresponding brick for the corrupted objects
Currently with "gluster volume bitrot <volume name> scrub status" command
the corrupted objects of a node are shown. But to what brick that corrupted
object belongs to is not shown. Showing the brick of the corrupted object
will help in situations where a node hosts multiple bricks of a volume.
Change-Id: I7fbdea1e0072b9d3487eb10757468bc02d24df21
fixes: bz#1569198
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
commit d4cfa4507107613d59c2f865c9b47d6e733a23c3
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Apr 18 15:08:55 2018 +0530
eventsapi: Handle Unicode string during signing
Python 2.7 HMAC does not support Unicode strings. Secret is read
from file so it is possible that glustereventsd reads the content
as Unicode. This patch converts the secret to `str` type before
generating HMAC signature.
Fixes: bz#1568820
Change-Id: I7daa64499ac4ca02544405af26ac8af4b6b0bd95
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 810754ea1f2b029787fe67a5759cbb9d31838c09
Author: Prashanth Pai <ppai@redhat.com>
Date: Thu Apr 19 12:50:20 2018 +0530
Make glusterfsd binary print statedump & xlator dir
The glusterd2 needs following options, some of which are provided by
gluster CLI today:
--print-xlatordir
--print-statedumpdir
--print-logdir
However, the CLI package need not be present on the machine running
glusterd2. This change adds the above CLI options to glusterfsd binary
which glusterd2 depends on.
Reverts 9a1ae47c8d60836ae0628a04a153f28c1085c0e8
Related changes:
https://review.gluster.org/#/c/19882/
https://github.com/gluster/glusterd2/pull/663
Updates: bz#1193929
Change-Id: I18c123b0d3350d2bd4f2400783e3b94e402a4e29
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit a241edcb416af88971dc1eba727d89883a237445
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Mar 12 19:43:15 2018 +0530
gluster: Sometimes Brick process is crashed at the time of stopping brick
Problem: Sometimes brick process is getting crashed at the time
of stop brick while brick mux is enabled.
Solution: Brick process was getting crashed because of rpc connection
was not cleaning properly while brick mux is enabled.In this patch
after sending GF_EVENT_CLEANUP notification to xlator(server)
waits for all rpc client connection destroy for specific xlator.Once rpc
connections are destroyed in server_rpc_notify for all associated client
for that brick then call xlator_mem_cleanup for for brick xlator as well as
all child xlators.To avoid races at the time of cleanup introduce
two new flags at each xlator cleanup_starting, call_cleanup.
BUG: 1544090
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Note: Run all test-cases in separate build (https://review.gluster.org/#/c/19700/)
with same patch after enable brick mux forcefully, all test cases are
passed.
Change-Id: Ic4ab9c128df282d146cf1135640281fcb31997bf
updates: bz#1544090
commit daba7ccaeb447f04af506cf5d0bbfd27be2b81b3
Author: hari gowtham <hgowtham@redhat.com>
Date: Wed Apr 11 17:38:26 2018 +0530
glusterd: volume inode/fd status broken with brick mux
Problem:
The values for inode/fd was populated from the ctx received
from the server xlator.
Without brickmux, every brick from a volume belonged to a
single brick from the volume.
So searching the server and populating it worked.
With brickmux, a number of bricks can be confined to a single
process. These bricks can be from different volumes too (if
we use the max-bricks-per-process option).
If they are from different volumes, using the server xlator
to populate causes problem.
Fix:
Use the brick to validate and populate the inode/fd status.
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Change-Id: I2543fa5397ea095f8338b518460037bba3dfdbfd
fixes: bz#1566067
commit 31266b2703b588144dbfc002fafd39bf3de006b9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Mar 28 12:09:27 2018 +0530
features/shard: Make operations on internal directories generic
Change-Id: Iea7ad2102220c6d415909f8caef84167ce2d6818
updates: bz#1568521
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 6b1a87e46860990859fe0252866c162de2099256
Author: Susant Palai <spalai@redhat.com>
Date: Wed Apr 11 23:14:02 2018 +0530
fuse: do fd_resolve in fuse_getattr if fd is received
problem: With the current code, post graph switch the old fd is received for
fuse_getattr and since it is associated with old inode, it does not
have the inode ctx across xlators in new graph. Hence, dht
errored out saying "no layout" for fstat call. Hence the EINVAL.
Solution: if fd is passed, init and resolve fd to carry on getattr
test case:
- Created a single brick distributed volume
- Started untar
- Added a new-brick
Without this fix, untar used to abort with ERROR.
Change-Id: I5805c463fb9a04ba5c24829b768127097ff8b9f9
fixes: bz#1566207
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 6e742065768a03efc1da6e4fe37fae1ea7f1efae
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Apr 16 11:26:40 2018 +0530
glusterd: update listen-backlog value to 1024
Update default value of listen-backlog to 1024 to reflect the changes in
socket.c
This keeps the actual implementation in socket.c and the help text in
glusterd-volume-set.c consistent
Change-Id: If04c9e0bb5afb55edcc7ca57bbc10922b85b7075
fixes: bz#1564600
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 4d99dd2f92917d0522f891dcf087c9c6853f6496
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Apr 13 00:16:22 2018 +0530
cluster/afr: Make sure latency-arg is passed to afr
xlator_notify doesn't pass the extra arguments that come in the
input function, so XLATOR_NOTIFY macro should be used instead
to pass the extra arguments to the function.
BUG: 1567881
fixes bz#1567881
Change-Id: Ic15b6c446638cbacf3149693147a754219037c47
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 809c752005790e3ace0e984a19df7966e9dd2ced
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Thu Apr 12 23:31:37 2018 +0200
libglusterfs: fix comparison of a NULL dict with a non-NULL dict
Function are_dicts_equal() had a bug when the first argument was NULL and
the second one wasn't NULL. In this case it incorrectly returned that the
dicts were different when they could be equal.
Fixes: bz#1566732
Change-Id: I0fc245c2e7d1395865a76405dbd05e5d34db3273
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit d6d8c4dba19bc90d13f1eddcca6453213e6db9b0
Author: Prashanth Pai <ppai@redhat.com>
Date: Mon Apr 16 11:55:02 2018 +0530
Add CLI option to print XLATORDIR
glusterfs gets the path to xlator dir from a compile time flag named
XLATORDIR which gets passed through a -D flag to GCC. This path is
used to find and load xlator shared objects.
The XLATORDIR path isn't easily accessible to glusterd2. Glusterd2
currently uses the following command (hack) to get value of XLATORDIR:
$ strings -d `which glusterfsd` | awk '/glusterfs/*/xlator$/'
This change introduces "print-xlatordir" CLI option to expose
XLATORDIR. The option is intentionally not documented.
Updates: bz#1193929
Change-Id: Ic7247457600f11cd8d68eb3d0ad2526fdfda0b02
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit 337b5aef61c31ae9b74bef860456817a0b205dd8
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Apr 16 15:38:34 2018 +0530
afr: fixes to afr-eager locking
1. If pre-op fails on all bricks,set lock->release to true in
afr_handle_lock_acquire_failure so that the GF_ASSERT in afr_unlock() does not
crash.
2. Added a missing 'return' after handling pre-op failure in
afr_transaction_perform_fop(), fixing a use-after-free issue.
Change-Id: If0627a9124cb5d6405037cab3f17f8325eed2d83
fixes: bz#1561129
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 83418cd8ee20ff3f58317e59811372950040db04
Author: Nigel Babu <nigelb@redhat.com>
Date: Wed Apr 18 10:37:46 2018 +0530
Revert "storage/posix: add pgfid in readdirp if needed"
This reverts commit d206fab73f6815c927a84171ee9361c9b31557b1.
Change-Id: I5b43fdcf916bc844437c9d60f6957bc40936e3c2
Updates: bz#1560319
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit c8ea1f019ad31e65423e5397d851a60867a19a59
Author: Xie Changlong <xiechanglong@cmss.chinamobile.com>
Date: Tue Apr 10 10:26:01 2018 +0800
build: exclude '--with-previous-options' to prevent infinite loop
Reproducible Steps:
1. cd glusterfs/; rm -rf *; git reset --hard #clean repo
2. cd extras/LinuxRPM/; ./make_glusterrpms #it's ok here
3. ./make_glusterrpms #infinite loop
4. cd ../../; make distclean #infinite loop
Change-Id: I162953d4576cedea7c6f6c631a77163a5cca023e
updates: #439
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
commit 4af93b536849d36a73cc949afc0c364f9367e13c
Author: Nigel Babu <nigelb@redhat.com>
Date: Mon Apr 16 09:20:42 2018 +0530
maintainers: promote Deepshikha to maintainer
Deepshikha has been doing excellent work across the CI system. She is
now ready to co-maintain the Continuous Integration module and be
responsible for the CI ecosystem in its entirety.
Fixes: bz#1567880
Change-Id: If204301d26731f93b2dccfe8b6571ee748a47b26
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit f75d74a3c105eb5931ce4937fc7e48a3377ce71c
Author: Csaba Henk <csaba@redhat.com>
Date: Sat Apr 14 08:22:48 2018 +0200
fuse: retire statvfs tweak
fuse xlator used to override the filesystem
block size of the storage backend to indicate
its preferences. Now we retire this tweak and
pass on what we get from the backend.
This fixes the anomaly reported in the referred
BUG. For more background, see the following email,
which was sent out to gluster-devel and gluster-users
mailing lists to gauge if anyone sees any use of
this tweak:
http://lists.gluster.org/pipermail/gluster-devel/2018-March/054660.html
http://lists.gluster.org/pipermail/gluster-users/2018-March/033775.html
Noone vetoed the removal of it but it got endorsement:
http://lists.gluster.org/pipermail/gluster-devel/2018-March/054686.html
BUG: 1523219
Change-Id: I3b7111d3037a1b91a288c1589f407b2c48d81bfa
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 3356de27398afe886506985bf9b4ad785a1e3f76
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Apr 13 10:52:14 2018 -0400
geo-rep: Fix syncing of symlink
Problem:
If symlink is created on master pointing
to current directory (e.g symlink -> ".") with
non root uid or gid, geo-rep worker crashes
with ENOTSUP.
Cause:
Geo-rep creates the symlink on slave and
fixes the uid and gid using chown cmd.
os.chown dereferences the symlink which is
pointing to ".gfid" which is not supported.
Note that geo-rep operates on aux-gfid-mount
(e.g. "/mnt/.gfid/<gfid-of-symlink-file>").
Solution:
The uid or gid change is acutally on symlink
file. So use os.lchown, i.e, don't deference.
BUG: 1567209
Change-Id: I63575fc589d71f987bef1d350c030987738c78ad
updates: bz#1567209
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit d01ae9b18a696a159270fda47602e8e68a236d41
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Apr 12 13:41:29 2018 +0530
extras: Disable choose-local in groups virt and gluster-block
Change-Id: Icba68406d86623195d59d6ee668e0850c037c63a
fixes: bz#1566386
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit c3e3ab49539f2f8722cbab3624fa7237413c45bb
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Apr 9 11:26:05 2018 +0530
rpc: set listen-backlog to high value
Problem:
On node reboot, when glusterd starts volumes rapidly, there's a flood of
connections from the bricks to glusterd and from the self-heal daemons
to the bricks. This causes SYN Flooding and dropped connections when the
listen-backlog is not enough to hold the pending connections to
compensate for the rate at which connections are accepted by the RPC
layer.
Solution:
Increase the listen-backlog value to 1024. This is a partial solution.
Part of the solution is to rearm the listener socket early for quicker
accept() of connections.
See commit 6964640a977cb10c0c95a94e03c229918fa6eca8 (change 19833)
Change-Id: I62283d1f4990dd43839f9a6932cf8a36effd632c
fixes: bz#1564600
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 723e2d5228ecc68c15aa9e4c83526eec4fdc2401
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Apr 6 16:06:51 2018 +0530
cluster/dht: Handle file migrations when brick down
The decision as to which node would migrate a file
was based on the gfid of the file. Files were divided
among the nodes for the replica/disperse set. However,
if a brick was down when rebalance started, the nodeuuids
would be saved as NULL and a set of files would not be migrated.
Now, if the nodeuuid is NULL, the first non-null entry in
the set is the node responsible for migrating the file.
Change-Id: I72554c107792c7d534e0f25640654b6f8417d373
fixes: bz#1564198
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 7a8418e31f372821917c5dfec7a403297501b07a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Mar 28 10:14:39 2018 -0400
core/build/various: python3 compat, prepare for python2 -> python3
Note 1) we're not supposed to be using #!/usr/bin/env python, see
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Shebang_lines
Note 2) we're also not supposed to be using "!/usr/bin/python,
see https://fedoraproject.org/wiki/Changes/Avoid_usr_bin_python_in_RPM_Build#Quick_Opt-Out
The previous patch (https://review.gluster.org/19767) tried to do too
much in one patch, so it was abandoned.
This patch does two things:
1) minor cleanup of configure(.ac) to explicitly use python2
2) change all the shebang lines to #!/usr/bin/python2 and add them
where they were missing based on warnings emitted during rpmbuild.
In a follow-up patch python2 will eventually be changed to python3.
Before that python2-isms (e.g. print, string.join(), etc.) need to be
converted to python3. Some of those can be rewritten in version agnostic
python. E.g. print statements become print() with "from __future_ import
print_function". The python 2to3 utility will be used for some of those.
Also Aravinda has given guidance in the comments to the first patch for
changes.
updates: #411
Change-Id: I471730962b2526022115a1fc33629fb078b74338
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 7ea70b5463d7bfa825c035d6e677eaf9bc001834
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Apr 5 21:41:44 2018 +0530
cluster/dht: Wind open to all subvols
dht_opendir should wind the open to all subvols
whether or not local->subvols is set. This is
because dht_readdirp winds the calls to all subvols.
Change-Id: I67a96b06dad14a08967c3721301e88555aa01017
updates: bz#1564198
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 549b5471d045428ce65fe6d3191d1837efd77404
Author: Varsha Rao <varao@redhat.com>
Date: Fri Mar 16 14:23:25 2018 +0530
xlators/performance: Add pass-through option
Add pass-through option in performance traslators. Set the option in
GF_OPTION_INIT() and GF_OPTION_RECONF()
Updates: #304
Change-Id: If1537450147d154905831e36f7162a32866d7ad6
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 88e44dab60ddcf18ee20bf81e198870606127156
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Mar 26 12:55:12 2018 +0530
posix: reserve option behavior is not correct while using fallocate
Problem: storage.reserve option is not working correctly while
disk space is allocate throguh fallocate
Solution: In posix_disk_space_check_thread_proc after every 5 sec interval
it calls posix_disk_space_check to monitor disk space and set the
flag in posix priv.In 5 sec timestamp user can create big file with
fallocate that can reach posix reserve limit and no error is shown on
terminal even limit has reached.
To resolve the same call posix_disk_space for every fallocate fop
instead to call by a thread after 5 second
BUG: 1560411
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I39ba9390e2e6d084eedbf3bcf45cd6d708591577
commit e55f4e0a8a371596b6077324c831e7ee1c65a0bc
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Mon Apr 9 08:33:51 2018 -0400
storage/posix: add pgfid in readdirp if needed
Change-Id: I6745428fd9d4e402bf2cad52cee8ab46b7fd822f
fixes: bz#1560319
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 4e937e3d5e7ffc66835c9828f8b427ccc1827348
Author: Susant Palai <spalai@redhat.com>
Date: Fri Mar 16 10:15:52 2018 +0530
posix: check file state before continuing with fops
In context of Cloudsync:
In scenarios where a data modification fop e.g. a write landed in
POSIX thinking that the file is local, while the file was actually
remote, can be dangerous. Ofcourse we don’t want to take inodelk
for every read/write operation to check the archival status or
coordinate with an upload or a download of a file. To avoid inodelk,
we will check the status of the file in POSIX it self, before we
resume the fop. This helps us avoiding any races mentioned above.
Now e.g. if a write reached POSIX for a file which was actually remote,
it can check the status of the file and will get to know that the file
is remote. It can error out with this status “remote” and cloudsync
xlator will retry the same operation, once it finished downloading the
file.
This patch includes the setxattr changes to do the post processing of
upload i.e. truncate and setting the remote xattr
"trusted.glusterfs.cs.remote" to indicate the file is REMOTE
Each file will have no xattr if the file is LOCAL, one remote xattr if
the file is REMOTE and a combination of REMOTE and DOWNLOADING xattr if
the file is getting downloaded. There is healing logic of these xattrs
to recover from crash inconsitencies.
Fixes: #387
Change-Id: Ie93c2d41aa8d6a798a39bdbef9d1669f057e5fdb
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 825e931529dd5286a5ac09198694eeade755bc76
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Apr 4 10:03:18 2018 +0530
cluster/dht: act as passthrough for renames on single child DHT
Various synchronization present in dht_rename while handling
directories and files is necessary only if we have more than only one
child.
Change-Id: Ie21ad419125504ca2f391b1ae2e5c1d166fee247
fixes: bz#1563511
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 04bed9548cae5c7bfd8acbb55c634dcf6122d312
Author: Susant Palai <spalai@redhat.com>
Date: Fri Mar 9 20:07:19 2018 +0530
experimental/cloudsync: Download xlator for archival feature
spec-files:
https://review.gluster.org/#/c/18854/
Overview:
* Cloudsync maintains three file states in it's inode-ctx i.e
1 - LOCAL,
2 - REMOTE,
3 - DOWNLOADING.
* A data modifying fop is allowed only if the state is LOCAL.
If the state is REMOTE or DOWNLOADING, client will download
or wait for the download to finish initiated by other client.
* Multiple download and upload from different clients are synchronized
by inodelk.
* In POSIX a state check is done (part of different commit)before
allowing the fop to continue. If the state is remote/downloading the
fop is unwound with EREMOTE. The client will then download the file
and continue with the fop again.
* Basic Algo for fop (let's say write fop):
- If LOCAL -> resume fop
- If REMOTE ->
- INODELK
- STAT (this gets state and heal the state if needed)
- DOWNLOAD
- resume fop
Note:
* Developers will need to write plugins for download, based on the
remote store they choose. In phase-1, support will be added for
one remote store per volume. In future, more options for multiple
remote stores will be explored.
TODOs:
- Implement stat/lookup/readdirp to return size info from xattr
- Make plugins configurable
- Implement unlink fop
- Add metrics collection
- Add sharding support
Design Contributions:
Aravinda V K <avishwan@redhat.com>
Amar Tumballi <amarts@redhat.com>
Ram Ankireddypalle <areddy@commvault.com>
Susant Palai <spalai@redhat.com>
updates: #387
Change-Id: Iddf711ee7ab4e946ae3e472ff62791a7b85e6d4b
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 952d8592e296fa11dfc5207b9c089a8ae4860248
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Tue Mar 13 06:50:48 2018 -0400
quota: allow writes when with EINVAL on pgfid isnot exist
NFS client gets "Invalid argument" when writing file through nfs-ganesha.
1. With quota disabled;
nfs client mount nfs-ganesha share, and do 'll' in the testing directory.
2. Enable quota;
getfattr: Removing leading '/' from absolute path names
trusted.gfid=0xe2edaac0eca8420ebbbcba7e56bbd240
trusted.gfid2path.b3250af8fa558e66=0x39663134343566662d653530332d343831352d396635312d3236633565366332633137642f7465737466696c653932
trusted.glusterfs.quota.9f1445ff-e503-4815-9f51-26c5e6c2c17d.contri.3=0x00000000000002000000000000000001
Notice: testfile92 without trusted.pgfid xattr.
3. restart glusterfs volume by "gluster volume stop/start gvtest"
4. echo somedata > testfile92
5. ll testfile92
-rw-r--r-- 1 root root 0 Mar 6 21:43 testfile92
BUG: 1560319
Change-Id: Iaa4dd1e891c99069fb85b7b11bb0482cbf2303b1
fixes: bz#1560319
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 70c831fee1f9af71de99c0cc3bc9ee64b1f1e56a
Author: Milind Changire <mchangir@redhat.com>
Date: Fri Apr 6 23:19:07 2018 +0530
rpc: rearm listener socket early
Problem:
On node reboot, when glusterd starts volumes, a setup with a large
number of bricks might cause SYN Flooding and connections to be dropped
if the connections are not accepted quickly enough.
Solution:
accept() the connection and rearm the listener socket early to receive
more connection requests as soon as possible.
Change-Id: Ibed421e50284c3f7a8fcdb4de7ac86cf53d4b74e
fixes: bz#1564600
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 3ee7f1ac05c9c9551f08a8d78f1003e01a7ed0ba
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 21 18:06:54 2018 +0530
features/index: Choose different base file on EMLINK error
Change-Id: I4648816af908539efdc2528608aa2ebf7f0d0e2f
fixes: bz#1559004
BUG: 1559004
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 33780382efc20a3cad4292795b93ba7b3a5db762
Author: Varsha Rao <varao@redhat.com>
Date: Thu Apr 5 11:26:12 2018 +0530
doc: Update the admin guide link
Update the existing admin guide link as it is incorrect.
Change-Id: I05669192623aeac287dfa9002caa0f390ea79499
Updates: bz#1193929
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 68d7d3d099cd803e9e7b41559771469917d4cd28
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Apr 5 12:09:56 2018 +0530
cluster/ec: Turn ON the stripe-cache option by default
Change-Id: I0a290396c30c635b13ee73004d20259efb76a954
fixes: bz#1563945
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit f174d6af0bc8f5d30d0185162e3975be4af80343
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Apr 5 14:50:45 2018 -0400
gfapi: fix a couple of minor issues
duplicatation of exported functions in gfapi.map. Only the newest one
is needed. Both the legacy and current symbols are exported.
glfs_io_cbk34 typedef should not be in a public header file. The old
application was compiled with the original glfs_io_cbk. Outside of
libgfapi, nothing now uses/needs this old typedef, move it into the
C file that needs it.
Similarly glfs_realpath34() decl should not be in glfs.h. Period. Old
applications were compiled with the then glfs_realpath() decl and
linked with glfs_realpath@@GFAPI_3_4.0. New applications should only
call glfs_realpath() and it will be linked to the new/current
glfs_realpath().
Change-Id: Icd5b0c9e9b68f0c133f14447b09ace35f33dbab2
fixes: bz#1564235
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 8b5cf432c38cd5203de78c7499f3a1d9647d922a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun Apr 1 22:10:30 2018 +0530
glusterd: show brick online after port registration
gluster-block project needs a dependency check to see if all the bricks
are online before bringing up the relevant gluster-block services. While
the patch https://review.gluster.org/#/c/19785/ attempts to write the
script but brick should be only marked as online only when the
pmap_signin is completed.
While this is perfectly fine for non brick multiplexing, but with brick
multiplexing this patch still doesn't eliminate the race completely as
the attach_req call is asynchrnous and glusterd immediately marks the
port as registerd.
Change-Id: I81db54b88f7315e1b24e0234beebe00de6429f9d
Fixes: bz#1563273
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 3acdbbe5bfea0ba130d874fe55a243fb65fb6bc5
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Mar 27 20:54:25 2018 +0530
afr: add quorum checks in pre-op
Problem:
We seem to be winding the FOP if pre-op did not succeed on quorum bricks
and then failing the FOP with EROFS since the fop did not meet quorum.
This essentially masks the actual error due to which pre-op failed. (See
BZ).
Fix:
Skip FOP phase if pre-op quorum is not met and go to post-op.
Fixes: 1561129
Change-Id: Ie58a41e8fa1ad79aa06093706e96db8eef61b6d9
fixes: bz#1561129
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 8a77b525b3df81157cb55414722e90acbd97c5a1
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Mar 27 16:53:33 2018 +0530
glusterd: mark port_registered to true for all running bricks with brick mux
glusterd maintains a boolean flag 'port_registered' which is used to determine
if a brick has completed its portmap sign in process. This flag is (re)set in
pmap_sigin and pmap_signout events. In case of brick multiplexing this flag is
the identifier to determine if the very first brick with which the process is
spawned up has completed its sign in process. However in case of glusterd
restart when a brick is already identified as running, glusterd does a
pmap_registry_bind to ensure its portmap table is updated but this flag isn't
which is fine in case of non brick multiplex case but causes an issue if
the very first brick which came as part of process is replaced and then
the subsequent brick attach will fail. One of the way to validate this
is to create and start a volume, remove the first brick and then
add-brick a new one. Add-brick operation will take a very long time and
post that the volume status will show all other brick status apart from
the new brick as down.
Solution is to set brickinfo->port_registered to true for all the
running bricks when brick multiplexing is enabled.
Change-Id: Ib0662d99d0fa66b1538947fd96b43f1cbc04e4ff
Fixes: bz#1560957
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 849f01487c90130f86c27e01a64e07144ec4ed75
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Mar 26 13:39:55 2018 +0530
features/changelog: Update option levels
Options levels for Changelog Xlator
Change-Id: Idd246717e38096c44258a990a0939f82e5fc9654
Updates: #430
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 99a933979858ab623848441c9df1c14171d44ef6
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Mar 16 20:54:15 2018 +0530
cluster/dht: enable lookup-optimize by default
Lookup-optimize has been shown to improve create
performance. The code has been in the project for several
years and is considered stable.
Enabling this by default in order to test this in the
upstream regression runs.
Change-Id: Iab792979ee34f0af4713931e0b5b399c23f65313
updates: bz#1557435
BUG: 1557435
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 871ff73bc9db8f0f6e396a8888a8e7469c86aed5
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun Apr 1 10:10:41 2018 +0530
glusterd: fix txn_opinfo memory leak
For transactions where there's no volname involved (eg : gluster v
status), the originator node initiates with staging phase and what that
means in op-sm there's no unlock event triggered which resulted into a
txn_opinfo dictionary leak.
Credits : cynthia.zhou@nokia-sbell.com
Change-Id: I92fffbc2e8e1b010f489060f461be78aa2b86615
Fixes: bz#1550339
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit b78a5a64e7ef93a040c01a44deea7e2e4efa7bc6
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 3 21:28:37 2018 +0530
glusterd: honour localtime-logging for all the daemons
Change-Id: I97a70d29365b0a454241ac5f5cae56d93eefd73a
Fixes: bz#1563334
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit ea8eadca99c3ded0fed0cd89f32ebcbb89452b9e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 29 21:28:33 2018 +0530
cluster/afr: Prevent ping-event handling on shd
On shd, we shouldn't treat any brick down based
on latency, otherwise self-heal will never happen
fixes: bz#1562717
Change-Id: Ica07fcc4fae91a6bfd9c9a670e2be464704d94b7
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit bb3e5fc6a7cbf00d3d083cecb096e8b70a008d61
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Apr 2 20:30:16 2018 +0530
glusterd: setting mgmt_v3_timer->timer to NULL after deleting mgmt_v3_timer
We are setting mgmt_v3_timer->timer to NULL after mgmt_v3_timer is deleted
which is unnecessary. So removing the statement.
This issue is caught while running glusterd with ASAN.
Change-Id: Ied1f91590a2c64ec1af36d4de9c3febd6cf94bb9
Fixes: bz#1562907
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 924626caf375f5570b96e074d89e180c98a2adb9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Apr 2 12:09:44 2018 +0530
mount/fuse: Set default fuse reader thread count to 1
Updates #412
Change-Id: Ida53d8b630feabb856a3551fa888f92382ade768
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 51b1a00032a590a1f2710d2f36c8ed1f7698f54a
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Mar 30 00:14:19 2018 +0200
ocf: use glusterd-workdir for finding volume status files
The volume status files are located in the glusterd-workdir, not under
/etc (sysconfdir).
BUG: 1234873
Change-Id: Id7f7c83261bb4b5ac2fc104dcd6cb198d6a930aa
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 4bac3a637fd4b58106194147f532d42556f1218b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Mar 28 09:01:05 2018 -0400
build: revert configure --without-ipv6-default behaviour
patch https://review.gluster.org/19692 breaks gluster on systems with
IPv6 enabled but don't have IPv6 reverse DNS. Also it defaulted to
enabling ipv6-default regardless of whether --with-ipv6-default or
--without-ipv6-default were specified in the options to configure.
(Also the patch was merged without review.)
Prefer libtirpc over glibc rpc.
On newer linux with tirpc and without glibc rpc use tirpc (obviously)
on less new linux with both tirpc and glibc rpc default to use tirpc,
unless --without-tirpc is specified, in which case use glibc rpc
On less new linux without tirpc fall back to glib rpc (obviously)
ipv6-default requires libtirpc. It is off by default. It must be
explicitly enabled with --with-ipv6-default. If --with-ipv6-default is
specified, but tirpc is not available, disable it and issue a warning
Change-Id: Ib96a230fafb83ec83a71948fe55af1215a7a6ffa
BUG: 1562052
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit ea3d963d1e9667575c9ec11cc733295faed835c3
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Mar 26 13:20:17 2018 +0530
cluster/dht: Update dht option levels
Set the levels for DHT options based on
https://review.gluster.org/#/c/19466/
Change-Id: I51b31a706a0b9517404e83224c89de145fd5d7e1
updates: #430
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 6828c0254153871ec78186a8201d9978ff96f0f8
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jan 9 15:11:00 2018 +0530
mount/fuse: Add support for multi-threaded fuse readers
Usage: Use 'reader-thread-count=<NUM>' as command line option to
set the thread count at the time of mounting the volume.
Next task is to make these threads auto-scale based on the load,
instead of having the user remount the volume everytime to change
the thread count.
Updates #412
Change-Id: I94aa1505e5ae6a133683d473e0e4e0edd139b76b
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit e5fac75a5578a8f62cfc09dd5a01a2ecbe98d63e
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Mar 29 18:23:13 2018 +0530
cluster/dht: Update layout in inode only on success
With lookup-optimize enabled, gf_defrag_settle_hash in rebalance
sometimes flips the on-disk layout on volume root post the
migration of all files in the directory.
This is sometimes seen when attempting to fix the layout of a
directory multiple times before calling gf_defrag_settle_hash.
dht_fix_layout_of_directory generates a new layout in memory but
updates it in the inode ctx before it is set on disk. The layout
may be different the second time around due to
dht_selfheal_layout_maximize_overlap. If the layout is then not
written to the disk, the inode now contains the wrong layout.
gf_defrag_settle_hash does not check the correctness of the layout
in the inode before updating the commit-hash and writing it to the
disk thus changing the layout of the directory.
Change-Id: Ie1407d92982518f2a0c40ec70ad370b34a87b4d4
updates: bz#1557435
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 76a5024fb1a11547a285cade41e7e8b13a4a6a83
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Mar 29 10:48:32 2018 +0000
Revert "glusterd: handling brick termination in brick-mux"
This reverts commit a60fc2ddc03134fb23c5ed5c0bcb195e1649416b.
This commit was causing multiple tests to time out when brick
multiplexing is enabled. With further debugging, it's found that even
though the volume stop transaction is converted into mgmt_v3 to allow
the remote nodes to follow the synctask framework to process the command,
there are other callers of glusterd_brick_stop () which are not synctask
based.
Change-Id: I7aee687abc6bfeaa70c7447031f55ed4ccd64693
updates: bz#1545048
commit da37bf8c2034ce520d954636691341b901ad7c1e
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Mar 22 17:55:15 2018 +0530
afr: add new value for read-hash-mode volume option
Updates: #363
This new value (3) will try to wind read requests to the child of AFR
having the least amount of pending requests in its queue.
Change-Id: If6bda2aac9bf7aec3fc39622f78659313c4b6508
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 03d0fe1c5519534cbc618cb995b2aebd0b58bc85
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Wed Mar 28 11:34:49 2018 +0200
cluster/ec: send list-node-uuids request to all subvolumes
The xattr trusted.glusterfs.list-node-uuids was only sent to a single
subvolume. This was returning null uuids from the other subvolumes as
if they were down.
This fix forces that xattr to be requested from all subvolumes.
Change-Id: If62eb39a6857258923ba625e153d4ad79018ea2f
fixes: bz#1561406
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 65b756be1ffa74a35c65ebaee6022adc707758a1
Author: Michael Scherer <misc@redhat.com>
Date: Fri Oct 27 09:50:20 2017 +0200
Fix gluster(8) formatting
Looking at the man page show that "Snapshot command" wasn't aligned
with the other section titles.
Change-Id: I24bdb2e3728e03862fee57710cfe34b0607fe09a
BUG: 1507230
Signed-off-by: Michael Scherer <misc@redhat.com>
commit b489de7c40a8f9e2a5e55627030d8354374ffc5c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Mar 27 14:59:59 2018 -0400
glusterd: changing the op-version of volume stop mgmt v3
log message describe the actual test
Change-Id: I1ea7300a6b186032a65236492d6d2a6eef0ab983
fixes: bz#1560441
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 91d5907f78c11f2cbf44c1755edc73e78a1843b9
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Wed Mar 18 11:02:18 2015 -0700
rpc: update tirpc registration to "force" unregister old mapping before re-registering
> Reviewed-on: https://review.gluster.org/16849
> Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
Change-Id: I05ed6b7c715a71e5819fbe8116e7c3146010f836
BUG: 1521030
Signed-off-by: Kevin Vigor <kvigor@fb.com>
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 9a00f5d2fc45effc008a828ccc6ec17bfc38dca7
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Fri Nov 10 11:57:31 2017 +0800
rpc: simplify parameters when a saved frame is forced to unwind
When a saved frame is to be forced unwind, there is no need to pass an
empty iovector without any data pointed to.
Change-Id: I6e858fb38644326e22239b83272b15db656035e5
BUG: 1523122
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit 9277a4ed24e64d6b5235b62bacdc983cb1911db2
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Fri Aug 25 15:15:46 2017 +0800
rpc: fix incorrect return value when xdr decode fails
xdr_replymsg is called to decode reply message, and it returns failure
if the message is corrupted. However, retrieving return value from
the global errno is 0 even xdr_replymsg fails.
Fix this issue by simply returning a negative value if call to
xdr_replymsg fails.
Change-Id: I2b9a1dc97652fbb6cf6568ea617f120713784a55
BUG: 1523122
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit e85ce9093796dbb2f2782531d4d9e50bb0399a13
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Feb 21 12:46:25 2018 +0530
glusterd: handling brick termination in brick-mux
Problem: There's a race between the last glusterfs_handle_terminate()
response sent to glusterd and the kill that happens immediately if the
terminated brick is the last brick.
Solution: When it is a last brick for the brick process, instead of glusterfsd
killing itself, glusterd will kill the process in case of brick multiplexing.
And also changing gf_attach utility accordingly.
Change-Id: I386c19ca592536daa71294a13d9fc89a26d7e8c0
fixes: bz#1545048
BUG: 1545048
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 774ed8f5e454a0e59f42c05cbea1edaed8215822
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Mar 26 10:56:51 2018 +0530
cluster/dht: ENOSPC will not fail rebalance
ENOSPC returned by a file migration is no longer
considered a rebalance failure.
Change-Id: I21cf3a8acdc827bc478e138d6cb5db649d53a28c
fixes: bz#1553598
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit ea7291ec51d9c73a3d3193e6d2592c38d6811a4d
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Fri Feb 23 15:26:20 2018 +0530
Quota: heal directory on newly added bricks when quota limit is reached
Problem: if a lookup is done on a newly added brick for a path on which limit
has been reached, the lookup fails to heal the directory tree due to quota.
Solution: Tag the lookup as an internal fop and ignore it in quota.
Since marking internal fop does not usually give enough contextual information.
Introducing new flags to pass the contextual info.
Adding dict_check_flag and dict_set_flag to aid flag operations.
A flag is a single bit in a bit array (currently limited to 256 bits).
Change-Id: Ifb6a68bcaffedd425dd0f01f7db24edd5394c095
fixes: bz#1505355
BUG: 1505355
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
commit 3f96ca30ccc391fd89751b0dbdd4a396ad23d7e1
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Mar 14 10:27:57 2018 +0530
quick-read: Provide statistics to the monitor
Updates: #425
Change-Id: Iea5198821f4eabc46bc63529afa4a92d4b4c2be0
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit ae438ca8b135bf3361d70ac79a740e64c4d1c476
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Mar 27 11:01:27 2018 +0530
glusterd: changing the op-version of volume stop mgmt v3
Change-Id: Iefc5a00d36436b23181871fa365f27b8d90cff0a
fixes: bz#1560441
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 908541518eeb6d71da8f6463657141dd071b95b0
Author: Vishal Pandey <vpandey@redhat.com>
Date: Mon Mar 26 12:05:25 2018 +0530
glfs heal binary change to accomodate socket file arguments
Change-Id: I755d6552decd015aec7859ad2cf99c76c8bee9dc
fixes: bz#1558380
BUG: 1558380
Signed-off-by: Vishal Pandey <vpandey@redhat.com>
commit f49294cad7b708e361a105f00914d669909fbda0
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Mar 26 13:18:07 2018 +0530
glusterd: Implementing volume stop in mgmt v3
Change-Id: I8f9c594cf56331d54eb4884335699744685ef20d
fixes: bz#1560441
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 038ee752c003d6817fba1a968ebee35c01ae53b9
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Mar 26 19:25:30 2018 +0530
tests: fix nl-cache.t failure
commit fef9293 changed network.inode-lru-limit from 50000 to 200000 in
nl-cache group profile but the test wasn't changed to reflect it
accordingly.
Change-Id: Ibb5fb0a387f160f6b726246b161a9a7b33135755
fixes: bz#1560589
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 100e6b5459e9788ce7655ad3651d35ea5b1f9674
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 26 18:30:50 2018 +0530
.testignore: remove the group profile files
Change-Id: I6619827f1bf6fe9bd974537af6169164b19a0aa5
fixes: bz#1560393
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 83b4c47a32d4ee1570df712e10e9854f815533f1
Author: Niklas Hambüchen <mail@nh2.me>
Date: Fri Sep 8 02:40:01 2017 +0200
glusterfind: Log remote stderr on `node_cmd` error. Fixes #1559130
The problem of lost stderr was introduced in
commit feea851fad4f89b48bfe89fe3b75250cc7bd6501.
Change-Id: Ic98f9bc9682ae3bd9c3ebea3855667fc8ba2843d
BUG: 1559130
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
commit d0720802739798d95ac2fe4e7bce11b4fecc4d53
Author: Susant Palai <spalai@redhat.com>
Date: Mon Mar 26 09:42:37 2018 +0530
md-cache: fix ./tests/basic/md-cache/bug-1418249.t
inode table size is currently set to 200000. Hence the need of change in
testcase which was expecting the old value 50000.
Change-Id: I8e44b1d0a2da1e8100bebd25f48bb36e2897b4f8
fixes: bz#1560393
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 515a678be7075157d6a4a19a06fb347a0daa3a25
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Mar 20 12:15:51 2018 +0530
extras/group: Change the server inode table size when upcall is on
By default server inode table size is 16K, when upcall is enabled,
there is going to be too many forgets sent on inodes as the brick can
hold only 16K inodes in memory, so we increased this to 50K. This is
still less than the client inode table size. We have seen performance
improvement when server inode table size is set to 200000(almost as
client inode table size). Hence changing the value to 200000.
Increasing this increases the memory consumption by <1MB.
BUG: 1559235
Change-Id: I931db965cd34bf33094328541bd5a633b3357805
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 035374f8763821791133e31e470ba249c9fa947b
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Mar 13 17:51:29 2018 +0530
nl-cache: Provide statistics to the monitor
Updates: #429
Change-Id: Ic2e64422055f1838d5d453643c739ef1e9319cfe
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit b867683ce3ee1a0177691efe66011483d0b0def8
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Mar 13 17:38:19 2018 +0530
md-cache: Provide statistics to the monitor
Updates: #427
Change-Id: Ib1f45016ac75d7bc2755db0dd4b68ce1d95d26c3
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 26fdbd120705ffb9fea9d30488c58ffaf3b6bd48
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Thu Aug 31 16:49:40 2017 +0530
features/quota: Add new fields to translator options for GD2
alert-time, soft timeout, hard timeout, default soft limit
and deem-statfs will be settable through volume set command.
hence marked as settable.
Other options are used only via quota commands.
Updates #302
Change-Id: I02d258cc3aa7fe58ccbadd59441cce64cfd9ba6e
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
commit e8e5fa85de22165e347fb93b060f8af7afb4e705
Author: James Le Cuirot <chewi@gentoo.org>
Date: Fri Mar 9 23:06:43 2018 +0000
build: Fix misleading TIRPC result in configure summary
Requesting ipv6-default even if you explicitly disable libtirpc will
then implicitly enable libtirpc because that is required. That is fine
but the configure summary should not then show TIRPC as disabled when
it is not.
The result has also been made clearer by stating that TIRPC is
"missing" when it has been tried but not found.
BUG: 1553938
Change-Id: I945bd6859aaf3defa682b0d05ee34a9827b9c45f
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
commit 5399a86ead9f65dfad7c24b62aba11aeb069dd6e
Author: James Le Cuirot <chewi@gentoo.org>
Date: Fri Mar 9 22:39:41 2018 +0000
build: Fix configure --without-ipv6-default behaviour
The current behaviour disables ipv6-default when no switch is given at
all but otherwise checks if libtirpc was requested, regardless of
whether you have given --with-ipv6-default or --without-ipv6-default.
I believe the intention was to enable when libtirpc is requested by
default but otherwise respect the switch given.
This is important because ipv6-default breaks Gluster for systems that
have IPv6 disabled.
BUG: 1553926
Change-Id: I76b91ae2699574b2e5b777453732bb5cbd79bbca
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
commit a32c1edc9a9917126743012515e62b420a72465b
Author: Niklas Hambüchen <mail@nh2.me>
Date: Wed Mar 21 18:54:24 2018 +0100
libgfchangelog: Correct the log message
Provide correct error message for changelog end time check
Updated error message to print "wrong result for end".
Original patch by Keith Schincke <kschinck@redhat.com>
from https://review.gluster.org/#/c/8121/
Change-Id: Ia3458cbac7784bfc71c05da67391a3f8259f18f0
BUG: 1559126
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
commit f73181612f9c609ef985222d869d9f4c5da82c94
Author: Niklas Hambüchen <mail@nh2.me>
Date: Sat May 13 18:54:36 2017 +0200
python: Remove all uses of find_library. Fixes #1450593
`find_library()` doesn't consider LD_LIBRARY_PATH on Python < 3.6.
Change-Id: Iee26085cb5d14061001f19f032c2664d69a378a8
BUG: 1450593
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
commit 629bce68a18afddec0bc67f26bb61d142432ceaf
Author: Niklas Hambüchen <mail@nh2.me>
Date: Sun Dec 31 17:46:40 2017 +0100
glusterfind: Show C function when raising ChangelogException
Fixes: #432
Change-Id: I9ab031e098aff717e619d9deb6410281b96de14a
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
commit 3487ad818d41b5bc288c4534388f89bbe604c3a4
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Feb 14 04:11:24 2018 +0530
rfc.sh: provide a unified way to update bugs or github issues ID
Change-Id: Ie78d87b31512da6201ae26f3d391fa3f8e5b68d1
fixes: bz#1545891
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 2eab93ecbca90358db37d83c77b5f578dd3d8eb2
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Mar 14 13:39:26 2018 +0100
client: make fuse direct I/O strategies explicit
So far the --direct-io-mode option has been presented
as of being Boolean valued. That is however not exact,
as a third behavior is chosen if the option is not
specified.
We accept now the "auto" value as an explicit choice
for the default heuristics, and indicate in the
descriptions of the option (which occur in commandline
help and in the gluterfs / mount.glusterfs man pages)
that auto is the default.
The default heuristics was briefly described in the
commandline help. We are getting rid of that, because:
- it's not the right place to provide such details;
- there is no guarantee of keeping the current heuristics
so it might go out of sync with reality;
- that is already the case to some degree, because the
description did not take into account that the default
heuristics varies between platforms (on Mac, it's just
"off"), and that xlators can also prescribe direct I/O
for the file of their choice (see change
I3fe3312cd96baa4eecfe1247ab7255b4f455f049).
Change-Id: Ia83479c0c67fe66b7fc2e0e8db5b7792d9f44b28
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 2ead32eaff24b9fd5e6fd2061b0c6aaba47e04fa
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Mar 21 21:57:50 2018 +0530
rpcsvc: enable ownthread feature for glusterfs4_0_fop_prog
Ownthread feature needs enabling for glusterfs4_0_fop_prog
Change-Id: Idce63eb094ae0fdfcddbd52d0dee25aa0e074926
BUG: 1559075
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit f0eef74cd5704ddb474faa3789d9cb6a2071372a
Author: Niklas Hambüchen <mail@nh2.me>
Date: Fri Nov 3 18:53:54 2017 +0100
socket: Improve error logging when loading SSL files fails
* Say which file had the problem
* Dump openssl error stack
Fixes gluster/glusterfs#431.
Change-Id: I66e9a0ae7758e9d7d8a5f19cc8ff898f01f2b491
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
commit 7033eaea91e4157de5fdeba496598b9d05024f3e
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Tue Mar 20 10:57:13 2018 +0100
cluster/ec: fix SHD crash for null gfid's
When the self-heal daemon is doing a full sweep it uses readdirp to
get extra stat information from each file. This information is
obtained in two steps by the posix xlator: first the directory is
read to get the entries and then each entry is stated to get additional
info. Between these two steps, it's possible that the file is removed
by the user, so we'll get an error, leaving stat info empty.
EC's heal daemon was using the gfid blindly, causing an assert failure
when protocol/client was trying to encode the gfid.
To fix the problem a check has been added. If we detect a null gfid, we
simply ignore it and continue healing.
Change-Id: I2e4acdcecd0b6951055e50d1c37d686a2186a228
BUG: 1558016
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit 14e8aa32f6ecf3656056b69e60caf0d97ea27b33
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 19 15:26:40 2018 +0530
cluster/afr: Switch to active-fd-count for open-fd checks
BUG: 1557932
Change-Id: I3783e41b3812267bc10c0d05d062a31396ce135b
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 550bd9895cfbf953c32377c7f366d455a1b4ae78
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 19 15:12:14 2018 +0530
storage/posix: Add active-fd-count option in gluster
Problem:
when dd happens on sharded replicate volume all the writes on shards happen
through anon-fd. When the writes don't come quick enough, old anon-fd closes
and new fd gets created to serve the new writes. open-fd-count is decremented
only after the fd is closed as part of fd_destroy(). So even when one fd is on
the way to be closed a new fd will be created and during this short period it
appears as though there are multiple fds opened on the file. AFR thinks another
application opened the same file and switches off eager-lock leading to
extra latency.
Fix:
Have a different option called active-fd whose life cycle starts at
fd_bind() and ends just before fd_destroy()
BUG: 1557932
Change-Id: I2e221f6030feeedf29fbb3bd6554673b8a5b9c94
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 99c7659d7805aae3f54d98ec8509078097900648
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Nov 28 18:18:12 2017 +0530
cluster/ec: Add test cases for stripe-cache option
Change-Id: I1508a336a7a927b389a19815ef57001cdf29b109
BUG: 1558074
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 1d8891dfb72a7162dc707190f4da373498a3558a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 19 12:09:18 2018 +0530
features/shard: Do list_del_init() while list memory is valid
Problem:
shard_post_lookup_fsync_handler() goes over the list of inode-ctx that need to
be fsynced and in cbk it removes each of the inode-ctx from the list. When the
first member of list is removed it tries to modifies list head's memory with
the latest next/prev and when this happens, there is no guarantee that the
list-head which is from stack memory of shard_post_lookup_fsync_handler() is
valid.
Fix:
Do list_del_init() in the loop before winding fsync.
BUG: 1557876
Change-Id: If429d3634219e1a435bd0da0ed985c646c59c2ca
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 4fc99b93667edb3f6f6e4f8ec497d191908f60fc
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Mar 12 11:47:30 2018 +0530
georep : Pause/Resume of geo-replication with wrong user
While performing pause/resume on geo-replication with wrong user
(other user then you setup), always returns success. Which further
leads to snapshot creation failure as it is detecting active
geo-replication session.
Change-Id: I6e96e8dd3e861348b057475387f0093cb903ae88
BUG: 1550936
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit c5f03c114d7ad77565b828d436fefc54e979ff17
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Mar 14 09:37:52 2018 +0530
glusterd: TLS verification fails while using intermediate CA
Problem: TLS verification fails while using intermediate CA
if mgmt SSL is enabled.
Solution: There are two main issue of TLS verification failing
1) not calling ssl_api to set cert_depth
2) The current code does not allow to set certificate depth
while MGMT SSL is enabled.
After apply this patch to set certificate depth user
need to set parameter option transport.socket.ssl-cert-depth <depth>
in /var/lib/glusterd/secure_acccess instead to set in
/etc/glusterfs/glusterd.vol. At the time of set secure_mgmt in ctx
we will check the value of cert-depth and save the value of cert-depth
in ctx.If user does not provide any value in cert-depth in that case
it will consider default value is 1
BUG: 1555154
Change-Id: I89e9a9e1026e37efb5c20f9ec62b1989ef644f35
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 5d83969eb7e1610697e52bb1f51c42e656a5c4e0
Author: Sven Fischer <sven@fischer-abc.de>
Date: Sat Mar 17 23:30:38 2018 +0100
cleanup: xlator_t structure's 'client_latency' variable is not used
- Removed unused struct member and its one time usage.
- cleaned up wrong white space
member 'client_latency' was not used otherwise since it was added by
commit 07cc8679cdf3b29680f4f105d0222da168d8bfc1
Author: Kevin Vigor <kvigor@fb.com>
Date: Tue Mar 21 08:23:25 2017 -0700
Halo Replication feature for AFR translator
Change-Id: Ibb0ea828d4090bbe8897f6af326b317884162a00
BUG: 1495153
Signed-off-by: Sven Fischer <sven@fischer-abc.de>
commit 20ba0193ae4e78a1bf0c1bf4aff37f69181ad98d
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Thu Mar 15 10:27:55 2018 +0530
glusterd: glusterd crash in gd_mgmt_v3_unlock_timer_cbk
Memory cleanup of same pointer twice inside gd_mgmt_v3_unlock_timer_cbk
causing glusterd to crash.
Change-Id: I9147241d995780619474047b1010317a89b9965a
BUG: 1550339
commit c0c0115bf91e4b3750ef60aae82aa82b0bce15ba
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jan 31 16:41:14 2018 +0530
cluster/afr: Make AFR eager-locking similar to EC
Problem:
1) Afr's eager-lock only works for data transactions.
2) When there are conflicting writes, write with conflicting region initiates
unlock of eager-lock leading to extra pre-ops and post-ops on the file. When
eager-lock goes off, it leads to extra fsyncs for random-write workload in afr.
Solution (that is modeled after EC):
In EC, when there is a conflicting write, it waits for the current write to
complete before it winds the conflicted write. This leads to better utilization
of network and disk, because we will not be doing extra xattrops and FSYNCs and
inodelk/unlock. Moved fd based counters to inode based counters.
I tried to model the solution based on EC's locking, but it is not similar to
AFR because we had to keep backward compatibility.
Lifecycle of lock:
==================
First transaction is added to inode->owners list and an inodelk will be sent on
the wire. All the next transactions will be put in inode->waiters list until
the first transaction completes inodelk and [f]xattrop completely. Once
[f]xattrop also completes, all the requests in the inode->waiters list are
checked if it conflict with any of the existing locks which are in
inode->owners list and if not are added to inode->owners list and resumed with
doing transaction. When these transactions complete fop phase they will be
moved to inode->post_op list and resume the transactions that were paused
because of conflicts. Post-op and unlock will not be issued on the wire until
that is the last transaction on that inode. Last transaction when it has to
perform post-op can choose to sleep for deyed-post-op-secs value. During that
time if any other transaction comes, it will wake up the sleeping transaction
and takes over the ownership of the lock and the cycle continues. If the
dealyed-post-op-secs expire, then the timer thread will wakeup the sleeping
transaction and it will set lock->release to true and starts doing post-op and
then unlock. During this time if any other transactions come, they will be put
in inode->frozen list. Once the previous unlock comes it will move the frozen
list to waiters list and moves the first element from this waiters-list to
owners-list and attempts the lock and the cycle continues. This is the general
idea. There is logic at the time of dealying and at the time of new
transaction or in flush fop to wakeup existing sleeping transactions or
choosing whether to delay a transaction etc, which is subjected to change based
on future enhancements etc.
Fixes: #418
BUG: 1549606
Change-Id: I88b570bbcf332a27c82d2767dfa82472f60055dc
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit b55143b81326aea8a136d03ab7eb1579e5a8500f
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Mar 13 14:03:20 2018 +0530
cluster/ec: Change default read policy to gfid-hash
Problem:
Whenever we read data from file over NFS, NFS reads
more data then requested and caches it. Based on the
stat information it makes sure that the cached/pre-read
data is valid or not.
Consider 4 + 2 EC volume and all the bricks are on
differnt nodes.
In EC, with round-robin read policy, reads are sent on
different set of data bricks. This way, it balances the
read fops to go on all the bricks and avoid heating UP
(overloading) same set of bricks.
Due to small difference in clock speed, it is possible
that we get minor difference for atime, mtime or ctime
for different bricks. That might cause a different stat
returned to NFS based on which NFS will discard
cached/pre-read data which is actually not changed and
could be used.
Solution:
Change read policy for EC as gfid-hash. That will force
all the read to go to same set of bricks.
Change-Id: I825441cc519e94bf3dc3aa0bd4cb7c6ae6392c84
BUG: 1554743
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 8f1a7056a7b12d31a3877d6348114b890e9b6368
Author: Varsha Rao <varao@redhat.com>
Date: Thu Mar 8 11:08:34 2018 +0530
tests/basic/namespace: Fix the namespace test failure
In the jenkins regression test brick multiplexing is enabled by
is_brick_mx_enabled function and not by setting cluster.brick-multiplex
option. Hence check the count of bricks and its logs, this fixes the
failure.
Change-Id: Ibb2ed8fbffd3765f283da741689304a5579d447c
BUG: 1555167
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 8abb45b74e76f1a7dfd189d894aedfd7120b7adc
Author: Xavi Hernandez <jahernan@redhat.com>
Date: Wed Feb 21 17:47:37 2018 +0100
cluster/ec: avoid delays in self-heal
Self-heal creates a thread per brick to sweep the index looking for
files that need to be healed. These threads are started before the
volume comes online, so nothing is done but waiting for the next
sweep. This happens once per minute.
When a replace brick command is executed, the new graph is loaded and
all index sweeper threads started. When all bricks have reported, a
getxattr request is sent to the root directory of the volume. This
causes a heal on it (because the new brick doesn't have good data),
and marks its contents as pending to be healed. This is done by the
index sweeper thread on the next round, one minute later.
This patch solves this problem by waking all index sweeper threads
after a successful check on the root directory.
Additionally, the index sweep thread scans the index directory
sequentially, but it might happen that after healing a directory entry
more index entries are created but skipped by the current directory
scan. This causes the remaining entries to be processed on the next
round, one minute later. The same can happen in the next round, so
the heal is running in bursts and taking a lot to finish, specially
on volumes with many directory levels.
This patch solves this problem by immediately restarting the index
sweep if a directory has been healed.
Change-Id: I58d9ab6ef17b30f704dc322e1d3d53b904e5f30e
BUG: 1547662
Signed-off-by: Xavi Hernandez <jahernan@redhat.com>
commit 0248861f4a89ec87b9ddce7daf94122c0193953b
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Mar 13 16:39:44 2018 +0530
tests/bug-1110262.t: fix a race condition
This test does:
1. mount a volume
2. kill a brick in the volume
3. mkdir (/somedir)
In my local tests and in [1], I see that mkdir in step 3 fails because
there is no dht-layout on root directory.
The reason I think is by the time first lookup on "/" hit dht, a brick
was killed as per step 2. This means layout was not healed for "/" and
since this is a new volume, no layout is present on it. Note that the
first lookup done on "/" by fuse-bridge is not synchronized with
parent process of daemonized glusterfs mount completing. IOW, by the
time glusterfs cmd executed there is no guarantee that lookup on "/"
is complete. So, if step 2 races ahead of fuse_first_lookup on "/", we
end up with an invalid dht-layout on "/" resulting in failures.
Doint an operation like ls makes sure that lookup on "/" is completed
before we kill a brick
Change-Id: Ie0c4e442c4c629fad6f7ae850437e3d63fe4bea9
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
BUG: 1543279
commit 2e439d8b8ba0b066a4382e441e90ec83540ed416
Author: Sven Fischer <sven@fischer-abc.de>
Date: Mon Mar 12 23:00:28 2018 +0100
run-tests.sh: added dependency check for netstat
Because bug-924726.t depends on netstat, tests failed before. This got resolved
by adding respective check to run-tests.sh.
Enabled respective test again.
Change-Id: I70c9bff03379ed9ee8cd95842c3501dfb50b8e86
BUG: 1312830
Signed-off-by: Sven Fischer <sven@fischer-abc.de>
commit 20d15dc4727666c843557f3b89e6d320bc9644ae
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Mar 9 13:03:40 2018 +0530
cluster/dht: Skipped files are not treated as errors
For skipped files, use a return value of 1 to prevent
error messages being logged.
Change-Id: I18de31ac1a64d4460e88dea7826c3ba03c895861
BUG: 1553598
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 7ea6a3083d32fb94dab21287568a1f8557c455e3
Author: Milind Changire <mchangir@redhat.com>
Date: Fri Mar 9 16:17:38 2018 +0530
rpcsvc: correct event-thread scaling
Problem:
Auto thread count derived from the number of attachs and detachs
was reset to 1 when server_reconfigure() was called.
Solution:
Avoid auto-thread-count reset to 1.
Change-Id: Ic00e86adb81ba3c828e354a6ccb638209ae58b3e
BUG: 1547888
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit f6edbe425a991b87d7b750200b1ec9d77217c988
Author: ShyamsundarR <srangana@redhat.com>
Date: Sat Mar 10 23:08:04 2018 -0500
protocol: Fix 4.0 client, parsing older iatt in dict
In a mixed mode cluster involving 4.0 and older 3.x bricks, if
clients are newer, then the iatt encoded in the dictionary can be
of the older iatt format, which a newer client will map incorrectly
to the newer structure.
This causes failures in FOPs that depend on this iatt for some
functionality (seen in mkdir operations failing as EIO, when DHT
hits its internal setxattr call).
The fix provided is to convert the iatt in the dict, based on which
RPC version is used to communicate with the server.
IOW, this is the reverse of change in commit "b966c7790e"
Tested using a mixed mode cluster (i.e bricks in 3.12 and 4.0 versions)
and a mixed set of clients, 3.12 and 4.0 clients.
There is no regression test provided, as this needs a mixed mode cluster
to test and validate.
Change-Id: I454e54651ca836b9f7c28f45f51d5956106aefa9
BUG: 1554053
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit ea08b75a1b51a37308e9bf12f374243c187ed094
Author: ShyamsundarR <srangana@redhat.com>
Date: Fri Mar 9 16:51:57 2018 -0500
protocol: Added iatt conversion to older format
Added iatt conversion to an older format, when dealing with
older RPC versions. This enables iatt structure conformance
when dealing with older clients.
This helps fix rolling upgrade from 3.x versions to 4.0 version
of gluster by sending the right iatt in the dictionary when DHT
requests the same.
Change-Id: Ieaf925f81f8c7798a8fba1e90a59fa9dec82856c
BUG: 1544699
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit c468a3e9f4d67dd4c8dd9dbf797175d70445a77f
Author: Xavi Hernandez <xhernandez@redhat.com>
Date: Fri Mar 9 22:48:33 2018 +0100
protocol/client: fix memory corruption
There was an issue when some accesses to saved_fds list were
protected by the wrong mutex (lock instead of fd_lock).
Additionally, the retrieval of fdctx from fd's context and any
checks done on it have also been protected by fd_lock to avoid
fdctx to become outdated just after retrieving it.
Change-Id: If2910508bcb7d1ff23debb30291391f00903a6fe
BUG: 1553129
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
commit c784a07b81348546337558da721068c09e5b7a5e
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Feb 13 06:24:18 2018 +0530
core: provide infra to make any xlator pass-through
updates: #304
Change-Id: If6a13d2e56b195390a386d720103a882e077f66c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit e26cf33f1fd13ab3c5f430fdb6f0cfd29e6efee5
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Feb 26 13:55:19 2018 +0530
tests: don't kill the process directly with KILL signal
Instead send the SIGTERM (default, 15) first, and at the end
send SIGKILL. If SIGKILL is sent directly, we miss many tests
like valgrind, lcov etc., not able to process the information
properly.
BUG: 1549000
Change-Id: I664de12ee7dbf47eb98b8141004cd51f6006b314
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 3e1fba436623ea8a3707e08aa160e87a91662481
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Mar 6 21:59:44 2018 +0530
hooks: fix workdir in S13create-subdir-mounts.sh
Change-Id: Id3eff498091ad9fa4651e93b66903426e76776d6
BUG: 1549915
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 0d5b27dc3928824f21dfeda491b810866a36b6b8
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Feb 14 12:15:53 2018 +0530
glusterd: volume get fixes for client-io-threads & quorum-type
1. If a replica volume created on glusterfs-3.8 was upgraded to
glusterfs-3.12, `gluster vol get volname client-io-threads` displayed
'on' even though it wasn't and the xlator wasn't loaded on
the client-graph. This was due to removing certain checks in
glusterd_get_default_val_for_volopt as a part of commit
47604fad4c2a3951077e41e0c007ceb979bb2c24. Fix it.
2. Also, as a part of op-version bump-up, client-io-threads was being
loaded on the clients during volfile regeneration. Prevent it.
3. AFR assumes quorum-type to be auto in newly created replic 3 (odd
replica in general) volumes but `gluster vol get quorum-type` displays
'none'. Fix it.
Change-Id: I19e586361ed1065c70fb378533d3b4dac1095df9
BUG: 1545056
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit b766c782125df165f62ec43bea3a411fb4558e9e
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Nov 3 11:49:42 2017 +0530
hooks: add a script to stat the subdirs in add-brick
The subdirectories are expected to be present for a subdir
mount to be successful. If not, the client_handshake()
itself fails to succeed. When a volume is about to get
mounted first time, this is easier to handle, as if the
directory is not present in one brick, then its mostly
not present in any other brick. In case of add-brick,
the directory is not present in new brick, and there is
no chance of healing it from the subdirectory mount, as
in those clients, the subdir itself will be 'root' ('/')
of the filesystem. Hence we need a volume mount to heal
the directory before connections can succeed.
This patch does take care of that by healing the directories
which are expected to be mounted as subdirectories from the
volume level mount point.
Change-Id: I2c2ac7b7567fe209aaa720006d09b68584d0dd14
BUG: 1549915
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 0ffd680b4036391edb128c116ac07913ee4fa453
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Mar 2 12:37:42 2018 +0530
cluster/afr: Remove unused code paths
Removed
1) afr-v1 self-heal locks related code which is not used anymore
2) transaction has some data types that are not needed, so removed them
3) Never used lock tracing available in afr as gluster's network tracing does
the job. So removed that as well.
4) Changelog is always enabled and afr is always used with locks, so
__changelog_enabled, afr_lock_server_count etc functions can be deleted.
5) transaction.fop/done/resume always call the same functions, so no need
to have these variables.
BUG: 1549606
Change-Id: I370c146fec2892d40e674d232a5d7256e003c7f1
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit d82c8199bd680214095d6b66774e20faf87245f9
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Thu Mar 1 14:44:34 2018 +0530
glusterd : memory leak in mgmt_v3 lock functionality
In order to take care of stale lock issue, a timer was intrduced
in mgmt_v3 lock. This timer is not freeing the memory due to
which this leak got introduced
With this fix now memory cleanup in locking is handled properly
Change-Id: I2e1ce3ebba3520f7660321f3d97554080e4e22f4
BUG: 1550339
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
commit 6d93147f1f3682cd082315dbe3b19ecec354f738
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Mar 2 10:13:20 2018 +0530
cluster/afr: Remove compound-fops usage in afr
We are not seeing much improvement with this change. So removing the
feature so that it doesn't need to be maintained anymore.
Fixes: #414
Change-Id: Ic7969b151544daf2547bd262a9fa03f575626411
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit e6035f273987d9a0bbc50326d47a017462fe62c9
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Feb 19 20:48:14 2018 +0530
nl-cache: Fix coverity issue RESOURCE_LEAK
Change-Id: Ic552f31853e1886b8c76d45c8c66251f1fd6f97f
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit ed3a6703b3ca700833e1a1542a24ed6351929e0d
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Feb 19 20:46:21 2018 +0530
nl-cache: Fix coverity issue RETURN_LOCAL
Change-Id: Ic6fbd34aad2a5ae5e27d833300bcd1284cb98c24
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 5b58657e2656044b76a54e638f5368255b6fdd9e
Author: Csaba Henk <csaba@redhat.com>
Date: Mon Mar 5 13:02:09 2018 +0100
fuse: enable proper "fgetattr"-like semantics
GETATTR FUSE message can carry a file handle
reference in which case it serves as a hint
for the FUSE server that the stat data is
preferably acquired in context of the given
filehandle (which we call '"fgetattr"-like
semantics').
So far FUSE ignored the GETTATTR provided
filehandle and grabbed a file handle
heuristically. This caused confusion in the
caching layers, which has been tracked down
as one of the reasons of referred BUG.
As of the BUG, this is just a partial fix.
BUG: 1512691
Change-Id: I67eebbf5407ca725ed111fbda4181ead10d03f6d
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 69cea70b03537278f5b3e19c202baa272c890bc4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Mar 2 17:04:49 2018 -0500
build: address linkage issues
We have the following undefined symbol error from protocol/server.so:
glusterfs_mgmt_pmap_signout
glusterfs_autoscale_threads
See https://review.gluster.org/19225 (bz#1532238)
and https://review.gluster.org/19657 (bz#1550895)
(why are there two different bzs for the same bug?)
IMO this is a cleaner solution. I.e. moving the above two functions
to libgfrpc (.../rpc/rpc-lib/...)
I would also, for (foolish) consistency sake, like to see
glusterfs_mgmt_pmap_signin() moved from glusterfsd to libgfrpc as
well.
This works on f28/rawhide, with its new, more restrictive run-time
link semantics. The smoke and regression tests on earlier fedora and
centos will confirm that it works on those platforms too.
Change-Id: I9cfbd1cc15e7ebd9fc31b56ac791287fa2c584de
BUG: 1550895
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 0f7923b4a555a87a582c898aad99a19582f92eda
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Dec 6 16:55:33 2017 +0530
features/shard: Upon FSYNC from upper layers, wind fsync on all changed shards
Change-Id: Ib74354f57a18569762ad45a51f182822a2537421
BUG: 1468483
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit b76696f480aceb5aceee5ee1fd10d30ddcdc8eeb
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Feb 19 21:42:06 2018 +0530
quick-read: Fix coverity issue CHECKED_RETURN
Change-Id: I989e8fe28c86f67b7e54692c01ae3ed6e729aa16
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 2464b76e3104c8fdeafcf06ed17591f45095d65e
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Feb 19 21:54:36 2018 +0530
upcall: Fix coverity issues NEGATIVE_RETURNS
Change-Id: I7d2e733192127ff4ae00ba718562b031f45b72b9
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 917fb51962f9f108a50f6a35dcbe594def62b420
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Feb 19 21:47:45 2018 +0530
io-cache: Fix coverity issue NEGATIVE_RETURNS
Change-Id: I811225ad20e3bd9f05820212e6a843f05d96b246
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 608f837a27d877b3fced9b6156025ef9e88cbc06
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Mar 2 10:04:52 2018 -0500
build: fix typo, spelling mistake
transistional -> transitional
Change-Id: I1eb7e063288384458c305afea6d6c46a358701ff
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit cdafff6d290d576f07543caef803901081ef1a8b
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Feb 19 21:23:53 2018 +0530
libglusterfs: Fix coverity issue FORWARD_NULL
Change-Id: I1402046edb232ca9d23346db82a0cfd041c91e70
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 188a2696693990b49df0a6be66044ab6269a2c24
Author: Anoop C S <anoopcs@redhat.com>
Date: Fri Mar 2 10:32:17 2018 +0530
protocol/server: Insert dummy clnt-lk-version to avoid upgrade failure
This is required as we check for 'clnt-lk-version' in SETVOLUME callback
with older clients in place against newer servers. Change is similar to
what we have done via https://review.gluster.org/#/c/19560/.
Change-Id: If333c20cf9503f40687ec926c44c7e50222c05b5
BUG: 1544699
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit a4e6bc60842f60d7e75ea1f2f69e4178cab57672
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Mar 1 17:34:05 2018 +0530
libglusterfs: Fix volume_options_t struct
The volume_options_t struct was modified and a new member was introduced
in the middle of the struct. This caused GD2 to crash when it tried to
read the volume options. The new member has been moved to the end of the
struct to correct this.
And a note has been added to notify developers on how to modify this
struct, and the xlator_api_t struct.
Updates: gluster/glusterfs#302
Change-Id: I2e9899ec10516be29c7e9d574da53be8ec17a99e
Signed-off-by: Kaushal M <kaushal@redhat.com>
commit e980fd9b4e2cab5e300fa00321ddbeaf7f912661
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Feb 19 20:45:02 2018 +0530
md-cache: Fix coverity issue FORWARD_NULL
Change-Id: I6ace846c412d898c0bc024b5d2081b11a223372f
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 2ceb9596e415f8ebf7b9af4e551738fed9f22e91
Author: karthik-us <ksubrahm@redhat.com>
Date: Fri Feb 23 15:12:19 2018 +0530
cluster/afr: Make afr_fsync a transaction
Change-Id: I713401feb96393f668efb074f2d5b870d19e6fda
BUG: 1548361
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit cef7d509515c0afb9891b9df5378502aae188710
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Feb 15 16:12:12 2018 +0530
features/shard: Fix shard inode refcount when it's part of priv->lru_list.
For as long as a shard's inode is in priv->lru_list, it should have a non-zero
ref-count. This patch achieves it by taking a ref on the inode when it
is added to lru list. When it's time for the inode to be evicted
from the lru list, a corresponding unref is done.
Change-Id: I289ffb41e7be5df7489c989bc1bbf53377433c86
BUG: 1468483
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 0655977c13283b159d07722341e9d6536a5fe3c8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 28 17:58:31 2018 +0530
cluster/afr: Fix dict-leak in pre-op
At the time of pre-op, pre_op_xdata is populted with the xattrs we get from the
disk and at the time of post-op it gets over-written without unreffing the
previous value stored leading to a leak.
This is a regression we missed in
https://review.gluster.org/#/q/ba149bac92d169ae2256dbc75202dc9e5d06538e
BUG: 1550078
Change-Id: I0456f9ad6f77ce6248b747964a037193af3a3da7
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 7f131839f47aa5501feb889ce6cce9a2019e1950
Author: Varsha Rao <varao@redhat.com>
Date: Tue Feb 27 15:58:56 2018 +0530
perfomance/io-threads: Add option to disable client disconnect feature
> Add options to disable new features
> Commit ID: c071992e8d
> https://review.gluster.org/#/c/18291/
> By Michael Goulet <mgoulet@fb.com>
This patch is required to forward port io-threads namespace patch.
Updates: #401
Change-Id: Ice477fdf4b8934f9fac0b4a2f6c93db97429a586
Signed-off-by: Varsha Rao <varao@redhat.com>
commit d1e994bf439fbc579d2ec81b0ac88b52840efab7
Author: Varsha Rao <varao@redhat.com>
Date: Tue Feb 27 11:33:30 2018 +0530
tests/basic/namespace: Check if brick multiplex is enabled
This patch fixes the namespace test failure when brick multiplexing is enabled.
By changing the log file name, when brick multiplexing is enabled. As only one
log file generated for all bricks.
Change-Id: Ide941946e5e1b2676e7139e1b5bf6b93b93c0815
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 1ede4f3b5530e0aae6ffb7b2cfec6d13a4b7e9d5
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Feb 19 20:36:05 2018 +0530
io-cache: Fix coverity issue
Coverity issue : FORWARD_NULL
fd is assigned within a condition, but the fd is used even outside
the condition.
Change-Id: I6548d605d8a8acc6a25f1657f9fb75586d513042
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit e6f9b9c645221fdae9231aa9c676982be611f5ee
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Feb 12 08:45:25 2018 -0500
libglusterfs: move compat RPC/XDR #defines to eliminate warnings
Building with libtirpc (versus legacy glibc rpc) results in many
warnings about xdr macros that are redefined in libtirpc headers
because of the way compat.h and glusterfs.h are usually #included.
And these xdr macros in libglusterfs/src/compat.h - which were copied
from legacy glibc's rpc headers - are different than the same-name macros
in libtirpc. I haven't checked to see that any of the macros are
expanded (incorrectly) between the definition in compat.h and the
redefinition in tirpc/rpc/xdr.h; the risk seems pretty minimal. Regardless
it seems better, from a truth-and-beauty perspective to not have the
old, incorrect definitions in the first place.
Not to mention that any file that #includes compat.h and not glusterfs.h
does not need these xdr macro definitions at all. They're really only
needed when using really old glibc rpc, which would only be evident if
including glusterfs.h and/or glusterfs-fops.h. (Which by the way, nothing
currently #includes glusterfs-fops.h by itself. And maybe nothing ever
should?)
Change-Id: Ic11e4407d6ab7c498a8745a99379cbf4788a24e8
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 4540902c7fb316a22a4915b20a00e45cc26ee488
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Feb 2 15:43:47 2018 +0530
options: framework for options levels
Framework in order to classify options.
Updates gluster/glusterfs#302
Change-Id: I3dd6ae27bd0eb8e0065ffca75838c801e4f3ac91
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 12999e97a9dfe4c078788f4227e00159ff03e041
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Sat Feb 10 12:25:15 2018 +0530
glusterfsd: Memleak in glusterfsd process while brick mux is on
Problem: At the time of stopping the volume while brick multiplex is
enabled memory is not cleanup from all server side xlators.
Solution: To cleanup memory for all server side xlators call fini
in glusterfs_handle_terminate after send GF_EVENT_CLEANUP
notification to top xlator.
BUG: 1544090
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Note: Run all test-cases in separate build (https://review.gluster.org/19574)
with same patch after enable brick mux forcefully, all test cases are
passed.
Change-Id: Ia10dc7f2605aa50f2b90b3fe4eb380ba9299e2fc
commit 9548e5ef5cf43dae1084a8d09e532e8ae4767e52
Author: Varsha Rao <varao@redhat.com>
Date: Mon Feb 26 12:55:06 2018 +0530
performance/io-threads: nuke everything from a client when it disconnects
> io-threads: nuke everything from a client when it disconnects
> Commit ID: 4d8268d760
> https://review.gluster.org/#/c/18254/
> By Jeff Darcy <jdarcy@fb.com>
This patch is required to forward port io-threads namespace patch.
Updates: #401
Change-Id: I13d3a74862eea3d01e8dbc8736987c3dae6e8b2a
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 52011890e8f59e9180276b97d319d93585fef292
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Feb 26 15:58:13 2018 +0530
features/shard: Leverage block_num info in inode-ctx in read callback
... instead of adding this information in fd_ctx in call path and
retrieving it again in the callback.
Change-Id: Ibbddbbe85baadb7e24aacf5ec8a1250d493d7800
BUG: 1468483
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit c35065faee5541947053223d9aaffc8529141882
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Feb 26 15:22:58 2018 +0530
features/shard: Pass the correct block-num to store in inode ctx
Change-Id: Icf3a5d0598a081adb7d234a60bd15250a5ce1532
BUG: 1468483
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 7cf681cc7fe7056d5e67eafd2a6cb5a0d5f2a49d
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Feb 9 10:33:30 2018 +0530
write-behind: Make aggregate size configurable
Currently the aggregate size is by default 128K (page size).
From performance perspective small number of large writes is faster
than large number of small writes, especially in EC volumes. But identifying
the right aggregate size depends on multiple factors like the memcpy overhead,
network overhead etc. On local machine, combining 128k writes to 1M writes for
EC volumes yielded 30% improvement.
As a part of this patch, aggregate size is just made configurable and page_size
is modified accordingly.
Raghavendra Gowdappa had suggested that, while aggregating writes we should get
rid of memcpy of large write size, and instead add the pointer to existinf vector,
will be doing it as a part of another patch. Also, in EC volumes, the vectors are
merged into one vector, so even if we save memcopy in write_behind, EC would anyways
do memcopy for merging vectors into one vector.
Updates: #364
Change-Id: Ib67294b8577bea14dde1c84cd271012ecea99f09
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 811085e18b4b1a947d60e691988493114e1b4f9a
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Feb 26 15:14:18 2018 +0530
rpcsvc: scale rpcsvc_request_handler threads
Scale rpcsvc_request_handler threads to match the scaling of event
handler threads.
Please refer to https://bugzilla.redhat.com/show_bug.cgi?id=1467614#c51
for a discussion about why we need multi-threaded rpcsvc request
handlers.
Change-Id: Ib6838fb8b928e15602a3d36fd66b7ba08999430b
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 987a2f6a1469bce652da8b5b9c4d20661977f04f
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Feb 20 11:34:09 2018 +0530
md-cache: Modify options to be gd2 compatible
Change-Id: I79d51fee8ec5d2d237de7dd21c2d28c18cfd7ce8
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 96de9efeebdbb59bae91053b4452f48041a3e588
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Feb 20 11:38:44 2018 +0530
nl-cache: Change the options to be gd2 compatible
Change-Id: Ib9d233df41b85c845643e3e6eb2d680e01859a43
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 3ab1529003fe8a2c5c0c33ea28c38500057a5286
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Feb 8 13:44:38 2018 +0530
cluster/dht: store the 'reaction' on failures per lock
Currently its passed in dht_blocking_inode(entry)lk, which would be a
global value for all the locks passed in the argument. This would
be a limitation for cases where we want to ignore failures on only few
locks and fail for others.
Change-Id: I02cfbcaafb593ad8140c0e5af725c866b630fb6b
BUG: 1543279
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit fa85f19bcecec4e1eb8b49e2c92d1fef9e7465f4
Author: Varsha Rao <varao@redhat.com>
Date: Wed Feb 21 23:03:48 2018 +0530
performance/io-threads: Add threads to priority based stagnant queues
> performance/io-threads: Add watchdog to cover up a possible thread leak
> Commit ID: 8b6804f75c
> https://review.gluster.org/#/c/18239/
> By Shreyas Siravara <sshreyas@fb.com>
This patch is required to forward port io-threads namespace patch.
Updates: #401
Change-Id: Id057c34a2abb9fc6dfb4afcd5c7bbbfe5693bbb8
Signed-off-by: Varsha Rao <varao@redhat.com>
commit bac400f4bf2d0f88d022c852a9250c549fd8f01e
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Feb 19 09:44:29 2018 +0530
cluster/dht: Handle single dht child in dht_lookup
This patch limits itself to only handling the case
where no file (data or linkto) exists on the subvol.
Additional cases to be handled:
1. A linkto file was found on the only child subvol. This currently
calls dht_lookup_everywhere which eventually deletes it. It can be
deleted directly as it will not be pointing to a valid subvol.
2. Directory lookups - locking might be unnecessary in some cases.
Change-Id: I940ba34531f2aaee1d36fd9ca45ecfd46be662a4
BUG: 1546620
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit acd4338e30e3f41ee66901884d02b9c5186de4d1
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Feb 20 20:08:11 2018 +0530
cluster/dht: Ignore ENODATA from getxattr for posix acls
dht_migrate_file no longer prints an error if getxattr for
posix acls fails with ENODATA/ENOATTR.
Change-Id: Id9ecf6852cb5294c1c154b28d609889ea3420e1c
BUG: 1546954
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit a1aba67c11829f4fa36696aa2f786a14509a97f5
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Feb 12 03:11:04 2018 -0500
geo-rep: Remove lazy umount and use mount namespaces
Lazy umounting the master volume by worker causes
issues with rsync's usage of getcwd. Henc removing
the lazy umount and using private mount namespace
for the same. On the slave, the lazy umount is
retained as we can't use private namespace in non
root geo-rep setup.
Change-Id: I403375c02cb3cc7d257a5f72bbdb5118b4c8779a
BUG: 1546129
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 7cc760704f9b774c4efa82402ce94116c05a68c5
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Feb 20 20:31:39 2018 +0530
cluster/dht: Fixed a typo
Replaced "then" with "than"
Change-Id: I73090e8c1a639befd7c5458e8d63bd173248bc7d
BUG: 1547128
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit f255815324d39667dff7508e281e7eb774605692
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Feb 20 18:37:56 2018 +0530
glusterd: compare uuid instead of hostname while finding compatible brick
If the above is not done, bricks created with different IP/hostname will
not be compatible with brick multiplexing.
Change-Id: I508eb59b0632df4b48466cca411c7ec6cc6bd577
BUG: 1547068
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit dbfffe2d217e16433cc190ce226fd420a17b9202
Author: Varsha Rao <varao@redhat.com>
Date: Mon Feb 12 10:37:15 2018 +0530
xlators/features/namespace: Add namespace xlator and link into brick graph
The following release-3.8-fb branch patch is upstreamed:
> features/namespace: Add namespace xlator and link into brick graph
> Commit ID: dbd30776f26e
> https://review.gluster.org/#/c/18041/
> By Michael Goulet <mgoulet@fb.com>
Changes in this patch:
Removes extra config.h and namespace.h file in namespace.c
Adds default_getspec_cbk to libglusterfs.sym
Rename dict_for_each to dict_foreach_inline
Remove fd.h header file stack.h
Add test case for truncate, open and symlink
This patch is required to forward port io-threads namespace patch.
Updates: #401
Change-Id: Ib88c95b89eecee9b8957df8a4c8712c899c761d1
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 26ac4ac3bbc5e9ef80c21c22fb5ac4a4c1b68ad0
Author: Nigel Babu <nigelb@redhat.com>
Date: Wed Feb 21 08:57:54 2018 +0530
tests: Set timeout of 300 for self-heal.t
There are a few tests that take more time on regression nodes
Change-Id: If126d5ebd422cd6d99125db040e74f0d104af7bc
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit 010b37883e6c301496bce81187f598a554590e25
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Sun Feb 18 08:14:35 2018 +0530
Revert "glusterfsd: Memleak in glusterfsd process while brick mux is on"
There are still remain some code paths where cleanup is required while
brick mux is on.I will upload a new patch after resolve all code paths.
This reverts commit b313d97faa766443a7f8128b6e19f3d2f1b267dd.
BUG: 1544090
Change-Id: I26ef1d29061092bd9a409c8933d5488e968ed90e
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 21595abf2b405d3edf9ba52e69546c756291246c
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jan 31 16:38:34 2018 +0100
build: add --without-server option
With Gluster 4.0 we will not provide the server components for EL6 and
older. At one point Gluster 4.x will get GlusterD2, which requires
Golang tools in the distribution. EL6 does not contain these at the
moment.
With this change, it is possible to `./configure --without-server` which
prevents building glusterd and the xlators for the bricks. Building RPMs
can pass `--without server` and the glusterfs-server sub-package will
not be created.
Change-Id: I97f5ccf9f2c76e60d9af83915fc59fae57ad6d25
BUG: 1074947
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 223db677e0205d2e21bf68ec1953b62f552a7af1
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Jan 25 08:53:21 2018 +0530
socket: options update for GD2
All socket options update for GD2
Change-Id: I227c16965e92018a5ab5aacd9c2617fb2735268c
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 3d87650f98e2c8c339929b20340126ab9ddc1041
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Feb 11 06:54:35 2018 +0530
posix/afr: handle backward compatibility for rchecksum fop
Added a volume option 'fips-mode-rchecksum' tied to op version 4.
If not set, rchecksum fop will use MD5 instead of SHA256.
updates: #230
Change-Id: Id8ea1303777e6450852c0bc25503cda341a6aec2
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit a2600e88611781990a29cbbf4ad167044d3b3998
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jan 30 18:48:33 2018 +0530
metrics: set latency min value during xlator init
otherwise, the very first metrics will have all the min as 0.
also no need to print pending-fops if it is 0.
Updates #168
Change-Id: I233de6c92b1a73977bb468ba211ac6ec3c05298f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 9f76dcbc747f086f622a2def972bf1460d499204
Author: Prashanth Pai <ppai@redhat.com>
Date: Fri Feb 9 09:27:03 2018 +0530
Fetch backup volfile servers from glusterd2
Clients will request for a list of volfile servers from glusterd2 by
setting a (optional) flag in GETSPEC RPC call. glusterd2 will check for
the presence of this flag and accordingly return a list of glusterd2
servers in GETSPEC RPC reply. Currently, this list of servers returned
only contains servers which have bricks belonging to the volume.
See:
https://github.com/gluster/glusterd2/issues/382
https://github.com/gluster/glusterfs/issues/351
Updates #351
Change-Id: I0eee3d0bf25a87627e562380ef73063926a16b81
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit 58c1f3e4f77d0334c97eeca5f1a50ed78404d023
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Sat Feb 10 12:25:15 2018 +0530
glusterfsd: Memleak in glusterfsd process while brick mux is on
Problem: At the time of stopping the volume while brick multiplex is
enabled memory is not cleanup from all server side xlators.
Solution: To cleanup memory for all server side xlators call fini
in glusterfs_handle_terminate after send GF_EVENT_CLEANUP
notification to top xlator.
BUG: 1544090
Change-Id: Ifa1525e25b697371276158705026b421b4f81140
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 4b66154bad095a75a138733e597e493d2be7c59a
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jan 18 23:24:04 2018 +0530
tests: bring option of per test timeout
This uses 'timeout' command with 300 seconds default. Right now,
there is just 1 test which takes more than that in a properly
setup machine.
Ideally best case is set the default to something like 30 seconds,
and if a test is supposed to take more than that, owner should add
a timeout line to test knowingly. That way, it makes test writers
think about a time limit too.
Change-Id: I747005ce1f208aeb2ecbf899e8feea487ecd21a0
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 121124aa36c25bf5e0e045c5ff220ba812252075
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Feb 13 12:23:39 2018 +0530
protcol/client: Insert dummy clnt-lk-version to avoid upgrade failure
With https://review.gluster.org/#/c/12363/ being merged, we no longer
send client's lk-version to server side and the corresponding check on
server is also removed. But when clients are upgraded prior to servers,
the check for lk-version at server side fails and is reported back to
clients resulting in disconnection.
Since we don't have lock-recovery (lk-version and grace-timeout) logic
anymore in code base our best bet would be to add client's default
lk-version i.e, 1, into the dictionary just to make server side check
pass and continue with remaining SETVOLUME operations.
Change-Id: I441b67bd271d1e9ba9a7c08703e651c7a6bd945b
BUG: 1544699
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 5a82a2de63a0337f825dc731dc73c3d7677836f8
Author: Sheena Artrip <sheenobu@fb.com>
Date: Tue Feb 13 14:59:07 2018 -0800
rpc: Adds rpcbind6 programs to libgfrpc symbols
Building with --with-default-ipv6 causes shared
components of gluster calling the rpcbind6 functions
to fail. Adding the symbols in the list is all that is
necessary. Building without ipv6 keeps the same behavior.
No test cases as this is a build-specific fix.
Change-Id: I248d3291bf17326b07d152d9b79cdcfaf9068f0d
BUG: 1544961
Signed-off-by: Sheena Artrip <sheenobu@fb.com>
commit a887274e04eeaaee66428c5bc53829006b51eaf4
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Feb 13 08:06:24 2018 +0530
glusterd: fix tier-enabled flag op-version check
tier-enabled flag in volinfo structure was introduced in 3.10, however
while writing this value to the glusterd store was done with a wrong
op-version check which results into volume checksum failure during upgrades.
Change-Id: I4330d0c4594eee19cba42e2cdf49a63f106627d4
BUG: 1544600
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 25ad326576bad8b9b1d792a5b36441208b1cb5c9
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Feb 13 09:09:39 2018 +0530
libglusterfs/syncop: Add syncop_entrylk
Change-Id: Idd86b9f0fa144c2316ab6276e2def28b696ae18a
BUG: 1543279
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 51427a528961c421657c44b55981a74cfb592645
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Feb 12 07:48:20 2018 +0530
tests: fix spurious test failure
In bug-1482023-snpashot-issue-with-other-processes-accessing-mounted-path.t
check for peer count after starting glusterd instance on node 2
Change-Id: I3f92013719d94b6d92fb5db25efef1fb4b41d510
BUG: 1540607
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 73928f2bc3401203700591121fe5ef171181bd59
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Feb 13 06:33:53 2018 +0530
posix: fix the syncop_writev() arguments
Due to merging https://review.gluster.org/#/c/19131 before
https://review.gluster.org/18804 the build started failing.
Fixing with this patch.
Change-Id: Ia1eedf481a0f6d25f1357ee56d6bbb7a7e9d9793
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit dab072d98eda73620c2b7fa528080fed60e95423
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Jan 16 14:24:28 2018 +0530
Posix: Implement put fop
Updates #353
Change-Id: I1410222529ff42a810d62825bd6eebe8913fad1e
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 54f967f31a61252814b3ef6f3932bb2666411332
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Feb 1 11:20:37 2018 +0800
gfapi: return pre/post attributes at callback for glfs api
Updates: #389
Change-Id: Ic71632722effe4b8855d5de3e65688efd9afe1e3
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit de70c6e56886cb8b53df0eed29e71a59cac4e292
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Feb 1 10:13:07 2018 +0800
gfapi: return pre/post attributes from glfs_ftruncate
Updates: #389
Change-Id: I8faea0828921fb17f05f7321c3cb01747373f21e
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 5f17d713e26b9aaf9f58de0c244980b0a5d4abf3
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Thu Jan 18 15:51:18 2018 +0800
gfapi: return pre/post attributes from glfs_fsync/fdatasync
Updates: #389
Change-Id: I4153df72d5eeecefa7579170899db4c340128bea
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit b7d4ec7e98698b715acc6ea4630a8a11d5a969a5
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Mon Feb 12 15:13:49 2018 +0800
gfapi: return pre/post attributes from glfs_pread/pwrite
As nfs-ganesha, a wcc data contains pre/post attributes is return
in read/write rpc reply. nfs-ganesha get those attributes by
two getattr between the real read/write right now.
But, gluster has return pre/post attributes from glusterfsd,
those attributes are skipped in syncop/gfapi, if gfapi return them,
the upper user (nfs-ganesha) can use them directly without any
duplicate getattr.
Updates: #389
Change-Id: I7b643ae4241cfe2aeb17063de00192d81674024a
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 37ad9fa11d8033d451b6f3b918d0b1992c59749e
Author: Poornima G <pgurusid@redhat.com>
Date: Sat Nov 18 15:51:43 2017 +0530
io-threads: Implement put fop
Updates #353
Change-Id: I8a30b53a52618c6a6c740d2c67b19e5322ce4ddb
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit f05ec4ae07df40721c027760ebb8b039b62a3949
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Jan 4 10:35:29 2018 +0530
glusterd: optimization of test cases
To reduce the overall time taken by the every regression job for all glusterd test cases,
avoiding some duplicate tests by clubbing similar test cases into one.
real time taken for all regression jobs of glusterd without this patch is 1959 seconds,
with this patch it is 1059 seconds.
Look at the below document for your reference.
https://docs.google.com/document/d/1u8o4-wocrsuPDI8BwuBU6yi_x4xA_pf2qSrFY6WEQpo/edit?usp=sharing
Change-Id: Ib14c61ace97e62c3abce47230dd40598640fe9cb
BUG: 1530905
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit d6b326d08ae024c08f6ecbebd38d062c5ca5c2c3
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Feb 9 21:02:09 2018 +0530
glusterd/snapshot : fix the compare snap logic
In one of the case in commit cb0339f there's one particular case where
after removing the old snap it wasn't writing the new snap version and
this resulted into one of the test to fail spuriously.
Change-Id: I3e83435fb62d6bba3bbe227e40decc6ce37ea77b
BUG: 1540607
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit f3ae37ad8b03c984f51b0ea5d4721d803a42bdfc
Author: Nigel Babu <nigelb@redhat.com>
Date: Tue Feb 6 16:29:33 2018 +0530
maintainers: Switch up glusto ownership
Shwetha is stepping down from maintainer to peer and Nigel is stepping
up to be co-maintainer along with Jonathan.
Change-Id: If1b54936bf1be27673448dda5eff5695da1e8f5f
commit 7f7327efb3c2c1cbb80aad7cc80d9b2e03240106
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Feb 8 09:09:00 2018 +0530
glusterd: import volumes in separate synctask
With brick multiplexing, to attach a brick to an existing brick process
the prerequisite is to have the compatible brick to finish it's
initialization and portmap sign in and hence the thread might have to go
to a sleep and context switch the synctask to allow the brick process to
communicate with glusterd. In normal code path, this works fine as
glusterd_restart_bricks () is launched through a separate synctask.
In case there's a mismatch of the volume when glusterd restarts,
glusterd_import_friend_volume is invoked and then it tries to call
glusterd_start_bricks () from the main thread which eventually may land
into the similar situation. Now since this is not done through a
separate synctask, the 1st brick will never be able to get its turn to
finish all of its handshaking and as a consequence to it, all the bricks
will fail to get attached to it.
Solution : Execute import volume and glusterd restart bricks in separate
synctask. Importing snaps had to be also done through synctask as
there's a dependency of the parent volume need to be available for the
importing snap functionality to work.
Change-Id: I290b244d456afcc9b913ab30be4af040d340428c
BUG: 1540607
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit dcec4629d48066f3c7cb77f80c00638ef64a4802
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Thu Feb 1 14:53:48 2018 +0800
libgfapi: Remove need_lookup from readdirp
The inode_set_need_lookup is removed from fuse_readdirp_cbk at
http://lists.gluster.org/pipermail/gluster-devel/2017-August/053505.html
https://review.gluster.org/#/c/17985/
Remove the same logical from glfd_entry_refresh too.
Change-Id: Ic0d7b59d4d4ed8315bf4c5e87e8e1133bcf95401
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 28651f18a336b09947174cb415b091246eced7f3
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Feb 6 14:27:00 2018 +0530
build: Exempt env.rc during `make clean`
It is desirable to keep env.rc after `make clean` is executed so that
tests can be run following the next `make` without configuring one
more time.
Change-Id: I5f3ebaea878fd5124af8eae3cb7f8a619d16eac2
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit f3ff89e30bef869d6bad214fae0e7bebc7b18bb9
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Thu Feb 1 15:18:45 2018 +0800
libgfapi: skip nameless lookup if stat is NULL
Change-Id: If0ad17be2f7d7f88df25966aaf67af963ff4fc41
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 67a833bd9c1b366fb138dd3d655f41745206a392
Author: Varsha Rao <varao@redhat.com>
Date: Tue Feb 6 18:56:45 2018 +0530
performance/io-threads: expose io-thread queue depths
The following release-3.8-fb branch patch is upstreamed:
> io-stats: Expose io-thread queue depths
> Commit ID: 69509ee7d2
> https://review.gluster.org/#/c/18143/
> By Shreyas Siravara <sshreyas@fb.com>
Changes in this patch:
- Replace iot_pri_t with gf_fop_pri_t
- Replace IOT_PRI_{HI, LO, NORMAL, MAX, LEAST} with
GF_FOP_PRI_{HI, LO, NORMAL, MAX, LEAST}
- Use dict_unref() instead of dict_destroy()
This patch is required to forward port io-threads namespace patch.
Updates: #401
Change-Id: I1b47a63185a441a30fbc423ca1015df7b36c2518
Signed-off-by: Varsha Rao <varao@redhat.com>
commit fef1614aae022889e7ed3c611ceb1b11e6716375
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Feb 7 20:55:47 2018 +0530
tests/dht: Non-root can delete stale linkto files
Test to check that non-root users can delete stale
linkto files
Change-Id: Ic9bc76bc485cab839927af60cfce78a058eee2e4
BUG: 1542318
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit a7c4690277b08f1b491b88addc2390666700fb58
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Feb 6 15:20:16 2018 +0530
cluster/dht: Unlink linkto files as root
Non-privileged users cannot delete linkto
files. However the failure to unlink a stale linkto
causes DHT to fail the lookup with EIO and hence
prevent access to the file.
Change-Id: Id295362d41e52263790694602f36f1219f0646a2
BUG: 1542318
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 61c2fdea12a7a7146d0c416ad8eab62b0c37641f
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Feb 5 13:39:22 2018 +0530
cluster/dht: Cleanup on fallocate failure
It looks like fallocate leaves a non-empty
file behind in case of some failures. We now
truncate the file to 0 bytes on failure in
__dht_rebalance_create_dst_file.
Change-Id: Ia4ad7b94bb3624a301fcc87d9e36c4dc751edb59
BUG: 1541916
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 0b0c93578c2921788744ecc2c2a333bb64ee0a90
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Feb 4 10:04:29 2018 +0530
glusterd/store: handle the case of fsid being set to 0
Generally this would happen when a system gets upgraded from an
version which doesn't have fsid details, to a version with fsid
values. Without this change, after upgrade, people would see reduced
'df ' output, causing lot of confusions.
Debugging Credits: Nithya B <nbalacha@redhat.com>
Change-Id: Id718127ddfb69553b32770b25021290bd0e7c49a
BUG: 1517260
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit f17a9d77f73dc18d8af88dd034e9fb7bd2c0fac9
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Jan 25 14:12:45 2018 +0530
build: Remove unwanted autoconf messages for libtirpc
AC_MSG_RESULT is normally used when it is preceded by AC_MSG_CHECKING
during explicit checking of certain requirements. With PKG_CHECK_MODULES
being used for checking the presence of libtirpc itself generates the
following message:
checking for TIRPC... yes
Change-Id: I3f088a45ef2ced6f6fd9e1524e758c812deecb8f
BUG: 1536186
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit a3035a73ae5acabb8f4e73220604296687857eb1
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Thu Feb 1 16:06:32 2018 +0100
cluster/afr: remove unnecessary child_up initialization
The child_up array was initialized with all elements being -1 to
allow afr_notify() to differentiate down bricks from bricks that
haven't reported yet. With current implementation this is not needed
anymore and it was causing unexpected results when other parts of
the code considered that if child_up[i] != 0, it meant that it was up.
Change-Id: I2a9d712ee64c512f24bd5cd3a48dcb37e3139472
BUG: 1541038
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit 896dcf284160706e868464df8bc78855b58dbdae
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Feb 2 18:32:32 2018 +0530
cluster/dht: Fixed a leak in inode_ref
Introduced by commit d9f773ba719397c128
Change-Id: I3f3103a5a80daed7562ace72e5aa53b77e74fb94
BUG: 1541264
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 27bc4d1a9ec7ad3fd332f89aeaa9265d2c3f36c6
Author: Susant Palai <spalai@redhat.com>
Date: Thu Jan 18 13:06:12 2018 +0530
cluster/dht: avoid overwriting client writes during migration
For more details on this issue see
https://github.com/gluster/glusterfs/issues/308
Solution:
This is a restrictive solution where a file will not be migrated
if a client writes to it during the migration. This does not
check if the writes from the rebalance and the client actually
do overlap.
If dht_writev_cbk finds that the file is being migrated (PHASE1)
it will set an xattr on the destination file indicating the file
was updated by a non-rebalance client.
Rebalance checks if any other client has written to the dst file
and aborts the file migration if it finds the xattr.
updates gluster/glusterfs#308
Change-Id: I73aec28bc9dbb8da57c7425ec88c6b6af0fbc9dd
Signed-off-by: Susant Palai <spalai@redhat.com>
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 9b6866d142d57c6809a9663b63c66256f970df9a
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Feb 2 12:35:16 2018 +0530
cluster/dht: Fixed leak in dht_populate_inode_for_dentry
Fixed an issue in dht_populate_inode_for_dentry where a layout is
set in the inode without checking if it is already set. This overwrites
the value each time without freeing the already existing layout.
Change-Id: I651bf539a0b82b4ddc4c355890c16a8e91f5f1fd
BUG: 1541264
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 39f3857d8f16bda295ea087d9cf0b9b92acbfb86
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Feb 1 22:56:09 2018 +0530
sdfs: crash fixes
* from the patch which got tested in experimental branch, there
was a code cleanup involved, which missed setting of a local
variable, which led to crash immediately after enabling the
feature.
* added a sanity test case to validate all the fops of sdfs.
Updates: #397
Change-Id: I7e0bebfc195c344620577cb16c1afc5f4e7d2d92
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 648cccbe79cb8aaea79266870640346c475e0bfc
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Jan 28 13:50:47 2018 +0530
afr: don't treat all cases all bricks being blamed as split-brain
Problem:
We currently don't have a roll-back/undoing of post-ops if quorum is not
met. Though the FOP is still unwound with failure, the xattrs remain on
the disk. Due to these partial post-ops and partial heals (healing only when
2 bricks are up), we can end up in split-brain purely from the afr
xattrs point of view i.e each brick is blamed by atleast one of the
others. These scenarios are hit when there is frequent
connect/disconnect of the client/shd to the bricks while I/O or heal
are in progress.
Fix:
Instead of undoing the post-op, pick a source based on the xattr values.
If 2 bricks blame one, the blamed one must be treated as sink.
If there is no majority, all are sources. Once we pick a source,
self-heal will then do the heal instead of erroring out due to
split-brain.
Change-Id: I3d0224b883eb0945785ade0e9697a1c828aec0ae
BUG: 1539358
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 5e9385b6091660f896aa05fcdaf263f640f14bfa
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jan 18 10:31:38 2018 +0530
protocol: utilize the version 4 xdr
updates #384
Change-Id: Id80bf470988dbecc69779de9eb64088559cb1f6a
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 87bb2b7ad4e58f68c16d9d2b6900a9bc29b13c41
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jan 31 22:10:46 2018 +0530
cluster/ec: Do lock conflict check correctly for wait-list
Problem:
ec_link_has_lock_conflict() is traversing over only owner_list
but the function is also getting called with wait_list.
Fix:
Modify ec_link_has_lock_conflict() to traverse lists correctly.
Updated the callers to reflect the changes.
BUG: 1540669
Change-Id: Ibd7ea10f4498e7c2761f9a6faac6d5cb7d750c91
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit b835653f56fcd0d75be8a8054c867d8d9f82bda6
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Jan 11 16:14:41 2018 +0530
protocol/auth: options update for GD2
addr and login options update for GD2
Change-Id: I3bb9a2ad368326036c2e7f6bd48b624bdd053051
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 86e0a76e658164b095d01abc0fcbfa600dd68a8b
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Sat Jan 27 00:58:25 2018 +0530
bitrot : improved cli report after bitrot operatoin
Improved cli report post bitrot opertaion as previously it was
showing output "volume bitrot: success" for all the sucessfull
bitrot operations (enable, disable or scrub options).
Change-Id: I0857e99f3956221a51cfd1b29a90e1038b90570f
BUG: 1539166
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 434e64f349809f4b96ffa15a70a14a7b7bfa7b71
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Jan 30 20:59:23 2018 +0530
afr: capture the correct errno in post-op quorum check
If the post-op phase of txn did not meet quorm checks, use that errno to
unwind the FOP rather than blindly setting ENOTCONN.
Change-Id: I0cb0c8771ec75a45f9a25ad4cd8601103deddf0c
BUG: 1506140
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit a697e5d6ae6a09ce9ce266d2c3f86bf6376ec255
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Mon Jan 29 16:07:50 2018 +0800
statedump: sanity check of mem_acct and rec for xlator
With memory accounting is disabled, glusterfs crash when doing statedump at,
0 0x00007fe24cff543a in gf_proc_dump_xlator_mem_info_only_in_use (xl=0x7fe23e44dc00) at statedump.c:269
1 0x00007fe24cff6310 in gf_proc_dump_oldgraph_xlator_info (top=0x7fe23e44dc00) at statedump.c:530
2 0x00007fe24cff7114 in gf_proc_dump_info (signum=10, ctx=0x7fe24ac0e000) at statedump.c:845
3 0x00007fe24d4d4bab in glusterfs_sigwaiter (arg=0x7ffc6c080750) at glusterfsd.c:2109
4 0x00007fe24bbd5dc5 in start_thread () from /lib64/libpthread.so.0
5 0x00007fe24b51a73d in clone () from /lib64/libc.so.6
(gdb) p xl->mem_acct
$1 = (struct mem_acct *) 0x0
(gdb) p xl->mem_acct->rec
$2 = 0x10
Change-Id: I10858170431311833ae01224d51c66caaad5e9a3
BUG: 1539603
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 788cba251da049148f4dbef9b2c97644a350ccce
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Jan 16 14:14:39 2018 +0530
protocol: Implement put fop
Updates #353
Change-Id: I755b9208690be76935d763688fa414521eba3a40
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit bdb9fc3dd2763ee6f85d00a404800e5dda7f63ad
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jan 29 10:23:52 2018 +0530
glusterd: optimize glusterd import volumes code path
In case there's a version mismatch detected for one of the volumes
glusterd was ending up with updating all the volumes which is a
overkill.
Change-Id: I6df792db391ce3a1697cfa9260f7dbc3f59aa62d
BUG: 1539510
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 6c1de17a702969463c7dbeee6f09e3fb5ba97e2e
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Jan 30 16:47:34 2018 +0100
tests: fix tests/bugs/fuse/bug-858215.t
Change-Id: Ifbf5e628ccb9a0ecb285f5884a41e70d935316bd
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 4f3ac29caaa3bc6689ad08b0b3375b5f7db07698
Author: Milan Zink <mzink@redhat.com>
Date: Wed Jan 10 13:04:42 2018 +0100
extras/hooks: Fix S10selinux-label-brick.sh hook script
* script was failng due to syntax error
* shellcheck issues fixed
* improved performance: semanage & restorecon is being run on unique path
Change-Id: I58b357d9fd37586004a2a518f7a5d1c5c9ddd7e3
BUG: 1533342
Signed-off-by: Milan Zink <zeten30@gmail.com>
commit 08fc00faadb584dafb3fb21ff891cc65c31939c6
Author: ShyamsundarR <srangana@redhat.com>
Date: Tue Jan 30 14:39:57 2018 -0500
glusterd: Update op-version for master
Updated the op-version on master to the next release
op-version, for any future options appearing on master.
Change-Id: I2ef6f8874c638ade1d97477bdd8ffa1bd1a9f952
BUG: 1540338
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit d2cf19bd7781be5a0253197ab624893ba1bbc18c
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jan 22 11:08:48 2018 +0100
doc: describe how to contribute when a GitHub Pull-Request is made
Every now and then new contributors create a GitHub Pull-Request. We do
not use those for accepting changes, and almost never check for new PRs.
Redirecting contributors can be done automatically, just like we do when
users create a GitHub Issue.
Note that the bulk of the description comes from gluster-block. Just
like most Gerrit maintained projects, it uses 'git review' and not a
custom ./rfc.sh. New contributors that are familiar with Gerrit, will
prefer the 'git review' approach over ./rfc.sh (which we want to
deprecate or at least have it use 'git review' too).
Change-Id: Ide36cbd80fdaaf238ea35ae5932a0cd21fc41f36
Updates: #381
URL: https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 8d73e3207db0769739f31e39d11d5c56cf28bbe8
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Jan 30 12:51:36 2018 +0530
build: Add new glusterfs4 source files to gitignore
Change-Id: I4e6439d0f1ab55528c0f7e23c437c7b62628b8e4
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit aa85c27b8ea62d05322367af1c8a6186f8436675
Author: Milan Zink <mzink@redhat.com>
Date: Thu Jan 11 11:43:40 2018 +0100
Fix disabled-quota-root-xattr-heal.sh hook script
Fixing all shellchek warnings and POSIX incomapatibilities
Change-Id: I35772bfcf7344c6ed9bd2a7db300c8f58bd3b243
BUG: 1500649
Signed-off-by: Milan Zink <zeten30@gmail.com>
commit cf57dc2012b3d1980197b2cd23640eab1c3f1e98
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Jan 25 10:03:09 2018 +0530
rpc: Showing some unusual timer error logs during brick stop
Solution: Update msg condition in gf_timer_call_after function
to avoid the message
BUG: 1538427
Change-Id: I849e8e052a8259cf977fd5e7ff3aeba52f9b5f27
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit fcbf3b509b7e466cabbf4d576d4b2fde43326820
Author: Milind Changire <mchangir@redhat.com>
Date: Fri Jan 26 16:07:59 2018 +0530
tests: merge stdout and stderr output
Add -m argument to 'prove' command-line.
Fix xxhsum.c debugging output to keep 'prove' happy.
Change-Id: I03485d5f5e43ae4ce454a275ec98bc18384ed00c
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 5833ac57bdb6f0f08a8725d1a70b7faefd48b033
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Jan 26 15:34:43 2018 +0530
quiesce, gfproxy: Implement failover across multiple gfproxy nodes
Updates: #242
Change-Id: I767e574a26e922760a7130bd209c178d74e8cf69
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 25bfc99db6ff9f37a901067b39a1620a6ff03b42
Author: Jeff Darcy <jdarcy@fb.com>
Date: Thu Jan 25 06:52:32 2018 -0800
core: add some examples of site.h usage
Change-Id: I6ce574a593eda8f3a6b2fc8969b5edf7c250b61c
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
commit 5622fa092e3c28d8e4c57463fa8039ab6a2b59d2
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Oct 15 15:04:34 2015 +0530
protocol: Remove lock recovery logic from client and server
Change-Id: I27f5e1e34fe3eac96c7dd88e90753fb5d3d14550
BUG: 1272030
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 3d90c8c18341b9adc0e702ddc0f5f7ad76237c83
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Jan 29 12:42:51 2018 +0530
geo-rep: Remove unused working directory check in gsyncd
To append the default config file path, gsyncd calls gluster
command to get the workdir path and constructs config file path.
This is not required now since the Config management in Geo-replication
is changed with patch 18257(Issue #73)
BUG: 1539545
Change-Id: Ia7eb39e36ed59ece4de65ea7ec71a0f615e338bb
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit cf38bbe07f625f39b796d49b0654e8535372e471
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Jan 23 15:56:45 2018 +0530
geo-rep: Detailed JSON output for config
JSON output of `config-get` command now returns in the following
format
{
"name": CONFIG_NAME,
"value": CONFIG_VALUE,
"default_value": DEFAULT_VALUE, # Only if modified == true
"configurable": true|false,
"modified": true|false
}
Change-Id: I6193de48cd33655df7ecef5a0d83d7cb147089cf
Fixes: #361
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit e620617b7dc6c76a4532142fbe8e6d0dc0339908
Author: Jan Engelhardt <jengelh@inai.de>
Date: Thu Dec 14 19:43:43 2017 +0100
build: restore ability to control verbosity settings
`make V=1` is broken — no commands are printed whatsoever. At the
same time, `make V=0` *also* is broken in that no summary lines
("CC foo.o") are printed, either. Kill the annoying hardcoded
--quiet in configure.ac, since it seems to override everything that
automake offers.
Change-Id: I377c0e0469619a33586afb4a93dde6d241e7bc21
Fixes: #381
BUG: 1539023
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
[ndevos: silence rpc/xdr/gen rpgcen]
commit 4620f47c2abcd3ff070b8fa85293ba2ef5c93d7a
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Jan 10 15:01:59 2018 +0530
gfapi : New APIs have been added to use lease feature in gluster
Following APIs glfs_h_lease(), glfs_lease() added, so that gfapi applications
can set and get lease which enables more efficient client side caching.
Updates: #350
Change-Id: Iede85be9af1d4df969b890d0937ed0afa4ca6596
Signed-off-by: Poornima G <pgurusid@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit 159857c2dd3c99776bfca023dba521abaa43170e
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jan 23 14:06:10 2018 +0530
debug/io-stats: io-stats options for GD2
Updates #302
Change-Id: I8e7ff391cec88ea76f63ffe05b7404bdb31eaf8e
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit fa3bce046cf43c6eaa1a0e6e3bee87bb6489fe99
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jan 23 12:12:14 2018 +0530
features/shard: shard options for GD2.
Updates #302
Change-Id: Ife21440ffcf5805ce5858360dc94a456ead891e5
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 7ab99fcf051d78ff646e97c5ae84f43dcd55fc41
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jan 25 10:39:19 2018 -0500
build: use libtirpc by default, even if ipv6 is not the default
Another error snuck in with Change-Id I86f847dfd, or more
accurately I think, with Change-Id: Ic47065e9c2...
All libs, not just libgfrpc, need to be linked with libtirpc,
especially on systems that still have xdr functions in (g)libc
where you will get a mixture of calls to libtirpc functions
and glibc functions, with catastrophic results.
BUG: 1536186
Change-Id: I97dc39c7844f44c36fe210aa813480c219e1e415
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 33de6150be0b9c6908c306e26b121100e97830e3
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Jan 24 12:56:14 2018 -0500
packaging: python-ctypes only in RHEL <= 7
And we don't need multiple BuildRequires: python-ctypes for sub-packages
when it's (already) set for the base package.
Change-Id: I71a2d750f338d360d5f716b1f0c4814e4e617b04
BUG: 1538258
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 2d8228fd5705b5ed3f2a80074dfb7334ecabee07
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jan 23 08:23:11 2018 +0530
glusterd: add profile_enabled flag in get-state
Change-Id: I09f348ed7ae6cd481f8c4d8b4f65f2f2f6aad84e
BUG: 1537364
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 0c1578541ebe2776dbb241319af3768710bae3f4
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jan 22 09:49:34 2018 +0530
glusterd: process pmap sign in only when port is marked as free
Because of some crazy race in volume start code path because of friend
handshaking with volumes with quorum enabled we might end up into a situation
where glusterd would start a brick and get a disconnect and then immediately try
to start the same brick instance based on another friend update request. And
then if for the very first brick even if the process doesn't come up at the end
sign in event gets sent and we end up having two duplicate portmap entries for
the same brick. Since in brick start we mark the previous port as free, its
better to consider a sign in request as no op if the corresponding port type is
marked as free.
Change-Id: I995c348c7b6988956d24b06bf3f09ab64280fc32
BUG: 1537362
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 6c37b6cb87a7a1be0bbdf44ea17023412154adc2
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jan 24 11:41:39 2018 +0100
build: use libtirpc by default, even if ipv6 is not the default
An error sneaked in with Change-Id I86f847dfd. The check for requiring
libtirpc-devel should be done regardless of the ipv6-default. Even if
IPv6 is not the default, libtirpc-devel should be used unless it is
explicitly requested by a --without option.
libtirpc can not be used on EL6 and EL7 yet. The EL7 version does not
provide xdr_sizeof(), in addition to that, EL6 does not have
xdr_uint32_t() and xdr_uint64_t().
BUG: 1536186
Change-Id: I4a8292de2eddad16137df5998334133fc1e11261
Fixes: 0c57232ae07f48bd6483bfe88a182f832377ef52
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit f58f06aa772bf39bcebdaccf88aa9df8e8f3568b
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Jan 23 15:03:33 2018 +0530
cluster/dht: Skip '..' for the volume root dir
dht_populate_inode_for_dentry tries to update the layout
for the '..' entry when listing the root of the volume.
This entry does not correspond to an entry in the volume
and therefore does not have a gfid or a layout on disk,
causing layout processing to fail.
Change-Id: I2b7470e1c5e20d87b5545160697f24d041045140
BUG: 1537457
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 5e32811f96d652125383d4067459b4f23103fcf9
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jan 18 15:24:00 2018 -0500
build: glibc has removed rpc headers and rpcgen in Fedora28, use libtirpc
Other Linux distributions are doing the same; some others have already
done so.
Switch to libtirpc(-devel) and unbundled rpcgen packages. For now
rpcgen is still provided by the glibc-rpcgen RPM, but rpcsvc-proto's
rpcgen subpackage is available now but will not be used until
glibc-rpcgen is retired. (note, rpcsvc-proto's rpcgen is just named
rpcgen-...rpm. I.e. not rpcsvc-proto-rpcgen.) Right now either one
will satisfy the BuildRequires: rpcgen.
Also, when a .spec file has
BuildRequires: foo-devel
it is not necessary to also have:
BuildRequires: foo
or even:
BuildRequires: foo foo-devel
The foo-devel package has a dependency on foo, which will install foo
automatically. It's usually also not necessary to have a corresponding
Requires: foo
as the rpmbuild process will also automatically determine the
install-time dependencies.
And other minor glusterfs.spec.in cleanup of ipv6-default, including
sorting the argument definitions because the comment says "keep them
sorted" (Though nobody appears to have ever sorted them in the first
place.)
Change-Id: I86f847dfda0fef83e22c6e8b761342d652a2d9ba
BUG: 1536186
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 30bb680d29e65a7aedf4d3e2aaebadf3bc65de06
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Mon Jan 22 14:38:17 2018 +0530
dentry fop serializer: added new server side xlator for dentry fop serialization
Problems addressed by this xlator :
[1]. To prevent race between parallel mkdir,mkdir and lookup etc.
Fops like mkdir/create, lookup, rename, unlink, link that happen on a
particular dentry must be serialized to ensure atomicity.
Another possible case can be a fresh lookup to find existance of a path
whose gfid is not set yet. Further, storage/posix employs a ctime based
heuristic 'is_fresh_file' (interval time is less than 1 second of current
time) to check fresh-ness of file. With serialization of these two fops
(lookup & mkdir), we eliminate the race altogether.
[2]. Staleness of dentries
This causes exponential increase in traversal time for any inode in the
subtree of the directory pointed by stale dentry.
Cause : Stale dentry is created because of following two operations:
a. dentry creation due to inode_link, done during operations like
lookup, mkdir, create, mknod, symlink, create and
b. dentry unlinking due to various operations like rmdir, rename,
unlink.
The reason is __inode_link uses __is_dentry_cyclic, which explores
all possible path to avoid cyclic link formation during inode
linkage. __is_dentry_cyclic explores stale-dentry(ies) and its
all ancestors which is increases traversing time exponentially.
Implementation : To acheive this all fops on dentry must take entry locks
before they proceed, once they have acquired locks, they perform the fop
and then release the lock.
Some documentation from email conversation:
[1] http://www.gluster.org/pipermail/gluster-devel/2015-December/047314.html
[2] http://www.gluster.org/pipermail/gluster-devel/2015-August/046428.html
With this patch, the feature is optional, enable it by running:
`gluster volume set $volname features.sdfs enable`
Also the feature is tested for a month without issues in the
experiemental branch for all the regression.
Change-Id: I6e80ba3cabfa6facd5dda63bd482b9bf18b6b79b
Fixes: #397
BUG: 1304962
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit d28ec06f979165584b9d660ac567026a67e2e0a3
Author: Nigel Babu <nigelb@redhat.com>
Date: Tue Jan 23 20:46:25 2018 +0530
tests: Disable geo-rep tests
These tests are prone to issues at the moment that need further
debugging and fixing.
BUG: 1537602
Change-Id: Ic59ca620925c6f43948b8a751eaddb571b791969
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit df4a76a8f3612d1598a9fbb5a2010f83546d5b4a
Author: Nigel Babu <nigelb@redhat.com>
Date: Mon Jan 22 08:36:36 2018 +0530
libglusterfs: Reset errno before call
This was causing Gluster to return a failure when testing on Centos7.
BUG: 1536913
Change-Id: Idb90baef05058123a7f69e94a51dd79abd371815
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit 6344dfd1510a3119eff612e1ed5c8b3f017ebde8
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jan 9 11:37:59 2018 +0530
features/error-gen: update volume options for GD2
Updates #302
Change-Id: I8d04bb4f46b1e53a8d176a75da2382fdbf0cfc6f
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 0bdd9f4b42b3ff73b3b4bdf6d1f24d9adbc085b2
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Nov 30 12:52:30 2017 +0530
geo-rep: Support for using Volinfo from Conf file
Once Geo-replication is started, it runs Gluster commands to get Volume
info from Master and Slave. With this patch, Georep can get Volume info
from Conf file if `--use-gconf-volinfo` argument is specified to monitor
Create a config(Or add to the config if exists) with following fields
[vars]
master-bricks=NODEID:HOSTNAME:PATH,..
slave-bricks=NODEID:HOSTNAME,..
master-volume-id=
slave-volume-id=
master-replica-count=
master-disperse_count=
Note: Exising Geo-replication is not affected since this is activated
only when `--use-gconf-volinfo` is passed while spawning `gsyncd
monitor`
Tiering support is not yet added since Tiering + Glusterd2 is still
under discussion.
Fixes: #396
Change-Id: I281baccbad03686c00f6488a8511dd6db0edc57a
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit fdec7e25ec0df0202636d966305a8d92d4e3271f
Author: Csaba Henk <csaba@redhat.com>
Date: Sat Jan 6 02:53:15 2018 +0100
performance/read-ahead: volume option fixes for GD2
Updates #302
Change-Id: I842ab746502bc4ff3b312ee19f397a6177edc6f7
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 91b3cc7fbe1ecbcf06f49c29746e2717014f6b9f
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Jan 19 03:54:02 2018 -0500
protocol/server: Fix "auth-path" in options table
Options set will crash the brick with glusterd2.
glusterd used to set "auth-path" during volfile
generation. With glusterd2, it should come from
options table.
Updates: #302
Change-Id: Ie41a17779c185b87ace7e0bce0d0ba594b415a75
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit a8994917d02399a43bb4dedd6240d43e4f0d1c8a
Author: Csaba Henk <csaba@redhat.com>
Date: Sat Jan 6 02:53:45 2018 +0100
performance/write-behind: volume option fixes for GD2
Updates #302
Change-Id: I2ade3dc4aef4da619c5b64058872594f0f1e004f
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 38bbf50d534fc7ccb91674078a3f582fb3dcee9b
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Jan 19 14:35:18 2016 +0530
libgfapi: Add new api for supporting mandatory-locks
The current API for byte-range locks [glfs_posix_lock()] doesn't
allow applications to specify whether it is advisory or mandatory
type locks. This particular change is to introduce an extended
byte-range lock API with an additional argument for including
the byte-range lock mode to be one among advisory(default) or
mandatory. Patch also includes a gfapi test case which make use
of this new api to acquire mandatory locks.
Ref: https://github.com/gluster/glusterfs-specs/blob/master/done/GlusterFS%203.8/Mandatory%20Locks.md
Change-Id: Ia09042c755d891895d96da857321abc4ce03e20c
Updates #393
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 6ab555c98285ca40e5d38b9543c7ad9ff792ddb1
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Fri Sep 1 15:04:09 2017 +0530
cluster/ec : EC options for GD2
Updates #302
Change-Id: I31b4648f7b1a394fceece5cba8120c579c66edd9
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit df5e9013525f12f46723e227a71c395570b0fe74
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jan 18 22:59:00 2018 -0500
geo-rep: Improve geo-rep pre-validation logs
Geo-rep runs gverify.sh which does pre-validation.
As part of it, master and slave volume is mounted
to verify the size. If for some reason, the mount
fails, the error message does not point out the
mount log file location. Also both master and
slave mount logs are same.
Patch does following improvements.
1. Master and slave mount logs are separated and
error message points the log file to be looked for.
2. The log location is changed to /var/log/glusterfs/geo-replication
instead of /var/log/glusterfs/geo-replication-slaves
3. The log file name is changed to "gverify-mastermnt.log" and
"gverify-slavemnt.log" for master and slave mount respectively
Fixes: #395
Change-Id: Ia644ec0afebbdaae92e01adf03c635e5f8866a02
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit e41c6dd5ff8d0e9f0bf2b507f03614ad28b371d8
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Jan 9 17:26:44 2018 +0530
md-cache: Implement dynamic configuration of xattr list for caching
Currently, the list of xattrs that md-cache can cache is hard coded
in the md-cache.c file, this necessiates code change and rebuild
everytime a new xattr needs to be added to md-cache xattr cache
list.
With this patch, the user will be able to configure a comma
seperated list of xattrs to be cached by md-cache
Updates #297
Change-Id: Ie35ed607d17182d53f6bb6e6c6563ac52bc3132e
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 46860ac66d32c18f9b87be4c90c1bcd80e255367
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Dec 22 13:12:42 2017 +0530
protocol: make on-wire-change of protocol using new XDR definition.
With this patchset, some major things are changed in XDR, mainly:
* Naming: Instead of gfs3/gfs4 settle for gfx_ for xdr structures
* add iattx as a separate structure, and add conversion methods
* the *_rsp structure is now changed, and is also reduced in number
(ie, no need for different strucutes if it is similar to other response).
* use proper XDR methods for sending dict on wire.
Also, with the change of xdr structure, there are changes needed
outside of xlator protocol layer to handle these properly. Mainly
because the abstraction was broken to support 0-copy RDMA with payload
for write and read FOP. This made transport layer know about the xdr
payload, hence with the change of xdr payload structure, transport layer
needed to know about the change.
Updates #384
Change-Id: I1448fbe9deab0a1b06cb8351f2f37488cefe461f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 48868b811a5fe7fdb48c611437f58a4132126424
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Jan 10 14:54:30 2018 +0530
gfapi : added glfs_setfsleaseid() for setting lease id
A new function glfs_setfsleaseid() added in gfapi. Currently lock owner
is saved in the thread context. Similarly the leaseid attribute can be
saved using glfs_setfsleaseid().
Updates: #350
Change-Id: I55966cca01d0f2649c32b87bd255568c3ffd1262
Signed-off-by: Poornima G <pgurusid@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit dcd3f891945c158598ab815b36896eec6d8f7223
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jan 18 14:21:57 2018 +0530
afr: add quorum checks in post-op
afr relies on pending changelog xattrs to identify source and sinks and the
setting of these xattrs happen in post-op. So if post-op fails, we need to
unwind the write txn with a failure.
Change-Id: I0f019ac03890108324ee7672883d774918b20be1
BUG: 1506140
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 76d4fc9cb0da1fc066cf682c9779007e2487e7a1
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Jan 4 19:39:05 2018 +0530
readdir-ahead: Cleanup the xattr request code
Updates #297
Change-Id: Ia0c697583751290a455da3cd1894e0c5685d1bd8
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit d3dc08695916b89a659c0fa0c646eaf2fe71dc83
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Jan 9 10:32:16 2018 +0530
upcall: Allow md-cache to specify invalidations on xattr with wildcard
Currently, md-cache sends a list of xattrs, it is inttrested in recieving
invalidations for. But, it cannot specify any wildcard in the xattr names
Eg: user.* - invalidate on updating any xattr with user. prefix.
This patch, enable upcall to honor wildcard in the xattr key names
Updates: #297
Change-Id: I98caf0ed72f11ef10770bf2067d4428880e0a03a
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 67899f9cc1700aa2e4861b07054cd06655f95fc9
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jan 18 05:43:56 2018 +0000
geo-rep: Validate availability of gluster binary on slave
1. Adds validation to check if gluster binary is available on slave
2. Add a simple geo-rep setup test case to verify whether setup is fine.
It's named in such a way that it runs first.
BUG: 1532591
Change-Id: Ie777e55ae13db8fa97d4e32464ad82269ee5fd07
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit ad5f709eb1c2480cd4930798444cf136db3e2436
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 2 21:17:09 2018 +0530
features/locks: volume option fixes for GD2
Updates #302
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Change-Id: I1667fc32b7a31562b289fcab878d94be202407e4
commit 4879cb28ffff763d63c81f4fcc4dc329cd6f508b
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Jan 4 19:38:05 2018 +0530
posix: In getxattr, honor the wildcard '*'
Currently, the posix_xattr_fill performas a sys_getxattr
on all the keys requested, there are requirements where
the keys could contain a wildcard, in which case sys_getxattr
would return ENODATA, eg: if the xattr requested is user.*
all the xattrs with prefix user. should be returned, with their
values.
This patch, changes posix_xattr_fill, to honor wildcard in the keys
requested.
Updates #297
Change-Id: I3d52da2957ac386fca3c156e26ff4cdf0b2c79a9
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 286e8774539b9d41035316dfc4df4bb07dae2f5c
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Jan 17 17:30:06 2018 +0530
cluster/afr: Adding option to take full file lock
Problem:
In replica 3 volumes there is a possibilities of ending up in split
brain scenario, when multiple clients writing data on the same file
at non overlapping regions in parallel.
Scenario:
- Initially all the copies are good and all the clients gets the value
of data readables as all good.
- Client C0 performs write W1 which fails on brick B0 and succeeds on
other two bricks.
- C1 performs write W2 which fails on B1 and succeeds on other two bricks.
- C2 performs write W3 which fails on B2 and succeeds on other two bricks.
- All the 3 writes above happen in parallel and fall on different ranges
so afr takes granular locks and all the writes are performed in parallel.
Since each client had data-readables as good, it does not see
file going into split-brain in the in_flight_split_brain check, hence
performs the post-op marking the pending xattrs. Now all the bricks
are being blamed by each other, ending up in split-brain.
Fix:
Have an option to take either full lock or range lock on files while
doing data transactions, to prevent the possibility of ending up in
split brains. With this change, by default the files will take full
lock while doing IO. If you want to make use of the old range lock
change the value of "cluster.full-lock" to "no".
Change-Id: I7893fa33005328ed63daa2f7c35eeed7c5218962
BUG: 1535438
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit fabe05ee1bf9a689d2a902c2a1d938a9d69351b1
Author: krad <krad@fb.com>
Date: Tue Dec 5 13:53:27 2017 -0800
distributed-tests: Framework for running tests on a worker cluster
Summary: This framework helps distribute running of unit tests on a cluster of machines.
Test Plan: Run tests on fb cluster
Reviewers: sshreyas, jdarcy
Change-Id: If309f504d9aa959cc8b01c85bff3b5503a890ff1
updates #374
Signed-off-by: krad <krad@fb.com>
commit 7727d0035468708d0a960b5a90e28442130c8adb
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Jan 17 18:03:11 2018 +0530
selinux-xlator : validate dict before calling dict_rename_key()
Change-Id: I71da3b64e5e8c82e8842e119b2b05da3e2ace550
BUG: 1535772
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit b6dbcea3e6770624aaeb88426f91affb72ce6dfb
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Aug 7 11:24:46 2017 +0530
md-cache: Serve nameless lookup from cache
Updates #232
Change-Id: I97e92312a53a50c2d1660bf8d657201fc05a76eb
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit ffb0d8d128ed52b198ea4d0234976a8debbf74cc
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jan 8 09:55:37 2018 +0530
fix features/leases: volume option fixes for GD2
Updates #302
Change-Id: I31091765b5bfd118fc5370b3515128f0e84e360f
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit cd2eba6cd04f2d78fd10b5e27abc2f3a6c1d56ab
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Oct 25 17:00:36 2017 +0530
readdir-ahead: Add parallel-readdir option in readdir-ahead
parallel-readdir option is defined as belonging to readdir-ahead
in glusterd-volume-set.c, but was not defined in options of
readdir-ahead, fixing the same.
Change-Id: I97cc88b38ab99ade5f066519ca1cb9bfed03a7da
BUG: 1506197
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit e9cca6fd485271011cb65bd88d23e337298c0ccc
Author: Varsha Rao <varao@redhat.com>
Date: Mon Jan 15 14:20:51 2018 +0530
performance/io-threads: Fix checked_return coverity error
Change the return type of set_stack_size function to integer and also
check the return value of pthread_attr_init(). This fixes the
Checked_Return coverity issue.
Change-Id: I270b8bd168b09f0b071437c117e4e23b01398534
Signed-off-by: Varsha Rao <varao@redhat.com>
commit f520614e378411ab6c41767c700e6a23b9220340
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jan 17 03:54:24 2018 -0500
features/bit-rot: Fix default value for scrub-throttle
Updates #302
Change-Id: Ifc23d5f8b5bc78b95f7c9d92d6df37a9168102f7
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit fa8604dfc28819ba081d6c219712d19d38eeb171
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Jan 17 19:16:15 2018 +0530
make sure geo-rep tests run first
as we run regression with a 'sort' function, geo-rep thus becomes last test to run.
instead, make sure it is the first test by changing the name of directory, and thus
any setup failures would be noticed much earlier.
Change-Id: I9e8d81824274900be42c4c49c752a1602497fa31
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7468f75ac2e260540da27e17dccff35fe3167a91
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Nov 7 00:07:12 2017 +0530
rpc/*: auth-header changes
Introduce another authentication header which can now send more data.
This is useful because this data can be common for all the fops, and
we don't need to change all the signatures.
As part of this, made rpc-clnt.c little more modular to support multiple
authentication structures.
stack.h changes are placeholder for the ctime etc, can be moved later
based on need.
updates #384
Change-Id: I6111c13cfd2ec92e2b4e9295896bf62a8a33b2c7
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit ff451c8bbd688b5937259a6766e3d733bec4856c
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jan 9 16:03:15 2018 +0530
dict: add another type to handle backward compatibility
This new type helps to avoid excessive logs. It should be
set only in case of
* volume graph building (graph.y)
* dict unserialize
(happens once a dictionary is received on wire in old protocol)
All other dict set and get should have proper check and warning
logs if there is a mismatch.
updates #220
Change-Id: I1cccb304a877aa80c07aaac95f10f5005e35b9c5
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit c7280c61bb9e2a5c008cce384821ade322f456a8
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jan 8 11:22:58 2018 +0530
features/bit-rot: fix volume options for GD2
Updates #302
Change-Id: I8809f269b93253bce049fdbf28a7f44e85a2b9e7
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit c2b680444ddb687c87023ff1a35748e406bb7e59
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Jan 16 00:37:45 2018 +0100
fuse: write out reverse notification to fuse dump
BUG: 1534602
Change-Id: Ide42cf9cffe462d0cc46272b327c2a05999f09ba
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit 771c8c74d0c903cc858e7b3facffab336526997e
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jan 5 13:51:18 2018 +0530
core: fix some of the dict_{get,set} with proper APIs
updates #220
Change-Id: I6e25dbb69b2c7021e00073e8f025d212db7de0be
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 70246b1181002756507fd2f2fdd8315b3b39fbfb
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Jun 15 14:42:19 2016 +0200
locks: added inodelk/entrylk contention upcall notifications
The locks xlator now is able to send a contention notification to
the current owner of the lock.
This is only a notification that can be used to improve performance
of some client side operations that might benefit from extended
duration of lock ownership. Nothing is done if the lock owner decides
to ignore the message and to not release the lock. For forced
release of acquired resources, leases must be used.
Change-Id: I7f1ad32a0b4b445505b09908a050080ad848f8e0
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
commit b59c58c35cc6c9266dca708892271d73fe31a9db
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Dec 28 16:02:59 2017 +0530
posix: delete stale gfid handles in nameless lookup
..in order for self-heal of symlinks to work properly (see BZ for
details).
Change-Id: I9a011d00b07a690446f7fd3589e96f840e8b7501
BUG: 1529488
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit f67053fc8b49907ff70205638c9818f3798bd9be
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Thu Jan 11 23:02:49 2018 +0530
tests: EC test fails with brick mux enabled
Problem:
With brick mux enabled get_fd_count count was returning
wrong value due to parsing issue.
Solution:
Updated the code to fix parsing problem.
BUG: 1533594
Change-Id: I5d7ff6843b4760f866c4a5aab2f13ff7380f248e
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit e554e76e9d9a6f0537f8b6bb90b2b5e167290c55
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Jan 12 10:51:44 2018 +0530
storage/posix: Set f_bfree to 0 if brick full
Return 0 free blocks if the brick is full or
has less than the reserved limit.
Change-Id: I2c5feda0303d0f4abe5af22fac903011792b2dc8
BUG: 1533736
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit c9699678291672cd895fc13b16dde634d9f8b7eb
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Tue Jan 9 16:58:22 2018 +0800
performance/readdir-ahead: fix cache usage update issue
Use atomic operation to modify cache-size to protect it from concurrent
modification.
Change-Id: Ie73cdd4abbaf0232b1db4ac856c01d24603890ad
BUG: 1533804
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit b632f6f0037c4e6e32b31cb9a532278dc8f96d36
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Dec 18 16:46:39 2017 +0530
cluster/afr: Fixing the flaws in arbiter becoming source patch
Problem:
Setting the write_subvol value to read_subvol in case of metadata
transaction during pre-op (commit 19f9bcff4aada589d4321356c2670ed283f02c03)
might lead to the original problem of arbiter becoming source.
Scenario:
1) All bricks are up and good
2) 2 writes w1 and w2 are in progress in parallel
3) ctx->read_subvol is good for all the subvolumes
4) w1 succeeds on brick0 and fails on brick1, yet to do post-op on
the disk
5) read/lookup comes on the same file and refreshes read_subvols back
to all good
6) metadata transaction happens which makes ctx->write_subvol to be
assigned with ctx->read_subvol which is all good
7) w2 succeeds on brick1 and fails on brick0 and this will update the
brick in reverse order leading to arbiter becoming source
Fix:
Instead of setting the ctx->write_subvol to ctx->read_subvol in the
pre-op statge, if there is a metadata transaction, check in the
function __afr_set_in_flight_sb_status() if it is a data/metadata
transaction. Use the value of ctx->write_subvol if it is a data
transactions and ctx->read_subvol value for other transactions.
With this patch we assign the value of ctx->write_subvol in the
afr_transaction_perform_fop() with the on disk value, instead of
assigning it in the afr_changelog_pre_op() with the in memory value.
Change-Id: Id2025a7e965f0578af35b1abaac793b019c43cc4
BUG: 1482064
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit c5c1c15adf9e142b98e1dfdb9962a06ba1707ae9
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Jan 10 09:09:24 2018 +0530
perf/io-cache: Update options for gd2
Update io-cache options for GD2
Updates gluster/glusterfs#302
Change-Id: I7fabf912d1e3cd024989404526db0a29644768c7
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit b717291375a4d1f57b51c6f7a71cc402ce468a13
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Jan 12 15:29:51 2018 +0530
cluster/ec Mark ./tests/basic/ec/heal-info.t as bad test
Change-Id: I7369fdd7510cc7ebf051cc621fc83764ba9591f3
BUG: 1533815
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit b5c530873b041642fe2a5fd51b5ea4222a8a4cd7
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Jan 5 10:22:45 2018 -0500
rpc: use export map to minimize exported symbols in libgf{rpc,xdr}.so
Without an export map (at link time) libgrpc and libgfxdr export over
150 and 450 symbols each, respectively. Many are not used by anything
else. (Unclear what the unused symbols are, some may be simple
sloppiness, e.g. not declaring functions static that should be. Others
may be intra-library calls that can't be static but aren't part of the
API, per se.)
By linking with an export map the number of exported symbols is
reduced to ~60 and ~250 respectively.
This parallels the similar change made to libglusterfs recently
and the older changes to the xlators to minimize the symbols that
are visible (exported) from the .so.
And I don't know, do we want to go all the way to symbol versions?
For these libs? And for libglusterfs?
fixes gluster/glusterfs#392
Change-Id: I9cdc3eee10e5f1408d7e7f2f29fad597c97e4003
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit aeae8bf7c3890c69954ffbb41651682915bf1595
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jan 12 10:07:28 2018 +0530
tests: check volume status for shd being up
so that glusterd is also aware that shd is up and running.
While not reproducible locally, on the jenkins slaves, 'gluster vol heal patchy'
fails with "Self-heal daemon is not running. Check self-heal daemon log file.",
while infact the afr_child_up_status_in_shd() checks before that passed. In the
shd log also, I see the shd being up and connected to at least one brick before
the heal is launched.
Change-Id: Id3801fa4ab56a70b1f0bd6a7e240f69bea74a5fc
BUG: 1515163
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit a187e16c914a597fae035802847142b04d6a824a
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Jan 10 08:33:23 2018 +0530
cluster/dht: Update options for gd2
Update DHT options for GD2
Updates gluster/glusterfs#302
Change-Id: Ia597fe364e97edd7bcf72d89f4ccdd50713a8837
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 263dbd3ef2b1d0e28b825daa1ae4184cb2e3da64
Author: Anoop C S <anoopcs@redhat.com>
Date: Mon Jan 8 17:32:05 2018 +0530
build: Link libgfrpc within rpc-transport shared libraries
Now with https://review.gluster.org/#/c/19056/ merged, we perform
dlopen() with RTLD_LOCAL so that every shared library is expected to
be explicitly linked against other required libraries.
"undefined symbol ..." was seen while trying to access GlusterFS volumes
via NFS-Ganesha/Samba using libgfapi resulting in an unusable state.
This is a follow-up patch to https://review.gluster.org/#/c/17659/
to make sure that we link libgfrpc too while making socket and rdma
rpc-transport shared libraries.
Change-Id: I9943cdc449c257ded3cb9f9f2becdd5784d1d82d
BUG: 1532238
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 577c7a3182769924b652d951ac2f98d2a6ae7679
Author: Varsha Rao <varao@redhat.com>
Date: Sun Jan 7 12:33:21 2018 +0530
cluster/dht: Change datatype of search_unhashed variable
Variable search_unhashed is of type boolean, change it to integer type.
This fixes the warning increment of a boolean expression.
BUG: 1531987
Change-Id: Ibf153f6a9ad704da38bff346b6a21a71323ed9bb
Signed-off-by: Varsha Rao <varao@redhat.com>
commit 171020496887951642b387b4953ba8fd463eca4b
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jan 4 22:07:54 2018 +0530
glusterd: get-state memory leak fix
Change-Id: Ic4fcf2087f295d3dade944efb8fd08f7e2d7d516
BUG: 1531149
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 0920f8c3b881834b7e81631259f1ef69ffe71144
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jan 8 11:53:17 2018 +0530
tests: Use /dev/urandom instead of /dev/random for dd
If there's not enough entropy in the system then reading /dev/random would take
a significant time since it would take a long time for the /dev/random buffers
to get full as is desired in this dd run.
Milind found that this test file takes almost a 1000 seconds or more to pass
instead of just a minute because of this.
BUG: 1431955
Change-Id: I9145b17f77f09d0ab71816ae249c69b8fe14c1a5
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 7462a37e7566b478367f9ebd9d44807c1887fa53
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Jan 5 15:29:13 2018 +0100
glusterd: fix up volume option flags
In glusterd volfile generation code options should be ornamented
with the VOLOPT_FLAG_* flags. However, some are ornamented with
OPT_FLAG_* flags (which are to be used in xlator context).
The impact is: the OPT_FLAG_* that occurs is OPT_FLAG_CLIENT_OPT,
which has the same value as VOLOPT_FLAG_XLATOR_OPT, so what was
meant is "option affects clients" and what was there means
"option enables/disables xlators". Because of this semantic
shift, op version might be incorrectly calculated for volumes
and clients. (At this point it's a theoretical possibility.
Actual occurrence might depend on connecting client & server
versions; it's also possible that there exists a proof of
concept scenario but it's irrealistic.)
This commit eliminates the OPT_FLAG_* occurrences from glusterd code,
and replaces them with the appropriate VOLOPT_FLAG_* flags.
Change-Id: Ia4e6fbac738d5a8d889c0f5561c4dea6783250b1
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit f34eeb22c6429b63af17b7c924d54e279ad0ae99
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sat Jan 6 20:00:04 2018 +0530
dict: fix VALIDATE_DATA_AND_LOG call
Couple of instances doesn't pass enough number of parameters to the
function resulting compilation to fail.
Updates #203
Change-Id: Id8caa6fe7fc611645ad7ff11d81a2462e4ec6bab
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 1bf73309277ec6aa2e4cabcb27bb3252146193e1
Author: Milind Changire <mchangir@redhat.com>
Date: Fri Jan 5 11:17:46 2018 +0530
Revert "rpc: merge ssl infra with epoll infra"
This reverts commit 56e5fdae74845dfec0ff7ad0c8fee77695d36ad5.
Change-Id: Ia62cee5440bbe8e23f5da9cff692d792091d544a
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit f0a2f49de45a21bdc6f08965cc58ba0a19e8bc65
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Jan 5 11:35:26 2018 +0530
libglusterfs: Include key name in data type validation
Printing the key name makes it easier for developers
to figure out which keys have dict data type mismatches.
Updates #337
Change-Id: I21d9a22488a4c5e5a8d991ca2d53f1e3039f7685
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 243e8d40df4bb3b4a79ebd9892fcd894c97bbc25
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Dec 27 16:14:30 2017 +0530
dict: add more types for values
Added 2 more types which are present in gluster codebase, mainly
IATT and UUID.
Updates #203
Change-Id: Ib6d6d6aefb88c3494fbf93dcbe08d9979484968f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 05202d6c88b0adb448f82b53986cd698ae6ed537
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Jan 3 14:29:51 2018 +0530
glusterd: connect to an existing brick process when qourum status is NOT_APPLICABLE_QUORUM
First of all, this patch reverts commit 635c1c3 as the same is causing a
regression with bricks not coming up on time when a node is rebooted.
This patch tries to fix the problem in a different way by just trying to
connect to an existing running brick when quorum status is not
applicable.
Change-Id: I0efb5901832824b1c15dcac529bffac85173e097
BUG: 1509845
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit fee58ded95a46f8e11b93af391e3422d04d08741
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Aug 11 04:55:18 2017 -0400
tests: Enable geo-rep test cases
This patch re-enables the geo-rep test cases.
Along with it does following optimizations.
1. Use EXPECT_WITHIN instead of sleep
2. Clean up geo-rep ssh key after test
3. Changes to gverify.sh and S56glusterd-geo-rep-create-post.sh
to use the given ssh identity file for geo-rep create
4. Make gluster-command-dir configurable and introduce
slave-gluster-command-dir which points the parent directory
of gluster binaries in master and slave respectively.
Change-Id: Ia7696278d9dd3ba04224dcd7c3564088ca970b04
BUG: 1480491
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit f338d95a2fbe485e985fd783aa64633c9173e3a9
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Thu Mar 23 12:50:41 2017 +0530
cluster/ec: OpenFD heal implementation for EC
Existing EC code doesn't try to heal the OpenFD to
avoid unnecessary healing of the data later.
Fix implements the healing of open FDs before
carrying out file operations on them by making an
attempt to open the FDs on required up nodes.
BUG: 1431955
Change-Id: Ib696f59c41ffd8d5678a484b23a00bb02764ed15
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit a9c54c0e7f0543ec272fbbcbecef4dd6a9e7b169
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Jan 4 12:24:48 2018 +0530
cli: Fixed a use_after_free
gf_event in cli_cmd_volume_create_cbk was accessing
memory that had already been freed.
Change-Id: I447c939fa9b31e18819a62c3b356c14cca390787
BUG: 1530910
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 8510a24504efec36d40d4db57f959b444c355d0d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 2 20:53:27 2018 +0530
debug/delay-gen: volume option fixes for GD2
Updates #302
Change-Id: I2c7ab85364337d0bc00428e0001ddc4038e08174
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit aa6e0408b8e5db1c172e20fe8c1467114584a8d5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 2 21:08:08 2018 +0530
performance/io-threads: volume option fixes for GD2
Updates #302
Change-Id: I7145e46ed649f8e69118f164709f7131b7e580be
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 27028248b55c48c1b4350ef151507d586d34d5ec
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jan 2 20:26:31 2018 +0530
glusterd: Nullify pmap entry for bricks belonging to same port
Commit 30e0b86 tried to address all the stale port issues glusterd had
in case of a brick is abruptly killed. For brick multiplexing case
because of a bug the portmap entry was not getting removed. This patch
addresses the same.
Change-Id: Ib020b967a9b92f1abae9cab9492f0cacec59aaa1
BUG: 1530281
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 6e03599ec341769c75f2598ad0f18cd66acbebf7
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Dec 28 11:23:29 2017 +0530
cluster/dht: Use percentages for space check
With heterogenous bricks now being supported in DHT
we could run into issues where files are not migrated
even though there is sufficient space in newly added bricks
which just happen to be considerably smaller than older
bricks. Using percentages instead of absolute available
space for space checks can mitigate that to some extent.
Marking bug-1247563.t as that used to depend on the easier
code to prevent a file from migrating. This will be removed
once we find a way to force a file migration failure.
Change-Id: I3452520511f304dbf5af86f0632f654a92fcb647
BUG: 1529440
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit f08457351531c70b8cf05b8eb4af39ef5615567b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Dec 27 12:33:16 2017 -0500
libglusterfs: export minimum necessary symbols
minimize risk of symbol collisions in global namespace.
see https://review.gluster.org/#/c/5697/ which Amar has
resurrected.
This is a strawman proposal to use an export-list to
only export the necessary symbols from libglusterfs. I suppose
some of this could be fixed by smarter use of static in the
function definitions.
It's a bit scary to see some of the names we expose. And then
there are the names we use in the reserved namespace.
One step short of going all the way to symbol versions
fixes gluster/glusterfs#382
Change-Id: Ifb848dfc655ef735dd27c73b7729e1188eb817f1
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit e6acec68a7b646f536bf9e7b1cf6708eaf897e33
Author: Niklas Hambüchen <mail@nh2.me>
Date: Fri Dec 29 15:49:13 2017 +0100
glusterfind: Speed up gfid lookup 100x by using an SQL index
Fixes #1529883.
This fixes some bits of `glusterfind`'s horrible performance,
making it 100x faster.
Until now, glusterfind was, for each line in each CHANGELOG.* file,
linearly reading the entire contents of the sqlite database in
4096-bytes-sized pread64() syscalls when executing the
SELECT COUNT(1) FROM %s WHERE 1=1 AND gfid = ?
query through the code path:
get_changes()
parse_changelog_to_db()
when_data_meta()
gfidpath_exists()
_exists()
In a quick benchmark on my laptop, doing one such `SELECT` query
took ~75ms on a 10MB-sized sqlite DB, while doing the same query
with an index took < 1ms.
Change-Id: I8e7fe60f1f45a06c102f56b54d2ead9e0377794e
BUG: 1529883
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
commit ff6baaeee09d6ab51463cbc30f7f822e02f36313
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Dec 25 19:19:53 2017 +0530
posix: Introduce flags for validity of iatt members
v1 of the patch started off as adding new fields to iatt that can be
filled up using statx but the discussions were more around introducing
masks to check the validity of different fields from a RIO perspective.
To that extent, I have dropped the statx call in this version and
introduced a 64 bit mask for existing fields. The masks I have defined
are similar with the statx() flags' masks.
I have *not* changed iatt_to_stat() to use the macros IATT_TYPE_VALID,
IATT_GFID_VALID etc before blindly copying from struct iatt to struct.
Also fixed warnings in xlators because of atime/mtime/ctime seconds
field change from uint32_t to int64_t.
Change-Id: I4ac614f1e8d5c8246fc99d5bc2d2a23e7941512b
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit ffeda6aab9edec805d30c900faa9c9a1d06c3664
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Dec 28 18:42:16 2017 +0530
mgmt/glusterd: Adding validation for setting quorum-count
In a replicated volume it was allowing to set the quorum-count value
between the range [1 - 2147483647]. This patch adds validation for
allowing only maximum of replica_count number of quorum-count value
to be set on a volume.
Change-Id: I13952f3c6cf498c9f2b91161503fc0fba9d94898
BUG: 1529515
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit ed1a81c9adef9cb66edb92de38ad4baee95ed8e3
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Dec 27 23:15:37 2017 +0530
snapshot : after brick reset/replace snapshot creation fails
Problem : after brick reset/replace snapshot creation fails
Solution : During brick reset/replace when we validate and aggrigate
dictionary data from another node it was rewriting
'mount_dir' value to NULL which is critical for snapshot
creation.
Change-Id: Iabefbfcef7d8ac4cbd2a241e821c0e51492c093e
BUG: 1512451
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit d80e08b2b2191f3b75c269ad02731798c66a587a
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Apr 24 23:20:27 2017 +0530
quiesce: add fallocate and seek fops
quiesce is useful in a gfproxy setup where if gfproxy machine goes
down the fop would be replayed. Hence only added the fops which is
supported by fuse layer to start with. With this patch, no behavior
change is added (ie, volfile change etc). Just making sure to have
the translator up-to-date so that if required we can consume it.
Updates #242
Change-Id: Id3bf204f2ccd42c3ac8f88d85836ecb855703e02
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit daac0047c8a51fad1c89f690c902b679fa8e5130
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Dec 28 15:17:34 2017 +0530
geo-rep: Log message improvements
BUG: 1529480
Change-Id: If4775ed9886990c0e1bcf4e44c7dfef95cc4f0c3
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 15921dec084a459ffe9154c90a6129eb2bf0cd54
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Dec 28 14:04:50 2017 +0530
eventsapi: JWT signing without external dependency
Added support for JWT signing without using python-jwt since it is not
available in all the distributions.
BUG: 1529463
Change-Id: I95699055442fbf9da15249f5defe8a8b287010f1
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 69dd061c94d800369d6f39e405e39aacd61d4bf6
Author: Yi Wang <wangyi@storswift.com>
Date: Tue Dec 26 01:17:04 2017 +0800
rpc-transport/rdma: Fix coverity issues in rdma transport
Issues:
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-12-25-0bc22bef/cov-errors.txt
Resolved:
[1] rdma.c:128 var_deref_op: Dereferencing null pointer "post".
[2] rdma.c:677: Potentially overflowing expression
[3] rdma.c:4250: freed_arg: "rpc_transport_unref" frees "peer->trans".
[4] rdma.c:4644: var_deref_op: Dereferencing null pointer "rdma_ctx".
[5] rdma.c:4945: cond_false: Condition "rdma_ctx != NULL", taking false branch.
Change-Id: Iec38f118d645df4131739da412a6c741ebbd2f85
BUG: 789278
Signed-off-by: Yi Wang <wangyi@storswift.com>
commit 3193fdf6d5aa471bfc4957227c27455a16c83754
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Sat Dec 23 23:18:14 2017 -0500
rpc: fix use after freed of clnt after rpc transport clenup
If the transport object is freed in rpc_transport_unref,
a notify of RPC_TRANSPORT_CLEANUP is push to rpc_clnt_notify,
where the rpc_clnt(contains conn) is freed.
After that, using of conn after rpc_transport_unref is use after freed.
Change-Id: I5cac8a8e7ced7c1079930080a12abf02d46667d5
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit baf5898e836ec58187e52fb5e0e810803bae7a4b
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue Dec 19 22:35:53 2017 +0530
Use RTLD_LOCAL for symbol resolution
RTLD_LOCAL is the default value for symbol visibility flag of dlopen()
in Linux and NetBSD. Using it avoids conflicts during symbol resolution.
This also allows us to detect xlators that have not been explicitly
linked with libraries that they use. This used to go unnoticed
when RTLD_GLOBAL was being used.
BUG: 1193929
Change-Id: I50db6ea14ffdee96596060c4d6bf71cd3c432f7b
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit 16012e52c877c93e9d06d6633c33bb9550d938e3
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Dec 25 14:34:16 2017 +0100
tests/vagrant: add a --help option to the script
Change-Id: I89913375fedb6a7617873b09039de72bf1773c68
BUG: 1526780
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 643482d892ae32e931b547ec8b632447867c7371
Author: Prashanth Pai <ppai@redhat.com>
Date: Fri Dec 22 15:52:46 2017 +0530
Set log path correctly when clients use UDS
When a libgapi client passes a path to Unix socket file as the "host"
parameter to glfs_set_volfile_server() and doesn't explicitly specify
a log file, the default log file path being generated was invalid.
Example:
ERROR: failed to create logfile "/var/log/glusterfs//tmp/gd2/
w1/run/glusterd2.socket-test-10368.log" (No such file or directory)
With this fix, it is set to:
/var/log/glusterfs/tmp-gd2-w1-run-glusterd2.socket-test-31869.log
Change-Id: Ibb4b58382c72eab0d104543781e0e966ebf4c47f
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit ebb773ac36eb4a246d6b7a1beeeadedaf4aebfb5
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Dec 19 16:10:11 2017 +0530
dict: support better on-wire transfer
This patch brings data type awareness to dictionary,
and also makes sure valid data is properly sent to the
other side of the wire using XDR.
Next step is to allow people to add more data types
(for example, Bool, UUID, iatt etc), and then make
it part of every fop signature in wire.
Fixes #203
Change-Id: Ie0eee2db847bea2bf7dad80dec89ce3e7c5917c1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7e707e67da1614005748f00267f158855c59294b
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Dec 25 14:40:16 2017 +0100
rpm: Fedora 28 has renamed pyxattr
Change-Id: Ifa60b394986b9c107792a7c2a4baa335d44dc6f7
BUG: 1528975
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit cfeed4036e41af9b15ad8fb51efedc0800598645
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Jul 14 15:18:19 2017 +0530
cluster/dht: Add migration checks to dht_(f)xattrop
The dht_(f)xattrop implementation did not implement
migration phase1/phase2 checks which could cause issues
with rebalance on sharded volumes.
This does not solve the issue where fops may reach the target
out of order.
Change-Id: I2416fc35115e60659e35b4b717fd51f20746586c
BUG: 1471031
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 1515643d7fdd1abce338652ebcfb2df444f76ac8
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Wed Nov 29 17:36:55 2017 +0800
protocol/client: reduce lock contention
Current use of a per-client mutex to protect fdctx introduces lock
contentions when there are dozens of file operations active.
Use finer grain spinlock to reduce contention, and put retrieving
fdctx out of lock.
Change-Id: Iea3e2eb481e76a5d73a582ba81529180c5b88248
BUG: 1519598
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit f1cb6cf37bb8694d13fb0fa3aa1eed375cfd30db
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Dec 22 12:02:09 2017 +0530
performance/write-behind: fix bug while handling short writes
The variabled "fulfilled" in wb_fulfill_short_write is not reset to 0
while handling every member of the list.
This has some interesting consequences:
* If we break from the loop while processing last member of the list
head->winds, req is reset to head as the list is a circular
one. However, head is already fulfilled and can potentially be
freed. So, we end up adding a freed request to wb_inode->todo
list. This is the RCA for the crash tracked by the bug associated
with this patch (Note that we saw "holder" which is freed in todo
list).
* If we break from the loop while processing any of the last but one
member of the list head->winds, req is set to next member in the
list, skipping the current request, even though it is not entirely
synced. This can lead to data corruption.
The fix is very simple and we've to change the code to make sure
"fulfilled" reflects whether the current request is fulfilled or not
and it doesn't carry history of previous requests in the list.
Change-Id: Ia3d6988175a51c9e08efdb521a7b7938b01f93c8
BUG: 1528558
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 5530640ab9349bfe3f2cd117d06476c52579e75f
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Dec 22 11:34:22 2017 +0530
xlator.h: move options and other variables to the top of structure
This helps external applications which wants to consume xlator_api
to read only fields (and not functions) using dlopen() to write
smaller structures/objects and still achieve their requirements.
One such example is GD2 project.
Updates #168
Change-Id: I8737939c8c72f6572ee1514201e9f9f8e4f37b40
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit d4c8603d0623a7ce93177072c7129a04ae84ef09
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Wed Dec 13 17:27:42 2017 +0100
cluster/ec: Fix possible shift overflow
A coverity scan has revelaed a potential shift overflow while scanning
the bitmap of available subvolumes. The actual overflow cannot happen,
but I've changed to test used to control the limit to make it explicit.
Change-Id: Ieb55f010bbca68a1d86a93e47822f7c709a26e83
BUG: 789278
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit 2d26de33f4ec73a7aad568480487f5adf6c93c9b
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Dec 20 15:24:11 2017 +0530
fips/geo-rep: Replace MD5 with SHA256
MD5 is not fips compliant. Hence replacing
with SHA256.
NOTE:
The hash is used to form the ctl_path for the ssh connection.
The length of ctl_path for ssh connection should not be > 108.
ssh fails with ctl_path too long if it is so. But when rsync
is piped to ssh, it is not taking > 90. rsync is failing with
error number 12. Hence using first 32 bytes of hash. Hash
collision doesn't matter as only one sock file is created
per directory.
Change-Id: I58aeb32a80b5422f6ac0188cf33fbecccbf08ae7
Updates: #230
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 0776aeed9e23761b7c500072940b762c97019220
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Dec 6 07:59:53 2017 +0530
cluster/ec: Change [f]getxattr to parallel-dispatch-one
At the moment in EC, [f]getxattr operations wait to acquire a lock
while other operations are in progress even when it is in the same mount with a
lock on the file/directory. This happens because [f]getxattr operations
follow the model where the operation is wound on 'k' of the bricks and are
matched to make sure the data returned is same on all of them. This consistency
check requires that no other operations are on-going while [f]getxattr
operations are wound to the bricks. We can perform [f]getxattr in
another way as well, where we find the good_mask from the lock that is already
granted and wind the operation on any one of the good bricks and unwind the
answer after adjusting size/blocks to the parent xlator. Since we are taking
into account good_mask, the reply we get will either be before or after a
possible on-going operation. Using this method, the operation doesn't need to
depend on completion of on-going operations which could be taking long time (In
case of some slow disks and writes are in progress etc). Thus we reduce the
time to serve [f]getxattr requests.
I changed [f]getxattr to dispatch-one and added extra logic in
ec_link_has_lock_conflict() to not have any conflicts for fops with
EC_MINIMUM_ONE as fop->minimum to achieve the effect described above.
Modified scripts to make sure READ fop is received in EC to trigger heals.
Updates gluster/glusterfs#368
Change-Id: I3b4ebf89181c336b7b8d5471b0454f016cdaf296
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 3944f57728d5c09a8810cc13c13e68ccaf9b4151
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Dec 17 13:08:47 2017 +0100
tests/vagrant: configure with --enable-gnfs so tests can use NFS
gNFS has been deprecated a while ago, but the ./run-tests-in-vagrant.sh
script has not been adapted to enable it. This causes the tests to fail
the first time a Gluster Volume is mounted over NFSv3.
Change-Id: Ifeec0ca964680ff61b956a5592a76eeee8ac3b85
BUG: 1526780
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit d5fe79a9838d3a7115560b50605e41da60cdb4e9
Author: Kamal Mohanan <kmohanan@redhat.com>
Date: Tue Dec 12 17:17:37 2017 +0530
cluster/ec: Add default value for the redundancy option
Updates #302
Change-Id: Ifccc6a64c2b2a3b3a0133e6c8042cdf61a0838ce
Signed-off-by: Kamal Mohanan <kmohanan@redhat.com>
commit 4c5ddb3c27497a1f19b92bc05e9b01a727a8590b
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Dec 19 07:21:07 2017 -0500
rchecksum/fips: Replace MD5 usage to enable fips support
rchecksum uses MD5 which is not fips compliant. Hence
using sha256 for the same.
Updates: #230
Change-Id: I7fad016fcc2a9900395d0da919cf5ba996ec5278
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit bacb4a5cc3c3c449404c7088cdb8870be478beb0
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Dec 20 13:30:39 2017 +0530
snapshot: fix several coverity issues in glusterd-snapshot.c
This patch fixes issues 157, 426, 428, 431, 432, 437,439, 482 from [1].
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-12-13-e255385a/html/
Change-Id: Iff9df12bd9802db29434155badb1beda045aba5b
BUG: 789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 86b0082e2cced6c5592d4a81fcd31722e30fb448
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Thu Nov 2 10:11:43 2017 +0100
cli: Fixed coverity issue in cli-cmd-system.c
This patch adds a missing check of the return value of strtok_r()
and returns an error if it's NULL.
It also fixes a couple of leaks.
Change-Id: Ib15d6f843516e44c3bd8790a2e3ad936e357f6d4
BUG: 789278
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit 81a5f56103abe71381d976788fecb5d2baf7db74
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Aug 31 15:23:56 2017 +0530
stripe, quiesce: volume option fixes
Updates: #302
Change-Id: I8f84260ba007f2afc7fe3b7c15c06069942ad6d1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 0f3bd24c0a4d9b93b0d66d04855ebdc834c01c56
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Fri Dec 1 15:23:52 2017 +0530
leases: Fix coverity issues
- dead code removal
- check return value for thread creation.
- fix resource leak
Change-Id: I58d4247bab503fa419bc83c36fc59801a1c41f5e
BUG: 789278
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
commit 8ecceb784060935b0dffc836b5f885b567d9dca0
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Dec 19 00:05:05 2017 -0500
fips: Replace md5sum usage to enable fips support
md5sum is not fips compliant. Using xxhash64 instead of
md5sum for socket file generation in glusterd and
changelog to enable fips support.
NOTE: md5sum is 128 bit hash. xxhash used is 64 bit.
Updates: #230
Change-Id: I1bf2ea05905b9151cd29fa951f903685ab0dc84c
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 43a75acebbc23c8c06d720769e1b8bcf35782051
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Mon Dec 18 04:09:39 2017 -0500
posix: fix use after freed by calling STACK_UNWIND_STRICT after error cleanup
xdata is freed when calling STACK_UNWIND_STRICT, so that,
posix_gfid_unset uses xdata after freed.
Change-Id: Id0ff2da3d6d9be204e50d9fb37ba57558936c85c
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 7f78a2de4a0303647a9d2e0506b476a59308c77c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Dec 11 16:14:03 2017 +0530
feature/bitrot: remove internal xattrs from lookup cbk
Problem:
afr requests all xattrs in lookup via the list-xattr key. If bitrot is
enabled and later disabled, or if the bitrot xattrs were present due to
an older version of bitrot which used to create the xattrs without
enabling the feature, the xattrs (trusted.bit-rot.version in particular)
was not getting filtered and ended up reaching the client stack. AFR, on
noticing different values of the xattr across bricks of the replica,
started triggering spurious metadata heals.
Fix:
Filter all internal xattrs in bitrot xlator before unwinding lookup,
(f)getxattr.
Thanks to Kotresh for the help in RCA'ing.
Change-Id: I5bc70e4b901359c3daefc67b8e4fa6ddb47f046c
BUG: 1524365
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 0de06f23256ce7503a8c038ff529117cc8e2cbff
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Dec 13 18:26:36 2017 +0530
snapshot: Fix several coverity issues in glusterd-snapshot-utils.c
This patch fixes issues 622, 627, 630, 484, 32, 33 and 34 from [1]
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I4c7ac2b2725474d73643367b38f8bf33eaddd8da
BUG: 789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 2365e8fba3e50dc6edad22349244838cda6bb180
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Nov 28 13:03:30 2017 +0530
protocol/server: add dump_metrics method
As 'xlator_api' export is a requirement to add dump_metrics, use it
Updates #168
Change-Id: Iaba8bb9151ef35038b0ff48bb26e8399d67aa039
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 20f3e8e42ad4428b91b84f2f573d0f5b57ad6cca
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Fri Dec 15 12:37:06 2017 +0100
glusterd: Fix buffer overflow in glusterd_get_volopt_content
The size of the description of each option in gluster has become
greater than the hardcoded maximum size, causing a buffer overflow
when requesting a list of all options.
This patch uses dynamic memory to store all the information.
Change-Id: I115cb9b55fc440434638bf468a50db055cdf271d
BUG: 1526402
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit a41f3d887a0e802d6a463e987dccfcc793a984e5
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Nov 13 12:55:06 2017 +0530
dht: Fill first_up_subvol before use in dht_opendir
Reported by: Sam McLeod
Change-Id: Ic8f9b46b173796afd70aff1042834b03ac3e80b2
BUG: 1512437
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 8587c5065ce0f03f9e33156c511a7b0226a160f1
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Tue Dec 12 22:31:53 2017 +0100
all: Simplify component message id's definition
This patch creates a new way of defining message id's that is easier
and less error prone because it doesn't require so many manual changes
each time a new component is defined or a new message created.
Change-Id: I71ba8af9ac068f5add7e74f316a2478bc991c67b
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit 348ba8d74719072e5f351c58bf39a60e170aef4d
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Feb 21 21:35:12 2017 +0100
logging: free the strdup'd filename and ident on gf_log_fini()
Every time glfs_set_logging() is called, the strings containing the
filename and the identity of the logfile leaks. Both should be free'd
before a new gf_strdup() is done and in gf_log_fini().
In addition to the free'ing of the filename, the code has been adapted
to use sys_open() and fdopen() so that unneeded closes and re-opening of
the filedescriptor are prevented.
Change-Id: I63e3e757ac990a4db419206dfad141ab68dbfa06
BUG: 1443145
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 0f7aa96121698974bea5333e3c47e864e7a1480a
Author: Richard Wareing <rwareing@fb.com>
Date: Tue Nov 10 18:04:00 2015 -0800
storage/posix: Fix crash in posix_make_ancestryfromgfid
Summary:
- Log an OOPS and bail when *parent is null just before going into
posix_resolve code path (to avoid crash)
> Reviewed-on: https://review.gluster.org/17969
> Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
Change-Id: I6140ef6fdb711748dad1c66d929aca36328bc574
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 0dbbc5dab80800e09f153c9627f42562161d2d47
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue Dec 12 13:16:52 2017 +0530
features/changelog: changelog threads are not cleaned properly after receive GF_EVENT_CLEANUP
Problem: changelog threads are not cleaned properly after receive
GF_EVENT_CLEANUP while brick mux is enabled
Solution: change changelog notify code path to cleanup threads
properly
BUG: 1524816
Change-Id: I007f4e14e3d557707df738faf222b78c793d5ab5
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 8d937245c3419aec678831cfc78d3ce2159b6977
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Nov 10 20:33:20 2017 +0100
write-behind: Allow trickling-writes to be configurable
This is the undisputed/trivial part of Shreyas' patch
he attached to https://bugzilla.redhat.com/1364740 (of
which the current bug is a clone).
We need more evaluation for the page_size and window_size
bits before taking them on.
Change-Id: Iaa0b9a69d35e522b77a52a09acef47460e8ae3e9
BUG: 1428060
Co-authored-by: Shreyas Siravara <sshreyas@fb.com>
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit f4ce28bb4cd9d6968d889f2847db17d5edd9f080
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Jun 30 12:52:21 2017 +0530
quick-read: Integrate quick read with upcall and increase cache time
Fixes : #261
Co-author: Subha sree Mohankumar <smohanku@redhat.com>
Change-Id: Ie9dd94e86459123663b9b200d92940625ef68eab
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 18cc6bc91b748a31e537664cdaa4d9ab0210eb71
Author: Sachin Prabhu <sprabhu@redhat.com>
Date: Fri Dec 8 15:24:26 2017 +0530
quick-read: Discard cache for fallocate, zerofill and discard ops
The fallocate, zerofill and discard modify file data on the server thus
rendering stale any cache held by the xlator on the client.
BUG: 1524252
Change-Id: I432146c6390a0cd5869420c373f598da43915f3f
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
commit c446ff2f71435395c6349ec465c607c624dac914
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Dec 11 14:41:57 2017 +0530
rpc: merge ssl infra with epoll infra
Patch attempts to use the epoll infra for handling SSL connections
as well instead of the socket_poller() thread func.
This essentially makes priv->own_thread flag redundant.
SSL_connect()/SSL_accept() is now non-blocking which has done away
with the localised poll() in ssl_do(). So, ssl_do() has been updated
appropriately.
own_thread and coincidently socket_poller() thread for SSL processing
is now deprecated.
Added a timeout to test whether seal-heal daemon is up and running
as per Ravi's suggestion.
Change-Id: If2b5d7b4fd19e321cb289e08d49a718d2161aafe
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit f8464a829ba80a3b967c5671771d1dbce9156b59
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Dec 7 10:32:05 2017 +0530
glusterd : Fix glusterd mem leaks
Problem: glusterd eats a huge amount of meory during volume set/stop/start.
Solution: At the time of compare graph topology create a graph and populate
key values in the dictionary, after finished graph comparison we
do destroy the new graph.At the time of construct graph we don't take
any reference and for server xlators we do take reference in
server_setvolume so in glusterd we do take reference after prepare
a new graph while we do create a graph to compare graph topology.
BUG: 1520245
Change-Id: I573133d57771b7dc431a04422c5001a06b7dda9a
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 810e2fa38604827ceb285321fd88d032994f4f50
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Thu Sep 7 15:34:58 2017 -0700
md-cache: Cache statfs calls
Summary:
- This gives md-cache to cache statfs calls
- You can turn it on or off via 'gluster vol set groot performance.md-cache-statfs <on|off>'
Change-Id: I664579e3c19fb9a6cd9d7b3a0eae061f70f4def4
BUG: 1523295
Signature: t1:4652632:1488581841:111cc01efe83c71f1e98d075abb10589c4574705
Reviewed-on: https://review.gluster.org/18228
Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
commit 7f6ae27e7667db36ec943f1940fc1226a7b7e9b6
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri Oct 20 12:39:29 2017 +0530
glusterfs: Use gcc builtin ATOMIC operator to increase/decreate refcount.
Problem: In glusterfs code base we call mutex_lock/unlock to take
reference/dereference for a object.Sometime it could be
reason for lock contention also.
Solution: There is no need to use mutex to increase/decrease ref
counter, instead of using mutex use gcc builtin ATOMIC
operation.
Test: I have not observed yet how much performance gain after apply
this patch specific to glusterfs but i have tested same
with below small program(mutex and atomic both) and
get good difference.
static int numOuterLoops;
static void *
threadFunc(void *arg)
{
int j;
for (j = 0; j < numOuterLoops; j++) {
__atomic_add_fetch (&glob, 1,__ATOMIC_ACQ_REL);
}
return NULL;
}
int
main(int argc, char *argv[])
{
int opt, s, j;
int numThreads;
pthread_t *thread;
int verbose;
int64_t n = 0;
if (argc < 2 ) {
printf(" Please provide 2 args Num of threads && Outer Loop\n");
exit (-1);
}
numThreads = atoi(argv[1]);
numOuterLoops = atoi (argv[2]);
if (1) {
printf("\tthreads: %d; outer loops: %d;\n",
numThreads, numOuterLoops);
}
thread = calloc(numThreads, sizeof(pthread_t));
if (thread == NULL) {
printf ("calloc error so exit\n");
exit (-1);
}
__atomic_store (&glob, &n, __ATOMIC_RELEASE);
for (j = 0; j < numThreads; j++) {
s = pthread_create(&thread[j], NULL, threadFunc, NULL);
if (s != 0) {
printf ("pthread_create failed so exit\n");
exit (-1);
}
}
for (j = 0; j < numThreads; j++) {
s = pthread_join(thread[j], NULL);
if (s != 0) {
printf ("pthread_join failed so exit\n");
exit (-1);
}
}
printf("glob value is %ld\n",__atomic_load_n (&glob,__ATOMIC_RELAXED));
exit(0);
}
time ./thr_count 800 800000
threads: 800; outer loops: 800000;
glob value is 640000000
real 1m10.288s
user 0m57.269s
sys 3m31.565s
time ./thr_count_atomic 800 800000
threads: 800; outer loops: 800000;
glob value is 640000000
real 0m20.313s
user 1m20.558s
sys 0m0.028
Change-Id: Ie5030a52ea264875e002e108dd4b207b15ab7cc7
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 9a51fd2978cb97d266309482060141596652b2b4
Author: Yi Wang <wangyi@storswift.com>
Date: Wed Dec 6 12:51:49 2017 +0800
rpc-transport/rdma: Add a mutex for the list of RDMA Memory Region(MR) access
Problem: gf_rdma_device_t->all_mr is a __gf_rdma_arena_mr(includes MR content)
kind of list in the rdma rpc-transport. The rdma rpc-transport will
add/delete items to the list when MRs register, deregister, and free.
Because gf_rdma_device_t->all_mr is used by different threads
and it is not mutex protected, rdma transport maybe access obsolete
items in it.
Solution: Add a mutex protection for the gf_rdma_device_t->all_mr.
Change-Id: I2b7de0f7aa516b90bb6f3c6aae3aadd23b243900
BUG: 1522651
Signed-off-by: Yi Wang <wangyi@storswift.com>
commit 12a959a9c5aa0af6f3da03cae2272e5c5871b37d
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Mon Apr 10 12:36:21 2017 -0700
posix: Add option to disable nftw() based deletes when purging the landfill directory
Summary:
- We may have found an issue where certain directories were being moved into .landfill and then being quickly purged via nftw().
- We would like to have an emergency option to disable these purges.
> Reviewed-on: https://review.gluster.org/18253
> Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
Fixes #371
Change-Id: I90b54c535930c1ca2925a928728199b6b80eadd9
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 592d2c45582bc4f3123b2e4b8b6450ff46697c3f
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Dec 7 04:46:08 2017 -0500
geo-rep: Cleanup stale unprocessed xsync changelogs
Fixes: #376
Change-Id: Ib92920c716c7d27e1eeb4bc4ebaf3efb48e0694d
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 2bac942956a21c41d1103059cb55f8da25928bd8
Author: Susant Palai <spalai@redhat.com>
Date: Wed Mar 8 14:45:15 2017 +0530
cluster/dht: fix memory leaks in rebalance
From code reading it was found that in gf_defrag_process_dir, GF_FREE
was called directly on dir_dfmeta->equeue leading to leaks of memory for
list of entries read from all the local subvols in case of a failure.
This patch frees the entries read from all the local subvols.
Change-Id: If5e8f557372a8fc2af86628b401e8de1b54986a1
BUG: 1430305
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 589613335074663f5cda1d053deceabd55f57351
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Sep 28 19:26:37 2017 +0530
perf/open-behind: update options for gd2
Updates: #302
Change-Id: I12e5bc6d9e1fcd285299818a7f7e8f1622deefcb
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit ce934be2e80f4b28dfe9a7c17fd20a82e4a06b19
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Aug 31 15:07:10 2017 +0530
trash/selinux : update volume option table in xlator
Add new options defined by https://review.gluster.org/18059 to trash and selinux
Updates #302
Change-Id: I31064f26d2b244a2923baa4bb948a6e8ab7b0d1a
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
commit 4cbe2ef63e37eb9698b1e0b4fa3ee8e23beee423
Author: Richard Wareing <rwareing@fb.com>
Date: Wed Apr 6 17:06:43 2016 -0700
debug/io-stats: Adding stat for weighted & unweighted average latency
Summary:
- Our current approach to measuring "average fop latency" is badly
flawed in that it doesn't weight the FOPs correctly according to how
many occurred in the time interval. This makes Statisticians very
sad. This patch adds an internally computed weighted average
latency which will be far more efficient to display via ODS, as well
as having the benefit of not being complete nonsense.
Reviewers: kvigor, dph, sshreyas
Reviewed By: sshreyas
Change-Id: Ie3618f279b545610b7ed1a8482243fcc8dc53217
BUG: 1523353
Reviewed-on: https://review.gluster.org/18192
Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Signed-off-by: Ana M. Neri <amnerip@fb.com>
commit 2c9d1acc985a2919f93521e306091d1752c7c0c3
Author: Ankit raj <anraj@redhat.com>
Date: Fri Apr 21 11:50:35 2017 +0530
dht: Send an event when disks get full
Send an event if DHT determines that a subvol is getting
full or running out of inodes.
Change-Id: Ie026f4ee1832b5df1e80b16cb949b2cc31a25d6f
Bug: 1440659
Signed-off-by: Ankit raj <anraj@redhat.com>
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 398ccf68df5ce974b89e7a8c2bd6ec60d4325444
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Thu Dec 7 08:00:16 2017 -0800
nfs: Reference count export items
Export items are used in the auth cache and need to be reference
counted to avoid use-after free bugs.
Change-Id: I5cdcdc1cc6abad26c7077d66a14f263da07678ac
BUG: 1522847
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
commit 57fc08c923190c461186da4d5c5c5c4ffd3ddfad
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Wed Dec 6 07:41:19 2017 -0800
nfs: Enable multi-core epoll support in gNFSd
Change-Id: Ie8a7b1ba04b0e83f5ec7a09f9d181fe59be479ca
BUG: 1522847
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
commit 90323f993bd4de321563cd05e47b6fd71dc5c9b2
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Thu Sep 7 16:36:29 2017 -0700
storage/posix: Add limit to number of hard links
Summary:
Too may hard links blow up btrfs by exceeding max xattr size (recordign
pgfid for each hardlink). Add a limit to prevent this explosion.
> Reviewed-on: https://review.gluster.org/18232
> Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
Fixes gluster/glusterfs#370
Signed-off-by: ShyamsundarR <srangana@redhat.com>
Change-Id: I614a247834fb8f2b2743c0c67d11cefafff0dbaa
commit 419427a441205c1a11a5996fc245723110dd1de7
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Wed Apr 5 13:23:13 2017 -0700
glusterd: Allow volume stop to succeed if certain processes are already dead
Summary:
- Sometimes a the process that glusterd is trying to kill is already dead.
- In that case, if it can't find the pid, it should just continue on and not fail the entire operation.
Change-Id: Ic96952a8d31927446f648830ede6ccd82512663f
BUG: 1522968
Reviewed-on: https://review.gluster.org/18234
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Signed-off-by: Ana M. Neri <amnerip@fb.com>
commit 8a89a591c9c7797f41d0ac2fb417010be3fd1d07
Author: Richard Wareing <rwareing@fb.com>
Date: Wed Jul 1 18:44:07 2015 -0700
Fix management client deadlock
Ping notify is a NOOP for management daemons
Reviewers: sshreyas
Reviewed By: sshreyas
FB-commit-id: ec30b68
Change-Id: I8e121aaaa3ad268e5df057e03aa4b37a403c9ea0
BUG: 1522968
Signed-off-by: Kevin Vigor <kvigor@fb.com>
Reviewed-on: https://review.gluster.org/16858
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
commit 19a94f55c5b88cc088a8c53eb5617a8a7d7a4605
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Nov 30 18:39:58 2017 +0530
features/read-only: Coverity fixes
Warning File Function
NEGATIVE_RETURNS worm.c worm_writev
RESOURCE_LEAK worm.c init
read-only.c init
Note: COPY_PASTE_ERROR in worm_setattr & worm_fsetattr are false alarms.
Change-Id: Iba1b0c18137a8797d7d04502acc87f0b307e1a1c
BUG: 789278
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit b89efa0afec129ac46328be57a34bc90b5996a90
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Dec 6 14:23:06 2017 +0530
core/memacct: save allocs in mem_acct_rec list
With configure --enable-debug, add all object allocations
to a list in the corresponding mem_acct_rec. This
allows us to see all objects of a particular type
and allows for additional debugging in case of memory
leaks.
This is not compiled in by default and must be explicitly
enabled. It is intended to be used by developers.
Change-Id: I7cf2dbeadecf994423d7e7591e85f18d2575cce8
BUG: 1522662
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 0e7f56fe630f36147f64aaab9c9c32428a37cb52
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Dec 6 18:05:24 2017 +0530
glusterd: Free up svc->conn on volume delete
Daemons like snapd, tierd and gfproxyd are maintained on per volume
basis and on a volume delete we should destroy the rpc connection
established for them.
Change-Id: Id1440e39da07b990fdb9b207df18da04b1ca8014
BUG: 1522775
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 47a75b89c50f3b741e77de6acea8db6b3299bfc1
Author: Richard Wareing <rwareing@fb.com>
Date: Fri Oct 17 18:35:56 2014 -0700
Fixes gNFSd gf_update_latency crashes
Summary:
- Per title, does a bounds check on the frame->op and bails from the
function if it's invalid preventing the crash
Test Plan: Prove tests
Reviewers: dph, jackl
Reviewed By: jackl
FB-commit-id: e67cc15
Change-Id: If1a5a9c0630573d4a6615050a9114ccf532551c7
BUG: 1522847
Signed-off-by: Kevin Vigor <kvigor@fb.com>
Reviewed-on: https://review.gluster.org/16847
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
commit ffa5894ba765627e2a585364886c942c23af8899
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Wed Dec 6 09:20:41 2017 -0800
rpc: Fix format warnings when using IPV6_DEFAULT
Change-Id: I22e622212f30defe6f2af1a67d7b48a88d37a097
BUG: 1520974
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
commit b5ed5e39e1ca5bc068967919cf1c6d914a1d5311
Author: Max Rijevski <moox@fb.com>
Date: Thu Apr 7 13:11:20 2016 -0700
performance/io-threads: Reduce the number of timing calls in iot_worker
Summary:
- Reduce the amount of unnecessary timing calls
in iot_worker servicing.
- The current logic is unnecessarily accurate and
hurts performance for many small FOPS.
Change-Id: I6db4f1ad9a48d9d474bb251a2204969061021954
BUG: 1522950
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Reviewed-on: http://review.gluster.org/16081
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kevin Vigor <kvigor@fb.com>
commit 7061eca78a2eb42e42f3e64e696514aca1b5b810
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Tue Dec 5 12:54:04 2017 +0800
gfapi: fix issue when glfs_set_logging is called concurrently
glfs_set_logging changes THIS->ctx without lock, during initialization
THIS refers to global_xlator. Concurrently changing it could result in
global_xlator.ctx being some fs->ctx. After that fs->ctx is destroyed,
global_xlator.ctx refers to an invalid pointer and that causes crash in
sbusequent access.
Change-Id: I6682173811799bafd525d9ab371874f3803baa0e
BUG: 1521213
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit d4a3c90cc1723dfe7efebdbaec728ae50456f4b7
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Tue Dec 5 12:45:46 2017 +0800
libglusterfs: specify ctx in gf_log_set_loglevel
specify ctx in gf_log_set_loglevel, instead of getting it from a thread
specific variable.
Change-Id: I498f826e8e32231235a6b0005026a27c327727fd
BUG: 1521213
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit ca763ae96df16c88f61879ae8697ac7eff4b75d0
Author: ShyamsundarR <srangana@redhat.com>
Date: Wed Dec 6 11:32:00 2017 -0500
dht/crypt/tier: Fix use of booleans as integers
BUG: 1520974
Change-Id: I19ea40c888e88a7a4ac271168ed1820c2075be93
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit e8d4c4b32e34c716c80a37946b0d46d4b82c8bb5
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Tue May 24 10:51:23 2016 -0700
nfs: Check if FQDN is authorized before unmounting clients
Summary:
- We have a thread that checks if connected clients are "still" authorized for a mount.
- This thread is currently only checking the IP (regression from the 3.4 -> 3.6 rebase, perhaps).
- This diff adds code toe check the IP *and* the FQDN before unmounting the client.
Test Plan: Tested on devserver, auth prove tests.
Reviewers: rwareing, kvigor
Reviewed By: kvigor
Change-Id: I441a4436d8df064d2f09a2539acb780ab53943f6
BUG: 1522847
Reviewed-on: https://review.gluster.org/18193
Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Signed-off-by: Siri Uppalapati <siri@fb.com>
commit 60fd566b1fcfcf0d4ebf010210f0d12417866219
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Oct 11 15:08:49 2017 +0530
metrics: provide options to dump metrics from xlators
* Introduce xlator methods to allow dumping of metrics
* Separate options to get the metrics dumped in a path
Updates #168
Change-Id: I7df80df33b71d6f449f03c2332665b4a45f6ddf2
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 481feb61dedfda9967f86a6a0ef6627dd0c49bd7
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Wed Dec 6 09:42:27 2017 -0800
xdr: Fix build errors due to missing xdr symbol when building against TIRPC
Change-Id: Ic52045f5dd19e551612242450b8982f42ff327e9
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
commit 746ed1aab72265b4265d7631817476842a3b734a
Author: Nigel Babu <nigelb@redhat.com>
Date: Wed Dec 6 20:16:09 2017 +0530
Revert "run-tests.sh: provide retry count option"
This change was actually causing failures to be reported as passing.
This reverts commit 4e798113229eab68e9e02364bb094a4ab8274c65.
Change-Id: I02b06e7f2af03419d922de8ad7e6948ae8cb8d06
commit 2c47466ac91636a27f7180b549e2fe7ceef9b08b
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Tue Dec 5 07:43:40 2017 -0800
features/quota: Fix brick crash in quota unlink callback
Change-Id: Iad16d7b2102376380eb0f6918111249af370aaeb
BUG: 1521014
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
commit 5f9d2528b02d4b4065b7e5b1156a57de21f52842
Author: Kevin Vigor <kvigor@fb.com>
Date: Fri Jan 6 13:19:35 2017 -0800
tests: Fix prove test bug-1292020.t
dd is doing a statfs and failing with ENOSPC instead of writign and
getting EDQUOTA. Make either error a success in this test.
> Signed-off-by: Kevin Vigor <kvigor@fb.com>
> Reviewed-on: http://review.gluster.org/16352
BUG: 1521116
Signed-off-by: ShyamsundarR <srangana@redhat.com>
Change-Id: I9f580d9e4a4dd293df55a1d954f86a9862fcae7b
commit 1ae4c3696a7641e4ef922c36bead7397d826e8ce
Author: Susant Palai <spalai@redhat.com>
Date: Tue Aug 22 13:44:52 2017 +0530
rio/everywhere: add icreate/namelink fop
icreate creates inode, while namelink links the basename to it's
parent gfid.
For now mkdir is the primary user of these fops. Better distribution is
acheived by creating the inode on ,(say) mds1 and linking the basename to it's
parent gfid on mds2. The inode serves readdirp, stat etc.
More details about the fops are present at:
https://review.gluster.org/#/c/13395/3/design/DHT2/DHT2_Icreate_Namelink_Notes.md
This backport of three patches from experimental branch.
1- https://review.gluster.org/#/c/18085/
2- https://review.gluster.org/#/c/18086/
3- https://review.gluster.org/#/c/18094/
Updates gluster/glusterfs#243
Change-Id: I1bd3d5a441a3cfab1acfeb52f15c6c867d362592
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 1860b6ae223d7b590e339268628d1570b2411a68
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Tue Dec 5 06:51:24 2017 -0800
cluster/dht: Fix build error due to switch statement on a boolean
Change-Id: Idf672b435e389baada732f609398404479306909
BUG: 1520974
commit cc34780b0d70634c2a259cd3d72c7da0605fb824
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Tue Dec 5 07:53:25 2017 -0800
rfc.sh: Update rfc.sh to use a custom origin via an env variable
Change-Id: I9efc6a7fbcbefad0c476cf69096b659485ed8906
BUG: 1521013
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
commit 8c7f1219134acf75b0b04f922ccfbc4d1b3367d4
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Dec 5 11:03:42 2017 +0530
cluster/ec: Fix bugs in stripe-cache feature
1 - This patch fixes a bug in ec_update_stripe()
that prevented some stripes to be updated after a write.
2 - This patch also include code modification for the
case in which a file does not exist and we write on
unaligned offset and user size, the last stripe on
which "end" will fall should also be cached.
Change-Id: I069cb4be1c8d59c206e3b35a6991e1fbdbc9b474
BUG: 1520758
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 13f280c5f597420b1050a219778c45d66cfabb26
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Dec 1 08:33:50 2017 -0500
run-tests.sh: provide retry count option
and default it to 5.
With this change, if any test fails due to timing issues (because of
slower/faster VM etc), there is a retry logic which gets triggered.
Many times, if a test successfully fails more than 5 times, there may
be a genuine issue with it, one should take a serious look at the
failing test.
Change-Id: Ia88e3293fd2724b0f9f09d8bc026560792fc1578
BUG: 1517961
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 62bf8d804e9fd821403a0c3219113a4b7a394531
Author: Poornima G <pgurusid@redhat.com>
Date: Sat Nov 18 15:19:13 2017 +0530
libglusterfs: Add put fop
Problem: It had been a longtime request to implement put fop
in gluster. put fop in gluster may not have the exact sementics
of HTTP PUT, but can be easily extended to do so. The subsequent
patches, will contain more semantics on the put fop and its
guarentees.
Why compound fop framework is not used for put?
Compound fop framework currently doesn't allow compounding of
entry fop and inode fops, i.e. fops on multiple inodes cannot be
combined in compound fop.
Updates #353
Change-Id: Idb7891b3e056d46d570bb7e31bad1b6a28656ada
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit a8325a23c7ad5ae92a5c365bfecf09d4300c04f2
Author: ShyamsundarR <srangana@redhat.com>
Date: Tue Nov 28 18:51:00 2017 -0500
posix: Reorganize posix xlator to prepare for reuse with rio
1. Split out entry and inode/fd based FOPs into
separate files from posix.c
2. Split out common routines (init, fini, reconf,
and such) into its own file, from posix.c
3. Retain just the method assignments in posix.c
(such that posix2 for RIO can assign its own methods in
the future for entry operations and such)
4. Based on the split in (1) and (2) split out
posix-handle.h into 2 files, such that macros that are
needed for inode ops are in one and rest are in the other
If the split is done as above, posix2 can compile with
its own entry ops, and hence not compile, the entry ops
as split in (1) above.
The split described in (4) can again help posix2 to
define its own macros to make entry and inode handles,
thus not impact existing POSIX xlator code.
Noted problems
- There are path references in certain cases where
quota is used (in the xattr FOPs), and thus will fail
on reuse in posix2, this needs to be handled when we
get there.
- posix_init does set root GFID on the brick root,
and this is incorrect for posix2, again will need
handling later when posix2 evolves based on this
code (other init checks seem fine on current inspection)
Merge of experimental branch patches with the following
gerrit change-IDs
> Change-Id: I965ce6dffe70a62c697f790f3438559520e0af20
> Change-Id: I089a4d9cf470c2f9c121611e8ef18dea92b2be70
> Change-Id: I2cec103f6ba8f3084443f3066bcc70b2f5ecb49a
Fixes gluster/glusterfs#327
Change-Id: I0ccfa78559a7c5a68f5e861e144cf856f5c9e19c
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 1ce53de6eeeb9a5bcb3da12980572ae8ac7451f3
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Thu Nov 2 15:09:37 2017 +0530
storage/posix : options to override umask
Options "create-mask" and "create-directory-mask" are added to
remove the mode bits set on a file or directory when its created.
Default value of these options is 0777.
Options "force-create-mode" and "force-create-directory" sets
the default permission for a file or directory irrespective of
the clients umask.
Default value of these options is 0000.
Command to set option:
volume set <volume name> storage.<option-name> <value>
The valid value range from 0000 to 0777.
Updates #301
Change-Id: Ia33d13f2117202ca55a056c747ccc3674eb8bae1
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit afc3047d35fdef98eeb709a47d2466fa9818cf9d
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Sep 19 09:44:55 2017 +0530
cluster/dht: populate inode in dentry for single subvolume dht
... in readdirp response if dentry points to a directory inode. This
is a special case where the entire layout is stored in one single
subvolume and hence no need for lookup to construct the layout
Change-Id: I44fd951e2393ec9dac2af120469be47081a32185
BUG: 1492625
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit eb0e2684dc0c4bea9468fa5d8565a15814a3d979
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Sep 18 16:01:34 2017 +0530
cluster/dht: don't overfill the buffer in readdir(p)
Superflous dentries that cannot be fit in the buffer size provided by
kernel are thrown away by fuse-bridge. This means,
* the next readdir(p) seen by readdir-ahead would have an offset of a
dentry returned in a previous readdir(p) response. When readdir-ahead
detects non-monotonic offset it turns itself off which can result in
poor readdir performance.
* readdirp can be cpu-intensive on brick and there is no point to read
all those dentries just to be thrown away by fuse-bridge.
So, the best strategy would be to fill the buffer optimally - neither
overfill nor underfill.
Change-Id: Idb3d85dd4c08fdc4526b2df801d49e69e439ba84
BUG: 1492625
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 9e0a86c8cfa60530578e47e5cf324666a7231563
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Mon Nov 20 14:06:56 2017 +0530
glusterd:buffer_size_warning coverity fixes
Fixes Issues :15,17,18,19,24,38
Change-Id: Ib09d319308e4ef7dfbdd5e49e16064d4f55a54f9
BUG: 789278
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit 8fa82a8bbdaf8d1f76eb70ade3e3c83f489a31dd
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue Nov 28 11:26:10 2017 +0530
posix: Convert posix_fs_health_check asynchrnously to save timestamp
Problem: Sometime posix_fs_health_check thread is blocked on write/read
call while backend device deleted abruptly.
Solution: To resolve it convert code to update timestamp asynchrnously.
BUG: 1501132
Change-Id: Id68ea6a572bf68fbf437e1d9be5221b63d47ff9c
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit b5524cd0b00cfd16198afa541e977e4134b50f86
Author: hari gowtham <hgowtham@redhat.com>
Date: Fri Nov 24 11:47:01 2017 +0530
Tier: Stop tierd for detach start
Problem: tierd was stopped only after detach commit
This makes the detach take a longer time. The detach
demotes the files to the cold brick and if the promotion
frequency is hit, then the tierd starts to promote files to
hot tier again.
Fix: stop tierd after detach start so the files get
demoted faster.
Note: the is_tier_enabled was not maintained properly.
That has been fixed too. some code clean up has been done.
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Change-Id: I532f7410cea04fbb960105483810ea3560ca149b
BUG: 1446381
commit e626159ab666161459ffb824e80ef1e925c9391c
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Nov 29 18:24:23 2017 +0530
tests: Fix a broken test case
Issue: When using statedump command to take statedump of the
gfapi process, we specify the following things:
$gluster volume statedump <volname> client <host>:<pid>
pid: Pid of the gfapi application
host: This should be the IP/hostname as seen by the glusterd,
the gfapi application is connected to.
In this test case, if gfapi application is running locally,
and is connected to $H1 glusterd, the <host> need not be $H1.
<host> could be localhost, 127.0.0.1, 127.1.1.1 etc. based on
the configuration of the system. Hence use netstat to find the
right <host> value.
Change-Id: I6efb9d1ccaf9c6841a9ab7c9ebfecafc03c0bc5e
BUG: 1517961
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 0b2f2b5cbcca6a455d2039390278527cf6666d51
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Nov 30 19:09:42 2017 +0530
dht: coverity fix in dht-rebalance.c
Fixed UNUSED_VALUE warning in dht_migrate_file.
Issue ID: 526
From: http://download.gluster.org/pub/gluster/glusterfs/
static-analysis/master/glusterfs-coverity/2017-11-30-eb013e4c
Change-Id: I37395e8ce7088742501424fcce918f0ee8ab4f3d
BUG: 789278
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 37f3feb6ee1ba30764d64f5572684c726c71188b
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Wed Oct 25 11:42:37 2017 +0800
libglusterfs: use rwlock for fdtable
To resolve a fd from client requests, need to take a mutex lock for the
fdtable to do the lookup. When a client is busy doing read and write,
the mutex lock could introduce contention. Therefore, use rwlock instead
of mutex to reduce the contention.
Change-Id: Ic833aed738a178a7ea1abafed7eb13814989d28c
BUG: 1518582
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit 375146fee3b04faf99ae374ff4710d83249c66fb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Nov 27 15:07:05 2017 +0530
heal: Fix coverity scan dead-code report
Got following kind of scan issues:
*** CID 1382469: (DEADCODE)
/heal/src/glfs-heal.c: 1749 in main()
1744 break;
1745 case GF_SHD_OP_SBRAIN_HEAL_FROM_BRICK:
1746 ret = glfsh_heal_from_brick (fs, top_subvol, &rootloc,
1747 hostname, path, file);
1748 break;
>>> CID 1382469: (DEADCODE)
>>> Execution cannot reach this statement: "case GF_SHD_OP_INVALID:".
Change-Id: I184da785893cb3e281b21f2d4fcdd2e5452102e6
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 52c47ed072995485e7dc851edf7f9331eadd29c4
Author: hari gowtham <hgowtham@redhat.com>
Date: Wed Nov 29 11:23:40 2017 +0530
tests: fix for bug-1260185-donot-allow-detach-commit-unnecessarily.t failure
problem: detach commit was issues before detach start was completed.
fix: wait for detach start to finish and then detach commit.
Change-Id: I639962be6de6dbd1512f0a5617050d1e6872eac8
BUG: 1517961
Signed-off-by: hari gowtham <hgowtham@redhat.com>
commit 0b8190e2c7d568f88ee69c13c12f10865b1ac766
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Nov 28 14:44:46 2017 +0530
xlator: provide a xlator_api_t structure to include all exported options
each translator from now on can have just 1 symbol exported called
'xlator_api', which has all the required fields in it.
Updates: #164
Change-Id: I48d54f5ec59fee842b1d55877e3ac5e9ec9b6bdd
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 6a72e585f9247df3a031a5e7f6389ff0fb38be5c
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Nov 27 01:28:38 2017 -0500
geo-rep: Fix access-mount geo-rep config
Fix access-mount and slave-access-mount
configs.
Change-Id: Ib586677755e76a51b9f20093e441b72789b4fecc
Signed-off-by: Kotresh HR <khiremat@redhat.com>
BUG: 1517633
commit 808a3ac85e088bf44b6418d2e49a5636d8c0db3a
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Nov 29 12:03:48 2017 +0530
posix: Change GD_OP_VERSION to 3_13_0 from 3_12_0 for storage.reserve
Problem: Change GD_OP_VERSION to 3_13_0 from 3_12_0 for option storage.reserve
Solution: Actually feature was merged in 3.13.0 branch so GD_OP_VERSION needs
to change from 3_12_0 to 3_13_0
BUG: 1518508
Change-Id: I5856ab3447b465879ec068cecb0933b91dd697f9
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit bf8509bb2f88c406a343ff552333a2efe0e4c307
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Nov 29 15:01:23 2017 +0530
cluster/ec: Modify OP_VERSION to 4.0.0 for stripe cache option
Change-Id: I991eaeb979497a1bf056b5871284274f959f36f2
BUG: 1471753
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit af87a44827c9375681279c9e3f83a86df95bbefb
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Nov 29 13:17:37 2017 +0530
glusterd: revert coverity fix for freeing key_dup
key_dup can't be freed here as the same is referenced at the
gd_mgmt_v3_unlock_timer_cbk.
Change-Id: I85667f98c82d1acebcce59137dfc0dd1ca93b4eb
BUG: 789278
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 8be3bc3a9ba7e5759a74989393ac4160f789c779
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Nov 29 12:03:48 2017 +0530
posix: Change GD_OP_VERSION to 3_13_0 from 3_12_0 for storage.reserve
Problem: Change GD_OP_VERSION to 3_13_0 from 3_12_0 for option storage.reserve
Solution: Actually feature was merged in 3.13.0 branch so GD_OP_VERSION needs
to change from 3_12_0 to 3_13_0
BUG: 1518508
Change-Id: I3890a3e921847d896465ce456fee003efaeb0c61
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 7a9c8ab98d93762c772e9fce0802516077b91c50
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri Nov 3 09:55:53 2017 +0530
posix: Fix coverity issues in several posix functions
Fixes issues 528, 763, 778, 792, 793, 86, 28, 29, 30, 39, 42, 769, 783,
794, 795 from the report at [1].
[1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Note: Apart from coverity resolve other issues
in posix_get(f)xattr more cleaner way.
BUG: 789278
Change-Id: If0737492198481ad7a8d75a3801c862fd61b8c6e
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 4573bf2d1ab028f232cfe5f2baffbb88978fd5f8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Nov 27 09:50:32 2017 +0530
cluster-syncop: Address comments in 3ad68df725ac32f83b5ea7c0976e2327e7037c8c
Change-Id: I325f718c6c440076c9d9dcd5ad1a0c6bde5393b1
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit da9b4b3eaf27562f47731728b41fda162a889016
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Oct 10 18:52:57 2017 +0530
features/bitrot: Add default value for stub export option
Updates #302
Change-Id: Ife78e15ad6300f09a820cbc25f43f214dc5e611d
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 6f5a9d6cb683d17c9f7616b4c88fb109ed9e1a08
Author: Nigel Babu <nigelb@redhat.com>
Date: Wed Nov 29 12:45:15 2017 +0530
tests: Renable basic/afr/split-brain-favorite-child-policy.t
This test was failing due to an infra issue. The infra issue is now
fixed.
BUG: 1517961
Change-Id: I09dfab9c0a3ebe73c738222e6269d9e35c85eddb
Signed-off-by: Nigel Babu <nigelb@redhat.com>
commit 4ff9af67d920f889d1aa100aabef4a6123c45b31
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Oct 10 18:58:35 2017 +0530
features/changelog: Add default values for options
Updates #302
Change-Id: I806e42b658114b242b787491400332299dbdbf77
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit b11f9ba365626af7b7ad054152e8908a958d2a19
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Aug 31 15:49:51 2017 +0530
quick-read: redefine options
Updates: #302
Change-Id: If25996a080d69e9ac819ca771a5774ccdab6e1ce
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit ced3edd3803d5f6ad524bc41588f3e52e7729591
Author: James Le Cuirot <chewi@gentoo.org>
Date: Mon Nov 20 20:56:34 2017 +0000
build: Use pkg-config to get libtirpc flags
This benefits cross-compiling and other exotic setups.
Change-Id: Id9f168728d96264ccab23d2e618fa2b4003455a3
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
commit 0a530220ca34b9ef0a6fb4420518b4089c335ec1
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Tue Nov 7 22:21:22 2017 -0500
gfapi: avoid nameless lookup when inode_find success
Ganesha calls pub_glfs_h_create_from_handle always with stat != NULL,
for inode_find success, a nameless lookup seems unnecessary.
Change-Id: I1242deefe8ff4af15a98cc3af7824233e24d62ad
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
commit 0195ca9b8124d594457d16ee021becc2ce648c0b
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Nov 27 23:56:50 2017 +0530
tests: mark currently failing regression tests as known issues
Change-Id: If6c36dc6c395730dfb17b5b4df6f24629d904926
BUG: 1517961
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit dba10f5b7358397504a7b5cbd8c5124638f1c11c
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Aug 14 10:15:45 2017 +0530
rpc: Eliminate conn->lock contention by using more granular locks
rpc_clnt_submit() acquires conn->lock before call to
rpc_transport_submit_request() and subsequent queuing of frame into
saved_frames list. However, as part of handling RPC_TRANSPORT_MSG_RECEIVED
and RPC_TRANSPORT_MSG_SENT notifications in rpc_clnt_notify(), conn->lock
is again used to atomically update conn->last_received and conn->last_sent
event timestamps.
So when conn->lock is acquired as part of submitting a request,
a parallel POLLIN notification gets blocked at rpc layer until the request
submission completes and the lock is released.
To get around this, this patch call clock_gettime (instead to call gettimeofday)
to update event timestamps in conn->last_received and conn->last_sent and to
call clock_gettime don't need to call mutex_lock because it (clock_gettime)
is thread safe call.
Note: Run fio on vm after apply the patch, iops is improved after apply
the patch.
Change-Id: I347b5031d61c426b276bc5e07136a7172645d763
BUG: 1467614
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit f923eba81fe37a39a99bef6fad52cfda5ac3fa07
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Nov 28 11:49:12 2017 +0530
tests: fix bug-1432542-mpx-restart-crash.t spurious failure
Change-Id: Ied1215bfec0ccf2ec8ee55a0aaf618517b67bd55
BUG: 1517961
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 41aca9e98af71da0fd55ac3df01ead52b0cf0412
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Wed Nov 22 15:12:26 2017 +0530
cluster/ec: EC DISCARD doesn't punch hole properly
Problem:
DISCARD operation on EC volume was punching hole of lesser
size than the specified size in some cases.
Solution:
EC was not handling punch hole for tail part in some cases.
Updated the code to handle it appropriately.
BUG: 1516206
Change-Id: If3e69e417c3e5034afee04e78f5f78855e65f932
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit a1aef32d32d8c4cfa4073ddfb63f43164f74e7e7
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Wed Nov 22 11:10:32 2017 +0100
cluster/ec: Prevent self-heal to work after PARENT_DOWN
When the volume is being stopped, PARENT_DOWN event is received.
This instructs EC to wait until all pending operations are completed
before declaring itself down. However heal operations are ignored
and allowed to continue even after having said it was down.
This may cause unexpected results and crashes.
To solve this, heal operations are considered exactly equal as any
other operation and EC won't propagate PARENT_DOWN until all
operations, including healing, are complete. To avoid big delays
if this happens in the middle of a big heal, a check has been
added to quit current heal if shutdown is detected.
Change-Id: I26645e236ebd115eb22c7ad4972461111a2d2034
BUG: 1515266
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit c2fcfb25a020c5544b3376359253f0c70eb3131c
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Oct 10 15:55:38 2017 +0530
protocol/client: Update xlator options table
Updates #302
Change-Id: Ia78e5d8f7b9ee6410965296808ad316c3cfb1d61
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 327249f057d3f52eac7ac3dc75382cc8c656cb85
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Nov 27 00:18:03 2017 +0530
cli: commands are missing in man page
adding missed commands to gluster manual page.
Change-Id: I2e5eb1b3929241275ee7a046c5e3d45a5aa5c4a2
BUG: 1517554
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit e11ead2fd7eed02b16a48d715f2ff83e037532af
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Mon Nov 13 13:47:53 2017 +0530
snapshot : snapshot creation failed after brick reset/replace
Problem : snapshot creation was failing after brick reset/replace
Fix : changed code to set mount_dir value in rsp_dict during prerequisites
phase i.e glusterd_brick_op_prerequisites call and removed form prevalidate
phase.
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
Change-Id: Ief5d0fafe882a7eb1a7da8535b7c7ce6f011604c
BUG: 1512451
commit c765fe775bcf00307874973408d39e7cb16f8339
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Nov 27 22:18:33 2017 +0530
tests: Spurious failure multiplex-limit-issue-151.t
A timing issue caused the remove-brick commit to fail.
Replaced 'remove-brick commit' with 'remove-brick force'.
Change-Id: I69144b2f7be34095dbd3a7d182e0bf01b27fb0a4
BUG: 1517904
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit ed2d95dc019bafd9f31bb09aac1a0974ab817ba2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Nov 24 17:54:35 2017 +0530
afr: volume option fixes for GD2
This patch takes care of volume options exposed via the CLI.
Updates #302
Change-Id: I6fd1645604928f6b9700e2425af4147cc6446a3a
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit c5c0c329ca451be842302d7d895971e379a1e35f
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Aug 31 16:00:53 2017 +0530
features/read-only: Redefine the options for read-only and worm
With https://review.gluster.org/18059 introducing new fields into the
volume_option structure, this change takes care of the changes required
at the read-only and worm side.
Updates #302
Change-Id: Ie9d38eed6739a8ef229c462448532354e275af7c
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit ad4e8be58ada82a2c044bcb1c32a4a6717884690
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Oct 10 17:38:52 2017 +0530
features/index: Update xlator options table
Updates #302
Change-Id: I2bc99394d89e94ae6aeee9de8d85a3d09991fad9
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 785610da67ff02b19e5d07377e5c775ec15d0705
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Nov 24 12:11:16 2017 +0530
geo-rep: Fix slave side custom config issue
Slave gsyncd will not use session config files, Slave configs are
stored in Master config file itself and sent as argument to slave
gsyncd.
With this patch, gconf default values are overwritten if argument
name starts with "slave-"
Change-Id: Iebc51f52232c0cd30b29199f03015f97b70ce537
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1517068
commit 6f8219532a299af145e61ee57719df709fc1bb40
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Nov 27 04:42:54 2017 +0530
tests/basic/inode-leak.t: mark as known issue
Mainly because the tests are consistently taking more than
20mins for each runs.
One of the samples from a regression run:
> /tests/basic/inode-leak.t - 1643 second
Change-Id: If11572203c702f64847794f6d578a6dc19a0dee8
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 380acb9a5db371576c1ac6d98df283116a74de6e
Author: Prashant D <pdhange@redhat.com>
Date: Wed Nov 8 22:09:42 2017 +1100
extras/devel-tools: Fix print-backtrace script
Problem:
If cpio version is less 2.11 then cpio command failing with
unrecognised option --directory.
Solution:
Check the cpio version and run rpm2cpio/cpio with or without
-D or --directory option.
Fixes : #359
Change-Id: Ibd440207231807dab1b58291ab661857094f1a4a
BUG: 1510874
Signed-off-by: Prashant D <pdhange@redhat.com>
commit 753a0e261bf669c8c0609a43706fd619e1251527
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Nov 16 09:47:00 2017 +0100
libglusterfs: fix the call_stack_set_group() function
- call_stack_set_group() will take the ownership of passed
buffer from caller;
- to indicate the change, its signature is changed from
including the buffer directly to take a pointer to it;
- either the content of the buffer is copied to the
groups_small embedded buffer of the call stack, or
the buffer is set as groups_large member of the call
stack;
- the groups member of the call stack is set to,
respectively, groups_small or groups_large, according
to the memory management conventions of the call stack;
- the buffer address is overwritten with junk to effectively
prevent the caller from using it further on.
Also move call_stack_set_group to stack.c from stack.h
to prevent "defined but not used [-Wunused-function]"
warnings (not using it anymore in call_stack_alloc_group()
implementation, which saved us from this so far).
protocol/server: refactor gid_resolve()
In gid_resolve there are two cases:
either the gid_cache_lookup() call returns
a value or not. The result is caputured in
the agl variable, and throughout the function,
each particular stage of the implementation
comes with an agl and a no-agl variant.
In most cases this is explicitly indicated
via an
if (agl) {
...
} else {
...
}
but some of this branching are expressed via
goto constructs (obfuscating the fact we stated
above, that is, each particular stage having
an agl/no-agl variant).
In the current refactor, we bring the agl
conditional to the top, and present the
agl/non-agl implementations sequentially.
Also we take the opportunity to clean up and
fix the agl case:
- remove the spurious
gl.gl_list = agl->gl_list;
setting, as gl is not used in the agl caae
- populate the group list of call stack from
agl, fixing thus referred BUG.
Also fixes BUG: 1513920
Change-Id: I61f4574ba21969f7661b9ff0c9dce202b874025d
BUG: 1513928
Signed-off-by: Csaba Henk <csaba@redhat.com>
commit f1646294739257fc3083e2413c37e58912fac252
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Nov 23 15:28:07 2017 +0530
geo-rep: JSON output for status and config
For Glusterd2 integration, JSON output of status and config
is very useful from gsyncd
Fixes: #361
Change-Id: I53c61f19033ad4ac601ea49469e4e7c7c8e9af3d
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit d8d424103abd0354140c51fe28c0354994ad9a60
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Oct 22 20:54:23 2017 +0200
xdr: comply with RFC4506
Change-Id: I03098a54b8d37f6201129007cf31b31d97c30a23
BUG: 1336889
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 53eb97229fbb5fcb302718d2b09e10ed354468ab
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Nov 21 15:00:42 2017 +0530
storage/posix: Update xlator options table
Updates #302
Change-Id: Ib8100c69267202266a7f03d0d632d45afb61d946
Signed-off-by: Kaushal M <kaushal@redhat.com>
commit b433f838786d9d93d097a1c6043f8d182c03b191
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Nov 13 07:03:36 2017 +0530
afr: coverity fixes
1.afr_discover_do: COPY_PASTE_ERROR
2.afr_fav_child_reset_sink_xattrs_cbk: REVERSE_INULL
3.afr_fop_lock_proceed: UNUSED_VALUE
4.afr_local_init: CHECKED_RETURN
5.afr_set_split_brain_choice: REVERSE_INULL
6.__afr_inode_write_finalize: FORWARD_NULL
7.afr_refresh_heal_done: REVERSE_INULL
8.afr_xl_op:UNUSED_VALUE
9.afr_changelog_populate_xdata: DEADCODE
10.set_afr_pending_xattrs_option: RESOURCE_LEAK
Note:
RESOURCE_LEAK complaints about afr_fgetxattr_pathinfo_cbk,
afr_getxattr_list_node_uuids_cbk and afr_getxattr_pathinfo_cbk seem to
be false alarms.
Change-Id: Ia4ca1478b5e2922084732d14c1e7b1b03ad5ac45
BUG: 789278
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit 8620e4e4b65668d939feb4dbbe1d0a9604936cc2
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Tue Nov 14 16:45:07 2017 +0100
cluster/ec: Remove unneded tests
To reduce regression test execution time, some of the EC tests
have been removed to save time. These tests were only doing the
same than other existing tests but with different volume
configurations.
I keep ec-3-1.t, ec-4-1.t, ec-5-2.t and ec-6-2.t because they
cover all the combinations of the most important cases:
* Configurations with redundancy 1 and redundancy > 1
* Configurations with #fragments = power of 2 and not a power of 2
Change-Id: I0b1d15b50428b605c6a1c96df12d8054556b1f23
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit 9269b564a48c1fcb040ed8b481b9bb13ffd53dc7
Author: hari gowtham <hgowtham@redhat.com>
Date: Wed Nov 15 15:54:51 2017 +0530
tier: coverity fixes in tier.c
fixes coverity issues:
127, 83, 312, 314, 48, and 506
from https://download.gluster.org/pub/gluster/glusterfs/static-analysis
/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: Ifb206a8758790faf96619bcc9961dcf169aaad25
BUG: 789278
Signed-off-by: hari gowtham <hgowtham@redhat.com>
commit f26c695260d23ab5e2d89df51db08e831003d092
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri Oct 6 15:13:02 2017 +0530
cluster/dht: Serialize mds update code path with lookup unwind in selfheal
Problem: Sometime test case ./tests/bugs/bug-1371806_1.t is failing on
centos due to race condition between fresh lookup and setxattr fop.
Solution: In selfheal code path we do save mds on inode_ctx, it was not
serialize with lookup unwind. Due to this behavior after lookup
unwind if mds is not saved on inode_ctx and if any subsequent
setxattr fop call it has failed with ENOENT because
no mds has found on inode ctx.To resolve it save mds on
inode ctx has been serialize with lookup unwind.
BUG: 1498966
Change-Id: I8d4bb40a6cbf0cec35d181ec0095cc7142b02e29
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 5430c9871150a7b4a5665f2b34de21bf6df37fce
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Nov 22 17:03:11 2017 +0530
rpc-lib: coverity fixes
Scan URL:
https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-11-10-0f524f07/html/
ID: 9 (BAD_SHIFT)
ID: 58 (CHECKED_RETURN)
ID: 98 (DEAD_CODE)
ID: 249, 250, 251, 252 (MIXED_ENUMS)
ID: 289, 297 (NULL_RETURNS)
ID: 609, 613, 622, 644, 653, 655 (UNUSED_VALUE)
ID: 432 (RESOURCE_LEAK)
Change-Id: I2349877214dd38b789e08b74be05539f09b751b9
BUG: 789278
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit c5551f41026fc594c38318af798e7efcafb0a2c6
Author: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Date: Thu Aug 25 16:35:27 2016 +0530
tests : add a test to check if there is an inode leak
This test check if there is inode leak in bricks.
lru_size for mount is expected to be zero. active_size for mount
is expected to be 1 which is of root.
Change-Id: I18762b4255af411f1b55c0be98451c8ef1b35478
BUG: 1370116
Signed-off-by: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
commit 1704a384c2b97c2a403d5053101aedd8c56d5964
Author: Susant Palai <spalai@redhat.com>
Date: Tue Oct 24 18:35:20 2017 +0530
cluster/dht: make rebalance use truncate incase
..
the brick file system does not support fallocate.
Change-Id: Id76cda2d8bb3b223b779e5e7a34f17c8bfa6283c
BUG: 1488103
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 6123b4858ec1148783de13dfe9f3108daf509947
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Mon Nov 20 10:51:09 2017 +0100
features/locks: Fix memory leaks
Change-Id: Ic1d2e17a7d14389b6734d1b88bd28c0a2907bbd6
BUG: 1515161
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit cb69ec5a3f74432e3b6a18525353646f30093ffd
Author: karthik-us <ksubrahm@redhat.com>
Date: Tue Nov 21 19:01:36 2017 +0530
cluster/afr: Print heal info summary output in stream fashion
Problem:
The heal info summary was printing the output at the end after
crawling for pending heal entries completes on all the bricks.
Fix:
Printing the output immediately after the crawl on individual brick
completes, so that it won't give the impression of CLI being hung.
Change-Id: Ieaf5718736a7ee6837bac02bd30a95836e605dab
BUG: 1506104
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 950bf09dae22685e8d857320d2cb977914ad0703
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 11 18:58:04 2017 +0530
libglusterfs: Handle FS errors gracefully
Problem:
FS sometimes doesn't give the expected return values. We need our common
functions to guard against this.
Example BUG: https://bugzilla.redhat.com/show_bug.cgi?id=864401
Fix:
When the return value is not as per specification, change the return value
to -1 and errno to EIO
BUG: 1469487
Change-Id: I14739ab2e5ae225b1a91438b87f8928af56f2934
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 7aeaa88352323a12bda70e8a54bdc197e7b22ccf
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Nov 17 07:20:21 2017 +0530
ec: Use tiebreaker_inodelk where necessary
When there are big directories or files that need to be healed,
other shds are stuck on getting lock on self-heal domain for these
directories/files. If there is a tie-breaker logic, other shds
can heal some other files/directories while 1 of the shds is healing
the big file/directory.
Before this patch:
96.67 4890.64 us 12.89 us 646115887.30us 340869 INODELK
After this patch:
40.76 42.35 us 15.09 us 6546.50us 438478 INODELK
Fixes gluster/glusterfs#354
Change-Id: Ia995b5576b44f770c064090705c78459e543cc64
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 1b4c3529fdee645a65ab659c62e9e605d7b6b371
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Nov 17 07:12:42 2017 +0530
cluster-syncop: Implement tiebreaker inodelk/entrylk
In this implementation, inodelk/entrylk will be tried for the subvols
given with trylock. In this attempt if all locks are obtained, then
inodelk is successful, otherwise, if it gets success on the first
available subvolume, then it will go for blocking lock, where as other
subvolumes will not try and this acts as tie-breaker.
Updates gluster/glusterfs#354
Change-Id: Ia2521b9ccb81a42bd6104ab21f610f761ba2b801
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit f00424c91c0a0cc64223339035e952d24b5153b6
Author: James Le Cuirot <chewi@gentoo.org>
Date: Mon Nov 20 20:44:45 2017 +0000
build: Allow libtirpc to be explicitly requested
Some distributions like Gentoo no longer include the RPC stuff in
their glibc packages.
Change-Id: Ic47065e9c2f5a0ccd860df9d7185eff59990ff10
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
commit c99097052f11e7f4535c4a4f9c430bd85e782162
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Nov 2 13:26:01 2017 +0530
cli: Fix coverity errors for cli-rpc-ops.c
Fixes issues 147, 168, 169, 219, 715, 718, 766, 768, 772, 774, 776, 782,
790 from the report at [1].
Also, fixed some other possible static checker errors as well.
[1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
BUG: 789278
Change-Id: I985cea1ef787d239b2632d5a7f467070846f92e4
Signed-off-by: Kaushal M <kaushal@redhat.com>
commit 387ed941b42485ea6895079fd20b190ecf23ad61
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Nov 20 17:55:35 2017 +0530
cluster/dht: Coverity fixes for dht-rebalance.c
Warning Functions
DEADCODE gf_defrag_handle_migrate_error
gf_defrag_get_entry
gf_defrag_process_dir
gf_defrag_start_crawl
dht_migrate_file
UNUSED_VALUE migrate_special_files
dht_migrate_file
FORWARD_NULL gf_tier_do_fix_layout
Change-Id: I6f408585b83a267581a4273dae7c22b8993163d5
BUG: 789278
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 59acd72187ac2dcac1cae9109fa33e4a7b3e2b3a
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Nov 17 10:35:26 2017 +0530
protocol/server: use common function to reduce duplicate code
Change-Id: Ifad0a88245fa6fdbf4c43d813b47c314d2c50435
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 6ae4d36c66c67e0ded42a27a39824bff362e86b9
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Nov 14 17:02:52 2017 +0100
Disable gfid2path by default on NetBSD
NetBSD storage of extended attributes for UFS1 badly scales when
the list of extended attributes names rises. gfid2path can add as
many extended attributes names as we have files, hence we keep it
disabled for performance sake.
Change-Id: Id77b5f5ceb4d5eba1b3362b4b9fc693450ffbc2b
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
BUG: 1129939
commit 002843e77966e51564db99727c45e67ba64f31eb
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Nov 3 15:41:34 2017 +0530
timer: Fix possible race during cleanup
As mentioned in bug1509189, there is a possible race
between gf_timer_cancel(), gf_timer_proc() and
gf_timer_registry_destroy() leading to use_after_free.
Problem:
1) gf_timer_proc() is called, locks reg, and gets an event.
It unlocks reg, and calls the callback.
2) Meanwhile gf_timer_registry_destroy() is called, and removes
reg from ctx, and joins on gf_timer_proc().
3) gf_timer_call_cancel() is called on the event being
processed. It cannot find reg (since it's been removed from reg),
so it frees event.
4) the callback returns into gf_timer_proc(), and it tries to free
event, but it's already free, so double free.
Solution:
The fix is to bail out in gf_timer_cancel() when registry
is not found. The logic behind this is that, gf_timer_cancel()
is called only on any existing event. That means there was a valid
registry earlier while creating that event. And the only reason
we cannot find that registry now is that it must have got set to
NULL when context cleanup is started.
Since gf_timer_proc() takes care of releasing all the remaining
events active on that registry, it seems safe to bail out
in gf_timer_cancel().
Change-Id: Ia9b088533141c3bb335eff2fe06b52d1575bb34f
BUG: 1509189
Reported-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 7e32d9cf2f3fe307e4b324fd0816ef182316003e
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Mon Nov 20 00:08:40 2017 +0530
rpc/rpc-transport: dead code coverity fix
issue: Execution cannot reach this statement: "iobuf_unref(iobuf);"
function: gf_rdma_do_reads
fix: removed the statement and the corresponding 'if' block
Change-Id: Ia21b872996dbc8e0a66c8c28dd90b367d3c9aadd
BUG: 789278
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit 513b2eb3ff0890ae86e79dd305b8b97ca4bc9ca8
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Wed Nov 15 15:17:00 2017 +0530
libglusterfs:checked return coverity fix
Problem:Calling "gf_thread_create" without checking return value.
Fix:The return value is saved and checked if gf_thread_create fails.
Change-Id: Ibdaac1c90a1a8369e92ade50825598b041063da8
BUG: 789278
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit 8171489c0b30830c8f03e3f031cfed796c54882e
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Sun Nov 19 23:53:28 2017 +0530
cluster/dht: dead code coverity fix
issue: Execution cannot reach this statement: "call_stub_destroy(stub);"
function: dht_mkdir_hashed_cbk
fix: removed the statement and the corresponding 'if' condition block.
Change-Id: I3e31056ee489ede6864e51a8e666edc7da3c175f
BUG: 789278
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit 1514bb775e9ee7c3f34b05eda8ddfe34df69c971
Author: cholcombe973 <cholcombe973@review.gluster.org>
Date: Wed Nov 15 19:28:05 2017 +0000
Revert "debug/io-stats: Append stats for each interval in the same file"
This reverts commit fc73ae5f81ef5926e3dc2311db116250d0f2a321.
See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1513692
Change-Id: I00d5989b042d4e345621c596d5370d324948557f
Bug: 1513692
Signed-off-by: Chris Holcombe <xfactor973@gmail.com>
commit 96e0e228eeba43820c75d7a2905acce11bd2c361
Author: Vishal Pandey <vishpandey2014@gmail.com>
Date: Thu Nov 2 19:16:26 2017 +0530
features/worm: new config option to manage deletion of Worm files.
Add a new configuration option worm-files-deletable to
file-level Worm in order to control behaviour of Worm files upon deletion.
Steps to Test:
1. Add all the configuration options to a volume to activate file-level-worm
2. Option features.worm-files-deletable is set to 1 by default.
3. Create a new file and wait for the retention time to expire.
4. After retention time expires, do an truncate, rename, unlink, link
or write to send the file in Worm state.
5. After that do `rm -f filename`.
6. The file is successfully removed.
7. Repeat from step 2 by setting features.worm-files-deletable 0.
This time deletion should not be successful.
Change-Id: Ibc89861ee296e065330b93a9f9606be5da40af31
BUG: 1508898
Signed-off-by: Vishal Pandey <vishpandey2014@gmail.com>
commit a61d72cd03aefcb4c2ce7753d0b02d667beaa1db
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Apr 4 07:13:09 2016 -0400
rpc : Change the way client uuid is built
Problem:
Today the main users of client uuid are protocol layers, locks, leases.
Protocol layers requires each client uuid to be unique, even across
connects and disconnects. Locks and leases on the server side also use
the same client uid which changes across file migrations. Which makes the graph
switch and file migration tedious for locks and leases.
file migration across bricks becomes difficult as client uuid for the same
client, is different on the other brick.
The exact set of issues exists for leases as well.
Solution would be to introduce a constant in the client-uid string which
the locks and leases can use to identify the owner client across bricks.
Client uuid currently:
%s(ctx uuid)-%s(protocol client name)-%d(graph id)%s(setvolume count/reconnect count)
Proposed Client uuid:
"CTX_ID:%s-GRAPH_ID:%d-PID:%d-HOST:%s-PC_NAME:%s-RECON_NO:%s"
- CTX_ID: This is will be constant per client.
- GRAPH_ID, PID, HOST, PC_NAME(protocol client name), RECON_NO(setvolume count)
remains the same.
Change-Id: Ia81d57a9693207cd325d7b26aee4593fcbd6482c
BUG: 1369028
Signed-off-by: Susant Palai <spalai@redhat.com>
commit 44b31b4bf4b8881539820ff53d5d81629a48034b
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Tue Nov 14 20:12:37 2017 +0530
features/marker: coverity fix
issue: Calling "mq_inode_ctx_get" without checking return value
function: marker_rename_unwind
fix: typecasted the return value of function to void
Change-Id: I552b1d76df434dfc3d9c2273ec63ccc4b9f960f2
BUG: 789278
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit 214cf19210c2a2da948766a779e3d81576b2015d
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Nov 17 12:06:53 2017 +0530
cluster/dht: Don't set ACLs on linkto file
The trusted.SGI_ACL_FILE appears to set posix
ACLs on the linkto file that is a target of
file migration. This can mess up file permissions
and cause linkto identification to fail.
Now we remove all ACL xattrs from the results of
the listxattr call on the source before setting them
on the target.
Change-Id: I56802dbaed783a16e3fb90f59f4ce849f8a4a9b4
BUG: 1514329
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit df6d20e890040bf20b9c67170a38648413dcafc8
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Aug 16 18:01:17 2017 +0530
afr: add checks for allowing lookups
Problem:
In an arbiter volume, lookup was being served from one of the sink
bricks (source brick was down). shard uses the iatt values from lookup cbk
to calculate the size and block count, which in this case were incorrect
values. shard_local_t->last_block was thus initialised to -1, resulting
in an infinite while loop in shard_common_resolve_shards().
Fix:
Use client quorum logic to allow or fail the lookups from afr if there
are no readable subvolumes. So in replica-3 or arbiter vols, if there is
no good copy or if quorum is not met, fail lookup with ENOTCONN.
With this fix, we are also removing support for quorum-reads xlator
option. So if quorum is not met, neither read nor write txns are allowed
and we fail the fop with ENOTCONN.
Change-Id: Ic65c00c24f77ece007328b421494eee62a505fa0
BUG: 1467250
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit f59b6b1817c81e7a04c2028d7825383f8b8c3599
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Aug 16 17:26:48 2017 +0530
cluster/afr: Fix for arbiter becoming source
Problem:
When eager-lock is on, and two writes happen in parallel on a FD
we were observing the following behaviour:
- First write fails on one data brick
- Since the post-op is not yet happened, the inode refresh will get
both the data bricks as readable and set it in the inode context
- In flight split brain check see both the data bricks as readable
and allows the second write
- Second write fails on the other data brick
- Now the post-op happens and marks both the data bricks as bad and
arbiter will become source for healing
Fix:
Adding one more variable called write_suvol in inode context and it
will have the in memory representation of the writable subvols. Inode
refresh will not update this value and its lifetime is pre-op through
unlock in the afr transaction. Initially the pre-op will set this
value same as read_subvol in inode context and then in the in flight
split brain check we will use this value instead of read_subvol.
After all the checks we will update the value of this and set the
read_subvol same as this to avoid having incorrect value in that.
Change-Id: I2ef6904524ab91af861d59690974bbc529ab1af3
BUG: 1482064
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit bf148d33c1c2b2dd8d66c1005f7cfc431099cf2b
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Tue Nov 14 14:39:43 2017 +0530
features/changetimerecorder:unused value coverity fix
Problem : Overwritting the value of ret in extract_db_params.
Fix : The value is used in out.
Change-Id: Ib7bee999c6f19e0c83ef47deab61835977162bd5
BUG: 789278
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit 9c83d7830f398c875d5e53d3fba787d3861a77a3
Author: hari gowtham <hgowtham@redhat.com>
Date: Thu Nov 2 17:23:05 2017 +0530
tier/glusterd: coverity issues in glusterd-tier.c
Coverity issues fixed in this patch:
254, 256, 295, 791, 546
from: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/
master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I44b7d307a3434040125d8b1d6fb18221f30f678d
BUG: 789278
Signed-off-by: hari gowtham <hgowtham@redhat.com>
commit ff62a966e36dc292ab234b1f7f5b79b8b780cc81
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Aug 31 15:06:19 2017 +0530
Upcall: Add new GD2 fields to upcall xlator options
Add new fields used by GD2 to the upcall xlator options.
Updates #302
Change-Id: Ia684648aa06312ca9649f00af17575162adb4996
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit b5f11ca9dad86aa381cb2c6569d6fd75f684fa7b
Author: hari gowtham <hgowtham@redhat.com>
Date: Thu Aug 31 16:47:48 2017 +0530
features/changetimerecorder: xlators opts improvement for GD2
Updates: #302
Change-Id: Ib401eb6fa187ab2498de8b5cdf4686e388192208
Signed-off-by: hari gowtham <hgowtham@redhat.com>
commit 246a71eaa739d23a708a1115a9312624c847b724
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Oct 10 17:53:24 2017 +0530
protocol/server: Update xlator options table
Updates #302
Change-Id: Ifb604914a5d8b5c47ea2de0c026043b71a783387
Signed-off-by: Kaushal M <kaushal@redhat.com>
commit 5d214ba069eec91a997b9dcbbb5b24bff1e7c97c
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Aug 31 15:13:26 2017 +0530
features/changelog: xlators opts improvement for GD2
Updates: #302
Change-Id: Ibbf0f99d4b81a5e9a5ccee1889214b74f083a7db
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 22b01a3566acf3a935a2d8646ebde06f0a3c3c5c
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Aug 31 15:03:50 2017 +0530
barrier: redefine the options
With https://review.gluster.org/18059 introducing new fields into the
volume_option structure, this change takes care of the changes required
at the barrier side.
Updates #302
Change-Id: If991df10b130c762a44883668a00e49943a508f8
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit fc27fa969d224fd5046356412f588ccf4a563288
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Aug 31 07:06:28 2017 -0400
feature/bitrot: stub xlators opts for GD2
Updates #302
Change-Id: I320eabf0c83295e90a312316a8373ccf5bf91dc4
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 1444a3f47248ecb9a4f506551c6bf5220cdca76c
Author: Pranith Kumar <pkarampu@redhat.com>
Date: Thu Nov 2 16:19:17 2017 +0530
features/index: initialize the options properly
watchlists should not over-write values gathered in previous invocation.
Change-Id: I5634930d20e720ad6509b03a64360d7320800565
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit ad094fe7ba5c196000a0c9d635bfcfac028d2adc
Author: Ji-Hyeon Gim <potatogim@gluesys.com>
Date: Wed Nov 15 20:51:07 2017 +0900
mailmap: add mailmap entry for potatogim
Change-Id: I2dd0dbb1949a8cab0a40e08f39182366a8a44990
Signed-off-by: Ji-Hyeon Gim <potatogim@gluesys.com>
commit 52fac3c79327a0e2734a7df7e57874936178a503
Author: Ji-Hyeon Gim <potatogim@gluesys.com>
Date: Wed Nov 15 18:17:20 2017 +0900
who-wrote-glusterfs: add an alias for potatogim@potatogim.net
Change-Id: Ieb3d1910f0284bd951089c197abc569ae95e5bcd
Signed-off-by: Ji-Hyeon Gim <potatogim@gluesys.com>
commit fc4f821fb380e9fa5326d7993eae801bc64ce5da
Author: hari gowtham <hgowtham@redhat.com>
Date: Thu Nov 2 18:13:17 2017 +0530
tier: coverity fix for tier-common.c
fix for the coverity id:
258, 162
Change-Id: I35ba21e37e186b7c1ce54faf5b24f48858e6fc70
BUG: 789278
Signed-off-by: hari gowtham <hgowtham@redhat.com>
commit 67087ff9f1cd5c2bb46164e9438ad44ffd5b00b7
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Tue Nov 14 16:50:49 2017 +0530
fuse-lib: checked_return coverity fix
issue: Calling "chdir" without checking return value
function: gf_fuse_unmount_daemon
fix: typecasted return value of function to void.
Change-Id: I5f06fbe886a35c2d4c9f763eeb01771e9451f232
BUG: 789278
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit 7d258be39c8a79e2a00b89a5ddf267597b67081e
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Nov 8 09:29:49 2017 +0530
glusterd: Fix coverity issues in handshake module
This patch fixes coveruty issues 737,738,172,188,728,198,235,35.
Change-Id: I632ddc5edbfb03bc81ce27f02886b8e262c1d946
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 02e0243da167e89d9db471fc1011579cae34ea51
Author: Ji-Hyeon Gim <potatogim@gluesys.com>
Date: Wed Nov 15 18:13:18 2017 +0900
who-wrote-glusterfs: add gluesys.com to domain-map
Change-Id: Idfc62026ca50aaf8767f093b4daefd7119564a1f
Signed-off-by: Ji-Hyeon Gim <potatogim@gluesys.com>
commit 90fb5ff8aa1f9ef251b9715f865b2af40edf7a5d
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri Nov 10 14:47:31 2017 +0530
dict: Fix several coverity issues in dict
This patch fixes issues 230,592,593,110,63 from [1]
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Note: Resolve FORWARD_NULL coverity issue in glusterfs_ctx_new is
also fixed with this patch.
BUG: 789278
Change-Id: Ic4199a144a14cc9ead7366fb1c9699197141bc86
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 0d0f8b88a17f90ae4b2d65d1841651ef22733be3
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Thu Nov 9 15:15:37 2017 +0530
glusterd: Fix coverity issues in glusterd-handler.c
Fixes get-state CLI related coverity issues 477, 511, 515, 523,
526 and 527 from the report at [1]
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: Ieb6f64c9035b4d9338d9515de003d607b7a4e9bc
BUG: 789278
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
commit 4a49d27d68602b3aec7a535c708c84138b396390
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Oct 12 11:31:34 2017 +0530
features/changelog: Structured logging support
Structured logging infra is available in logging library with
issue #240. Log messages with dynamic content are identified and
converted to structured logging format(`gf_msg` to `gf_smsg` and
`gf_log` to `gf_slog`)
BUG: 1501054
Change-Id: I5fccc354730c07cb9ae444d0b959d1d72bd9be49
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit b2f061748d94e9014022d56fb03e8a70e0aeb30e
Author: Kamal Mohanan <kmohanan@redhat.com>
Date: Fri Nov 3 12:24:32 2017 +0530
xlators/features/trash: STRING_OVERFLOW Coverity fixes in trash.c
Replaced strcpy, strcat with strncpy, strncat calls.
Change-Id: Ibf46a2b5ae4a0dd1632be46d6fe3597f6ace7a41
BUG: 789278
Signed-off-by: Kamal Mohanan <kmohanan@redhat.com>
commit 546dd48d359683f60b685308abb92132383a06cf
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Oct 13 16:53:51 2017 +0530
libglusterfs/options: Add new member 'setkey' to xlator options
The 'setkey' will be used as the key by GD2 when setting the option
during volgen. 'setkey' also supports using varstrings.
This is mainly to be used for options, which use a different key for
'volume set' and in volfiles. For eg. the 'auth.*' options of
protocol/server.
The protocol/server xlator has been updated to make use of this for the
auth.allow and auth.reject options.
Updates #302
Change-Id: I1fd2fd69625c9db48595bd3f494c221625255169
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit fe62d4150bdd8ab3ad96af0ce07068d941030a33
Author: Vishal Pandey <vishpandey2014@gmail.com>
Date: Tue Nov 14 14:33:19 2017 +0530
eventsapi: glustereventsd hardcodes working-directory
Issue:
Glusterevents daemon hardcodes glusterd working directory
even though it can be changed later in .vol file
which causes breaks in the code.
Fix: Use python subprocess module to get the working directory
of gluster daemon in eventsapiconf.py.in.
Change-Id: I5e92185604f8c8aeb77dabdc00f9ea0f8e92c88d
BUG: 1512455
Signed-off-by: Vishal Pandey <vishpandey2014@gmail.com>
commit dead31026640f53036f29265ea10c2214e2b6cbe
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Tue Nov 14 20:32:59 2017 +0530
glusterd: checked_return coverity fix
function: glusterd_store_retrieve_options
issue: Calling "gf_store_iter_destroy" without checking return value
fix: typecasted the return value of the function to void
Change-Id: I6dc4f4308b1eca8d6ee85834a1530ff356c73898
BUG: 789278
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit 7c6f839932912e7c3c98f0eaf2c5b9b0cc200807
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jun 21 12:56:14 2017 +0530
geo-rep: Refactoring Config and Arguments parsing
- Fixed Python pep8 issues
- Removed dead code
- Rewritten configuration management
- Rewritten Arguments/subcommands handling
- Added Args upgrade to accommodate all these changes without changing
glusterd code
- use of md5 removed, which was used to hash the brick path for workdir
Both Master and Slave nodes will have subdir for session in the
format "<mastervol>_<primary_slave_host>_<slavevol>
$GLUSTER_LOGDIR/geo-replication/<mastervol>_<primary_slave_host>_<slavevol>
$GLUSTER_LOGDIR/geo-replication-slaves/<mastervol>_<primary_slave_host>_<slavevol>
Log file paths renamed since session info is available with directory
name itself.
$LOG_DIR_MASTER/
- gsyncd.log - Gsyncd, Worker monitor logs
- mnt-<brick-path>.log - Aux mount logs, mounted by each worker
- changes-<brick-path>.log - Changelog related logs(One per brick)
$LOG_DIR_SLAVE/
- gsyncd.log - Slave Gsyncd logs
- mnt-<master-node>-<master-brick-path>.log - Aux mount logs,
mounted for each connection from master-node:master-brick
- mnt-mbr-<master-node>-<master-brick-path>.log - Same as above,
but mountbroker setup
Fixes: #73
Change-Id: I2ec2a21e4e2a92fd92899d026e8543725276f021
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit f0c1acbddc683e071024fe6a57ab93d884fd5eea
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Tue Nov 14 10:53:47 2017 +0100
cluster/ec: Fix op-version for disperse.other-eager-lock
The op-version used for the new option was wrong. It has been set
to 3.13.0.
Change-Id: I88fbd7834e4a8018c8906303e734c251e90be8cf
BUG: 1502610
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit f818bf249cbfa871a12e08752bfc565770f63590
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Tue Nov 14 14:24:21 2017 +0530
cluster: dead_code coverity fix
function: stripe_entry_self_heal
issue: Execution cannot reach this statement: "dict_unref(xdata);"
fix: removed the 'if' condition and the corresponding actions because if the execution reaches this statement, then the value of xdata will always be NULL
Change-Id: Iebc825339e2e1236b92bed39d81a1a9aba10164e
BUG: 789278
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit 53b3b97ef1dd5b4f63fe3c7fe8d510f9b64ebb27
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Tue Nov 14 13:59:14 2017 +0530
glusterd: dead_code coverity fix
issue: Execution cannot reach this statement: "rsp.op_errno = gf_errno_to_...".
function:__server_event_notify
fix: removed the if statement and the corresponding actions. Also, the variable was not being used anywhere else, so removed its declaration as well
Change-Id: I85259e276c482cc9c98b1a829426bcec7412ce3f
BUG: 789278
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit d0587c04710ddc20aff4efaf103f253a1285ff6f
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Nov 13 05:27:50 2017 -0500
geo-rep: Fix data sync issue during hardlink, rename
Problem:
The data is not getting synced if master witnessed
IO as below.
1. echo "test_data" > f1
2. ln f1 f2
3. mv f2 f3
4. unlink f1
On master, 'f3' exists with data "test_data" but on
slave, only f3 exists with zero byte file without
backend gfid link.
Cause:
On master, since 'f2' no longer exists, the hardlink
is skipped during processing. Later, on trying to sync
rename, since source ('f2') doesn't exist, dst ('f3')
is created with same gfid. But in this use case, it
succeeds but backend gfid would not have linked as 'f1'
exists with the same gfid. So, rsync would fail with
ENOENT as backend gfid is not linked with 'f3' and 'f1'
is unlinked.
Fix:
On processing rename, if src doesn't exist on slave,
don't blindly create dst with same gfid. The gfid
needs to be checked, if it exists, hardlink needs
to be created instead of mknod.
Thanks Aravinda for helping in RCA :)
Change-Id: I5af4f99798ed1bcb297598a4bc796b701d1e0130
Signed-off-by: Kotresh HR <khiremat@redhat.com>
BUG: 1512483
Reporter: dimitri.ars@gmail.com
commit d7526a187f036314715e7e9f9ce5257ef2a60a77
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Nov 1 23:44:02 2017 +0530
glusterd: DEADCODE coverity fix
Problem: execution cannot enter into if block since the condition
!address is always false.
Fix: removing if block solves it.
Change-Id: I47b4beca7bdc095900b46e3f5a5cb9629aa2a4d7
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 1b5862a7bb680d9c0ec6bdc29ea9c7e7d3a306bb
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Tue Nov 7 13:45:03 2017 +0100
libglusterfs/atomic: Improved atomic support
This patch solves a detection problem in configure.ac that prevented
that compilation detects builtin __atomic or __sync functions.
It also adds more atomic types and support for other atomic functions.
An special case has been added to support 64-bit atomics on 32-bit
systems. The solution is to fallback to the mutex solution only for
64-bit atomics, but smaller atomic types will still take advantage
of builtins if available.
Change-Id: I6b9afc7cd6e66b28a33278715583552872278801
BUG: 1510397
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit 352a4c9aeedf8502ded6c21adbae4c6b13209440
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Mon Nov 13 16:48:26 2017 +0530
glusterd: dead code coverity fix
function: glusterd_volume_rebalance_use_rsp_dict
problem: Execution cannot reach this statement: "goto out;"
fix: removed the condition 'if(!ctx_dict)' and the corresponding action 'goto out;' because it will never be executed.
reason: if the execution reaches this condition, then the value of '!ctx_dict' will always be false otherwise the execution will reach the 'out'
label, skipping the execution of this conditional statement.
html link of issue: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-11-10-0f524f07/html/1/99glusterd-utils.c.html#error
Change-Id: I7ab6b2386bb01c54edd872f9f83bb8d2a4cd499f
BUG: 789278
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit f23a4a03d5ee11f97c396acbda9388d518c07513
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Mon Nov 13 21:28:51 2017 +0530
glusterd: checked_return coverity fix
issue: Calling "recursive_rmdir" without checking return value
fix: typecasted return value of function 'recursive_rmdir' to void
Change-Id: Ie95c2a2c503bb247afa69823d0043c3af5e036e8
BUG: 789278
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit 8403903fd7fcf4dd2e09cbb2e39a65dc7d9b9ada
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Mon Nov 13 15:03:05 2017 +0530
glusterd: buffer_size_warning coverity fix
function: glusterd_import_volinfo
problem: Calling strncpy with a maximum size argument of 256 bytes on destination array "new_volinfo->parent_volname" of size 256 bytes might leave the destination string unterminated.
fix: The third argument of strncpy specifies the number of characters to be copied from the source string to the destination string. To make sure that the final string in destination is always null terminated, we copy 1 less character than the total capacity of the destination array and the last element of the array will be filled by '/0' automatically by the strncpy function.
html link of issue: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-11-10-0f524f07/html/1/39glusterd-utils.c.html#error
Change-Id: I76b0d10e6a932b0885531c9be3c4f4ce7239f3e1
BUG: 789278
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit 4c4ed3334964e9479d5ed3c5ea2d51852a275b53
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Sat Nov 11 01:12:02 2017 +0530
libglusterfs/gfdb:coverity issue fix
Coverity Id:719,748,761
problem : The value of "ret" is overwritten in init_db and
add_conection_node
Change-Id: Iade8ca8d61c5e25e8c311b1375219f5f61d51bc3
BUG: 789278
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit ae8569506f3fbdf76aa6d54908da1bdb1a92da14
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Sat Nov 11 00:12:10 2017 +0530
libglusterfs:UNUSED VALUE coverity fix
Problem : Overwriting previous write to "ret" with value "EVENT_SEND_OK"
before itr can be used.
Fix: The value of ret is used in out.
Change-Id: I2cdb32e441c85c94de30de89a7a4121fd54d1acd
BUG: 789278
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit 8c341906dc7c7da9a68c5886aa6947d2fd43894e
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Nov 7 13:05:56 2017 +0530
debug/io-stats: Coverity fix in io-stats
Coverity ID: 539
Coverity ID: 542
Coverity ID: 365
Coverity ID: 366
Coverity ID: 502
Coverity ID: 76
Change-Id: I0369856e8958e167a43065801096432b8855c114
BUG: 789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 5d3b0d076e13ca34d81cbb371c7a034485561228
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Nov 8 16:15:43 2017 +0530
features/libgfchangelog: Fix coverity issues
Error: DEADCODE:
xlators/features/changelog/lib/src/gf-changelog-journal-handler.c:524:
dead_error_begin: Execution cannot reach this statement: "default:".
Error: DEADCODE:
xlators/features/changelog/lib/src/gf-history-changelog.c:984:
dead_error_line: Execution cannot reach the expression "to" inside
this statement: "if (!from || !to)
ret = -1;".
Error: REVERSE_INULL:
xlators/features/changelog/lib/src/gf-changelog-journal-handler.c:678:
check_after_deref: Null-checking "entry" suggests that it may be null,
but it has already been dereferenced on all paths leading to the
check.
Error: STACK_USE:
xlators/features/changelog/lib/src/gf-changelog-journal-handler.c:275:
stack_use_local_overflow: Local variable "ascii" uses 12288 bytes of
stack space, which exceeds the maximum single use of 10000 bytes.
Error: STACK_USE:
xlators/features/changelog/lib/src/gf-changelog-journal-handler.c:167:
stack_use_local_overflow: Local variable "ascii" uses 12288 bytes of
stack space, which exceeds the maximum single use of 10000 bytes.
Error: STRING_NULL:
xlators/features/changelog/lib/src/gf-changelog-journal-handler.c:589:9:
string_null_sink_parm_call: Passing parameter "from_path" to "open"
which expects a null-terminated string.
Error: UNUSED_VALUE:
xlators/features/changelog/lib/src/gf-history-changelog.c:628:
assigned_value: Assigning value "-1" to "ret" here, but that stored
value is overwritten before it can be used.
Error: STRING_NULL:
xlators/features/changelog/lib/src/gf-history-changelog.c:518:
string_null_argument: Function "sys_pread" does not terminate string
"*ccd->changelog".
BUG: 789278
Change-Id: I1414ec6d4a118ce0c14df4dbe50995c85fe3ecf7
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit dfbaf84f8be7f9f11a91da725a36f1f66c111174
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Sep 27 11:37:28 2017 +0530
extras: scripts to control CPU/MEMORY for any gluster daemon during runtime
Problem: Sometime gluster daemons like glustershd can consume a lot of cpu and/
or memory if there is a large amount of data/ entries to be healed.
Solution: Until we have some form of throttling/ QoS mechanisms built into
gluster, we can use control groups for regulating cpu and memory of any gluster
daemon using control-cpu-load.sh and control-mem.sh scripts respectively.
Test: To test the control-cpu-load.sh script follow below procedure:
1) Setup distribute replica environment
2) Selfheal daemon off
3) Down one node from replica nodes
4) Create millions of files from mount point
5) Start down node
6) Check cpu usage for shd process in top command
7) Run script after provide shd pid with CPU quota value
8) Check again cpu usage for shd process in top command
Note: control-mem.sh script can cap the memory usage of the process to the set
limit, beyond which the process gets blocked. It resumes either when the memory
usage comes down or if the limit is increased.
BUG: 1496335
Change-Id: Id73c36b73ca600fa9f7905d84053d1e8633c996f
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 779e0a0f6673572405076d077959ca61b0023db0
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Oct 25 12:42:23 2017 +0530
cluster/afr: Print heal info split-brain output in stream fashion
Problem:
When we trigger the heal info split-brain command the o/p is not
streamed as it is received, but dumped at the end for all the bricks
together. This gives a perception that the command is hung.
Fix:
When we get a split brain entry while crawling throught the pending
heal entries, flush that immediately so that it prints the output
in a stream fashion and doesn't look like the cli is hung.
Change-Id: I7547e86b83202d66616749b8b31d4d0dff0abf07
BUG: 1506104
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 9d71c80900ee96f56b584c4726627c39f44ce889
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Nov 9 22:42:22 2017 +0530
tests: fix bug-1483058-replace-brick-quorum-validation.t spurious failure
Change-Id: I04c35305bfb663eabbf715eee78695adfd4a2d20
BUG: 1511310
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit bd4048f91a7aa701f18f777eb897437951ee0682
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Oct 17 11:28:43 2017 -0400
glusterd: Validate changelog on geo-rep volume
If geo-rep is configured on volume, don't allow
to disable changelog.
Change-Id: I7d1ba8b2939c8fe6ee6c59fb923d9aa1bdab553c
BUG: 1503227
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 1da7c0afc7a927aafe332a58fdc9b45dd381ae09
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Nov 2 00:17:42 2017 +0530
glusterd: PW.INCLUDE_RECURSION coverity fix
This patch fixes coverity issue 421
Problem: #include file "glusterd-utils.h" includes itself,
glusterd-utils.h -> glusterd-peer-utils.h -> glusterd-utils.h
Fix: include of glusterd-utils.h into glusterd-peer-utils.c instead
of glusterd-peer-utils.h.
Change-Id: I164732dfb1f64636577765124ddc5361ff0f1cc5
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 415b68013aa525a94d67dba9ecbc4062b150d120
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Nov 7 17:24:24 2017 +0530
glusterfsd: making parent process to write pidfile while forking
Issue: pid is written into glusterd.pid by child process instead of
parent process while forking.
Fix: After fork returns child pid to parent process, it falls under
default case of switch statement, call glusterfs_pidfile_update()
in default case instead of postfork label.
Change-Id: I41b616c140592bf117601bc451dfd8b934a5b640
BUG: 1509340
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit a4d260e8bc5a0b45c9bb1f2ad7c1c3358bf9b4eb
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Nov 10 13:31:28 2017 +0530
glusterd: few coverity fixes in glusterd-handler.c
This patch fixes coverity issues 695,555,263
Change-Id: I3577cbc793b6652b24cc719037db2bdd5e27f196
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit e89c00733d55d4666fb38fb208046c2c3d0a10d4
Author: Ashish Pandey <aspandey@redhat.com>
Date: Sat Nov 4 23:14:37 2017 +0530
mgmt/glusterd glusterd coverity fixes
Coverity ID: 498
Coverity ID: 756
Coverity ID: 764
Coverity ID: 553
Coverity ID: 562
Coverity ID: 765
Coverity ID: 731
Coverity ID: 545
Coverity ID: 781
Change-Id: I5922db462ba3f71397ae097d7e56739c335114d3
BUG: 789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 212fabc13550b02884e786bf230b906d6140e709
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Sep 18 14:07:31 2017 +0530
cluster/ec: Keep last written strip in in-memory cache
Problem:
Consider an EC volume with configuration 4 + 2.
The stripe size for this would be 512 * 4 = 2048.
That means, 2048 bytes of user data stored in one
stripe. Let's say 2048 + 512 = 2560 bytes are
already written on this volume. 512 Bytes would
be in second stripe. Now, if there are sequential
writes with offset 2560 and of size 1 Byte, we have
to read the whole stripe, encode it with 1 Byte and
then again have to write it back. Next, write with
offset 2561 and size of 1 Byte will again
READ-MODIFY-WRITE the whole stripe. This is causing
bad performance because of lots of READ request
travelling over the network.
There are some tools and scenario's where such kind
of load is coming and users are not aware of that.
Example: fio and zip
Solution:
One possible solution to deal with this issue is to
keep last stripe in memory. This way, we need not to
read it again and we can save READ fop going over the
network. Considering the above example, we have to
keep last 2048 bytes (maximum) in memory per file.
Change-Id: I3f95e6fc3ff81953646d374c445a40c6886b0b85
BUG: 1471753
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit b870c93435ca605d20df64d2940a7774016ea44f
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri Nov 3 11:15:52 2017 +0530
rpc: Fix several coverity issues in rpc/socket code
This patch fixes issues 287,289,286,809,690,276,401,402,403 from [1]
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
BUG: 789278
Change-Id: I2716d07fbdab59f779c2852bde07756b0e9a4ddc
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 8464ea6d56338bf1c664699d4c949a408018d9cc
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Sep 21 18:11:15 2017 -0400
geo-rep: Fix rename of directory in hybrid crawl
In hybrid crawl, renames and unlink can't be
synced but directory renames can be detected.
While syncing the directory on slave, if the
gfid already exists, it should be rename.
Hence if directory gfid already exists, rename
it.
Change-Id: Ibf9f99e76a3e02795a3c2befd8cac48a5c365bb6
BUG: 1499566
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 6305609264d3cabb79f644c63592b85cbf0ea26d
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Nov 8 06:08:02 2017 -0500
features/bitrot: Fix coverity issues
1. br_update_scrub_finish_time: BUFFER_SIZE_WARNING
2. br_read_bad_object_dir : DEADCODE
3. bit-rot.c: init : RESOURCE_LEAK
4. br_stub_fsetxattr : STACK_USE
5. br_stub_setxattr : STACK_USE
6. bit-rot-stub.c: init : BUFFER_SIZE_WARNING
Change-Id: Ie620f431bd7548fedae2152aa756ccdcd89ddf89
Signed-off-by: Kotresh HR <khiremat@redhat.com>
BUG: 789278
commit 9cf5cd38b09ae874ad0c863cfa6b1cc9baf4301d
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Wed Nov 8 16:18:56 2017 +0530
quota: fixes issue in quota.conf when setting large number of limits
Problem: It was not possible to configure more than 7712 quota limits.
This was because a stack buffer of size 131072 was used to read from
quota.conf file. In the new format of quota.conf file each gfid entry
takes 17bytes (16byte gfid + 1 byte type). So, the buf_size was not a
multiple of gfid entry size and as per code this was considered as
corruption.
Solution: make buf size multiple of gfid entry size
Change-Id: Id036225505a47a4f6fa515a572ee7b0c958f30ed
BUG: 1510940
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
commit 0d81b4e72f2ee9e0c6803bcd41b9dc22cd618d1d
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Nov 9 13:15:51 2017 +0530
glusterd: display gluster volume status, when quorum type is server
Problem: when server-quorum-type is server, after restarting glusterd
in the node which is up, gluster volume status is giving incorrect
information.
Fix: check whether server is blank, before adding other keys into the
dictionary.
Change-Id: I926ebdffab330ccef844f23f6d6556e137914047
BUG: 1511339
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 3f827c2abf93f010c9f3589cf043f93ec88cbd49
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Nov 7 16:09:37 2017 +0530
mount/fuse: use fstat in getattr implementation if any opened fd is available
The restriction of using fds opened by the same Pid means fds cannot
be shared across threads of multithreaded application. Note that fops
from kernel have different Pid for different threads. Imagine
following sequence of operations:
* Turn off performance.open-behind
* Thread t1 opens an fd - fd1 - on file "file". Let's assume nodeid of
"file" is "nodeid-file".
* Thread t2 does RENAME ("newfile", "file"). Let's assume nodeid of
"newfile" as "nodeid-newfile".
* t2 proceeds to do fstat (fd1)
The above set of operations can sometimes result in ESTALE/ENOENT
errors. RENAME overwrites "file" with "newfile" changing its nodeid
from "nodeid-file" to "nodeid-newfile" and post RENAME, "nodeid-file" is
removed from the backend. If fstat carries nodeid-file as argument,
which can happen if lookup has not refreshed the nodeid of "file" and
since t2 doesn't have an fd opened, fuse_getattr_resume uses STAT
which will fail as "nodeid-file" no longer exists.
Since the above set of operations and sharing of fds across
multiple threads are valid, this is a bug.
The fix is to use any fd opened on the inode. In this specific example
fuse_getattr_resume will find fd1 and winds down the call as fstat
(fd1) which won't fail.
Cross-checked with "Miklos Szeredi" <mszeredi.at.redhat.dot.com> for
any security issues with this solution and he approves the solution.
Thanks to "Miklos Szeredi" <mszeredi.at.redhat.dot.com> for all the
pointers and discussions.
Change-Id: I88dd29b3607cd2594eee9d72a1637b5346c8d49c
BUG: 1510401
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit 1960e284ba3c8c606bddb6e02e423b9afe4f54f3
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Oct 12 11:31:34 2017 +0530
features/libgfchangelog: Structured logging support
Structured logging infra is available in logging library with
issue #240. Log messages with dynamic content are identified and
converted to structured logging format(`gf_msg` to `gf_smsg` and
`gf_log` to `gf_slog`)
BUG: 1501054
Change-Id: I99b35396455a634f5267eb1379d481ea981e5494
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit ebcc48b2e9978cda1fd9f450e13b8602cf6f6ece
Author: Girjesh Rajoria <grajoria@redhat.com>
Date: Fri Nov 3 02:42:23 2017 +0530
Coverity Issue: PW.INCLUDE_RECURSION in several files
Coverity ID: 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417,
418, 419, 423, 424, 425, 426, 427, 428, 429, 436, 437, 438, 439,
440, 441, 442, 443
Issue: Event include_recursion
Removed redundant, recursive includes from the files.
Change-Id: I920776b1fa089a2d4917ca722d0075a9239911a7
BUG: 789278
Signed-off-by: Girjesh Rajoria <grajoria@redhat.com>
commit f7f8d2b190980f4925ca1740db01dd533c64f3da
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Nov 3 16:54:55 2017 +0530
snapshot: fix coverity issue 'UNREACHABLE'
Problem : In glusterd-snapshot-utils.c:2778 code path is unreachable as it was
intended for n-way replication snapshot support.
Fix : Removed code now, will revert back this change in future once we support
n-way replication in snapshot.
This patch fixes coverity issue 687 from [1].
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I163f318e62a7e84d211d9930dedee6587d37b2a0
BUG: 789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit c4aeae4d526c48d4809714806eff73cfb44c4560
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Tue Oct 24 16:10:23 2017 +0530
Quota: Adding man page for quota
Change-Id: I95365c443705f56561cc10138318eb96db3b941e
BUG: 1505660
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
commit b1241746651889fbefbff318d3142be495958382
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Nov 6 13:23:32 2017 +0530
glusterd: restart the brick if qorum status is NOT_APPLICABLE_QUORUM
If a volume is not having server quorum enabled and in a trusted storage
pool all the glusterd instances from other peers are down, on restarting
glusterd the brick start trigger doesn't happen resulting into the
brick not coming up.
Change-Id: If1458e03b50a113f1653db553bb2350d11577539
BUG: 1509845
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 92ddd6f924c023c8b585fbc4c480262e0d0f87d4
Author: Vishal Pandey <vishpandey2014@gmail.com>
Date: Tue Sep 26 11:55:25 2017 +0530
glusterd: Coverity Issue FORWARD_NULL fix
Problems: According to Coverity Issue ID 207
issues are as follows-
a-) Dereferencing "this" pointer without checking if it points to NULL.
b-) The IF condition on line 1750 should check
if any *one* of dict, this or peerinfo is NULL
and not *all*.
Fix:
Replace the && operator with || to check if any *one* of
this, dict or peerinfo is NULL and then execute out label.
Change-Id: I40057d6cade71d3862c8e491bf4137cf25dda327
BUG: 789278
Signed-off-by: Vishal Pandey <vishpandey2014@gmail.com>
commit 605c78f08b5aeeaae892fb474e59e0a2b9fec34d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Nov 6 17:54:30 2017 +0530
features/shard: Coverity fixes
This patch fixes coverity issues 242 and 453.
Change-Id: If18f40539dccc7c2fcdcf8ef9b6fa3efbb3e462f
BUG: 789278
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit c3fc973413b6804bb002e02aefeb8ffd32d3c5ed
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Nov 6 22:06:46 2017 +0530
cli: Fix coverity issues in cli.c
This patch fixes coverity issue 536
BUG: 789278
Change-Id: I9fe7b324a3ab1f16b4ee4e63818f93ef71d3405a
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 57bc2b500212cee69492899307b36dd98481aa24
Author: Ashish Pandey <aspandey@redhat.com>
Date: Sat Nov 4 23:37:18 2017 +0530
protocol/server : Coverity Fixes
Coverity ID: 802
Coverity ID: 741
Coverity ID: 808
Change-Id: If1b3196f0d1ba850c349c65f1626e41dcf42b6b6
BUG: 789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 7412debe6f8d055d45a34ecf94ce08af3ef6f95d
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Nov 7 17:35:32 2017 +0530
snapshot : fix coverity issue in glusterd-snapshot.c
This patch fixes coverity issue 87 from [1].
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I5c9c67b4dd43ebf1a5a83532cbd06178000da145
BUG: 789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 874c711062ad795bc28c402d00669d21fd05df1d
Author: Andrea Bolognani <abologna@redhat.com>
Date: Wed Oct 25 17:16:14 2017 +0200
*.pc: Fix include path in Cflags
The include path in glusterfs-api.pc looks like
-I${includedir}/glusterfs
However, client code will include the glusterfs headers using
#include <glusterfs/api/glfs.h>
rather than
#include <api/glfs.h>
which makes the "/glusterfs" part entirely unnecessary.
More importantly, on some platforms such as FreeBSD, the header files
for glusterfs will be installed in /usr/local/include, which is *not*
part of the compiler's default include path, so compilation will fail
with something like
fatal error: 'glusterfs/api/glfs.h' file not found
#include <glusterfs/api/glfs.h>
^~~~~~~~~~~~~~~~~~~~~~
The fix is to simply drop the extra "/glusterfs". The same change
is applied to other *.pc files as well, althought I haven't actually
tested those.
A test program (gfapi-load-volfile) and the glfsxmp example
application were using the wrong include paths, so they had to be
fixed as well.
Change-Id: I9a16de47fee7ab9c12d1cb823bbe061a69352670
BUG: 1508947
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
commit 45eb7ef69781e172a5af5f5591e6070d18e959bf
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Sep 12 23:01:46 2017 +0530
xlator: add more metrics per fops
Make sure to handle these counters in STACK_WIND/UNWIND macro, and
keep the counters as part of xlator_t structure itself, to provide
infra to monitoring.
Updates #137
Change-Id: Ib54d45e2321c2b095dac5810c37e6cdffe1f71b7
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 7c9a38fa2a65a7e9ff732cb211f283faa9229a48
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Tue Oct 31 13:05:36 2017 +0530
cluster/ec: UNUSED_VALUE coverity fix
Problem: Return values are not used.
Solution: Removed the unused values.
BUG: 789278
Change-Id: Ica2b95bb659dfc7ec5346de0996b9d2fcd340f8d
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit 31823f2d475c46c2f44170f661dadd84f1b9afc3
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Nov 3 15:30:51 2017 +0530
snapshot: lvm cleanup during snapshot remove
Problem : During snapshot remove lvm cleanup was skipped for deactivated
snapshots by assuming that its mount point is not present.
Fix : Do no skip lvm cleanup by checking active mount point.
Change-Id: I856d2d647c75db8b37b7f430277daef6eb7580a8
BUG: 1509254
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 1cb6dcad4f2eebf8bae1c5e3c8c5298203b79864
Author: Vishal Pandey <vishpandey2014@gmail.com>
Date: Mon Sep 25 12:14:33 2017 +0530
features/changelog: Coverity Error Check Return
If condition to check error in lseek wrapper sys_lseek.
Change-Id: Ic96ddbb0898146bbfae11acc86818d6604e5eb98
BUG: 789278
Signed-off-by: Vishal Pandey <vishpandey2014@gmail.com>
commit 1b0e5320ce9fd143752dbd4a2520316b5f6fcbd2
Author: Girjesh Rajoria <grajoria@redhat.com>
Date: Fri Nov 3 22:59:42 2017 +0530
rpc/rpc-transport/: MISSING_BREAK in name.c
Coverity ID: 286, 287, 288, 289, 290
Issue: Event unterminated_case: The case for value "27" is not
terminated by a 'break' statement.
Added Fall through in comment between switch cases.
Change-Id: I9e3f205c05ac22a85a87423ef690fc18891eaece
BUG: 789278
Signed-off-by: Girjesh Rajoria <grajoria@redhat.com>
commit f8278e9013beee5566edc9ae2f6e88aaa0bc76cf
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Tue Oct 31 12:46:53 2017 +0530
cluster/ec: REVERSE_INULL coverity fix
Problem: fop could be NULL.
Solution: Check has been added to verify fop.
BUG: 789278
Change-Id: I7e8d2c1bdd8960c609aa485f180688a95606ebf7
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit b41184ce2cf26e435b453ee57ddceab2df08138f
Author: Ashish Pandey <aspandey@redhat.com>
Date: Sat Nov 4 20:44:04 2017 +0530
snapview: Coverity Fixes
Coverity ID: 259
Coverity ID: 163
Change-Id: I7f7753b870715e1176826fb8dfbe81119750d113
BUG: 789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 521cc82e18d2469e2c76f033f842c7106826eddb
Author: Ashish Pandey <aspandey@redhat.com>
Date: Sat Nov 4 19:48:48 2017 +0530
cluster/dht: Check for NULL local before using it
Coverity ID: 261
Coverity ID: 257
Check if local is NULL or not
Change-Id: I570f87f32e1347f891c6a02ee5641fcc5a262a96
BUG: 789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit a36332a0d2c2d660736c5f17104815baaf9ee6f9
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Nov 2 17:20:29 2017 +0530
gfapi: Fix several coverity issues in glfs-fops.c
This patch fixes coverity issues 176
[1] : https://download.gluster.org/pub/gluster/glusterfs/static-analysis/
master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I473323db27218ac784b8eae773a1efe911fcfec0
BUG: 789278
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit 5a40c84a054886159a808b91919297ccc7bd5079
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Tue Oct 31 15:29:30 2017 +0530
cluster/ec: NEGATIVE_RETURNS coverity fix
Problem: Source could be negative.
Solution: Check has been added to verify the same.
BUG: 789278
Change-Id: I8cca6297327e7923b25949c20ec8d1a711207a76
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit 096365f7157194c8d2bf9568124af62aa7e45c69
Author: Jeff Darcy <jdarcy@fb.com>
Date: Mon Nov 6 06:02:24 2017 -0800
libglusterfs: fix (some) silliness in timer.c
This addresses two issues. First is that we currently keep
traversing the timer list even when it's no longer possible for
us to find a timer that's ready to fire. Second is that we sleep
a full second even when the next timer is due sooner.
Change-Id: I178a460d0176dbb45f972c62ee94c6df66d92ca5
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
commit b2b07cc243a68673c974849222c0785e98ed0e03
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Nov 7 16:20:27 2017 +0530
tests: fix spurious failure in bug-1345727-bricks-stop-on-no-quorum-validation.t
Add peer_count check before checking for brick status
Change-Id: I0179ec29729ab6bbc3571eb6ffd631b7b0d15f7c
BUG: 1510415
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 777a16294cb1649c5d321d0aded1cdf211672e7b
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Tue Oct 31 15:14:52 2017 +0530
cluster/ec: FORWARD_NULL coverity fix
Problem: xattr could be NULL.
Solution: Added check to verify the same.
BUG: 789278
Change-Id: Ie013f5655f4621434e5023dd76cef44b976adc68
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit 0e1b7e6fe9189eebb7c8965bf7996f9fb74e02f2
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Thu Nov 2 09:01:48 2017 +0100
cli: Fix several coverity issues in cli-cmd-parser.c
This patch fixes coverity issues 115, 191, 274, 462, 463, 508, 588,
612, 614, 618 and 698 from [1].
Also removed the need for some relatively big arrays as local variables
of some functions.
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I4f435dbdbedc1b6de067084cce3050b620b28391
BUG: 789278
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit 604693b3e570c5cfb208681d785cd56950b78c48
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Nov 7 14:00:44 2017 +0530
protocol/server: Add an argument to rpcsvc_program_register
Because of the conflicts between changes [1] and [2], a new argument
was missed from the caller of rpcsvc_program_register.
[1] : Id0a2da3632516dc1a5560dde2b151b2e5f0be8e5
[2] : I45c3dcdbf39ec90ba39d914432d13a2ace00a5ee
Change-Id: If53f755727f1bb23e0b9fb45ebf25fbc80d770a2
BUG: 1510324
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit d793bcf9924705519f45d584bb7ecb0c2698871d
Author: Girjesh Rajoria <grajoria@redhat.com>
Date: Thu Nov 2 17:52:08 2017 +0530
xlators/mgmt/glusterd/: Coverity Issue MISSING_BREAK in glusterd_op_stage_rebalance
Coverity ID: 297, 298
Issue: Event unterminated_case
Added Fall through in comment.
Change-Id: Ied742e64d9741cc974906921dcca80f0b738b7d6
BUG: 789278
Signed-off-by: Girjesh Rajoria <grajoria@redhat.com>
commit 79d975d0bdbdc0be910159074d0e01edade0cd37
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Oct 10 17:13:25 2017 +0530
rpc: bring a new protocol version
* xdr: add gfid to on wire format for fsetattr/rchecksum
* as it is change in on wire XDR format, needed backward
compatible RPC programs.
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 827334
Change-Id: Id0a2da3632516dc1a5560dde2b151b2e5f0be8e5
commit 33787519be533b6e0d1eb5a845dd3e5d553d14f6
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Aug 8 23:11:10 2017 +0530
cli: correct rebalance status elapsed check
Check that elapsed time has crossed 10 mins for at least
one rebalance process before displaying the estimates.
Change-Id: Ib357a6f0d0125a178e94ede1e31514fdc6ce3593
BUG: 1479528
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 67a8067e97d88686f8b99b12e7690f783d9aef54
Author: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
Date: Mon Nov 6 15:14:24 2017 +0530
xlators/client-rpc-fops: Fix Coverity Issues
Coverity Id: 803, 804 from [1]
Problem:
USE_AFTER_FREE code at client3_3_lookup: 3371
USE_AFTER_FREE at client3_3_readdir: 5562
Solution:
Postponed iobuf_unref(rsp_iobuf) to a location after
all dereferences of rsp_iobuf
[1]:https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I34f90d72b1248e5526ff1d2b3273cdab619cf4f8
BUG: 789278
Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
commit 5d27db3308cf496710db65556f759a511dbf4ce9
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Oct 19 11:49:42 2017 +0530
rpc: optimize fop program lookup
Ensure that the fop program is the first in the program list
so that there's minimum amount of time spent to search the
program for the most frequently needed use case.
Change-Id: I45c3dcdbf39ec90ba39d914432d13a2ace00a5ee
BUG: 1509647
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit de34b53c2a1b50309603c5ce694c14768450f045
Author: Girjesh Rajoria <grajoria@redhat.com>
Date: Fri Nov 3 00:02:15 2017 +0530
xlators/mgmt/glusterd/: DEADCODE in client_graph_set_rda_options
Coverity ID: 137
Issue: Event dead_error_begin: Execution cannot reach this statement:
"set_graph_errstr(graph, "in...".
Assigned return value of gf_string2bytesize_uint64 () to ret.
Change-Id: Ibef1b1398b233f6442b23282f5ca205c1869a8ee
BUG: 789278
Signed-off-by: Girjesh Rajoria <grajoria@redhat.com>
commit 9c0243818d23b1b3de603c81b953ed98749da23c
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 25 16:44:06 2017 +0530
stack: change gettimeofday() to clock_gettime()
For achieving the above, needed below changes too.
* more sanity into how 'frame->op' is assigned.
* infra to have 'stats' as separate section in 'xlator_t' structure
Updates #137
Change-Id: I36679bf9577f3ed00a695b4e7d92870dcb3db8e1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit e71e2f81d4a65260f4209bd816fb7d48e249ad18
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Oct 18 10:10:38 2017 +0530
rpc: make actor search parallel
Problem:
On a service request, the actor is searched using an exclusive mutex
lock which is not really necessary since most of the time the actor
list is going to be searched and not modified.
Solution:
Use a read-write lock instead of a mutex lock.
Only modify operations on a service need to be done under a write-lock
which grants exclusive access to the code.
Change-Id: Ia227351b3f794bd8eee70c7a76d833cc716ab113
BUG: 1509644
Signed-off-by: Milind Changire <mchangir@redhat.com>
commit 77a5b0038adbce2b45e0f3d98420b40caa2574fd
Author: Girjesh Rajoria <grajoria@redhat.com>
Date: Thu Nov 2 17:05:31 2017 +0530
rpc/rpc-transport/rdma/: Coverity Issue MISSING_BREAK
Issue: Event unterminated_case: The case for value "27" is not
terminated by a 'break' statement.
Function: gf_rdma_get_transport_identifiers, gf_rdma_server_get_local_sockaddr
Added Fall through in comment after case AF_INET_SDP.
Change-Id: Ia30d0143a63a63af2b4b1d9b02551b9260444f35
BUG: 789278
Signed-off-by: Girjesh Rajoria <grajoria@redhat.com>
commit 9531ab050e5b9c94b6a6232a2af084521fc672cf
Author: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
Date: Fri Nov 3 00:38:17 2017 +0530
xlators/client-rpc-fops: Fix Coverity Issues
Coverity Id: 557,175,177,184,711,182,180,181,178 from [1]
Problem:
Unreachable code at client3_3_fgetxattr: 4771
Unreachable code at client3_3_fxattrop: 5087
Unreachable code at client3_3_getxattr: 4890
Unreachable code at client3_3_lookup: 3412
Unreachable code at client3_3_readdir: 5604
Unreachable code at client3_3_readdirp: 5704
Unreachable code at client3_3_xattrop: 4982
NULL checking deref ptr at client3_3_compound: 6045
Unused Value for op_errno at client3_3_getxattr: 4859
Solution:
Removed The Unreachable Dead Code
Removed NULL Check of dereferenced pointer
Removed assignment of op_errno which is overwritten
later
[1]:https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: Ie26a026dd1475c892faf00dd844bf38092e0a780
BUG: 789278
Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
commit 09f39045dadf58adf446705097f867b883ec1684
Author: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
Date: Thu Nov 2 14:57:28 2017 +0530
server-helpers: Coverity Fix CONSTANT_EXPRESSION_RESULT in serialize_rsp_direntp
Issue : "trav->dict.dict_len > 4294967295U" is always false regardless of the values
of its operands. .But dict_serialized_length can return < 0 when error happens.
Solution : Remove the comparison which always turns out to be false and add a new
condition for error checking.
Fix : The if-condition was renewed.
Coverity-Id: 108 from [1]
[1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I9956b6ca7c4bf7444f19aadd3b32fceac011a44e
BUG: 789278
Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
commit f8f6421701f39ab47fe86f6ce3f314c4f170770a
Author: Ashish Pandey <aspandey@redhat.com>
Date: Sat Nov 4 19:20:35 2017 +0530
cluster/dht: Check for NULL before using variable
Coverity ID: 245
Check statvfs received as cbk before using it
Coverity ID: 228
Check NULL loc before freeing it.
Change-Id: I1b153ed5e7b81bcf7033bf710808e95908dcfef4
BUG: 789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 195d6119d98b422248a9f6f20bcfd80a6c10115a
Author: Prashanth Pai <ppai@redhat.com>
Date: Fri Nov 3 11:53:12 2017 +0530
glusterd: Fix few coverity errors
Fixes issues 810, 248, 491, 499, 85, 786, 811, 43, and 44
from the report at [1].
[1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
BUG: 789278
Change-Id: I27ebae2ffb2256b8eef0757d768cc46e5a942e9f
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit b5b6ca5fae227f0b327592b652caadb8ec70063c
Author: ShyamsundarR <srangana@redhat.com>
Date: Fri Nov 3 13:45:12 2017 -0400
glusterd: Changed default op-version for some options
As 3.13 is branched at a point that includes the features
that are changed with this commit, their minimum supported
op-versions should also change to 3.13.
Change-Id: I7ef8eccc13a16f93939c1edbff9508d1e167c5e4
BUG: 1509412
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 43e9b5ebd597f431e0a82d0d5654cb2372accf48
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Nov 3 15:59:00 2017 +0530
cluster/ec: Remove possibility of NULL deref
Coverity ID: 237
Problem: In ec_check_status we are trying to deref fop->answer
which could be NULL.
Solution: Check Null condition before using this pointer.
Change-Id: I4f9a73dc2f062ca9c62b4c4baf0a6fcadade88f2
BUG: 789278
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 356d1d28ff201370f890c8ca239440e80fc962d9
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Mon Oct 16 13:57:59 2017 +0200
cluster/ec: create eager-lock option for non-regular files
A new option is added to allow independent configuration of eager
locking for regular files and non-regular files.
Change-Id: I8f80e46d36d8551011132b15c0fac549b7fb1c60
BUG: 1502610
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit 43cf76af8c05d2042a8193dc47ebb75490eb802f
Author: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
Date: Thu Nov 2 15:23:22 2017 +0530
xlators/bd-helper: Coverity Fix CHECKED_RETURN in bd_do_ioctl_zerofill
Problem: bd_do_ioctl_zerofill is called and return value is unchecked
Fix: Check the returned value and goto skip if the returned value < 0
which means its an error.
Coverity Id: 67 from [1]
[1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I398873cefaca03f9cd188fa0f4ccba1378a60ed9
BUG: 789278
Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
commit 1c3c2f436b803a43866abd11cda2e91cdb7d441c
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Nov 1 19:00:09 2017 +0530
glusterd: coverity fixes
This patch fixes coverity issue 780, 88, 692, 747, 357
Change-Id: I44b0fe9119853a6d2210507c7247e168d7c3ae0a
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit bca593c1d92c9c189b63a1232798e8757841e975
Author: Girjesh Rajoria <grajoria@redhat.com>
Date: Fri Nov 3 00:41:24 2017 +0530
xlators/performance/io-cache/: DEADCODE in ioc_open_cbk
Coverity ID: 173
Issue: Event dead_error_line: Execution cannot reach this statement:
"fd_ctx_set(fd, this, 1UL);".
Removed if block as "weight == 0U" cannot be true, so if block will
never execute. Also removed weight variable because it is unused.
Change-Id: I4f028df29bfde91167fb15befa99b1fe1892adc6
BUG: 789278
Signed-off-by: Girjesh Rajoria <grajoria@redhat.com>
commit 25611152d6feb8bea08d85749571f946b08b241c
Author: ShyamsundarR <srangana@redhat.com>
Date: Thu Nov 2 12:35:53 2017 -0400
doc: Updating MAINTAINERS to reflect gNFS maintainership
Facebook has offered to take up maintaining gNFS going
forward. This change reflects the same in the MAINTAINERS
file.
Change-Id: I58dde9c833a9465d6e563f1355e4725021f5055c
Signed-off-by: ShyamsundarR <srangana@redhat.com>
commit 3ae07a4c717fc366038ae1be851470b627ad68ff
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Nov 1 12:14:36 2017 +0530
glusterd/mgmt: coverity fixes
This patch fixes coverity issues 179, 59.
Problem: control flow won't enter into if block as volname is always
NULL and return value of function synctask_barrier_init is unchecked.
Fix: remove condition checking which is always resulting in false,
and removing if block which is always unreachable. As a result of
removal of condition checking volname became a unused variable,
so remove declaration of volname.
assign return valur of synctask_barrier_init to ret, if it nonzero
value goto out.
Change-Id: I870aeb020034e97a761e9314f7ace7573f7c520c
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 1255cf178002541aace3bc1d579741cb9808f929
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 18 23:03:32 2017 +0530
global options: add a sample option to handle
Fixes #303
Change-Id: Icdaa804711c43c65b9684f2649437aae1b5c1ed5
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit c900909949a042bec37013a04f8ee7b5780d955f
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Sep 12 22:07:10 2017 +0530
Add framework for global xlator in graph
Updates #303
Change-Id: Id0b9050c93ea87532dc80b4fda650c5663d285bd
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 655b2c5d88c2e6236b5e3b9064e9053e6bbd31ea
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Thu Nov 2 10:36:36 2017 +0100
cli: Fix several coverity issues in cli-cmd-volume.c
This patch fixes issues 133, 486, 487 and 691 from [1]
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I1a6ca4870ac105ea4c634fc18293229a56ab8596
BUG: 789278
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit be897f2ff2ccb2746c703eea1271639146486e07
Author: Jeff Darcy <jdarcy@fb.com>
Date: Tue Oct 31 09:56:11 2017 -0700
core: make gf_boolean_t a C99 bool instead of an enum
This reduces the space used from four bytes to one, and allows
new code to use familiar C99 types/values interoperably with our
old cruft. It does *not* change current declarations or code;
that will be left for a separate - much larger - patch.
Updates: #80
Change-Id: I5baedd17d3fb05b38f0d8b8bb9dd62824475842e
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
commit 5e5bf5902b8fc16c4c2d20faf9019b764bb7b7c6
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Thu Nov 2 09:37:44 2017 +0100
cli: Fixed coverity issue in cli-cmd-snapshot.c
This patch fixes issue 132 from [1].
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/
Change-Id: I50952614e7edb6dbb1ec70383f1dc58ce1738c2f
BUG: 789278
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit ee611643d1a0e31a27613341e2989893ea9d6f89
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Aug 1 16:58:27 2017 +0530
cli: gluster help changes
gluster cli help now shows only the top level
help commands. gluster <component> help will now show
help commands for <component>.
Change-Id: I263f53a0870d80ef4cfaad455fdaa47e2ac4423b
BUG: 1474768
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 30104cd0674a31426f34967e2361d8590635538a
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Nov 1 17:36:10 2017 +0530
glusterd: UNUSED VALUE coverity fix
ret is overwritten before it is used, adding a line for checking
its value solves it.
Change-Id: I4ac4ad33bc236d9294da64b19d16b3bc9bb8807b
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 0bea5ff028bde031c68a015e2185d5f05e2d582c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Oct 31 17:09:45 2017 +0530
heal: Fix coverity errors
Change-Id: Idbebfc2e4cfa739a87ccaabbc6e2088362b6bbc1
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 6e96ce799e0a17924491787c60c3c04411635add
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Nov 2 01:40:00 2017 +0530
glusterd: PW.INCLUDE_RECURSION coverity fix
Problem: #include file "glusterd.h" includes itself,
glusterd.h -> glusterd-pmap.h -> glusterd.h
Fix: remove inclusion statement
Change-Id: I28f2043a73a50ae2c7b670e2dece4a3f3fffbcd6
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 18ab0d900b2a56bf0b97dd841eacb317ae60dfbd
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Thu Nov 2 00:39:28 2017 +0530
glusterd/pmap: UNUSED VALUE coverity fix
Problem: port value is assigned to p, which is overwritten before
using it.
Fix: remaoval of assignment line.
Change-Id: If007167f37b0325c7bfe12f8e9075ca68524e40a
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 0408570ebabe02a6ecfd878808fa980f57650723
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 14 13:43:58 2017 -0400
xlator/tier: flood of -Wformat-truncation warnings with gcc-7.1
Starting in Fedora 26 which has gcc-7.1.x, -Wformat-trunction is enabled
with -Wformat, resulting in a flood of new warnings. This many warnings
is a concern because it makes it hard(er) to see other warnings that
should be addressed.
An example is at
https://kojipkgs.fedoraproject.org//packages/glusterfs/3.12.0/1.fc28/data/logs/x86_64/build.log
For more info see https://review.gluster.org/#/c/18267/
Change-Id: Id7ef8e0dedd28ada55f72c03d91facbe1c9888bd
BUG: 1492849
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit ee2419949414c4fc58c7e50a7e9d5f50040f1074
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Wed Jun 8 11:53:59 2016 -0700
nfs: Fix crash bug when mnt3_resolve_subdir_cbk() fails
Summary:
When mnt3_resolve_subdir_cbk() fails (this can happen when racing
operations), authorized_path is sometimes NULL. We try to run strlen()
on this path and as a result we crash. This diff fixes that by checking
if path is NULL before dereferencing it.
Test Plan: Run with patch and observe that there is no crash. Prove test
for auth code.
BUG: 1365683
Change-Id: I2e2bdfdc61ae906788611e151d2c753b79b312df
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
commit 9ea30f6c0fafc5e3f9643438082bb7f50ba962b2
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Tue Oct 31 15:36:02 2017 +0530
cluster/ec: FORWARD_NULL coverity fix
Problem: frame could be NULL.
Solution: Added check to verify frame.
BUG: 789278
Change-Id: I55a64c936ae71ec8587a3f9dfa0fdee5d0ea5213
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit 0499fe3c8e6200288079d17fe0c9fb9c419d5d9c
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Tue Oct 31 12:37:37 2017 +0530
cluster/ec: FORWARD_NULL coverity fix
Problem: cbk could be NULL.
Solution: Assigned appropriate value to cbk.
BUG: 789278
Change-Id: I2e4bba9a54f965c6a7bccf0b0cb6c5f75399f6e6
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit 333bd5e217e079425846913f209c822d95a78766
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Oct 26 14:26:30 2017 +0530
glusterd: fix brick restart parallelism
glusterd's brick restart logic is not always sequential as there is
atleast three different ways how the bricks are restarted.
1. through friend-sm and glusterd_spawn_daemons ()
2. through friend-sm and handling volume quorum action
3. through friend handshaking when there is a mimatch on quorum on
friend import.
In a brick multiplexing setup, glusterd ended up trying to spawn the
same brick process couple of times as almost in fraction of milliseconds
two threads hit glusterd_brick_start () because of which glusterd didn't
have any choice of rejecting any one of them as for both the case brick
start criteria met.
As a solution, it'd be better to control this madness by two different
flags, one is a boolean called start_triggered which indicates a brick
start has been triggered and it continues to be true till a brick dies
or killed, the second is a mutex lock to ensure for a particular brick
we don't end up getting into glusterd_brick_start () more than once at
same point of time.
Change-Id: I292f1e58d6971e111725e1baea1fe98b890b43e2
BUG: 1506513
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 61932eeca866ba5614dee7028860217afb526c9b
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Tue Oct 31 14:56:40 2017 +0530
cluster/ec: MISSING_BREAK coverity fix
Problem: switch case syntax issue.
Solution: syntax fixed.
BUG: 789278
Change-Id: I76da72c3ab6ffc5db671686a71d6a596beaf496e
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit 48f80edab073690d69264f1c0d3655c916a8a13a
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Tue Oct 31 11:24:04 2017 +0530
snapshot: fix coverity issue 'DEADCODE'
Problem : Unreachable code at glusterd-snapshot.c:6718
Unreachable code at glusterd-snapshot.c:7352
FIx : Remove unreachable code
At glusterd-snapshot.c:6718 in if condition the value of "snap" must be "NULL"
to call glusterd_snap_remove() which is not possible here.
Change-Id: Id865bde7c1474a9b9ed11c0ed614676b4e2443c6
BUG: 789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 2d49b79b193a1cad76bf352ac4565b168b3ed1b8
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Oct 25 12:21:12 2017 +0530
extras/hooks: Honour all input arguments to scripts
Some of the hook scripts were not honouring the arguments with which
they are invoked during various volume operations. So make sure that
we consider everything while parsing the command line arguments to
avoid following warnings:
. . .
ame: unrecognized option '--first=no'
ame: unrecognized option '--version=1'
ame: unrecognized option '--volume-op=start'
. . .
Change-Id: I5b08e5e7f32908c8509e97098a042096b507783e
BUG: 1503983
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 3fadadc9d9615bd1a4d293eb8c5abeeeaf5b117e
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Oct 30 15:55:32 2017 +0530
glusterd: delete source brick only once in reset-brick commit force
While stopping the brick which is to be reset and replaced delete_brick
flag was passed as true which resulted glusterd to free up to source
brick before the actual operation. This results commit force to fail
failing to find the source brickinfo.
Change-Id: I1aa7508eff7cc9c9b5d6f5163f3bb92736d6df44
BUG: 1507466
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit 115b9627772695dff330237adea1c91cbad778e7
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Mon Sep 25 01:03:09 2017 +0530
Xlators/features: Coverity Issue "NEGATIVE_RETURNS" in worm_truncate,worm_ftruncate,worm_link,worn_unlink and worm_rename.
Issue :Event negative_returns: "op_errno" is passed to a parameter
that cannot be negative.
Fix : In functions worm_link,worm_unlink,worm_truncate,worm_ftruncate
and worm_rename, added an condition to check the whether value
of "op_errno" is negative or not.If the value is negative, then
it is set to EROFS.
Change-Id: Ie65601b6cc9799f587cc574408281dab50a58afb
BUG: 789278
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit 13d7b0fbe9d2489e1ab4bf687af7729107187dc6
Author: Rishabh Dave <rishabhddave@gmail.com>
Date: Sun Oct 15 18:41:10 2017 +0530
snapshot/scheduler: handle the exception when SELinux is absent
When SELinux is absent on an given system, snapshot_scheduler.py raises
an exception; handle it and report it in the log.
Change-Id: I21bc179e090d34f8061063e6d662521ee5046cce
BUG: 1502253
Signed-off-by: Rishabh Dave <rishabhddave@gmail.com>
commit f75fa5356d5a4b298baf3f42d061e845d16523f9
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Sep 22 16:43:39 2017 +0530
gfapi: Register/Unregister Upcall events' callback
Polling continuously for upcall events is not optimal.
Hence new APIs have been added to allow applications to
register and unregister upcall events it is interested in
along with callback function to be invoked in case of any
such upcalls sent by backend server.
@TODO: Make changes in upcall xlator so that events are
sent to only those clients which either registered callbacks
or started polling. Shall be addressed in separate patch.
Updates: #315
Change-Id: I40473fd5cf689172ff2d7bb2869756b7fd5bc761
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit 9aae141b06e4c314ec220225e37b19549a7eda15
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Oct 17 12:50:48 2017 +0530
eventsapi: HTTPS support for Webhooks
First it tries to call URL with verify=True without specifying the cert
path, it succeeds if a webhook is HTTP or HTTPS with CA trusted
certificates(for example https://github..).
If above call fails with SSL error then it tries to get the server
certificate and calls URL again. If call fails with SSL error even after
using the certificate, then verification will be disabled and logged in
the log file.
All other errors will be catched and logged as usual.
BUG: 1506903
Change-Id: I86a3390ed48b75dffdc7848022af23a1e1d7f076
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit c905f0475b6440ee3192d05166dd5fa383f2b141
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Oct 17 21:32:44 2017 +0530
glusterd: clean up portmap on brick disconnect
GlusterD's portmap entry for a brick is cleaned up when a PMAP_SIGNOUT event is
initiated by the brick process at the shutdown. But if the brick process crashes
or gets killed through SIGKILL then this event is not initiated and glusterd
ends up with a stale port. Since GlusterD's portmap traversal happens both ways,
forward for allocation and backward for registry search, there is a possibility
that glusterd might end up running with a stale port for a brick which
eventually will end up with clients to fail to connect to the bricks.
Solution is to clean up the port entry in case the process is down as
part of the brick disconnect event. Although with this the handling
PMAP_SIGNOUT event becomes redundant in most of the cases, but this is
the safeguard method to avoid glusterd getting into the stale port
issues.
Change-Id: I04c5be6d11e772ee4de16caf56dbb37d5c944303
BUG: 1503246
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit a8ec47bbb7f14d4895e09a11723cd6ed2b680dd6
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Fri Oct 27 16:04:46 2017 +0530
glusterd: persist brickinfo's port change into glusterd's store
Problem:
Consider a case where node reboot is performed and prior to reboot
brick was listening to 49153. Post reboot glusterd assigned 49152
to brick and started the brick process but the new port was never
persisted. Now when glusterd restarts glusterd always read the port
from its persisted store i.e 49153 however pmap signin happens with
the correct port i.e 49152.
Fix:
Make sure when glusterd_brick_start is called, glusterd_store_volinfo is
eventually invoked.
Change-Id: Ic0efbd48c51d39729ed951a42922d0e59f7115a1
BUG: 1506589
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
commit 78e11adb3fe71473b28145679bd83e0956a52aa0
Author: Vishal Pandey <vishpandey2014@gmail.com>
Date: Tue Oct 24 14:26:45 2017 +0530
write once read many: file appendable in worm state
Issue:
A new file is appendable even when file level worm is 1.
Fix:
Do a state transition in writev function in worm.c file.
Steps To Test:
1- Activate file level worm.
2- Create a new file.
3- Leave file dormant for auto commit period.
4- Try and append some content to the file.
5- check the file if new content has been appended or not.
6- check if file has been transitioned to Worm Retention state.
Change-Id: I52d50ad888cb0c39ad54be9352ccb07d48b8d71a
BUG: 1505807
Signed-off-by: Vishal Pandey <vishpandey2014@gmail.com>
commit 475dfbdd1187a3cb9f40b46c53491af577db7442
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Oct 18 16:43:16 2017 +0530
cluster/afr: Honor default timeout of 5min for analyzing split-brain files
Problem:
After setting split-brain-choice option to analyze the file to resolve
the split brain using the command
"setfattr -n replica.split-brain-choice -v "choiceX" <path-to-file>"
should allow to access the file from mount for default timeout of 5mins.
But the timeout was not honored and was able to access the file even after
the timeout.
Fix:
Call the inode_invalidate() in afr_set_split_brain_choice_cbk() so that
it will triger the cache invalidate after resetting the timer and the
split brain choice. So the next calls to access the file will fail with EIO.
Change-Id: I698cb833676b22ff3e4c6daf8b883a0958f51a64
BUG: 1503519
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 8977d94df6ab4954a2841a4ecddd0576f2586f39
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Sat Jul 15 17:55:14 2017 +0530
posix: Ignore disk space reserve check for internal FOPS
Problem: Currently disk space reserve check is applicable for internal FOP
also it needs to be ignore for internal FOP.
Solution: Update the DISK_SPACE_CHECK_AND_GOTO macro at posix component.
Macro will call only while key "GLUSTERFS_INTERNAL_FOP_KEY"
exists in xdata.
BUG: 1506083
Change-Id: I2b0840bbf4fa14bc247855b024ca136773d68d16
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 4f0441ae14d679d36e2f5d1158f87fa26e866092
Author: Günther Deschner <gd@samba.org>
Date: Tue Jul 25 11:54:09 2017 +0200
md-cache: Add additional samba and macOS specific EAs to mdcache
Samba ships with a server implementation of the Apple Create Context
extension (AAPL) as negotiated by all modern Apple clients. With the
support of the AAPL extension, Apple clients will integrate better with
Samba servers. The AAPL implementation itself is contained in the Samba
vfs_fruit(8) module which has to be activated in Samba. This vfs_fruit
module also provides support for macOS alternate data streams which will
be represented in EAs. Two standard data streams ("AFP_AfpInfo" and
"AFP_Resource") will be stored in the following EAs:
* user.org.netatalk.Metadata
* user.org.netatalk.ResourceFork
For all other data streams, vfs_fruit relies on another Samba vfs
module, vfs_streams_xattr(8), to handle these. Although configurable, by
default the vfs_streams_xattr module will build EA keynames with a
"user.DosStream." prefix. Please note that we have to deal with only one
known prefix key, as macOS will happily compose EA keynames like:
* user.DosStream.com.apple.diskimages.fsck:$DATA
* user.DosStream.com.apple.diskimages.recentcksum:$DATA
* user.DosStream.com.apple.metadata:kMDItemWhereFroms:$DATA
* user.DosStream.com.apple.quarantine:$DATA
* etc.
Caching of vfs_fruit specific EAs is crucial for SMB performance and is
controlled with the same configuration option
"performance.cache-samba-metadata".
Guenther
Change-Id: Ia7aa341234dc13e1c0057f3d658b7ef711b5d31e
BUG: 1499933
Signed-off-by: Guenther Deschner <gd@samba.org>
commit de8cb3a69f2e4b1a94964ef99e717601744f80c0
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Oct 23 12:42:32 2017 +0530
tests: Update tier CLI in .t files
Update .t tier tests to use the new tier CLI.
Change-Id: I0e7f1769071108d8266fc86378c4466bcaf96e7d
BUG: 1505253
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 3870d5f867adee8c317156c5fee27e2dd854f960
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Oct 19 13:40:35 2017 +0530
extras/hooks: Fix getopt usage
`getopt` does not have an optional argument as '-name'. It should
be either '-n' or '--name'(see man getopt(1)). This wrong usage
resulted in setting the script name as 'ame' instead of $PROGNAME
in most of the hook-scripts.
Additionally the following line from DESCRIPTION given for `getopt`
shell command expects short options for almost every kind of usage
mentioned in SYNOPSIS:
. . .
If no '-o' or '--options' option is found in the first part, the
first parameter of the second part is used as the short options string.
. . .
Refer http://man7.org/linux/man-pages/man1/getopt.1.html for more
clarity on its usage.
Change-Id: I95baf5fa8c99025e66b2d83656dd838d4f6048ce
BUG: 1503983
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit eac6576beb69cf6049afca9f64bc913356f1236c
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Oct 22 12:41:38 2017 +0530
protocol/client: handle the subdir handshake properly for add-brick
There should be different way we handle handshake in case of subdir
mount for the first time, and in case of subsequent graph changes.
Change-Id: I2a7ba836433bb0a0f4a861809e2bb0d7fbc4da54
BUG: 1505323
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit c47766831baa53b4536f2061403d764a7a9ff51a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Sep 4 16:57:25 2017 +0530
cluster/afr: Fail open on split-brain
Problem:
Append on a file with split-brain succeeds. Open is intercepted by open-behind,
when write comes on the file, open-behind does open+write. Open succeeds
because afr doesn't fail it. Then write succeeds because write-behind
intercepts it. Flush is also intercepted by write-behind, so the application
never gets to know that the write failed.
Fix:
Fail open on split-brain, so that when open-behind does open+write open fails
which leads to write failure. Application will know about this failure.
Change-Id: I4bff1c747c97bb2925d6987f4ced5f1ce75dbc15
BUG: 1294051
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit a98c47c0b272c1a89198de58b8240120b48a49a0
Author: Michael Scherer <misc@redhat.com>
Date: Wed Oct 25 14:36:35 2017 +0200
Make sure attach_brick return a proper error code
Coverity warn about "Using uninitialized value "ret".", which is
indeed the case. If we can't attach after 15 tries, attach_brick
return uninitiliazed return code, which is likely hard to trigger,
but bad.
I use -1 to follow the UNIX convetion, but there is no specific error
code tested by code.
Change-Id: I43ad60d25ab169f9cea0db600805ced7f77c37ba
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
commit 9db81f8a31295fc6b74c4524e55d1c789bc63701
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Wed Jun 14 16:28:40 2017 +0530
cluster/ec: Implement DISCARD FOP for EC
Updates #254
This code change implements DISCARD FOP support for
EC.
BUG: 1461018
Change-Id: I09a9cb2aa9d91ec27add4f422dc9074af5b8b2db
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit 0ccdff6c2b801b6eb9b7e137025bf00fb2a515a6
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Oct 23 21:17:52 2017 +0200
protocol/server: fix the comparision logic in case of subdir mount
without the fix, the stat entry on a file would return inode==1 for
many files, in case of subdir mount
This happened with the confusion of return value of 'gf_uuid_compare()',
it is more like strcmp, instead of a gf_boolean return value, and hence
resulted in the bug.
Change-Id: I31b8cbd95eaa3af5ff916a969458e8e4020c86bb
BUG: 1505527
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit d7854c90ec2f651c0b1a76522c88af18aa7a3605
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Tue Oct 24 11:47:46 2017 +0530
cli: volume status command is missing in man page
Problem: volume status command is missing gluster manual page.
Fix: Adding volume status command to manual page.
Change-Id: Ifef18ff3721bc85636a9e7707c50bee2bf9d4a9b
BUG: 1505663
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 054b8b6a60059084dfa7326504bfe01623019460
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Jun 25 16:34:01 2017 +0530
cluster/ec: Allow parallel writes in EC if possible
Problem:
Ec at the moment sends one modification fop after another, so if some of
the disks become slow, for a while then the wait time for the writes that
are waiting in the queue becomes really bad.
Fix:
Allow parallel writes when possible. For this we need to make 3 changes.
1) Each fop now has range parameters they will be updating.
2) Xattrop is changed to handle parallel xattrop requests where some
would be modifying just dirty xattr.
3) Fops that refer to size now take locks and update the locks.
Fixes #251
Change-Id: Ibc3c15372f91bbd6fb617f0d99399b3149fa64b2
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit daea046823c3613d4d2a36284020b3d4936e1a50
Author: Kevin Vigor <kvigor@fb.com>
Date: Fri Apr 28 16:44:29 2017 -0700
gluster: IPv6 single stack support
Summary:
- This diff changes all locations in the code to prefer inet6 family
instead of inet. This will allow change GlusterFS to operate
via IPv6 instead of IPv4 for all internal operations while still
being able to serve (FUSE or NFS) clients via IPv4.
- The changes apply to NFS as well.
- This diff ports D1892990, D1897341 & D1896522 to the 3.8 branch.
Test Plan: Prove tests!
Reviewers: dph, rwareing
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Change-Id: I34fdaaeb33c194782255625e00616faf75d60c33
BUG: 1406898
Reviewed-on-3.8-fb: http://review.gluster.org/16059
Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
Tested-by: Shreyas Siravara <sshreyas@fb.com>
commit 0088e100a230ef2872cc18f5f60bc52aa27680f6
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Oct 23 06:46:49 2017 -0400
libgfchangelog: Fix possible null pointer dereference
If pthread_attr_init fails, gf_msg uses this->name
where 'this' is not initialized yet. This patch fixes
the same.
Change-Id: Ie004cbe1015a0d62fc3b5512e8954c5606eeeb5f
Signed-off-by: Kotresh HR <khiremat@redhat.com>
BUG: 1505325
commit 295fc18fda8aa391464a21c53ecf873eea44c59c
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Wed Aug 16 14:04:45 2017 +0530
snapshot: Issue with other processes accessing the mounted brick
Added code for unmount of activated snapshot brick during snapshot
deactivation process which make sense as mount point for deactivated
bricks should not exist.
Removed code for mounting newly created snapshot, as newly created
snapshots should not mount until it is activated.
Added code for mount point creation and snapshot mount during snapshot
activation.
Added validation during glusterd init for mounting only those snapshot
whose status is either STARTED or RESTORED.
During snapshot restore, mount point for stopped snap should exist as
it is required to set extended attribute.
During handshake, after getting updates from friend mount point for
activated snapshot should exist and should not for deactivated
snapshot.
While getting snap status we should show relevent information for
deactivated snapshots, after this pathch 'gluster snap status' command
will show output like-
Snap Name : snap1
Snap UUID : snap-uuid
Brick Path : server1:/run/gluster/snaps/snap-vol-name/brick
Volume Group : N/A (Deactivated Snapshot)
Brick Running : No
Brick PID : N/A
Data Percentage : N/A
LV Size : N/A
Fixes: #276
Change-Id: I65783488e35fac43632615ce1b8ff7b8e84834dc
BUG: 1482023
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
commit 52d059908ab376f1aaeff6e3ccfeb0a7c7317bbc
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Oct 18 08:06:24 2017 +0530
glusterfsd: Dereferencing the null pointer
Problem: When control reaches to out, one of (iobref, iobuf, frame) can
be null.for iobref, iobuf iobref_unref() and iobuf_unref() functions
are called respectively, which are using GF_VALIDATE_OR_GOTO(), so
there won't be null pointer dereference. But for frame without null
checking STACK_DESTROY(frame->root) is called causing null pointer
dereference.
Fix: adding a line for null checking, the function
STACK_DESTROY(frame->root) is called only when frame is not null.
Change-Id: I3a6684c11fb7b694b81d6ad4fec3bced5562ad88
BUG: 1503394
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit b71290f30b3116a3095d807456fe0e3a93865e47
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Oct 11 13:29:13 2017 +0530
extras/hooks: Fix errors reported via shellcheck utility
Change-Id: I217c6b2a39955f1709bb3452b00d33c2dcb60faa
BUG: 1500649
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 4f7221c548b20cb0cbfa941f0fc633278de9e519
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Oct 18 06:23:56 2017 -0400
doc: Add missing option for bitrot scrub-frequency
The option 'hourly' is supported for 'scrub-frequency'
but man page was not reflecting it. Fixed the same.
Change-Id: Ida0929c805f6f5332c5dcd94cda9ecf2f4eee20e
BUG: 1503510
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 34cc757d6fba58af161c47b262e41f34a1143479
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Wed Oct 18 11:40:59 2017 +0530
glusterd: documenting server.allow-insecure
problem: "server.allow-insecure" is invisible in gluster volume set
help.
Fix: "server.allow-insecure" is defined as NO_DOC type, chainging
it to DOC type solve the problem.
Change-Id: I327f1e4c1684ff846deb8b7df07d4d8a09073274
BUG: 1503424
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 9277ecdd15c4a9cd68d78d9dbd1a4d25db6d23e8
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Oct 10 14:45:03 2017 +0530
gfproxyd: Let glusterd manage gfproxy daemon
Updates: #242
BUG: 1428063
Change-Id: Iaaf2edf99b2ecc75f6d30762c752a6d445c1c826
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 88656ca6838a34cbf65aa8955b4f27a18a4879fd
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Oct 13 11:46:38 2017 +0530
stack.h: make sure 'oldgroups' is never null
If 'oldgroups' is null, it can lead to a crash.
Change-Id: I7a4f71256b07dc0ca3b988cad3694c21b150c99e
BUG: 789278
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit b24a9f90e920f305064353c5291c1a029d059ea9
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Thu Oct 5 23:44:46 2017 +0530
glusterd : introduce timer in mgmt_v3_lock
Problem:
In a multinode environment, if two of the op-sm transactions
are initiated on one of the receiver nodes at the same time,
there might be a possibility that glusterd may end up in
stale lock.
Solution:
During mgmt_v3_lock a registration is made to gf_timer_call_after
which release the lock after certain period of time
Change-Id: I16cc2e5186a2e8a5e35eca2468b031811e093843
BUG: 1499004
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
commit 6a84edfc3f386c6e34a1f34a174e814c1dc7bcc0
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Oct 13 20:15:55 2017 +0530
gfapi: update symbol version of glfd_set_lk_owner to 3.10.7
To be able to backport the API glfd_set_lk_owner() to
existing stable (3.10, 3.12) releases, change its symbol
version to 3.10.7 (upcoming 3.10 release).
Also sticking to the norms of the gfapi library, changing
the routine name to glfs_fd_set_lkowner()
BUG: 1499641
Change-Id: I43d002a24f493770a3daa774dbda2b7ea6d49e37
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit a96d661bf584943fc52ad354ebe433f9b0131a41
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue Oct 17 10:57:13 2017 +0530
worm/read-only: Add sentinel NULL key to options
BUG: 1193929
Change-Id: Ibfee382362826556e2e760f9b946c83445d6a08e
Signed-off-by: Prashanth Pai <ppai@redhat.com>
commit 3cffb438b5d863b4888173092d56f234e39c2b6b
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Oct 13 20:00:47 2017 +0530
mount/fuse: never fail open(dir) with ENOENT
open(dir) being an operation on inode should never fail with
ENOENT. If gfid is not present, the appropriate error is ESTALE. This
will enable kernel to retry open after a revalidate lookup.
Change-Id: I8d07d2ebb5a0da6c3ea478317442cb42f1797a4b
BUG: 1500269
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit a4192633e791ce3d27834350d8234d110e451c62
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Oct 10 11:29:04 2017 +0530
Revert "mount/fuse: report ESTALE as ENOENT"
This reverts commit 26d16b90ec7f8acbe07e56e8fe1baf9c9fa1519e.
Consider rename (index.new, store.idx) and open (store.idx) being
executed in parallel. When we break down operations following sequence
is possible.
* lookup (store.idx) - as part of open(store.idx) returns gfid1 as the
result.
* rename (index.new, store.idx) changes gfid of store.idx to
gfid2. Note that gfid2 was the nodeid of index.new. Since rename is
successful, gfid2 is associated with store.idx.
* open (store.idx) resumes and issues open fop to glusterfs with
gfid1. open in glusterfs fails as gfid1 doesn't exist and the error
returned by glusterfs to kernel-fuse is ENOENT.
* kernel passes back the same error to application as a result to
open.
This error could've been prevented if kernel retries open with
gfid2. Interestingly kernel do retry open when it receives ESTALE
error. Even though failure to find gfid resulted in ESTALE error,
commit 26d16b90ec7f8acb converted that error to ENOENT while sending
an error reply to kernel. This prevented kernel from retrying open
resulting in error.
Change-Id: I2e752ca60dd8af1b989dd1d29c7b002ee58440b4
BUG: 1500269
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
commit a8259df059bdbcce74b7850d9e449b816ddfb684
Author: Jeff Darcy <jdarcy@fb.com>
Date: Thu Jun 29 07:00:41 2017 -0700
project: update coding standard
Change-Id: I1d389c8d97ec1491be675bea2ff90898f1209861
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
commit f66d1c8e6319bf64734e1335134be27a20957eea
Author: Zhang Huan <zhanghuan@open-fs.com>
Date: Tue Sep 5 11:36:25 2017 +0800
cluster/dht: fix crash when deleting directories
In DHT, after locks on all subvolumes are acquired, it would perform the
following steps sequentially,
1. send remove dir on all other subvolumes except the hashed one in a loop;
2. wait for all pending rmdir to be done
3. remove dir on the hashed subvolume
The problem is that in step 1 there is a check to skip hashed subvolume
in the loop. If the last subvolume to check is actually the
hashed one, and step 3 is quickly done before the last and hashed
subvolume is checked, by accessing shared context data be destroyed in
step 3, would cause a crash.
Fix by saving shared data in a local variable to access later in the
loop.
Change-Id: I8db7cf7cb262d74efcb58eb00f02ea37df4be4e2
BUG: 1490642
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
commit be86c774ae0f9182f0fb5051d1548df73595cc9a
Author: Kamal Mohanan <kmohanan@redhat.com>
Date: Mon Sep 25 11:36:54 2017 +0530
cluster/ec: Coverity Fix UNUSED_VALUE in ec_create_name
Problem: The value returned by cluster_mkdir is assigned to ret at
ec-heal.c:1076. But this value is overwritten before it can be
used.
Solution: The return value of cluster_mkdir is ignored. It is not
assigned to ret.
Change-Id: Iee6b8d8b04e0bd800dd30d2c24cab755b9e63443
BUG: 789278
Signed-off-by: Kamal Mohanan <kmohanan@redhat.com>
commit 256e9acb5cfc13c07326a3e76dabd7a0b4193447
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Jul 31 12:45:21 2017 +0530
cluster/ec: Improve heal info command to handle obvious cases
Problem:
1 - If a brick is down and we see an index entry in
.glusterfs/indices, we should show it in heal info
output as it most certainly needs heal.
2 - The first problem is also not getting handled after
ec_heal_inspect. Even if in ec_heal_inspect, lookup will
mark need_heal as true, we don't handle it properly in
ec_get_heal_info and continue with locked inspect which
takes lot of time.
Solution:
1 - In first case we need not to do any further invstigation.
As soon as we see that a brick is down, we should say that
this index entry needs heal for sure.
2 - In second case, if we have need_heal as _gf_true after
ec_heal_inspect, we should show it as heal requires.
Change-Id: Ibe7f9d7602cc0b382ba53bddaf75a2a2c3326aa6
BUG: 1476668
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
commit 5e764808ec4adb0be21063b01183e761a7a80a3b
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Oct 12 14:31:14 2017 +0530
mount/fuse : Fix parsing of vol_id for snapshot volume
For supporting sub-dir mount, we changed the volid. Which means anything
after a '/' in volume_id will be considered as sub-dir path.
But snapshot volume has vol_id stracture of /snaps/<volname>/<snapname>
which has to be considered as during the parsing.
Note 1: sub-dir mount is not supported on snapshot volume
Note 2: With sub-dir mount changes brick based mount for quota cannot be
executed via mount command. It has to be a direct call via glusterfs
Change-Id: I0d824de0236b803db8a918f683dabb0cb523cb04
BUG: 1501235
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
commit c2993669c48f3efdaf44b7c3847987a58bc5d39a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Oct 4 14:22:05 2017 -0400
packaging: manual systemctl daemon reload required after install
Use the %systemd_{post,preun,postun_with_restart} macros provided.
Previous fix failed to build on koji Fedora 27 and 28 despite building
successfully in on Fedora 2x and CentOS 6 in jenkins and Fedora 25 and
26 in koji (but with late warnings emitted at the end of the build.)
Examination of the scriptlets (e.g. `rpm -qp --scripts glusterfs-server.rpm`)
revealed some ugliness that is addressed by the using %{nil} lines instead
of " ;"
After this, builds on CentOS 6, and old Fedora 27 rawhide, and koji f27 worked
without warnings or errors about macro recursion. Visual inspection of the
scripts appears correct. Fresh installs on CentOS 6 and Fedora 27 rawhide worked.
Updates from glusterfs-3.12.1 worked.
Reported-by: Sam McLeod <rhbugs@auto.smcleod.net>
Change-Id: I84e9dbc6ccd17cdfc2f7c025bdbf61e92523da79
BUG: 1495384
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 828ee334886cb5cd11eeb162788434a8d8616b9c
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Oct 10 15:50:33 2017 +0200
md-cache: free "struct mdc_conf" in fini()
Change-Id: Ia3a9b0152b7e36ded584150733e8392be458125c
BUG: 1443145
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit d9eda3028623c90c11bd3e9454ebaa677e4cfa70
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Oct 10 13:51:46 2017 +0200
gfapi: free xlator_cmdline_option_t when set through glfs_set_xlator_option()
Change-Id: I10c323477534fd50d29460cf71c246378659fca5
BUG: 1443145
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 0c7ce74914a28cdc1ddd1a97de4e15c5deca2ccc
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Oct 10 13:23:50 2017 +0200
build: make it possible to build cleanly 2x in a row
'make clean' does not cleanup everything, and some of the files get
cleaned too eagerly. Several files are being packaged in a 'make dist'
tarball, that get rebuild each time anyway.
Specifically, this change prevents
- libglusterfs/src/generator.pyc from laying around
- keeping rpc/xdr/gen/*.x symlinks
- modifying tests/basic/{fuse,gfapi}/Makefile each run
- including tests/env.rc and events/src/eventtypes.py in the tarball
Change-Id: I774dd1abf3a9d3b6a89b938cf6ee7d7792c59a82
BUG: 1501317
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 91aa1f6462a97e4f958dd2c6e6a3b1cc1fae0dc5
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Oct 10 10:27:01 2017 -0400
geo-rep: Filter out volume-mark xattr
The volume-mark xattr, maintained at brick root
of slave volume is specific to geo-replication
and should be filtered out for all other clients.
It should also be filtered out from list getxattr
from all mounts including geo-rep mount as it
might cause rsync to read and set.
Change-Id: If9eb5a3af18051083c853e70d93b2819e8eea222
BUG: 1500433
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 883cd97c2d8a2e427af5159c58f43aa7d660fda9
Author: Nigel Babu <nigelb@redhat.com>
Date: Thu Oct 12 18:59:15 2017 +0530
Disable failing NetBSD tests
BUG: 1501390
Change-Id: I9a04c094783ec33e617baeae3d0e0cbedb1d6c3b
commit bd00cc214901dd53c1002e5e8e18b1fd7cbbaae6
Author: Kamal Mohanan <kmohanan@redhat.com>
Date: Fri Sep 22 11:33:47 2017 +0530
xlators/debug/trace: Coverity Fix BUFFER_SIZE in reconfigure
Problem: strncpy was being called with a source string of length
equal to the size argument at lines 3110 and 3114.
Solution: Calculate the size argument from the size of the
destination argument.
Change-Id: I1fed6f8f47c5512b9489bfb3297e7a9911eacbc8
BUG: 789278
Signed-off-by: Kamal Mohanan <kmohanan@redhat.com>
commit 7081194b5c948c66c4e654ba4f014fc45aa7d066
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Sep 18 14:34:54 2017 +0530
eventsapi: Add JWT signing support
New argument added to accept secret to generate JWT token. This patch
does not affect the backward compatibility.
Usage:
gluster-eventsapi webhook-add <url> [-t <TOKEN>] \
[-s SECRET]
With `--token` argument, Token header will be added as is.
Authorization: Bearer <TOKEN>
In case of shared secret, Gluster will generate JWT token using the
secret and then add it to Authorization header.
Authorization: Bearer <GENERATED_TOKEN>
Secret/Token can be updated using `webhook-mod` command.
Generated token will include the following payload,
{
"iss": "gluster",
"exp": EXPIRY_TIME,
"sub": EVENT_TYPE,
"iat": EVENT_TIME
}
Where: iss - Issuer, exp - Expiry Time, sub - Event Type
used as Subject, iat - Event Time used as Issue Time
BUG: 1496363
Change-Id: Ib6b6fab23fb212d7f5e9bbc9e1416a9e9813ab1b
Signed-off-by: Aravinda VK <avishwan@redhat.com>
commit 753aa0656add4ba8bef4e08f808b7bf1b43c4e96
Author: Xavier Hernandez <jahernan@redhat.com>
Date: Fri Oct 6 10:39:58 2017 +0200
cluster/ec: add functions for stripe alignment
This patch removes old functions to align offsets and sizes
to stripe size boundaries and adds new ones to offer more
possibilities.
The new functions are:
* ec_adjust_offset_down()
Aligns a given offset to a multiple of the stripe size
equal or smaller than the initial one. It returns the
size of the gap between the aligned offset and the given
one.
* ec_adjust_offset_up()
Aligns a given offset to a multiple of the stripe size
equal or greater than the initial one. It returns the
size of the skipped region between the given offset and
the aligned one. If an overflow happens, the returned
valid has negative sign (but correct value) and the
offset is set to the maximum value (not aligned).
* ec_adjust_size_down()
Aligns the given size to a multiple of the stripe size
equal or smaller than the initial one. It returns the
size of the missed region between the aligned size and
the given one.
* ec_adjust_size_up()
Aligns the given size to a multiple of the stripe size
equal or greater than the initial one. It returns the
size of the gap between the given size and the aligned
one. If an overflow happens, the returned value has
negative sign (but correct value) and the size is set
to the maximum value (not aligned).
These functions have been defined in ec-helpers.h as static
inline since they are very small and compilers can optimize
them (specially the 'scale' argument).
Change-Id: I4c91009ad02f76c73772034dfde27ee1c78a80d7
Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
commit 22e84fabb1da3e57e09bcda2863ad78621c71159
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Oct 4 14:34:48 2017 +0530
gfapi: set lkowner in glfd
We need a provision to be able to set lkowner (which is
used to distinguish locks maintained by server) in gfapi.
Since the same lk_owner need to be used to be able to
flush the lock while closing the fd, store the lkowner
in the glfd structure itself.
A new API has been added to be able to set lkowner in glfd.
Change-Id: I67591d6b9a89c20b9617d52616513ff9e6c06b47
BUG: 1499641
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
commit f1503e5895fe26deebbe2b73c184e2aefb748952
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Oct 11 17:33:20 2017 +0530
protocol-auth: use the proper validation method
Currently, server protocol's init and glusterd's option
validation methods are different, causing an issue. They
should be same for having consistent behavior
Updates #175
Change-Id: Ibbf9a18c7192b2d77f9b7675ae7da9b8d2fe5de4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
commit 34dbf8f6f3280859f33608cfcb0cad9d556de7fd
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Sat Oct 7 03:33:40 2017 +0530
glusterd:Marking all the brick status as stopped when a process goes down in brick multiplexing
In brick multiplexing environment, if a brick process goes down
i.e., if we kill it with SIGKILL, the status of the brick for which
the process came up for the first time is only changing to stopped.
all other brick statuses are remain started. This is happening because
the process was killed abruptly using SIGKILL signal and signal
handler wasn't invoked and further cleanup wasn't triggered.
When we try to start a volume using force, it shows error saying
"Request timed out", since all the brickinfo->status are still in
started state, we're waiting for one of the brick process to come up
which never going to happen since the brick process was killed.
To resolve this, In the disconnect event, We are checking all the
processes that whether the brick which got disconnected belongs the
process. Once we get the process we are calling a function named
glusterd_mark_bricks_stopped_by_proc() and sending brick_proc_t object as
an argument.
From the glusterd_brick_proc_t we can get all the bricks attached
to that process. but these are duplicated ones. To get the original
brickinfo we are reading volinfo from brick. In volinfo we will have
original brickinfo copies. We are changing brickinfo->status to
stopped for all the bricks.
Change-Id: Ifb9054b3ee081ef56b39b2903ae686984fe827e7
BUG: 1499509
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 2b9d83a4cf27474db102650593d8e7a855253422
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Oct 10 08:25:19 2017 -0400
geo-rep: Fix passive brick's last sync time
Passive brick's stime was not updated to the
status file immediately after updating the brick
root. As a result the last sync time was showing
'0' until it finishes first crawl if passive
worker becomes active after restart. Fix is to
update the status file immediately after upgrading
the brick root.
Change-Id: I248339497303bad20b7f5a1d42ab44a1fe6bca99
BUG: 1500346
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit cdfa4c69523016c6f4c2783f9ccaecc2c317e6ae
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Oct 6 23:45:49 2017 -0400
geo-rep: Add EINTR to retry list while doing readlink
Worker occasionally crashed with EINTR on readlink.
This is not persistent and is transient. Worker restart
invovles re-processing of few entries in changenlogs.
So adding EINTR to retry list to avoid worker restart.
Change-Id: Iefe641437b5d5be583f079fc2a7a8443bcd19f9d
BUG: 1499393
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 60396763b38dde9c20ba384344c6919b72697a66
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Oct 6 22:42:43 2017 -0400
geo-rep: Add ENODATA to retry list on gfid getxattr
During xsync crawl, worker occasionally crashed
with ENODATA on getting gfid from backend. This
is not persistent and is transient. Worker restart
invovles re-processing of few entries in changenlogs.
So adding ENODATA to retry list to avoid worker
restart.
Change-Id: Ib78d1e925c0a83c78746f28f7c79792a327dfd3e
BUG: 1499391
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 1693d58177cec6f8c0e5a0008e9372cbc5b96671
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Oct 10 05:54:04 2017 -0400
geo-rep: Fix status transition
The status transition is as below which is
wrong.
Created->Initializing->Active->Active/Passive->Stopped
As soon as the monitor spawns the worker, the state
is changed from 'Initializing' to 'Active' and then to
'Active/Passive' based on whether worker gets the lock
or not. This is wrong and it should directly tranistion
as below.
Created->Initializing->Active/Passive->Stopped
Change-Id: Ibf5ca5c4fdf168c403c6da01db60b93f0604aae7
BUG: 1500284
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 85882983a22b0db0a8425955a3c8c4af5acf5842
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Oct 10 15:39:30 2017 +0200
rpc: free conn->name in rpc_clnt_destroy()
Change-Id: Idf99908aa48718a7faf7f0bbc647a679ec548282
BUG: 1443145
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 879629f6356916be27cab250cb7719d08675f65e
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Oct 9 18:58:09 2017 +0200
rpc: free registered callback programs
Change-Id: I8c6f6b642f025d1faf74015b8f7aaecd7ebfd4d5
BUG: 1443145
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 59d9b2537d0df6088da7e378521d659ef2e54048
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Oct 9 17:56:56 2017 +0200
dht: free memory allocated in dht_init() and dht_init_subvolumes()
When glfs_fini() is called, DHT fails to free all memory allocations
which result in a considerable leak.
Change-Id: I37c6de5c93ca4516266dbe8288b4a416f5589901
BUG: 1443145
Signed-off-by: Niels de Vos <ndevos@redhat.com>
commit 500b073bb5d14965a22d5dd1a1af87b8bca92556
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Fri Sep 22 16:13:44 2017 +0530
xlator/debug :coverity Issue BUFFER_SIZE
Issue :Calling strncpy with a source string whose length (2 chars)
is greater than or equal to the size argument (2) will fail to
null-terminate "trace_fop_names[i].name".
Solution : The size argument is obtained from
sizeof(trace_fop_names[i].name).
Change-Id: I99fad2693054f3af84d78da34c61258233d3049a
BUG: 789278
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit 2b3383a4ffde2fa79cec90f2efbd5735bf73e846
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Oct 6 06:02:56 2017 -0400
geo-rep: Add ENOTSUP error to retry list
os.listdir gives ENOTSUP on gfid path occasionally
which is not persistant. Adding it to retry list
to avoid worker to crash if it's transient error.
Change-Id: Ic795dd1f02a27c9e5d901e20722ee32451838feb
BUG: 1499180
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit c4328706116ab7af304f453b3f8fc1dd5ea83192
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Jul 21 16:38:14 2017 +0530
cluster/dht: Don't store the entire uuid for subvols
Comparing the uuid string of the local node against that stored in the
local_subvol information is inefficient, especially as it is
done for every file to be migrated. The code has now been changed
to set the value of info to 1 if the nodeuuid is that of the node
making the comparison so this becomes an integer comparison.
Change-Id: I7491d59caad3b71dbf5facc94dcde0cd53962775
BUG: 1451434
Signed-off-by: N Balachandran <nbalacha@redhat.com>
commit 58a11d39c36637345516051a227e6d1e0f16470c
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Tue Aug 8 12:09:25 2017 +0530
gfproxy: Introduce new server-side daemon called GFProxy
Summmary:
Adds a new server-side daemon called gfproxyd & a new FUSE client
called gfproxy-client
Updates: #242
BUG: 1428063
Change-Id: I83210098d3a381922bc64fed1110ae1b76e6519f
Tested-by: Shreyas Siravara <sshreyas@fb.com>
Reviewed-by: Kevin Vigor <kvigor@fb.com>
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
commit 042d7e37fe20d21c93936a68e31a18f68b68ad88
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 18 18:39:01 2017 +0530
cluster/ec: Handle parallel get_size_version
Updates #251
Change-Id: I6244014dbc90af3239d63d75a064ae22ec12a054
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit 9d2b0e5bef774ca16fd6f2570d4ef00f8cb2a9b3
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Oct 9 14:10:52 2017 +0530
test: Mark test case ./tests/bugs/bug-1371806_1.t as a bad test case
Problem: Test case ./tests/bugs/bug-1371806_1.t is failing.
Solution: Mark test case ./tests/bugs/bug-1371806_1.t as a bad test case.
BUG: 1499663
Change-Id: Icb3f41d23dcc74cce6fde05ca343c158d5f58cdd
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 85491d99376cdf1b50916331e1f8172aa1edb79e
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Oct 3 18:41:11 2017 +0530
glusterd : fix client io-threads option for replicate volumes
Problem:
Commit ff075a3d6f9b142911d25c27fd209838782bfff0 disabled loading
client-io-threads for replicate volumes (it was set to on by default in
commit e068c1997314046658dd502e9118dab32decf879) due to performance
issues but in doing so, inadvertently failed to load the xlator even if
the user explicitly enabled the option using the volume set command.
This was despite returning returning sucess for the volume set.
Fix:
Modify the check in perfxl_option_handler() and add checks in volume
create/add-brick/remove-brick code paths, tying it all to
GD_OP_VERSION_3_12_2.
Change-Id: Ib612973a999a7da818cc926f5c2601b1f0794fcf
BUG: 1498570
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit db3b1afe348882108be9a25f58fa0f9f00773ed0
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Sep 20 12:16:06 2017 +0530
afr: heal gfid as a part of entry heal
Problem:
If a brick crashes after an entry (file or dir) is created but before
gfid is assigned, the good bricks will have pending entry heal xattrs
but the heal won't complete because afr_selfheal_recreate_entry() tries
to create the entry again and it fails with EEXIST.
Fix:
We could have fixed posx_mknod/mkdir etc to assign the gfid if the file
already exists but the right thing to do seems to be to trigger a lookup
on the bad brick and let it heal the gfid instead of winding an
mknod/mkdir in the first place.
Change-Id: I82f76665a7541f1893ef8d847b78af6466aff1ff
BUG: 1493415
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit b1ce05c1319c49a89c1468a78e2d8d0728185ca1
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Oct 6 05:33:31 2017 -0400
geo-rep/scheduler: Add validation for session existence
Added validation to check for session existence
to give out proper error message out.
Change-Id: I13c5f6ef29c1395cff092a14e1bd2c197a39f058
BUG: 1499159
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit 80d2324ae5c39a8f50fb8bbbeec76acb33fc8180
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Fri Apr 28 18:09:01 2017 +0530
cluster/ec: Improve performance with xattrop update
Existing EC code updates the xattr on the subvolume
in a sequential pattern resulting in very poor performance.
With this fix EC now updates the xattr on the subvolume
in parallel which improves the xattr update performance.
BUG: 1445663
Change-Id: I3fc40d66db0b88875ca96a9fa01002ba386c0486
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
commit 54852dddff953b1cdf0ca1b5cd0f53e0f5c65c5c
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Mon Sep 25 14:58:13 2017 +0530
xlator/cluster/afr:coverity Issue "UNUSED_VALUE" in afr_get_split_brain_status
Issue: Event value_overwrite:Overwriting previous write to "ret"
with value "-1".
Fix : An "If" condition is added to check the value of "ret".
Change-Id: I7b6bd4f20f73fa85eb8a5169644e275c7b56af51
BUG: 789278
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit 227cc741602bdb94122d628769a0d915e198f0c1
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Jun 27 17:17:56 2016 +0530
storage/posix: Adding implementation for posix_do_futimes
Adding the implementation for the posix_do_futimes function which is
not complete in the current implementation and giving the ENOSYS error.
Change-Id: I9cfc95a7ea293b0a2df8efd4ac80d0120b3120e4
BUG: 1350406
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit e8b3ff34487896abf1e6fff1f045ba41b58de1a2
Author: Kartik_Burmee <kburmee@redhat.com>
Date: Mon Sep 25 15:49:36 2017 +0530
Coverity issue fix: checked return
issue:Calling "client_submit_request" without checking return value (as is done elsewhere 52 out of 58 times).
function: client_fdctx_destroy
Change-Id: I66a295dd114fc20f04eb1aca9a5b274df53be090
BUG: 789278
fix: typecasted function return value using void
Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
commit 725aa34c91ea8c57531ba31cef9ec1976c6d7cc5
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri May 12 21:12:47 2017 +0530
cluster/dht : User xattrs are not healed after brick stop/start
Problem: In a distributed volume custom extended attribute value for a directory
does not display correct value after stop/start or added newly brick.
If any extended(acl) attribute value is set for a directory after stop/added
the brick the attribute(user|acl|quota) value is not updated on brick
after start the brick.
Solution: First store hashed subvol or subvol(has internal xattr) on inode ctx and
consider it as a MDS subvol.At the time of update custom xattr
(user,quota,acl, selinux) on directory first check the mds from
inode ctx, if mds is not present on inode ctx then throw EINVAL error
to application otherwise set xattr on MDS subvol with internal xattr
value of -1 and then try to update the attribute on other non MDS
volumes also.If mds subvol is down in that case throw an
error "Transport endpoint is not connected". In dht_dir_lookup_cbk|
dht_revalidate_cbk|dht_discover_complete call dht_call_dir_xattr_heal
to heal custom extended attribute.
In case of gnfs server if hashed subvol has not found based on
loc then wind a call on all subvol to update xattr.
Fix: 1) Save MDS subvol on inode ctx
2) Check if mds subvol is present on inode ctx
3) If mds subvol is down then call unwind with error ENOTCONN and if it is up
then set new xattr "GF_DHT_XATTR_MDS" to -1 and wind a call on other
subvol.
4) If setxattr fop is successful on non-mds subvol then increment the value of
internal xattr to +1
5) At the time of directory_lookup check the value of new xattr GF_DHT_XATTR_MDS
6) If value is not 0 in dht_lookup_dir_cbk(other cbk) functions then call heal
function to heal user xattr
7) syncop_setxattr on hashed_subvol to reset the value of xattr to 0
if heal is successful on all subvol.
Test : To reproduce the issue followed below steps
1) Create a distributed volume and create mount point
2) Create some directory from mount point mkdir tmp{1..5}
3) Kill any one brick from the volume
4) Set extended attribute from mount point on directory
setfattr -n user.foo -v "abc" ./tmp{1..5}
It will throw error " Transport End point is not connected "
for those hashed subvol is down
5) Start volume with force option to start brick process
6) Execute getfattr command on mount point for directory
7) Check extended attribute on brick
getfattr -n user.foo <volume-location>/tmp{1..5}
It shows correct value for directories for those
xattr fop were executed successfully.
Note: The patch will resolve xattr healing problem only for fuse mount
not for nfs mount.
BUG: 1371806
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I4eb137eace24a8cb796712b742f1d177a65343d5
commit f196f25d71c5e7641d5d8ca86a5dd3d8a4fc77b8
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 14 14:31:26 2017 -0400
xlator/bitrot: flood of -Wformat-truncation warnings with gcc-7.1
Starting in Fedora 26 which has gcc-7.1.x, -Wformat-trunction is enabled
with -Wformat, resulting in a flood of new warnings. This many warnings
is a concern because it makes it hard(er) to see other warnings that
should be addressed.
An example is at
https://kojipkgs.fedoraproject.org//packages/glusterfs/3.12.0/1.fc28/data/logs/x86_64/build.log
For more info see https://review.gluster.org/#/c/18267/
Change-Id: I7792d94da1e8109f3aaa857a94be40f2d2402684
BUG: 1492851
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 1520aa5d83f9f9473c857a17a72cc9f3066e1bd0
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue Oct 25 19:57:02 2016 +0530
cli/afr: gluster volume heal info "healed" command output is not appropriate
Problem: "gluster volume heal info [healed] [heal-failed]" command
output on terminal is not appropriate in case of down any volume.
Solution: To make message more appropriate change the condition
in function "gd_syncop_mgmt_brick_op".
Test : To verify the fix followed below procedure
1) Create 2*3 distribute replicate volume
2) set self-heal daemon off
3) kill two bricks (3, 6)
4) create some file on mount point
5) bring brick 3,6 up
6) kill other two brick (2 and 4)
7) make self heal daemon on
8) run "gluster v heal <vol-name>"
Note: After apply the patch options (healed | heal-failed) will deprecate
from command line.
BUG: 1388509
Change-Id: I229c320c9caeb2525c76b78b44a53a64b088545a
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
commit 04121f3856afd3a974123af078cc24ad7909d686
Author: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
Date: Thu Sep 21 14:07:16 2017 +0530
xlators/io-stats: Coverity Fix CHECKED_RETURN in resolve_group_name
Issue: Calling "getgrgid_r(gid, &grp, grp_buf, grp_buf_len, &grp_result)"
without checking return value. This library function may fail and return
an error code
Solution: getgrgrid_r returns zero when the operation is successful
and a non-zero error code if there's some error in the operation
Fix: Checked for the return value and redirected to error if the
return value was non-zero
Change-Id: I0d082c6d57c6148b9830bc020140946c06d6f800
BUG: 789278
Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
commit 900e7a06ba41f5dcf22c57ef12c38ad6d2a77654
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Fri Sep 22 18:17:03 2017 +0530
glusterd/snapshot: Buffer Size Warning
new_brickinfo->mnt_opts is allocated memory using calloc. So it is
already zeroed out at allocation. we need not to add null character
at the end. we pass one less than maximum size to the strncpy to make
sure that destination string is terminated.
Change-Id: I463dddd2171fb39a509bb75ffcc074d5b1cf7d62
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 57f73670ad9c55ff2832dcd218c36af317d7d8ed
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Oct 2 10:44:59 2017 -0400
packaging: manual systemctl daemon reload required after install
Use the %systemd_{post,preun,postun_with_restart} macros provided
I tried both install and update from 3.10.x and did not receive
any warnings about needing daemon reload
Reported-by: Sam McLeod <rhbugs@auto.smcleod.net>
Change-Id: Ibb33a748fc4226864019765b59d1a154b7297bae
BUG: 1495384
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 2d5197928cdd382af2d3ef2c7351645b6639359d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Aug 11 15:43:58 2017 +0530
cluster/afr: Make choose-local "reconfigurable"
With this change, enabling choose-local (which means its state makes
transition from "off" to "on") will be effective after the first
gfid-lookup on "/" since volume-set was executed.
Change-Id: Ibab292ba705d993b475cd0303fb3318211fb2500
BUG: 1480525
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 267394383fba59cee7be797ce8a000e260c1579d
Author: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
Date: Thu Sep 21 18:12:59 2017 +0530
libglusterfs: Coverity Fix CONSTANT_EXPRESSION_RESULT in gf_string2int64
Issue : "l <= 9223372036854775807L" is always true regardless of the values
of its operands. This occurs as the logical operand of "if".
Solution : Remove the comparison which always turns out to be true
Fix : The if-condition was removed and the body inside the same was retained.
Change-Id: Iba94d7f4f2dee85a180d10cdb7f7235b406cc400
BUG: 789278
Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
commit 42ef0ee2675a4de1d1a5068b1ca6ce4f0b1ece3b
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Fri Sep 22 19:34:12 2017 +0530
glusterfsd: Coverity Issue "MISSING_BREAK" in parse_opts
Issue:Event unterminated_case: The case for value
"ARGP_LOCALTIME_LOGGING_KEY" is not terminated by a
'break' statement.
Solution: A break statement is added in the fallthrough case.
Change-Id: Ie44d1a291afaa0e9fb9ef2aa45368b9401a8bb82
BUG: 789278
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit 3c5c869d02b8da08fc08c86119e6f76d8aa415f0
Author: Akarsha Rai <akrai@redhat.com>
Date: Tue Sep 26 06:09:28 2017 -0400
cluster/ec: FORWARD_NULL coverity fix
Problem: ctx pointer could be NULL
Solution: Updated the code to verify ctx pointer
BUG: 789278
Change-Id: I25e07a07c6ebe2f630c99ba3aa9a61656fbaa981
Signed-off-by: Akarsha Rai <akrai@redhat.com>
commit 27c471d1e3b11beacb5259ce27d9ef9100ee3add
Author: Girjesh Rajoria <grajoria@redhat.com>
Date: Sat Sep 23 02:28:34 2017 +0530
libglusterfs: Coverity Issue NEGATIVE_RETURNS
Issue: Event negative_return_fn: Function "dup(handle->fd)" returns a
negative number. Event negative_returns: "dup(handle->fd)" is passed
to a parameter that cannot be negative.
With this change value of dup(handle->fd) is stored in duped_fd & if
condition checks the value of duped_fd is non-negative.
Change-Id: I563d717108016d740ffa64fbe0929eb1e08c8f33
BUG: 789278
Signed-off-by: Girjesh Rajoria <grajoria@redhat.com>
commit 5f8ef60f7d7d74a67f6093581bb46049a8a3f864
Author: Akarsha Rai <akrai@redhat.com>
Date: Thu Sep 28 07:18:56 2017 -0400
core: Verify pool pointer before destroying it
Problem: Current code is not checking whether the pool pointer is null or not.
Solution: Updated the code to verify pool pointer.
Bug: 1496675
Change-Id: Ie1f2de4e4204fde15d2b1e3a966ea4c9e7b41534
Signed-off-by: Akarsha Rai <akrai@redhat.com>
commit c804121cea34f103cdb4a20c94a18c3d5112de3b
Author: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
Date: Thu Sep 21 20:19:44 2017 +0530
cli: fix Coverity warning DEADCODE in gf_cli_attach_tier()
Issue : At condition "ret", the value of "ret" must be equal to 0.
The condition "ret" cannot be true since the value is always 0.
Hence, the execution cannot reach the statement "goto out"
Solution : The never-true if-condition and its body has to be removed
Fix : The always false if-condition and the dead code under this
if-condition was removed.
Change-Id: I5c038b8ec9abf9b2f06dcfd981904b9dca1a0094
BUG: 789278
Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
commit b62a51dd4ee149d9bdfdba5777ba988fc6da3552
Author: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
Date: Thu Sep 21 20:55:05 2017 +0530
protocol/client: Coverity Fix IDENTICAL_BRANCHES in client3_3_flush_cbk
Issue : The same code is executed when the condition "ret < 0" is true
or false, because the code in the if-then branch and after the if
statement is identical.
Solution : Remove the if-condition whose output does not alter the
program flow of control
Fix : The identical branching condition was removed.
Change-Id: Iae40f068e5a03946273e1091886ba7011460fcc8
BUG: 789278
Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
commit c9efb826b1a76e1242bc3872e5e2d78af9392b3d
Author: Akarsha Rai <akrai@redhat.com>
Date: Tue Sep 26 06:44:15 2017 -0400
cluster/ec: FORWARD_NULL coverity fix
Problem:
cbk could be NULL.
Solution:
Returning NULL when memory is not allocated
for cbk.
BUG: 789278
Change-Id: Iea9128e0f3b95100deca560f690f9baaae226abf
Signed-off-by: Akarsha Rai <akrai@redhat.com>
commit b5afc1dca46897e35ec258d1e8ad3236ec594462
Author: Girjesh Rajoria <grajoria@redhat.com>
Date: Mon Sep 25 14:52:24 2017 +0530
xlators/protocol/server: Coverity Issue in server_setvolume()
Issue: Event result_independent_of_operands: "rsp->dict.dict_len > 4294967295U
/* 2147483647 * 2U + 1U */" is always false regardless of the values of its
operands. This occurs as the logical operand of "if".
Fix: removed if block as the if condition is always false and statement inside
block never executes.
Change-Id: Ieaa968d6fbc9477428b4658ef725ace0db9b810a
BUG: 789278
Signed-off-by: Girjesh Rajoria <grajoria@redhat.com>
commit 029af32e54b69997132051cd58ab6a99d4bca847
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Sep 25 17:29:25 2017 +0530
stack.h:PW.INCLUDE_RECURSION
The headerfile globals.h is recursively adding itself.
( globals.h -> xlator.h -> stack.h -> globals.h).
We are finding the source files which are including the header
file globals.h and removing the inclusion line.
I used git grep -l stack.h | xargs git grep globals.h --
to find out the files and removed the header file from all files
except libglusterfs/src/xlator.h and libglusterfs/src/Makefile.am
When I try to remove header file from libglusterfs/src/xlator.h
I'm getting some errors. In libglusterfs/src/Makefile.am it is
required for building RPMs.
Change-Id: I537218c09ade6d7ea51717768b26563a247daf60
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 61acbab288c466932f5f5351d3be1fff220eb20a
Author: hari gowtham <hgowtham@redhat.com>
Date: Thu Sep 28 15:43:30 2017 +0530
Posix: fix additional inode ref
Problem: In the iteration, the inode is being ref-ed twice and
unref-ed once. this leads to ref leak.
Fix: assign the parent to the inode instead of referencing it.
Change-Id: Ib154b12d38ad68220f8f5288bbc50081beccc2b9
BUG: 1496379
Signed-off-by: hari gowtham <hgowtham@redhat.com>
commit 8d7e566c4907c10c71bb01474d5e7c4022abe19c
Author: Girjesh Rajoria <grajoria@redhat.com>
Date: Fri Sep 22 19:09:34 2017 +0530
rpc/rpc-transport/socket/: Coverity Issue MISSING_BREAK
Issue: Event unterminated_case: The case for value "AF_INET_SDP"
is not terminated by a 'break' statement.
Function: socket_server_get_local_sockaddr
Added Fall through in comment after case AF_INET_SDP.
Change-Id: I5340cde2257be33ff13c53cee6ccdb33df7d2c88
BUG: 789278
Signed-off-by: Girjesh Rajoria <grajoria@redhat.com>
commit a72649bf7cc68f796c83ec758af9e854e4471107
Author: Kamal Mohanan <kmohanan@redhat.com>
Date: Mon Sep 25 12:07:03 2017 +0530
dht: fix a coverity error of type - UNREACHABLE
Problem: Unreachable assignment statement at dht-rebalance.c:1040
Fix: Delete line dht-rebalance.c:1040.
The goto statements at lines 1037 and 1031 are also deleted since
both branches of the if statement finally go to the same
immediately-following label anyway.
Change-Id: I5f47ea99244cae2a0a9f2aec7284faadf2ea286a
BUG: 789278
Signed-off-by: Kamal Mohanan <kmohanan@redhat.com>
commit 89161777ba2501fb5b0a68a5251e4ce2a417155f
Author: Akarsha Rai <akrai@redhat.com>
Date: Tue Sep 26 04:58:19 2017 -0400
cluster/ec: FORWARD_NULL coverity fix
Problem: Pool pointer could be NULL while destroying it.
Solution: Verifying pointer before destroying it.
BUG: 789278
Change-Id: I497d1310aa47cb749a4c992aa961bd4dfa23ee48
Signed-off-by: Akarsha Rai <akrai@redhat.com>
commit c259116dddfa846a89bce7252ff8184bbec64159
Author: Akarsha Rai <akrai@redhat.com>
Date: Tue Sep 26 08:51:04 2017 -0400
protocol: UNINIT coverity fix
Problem: Coverity issue due uninitialized variable.
Solution: Initialized the variable appropriately.
Bug: 789278
Change-Id: I6e9356bbcd8fa97006b605ee162458d4a2eb5887
Signed-off-by: Akarsha Rai <akrai@redhat.com>
commit 24d5985c6239588ce3160e52741c75164f035c00
Author: Kamal Mohanan <kmohanan@redhat.com>
Date: Mon Sep 25 12:50:43 2017 +0530
libglusterfs: fix a coverity error of type - PW.INCLUDE_RECURSION
Problem: xlator.h which is included at inode.h:32 includes itself.
Solution: Delete the include statement.
Change-Id: I304bbef5293a2fef0584773a1f8e61e838d7cbf1
BUG: 789278
Signed-off-by: Kamal Mohanan <kmohanan@redhat.com>
commit 0b20fde5818698b37f30007055a95e116d75c1ad
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Sep 22 12:50:43 2017 +0530
features/locks: Maintain separation of lock->client_pid, flock->l_pid
Problem:
grant_blocked_locks() constructs flock from lock. Locks xlator uses
frame->root->pid interchangeably flock->l_pid. With gNFS frame->root->pid
(which translates to lock->client_pid) is not same as flock->l_pid, this leads
to lk's cbk returning flock with l_pid from lock->client_pid instead of input
flock->l_pid. This triggers EC's error code path leading to failure of lk call,
because the response' flock->l_pid is different from request's flock->l_pid.
Fix:
Maintain separation of lock->client_pid, flock->l_pid. Always unwind with
flock with correct pid.
BUG: 1472961
Change-Id: Ifab35c458662cf0082b902f37782f8c5321d823d
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
commit e670f36e86d24a54031d8760d4a59c98891a66a0
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Sep 26 14:03:52 2017 +0530
afr: don't check for file size in afr_mark_source_sinks_if_file_empty
... for AFR_METADATA_TRANSACTION and just mark source and sinks if
metadata is the same.
Change-Id: I69e55d3c842c7636e3538d1b57bc4deca67bed05
BUG: 1491670
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
commit a1066121b675e8c387d1299610d52e0262f6506a
Author: Akarsha Rai <akrai@redhat.com>
Date: Mon Sep 25 08:36:36 2017 -0400
glusterd: FORWARD_NULL coverity fix
Problem:
Pointer used to print xlator name could be NULL.
Solution:
Updated the code to use xlator name as appropriate.
BUG: 789278
Change-Id: I26927ef1f33f362e17c104684d7f722a643c7f97
Signed-off-by: Akarsha Rai <akrai@redhat.com>
commit 30d695dfdd351eab166c86611dbd04de9a319a0d
Author: Girjesh Rajoria <grajoria@redhat.com>
Date: Sat Sep 23 02:00:56 2017 +0530
Coverity Issue Fix: IDENTICAL_BRANCHES
Issue: Event identical_branches: The same code is executed when the condition "ret" is true or false, because the code in the if-then branch and after the if statement is identical.
Function: glusterd_print_gsync_status_by_vol
Fix: removed if and goto statement.
Change-Id: I966d793c9f3b65487acfb07083a4039caf593105
BUG: 789278
Signed-off-by: Girjesh Rajoria <grajoria@redhat.com>
commit cec0d5828ca9ab6e02aa6014329eb2b12d6ac128
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Sep 25 15:53:24 2017 +0530
Posix: Unused value
In line number 5179 we are storing -1 into op_ret variable. Before
we use the value we are overwriting the same variable in line
number 5339. So we are removing the value assigning statement.
Change-Id: I8c6dae9f6b0f9f1e3c09d0744d451b9296d12db8
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit 921dbcae9ad44032c764598d2a2eee32432fa32d
Author: Sanju Rakonde <srakonde@redhat.com>
Date: Mon Sep 25 12:34:05 2017 +0530
Glusterfsd: Unreachable statements
Issue: Event unreachable at line number 1111 in glusterfsd/src/glusterfsd.c
There was a statement in outer if block after the break statement.
Ideally the break statement should be inside the inner if block so
that the statement will not become unreachable. I put the break
inside the inner if block.
Change-Id: Id4917305333e1638f35b3f2fb59ac42e62a12d02
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
commit d08d2481c00ea7142287fddc1dbc27fd37bdd1ca
Author: Subha sree Mohankumar <smohanku@redhat.com>
Date: Mon Sep 25 11:49:16 2017 +0530
Coverity Issue Fix : CHECKED_RETURN
Issue :Event check_return: Calling "ec_dict_set_number" without checking return value.
Fix : Type casted the return value of the function "ec_dict_set_number" to void.
Change-Id: Id97034f9b1b8591536d63dca680ca7c7a9c4fcc3
BUG: 789278
Signed-off-by: Subha sree Mohankumar <smohanku@redhat.com>
commit 07abe080dfe39ff88e59cb5d7413fc3d44b1796f
Author: Kamal Mohanan <kmohanan@redhat.com>
Date: Mon Sep 25 10:57:21 2017 +0530
Fix a coverity error of checker type: CHECKED_RETURN
Problem: dht_frame_return was being called without checking the
return value.
Solution: Typecast the value returned by the function to void.
Change-Id: Idfc6a7ed467d1c8f5f8d09ec26d9059f3d23b760
BUG: 789278
Signed-off-by: Kamal Mohanan <kmohanan@redhat.com>
commit 680719754763b93547cbf10f98365e2fb1352681
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Sep 25 23:34:55 2017 -0400
geo-rep/scheduler: Fix '--no-color' help msg
Change-Id: I0f51558083e0b11a6563b8a2ef62ec07fe2a9ca9
BUG: 1495436
Signed-off-by: Kotresh HR <khiremat@redhat.com>
commit c3bf3ccdb2ae1a7dc7ac5dacae17f1bd4eecfc18
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Sep 14 11:29:15 2017 +0530
afr: auto-resolve split-brains for zero-byte files
Problems:
As described in BZ 1491670, renaming hardlinks can result in data/mdata
split-brain of the DHT link-to files (T files) without any mismatch of
data and metadata.
As described in BZ 1486063, for a zero-byte file with only dirty bits
set, arbiter brick will likely be chosen as the source brick.
Fix:
For zero byte files in split-brain, pick first brick as
a) data source if file size is zero on all bricks.
b) metadata source if metadata is the same on all bricks
In arbiter case, if file size is zero on all bricks and there are no
pending afr xattrs, pick 1st brick as data source.
Change-Id: I0270a9a2f97c3b21087e280bb890159b43975e04
BUG: 1491670
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reported-by: Rahul Hinduja <rhinduja@redhat.com>
Reported-by: Mabi <mabi@protonmail.ch>
commit 8a42ab92fa3ac049b4e6f11e269aff866042e8e7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Sep 21 14:05:35 2017 +0530
glusterd: retrieve uuid under mutex lock
In a multi node cluster, if one of the glusterd instance goes down and
comes back, then there might be a race situation where glusterd needs to
retrieve its uuid (glusterd_retrieve_uuid) and at the same time as part of
receiving a friend handshake from other peer, glusterd iterates over the volume
information recieved from remote node and checks for if a brick is local or not
by calling MY_UUID which in turn calls glusterd_retrieve_uuid. And the
same applies for glusterd_store_global_info () function too. This
could end up in a situation where for the same node glusterd ends up
generating two UUID files in /var/lib/glusterd. Following is the log
snippet which confirms the above:
[2017-09-01 03:09:24.458030] I [glusterd.c:146:glusterd_uuid_init] 0-management: retrieved UUID: fd46a495-7e33-468f-88f6-63c815fac640 // thread 1 retrieve uuid from glusterd.info
[2017-09-01 03:09:24.458034] E [glusterd-store.c:2109:glusterd_retrieve_uuid] 0-: No previous uuid is present
//thread 2 can not retrieve uuid, because in thread1 the file pointer has already become eof.
[2017-09-01 03:09:24.458041] E [glusterd-store.c:2117:glusterd_retrieve_uuid] 0-: Returning -1
[2017-09-01 03:09:24.458076] I [glusterd.c:176:glusterd_uuid_generate_save] 0-management: generated UUID: 190bb292-a296-4125-96da-42b247511cc4
[2017-09-01 03:09:24.458129] E [store.c:367:gf_store_save_value] 0-: Able to store key: UUID,value: 190bb292-a296-4125-96da-42b247511cc4
Fix is to retrieve the uuid under mutex lock.
Credits : cynthia.zhou@nokia-sbell.com
Change-Id: Ib9a5e159c3febf2aef13aa5e38f0a51fe409dadb
BUG: 1493967
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
commit cc2dc763cc9b9bbc221fa114b98a06f140c51827
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Sep 7 18:48:34 2017 +0530
mount/fuse: Make event-history feature configurable
... and disable it by default.
This is because having it disabled seems to improve performance.
This could be due to the lock contention by the different epoll threads
on the circular buff lock in the fop cbks just before writing their response
to /dev/fuse.
Just to provide some data - wrt ovirt-gluster hyperconverged
environment, I saw an increase in IOPs by 12K with event-history
disabled for randrom read workload.
Usage:
mount -t glusterfs -o event-history=on $HOSTNAME:$VOLNAME $MOUNTPOINT
OR
glusterfs --event-history=on --volfile-server=$HOSTNAME --volfile-id=$VOLNAME $MOUNTPOINT
Change-Id: Ia533788d309c78688a315dc8cd04d30fad9e9485
BUG: 1467614
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 8149a3a4626e87a6208eafc8da07f773857e2dd4
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Sep 21 12:09:12 2017 +0530
cli: Bypass the confirmation question creating replica 2 volume with force
When a replica 2 volume is created with the force option,
remove the warning message with the confirmation question,
whether they want to continue or not and Succeed the
volume creation.
Change-Id: I4f3306659fa4cbf53dd8d45269a32d19ce86ac88
BUG: 1493893
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 3e539ea238a23b285b9ecdc6095cb756349f0d1b
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Sep 19 15:34:04 2017 +0530
libglusterfs: Fix openSUSE build error
GlusterFS failed during make on openSUSE Tumbleweed with the following
error:
Making all in fdl
Making all in src
CC logdump.o
CC recon.o
CC fdl.lo
CC librecon.o
CC libfdl.o
CCLD gf_logdump
CCLD gf_recon
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../lib64/libfl.so: undefined reference to `yylex'
collect2: error: ld returned 1 exit status
make[5]: *** [Makefile:618: gf_logdump] Error 1
make[5]: *** Waiting for unfinished jobs....
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../lib64/libfl.so: undefined reference to `yylex'
collect2: error: ld returned 1 exit status
Reading through autoconf manual[1](see AC_PROG_LEX) reveals that LEXLIB
is automatically set to appropriate value for the system. The reference
to LEXLIB in automake file caused the above mentioned error on openSUSE.
In particular, we do not bother about LEXLIB hereafter.
[1] https://www.gnu.org/software/autoconf/manual/autoconf.html#Particular-Programs
Change-Id: I9bfce80c9654b2e3bfb393b08c25e8ad3d79e449
BUG: 1493133
Signed-off-by: Anoop C S <anoopcs@redhat.com>
commit 332c09ba38cd99b2fafdee6497e45cb8bc707def
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Sep 20 18:30:21 2017 +0530
cluster/afr: Sending subvol up/down events when subvol comes up or goes down
Change-Id: I6580351b245d5f868e9ddc6a4eb4dd6afa3bb6ec
BUG: 1493539
Signed-off-by: karthik-us <ksubrahm@redhat.com>
commit 3839fed8b75b2f9e26a377c3a8cab8a846c7ce1f
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Sat Sep 2 09:49:06 2017 -0400
cluster/ec: fix for BAD_SHIFT, follow-up patch
Address comments to https://review.gluster.org/18067, (Change-Id
I86e15d12939c610c99f5f96c551bb870df20f4b4)
Which was posted as an RFC as an example of a possible alternative
fix to https://review.gluster.org/17860 (Change-Id
I28a3bdd4a357526dba0cf84c262919c05cfa173e)
An alternative fix that preserved the unsignedness of the indexes
throughout, obviating the need to check its value before using it to
shift. (shift by negative number is undefined, as is shift by more
bits than in the type.)
BUG: 1474309
Change-Id: I46fe9cec140d3397463780748f6876251acb06dd
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
commit 5f7a0d4439b31769cc25fd3c735e900bec99daf8
Author: Susant Palai <spalai@redhat.com>
Date: Mon Aug 7 15:19:47 2017 +0530
fuse/readdirp: Remove need_lookup from fuse_readdirp_cbk
background: Various xlators used to populate their ctx, on
an explicit lookup. That means without a lookup, the translator will have
either null or stale data to function. E.g. dht would depend on lookup to
create linkto files on the correct node/hashed subvol, afr would rely on
this lookup to heal pending data/metadata etc.
So to complete above actions a lookup used to be issued on files,
even their inode was populated on a readdirp_cbk. This was done
by setting the need_lookup flag on all the files those were read
on readdirp fop.
We tried a small test on "ACL client". For listing 50k files on root
itself, it took around 50seconds with readdirp enabled while
the same operation took 5-6 seconds with readdirp disabled. Both the
times md-cache was enabled.
We observed that on the 1st test case (readdirp enabled), post readdirp
a getxattr is done. The number of getxattr depends on the number of acl
xattrs (I saw requests on these two: system.posix_acl_default,
system.posix_acl_access). Since need_lookup flag is set, during fuse_resolve
a nameless lookup is executed on the inode(getxattr being inode operation,
hence the nameless lookup). Since md-cache does not serve nameless lookup,
a network hop is needed for each file, costing the time.
With readdirp disabled, the getxattrs are served from md-cache itself(note:
we are discussing the 2nd attempt of ls -l use case).
_Current affairs around need of lookup for a file to populate it's ctx_:
For the xlators on client stack we discussed quite extensively about the need
for a lookup fop post readdirp in all three cluster translators - afr, EC and
dht. EC and dht don't really need a nameless lookup post readdirp. For afr too,
the need for lookup was negated with patch (http://review.gluster.org/6010 - AFRV2),
where afr added a function called afr_inode_refresh() which does a lookup and
populates its inode context in case a FOP came to AFR without a lookup being issued
prior to it.
We ran a thread on gluster-devel asking for feedback on the need of explicit lookup
post readdirp. For responses refer [1]. Refer [2] for discussions happened on gerrit.
After gathering inputs from [1] and [2], it looks like there is no xlator in
current state that requires an explicit lookup post readdirp to function properly.
* A separate similar patch will be sent for gfapi/nfs/nfs-ganesha.
Note: Only file's inode is built with readdirp.
[1] http://lists.gluster.org/pipermail/gluster-devel/2017-August/053505.html
[2] https://review.gluster.org/#/c/17985/
Change-Id: Ie1d68ce7bea5e1f8a1fab9a62217f478322554f5
BUG: 1492996
Signed-off-by: Susant Palai <spalai@redhat.com>
commit df3a46a00b6e01333c98907e78ec289452756e80
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Sep 19 09:39:31 2017 +0530
eventsapi: Fix issue with CLIENT_CONNECT event
A mismatch in event format causing below error in events.log when
it detects CLIENT_CONNECT event.
[2017-09-19 09:35:06,785] WARNING [glustereventsd - 46:handle] -
Unable to parse Event 1505793906 97
client_uid=f241-16363-2017/09/19-04:05:06:747558-gv1-client-
0-0-0;client_identifier=192.168.122.208:49150;server_identifier=
192.168.122.208:49152;brick_path=/bricks/b1,subdir_mount=(null)
BUG: 1492968
Change-Id: Ie6d507725a7e6b54fca44651f9c5e66eca2be244
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/18322
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 3a2a02c5bcfed0fc0e731de853f63498bba9fb9a
Author: hari gowtham <hgowtham@redhat.com>
Date: Mon Sep 18 11:48:43 2017 +0530
Tests: disabling the check for volume client-list
The client-list command is broken for brick-multiplexed.
Disabling it until the fix is in so that the regression test
can be resumed for the other test cases.
Change-Id: Idcb5a09db0eb46fbe71c215109b5c55924cc1209
BUG: 1492542
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/18308
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit e9ebe0954d4b26991bacb1155d446ca48c2c3039
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Sep 7 19:14:23 2017 +0530
glusterd: disallow replace brick for dist only volumes
Allowing replace-brick on dist only volumes will lead to data loss. This
patch blocks replace brick commit force to fail if a volume is dist
only.
Also removing tests/basic/pump.t as its of no use as per the discussion
in
http://lists.gluster.org/pipermail/gluster-devel/2017-September/053652.html
Change-Id: Iabb0c16f865f3fc361b64a19bfcf0c0fbb5c2682
BUG: 1489432
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/18226
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit fc69bb63fd2585f532406f96c310e10a7a540d64
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Sep 15 19:01:53 2017 +0530
events : Add brick list in EVENT_VOLUME_CREATE
Change-Id: Ibf87ae5ca57f9d27c036f329a30c8f81b51c52bf
BUG: 1492109
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/18306
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 67c9ff84414c296360cca9946b749b885f934167
Author: luneo7 <luneo7@gmail.com>
Date: Wed Aug 23 15:25:57 2017 -0300
features/worm: Adding check to newloc when doing rename
Problem: Since rename didn't check if newloc exists and it's
retention state it was possible to rename a new file that wasn't
in retention over a existing file that was in read-only state.
Change-Id: I63c6bbabb7bb456ebedf201cc77b878ffda62229
BUG: 1484490
Signed-off-by: luneo7 <luneo7@gmail.com>
Reviewed-on: https://review.gluster.org/18104
Tested-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Karthik U S <ksubrahm@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 6de0514c5c94c160d05ab26ae2ac4c46254b977d
Author: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Date: Wed Aug 10 13:44:19 2016 +0530
heal: New feature heal info summary to list the status of brick and count of entries to be healed
Command output:
Brick 192.168.2.8:/brick/1
Status: Connected
Total Number of entries: 363
Number of entries in heal pending: 362
Number of entries in split-brain: 0
Number of entries possibly healing: 1
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<healInfo>
<bricks>
<brick hostUuid="9105dd4b-eca8-4fdb-85b2-b81cdf77eda3">
<name>192.168.2.8:/brick/1</name>
<status>Connected</status>
<totalNumberOfEntries>363</numberOfEntries>
<numberOfEntriesInHealPending>362</numberOfEntriesInHealPending>
<numberOfEntriesInSplitBrain>0</numberOfEntriesInSplitBrain>
<numberOfEntriesPossiblyHealing>1</numberOfEntriesPossiblyHealing>
</brick>
</bricks>
</healInfo>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
</cliOutput>
Change-Id: I40cb6f77a14131c9e41b292f4901b41a228863d7
BUG: 1261463
Signed-off-by: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Reviewed-on: https://review.gluster.org/12154
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Karthik U S <ksubrahm@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 7aea7359887f67583e87bfeb1329020b849f5738
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 14 09:24:59 2017 -0400
rpc-transport/socket: tab -> spaces cleanup
tired of review comments about use of tabs when the whole file uses tabs
Change-Id: I4f822a53f47886da04282f9c3fb84d81a7b3f8d0
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/18286
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 59893f8735ddce0a4b030592f4b10c7d3e0ef964
Author: Michael Scherer <misc@redhat.com>
Date: Fri Sep 8 18:45:12 2017 +0200
Fix use-after-free in gf_rdma_do_reads
If iobref_new can't allocate a ref, we free the iobuf, and
then go to the cleanup part of the function, that will
run iobuf_unref a 2nd time, which trigger a warning with
coverity.
Change-Id: Ie9cf7a5d5f98244a390e44e1403c614199eb650c
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/18245
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f36ffb0a36578c1854246a6a8d2d68bd0cfd3e0f
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Wed Jul 19 18:40:38 2017 +0530
Heal root xattr correctly upon an add-brick operation
When an add-brick is performed the root path xattr is healed using a hook
script. For a volume in stopped state, the hook script is triggered in post
op of add-brick. Otherwise, if the volume is in started state the hook script
is started on a subsequent volume start. The script unlinks itself after
execution.
The issue is that current hook script does not work when you have multiple
volumes in stopped state. A hook script meant for volume1 can get trigerred
during start of volume2.
Fix: create separate hook script links for individual volumes.
Bug: 1472609
Change-Id: If5f056509505fdbbbf73d3363e9966047ae6a3d3
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
Reviewed-on: https://review.gluster.org/17824
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 9fd51313b1d4db78b52c303bf2fb6cc37ce46a8d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Sep 8 18:04:50 2017 +0530
features/shard: Change default shard-block-size to 64MB
Change-Id: I55fa87e07136cff10b0d725ee24dd3151016e64e
BUG: 1489823
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/18243
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Sunil Kumar Acharya <sheggodu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit c487d813fec7b08d27007ce4d8acddd47577b131
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Sep 12 14:53:41 2017 +0200
glusterd: fix invalid memory reference returned
Change-Id: I0823c7b33060b48040c1d86ad346a5f6e15bc190
BUG: 1490897
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/18263
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
commit d0c995bcb8ca138e1672da6621b6955a8b400f1b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 12 15:34:15 2017 -0400
rpc: TLSv1_2_method() is deprecated in OpenSSL-1.1
Fedora 26 has OpenSSL-1.1. Compile-time warnings indicate
that TLSv1_2_method() is now deprecated. As per the SSL man page:
TLS_method(), TLS_server_method(), TLS_client_method()
These are the general-purpose version-flexible SSL/TLS methods.
The actual protocol version used will be negotiated to the highest
version mutually supported by the client and the server. The
supported protocols are SSLv3, TLSv1, TLSv1.1 and TLSv1.2.
Applications should use these methods, and avoid the version-
specific methods described below.
...
TLSv1_2_method(), ...
...
Note that OpenSSL-1.1 is the version of OpenSSL; Fedora 25 and RHEL 7.3
and other distributions (still) have OpenSSL-1.0.
TLS versions are orthogonal to the OpenSSL version. TLS_method() is the
new — in OpenSSL-1.1 — version flexible function intended to replace the
TLSv1_2_method() function in OpenSSL-1.0 and the older (?), insecure
TLSv23_method(). (OpenSSL-1.0 does not have TLS_method())
Change-Id: I190363ccffe7c25606ea2cf30a6b9ff1ec186057
BUG: 1491025
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/18268
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 8a10adcac1d446118f49d45465787edfde755cb0
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Sep 13 14:04:52 2017 +0530
protocol/server: Remove duplicate dict_get_str
dict_get_str() for auth-path has been already done once within switch
case for RPCSVC_EVENT_DISCONNECT inside server_rpc_notify(). Therefore
this change removes the needless dict_get_str.
Change-Id: Ifeb3db828328df08a1f1612a8ad8e0babace1d16
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: https://review.gluster.org/18272
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 3c36e281e4e985e8bb38980e057dd446635cee94
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jun 21 12:56:14 2017 +0530
socket: Use granular mutex locks during pollin and pollout event processing
... instead of one global lock. This is because pollin and pollout
processing code operate on mutually exclusive members of
socket_private_t. Keeping this in mind, this patch introduces
the more granular priv->in_lock and priv->out_lock locks.
For pollerr, which modifies both priv->incoming and priv->ioq, both
locks need to be taken.
Change-Id: Id7aeb608dc7755551b6b404470d5d80709c81960
BUG: 1467614
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17687
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 5c08180162160018e09ba6c2a9e46f2f98bbee3f
Author: Michael Scherer <misc@redhat.com>
Date: Wed Sep 6 14:46:20 2017 +0200
Fix the type of len, a warning is triggered
clang show this warning on FreeBSD:
posix.c:133:17: warning: comparison of unsigned expression < 0
is always false [-Wtautological-compare]
A closer look on the code show that sys_readlink is returning a ssize_t,
not a size_t, who is unsigned.
Change-Id: Idb6a440ea44cc2168b0dd85f791c7955caa67c8c
BUG: 1488909
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/18220
Tested-by: Michael Scherer <misc@fedoraproject.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit ea11a9ae14d19de36a87388815eb0cdee068f667
Author: Michael Scherer <misc@redhat.com>
Date: Wed Sep 6 12:11:09 2017 +0200
Fix the conditional
Clang complain about it on FreeBSD
In file included from xlators/performance/nl-cache/src/nl-cache-helper.c:11:
In file included from xlators/performance/nl-cache/src/nl-cache.h:14:
xlators/performance/nl-cache/src/nl-cache-mem-types.h:12:9: warning: '__NL_CACHe_MEM_TYPES_H__' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]
#ifndef __NL_CACHe_MEM_TYPES_H__
Change-Id: I4327c7dacf10f2690bd33bf2b37dbb7d9b52bdd5
BUG: 1488840
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/18216
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 06873d66be7dd0586371bd4b97846bf984c2e373
Author: Michael Scherer <misc@redhat.com>
Date: Wed Sep 6 11:44:06 2017 +0200
Do not declare the variable timeout_ms if TCP_USER_TIMEOUT is not defined
Trying to fix the build on FreeBSD, -Wunused-variable trigger this warning.
Change-Id: I318121829ac6a609fe9c606aead257827c7748b1
BUG: 1488829
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/18215
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 772450da848c5501fa22b42a7e9ff6665b16eb49
Author: Michael Scherer <misc@redhat.com>
Date: Wed Sep 6 14:35:39 2017 +0200
Fix clang/gcc warning -Wformat-extra-args
umountd.c:59:61: warning: data argument not
used by format string [-Wformat-extra-args]
"Cannot access %s\n", path, strerror (errno));
Change-Id: If1622d5b806ce6795ad2f84f2f2874227811dd96
BUG: 1488906
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/18219
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit e4e272b3d3f6213d8448383918483b105c040103
Author: Michael Scherer <misc@redhat.com>
Date: Fri Sep 1 14:09:06 2017 +0100
Use the new URL for the docs
Change-Id: I0ef5c3980aed24a9fa2dda673f8293771ce81808
BUG: 1487644
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/18182
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Nigel Babu <nigelb@redhat.com>
Tested-by: Nigel Babu <nigelb@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 617fc988a8de86d630972d5db7b3398d51814296
Author: Csaba Henk <csaba@redhat.com>
Date: Tue May 23 08:27:06 2017 +0200
libglusterfs: fix run.c demo mode
run.c can be compiled into a standalone object file
or a demo program with the appropriate defines for
development purposes. This functionality was broken.
We fix it and also clean it up:
- call it "demo mode" not "test mode" as tests should
come with verification of the results of the invocation
which is not being done
- add comments to the source explaining the feature
- provide more comprehensive output in the demo program
This change does not affect standard compilation and
usage of run.c functionality.
BUG: 1454590
Change-Id: I1ea618e3262bf6a4d9f79f6b59209438d5163244
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: https://review.gluster.org/17363
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Amar Tumballi <amarts@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 9957aa67cd9c1cf02af458995f2ef4a888a104d4
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Sep 5 23:58:15 2017 -0400
mount/fuse: Include sub-directory in source argument for mount()
With this, mount of a sub-directory 'foo' gets listed in /proc/mounts as:
<hostname>:<volname>/foo on /mnt/glusterfs type fuse.glusterfs (rw,relatime...)
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
BUG: 1488913
Change-Id: Ib1e1ac3741bf66e1a912d792f2948b748931f2b0
Reviewed-on: https://review.gluster.org/18210
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit e68b684f17d2118e6159c11ad096def482ad40ca
Author: Michael Scherer <misc@redhat.com>
Date: Wed Sep 6 11:02:01 2017 +0200
Fix warning on FreeBSD, show by -Wformat-extra-args
The warning is specific to FreeBSD, since both Linux and NetBSD
do trigger a different codepath.
Change-Id: I3d2b374b6a39804942af076d7e0d130a76f869a2
BUG: 1488808
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/18214
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0fd6b233742f452f73bd8e280e103d051e5dd9d5
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Sep 5 15:18:58 2017 +0530
dht: add FOP check to dht_file_setattr_cbk
Problem:
bug-797171.7 loaded error-gen xlator on the brick which sent EBADF for a
non fd-based fop, namely setattr. This caused
dht_check_and_open_fd_on_subvol_task() to crash as local->fd was NULL.
Fix:
Call dht_check_and_open_fd_on_subvol_task() from dht_file_setattr_cbk
only for dht_fsetattr and not dht_setattr or dht_setattr2
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: Iab4999e213bf2065804f3f8237e470ad454e3c99
BUG: 1488399
Reviewed-on: https://review.gluster.org/18208
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1e6a9adb869c11fe666c54af05a7a6fc6500677b
Author: hari gowtham <hgowtham@redhat.com>
Date: Mon Aug 21 15:41:42 2017 +0530
Command to identify client process
command: gluster volume status <volname/all> client-list
output:
Client connections for volume v1
Name count
----- ------
fuse 2
tierd 1
total clients for volume v1 : 3
-----------------------------------------------------------------
Client connections for volume v2
Name count
----- ------
tierd 1
fuse.gsync 1
total clients for volume v2 : 2
-----------------------------------------------------------------
Updates: #178
Change-Id: I0ff2579d6adf57cc0d3bd0161a2ec6ac6c4747c0
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/18095
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bca2f6998719ea37c68c23e11dfdc4dd5fc53cdd
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Aug 29 15:07:53 2017 +0530
event/epoll: don't call handler for events received after a pollerr
we register socket with EPOLLONESHOT, which means it has to be
explicitly added back through epoll_ctl to receive more
events. Normally we do this once the handler completes processing of
current event. But event_select_on_epoll is one asynchronous codepath
where socket can be added back for polling while an event on the same
socket is being processed. event_select_on_epoll has a check whether
an event is being processed in the form of slot->in_handler. But this
check is not sufficient enough to prevent parallel events as
slot->in_handler is not atomically incremented with respect to
reception of the event. This means following imaginary sequence of
events can happen:
* epoll_wait returns with a POLLERR - say POLLERR1 - on a socket
(sock1) associated with slot s1. socket_event_handle_pollerr is yet
to be invoked.
* an event_select_on called from __socket_ioq_churn which was called
in request/reply/msg submission codepath (as opposed to
__socket_ioq_churn called as part of POLLOUT handling - we cannot
receive a POLLOUT due to EPOLLONESHOT) adds back sock1 for polling.
* since sock1 was added back for polling in step 2 and our polling is
level-triggered, another thread picks up another POLLERR event - say
POLLERR2. socket_event_handler is invoked as part of processing
POLLERR2 and it completes execution setting priv->sock to -1.
* event_unregister_epoll called as part of __socket_reset due to
POLLERR1 would receive fd as -1 resulting in assert failure.
Also, since the first pollerr event has done rpc_transport_unref,
subsequent parallel events (not just pollerr, but other events too)
could be acting on a freed up transport too.
Change-Id: I5db755068e7890ec755b59f7a35a57da110339eb
BUG: 1486134
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: https://review.gluster.org/18129
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
commit 4af3310cb66280ec97a7a9da3d751a38dee738f7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Sep 5 13:30:53 2017 +0530
features/shard: Increment counts in locks
Problem:
Because create_count/eexist_count are incremented without locks, all the shards may not
be created because call_count will be lesser than what it needs to be. This can lead
to crash in shard_common_inode_write_do() because inode on which we want to do
fd_anonymous() is NULL
Fix:
Increment the counts in frame->lock
Change-Id: Ibc87dcb1021e9f4ac2929f662da07aa7662ab0d6
BUG: 1488354
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/18203
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 602cb5118bb33b006ee595dacf4b3fc4f7079281
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Sep 5 21:42:26 2017 +0530
features/shard: Return aggregated size in stbuf of LINK fop
Change-Id: I42df7679d63fec9b4c03b8dbc66c5625f097fac0
BUG: 1488546
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/18209
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit ca67df8769045016b8135efdbc2928f0c8c6ebd6
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Aug 23 18:18:24 2017 +0200
arbiter: return ENOSYS for 'non readable' FOPs
AFR marks the arbiter as 'non readable'. This has been introduced with
commit 8ab87137 (afr: do not set arbiter as a readable subvol in inode
context). arbiter_readv() should not get called anymore, so it could be
removed. However, it is a good defensive approach to have all the inode
read FOPs that can not be handled by the arbiter to return ENOSYS.
Change-Id: I6ea41680832859bd6790dc8d7440ee98d38205fc
BUG: 1484722
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/18103
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit be7d2ba0e81dda18957724e49b654da661bd8fc6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Sat Sep 2 06:50:50 2017 -0400
scripts: mount.glusterfs contains non-portable bashisms
Debian's default shell is dash, i.e. /bin/sh -> dash, which doesn't
support bash extensions
Reported-by: "Michael Lundkvist" <brels.debian@solske.net>
Reported-by: pmatthaei@debian.org
Debian BZ: 873878
Change-Id: I33003183b9bc6459cae28c565125e6b2bd1eaa47
BUG: 1487830
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/18184
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 4c728856f6c71214e8e13e6f2aba84b41ef7e6cd
Author: Sunny Kumar <sunkumar@redhat.com>
Date: Fri Aug 18 14:56:46 2017 +0530
snapshot: clang compile warning
Warning type: NO_EFFECT
xlators/mgmt/glusterd/src/glusterd-snapshot.c:4004 : warning: comparison of
constant -1 with expression of type 'gf_boolean_t' (aka 'enum _gf_boolean')
is always false.
solution : "timestamp" was formerly declared as gf_boolean_t, now changed to
int.
Change-Id: Ie461537f06fe2971e2b09a428a22331808c41a13
BUG: 1335251
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
Reviewed-on: https://review.gluster.org/18062
Tested-by: Sunny Kumar
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 99b95ee3eaffc2dd11ba8ae69c6611d8a552bf9b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sat Sep 2 20:24:00 2017 +0530
afr: discover/lookup heal fixes
Addresses review comments in commit 468ca877807625817b72921d1e9585036687b640
Change-Id: I04b1bd3b00abfd6758798d6272954e36a24249a9
BUG: 1473636
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/18187
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 77607bafee41fb30324b6c82b0d3c6d266e6aa2a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Sat Sep 2 09:09:02 2017 -0400
glusterd: spelling errors reported by Debian maintainer
Reported-by: "Patrick Matthäi" <pmatthaei@debian.org>
Change-Id: I0dd6b7d88ddf3c98e8083b75f8dd848babcfd30a
BUG: 1487840
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/18185
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 1654b535f92f95cbf3968845b561897694432e34
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Aug 18 17:12:05 2017 +0200
mempool: fix code when GF_DISABLE_MEMPOOL is defined
Problem: Run-time crash is observed when attempting to memset() a zero
length buffer.
Solution: When GF_DISABLE_MEMPOOL is set, mem_get() gets translated to a
GF_MALLOC(). The size of the allocation does not need to relate to the
available (but uninitialized) global memory pools. It is fine to
allocate the exact amount of memory that was configured when the
mem-pool was created.
Change-Id: Iea0bff974bb771623a34d7a940e10cb0db0f90e1
BUG: 1481199
Reported-by: Milind Changire <mchangir@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/18034
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 747c6d0402d3562b6e18f2424757b61c64b0438d
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Wed Aug 30 17:54:09 2017 +0800
gfapi: adds a glfs_mem_header for exported memory
glfs_free releases different types of data depends on memory type.
Drop the depends of memory type of memory accounting,
new macro GLFS_CALLOC/GLFS_MALLOC/GLFS_REALLOC/GLFS_FREE are added
to support assign release function dynamically, it adds a separate
memory header named glfs_mem_header for gfapi.
Updates: #312
Change-Id: Ie608e5227cbaa05d3f4681a515e83a50d5b17c3f
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Reviewed-on: https://review.gluster.org/18092
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d4d0cae8b1baca1add222e45c82bf2cb9f139b98
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jun 20 15:24:33 2017 +0530
debug/delay-gen: Implement delay-generation feature
Background:
I was working on a customer issue where the disks were responding some times
after seconds. It was becoming very difficult to recreate the issues in our
labs, so had to come up with this feature.
Requirements:
We need an xlator which can delay x% of ops for y micro seconds.
We should be able to enable delays for specific fops.
This feature is modeled after error-gen. Most of the logic
is borrowed from that xlator. This is a minimum implementation
of the feature which satisfied the requirements I had. May be
in future with more requirements and understanding of the problem
further we can improve upon this implementation.
Here are the commands and what they do:
Enable delay-gen: (This is similar to how err-gen is enabled on the brick side)
- gluster volume set <volname> delay-gen posix
Set the percentage of fops that need to be delayed
- gluster volume set <volname> delay-gen.delay-percentage 50
Default is 10%
Set the delay in micro seconds
- gluster volume set <volname> delay-gen.delay-duration 500000
Default is 100000
Set comma separated fops to be delayed
- gluster v set r2 delay-gen.enable read,write
Default is all fops.
Fixes #257
Change-Id: Ib547bd39cc024c9cdb63754d21e3aa62fc9d6473
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17591
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit f5933544f0b331a49ecfb49b4662d21fe77e8e7b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Aug 18 18:05:54 2017 +0530
afr: check validity of afr_reply
...in various self-heal code paths.
Originally found by Pranith in __afr_selfheal_name_impunge ()
Also change __afr_selfheal_assign_gfid() to send lookup only on those
bricks that don't have a gfid matching that of the source.
Change-Id: I70a2ccd750a2af92c5fc36e0eefb2b6125404b4a
BUG: 1482923
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/18065
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1ad5ff0cb7377c6eb67b2f8637bd30e58ec5af97
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Aug 30 11:25:29 2017 +0530
rpc: destroy transport after client_t
Problem:
1. Ref counting increment on the client_t object is done in
rpcsvc_request_init() which is incorrect.
2. Ref not taken when delegating to grace_time_handler()
Solution:
1. Only fop requests which require processing down the graph via
stack 'frames' now ref count the request in get_frame_from_request()
2. Take ref on client_t object in server_rpc_notify() but avoid
dropping in RPCSVC_EVENT_TRANSPORT_DESRTROY. Drop the ref
unconditionally when exiting out of grace_time_handler().
Also, avoid dropping ref on client_t in
RPCSVC_EVENT_TRANSPORT_DESTROY when ref mangement as been
delegated to grace_time_handler()
Change-Id: Ic16246bebc7ea4490545b26564658f4b081675e4
BUG: 1481600
Reported-by: Raghavendra G <rgowdapp@redhat.com>
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/17982
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit d3a9a2c6aab47765e5e2fb24eb8a837bfa3e2406
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Aug 11 12:16:12 2017 +0530
cluster/dht: Log files skipped by rebalance
There was no easy way to find out which files were
skipped during a rebalance.
Rebalance now logs a message for every skipped file
using msgid 109126, making it easier to find
all files that were skipped.
Change-Id: I2cac7db7285e2f82354251f3ea4094827b0daf3e
BUG: 1480445
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/18021
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: hari gowtham <hari.gowtham005@gmail.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit e2c8d07ac9ddae1b03491c0e5d0f449a46b85e7b
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Aug 29 21:12:51 2017 +0530
cluster/dht: Aggregate xattrs only for dirs in dht_discover_cbk
If dht_discover finds data files on more than one subvol,
racing calls to dht_discover_cbk could end up calling
dht_aggregate_xattr which could delete dictionary data
that is being accessed by higher layer translators.
Fixed to call dht_aggregate_xattr only for directories and
consider only the first file to be found.
Change-Id: I4f3d2a405ec735d4f1bb33a04b7255eb2d179f8a
BUG: 1484709
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/18137
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ea4caf94cce3bb82c3d5bcddf23e7595d7d9f270
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Aug 29 00:17:03 2017 +0200
mem-pool: count allocations done per user-pool
Count the active allocations per 'struct mem_pool'. These are the
objects that the calling component allocated and free'd in the memory
pool for this specific type. Having this count in the statedump will
make it easy to find memory leaks.
Updates: #307
Change-Id: I797fabab86f104e49338c00e449a7d0b0d270004
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/18074
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 1161e1dd70038233affa61d2aeddc2ddc81443f0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Aug 28 19:33:30 2017 +0530
gluster-block: strict-o-direct should be on
tcmu-runner is not going to open block with O_SYNC anymore
so writes have a chance of getting cached in write-behind
when that happens, there is a chance that on failover some
data could be stuck in cache and be lost.
BUG: 1485962
Change-Id: If9835d914821dfc4ff432dc96775677a55d2918f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/18120
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit e0ea44f0a04b101e59952a6acb2ef00806c1ced7
Author: Iblis Lin <iblis@hs.ntnu.edu.tw>
Date: Mon Jul 31 11:25:07 2017 +0800
posix: fix incorrect xattr list handling on FreeBSD
Change-Id: I5be157259f0b665640aaa1eda68063bb19fd7b3d
BUG: 1484246
Signed-off-by: Pellaeon Lin <nfsmwlin@gmail.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: https://review.gluster.org/17917
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit fd3bf916177fdf3d31db5e5db3d0a18e4f51c527
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Aug 1 07:51:44 2017 -0400
feature/posix: Enabled gfid2path by default
Enable gfid2path feature by default. The basic
performance tests are carried out and it doesn't
show significant depreciation. The results are
updated in issue.
Updates: #139
Change-Id: I5f1949a608d0827018ef9d548d5d69f3bb7744fd
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17950
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 19feaee152a408d5ed72a07e364cef403e934e51
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Aug 29 00:16:22 2017 +0200
mem-pool: track glusterfs_ctx_t in struct mem_pool
In order to generate statedumps per glusterfs_ctx_t, it is needed to
place all the memory pools in a structure that the context can reach.
The 'struct mem_pool' has been extended with a 'list_head owner' that is
linked with the glusterfs_ctx_t->mempool_list.
All callers of mem_pool_new() have been updated to pass the current
glusterfs_ctx_t along. This context is needed to add the new memory pool
to the list and for grabbing the ctx->lock while updating the
glusterfs_ctx_t->mempool_list.
Updates: #307
Change-Id: Ia9384424d8d1630ef3efc9d5d523bf739c356c6e
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/18075
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit cb2972ae5a6e985704aecb330da61b05e3d6a9c4
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Aug 16 20:17:19 2017 +0530
libglusterfs: Add new fields to volume_options struct
The new fields are required to enable equivalent volume set and volgen
features, and some more additional features in GD2. GD2 does not use a
hard-coded volume options map like GD1, but builds such by reading the
options tables directly from the xlators.
The new fields being introduced into the volume options struct include
the following,
- op-version - version(s) the option was introduced in
- deprecated - version(s) the option was deprecated in
- flags - flags for the option (settable, client, global, force, doc etc.)
- tags - descriptive tags that apply to this option, can be used to
group options
- validate_fn - custom option validation function
Enums for currently available flags have also been defined. To avoid a
naming clashes, the flag enums in GD1 have been renamed.
Updates #302
Change-Id: Ic7e08aef9e051beb47e8dc17d7f7be211aed308a
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: https://review.gluster.org/18059
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 8945fb9f9783910d2203b92f3e04eba5725161e6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Aug 23 11:37:40 2017 -0400
packaging: /run and /var/run; prefer /run
Fedora packaging guidelines say to use /run. On newer Fedora and
el7 /var/run is a symlink to ../run (i.e. /run). /run is a tmpfs
file system that is mounted earlier than /var might be.
See https://bugzilla.redhat.com/show_bug.cgi?id=1476794
Change-Id: I9631d5aa854d7bc4f4dc0c9cac1a3cb19ea516f2
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/18102
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
commit 7d4d4aba8caba9e2ac34a6ca62b97331ac9dd0e6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Aug 18 11:24:44 2017 -0400
cluster/ec: coverity, fix for BAD_SHIFT
This is how I would like to see this fixed.
passes (eliminates the warning in) coverity.
The use of uintptr_t as a bitmask is a problem IMO, especially on
32-bit clients.
Change-Id: I86e15d12939c610c99f5f96c551bb870df20f4b4
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/18067
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 0455d984dafdae286c05231a22d10f429bb08c0c
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Aug 4 16:29:51 2017 +0200
mem-pool: add tracking of mem_pool that requested the allocation
This renames the current 'struct mem_pool' to 'struct mem_pool_shared'.
The mem_pool_shared is globally allocated and not specific for
particular objects.
A new 'struct mem_pool' gets allocated when mem_pool_new() is called. It
points to the mem_pool_shared that handles the actual allocation
requests. The 'struct mem_pool' is only used for accounting of the
objects that the caller requested and free'd.
All of these changes will be used to collect all the memory pools a
glusterfs_ctx_t is consuming, so that statedumps can be collected per
context.
Updates: #307
Change-Id: I6355d3f0251c928e0bbfc71be3431307c6f3a3da
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/18073
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 67b1421dbe581f4bbec1610a82f84430a2e0f869
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Aug 6 17:21:51 2017 +0200
statedump: add support for dumping basic mem-pool info
With all the new 'struct mem_pool' infrastructure in place, it is now
possible to fetch details about the memory pools that a glusterfs_ctx_t
uses.
This only captures the information from 'struct mem_pool', and not from
the global 'struct mem_pool_shared' or the pool_sweeper thread. The
current details help with detecting memory leaks.
Updates: #307
Change-Id: Idbc5ba136df50863e1e380b448061509896f2c23
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/18076
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit dc3fe006c57e0f332b07cf8207ccdbcbda0e1ac9
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Aug 24 13:39:07 2017 +0530
perf/qr: Use a ref-ed data to extract content
qr_content_extract used dict_get to get the value of
the GF_CONTENT_KEY key. dict_get does not ref the data
before returning it so QR could be acting on freed memory
if another thread deletes the key before then.
This patch also fixes a race in dict_get_with_ref.
Fix: Use dict_get_with_ref to retrieve the file contents.
Change-Id: Ib1a7a70bb92eed7e70747ec530e0b3edc53127ec
BUG: 1484709
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/18115
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit acbcf44e711656448022d51018434bf41a8d9f70
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Aug 24 12:35:03 2017 +0530
Revert "rpc: disable client on disconnection from rebalance"
This reverts commit 5b14c11d3cae38bc66006b02217ede485ae30dea.
BUG: 1484225
Change-Id: I3269d3fc64de3f3cc6f670ea564a87d7725e10fd
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/18113
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit e3edd687828b41a18e78011f9b4abeacd1ce9a37
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Aug 24 12:39:47 2017 +0530
glusterd: disable rpc_clnt_t after relalance process disconnection
Problem:
glusterd continues to connect to rebalance process even after
the socket connection has disconnected.
Solution:
rpc_clnt_disable() disables the rpc_clnt_t object and disarms
all relevant timers and drops refs to the rpc_clnt_t object
and the transport as well.
Change-Id: I981d6f1cc0087037f1927062c2770a4d5026a619
BUG: 1484225
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/18114
Reviewed-by: MOHIT AGRAWAL <moagrawa@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit cc454a96e4be4d36e08abc12f65aeda1a275221e
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Fri Aug 18 19:46:47 2017 +0530
glusterd: glusterd fails to start if peers file has blank line
Problem:
On start of glusterd service, glusterd fetch data from store, while
parsing data from store if peers file consists of blank line glusterd
fails to start.
Fix:
With this fix while parsing peers file glusterd will skip blank lines
if it contains any.
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Change-Id: I53cd65a54de5f57baef292b2118b70ffb7f99388
BUG: 1482906
Reviewed-on: https://review.gluster.org/18066
Tested-by: Gaurav Yadav <gyadav@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 8d6eef998c54067ee4c14201abcb035683f7d03b
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Aug 8 10:12:14 2017 -0400
geo-rep: Fix syncing of hardlink of symlink
Problem:
If there is a hardlink to a symlink on master
and if the symlink file is deleted on master,
geo-rep fails to sync the hardlink.
Typical Usecase:
It's easily hit with rsnapshot use case where
it uses hardlinks.
Example Reproducer:
Setup geo-replication between master and slave
volume and in master mount point, do the following.
1. mkdir /tmp/symlinkbug
2. ln -f -s /does/not/exist /tmp/symlinkbug/a_symlink
3. rsync -a /tmp/symlinkbug ./
4. cp -al symlinkbug symlinkbug.0
5. ln -f -s /does/not/exist2 /tmp/symlinkbug/a_symlink
6. rsync -a /tmp/symlinkbug ./
7. cp -al symlinkbug symlinkbug.1
Cause:
If the source was not present while syncing hardlink,
it was always packing the blob as regular file.
Fix:
If the source was not present while syncing hardlink,
pack the blob based on the mode.
Change-Id: Iaa12d6f99de47b18e0650e7c4eb455f23f8390f2
BUG: 1432046
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reported-by: Christian Lohmaier <lohmaier+rhbz@gmail.com>
Reviewed-on: https://review.gluster.org/18011
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 0820f9ad597cb868f20077d8a7e399e40637fdb9
Author: Prashanth Pai <ppai@redhat.com>
Date: Wed Aug 9 16:34:39 2017 +0530
glusterd: do not create .glusterfs/indices
glusterd shouldn't concern itself with creating directories specific to
certain xlators.
The index xlator will now proceed creating './glusterfs/indices' dir
only if the parent '.glusterfs' directory exists, which still fixes the
original problem reported i.e 'volume start force' command shouldn't
create brick path if it doesn't exist (BUG 1457202)
This reverts most of the changes done by the commit
b58a15948fb3fc37b6c0b70171482f50ed957f42
Change-Id: I7fc52ad64dce220e336c218fb4d85933ca2e61c0
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: https://review.gluster.org/18003
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit be77b87c8916793ff9270d00d110cfa8eb904146
Author: Nigel Babu <nigelb@redhat.com>
Date: Thu Aug 17 17:04:35 2017 +0530
Add Deepshika as Continuous Integration peer
Change-Id: I49df7cd49dc2e73ab3f9c797cf8d5bf39372902a
BUG: 1484215
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: https://review.gluster.org/18091
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Michael Scherer <misc@fedoraproject.org>
commit 0421cc263aef7cf90067a9e81b835f826dfac7f8
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Aug 23 10:10:13 2017 +0530
rpc: disable client on disconnection from rebalance
Problem:
glusterd rpc code path attempts to reconnect to rebalance process
via the reconnect timer even after the rebalance process disconnection
Solution:
Set the clnt->disabled flag to 1 to avoid reconnection and cause
the clnt object to be unref'd
Change-Id: I4e38eaef45d2fdea86d25e9dff9f1af0cd29cf66
BUG: 1484225
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/18093
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 7f358de2f3c685373eeec6e998c135c87f6dd0c4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Aug 22 10:21:48 2017 -0400
packaging: use rdma-core(-devel) instead of ibverbs, rdmacm
Also disable rdma on armv7hl.
Starting in Fedora 26 the rdma-core package replaces various
(lib)ibverbs and (lib)rdmacm packages.
Also apparently rdma never actually worked (even if ibverbs and
rdmacm packages were built) for armv7hl. The new rdma-core excludes
armv7hl.
See https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/WJHXQ3G6H7UMVERDCMUXBYDJTFABTGW3/
and https://bugzilla.redhat.com/show_bug.cgi?id=1483278
Even though rdma-core dates back to Fedora 26 this only makes the
switch to rdma-core effective with Fedora 27 and later; rdma-core has
Provides: (and Obsoletes:) for all the ibverbs and rdmacm packages
which is why we haven't noticed this before now.
Change-Id: I3cd4f2becb465569b2c8e5514d28c9adff534d26
BUG: 1483995
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/18088
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 9756347b74f5b9869fd3fc3d434c68ea8ac32eca
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Fri Aug 18 23:06:13 2017 +0530
glusterd: replace-brick executing successfully when quorum does not met
Problem:
replace-brick command on a setup where quorum does not met executing
successfully.
Fix:
With the fix glusterd is validating whether server is in quorum or not
during replace-brick staging
Change-Id: I8017154bb62bdcc6c6490e720ecfe9cde090c161
BUG: 1483058
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-on: https://review.gluster.org/18068
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit d77859179267f9930c1d1ebb0be2e468abcc26c3
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Aug 16 12:58:52 2017 +0530
cluster/dht: Reorder dir operations in gf_defrag_fix_layout
Earlier, rebalance performed a fix-layout on a directory
before healing its subdirectories. If there were a lot of
subdirs, it could take a while before all subdirs were
created on the newly added bricks. As dht_readdirp only lists
dirs from their hashed subvol, those dirs which hashed to
the newly added bricks but were not yet created on them were
not listed.
Now, the child dirs are listed and processed before the layout
of the parent is fixed. This introduces a change in behaviour
where files in subdirs are migrated before those in parent
directories.
Credit: Shyam <srangana@redhat.com>
Github issue: #239
Change-Id: I8ae7f24a510754cd8d1b31e5d608bcf1928599e2
BUG: 1248393
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/18045
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit a7c4ea21bdb542c91741eb4822c4b53c2412287a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Aug 17 10:54:02 2017 +0530
glusterd: disallow volume specific options to be set with all as volume name
All the .validate_fn defined in volume map entry table refers to volinfo
object. And if we end up in trying to set a volume level option cluster
wide glusterd results into a crash.
Change-Id: I7c877aee0ff5c8c1d8c95662fdc8c8923355ae7b
BUG: 1482344
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/18052
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1d61cb43ebd93a7ff97934fcf0ae57201e636040
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Aug 10 18:31:55 2017 +0530
glusterd: introduce max-port range
glusterd.vol file always had an option (commented out) to indicate the
base-port to start the portmapper allocation. This patch brings in the
max-port configuration where one can limit the range of ports which
gluster can be allowed to bind.
Fixes: #305
Change-Id: Id7a864f818227b9530a07e13d605138edacd9aa9
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/18016
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
commit 62e9884a051a4174d52275f7f17d8ed976217769
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Aug 11 10:20:14 2017 +0530
glusterd: improve op-version error message
In case of a heterogeneous cluster if an admin sets a volume option
which is higher than the current op-version the current error message
only displays the version number of the new tunable. Better use
experience is to dump the supported op-version in the error message as
well.
Change-Id: Ib42dadc574a401f79364178cb41ad21fb0b4432b
BUG: 1328994
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/18020
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Joe Julian <me@joejulian.name>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 0e2b8e9b64bbbea6fab22f2dbbf4f2b633cfaeac
Author: Ryan Ding <ryan.ding@open-fs.com>
Date: Wed Nov 16 10:52:34 2016 +0800
glusterd: Fix the debug and error-gen turned on issue
Problem:
When enabling one of the debug or the error-gen xlator, both of
them will be turned on together.
The problem is that when adding debug xlators into the graph, its
on/off status is ignored to be checked.
Fix:
When adding a debug xlator, check its status and skip those with
a value of "off".
Change-Id: Ifa79314ff337b60ee941cfb0308c1ccbe42d027f
BUG: 1395492
Signed-off-by: Zhang Huan <zhanghuan@open-fs.com>
Reviewed-on: https://review.gluster.org/15849
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 411a0905d3df53ee17cb15b87dbde2aac184315f
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Jul 25 18:07:05 2017 +0530
Infra to indentify process
Problem: currently we can't identify which process is running and
how many instances of it are available.
Fix: name the process when its spawned and send it to the server
and save it in the client_t
The processes that abide by this change from this patch are:
1) fuse mount,
2) rebalance,
3) selfheal,
4) tier,
5) quota,
6) snapshot,
7) brick.
8) gfapi (by default. gfapi.<processname> if processname is found)
Note: fuse gets a process name as native-fuse-client by default.
If the user gives a name for the fuse and spawns it, it will be of
this type --process-name native-fuse-client.<name_specified>.
This can be made use by the process like aux mount done by quota,
geo-rep, etc by adding another option in the aux mount " -o
process-name=gsync_mount"
Updates: #178
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Change-Id: Ie4d02257216839338043737691753bab9a974d5e
Reviewed-on: https://review.gluster.org/17957
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit b2895b9b9917339c4ff020de147827f2129b67fd
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jul 21 15:21:20 2017 +0530
afr: heal metadata in discover code path
During graph switch, if fuse sends nameless (gfid) lookups, afr takes
the discover code path to serve it. If there are pending metadata heals,
they do not happen unless an inode refresh happens as a part of
discover (which is not guaranteed to happen always).
This patch fixes it by attempting metadata heal as a part of discover,
just like how it is done in lookup code path.
Also removed creating superfluous heal frames when launching heal.
Change-Id: I49868649361ebe5d70b6ea150f4686169b6c3070
BUG: 1473636
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17850
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Karthik U S <ksubrahm@redhat.com>
commit 39daaa0daba6fea5e15f5f0471ef6625165f94d0
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Aug 11 17:50:52 2017 +0530
uss/svc: Send the first lookup to the normal graph
When parent inode is not looked up before, the inode type
won't be set. In this scenario we should send the lookup
to the normal graph first.
Change-Id: I5d3e53f5c1c33a17be32204f3114749d9b1e6db8
BUG: 1480591
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/18028
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
commit 5d7402b747ea10ab50f0e0bfb4684d1f740d79af
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Aug 10 13:13:39 2017 -0400
packaging: /run and /var/run; prefer /run
Fedora packaging guidelines say to use /run. On newer Fedora and
el7 /var/run is a symlink to ../run (i.e. /run). /run is a tmpfs
file system that is mounted earlier than /var might be.
See https://bugzilla.redhat.com/show_bug.cgi?id=1476794
Change-Id: I08d948a43c7698bebd26c88a673a7f77c2d317ca
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/18017
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 9c2aca93c14f3bf9b64d3a4566b7845a8802f93e
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Wed Mar 2 17:42:07 2016 +0530
glusterd: Gluster should keep PID file in correct location
Currently Gluster keeps process pid information of all the daemons
and brick processes in Gluster configuration file directory
(ie., /var/lib/glusterd/*).
These pid files should be seperate from configuration files.
Deletion of the configuration file directory might result into serious problems.
Also, /var/run/gluster is the default placeholder directory for pid files.
So, with this fix Gluster will keep all process pid information of all
processes in /var/run/gluster/* directory.
Change-Id: Idb09e3fccb6a7355fbac1df31082637c8d7ab5b4
BUG: 1258561
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: https://review.gluster.org/13580
Tested-by: MOHIT AGRAWAL <moagrawa@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bdb12d5fd53c912f67b0188e0ea965bb7dbfbe8a
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Aug 10 12:56:32 2017 +0530
mgmt/glusterd: Provide more information in command message
Problem:
When more than one bricks are present on the same node,
while creating a volume, we get a warning message that
the setup is not optimal. We need to add more information
in this error/warning.
Solution:
Add following line in current message.
Bricks should be on different nodes to have best fault
tolerant configuration.
Change-Id: Ica72bd6e68dff7e41c37617f3b775a981fa40c69
BUG: 1480099
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://review.gluster.org/18014
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit dec0dfee1708c220310a9bba4565a4c70c7bd480
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Jul 27 14:20:31 2017 +0530
protocol/server: Fix Wint-in-bool-context compiler warning
Following warning is shown when compiled with gcc v7:
server-helpers.c: In function ‘auth_set_username_passwd’:
server-helpers.c:1282:65: warning: ?: using integer constants in boolean context [-Wint-in-bool-context]
ret = !((strcmp (data_to_str (passwd_data),
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
password))?0: -1);
~~~~~~~~~~~~^~~~~
CCLD server.la
Previously we used to have integers being used in context where boolean
values were intended with ternay oprations and it was hard to understand
the logic. This change simplifies the logic so that it avoids the warning
too.
Change-Id: Ie533cf34f829b9fcfeb79f3d519a0ac3cb7f2ab8
Updates: #259
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: https://review.gluster.org/17895
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit c2f969cf48d46fa95948b94d733a2233a3cc1c45
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Jul 27 14:15:22 2017 +0530
contrib/fuse-lib: Fix compiler warning within switch case
Following warning is shown when compiled with gcc v7:
mount.c: In function ‘gf_fuse_unmount_daemon’:
mount.c:98:22: warning: statement will never be executed [-Wswitch-unreachable]
char c = 0;
^
CCLD fuse.la
We just need to move the relevant declaration statements to that switch
case where it is valid and is being used.
Change-Id: I8e50cc7cfcfc3bc88218cd69abbf516c08ee1648
Updates: #259
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: https://review.gluster.org/17878
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 69b5e909752e551f342efa9d5cc0d69ed6c62601
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Aug 8 22:33:24 2017 +0530
cluster/dht: EBADF handling for fremovexattr and fsetxattr
Add EBADF handling for dht_fremovexattr and dht_fsetxattr.
Change-Id: Ide0d5812dae79655d2565157e5baabcd753b4309
BUG: 1476665
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17999
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit fbd0646067fd177bdc95f479faa3528decdc7f61
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue Aug 8 14:36:17 2017 +0530
glusterd: Block brick attach request till the brick's ctx is set
Problem: In multiplexing setup in a container environment we hit a race
where before the first brick finishes its handshake with glusterd, the
subsequent attach requests went through and they actually failed and
glusterd has no mechanism to realize it. This resulted into all the such
bricks not to be active resulting into clients not able to connect.
Solution: Introduce a new flag port_registered in glusterd_brickinfo
to make sure about pmap_signin finish before the subsequent
attach bricks can be processed.
Test: To reproduce the issue followed below steps
1) Create 100 volumes on 3 nodes(1x3) in CNS environment
2) Enable brick multiplexing
3) Reboot one container
4) Run below command
for v in ‛gluster v list‛
do
glfsheal $v | grep -i "transport"
done
After apply the patch command should not fail.
Note: A big thanks to Atin for suggest the fix.
BUG: 1478710
Change-Id: I8e1bd6132122b3a5b0dd49606cea564122f2609b
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/17984
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 251eaf1b21f77cd15a84ee36dfc19fb471739efd
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Aug 7 12:14:23 2017 +0530
posix: add null gfid checks
...in file/dir creation and lookup codepaths. The check is relaxed for
fops coming from trash xlator at the moment until trash has client side
logic to send the create fops with gfid-req.
Also fixed the missing trash pid assignment in creates sent by trash
xlator. Without this, truncated files won't be moved to .trashcan.
Change-Id: Ieddd7f0634850e7c7010e4fbb4ad1eead35888c8
BUG: 1478297
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17975
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit e09cbb13d89a3eca9562b857e28ba786f0b6c716
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Aug 4 14:46:38 2017 +0530
cluster/dht: Check for open fd only on EBADF
DHT fd based fops used to check if the fd was open
on the cached subvol before winding the call. However,
this introduced a performance regression of about
30% for reads.
This check was introduced to handle cases where files
were migrated while IOs were happening. As this is not
the common case, dht will now check if the fd is
open on the cached subvol only if the call fails
with EBADF.
This will prevent a performance hit where a rebalance
is not running.
Change-Id: I2035a858d63c3fcd22bb634055bbb0ad01686808
BUG: 1476665
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17976
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit cbfa463f41ef71a58bbe7c26923724ca0c514254
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Aug 7 23:47:00 2017 +0530
nfs : add NULL check for call state in nfs3_call_state_wipe
Refcounting added for nfs call state in https://review.gluster.org/17696.
This is based on assumption that call state won't NULL when it is freed.
But currently gluster nfs server is crashing in different scenarios at
nfs3_getattr() with following bt
#0 0x00007ff1cfea9205 in _gf_ref_put (ref=ref@entry=0x0) at refcount.c:36
#1 0x00007ff1c1997455 in nfs3_call_state_wipe (cs=cs@entry=0x0) at nfs3.c:559
#2 0x00007ff1c1998931 in nfs3_getattr (req=req@entry=0x7ff1bc0b26d0, fh=fh@entry=0x7ff1c2f76ae0) at nfs3.c:962
#3 0x00007ff1c1998c8a in nfs3svc_getattr (req=0x7ff1bc0b26d0) at nfs3.c:987
#4 0x00007ff1cfbfd8c5 in rpcsvc_handle_rpc_call (svc=0x7ff1bc03e500, trans=trans@entry=0x7ff1bc0c8020, msg=<optimized out>) at rpcsvc.c:695
#5 0x00007ff1cfbfdaab in rpcsvc_notify (trans=0x7ff1bc0c8020, mydata=<optimized out>, event=<optimized out>, data=<optimized out>) at rpcsvc.c:789
#6 0x00007ff1cfbff9e3 in rpc_transport_notify (this=this@entry=0x7ff1bc0c8020, event=event@entry=RPC_TRANSPORT_MSG_RECEIVED, data=data@entry=0x7ff1bc0038d0)
at rpc-transport.c:538
#7 0x00007ff1c4a2e3d6 in socket_event_poll_in (this=this@entry=0x7ff1bc0c8020, notify_handled=<optimized out>) at socket.c:2306
#8 0x00007ff1c4a3097c in socket_event_handler (fd=21, idx=9, gen=19, data=0x7ff1bc0c8020, poll_in=1, poll_out=0, poll_err=0) at socket.c:2458
#9 0x00007ff1cfe950f6 in event_dispatch_epoll_handler (event=0x7ff1c2f76e80, event_pool=0x5618154d5ee0) at event-epoll.c:572
#10 event_dispatch_epoll_worker (data=0x56181551cbd0) at event-epoll.c:648
#11 0x00007ff1cec99e25 in start_thread () from /lib64/libpthread.so.0
#12 0x00007ff1ce56634d in clone () from /lib64/libc.so.6
This patch add previous NULL check move from __nfs3_call_state_wipe() to nfs3_call_state_wipe()
Change-Id: I2d73632f4be23f14d8467be3d908b09b3a2d87ea
BUG: 1479030
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: https://review.gluster.org/17989
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 60cc9cccb0fdc9181dab5bb2130dad9df48f99f9
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Aug 4 16:23:46 2017 +0530
afr: Prevent null gfids in self-heal entry re-creation
Change-Id: I5acb8bd0a19fc4e764d61e349bb690b5236ee610
BUG: 1478297
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17981
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Karthik U S <ksubrahm@redhat.com>
commit adb450ac650dcfef94f8d9d106e98ea61fb4013f
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Aug 3 17:43:22 2017 +0530
gfapi: Duplicate the buffer sent in setxattr calls
Issue:
The caller of glfs_setxattr sends a buffer to set as the value.
We create a dict in which the pointer to the value is set.
Underlying layers like md-cache take a ref on this dict to store
the value for a longer time. But the moment setxattr is complete,
the caller of glfs_setxattr can free the value memory.
Solution:
memcpy the setxattr value to the gluster buffer.
Change-Id: I58753fe702e8b7d0f6c4f058714c65d0ad5d7a0a
BUG: 1477488
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17967
Reviewed-by: soumya k <skoduri@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 2aa5d550e4940c127f7064dd625059dcfb744a9f
Author: SonaArora <aarorasona@gmail.com>
Date: Wed Jul 26 17:43:45 2017 +0530
read-only : currently read-only doesn't implement fallocate
PROBLEM STATEMENT: read-only should block fallocate call if its enabled,
else pass to next xlator. Implemented this functionality in read-only.
BUG: 1475300
Change-Id: I57c51eb4f1519ba75d7291eba49554e6ed4a25eb
Signed-off-by: SonaArora <aarorasona@gmail.com>
Reviewed-on: https://review.gluster.org/17879
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Karthik U S <ksubrahm@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Karthik U S <ksubrahm@redhat.com>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit c3954804c789b8ae59425d9dee240e2163b02f1a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Jul 31 23:38:20 2017 +0530
posix: add sanity checks for removing the gfid symlink for directories
...during mkdir and rmdir. Otherwise, during entry self-heal, the
directory could be left out without a .glusterfs symlink causing fops like
opendir, readdir to fail. The only chance the missing symlink will be
created is when a fresh lookup comes on it.
Change-Id: I2e1cf1bce8962ea80187edd8f6d73e0a09cf9f8e
BUG: 1477169
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17945
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 4b4d96d42629696d3459e54dab0688f63d0a5515
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Aug 4 08:52:31 2017 +0530
Revert "cluster/dht: Check for open fd only on EBADF"
This reverts commit 91c9f4a19fde4894576b398252c77f730832a26a.
This patch needs to be reworked.
Change-Id: I4c24f647c2b1abc68fc4e9fe6eb810418e2033aa
BUG: 1476665
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17970
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit bcb5f27b0f1fba66e7ac26a376187a1d2dee0c8e
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Mon Jul 31 10:51:21 2017 +0530
glusterd: Add geo-replication session details to get-state output
This commit adds support to the get-state CLI to capture details
on geo-replication session as obtained in
`gluster volume geo-replication status detail` in its output.
Fixes: #291
Change-Id: I2fbcba70bfdaf439522637234805545194777ed4
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17941
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shubhendu Tripathi <shtripat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 60f6a99b390d20a71a9d17ed9fff4a603ba12281
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Jul 19 23:08:05 2017 +0530
glusterfsd: allow subdir mount
Changes:
1. Take subdir mount option in client (mount.gluster / glusterfsd)
2. Pass the subdir mount to server-handshake (from client-handshake)
3. Handle subdir-mount dir's lookup in server-first-lookup and handle
all fops resolution accordingly with proper gfid of subdir
4. Change the auth/addr module to handle the multiple subdir entries
in option, and valid parsing.
How to use the feature:
`# mount -t glusterfs $hostname:/$volname/$subdir /$mount_point`
Or
`# mount -t glusterfs $hostname:/$volname -osubdir_mount=$subdir /$mount_point`
Option can be set like:
`# gluster volume set <volname> auth.allow "/subdir1(192.168.1.*),/(192.168.10.*),/subdir2(192.168.8.*)"`
Updates #175
Change-Id: I7ea57f76ddbe6c3862cfe02e13f89e8a39719e11
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17141
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit fb5cb6905276a888bccbb3f21fecd9c15a4896de
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Aug 1 08:04:48 2017 -0400
logging: localtime logging, cmdline, volume set option
Despite the fact that appliances generally use UTC, some
users really want log entries in localtime.
fixes gluster/glusterfs#272
feature page: https://review.gluster.org/17807
Change-Id: I5fbf2c3eedd9eb128fb3f851dd67b2f4081c8bba
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16911
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit e5fbcddae3ba33949826fe2c5a68382503e1fc66
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Aug 1 01:38:00 2017 +0200
tests: don't use hard coded value for glusterd workdir
A number of test referred to /var/lib/glusterd,
they were adjusted to use "$GLUSTERD_WORKDIR".
(This has significance for proper test runs on non-Linux
platforms -- see the following #define in glusterfs.h:
#ifdef GF_LINUX_HOST_OS
#define GLUSTERD_DEFAULT_WORKDIR DATADIR "/lib/glusterd"
#else
#define GLUSTERD_DEFAULT_WORKDIR DATADIR "/db/glusterd"
#endif
Ie. the glusterd workdir will typically be /var/db/glusterd
instead of /var/lib/glusterd on non-Linux platforms.)
BUG: 1476957
Change-Id: I69ce3e1bb7a0c14ea85b60adbf8205f9aca46cd5
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: https://review.gluster.org/17937
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 05759d3d974f69416c2f572b3a4c6b4a7b4bbd48
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jul 31 12:22:46 2017 -0400
packaging: /var/lib/glusterd/options should be %config(noreplace)
/var/lib/glusterd/options is where cluster.enabled-shared-storage is
persisted. If the file is removed as part of an uninstall/reinstall
or update then the state of shared storage could be lost.
Change-Id: Ie18c3d883df71c1857fd6996d9c03ab247580b70
BUG: 1476861
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17930
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 9b7bae21f1dc738c512debd694fee7a9faa82b27
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Mon Dec 19 11:23:38 2016 +0530
tests: Minor fix in error condition
Change-Id: I2dcc8d88234d2ce92dd8506c61cb84ab253decab
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: https://review.gluster.org/16191
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
commit bcaac5f3193396545952ac0a80d379631238c20b
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Fri Jul 21 12:14:25 2017 +0530
tests/gfapi : add test case for nameless lookups in glfs_resolve_component()
Plus address pending comment to add check for entry "" in glfs_resolve_component()
Change-Id: I6063f776ce1cd76cb4c1b1f621b064f3dcc91e5c
BUG: 1460514
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: https://review.gluster.org/17844
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
commit 5f40a861e4cbe3edc6091d79c1c8ddb5bde40ed8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Aug 2 07:22:13 2017 +0530
extras: Turn eager-lock off for gluster-block
With the current implementation of eager-lock FINODELK is taking so much
time that cassandra workload times out and errors out. AFR eager-locking
needs to be changed similar to EC eager-locking to make things work
as expected. In the interim, it is better to turn it off
This is how the profile looks if eager-lock is turned on:
0.35 628.26 us 64.00 us 129882.00 us 42278 FXATTROP
17.45 16500.54 us 212.00 us 375829.00 us 79568 WRITE
81.76 209862.12 us 15.00 us 1992486.00 us 29318 FINODELK
This is how profile looks if eager-lock is turned off:
1.87 283.71 us 65.00 us 298970.00 us 68346 FXATTROP
6.33 199.04 us 13.00 us 373428.00 us 330524 FINODELK
10.37 3151.47 us 53.00 us 1528484.00 us 34172 FSYNC
81.31 5110.45 us 270.00 us 1519722.00 us 165244 WRITE
BUG: 1477404
Change-Id: I98026b1ecf30002ddac01be76f375c2e8c0b7838
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17954
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 6cec7e367a705eae8fabe03af68a26ef38c6bf79
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jul 31 09:48:09 2017 -0400
scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh
test(1) man pages says -eq is for INTEGER compares, and = is for
string compares.
Also note the comment that -a and -o are ambiguous and to use
test && test or test || test instead.
This bug has existed since 2015! (yikes)
Found while testing localtime logging and running glusterd in the
foreground.
Change-Id: Ia544f7295e247b981504d085ebc4c533ab60ba84
BUG: 1476785
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17925
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 9895a912725765b9a9fef095b515fdee058b3adf
Author: Günther Deschner <gd@samba.org>
Date: Fri Jul 28 13:38:16 2017 +0200
md-cache: avoid checking the xattr value buffer with string functions.
xattrs may very well contain binary, non-text data with leading 0
values. Using strcmp for checking empty values is not the appropriate
thing to do: In the best case, it might treat a binary xattr value
starting with 0 from being cached (and hence also from being reported
back with xattr). In the worst case, we might read beyond the end
of a data blob that does contain any zero byte.
We fix this by checking the length of the data blob and checking
the first byte against 0 if the length is one.
Signed-off-by: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Michael Adam <obnox@samba.org>
Change-Id: If723c465a630b8a37b6be58782a2724df7ac6b11
BUG: 1476324
Reviewed-on: https://review.gluster.org/17910
Reviewed-by: Michael Adam <obnox@samba.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: Poornima G <pgurusid@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit bf6abbcd2604a7307272c61decf88288dbe59c28
Author: hari gowtham <hgowtham@redhat.com>
Date: Mon Jan 23 16:38:00 2017 +0530
tier: separation of attach-tier from add-brick
PROBLEM: Both attach tier and add brick have the same RPC
and set of code. This becomes a hurdle while tring to implement
add brick on a tiered volume.
FIX: This patch separates the add brick and attach tier
giving them separate RPCs.
Change-Id: Iec57e972be968a9ff00b15b507e56a4f6dc398a2
BUG: 1376326
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/15503
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 024f9e2707fad38b6644a4607091e9ba6ee7c5e1
Author: Michael Adam <obnox@samba.org>
Date: Tue Jun 13 14:44:39 2017 +0200
glusterd: streamline logic flow in glusterd_validate_quorum()
Make an earlier exit when the volume is not of server quorum.
Thereby it spares the actual quorum calculation in this case.
This also increases the overall readability of the function.
The patch is best seen with the --patience diff option to
understand what it does (e.g. "git show --patience").
Change-Id: Ifce50bc3f73d79d3d6226473661a83696d65149a
BUG: 1476719
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: https://review.gluster.org/17924
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 7e5670ffee40acc952c2360bf46199bd4c614e05
Author: Susant Palai <spalai@redhat.com>
Date: Thu Jul 27 16:33:12 2017 +0530
cluster/dht: Handle wrong rebalance status reporting
Change-Id: Id91ef35f890055cd42b9a94462f92297c77f1fff
Bug: 1475282
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/17868
Tested-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 70c1f482ac1b4f8af3233520224afdad6ec6d637
Author: Susant Palai <spalai@redhat.com>
Date: Wed Jul 26 17:12:03 2017 +0530
cluster/dht: rebalance min-free-disk fix
To calculate available space on a subvolume we used to do
the following in __dht_check_free_space.
post_availspace = (dst_statfs.f_bavail * dst_statfs.f_frsize) - stbuf->ia_size
Now to subtracting the file size from available space is tricky here.
Sometime available space will be lesser than the file size and since all the
participating members in calculation are unsigned int, the result is a large
number (integer overflow).
Solution: We do not need to subtract the file size from the space available,
since fallocate would have reserved file size space already.
Change-Id: I4f724358c44b9911933742ff3ff8d55b3dfda1cb
BUG: 1475282
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/17876
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit dfb4e7a71a376d9f581223a06584a2c199048aeb
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jul 25 09:25:53 2017 +0200
nfs: use "/" as subdir for volume mounts
For cases where subdir mounting is checked, it makes it much easier to
return a subdir of "/" in case no subdir is passed. This reduces the
number of corner cases where permissions are checked for subdir mounts,
but not for volume mounts (or the other way around).
The problem was identified by WebNFS mounting a volume, which got denied
after commit e3f48fa2. Handling this would require an exception for
non-subdir mounts, or make non-subdir mounts equal to subdir mounts.
This change takes the 2nd approach.
Change-Id: I0d810ae90b267a2cc3eac8d55368a0f1b0787f6a
Fixes: e3f48fa2 ("nfs: add permission checking for mounting over WebNFS")
BUG: 1468291
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17898
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit efb4636ace393525ff220a0ffced3bca7953294d
Author: Jeff Darcy <jdarcy@fb.com>
Date: Wed Jul 26 11:56:04 2017 -0700
error-gen: fix randomness
This generates errors in a truly random distribution, including streaks
and dry spells, instead of just setting a constant interval between
errors. It also supports very small error probabilities, down to 1ppm
instead of 1%. Also cleaned up some bad logic in the "random-failure"
case.
Change-Id: I17b058c4b86b0aa17dd5706250e6d44f242fcd9d
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17886
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 2195d432f49f1e6f67f1d09e91b93fc0f719bf6b
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jul 31 12:32:59 2017 +0530
cluster/dht: Check for open fd only on EBADF
DHT fd based fops will now check if the fd is
open on the cached subvol only if the call fails
with EBADF.
This will improve performance for scenarios where
a rebalance is not running which would be most of
the time.
Change-Id: Idfaeb8927af769c6110d07a165a0fe2307369239
BUG: 1476665
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17922
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 9f0f00d309fb49e2fb8fbdbfc856b5d5bc1e043b
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Jul 28 15:18:29 2017 +0530
ec/cluster: Update failure of fop on a brick properly
Problem:
In case of truncate, if writev or open fails on a brick,
in some cases it does not mark the failure onlock->good_mask.
This causes the update of size and version on all the bricks
even if it has failed on one of the brick. That ultimately
causes a data corruption.
Solution:
In callback of such writev and open calls, mark fop->good
for parent too.
Thanks Pranith Kumar K <pkarampu@redhat.com> for finding the
root cause.
Change-Id: I8a1da2888bff53b91a0d362b8c44fcdf658e7466
BUG: 1476205
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://review.gluster.org/17906
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 2da3fad21dbb8832bfdb3b4f6084f212e20e908a
Author: Michael Adam <obnox@samba.org>
Date: Tue Jun 13 10:16:27 2017 +0200
glusterd: improve intuitivity of check in glusterd_get_quorum_cluster_counts
More intuitive to check for ret == 0 than !ret here...
Change-Id: I8177a0bc8f266331187f5f2eeefea8a25cfcb30a
Signed-off-by: Michael Adam <obnox@samba.org>
BUG: 1476410
Reviewed-on: https://review.gluster.org/17912
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1b97556b4b4e3b32423c2fae7675c86b681404fc
Author: Jeff Darcy <jdarcy@fb.com>
Date: Thu Jul 27 09:03:40 2017 -0700
glusterd: fix misleadingly named GF_FOR_EACH_ENTRY_IN_DIR
What it really does is skip irrelevant entries like . and .. until
we're at an entry we might actually care about. Renamed to
GF_SKIP_IRRELEVANT_ENTRIES accordingly.
Change-Id: If0464451a8243c29c0a93b4c6f0f0eda2fade44c
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17901
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit b786ffee094d4718ba2fbba685b61d0afa4c5670
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jul 26 16:17:03 2017 +0200
changelog: add mem-pool initialization
With recent changes to the mem-pool initialization,
mem_pools_init_early() and mem_pools_init_late() need to be called
before mem_get() is usable.
This change has been tested manually with the included test from
xlators/features/changelog/lib/examples/c/get-changes.c.
Change-Id: I139563c4ff78a566cef2ff7e3da2ee10306def92
BUG: 1475255
Reported-by: Kotresh HR <khiremat@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17900
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 1510feab499c5d43d73147213714dda6de340b2d
Author: Günther Deschner <gd@samba.org>
Date: Wed Jul 26 18:10:33 2017 +0200
md-cache: Use correct xattr keynames for virtual glusterfs ACLs.
The "glusterfs.posix_acl." prefix does not catch the glusterfs posix acl
xattr keynames which are
* "glusterfs.posix.acl" and
* "glusterfs.posix.default_acl"
Using the GF_POSIX_ACL_ACCESS and GF_POSIX_ACL_DEFAULT defines directly
is the savest option.
Guenther
Change-Id: I5aba64b26b6cbec850ea02316dd9f069400e857f
BUG: 1476295
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-on: https://review.gluster.org/17909
Reviewed-by: Michael Adam <obnox@samba.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit c34e53c132c6d7f52854f182503edff2a074dc8b
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jul 27 07:32:36 2017 -0400
geo-rep: Convert gfid mismatch logs to structured logging
Convert the logs related to entry failures fix
due to gfid mismatch logs into structured logging
format
Change-Id: I9bce950c5339b48d3ec8b84bddee38b0473b7634
Updates: #246
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17896
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 3cf87a175da11802d2bbac1c32e2dc1d2a2be5db
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jul 20 17:08:12 2017 +0530
tools/setgfid2path: Tool to set GFID to Path xattr in brick backend
Once storage/gfid2path feature is enabled using `gluster volume set
<volname> storage.gfid2path enable`, it starts recording the gfid2path
xattr on each files. But this feature will not add xattr to the existing
files.
This tool accepts the file path as argument and sets the necessary xattr
required for this feature.
Change-Id: I75ad82c86ce482950645e687ff2e33b413fa53da
Updates: #139
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/17839
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 9b1f783ccaec26a3571a96eaed6b202f33bad539
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jul 26 16:16:11 2017 +0200
mem-pool: track and verify initialization state
It is possible that pthread_getspecific() returns a non-NULL value in
case the pthread_key_t is not initialized. The behaviour for
pthread_getspecific() is not defined in this case. This can happen when
applications use mem-pools from libglusterfs.so, but did not call
mem_pools_init_early().
By tracking the status of the mem-pools initialization, it is now
possible to prevent calling pthread_getspecific() in case the
pthread_key_t is not initialized. In future, we might want to exend this
more to faciliate debugging.
Reported-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Jiffin Tony Thottan <jthottan@redhat.com>
Change-Id: I6255419fe05792dc78b1eaff55bc008fc5ff3933
Fixes: 1e8e62640 ("mem-pool: initialize pthread_key_t pool_key in mem_pool_init_early()")
BUG: 1475255
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17899
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 8fc0ba380ac39c8974759cf764368c308c7505bf
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jul 26 08:09:31 2017 -0400
geo-rep: Fix syncing of self healed hardlinks
Problem:
In a distribute replicate volume, if the hardlinks
are created when a subvolume is down, it gets
healed from other subvolume when it comes up.
If this subvolume becomes ACTIVE in geo-rep
there are chances that those hardlinks won't
be synced to slave.
Cause:
AFR can't detect hardlinks during self heal.
It just create those files using mknod and
the same is recorded in changelog. Geo-rep
processes these mknod and ignores it as
it finds gfid already on slave.
Solution:
Geo-rep should process the mknod as link
if the gfid already exists on slave.
Change-Id: I2f721b462b38a74c60e1df261662db4b99b32057
BUG: 1475308
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17880
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 6fa53e2e4bde73f8eef8795874c4e73d58694b7e
Author: Kotresh HR <khiremat@redhat.com>
Date: Sun Jul 16 15:16:56 2017 -0400
storage/posix: Add virtual xattr to fetch path from gfid
The gfid2path infra stores the "pargfid/bname" as on xattr
value for each non directory entry. Hardlinks would have a
separate xattr. This xattr key is internal and is not
exposed to applications. A virtual xattr is exposed for
the applications to fetch the path from gfid.
Internal xattr:
trusted.gfid2path.<xxhash>
Virtual xattr:
glusterfs.gfidtopath
getfattr -h -n glusterfs.gfidtopath /<aux-mnt>/.gfid/<gfid>
If there are hardlinks, it returns all the paths separated
by ':'.
A volume set option is introduced to change the delimiter
to required string of max length 7.
gluster vol set gfid2path-separator ":::"
Updates: #139
Change-Id: Ie3b0c3fd8bd5333c4a27410011e608333918c02a
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17785
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 48b588d3a954661889625fee357ef2b31dd02bcc
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Tue Jul 18 16:23:18 2017 +0530
glusterd : glusterd fails to start when peer's network interface is down
Problem:
glusterd fails to start on nodes where glusterd tries to come up even
before network is up.
Fix:
On startup glusterd tries to resolve brick path which is based on
hostname/ip, but in the above scenario when network interface is not
up, glusterd is not able to resolve the brick path using ip_address or
hostname With this fix glusterd will use UUID to resolve brick path.
Change-Id: Icfa7b2652417135530479d0aa4e2a82b0476f710
BUG: 1472267
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-on: https://review.gluster.org/17813
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bca9f99dd08267a920458463dafa06bd7a078867
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Jul 27 09:25:32 2017 +0530
changetimerecorder: Brick process crashed at ctr xlator in notify function
Problem: Sometime brick process is getting crash in notify function at the
time of cleanup db connection while brick mux is enabled.
Solution: In changetimerrecorder (ctr) notify function after cleanup
db connection set to db_conn to NULL to avoid reuse the same
db connection again.
Note: Below is the backtrace pattern showing by brick process
#0 0x00007ff98a30c1f7 in raise () from /lib64/libc.so.6
#1 0x00007ff98a30d8e8 in abort () from /lib64/libc.so.6
#2 0x00007ff98a34bf47 in __libc_message () from /lib64/libc.so.6
#3 0x00007ff98a351b54 in malloc_printerr () from /lib64/libc.so.6
#4 0x00007ff98a3537aa in _int_free () from /lib64/libc.so.6
#5 0x00007ff97d95e311 in gf_sql_connection_fini (sql_connection=sql_connection@entry=0x7ff8e8496b50) at gfdb_sqlite3.c:42
#6 0x00007ff97d95e38a in gf_sqlite3_fini (db_conn=0x7ff92ca04470) at gfdb_sqlite3.c:507
#7 0x00007ff97d957156 in fini_db (_conn_node=0x7ff92ca04470) at gfdb_data_store.c:326
#8 0x00007ff97db78679 in notify (this=0x7ff92c5b3670, event=9, data=0x7ff92c5b5a00) at changetimerecorder.c:2178
#9 0x00007ff98bca0dc2 in xlator_notify (xl=0x7ff92c5b3670, event=event@entry=9, data=data@entry=0x7ff92c5b5a00) at xlator.c:549
#10 0x00007ff98bd3ac12 in default_notify (this=this@entry=0x7ff92c5b5a00, event=9, data=data@entry=0x7ff92c5b6d50) at defaults.c:3139
BUG: 1475632
Change-Id: Idd4bfdb4629c4799ac477ade81228065212683fb
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/17888
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit f43a9011ed63c7bebe26524ad425e5981c744896
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jul 27 14:11:27 2017 +0200
libglusterfs: the global_xlator should have valid cbks
There is a case where Gluster/NFS needs to resolve a path outside of the
nfs-xlator itself. While resolving the path to fetch the GFID for
creating the NFS-filehandle, gfapi may set an inode-ctx through
glfs_resolve_at(). This inode-ctx is linked with the global_xlator.
Because the global_xlator does not have any cbks, loc_wipe() will cause
a segfault when it calls inode_unref() and xl->cbks->forget(). It is
assumed that all xlators have a cbks symbol, otherwise loading of the
xlator will fail. The global_xlator is not loaded in the same way, so
there is no failure noticed when the instance is created. By adding an
empty `struct xlator_cbks`, the global_xlator behaves similat to other
xlators that do not implement all callbacks.
I would have preferred to keep the inode-ctx setting through
glfs_resolve_at() contained within Gluster/NFS. Unfortunately
Gluster/NFS also uses the inode-ctx, and is not prepared to see the
values that glfs_resolve_at() stores there.
This problem is not easily reproducible because it involves mounting
over WebNFS (like Solaris 10 can do). The segfault will also not be
immediate, unless the following is done:
1. create a subdir on a volume
2. mount the volume/subdir over WebNFS
3. unmount the volume/subdir
4. mount the root of the volume
5. delete the subdir on the volume -> segfault of Gluster/NFS
Change-Id: I2bd71d033e97edc07ba93b2d4ada558f65d68999
BUG: 1468291
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17897
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 744ce1c5987c77ad3e8d115a11a8caafd012c361
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Jul 26 16:47:16 2017 +0530
build: Add stamp-h2 to gitignore
Recent change https://review.gluster.org/17206 which adds site.h to
sources results in the generation of another timestamp file named
'stamp-h2'. This change adds 'stamp-h2' also to gitignore.
Change-Id: I2592a283ec13e99b547b38c8b374874e50d5e3c1
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: https://review.gluster.org/17877
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 09e95bf3c5b028f1c877d77a8aa87093e19cb09d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 26 20:27:08 2017 +0530
group-gluster-block: Set default shard-block-size to 64MB
With 4MB shard size I/O slows down more because of the extra
inodelk/xattrops in replicate. So increasing it to 64MB which
gave better performance than 4MB.
To simulate writes on a preallocated VM-image, fallocate the file and then do
dd with notrunc
do "fallocate -l 1GB" then "dd if=/dev/zero of=file-1GB bs=1MB count=1024 conv=notrunc"
These are the results on my laptop for dd:
With 4MB:
1.84 1357.37 us 19.00 us 12431.00 us 1188 FINODELK
2.45 255.08 us 58.00 us 4038.00 us 8428 WRITE
95.69 78967.76 us 30.00 us 20324240.00 us 1063 FXATTROP
With 64MB:
0.13 59.36 us 15.00 us 814.00 us 657 FINODELK
6.02 225.53 us 69.00 us 6556.00 us 8205 WRITE
93.82 103015.12 us 32.00 us 13046368.00 us 280 FXATTROP
BUG: 1475605
Change-Id: I4ed5441409df639e38c731ba0d140fe92902f25f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17887
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 2a46289cc2c9545d4bedb50db7ec684d3a6e074c
Author: Jeff Darcy <jdarcy@fb.com>
Date: Tue Jul 25 17:40:49 2017 -0700
glusterd: make peerfile parsing more robust
Differential Revision: https://phabricator.intern.facebook.com/D5498639
Change-Id: I3184ed8f3dadbdcffd46f4ade855fa93131efa82
BUG: 1462969
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17885
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 6f24632753eae3bb7791954facdeece197ecdb4d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri May 17 12:52:32 2013 +0530
performance/io-cache: update inode contexts of each entry in readdirplus
io-cache stores read-cache in inode which is currently created only in
lookup. But, with readdirplus and md-cache absorbing lookups, io-cache
need not receive a lookup before a fop like readv.
Change-Id: I6eba995b0a90d4d5055a4aef0489707b852da1b8
BUG: 1474180
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: https://review.gluster.org/5029
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit a3a93f810a93974f2f4b335c580611133b2fce6e
Author: Susant Palai <spalai@redhat.com>
Date: Tue Jul 25 11:43:37 2017 +0530
cluster/dht: change log level to debug for thread activity
Every time all the thread sleeps or wakes up, we log a message
about that event. Sometime this can be noisy where the number of
files eligible to be migrated are placed far away from each other.
Moving the logs to DEBUG.
Change-Id: I4dc2cc9fdf4f42d4001754532a5bc4aeb3f0f959
BUG: 1474639
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/17866
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 681dee6860cf7a9c9e62f086598e7af9101b2082
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Jul 22 16:36:42 2017 +0200
gfapi: mark glfs_ipc() for internal use only
The 3.7 version of glfs_ipc() has never been used by external
applications. There is little use for internal xlator communication that
is triggered from outside of core GlusterFS executables. This function
has now been removed from libgfapi.so.
For Gluster 4.0 a new variation for glfs_ipc() has been added. The
function expects dict_t parameters, which are currently not available
for external applications. There is no sense in providing glfs_ipc() for
non-core GlusterFS executables. Therefore, glfs_ipc() has been marked as
private, and the declaration is now in the glfs-internal.h header.
The Python test case (tests/features/ipctest.py) is not correct and will
be re-written in C to prevent portability issues. This test is currently
disabled (commit d26f0bac149d495fa93710c3f7b6b63c36cb8387).
Change-Id: Idbfe35570d34d45ce8b6b43084627a552ac21f59
Fixes: #269
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17854
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit f63eacecab3126e4e4580c979f8719be66ff7bf5
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Jul 26 12:46:42 2017 +0530
cli: error out incomplete CLI commands
cli_cmd_bricks_parse () & cli_cmd_volume_remove_brick_parse () were not
handling the the error cases where the command is incomplete with
missing brick details which could lead to glusterd crashes.
Credit : george.lian@nokia.com
Change-Id: Ia6303457a2aa279465aa75d4e1cfcc948893d5de
BUG: 1396327
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17870
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 5e2701092247964a468388e6fd843bad05f05c0e
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jul 24 19:47:07 2017 +0530
glusterd: highlight arbiter brick in get-state
Fixes: #278
Change-Id: I1af5255127457a70e6362a2c20c53ee533e27c29
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17864
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Shubhendu Tripathi <shtripat@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 307de95cab62d378029e60231f8bd16873bc678c
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jul 24 18:27:39 2017 +0530
cluster/dht: Fix negative rebalance estimates
The calculation of the rebalance estimates will start
after the rebalance operation has been running for 10
minutes. This patch also changes the cli rebalance status
code to use unsigned variables for the time calculations.
Change-Id: Ic76f517c59ad938a407f1cf5e3b9add571690a6c
BUG: 1457985
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17863
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1c3d6915cc4d9c70a602e27b1d75364b326fb970
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Jul 25 14:28:00 2017 +0530
cluster/dht: Update size processed for non-migrated files
The size of non-migrated files was not added to the
size_processed causing incorrect rebalance estimate
calculations. This has been fixed.
Change-Id: I9f338c44da22b856e9fdc6dc558f732ae9a22f15
BUG: 1467209
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17867
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f4b7bd6094036e3d3f710ea11cea65d7a455ea3d
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jul 21 12:06:20 2017 +0200
glusterd: fix compile warning in glusterd_volinfo_copy_brickinfo()
gcc 7 (default in Fedora 26) complains about the following:
glusterd-utils.c: In function ‘glusterd_volinfo_copy_brickinfo’:
glusterd-utils.c:4279:54: warning: comparison between pointer and zero character constant [-Wpointer-compare]
if (old_brickinfo->real_path == '\0') {
^~
glusterd-utils.c:4279:29: note: did you mean to dereference the pointer?
if (old_brickinfo->real_path == '\0') {
^
Comparing a char* with a char is not correct in any case. Instead,
compare it to NULL and the char[0] with '\0'.
Change-Id: Ie5b925cd200416a1e2fa035046005f421994e641
Updates: #259
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17847
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit fe2f14baeee520bf870e2dbe7d194ce6a152716a
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Sat Jul 15 17:55:14 2017 +0530
posix: Needs to reserve disk space to prevent the brick from getting full
Problem: Currently there is no option available at posix xlator to save the
disk from getting full
Solution: Introduce a new option storage.reserve at posix xlator to
configure disk threshold.posix xlator spawn a thread to update the
disk space status in posix private structure and same flag is checked
by every posix fop before start operation.If flag value is 1 then
it sets op_errno to ENOSPC and goto out from the fop.
BUG: 1471366
Change-Id: I98287cd409860f4c754fc69a332e0521bfb1b67e
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/17780
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 63025e5af78e953480db8a1134ebd4c070332055
Author: Prashanth Pai <ppai@redhat.com>
Date: Fri Jul 21 15:48:23 2017 +0530
rpc: prevent logging null client [Invalid argument]
The following log entry is observed during volume operations such
as volume create:
[2017-07-20 05:13:43.213797] E [client_t.c:321:gf_client_ref]
(-->/usr/local/lib/libgfrpc.so.0(rpcsvc_request_create+0x1a4) [0x7f987f66cd20]
-->/usr/local/lib/libgfrpc.so.0(rpcsvc_request_init+0xd0) [0x7f987f66ca23]
-->/usr/local/lib/libglusterfs.so.0(gf_client_ref+0x56) [0x7f987f91cbd5] )
0-client_t: null client [Invalid argument]
Change-Id: I49ba753e8d1a828bb275b0ccb1a181706774f387
BUG: 1193929
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: https://review.gluster.org/17848
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 30957e5f782f939d1ece7c9f62ba4ee56b973c37
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jul 24 17:48:47 2017 +0530
cluster/dht: Correct iterator for decommissioned bricks
Corrected the iterator for looping over the list of
decommissioned bricks while checking if the new target
determined because of min-free-disk values has been
decommissioned.
Change-Id: Iee778547eb7370a8069e954b5d629fcedf54e59b
BUG: 1474318
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17861
Reviewed-by: Susant Palai <spalai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 273972672167750636606038588fbc5d58727135
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Sun Jul 23 22:07:34 2017 +0530
glusterd: Add option to get all volume options through get-state CLI
This commit makes the get-state CLI capable to returning the values
for all volume options for all volumes. This is similar to what you
get when you issue a `gluster volume get <volname> all` command.
This is the new usage for the get-state CLI:
# gluster get-state [<daemon>] [[odir </path/to/output/dir/>] \
[file <filename>]] [detail|volumeoptions]
Fixes: #277
Change-Id: Ice52d936a5a389c6fa0ba5ab32416a65cdfde46d
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17858
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 6e6abf130491303fc9a2ba17bb9a6122d034ec34
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jul 19 16:14:59 2017 +0530
storage/posix: Use the ret value of posix_gfid_heal()
... to make the change in commit acf8cfdf truly useful.
Without this, a race between entry creation fops and lookup
at posix layer can cause lookups to fail with ENODATA, as
opposed to ENOENT.
Change-Id: I44a226872283a25f1f4812f03f68921c5eb335bb
BUG: 1472758
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17821
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a9d2bd88eafd87a2a5ab550cb3c96f3a285690f4
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jul 24 17:54:07 2017 +0530
glusterd: add rebal estimates time in get-state
Fixes: #279
Change-Id: If62fa59042604c9450749d3012c7a962ed0eb374
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17862
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6c354e6674a545191fae76c7c30fbaa6dd86d5af
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jun 23 13:10:56 2017 +0530
posix: option to handle the shared bricks for statvfs()
Currently 'storage/posix' xlator has an option called option
`export-statfs-size no`, which exports zero as values for few
fields in `struct statvfs`. In a case of backend brick shared
between multiple brick processes, the values of these variables
should be `field_value / number-of-bricks-at-node`. This way,
even the issue of 'min-free-disk' etc at different layers would
also be handled properly when the statfs() sys call is made.
Fixes #241
Change-Id: I2e320e1fdcc819ab9173277ef3498201432c275f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17618
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a068b1ada7e18bdc4b1a40902d4084435bdc1afb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 24 11:31:56 2017 +0530
extras: Disable remote-dio in gluster-block profile
gluster-block file is opened with O_DIRECT but because block-profile has
remote-dio enabled, it is leading to high latency for fsync which leads to
failures in cassandra. Disabling remote-dio fixed this issue. We need to change
remote-dio to disabled in gluster-block.
BUG: 1474190
Change-Id: Ifd845ea9cbdcc08dd6073faca6082682af376ca3
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17856
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 494d545aba78d3b508733baf57aa4fe600242f75
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jul 10 10:31:27 2017 -0400
posix/gfid2path: Block access to gfid2path xattr via mount
gfid2path xattr is an internal xattr and should not be
allowed to modify by other applications via gluster
mount. This patch blocks the same.
Updates: #139
Change-Id: Id2cb29797ee1bd77e0e0d2203a47469fd7203355
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17744
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d229eaee6f6c074a09ff89e71b9ba7fca577452a
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Jul 20 02:54:30 2017 +0530
tests: replace brick failure shouldn't corrupt volfiles
This is a test to present the known issue. It will be skipped as it has
the known issue marker.
Change-Id: Id6fa5d323abe0bc76a58cd92cb8e52fcde41b49b
BUG: 1473026
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: https://review.gluster.org/17828
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit df4232287410468696ae5df0ca78cccc2647316e
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jul 20 16:59:32 2017 +0200
libglusterfs: prevent compile warnings with roof() and floor()
gcc 7 (default in Fedora 26) complains about the roof() and floor()
macros:
stripe.c: In function 'stripe_truncate':
stripe.c:701:49: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
tmp_offset = roof(offset, fctx->stripe_size *
../../../../libglusterfs/src/common-utils.h:55:35: note: in definition of macro 'roof'
#define roof(a,b) ((((a)+(b)-1)/((b)?(b):1))*(b))
^
stripe.c:704:50: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
tmp_offset = floor(offset, fctx->stripe_size *
../../../../libglusterfs/src/common-utils.h:56:28: note: in definition of macro 'floor'
#define floor(a,b) (((a)/((b)?(b):1))*(b))
^
The calculations done in stripe_truncate() look safe enough, but gcc
does not seem to like the passing the int/size_t to the `((b)?(b):1)`
compact if-statement, so use `b != 0` for the test.
Change-Id: If9fa4b8e86ba4b2ace61b1e05a5c28050fe4a7d3
Updates: #259
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17842
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 986ab34d0ebd4d747d1454581b0fe34040e5d2ec
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jul 20 02:20:29 2017 +0530
crypt: fix evaluation of args to macro
GCC 7 warns about the following
crypt.c:3685:31: warning: ?: using integer constants in boolean context,
the expression will always evaluate to ‘true’ [-Wint-in-bool-context]
local->op_ret < 0 ? -1 : 0,
../../../../libglusterfs/src/stack.h:342:36: note: in definition of
macro ‘STACK_UNWIND_STRICT’
} else if (op_ret == 0) {
\
^~~~~~
}
This is because args to pre-processor are lazily evaluated and operator
precedence for == is higher than ?:
Change-Id: I2c2ffb08bc3731ad0e17796047e01cb10771dbcf
Updates: #259
Reported-by: Raghavendra Talur <rtalur@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17827
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 94dcf9f6ef61edf884b57edf286b1f0e2b9dc6ab
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jul 18 15:47:13 2017 +0530
run-tests.sh: log failed tests at the end
Two benefits:
1. People who subscribe to emails on regression failures
(like maintainers@gluster.org), can see the list of failed tests
in the email itself, instead of clicking on the link and checking
for failures.
2. When we visit the regression console, instead of scrolling to the
exact position to see which tests failed, we can just press 'End'
and would be able to check failures.
Change-Id: Ibb4ac9575c5d32bae9c40c31fb53c9488b94421a
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17843
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 029d7a647690c6db3d25fca404804ef05959c739
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jun 19 13:40:35 2017 -0400
geo-rep: Handle possible entry failures gracefully
Updates: #246
Change-Id: If0ce83fe8dd3068bfb671f398b2e82ac831288d0
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17577
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit d03b5118fffcc8ffeb11e94e337e31b3f179a881
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jul 19 13:53:27 2017 +0200
nfs: improve error handling for WebNFS mount permissions
In case nfs3_funge_webnfs_zerolen_fh() returns an error, the
nfs3_call_state_t structure will not get initialized. This means that
calling `nfs3_call_state_wipe (cs)` will result in a segmentation fault
after commit daed52b8eb that makes nfs3_call_state_t refcounted.
Change-Id: I4c300aedf132a7fea95756dd278ff87d67722478
BUG: 1468291
Fixes: e3f48fa2 ("nfs: add permission checking for mounting over WebNFS")
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17822
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
commit 4bdf92b63b62481bb3e31b3e05508ad4ff2e3c6b
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Jul 3 14:51:21 2017 +0530
tools/glusterfind: Fix encoding to encode only space,newline and percent chars
libgfchangelog was encoding path using spec rfc3986, but encoding only
required for SPACE, NEWLINE and PERCENT chars since the NEWLINE char is
used as record separator and SPACE as field separator in the parsed
changelogs output.
Changed the encoding function to encode only SPACE, NEWLINE and PERCENT chars
BUG: 1451724
Change-Id: Ic1dea824d23493dedcf3db45f353f90572f4e046
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/17788
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
commit c948bf41ed80a9478e8dde17cfcb24a219f96ad6
Author: Milind Changire <mchangir@redhat.com>
Date: Fri Jul 7 10:49:23 2017 +0530
rpc: include current second in timed out frame cleanup
Problem:
frames which time out at current second are missed out
Solution:
change test to include frames timing out at current second
i.e. timeout <= current.tv_sec
instead of
timeout < current.tv_sec
Change-Id: I459d47856ade2b657a0289e49f7f63da29186d6e
BUG: 1468433
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/17722
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2930457801d4e3c2d3476d0763945fbc4c979e32
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Jul 3 14:51:21 2017 +0530
geo-rep: Fix changelog encoding to encode only space and newline
libgfchangelog was encoding path using spec rfc3986, but encoding only
required for SPACE and NEWLINE chars since the NEWLINE char is used as
record separator and SPACE as field separator in the parsed changelogs
output.
Changed the encoding function to encode only SPACE and NEWLINE.
BUG: 1451724
Change-Id: I1936efad31788a9e636f912c832ed7d7efea4fe2
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/17787
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 5af86459d5ec5b105da57c33dd798c6be67e63b1
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Jul 3 14:51:21 2017 +0530
features/libgfchangelog: Fix encoding to encode only space and newline
libgfchangelog was encoding path using spec rfc3986, but encoding only
required for SPACE and NEWLINE chars since the NEWLINE char is used as
record separator and SPACE as field separator in the parsed changelogs
output.
Changed the encoding function to encode only SPACE and NEWLINE.
BUG: 1451724
Change-Id: I4305459aab9e710517dd3eb065f0024503064b77
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/17674
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit aca2f0d0ae43380888d3e2cd6ad9cd22dc6cd021
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Jun 20 21:28:20 2017 +0530
MAINTAINERS: Changes for Maintainers 2.0
Updates MAINTAINERS to be in sync with [1]. More details on Maintainers
2.0 can be found at [2].
[1] https://goo.gl/CcvP5K
[2] https://hackmd.io/s/SkwiZd4qe
Change-Id: I069ee8eb78ec4f5272052f3ba902eb29f0fdb64b
BUG: 1463365
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: https://review.gluster.org/17583
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
commit 81c5018bec4e8bd46eb7c821b029088d53e43b59
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jul 20 18:11:14 2017 +0530
glusterd: fix brick start race
Problem:
Another race where glusterd was restarted glusterd_brick_start () is called
multiple times due to friend handshaking and in one instance when one of the
brick was attempted to be attached to the existing brick process,
send_attach_req failed as the first brick itself was still not up and then we
did a synlock_unlock () followed by a sleep of 1 sec, before the same thread
woke up, another thread tried to start the same brick process and then it
assumed that it has to start a fresh brick process.
Solution:
1. If brick is in starting phase (brickinfo->status ==
GF_BRICK_STARTING), no need for a reattempt to
start the brick.
2. While initiating attach_req set brickinfo->status to
GF_BRICK_STARTING
Change-Id: Ib007b6199ec36fdab4214a1d37f99d7f65ef64da
BUG: 1465559
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17840
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 4d5a933e154a6252dd6dbc4a93d4841ac26e0688
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Jul 19 21:44:55 2017 +0530
cluster/dht: Fixed crash in dht_rmdir_is_subvol_empty
The local->call_cnt was being accessed and updated inside
the loop where the entries were being processed and the calls
were being wound.
This could end up in a scenario where the local->call_cnt became
0 before the processing was complete causing the crash when the
next entry was being processed.
Change-Id: I930f61f1a1d1948f90d4e58e80b7d6680cf27f2f
BUG: 1472949
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17825
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit d3f70dacb48f388c1cc5b46ee8504602c19f36d3
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jul 13 13:44:19 2017 +0200
mem-pool: free objects from pools on mem_pools_fini()
When using a minimal gfapi application that only initializes a small
graph (sink, shard and meta xlators) the following memory leaks are
reported by Valgrind:
HEAP SUMMARY:
in use at exit: 322,976 bytes in 75 blocks
total heap usage: 684 allocs, 609 frees, 2,092,116 bytes allocated
With this change, the mem-pools are cleaned up on calling of
mem_pools_fini() and the objects in the pool are free'd.
HEAP SUMMARY:
in use at exit: 315,265 bytes in 58 blocks
total heap usage: 684 allocs, 626 frees, 2,092,079 bytes allocated
This information was gathered with `./run-xlator.sh features/shard` that
comes with `gfapi-load-volfile` from gluster-debug-tools.
While working on the free'ing of the per_thread_pool_list_t structures,
it became apparent that GF_CALLOC() in mem_get_pool_list() gets
redirected to a standard calloc() without prepending the Gluster
specific memory header. This is because mem_pools_init() gets called
before THIS->ctx is valid, so it is not possible to check if memory
accounting is enabled or not. Because of this, the GF_CALLOC() call in
mem_get_pool_list() has been replaced by CALLOC() to prevent potential
mismatches between the allocation/free'ing of per_thread_pool_list_t
structures.
Change-Id: Id6f558816f399b0c613d74df36deac2300b6dd98
BUG: 1470170
URL: https://github.com/gluster/gluster-debug-tools
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17768
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: soumya k <skoduri@redhat.com>
commit 936fdb8fb4b8a558c8104fac854fefe5cd64c87d
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jul 14 18:35:10 2017 +0200
mem-pool: initialize pthread_key_t pool_key in mem_pool_init_early()
It is not possible to call pthread_key_delete for the pool_key that is
intialized in the constructor for the memory pools. This makes it
difficult to do a full cleanup of all the resources in mem_pools_fini().
For this, the initialization of pool_key should be moved to
mem_pool_init().
However, the glusterfsd binary has a rather complex initialization
procedure. The memory pools need to get initialized partially to get
mem_get() functionality working. But, the pool_sweeper thread can get
killed in case it is started before glusterfsd deamonizes.
In order to solve this, mem_pools_init() is split into two pieces:
1. mem_pools_init_early() for initializing the basic structures
2. mem_pools_init_late() to start the pool_sweeper thread
With the split of mem_pools_init(), and placing the pthread_key_create()
in mem_pools_init_early(), it is now possible to correctly cleanup the
pool_key with pthread_key_delete() in mem_pools_fini().
It seems that there was no memory pool initialization in the CLI. This
has been added as well now. Without it, the CLI will not be able to call
mem_get() successfully which results in a hang of the process.
Change-Id: I1de0153dfe600fd79eac7468cc070e4bd35e71dd
BUG: 1470170
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17779
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 74be2339103bc85cb76193308805afac365db36d
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Tue Jul 18 21:33:45 2017 +0530
glusterd: Set default value for cluster.max-bricks-per-process to 0
When brick-multiplexing is enabled, and
"cluster.max-bricks-per-process" isn't explicitly set, multiplexing
happens without any limit set. But the default value set for that
tunable is 1, which is confusing. This commit sets the default
value to 0, and prevents the user from being able to set this value
to 1 when brick-multiplexing is enbaled. The default value of 0
denotes that brick-multiplexing can happen without any limit on the
number of bricks per process.
Change-Id: I4647f7bf5837d520075dc5c19a6e75bc1bba258b
BUG: 1472417
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17819
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f26e9ef1a5d79ffc269342aab763c21cb1bbf7c0
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Jul 18 11:36:19 2017 +0530
libglusterfs: Name threads on creation
Set names to threads on creation for easier
debugging.
Output of top -H -p <PID-OF-GLUSTERFSD>
Before:
19773 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19774 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19775 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19776 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19777 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19778 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19779 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19780 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19781 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19782 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19783 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19784 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19785 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.01 glusterfsd
19786 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.01 glusterfsd
19787 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.01 glusterfsd
19789 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19790 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
25178 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
5398 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
7881 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
After:
19773 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19774 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glustertimer
19775 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterfsd
19776 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glustermemsweep
19777 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glustersproc0
19778 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glustersproc1
19779 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterepoll0
19780 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusteridxwrker
19781 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusteriotwr0
19782 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterbrssign
19783 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterbrswrker
19784 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterclogecon
19785 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.01 glusterclogd0
19786 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.01 glusterclogd1
19787 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.01 glusterclogd2
19789 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterposixjan
19790 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterposixfsy
25178 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterepoll1
5398 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterepoll2
7881 root 20 0 1301.3m 12.6m 8.4m S 0.0 0.1 0:00.00 glusterposixhc
Change-Id: Id5f333755c1ba168a2ffaa4fce6e71c375e10703
BUG: 1254002
Updates: #271
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: https://review.gluster.org/11926
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit e85e87af20724f23892ace2448c657c563c1ad5d
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Apr 24 17:44:11 2015 +0530
doc: beginner's guide to syncop framework
Change-Id: I1f4517e1952d5b82ce679ebd2544b7403b1d37d8
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: https://review.gluster.org/10365
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ff3170269a05651c810f38ea8afc66b7fdadd41b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 18 15:23:12 2017 +0530
common-utils: Remove fop_enum_to_string, get_fop_int
Implementation of these two functions becomes easier by using gf_fop_list[]
array. So implemented that and removed usage of these functions.
BUG: 1472250
Change-Id: I8a592913f9eeb02d965708bcf28a637588ed4988
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17812
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 00e09adfc4e568d2ed5ae197b815a9d716b03f22
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 18 15:25:48 2017 +0530
extras: Change Makefile generation in generate_xlator.py
Makefile generation should include default LD_FLAGS and also include rpc
related paths in include path
Change-Id: I45e1c97b96f08bbfe4663384f4873726febef9f6
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17811
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 2c2af45e80f9a23bf8ab548896e19660880c1e27
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Jun 7 15:56:13 2017 +0530
cluster/afr: GFID split-brain resolution with existing CLI
Problem:
Currently there is no way for the admin from CLI to resolve gfid
split-brain based on some policy like choice of the brick, mtime
or size.
Fix:
With the existing CLI options based on size, mtime, and choice of
brick, we do lookup on the parent for the specified file. As
part of the lookup, if we find gfid mismatch, we resolve them
based on the policy and return. If the file is not in gfid split-
brain, then we check for the data and metadata split-brain in the
getxattr code path, and resolve if any.
This will work provided absolute path to the file with the CLI
and not with gfid of the file. Hence the source-brick policy
without any file path will also not resolve the gfid split-brain
since it uses the gfid of the files. But it can resolve any other
type of split-brains and skip the gfid mismatch resolution with
the usual error message.
Reverting the change https://review.gluster.org/17290. This patch
resolves the issue.
Fixes gluster/glusterfs#135
Change-Id: Iaeba6fc32f184a34255d03be87cda02773130a09
BUG: 1459530
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: https://review.gluster.org/17485
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 805cb6f0c78788bf59717afb3f7bd5fcc07d3796
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Tue Jul 18 11:36:19 2017 +0530
cluster/ec: Test script failing with brick multiplexing enabled
Problem:
Killing the bricks(using kill signal) in test scripts will
result in test failures with brick multiplexing enabled.
Solution:
Updated the script to use kill_brick function to bring down
the bricks.
BUG: 1472094
Change-Id: Ibbf1fdc1be660ad3cd93e95af2838c0aae0181af
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
Reviewed-on: https://review.gluster.org/17809
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit ab5cd1af2e966b89978f3d0a29d2bfbb9ada7065
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Jul 10 20:43:39 2017 +0530
rfc.sh: make alignment check compulsory
Earlier, it was not reported if a function call had arguments on next
line and the args were not aligned to opening bracket. With this change,
it is a check that is displayed in output.
I have not analyzed what all --strict brings in. If it is found to be
more restrictive than required, we may choose to promote this *one* CHK
to WARN and stop using --strict.
Sample:
CHECK: Alignment should match open parenthesis
+ ret = gf_asprintf (&footer,
+ " [%s]", strerror(errnum));
total: 0 warnings, 1 checks, 8 lines checked
Change-Id: I48834087efcae872b69746ba962b0bb1c130b5cd
BUG: 1469179
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: https://review.gluster.org/17737
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: ankitraj
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Sonal Arora <sarora@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 9ec42ef8fa017746f2fa8f3ad18c9794e8af1997
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jul 17 11:40:33 2017 +0200
tests: disable IPC test-case
The IPC test-case is not correct, and can cause segfaults or hangs. The
ipctest.py script calls glfs_ipc() with the `glfs_t` structure, but
should do so with a `glfs_fd_t`.
In addition, the test-case is written in a way that we do not suggest to
use libgfapi. Python scripts are encouraged to use the bindings from the
libgfapi-python project. It would be better to rewrite the test in C so
that there is type-checking while compiling and no additional issues
with portability (see `LD_PRELOAD` note in the `.t` file).
Change-Id: Icb52b5b1585fbee98f2c694547c31df0aa2ba70b
Updates: #269
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17786
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 99d7524f76451640865249cf1824ccfee765efb6
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Apr 25 10:43:07 2017 +0530
program/GF-DUMP: Shield ping processing from traffic to Glusterfs Program
Since poller thread bears the brunt of execution till the request is
handed over to io-threads, poller thread experiencies lock
contention(s) in the control flow till io-threads, which slows it
down. This delay invariably affects reading ping requests from network
and responding to them, resulting in increased ping latencies, which
sometimes results in a ping-timer-expiry on client leading to
disconnect of transport. So, this patch aims to free up poller thread
from executing code of Glusterfs Program. We do this by making
* Glusterfs Program registering itself asking rpcsvc to execute its
actors in its own threads.
* GF-DUMP Program registering itself asking rpcsvc to _NOT_ execute
its actors in its own threads. Otherwise program's ownthreads become
bottleneck in processing ping traffic. This means that poller thread
reads a ping packet, invokes its actor and hands the response msg to
transport queue.
Change-Id: I526268c10bdd5ef93f322a4f95385137550a6a49
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
BUG: 1421938
Reviewed-on: https://review.gluster.org/17105
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 856f4f434e34c060a8db0810513787e664213d3e
Author: Prashanth Pai <ppai@redhat.com>
Date: Wed Jul 12 12:44:45 2017 +0530
Update .gitignore
Change-Id: Ica39edaf4388502d2f40c6daa5b4d65abda3bab1
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: https://review.gluster.org/17754
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: ankitraj
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 4d074833487f113e8ed7527d956699052c65a002
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 12 09:18:02 2017 +0530
storage/posix: Don't allow gfid/volume-id xattr to be removed
Problem:
Bulk xattr removal doesn't check if the xattrs that are coming in xdata
have gfid/volume-id xattrs, so there is potential for bulkremovexattr
removing gfid/volume-id.
I also observed that bulkremovexattr is not available for fremovexattr.
Fix:
Do proper checks in bulk removexattr to remove gfid/volume-id.
Refactor [f]removexattr to reduce the differences.
BUG: 1470489
Change-Id: Ia845b31846a149500111c0996646e648f72cdce6
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17765
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 5b2da09eb5ff1dd4745815a8c41e88904256d0c5
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Mon Jul 17 17:38:48 2017 +0530
glusterd: Add description field to global options for brick-mux
Currently the "cluster.brick-multiplex" and
"cluster.max-bricks-per-process" options do not show anything in
the description field when gluster volume set help is called. This
commit adds the description fields for these 2 options.
Change-Id: I3d162c61fa2774dd994f046e305d457f0fd43192
BUG: 1471790
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17790
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit c4c03d163687593e45d9da624261007815695252
Author: Prashanth Pai <ppai@redhat.com>
Date: Wed Jul 12 12:59:35 2017 +0530
socket: call init_openssl_mt() in init() and add cleanup
init_openssl_mt() wasn't explicitly invoked and was run implicitly before
dlopen() returned as it was tagged as __attribute__ ((constructor)). This
function used to call GF_CALLOC() which wasn't available or initialized
when socket.so is dlopen()ed by an external program. The program used to
crash with SIGSEGV as follows:
0x00007ffff5efe1ad in __gf_calloc (nmemb=41, size=40, type=158, typestr=0x7ffff63eb3d6 "gf_sock_mt_lock_array")
at mem-pool.c:109
0x00007ffff63e6acf in init_openssl_mt () at socket.c:4016
0x00007ffff7de90da in call_init.part () from /lib64/ld-linux-x86-64.so.2
0x00007ffff7de91eb in _dl_init () from /lib64/ld-linux-x86-64.so.2
0x00007ffff7dedde1 in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
0x00007ffff7de8f84 in _dl_catch_error () from /lib64/ld-linux-x86-64.so.2
0x00007ffff7ded339 in _dl_open () from /lib64/ld-linux-x86-64.so.2
This change moves call to init_openssl_mt() from being a constructor function
to the init() function and introduces fini_openssl_mt() which cleans up
resources (called in destructor).
BUG: 1193929
Change-Id: Iab690897ec34e24c33f6b43f8d8d9f8fd75ac607
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: https://review.gluster.org/17753
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 1d7932bda2a6b276d0486828f8894dbc2557d08b
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Fri Jun 30 17:11:46 2017 +0530
systemd/glusterfssharedstorage : remove dependency for var-run-gluster-shared_storage
Currently the script used by glusterfssharedstorage have dependency over
var-run-gluster-shared_storage. But this service will be present only if
node has rebooted. Also in reboot scenario , there is a chance that this
service can be executed before creating var-run-gluster-shared_storage.
In that case glusterfssharedstorage will get succeed even without mounting
the shared storage
Also the type of glusterfssharedstorage changed to "forking" so that it can
be active(instead of dead) after the successful start.
Change-Id: I1c02cc64946e534d845aa7ec7b72644bbe4d26f9
BUG: 1452527
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: https://review.gluster.org/17658
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 8d9ad8f3a2f8f9a2e47e968a0aae26201b09cfc8
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Sun Jul 9 23:16:39 2017 -0400
quota: fix a crash by using bad regfile inode as parent
0 0x00007f1482f1f1d7 in raise () from /lib64/libc.so.6
1 0x00007f1482f208c8 in abort () from /lib64/libc.so.6
2 0x00007f1482f18146 in __assert_fail_base () from /lib64/libc.so.6
3 0x00007f1482f181f2 in __assert_fail () from /lib64/libc.so.6
4 0x00007f148484986a in __inode_link (inode=inode@entry=0x7f14742404d4,
parent=parent@entry=0x7f14742404d4,
name=name@entry=0x7f1460001c48 "testfile5308",
iatt=iatt@entry=0x7f1460001bc8) at inode.c:954
5 0x00007f1484849969 in inode_link (inode=0x7f14742404d4,
parent=parent@entry=0x7f14742404d4,
name=name@entry=0x7f1460001c48 "testfile5308",
iatt=iatt@entry=0x7f1460001bc8) at inode.c:1060
6 0x00007f147591b895 in quota_build_ancestry_cbk (
frame=frame@entry=0x7f1482315e80, cookie=<optimized out>,
this=0x7f147000e910, op_ret=op_ret@entry=6904, op_errno=op_errno@entry=0,
entries=entries@entry=0x7f1474731c00, xdata=xdata@entry=0x0) at quota.c:779
7 0x00007f1475b2f505 in marker_build_ancestry_cbk (frame=0x7f1482315988,
cookie=<optimized out>, this=<optimized out>, op_ret=<optimized out>,
op_errno=<optimized out>, entries=0x7f1474731c00, xdata=0x0)
at marker.c:3055
8 0x00007f14848b9cd9 in default_readdirp_cbk (
frame=frame@entry=0x7f1482315b30, cookie=<optimized out>,
this=<optimized out>, op_ret=op_ret@entry=6904, op_errno=op_errno@entry=0,
entries=entries@entry=0x7f1474731c00, xdata=xdata@entry=0x0)
at defaults.c:1403
9 0x00007f1475f68132 in pl_readdirp_cbk (frame=0x7f1482315dac,
cookie=<optimized out>, this=<optimized out>, op_ret=6904, op_errno=0,
entries=0x7f1474731c00, xdata=0x0) at posix.c:2700
10 0x00007f1476e26819 in posix_readdirp (frame=0x7f1482315f54,
this=<optimized out>, fd=<optimized out>, size=<optimized out>,
off=<optimized out>, dict=<optimized out>) at posix.c:6282
11 0x00007f1475f6599a in pl_readdirp (frame=0x7f1482315dac,
this=0x7f147000a200, fd=0x7f1484b5106c, size=0, offset=0,
xdata=0x7f1481ab4f34) at posix.c:2711
12 0x00007f14848ce954 in default_readdirp_resume (frame=0x7f1482315b30,
this=0x7f147000b690, fd=0x7f1484b5106c, size=0, off=0,
xdata=0x7f1481ab4f34) at defaults.c:2019
13 0x00007f148485c92d in call_resume (stub=0x7f1481b65710) at call-stub.c:2508
14 0x00007f1475d54743 in iot_worker (data=0x7f147004e7d0) at io-threads.c:210
15 0x00007f148369cdc5 in start_thread () from /lib64/libpthread.so.0
16 0x00007f1482fe173d in clone () from /lib64/libc.so.6
Change-Id: I740dc691e7be1bc2a9ae3a0cb14bbf566ea77bc5
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Reviewed-on: https://review.gluster.org/17730
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 7c809d03abefccb3cf6b419862f3e4671bc2ef90
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jul 14 13:17:48 2017 +0200
mem-pool: remove references to unused ctx->mempool_list
Only the old (removed) implementation of mem-pools provided access to
the ctx->mempool_list to faciliate state-dumps. The usage of the
mempool_list has been disabled with "#if defined(OLD_MEM_POOLS)", but a
few occurences were missed.
Change-Id: I912fb63830efc06247eb0c6551d198271ee57a86
BUG: 1470170
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17778
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0ea292c61791c6b7f21f9065d83ad7e203a99478
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jul 13 11:35:50 2017 -0400
packaging: various directories not owned by any package
e.g. /usr/libexec/glusterfs or /usr/lib64/glusterfs/$NV/xlator
Change-Id: Ibccb8d27b6ad3d6c335e5bbf39aec03b4fe5c8dd
BUG: 1470768
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17770
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 04f33219d51c9a8afb3ed3ea55b68f87ca8c8367
Author: Danny Couture <couture.danny@gmail.com>
Date: Wed Jul 5 09:55:17 2017 -0400
fuse: memory leak fixes
Fix fuse ctx memory leak in case an error occurs and the cleanup path
is different than usual. Also fix a memory leak in logging if
eh_save_history() fails.
Change-Id: I7ec967c807b0ed91184e5b958be70702215c46c9
BUG: 1470220
Signed-off-by: Danny Couture <couture.danny@gmail.com>
Reviewed-on: https://review.gluster.org/17759
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 3f826f774cf47c1e8ff00b30b45aab81c07952ee
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jul 13 08:10:27 2017 -0400
core: miscellaneous cleanup
clean up things that I tripped over doing other changes.
1) fix mishmash of random spacing in struct decls in glusterfs.h.
Not technically a problem, just ugly to look at.
2) replace open-coded strings constants with existing #define
constants. A disaster waiting to happen.
3) Use sys_access() instead of sys_stat() or sys_lstat() to test
simple existence of file. Why copy dozens of bytes from kernel to
user space that aren't going to be used by anything? There are
probably more instances like these.
Change-Id: I28089bef4cc93d5e4e4213045fb1a2649d110f82
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17769
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 70fb82ee315fd3e1e78125039f0e689deb3771ce
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Wed Jul 5 16:41:38 2017 +0530
cluster/ec: Non-disruptive upgrade on EC volume fails
Problem:
Enabling optimistic changelog on EC volume was not
handling node down scenarios appropriately resulting
in volume data inaccessibility.
Solution:
Update dirty xattr appropriately on good bricks whenever
nodes are down. This would fix the metadata information
as part of heal and thus ensures data accessibility.
BUG: 1468261
Change-Id: I08b0d28df386d9b2b49c3de84b4aac1c729ac057
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
Reviewed-on: https://review.gluster.org/17703
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit c087432c66863b17271c0da006e3583727e10b6d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jul 6 19:49:47 2017 +0530
afr: mark non sources as sinks in metadata heal
Problem:
In a 3 way replica, when the source brick does not have pending xattrs
for the sinks, but the 2 sinks blame each other, metadata heal was not
happpening because we were not setting all non-sources as sinks.
Fix: Mark all non-sources as sinks, like it is done in data and entry
heal.
Change-Id: I534978940f5087302e307fcc810a48ffe898ce08
BUG: 1468279
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17717
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6273b6abee96c1c356c2fb19ee1c77163e1cc572
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Jul 13 12:23:13 2017 +0530
posix: brick process crash after stop the volume while brick mux is on
Problem: sometime brick process is getting crash after stop the volume
while brick mux is enabled and no. of volumes are high
Solution: In posix notify at the time close mount_lock dir , dir handle
needs to set NULL to avoid the reuse of same dir handle.
BUG: 1470533
Change-Id: Ifd41c20b3c597317851f91049a7c801949840b16
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/17767
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 0d80340498ec49d9c4683d951c7b7d6f999a2613
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jul 6 16:40:07 2017 +0530
cluster/ec: Get size of file in EC [f]xattrop
Problem:
For allowing parallel writes we shouldn't depend on ia_size to be same for
all the bricks in each write_cbk(). But we need to make sure backend size
is correct on all the bricks and no crashes/manual modifications happened.
Fix:
At the time of get_size_version() we do 1 check to make sure size of the file
is same across the bricks. From then on the FOPs will give the status of the
fop, so we rely on this information to keep which bricks are good/bad.
Updates #251
Change-Id: I1df645347e2e9f2e09cfa4411b6cc305d7f4e4e5
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17741
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 166ed5f64967bf5bd56653233952e5c18e2ccb37
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jul 6 16:39:37 2017 +0530
storage/posix: Handle [f]xattrop xdata
Updates #251
Change-Id: I13d89c3b5dc39aa0a232a70be8ec6b64394cfa6e
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17740
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 11d7ad8b6407ca4dfca0f9fbf2fd6103d38b6fcd
Author: Susant Palai <spalai@redhat.com>
Date: Wed Jul 12 12:01:40 2017 +0530
cluster/rebalance: Fix hardlink migration failures
A brief about how hardlink migration works:
- Different hardlinks (to the same file) may hash to different bricks,
but their cached subvol will be same. Rebalance picks up the first hardlink,
calculates it's hash(call it TARGET) and set the hashed subvolume as an xattr
on the data file.
- Now all the hardlinks those come after this will fetch that xattr and will
create linkto files on TARGET (all linkto files for the hardlinks will be hardlink
to each other on TARGET).
- When number of hardlinks on source is equal to the number of hardlinks on
TARGET, the data migration will happen.
RACE:1
Since rebalance is multi-threaded, the first lookup (which decides where the TARGET
subvol should be), can be called by two hardlink migration parallely and they may end
up creating linkto files on two different TARGET subvols. Hence, hardlinks won't be
migrated.
Fix: Rely on the xattr response of lookup inside gf_defrag_handle_hardlink since it
is executed under synclock.
RACE:2
The linkto files on TARGET can be created by other clients also if they are doing
lookup on the hardlinks. Consider a scenario where you have 100 hardlinks. When
rebalance is migrating 99th hardlink, as a result of continuous lookups from other
client, linkcount on TARGET is equal to source linkcount. Rebalance will migrate data
on the 99th hardlink itself. On 100th hardlink migration, hardlink will have TARGET as
cached subvolume. If it's hash is also the same, then a migration will be triggered from
TARGET to TARGET leading to data loss.
Fix: Make sure before the final data migration, source is not same as destination.
RACE:3
Since a hardlink can be migrating to a non-hashed subvolume, a lookup from other
client or even the rebalance it self, might delete the linkto file on TARGET leading
to hardlinks never getting migrated.
This will be addressed in a different patch in future.
Change-Id: If0f6852f0e662384ee3875a2ac9d19ac4a6cea98
BUG: 1469964
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/17755
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 4618a811609c79ddf413b998268e39d0fe2c058a
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jul 10 11:45:31 2017 +0200
gfapi: prevent mem-pool leak in case glfs_new_fs() fails
Commit 7039243e187 adds a call to mem_pools_init() so that the memory
pool cleanup thread ("sweeper") is started. However, now it is possible
that users of gfapi can not cleanup this thread because glfs_new() can
return NULL, but the sweeper is still running.
In case glfs_fs_new() fails, mem_pools_fini() needs to be called as
well. This seems more correct than calling mem_pools_init() after
glfs_fs_new(), and this makes using memory pools possible *really* early
in the gfapi initialization.
Change-Id: I1f2fb25cc33e227b3c33ce9d1b03f67bc27e981a
Fixes: 7039243e187 ("gfapi: add mem_pools_init and mem_pools_fini calls")
BUG: 1468863
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17734
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit d8c904e64715e065e0c0156a0ad7a99cf4b7d224
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Mar 6 10:19:54 2017 -0500
features/read-only: Allow internal clients to r/w
If the "read-only" volume option is set, it would
make the volume "read-only". But it also makes it
read-only to gluster internal clients such as
gsyncd, self heal, bitd, rebalance etc. In which
case, all the internal operations would fail. This
patch allows internal clients to read and write
when "read-only" option is set.
Change-Id: I8110e8d9eac8def403bb29f235000ddc79eaa433
BUG: 1430608
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/16855
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Karthik U S <ksubrahm@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 0ca4ae7fbf92ad9d530ffca1cae103bdc3a7c1c3
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Tue Jul 4 11:18:16 2017 +0530
gluster man page: Add remote-host and script mode in gluster man page
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Change-Id: I2d9b9f09d72d713e34ccb9516387c5982b830115
BUG: 1467277
Reviewed-on: https://review.gluster.org/17685
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit b0798fdb5d3d0763d6f80494b77c39e941692a57
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jul 10 15:45:04 2017 +0530
cluster/dht: Clear clean_dst flag on target change
If the target of a file migration was changed because
of min-free-disk limits, the dst_fd was closed but the
clean_dst flag was not set to false. If the file could
not be created on the new target for some reason, the
ftruncate call to clean up the dst was sent on the now
invalid fd causing the process to deadlock.
Change-Id: I5bfa80f519b04567413d84229cf62d143c6e2f04
BUG: 1469029
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17735
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 273c7d5981db2259d25947d7b44f694ea6d3ac9a
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jul 10 09:38:54 2017 +0530
cluster/dht: Fix fd check race
There is a another race between the cached subvol
being updated in the inode_ctx and the fd being opened on
the target.
1. fop1 -> fd1 -> subvol0
2. file migrated from subvol0 to subvol1 and cached_subvol
changed to subvol1 in inode_ctx
3. fop2 -> fd1 -> subvol1 [takes new cached subvol]
4. fop2 -> checks fd ctx (fd not open on subvol1) -> opens fd1 on subvol1
5. fop1 -> checks fd ctx (fd not open on subvol0)
-> tries to open fd1 on subvol0 -> fails with "No such file on directory".
Fix:
If dht_fd_open_on_dst fails with ENOENT or ESTALE, wind to old subvol
and let the phase1/phase2 checks handle it.
Change-Id: I34f8011574a8b72e3bcfe03b0cc4f024b352f225
BUG: 1465075
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17731
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 171f053daee0e0ea85c57dcfc43e927e26992df2
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jun 29 05:45:34 2017 -0400
storage/posix: New gfid2path infra
With this infra, a new xattr is stored on each entry
creation as below.
trusted.gfid2path.<xxhash> = <pargfid>/<basename>
If there are hardlinks, multiple xattrs would be present.
Fops which are impacted:
create, mknod, link, symlink, rename, unlink
Option to enable:
gluster vol set <VOLNAME> storage.gfid2path on
Updates: #139
Change-Id: I369974cd16703c45ee87f82e6c2ff5a987a6cc6a
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17488
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 95bb19ca3cdd636730041505cf27105188111055
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jul 3 13:13:35 2017 +0530
cluster/dht: Use size to calculate estimates
The earlier approach of using the number of files
to determine when the rebalance would complete did
not work well when file sizes differed widely.
The new approach now gets the total data size and
uses that information to determine how long
the rebalance is expected to take.
Change-Id: I84e80a0893efab72ff06130e4596fa71c9c8c868
BUG: 1467209
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17668
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: MOHIT AGRAWAL <moagrawa@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 593c8528356b4ecfe2b72ad0cef8c5c39922f8ae
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jul 7 02:46:26 2017 +0530
tests: fix stats-dump.t failure
Since https://review.gluster.org/#/c/17452, the statistics are appended
to the same file instead of overwritten over the previous stats. This
was causing the .t to fail since it checks for only the presence of a
non zero aggr.fop.write.count assuming the latest statistics will
overwrite the previous ones.
Fix it by checking for that the latest value of aggr.fop.write.count is
non zero.
Change-Id: I858011f343966a5d1c19d66dcc64b8cd26315df7
BUG: 1468432
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17721
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 37302125d93d4207f42d6c4609ca23c47caa60d2
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jul 6 14:25:09 2017 +0530
extras: Enable stat-prefetch in virt profile
In the internal testing that was done, stat-prefetch did help
reduce the number of stats coming from qemu hitting the disk,
and thereby improved performance.
Change-Id: Icf1ce62ecf4e96b97e1946a77b30434157a7786a
BUG: 1468191
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17713
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 97d0ce7d5b89f86d536e613d83ef11384e1fe383
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Jul 6 13:26:42 2017 +0530
mgtm/core : use sha hash function for volfile check
We are storing the entire volfile and using this to check
volfile change. With brick multiplexing there will be lot
of graphs per process which will increase the memory foot
print of the process. So instead of storing the entire
graph we could use sha256 and we can compare the hash to
see whether volfile change happened or not.
Also with Brick multiplexing, the direct comparison of vol
file is not correct. There are two problems.
Problem 1:
We are currently storing one single graph (the last
updated volfile) whereas, what we need is the entire
graph with all atttached bricks.
If we fix this issue, we have second problem
Problem 2:
With multiplexing we have a graph that contains multiple
bricks. But what we are checking as part of the reconfigure
is, comparing the entire graph with one single graph,
which will always fail.
Solution:
We create list in glusterfs_ctx_t that stores sha256 hash
of individual brick graphs. When a graph changes happens
we compare the stored hash and the current hash. If the
hash matches, then no need for reconfigure. Otherwise we
first do the reconfigure and then update the hash.
For now, gfapi has not changed this way. Meaning when gfapi
volfile fetch or reconfigure happens, we still store the
entire graph and compare, each memory.
This is fine, because libgfapi will not load brick graphs.
But changing the libgfapi will make the code similar in
both glusterfsd-mgmt and api. Also it helps to reduce some
memory.
Change-Id: I9df917a771a52b95622ab8f63af34ec390163a77
BUG: 1467986
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17709
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 451e1d456189fb7a7d391294c96561586878edaf
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Fri Jun 2 10:12:12 2017 +0530
glusterd: Introduce option to limit no. of muxed bricks per process
This commit introduces a new global option that can be set to limit
the number of multiplexed bricks in one process.
Usage:
`# gluster volume set all cluster.max-bricks-per-process <value>`
If this option is not set then multiplexing will happen for now
with no limitations set; i.e. a brick process will have as many
bricks multiplexed to it as possible. In other words the current
multiplexing behaviour won't change if this option isn't set to
any value.
This commit also introduces a brick process instance that contains
information about brick processes, like the number of bricks
handled by the process (which is 1 in non-multiplexing cases), list
of bricks, and port number which also serves as an unique identifier
for each brick process instance. The brick process list is
maintained in 'glusterd_conf_t'.
Updates: #151
Change-Id: Ib987d14ab0a4f6034dac01b73a4b2839f7b0b695
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17469
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 332857e7b393df5332a50786cd79115280a3fe5c
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jul 6 17:04:17 2017 +0200
nfs: add permission checking for mounting over WebNFS
Solaris 10 uses WebNFS and not the MOUNT protocol. All permission checks
for allowing/denying clients to mount are done through the MNT handlers.
These handlers will not give out a filehandle to the NFS-client when
mounting is denied. This prevents clients from successful mounting.
However, over WebNFS a well known 'root-filehandle' is used directly
with the NFSv3 protocol.
When WebNFS was used, no permission checks (the "nfs.export-dir" option)
were applied. Now the WebNFS mount-handler in Gluster/NFS calls the
mnt3_parse_dir_exports() function that takes care of the permission
checking.
BUG: 1468291
Change-Id: Ic9dfd092473ba9c1c7b5fa38401cf9c0aa8395bb
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17718
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit d31b9575c884f47b93292039c106e7601a79e0ae
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jul 4 20:11:11 2017 +0200
nfs/nlm: keep track of the call-state and frame for notifications
When blocking locks are used, a new frame is allocated that is used to
send the notification to the client once once the lock becomes
available. In all other cases, the frame that contains the request from
the client will be used for the reply.
Because there was no way to track the different clients with their
requests (captured in the call-state), the call-state could be free'd
before the notification was sent to the client. This caused a
use-after-free of the call-state and could trigger segfaults of the
Gluster/NFS server or incorrect replies on (un)lock requests.
By introducing a nlm4_notify_args structure, the call-state and frame
can be tracked better. This prevents the possibility of segfaulting when
the call-state is used after being free'd.
BUG: 1467313
Change-Id: I285d2bc552f509e5145653b7a50afcff827cd612
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17700
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit efb1ec82b6d2484c78ff8ae3d49f23a2c39aefd6
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jul 3 16:24:53 2017 +0200
nfs/nlm: use refcounting for nfs3_call_state_t
In order to track down a potential use-after-free of the
nfs3_call_state_t structure in the NLM component, add reference counting
where teh structure is used. This should prevent premature free'ing of
the structure.
Change-Id: Ib1f13b0463ab1e012b7b49a623c91f0f3e73e1fb
BUG: 1467313
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17699
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 8f85f2211128da6e54313cb0d048b7013f9f89d2
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jun 21 16:25:33 2017 +0200
nfs/nlm: handle reconnect for non-NLM4_LOCK requests
When a reply on an NLM-procedure gets stuck, the NFS-client will resend
the request. This can happen through a re-connect in case the connection
was terminated (long delay in the reply on the initial request). Once
that happens, not all NLM-procedures are handled correctly.
Testing this is difficult and time-consuming. There still may be
problems with certain operations, but this definitely makes it behave
much better than before.
The problem occured due to a problem in EC, change-id I18a782903ba
addressed the root cause.
Change-Id: I23b385568e27232951fa3fbd7198a0e5d775a8c2
BUG: 1467313
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17698
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit fda4ab161161d0d83a52d69498c8718c871bd6f4
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Jul 3 16:37:01 2017 +0530
uss/svc: fix double free on xdata dictionary
we were taking unref on wrong dictionary which results
in wrong memory access.
Change-Id: Ic25a6c209ecd72c9056dfcb79fabcfc650dd3c1e
BUG: 1467513
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17691
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 1afd4b866372bec1bc6d09f7507609f7b0860185
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Jul 3 12:45:38 2017 +0530
svc: send revalidate lookup on special dir
.snaps directory is a virtual direcotory, that doesn't
exist on the backend. Even though it is a special dentry,
it doesn't have a dedicated inode. So the inode number is
always random. Which means it will get different inode
number when reboot happens on snapd process.
Now with windows client the show-direcotry feature requires
a lookup on the .snpas direcoty post readdirp on root.
If the snapd restarted after a lookup, then subsequent lookup
will fail, because linked inode will be stale.
This patch will do a revalidate lookup with a new inode.
Change-Id: If97c07ecb307cefe7c86be8ebd05e28cbf678d1f
BUG: 1467513
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17690
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 5c0e26bd555b5290954650558a5fc307dc236cd2
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Jun 30 20:17:20 2017 +0530
svs:implement CHILD UP notify in snapview-server
protocol/server expects a child up event to successfully
configure the graph. In the actual brick graph, posix is
the one who decide to initiate the notification to the parent
that the child is up.
But in snapd graph there is no posix, hence the child up
notification was missing.
Ideally each xlator should initiate the child up event whenever
it see's that this is the last child xlator.
Change-Id: Icccdb9fe920c265cadaf9f91c040a0831b4b78fc
BUG: 1467513
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17689
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 5d2694fa1a79308bc8c3dbd23703d4bcd4ea64ec
Author: Jeff Darcy <jdarcy@fb.com>
Date: Fri Jul 7 07:49:45 2017 -0700
gfapi+libglusterfs: fix mem_pools_fini without mem_pools_init case
The change consists of two parts: make sure it doesn't happen (in
glfs.c), and make it harmless if it does (in mem-pool.c).
Change-Id: Icb7dda7a45dd3d1ade2ee3991bb6a22c8ec88424
BUG: 1468863
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17728
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 9252af88544a6168d0afb2da0f828c2f1aa45087
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Jul 4 16:18:20 2017 +0530
cluster/ec : Don't try to heal when no sink is UP
Problem:
4 + 2 EC volume configuration.
If untar of linux is going on and we kill a brick,
indices will be created for the files/dir which need
to be healed. ec_shd_index_sweep spawns threads to
scan these entries and start heal. If in the middle
of this we kill one more brick, we end up in a
situation where we can not heal an entry as there
are only "ec->fragment" number of bricks are UP.
However, the scan will be continued and it will
trigger the heal for those entries.
Solution:
When a heal is triggered for an entry, check if it
*CAN* be healed or not. If not come out with ENOTCONN.
Change-Id: I305be7701c289f36bd7bde22491b71074771424f
BUG: 1464359
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://review.gluster.org/17692
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Sunil Kumar Acharya <sheggodu@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit e0d17b0ff95825a4714500cbcee76162cb134a73
Author: Nigel Babu <nigelb@redhat.com>
Date: Fri Jul 7 11:06:37 2017 +0530
tests: Disable basic/stats-dump.t
Disabling this test right now so that master is green again. This patch
https://review.gluster.org/#/c/17721/ will actually fix the test. This
patch will make master green again unblocking other patches to land onto
master.
Change-Id: I77d177ce92eb6edcf5326b27a0f7fdbefdec007b
Signed-off-by: Nigel Babu <nigelb@redhat.com>
BUG: 1468432
Reviewed-on: https://review.gluster.org/17723
commit f2058aa25b357c8885f5373f45c5950acc840c9e
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Jul 5 17:48:37 2017 +0200
groups: don't allocate auxiliary gid list on stack
When glusterfs wants to retrieve the list of auxiliary gids
of a user, it typically allocates a sufficiently big gid_t
array on stack and calls getgrouplist(3) with it. However,
"sufficiently big" means to be of maximum supported gid list
size, which in GlusterFS is GF_MAX_AUX_GROUPS = 64k.
That means a 64k * sizeof(gid_t) = 256k allocation, which is
big enough to overflow the stack in certain cases.
A further observation is that stack allocation of the gid list
brings no gain, as in all cases the content of the gid list
eventually gets copied over to a heap allocated buffer.
So we add a convenience wrapper of getgrouplist to libglusterfs
called gf_getgrouplist which calls getgrouplist with a sufficiently
big heap allocated buffer (it takes care of the allocation too).
We are porting all the getgrouplist invocations to gf_getgrouplist
and thus eliminate the huge stack allocation.
BUG: 1464327
Change-Id: Icea76d0d74dcf2f87d26cb299acc771ca3b32d2b
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: https://review.gluster.org/17706
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 2b0f54cca8573031e77fed56440c313dc83e807b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Jun 2 15:42:39 2017 +0530
debug/io-stats: Append stats for each interval in the same file
... instead of overwriting stats from the previous interval.
This is so that consumers of this feature do not have to be worried
about monitoring when each 'ios-dump-interval' has passed and back up
the resultant stats file well before the next interval has expired.
Change-Id: Ide897237bf4d38e5d759f09911f7d9c817019edf
BUG: 1458197
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17452
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 0f936ba41cd3ed92c577fa3b3234993c4b280de8
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jun 30 17:54:34 2017 +0200
nfs/nlm: unref fds in nlm_client_free()
When a nlm_clnt is getting free'd, the FDs associated with this client
should be unref'd as well.
Change-Id: Ifa4ea4b7ed45a454413cfc0c820f2516c534a9aa
BUG: 1467313
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17697
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 323ff9b5797fbdf6d6d231652061d71384ffeaec
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jun 23 10:01:27 2017 +0200
nfs: make nfs3_call_state_t refcounted
There is no refcounting done of the nfs3_call_state_t structure, which
seems to result in use-after-free problems in the NLM part of
Gluster/NFS. The structure is initialized with two different functions,
it is easier to have a single place to do this.
The Gluster/NFS part will not use the refcounting, for now. This is
being added to make the NLM code more stable. nfs3_call_state_wipe()
will behave as before for Gluster/NFS, but cleanup is triggered through
the refcounting now. This prevents major changes to the stable part of
the NFS-server, and makes it possible to improve the NLM component
separately.
Change-Id: I2e15bcf12af74e8a46c2727e4a160e9444d29ece
BUG: 1467313
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17696
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit d299a614e4417f9499d1d17b5e975bfc0cf48239
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Jul 5 14:58:50 2017 +0530
cli/xml: fix return handling
The return code of xmlTextWriter* APIs says it returns either the bytes
written (may be 0 because of buffering) or -1 in case of error. Now if the
volume of the xml data payload is not huge then most of the time the
data to be written gets buffered, however when this grows sometimes this
APIs will return the total number of bytes written and then it becomes
absolutely mandatory that every such call is followed by
XML_RET_CHECK_AND_GOTO otherwise we may end up returning a non zero ret
code which would result into the overall xml generation to fail.
Change-Id: I02ee7076e1d8c26cf654d3dc3e77b1eb17cbdab0
BUG: 1467841
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17702
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
commit 3ba414654b896edb7751b0d59d56ba64e773a65d
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue May 9 19:40:21 2017 +0200
cluster/ec: correctly handle end of file for seek
When a SEEK_HOLE was issued near to the end of file, sometimes an
offset beyond the end of file was returned. Another problem was that
using some offsets greater than the end of file returned successfully
instead of failing with ENXIO.
Change-Id: I238d2884ba02fd19a78116b0f8f8e8d6338fb3f5
BUG: 1449348
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/17228
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6e06e7eb9a2506f30153f05424202fdfc473183d
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jul 4 08:46:06 2017 -0400
geo-rep: Fix entry failure because parent dir doesn't exist
In a distributed volume on master, it can so happen that
the RMDIR followed by MKDIR is recorded in changelog on
a particular subvolume with same gfid and pargfid/bname
but not on all subvolumes as below.
E 61c67a2e-07f2-45a9-95cf-d8f16a5e9c36 RMDIR \
9cc51be8-91c3-4ef4-8ae3-17596fcfed40%2Ffedora2
E 61c67a2e-07f2-45a9-95cf-d8f16a5e9c36 MKDIR 16877 0 0 \
9cc51be8-91c3-4ef4-8ae3-17596fcfed40%2Ffedora2
While processing this changelog, geo-rep thinks RMDIR is
successful and does recursive rmdir on slave. But in the
master the directory still exists. This could lead to
data discrepancy between master and slave.
Cause:
RMDIR-MKDIR pair gets recorded so in changelog when the
directory removal is successful on cached subvolume and
failed in one of hashed subvol for some reason
(may be down). In this case, the directory is re-created
on cached subvol which gets recorded as MKDIR again in
changelog.
Solution:
So while processing RMDIR geo-replication should stat on
master with gfid and should not delete it if it's present.
Change-Id: If5da1d6462eb4d9ebe2e88b3a70cc454411a133e
BUG: 1467718
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17695
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 35a930843a678e42c7720ff3914f0b07b9078503
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jun 29 14:07:51 2017 -0400
gfapi: add mem_pools_init and mem_pools_fini calls
These are both needed because GFAPI clients are a bit unique. They can
be long-running, so they can potentially benefit from the memory
reclamation that mem_pools_init will enable. On the other hand, they
might completely tear down their Gluster environment well before the
process exits, so they need mem_pools_fini as well.
Our main and auxiliary daemons do need mem_pools_init but don't need to
call it themselves because that's handled for them in glusterfsd.c right
after they daemonize. They don't need mem_pools_fini, because the only
place they could *safely* call it is right before exit and then it won't
do them any good. Transient processes (e.g. gf_attach) don't benefit
from either because, well, they're transient. They'll be gone before
memory reclamation matters.
Change-Id: I611cf77d8b408b3ecfc00664e8da294edde9e57a
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17666
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit e6c253ca293319e3f269372603e8f13a62902555
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Jun 30 09:05:51 2017 -0400
core: assorted typos and spelling mistakes from Debian lintian
Plus minor readability improvements.
Reported-by: pmatthaei@debian.org
Change-Id: I5393819a2fc9f240a19811143bb57b127df717cf
BUG: 1466785
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17660
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 819c97595131e16a3ec94b166b7e11c3c65bcdc1
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Jun 12 16:30:20 2017 +0530
posix: Avoid one extra call of l(get|list)xattr call after use buffer in posix_getxattr
Problem: In posix xlator posix_(f)getxattr is calling system call(sys_lgetxattr)
two times to fetch the xattr value.
Solution: After use the extra buffer for first time calling we can avoid second
attempt of system call(sys_lgetxattr) calling in posix_getxattr for most
of the xattrs.
BUG: 1460659
Change-Id: I0d8da776c5bc86653d874a4629a73bbf65c621b8
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/17520
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kinglong Mee
commit 3bb943b3266735dea7b967b3151bd2b468ed11a8
Author: Prashanth Pai <ppai@redhat.com>
Date: Fri Jun 30 15:52:53 2017 +0530
Link against missed libraries to resolve symbols
When external programs perform a dlopen("..so", RTLD_LAZY|RTLD_LOCAL)
on some shared objects like xlators, it can fail with dlerror set to
error string "undefined symbol <some-type>".
This was observed for the following shared objects: fuse.so, quota.so,
quotad.so, server.so, libgfrpc.so and socket.so
P.S: This was found while running a go program which fetches the list
of xlator options (volume_option_t) from xlator's shared object.
BUG: 1193929
Change-Id: I7b958409cf11fb67c2be32a3f85a96fb1260236b
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: https://review.gluster.org/17659
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 8b48499ec905fb1168bf22cad53c0955c6e65591
Author: Jeff Darcy <jdarcy@fb.com>
Date: Fri Jun 30 07:07:16 2017 -0700
libglusterfs: add mem_pools_fini
This also makes mem_pools_init and mem_pools_fini re-callable, so GFAPI
can go through infinite init/fini cycles if they want to. Not saying
that's a good idea, but at least it's safe.
Change-Id: I617913410bcff54568b802cb653f48bdd533bd65
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17662
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit cf15ab075d33a1852dbbabd34f40a6e1ad9b35da
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Jun 25 21:50:09 2017 +0530
glfsheal: prevent background self-heals
Problem:
For a file in gfid split-brain, the parent directory ('/' during
testing) was detected as possibly undergoing heal instead of split-brain
in `heal-info` output. Also, it was not being displayed in `info
split-brain` output for the same reason. The problem was that when `glfsheal`
was run, lookup on '/' triggered a background self-heal due to which processing
of '/' during `heal info` failed to acquire locks with errno=EAGAIN.
Fix:
Set background-self-heal-count to zero while launching glfsheal.
Change-Id: I153a7c75af71f213a4eefacf504a0f9806c528a5
BUG: 1318895
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/13772
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 7c20bdd2c86d5596c0a9ef3126a4c4cf784b15de
Author: Jeff Darcy <jdarcy@fb.com>
Date: Thu Jun 29 10:25:54 2017 -0700
tests: disable crypt.t
This has been nuking just about everything. Kill it with fire.
Change-Id: I5e6e2e4d1568f118298fcf109077db001f87040d
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17652
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 8c5fc7916fb29f2dc5cecd1556ad65ef098984f5
Author: Jeff Darcy <jdarcy@fb.com>
Date: Thu Jun 29 06:50:56 2017 -0700
multiple: fix struct/typedef inconsistencies
The most common pattern, both in our code and elsewhere, is this:
struct _xyz {
...
};
typedef struct _xyz xyz_t;
These exceptions - especially call_frame/call_stack - have been slowing
down code navigation for years. By converging on a single pattern,
navigating from xyz_t in code to the actual definition of struct _xyz
(i.e. without having to visit the typedef first) might even be
automatable.
Change-Id: I0e5dd1f51f98e000173c62ef4ddc5b21d9ec44ed
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17650
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit e16f9f7169b61e38f5120fbf37572f5d1fb1ca78
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Thu Jun 29 15:39:35 2017 +0530
Scripts to identify quota accouting issues
The patch contains 2 scripts:
log_accounting.sh does a du -h on the FS hierarchy and a quota list
on the hierarchy and interleaves the two output. We can then identify
which directory(s) in FS has caused the accounting to go bad and try
to investigate what fops happened on those directories. We can also
limit the set of directories on which we need to set dirty xattr to
correct accounting.
xattr_analysis.py reads all the xattr of a brick and dumps it a human
readable form to ease debugging.
Change-Id: I2155561d10c08dc3ab9e8b09dbd258f0592b4d33
BUG: 1466188
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
Reviewed-on: https://review.gluster.org/17649
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 687c71e935839c94fcd773fc863453e5d6935e1b
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jun 28 05:09:12 2017 -0400
contrib/xxhash: Add xxhash library
xxhash is a faster non-cryptographic hash.
https://github.com/Cyan4973/xxHash
Release Taken: "xxHash v0.6.2"
--------------
Files added:
contrib/xxhash/xxhash.c
contrib/xxhash/xxhash.h
contrib/xxhash/xxhsum.c
Modifications to source:
------------------------
Following functions and data types got 'GF_' prefix
as below to avoid any form of name collisions in future.
---- Functions ----
GF_XXH_versionNumber
GF_XXH32
GF_XXH32_createState
GF_XXH32_freeState
GF_XXH32_copyState
GF_XXH32_reset
GF_XXH32_update
GF_XXH32_digest
GF_XXH32_canonicalFromHash
GF_XXH32_hashFromCanonical
GF_XXH64
GF_XXH64_createState
GF_XXH64_freeState
GF_XXH64_copyState
GF_XXH64_reset
GF_XXH64_update
GF_XXH64_digest
GF_XXH64_canonicalFromHash
GF_XXH64_hashFromCanonical
---- Data Types ----
GF_XXH_errorcode
GF_XXH32_state_t*
GF_XXH32_canonical_t*
GF_XXH32_hash_t
GF_XXH64_state_t*
GF_XXH64_canonical_t*
GF_XXH64_hash_t
It is linked with libglusterfs.so. A wrapper
funtion is also added for the easy usage in
common-utils.c.
xxhash can be used for the all the usecases where
a faster non-cryptographic hash is required.
gfid to path infra would be using this for now.
NOTE:
----
The gluster coding guidelines check is ignored
as maintaining it further would be difficult.
Updates: #253
Change-Id: Ib143f90d91d4ee99864a10246d5983e92900173b
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17641
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 040b7c0ac45b5f85fc217c66ea366aebda06be0a
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Jun 26 18:20:23 2017 +0530
tools/glusterfind: unquote DELETE path before further processing
Problem:
DELETE path is quoted before it reaches glusterfind. This wasn't handled
in the glusterfind code leading to double quoting of path separator
'%2F' to '%252F' i.e. the '%' character in '%2F' itself was quoted to
'%25'
Solution:
unquote the the deleted path before further processing
Change-Id: I2dfbbd7792dc0f9da5c8e02093b0f1c031ff344a
BUG: 1465024
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/17629
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 24405ae65a8c75d1cac742217d2721358dc90601
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jun 28 09:10:53 2017 +0530
features/shard: Remove ctx from LRU in shard_forget
Problem:
There is a race when the following two commands are executed on the mount in
parallel from two different terminals on a sharded volume,
which leads to use-after-free.
Terminal-1:
while true; do dd if=/dev/zero of=file1 bs=1M count=4; done
Terminal-2:
while true; do cat file1 > /dev/null; done
In the normal case this is the life-cycle of a shard-inode
1) Shard is added to LRU when it is first looked-up
2) For every operation on the shard it is moved up in LRU
3) When "unlink of the shard"/"LRU limit is hit" happens it is removed from LRU
But we are seeing a race where the inode stays in Shard LRU even after it is
forgotten which leads to Use-after-free and then some memory-corruptions.
These are the steps:
1) Shard is added to LRU when it is first looked-up
2) For every operation on the shard it is moved up in LRU
Reader-handler Truncate-handler
1) Reader handler needs shard-x to be read. 1) Truncate has just deleted shard-x
2) In shard_common_resolve_shards(), it does
inode_resolve() and that leads to
a hit in LRU, so it is going to call
__shard_update_shards_inode_list() to move the
inode to top of LRU
2) shard-x gets unlinked from the itable
and inode_forget(inode, 0) is called
to make sure the inode can be purged
upon last unref
3) when __shard_update_shards_inode_list() is
called it finds that the inode is not in LRU
so it adds it back to the LRU-list
Both these operations complete and call inode_unref(shard-x) which leads to the inode
getting freed and forgotten, even when it is in Shard LRU list. When more inodes are
added to LRU, use-after-free will happen and it leads to undefined behaviors.
Fix:
I see that the inode can be removed from LRU even by the protocol layers like gfapi/gNFS
when LRU limit is reached. So it is better to add a check in shard_forget() to remove itself
from LRU list if it exists.
BUG: 1466037
Change-Id: Ia79c0c5c9d5febc56c41ddb12b5daf03e5281638
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17644
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 1205e877a98f2c2ceee3c6d462d02f69163293e6
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Jun 29 10:52:37 2017 +0530
cluster:dht Fix crash in dht_rename_lock_cbk
Use a local variable to store the call count
in the STACK_WIND for loop. Using frame->local
is dangerous as it could be freed while the loop
is still being processed
Change-Id: Ie65cdcfb7868509b4a83bc2a5b5d6304eabfbc8e
BUG: 1466110
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17645
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Nigel Babu <nigelb@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit a4fe84a291410f7a959a02ca79e55a2ebd923091
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jun 14 13:31:42 2017 +0530
logging: Support for Structured logging format
Wrapper for `gf_log` and `gf_msg` to add support for
structured logging format.
Two new wrappers available `gf_slog` and `gf_smsg`
Example 1: All static details
gf_slog ("cli", GF_LOG_INFO, "Volume Set",
"name=gv1",
"option=changelog.changelog",
"value=on",
NULL);
gf_smsg ("cli", GF_LOG_INFO, 0, MSGID_VOLUME_SET,
"Volume Set",
"name=gv1",
"option=changelog.changelog",
"value=on",
NULL);
Example 2: Using Format chars in key values
gf_slog ("cli", GF_LOG_INFO, "Volume Set",
"name=%s", volume_name,
"option=%s", option_name,
"value=%s", option_value,
NULL);
gf_smsg ("cli", GF_LOG_INFO, 0, MSGID_VOLUME_SET,
"Volume Set",
"name=%s", volume_name,
"option=%s", option_name,
"value=%s", option_value,
NULL);
Formats as,
<EVENT><TAB><KEY1=VALUE1><TAB><KEY2=VALUE2>...
Example:
Volume Set name=gv1 option=changelog.changelog value=on
Updates: #240
Change-Id: I871727be16a39f681d41f363daa0029b8066fb52
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/17543
Reviewed-by: MOHIT AGRAWAL <moagrawa@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 250237771b1eba12ecff2e5a1565dee6d37e5a52
Author: Jeff Darcy <jdarcy@fb.com>
Date: Tue Jun 27 07:21:28 2017 -0700
libglusterfs: fix disable-mempool
Change-Id: I55f707ae1e7c3ad7fc0545f7aa657584cead58f9
BUG: 1465214
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17636
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ji-Hyeon Gim
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 561f33587e520913a9f1337afde6be0ddb607e87
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jun 26 21:12:56 2017 +0530
cluster/dht: Check if fd is opened on dst subvol
If an fd is opened on a file, the file is migrated
and the cached subvol is updated in the inode_ctx
before an fd based fop is sent, the fop is sent to
the dst subvol on which the fd is not opened.
This causes the FOP to fail with EBADF.
Now, every fd based fop will check to see that the fd
has been opened on the dst subvol before winding it down.
Change-Id: Id92ef5eb7a5b5226688e2d2868b15e383f5f240e
BUG: 1465075
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17630
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 93d79a8b6a753eb191cc19eb5af9d9e77cb2c3b6
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Jun 22 17:06:40 2017 +0530
ec: Increase notification in all the cases
Problem:
"gluster v heal <volname> info" is taking
long time to respond when a brick is down.
RCA:
Heal info command does virtual mount.
EC wait for 10 seconds, before sending UP call to upper xlator,
to get notification (DOWN or UP) from all the bricks.
Currently, we are increasing ec->xl_notify_count based on
the current status of the brick. So, if a DOWN event notification
has come and brick is already down, we are not increasing
ec->xl_notify_count in ec_handle_down.
Solution:
Handle DOWN even as notification irrespective of what
is the current status of brick.
Change-Id: I0acac0db7ec7622d4c0584692e88ad52f45a910f
BUG: 1464091
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://review.gluster.org/17606
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit ddc5363bac67072bec15f741d4c15d4409144f81
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jun 27 21:09:49 2017 +0530
glusterd: mark brickinfo to started on successful attach
brickinfo's port & status should be filled up only when attach brick is
successful.
Change-Id: I68b181be37cb94d176f0f4692e8d9dac5493181c
BUG: 1465559
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17640
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit fbb5f035adc4196bd9c404300d3056c54a6bbda3
Author: Ji-Hyeon Gim <potatogim@gluesys.com>
Date: Tue Jun 6 11:18:57 2017 +0900
libglusterfs: build failed with GF_DISABLE_MEMPOOL
When we build GlusterFS with GF_DISBLE_MEMPOOL, it is failed due to macro
condition in mem-pool.c:mem_get().
Change-Id: I03fe804f93d761ea3bfdc3b20f0253a03350a68f
BUG: 1465214
Signed-off-by: Ji-Hyeon Gim <potatogim@potatogim.net>
Reviewed-on: https://review.gluster.org/17633
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: Ji-Hyeon Gim
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 1e512a5883cb82ecf2ec61f1a435a2bf5cc809b1
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Jun 22 16:57:04 2017 +0530
glusterd: brick process fails to restart after gluster pod failure
Problem: In container environment sometime after delete gluster pod
and created new gluster pod brick process doesn't seem
to come up.
Solution: On the basis of logs it seems glusterd is trying to attach
with non glusterfs process.Change the code of function
glusterd_get_sock_from_brick_pid to fetch socketpath from argument
of running brick process.
BUG: 1464072
Change-Id: Ida6af00066341b683bbb4440d7a0d8042581656a
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/17601
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 8f3a748cad868d9d21c5b79ea7f0249bee7a6ff4
Author: Susant Palai <spalai@redhat.com>
Date: Wed Jun 21 17:52:45 2017 +0530
cluster/rebalance: Use GF_XATTR_LIST_NODE_UUIDS_KEY to figure out local subvols.
Afr has introduced a new key GF_XATTR_LIST_NODE_UUIDS_KEY,
through which rebalance will figure out its local subvolumes.(Reference
bugid=1463250)
key: GF_XATTR_NODE_UUID_KEY will continue to serve it's old
purpose of returning the first afr chiild.
test: prove tests/basic/distribute/rebal-all-nodes-migrate.t
Change-Id: I4d602feda2a05b29d2210c712a07a4ac6b8bc112
BUG: 1463648
Signed-off-by: Susant Palai <spalai@redhat.com>
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17595
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 04c6b08c1776532bc7b0dec8041fae8246619564
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Jun 22 15:56:28 2017 +0530
cluster/dht: rebalance gets file count periodically
The rebalance used to get the file count in the beginning
and not update it. This caused estimates to fail
if the number changed during the rebalance.
The rebalance now updates the file count periodically.
Change-Id: I1667ee69e8a1d7d6bc6bc2f060fad7f989d19ed4
BUG: 1464110
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17607
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5545684275db41ce8b5692faf8c188412cd4fbea
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Wed Jun 21 16:37:09 2017 +0530
cluster/ec: Node uuid xattr support update for EC
Problem:
The change in EC to return list of node uuids for
GF_XATTR_NODE_UUID_KEY was causing problems with
geo-rep.
Fix:
This patch will allow to get the single node uuid
as it was doing before with the key
"GF_XATTR_NODE_UUID_KEY", and will also allow to get
the list of node uuids by using a new key
"GF_XATTR_LIST_NODE_UUIDS_KEY". This will solve
the problem with geo-rep and any other features which
were depending on this.
BUG: 1462790
Change-Id: I2d9214a9658d4a41a3d6de08600884d2bda5f3eb
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
Reviewed-on: https://review.gluster.org/17594
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 239bbb57f11fb7672b67f347d37aa2a1b61ef219
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu May 18 14:53:47 2017 +0530
gfapi: Enhance testscript for glfs_xreaddirplus
Enhance the script testing glfs_xreaddirplus functionality
and also measure the performance difference when compared to
using the older method.
Change-Id: I590d07c850994afab0a02eb5dccb8342224aa6b7
BUG: 1442950
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: https://review.gluster.org/17329
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit eaa3fac771db1230973cd5b7a6b91af2bd274ab6
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu May 18 11:22:16 2017 +0530
dht/hardlink : Remove stale linkto file incase of failure
This is a similar issue fixed for rename in https://review.gluster.org/#/c/16016/
For hardlinks, if cached and hashed subvolumes are different, then it will first
create linkto file in hashed using root permission, but actually hardlink creation
fails with EACESS and stale linkto file is never removed.All the followup hardlink
calls with file name will result ESTALE because linktofile creation fails with EEXIST
and follow up lookup on linkto file returns gfid-mismatching(old linkto file) and
finally fails with ESTALE
Steps to produce :
(From link/00.t test from posix-testsuite)
Steps executed in script
* create a file "abc" using root
* change the ownership of file to a non root user
* create hardlink "link" for "abc" using a non root user, it fails with EACESS
* delete "abc"
* create directory "abc" using root
* again try to create hadrlink "link" for "abc" using non root user, fails with ESTALE
Also tried to fix other bugs in dht_linkfile_create_cbk() and posix_lookup.
Thanks Susant for the help in debugging the issue and suggestion for this patch.
Change-Id: I7a5a1899d3fd1fdb13578b37f9d52a084492e35d
BUG: 1452084
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: https://review.gluster.org/17331
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 9fee5b1df0905ed71474d04429c889e425419991
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Thu Jun 15 11:39:56 2017 +0530
doc: Update GlusterFS README
Reorganizing GlusterFS README contents.
BUG: 1461648
Change-Id: I3696e41963c536679d04934930d491f425ffe1ad
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
Reviewed-on: https://review.gluster.org/17550
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 9e42355dce9cb146aef5573d2b2d089790aacd18
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jun 20 06:26:18 2017 -0400
feature/changelog: Fix buffer overflow crash
The buffer used to hold the basename was hard coded
to the size of NAME_MAX(255). It might lead to buffer
overflow crashes when the basename which is sent
is more than NAME_MAX length. Fixed the same.
Change-Id: I6c1cad3ccaeb8c55549b1d3c5f96a198f65ba2b7
BUG: 1463178
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17579
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit bd94ddbc171f8f36f0f365356dbf184ee6ac8fa1
Author: Hendrik Visage <hvjunk@gmail.com>
Date: Fri May 19 12:21:37 2017 +0530
scripts/shared_storage : systemd helper scripts to mount shared storage post reboot
Reported-by: Hendrik Visage <hvjunk@gmail.com>
Change-Id: Ibcff56b00f45c8af54c1ae04974267c2180f5f63
BUG: 1452527
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: https://review.gluster.org/17339
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit ea48f32827852588412540beab434088aeab1a69
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Sun Jun 11 07:33:52 2017 +0530
gfapi : Resolve "." and ".." only for named lookups
The patch https://review.gluster.org/#/c/17177 resolves "." and ".."
to corrosponding inodes and names before sending the request to the
backend server. But this will only work if inode and its parent is
linked properly. Incase of nameless lookup(applications like ganesha)
the inode of parent can be NULL(only gfid is send). So this patch will
resolve "." and ".." only if proper parent is available
Change-Id: I4c50258b0d896dabf000a547ab180b57df308a0b
BUG: 1460514
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: https://review.gluster.org/17502
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit cb586c07c7c76dccbad567f1677ddffddba796b6
Author: karthik-us <ksubrahm@redhat.com>
Date: Mon Jun 19 19:54:36 2017 +0530
cluster/afr: Returning single and list of node uuids from AFR
Problem:
The change in afr to return list of node uuids was causing problems
with geo-rep.
Fix:
This patch will allow to get the single node uuid as it was doing
before with the key "GF_XATTR_NODE_UUID_KEY", and will also allow
to get the list of node uuids by using a new key
"GF_XATTR_LIST_NODE_UUIDS_KEY". This will solve the problem with
geo-rep and any other feature which were depending on this.
Change-Id: I09885dac6dfca127be94b708470c8c2941356f9a
BUG: 1462790
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: https://review.gluster.org/17576
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 5cb865cf9480fa0f79f7edf13a66935d3c172a16
Author: AnkitRaj <anraj@redhat.com>
Date: Mon Jun 5 14:11:43 2017 +0530
dht: passing the errno as an argument to gf_msg
There are many calls in gf_msg where errno
is needed to pass as an argument instead of
strerrno(error)
Change-Id: I15048a5e0b41f9752a2023afe8470eca6f2cd383
Bug: 1454701
Signed-off-by: AnkitRaj <anraj@redhat.com>
Reviewed-on: https://review.gluster.org/17464
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: MOHIT AGRAWAL <moagrawa@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Karthik U S <ksubrahm@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit bf3e9688f8314b7cad133ad4e787b8ff912657c2
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jun 19 11:50:28 2017 +0530
cluster/dht: Additional checks for rebalance estimates
The rebalance estimates calculation was not handling
calculations correctly when no files had been processed,
i.e., when rate_lookedup was 0.
Now, the estimated time is set to 0 in such scenarios as
there is no way for rebalance to figure out how long the
process will take to complete without knowing the rate at
which the files are being processed.
Change-Id: I7b6378e297e1ba139852bcb2239adf2477336b5b
BUG: 1457985
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17564
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 389b446ee9d8938bfd5ab207fa64e80ff01de04a
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jun 15 18:09:36 2017 +0530
geo-rep: Structured log support
Changed all log messages to structured log format
Change-Id: Idae25f8b4ad0bbae38f4362cbda7bbf51ce7607b
Updates: #240
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/17551
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 652d8bf77a69b4df053590f4c906c177ef506b5f
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Sun Jun 18 23:10:57 2017 +0530
glusterd.service (systemd), shows "Active failed" when gd in stop state
While doing cleanupandexit glusterd was handling the signal SIGTERM which
is clean exit but systemd treats it as failure being a non-zero value.
With this fix dependency "SuccessExitStatus " has been added
in glusterd.service which takes care of service stop properly.
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Change-Id: Ie5216722632a245f787fd69bfbbf8d0f0068bccb
BUG: 1462200
Reviewed-on: https://review.gluster.org/17559
Tested-by: Gaurav Yadav <gyadav@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit f21d6af6f0c8f350a3f72161ee342c753c6b417a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Jun 19 13:45:55 2017 +0530
posix: Revert modifying op_errno in __posix_fd_ctx_get
https://review.gluster.org/#/c/17414/ converted ENOENT to EBADFD because
ENOENT is not a valid error for fd based operations, but this apparently
breaks dht rebalance behaviour (see comments in the backport 17517. So
reverting that part of the change.
Change-Id: Idcf5c65a47b096a3766cf7f20ca938d988572052
BUG: 1456582
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17565
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit eb31f156eb35cab64505d452d6f5a89d8d4211c5
Author: Milind Changire <mchangir@redhat.com>
Date: Fri Jun 16 18:39:08 2017 +0530
tools/glusterfind: initialize variable 'end'
Problem:
syntax error due to uninitialized variable 'end'
Solution:
set end = -1
Change-Id: Ia8b500e9dd5304d0832e5f594abca0b5b2ab357e
BUG: 1462241
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/17557
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit aad85c3ce2f48b853cea784099e82c7fea82ce09
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jun 12 22:06:18 2017 +0530
cluster/afr: Implement quorum for lk fop
Problem:
At the moment when we have replica 3 or arbiter setup, even when
lk succeeds on just one brick we give success to application which
is wrong
Fix:
Consider quorum-number of successes as success when quorum is enabled.
BUG: 1461792
Change-Id: I5789e6eb5defb68f8a0eb9cd594d316f5cdebaea
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17524
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit dd35054dd3e72ff4ec80a8a5d313aef92fad244f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jun 15 15:36:07 2017 +0530
index: Do not proceed with init if brick is not mounted
..or else when a volume start force is given, we end up creating
/brick-path/.glusterfs/indices folder and various subdirs under it and
eventually starting the brick process.
As a part of this patch, glusterd_get_index_basepath() is added in
glusterd, who will then use it to create the basepath during
volume-create, add-brick, replace-brick and reset-brick. It also uses this
function to set the 'index-base' xlator option for the index translator.
Change-Id: Id018cf3cb6f1e2e35b5c4cf438d1e939025cb0fc
BUG: 1457202
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17426
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 0c4f3b82d9294f5b45605417ee993ae27fabb19d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jun 13 23:35:40 2017 +0530
cluster/ec: lk shouldn't be a transaction
Problem:
When application sends a blocking lock, the lk fop actually waits under
inodelk. This can lead to a dead-lock.
1) Let's say app-1 takes exculsive-fcntl-lock on the file
2) app-2 attempts an exclusive-fcntl-lock on the file which goes to blocking
stage note: app-2 is blocked inside transaction which holds an inode-lock
3) app-1 tries to perform write which needs inode-lock so it gets blocked on
app-2 to unlock inodelk and app-2 is blocked on app-1 to unlock fcntl-lock
Fix:
Correct way to fix this issue and make fcntl locks perform well would be to
introduce
2-phase locking for fcntl lock:
1) Implement a try-lock phase where locks xlator will not merge lk call with
existing calls until a commit-lock phase.
2) If in try-lock phase we get quorum number of success without any EAGAIN
error, then send a commit-lock which will merge locks.
3) In case there are any errors, unlock should just delete the lock-object
which was tried earlier and shouldn't touch the committed locks.
Unfortunately this is a sizeable feature and need to be thought through for any
corner cases. Until then remove transaction from lk call.
BUG: 1455049
Change-Id: I18a782903ba0eb43f1e6526fb0cf8c626c460159
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17542
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit bcca8aef824cac735a9b4be28a0f0ee338c0b862
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jun 15 08:31:06 2017 -0400
feature/bitrot: Fix ondemand scrub
The flag which keeps tracks of whether the scrub
frequency is changed from previous value should
not be considered for on-demand scrubbing. It
should be considered only for 'scrub-frequency'
where it should not be re-scheduled if it is
set to same value again. But in case ondemand
scrub, it should start the scrub immediately
no matter what the scrub-frequency.
Reproducer:
1. Enable bitrot
2. Set scrub-throttle
3. Set ondemand scrub
Make sure glusterd is not restarted while doing
below steps
Change-Id: Ice5feaece7fff1579fb009d1a59d2b8292e23e0b
BUG: 1461845
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17552
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit d13151679943b82957f5062ec7288e6f2a7c26f1
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri May 26 15:56:59 2017 +0530
debug/io-stats: Provide option to select stats output format
... as opposed to hardcoding it to "json" always.
Change-Id: I5e79473a514373145ad764f24bb6219a6983a4c6
BUG: 1458197
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17451
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 21c75f624bf5273e57a2b7b560e731fb8373dd59
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jun 12 08:18:30 2017 -0400
.testignore: if a file doesn't change any code/behavior, add it here
So, the regression tests won't run if the changes in the patch is for
only files belonging to this file. Helps in reducing the load on overall
regression framework.
Credits: Nigel Babu <nigelb@redhat.com>
Change-Id: Icaa351b19cdcbe5af9a64c03b90f530aab297ee1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17522
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit eb8b3c7d494b0fb9dbc63bc7b07bd50436179c08
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jun 15 11:31:39 2017 +0530
glusterd: fix crash on statedump when no volumes are started
pmap object is created when glusterd allocates a port for the very first
time, however before that if someone tries to take statedump glusterd
will crash.
Solution : Add a NULL check before accessing pmap reference.
Change-Id: I206b02e07a4717e68af2c6bf05fac55119353de8
BUG: 1461655
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17549
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d347fa93509edd6d680fbee02c9ecb69cc80f3af
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Jun 13 14:40:09 2017 +0530
geo-rep: Added metrics related to Sync Time
In Geo-rep, Sync jobs can be configured using, `config sync-jobs 3`. This
patch adds following information related to the sync job(Rsync/Tarssh)
Example output:
[2017-06-13 09:09:32.532181] I [master(/bricks/b1):1713:syncjob] Syncer: \
Sync Time Taken (Job:2 Files:5484 ReturnCode:0): 4.8774 secs
Change-Id: Ifceb96d4b8d14e00fd1290c0aeff60d64b4d7f37
BUG: 1455179
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/17531
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 2b147ec6321f283eaad06a1257a50dcd97d8080f
Author: Michael Adam <obnox@samba.org>
Date: Tue Jun 13 10:06:57 2017 +0200
glusterd: fix quorum calculation if percentage is not specified correctly
There was an extra "ratio = _gf_true".
- In case the ratio was specified correctly
in the volfile, this is redundant.
- In case the ratio was specified, but not parseable
into a precentage, this is wrong and would
lead to a quorum count of 0 instead of falling
back to the default of 50% + 1.
This patch removes the extra setting of "ratio".
Change-Id: I2bd57ebf1b8989e905481a2b6285a1f422942f72
BUG: 1461129
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: https://review.gluster.org/17538
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 5c63ee9ff7a8af8a379c27e72560e567fb46e2e2
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Jun 11 15:43:58 2017 -0400
dht: reduce duplicate code in tier migrate
Updates #234
Change-Id: I016f6d4f1e5ad2ea56a611c1bffbd189f10650db
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17525
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit b506e9a3b6c1d6a9aabdf7560d24bc4ba35ea0f7
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Jun 12 11:17:01 2017 +0530
Revert "glusterd: disallow rebalance & remove-brick on a sharded volume"
This reverts commit 8375b3d70d5c6268c6770b42a18b2e1bc09e411e.
Now that some of the users have confirmed rebalance works fine without
causing corruption of VMs, time to revert the CLI restriction.
Change-Id: I45493fcbb1f25fd0fff27b2b3526c42642ccb464
BUG: 1460585
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17506
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6cb01d5a4c2733dc2df0e647a1a00dab3c6e0cd3
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Jun 12 11:05:27 2017 +0530
geo-rep: Fix string format issue caused due to #17489
With Patch #17489, values from Geo-rep config always represented
as Unicode string, which is not compatible with rest of the code.
Changed the format with this patch to fix the issue.
BUG: 1459620
Change-Id: I935fca0d24f02e90757f688f92ef73fad9f9b8e1
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/17503
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit e1e112196f71cb4abb1bb3dea2f0186305c53493
Author: Poornima G <pgurusid@redhat.com>
Date: Fri May 26 15:45:57 2017 +0530
nl-cache: Fix a possible crash and stale cache
Issue1:
Consider the followinf sequence of operations:
...
nlc_ctx = nlc_ctx_get (inode i1)
....... -> nlc_clear_cache (i1) gets called as a part of nlc_invalidate
or any other callers
...
GF_FREE (ii nlc_ctx)
LOCK (nlc_ctx->lock); -> This will result in crash as the ctx
got freed in nlc_clear_cache.
Issue2:
lookup on dir1/file1 result in ENOENT
add cache to dir1 at time T1
....
CHILD_DOWN at T2
lookup on dir1/file2 result in ENOENT
add cache to dir1, but the cache time is still T1
lookup on dir1/file2 - should have been served from cache
but the cache time is T1 < T2, hence
cache is considered as invalid.
So, after CHILD_DOWN the right thing would be to clear the cache
and restart caching on that inode.
Solution:
Do not free nlc_ctx in nlc_clear_cache, but only in inode_forget()
The fix for both issue1 and 2 is interleaved hence sending it as
single patch.
Change-Id: I83d8ed36c049a93567c6d7e63d045dc14ccbb397
BUG: 1458539
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17453
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0ac0b9870e732cf70e653ab13df9de79f1a17397
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jun 12 15:09:10 2017 +0530
ec: fix ec-data-heal.t failure
With brick mux enabled, this test was constantly failing. Further it was
found that the the test does a series of killing a particular brick and
bringing it up in cmdline where as just starting the volume with force
would suffice.
Change-Id: Iee491d0777eaa28dca5c78f92d4b400fcc897fd2
BUG: 1460638
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://review.gluster.org/17508
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 096d7b99df714853bd044c2618e2bc0e480b9479
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Jun 12 10:59:04 2017 +0530
readdir-ahead: Fix duplicate listing and cache size calculation
Issue:
If a opendir is followed by a closedir without readdir, though
the prefetched entries were freed, the freed size was not accounted
in priv->rda_cache_size. Thus the cache limit will exceed if there
are multiple opendir followed by closedir.
Fix:
Fix the pric->rda_cache_size calculation. Also have removed the
inode_ctx_size. Each perf xlator has its own cache limit that
it works with. Also the inode_ctx size can change, if a forget/
invalidate or any other factor triggers the inode_ctx size.
Change-Id: I9707ec558076ce046e58a55989ec9513c70ea029
BUG: 1431908
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17504
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit e762a2f212a85c4556876587c9db554a2d545030
Author: Milind Changire <mchangir@redhat.com>
Date: Tue Jun 6 12:27:28 2017 +0530
tools/glusterfind: add --end-time option
Add optional --end-time argument to be used with --since-time
when using the "query" command.
"start" and "end" times are passed in the command-line to
changelog.py only if --full has not been specified on command-line.
-1 is passed to changelog.py as end time if user has not supplied
--end-time on command-line.
brickfind.py:
Remove unused "start" command-line argument.
Also:
Minor indentation changes to keep flake8-2.7 happy.
Change-Id: I063ef5459916f711503881ade5c4fc32374edad0
BUG: 1453151
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/17439
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 51763ff6bd264d2754c315fb7d2f24390392862b
Author: Milind Changire <mchangir@redhat.com>
Date: Tue Jun 6 23:43:54 2017 +0530
tools/glusterfind: add --field-separator option
Problem:
Default field separator is a space character.
This gets in the way if the file name itself has embedded spaces.
Solution:
Add --field-separator option to "pre" and "query" commands.
The field separator string will be used to separate strings in the
output lines that get written to the output file.
eg.
old output:
NEW file1.txt
RENAME file2 Copy.txt file3.txt
with --field-separator as "==="
new output:
NEW===file1.txt
RENAME===file2 Copy.txt===file3.txt
Change-Id: I71e878fed58ba1113d97044ac9f6404ee66227c7
BUG: 1453151
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/17481
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 00b8c47c627ba80a130d256b91b417bd33cbbdd6
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Jun 8 11:06:32 2017 +0530
md-cache: Fix the dump of stat inode in .meta and statedump
Change-Id: If61ed5e4462e98d18a1370734a0bcee1ed94d82d
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17491
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 73c4e9bf14f27157143ea247ed98213d60d7e602
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Jun 9 11:31:19 2017 +0530
nl-cache: add group volume set option for ease of use
Change-Id: Id03643a9598da53051a01ca09e1d2a62bc195ab6
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17495
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 002910315cad68bdfb3b584535999b92a3a911b7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Jun 9 17:10:00 2017 +0530
glusterd: log stale rpc disconnects occasionally
There might be situations where if a brick process is killed through
SIGKILL (not SIGTERM) when brick mux is enabled glusterd will continue to
receive disconnect events from the stale rpc which might flood the
glusterd log. Fix is to use GF_LOG_OCCASIONALLY.
Change-Id: I95a10c8be2346614e0a3458f98d9f99aab34800a
BUG: 1460225
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17499
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit f6135a4eb2f7ff7db77a0d2f6a34ef14dfba3d9d
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Jun 8 13:04:42 2017 +0530
glusterfsd: Deletion of brick dir throw emerg msgs after stop volume
Problem: Deletion of brick directories throw emerg messages after stop
volume while brick mux is enabled.
Solution: Modify the posix health check monitor thread code to
handled correctly.
BUG: 1459781
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: I2d22a84f9a98b0da261e5fb7850ba1368f3601d7
Reviewed-on: https://review.gluster.org/17492
Tested-by: MOHIT AGRAWAL <moagrawa@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 5a0df5c04cfbed459959d7a7ed1bf90aa9d24c59
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Jun 2 16:28:40 2017 +0530
gfapi: change root lookup from nameless to named lookup
Problem:
During component resolve we do lookup on root based on
root gfid. If we are doing nameless lookup, then md-cache
won't be able to serve those lookup.
Solution:
With this patch, we covert nameless lookup to named lookup
on root.
Credits: Poornima G <pgurusid@redhat.com>
Change-Id: Ie64141936fd294d8969c39e3bd4dbc73ee375c6b
BUG: 1458768
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17465
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 43ef57667e19ce50caa455b7fae25ebd79ab7834
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Jun 2 10:05:33 2017 +0530
upcall: Update the access time in missing cases
Issue: In fops like rename, link, unlink etc, the parent
dirrs' client access time was not being updated. And in fops like
create, link, symlink etc. the new file/dirs' client access time was
not updated.
Solution: Update the client access time for both parent and new entry.
Change-Id: Id9f63583216ae857f6251dca15797ac66fa85430
BUG: 1458127
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17450
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 77303a11ae9634782bc83ace8d9fe4df625d9e00
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jun 8 22:19:17 2017 +0530
posix-acl: Whitelist virtual ACL xattrs
Similar to system.posix_acl_* xattrs, all users should get
permission to be able to read glusterfs.posix.acl* xattrs too.
Change-Id: I1fc2b67c8a12113910e4ec57cd114e4baefe0d38
BUG: 1459971
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: https://review.gluster.org/17493
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 74ea9414581e18f7219f095c74ac99596f6635cb
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue May 30 18:01:26 2017 +0530
debug/trace: Implement seek fop
Change-Id: Idd1b92201348a76a6145b38799a3a46cab730540
BUG: 1458193
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17437
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1c7a792d170b4ca086d95545e23a0942cec960af
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon May 29 16:00:24 2017 +0530
protocol/server: make listen backlog value as configurable
problem:
When we call listen from protocol/server, we are giving a
hard coded valie of 10 if it is not manually given.
With multiplexing, especially when glusterd restarts all
clients may try to connect to the server at a time.
Which will result in overflowing the queue, and kernel
will complain about the errors.
Solution:
This patch will introduce a volume set command to make backlog
value as a configurable. This patch also changes the default
values for backlog from 10 to 128. This changes is only applicable
for sockets listening from protocol.
Example:
gluster volume set <volname> transport.listen-backlog 1024
Note: 1 Brick has to be restarted to get this value in effect
2 This changes won't be reflected in glusterd, or other
xlators which calls listen. If you need, you have to
add this option to the volfile.
Change-Id: I0c5a2bbf28b5db612f9979e7560e05dd82b41477
BUG: 1456405
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17411
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit f2300733c8747b123cf7e12c90b84b70997dd2cb
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Jun 6 17:59:59 2017 +0530
geo-rep: Fix ConfigInterface Template issue
ConfigParser uses string Template to substitute the dynamic values
for config. For some of the configurations, Geo-rep worker will
not restart. Due to this conf object may have non string values.
If val is not string in Template(val), then it fails with
"TypeError: expected string or buffer"
BUG: 1459620
Change-Id: I25b8bbc1df42f6f29e9563a55b3e27a228321c44
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/17489
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 44d25549c8a404d312d2d2d32f26d0f1ebd583ed
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue Jun 6 13:44:06 2017 +0530
glusterfsd: Sometime brick process is crashed after enable brick mux
Problem: glusterfsd is getting Segfault while running bug-1432542-mpx-restart-crash.t
in a loop in while brick mux is enabled.
Solution: Change the index_worker code as well as notify code in index.c
to cleanup index_worker thread appropriately.
BUG: 1459402
Change-Id: Id036664dc34309dd3f6e54746fc2724182cb074f
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/17471
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 80f459d321b2a246de78fbeccba8f24f07e61bbc
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jun 6 17:45:51 2017 +0530
glusterd: fix glusterd crash from glusterd_op_ac_rcvd_brick_op_acc
In out label, before checking ev_ctx->rsp_dict we should first check if
ev_ctx is not NULL
Change-Id: I28f4f1ee9070617a0e6a23a43af8c5756f96a47e
BUG: 1452956
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17478
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
commit db8cbe690e8c02db9f4c75c06aeb2f59e29830c0
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Jun 1 22:13:41 2017 +0530
cluster/dht: Include dirs in rebalance estimates
Empty directories were not being considered while
calculating rebalance estimates leading to negative
time-left values being displayed as part of the
rebalance status.
Change-Id: I48d41d702e72db30af10e6b87b628baa605afa98
BUG: 1457985
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17448
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 6da711b00ddce6deb6c410fcd5a2767ac946ba8b
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Apr 3 12:46:29 2017 +0530
cluster/ec: Update xattr and heal size properly
Problem-1 : Recursive healing of same file is happening
when IO is going on even after data heal completes.
Solution:
RCA: At the end of the write, when ec_update_size_version
gets called, we send it only on good bricks and not
on healing brick. Due to this, xattr on healing brick
will always remain out of sync and when the background
heal check source and sink, it finds this brick to be
healed and start healing from scratch. That involve
ftruncate and writing all of the data again.
To solve this, send xattrop on all the good bricks as
well as healing bricks.
Problem-2: The above fix exposes the data corruption
during heal. If the write on a file is going on and
heal finishes, we find that the file gets corrupted.
RCA:
The real problem happens in ec_rebuild_data(). Here we receive the
'size' argument which contains the real file size at the time of
starting self-heal and it's assigned to heal->total_size.
After that, a sequence of calls to ec_sync_heal_block() are done. Each
call ends up calling ec_manager_heal_block(), which does the actual work
of healing a block.
First a lock on the inode is taken in state EC_STATE_INIT using
ec_heal_inodelk(). When the lock is acquired, ec_heal_lock_cbk() is
called. This function calls ec_set_inode_size() to store the real size
of the inode (it uses heal->total_size).
The next step is to read the block to be healed. This is done using a
regular ec_readv(). One of the things this call does is to trim the
returned size if the file is smaller than the requested size.
In our case, when we read the last block of a file whose size was = 512
mod 1024 at the time of starting self-heal, ec_readv() will return only
the first 512 bytes, not the whole 1024 bytes.
This isn't a problem since the following ec_writev() sent from the heal
code only attempts to write the amount of data read, so it shouldn't
modify the remaining 512 bytes.
However ec_writev() also checks the file size. If we are writing the
last block of the file (determined by the size stored on the inode that
we have set to heal->total_size), any data beyond the (imposed) end of
file will be cleared with 0's. This causes the 512 bytes after the
heal->total_size to be cleared. Since the file was written after heal
started, the these bytes contained data, so the block written to the
damaged brick will be incorrect.
Solution:
Align heal->total_size to a multiple of the stripe size.
Thanks "Xavier Hernandez" <xhernandez@datalab.es>
to find out the root cause and to fix the issue.
Change-Id: I6c9f37b3ff9dd7f5dc1858ad6f9845c05b4e204e
BUG: 1428673
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://review.gluster.org/16985
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 68c042c8235977d93ca49506986e779ae34082ef
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun Jun 4 20:19:19 2017 +0530
cli: add 'all' option in gluster v get cli usage
Change-Id: If216b13b7f9072f875eb2c5019d3b50b8bf3313e
BUG: 1458582
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17460
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
commit 32c26777d4ee3d62dcbce5d74f91891cd3bebbed
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jun 1 22:05:51 2017 +0530
glusterd: fix brick start race
This commit tries to handle a race where we might end up trying to spawn
the brick process twice with two different set of ports resulting into
glusterd portmapper having the same brick entry in two different ports
which will result into clients to fail connect to bricks because of
incorrect ports been communicated back by glusterd.
In glusterd_brick_start () checking brickinfo->status flag to identify
whether a brick has been started by glusterd or not is not sufficient as
there might be cases where while glusterd restarts
glusterd_restart_bricks () will be called through glusterd_spawn_daemons
() in synctask and immediately glusterd_do_volume_quorum_action () with
server-side-quorum set to on will again try to start the brick and in
case if the RPC_CLNT_CONNECT event for the same brick hasn't been processed by
glusterd by that time, brickinfo->status will still be marked as
GF_BRICK_STOPPED resulting into a reattempt to start the brick with a different
port and that would result portmap go for a toss and resulting clients to fetch
incorrect port.
Fix would be to introduce another enum value called GF_BRICK_STARTING in
brickinfo->status which will be set when a brick start is attempted by
glusterd and will be set to started through RPC_CLNT_CONNECT event. For
brick multiplexing, on attach brick request given the brickinfo->status
flag is marked to started directly this value will not have any effect.
Also this patch removes started_here flag as it looks to be redundant as
brickinfo->status.
Change-Id: I9dda1a9a531b67734a6e8c7619677867b520dcb2
BUG: 1457981
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17447
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 1b73db553be795c3206c4fa7002aed1c2b85ca3c
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue May 30 14:27:16 2017 +0530
core: add more information on dictionary usage
when you take the 'statedump', it shows the output like below
-----
[dict]
max-number-of-dict-pairs=13
total-pairs-used=41613
total-dict-used=12629
average-pairs-per-dict=3
------
Updates #220
Change-Id: I71a7eda3a3cd23edf4483234f22f983923bbb081
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/4035
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit ab45756d8695bee7d8eb50a6cf5204ee41915a51
Author: AnkitRaj <anraj@redhat.com>
Date: Mon May 29 14:12:21 2017 +0530
dht: for many operation directory/file path is (null) in brick log
There are few operations on mount point which results to
(null) error for path on brick log. This should be corrected with
correct path.
Change-Id: I5acf2ead5196594c76a2e526aafbfc128ece433e
BUG: 1456361
Signed-off-by: ankitraj <anraj@redhat.com>
Reviewed-on: https://review.gluster.org/17407
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: ankitraj
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 53257e369a04223031c11ff6b68a96c4dd631cf6
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jun 1 14:20:03 2017 +0530
afr: update errno check in afr_inode_refresh_do
Addresses review comment in https://review.gluster.org/#/c/17413
Change-Id: Ic247729e5e92a5bb0148543764e0b30790444004
BUG: 1456582
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17436
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 50b3f698bf1c93a60af8cb0ce9fd94f586594fda
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu May 25 07:28:07 2017 -0400
geo-rep: Fix meta data sync on symlink
chmod doesn't support 'no dereference' option.
It always deference the symlink. But 'chown'
does support metadata changes on symlink itself,
which was not taken care while syncing. This
patch fixes the same.
Change-Id: Ic9985f4e39d15b5a9deb379841bcfb2c263d3e6c
BUG: 1455559
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17389
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 9f47dbc3da5772d3388bbb33073e549db7e5c8e8
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jun 1 07:05:42 2017 -0400
extras/hookscripts: non-portable shell syntax
use of "function" is not portable to other shells
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
Change-Id: I13a0482b387cc3b7a7a57df424e673850603da37
BUG: 1457812
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17443
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 629eef6e8a611577e019eabc6de39eb2af14323f
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jun 1 06:56:22 2017 -0400
core: fix spelling errors
fixes for various minor spelling errors and typos
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
Change-Id: Ic1be36f82e3d822bbdc9559878bd79520fc0fcd5
BUG: 1457808
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17442
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit b673fd0a15dadb1b84dfbf2c89b9cb697ef38e5a
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue May 30 17:48:41 2017 +0530
dict: add a simple hash comparision of keys before strcmp for performance
Updates #220
Change-Id: I03b1d2fac2dfcdd21bdf4e4fff19d49425699931
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/6450
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit fdf5ea9084a2646c9d6d8a1b38765950ca5d022e
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Tue May 30 18:09:01 2017 +0530
glusterd: Fix regression wrt add-brick on replica count change
tests/bugs/glusterd/bug-1406411-fail-add-brick-on-replica-count-change.t
was failing on centos machines with brick multiplexing enabled.
This is because detaching individual bricks manually from the
backend like it is done in the regression test framework by
'kill_brick', fails to send a RPC_CLNT_DISCONNECT to glusterd when
multiplexing is enabled. This causes the add-brick command to not
fail when one of the bricks are killed using kill_brick in the
regression test framework. To fix this, set the brick status to
GF_BRICK_STOPPED on the glusterd end during portmap signout. This
commit also sets the brick status in glusterd_brick_stop() function
so that the brick status is correctly set to 'stopped' even when the
function is called independently for individual bricks.
Change-Id: I4d6f7b579069d0cfa53cb2b0cff78876e1f31594
BUG: 1456898
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17422
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d3c0f966337b0bb9119ea5b3e724070e669322c2
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu May 25 21:43:42 2017 +0530
glusterfs: Not able to mount running volume after enable brick mux and stopped any volume
Problem: After enabled brick mux if any volume has down and then try ot run mount
with running volume , mount command is hung.
Solution: After enable brick mux server has shared one data structure server_conf
for all associated subvolumes.After down any subvolume in some
ungraceful manner (remove brick directory) posix xlator sends
GF_EVENT_CHILD_DOWN event to parent xlatros and server notify
updates the child_up to false in server_conf.When client is trying
to communicate with server through mount it checks conf->child_up
and it is FALSE so it throws message "translator are not yet ready".
From this patch updated structure server_conf to save child_up status
for xlator wise. Another improtant correction from this patch is
cleanup threads from server side xlators after stop the volume.
BUG: 1453977
Change-Id: Ic54da3f01881b7c9429ce92cc569236eb1d43e0d
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/17356
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit eddc888a0def11b8b6b1fe1e194630e88a7627f1
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon May 29 21:38:14 2017 +0530
posix: use the correct op_errno
Problem:
If readdir/fstat was performed on a directory that was removed,
posix_fd_ctx_get() fails with ENOENT but we incorrectly use the ret
value (-1 in this case) as op_errno, logging "Operation not permitted"
messages in the brick logs. Also in case of fstat, the -1 op_errno was
also propagated to the client via stack unwind, causing the message to
appear in protocol/client logs as well.
Fix:
Use the right op_errno in readdir, fstat and writev. Also, if
posix_fd_ctx_get() failed with ENOENT, convert it into EBADF because
ENOENT is not a valid error for an fd operation.
Change-Id: Ie43c0789d5040ec73b7cf885d015a183b8c64d70
BUG: 1456582
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17414
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit af28700e929efdbccf29d1e5c01adba0d09c428d
Author: Sakshi <sabansal@redhat.com>
Date: Mon Jan 23 12:11:49 2017 +0530
cluster/dht: Make optimal usage of buffer provided with readdir(p)
dht_readdirp must unwind with list of entries only after
the entire buffer requested by kernel is filled to avoid
extra syscalls occuring when returning partially filled
buffer. Also wind readdir call to next subvol on reaching
EOD for directory on that subvol to avoid extra network call.
Change-Id: If2e1a2722f813d95457c7542bff25fef56c7a041
BUG: 1356453
Signed-off-by: Sakshi <sabansal@redhat.com>
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: https://review.gluster.org/12271
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
commit 98b24d7e1b33c23e82bd00327edc7f43809416d2
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue May 30 15:50:25 2017 +0530
tier: port value missing on cli parsing
problem: as tier didn't have a port all the values regarding
the port were removed. but the cli needs a port value to parse and
print the status.
fix: fake the port value with a zero.
Change-Id: I6491f6c441f7cfddbdaa724fcbe7c30e348aa765
BUG: 1452006
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/17419
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 62ec0e359fbee351ad8a473d66b11fac511e4f7d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon May 29 21:56:12 2017 +0530
afr: add errno to afr_inode_refresh_done()
Problem:
When parellel `rm -rf`s were being done from cifs clients, opendir might
fail on some replicas with ENOENT. DHT ignores partial opendir failures
in dht_fd_cbk() and winds readdirs on those replicas. Afr inode refresh
(as a part of readdirp read_txn) sees in its fd context that the state
of the fds is *not* AFR_FD_OPENED and bails out to
afr_inode_refresh_done() without doing a refresh. When this happens, the
errno is set as EIO due to lack of readable subvols, logging split-brain
messages in the logs.
Fix:
Introduce an errno argument to afr_inode_refresh_do() to bail out with
the right error value when inode refresh is not performed.
Change-Id: I075707fbb73fd93a923b77b923a96aac79e847f9
BUG: 1456582
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17413
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit c9e1652554698f1b2bb304386f33235026ac5cc1
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Apr 18 12:40:36 2017 +0530
fuse-bridge: cleanup first_lookup()
use syncop_lookup instead of synchronising stack_wind/unwind again.
Updates #175
Change-Id: Iad4a181d8601235a999039979bfb7ec688675520
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17075
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 76cb10291410e827908cc56d60475d7d6e141297
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon May 29 15:21:39 2017 +0530
perf/ioc: Fix race causing crash when accessing freed page
ioc_inode_wakeup does not lock the ioc_inode for the duration
of the operation, leaving a window where ioc_prune could find
a NULL waitq and hence free the page which ioc_inode_wakeup later
tries to access.
Thanks to Mohit for the analysis.
credit: moagrawa@redhat.com
Change-Id: I54b064857e2694826d0c03b23f8014e3984a3330
BUG: 1456385
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17410
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 82f44b59defbc92c2dab014036febca7e68d30b7
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue May 30 10:18:04 2017 +0530
nl-cache: Remove null check validation for frame->local in lookup cbk
For nameless lookups, nl-cache does not init frame local, so the cbk
throws up messages like these flooding the logs, especially whenenver
gfid lookup on '/' is done (i.e. loc.path="/" and loc.gfid=1).
[2017-05-30 04:35:31.628443] E [nl-cache.c:201:nlc_lookup_cbk]
(-->/usr/lib64/glusterfs/3.8.4/xlator/performance/io-cache.so(+0x3d81)
[0x7f0883005d81]
-->/usr/lib64/glusterfs/3.8.4/xlator/performance/quick-read.so(+0x3127)
[0x7f0882dfb127]
-->/usr/lib64/glusterfs/3.8.4/xlator/performance/nl-cache.so(+0x4cd3)
[0x7f08829e0cd3] ) 0-distrep-nl-cache: invalid argument: local [Invalid
argument]
Fixed it.
Change-Id: I21cb44a9d2a324617e43f46fed83c9a0942d3a0b
BUG: 1456653
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17417
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 64e23842f831948b551c74742852e7651b7878c7
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue May 30 13:10:50 2017 +0530
scripts: prevent a script warning if rfc.sh does not find a backport
When running ./rfc.sh on a branch to post release notes (not a backport
from master), then the following script warning is displayed:
./rfc.sh: line 97: [: =: unary operator expected
In case the used variables are not set, they are not handled as empty
strings. Placing the variables inside "${qoutes}" prevents this warning.
BUG: 1428047
Change-Id: Ie171d6f66b47401d6ea4e78aa3ed2bd0c6fce9ce
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17418
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit debf705a85735060aee28a378973cc0c6406d0d3
Author: Susant Palai <spalai@redhat.com>
Date: Tue Apr 25 18:32:45 2017 +0530
cluster/dht: fix on demand migration files from client
On demand migration of files i.e. migration done by clients
triggered by a setfattr was broken.
Dependency on defrag led to crash when migration was triggered from
client.
Note: This functionality is not available for tiered volumes. Migration
from tier served client will fail with ENOTSUP.
usage (But refer to the steps mentioned below to avoid any issues) :
setfattr -n "trusted.distribute.migrate-data" -v "1" <filename>
The purpose of fixing the on-demand client migration was to give a
workaround where the user has lots of empty directories compared to
files and want to do a remove-brick process.
Here are the steps to trigger file migration for remove-brick process from
client. (This is highly recommended to follow below steps as is)
Let's say it is a replica volume and user want to remove a replica pair
named brick1 and brick2. (Make sure healing is completed before you run
these steps)
Step-1: Start remove-brick process
- gluster v remove-brick <volname> brick1 brick2 start
Step-2: Kill the rebalance daemon
- ps aux | grep glusterfs | grep rebalance\/ | awk '{print $2}' | xargs kill
Step-3: Do a fresh mount as mentioned here
- glusterfs -s ${localhostname} --volfile-id rebalance/$volume-name /tmp/mount/point
Step-4: Go to one of the bricks (among brick1 and brick2)
- cd <brick1 path>
Step-5: Run the following command.
- find . -not \( -path ./.glusterfs -prune \) -type f -not -perm 01000 -exec bash -c 'setfattr -n "distribute.fix.layout" -v "1" ${mountpoint}/$(dirname '{}')' \; -exec setfattr -n "trusted.distribute.migrate-data" -v "1" ${mountpoint}/'{}' \;
This command will ignore the linkto files and empty directories. Do a fix-layout of
the parent directory. And trigger a migration operation on the files.
Step-6: Once this process is completed do "remove-brick force"
- gluster v remove-brick <volname> brick1 brick2 force
Note: Use the above script only when there are large number of empty directories.
Since the script does a crawl on the brick side directly and avoids directories those
are empty, the time spent on fixing layout on those directories are eliminated(even if the script
does not do fix-layout on empty directories, post remove-brick a fresh layout will be built
for the directory, hence not affecting application continuity).
Detailing the expectation for hardlink migartion with this patch:
Hardlink is migrated only for remove-brick process. It is highly essential
to have a new mount(step-3) for the hardlink migration to happen. Why?:
setfattr operation is an inode based operation. Since, we are doing setfattr from
fuse mount here, inode_path will try to build path from the linked dentries to the inode.
For a file without hardlinks the path construction will be correct. But for hardlinks,
the inode will have multiple dentries linked.
Without fresh mount, inode_path will always get the most recently linked dentry.
e.g. if there are three hardlinks named dir1/link1, dir2/link2, dir3/link3, on a client
where these hardlinks are looked up, inode_path will always return the path dir3/link3
if dir3/link3 was looked up most recently. Hence, we won't be able to create linkto
files for all other hardlinks on destination (read gf_defrag_handle_hardlink for more details
on hardlink migration).
With a fresh mount, the lookup and setfattr become serialized. e.g. link2 won't be
looked up until link1 is looked up and migrated. Hence, inode_path will always have the correct
path, in this case link1 dentry is picked up(as this is the most recently looked up inode) and
the path is built right.
Note: If you run the above script on an existing mount(all entries looked up), hard links may
not be migrated, but there should not be any other issue. Please raise a bug, if you find any
issue.
Tests: Manual
Change-Id: I9854cdd4955d9e24494f348fb29ba856ea7ac50a
BUG: 1450975
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/17115
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2b51a482837fd1eb48379d046f681bb54faea636
Author: hari gowtham <hgowtham@redhat.com>
Date: Thu May 18 14:15:39 2017 +0530
Tier: removing port allocated for tier
Problem: Tier has a port which it doesn't use.
Fix: Remove the port getting allocated for tier.
Change-Id: If0fe393fc335d9f622a063787e0a3c6db9b7a50c
BUG: 1452006
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/17328
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 4fd5d2465c7570c7b0525d57f300e6ff6576acf2
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon May 29 16:19:40 2017 +0530
socket/reconfigure: reconfigure should be done on new dict
In socket reconfigure, reconfigurations are doing with old
dict values. It should be with new reconfigured dict values
Change-Id: Iac5ad4382fe630806af14c99bb7950a288756a87
BUG: 1456405
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17412
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1cc1dd33cd898156e625ea7eaef25ee0724a42bf
Author: Michael Scherer <misc@redhat.com>
Date: Fri Feb 24 22:32:06 2017 +0100
nfs/netgroups: do not free the same file twice
Coverity warn about a code path where 'file' is freed twice. And reading
the code, I also found that 'line' shouldn't be freed using GF_FREE
since it was allocated by getline.
Also call _ng_deinit_parsers() in the success case, preventing leaking
two 'struct parser' upon multiple calls to ng_file_parse().
Change-Id: I05d71fdbf3b48a25d35e7a56a4c245ceb2dd6ed9
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
[ndevos: add _ng_deinit_parsers() cleanup suggested by Nithya]
Reviewed-on: https://review.gluster.org/16759
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 79fc6e29587060318d22d41a56c33d6a508f79d0
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Apr 10 02:04:42 2017 -0400
geo-rep: Log time taken to sync entries
With each batch having the type and count of
each fop helps to know the kind of I/O.
Having time taken to sync entry ops, metadata
ops and data ops gives us good understanding
into where the more time is being spent.
This patch does the same.
Change-Id: Ib52a0f9ede905f28a468b68bdf6d23e4b043f3e3
BUG: 1455179
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17066
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit e513de40631f6e715fb1d8db7b2b728d365e022f
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon May 22 08:47:07 2017 -0400
features/bitrot: Fix glusterfsd crash
With object versioning being optional, it can
so happen the bitrot stub context is not always
set. When it's not found, it's initialized. But
was not being assigned to use in the local
function. This was leading for brick crash.
Fixed the same.
Change-Id: I0dab6435cdfe16a8c7f6a31ffec1a370822597a8
BUG: 1454317
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17357
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 22eda8dfc9127552963c0ca9a4841ac0a0978603
Author: Ji-Hyeon Gim <potatogim@gluesys.com>
Date: Fri May 5 18:06:25 2017 +0900
libglusterfs: updates old comment for 'arena_size'
the comment (libglusterfs/src/iobuf.h:88-90) for 'arena_size' field
in 'struct iobuf_arena' is not valid anymore. According to line 190 in
__iobuf_arena_alloc() no longer follows that equation.
Change-Id: I68558164b309123cf19093e2da89bc156df294fd
BUG: 1455831
Signed-off-by: Ji-Hyeon Gim <potatogim@gluesys.com>
Reviewed-on: https://review.gluster.org/17393
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f26517daffb900d94ab0879ef7944774e5b0548c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 24 22:30:29 2017 +0530
features/shard: Handle offset in appending writes
When a file is opened with append, all writes are appended at the end of file
irrespective of the offset given in the write syscall. This needs to be
considered in shard size update function and also for choosing which shard to
write to.
At the moment shard piggybacks on queuing from write-behind
xlator for ordering of the operations. So if write-behind is disabled and
two parallel appending-writes come both of which can increase the file size
beyond shard-size the file will be corrupted.
BUG: 1455301
Change-Id: I9007e6a39098ab0b5d5386367bd07eb5f89cb09e
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17387
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 8502309d199b7b02dd941697b41a27358704a50d
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri May 19 21:04:53 2017 +0530
glusterfsd: process attach and detach request inside lock
With brick multiplexing, there is a high possibility that attach and
detach requests might be parallely processed and to avoid a concurrent
update to the same graph list, a mutex lock is required.
Credits : Rafi (rkavunga@redhat.com) for the RCA of this issue
Change-Id: Ic8e6d1708655c8a143c5a3690968dfa572a32a9c
BUG: 1454865
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17374
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit df636bf3574088db1ddb8d22ededffb182cd1b65
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Mon May 22 23:25:47 2017 +0530
libglusterfs : Fix crash in glusterd while peer probing
glusterd crashes when port is being set explcitly to a
range which is outside greater than short data type range.
Eg. sysctl net.ipv4.ip_local_reserved_ports="49152-49156"
In above case glusterd crashes while parsing the port.
With this fix glusterd will be able to handle port range
between INT_MIN to INT_MAX
Change-Id: I7c75ee67937b0e3384502973d96b1c36c89e0fe1
BUG: 1454418
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-on: https://review.gluster.org/17359
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 5f5bb3c594aef03c446df12c250b28a8e9f8f46f
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed May 24 03:17:33 2017 -0400
features/dht: Initialize local hashed_subvol
Self heal directory code path doesn't always
have local->hashed_subvol populated. Populating
the same which otherwise would fail the self
heal.
Change-Id: I03b64709fd7a68e28f9e7438243e817c53c6ef5d
BUG: 1455104
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17381
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 60c2f72c38002ad566921b2d65eeac180bab05ec
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon May 22 20:23:06 2017 +0530
glusterd: ignore incorrect uuid validation if uuid_str is empty
If uuid_str is not filled up in dictionary (when glusterd bit is old),
we shouldn't be additional validation with peer uuid otherwise the
handshake request will fail.
Refer :
http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html
Credits : pawan@platform.sh
Change-Id: I2c30bf0490c31d1418b31d555e7758696e79409f
BUG: 1454375
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17358
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit ca6c40c6a81e5a7a3c6caa485b0747ae899ee19f
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue May 23 11:47:18 2017 -0400
geo-rep: Make changelog-batch-size configurable
Changelog batch size is set to 727040 bytes which
is the size of all the changelogs in a single batch.
It's based on few tests which approximately processes
5K entries. But it might vary on different machines.
Making it configurable gives more control on the
frequency of stime updates. This patch does the same.
Change-Id: I9a5ebb3d92c1327dded0e0a712c43a5a9046c1b0
BUG: 1454872
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17376
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 49341f510ff24971d0db52015d7a69d79a1d1ab2
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Tue May 23 19:32:24 2017 +0530
glusterd: Eliminate race in brick compatibility checking stage
In https://review.gluster.org/17307/, while looking for compatible
bricks for multiplexing, it is checked if the brick pidfile exists
before checking if the corresponding brick process is running.
However checking if the brick process is running just after
checking if the pidfile exists isn't enough since there might be
race conditions where the pidfile has been created but hasn't
been updated with a pid value yet. This commit solves that by
making sure that we wait iteratively till the pid value is updated
as well.
Change-Id: Ib7a158f95566486f7c1f84b6357c9b89e4c797ae
BUG: 1451248
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17375
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 368a42794e31e5cc4631fd7eee7ea1262da6f576
Author: Csaba Henk <csaba@redhat.com>
Date: Tue May 9 19:26:40 2017 +0200
fuse: implement "-oauto_unmount"
libfuse has an auto_unmount option which,
if enabled, ensures that the file system
is unmounted at FUSE server termination
by running a separate monitor process
that performs the unmount when that
occurs. (This feature would probably
better be called "robust auto-unmount",
as FUSE servers usually do try to unmount
their file systems upon termination,
it's just this mechanism is not crash
resilient.)
This change implements that option and
behavior for glusterfs.
Note that "auto unmount" (robust or not) is
a leaky abstraction, as the kernel cannot
guarantee that at the path where the FUSE
fs is mounted is actually the toplevel mount
at the time of the umount(2) call, for
multiple reasons, among others, see:
fuse-devel: "fuse: feasible to distinguish between umount and abort?"
http://fuse.996288.n3.nabble.com/fuse-feasible-to-distinguish-between-umount-and-abort-tt14358.html
https://github.com/libfuse/libfuse/issues/122
Updates #153
Change-Id: Ia4432580c9fd2c156d9c73c3a44f4bfd42437599
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: https://review.gluster.org/17230
Tested-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 99a4ba4e5a63ae7f29643967b3f594494654fa60
Author: Csaba Henk <csaba@redhat.com>
Date: Tue May 9 19:23:18 2017 +0200
libglusterfs: extract some functionality to functions
- code in run.c to close all file descriptors,
except for specified ones is extracted to
int close_fds_except (int *fdv, size_t count);
- tokenizing and editing a string that consists
of comma-separated tokens (as done eg. in
mount_param_to_flag() of contrib/fuse/mount.c
is abstacted into the following API:
char *token_iter_init (char *str, char sep, token_iter_t *tit);
gf_boolean_t next_token (char **tokenp, token_iter_t *tit);
void drop_token (char *token, token_iter_t *tit);
Updates #153
Change-Id: I7cb5bda38f680f08882e2a7ef84f9142ffaa54eb
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: https://review.gluster.org/17229
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit eb0fbb61e99a3fc0157181b518c0d5fdbcf90e89
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Dec 2 15:04:49 2016 +0530
geo-rep: Rsync tunables for performance improvements
Flag: --ignore-missing-args
This Rsync flag reduces sync failures if the source file is
unlinked but present in --files-from list. This reduces
Rsync retries in Geo-rep and improves the performance
Flag: --existing
Rsync in Geo-rep never creates target files. Using RPC Geo-rep creates
entry in Slave and rsync --inplace used to prevent creating temporary file
and rename.(To avoid different GFID in Slave). If the entry is missing in
Slave then Geo-rep Rsync gets Permission denied errors when it tries to
create file with name as GFID inside .gfid dir.(Geo-rep rsync syncs data
using GFIDS with aux-gfid-mount)
To disable these flags,
gluster volume geo-replication <session> config \
rsync-opt-ignore-missing-args false
gluster volume geo-replication <session> config \
rsync-opt-existing false
Thanks Kotresh for finding these awesome tunables.
BUG: 1400924
Change-Id: I6a84fb86a589bf6edc8dfd1086456a84b05a64fc
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/16010
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit f094cff0dcf4f65e02a73afe5f0e0672b40de6be
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Wed May 17 14:35:41 2017 +0530
cluster/ec: Implement FALLOCATE FOP for EC
FALLOCATE file operations is not implemented in the
existing EC code. This change set implements it
for EC.
BUG: 1448293
Change-Id: Id9ed914db984c327c16878a5b2304a0ea461b623
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
Reviewed-on: https://review.gluster.org/15200
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ca711547f25020ec36410530681a165e93f91522
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Sun May 21 12:31:29 2017 +0530
glusterd : volume profile command on one of the node crashes glusterd
When volume profile command is issued on one of the node glusterd
crashes. Its a race condition which may hit when profile command and
status command is being executed from node A and node B respectively.
While doing so event GD_OP_STATE_BRICK_OP_SENT/GD_OP_STATE_BRICK_COMMITTED
is being triggered. As handling of event is not thread safe, hence context
got modify and glusterd crashes.
With the fix now we are validating the context before using it.
Change-Id: Ic07c3cdc5644677b0e40ff0fac6fcca834158913
BUG: 1452956
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-on: https://review.gluster.org/17350
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit d07a5050aac4456b1e08cc7a3ca11ccf60316e76
Author: Poornima G <pgurusid@redhat.com>
Date: Tue May 16 19:25:20 2017 +0530
nl-cache: In case of nameless operations do not cache
Issue:
In nameless lookup/other fops, parent inode will be NULL, when we try
to add the cache to the NULL inode, it causes a crash.
Hence handle the scenario of nameless fops, and do not cache/serve
the nameless fops.
Change-Id: I3b90f882ac89e6aaf3419db89e6f890797f37700
BUG: 1451588
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17316
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ffd5e46529db9e72cd28affb9c099d6b42eb47f8
Author: Poornima G <pgurusid@redhat.com>
Date: Fri May 19 11:09:13 2017 +0530
rda, glusterd: Change the max of rda-cache-limit to INFINITY
Issue:
The max value of rda-cache-limit is 1GB before this patch.
When parallel-readdir is enabled, there will be many instances of
readdir-ahead, hence the rda-cache-limit depends on the number of
instances. Eg: On a volume with distribute count 4, rda-cache-limit
when parallel-readdir is enabled, will be 4GB instead of 1GB.
Consider a followinf sequence of operations:
- Enable parallel readdir
- Set rda-cache-limit to lets say 3GB
- Disable parallel-readdir, this results in one instance of readdir-ahead
and the rda-cache-limit will be back to 1GB, but the current value is 3GB
and hence the mount will stop working as 3GB > max 1GB.
Solution:
To fix this, we can limit the cache to 1GB even when parallel-readdir
is enabled. But there is no necessity to limit the cache to 1GB, it
can be increased if the system has enough resources. Hence getting rid
of the rda-cache-limit max value is more apt. If we just change the
rda-cache-limit max to INFINITY, we will render older(<3.11) clients
broken, when the rda-cache-limit is set to > 1GB (as the older clients
still expect a value < 1GB). To safely change the max value of
rda-cache-limit to INFINITY, add a check in glusted to verify all
the clients are > 3.11 if the value exceeds 1GB.
Change-Id: Id0cdda3b053287b659c7bf511b13db2e45b92032
BUG: 1446516
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17338
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 16f97e6c0719e0b01a210bae25cf314de1d25d8b
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri May 19 15:22:12 2017 +0530
cluster/dht: Fix crash in dht_selfheal_dir_setattr
Use a local variable to store the call cnt used in the
for loop for the STACK_WIND so as not to access local
which may be freed by STACK_UNWIND after all fops return.
Change-Id: I24f49b6dbd29a2b706e388e2f6d5196c0f80afc5
BUG: 1452102
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17343
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f33c9d9ec33aa83ed23e4cc3ddd9894b0e8f60c0
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu May 18 15:49:27 2017 -0400
cluster/afr: Remove debug logs in fix_quorum_options()
Change-Id: Id019b0c6425849eece8a9aba7acec9a521dfb10b
BUG: 1452378
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: https://review.gluster.org/17335
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit deab135f6705f77a48497b4406e18ba09cd83e1b
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Tue May 16 15:07:21 2017 +0530
glusterd: Don't spawn new glusterfsds on node reboot with brick-mux
With brick multiplexing enabled, upon a node reboot new bricks were
not being attached to the first spawned brick process even though
there wasn't any compatibility issues.
The reason for this is that upon glusterd restart after a node
reboot, since brick services aren't running, glusterd starts the
bricks in a "no-wait" mode. So after a brick process is spawned for
the first brick, there isn't enough time for the corresponding pid
file to get populated with a value before the compatibilty check is
made for the next brick.
This commit solves this by iteratively waiting for the pidfile to be
populated in the brick compatibility comparison stage before checking
if the brick process is alive.
Change-Id: Ibd1f8e54c63e4bb04162143c9d70f09918a44aa4
BUG: 1451248
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17307
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f4fa18e644dc86dc8bddd251c847983b31738050
Author: Susant Palai <spalai@redhat.com>
Date: Tue May 16 07:00:31 2017 +0530
cluster/dht: initialize throttle option "normal" to same in init and reconfigure
Normal value were different in dht_init and dht_reconfigure.
Initialization/reconfigure of throttle option are carved out to a separate function
(dht_configure_throttle) now. Normal value will be "2".
Change-Id: Ie323eae019af41d6bef0a136e3d284dc82bab9a1
BUG: 1451162
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/17303
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit eb6961bf4cf25c32419869c02e5797e040982d01
Author: karthik-us <ksubrahm@redhat.com>
Date: Wed Apr 19 18:04:46 2017 +0530
cluster/afr: Return the list of node_uuids for the subvolume
Problem:
AFR was returning the node uuid of the first node for every file if
the replica set was healthy, which was resulting in only one node
migrating all the files.
Fix:
With this patch AFR returns the list of node_uuids to the upper layer,
so that they can decide on which node to migrate which files, resulting
in improved performance. Ordering of node uuids will be maintained based
on the ordering of the bricks. If a brick is down, then the node uuid
for that will be set to all zeros.
Change-Id: I73ee0f9898ae473584fdf487a2980d7a6db22f31
BUG: 1366817
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: https://review.gluster.org/17084
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit b00f52b5dc20d04dff21dcb43cd34b3631a5506b
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Fri May 12 09:23:47 2017 +0200
cluster/ec: return all node uuids from all subvolumes
EC was retuning the UUID of the brick with smaller value. This had
the side effect of not evenly balancing the load between bricks on
rebalance operations.
This patch modifies the common functions that combine multiple subvolume
values into a single result to take into account the subvolume order
and, optionally, other subvolumes that could be damaged.
This makes easier to add future features where brick order is important.
It also makes possible to easily identify the originating brick of each
answer, in case some brick will have an special meaning in the future.
Change-Id: Iee0a4da710b41224a6dc8e13fa8dcddb36c73a2f
BUG: 1366817
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/17297
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 8a992b91d7a37bde257961d6b15a27de4ea7b12e
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Tue May 9 12:13:37 2017 +0800
glusterd: remove useless options from glusterd's volume set table
These options will cause brick's log complains:
_log_if_unknown_option] 0-patchy-quota: option 'timeout' is not recognized
_log_if_unknown_option] 0-patchy-server: option 'ping-timeout' is not recognized
Change-Id: Ida2add13f792736a4e52bfaf38d1169309283a3f
BUG: 1449008
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: https://review.gluster.org/17213
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 371200d550555bad792f60db68bd4d085cd3f283
Author: hari gowtham <hgowtham@redhat.com>
Date: Fri Apr 28 00:09:50 2017 +0530
Tier/cli: detach status xml output
Problem: detach status xml output was broken because
of the wrong argument. The status_op sent to verify
whether it is a tier status command was as false.
Fix: the argument being passed was changed from false
to true.
Change-Id: I8cdd4dd972d6bfbb61c1182cbf4097767f83c7c5
BUG: 1446362
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/17131
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit a2503f02b9f6807097c30fa334b2e5d8b9c6bbfd
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed May 10 21:26:28 2017 +0530
cluster/dht: Rebalance on all nodes should migrate files
Problem:
Rebalance compares the node-uuid of a file against its own
to and migrates a file only if they match. However, the
current behaviour in both AFR and EC is to return
the node-uuid of the first brick in a replica set for all
files. This means a single node ends up migrating all
the files if the first brick of every replica set is on the
same node.
Fix:
AFR and EC will return all node-uuids for the replica set.
The rebalance process will divide the files to be migrated
among all the nodes by hashing the gfid of the file and
using that value to select a node to perform the migration.
This patch makes the required DHT and tiering changes.
Some tests in rebal-all-nodes-migrate.t will need to be
uncommented once the AFR and EC changes are merged.
Change-Id: I5ce41600f5ba0e244ddfd986e2ba8fa23329ff0c
BUG: 1366817
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17239
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 773f2279b86e45b345e49ad5031d205d0db164ff
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue May 16 10:26:25 2017 +0530
cluster/dht: Fix crash in dht rmdir
Using local->call_cnt to check STACK_WINDs can
cause dht_rmdir_do to be called erroneously if
dht_rmdir_readdirp_cbk unwinds before we check if
local->call_cnt is zero in dht_rmdir_opendir_cbk.
This can cause frame corruptions and crashes.
Thanks to Shyam (srangana@redhat.com) for the
analysis.
Change-Id: I5362cf78f97f21b3fade0b9e94d492002a8d4a11
BUG: 1451083
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17305
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 1626dee3866b85490f4d8782cb4c451bbbf372b3
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon May 1 12:39:56 2017 -0400
contrib/timerwheel: bad 32-bit, use builtin fls(), fix copyright
It's bad form to remove other people's copyright and license when you
copy their source for your own use.
Defining BITS_PER_LONG as 64 is incorrect on 32-bit platforms.
The mismatch between the unsigned long of the timer and the int
param to fls() means on 64-bit platforms that any bits set in the
high 32-bits of the the timer are lost/ignored.
gf_tw_find_last_bit() is meant to find the last bit in an array of
longs. It's overkill for gluster's timerwheel where we only ever pass
a single long; replacing it with a direct call to fls() which is
renamed to gf_tw_fls()
The timer routines are slightly modified from the kernel timer
functions that first appeared circa 2.6.x in .../kernel/timer.c
AFAICT.
find_last_bit() comes from the (linux) kernel (.../lib/find_bit.c
in 4.x kernels, .../lib/find_last_bit.c in 3.x kernels) but as noted
above, it is removed with this patch.
__fls() comes from the linux kernel (.../include/asm-generic/
bitops/{__fls.h,builtin-__fls.h}
Restoring/updating the copyright and license to the version from
the 4.x kernel find_bit.c. (timer.c does not have a license, __fls.h
and builtin-__fls.h do not have a copyright or license, but the whole
kernel is licensed under GPLv2 anyway.)
Change-Id: I2d2defccf1ccc74f55d99e94212747a36a1dff35
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17146
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 4025655b144da89e614685405a436d372ae0c9a9
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed May 10 10:03:08 2017 +0530
afr: propagate correct errno for fop failures in arbiter
Problem:
If quorum is not met in fop cbk, arbiter sends an ENOTCONN error to the
upper xlators. In a VM workload with sharding enabled, this was leading
to the VM pausing when replace-brick was performed as described in the BZ.
Fix:
Move the fop cbk arbitration logic to afr_handle_quorum() because in
normal replica volumes, that is the function that has the quorum and
errno checks in the fop cbk path before doing a post-op.
Thanks to Pranith for suggesting this approach.
Change-Id: Ie6315db30c5e36326b71b90a01da824109e86796
BUG: 1449610
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17235
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 3c5d556acbd92c7c8dccb4e6248d9cfffbdac0a7
Author: Poornima G <pgurusid@redhat.com>
Date: Fri May 12 10:27:28 2017 +0530
nl-cache: Remove the max limit for nl-cache-limit and nl-cache-timeout
The max limit is better unset when arbitrary. Otherwise in the future
if max has to be changed, it can break backward compatility.
Change-Id: I4337a3789a2d0d5cc8e2bf687a22536c97608461
BUG: 1442569
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17261
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit ebf99a25516f72411f461ab94e451b2ebff1bce6
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon May 15 10:15:20 2017 +0530
afr: gfid-mismatch-resolution-with-fav-child-policy.t to bad tests
gfid-mismatch-resolution-with-fav-child-policy.t does a `TEST ls
$M0/f3` (line #170) to trigger healing of a file in gfid split-brain in
a rep-3 volume. But the code to trigger name heal of gfid split-brain
file is not yet there. The test is passing due a lookup/ stat on $M0
which triggers a background entry self heal (which has the code to heal
gfid split-brain files) which may or may not complete the heal before
line 170. If it doesn't, lookup on f3 is failing with EIO.
Add the .t to bad tests until Karthik's patch for CLI based gfid
split-brain resolution fixes name heal also.
Change-Id: Iba6e9d81db386bc406aff1ecb6a18851f09bf7c0
BUG: 1450730
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17290
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 34435b40784aaa6deadfd49edf0999ab8f517b7e
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Sat May 13 10:06:50 2017 +0530
socket: Avoid flooding of error message in case of SSL
Problem: socket poller is throwing Input/Output messages during volume operation
Solution: Update the code in socket_connect function before call
socket_spwan.
BUG: 1450559
Change-Id: I5f275fe7a4b730b16d7b0a0407e76288b07ceaef
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/17280
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit faf91498de062cf1895bf79d8b2b8401ce139282
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun May 14 12:34:15 2017 +0530
brick mux: Detach brick on posix health check failure
With brick mux enabled, we'd need to detach a particular brick if the
underlying backend has gone bad. This patch addresses the same.
Change-Id: Icfd469c7407cd2d21d02e4906375ec770afeacc3
BUG: 1450630
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17287
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 942b6d9028ae50ad928bcdcb9846f004f7051dd5
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 20 11:13:55 2017 -0400
rpc: add more document on programs and actors
Also give hints on where to look for relevant structures.
Fixes #140
Change-Id: If29f67fb6fd39379045fe774559934fb13cbede8
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/16925
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6b56bbbfb3e0201d8936be6eeef41759578cb71c
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue May 9 21:05:50 2017 +0530
glusterfsd: send PARENT_UP on brick attach
With brick multiplexing being enabled, if a brick is instance attached to a
process then a PARENT_UP event is needed so that it reaches right till
posix layer and then from posix CHILD_UP event is sent back to all the
children.
Change-Id: Ic341086adb3bbbde0342af518e1b273dd2f669b9
BUG: 1447389
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17225
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 5549e1250d97f3c2db49595cc7ac8490b3bdd037
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed May 3 17:19:57 2017 +0530
gfapi: fix handling of dot and double dot in path
This patch is to handle "." and ".." in file path. Which means
this special dentry names will be resolved before sending fops
on the path.
Change-Id: I5e92f6d1ad1412bf432eb2488e53fb7731edb013
BUG: 1447266
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17177
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit a6a63f9318606bccf475b5e91462af819367dc77
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue May 9 16:11:52 2017 +0530
tests/gfapi:Adding testcase to check handling of "." and ".."
Adding a testcase to check the proper handling of "." and ".."
in gfapi path.
The patch which fix the issue is https://review.gluster.org/#/c/17177
Change-Id: I5c9cceade30f7d8a3b451b5f34f1cf9815729c4a
BUG: 1447266
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17216
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 895b004fd8f61e7543bc738bddf0c33dff3c3723
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 10 16:26:35 2017 +0530
extras: Provide group set for gluster-block workloads
For gluster-block workloads I/O is always with o-direct so it doesn't
benefit by any of the perf xlators so disabling all of them to save
on memory.
performance.quick-read=off
performance.read-ahead=off
performance.io-cache=off
performance.stat-prefetch=off
performance.write-behind=off
performance.open-behind=off
performance.readdir-ahead=off
We want the I/O on the file to be with o-direct
network.remote-dio=enable
Options that are proven to give good performance with
VM workloads which is very similar to gluster-block
cluster.eager-lock=enable
cluster.quorum-type=auto
cluster.data-self-heal-algorithm=full
cluster.locking-scheme=granular
cluster.shd-max-threads=8
cluster.shd-wait-qlength=10000
features.shard=on
It is better to turn off things we are not using
user.cifs=off
It is better to have allow-insecure to be on so that
ports that are > 1024 in tcmu-runner are allowed.
server.allow-insecure=on
Change-Id: I9a21c824fa42242f02b57569feedd03d9b6f9439
BUG: 1450010
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/17254
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 1fa9b97308e1eebd78cd6695932e4e7f3a61bf9b
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Tue Feb 3 10:48:49 2015 +0530
glusterd: coverity fix for string overflow
coverity CID: 1124852
Change-Id: Ifb04ad36b0652474007d2768737722231a5c1df0
BUG: 789278
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: https://review.gluster.org/9539
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 402087a8344c801b297137fe5037c1e1235dc446
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Dec 16 18:55:28 2016 +0530
cluster/tier: Don't update cached subvol
tier_readdirp_cbk updates the cached subvol to
the hot tier if it finds a linkto file.
However, if no lookup has been sent to the hot tier,
lower layers will not have updated the inode-ctx causing
later fops to fail.
Change-Id: Ib8a5e58a6e7fd7750cf6a0ea85da611aa24c7512
BUG: 1402406
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/16163
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@gmail.com>
Tested-by: Dan Lambright <dlambrig@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 1aceaf22dbb87caca66d116bd75e2659032f8adc
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 13 13:02:23 2017 +0100
nfs/nlm: remove lock request from the list after cancel
Once an NLM client cancels a lock request, it should be removed from the
list. The list can also be cleaned of unneeded entries once the client
does not have any outstanding lock/share requests/granted.
Change-Id: I2f2b666b627dcb52cddc6d5b95856e420b2b2e26
BUG: 1381970
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17188
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 9f6da31f7f047b8af48ef4eb6d2f84d3fd3391af
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 20 14:15:31 2017 +0100
nfs/nlm: free the nlm_client upon RPC_DISCONNECT
When an NLM client disconnects, it should be removed from the list and
free'd.
Change-Id: Ib427c896bfcdc547a3aee42a652578ffd076e2ad
BUG: 1381970
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17189
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit b7972279408d330dc394ec2f004bb09a1537cee4
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri May 5 15:21:30 2017 +0530
event/epoll: Add back socket for polling of events immediately after reading the entire rpc message from the wire
Currently socket is added back for future events after higher layers
(rpc, xlators etc) have processed the message. If message processing
involves signficant delay (as in writev replies processed by Erasure
Coding), performance takes hit. Hence this patch modifies
transport/socket to add back the socket for polling of events
immediately after reading the entire rpc message, but before
notification to higher layers.
credits: Thanks to "Kotresh Hiremath Ravishankar"
<khiremat@redhat.com> for assitance in fixing a regression in
bitrot caused by this patch.
Change-Id: I04b6b9d0b51a1cfb86ecac3c3d87a5f388cf5800
BUG: 1448364
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: https://review.gluster.org/15036
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit fdd378a23d79b42497c6b3b5e4567d6184d2af44
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Tue May 9 20:57:34 2017 +0800
libglusterfs: fix race condition in client_ctx_set
follow procedures:
1.thread1 client_ctx_get return NULL
2.thread 2 client_ctx_set ctx1 ok
3.thread1 client_ctx_set ctx2 ok
thread1 use ctx1, thread2 use ctx2 and ctx1 will leak
Change-Id: I990b02905edd1b3179323ada56888f852d20f538
BUG: 1449232
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: https://review.gluster.org/17219
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 2869b6c24e5568888b72a48974a8adea896d18f9
Author: Ji-Hyeon Gim <potatogim@potatogim.net>
Date: Thu May 11 18:05:21 2017 +0900
rpc: fix a routine to destory RDMA qp(queue-pair)
Problem: If an error has occured with rdma_create_id() in gf_rdma_connect(),
process will jump to the 'unlock' label and then call gf_rdma_teardown()
which call __gf_rdma_teardown().
Presently, __gf_rdma_teardown() checks InifiniBand QP with peer->cm_id->qp!
Unfortunately, cm_id is not allocated and will be crushed in this situation :)
Solution: If 'this->private->peer->cm_id' member is null, do not check
'this->private->peer->cm_id->qp'.
Change-Id: Ie321b8cf175ef4f1bdd9733d73840f03ddff8c3b
BUG: 1449495
Signed-off-by: Ji-Hyeon Gim <potatogim@potatogim.net>
Reviewed-on: https://review.gluster.org/17249
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Ji-Hyeon Gim
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit ad5ece16e17a7b7f6f63accb07c165e308e15caf
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue May 9 02:31:39 2017 +0530
afr: send the correct iatt values in fsync cbk
Problem:
afr unwinds the fsync fop with an iatt buffer from one of its children
on whom fsync was successful. But that child might not be a valid read
subvolume for that inode because of pending heals or because it happens
to be the arbiter brick etc. Thus we end up sending the wrong iatt to
mdcache which will in turn serve it to the application on a subsequent
stat call as reported in the BZ.
Fix:
Pick a child on whom the fsync was successful *and* that is readable as
indicated in the inode context.
Change-Id: Ie8647289219cebe02dde4727e19a729b3353ebcf
BUG: 1449329
RCA'ed-by: Miklós Fokin <miklos.fokin@appeartv.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17227
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 3835e862c2ff9ef888e83a19d9127a8a9334a42c
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Mon Apr 24 22:00:17 2017 +0530
glusterd: Make reset-brick work correctly if brick-mux is on
Reset brick currently kills of the corresponding brick process.
However, with brick multiplexing enabled, stopping the brick
process would render all bricks attached to it unavailable. To
handle this correctly, we need to make sure that the brick process
is terminated only if brick-multiplexing is disabled. Otherwise,
we should send the GLUSTERD_BRICK_TERMINATE rpc to the respective
brick process to detach the brick that is to be reset.
Change-Id: I69002d66ffe6ec36ef48af09b66c522c6d35ac58
BUG: 1446172
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17128
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 1e21d9bb2ba801d285b7a2a5853211528edc9abe
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed May 10 15:44:33 2017 +0530
tests/lock_revocation: mark as bad
The test is failing in master. see gluster-devel for more details.
Change-Id: I7a589ad2c54bd55d62f4e66fdf8037c19fc123ea
BUG: 1448364
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: https://review.gluster.org/17234
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 677f4e319365cefb5d93916b90398bd4d0a5f9cf
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon May 8 21:10:50 2017 +0530
features/changelog: Add xattr as special type in changelog entry
When both SETATTR and SETXATTR fops are happening on gfid within the
rollover time then, SETXATTR were not logged.
In Which case we will miss the xattr fop in slave.
This patch will be fix the same
Change-Id: Ia75538ad1fd2797dbcf90d20dfa89f756009243d
BUG: 1448914
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17205
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit e16fbab29dade934af550ec3953c247f58c8ab13
Author: Michael Scherer <misc@redhat.com>
Date: Fri May 5 16:01:36 2017 +0200
Fix 'flush' type, coverity warning
As getchar returna a int, (which is 4 bytes on most
common platforms, and at least 2 bytes), and char being often
1 byte, the conversion would lose information, hence
the warning.
Change-Id: I5b0b39c636ff49ef5c15d51a7f798e21635eca06
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/17193
Tested-by: Michael Scherer <misc@fedoraproject.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 0fadcf3266de038552ead644ab98c997a041a3f6
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri May 5 14:30:49 2017 +0530
features/shard: Set size in inode ctx before size update for truncate too
Change-Id: I7e984bb0f50c7d42764c0648e697d94d6c768dc7
BUG: 1448299
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17184
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit d6101985b5ca843ca476f051368dc9ab72fb30fd
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 13 14:46:17 2017 +0100
nfs/nlm: log the caller_name if nlm_client_t can be found
In order to help tracking possible misbehaving clients down, log the
'caller_name' (hostname of the NFS client) that does not have a matching
nlm_client_t structure.
Change-Id: Ib514a78d1809719a3d0274acc31ee632727d746d
BUG: 1381970
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17186
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 56521833e16b19ef708b1b212f98adcff7dc85cc
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 13 14:02:45 2017 +0100
nfs/nlm: ignore notify when there is no matching rpc request
In certain (unclear) occasions it seems to happen that there are
notifications sent to the Gluster/NFS NLM service, but no call-state can
be found. Instead of segfaulting, log an error but keep on running.
Change-Id: I0f186e56e46a86ca40314d230c1cc7719c61f0b5
BUG: 1381970
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17185
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 2b3066430008214e3265341881e0a6ece2a64b5c
Author: Jeff Darcy <jdarcy@fb.com>
Date: Mon May 8 12:55:49 2017 -0400
build: add site.h as a place to put environment-specific defines
Most people consume Gluster in one of two ways:
* From packages provided by their OS/distribution vendor
* By building themselves from source
For the first group it doesn't matter whether configuration is done in
a configure script, via command-line options to that configure script,
or in a header file. All of these end up as edits to some file under
the packager's control, which is then run through their tools and
process (e.g. rpmbuild) to create the packages that users will
install.
For the second group, convenience matters. Such users might not even
have a script wrapped around the configure process, and editing one
line in a header file is a lot easier than editing several in the
configure script. This also prevents a messy profusion of configure
options, dozens of which might need to be added to support a single
such user's preferences. This comes back around as greater simplicity
for packagers as well.
This patch defines site.h as the header file for options and
parameters that someone building the code for themselves might want to
tweak. The project can ship one version to reflect the developers'
guess at the best defaults for most users, and sophisticated users
with unusual needs can override many options at once just by
maintaining their own version of that file. Everybody wins. Further
guidelines for how to determine whether an option should go in
configure.ac or site.h are explained within site.h itself.
Fixes #201
Change-Id: I5b8fb518d42450737423c4c1f43ebeb3130b4ff6
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17206
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 6d559afa867851a6d78d32e257e86555c4200618
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue May 9 14:02:41 2017 +0530
afr: fixes to quorum-type in afr_priv_dump()
Include the 'none' option as well in the output. This fixes the bug in
commit 335555d256d444f4952ce239168f72b393370f01.
Also added a test-case.
This is a
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: I479a14ae69ecae5a03e85e73ed50c19b483df603
BUG: 1448804
Reviewed-on: https://review.gluster.org/17215
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 3ffc3d1bfc2b26c73623155b0ed7efef4f4845b8
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Nov 10 10:56:26 2016 +0530
mount/fuse: Handle racing notify on more than one graph properly
Make sure that we always use latest graph as a candidate for
active-subvol.
Change-Id: Ie37c818366f28ba6b1570d65a9eb17697d38a6c5
BUG: 1448364
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: https://review.gluster.org/17200
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit c7dce4075b59f6b8177a6de204a695203064acec
Author: AnkitRaj <anraj@redhat.com>
Date: Mon May 8 17:52:33 2017 +0530
dht:Spacing issue in fix-layout o/p
There is a spacing issue in the status output of
the rebalance fix-layout operations. If the local
host name is big then we will have spacing issue.
Change-Id: I2fcc4fd382723fb7e93cb4d4dad03dae682cc1a8
BUG: 1437748
Signed-off-by: AnkitRaj <anraj@redhat.com>
Reviewed-on: https://review.gluster.org/17203
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: ankitraj
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit a292997a7daba9a1abc2217fca52a1de8a4eb2d9
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Tue Apr 25 08:28:25 2017 -0400
libglusterfs: include sys/time.h avoid compiling error on MacOSX
Change-Id: I3d30bacc3d5d085220dd85a3919207deef8bd1dd
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Reviewed-on: https://review.gluster.org/17114
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 102116083a2376016586a3e6f576a6eb90c7d05c
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Thu May 4 09:01:37 2017 +0800
libglusterfs/graph: fix potential endless loop in options validate work
Change-Id: Icb71ded6051afe44e07480e0499d2a39f05fac71
BUG: 1447826
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: https://review.gluster.org/17171
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 69a6782613aa435fde44d35ae6d88ed587fbc4b2
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Apr 11 15:58:47 2014 +0530
performance/read-ahead: prevent stale data being returned to application.
Assume that fd is shared by two application threads/processes.
T0 read is triggered from app-thread t1 and read call passes through
write-behind.
T1 app-thread t2 issues a write. The page on which read from t1 is
waiting is marked stale
T2 write-behind caches write and indicates to application as write
complete.
T3 app-thread t2 issues read to same region. Since, there is already a
page for that region (created as part of read at T0), this read
request waits on that page to be filled (though it is stale, which
is a bug).
T4 read (triggered at T0) completes from brick (with write still
pending). Now both read requests from t1 and t2 are served this data
(though data is stale from app-thread t2's perspective - which is a
bug)
T5 write is flushed to brick by write-behind.
Fix is to not to serve data from a stale page, but instead initiate a
fresh read to back-end.
Change-Id: Id6af733464fa41bb4e81fd29c7451c73d06453fb
BUG: 1414242
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: https://review.gluster.org/7447
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Csaba Henk <csaba@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 61bc723427aaafee2cfc06bccf45568ee361e087
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Apr 5 09:52:39 2017 +0200
cluster/ec: fix incorrect answer check in seek fop
A bad check in the answer of a seek request caused a segmentation
fault when seek reported an error.
Change-Id: Ifb25ae8bf7cc4019d46171c431f7b09b376960e8
BUG: 1439068
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/16998
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a4f8cbdbbbe9a49b2f78e13fa16f178d156cd1c6
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue May 9 07:05:18 2017 +0530
posix: Send SIGKILL in 2nd attempt
Commit 21c7f7ba changed the signal from SIGKILL to SIGTERM for the 2nd
attempt to terminate the brick process if SIGTERM fails. This patch
fixes this problem.
Change-Id: I856df607b7109a215f2a2a4827ba3ea42d8a9729
BUG: 1444596
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17208
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit fb2bc40f1f607be7661fdebad8bff5ddac0539a5
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon May 8 19:29:22 2017 +0530
glusterd: socketfile & pidfile related fixes for brick multiplexing feature
Problem: While brick-muliplexing is on after restarting glusterd, CLI is
not showing pid of all brick processes in all volumes.
Solution: While brick-mux is on all local brick process communicated through one
UNIX socket but as per current code (glusterd_brick_start) it is trying
to communicate with separate UNIX socket for each volume which is populated
based on brick-name and vol-name.Because of multiplexing design only one
UNIX socket is opened so it is throwing poller error and not able to
fetch correct status of brick process through cli process.
To resolve the problem write a new function glusterd_set_socket_filepath_for_mux
that will call by glusterd_brick_start to validate about the existence of socketpath.
To avoid the continuous EPOLLERR erros in logs update socket_connect code.
Test: To reproduce the issue followed below steps
1) Create two distributed volumes(dist1 and dist2)
2) Set cluster.brick-multiplex is on
3) kill glusterd
4) run command gluster v status
After apply the patch it shows correct pid for all volumes
BUG: 1444596
Change-Id: I5d10af69dea0d0ca19511f43870f34295a54a4d2
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/17101
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a9cd0262db7b61e58f56c89990e20830b173fed9
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Fri Apr 28 05:46:50 2017 -0400
cli: fix build error with --disable-xml-output
./configure --disable-xml-output --disable-georeplication
make
Making all in src
CC cli.o
In file included from cli.c:42:0:
cli.h:440:24: error: unknown type name ‘xmlTextWriterPtr’
cli_xml_output_common (xmlTextWriterPtr writer, int op_ret, int op_errno,
^
cli.h:443:26: error: unknown type name ‘xmlTextWriterPtr’
cli_xml_snapshot_delete (xmlTextWriterPtr writer, xmlDocPtr doc, dict_t *dict,
^
cli.h:443:51: error: unknown type name ‘xmlDocPtr’
cli_xml_snapshot_delete (xmlTextWriterPtr writer, xmlDocPtr doc, dict_t *dict,
^
make[1]: *** [cli.o] Error 1
make: *** [all-recursive] Error 1
Change-Id: I36c2dfc11f89d774b62dfe6f50b156826bed5b66
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Reviewed-on: https://review.gluster.org/17136
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 713f46c4267bba26c8fe75affc4fda9841bc8071
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Apr 25 17:01:09 2017 +0200
libglusterfs: stop special casing "cache-size" in size_t validation
The original situation was as follows:
The function that validates xlator options indicating a size,
xlator_option_validate_sizet(), handles the case when the name
of the option is "cache-size" in a special way.
- Xlator options (things of type volume_option_t) has a
min and max attribute of type double.
- An xlator option is endowed with a gluster specific type (not
C type). An instance of an xlator option goes through a validation
process by a type specific validator function (which are collected
in option.c).
- Validators of numeric types - size being one of them - make use the
min and max attributes to perform a range check, except in one case:
if an option is defined with min = max = 0, then this option will be
exempt of range checking. (Note: the volume_option_t definition
features the following comments along the min, max fields:
double min; /* 0 means no range */
double max; /* 0 means no range */
which is slightly misleading as it lets one to conclude that
zeroing min or max buys exemption from low or high boundary check,
which is not true -- only *both* being zero buys exemption.)
- Besides this, the validator for options of size type,
xlator_option_validate_sizet() special cases options
named "cache-size" so that only min is enforced. (The only consequence
of a value exceeding max is that glusterd logs a warning about it, but
the cli user who makes such a setting gets no feedback on it.)
- This was introduced because a hard coded limit is not useful for
io-cache and quick-read. They rather use a runtime calculated
upper limit. (See changes
I7dd4d8c53051b89a293696abf1ee8dc237e39a20
I9c744b5ace10604d5a814e6218ca0d83c796db80
about the last two points.)
- As an unintended consequence, the upper limit check of
cache-size of write-behind, for which a conventional hard coded limit
is specified, is defeated.
What we do about it:
- Remove the special casing clause for cache-size in
xlator_option_validate_sizet. Thus the general range
check policy (as described above) will apply to
cache-size too.
- To implement a lower bound only check by the validator
for cache-size of io-cache and quick-read, change the
max attribute of these options to INFINITY.
The only behavioral difference is the omission of the warnings
about cache-size of io-cache and quick-read exceeding the former max
values. (They were rather heuristic anyway.)
BUG: 1445609
Change-Id: I0bd8bd391fa7d926f76e214a2178833fe4673b4a
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: https://review.gluster.org/17125
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0c09a0e941e0e45ec6c4571d51a4c1f0cd30f0c0
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 13 16:05:02 2017 +0100
nfs/nlm: unref rpc-client after nlm4svc_send_granted()
nlm4svc_send_granted() uses the rpc_clnt by getting it from the
call-state structure. It is safer to unref the rpc_clnt after the
function is done with it.
Change-Id: I7cb7c4297801463d21259c58b50d7df7c57aec5e
BUG: 1381970
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17187
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 1c28c5cdd20cbeb030adc094cca9937db06b0a24
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Fri Apr 28 06:12:56 2017 +0800
debug/error-gen: Don't need to convert error string to int in every fop
Every fop in xlator error-gen will call function error_gen,
which will call function conv_error to convert pvt->error_no to int.
But actually the function could only be called in init and reconfigure
Change-Id: I96c9780574f369fc58eed10fea9d50c4cd7d4e8a
BUG: 1446412
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: https://review.gluster.org/17132
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 915a2fdcd97b1baa3711aca21667fc5b9cc54e61
Author: Michael Scherer <misc@redhat.com>
Date: Fri May 5 17:20:14 2017 +0200
Remove uneeded gotos, as it jump to the next line
Found by coverity
Signed-off-by: Michael Scherer <misc@redhat.com>
Change-Id: I1fef09a427d18bbeb9af0bf4f5c82c77aa3c0d3d
BUG: 789278
Reviewed-on: https://review.gluster.org/17195
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit a0d8542f566135a395075281b01924a0a36dd099
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed May 3 12:17:30 2017 +0530
glusterd: cleanup pidfile on pmap signout
This patch ensures
1. brick pidfile is cleaned up on pmap signout
2. pmap signout evemt is sent for all the bricks when a brick process
shuts down.
Change-Id: I7606a60775b484651d4b9743b6037b40323931a2
BUG: 1444596
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17168
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit f68cf6f14bed8f000e9924446cb058bff209d4ee
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri May 5 22:19:36 2017 +0530
afr: include quorum type and count when dumping afr priv
Dump the client quorum type ('auto' or 'fixed'). If it is 'fixed', also dump
the quorum-count. This information will be available in the client
statedump and in
/<fuse_mount>/.meta/graphs/active/testvol-replicate-X/private.
Change-Id: Idbd6e2acbd622d4e6cfabf511e649a6da0e42384
BUG: 1448804
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17196
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 0730477a768015252ef2466099902e7e36d0e8ba
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Wed Mar 22 15:02:12 2017 +0530
Fixes quota aux mount failure
The aux mount is created on the first limit/remove_limit/list command
and it remains until volume is stopped / deleted / (quota is disabled)
, where we do a lazy unmount. If the process is uncleanly terminated,
then the mount entry remains and we get (Transport disconnected) error
on subsequent attempts to run quota list/limit-usage/remove commands.
Second issue, There is also a risk of inadvertent rm -rf on the
/var/run/gluster causing data loss for the user. Ideally, /var/run is
a temp path for application use and should not cause any data loss to
persistent storage.
Solution:
1) unmount the aux mount after each use.
2) clean stale mount before mounting, if any.
One caveat with doing mount/unmount on each command is that we cannot
use same mount point for both list and limit commands.
The reason for this is that list command needs mount to be accessible
in cli after response from glusterd, So it could be unmounted by a
limit command if executed in parallel (had we used same mount point)
Hence we use separate mount points for list and limit commands.
Change-Id: I4f9e39da2ac2b65941399bffb6440db8a6ba59d0
BUG: 1433906
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
Reviewed-on: https://review.gluster.org/16938
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <manikandancs333@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 62e4b5a11730fc0c73a12b6ca96483bbb63cc09c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu May 4 20:56:43 2017 +0530
snapview-server : Refresh the snapshot list during each reconnect
Currently we are refreshing the snapshot list either when there is
a request from glusterd or the very first initialization. But if
anything changed after when glusterd is down then there is no
mechanism to refresh the snashot dentries.
This patch will refresh snapshot list during each reconnect
Change-Id: I3ed655572d777f60d57dd479d190f75553591267
BUG: 1448150
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/17178
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit b61c5ab09105dd9493373b43998a83d52dc8970f
Author: N Balachandran <nbalacha@redhat.com>
Date: Sat May 6 20:01:16 2017 +0530
cluster/dht: Fix ret check
Fixed an incorrect return code check in the rebalance
code.
Change-Id: I60804ff121cec7a2f0419e2ee70dd22ea7533c0c
BUG: 1448640
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17197
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 3ad6b5464f31f6b3ac07bc3fd372fab523e983be
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Sun May 7 17:29:26 2017 +0800
rpc: use GF_ATOMIC_INC to generate rpc_clnt's callid
Change-Id: I57ad970411db1ccd3d2c56c504c7da9cc221051f
BUG: 1448692
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: https://review.gluster.org/17198
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 9b5285bb8aa8ad4c217105d8bca91f2e0f613c6d
Author: hari gowtham <hgowtham@redhat.com>
Date: Thu May 4 15:49:59 2017 +0530
Tier: Watermark check for hi and low value being equal
Problem: Both low and hi watermark can be set to same value
as the check missed the case for being equal.
Fix: Add the check to both the hi and low values being equal
along with the low value being higher than hi value.
Change-Id: Ia235163aeefdcb2a059e2e58a5cfd8fb7f1a4c64
BUG: 1447960
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/17175
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit b39d656d86a1096aa4d1695bc8d24610026eea03
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 16:40:12 2017 +0100
Fix ressources leak on error path
Coverty found a path where blk_fop is not freed, thus
leaking memory. The main cause is because we are using the
wrong variable for errors.
I do not think this is leaking anything in
practice, since the error condition seems quite rare, but
fixing this should remove around 15 coverty warning.
Change-Id: Ida0ea59f501f0a21bd1d8119aa1a299ce655add8
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16715
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 63ada909e0550632b9fdd7080b1d7daf14663e31
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Fri Mar 31 00:42:46 2017 +0800
coreutils: use coreutils instead of duplicate code
Change-Id: I0e442331d2bbb22ec18c37af87ab2a8852737c43
BUG: 1448265
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: https://review.gluster.org/16975
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit e61b78a2e9b7a6e7431a2d67eb00c599775eeb96
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed May 3 18:39:14 2017 +0530
gfapi: Fix few severe coverity issues
From https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-05-03-6484558c/html/
fixes coverity#189, 248, 250, 488, 546
Change-Id: I7c4aa5bf6c367344602748dfd736de27f341cca2
BUG: 789278
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: https://review.gluster.org/17161
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 65952509f78c9296ad3fc680c2677a5664f3da71
Author: Kaushal M <kaushal@redhat.com>
Date: Thu May 4 12:15:09 2017 +0530
rpc: Remove accidental IPV6 changes
They snuck in with the HALO patch (07cc8679c)
Change-Id: I8ced6cbb0b49554fc9d348c453d4d5da00f981f6
BUG: 1447953
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: https://review.gluster.org/17174
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit c8c7debdc106d79a350a90b0f9f09f77302fe2a6
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu May 4 12:26:26 2017 +0200
build: 'make cscope' requires generated .c and .h XDR files
When running 'make cscope' on a clean configured tree (before building
anything), it fails because of missing files unders rpc/xdr/src/. These
files are symlinked from generated files in the rpc/xdr/gen/ directory.
In order to create the symlinks for 'make cscope', a target needs to
specify how these symlinks are created.
Change-Id: I473c90e10d915ee438425cf0f806c0531b9f582a
BUG: 1447966
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17176
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 9c4b487ae806f7a83559971d7a146445e13db942
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed May 3 16:42:22 2017 +0530
glusterd: disallow rebalance & remove-brick on a sharded volume
Change-Id: Idfbdbc61ca18054fdbf7556f74e195a63cd8a554
BUG: 1447630
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17160
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit eff4cd7366de342c6d1f43ef88e2ae57248e721b
Author: Michael Scherer <misc@redhat.com>
Date: Wed May 3 16:54:46 2017 +0200
Remove double free
Since there is already GF_FREE (value) near the out label, this
one is uneeded. Found by coverity.
Change-Id: Ib4a4e1a6af186e14fc75e7578c79beb58de053ec
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/17165
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 2db599a873f2beec5ee9f1588d198e1c719f181b
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Wed May 3 18:33:40 2017 +0800
fd: We should use dict_set_uint64 to store fd->pid
Change-Id: I136372b9929d3ecf243649b6945571a67bfd80eb
BUG: 1447828
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: https://review.gluster.org/17172
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 5443e653cbc87c76b344bf85ad36e16427616279
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 22:47:02 2017 +0100
Refactor the code for posix_handle_pair
It was no longer compiling on Darwin, and triggered a cppcheck
error:
[xlators/storage/posix/src/posix-helpers.c:1097]: (error) Invalid number of character '{' when these macros are defined: 'GF_DARWIN_HOST_OS'.
Change-Id: I986609cc6cfc13ddea0ed35d7776736171f40a41
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16729
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 196beaa4e8b94b2d8f01b34254f7458ce3f531cc
Author: Michael Scherer <misc@redhat.com>
Date: Thu Feb 23 22:57:42 2017 +0100
mgmt: Fix null pointer deref
since "this" can be NULL, we should skip this
validation, there is another call to GF_VALIDATE_OR_GOTO
in the following lines. Found by cppcheck.
Change-Id: I329f50b986a9eaf3315e09f851080ab41bea57c0
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16742
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0dfd18a5355ef5655f79cb9e4d3a89f6ca1acdc7
Author: Michael Scherer <misc@redhat.com>
Date: Sun Feb 19 17:19:33 2017 +0100
Fix wrong operators
Coverty rightfully note that if we verify that
A =! C or A != B, it will always be true.
In one case, that prevent healing from continuing. In the other,
that trigger useless logs. Fixing this bug also show that
ENOSPC shouldn't abort the rebalance operation, as seen during
the review of the first patch on
https://review.gluster.org/#/c/16676/1/xlators/cluster/dht/src/dht-rebalance.c
Change-Id: I93c4df43b880b211da202a7e49cef6b1ce7ab68f
BUG: 1424817
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16676
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit f2e61c4db949b3b12972e205442375fe532c10b2
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Wed May 3 17:51:57 2017 +0800
server: fd should be refed before put into fdtable
If a network error occurs after we put a fd to fdtable,
fds in fdtable will be cleaned up by do_fd_cleanup which will
unref the fd and release the fd if the fd hasn't be refed by user.
Change-Id: Idbad0fafd005c59398518190845fe137cbf95c60
BUG: 1447609
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: https://review.gluster.org/17158
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 8a750b91e907b265c486da012a5baff255d8a38e
Author: Milind Changire <mchangir@redhat.com>
Date: Wed May 3 10:51:16 2017 +0530
rpc: fix transport add/remove race on port probing
Problem:
Spurious __gf_free() assertion failures seen all over the place with
header->magic being overwritten when running port probing tests with
'nmap'
Solution:
Fix sequence of:
1. add accept()ed socket connection fd to epoll set
2. add newly created rpc_transport_t object in RPCSVC service list
Correct sequence is #2 followed by #1.
Reason:
Adding new fd returned by accept() to epoll set causes an epoll_wait()
to return immediately with a POLLIN event. This races ahead to a readv()
which returms with errno:104 (Connection reset by peer) during port
probing using 'nmap'. The error is then handled by POLLERR code to
remove the new transport object from RPCSVC service list and later
unref and destroy the rpc transport object.
socket_server_event_handler() then catches up with registering the
unref'd/destroyed rpc transport object. This is later manifest as
assertion failures in __gf_free() with the header->magic field botched
due to invalid address references.
All this does not result in a Segmentation Fault since the address
space continues to be mapped into the process and pages still being
referenced elsewhere.
As a further note:
This race happens only in accept() codepath. Only in this codepath,
the notify will be referring to two transports:
1, listener transport and
2. newly accepted transport
All other notify refer to only one transport i.e., the transport/socket
on which the event is received. Since epoll is ONE_SHOT another event won't
arrive on the same socket till the current event is processed. However, in
the accept() codepath, the current event - ACCEPT - and the new event -
POLLIN/POLLER - arrive on two different sockets:
1. ACCEPT on listener socket and
2. POLLIN/POLLERR on newly registered socket.
Also, note that these two events are handled different thread contexts.
Cleanup:
Critical section in socket_server_event_handler() has been removed.
Instead, an additional ref on new_trans has been used to avoid ref/unref
race when notifying RPCSVC.
Change-Id: I4417924bc9e6277d24bd1a1c5bcb7445bcb226a3
BUG: 1438966
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/17139
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 7f566ec48130a51a8526f670fc22a31072cfd4df
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Mar 16 21:37:22 2016 +0530
SELinux : implementation of SELinux translator
The patch implement a part of SELinux translator to support setting
SELinux contexts on files in a glusterfs volume.
URL: https://github.com/gluster/glusterfs-specs/blob/master/accepted/SELinux-client-support.md
Change-Id: Id8916bd8e064ccf74ba86225ead95f86dc5a1a25
BUG: 1318100
Fixes : #55
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/13762
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <manikandancs333@gmail.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 06fada2c62ddf42f98e82bf51a78612160860582
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Apr 21 16:30:20 2017 +0530
gfapi/handleops: Introducing glfs_xreaddirplus_r() fop for handleops
Its known that readdirplus operation fetches stat as well for each of the
dirents. But often applications may need extra information, like for eg.,
NFS-Ganesha which operates on handles needs handles for each of those
dirents returned. So this would require extra calls to the backend, in this
case LOOKUP (which is very expensive operation) resulting in very low
readdir performance.
To address that introducing this new API using which applications can
make request for any extra information to be returned as part of
readdirplus response.
Currently this new api returns stat and handles as demanded by application.
The synopsis of the API is noted in glfs.h.
@todo:
* Enhance test script using this new API
Below were the perf results on single brick volume with and without
these changes -
Dataset used -
10*100 directories and each directory containing 100 empty files.
I used NFS-Ganesha application to test these changes -
>for i in {1..5}; do systemctl restart nfs-ganesha; sleep 10; mount -t nfs -o vers=4 localhost:/brick_vol /mnt; cd /mnt; echo "ITERATION$i"; date; find . > tmp-nfs.log; date; cd /; umount /mnt; sleep 2; done;
Without these changes -
ITERATION1
Mon Mar 20 17:22:26 IST 2017
Mon Mar 20 17:23:18 IST 2017
ITERATION2
Mon Mar 20 17:23:39 IST 2017
Mon Mar 20 17:24:28 IST 2017
ITERATION3
Mon Mar 20 17:24:49 IST 2017
Mon Mar 20 17:25:36 IST 2017
ITERATION4
Mon Mar 20 17:30:57 IST 2017
Mon Mar 20 17:31:37 IST 2017
ITERATION5
Mon Mar 20 17:31:57 IST 2017
Mon Mar 20 17:32:40 IST 2017
[root@dhcp35-197 /]#
On an average ~46.2 sec
With these changes applied -
ITERATION1
Mon Mar 20 17:35:03 IST 2017
Mon Mar 20 17:35:15 IST 2017
ITERATION2
Mon Mar 20 17:35:36 IST 2017
Mon Mar 20 17:35:46 IST 2017
ITERATION3
Mon Mar 20 17:36:06 IST 2017
Mon Mar 20 17:36:17 IST 2017
ITERATION4
Mon Mar 20 17:41:38 IST 2017
Mon Mar 20 17:41:49 IST 2017
ITERATION5
Mon Mar 20 17:42:10 IST 2017
Mon Mar 20 17:42:20 IST 2017
On an average ~10.8 sec
Updates #174
BUG: 1442950
Change-Id: I0f74f74dc62085ca4c4a23c38e3edc84bd850876
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: https://review.gluster.org/15663
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit eb8c6936992bf31fa74cf82fddd3ec40c88cea37
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue May 2 11:46:11 2017 +0530
glusterd: skip nfs svc reconfigure if nfs xlator is not installed
With 83abcba, nfs svc is not (re)started or stopped if NFS so file is
not installed. However the same check was missing in nfs svc reconfigure
which was causing all volume set command to fail.
Change-Id: Ie87b5dba44ac59e890cbd60f85944f8e685ad52b
BUG: 1326219
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17149
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 81966fdb5548be4e351c22bec1a35527e976fbb7
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Apr 21 18:36:58 2017 +0200
nl-cache: free nlc_conf_t in fini()
The (xlator_t*)->private structure in negative-lookup-cache is allocated
in the init() function of the xlator, but never free'd. Valgrind
detected this as:
656 bytes in 1 blocks are definitely lost in loss record X of Y
at 0x..+ calloc (/builddir/build/BUILD/valgrind-3.11.0/coregrind/m_replacemalloc/vg_replace_malloc.c:711)
by 0x.. __gf_calloc (/usr/src/debug/glusterfs-3.11dev/libglusterfs/src/mem-pool.c:117)
by 0x.. init (/usr/src/debug/glusterfs-3.11dev/xlators/performance/nl-cache/src/nl-cache.c:669)
by 0x.. __xlator_init (/usr/src/debug/glusterfs-3.11dev/libglusterfs/src/xlator.c:472)
by 0x.. xlator_init (/usr/src/debug/glusterfs-3.11dev/libglusterfs/src/xlator.c:498)
by 0x.. glusterfs_graph_init (/usr/src/debug/glusterfs-3.11dev/libglusterfs/src/graph.c:321)
by 0x.. glusterfs_graph_activate (/usr/src/debug/glusterfs-3.11dev/libglusterfs/src/graph.c:693)
by 0x.. glfs_process_volfp (/usr/src/debug/glusterfs-3.11dev/api/src/glfs-mgmt.c:79)
by 0x.. glfs_volumes_init (/usr/src/debug/glusterfs-3.11dev/api/src/glfs.c:160)
by 0x.. glfs_init_common (/usr/src/debug/glusterfs-3.11dev/api/src/glfs.c:868)
by 0x.. glfs_init@@GFAPI_3.4.0 (/usr/src/debug/glusterfs-3.11dev/api/src/glfs.c:913)
by 0x.. main (/root/gluster-debug/gfapi-load-volfile/gfapi-load-volfile.c:54)
When the xlators is unloaded, it should free the resources it allocated.
This can easily be done in the fini() function.
Change-Id: I079e78cc207145bc542e2282fc4cf2bb4dadc28a
BUG: 1442569
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17143
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit e31f75cb0e8dbea1cff5de9bca4270ec8639d1bb
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Fri Apr 28 05:45:16 2017 -0400
api: fix typo of glfs_upcall_get_event
glfs_upcall_inode_get_event is not exist.
Change-Id: I27bd7eb9bf99d3289ae12fe31405d3b46855152d
BUG: 1447116
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Reviewed-on: https://review.gluster.org/17135
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ca101390c055f94c6d566d435c1d3bb333e3805f
Author: Kevin Vigor <kvigor@fb.com>
Date: Tue Mar 21 08:23:25 2017 -0700
Halo Replication feature for AFR translator
Summary:
Halo Geo-replication is a feature which allows Gluster or NFS clients to write
locally to their region (as defined by a latency "halo" or threshold if you
like), and have their writes asynchronously propagate from their origin to the
rest of the cluster. Clients can also write synchronously to the cluster
simply by specifying a halo-latency which is very large (e.g. 10seconds) which
will include all bricks.
In other words, it allows clients to decide at mount time if they desire
synchronous or asynchronous IO into a cluster and the cluster can support both
of these modes to any number of clients simultaneously.
There are a few new volume options due to this feature:
halo-shd-latency: The threshold below which self-heal daemons will
consider children (bricks) connected.
halo-nfsd-latency: The threshold below which NFS daemons will consider
children (bricks) connected.
halo-latency: The threshold below which all other clients will
consider children (bricks) connected.
halo-min-replicas: The minimum number of replicas which are to
be enforced regardless of latency specified in the above 3 options.
If the number of children falls below this threshold the next
best (chosen by latency) shall be swapped in.
New FUSE mount options:
halo-latency & halo-min-replicas: As descripted above.
This feature combined with multi-threaded SHD support (D1271745) results in
some pretty cool geo-replication possibilities.
Operational Notes:
- Global consistency is gaurenteed for synchronous clients, this is provided by
the existing entry-locking mechanism.
- Asynchronous clients on the other hand and merely consistent to their region.
Writes & deletes will be protected via entry-locks as usual preventing
concurrent writes into files which are undergoing replication. Read operations
on the other hand should never block.
- Writes are allowed from _any_ region and propagated from the origin to all
other regions. The take away from this is care should be taken to ensure
multiple writers do not write the same files resulting in a gfid split-brain
which will require resolution via split-brain policies (majority, mtime &
size). Recommended method for preventing this is using the nfs-auth feature to
define which region for each share has RW permissions, tiers not in the origin
region should have RO perms.
TODO:
- Synchronous clients (including the SHD) should choose clients from their own
region as preferred sources for reads. Most of the plumbing is in place for
this via the child_latency array.
- Better GFID split brain handling & better dent type split brain handling
(i.e. create a trash can and move the offending files into it).
- Tagging in addition to latency as a means of defining which children you wish
to synchronously write to
Test Plan:
- The usual suspects, clang, gcc w/ address sanitizer & valgrind
- Prove tests
Reviewers: jackl, dph, cjh, meyering
Reviewed By: meyering
Subscribers: ethanr
Differential Revision: https://phabricator.fb.com/D1272053
Tasks: 4117827
Change-Id: I694a9ab429722da538da171ec528406e77b5e6d1
BUG: 1428061
Signed-off-by: Kevin Vigor <kvigor@fb.com>
Reviewed-on: http://review.gluster.org/16099
Reviewed-on: https://review.gluster.org/16177
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit f6f2ee90aee337e90b3e31bfd40db681c457fab2
Author: Shyamsundar Ranganathan <srangana@redhat.com>
Date: Mon May 1 17:22:34 2017 +0000
Revert "contrib/timerwheel: probable bug on 32-bit, use __builtin_ffs()"
This reverts commit c92b8347aea8ce78ca3fbc49b88f5adadc98509b.
Commit is not ready for a merge!
Change-Id: I3b3b52f7bfb4781dd42160e2b1059b4cdeb17956
Reviewed-on: https://review.gluster.org/17147
Tested-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 739fc753aacc401869ef9b8aab7098aa0e139aa9
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Sun Apr 30 18:59:17 2017 -0400
contrib/timerwheel: probable bug on 32-bit, use __builtin_ffs()
Simply always defining BITS_PER_LONG as 64 seems like it's almost
certainly wrong on 32-bit platforms and could potentially result in
incorrect results.
fls and, e.g., __builtin_ffs() return the same answer for any given
input, making it seem like the name fls (find last set) is a misnomer
and ffs (find first set, starting from the lsb) is the more accurate
name.
Using __builtin_ffs() causes the compiler (in intel) to emit code
with the bsf (bit scan forward) insn, which is approx 3x faster than
the code in ffs(), at least on the machine I tried it on. (Even so,
it takes 10M+ iterations for the speed difference to be measurable.
Choosing the "faster" implementation seems like a no-brainer, even
if there may not be any significant gain by doing so.)
Change-Id: I1616dda1a5b76f208ba737a713877c1673131e33
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17142
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 91d7cb50263c789d0f0d23ce10623e3a33bce0f6
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 17 15:50:07 2017 +0530
core: make the per glusterfs_ctx_t timer-wheel refcounted
xlators can use a 'global' timer-wheel for scheduling events. This
timer-wheel is managed per glusterfs_ctx_t, but does not need to be
allocated for every graph. When an xlator wants to use the timer-wheel,
it will be instanciated on demand, and provided to xlators that request
it later on.
By adding a reference counter to the glusterfs_ctx_t for the
timer-wheel, the threads and structures can be cleaned up when the last
xlator does not have a need for it anymore. In general, the xlators
request the timer-wheel in init(), and they should return it in fini().
Because the timer-wheel is managed per glusterfs_ctx_t, the functions
can be added to ctx.c and do not need to live in their very minimal
tw.[ch] files.
Change-Id: I19d225b39aaa272d9005ba7adc3104c3764f1572
BUG: 1442788
Reported-by: Poornima G <pgurusid@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17068
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit e45a60240be2100c638df226bfb79ee902ceed7c
Author: Brian Foster <bfoster@redhat.com>
Date: Thu Jan 2 14:03:18 2014 -0500
extras/hook-scripts: SELinux brick file context management scripts
The SELinux policy for gluster defines the glusterd_brick_t type to
support server side SELinux (e.g., server side labels). Add
convenience hook scripts that users/packagers can install to ensure
that new bricks are labeled correctly.
The volume create hook script adds a new SELinux file context for
each brick path and runs a restorecon to label the brick. The
volume delete hook removes the per-brick SELinux file context.
Change-Id: I5f102db5382d813c4d822ff74e873a7a669b41db
BUG: 1047975
Signed-off-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: https://review.gluster.org/6630
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 6afbffa2260a67a133d3948183b30d8b643e8ddf
Author: Jeff Darcy <jdarcy@fb.com>
Date: Fri Apr 28 14:19:27 2017 -0700
tests: fix typo
I've been staring at this for ages, and it finally got to me.
Change-Id: I472dc2b2cf3ab175014ed673d73b543aa3e14d14
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17140
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 57d21c0e809dee3c30174f7d9d52585b6f465b93
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Jan 17 17:23:52 2017 +0100
fuse: enhance fusedump to include timestamp and a signature
(Also referred to as "fusedump v2".)
Change-Id: I837944024efd1b9055c2f5f91bd5723ef350e688
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: https://review.gluster.org/16422
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 10e69eb628ab9759bfc59e9a26c78bf202fc5dfe
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Apr 20 10:17:07 2017 +0530
mount/fuse: Replace GF_LOG_OCCASIONALLY with gf_log() to report fop failure at all times
Change-Id: Ibd8e1c6172812951092ff6097ba4bed943051b7c
BUG: 1440051
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17086
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit e84fc53e33ce79a25c89bd4dc4ba57ef45e521da
Author: Susant Palai <spalai@redhat.com>
Date: Wed Mar 22 17:14:25 2017 +0530
cluster/dht: Make rebalance throttle option tuned by number
Current rebalance throttle options: lazy/normal/aggressive may not always be
sufficient for the purpose of throttling. In our recent test, we observed for
certain setups, normal and aggressive modes behaved similarly consuming full
disk bandwidth. So in cases like this admin should be able to tune it
down(or vice versa) depending on the need.
Along with old throttle configurations, thread counts are tuned based on number.
e.g. gluster v set vol-name cluster-rebal.throttle 5.
Admin can tune up/down between 0 and the number of cores available.
Note: For heterogenous servers, validation will fail on the old server if "number"
is given for throttle configuration.
The message looks something like this:
"volume set: failed: Staging failed on vm2. Error: cluster.rebal-throttle should be {lazy|normal|aggressive}"
Test: Manual test by logging active thread number after reconfiguring throttle option.
testcase: tests/basic/distribute/throttle-rebal.t
Change-Id: I46e3cde546900307831028b344ecf601fd9b02c3
BUG: 1438370
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/16980
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 57ef498e0608b985b49abbf312d37e0e17db96e8
Author: Susant Palai <spalai@redhat.com>
Date: Wed Jan 11 16:04:47 2017 +0530
dht: send lookup on old name inside rename with bname and pargfid
Inside rename, a lookup is done on the source name to make sure that
the file is there. But we used to do a gfid based lookup and hence,
even if the source name was renamed to a new name from some other client,
lookup will be successful as server3_3_lookup will fetch the new path
based on the gfid.
So even if the source file does not exist any more rename will carry on,
and as server3_3_link(destination is hashed to a different brick other
than source cached scenario) also does gfid based resolve, it wont
detect that the source name does not exist and hardlink creation will be
successful (since gfid based resolve will get the new dentry).
To solve this problem, do a name based lookup inside rename. So that
rename will fail right away if the source does not exist.
Change-Id: Ieba8bdd6675088dbf18de90ed4622df043d163bd
BUG: 1412135
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/16375
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 30e4b8dac89432d2dcb8e5ff77179dd98b3bbe95
Author: Susant Palai <spalai@redhat.com>
Date: Tue Jan 10 16:11:50 2017 +0530
cluster/dht: rebalance perf enhancement
Problem: Throttle settings "normal" and "aggressive" for rebalance
did not have performance difference.
normal mode spawns $(no. of cores - 4)/2 threads and aggressive
spawns $(no. of cores - 4) threads. Though aggressive mode has twice
the number of threads compared to that of normal mode, there was no
performance gain when switched to aggressive mode from normal mode.
RCA:
During the course of debugging the above problem, we tried assigning
migration job to migration threads spawned by rebalance, rather than
synctasks(as there is more overhead associated to manage the task
queue and threads). This gave us a significant improvement over rebalance
under synctasks. This patch does not really gurantee that there will be a
clear performance difference between normal and aggressive mode, but this
patch certainly maximized the disk utilization for 1GBfiles run.
Results:
Test enviroment:
Gluster Config:
Number of Bricks: 2 (one brick per disk(RAID-6 12 disk))
Bricks:
Brick1: server1:/brick/test1/1
Brick2: server2:/brick/test1/1
Options Reconfigured:
performance.readdir-ahead: on
server.event-threads: 4
client.event-threads: 4
1000 files with 1GB each were created/renamed such that all files will have
server1 as cached and server2 as hashed, so that all files will be migrated.
Test machines had 24 cores each.
Results with/without synctask based migration:
-----------------------------------------------
mode normal(10threads) aggressive(20threads)
timetaken 0:55:30 (h:m:s) 0:56:3 (h:m:s)
withsynctask
timetaken
with migrator 0:38:3 (h:m:s) 0:23:41 (h:m:s)
threads
From above table it can be seen that, there is a clear 2x perf gain between
rebalance with synctask vs rebalance with migrator threads.
Additionally this patch modifies the code so that caller will have the exact error
number returned by dht_migrate_file(earlier the errno meaning was overloaded). This
will help avoiding scenarios where migration failure due to ENOENT, can result in
rebalance abort/failure.
Change-Id: I8904e2fb147419d4a51c1267be11a08ffd52168e
BUG: 1420166
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/16427
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 10b9a952da98fcaefb2df4537ee98a1d5d628296
Author: Kinglong Mee <mijinlong@open-fs.com>
Date: Tue Apr 25 08:20:28 2017 -0400
api: fix two typos of GFAPI_PUBLIC function define
Change-Id: I2f9915b3572c4cbce6748e99a037daba439a187e
BUG: 1446273
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Reviewed-on: https://review.gluster.org/17112
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 7645a503e6fc72f6df705d32e050a5d543fbb497
Author: Prashanth Pai <ppai@redhat.com>
Date: Thu Apr 27 18:26:02 2017 +0530
glusterd: Fix removing pmap entry on rpc disconnect
Problem:
The following line of code intended to remove pmap entry for the
connection during disconnects:
pmap_registry_remove (this, 0, NULL, GF_PMAP_PORT_NONE, xprt);
However, no pmap entry will have it's type set to GF_PMAP_PORT_NONE
at any point in time. So a call to pmap_registry_search_by_xprt() in
pmap_registry_remove() will always fail to find a match.
Fix:
Optionally ignore pmap entry's type in pmap_registry_search_by_xprt().
BUG: 1193929
Change-Id: I705f101739ab1647ff52a92820d478354407264a
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: https://review.gluster.org/17129
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit c6fd52115fc90b499bda2288dca1f121d303ac1c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Mar 27 16:09:56 2017 -0400
build: conditionally build legacy gNFS server and associated sub-packaging
Plus some additional logic in glusterd to ensure gnfs (glusterfs)
daemons are never started if server/nfs xlator is not installed.
As a service, nfs is still initialized. The glusterfs-gnfs RPM
may be installed or uninstalled independent of anything else,
including on a system where gluster is actively running, so the
existence of the xlator is always tested before trying to start
gnfs.
Change-Id: I56743ad1cb36a84917226d7d26cb9d015d441e66
BUG: 1326219
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16958
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 5501dd5d0893dc7ff69aeeeab84e25c04ee95c1c
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Apr 27 11:53:24 2017 +0530
cluster/dht: Pass the correct xdata in fremovexattr fop
Change-Id: Id84bc87e48f435573eba3b24d3fb3c411fd2445d
BUG: 1440051
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17126
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 7d11fef12140f9c1db2b56f9d2487319ddfa720b
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Jan 3 15:26:30 2017 +0100
fuse: clean up mount flag processing
In general, when one invokes a mount helper program -- basically
anything that mounts something based on its command line, so thinking of
mount(8), mount.<fs-type> or fusermount, but also of FUSE servers in
general, including glusterfs -- the command line arguments that are to
affect mount(2) are mapped to a bitmask called the mount flags, which is
passed to mount(2), so that the kernel can interpret the flag bits and
adjusts properties of the mount accordingly.
There is a traditional syntax for this mechanism as implemented in
mount(8): one passes "-ocomma,separated,mount,options" and the
individual option name strings are mapped to flag bits in mount(8).
FUSE further explores this idea and typically the FUSE server command
lines allow further option names to be used in the "-ooption,name,list"
which are then separated from the kernel sanctioned option names (to
which we'll refer as "system mount options") and are passed to a
platform specific lower level fuse mount helper interface.
The separation of system mount option names and FUSE specific option
names is also platform specific, so the general mount interface
function, which in case of glusterfs is gf_fuse_mount(), should abstract
this away.
Therefore we change the signature of this function from
int gf_fuse_mount (const char *mountpoint, char *fsname,
unsigned long mountflags, char *mnt_param,
pid_t *mtab_pid, int status_fd);
to
int gf_fuse_mount (const char *mountpoint, char *fsname,
char *mnt_param, pid_t *mtab_pid,
int status_fd);
and deal with flag extraction in platform specific mount code. Note that
the sole purpose of the mountflags argument was to indicate read-only
mounting. The other system mount option names were expected to reside in
the comma-separated mnt_param string, but they were not properly
processed (see the referred BUG). With the new gf_fuse_mount signature
read-only mounting is to be indicated as a "ro" component in mnt_param.
- For Darwin, which has a dedicated, separate gf_fuse_mount
implementation, gf_fuse_mount was ignoring mountflags, so only the
signature had to to be adjusted. However, as bonus, we gain read-only
support for Darwin, which was missing so far, given that it was
indicated via the ignored mountflags. Darwin's low level mount helper
relies on the "ro" component of the option string, which agrees with
the new calling convention of gf_fuse_mount.
- On Linux, system mount option name handling (apart from the
distinguished read-only option) used to have the inadvertent side
effect of adding "nosuid,nodev" as indicated in BUG; since
Ia89d975d1e27fcfa5ab2036ba546aa8fa0d2d1b0 this side effect is removed,
but system mount option name handling was left broken (passing system
mount options other than "ro" fails to mount).
- On other platforms, system mount option name handling is broken
(expect for the distinguished read-only option).
As of this change, in the general (non-Darwin) implementation of
gf_fuse_mount we take care of proper separation of system mount names
and their conversion to mount flags. For Linux, we adopt the conversion
table from FUSE upstream. For other systems we just provide a best
effort to support those system mount options which are understood across
all Unices (nosuid,nodev,noatime,noexec,ro). (This can be improved later
to provide proper plaform support.)
BUG: 1297182
Change-Id: I5d10b5df46feba7a02bf5bf1018db69e6b52260a
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: https://review.gluster.org/16313
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
commit 6a3813b51888c1e48d723acf3bd561f07fde64a4
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Apr 27 14:34:08 2017 +0530
extras/hooks: Use double quotes while using [..]
This avoids the following warning when first operand is null
[: =: unary operator expected
Change-Id: I5439d8f60a6d9e30e6ba04c16c3de2096a87c38f
BUG: 1446126
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: https://review.gluster.org/17127
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 82473b5b2e8bf9d31eaa264adf3ddcd6f5aac60b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Apr 26 08:11:56 2017 -0400
packaging: /var/run/gluster owner gluster:gluster(0775) for statedumps
gfapi has the ability to take statedumps. However, if the application
using gfapi isn't running with root privs the statedump file can't be
written to the default location, i.e. /var/run/gluster.
Change-Id: I97d8919ef8b8cd4775e1a206f939a2bf0046786d
BUG: 1445569
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17122
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit e7564fafe09e06a4032045fc4becf2414da6ebca
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Apr 21 19:11:24 2017 +0200
build: ensure autoconf template expansions resolve variables
Make sure the following autotools managed variables:
GLUSTERFS_LIBEXECDIR
GLUSTERD_MISCDIR
GLUSTERD_VOLFILE
LOCALSTATEDIR
get expanded to literal paths when the configure
script generates the installed versions of certain
text files from *.in templates.
This change is partly implemented by restoring some of
the "eval echo $variable" style forced expansions in
configure that were removed in
If5219cadc51ae316f7ba2e2831d739235c77902d.
BUG: 1444228
Change-Id: I3b31b1259c5101252bbc37861683894e6eae29e6
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: https://review.gluster.org/17096
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 787582f720fdbcf73c40f9833e2845a9f737e63b
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Mar 17 13:14:51 2017 +0530
libglusterfs/stack.h: reduce duplication of code
* Use STACK_UNWIND_STRICT everywhere.
* Provide STACK_WIND_COMMON as both STACK_WIND_COOKIE
and STACK_WIND differ by just 1 line and 1 option.
Updates gluster/glusterfs#137
Change-Id: Ifbb6b9c4702b02f4a02834824f509fd10c78f0ce
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/16915
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit c47426b2fca84a9b8f5e6213cd4fa4612d64bb72
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Mar 9 13:31:44 2017 +0530
cluster/dht: Document detailing transactions in dht
Change-Id: If69d67ce5dffe966fbc1e4ad834ca110e1e0b745
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: #191
Reviewed-on: https://review.gluster.org/16876
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit a6e9db58aaa8b434c4895a2802ddb4b8c471b806
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Apr 20 02:08:32 2017 -0400
io-stats: fix some memory leak after fini
Change-Id: Id057b711d7f615c6d2db1ebbca2f17d0afacb2ae
BUG: 1444023
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Reviewed-on: https://review.gluster.org/17089
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0ca14b44b3ca356d513394c711397e26cfa273b2
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Apr 7 06:19:30 2017 -0400
geo-rep: Fix mount cleanup
On corner cases, mount cleanup might cause
worker crash. Fixing the same.
Change-Id: I38c0af51d10673765cdb37bc5b17bb37efd043b8
BUG: 1433506
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17015
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 3e757dcba9da180f11aac6bceec2ae904d135bd8
Author: Richard Wareing <rwareing@fb.com>
Date: Mon Sep 22 17:42:04 2014 -0700
nfs: Check for null buf, and set op_errno to EIO not 0
Summary:
- Prevent crashes for the case where "getattr" actually failed and
returned with a NULL buf, but the op_errno was set to 0.
- This is a cherry-pick of D1571184
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Change-Id: Ia2d6ad7539df714f9420dcf063c7c14e727bb7e3
BUG: 1428064
Reviewed-on: http://review.gluster.org/16152
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kevin Vigor <kvigor@fb.com>
Reviewed-on: https://review.gluster.org/16803
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit e8b8ee842fb19376f1b9b2cd74d3b828cf5e2d83
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Fri Feb 26 20:59:00 2016 -0800
nfs: Tear down transports for requests that arrive before the volume is initialized
Summary:
- Disconnects RPC transports for requests that cannot be serviced
because volumes are not ready.
- This is a cherry-pick of D2991403
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Change-Id: I07ff0795b81d25624541ff981b5f2586d078e9a6
BUG: 1428068
Reviewed-on: http://review.gluster.org/16154
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kevin Vigor <kvigor@fb.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-on: https://review.gluster.org/16805
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit e06f64013178af905f53e0d7996744816ce09ddf
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Apr 20 02:13:27 2017 -0400
api: free the xattr data after using in glfs_volfile_fetch
Change-Id: I89a7df93039e367301fd70df722c13f1d8b3484b
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Reviewed-on: https://review.gluster.org/17091
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 8c5620fa42df8aacf5d4917fe556ef3b31e7df4f
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Apr 26 10:24:40 2017 +0530
cluster/dht Remove redundant logs in dht rmdir
Removing redundant logs were introduced in
https://review.gluster.org/#/c/17065/
Change-Id: I0d6055488b51a13c91d2121e87f653cdb94888b0
BUG: 1445590
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17118
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Susant Palai <spalai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit bf7f5b5b281ff1656d05235d99ccc45ab15fcb7a
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Apr 25 15:04:34 2017 +0530
nl-cache: Fix the issue in refd_inode counting and prune the cache
Change-Id: I5b9beb8502667bc3876385900bc01b6491348716
BUG: 1442569
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17110
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit aef11092ef54f68f01e6821656d05b0a2a248a39
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jan 3 02:35:06 2017 -0500
feature/dht: Directory synchronization
Design doc: https://review.gluster.org/16876
Directory creation is now synchronized with blocking inodelk of the
parent on the hashed subvolume followed by the entrylk on the hashed
subvolume between dht_mkdir, dht_rmdir, dht_rename_dir and lookup
selfheal mkdir.
To maintain internal consistency of directories across all subvols of
dht, we need locks. Specifically we are interested in:
1. Consistency of layout of a directory. Only one writer should modify
the layout at a time. A writer (layout setting during directory heal
as part of lookup) shouldn't modify the layout while there are
readers (all other fops like create, mkdir etc., which consume
layout) and readers shouldn't read the layout while a writer is in
progress. Readers can read the layout simultaneously. Writer takes
a WRITE inodelk on the directory (whose layout is being modified)
across ALL subvols. Reader takes a READ inodelk on the directory
(whose layout is being read) on ANY subvol.
2. Consistency of directory namespace across subvols. The path and
associated gfid should be same on all subvols. A gfid should not be
associated with more than one path on any subvol. All fops that can
change directory names (mkdir, rmdir, renamedir, directory creation
phase in lookup-heal) takes an entrylk on hashed subvol of the
directory.
NOTE1: In point 2 above, since dht takes entrylk on hashed subvol of a
directory, the transaction itself is a consumer of layout on
parent directory. So, the transaction is a reader of parent
layout and does an inodelk on parent directory just like any
other layout reader. So a mkdir (dir/subdir) would:
> Acquire a READ inodelk on "dir" on any subvol.
> Acquire an entrylk (dir, "subdir") on hashed subvol of "subdir".
> creates directory on hashed subvol and possibly on non-hashed subvols.
> UNLOCK (entrylk)
> UNLOCK (inodelk)
NOTE2: mkdir fop while setting the layout of the directory being created
is considered as a reader, but NOT a writer. The reason is for
a fop which can consume the layout of a directory to come either
of the following conditions has to be true:
> mkdir syscall from application has to complete. In this case no
need of synchronization.
> A lookup issued on the directory racing with mkdir has to complete.
Since layout setting by a lookup is considered as a writer, only
one of either mkdir or lookup will set the layout.
Code re-organization:
All the lock related routines are moved to "dht-lock.c" file.
New wrapper function is introduced to take blocking inodelk
followed by entrylk 'dht_protect_namespace'
Updates #191
Change-Id: I01569094dfbe1852de6f586475be79c1ba965a31
Signed-off-by: Kotresh HR <khiremat@redhat.com>
BUG: 1443373
Reviewed-on: https://review.gluster.org/15472
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 474621edc7dd8d7b9002fa3ba9929afdccdbb6f7
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Feb 27 18:45:16 2017 -0800
libglusterfs: accept random volname in glusterfs_graph_prepare()
When the call to glfs_new("volname") passes a name for the volume and it
does not match the name of the subvolume in the graph, glfs_init() will
fail. This is easily reproducible by a gfapi program that loads the
volume from a .vol file, and not from a GlusterD server.
Change-Id: I33e77fbee7d12eaefe7c384fad6aecfa3582ea5a
BUG: 1425623
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16796
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit fc0c1dca7e63364f3477fe4d3b992505941b4dfb
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Feb 21 14:35:52 2017 +0100
debug/sink: add xlator to aid in resource leak debugging
This new xlator does not allocate any resources on init(). This makes it
a good option to use for debugging xlator releated resources leaks on
fini().
By putting the sink xlator as single xlator in a .vol file, and loading
it through gfapi, we can investigate the resource leaks that are
happening through gfapi (and the Gluster core). By extending the .vol
file with additional xlators, it is possible to analyze resource leaks
of single xlators.
Change-Id: Idb5faa861b623dd5b2a988b181e669b0d52c2a0e
BUG: 1425623
Fixes: #176
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16806
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit b3d8cde71ebe412fd3c5e7428ae8b78e0dfc8507
Author: Susant Palai <spalai@redhat.com>
Date: Mon Apr 24 16:27:23 2017 +0530
cluster/dht: correct space check for rebalance
With rebalance doing fallocate on destination, we don't need to
add file size to the "destination available space" to decide whether
to migrate the file or not.
Notes: Fallocate would have already occupied the file size space on
destination
Change-Id: If7f6a6654e6257726680cf20d618482a6e9095a6
BUG: 1441508
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/17104
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 9d86bee6e94adba643f7dd759ee1a0ca6f0399aa
Author: karthik-us <ksubrahm@redhat.com>
Date: Tue Mar 14 13:17:11 2017 +0530
cli: Adding warning message while creating a replica 2 volume
Warn the CLI about ending up in split-brain situation with a
replica 2 volume. Display arbiter and replica 3 are recommended
option to avoid this and point to the document on split-brain
and ways to deal with it.
Change-Id: I7f31f3c74818d440a684b3130bc5ccdc72258f01
BUG: 1431963
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: https://review.gluster.org/16899
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 80407b1f390bd2d1ebdac2592dac526deada0856
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Apr 20 02:14:28 2017 -0400
api: fix bad release of dict causes memory leak
Change-Id: Ic7169fd05aff7bf46108e8ac7b1f29688a7f2358
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Reviewed-on: https://review.gluster.org/17092
Tested-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit db53d16b7fb12bcd36cfb7bcc8c66cd7a64f8a1e
Author: Jungyeon Yoon <jungyeon.yoon@gmail.com>
Date: Tue Apr 25 15:23:32 2017 +0900
remove redundant function definition
function definition is duplicated
erase second sys_ftruncate() definition
No test cases
Change-Id: I3eead1380b527b8b0e480f45b39e0c4bc9b2b92a
Signed-off-by: Jungyeon Yoon <jungyeon.yoon@gmail.com>
Reviewed-on: https://review.gluster.org/17106
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit c277f84776069deeb5df25ffbff39cf0896b37c6
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Apr 21 19:43:08 2017 +0200
build: correct bogus date in RPM spec
In the RPM spec changelog there is an entry
wth the following date:
Wed Feb 7 2017
However, Feb 7 2017 was Tuesday. In this change
we correct the day of the date.
BUG: 1444941
Change-Id: I073bfe878e0a21d446a80c2f4ee045facba3e82b
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: https://review.gluster.org/17100
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fd073550dbc12c99e854ef3bfca3ba89589a101c
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Thu Apr 20 12:24:51 2017 +0530
cluster/ec: Implement self-heal-window_size option
Fix implements the heal window size option for
EC. This option control the maximum size of
read/write operation carried out in self-heal
process.
BUG: 1441491
Change-Id: I6c0ef65c9ca18b0828f91b319d4f52ac5b77d0d8
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
Reviewed-on: https://review.gluster.org/17098
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit c76664162ec807a9ba49e2021466706c8e51d915
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Apr 20 07:18:52 2017 -0400
glusterd/geo-rep: Fix snapshot create in geo-rep setup
glusterd persists geo-rep sessions in glusterd
info file which is represented by dictionary
'volinfo->gsync_slaves' in memory. Glusterd also
maintains in memory active geo-rep sessions in
dictionary 'volinfo->gsync_active_slaves' whose key
is "<slave_url>::<slavhost>".
When glusterd is restarted while the geo-rep sessions
are active, it builds the 'volinfo->gsync_active_slaves'
from persisted glusterd info file. Since slave volume
uuid is added to "voinfo->gsync_slaves" with the commit
"http://review.gluster.org/13111", it builds it with key
"<slave_url>::<slavehost>:<slavevol_uuid>" which is
wrong. So during snapshot pre-validation which checks
whether geo-rep is active or not, it always says it is
ACTIVE, as geo-rep stop would not deleted this key.
Fixed the same in this patch.
Change-Id: I185178910b4b8a62e66aba406d88d12fabc5c122
BUG: 1443977
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17093
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 8c7ea9254e18569640187163f323570838eba98d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Apr 20 10:08:02 2017 +0530
cluster/dht: Pass the req dict instead of NULL in dht_attr2()
This bug was causing VMs to pause during rebalance. When qemu winds
down a STAT, shard fills the trusted.glusterfs.shard.file-size attribute
in the req dict which DHT doesn't wind its STAT fop with upon detecting
the file has undergone migration. As a result shard doesn't find the
value to this key in the unwind path, causing it to fail the STAT
with EINVAL.
Also, the same bug exists in other fops too, which is also fixed in
this patch.
Change-Id: Id7823fd932b4e5a9b8779ebb2b612a399c0ef5f0
BUG: 1440051
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17085
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1f56e58b59c15982852ec26502229be2b821bea7
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Apr 20 09:46:46 2017 -0400
packaging: no firewalld-filesystem before el7.3
Attempting to build on RHEL or CentOS 7.2 will fail because there is
no firewalld-filesystem RPM. (This probably holds true for older versions
of Fedora too, although the versions where this would apply are so old
and so far gone as to be (nearly) meaningless.
The firewalld rpm in 7.3 has a Requires: firewalld-filesystem.
In addition to other things, the firewalld-filesystem rpm provides rpm
build time macros (a strange place for them actually, there ought to be
a firewalld-devel subpackage instead).
Florian Festi, one of the Fedora RPM/YUM/DNF devs, strongly suggests
that even in 7.3 the correct way to get firewalld-filesystem is to use
BuildRequires: firewalld.
N.B. That someone might try to install 7.3-built RPMs on their 7.2 system
is beside the point.
Change-Id: Iac8cc74a3345acaaed45af4c14e141b7a1711f84
BUG: 1443959
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/17094
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 46a69e62fd399dd03800659ae967dc6b4fae0fea
Author: Kinglong Mee <kinglongmee@gmail.com>
Date: Thu Apr 20 02:12:42 2017 -0400
api: free all dynamic memory returned from xdr_to_generic
Change-Id: I01235ffca80683e69e99da09a9fc1a6d3ffdcb65
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Reviewed-on: https://review.gluster.org/17090
Tested-by: Poornima G <pgurusid@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 40c450a269ba490bda7a9ebb730749d5843dca4e
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Mon Apr 17 10:06:20 2017 +0800
debug/error-gen: Use STACK_WIND_TAIL instead of STACK_WIND
Also remove unnecessary fop cbks, which are no longer necessary.
1.We don't need to call STACK_WIND if we care nothing in cbk stack, so
I use STACK_WIND_TAIL instead of STACK_WIND without new a frame
2.Fix several indent problems
3.Fix return value issues in init and reconfigure
Change-Id: Id57a68fec39b5b47cd4ff77664399ed3ef1d3888
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: https://review.gluster.org/17062
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 291342f15bb8811aeef8a9eaa17d94622a563aa5
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Apr 17 15:21:20 2017 +0530
cluster/dht: rm -rf fails if dir has stale linkto files
rm -rf <dir> fails with ENOENT if dir contains a lot of
stale linkto files. This is because a single
readdirp is sent as part of the rmdir which would return
and delete only as many linkto files on the bricks as would fit
in one readdirp buffer. Running rm -rf <dir> multiple times
will eventually delete all the files. The fix sends readdirp
on each subvol until no more entries are returned.
Change-Id: I447f2d193de4bd8ac16e4541c6b919d22250e39e
BUG: 1442724
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/17065
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit e65093fc3121503967d8edfa463cd56dcdd0e764
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Mar 9 18:08:28 2017 +0530
cluster/afr: GFID split brain resolution with favorite-child-policy
Problem:
Currently the automatic split brain resolution with favorite child policy
is not resolving the GFID split brains.
Fix:
When there is a GFID split brain and the favorite child policy is set to
size/mtime/ctime/majority, based on the policy decide on the source and
sinks. Delete the entry from the sinks and recreate it from the source.
Mark the appropriate pending attributes and resolve the GFID split brain.
When the heal takes place it will complete the pending heals and reset
the attributes.
Change-Id: Ie30e5373f94ca6f276745d9c3ad662b8acca6946
BUG: 1430719
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: https://review.gluster.org/16878
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0cfcfed597d8116136971e010699c8f277a67e85
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Apr 20 13:57:27 2017 +0530
glusterd: set conn->reconnect to null on timer cancellation
Change-Id: Ic48e6652f431daeb0db027660f6c9de16d893f08
BUG: 1443896
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17088
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 9b6b340ff63bafbfcabf7a49c4bfbcbebb67c77a
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Apr 12 15:24:14 2017 +0530
Implement negative lookup cache
Before creating any file negative lookups(1 in Fuse, 4 in SMB etc.)
are sent to verify if the file already exists. By serving these
lookups from the cache when possible, increases the create
performance by multiple folds in SMB access and some percentage
in Fuse/NFS access.
Feature page: https://review.gluster.org/#/c/16436
Updates #82
Change-Id: Ib1c0e7ac7a386f943d84f6398c27f9a03665b2a4
BUG: 1442569
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16952
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 457f21e312d9b4b3222862f3add290ea08b75f96
Author: Shyam <srangana@redhat.com>
Date: Mon Apr 10 11:36:17 2017 -0400
scripts: Update rfc.sh to prompt for a github issue on RFE commits
If a commit does not contain a bug check with the committer if
this is an RFE (or such) and prompt to amend the commit with a
github issue that relates to the change.
Also, give some specifics on what string to add to refer to an
issue.
This change is meant to encourage committers to add github issues
and hence will not enforce the same, IOW the check can be ignored
and code can still be submitted. Reviewers would hence be
responsible to check for the same.
Change-Id: Id382247a787a96d55be6be554332a1b7ccde6bcd
BUG: 1428036
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: https://review.gluster.org/17032
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 981d34574a2476f8b5fdef2b936a6a5f8bfffa7f
Author: Susant Palai <spalai@redhat.com>
Date: Mon Apr 17 13:00:54 2017 +0530
cluster/dht: Skip file migration if the subvol that meets min-free-disk criteria happens to be the same subvol containing data-file
Rebalance need to figure out a new subvol in case the hashed subvol
does not have enough space. In the process of figuring out the new subvol,
we need to ignore the source subvol, otherwise it will lead to data loss.
Test: Manual
Ran the following
sizeof /tmp/1: 1.5GB
sizeof /brick/1: 16GB
sizeof /tmp/2: 1.5GB
<start>
glusterd; gluster v create test1 vm1:/brick/1 vm1:/tmp/1;
gluster v start test1;
mount -t glusterfs vm1:test1 /mnt;
for i in {1..2000}
do
dd if=/dev/zero of=/mnt/file$i bs=1KB count=1 &> /dev/null;
done
gluster v add-brick test1 vm1:/tmp/2
gluster v set test1 min-free-disk 12GB
gluster v remove-brick test1 vm1:/tmp/1 star
<end>
file count and data were intact.
Change-Id: Ib8fc8467a3d48a7c12958824c4f0b88e160b86c1
BUG: 1441508
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/17064
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 85ab0137feb58a1a1432464320643bda7d23702f
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu May 12 16:40:04 2016 -0400
features/bit-rot-stub: bring in optional versioning
* As of now bit-rot-stub does versioning always. This leads
lots of getxattr calls being made in lookups. So make
object versioning optional.
Change-Id: I83713e45ae59fb28004bb3cfa008f2d69edebbfa
BUG: 1359599
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/14442
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7c0c59b5ee9c509233eaeb9a5d3026e882731f10
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Apr 2 18:08:04 2017 +0530
afr: don't do a post-op on a brick if op failed
Problem:
In afr-v2, self-blaming xattrs are not there by design. But if the FOP
failed on a brick due to an error other than ENOTCONN (or even due to
ENOTCONN, but we regained connection before postop was wound), we wind
the post-op also on the failed brick, leading to setting self-blaming
xattrs on that brick. This can lead to undesired results like healing of
files in split-brain etc.
Fix:
If a fop failed on a brick on which pre-op was successful, do not
perform post-op on it. This also produces the desired effect of not
resetting the dirty xattr on the brick, which is how it should be
because if the fop failed on a brick, there is no reason to clear the
dirty bit which actually serves as an indication of the failure.
Change-Id: I5f1caf4d1b39f36cf8093ccef940118638caa9c4
BUG: 1438255
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/16976
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 00bb33151796c0cbb29732b6152c76868cc3a1f0
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jan 3 20:13:40 2017 +0530
api: Fix incorrect strcmp() during fs initialisation
Just chanced upon this while reading graph switch code in
libgfapi.
Change-Id: Ie62b410c22e6d0768a24187c5d587b6d3fc996bf
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16319
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c059f1a283dd6c13770808f699952f6f68d7b9ae
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Apr 13 11:38:08 2017 +0530
worm: add check for internal processes in ftruncate()
The patch fixes the recently seen issues with worm_sh.t test.
RCA:
-
$ git log --oneline xlators/features/read-only/src/worm.c
1b01bdc worm: allow Self-heal-Daemon to perform some operations
c5a4a77 features/worm: Adding implementation for ftruncate
-
These two patches were merged in reverse order of their submission,
and hence the check added for internal processes got missed in
new fop 'ftruncate()'. The worm_sh.t passed the tests as while
that patch got submitted there was no ftruncate() in worm xlator.
Change-Id: I81a8a45fa2679917a2c859c4f5224a2c3edbc784
BUG: 1423413
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17048
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-by: David Spisla <david.spisla@iternity.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7b61f5212a0594c057813e6d8d4e24a43fa64ee4
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Apr 4 15:50:29 2017 +0530
gfapi: Fix inode ref leak in anonymous fd I/O APIs
In the APIs to do I/Os using anonymous fd, there
is a ref taken for inode which hasn't been unreferenced
post the operation. This shall result in the leak.
Change-Id: I75ea952a6b2df58c385f4f53398e5562f255248d
BUG: 1438738
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: https://review.gluster.org/16989
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 3d2978b4116c133d589428bb9901a4332f35b38d
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Apr 17 08:39:30 2017 -0400
glusterd: Fix snapshot failure in non-root geo-rep setup
Geo-replication session directory name has the form
'<mastervol>_<slavehost>_<slavevol>'. But in non-root
geo-replication setup, while preparing geo-replication
session directory name, glusterd is including 'user@'
resulting in "<mastervol>_<user@slavehost>_<slavevol>".
Hence snapshot is failing to copy geo-rep specific
session files. Fixing the same.
Change-Id: Id214d3186e40997d2827a0bb60d3676ca2552df7
BUG: 1442760
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17067
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 65a0395125518cb4fe0f7ca0745fa716cf8f707e
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 10 10:29:15 2017 +0200
gfapi: prevent off-by-one buffer overrun in glfs_sysrq()
Coverity found a potential buffer overrun in the strncat() usage for
logging the help message with glfs_sysrq(). This seems to be an
off-by-one mistake and should be addressed by reducing the initial size
of the remainder calculation.
Change-Id: Ide14add1cb28e5200d2c0df6b3a5154999ef3ca9
BUG: 789278
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17024
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 377a1a9eee818f562da40b911e8b91eb56261885
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Apr 13 16:20:29 2017 +0530
dht: Add readdir-ahead in rebalance graph if parallel-readdir is on
Issue:
The value of linkto xattr is generally the name of the dht's
next subvol, this requires that the next subvol of dht is not
changed for the life time of the volume. But with parallel
readdir enabled, the readdir-ahead loaded below dht, is optional.
The linkto xattr for first subvol, when:
- parallel readdir is enabled : "<volname>-readdir-head-0"
- plain distribute volume : "<volname>-client-0"
- distribute replicate volume : "<volname>-afr-0"
The value of linkto xattr is "<volname>-readdir-head-0" when
parallel readdir is enabled, and is "<volname>-client-0" if
its disabled. But the dht_lookup takes care of healing if it
cannot identify which linkto subvol, the xattr points to.
In dht_lookup_cbk, if linkto xattr is found to be "<volname>-client-0"
and parallel readdir is enabled, then it cannot understand the
value "<volname>-client-0" as it expects "<volname>-readdir-head-0".
In that case, dht_lookup_everywhere is issued and then the linkto file
is unlinked and recreated with the right linkto xattr. The issue is
when parallel readdir is enabled, mount point accesses the file
that is currently being migrated. Since rebalance process doesn't
have parallel-readdir feature, it expects "<volname>-client-0"
where as mount expects "<volname>-readdir-head-0". Thus at some point
either the mount or rebalance will fail.
Solution:
Enable parallel-readdir for rebalance as well and then do not
allow enabling/disabling parallel-readdir if rebalance is in
progress.
Change-Id: I241ab966bdd850e667f7768840540546f5289483
BUG: 1436090
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17056
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8949c841252a73383565b247570577e200e7ea02
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Apr 13 12:56:09 2017 +0530
eventsapi: Fix webhook-test when no schema specified in URL
If no schema specifed like `http` or `https` while testing webhook,
it was failing with Schema Exception and not communicated the error
to CLI caller.
With this patch exception is handled and responded back to CLI caller.
BUG: 1441945
Change-Id: I9be11d36e9f65be873516fef370c327f1cdbc93e
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: https://review.gluster.org/17054
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 6e71b7bf6cbef0904222ecba601bc82608398229
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Apr 10 06:52:51 2017 -0400
geo-rep: Remove unlink fop during rmdir
Even though it is known to be 'RMDIR', os.unlink
was being tried and os.rmdir is issued upon receiving
EISDIR. It's unnecessary unlink call for 'RMDIR'.
Fixed the same.
Change-Id: I8dbb680ee2c7f0c32b7799b1ed5351b3621cb42a
BUG: 1441106
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17041
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 3692bd903bc7ab32b5da4aa179970c44b2ec0a6a
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Mon Apr 10 18:46:42 2017 +0530
glusterd: Add brick capacity details to get-state CLI output
Change-Id: I53fe180e71d41d56b129254b93bb74014a2cdb43
BUG: 1431192
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17029
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 38a88c1a2a5f16a9c75842755fd613e05b9c483c
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Apr 14 17:19:47 2017 +0200
meta: free this->private in fini()
For every graph switch or de-init (includes calling `glfs_fini`) the
meta_priv_t structure (80 bytes on x86_64) leaks. Because it is
allocated in the `init()` funtion, it should be free'd in `fini()`.
Change-Id: Ie45a9c9a520d55bebd0eb04c2ac667bc8c1c5acb
BUG: 1442411
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17061
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit b506d19106a7596c5b05c78691c5e30e84fda24a
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Apr 13 18:26:29 2017 +0200
rpm: the regression-tests sub-package needs "bc"
split-brain-favorite-child-policy.t runs "bc" for comparing times in
nanosecond precision. The glusterfs-regression-tests sub-package can be
used to install environments for testing, but "bc" is not installed.
This causes test failures.
BUG: 1442145
Change-Id: Iaf9dcb3a8488dea7162873ee40ae445843a35d04
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17060
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 52006f1bd9164d18978096d68a48f5d4133aee15
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Apr 13 13:20:18 2017 +0530
glusterd: fix glusterd_wait_for_blockers to go in infinite loop
In send_attach_req () conf->blockers is bumped up before
rpc_clnt_submit however the same is bumped down twice, one from the
callback and one from the negative ret handling which can very well be a
possible case if the rpc submit fails.
Change-Id: Icb820694034cbfcb3d427911e192ac4a0f4540f6
BUG: 1441910
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17055
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 37e78ad23769f95f5976a645e02eb15c9eb0e90c
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Apr 13 16:44:44 2017 +0530
dht: Add missing braces in dht_opendir
Change-Id: I6adce98f52e17953f501bc590ff7189cceac3c31
BUG: 1431908
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17057
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9fd33e11c6a50f7f98f99a1ac048a6ac51c1eccc
Author: Susant Palai <spalai@redhat.com>
Date: Tue Apr 11 17:27:17 2017 +0530
cluster/dht: Make rebalance honor min-free-disk
test: Manual
created files of size 1K on 2 brick(of size 1GB) setup .
added a brick of size 16GB.
set min-free-disk to 12GB(so that first two bricks won't receive any files).
removed one of the 1st brick of size 1GB.
Logs from test:
[2017-04-12 08:52:08.196484] W [MSGID: 0] [dht-rebalance.c:895:__dht_check_free_space]
0-test1-dht: Write will cross min-free-disk for file - /tile32 on subvol - test1-client-1.
Looking for new subvol.
[2017-04-12 08:52:08.196904] I [MSGID: 0] [dht-rebalance.c:925:__dht_check_free_space]
0-test1-dht: new target found - test1-client-2 for file - /tile32
- Post migration we have two files. The new destination (/brick/1) has the data file
[root@vm1 ~]# ll /brick/1/tile32
-rw-r--r--. 2 root root 0 Apr 12 14:22 /brick/1/tile32
- On the old target the linkto file is there with linkto xattr pointing to /brick/1
[root@vm1 ~]# ll /tmp/2/tile32
---------T. 2 root root 1000 Apr 12 14:22 /tmp/2/tile32
[root@vm1 ~]# getfattr -m . -de text /tmp/2/tile32
getfattr: Removing leading '/' from absolute path names
security.selinux="unconfined_u:object_r:user_tmp_t:s0"
trusted.gfid="����:Aс�#�/'b2"
trusted.glusterfs.dht.linkto="test1-client-2"
Marking ./tests/features/worm_sh.t as bad test.
Reason being, this patch failed on master branch as well and it has nothing
to do with rebalance/remove-brick.
BUG: 1441508
Change-Id: I90bae251cda3d957a49cdceda90cd08311a392fb
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/17034
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit fcdb34c5a17ac846085fcc7d742fc82f67623d1a
Author: Prashanth Pai <ppai@redhat.com>
Date: Mon Dec 19 16:28:06 2016 +0530
glusterd: Propagate EADDRINUSE correctly to parent process
exit()/_exit():
Only the least significant 8 bits i.e (err & 255) shall be available
to the waiting parent process on calling _exit() or exit() with an
integer exit status. If this number is negative, the parent process
doesn't readily get what it's really looking forward to handle.
For example: EADDRINUSE is 98 and if exit status code is set to -98,
the waiting parent process shall get 158 (= -98 & 255) as exit status.
BUG: 1193929
Change-Id: Idc6b0f40c2332e087e584b4b40cbf0d29168c9cd
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: https://review.gluster.org/16200
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit d469bfd3221e3fd68d9554f9c6c47cc3e3c4de24
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Wed Apr 5 18:03:10 2017 +0530
glusterd: Add client details to get-state output
This commit optionally adds client details corresponding to the
locally running bricks to the get-state output. Since getting
the client details involves sending RPC requests to the respective
local bricks, this is a relatively more costly operation. These
client details would be added to the get-state output only if the
get-state command is invoked with the 'detail' option.
This commit therefore also changes the get-state CLI usage. The
modified usage is as follows:
# gluster get-state [<daemon>] [[odir </path/to/output/dir/>] \
[file <filename>]] [detail]
Change-Id: I42cd4ef160f9e96d55a08a10d32c8ba44e4cd3d8
BUG: 1431183
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/17003
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 1afaeae69927f042b2cd2bec6c388924db12e76e
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Apr 5 17:13:25 2017 +0530
cluster/ec : Don't count healing brick as healthy brick
In ec_child_select, we should send fop on healing bricks
unconditionaly but to check the number of healthy bricks
against fragments and minimum count, we should not count
these healing bricks.
Count bits of fop->mask before adding ealing brick to
fop->mask
Change-Id: I3fa80bdd5ca34ca070d610116b84154b917c5999
BUG: 1439527
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://review.gluster.org/17007
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6a5888fe240cb740da905bfc8115c96f538948df
Author: David Spisla <david.spisla@iternity.com>
Date: Fri Feb 17 13:06:44 2017 +0100
worm: allow Self-heal-Daemon to perform some operations
The Self-Heal-Daemon should be allowed to trigger unlink, link,
trauncate, rename and write operation. The value of frame->root->pid
can be used to detect internal (by SHD) operations.
Change-Id: I7526148100bef1e2837d69df5c119dc97d91fffd
BUG: 1423413
Signed-off-by: David Spisla <david.spisla@iternity.com>
Reviewed-on: https://review.gluster.org/16661
Tested-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit a7ab709bc8cfabda05cec14a4773bccb3b35950b
Author: Milind Changire <mchangir@redhat.com>
Date: Tue Apr 11 12:30:06 2017 +0530
rpc: add options to manage socket keepalive lifespan
Problem:
Default values for handling socket timeouts for brick responses are
insufficient for aggressive applications such as databases.
Solution:
Add 1:1 gluster options for keepalive, keepalive-idle,
keepalive-interval and keepalive-timeout as per the socket level options
available as per tcp(7) man page.
Default values for options are NOT agressive and continue to be values
which result in default timeout when only the keep alive option is
turned on.
These options are Linux specific and will not be applicable to the
*BSDs.
Change-Id: I2a08ecd949ca8ceb3e090d336ad634341e2dbf14
BUG: 1426059
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/16731
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 98b5ff30ec89c6e0d25e69fd914b21ecd9954be5
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 11 09:25:48 2017 +0530
tests: remove tests/bugs/core/bug-1421590-brick-mux-reuse-ports.t
bug-1421590-brick-mux-reuse-ports.t seems to be a bad test to me and here is my
reasoning:
This test tries to check if the ports are reused or not. When a volume is
restarted, by the time glusterd tries to allocate a new port to the one of the
brick processes of the volume there is no guarantee that the older port will be
allocated given the kernel might take some extra time to free up the port between
this time frame. From
https://build.gluster.org/job/regression-test-burn-in/2932/console we can
clearly see that post restart of the volume, glusterd allocated port 49153 &
49155 for brick1 & brick2 respectively but the test was expecting the ports to
be matched with 49155 & 49156 which were allocated before the volume was
restarted.
Change-Id: Id887bf28445261d4de04fc7502e58057659c9512
BUG: 1441035
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17033
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit b35f10e048b83973b78084ef3c30a0e5522d96f7
Author: Kevin Vigor <kvigor@fb.com>
Date: Tue Mar 29 14:08:38 2016 -0700
nfs: Fix compiler warning when calling svc_getcaller
Summary:
When using libtirpc instead of glibc rpc the result needs to be
cast to (struct sockaddr_in *)
This diff was originally a cherry-pick of D3111554 to 3.8
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Change-Id: If4c27dbe6c032f9e278ea08cd3c96a4d07bcc5f9
BUG: 1428073
Reviewed-on: http://review.gluster.org/16179
Tested-by: Shreyas Siravara <sshreyas@fb.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kevin Vigor <kvigor@fb.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-on: https://review.gluster.org/16804
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 78ca350ae4f249356ee95218796c87b62da87cf9
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 10 11:02:41 2017 +0200
gfapi: remove unneeded NULL-check in glfs_fsync_async_common()
Coverity reported that "glfd" has a NULL-check at the end of the
function, but is used without checking earlier. Because "glfd" is passed
as parameter to the (internal) function, there is no need to have the
additional NULL-check.
Change-Id: I1390b2ef250fbf624f0bc2b0eda7b7588942aae9
BUG: 789278
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17026
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 015c1b5a39eda8bb2d4764c9c6d82c2e694424ca
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Apr 10 11:04:31 2017 +0530
features/shard: Initialize local->fop in readv
Change-Id: I9008ca9960df4821636501ae84f93a68f370c67f
BUG: 1440051
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17014
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cde1537cc0e25e2ebd5aa5cdd88bc6c8637fad71
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Fri Jul 8 19:10:45 2016 +0530
geo-rep: filter out xtime attribute during getxattr
georep gsyncd's xtime needs to filtered irrespective
of any process access.
This way, we can avoid (unnecessarily)syncing xtime attribute
to slave, which may raise permission denied errors.
test case modified to check for xtime xattr only in backend.
Change-Id: I2390b703048d5cc747d91fa2ae884dc55de58669
BUG: 1353952
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/14880
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Kotresh HR <khiremat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit aba0b3bb1585adc636ba3248615cc608449ea41e
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Apr 6 16:36:29 2017 +0530
glusterd: Add validation for options rda-cache-limit rda-request-size
Currently when prarallel readdir is enabled, setting any junk value
to rda-cache-limit and rda-request-size succeeds. This is because of
bug in the special handling of these options.
Fixing the same in this patch
Change-Id: I902cd9ac9134c158ab6f8aea4b001254a03547bd
BUG: 1439640
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17008
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1f965fb08cccde5c6c7797ec880b1e26490143ab
Author: AnkitRaj <anraj@redhat.com>
Date: Fri Mar 31 10:55:41 2017 +0530
DHT: Spacing issue in fix-layout status output
There is a spacing issue in the status output of the rebalance
fix-layout operations. If the local host name is big then we will
have spacing issue.
To fix this we need to increase the space for node column.
Change-Id: Ic22e8017b55b05680db851a81f9b43c20489db79
BUG: 1437748
Signed-off-by: ankit <anraj@redhat.com>
Signed-off-by: AnkitRaj <anraj@redhat.com>
Reviewed-on: https://review.gluster.org/16972
Tested-by: ankitraj
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 07219cb57723757c8202fbdd77e4c3ffd091c062
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 10 10:10:30 2017 +0200
upcall: correct the cleanup path in init() when GF_CALLOC() fails
Coverity found that "priv" can be NULL when the 1st GF_CALLOC() fails,
and still is being used with "priv->xattrs" before the functon returns.
While cleaning this up, also removing the log message for out of memory,
as this is already logged through GF_CALLOC().
BUG: 789278
Change-Id: I887eaa9136dc25a39c107cd2152b1ba11f9fa925
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17023
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit d1d485d13a22ed4d0add95b4563ca4d23ce20a17
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Apr 6 15:11:00 2017 +0200
io-stats: use gf_atomic_t instead of partial atomic variables
io-stats should not use the legacy __sync_*() builtin functions for
doing atomic operations. Instead, it should use the gf_atomic_t type and
macros for any of the statistics it calculates. This makes sure that the
behaviour is the same on all architectures.
Also the __sync_*() builtins are being deprecated with __atomic_*()
functions. The "atomic.h" header will be one of the very few places
where these builtin functions are used and the feature checking will be
needed.
While replacing many of the uint64_t types, it seemed that locking
around some of the statements is not needed anymore (done automatically
with the GF_ATOMIC_*() macros). This resulted in quite some removal and
cleanup of those BUMP_*() macros. It seemed appropriate to make these
macros normal functions and let the compiler decide on inlining them.
This caused some existing functions to be shuffled around.
Change-Id: I7c4f3df1832eae51debda2b127b943e14546b605
URL: https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html
BUG: 1437037
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17009
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit d9752eb33bce077567863f0904f57cc35cc3b133
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Apr 7 13:02:08 2017 +0200
mem-pool: use gf_atomic_t for atomic counters
Reduce the usage of __sync_fetch_and_add() builtins in mem-pool. The new
gf_atomic_t type can be used instead, so that the architecture and
compiler specific builtins are hidden from the mem-pool implementation.
BUG: 1437037
Change-Id: Icbeeb187dd2b835b35f32f54f821ceddfc7b2638
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17012
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 1a3c7bb7b9257b90d5ce348c0dd7299b671cad99
Author: hari gowtham <hgowtham@redhat.com>
Date: Fri Feb 10 13:00:16 2017 +0530
TIER/TESTS: improving regression test for tier
The test files that were marked as bad test were checked and
updated for centos. The tests that had issue were fixed.
Tests that aren't needed anymore are removed.
REASON:
tests/basic/tier/tier-file-create.t
This test checks one line after creating a tiered volume (which
is done in every tier test). So this line is moved along with
other test in tier and the file is deleted.
tests/bugs/tier/bug-1286974.t
This bug checks for the tier as a task and tier has been moved
from a task to service as a part of the tier as a service patch
https://review.gluster.org/#/c/13365/
So it is removed from bad tests.
tests/basic/tier/record-metadata-heat.t
This test had a bug and has been fixed.
tests/basic/tier/bug-1214222-directories_missing_after_attach_tier.t
tests/basic/tier/fops-during-migration.t
tests/basic/tier/tier-snapshot.t
tests/basic/tier/tier_lookup_heal.t
These test seem to work fine on centos now.
Change-Id: I05537f4bbb91584410177ce43543897eff8761a1
BUG: 1421600
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/16605
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 8dfecd61e4e1e392ba1ef2318c4a0ceb15d67934
Author: Shyam <srangana@redhat.com>
Date: Wed Apr 5 14:22:57 2017 -0400
scripts: Update rfc.sh to check existance of Change-Id in backports
Addition to this script is a no-op on master.
This would need to be backported to active release branches to be
effective.
This check is not smart proof, in that someone could proceed knowing
that the Change-Id differs from master, but this is not expected to
catch that, instead it is to serve more as a reminder that we need
the same Change-Id across branches.
Contributors not using rfc.sh would not see this, but they are few
and possibly far in between. Also contributors using gerrit to
cherry-pick changes will not see this. For both cases a server side
solution to catch any changes are needed.
There is a possiblilty that we will follow this up with a check
on the gerrit end and add a comment to the reviews, to aid reviewers
to quickly check the sanity of the Change-Id when it differs.
Change-Id: I11e371489a4a3cf2ff96d9892256986cd535998b
BUG: 1428047
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: https://review.gluster.org/17004
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 255af0488a7982c337a6aefd45b992c56f91fc5d
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Apr 7 05:33:34 2017 -0400
geo-rep: Fix EBUSY traceback
EBUSY was added to retry list of errno_wrap
without importing. Fixing the same.
Change-Id: Ide81a9ccc9b948a96265b6890da078b722b45d51
BUG: 1434018
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/17011
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 53f0f571a0d413418f2ffeb9aadcd3ff94f5b9b1
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Mar 30 14:45:59 2017 +0530
cli/auth : auth.allow and auth.reject does not accept FQDN/host name
Problem : At the time of set FQDN name to "auth.allow/auth.reject" through
gluster cli,it does not accept FQDN/host name.
Solution: Condition needs to be update in verify_host_name and gf_auth
to accept FQDN/host name.
Fix : Change the condition to accept FQDN/host Name.
To verify the patch followed below procedure
1) Try to set FQDN name for auth.allow or auth.reject parameter
gluster v set myvol auth.reject <fqdn name>
It gives error "fqdn-name" is not a valid internet-address-list
2) After apply the patch it does not give any error.
3) To verify auth.allow/reject try to mount volume on some client.
Change-Id: Ieb76cbb93d43323fd29c7ca04efe3790edb4281b
BUG: 1321578
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/15086
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 17ae93439741a0f2f4912d3e195b23fb8e958ce0
Author: Susant Palai <spalai@redhat.com>
Date: Mon Nov 7 12:00:13 2016 +0530
dht/rebalance: Crawler performance improvement
The job of the crawler in rebalance is to fetch files from each
local subvolume and push them to migration queue if it is eligible for
migration. And we do a lookup on the entries received to figure out the
eligibilty. Since, the lookup done is on a local subvolume we receive
linkto files and regular files as well. This requires us to do two lookups.
first: do a lookup on the file to figure out whether it is a linkto file
second: do a lookup on the file to figure out if it should be migrated
Note: The migrator thread also does one lookup for the file before
migration.
Optimization: Remove the lookup done by the crawler. Offload these task
to the migrator threads. For linkto file verification get the stat and
xattr information from readdirp.
So in total we have one lookup instead of three for each entry.
Performance numbers:
Create two node, two brick setup. Created 100000 files. And started
rebalance. Since, there is no add-brick, no files will be migrated and
we will get the crawler performance.
Without patch:
[root@gprfs039 ~]# grs
Node Rebalanced-files size
scanned failures skipped status run time in
h:m:s
--------- ----------- -----------
----------- ----------- ----------- ------------
--------------
localhost 0 0Bytes
50070 0 0 completed 0:0:48
server2 0 0Bytes
49930 0 0 completed 0:0:44
volume rebalance: test1: success
Total: 48 seconds
WiththecurrentPatch:
[root@gprfs039 mnt]# gluster v rebalance test1 status
Node Rebalanced-files size
scanned failures skipped status run time in
h:m:s
--------- ----------- -----------
----------- ----------- ----------- ------------
--------------
localhost 0 0Bytes
50070 0 0 completed 0:0:12
server2 0 0Bytes
49930 0 0 completed 0:0:12
volume rebalance: test1: success
Total: 12 seconds
That's 4X speed gain. :)
Updates glusterfs#155
Change-Id: Idc8e5b366e76c54aa40d698876ae62fe1630b6cc
BUG: 1439571
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/15781
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit dfa55c84dbe5a873e511c70d933406dfc39e0780
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Jan 20 15:29:05 2017 -0500
tests: track EW_RETRIES for debugging
It can often be useful while debugging to know how many times
EXPECT_WITHIN had to retry a command before it got the result we were
looking for. This patch just adds a variable EW_RETRIES that can be
inspected to find this info for the last EXPECT_WITHIN.
Change-Id: I1bcb09bb7eb118c3d76c60317ef99e02df6b6ee6
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16451
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7c742ccc06cea285ae93eb1a772618057c841c80
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Apr 6 18:10:41 2017 +0530
features/shard: Fix vm corruption upon fix-layout
shard's writev implementation, as part of identifying
presence of participant shards that aren't in memory,
first sends an MKNOD on these shards, and upon EEXIST error,
looks up the shards before proceeding with the writes.
The VM corruption was caused when the following happened:
1. DHT had n subvolumes initially.
2. Upon add-brick + fix-layout, the layout of .shard changed
although the existing shards under it were yet to be migrated
to their new hashed subvolumes.
3. During this time, there were writes on the VM falling in regions
of the file whose corresponding shards were already existing under
.shard.
4. Sharding xl sent MKNOD on these shards, now creating them in their
new hashed subvolumes although there already exist shard blocks for
this region with valid data.
5. All subsequent writes were wound on these newly created copies.
The net outcome is that both copies of the shard didn't have the correct
data. This caused the affected VMs to be unbootable.
FIX:
For want of better alternatives in DHT, the fix changes shard fops to do
a LOOKUP before the MKNOD and upon EEXIST error, perform another lookup.
Change-Id: I8a2e97d91ba3275fbc7174a008c7234fa5295d36
BUG: 1440051
RCA'd-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
Reported-by: Mahdi Adnan <mahdi.adnan@outlook.com>
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/17010
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 26e5d0fa66da9e25dd3bb6d2987a276a62a59ac4
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Mar 24 10:16:34 2017 -0400
fuse-bridge: fuse_getattr(): send root lookup() only in case of failure.
this will make sure we don't fail in any current cases, and also will
enable the performance better.
Change-Id: Ia421e1913e1b00f0730a004bf7c84bf7e2a62636
BUG: 1437780
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/16945
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 6854d239c0e4d9d0db99730296b15f3f7226c182
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Feb 27 22:37:00 2017 -0800
xlator: do not call dlclose() when debugging
Valgrind can not show the symbols if a .so after calling dlclose(). The
unhelpful ??? in the output gets resolved properly with this change:
==25170== 344 bytes in 1 blocks are definitely lost in loss record 233 of 324
==25170== at 0x4C29975: calloc (vg_replace_malloc.c:711)
==25170== by 0x52C7C0B: __gf_calloc (mem-pool.c:117)
==25170== by 0x12B0638A: ???
==25170== by 0x528FCE6: __xlator_init (xlator.c:472)
==25170== by 0x528FE16: xlator_init (xlator.c:498)
==25170== by 0x52DA8D6: glusterfs_graph_init (graph.c:321)
==25170== by 0x52DB587: glusterfs_graph_activate (graph.c:695)
==25170== by 0x5046407: glfs_process_volfp (glfs-mgmt.c:79)
==25170== by 0x5043B9E: glfs_volumes_init (glfs.c:281)
==25170== by 0x5044FEC: glfs_init_common (glfs.c:986)
==25170== by 0x50451A7: glfs_init@@GFAPI_3.4.0 (glfs.c:1031)
By not calling dlclose(), the dynamically loaded .so is still available
upon program exit, and Valgrind is able to resolve the symbols. This
will add an additional leak, so dlclose() is called for normal builds,
but skipped when configuring with "./configure --enable-valgrind" or
passing the "run-with-valgrind" xlator option.
URL: http://valgrind.org/docs/manual/faq.html#faq.unhelpful
Change-Id: I2044e21b1b8fcce32ad1a817fdd795218f967731
BUG: 1425623
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16809
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit e1395b995ec15f1fdc566b5e223585a59c872f65
Author: Bipin Kunal <bkunal@redhat.com>
Date: Mon Feb 27 15:23:04 2017 +0530
nfs: make subdir mounting work for Solaris 10 clients
This fixes the segfault caused by solaris client in Gluster/NFS.
Volname was not being parsed properly, Instead of volume
name complete path was being used in nfs_mntpath_to_xlator().
Fixed it by striping volume name from complete path in nfs_mntpath_to_xlator().
Modified function name nfs3_funge_solaris_zerolen_fh() to
nfs3_funge_webnfs_zerolen_fh() as zero-filled filehandle is specific to WebNFS.
RFC : https://tools.ietf.org/html/rfc2055
Solaris uses WebNFS, the zero-filled FH is defined in the WebNFS spec.
Logic was even added in fuction nfs3_funge_webnfs_zerolen_fh() to send
subdir path in function glfs_resolve_at() instead of complete path for
subdir mount.
Change-Id: I19aae3547b8910e7ed4974ee5385424cab3e834a
BUG: 1426667
Signed-off-by: Bipin Kunal <bkunal@redhat.com>
Reviewed-on: https://review.gluster.org/16770
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0dec8a7c07d869f5e96f4e4c8cb3aa412fff8527
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Apr 4 15:39:46 2017 -0400
geo-rep: Improve worker log messages
Monitor process expects worker to establish SSH Tunnel to slave node
and mount master volume locally with in 60 secs and acknowledge monitor
process by closing feedback fd. If something goes wrong and worker
does not close feedback fd with in 60 secs, monitor kills the worker.
But there was no clue in log message about the actual issue. This patch
adds log and indicates whether the worker is hung during SSH
or master mount.
Change-Id: Id08a12fa6f3bba1d4fe8036728dbc290e6c14c8c
BUG: 1261689
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/16997
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 0c13ca21a7da951a3827b5f64bb7dafeef80c3fe
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Mar 20 05:21:59 2017 -0400
geo-rep: Retry on EBUSY
Do not crash on EBUSY error. Add EBUSY
retry errno list. Crash only if the error
persists even after max retries.
Change-Id: Ia067ccc6547731f28f2a315d400705e616cbf662
BUG: 1434018
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/16924
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 4ab493f166ff4a5712184974816cf399f0315d8d
Author: Michael Scherer <misc@redhat.com>
Date: Thu Feb 23 21:26:33 2017 +0100
shared: simplify and fix crash when we run out of memory
Since mem_get0 can return NULL, local->op_ret is gonna
crash. Found by coverity. And since we only have ENOMEM
as potential error, we can also simplify the code by avoiding
using 'local' for that.
Change-Id: I778747b57f520b1a52347c0fc9f27efd7a7c5ca0
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16739
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 22a29a8e872199d58a5c6dbfcf926d57bb2d1363
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Mar 15 10:26:28 2017 +0530
dht: The xattrs sent in readdirp should be sent in opendir aswell
As readdir-ahead can be loaded as a child of dht, dht has to specify
the xattrs it is intrested in, as part of opendir call itself.
Change-Id: I012ef96cc143b0cef942df78aa7150d85ec38606
BUG: 1431908
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16902
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 9deb08babc3033764951142ed1b9bc414b0316fa
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Mar 29 13:44:03 2017 +0200
libglusterfs: provide standardized atomic operations
The current macros ATOMIC_INCREMENT() and ATOMIC_DECREMENT() expect a
lock as first argument. There are at least two issues with this
approach:
1. this lock is unused on architectures that have atomic operations
2. some structures use a single lock for multiple variables
By defining a gf_atomic_t type, the unused lock can be removed, saving a
few bytes on modern architectures.
Because the gf_atomic_t type locates the lock for the variable (in case
of older architectures), each variable is protected the same on all
architectures. This makes the behaviour across all architectures more
equal (per variable locking, by a gf_lock_t or compiler optimization).
BUG: 1437037
Change-Id: Ic164892b06ea676e6a9566f8a98b7faf0efe76d6
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16963
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 592aea284acd374922653a577bc670faec73e0d9
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Apr 4 20:28:07 2017 +0530
explicitly specify executor to be bash for tests
We use prove command to run tests. Sometimes tests fail rather strangely
with error as shown below:
Not a perl script at ./tests/bugs/core/bug-1111557.t line 1.
./tests/bugs/core/bug-1111557.t ..
Dubious, test returned 25 (wstat 6400, 0x1900)
No subtests run
https://build.gluster.org/job/centos6-regression/3818/consoleFull
https://build.gluster.org/job/centos6-regression/3819/consoleFull
https://build.gluster.org/job/centos6-regression/3801/consoleFull
Quote from man page
``
"--exec"
Normally you can just pass a list of Perl tests and the harness
will know how to execute them. However, if your tests are not written in Perl
or if you want all tests invoked exactly the same way, use the "-e",
or "--exec" switch:
prove --exec '/usr/bin/ruby -w' t/
```
Hence, better to comply with recommended practice although it might not
be the reason for this failure.
Change-Id: If7a0baf20698f8497ef3e8fc422fa67063a4651f
BUG: 1438858
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: https://review.gluster.org/16996
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Nigel Babu <nigelb@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 1c68096eb42d5664baac2981f3d3e3876061d798
Author: karthik-us <ksubrahm@redhat.com>
Date: Tue Apr 4 18:57:32 2017 +0530
features/worm: Adding implementation for ftruncate
Problem:
Since the ftruncate fop was not handled in the worm feature, when
truncate and write was happening on a worm-retained/worm file, it was
giving the EROFS error but truncating the file, which is not correct.
Change-Id: I1a7e904655210d78bce9e01652ac56f3783b5aed
BUG: 1438810
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: https://review.gluster.org/16995
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 26e94c3006f08e37a15340aa68e277f8262564f9
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Mar 27 11:38:28 2017 +0530
reddir-ahead: Fix EOD propagation problem
In readdirp fop, op_errno is overloaded to indicate the EOD detection.
If op_errno contains ENOENT, then it indicates that there are no
further entries pending read in the directory. Currently NFS uses the
ENOENT to identify the EOD.
Issue:
NFS clients issues a 4K buffer for readdirp, readdir-ahead converts it
to 128K buffer as its reading ahead. If there are 100 entries in the
bricks, 128K can get all 100 and store in readdir-ahead, but only 23
entries that can be fit in 4K will be sent to NFS. Since the whole
100 entries were read from brick, the op_errno is set to ENOENT, and
the op_errno is propagated as is when sent to NFS. Hence NFS client
in reading 23 entries thinks it reached EOD.
Solution:
Do not propogate ENOENT errno, unless all the entries are read
from the readdir ahead buffer.
Change-Id: I4f173a77b21ab9e98ae35e291a45b8fc0cde65bd
BUG: 1436086
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16953
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 51915dfb2b0f1598ddebdb556ae5bcf86ad7b40b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Apr 4 07:35:52 2017 -0400
build: clang has __builtin_popcount() and __builtin_ffs()
Note: Even though gcc(1) will automatically treat ffs() and popcount()
as built-in, calling them explicitly as __builtin in the source helps
make it easier to find them. (And if no __builtin_ffs use the one in
libc.)
Change-Id: Ib74d9b221ff03a01df5ad05907024da1a83a7a88
BUG: 1438772
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16993
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit b542e915a98506751aee17f7dbeed845633a1241
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Mon Mar 6 12:36:02 2017 +0530
Fixes Stale auxiliary mount when crawler fails to spawn
The auxiliary mount created for crawling remains if the crawler was not
successfully spawned due to transport disconnect or other such issues.
The patch ensures the mount is cleared in those code paths as well.
Change-Id: I659fcc1d1956f8e05a37b75ebe3f3a00c24693e8
BUG: 1429330
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
Reviewed-on: https://review.gluster.org/16853
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-by: Manikandan Selvaganesh <manikandancs333@gmail.com>
commit 290e943d3de54183b7d71dc2662571c1c3ebb6e3
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Apr 4 12:55:27 2017 +0200
build: place generated XDR .h and .c files under $(top_builddir)
Change-Id: I0487337223a54a52e73088cb6dd812ce6d47178d
BUG: 1429696
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16994
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Tested-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 3fefa815dc8e09fd71d9c309c188a4c67f6c59fe
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 30 14:58:38 2017 +0530
cluster/dht: Modify local->loc.gfid in thread safe manner
Problem:
local->loc.gfid in dht_lookup_directory() will be null-gfid for a fresh lookup.
dht_lookup_dir_cbk() updates local->loc.gfid while in other thread dht_lookup_directory()
is still winding lookup calls to subvolumes so there is a chance of partial gfid being
seen by EC.
We saw in 12x(4+2) volume, ec is receiving an loc where the gfid has last 10 bytes matching
with the gfid of the directory and the first 4 bytes are all-zeros. This is leading to EC
erroring out the lookup with EINVAL which leads to NFS failing lookup with EIO.
snip from gdb:
$37 = (dht_local_t *) 0x7fde5de5b3cc
(gdb) p /x $37->loc.gfid
$39 = {0x3b, 0x82, 0x10, 0x5e, 0x40, 0x65, 0x43, 0x14, 0xa0, 0xc6, 0x8, 0xf5,
0x6c, 0x2c, 0xb8, 0x56}
(gdb) fr 7
state=<optimized out>) at ec-generic.c:837
837 ec_lookup_rebuild(fop->xl->private, fop, cbk);
(gdb) p /x fop->loc[0].gfid
$40 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x43, 0x14, 0xa0, 0xc6, 0x8, 0xf5, 0x6c,
0x2c, 0xb8, 0x56}
snip from log:
[2017-01-29 03:22:30.132328] W [MSGID: 122019]
[ec-helpers.c:354:ec_loc_gfid_check] 0-butcher-disperse-4: Mismatching GFID's
in loc [2017-01-29 03:22:30.132709] W [MSGID: 112199]
[nfs3-helpers.c:3515:nfs3_log_newfh_res] 0-nfs-nfsv3:
/linux-4.9.5/Documentation => (XID: b27b9474, MKDIR: NFS: 5(I/O error), POSIX:
5(Input/output error)), FH: exportid 00000000-0000-0000-0000-000000000000, gfid
00000000-0000-0000-0000-000000000000, mountid
00000000-0000-0000-0000-000000000000 [Invalid argument]
Fix:
update local->loc.gfid in last-call to make sure there are no races.
BUG: 1438411
Change-Id: Ifcb7e911568c1f1f83123da6ff0cf742b91800a0
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/16986
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit adb629e277ec1c2bd899668aefce30eabc31141a
Author: Patrick Matthäi <pmatthaei@debian.org>
Date: Fri Mar 31 12:27:20 2017 +0200
build: miscellaneous spelling fixes
Debian builds detected spelling issues with GlusterFS 3.10.1. Instead of
carrying the patch in the Debian sources, let's include the fixes here
too.
Change-Id: I38db6adf142f7ec247bffd47aa1e6ff1a0c49e00
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
BUG: 1437853
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16973
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ef262d9472fa4c0fad70bffefbc3edad3599db65
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Wed Mar 29 11:40:43 2017 +0800
protocol: corect parameter state->size in server3_3_writev
Change-Id: I1a3d558670e4320fe8508b5ab97deff9aacca5c7
BUG: 1436936
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: https://review.gluster.org/16962
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit dde75a8a0e4ff7dfa54c7d14e112f65ac49146c4
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Thu Mar 16 14:56:39 2017 +0530
glusterd : Disallow peer detach if snapshot bricks exist on it
Problem :
- Deploy gluster on 2 nodes, one brick each, one volume replicated
- Create a snapshot
- Lose one server
- Add a replacement peer and new brick with a new IP address
- replace-brick the missing brick onto the new server
(wait for replication to finish)
- peer detach the old server
- after doing above steps, glusterd fails to restart.
Solution:
With the fix detach peer will populate an error : "N2 is part of
existing snapshots. Remove those snapshots before proceeding".
While doing so we force user to stay with that peer or to delete
all snapshots.
Change-Id: I3699afb9b2a5f915768b77f885e783bd9b51818c
BUG: 1322145
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-on: https://review.gluster.org/16907
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 7d39ea52375b02e001dbddc1365c7d5ab70391f8
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Feb 14 17:50:27 2017 +0100
libglusterfs: add dict_rename_key()
The dict_rename_key() function will be used for converting the
"security.selinux" xattr to "trusted.gluster.selinux" in the upcoming
SELinux xlator.
BUG: 1318100
Change-Id: Ic5d0b9127e2c360d355f02e200a820597e83fa2c
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
[ndevos: split from change Id8916bd8e064ccf74ba86225ead95f86dc5a1a25]
Reviewed-on: https://review.gluster.org/16616
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit ff617ec0e84c3e1ca93b372230e7166fc5a1b05a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Mar 30 14:47:45 2017 +0530
glusterd: reset pid to -1 if brick is not online
While populating brick details in gluster volume status response payload
if a brick is not online then pid should be reset back to -1 so that
volume status output doesn't show up the pid which was not cleaned up
especially with brick multiplexing where multiple bricks belong to same
process.
Change-Id: Iba346da9a8cb5b5f5dd38031d4c5ef2097808387
BUG: 1437494
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16971
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit b1d70f522136a054fb933286f7cd3e156a82f880
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Mar 20 12:32:33 2017 -0400
glusterd: hold off volume deletes while still restarting bricks
We need to do this because modifying the volume/brick tree while
glusterd_restart_bricks is still walking it can lead to segfaults.
Without waiting we could accidentally "slip in" while attach_brick has
released big_lock between retries and make such a modification.
Change-Id: I30ccc4efa8d286aae847250f5d4fb28956a74b03
BUG: 1432542
Signed-off-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-on: https://review.gluster.org/16927
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 7233f03ef1940e936e3289ca499dd319016af4f7
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Mar 30 11:45:43 2017 +0200
build: add copied .x files to .gitignore
The new rpc/xdr/gen/ directiry contains copies of the .x files from
rpc/xdr/src/. This is needed to generate the headers for the cyclic
dependency for libglusterfs <-> rpc. These files should never be
included in the git repository, so adding them to .gitignore.
BUG: 1429696
Change-Id: Ia9dd104853e2dbde49b368169dc15c465dff0323
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16969
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit c66a535eca3fb4c331305a42234f6d3769e33e12
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Mar 28 19:26:41 2017 +0530
features/shard: Pass the correct iatt for cache invalidation
This fixes a performance issue with shard which was causing
the translator to trigger unusually high number of lookups
for cache invalidation even when there was no modification to
the file.
In shard_common_stat_cbk(), it is local->prebuf that contains the
aggregated size and block count as opposed to buf which only holds the
attributes for the physical copy of base shard. Passing buf for
inode_ctx invalidation would always set refresh to true since the file
size in inode ctx contains the aggregated size and would never be same
as @buf->ia_size. This was leading to every write/read being preceded
by a lookup on the base shard even when the file underwent no
modification.
Change-Id: Ib0349291d2d01f3782d6d0bdd90c6db5e0609210
BUG: 1436739
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16961
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 32904a62b2f267cfe09e988e47d905c3c68fcc9d
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Mar 20 05:15:25 2017 +0530
protocol : fix auth-allow regression
One of the brick multiplexing patches (commit 1a95fc3) had some changes
in gf_auth () & server_setvolume () functions which caused auth-allow
feature to be broken. mount doesn't succeed even if it's part of the
auth-allow list. This fix does the following:
1. Reintroduce the peer-info data back in gf_auth () so that fnmatch has
valid input and it can decide on the result.
2. config-params dict should capture key values pairs for all the bricks
in case brick multiplexing is on. In case brick multiplexing isn't
enabled, then config-params should carry attributes from protocol/server
such that all rpc auth related attributes stay in tact in the
dictionary.
Change-Id: I007c4c6d78620a896b8858a29459a77de8b52412
BUG: 1433815
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16920
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: MOHIT AGRAWAL <moagrawa@redhat.com>
commit 95d932af688dc6017f83f0b65b01cacd5c6275a6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Mar 27 08:35:51 2017 -0400
build: errors generating xdr stubs+headers with `make -j`
Using a makebomb, on f23 at least, blows up when generating the
xdr headers and stubs. (Works reliably on f25 though, go figure.)
This change appears to mitigate the race on f23.
BUG: 1429696
Change-Id: Icca2de035255a7759563bf06d853950dddc5724d
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16954
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit c5bffb4afb5b440c6d0f87630c213f74b80e9f23
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Mar 21 11:02:32 2017 +0530
syncop: don't wake task in synctask_wake unless really needed
Problem:
In EC and AFR, we launch synctasks during self-heal.
(i) These tasks usually stackwind a FOP to all its children and call
synctask_yield() which does a swapcontext to synctask_switchto() and puts the
task in syncenv's waitq by calling __wait(task). This happends as long as the
FOP ckbs from all children haven't been received.
(ii) For each FOP cbk, we call synctask_wake() which again does a swapcontext
to synctask_switchto() which now puts the task in syncenv's runq by calling
__run(task). When the task runs and the conext switches back to the FOP path,
it puts the task in waitq because we haven't heard from all children as
explained in (i).
Thus we are unnecessarily using the swapcontext syscalls to just toggle
the task back and forth between the waitq and runq.
Fix:
Store the stackwind count in new variable 'syncbarrier->waitfor' before
winding the fop. In each cbk when we call synctask_wake(), perform an actual
wake only if the cbk count == stackwind count.
Change-Id: Id62d3b6ffed5a8c50f8b79267fb34e9470ba5ed5
BUG: 1434274
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://review.gluster.org/16931
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 7cdc986b385db69bc1ca1440cab7289c5d4f4973
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 27 07:19:57 2017 +0530
syncop: Fix args for makecontext
Passing 64bit arguments to makecontext is not portable and manpage says the following:
<snip>
On architectures where int and pointer types are the same size (e.g., x86-32, where
both types are 32 bits), you may be able to get away with passing pointers as argu‐
ments to makecontext() following argc. However, doing this is not guaranteed to be
portable, is undefined according to the standards, and won't work on architectures
where pointers are larger than ints. Nevertheless, starting with version 2.8, glibc
makes some changes to makecontext(), to permit this on some 64-bit architectures
(e.g., x86-64).
</snip>
Since we do not depend on the arguments, it is better to change makecontext to not
take any arguments.
BUG: 1434274
Change-Id: Ic46c9e9faaeb2f78e4efde353ef861466515b1ec
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/16951
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 733c536fbc4c5ac7132623e96f7a098b6786d3bb
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Mar 7 18:01:25 2017 +0100
glusterd: support filesystems with dynamic inode sizes
btrfs and zfs are two filesystems that do not have fixed sizes for
inodes. Instead of logging an error, skip checking and mark the size as
"N/A" like other properties that can not be reported.
The error message that was reported by users on the mailinglist shows up
like:
[glusterd-utils.c:5458:glusterd_add_inode_size_to_dict] 0-management: could not find (null) to getinode size for /dev/vdb (btrfs): (null) package missing?
Change-Id: Ib10b7a3669f2f4221075715d9fd44ce1ffc35324
Reported-by: Arman Khalatyan <arm2arm@gmail.com>
URL: http://lists.gluster.org/pipermail/gluster-users/2017-March/030189.html
BUG: 1433425
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16867
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 41df2184d82d7b2071bfb006ad400496c6a479d7
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Mar 20 17:24:37 2017 -0400
nfs: use pkill on all OS's
'killall' is the only executable that is needed from the psmisc package
on glusterfs-server installations. NetBSD already uses 'pkill' as
alternative, this can be used everywhere.
BUG: 1197308
Change-Id: Ied671a74b735e321f52d99c869627b957aa2bd02
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16928
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 53cbe9f7597dd11d7ce395c4cb681340b085ece9
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Mar 24 08:32:39 2017 -0400
build: errors generating xdr stubs+headers with `make -j`
Using a makebomb, on f23 at least, blows up when generating the
xdr headers and stubs. (Works reliably on f25 though, go figure.)
This change appears to mitigate the race on f23.
Change-Id: I006066f0e7c3f8b65189f97c70089f3422e3e08b
BUG: 1429696
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16941
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Anoop C S <anoopcs@redhat.com>
commit ad940dd91ee10ff294155b3fe17c7e375af475d6
Author: karthik-us <ksubrahm@redhat.com>
Date: Sat Mar 18 13:44:56 2017 +0530
cluster/afr: Undo pending xattrs only on the up bricks
Problem:
While doing conservative merge, even if a brick is down, it will reset
the pending xattr on that. When that brick comes up, as part of the
heal, it will consider this brick as the source and removes the entries
on the other bricks, which leads to data loss.
Fix:
Undo pending only for the bricks which are up.
Change-Id: I18436fa0bb1faa5f60531b357dea3f6b20446303
BUG: 1433571
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: https://review.gluster.org/16913
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit 5aa33073e60fc6edc3cfb66e96ee8253f1892a0f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Mar 15 17:10:41 2017 +0530
libglusterfs: Initialize old sigset
...in gf_thread_create(). Technically, since we pass it as an argument
to pthread_sigmask, initialization is not needed but doing it as a good
practice.
Change-Id: Ie069af07cb07c1784f3841e1fc628ca13dfdcef4
BUG: 1434274
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/16929
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 3effe51690730bce09695bb7298e08d3fa3872c5
Author: Poornima G <pgurusid@redhat.com>
Date: Sun Mar 26 07:59:53 2017 +0530
protocol-client: Initialize the list_head before using
In client3_3_readdir(p)_cbk, in case of error conditions,
it is possible that the list_head is used before initializing.
Hence move the initialization before usage.
Change-Id: Ie58902d079fdc58416d17b5fa5f61375decb1c99
BUG: 1435943
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16948
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 0156e1a6ad97708f20a97fbb7aaea108b711ef72
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Mar 20 12:31:33 2017 -0400
core: fix synclocks' handling of "woken" flag
The "woken" flag wasn't being reset when it should have been, leading
(eventually) to a SEGV when someone tried to folow a synclock's waitq
to a task structure that had been freed while still on the queue. See
the bug report for (far) more detail.
Change-Id: I5cd9ae1bcb831555274108b292181ec2a29b6d95
BUG: 1434062
Signed-off-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-on: https://review.gluster.org/16926
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 933579ca4f62d7895a0fbb55585f202569f6f965
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Mar 14 15:38:39 2017 +0100
refcount: correct the return value of GF_REF_PUT()
It is documented that GF_REF_PUT() returns a 0 in case the call resulted
in free'ing the structure. However the implementations did not have a
return value, so nothing can actually use it.
Change-Id: Ic57091f5ddd7e0b80929dc335a5b6d37f5fe1b2e
BUG: 1433405
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16910
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 0b9af536bada347a2b3e2baa0bc0eed2bb989a3c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Feb 1 07:50:17 2017 -0500
packaging: (ganesha) remove glusterfs-ganesha subpackage and related files)
Indiana Jones and the Temple of Ganesha HA, part two.
remove glsuterfs-ganesha subpackage, superceded by storhaug
Change-Id: I42a1fc59159add108d77080b9b130696216aa76d
BUG: 1418417
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16506
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 63174b672317fc21d1ce69b055d94a8112e5e5f1
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Feb 1 06:39:03 2017 -0500
glusterd: (storhaug) remove ganesha
remove all vestiges of ganesha
The storhaug CLI is used to manage ganesha and Samba. Also any setup
and teardown of the ganesha HA is initiated using storhaug to preserve
the proper layering.
Change-Id: I0eec0016a1b7802a36e7b2d92896b86fdf8607d5
BUG: 1420713
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16504
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit a150199df469945ccea3b15beb92a664de805195
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Mar 8 14:44:50 2017 -0500
build: libgfxdr.so calls GF_FREE(), needs to link with -lglusterfs
The previous change to remove the xdrgen script exposed (or
created) a recursive build dependency: libglusterfs needs the
generated headers, and libgfxdr should be linked with libglusterfs
for GF_FREE/__gf_free.
(Much grumbling about libglusterfs being the kitchen sink of gluster
elided. This would not be necessary if there were two or more libs,
a gluster "runtime" library with common gluster code shared by the
xlators and daemons, and a utility library with things like the
rbtree, memory allocation, and whatnot.)
So. Link at build time or link at runtime? For truth-and-beauty, link
with libglusterfs.so at build time. Without truth-and-beauty, don't
link with libglusterfs and rely on the other things that link with
libglusterfs to provide resolution of __gf_free().
Truth-and-beauty it is. But how to generate the headers first, then
build libglusterfs, then come back and build libgfxdr? Autotools is a
maze of twisty passages, all different. Things that work with gnu
make on linux don't work with the BSD make. Finally I hit on this
solution. Add a shadow directory where make only generates the headers,
then build libglusterfs using the generated headers, and finally build
libgfxdr and link with libglusterfs.
See original BZ 1330604
change http://review.gluster.org/14085
Change-Id: Iede8a30e3103176cb8f0b054885f30fcb352492b
BUG: 1429696
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16873
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fde9021a1eeba74f328495e62eafe9447563434e
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Mar 15 17:18:54 2017 +0530
syncop: fix argc count in call to makecontext()
We are only passing one argument (a pointer to struct synctask) to the
function, so argc must be 1 and not 2.
Change-Id: I4eaadd58a76f32327d8bb3efa9c5c435700d7391
BUG: 1434274
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/16930
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit a7bf98fe62bece2e5a989565d6163e1496d56bad
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Mon Feb 27 15:35:17 2017 +0530
cluster/ec: Metadata healing fails to update the version
During meatadata heal, we were not updating the version
though all the inode attributes were in sync.
Updated the code to adjust version when all the inode
attributes are in sync.
BUG: 1425703
Change-Id: I6723be3c5f748b286d4efdaf3c71e9d2087c7235
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
Reviewed-on: https://review.gluster.org/16772
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 436d4fe4c5d01c9bcfbad0764187c37fead57c97
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sat Mar 18 16:29:10 2017 +0530
rpc: bump up conn->cleanup_gen in rpc_clnt_reconnect_cleanup
Commit 086436a introduced generation number (cleanup_gen) to ensure that
rpc layer doesn't end up cleaning up the connection object if
application layer has already destroyed it. Bumping up cleanup_gen was
done only in rpc_clnt_connection_cleanup (). However the same is needed
in rpc_clnt_reconnect_cleanup () too as with out it if the object gets destroyed
through the reconnect event in the application layer, rpc layer will
still end up in trying to delete the object resulting into double free
and crash.
Peer probing an invalid host/IP was the basic test to catch this issue.
Change-Id: Id5332f3239cb324cead34eb51cf73d426733bd46
BUG: 1433578
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16914
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 724b2c6a211ac02f30b34738f0270f2449024ec3
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Sun Mar 19 17:09:06 2017 +0530
gfapi: Dump graph upon initilization/switch for better debugging experience
Having this information printed the way FUSE/nfs do would helps immensely with
debugging experience, especially when a user/customer has added and removed
bricks a couple of times. It helps in mapping the brick path to its
corresponding protocol/client translator and in turn all the log messages that
may be thrown by this protocol/client xlator.
Change-Id: I0784e5fe932326fdbdc56f5a12b6951c7541a8cf
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16919
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
commit 0e7dfc3c4ef4085dc656e6aa2f7d20744b883ea3
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Mar 19 22:42:33 2017 +0530
afr: do not mention split-brain in log message in read_txn
I am seeing a lot of messages in qe/customer logs where read_txn
complains that file is possibly in split-brain because of no readable
subvol being found, does inode refresh and then there is no split-brain
message post the inode refresh. This means that a lookup was not issued
on the indoe to populate 'readable' or it can mean one brick is source
for data and the other for metadata, making readable to be zero (because
readable=intersection of (data,metadata readable) since commit
7a1c1e290470149696.
Since we anyway log actual split-brains post inode-refresh, move this
message to DEBUG log level.
Change-Id: Idb88b8ea362515279dc9b246f06b6b646c6d8013
BUG: 1433838
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/16879
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 92dda5637374ef1b6039026013cf47808b9abf94
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Mar 17 13:03:57 2017 -0400
geo-rep: Optionally allow access to mounts
In order to improve debuggability, it is important
to have access to geo-rep master and slave mounts.
With the default behaviour, geo-rep lazy unmounts
the mounts after changing the current working
directory into the mount point. It also cleans
up the mount points. So only geo-rep worker has
the access and it becomes impossible to take the
client profile info and do any other client statck
analysis. Hence the following new config is being
introduced to allow access to mounts.
gluster vol geo-rep <mastervol> <slavehost>::<slavevol> \
config access_mount true
The default value of 'access_mount' is false.
Change-Id: I53dce4ea86a6ffc979c82f9330e8954327180ca3
BUG: 1433506
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/16912
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c930605ac5cec19ae4f9322c69ca5aa9d3c03ef3
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Apr 19 14:01:09 2016 +0530
TIER: watermark check during low watermark reset
PROBLEM: during a low watermark reset, checking of whether
the low watermark is lower than hi watermark is not done.
FIX: This patch checks if the hi watermark value is higher
the default low watermark. Else throws an failure of the reset
command
Change-Id: I8b49090c6bccce6d45c2e8076ab766047a2a6162
BUG: 1328342
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/14028
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 791818d797c012baaf74fd7688a156686b384d08
Author: mvignesh@redhat.com <mvignesh@redhat.com>
Date: Fri Oct 14 19:38:21 2016 +0530
libglusterfs : update correct message segments in glfs-message-id
Change-Id: I6611c5699303c879e6f5d88549f5101dd6f63e46
BUG: 1384989
Signed-off-by: Muthu-vigneshwaran <mvignesh@redhat.com>
Reviewed-on: https://review.gluster.org/15644
Tested-by: Muthu Vigneshwaran <muthuvigneshwaran77@gmail.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <manikandancs333@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 583ded30587389037594b6d26a8f473257c606dc
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Mar 9 12:18:40 2017 -0500
build/packaging: Debian and Ubuntu don't have /usr/libexec
GLUSTERFS_LIBEXECDIR is effectively hard-coded to /usr/libexec/glusterfs
in configure(.ac)
Debian-based distributions don't have a /usr/libexec/ directory
This issues is partially mitigated by the use of $libexecdir in
some of the Makefile.am files, but even so the incorrectly defined
GLUSTERFS_LIBEXECDIR results in various things such as gsyncd,
glusterfind, eventsd, etc., trying to invoke other scripts and
programs from a location that doesn't exist.
And once we correctly define GLUSTERFS_LIBEXECDIR, then we might as
well use it appropriatedly.
Change-Id: If5219cadc51ae316f7ba2e2831d739235c77902d
BUG: 1430841
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16880
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Joe Julian <me@joejulian.name>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit a990e4808185abefaa266ab40d351c11f1cbd615
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Feb 28 15:52:49 2017 +0530
storage/posix: Use granular mutex locks for pgfid update syscalls
Change-Id: Ie5d635951c483d858dc4be2a90fb24b8b5f4f02d
BUG: 1421938
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16869
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit f3778b0b8029fa9ef92607718034e777f8a01104
Author: Kevin Vigor <kvigor@fb.com>
Date: Thu Dec 15 13:41:14 2016 -0800
transport: allow OS to assign us a port
Replace complex and slow port selection code with bind(0) which
already respects privileged ports.
Change-Id: I408a8528e58e1aafcd32eba6a8f1a759e0bf274e
BUG: 1405628
Reviewed-on-release-3.8-fb: http://review.gluster.org/16150
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16178
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ed628bc9fce463b117069fe08acd569bc4f3be63
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Mar 9 09:29:49 2017 +0100
features/locks: Fix leak of posix_lock_t's client_uid
Change-Id: I3bc14998ed6a8841f77a004c24a456331048a521
BUG: 1428510
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/16838
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 00b47f141f1d81f67912754ae8128e47efb0ac45
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Mar 6 10:34:05 2017 -0500
performance/write-behind: Honor the client pid set
write-behind xlator does not honor the client pid being
set. It doesn't pass down the client pid saved in
'frame->root->pid'. This patch fixes the same.
Change-Id: I838dcf43f56d6d0aa1d2c88811a2b271d9e88d05
BUG: 1430608
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/16854
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit a87676c3354c0cb90e3ce144af63b27db7530c76
Author: Susant Palai <spalai@redhat.com>
Date: Wed Nov 9 16:39:44 2016 +0530
dht/rebalance: update op_errno for rebalance failures
function "rebalance_task_completion" did not honor returned values other
than -1 and 1. This led to ignoring errno e.g in the current bug,
ENOTSUP returned by __is_file_migratable and it returned
EINVAL(op_errno initialized) to it's caller leading to failure messages
logged in ERROR level.
Change-Id: I45549fba35c72b278539269b750768fd89e0faf2
BUG: 1393338
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: https://review.gluster.org/15810
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8c691e2e2eddd78dd830538d7d6f2ce81a78a993
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 9 12:49:27 2017 -0500
glusterfsd+libglusterfs: add null checks during attach
It's possible (though unlikely) that we could get a brick-attach
request while we're not ready to process it (ctx->active not set yet).
Add code to guard against this possibility, and return appropriate
error indicators.
Change-Id: Icb3bc52ce749258a3f03cbbbdf4c2320c5c541a0
BUG: 1430860
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16883
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 36f14ee9106cd4204b11cdcfa7bcc741803eee46
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Mar 7 18:36:58 2017 -0500
glusterd: don't queue attach reqs before connecting
This was causing USS tests to fail. The underlying problem here is
that if we try to queue the attach request too soon after starting a
brick process then the socket code will get an error trying to write
to the still-unconnected socket. Its response is to shut down the
socket, which causes the queued attach requests to be force-unwound.
There's nothing to retry them, so they effectively never happen and
those bricks (second and succeeding for a snapshot) never become
available.
We *do* have a retry loop for attach requests, but currently break out
as soon as a request is queued - not actually sent. The fix is to
modify that loop so it will wait some more if the rpc connection isn't
even complete yet. Now we break out only when we have a completed
connection *and* a queued request.
Change-Id: Ib6be13646f1fa9072b4a944ab5f13e1b29084841
BUG: 1430148
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16868
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit a6b88d7afe928f796fed3446f8800b38af663b97
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Mar 7 11:53:04 2017 -0500
glusterfsd: don't quit (in client) on connection failure
Change-Id: I32be91e9db361a45454d6340a4c4ac2d0d7efffc
BUG: 1430042
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16866
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 8ed23301dd64359487ca5ee9d8c2ec4f61a2a360
Author: Milind Changire <mchangir@redhat.com>
Date: Tue Feb 28 10:38:19 2017 +0530
extras/devel-tools: script to resolve bt addresses
Problem:
STACK_WINDs in a gluster backtrace dumped in a log file are
undecipherable with only the hex addresses of the location
leaving us without a clue.
Solution:
This utility uses the undeciphered lines in the backtrace and the
associated debuginfo rpm to generate the function name and the file and
line number associated with the stack frame.
Passing "none" as the debuginfo rpm name will make the script assume
that you want to resolve against a source install and not a debuginfo
rpm.
You would need to copy the unresolved lines from the backtrace into a
file and pass the name of this file to the utility as the input file.
Change-Id: I4d8bc1ae205af37688d03298de49654018bdba9d
BUG: 1426891
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/16763
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f36ac4e2eef2fcc0152e2fa759490a6e06ecaf21
Author: Michael Scherer <misc@redhat.com>
Date: Wed Mar 1 16:38:21 2017 +0100
Free the mutex even if we can't allocate a inode
Since GF_CHECK_ALLOC may jump to out, with a mutex locked,
we need to make sure the mutex is unlocked before returning.
Error found by coverity
Change-Id: I81011e18afc90c2c0fd489ceeb78d90ae31e35ba
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16793
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b7dae7300e45a99ffc77bc460c61045e7fb58be0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Mar 7 14:32:18 2017 +0530
cluster/ec: Don't mark dirty on entry/meta ops in query-info
We wanted to mark dirty for metadata/entry operations
whenever query-info is set and info is not yet there because we
are anyway sending xattrop over the network. But this is causing
25% regression from 3.8.8 so removing this optimization
Also fixed two small issues that we didn't find in the previous
patch
1) reconfigure failure was sending return value 0 for optimistic-changelog
2) ec->optimistic_changelog was set to true even before OPTION_INIT
BUG: 1408809
Change-Id: Iabb0b64bd4d3623688790e4b67e5c20b4da977a1
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/16865
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 3052a4723fd857fdaf1e62f10424dfcbddf20fa5
Author: Niklas Hambüchen <mail@nh2.me>
Date: Sat Feb 18 00:49:02 2017 +0100
posix: use nanosecond accuracy when available
Programs that set mtime, such as `rsync -a`, don't work correctly on
GlusterFS, because it sets the nanoseconds to 000. This creates
problems for incremental backups, where files get accidentally copied
again and again.
For example, consider `myfile` on an ext4 system, being copied to a
GlusterFS volume, with `rsync -a` and then `cp -u` in turn. You'd
expect that after the first `rsync -a`, `cp -u` agrees that the file
need not be copied.
BUG: 1422074
Change-Id: I89c7b6a73e2e06c02851ff76b7e5cdfaa271e985
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
Reviewed-on: https://review.gluster.org/16667
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 452b068881bdbf62743fbca8b22fbc586b716939
Author: Milind Changire <mchangir@redhat.com>
Date: Sun Mar 5 21:39:20 2017 +0530
rpc: avoid logging success on failure
Avoid logging Success in the event of failure especially when errno has
no meaningful value w.r.t. the failure. In this case the errno is set to
zero when there's indeed a failure at the RPC level.
Change-Id: If2cc81aa1e590023ed22892dacbef7cac213e591
BUG: 1426032
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/16730
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ebd5cd15549fa1169f37ec527685d06b90210484
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Wed Dec 14 08:24:01 2016 -0800
tests: Fix tests/bugs/distribute/bug-1161311.t
Summary:
- Bigger buffer size made rebalance faster and broke the test.
- We made the file bigger so rebalance takes longer.
BUG: 1428058
Change-Id: I7acfec5611b28bdae0a9d9fc03eb104659a5563a
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Author: Shreyas Siravara <sshreyas@fb.com>
Reviewed-on: https://review.gluster.org/16802
Tested-by: Vijay Bellur <vbellur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 7347fcf4eb56dae7e7b924a00bc302f87bc4bb2e
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Tue Jan 31 16:14:46 2017 +0530
glusterd : Fix for replicate and disperse volume option
While setting volume option(disperse-shd-max-threads) for
replicate volume and volume option(cluster-shd-max-threads)
for disperse volume, glusterd is not validating volume options
and setting all the values irrespective of proper validation
for disperse-shd-max-threads and cluster-shd-max-threads
Change-Id: Ic88815ad49e901e74ffc042170f5caabf7c17a89
BUG: 1417588
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-on: https://review.gluster.org/16489
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 9a534cb387c13930cb70e9784ff795dc1191cbce
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Feb 27 13:51:09 2017 +0530
glusterd: disallow increasing replica count for arbiter volumes
Problem: add-brick command to increase replica count in an arbiter
volume succeeds, causing undesirable effects like the 4th brick being
loaded with the arbiter xlator, the 3rd one losing the arbiter xlator
(when the brick process is restarted), arbitration logic in afr going
for a toss etc.
Fix: Arbiter configuration should always be a replica 3 volume (of
which 3rd brick is arbiter). Hence disallow increasing replica count for
arbiter volume configurations.
Change-Id: I9fe4edac880d0f711e6d44324ad5562974e53e51
BUG: 1429200
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/16845
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 360313ba434eecdc2921b966eb3fb6806781458b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sat Mar 4 01:04:10 2017 +0530
afr: restore atime/mtime for non-regular files
AFR restores atime/mtime only as a part of data heal. For non-regular
files (dirs, symlinks, char/block/socket files etc) which do not undergo
data-heal, atime/mtime is not restored.
This patch restores atime/mtime as a part of metadata heal for such
files.
Change-Id: Id8da885fc93fdf65c2f4bae2af3605b146ac1f16
BUG: 1429198
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/16844
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 90617e5b07a18b6d6a4a202a27efa273d105456c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 2 07:14:14 2017 +0530
cluster/ec: Introduce optimistic changelog in EC
Problem: Fix to https://bugzilla.redhat.com/show_bug.cgi?id=1316873 has made
changes to set dirty flag before every update fop, data or metadata, and unset
it after successful operation. That makes some of the fops very slow such as
entry operations or metadata operations.
Solution: File data operations are the only operation which take some time and
setting dirty flag before a fop and unsetting it after serves the purpose as
probability of failure of a fop is high when the time duration is more. For all
the other operations, set dirty flag at the end of the fop, if any brick is
down and need heal.
Providing following option to choose between high performance or better heal
marking for metadata and entry fops.
Set/Unset dirty flag for every update fop at the start of the fop. If ON, this
option impacts performance of entry operations or metadata operations as it
will set dirty flag at the start and unset it at the end of ALL update fop. If
OFF and all the bricks are good, dirty flag will be set at the start only for
file fops For metadata and entry fops dirty flag will not be set at the start,
if all the bricks are good. This does not impact performance for metadata
operations and entry operation but has a very small window to miss marking
entry as dirty in case it is required to be healed.
Thanks to Xavi and Ashish for the design
Picked the .t file from Ashish' patch https://review.gluster.org/16298
BUG: 1408809
Change-Id: I3ce860063f0e2901e50754dcfc3e4ed22daf819f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/16821
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Xavier Hernandez <xhernandez@datalab.es>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit b84f6c54368f82d53bccdac2f57dd6484a211617
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 17:09:46 2017 +0100
Fix bad free
Since rsp.path is assigned a constant string, free would
operate on a incorrect pointer, with likely bad results.
Found by coverity scan
Change-Id: I4befdd78573daa3c0c3013100f7ae69a2dcae36a
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16716
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 10459746bb3e83b83f70cd199d902473e6eb09be
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Feb 28 14:27:51 2017 +0530
storage/posix: Use more granular mutex locks for atomic writes
Change-Id: I7a5167de77fabf19c5151775b553913a1af5a765
BUG: 1421938
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16785
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit a1116f5ec9bff4cdd7397a8c4822955698980abd
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Oct 13 18:08:57 2016 +0200
doc: Added documentation about ec implementation
A new document explaining how ec encoding/decoding is implemented
has been added to the developer guide.
Change-Id: I344493477bf42b935ed75f7cf0574d54dc1b9509
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/15637
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit bf1a0c9fd6068a6d54a764a775fa2712e89abc49
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Mar 2 15:27:54 2017 +0530
cluster/dht: Fix crash in "nuke-dir" feature
My patch at https://review.gluster.org/16419 is resulting
in core dumps everytime I run tests/features/nuke.t.
Turns out dht, upon successfully "nuking" a directory,
which was initiated through a setxattr, unwinds the operation
with rmdir fop signature, resulting in readdir-ahead casting
a struct iatt (preparent) to dict_t, leading to a crash.
Change-Id: If5f50417be9eb93e731b06c79b9bf027e5dd4d55
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16829
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit e23d67b95d333db1c6c18e76366d6f7e9948f217
Author: Shyam <srangana@redhat.com>
Date: Wed Mar 1 14:30:14 2017 -0500
doc: Added a github issue template to redirect to mails or bugzilla
We currently see an increased activity by users filing github issues.
As we do not use github issues to track or respond to queries, adding
this template to help redirect users to the right forum.
Change-Id: Ied69af1c42b85e10018bbd83d48f7e6fa3c1f10b
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: https://review.gluster.org/16795
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 84da7fa1618e6301f00b8e2b2de78099103ce083
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Thu Aug 4 11:44:53 2016 -0700
dht/rebalance: Increase maximum read block size from 128 KB to 1 MB
Summary:
- The maximum block size, `DHT_REBALANCE_BLKSIZE`, is set to 128 KB.
- As a result, migrating files in the megabytes to gigabytes can take much longer than necessary.
- Some preliminary results by bumping the blocksize:
With 128 KB:
[2016-08-04 11:40:19.251167] I [MSGID: 109028] [dht-rebalance.c:2196:gf_defrag_status_get] 0-glusterfs: Rebalance is completed. Time taken is 15.00 secs
[2016-08-04 11:40:19.251189] I [MSGID: 109028] [dht-rebalance.c:2200:gf_defrag_status_get] 0-glusterfs: Files migrated: 49, size: 2569011200, lookups: 149, failures: 0, skipped: 0
With 1 MB:
[2016-08-04 11:41:21.093662] I [MSGID: 109028] [dht-rebalance.c:2196:gf_defrag_status_get] 0-glusterfs: Rebalance is completed. Time taken is 7.00 secs
[2016-08-04 11:41:21.093687] I [MSGID: 109028] [dht-rebalance.c:2200:gf_defrag_status_get] 0-glusterfs: Files migrated: 49, size: 2569011200, lookups: 149, failures: 0, skipped: 0
- This is a cherry-pick of D3670927 to 3.8.
Test Plan: Tested rebalance on devserver.
Reviewed By: dph, rwareing
Change-Id: Ide2edbf87ef9ae2b32a03f189c57b63e2f233fc8
BUG: 1428055
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Reviewed-on: https://review.gluster.org/16797
Tested-by: Vijay Bellur <vbellur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 01407e78e36d213779601cfa886b38dae4ed5008
Author: Richard Wareing <rwareing@fb.com>
Date: Fri Jun 3 20:39:36 2016 -0700
protocol/server: Fix crash bug in unlink flow
Summary: Fixes a crash bug during unlink in server-rpc-fops.c
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Change-Id: I049a9863ffd4003742276e0aa9e8d1224488182d
BUG: 1428093
Tested-by: Shreyas Siravara <sshreyas@fb.com>
Reviewed-on: https://review.gluster.org/16814
Tested-by: Vijay Bellur <vbellur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 86a47f32686b377b88cccc3ce25f3669eb1b13b3
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Mar 1 14:35:26 2017 -0800
glusterd: use sys_lstat instead of lstat
Showed up in 0symbol-check.t while testing something else. Might as
well fix it now.
Change-Id: Ic6b8214de6f486187afc4987c5ffbbca02c8997f
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16820
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ff3a009b1d5ee453da08820384f949dd03bdeee2
Author: Michael Scherer <misc@redhat.com>
Date: Thu Feb 23 22:29:28 2017 +0100
Do not use va_end before cli_rl_out, since it use ap
Trigger a cppcheck error
Change-Id: I8919fed47ef562319ac6baff38ed993e7cd54708
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16741
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 68fa2764e3565e5c491ce160ac4ca9d7bc352ac7
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Mar 1 12:48:10 2017 +0530
storage/posix: Set ret value correctly before exiting
Change-Id: I07c3a21c1c0625a517964693351356eead962571
BUG: 1427404
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16792
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit f33b1803f6193dcba2d893a10cc96ba4da01fb8f
Author: Nigel Babu <nigelb@redhat.com>
Date: Wed Mar 1 07:16:19 2017 +0530
Return ret as soon as `this` is freed
Omitting this return causes a confusing error message in the next block,
which is also a case of use after free. This bug was found by Coverity
scan.
BUG: 789278
Change-Id: Ifd4932de437e8ae875ff191033ea43cff81b701d
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: https://review.gluster.org/16790
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 90a2272f7fb737db2e81604fa7dc1f2367596ca7
Author: Niklas Hambüchen <mail@nh2.me>
Date: Tue Feb 28 14:05:59 2017 +0100
tests: Fix and enable split-brain-healing mtime check
This test was commented out with the belief that it depended
on utimensat() support, but in fact it was not necessary because
`stat -c %Y` only outputs second resolution.
Simply commenting in the test made it fail because it checked
the values *before* the heal, while intended was to check them
*after* the heal. This commit fixes that.
Change-Id: I4194ac645b365a1f906a3ac9bcbbdb1f05000e27
BUG: 1422074
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
Reviewed-on: https://review.gluster.org/16789
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niklas Hambüchen
commit 171544b5a4203487d57e53c1190fc05a4ae32b94
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Feb 23 17:58:46 2017 +0530
rpc: log more about socket disconnects
Log more about the different paths leading to socket disconnect for ease
of debugging.
Log via gf_log_callingfn() in __socket_disconnect() at loglevel TRACE if
socket connection is being torn down.
Change-Id: I1e551c2d685784b5ec747f481179f64d524c0461
BUG: 1426125
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/16732
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit de9e0842a5d111a912037857369a5198086c1ad9
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Feb 28 13:13:59 2017 +0530
rpc/clnt: remove locks while notifying CONNECT/DISCONNECT
Locking during notify was introduced as part of commit
aa22f24f5db7659387704998ae01520708869873 [1]. The fix was introduced
to fix out-of-order CONNECT/DISCONNECT events from rpc-clnt to parent
xlators [2]. However as part of handling DISCONNECT protocol/client
does unwind saved frames (with failure) waiting for responses. This
saved_frames_unwind can be a costly operation and hence ideally
shouldn't be included in the critical section of notifylock, as it
unnecessarily delays the reconnection to same brick. Also, its not a
good practise to pass control to other xlators holding a lock as it
can lead to deadlocks. So, this patch removes locking in rpc-clnt
while notifying parent xlators.
To fix [2], two changes are present in this patch:
* notify DISCONNECT before cleaning up rpc connection (same as commit
a6b63e11b7758cf1bfcb6798, patch [3]).
* protocol/client uses rpc_clnt_cleanup_and_start, which cleans up rpc
connection and does a start while handling a DISCONNECT event from
rpc. Note that patch [3] was reverted as rpc_clnt_start called in
quick_reconnect path of protocol/client didn't invoke connect on
transport as the connection was not cleaned up _yet_ (as cleanup was
moved post notification in rpc-clnt). This resulted in clients never
attempting connect to bricks.
Note that one of the neater ways to fix [2] (without using locks) is
to introduce generation numbers to map CONNECT and DISCONNECTS across
epochs and ignore DISCONNECT events if they don't belong to current
epoch. However, this approach is a bit complex to implement and
requires time. So, current patch is a hacky stop-gap fix till we come
up with a more cleaner solution.
[1] http://review.gluster.org/15916
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1386626
[3] http://review.gluster.org/15681
Change-Id: I62daeee8bb1430004e28558f6eb133efd4ccf418
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
BUG: 1427012
Reviewed-on: https://review.gluster.org/16784
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 28eb935e4428f18f798559c95196d738fdb80673
Author: Nigel Babu <nigelb@redhat.com>
Date: Tue Feb 28 13:13:36 2017 +0530
Free brick_hint at the end of the function
Not freeing brick_hint causes a memory leak. This error was reported by
Coverity.
Change-Id: Ic923f892ea5207848cdd3fa6332a1e52e6c996b8
BUG: 789278
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: https://review.gluster.org/16782
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bd1655e58f950fa67fc93c38b48c16ed148e6e57
Author: Michael Scherer <misc@redhat.com>
Date: Thu Feb 23 20:17:25 2017 +0100
Use int instead of int8_t for the 3 variables
Since strcmp return a int, and since the spec
of strcmp do not tell the return value, it
could return 256 and this would overflow.
Found by Coverity scan.
(thanks to Stéphane Marcheusin who explained
the details to me)
Change-Id: I5195e05b44f8b537226e6cee178d95a1ab904e96
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16738
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 695e5970f3c8a8f8518db877168e17877869a86c
Author: Michael Scherer <misc@redhat.com>
Date: Tue Feb 28 15:02:18 2017 +0100
Free arg_save when malloc fail
Warning found by coverity.
Change-Id: Ie755659c33a43a440dadfeb1499a2f6c08e3f625
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16788
Tested-by: Michael Scherer <misc@fedoraproject.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 61cc2471144969578eced747a26addd8606df44a
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Feb 28 11:45:44 2017 +0530
tests: Mark tests/bitrot/bug-1373520.t bad until fixed
Change-Id: Ic0b5c93c6365e26a5742184dd9445354c0a57295
BUG: 1427404
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16780
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 2b9f42f91ff82bdf7731f3b75582aafd187f3356
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 22 09:49:05 2017 +0530
protocol/client: Add gfid in request for better tcpdumps
It is difficult to match opendir/releasedir or
open/release calls without gfid associlation to find
fd-leaks on the bricks. So assigning gfid also in
the request which was already there in the on-wire
format.
BUG: 1425676
Change-Id: Iec908eeaa2f97295d45140a529b7f8fb834a1553
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/16706
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ef28c3f048b2cb719b7dfa32a119289c3491386b
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Feb 27 11:20:14 2017 +0530
socket: Avoid flooding of SSL messages in case of failure/success
Problem: Avoid flodding of SSL messages in case of failure/success
Solution: 1) Ideally ssl_setup_connection should be call after getting success on
connect so update the condition before call socket_spawn in socket_connect.
2) Change the message type to debug in case of success.
BUG: 1427018
Change-Id: Icb6101e49304d5fe539609b4afacfb1b50b62f84
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/16767
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit b691838268be7e995c451a51e8bcd1aaab512050
Author: Nigel Babu <nigelb@redhat.com>
Date: Mon Feb 27 11:07:16 2017 +0530
glusterd: Fix the incorrect check
err_str is an array and is therefore never NULL. This condition would
always be false.
Change-Id: I31eb3338986a3af584e0feca8ec3e16f738378ec
BUG: 789278
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: https://review.gluster.org/16766
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 7025bf65be47031ab8bdadc770da2763a4d09b82
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 18:04:59 2017 +0100
Remove double free for disk_layout
Since disk_layout is freed after the jump to err, we
do not need to free it again before the goto.
Found by coverity scan.
Change-Id: Ie0c0262f6b95c51c61a59faefbca70352bf1e604
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16720
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6e4fd263015c0fc6145d22ce528e64eff4f575e7
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Mon Feb 20 18:35:01 2017 +0530
core: Clean up pmap registry up correctly on volume/brick stop
This commit changes the following:
1. In glusterfs_handle_terminate, send out individual pmap signout
requests to glusterd for every brick.
2. Add another parameter to glusterfs_mgmt_pmap_signout function to
pass the brickname that needs to be removed from the pmap registry.
3. Make sure pmap_registry_search doesn't break out from the loop
iterating over the list of bricks per port if the first brick entry
corresponding to a port is whitespaced out.
4. Make sure the pmap registry entries are removed for other
daemons like snapd.
Change-Id: I69949874435b02699e5708dab811777ccb297174
BUG: 1421590
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/16689
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 53dbe278ebfdd957260efde8cbf7d1a4d369f132
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun Feb 26 23:00:21 2017 +0530
glusterd: add portmap details in glusterd statedump
glusterd statedump file doesn't have information on the ports and its
associated brick details. This is quite problematic if any setup ends up
with stale ports and the only way to find the issue out is to gdb into
the process which is always not available. This patch attempts to fill
in this gap.
Change-Id: I26b4fe753d752366ddf865ca3eeae3b4d577d555
BUG: 1426948
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16764
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 91788ff3b9ea980a989be9c8b17d1e65184fc4d5
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Jan 23 17:40:40 2017 +0530
storage/posix: Execute syscalls in xattrop under different locks
... and not inode->lock. This is to prevent the epoll thread from
*potentially* being blocked on this lock in the worst case for
extended period elsewhere in the brick stack, while the syscalls
in xattrop are being performed under the same lock by a different
thread. This could potentially lead to ping-timeout, if the only
available epoll thread is busy waiting on the inode->lock, thereby
preventing it from picking up the ping request from the client(s).
Also removed some unused functions.
Change-Id: I2054a06701ecab11aed1c04e80ee57bbe2e52564
BUG: 1421938
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16462
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit bd3ce77740f58646655311305766d8f87a74c8ed
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Oct 19 15:20:45 2016 +0530
protocol/mgmt: sending wrong return value during emancipation
A change introduced for moving emancipation after signin process
cause this regression, where the second signin always return the
size of process xdr.
This patch will fix the issue.
Change-Id: Ic924c82abe6932a93abe37df1fd2d1285a77ed0a
BUG: 1386578
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: https://review.gluster.org/15687
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit cfbe50287498658aaee5380379c1217a3335c989
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jan 25 15:31:44 2017 +0530
cluster/ec: Don't trigger data/metadata heal on Lookups
Problem-1
If Lookup which doesn't take any locks observes version mismatch it can't be
trusted. If we launch a heal based on this information it will lead to
self-heals which will affect I/O performance in the cases where Lookup is
wrong. Considering self-heal-daemon and operations on the inode from client
which take locks can still trigger heal we can choose to not attempt a heal on
Lookup.
Problem-2:
Fixed spurious failure of
tests/bitrot/bug-1373520.t
For the issues above, what was happening was that ec_heal_inspect()
is preventing 'name' heal to happen
Problem-3:
tests/basic/ec/ec-background-heals.t
To be honest I don't know what the problem was, while fixing
the 2 problems above, I made some changes to ec_heal_inspect() and
ec_need_heal() after which when I tried to recreate the spurious
failure it just didn't happen even after a long time.
BUG: 1414287
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Change-Id: Ife2535e1d0b267712973673f6d474e288f3c6834
Reviewed-on: https://review.gluster.org/16468
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
commit bead6bf558be053ab3cbd8f86121e8bf41baa545
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Nov 18 10:05:12 2016 -0500
events: use attribute(format(/printf)) to catch fmt string errors
and statedump too. Also "const char *" (versus just "char *") for the
fmt param.
Change-Id: Ic63734a673208a2cd49aebccce7659816e6179e3
BUG: 1399196
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/15881
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 891a174c534e1c1321e10bb147d8658bdb5dc58d
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Oct 26 20:16:23 2016 -0400
build: fixes to build 3.9.0rc2 on Debian
Add glustereventsd-Debian(.in) and associated Makefile(.am)
and configure(.ac) changes
Add UUIDLIBS to fdl's librecon
Change-Id: Ibff821691023704978140eaaff2c6532b74c50fa
BUG: 1389127
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/15737
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Joe Julian <me@joejulian.name>
commit d529d9bef9327c123df878dec326344875f138b0
Author: Michael Scherer <misc@redhat.com>
Date: Fri Feb 24 21:35:38 2017 +0100
mgmt: Reset conf_fd to default value to avoid double close
Coverity warn of a path where we use sys_close 2 times on the
same file descriptor, which is likely harmless but could
cause various hard to debug problems if threads are used
(since the file descriptor table is shared among all
threads, we could close a newly opened fd by another thread).
Change-Id: I0524b31dccc0da94c7b87583e2a88ef06e003518
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16758
Tested-by: Michael Scherer <misc@fedoraproject.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 3e6f40b7ec5011d14bf55c5b9585ca0d23af0ff8
Author: Michael Scherer <misc@redhat.com>
Date: Fri Feb 24 12:41:45 2017 +0100
dnt: Add a GF_DEFRAG_CMD_NONE to gf_defrag_type
Coverity complain about enum mismatch since we assign GF_OP_CMD_NONE
to a variable holding gf_defrag_type.
Change-Id: I63e71f552b3cc752c26c1b8705420f38908e17e6
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16756
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f7d4247e80078dd9be68b5ccfbeee5439a98e90d
Author: Michael Scherer <misc@redhat.com>
Date: Thu Feb 23 21:35:45 2017 +0100
dnt: Fix crash when showing the error message
Since this is NULL, this->name would crash the
daemon if a incorrect rebal_entry is passed.
Found by coverity scan.
Change-Id: Ieddf1ef097d13711ab8ec9cd24e125914d2e7245
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16740
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 2003d2c490f85f52198da5ff1303b304108010e0
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 17:58:24 2017 +0100
Free iobuf after using it, not before
Coverity warn of use after free here. I assume that
under pressure, this might crash the whole process.
Change-Id: I15fb5cfc9b509705e96e4156b739988d816bbef5
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16719
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ee885ee7e366dd70bab3aa09c97b4218697852bb
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 17:27:43 2017 +0100
Reorder the variable initialisation
Found by coverity, since is_hot_tier is assigned to false,
tier_type was always "hot" rather than "cold", making
potential debugging likely harder.
Change-Id: I49bce1c184548c5de5c00639e83fc3d2dbed90b2
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16717
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 9aef9f5c645022d23e54f1a86856988cfe739420
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 17:34:02 2017 +0100
Remove deadcode
Found by coverity, ret is already test in the previous 'if'.
Change-Id: Iefb7da07c1144470c2322f44b28f98a5904343b4
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16718
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit e065ea3d8eabbba8defc4c13bba9bbdc5f6b09e8
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 16:31:30 2017 +0100
Remove unused conditionnal
The code is using a got to jump 1 line further, which is
a no-op. Found by coverty scan
Change-Id: Ic8698e2f86ebd9472b3104b09920ab7946c3b4fc
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16714
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 89befd87942b18bb968afe849261efb087b739c1
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 16:21:11 2017 +0100
Remove deadcode, found by coverty
Since ret value is unchanged since last goto out, this
code is unreachable.
Change-Id: Iff8618739900b44bad6c4e663a4201d9e14cb457
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16713
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d6e3be89d261edeeba4766dd14f9ff907e170211
Author: Nigel Babu <nigelb@redhat.com>
Date: Mon Feb 20 08:27:51 2017 +0530
libglusterfs, gfdb, glusterfs: Add missing breaks
A few switches did not have breaks causing fall throughs. Most of them
have been fixed with fall through comments for those that are
intentional.
Change-Id: I84c85726b542f38504b50fefab5eba5dbcd27a07
BUG: 1424894
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: https://review.gluster.org/16677
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 2437524b8d746ceb7ed04ba947cfa3da389259d0
Author: Nigel Babu <nigelb@redhat.com>
Date: Thu Feb 23 15:13:43 2017 +0530
cli: fix error when HAVE_READLINE is false
When HAVE_READLINE is false, Gluster doesn't compile with -Werror flag.
This will fix it up so it is possible to compile without having readline
present
Change-Id: Ia6620b5a372318d10f0e908e3d45f4090f99d118
BUG: 1426052
Reviewed-on: https://review.gluster.org/16734
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Nigel Babu <nigelb@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 9604b1f06a15f43a8a07a3ccad051ea3fd34d48d
Author: Michael Scherer <misc@redhat.com>
Date: Sun Feb 19 11:06:56 2017 +0100
Filter coverty false positives
Since random is not used for anything cryptographically related,
it is fine to use it in those instances.
Change-Id: I720172285f60d6bc477c7169c7286fc018ebdf8f
BUG: 1424764
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16668
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Nigel Babu <nigelb@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 7d118ae3516af56c48d6f75a8fb2a6dcd99e82fe
Author: Michael Scherer <misc@redhat.com>
Date: Thu Feb 23 23:24:42 2017 +0100
Do not call va_end twice in _gf_log_eh
Since va_end is called after the out label,
we do not need to call it here, as it make va_end undefined,
and thus could cause problem. And this is a error
on cppcheck.
Change-Id: I6e96c796bd37fa3cde989996ab93f9a438c0ee74
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16745
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 65602f2fb6bf3506afa6e4468f31e0bdb0e38a9a
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 21:46:14 2017 +0100
Make sure that buffer is null terminated
Coverity warn about it, and while that's unlikely
to be a issue in practice, it is rather important
to not mask more critical problems with false positive.
Change-Id: Ibee1a9c37e216635077f05d5ef5de55ad5e0b051
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16727
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 29ebd75ae3f4615cd33f08e48100c289ad25e268
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Feb 24 10:53:57 2017 +0530
glusterd : log improvements in glusterd_op_stage_rebalance ()
Include volume names in the respective staging failure error logs in
rebalance staging
Change-Id: Iaaab12a552930dd5274fbecec78f5735f883ab6b
BUG: 1426509
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16746
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit cce598473057bcb27929e1bf25859d673abe3022
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue May 17 15:37:18 2016 +0530
features/shard: Fix EIO error on add-brick
DHT seems to link inode during lookup even before initializing
inode ctx with layout information, which comes after
directory healing.
Consider two parallel writes. As part of the first write,
shard sends lookup on .shard which in its return path would
cause DHT to link .shard inode. Now at this point, when a
second write is wound, inode_find() of .shard succeeds and
as a result of this, shard goes to create the participant
shards by issuing MKNODs under .shard. Since the layout is
yet to be initialized, mknod fails in dht call path with EIO,
leading to VM pauses.
The fix involves shard maintaining a flag to denote whether
a fresh lookup on .shard completed one network trip. If it
didn't, all inode_find()s in fop path will be followed by a
lookup before proceeding with the next stage of the fop.
Big thanks to Raghavendra G and Pranith Kumar K for the RCA
and subsequent inputs and feedback on the patch.
Change-Id: I9383ec7e3f24b34cd097a1b01ad34e4eeecc621f
BUG: 1420623
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/14419
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 9525159f9a146a1e70364908d7ebc0d47c073440
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Feb 22 13:55:00 2017 -0500
gfapi: OBS build fails in post build analysis
Originally gfapi: create statedump when glusterd requests it
When GlusterD sends the STATEDUMP procedure to the libgfapi client, the
client checks if it matches the PID that should take the statedump. If
so, it will do a statedump for the glfs_t that is connected to this mgmt
connection.
See https://bugzilla.redhat.com/show_bug.cgi?id=1169302#c25 for the
OpenSuSE Build System post build analysis error.
See Change-Id: I70d6a1f4f19d525377aebc8fa57f51e513b92d84
https://review.gluster.org/#/c/16415/
Change-Id: I7775f44ce13e20c831e8f1015816a28471d35bb4
BUG: 1169302
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16722
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 4323c38ee2e729f1e027f641ea38cfaacd1d8732
Author: Michael Scherer <misc@redhat.com>
Date: Wed Feb 22 22:08:51 2017 +0100
nfs: remove include of mount3.h
While there is proper protection against that, coverity
complain of a loop, and nothing in auth-cache.h use
a declaration of "mount3.h".
Change-Id: I55885ec12496359170f271ae192e9940a35121e1
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16728
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 04c17f9e0db02aebff18258590a22b48c654485c
Author: Nigel Babu <nigelb@redhat.com>
Date: Sat Feb 18 14:02:30 2017 +0530
libglusterfs, dht, locks, glusterd: Coverity fixes
Fix up use after free bugs and dead code
Change-Id: I8f79ed6b5108926c1fac31c147b5ecba79d10785
BUG: 1424905
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: https://review.gluster.org/16666
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 3f8dc46cd33787ebdfc2fb9e87e7c22b9bdc4c3a
Author: Michael Scherer <misc@redhat.com>
Date: Sun Feb 19 15:18:56 2017 +0100
Properly verify the return code of fcntl
Coverty scan complain about it, even if in practice, this
doesn't seems to have much impact.
Change-Id: I513f7d393889625d22dded25ef4c7477f68d1064
BUG: 1424793
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16671
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Nigel Babu <nigelb@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
commit aacb9744175fa0cbb838449bcbeb97bbe0ccd8bd
Author: hari gowtham <hgowtham@redhat.com>
Date: Wed Feb 22 15:19:20 2017 +0530
TESTS/TIER: bug-1303028-Rebalance-glusterd-rpc-connection-issue.t
PROBLEM: spurious failure of the test.
CAUSE: the function "rebalance_run_time" calculates the total time
the tier has been running for. this being a test case, the run time
of tier can be 0 and when the function adds up zero it results in
zero. and thus it starts to fail.
FIX: Give it some time for the function to add up the values.
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Change-Id: Ie270f3f3c8942081cca85dc49ef8fec76f3a261a
BUG: 1425743
Reviewed-on: https://review.gluster.org/16711
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 55714e88c5aa8666306db90e45b370da61e22db5
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Feb 22 14:43:46 2017 +0530
features/shard: Put onus of choosing the inode to resolve on individual fops
... as opposed to adding checks in "common" functions to choose the inode
to resolve based local->fop, which is rather ugly and prone to errors.
Change-Id: Ia46cc59992baa2979516369cb72d8991452c0274
BUG: 1420623
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16709
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 319f31c53e3fee3eb149355d5e45ed1679d12adc
Author: Shyam <srangana@redhat.com>
Date: Tue Feb 21 10:51:27 2017 -0500
tests: Added check for NFS export availability to quota-anon-fd-nfs.t
Change-Id: I15a9441267c18bb1073d14db325c98fa497f2fb7
BUG: 1425515
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: https://review.gluster.org/16701
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: sanoj-unnikrishnan <sunnikri@redhat.com>
commit 5e6308e6d6904f443747d6cc4b736a6c1b29ce18
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Tue Feb 21 22:35:47 2017 +0530
glusterd : cluster.brick-multiplex validation is missing while setting it
Currently glusterd allow setting all values while setting cluster.brick-multiplex
option. Validation of allowed options is missing.
With this patch glusterd will validate the values given while setting
cluster.brick-multiplex.
Change-Id: I938fb16b8f5faa9d31326373cd18632b8aa7ebab
BUG: 1425288
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-on: https://review.gluster.org/16704
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 13ea4830cfa74b1cbfa530d8b30967b19df97883
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Nov 16 16:19:14 2016 +0530
snapshot/scheduler: Set sebool cron_system_cronjob_use_shares to on
Rhel 7.1 onwards, the user has to manually set the
selinux boolean 'cron_system_cronjob_use_shares' as
on, if selinux is enabled for snapshot scheduler to
work.
With this fix, we are automating that bit, in init step
of snapshot scheduler
Change-Id: I5c1d23c14133c64770e84a77999ce647526f6711
BUG: 1395643
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: https://review.gluster.org/15857
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 5e36b1882d05159ad6614cd370854d51720d025d
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Feb 21 18:33:14 2017 +0530
glusterd: unref brickinfo object on volume stop
If brick multiplexing is enabled, on a volume stop glusterd was not
unrefing the brickinfo rpc object which lead to a flood of stale rpc
logs.
Change-Id: I18fedcd6921042ef2e945605466194b7b53fe2f7
BUG: 1421724
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16699
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
commit 238873c3d1ccd774e47e7ca5ee7a3b2ae6f9a81c
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Feb 14 11:12:58 2017 +0100
cluster/ec: Fallback to precompiled code
When dynamic code generation fails for some reason, instead of causing
a failure in encode/decode, fallback to the precompiled version.
Change-Id: I4f8a97d3033aa5885779722b19c6e611caa4ffea
BUG: 1421955
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/16614
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 085655a92d2b84d3b096e6cd42e4b59eff77e3f8
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Feb 16 20:32:36 2017 +0100
rpm: replace renamed python-gluster with python2-gluster
When upgrading from < 3.10, the old python-gluster package causes
conflicts with the newly renamed python2-gluster package.
This can be solved by adding the appropriate Provides and Obsoletes to
the python2-gluster RPM. Details on renaming packages are listed on the
Fedora Packaging Guidelines.
Change-Id: Ib143bf69022c45abe2d5e8d31d3375a6b85f75da
URL: https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
BUG: 1414902
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16649
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
commit 578b22e151b4da9f081433d894289a874ec74e16
Author: Michael Scherer <misc@redhat.com>
Date: Sun Feb 19 16:54:39 2017 +0100
Fix erronous comparaison of flags
Using a binary 'or' mean that we always send the
UUID, even when not required.
Found by coverty scan
Change-Id: Ifc4bff6b2f64febd5d2f038538218c2183518fd5
BUG: 1424815
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16675
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit cb13517e8e9bc0347234691a94e7d6e163b6d2a6
Author: Michael Scherer <misc@redhat.com>
Date: Sun Feb 19 14:51:27 2017 +0100
Initialize path, since coverty detect a code path where we do a free on a unitialized pointer (if jbr_get_changelog_dir fail).
Change-Id: Ib68122bb9eddaeb422028f834856a0776ecbb789
BUG: 1424791
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16670
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Nigel Babu <nigelb@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 7596bb6cd6323129b86959d75a3f96a2cbe2487b
Author: Michael Scherer <misc@redhat.com>
Date: Sun Feb 19 16:16:00 2017 +0100
Ressources used by va_start must be freed with va_end
Coverty warn of the defect.
Change-Id: Ie86684520e1d5b41237ab8d3247c24564a1a8639
BUG: 1424802
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16673
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 42fbf4c5d540c796b6a5bc99aba2fa1161b2560a
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Feb 20 09:48:46 2017 +0100
contributors: map more email addresses and domain names
While checking the statistics for the upcoming release, I noticed some
new names, emailaddresses and domains. Adding the ones for which the
mapping is obvious or for which people replied to my request for
clarification.
Steps to get the more up-to-date statistics (once merged):
$ git checkout master
$ ./extras/who-wrote-glusterfs/who-wrote-glusterfs.sh v3.9dev..origin/release-3.10
...
Change-Id: I4ab85fdbdb53d09a70a659555b8341cf9376167c
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16688
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 657d9639254786a857f78740ee40a82437f10696
Author: Michael Scherer <misc@redhat.com>
Date: Sun Feb 19 16:38:24 2017 +0100
Remove the useless goto
ret cannot be 0, since the error code for gf_store_save_value is
-1. And the label of the goto is just after the goto, so that's
deadcode.
Change-Id: I227bca41f4d0755891b8e6e0f4cb2ce004615a35
BUG: 1424809
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16674
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Nigel Babu <nigelb@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit e83200b72fc607186ea64aca78965de6562fc159
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Feb 16 13:05:25 2017 +0530
marker: Fix inode value in loc, in setxattr fop
On recieving a rename fop, marker_rename() stores the,
oldloc and newloc in its 'local' struct, once the rename
is done, the xtime marker(last updated time) is set on
the file, but sending a setxattr fop. When upcall
receives the setxattr fop, the loc->inode is NULL and
it crashes. The loc->inode can be NULL only in one valid
case, i.e. in rename case where the inode of new loc
can be NULL. Hence, marker should have filled the inode
of the new_loc before issuing a setxattr.
marker_rename_cbk was already fixed in a previous commit.
Fixing marker_rename_done to send valid inode in this commit.
Also in upcall check for NULL inode so that there is no crash.
Change-Id: I3ed2a05118fed3367dfe3251ce4477310cb480d0
BUG: 1422776
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16633
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2053f41fc3363ae78865501d25128bab67af2588
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Feb 15 11:18:31 2017 +0530
libglusterfs: Fix a crash due to race between inode_ctx_set and inode_ref
Issue:
Currently inode ref count is gaurded by inode_table->lock, and
inode_ctx is gauarded by inode->lock. With the new patch [1]
inode_ref was modified to change the inode_ctx to track the ref
count per xlator. Thus inode_ref performed under inode_table->lock
is modifying inode_ctx which has to be modified only under inode->lock
Solution:
When a inode is created, inode_ctx holder is allocated for all the xlators.
Hence in case of inode_ctx_set instead of using the first free index in
inode ctx holder, we can have predecided index for every xlator in the graph.
Credits Pranith K <pkarampu@redhat.com>
[1] http://review.gluster.org/13736
Change-Id: I1bfe111c211fcc4fcd761bba01dc87c4c69b5170
BUG: 1423373
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16622
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 4a162e971a4099e3b9b96fbf7718652e2987e1ff
Author: Mateusz Slupny <mateusz.slupny@appeartv.com>
Date: Tue Nov 29 12:09:49 2016 +0100
rpc: fix obvious typo in cleanup code in rpc_clnt_notify
Change-Id: I003e38b238704d3345d46688355bcf3702455ba1
BUG: 1399593
Signed-off-by: Mateusz Slupny <mateusz.slupny@appeartv.com>
[ndevos: rebased after I8ff5d1a32 moved the code around]
Reviewed-on: https://review.gluster.org/15969
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 23f4ce997f4a3064502bb5e5ce24d24250fb9d55
Author: Michael Scherer <misc@redhat.com>
Date: Sun Feb 19 15:36:27 2017 +0100
Remove deadcode, found by covertyscan
Since ctx_dict is either assigned to the value of aggr,
or we goto to out, there is no need for a 2nd goto.
Change-Id: I6c4295c61e6ff412ed7b85421dcae13df8088d7c
BUG: 1424796
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16672
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 810ad2b1d9a53bf14625f09e1e4d3179820257df
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Jan 10 17:21:56 2017 +0100
posix: Fix creation of files with S_ISVTX on FreeBSD
On FreeBSD the S_ISVTX flag is completely ignored when creating a
regular file. Since gluster needs to create files with this flag set,
specialy for DHT link files, it's necessary to force the flag.
This fix does this by calling fchmod() after creating a file that
must have this flag set.
Change-Id: I51eecfe4642974df6106b9084a0b144835a4997a
BUG: 1411228
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/16417
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 55b68079526c51e79790872782c1b1bbef37a72f
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Feb 17 14:05:25 2017 +0530
glusterd, readdir-ahead: Fix backward incompatibility
Issue:
Any opion is spcified in two places: In the options[] of xlator
itself and glusterd-volume-set.c. The default value of this option
can be specified in both the places. If its specified only in xlator
then the volfile generated will not have the option and default value,
it will be assigned during graph initialization.
With patch [1] the option rda-request-size was changed from INT to SIZET
type, and default was changed from 131072 to 128KB, but was specified
only in the readdir-ahead.c. Thus with this patch alone the volfile
entry for readdir-ahead looks like:
volume patchy-readdir-ahead
type performance/readdir-ahead
subvolumes patchy-read-ahead
end-volume
With patch [2], the default of option rda-request-size was specified
in glusterd-volume-set.c as well(as it was necessary fr parallel readdir).
With this patch the readdir entry in the volfile will look like:
volume patchy-readdir-ahead
type performance/readdir-ahead
option rda-cache-limit 10MB
option rda-request-size 128KB
option parallel-readdir off
subvolumes patchy-read-ahead
end-volume
Now consider the server has both these patches and client doesn't.
Server will generate a volfile with entry:
The old clients which thought the option rda-request-size is of type
INT will now recieve the value 128KB which it willn't understand,
and hence fail the mount.
The issue is seen only with the combination of [1] and [2].
Solution:
Instead of specifying 128KB as default in glusterd we specify 131072
so that the old clients will interpret as INT and new ones as 128KB
Credits: Raghavendra G
Change-Id: I0c269a5890957fd8a38e9a05bdec088645a6688a
BUG: 1423410
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16657
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit f4cfbec37ff0d4c35f665a7daaf0297f963f0987
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Feb 17 09:42:46 2017 -0500
glusterd: take conn->lock around operations on conn->reconnect
Failure to do this could lead to a race in which a timer would be
removed twice concurrently, corrupting the timer list (because
gf_timer_call_cancel has no internal protection against this) and
possibly causing a crash.
Change-Id: Ic1a8b612d436daec88fd6cee935db0ae81a47d5c
BUG: 1421721
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16662
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 04e536ac81b7a05bb919082fab0e1593fd8319f6
Author: Anoop C S <anoopcs@redhat.com>
Date: Fri Feb 17 12:37:27 2017 +0530
build: Add gf_attach to glusterfs-server package
Previously gf_attach was listed under glusterfs-fuse sub-package which
introduced the dependency for glusterfs-api. So as per the discussion
on gluster-devel[1] moving it to glusterfs-server.
[1] http://lists.gluster.org/pipermail/gluster-devel/2017-February/052111.html
Change-Id: I3d646d7c2e556d8f37e6da67bdedd0738739e01b
BUG: 1423448
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: https://review.gluster.org/16660
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d480dca111c95e1452765e42c08970fcc8a852b4
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Thu Feb 16 13:02:20 2017 +0530
glusterd : Fix for error message while removing brick
When remove-brick command is issued to a offline brick, glusterd
error out the operation with message -: "volume remove-brick start:
failed: Found stopped brick <hostname>:".
With this fix while removing brick, error message is modified
to "volume remove-brick start: failed: Found stopped brick
<brick path>. Use force option to remove the brick"
Change-Id: Id40a02fc38cdb526c4629de262967fe2383febe4
BUG: 1422624
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-on: https://review.gluster.org/16630
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 30da31f195bdb67ad1196fde22ce40703d3c770e
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Feb 17 12:17:18 2017 +0530
readdir-ahead: Remove unnecessary logging
dict_get_int can return < 0 when key is not found is a valid case.
Hence no need to log.
Change-Id: If0795b0f178adbb94b10efc563506993f7411962
BUG: 1423369
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16654
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c84f266ee957b6e90e0c3fc4242de46a6d425075
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Feb 9 15:56:04 2017 +0530
extras: Add more options to group virt
Apart from some of the option configurations already listed
in the group-virt.example file, we also recommend that the
users set certain other options added by this patch for
VM use-case. This also helps Gluster-oVirt users in configuring
virt options for new volumes at the click of a button as opposed
to setting them manually through volume-set command.
Change-Id: I8524e8d8a06bbbb0b9247571706e786410013b41
BUG: 1418900
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16577
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Sahina Bose <sabose@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit a98e39d53e36130f56bb5540ef0b98d2bfe9d2e4
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Feb 16 09:58:15 2017 +0100
build: fix linking of 'gf_logdump' and 'gf_recon'
When linking the 'gf_recon' and 'gf_logdump' binaries on certain OS's
(Debian?), the following error is returned and compilation aborts:
Making all in src
CCLD gf_recon
Makefile:617: recipe for target 'gf_recon' failed
Furher inspection showed this failure:
/lib/x86_64-linux-gnu/libuuid.so.1: error adding symbols: DSO missing from command line
'gf_recon' and 'gf_logdump' link against libgfapi, and also need to pass the
additional used libraries on the 'ld' commandline.
Change-Id: I7401023f154dde46443f0186dda8ba749951234c
Reported-by: chawlanikhil24 (on IRC)
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16639
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 1b71065cc49518318f5fe7531fbe2224a880eabf
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Feb 14 20:47:48 2017 +0530
performance/decompounder: Have terminal value in options[]
Absence of terminal values is leading to buffer-over-flow errors in
address sanitizer.
BUG: 1422152
Change-Id: I769c0e4b5bbb3ef2849b8d1097b9def522ae08d9
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/16615
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 8f4ee19407258562f5cb6c883555543643af569f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jan 23 14:58:45 2017 +0530
cluster/afr: Perform new entry mark before creating new entry
There is a chance for the source brick to go down just after
the new entry is created and before source brick is marked with
necessary pending markers. If after this any I/O happens then
new entry will become source and reverse heal will happen.
To prevent this mark the pending xattrs before creating the new
entry.
BUG: 1417466
Change-Id: I233b87e694d32e5d734df5a83b4d2ca711c17503
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/16474
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 8f79141183fd689a958e36ed924bdac84fdb7070
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Feb 15 03:44:17 2017 -0500
geo-rep: Fix xsync crawl
If stime is set to (0, 0) on master brick root, it
is expected to do complete sync ignoring the stime
set on sub directories. But while initializing the
stime variable for comparison, it was initailized
to (-1, 0) instead of (0, 0). Fixed the same.
The stime is set to (0, 0) with the 'reset-sync-time' option
while deleting session.
'gluster vol geo-rep master fedora1::slave delete reset-sync-time'
The scenario happens when geo-rep session is deleted as above and
for some reason the session is re-established with same slave volume
after deleting data on slave volume.
Change-Id: Ie5bc8f008dead637a09495adeef5577e2b33bc90
BUG: 1422760
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: https://review.gluster.org/16629
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit b81f37d9df338a906937f64beef4cab69b4711bb
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Feb 14 12:45:36 2017 +0530
rpcsvc: Add rpchdr and proghdr to iobref before submitting to transport
Issue:
When fio is run on multiple clients (each client writes to its own files),
and meanwhile the clients does a readdirp, thus the client which did
a readdirp will now recieve the upcalls. In this scenario the client
disconnects with rpc decode failed error.
RCA:
Upcall calls rpcsvc_request_submit to submit the request to socket:
rpcsvc_request_submit currently:
rpcsvc_request_submit () {
iobuf = iobuf_new
iov = iobuf->ptr
fill iobuf to contain xdrised upcall content - proghdr
rpcsvc_callback_submit (..iov..)
...
if (iobuf)
iobuf_unref (iobuf)
}
rpcsvc_callback_submit (... iov...) {
...
iobuf = iobuf_new
iov1 = iobuf->ptr
fill iobuf to contain xdrised rpc header - rpchdr
msg.rpchdr = iov1
msg.proghdr = iov
...
rpc_transport_submit_request (msg)
...
if (iobuf)
iobuf_unref (iobuf)
}
rpcsvc_callback_submit assumes that once rpc_transport_submit_request()
returns the msg is written on to socket and thus the buffers(rpchdr, proghdr)
can be freed, which is not the case. In especially high workload,
rpc_transport_submit_request() may not be able to write to socket immediately
and hence adds it to its own queue and returns as successful. Thus, we have
use after free, for rpchdr and proghdr. Hence the clients gets garbage rpchdr
and proghdr and thus fails to decode the rpc, resulting in disconnect.
To prevent this, we need to add the rpchdr and proghdr to a iobref and send
it in msg:
iobref_add (iobref, iobufs)
msg.iobref = iobref;
The socket layer takes a ref on msg.iobref, if it cannot write to socket and
is adding to the queue. Thus we do not have use after free.
Thank You for discussing, debugging and fixing along:
Prashanth Pai <ppai@redhat.com>
Raghavendra G <rgowdapp@redhat.com>
Rajesh Joseph <rjoseph@redhat.com>
Kotresh HR <khiremat@redhat.com>
Mohammed Rafi KC <rkavunga@redhat.com>
Soumya Koduri <skoduri@redhat.com>
Change-Id: Ifa6bf6f4879141f42b46830a37c1574b21b37275
BUG: 1421937
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16613
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 6f87a310673ac1bee32abf16ca64b9a27ca45c1d
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Feb 13 16:49:06 2017 +0530
cluster/dht Fix error assignment in dht_*xattr2 functions
Corrected the op_errno assignments and NULL checks in
the dht_sexattr2 and dht_removexattr2 functions. Earlier,
they unwound with the default EINVAL op_errno if the
file had been deleted.
Change-Id: Iaf837a473d769cea40132487a966c7f452990071
BUG: 1421653
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/16610
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: MOHIT AGRAWAL <moagrawa@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit adab1b913287733ac12d899e6d0456fd242f2e4f
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Fri Feb 10 12:30:51 2017 +0530
build: git ignore generated executable script gf_attach
Change-Id: I5962270f4a06b0ce2e41331ac3519d6dfa2cc5d9
BUG: 1421023
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: https://review.gluster.org/16596
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 23d30da0eace43465097f16aedf3325b0b6e901d
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Feb 2 12:10:12 2017 +0000
build: Fix detection of uuid libs during configure
This change cleans up the current logic for detecting the presence of
uuid libs and avoids the following warning while executing configure
script:
. . .
checking for UUID... yes
checking uuid.h usability... yes
checking uuid.h presence... no
configure: WARNING: uuid.h: accepted by the compiler, rejected by the preprocessor!
configure: WARNING: uuid.h: proceeding with the compiler's result
checking for uuid.h... yes
. . .
Refer the following link for more details:
https://www.gnu.org/software/autoconf/manual/autoconf.html#Present-But-Cannot-Be-Compiled
Change-Id: Icc6e11097fed7c5a82ebd9d931b4e308f7d666c9
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: https://review.gluster.org/16541
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 7031252f4f1382b43ff48a27e347019af8add918
Author: Sunil Kumar Acharya <sheggodu@redhat.com>
Date: Thu Feb 9 16:34:54 2017 +0530
cluster/ec: Change log level of messages to DEBUG
Heal failed or passed should not be logged as info. These can be
observed from heal info if the heal is happening or not. If we require
to debug a case where heal is not happening, we can set the level to
DEBUG.
Change-Id: I062668eadd145ef809b25e818e6bca1094f54cd6
BUG: 1420619
Signed-off-by: Sunil Kumar Acharya <sheggodu@redhat.com>
Reviewed-on: https://review.gluster.org/16580
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
commit f3fc315e9e82cef61b0f89fc4a38da54c8de52d3
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Feb 13 16:52:07 2017 +0530
gNFS: Keep the mountdict as long as the service is active
We initialize and take ref once on mountdict during NFS/MNT3 server
initialization but seem to be unref'in it for every UMNTALL request.
This can lead to crash when there are multiple UMNTALL requests
with >=1 active mount entry(/ies) in the mountlist.
Since we take the ref only once, we should keep the mountdict through
out the life of the process and dereference it only during unitialization
of mnt3 service.
Change-Id: I3238a8df09b8972e56dd93fee426d866d40d9959
BUG: 1421759
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: https://review.gluster.org/16611
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 7e9624997443fc8ea99ed8cdfd927f2fff0d4819
Author: Gaurav Yadav <gyadav@redhat.com>
Date: Mon Feb 13 15:46:24 2017 +0530
glusterd : Fix for error mesage while detaching peers
When peer is detached from a cluster, an error log is being
generated in glusterd.log -"Failed to reconfigure all daemon
services". This log is seen in the originator node where the
detach is issued.
This happens in two cases.
Case 1: Detach peer with no volume been created in cluster.
Case 2: Detach peer after deleting all the volumes which were
created but never started.
In any one of the above two cases, in glusterd_check_files_identical()
GlusterD fails to retrieve nfs-server.vol file from /var/lib/glusterd/nfs
which gets created only when a volume is in place and and is started.
With this fix both the above cases have been handled by added
validation to skip reconfigure if there is no volume in started
state.
Change-Id: I039c0840e3d61ab54575e1e00c6a6a00874d84c0
BUG: 1421607
Signed-off-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-on: https://review.gluster.org/16607
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 82013c08c071aea718fb4762500deead9355cf10
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Feb 2 16:41:45 2017 +0530
protocol/client: Fix double free of client fdctx destroy
This patch fixes the race between fd re-open code and fd release code,
both of which free the fd context due to a race in certain variable
checks as explained below:
1. client process (shd in the case of this BZ) sends an opendir to its
children (client xlators) which send the fop to the bricks to get a valid fd.
2. Client xlator loses connection to the brick. fdctx->remotefd is -1
3. Client re-establishes connection. After handshake, it reopens the dir
and sets fdctx->remotefd to a valid fd in client3_3_reopendir_cbk().
4. Meanwhile, shd sends a fd unref after it is done with the opendir.
This triggers a releasedir (since fd->refcount becomes 0).
5. client3_3_releasedir() sees that fdctx-->remotefd is a valid number
(i.e not -1), sets fdctx->released=1 and calls client_fdctx_destroy()
6. As a continuation of step3, client_reopen_done() is called by
client3_3_reopendir_cbk(), which sees that fdctx->released==1 and
again calls client_fdctx_destroy().
Depending on when step-5 does GF_FREE(fdctx), we may crash at any place in
step-6 in client3_3_reopendir_cbk() when it tries to access
fdctx->{whatever}.
Change-Id: Ia50873d11763e084e41d2a1f4d53715438e5e947
BUG: 1418629
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/16521
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 00574cd385ff7e215ae704413cb696992354b200
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Feb 9 21:12:17 2017 +0530
cluster/dht: Use int8 instead of string to pass DHT_IATT_IN_XDATA_KEY
It is sufficient to pass an int value as opposed to a "yes" against the
DHT_IATT_IN_XDATA_KEY key since all posix cares about is whether the
key is present in the dict or not. Also note that this patch does not
violate backward compatibility since the handling of the key in posix
remains untouched.
Change-Id: I2f881494a257488709c8c1d2002f2d124ddcc089
BUG: 1390050
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://review.gluster.org/16591
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 70d15688fbc08174b1c2534cc065ec22dd03895e
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Feb 8 15:21:46 2017 -0500
libglusterfs+changetimerecorder: reduce log noise
The logging about translator options is so verbose that it
significantly slows down scalability tests - sometimes even to the
point where it induces timing-related failures. Quiet, please.
Change-Id: If0766e2a80746bba586e67e6019ff7084d68b425
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16569
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
commit 7433a08590783262fe8bb140a615dcaaf6d157ff
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Feb 9 09:53:51 2017 -0500
tests: reenable trash.t
Now that the underlying bug has been fixed (by d97e63d0) we can allow
the test to run again.
Change-Id: If9736d142f414bf9af5481659c2b2673ec797a4b
BUG: 1420434
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16584
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit a1ffa3ed309db26ba2c8ab10931e16f888eb6d00
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Feb 3 10:51:21 2017 -0500
glusterd: keep snapshot bricks separate from regular ones
The problem here is that a volume's transport options can change, but
any snapshots' bricks don't follow along even though they're now
incompatible (with respect to multiplexing). This was causing the
USS+SSL test to fail. By keeping the snapshot bricks separate
(though still potentially multiplexed with other snapshot bricks
including those for other volumes) we can ensure that they remain
unaffected by changes to their parent volumes.
Also fixed various issues with how the test waits (or more precisely
didn't) for various events to complete before it continues.
Change-Id: Iab4a8a44fac5760373fac36956a3bcc27cf969da
BUG: 1385758
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16544
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
commit fd5e1203f54da0568d9cb29ca6500e25fd106e98
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Feb 9 16:09:08 2017 +0530
cli: add integer check for timeout option
Change-Id: Ia9f2d343e0a9ad13af1a62abe8946d646d36b3bb
BUG: 1420697
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16578
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
commit c88a2eed48dfcd556404a9c64051b17016aa7689
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Jan 30 09:54:16 2017 +0530
afr: all children of AFR must be up to resolve s-brain
Problem:
The various split-brain resolution policies (favorite-child-policy based,
CLI based and mount (get/setfattr) based) attempt to resolve split-brain
even when not all bricks of replica are up. This can be a problem when
say in a replica 3, the only good copy is down and the other 2 bricks
are up and blame each other (i.e. split-brain). We end up healing the
file in such a case and allow I/O on it.
Fix:
A decision on whether the file is in split-brain or not must be taken
only if we are able to examine the afr xattrs of *all* bricks of a given
replica.
Change-Id: Icddb1268b380005799990f5379ef957d84639ef9
BUG: 1417522
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/16476
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a633fc1fd3235d99007f4ac0d3234499627d268e
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Feb 9 12:56:38 2017 +0530
glusterd: ignore return code of glusterd_restart_bricks
When GlusterD is restarted on a multi node cluster, while syncing the
global options from other GlusterD, it checks for quorum and based on
which it decides whether to stop/start a brick. However we handle the
return code of this function in which case if we don't want to start any
bricks the ret will be non zero and we will end up failing the import
which is incorrect.
Fix is just to ignore the ret code of glusterd_restart_bricks ()
Change-Id: I37766b0bba138d2e61d3c6034bd00e93ba43e553
BUG: 1420637
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16574
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 30d588a60e9bdbf941bdeb1a91dbf91d7cfd763e
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Feb 9 10:13:20 2017 +0530
glusterd: set default GLUSTERD_QUORUM_RATIO_KEY value to 51
The default value of GLUSTERD_QUORUM_RATIO_KEY is set to 0, while this
doesn't harm any functionality as the actual quorum calculation logic
always take the factor that if the key is not set in the dictionary the
value is considered to be 51 but from an user perspective it gives an
incorrect output through volume get where quorum-ratio is always shown as
0 until reconfigured.
Change-Id: I087712fa4736055859f29cc3bdbb3b111cbe7224
BUG: 1420611
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16572
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 0749248280af8cb5d1104c9252b25f3fee39aaac
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Feb 9 10:28:55 2017 +0530
glusterd: put null check for mod_dict in build_shd_graph
Change-Id: I849f5f7eb5932d2dc2a76f8abc61e41231f9883e
BUG: 1420614
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16573
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit fa53c6d6dc1cfbd8527543558d98a02e680b79c7
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Feb 8 19:45:46 2017 -0500
libglusterfs: fix serious leak of xlator_t structures
There's a lot of logic (and some long comments) around how to free
these structures safely, but then we didn't do it. Now we do.
Change-Id: I9731ae75c60e99cc43d33d0813a86912db97fd96
BUG: 1420571
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16570
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 3d78cac48f0275eff7cef998002d59f32579578c
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Feb 8 10:48:55 2017 -0500
trash: fix problem with trash feature under multiplexing
With multiplexing, the trash translator gets a reconfigure call before
a notify(CHILD_UP). In this case, priv->trash_itable was not yet
initialized, so the reconfigure would get a SEGV. Moving the itable
allocation to init seems to fix it, so trash can be reenabled.
Change-Id: I21ac2d7fc66bac1bc4ec70fbc8bae306d73ac565
BUG: 1420434
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16567
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit e45f98fb06b16bc01f0bf0b9ec0dff797571b411
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Feb 8 12:20:55 2017 +0530
glusterd: glusterd is crashed at the time of stop volume
Problem: glusterd is crashed at the time of stop volume due to
overflow of pidfile array after build rpm with default options.
Solution: To avoid the crash update the pidfile array size.
Test: To test the patch followed below procedure
1) Setup 1*2 environment and start the volume
2) Stop the volume
Before apply the patch glusterd is crashed.
Note: The crash is happened only after build rpm with rpmbuild -ba
<spec> because _FORTIFY_SOURCE is enabled. This option tries to
figure out possible overflow scenarios like the bug here and
crash the process.
BUG: 1420202
Change-Id: I58a006bc0727843a7ed02a10b4ebd5dca39eae67
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/16560
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit a5000bf8c0e2d6ba521bed6d576b0c9041192c82
Author: Richard Wareing <rwareing@fb.com>
Date: Fri Dec 11 21:03:40 2015 -0800
afr/cluster: Restore data-self-heal-window option
Summary:
- Fixes a bug where data-self-heal-window was ignored and instead
hard-coded to 128k
- Cherry-pick of D2752781
Test Plan:
- Prove tests
Reviewed By: sshreyas
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Change-Id: Ie38456ce9ad90921f7456fe02aaace88393433a9
BUG: 1404424
Reviewed-on-release-3.8-fb: http://review.gluster.org/16083
Tested-by: Shreyas Siravara <sshreyas@fb.com>
Reviewed-by: Kevin Vigor <kvigor@fb.com>
Reviewed-on: https://review.gluster.org/16123
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit bde50540982e2c855b53c427861d2dae8965db64
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Feb 2 10:22:00 2017 -0500
tests: fix online_brick_count for multiplexing
The number of brick processes no longer matches the number of bricks,
therefore counting processes doesn't work. Counting *pidfiles* does.
Ironically, the fix broke multiplex.t which used this function, so it
now uses a different function with the old process-counting behavior.
Also had to fix online_brick_count and kill_node in cluster.rc to be
consistent with the new reality.
Change-Id: I4e81a6633b93227e10604f53e18a0b802c75cbcc
BUG: 1385758
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16527
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 627f4ee8e62fd84ba34117cd63ddfd5910a90e77
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Feb 7 09:17:47 2017 -0500
packaging: python/python2(/python3) cleanup, again
mistake missed in the previous patches
see https://review.gluster.org/#/c/16486/ and
https://review.gluster.org/#/c/16428/
BUG: 1414902
Change-Id: Ie0839fa00794986f7f6a742dff70acd242e68735
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16556
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit b891bdd75c507456732d4490532f3fd0c23606a7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Feb 2 13:37:31 2017 +0530
tests : turn off nfs.disable in bug-1238706-daemons-stop-on-peer-cleanup.t
To validate this test and remove it from the list of bad tests, turn off
nfs.disable option so that nfs daemon can come up.
Change-Id: I8146c2d7f72ac53cac7e395dbb9e819d729eb6a9
BUG: 1257792
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16514
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 07f9daaec1795f4fe24f7ea49ded50f144f4181c
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Feb 1 10:01:26 2017 +0100
extras/rebalance.py: Fix statvfs for FreeBSD in python
FreeBSD doesn't return the block size in f_bsize as linux does. It
returns the optimal I/O size, so we need to consider this to avoid
invalid results. On FreeBSD we take f_frsize as the block size.
Change-Id: I72083d8ae183548439de874c77f1d60d9c2d14a7
BUG: 1356076
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/16498
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b277834f07dc44d567791e7205cefb4a9f772d68
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Jan 24 14:24:47 2017 +0530
CLI/TIER: removing old tier commands under rebalance
PROBLEM: gluster v rebalance <volname> tier start works even after
the switch of tier to service framework.
This lets the user have two tierd for the same volume.
FIX: checking for each process will make the new code hard
to maintain. So we are removing the support for old commands.
Change-Id: I5b0974b2dbb74f0bee8344b61c7f924300ad73f2
BUG: 1415590
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/16463
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit f52b3609879b810583be35c0cd407cbec65729f5
Author: hari gowtham <hgowtham@redhat.com>
Date: Fri Feb 3 15:55:47 2017 +0530
Tier: remove warning related to the enum
PROBLEM: In the tier as a service patch the enums for tier (from
gf1_op_command and gf_defrag_command) are put into a single enum
gf_defrag_command which causes a warning that will make the build
fail.
FIX: send both the enum and eliminate the warning.
Change-Id: I899ff622dfb07134e6459aa65f65ea7252765293
BUG: 1418973
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: https://review.gluster.org/16539
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 66d5b4936b2f5dc812cbb41135f9c6f82295ee8a
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Wed Feb 1 19:15:29 2017 +0530
Fixes quota list when stale gfid exist in quota.conf
when an rmdir is done, the gfid corresponding to the dir remains
in quota.conf (if a limit was configured on the dir). The quota
list should ignore them and print the remaining limits. In case
the last gfid in quota.conf happened to be stale, the print code
was getting skipped. Refactored the code to ensure printing happens.
Change-Id: I3ac8e8a7a62d34e1fa8fd2734419459112c71797
BUG: 1418259
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
Reviewed-on: https://review.gluster.org/16507
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <manikandancs333@gmail.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 29f68c220a66de8a03cb2c44671c7f0fd3d8d060
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Thu Jan 5 23:58:21 2017 +0530
socket: GF_REF_PUT should be called outside lock
GF_REF_PUT was called inside lock which can call
socket_poller_mayday which inturn tries to take the
same lock. This can lead to deadlock scenario.
BUG: 1410701
Change-Id: Ib3b161bcfeac810bd3593dc04c10ef984f996b17
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: https://review.gluster.org/16343
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit a823bb080eb2c5a94aa6ec1330cf73e9a5021044
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jan 23 22:19:01 2017 +0530
cluster/dht: Don't update layout in rebalance_task_completion
Updating the layout in the dht inode_ctx in
rebalance_task_completion after the file is migrated
is erroneous in case of files with hardlinks.
This step can be skipped as the layout will be set
in the syncop_lookup call post the migration in
dht_migrate_file.
Change-Id: I24ac798a919585d91a117d6a207e6a31b88486c6
BUG: 1415761
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/16457
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
commit 375067eba4345eaf721b57dbbbb39ef107660efd
Author: menakamohan <menaka.m@outlook.com>
Date: Tue Jan 31 17:14:30 2017 +0530
Added the missing FOPs in the io-stats xlator
The following FOPs are not implemented in the io-stats xlator.
1)fentrylk
2)compound
3)seek
4)lease
5)getactivelk
6)setactivelk
Added the missing FOPs to the io-stats xlator
Change-Id: I4577f82ec906f1b88327c484cd9a6f356d578125
BUG: 1416520
Signed-off-by: menakamohan <menaka.m@outlook.com>
Reviewed-on: https://review.gluster.org/16490
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 52631f7c1c61c8b406ae8cdcedd60d57bc7164fc
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Feb 1 15:04:08 2017 +0530
glusterd : do not load io-threads in client graph for replicate volumes
client.io-threads has been turned on by default from release-3.9 onwards,
however this has an adverse effects on replicate volumes due to the design
limitations on replications, till that gets addressed through server side
replication as a preventive measure it is wiser not to load io-threads in the
client graph for replicate volumes.
Change-Id: Ibc576d4517da23fcdf55c6f4d17b90152a8817d7
BUG: 1418014
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16502
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 92b8c5a0edb4d39476ca4f6037d51dabc6690c81
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Feb 1 17:11:46 2017 +0530
extras: Provide group set for md-cache and invalidation options
To enable the integration of md-cache and invalidation features
we need to perform 3 volume set options in a specific order.
In order to ease this for user provide a group volume set option.
Usage: gluster vol set <VOLNAME> group metadata-cache
Change-Id: I9bf0fd4217aa2a1c7ffbdc93e879b10f87addeac
BUG: 1418249
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16503
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 4b13d0a825b33b81dcc33ed1e99a939bd2e6f8be
Author: Vitaly Lipatov <lav@etersoft.ru>
Date: Tue Jan 31 21:18:05 2017 +0300
md-cache: initialize mdc_counter.lock
add missed LOCK_INIT to fix INCREMENT_ATOMIC on
conf->mdc_counter.lock when pthread_spin_* using
Change-Id: I680bd6f41e3b8a1852ed969bf6794cbf4c1ccdd4
BUG: 1417913
Signed-off-by: Vitaly Lipatov <lav@etersoft.ru>
Reviewed-on: https://review.gluster.org/16515
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 33175a84154a90d1f1a0edd8115c909531a3f245
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Feb 2 13:08:04 2017 -0500
glusterd: double-check brick liveness for remove-brick validation
Same problem as https://review.gluster.org/#/c/16509/ in a different
place. Tests detach bricks without glusterd's knowledge, so
glusterd's internal brick state is out of date and we have to re-check
(via the brick's pidfile) as well.
BUG: 1385758
Change-Id: I169538c1c62d72a685a49d57ef65fb6c3db6eab2
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16529
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 09e8e8ab90c7ea3567b1f1e6e22d11d9dfdec619
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Feb 2 11:41:06 2017 -0500
tests: use kill_brick instead of kill -9
The system actually handles this OK, but with multiplexing the result
of killing the whole process is not what some tests assumed.
Change-Id: I89ebf0039ab1369f25b0bfec3710ec4c13725915
BUG: 1385758
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16528
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 2ee0c9ff5ed8b6720e439ad0c4a09a7304f2d245
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Feb 1 22:00:32 2017 -0500
socket: retry connect immediately if it fails
Previously we relied on a complex dance of setting flags, shutting
down the socket, tearing stuff down, getting an event, tearing more
stuff down, and waiting for a higher-level retry. What we really
need, in the case where we're just trying to connect prematurely e.g.
to a brick that hasn't fully come up yet, is a simple retry of the
connect(2) call.
This was discovered by observing failures in ec-new-entry.t with
multiplexing enabled, but probably fixes other random failures as
well.
Change-Id: Ibedb8942060bccc96b02272a333c3002c9b77d4c
BUG: 1385758
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16510
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit dda3274fb5450df13161a5332181258ff8e2eb77
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Oct 14 10:04:07 2016 -0400
libglusterfs: make memory pools more thread-friendly
Early multiplexing tests revealed *massive* contention on certain
pools' global locks - especially for dictionaries and secondarily for
call stubs. For the thread counts that multiplexing can create, a
more lock-free solution is clearly needed. Also, the current mem-pool
implementation does a poor job releasing memory back to the system,
artificially inflating memory usage to match whatever the worst case
was since the process started. This is bad in general, but especially
so for multiplexing where there are more pools and a major point of
the whole exercise is to reduce memory consumption.
The basic ideas for the new design are these
There is one pool, globally, for each power-of-two size range.
Every attempt to create a new pool within this range will instead
add a reference to the existing pool.
Instead of adding pools for each translator within each multiplexed
brick (potentially infinite and quite possibly thousands), we
allocate one set of size-based pools per *thread* (hundreds at
worst).
Each per-thread pool is divided into hot and cold lists. Every
allocation first attempts to use the hot list, then the cold list.
When objects are freed, they always go on the hot list.
There is one global "pool sweeper" thread, which periodically
reclaims everything in each pool's cold list and then "demotes" the
current hot list to be the new cold list.
For normal allocation activity, only a per-thread lock need be
taken, and even that only to guard against very rare contention from
the pool sweeper. When threads start and stop, a global lock must
be taken to add them to the pool sweeper's list. Lock contention is
therefore extremely low, and the hot/cold lists also provide good
locality.
A more complete explanation (of a similar earlier design) can be found
here:
http://www.gluster.org/pipermail/gluster-devel/2016-October/051160.html
Change-Id: I5bc8a1ba57cfb553998f979a498886e0d006e665
BUG: 1385758
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/15645
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit eb5bd1d82c33a5af6dfab5e88d6e5d43f9961ab7
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Feb 1 04:04:28 2017 -0500
extras: glusterfs-mode.el has incorrect FSF address
found by rpmlint on OpenSuSE Build Service
And convert DOS crlf to Unix lf, also found by SuSE rpmlint
Change-Id: I0329e6682333ead21ca1b76a3b00cb863c2af51b
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16500
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit daca2a717f610f1bcb58642a5cbebf2ae278ffce
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Feb 1 21:54:30 2017 -0500
glusterd: double-check whether brick is alive for stats
With multiplexing, our tests detach bricks from their host processes
without glusterd being involved. Thus, when we ask glusterd to fetch
profile info, it will try to fetch from a brick that's actually not
present any more. While it can handle the process being dead and its
RPC connection being closed, it barfs if it gets a negative response
from a live brick process. This is not a problem in normal use,
because the brick can't disappear without glusterd seeing it. The fix
is to double check that the brick is actually running, by looking for
its pidfile which the tests *do* clean up as part of killing a brick.
Change-Id: I098465b175ecf23538bd7207357c752a2bba8f4e
BUG: 1385758
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/16509
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit cfc4ffc6d98aedbd0c05d1ffebbc3675df5b8fb1
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Feb 2 15:54:10 2017 +0530
glusterfsd/gf_attach: Remove unused varibale
Change-Id: I1f2ae36c91bd0880a7f15aa73b7e0f462c7e7952
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: https://review.gluster.org/16517
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ce4bbbe01a0d2ac55abc10909f7ee54a28d2f48e
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Fri Jan 13 13:54:35 2017 +0100
cluster/ec: fix selinux issues with mmap()
EC uses mmap() to create a memory area for the dynamic code. Since
the code is created on the fly and executed when needed, this region
of memory needs to have write and execution privileges.
This combination is not allowed by default by selinux. To solve the
problem a file is used as a backend storage for the dynamic code and
it's mapped into two distinct memory regions, one with write access
and the other one with execution access. This approach is the
recommended way to create dynamic code by a program in a more secure
way, and selinux allows it.
Additionally selinux requires that the backend file be stored in a
directory marked with type bin_t to be able to map it in an executable
area. To satisfy this condition, GLUSTERFS_LIBEXECDIR has been used.
This fix also changes the error check for mmap(), that was done
incorrectly (it checked against NULL instead of MAP_FAILED), and it
also correctly propagates the error codes and makes sure they aren't
silently ignored.
Change-Id: I71c2f88be4e4d795b6cfff96ab3799c362c54291
BUG: 1402661
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/16405
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 7466b4efbde51b6960e824224d682e5735493ce8
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Jan 20 16:09:13 2017 +0530
performance/write-behind: access stub only if available during statedump
Change-Id: Ia5dd718458a5e32138012f81f014d13fc6b28be2
BUG: 1415115
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: https://review.gluster.org/16440
Reviewed-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit f1898a6f04ac4c1ce326ca52377e0c59796eb74a
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Oct 27 11:51:47 2016 -0400
libglusterfs+transport+io-threads: fix 256KB stack abuse
Some functions were allocating 64K booleans, which are (crazily) mapped to
4-byte ints, for a total of 256KB per call. Changed to use bitfields instead,
so usage is now only 8KB per call. This was the impediment to changing the
io-threads stack size, so that has been adjusted too.
Change-Id: I8781c4f2c8f2b830f4535e366995fac8dd0a8653
BUG: 1418095
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/15745
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 4d9290cf3126bcc823ef30b9eb8f9f02203bd979
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Feb 1 15:17:51 2017 +0530
rpc/socket.c : Bonnie++ hangs during rewrites in ganesha + SSL
Problem: Bonnie++ rewrite operation hangs in ganesha + SSL environment
Solution: Bonnie++ hangs during execution of rewrite operation in
ganesha + SSL environment.It was hanged due to blocking on poll
call in ssl_do because no POLLOUT event was getting on socket.
Socket is not getting POLLOUT event because all other threads
are waiting to get lock and lock is not released ssl_do
because it is not getting any event on poll.To correct it
update the condition in ssl_do as same in getting error
SSL_ERROR_WANT_READ.
Test: To test the patch followed below procedure
1) Setup 2X2 Ganesha + SSL environment.
2) Run bonnie from 3 nfs client parallely
3) After run "Rewwrite operation" by bonnie it is hanged.
4) After apply the patch it is not hanged.
BUG: 1418213
Change-Id: I5985cbbc4cfdac5d287268d791e31c274abc3c8d
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: https://review.gluster.org/16501
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1a3ef75c9e98f513eaaa532efe96105e363595b4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jan 31 04:03:51 2017 -0500
packaging: python/python2(/python3) cleanup, again
missed a couple things in the previous patch
Change-Id: I0ebd5c431abd9af5e1b680ad52318219edb4bfa7
BUG: 1414902
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16486
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fe7a0856ab787ea68fa717478f06197d5fd0a018
Author: Michael Adam <obnox@samba.org>
Date: Wed Dec 7 07:45:57 2016 +0100
glusterd: fix compiler warning (unused var) if bd xlator is not enabled
BUG: 1402254
Change-Id: Id4450c5e00e9eb6d63dcdf65b0a13bc535a32d98
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: https://review.gluster.org/16049
Tested-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 6e4c73bd071bcb07b9e0b5d9c3676ad76709e6b8
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 26 16:45:51 2017 +0100
refcount: typecast function for calling on free
All of the functions called to free the refcounted structure are doing a
typecast from (void*) to their own type taht is being free'd. This
really is not needed and the refcount interface is made a little simpler
without the requirement of typecasting.
With this small improvement in the API, all callers are updated too.
Change-Id: I32473b6d1799f62861d4b2d78ea30c09e6c80ab1
BUG: 1416889
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16471
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 19d398640094b0ea2b7d89b66034711cb98d38f0
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Dec 8 16:24:15 2016 -0500
core: run many bricks within one glusterfsd process
This patch adds support for multiple brick translator stacks running
in a single brick server process. This reduces our per-brick memory usage by
approximately 3x, and our appetite for TCP ports even more. It also creates
potential to avoid process/thread thrashing, and to improve QoS by scheduling
more carefully across the bricks, but realizing that potential will require
further work.
Multiplexing is controlled by the "cluster.brick-multiplex" global option. By
default it's off, and bricks are started in separate processes as before. If
multiplexing is enabled, then *compatible* bricks (mostly those with the same
transport options) will be started in the same process.
Change-Id: I45059454e51d6f4cbb29a4953359c09a408695cb
BUG: 1385758
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/14763
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a9283490c1ea9c5ac74e52ee1bd1eb8250f8fb04
Author: Ryan Ding <ryan.ding@open-fs.com>
Date: Tue Aug 23 17:28:44 2016 +0800
features/changelog: fix a bug in changelog_rpc_server_destroy
the programe unregister loop never get moved forward, it's a dead loop.
to resolve it, add progs++ in the loop.
Change-Id: Ib25ded10b3ce808e2fb57b13d767833f24cf01a7
BUG: 1369393
Signed-off-by: Ryan Ding <ryan.ding@open-fs.com>
Reviewed-on: https://review.gluster.org/15292
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b1135bd4c23fdce504f2ac5aa6017569e2387e15
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Dec 2 15:24:46 2016 -0500
features/bit-rot-stub: use the correct spelling of quarantine for bad objects container
The directory for containing the list of bad objects was named "quanrantine"
instead of "quarantine"
Change-Id: I8c20381ac637201d9d1a224f5223e8dfbed53f1e
BUG: 1401571
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: https://review.gluster.org/16027
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit f5490edf9f6bac3059d9cb3264bc6ce92e11a308
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jan 30 13:13:54 2017 +0530
tests: Mark tests/bitrot/bug-1373520.t bad
Change-Id: Ief8014dd9faa012c7f3c5347f597a155873a8f92
BUG: 1417540
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16479
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit cfc0ebfe83afdd8e56407f58827b55450a29fe5c
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Jan 17 18:26:55 2017 +0530
gNFS : pass proper gfid for nfs_setattr() in nfs3svc_create_cbk()
The nfs3svc_create_cbk() takes "gfid" from inode variable which it
received, not from inode which it performed linking to nfs_setattr().
There is possiblity that the inode passed into this function holds
NULL gfid if there are some parallel operation happening on the same
file.
Similar issue is mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1413971
Thanks pranith for proposing the fix
Change-Id: I1a0ff4f02b483416f19f4f064c306c2cad5d9d8b
BUG: 1413971
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: https://review.gluster.org/16421
Reviewed-by: soumya k <skoduri@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 9a2f4f48dd44db9574d25c243dc339d03943c41b
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Jan 16 15:27:09 2017 +0530
tools/glusterfind: delete temporary folder
Problem:
Run specific temporary folder created under
/usr/var/lib/misc/glusterfsd/glusterfind/<session>/<volume>/
remains undeleted.
Solution:
Delete the temporary folder from all nodes.
Change-Id: I0edaf868aebb01b15c489434bbb26fe853351384
BUG: 1413526
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://review.gluster.org/16416
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 75f78b1d4a73ac5fa9284c3a1f33eb2a95477a57
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jan 27 16:17:49 2017 +0530
cluster/ec: Fix cthon failures observed with ec volumes
Since EC already winds one write after other there is no need to align
application fcntl locks with ec blocks. Also added this locking to be
done as a transaction to prevent partial upgrade/downgrade of locks
happening.
BUG: 1410425
Change-Id: I7ce8955c2174f62b11e5cb16140e30ff0f7c4c31
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: https://review.gluster.org/16445
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 411f81720b5eca508db9d45d90e199c0f6472d80
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jan 23 13:03:06 2017 +0530
glusterd: regenerate volfiles on op-version bump up
Change-Id: I2fe7a3ebea19492d52253ad5a1fdd67ac95c71c8
BUG: 1416251
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16455
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 57e8e7a34303be028d73bd882b651d1cb69c89d9
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Jan 27 11:31:40 2017 +0530
cluster/ec: Change level of messages to DEBUG
Heal failed or passed should not be logged as warning.
These can be observed from heal info if the heal is
happening or not. If we require to debug a case where
heal is not happening, we can set the level to DEBUG.
Change-Id: I347665c8c8b6223bb08a9f3dd5643a10ddc3b93e
BUG: 1417050
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://review.gluster.org/16473
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d239946ed6d8dd80243ec564b076711e50ac8e4b
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Oct 5 14:59:51 2016 +0530
glusterd: daemon restart logic should adhere server side quorum
Just like brick processes, other daemon services should also follow the same
logic of quorum checks to see if a particular service needs to come up if
glusterd is restarted or the incoming friend add/update request is received
(in glusterd_restart_bricks () function)
Change-Id: I54a1fbdaa1571cc45eed627181b81463fead47a3
BUG: 1383893
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/15626
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 63979b6439be06bf3ea45ed1dc6da4151a242f94
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Jan 24 14:18:03 2017 +0530
performance/write-behind: do __wb_request_unref within locks
Since __wb_request_unref can remove the request from various lists,
calling it without holding wb_inode->lock results in corruptions when
other threads simultaneously try to access the lists this request is
part of.
Thanks to "Nithya Balachandran" <nbalacha@redhat.com> for pointing out
the bug.
Change-Id: I78fb6433c2e212500d07780f7b45c5a0e2bf9209
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: https://review.gluster.org/16464
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d1aaa9a81875cd34b9f8554729ec8b1d9593e3ef
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Jan 26 10:24:32 2017 +0100
cluster/ec: mark ec-background-heal.t as bad
Change-Id: I0c54c62cdeb40b983da2392296762471a5474652
BUG: 1416689
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: https://review.gluster.org/16470
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit a069eed2ab6becb1ab4e004da003bb5d9e06dd53
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Jan 12 14:48:28 2017 +0530
tests/include : EXPECT_WITHIN takes full time even if expression matches
Problem: For all the tests using get_pending_heal_count, EXPECT_WITHIN
is taking full time given to it even if the heal count matches with
expected value.
Solution:
RC - In most of the tests, to check heal count, wildcards are
being used. In EXPECT_WITHIN, in if condition, when we use it in
double quotes (" "), it gives string with wildcards which does not
match with the output of get_pending_heal_count.
For example, (0 =~ ^0$).
So, "while" loop was running for full time and at the end, after
coming out of loop, in next if condition it was matching with the
expression without quotes. That is why it was passing.
Remove double quotes in "if condition" in EXPECT_WITHIN and match
as we are matching it in test_expect_footer.
Change-Id: Ia161594774d05b9b888efb2f7ed1950590d8ac1b
BUG: 1412549
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://review.gluster.org/16382
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 1ba0fe44f14814ece25d068ebe52bc25428137ea
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 6 12:58:02 2017 +0100
gfapi: create statedump when glusterd requests it
When GlusterD sends the STATEDUMP procedure to the libgfapi client, the
client checks if it matches the PID that should take the statedump. If
so, it will do a statedump for the glfs_t that is connected to this mgmt
connection.
BUG: 1169302
Change-Id: I70d6a1f4f19d525377aebc8fa57f51e513b92d84
See-also: http://review.gluster.org/9228
Signed-off-by: Poornima G <pgurusid@redhat.com>
[ndevos: separated patch from 9228]
Reviewed-on: https://review.gluster.org/16415
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 97130d00731a59fb69901b3acf155d2e6c1a7598
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Dec 8 16:08:40 2016 +0530
Readdir-ahead : Honor readdir-optimise option of dht
Change-Id: I9c5e65b32e316e6a2fc7e1f5c79fce79386b78e2
BUG: 1401812
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16071
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8306b97238be476cb7b6136a4777dcee9ec45881
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Jan 22 11:44:21 2016 -0500
glusterd: add a cli command to trigger a statedump on a client
With this, we will be able to trigger statedumps on remote Gluster
clients, mainly targetted for applications using libgfapi.
Design:
SIGUSR signal is the most comman way of taking a statedump in Gluster.
But it cannot be used for libgfapi based processes, as the process
loading the library might have already consumed SIGUSR signal. Hence
going by the command way.
One has to issue a Gluster command to initiate a statedump on the
libgfapi based client. The command takes hostname and PID as an
argument. All the glusterds in the cluster, check if they are connected
to the specified hostname, and send an RPC request to all the connected
clients from that hostname (via the mgmt connection).
URL: http://review.gluster.org/16357
Change-Id: Icbe4d2f026b32a2c7d5535e1bfb2cdaaff042e91
BUG: 1169302
Signed-off-by: Poornima G <pgurusid@redhat.com>
[ndevos: minor fixes and split patch in smaller pieces]
Reviewed-on: https://review.gluster.org/9228
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
commit a5043ba3f814be787fdcf3f6ccf82c60f42d25a6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Jan 18 12:51:19 2017 -0500
packaging: python2 cleanup
Update to current python2 (vs. python3) guidelines.
While doing package review of new python-glusterfs-api we
were reminded that we should update the glusterfs.spec(.in)
accordingly.
Change-Id: I67c88f209e803425c5ef70cb8d3e7ffd8e396c7f
BUG: 1414902
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/16428
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1d675662c5e4334aebe7847f2e179a77b1e933e3
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Jan 17 17:45:59 2017 +0530
glusterd, rda: If parallel readdir is enabled, split the cache limit
With patch http://review.gluster.org/#/c/16072/ readdir-ahead can be
loaded as a child of dht. i.e. there can be more than one instance
of readdir-ahead in client process. In this case the rda-cache-size
should be split among all the readdir-ahead instances. Also the
value of rda-request-size is considered as the minimum cache size
of any readdir-ahead instance.
Change-Id: Iea2fe6d4c46adc09dd2e9a252332a0fe3005f2b9
BUG: 1401812
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16424
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 3a7eae066f223490ff2476039550a0d25d66d25e
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Dec 26 14:28:22 2016 +0530
md-cache: Cache security.ima xattrs
From kernel version 3.X or greater, creating of a file
results in removexattr call on security.ima xattr. But
this xattr is not set on the file unless IMA feature
is active. With this patch, removxattr call returns
ENODATA if it is not found in the cache.
Change-Id: I8136096598a983aebc09901945eba1db1b2f93c9
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/16296
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5417709d99cf5cbd71c9f9b67ef7d4b4eea44540
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Jan 11 17:19:30 2017 +0530
cluster/ec: Do not start heal on good file while IO is going on
Problem:
Write on a file has been slowed down significantly after
http://review.gluster.org/#/c/13733/
RC : When update fop starts on a file, it sets dirty flag at
the start and remove it at the end which make an index entry
in indices/xattrop. During IO, SHD scans this and finds out
an index and starts heal even if all the fragments are healthy
and up tp date. This heal takes inodelk for different types of
heal. If the IO is for long time this will happen in every 60 seconds.
Due to this extra, unneccessary locking, IO gets slowed down.
Solution:
Before starting any type of heal check if file needs heal or not.
Change-Id: Ib9519a43e7e4b2565d3f3153f9ca0fb92174fe51
BUG: 1409191
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/16377
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 6de8e11f77cc01adcbf069d42ceb419196e2dc62
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Sep 28 17:20:19 2015 +0530
features/trash: Create trash directory only when it is enabled
Previously trash directory was being created as part of volume
start operation. And also the user/admin could not delete this
directory from volume even if it is not needed. This patch will
fix the same. From now onwards creation and enforcement on trash
directory will come into pictrure only when trash translator is
enabled. Similarly exact same behaviour is reflected on internal-op
directory inside trash directory.
Change-Id: I3e58316a7b299a691885e458c960438bec2220fb
BUG: 1264849
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/12256
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Anoop C S <anoopcs@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 6d41224d38bfb739e15a5febe0b7bad8a839be94
Author: Susant Palai <spalai@redhat.com>
Date: Tue Dec 6 15:34:39 2016 +0530
dht/cluster: add logs to fix-layout code path
Currently there is no helpful log in fix-layout code path. Adding
the logs to be helpful for debugging fix-layout failures.
BUG: 1414782
Change-Id: I61c29ceedcaa2e235fa7be99866709d6ca6de3ae
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/16040
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit d98fbbca12073a8282ff21d12917715506317d63
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Jan 9 12:45:36 2017 +0530
debug/trace: Print entries' iatts in readdirp cbk
Change-Id: Iab2b4fa44b22aad0745e9f9249d8adba0acd7de1
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16432
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1ad37c402911caa4e6a0f7adef47c332e51d32a0
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Jan 19 18:20:44 2017 +0530
cluster/disperse: Do not log fop failed for lockless fops
Problem: Operation failed messages are getting logged
based on the callbacks of lockless fop's. If a fop does
not take a lock, it is possible that it will get some
out of sync xattr, iatts. We can not depend on these
callback to psay that the fop has failed.
Solution: Print failed messages only for locked fops.
However, heal would still be triggered.
Change-Id: I4427402c8c944c23f16073613caa03ea788bead3
BUG: 1414287
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/16435
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 8662c3a9308b60974233d8924c3528ec7b431822
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Dec 6 15:53:10 2016 +0530
ganesha/glusterd : create 'ganesha.conf' symlink for nodes in ganesha cluster
Change-Id: I27503558da176f0b1a1f0953a7e7ebe86976608d
BUG: 1401877
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/16041
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit e9809e62bd49bf24d4e96604f8d2cdf96b7ed021
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Jan 17 15:43:47 2017 +0530
dht/rebalance Estimate time to complete rebalance
The estimates will be logged to the rebalance log on running
gluster v rebalance <vol> status
Change-Id: I9d51b139cd4c8dfde1ff2c2050720ae606c13fc6
BUG: 1396004
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15893
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 7d107e14d815aac14d7a749dcd01a75a1d770980
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Jan 10 11:21:06 2017 +0100
cli: keep 'gluster volume status detail' consistent
The output of the command 'gluster volume status <volname> detail' is
not consistent between operating systems. On linux hosts it shows the
file system type, the device name, mount options and inode size of each
brick. However the same command executed on a FreeBSD host doesn't show
all this information, even for bricks stored on a linux.
Additionally, for hosts other than linux, this information is shown as
'N/A' many times. This has been fixed to show as much information as it
can be retrieved from the operating system.
The file contrib/mount/mntent.c has been mostly rewriten because it
contained many errors that caused mount information to not be retrieved
on some operating systems.
Change-Id: Icb6e19e8af6ec82255e7792ad71914ef679fc316
BUG: 1411334
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/16371
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 2acc35b15d1eb81c5346cb11db529212760ee8ea
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Jan 19 12:23:00 2017 +0530
gluster: Typos in logs and comments
Replaced 'recieve' with 'receive'.
Change-Id: I4c1c9147db5437feb81e4c83ed074440aaa28e07
BUG: 1414645
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/16429
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <manikandancs333@gmail.com>
Tested-by: Manikandan Selvaganesh <manikandancs333@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit fc87f6ecb61a5bac09bc3d2d8f6b36c7f3ec75ab
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 6 12:49:32 2017 +0100
gfapi: add API to trigger events for debugging and troubleshooting
Introduce glfs_sysrq() as a generic API for triggering debug and
troubleshoot events. This interface will be used by the feature to get
statedumps for applications using libgfapi.
The current events that can be requested through this API are:
- 'h'elp: log a mesage with all supported events
- 's'tatedump: trigger a statedump for the passed glfs_t
In future, this API can be used by a CLI to trigger statedumps from
storage servers. At the moment it is limited to take statedumps, but it
is extensible to set the log-level, clear caches, force reconnects and
much more.
BUG: 1169302
Change-Id: I18858359a3957870cea5139c79efe1365a15a992
Original-author: Poornima G <pgurusid@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/16414
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit a6cc490625298e06d9bfc01a6d479cf13b934779
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Wed Jan 18 15:56:00 2017 +0530
Fixes upgrade issue in quota.conf
When an op-version bump up is done the glusterd_store_quota_config
upgrades the quota conf file, although overwriting the same later
which leaves out all gfid entries. While this is warranted for
enable opcode, for upgrade we need to retain gfids. So for upgrade
opcode, we return once the upgrade is done.
Change-Id: I2b38c6022d74b4a14dc07432651a51cc39ad5120
BUG: 1414346
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
Reviewed-on: http://review.gluster.org/16425
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 2d6a2e65dcb2999dd82031e17bf65ec5643ce64c
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jan 17 06:39:25 2017 -0500
features/changelog: Fix htime xattr during brick crash
The htime file contains the path of all the changelogs
that is rolloved over till now. It also maintains xattr
which tracks the latest changelog file rolloved over
and the number of changelogs. The path and and xattr
update happens in two different system calls. If the
brick is crashed between them, the xattr value becomes
stale and can lead to the failure of gf_history_changelog.
To identify this, the total number of changelogs is being
calculated based on htime file size and the record
length. The above value is used in case of mismatch.
Change-Id: Ia1c3efcfda7b74227805bb2eb933c9bd4305000b
BUG: 1413967
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/16420
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 1a472c1a28bdfa7b81e5635c4ac466c115727a69
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jan 9 10:56:13 2017 +0530
glusterd: bypass add-brick validation with force
Commit c916a2f added a validation to restrict add-brick operation if a
replica configuration is changed and any of the bricks belonging to the
volume is down. However we should bypass this validation with a force
option if users really want to have add-brick to go through at the sake
of the corner cases of data loss issue.
The original problem of add-brick getting failed when layout is not set
will still be a problem with a force option as the issue has to be taken
care in the DHT layer.
Change-Id: I0ed3df91ea712f77674eb8afc6fdfa577f25a7bb
BUG: 1406411
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/16358
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0a94f869378b781a8b60bd3853c252cdbe442bfc
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Mar 15 03:14:16 2016 -0400
inode: Add per xlator ref count for inode
Debugging inode ref leaks is very difficult as there is no info
except for the ref count on the inode. Hence this patch is first step
towards debugging inode ref leaks. With this patch, in the statedump
we get additional info that tells the ref count taken by each xlator
on the inode.
Change-Id: I7802f7e7b13c04eb4d41fdf52d5469fd2c2a185a
BUG: 1325531
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/13736
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 38d45140a48ac593b9348201b2bdc2a49f16b595
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jan 10 15:39:55 2017 -0500
geo-rep: Separate slave mount logs for each connection
Geo-rep worker mounts the slave volume on the slave
node. If multiple worker connects to same slave node,
all workers share the same mount log file. This
is very difficult to debug as logs are cluttered from
different mounts. Hence creating separate mount log
file for each connection from worker. Each connection
from worker is identified uniquely using 'mastervol uuid',
'master host', 'master brickpath', 'salve vol'. The log
file name will be combination of the above.
Change-Id: I67871dc8e8ea5864e2ad55e2a82063be0138bf0c
BUG: 1412689
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/16384
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit b92ff2a6e4320e56749a4669f7fbddacfac0363b
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Nov 2 07:22:39 2016 +0100
fuse: limit fusermount fallback to EPERM cases
There are two mount mechanims for fuse:
1) Call mount(2) syscall directly -- implemented by fuse_mount_sys
2) Call out to fusermount(1) helper utilty to do the mount --
implemented by fuse_mount_fusermount
[Note: both libfuse and glusterfs ships a variant of this helper
utility; named, respectively, fusermount and fusermount-glusterfs.
The two has diverged, and are not compatible at the moment.]
The intended use of 1) is privileged mounting, ie. when root
is invoking the glusterfs client. (It cannot work for non-privileged
users as the kernel enforces privilege for mount(2), more precisely,
caller context needs CAP_SYS_ADMIN, see capabilities(7).)
The intended use of 2) is unprivileged mountig, ie. when
the glusterfs client is invoked by an unprivileged user.
The helper utility is a setuid binary, so it can perform
mount(2) on behalf of the user.
The main mount routine, gf_fuse_mount, calls fuse_mount_sys first,
and if that fails, tries also with fuse_mount_fusermount. This
is what we call "fusermount fallback". However, in the light of
the above remarks about intended use, this logic should apply if
the fuse_mount_fusermount fails because of a privilege shortage,
ie. with error "Operation not permitted" (errno EPERM).
So far the fallback was unconditional (masking bugs of
fuser_mount_sys, as it happens in referred BUG). Now we
add the "errno == EPERM" condition.
BUG: 1297182
Change-Id: Ia89d975d1e27fcfa5ab2036ba546aa8fa0d2d1b0
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/15766
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 53569d29439eb6e2f1891589416130419f64ed6e
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Dec 8 16:48:55 2016 +0530
glusterd: Change the volfile to have readdir-ahead as a child of dht
As mentioned in feature page http://review.gluster.org/#/c/16090/
readdir-ahead will be optionally placed below dht.
There are two options:
1. performance.readdir-ahead
2. performance.parallel-readdir
If only option is enabled, then readdir ahead is placed at its
original place as an ancestor of dht. If both the options 1 and 2
are enabled then readdir ahead is placed as a child of dht.
Also changes have been made to retain the rebalance, quotad,
snapd vol files to remain unchanged.
Change-Id: I0adf0b476fcbf91251f5a2fee2241786a3d8255a
BUG: 1401812
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/16072
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bdf6ba331da03c18575fc12001d143e2355c291e
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Jan 6 10:37:54 2017 -0500
storhaug HA: first step, remove resource agents and setup script
resource agents and setup script(s) are now in storhaug
This is a phased switch-over to storhaug. Ultimately all components
here should be (re)moved to the storhaug project and its packages.
But for now some will linger here.
Change-Id: Ied3956972b14b14d8a76e22c583b1fe25869f8e7
BUG: 1410843
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/16349
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit b6a78de0fa344c0a5e80b993ad08355a67e06fad
Author: Saurabh Badhwar <sbsaurabhbadhwar9@gmail.com>
Date: Fri Jan 13 12:59:51 2017 +0530
fuse: Fix a possible resource leak under GF_SOLARIS_HOST_OS in fuse-helpers.c
Change-Id: Ie367a6dec2a0d5848631b19ebbe39ceafa954a60
BUG: 1412918
Signed-off-by: Saurabh Badhwar <sbsaurabhbadhwar9@gmail.com>
Reviewed-on: http://review.gluster.org/16395
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2457c3c9d2ad14f5ac9e113177ca4ca241d11e19
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Jul 12 16:40:28 2016 +0530
tier : Tier as a service
tierd is implemented by separating from rebalance process.
The commands affected:
1) Attach tier will trigger this process instead of old one
2) tier start and tier start force will also trigger this process.
3) volume status [tier] will show tier daemon as a process instead
of task and normal tier status and tier detach status works.
4) tier stop implemented.
5) detach tier implemented separately along with new detach tier
status
6) volume tier volname status will work using the changes.
7) volume set works
This patch has separated the tier translator from the legacy
DHT rebalance code. It now sends the RPCs from the CLI
to glusterd separate to the DHT rebalance code.
The daemon is now a service, similar to the snapshot daemon,
and can be viewed using the volume status command.
The code for the validation and commit phase are the same
as the earlier tier validation code in DHT rebalance.
The “brickop” phase has been changed so that the status
command can use this framework.
The service management framework is now used.
DHT rebalance does not use this framework.
This service framework takes care of :
*) spawning the daemon, killing it and other such processes.
*) volume set options , which are written on the volfile.
*) restart and reconfigure functions. Restart is to restart
the daemon at two points
1)after gluster goes down and comes up.
2) to stop detach tier.
*) reconfigure is used to make immediate volfile changes.
By doing this, we don’t restart the daemon.
it has the code to rewrite the volfile for topological
changes too (which comes into place during add and remove brick).
With this patch the log, pid, and volfile are separated
and put into respective directories.
Change-Id: I3681d0d66894714b55aa02ca2a30ac000362a399
BUG: 1313838
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/13365
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 4aadc04f5d91ec5d1e5a66b6af83c50a5b6376f4
Author: Michael Adam <obnox@samba.org>
Date: Wed Dec 7 07:21:41 2016 +0100
glusterd: remove extra space in error message
BUG: 1402237
Change-Id: Ib6efca655555a92a0542ef6056f3357f390eeb38
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/16048
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 5790c603acbec16cdce21b1a45dae7fc8cc14e60
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri Jan 13 12:17:05 2017 +0530
upcall: Resolve dict leak from up_(f)removexattr in upcall code path
Problem: In up_(f)removexattr() dict_for_key_value() is used to create a
new dict. This dict is not correctly unref'd and gets leaked.
Solution: To avoid the leak up_(f)removexattr() now also does a
dict_unref() on the newly created dict.
While reviewing the code in up_(f)setxattr() for a similar problem, it
was noticed that there is an extra dict created. There is no need for
this copy, upcall_local_init() can just take the dict that was passed as
argument to the FOP.
BUG: 1412917
Change-Id: I5bb9a7d99f5087af11c19ae722de62bdb5ad1498
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/16392
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 86c491fbc41a93b5b8469849ce1940c271f99e86
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 13 14:31:27 2017 +0100
rpm: fix glusterfs-server(%postun) scriptlet error
While introducing the usage of the %firewalld_restart macro, the old
scriplet was not correctly removed. This causes an error to be displayed
when the RPM gets updated or uninstalled.
Fixes: f99750b4477538cd1f97ce6340e1813202f986e2
Change-Id: I69091d8e9e3c412dc3cb52246967eac29d2ebc90
BUG: 1410853
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/16408
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 2f1764be4a356716bfb1388de70e6ac37fc33e56
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Jan 12 11:14:49 2017 +0530
tests/distribute: remove bug-1063230.t
bug-1063230.t does not add value and has diverged
from the original BZ it was supposed to test.
Change-Id: I13ae1c68c276233dd53548d1333e3eb4b936785d
BUG: 1412467
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/16379
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e019ffd46b47659c340cf7eb06b08203058474fc
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jan 10 00:30:42 2017 -0500
geo-rep: Handle directory sync failure as hard error
If directory creation is failed, return immediately before
further processing. Allowing it to further process will
fail the entire directory tree syncing to slave. Hence
master will log and raise exception if it's directory
failure. Earlier, master used to log the failure and
proceed.
Change-Id: Iba2a8b5d3d0092e7a9c8a3c2cdf9e6e29c73ddf0
BUG: 1411607
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/16364
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit bd53e0d897347e852931a4edf39841513df491eb
Author: SonaArora <sarora@redhat.com>
Date: Fri Jan 6 14:21:56 2017 +0530
cli/geo-rep: Fix geo-rep status detail
Earlier this command works when master and slave volume args are
given. Now it works even when no volume args are given (i.e. 'gluster
volume geo-replication status detail) and also when master volume is given
(i.e.'gluster volume geo-replication <master-vol> status detail').
BUG: 1410071
Signed-off-by: SonaArora <sarora@redhat.com>
Change-Id: I1a39241a4a5d70c20b2326599b3cccd8f1f6dc78
Reviewed-on: http://review.gluster.org/16347
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Kotresh HR <khiremat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit e5f84864859096cba733ab6d08505ce44c5ba49c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Dec 30 14:57:17 2016 +0530
afr: Avoid resetting event_gen when brick is always down
Problem:
__afr_set_in_flight_sb_status(), which resets event_gen to zero, is
called if failed_subvols[i] is non-zero for any brick. But failed_subvols[i]
is true even if the brick was down *before* the transaction started.
Hence say if 1 brick is down in a replica-3, every writev that comes
will trigger an inode refresh because of this resetting, as seen from
the no. of FSTATs in the profile info in the BZ.
Fix:
Reset event gen only if the brick was previously a valid read child and
the FOP failed on it the first time.
Also `s/afr_inode_read_subvol_reset/afr_inode_event_gen_reset` because
the function only resets event gen and not the data/metadata readable.
Change-Id: I603ae646cbde96995c35db77916e2ed80b602a91
BUG: 1409206
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/16309
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 7e506adf6661060b49e4212bcec51948e6b81f76
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Jan 12 08:38:50 2017 +0100
fuse: fix memory leak in setxattr
If there's some failed check in setxattr of mount/fuse before
actually starting the operation, a fuse_state_t structure is
leaked.
This fix correctly releases allocated resources in case of
error.
Change-Id: I8b1cda67a613c13b6bc38947352e2ccfccf96a1d
BUG: 1412174
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/16380
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 093ed7eb98c12b0c717a836becfeda37e7fe9112
Author: Patrick Uiterwijk <patrick@puiterwijk.org>
Date: Tue Jan 10 23:52:13 2017 +0000
Make getvolfile.py example pep8 compliant
Change-Id: I7d3c1e871b9fa3859745f4d67acf05f16c7ccf5f
BUG: 1412002
Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
Reviewed-on: http://review.gluster.org/16372
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 270b052ab51b20fb5eaa3228fdab7fc648194272
Author: Patrick Uiterwijk <patrick@puiterwijk.org>
Date: Wed Jan 11 00:04:47 2017 +0000
MAINTAINERS: src.fedoraproject.org is the new location and uses https
Change-Id: I7797ffa3df7a7174a2837a20fd708fa919db537b
BUG: 1411999
Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
Reviewed-on: http://review.gluster.org/16373
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d69bd77cb9eff1549c03c2547ec912411e0cea91
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Wed Dec 28 20:33:54 2016 +0530
glusterd: Add info on op-version for clients in vol status output
Currently the `gluster volume status <VOLNAME|all> clients` command
gives us the following information on clients:
1. Brick name
2. Client count for each brick
3. hostname:port for each client
4. Bytes read and written for each client
There is no information regarding op-version for each client. This
patch adds that to the output.
Change-Id: Ib2ece93ab00c234162bb92b7c67a7d86f3350a8d
BUG: 1409078
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: http://review.gluster.org/16303
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 6e1e1d95fd55664a08a698653ee571c9246a1b39
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jan 12 14:19:31 2017 +0530
Upcall: Fix possible memleak when inode_ctx_set fails
In __upcall_inode_ctx_set(), if inode_ctx_set fails we should
free allocated memory for ctx. This patch takes care of the same.
Change-Id: Iafb42787151a579caf6f396c9b414ea48d16e6b4
BUG: 1412489
Reported-by: Nithya Balachandran <nbalacha@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/16381
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 3cd4da893c9513fbfe50e46a396d6928db53101a
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jan 10 13:26:02 2017 +0530
cluster/afr: Do not log of split-brain when there isn't one
* Even on errors like ENOENT, AFR logs split-brain after
read-txn refresh, introduced by commit a07ddd8f.
This can be a cause of much panic and confusion and needs to be fixed.
* Also fixed this issue in write-txns.
* Fixed afr read txns to log about split-brain only after knowing that
there is no split-brain choice configured.
* Removed code duplication
* Fixed incorrect passing of error code in afr_write_txn_refresh_done()
(the function was passing -0 as errno to gf_msg().
Change-Id: I354f454ce5bf0e5f00bc27916eb597367cb7d927
BUG: 1411625
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16362
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit d78da8b0040a0dc2220408e749ce76b6a74d89a6
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Oct 27 07:30:48 2016 +0200
feature/dht: undo partially successful dir rename
As with dht, dirs are present on all subvolumes,
renaming them is a compound operation and thus a
partial success + partial failure scenario is
possible, resulting in an inconsistent state.
For purposes of reproduction, such a scenario can
easily be produced by stopping the volume, edit the
volfile of a certain subvolume to get at an
"option read-only on" setting, and then restart
the volume. Thus those operations that are to make change
on the affected subvolume will fail with EROFS.
To handle such scenarios, we introduce an in-memory cache
where we record the return values obtained from the
subvolumes. At the final stage of the dir rename operation
we check if it's a partial success/fail situation. If yes,
then we perform a reverse rename op on those subvolumes
where the operation succeeded.
Change-Id: I3d05f74f53932cb984a918d252a7309c1009a51d
BUG: 1412069
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/15739
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit 05f3586b54b1682f42f4d29df06835a0be032b9e
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Jan 9 13:10:19 2017 +0100
libglusterfs: fix statvfs in FreeBSD
FreeBSD interprets statvfs' f_bsize field in a different way than Linux.
This fix modifies the value returned by statvfs() on FreeBSD to match
the expected value by Gluster.
Change-Id: I930dab6e895671157238146d333e95874ea28a08
BUG: 1356076
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/16361
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 77031cde72d860510484087441ca346d78f06ad9
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Dec 19 09:14:44 2016 +0530
dht : file rename operation is successful but log has error File exists
Problem: file rename operation is successful but log has error
'key:trusted.glusterfs.dht.linkto error:File exists'
Solution: The error comes in log only when file already has set this xattr
(trusted.glusterfs.dht.linkto) before run rename operation and
in that case sys_lsetxattr throws this kind of message.
To avoid the error message in logs update the condition in
posix_handle_pair.
BUG: 1404905
Change-Id: Iafd8cb45f9d7f4fe247e297a6ef0af978a8d0b30
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/16185
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit bc325a068167a0124b1d50689f3a0e31048e9c38
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Jan 9 09:55:26 2017 +0530
readdir-ahead : Perform STACK_UNWIND outside of mutex locks
Currently STACK_UNWIND is performnd within ctx->lock.
If readdir-ahead is loaded as a child of dht, then there
can be scenarios where the function calling STACK_UNWIND
becomes re-entrant. Its a good practice to not call
STACK_WIND/UNWIND within local mutex's
Change-Id: If4e869849d99ce233014a8aad7c4d5eef8dc2e98
BUG: 1401812
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/16068
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1ae3698eed8bd6df79569857d1c1a306e70d87ec
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 6 17:16:38 2017 +0100
rpm: depend on firewalld-filesystem for directory ownership
Also use the %firewalld_reload macro that is provided by the
firewalld-filesystem package.
BUG: 1410853
Change-Id: Ibbbc18cc394f8b1e5ba74927effc41c466667479
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/16351
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 8c7a78597e7695d2c6e403b6f1d0ac21122bed12
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Dec 6 14:43:10 2016 +0530
dht: At places needed use STACK_WIND_COOKIE
Issue:
frame has a void * cookie pointer.
In case of STACK_WIND_COOKIE frame->cookie is assigned
to what is sent by the caller.
In case of STACK_WIND frame->cookie is assigned to point
point to the frame itself.
For ease of coding, at many places, the cookie in the cbk
is used to get the pointer to the next xl. This is
inconsistent when STACK_WIND_TAIL comes into picture.
Eg: dht_setxattr () {
for (i = 0 ; i < conf->subvolume_cnt ; i++) {
STACK_WIND (..dht_checking_pathinfo_cbk,
conf->subvolumes[i] ..);
}
dht_checking_pathinfo_cbk (...void *cookie...) {
prev = cookie;
...
for (i = 0; i < conf->subvolume_cnt; i++) {
if (conf->subvolumes[i] == prev->this) {
...
}
}
}
Consider the below graph:
dht (parent)
readdir-ahead => Doesn't define setxattr and uses STACK_WIND_TAIL
protocol-client
With this graph, when dht_checking_pathinfo_cbk is called,
cookie will have frame pointing to protocol-client.
i.e. prev->this will be protocol-client. But dht was expecting
it to be readdir-ahead as it has stored in conf->subvolumes[i]
Solution:
Hence, as a thumb rule, if cbk is using cookie, then we explicitly
call STACK_WIND_COOKIE.
Change-Id: I83aea1e24c809c5a91a0db7283e908e125471bd4
BUG: 1401812
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/16039
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit b23e8bc9e1f1493099eb7d408be69a287b71432c
Author: Sunil Kumar H G <sheggodu@redhat.com>
Date: Fri Dec 30 14:11:15 2016 +0530
cluster/ec: Fixing log message
Updating the warning message with details to improve
user understanding.
BUG: 1409202
Change-Id: I001f8d5c01c97fff1e4e1a3a84b62e17c025c520
Signed-off-by: Sunil Kumar H G <sheggodu@redhat.com>
Reviewed-on: http://review.gluster.org/16315
Tested-by: Sunil Kumar Acharya
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit fe0678653e63422bacb0fa80bbaac24222df68bf
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Mon Dec 19 15:07:14 2016 +0530
glusterd: Get maximum supported op-version in a cluster
gluster volume get <VOLNAME> cluster.opversion gives us the current
op-version on which the cluster is operating. There is no command
that lets the user know the maximum supported op-version that the
cluster can run on.
This patch adds a new global option cluster.max-op-version, that
can be used to retrieve the maximum supported op-version in a
cluster.
Usage:
# gluster volume get all cluster.max-op-version
Example output:
Option Value
------ -----
cluster.max-op-version 30900
NOTE: The only way to test this feature for now is to set the
GD_OP_VERSION_MAX macro to different values (30800 for 3.8,30900
for 3.9, and so on) and rebuild glusterd. Since the regression test
framework currently doesn't have support to simulate these tests,
there are no accompanying regression tests for this feature. It
should be possible to add tests once glusto comes in and makes it
easier to run a heterogeneous cluster.
Change-Id: I547480ee5e7912664784643e436feb198b6d16d0
BUG: 1365822
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: http://review.gluster.org/16283
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 300b4e87f97cda1659a535bb53e198f16e18a233
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Dec 26 16:26:49 2016 +0530
md-cache: Cache updated as a part of invalidate should not update time
Currently when a invalidate happens we update the cache along with
the cache time. The problem with this is, upcall doesn't update the
last access time of a client when an invalidation is sent, thus resulting
in a timewindow where the md-cache has cached, but the upcall is unaware
and hence upcall will not further invalidate the cache(unless a fop is sent
from the same client, and upcall updates its database to reflect the same)
Change-Id: Ibceb8d2fc360582752846bbf7fd59697d5424754
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/16295
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8d0e384203bdb00c7910540d7787a0ce511dbdf7
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Dec 26 15:16:10 2016 +0530
performance/write-behind: Add debug messages
Change-Id: I2ea1350fcbe4b6c06dcb8093b28316f734cd3b48
BUG: 1379655
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/16285
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit b74837d5145f1f6536831dfee816bc610b9a4435
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Jan 6 21:06:23 2017 +0530
cluster/dht: Incorrect migration checks in fsync
Fixed the order of the migration phase checks
in dht_fsync_cbk. Phase1 should never be hit if op_ret
is non zero.
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Change-Id: I9222692e04868bffa93498059440f0aa553c83ec
BUG: 1410777
Reviewed-on: http://review.gluster.org/16350
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5a05c2a18e6aa02fba2083b80ffcf756ae596f0a
Author: Muthu-vigneshwaran <mvignesh@redhat.com>
Date: Mon Dec 5 21:02:05 2016 +0530
glusterfs : Removing logically dead code
CID = 1356502
BUG: 789278
Change-Id: I11a814addc6607902c12aca8f4efec5741cbd7d3
Signed-off-by: Muthu-vigneshwaran <mvignesh@redhat.com>
Reviewed-on: http://review.gluster.org/16028
Tested-by: Muthu Vigneshwaran <muthuvigneshwaran77@gmail.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit cdc9eaec2ed8ff7fd0a2f97d115cda45d90c1294
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Jan 4 16:29:49 2017 +0530
features/uss: Remove redundant dict_unref
In case dict_set_dynstr_with_alloc fails, dict_unref is done
when exection jumps to label 'out'.
Change-Id: I083386b7f85207348ba0bc353b5d1036ab821a15
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/16321
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c70d351f4494b0dbb61d0fce50f294487425016e
Author: Nigel Babu <nigelb@redhat.com>
Date: Tue Dec 27 10:56:57 2016 +0530
tests: Remove rpm test
This is already tested by our smoke test. Testing it again is redundant.
Change-Id: Icae4e8650002cd847dcb7ea76fd0447df7e72816
BUG: 1408755
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: http://review.gluster.org/16287
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5664dae3986f74c5b8d28db72ab16928cf5118b1
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Dec 6 07:46:52 2016 +0100
posix: make sure atime and mtime are set when calling lutimes()
When overwriting an existing file with O_TRUNC, the 'atime' was set to
0, meaning the Epoch (01-Jan-1970 UTC). However, the 'mtime' gets
updated correcty.
In case 'atime' or 'mtime' is not passed in the 'struct iatt', the time
values passed to the systemcall are taken from the current values are
returned by lstat().
Change-Id: I7021b7161dcd6c9a3e515d98f6d4847533c434b3
BUG: 1401777
Reported-by: Eivind Sarto <eivindsarto@gmail.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/16034
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 99986ae597fb423754a47a392662acba7d0750b2
Author: Susant Palai <spalai@redhat.com>
Date: Thu Jan 5 11:46:20 2017 +0530
dht/rebalance: remove errno check for failure detection
BUG: 1410355
Change-Id: I867419ca36a81ef7209e6911a46c1c2c898b8eab
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/16328
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5aff41c892e7422b42976d6e72e83c0512370fa4
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Jan 5 14:06:21 2017 +0530
glusterd: Fail add-brick on replica count change, if brick is down
Problem:
1. Have a replica 2 volume with bricks b1 and b2
2. Before setting the layout, b1 goes down
3. Set the layout write some data, which gets populated on b2
4. b2 goes down then b1 comes up
5. Add another brick b3, and heal will take place from b1 to b3, which
basically have no data
6. Write some data. Both b1 and b3 will mark b2 for pending writes
7. b1 goes down, and b2 comes up
8. b2 gets heald from b1. During heal it removes the data which is already
in b2, considering that as stale data. This leads to data loss.
Solution:
1. In glusterd stage-op, while adding bricks, check whether the replica
count is being increased
2. If yes, then check whether any of the bricks are down at that time
3. If yes, then fail the add-brick to avoid such data loss
4. Else continue the normal operation.
This check will work enen when we convert plain distribute volume to replicate
Test:
1. Create a replica 2 volume
2. Kill one brick from the volume
3. Try adding a brick to the volume
4. It should fail with all bricks are not up error
5. Cretae a distribute volume and kill one of the brick
6. Try to convert it to replicate volume, by adding bricks.
7. This should also fail.
Change-Id: I9c8d2ab104263e4206814c94c19212ab914ed07c
BUG: 1406411
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: http://review.gluster.org/16330
Tested-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 08402349de470c380aa81fa85a9abaa504ce25f2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jan 4 13:37:23 2017 +0530
cluster/ec: Do lookup on an existing file in link
Problem:
In link fop lookup is happening on the new fop which doesn't exist so the iatt
ec serves parent xlators has size as zero which leads to 'cat' giving empty output
Fix:
Change code so that lookup happens on the existing link instead.
BUG: 1409730
Change-Id: I70eb02fe0633e61d1d110575589cc2dbe5235d76
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/16320
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Xavier Hernandez <xhernandez@datalab.es>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 7bd5f224e45882737080aacc46bfa46730f6f1e6
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Jan 5 15:36:02 2017 +0530
ec: Invalidations in disperse volume should not update the stat
Issue:
In disperse volume, the file is present across bricks, hence the stat
from one brick doesn't carry the valid size of the file. Therefore
the upcall from one brick updating the md-cache results in wrong size
being updated.
Fix:
If the notification is cache invalidation then, indicate md-cache that
the attributes is invalid.
BUG: 1410375
Change-Id: Id89d2283478e70b62b435a8891fffc86d2be8cb2
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/16329
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 82f531b7ea3b44cc5070703bb3cdafd06f833fd5
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Dec 5 13:01:41 2016 -0500
libglusterfs: serialize init/reconfigure calls
These functions do not generally "expect" to be called more than once
in parallel, and many are likely to misbehave in that case (one case
in DHT already). Such parallel calls have not generally happened
because there are only a few places where we call these functions, and
those have been implicitly serialized until recently. However, recent
changes in the epoll layer change that, as does brick multiplexing.
Therefore, the serialization is now explicit at the init/reconfigure
level.
It would be sufficient to serialize calls to a particular translator's
init and reconfigure functions, but that would require per-translator
locks and a bit more complexity in maintaining/using them. Since
there's no clear reason why we would need or want to support a higher
level of parallelism, the simpler approach of a global lock should
suffice.
Change-Id: I26296c2826e91dc00b7f0c2061bcc2964ef90c4c
BUG: 1399134
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/16030
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit e7f78c0233d7c97dc18152a05d408e5e6400cd21
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Dec 6 16:31:51 2016 +0530
readdir-ahead: Enhance EOD detection logic
Issue:
Currently end of directory is identified on obtaining a
readdirp_cbk with op_ret = 0 (i.e. 0 entries fetched in
readdirp). Thus an extra readdirp is required for every
directory just to identify EOD. Consider a case of listing
large number of small directories. The readdirp fops required
are doubled in that case.
Solution:
On reaching the EOD, posix sets the op_errno to ENOENT,
hence along with looking for 'op_ret == 0' we also
look for 'operrno == ENOENT' ehile checking for EOD condition
Change-Id: I7a5b52e7b98f5dc236c387635fcc651dac0171b3
BUG: 1401812
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/16042
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 861e9613460d2721e14f11fe59127e5b1a19ca28
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jan 5 11:28:44 2017 +0530
eventsapi: Use `getaddrinfo` instead of `gethostbyname`
`gethostbyname` is not thread safe. Use `getaddrinfo` to avoid
any race or segfault while sending events
BUG: 1410313
Change-Id: I164af1f8eb72501fb0ed47445e68d896f7c3e908
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/16327
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 7a67cd06831ec57acbe6f12734618e239ba8906d
Author: Nigel Babu <nigelb@redhat.com>
Date: Thu Dec 22 14:28:27 2016 +0530
tests: Remove tests/distaf
We will not be using it in the future
BUG: 1408131
Change-Id: Idebaaadb06786eebc08969ce0cc15a9df4bd9f42
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: http://review.gluster.org/16270
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 566d4d19f138ee61364dd2dee93b442fec75cc5d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 3 12:50:54 2017 +0530
cluster/dht: Do rename cleanup as root
Problem:
Rename linkfile cleanup is done as non-root which may not have priviliges to do
the rename so it fails with EACCESS. MKDIR on that name in future will start to
hole on this subvolume. It is not easy to hit on fuse mounts because vfs takes
care of the permission checks even before rename fop is wound. But with
nfs-ganesha mounts it happens.
Fix:
Do rename cleanup as root
BUG: 1409727
Change-Id: I414c1eb6dce76b4516a6c940557b249e6c3f22f4
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/16317
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 4f1dbdc58100322bf6005265d106c31265c8a06c
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Dec 28 14:32:12 2016 +0530
mount/fuse: Fix the place where graph-switch event is logged
Change-Id: I3c8577b87db02a2a6ce6159e7d04cf58a2bda0c1
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16302
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1be3bd133e99b12553466eb1f13fe5e49ecf3dae
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Thu Dec 15 09:06:00 2016 -0800
core: Disable the memory pooler in Gluster via a build flag
Summary:
Passing --disable-mempool to configure will disable the mempool.
Change-Id: I60d5f70d54de507fe9f4695d7589f7ae1ba4bb0f
BUG: 1405165
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Reviewed-on: http://review.gluster.org/16148
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit e20146c3cc0e7978b644b85b97fc7b12b4e8001e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Nov 30 17:44:29 2016 -0500
storage/posix: log the error when locking the export directory fails
posix xlator tries to prevent external unmount of the brick export directory
by locking it. It locks the export directory by opening it (i.e. doing a opendir).
But if opendir fails it errors out resulting in the brick process going down. The
error due to which opendir failed is not logged.
Change-Id: I28648382b7f0b88fb1aeb36152e5ab5d812374c9
BUG: 1401095
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/16018
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Vijay Bellur <vbellur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit adadd38994f6ba872ad09cc4f540626719c6998a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Dec 29 12:10:00 2016 +0000
tests: Fix split-brain-favorite-child-policy.t failures
Problem:
In CentOS-7, the file was receving an extra removexattr(security.ima)
FOP which changed its ctime, breaking the assumption that a particular brick
had the latest ctime based on the writevs done in the .t
Fix:
1. Compare the ctime of both files in the backend and pick the one with
the latest ctime for the fav-child policy. Also unmount the volume
before comparing, to avoid any further FOPS on the file that
can possibly modify the timestamps.
2. Added floating point handling in stat function. Thanks to Pranith for
the helping debugging the regex.
Change-Id: I06041a0f39a29d2593b867af8685d65c7cd99150
BUG: 1408757
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/16288
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 276ea59bc8bb3c8ed9448ed9fd4824dda95d05d5
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Dec 30 10:33:13 2016 +0530
cluster/dht: Fix dict_leak in migration check tasks
Fixed a memleak where dict was not being unrefed
in the dht_migration_complete_check_task and
dht_rebalance_inprogress_task functions.
Change-Id: I3d42e9a2e5c8596c985bf6431a68fd3905227383
BUG: 1409186
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/16308
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: MOHIT AGRAWAL <moagrawa@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit fa85baa83cb523a78fb8fdad7fbcb218e1c9e129
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Dec 27 11:17:29 2016 +0530
tests: fix tests/bugs/glusterd/bug-913555.t spurious failures
Mainly replaced EXPECT instances with EXPECT_WITHIN
Change-Id: If48f444f6b2ba6713fdc5e31ff3a642092e62ada
BUG: 1408758
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/16289
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2ac85990f395fc63fa83aff87d52afe74f7f87d8
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Fri Sep 23 16:35:15 2016 +0530
glusterd, cli: Get global options through volume get functionality
Currently it is not possible to retrieve values of global options
by using the 'gluster volume get' functionality if there are no
volumes present. In order to get the global options one has to use
'gluster volume get' with a specific volume name. This usage makes
the illusion as though the option is set only on one volume, which
is incorrect. When setting the global options, 'gluster volume set'
provides a way to set them using the volume name as 'all'.
Similarly, retrieving the global options should be made possible by
using the volume name 'all' with the 'gluster volume get'
functionality. This patch adds that functionality to 'volume get'
Usage:
# gluster volume get all <OPTION/all>
Change-Id: Ic2fdb9eda69d4806d432dae26d117d9660fe6d4e
BUG: 1378842
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: http://review.gluster.org/15563
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 253cd5e4d2140d34303e3b9665b2cf212805ccf3
Author: Kevin Vigor <kvigor@fb.com>
Date: Sat Dec 17 08:31:24 2016 -0800
Repair EC tests for FB environment (/mnt/gvfs is teh sux00r)
Summary:
Don't blindly 'df', target the volume in question.
(this is because FB build environment has a /mnt/gvfs which
fails df).
Test Plan:
runtests.sh
Reviewers:
Subscribers:
Tasks:
Blame Revision:
Change-Id: Ic2c5883dd102835db64be9594657257e20711ba0
BUG: 1406878
Signed-off-by: Kevin Vigor <kvigor@fb.com>
Reviewed-on-3.8-fb: http://review.gluster.org/16182
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Shreyas Siravara <sshreyas@fb.com>
Reviewed-by: Shreyas Siravara <sshreyas@fb.com>
Reviewed-on: http://review.gluster.org/16226
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 7774c315a9fe1144b833167ea2f9938e85107dcf
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Dec 27 16:15:30 2016 +0530
performance/readdir-ahead: mark two options as NO_DOC
The two options are rda-high-wmark and rda-low-wmark. The impact of
these two options is yet to be fully understood and hence not
advertising these options to not run into surprises.
Change-Id: Ia537f4cc342011f0f2f3849ad6b938e247e5622d
BUG: 1356960
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/16297
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 49d189338f962af0c34794bf9a15785e45cb4207
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Dec 26 21:08:03 2016 +0530
cluster/afr: Fix missing name indices due to EEXIST error
PROBLEM:
Consider a volume with granular-entry-heal and sharding enabled. When
a replica is down and a shard is created as part of a write, the name
index is correctly created under indices/entry-changes/<dot-shard-gfid>.
Now when a read on the same region triggers another MKNOD, the fop
fails on the online bricks with EEXIST. By virtue of this being a
symmetric error, the failed_subvols[] array is reset to all zeroes.
Because of this, before post-op, the GF_XATTROP_ENTRY_OUT_KEY will be
set, causing the name index, which was created in the previous MKNOD
operation, to be wrongly deleted in THIS MKNOD operation.
FIX:
The ideal fix would have been for a transaction to delete the name
index ONLY if it knows it is the one that created the index in the first
place. This would involve gathering information as to whether THIS xattrop
created the index from individual bricks, aggregating their responses and
based on the various posisble combinations of responses, decide whether to
delete the index or not. This is rather complex. Simpler fix would be
for post-op to examine local->op_ret in the event of no failed_subvols
to figure out whether to delete the name index or not. This can occasionally
lead to creation of stale name indices but they won't be affecting the IO path
or mess with pending changelogs in any way and self-heal in its crawl of
"entry-changes" directory would take care to delete such indices.
Change-Id: Ic1b5257f4dc9c20cb740a866b9598cf785a1affa
BUG: 1408712
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16286
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit c132fc839e762fc2ec72f5c2fafb96731eeb9f1d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Dec 23 07:11:13 2016 +0000
afr: use accused matrix instead of readable matrix for deciding heals
Problem:
afr_replies_interpret() used the 'readable' matrix to trigger client
side heals after inode refresh. But for arbiter, readable is always
zero. So when `dd` is run with a data brick down, spurious data heals
are are triggered. These heals open an fd, causing eager lock to be
disabled (open fd count >1) in afr transactions, leading to extra FXATTROPS
Fix:
Use the accused matrix (derived from interpreting the afr pending
xattrs) to decide whether we can start heal or not.
Change-Id: Ibbd56c9aed6026de6ec42422e60293702aaf55f9
BUG: 1408395
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/16277
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 0deef05afe297964f472b29949d62e28cc0df518
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Dec 14 07:03:28 2016 -0500
glusterd/geo-rep: Fix geo-rep config issue
Problem:
Geo-replication config commands fail when geo-rep
status is in 'Created'.
Cause:
During staging phase of geo-rep config, it checks
for the existence of 'monitor.pid' file. But the
pid file gets created only on start of geo-rep.
Hence it fails.
Fix:
Do not check for the existence of pid-file during
staging for config commands. It is not required.
Change-Id: I626d368b249cf0423c7f49b4284465508371f566
BUG: 1404678
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/16132
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 13e1ec888ea6e34156e58b6e7b629ef07837cce6
Author: Susant Palai <spalai@redhat.com>
Date: Tue Dec 13 14:26:53 2016 +0530
dht/rebalance: reverify lookup failures
race: readdirp has read one entry, and doing a lookup on
that entry, but user might have renamed/removed that entry just
after readdirp but before lookup.
Since remove-brick is a costly opertaion,will ingore any
ENOENT/ESTALE failures and move on.
Change-Id: I62c7fa93c0b9b7e764065ad1574b97acf51b5996
BUG: 1408115
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/15846
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 1c995bb7b53ee5bf04c00575a90198b0833d576d
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Dec 20 10:48:45 2016 -0500
common-ha: add node create new node dirs in shared storage
When adding a node to the ganesha HA cluster, create the directory
tree in shared storage for the added node and create sets of symlinks
to match what is/was created for the other nodes. I.e. in a four
node cluster the new node needs a set of links to the four existing
nodes:
/run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e1 -> e1
/run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e2 -> e2
/run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e3 -> e3
/run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e4 -> e4
and all the existing nodes need links added for the new node:
/run/gluster/shared/nfs-ganesha/$e1/nfs/{ganesha,statd}/$new -> new
/run/gluster/shared/nfs-ganesha/$e2/nfs/{ganesha,statd}/$new -> new
/run/gluster/shared/nfs-ganesha/$e3/nfs/{ganesha,statd}/$new -> new
/run/gluster/shared/nfs-ganesha/$e5/nfs/{ganesha,statd}/$new -> new
Likewise when deleting, remove the dir and symlinks.
original change http://review.gluster.org/16036
BUG: 1400613
Change-Id: I52839046745728d06ab5a07f38081c032093bff6
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/16216
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
commit 00cbd15dafeb756006d1fa796eb7de38df38048c
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Nov 24 14:58:20 2016 +0530
performance/readdir-ahead: limit cache size
This patch introduces a new option called "rda-cache-limit", which is
the maximum value the entire readdir-ahead cache can grow into. Since,
readdir-ahead holds a reference to inode through dentries, this patch
also accounts memory stored by various xlators in inode contexts.
Change-Id: I84cc0ca812f35e0f9041f8cc71effae53a9e7f99
BUG: 1356960
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/16137
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit cde407650ed3bdcc2a64629946ab0140402b2e5f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Dec 20 07:05:02 2016 +0530
afr: Ignore event_generation checks post inode refresh for write txns
Before http://review.gluster.org/#/c/15673/, after inode refresh, we
failed read txns in case of EIO or event_generation being zero. For
write transactions, the check was only for EIO. 15673 re-factored the
code to fail both read and write when event_generation=0. This seems to
have caused a regression as explained in the BZ.
This patch restores that behaviour in afr_txn_refresh_done().
Change-Id: Ib8e116506badce6f58b55827dbe403d95069d744
BUG: 1406224
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/16205
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit a02722cafbb3d32c3b3d63a557845027560e9df9
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Dec 20 18:22:02 2016 +0530
common-ha: Correct the VIP assigned to the new node added
There is a regression introduced with patch#16115. An incorrect
VIP gets assigned to the new node being added to the cluster.
This patch fixes the same.
Change-Id: I468c7d16bf7e4efa04692db83b1c5ee58fbb7d5f
BUG: 1406410
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/16213
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 35db0594d804cca1146b4773fb80e5bd023fac4f
Author: Sanoj Unnikrishnan <sunnikri@redhat.com>
Date: Sun Dec 18 17:29:47 2016 +0530
Fixes GlusterFS process crashes on deep directory hierarchy
alloca() calls to recusive function posix_make_ancestryfromgfid
consumes the entire stack leading to segfault.
Changed the function to iterative and reused the same linkname
buffer across iterations.
Change-Id: If065c8b9f7f85219bdd2d23259a115fe66f5f60d
BUG: 1405775
Signed-off-by: Sanoj Unnikrishnan <sunnikri@redhat.com>
Reviewed-on: http://review.gluster.org/16192
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 45c7997a274707c2456a824a2992e9a08ff71bf0
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Dec 20 16:09:10 2016 +0530
storage/posix: Do not create a directory which already exist
Problem: While brick process starts, it tries to create trashcan
and internal_op directory with fixed gfids. For the first time
these directories will not be present. However, stop and start
of volume again tries to create these directories, which are
already present.
This throws a gfid exist warning and EEXIST error in logs.
Solution: Check if the directory exist on brick and gfid of
this dir and the requested gfid matches or not.
Change-Id: Ie4966a550ed44046e0f2d10e9dbd540182ea97d2
BUG: 1406348
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/16212
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 11a643e509f6ceca16f00f882b6a4069bd6d715d
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Dec 13 15:28:42 2016 +0530
socket: socket disconnect should wait for poller thread exit
When SSL is enabled or if "transport.socket.own-thread" option is set
then socket_poller is run as different thread. Currently during
disconnect or PARENT_DOWN scenario we don't wait for this thread
to terminate. PARENT_DOWN will disconnect the socket layer and
cleanup resources used by socket_poller.
Therefore before disconnect we should wait for poller thread to exit.
Change-Id: I71f984b47d260ffd979102f180a99a0bed29f0d6
BUG: 1404181
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/16141
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2d185184faa233afafcd0f99735db49ec1bf1f19
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Dec 20 10:42:31 2016 +0530
ganesha/scripts : Prevent removal of entries in ganesha.conf during deletion of a node
Change-Id: Ia6c653eeb9bef7ff4107757f845218c2316db2e4
BUG: 1406249
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/16209
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
commit ca4f65cfc160e0d1efe0419d6c4896bff48a4162
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Dec 19 12:22:29 2016 +0530
tests: Fix spurious failure in tests/bugs/replicate/bug-1402730.t
Replace the EXPECT '00000001' with EXPECT_NOT '00000000'. This is
because occasionally a name-heal is performing new-entry marking on
'c' causing the pending entry changelog on it to become '00000002'.
Change-Id: I30916e6266534d18899cfa5771c892db8c51ad9a
BUG: 1405902
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16193
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a9737c13dd1e44b1c2808a7e25a53c58e5b56f1b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Dec 20 11:51:07 2016 +0530
client,server: Free xdr-allocated compound req/rsp arrays
Change-Id: I9e1829f4f73f001bba33005032e030f289e8d003
BUG: 1406252
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16210
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f4dd04f882924b23745df73d364c4931fb3a8b20
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Dec 16 21:41:58 2016 +0530
tests: Fix spurious failure in bug-1402841.t-mt-dir-scan-race.t
Check that shd is up before executing 'volume heal' command
Change-Id: Ib510a5de06d732fd3a738e90fa16376698479897
BUG: 1405554
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16169
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 2e395675d80f20a9cfa77489b99eecfe6e81681d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Dec 16 12:37:41 2016 +0530
tests: Move tests/basic/gfapi/bug1291259.t to bad tests list
See thread
http://www.gluster.org/pipermail/gluster-devel/2016-December/051714.html
for more information.
Change-Id: I9abe4b0e40499e53c1276a10a6bc192fd0f2cef7
BUG: 1405301
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16159
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit fbabed8f672a0e785419e022d405adeed41ca4a3
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Dec 13 11:55:19 2016 +0530
snapshot: Fix restore rollback to reassign snap volume ids to bricks
Added further checks to ensure we do not go beyond prevalidate
when trying to restore a snapshot which has a nfs-gansha conf
file, in a cluster when nfs-ganesha is not enabled
The error message for the particular scenario is:
"Snapshot(<snapname>) has a nfs-ganesha export conf
file. cluster.enable-shared-storage and nfs-ganesha
should be enabled before restoring this snapshot."
Change-Id: I1b87e9907e0a5e162f26ef1ca89fe76e8da8610f
BUG: 1404118
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/16116
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit e8f29b5d4ff4c1cb968e1f807c864965551a3801
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Tue Mar 15 19:18:35 2016 -0700
socket: Keepalives should happen on IPv6 as well as IPv4
Summary:
- Check for AF_INET *and* AF_INET6.
- This is a cherry-pick of D3057373 to 3.8
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Change-Id: I53eb79284eddfee6e13821c6570809f575b96769
BUG: 1405478
Reviewed-on: http://review.gluster.org/16167
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6aa343beca3f2c7c5d8cf11793bef9a4cd388c4e
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Thu Dec 15 20:51:30 2016 +0530
tests: Fix spurious test failure in bug-1316437.t
After sending SIGTERM to gluster process we immediately
check if process exited. We should wait for some time
before checking process state.
BUG: 1404573
Change-Id: Iaba0067f6e880a7fe38e11b9fa0fe9bd103b19e2
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/16162
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1b23d53d335fb662feb026311512ec8ba37f12e9
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Dec 6 02:00:11 2016 -0500
common-ha: add node create new node dirs in shared storage
When adding a node to the ganesha HA cluster, create the directory
tree in shared storage for the added node and create sets of symlinks
to match what is/was created for the other nodes. I.e. in a four
node cluster the new node needs a set of links to the four existing
nodes:
/run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e1 -> e1
/run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e2 -> e2
/run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e3 -> e3
/run/gluster/shared/nfs-ganesha/$new/nfs/{ganesha,statd}/$e4 -> e4
and all the existing nodes need links added for the new node:
/run/gluster/shared/nfs-ganesha/$e1/nfs/{ganesha,statd}/$new -> new
/run/gluster/shared/nfs-ganesha/$e2/nfs/{ganesha,statd}/$new -> new
/run/gluster/shared/nfs-ganesha/$e3/nfs/{ganesha,statd}/$new -> new
/run/gluster/shared/nfs-ganesha/$e5/nfs/{ganesha,statd}/$new -> new
Likewise when deleting, remove the dir and symlinks.
Change-Id: Id2f78f70946f29c3503e1e6db141b66cb431e0ea
BUG: 1400613
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/16036
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 160d55106ff08b614d54f58accde23c1a4d95514
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Dec 16 09:31:41 2016 +0530
protocol/client: Fix potential mem-leaks
Commit 93eaeb9c93be3232f24e840044d560f9f0e66f71 introduces
leaks in INODELK callback where a dict is unserialized twice,
leading to dict leaks.
Change-Id: I219ccb2279f237ebc2e4fc366af4775a461929b8
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16156
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 8b976d01ba4a8fb3aa4889bc10df1006f91cbc11
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Dec 16 09:53:19 2016 +0530
Revert "doc: fix gluster man page"
This reverts commit c6fdc2f819b265e018d858232293407835fe2c6c.
Initially I thought gluster --xml taking into the shell prompt is not a
correct behavior, however if we execute any commands from that prompt we
get xml output which is the original intention. This patch reverts the
change and put back --xml option for gluster in man page.
Change-Id: If77d0c0bf27f8cfc799973003c860d9bd8cd6407
BUG: 1360670
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/16157
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: MOHIT AGRAWAL <moagrawa@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit ddf51c62c5033726a6a9b6f406a983f09359aa1a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Dec 15 21:27:21 2016 +0530
doc: fix gluster man page
gluster --xml will take into the interactive prompt which is not an
intended message here.
Change-Id: Iea5b094a1b1b429d211008a3c7459b703c1a0a12
BUG: 1360670
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/16142
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ad5e039eeb6d380d730b7693b702faf963733e98
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Dec 14 22:48:20 2016 +0530
glfsheal: Explicitly enable self-heal xlator options
Enable data, metadata and entry self-heal as xlator-options so that glfs-heal.c
can heal split-brain files even if they are disabled on the volume via volume
set commands.
Change-Id: Ic191a1017131db1ded94d97c932079d7bfd79457
BUG: 1234054
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/11333
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 809c3e17c14645452d7a586f62218a4b50bd32ea
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Dec 13 13:40:52 2016 -0500
common-ha: explicitly set udpu transport for corosync
On RHEL7 corosync uses udpu (udp unicast) by default. On RHEL6 the
default is (now) udp multi-cast. In network environments that don't
support udp multi-cast this causes the ever growing lists of
[TOTEM ] Retruansmit errors.
Always specifying --transport udpu is thus a no-op on RHEL7.
Using the same transport on both RHEL6 and RHEL7 may (or may not
give similar behavior and performance--it's hard to say.
It remains a mystery why things have always worked on RHEL6 prior to
now. Further investigation is required to uncover why this is the
case.
Change-Id: I4d0de97fe4425c47f249beaaf51aeca3e91731fa
BUG: 1404410
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/16122
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
commit bdb30414a13cb75a92330087ada767fcab46a77e
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Nov 30 12:54:05 2016 -0500
cli: Suppress unused but set warnings
GCC has the following complaint during compilation:
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli_get_volume_cbk’:
../../../cli/src/cli-rpc-ops.c:846:36: warning: variable ‘caps’ set but not used
[-Wunused-but-set-variable]
char *caps = NULL;
Change-Id: Ia378a6c83ba70ae35290802b7b38ad2830c0956c
BUG: 1402261
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/15982
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 76513383cedbf21418e06d2ca6379978d016d81f
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Nov 17 18:22:39 2016 +0530
access_control : address O_TRUNC and O_APPEND flag properly in posix_acl_open
In posix_acl_open, in switch value passed is (flag & O_ACCMODE). The value for
O_ACCMODE is 0003, so the result will always be less than or equal to 3.
But value for O_TRUNC is 01000 and O_APPEND is 02000, so it is not right to
check it in switch case
Change-Id: Ia17db80a6a5f681c35e08e062d384f33ef7e0354
BUG: 1387241
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/15688
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 6e9d7384e976c08a5b5b785ee5807288ec59dfc4
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Dec 12 13:06:15 2016 +0530
geo-rep: Fix log-rsync-performance config issue
If log-rsync-performance config is not set, gconf.get_realtime
will return None, Added default value as False if config file
doesn't have this option set.
BUG: 1393678
Change-Id: I89016ab480a16179db59913d635d8553beb7e14f
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/16102
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f34433517b988caf97f099175275661864c69833
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Dec 6 12:11:35 2016 +0530
geo-rep: Use Host UUID to find local Gluster node
To spawn workers for each local brick, Geo-rep was collecting all
the machine IPs based on hostname and finds based on the connectivity.
With this patch, Geo-rep finds local brick if host UUID matches with
UUID of the brick from Volume info.
BUG: 1401801
Change-Id: Ic83c65df89e43cb86346e3ede227aa84d17ffd79
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/16035
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 0a55e89a430c9d2c00907afe73037ac2a25dd249
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Dec 8 14:53:04 2016 +0530
cluster/ec: Fix lk-owner set race in ec_unlock
Problem:
Rename does two locks. There is a case where when it tries to unlock it sends
xattrop of the directory with new version, callback of these two xattrops can
be picked up by two separate epoll threads. Both of them will try to set the
lk-owner for unlock in parallel on the same frame so one of these unlocks will
fail because the lk-owner doesn't match.
Fix:
Specify the lk-owner which will be set on inodelk frame which will not be over
written by any other thread/operation.
BUG: 1402710
Change-Id: I666ffc931440dc5253d72df666efe0ef1d73f99a
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/16074
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ecdb939372e306c46aa78c8bf4a601b88d1edd8c
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Dec 13 14:38:18 2016 +0530
upcall: Fix 'use after free' in a log message
There is chance of accessing freed pointer in a log message at TRACE
level while cleaning up expired client entries.
Change-Id: I06b4dad755df63978ab04ca52442bfd4600d139a
BUG: 1404168
Reported-by: Ravishankar N <ravishankar@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/16117
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit f7674308123fbdea064a1c9ec60c9227fbd11b4b
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Dec 12 16:41:23 2016 +0530
glusterd: Handle volinfo->refcnt properly during volume start command
While running the volume start command, the refcnt of the volume is
incremented. At the end of the command, the refcnt should also be
decremented. This is currently not the case.
This patch, makes sure the refcnt is also decremented at the end of the
volume start command.
Change-Id: I017b5039be5948df41dde6bc89d2955d5d18971f
BUG: 1403780
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/16108
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 335ddb3c5d5ed27bd789b2d1c9d24e6c6e5a389d
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Dec 9 12:18:28 2016 +0530
common-ha: Create portblock RA as part of add/delete-node
When a node is added to or deleted from existing nfs-ganesha cluster,
we need to create or cleanup portblock RA as well. This patch is
to address the same. Also we need to adjust the quorum-policy with
increase/decrease in the number of nodes in the cluster.
Change-Id: I31a896715b9b7fc931009723d1570bf7aa4da9b6
BUG: 1403130
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/16089
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 1bd441761da9d8b1fac5cb15c0071cfd61252e85
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Dec 8 22:49:48 2016 +0530
cluster/afr: Fix per-txn optimistic changelog initialisation
Incorrect initialisation of local->optimistic_change_log was leading
to skipped pre-op and post-op even when a brick didn't participate in
the txn because it was down.
The result - missing granular name index resulting in some entries
never getting healed.
FIX:
Initialise local->optimistic_change_log just before pre-op.
Also fixed granular entry heal to create the granular name index in
pre-op as opposed to post-op. This is to prevent loss of granular
information when during an entry txn, the good (src) brick goes
offline before the post-op is done. This would cause self-heal to
do conservative merge (since dirty xattr is the only information
available), which when granular-entry-heal is enabled, expects
granular indices, the lack of which can lead to loss of data in
the worst case.
Change-Id: Ia3ad716d6fb1821555f02180e86e8711a79f958d
BUG: 1402730
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16075
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 90448c1bdc267679f66c478028987bcfc99dacd0
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Oct 31 10:49:09 2016 +0530
performance/write-behind: Add more fops for checking dependency with cached writes
Fops like readdirp, link, fallocate, discard, zerofill return iatt of
files in their responses. This iatt can be cached by md-cache. Hence
it is important that write-behind maintains relative ordering of these
fops with cached writes. Failure to do so, can result in md-cache
storing stale iatts and returning the same to applications.
Change-Id: Icfe12ad807e42fe9e52a9f63e47ce63f511c6946
BUG: 1390050
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/15757
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 836d868da7f0dad618628cf6084e008cb8058473
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Dec 9 15:01:40 2016 +0530
snapshot/ganesha: Copy export.conf, only if ganesha.enable is on.
Status of the volume being exported via nfs ganesha, should be
checked by checking if ganesha.enable is set or not, rather than
deciding based on the errno of the stat
Change-Id: Iaff786d9f77a2de1322ce8ccb4b80954f84d3373
BUG: 1402828
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/16094
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 0094a382e5039103dfb696d18bac8607e3515992
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Oct 26 08:56:51 2016 -0400
build: python site-packages vs. dist-packages
Unlike Fedora and RHEL/CentOS, where python has
/usr/{lib,lib64}/python2.7/site-packages/..., Debian-based
distributions have /usr/lib/python2.7/dist-packages/...
On Debian our python scriptlet to determine this is broken and
incorrectly returns .../site-packages, not .../dist-packages.
Furthermore, the automake/autoconf/pkgconfig bits ahead of our
own scriptlet have already determined the correct location -- all
we need to do is use it.
This change also slightly reworks the BUILD_PYTHON_INC scriptlet
to bring it in line with the style/pattern of the other python
scriptlets provided by autoconf/pkgconfig.
(I do wonder though, why we have two sets of {C,CPP}FLAGS and
LD_FLAGS - PYTHONDEV_CPPFLAGS and BUILD_PYTHON_INC, and
PYTHONDEV_LDFLAGS and BUILD_PYTHON_LIB.
They both have very similar values, but, e.g. BUILD_PYTHON_INC
misses /usr/lib/x86_64-linux-gnu/python2.7 on Debian; even if that
ommission doesn't seem to be hurting us.)
Change-Id: I309a5c781a1d9aee4d7be2867223781bd2ae18fa
BUG: 1388861
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15733
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 1100b613054039ce168fc02e3ba0ab73360dcdfd
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Tue Dec 6 14:05:35 2016 +0530
doc: update to readthedocs.io documentation
Update old links to point to appropriate readthedocs.io
documentation.
BUG: 1401836
Change-Id: Ib59848feee7e73512230deb0554471df655b8417
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/16038
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 93c292500dacf6c7611ba37b14650516ef0857ce
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Nov 29 16:51:58 2016 +0100
refcount: return pointer to the structure instead of a counter
There are no real users of the counter. It was thought of a handy tool
to track and debug refcounting, but it is not used at all. Some parts of
the code would benefit from a pointer getting returned instead.
BUG: 1399780
Change-Id: I97e52c48420fed61be942ea27ff4849b803eed12
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15971
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit c923988397884087c5fe7b0980fff39eb1fdd6c1
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Dec 9 09:50:43 2016 +0530
syncop: fix conditional wait bug in parallel dir scan
Problem:
The issue as seen by the user is detailed in the BZ but what is
happening is if the no. of items in the wait queue == max-qlen,
syncop_mt_dir_scan() does a pthread_cond_wait until the launched
synctask workers dequeue the queue. But if for some reason the worker
fails, the queue is never emptied due to which further invocations of
syncop_mt_dir_scan() are blocked forever.
Fix: Made some changes to _dir_scan_job_fn
- If a worker encounters error while processing an entry, notify the
readdir loop in syncop_mt_dir_scan() of the error but continue to process
other entries in the queue, decrementing the qlen as and when we dequeue
elements, and ending only when the queue is empty.
- If the readdir loop in syncop_mt_dir_scan() gets an error form the
worker, stop the readdir+queueing of further entries.
Change-Id: I39ce073e01a68c7ff18a0e9227389245a6f75b88
BUG: 1402841
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/16073
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 818c6f936673dd067220c303695c9301fbee4572
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Nov 8 12:09:57 2016 +0530
cluster/dht: Fix memory corruption while accessing regex stored in private
If reconfigure is executed parallely (or concurrently with dht_init),
there are races that can corrupt memory. One such race is modification
of regexes stored in conf (conf->rsync_regex_valid and
conf->extra_regex_valid) through dht_init_regex. With change [1],
reconfigure codepath can get executed parallely (with itself or with
dht_init) and this fix is needed.
Also, a reconfigure can race with any thread doing dht_layout_search,
resulting in dht_layout_search accessing regex freed up by reconfigure
(like in bz 1399134).
[1] http://review.gluster.org/15046
Change-Id: I039422a65374cf0ccbe0073441f0e8c442ebf830
BUG: 1399134
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/15945
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 3023b9abe64db10c22a4d2bd863f9bf86d29d429
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Dec 6 13:38:21 2016 +0530
ganesha/scripts : find export id for already exported volume in S31ganesha-start.sh
Change-Id: Iada90ed215966d3f526fa20aa5359b67f25a6944
BUG: 1401822
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/16037
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 90b1f9d73c3017094fd5d53a7a4ff74ed1e65af5
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Oct 18 16:58:36 2016 +0530
eventsapi: Log all published events and provide option to disable logging
Log every published event in /var/log/glusterfs/events.log, Disable logging
using,
gluster-eventsapi config-set disable-events-log true
Also changed "log_level" config name to "log-level"
Change-Id: Ib354be0c4ca999d1ccd01b810d6cd96ebc72bcd4
BUG: 1386200
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15674
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1c34d6e967328e4aa4b12a81e6ac74f5e5b6efc1
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Dec 7 07:36:19 2016 -0500
glusterd/geo-rep: Fix glusterd crash
Problem:
glusterd crashes when geo-rep mountbroker setup is
created if the slave user length is more than
8 characters.
Cause:
_POSIX_LOGIN_NAME_MAX is used which is 9 including
NULL byte.
Analysis:
While the man page says it sufficient for portability, but
acutally it's not. Linux allows the creation of username
upto 32 characters by default where the max length is 256.
And NetBSD's max is 17.
Linux:
#getconf LOGIN_NAME_MAX
256
NetBSD:
#getconf LOGIN_NAME_MAX
17
Fix:
Use LOGIN_NAME_MAX instead of _POSIX_LOGIN_NAME_MAX
Change-Id: I26b7230433ecbbed6e6914ed39221a478c0266a8
BUG: 1368138
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/16053
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a64d9721610ca1207c87f290fd5627bcb0306719
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Dec 6 16:21:41 2016 +0530
glusterfsd : fix null pointer dereference in glusterfs_handle_barrier
Change-Id: Iab86a3c4970e54c22d3170e68708e0ea432a8ea4
BUG: 1401921
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/16043
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5bf1ba5bc598ce38e141cf410a4613c1fa91da4e
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Dec 7 17:27:02 2016 +0530
tools/glusterfind: avoid deleting keys directory
Problem:
gluster volume delete mistakenly deletes the .keys directory under
/var/lib/glusterd/glusterfind.
Solution:
Check for ".keys" directory and avoid deleting it.
Change-Id: Ia595c8bf3f423c1ad5d6faa183a29598c07a11f9
BUG: 1402369
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/16052
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 22c16a75f653fa476220bd8b0ed6ec52477ca15f
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Nov 10 12:35:30 2016 +0530
geo-rep: Do not restart workers when log-rsync-performance config change
Geo-rep restarts workers when any of the configurations changed. We
don't need to restart workers if tunables like log-rsync-performance
is modified.
With this patch, Geo-rep workers will get new "log-rsync-performance"
config automatically without restart.
BUG: 1393678
Change-Id: I40ec253892ea7e70c727fa5d3c540a11e891897b
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15816
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit f5b1ae89c7ddce98e49a74374b44f691ce2ce078
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Dec 5 13:20:51 2016 +0530
cluster/afr: Remove backward compatibility for locks with v1
When we have cascading locks with same lk-owner there is a possibility for
a deadlock to happen. One example is as follows:
self-heal takes a lock in data-domain for big name with 256 chars of "aaaa...a"
and starts heal in a 3-way replication when brick-0 is offline and healing from
brick-1 to brick-2 is in progress. So this lock is active on brick-1 and
brick-2. Now brick-0 comes online and an operation wants to take full lock and
the lock is granted at brick-0 and it is waiting for lock on brick-1. As part
of entry healing it takes full locks on all the available bricks and then
proceeds with healing the entry. Now this lock will start waiting on brick-0
because some other operation already has a granted lock on it. This leads to a
deadlock. Operation is waiting for unlock on "aaaa..." by heal where as heal is
waiting for the operation to unlock on brick-0. Initially I thought this is
happening because healing is trying to take a lock on all the available bricks
instead of just the bricks that are participating in heal. But later realized
that same kind of deadlock can happen if a brick goes down after the heal
starts but comes back before it completes. So the essential problem is the
cascading locks with same lk-owner which were added for backward compatibility
with afr-v1 which can be safely removed now that versions with afr-v1 are
already EOL. This patch removes the compatibility with v1 which requires
cascading locks with same lk-owner.
In the next version we can make locking-scheme option a dummy and switch
completely to v2.
BUG: 1401404
Change-Id: Ic9afab8260f5ff4dff5329eb0429811bcb879079
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/16024
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0059b02400b6f8465796575ca8dcd67b90d94314
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Dec 1 09:42:19 2016 +0530
cluster/afr: Serialize conflicting locks on all subvols
Problem:
1) When a blocking lock is issued and the parallel lock phase fails
on all subvolumes with EAGAIN, it is not switching to serialized
locking phase.
2) When quorum is enabled and locks fail partially it is better
to give errno returned by brick rather than the default
quorum errno.
Fix:
Handled this error case and changed op_errno to reflect the actual
errno in case of quorum error.
BUG: 1369077
Change-Id: Ifac2e4a13686e9fde601873012700966d56a7f31
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15984
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit cdf76da1ea61f61a622afe6f04db4217f0977bd3
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Dec 1 15:05:06 2016 +0530
build: Use %{_datadir} rpm macro in spec file
Change-Id: I18383b2a5f0ff5233d47715c2e91514b6c3f2b7c
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/15985
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 45e7b92ae270f19a6eca558bd8a6aab9bdc72db1
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Nov 23 16:04:26 2016 +0530
glusterd/ganesha : handle volume reset properly for ganesha options
The "gluster volume reset" should first unexport the volume and then delete
export configuration file. Also reset option is not applicable for ganesha.enable
if volume value is "all".
This patch also changes the name of create_export_config into manange_export_config
Change-Id: Ie81a49e7d3e39a88bca9fbae5002bfda5cab34af
BUG: 1397795
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/15914
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 15f99c7b69311585b207f4ff66f4f76bff3f279b
Author: Muthu-vigneshwaran <mvignesh@redhat.com>
Date: Thu Dec 1 15:59:26 2016 +0530
glusterd : coverity fix for string overflow
CID : 1357872, 1357873, 1351695
BUG: 789278
Change-Id: I2ee01a6054326f35de621ee7a1f2afd09c5738fe
Signed-off-by: Muthu-vigneshwaran <mvignesh@redhat.com>
Reviewed-on: http://review.gluster.org/15989
Tested-by: Muthu Vigneshwaran
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <manikandancs333@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit addea9819576a00008c325ed0b56b0afecda0ff2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Dec 5 21:14:57 2016 +0530
afr: fix bug in passing child index in afr_inode_write_fill
Change-Id: I7b70de317a5f15a3bf483ffe40b971143deddc11
BUG: 1401218
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/16029
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d32ce46ee045682ebf0131a6e8fbb7505fc63867
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Sat Dec 3 01:10:51 2016 +0530
rpc: fix for race between rpc and protocol/client
It is possible that the notification thread which notifies
protocol/client layer about the disconnection is put to sleep
and meanwhile, a fuse thread or a timer thread initiates and
completes reconnection to the brick. The notification thread
is then woken up and protocol/client layer updates its flags
to indicate that network is disconnected. No reconnection is
initiated because reconnection is rpc-lib layer's responsibility
and its flags indicate that connection is connected.
Fix: Serialize connect and disconnect notify
Credit: Raghavendra Talur <rtalur@redhat.com>
Change-Id: I8ff5d1a3283b47f5c26848a42016a40bc34ffc1d
BUG: 1386626
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/15916
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ded5136537b05cd7165b438cbe06b891d2eec09d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Dec 1 17:28:40 2016 +0530
extras: Include shard and full-data-heal in virt group
Change-Id: Iea66cb017bd1ab62da9cd65895fa65fc6896108b
BUG: 1375431
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15995
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e20ce0f8d21827be92acb993e6d731a2b6c786de
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Sat Dec 3 09:09:15 2016 +0530
afr, client: More mem-leak fixes in COMPOUND fop cbk
Bugs found and fixed:
1. Use correct subvolume index in pre-op-writev compound cbk
2. Prevent use-after-free of local->compound_args members in
compound fops cbk in protocol/client
3. Fix xdata and xattr leaks in client_process_response
4. Fix possible leak of xdata in client_pre_writev() in
test mode.
5. Free req->compound_req_array.compound_req_array_val as well
after freeing its members
6. Free tmp_rsp->flock.lk_owner.lk_owner_val in LK fop.
Change-Id: I15b646d7d4e0e5cd4ea3d2d6452c815cf2eaf68f
BUG: 1401218
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16020
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit a62ed55397e59231f9a66dbacdf66290bcd12566
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Dec 2 13:15:20 2016 +0530
cluster/ec: Check xdata to avoid memory leak
Problem: ec_writev_start calls ec_make_internal_fop_xdata
to set "yes" in xdata before ec_readv (an internal fop)
is called for head and tail. Second call to this function
is overwriting the previous allocated dict_t to "xdata",
which results in memory leak.
Solution: In ec_make_internal_fop_xdata, check if *xdata
is NULL or not to avoid overwriting *xdata.
Change-Id: I49b83923e11aff9b92d002e86424c0c2e1f5f74f
BUG: 1400818
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/16007
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f1aac03ed5d8867e62626395964e5b9ee5863463
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Nov 29 16:32:54 2016 +0530
eventsapi: Push Messages to Webhooks in parallel
With this patch, glustereventsd will maintain one thread per
webhook. If a webhook is slow, then all the events to that worker
will be delayed but it will not affect the other webhooks.
Note: Webhook in transit may get missed if glustereventsd reloads due to
new Webhook addition or due configuration changes.
BUG: 1357754
Change-Id: I2d11e01c7ac434355bc356ff75396252f51b339b
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15966
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit a81111c8ebdbacbf9bd459cfdd9ac807cc3c9d3b
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Nov 8 10:32:29 2016 +0530
dht/md-cache: Filter invalidate if the file is made a linkto file
Upcall as a part of setattr, sends an invalidation and the
invalidation carries the resulting stat value. When a file
is converted to linkto files, even then an invalidation
is set and as a result the mountpoint shows the sticky
bit in the stat of the file.
eg: ---------T. 945 root root 0 Nov 8 10:14 hardlink.999
Fix:
When dht recieves a notification of sticky bit change, it updates
the flag, to indicate md-cache to send the subsequent lookup.
Change-Id: Ic2fd7a5b196db0754f9b97072e644e6bf69da606
BUG: 1392713
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15789
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 72225ec7c0e93e0ec30c235c61decc7dc708e1d5
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Nov 16 16:50:50 2016 +0530
geo-rep/eventsapi: Add Master node information in Geo-rep Events
Added Master node information to GEOREP_ACTIVE, GEOREP_PASSIVE, GEOREP_FAULTY
and GEOREP_CHECKPOINT_COMPLETED events.
EVENT_GEOREP_ACTIVE(master_node and master_node_id are new fields)
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": "GEOREP_ACTIVE",
"message": {
"master_volume": MASTER_VOLUME_NAME,
"master_node": MASTER_NODE,
"master_node_id": MASTER_NODE_ID,
"slave_host": SLAVE_HOST,
"slave_volume": SLAVE_VOLUME,
"brick_path": BRICK_PATH
}
}
EVENT_GEOREP_PASSIVE(master_node and master_node_id are new fields)
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": "GEOREP_PASSIVE",
"message": {
"master_volume": MASTER_VOLUME_NAME,
"master_node": MASTER_NODE,
"master_node_id": MASTER_NODE_ID,
"slave_host": SLAVE_HOST,
"slave_volume": SLAVE_VOLUME,
"brick_path": BRICK_PATH
}
}
EVENT_GEOREP_FAULTY(master_node and master_node_id are new fields)
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": "GEOREP_FAULTY",
"message": {
"master_volume": MASTER_VOLUME_NAME,
"master_node": MASTER_NODE,
"master_node_id": MASTER_NODE_ID,
"current_slave_host": CURRENT_SLAVE_HOST,
"slave_host": SLAVE_HOST,
"slave_volume": SLAVE_VOLUME,
"brick_path": BRICK_PATH
}
}
EVENT_GEOREP_CHECKPOINT_COMPLETED(master_node and master_node_id are new fields)
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": "GEOREP_CHECKPOINT_COMPLETED",
"message": {
"master_volume": MASTER_VOLUME_NAME,
"master_node": MASTER_NODE,
"master_node_id": MASTER_NODE_ID,
"slave_host": SLAVE_HOST,
"slave_volume": SLAVE_VOLUME,
"brick_path": BRICK_PATH,
"checkpoint_time": CHECKPOINT_TIME,
"checkpoint_completion_time": CHECKPOINT_COMPLETION_TIME
}
}
BUG: 1395660
Change-Id: Ic91af52fa248c8e982e93a06be861dfd69689f34
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15858
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit f7c8655463e6a65e9fbe79a25b285767d008da3b
Author: Mateusz Slupny <mateusz.slupny@appeartv.com>
Date: Tue Nov 29 12:01:48 2016 +0100
selfheal: fix memory leak on client side healing queue
Change-Id: I2beaba829710565a3246f7449a5cd21755cf5f7d
BUG: 1399592
Signed-off-by: Mateusz Slupny <mateusz.slupny@appeartv.com>
Reviewed-on: http://review.gluster.org/15968
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 138807a678766e80b8d4d438bac9be2b50889bb6
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Nov 17 15:42:24 2016 +0530
eventsapi: JSON output and different error codes
JSON outputs are added to all commands, use `--json` to
get JSON output.
Following error codes are added to differenciate between errors.
Any other Unknown errors will have return code 1
ERROR_SAME_CONFIG = 2
ERROR_ALL_NODES_STATUS_NOT_OK = 3
ERROR_PARTIAL_SUCCESS = 4
ERROR_WEBHOOK_ALREADY_EXISTS = 5
ERROR_WEBHOOK_NOT_EXISTS = 6
ERROR_INVALID_CONFIG = 7
ERROR_WEBHOOK_SYNC_FAILED = 8
ERROR_CONFIG_SYNC_FAILED = 9
Also hidden `node-` commands in the help message.
BUG: 1357753
Change-Id: I962b5435c8a448b4573059da0eae42f3f93cc97e
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15867
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 5c9e0ab12c3c4cbb4e5f9de3ff2675bde1292bc7
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Nov 22 01:51:19 2016 +0530
glusterfsd: glusterfs_ctx_defaults_init should not re-initialize ctx->locks
glusterfs_ctx_new already initialize ctx->locks therefore the second
initialization in glusterfs_ctx_defaults_init does not make sense.
Change-Id: I6027cbd311da8e80585e0f0dcd6916e3bc8dd284
BUG: 1397419
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/15905
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 10278eec4768f283db845a19c571ddaa4d591446
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Dec 1 18:18:27 2016 +0530
cluster/tier: fix op-version for tier-query-limit
Correct the op-version for tier-query-limit option from 3.9.0 to 3.9.1
Change-Id: I3a52a94c2708a97c18377e945d559a51d8025c41
BUG: 1366648
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/15990
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bc41e94767a9ad4ff6c1abdfd30403084553aaa1
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Nov 28 19:18:51 2016 +0530
ganesha/scripts : avoid incrementing Export Id value for already exported volumes
Currently a volume will unexport when it stops and reexport it during volume start
using hook script. And also it increments the value for export id for each reexport.
Since a hook script is called from every node parallely which may led inconsistency
for export id value.
Change-Id: Ib9f19a3172b2ade29a3b4edc908b3267c68c0b20
BUG: 1399186
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/15948
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit cb36c79ab089f0990df84171d8003ceb82e992a1
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Nov 21 18:08:14 2016 +0530
dht/rename : Incase of failure remove linkto file properly
Generally linkto file is created using root user. Consider following
case, a user is trying to rename a file which he is not permitted.
So the rename fails with EACESS and when rename tries to cleanup the
linkto file, it fails.
The above issue happens when rename/00.t test executed on nfs-ganesha
clients :
Steps executed in script
* create a file "abc" using root
* rename the file "abc" to "xyz" using a non root user, it fails with EACESS
* delete "abc"
* create directory "abc" using root
* again try ot rename "abc" to "xyz" using non root user, test hungs here
which slowly leds to OOM kill of ganesha process
RCA put forwarded by Du for OOM kill of ganesha
Note that when we hit this bug, we've a scenario of a dentry being
present as:
* a linkto file on one subvol
* a directory on rest of subvols
When a lookup happens on the dentry in such a scenario, the control flow
goes into an infinite loop of:
dht_lookup_everywhere
dht_lookup_everywhere_cbk
dht_lookup_unlink_cbk
dht_lookup_everywhere_done
dht_lookup_directory (as local->dir_count > 0)
dht_lookup_dir_cbk (sets to local->need_selfheal = 1 as the entry is a linkto file on one of the subvol)
dht_lookup_everywhere (as need_selfheal = 1).
This infinite loop can cause increased consumption of memory due to:
1) dht_lookup_directory assigns a new layout to local->layout unconditionally
2) Most of the functions in this loop do a stack_wind of various fops.
This results in growing of call stack (note that call-stack is destroyed only after lookup response is
received by fuse - which never happens in this case)
Thanks Du for root causing the oom kill and Sushant for suggesting the fix
Change-Id: I1e16bc14aa685542afbd21188426ecb61fd2689d
BUG: 1397052
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/15894
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 9d5109f5ddf428d0b4ec0f9491e412f06753d159
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Nov 30 13:00:16 2016 -0500
common-ha: IPaddr RA is not stopped when pacemaker quorum is list
Ken Gaillot writes:
The other is pacemaker's no-quorum-policy cluster property. The
default (which has not changed) is "stop" (stop all resources).
Other values are "ignore" (act as if quorum was not lost),
"freeze" (continue running existing resources but don't recover
resources from unseen nodes) or "suicide" (shut down).
But on my four node cluster
% pcs property show no-quorum-policy
Cluster Properties:
%
i.e. shows nothing.
But:
% pcs property list --all
Cluster Properties:
...
no-quorum-policy: stop
...
%
Seems to think it knows about it.
and then
% pcs property set no-quorum-policy=stop
% pcs property show no-quorum-policy
Cluster Properties:
no-quorum-policy: stop
%
Which looks rather inconsistent. So we will try explicitly
setting it to "stop" when there are three or more nodes.
Change-Id: I47fc7ee84fcd6ad52ccb776913511978a8d517b4
BUG: 1400237
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15981
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 4f8fe3fb06c44da7750368fa0ef5c26e74cd0557
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Nov 30 19:38:03 2016 +0530
build: add systemd dependency to the glusterfs sub-package
Problem:
/bin/systemctl is not available at install time of primary glusterfs
package.
Solution:
Add %{?systemd_requires} to the glusterfs sub-package install time
requirements.
Replace all "Requires: systemd" and "Requires: systemd-units" with
%{?systemd_requires}. %systemd_requires is defined in
/usr/lib/rpm/macros.d/macros.systemd
systemd-units is provided by systemd.
Add BuildRequires: systemd for the definition of %systemd_requires
as well.
Change-Id: I980ece7d538ea177ca6b0e70c1c169e6f04c46d4
BUG: 1399031
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/15936
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit c877b6785a88591c438b0a75cf612f96c7f959a1
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Wed Nov 30 14:35:59 2016 +0530
glusterd, cli: Fix volume options output format in get-state cli
Currently the get-state cli outputs the volume options in the
following format:
Volume1.rebalance.skipped: 0
Volume1.rebalance.lookedup: 0
Volume1.rebalance.files: 0
Volume1.rebalance.data: 0Bytes
[Volume1.options]
features.barrier: on
transport.address-family: inet
performance.readdir-ahead: on
nfs.disable: on
Volume2.name: tv2
Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9
Volume2.type: Distribute
This above format is a valid ini file format syntactically, but is
not very easily parseable. This patch changes the format to look like
the following and should be more easily parseable:
Volume1.rebalance.skipped: 0
Volume1.rebalance.lookedup: 0
Volume1.rebalance.files: 0
Volume1.rebalance.data: 0Bytes
Volume1.options.features.barrier: on
Volume1.options.transport.address-family: inet
Volume1.options.performance.readdir-ahead: on
Volume1.options.nfs.disable: on
Volume2.name: tv2
Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9
Volume2.type: Distribute
Change-Id: I9768b45de288d9817ec669d3a801874eb1914750
BUG: 1399995
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: http://review.gluster.org/15975
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shubhendu Tripathi <shtripat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 136a4d5656e60ba96d825297376e9d2c79cd9101
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Nov 18 13:07:50 2016 -0500
common-ha: add cluster HA status to --status output for gdeploy
gdeploy desires a one-liner "health" assessment.
If all the VIP and port block/unblock RAs are located on their
prefered nodes and 'Started', then the cluster is deemed to be
good (healthy).
N.B. status originally only checked the "online" nodes obtained
from `pcs status` but we really want to consider all the configured
nodes, whether they are online or not.
Also one `pcs status` is enough.
Change-Id: Id0e0380b6982e23763edeb0488843b5363e370b8
BUG: 1395648
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15882
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
commit 9d7e8afcf04231d27b93b44bc670649490d5409b
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Nov 28 17:56:35 2016 +0530
common-HA: Increase timeout for portblock RA of action=unblock
Portblock RA of action type unblock stores the information about
the client/server IPs connection in tickle_dir folder created in
the shared storage. In case of node shutdown/reboot there could be
cases wherein shared_storage may become unavailable for sometime.
Hence increase the timeout to avoid that resource agent going into
FAILED state.
Change-Id: I4f98f819895cb164c3a82ba8084c7c11610f35ff
BUG: 1399154
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/15947
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 34091c9d5bcd79efb0df2fc0008825d473dd8dcf
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Nov 29 21:57:37 2016 +0530
uss: snapd should enable SSL if SSL is enabled on volume
During snapd graph generation we should check if SSL is
enabled on main volume or not. This is because clients
will communicate with snapd as if it is communicating to
a brick.
Change-Id: I0d7fe86c567b297a8528a48faf06161d4c3cb415
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
BUG: 1400013
Reviewed-on: http://review.gluster.org/15979
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit e8a475dab4bd1ee99f3bef017b23798a75f1350e
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Wed Nov 30 15:43:26 2016 +0530
glusterd: Remove duplicate values for glusterd message macros
Both GD_MSG_BRICK_CLEANUP_SUCCESS and GD_MSG_DAEMON_STATE_REQ_RCVD
macros are assigned the same value (GLUSTERD_COMP_BASE + 584). Also
the number of messages should be 588 instead of 587
Change-Id: I015d32435c05ded1b14cd8ba11911af826bc956b
BUG: 1400026
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: http://review.gluster.org/15980
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 591d83e5d4be750dd520d1a0b368346929f0dd32
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Nov 29 12:56:40 2016 +0530
protocol/server: Fix mem-leaks in compound fops
* Remove spurious 'return' statement.
* Free up 'compound_rsp_array_val' as well in the end.
* Remove multiple refs on this_args->xdata.
Change-Id: I212c6dbe4d81b0381c1323d05fdfcc853886b25b
BUG: 1399578
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15965
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 47af35a0b244e0493e9d26da5bd54750c1ea34fa
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Nov 22 22:25:42 2016 +0530
gfapi: glfs_subvol_done should NOT wait for graph migration.
In graph_setup function glfs_subvol_done is called which
is executed in an epoll thread. glfs_lock waits on other
thread to finish graph migration. This can lead to dead lock
if we consume all the epoll threads.
In general any call-back function executed in epoll thread
should not call any blocking call which waits on a network
reply either directly or indirectly, e.g. syncop functions
should not be called in these threads.
As a fix we should not wait for migration in the call-back path.
Change-Id: If96d0689fe1b4d74631e383048cdc30b01690dc2
BUG: 1397754
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/15913
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1223180de672af3dd1dbe3bd62c23e5ac1b6a497
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Nov 22 10:18:50 2016 -0500
all: remove dead translators
The following have been completely removed from the source tree,
makefiles, configure script, and RPM specfile.
cluster/afr/pump
cluster/ha
cluster/map
features/filter
features/mac-compat
features/path-convertor
features/protect
Change-Id: I2f966999ac3c180296ff90c1799548fba504f88f
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/15906
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0f95647d016f72ef21572a9832f247cdf59a0597
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Nov 17 16:20:40 2016 +0530
cluster/dht: A hard link is lost during rebalance + lookup
Problem: A hard link is lost during rebalance + lookup.Rebalance skip files
if file has hardlink.In dht_migrate_file __is_file_migratable ()
function checks if a file has hardlink, if yes file is not migrated
but if link is created after call this function then link will lost.
Solution: Call __check_file_has_hardlink to check hardlink existence after (S+T) bits
in migration process ,if file has hardlink then skip the file for
migrate rebalance process.
BUG: 1396048
Change-Id: Ia53c07ef42f1128c2eedf959a757e8df517b9d12
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15866
Reviewed-by: Susant Palai <spalai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit be7051cac735a5a083100f134d85ebf282f715ff
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Nov 17 10:42:02 2016 -0500
afr: fix auto-quorum
(1) afr_have_quorum is dead code. It was copied to afr_has_quorum,
and everything else uses that, but the original was never deleted
(until now).
(2) Auto-quorum should be default for any N>2. Leaving quorum
disabled is BAD, but apparently deemed acceptable for N=2 because
there's no real quorum in that case. For any larger number (including
arbiter configurations) there is such a thing as real quorum and we
should use it by default. Note that for N=3 the answers we get from
"N % 2" (the old check) and "N > 2" (the new one) are the same.
(3) The special case for even N in afr_has_quorum has been simplified and
explained more thoroughly in a comment.
Change-Id: I48b33c15093512fecf516b26dcf09afecb7ae33b
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/15873
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 0399e39ae59c06e6fb548a47bc0e4f3edf124d00
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Nov 17 17:47:29 2016 +0530
geo-rep: Fix Last synced status column issue during Hybrid Crawl
During Hybrid crawl, Geo-rep maintains stime xattr in subdirectories along
with the Brick root. This is done to skip directories if Geo-rep crashes
before Hybrid crawl completes.
Update Last synced status only when stime xattr updated in brick root.
Status output will mislead if it shows sub directory stime as
last synced time.
BUG: 1396081
Change-Id: I5b73aee7ae4a1c1e2d1001d1f55559b9f9efd6e6
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15869
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 6b68c0e1b91aa207df83d514757887efa83281cc
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Nov 21 11:49:35 2016 +0530
afr: Fix the EIO that can occur in afr_inode_refresh as a result of cache invalidation(upcall).
Issue:
------
When a cache invalidation is recieved as a result of changing
pending xattr, the read_subvol is reset. Consider the below chain
of execution:
CHILD_DOWN
...
afr_readv
...
afr_inode_refresh
...
afr_inode_read_subvol_reset <- as a result of pending xattr set by
some other client GF_EVENT_UPCALL will
be sent
afr_refresh_done -> this results in an EIO, as the read subvol was
reset by the end of the afr_inode_refresh
Solution:
---------
When GF_EVENT_UPCALL is recieved, instead of resetting read_subvol,
set a variable need_refresh in inode_ctx, the next time some one
starts a txn, along with event gen, need_rrefresh also needs to
be checked.
Change-Id: Ifda21a7a8039b8874215e1afa4bdf20f7d991b58
BUG: 1396952
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15892
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 84988a2497578242944848197e4267400d055903
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Nov 21 19:57:08 2016 +0530
libglusterfs: Fix a read hang
Issue:
=====
In certain cases, there was no unwind of read
from read-ahead xlator, thus resulting in hang.
RCA:
====
In certain cases, ioc_readv() issues STACK_WIND_TAIL() instead
of STACK_WIND(). One such case is when inode_ctx for that file
is not present (can happen if readdirp was called, and populates
md-cache and serves all the lookups from cache).
Consider the following graph:
...
io-cache (parent)
|
readdir-ahead
|
read-ahead
...
Below is the code snippet of ioc_readv calling STACK_WIND_TAIL:
ioc_readv()
{
...
if (!inode_ctx)
STACK_WIND_TAIL (frame, FIRST_CHILD (frame->this),
FIRST_CHILD (frame->this)->fops->readv, fd,
size, offset, flags, xdata);
/* Ideally, this stack_wind should wind to readdir-ahead:readv()
but it winds to read-ahead:readv(). See below for
explaination.
*/
...
}
STACK_WIND_TAIL (frame, obj, fn, ...)
{
frame->this = obj;
/* for the above mentioned graph, frame->this will be readdir-ahead
* frame->this = FIRST_CHILD (frame->this) i.e. readdir-ahead, which
* is as expected
*/
...
THIS = obj;
/* THIS will be read-ahead instead of readdir-ahead!, as obj expands
* to "FIRST_CHILD (frame->this)" and frame->this was pointing
* to readdir-ahead in the previous statement.
*/
...
fn (frame, obj, params);
/* fn will call read-ahead:readv() instead of readdir-ahead:readv()!
* as fn expands to "FIRST_CHILD (frame->this)->fops->readv" and
* frame->this was pointing ro readdir-ahead in the first statement
*/
...
}
Thus, the readdir-ahead's readv() implementation will be skipped, and
ra_readv() will be called with frame->this = "readdir-ahead" and
this = "read-ahead". This can lead to corruption / hang / other problems.
But in this perticular case, when 'frame->this' and 'this' passed
to ra_readv() doesn't match, it causes ra_readv() to call ra_readv()
again!. Thus the logic of read-ahead readv() falls apart and leads to
hang.
Solution:
=========
Modify STACK_WIND_TAIL() as:
STACK_WIND_TAIL (frame, obj, fn, ...)
{
next_xl = obj /* resolve obj as the variables passed in obj macro
can be overwritten in the further instrucions */
next_xl_fn = fn /* resolve fn and store in a tmp variable, before
modifying any variables */
frame->this = next_xl;
...
THIS = next_xl;
...
next_xl_fn (frame, next_xl, params);
...
}
As a part of http://review.gluster.org/15901/ the caller io-cache
was fixed.
BUG: 1388292
Change-Id: Ie662ac8f18fa16909376f1e59387bc5b886bd0f9
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15923
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1744be1d85b803a5335aa04ee21aee4c161bbca1
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Nov 28 13:42:33 2016 +0530
cluster/ec: Healing should not start if only "data" bricks are UP
Problem: In a disperse volume with "K+R" configuration, where
"K" is the number of data bricks and "R" is the number of redundancy
bricks (Total number of bricks, N = K+R), if only K bricks are UP,
we should NOT start heal process. This is because the bricks, which
are supposed to be healed, are not UP. This will unnecessary
eat up the resources.
Solution: Check for the number of xl_up_count and only
if it is greater than ec->fragments (number of data bricks),
start heal process.
Change-Id: I8579f39cfb47b65ff0f76e623b048bd67b15473b
BUG: 1399072
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/15937
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit b392c33725a83d2c2fa07e53450f33f8cc2de238
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Sep 22 16:48:54 2016 +0530
cluster/afr: CLI for granular entry heal enablement/disablement
When there are already existing non-granular indices created that are
yet to be healed, if granular-entry-heal option is toggled from 'off' to
'on', AFR self-heal whenever it kicks in, will try to look for granular
indices in 'entry-changes'. Because of the absence of name indices,
granular entry healing logic will fail to heal these directories, and
worse yet unset pending extended attributes with the assumption that
are no entries that need heal.
To get around this, a new CLI is introduced which will invoke glfsheal
program to figure whether at the time an attempt is made to enable
granular entry heal, there are pending heals on the volume OR there
are one or more bricks that are down. If either of them is true, the
command will be failed with the appropriate error.
New CLI: gluster volume heal <VOL> granular-entry-heal {enable,disable}
Change-Id: I1f4fe8162813b9068e198965d94169fee4adc099
BUG: 1370410
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15747
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a07efb12a8cbfe63f5a53ae7cf942adb4c61602e
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Nov 24 08:31:47 2016 +0530
protocol/server: capture offset in seek
Problem:
http://review.gluster.org/11482 implemented seek FOP but
http://review.gluster.org/#/c/14137/ 'undid' the change where we pack
the offset returned by seek in server xlator before sending it to the client.
As a result, seek always returns zero to the client for SEEK_HOLE/
SEEK_DATA.
Fix:
I think 14137 removed it unintentionally, hence adding it back again.
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: I67a1f7b53214b043c5291f5704be4a50b698f91c
BUG: 1398076
Reviewed-on: http://review.gluster.org/15920
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 822341e230a3aeff04b8bbee620b8609c08b29ec
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Fri Sep 23 13:57:55 2016 +0530
gfapi: Fix memory leak in glfs-mgmt
dictionary was not freed after serialization
Change-Id: I495f2f823b0d53a0d858876bde41fde5f0705113
BUG: 1397177
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/15895
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit c1d32adf52b5d6c265fcd62e3c43e6d92dc2bbc7
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sat Nov 26 21:24:01 2016 +0530
afr: allow I/O when favorite-child-policy is enabled
Problem:
Currently, I/O on a split-brained file fails even when the
favorite-child-policy is set until the self-heal is complete.
Fix:
If a valid 'source' is found using the set favorite-child-policy, inspect
and reset the afr pending xattrs on the 'sinks' (inside appropriate locks),
refresh the inode and then proceed with the read or write transaction.
The resetting itself happens in the self-heal code and hence can also
happen in the client side background-heal or by the shd's index-heal in
addition to the txn code path explained above. When it happens in via
heal, we also add checks in undo-pending to not reset the sink xattrs
again.
Change-Id: Ic8c1317720cb26bd114b6fe6af4e58c73b864626
BUG: 1386188
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reported-by: Simon Turcotte-Langevin <simon.turcotte-langevin@ubisoft.com>
Reviewed-on: http://review.gluster.org/15673
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d820f6daac0c68efd5c5692ab42cba88e73ffac3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Nov 17 21:02:29 2016 +0530
protocol/server: Print pargfid in logs for rename error
BUG: 1394548
Change-Id: I42ee627c8cdf54158f083f9019a096ace449e3cc
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15872
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit 765ac2fc34af29e31e369f7d7ac6d7aff3463e44
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Nov 7 14:47:34 2016 +0530
cluster/afr: Fix bugs in [f]inodelk/[f]entrylk
Problems:
1) Inodelk is not taking quorum into account
2) finodelk, [f]entrylk are not implemented correctly
3) By default afr doesn't go for non-blocking parallel locks.
Fix:
Implemented a common framework which can be used by
[f]inodelk/[f]entrylk. Used quorum for the same.
Change-Id: I239f13875a065298630d266941df10cfa3addc85
BUG: 1369077
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15802
Tested-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 38b57150134c6fc3642c8d57b16264e2f79efad6
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Nov 25 15:54:30 2016 +0530
cluster/afr: Fix deadlock due to compound fops
When an afr data transaction is eligible for using
eager-lock, this information is represented in
local->transaction.eager_lock_on. However, if non-blocking
inodelk attempt (which is a full lock) fails, AFR falls back
to blocking locks which are range locks. At this point,
local->transaction.eager_lock[] per brick is reset but
local->transaction.eager_lock_on is still true.
When AFR decides to compound post-op and unlock, it is after
confirming that the transaction did not use eager lock (well,
except for a small bug where local->transaction.locks_acquired[]
is not considered).
But within afr_post_op_unlock_do(), afr again incorrectly sets
the lock range to full-lock based on local->transaction.eager_lock_on
value. This is a bug and can lead to deadlock since the locks acquired
were range locks and a full unlock is being sent leading to unlock failure
and thereby every other lock request (be it from SHD or other clients or
glfsheal) getting blocked forever and the user perceives a hang.
FIX:
Unconditionally rely on the range locks in inodelk object for unlocking
when using compounded post-op + unlock.
Big thanks to Pranith for helping with the debugging.
Change-Id: Idb4938f90397fb4bd90921f9ae6ea582042e5c67
BUG: 1398566
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15929
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 06d900f493b36b96715a24029337949f16b1a0d4
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Nov 24 18:36:28 2016 +0530
cluster/afr: Handle rpc errors, xdr failures etc with proper NULL checks
Change-Id: Id8ba76ba116d056bc7299dc5ce0980680a5a23f8
BUG: 1398226
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15924
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit edcb46d2d95562734be225bb8f484d7ff6547da6
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Nov 18 15:38:00 2016 +0530
features/index: Delete granular entry indices of already healed directories during crawl
If granular name indices are already in existence for a volume, and
before they are healed, granular entry heal be disabled, a crawl on
indices/xattrop will clear the changelogs on these directories. When
their corresponding entry-changes indices are crawled subsequently,
if it is found that the directories don't need heal anymore, the
granular indices are not cleaned up.
This patch fixes that problem by ensuring that the zero-xattrop
also deletes the stale indices at the level of index translator.
Change-Id: Ifbaa6bec2a14e3041addfee4054131babbf4d35e
BUG: 1370410
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15880
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit eb3ee597d664825e4c7a9b0867386489f11a4cc0
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Nov 22 01:48:26 2016 +0530
cli: glusterfs_ctx_defaults_init should not re-initialize ctx->locks
glusterfs_ctx_new already initialize ctx->locks therefore the second
initialization in glusterfs_ctx_defaults_init does not make sense.
Change-Id: I8a44bed13af20e60e8bafb05360e88c0b237056c
BUG: 1397419
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/15904
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 242260a1bcb12feb86a133749d2966929d484c58
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Nov 21 19:57:08 2016 +0530
io-cache: Fix a read hang
Issue:
=====
In certain cases, there was no unwind of read
from read-ahead xlator, thus resulting in hang.
RCA:
====
In certain cases, ioc_readv() issues STACK_WIND_TAIL() instead
of STACK_WIND(). One such case is when inode_ctx for that file
is not present (can happen if readdirp was called, and populates
md-cache and serves all the lookups from cache).
Consider the following graph:
...
io-cache (parent)
|
readdir-ahead
|
read-ahead
...
Below is the code snippet of ioc_readv calling STACK_WIND_TAIL:
ioc_readv()
{
...
if (!inode_ctx)
STACK_WIND_TAIL (frame, FIRST_CHILD (frame->this),
FIRST_CHILD (frame->this)->fops->readv, fd,
size, offset, flags, xdata);
/* Ideally, this stack_wind should wind to readdir-ahead:readv()
but it winds to read-ahead:readv(). See below for
explaination.
*/
...
}
STACK_WIND_TAIL (frame, obj, fn, ...)
{
frame->this = obj;
/* for the above mentioned graph, frame->this will be readdir-ahead
* frame->this = FIRST_CHILD (frame->this) i.e. readdir-ahead, which
* is as expected
*/
...
THIS = obj;
/* THIS will be read-ahead instead of readdir-ahead!, as obj expands
* to "FIRST_CHILD (frame->this)" and frame->this was pointing
* to readdir-ahead in the previous statement.
*/
...
fn (frame, obj, params);
/* fn will call read-ahead:readv() instead of readdir-ahead:readv()!
* as fn expands to "FIRST_CHILD (frame->this)->fops->readv" and
* frame->this was pointing ro readdir-ahead in the first statement
*/
...
}
Thus, the readdir-ahead's readv() implementation will be skipped, and
ra_readv() will be called with frame->this = "readdir-ahead" and
this = "read-ahead". This can lead to corruption / hang / other problems.
But in this perticular case, when 'frame->this' and 'this' passed
to ra_readv() doesn't match, it causes ra_readv() to call ra_readv()
again!. Thus the logic of read-ahead readv() falls apart and leads to
hang.
Solution:
=========
Ideally, STACK_WIND_TAIL() should be modified as:
STACK_WIND_TAIL (frame, obj, fn, ...)
{
next_xl = obj /* resolve obj as the variables passed in obj macro
can be overwritten in the further instrucions */
next_xl_fn = fn /* resolve fn and store in a tmp variable, before
modifying any variables */
frame->this = next_xl;
...
THIS = next_xl;
...
next_xl_fn (frame, next_xl, params);
...
}
But for this solution, knowing the type of variable 'next_xl_fn' is
a challenge and is not easy. Hence just modifying all the existing
callers to pass "FIRST_CHILD (this)" as obj, instead of
"FIRST_CHILD (frame->this)".
Change-Id: I179ffe3d1f154bc5a1935fd2ee44e912eb0fbb61
BUG: 1388292
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15901
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 7d8b11041b095970373d2a46fbc3427fdcdfe882
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Nov 22 19:04:54 2016 +0530
glusterd: fix few events generation
This patch does the following:
1. Generate PEER_REJECT event if the peer add request is from an unknown peer
during peer handshaking.
2. EVENT_COMPARE_FRIEND_VOLUME_FAILED should be generated based on status code,
not ret.
3. Add EVENT_BRICKPATH_RESOLVE_FAILED event in case glusterd fails to resolve
bricks, this is mainly at restore path.
4. Remove EVENT_BRICKS_START_FAILED event as we already have
EVENT_BRICK_START_FAILED
Change-Id: I90e5bc4a331166d0bb3554eb2ec9df2526837a1d
BUG: 1397424
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15903
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
commit 959abf5a84204934e1edc1309730323e8794d7a5
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Nov 17 17:07:36 2016 +0530
geo-rep: Handle ENOENT during unlink
Do not raise traceback if a file/dir not exists during
unlink or rmdir
BUG: 1396062
Change-Id: Idd43ca1fa6ae6056c3cd493f0e2f151880a3968c
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15868
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3ea60d1fa6121ea6fefee2c2f70603f5472b0c2e
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Nov 22 06:34:35 2016 +0000
protocol/server: Remove unused variable
Change-Id: I0d0a786b2d02d4db37c4da6194ee4b4feac31b63
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/15899
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 96394a95870861bb81cb73a4f9443bcfe37d5414
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Mon Nov 14 15:40:32 2016 +0530
libglusterfs:Now mempool is added to ctx pool list under a lock
mempool is added to ctx pool list without any lock. This can cause undefined
behaviour in case of multithreaded environment.
Fix: modify the list only under ctx->lock
Change-Id: I7bdbb3db48a899bb0e41427e149b13c0facaedba
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
BUG: 1394719
Reviewed-on: http://review.gluster.org/15842
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit d91c7c21f3638dfd5730f9d2fd373bc2ad75ab46
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun Nov 20 18:18:45 2016 +0530
glusterd: dump volinfo->dict in gluster get-state
Change-Id: I7e60629fb8003c620847fa63441f6b098db59721
BUG: 1396807
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15889
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Rohan Kanade <rkanade@redhat.com>
commit 81120da7783de8f6d538dcfa73a3cf6a7bca6666
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Nov 18 13:30:08 2016 +0530
performance/io-threads: Exit threads in fini() as well
Problem:
io-threads starts the thread in 'init()' but doesn't clean them up
on 'fini()'. It relies on PARENT_DOWN to exit threads but there can
be cases where event before PARENT_UP the graph init code can think
of issuing fini(). This code path is hit when glfs_init() is called
on a volume that is in 'stopped' state. It leads to a crash in ganesha
process, because the io-thread tries to access freed memory.
Fix:
Ideal fix would be to wait for all fops in io-thread list to be completed on
PARENT_DOWN, and have fini() do cleanup of threads. Because there is no proper
documentation about how PARENT_DOWN/fini are supposed to be used,
we are getting different kinds of sequences in different higher level protocols.
So for now cleaning up in both PARENT_DOWN and fini(). Fuse doesn't call fini()
gfapi is not calling PARENT_DOWN in some cases, so for now I don't see
another way out.
BUG: 1396793
Change-Id: I9c9154e7d57198dbaff0f30d3ffc25f6d8088aec
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15888
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 192bb0414a00f4bf4b65f63786e4f12aa016ce83
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Nov 8 14:10:49 2016 +0530
cluster/dht Set layout after mkdir as root
DHT does not set the layout for newly created
directories as root. This causes EPERM failures
when a non-root user with insufficient permissions
creates directories.
credit: srangana@redhat.com for RCA
Change-Id: Ia646e41665ce172c43c5f01d2707455e8eb374ed
BUG: 1392772
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15794
Reviewed-by: Susant Palai <spalai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 21504db0581bf65067b38c42c5f8314a871dab41
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Oct 28 15:27:15 2016 +0530
afr,dht,ec: Replace GF_EVENT_CHILD_MODIFIED with event SOME_DESCENDENT_DOWN/UP
Currently these are few events related to child_up/down:
GF_EVENT_CHILD_UP : Issued when any of the protocol client
connects.
GF_EVENT_CHILD_MODIFIED : Issued by afr/dht/ec
GF_EVENT_CHILD_DOWN : Issued when any of the protocol client
disconnects.
These events get modified at the dht/afr/ec layers. Here is a
brief on the same.
DHT:
- All the subvolumes reported once, and atleast one child came
up, then GF_EVENT_CHILD_UP is issued
- connect GF_EVENT_CHILD_UP is issued
- disconnect GF_EVENT_CHILD_MODIFIED is issued
- All the subvolumes disconnected, GF_EVENT_CHILD_DOWN is issued
AFR:
- First subvolume came up, then GF_EVENT_CHILD_UP is issued
- Subsequent subvolumes coming up, results in GF_EVENT_CHILD_MODIFIED
- Any of the subvolumes go down, then GF_EVENT_SOME_CHILD_DOWN is issued
- Last up subvolume goes down, then GF_EVENT_CHILD_DOWN is issued
Until the patch [1] introduced GF_EVENT_SOME_CHILD_UP,
GF_EVENT_CHILD_MODIFIED was issued by afr/dht when any of the subvolumes
go up or down.
Now with md-cache changes, there is a necessity to differentiate between
child up and down. Hence, introducing GF_EVENT_SOME_DESCENDENT_DOWN/UP and
getting rid of GF_EVENT_CHILD_MODIFIED.
[1] http://review.gluster.org/12573
Change-Id: I704140b6598f7ec705493251d2dbc4191c965a58
BUG: 1396038
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15764
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 21817548b31e862419193b32af56720dff39d7a9
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Nov 18 13:13:21 2016 +0530
snapshot/scheduler: Removing dependency of scheduler on eventing
Change-Id: I7de156d8186c32092ec5e9d174d023f4782947c0
BUG: 1396364
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/15876
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit f67771cb2ba6cda5141740c9ebd0ef5717138ad6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Oct 18 15:16:17 2016 +0530
events: Add FMT_WARN for gf_event
Raghavendra G found that posix is trying to print %s
but passing an int when HEALTH_CHECK fails in posix.
These are the kind of bugs that should be caught
at compilation itself.
Also fixed the problematic gf_event() callers.
BUG: 1386097
Change-Id: Id7bd6d9a9690237cec3ca1aefa2aac085e8a1270
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15671
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 9c1865199de45409ee714da7e4e5dbf861780f17
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Fri Oct 28 17:37:39 2016 +0530
ganesha/scripts : use export id for dbus signals
Currently for add export and update export parameter passed for executing those signal
is "PATH". This is based on assumption that volume name and PATH will always be same.
But it is wrong for subdir exports. The only reliable parameter in export configuration
file is "Export_Id".
Change-Id: Ic63ff44ac7736e14502034b74beaae27292eddf9
BUG: 1389746
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/15751
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 005f21fab607bd3c857ec42eb9767f19a2fcc356
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Nov 17 13:11:16 2016 +0530
cli: Print to screen frequently
Problem:
CLI appears to be hung because XML document is not flushed periodically
Fix:
Flush the buffer as soon as we print something
BUG: 1395993
Change-Id: Ic5f61d4c7d29ee162a124a049e60ceb810d6da6d
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15863
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 8e62cff81ecc1a1b7e30e7de07af54f69d22474f
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Oct 27 22:53:43 2016 +0530
tools/glusterfind: xml parsing fix for tiered volumes
gluster volume info <vol> --xml for non-tiered volumes have
'bricks/brick' elements under the 'volInfo/volumes/volume' element.
However, tiered volumes have a 'bricks/hotBricks/brick' and
'bricks/coldBricks/brick' elements under the 'volInfo/volumes/volume'
element.
Fix main.py::get_nodes()
BUG: 1389481
Change-Id: I2f4465bfa8a55e7fa87917d3ec3e69b05d5241b9
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/15746
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 0b9e8ae6dfea63321adaf5f3e9cc1cb10e62af56
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Oct 26 15:51:17 2016 +0530
eventsapi: Auto reload Webhooks data when modified
glustereventsd depends on reload signal to reload the
Webhooks configurations. But if reload signal missed, no
events will be sent to newly added Webhook.
Added auto reload based on webhooks file mtime. Before pushing
events to Webhooks, reloads webhooks configurations if previously
recorded mtime is different than current mtime.
BUG: 1388862
Change-Id: I83a41d6a52d8fa1d70e88294298f4a5c396d4158
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15731
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 257073b17ed3043ed0f47334f1e6ad763418f7c2
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Nov 11 12:08:57 2016 +0530
marker: Fix inode value in loc, in setxattr fop
On recieving a rename fop, marker_rename() stores the,
oldloc and newloc in its 'local' struct, once the rename
is done, the xtime marker(last updated time) is set on
the file, but sending a setxattr fop. When upcall
receives the setxattr fop, the loc->inode is NULL and
it crashes. The loc->inode can be NULL only in one valid
case, i.e. in rename case where the inode of new loc
can be NULL. Hence, marker should have filled the inode
of the new_loc before issuing a setxattr.
Change-Id: Id638f678c3daaf4a5c29b970b58929d377ae8977
BUG: 1394131
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15826
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit ca068747dec4d36f3b391e0b5e0ec74009796488
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Oct 28 15:21:52 2016 +0530
cli/rebalance: remove brick status is incorrect
If a remove brick operation is preceded by a fix-layout,
running remove-brick status on a node which does not
contain any of the bricks that were removed displays
fix-layout status.
The defrag_cmd variable was not updated in glusterd
for the nodes not hosting removed bricks causing the
status parsing to go wrong. This is now updated.
Also made minor modifications to the spacing in
the fix-layout status output.
Change-Id: Ib735ce26be7434cd71b76e4c33d9b0648d0530db
BUG: 1389697
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15749
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 1704ac09d2e65347f31d65d45fc068a70429704e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Nov 13 16:43:36 2016 +0530
system/posix-acl: Log reason for EACCES
It is becoming increasingly difficult to debug the reason why posix-acl decides
to fail a fop with EACCES. This patch prints a big log everytime such
a condition occurs giving out the details that may help in finding why the fop
is errored out.
Change-Id: I2505baaafb5d77ef6c187554ff027df9b20468db
BUG: 1394548
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15837
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 81263b211af82ee841a00992a0ff60ca39558c71
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Nov 16 18:26:52 2016 +0530
protocol/client: Fix iobref and iobuf leaks in COMPOUND fop
Change-Id: I408879aa2bbd8ea176fbc0d0eba5567e5df1b2b3
BUG: 1395687
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15860
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit edc2f9c1f080cf24f1845f1bad6ea49dee98beb5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Nov 12 16:47:00 2016 +0530
protocol/server: Print error-xlator name
Problem:
At the moment from which xlator the errors are stemming from is a mystery.
Fix:
With this patch we can find on the server side which xlator first gave
the errno received by server xlator. I am not yet sure how to get this
done for client side which has lot of copy_frame()s. May be another
patch.
Change-Id: Ie13307b965facf2a496123e81ce0bd6756f98ac9
BUG: 1394548
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15836
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 25efa064c6c26ae683c344a615e2cc18d79d299a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Nov 11 08:06:03 2016 -0500
common-ha: nfs-grace-monitor timed out unknown error messages
grace_mon_monitor() occasionally returns OCF_ERR_GENERIC, but it
ought to return OCF_NOT_RUNNING instead.
Change-Id: I3d550e33cc3d0a8dce4333ced72db19b3b2f4f2e
BUG: 1394224
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15831
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 1d532fd879cca00b9ede641e4f5ecb4619556242
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Oct 25 12:56:05 2016 +0530
geo-rep/cli: Validate Checkpoint label
Checkpoint command accepts "now" or any other Time
in "%Y-%m-%d %H:%M:%S" format as label.
Validation added with this patch for the input label. Checkpoint set
will fail for invalid label.
BUG: 1388401
Change-Id: I23518c151ab4b294f64cae3b78baaacb3d8f7b82
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15721
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit cc180f936bde7e96f05c54bf9b05a668a206d2f7
Author: Pranith Kumar Karampuri <pkarampu@redhat.com>
Date: Sun Nov 13 06:53:15 2016 -0700
Revert "rpc: Fix the race between notification and reconnection"
This reverts commit a6b63e11b7758cf1bfcb67985e25ec02845f0995.
Nithya and Rajesh found that the mount fails sometimes after this patch
was merged so reverting it.
BUG: 1386626
Change-Id: I959a5b6c7da61368cf4c67c98193c6e8fdd1755d
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15838
Reviewed-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 87d7b2a1fb01d92b2ed0c81cc92ed72321649400
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Nov 15 20:40:08 2016 +0530
cluster/dht: Check for null inode
Check for NULL inode before attempting to
set dht inode ctx.
Change-Id: I7693c18445f138221d8417df5e95b118cedb818a
BUG: 1395261
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15847
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit ec5804d5af029d00a91eadf974c915a576e9e7d6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Nov 14 11:09:31 2016 -0500
common-ha: remove /etc/corosync/corosync.conf in teardown/cleanup
In newer versions of corosync we observe that after tearing down an
existing HA cluster, when trying to set up a new cluster, `pcs cluster
start --all` will fail if corosync believes the nodes are already in
the cluster based on the presence of, and the contents of
/etc/corosync/corosync.conf
So we summarily delete it. (An alternative/work-around is to use `pcs
cluster start --force --all`)
Change-Id: I225f4e35e3b605e860ec4f9537c40ed94ac68625
BUG: 1394881
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15843
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
commit 4ab9288f690e8b57fb71f072da8644854c5db6a5
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Nov 8 19:54:11 2016 +0530
nfs/cli : add warning message while enabling gluster nfs
Change-Id: Ice70003f7295d2d8af9877e1ecf6f3c81422b30c
BUG: 1376693
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/15805
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 44e68e0d6d59ce1f2109b03ec5af6789f4dc2ac3
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Nov 10 12:34:48 2016 +0530
Update copyright content for glusterfs binaries
Change-Id: I2d5de7ae634d55ae32977e337f366586eab449e4
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/15819
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 985a81b9c0ca5e441b724cdc005dcebf51d1a7b3
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Sep 27 19:01:48 2016 +0530
nfs: revalidate lookup converted to fresh lookup
when an inode ctx is missing for a linked inode the revalidate
lookups are converted to fresh.
This could result in sending ESTALE when the gfid are recreated
We are not able to reproduce the issue with normal setup, most part of
RCA was done with code reading.
Possible scenario in which this bug can reproduce,
Delete a file and recreate a new file with same name, at the same time
from another client process try to list/or access the file.
In this case the second client may throw an ESTALE error for such files
Thanks to Soumya and Pranith for doing the complete RCA
Change-Id: I73992a65844b09a169cefaaedc0dcfb129d66ea1
BUG: 1379720
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/15580
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit fe7cac01330c1c5f633e544e41b0bb8561b96e82
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Oct 26 16:31:58 2016 +0530
glusterfsd: Continuous errors are getting in mount logs while glusterd is down
Problem: when glusterd is down, getting the continuous mgmt_rpc_notify errors
messages in the volume mount log for every 3 seconds,it will
consume disk space.
Solution: To reduce the frequency of error messages use GF_LOG_OCCASIONALLY.
BUG: 1388877
Change-Id: I6cf24c6ddd9ab380afd058bc0ecd556d664332b1
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15732
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 3b6d27dd7338c303a8a9270c3e39bbd9cc0e2656
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Nov 9 13:07:25 2016 +0530
performance/open-behind: Avoid deadlock in statedump
Problem:
open-behind is taking fd->lock then inode->lock where as statedump is taking
inode->lock then fd->lock, so it is leading to deadlock
In open-behind, following code exists:
void
ob_fd_free (ob_fd_t *ob_fd)
{
loc_wipe (&ob_fd->loc); <<--- this takes (inode->lock)
.......
}
int
ob_wake_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
int op_ret, int op_errno, fd_t *fd_ret, dict_t *xdata)
{
.......
LOCK (&fd->lock); <<---- fd->lock
{
.......
__fd_ctx_del (fd, this, NULL);
ob_fd_free (ob_fd); <<<---------------
}
UNLOCK (&fd->lock);
.......
}
=================================================================
In statedump this code exists:
inode_dump (inode_t *inode, char *prefix)
{
.......
ret = TRY_LOCK(&inode->lock); <<---- inode->lock
.......
fd_ctx_dump (fd, prefix); <<<-----
.......
}
fd_ctx_dump (fd_t *fd, char *prefix)
{
.......
LOCK (&fd->lock); <<<------------------ this takes fd-lock
{
.......
}
Fix:
Make sure open-behind doesn't call ob_fd_free() inside fd->lock
BUG: 1393259
Change-Id: I4abdcfc5216270fa1e2b43f7b73445f49e6d6e6e
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15808
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ae69043df25bef4cf6221c4dba9f8572e7fab083
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Nov 8 17:24:41 2016 +0530
cluster/afr: When failing fop due to lack of quorum, also log error string
Change-Id: I39de2bcfc660f23a4229a885a0e0420ca949ffc9
BUG: 1392865
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15800
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 11e1a79ee2fe0857620f2281eff2e302a997127a
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Nov 4 15:56:42 2016 +0530
upcall: Fix a log level
In upcall_cache_invalidation(), the gfid can be NULL in certain
valid test cases(eg: entry for ".." in readdirp), hence change
the log level from WARNING to DEBUG.
Change-Id: Ic90167a0e2076694e9131913114460df7b939b30
BUG: 1392167
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15777
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 9cb8f19582b58d6be0ab0eee33724b94170220ad
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Jun 23 12:15:22 2016 +0530
jbr: Sending rollback from failed fop to fdl
In case of a failed fop, the failure is detected
by the leader in the jbr-server in two places. First
during a quorum check of +ve responses when it
receives responses from all the followers. At this
point if the fop hasn't been successfully journaled
at a quorum of followers (as in there is no merit in
trying the fop in the leader as the quorum will never
be met), then we fail the fop.
Also if this quorum is met, then the fop is tried on
the leader, and after the leader completes the fop
a quorum check similar to the previous one is done
again, this time including the leaders outcome. If
quorum is not met, then we fail the fop.
In both these cases, when the fop fails we send a -ve
ack to the client. With this patch, now we will also
send a rollback through a GF_FOP_IPC to all the followers(and
also to the leader in the second case of failure). This
rollback will contain the index and term number of the
fop which failed. This will be recorded in the respective
journals of the bricks and will be used to rollback the
fop on that brick later.
A subsequent write, and it's respective rollback would
look something like the following in the journal.
The trusted.jbr.term and trusted.jbr.index present in the
dict of both the logs, relate them, and the presence of
"rollback-fop" in the dict of IPC indicates that it is a
rollback fop, and the value 13(stands for GF_FOP_WRITE)
indicates what kind of rollback operation it is.
=== GF_FOP_WRITE
fd = <gfid 77f12ea2-ca56-40e3-a46e-ba2308baa035>
vector = <158 bytes>
offset = 0 (0x0)
flags = 32769 (0x8001)
xdata = dict {
trusted.jbr.term = 0 <2 bytes>
trusted.jbr.index = 4 <2 bytes>
}
=== GF_FOP_IPC
xdata = dict {
trusted.jbr.term = 0 <2 bytes>
trusted.jbr.index = 4 <2 bytes>
rollback-fop = 13 <3 bytes>
}
Change-Id: I70b6a143d20697153d58e2f719e34ecd1ed160a5
BUG: 1349385
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/14783
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit e4e204c55a968861928247366762beb29e3d5849
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Tue Nov 8 15:08:37 2016 +0530
build: Update version check for resource-agents on RHEL
With bug1302545[1] and bug1303037[2], portblock resource agent
is made available as part of resource-agents-3.9.5* package
on RHEL 6.8 and RHEL 7.3 respectively. This change is to
update the same in the glusterfs spec.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1302545
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1303037
Change-Id: I5917e5f22f07b4121d636b099dd8815847e1338f
BUG: 1389293
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/15803
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit e3f81666d22063f8d27eb47e9ebc4d2000074e4a
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Nov 7 16:06:56 2016 +0530
features/shard: Fill loc.pargfid too for named lookups on individual shards
On a sharded volume when a brick is replaced while IO is going on, named
lookup on individual shards as part of read/write was failing with
ENOENT on the replaced brick, and as a result AFR initiated name heal in
lookup callback. But since pargfid was empty (which is what this patch
attempts to fix), the resolution of the shards by protocol/server used
to fail and the following pattern of logs was seen:
Brick-logs:
[2016-11-08 07:41:49.387127] W [MSGID: 115009]
[server-resolve.c:566:server_resolve] 0-rep-server: no resolution type
for (null) (LOOKUP)
[2016-11-08 07:41:49.387157] E [MSGID: 115050]
[server-rpc-fops.c:156:server_lookup_cbk] 0-rep-server: 91833: LOOKUP(null)
(00000000-0000-0000-0000-000000000000/16d47463-ece5-4b33-9c93-470be918c0f6.82)
==> (Invalid argument) [Invalid argument]
Client-logs:
[2016-11-08 07:41:27.497687] W [MSGID: 114031]
[client-rpc-fops.c:2930:client3_3_lookup_cbk] 2-rep-client-0: remote
operation failed. Path: (null) (00000000-0000-0000-0000-000000000000)
[Invalid argument]
[2016-11-08 07:41:27.497755] W [MSGID: 114031]
[client-rpc-fops.c:2930:client3_3_lookup_cbk] 2-rep-client-1: remote
operation failed. Path: (null) (00000000-0000-0000-0000-000000000000)
[Invalid argument]
[2016-11-08 07:41:27.498500] W [MSGID: 114031]
[client-rpc-fops.c:2930:client3_3_lookup_cbk] 2-rep-client-2: remote
operation failed. Path: (null) (00000000-0000-0000-0000-000000000000)
[Invalid argument]
[2016-11-08 07:41:27.499680] E [MSGID: 133010]
Also, this patch makes AFR by itself choose a non-NULL pargfid even if
its ancestors fail to initialize all pargfid placeholders.
Change-Id: I5f85b303ede135baaf92e87ec8e09941f5ded6c1
BUG: 1392445
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15788
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit fab99ed422d09c27ce6d4a68b6ddfa1ced1de8cf
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Aug 30 17:53:09 2016 +0530
glusterd/quota: upgrade quota.conf file during an upgrade
Problem
=======
When quota is enabled on 3.6, it will have quota conf version in quota.conf
as v1.1. This node gets upgraded to 3.7 but it will still have quota conf
version as v1.1 until a quota enable/disable/set limit is initiated. When
this is not initiated and when this node tries to peer probe a node which
is a fresh install of 3.7 (which will have quota conf version as v1.2), then this
will result in "Peer rejected" state. This patch fixes the issue.
Solution
========
When an upgrade happens from 3.6 to 3.7, quota.conf file needs
to be modified as well. With 3.6, in quota.conf the version will be
v1.1 and it needs to be changed to v1.2 from 3.7. This is because in
3.7, inode quota feature is introduced. So when an op-version bumpup
happens quota.conf needs to be upgraded with quota conf version v1.2
and all the 16 byte uuid needs to be changed to 17 bytes uuid as well.
Previously, when the cluster version is upgraded to 3.7, the quota.conf
got upgraded as well. But, the upgradation was done only when quota
enable/disable/set limit is done. With this patch, the upgradation is done
during a cluster op version bump up as well.
Change-Id: Idb5ba29d3e1ea0e45c85d87c952c75da9e0f99f0
BUG: 1371539
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/15352
Tested-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 25bf5ae7e2d67cc89aa0e86cd1300a7b95612fd8
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Nov 2 19:51:26 2016 +0530
gfapi: async fops should unref in callbacks
If fd is unref'd at the end of async call then the unref in cbks would
lead to double unref and possible crash. Removing duplicate unrefs.
Added unref only in failure cases.
A simple test case has been added to test async write case. Need to
extend the same for other async APIs too.
Details:
All glfd based calls in libgfapi, except for glfs_open and glfs_close,
behave in the same way. At the start of the operation, they take a ref
on glfd and fd. At the end of the operation, they unref it. Async calls
are a little different as they unref in the cbk function. A successfull
open call does not unref either the glfd or fd, thereby functioning as a
reference for a OPEN file object. glfs_close makes a syncop_flush call
sandwiched between a fd ref and unref(this can be removed, more on this
below), followed by a call to glfs_mark_glfd_for_deletion which unrefs
glfd and also calls glfs_fd_destroy as a release function thereby doing
a unref on fd too.
Functionally, there is no problem with how everything works when as
described above. However, it is a little non-intuitive that we need to
perform a fd_unref as a consequence of a implicit fd_ref that happens
within glfs_resolve_fd. As we perform a GF_REF_GET(glfd) at the start of
every operation, it would be worthwhile to remove the fd_ref that
glfs_resovle_fd takes and do away with explicit fd_unref()s at the end
of every operation. This is the same reason why we don't need the fd_ref
in glfs_close. This is however not in the scope of this patch.
Change-Id: I86b1d3b2ad846b16ea527d541dc82b5e90b0ba85
BUG: 1391086
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/15768
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Prasanna Kumar Kalever <pkalever@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit dc316a8f733d9f1574f8288f0bc6017faea733bf
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Thu Nov 3 14:21:28 2016 +0530
posix-acl: check dictionary before using it
If extended attributes are not present in md-cache it returns NULL as xattr.
posix acl xlator should check for NULL before using xattr.
If normal and default ACLs are not set on file then md-cache will not contain
system.posix_acl_access and system.posix_acl_default extended attributes in
its cache.
Therefore posix_acl_lookup_cbk should check xattr before using it, otherwise
the logs will get filled with dictionary errors.
Change-Id: Icebf73cf0b313bd3e82ca8cbda63786dd0fa47da
BUG: 1391387
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/15769
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 7baf9bd23eaec7a5af17aedcc3eeeeb6deeba58a
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Nov 1 20:32:17 2016 +0530
gfapi/upcall: Fix mismatch in few upcall API SYMVER
There is mismatch in few of the upcall API routine
definitions and their corresponding symbol version
declarations. Fixed the same.
Change-Id: I2edfd9546a4c6a9128757f3b68e3ae4edd2c7a79
BUG: 1344714
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/15760
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6c821cea3c2cd1dcc173ffe3ece9f20f81dbf516
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Fri Oct 21 00:08:26 2016 +0530
xlators/trash : Remove upper limit for trash max file size
Currently file which size exceeds more than 1GB never moved to
trash directory. This is due to the hard coded check using
GF_ALLOWED_MAX_FILE_SIZE.
Change-Id: I2ed707bfe1c3114818896bb27a9856b9a164be92
BUG: 1386766
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/15689
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 174e368209d586e294cdc594a9efa10be565ae5b
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Oct 20 12:58:16 2016 +0530
snapshot: Fix the failure to recreate clones with same name
The brick path of snapshot clones contained the clonename,
thereby failing to create newer clones with the same name
after the original clone had been deleted.
This fix creates the brick path with the clone's vol id
instead of the clones name. Hence future clones with the
same name will not have the namespace clash.
Change-Id: I262712adc576122f051b5d1ce171d020efaefd1a
BUG: 1387160
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/15683
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 709c064ff7e5bcaa3bbb149379260b5d4184b560
Author: Ryan Ding <ryan.ding@open-fs.com>
Date: Thu Sep 1 15:40:35 2016 +0800
performance/write-behind: fix flush stuck by former failed writes
the issue is happened in this case:
assume a file is opened with fd1 and fd2.
1. some WRITE opto fd1 got error, they were add back to 'todo' queue
because of those error.
2. fd2 closed, a FLUSH op is send to write-behind.
3. FLUSH can not be unwind because it's not a legal waiter for those
failed write(as func __wb_request_waiting_on() say). and those failed
WRITE also can not be ended if fd1 is not closed. fd2 stuck in close
syscall.
to resolve this issue, we can change the way we determine 2 requests is
'conflict': flush/fsync is not conflict with those write that is not
belonged to them. so __wb_pick_winds() can wind the FLUSH op.
below is some information when the stuck issue happen:
glusterdump logs:
[xlator.performance.write-behind.wb_inode]
path=/ltp-F9eG0ZSOME/rw-buffered-16436
inode=0x7fdbe8039b9c
window_conf=1048576
window_current=249856
transit-size=0
dontsync=0
[.WRITE]
request-ptr=0x7fdbe8020200
refcount=1
wound=no
generation-number=4
req->op_ret=-1
req->op_errno=116
sync-attempts=3
sync-in-progress=no
size=131072
offset=1220608
lied=-1
append=0
fulfilled=0
go=0
[.WRITE]
request-ptr=0x7fdbe8068c30
refcount=1
wound=no
generation-number=5
req->op_ret=-1
req->op_errno=116
sync-attempts=2
sync-in-progress=no
size=118784
offset=1351680
lied=-1
append=0
fulfilled=0
go=0
[.FLUSH]
request-ptr=0x7fdbe8021cd0
refcount=1
wound=no
generation-number=6
req->op_ret=0
req->op_errno=0
sync-attempts=0
gdb detail about above 3 requests:
(gdb) print *((wb_request_t *)0x7fdbe8021cd0)
$2 = {all = {next = 0x7fdbe803a608, prev = 0x7fdbe8068c30}, todo = {next
= 0x7fdbe803a618, prev = 0x7fdbe8068c40}, lie = {next = 0x7fdbe8021cf0,
prev = 0x7fdbe8021cf0}, winds = {next = 0x7fdbe8021d00, prev =
0x7fdbe8021d00}, unwinds = {next = 0x7fdbe8021d10, prev =
0x7fdbe8021d10}, wip = {
next = 0x7fdbe8021d20, prev = 0x7fdbe8021d20}, stub =
0x7fdbe80224dc, write_size = 0, orig_size = 0, total_size = 0, op_ret =
0, op_errno = 0,
refcount = 1, wb_inode = 0x7fdbe803a5f0, fop = GF_FOP_FLUSH, lk_owner
= {len = 8, data = "W\322T\f\271\367y$", '\000' <repeats 1015 times>},
iobref = 0x0, gen = 6, fd = 0x7fdbe800f0dc, wind_count = 0, ordering =
{size = 0, off = 0, append = 0, tempted = 0, lied = 0, fulfilled = 0,
go = 0}}
(gdb) print *((wb_request_t *)0x7fdbe8020200)
$3 = {all = {next = 0x7fdbe8068c30, prev = 0x7fdbe803a608}, todo = {next
= 0x7fdbe8068c40, prev = 0x7fdbe803a618}, lie = {next = 0x7fdbe8068c50,
prev = 0x7fdbe803a628}, winds = {next = 0x7fdbe8020230, prev =
0x7fdbe8020230}, unwinds = {next = 0x7fdbe8020240, prev =
0x7fdbe8020240}, wip = {
next = 0x7fdbe8020250, prev = 0x7fdbe8020250}, stub =
0x7fdbe8062c3c, write_size = 131072, orig_size = 4096, total_size = 0,
op_ret = -1,
op_errno = 116, refcount = 1, wb_inode = 0x7fdbe803a5f0, fop =
GF_FOP_WRITE, lk_owner = {len = 8, data = '\000' <repeats 1023 times>},
iobref = 0x7fdbe80311a0, gen = 4, fd = 0x7fdbe805c89c, wind_count = 3,
ordering = {size = 131072, off = 1220608, append = 0, tempted = -1,
lied = -1, fulfilled = 0, go = 0}}
(gdb) print *((wb_request_t *)0x7fdbe8068c30)
$4 = {all = {next = 0x7fdbe8021cd0, prev = 0x7fdbe8020200}, todo = {next
= 0x7fdbe8021ce0, prev = 0x7fdbe8020210}, lie = {next = 0x7fdbe803a628,
prev = 0x7fdbe8020220}, winds = {next = 0x7fdbe8068c60, prev =
0x7fdbe8068c60}, unwinds = {next = 0x7fdbe8068c70, prev =
0x7fdbe8068c70}, wip = {
next = 0x7fdbe8068c80, prev = 0x7fdbe8068c80}, stub =
0x7fdbe806746c, write_size = 118784, orig_size = 4096, total_size = 0,
op_ret = -1,
op_errno = 116, refcount = 1, wb_inode = 0x7fdbe803a5f0, fop =
GF_FOP_WRITE, lk_owner = {len = 8, data = '\000' <repeats 1023 times>},
iobref = 0x7fdbe8052b10, gen = 5, fd = 0x7fdbe805c89c, wind_count = 2,
ordering = {size = 118784, off = 1351680, append = 0, tempted = -1,
lied = -1, fulfilled = 0, go = 0}}
you can see they are all on 'todo' queue, and FLUSH op fd is not the
same WRITE op fd.
Change-Id: Id687f9cd3b9f281e1a97c83f1ce981ede272b8ab
BUG: 1372211
Signed-off-by: Ryan Ding <ryan.ding@open-fs.com>
Reviewed-on: http://review.gluster.org/15380
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 7853dd3c004e8f6a7af8a6690920265361e3f5f5
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Oct 27 08:01:44 2016 -0400
build: incorrect Requires for portblock resource agent
was:
Requires: /usr/lib/ocf/resource.d/portblock
s/b:
Requires: /usr/lib/ocf/resource.d/heartbeat/portblock
or:
Requires: resource-agents >= 3.9.6
Note: RHEL6.8 and RHEL7.2 have resource-agents-3.9.5 which does
not contain the portblock resource agent.
I'm not sure what the point is actually of:
Requires: /usr/lib/ocf/resource.d/heartbeat/portblock
as it will fail to install on RHEL whether you have the
resource-agents package installed or not. Hence wrapping it
in %if ( fedora ).
Change-Id: Ia7d6a475464c7469018678c98fc710a3b3bfc553
BUG: 1389293
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15743
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit bd50954d4145fc9f850092b1bb4f5b39961eea9b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Oct 27 08:28:14 2016 -0400
tests: fix cleanup in bug-1110262.t
The test wasn't cleaning up the user/group it had created if it
terminated abnormally. We have a mechanism (push_trapfunc) to add
cleanup actions in a way that ensures they'll be run when necessary, so
I changed the test to use it. While I was there, I fixed it to use
kill_brick instead of "ps|grep|kill" because that will be necessary for
it to pass with brick multiplexing anyway.
Change-Id: Ia515bd2420050f922970d28c5856c55df9b5247b
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/15744
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 4ce8f600bc644c811cfb9a0770548b7521af37f8
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Oct 25 12:44:29 2016 +0530
glusterd/shared storage: Check for hook-script at staging
Check if S32gluster_enable_shared_storage.sh is present
at /var/lib/glusterd/hooks/1/set/post/ at staging
before proceeding with the command. Fail the command
with the appropriate error message in case it is not
present.
Change-Id: I84e3912f1cdffb927f8a40d74d52be43ee69388b
BUG: 1388348
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/15718
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit f17add301639dc4eefea4385101c8e42d1f0c4e5
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Oct 6 13:13:44 2016 +0530
md-cache: Invalidate cache entry for open() with O_TRUNC
When a file is opened with O_TRUNC flag set, its size gets
set to '0'. This case needs to be handled in md-cache to
avoid sending incorrect cached stat.
Change-Id: I95d1f8a6634734898883ede010c3e7b0b7eb97d9
BUG: 1382266
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/15618
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 6c6273b147b3465994f32ffd58ff9eb637b04692
Author: Milind Changire <mchangir@redhat.com>
Date: Tue Jul 19 16:20:15 2016 +0530
cluster/tier: break the monolith processing function
Break tier_migrate_using_query_file() into a more manageable
tier_migrate_link() and helpers.
Change-Id: I5eb2d2cff9e7a2a2da567c3c4c2d53aab195f477
BUG: 1358296
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/14957
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit fc52055af8e03017b728a4510e70109d2fbefbbe
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Oct 26 06:51:18 2016 +0530
afr,ec: Heal device files with correct major, minor numbers
Thanks a lot to xiaoping.wu@nokia.com from Nokia for the bug and the
fix.
BUG: 1384297
Change-Id: Ie443237e85d34633b5dd30f85eaa2ac34e45754c
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15728
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 710cc20bec117bb543c4b37f013129b1ff217a4f
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Oct 17 12:16:36 2016 +0530
tools/glusterfind: kill remote processes and separate run-time directories
Problem #1:
Hitting CTRL+C leaves stale processes on remote nodes if glusterfind pre
has been initiated.
Solution #1:
Adding "-t -t" to ssh command-line forces pseudo-terminal to be assigned
to remote process. When local process receives Keyboard Interrupt,
SIGHUP is immediately conveyed to the remote terminal causing remote
changelog.py process to terminate immediately.
Problem #2:
Concurrent glusterfind pre runs are not possible on the same glusterfind
session in case of a runaway process.
Solution #2:
glusterfind pre runs now add random directory name to the working
directory to store and manage temporary database and changelog
processing.
If KeyboardInterrupt is received, the function call
run_cmd_nodes("cleanup", args, tmpfilename=gtmpfilename)
cleans up the remote run specific directory.
Patch:
7571380 cli/xml: Fix wrong XML format in volume get command
broke "gluster volume get <vol> changelog.rollover-time --xml"
Now fixed function utils.py::get_changelog_rollover_time()
Fixed spurious trailing space getting written if second path is empty in
main.py::write_output()
Fixed repetitive changelog processing in changelog.py::get_changes()
Change-Id: Ia8d96e2cd47bf2a64416bece312e67631a1dbf29
BUG: 1382236
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/15609
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 13bad180b4636ca3d91b9558b1233aea742e27c6
Author: hari <hgowtham@redhat.com>
Date: Mon Oct 24 16:24:23 2016 +0530
CLI/TIER: throw warning regarding the removal of the older commands.
The older tier commands for attach tier and detach tier have to be
removed from code. This patch sends a warning asking to use new
command as older ones are depricated and will be removed.
Change-Id: Ie1c62947bad6ff106f40331ff6134838a6c72a7a
BUG: 1388062
Signed-off-by: hari <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/15713
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 1167e9ccd2700400734f0adc56b77fd74cda5101
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Oct 21 18:27:45 2016 +0530
glusterd: use GF_BRICK_STOPPING as intermediate brickinfo->status state
On a volume stop trigger glusterd issues a brick-op to terminate the brick
process during brick-op phase , however in the commit-op glusterd once again
tries to kill the same process if it exists and then mark the brickinfo->status
flag to GF_BRICK_STOPPED. In the former case, if brick is successfully killed
there is a possibility that GlusterD will receive RPC_CLNT_DISCONNECT from the
said brick process before even the commit op phase is executed and hence by that
time brickinfo->status will still be set to GF_BRICK_STARTED.
BRICK_DISCONNECT event should be only sent if a brick has been killed and not
through a volume stop/remove brick trigger, however due to this trace, this
event is also sent out on a volume stop.
Fix is to introduce an intermediate state GF_BRICK_STOPPING which can be used to
mark the brick status at brick op phase of volume stop/remove brick to avoid
sending spurious BRICK_DISCONNECT events on a volume stop trigger.
Change-Id: Ieed4450e1c988715e0f9958be44faa6b14be81e1
BUG: 1387652
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15699
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 6aa171e9918e0f25bf9912cc4fe4d66cb642ddd2
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Oct 24 13:54:41 2016 +0530
cluster/dht: Incorrect volname in rebalance events
The rebalance event code was using strtok to parse the
volume name which is incorrect.
Reworked the code to get the correct volume name using
strstr.
Change-Id: Ib5f3305a34e6bf1ecfef677d87c5aff96bdeb0e6
BUG: 1388010
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15712
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 9c78463dada08af419d6478c68eb1edf8c445be9
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Oct 18 12:52:36 2016 +0530
snapshot: Fix for memory leaks in snapshot code path
Change-Id: Idc2cb16574d166e3c0ee1f7c3a485f1acb19fc8c
BUG: 1386088
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/15668
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit a9d9720f284043979f0af98f8c7a4ec09762fa8a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Oct 19 15:50:50 2016 +0530
rpc: Fix the race between notification and reconnection
Problem:
There was a hang because unlock on an entry failed with
ENOTCONN.
Client thinks the connection is down where as server thinks
the connection is up.
This is the race we are seeing:
1) Connection from client to the brick disconnects.
2) Saved frames unwind is called which unwinds all
frames that were wound before disconnect.
3) connection from client to the brick happens and
setvolume.
4) Disconnect notification for the connection in 1)
comes now and calls client_rpc_notify() which
marks the connection to be offline even when the
connection is up.
This is happening because I/O can retrigger connection
before disconnect notification is sent to the higher
layers in rpc.
Fix:
Notify the higher layers that a disconnect happened and then
go ahead with reconnect logic.
For the logs which point to the information above check:
https://bugzilla.redhat.com/show_bug.cgi?id=1386626#c1
Thanks to Raghavendra G for suggesting the correct fix.
BUG: 1386626
Change-Id: I3c84ba1f17010bd69049fa88ec5f0ae431f8cda9
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15681
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8b0c1b516383cd7292f0a3267ca4835dee8f70cd
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Sep 28 21:38:57 2016 +0530
protocol/client: reduce memory usage
readdirp calls use a lot of memory in case
of a large number of files. The dict->extra_free
is not used here so free buf immediately.
Change-Id: I097f5dde2df471f5834264152711110a3bdb7e9a
BUG: 1380249
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15593
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 5846ab67bfe84b39f8f7059221a6d2583de102c0
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Oct 18 13:34:57 2016 +0530
geo-rep: Upgrade conf file only if it is session config
Ignore config upgrade if it is template config file present in
/var/lib/glusterd/geo-replication/gsyncd_template.conf
BUG: 1386123
Change-Id: I2cbba3103b6801c16ff57f778a90b9a0bb2467cf
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15669
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit c3700a6dfb01ff9836cb21375956cc4dcbfb7f62
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Oct 17 15:13:28 2016 +0530
compound fops: Fix file corruption issue
1. Address of a local variable @args is copied into state->req
in server3_3_compound (). But even after the function has gone out of
scope, in server_compound_resume () this pointer is accessed and
dereferenced. This patch fixes that.
2. Compound fops, by virtue of NOT having a vector sizer (like the one
writev has), ends up having both the header and the data (in case one of
its member fops is WRITEV) in the same hdr_iobuf. This buffer was not
being preserved through the lifetime of the compound fop, causing it to
be overwritten by a parallel write fop, even when the writev associated
with the currently executing compound fop is yet to hit the desk, thereby
corrupting the file's data. This is fixed by associating the hdr_iobuf with
the iobref so its memory remains valid through the lifetime of the fop.
3. Also fixed a use-after-free bug in protocol/client in compound fops cbk,
missed by Linux but caught by NetBSD.
Finally, big thanks to Pranith Kumar K and Raghavendra Gowdappa for their
help in debugging this file corruption issue.
Change-Id: I6d5c04f400ecb687c9403a17a12683a96c2bf122
BUG: 1378778
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15654
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6499770cd63814980d4a92e308cea7b43769926e
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Oct 20 16:26:27 2016 +0530
eventsapi: Fix sending event during volume set help
Event sent when `gluster volume set help` command is run
with Volume name as "help" and empty options list
With this patch, event sent only when volume set on a real volume
BUG: 1387207
Change-Id: Ia8785d6108cb86f7d89ecf9ea552df0334b41398
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15685
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a65f4a2232f85bdd037146a4bbc2591a3f3437ad
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Oct 20 15:05:38 2016 +0530
geo-rep: Logging improvements
- Redundant log messages removed.
- Worker and connected slave node details added in "starting worker" log
- Added log for Monitor state change
- Added log for Worker status change(Initializing/Active/Passive/Faulty)
- Added log for Crawl status Change
- Added log for config set and reset
- Added log for checkpoint set, reset and completion
BUG: 1359612
Change-Id: Icc7173ff3c93de4b862bdb1a61760db7eaf14271
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15684
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit d656809666268697f382dde5872544af74531a24
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Oct 19 07:27:40 2016 +0530
rpc/socket.c : Modify socket_poller code in case of ENODATA error code.
Problem: Continuous warning message(ENODATA) are coming in socket_rwv
while SSL is enabled.
Solution: To avoid the warning message update one condition in
socket_poller loop code before break from loop in case
of error returned by poll functions.
BUG: 1386450
Change-Id: I19b3a92d4c3ba380738379f5679c1c354f0ab9b1
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15677
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 54e99aaa60a3d2df0abeb5886e300d8d30f5f604
Author: Kaushal M <kaushal@redhat.com>
Date: Mon May 16 15:15:49 2016 +0530
rpc/socket: Close pipe on disconnection
Encrypted connections create a pipe, which isn't closed when the
connection disconnects. This leaks fds, and gluster eventually ends up
in a situation with fd starvation which leads to operation failures.
Change-Id: I144e1f767cec8c6fc1aa46b00cd234129d2a4adc
BUG: 1336371
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/14356
Tested-by: MOHIT AGRAWAL <moagrawa@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 4017973e3d8d686723833c59dc10a3e36b1a69c4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Oct 9 21:36:40 2016 +0530
performance/io-threads: Exit all threads on PARENT_DOWN
Problem:
When glfs_fini() is called on a volume where client.io-threads is enabled,
fini() will free up iothread xl's private structure but there would be some
threads that are sleeping which would wakeup after the timedwait completes
leading to accessing already free'd memory.
Fix:
As part of parent-down, exit all sleeping threads.
BUG: 1381830
Change-Id: I0bb8d90241112c355fb22ee3fbfd7307f475b339
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15620
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit d2f3574ce503fe91bd2f89eab515946433412b96
Author: Kotresh HR <khiremat@redhat.com>
Date: Sat Oct 22 23:50:02 2016 +0530
bitrot/cli: Add ondemand scrub event
Following Bitrot Events are added
BITROT_SCRUB_ONDEMAND
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": EVENT_TYPE,
"message": {
"name": VOLUME_NAME,
}
}
Change-Id: I85e668e254e6f29c447ddb4ad2ce2fc04f98bf3c
BUG: 1387864
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/15700
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 0e66a2b8213eb721845dfc9bdf3dc606c752f705
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Oct 19 12:53:35 2016 +0530
glusterd: conditionally pass uuid for EVENT_PEER_CONNECT
When a new node is probed, on the first RPC_CLNT_CONNECT peerctx->uuid is set to
NULL as the same is yet to be populated. However the subesquent (dis)connect
events would be carrying the valid UUIDs.
Solution is not to generate EVENT_PEER_CONNECT on a peer probe trigger as CLI is
already going to take care of generating the same.
Change-Id: I2f0de054ca09f12013a6afdd8ee158c0307796b9
BUG: 1386516
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15678
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 779c120e43e78d20b6f9196c9b07fd6b6be26420
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Oct 18 14:57:47 2016 +0530
eventsapi/packaging: Fix wrong usage of %post
%postun was used for events package instead of %post. eventsd
service should be restarted only after install/upgrade and not
during uninstallation(%postun)
BUG: 1386141
Change-Id: Iae3eab06d02c5f4134b3de09f040123bed053bb8
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15670
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit bfb291ca2ffaa25b8416d7720cd83386a9e00c8e
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Oct 19 23:53:12 2016 +0530
events: add TIER_START and TIER_START_FORCE events
Add TIER_START and TIER_START_FORCE events
Conditionally generate DETACH events as per user confirmation.
Change-Id: I205dc14884d707087edce42e8cf4208bd89d31dc
BUG: 1386247
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/15675
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit fd1b0e4383f75fe9739ecf87e52ffe6c060a404d
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Sep 30 12:55:40 2016 +0200
tests: gfapi/bug1291259.c should only call glfs_free() on success
In case glfs_h_poll_upcall() does not return success, the 'struct
glfs_upcall' would not have been allocated. A retry will be done and
glfs_free() is called on the unallocated structure. In case the pointer
does not point to NULL, glfs_free() will try to free up some random
area.
Change-Id: I38788d3bf22bbac3924f25edf45cd4a2637fa777
BUG: 1371540
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15603
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 771b62cbffb27da61e08b8baca8bcd8d6902ad43
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Thu Oct 13 17:13:54 2016 +0530
cli, glusterd: Address issues in get-state cli output
This fixes the following data points:
1. Volume type
2. Peer state
3. List of other hostnames for a peer
4. Data unit information for rebalance
The following data points are removed:
1. Mount options and filesystem types for bricks
2. global-option-version from list of global options
The following data points are added:
1. Replica Count
2. Tier type for bricks belonging to hot/cold tier
Change-Id: I5011250e863fdc4929b203cdb345d79b2f16c6a5
BUG: 1385839
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: http://review.gluster.org/15662
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 5b4be6f8dcb97aaa5a73658302a86488c0e20d70
Author: Poornima G <pgurusid@redhat.com>
Date: Sun Sep 4 08:27:47 2016 +0530
md-cache, afr: Reduce the window of stale read
Problem:
Consider a replica setup, where one mount writes data to a
file and the other mount reads the file. In afr, read operations
are not transaction based, a brick(read subvolume) is chosen as
a part of lookup or other operations, read is always wound only
to the read subvolume, even if there was write from a different client
that failed on this brick. This stale read continues until there is
a lookup or any write operation from the mount point. Currently, this
is not a major issue, as a lookup is issued before every read and it will
switch the read subvolume to a correct one. But with the plan of
increasing md-cache timeout to 600s, the stale read problem will be
more pronounced, i.e. stale read can continue for 600s(or more if cascaded
with readdirp), as there will be no lookups.
Solution:
Afr doesn't have any built-in solution for stale read(without affecting
the performance). The solution that came up, was to use upcall. When a file
on any brick is marked bad for the first time, upcall sends a notification
to all the clients that had recently accessed the file. The solution has
2 parts:
- Identifying when a file is marked bad, on any of the bricks,
for the first time
- Client side actions on recieving the notifications
Identifying when a file is marked bad on any of the bricks for the first time:
-----------------------------------------------------------------------------
The idea is to track xattrop in upcall. xattrop currently comes with 2 afr
xattrs - afr dirty bit and afr pending xattrs.
Dirty xattr is set to 1 before every write, and is unset if write succeeds.
In certain scenarios, dirty xattr can be 0 and still the file could be bad
copy. Hence do not track dirty xattr.
Pending xattr is set on the good copy, indicating the other bricks that have
bad copy. It is still not as simple as, notifying when any of the pending xattrs
change. It could lead to flood of notifcations, in case the other brick is
completely down or consistantly failing. Hence it is important to notify only
once, the first time a good copy is marked bad.
Client side actions on recieving pending xattr change, notification:
--------------------------------------------------------------------
md-cache will invalidate the cache of that file, so that further lookup is
passed down to afr and hence update the read subvolume. Invalidating only in
md-cache is not enough, consider the folling oder of opertaions:
- pending xattr invalidation - invalidate md-cache
- readdirp on the bad read subvolume - fill md-cache
- lookup (served from md-cache)
- read - wound to the old read subvol.
Hence, along with invalidating md-cache, it is very important to reset the
read subvolume for that file, in afr.
Design Credit: Anuradha Talur, Ravishankar N
1. xattrop doesn't carry info saying post op/pre op.
2. Pre xattrop will have 0 value for all pending xattrs,
the cbk of pre xattrop carries the on-disk xattr value.
Non zero indicated healing is required.
3. Post xattrop will have non zero value for any of the
pending xattrs, if the fop failed on any of the bricks.
Change-Id: I469cbc111714c433984fe1c922be2ef113c25804
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15398
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 5a03aa6997ba082565575cea8e86e7fdc892bd92
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Sep 26 17:08:31 2016 +0530
eventsapi: Auto convert Boolean and Int attributes
Before publishing in JSON format, automatically convert the
attribute to "bool" or "int" if configured.
For example, instead of sending force="1", convert to bool and
send as force=True
{
"event": "VOLUME_START",
"name" : "gv1",
"force": "1"
}
Convert to,
{
"event": "VOLUME_START",
"name" : "gv1",
"force": true
}
BUG: 1379328
Change-Id: Iabc51fd61abc267a7c8dcf0aeac6b3c722d89649
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15574
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 173cc7bd81bd3bc0430418ab36b526e63e38b319
Author: Milind Changire <mchangir@redhat.com>
Date: Sat Oct 15 10:49:19 2016 +0530
cluster/tier: handle fast demotions
Demote files on priority if hi-watermark has been breached and continue
to demote until the watermark drops below hi-watermark.
Monitor watermark more frequently.
Trigger demotion as soon as hi-watermark is breached.
Add cluster.tier-emergency-demote-query-limit option to limit number
of files returned from the database query for every iteration of
tier_migrate_using_query_file(). If watermark hasn't dropped below
hi-watermark during the first iteration, the next iteration will be
triggered approximately 1 second after tier_demote() returns to the
main tiering loop.
Update changetimerecorder xlator to handle query for emergency demote
mode.
Add tier-ctr-interface.h:
Move tier and ctr interface specific macros and struct definition from
libglusterfs/src/gfdb/gfdb_data_store.h to new header
libglusterfs/src/tier-ctr-interface.h
Change-Id: If56af78c6c81d37529b9b6e65ae606ba5c99a811
BUG: 1366648
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/15158
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 4f8a5c68e42a5e65338537c336fe1d4742eba1a8
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Oct 3 12:35:39 2016 +0530
common-ha: Use UpdateExports dbus msg for refresh-config
In nfs-ganesha 2.4, new dbs msg type "UpdateExports" support
has been added. With this support, the exports can be re-configured
dynamically without the need to re-export the entries.
Change-Id: Iee7330d33e91db1126974a2ff46becb3764f2e5e
BUG: 1382258
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/15617
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit df6f7889b8b008bf9b6285b61e1b5aabbfb46a53
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Oct 18 12:19:39 2016 +0530
build: Avoid printing python version to stdout discovered during configure
Change-Id: I1e0d0dd462cd8fa6d3ce40850099e8a019d754de
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/15666
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 7f37344f8fedeea9a3c39b42ab480f4c8b36ad54
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Oct 17 11:58:30 2016 +0200
gfapi: add glfs_free() to glfs.h
Commit 4721188a154acd9a0a4c096d8d73e97f3bf1b2a9 introduces glfs_free()
but missed adding the function to the header. The symbol is correctly
available in the library though. Testcases do not seem to fail when a
function is missing for the headers...
The glusterfs-3.7.16 packages have been released with the missing
declaration in the header and symbol-maps. Still, the function is
available for applications:
$ objdump -T usr/lib64/libgfapi.so.0 | grep -w glfs_free
0000000000006aa0 g DF .text 0000000000000035 GFAPI_3.7.16 glfs_free
Change-Id: Ia707ee957f090dbfca028192fcc81a83dfdf4ae0
BUG: 1344714
Reported-by: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15653
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 459cc1bc7d33d7da57fa342c5175762a5e791675
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Oct 17 16:08:41 2016 +0530
glusterd: set the brickinfo->port before spawning the bricks
As of now, when glusterd spawns a brick process, post spawning, the brickinfo's
port is set. The side effect of this is it opens up an window where the
pmap_signin event can be initiated by the brick to glusterd and glusterd fails
to update signed_in flag since the brickinfo port is still 0 and the comparison
of port and brickinfo->port fails.
As a solution, set the brickinfo->port post pmap_registry_alloc and if the brick
spawn fails reset it to 0. This logic applies for rdma port too.
Change-Id: I00a13d4c6d6809ebd19a972aa13e71ee5eac7e35
BUG: 1385575
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15655
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit bf033e0a2723cc9e8a88c51e3a12aaecf9a1c528
Author: Ryan Ding <ryan.ding@open-fs.com>
Date: Wed Aug 24 00:08:12 2016 +0800
features/read-only: reten_mode is invalid to be free by mem_put()
priv->reten_mode is initialised by option 'retention-mode'. and it
reference the memory in this->options. so fini() use mem_put to free
priv->reten_mode will cause a problem.
there is no need to call mem_put(), so just remove it will be fine.
Change-Id: Iee6f9d1d54df38cba8c9b9100e2824f4f2b18ab4
BUG: 1369523
Signed-off-by: Ryan Ding <ryan.ding@open-fs.com>
Reviewed-on: http://review.gluster.org/15296
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit dd67313cc8ec617ddde90a7fd3a84090fe9f3c68
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Oct 12 12:25:11 2016 -0400
crypt: changes needed for openssl-1.1 (coming in Fedora 26)
Fedora is poised to update openssl-1.1.0b in/for Fedora 26
in the next day or so.
But already Fedora koji scratch builds are built against
openssl-1.1.0b because of the way scratch builds work.
N.B. that the latest Fedora rawhide (11 October) still ships
with openssl-1.0.2j.
HMAC_CTX is now an opaque type and instances of it must be
created and released by calling HMAC_CTX_new() and
HMAC_CTX_free().
Change-Id: I3a09751d7b0d9fc25fe18aac6527e5431e9ab19a
BUG: 1384142
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15629
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 090bb78e55284f76704b50ef57893924b10d9e0d
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Oct 12 23:32:39 2016 +0530
geo-rep/eventsapi: Additional Events
Added following events
EVENT_GEOREP_ACTIVE
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": "GEOREP_ACTIVE",
"message": {
"master_volume": MASTER_VOLUME_NAME,
"slave_host": SLAVE_HOST,
"slave_volume": SLAVE_VOLUME,
"brick_path": BRICK_PATH
}
}
EVENT_GEOREP_PASSIVE
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": "GEOREP_PASSIVE",
"message": {
"master_volume": MASTER_VOLUME_NAME,
"slave_host": SLAVE_HOST,
"slave_volume": SLAVE_VOLUME,
"brick_path": BRICK_PATH
}
}
EVENT_GEOREP_CHECKPOINT_COMPLETED
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": "GEOREP_ACTIVE",
"message": {
"master_volume": MASTER_VOLUME_NAME,
"slave_host": SLAVE_HOST,
"slave_volume": SLAVE_VOLUME,
"brick_path": BRICK_PATH,
"checkpoint_time": CHECKPOINT_TIME,
"checkpoint_completion_time": CHECKPOINT_COMPLETION_TIME
}
}
BUG: 1379330
Change-Id: I90716175868c59dd65c8d202e73e0ede90347b6a
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15630
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Kotresh HR <khiremat@redhat.com>
commit 30c2c5b0f496dd3996397cfcf22c9b0767f865b1
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Oct 17 13:20:09 2016 +0200
trivial: correct some spelling mistakes in comments and logs
BUG: 1385593
Change-Id: Icfae9e557a284182c6c22e9606fdd641528906f0
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15656
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 28c93cddba1075f65ed2109800d4a27abb83d734
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Sep 23 21:06:37 2016 +0530
storage/posix: Fix race in posix_pstat
Problem:
When one thread is in the process of creating a file/directory
and the other thread is doing readdirp, there is a chance that
posix_pstat, creation fops race in the following manner which
will lead to wrong stat values to be read by parent xlators
like posix-acl.
Creation fops posix_pstat() as part of readdirp
1) file is created with uid/gid 0/0 1) does stat of the path that
is created just now.
2) Does chown to set the correct
uid/gid
3) Sets the acl/user/internal xattrs
4) Sets the gfid on the entry and
completes the creation of the file/dir
2) fills the gfid in the iatt
If unwind of readdirp hits server xlator before creation fop, then
posix-acl remembers uid/gid of the file to be root/root and fails
fops like open etc on it.
Fix:
Reverse the order of filling gfid and filling lstat() values in
posix_pstat() so that if there is gfid in iatt buffer uid/gid
are valid.
Change-Id: I46caa7f6da7abfa40a0b1d70e35b88de9c64959c
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15564
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 83605f1420c5cdc90edde2becb233a5c95c5d98f
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Sep 27 16:35:08 2016 +0530
performance/write-behind: remove the request from liability queue in wb_fulfill_request
Before this patch, a request is removed from liability queue only when
ref count of request hits 0. Though, wb_fulfill_request does an unref,
it need not be the last unref and hence the request may survive in
liability queue till the last unref. Let,
T1: the time at which wb_fulfill_request is invoked
T2: the time at which last unref is done on request
Let's consider a case of T2 > T1. In the time window between T1 and
T2, any other request (waiter) conflicting with request in liability
queue (blocker - basically a write which has been lied) is blocked
from winding. If T2 happens to be when wb_do_unwinds is invoked, no
further processing of request list happens and "waiter" would get
blocked forever. An example imaginary sequence of events is given
below:
1. A write request w1 is picked up for unwinding in __wb_pick_unwinds
(but unwind is not done _yet_ and hence reference
remains). However, w1 is moved to liability queue. Let's call this
invocation of wb_process_queue by wb_writev as PQ1.
2. A flush (f1) request hits write behind. Since the liability queue
of inode is not empty, f1 is not picked for unwinding. Let's call
the invocation of wb_process_queue by wb_flush as PQ2.
3. PQ2 continues and picks w1 for fulfilling and invokes
wb_fulfill. As part of successful wb_fulfill_cbk,
wb_fulfill_request (w1) is invoked. But, w1 is not freed (and hence
not removed from liability queue) as w1 is not unwound _yet_ and a
ref remains (PQ1 has not invoked wb_do_unwinds _yet_).
4. wb_fulfill_cbk (triggered by PQ2) invokes a wb_process_queue (let's
say PQ3). f1 is not resumed in PQ3 as w1 is still in liability
queue. At this time, PQ2 and PQ3 are complete.
5. PQ1 continues, unwinds w1 and does last unref on w1 and w1 is freed
(and removed from liability queue). Since PQ1 didn't invoke
wb_fulfill on any other write requests, there won't be any future
codepaths that would invoke wb_process_queue and f1 is stuck
forever.
With this fix, w1 is removed from liability queue in step 3 above and
PQ3 resumes f1 in step 4 (as there are no requests conflicting with f1
in liability queue during execution of PQ3).
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
BUG: 1379655
Change-Id: Idacda1fcd520ac27f30224f8dfe8360dba6ac6cb
Reviewed-on: http://review.gluster.org/15579
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit ec7fb682d53095f75268d208da3e0837c0620650
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sat Sep 24 13:18:24 2016 +0530
glusterd: enable default configurations post upgrade to >= 3.9.0 versions
With 3.8.0 onwards volume options like nfs.disable, transport.address-family
have some default configuration value. If a volume was created pre upgrade to
3.8.0 or higher the default options are not set post upgrade. This patch takes
care of putting the default values in the op-version bump up workflow. However
these changes will only reflect from 3.9.0 onwards
Change-Id: I9a8d848cd08d87ddcb80dbeac27eaae097d9cbeb
BUG: 1379223
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15568
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 5bc11f59bed07cdcceb5773a0c0e361797e51bc5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Sep 30 17:16:43 2016 +0530
cluster/afr: Prevent dict_set() on NULL dict
In afr lookup when NULL dict is received in lookup, afr
is supposed to set all the xattrs it requires in a new dict
it creates, but for 'link-count' it is trying to set to the
dict that is passed in lookup which can be NULL sometimes.
This is leading to error logs. Fixed the same in this patch.
BUG: 1385104
Change-Id: I679af89cfc410cbc35557ae0691763a05eb5ed0e
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15646
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit 5cda92aefb4534f139b0d9c57f7d51a71fce9f80
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Oct 14 16:09:08 2016 +0530
afr: Take full locks in arbiter only for data transactions
Problem:
Sharding exposed a bug in arbiter config. where `dd` throughput was
extremely slow. Shard xlator was sending a fxattrop to update the file
size immediately after a writev. Arbiter was incorrectly over-riding the
LLONGMAX-1 start offset (for metadata domain locks) for this fxattrop,
causing the inodelk to be taken on the data domain. And since the
preceeding writev hadn't released the lock (afr does a 'lazy'
unlock if write succeeds on all bricks), this degraded to a blocking
lock causing extra lock/unlock calls and delays.
Fix:
Modify flock.l_len and flock.l_start to take full locks only for data
transactions.
Change-Id: I906895da2f2d16813607e6c906cb4defb21d7c3b
BUG: 1384906
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reported-by: Max Raba <max.raba@comsysto.com>
Reviewed-on: http://review.gluster.org/15641
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit ad6f1869ee23dec8b20f355f86e5fcddd45de311
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Oct 13 09:58:21 2016 +0200
gfapi: correct the gfapi.map for glfs_ipc@GFAPI_4_0_0
Commit 85e959052148ec481823d55c8b91cdee36da2b43 introduced an
inconsistency in gfapi.map. We need to figure out how to handle the
glfs_ipc() function at one point...
Change-Id: If53ad904318d5a60c14bd8b80685f7a852bf25e5
BUG: 1370931
Reported-by: Anoop C S <anoopcs@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15633
Reviewed-by: Anoop C S <anoopcs@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 0c24924060fc0442d869f445c8f24ccdfb86f55b
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Oct 3 10:55:23 2016 +0530
rpc/socket.c : Modify gf_log message in socket_poller code in case of error
Problem: In case of SSL after stopping the volume if client(mount point) is
still trying to write the data on socket then it will throw an EIO
error on that socket and given this log message is captured at every
attempt this would flood the log file.
Solution: To reduce the frequency of stored log message use GF_LOG_OCCASIONALLY
instead of gf_log.
BUG: 1381115
Change-Id: I66151d153c2cbfb017b3ebc4c52162278c0f537c
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15605
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 0fb2be7e1552b680f5859dac19b297f0ddbe3d5b
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Oct 4 13:55:53 2016 -0400
mgmt/glusterd: Cleanup memory leaks in handshake
Thanks to bingxuan.zhang at nokia dot com for the report and patch.
Change-Id: I994f82493fec7827f31592340af5bda83322f878
BUG: 1377584
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/15612
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit d72e98f4b5c16141a30af04cba3014b0d7042650
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Oct 4 14:02:12 2016 -0400
libglusterfs/client_t: cleanup username and passwd in client_destroy()
Thanks to bingxuan.zhang at nokia dot com for the report and patch.
Change-Id: If2b2151ab4df27d769126860d98770c80bc8a534
BUG: 1377584
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/15613
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit fd689fb71cd4921315334c71f6a7db095b012167
Author: Oleksandr Natalenko <onatalen@redhat.com>
Date: Wed Sep 28 14:29:23 2016 +0200
glusterfsd/main: fix OOM adjustment for older kernels
Milind Changire reported that GlusterFS fails to build on RHEL5
because linux/oom.h is unavailable.
Milind's initial patch disables OOM adjustment completely
for those environments that do not have this header. However,
I'd take another approach that:
1) checks for linux/oom.h in compile-time and defines necessary
constants if the header is not present;
2) checks for available OOM API in /proc in run-time and uses it
accordingly.
This allows OOM to be adjusted properly on RHEL5 (the kernel is pretty new
to present /proc API for that) as well as RHEL6 (the kernel has many thing
backported including new /proc API).
Change-Id: I1bc610586872d208430575c149a7d0c54bd82370
BUG: 1379769
Signed-off-by: Oleksandr Natalenko <onatalen@redhat.com>
Reviewed-on: http://review.gluster.org/15587
Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit efee2d2d78239f38db399cb928ddd845f9a67b90
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Sep 20 12:32:28 2016 +0530
cluster/ec: Implement heal info with lock
Problem: Currently heal info command prints all
the files/directories if the index for the
file/directory is present in .glusterfs/indices folder.
After implementing patch http://review.gluster.org/#/c/13733/
indices of the file which is going through update fop
will also be present in .glusterfs/indices even
if the fop is successful on all the brick. At this time
if heal info command is being used, it will also display this
file which is actually healthy and does not require any heal.
Solution: Take lock on a file corresponding to the indices
and inspect xattrs to decide if the file needs heal or not.
Change-Id: I6361e2813ece369be12d02e74816df4eddb81cfa
BUG: 1366815
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/15543
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 41d5a65b49c9d55983da8fcd38a27cce55304bc1
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Sep 13 09:03:56 2016 +0200
gfapi: warn when glfs_realpath() returned malloc'd memory
glfs_realpath() may return memory allocated with malloc(). Depending on
the memory allocator that the application uses, calling free() on the
returned string can cause segmentation faults or other problems.
Functions that allocate memory, need to match the free'ing of the same
memory allocator and memory accounting. glibc/malloc and jemalloc/free
do not match together (other allocators could probably trigger these
problems as well).
Applications need to provide a pre-allocated buffer, or in case
glfs_realpath() allocates the memory, glfs_free() should be used to free
it.
Change-Id: I5d721a7425674aa700db8a7a436cbedb95a5927f
BUG: 1370931
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15332
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 451aa4a28bf0be49629d956141dfbdebdf37bde7
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Thu Sep 29 13:35:26 2016 +0530
socket: log the client identifier in ssl connect
Problem: client identifier is not logged in message in ssl_setup_connection
Solutuion: In ssl_setup_connection xl_private is not available in rpc_transport
so changed to this peerinfo.identifier.
BUG: 1380275
Change-Id: I05006a3d63e46de8c388298c22faa9a3329eb6f3
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15596
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d8d7dd303d04aeaccf731de95d5d7bfca12674ba
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Oct 4 10:10:56 2016 +0530
afr: fix incorrect debug log in selfheal path
1. While looking at glustershd logs in DEBUG log-level, it was found that
all bricks of the replica were printed as local bricks even though they
were not. Fixed it.
2. Print the name of the subvol from which the entry was got during
index crawl.
Change-Id: I08b32e38694c755715e9fe0c0e1dd9212abcfb16
BUG: 1381421
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15610
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0bdb76a4dbe081119d36e5497532ebc1e1697d4b
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Aug 22 12:30:43 2016 +0530
afr: Implement IPC fop
Currently ipc() is not implemented in afr. md-cache and upcall
uses ipc to register the list of xattrs, [1] for more details.
For the ipc op GF_IPC_TARGET_UPCALL, it has to be wound to all
the replica subvolumes. ipc() is failed when any of the
subvolumes fails with other than ENOTCONN or all of the subvolumes
are down.
[1] http://review.gluster.org/#/c/15002/
Change-Id: I0f651330eafda64e4d922043fe53bd0014536247
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15378
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 10816d551bc5b0f32612c85e88ce8f1a4e37b759
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Sep 21 17:43:00 2016 +0530
eventsapi/geo-rep: Geo-rep will not work without eventsapi rpms
If glusterfs-events rpm is not installed, Geo-replication will
fail since it imports eventtypes.
Any call to gsyncd will fail with Import error. Glusterd start
fails since it runs `gsyncd.py --version`
Traceback (most recent call last):
File "/usr/libexec/glusterfs/python/syncdaemon/gsyncd.py",
line 29, in <module>
from syncdutils import FreeObject, norm, grabpidfile, finalize
File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py",
line 28, in <module>
from events import eventtypes
ImportError: No module named events
BUG: 1378057
Change-Id: I1a9bc086c3d52449ec7296cb2f9ceb16cd41a8a4
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15539
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 565baa60e1e8446558501a04cfb1696550138eb5
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Aug 6 16:04:48 2016 +0200
gfapi: redesign the public interface for upcall consumers
The glfs_callback_arg and glfs_callback_inode_arg were allocated by
gfapi, and expected to be free()'d by the application. However it is not
reasonable to expect that applications use the same memory allocator to
as the compiled libgfapi.so. For instance, it is possible that gfapi
uses glibc malloc/free, and an application like NFS-Ganesha the versions
from jemalloc. Mismatching of the malloc() and free() functions causes
segmentation faults at best.
In order to prevent problems like this in the future, the API for
applications that consume upcalls has been remodeled. Any of the
structures that gfapi allocates, should be free'd with glfs_free(). The
members of the structures can not be accessed directly anymore, each
has its own function to access now.
Correcting the naming of the functions, structures and constants is a
continuation of commit 2775dc64101ed37c8d9809bf9852dbf0746ee2b6. These
new improvements not only have correct prefixes for the functions and
structures, the naming also reflects more to the upcall framework and
does not use "callback" anymore.
Change-Id: I2b8bd5a0a82036d2abea1a217f5e5975a1d4fe93
BUG: 1344714
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14701
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit bfb58d741fed198d05f4733fa6ed0d092aef8dc8
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Sep 20 12:50:55 2016 +0530
ganesha/scripts : modify start hook script for shared storage changes
Change-Id: Ib8dfe41d06ae0756af8f1c110fc774ac16bdc581
BUG: 1377607
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/15535
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit ec34d8069f7bc7d11e702df212c37da20ab9bc7c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Sep 27 07:51:48 2016 +0530
tests: Fix races in open-behind.t
Problems:
1) flush-behind is on by default, so just because write completes doesn't mean
it will be on the disk, it could still be in write-behind's cache. This
leads to failure where if you write from one mount and expect it to be there
on the other mount, sometimes it won't be there.
2) Sometimes the graph switch is not completing by the time we issue read which
is leading to opens not being sent on brick leading to failures.
Fixes:
1) Disable flush-behind
2) Add new functions to check the new graph is there and connected to bricks
before 'cat' is executed.
BUG: 1379511
Change-Id: I0faed684e0dc70cfd2258ce6fdaed655ee915ae6
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15575
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6cdac395f8cd36e5b8892c1645e2b7dafaf166f8
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Sep 26 14:54:27 2016 +0530
gfapi: Fix few fd ref leaks
From the code inspection, have observed that there are fd ref
leaks for few fd-based gfapi fops. 'glfs_resolve_fd' returns
a fd (either existing or migrated) with an extra ref taken.
This needs to be unref'ed at the end of the operation.
Change-Id: Id63394e3e7deafb0c8b06444f2ae847248b126db
BUG: 1379285
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/15573
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit f95e9b37502cf272836a0114c03af7fb6617375e
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Sep 16 13:05:59 2016 +0530
glusterd: Revert 368e26f454fe35477e46dc698fa6b8c3c608ea8d
The earlier fix prevented rebalance from
starting even if only a single brick of a
replica set was down.
Change-Id: I8c9a7d4c1fe33f7749568357462f29796e1b832a
BUG: 1376671
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15517
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 42a2d630d8570f4e82021fcf869b2f4ce0271946
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue Sep 13 18:27:45 2016 +0530
glusterd: "gluster v heal test statistics heal-count replica" output is not correct
Problem : "gluster v heal test statistcs heal-count replica" does not
show correct output.
Solution: After update condition (match brick name) in
_select_hxlator_with_matching_brick, it shows correct output.
BUG: 1325792
Change-Id: I60cc7c68ea70bce267a747570f91dcddbc1d9016
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15494
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit d70cdc57802e9f20094ce45b3399a2fd02cdfbe7
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Sep 23 10:47:03 2016 +0530
afr: Ignore gluster internal (virtual) xattrs in metadata heal check
Problem:
In arbiter configuration, posix-xlator in the arbiter brick always sets
the GF_CONTENT_KEY in the response dict with a value 0. If the file size on
the data bricks is more than quick-read's max-file-size (64kb default),
those bricks don't set the key. Because of this difference in the no. of dict
elements, afr triggers metadata heal in lookup code path, in turn
leading to extra lookups+inodelks.
Fix:
Changed afr dict comparison logic to ignore all virtual xattrs and the
on-disk ones that we should not be healing.
Also removed is_virtual_xattr() function. The original callers to this
function (upcall) don't seem to need it anymore.
Change-Id: I05730bdd39d8fb0b9a49a5fc9c0bb01f0d3bb308
BUG: 1378684
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15548
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 2a6e0375a510bad8ce94399ce3c39ff2076a7c37
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Sep 22 20:04:12 2016 +0530
glusterd: fix return val in glusterd_op_volume_dict_uuid_to_hostname ()
glusterd_op_volume_dict_uuid_to_hostname () ignores few dict_get_str failures
but doesn't reset the ret value to 0.
Reproducer steps:
1. Configure a volume and start it (gNFS has to be disabled)
2. gluster volume status
An warning log is observed with:
[MSGID: 106217] [glusterd-op-sm.c:4706:glusterd_op_modify_op_ctx] 0-management:
Failed uuid to hostname conversion
[2016-09-22 09:21:38.537533] W [MSGID: 106387]
[glusterd-op-sm.c:4812:glusterd_op_modify_op_ctx] 0-management: op_ctx
modification failed
Change-Id: I1d3aa79304d83a9d5db1b7198773d8c2780e24a9
BUG: 1378492
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15547
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit b5f9d3cfa732c06ff8a38cd1a3846d67f9180ed8
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Sep 2 12:47:15 2016 +0530
ec: Implement ipc fop
The ipc will be wound to all the bricks, but for it to be
successfull, the fop should succeed on minimum number of bricks.
Change-Id: I3f8cb6a349e87bafd0773583def9d4e3765aa140
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15387
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 07403aaae168162f7114164d4b9fbd517267d1dd
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Sep 23 15:16:46 2016 +0530
afr: Modifications to afr events
Modified afr event message to add a 'type' key as detailed in the BZ.
Also added events for data and metadata split-brain.
Change-Id: I8156674b4b6a501499fc10fd68e05115fdaef3e4
BUG: 1378072
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15550
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit e12e74e225b4dac922a432c3886b22c0283a663b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 22 08:22:50 2016 -0400
build: python-ctypes no longer exists in Fedora Rawhide
Python packaging in Rawhide has a Virtual Provides of python-ctypes
but that will be removed soon
Change-Id: I353f7fcbff35dfbfb1a726c7608eef721976453d
BUG: 1378436
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15546
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit b9170d9bb0e87781c0ab2a7f4a99814da683a3de
Author: Csaba Henk <csaba@redhat.com>
Date: Mon Sep 19 03:58:15 2016 +0200
fuse: fix fuse dumping for FUSE_WRITE
Data coming with FUSE_WRITE requests are arranged
with a special alignment, cf. 15d85ff1. fuse_dumper()
was not aware of this and didn't dump the proper
reqion for FUSE_WRITE.
BUG: 1377427
Signed-off-by: Csaba Henk <csaba@redhat.com>
Change-Id: I36255ca3336e95be6e2d256c8199761ddec41869
Reviewed-on: http://review.gluster.org/15525
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit e193c6c755f442cb41095d64d27b290daea047c7
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Sep 22 10:38:21 2016 +0530
cluster/dht: remove unnecessary struct member
Removed a structure member that was not used
from dht_local_t. Skipped some unnecessary checks
in dht_filter_loc_subvol_key.
Change-Id: I81740b6528e063fb9cf5817e05865ff4d77aa748
BUG: 1378305
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15542
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 4c93d434bce884a25bc0dfe6dcf04fd0f9a092c8
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Sep 20 12:05:23 2016 +0530
performance/open-behind: Pass O_DIRECT flags for anon fd reads when required
Writes are already passing the correct flags at the time of open().
Also, make io-cache honor direct-io for anon-fds with
O_DIRECT flag during reads.
Change-Id: I215cb09ef1b607b9f95cabf0ef3065c00edd9e78
BUG: 1377556
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15537
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1435fc38995c9f96c32c7f7c121a71f23b5ff208
Author: Joseph Fernandes <josferna@redhat.com>
Date: Wed Dec 30 16:53:25 2015 +0530
tier/ctr/sql : Dafault values for sql cache and wal size
Setting default values for sql cache and wal size
cache : 12500 pages
wal : 25000 pages
1 pages - 4096 bytes
Change-Id: Iae3927e021af2e3f7617d45f84e81de3b7d93f1c
BUG: 1377864
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/15536
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
commit f48e8e81e62cd958ef01144946d4c196f67ab766
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Sep 19 09:13:09 2016 -0400
build: rpc/xdr .c and .h files are regenerated unnecessarily
.c and .h files are blindly (re)generated. If you run `make`
followed by a second `make` or `make install` the subsequent
`make` will unnecessarily recompile everything because of the
redundant regeneration of the .c and .h files are now newer
than the prior builds .o files
Change-Id: I7e477bcdcc20869e144ada7e6d91e7221b8ee71f
BUG: 1377341
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15530
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
commit 495b4bd923680c88b4942335965aad41e4dd9ff2
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Sep 8 11:33:59 2016 +0530
socket: pollerr event shouldn't trigger socket_connnect_finish
If connect fails with any other error than EINPROGRESS we cannot get
the error status using getsockopt (... SO_ERROR ... ). Hence we need
to remember the state of connect and take appropriate action in the
event_handler for the same.
As an added note, a event can come where poll_err is HUP and we have
poll_in as well (i.e some status was written to the socket), so for
such cases we need to finish the connect, process the data and then
the poll_err as is the case in the current code.
Special thanks to Kaushal M & Raghavendra G for figuring out the issue.
Change-Id: Ic45ad59ff8ab1d0a9d2cab2c924ad940b9d38528
BUG: 1372356
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/15440
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit fcd01780e33ff03f1a250c8e5613156240aeac38
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Sep 16 17:29:21 2016 +0200
rpc: increase RPC/XID with each callback
The RPC/XID for callbacks has been hardcoded to GF_UNIVERSAL_ANSWER. In
Wireshark these RPC-calls are marked as "RPC retransmissions" because of
the repeating RPC/XID. This is most confusing when verifying the
callbacks that the upcall framework sends. There is no way to see the
difference between real retransmissions and new callbacks.
This change was verified by create and removal of files through
different Gluster clients. The RPC/XID is increased on a per connection
(or client) base. The expectations of the RPC protocol are met this way.
Change-Id: I2116bec0e294df4046d168d8bcbba011284cd0b2
BUG: 1377097
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15524
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 3013ce6852c073f8beb8212670e751cf9353a090
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue Apr 26 17:04:04 2016 -0400
build: out-of-tree builds generates files in the wrong directory
And minor cleanup of a few of the Makefile.am files while we're
at it.
Rewrite the make rules to do what xdrgen does. Now we can get rid
of xdrgen.
Note 1. netbsd6's sed doesn't do -i. Why are we still running
smoke tests on netbsd6 and not netbsd7? We barely support netbsd7
as it is.
Note 2. Why is/was libgfxdr.so (.../rpc/xdr/src/...) linked with
libglusterfs? A cut-and-paste mistake? It has no references to
symbols in libglusterfs.
Note3. "/#ifndef\|#define\|#endif/" (note the '\'s) is a _basic_
regex that matches the same lines as the _extended_ regex
"/#(ifndef|define|endif)/". To match the extended regex sed needs to
be run with -r on Linux; with -E on *BSD. However NetBSD's and
FreeBSD's sed helpfully also provide -r for compatibility. Using a
basic regex avoids having to use a kludge in order to run sed with
the correct option on OS X.
Note 4. Not copying the bit of xdrgen that inserts copyright/license
boilerplate. AFAIK it's silly to pretend that machine generated
files like these can be copyrighted or need license boilerplate.
The XDR source files have their own copyright and license; and
their copyrights are bound to be more up to date than old
boilerplate inserted by a script. From what I've seen of other
Open Source projects -- e.g. gcc and its C parser files generated
by yacc and lex -- IIRC they don't bother to add copyright/license
boilerplate to their generated files.
It appears that it's a long-standing feature of make (SysV, BSD,
gnu) for out-of-tree builds to helpfully pretend that the source
files it can find in the VPATH "exist" as if they are in the $cwd.
rpcgen doesn't work well in this situation and generates files
with "bad" #include directives.
E.g. if you `rpcgen ../../../../$srcdir/rpc/xdr/src/glusterfs3-xdr.x`,
you get an #include directive in the generated .c file like this:
...
#include "../../../../$srcdir/rpc/xdr/src/glusterfs3-xdr.h"
...
which (obviously) results in compile errors on out-of-tree build
because the (generated) header file doesn't exist at that location.
Compared to `rpcgen ./glusterfs3-xdr.x` where you get:
...
#include "glusterfs3-xdr.h"
...
Which is what we need. We have to resort to some Stupid Make Tricks
like the addition of various .PHONY targets to work around the VPATH
"help".
Warning: When doing an in-tree build, -I$(top_builddir)/rpc/xdr/...
looks exactly like -I$(top_srcdir)/rpc/xdr/... Don't be fooled though.
And don't delete the -I$(top_builddir)/rpc/xdr/... bits
Change-Id: Iba6ab96b2d0a17c5a7e9f92233993b318858b62e
BUG: 1330604
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14085
Tested-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 7df78b86b02ed081bd30bf2fe623502aeb8b38e9
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Sep 18 08:23:23 2016 +0200
cli: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
Change-Id: Ib78fed1fab00ba22a90f2148a343170488fa05cf
BUG: 1369124
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15523
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6bd026980403ccc39ab7a8b2ff8d7e717cf1ca54
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Sat Sep 17 12:15:27 2016 -0400
cli/cli-rpc-ops: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I844e694c1797f9f6512f75fbe3620f527d1f5203
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15522
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 161a390193985b5b6a804366d495350ef3ef3d9f
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Sep 15 11:20:54 2016 +0530
dht/events: Added rebalance events
The rebalance process will now send an event when it is
complete.
Also fixed a problem where the run-time was not always
set causing spurious rebalance failure events to be sent.
Change-Id: Ib445171c78c9560940022bca20c887d31a9bb1ca
BUG: 1371874
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15501
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 483a6e08301dc4508bec53914077cde1b82c4503
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Aug 30 18:36:51 2016 +0530
ganesha/glusterd : Correct the path for ganesha conf dir in Makefile
The value for ganesha conf dir in Makefile.am is mistakenly entered as
following :
DCONFDIR=\"/$(runstatedir)/gluster/shared_storage/nfs-ganesha\"
Here value for runstatedir is seems to "NULL" which results wrong path
for ganesha configuration directory
Change-Id: I0b7ebd8e2503de0cb79b601553c4405d0d1fd711
BUG: 1355956
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/15355
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit eebac5a4f75a331dc0a3f2b81e8eed7969f1de93
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Sep 16 03:49:20 2016 -0400
cluster/ec: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I24607fc2082c3424f876f740a88fb7d0173d322d
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15518
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 4bd469f4f6d20c6f1e5e7b83760309684518ce5c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 15 22:53:09 2016 -0400
libglusterfs/mem-pool: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I8885e4d4aa44307c240413ba6f35ecd59ab45444
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15516
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 98a60c26835ed71d6731a3e7ee6a4e036dff4a65
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Aug 22 16:03:13 2016 +0530
cluster/ec: set/unset dirty flag for data/metadata update
Currently, for all the update operations, metadata or data,
we set the dirty flag at the end of the operation only if
a brick is down. This leads to delay in healing and in some
cases not at all.
In this patch we set (+1) the dirty flag
at the start of the metadata or data update operations and
after successfull completion of the fop, we unset (-1) it again.
Change-Id: Ide5668bdec7b937a61c5c840cdc79a967598e1e9
BUG: 1316873
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13733
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 74619c924ec8fc40082aa436c112d138c3355d23
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 15 12:29:53 2016 -0400
glusterd/handler: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: Ia2742a44fcf1e16ade1f55287096dbecdb8eb9b7
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15514
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f976e060e48cfba5aedc323a840d155ac864c6d4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 15 12:27:58 2016 -0400
xlators/afr: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I4946d460f66d3430bac8910260c0cb1b3e9ff87b
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15513
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit eedf06153a3df8a09e51852bc02a15ff8d09f5d7
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 13 05:57:32 2016 -0400
protocol/client: fix op_errno handling, was unused variable
see comment in patch set one. Match the general logic flow of the
other fop-cbks and eliminate the unused variable and its associated
warning
also see comment in patch set seven, re: correct handling of
client_process_response(); and the associated BZ
https://bugzilla.redhat.com/show_bug.cgi?id=1376328
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I7421ba3550770acc5564b7d6aba3290e027591f2
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15482
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit a4a2e25fa4dac1dfaffb75b16abe9068458eed8a
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Sep 14 20:12:42 2016 +0530
events/dht: dht cli events
Adding events for add/remove brick and rebalance
from the cli.
Change-Id: I4e07cb7224e1b63a2926db055f87a02220c5d043
BUG: 1371874
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15500
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 9c8056d93c57bdbc3c48a4d5bedce49b7a8318c8
Author: Nigel Babu <nigelb@redhat.com>
Date: Tue Sep 13 15:54:48 2016 +0530
tests: Kill rpc.statd on tests in Linux as well
The lack of this causes the /var/messages file on Linux test nodes to be filled
up and cause space issues.
Change-Id: I4c741c34de7f584859d1c62bdfda44a3d79c7ecc
BUG: 1375526
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: http://review.gluster.org/15485
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 09caf9a0598724c446e62d0dcc361830652d9550
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Sep 7 04:19:32 2016 +0530
storage/posix: Integrate important events with gf_event
BUG: 1371353
Change-Id: I9346ca16222caf9d97d999751577399ae6aacf72
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15342
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit ee87a1de3cd8df0f6cfc6815bdca27fe57850594
Author: Milind Changire <mchangir@redhat.com>
Date: Tue Sep 13 14:21:29 2016 +0530
build: add systemd dependency
Installs break with glusterfs getting installed before systemd
installation. This patch adds a dependency for systemd appropriately
for Fedora and RHEL platforms for glusterfs-server and glusterfs-events
packages.
Change-Id: Ica18f82a5e37c7755f0d386ce2ac6c70e8082815
BUG: 1375181
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/15469
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit d3b36fc30b7aad4ab66b4189366144c66043042f
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Sep 13 15:38:24 2016 +0530
eventsapi/packaging: Fix conflict during rpm install
RPM installation fails with following error
Error: Transaction check error:
file /etc/glusterfs/eventsconfig.json conflicts between attempted
installs of glusterfs-events-3.10dev-0.51.gitc9271ff.fc24.x86_64
and glusterfs-server-3.10dev-0.51.gitc9271ff.fc24.x86_64
Changed attributes of eventsconfig.json file as same as other
config files and excluded this file in server rpm.
BUG: 1375532
Change-Id: I3708c8fc58448cd5a6ebe611250f10e0658bdd58
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15486
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit d51abe2c475fa9b5e680c614a350ea8e0ef520dc
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 13 05:56:25 2016 -0400
xlators/md-cache: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I5904956b2033993abee0a29ff615e058a52c9ac0
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15481
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit eb458d1a8f536751ed843b3317fe544a22fd7132
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 13 05:54:59 2016 -0400
xlators/glusterd: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I7ccaa4f1cc817fa81082cee83e99a2dc7e542e17
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15479
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 6441d974c13e3e34cbb623725fd8cefad5ac604c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 13 05:58:10 2016 -0400
xlators/protocol/server: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I087131cd9b5e2abffc6a67d6c61e88fb6784661a
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15483
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 1a1e83d445aa78121f8d360c8c3b87514a8717bb
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 13 05:53:14 2016 -0400
xlators/{dht,tier}: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I6feee863927254ae9f59013112bcc297ad09e89b
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15477
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit a139e667870dabdaf3a3a0ecc6848de10a078f54
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 13 05:55:45 2016 -0400
xlators/decompounder: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: Ia4d11871838b749d15dd1942d0a93594e90124e0
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15480
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d4a8f3120389b2d70c60cdc1205d790b6c983ddc
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 13 05:52:09 2016 -0400
xlators/afr: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I55d4106ac828380f3315f5a21593390905d3ab3a
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15476
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 8521035ea464298ecd3201e8727efea4c0afdfc1
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 13 06:28:26 2016 -0400
xlators/upcall: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a "pragma leak" where the
generated rpc/xdr headers have a pair of pragmas that disable these
warnings. With the warnings disabled, many unused variables have
crept into the code base.
And 14085 won't pass its own smoke test until all these warnings are
fixed.
BUG: 1369124
Change-Id: I48c0d9bbf13ccf79975dd7b35d524f6d7428ac52
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15484
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit cf1b8ec77a03bd3c2be4e1412b09cbeed9b92f59
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Sep 8 17:30:37 2016 +0530
geo-rep: Defunct tar process after sync
After every sync iteration with tarssh mode leaves defunct tar
process.
Added wait for tar process to prevent this issue.
BUG: 1374286
Change-Id: I9953239ef601cc1970c814b00074b45eb00f481e
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15426
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit b7070f26274b02be329a5ed04d810512bb76e4f5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Sep 8 05:43:20 2016 +0530
system/posix-acl: Unwind with NULL xdata on error
In posix-acl when there are errors xdata that comes as part of input is used to
unwind which can be used as response xdata which may lead to problems as the
keys in the input will match with keys in the output but the values the
response xdata may expect can be completely different.
For example, we see that dht sends DHT_IATT_IN_XDATA_KEY in setxattr
which will be unwound with the same key in the xdata-response which
dht thinks is valid response and fills stbuf with invalid values
leading to EIO
BUG: 1374093
Change-Id: I6b77a1fa1ee99cb62e181e1db2e6fea73f6eaaa3
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15421
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 8da89145bf42625993799903de39beba4246a18b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Ibf069935a630cf10a9a829f5a3194621a891b616
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15282
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit b4ba4b50b90e34d733ec0c66fb2ba4aa705ab0a5
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:02 2016 -0400
glusterd (handler): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Ic4eabed88a363e85dbc4823b250a5a7f2a00a50f
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15265
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 0adea59d6525a6b9c7232932c9320db514ab4a34
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:02 2016 -0400
glusterd (geo-rep): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I2edacd3d0f3924b1be0f0398ba9ac076459c5a61
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15263
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
commit 6582aa8a5f82b7d45de0aa93135d6782e2303769
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
index: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Ibbc34782fdbffb7d9deaf454ebe946d04696035e
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15247
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 8d36a9f9d02babbe67cc5c2cda8dbfa8a73ac371
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (snapshot): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I359145d9e726b0fae78cac8003b57c216780cbba
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15278
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 97af3bfd5c967c4d22c5d4bb938608696fd7b686
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:12:12 2016 -0400
snapview-server: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I74cf7adf943f71e0de8d8f487db3cd2394ce16e8
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15251
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit ebfb1ff7fdca71d9647b9f2629d31e31021df26f
Author: Kaleb S. KEITHLEY <kkeithle@linux.keithley.org>
Date: Tue Aug 30 09:44:39 2016 -0400
protocol/client (no 4): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
BUG: 1369124
Change-Id: I7edef3c060b798fcb81d881caa04b346cef7a131
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@linux.keithley.org>
Reviewed-on: http://review.gluster.org/15356
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
commit cb3c22ae72e4b45bd2ac8acc9cab7647a019b43f
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:15:18 2016 -0400
bd: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Ia242a51ce153ee3a866a4c7f05a1389841b2bb54
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15256
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f361ebdbdeba724f4ea8ad9a21ff59583136d487
Author: hari gowtham <hgowtham@redhat.com>
Date: Fri Sep 9 12:26:52 2016 +0530
Tier: failing detach commit on detach failure and in-progress
PROBLEM: if detach status has failed or if it remains in progress
we allow detach commit to happen. only detach force should
be allowed.
FIX: check the detach status for failure or inprogress and disallow
with the apt error message.
Change-Id: Ib97d540fec67717bb55c18d133187c665cf69ef1
BUG: 1374584
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/15438
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit be74750ffe0322de4634bf1ac4665abd6e31f5b7
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (utils): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I3efaad13cc4cbba7853ada20e838b6fe417ca2d6
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15280
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 88dbaa48d93bbb1f01f23b4ca57ee82d4f863bcb
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Sep 7 10:38:41 2016 +0200
Update maintainers for "QEMU integration"
Prasanna and I are currently doing the majority of development for the
Gluster driver in QEMU. Bharata mentioned he prefers to get moved to the
"thank you" section.
Change-Id: I2a11d7a8f3bdc0f06815aa9701ab2b749b4f851a
URL: https://www.gluster.org/pipermail/gluster-devel/2016-September/050796.html
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15418
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 36c85f7a7a9e554a46f1852f0ab521f580d60a33
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Sep 5 11:39:10 2016 +0200
build: move checkpatch.pl to build-aux
There is no need for checkpatch.pl to be in extras/, it is used similar
to other scripts that are placed in build-aux/.
Change-Id: Id0f4db1666d83dad31687aa7aadae128fc14c016
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15400
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 3750589bbe1c6f99a54a5bb920148ec13f5e6992
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri Aug 19 10:33:50 2016 +0530
dht: "replica.split-brain-status" attribute value is not correct
Problem: In a distributed-replicate volume attribute
"replica.split-brain-status" value does not display split-brain
condition though directory is in split-brain.
If directory is in split brain on mutiple replica-pairs
it does not show full list of replica pairs.
Solution: Update the dht_aggregate code to aggregate the xattr
value in this specific condition.
Fix: 1) function getChoices returns the choices from split-brain
status string.
2) function add_opt adding the choices to local buffer to
store in dictionary
3) For the key "replica.split-brain-status" function dht_aggregate
call dht_aggregate_split_brain_xattr to prepare the list.
Test: To verify the patch followed below steps
1) Create a distributed replica volume and create mount point
2) Stop heal daemon
3) Touch file and directories on mount point
mkdir test{1..5};touch tmp{1..5}
4) Down brick process on one of the replica set
pkill -9 glusterfsd
5) Change permission of dir on mount point
chmod 755 test{1..5}
6) Restart brick process on node with force option
7) kill brick process on other node in same replica set
8) Change permission of dir again on mount point
chmod 766 test{1..5}
9) Reexecute same step from 4-9 on other replica set also
10) After check heal status on server it will show dir's are
in split brain on all replica sets
11) After check the replica.split-brain-status attr on mount
point it will show wrong status of split brain.
12) After apply the patch the attribute shows correct value.
BUG: 1368312
Change-Id: Icdfd72005a4aa82337c342762775a3d1761bbe4a
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15201
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8666c72033f5a2aa270d3ca08869d5b85cfa0624
Author: Susant Palai <spalai@redhat.com>
Date: Wed Aug 17 15:10:04 2016 +0530
cluster/dht: heal root permission post add-brick
Post add-brick event the new brick will have permission of 755
by default. If the root directory permission was other than 755,
that does not get healed to the new brick leading to permission
errors/inconsistencies.
For choosing source of attr heal we can trust the subvols which
have layouts with latest ctime(as part of missing directory heal,
we heal the proper attr). In case none of the subvols have layout,
return ESTALE to retrigger a fresh lookup.
Note: This patch heals the permission of the root directories only.
Since, permission healing of directory is not straight forward and
required intrusive fix, those are not addressed here.
Change-Id: If894e3895d070d46b62d2452e52c1eaafcf56c29
BUG: 1368012
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/15195
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1f4d042a4c5a4e7a7f25b42980c950127f31f6ab
Author: ankit <anraj@redhat.com>
Date: Tue Aug 30 12:55:32 2016 +0530
dht: Proper log message if data migration is skipped
Change-Id: Id0af15a2aec96bdbe675b4c959b56f0fc8e72504
BUG: 1341948
Signed-off-by: ankit <anraj@redhat.com>
Reviewed-on: http://review.gluster.org/15345
Tested-by: ankitraj
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit bbc900cee8acb909ecf631558cbc8cf8cd1a7d09
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun Sep 11 20:16:33 2016 +0530
tests: fix bug-963541.t spurious failure
wait for remove brick to complete before attempt for a commit.
Change-Id: I66ea6c48b6a69fe33d79f9d9080b6f2c1462578e
BUG: 1374993
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15457
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 92308d4f79a9cc9fa768cfe055447b8de887014e
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Sep 9 12:40:38 2016 +0530
eventsapi: Add conditional import for requests library
requests lib is used only during publishing event. gf_event python
imports utils.py, and indirectly imports requests lib even though
it is not required while sending event to eventsd.
Moved "import requests" inside the "plugin_webhook" function.
BUG: 1374587
Change-Id: Ie3c8088b43d4d7952d01352731999bf8519c73c4
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15439
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 259cd042020e696787e273b08a20f31b0bd124a8
Author: Susant Palai <spalai@redhat.com>
Date: Mon Aug 8 17:05:10 2016 +0530
dht: udpate stbuf from servers those have layout
Problem: For healing of uid/gid we check if local->stbuf.ia_ctime is
lesser than stbuf->ia_ctime (received from brick). If yes then uid/gid
is updated to local->prebuf(source of healing).
But we merge local->stbuf also form the newly added brick. So if we
receive response from the newly added brick first and update the
local->stbuf, then local->prebuf will remain empty since the newly added
brick will have the latest ctime among all servers. And this can result
in healing wrong uid/gids to the rest of servers.
Hence, we should update local->stbuf from servers with a layout which
will ignore merging stbufs from newly added bricks.
Change-Id: If4b64f75a0ea669abdbe9f5a3d1d18ff19374c2f
BUG: 1365740
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/15126
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 379aca6b12571ea79f931ffe953c683c6214c0ff
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Aug 31 08:33:44 2016 +0530
eventsapi: Add Init scripts for different distributions
Added init scripts for
- SysvInit(CentOS 6 or Red Hat 6)
- rc.d (FreeBSD)
Most of the latest distributions are using systemd. Support to be
added for other distributions which are not using systemd.
Removed systemctl wrapper functions(start/stop/status) from
gluster-eventsapi CLI(peer_eventsapi.py). Status and Reload
re-implemented using pid file check.
Added pid file support for glustereventsd.
Following dependencies removed
python-flask - Only used for example dashboard. User can install
if required.
python-fasteners - Not available for EPEL 6, added custom code using
fcntl as replacement.
BUG: 1365395
Change-Id: I26792eae9b11e93304f70b3997cd7d8d03b067f4
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15367
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 205d650b51c6d4c99e2fd99748950088313a0df0
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Aug 3 17:52:20 2016 +0530
geo-rep: Use configured log_level for libgfchangelog logs
libgfchangelog was not respecting the log_level configured
in Geo-replication. With this patch Libgfchangelog log level
can be configured using `config changelog_log_level TRACE`.
Default Changelog log level is INFO
BUG: 1363965
Change-Id: Ida714931129f6a1331b9d0815da77efcb2b898e3
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15078
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit e28cb528812d06598ff232e1daa7af14cafc4053
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Sep 6 11:13:20 2016 +0530
cluster/dht: Skip layout overlap maximization on weighted rebalance
dht_selfheal_layout_maximize_overlap () does not consider
chunk sizes while calculating overlaps. Temporarily
enabling this operation if only if weighted rebalance is disabled
or all bricks are the same size.
Change-Id: I5ed16cdff2551b826a1759ca8338921640bfc7b3
BUG: 1366494
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/15403
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit d8d7bd3212c4afa7c63bee71db8aaf12acd565ac
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Sep 6 18:28:42 2016 +0530
feature/bitrot: Fix recovery of corrupted hardlink
Problem:
When a file with hardlink is corrupted in ec volume,
the recovery steps mentioned was not working.
Only name and metadata was healing but not the data.
Cause:
The bad file marker in the inode context is not removed.
Hence when self heal tries to open the file for data
healing, it fails with EIO.
Background:
The bitrot deletes inode context during forget.
Briefly, the recovery steps involves following steps.
1. Delete the entry marked with bad file xattr
from backend. Delete all the hardlinks including
.glusters hardlink as well.
2. Access the each hardlink of the file including
original from the mount.
The step 2 will send lookup to the brick where the files
are deleted from backend and returns with ENOENT. On
ENOENT, server xlator forgets the inode if there are
no dentries associated with it. But in case hardlinks,
the forget won't be called as dentries (other hardlink
files) are associated with the inode. Hence bitrot stube
won't delete it's context failing the data self heal.
Fix:
Bitrot-stub should delete the inode context on getting
ENOENT during lookup.
Change-Id: Ice6adc18625799e7afd842ab33b3517c2be264c1
BUG: 1373520
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/15408
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit f7436eb96ad2ce29712b7ada94f74a596fad557b
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Dec 1 11:50:54 2015 +0100
cluster/ec: Add support for hardware acceleration
This patch implements functionalities for fast encoding/decoding
using hardware support. Currently optimized x86_64, SSE and AVX is
added.
Additionally this patch implements a caching mecanism for inverse
matrices to reduce computation time, as well as a new method for
computing the inverse that takes quadratic time instead of cubic.
Finally some unnecessary memory copies have been eliminated to
further increase performance.
Change-Id: I26c75f26fb4201bd22b51335448ea4357235065a
BUG: 1289922
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/12837
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 1f4cd1dc11cec644b700c33cbe308b46cd5a724d
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Aug 10 14:02:09 2016 +0530
geo-rep: Handle EISDIR error during Unlink
During Rename, If Source and Target has same inode then
Geo-rep unlinks source. But if source is a directory then
this will fail with below traceback
Traceback (most recent call last):
File "/usr/libexec/glusterfs/python/syncdaemon/repce.py", line 113, in worker
res = getattr(self.obj, rmeth)(*in_data[2:])
File "/usr/libexec/glusterfs/python/syncdaemon/resource.py", line 772,
in entry_ops
os.unlink(entry)
OSError: [Errno 21] Is a directory: '.gfid/12711ebf-7fdc-4f4b-9850-2d75581eb
452/New folder'
With this patch, if EISDIR, rmdir is tried. Logs error in Slave log in case
of ENOTEMPTY.
BUG: 1365791
Change-Id: I099af4192adac5125c0a23988ceb6506f91e987f
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15132
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 8e31685061269a02e0a11fb551fd136092f69859
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Sep 6 12:02:02 2016 +0530
geo-rep: Fix ESTALE/EINVAL issue during set_{xtime,stime}
Setfattr may get ESTALE/EINVAL if a file is being unlinked.
To prevent worker crashing, added retry for these error messages.
On second retry it will get ENOENT and that error is handled by
ignoring.
BUG: 1373373
Change-Id: Ic660fa13208366d57c8d3d492bbef611475e45b7
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15404
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit b7c4c9f7bbd679d1a0404eef81e9055b6a56b4ef
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Sep 7 11:39:39 2016 +0530
geo-rep: Fix Geo-rep status if monitor.pid file not exists
If monitor.pid file not exists, gsyncd fails with following traceback
Traceback (most recent call last):
File "/usr/libexec/glusterfs/python/syncdaemon/gsyncd.py",
line 201, in main
main_i()
File "/usr/libexec/glusterfs/python/syncdaemon/gsyncd.py",
line 681, in main_i
brick_status.print_status(checkpoint_time=checkpoint_time)
File "/usr/libexec/glusterfs/python/syncdaemon/gsyncdstatus.py",
line 343, in print_status
for key, value in self.get_status(checkpoint_time).items():
File "/usr/libexec/glusterfs/python/syncdaemon/gsyncdstatus.py",
line 262, in get_status
with open(self.monitor_pid_file, "r+") as f:
IOError: [Errno 2] No such file or directory: '/var/lib/glusterd/
geo-replication/master_node_slave/monitor.pid'
If Georep status command this worker's status will not be displayed
since not returning expected status output.
BUG: 1373741
Change-Id: I600a2f5d9617f993d635b9bc6e393108500db5f9
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15416
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 961db78a9325966d8b0ace312ec0f95f135ed093
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Sep 1 12:35:46 2016 +0530
geo-rep: Fix logging sync failures
If Rsync/Tar subprocess dies, while logging error Geo-rep fails
with EBADF while accessing error file. Also worker dies while
accessing elines before it is set.
BUG: 1372193
Change-Id: I9cfce116e8aafa4a98654f5190d40a455af8ec95
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15379
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 908b101d725d15d6d8c7c3b43af0113cd288cc4a
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Sep 5 21:51:19 2016 +0530
cluster/tier: add tiering events
Add events for:
* tier attach and detach
* tier pause and resume
* tier rising and dropping hi and lo watermarks
Update eventskeygen.py with tiering events.
Update cli help with:
* attach: add optional force argument
* detach: make force available as non-optional argument on its own
Change-Id: I43990d3a8742151a4a7889bafa19cb572fe661bd
BUG: 1368336
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/15232
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit fc541179df6b22e494067f6d0d19fb719ecfbb5b
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Sep 2 10:42:44 2016 +0530
cli: fix volume status xml generation
While generating xml, if CLI fails in between xml output doesn't get dumped into
stdout. Fix is to invoke cli_xml_output_vol_status_end () in such failures.
Change-Id: I7cb3097f5ae23092e6d20f68bd75aa190c31ed88
BUG: 1372553
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15384
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit cbb6417728da541af2d1a384d4a7cd520e0f157c
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Sep 8 10:11:01 2016 +0530
libglusterfs: Fix wrong git repository url
Change-Id: Iecd4cfacd7536cb3cc9a569c8d96e5284f5e2152
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/15423
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 0baab599036a88189cc076bbba7fc7e872f00c72
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Aug 31 11:53:06 2016 +0530
geo-rep: Fix History post process
This patch removes changelogsdb part of post processing since
not got much performance advantage as expected.
Entry stime and other logging improvements retained.
BUG: 1364420
Change-Id: Ib99d23f09d96c14bc28225b47d9134260f5551bf
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15371
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 83932a060f5c125e25521ab015530af8c96dc89b
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Sep 7 15:47:14 2016 +0530
tests: Fix one of the md-cache test cases
Verify if the unlink, rename and other ops are reflected both on
the current mount and other mounts.
Change-Id: I5a296cdd557194dcf487e65ee4a14bbeaf4be690
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15419
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9af9b73266caf3419e4c6f901af618db87e38ef8
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Aug 30 14:17:58 2016 +0530
cluster/ec: Add events for EC translator
This patch will generates events in following
cases which will be consumed by new event
framework.
Consider an EC volume with (K+M) configuration
K = Data bricks
M = Redundancy bricks
1- EVENT_EC_MIN_BRICKS_NOT_UP -
When minimum "K" number of bricks, required
for any ec fop, are not up.
2- EVENT_EC_MIN_BRICKS_UP
When minimum "K" number of bricks, required
for any ec fop, are up.
Change-Id: I0414b8968c39740a171e5aa14b087afd524d574f
BUG: 1371470
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/15348
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit bcf698450f47b5cd718449062d510023411776d5
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Sep 1 13:01:22 2016 +0530
afr: add replication events
Added the following events for the eventing framework:
"EVENT_AFR_QUORUM_MET", --> Sent when quorum is met.
"EVENT_AFR_QUORUM_FAIL" -->Sent when quorum is lost.
"EVENT_AFR_SUBVOL_UP" -->Sent when afr witnesses the first up subvolume.
"EVENT_AFR_SUBVOLS_DOWN"-->Sent when all children of an afr subvol are down.
"EVENT_AFR_SPLIT_BRAIN" -->Sent when self-heal detects split-brain in heal
path (not read/write path).
Change-Id: I937c61ca1ce78b5922ade73c7bfa3051df59c513
BUG: 1371485
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15349
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 2912fcedebac8474571beaf8ad1642d92c56b6c9
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Sep 5 11:15:10 2016 +0530
eventsapi: Fix Volume Stop and delete prompt issue
During Volume Stop and Delete, event is emitted even if
prompt answer is No.
Also added "force" details in START and STOP events.
BUG: 1373072
Change-Id: I986dcff7154b584f6ed44b533d4eeabe82815235
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15399
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit f4a6ef6759cfd0bd686e4558e04a5d5992f01e99
Author: ankit <anraj@redhat.com>
Date: Tue Sep 6 22:08:23 2016 +0530
typo error on github link
Change-Id: I011356266500315c43e42c2ba88cd6e5246db3a9
Signed-off-by: ankit <anraj@redhat.com>
This error was corrected for https://github.com/gluster/glusterfs
Reviewed-on: http://review.gluster.org/15412
Tested-by: ankitraj
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 26407dc9db74b1835e237deb522e9c4c7e483d93
Author: Susant Palai <spalai@redhat.com>
Date: Tue Aug 30 12:44:04 2016 +0530
cluster/dht: move layout logs to DEBUG level
Change-Id: Iad96256218be643b272762b5638a3f6837aff28d
BUG: 1366495
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/15343
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 7098a010b3fb18c3e59b519e758b36e76213791f
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Tue Aug 30 13:40:41 2016 +0530
protocol-server: generate events
This patch add/generate the events seen from/in the protocol server
side, which will be consumed by the new eventing framework.
-------------------------------------------------------------------------
| event | description |
|-------------------------------|---------------------------------------|
| EVENT_CLIENT_CONNECT | new client connected |
|-------------------------------|---------------------------------------|
| EVENT_CLIENT_AUTH_REJECT | client cannot be authenticated |
|-------------------------------|---------------------------------------|
| EVENT_CLIENT_DISCONNECT | client had disconnected |
-------------------------------------------------------------------------
Thanks to "Raghavendra Talur" <rtalur@redhat.com> for all the help
Change-Id: I4fda83fae7747507f64d81a7645cc3a8a2fbaeae
BUG: 1369403
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/15294
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 4121e808a3f84be0c164ca70ab39a76a0309f603
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (server-quorum): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I53961a9ddbba824ea3cfa00abbba20109da5de89
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15276
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a5565dad8765afd7d88fc9e24de1cc65bf48da3e
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Sep 2 09:33:16 2016 -0400
common-ha: ganesha_mon: line 137: [: too many arguments ]" messages
ensure that there are always valid, non-null arguments to /bin/test
Here there be dragons. Very racy, but if the races lose, they lose
in a way that's consistent with what we're testing for anyway, namely
that the ganesha.nfsd process is gone.
Change-Id: I88b770dd874ffa8576711f8009f27122a4fb0130
BUG: 1363595
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15390
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 829c39eaf26b935d5eaeb6be58df178c3825c4e0
Author: Kaleb S. KEITHLEY <kkeithle@linux.keithley.org>
Date: Tue Aug 30 09:46:00 2016 -0400
protocol/client (no 5): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
BUG: 1369124
Change-Id: Ic209b1291927c56f009544eadebdc51ba5f77475
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@linux.keithley.org>
Reviewed-on: http://review.gluster.org/15357
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 0056cf69b9cde42f2e6f36afbd766a2be45b2e11
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 29 14:24:48 2016 -0400
protocol/client (no 2): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
BUG: 1369124
Change-Id: I54055b3b1038374b4e21432da48fdaeca2938289
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15339
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 8c46b9394cc90ae5d819d4a1ea1e9591e931e189
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 29 14:22:42 2016 -0400
protocol/client (no 1): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
BUG: 1369124
Change-Id: I8a24e3c02144860859d653ab7115895fb3066378
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15338
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 82659098f137b73cd4899e4c0f82f9c62e6efec0
Author: Diogenes Nunez <dnunez@redhat.com>
Date: Wed Jul 27 11:09:47 2016 -0400
cluster/tier: Adding compaction option for metadata databases
Problem: As metadata in the database fills up, querying the database
take a long time. As a result, tier migration slows down. To
counteract this, we added a way to enable the compaction methods of
the underlying database. The goal is to reduce the size of the
underlying file by eliminating database fragmentation.
NOTE: There is currently a bug where sometimes a brick will
attempt to activate compaction. This happens even compaction is already
turned on.
The cause is narrowed down to the compact_mode_switch flipping its value.
Changes: libglusterfs/src/gfdb - Added a gfdb function to compact the
underlying database, compact_db() This is a no-op if the database has
no such option.
- Added a compaction function for SQLite3 that does the following
1) Changes the auto_vacuum pragma of the database
2) Compacts the database according to the type of compaction requested
- Compaction type can be changed by changing the macro
GF_SQL_COMPACT_DEF to one of the 4 compaction types in
gfdb_sqlite3.h
It is currently set to GF_SQL_COMPACT_INCR, or incremental
vacuuming.
xlators/cluster/dht/src - Added the following command-line option to
enable SQLite3 compaction.
gluster volume set <vol-name> tier-compact <off|on>
- Added the following command-line option to change the frequency the
hot and cold tier are ordered to compact.
gluster volume set <vol-name> tier-hot-compact-frequency <int>
gluster volume set <vol-name> tier-cold-compact-frequency <int>
- tier daemon periodically sends the (new)
GFDB_IPC_CTR_SET_COMPACT_PRAGMA IPC to the CTR xlator. The IPC
triggers compaction of the database.
The inputs are both gf_boolean_t.
IPC Input:
compact_active: Is compaction currently on for the db.
compact_mode_switched: Did we flip the compaction switch recently?
IPC Output:
0 if the compaction succeeds.
Non-zero otherwise.
xlators/features/changetimerecorder/src/ - When the CTR gets the
compaction IPC, it launches a thread that will perform the
compaction. The IPC ends after the thread is launched. To avoid extra
allocations, the parameters are passed using static variables.
Change-Id: I5e1433becb9eeff2afe8dcb4a5798977bf5ba0dd
Signed-off-by: Diogenes Nunez <dnunez@redhat.com>
Reviewed-on: http://review.gluster.org/15031
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit ddbfe979fc41e0580c01e43a451cad29acbc24ea
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Sep 2 10:47:13 2016 +0530
tests: Fix one of the upcall tests
Currently md-cache invalidation feature is enabled by setting
"performance.cache-invalidation", but this case was sent when
"features.cache-invalidation" was enabling md-cache invalidation.
Hence, fix the same.
Change-Id: If044f6208179748a120fbe1d63b676367e707f73
BUG: 1372584
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15385
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 729e332231b0ac3524ea5bdf73be530fb61307b5
Author: Ryan Ding <ryan.ding@open-fs.com>
Date: Tue Aug 23 17:42:44 2016 +0800
features/changelog: fix a segment fault in changelog_cleanup_dispatchers
the arg 'count' in changelog_cleanup_dispatchers means the thread count
to cleanup, so the cleanup loop should start with count-1, not count.
change the invoke place also.
Change-Id: Ia00853a2e0c5e01e145f60048b1f0ac05f2440ab
BUG: 1369397
Signed-off-by: Ryan Ding <ryan.ding@open-fs.com>
Reviewed-on: http://review.gluster.org/15293
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6e38018d805fb59b02be4bd7219e965bc85355fe
Author: Anuradha Talur <atalur@redhat.com>
Date: Thu Aug 25 11:46:25 2016 +0530
afr: Consume compound fops in afr transaction
Change-Id: Ib06ece3cce1b10d28d6d2953da28444f5c2457ad
BUG: 1290304
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/15014
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit c42aa091278997e2c40e2d765605977af80bb7ac
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Aug 25 11:49:19 2016 +0530
feature/locks: Implement fops in locks Translator
Implement those fop which were not present in
locks translator.
Also make sure to return xdata with the
entries which were requested for these fops.
Change-Id: I6e7f80e9eb5fba9e34c7034f6bc30557cde20927
BUG: 1231224
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/11204
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 783c6aa7acfd3792772c63e4f4e630a7797bb977
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Aug 30 18:10:16 2016 +0530
gfapi: Mark tests/basic/gfapi/bug1291259.t bad until it is fixed
Change-Id: Ia0493ce7e71050b3e8a1a1fed2d861cc141a0f94
BUG: 1371540
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15353
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit b5a3d7cd989b047420ace71acf352df994638fd7
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Aug 26 14:05:07 2016 +0530
snapshot/eventsapi: Integrate snapshot events with eventsapi
1. EVENT_SNAPSHOT_CREATED : snapshot_name=snap1 volume_name=test_vol
snapshot_uuid=26dd6c52-6021-40b1-a507-001a80401d70
2. EVENT_SNAPSHOT_CREATE_FAILED : snapshot_name=snap1 volume_name=test_vol
error=Snapshot snap1 already exists
3. EVENT_SNAPSHOT_ACTIVATED : snapshot_name=snap1
snapshot_uuid=26dd6c52-6021-40b1-a507-001a80401d70
4. EVENT_SNAPSHOT_ACTIVATE_FAILED: snapshot_name=snap1
error=Snapshot snap1 is already activated.
5. EVENT_SNAPSHOT_DEACTIVATED : snapshot_name=snap1
snapshot_uuid=26dd6c52-6021-40b1-a507-001a80401d70
6. EVENT_SNAPSHOT_DEACTIVATE_FAILED : snapshot_name=snap3
error=Snapshot (snap3) does not exist.
7. EVENT_SNAPSHOT_SOFT_LIMIT_REACHED : volume_name=test_vol
volume_id=2ace2616-5591-4b9b-be2a-38592dda5758
8. EVENT_SNAPSHOT_HARD_LIMIT_REACHED : volume_name=test_vol
volume_id=2ace2616-5591-4b9b-be2a-38592dda5758
9. EVENT_SNAPSHOT_RESTORED : snapshot_name=snap1 volume_name=test_vol
snapshot_uuid=3a840ec5-08da-4f2b-850d-1d5539a5d14d
10. EVENT_SNAPSHOT_RESTORE_FAILED : snapshot_name=snap10
error=Snapshot (snap10) does not exist
11. EVENT_SNAPSHOT_DELETED : snapshot_name=snap1
snapshot_uuid=d9ff3d4f-f579-4345-a4da-4f9353f0950c
12. EVENT_SNAPSHOT_DELETE_FAILED : snapshot_name=snap2
error=Snapshot (snap2) does not exist
13. EVENT_SNAPSHOT_CLONED : clone_uuid=93ba9f06-cb9c-4ace-aa52-2616e7f31022
snapshot_name=snap1 clone_name=clone2
14. EVENT_SNAPSHOT_CLONE_FAILED : snapshot_name=snap1 clone_name=clone2
error=Volume with name:clone2 already exists
15. EVENT_SNAPSHOT_CONFIG_UPDATED : auto-delete=enable config_type=system_config
config_type=volume_config hard_limit=100
16. EVENT_SNAPSHOT_CONFIG_UPDATE_FAILED :
error=Invalid snap-max-soft-limit 110. Expected range 1 - 100
17. EVENT_SNAPSHOT_SCHEDULER_INITIALISED : status=Success
18. EVENT_SNAPSHOT_SCHEDULER_INIT_FAILED
19. EVENT_SNAPSHOT_SCHEDULER_ENABLED : status=Successfuly Enabled
20. EVENT_SNAPSHOT_SCHEDULER_ENABLE_FAILED :
error=Snapshot scheduler is already enabled.
21. EVENT_SNAPSHOT_SCHEDULER_SCHEDULE_ADDED : status=Successfuly added job job1
22. EVENT_SNAPSHOT_SCHEDULER_SCHEDULE_ADD_FAILED :
status=Failed to add job job1 error=The job already exists.
23. EVENT_SNAPSHOT_SCHEDULER_SCHEDULE_EDITED :
status=Successfuly edited job job1
24. EVENT_SNAPSHOT_SCHEDULER_SCHEDULE_EDIT_FAILED :
status=Failed to edit job job2
error=The job cannot be found.
25. EVENT_SNAPSHOT_SCHEDULER_SCHEDULE_DELETED :
status=Successfuly deleted job job1
26. EVENT_SNAPSHOT_SCHEDULER_SCHEDULE_DELETE_FAILED :
status=Failed to delete job job1
error=The job cannot be found.
27. EVENT_SNAPSHOT_SCHEDULER_DISABLED : status=Successfuly Disabled
28. EVENT_SNAPSHOT_SCHEDULER_DISABLE_FAILED :
error=Snapshot scheduler is already disabled.
Change-Id: I3479cc3fb7af3c76ded67cf289f99547d0a55d21
BUG: 1370567
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/15329
Tested-by: Aravinda VK <avishwan@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 51edcbbf10690f81fb6519218e5b837bd6ff201a
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Aug 17 20:19:59 2016 +0530
io-stats: Add stats for upcall notifications
With this patch, there will be additional entries seen in
the profile info:
UPCALL : Total number of upcall events that were sent from
the brick(in brick profile), and number of upcall
notifications recieved by client(in client profile)
Cache invalidation events:
-------------------------
CI_IATT : Number of upcalls that were cache invalidation and
had one of the IATT_UPDATE_FLAGS set. This indicates
that one of the iatt value was changed.
CI_XATTR : Number of upcalls that were cache invalidation, and
had one of the UP_XATTR or UP_XATTR_RM set. This indicates
that an xattr was updated or deleted.
CI_RENAME : Number of upcalls that were cache invalidation,
resulted by the renaming of a file or directory
CI_UNLINK : Number of upcalls that were cache invalidation,
resulted by the unlink of a file.
CI_FORGET : Number of upcalls that were cache invalidation,
resulted by the forget of inode on the server side.
Lease events:
------------
LEASE_RECALL : Number of lease recalls sent by the brick (in
brick profile), and number of lease recalls recieved
by client(in client profile)
Note that the sum of CI_IATT, CI_XATTR, CI_RENAME, CI_UNLINK,
CI_FORGET, LEASE_RECALL may not be equal to UPCALL. This is
because, each cache invalidation can carry multiple flags.
Eg:
- Every CI_XATTR will have CI_IATT
- Every CI_UNLINK will also increment CI_IATT as link count is an
iatt attribute.
Also UP_PARENT_DENTRY_FLAGS is currently not accounted for,
as CI_RENAME and CI_UNLINK will always have the flag
UP_PARENT_DENTRY_FLAGS
Change-Id: Ieb8cd21dde2c4c7618f12d025a5e5156f9cc0fe9
BUG: 1371543
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15193
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit d63236c5b198060047aa2c7f6470d8497ed96a59
Author: Anuradha Talur <atalur@redhat.com>
Date: Wed Aug 31 15:27:31 2016 +0530
event: fix gf_event messages for replace/reset brick op
Change-Id: I80ebeeaffd2b228d7d0796c8d08bc2a051c4ccac
BUG: 1266876
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/15370
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 84f3b930de0040d77a4411a52b350a116e4e1e71
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Aug 30 02:02:45 2016 +0530
tests: Fix spurious failures because of wrong shd up function
Fixed the way shd up check is done to prevent self-heal daemon
not running error when heal full command is executed.
Change-Id: I93c4a0da12316373d62cd4ea74432cd9bf2b090c
BUG: 1370053
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15341
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
commit 9e85638848dfb804d6856ed552a83055b5d138fd
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Wed Aug 24 15:19:53 2016 +0530
geo-rep: add geo-rep events for server side changes
Event Type defined in #15351 to avoid merge conflicts
Add geo-rep events applicable to changes in
geo-rep session in the server side.
Change-Id: Ia66574d2abccad7fce6a96667efbc7c6c8903fc6
BUG: 1370445
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/15328
Tested-by: Aravinda VK <avishwan@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit c7b1c541c33163b64f356fb5fa757911e1855c1e
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Aug 25 10:09:20 2016 +0530
upcall: Mark the clients as accessed on readdirp entries
Currently when a client performs a readdirp it is not stored
in upcall, as one of the clients that have accessed the files.
Hence, when any other client modifies the file, the client that
had performed readdirp will not get any notifications.
Fix this by adding the clients to upcall database when they
perform readdirp.
Change-Id: I7767f1e26bf1bd1f67702a6d01f8aa64526ccc46
BUG: 1369430
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15313
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 000ea71b9616737ec55b7d3e152195352dcd0944
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Aug 31 16:07:09 2016 +0530
tests: disable lock_revocation.t on NetBSD
This has been consistently causing hangs in NetBSD machines. I have not
been able to debug the issue and we have merge deadline for 3.9. It
would be better to disable this for now.
Change-Id: I8c63940aa26f78dd9994bb63293a5757835ec52b
BUG: 1369401
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/15374
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e78f39f1687036a11e8e864caca43f70c2f1f7c5
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Aug 31 10:47:45 2016 +0530
cli: Fix double unref of dict
Problem: `gluster system:: uuid get` hangs due to double unref of dict.
Fix:
Remove the unnecessary unref in cli_cmd_uuid_get_cbk(). In the said
function, if calling proc->fn() is sucessful, the dict is automatically
unrefed in its cbk as a part of cli_local_wipe(). If calling proc->fn() fails,
then CLI_STACK_DESTROY() takes care of the unref.
Change-Id: Ib656d200f14a27415b36794a0bdadfe36b0d5306
BUG: 1371775
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15368
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit aff91eb179874d2ad31f5d5c03bd8cd9813599b1
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Aug 30 18:05:11 2016 +0530
eventsapi: declare all the identified events at one go
This patch ensures we don't get into merge conflicts
everytime a single eventing patch is merged which
changes eventskeygen.py. I've collected all the identified
events from the patches posted in gerrit for reviews and
consolidated at one place.
Change-Id: I5a5983d5c8db7c4a223fa02b4f99ec41c6fa9c35
BUG: 1334044
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15351
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit e33adf272f4cdc2557f3037d9d4a7202ef47fd28
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jun 15 13:54:37 2016 +0530
geo-rep: Alternate command to generate SSH Keys
`gluster system:: execute gsec_create` is used to generate SSH
Keys in all Master nodes and collect public keys in command initiated
node. But this tool will not provide details if a peer node is down and
unable to generate keys.
New command will be introduced to create SSH Keys in all peer nodes.
Usage:
gluster-georep-sshkey generate
or
gluster-georep-sshkey generate --no-prefix
Generates two SSH keys(one for gsyncd access and other for tar) in all
peer nodes and collects the public keys to the local node where it is
initiated. Adds `command=` prefix to common_secret.pem.pub if `--no-prefix`
argument is not set.
Shows status as below,
+-----------+-------------+---------------+
| NODE | NODE STATUS | KEYGEN STATUS |
+-----------+-------------+---------------+
| fvm2 | UP | OK |
| localhost | UP | OK |
+-----------+-------------+---------------+
BUG: 1356508
Change-Id: Ib202811f41f9986694f07d9eedba31db6ed4d18f
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14732
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 25321202b3319f6960c9e0a77136d6c827ca4563
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Aug 30 17:19:47 2016 +0530
extras: Fix failed_tests.py to have the updated regression links
Change-Id: Iee79389d835cae91288fbbe9b2b266ea2ba4b30e
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15350
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit f3ad17cd31a9cc7f63364b736f13fe28e71e972b
Author: Anuradha Talur <atalur@redhat.com>
Date: Mon Aug 29 16:41:09 2016 +0530
compound fops: Some fixes to compound fops framework
Change-Id: I808fd5f9f002a35bff94d310c5d61a781e49570b
BUG: 1360169
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/15010
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 669d04962ea19c7b214d1aadf83d39265ebab919
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Aug 25 15:43:29 2016 +0530
md-cache: Process all the cache invalidation flags
Currently, md-cache only processes IATT_UPDATE_FLAGS, UP_XATTR and
UP_XATTR_RM. We also need to process UP_RENAME_FLAGS, UP_FORGET,
UP_PARENT_DENTRY_FLAGS and UP_NLINK_FLAGS. Otherwise the files
unlinked or renamed will not be reflected on other mounts.
Change-Id: Icb8b03da51482c3fc2e2a7292d16d56e11a341d9
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15324
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 94dd6761c39d19cf5cf35a5ddaf49295e6b792fd
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Aug 23 18:15:22 2016 +0530
dht, md-cache, upcall: Add invalidation of IATT when the layout changes
Issue:
dht_layout is built as a part of lookup only. The layout can be
modified by rebalance process. Since every IO fop is preceded
by a lookup, there are very less issues of stale layout. But
with enhancements of aggressive caching of stats in md-cache,
the lookup will reduce and expose the stale layout issue often.
Solution:
Since stale layout is already an issue on dht, there is already
a plan to fix this at the dht layer, but this fix is not currently
planned for any release. Until this fix comes out, we can have
a workaround where, the upcall will send a notification to md-cache
when a layout xattr is changed. As a part of layout change notification
the existing cache is invalidated and the next lookup will fetch the
latest layout.
This is not a foolproof solution as the window between the layout change
and the next lookup(after invalidation of stat), where there will be stale
layout. But until the final fix comes in, this reduces the stale layout
window.
Change-Id: Iacf871a38b35880c1fc0bc68fe7ce291265e71d4
BUG: 1369638
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15300
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ea47594bda72f6a3c141487b27742293e7592c5e
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Jul 11 15:04:55 2016 +0530
md-cache: Register the list of xattrs with cache-invalidation
Issue:
md-cache caches a specified list of xattrs, and when cache invalidation
is enabled, it makes sense to recieve invalidation only when those xattrs
are modified by other clients. But the current implementation of upcall
is that, it will send invalidation when any of the on-disk xattrs is modified.
Solution:
md-cache sends a list of xattrs that it is interested in, to upcall by
issuing an ipc(). The challenge here is to make sure everytime a brick
goes offline and comes back up, the ipc() needs to be issued to the
bricks. Hence ipc() is sent from md-cache every time there is a
CHILD_UP/CHILD_MODIFIED event.
TODO:
There will be patches following, in cluster xlators, to implement ipc fop.
Change-Id: I6efcf3df474f5ce6eabd3d6694c00c7bd89bc25d
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15002
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1c971922dd58bd72e355dd957bbf8484400aab22
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu May 26 15:52:53 2016 +0530
geo-rep: Simplify Non root user(mountbroker) Setup
Setting up Non root Geo-replication is troublesome. Lot of steps
involved like user setup, directory creation, setting up proper
permissions, editing glusterd.vol file etc.
Introducing `gluster-mountbroker` command, with this tool non root
user setup steps are(Run the following commands in any one Slave
node),
gluster-mountbroker setup <MOUNT ROOT> <GROUP>
For example,
gluster-mountbroker setup /var/mountbroker-root geogroup
Add user using,
gluster-mountbroker add <VOLUME> <USER>
For example,
gluster-mountbroker add slavevol geoaccount
Remove user or Volume using,
gluster-mountbroker remove [--volume <VOLUME>] [--user <USER>]
Example,
gluster-mountbroker remove --volume slavevol --user geoaccount
gluster-mountbroker remove --user geoaccount
gluster-mountbroker remove --volume slavevol
Check the status of setup using,
gluster-mountbroker status
Once the changes are complete, restart glusterd in all Slave nodes.
and follow the Geo-rep instructions.
Change-Id: Ied3fa009df6a886b24ddd86d39283fcfcff68c82
BUG: 1343333
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14544
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 855be5ae011abb1871d2fb2a67237bdf337264b1
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (op-sm): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I6c1474547586b5e43f30545872ec512cdd32dac2
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15269
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 976a30b4de41d209b7d8d756e8eea2cf2de3595e
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Aug 17 13:46:00 2016 +0530
eventsapi: Add support for Client side Events
Client side gf_event uses ctx->cmd_args.volfile_server to push
notifications to the eventsd.
Socket server changed from Unix domain socket to UDP to support
external events.
Following to be addressed in different patch
- Port used for eventsd is 24009. Make it configurable
Already configurable in Server side. Configurable in gf_event API
is required.
- Auth Token yet to be added as discussed in
https://www.gluster.org/pipermail/gluster-devel/2016-August/050324.html
Change-Id: I159acf80b681d10b82d52cfb3ffdf85cb896542d
BUG: 1367774
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15189
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit ecca443f47989311971e4e90315e86e2d86a1bf8
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Aug 30 18:14:45 2016 +0530
gfapi: Mark tests/basic/gfapi/1093594.t bad until it is fixed
Change-Id: If88efe3db782a6156614af4c650d53b159ade57f
BUG: 1371541
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15354
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 2b2704423438a4ed06006cb9c52b8424182e68b1
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
dht/tiering: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I367a737570dd7d2f6cc25f4bf4299d31bb6826aa
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15242
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit f5855d24da35de6bb4f7d197b57490e009ed075f
Author: Anuradha Talur <atalur@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd : Introduce reset brick
The command basically allows replace brick with src and
dst bricks as same.
Usage:
gluster v reset-brick <volname> <hostname:brick-path> start
This command kills the brick to be reset. Once this command is run,
admin can do other manual operations that they need to do,
like configuring some options for the brick. Once this is done,
resetting the brick can be continued with the following options.
gluster v reset-brick <vname> <hostname:brick> <hostname:brick> commit {force}
Does the job of resetting the brick. 'force' option should be used
when the brick already contains volinfo id.
Problem: On doing a disk-replacement of a brick in a replicate volume
the following 2 scenarios may occur :
a) there is a chance that reads are served from this replaced-disk brick,
which leads to empty reads. b) potential data loss if next writes succeed
only on replaced brick, and heal is done to other bricks from this one.
Solution: After disk-replacement, make sure that reset-brick command is
run for that brick so that pending markers are set for the brick and it
is not chosen as source for reads and heal. But, as of now replace-brick
for the same brick-path is not allowed. In order to fix the above
mentioned problem, same brick-path replace-brick is needed.
With this patch reset-brick commit {force} will be allowed even when
source and destination <hostname:brickpath> are identical as long as
1) destination brick is not alive
2) source and destination brick have the same brick uuid and path.
Also, the destination brick after replace-brick will use the same port
as the source brick.
Change-Id: I440b9e892ffb781ea4b8563688c3f85c7a7c89de
BUG: 1266876
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12250
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 3c9797a081c17321d1a8dd71cc7070ed43c7d118
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:15:22 2016 -0400
posix: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Ibb3057cc072097434350c1dd2139b18610295825
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15257
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 0aa15022711d7691c0537f09d2ca0ff2554be5f0
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Id6f7555e35fd2bc37e8b9f81ac37d5384624501c
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15285
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit c5d07b6999b8d9d99618695d9f70801345137e40
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I4ce4ec8073c1da4ea60bf5488b3f57c91c4cffa6
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15284
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit 8189a9826ea6a0a6568251b7a143afb14995a634
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Ibe060202efb1f175a4348ff0927a7b44303d96e6
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15283
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 6c0283a3cb30183eb6f66da8b6791bfce14c8ea0
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (snapshot-utils): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I5d3372de16a1e03a6391885434ffea84f6a00412
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15277
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit b291d5ed2da5ecf0704c8cb8a4013e36b10c8dd9
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (replace-brick): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I58aede09a2f2c65a438188d7319ad7a61395e7a9
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15274
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 1de9d7da02213b85ea15ae3a9e1a5de1ae15c8ff
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (rebalance): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I136cf4c1d318f98933f3bfed81e2de3da0f56abc
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15273
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 937100186658cff52c5ace9c723a22baa5a1f2af
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (peer-utils): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I99e818d71e72aaa2dfb629f00a5245365f582b99
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15270
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit c5c6935a26065ff92fdad4b81e5a67bcdfc2c8c0
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:02 2016 -0400
glusterd (hooks): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I401090b0c51c90cf148c75756408c70ccee6a5e6
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15267
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 70e8e1ecdeea7b9f85950b6fd607c39904e6d13b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:02 2016 -0400
glusterd (handshake): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I25b40c89d883d088e4aaba87ce0bf235a09a27da
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15266
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
commit 5dcf983a2102b1de0cb8a2020c767fcdd285fba6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:02 2016 -0400
glusterd (bitd-svc): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I1a96cd72fce6b109769f11f17b625fe152298888
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15260
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit eac82e3ca332acfc32a3ddb73350f71a2acbd6e2
Author: ankit <anraj@redhat.com>
Date: Wed Aug 24 21:34:35 2016 +0530
rpc: dead code fix
CID: 1357866
Change-Id: I117cfd455b05df8d2bd9c8df4a081ffe4d053d09
BUG: 789278
Signed-off-by: ankit <anraj@redhat.com>
Reviewed-on: http://review.gluster.org/15310
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: ankitraj
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c0727c15a7c600c809699f512fdc0da96f012912
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
core: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Id9bf5732f8c94824769409f7895be9dbe6fbd5fa
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15249
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Susant Palai <spalai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b84a7e11bea40a37f6c27c8935313e19a3c5514e
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
core: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I3d8a7a3de35058aa97eab59d3f59208396298b03
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15246
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit d67c8a13100a31004c51a79b4cf814aae82f21f2
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
bit-rot: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I566fcbcae5aec575bfca40975b941c53546d4d97
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15245
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit d11ad8758d8bb19e7af8652814bbde338522010c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
afr: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I98e3308a2548ae095048caa99c86edec15b5e782
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15241
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit ef2ae69f75c5d7ce6202798c07c79b9092016715
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:02 2016 -0400
glusterd (ganesha): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I8496b0d1158aeac88cdee991e40c5bb1705f1c09
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15262
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 8a62317cba215b374896a43025ba5910bc36e040
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:02 2016 -0400
glusterd (store): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I9de669261b91e89a719997b54adeea893f8c3bee
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15264
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit ed2e07a5cfe2c2ee971b2d707f2dda2e5642d57e
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:31:28 2016 -0400
shard: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I3e53f12371b002d7f2fe2e281b63794c7769f823
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15258
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 1e93785b7bfaf49d428665b44061c2cf5af60b97
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (quota): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Id1bc618261a73d91847f65cb790109fda9e77c65
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15271
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
commit ec3d2a8828a6fc5ab9c15538cc28d686953d458e
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Aug 29 12:40:48 2016 +0530
glusterd: Fix msgid in mountbroker logs
Fix declared but not used msgid in mountbroker
logs.
Change-Id: I68d331f2741726624f647a8bc437e1ebcddd038f
Signed-off-by: Kotresh HR <khiremat@redhat.com>
BUG: 1346138
Reviewed-on: http://review.gluster.org/15333
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 548f44a16318f984f59aaadfd9228a86cf4d8f39
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Aug 24 09:55:32 2016 +0530
upcall: Add permission change flag to iatt flag
Currently IATT_UPDATE_FLAGS is (UP_NLINK | UP_MODE | UP_OWN | UP_SIZE |
UP_TIMES | UP_ATIME). But it should also have UP_PERM and permission bits
are apart of IATT.
This change will have no effect on the existing users as
IATT_UPDATE_FLAGS is currently used only by md-cache. And the changes in
md-cache to consume cache invalidation is not part of any release yet.
Change-Id: I7efad44972add152f5f981d733fb8191dc7ef8ef
BUG: 1369432
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15301
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 90d0a6734a5c94c3f112dfb51ee03d4fd8938f54
Author: Ryan Ding <ryan.ding@open-fs.com>
Date: Wed Aug 24 00:24:30 2016 +0800
features/upcall: segment fault while join thread reaper_thr in fini()
reaper_thr thread may not be started according to option
'cache-invalidation', if it's not started, join it in fini will cause a
segment fault.
Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
BUG: 1369524
Signed-off-by: Ryan Ding <ryan.ding@open-fs.com>
[ndevos: check .reaper_init_done and make it a boolean]
Reviewed-on: http://review.gluster.org/15298
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit c1cc4f6da3d3535baa4cb7ab7796d8d2f9020fdc
Author: Nigel Babu <nigelb@redhat.com>
Date: Tue Jul 26 18:55:16 2016 +0530
Clean up the failed-buids.py script
* Use the Jenkins API instead of looking up every job.
* Unify the output function with Pystache
* Mostly follow pep8 guidelines and make the script more pythonic
Change-Id: Ia5e0061638732e293e94b3a8ad9e25a7db65cfa5
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: http://review.gluster.org/15034
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b042b220484d7ffd8cb39a8309d89545f826d7f8
Author: Muthu-vigneshwaran <mvignesh@redhat.com>
Date: Thu Aug 11 17:07:29 2016 +0530
cli,rpc : Removing logically dead code
CID = 1357865, 1357866
Change-Id: I05eb345e9357d889872d259a600759392b188bb3
BUG: 789278
Signed-off-by: Muthu-vigneshwaran <mvignesh@redhat.com>
Reviewed-on: http://review.gluster.org/15148
Tested-by: Muthu Vigneshwaran
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
commit c0fa008d4c451064a75010f88e329c2169d47b46
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
core: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I16e55ad7afbddaee0d0e30acf1480e42adf96da4
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15243
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 16797a25d2c270c245d42ae3efc0cd18a0a3f712
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
rpc: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I20d91091bee0bf8f198a307ebba4b284bc3817ff
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15240
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 08004d2c6b9c4643f52e01854ee18e26fce4de54
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
jbr: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I68c210f3bcc0f7754a89095c0d1408d57d5bd4a2
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15244
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5cf2c74f10cdd75da5028f0aeba33bd233d478fc
Author: Poornima G <pgurusid@redhat.com>
Date: Sun Aug 21 17:14:06 2016 +0530
io-stats: Add ipc fop for display in the profile info
Change-Id: I959899ac00b3019ed45bd0127c4dc9a27a74bcb9
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15224
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c11421517b9b115fb6a4021d95376e558965c2ac
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed Aug 17 17:47:08 2016 +0530
extras: kill gsyncd before glusterfsd
It's a good practice to kill gsyncd before brick process, else we see
unnecessary loops and logs of bring up the faulty bricks
Change-Id: I2d2176f2bf5014f3afd622194a8b2d60c86926af
BUG: 1367771
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/15187
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 167a8451e52874b0668711a8e74ef5dfce90793a
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed Aug 17 17:31:17 2016 +0530
extras: kill processes gracefully
Currently all of brick, gsyncd and other glustershd services/processes
are killed without checking for ongoing tasks such as geo-rep,
self-heal, rebalance and etc. which may lead to inconsistency after
the node is brought back.
This patch introduce an option '-g' which ensures whether all the
gluster processes are ready (not busy) to be terminated before we
executing 'kill' on them
Usage: ./extras/stop-all-gluster-processes.sh [-g] [-h]
options:
-g Terminate in graceful mode
-h Show this message, then exit
eg:
1. ./extras/stop-all-gluster-processes.sh
2. ./extras/stop-all-gluster-processes.sh -g
By default, this script executes in force mode, processes are killed
without checking for ongoing tasks, on specifying '-g' option this
script works in graceful mode, which returns exitcode if some of gluster
processes are busy in doing their jobs.
exitcodes include:
0 No errors/Success
64 Rebalance is in progress
65 Self-Heal is in progress
66 Tier daemon running on this node
127 option not found
Change-Id: I2f924b2bf9f04a81788d0f5604895a42755b33a1
BUG: 1367771
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/15188
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 2f6f02eaad600b4ab477ff8706c687410e5ca2b6
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Aug 24 14:02:08 2016 +0530
packaging/eventsapi: Make Python site-packages variable global
Python site-packages path is assigned when glupy is enabled.
Eventsapi will not work as expected if glupy is disabled using
./configure --disable-glupy.
With this patch, all the Python variables are moved out of glupy
and used inside it.
systemd services will fail if we import gluster.cliutils python library
which is installed in /usr/local/lib/python.2.7/site-packages or some
other location. With this patch, Environment variable is added in
systemd service file.
BUG: 1369721
Change-Id: I9416240f03889e3bbcb4cd375e27c784fa9ca277
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15305
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0d0c5b4c59b8476b17ec0683e409275645af1199
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Aug 2 15:33:34 2016 +0000
gfapi: SSL connection for mgmt connection is not working
Problem: libgfapi does not enable SSL on mgmt connection.
Fix: Enable SSL when it is enabled on mgmt connection is enabled,
i.e. presence of /var/lib/glusterd/secure-access file
Change-Id: I1ce4935b04e6140aeab819e42076defd580b0727
BUG: 1362602
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/15073
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit a2c67220a07fb6e0b3c0eb3ab11390172e57c6a0
Author: Anuradha Talur <atalur@redhat.com>
Date: Thu Aug 25 12:19:16 2016 +0530
tests: change EXPECT_WITHIN timeouts
Use defined HEAL and PROCESS_UP timeouts rather than
hard code them in self-heald.t.
Change-Id: I21586811904c8417b7208bb643f14dff20dc4832
BUG: 1370074
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/15316
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6fe5f7f93119d385981bf39134a156fab3d821e3
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Sat Aug 27 20:24:20 2016 +0530
dht: define GF_IPC_TARGET_UPCALL
In patch http://review.gluster.org/#/c/15225/
GF_IPC_TARGET_UPCALL was used but not defined,
because of which build is broken
Hence fixing it here.
Change-Id: I81e1e63cba25a49fd72a8fd7a3b4a445cadae103
BUG: 1370862
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/15331
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 7b479c0f67642380605a29fe1553b900436de28a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
cli: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Ifc33762cf62259961ceb35ae9ac3cbec7094b703
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15238
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1cb26aa199e19c965792d205fb7af4c083575d79
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
glusterd: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Ib37642dc8d35dd1065398fc53c97de65869d5681
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15239
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit bc7d77cc811446b35881c436f3cb794d06846c2a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:02 2016 -0400
glusterd: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Id3577872ef720787796f7bfe6772734a3b26fef0
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15286
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 656058d46c7474f98eec77ef5bd7789142008715
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Jul 29 15:03:47 2016 +0530
md-cache: Fix wrong cache time update for xattrs
In md-cache, the cache has two times:
1. Time when the stat was last fetched for that inode
2. Time when the xattrs were last fetched for that inode. This
time should not be updated when only one of the xattrs is updated.
If, its updated when one of the cached xattr is changed, it can so
happen that the other xattrs have past their cache timeout, but are
still served from cache.
Solution:
Do not update the xattr cache time, when one of the xattrs being cached
is changed. With this, we may end up in cache timeout though it was
updated recently, but it is not a harm. The other way is to have
timeout for every xattr that is being cached. Its more complicated, and
may be not worth it, as we have lot of lookup fops, that are overloaded to
get all the xattrs.
Change-Id: Id77e547f403fc792348f1ea56b468b9260a5a34f
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15045
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 43a5f0bc67578d642eacb4430711af293efba81b
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Jul 18 21:19:34 2016 +0530
dht: Implement ipc fop
ipc is used by md-cache to communicate the list of xattrs that
it is caching, to the upcall xlator. Hence implement this in
dht, such that it winds to all the bricks if the ipc op is
GF_IPC_MDC_TARGET_UPCALL. The ips should not fail if any of
the bricks is down, as md-cache will replay the ipc late when
the brick comes back up.
Change-Id: Ica551a550c04cbb1240c0d211fe831c2e5eb6017
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15225
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 68977d5d703bcb45c7cccdf3a7990d3c1de42702
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Aug 25 10:25:24 2016 +0530
md-cache: Do not use features.cache-invalidation for both md-cache and upcall
Currently, the volume set option features.cache-invalidation enables upcall
feature on server side and md-cache cache-invalidation on client side.
There are multiple problems that can arise from this:
1. The scenario when user wants to, enable upcall for nfs-ganesha setup,
but do not want to enable md-cache cache-invalidation, as the
nfs-clients have already cached the metadata and upcall is used to
to invalidate the nfs-client cache. In this case, users should have
a way of disabling md-cache invalidation without disabling upcall.
2. Upcall requires a op-version of GD_OP_VERSION_3_7_0, where as
md-cache invalidation requires an op version of GD_OP_VERSION_3_9_0.
Consider a setup where the servers are in op-version GD_OP_VERSION_3_7_0,
and th clients are in op-version GD_OP_VERSION_3_9_0. if there is one
single volume set option, user can enable this feature in this setup.
But it can lead to stale xattr cache as the xattr invalidation was
introduced in upcall only in release 3.8. Hence, we should not be
able to enable md-cache invalidation, if all the servers and clients
are not on opversion >= GD_OP_VERSION_3_9_0.
To solve the above mentioned issues, we have seperate volume options
for enabling md-cache invalidation and upcall. But this can lead to
issues when user enable md-cache invalidation and forgets to enable
upcall. Probably in the next release, these can be enables by default.
Change-Id: Ie70eff97fe12fcb623eec8f4f5861ac065bf483e
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15314
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 795ccaf1e128cea96eaa11ed947aef7241514858
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:15:14 2016 -0400
protocol/server: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I5a48055c4b0a4a07dd511ad4f2e9ef823b9c60b2
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15255
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5f45b23b761fe6dec201049e21e8f42f2ad5115d
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Aug 17 12:55:37 2016 +0530
md-cache: Add cache hit and miss counters
These counters can be accessed either by .meta interface
or statedump.
From meta: cat on the private file in md-cache directory.
Eg: cat /mnt/glusterfs/0/.meta/graphs/active/patchy-md-cache/private
[performance/md-cache.patchy-md-cache]
stat_hit_count = 2
stat_miss_count = 8
xattr_hit_count = 4
xattr_miss_count = 3
nameless_lookup_count = 1
negative_lookup_count = 0
stat_invalidations_recieved = 1
xattr_invalidations_recieved = 1
Change-Id: Ib62a8822f263a9f75858b15832d0119fbe382629
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15185
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit f4c33f8adb619dcbfc212a7eaf8ccf30172cf971
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
quota: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Ic5c1e20468d47ccb5243b8e99f946fd31eb737b8
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15250
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit e0b49dbef9804317f1ee842bccc8942b6ccdd7a6
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Aug 8 17:02:37 2016 +0530
geo-rep: Post process Data and Meta Changelogs
With this patch, Data and Meta GFIDs are post processed. If Changelog has
UNLINK entry then remove from Data and Meta GFIDs list(If stat on GFID is
ENOENT in Master).
While processing Changelogs,
- Collect all the data and meta operations in a temporary database
- Delete all Data and Meta GFIDs which are already unlinked as per Changelogs
(unlink only if stat on GFID is ENOENT)
- Process all Entry operations as usual
- Process data and meta operations in batch(Fetch from Db in batch)
- Data sync is again batched based on number of changelogs(Default 1day
changelogs). Once the sync is complete, Update last Changelog's time as last_synced
time as usual.
Additionally maintain entry_stime on Brick root, ignore Entry ops if changelog
suffix time is less than entry_stime. If data stime is more than entry_stime,
this can happen only when passive worker updates stime by itself by getting
mount point stime. Use entry_stime = data_stime in this case.
New configurations:
max-rsync-retries - Default Value is 10
max-data-changelogs-in-batch - Max number of changelogs to be considered in a
batch for syncing. Default value is 5760(4 changelogs per min * 60 min *
24 hours)
max-history-changelogs-in-batch - Max number of history changelogs to be
processed at once. Default value 86400(4 changelogs per min * 60 min * 24
hours * 15 days)
BUG: 1364420
Change-Id: I7b665895bf4806035c2a8573d361257cbadbea17
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15110
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d8a78f07e33121876c61a5574e7ed6f5956784c9
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Thu Jul 7 20:33:02 2016 +0530
glusterd/cli: cli to get local state representation from glusterd
Currently there is no existing CLI that can be used to get the
local state representation of the cluster as maintained in glusterd
in a readable as well as parseable format.
The CLI added has the following usage:
# gluster get-state [daemon] [odir <path/to/output/dir>] [file <filename>]
This would dump data points that reflect the local state
representation of the cluster as maintained in glusterd (no other
daemons are supported as of now) to a file inside the specified
output directory. The default output directory and filename is
/var/run/gluster and glusterd_state_<timestamp> respectively. The
option for specifying the daemon name leaves room to add support for
other daemons in the future. Following are the data points captured
as of now to represent the state from the local glusterd pov:
* Peer:
- Primary hostname
- uuid
- state
- connection status
- List of hostnames
* Volumes:
- name, id, transport type, status
- counts: bricks, snap, subvol, stripe, arbiter, disperse,
redundancy
- snapd status
- quorum status
- tiering related information
- rebalance status
- replace bricks status
- snapshots
* Bricks:
- Path, hostname (for all bricks these info will be shown)
- port, rdma port, status, mount options, filesystem type and
signed in status for bricks running locally.
* Services:
- name, online status for initialised services
* Others:
- Base port, last allocated port
- op-version
- MYUUID
Change-Id: I4a45cc5407ab92d8afdbbd2098ece851f7e3d618
BUG: 1353156
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: http://review.gluster.org/14873
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 3325d12ecf3ee34f37c9935348b28ec9f2832d86
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Fri Aug 26 13:49:32 2016 +0530
build: fix eventtypes.h generation
make 'eventtypes.py' as dependent i.e. must build eventtypes.h
Else the consequence will be like:
error: 'EVENT_CLIENT_GRACE_TIMER_START' undeclared (first use in this function)
Change-Id: I5fe2491d8d1e0c430b307026695d25475250ae79
BUG: 1370406
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/15327
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit babc41e4bdabe2102a3ae63d3d8fc7e3d2304693
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Jul 13 11:38:10 2016 +0530
glusterd/ganesha : create export configuration file in shared storage
This is the second patch which moves export related configuration for
a volume into shared storage. The main change includes in scripts
create-export-ganesha.sh, dbus-send.sh and the handling of volume set
command "ganesha.enable". The manipulation of EXPORT_ID move from
dbus-send.sh to create-export-ganesha.sh.
In volume set handling following has performed
stage | commit
----------------------------------------------------------
1.) gluster v set <volname> ganesha.enable on
None | create export file
| in node where cli executed,
| thne export volume via dbus
2.) gluster v set <volname> ganesha.enable off
unexport volume via dbus | remove export file from the
| shared storage
-----------------------------------------------------------
More details can be found at http://review.gluster.org/#/c/15105/
Change-Id: Ia8b0e89bc8fff24b0bc5d20a538a89212894a8e4
BUG: 1355956
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14908
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit ce31a96e2f58b465a5aeacb79d177d3a45596d33
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Jul 13 12:09:43 2016 +0530
ganesha/scripts : Modifying ganesha-ha.sh for share storage related changes
Currently the ganesha related configurations are "scp"ied for operations like
add, delete, refresh-config in ganesha-ha.sh. This is no more required since
all the conf files are available in shared storage and every node can directly
access them from shared storage.
More details can be found at http://review.gluster.org/#/c/15105/
Change-Id: Ic025eb4dc246db61d6fbe969ca60214751fbf3ba
BUG: 1355956
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14909
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 8cd970aadc89a8967b0217e41c9b5fd4e3cc862f
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Jul 12 17:23:03 2016 +0530
Revert "glusterd-ganesha : copy ganesha export configuration files during reboot"
This reverts commit f71e2fa49af185779b9f43e146effd122d4e9da0.
Reason:
As part of sync up node reboot this patch copies ganesha export conf file
from a source node. This change is no more require if the export files are
available in shared storage.
Change-Id: Id9c1ae78377bbd7d5d80aa1c14f534e30feaae97
BUG: 1355956
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14907
Reviewed-by: soumya k <skoduri@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 2f4c003f2a21a6155907f0aec32683860cc59546
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:02 2016 -0400
glusterd: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I212abb47d9f35922b3f8253137ebab6841a53eed
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15261
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 4d8b4d06dbb65c7d9e7150649ea1f018fd55631a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (mgmt): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: Ia98f2934b179145398895600a3f34dbff841c3bd
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15268
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 5545e4fc621371ce383b411a694473a2730acd00
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (quotad-svc): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I186bdee9f7f72251f552a95a0c08a9be9aec7c83
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15272
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 9813abb6095adf077037e4c3b7ee9ddbe08d8d6b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (rpc-ops): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I65e6f8cdae150a796da485d9840838c4306b623b
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15275
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 65b92af779bc1eef47dfb44de8e309a95d287f90
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (statedump): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I92970f7b7c2a881ba5678dbf1f0bd2bf6c68f4db
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15279
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit abf81a41b66f47e86aa4861daa3b61f02b4de089
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 13:22:03 2016 -0400
glusterd (syncop): fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I40da2a344be3da4bda2370b1ae1eb77dc00b033e
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15281
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit d899499daa3f3bd0e39bcf9991770cbf57310f3d
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Jun 27 15:08:25 2016 +0530
ganesha/scripts : remove 'HA_VOL_SERVER' from the code
The parameter HA_VOL_SERVER introduced intially ganesha-ha.conf to
specify gluster server from which to mount the shared data volume.
But after introducing new cli for the same purpose, it become
unnecessary. The existence of that parameter can lead confussion
to the users. This patch will remove/replace all the instance of
HA_VOL_SERVER from the code
Change-Id: I638c61dcd2c21ebdb279bbb141d35bb806bd3ef0
BUG: 1350371
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14812
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit a5509cb0c83439f583ccffbf1f9c447a3a1c12a0
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Aug 25 22:20:30 2016 +0530
glusterd: Improve mountbroker logs
When Mountbroker mount fails, it was just returning
EPERM or EACCESS without logging exact failure.
This patch improves the logging by logging exact
failure.
Change-Id: I3cd905f95865153f70dfcc3bf1fa4dd19af16455
BUG: 1346138
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/15319
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 679d97688bf91db027dff8c2f1ccb93b6a7b7710
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Aug 5 09:03:22 2016 +0530
feature/bitrot: Ondemand scrub option for bitrot
The bitrot scrubber takes 'hourly/daily/biweekly/monthly'
as the values for 'scrub-frequency'. There is no way
to schedule the scrubbing when the admin wants it.
Ondemand scrubbing brings in the new option 'ondemand'
with which the admin can start scrubbing ondemand.
It starts the scrubbing immediately.
Ondemand scrubbing is successful only if the scrubber
is in 'Active (Idle)' (waiting for it's next frequency
cycle to start scrubbing). It is not entertained when
the scrubber is in 'Paused' or already running.
Here is the command line syntax.
gluster volume bitrot <vol name> scrub ondemand
Change-Id: I84c28904367eed827a7dae8d6a535c14b28e9f4d
BUG: 1366195
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/15111
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 67d1da6b07330a67b35df1d7239549b5c0137e04
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Aug 17 16:44:55 2016 +0200
gfapi: do not cache upcalls if the application is not interested
When the volume option 'features.cache-invalidation' is enabled, upcall
events are sent from the brick process to the client. Even if the client
is not interested in upcall events itself, md-cache or other xlators may
benefit from them.
By adding a new 'cache_upcalls' boolean in the 'struct glfs', we can
enable the caching of upcalls when the application called
glfs_h_poll_upcall(). NFS-Ganesha sets up a thread for handling upcalls
in the initialization phase, and calls glfs_h_poll_upcall() before any
NFS-client accesses the NFS-export.
In the future there will be a more flexible registration API for
enabling certain kind of upcall events. Until that is available, this
should work just fine.
Verificatio of this change is not trivial within our current regression
test framework. The bug report contains a description on how to reliably
reproduce the problem with the glusterfs-coreutils.
Change-Id: I818595c92db50e6e48f7bfe287ee05103a4a30a2
BUG: 1368842
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15191
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit dc6945345f4e6778c14b04f0c15a4b325c0d3a27
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Jul 12 15:44:23 2016 +0530
glusterd/ganesha : Move ganesha-ha.conf and ganesha.conf to shared storage
Currently all the ganesha related configuration files(ganesha.conf,
ganesha-ha.conf, export files, etc) is stored locally at /etc/ganesha
on a every node in ganesha cluster. Usually we end up in two issues by
doing so :
* difficult in modifiying ganesha related conf file
* diffciult to maintain consistency of conf file across ganesha cluster
To tackle this, we plan to move all the ganesha configuration to shared
storage. As a first step in this patch ganesha.conf and ganesha-ha.conf
move to shared storage. Here actual ganesha.conf will resides in shared
stoarge and symlinks will be created in /etc/ganesha when the option
"gluster nfs-ganesha enable" is executed and remove those during the
"disable" part.
Modified prerequisites to done before running globaloption:
* enable shared storage
* create nfs-ganesha folder in shared storage
* create ganesha.conf and ganesha-ha.conf in it
More details can be found at http://review.gluster.org/#/c/15105/
Change-Id: Ifabb6c5db50061f077a03932940190af74e2ca7f
BUG: 1355956
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14906
Reviewed-by: soumya k <skoduri@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ba60542c492165bfdbaa6e0fbaa0612a2418e760
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Aug 24 21:01:05 2016 +0530
cluster/ec: Use locks for opendir
Problem:
In some cases we see that readdir keeps winding to the brick that doesn't have
any blocked locks i.e. first brick. This is leading to the client assuming that
there are no blocking locks on the inode so it won't give away the lock. Other
clients end up blocked on the lock as if the command hung.
Fix:
Proper way to fix this issue is to use infra present in
http://review.gluster.org/14736 This is a stop gap fix where we start taking
inodelks in opendir which goes to all the bricks, this will detect if there is
any contention.
BUG: 1346719
Change-Id: I91109107a26f6535b945ac476338e9f21dc31eb9
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15309
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
commit a8887af6161700cf94b9c92618be235fab9150e7
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:11:24 2016 -0400
core: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I866d811e448067405af5b797eb9914c9c5e855cb
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15248
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit ad4bbd17b1340c5faf7f2ef74c9ec635c75f72c5
Author: Muthu-vigneshwaran <mvignesh@redhat.com>
Date: Mon Aug 22 16:53:59 2016 +0530
quota: add quota events
The patch targets to capture quota related events which are
important to be notified.
Change-Id: Iba440d675b11c346faab4c23260899d05296d8a7
BUG: 1368931
Signed-off-by: Muthu-vigneshwaran <mvignesh@redhat.com>
Reviewed-on: http://review.gluster.org/15235
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Manikandan Selvaganesh <mselvaga@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit c614208d70b178a2810b369d0b7375d80070ef51
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri May 6 12:26:29 2016 +0530
quotad: fix potential buffer overflows
This converts sprintf to gf_asprintf in following components: * quotad.c
* dht
* afr
* protocol/client
* rpc/rpc-lib
* rpc/rpc-transport
Change-Id: If8a267bab3d91003bdef3a92664077a0136745ee
BUG: 1332073
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/14102
Tested-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
commit a74b36729c396ecc5eaf50a2cd6eb16274025b95
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:14:33 2016 -0400
upcall: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I887aa033f00ab67f73c7d7a7f1b3054d43bffc49
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15252
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0d1cf2b82cfadb4188e76e3eccdc6dee0d06e5d7
Author: yanping.gao <yanping.gao@xtaotech.com>
Date: Wed Aug 24 06:47:49 2016 +0000
features/locks: fix fdctx leak in locks xlators
Problem:
Locks xlators is leaking fdctx in pl_release when
inode_ctx_get return non-zero
Fix:
This patch fixes fdctx leak in pl_release path
Change-Id: Icd5c5c681b7d890e7971b3b06d4258a51d45097d
Signed-off-by: Yanping.gao <yanping.gao@xtaotech.com>
Reviewed-on: http://review.gluster.org/15302
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 3be40faca299286f38b9d948601a9cd9922701e7
Author: Ryan Ding <ryan.ding@open-fs.com>
Date: Wed Aug 24 00:41:13 2016 +0800
protocol/server: readlink rsp xdr will fail while readlink got an error
set gfs3_readlink_rsp.path with an empty string while error happen, to
make xdr_gfs3_readlink_rsp happy. otherwise the original errno will be
lost, and return an rpc internal errno instead.
Change-Id: I36655b66df8b9f164e5bd21eb17244722c2f5a52
BUG: 1369530
Signed-off-by: Ryan Ding <ryan.ding@open-fs.com>
Reviewed-on: http://review.gluster.org/15299
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit b6c076637dcd71144fd04c8bb01ef4fe4b4cb757
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Aug 4 00:41:16 2016 +0530
cluster/ec: Do multi-threaded self-heal
BUG: 1368451
Change-Id: I5d6b91d714ad6906dc478a401e614115c89a8fbb
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15083
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 709d1a415f2f6dcc9d6e77484bb71642f6cb6b37
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Aug 22 12:43:19 2016 +0530
quota/cli: add user driven quota events
This patch targets to capture all the user driven quota related events
which are important to be notified.
Change-Id: I90c0af434363465e9dbdf6fca65ac220251d8d3c
BUG: 1368931
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/15230
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 2b2c0b066a9dfb93a640ef6076ecd080585d761b
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Aug 18 14:51:44 2016 +0530
eventsapi: Fix disable-events issue
Events related sources are not loaded in libglusterfs when
configure is run with --disable-events option. Due to this
every call of gf_event should be guarded with USE_EVENTS macro.
To prevent this, USE_EVENTS macro was included in events.c
itself(Patch #15054)
Instead of disabling building entire directory "events", selectively
disabled the code. So that constants and empty function gf_event is
exposed. Code will not fail even if gf_event is called when events is
disabled.
BUG: 1368042
Change-Id: Ia6abfe9c1e46a7640c4d8ff5ccf0e9c30c87f928
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15198
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 4e3a67bb849b9ccbe688de7789704963a1e49e8a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Aug 23 12:51:57 2016 +0530
arbiter: Fix memleak in arbiter_inode ctx
Problem:
The iattbuf ptr stored in arbiter's inode context was not freed during inode
forget.
Fix:
Change it to a statically allocated value so that we don't have to deal
with allocating/freeing it.
Change-Id: Id1b73b8aee1fb5c4174d0734bd20e168432b1abd
BUG: 1369331
Reported-by: Benjamin Edgar <benedgar8@gmail.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15289
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit bf79fe507272f340cf3f9af0ed4a96f21f8396cf
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Aug 8 13:11:29 2016 -0400
logging: Avoid re-initing log level in io-stats
If log level is already set via api or command line, initialization of
io-stats xlator overwrites the log level to GF_LOG_INFO. This patch
prevents re-initialization of log level if already set.
Change-Id: I1f74d94ef8068b95ec696638c0a8b17d8d71aabe
BUG: 1368882
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reported-by: Colin Lord <clord@redhat.com>
Reviewed-on: http://review.gluster.org/15112
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 1c7f45f973987514be6e05586b29edd135e93f1d
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Aug 12 10:22:17 2016 +0530
glusterd: add async events (part 2)
Change-Id: I7a5687143713c283f0051aac2383f780e3e43646
BUG: 1360809
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15153
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
commit c1f33010b3b4c8f899c11ace703dbb851e2c3c90
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Aug 17 13:08:41 2016 +0530
build: add dependency for psmisc for fuse
Add package dependency for psmisc for client package fuse
for the killall utility. killall is referenced in the gluster
logrotate config file.
Change-Id: I4cc95fe4aaa52faf8f384b9834654d3d928c252d
BUG: 1367665
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/15184
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 2ff43dbe6699bab2d6f773965349a0b1ce930c48
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 22 12:15:04 2016 -0400
nfs: fix unused variable warnings/errors
http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.
However 14085 won't pass the smoke test until all the warnings are
fixed.
Change-Id: I0e872a8025c3b1b5e2aa15d8fe66248e2fd96bf1
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15253
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ab323bdb9ca65f074776dd43cf6564f8ba0060fd
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Apr 12 12:26:54 2016 +0530
snapshot/cli: Fix snapshot status xml output
snap status --xml errors out if a brick is down and
doesn't have pid. It is handled in the cli of the snap
status where "N/A" is displayed in such a scenario.
Handled the same in xml
snap status <snapname> --xml fails as the writer is
not initialised for the same. Using GF_SNAP_STATUS_TYPE_ITER
instead of GF_SNAP_STATUS_TYPE_SNAP for all snap's
status to differentiate between the two scenarios.
Added testcase volume-snapshot-xml.t to check
all snapshot commands xml outputs
Change-Id: I99563e8f3e84f1aaeabd865326bb825c44f5c745
BUG: 1325831
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/14018
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 2492ceec569ffef17967e8bde2c898c645e55bcb
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jul 27 16:28:44 2016 +0530
snapshot: Display number of snapshots in volume info
Display number of snapshots in a volume in volume info
output. This number gets modified, with create, delete,
and restore operations.
Change-Id: Ic9b7c2b6950980f8ce75ca362998c097ea7c863d
BUG: 1360693
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/15029
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 37659962fa69387ef04fb8d88d42b7fa0285b6a4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Aug 16 16:04:37 2016 +0530
cluster/afr: Give option to do consistent-io
Problem:
When tiering/rebalance does migrations and afr with 2-way replica is in
picture, migration can read stale data if the source brick goes down and writes
to the destination. After this deletion of the file leads to permanent loss of
data after migration.
Fix:
Rebalance/tiering should migrate only when the data is definitely not stale. So
introduce an option in afr called consistent-io which will be enabled in
migration daemons.
BUG: 1306398
Change-Id: I750f65091cc70a3ed4bf3c12f83d0949af43920a
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13425
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 5cb8af42967f8112c87949f7a9666ada8cdad4ba
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Aug 22 13:59:01 2016 +0530
tests: fix volfile_server_switch.t spurious failure
1. Unnecessary self probe is removed
2. After every probe a peer_count check is added to give the test to time finish
handhake.
Change-Id: Iab52548f8b781e7968250cd98fdbeaf02472970d
BUG: 1368953
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15231
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ed23d5022ef433de596042ac32b2d533de6d1a55
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Aug 18 12:36:37 2016 +0530
tests: Remove explicit mention of include location
This hopefully fixes the spurious failures with
error: glusterfs/api/glfs.h No such file or directory
build.gluster.org/job/rackspace-regression-2GB-triggered/22897/consoleFull
BUG: 1365489
Change-Id: Ic3660de810c0daee7284373bbfaed172aba86d69
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15194
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 79ad594ce704eadc7df8c3c7c566dbef1a0e703b
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jul 26 16:01:56 2016 +0530
glusterd: Add async events
As the eventing framework is already in the code, this patch targets to capture
all the async glusterd events which are important to be notified to the higher
layers which consume the eventing framework.
I plan to break this work into two different patches where this patch set covers
the first set of events.
Change-Id: Ie1bd4f6fa84117b26ccb4c75bc4dc68e6ef19134
BUG: 1360809
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15015
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rohan Kanade <rkanade@redhat.com>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
commit c7db0ab2cfc1f550c59e97d68c7d9f8ff148902d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jul 28 21:29:59 2016 +0530
cluster/afr: Prevent split-brain when bricks are brought off and on in cyclic order
When the bricks are brought offline and then online in cyclic
order while writes are in progress on a file, thanks to inode
refresh in write txns, AFR will mostly fail the write attempt
when the only good copy is offline. However, there is still a
remote possibility that the file will run into split-brain if
the brick that has the lone good copy goes offline *after* the
inode refresh but *before* the write txn completes (I call it
in-flight split-brain in the patch for ease of reference),
requiring intervention from admin to resolve the split-brain
before the IO can resume normally on the file. To get around this,
the patch does the following things:
i) retains the dirty xattrs on the file
ii) avoids marking the last of the good copies as bad (or accused)
in case it is the one to go down during the course of a write.
iii) fails that particular write with the appropriate errno.
This way, we still have one good copy left despite the split-brain situation
which when it is back online, will be chosen as source to do the heal.
Change-Id: I9ca634b026ac830b172bac076437cc3bf1ae7d8a
BUG: 1363721
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15080
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Oleksandr Natalenko <oleksandr@natalenko.name>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a27474fa17e517b878180ad3d94ab8ac0ca5a5ce
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Aug 19 14:13:51 2016 +0530
tests/cli: Generate SSL certificates
Generate SSL certificates before enabling
management encryption to avoid test failure.
Change-Id: Iab23b36703f4653f1d5bb9d14695e4d3fa63ad61
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
BUG: 1368349
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/15202
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit d19f97ae60f6540d47825f792f6149a5cc8398c6
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Aug 17 19:52:29 2016 +0530
eventsapi: Bitrot events
Following Bitrot Events are added
BITROT_ENABLE/BITROT_DISABLE
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": EVENT_TYPE,
"message": {
"name": VOLUME_NAME,
}
}
BITROT_SCRUB_THROTTLE/BITROT_SCRUB_FREQ/BITROT_SCRUB
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": EVENT_TYPE,
"message": {
"name": VOLUME_NAME,
"value": OPTION_VALUE
}
}
EVENT_BITROT_BAD_FILE
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": EVENT_TYPE,
"message": {
"gfid": GFID_OF_FILE,
"brick": BRICK_ROOT,
"path": FILE_PATH_FROM_BRICK_ROOT (if available)
}
}
Change-Id: I8c37b0e9db9f4f0f3d05d8f78b5521c7db0e2237
BUG: 1367815
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/15190
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 36cfd9a4ea2ac84f37c6e10f96db058070c2001f
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Aug 16 12:14:43 2016 -0400
core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)
gnu glibc (libc) in Fedora 26 (rawhide) has turned off "compat" for
makedev(), major(), and minor(3) decls.
3.8.2 on F26 built with warnings, see:
https://kojipkgs.fedoraproject.org//packages/glusterfs/3.8.2/1.fc26/data/logs/x86_64/build.log
More recent builds of other packages (namely nfs-ganesha) indicate
that these warnings would now be errors, and, will be errors when
3.8.3 is released and built.
Change-Id: I3caa0d05f5de695818753e40e754da8b40d2011c
BUG: 1367527
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/15182
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 38c15511f9ce1d671b5d3678fbc1af328ede46b8
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Jul 18 15:17:49 2016 +0530
quota: change the log level from warning to info
Change-Id: Icac7d87bb6c5ecc813528690e03c821bbe3789b5
BUG: 1357463
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/14940
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cdafd37aca920622b1e4692373c0cd391e85856c
Author: Anuradha Talur <atalur@redhat.com>
Date: Tue Aug 9 21:09:11 2016 +0530
protocol/client: Unserialize xdata even if lookup fails
Problem:
AFR relies on xdata returned by lookup to determine if
there are any files that need healing. This info is further
used to optimize readdirp.
In case of lookups with negative return value, client
xlator was sending NULL xdata. Due to absence of xdata,
AFR conservatively assumes that there are files that
need healing, which is incorrect.
Solution:
Even in case of unsuccessful lookups, send the xdata received
by protocol client so that higher xlators can get the info
that they rely on.
Change-Id: Id3a1023eb536180888eb2c0b39050000b76f7226
BUG: 1366284
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/15120
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: Poornima G <pgurusid@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 904deab9bc3b3abb901e0d00aaa65edcba6fdfc1
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Tue Aug 16 16:46:41 2016 +0530
glusterd: Fix volume restart issue upon glusterd restart
http://review.gluster.org/#/c/14758/ introduces a check in
glusterd_restart_bricks that makes sure that if server quorum is
enabled and if the glusterd instance has been restarted, the bricks
do not get started. This prevents bricks which have been brought
down purposely, say for maintainence, from getting started
upon a glusterd restart. However this change introduced regression
for a situation that involves multiple volumes. The bricks from
the first volume get started, but then for the subsequent volumes
the bricks do not get started. This patch fixes that by setting
the value of conf->restart_done to _gf_true only after bricks are
started correctly for all volumes.
Change-Id: I2c685b43207df2a583ca890ec54dcccf109d22c3
BUG: 1367478
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: http://review.gluster.org/15183
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 21661cf1b95896e0d7a03529476b7225ae1bae61
Author: Ekasit Kijsipongse <ekasit.kijsipongse@nectec.or.th>
Date: Wed Jun 24 16:12:19 2015 +0700
stripe: Fix wrong pathinfo in striped-replicated volume
Change-Id: I05b3ba6757d5b786daf7cb3a64e6ac6676e9c997
BUG: 1200914
Signed-off-by: Ekasit Kijsipongse <ekasit.kijsipongse@nectec.or.th>
Reviewed-on: http://review.gluster.org/11375
Tested-by: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d7dc08ca6361f00cc997f707f99e21c1133a2b41
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Aug 2 15:30:27 2016 +0000
socket: SSL_shutdown should be called before socket shutdown
SSL_shutdown shuts down an active SSL connection. But we
are calling this after underlying socket is disconnected.
Change-Id: Ia943179d23395f42b942450dbcf26336d4dfc813
BUG: 1362602
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/15072
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 0f584f6037854d8c49ff39dbf9f1ce271692cbee
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Aug 16 10:43:07 2016 +0530
storage/posix: Log EEXIST failures at DEBUG log-level
Change-Id: I56f160058d2e2751ca75f1f75ea8254a1b8a6bf3
BUG: 1367258
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15161
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 688c05917c8fc047f308897ebaf9b3765f477ecd
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Aug 2 14:51:23 2016 +0530
md-cache: Add logging to increase debuggability
Change-Id: I147d16ec3c20d3372892fdd5f62010e52f82f8bd
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15069
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit fe8eb15f90571d31696458950cdefa7216939b15
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Aug 2 16:17:36 2016 +0530
logging: Fix per xl log level
Currently per xlator loglevel setting doesn't work, due to the
flaw in loglevel checking. Fix the same.
Per xlator logging can be set using the below command:
Eg: setfattr -n trusted.glusterfs.patchy-md-cache.set-log-level -v TRACE /mnt/glusterfs/0
Change-Id: I8ff1d15bd5693b6f682d99bee22a4bbb5eee646c
BUG: 1362520
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15071
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 3b6f6fb1098cd36c7d840ee3763b29d759b4042e
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Aug 5 12:18:05 2016 +0530
cluster/afr: Bug fixes in txn codepath
AFR sets transaction.pre_op[] array even before actually doing the
pre-op on-disk. Therefore, AFR must not only consider the pre_op[] array
but also the failed_subvols[] information before setting the pre_op_done[]
flag. This patch fixes that.
Change-Id: I78ccd39106bd4959441821355a82572659e3affb
BUG: 1363721
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15145
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 71a48da70e16ae846c1d41fa6b80fbacb723ae28
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Aug 6 16:04:29 2016 +0200
libglusterfs: add gf_get_mem_type()
gfapi needs to provide a function towards applications to free memory
that it allocated. Depending on how the application is compiled/linked,
it could use a different memory allocator than Gluster itself. Therefore
it is not safe for gfapi to request applications to free memory with
'standard' free().
Examples for this are Gluster allocated structures with GF_CALLOC() when
memory accounting is enabled (the default). Some gfapi functions use
malloc() to allocate memory as a workaround, but the free() from the
jemalloc implementation should not be combined with the malloc() from
glibc.
Change-Id: I626cd1a60abf8965f9263290f4045d1f69fc2093
BUG: 1344714
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15108
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 3ec4d8b67bc433ecf09e3e2220dbe4a52ee005fb
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Aug 10 11:24:19 2016 +0530
libglusterfs: move alloca0 definition to common-utils
...and remove their definitons from EC and AFR.
Also `s/alloca+memset0/alloca0` wherever it is used.
Change-Id: I3b71e596d12a7d8900f5d761af6b98305c8874d5
BUG: 1366226
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15147
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ee0afbed2a085cc12facac5cf96524e0d63d54bd
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Aug 11 10:10:25 2016 +0000
glfsheal: print brick name and path even when brick is down
The xml variant of heal info command does not display brick name when
the brick is down due to a failure to fetch the hostUUID. But the non
xml variant does. So fixed the xml variant to print the remote_host
and remote_subvol even when the brick is down.
Change-Id: I16347eb4455b9bcc7a9b0127f8783140b6016578
BUG: 1366222
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15146
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit c033da4d51b120201326650e5e781f437f901aa4
Author: Muthu-vigneshwaran <mvignesh@redhat.com>
Date: Fri Aug 5 14:05:36 2016 +0530
rpc: fixing illegal memory access
CID:1357876
Change-Id: I34eee0bf0367f963ddf6e9d6b28b7d3a9af12c90
BUG: 789278
Signed-off-by: Muthu-vigneshwaran <mvignesh@redhat.com>
Reviewed-on: http://review.gluster.org/15094
Tested-by: Muthu Vigneshwaran
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b23f437b805c770f22d3ad6c4db2a7d7e871c6f3
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Aug 9 13:20:26 2016 +0300
gfapi: add missing glfs_truncate
Change-Id: I80b016090a4d9d86278a0a5144dd58c0cbfe9bb2
BUG: 1365489
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reviewed-on: http://review.gluster.org/13927
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit dce938b129be6f66174fef911522dd44649fba2b
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Tue Aug 9 15:53:27 2016 +0530
glusterd: Convert volume to replica after adding brick self heal is not triggered
Problem: After add brick to a distribute volume to convert to replica is not
triggering self heal.
Solution: Modify the condition in brick_graph_add_index to set trusted.afr.dirty
attribute in xlator.
Test : To verify the patch followd below steps
1) Create a single node volume
gluster volume create <DIS> <IP:/dist1/brick1>
2) Start volume and create mount point
mount -t glusterfs <IP>:/DIS /mnt
3) Touch some file and write some data on file
4) Add another brick along with replica 2
gluster volume add-brick DIS replica 2 <IP>:/dist2/brick2
5) Before apply the patch file size is 0 bytes in mount point.
BUG: 1365455
Change-Id: Ief0ccbf98ea21b53d0e27edef177db6cabb3397f
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15118
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a0610dd02b54e91e5f725fc05231ffa493255160
Author: Oleksandr Natalenko <oleksandr@natalenko.name>
Date: Tue Aug 9 14:58:08 2016 +0300
gfapi: use const qualifier for glfs_*timens()
glfs_*timens() functions have the last argument
of struct timespec type that is supposed to be
const. Now using glfs_*timens() in fops, implemented
on top of FUSE library, leads to compiler-time warning
about discarding const qualifier.
Introducing const qualifier does not break ABI,
so let's just fix it.
Change-Id: Iea2a1018de7dce67f67a8229671a5978246de800
BUG: 1365506
Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reviewed-on: http://review.gluster.org/15119
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 885df0de3a08bda10275c9d816fcc74b014ce115
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Jul 19 15:20:09 2016 +0530
gfapi: Fix IO error caused when there is consecutive graph switches
This is part 2 of the fix, the part 1 can be found at:
http://review.gluster.org/#/c/14656/
Problem:
=======
Consider a race between, __glfs_active_subvol() and graph_setup().
Lets say @TIME T1:
fs->active_subvol = A
fs->next_subvol = B
__glfs_active_subvol() //under lock fs->mutex
{
....
new_subvol = fs->next_subvol //which is B
.... //Start migration from A to B
__glfs_first_lookup(){
....
unlock fs->mutex //@TIME T2
network fop
lock fs->mutex
....
}
.... //migration continue on B
fs->active_subvol = fs->next_subvol //which is C (explained below)
....
}
@Time T2, lets say in another thread, graph_setup() is called with C,
note that at T2, fs->mutex is unlocked.
graph_stup(C...)
{
lock fs->mutex
....
if (fs->next_subvol) // which is B
destroy subvol (fs->next_subvol)
....
fs->next_subvol = C
....
unlock fs->mutex
}
Thus at the end of this,
fs->old_subvol = A;
fs->active_subvol = C;
fs->next_subvol = NULL;
which is wrong, as B completed migration, but was destroyed by
graph_setup, and C never was migrated.
Solution:
=========
Any new graph can be in one of the 2 states:
- Picked for migration, migration in progress (fs->mip_subvol)
- Not picked so far for migration (fs->next_subvol)
graph_setup() updates fs->next_subvol only, __glfs_active_subvol()
moves fs->next_subvol to fs->mip_subvol and fs->next_subvol = NULL
atomically, and then once the migration is complete, make that the
fs->active_subvol
Change-Id: Ib6ff0565105c5eedb912a43da4017cd413243612
BUG: 1343038
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14722
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 40c2d343f10b2afd0fae952cedcfa1244ed17dc9
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Aug 4 16:00:31 2016 +0530
inode: Adjust lru_size while retiring entries in lru list
As part of inode_table_destroy(), we first retire entries
in the lru list but the lru_size is not adjusted accordingly.
This may result in invalid memory reference in inode_table_prune
if the lru_size > lru_limit.
Change-Id: I29ee3c03b0eaa8a118d06dc0cefba85877daf963
BUG: 1364026
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/15087
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit a3c077d9857acd61045ad289cc427741c5821f6c
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Mar 10 13:45:52 2016 +0530
georep: tests for logrotate, create+rename, hard-link rename
* log rotate
eg. with rotate count as 2 and with the following files created
x.log, x.log.1 and x.log.2, another iteration of logrotate results in
the following operations to be performed
x.log.2 is renamed to x.log.3
x.log.1 is renamed to x.log.2
x.log is renamed to x.log.1
x.log.3 is deleted
x.log is created [possible gfid allocated that belonged to x.log.3]
when a file is created, there's a big possibility that a gfid used
earlier can be reassigned and reused. This causes RENAME operations
to fail on slave nodes when logs are replayed, typically on a Georep
restart.
A function called logrotate_simulate has been added to tests/geo-rep.rc
to help simulate this situation. Starting from a clean state,
logrotate_simulate has to be called 4 times with a rotate count of 2
to help the logs roll over and cause a delete at the end and a gfid
reallocation.
With the bug-fix in place, this test should not cause the Georep
session to go into a Faulty state.
* create+rename
On log replay after Georep restart, a create+rename causes an entry
to be created for the original file, but it cannot be linked to the
gfid back-end since it is associated with the renamed file before
the Georep restart.
A function create_rename simulates the create+rename scenario and
the function create_rename_ok tests if the dangling entry is present
at the slave mount.
With the bug-fix in place, a dangling entry with the original name
should not be found at the slave mount after logs are replayed after
a Georep restart.
* hard-link rename
This case is similar to the create+rename case except that this is
a case of renaming hard-link to one of its other names.
A function hardlink_rename has been added to tests/geo-rep.rc which
simulates the creation and rename of hard-link. After a Georep session
restart, the test function hardlink_rename_ok should not find the
source link name on the slave.
With the bug-fix in place, this test should not fail.
If changelogs have been enabled on the slave as well, then the logs
should show an UNLINK entry for the source link name, since a rename
operation of a hard link to one of its names essentially just drops
the source name as per the 'mv' command semantics.
Change-Id: I85b196c00cf79a11bada25ef2fe5f1dc5c0c858a
BUG: 1316389
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/13663
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 228fa4386a5c5423623ed542474e40a7b72d7ad3
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Aug 1 16:59:33 2016 +0530
features/libgfchangelog: Log failure in gf_histroy_changelog
Add error logs if gf_history_changelog fails. If requested
changelog range is not available, log the error and exit
instead of continuing the loop and exiting in readdir
without logging. Also fixed the duplicate MSGID number in
'changelog-lib-messages.h'
Change-Id: Icd71b89ae23b48a71380657ba5649029c32fabfd
BUG: 1362151
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/15064
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 5782ef398a20002609e77fea3de90b0825006151
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Aug 1 17:16:50 2016 +0530
eventsapi: Python library for gf_event
Python library to emit Events from Geo-replication or any other Python apps
running in storage nodes.
Add $LIBEXEC/glusterfs/events to Python path to use gf_event
gf_event(event_type, **kwargs)
For example,
sys.path.insert(1, "LIBEXECDIR/glusterfs")
from events.gf_event import gf_event
from events import eventtypes
gf_event(eventtypes.GEOREP_FAULTY,
volname="gv1",
slaveuser="root",
slavehost="node1",
slavevol="gv2")
Errors will be logged in $LOGDIR/glusterfs/events.log
BUG: 1362144
Change-Id: I2af2bd77f9961975e4387006b9e99e4543e12b57
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15063
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 4eccc9a2536da15677a383b71b36dbb724633ac8
Author: Jiffin Tony Thottan <jthottan@gmail.com>
Date: Thu Mar 17 18:53:13 2016 +0530
glusterd : skip non directories inside /var/lib/glusterd/vols
Right now glusterd won't come up if vols directory contains an invalid entry.
Instead of doing that with this change a message will be logged and then skip
that entry
Change-Id: I665b5c35291b059cf054622da0eec4db44ec5f68
BUG: 1318591
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/13764
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 1224afdae9d4b8c788b55a9adcfc086397da7aaa
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Jul 27 15:49:25 2016 +0530
posix: Do not move and recreate .glusterfs/unlink directory
Problem:
At the time of start of a volume, it is checked if
.glusterfs/unlink exist or not. If it does, move it
to landfill and recreate unlink directory. If a volume
is mounted and we write data on it till we face ENOSPC,
restart of that volume fails as it will not be able to
create unlink dir. mkdir will fail with ENOSPC.
This will not allow volume to restart.
Solution:
If .glusterfs/unlink directory exist, don't move it to
landfill. Delete all the entries inside it.
Change-Id: Icde3fb36012f2f01aeb119a2da042f761203c11f
BUG: 1360679
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/15030
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit c36362f6212c4ae9717fd246aa5af4b278cbfd12
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jul 19 12:55:03 2016 +0200
build: systemd unit should not be marked executable
systemd complains about the unit for GlusterD when it is executable:
Configuration file /usr/lib/systemd/system/glusterd.service is marked executable. Please remove executable permission bits. Proceeding anyway.
The Makefile that installs the unit has some scripted commands. These
are not needed and standard "*dir" and "*DATA" postfixes for variables
can be used instead.
The EXTRA_DIST variable is needed for building the 'make dist' tarball
on systems where there is no systemd. The unit would be missing from the
tarball if it is not explicitly included.
BUG: 1354489
Change-Id: I5e72ec201036906b9b2458bc8931ccebf9a8c6b4
Reported-by: Sergej Pupykin <ml@sergej.pp.ru>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14892
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 18e5aea32fa8837f85cd581e6737c688678b8b27
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Aug 5 13:27:26 2016 +0200
build: correct date in the %changelog
Building RPMs failed for me because of an incorrect date in the
%changelog in the .spec. It seems that rpmlint identifies is as well:
$ rpmlint glusterfs.spec
... (snipped non critical errors)
glusterfs.spec: E: specfile-error warning: bogus date in %changelog: Wed Jul 15 2016 Aravinda VK <avishwan@redhat.com>
Changed the date in the .spec to the date of the latest version (v16) of
the patch that adds eventing (commit 5ed781ecf).
BUG: 1334044
Change-Id: I5ef5003e227a83479f24103fc67139d7287fbc39
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/15099
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 93748279d019c58f17d3d07d6eca189bc6f320d3
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Aug 5 11:22:18 2016 +0000
posix: honour fsync flags in posix_do_zerofill
commit 6d994661db96cad43f26d0d1e2fba31dce9a76f5 introduced fallocate +
FALLOC_FL_ZERO_RANGE to do posix_do_zerofill but did not do an fsync if
O_SYNC or O_DSYNC fd flags were set. Prashant Pai pointed out performing
fallocate(2) does not remove the necessity to do fsyncs if durability is
desired: http://linux-fsdevel.vger.kernel.narkive.com/bDmrAUlh/fallocate-falloc-fl-punch-hole
So fixed it to honour the fd flags.
Change-Id: I27ae90b429185d0af29a5e632c4a8b242075a899
BUG: 1364449
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15100
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 1bcf5d4c52b61a59bcba355613432ce4cf39a41b
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Aug 2 11:59:42 2016 +0530
meta: fix memory leak in meta xlators
meta xlator is leaking iobuf and iobrefs in read path
This patch fixes memleak in meta_default_read code path
Change-Id: Ieb413267604d9870dbe6e11258fffd279a7bd7cf
BUG: 1362397
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/15068
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
commit aba41ca4758244ee31b374748c8029460e36d5f4
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Jul 29 12:20:11 2016 +0530
md-cache/upcall: In case of mode bit change invalidate xattr
When the mode bits are changed, the ACL entries also do get affected.
Currently in upcall, setattr invalidates only the stat info.
With this patch, if mode bits are changed, the upcall will invalidate
all the xattrs.
Change-Id: Iccda2e1a7440ee845aa5442bf51970f74d9b0862
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15043
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 36fa050ab3cf5b1eaea2a7a43f1e28bba07efe42
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Aug 4 11:51:27 2016 +0530
tests: fix spurious failure in tests/bugs/glusterd/bug-1089668.t
Instead of rebalance stop, its always better to wait for rebalance to complete
as the former doesn't have any purpose.
Change-Id: Ia1bc2a34d937a0a96543bebd257dcda619f12474
BUG: 1363948
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15085
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 24d813127a2285a9935cfa2215bd31814b437da1
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue May 31 16:44:48 2016 +0530
libglusterfs: fix glusterd statedump crash
commit 3c04a91 removed setting typeStr to NULL if num_allocs is set to 0, this
has caused this regression. Code has been put back like earlier and to avoid
statedump printing all the NULL values check is modified to see skip the records
if num_allocs is 0 instead of total_allocs
Change-Id: Ib8bcc2fba908e88cf52b641c3f6bcba74f5e667c
BUG: 1359190
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14987
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ba50dd6c7f88d4e57cd08c41068a4773b7e0ecca
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Aug 1 12:11:24 2016 +0530
xlators/ganesha : Remove the ganesha xlator code entirely from source
ganesha xlator is dummy xlator which introduced as part of cli options.
But all the ganesha related cli commands are handled from glusterd only.
There is no point in keeping this xlator. Hence removing the same since
it does not have any role in NFS-Ganesha intergration with gluster
Change-Id: Id438d2fabd3afe7e91ae26522df8495c8e9e9308
BUG: 1361999
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/15055
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 380ae2b82ebc9e5c47cdada5fad5efee9ade42c1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jul 29 21:55:58 2016 +0530
mgmt/glusterd: Enable client-io-threads by default
BUG: 1361678
Change-Id: Ic013a772ffc3f8c93673bbee064ff4cc372fe128
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15051
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit d586bf8123cd5441097d0ad1600ef358a4f8d95f
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Aug 3 12:16:43 2016 +0530
eventsapi: Geo-replication User driven events
Following Geo-replication Events are added
GEOREP_CREATE/GEOREP_START/GEOREP_STOP/GEOREP_DELETE/GEOREP_PAUSE/GEOREP_RESUME
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": EVENT_TYPE,
"message": {
"master": MASTER_VOLUME_NAME,
"slave": SLAVE_DETAILS
}
}
GEOREP_CONFIG_SET
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": GEOREP_CONFIG_SET,
"message": {
"master": MASTER_VOLUME_NAME,
"slave": SLAVE_DETAILS,
"option": OPTION_NAME,
"value": OPTION_VALUE
}
}
GEOREP_CONFIG_RESET
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": GEOREP_CONFIG_RESET,
"message": {
"master": MASTER_VOLUME_NAME,
"slave": SLAVE_DETAILS,
"option": OPTION_NAME
}
}
BUG: 1363591
Change-Id: I78c81aabd022ebb042b3eae3c6b5a284a6c2801f
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15077
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit bdddaa14dd9aa688528b64067e379a3c368dc4c8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Aug 2 15:19:00 2016 +0530
cluster/afr: copy loc before passing to syncop
Problem:
When io-threads is enabled on the client side, io-threads destroys the
call-stub in which the loc is stored as soon as the c-stack unwinds.
Because afr is creating a syncop with the address of loc passed in
setxattr by the time syncop tries to access it, io-threads would have
already freed the call-stub. This will lead to crash.
Fix:
Copy loc to frame->local and use it's address.
BUG: 1361678
Change-Id: I16987e491e24b0b4e3d868a6968e802e47c77f7a
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15070
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 1d141ba7f8bbe8d7a7bb9605cb9f5b3f682edcd4
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jul 25 19:09:08 2016 +0530
glusterd: clean up old port and allocate new one on every restart
GlusterD as of now was blindly assuming that the brick port which was already
allocated would be available to be reused and that assumption is absolutely
wrong.
Solution : On first attempt, we thought GlusterD should check if the already
allocated brick ports are free, if not allocate new port and pass it to the
daemon. But with that approach there is a possibility that if PMAP_SIGNOUT is
missed out, the stale port will be given back to the clients where connection
will keep on failing. Now given the port allocation always start from base_port,
if everytime a new port has to be allocated for the daemons, the port range will
still be under control. So this fix tries to clean up old port using
pmap_registry_remove () if any and then goes for pmap_registry_alloc ()
Change-Id: If54a055d01ab0cbc06589dc1191d8fc52eb2c84f
BUG: 1221623
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15005
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
commit 38c5a6f82ca992e60b6698c6f6c2c35764ed95df
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Jul 8 12:30:25 2016 +0530
commn-HA: Add portblock RA to tickle packets post failover(/back)
Portblock resource-agents are used to send tickle ACKs so as to
reset the oustanding tcp connections. This can be used to reduce
the time taken by the NFS clients to reconnect post IP
failover/failback.
Two new resource agents (nfs_block and nfs_unblock) of type
ocf:portblock with action block & unblock are created for each
Virtual-IP (cluster_ip-1). These resource agents along with cluster_ip-1
RA are grouped in the order of block->IP->unblock and also the entire
group maintains same colocation rules so that they reside on the same
node at any given point of time.
The contents of tickle_dir are of the following format -
* A file is created for each of the VIPs used in the ganesha cluster.
* Each of those files contain entries about clients connected
as below:
SourceIP:port_num DestinationIP:port_num
Hence when one server failsover, connections of the clients connected
to other VIPs are not affected.
Note: During testing I observed that tickle ACKs are sent during
failback but not during failover, though I/O successfully
resumed post failover.
Also added a dependency on portblock RA for glusterfs-ganesha package
as it may not be available (as part of resource-agents package) in
all the distributions.
Change-Id: Icad6169449535f210d9abe302c2a6971a0a96d6f
BUG: 1354439
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/14878
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 51af0e5a6b118e3168bcde71bc05cc78ba17ef37
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Sat Jul 23 14:33:17 2016 +0530
gfapi: fix glfs_set_volfile_server doc
Gluster supports volume file fetching over transports tcp and unix only.
The current glfs_set_volfile_server() doc misleads by mentioning rdma,
which is removed by this patch.
More about the discussion around @
http://www.gluster.org/pipermail/gluster-devel/2016-July/050114.html
Change-Id: I08cfe262fb9a82cb341f6adbe93594c8e628b7fe
BUG: 1359370
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14995
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5a903107eda8948ec94fd68f8851904cc5e6e5f5
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Aug 1 11:56:27 2016 +0530
events: move conditional macro check USE_EVENTS inside gf_events
Change-Id: I88279b11b648e676a4544bbb55c7466fbc55ffa7
BUG: 1361983
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/15054
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 39cfee04b2bae211bbddfd395550d2d1d54b616e
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jul 28 15:49:59 2016 +0530
eventsapi: Auto generate header files during make
$SRC/libglusterfs/src/eventtypes.h and $SRC/events/src/eventtypes.py are
generated by running `python $SRC/events/eventskeygen.py`
Header files generation step is added to make file itself, Now All new
events should be added to only to $SRC/events/eventskeygen.py file.
BUG: 1361094
Change-Id: I384961ef2978ca2d0be37f288b39ac0d834bdf06
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/15035
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit c2330c524757e8e9fdef3192a80c373e3eb1672a
Author: root <root@dhcp35-131.lab.eng.blr.redhat.com>
Date: Tue Jul 5 14:33:15 2016 +0530
glusterd: Fix memory leak in glusterd (un)lock RPCs
Problem: At the time of execute "gluster volume profile <vol> info" command
It does have memory leak in glusterd.
Solution: Modify the code to prevent memory leak in glusterd.
Fix : 1) Unref dict and free dict_val buffer in glusterd_mgmt_v3_lock_peer and
glusterd_mgmt_v3_unlock_peers.
Test : To verify the patch run below loop to generate io traffic
for (( i=0 ; i<=1000000 ; i++ ));
do echo "hi Start Line " > file$i;
cat file$i >> /dev/null;
done
To verify the improvement in memory leak specific to glusterd run below command
cnt=0;while [ $cnt -le 1000 ]; do
pmap -x <glusterd-pid> | grep total;
gluster volume profile distributed info > /dev/null; cnt=`expr $cnt + 1`; done
After apply this patch it will reduce leak significantly.
Change-Id: I52a0ca47adb20bfe4b1848a11df23e5e37c5cea9
BUG: 1352854
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/14862
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0df9feed122638aa3a1fd332668e19551a67f167
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Jul 7 15:55:07 2016 +0530
features/ganesha : remove ganesha xlator from client graph
The ganesha introduced in dummy xlator in the client graph, which is used
for introducing the cli options. When the volume set command "ganesha.enable"
ran, this xlator will add into client graph but never removed from it. In my
opinion there is no point in adding the ganesha xlator in the client graph
Change-Id: I926c4b4adf991361aa459679e275cb58246c5294
BUG: 1349270
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14871
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 79874cddfe847a454ec4c556d14c16a6c6e446f3
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jul 26 08:49:36 2016 -0400
io-stats: fix translator names
Change-Id: Icf5afaee8b7c704aecab7f8a8a1df9f1bc9288ce
BUG: 1360401
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/15016
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0208b35346bfa6598491ef8066acc4022bccdc03
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Jul 27 15:32:56 2016 +0530
gluster man page: Add output option "--xml" to man page of gluster
BUG: 1360670
Change-Id: Ia167bb5b541a12459f70ab1205bd4ffdab8c7e65
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15027
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d6d3afc88943fbfe24a4be6000685c69f9aeba95
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Jun 23 12:37:51 2016 +0530
cluster/tier: dont promote if estimated block consumption > hi watermark
Add test to fail promotion if estimated block consumption grows
beyond hi watermark.
Skip file migrations until next cycle if tier_get_fs_stat() fails
in tier_migrate_using_query_file()
Change-Id: Ice04572fa739c09109c4433e65965197482a7beb
BUG: 1349284
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/14780
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 871d5cf50b2ba8b4f1f8396be2e70884ceecb17c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Mar 31 10:54:10 2015 +0530
Snapshot/xml:xml output for snapshot clone
Snapshot clone is used to create a regular volume from snapshot.
Currently snapshot clone is not supporting xml outout.
This change introduce a xml output for snapshot clone command
Change-Id: I417b480d36f9d84ee088004999b041c9619edd50
BUG: 1207604
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10065
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 1d5e3be17361eef6a44dbe5da078b8f39501ad93
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Jul 25 19:58:01 2016 +0530
tests: Fix get_pending_heal_count check in ec
Continuation of http://review.gluster.org/#/c/14985.
Also renamed tests/bugs/disperse to tests/bugs/ec for a better
correlation to tests/basic/ec and xlators/cluster/ec
Change-Id: I662b3477c12af8a0b94597769e8f00f354b1168c
BUG: 1332054
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15006
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit a33fbcf016c64170da9eac16a79b092f03109440
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jul 28 20:42:45 2016 +0530
posix: leverage FALLOC_FL_ZERO_RANGE in zerofill fop
posix_zerofill() implements zerofilling of a given (offset,length) by
doing a writev in a loop followed by an optional fsync on the file.
fallocate(2) has a FALLOC_FL_ZERO_RANGE flag which does away with all
this and provides the same result (from a userspace application point of
view) with a single syscall. This patch attempts the zerofill with the
latter and falls back to the former if it fails.
Tested using a libgfapi based C program on XFS and observed using gdb that
posix_zerofill()'s call to fallocate with FALLOC_FL_ZERO_RANGE was a
success.
Change-Id: I77e9b7de0d59c255f06b0c39c43a276990081727
BUG: 1361249
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15037
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 5e877774d1dc617eda20cc7f58e5159d239b42fa
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jul 28 22:37:38 2016 +0530
storage/posix: Look for file in "unlink" dir IFF open on real-path fails with ENOENT
PROBLEM:
In some of our users' setups, open() on the anon fd failed for
a reason other than ENOENT. But this error code is getting masked
by a subsequent open() under posix's hidden "unlink" directory, which
will fail with ENOENT because the gfid handle still exists under .glusterfs.
And the log message following the two open()s ends up logging ENOENT,
causing much confusion.
FIX:
Look for the presence of the file under "unlink" ONLY if the open()
on the real_path failed with ENOENT.
Change-Id: Ifb674dc7123f79fec9a9ac1ec7bf832f4df17627
BUG: 1361300
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/15039
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit f4db2535b441bf8b2bed1636b4dae66e00317054
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Jul 22 13:11:15 2016 -0400
io-threads: distribute work fairly among clients
This is the full "queue of queues" approach where each client gets its
own queue (per priority) and we round-robin among them.
Change-Id: I73955d1b9bb93f2ff781b48dfe2509009c519ec6
BUG: 1360402
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/14904
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 3590e3aee4f518eee443de5689a532bd012bc30b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jul 21 14:49:55 2016 -0400
io-threads: remove least-rate-limit option and code
This will be unnecessary, and mostly in the way, as real fairness
guarantees are implemented.
Change-Id: Ic61ec1c9e9add58385f1a4eafcfe2cc554ceefc8
BUG: 1360402
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/14989
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: Gluster Build System <jenkins@build.gluster.org>
commit 942ef90a42df12826e07e4009a527a604e64ef3c
Author: Susant Palai <spalai@redhat.com>
Date: Thu Jul 21 18:17:21 2016 +0530
dht/rebalance: allocate migrator thread pool dynamically
Problems: The maximum number of migratior threads created was static set
to "40". And the number of these threads get created in rebalance depends
on the number of cores user has. If the number of cores exceeds 40, a
crash or memory corruption can be seen.
Fix: Make the migratior thread pool dynamic.
Change-Id: Ifbdac8a1a396363dd75e2f6bcb454070cfdbf839
BUG: 1359711
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/15000
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit b422b0955e376e661a908aedc962f27f8554166d
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Jul 19 17:28:14 2016 +0530
eventsapi: Volume Set and Reset Events
Example of published data for Volume Set:
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": "VOLUME_SET",
"message": {
"name": VOLUME_NAME,
"options": [[KEY1, VALUE1], [KEY2, VALUE2],..]
}
}
Example of published data for Volume Reset:
{
"nodeid": NODEID,
"ts": TIMESTAMP,
"event": "VOLUME_RESET",
"message": {
"name": VOLUME_NAME,
"option": KEY
}
}
BUG: 1358671
Change-Id: If30cc95396459b2a9993b3412ee6d05d27f6a86a
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14973
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a7a6f0098fcc045e1ee6a1a0e4fc7e07cbbf48ab
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Jul 22 11:40:32 2016 +0530
snapshot/snapd: Don't display pid when snapd is offline
We were previously reading the pidfile, and displaying
the pid even if snapd daemon is not running. Now to fix
it, we re-assign pid value to -1, if snapd is offline.
Change-Id: I4baff8d489fe9380061c52aea006db90fa421cd7
BUG: 1358244
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/14981
Tested-by: Vijay Bellur <vbellur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c0e1536b7cf5b0d49fb1a2e13b4e47d0c1489846
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Jul 25 10:26:58 2016 +0530
tests: Fix the spurious failure in libgfapi-fini-hang.t
RCA:
After running libgfapi-fini-hang, there is a EXPECT_WITHIN which waits
for PROCESS_UP_TIMEOUT(20s), for the process libgfapi-fini-hang to die.
Currently EXPECT_WITHIN is returning success even if the process
libgfapi-fini-hang is alive. This is because "pgrep libgfapi-fini-hang"
in check_process() is returning 1(no process alive) even if the process
is alive. Man page of pgrep says "The process name used for matching is
limited to the 15 characters". Hence changing the name of executable from
libgfapi-fini-hang to gfapi-hang, so that it falls within the limit.
As explained the failure is not because there was a hang(logs show that
glfs_set_volfile_server was still executing), but because EXPECT_WITHIN
was not really waiting. And hence there was a race between the execution
of the process libgfapi-fini-hang and the kill.
Change-Id: I257715865e0d3e5a14f83d1e235c01899e1cae68
BUG: 1358594
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14997
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.org>
commit e8c4d19a709bb91210a8021e9d4e6e4ef999edfd
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed Jul 27 14:23:23 2016 +0530
gfapi: deprecate rdma support for management connections
RDMA transport was never supported for management connection before, but
glfs_set_volfile_server() allowed rdma transport type due to lack of defense
code and the glusterfs_mgmt_init() code silently fall back to tcp with out
any warnings, this gave a chance for assumtions that mgmt connection also
supports rdma along with tcp and unix.
This patch deprecates the rdma support by warning at its usage.
Change-Id: I0ad99d9851e05ff84ba4b6a3534a984bcc7e2ed7
BUG: 1360647
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/15026
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit d5304e3df076770cc6fe17cdc3bebf338799467e
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jul 27 15:58:35 2016 +0530
tests: Fix tests/bitrot/bug-1244613.t
Wait for gluster nfs to initialize before
attempting the nfs mount.
Change-Id: I4bd9579ad5368935cf62632a5d612f89fce5979f
BUG: 1360682
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/15028
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 14d2afe3c960c421e03b82435b3681cefe7a22c1
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed May 25 13:54:13 2016 -0400
cluster/tier: fix statfs for dht/tiered volumes
Return the correct size of the tiered volume in statfs. It should
be the size of the cold tier, not the sum of the hot and cold tier,
because the hot tier is a cache and not an extension of the volume's
capacity. The number of free blocks, etc is the cold tier's capacity
subtracted by the sum of utilization on the hot and cold tiers. Note
if both tiers are part of the same file system this must be accounted
for as well.
The patch also fixes a pre-existing bug in the DHT/tier
translators. If statfs was taken on a file, the code only calculated
free space on the cached subvolume, not all subvolumes in the replica
group. With the fix, this is corrected, except in the case
where quota is used with the deem-statfs option set to "on".
Change-Id: I2b8bcb4511edf83f12130960aad0a609fcf8f513
BUG: 1339689
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/14536
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit edac59a46edf5356d64f2a4f88dde2999c496403
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Aug 14 11:13:54 2015 +0200
README: improve readability and add a clickable link
It is easier to have a link that can be clicked.
Change-Id: Id0f75b3e68ca358c218e7f1f00769545dab0c058
BUG: 1193929
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11922
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c81d651e22381cf9cb963cddbf8c7ab3532a8345
Author: Prashanth Pai <ppai@redhat.com>
Date: Mon May 30 11:56:17 2016 +0530
tier: Suppress warning when tiering is disabled
Suppress -Wunused-function compile time warnings when tiering is
disabled with --disable-tiering.
BUG: 1193929
Change-Id: I396e03631606ce60a953ed5e124986ae2c803abd
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/14638
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.org>
commit 472ccb11ed901d832d95686938ce341da4cd6bc7
Author: Poornima G <pgurusid@redhat.com>
Date: Sat Jul 23 19:25:46 2016 +0530
extras: Change failed_tests.py to generate html output
Running failed-tests.py as a job in jenkins to send the regression
report periodically to gluster-devel. Hence, clean up some of the
argument parsing code and add support for html display of the output
Change-Id: Ic6daf87e3fa9b0ef8401d68cbd0010f166ea4961
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14996
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Nigel Babu <nigelb@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 3e275804e41d3e737427523e350ae884dd9ddef3
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Jul 12 10:07:48 2016 +0530
afr: some coverity fixes
Thanks to Krutika for a cleaner way to track inode refs in
afr_set_split_brain_choice().
Change-Id: I2d968d05b815ad764b7e3f8aa9ad95a792b3c1df
BUG: 1355604
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/14895
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit c1a9c0b9fa141bd20cd044141c9e6da2f4327675
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Sat Jul 23 06:59:09 2016 +0800
libglusterfs: add "_" to the name of parameter in macro code
Change-Id: I3daf10e2099a36f8ca8df35067ef9206f08fe7ef
BUG: 1358922
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: http://review.gluster.org/14990
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 258b14a7546dbe5354184f804ed7d73561e11277
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Jul 25 09:05:20 2016 -0400
infra: remove anti-typedef check
Linus's dislike of typedefs is one of his most idiosyncratic positions,
at odds with the mainstream of software engineering and practice.
There's no reason that quirk should have been imposed on this project,
which was done by fiat when we adopted a style checker written for a
very different audience and environment.
Change-Id: Ic08b0d14a0130ee88c3f60dcac07670d91004c2b
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/15004
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7ad1e74c01b2377596d59e555b5c222f8fda60c4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jan 6 14:30:08 2016 +0530
dict: Don't expose get_new_dict/dict_destroy
get_new_dict/dict_destroy is causing confusion where, dict_new/dict_destroy or
get_new_dict/dict_unref are used instead of dict_new/dict_unref.
Change-Id: I4cc69f5b6711d720823395e20fd624a0c6c1168c
BUG: 1296043
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13183
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 009125f08e0186ff28fe374027b148626c3e2cdb
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Jun 17 17:52:56 2016 +0530
cluster/ec: Handle absence of keys in some callback dict
Problem: This issue arises when we do a rolling update
from 3.7.5 to 3.7.9.
For 4+2 volume running 3.7.5, if we update 2 nodes
and after heal completion kill 2 older nodes, this
problem can be seen. After update and killing of
bricks, 2 nodes will return inodelk count key in dict
while other 2 nodes will not have inodelk count in dict.
This is also true for get-link-count.
During dictionary match , ec_dict_compare, this will
lead to mismatch of answers and the file operation
on mount point will fail with IO error.
Solution:
Don't match inode, entry and link count keys while
comparing two dictionaries. However, while combining the
data in ec_dict_combine, go through all the dictionaries
and select the maximum values received in different dicts
for these keys.
Change-Id: I33546e3619fe8f909286ee48fb0df2009cd3d22f
BUG: 1347686
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/14761
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit edbda62a9e8d1d81a570c0bf9bd10c8d23e7e972
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Jul 20 15:10:05 2016 +0530
features/ctr: Check for NULL local
This is a defensive fix to prevent a crash reported
during a rename operation. This is not reproducible
under normal circumstances.
This patch also moves ctr-messages.h to the src dir
of the changetimerecorder xlator.
Change-Id: I46eb926d67bf4c19387c8b26e354c635a5fb284c
BUG: 1358196
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/14964
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f8815b58578e2c133d97363fefa50787a303fde3
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Jul 25 16:23:06 2016 +0530
tests: Moving ./tests/bugs/snapshot/bug-1316437.t to bad test
Moving ./tests/bugs/snapshot/bug-1316437.t to bad test, while mulling
over the pros and cons of the fix. Will update the bug, as we go.
Sending this patch to unblock master.
Change-Id: Ia863312913686b4fa0ee0b63da13aedc0439a835
BUG: 1359717
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/15001
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b0e9ccc9bdfbb392416ddfbaf0a1579314c3cd91
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Jul 22 13:15:58 2016 +0530
gfapi/upcall: Fix a ref leak
inode_find (used to create the handle) takes a reference
of the inode. This needs to be un'refernced to avoid leak.
Change-Id: I22f03577a8f1d9608cfc62d57202cfc4c2ba12b3
BUG: 1358608
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/14984
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.org>
commit 6d92c2134c2e3ed50bf019adae9d958305988a25
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jul 22 20:24:51 2016 +0530
tests: Remove hard coding in get_aux
Change-Id: Ie007d8006a2f2be0187f0c73d46ec6dda2a68a6b
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14988
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit f3788307ce3e09c5ab7777f9cd0de7d80c3fa011
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jul 22 07:48:27 2016 +0530
tests: Fix spurious failures with split-brain-favorite-child-policy.t
Problem:
It is not guranteed that the self-heal daemon would apply the new option
as soon as volume set is executed because all the command gurantees is that
the process is notified of the change in volfile. Shd still needs to fetch
volfile and reconfigure. If the next volume heal command comes even before
the reconfigure happens, then the heal won't happen.
Fix:
Restart shd to make sure it has the option loaded with new value.
BUG: 1358976
Change-Id: I3ed30ebbec17bd06caa632e79e9412564f431b19
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14978
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 46e419f62ae8b50401adb87b1b85606e2abd94b7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jul 22 13:58:22 2016 +0530
tests: Fix pending-heal-count checks
EXPECT_WITHIN takes regular expression to match the count,
so even when there are say 10 entries to heal, it would
think that the heal is complete. Fixed checking
pending heal count with correct regex.
Thanks to Xavi for finding this problem.
Change-Id: Ic593d22468b2b586bfca864962ffa0eda96b1d1f
BUG: 1332054
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14985
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6e720a15630585d99f5be04ca57ae8684dcf1ea5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jul 22 10:25:49 2016 +0530
tests: Fix timing issue in ec.t
Problem:
Because of timing issue sometimes the mount is unmounted
even before the version is updated, this is leading to
not triggering heals.
Fix:
One way to fix this would be to increate 'sleep 2' to 'sleep 10'
but that would slow things down. I changed the way ec learns
it needs xattr healing so that it triggers heals even when the
xattrs are not marked correctly.
Change-Id: I1c82041166443ae7079dd99b89ea2ed170233ba3
BUG: 1359001
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14980
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2dbf28e2c95e57e6c4a2e72833b69193b1cd7af2
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jul 21 12:14:27 2016 +0530
glfs/upcall: entries should be removed under mutex lock
During poll, upcall entries should be removed from the
upcall_list only under upcall_list_mutex lock. Otherwise
it could result in the list corruption if there are entries
being added during poll resulting in memory leak.
Also addressed a probable leak during any failures with upcall
entry addition.
Change-Id: I468183f961eb6faed9a0a1bcb783705f711641fc
BUG: 1358608
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/14972
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit cd6fc929a4fc0c9135bf8fd440179b7575d0b58c
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Mar 7 11:45:07 2016 +0530
changelog/rpc: Fix rpc_clnt_t mem leaks
PROBLEM:
1. Freeing up rpc_clnt object might lead to crashes. Well,
it was not a necessity to free rpc-clnt object till now
because all the existing use cases needs to reconnect
back on disconnects. Hence timer code was not taking
ref on rpc-clnt object.
Glusterd had some use-cases that led to crash due to
ping-timer and they fixed only those code paths that
involve ping-timer.
Now, since changelog has an use-case where rpc-clnt
need to be freed up, we need to fix timer code to take
refs
2. In changelog, because of issue 1, only mydata was being
freed which is incorrect. And there are races where
rpc-clnt object would access the freed mydata which
would lead to crashes.
Since changelog xlator resides on brick side and is long
living process, if multiple libgfchangelog consumers
register to changelog and disconnect/reconnect mulitple
times, it would result in leak of 'rpc-clnt' object
for every connect/disconnect.
SOLUTION:
1. Handle ref/unref of 'rpc_clnt' structure in timer
functions properly.
2. In changelog, unref 'rpc_clnt' in RPC_CLNT_DISCONNECT
after disabling timers and free mydata on RPC_CLNT_DESTROY.
RPC SETUP IN CHANGELOG:
1. changelog xlator initiates rpc server say 'changelog_rpc_server'
2. libgfchangelog initiates one rpc server say 'libgfchangelog_rpc_server'
3. libgfchangelog initiates rpc client and connects to 'changelog_rpc_server'
4. In return changelog_rpc_server initiates a rpc client and connects back
to 'libgfchangelog_rpc_server'
REF/UNREF HANDLING IN TIMER FUNCTIONS:
Let's say rpc clnt refcount = 1
1. Take the ref before reigstering callback to timer queue
>>>> rpc_clnt_ref (say ref count becomes = 2)
2. Register a callback to timer say 'callback1'
3. If register fails:
>>>> rpc_clnt_unref (ref count = 1)
4. On timer expiration, 'callback1' gets called. So unref rpc clnt at the end
in 'callback1'. This is corresponding to ref taken in step 1
>>>> rpc_clnt_unref (ref count = 1)
5. The cycle from step-1 to step-4 continues....until timer cancel event happens
6. timer cancel of say 'callback1'
If timer cancel fails:
Do nothing, Step-4 would have unrefd
If timer cancel succeeds:
>>>> rpc_clnt_unref (ref count = 1)
Change-Id: I91389bc511b8b1a17824941970ee8d2c29a74a09
BUG: 1316178
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/13658
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2db5ce303e15dee3ff6a0ac3be9ec133fc717131
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Fri Jul 22 04:09:15 2016 +0800
core: coverity, NULL potinter check
iobuf_get_page_aligned should check the return pointer
after calling iobuf_get2.
CID: 1357868
Change-Id: I3aa5b09bce2225aa70cf3c60a6b6f4e4eca1dee6
BUG: 1358936
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: http://review.gluster.org/14976
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c80580bcedd98a5fb2b35ef66f0fface7b7ce8d4
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Thu Jul 21 21:36:23 2016 -0400
jbr: coverity, resource leak
Change-Id: I62428808ce52569ff0298b0fcdd07cbaec1621dc
BUG: 1358944
CID: 1357871
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: http://review.gluster.org/14977
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 3e3a64aaae4b3c57324f206810337c86efd15c01
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jul 21 08:12:04 2016 +0200
md-cache: fix indention to silence Coverity
Coverity complains about the incorrect indention:
*** CID 1357867: Control flow issues (NESTING_INDENT_MISMATCH)
...
2566 if (conf->mdc_invalidation)
2567 ret = mdc_invalidate (this, data);
>>> CID 1357867: Control flow issues (NESTING_INDENT_MISMATCH)
>>> This 'if' statement is indented to column 25, as if it were nested within the preceding parent statement, but it is not.
2568 if (default_notify (this, event, data) != 0)
2569 ret = -1;
2570 break;
...
Even when md-cache does not have cache-invalidation on, we need to pass
the upcall to the next xlator.
Change-Id: I6d2a174eb54e3df270920aae9673b5010c235f25
CID: 1357867
BUG: 1211863
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14971
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3cd4de1d8661602e7860e39e14093cd1053e5e96
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jul 20 11:36:31 2016 +0530
tests: Fix spurious failure of br-stub.t
The nfs mount fails occasionally in ./tests/bitrot/br-stub.t.
The reason being nfs mount is attempted before the gluster
nfs has come up. It is a race and hence happens occasionally.
The patch fixes it by waiting for nfs server to come up
before mount.
Thanks skoduri@redhat.com for root causing it.
Change-Id: I3adbf2363514635785c02b1478733095ad0b74cf
BUG: 1358114
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14960
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 59af94a9240b0ed365629458636bc348bd05d73a
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jul 12 15:21:23 2016 +0530
feature/bitrot: Ignore files with sticky bit set
Scrubber scrubs entries in backend. It is scrubbing files with sticky
bit as well. This might include linkfiles which should be skipped. This
patch adds the check to ignore linkfiles during scrub.
Change-Id: Ic21367b37770d391326c55c659491a1e5a82335b
BUG: 1355706
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14903
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: NetBSD Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit f5f1a83a2034d4e07e80456ffd20d983d40bf717
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Jul 12 19:46:57 2016 +0530
extras: fix failed_tests.py to work
The text in the regression console output, now has the following prepended:
"<span class="timestamp"><b>08:27:48</b> </span>"
with every line. Hence changing all the instances where the entire line
was compared, to find the pattern in the line.
Also, another usability change to take centos/netbsd as an argument
instead of the regression link.
Change-Id: I1648ab90fa6d34bb8b82a0a33401c5a2ecb86426
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14914
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d47935d24e3023dfc19415c55942464b1a272e8a
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Jul 19 15:41:54 2016 +0530
eventsapi: Fix make install issue second time
If Symlink file $SBIN/gluster-eventsapi is not deleted,
make install was failing when run second time(Without uninstall)
With this patch, Symlink deleted before installing new symlink.
BUG: 1357821
Change-Id: I65e636f7b48ba9e81177f56c720ffc27e1f95fb3
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14954
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 8f8f471e895188fc5fc9225a722a2fdf07546ff9
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Jun 17 01:27:31 2016 -0400
tests: Enable all gfapi test cases
Change-Id: I32bfec4af91348d96dc3e81a9d5c9cad599f821b
Bug: 1358594
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14748
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 0b96679b550d91a142cc71a9c73bd8ecc6d3b6be
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Thu Jul 14 14:25:35 2016 +0530
glusterd/geo-rep: fix memory leak and minor fixes
Fix for memory leak and other issues revealed by coverity.
Change-Id: Ib66eaa3a1a086d4b487534cebc56af5e1f9bf576
BUG: 1356528
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/14925
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 82055bfe9ad821b0e6d2c29827ba4e925a5ba2a9
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jul 20 15:04:01 2016 +0530
tests: Fix spurious failure of tests/bugs/glusterd/bug-1111041.t
On a faster machine the ps check was returning two pids,
including the glusterfsd process's pid, right after that,
process forked. Hence removing that ps, as for the scope
of this test, verifying the snapd pid from the status
command itself is enough.
Change-Id: I8bd8fc4ea406d96e3a47f952cfe44560b615dbe6
BUG: 1358195
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/14963
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit a2f456c4e429c1ba4466a1ddb338dcfb49b80269
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri Jul 15 14:12:31 2016 +0530
rpc/socket.c : Modify socket code to avoid fd leak in case of socket_poller thread
Update socket code to avoid fd leak in case of socket_poller thread.
Change-Id: Ifa9718fbaf065988a299cda7ba0282dfd6b10a32
BUG: 1356888
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/14929
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 6636bbaaf321546ba3305df41c9e544660a26fa3
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Dec 11 05:12:07 2015 -0500
md-cache: Add cache invalidation support to invalidate the meta data cache
Problem:
md-cache currently updates its stat in cbks of selected fops.
The default cache time is 1 second, if this is increasd to reap the
benefits of caching, we may end up with stale cache for long time,
as there is no logic yet to notify md-cache of backend changes by
another client.
Solution:
Use the existing upcall mechanism to invalidate the cache.
For this feature to work, "features.cache-invalidation" volume
option should be enabled.
This patch as is doesn't improve any performance, the benifit of the
patch is that it provides coherency for stat cache, hence the cache
timeout can be quite longer which in turn can improve the performance.
Change-Id: I2dbb0afa7b5e4a5a248f910188e0918e02f18692
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/12951
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit e92a6025a91a9959b3b66abfddd56ad152dc3c90
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jul 14 12:30:12 2016 +0530
feature/bitrot: Fix scrub status with sharded volume
Bitrot scrubs each shard entries separately. Scrub
statistics was counting each shard entry which is
incorrect. This patch skips the statistics count
for sharded entries.
Change-Id: I184c315a4bc7f2cccabc506eef083ee926ec26d3
BUG: 1356851
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14927
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d970254198be617eac9709b6bc4ed7440e870b93
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Jul 18 11:12:43 2016 +0530
xlator/trash : append '/' at the end in trash_notify_lookup_cbk
In the notify function in trash xlator, a lookup is performed
to obtain path of old trash directory. The result usually contains
path without '/' at the end. The trash xlator maintains expects
'/' at the end for the values such as 'old trash dir' and
'new trash dir'. Otherwise certian checks in the code will fail.
Change-Id: I89e02e4b249314fb6536297f959865feee182c83
BUG: 1357397
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14938
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 62a703d2b9fa366a07646fc088bb1ec21cfde42b
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Mon May 2 19:06:47 2016 +0530
geo-rep: address potential leak of memory
fix memory leak reported by clang analyzer:
gsyncd.c:411:17: warning: Potential leak of
memory pointed to by 'argv'
in main()
Change-Id: I179fb1c095cf4d331b5910df6388dc724cb4ac96
BUG: 1332419
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14151
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 0e12a5dd64ec6e8c0fc7df1f4c98f224308d0f96
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Jul 16 16:36:22 2016 +0200
build: fix sprintf format for uint64_t in gf_worm_serialize_state()
When building on 32-bit architectures, the following warning gets
reported:
worm-helper.c: In function 'gf_worm_serialize_state':
worm-helper.c:219: warning: format '%ld' expects type 'long int', but argument 4 has type 'uint64_t'
worm-helper.c:219: warning: format '%ld' expects type 'long int', but argument 5 has type 'uint64_t'
The format string "%ld" depend on the architecture. If the type is very
specific (here unint64_t), the dynamicness of "%ld" is not correct.
There are macros for these fixed types in <inttypes.h> and even some
more in "logging.h" from libglusterfs.
BUG: 1198849
Change-Id: I63eeb9c8e4d7b292ce0c9333938ca365db0823fc
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14934
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 56362017dcc12ddcac4cb39975e1ebc685b4d7ff
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu May 5 18:34:41 2016 +0530
eventsapi: Gluster Eventing Feature implementation
[Depends on http://review.gluster.org/14627]
Design is available in `glusterfs-specs`, A change from the design
is support of webhook instead of Websockets as discussed in the design
http://review.gluster.org/13115
Since Websocket support depends on REST APIs, I will add Websocket support
once REST APIs patch gets merged
Usage:
Run following command to start/stop Eventsapi server in all Peers,
which will collect the notifications from any Gluster daemon and emits
to configured client.
gluster-eventsapi start|stop|restart|reload
Status of running services can be checked using,
gluster-eventsapi status
Events listener is a HTTP(S) server which listens to events emited by
the Gluster. Create a HTTP Server to listen on POST and register that
URL using,
gluster-eventsapi webhook-add <URL> [--bearer-token <TOKEN>]
For example, if HTTP Server running in `http://192.168.122.188:9000`
then add that URL using,
gluster-eventsapi webhook-add http://192.168.122.188:9000
If it expects a Token then specify it using `--bearer-token` or `-t`
We can also test Webhook if all peer nodes can send message or not
using,
gluster-eventsapi webhook-test <URL> [--bearer-token <TOKEN>]
Configurations can be viewed/updated using,
gluster-eventsapi config-get [--name]
gluster-eventsapi config-set <NAME> <VALUE>
gluster-eventsapi config-reset <NAME|all>
If any one peer node was down during config-set/reset or webhook
modifications, Run sync command from good node when a peer node comes
back. Automatic update is not yet implemented.
gluster-eventsapi sync
Basic Events Client(HTTP Server) is included with the code, Start
running the client with required port and start listening to the
events.
/usr/share/glusterfs/scripts/eventsdash.py --port 8080
Default port is 9000, if no port is specified, once it started running
then configure gluster-eventsapi to send events to that client.
Eventsapi Client can be outside of the Cluster, it can be run event on
Windows. But only requirement is the client URL should be accessible
by all peer nodes.(Or ngrok(https://ngrok.com) like tools can be used)
Events implemented with this patch,
- Volume Create
- Volume Start
- Volume Stop
- Volume Delete
- Peer Attach
- Peer Detach
It is easy to add/support more events, since it touches Gluster cmd
code and to avoid merge conflicts I will add support for more events
once this patch merges.
BUG: 1334044
Change-Id: I316827ac9dd1443454df7deffe4f54835f7f6a08
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14248
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c416e7966ecd950418b47fb803c5ccda334ad4bf
Author: Muthu-vigneshwaran <mvignesh@redhat.com>
Date: Mon Jul 18 16:56:38 2016 +0530
libglusterfs : update correct memory segments in glfs-message-id
Change-Id: I669d6674e21d1524a2934edba8a77b70c77ef0f4
BUG: 1357490
Signed-off-by: Muthu-vigneshwaran <mvignesh@redhat.com>
Reviewed-on: http://review.gluster.org/14942
Tested-by: Muthu Vigneshwaran
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 2ef3492f3adf92fd508cd6d436dc85a408888024
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Jul 14 11:50:42 2016 -0400
Update MAINTAINERS
Changes to reflect the current state of maintainers.
Change-Id: Ic3d0b61ef4bf334a7434dcc9d8ef867774306eae
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/14926
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a19242a46721d8b8b24520c334d980de14a85bfb
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jul 18 12:54:38 2016 +0530
glusterd: search for free port from base_port
When a volume is deleted, the freed up ports are never considered for further
allocation since pmap_registry_alloc () always starts scanning from last_alloc.
So in use cases where gluster volumes are frequently created and deleted
managing ports become nightmare as for every new volume creation ports need to
be opened up by the admin based on the volume topology.
Solution: Instead of scanning from last_alloc, pmap_registry_alloc () always
starts from base_port now. What that means is glusterd will always try to find
out the ports which have been freed from earlier volumes and reallocate them for
the newer ones. There could be possibilities that when a volume is stopped and
started back their brick ports are changed which is completely acceptible IMHO.
Change-Id: I99ccc11732b6a75527fcb6abafaf249ed02b3b78
BUG: 1221623
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14939
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit fba667ff859761e14fadd8702ba40cd08f6224af
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jun 27 14:56:04 2016 +0530
Revert "tests: remove tests for clear-locks"
This reverts commit 0086a55bb7de1ef5dc7a24583f5fc2b560e835fd.
As part of Richard's patch for lock-revocation feature this bug
is completely fixed (I think at least ;-) ). So bringing these
back so that we will find out if there are anymore things we need
to address in this code path.
BUG: 1350867
Change-Id: If1440fc83b376576ae1a77b1156188a6bf53fe3a
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14817
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2f59e5be3b61c94722c0bc70f3904f88a801c4d7
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Jul 1 15:54:07 2016 +0530
features/bitrot: Move throttling code to libglusterfs
Since throttling is a separate feature by itself,
move throttling code to libglusterfs.
Change-Id: If9b99885ceb46e5b1865a4af18b2a2caecf59972
BUG: 1352019
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14846
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e40985ea6050176711eded5f3db5b58af85b7a2a
Author: mvignesh@redhat.com <mvignesh@redhat.com>
Date: Wed Jul 13 15:30:19 2016 +0530
quota: corrected minor spelling mistakes in quota src files
Change-Id: I85420ca5f89ce9d576a81be22d8c2003f109b476
BUG: 1356032
Signed-off-by: mvignesh@redhat.com <mvignesh@redhat.com>
Reviewed-on: http://review.gluster.org/14917
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit afc4b68e86a9e8be42b38f13a4949ced685ca159
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jul 15 18:49:32 2016 +0530
cli/xml: Fix wrong XML format in volume get command
Without this Patch,
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volGetopts>
<count>258</count>
<Option>cluster.lookup-unhashed</Option>
<Value>on</Value>
<Option>cluster.lookup-optimize</Option>
<Value>off</Value>
<Option>cluster.min-free-disk</Option>
<Value>10%</Value>
<Option>cluster.min-free-inodes</Option>
<Value>5%</Value>...
With this patch,
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volGetopts>
<count>258</count>
<Opt>
<Option>cluster.lookup-unhashed</Option>
<Value>on</Value>
</Opt>
<Opt>
<Option>cluster.lookup-optimize</Option>
<Value>off</Value>
</Opt>
<Opt>
<Option>cluster.min-free-disk</Option>
<Value>10%</Value>
</Opt>
<Opt>
<Option>cluster.min-free-inodes</Option>
<Value>5%</Value>
</Opt>...
BUG: 1302277
Change-Id: I6c5a040f659f2244ddcd47c57882b4f300cbe52f
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14931
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2f81ada6f1323b733b00d1d4b5f47b3f4f39ee5e
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jul 7 08:51:08 2016 -0400
core: use readdir(3) with glibc, and associated cleanup
Starting with glibc-2.23 (i.e. what's in Fedora 25), readdir_r(3)
is marked as deprecated. Specifically the function decl in <dirent.h>
has the deprecated attribute, and now warnings are thrown during the
compile on Fedora 25 builds.
The readdir(_r)(3) man page (on Fedora 25 at least) and World+Dog say
that glibc's readdir(3) is, and always has been, MT-SAFE as long as
only one thread is accessing the directory object returned by opendir().
World+Dog also says there is a potential buffer overflow in readdir_r().
World+Dog suggests that it is preferable to simply use readdir(). There's
an implication that eventually readdir_r(3) will be removed from glibc.
POSIX has, apparently deprecated it in the standard, or even removed it
entirely.
Over and above that, our source near the various uses of readdir(_r)(3)
has a few unsafe uses of strcpy()+strcat().
(AFAIK nobody has looked at the readdir(3) implemenation in *BSD to see
if the same is true on those platforms, and we can't be sure of MacOS
even though we know it's based on *BSD.)
Change-Id: I5481f18ba1eebe7ee177895eecc9a80a71b60568
BUG: 1356998
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14838
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ed9c871c766439dde731309cc30905bf9d0cdd7b
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Sat Jul 16 21:43:58 2016 -0400
core: add a basis function to reduce verbose code
Change-Id: Icebe1b865edb317685e93f3ef11d98fd9b2c2e9a
BUG: 1357226
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: http://review.gluster.org/14936
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 022c4fbb0477d2c58ab3e74bc634150bf73ab477
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jul 18 12:23:29 2016 +0530
glusterd: fix compilation warning
glusterd-utils.c: In function 'glusterd_handle_replicate_brick_ops':
glusterd-utils.c:11402:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (dict_get_str (THIS->options, "transport.socket.bind-address",
^~
glusterd-utils.c:11406:17: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
snprintf (logfile, sizeof (logfile),
Solution : indentation does the magic :)
Change-Id: I887fcba69ba1e952cc635d939e636d69e227f8b8
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14937
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ea6c5348168a03cb363a0d5e4929b95b1a9cf1a3
Author: Richard Wareing <rwareing@fb.com>
Date: Fri Nov 20 10:59:00 2015 -0800
features/locks: Add lock revocation functionality to posix locks translator
Summary:
- Motivation: Prevents cluster instability by mis-behaving clients
causing bricks to OOM due to inode/entry lock pile-ups.
- Adds option to strip clients of entry/inode locks after N seconds
- Adds option to clear ALL locks should the revocation threshold get hit
- Adds option to clear all or granted locks should the max-blocked
threshold get hit (can be used in combination w/ revocation-clear-all).
- Options are:
features.locks-revocation-secs <integer; 0 to disable>
features.locks-revocation-clear-all [on/off]
features.locks-revocation-max-blocked <integer>
- Adds monkey-locking option to ignore 1% of unlock requests (dev only)
features.locks-monkey-unlocking [on/off]
- Adds logging to indicate revocation event & reason
Test Plan:
First you will need TWO fuse mounts for this repro. Call them /mnt/patchy1 & /mnt/patchy2.
1. Enable monkey unlocking on the volume:
gluster vol set patchy features.locks-monkey-unlocking on
2. From the "patchy1", use DD or some other utility to begin writing to a file,
eventually the dd will hang due to the dropped unlocked requests. This now
simulates the broken client. Run:
for i in {1..1000};do dd if=/dev/zero of=/mnt/patchy1/testfile bs=1k count=10;done'
...this will eventually hang as the unlock request has been lost.
3. Goto another window and setup the mount "patchy2" @ /mnt/patchy2, and
observe that 'echo "hello" >> /mnt/patchy2/testfile" will hang due to the
inability of the client to take out the required lock.
4. Next, re-start the test this time enabling lock revocation; use a timeout of
2-5 seconds for testing:
'gluster vol set patchy features.locks-revocation-secs <2-5>'
5. Wait 2-5 seconds before executing step 3 above this time. Observe that this
time the access to the file will succeed, and the writes on patchy1 will
unblock until they hit another failed unlock request due to
"monkey-unlocking".
BUG: 1350867
Change-Id: I814b9f635fec53834a26db634d1300d9a61057d8
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14816
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit f8e2d9822514c125340271883ee8fe266d531e7b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jul 14 11:17:40 2016 +0530
features/index: Move gf_log -> gf_msg
Change-Id: I88e5d69a24309bf9d3cb855950c9a5349bdd3d66
BUG: 1356504
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14924
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Krutika Dhananjay <kdhananj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Tested-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
commit 814a0971ad21ae375fc1c8964e7a7b30bde239ca
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Jul 16 14:21:47 2016 +0200
build: correctly format some (s)size_t messages
On 32-bit builds the are are warnings like these:
posix.c:6438: warning: format '%ld' expects type 'long int', but argument 11 has type 'ssize_t'
Instead of using "%l" for (signed) size_t variables, "%z" should be
used.
BUG: 1198849
Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14933
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 7785597eac05b3d96c2ad099cf0f20f411043501
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Sat Jul 16 18:02:55 2016 -0400
io-threads.c: add serveral fops support in io-threads
1.add lease, seek, getactivelk, setactivelk support in io-threads
2.add several missing function declations in defaults.h, the declation
of function default_getactivelk_failure_cbk needed by io-threads.c
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Change-Id: Ie7a56569b4c29cdc6984d31738b484d2d6d83557
BUG: 1357210
Reviewed-on: http://review.gluster.org/14935
Tested-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2533450a8f2882b1bfe851685f552154eee4029c
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Jul 13 16:24:31 2016 +0530
nfs: Reset cs->resolvedhard while resolving an entry
If an entry is not found in the inode table, nfs xlator should be
resolving it by sending an explicit lookup to the brick process.
But currently its broken in case of NFS3_LOOKUP fop where in the server
bails out early resulting in sending pargfid attributes to the client.
To fix the same reset 'cs->resolvedhard' so that an explicit lookup
is done for the entry in the resume_fn "nfs3_lookup_resume()".
Change-Id: I999f8bca7ad008526c174d13f69886dc809d9552
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
BUG: 1356068
Reviewed-on: http://review.gluster.org/14911
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 15956135bbf0bb83067cc256e71ff8efa05709ce
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jul 15 13:15:21 2016 +0530
packaging: Remove ".py" extension from symlink target
S57glusterfind-delete-post.py* is packaged in
$LIBEXEC/glusterfs/glusterfind directory, symlink created to
/var/lib/glusterd/hooks directory
ln -s $(libexecdir)/glusterfs/glusterfind/S57glusterfind-delete-post.py \
$(DESTDIR)$(GLUSTERD_WORKDIR)/hooks/1/delete/post/S57glusterfind-delete-post.py
".py" should be removed from symlink target so that build system will
not try to compile the symlink files and generate .pyc/.pyo files.
BUG: 1356868
Change-Id: I9155378aa72eb8559ba8af76d91a4985f69f38f9
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14928
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 165206419ede829e79e35c555808663de9de5767
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Sun Jul 10 09:10:49 2016 -0400
rpc: fix several problems in failure handle logic
Once dynstr is set into a dict by function dict_set_dynstr, its free
operation will be called by this dict when the dict is destroyed.
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Change-Id: Idd2bd19a041bcb477e1c897428ca1740fb75c5f3
BUG: 1354141
Reviewed-on: http://review.gluster.org/14882
Tested-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 83fa7df725954176b02e60de607cab92a2a00f6a
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jul 14 13:04:09 2016 +0530
extras/cliutils: Fixed extra packaging line
cliutils was added in two places, $LIBEXEC and $PYTHON_SITE_PACKAGES
Removed packaging from $LIBEXEC
BUG: 1342356
Change-Id: Ie51d72b65996d14be2e7cab9a614327bec1e9555
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14923
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 572f999195f10c33414ccdecba158901fd562311
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jul 12 00:39:31 2016 +0530
glusterd: Fix gsyncd upgrade issue
Problem:
gluster upgrade is not generating new volfiles
Cause:
During upgrade, "glusterd --xlator-option *.upgrade=on -N"
is run to generate new volfiles. It is run post 'glusterfs'
rpm installation. The above command fails during upgrade
if geo-replication is installed. This is because on
glusterd start 'gsyncd' binary is called to configure
geo-replication related stuff. Since 'glusterfs' rpm is
installed prior to 'geo-rep' rpm, the 'gsyncd' binary
used to glusterd upgrade command is of old version and
hence it fails before generating new volfiles.
Solution:
Don't call geo-replication configure during upgrade/downgrade.
Geo-replication configuration happens during start of glusterd
after upgrade.
Change-Id: Id58ea44ead9f69982f86fb68dc5b9ee3f6cd11a1
BUG: 1355628
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14898
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 643878d4f4ef09b26f0d74689ecfbfd650032f23
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Mon Jul 11 07:28:44 2016 -0400
build: fix noisy compilation warning with current build option Wstrict-prototypes
Change-Id: I50904033aa2beb880dee828849f470ac31048a79
BUG: 1354221
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: http://review.gluster.org/14884
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 02562b42cf6df82a0d8e329e57fe43837f241e61
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue May 31 13:39:05 2016 +0530
extras/cliutils: Utils for creating CLI tools for Gluster
Refer README.md for documentation.
BUG: 1342356
Change-Id: Ic88504177137136bbb4b8b2c304ecc4af9bcfe30
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14627
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a0b4d85d6f305979ce5b4e785c49e46e33214099
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jun 23 11:53:36 2016 +0530
geo-rep: Handle Config parser errors
Python ConfigParser lib has two methods, readfp and read, it should
be used as follows.
readfp(open("defaults.conf"))
read("custom.conf")
ConfigParser.read(path) ignores any file errors, which is intentional
since errors are handled while loading default config.
Geo-rep uses only one config file(Session config in Master side and
Template config on Slave side) so we should use readfp to avoid
skipping OS errors.
config.read is retained in case of `--config-set-rx` where glusterd
creates new template config file.
BUG: 1349273
Change-Id: I15a14d3743facd7b8c7af0edc70fdefaa43efd04
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14777
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit f6ab65462a6368281fc5c566404a582a092ad752
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Wed Jun 29 15:36:41 2016 +0530
gluster v set help does not show ssl options
Problem: "gluster v set help" does not show ssl options.
Solution: Remove NO_DOC option for client.ssl/server.ssl from glusterd_volopt_map.
Change-Id: Iabe982ea56398209bbf30d41260798e5ad7fce7b
BUG: 1351134
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/14829
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 2dedfe67b42f86fd4091f6dd76a448fc18ce69c2
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jul 7 14:33:20 2016 +0530
features/index: Ignore regular files when examining state of the inode wrt ENTRY_CHANGES
This prevents unnecessary sys_lstat() syscall when xattrop
is operating on regular files.
Also, to avoid (even) the one-time execution of sys_lstat()
syscalls on disperse volumes or replicate volumes when granular
entry self-heal is disabled, we pass a key in afr_selfheal_undo_pending()
indicating to index that this xattrop is on a granular directory index.
Index will accordingly decide whether or not to attempt the index state
initialization.
Change-Id: I616d9a4b3704066f4a2770d3ca307f7dca9122e0
BUG: 1331323
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14870
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit ae4551b81c82cf7ef30cf756ee8d5982e21c455f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Jun 27 15:21:26 2016 +0530
afr, index: Clean up stale directory and file indices in granular entry sh
Specifically when a directory tree is removed (rm -rf)
while a brick is down, both the directory index and the
name indices of the files and subdirs under it will remain.
Self-heal will need to pick up these and remove them.
Towards this, afr sh will now also crawl indices/entry-changes
and call an rmdir on the dir if the directory index is stale.
On the brick side, rmdir fop has been implemented for index xl,
which would delete the directory index and its contents if present
in a synctask.
Change-Id: I8b527331c2547e6c141db6c57c14055ad1198a7e
BUG: 1331323
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14832
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 819239494264b5b3c13e5d0400d62425f86c8a98
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Wed Jun 29 15:36:06 2016 +0530
glusterd/geo-rep: Handle empty monitor.status during upgrade
Problem:
Consider geo-replication is in Stopped state.
Following which, glusterfs is upgraded (where monitor.status is the new status file).
Now, When geo-replication status command is run,
empty monitor status file gets created.
Now, if glusterd is restarted, it reads empty monitor status
and starts geo-replication session. This is incorrect as session
was in Stopped state earlier.
Solution:
If monitor status is empty, error out and avoid
starting geo-replication session.
Note: if monitor status is empty, geo-rep session is displayed
as Stopped state.
Change-Id: Ifb3db896e5ed92b927764cf1163503765cb08bb4
BUG: 1351071
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/14830
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5cb05125adfc804071e9fcef26cca2065f109d59
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Mon Jul 11 13:34:28 2016 +0530
tests: fix rebalance timing issue
With a start and stop rebalance, the stop command may fail
as by that time the rebalance process may not come up.
Using the rebalance status commmand to ensure that the rebalance
process is up before stoping rebalance.
Change-Id: I3d5123cd5dfabde2720428455b257d11b980ce21
BUG: 1354372
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/14885
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d8021a448e0cd7581154a63a4c3e8bcdf560ad5b
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Jul 8 14:25:35 2016 +0530
"md-cache: Enable caching of stat fetched from readdirp
Patch http://review.gluster.org/11894 removed readdirp fop for
md-cache, but there is no mention of exact xlator which was
failing because of this. As mentioned by Rafi(author of patch 11894)
tiering and svc doesn't really need this as the inode_ctx is populated
in readdirp_cbk. Hence reverting this commit.
This reverts commit c8c9308134ae4ce24c630a1b0ccfcf4e8f9b0fe7.
Change-Id: Ib8d00b3f129596f3a54984f839199175f5c9b55b
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14879
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 1a978fe22fba7d26496558f22f2b15a3d5d4c083
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Apr 14 12:38:50 2016 -0400
tests: miscellaneous improvements
This is a combination of three previous low-impact changes, combined to
reduce patch-pushing burden.
((( GF_INTERACTIVE )))
To use this, just define GF_INTERACTIVE (value doesn't matter as long as
the length is non-zero) before running your test. It replaces the TEST
alias with one that will prompt you before executing that line. You can
answer:
'y' to execute the line
'q' to exit the test immediately
anything else to skip this line and continue
This is particularly useful to inspect state in another window while a
test is paused, or to do manual experimentation in the (often complex)
configuration created during a test.
((( CLEANUP.SH )))
tests: add cleanup.sh
Often, a developer might want to run a test up to some point, then bail
out and poke around manually. That leaves state that needs to be
cleaned up before the next test can run properly. This patch adds a
trivial script to invoke that cleanup machinery.
Along the way, code in include.rc to find env.rc was changed to be more
robust across arbitrarily deep (or shallow) directory hierarchies.
((( REPLACE EXISTING TAR FILES INSTEAD OF APPENDING )))
We currently use "tar rf" to collect log files from each test. This
*appends* the new data to whatever's there already, which has two bad
effects when a test is run repeatedly.
* Ever-increasing size of the tar file.
* Ever-increasing time to extract logs from the tar file, with each
copy completely overwriting any previous.
This doesn't seem to be a problem in our regression tests, because the
entire directory is nuked during package removal and reinstallation.
However, when running a test repeatedly during a debug session, the
effects can be quite severe. This is particularly evident with JBR,
because the "logs" that get archived include large journal files.
Certain other translators, such as changelog and CTR, might be prone to
similar effects.
There's no point to having multiple copies of the logs in each tar file.
As far as I know, nobody ever takes advantage of that. Therefore, use
"tar cf" to overwrite any existing archive instead of appending. This
change also handles excluding other .tar files in a portable way.
Change-Id: Iebf77d496a71976c321bbacb49776338a9da586f
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/14874
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 8648ce6467f8a5ebe1e278991c7404ffb77829a2
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jul 4 17:25:57 2016 +0530
feature/bitrot: Show whether scrub is in progress/idle
Bitrot scrub status shows whether the scrub is paused
or active. It doesn't show whether the scrubber is
actually scrubbing or waiting in the timer wheel
for the next schedule. This patch shows this status
with "In Progress" and "Idle" respectively.
Change-Id: I995d8553d1ff166503ae1e7b46282fc3ba961f0b
BUG: 1352871
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14864
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5a03300c9def9c491685e6d9092f306090d29665
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Fri Jun 24 06:33:16 2016 +0800
rpc: invalid argument when function setsockopt sets option TCP_USER_TIMEOUT
If option "transport.tcp-user-timeout" hasn't been setted, glusterd's
priv->timeout will be -1, which will cause invalid argument when
set TCP_USER_TIMEOUT.
Change-Id: Ibc16264ceac0e69ab4a217ffa27c549b9fa21df9
BUG: 1349657
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: http://review.gluster.org/14785
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c44cd476a589b6e89d2d5e5654fadc2561408611
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sat Apr 9 00:40:38 2016 -0400
cluster/afr: Fix a minor typo in afr-self-heald.c
s/outout/output/
Change-Id: I2aec770cdae513cd4932e5fd56e0267584e44cae
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/13930
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
commit ce1d6c357a3ef4fa22faad9128cb7a1b35691926
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Sun Jun 26 19:56:58 2016 -0400
libglusterfs: race condition when set ctx->timer in function gf_timer_registry_init
1.fix race conditon when set ctx->timer
2.use typical list_head operation instead of verbose list's operation
3.add file "tags" into .gitignore
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Change-Id: I4ec55e41356633cf1399536d202c58e19b309f00
BUG: 1350191
Reviewed-on: http://review.gluster.org/14800
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 647a7cc5eb378ea4c989a1f6ea9f45f1d133ff78
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Jul 8 10:46:46 2016 +0530
rpc/socket: pthread resources are not cleaned up
A socket_connect failure creates a new pthread which
is not a detached thread. As no pthread_join is called,
the thread resources are not cleaned up causing a memory leak.
Now, socket_connect creates a detached thread to handle failure.
Change-Id: Idbf25d312f91464ae20c97d501b628bfdec7cf0c
BUG: 1343374
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/14875
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 93db5a6286d0992b401a2add9caf327b755c8408
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Fri Jun 24 09:58:29 2016 +0530
rpc/socket.c : Modify socket_poller code in case of ENODATA error code.
Problem: Polling failure errors are coming till volume is not come while
SSL is enabled.
Solution: To avoid the message update one condition in socket_poller code
It will not exit from thread in case of received ENODATA from
ssl_do function.
Change-Id: Ia514e99b279b07b372ee950f4368ac0d9c702d82
BUG: 1349709
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/14786
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2d6ad2ce645934bf66f13c28a7d702dd9fb99587
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jul 7 15:24:05 2016 -0400
mgmt: remove unused and misleading pmap_signup
We use signin, but not signup. Having both just introduces confusion.
The proc number has been retained to avoid changes to the numbering of
other procs, and the mapping to a name has similarly been retained as a
placeholder, but the code and structure definitions have been removed.
Change-Id: I60f64f3b5d71ba6ed6862b36a38f90a9c8271c9f
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/14792
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 9717b6511763261d0f2d38debfeed99feedc22c7
Author: Nigel Babu <nigelb@redhat.com>
Date: Thu Jul 7 14:35:14 2016 +0530
Update the documentation link in the spec file
BUG: 1303668
Change-Id: Ifded6a03f437f16a0a1ad2bfb7377d07569a7735
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: http://review.gluster.org/14869
Tested-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.org>
commit 5d2b3e18c8367bb2f704310c56fa882f36f67b3c
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Mon Jul 4 12:21:45 2016 +0530
geo-rep: fix wrong argument to find_library
Argument passed to find_library function is wrong.
Pass proper argument to find_library.
Note: It still works as default handle is libc.
Change-Id: I4657a3ef9f5249e3eec4a20582856b58168126ce
BUG: 1352423
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/14852
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 2f9af42f79e9bb53ca13bfb1aeec43fbdac5591e
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Jul 4 18:36:26 2016 +0530
gfapi: update count when glfs_buf_copy is used
glfs_buf_copy collates all iovecs into a iovec with count=1. If
gio->count is not updated it will lead to dereferencing of invalid
address.
Change-Id: I7c58071d5c6515ec6fee3ab36af206fa80cf37c3
BUG: 1352634
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reported-By: Lindsay Mathieson <lindsay.mathieson@gmail.com>
Reported-By: Dmitry Melekhov <dm@belkam.com>
Reported-By: Tom Emerson <TEmerson@cyberitas.com>
Reviewed-on: http://review.gluster.org/14854
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 8652caf60ad7cf1f1fe8737d6fff43cd0eb3cc6c
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Jun 16 12:03:19 2016 +0530
storage/posix: fix inode leaks
Change-Id: Ibd221ba62af4db17bea5c52d37f5c0ba30b60a7d
BUG: 1344885
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/14739
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 10cc3a58c4d1b528a529fa671c8f554db540d111
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Tue Jun 14 10:52:27 2016 +0530
glusterd: Don't start bricks if server quorum is not met
Upon glusterd restart if it is observered that the server quorum
isn't met anymore due to changes to the "server-quorum-ratio"
global option, the bricks should be stopped if they are running.
Also if glusterd has been restarted, and if server quorum is not
applicable for a volume, do not restart the bricks corresponding
to the volume to make sure that bricks that have been brought
down purposely, say for maintenance, are not brought up. This
commit moves this check that was previously inside
"glusterd_spawn_daemons" to "glusterd_restart_bricks" instead.
Change-Id: I0a44a2e7cad0739ed7d56d2d67ab58058716de6b
BUG: 1345727
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: http://review.gluster.org/14758
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ae04ee06f70715c1cbbfc7de7c7524a17242c2a5
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Jun 29 05:31:03 2016 -0400
upcall: Invalidation for xattr should also carry a valid stat
xattr modification also impacts the ctime of the file, hence
include the new stat along with the new xattrs, in the
invalidation request
Change-Id: Ieaa4382fa62f397f61a995b926013b9207c6e9da
BUG: 1352671
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14828
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5ee8f8418b83e5a410d75874278f6cba19708558
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jun 30 11:42:54 2016 +0530
glusterd: spawn daemons from init() on a single or two node setup
Allow glusterd to spawn the daemons at the time of initialization when peer
count is less than 2. This is required if user wants to set up a two node
cluster with out server side quorum and want the bricks to come up on a node
where the other node is down, however the behaviour will be overriden when
server side quorum is enabled.
Change-Id: I21118e996655822467eaf329f638eb9a8bf8b7d5
BUG: 1352277
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14848
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 4c746d72661b9d9bb640c7026cdbfe96a8ac3bd6
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jun 30 14:49:51 2016 +0530
features/bitrot: Option to set scrub interval to a minute
Bitrot scrub-frequency supports "hourly|daily|weekly|biweekly|monthly".
But it is painful for testing as minimum scrub-interval is an hour
Hence introducing a scrub interval of minute to ease testing.
It is intentionally not exposed in bitrot command help as it is
only for testing.
e.g.,
gluster vol bitrot <volname> scrub-frequency minute
Change-Id: I155a65298d3fad5ae9e529d9c7d4b0d25fa297c0
BUG: 1351537
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14836
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a81c49c36d3a827f9544c21304773c39496d9ed6
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Jul 1 11:47:48 2016 +0530
cli: print volume status client output for partial bricks
In cli the response dictionary is parsed assuming all the bricks to be up.
If in a given cluster one of the node is down client details for the
bricks hosted by the same node are not available in the dictionary resulting
into a blank output for 'gluster volume status <volname> clients'
Fix is to ignore the ret value for dict_get for those keys.
Change-Id: If4fb65b8807ea3ac71b3ed1a754ea75f599e3613
BUG: 1351880
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14842
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5790dd57afc140105dec48f7d762815c69742cbb
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon May 9 12:14:37 2016 +0530
glusterd: search port from last_alloc to base_port
If a brick process is killed ungracefully then GlusterD wouldn't receive a
PMAP_SIGNOUT event and hence the stale port details wouldn't be removed out.
Now consider the following case:
1. Create a volume with 1 birck
2. Start the volume (say brick port allocated is 49152)
3. Kill the brick process by 'kill -9'
4. Stop & delete the volume
5. Recreate the volume and start it. (Now the brick port gets 49153)
6. Mount the volume
Now in step 6 mount will fail as GlusterD will provide back the stale port
number given the query starts searching from the base_port.
Solution:
To avoid this, searching for port from last_alloc and coming down to base_port
should solve the issue.
Change-Id: I9afafd722a7fda0caac4cc892605f4e7c0e48e73
BUG: 1334270
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14268
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b9cd7cae7c523b2bd84d03a633d629ece66c6ec1
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Jun 29 00:25:39 2016 -0400
md-cache: Cache gluster-samba metadata
Change-Id: I0a95f4897440c5bf6f54612d9c232e015c8bf983
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14824
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit d075835ab504bab34e2968c7181bcb3c07e3c723
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun Jul 3 15:51:20 2016 +0530
glusterd: compare uuid instead of hostname address resolution
In glusterd_get_brickinfo () brick's hostname is address resolved. This adds an
unnecessary latency since it uses calls like getaddrinfo (). Instead given the
local brick's uuid is already known a comparison of MY_UUID and brickinfo->uuid
is much more light weight than the previous approach.
On a scale testing where cluster hosting ~400 volumes spanning across 4 nodes,
if a node goes for a reboot, few of the bricks don't come up. After few days of
analysis its found that glusterd_pmap_sigin () was taking signficant amount of
latency and further code walthrough revealed this unnecessary address
resolution. Applying this fix solves the issue and now all the brick processes
come up on a node reboot.
Change-Id: I299b8660ce0da6f3f739354f5c637bc356d82133
BUG: 1352279
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14849
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 53be0ba0bb8c9f60fb6abe28a67d63bf1f4931e1
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Feb 10 18:27:38 2016 -0500
logging: Change log file name for glusterd
log file names are based on:
a. user provided input (through -l switch while starting a gluster process)
b. mount point paths in the case of native clients
c. volume/configuration files used for starting a gluster process
d. volume server used for starting a gluster process
Currently glusterd uses scheme c. to have a log file name that reads as
INSTALL_PREFIX-etc-glusterfs-glusterd.log
Since glusterd has a well known configuration file, it does not make much
sense to have log file name based on scheme c. This patch changes the name of
glusterd's log file to "glusterd.log". Hopefully this enables users to identify
glusterd's log file more easily.
Change-Id: I2d04179c4b9b06271b50eeee3909ee259e8cf547
BUG: 1348944
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/13426
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 927ed67f8f7999670dbe8f402dfba900179fe43c
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Wed Jun 29 12:09:06 2016 +0530
glusterd: glusterd must store all rebalance related information
Change-Id: I8404b864a405411e3af2fbee46ca20330e656045
BUG: 1351021
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/14827
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a3c5210d2a34958e87e7b17742832e1ac4fdbd26
Author: Sakshi <sabansal@redhat.com>
Date: Thu May 28 11:23:55 2015 +0530
cli: different status output for rebalance fix-layout
Change-Id: I6ded40a1b1cff5c72e5b61fd353db3d8c688efd8
BUG: 1225718
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/10956
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 6f2c1f5aa59d1c9be738f120e567643fccb3f7c4
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri May 6 10:03:53 2016 -0400
socket: log the client identifier in ssl connect
Change-Id: I4b463ecafb66de16cbe7ed23fae800bb1204f829
BUG: 1333912
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/14242
Tested-by: Vijay Bellur <vbellur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit a44f018e4e1c8504c50eab9d89c77c499de47d4f
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Jun 16 15:55:47 2016 +0530
libgfapi : free parameters allocated by glfs_set_volfile_server()
This change introduce new function glfs_free_volfile_server
which frees the variables allocated by glfs_set_volfile_server
during glfs_fini()
Change-Id: I8b1806c56e3431c33e4e8c17f9e8aa17a28a2f5c
BUG: 1347249
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14743
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0bf8ef5b2e17efd3bf18afef67310cc4f07af9b3
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue Jun 28 14:48:14 2016 -0400
build: glusterfs.spec(.in) firewalld file doesn't use %{_prefix}
.../firewalld/services/glusterfs.xml in %server files section
does not use %{_prefix}
Other firewalld files, e.g., in the firewalld.src.rpm file use
%{_prefix}
N.B. the other 'hardcoded' path, "/sbin/mount.glusterfs" in the
%files fuse section must remain as is, there is no macro for
mount utilities to use as there is for, e.g., the %{_sbindir}
macro for /usr/sbin. This doesn't matter for either RHEL6, where
/sbin and /usr/sbin are distinct directories, or for Fedora and
RHEL7, where /sbin is a symlink to /usr/sbin. E.g. see the nfs-
utils.src.rpm where /sbin/mount.nfs is also 'hardcoded'.
Change-Id: I902f47e3c589526c774d0aceb6fc2815abf86b01
BUG: 1350793
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14823
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 07bd6dc8318545a858712192ed3c468465197cd5
Author: Milind Changire <mchangir@redhat.com>
Date: Fri Apr 22 16:56:47 2016 +0530
georep: add reset-sync-time option for session delete
Set the stime xattr at all the brick roots to (0,0) if the argument
reset-sync-time has been provided on the command-line.
To avoid testing against directory specific stime, the remote
stime is assumed to be minus_infinity, if the root directory
stime is set to (0,0), before the directory scan begins.
This triggers a full volume resync to slave in the case of a
geo-rep session recreation with the same master-slave volume
pair.
Command synopsis:
gluster volume geo-replication <MASTERVOL> <SLAVE>::<SLAVEVOL> delete \
[reset-sync-time]
Update gluster cli man page to include new sub-command reset-sync-time.
Change-Id: Ie4ce03b9425ed9bb81eda8681058c0fc6f990948
BUG: 1311926
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/14051
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 0cb4e35db2d69183ffd0a3864f8115eedb6b841f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jun 7 16:27:34 2016 +0530
libglusterfs: Implement API that provides page-aligned iobufs
One of the consumers of a page aligned buffer would be posix's
readv fop on O_DIRECT fds. Today the way it works is by getting
a page-aligned buffer through calloc, pread()ing into this buffer
and then copying its contents into a newly created iobuf's ptr.
This results in an extra memcpy() which can be avoided if we could
implement an api that would return an iobuf whose ptr is
page-aligned. That way the iobuf->ptr can be directly passed to
sys_pread() as a parameter by posix translator.
Change-Id: I385139bc6ee309fc501034b3af8f7814fab8cd65
BUG: 1343838
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14672
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 53190acf24533399a0654d67529837cadcda1a2d
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sun Jun 12 13:02:05 2016 +0530
libglusterfs/client_t: Dump the 0th client too
Change-Id: I565e81944b6670d26ed1962689dcfd147181b61e
BUG: 1344885
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/14704
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5cc2e73b1c811a4a02a94bab9815bd2aa5c0a204
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jun 28 15:32:17 2016 +0530
glusterd/cli: coverity fixes
A downstream coverity run has revealed few of the following coverity defects.
Since the downstream code is a clone of a specific upstream branch the defects
hold true for the upstream as well.
Defect type: NEGATIVE_RETURNS
xlators/mgmt/glusterd/src/glusterd-rpc-ops.c:641: negative_returns: "op_errno"
is passed to a parameter that cannot be negative.
Defect type: BUFFER_SIZE_WARNING
xlators/mgmt/glusterd/src/glusterd-volume-ops.c:2124: buffer_size_warning:
Calling strncpy with a maximum size argument of 261 bytes on destination array
"volinfo->volname" of size 261 bytes might leave the destination string
unterminated.
Defect type: BUFFER_SIZE_WARNING
xlators/mgmt/glusterd/src/glusterd-volgen.c:4888: buffer_size_warning: Calling
strncpy with a maximum size argument of 261 bytes on destination array
"volinfo->volname" of size 261 bytes might leave the destination string
unterminated.
Defect type: STRING_OVERFLOW
xlators/mgmt/glusterd/src/glusterd-volgen.c:3449: string_overflow: You might
overrun the 256 byte destination string "tmp_volname" by writing 261 bytes from
"volinfo->volname".
Defect type: BUFFER_SIZE_WARNING
xlators/mgmt/glusterd/src/glusterd-utils.c:3392: buffer_size_warning: Calling
strncpy with a maximum size argument of 261 bytes on destination array
"new_volinfo->volname" of size 261 bytes might leave the destination string
unterminated.
Defect type: NO_EFFECT
xlators/mgmt/glusterd/src/glusterd-utils.c:7359: remediation: Was
"rebal->rebalance_id" formerly declared as a pointer?
Defect type: USE_AFTER_FREE
xlators/mgmt/glusterd/src/glusterd-utils.c:7115: pass_freed_arg: Passing freed
pointer "volinfo" as an argument to "glusterd_friend_contains_vol_bricks".
Defect type: DEADCODE
cli/src/cli-cmd-parser.c:1767: dead_error_begin: Execution cannot reach this
statement: "ret = -1;".
Change-Id: Ie941bdf31923e2f39618dd94bfae16fdb3ad65f1
BUG: 789278
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14818
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 198ef170c24cfdf49aa9c5962c5b4d0ff62a9941
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jun 26 18:50:27 2016 +0200
nfs: allow hostnames with dashes in exports/netgroups files
Hostnames with dashes (like "vagrant-testVM") are not correctly parsed
when reading the exports/netgroups files. This bacomes obvious when
running ./run-tests-in-vagrant.sh because it causes
tests/basic/mount-nfs-auth.t and tests/basic/netgroup_parsing.t to fail.
The regex for hostname (in exports) and the entry and hostname
(netgroups) parsing does not include the "-" sign, and hence the
hostnames are splitted at it.
BUG: 1350237
Change-Id: I38146a283561e1fa386cc841c43fd3b1e30a87ad
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14809
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a3738b5cec8aab793bc0bbdac174835c7a2e3cd1
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Jun 27 12:40:17 2016 +0530
protocol/server: Fix client/server compatibility
The 3.8 client expects a child_up key from the server
indicating the status of the server translators. This
key is not being sent by the servers running older
versions, thereby breaking compatibility.
With this patch we are treating the absence of the said
key as an indication that the server trying to connect
to this client is running an older version and hence
in such a case we are setting conf->child_up as
_gf_true explicitly. This should suffice in emulating
the older behavior.
Due to the nature of this bug, requiring two version to
be reproducible, there are no testcases added for the same.
Change-Id: I29e0a5c63b55380dc9db8e42852d7e95b64a2b2e
BUG: 1350327
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/14811
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.org>
commit b808320604173c451666535e040ed67896925830
Author: Arthy Loganathan <aloganat@redhat.com>
Date: Mon Jun 27 17:44:28 2016 +0530
distaf: Modified tier_attach() to get bricks path from available bricks in server
Added code to get bricks path from available bricks in
server in tier_attach()
Change-Id: I58822f425c6ea8284568d3701807cfcc11f37e3c
BUG: 1350427
Signed-off-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-on: http://review.gluster.org/14814
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: M S Vishwanath Bhat <msvbhat@gmail.com>
commit 229359ef8c683ed63cad920392bf3767b7c047c6
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed May 25 14:38:31 2016 +0530
gfapi/handleops: Avoid using glfd during create
To avoid leaking glfd while creating a file using handleops and
since application shall not be interested in it, use the 'fd'
object directly which can be un'refed post create.
Change-Id: I119874ffb63fb4aa18f846ba1fdbe77874b66a54
BUG: 1339553
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14532
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 2184e75f071bc87dca83e1f2c16f1e6c6270cec3
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Jun 23 12:20:03 2016 +0530
gfapi : check the value "iovec" in glfs_io_async_cbk only for read
The glfs_io_async_cbk() is called from the cbk of all the async ops
such as write, read, fsync, ftruncate. In all other cases, expect for
read the value for "iovec" is NULL. From the code, glfs_io_async_cbk
checks the value in common routine which may end up in failures.
Thanks Joe Julian for finding issue and suggesting the fix.
Change-Id: I0be0123da68f9d8fbb5d94ede2d45566a9add6a5
BUG: 1349276
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reported-by: Joe Julian <me@joejulian.name>
Reviewed-on: http://review.gluster.org/14779
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Joe Julian <me@joejulian.name>
commit 7d8c695cb730dd34fd87e003bb3a9ed71051a701
Author: Arthy Loganathan <aloganat@redhat.com>
Date: Sun Jun 26 23:53:34 2016 +0530
distaf: Modified get_pathinfo() in lib_utils.py
Modified get_pathinfo() in lib_utils.py
Change-Id: I721d3704ec00c20b9678088d79e52e3eedbe4af5
BUG: 1350248
Signed-off-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-on: http://review.gluster.org/14802
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: M S Vishwanath Bhat <msvbhat@gmail.com>
commit d362e9780eff85feeb6e57b635622fe2eaa9b32b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jun 22 14:52:58 2016 +0530
features/index: Delete parent dir indices when heal on it is complete
In this patch, the state information about whether a directory
gfid index is present or not is stored in the inode ctx with
values IN and NOTIN. This saves index xl the need to perform
stat() everytime an index_entry_create() is called.
When a brick is restarted these in-memory inode ctx records will
be gone. So when granular entry heal happens after a brick is restarted,
and a post-op is done on the parent, if the state gotten from inode ctx
is UNKNOWN, then index xl does a stat to initialize the state as IN or
NOTIN. Note that this is a one-time operation for the lifetime of the
brick. Such a change also helps avoid calling index_del() in
xattrop_index_action() periodically even when granular self-heal is
disabled or when the volume type is disperse.
Change-Id: Ib92c17350e6531b91ab81477410fe1e7a5856207
BUG: 1331323
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14781
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 9836357fdea099727592e9cbcc2063953b4b1024
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jun 22 14:57:44 2016 +0530
glusterd/geo-rep: Add relative path validation to copy file command
Added validation for input file, command fails if input file path is
relative path pointing outside of GLUSTERD_WORKDIR.
BUG: 1348897
Change-Id: I329d43ebed69bfe9fe03d6be70dc8c78a605ffc5
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14772
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 23ee7b750128d439ef9cdcd1b8b6f6f01121dbb1
Author: Arthy Loganathan <aloganat@redhat.com>
Date: Mon Jun 27 15:51:38 2016 +0530
Minor fix in distaf_gluster_config.yml file
Change-Id: Ia0609d54b51eed14db229e0fdc92c4530fb97aff
BUG: 1350383
Signed-off-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-on: http://review.gluster.org/14813
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 7a5f60c77be2bb9ba76f7bf551840368cecea19f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jun 7 21:27:10 2016 +0530
storage/posix: Give correct errno for anon-fd operations
Change-Id: Ia9e61d3baa6881eb7dc03dd8ddb6bfdde5a01958
BUG: 1343906
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14669
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1dd22504816280e379a17874848e257573869bc8
Author: Shwetha Panduranga <spandura@redhat.com>
Date: Mon Jun 27 02:02:29 2016 +0530
Adding simple test "running dd from mount".
Change-Id: Icbb799c401e73b51a7e96b86db78e46f6b0d5813
BUG: 1350258
Signed-off-by: Shwetha Panduranga <spandura@redhat.com>
Reviewed-on: http://review.gluster.org/14807
Tested-by: ShwethaHPanduranga
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit fa2c3831239e7c25a2a0d83a0bb9ad6a7b4244ce
Author: Shwetha Panduranga <spandura@redhat.com>
Date: Mon Jun 27 01:49:15 2016 +0530
Servers in yaml file is list of dicts. Hence iterating through servers to get the 'host' of it.
Change-Id: I361aa88ad21ce30fd57f297795c5f7ff60ccfd2a
BUG: 1350256
Signed-off-by: Shwetha Panduranga <spandura@redhat.com>
Reviewed-on: http://review.gluster.org/14805
Tested-by: ShwethaHPanduranga
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 2ef3845c71dabea25a0c39977c16f0ada28d91a5
Author: Shwetha Panduranga <spandura@redhat.com>
Date: Mon Jun 27 02:26:06 2016 +0530
Modifying gluster_base_class and mount_ops to suit the config file changes made
Change-Id: Ic551724dd27fcc2cc618e8de04110752bf5a8786
BUG: 1350017
Signed-off-by: Shwetha Panduranga <spandura@redhat.com>
Reviewed-on: http://review.gluster.org/14808
Tested-by: ShwethaHPanduranga
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jonathan Holloway <jholloway@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit fa73946f18230357a4878de273dea309e0d0882f
Author: M S Vishwanath Bhat <msvbhat@gmail.com>
Date: Sun Jun 26 12:10:30 2016 -0700
Revert "Modifying gluster_base_class and mount_ops to suit the config file changes made"
This reverts commit 09c0b2f3c2534f365bee5a738d1699af36413a25.
BUG: 1350017
Change-Id: Id1b63c98ad827b87ad0a6beb4c7565c45749b134
Reviewed-on: http://review.gluster.org/14803
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: M S Vishwanath Bhat <msvbhat@gmail.com>
Tested-by: M S Vishwanath Bhat <msvbhat@gmail.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 6da2ab9b7e0826ab68b02f598359a916d104eb42
Author: Shwetha Panduranga <spandura@redhat.com>
Date: Sat Jun 25 02:06:38 2016 +0530
Modifying gluster_base_class and mount_ops to suit the config file changes made
Change-Id: I61481c029fdbdd9c966867f195b9dc9046550392
BUG: 1350017
Signed-off-by: Shwetha Panduranga <spandura@redhat.com>
Reviewed-on: http://review.gluster.org/14793
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: M S Vishwanath Bhat <msvbhat@gmail.com>
Tested-by: M S Vishwanath Bhat <msvbhat@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 19bb85b9ea1da5aa6920d144e263e710cf5b933a
Author: Arthy Loganathan <aloganat@redhat.com>
Date: Sun Jun 26 23:14:35 2016 +0530
distaf: Modified volume_ops library
Modified gluster volume ops library modules
Change-Id: I2ef5ca44f3a4a9844aee48f3688e8617dbbb4fcd
BUG: 1350245
Signed-off-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-on: http://review.gluster.org/14801
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: ShwethaHPanduranga
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 4f79e89425dc860923120c919ed9ed47c92f4d7f
Author: Apeksha D Khakharia <akhakhar@redhat.com>
Date: Sun Jun 26 14:55:20 2016 +0530
distaf: Adding samba_ops library
Change-Id: Icc2b1eefe0f27a67e9f0e50edd41b313bd3cc892
BUG: 1350173
Signed-off-by: Apeksha D Khakharia <akhakhar@redhat.com>
Reviewed-on: http://review.gluster.org/14798
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: ShwethaHPanduranga
Tested-by: ShwethaHPanduranga
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit ed58d8495b8f4d9140cef88107f22cc6708b04d8
Author: Apeksha D Khakharia <akhakhar@redhat.com>
Date: Sun Jun 26 16:28:52 2016 +0530
distaf: minor import changes in ganesha.py
Change-Id: I8bcb9056c1087dce54bc3ed6c967dfb444521236
BUG: 1350188
Signed-off-by: Apeksha D Khakharia <akhakhar@redhat.com>
Reviewed-on: http://review.gluster.org/14799
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: ShwethaHPanduranga
Tested-by: ShwethaHPanduranga
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 4ffe2261d8ca7608c10951acb185bfe0ffdda2bb
Author: Apeksha D Khakharia <akhakhar@redhat.com>
Date: Fri Jun 24 11:06:17 2016 +0530
distaf: adding libraries to get server_brick dictionaries
Change-Id: I9046126739a126ee2d40249919e1fe58adf2fa27
BUG: 1349723
Signed-off-by: Apeksha D Khakharia <akhakhar@redhat.com>
Reviewed-on: http://review.gluster.org/14788
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: ShwethaHPanduranga
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: ShwethaHPanduranga
commit c84269ebdad4b14f4a15d0aa7211e07df5884dfe
Author: Apeksha D Khakharia <akhakhar@redhat.com>
Date: Sun Jun 26 14:10:38 2016 +0530
distaf: modifications to create volume function
Change-Id: Ifba1bc96f1f620b41fd5c61c345e8ac148e9250a
BUG: 1350168
Signed-off-by: Apeksha D Khakharia <akhakhar@redhat.com>
Reviewed-on: http://review.gluster.org/14797
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: ShwethaHPanduranga
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 0a4083154254a674a1d876a53703d5ca14ea567c
Author: Mohit Agrawal <moagrawa@redhat.com>
Date: Mon Jun 13 12:41:15 2016 +0530
rpc/socket.c: Modify approach to cleanup threads of socket_poller in socket_spawn.
Problem: Current approach to cleanup threads of socket_poller is not appropriate.
Solution: Enable detach flag at the time of thread creation in socket_spawn.
Fix: Write a new wrapper(gf_create_detach_thread) to create detachable thread
instead of store thread ids in a queue.
Test: Fix is verfied on gluster process, To test the patch followed below procedure
Enable the client.ssl and server.ssl option on the volume
Start the volume and count anon segment in pmap output for glusterd process
pmap -x <glusterd-pid> | grep "\[ anon \]" | wc -l
Stop the volume and check again count of anon segment it should not increase.
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Change-Id: Ib8f7ec7504ec8f6f74b45ce6719b6fb47f9fdc37
BUG: 1336508
Reviewed-on: http://review.gluster.org/14694
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit cb83034184676a6d0b3d26a7347cc0a626e12158
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Feb 5 15:10:06 2016 +0530
afr:Don't wind reads for files in metadata split-brain
Problem: For a read on a file in metadata split-brain:
1.lookup_done resets event_generation to zero.
2. readv is issued, goes to inode refresh due to mismatching event_gen.
3. After refresh is successful, we update event_generation, data and
metdata readable.
3. We then call afr_read_txn_refresh_done() which in turn calls
afr_inode_get_readable() but doesn't check for EIO. So afr_readv_wind
is called with local->readable (which is populated with data_readable),
thus winding the read to a brick.
4. Also, further parallel reads that come directly go to the wind path
because there is no inode_refresh needed.
Fix:
1.For any afr_read_txn(), readable must be an intersection of data and metadata
readable.
2.Check for EIO in afr_read_txn_refresh_done().
Change-Id: I22dd221fdfaf96d7aced2f474e28ed1337d69f0e
BUG: 1305031
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13389
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit cf65c5f1f15ec2298e2a81c7c4f288e310346d88
Author: Shwetha Panduranga <spandura@redhat.com>
Date: Mon May 16 15:18:06 2016 +0530
Adding distaf config file for gluster tests.
Change-Id: Id16bc316a202fa373774f380dfd86903516b80ac
BUG: 1336373
Signed-off-by: Shwetha Panduranga <spandura@redhat.com>
Reviewed-on: http://review.gluster.org/14357
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 13109f9235e5b476e7cf4c6bcee018e16d3e949e
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jun 15 16:02:44 2016 +0530
features/index: Do deletion of name-index in unwind path
Previously the deletion of name index was being done before
winding the xattrop to posix. This order needs to be changed
to ensure we don't lose the index in the event the xattrop fails
in posix xl.
Change-Id: I4aa892b102cbf5269cede041b871064563cb7348
BUG: 1331323
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14742
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit d5d358e8034caa1edb83db28ea177f91c77c0c23
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Jun 23 17:41:09 2016 +0530
ganesha/scripts : delete nfs-ganesha folder from shared storage during clean up
A directory named "nfs-ganesha" will be created inside shared storage when
'gluster nfs-ganesha enable' is executed. Similarly this directory should be
removed when 'gluster nfs-ganesha disable' is executed.
Change-Id: Icc09b32010de07c9809e22aafbb2fd08a5c8252f
BUG: 1349398
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14782
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 02c08d5f96fd543322c8a22f491d6ea306010434
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Wed Jun 22 01:27:25 2016 +0800
cluster/dht: Wrong type of function's parameter when calling dht_selfheal_dir_xattr_cbk
The second parameter's type is call_frame_t *, and we change
it to be type xlator_t *, it is exactly what we need in this function.
Change-Id: I6a154edcaa5a11084d837ca925efbfac853d0786
BUG: 1346551
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: http://review.gluster.org/14737
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 3517bf2a18a8c009ff3e41e085f436497802f109
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Jun 23 11:56:10 2016 +0530
glusterd/ganesha : persist value set by teardown in info file
During teardown, all the volumes exported via NFS-Ganesha will be
unexported. So all related volume options need to reset. Currently
this change made using dict_set on volopt dictionary, i.e change
is only reflected in memory not persisted in the volume info file
Therefore incase of glusterd restart this data can be lost.
Also this patch fix similar issue in ganesha_manage_export().
Change-Id: Ib843ac30adb28a70e13a9a1df57020ef2f3db8a4
BUG: 1349270
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14778
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 0ca1d5a255dcc5058d519b3af9ba1a6f19ee1305
Author: Arthy Loganathan <aloganat@redhat.com>
Date: Wed May 4 15:12:23 2016 +0530
distaf: Added bitrot_ops and lib utils
Added library functions for gluster bitrot operations and added
functions in lib_utils.py which are generic across all components
Change-Id: I877ded038c9f4c1e7aa1a15b035fcd7ebb0da21f
BUG: 1332885
Signed-off-by: Arthy Loganathan <aloganat@redhat.com>
Change-Id: I877ded038c9f4c1e7aa1a15b035fcd7ebb0da21f
Reviewed-on: http://review.gluster.org/14209
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: ShwethaHPanduranga
Smoke: Gluster Build System <jenkins@build.gluster.org>
commit 10e037e93e60b01363b9332da65e081d63755956
Author: Apeksha D Khakharia <akhakhar@redhat.com>
Date: Tue May 24 12:20:59 2016 +0530
distaf: adding libraries to setup CTDB in gluster
Change-Id: Iad3493794cf05262f182334efc8e517e30698e39
BUG: 1339541
Signed-off-by: Apeksha D Khakharia <akhakhar@redhat.com>
Reviewed-on: http://review.gluster.org/14531
Reviewed-by: Vivek Das <vdas@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: ShwethaHPanduranga
commit 73632de061e9f973c0fc77549d6577f7bd53bfaa
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jun 22 13:05:10 2016 +0530
feature/gfid-access: Fix nameless lookup on ".gfid"
Problem:
In geo-replication, if the data copied from .snaps
directory to the master, the first set of copy after
uss is enabled doesn't get sync to slave.
Cause:
Enabling uss results in graph switch. So when the
lookup comes on "0x00...0d/gfid1" on new graph,
("0x00...0d' being the gfid of virtual directory
".gfid"), it fails as gfid-access xlator doesn't
handle it.
Fix:
Handle nameless lookup on ".gfid" in gfid-access
xlator.
Change-Id: I32be0064e8fd58068646dbf662432f4a3da14e77
BUG: 1348904
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14773
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 933ec929d12070ecf2df67c86456d0e4fa7eec0d
Author: Samikshan Bairagya <samikshan@gmail.com>
Date: Tue Mar 29 16:24:07 2016 +0530
Fix opRet value for volume info --xml call on non-existent volume
The opRet field was being assigned to 0 in the XML output when a
gluster volume info --xml call is made on a non-existent volume.
This change assigns a value of -1 to opRet for volume info calls
for non-existent volumes. Other fields like opErrno and opErrstr
are also assigned relevant values
Change-Id: I3920c602328f74252c87bb521f5a43d4bdc7d44d
BUG: 1321836
Signed-off-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-on: http://review.gluster.org/13843
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: darshan n <dnarayan@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 6a66889d212136b12623966d8f5b273e69a13481
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Jun 13 12:00:40 2016 +0530
geo-rep: Safely handle if unliked GFID not present in data list
If unlinked GFID is not present in data list to be synced then
Geo-rep worker was crashing with KeyError. Handled KeyError with
this patch.
BUG: 1345744
Change-Id: I5a1c9ca4473e32606df2e5c7e26c95faf55d44c0
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14706
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 13495e36deb2f099f5dada7a1886dc5089beceac
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Jun 13 12:26:24 2016 +0530
cluster/dht: initialize cbk before attempting inode-link
Otherwise inode-link failures in selfheal codepath will result in a
crash.
Change-Id: I9061629ae9d1eb1ac945af5f448d0d8b397a5022
BUG: 1345748
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/14707
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ca52d54167f3e77f3e7802e9fde0c6cc70676209
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jun 16 10:21:53 2016 +0530
cli: fix crash in arbiter keyword parsing
A negative case like `gluster volume create volname arbiter 3 /bricks{1..3}`
must not crash. 'arbiter' keyword is valid only for (3 way) replica volumes.
The .t that is added will crash and create a core *without* the fix when
run but will still pass all TESTs. Since the regression framework fails
the .t if it creates a core, we can consider it a valid test 'that
fails without the fix'.
Change-Id: Ie2d7ced66025ea3617d30f6f823b22401e6d2fde
BUG: 1346821
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/14738
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit dcbe97a81668d9d5552028d4c36cb5068323492e
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu Jun 16 11:24:30 2016 -0400
glusterd: unsafe strcat, strncat use in glusterd_op_stage_gsync_create()
SuSE build system post-compile analysis aborts pkg build due to
unsafe strcat, strncat usage.
Change-Id: I52ac41e1172d0c1e5695a91b9f731cc9e7de4db4
BUG: 1347354
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14745
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 7e5a25a339240c8253b8e6ef2b1d9452e07f8c48
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Jun 6 06:29:40 2016 -0400
gfapi: Fix IO error caused when there is consecutive graph switches
Issue:
Consider a simple situation, where glfs_init() is done, i.e. initial
graph is up. Now perform 2 volume sets that results in 2 client side
graph changes. After this perform some IO, the IO fails with ENOTCON.
The only way to recover this client is i guess another graph switch
or restart.
What actually is happening from code perspective:
Initial graph lets say A, followed by 2 consecutive graph switches
to B and C without any IO those two switches.
- graph_setup (A) as a result of GF_EVENT_CHILD_UP, and
fs->next_subvol = A
- glfs_init() results in fs->active_subvol = A, fs->next_subvol = NULL
- graph_setup (B) as a result of GF_EVENT_CHILD_UP, and
fs->next_subvol = B
- graph_setup (C) as a result of GF_EVENT_CHILD_UP, and
fs->next_subvol = C. It also sees that the previous graph B was never
set as fs->active_subvol, i.e. no IO or anything happened on B, so
can safely send GF_EVENT_PARENT_DOWN (by calling glfs_subvol_done(B)).
This parent down on B, results in child_down(B), which is fine.
But child_down also triggers graph_setup(B).
- graph_setup(B) as a result of GF_EVENT_CHILD_DOWN, and
fs->next_subvol = B, and GF_EVENT_PARENT_DOWN on C as explained
above. This again leads to GF_EVENT_CHILD_DOWN on C.
- graph_setup(C) as a result of GF_EVENT_CHILD_DOWN, and
fs->next_subvol = C, and GF_EVENT_PARENT_DOWN on B as explained
above.
Thus both the graphs B and C are disconnected, and hence the ENOTCON
Solution:
Remove the call to graph_setup() when the event is GF_EVENT_CHILD_DOWN.
It don't see any reason why graph_setup should be called when there is
child_down. Not sure what the original reason was, to have graph_setup
in child_down. git hostory shows the first patch itself had this call.
Change-Id: I9de86555f66cc94a05649ac863b40ed3426ffd4b
BUG: 1343038
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14656
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit dcf1e2af5ed180839b698d3c2248e0b29fc1e11d
Author: Shyam <srangana@redhat.com>
Date: Fri May 27 14:00:40 2016 -0400
io-stats: Fix io-stat dump to dump at all levels
Previous commit to fix the bug, where io-stat-dump was overwriting
the dump file when the client and a brick was on the same host,
failed to consider the existing behaviour where io-stats can
help generate closely correlated set of stats across clients
and bricks, by triggering the dump using the same command.
This was introduced in commit:
0facb11220aea20a6573b656785922219c9650cf
Further, by limiting the first io-stat to unwind the dump request,
there is no way to trigger other io-stat xlators in the stack to
dump their stat information.
This bug hence is being fixed by this commit keeping the
following in mind,
- We need to trigger io-stat-dump for all instances in the
graph when this attr is set
- We need to write the output to different files, so that
they do not overwrite each others data
- We need to prevent this xattr from being set on the path
that is used to trigger the io-stat-dump information
Change-Id: I31ec380f0d85e10313a9d7b977da0e1ec74638a6
BUG: 1322825
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/14552
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit f463d1973f31c19bc1395ad2e99e26c6480114e9
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jun 8 16:56:26 2016 +0530
geo-rep: Error message cleanup
If ssh returns 127 that means the remote gsyncd path is wrong
or push-pem failed during create. Existing error message was
pointing old documentation.
Change-Id: Ifbbb4a604fc0ae0fd5cb2746df6363bf28cde1e9
BUG: 1343943
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14673
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 4ed715028f086433b1bd22f8b0e740a040a062ce
Author: Apeksha D Khakharia <akhakhar@redhat.com>
Date: Wed May 18 16:41:30 2016 +0530
distaf: Added libraries to setup nfs-ganesha in gluster through distaf
Change-Id: Ifc4c6aa76f2fc6fb7a2de06c2fc458b0015c6951
BUG: 1337160
Signed-off-by: Apeksha D Khakharia <akhakhar@redhat.com>
Reviewed-on: http://review.gluster.org/14416
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: M S Vishwanath Bhat <msvbhat@gmail.com>
commit 4dc27919ae580120f5699499efa471d0015aaa32
Author: Arthy Loganathan <aloganat@redhat.com>
Date: Tue May 10 17:46:36 2016 +0530
distaf: Added library functions for gluster tiering operations
Change-Id: I08d77bdc1ca3f804e35b69abe39df2049eb7cf70
BUG: 1334721
Signed-off-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-on: http://review.gluster.org/14283
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: karthick
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 3ad42325811716bcbcb09ec5b0a6b6267a11ec3e
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Jun 9 16:53:19 2016 +0200
cluster/dht: Fix unsafe iteration on inode->fd_list
When DHT traverses the inode->fd_list, it does that in an unsafe
way that can generate races with fd_unref() called from other threads.
This patch fixes this problem taking the inode->lock and adding a
reference to the fd while it's being used outside of the mutex
protected region.
A minor change in storage/posix has been done to also access the
inode->fd_list in a safe way.
Change-Id: I10d469ca6a8f76e950a8c9779ae9c8b70f88ef93
BUG: 1344340
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/14682
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 422f11c3c0095131fa2dbe8ca99aaffb31d3eb60
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Mon Jun 13 11:34:51 2016 -0400
api: use versioned symbols for minor ABI change
No need to expand the API/ABI. E.g., see how glfs_lookupat
changed between 3.7.0 and 3.7.4 IIRC
(I originally argued against versioning the library. I wanted
to just add new functions as they were needed, as was initially
done for glfs_ipc and glfs_ipc_xd in the master branch for 4.0.
But others strongly wanted versioning.)
Having made the decision to use versioning, I believe we should
continue. At least until we have a public decision that we're
no longer going to use versioning.
Change-Id: I0c3b2c1cbb297ae2b2864b647c224922987d74ad
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14717
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c227dcc9a0ba3281e579f1e7e0fc0c4807a67e2f
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Tue Jun 14 15:07:51 2016 +0530
glusterd/geo-rep: remove unused variables
cleanup - remove unused variables, fix return
value.
Change-Id: I77b663bdae0ffe7667486f5f4e2355ef9757f960
BUG: 1346211
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/14728
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit beff461966b1870ef420c24c9c665cbe28a8dd04
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Apr 11 17:31:58 2016 +0530
performance/decompounder: Add graph for decompounder xlator
This xlator will fall below protocol/server.
This is mandatory xlator without any options.
Observed that the callback for decompounder translator
was not added which was causing volume start
to fail.
Added cbks for decompounder.
Change-Id: I3e16a566376338d9c6d36d6fbc7bf295fda9f3a6
BUG: 1335019
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13968
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 04d1547299a891c5da5bacb13cfdd4dfe2ca5654
Author: Anoop C S <anoopcs@redhat.com>
Date: Mon Jun 13 15:55:39 2016 +0530
api: Fix a typo in gfapi logging message framework
Change-Id: I8a44a37a73f0c92783aecac8187247db98957070
BUG: 1202274
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/14709
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 16a06e4a7383df66a1b162021c7691732e4b6e33
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Jun 11 18:43:42 2016 +0530
cluster/ec: Unlock stale locks when inodelk/entrylk/lk fails
Thanks to Rafi for hinting a while back that this kind of
problem he saw once. I didn't think the theory was valid.
Could have caught it earlier if I had tested his theory.
Change-Id: Iac6ffcdba2950aa6f8cf94f8994adeed6e6a9c9b
BUG: 1344836
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14703
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: mohammed rafi kc <rkavunga@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
commit 6527ee5e2b8ff2e27b2d981490cc448babba1145
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Jun 3 12:44:14 2016 +0530
glusterd/snapshot: free resource from the owner of memory
We are freeing memory from a function which is not the
owner of the memory.
Free should happen from the owner of resources.
Change-Id: If8772ba27f9eb65881dcdddde8d7dc431c1c0ee8
BUG: 1341796
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/14634
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ede464cc93e092271332c2fa3ccb177480606ca3
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Jun 13 15:28:41 2016 +0530
quota : rectify quota-deem-statfs default settings
Change-Id: I75c47c4a0f0eb898b5e32efe7f0a6a558d7f8007
BUG: 1345846
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/14708
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2fd4d43fce5d1b0041597284bb53f0a21127e816
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Jun 13 12:42:47 2016 +0200
cluster/ec: Fix race in timer cancellation
A race in timer cancellation for delayed unlock could cause a crash
if the cancelling thread fails to cancel the timer because it has
already been fired but not executed, and the callback is scheduled
out of the CPU, delaying it until the thread has released important
resources needed by the callback.
This patch improves the handling of this case to make it robust.
Change-Id: I5c8a8c6610c5136f71b938aa78b5878ba05238d4
BUG: 1345855
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/14712
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit e200ce6b378f221c5a385c6c6cc262713bfafe61
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Jun 9 17:29:26 2016 +0200
cluster/ec: Fix invalid __fd_unref() call
__fd_unref() doesn't do any cleanup, so it cannot be called to release
fd references, specially if it's the last reference.
The code has been changed to avoid a call to this function.
In the previous version we always tried to keep the newest fd in the
ec_lock_t structure. However this is not necessary. We'll always keep
one reference to an open file on the same inode. It's irrelevant if
the reference is new or old.
The function __fd_unref() has also been removed from fd.h to avoid being
used in the future since it's useless as it's defined now.
Change-Id: Ia728777fc8e464758d5ea4d3bf020f0603919039
BUG: 1344396
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/14683
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5b019282bdb68cdfc981b3be1a3a356bcd380e89
Author: karthik-us <ksubrahm@redhat.com>
Date: Fri Jun 3 01:04:01 2016 +0530
features/worm: fixed issue with write FOP for normal files
The write FOPs on normal files were being blocked after the recent change.
It should fail only for the WORM and WORM-Retained files, and should pass
for a normal file.
Using auto-commit period to check for dormant files instead of retention period.
Change-Id: I30f82d4de2ea2c59c1eb7b4449ba6a60e568cfd5
BUG: 1342259
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: http://review.gluster.org/14619
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Joseph Fernandes
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
commit b7d71af3d26e85c2d32ac0a3c7117dc8ca43963a
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed May 25 11:56:56 2016 +0530
geo-rep: Handle stime/xtime set failures
While setting stime/xtime, if the file or directory is already
deleted then Geo-rep will crash with ENOENT.
With this patch, Geo-rep will ignores ENOENT since stime/xtime can't
be applied on a deleted file/directory.
Change-Id: I2d90569e51565f81ae53fcb23323e4f47c9e9672
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1339471
Reviewed-on: http://review.gluster.org/14529
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 9231c0c799cc3ace344201955d370a13aff939dd
Author: Dan Lambright <dlambrig@redhat.com>
Date: Thu May 19 10:43:53 2016 -0400
cluster/tier: fix detach tier error message
Do not refer to obsolete syntax when throwing an error on detach tier.
Throw a warning if the user tries to commit a detach tier before
starting (or completing) the decommission process.
Change-Id: I9df28c1b42b8ab1790e1db5c0cd518432146c1d1
BUG: 1337227
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/14438
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit f41ef6af9d40316705af84d03b590be6dd582aa3
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Jun 10 14:25:14 2016 +0530
tests: fix bug-1344407-volume-delete-on-node-down.t
Test was earlier starting the volume which will always make volume delete fail.
so it was actually not validating BZ 1344407
Change-Id: I6761be16e414bb7b67694ff1a468073bfdd872ac
BUG: 1344407
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14693
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 8d4988fa8c85f3fd1b5e37d7e83ae436c69062e0
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Jun 1 17:57:41 2016 +0530
afr: Consider ENOSPC and EDQUOT as symmetric errors
Problem:
Since commit 8eaa3506ead4f11b81b146a9e56575c79f3aad7b, in replica 3, if a
brick is down and a create fails on the other 2 brick with EDQUOT, we consider
it an unsymmetric error and hence do not do post-op. So the dirty xattr
remains set on the parent dir, leading to conservative merges during heal when
all bricks are up. i.e. a file deleted on the source might re-appear after heal.
Fix:
Consider ENOSPC and EDQUOT as symmetric errors since there is no
possibility of partial inode or entry modification operations possible when
quota is enabled. IOW, if quota reports EDQUOT, the no. of bytes written
(or not written) will be the same on all bricks of the replica.
Likewise, the entry operation (create, mkdir...) will either succeed or
not succeed on all bricks.
Change-Id: Iacb1108e9ef4a918e36242fb4a957455133744e9
BUG: 1341650
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/14604
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
commit 2074143135b5259ede303e19e951090df913a9a2
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Fri Jun 10 18:23:43 2016 +0530
libgfapi/upcall : prepend "glfs_" to callback_arg, callback_inode_arg
Change-Id: I371525775db4f6a4d69beb94baaa53d17b16fb41
BUG: 1344714
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14702
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit 7f559764c22ab85ca8c33cf521ed4b77bb805f84
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Jun 10 16:33:04 2016 +0530
tiering/ctr: Fix strcpy coverity
Change-Id: I6cffba3e09a023f105dbf2975cc9a3ae1a965c31
BUG: 1344686
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/14696
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 433dcb7ab91c3895d53b4823b57cab6c3d812048
Author: Poornima G <pgurusid@redhat.com>
Date: Sun Jun 5 00:06:11 2016 -0400
protocol: Add framework to send transaction id with recall
Issue:
The upcall(cache invalidation/recall) event is sent from the bricks
to clients. In AFR/EC setup, it can so happen that all the bricks
will send the upcall for the same event, and if AFR/EC doesn't filter
out these duplicate notifications, the logic above cluster xlators
can fail.
Solution:
Use transaction id to filter out duplicate notifications.
This patch adds framework for duplicate notifications.
AFR/EC can build up on this patch for deduping the notifications
Change-Id: I66b08e63b8799bc5932f2b2545376138a5701168
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14647
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 736fba071f0dab788aa18fb8651ba766c227a540
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Jun 9 16:19:37 2016 +0530
cluster/ec: Pass xdata to dht in case of error
Problem: In case of mkdir failure, dht expects
error information so that it can act accordingly.
Aftre adding bricks and re balance, layout gets
changed. Fop "mkdir" with old layout returns EIO.
EC gets this error in xdata but does not pass it
back to dht. In this case dht will not be able to
take corrective action.
Solution: Return xdata back to dht
Change-Id: I24def8038e6880607689b7b046dc6428f564c6ab
BUG: 1344277
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/14679
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit ab296f61a45cddb0c4cc013c0324f2145ff55cfb
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jun 9 18:22:43 2016 +0530
glusterd: fail volume delete if one of the node is down
Deleting a volume on a cluster where one of the node in the cluster is down is
buggy since once that node comes back the resync of the same volume will happen.
Till we bring in the soft delete feature tracked in
http://review.gluster.org/12963 this is a safe guard to block the volume
deletion.
Change-Id: I9c13869c4a7e7a947f88842c6dc6f231c0eeda6c
BUG: 1344407
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14681
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit f4db3bdba61a582e84e2467ff4a192e0b4872135
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Mon Jun 6 14:44:35 2016 +0530
glusterd/geo-rep: Avoid started status check if same host
After carrying out add-brick, session creation is carried out
again, to involve new brick in the session. This needs to be done,
even if the session is in Started state.
While involving slave uuid as part of a session, User is warned
if session is in Started state. This check needs to be avoided
if it is same slave host and session creation needs to be proceeded.
Change-Id: Ic73edd5bd9e3ee55da96f5aceec0bafa14d3f3dd
BUG: 1342979
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/14653
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 4abb59c670981e63609f58dbd3f09bc0dfefee02
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jun 7 17:15:56 2016 +0530
libglusterfs: Negate all but O_DIRECT flag if present on anon fds
This is to prevent any unforeseen problems that might arise due to
writevs and readvs being wound with @flag parameter containing
O_TRUNC or O_APPEND especially wrt translators like sharding and ec
where O_TRUNC write or O_APPEND write on individual shards/fragments
is not the same as O_TRUNC write or O_APPEND write as expected by the
application.
Change-Id: I9e5206a6ce2b1b70df61ff23b1c961cf25bf7ff9
BUG: 1342171
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14665
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit f4aa5b19d921262d61a8161c251c92de4d296095
Author: Bipin Kunal <bkunal@redhat.com>
Date: Tue Jun 7 18:30:16 2016 +0530
nfs: build exportlist with multiple groupnodes
The EXPORT procedure of the MOUNT protocol does not correctly create
structures for the 'groupnodes' in the reply. Each 'groupnode' should be
a single entry in the 'nfs.rpc-auth-allow' volume option. Because the
value is handled as a single string, the encoding of the
groupnode->gr_name fails when the value of the volume option is longer
than 255 characters.
In the error case, encoding the EXPORTS reply fails, and the waiting
'showmount' command will not receive a reply and times out.
Splitting the allowed entries and creating a groupnode for each one
prevents the too long ->gr_name. This is following the structures for
the EXPORTS reply in the MOUNT protocol more correctly as well. Note
that the contents of ->gr_name is expected to be server dependent.
Change-Id: Ibbabad581cc9aa00feb80fbbc851a1b10b28383d
BUG: 1343286
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14667
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: bipin kunal <kunalbipin@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 84288410ec99dd6d0670f8868ab02ea218dce21d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue May 31 09:05:28 2016 +0530
tests: Add a test for conservative merge with granular esh
Change-Id: Ib8ada912451bf80b640d25e6e3a824216d055b5b
BUG: 1332566
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14601
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6f41ae97b89d9138a9f3f71ca81cabc596511062
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jun 3 18:22:22 2016 +0530
afr: afr-pending-xattr fallback check
Commit 6e635284a4411b816d4d860a28262c9e6dc4bd6a introduced a comma
separated list of values to be used as AFR's pending changelogs. If
this xlator option is missing in the volfile, fall back to using client
xlator names for constructing the pending changelog names.
Also, since the aforementioned commit was reverted from 3.7 and 3.8
branches, introduce GD_OP_VERSION_3_9_0 and change the op-version for this
feature to GD_OP_VERSION_3_9_0.
Change-Id: I3639b9ab475bd8d9929cc7527d9f4584dee1ad1b
BUG: 1285152
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/14642
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 9556a9a5bd53d8822c959df0fe28745ce6fb68f7
Author: Shyam <srangana@redhat.com>
Date: Fri Jun 3 14:58:16 2016 -0400
posix2: Creation of experimental shell for posix2 xlator
DHT2 comes with a new backend on-disk format, that requires
a new backend storage xlator. This experimental project will
house the artifacts for the same.
Change-Id: I71a3d60a0415d0c23b2294a02b838810fa8f101f
BUG: 1338991
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/14646
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 35206a6a5019b9536148faee08fb41c785284293
Author: Bipin Kunal <bkunal@redhat.com>
Date: Tue Jun 7 17:59:27 2016 +0530
xdr/nfs: free complete groupnode structure
The groupnode->gr_next pointer is not traversed upon free. This is
currently not a problem, because the pointer is never used. However the
correct way to free a groupnode should check the ->gr_next pointer and
free any of the groups that it encounters.
This problem was identified while correcting a problem with the MOUNT
protocol. The change "nfs: build exportlist with multiple groups" starts
to use ->gr_next.
Change-Id: I9d04eaf4c65bdb8db136321d60e70789da1739d7
BUG: 1343286
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14666
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: bipin kunal <kunalbipin@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 3956fadc798a987631254d4c4862ff7a6b820dae
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Thu Jun 4 14:55:17 2015 +0530
clang-analyzer: adding clang static analysis support
clang static analyzer is a source code analysis tool that
finds bugs in C, C++.
This patch automates clang analyzes part by integrating
it with 'make clang-check'
clang-checker.sh: runs clang analyzer with and without the
HEAD commit, and shows the bugs introduced by HEAD commit (if any)
sample report:
$[ glusterfs ]: make clang-check
================ Clang analyzer in progress ================
...
BASELINE BUGS LIST (before applying patch):
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Out of bound array access --> 3
Memory leak --> 1
Unix API --> 24
Dead increment --> 5
Dereference of null pointer --> 1995
Uninitialized argument value --> 2
All Bugs --> 2872
Called function pointer is null null dereference --> 4
Dead initialization --> 49
Dead assignment --> 691
Undefined allocation of 0 bytes CERT MEM0 C CWE --> 5
Argument with nonnull attribute passed null --> 84
Result of operation is garbage or undefined --> 9
TARGET BUGS LIST (after applying patch):
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Out of bound array access --> 3
Memory leak --> 1
Unix API --> 24
Dead increment --> 5
Dereference of null pointer --> 1995
Uninitialized argument value --> 2
All Bugs --> 2875
Called function pointer is null null
dereference --> 4
Dead initialization --> 49
Dead assignment --> 694
Undefined allocation of 0 bytes CERT MEM0 C CWE --> 5
Argument with nonnull attribute passed null --> 84
Result of operation is garbage or undefined --> 9
SUMMARY OF CLANG-ANALYZER:
~~~~~~~~~~~~~~~~~~~~~~~~~~
Extra 3 Bug[s] Introduced in: Dead assignment
Patch Value given by Clang analyzer '-1'
Explore complete results at
/home/user/work/glusterfs/baseline/results/index.html
/home/user/work/glusterfs/target/results/index.html
================= Done with Clang Analysis =================
Change-Id: I512e33cfc02885a111152fbc1832144261dda1da
BUG: 1228142
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/11083
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 166dd6a6478eca8240e5e8530fb253de9b97817d
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Jun 6 18:10:09 2016 +0530
nfs : store sattr properly in nfs3_setattr() call
nfs3_setattr stores the input arguments in cs->stbuf.
However, inode/entry resolution code overwrites cs->stbuf
after a successful resolution, thereby overwriting the
input arguments with iatt values stored on backend.
Hence operations like chmod/chown turns out to be a NOP.
Specifically following are the functions that overwrite
cs->stbuf:
nfs3_fh_resolve_inode_lookup_cbk
nfs3_fh_resolve_entry_lookup_cbk
Since we resort to inode resolution only when inode is not
found in inode table and lru limit guards the number of
inodes in itable, we run into this issue only when the data
set is bigger than lru limit of itable.
Fix is to store input arguments in a member other than
cs->stbuf.
Thanks Du for suggesting the fix
Change-Id: I7caef48839d4f177c3557d7823fc1d35c8294939
BUG: 1318204
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14657
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit d2129d40cb7f19ef84cfe973f4e376173b1bcdd5
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon May 2 16:51:10 2016 +0530
core, shard: Make shards inherit main file's O_DIRECT flag if present
If the application opens a file with O_DIRECT, the shards'
anon fds would also need to inherit the flag. Towards this,
shard xl would be passing the odirect flag in the @flags parameter
to the WRITEV fop. This will be used in anon fd resolution
and subsequent opening by posix xl.
Change-Id: Iddb75c9ed14ce5a8c5d2128ad09b749f46e3b0c2
BUG: 1342171
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14191
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 4b4c0a7d17e9370a79fd142052d09fd19324886d
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Jun 6 10:17:54 2016 +0530
cluster/ec: Restrict the launch of replace brick heal
Problem: When features.cache-invalidation is ON, a lot of
ec_notify function gets called which leads to launch of
too many heals. This leads to no heal completion,
which causes accumulation of heals.
Solution: ec_launch_replace_heal should not be launch
for every event. Replace brick will trigger a child up
event and then only this heal function should be called.
Change-Id: I57b44c6a279d57230daea1d93229be6069245b7d
BUG: 1342796
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/14649
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit cb049094abddd4bd41760c358ae943972e40717b
Author: Dustin Black <dblack@redhat.com>
Date: Thu Jun 2 16:15:25 2016 -0400
nfs: fix a typo in the help text for option rpc-auth.addr.reject
Added space to .description
Reported-by: James Shubin <purpleidea@gmail.com>
Change-Id: Ie4dd8774567ac4d8e1e8ec39aa3ab595d037101a
BUG: 1005257
Signed-off-by: Dustin Black <dblack@redhat.com>
Reviewed-on: http://review.gluster.org/14621
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit f4d34dbf2c52dcd0ed95e9c6f004f9e7d3507c97
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jun 3 04:22:27 2016 +0530
features/shard: Don't modify readv size
For o-direct reads application sends aligned size which needs to be
sent as is, otherwise o-direct writes where the file-size is not
aligned fails.
Change-Id: I097418ad92eda6c835d7352a3d2e53ea9d8e2424
BUG: 1342298
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14623
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d1389f7b1d5f38578df8c052bbb1ecfa96d925c8
Author: Dustin Black <dblack@redhat.com>
Date: Thu Jun 2 17:01:32 2016 -0400
Corrected default text for ARGP_FUSE_USE_READDIRP_KEY Changed from "off" to "yes" per BZ 1222915
Change-Id: Idffffee621560adb4cc02c1001d1ae21ca11941f
BUG: 1222915
Signed-off-by: Dustin Black <dblack@redhat.com>
Reviewed-on: http://review.gluster.org/14622
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 244563aaf32221e5a20246664c1f7c101247fdff
Author: Arthy Loganathan <aloganat@redhat.com>
Date: Tue May 24 15:06:27 2016 +0530
distaf: Added library functions for gluster quota operations
Change-Id: I4968918fc2bf5b67e3415fc7b9beb1b414ca6eb4
BUG: 1332952
Signed-off-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-on: http://review.gluster.org/14210
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: M S Vishwanath Bhat <msvbhat@gmail.com>
commit cd4dd5b365b7f4fbd4b90587a2b1e168361304d0
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Wed Jun 1 14:40:13 2016 -0400
common-ha: race/timing issue setting up cluster
The ganesha_grace resource agent can start before the ganesha_mon
resource agent, with the result that the crm_attribute that
ganesha_grace expects to find has not been created yet.
This is never (never? Or just so rarely that it has never actually
been seen during development) seen with four nodes, but with just
two nodes it's very repeatable.
Note that when long (FQDN) names are used it is not unexpected to
see Failed Actions in the output of `pcs status`, e.g.:
* nfs-grace_monitor_5000 on node1.fully.qualified.domain.name.com
'unknown error' (1): call=20, status=complete, exitreason='none',
last-rc-change='Wed Jun 1 12:32:32 2016', queued=0ms, exec=0ms
* nfs-grace_monitor_5000 on node2.fully.qualified.domain.name.com
'unknown error' (1): call=18, status=complete, exitreason='none',
last-rc-change='Wed Jun 1 12:32:42 2016', queued=0ms, exec=0ms
and as long as all the ganesha_grace_clone and cluster_ip-1
resource agents are in Started state then this is okay.
Change-Id: I726c9946ceb1ca92872b321612eb0f4c3cc039d8
BUG: 1341768
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14607
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 5b233be183bb1cb41a1de886736b142353e1e2b9
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Thu May 19 21:13:04 2016 +0530
glusterd/geo-rep: upgrade path when slave vol uuid involved
slave volume uuid is involved in identifying a geo-replication
session.
This patch addresses upgrade path, where existing geo-rep session
is gracefully upgraded to involve slave volume uuid.
Change-Id: Ib7ff5109b161592f24fc86fc7e93a407655fab86
BUG: 1337473
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14425
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 7e2480e100980c011315a96d3fafe09eac92758e
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Apr 14 16:19:40 2016 +0530
cluster/ec: Add/Modify description for eager-lock option
This patch provides description for disperse.eager-lock
option for disperse volume.
It also modifies the description for cluster.eager-lock
option to indicate that this option is only for replica
volume.
Change-Id: Ie73298947fcaaa6aaf825978bc2d27ceaff386d2
BUG: 1327171
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13999
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 8b76495157a67648649dd8345f2fd33f606022d9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jun 2 19:45:03 2016 +0530
posix, shard: Use page-aligned buffer for o-direct reads
and also make shard_readv_do() pass the correct flags when
the original fd is opened with O_DIRECT.
Change-Id: Ic2f8ad900743ed3f7cab56948bcf1358d247a311
BUG: 1342171
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14639
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit e7f9ab9c1cb81e79d3c40edfc01c5efa2ff2a861
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jun 3 13:07:24 2016 +0530
geo-rep: Fix volume stop with geo-rep session
The slave volume uuid is appended to slave_url
which is saved in 'gsync_slaves' dictionary with
the commit "http://review.gluster.org/13111".
But the gsyncd expects slave_url with out slave
volume uuid otherwise it fails which in turn
fails volume stop with geo-rep. This patch
fixes the same.
Change-Id: I036f4fce43115ff848daebfe1b2c58765cffab5a
BUG: 1342420
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14636
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 053a8114c110b752270301648040e52bb8fc3832
Author: Susant Palai <spalai@redhat.com>
Date: Mon May 9 01:12:17 2016 +0530
dht : add metalock/unlock
Change-Id: I842a7ea1b286f1b893b200fe647597e7fd0f2105
BUG: 1331720
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14252
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 6eb9b4d80e6a9786a8bdac03080d7077b1d0edc3
Author: Susant Palai <spalai@redhat.com>
Date: Fri Apr 22 15:20:39 2016 +0530
posix/lock: implement meta-lock/unlock functionality
problem : The lock state needs to be protected when rebalance is reading the
lock state on the source. Otherwise there will be locks left unmigrated.
Hence, to synchronize incoming lock requests with lock-migration, meta lock
is needed. Any new lock request will be queued if there is an active meta-lock
and with sucessful lock migration, will be unwound with EREMOTE, so that
dht module can wind the request to the correct destination.
On a successful lock migration, "pl_inode->migrated" flag is enabled. Hence,
any further request would be unwound with EREMOTE and will be redirected to
new destination.
More details can be found here:
https://github.com/gluster/glusterfs-specs/blob/master/accepted/Lock-Migration.md
design discussion:
https://www.gluster.org/pipermail/gluster-devel/2016-January/048088.html
Change-Id: Ief033d5652b5ca4ba6f499110a521cae283d6aba
BUG: 1331720
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14251
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit a17df868f2b40a54dc9821b1d35ca8e13782b642
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Jun 1 23:01:37 2016 +0530
glusterd/snapshot: remove quota related options from snap volfile
enabling inode-quota on a snapshot volume is unnecessary, because
snapshot is a read-only volume. So we don't need to enforce quota
on a snapshot volume.
This patch will remove the quota related options from snapshot
volfile.
Change-Id: Iddabcb83820dac2384924a01d45abe1ef1e95600
BUG: 1341796
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/14608
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit a6ed517101fbe8cb5fce5d26489b86f4f723da05
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Jul 20 16:44:32 2015 +0530
glusterd: volgen and volume set changes for leases
Add leases xlator in volgen and also add corresponding volume set options
Change-Id: Ic5de50cdb87eaf6a833e739bc7e08fecbeca3de3
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/11722
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit d9314914183c69ad22d1c0bf8e80dd139311ef19
Author: Arthy Loganathan <aloganat@redhat.com>
Date: Tue May 24 15:23:43 2016 +0530
Added timeout value to wait for rebalance to complete and removed older rebalance library file
Change-Id: I89e2e436ec9306a80a87faab6d6e53f547ce4e42
BUG: 1339166
Signed-off-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-on: http://review.gluster.org/14515
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: M S Vishwanath Bhat <msvbhat@gmail.com>
commit df02fdd8cc19bb2efdbd071c3e4623c074c76f19
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jun 1 12:42:30 2016 +0530
glusterd/snapshot: Fix snapshot creation with geo-rep
The construction of path to geo-rep session directory
is broken with the commit "http://review.gluster.org/13111"
as it saves the slave volume uuid in 'gsync_slaves'
dictionary. This patch fixes the same.
Change-Id: Ic7fc3c37d368549feb44b3a08d60157ce61227c3
Signed-off-by: Kotresh HR <khiremat@redhat.com>
BUG: 1341474
Reviewed-on: http://review.gluster.org/14595
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 7c29adade0b9d93d1805a605db9e668f5118fe69
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue May 31 14:00:35 2016 -0400
build: RHEL7 unpackaged files .../hooks/S57glusterfind-delete-post.{pyc,pyo}
building on Real RHEL7 (versus mock?) results in installed (but
unpackaged) files found:
/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.pyc
/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.pyo
The same .spec file on Fedora 23 and RHEL6 does not encounter this
issue.
(Replacing the RHEL7 /usr/lib/rpm/brp-python-bytecompile file with
the one from Fedora 23 also makes the problem go away. But we are
probably not going to get a fixed rpm/rpmbuild soon enough to make
this go away by itself.)
Change-Id: Ib3db41cf0b7334a41b5174bba0c57e9aeb13407c
BUG: 1341294
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14590
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 58e8db63e2e353ab17f61a2992b2c546eb270e37
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Fri May 6 13:04:38 2016 -0400
libglusterfs (timer): race conditions, illegal mem access, mem leak
While investigating gfapi memory consumption with valgrind, valgrind
reported several memory access issues.
Also see the timer 'registry' being recreated (shortly) after being
freed during teardown due to the way it's currently written.
Passing ctx as data to gf_timer_proc() is prone to memory access
issues if ctx is freed before gf_timer_proc() terminates. (And in
fact this does happen, at least in valgrind.) gf_timer_proc() doesn't
need ctx for anything, it only needs ctx->timer, so just pass that.
Nothing ever calls gf_timer_registry_init(). Nothing outside of
timer.c that is. Making it and gf_timer_proc() static.
Change-Id: Ia28454dda0cf0de2fec94d76441d98c3927a906a
BUG: 1333925
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14247
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 14c9afc06f16f37f8d02b64bc472b29cbcf34d59
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Mon May 23 14:31:51 2016 +0530
__inode_ctx_put: fix mem leak on failure
up on failure case __inode_ctx_put need to free the allocated memory
Indirect leak of 104 byte(s) in 1 object(s) allocated from:
#0 0x496669 in __interceptor_calloc (/usr/local/sbin/glusterfsd+0x496669)
#1 0x7f8a288522f9 in __gf_calloc libglusterfs/src/mem-pool.c:117
#2 0x7f8a17235962 in __posix_acl_ctx_get xlators/system/posix-acl/src/posix-acl.c:308
Change-Id: I0ce6da3967c55931a70f77d8551ccf52e4cdfda3
BUG: 1338733
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14505
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 4d98da482beacb4e1748f043bda27e4185108f91
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue May 31 14:49:33 2016 +0530
cluster/afr: Unwind with xdata in inode-write fops
When there is a failure afr was not unwinding xdata to xlators above.
xdata need not be NULL on failures. So it is important to send it
to parent xlators.
Change-Id: Ic36aac10a79fa91121961932dd1920cb1c2c3a4c
BUG: 1340623
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14567
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit df611f229a301a86707a775e5a5d9d23fa5851ed
Author: Oleksandr Natalenko <oleksandr@natalenko.name>
Date: Tue May 17 16:45:44 2016 +0300
glusterfsd/main: Add ability to set oom_score_adj
Give the administrator a possibility to set oom_score_adj for glusterfs
process. Applies to Linux only.
Change-Id: Iff13c2f4cb28457871c6ebeff6130bce4a8bf543
BUG: 1336818
Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reviewed-on: http://review.gluster.org/14399
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 33ee084e683258469bedabf915dd997549f38f12
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue May 31 21:51:22 2016 +0530
features/index: Exclude gfid-type for '.', '..'
index_get_gfid_type is assuming all names are gfids where as some of these
entry->d_names can be '.' or '..'
Thanks a lot to Nithya for RC
BUG: 1336630
Change-Id: I06ad688a5865ab25b4f6c8a91af8c7fb2ed62186
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14589
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 20735f293f655d5c52d28a0481d7c6844a534509
Author: Poornima G <pgurusid@redhat.com>
Date: Thu May 19 05:04:13 2016 -0400
leases: Fix the recall code path
1. Replace frame->op usage with frame->root->op, as frame->op
is not filled with appropriate value in all cases
2. Add few log messages
3. Fix boolean assignment
Change-Id: I340f2200c1fcc4f4ce5a139b0fd22508cb8ac1e3
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14434
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 47ff9843ffa250b1d3eb0fd833e477be3c1d571c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 20 01:09:40 2016 +0530
protocol/client: Reflect readv/writev changes in filter-O_DIRECT description
Commit 74837896c38bafdd862f164d147b75fcbb619e8f introduced filtering
of O_DIRECT option even for readv/writev but the option description is not
updated.
Change-Id: I7c2b69fdb496ca27d1b06a458f2f3eab0d16d417
BUG: 1322214
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14441
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit da31e89e38d9f8b1eac7517aa5609887a41ae0b6
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon May 9 16:54:00 2016 +0530
features/changelog: Change barrier notification mechanism
The barrier notification mechanism was fd based and 'select'
was being used. 'select' breaks when number of fds opened
by brick process exceeds 1024. To avoid this and also
the maintainance of pipe between notify and 'changelog_rollover',
the pipe has been replaced with pthread condition signal
and timed wait mechanism.
Change-Id: I530ea90d9a06953f8b23b4e12d122872ee1925de
BUG: 1334314
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14272
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 6eba09f65fd22e0b543e3cb616946c13b5c800cc
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue May 24 14:33:54 2016 +0530
snapshot/uss: client-side log is filled with "invalid-argument" error
xdata is used without checking if it is NULL or not.
Change-Id: Ib6ddaab28ec3b430b8d646aada0456d3cc9978cb
BUG: 1339149
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/14511
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit cd3fbf920b266ca53a0cf2d9201f41a75bb06eaa
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu May 5 12:42:35 2016 +0530
features/worm: updating function names & unwinding FOPs with op_errno
- Added gf_worm prefix to some of the functions in worm-helper files so that
they do not clash with other functions
- Made the functions in worm.c static
- Unwinding the FOPs with op_errno instead of using different unwind statements
- Removed the multiple goto labels (wind & unwind)
Change-Id: I3a2f114061aae4b422df54e91c4b3f702af5d0b0
BUG: 1333263
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: http://review.gluster.org/14222
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 99da303e5dc73ddbffb94bd428729e23043ad1c8
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue May 31 12:29:10 2016 +0530
cluster/afr adding test case for http://review.gluster.org/#/c/14553/
Change-Id: I23865343021ae65a36f6abc74d6bd594efd9dc7e
BUG: 1340623
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14561
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 649eab1eec12ffeb62085bd8263b9b33840e7a6d
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue May 24 18:52:52 2016 +0530
gfapi/upcall : remove unused variable ret in glfs_h_find_handle
The variable ret is declared in glfs_h_find_handle(), but never used.
So while compiling following warning message will be printed.
glfs-handleops.c: In function ‘glfs_h_find_handle’:
glfs-handleops.c:1813:29: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
int ret = -1;
^
Change-Id: I599b7a4e87184aacd6c937e946defd4e270509c4
BUG: 1341007
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14524
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fd2bcd45305fedb9efc512905dc3892d6fa863e9
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Mon May 30 17:34:24 2016 +0530
geo-rep: update peers section in gsyncd conf
Problem:
Once Slave volume uuid is involved as part of a geo-rep session, it is
possible to create the same geo-rep session with different (slave)host.
But, it reflects default values for geo-rep configuration values originally
configured for old geo-rep session.
Reason is, slave host is used while saving config options in gsyncd.conf.
With new slave host, it is not possible to retrieve those config values.
Solution:
Remove slave host related information from gsyncd.conf and have only master
volume and slave volume as part of peers section.
Also, during upgrade from old geo-rep session, update peers section to
reflect only master volume and slave volume.
Change-Id: I7debf35a09a28d030b706b0c3e5d82c9b0467d0e
BUG: 1340853
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/14558
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 6e5a6b90fa412b5b98a5b949d36c39ab8cfd82a9
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Apr 11 11:07:17 2016 +0530
cli: Add test for heal info with ssl on
This test has been introduced to check
if we get proper heal info after enabling
management SSL.
Change-Id: I9c7721293b18cc10090b8695e49b5f4c8c766c6c
BUG: 1320388
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13959
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit e67b32763dd93066bef23f9204830b1ad9a1888b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon May 9 16:53:19 2016 +0530
storage/posix: Print offset,size and gfid too when readv fails
... for better debuggability.
Here's a sample log:
[2016-05-31 05:18:34.893951] E [MSGID: 113040] [posix.c:3089:posix_readv]
0-dis-posix: read failed on gfid=3744d34b-f798-4ce2-b421-cc632a9903bd,
fd=0x7f8b3c015abc, offset=131072 size=131072 [Invalid argument]
Change-Id: I069c17fecbb01a4a2b5dea1eb482c7f56a191fd3
BUG: 1341009
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14271
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 79c56be120c1ce0167dc14ed311575b136e4cb02
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon May 30 21:01:29 2016 +0200
fuse: accept the -s option to allow automounting
autofs passes the -s option when mounting. All /sbin/mount.<fs> helpers
accept this, except mount.glusterfs. Because the helper fails when -s is
passed accessing the mountpoint through autofs gives the following
error:
$ ls /lan/storage.lan.example.net/repos
ls: cannot open directory /lan/storage.lan.example.net/repos: Too many levels of symbolic links
BUG: 1340936
Change-Id: I84755cdac59e630618cb745c0eb3228cc1e93a1a
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14559
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Oleksandr Natalenko <oleksandr@natalenko.name>
commit a083b3c558df8e728c73c67d167e6aeb41758c6e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 27 15:47:07 2016 +0530
cluster/afr: Unwind xdata_rsp even in case of failures
DHT expects GF_PREOP_CHECK_FAILED to be present in xdata_rsp in case of mkdir
failures because of stale layout. But AFR was unwinding null xdata_rsp in case
of failures. This was leading to mkdir failures just after remove-brick. Unwind
the xdata_rsp in case of failures to make sure the response from brick reaches
dht.
BUG: 1340623
Change-Id: Idd3f7b95730e8ea987b608e892011ff190e181d1
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14553
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit b8c850ececd775c62be43bcb0665f895a95aebf6
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu May 26 08:25:37 2016 +0530
tests: Add more tests for granular entry self-heal feature
Change-Id: I6f14e413c538e392c8ee5bf4bf9f283e8ac792b7
BUG: 1332566
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14542
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 705d6d79b86d160f2a3e961e80d3981e6fb14cac
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue May 24 14:13:29 2016 +0530
geo-rep: Handle Worker kill gracefully if worker already died
If Agent dies for any reason, monitor tries to kill Worker also. But
if worker is also died then kill command raises error ESRCH: No such
process.
[2016-05-23 16:49:33.903965] I [monitor(monitor):326:monitor] Monitor:
Changelog Agent died, Aborting Worker(/bricks/brick0/master_brick0)
[2016-05-23 16:49:33.904535] E [syncdutils(monitor):276:log_raise_exception]
<top>: FAIL:
Traceback (most recent call last):
File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 306 in
twrap
tf(*aa)
File "/usr/libexec/glusterfs/python/syncdaemon/monitor.py", line 393, in
wmon
slave_host, master)
File "/usr/libexec/glusterfs/python/syncdaemon/monitor.py", line 327, in
monitor
os.kill(cpid, signal.SIGKILL)
OSError: [Errno 3] No such process
With this patch, monitor will gracefully handle if worker is already died.
Change-Id: I3ae5f816a3a197343b64540cf46f5453167fb660
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1339472
Reviewed-on: http://review.gluster.org/14512
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 93e5418da0458268b01e74bdf12aaf540d8a49fb
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri May 20 10:29:05 2016 +0530
tests/write-behind: move 1279730.t to BAD tests
There is a race condition which is causing the test to fail. For lack
of bandwidth I am moving this test to BAD, though clearly there is
some issue with codebase.
BUG: 1337777
Change-Id: If4f3eff8a5985f37a4dee65d2df29fa7b6bda7ae
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/14443
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit b741728dcce8ec6c2fb8fe5e27a819a5351383a0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu May 26 18:45:59 2016 +0530
cluster/afr: Fix warning about unused variable
BUG: 1336612
Change-Id: Ife1ce4b11776a303df04321b4a8fc5de745389d6
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14545
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit 04df3f8b823b072c2caeafaee0444e2a9ff8d6d2
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri May 27 16:16:37 2016 +0200
ganesha: fix the shebang for the copy-export script
BUG: 1340488
Change-Id: I22061a8b8bc0ea43da91e5b2904a27a674a004be
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14548
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 3e17626a7436a9737762ab8b7f337a58e0873018
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue May 24 11:37:21 2016 -0400
core: assorted spelling mistakes reported by Debian
See also
> Change-Id: I567a4be8f0f31f6285550f243fe802895f6bc43b
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
BUG: 1336793
Change-Id: Icb9a6ff94d86663a5bca4ba931d810439c02556e
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14526
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit edc18405f06ae5d061dcdaae80524073429283ba
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon May 16 14:55:54 2016 +0530
jbr/locking: Define path for lock/unlock fops in JBR
lock/unlock fops need to be handled differently than
other 'regular' fops, so as to avoid chances of deadlock
in blocking calls. This patch addresses the same in the
following manner, with a caveat.
1. On receiving the fop if the node is a follower, it
performs the operation (irrespective of it being
lock/unlock fop), and returns the result.
2. If the node is a leader it follows the following paths
for lock and unlock fops:
For lock fops :
-> It performs the fop on itself. If it is a failure, it
sends -ve ack to the client. If it is successful, it
dispatches the fop to the followers.
-> On receiving responses from the followers, it checks
for quorum (including the leader's outcome). If
quorum is met, it sends +ve ack to the client.
-> If quorum is not met, then it *should* issue a rollback
to the followers, followed by the rollback on the leader.
It should then send -ve ack to he client.
For unlock fops:
-> It dispatches the fop on the followers first.
-> On receiving responses from the followers, it performs
the fop on itself. On completion, it checks for quorum
(including the leader's outcome). If quorum is met, it
sends +ve ack to the client.
-> If quorum is not met, then it *should* issue a rollback
on itslef, followed by the rollback on the followers.
It should then send -ve ack to he client.
Caveat:
-> jbr-server does not have a rollback framework yet,
and hence this patch does not perform the rollbacks as
discussed in the failure scenarios above. The rollback
framework will be a different dependent patch.
Change-Id: I26961b27cb85f324c1ffeee80e82ec082ffa4465
BUG: 1333370
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/14226
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2bcab719e0de258869e5b6dafbd7e49cce20d29b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue May 24 15:25:19 2016 +0530
cluster/afr: Attempt name-index purge even on full-heal of directory
Change-Id: Ief71cc68a4fbf8113e15b4254ebcabf7e30f74e2
BUG: 1339181
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14516
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit adb14acd915512286981abcb1a9af90c8ff0dca5
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon May 2 18:45:44 2016 +0530
afr: Automagic unsplit-brain by [ctime|mtime|size|majority]
Introduce cluster.favorite-child-policy which when enabled with
[ctime|mtime|size|majority], automatically heals files that are in
split-brian.
The majority policy will not pick a source if there is no majority.
The other three policies pick the first brick with a valid reply and
non-zero ctime/mtime/size as source.
Change-Id: I3c099a0404082213860f74f2c9b4d207cfaedb76
BUG: 1328224
Original-author: Richard Wareing <rwareing@fb.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/14026
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e095980ee35bdff5cfc8ab693040b8d21e5f8992
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue May 10 12:13:18 2016 +0530
jbr: Making fop functions more modular to reuse more code
Putting bigger chunks of re-usable code like leader checks
and init into functions thereby reducing the size of the
'fop' call.
Introduced 'perform_local_op' in the 'fop' call, where
regular functions as of now just call dispatch, but fops
like 'lk' can do their fop specific operations.
Introduced selective_generate to allow certain functions
for a particular fop to be generated. The rest of the
functions can be customised and added in jbr.c
Change-Id: I3754ed68983e763329e14a2faef911428e36e4f0
BUG: 1336328
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/14355
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 6dd532c9e1fab7f4a74c4b8c41bd488ab461dece
Author: hari <hgowtham@redhat.com>
Date: Mon May 23 12:07:21 2016 +0530
Glusterd: printing the node details on error message of rebalance
Problem: on the rebalance start with one of the glusterd being
down among the volume, the error message says only about the
brick path.
Fix: adding the node details
Change-Id: I5827d3a9a15b0461c9ce3a51c0b16246ca58f335
BUG: 1337899
Signed-off-by: hari <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/14495
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 549e4fb8a2e2cfcb5ff14f02299a1eac865567a1
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue May 24 19:14:41 2016 +0530
snapshot/uss: client log is filled with "invalid argument: inode" error
svc_inode_ctx_get is called even if inode is NULL. We should not call
this function if inode is NULL
Change-Id: I5c3f17633ca88e5b6f40d4acf14a09e14b7ef62b
BUG: 1339149
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/14525
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit cacd6c9b881ee3c7df7f1bf3b52b416d2c2efeec
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue May 24 15:10:33 2016 +0530
snapshot/uss: log is filled with gfid is NULL error
In snapview-server if the lookup came on missing entry
then it does not have proper context to see if it is the
case of "Stale file handle" or ENOENT. We should not log
this error in GF_LOG_ERROR level, instead this should be
a debug log.
Change-Id: I8f7cc0e117e9a6dd9482da2e94a56f2ed731a442
BUG: 1339149
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/14514
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 35cee28a75f7e46287f7fec3824b4cd7509be118
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Fri May 20 15:16:17 2016 +0530
dht: selfheal should wind mkdir call to subvols with ESTALE error
Change-Id: I7140e50263b5f28b900829592c664fa1d79f3f99
BUG: 1338634
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/14496
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ed92d38cfc9a6c5b5fe24355541935da787d9743
Author: Susant Palai <spalai@redhat.com>
Date: Mon May 23 12:09:10 2016 +0530
dht/rebalance: mark hardlink failures as skipped in rebalance
Since rebalance(not remove-brick) process does not migrate hardlinks
mark them as skipped rather than failed as it creates confusion for
the users.
Change-Id: I5d469d10146274f00bb91482d0373c5235a9b8b2
BUG: 1339071
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14493
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit c5de55146182d80cbf8bb9bd362f1792539667d0
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue May 24 17:42:06 2016 +0530
gfapi/upcall: Use GF_CALLOC while allocating variables
In 'glfs_h_poll_cache_invalidation', use GF_CALLOC to allocate
'up_inode_arg' to set memory accounting which is used/referred when
freeing the same variable in case of any erros.
Change-Id: I365e114fa6d7abb292dacb6fc702128d046df8f8
BUG: 1339214
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/14521
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit b6eb829a6f8dfd0ffc0029a2a9dfe8d39ea801ea
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Jan 20 14:30:08 2016 +0530
cluster/ec: Use correct log levels
Problem :
Misleading messages are getting logged in mount logs
and bricks log.
"Mismatching xdata" and "Heal failed" are getting logged
Solution :
Reduce the level of logs from INFO, WARNING and NOTICE
to DEBUG level wherever applicable OR use fop_log_level
to get proper log level.
Change-Id: Ia824c71e75ab683d3cb8949e1966ea09c9ccce72
BUG: 1231224
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13266
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 97822edfc5fdc1a0d36b7072e42c937100830bfa
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon May 23 11:06:38 2016 +0200
build: include a dummy config.sub and config.guess in releases
There is no hard requirement for a config.guess and config.sub script in
the release tarball. By passing --build=... and --host=... to
./configure, the scripts are not executed. When doing local builds, the
./autogen.sh script (by running automake) will place a config.guess and
config.sub script in the root of the source tree. Upon creation of the
release ('make dist') tarball, the scripts are replaced by dummy copies
from the build-aux/ directory.
The main advantage to not include these scripts in the repository, is
that there is no need to track upstream updates for them either.
Change-Id: I5e930988a9e849ec5d0c84d2e30e61f2a9685f45
BUG: 1223937
Reported-by: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14503
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit db909325d00c593bda9fea90f67d117418b4d383
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu May 19 12:57:58 2016 -0400
common-ha: wait for cluster to elect DC before accessing CIB
access attempts, e.g. `pcs property set stonith-enabled=false`
will fail (or time out) if attempted "too early", i.e. before
the cluster has elected its DC.
Change-Id: Ifc0aa7ce652c1da339b9eb8fe17e40e8a09b1096
BUG: 1336945
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14426
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 322eee285a24cd2ed9ed1fe958a4f33b65481e2c
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Mon May 23 15:30:23 2016 -0400
common-ha: post fail-back, ganesha.nfsds are not put into NFS-GRACE
A little known, rarely used feature of pacemaker called
"notification" is used to follow the status of the ganesha.nfsds
in the cluster. This is done with location constraints and other
Black Magick.
When a nfsd dies, the ganesha-active attribute is cleared, the
associated floating IP (VIP) fails over to another node, and the
ganesha_grace notify method is invoked with post-stop on all the
nodes where the ganesha.nfsd is still running. The notify methods
send dbus msgs to put their nfsds into NFS-GRACE, and the nfsds
perform their grace processing, e.g. taking over locks from the
failed nfsd.
N.B. Fail-back was originally not planned to be a feature for
glusterfs-3.7, but we sorta got it for free.
For fail-back, the opposite occurs. The ganesha-active attribute
is recreated, the floating IP fails back, and the notify method is
invoked with pre-start on all the nodes where the surviving
ganesha.nfsds continue to run. The notify methods send dbus msgs
again to put their nsfds into NFS-GRACE again, and the nfsds clean
up their locks.
Change-Id: I3fc64afa20ae3a928143d69aa533a8df68dd680e
BUG: 1338967
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14506
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit abdc12d59948ad2869bac70338bbbaba4362859d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed May 18 14:37:46 2016 +0530
cluster/afr: Check for required number of entrylks
Problem:
Parallel rmdir operations on the same directory results in ENOTCONN messages
eventhough there was no network disconnect.
In blocking entry lock during rmdir, AFR takes 2 set of locks on all its
children-One (parentdir,name of dir to be deleted), the other (full lock
on the dir being deleted). We proceed to pre-op stage even if only a single
lock (but not all the needed locks) was obtained, only to fail it with ENOTCONN
because afr_locked_nodes_get() returns zero nodes in afr_changelog_pre_op().
Fix:
After we get replies for all blocking lock requests, if we don't have
the minimum number of locks to carry out the FOP, unlock and fail the
FOP. The op_errno will be that of the last failed reply we got, i.e.
whatever is set in afr_lock_cbk().
Change-Id: Ibef25e65b468ebb5ea6ae1f5121a5f1201072293
BUG: 1336381
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/14358
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit d0796ccc4165aaf866d84d516f8008a2ddb509c8
Author: Kremmyda, Olia (NSN - GR/Athens) <olympia.kremmyda@nokia.com>
Date: Sun May 22 21:40:19 2016 +0300
fuse: unref dict even if fuse_first_lookup fails
In fuse_first_lookup function, "dict_unref (dict)" should be included in
the out label, in case create_frame returns an empty pointer the dict to
be unreferenced as well.
Bug: 1338544
Change-Id: Ifb8a3378aec6521c1aa848f818968b6bfdb72089
Signed-off-by: Olia Kremmyda <olympia.kremmyda@nokia.com>
Reviewed-on: http://review.gluster.org/14464
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2f112ea4217d8359960426618f7a641a90a5aced
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu May 19 12:53:09 2016 +0200
nfs: strip trailing / when clients do subdir mounts
Mounting a volume over NFS with a subdir followed by a / does not work:
# mount -t nfs -o vers=3 storage.example.com:/media/installation/ /mnt
mount.nfs: an incorrect mount option was specified
In the nfs.log:
[client-rpc-fops.c:2930:client3_3_lookup_cbk] 0-media-client-0: remote operation failed. Path: /installation/ (00000000-0000-0000-0000-000000000000) [Invalid argument]
[client-rpc-fops.c:2930:client3_3_lookup_cbk] 0-media-client-1: remote operation failed. Path: /installation/ (00000000-0000-0000-0000-000000000000) [Invalid argument]
[mount3.c:1134:mnt3_resolve_subdir_cbk] 0-nfs: path=/installation/ (Invalid argument) [Invalid argument]
It is not possible to resolve paths with a trailing /. Stripping
trailing /'s from the subdir to mount is sufficient to make it work
again.
Change-Id: I4075d4cd351438de58e1ff81f0fb65a1ff076da4
BUG: 1337597
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14421
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 04a033cbffa5aea0beafe18ccf98152d2881de86
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu May 19 14:24:08 2016 -0400
common-ha: log flooded with Could not map name=xxxx to a UUID
When the cluster is configured with long (FQDN) cluster members
the log is flooded with "Could not map name=$shortname to a UUID"
notices, and setting/getting the attribute is failing
Change-Id: I954d8cef7115659cc9c8b23dae75a5a247dc5db7
BUG: 1337650
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14435
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
commit b670084165a2072056d97fb0ab60ef6348e74355
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed May 18 12:23:59 2016 +0200
index: improve compiler warning fix
Commit 137bd83029458ecd461718a891c74cd1afd8f6cb introduced some
typecasting to work around a compiler warning. It is much cleaner to
add a -1 value in the enumeration and use that in if-statements.
BUG: 1335232
Change-Id: I830a565b8d96d7b51ff775e94aa23dd567ffe0d9
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14409
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit ac82b9629d372a4a731a6624de4e3d5807ca6255
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri May 20 11:19:27 2016 +0530
tests: Add afr/tarissue.t to bad tests
Likey a tar binary bug and nothing to do with gluster but adding to bad
tests for now.
Change-Id: I5cc419f555fef98de555aabb16033f8fe7dc87d0
BUG: 1337791
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/14446
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit eb6c7260920e391d6ece1f9f8e85ec464278f4eb
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu May 12 15:06:59 2016 +0530
features/shard: Get hard-link-count in {unlink,rename}_cbk before deleting shards
Change-Id: I0606b74f11f5412c4d9af44a6505635ed9022c15
BUG: 1335858
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14334
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit f41ed1879acf14f5717a93233fe2fcd379378b5d
Author: hari gowtham <hgowtham@redhat.com>
Date: Mon May 16 10:55:17 2016 +0530
tier/cli : printing a warning instead of skipping the node
Problem: skipping the status of the nodes down creates confusion
to the user as one might see the status as completed for all nodes
and while performing detach commit, the operation will fail as the
node is down
Fix: Display a warning message
Note: When the last node is down (as per the peer list) then
warning message can't be displayed as the total number of peers
participating in the transaction is considered to be the total count.
Change-Id: Ib7afbd1b26df3378e4d537db06f41f5c105ad86e
BUG: 1324439
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/14347
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 1fc9fc195dca6dc8e95b743e4118c2ffc75d98fe
Author: M S Vishwanath Bhat <msvbhat@gmail.com>
Date: Thu May 19 18:53:35 2016 +0530
distaf: Adding GlusterBaseClass to distaflibs-gluster
GlusterBaseClass is the base class for gluster related test cases.
This has setup() method which takes care of creating volumes with
correct volume type after checking global_mode flags etc. So all tests
are recommended to use this base class.
The teardown() method is to teardown the setup that test has created.
Each test case should teardown, any setup it does apart from what is done
in setup().
The cleanup() method is used internally for cleaning up the volumes when
there is a change of volume type between the tests.
This patch also makes relevant import path changes.
The changes from tc.nodes[] to tc.servers[] in distaf-core broke few
tests. This patch fixes them.
Change-Id: I1a8ae20ca7cac13b7d25c587f98c23b430054a57
BUG: 1333738
Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
Reviewed-on: http://review.gluster.org/14239
Tested-by: M S Vishwanath Bhat <vbhat@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Apeksha D khakharia <akhakhar@redhat.com>
Reviewed-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-by: ShwethaHPanduranga
commit 392c2b2cb21b0a3e3a6b02c35c68951b73ff4dc8
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue May 3 17:02:17 2016 +0530
core: Honour mandatory lock flags during lock migration
lk_flags from posix_lock_t structure is the primary key used to
differentiate locks as either advisory and mandatory type. During
lock migration this field is not read in getactivelk() call path.
So in order to copy the exact lock state from source to destination
it is necessary to include lk_flags within lock_migration_info_t
structure to maintain accurate state. This change also includes
minor modifications to setactivelk() call to consider lk_flags
during lock migration.
Change-Id: I20a7b6b6a0f3bdac5734cce8a2cd2349eceff195
BUG: 1332501
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/14189
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 028c2aa57a3894e3cfeb3d16124d4a1baa6df298
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu May 19 16:24:09 2016 +0530
cluster/afr: Do not inode_link in afr
Race is explained at
https://bugzilla.redhat.com/show_bug.cgi?id=1337405#c0
This patch also handles performing of self-heal with shd-pid.
Also performs the healing with this->itable's inode rather than
main itable.
BUG: 1337405
Change-Id: Id657a6623b71998b027b1dff6af5bbdf8cab09c9
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14422
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 877398932712c4b9435e3d1df3f3ba559c2adf63
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 16 15:05:36 2016 +0530
cluster/afr: Refresh inode for inode-write fops in need
Problem:
If a named fresh-lookup is done on an loc and the fop fails on one of the
bricks or not sent on one of the bricks, but by the time response comes to afr,
if the brick is up, 'can_interpret' will be set to false in afr_lookup_done(),
this will lead to inode-ctx for that inode to be not set, this can lead to EIO
in case of a transaction as it depends on 'readable' array to be available by
that point.
Fix:
Refresh inode for inode-write fops for the ctx to be set if it is not already
done at the time of named fresh-lookup or if the file is in split-brain where
we need to perform one more refresh before failing the fop to check if the file
is still in split-brain or not.
BUG: 1336612
Change-Id: I5c50b62c8de06129b8516039f7c252e5008c47a5
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14368
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 6381a17b9aeb2c9f9213d06dbce2d770479f368f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Apr 29 17:41:18 2016 +0530
cli/glusterd: add/remove brick fixes for arbiter volumes
1.Provide a command to convert replica 2 volumes to arbiter volumes.
Existing self-heal logic will automatically heal the file hierarchy into
the arbiter brick, the progress of which can be monitored using the
heal info command.
Syntax: gluster volume add-brick <VOLNAME> replica 3 arbiter 1
<HOST:arbiter-brick-path>
2. Add checks when removing bricks from arbiter volumes:
- When converting from arbiter to replica 2 volume, allow only arbiter
brick to be removed.
- When converting from arbiter to plain distribute volume, allow only if
arbiter is one of the bricks that is removed.
3. Some clean-up:
- Use GD_MSG_DICT_GET_SUCCESS instead of GD_MSG_DICT_GET_FAILED to
log messages that are not failures.
- Remove unused variable `brick_list`
- Move 'brickinfo->group' related functions to glusted-utils.
Change-Id: Ic87b8c7e4d7d3ab03f93e7b9f372b314d80947ce
BUG: 1318289
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/14126
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 07986babec616a1bf3b5fd35dbba7c7357cfc39c
Author: Poornima G <pgurusid@redhat.com>
Date: Mon May 16 08:27:41 2016 -0400
leases: Do not init the threads when lease is disabled
Change-Id: I08c4caf94bf3dfceba6f7d3cc8945c61d9b12dbc
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14360
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c5533c0303322e6a217c01d7be2e7eefcfa3bf04
Author: Shwetha Panduranga <spandura@redhat.com>
Date: Thu May 12 19:31:41 2016 +0530
Adding proper doc_strings to the functions and modifying the existing functions in peer_ops
Change-Id: I819293c3191040232b6c9d30877f11b2857f3931
BUG: 1335494
Signed-off-by: Shwetha Panduranga <spandura@redhat.com>
Reviewed-on: http://review.gluster.org/14308
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: M S Vishwanath Bhat <vbhat@redhat.com>
Tested-by: M S Vishwanath Bhat <vbhat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit cf9acbdc4876187f80d75ab3038983c9052e232c
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue May 17 17:27:37 2016 -0400
common-ha: stonith-enabled option set error in new pacemaker
Setting the option too early results in an error in newer versions
of pacemaker. Postpone setting the option in order for it to succeed.
N.B. We do not use a fencing agent. Yes, we know this is not supported.
Change-Id: I86953fdd67e6736294dbd2d0795611837188bd9d
BUG: 1336945
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14404
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit a15707a449fc175cbac3350ac07a3a4f7b6f4197
Author: Poornima G <pgurusid@redhat.com>
Date: Tue May 17 01:22:37 2016 -0400
leases: Send "this" as cookie to the timer handler
Issue:
timer-wheel implementation doesn't set the THIS to point
to the xlator who registered the timer, before calling
the handler. Hence referencing to THIS is any timer handler
will point to the global_xlator.
Fix: This is a bug from the timer wheel, but until that gets
fixed passing "this" as a cookie to the timer handler.
Change-Id: Ife1be56dc100372f9211e8fc7a885ac717cbcf47
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14370
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 8228fb97f71144d414dd186948ffded95086b274
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Dec 16 05:45:03 2015 -0500
upcall: pass dict with xattrs on xattr invalidation
In case of xattr invalidation, return a dict containing
the updated xattrs.
[ndevos: move chunks to change 12995 and only address the xattrs-dict here]
Change-Id: I8733f06a519a9a0f24be1bb4b2c38c9c9dce0ce2
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/12996
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: soumya k <skoduri@redhat.com>
commit d1e1b871be4f368fdf60dfad65c9ae100ac6bf4b
Author: Poornima G <pgurusid@redhat.com>
Date: Tue May 17 05:47:55 2016 -0400
leases: Fix failure of RD_lease request in certain scenario
Issue:
When RW_lease exists for a given lease id and another request for
RD_lease comes in with the same lease id, it gets rejected.
Fix:
Allow the RD_lease when RW_lease is present iff its from the
same lease id.
Change-Id: Id8ad542c649497f5e58f2acf5681c640d9202046
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14374
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit f37da7c3bec0cbbbf0c15ed75710b088158d7400
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue May 17 06:38:57 2016 +0530
cluster/afr: If possible give errno received from lower xlators
In case of 3 way replication with quorum enabled with sharding,
if one bricks is brought down and brought back up sometimes
fops fail with EROFS because the mknod of shard file fails with
two good nodes with EEXIST. So even when quorum is not met, it
makes sense to unwind with the errno returned by lower xlators
as much as possible.
Change-Id: Iabd91cd7c270f5dfe6cbd18c50e59c299a331552
BUG: 1336612
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14369
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit 20ff1d2b03a7eab975b124d8651d76cdb4217b35
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Thu May 5 13:20:10 2016 +0530
git-branch-diff: wrapper script for git to visualize backports
This script helps in visualizing backported and missed commits between two
different branches, tags or commit ranges. In the list of missed commits,
it will help you identify patches which are posted for reviews on gerrit server.
While backporting commit to another branch only subject of the patch may
remain unchanged, all others such as commit message, commit Id, change Id,
bug Id, may be changed. This script works by taking commit subject as the
key value for comparing two git branches, which can be local or remote.
Help:
$ ./extras/git-branch-diff.py --help
usage: git-branch-diff.py [-h] [-s SOURCE] -t TARGET [-a AUTHOR] [-p PATH]
[-o OPTIONS]
git wrapper to diff local or remote branches/tags/commit-ranges
optional arguments:
-h, --help show this help message and exit
-s SOURCE, --source SOURCE
source pattern, it could be a branch, tag or a commit
range
-t TARGET, --target TARGET
target pattern, it could be a branch, tag or a commit
range
-a AUTHOR, --author AUTHOR
default: git config name/email, to provide multiple
specify comma separated values
-p PATH, --path PATH show source and target diff w.r.t given path, to
provide multiple specify space in between them
-o OPTIONS, --options OPTIONS
add other git options such as --after=<>, --before=<>
etc. experts use;
Sample usages:
$ ./extras/git-branch-diff.py -t origin/release-3.8
$ ./extras/git-branch-diff.py -s local_branch -t origin/release-3.7
$ ./extras/git-branch-diff.py -s 4517bf8..e66add8 -t origin/release-3.7
$ ./extras/git-branch-diff.py -s HEAD..c4efd39 -t origin/release-3.7
$ ./extras/git-branch-diff.py -t v3.7.11 --author="author@redhat.com"
$ ./extras/git-branch-diff.py -t v3.7.11 --author="authorX, authorY, authorZ"
$ ./extras/git-branch-diff.py -t origin/release-3.8 --path="xlators/"
$ ./extras/git-branch-diff.py -t origin/release-3.8 --path="./xlators ./rpc"
$ ./extras/git-branch-diff.py -t origin/release-3.6 --author="*"
$ ./extras/git-branch-diff.py -t origin/release-3.6 --author="All"
$ ./extras/git-branch-diff.py -t origin/release-3.6 --author="Null"
$ ./extras/git-branch-diff.py -t v3.7.11 --options "--after=2015-03-01 \
--before=2016-01-30"
Example output:
$ ./extras/git-branch-diff.py -t origin/release-3.8 --path="./rpc"
------------------------------------------------------------
[ ✔ ] Successfully Backported changes:
{from: remotes/origin/master to: origin/release-3.8}
[84e90b7] server/protocol: option for dynamic authorization of client permissions
[5bf6522] rpc: By default set allow-insecure, bind-insecure to on
[3af9b53] glusterd: try to connect on GF_PMAP_PORT_FOREIGN aswell
[9442e7b] rpc: fix binding brick issue while bind-insecure is enabled
[7370633] rpc: assign port only if it is unreserved
[88a386b] rpc: fix gf_process_reserved_ports
------------------------------------------------------------
[ ✖ ] Missing patches in origin/release-3.8:
All keys already loaded
[50ca123] rpc: define client port range (under review)
[89759de] glusterd: add defence mechanism to avoid brick port clashes (under review)
------------------------------------------------------------
Note: This script may ignore commits which have altered their commit subjects
while backporting patches. Also this script doesn't have any intelligence to
detect squashed commits.
Change-Id: Ieb27e548c1945a208e2f5d390c99cac82d18a665
BUG: 1336642
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14230
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit d7d341fc21646e90ce19de5ac433b22bc4d2d05e
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Mon May 16 14:38:24 2016 +0530
extra/devel-vagrant: accept gluster src location from user
Currently gluster source location is hard-coded in vagrantfile.
Made the source location user configurable and also fixed minor issue
with peer probe with single node.
Change-Id: I7057a97d7372477ddbf01fbc8db949923dfd86e8
BUG: 1336354
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/14354
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit bed3cb4b73f3f43ad3a7fb5cf6ae32931967d56c
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Fri May 13 13:17:16 2016 +0530
rpc: change client insecure port ceiling from 65535 to 49151
current port allocation to various processes (clumsy):
1023 - 1 -> client ports range if bind secure is turned on
49151 - 1024 -> fall back to this, if in above case ports exhaust
65535 - 1024 -> client port range if bind insecure is on
49152 - 65535 -> brick port range
now, we have segregated port ranges 0 - 65535 to below 3 ranges
1023 - 1 -> client ports range if bind secure is turned on
49151 - 1024 -> client port range if bind insecure is on
(fall back to this, if in above case ports exhaust)
49152 - 65535 -> brick port range
so now we have a clean segregation of port mapping
Change-Id: Ie3b4e7703e0bbeabbe0adbdd6c60d9ef78ef7c65
BUG: 1335776
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14326
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 040d7ba179c1c9f35b2a73a85329e024460ef72a
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Tue May 17 13:23:28 2016 +0530
dht: rename takes lock on parent directory if destination exists
For directory rename if destination exists the source directory
is created as a child of the given destination directory. Since
the new child directory does not exist take lock on parent of the
child directory.
Change-Id: I24a34605a2cd65984910643ff5462f35e8fc7e71
BUG: 1336698
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/14371
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 4c56d69dd8669df203820eb94b45fb3e4561ee78
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue May 17 11:06:07 2016 -0400
scripts: bash-isms in scripts
Change-Id: I05f8718fb73c16dbb37c1f7460bb7b55cc0ffe97
BUG: 1336853
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14401
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 43a67092343dec2fccfa0d893a835f7ca4eb9595
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue May 17 09:22:43 2016 -0400
core: assorted typos and spelling mistakes reported by Debian lintian
Also missing bang (!) in #!/bin/bash in shell scripts.
Change-Id: I567a4be8f0f31f6285550f243fe802895f6bc43b
BUG: 1336793
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14398
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 1a2e8d999bbcb4905ca9d75b11ed8954ca309fc2
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed May 11 18:24:40 2016 +0530
glusterd: copy real_path from older brickinfo during brick import
In glusterd_import_new_brick () new_brickinfo->real_path will not be populated
for the first time and hence if the underlying file system is bad for the same
brick, import will fail resulting in inconsistent configuration data.
Fix is to populate real_path from old brickinfo object.
Also there were many cases where we were unnecessarily calling realpath() and
that may cause in failure. For eg - if a remove brick is executed with a brick
whoose underlying file system has crashed, remove-brick fails since realpath()
call fails. We'd need to call realpath() here as the value is of no use.Hence
passing construct_realpath as _gf_false in glusterd_volume_brickinfo_get_by_brick ()
is a must in such cases.
Change-Id: I7ec93871dc9e616f5d565ad5e540b2f1cacaf9dc
BUG: 1335531
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14306
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 6b9383dae1a9590c71284ab737e1ca92f3c4a72b
Author: Arthy Loganathan <aloganat@redhat.com>
Date: Mon May 9 13:03:52 2016 +0530
distaf: Added library functions for gluster rebalance operations
Change-Id: I8df9199571dbf9e649d93e50f15cfbf3cea7f2bd
BUG: 1334208
Signed-off-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-on: http://review.gluster.org/14255
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: M S Vishwanath Bhat <vbhat@redhat.com>
commit 0cfe9288ac5c8da04776eb2397644515de4a286a
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri May 13 15:18:22 2016 +0530
Revert "features/shard: Make o-direct writes work with sharding"
This reverts commit c272c71391cea9db817f4e7e38cfc25a7cff8bd5.
This is for two reasons:
1) It introduces high fop latencies
2) Even with the patch, there is no true odirect behavior since the
workaround in the patch doesn't reduce the caching done in kernel's
page cache as far as writes on anon fds associated with individual
shards is concerned.
Change-Id: Iaf411198b56237ca0601deaf17f69ef178d7e769
BUG: 1335818
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14328
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit d00ca117aef30af3be1f1d979990bed3229ae126
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon May 16 19:53:44 2016 +0200
core: correct the if-statment in inode_set_need_lookup()
There does not seem to be an ill side-effect from the incorrect
if-statement. But we should really stick to the same checks we do
everywhere.
BUG: 1236009
Change-Id: If2b787287ac0d87712840b15b8c914e3dc5ffcde
Reported-by: kinsu <vpolakis@gmail.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14363
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1fb6673cf24d9d58a9c831f0af65585b60ee9fc1
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri May 13 11:40:57 2016 +0530
cluster/distribute: heal layout in discover codepath too
BUG: 1334164
Change-Id: I4259d88f2b6e4f9d4ad689bc4e438f1db9cfd177
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/14365
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit e05d03238ff01fd4a1547f49b5bafedca04919d2
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed May 11 17:49:10 2016 +0530
cluster/distribute: use a linked inode in directory heal codepath
This is needed for following reasons:
* healing is done in lookup and mkdir codepath where inode is not
linked _yet_ as normally linking is done in interface layers
(fuse-bridge, gfapi, nfsv3 etc).
* healing consists of non-lookup fops like inodelk, setattr, setxattr
etc. All non-lookup fops expect a linked inode.
Change-Id: I1bd8157abbae58431b7f6f6fffee0abfe5225342
BUG: 1334164
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/14295
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
commit 633a95e32b819fc4e0c0b2bdae39b01450644ed9
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri May 13 13:06:21 2016 -0400
cluster/tier: downgrade max-cycle-time log message to INFO
The "max cycle time" log message was incorrectly logged as
an error. Downgrade it to INFO.
Change-Id: Ia7d074423019fa79443bc6ea694148b7b8da455d
BUG: 1335973
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/14336
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit c03dbd93aadb28a4093d8d290ec35d34a5a92e34
Author: Poornima G <pgurusid@redhat.com>
Date: Tue May 10 01:50:08 2016 -0400
leases: Fix the notify being lost
The notify() implemented doesn't really add any value
and the EXIT_IF_LEASES_OFF in notify() can cause the
notifications to be lost if leases if off.
Hence remove the notify definition from leases,
also fix a log level
Change-Id: I8bf30d26f08034a16a450ed811dcf8ac57d70a94
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14275
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 946c6e904ddd4d0d83d2b36b43ada47e54083615
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Sun May 15 10:51:41 2016 -0400
common-ha: floating IP (VIP) doesn't fail over when ganesha.nfsd dies
restore mistaken removal of 'attrd_updater delete grace-active' to
trigger fail-over
original was:
attrd_updater -D -n grace-active
sleep
attrd_updater -D -n ganesha-active
mistake was:
sleep
attrd_updater -D -n grace-active
Change-Id: Ifb20ebc673b8d262dfb720e7d5c060fbf0d1639b
BUG: 1336197
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14343
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit d37d9dcd66061e1d25a69af01faf166c93e7342d
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri May 13 09:40:38 2016 +0530
configure: Prevent glupy installation outside $prefix
glupy was installed in the global path outside the prefix path,
even if --prefix is passed.
./configure --prefix=/usr/local
make install
Expected: ${DESTDIR}${prefix}/lib64/python<VERSION>/site-packages/gluster
Actual: ${DESTDIR}/usr/lib64/python<VERSION>/site-packages/gluster
prefix was not honoured.
With this patch, glupy will be installed inside the prefix path.
BUG: 1335717
Change-Id: I810dd8d2d6c403540d4b738f5ab54237c7358bf6
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14315
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 0a21e9686a1001286c1872867c0e687cd34c1c4a
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue May 10 21:10:08 2016 +0530
tier/detach: Clear tier-fix-layout-complete xattr after migration threads join
Previously we had wrongly placed the clearing tier-fix-layout-complete
xattr before the joining of migration threads. This would lead to
situations where failure of clearing the xattr would cause the
premature death of migration threads.
Now we clear the xattr only after the data movement threads join,
ensuring that all migration is done.
Change-Id: I829b671efa165ae13dbff7b00707434970b37a09
BUG: 1334839
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/14285
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Joseph Fernandes
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 8d4e7c222d71db244a59f328e108cd292803b6c9
Author: Anuradha Talur <atalur@redhat.com>
Date: Fri May 13 15:34:06 2016 +0530
cluster/afr : Do post-op in case of symmetric errors
In afr_changelog_post_op_now(), if there was any error,
meaning op_ret < 0, post-op was not being done even when
the errors were symmetric and there were no "failed
subvols".
Fix:
When the errors are symmetric, perform post-op.
How was the bug found :
In a 1 X 3 volume with shard and write behind on
when writes were done into a file with one brick down,
the trusted.afr.dirty xattr's value for .shard directory
would keep increasing as post op was not done but pre-op was.
This incorrectly showed .shard to be in split-brain.
RCA:
When WB is on, due to multiple writes being sent on
offset lying in the same shard, chances are that
same shard file will be created more than once
with the second one failing with op_ret < 0
and op_errno = EEXIST.
As op_ret was negative, afr wouldn't do post-op,
leading to no decrement of trusted.afr.dirty xattr.
Thus showing .shard directory to be in split-brain.
Change-Id: I711bdeaa1397244e6a7790e96f0c84501798fc59
BUG: 1335652
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/14310
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 898b75774de71da48b84873798e769c7dc27adf9
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Tue May 10 12:59:56 2016 +0530
extras: stop all include glusterfs process as well
currently, extras/stop-all-gluster-processes.sh script handles
brick processes, node services and geo-rep's gsync process.
from now this script also handles mount processes as well,
as part of this patch I have reorganized this script
Change-Id: Id62d6fda6dd331bde722ce3d99ec3f09fed55cb0
BUG: 1334620
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14277
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit edcf2d0624024094a04fab73eeb8912514e676aa
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri May 13 12:41:39 2016 +0530
index: Fix compiler warning
Problem:
----------------------------
index.c:420:18: warning: comparison of unsigned enum expression < 0 is
always false [-Wtautological-compare]
if (type < 0 || type >= XATTROP_TYPE_END)
~~~~ ^ ~
1 warning generated.
----------------------------
Fix:
Do a type cast before comparing.
Change-Id: I65911a05de5f8b5634f1e8cf359c38dad7d125aa
BUG: 1335232
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/14318
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 7a6bc2fb8c73863696036c3fe55958f31d36b3f9
Author: Kaushal M <kaushal@redhat.com>
Date: Thu May 5 14:19:55 2016 +0530
glusterfsd: explicitly turn on encryption for volfile fetch
Change-Id: I58e1fe7f5edf0abb5732432291ff677e81429b79
BUG: 1333317
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/14253
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 7f7a780e04eec579e31740b2a317fe611ee6d754
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Fri May 13 11:59:55 2016 +0530
ganesha/scripts : Fixing refresh config in ganesha-ha.sh
The change http://review.gluster.org/#/c/14225/ cause a regression
for refresh config funtion in ganesha-ha.sh due to a invalid usage
of awk arguement.
Change-Id: Id5adfb12f99b29bdb3531773cd34bd67cfff8768
BUG: 1333319
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14325
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit dbf44bd4e5c5180764ab70a8fc6bdc32e6c6642d
Author: Milind Changire <mchangir@redhat.com>
Date: Fri May 13 01:12:10 2016 +0530
packaging: %postun libs ldconfig: relative path `1' used to build cache
Remove %post{un} {libs|api} -p /sbin/ldconfig optimization and
move /sbin/ldconfig on a separate line.
Change-Id: I8a4c3879afcb7cea08d4b303a2524432d2ffec06
BUG: 1330583
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/14312
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 98d729ec9c68a06700ff71d3678bd13735316598
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Tue Dec 29 19:22:36 2015 +0530
glusterd/geo-rep: slave volume uuid to identify a geo-rep session
Problem:
Currently, it is possible to create multiple geo-rep session from
the Master host to Slave host(s), where Slave host(s) belonging
to the same volume.
For example:
Consider Master Host M1 having volume tv1 and Slave volume tv2,
which spans across two Slave hosts S1 and S2.
Currently, it is possible to create geo-rep session from
M1(tv1) to S1(tv2) as well as from M1(tv1) to S2(tv2).
When the Slave Host is alone modified, it is identified as a new geo-rep
session (as slave host and slave volume together are identifying
Slave side).
Also, it is possible to create both root and non-root geo-rep session between
same Master volume and Slave volume. This should also be avoided.
Solution:
This multiple geo-rep session creation must be avoided and
in order to avoid, use Slave volume uuid to identify a Slave.
This way, we can identify whether a session is already created for
the same Slave volume and avoid creating again (using different host).
When the session creation is forced in the above scenario, rename
the existing geo-rep session directory with new Slave Host mentioned.
Change-Id: I9239759cbc0d15dad63c48b8cf62950bb687c7c8
BUG: 1294813
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/13111
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Kotresh HR <khiremat@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit ac653905f88bc3167e9fb00369bf59397dee23a1
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed May 11 16:39:59 2016 +0530
mount/fuse: Log gfid and fd ptr as well when writev/readv fail
Change-Id: Iaed3850171155f2452fc29ebecd350c2da0b55cb
BUG: 1335091
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14291
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 424b54c0bb8aa06135a929061cee74fa79c79ecf
Author: Milind Changire <mchangir@redhat.com>
Date: Wed May 11 16:53:10 2016 +0530
packaging: additional dirs and files in /var/lib/glusterd/
Add directories /var/lib/glusterd/hooks and /var/lib/glusterd/hooks/1
to the list for server package ownership
Correct spelling for
/var/lib/glusterd/ss_brick and
/var/lib/glusterd/snaps
Change-Id: I5dffa1db610ccd7e1db4082977dd53afec4aecba
BUG: 1326410
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/14294
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 6f3a4988f700aeceab289c3599330b44ea04527f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu May 12 13:55:44 2016 +0530
cluster/afr: Handle non-zero source in heal-info decision
Problem:
Spurious entries are reported in heal info when the mount is on second/third
brick of the replica pair because local-child is given preference in selecting
source. The code is supposed to suggest the file needs heal if the (source < 0)
(failure code path), but instead it is written as if any non-zero value
is considered failure.
Fix:
Treat +ve source as success case
BUG: 1335429
Change-Id: I1be7f9defef2ae03be7eec8d7d49bf34adeca82c
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14302
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 32c9a0b710db5ab9b9927dfffef347145410332a
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed May 11 21:41:02 2016 +0530
locks: Fix a compile warning to use labs instead of abs
This addresses below compile warning generated -
posix.c:2260:32: warning: absolute value function 'abs' given an argument of type 'off_t' (aka 'long') but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
flock->l_len = abs (flock->l_len);
^
posix.c:2260:32: note: use function 'labs' instead
flock->l_len = abs (flock->l_len);
^~~
labs
Change-Id: Ifd8c5442de4076a2d4425487eb119ce89097779d
BUG: 1335231
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/14296
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 5e04d485d510f46f1fcf98b38378580d3f0d8d34
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Mon May 2 19:38:55 2016 +0530
tier: avoid pthread_join if pthread_create fails
this patch rearrange the code, to add some defence functionality for
pthread_create(), i.e. only on a success on pthread_create() call
pthread_join().
Change-Id: I0836bc950a210574cfdc755a666c6ac5df6ab430
BUG: 1332219
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14152
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 4f8c72ab94d052759bdbe27aea515ec16375dcd1
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Dec 7 16:24:15 2015 +0000
upcall: Add support to invalidate xattrs
When SElinux is used, clients should get a notification that the
extended attributes have been updated. Other components (like md-cache)
will be able to use this too.
A big part of the implementation comes from Poornima through the first
version of http://review.gluster.org/12996.
Also moving the flags from upcall-cache-invalidation.h to the main
libglusterfs upcall-utils.h file, so that other places can easily use
them in future.
Change-Id: I525345bed8f22d029524ff19ccaf726a2c905454
BUG: 1211863
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/12995
Reviewed-by: soumya k <skoduri@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit a4c1fbb698ed83ef4d7743cabeaa5218416cbb66
Author: M S Vishwanath Bhat <msvbhat@gmail.com>
Date: Wed May 4 17:08:33 2016 +0530
distaf: Adding README about distaf gluster tests
This README.md contains information about installing
the required packages before writing distaf tests.
Also illustrates writing the gluster related test cases.
Change-Id: I6dbdf069fa3adb13edd8af14e95f7676e1c93e9d
BUG: 1331721
Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
Reviewed-on: http://review.gluster.org/14240
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Jonathan Holloway <jholloway@redhat.com>
commit e62f149a18c736e78fb9d32cfb3d7264974b84b5
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon May 9 12:50:39 2016 +0200
socket: Fix incorrect handling of partial reads
The usage of function local variables in the protocol state
machine caused an incorrect behaviour when a partial read
from the socket forced the function to return and restart
later when more data was available. At this point the local
variables contained incorrect data.
Change-Id: I4db1f4ef5c46a3d2d7f7c5328e906188c3af49e6
BUG: 1334285
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/14270
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit bdd4662b14c10500d4be64c4bb90f7b51577f569
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon May 9 21:06:07 2016 +0530
gfapi: clear loc.gfid when retrying after ESTALE
If an ESTALE is returned as result of a revalidate lookup, it means the
previous gfid and inode are to be discarded and lookup has to be tried
as a fresh one. A fresh lookup should not have loc.gfid set. We were
creating a new inode and passing it down but not clearing loc.gfid.
This patch fixes that.
Change-Id: Ib192ada0528b5fb5e49b4e2555f2bcab62710e2d
BUG: 1334444
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/14274
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit e575d6364dc218c4193ec275378954c9e27fba58
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon May 9 09:49:01 2016 +0200
gfapi: fix compile warning on 32-bit systems
While compiling gfapi on a 32-bit system, I got the following warning:
glfs.c:1114:33: warning: format '%ld' expects argument of type 'long int', but argument 10 has type 'int64_t' [-Wformat=]
gf_msg_trace ("glfs", 0,
^
Change-Id: Ia910cbd2e1682d54c9ccfbf773c87d29facab7b0
BUG: 1202274
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14279
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 6ae3f953128741f61954a7b2225f148f6e634ece
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue May 3 14:29:45 2016 +0530
features/worm: When disabled, worm xl must directly pass fops to its child xl
Change-Id: I56ea46c2743636ef7af5c85469cb2e186eadf21f
BUG: 1332460
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14182
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 18470ff805d81e641bf89d74aae19e3472a4983c
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue May 10 13:03:42 2016 +0530
libglusterfs/gfapi: set appropriate errno for inode_link failures
We do not seem to be setting errno appropriately in case
of inode_link failures. This errno may be used by any application
(for eg., nfs-ganesha) to determine the error encountered. This
patch addresses the same.
Change-Id: I674f747c73369d0597a9c463e6ea4c85b9091355
BUG: 1334621
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/14278
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 7ea12caca8ae8b2f647b8803126780c85c2e223e
Author: Poornima G <pgurusid@redhat.com>
Date: Tue May 10 02:35:22 2016 -0400
client: Fix the message ids
The message id of PC_MSG_GFID_NULL was changed as a part of rebase
of http://review.gluster.org/#/c/11597. Fixing the same
Change-Id: I773e02fb5695b6b55700046f4a4298ec475f8991
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14276
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit f222360d28df224f4df2d4148cc456ed3a5caf04
Author: Prashanth Pai <ppai@redhat.com>
Date: Wed May 4 16:56:50 2016 +0530
readdir-ahead: Prefetch xattrs needed by md-cache
Problem:
Negative cache feature implementation in md-cache requires xattrs
returned by posix to be intercepted for every call that can possibly
return xattrs. This includes readdirp(). This is crucial to treat
missing keys in cache as a case of negative entry (returns ENODATA)
md-cache puts names of xattrs that it wants to cache in xdata and
passes it down to posix which returns the specified xattrs in the
callback. This is done in lookup() and readdirp(). Hence, a xattr
that is cached can be invalidated during readdirp_cbk too.
This is based on the assumption that readdirp() will always return
all xattrs that md-cache is interested in. However, this is not the
case when readdirp() call is served from readdir-ahead's cache.
readdir-ahead xlator will pre-fetch dentries during opendir_cbk
and readdirp. These internal readdirp() calls made by readdir-ahead
xlator does not set xdata in it's requests. Hence, no xattrs are
fetched and stored in it's internal cache.
This causes metadata loss in gluster-swift. md-cache returns ENODATA
during getxattr() call even though the xattr for that object exists on
the brick. On receiving ENODATA, gluster-swift will create new metadata
and do setxattr(). This results in loss of information stored in
existing xattr.
Fix:
During opendir, md-cache will communicate to readdir-ahead asking it
to store the names of xattrs it's interested in so that readdir-ahead
can fetch those in all subsequent internal readdirp() calls issued by
it. This stored names of xattrs is invalidated/updated on the next
real readdirp() call issued by application. This readdirp() call will
have xdata set correctly by md-cache xlator.
BUG: 1333023
Change-Id: I32d46f93a99d4ec34c741f3c52b0646d141614f9
Reviewed-on: http://review.gluster.org/14214
Tested-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 27f3c8affad3e30ff5ebb98f90cc8db91e42c2b9
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon May 9 11:56:37 2016 +0200
packaging: resource-agents sub-package needs arch-less requires
The glusterfs-resource-agents package is marked as 'noarch'. It should
therefor not have a dependency on a specific architecture (is done with
the _isa macro).
BUG: 1334269
Change-Id: I3d24c0e4e60e368b22eef97bf3aabe6b020a23a9
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14269
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit f1a2c7e0ab6d7ed564f734a68a19ab3b9251a632
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Fri May 6 12:07:41 2016 -0400
packaging: additional dirs and files in /var/lib/glusterd/
Directory /var/lib/glusterd/glusterfind/.keys doesn't need
to be created, it just needs to be listed in the list of files.
Also, S57glusterfind-delete-post.py under the hooks directory
is actually a symlink to libexec/glusterfs/glusterfind/...
so don't list %attr(...) for the symlink
Change-Id: Ia4571a7b5d0cc79c70cc120f7770bf2e6453bc84
BUG: 1326410
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14243
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit fc522ff0c4c5b4789b47e4724f395ad71cdece1e
Author: hari gowtham <hgowtham@redhat.com>
Date: Thu Apr 28 11:48:23 2016 +0530
heal/xml : xml implementation of heal info and splitbrain info
Current output:
heal didn't have xml output.
expected output with patch:
gluster v heal v1 info --xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<healInfo>
<bricks>
<brick hostUuid="3677edbb-0a6a-415e-b0ee-b846ff93259c">
<name>10.70.42.183:/home/bricks/b1</name>
<status>Connected</status>
<numberOfEntries>0</numberOfEntries>
</brick>
<brick hostUuid="3677edbb-0a6a-415e-b0ee-b846ff93259c">
<name>10.70.42.183:/home/bricks/b2</name>
<status>Connected</status>
<numberOfEntries>0</numberOfEntries>
</brick>
</bricks>
</healInfo>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
</cliOutput>
gluster v heal v1 info split-brain --xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<healInfo>
<bricks>
<brick hostUuid="3677edbb-0a6a-415e-b0ee-b846ff93259c">
<name>10.70.42.183:/home/bricks/b1</name>
<status>Connected</status>
<numberOfEntries>0</numberOfEntries>
</brick>
<brick hostUuid="3677edbb-0a6a-415e-b0ee-b846ff93259c">
<name>10.70.42.183:/home/bricks/b2</name>
<status>Connected</status>
<numberOfEntries>0</numberOfEntries>
</brick>
</bricks>
</healInfo>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
</cliOutput>
Change-Id: I20ad5eb7950d4721364ab46089e3af515162db82
BUG: 1331287
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/14100
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 23f4b7510a59704a4ab3014d42673df0f48ab819
Author: Joseph Fernandes <josferna@redhat.com>
Date: Mon May 2 16:20:30 2016 +0530
tier/detach : During detach check if background fixlayout is done
During detach check if background fixlayout is done, if not done ignore
the case and continue detach.
Change-Id: I5d5cfc0e73d0eb217fdeab54c432dc4af8bc598d
BUG: 1332136
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/14147
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 7339d58545121d39de43f9dc74a89c16151263da
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Apr 29 12:24:24 2016 -0400
gfapi: Fix a deadlock caused by graph switch while aio in progress
RCA:
Currently async nature is achieved by submitting a syncop operation to
synctask threads. Consider a scenario where the graph switch is triggered,
the next write fop checks for the next available graph and sets
fs->migration_in_progess and triggers the migration of fds and other
things, which can cause some syncop_lookup operation. While this fop (on
synctask thread) is waiting for syncop_lookup to return, lets say there
are another 17 write async calls submitted, all these writes are blocked
waiting for fs->migration_in_progress to be unset, hence all the 16
synctask threads are blocked waiting for fs->migration_in_progress to be
unset. Now the syncop_lookup returns, but there are no synctask threads to
process the lookup_cbk. If this syncop_lookup doesn't return,
then fs->migration_in_progress can not be unset by the first fop.
Thus causing a deadlock.
To fix this deadlock, changing all the async APIs to use STACK_WIND,
instead of syntask to achieve async nature. glfs_preadv_async is already
implemented using STACK_WIND, now changing all the other async APIs
also to do the same.
This patch as such will not reduce the performance of async IO, the only
thing that can affect is that, in case of write, the buf passed by
application is copied onto iobuf in the same thread wheras before it
was being copied in synctask thread.
Since, the syncop + graph switch logic (lock across fops) is not a good
candidate for synctask, changing the async APIs to use STACK_WIND
Change-Id: Idf665cae0a8e27697fbfc5ec8d93a6d6bae3a4f1
BUG: 1332156
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14148
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6d50dea3ac7849b16395a360e24235a2a6d25540
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Mon Aug 17 11:16:27 2015 +0530
remove unused variables
Cleaning dead initializations.
Change-Id: I53ae506593cd10441d61df3b2c9249544a7871f7
BUG: 1254067
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/11932
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit abbe365980e80459bf41459663a464e42e1ceb76
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue May 3 14:43:20 2016 +0530
dht:remember locked subvol and send unlock to the same
During locking we send lock request to cached subvol,
and normally we unlock to the cached subvol
But with parallel fresh lookup on a directory, there
is a race window where the cached subvol can change
and the unlock can go into a different subvol from
which we took lock.
This will result in a stale lock held on one of the
subvol.
So we will store the details of subvol which we took the lock
and will unlock from the same subvol
Change-Id: I47df99491671b10624eb37d1d17e40bacf0b15eb
BUG: 1311002
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13492
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 95539252d8402ec065cf8e2c347d6344d0c8f4ea
Author: M S Vishwanath Bhat <msvbhat@gmail.com>
Date: Fri Apr 29 20:38:23 2016 +0530
Adding io_libs to the distaflibs namespace packages
Following the gluster_libs, which was added to distaflibs
namespace package, this patch also adds io_libs to the same
namespace package.
Change-Id: Ife62f2dd0c966579546426a9dbc1a71d8c154292
BUG: 1331423
Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
Reviewed-on: http://review.gluster.org/14119
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jonathan Holloway <jholloway@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 1f7b0c04c017c4ed6482adaa324954b59b3685b9
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Apr 18 21:34:32 2016 +0530
glusterd-ganesha : copy ganesha export configuration files during reboot
glusterd creates export conf file for ganesha using hook script during
volume start and ganesha_manage_export() for volume set command. But this
routine is not added in glusterd restart scenario.
Consider the following case, in a three node cluster a volume got exported
via ganesha while one of the node is offline(glusterd is not running).
When the node comes back online, that volume is not exported on that node
due to the above mentioned issue.
Also I have removed unused variables from glusterd_handle_ganesha_op()
For this patch to work pcs cluster should running on that be node.
Change-Id: I5b2312c2f3cef962b1f795b9f16c8f0a27f08ee5
BUG: 1330097
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14063
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 3f33a7b2f1248d5e349616a7e3bb427250563a2f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 4 19:05:28 2016 +0530
cluster/afr: Do heals with shd pid
Multi-threaded healing doesn't create synctask with shd pid, this
leads to healing problems when quota exceeds.
BUG: 1332994
Change-Id: I80f57c1923756f3298730b8820498127024e1209
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14211
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit 1211368267836e148a52a462da7f3eafcc0885d9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu May 5 07:59:03 2016 +0530
protocol/client: Filter o-direct in readv/writev
Change-Id: I519c666b3a7c0db46d47e08a6a7e2dbecc05edf2
BUG: 1322214
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14215
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 9536964ed7e7216b8e3c3921a773f8bc595dfb85
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu May 5 14:52:32 2016 +0530
NFS-Ganesha : Parse the Export_Id correctly for unexporting volume
Currently export id parsed using "cut -d ' ' -f8" which might endup
in giving wrong value. In case of multiple space chracter, output
may differ. In this all those instance will replaced by awk call
Change-Id: I60dea8ce116900da3c1fc9badf898e51183a2ca1
BUG: 1333319
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/14225
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 63c1cce6a9255ae36ec301e406af4787a691c0ac
Author: hari <hgowtham@redhat.com>
Date: Thu Apr 28 19:36:25 2016 +0530
Tier/glusterd: Resetting the tier status value to not started
Problem: during a volume restart or tier start force, the
value of tier status is set as started irrespective of the result.
Fix: The appropriate value of status is set during the restart of
rebalance function.
Change-Id: I6164f0add48542a57dee059e80fa0f9bb036dbef
BUG: 1315666
Signed-off-by: hari <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/14106
Tested-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 79133e130f2d6ad7a19c7cc992eefead776b838c
Author: Arthy Loganathan <aloganat@redhat.com>
Date: Fri Apr 29 17:24:24 2016 +0530
distaflibs:Added snapshot library functions in distaf
Change-Id: I29407b05b8b76c1d5883172a66b15cf0038cb67e
BUG: 1332822
Signed-off-by: Arthy Loganathan <aloganat@redhat.com>
Reviewed-on: http://review.gluster.org/14115
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: M S Vishwanath Bhat <vbhat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit dc774c45795eeacbbe98cdca1f89f2e306202d0e
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed May 4 20:16:36 2016 +0530
cluster/dht: Perform NULL check on xdata before dict_get()
.. to prevent unnecessary logs from gf_msg_callingfn()
Change-Id: I367628fee2f6783ba9ed6f918deabd034df820c9
BUG: 1333043
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14212
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit f16686081ab8b146ba73034fd423b2465b81060f
Author: Anuradha Talur <atalur@redhat.com>
Date: Wed May 4 11:55:43 2016 +0530
heal: Fix incorrect heal info output
Problem:
In heterogenous clusters, heal info gives incorrect
outout as "Failed to process entries completely.
Number of entries so far: 0".
This happens when the getxattr on virtual xattr
for <brickpath>/.glusterfs/indices/dirty fails
on older bricks as they do not recognize the xattr.
Fix:
Ignore that error so that heal info doesn't
incorrectly report failure.
Change-Id: I0d3541ed0594d67c3c3b8568a89a975a100bf6dd
BUG: 1332798
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/14199
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit f59beaf64f1ec9a2c2ead24e7e8e45477a94b2ed
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Mar 19 11:40:26 2016 +0530
cluster/afr: Don't let NFS cache stat after writes
Problem:
Afr does post-ops after write but the stat buffer it unwinds is at the
time of write, so if nfs client caches this, it will see different
ctime when it does stat on it after post-op is done. From NFS client's
perspective it thinks the file is changed. Tar which depends on this
to be correct keeps giving 'file changed as we read it' warning.
If Afr instead has to choose to unwind after post-op, eager-lock,
delayed-post-op will have to be disabled which will lead to bad
performance for all write usecases.
Fix:
Don't let client cache stat after write.
Change-Id: Ic6062acc6e5cdd97a9c83c56bd529ec83cee8a23
BUG: 1302948
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/13785
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit be02722d713085d6d1fc0a5bfb5a784a53378870
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Feb 12 17:17:30 2016 +0530
performance/write-behind: guaranteed retry after a short write
* Don't mark the request with a fake EIO after a short write.
* retry the remaining buffer at least once before unwinding reply to
application. This way we capture correct error from backend (ENOSPC,
EDQUOT etc).
Thanks to "Vijaikumar Mallikarjuna"<vmallika@redhat.com> for the test
script.
Change-Id: I73a18b39b661a7424db1a7855a980469a51da8f9
BUG: 1292020
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/13438
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit a752cc6e0fd9e1cd1b0d3b6e6ed3645deacc3af1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 4 10:19:23 2016 +0530
libglusterfs: Fix security prefix comparison
BUG: 1331860
Change-Id: If35012ee35104848d7d3b21900c7f533d0253cde
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14194
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ac01d92b76d330ff50b5456dd19e43e32185fc76
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue May 3 09:29:46 2016 -0400
protocol/client: fix coding style violations
Commit 45fa52d7 added some massive violations of our 80-column rule.
This commit fixes them.
Change-Id: I7bb588b99dbbff4f0b9874ef10f200f73ac1b627
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/14192
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
commit 6f3eff966b499cc0296bbc0a70b3187b691cd9e4
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed May 4 11:21:31 2016 +0530
tests: assign bug id for br-state-check known issue
Change-Id: I13a1477830a023f40cb62097f04c22cd2d910021
BUG: 1332473
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/14198
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 73272f67d412ea2c231f5af4af17f4d228690257
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue May 3 15:08:30 2016 +0530
quota/tests : remove inode-quota-enforcing.t from bad tests
Change-Id: I4aef04cdbef7ecdabfe1dd64784cecf0624e6d8c
BUG: 1332021
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/14184
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 103c91da52d616afcff07fb85d60ebe957613014
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue May 3 15:12:08 2016 +0530
quota/tests : remove quota-ancestry-building.t from bad tests
Change-Id: Iaee0934d8be4e133b43bd390ed029f11cce1a24b
BUG: 1332020
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/14185
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit bb14fa28401e481fb7b9b7e8605b9e42ec6e7a59
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed Apr 27 19:12:19 2016 +0530
glusterd: add defence mechanism to avoid brick port clashes
Intro:
Currently glusterd maintain the portmap registry which contains ports that
are free to use between 49152 - 65535, this registry is initialized
once, and updated accordingly as an then when glusterd sees they are been
used.
Glusterd first checks for a port within the portmap registry and gets a FREE
port marked in it, then checks if that port is currently free using a connect()
function then passes it to brick process which have to bind on it.
Problem:
We see that there is a time gap between glusterd checking the port with
connect() and brick process actually binding on it. In this time gap it could
be so possible that any process would have occupied this port because of which
brick will fail to bind and exit.
Case 1:
To avoid the gluster client process occupying the port supplied by glusterd :
we have separated the client port map range with brick port map range more @
http://review.gluster.org/#/c/13998/
Case 2: (Handled by this patch)
To avoid the other foreign process occupying the port supplied by glusterd :
To handle above situation this patch implements a mechanism to return EADDRINUSE
error code to glusterd, upon which a new port is allocated and try to restart
the brick process with the newly allocated port.
Note: Incase of glusterd restarts i.e. runner_run_nowait() there is no way to
handle Case 2, becuase runner_run_nowait() will not wait to get the return/exit
code of the executed command (brick process). Hence as of now in such case,
we cannot know with what error the brick has failed to connect.
This patch also fix the runner_end() to perform some cleanup w.r.t
return values.
Change-Id: Iec52e7f5d87ce938d173f8ef16aa77fd573f2c5e
BUG: 1322805
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14043
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 86bcd248be446492bc05f4292ef22ae8c626faff
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue May 3 15:30:44 2016 +0530
tests: Move tests/bitrot/br-state-check.t to bad test
Change-Id: I9a1578ef4aeb8ce559b3af5092544b3023b14f87
BUG: 1332473
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14186
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 2ae04c44d1d841eae25ddbad00432d657c640a4b
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue May 3 12:50:51 2016 +0530
mgmt/glusterd: Fix op-version for mandatory-locking volume set option
The following volume set option will be available with 3.8 release.
locks.mandatory-locking
This one-line change is to fix the wrongly set op-version for the
above mentioned volume set option.
Change-Id: Icc7d213f917f5f69e2ec84c685b1138ce2f86a90
BUG: 1332413
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/14180
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 91d3e2f6168f09497828b00ee521f22032f7c040
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue May 3 14:47:19 2016 +0530
glusterd/bitrot: Fix bitrot xlator_type
Fix "voltype" value for bitrot in 'glusterd_volopt_map'.
Routines such as 'gd_is_boolean_option' will use
the value of "voltype" to load the shared
library and figure out data type of specific options.
If the value of "voltype" does not match with
the actual shared library name, it will break such
routines.
Change-Id: I36af4bb3e7043cc87dd19aea1985f3167ff82c18
BUG: 1332465
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14183
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 434c2a7c68545c075d16d4d602d69759dbf82c47
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Thu Apr 14 19:02:19 2016 +0530
rpc: define client port range
Problem:
when bind-insecure is 'off', all the clients bind to secure ports,
if incase all the secure ports exhaust the client will no more bind
to secure ports and tries gets a random port which is obviously insecure.
we have seen the client obtaining a port number in the range 49152-65535
which are actually reserved as part of glusterd's pmap_registry for bricks,
hence this will lead to port clashes between client and brick processes.
Solution:
If we can define different port ranges for clients incase where secure ports
exhaust, we can avoid the maximum port clashes with in gluster processes.
Still we are prone to have clashes with other non-gluster processes, but
the chances being very low in the rhgs Env, but that's a different story
on its own, which will be handled in upcoming patches.
Change-Id: Ib5ce05991aa1290ccb17f6f04ffd65caf411feaf
BUG: 1322805
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13998
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5a82f1c1ab27804dea437f0303fb35ecd3a378a2
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Thu Nov 5 15:09:31 2015 +0530
glusterd: remove-brick commit should not succeed when migration failed
While remove a brick if the data migration was not successful,
remove-brick commit should not succeed as this can lead to
data loss.
Change-Id: I1eac0ef775cc6910ece0e46ebb04051444d54393
BUG: 1278325
Signed-off-by: Sakshi Bansal <sabansal@localhost.localdomain>
Reviewed-on: http://review.gluster.org/12513
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
commit a0f373906ed13595087457bfd349666a7611fab4
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Mon May 2 18:09:12 2016 +0530
protocol/server: address double free's
Change-Id: Ic8a8fe85cf91c5c7aa93dce872cedbc67464e4ea
BUG: 1227667
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14150
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 7d485e52246cdfacc0ca8cd3ee33e43a1a785226
Author: Soumya Koduri <skoduri@redhat.com>
Date: Sat Apr 30 22:01:47 2016 +0530
gfapi/upcall: Ignore handle create failures
In "glfs_h_poll_cache_invalidation", we need to send upcall only if there
is a corresponding inode entry in the gfapi inode table for that handle.
That's because the application will have reference to the inode as long as
it operates on any handle. That means the only case in which we cannot find
inode is when the application has closed the handle (either as part of unlink
or for any other purpose). But since it will have no more references and will
not be interested in any upcall event for that handle, we can safely ignore such
cases.
Note: This will affect only that particular applicaiton process/local libgfapi
client.
Change-Id: I9499cd9c284350d4a271e58f2a0966db65a7a61c
BUG: 1331969
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/14132
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit d38161643ddd6e0bbc8389b48e8fabfa0121d3b3
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon May 2 15:33:13 2016 +0530
features/bitrot: Fix Compilation Warning!!!
Earlier the lock was using glusterfs macros
LOCK/UNLOCK/LOCK_INIT/LOCK_DESTROY. The patch
http://review.gluster.org/#/c/14140/ used 'pthread_cleanup_push'
interface for the same lock which was giving "initialization
discards qualifiers from pointer target type". It's strange that
the build succeeded in master branch with no warnings but fails for
the backport http://review.gluster.org/#/c/14140/ in 3.7 branch
treating this warning as error.
Change-Id: I75c8a65a2bfb1147fe9a84cfd8f09a97c089ae70
BUG: 1332134
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14146
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 50d9ed116a65db5d521a9a1f318844dae53975cf
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Apr 28 08:42:40 2016 +0200
cluster/ec: Fix issues with eager locking
Due to a race in timer cancellation, in some cases it was possible
to unlock the lock while another concurrent fop that needed it
continues execution as if it were not released.
This patch also fixes an issue that caused a lock to not be released
if an error was found while preparing ec_update_size_version().
Change-Id: I1344a3f5ecfc333f05a09e62653838264c9c26b1
BUG: 1331254
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/14112
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Chen Chen <chenchen@smartquerier.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit e19edee7b6798337a0bfc6e6f5656ae6facc697a
Author: Prashanth Pai <ppai@redhat.com>
Date: Wed Apr 27 13:37:07 2016 +0530
posix: Set correct d_type for readdirp() calls
dirent.d_type can contain the type of the directory entry. The 'd_type'
struct member in dirent is present in Linux and many BSD flavours.
However, filling d_type with correct value requires support from the
underlying filesystem. If not, d_type is set to DT_UNKNOWN. XFS added
support for d_type as part of their newer version 5 on-disk format.
However, this requires Linux >= 3.15, xfsprogs >= 3.2.0 and the bricks
to be formatted using the new format.
This patch enables posix xlator to set d_type to the right value even
when the underlying filesystem does not support it. d_type can be set
using information previously fetched by stat() on the dir entry.
This will aid FUSE applications to leverage d_type to avoid the expense
of calling lstat() if further actions depend on the type of the file.
Refer `man 3 readdir` and `man 2 getdents`
BUG: 1175711
Change-Id: Ic5a262fe4c64122726b4fae2d1bea375c559ca04
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/14095
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c22c31a72378b9371b262f288bc2646742ae61db
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun May 1 22:49:57 2016 +0200
disperse: mark bug-1236065.t as bad_test
tests/bugs/disperse/bug-1236065.t failed several times on different
Jenkins slaves:
* https://build.gluster.org/job/rackspace-regression-2GB-triggered/20316/console
* https://build.gluster.org/job/rackspace-regression-2GB-triggered/20320/console
* https://build.gluster.org/job/rackspace-regression-2GB-triggered/20321/console
BUG: 1332054
Change-Id: Ie1934f09f843c2089c187e9295288c16c01913d2
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14138
Reviewed-by: Susant Palai <spalai@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit e79d2a42c1b280286745b4908c414333a2936eb1
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Feb 4 10:34:33 2015 +0530
features/locks: Implement mandatory locks
Initial change to fix/enable the mandatory locking support in GlusterFS
as per the following design:
https://review.gluster.org/#/c/12014/
Accordingly 'locks.mandatory-locking' option is available as part of this
change which will accept one among the following values:
* off
* file
* forced
* optimal
See design doc for more details
Change-Id: I14c489b3f8af5ebcbfa155a03f0c175e9558ac46
BUG: 762184
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/9768
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 721126f2584fac11b54270c389caba7b7dc61338
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Apr 25 16:02:10 2016 +0530
cluster/dht: Handle rmdir failure correctly
DHT did not handle rmdir failures on non-hashed subvols
correctly in a 2x2 dist-rep volume, causing the
directory do be deleted from the hashed subvol.
Also fixed an issue where the dht_selfheal_restore
errcodes were overwriting the rmdir error codes.
Change-Id: If2c6f8dc8ee72e3e6a7e04a04c2108243faca468
BUG: 1330032
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/14060
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 6f6ea4603a014453c64974723ccb72f351a04747
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Apr 20 17:53:50 2016 +0530
cli/bitrot: Unmask scrub statistics
Revert the commit 2a37dbd845348a774f45c4d77cffebc32c749251
The scrub statistics were masked because of inaccurate
stats. Now with http://review.gluster.org/#/c/14044/
it's fixed, hence unmasking it.
Change-Id: Iffff5f48eb8121b617af82ecfb70bec5b2772c23
BUG: 1329211
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14121
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 71a654289a4fc6c9f04d10257880741cc7c840b0
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Apr 29 17:45:31 2016 +0530
features/bitrot: Introduce scrubber monitor thread
The patch does following changes.
1. Introduce scrubber monitor thread.
2. Move scrub status related APIs to separate file
and make part of libbitrot library.
Problem:
Earlier, each child of the scrubber was maintaining
the state machine and hence there was no way to track
the start and end time of scrubbing as each brick has
it's own start and end time. Also each brick was maintaining
it's own timer wheel instance. It was also not possible
to get scrubbed files count per session as we could not
get last child which finishes scrubbing to reset it to
zero.
Solution:
Introduce scrubber monitor thread. It does following.
1. Maintains the scrubber state machine. Earlier each
child had it's own state machine. Now, only monitor
maintains on behalf of all it's children.
2. Maintains the timer wheel instance. Earlier each
child had it's own timer wheel instance. Now, only
monitor maintains on behalf of all it's children.
As a result, we can track the scrub statistics easily
and correctly.
Change-Id: Ic6e34ffa57984bd7a5ee81f4e263342bc1d9b302
BUG: 1329211
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14044
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 82e47f64151606f541b5fffe9aa3d9c0ad4a1324
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Apr 20 23:49:39 2016 +0530
glusterd/bitrot: Fix bit-rot scrub status
Few of the dictionary values were not allocated and
set. This patch allocates them and set.
Change-Id: Ic61c1209b238e45219793fd8bec92235adfbd013
BUG: 1329211
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/14120
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 838fe69668cf0890c7623ccc42fa3b14e4ac2094
Author: Anuradha Talur <atalur@redhat.com>
Date: Mon May 2 00:36:30 2016 +0530
protocol/server: Implementation of compound fop
Change-Id: I981258afa527337dd2ad33eecba7fc8084238e6d
BUG: 1303829
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/14137
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 09a7accd82caed0ccd6e57ffc8f4913f5564cb94
Author: karthik-us <ksubrahm@redhat.com>
Date: Thu Feb 11 16:31:18 2016 +0530
WORM/Retention Translator: Implementation of file level WORM
To activate the file level worm feature, the features.read-only and
features.worm options should be switched "off" on the volume and
the features.worm-file-level should be switched "on". Both read-only
and worm or worm-file-level cannot be switched "on" together. The
files which are created when the worm-file-level option is set on the
volume will have their own retention profile.
If both worm and worm-file-level are "on" at that time the worm
which is the volume level worm will have priority over file level
worm. If worm-file level is switched "off" after some time and the
read-only option is switched "on" then read-only will have priority.
The current implementation allows the users to manually transmit
a file to a WORM-Retained state by removing all the write bits of
the file using the chmod command. The file will have a retention
profile which contains the state of the file, mode of retention,
and the default retention time.
The file will be made WORM-Retained for a default of 120 seconds
during which it will be immutable and undeletable and it sets the
atime of the file to the time till which it is retained.
After that period if any fop request comes for that file, will
make the transition from WORM-Retained state to WORM state, where
the file will be immutable but deletable and, it will reset
the atime to the actual atime of the file. If a WORM file needs
to be made undeletable again, it can be done by using the chmod
command with all the write bits removed.
There are two modes of retention:
1. Relax: where the retention time of a WORM-Retained file can be
increased or decreased.
2. Enterprise: where the retention time of a WORM-Retained file
can be increased but not be decreased.
Whenever a utime change(touch -a, -t, ...)request comes for a
file it checks the mode of retention before setting the utimes.
This is done only if the file is WORM-Retained but for a WORM file
it will change the utimes.
Lazy auto commit:
Whenever a file gets created it will store the creation time of the
file or if a file already exists then any of the next unlink, link,
truncate or rename fops will set the current time as the start time
in an xattr. The next rename/unlink/truncate/link call will check for the
auto commit period and if is is expired, then it will automatically do
the state transition. If it is a normal file then it gets converted
to WORM-Retained state. If it is a WORM-Retained file and its retention
period is expired, then it gets converted to WORM state.
Added the volume set options for the WORM translator. It allows the users
to change the default values of auto-commit-period, default-retention-period,
retention-mode. To make use of the file-level WORM first we have to set the
'worm-file' option to 'on'. The files which are created when the worm-file
option is set on the volume will get WORM-Retained. Other files will work
as usual and will not be WORMed. The auto-commit-period, retention-mode,
and the default-retention-period values for the file will be set to the values
which are set on the volume when the file is created.
Added the tests to check the basic functionalities of the WORM/Retention feature.
Change-Id: I77bd9777f9395a944d76b5cc35a5b48a3c14d148
BUG: 1326308
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: http://review.gluster.org/13429
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit e21bb0afa8239a2ae9cde88bff41d85ea2fc285e
Author: Susant Palai <spalai@redhat.com>
Date: Mon Apr 25 15:22:23 2016 +0530
dht/rebalance: add lock migration fop to dht_migrate_file
Change-Id: Id0e7400c8ae950c90d42a3ddf8b558a14959a1f8
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14074
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit b14575768d1d808fc39be32236bfe40861f615b3
Author: Susant Palai <spalai@redhat.com>
Date: Tue Apr 19 01:09:10 2016 +0530
cluster/dht: handle EREMOTE in dht lk/flush
With lock-migration, we need to send requests to destination
brick post migration. Once, the source brick marks the lock
structure to be already migrated, the requests will be redirected
to destination brick by dht_lk2/flush2.
Change-Id: I50b14011c5ab68c34826fb7ba7f8c8d42a68ad97
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/13493
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit d3543b7eeedd2ebf53233e3ce1e36e2d4d418b41
Author: Susant Palai <spalai@redhat.com>
Date: Mon Apr 18 17:42:06 2016 +0530
glusterd: volume set changes for lock migration
Change-Id: I48c6f9cdda47503615ba65882acd5eedf0a70c89
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14024
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 6a27a01df0190bea0d18f23944a6f49e50c82375
Author: Susant Palai <spalai@redhat.com>
Date: Sun Apr 17 10:23:20 2016 +0530
posix/lock: add setactivelk () fop
Change-Id: Ic7ad7362ac0e8bb0f8861698767c9ab7da539403
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14014
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 0e1c43b93f08c08739595ea93ea4ac4e92901efc
Author: Susant Palai <spalai@redhat.com>
Date: Sun Apr 17 10:23:02 2016 +0530
protocol: add setactivelk () fop
Change-Id: I60fe2d59c454095febce4c0fbef87a2dad9636e4
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14013
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit d9cfa300ba563e65bcba8d76a6d884ec25666ed2
Author: Susant Palai <spalai@redhat.com>
Date: Sun Apr 17 10:22:30 2016 +0530
io-threads: add setactivelk () fop
Change-Id: I74225a39348f6bb2fbdd1513676a70019227e45f
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14012
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 40d574ef2e468dd017afe97b0d25b10074c84cea
Author: Susant Palai <spalai@redhat.com>
Date: Sun Apr 17 10:21:59 2016 +0530
core: add setactivelk () fop
Change-Id: Ic2ba77a1fdd27801a6e579e04e6c0dd93cd7127b
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14011
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 98b65af3307b312dce93d63e1ca0dc3bc4da84ea
Author: Susant Palai <spalai@redhat.com>
Date: Sun Apr 17 10:17:42 2016 +0530
posix/lock: add getactivelk () fop
Change-Id: I99e41a80854d6f90572df755e14757099ae1236f
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/13995
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit cbad4b1f266298e8d4b39705efab4fb2ace3290b
Author: Susant Palai <spalai@redhat.com>
Date: Sat Apr 30 18:00:44 2016 +0530
protocol: add getactivelk () fop
Change-Id: Ie38198db990f133fe163ba160cdf647e34f83f4f
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/13994
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit d2a8954b2a853daf99e8e20817c9394c49ae56b1
Author: Susant Palai <spalai@redhat.com>
Date: Sun Apr 17 10:15:39 2016 +0530
io-threads: add getactivelk () fop
Change-Id: Iaef97ea02dfc54e1a0f23ab972f58b0687b4709c
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/13993
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 58dd3f1a69aaff3f36a8e9252d773540b6a3fd80
Author: Susant Palai <spalai@redhat.com>
Date: Sun Apr 17 10:14:02 2016 +0530
core: add getactivelk () fop
Change-Id: Ifd0ff278dcf43da064021f5c25e5dcd34347fcde
BUG: 1326085
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/13970
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 0b33cf4317a3fc6751341152ea2398ff89058584
Author: Susant Palai <spalai@redhat.com>
Date: Sun May 1 23:23:44 2016 +0530
quota: mark tests/basic/quota.t as bad_test
tests/basic/quota.t regularly leaves a core behind.
Some of the failed tests:
* https://build.gluster.org/job/rackspace-netbsd7-regression-triggered/16439/consoleFull
* https://build.gluster.org/job/rackspace-netbsd7-regression-triggered/16440/console
Change-Id: Iacf42c40f768dd2939994bbb87cc7ef366ee495f
BUG: 1332045
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14136
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 5bf9ededa6803cc7660e6c3770d9839b261fe7a3
Author: Susant Palai <spalai@redhat.com>
Date: Sun May 1 15:15:12 2016 +0530
quota: mark inode-quota-enforcing.t as bad_test
tests/basic/inode-quota-enforcing.t regularly leaves a core behind.
Some of the failed tests:
* https://build.gluster.org/job/rackspace-netbsd7-regression-triggered/16387/console
* https://build.gluster.org/job/rackspace-netbsd7-regression-triggered/16390/console
Change-Id: I6c9c8f3503f033a3a10d585efa2de13caf4ac610
BUG: 1332021
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14135
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 1b3a9136c85d9bdd910fe0750db0c90857fd6a63
Author: Susant Palai <spalai@redhat.com>
Date: Sun May 1 15:03:05 2016 +0530
quota: mark quota-ancestry-building.t as bad_test
tests/basic/quota-ancestry-building.t regularly fails like this:
./tests/basic/quota-ancestry-building.t (Wstat: 0 Tests: 34 Failed: 6)
Failed tests: 14-19
Files=1, Tests=34, 43 wallclock secs ( 0.05 usr 0.01 sys + 2.28 cusr 2.91 csys = 5.25 CPU)
Result: FAIL
./tests/basic/quota-ancestry-building.t: 2 new core files
End of test ./tests/basic/quota-ancestry-building.t
Some of the failed tests:
* https://build.gluster.org/job/rackspace-netbsd7-regression-triggered/16385/console
* https://build.gluster.org/job/rackspace-netbsd7-regression-triggered/16386/console
Change-Id: Ibbae908b4f752e195e7a7bdd10b102d7bcec312b
BUG: 1332020
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14134
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 82b4e4b823d2617c0f4140d27323f89933bdc158
Author: Susant Palai <spalai@redhat.com>
Date: Sun May 1 13:42:36 2016 +0530
disperse: mark bug-1304988.t as bad_test
tests/bugs/disperse/bug-1304988.t regularly fails like this:
[07:25:34] Running tests in file ./tests/bugs/disperse/bug-1304988.t
tar: Removing leading `/' from member names
./tests/bugs/disperse/bug-1304988.t ..
1..9
ok 1, LINENUM:19
ok 2, LINENUM:20
ok 3, LINENUM:21
ok 4, LINENUM:22
ok 5, LINENUM:23
ok 6, LINENUM:24
Started rename 26042
ok 7, LINENUM:33
ok 8, LINENUM:34
not ok 9 Got "in progress ::" instead of "completed", LINENUM:37
FAILED COMMAND: completed rebalance_status_field patchy
rebalance done...
Failed 1/9 subtests
Test Summary Report
-------------------
./tests/bugs/disperse/bug-1304988.t (Wstat: 0 Tests: 9 Failed: 1)
Failed test: 9
Files=1, Tests=9, 374 wallclock secs ( 0.02 usr 0.00 sys + 34.12 cusr 15.33 csys = 49.47 CPU)
Result: FAIL
End of test ./tests/bugs/disperse/bug-1304988.t
Some of the failed tests:
* https://build.gluster.org/job/rackspace-regression-2GB-triggered/20261/console
* https://build.gluster.org/job/rackspace-regression-2GB-triggered/20262/console
* https://build.gluster.org/job/rackspace-regression-2GB-triggered/20263/console
Change-Id: I0350a720f57f536d283c088e040680bbbe9f8f34
BUG: 1332022
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14133
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 4e4b04fc2170c803067859752398b6c18598a917
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Apr 29 13:42:54 2016 +0530
tests: Add test cases for add/replace brick with granular entry sh
Most of the tests borrowed from Anuradha's original replace-brick
and add-brick tests under tests/basic/afr/.
Change-Id: I874c04a6af3223e07aa6099b818ff502b6ba2a15
BUG: 1269461
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14130
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit fbb0977d4f0ef26eb4225f32b4522cfc1ac1ac0a
Author: Anuradha Talur <atalur@redhat.com>
Date: Fri Apr 29 16:12:10 2016 +0530
protocol/client : Implementation of compound fop
Change-Id: Iade71daf3bc70e60833d693ac55151c9cf691381
BUG: 1303829
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/14114
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit fc616ac819c7c6aee98603788f77c456e61aa3a0
Author: Anuradha Talur <atalur@redhat.com>
Date: Wed Apr 27 15:32:16 2016 +0530
protocol/client : Refactoring functions
These changes are made to accommodate compound fops.
The new functions that are added pack
the arguments required to perform the fops.
These will be used both by normal fops and compound ones.
Change-Id: I44d9cef8ff1d33aa2f5661689c8e9386d87b2007
BUG: 1303829
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/13963
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit fa2a68058ad624d9ddcad1931a72e411201eb9ab
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Apr 26 06:10:16 2016 +0530
tier/migrator: Fetch the next query file for the next cycle
Problem: When we spawn promote and demote thread, query files
are build. And only query file with index 0 is picked for migration
as the first query file. This may not be suitable for scenarios,
where the file in the query are too big to move in the first cycle,
as a result file in the other query files always get missed. We need to
shuffle so that other query files also get a chance.
Fix: Remember the previous first query file and shift it by one index,
before the migration starts.
Change-Id: I704947bcf4bab6b20b1179a6d9ae4a15a3d51bd9
BUG: 1330353
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/14068
Tested-by: Joseph Fernandes
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 8194e6529c229b6e13343f21dfcdf549bf62a05e
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Nov 2 08:55:46 2015 +0530
afr/index: changes for granular entry self-heal
Implements new indices type ENTRY_CHANGES where other
xlators can add/delete names.
Change-Id: I01c5568997085e11d22ba36a4376c70b78fb3827
BUG: 1269461
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12482
Tested-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 4a25dbe10b975e08444a7ec50372c747561e823a
Author: Poornima G <pgurusid@redhat.com>
Date: Wed May 27 12:55:50 2015 +0530
Leases: Add a server side xlator to handle lease requests
Before this patch, there was an effort to implement leases
in upcall xlator, these patches by Soumya and me can be
found @ http://review.gluster.org/#/c/10084/
Change-Id: I926728c7ec690727a8971039b240655882d02059
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/11643
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 873e88a29a3f6ac361f37d0d1be941c8ba9f9575
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Jul 9 15:22:43 2015 +0530
Protocol: Add lease fop
Change-Id: I64c361d3e4ae86d57dc18bb887758d044c861237
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/11597
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 0bcb66be34f34779f4554f2bbaf591fdcad580c0
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Apr 29 13:03:40 2016 +0530
geo-rep: Fix gluster binary invocation while running as cron
When scheduler script was executed as cron, it was unable to detect
the Gluster binaries.
BUG: 1331658
Change-Id: Ic9c533586ed9a472765f69aa2f87d004c46d4340
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14111
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b0cb24a49fab89ff7a05f284366102cd5c92f95c
Author: Anuradha Talur <atalur@redhat.com>
Date: Fri Apr 29 19:42:37 2016 +0530
libglusterfs : packing functions for compound fops
Any xlator that wants to compound fops together can
use these apis to get the job done.
Change-Id: Ic40fceafecafe70173fd469060e834314826a92c
BUG: 1303829
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/13694
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit d9036ad8455cf9cf6d365ff9fb4e49334f9f5510
Author: Anuradha Talur <atalur@redhat.com>
Date: Mon Feb 1 11:12:00 2016 +0530
rpc: added structures to support compound fops
Change-Id: Ida81e7b3145fb09afa37353244ff8721a4dc4c6a
BUG: 1303829
Signed-off-by: Anuradha Talur <atalur@redhat.com>
[ndevos: move definitions around to align with changes for bug 1328502]
Reviewed-on: http://review.gluster.org/13331
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 0662c48023ff1d2518ac37109dd1c766c2a3dff0
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Oct 14 14:14:51 2015 +0530
cluster/afr: Entry self-heal performance enhancements
Change-Id: I52da41dff5619492b656c2217f4716a6cdadebe0
BUG: 1269461
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12442
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit edf9c382d29de9d796d0d61acb8632701f2ac2f2
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 26 15:27:43 2016 +0530
glusterd: persist brickinfo->real_path
Since real_path was not persisted and gets constructed at every glusterd
restart, glusterd will fail to come up if one of the brick's underlying file
system is crashed.
Solution is to construct real_path only once and get it persisted.
Change-Id: I97abc30372c1ffbbb2d43b716d7af09172147b47
BUG: 1330481
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14075
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit b39a49a9f27c54065bac11a1ca7ca5368fd1f6cd
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 14 10:59:38 2016 +0530
dht/afr/client/posix: Fail mkdir without gfid-req
Do not allow directory creations without gfids as
after the directories are created, operations
on them fail anyway. So it is better to fail mkdir.
BUG: 1317361
Change-Id: I8f8e3b38bbded1960b7215bac0432500f7e78038
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13690
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 2eb9d29c336f904912e9f05758659e93cb369712
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Apr 27 16:12:49 2016 +0530
socket: Reap own-threads
Dead own-threads are reaped periodically (currently every minute). This
helps avoid memory being leaked, and should help prevent memory
starvation issues with GlusterD.
Change-Id: Ifb3442a91891b164655bb2aa72210b13cee31599
BUG: 1331289
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/14101
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit cb4e83a20f0be7052dd2c4c1c01b5d67699325ea
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed Apr 27 19:29:09 2016 +0530
glusterfsd: fix to return actual exit status on mount process
Problem:
Currently, we always exit mount process with the pid as the exit number
which is return value of the waitpid(), it is not the exit value of the
child process
Solution:
Extract the actual exit code/status in case if the child terminated normally,
that is, by calling exit(3) or _exit(2), or by returning from main()
Change-Id: Iefec6e27b5a5a98a22f016e49967978853662e37
BUG: 1331042
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14094
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 64a1a15fbbc692679fc15150b0f1cf94c2291bc1
Author: vmallika <vmallika@redhat.com>
Date: Sat Apr 2 09:50:11 2016 +0530
quota/glusterd: enhance quota enable and disable process
Previously quota crawl was done from the single mount point,
this is very slow process if there are huge number of files exists
in the volume
This RFE will now spawn crawl process for each brick in the
volume, and files are looked in parallel independently for each
brick. This improves the speed of crawling process for
entire files-system
This patch also fixes below problem
* Previously, mountdir was created under '/tmp'.
If someone tries to cleanup '/tmp'/ directory
then it is very dangerous that we loose volume data
So create a mount point under /var/run/gluster/tmp
instead
* Previously, file-system crawl is performed from all the nodes,
which is a redundant operation and performance will degrade
The problem is fixed with this patch
Change-Id: Icabedeb44182139ace9c8106793803122388cab8
BUG: 1290766
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12952
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 30b57df4c01504d4d64d26d12d492330c648dfe5
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Thu Apr 28 11:42:28 2016 +0530
glusterd: fix max pmap alloc to GF_PORT_MAX
This patch also mops the port max i.e 65535 hard coding
Change-Id: Ia93656d75ceb4c6c4849f9e0ad1b260d5952d4c6
BUG: 1331253
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14096
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit f08201c179c9d92eb6614624f84ae6ea55cc4145
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 18 21:47:18 2016 +0200
rpc: split FOPs enum from glusterfs.h
Moving the enumeration of FOPs and some of the other parts that are
defining the network protocol to the rpc/xdr/ section. These structures
need some care when modifications are made, moving them out of the
common glusterfs.h header helps with that.
The protocol definition structures are generated in a new glusterfs-fops
header. This file is present in rpc/xdr/src/ and libglusterfs/src/, it
is a little ugly, but prevents the need to update all Makefile.am files
with the additional -I option for finding the new header file.
The generation of the .c and .h files from the .x descriptions needed
small modifications to accommodate these changes. The build/xdrgen
script was improved slightly for this. The .c and .h files are
incorrectly in the $(top_srcdir), instead of $(top_builddir). This is
an existing issue, and bug 1330604 has been filed to get that addressed.
Change-Id: I98fc8cf7e4b631082c7b203b5a0a77111bec1fb9
BUG: 1328502
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14032
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit bbd9f2671e035aa04ba068ce4c6b57fc20ae3e18
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Apr 26 16:05:04 2016 +0530
protocol/client: Use loc->pargfid if loc->parent(->gfid) is not filled
Change-Id: Id73bf635ca94dcf7518b33e529ffca07daeeb1f4
BUG: 1269461
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14078
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 856653a1632079cd6855556ac22ec7132c51eebe
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu Apr 28 08:05:29 2016 -0400
glusterd: default value of nfs.disable, change from false to true
revert gf_msg -> gf_msg_plain change, i.e. restore gf_msg()
Change-Id: Ibdf9906c8a4bf92ba0969a08bb5a5c01dfd74680
BUG: 1092414
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14105
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 72f290b406fee16761abf09d899758fa74dfee74
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Apr 26 16:59:30 2016 +0530
gfapi: fill iatt in readdirp_cbk if entry->inode is null
If any of dirent have inode as null in readdirp_cbk, which indicates
that the stat information is not valid. So for such entries, we send
explicit lookup to fill the stat information.
Change-Id: I0604bce34583db0bb04b5aae8933766201c6ddad
BUG: 1330567
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/14079
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 4504778813aa14f8ccccedd38eb161e46c298940
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Apr 27 14:50:58 2016 +0200
build: remove unneeded include <sys/user.h> for FreeBSD
The include <sys/user.h> causes a conflicting definition of an RPC
'struct pmap':
--- fuse-helpers.lo ---
In file included from /usr/include/rpc/rpc.h:73:0,
from ../../../../libglusterfs/src/glusterfs-fops.h:35,
from /usr/home/jenkins/root/workspace/freebsd-smoke/libglusterfs/src/glusterfs.h:32,
from /usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mount/fuse/src/fuse-bridge.h:22,
from /usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mount/fuse/src/fuse-helpers.c:26:
/usr/include/rpc/pmap_prot.h:89:8: error: redefinition of 'struct pmap'
struct pmap {
^
In file included from /usr/include/vm/pmap.h:90:0,
from /usr/include/sys/user.h:52,
from /usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mount/fuse/src/fuse-helpers.c:19:
/usr/include/machine/pmap.h:299:8: note: originally defined here
struct pmap {
^
It seems that building on FreeBSD still functions without any additional
warnings or errors, even when the include is removed.
Change-id I98fc8cf7e4b631082c7b203b5a0a77111bec1fb9 identified this
issue, and this build-fix is needed for applying I98fc8cf7.
BUG: 1198849
Change-Id: Ib8241b7dc47eb2c3593d2f8ea1d196178e63d02d
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14093
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 17571aa237370215583d2de7dc1682303472ae65
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Wed Apr 6 11:18:30 2016 -0400
common-ha: continuous grace_mon log messages in /var/log/messages
messages are seen on RHEL6.x and RHEL7.1 and earlier versions of
pacemaker. (And RHEL7.2 with RHEL7.1 pacemaker packages.)
It's not possible to query attrd attributes in the older version,
only set/update/clear them. The messages come from invalid attempts
to query the attributes.
However it is possible to query crm attributes. The fix here is to
create a "shadow" crm attribute for the attrd attribute. Changes are
made to both, queries are made on the crm attribute.
(Resource Agents "follow" the attrd attribute using constraint locations,
so we must keep the attrd attribute.)
Change-Id: I84ac1a80673e528d98b67b7d5062e21dcf744d4a
BUG: 1324509
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13919
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
commit 806a42fd252b83028b1a83db28939fa4f3e0c2e9
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Tue Apr 26 18:40:04 2016 +0530
glusterd: try to connect on GF_PMAP_PORT_FOREIGN aswell
This patch fix couple of things mentioned below:
1. previously we use to try to connect on only GF_PMAP_PORT_FREE
in the pmap_registry_alloc(), it could happen that some foreign process
would have freed the port by this time ?, hence it is worth giving a try on
GF_PMAP_PORT_FOREIGN ports as well instead of wasting them all.
2. fix pmap_registry_remove() to mark the port asGF_PMAP_PORT_FREE
3. added useful comments on gf_pmap_port_type enum members
Change-Id: Id2aa7ad55e76ae3fdece21bed15792525ae33fe1
BUG: 1322805
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14080
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 6cb72b87886226fb1ff43323cd4ca7ee841c109d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Apr 27 11:41:05 2016 +0000
Swap order of GF_EVENT_SOME_CHILD_DOWN enum
GF_EVENT_SOME_CHILD_DOWN value seems to be mismatching between master and 3.7.
Fix the master since 3.7 is a release branch and GF_EVENT_SOME_CHILD_DOWN was
added newly and hence should be in the end in the enum list.
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: I1f758550d6300f6750d1574302096d8e7f493549
BUG: 1330974
Reviewed-on: http://review.gluster.org/14092
Tested-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 79fa1c6dd41ffda36d30947d74766e84b5178813
Author: Anoop C S <anoopcs@redhat.com>
Date: Fri Mar 18 10:32:09 2016 +0530
features/trash: wind mkdir with special pid
Recent changes done w.r.t handling of mkdir calls in posix translator
resulted in crashing the brick process from trash translator. This was
due to the changes made in posix translator to return EPERM for every
mkdir calls without 'gfid-req' set in dictionary. In order to avoid
gfid mismatches during directory creation from brick side trash
translator does not set 'gfid-req'. This patch is to have an exemption
for trash based on a special pid set for those mkdir calls originating
from trash translator and to reset it in callback.
This patch also includes a small optimization to the existing test case
for trash feature.
Change-Id: I59f084ac875e54342ecf2bffa6e43ebd84814153
BUG: 1317361
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/13776
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d0c3d3e3d9f4f325ce682c107a2d4db7d370769b
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Feb 15 18:16:04 2016 +0530
libglusterfs: Add debug and trace logs for stack trace
It has become very difficult to identify the xlator which returned
negative op_ret. Being able to just change the log level and
visualize the stack is helpful in such cases.
Change-Id: I6545b4802c1ab4d0d230d5e9e036afb2384882e1
BUG: 1330052
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13448
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 192fc7aa70d96ee8c133fa1d5c918b43a68f2a90
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Apr 22 11:43:45 2016 +0530
cluster/afr: Do not fsync when durability is off
BUG: 1329501
Change-Id: Id402c20f2fa19b22bc402295e03e7a0ea96b0c40
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14048
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 716dfd97eac6aad021799023fbd201cc52c78705
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Tue Apr 26 21:42:23 2016 +0530
rpc: fix gf_process_reserved_ports
this patch also does minor code cleanups.
Change-Id: I0d005bd0f9baaaae498aa1df4faa6fcb65fa7a6e
BUG: 1198849
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13997
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 4de6f0609ab07811d207fb73836d709589eaf429
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue Apr 26 10:10:05 2016 -0400
packaging: %postun libs ldconfig: relative path `1' used to build cache
%postun libs isn't 'closed' by the following %postun server on RHEL6
due to the %ifdef...%endif
But -server has /usr/lib*/libgfdb.so.x, so we should be running
/sbin/ldconfig! Which conveniently fixes the closing issue.
Change-Id: Icc365eefc5453c40e02b59288a4e8023b82baa7b
BUG: 1330583
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14081
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 12438399e231eb8da43443fe301f34b17743f837
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Apr 26 14:52:29 2016 +0530
gfapi: set need_lookup flag on response list
We set need_lookup flag for entries returned by readdirp
to force lookup. Currently we are setting on the previously
stored list, rather than response list returned by readdirp.
This patch will iterate over current list returned by readdirp
and will set need_lookup flag.
Change-Id: Ibd6fcbc188f4c87f40ece7a9dcda27645401c240
BUG: 1330476
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/14073
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 8555d5ff324d81ddd3f850cbab45c82f9ab85396
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Apr 26 19:49:34 2016 +0530
Rename enum _gf_client_pid to _gf_special_pid
Till now _gf_client_pid enum has been used to define special PIDs used
by glusterfs clients like shd, quotad etc. In order to have this enum
capable of holding all other special PIDs including the one used by
trash translator, _gf_client_pid is being renamed to _gf_special_pid.
Change-Id: Id123127771f18aa55d39f335801a54810848d7bc
BUG: 1330616
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/14083
Reviewed-by: Joseph Fernandes
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit bd3010b284ecd22e3345f123783545fd9d96e289
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 18 19:34:26 2016 +0200
snapshot: svc_stat collides with define from /usr/include/rpc/svc.h
Compiling fails with this error:
snapview-client.c:559:24: error: macro "svc_stat" passed 4 arguments, but takes just 1
dict_t *xdata)
^
snapview-client.c:560:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token
{
^
snapview-client.c:2412:26: error: ‘svc_stat’ undeclared here (not in a function)
.stat = svc_stat,
^
svc_* is the common prefix for (SUN)RPC functions provided by system
headers. svc_stat() seems to be an existing function name. This happens
because change-id I98fc8cf7e4b631082c7b203b5a0a77111bec1fb9 causes
<rpc/rpc.h> included through "glusterfs.h". Prepending gf_ for all svc_*
functions works around the symbol collision.
Change-Id: Idc86b719c48675a5154c54d844c1899d14d46e2a
BUG: 1328502
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14035
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 4e6b5f5ece07b78b7c3187d2a9cbe299a6fc3a55
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue Mar 15 06:16:31 2016 -0400
glusterd: default value of nfs.disable, change from false to true
Next step in eventual deprecation of glusterfs nfs server in favor
of ganesha.nfsd.
Also replace several open-coded strings with constant.
Change-Id: If52f5e880191a14fd38e69b70a32b0300dd93a50
BUG: 1092414
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13738
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 918627cc0932a03a8ec6d2d01c4b843a3567fcd6
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Dec 23 13:49:14 2015 +0530
afr: propagate child up event after timeout
Problem: During mount, afr waits for response from all its children before
notifying the parent xlator. In a 1x2 replica volume , if one of the nodes is
down, the mount will hang for more than a minute until child down is received
from the client xlator for that node.
Fix:
When parent up is received by afr, start a 10 second timer. In the timer call
back, if we receive a successful child up from atleast one brick, propagate the
event to the parent xlator.
Change-Id: I31e57c8802c1a03a4a5d581ee4ab82f3a9c8799d
BUG: 1054694
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11113
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 9cce8796bad5d82f28e5af18a5ef4916cf444d98
Author: Jonathan Holloway <jholloway@redhat.com>
Date: Mon Apr 11 20:32:26 2016 -0500
distaflibs: organize distaflibs to use namespace packages
Organized the distaflibs directory tree to accomodate namespace packages.
* Allows multiple distaf library packages to install in single namespace package.
- Created distaflibs-gluster directory as root for package configs, docs, etc.
- Created setup.py file to install distaflibs-gluster package into namespace.
- Created distaflibs-gluster/distaflibs namespace package dir and init.
- Created distaflibs-gluster/distaflibs/gluster as package dir.
- Copied distaf gluster library files into package dir.
Requires the distaf package.
distaflibs-gluster installs into /usr/lib/python2.7/site-packages/distaflibs/gluster
Change-Id: I775c4f1526880ea606f35c3616abb9aaf2f3b886
BUG: 1330346
Signed-off-by: Jonathan Holloway <jholloway@redhat.com>
Reviewed-on: http://review.gluster.org/13972
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: M S Vishwanath Bhat <vbhat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 1d612638e50d7ed3aa60c48497b4c38591b7dcd8
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue Apr 12 11:35:38 2016 -0400
packaging: additional dirs and files in /var/lib/glusterd/
Add the missing /var/lib/glusterd files and dirs found by
downstream testing. Use a loop to create hook dirs instead
of open-coding. Merge the %ghost and non-ghost dirs in
-server %files section for easier maintenance.
Eliminate a benign warning for enabling non-existent
glusterfsd.{init,service} which is only relevant to Fedora
builds
Don't reject glusterfs.spec.in changes because of long lines
Change-Id: I5802175d729e0168eea879a2a61626b0b73d77c8
BUG: 1326410
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13981
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit bd60bb90ce3b3c0150d39c238e99e55c735defd6
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Mar 15 12:47:24 2016 +0530
devel-tools: vagrant setup for creating devel VMs
Created vagrant setup for Gluster developers. The Vagrantfile
is modifed from the work done by Chris (cblum@redhat.com).
Ansible structure is taken from test vagrant infra initially
posted by rtalur.
This vagrant setup can create one or more VM (using libvirt),
create thinly provisioned LVs, format them with XFS and mount them.
It will also compile the source from host machine (/work/source) and
install gluster. It will also do peer probe.
Change-Id: Ie984f661bb5dc9cfc4059643389d3c80b2cae21d
BUG: 1327976
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/13734
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Raghavendra Talur <rtalur@redhat.com>
commit 61c3f6a23c00a06a2348cb31bcd90c7107377863
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 26 12:46:18 2016 +0530
glusterd: fix validation of lower op-version check in volume set
Commit 2d87a98 introduced a validation to fail lowering down the
cluster.op-version. Commit 2eb8758 actually changed the variable value from
cluster's op-version to volume's op-version which resulted the logic go for a
toss.
Change-Id: I70df32b75c3a3fe47dc840c4a655059e5b124bca
BUG: 1315186
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/14069
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 925eb07ecc28d34dfaa28da5a56c483bc69187dc
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Apr 13 12:50:49 2016 +0530
inode: Always fetch first entry from the inode lists during inode_table_destroy
In inode_table_destroy, we iterate through lru and active lists
to move the entries to purge list so that they can be destroyed
during inode_table_prune.
But if used "list_for_each_entry" or "list_for_each_entry_safe"
to iterate, we could end up accessing the entries which may have
got moved to different(purge) lists in the process and can result
in either infinite loop or crash. The safe approach seems to fetch
the first entry of the list in each iteration till it gets empty.
Change-Id: I24a18881833bd9419c2d8e5e8807bc71ec396479
BUG: 1326627
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13987
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 8090eeaf47c999b198e07edbc6301f4b451a6a73
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Apr 19 15:30:19 2016 +0530
geo-rep: Fix checkpoint issue in scheduler
If checkpoint is not met, Scheduler script should touch the
Mount point so that SETATTR will get recorded in every brick
Changelog. Script was not touching the mount point in each iteration.
BUG: 1328399
Change-Id: I2718a764fb3e550742c9dcd316724683561ddf18
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14029
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 4844a3858f457c8f4b9ba453c5d781224a0dd2bd
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Apr 25 17:16:42 2016 +0530
storage/posix: change the conflicting msg-id
Change-Id: I11b2ffb73b2358380771921548fa2c51da6ad93f
BUG: 1323040
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/14062
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 4dc9c6c04fc1a4c39693e312e8af95fbaecc9984
Author: Anuradha Talur <atalur@redhat.com>
Date: Thu Apr 21 17:20:09 2016 +0530
performance/decompounder: Introducing decompounder xlator
This xlator decompounds the compound fops received,
and executes them serially.
Change-Id: Ieddcec3c2983dd9ca7919ba9d7ecaa5192a5f489
BUG: 1303829
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/13577
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 618f805250b057a456b1b5ce03b7bdac09653f5a
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Mon Apr 25 14:05:30 2016 -0400
glusterd: SSL certificate depth volume option is incorrect
Between 3.7.1 and 3.7.2 a typo was introduced changing the string
ssl-cert-depth to ssl-cetificate-depth. [sic]
rpc/rpc-transport/socket/src/socket.c still expects the string
ssl-cert-depth.
Also replace a couple errant tabs with spaces.
Change-Id: I0621258470bd831c97008b56123a9dc7029d73f1
BUG: 1330248
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14066
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 0ac247bccbf71b392e3838ef57e259a43ca6a828
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Apr 4 14:55:20 2016 +0530
nsr/jbr: Renaming nsr to jbr
As per community consensus, we have decided to rename
nsr to jbr(Journal-Based-Replication). This is the patch
to rename the "nsr" code to "jbr"
Change-Id: Id2a9837f2ec4da89afc32438b91a1c302bb4104f
BUG: 1328043
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13899
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 4e0e608d4e326a4c177ecbd3699c36fc1ad5cb80
Author: Michael Scherer <misc@redhat.com>
Date: Mon Apr 25 18:23:48 2016 +0200
Use pthread_equal to compare threads
The man pages about pthreads are quite clear on the fact that pthread_t
is supposed to be opaque, and so can't be compared using the equality
operator.
Change-Id: Id69e166ed73a98668d19a71cd6d9ab9a0429ec38
BUG: 1330225
Signed-off-by: Michael Scherer <mscherer@redhat.com>
commit 55fd9aabd14ff94d415a4850e4a5396f4f96ba97
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Apr 22 12:07:31 2016 +0530
tier/dht: check for rebalance completion for EIO error
When an ongoing rebalance completion check task been
triggered by dht, there is a possibility of a race
between afr setting subvol as non-readable and dht updates
the cached subvol. In this window a write can fail with EIO.
Change-Id: I42638e6d4104c0dbe893d1bc73e1366188458c5d
BUG: 1329503
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/14049
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 26e7400958562c1394239190e7f5614d226005c3
Author: Susant Palai <spalai@redhat.com>
Date: Fri Apr 15 05:15:33 2016 -0400
dht/rebalance: Handle GF_DEFRAG_STOP
Problem: On a rebal stop, the migrator threads don't intimate the
crawler thread to wake up in case it is waiting on signal from
migrator thread.
Change-Id: I3cc4be41a4db25f48fee059ebb79a97ee99dcd00
BUG: 1327507
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/14004
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c4fe567d415e6e58de67ea386ef0c308dc277647
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Jul 20 14:29:24 2015 +0530
dht: Add lease() fop
Change-Id: I0bbc2c2ef115c78393f6570815a5b80316e7e4be
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/11720
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 72d8e1425bc755dffec06fcc6dd8e27f3b8eabbb
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Apr 20 15:02:16 2016 +0530
vagrant-test: added more options and centos6 base box
Options added are
1. destroy-now option
Now you can call run-tests-in-vagrant.sh with --destroy-now option to
destroy the VM corresponding to the git branch and delete the
corresponding vagrant dir.
Usage: run-tests-in-vagrant.sh --destroy-now
2. os option
With --os option you can specify the os to be used for VM.
Default is fedora and this patch adds support for centos6.
Usage: run-tests-in-vagrant.sh --os="centos6"
3. destroy-after-test option
When specified the VM is deleted right after the tests are executed. If
the script exited before running tests then the VM is left as is for
further debugging.
4. verbose option
Many log messages which were mainly added for initial debugging have
been removed now. All vagrant and compilation outputs have been redirected to
/dev/null. To enable these logs please use --verbose option.
5. ssh option
--ssh option now allows one to ssh into the VM from topdir of source
code thereby avoiding the hassle of cd'ing into the vagrant dir.
Box added
1. This patch adds a centos6 base box which is currently made available
at atlas.hashicorp.com. Template files for this box are available
under tests/vagrant/vagrant-template-centos6 directory. The default box is
moved under vagrant-template-fedora directory to keep up with the naming
convention.
Enhancements
This patch also modifies the cpu and memory allocation mechanism for
the VMs. All the cpus on the host are used and 1/4 of the memory
available on host is used.
Bug Fixes
1. Fix CFLAGS not passed to configure error
If CFLAGS is assigned and then configure is called under sudo, the cflags
are not passed onto configure.
Change-Id: Iee1811a7d2b77785f6167f4706135a8f584a6bbd
BUG: 1291537
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/14046
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d4649bb2b9c42a4ad0f2763bc8661cefbbcdb9e8
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Thu Apr 21 14:38:16 2016 +0530
runner: extract and return actual exit status of child
Intro:
pid_t waitpid(pid_t pid, int *status, int options);
The waitpid() system call suspends execution of the calling process
until a child specified by pid argument has changed state.
Here the ret (pid) value is not equal to the exit status of the child process.
Check manpages for more info on this.
Problem:
In the current runner framework we always return the pid i.e ret value
of the waitpid, as said above it is not the exit value of the child process
Solution:
Extract the actual exit code/status in case if the child terminated normally,
that is, by calling exit(3) or _exit(2), or by returning from main()
Change-Id: Iffae99a43e540af66917b3745f21ea3c2a5a3c2d
BUG: 1329129
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/14042
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d1d1848d2c6881e7fd13336859f4592c99eff84b
Author: vmallika <vmallika@redhat.com>
Date: Thu Apr 14 17:51:19 2016 +0530
cli/quota: Sort the list output alphabetically by path
Change-Id: I0b124e119d167817be2ae3eb52ac6c80fc7db5d1
BUG: 1320716
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/14000
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 4f205d1e85fbbc8580383a4b03b5b43a1a82ac61
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Apr 18 14:44:18 2016 +0530
clone/snapshot: Save restored_from_snap for clones
Bricks of cloned volumes are lvm bricks mounted in
/run/gluster, which on reboot of the node gets
cleared. Hence, these brick paths need to be recreated
on glusterd restart and the appropriate lvms are
mounted.
Change-Id: I6da086288c0dbdcedf3a20fd53f25e3728bea473
BUG: 1328010
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/14021
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 489a8ee823e1267ffacda357bb0313e6d6aeeeab
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 18 19:24:41 2016 +0200
build: reduce warnings when building the syscall compatibility layer
For whatever reason my Fedora 23 started to complain loudly when
compiling syscall.c.
Change-Id: I72d278d6dc9abb77018c2590c113552383b639d1
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14034
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit f6312b673321b140ea39e97ffa849ddbf99f9597
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Apr 19 17:52:26 2016 +0200
build: remove unused gf_darwin_compat_*xattr() functions
These functions are not implemented or used anywhere, there is no reason
to have them declared in the compatibility header.
Change-Id: If33ed2cc0be86b9f04f05f3af822758e263f6d53
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14033
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit cd09b9b4efafe49b011d505b42a91fc9b4574631
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Apr 23 05:30:08 2016 +0530
cluster/afr: Fix inode-leak in data self-heal
Thanks to Olia-Kremmyda for finding the bug on github review,
https://github.com/gluster/glusterfs/commit/b8106d1127f034ffa88b5dd322c23a10e023b9b6
Change-Id: Ib8640ed0c331a635971d5d12052f0959c24f76a2
BUG: 1329773
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14052
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 83b09addffe845ff5b57640a9a181f16d5092457
Author: jiffin tony Thottan <jthottan@redhat.com>
Date: Thu Mar 10 04:03:19 2016 -0800
Revert "NFS-Ganesha : scripts related changes for supporting multiple export entires for volume"
This reverts change-id I2286af4877f96f4334435818f67beea87efa2b1f.
While testing, I had found that ganesha-ha.sh is not working as expected. It is
almost equivalent to rewrite entire thing again
Change-Id: Ia85e50fe8e043e8a2bc6441b7c45dcc726b36672
BUG: 1275966
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/13673
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit 3c6281061aded8871a7473dcc8fbc3131ba4d2aa
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Apr 24 06:31:14 2016 +0530
statedump: Prevent (null) typestr to be printed
Problem:
After the commits: 7e44c783ad731856956929f6614bbe045c26ea3a - lock: use
spinlock only on multicore systems
a6aecae2cd8171b8538bfe5d2800bdd157380b85 - nfs: fix lock variable type
we see a lot of "[global.glusterfs - usage-type (null) memusage]" in statedump
because lock status is not all-zeros after init, and the memcmp to check that
a datatype is never allocated is invalid.
Fix:
Changed if a datatype is allocated or not check based on total_allocs. Also
removed setting typestr to NULL on gf_free even when num_allocs is 0. Because
even that is leading to 'null' memusage string to be printed in statedump.
BUG: 1329870
Change-Id: If2b01a557cbdc787625db32e276e06cee3ac46ee
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14054
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fa7a9e0cc2401a369d45784f6ebf02d2766f3ffd
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Mon Apr 11 15:28:07 2016 +0530
qemu-block: mop leftover code
This patch cleans off the code that was leftover by '6860968'
which basically remove qemu-block from gluster code repo
Also update 'bug-1168803-snapd-option-validation-fix.t'
which previously used 'features.file-snapshot' for checking
'volume set' for some reason.
Change-Id: I2c4f28e186b74a4ce55d48c0fa7f3f79ca1901b5
BUG: 1198849
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13964
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit ac93f5ec7b4a89a0f6bc0e67d939c1a782c289b7
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Apr 1 15:16:23 2016 +0530
cluster/distribute: detect stale layouts in entry fops
dht_mkdir ()
{
first-hashed-subvol = hashed-subvol for "bname" in in-memory
layout of "parent";
inodelk (SETLKW, parent, "LAYOUT_HEAL_DOMAIN", "can be any
subvol, but we choose first-hashed-subvol randomly");
{
begin:
hashed-subvol = hashed-subvol for "bname" in in-memory
layout of "parent";
hash-range = extract hashe-range from layout of "parent";
ret = mkdir (parent/bname, hashed-subvol, hash-range);
if (ret == "hash-value doesn't fall into layout stored on
the brick (this error is returned by posix-mkdir)")
{
refresh_parent_layout ();
goto begin;
}
}
inodelk (UNLCK, parent, "LAYOUT_HEAL_DOMAIN",
"first-hashed-subvol");
proceed with other parts of dht_mkdir;
}
posix_mkdir (parent/bname, client-hash-range)
{
disk-hash-range = getxattr (parent, "dht-layout-key");
if (disk-hash-range != client-hash-range) {
fail-with-error ("hash-value doesn't fall into layout
stored on the brick");
return 0;
}
continue-with-posix-mkdir;
}
Similar changes need to be done for dentry operations like create,
symlink, link, unlink, rmdir, rename. These will be addressed in
subsequent patches. This patch addresses only mkdir codepath.
This change breaks stripe tests, as on some striped subvols dht layout
xattrs are not set for some reason. This results in failure of
mkdir. Since striped volumes are always created with dht, some tests
associated with stripe also fail. So, I am making following tests
changes (since stripe is out of maintainance):
* modify ./tests/basic/rpc-coverage.t to not to use striped volumes
* mark all (2) tests in tests/bugs/stripe/ as bad tests
Change-Id: Idd1ae879f24a48303dc743c1bb4d91f89a629e25
BUG: 1323040
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/13885
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit 604239908a908ff20f3a184c725545d88d6892ed
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Mar 11 15:27:30 2016 +0530
snapshot/quota: Copy quota.cksum during snapshot operations
A volume having a quota.conf file, should always have
a quota.cksum file too. Based on this above assumption
modifying glusterd_copy_quota_files() to always copy
quota.cksum, if quota.conf is present.
This change will be reflected when a snapshot is created,
restored and cloned.
Change-Id: Ia49dc26eacef32eeb8f7d7d9553c80e304b08779
BUG: 1316848
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13760
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 09494e825388800ee26ab0a1679ee76b575e4346
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Feb 23 19:22:45 2016 -0500
features/crypt: Whitespace Cleanup
Change-Id: Ib7f2ceb3851a3c333e3d58e3e2713fe4d59616b1
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/13502
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 515bb43d48a67c1b98ca32004f3311474c506b96
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Mar 21 12:01:47 2016 +0530
features/marker: Fix dict_get errors when key is NULL
Change-Id: I25e497459441334c13af77b3fec83c42a7a92ac4
BUG: 1319581
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/13793
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 70f4c308449dd00c820b1e571e13f2958d54ce37
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Jul 9 15:31:30 2015 +0530
posix: Add lease() fop
Change-Id: I20007d7ff4536ae8180425c84a1aa7863a6f2447
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/11598
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit e213dd6aab965f4584a5bfdcab6984c30a715567
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Jul 9 15:28:59 2015 +0530
io-threads: Add lease() fop
Change-Id: Ie4921867948d23b8b6c570196e88680cdb5ebfbc
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/11599
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 9de07c82fbe42e9973c1e1de548b324a7efd4395
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Jul 9 15:06:49 2015 +0530
core: add lease fop
Change-Id: Ia27d66b1061b0377857827515590eb89b18515c9
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/11596
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit f8896173a98e11e50d566ab4a22afe19a3f7a460
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Apr 18 15:27:01 2016 +0530
quota : fix null dereference issues in quota
Change-Id: I3805b206077718da26adbeb8b29a53642e00886f
BUG: 1328696
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/14022
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 9f3d23e72ed1a9b68ea3dd5329274afbbb30b604
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 31 14:40:09 2016 +0530
cluster/afr: Fix spurious entries in heal info
Problem:
Locking schemes in afr-v1 were locking the directory/file completely during
self-heal. Newer schemes of locking don't require Full directory, file locking.
But afr-v2 still has compatibility code to work-well with older clients, where
in entry-self-heal it takes a lock on a special 256 character name which can't
be created on the fs. Similarly for data self-heal there used to be a lock on
(LLONG_MAX-2, 1). Old locking scheme requires heal info to take sh-domain locks
before examining heal-state. If it doesn't take sh-domain locks, then there is
a possibility of heal-info hanging till self-heal completes because of
compatibility locks. But the problem with heal-info taking sh-domain locks is
that if two heal-info or shd, heal-info try to inspect heal state in parallel
using trylocks on sh-domain, there is a possibility that both of them assuming
a heal is in progress. This was leading to spurious entries being shown in
heal-info.
Fix:
As long as there is afr-v1 way of locking, we can't fix this problem with
simple solutions. If we know that the cluster is running newer versions of
locking schemes, in those cases we can give accurate information in heal-info.
So introduce a new option called 'locking-scheme' which if it is 'granular'
will give correct information in heal-info. Not only that, Extra network hops
for taking compatibility locks, sh-domain locks in heal info will not be
necessary anymore. Thus it improves performance.
BUG: 1322850
Change-Id: Ia563c5f096b5922009ff0ec1c42d969d55d827a3
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13873
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 1f7f9ee9af236cb696077271811ae1187458abe3
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Apr 15 16:37:18 2016 +0530
geo-rep: Fix hostname mismatch between volinfo and geo-rep status
When Volume was created using IP, Gluster Volume info shows IP address
But Geo-rep shows hostname if available, So difficult to map the outputs
of Volume Info and Georep status output.
Schedule Geo-rep script(c#13279) will merge the output of Volume info and
Geo-rep status to get offline brick nodes information. This script was
failing since host info shown in Volinfo is different from Georep status.
Script was showing all nodes as offline.
With this patch Geo-rep gets host info from volinfo->bricks instead of
getting from hostname. Geo-rep status will now show same hostname/IP which
was used in Volume Create.
BUG: 1327553
Change-Id: Ib8e56da29129aa19225504a891f9b870f269ab75
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14005
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 217489ae8b8aa90a5a4ed42eac3098735de2f885
Author: hari <hgowtham@redhat.com>
Date: Wed Apr 6 16:16:47 2016 +0530
Tier: tier command fails message when any node is down
PROBLEM: the dict doesn't get set on the node if its down.
so while printing the output on cli we get a ENOENT
which ends in a tier command failed.
FIX: this patch skips the node that wasn't available
and carrys on with the next node for both tier status
and tier detach status.
Change-Id: I718a034b18b109748ec67f3ace56540c50650d23
BUG: 1324439
Signed-off-by: hari <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/13918
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 5de85cd9d1d91ddd8e526654eca0043a593f571e
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Wed Apr 13 16:40:40 2016 +0530
quota: setting 'read-only' option in xdata to instruct DHT to not heal
When quota is enabled the quota enforcer tries to get the size of the
source directory by sending nameless lookup to quotad. But if the rename
is successful even on one subvol or the source layout has anomalies then
this nameless lookup in quotad tries to heal the directory which requires
a lock on as many subvols as it can. But src is already locked as part of
rename. For rename to proceed in brick it needs to complete a cluster-wide
lookup. But cluster-wide lookup in quotad is blocked on locks held by rename,
hence a deadlock. To avoid this quota sends an option in xdata which instructs
DHT not to heal.
Change-Id: I792f9322331def0b1f4e16e88deef55d0c9f17f0
BUG: 1252244
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/13988
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit d3b991f847108438c02026b9e847f65e91f4c857
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Mar 23 13:47:27 2016 +0530
mount/fuse: report ESTALE as ENOENT
When the inode/gfid is missing, brick report back as an ESTALE
error. However, most of the applications don't accept ESTALE as an
error for a file-system object missing, changing their behaviour.
For eg., rm -rf ignores ENOENT errors during unlink of
files/directories. But with ESTALE error it doesn't send rmdir on a
directory if unlink had failed with ESTALE for any of the files or
directories within it.
Thanks to Ravishankar N <ravishankar@redhat.com>, here is a link as to
why we split up ENOENT into ESTALE and ENOENT.
http://review.gluster.org/#/c/6318/
Change-Id: I467df0fdf22734a8ef20c79ac52606410fad04d1
BUG: 1245065
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/13816
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit cf6d1e54b38bf0141649035ff75550c239d181db
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Mar 31 09:38:55 2016 +0200
Build fix: remove undefined -I${rpclibdir}
The variable is not defined anywhere, remove it.
Change-Id: Iaefb349cceb4108ac22c44cd32e5ea3d3c8bc0e5
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
BUG: 1129939
Reviewed-on: http://review.gluster.org/13867
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e565d27e93828f638c1cfc17b5c3eacd9c400df8
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Apr 12 11:27:08 2016 +0200
tests: fix syntax error in 0symbol-check.t
While running the tests, 0symbol-check.t gives the following syntax
error:
tests/basic/0symbol-check.t: line 25: [: missing `]'
BUG: 1267967
Change-Id: Iba454387ebdfa75872036ebe168115500c85d0b1
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13976
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit f1628c49a80b26fb91914f6b5ee33f5704e1635c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 17 19:42:00 2016 +0530
cluster/afr: Fix partial heals in 3-way replication
Problem:
When there are 2 sources and one sink and if two self-heal daemons
try to acquire locks at the same time, there is a chance that it
gets a lock on one source and sink leading partial to heal. This will
need one more heal from the remaining source to sink for the complete
self-heal. This is not optimal.
Fix:
Upgrade non-blocking locks to blocking lock on all the subvolumes, if
the number of locks acquired is majority and there were eagains.
BUG: 1318751
Change-Id: Iae10b8d3402756c4164b98cc49876056ff7a61e5
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13766
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit fb3ebccf0424f64634f43e8434ea9e11f26ab6c2
Author: Sakshi <sabansal@redhat.com>
Date: Wed Apr 15 13:28:24 2015 +0530
libglusterfs: coverity fix
fix missing varargs cleanup
CID 1124856: string overflow
CID 1124656: NULL return
CID 1124374: constant expression
Change-Id: Iead530c599bdfef05a40c68b892215f4e4f02247
BUG: 789278
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/9630
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d15d8e30b413290a917847bbcea1b50739649f61
Author: Zhou Zhengping <johnzzpcrystal@gmail.com>
Date: Sun Apr 10 23:56:17 2016 +0800
rpc: check the right variable after gf_strdup
Change-Id: If4628bd37f2c85a070f6c3b3e0583d939100d7ec
BUG: 1325683
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
Reviewed-on: http://review.gluster.org/13934
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 7227d904f241d3f02e0b727d3b9e99fa98096f6b
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Wed Apr 13 14:38:11 2016 +0530
Revert "glusterd: Allocate fresh port on brick (re)start"
This reverts commit 34899d7
Commit 34899d7 introduced a change, where restarting a volume or rebooting
a node result into fresh allocation of brick port. In production
environment generally administrator makes firewall configuration for a
range of ports for a volume. With commit 34899d7, on rebooting of node
or restarting a volume might result into volume start fail because
firewall might block fresh allocated port of a brick and also it will be
difficult in testing because of fresh allocation of port.
Change-Id: I7a90f69e8c267a013dc906b5228ca76e819d84ad
BUG: 1322805
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/13989
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 53dc945b595dedcd2703ff45ff498cfa427d97dc
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 13 21:10:22 2016 +0530
mgmt/glusterd: Change op-version for max-threads, shd-wait-qlength
Change-Id: I0e2dcacfe0804737d2cff76d2a0ee51a520ccec2
BUG: 1221737
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13992
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 561e86ee40c3e173c6547b06da9f9df04826462b
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Apr 11 01:51:38 2016 -0400
extras: Fix the create_new_xlator tool
It is currently importing a non existing module.
Remove the same.
Change-Id: I7f4b790ba42d8683575768ec14851932a8cddc43
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/13960
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 58dd3dea0d97ee0d8bc67902ba4c0a6880cfc2cb
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Apr 7 01:08:26 2016 -0400
extras: Enable failed-tests.py to fetch regression summary for more than 30 builds
Credits: Raghavendra Talur
Change-Id: I4a895f57e9ab0e5d28e78c467e5b52d347586706
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/13922
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b1f2efd9835510adaa945f9a15328729435c7d6a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 12 09:43:13 2016 +0530
tests: fix regression failure from bug-1322772-real-path-fix-for-snapshot.t
There is no need to unmount the brick as doing so we loose all the xattrs on the
brick and while restarting glusterd brick doesn't come up
Change-Id: Ic1fa8b72f6cfcad564c62bcef1d022b083263ecc
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13974
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit dcc4c81406c20400ee1b2ba0cf671d08a55561e0
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Mon Feb 9 14:28:21 2015 +0530
glusterfsd: coverity fix
CID 1124846: string overflow
CID 1124363: checked return value
CID 1210982: unsigned compare
Change-Id: I5995d98c07750615657668535fcc23ac30b3523b
BUG: 789278
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/9608
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit dadb53783750a1325adc53d38f977b62154f2ecc
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Thu Mar 17 13:50:31 2016 +0530
glusterd-client: switch volfile server incase existing connection breaks
Problem:
Currently, say we have 10 Node gluster volume, and mounted it using
Node 1 (N1) as volfile server and the rest as backup volfile servers
$ mount -t glusterfs -obackup-volfile-servers=<N2>:<N3>:...:<N10> <N1>:/vol /mnt
if N1 goes down we still be able to access the same mount point,
but the problem is that if we add or remove bricks to the volume
whoes volfile server is down in our case N1, that info will not be
passed to client, because connection between glusterfs and glusterd (of N1)
will be disconnected due to which we cannot store files to the newly
added bricks until N1 comes back
Solution:
If N1 goes down iterate through the nodes specified in
backup-volfile-servers list and try to establish the connection between
glusterfs and glsuterd, hence we don't really have to wait
until N1 comes back to store files in newly added bricks that are
successfully added when N1 was down
Change-Id: I653c9f081a84667630608091bc243ffc3859d5cd
BUG: 1289916
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13002
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c7da2e081381aac11e73e802000a65ad94241511
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Mar 31 06:29:29 2016 -0400
io-stats: Fix overwriting of client profile by the bricks
Issue: When the user executes the following command to generate
the client perf profile, if the client is on the same node as
bricks, the bricks overwrite the profile info written by clients.
Also xattr "trusted.io-stats-dump" gets set on the mount point.
setxattr -n trusted.io-stats-dump -v /tmp/iostat.log /mnt/fuse
Fix: Unwind from setxattr, when xattr is 'io-stats-dump'
Change-Id: Iba0e5df2f25f4ba3b1399ac176a3f8a916ff372e
BUG: 1322825
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/13872
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 3f549fe0a57d0d861084cb222251220c05c1bb99
Author: Sakshi <sabansal@redhat.com>
Date: Wed Apr 15 15:30:51 2015 +0530
glusterd: coverity fix for insecure temporary file
Set umask before creating temporary file
Change-Id: Ia39af63b05ce68f3f3af6585b70d4129a5530269
BUG: 789278
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/9558
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b20a7a1f0b47b08a55953e50006643b853962d99
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Sun Apr 10 10:51:11 2016 -0400
tests: use trap mechanism to ensure that proper cleanups happen
This actually consists of several parts.
* Added a generic cleanup-scheduling mechanism. Instead of calling
"trap ... EXIT" directly, just call "push_trapfunc ..." instead and
your cleanup function will be called along with any others.
* Converted a few tests to use push_trapfunc.
* Added "push_trapfunc cleanup_lvm" to snapshot.rc to address the
particular problem that's driving this - snapshot tests not calling
cleanup_lvm on their own and leaving bad state for the next test.
Change-Id: I548a97a26328390992fc71ee1f03c0463703f9d7
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13933
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 8ae0239adced7816a51f0ab961d117f7b06d9f71
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Sun Apr 10 15:31:50 2016 -0400
dht: extend time for "nuke" test's janitor-cleanup check
The previous check worked out to 50 deletes per second. That might have
seemed generous, but NetBSD regression tests were failing because it
can't hit that figure reliably.
Change-Id: Ifbd8f4547caf53a8a8d11ad586aa8051f77ddc40
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13935
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit ac10c955ba72586b2d72057d8dc73b1e4b3c5850
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 21 23:26:43 2016 +0530
cluster/afr: Fix witness counting code in src/sink detection
Problem:
In afr-v1 pre-op, xattrop increments self xattr first then it increments the
value on rest. In post-op, xattr value is decreased first on rest and at last
it gets decremented on self. So for a possible operation to be witnessed i.e.
a fop is seen by the brick it is important to have at least 1 pending op
because without completing pre-op fop won't come. The other possibility is when
fop completes but at the time of post-op after decrementing pending counts on
others just before decrementing its own pending count, the brick dies.
Fix:
Fix witness detection code in afr_self_heal_find_direction()
BUG: 1322253
Change-Id: Ia7e76482c0a46e775e269bb96ec1b9490a3ac18f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13811
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit f7a1925a77ae48a620074362458c425e860c5291
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Mar 29 18:36:08 2016 +0530
features/shard: Make o-direct writes work with sharding
With files opened with o-direct, the expectation is that
the IO performed on the fds is byte aligned wrt the sector size
of the underlying device. With files getting sharded, a single
write from the application could be broken into more than one write
falling on different shards which _might_ cause the original byte alignment
property to be lost. To get around this, shard translator will send fsync
on odirect writes to emulate o-direct-like behavior in the backend.
Change-Id: Ie8a6c004df215df78deff5cf4bcc698b4e17a7ae
BUG: 1322214
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13846
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit ab9d7b6eccb27a2a03e4941f18a8d2f74bacd468
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Apr 11 16:07:40 2016 +0530
glusterd: populate brickinfo->real_path conditionally
glusterd_brickinfo_new_from_brick () is called from multiple places and one of
them is glusterd_brick_rpc_notify where its very well possible that an
underlying brick's file system has crashed and a disconnect event has been
received. In this case glusterd tries to build the brickinfo from the brickid in
the RPC request, however the same fails as glusterd_brickinfo_new_from_brick ()
fails from realpath.
Fix is to skip populating real_path if its a disconnect event.
Change-Id: I9d9149c64a9cf2247abb731f219c1b1eef037960
BUG: 1325841
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13965
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 80dade29460317f3b0017e4ac53bed0e0eab7bcc
Author: vmallika <vmallika@redhat.com>
Date: Mon Apr 11 15:44:16 2016 +0530
posix_acl: create inode ctx for posix_acl_get
Change-Id: Ibe5b00cd4b5d896133adc61f65094d783c492ed4
BUG: 1325822
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13961
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a34cde05904b013d0c7b75d19419114aa344db80
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Apr 5 15:16:52 2016 +0530
arbiter: write performance improvement
Problem: The throughput for a 'dd' workload was much less for arbiter
configuration when compared to normal replica-3 volume. There were 2
issues:
i)arbiter_writev was using the request dict as response dict while
unwinding, leading to incorect GLUSTERFS_WRITE_IS_APPEND and
GLUSTERFS_OPEN_FD_COUNT values (=4), leading to immediate post-ops
because is_afr_delayed_changelog_post_op_needed() failed due to
afr_are_multiple_fds_opened() check.
ii) The arbiter code in afr was setting local->transaction.{start and len} =0
to take full file locks. What this meant was even for simultaenous but
non-overlapping writevs, afr_transaction_eager_lock_init() was not
happening because afr_locals_overlap() always stays true. Consequently
is_afr_delayed_changelog_post_op_needed() failed due to
local->delayed_post_op not being set.
Fix:
i) Send appropriate response dict values in arbiter_writev.
ii) Modify flock params instead of local->transaction.{start and len} to
take full file locks in the transaction.
Also changed _fill_writev_xdata() in posix to fill rsp_xdata for
whatever key is requested for.
Change-Id: I1c5fc5e98aba49ade540bb441a022e65b753432a
BUG: 1324004
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reported-by: Robert Rauch <robert.rauch@gns-systems.de>
Reported-by: Russel Purinton <russell.purinton@gmail.com>
Reviewed-on: http://review.gluster.org/13906
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 891d999068ad2a7f2e68c6f837a2229087ddea9e
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Apr 8 21:59:53 2016 -0400
extras: Add namespace for options in group-virt.example
Commit 23ccabbeb7 introduced a new key "disperse.eager-lock" which
causes a conflict with key "cluster.eager-lock" when option is used
without the qualifying namespace. group-virt.example which gets
installed as /var/lib/glusterd/ groups/virt contains options without
namespace qualifiers. This patch adds the appropriate namespace to all
options in group-virt.example.
Change-Id: I2c09dd10d44138410d889ddeb805f01c641c6780
BUG: 1314649
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/13929
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 8d58b4d7f97ee7c32b4cc18f62a80f30dc822a0d
Author: Anuradha Talur <atalur@redhat.com>
Date: Fri Feb 5 10:45:37 2016 +0530
libglusterfs: Refactor packing of arguments
Added these changes so that they can be re-used to pack
arguments required for each fop while populating the
compound fop structure used by each xlator.
Change-Id: Id9923e10003adafbc16a8bf3fbefa30677847313
BUG: 1303829
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/13360
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 5d732e36f67094d41e8bc011c1ef3e870dc36637
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Apr 7 21:14:49 2016 +0530
socket: Don't cleanup encrypted transport in socket_connect()
..instead cleanup only in socket_poller()
With commit d117466 socket_poller() wasn't launched from socket_connect
(for encrypted connections), if connect() failed. This was done to
prevent the socket private data from being double unreffed, from the
cleanups in both socket_poller() and socket_connect(). This allowed
future reconnects to happen successfully.
If a socket reconnects is sort of decided by the rpc notify function
registered. The above change worked with glusterd, as the glusterd rpc
notify function (glusterd_peer_rpc_notify()) continuously allowed
reconnects on failure.
mgmt_rpc_notify(), the rpc notify function in glusterfsd, behaves
differently.
For a DISCONNECT event, if more volfile servers are available or if more
addresses are available in the dns cache, it allows reconnects. If not
it terminates the program.
For a CONNECT event, it attempts to do a volfile fetch rpc request. If
sending this rpc fails, it immediately terminates the program.
One side effect of commit d117466, was that the encrypted socket was
registered with epoll, unintentionally, on a connect failure. A weird
thing happens because of this. The epoll notifier notifies
mgmt_rpc_notify() of a CONNECT event, instead of a DISCONNECT as
expected. This causes mgmt_rpc_notify() to attempt an unsuccessful
volfile fetch rpc request, and terminate.
(I still don't know why the epoll raises the CONNECT event)
Commit 46bd29e fixed some issues with IPv6 in GlusterFS. This caused
address resolution in GlusterFS to also request of IPv6 addresses
(AF_UNSPEC) instead of just IPv4. On most systems, this causes the IPv6
addresses to be returned first.
GlusterD listens on 0.0.0.0:24007 by default. While this attaches to all
interfaces, it only listens on IPv4 addresses. GlusterFS daemons and
bricks are given 'localhost' as the volfile server. This resolves to
'::1' as the first address.
When using management encryption, the above reasons cause the daemon
processes to fail to fetch volfiles and terminate.
Solution
--------
The solution to this is simple. Instead of cleaning up the encrypted
socket in socket_connect(), launch socket_poller() and let it cleanup
the socket instead. This prevents the unintentional registration with
epoll, and socket_poller() sends the correct events to the rpc notify
functions, which allows proper reconnects to happen.
Change-Id: Idb0c0a828743cccca51cfdd1aa6458cfa0a9d100
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/13926
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 132cb70a73c0f2275a28a446de39fc50908afb56
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Mar 31 21:15:14 2016 +0530
tests: Fix typo in split-brain-healing.t
Change-Id: Ie4554a13fd60d2b14518cc54e8c464f898970030
BUG: 1321322
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13875
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit ae585732a42076e35969c1cb82fc04a550202328
Author: M S Vishwanath Bhat <msvbhat@gmail.com>
Date: Wed Mar 30 17:05:05 2016 +0530
Adding distaf tests directory structure to tests dir
Since it was decided to have distaf test cases and related
libraries inside of glusterfs.git, this patch has the basic
skeleton directory structure and few of the libs.
Please note that, this patch by itself will not enable to
run any distaf tests right away. The distaf package needs to
be installed from the github.com/gluster/distaf. Once that
package is installed, it will put all the libs into respective
standard location and only then the tests in this patch can be
executed.
The plan to have distaf_libs packaged or installable using setup.py
This will enable tests to assume that all the libs are present in
the standard location.
Change-Id: I925ac0ad7e9cf6164c4380319a1f786b5241c74a
Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
Reviewed-on: http://review.gluster.org/13853
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Raghavendra Talur <rtalur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 4bf237d2846962507714f2d79595c0705ecc8163
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 31 17:15:37 2016 -0400
dht: add "nuke" functionality for efficient server-side deletion
This turns a special xattr into an rmdir with flags set. When that hits
the posix translator on the server side, that causes the file/directory
to be moved into the special "landfill" directory. From there, the
posix janitor thread will take care of deleting it entirely on the
server side - traversing it recursively if necessary. A couple of
secondary issues were fixed to make this effective.
* FUSE now ensures that setxattr values are NUL terminated.
* The janitor thread now gets woken up immediately when something is
placed in 'landfill' instead of only when file descriptors need to be
closed.
* The default landfill-emptying interval was reduced to 10s.
To use the feature, issue a setxattr something like this:
setfattr -n glusterfs.dht.nuke -v "" /mnt/glusterfs/vol/some_dir
The value doesn't actually matter; the mere receipt of a request with
this key is sufficient. Some day it might be useful to allow setting a
required value as a sort of password, so that only those who know it can
access the underlying special functionality.
Change-Id: I8a343c2cdb40a76d5a06c707191fb67babb8514f
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13878
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2c8813ce94d1ede49075a7b489fd8db6dd53a50d
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Apr 6 15:47:46 2016 -0400
tests: fix per-test core detection
Commit 9933c5ab in glusterfs-patch-acceptance-tests broke the code here
to count cores after each test, with two bad effects:
* Tests continue to run after the job is already guaranteed to fail,
tying up resources and delaying jobs for other patches.
* Cores aren't detected until the end of the job, long after it might
have been possible to figure out what was going on at the time the
process died.
The current check here works for the current code in the other repo, but
could break if the two repos are changed without coordination again.
Change-Id: Ica9222c3474fddf8e3b40074da2bdfd4dabb79d7
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13921
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit be223586dd9bead6df9122d7af1decf8cafbe303
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Thu Mar 31 15:02:03 2016 +0530
NFS: new option nfs.rdirplus added
When this option is 'disabled', NFS falls back to standard readdir instead
of readdirp
Change-Id: Icaaf4da6533bee56160d4a81e42bb60f7d341945
BUG: 1302948
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/13782
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 5ae243acd14d4969f0740c1dd9aa94aa6e4e33b9
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Apr 4 17:29:38 2016 -0400
cli: fix double free of options dictionary
In cli_cmd_volume_getopt_cbk and cli_cmd_volume_barrier_cbk, we were
freeing our options directory, which was incorrect because we had
already put it in our local structure (via CLI_LOCAL_INIT) and it was
being freed from there (via CLI_STACK_DESTROY and cli_local_wipe). This
was causing mount.t to hang consistently in a vagrant environment, with
the CLI stuck trying to take a lock on a dictionary that had already
been freed. While this made it possible to debug, the same problem
might be behind some other intermittent regression test failures as
well.
Change-Id: I70aa7c69f63243f5423d68e2cfaefca81b937aad
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13903
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 7142a188b549f48bfcb807556984dd717451efb4
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Mon Apr 4 16:15:18 2016 +0530
rpc: assign port only if it is unreserved
Current order:
assign port;
check for port;
if reserved {
port--;
continue to i;
}
bind();
basically, we are assigning port first then checking if it is reserved
Fix:
get unreserved port;
assign port;
bind();
from now, we get unreserved port first and then assign it
Change-Id: I004580c5215e7c9cae3594af6405b20fcd9fa4ad
BUG: 1323659
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13900
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 3bbe42ae9bedf61890a33c6d5c506d5ba7159286
Author: Sakshi <sabansal@redhat.com>
Date: Wed Aug 5 16:05:22 2015 +0530
dht: lock on subvols to prevent rename and lookup selfheal race
This patch addresses two races while renaming directories:
1) While renaming src to dst, if a lookup selfheal is triggered
it can recreate src on those subvols where rename was successful.
This leads to multiple directories (src and dst) having same gfid.
To avoid this we must take locks on all subvols with src.
2) While renaming if the dst exists and a lookup selfheal is
triggered it will find anomalies in the dst layout and try to
heal the stale layout. To avoid this we must take lock on any
one subvol with dst.
Change-Id: I637f637d3241d9065cd5be59a671c7e7ca3eed53
BUG: 1252244
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/11880
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 9aeb6164aa1922347631712238efff9a4f34833b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Apr 4 17:23:53 2016 -0400
tests: improve vagrant usability
The first and most important change is to deal with the fact that
"localhost" is an IPv6 address in the vagrant box we're using. This was
non-obviously behind some of the NFS tests failing to run properly, so
there's now an Ansible role etc. to make the necessary modifications in
/etc/hosts. Also added "-j" to the make command, and changed the
invocation of "run-tests.sh" so it passes through any arguments instead
of running all tests every time.
BUG: 1291537
Change-Id: I5e6125de043c41fdb2866875e999cb1fcd72ba52
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13904
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit aaf57b38592cfc33d87101136b5921683566434e
Author: vmallika <vmallika@redhat.com>
Date: Sat Apr 2 08:57:00 2016 +0530
marker: optimize mq_update_dirty_inode_task
In function mq_update_dirty_inode_task we do readdirp
on a dirty directory and for entry we again do
lookup to fecth the contribution xattr.
We can fetch this contribution as part of readdirp
Change-Id: I766593c0dba793f1ab3b43625acce1c7d9af8d7f
BUG: 1320818
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13892
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
commit fc7df2d95279fe8b41878840ecdb489fc889aa9a
Author: vmallika <vmallika@redhat.com>
Date: Wed Apr 6 14:09:50 2016 +0530
marker: do mq_reduce_parent_size_txn in FG for unlink & rmdir
* If a "rm -rf" is performed by a client, we initiate a
marker background operation mq_reduce_parent_size_txn
for rmdir and unlink.
mq_reduce_parent_size_txn can fail when updating
size on the ancestor directories, if these directories
are removed during the txn as the child-parent association
removed in the dentry list.
So execute mq_reduce_parent_size_txn in foreground
and then do the UNWIND for rmdir and unlink FOP
Change-Id: Iefcdced4c6ae0dbd43f92814d0ddcd1e33825864
BUG: 1322489
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13874
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit e53e537ce68d3fc66dd699c3ee8fddf2ac0fc519
Author: vmallika <vmallika@redhat.com>
Date: Sat Apr 2 12:02:22 2016 +0530
posix_acl: skip acl_permits for special clients
Change-Id: I3f478b7e4ecab517200f50eb09f65a634c029437
BUG: 1320818
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13894
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 7aa689f872e20401198262ec625e74dcda8561f0
Author: vmallika <vmallika@redhat.com>
Date: Sun Apr 3 20:35:52 2016 +0530
quota: check inode limits only when new file/dir is created
When a inode limit is full, writes to any existing file
fails with disk quota exceed even if usage limit is
not set or usage limit is not full.
BUG: 1323486
Change-Id: I9679fe26a2839ade0b1541fa7f0a2b71ac6dcc31
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13911
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
commit 93f318452f4a60465c06e714ed983a26681d2862
Author: vmallika <vmallika@redhat.com>
Date: Wed Mar 30 20:16:32 2016 +0530
marker: build_ancestry in marker
* quota-enforcer doesn't execute build_ancestry in the below
code path
1) Special client (PID < 0)
2) unlink
3) rename within the same directory
4) link within the same directory
In these cases, marker accounting can fail as parent not found.
We need to build_ancestry in marker if it doesn't find parent
during update txn
Change-Id: Idb7a2906500647baa6d183ba859b15e34769029c
BUG: 1320818
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13857
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit 46c572779916b48c4122ddc5996b53fb93ee61da
Author: Sakshi <sabansal@redhat.com>
Date: Thu Jul 16 14:31:03 2015 +0530
dht: lock on subvols to prevent lookup vs rmdir race
There is a possibility that while an rmdir is completed on
some non-hashed subvol and proceeding to others, a lookup
selfheal can recreate the same directory on those subvols
for which the rmdir had succeeded. Now the deletion of the
parent directory will fail with an ENOTEMPTY.
To fix this take blocking inodelk on the subvols before
starting rmdir. Selfheal must also take blocking inodelk
before creating the entry.
Change-Id: I168a195c35ac1230ba7124d3b0ca157755b3df96
BUG: 1245065
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/13528
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 35861a12680d7d45bfa2304a050c2003a198499e
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Apr 1 23:10:51 2016 +0530
glusterd: fill real_path variable in brickinfo during volume import
Variable "real_path" in brick info was used to store absolute path
and using this we check the availability of the newly added bricks.
But we were not populating the variable when we import a volume
from peers. That caused to reset the real_path variable to zero,
which resulted in validation failure for all new brick creation.
Change-Id: I62be7bf452f0dcdf6aec3a4ec33c2e1fba2951ca
BUG: 1323287
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13890
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 95cb80282f80473c8f00d5c49186b6a1b8ac9438
Author: vmallika <vmallika@redhat.com>
Date: Sat Apr 2 09:20:45 2016 +0530
quota/cli: display quota usage on path when limit not set
When a quota limit is not set, 'quota list <path>' should still display
the usage when a path parameter is specified.
Change-Id: Ida12d9c5e348fbd98db4d68d9324c623cbdd3dea
BUG: 1323360
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13893
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit a79e71ef9284c67928074faaad44f70fcdab16fc
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Mar 31 14:58:02 2016 +0530
glusterd: build realpath post recreate of brick mount for snapshot
Commit a60c39d introduced a new field called real_path in brickinfo to hold the
realpath() conversion. However at restore path for all snapshots and snapshot
restored volumes the brickpath gets recreated post restoration of bricks which
means the realpath () call will fail here for all the snapshots and cloned
volumes.
Fix is to store the realpath for snapshots and clones post recreating the brick
mounts. For normal volume it would be done during retrieving the brick details
from the store.
Change-Id: Ia34853acddb28bcb7f0f70ca85fabcf73276ef13
BUG: 1322772
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13869
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit 56a04f81188ae3ab76289078a24c0557a817a6be
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 17 09:32:17 2016 +0530
cluster/afr: Use parallel dir scan functionality
BUG: 1221737
Change-Id: I0ed71a72f0e33bd733723e00a01cf28378c5534e
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13755
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 8492b6840f03ca5824a24efc3389cfacaad6969e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 17 09:32:02 2016 +0530
syncop: Add parallel dir scan functionality
Most of this functionality's ideas are contributed
by Richard Wareing, in his patch:
https://bugzilla.redhat.com/show_bug.cgi?id=1221737#c1
VERY BIG thanks to him :-).
After starting porting/testing the patch above, I found a few things we can
improve in this patch based on the results we got in testing.
1) We are reading all the indices before we launch self-heals. In some customer
cases I worked on there were almost 5million files/directories that needed
heal. With such a big number self-heal daemon will be OOM killed if we go
this route. So I modified this to launch heals based on a queue length
limit.
2) We found that for directory hierarchies, multi-threaded self-heal
patch was not giving better results compared to single-threaded
self-heal because of the order problems. We improved index xlator to
give gfid type to make sure that all directories in the indices are
healed before the files that follow in that iteration of readdir
output(http://review.gluster.org/13553). In our testing this lead to
zero errors of self-heals as we were only doing self-heals in parallel
for files and not directories. I think we can further improve self-heal
speed for directories by doing name heals in parallel based on similar
techniques Richard's patch showed. I think the best thing there would be to
introduce synccond_t infra (pthread_cond_t kind of infra for syncops)
which I am planning to implement for future releases.
3) Based on 1), 2) and the fact that afr already does retries of the
indices in a loop I removed retries again in the threads.
4) After the refactor, the changes required to bring in multi-threaded
self-heal for ec would just be ~10 lines, most of it will be about
options initialization.
Our tests found that we are able to easily saturate network :-).
High level description of the final feature:
Traditionally self-heal daemon reads the indices (gfids) that need to be healed
from the brick and initiates heal one gfid at a time. Goal of this feature is
to add parallelization to the way we do self-heals in a way we do not regress
in any case but increase parallelization wherever we can. As part of this following
knobs are introduced to improve parallelization:
1) We can launch 'max-jobs' number of heals in parallel.
2) We can keep reading indices as long as the wait-q for heals doesn't go over
'max-qlen' passed as arguments to multi-threaded dir_scan.
As a first cut, we always do healing of directories in serial order one at a time
but for files we launch heals in parallel. In future we can do name-heals of dir
in parallel, but this is not implemented as of now. Reason for this is mentioned
already in '2)' above.
AFR/EC can introduce options like max-shd-threads/wait-qlength which can be set
by users to increase the rate of heals when they want. Please note that the
options will take effect only for the next crawl.
BUG: 1221737
Change-Id: I8fc0afc334def87797f6d41e309cefc722a317d2
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13569
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit 1fa70fa2ecb0a27f4219e14615cf1b6e87ceb3cf
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Sat Aug 15 01:29:31 2015 +0530
glusterd: clean dead initializations
This patch cleans unused variable initialization as well as their declarations
which are no where used in the code
Change-Id: I784165fc6e91297758079699dd9583d5203b7793
BUG: 1253831
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/11929
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit db56f183e55f5b34a7496eafec62776d8b3f87ed
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Apr 1 15:33:22 2016 -0400
fdl: fix "used before set" warnings in librecon
Newer compilers were complaining about this in generated code, because
cleanup code fragments were being added in the wrong order.
Change-Id: I90ff6eccfa78dc012da6d8fd83443490a3cb276d
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13891
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit eb102b97205a5149fab6dccda777f82ad69d1a3d
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed Mar 30 15:04:39 2016 +0530
fdl: fix make clean
add fdl/src/librecon.c to CLEANFILES
Change-Id: I91332ddda5b4157483389c32b74d90a6a4e1322a
BUG: 1322323
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13850
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit 28314977acf904d2bc5d450f3c07726efdc91f6a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Apr 1 11:50:26 2016 +0530
cli: Make CLI timeout configurable
When number of volumes go high in numbers command like gluster volume status may
timeout from CLI since it follows a static timeout value of 120 secs.
This patch introduces a flag '--timeout' which can pass a specific time out
value for a particular command.
Change-Id: I9795b709f27357fe5ee10ba19de8f4c11b63186f
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13882
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d61fce8cdb1e104526e9920f9e4c11a5b4caa4ee
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Mar 31 11:01:53 2016 +0530
glusterd: Allocate fresh port on brick (re)start
There is no point of using the same port through the entire volume life cycle
for a particular bricks process since there is no guarantee that the same port
would be free and no other application wouldn't consume it in between the
glusterd/volume restart.
We hit a race where on glusterd restart the daemon services start followed by
brick processes and the time brick process tries to bind with the port which was
allocated by glusterd before a restart is been already consumed by some other
client like NFS/SHD/...
Note : This is a short term solution as here we reduce the race window but don't
eliminate it completely. As a long term solution the port allocation has to be
done by glusterfsd and the same should be communicated back to glusterd for book
keeping
Change-Id: Ibbd1e7ca87e51a7cd9cf216b1fe58ef7783aef24
BUG: 1322805
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13865
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a4ac276ad8f10353a3ef64d41d1908855e1c90c1
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu Mar 31 07:15:42 2016 -0400
packaging: gluster-ganesha requires pacemaker, etc., on RHEL6
HA packages in RHEL6 are missing dependencies. (RHEL7 versions do.)
Change-Id: I4e80b569ea89f97e8a110aee2f4554175aa0ec8b
BUG: 1322801
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13870
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
commit eac357e39b105e434d16a3d488bf0fea3d8f9841
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 31 17:15:14 2016 -0400
locks: fix build breakage from missing pl-messages.h
Change-Id: I0f8af57dd96226b1e7a8a39237a82ce1cdd48be6
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13876
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 2693cfd569fd08ab95a50cf6cdcbdbf626e4c2af
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Fri Apr 1 14:54:48 2016 +0530
tests: add open-behind.t to bad tests
open-behind.t fails on NetBSD very frequently
will be disabled until the problem is fixed
Change-Id: I0655e4b0c8b3ad7fc9e2ccfcf679673832ff12a5
BUG: 1300253
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13884
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit efd2a0c6598f87300cb308b3175f99b08b525b07
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Mar 30 17:42:44 2016 +0530
glusterd/syncop: double free of frame stack
If rpc message from glusterd during brick op phase
fails without sending, then frame was freed from
the caller function and call back function.
Change-Id: I63cb3be30074e9a074f6895faa25b3d091f5b6a5
BUG: 1322262
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13854
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit fff0cc52459a0a5475a90fc6985507f7b59e58da
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 12 14:57:47 2016 +0530
nsr: Introducing a happy path test case
Write infra for nsr_server to not send a
CHILD_UP before it gets a CHILD_UP from a
quorum of it's children. Using the CHILD_UP
received in the nsr client translator from
the server, to decide the right time for
starting the I/Os
Change-Id: I9551638b306bdcbc6bae6aeda00316576ea832fe
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13623
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 4d7e8adce14069102d9e0b3286f6fbdbb22f2400
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 28 16:31:12 2016 +0530
cluster/afr: Don't lookup/forget inodes
Problem:
All inodes that are looked-up are always forgotten without fail in
afr removing the benefits of them being in lru. This same code can
cause crashes if between inode_lookup, inode_forget in afr if the
top xlator does inode_forget(0).
Fix:
Don't use lookup/forget in afr. No benefits are there at the moment
for keeping this code. It is impossible to prevent top xlators to
do inode_forget(0). Found similar instances in ec
and removed them even though those code paths are not going to
be executed in any place other than heal-daemon.
BUG: 1321554
Change-Id: Ia4cb236178f7f129cc898d53f0bbd26f494a2a8d
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13834
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
commit bd0062713a4e70d138fffc264e10abfa762547ef
Author: Milind Changire <mchangir@redhat.com>
Date: Sat Nov 28 14:56:02 2015 +0530
tools/glusterfind: add --full option to query command
The --full option will use brickfind.py to list all files in the volume.
The output file will contain url-encoded file names prefixed with the
tag string to indicate that all files should be considered as new.
The default tag string for the --full option is "NEW". This can be
changed with the --tag-for-full-find command-line option.
Change-Id: Ic85ba5db062e19df13ae9dc2de8a08eacb5c9792
BUG: 1286279
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/12779
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit f44c4066cb8c2a1e09fae9c5548356ba3a6d73f7
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Mar 29 19:06:46 2016 +0530
features/changelog: Don't modify 'pargfid' in 'resolve_pargfid_to_path'
If 'changelog' is enabled and 'changelog.capture-del-path' option is on
it calls 'resolve_pargfid_to_path' which modifies 'pargfid' sent by
caller. 'changelog_unlink' calls this routine directly with
'loc->pargfid' resulting it being modified and point to root instead of
actual pargfid. This is a nasty bug and could cause the deletion of
entry on root directory instead on actual parent when 'loc->path' is
not present. Hence this fix to make 'pargfid' a const pointer and
'resolve_pargfid' to work on copy of pargfid.
Glusterfind session creation enables these options by default to
capture deleted entry path in changelog.
Thanks Pranith for root causing this.
Change-Id: I1d275a86f91c981b6889bedef93401c039d01d71
BUG: 1321955
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/13845
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 6ee69b679480d1402f6f0cee522f328a0a788c6a
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Mar 29 13:46:07 2016 +0530
glusterd: scan for open ports only in required range
It does not make sense to keep track of free ports from 0 to base_port
if we are not going to use them.
glusterd start times without this patch
2.622
2.478
2.455
2.590
2.400
glusterd start times with this patch
1.9
1.9
1.9
2.0
2.0
1.8
We save around half a second for every glusterd start.
BUG: 1322237
Change-Id: I0456689d0afad50dd068f2325ebfca9bdeffe01a
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13841
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5d48c5812dfb244962db78fb3c1b8a5c138ac224
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Mar 29 11:26:39 2016 +0530
extras: allign glusterd stop response in init script
An echo is missing stop() function which results in bad allignment of glusterd
stop output
Change-Id: I63ac9571457db90574fb1bfbf4f18ba09d3df1af
BUG: 1321762
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13839
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ed9bf85fbf0b71262c1e03d959a30c2aa1f9fd36
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed Mar 30 15:16:35 2016 +0530
build: git ignore files generated by fdl xlator
Change-Id: I7693624646cfab254c93afc0361b483a72c99841
BUG: 1322320
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13851
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e4eed3a76f4a5c05a8cc6d05fa1762456ef7e00e
Author: vmallika <vmallika@redhat.com>
Date: Tue Mar 29 18:34:11 2016 +0530
server: send lookup on root inode when itable is created
* xlators like quota, marker, posix_acl can cause problems
if inode-ctx are not created.
sometime these xlarors may not get lookup on root inode
with below cases
1) client may not send lookup on root inode (like NSR leader)
2) if the xlators on one of the bricks are not up,
and client sending lookup during this time: brick
can miss the lookup
It is always better to make sure that there is one lookup
on root. So send a first lookup when the inode table is created
* When sending lookup on root, new inode is created, we need to
use itable->root instead
Change-Id: Iff2eeaa1a89795328833a7761789ef588f11218f
BUG: 1320818
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13837
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 7e350f0de65ed83b6632d5e7f7dac43c8ab7d732
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Mar 21 16:57:48 2016 +0530
tools/glusterfind: Handling Unicode file names
Unicode filenames handled cleanly with this patch. Changelog
files and output files are opened with utf-8 encoding using codecs.open.
urllib.quote_plus and unquote_plus will not handle Unicode so, encode
Unicode to 8-bit string version before calling unquote. urllib.quote_plus
requires 8-bit string itself so do not decode to Unicode if we need to use
quote_plus(when --no-encode=false). Decode to unicode in --no-encode is set.
BUG: 1319717
Change-Id: If5561c749ab5529445650d322c831eb4da22b65a
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/13798
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit f7663554f0d81339df86e25a0cc26e74b36bb028
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Feb 17 15:57:02 2016 +0530
cluster/ec: Rebalance hangs during rename
Problem:
During the rename of a particular file (ec
is holding blocking inodelk on the parent
directory), if the rename of another file
under the same directory comes. EC does not
release the lock and goes ahead and renames
the "new" file with the "already held lock".
That causes rebalance process to be blocked
on a lock which has been acquired by rename.
Solution:
While rename fop comes, ec takes blocking inodelk
on old and new parent of the file. Before releasing,
every lock held by ec, it waits for some "time" to
see if that lock can be reused by the next fop.
If within this "time" some other request comes,
it releases this lock based on condition
"lock count > 1"
To get this "lock count" for rename fop, we have
implemented "pl_rename" in feature/lock. Also,
on ec side, changed the condition to release the lock
based on the type of fop and old and new parent
directories.
Change-Id: I979dbab1185df962e8f305a6074ae1186ffe7db0
Bug: 1304988
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13460
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 66b29ee875a2892898c485f67f2464570a32f298
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Mar 28 10:49:43 2016 +0530
libglusterfs: open cmd_history log file with O_APPEND and O_WRONLY
Commit 8fdfa0c introduced a fix to ensure cmd_history file is log rotated
properly. However with this fix fdopen() is called with mode "a" on a fd which
was not opened with O_WRONLY & O_APPEND resulting into a fdopen() failure.
Fix is to open cmd_history.log file with O_CREATE|O_WRONLY|O_APPEND mode
Change-Id: I75ef350560aa6d5435c78c5fd83adfde1a73bfc3
BUG: 1286959
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13829
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 8de4ac1fc0f1a25cf6796a4665c036e5f1a37df8
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Mar 25 18:48:30 2016 +0530
afr: add mtime based split-brain resolution to CLI
Extended the CLI to include support for split-brain resolution based on
mtime. The command syntax is:
$:gluster volume heal <VOLNAME> split-brain latest-mtime <FILE>
where <FILE> can be either the full file name as seen from the root of the
volume (or) the gfid-string representation of the file.
Change-Id: I7a16f72ff1a4495aa69f43f22758a9404e958b4f
BUG: 1321322
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13828
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit a9b18f48fd9ad067dd04bc8973bd5825a52d79b4
Author: Jiffin Tony Thottan <jthottan@gmail.com>
Date: Mon Mar 28 16:39:24 2016 +0530
build : fixing dependency issue for glusterfs-ganesha in epel6
glusterfs-ganesha requires "dbus-send" binary, but location of this
binary is different in epel6 and epel7. For epel6 it is /bin/ and
epel7 it is /usr/bin/. So the patch will add dependency based on
package dbus not on the binary dbus-send
Change-Id: I266af7b983791be648749f01a04b38479d6f7c03
BUG: 1321872
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/13842
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit b5a5780baea1cd9a1d65c5c4db656bbf8c64b83a
Author: Joseph Fernandes <josferna@redhat.com>
Date: Fri Mar 4 08:55:09 2016 +0530
tier/libgfdb: Ordering query results from libgfdb
When querying we will order the query result to get
the hotest or the coldest files in the queried list
so that these files are migrated first.
Now here we are giving priority to the write heat(time and counters),
as it requires complex queries to have a composite
ordering of write and read + it has it impact on performance.
Change-Id: I2e0415dcfad4218b42c68fc5c2ed8d1f075ce9ea
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/13607
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Joseph Fernandes
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit f815cfa60e728c42025241bb5514a6b12e1fe022
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Mar 24 20:43:05 2016 +0530
debug/trace: Print {acm}times as integers
This helps in debugging issues with mtime, ctime etc.
Change-Id: I4a0335f17c6b40e6c627658e91f43989c3efca22
BUG: 1302948
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13826
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit edca6d195f5b2106057a0e277f41a9dcc328352f
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Mar 22 16:32:32 2016 +0530
glusterd: Add a new event to handle multi-net probes
This allows GlusterD to send updates to all other nodes when attaching
new addresses using multi-net peer probe.
Change-Id: I62846be750ab3721912e7b49656594347ea61723
BUG: 1320458
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/13817
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 18c6bec984971f16af264e3c10c47add391b1ab9
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Feb 23 12:51:45 2016 +0530
tier/dht : Attach tier fix layout to run in background
1. Spawn a thread for background fix-layout for tier process.
2. Once the fix-layout is completed a marker xttr is set on the root of
volume to mark the completion of the background fixlayout, so that
even if the tier process is spawned again, fixlayout will not be
issued, if it was completed last time.
3. Please note that promotion of legacy files will happen eventually as
the ctr lookup heal in the fixlayout slowly heals the ctr db for legacy
files OR the ctr lookup heal happend due to a name lookup.
4. When a detach tier is successful in evacuation data from hot tier, we remove
the marker xattr is removed. So that next attach tier runs the background
tier fixlayout.
what is remaining ?
1. Instead of clearing the marker xattr of tiering fix layout at the end of detach start
clear it during detach commit. But the issue is detach commit is a glusterd operation
and the volume is not mounted in glusterd.
The reason we want to do it in detach commit is that if the admin wants to attach the
same tier again, then a background fixlayout will be triggered, which would not be needed.
2. Clearing the CTR DB of the cold bricks when there is a detach commit, as it will be having
entries which will be stale when the volume is used, with ctr off (ctr is switched off only when
we have detach commit.)
Change-Id: Ibe343572e95865325cd0eef4d0b976b626a3c0c5
BUG: 1313228
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/13491
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Joseph Fernandes
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 748ef4d8e5f3a8f23e7850e56dc9aa0f475deaf1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Mar 25 06:04:23 2016 +0530
cluster/afr: Fix read-child selection in entry create fop
When an entry is being created the inode is yet to be linked
so args must be filled with gfid and ia_type for it to give
consistent iatt.
Also handle Dht sending fops on inode not yet linked.
BUG: 1302948
Change-Id: I6969cacb437cad02f66716f3bf8ec004ffe7c691
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13827
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit a8265c92ece2d8fd4b112d77ece44f4ad0e4d3e5
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Mar 14 15:10:17 2016 -0400
storage/posix: send proper iatt attributes for the root inode
* changes in posix to send proper iatt attributes for the root directory
when ancestry is built. Before posix was filling only the gfid and the
inode type in the iatt structure keeping rest of the fields zeros. This
was cached by posix-acl and used to send EACCES when some fops came on
that object if the uid of the caller is same as the uid of the object on
the disk.
* getting and setting inode_ctx in function 'posix_acl_ctx_get' is not atomic
and can lead to memory leak when there are multiple looups for an
inode at same time. This patch fix this problem
* Linking an inode in posix_build_ancestry, can cause a race in
posix_acl.
When parent inode is linked in posix_build_ancestry, and before
it reaches posix_acl_readdirp_cbkc, reate/lookup can
come on a leaf-inode, as parent-inode-ctx not yet updated
in posix_acl_readdirp_cbk, create/lookup can fail
with EACCESS. So do the inode linking in the quota xlator
Change-Id: I3101eefb65551cc4162c4ff2963be1b73deacd6d
BUG: 1320818
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/13730
Tested-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit a9a58e732ec7a472e18b94b1d563d585b0c0ee02
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Mar 23 11:26:49 2016 +0530
glfs/heal: Use encrypted connection in shd
When management encryption is enabled, GlusterD
only allows encrypted connections for port 24007.
SHD is trying to fetch it's volfile using an
unencrypted connection.
If /var/lib/glusterd/secure-access is present , i.e.
if management ssl is enabled, use encrypted connection
fecth info from glusterd.
Change-Id: Ia41dcde1a69375379409889ec5b3a70cb95a4fd0
BUG: 1320388
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13815
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit d1aed335c21275db5fc99708a1438c6235f7997f
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed Mar 23 15:45:08 2016 +0530
glfs-mgmt: fix connecting to multiple volfile transports
Problem:
[
{"host":"1.2.3.4", "port":"24007", "transport":"tcp"},
{"host":"/var/run/glusterd.socket", "transport":"unix"}
]
Consider the above case where we have two volfile servers, each
has different transport type, we first try to connect to server1
which has transport type "tcp" let's say we found that host address
is invalid, now we pick the next available server2, in our case
it is of type "unix" and try to connect to it.
but we fail to connect to it even we have right unix path, because
multiple volfile servers with different transport type is not taken
care currently.
Solution:
Every time we receive a RPC_CLNT_DISCONNECT event in mgmt_rpc_notify,
we need to check the transport type of the volfile server in the list
and set the keys "transport.socket.connect-path" or "remote-host"
accordingly.
Change-Id: I36bec46ef2e92e4642a7d7d64b423d0bc3ab269b
BUG: 1320489
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13819
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Prasanna Kumar Kalever <pkalever@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit f389f3709fbce9c99e2274fa3f2b48298b3d94b3
Author: Shyam <srangana@redhat.com>
Date: Mon Feb 8 14:44:32 2016 +0530
dht2: Creation of experimental shell for dht2
Change-Id: I1aa3ea25f99d36fa2356edaa4c3132386adef303
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/13397
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 6a932175dca671e50038ee962816a53f349fba77
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Mar 22 15:51:37 2016 +0530
debug/io-stats: Disable fop stats dump by default
Even though someone is not interested in seeing the fops statistics in
client logs under DEBUG level we forcefully dump the same. This is due
to default dump-interval configured to as 5 seconds. Since can use
diagnostics.stats-dump-interval volume set option to change the default
dump-interval its better to disable this huge dumping by default.
Change-Id: Id14a38bcd92e47d75003279567a0f80acac1d86e
BUG: 1320101
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/13808
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 37c9a0b580c19ed5b23bc002f22a883d603c36ea
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Sat Aug 15 01:06:32 2015 +0530
glusterd: remove unused large memory/buffer allocations
This patch cleans dead buffer allocations which are never used in the
code.
Change-Id: I8c55837434fd5bf9dde9fb7b070fdefbf64cf4a3
BUG: 1253828
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/11928
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a3e3b0d40fb14bee7eabcf45e3687ceeeee46a8f
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Sat Mar 19 10:15:24 2016 +0530
dht: update attr information in refresh layout to avoid stale timestamp
Consider the scenario where an mkdir has just created the
directory but has not healed it yet. A parallel lookup on
this entry will find anomalies and trigger a selfheal which
will sample the ctime of the directory after the mkdir phase.
Meanwhile the mkdir has completed setting the layout and
updated the ctime. The selfheal then sees the layout to be
healed and returns with the ctime it got after the mkdir phase
which has now become stale. However if the lookup happens
to unwind before the mkdir then the inode associated with
lookup will get linked in the inode table which has the
stale ctime. To avoid this selfheal must do an iatt_merge in
refresh layout to get the latest timestamp irrespective of
whether it needs to heal the layout or not.
Change-Id: I3634c3978bcc1710705f44b48f3876601682d33e
BUG: 1302948
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/13781
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 3fdbc00f75673b60ca3ee972fa9101fdeb5cd479
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Mar 10 16:43:08 2016 +0530
cli: Do not remove whitespace if key is user.* in volume set
setting any user.* option can have multiple words in the key and hence skip the
process of trimming whitespaces.
Change-Id: Ia295428d7cda55e5470fef668325bea497f2333d
BUG: 1316499
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13669
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit eda748154823b56c7f1e75f6ac454d265c968a1b
Author: Poornima G <pgurusid@redhat.com>
Date: Sat Mar 19 04:38:47 2016 -0400
gfapi: Fix the crashes caused by global_xlator and THIS
Issue: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10922
The right fix for this is elaborate and intrusive, until it is in place,
this patch provides a temperory fix. This fix is necessary, as without this
libgfapi applications like qemu, samba, NFS ganesha are prone to crashes.
This patch will be reverted completely, once the actual fix gets accepted.
Change-Id: Ic975ab0bb03ba415cdf9bddba1534ba4d2d2820c
BUG: 1319374
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/13784
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 1a3fbad29ded775e20df1355d4e41c44fc588953
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Mar 21 16:38:25 2016 +0530
extras:add gfid-to-dirname.sh
Add a script that converts the gfid-string of a directory into absolute
path name w.r.t the brick path.
Example:gfid-to-dirname.sh /home/ravi/bricks/brick1 e9c81321-f009-41b0-a009-cd77888c217e
Location of the directory corresponding to gfid:e9c81321-f009-41b0-a009-cd77888c217e is /home/ravi/bricks/brick1/d1/d2/d3/d4/d5/d6/d7/
Change-Id: I276ddf9c4f3d11a5b1932286d848b00b5ea1895d
BUG: 1319706
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13797
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: bipin kunal <kunalbipin@gmail.com>
Tested-by: bipin kunal <kunalbipin@gmail.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit d23d583870a3a60414da89ddeb7ee5a5cdff1ef7
Author: Ravishankar N <root@ravi2.(none)>
Date: Tue Mar 22 12:56:41 2016 +0000
glusterd/ afr: Fix op-version for background client-side heals
http://review.gluster.org/13207 tied cluster.heal-wait-queue-length to
GD_OP_VERSION_3_7_9 but the patch will be merged in release-3.7 branch
(http://review.gluster.org/#/c/13564/) only for 3.7.10.
Hence change it on master also for uniformity.
Change-Id: Id581695e58b0765f5652016cc2045f05e36b768f
BUG: 1297172
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13810
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 78e84bc5a5a4b2c48ca995965d9147d8c6e797ae
Author: Anoop C S <anoopcs@redhat.com>
Date: Sun Dec 20 21:47:37 2015 +0530
features/locks: Remove unneeded function parameter
We use list_del_init() inside __delete_lock()
to remove a lock from inode's lock list where
pl_inode_t is not required at all. This patch
removes pl_inode_t from list of parameters
required for __delete_lock().
Change-Id: Ic5701bcae231172d4fd7feda1b25752343ee81cf
BUG: 1293227
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/13033
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 51a0b483a1d92371aba4c3a69059177e95707491
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun Mar 20 18:31:00 2016 +0530
glusterd/rpc : Discard duplicate Disconnect events
If a peer rpc disconnect event has been already processed, skip the furthers as
processing them are overheads and sometimes may lead to a crash like due to a
double free
Change-Id: Iec589ce85daf28fd5b267cb6fc82a4238e0e8adc
BUG: 1318546
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13790
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2eeb6c8e4d5cee370deddffc33fede12ef00db74
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Dec 15 00:19:41 2015 -0500
extras: Ease creation of new xlators
Add a python generator that creates a template for new xlator.
Co-Authored by Jeff Darcy.
Change-Id: I10820c0483794dcd450656684cf954f7b8f159e0
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/13061
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit dc85fca2bb7cbc9f5c15687968afaeb2382c13fe
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Sep 4 16:19:01 2013 +0530
glusterd: Fix connected clients check during 'volume set'
Use the volume's newly calulatedclient-op-version for the connected
clients check. This prevents rejection of server options of higher
op-version when clients of lower op-version are connected. Also,
initialize the variables of the newly calculated volume op-version and
client-op-version with the current values, instead of the cluster
op-version.
Change-Id: Ieb36f97c677a5457feba54bef20e154c0456e70e
BUG: 1004332
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5786
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 543bbe0d962bc8e86ceb27e8bc9e8251195ca6f8
Author: vmallika <vmallika@redhat.com>
Date: Wed Mar 16 13:31:10 2016 +0530
marker: set inode ctx before lookup unwind
When a file is unlinked before it was accounted by the marker,
then we may see error "ctx for the node ... is NULL" at many places.
This is actually not an error and can be ignored.
It is better to set the inode ctx before lookup/create is unwind
back to protocol server
Change-Id: I462b5542951f2fc2964f59af7a31978979dab1de
BUG: 1318158
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13748
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 81856814783e778f74c0fe4543b5c505b4dd2cd4
Author: Anuradha Talur <atalur@redhat.com>
Date: Tue Feb 23 10:56:51 2016 +0530
afr : Enable auto heal when replica count increases
This patch is part two change to prevent data loss
in a replicate volume on doing a add-brick operation.
Problem: After doing add-brick, there is a chance
that self heal might happen from the newly added
brick rather than the source brick, leading to data loss.
Solution: Mark pending changelogs on afr children for
the new afr-child so that heal is performed in the
correct direction.
Change-Id: I11871e55eef3593aec874f92214a2d97da229b17
BUG: 1276203
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12454
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 141b4a6815108810ac5e4865239a08a8fb049f94
Author: Anuradha Talur <atalur@redhat.com>
Date: Wed Mar 16 10:55:09 2016 +0530
glusterd / afr : Enable auto heal when replica count increases
In replicate volumes, when a brick is added to a replicate
group, heal to the new brick should be triggered.
Also, the new brick should not be considered as source for
healing till it is up to date.
Previously, extended attributes had to be set manually on
the bricks for this to happen. This patch is part 1 patch
to automate this process.
Change-Id: I29958448618372bfde23bf1dac5dd23dba1ad98f
BUG: 1276203
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12451
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit dbdb34d02d0afed82e0b2f36f6cf7e46bcef5d09
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Mar 17 13:37:59 2016 +0530
glusterd/snapshot: dereferencing null variable resulted in crash
When we add service details into dictionary, snapd is volume
based service. So the svc variable for snapd will be stored in
volinfo. But when we trying to add details for snapd node alone
we use generic function, ie that won't have the svc variable
initialized.
Change-Id: I7e4abc477e6c520388d696548ffa260a43281827
BUG: 1318544
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13759
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 2d50528358affb318fef5d83fb37adef3fe07fda
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Mar 14 16:36:33 2016 +0530
ganesha: Include a script to generate epoch value
In a NFS-Ganesha HA cluster setup, for NFS clients to recover state
succesfully post failover, the NFS-servers should start with a unique
epoch value.
With NFS-Ganesha 2.3, the service accepts an option "EPOCH_EXEC" which
takes path of the script, generating epoch value. This script is executed before
starting nfs-ganesha service so that the generated epoch value is used
while bringing up the service.
This patch includes the script to be used by nfs-ganesha+gluster setup.
The epoch value is computed as follows -
- first 32-bit contains the now() time
- rest 32-bit value contains the local glusterd node uuid
Change-Id: I876ea5a3730d7c6b40503e0fec16a4a142c54a36
BUG: 1317902
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13744
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 5a08378d4415736ec54673f18815051a1544deaf
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 17 13:33:34 2016 -0400
dht: report constant directory size
Directory size is meaningless. Every filesystem has its own
unpredictable way of increasing or decreasing it, based on internal data
structures and even transient conditions. Some filesystems (e.g. ext4)
never decrease it at all. Others (e.g. btrfs) don't even report it.
Very few programs look at it, and those that do are broken.
Unfortunately, one such program is GNU tar, which will complain when it
sees different values because at different times we got the value from
different DHT subvolumes. To avoid such problems, just report a
constant value.
Change-Id: Id64ce917c75b5f7ff50cb55b6e997f3b3556e7e3
BUG: 1302948
Original-author: Shyam <srangana@redhat.com>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/13770
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e7931dab6adc406341328456577519493121c3af
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Mar 17 22:44:12 2016 +0530
features/trash: Handle unexpected errors during mkdir
When expected directory hierarchy in not present in trash directory,
trash translator tries to create it inside the same. Any errors from
posix other than the expected ones should be handled properly during
an internal mkdir call and logged accordingly explaining the reason
for not moving the file to trash directory.
Change-Id: I4e19637138ea4fb92f9301be372ac19542a6aed8
BUG: 1318757
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/13771
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 32e101f524c23fc659845747b00d8c4ad64b4527
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 16 21:55:35 2016 +0530
cluster/afr: Enhance the test to be more robust
In some cases of dht, there is code path (dht_lookup_directory) where it sets
gfid-req before lookup. This leads to successful setting of gfid when there are
only two subvolumes in distribute. So increased number of replica subvolumes.
Also increased number of directories.
Change-Id: I17092ce6dc69c7fed6e6b380eb0fc0040f19c06a
BUG: 1312816
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13754
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Ravishankar N <ravishankar@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 0f8d173cee6fe9614a2b945cc557676b15fce965
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Mar 16 13:08:23 2016 +0530
storage/posix: Typo in log message
Fixed missing spaces between some words in a log message.
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Change-Id: I24398e6dd2ab83956827fc905f43cffd7e699c51
BUG: 1318107
Reviewed-on: http://review.gluster.org/13747
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2088ddb27fb31ad5b29035e6639e650ed86481c3
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Fri Feb 26 19:34:38 2016 +0530
changelog: fix typecasting of function
fix compiler error:
"error: void value not ignored as it ought to be"
while the code tries to typecast return type of
'LOCK_DESTROY(lock)' to (void)
Change-Id: I38ed47f3a12719c7a4a59388c0d021858d4dfe6d
BUG: 1312354
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13533
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 1e65059d532844b56585389b279e75661f3849c0
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Fri Feb 26 19:28:58 2016 +0530
nfs: fix lock variable type
variable 'mountlock' should be generic
since it is used by macros LOCK_* ,
it can be used spinlock or mutexlock
Change-Id: If558bcf8debd98c4e1a615df0f9f0caec586e39b
BUG: 1312346
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13532
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ac248c86c1ffae4895c3589806a13064e0029631
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Thu Feb 11 23:45:37 2016 +0530
lock: use spinlock only on multicore systems
Using spinlocks on a single-core system makes usually no meaning,
since as long as the spinlock polling is blocking the only available
CPU core, no other thread can run and since no other thread can run,
the lock won't be unlocked until its time quantum expires and it gets
de-scheduled. In other words, a spinlock wastes CPU time on those
systems for no real benefit. If the thread was put to sleep instead,
another thread could have ran at once, possibly unlocking the lock and
then allowing the first thread to continue processing, once it woke up
again.
Change-Id: I0ffc14e26c2e150b564bcb682a576859ab1d1872
BUG: 1306807
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13432
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 3b7f8c81fd912ad115525994cb1e9145e9c2d5d3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Mar 15 11:58:44 2016 +0530
tests: Self-heald.t spurious failure fix
Problem:
There is no guarantee that the indices are created by the time
write is complete because write-behind may not flush the buffers.
Fix:
Disable flush-behind so that by the time 'echo abc > file' completes,
indices are created.
Also removed split-brain-healing.t from spurious failures as we are
not able to recreate it.
BUG: 1306897
Change-Id: I5c9c735430f1736747c8d7396d2cbf487533f4b5
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13434
Reviewed-by: Anuradha Talur <atalur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit b55c1e1144c026eb601f18168f32a9a4fd499471
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Mar 1 15:03:54 2016 -0500
cluster/tier: add tunable to migrate files based on size
This fix adds a paramater "tier-max_promote_size" to control wether
a file is migrated or not based on its size. By default the value
is 0, meaning all files are migrated. If set to a non-zero
value, files larger than the parameter won't be moved
in tiered volumes.
Change-Id: Ia6b88e9b2508935bef500d956f9192e59670fe00
BUG: 1313495
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/13570
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
commit c5b340c12fcdc599e52575050f3003c665164b17
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Mar 13 10:44:12 2016 -0400
mount/fuse: cleanup an additional inode_ref()
commit ca515db0127 introduced a check in
fuse_resolve_inode_simple(). This results in an additional
ref being held on inodes which were obtained through readdirp.
As a result, the inode table keeps growing and entries remain in
the active list even after deletion of such inodes.
Change-Id: I780ec5513990d6ef00ea051ec57ff20e4428081e
BUG: 1317948
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/13689
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 7f40e547070dc950e83ecfef96dc0a8414df57b4
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue Mar 15 14:21:18 2016 +0530
md-cache: Cache gluster-swift metadata
BUG: 1317785
Change-Id: Ie02b8fc294802f8fdf49dee8bf97f1e6177d92bd
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/13735
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
commit 730633e1c089aa17db900c30efc788f410f9aa17
Author: hari <hgowtham@redhat.com>
Date: Mon Dec 28 16:04:50 2015 +0530
Cli/tier: separating services from cold bricks in xml
fix: The cold bricks tag included the processes also.
The patch has removed the processes from being mentioned
inside the cold brick tag and are mentioned below by
closing the cold brick tag after the brick count.
Previous output:
<coldBricks>
<node>
<hostname>192.168.1.102</hostname>
<path>/data/gluster/b3</path>
<peerid>8c088528-e1aee3b2b40f</peerid>
<status>1</status>
<port>49157</port>
<ports>
<tcp>49157</tcp>
<rdma>N/A</rdma>
</ports>
<pid>1160</pid>
</node>
<node>
<hostname>NFS Server</hostname>
<path>localhost</path>
<peerid>8c088528-e1aee3b2b40f</peerid>
<status>0</status>
<port>N/A</port>
<ports>
<tcp>N/A</tcp>
<rdma>N/A</rdma>
</ports>
<pid>-1</pid>
</node>
</coldBricks>
Expected output:
<coldBricks>
<node>
<hostname>192.168.1.102</hostname>
<path>/data/gluster/b3</path>
<peerid>8c088528-e1aee3b2b40f</peerid>
<status>1</status>
<port>49157</port>
<ports>
<tcp>49157</tcp>
<rdma>N/A</rdma>
</ports>
<pid>1160</pid>
</node>
</coldBricks>
<node>
<hostname>NFS Server</hostname>
<path>localhost</path>
<peerid>8c088528-e1aee3b2b40f</peerid>
<status>0</status>
<port>N/A</port>
<ports>
<tcp>N/A</tcp>
<rdma>N/A</rdma>
</ports>
<pid>-1</pid>
</node>
Change-Id: Ieccd017d7b2edb16786323f1a76402f020bdfb0d
BUG: 1294497
Signed-off-by: hari <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/13101
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit d2436bf6bccf8d095d9dcb4dcdfbd7956aa7957b
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Mar 11 15:07:48 2016 +0530
posix: Filter gsyncd stime xattr
Filter gsyncd stime xattr in lookup as well.
The value of stime would be different among
replica bricks and EC bricks. AFR and EC
should not take any action on these as it
could be different.
Change-Id: If577f6115b36e036af2292ea0eaae93110f006ba
BUG: 1296496
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/13678
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a86c4e399fd1a194f4366059b1d77901bbaa6859
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Mar 4 13:05:09 2016 +0530
cluster/ec: Provide an option to enable/disable eager lock
Problem: If a fop takes lock, and completes its operation,
it waits for 1 second before releasing the lock. However,
If ec find any lock contention within this time period,
it release the lock immediately before time expires. As we
take lock on first brick, for few operations, like read, it
might happen that discovery of lock contention might take
long time and can degrades the performance.
Solution: Provide an option to enable/disable eager lock.
If eager lock is disabled, lock will be released as soon
as fop completes.
gluster v set <VOLUME NAME> disperse.eager-lock on
gluster v set <VOLUME NAME> disperse.eager-lock off
Change-Id: I000985a787eba3c190fdcd5981dfbf04e64af166
BUG: 1314649
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13605
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 7c78a2e2e952f177215814fb338dd6c548c18597
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 7 11:52:18 2016 +0530
protocol/server: Do not log ENOENT/ESTALE in fd based fops
When fd-fops come on anon-fds there is a chance to log ENOENT/ESTALE for them.
Log it as DEBUG.
Change-Id: I8ae53c29d6a66f6a65081c281a9a5c205f53766b
BUG: 1315168
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13621
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit 24949f6fe846fc5a4642462e385bc7f45164df1b
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Mon Mar 14 07:41:11 2016 -0400
ganesha-ha: merge release-3.7 to master for release-3.8
cherry-pick changes from release-3.7 branch to master in preparation
for 3.8
changes merged/cherry-picked from release-3.7 consist of:
> common-ha: delete virt-IP entry of deleted node
> commit aee983ff43655771a9102592a284d0b0a29ad89f
> BUG: 1250601
>
> common-ha: concise output for HA status
> commit d804b17f2fe92b1516f85f03978072c42ddc6f19
> BUG: 1250628
>
> common-ha : refresh-config should print sensible output
> commit d7adcca24fb9638df2806c01d8ea7e73eec46928
> BUG: 1254494
>
> CommonHA: Avoid scp of the config state to the same host
> commit 07b31a008b59d6c0b06bd17994de85fc56560b38
> BUG: 1259225
>
> CommonHA: Fix the path of 'systemctl' cmd
> commit 8e7ca068720fa6fa50e4746e5b17c305f38171e8
> BUG: 1259225
>
> common-ha: refresh-config output includes dbus "method return" msg
> commit 045cb34238e341d68288893b8f040056e138c04e
> BUG: 1262881
>
> common-ha: distribution neutral location of config files
> commit 6667478cdba920d2658bba2edc99c8f8cc33e271
> BUG: 1251821
>
> common-ha: Corrected refresh-config output parsing
> commit 2892bab69cac2d991509fca1279a659bce1ae793
> BUG: 1254494
>
> common-ha: reliable grace using pacemaker notify actions
> commit e8121c4afb3680f532b450872b5a3ffcb3766a97
> BUG: 1290865
>
> ganesha: Read export_id on each node while performing refresh-config
> commit e0e633cdce7586af92490730257ed7f0cffcff61
> BUG: 1309238
>
> nfs-ganesha: pcs cluster setup needs '--name' option
> commit 812e7321d3c56d329526628fe96a8f6fabea75ca
> BUG: 1314204
Change-Id: I41c19bd369bd9da1092b0677590634a4e9f72813
BUG: 1317424
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13728
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 0ea264fa2cda6dd3421dc8e74ae00649dc7a9015
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Mar 3 14:08:39 2016 +0530
nfs-ganesha: pcs cluster setup needs '--name' option
Even on fedora machines (on f22, f23), pcs cluster setup CLI
expects '--name' to be provided. This patch addresses the same.
BUG: 1314204
Change-Id: If23851bfd7fe2f1c200731d66dcb3e744390ff83
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13590
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-on: http://review.gluster.org/13727
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit a9fc49e010663f7243287fedb0135cae7af26273
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Feb 17 15:34:44 2016 +0530
ganesha: Read export_id on each node while performing refresh-config
As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1309238#c1,
there could be cases which shall result in having different ExportIDs
for the same volume on each node forming the ganesha cluster.
Hence during refresh-config, it is necessary to read the ExportID on
each of those nodes and re-export that volume with the same ID.
BUG: 1309238
Change-Id: Id39b3a0ce2614ee611282ff2bee04cede1fc129d
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13459
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13726
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit afc161ad0baa62534e3501d30fbd26b6dd4a8aec
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Wed Mar 9 22:05:18 2016 +0530
gfapi: preserve glfd state during glfs_dup
Following patch introduced a new state variable in glfd
to track the current status of the fd.
http://review.gluster.org/13340/
But this state was not copied in glfd_dup function.
BUG: 1311146
Change-Id: I283f8944035f6defe491f81e13d7ef28fc440572
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/13666
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 8ef6089a5d11f5c3699bd77ac3962973de64e724
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Mar 8 16:38:34 2016 +0530
TIER: stopping the tierd when the volume goes down
If there are large number of files to be migrated
and by this time if the volume goes down, then the tierd
has to be stopped. But on a huge query file list it keeps
checking for each file before stopping. If the volume comes
up before the old tierd dies then due to the
presence of old tierd new one won't be created. After
the old one completes the task, it dies and the status
ends up as failed.
This patch will check if the status is still running and then let
it continue its work. Else it will stop running the tierd.
Change-Id: I6522a4e2919e84bf502b99b13873795b9274f3cd
BUG: 1315659
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/13646
Tested-by: Dan Lambright <dlambrig@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 7b1a529551789493485d7542020133254d49e65f
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Mon Dec 14 09:24:57 2015 -0500
common-ha: reliable grace using pacemaker notify actions
Using *-dead_ip-1 resources to track on which nodes the ganesha.nfsd
had died was found to be unreliable.
Running `pcs status` in the ganesha_grace monitor action was seen to
time out during failover; the HA devs opined that it was, generally,
not a good idea to run `pcs status` in a monitor action in any event.
They suggested using the notify feature, where the resources on all
the nodes are notified when a clone resource agent dies.
This change adds a notify action to the ganesha_grace RA. The ganesha_mon
RA monitors its ganesha.nfsd daemon. While the daemon is running, it
creates two attributes: ganesha-active and grace-active. When the daemon
stops for any reason, the attributes are deleted. Deleting the
ganesha-active attribute triggers the failover of the virtual IP (the
IPaddr RA) to another node where ganesha.nfsd is still running. The
ganesha_grace RA monitors the grace-active attribute. When the
grace-active attibute is deleted, the ganesha_grace RA stops, and will
not restart. This triggers pacemaker to trigger the notify action in
the ganesha_grace RAs on the other nodes in the cluster; which send a
DBUS message to their ganesha.nfsd.
(N.B. grace-active is a bit of a misnomer. while the grace-active
attribute exists, everything is normal and healthy. Deleting the
attribute triggers putting the surviving ganesha.nfsds into GRACE.)
To ensure that the remaining/surviving ganesha.nfsds are put into
NFS-GRACE before the IPaddr (virtual IP) fails over there is a short
delay (sleep) between deleting the grace-active attribute and the
ganesha-active attribute. To summarize:
1. on node 2 ganesha_mon:monitor notices that ganesha.nfsd has died
2. on node 2 ganesha_mon:monitor deletes its grace-active attribute
3. on node 2 ganesha_grace:monitor notices that grace-active is gone
and returns OCF_ERR_GENERIC, a.k.a. new error. When pacemaker
tries to (re)start ganesha_grace, its start action will return
OCF_NOT_RUNNING, a.k.a. known error, don't attempt further
restarts.
4. on nodes 1, 3, etc., ganesha_grace:notify receives a post-stop
notification indicating that node 2 is gone, and sends a DBUS
message to its ganesha.nfsd putting it into NFS-GRACE.
5. on node 2 ganesha_mon:monitor waits a short period, then deletes
its ganesha-active attribute. This triggers the IPaddr (virt IP)
failover according to constraint location rules.
ganesha_nfsd modified to run for the duration, start action is invoked
to setup the /var/lib/nfs symlink, stop action is invoked to restore it.
ganesha-ha.sh modified accordingly to create it as a clone resource.
BUG: 1290865
Change-Id: I1ba24f38fa4338b3aeb17c65645e9f439387ff57
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12964
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-on: http://review.gluster.org/13725
commit 73367e6e63696753c4013bd63aae67ceb4a00eda
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Oct 28 14:50:55 2015 +0530
common-ha: Corrected refresh-config output parsing
>>>> Sample program with the earlier changes -
output=$(dbus-send --print-reply --system \
--dest=org.ganesha.nfsd /org/ganesha/nfsd/ExportMgr \
org.ganesha.nfsd.exportmgr.RemoveExport uint16:5 2>&1\
| grep -v "^method return")
ret=$?
echo "${output}"
echo $ret
sleep 1
output=$(dbus-send --system --dest=org.ganesha.nfsd \
/org/ganesha/nfsd/ExportMgr org.ganesha.nfsd.exportmgr.AddExport \
string:/usr/etc/ganesha/exports/export.vol3.conf \
string:"EXPORT(Path=/vol3)" 2>&1 | grep -v "^method return")
ret=$?
echo "${output}"
echo $ret
Output:
1
1
Even if the command was successfully executed, 'grep -v' has
filtered out the output.
>>>> Sample program with the current changes -
output=$(dbus-send --print-reply --system --dest=org.ganesha.nfsd \
/org/ganesha/nfsd/ExportMgr org.ganesha.nfsd.exportmgr.RemoveExport\
uint16:5 2>&1)
ret=$?
echo "${output}"
echo $ret
sleep 1
output=$(dbus-send --print-reply --system --dest=org.ganesha.nfsd \
/org/ganesha/nfsd/ExportMgr org.ganesha.nfsd.exportmgr.AddExport \
string:/usr/etc/ganesha/exports/export.vol3.conf \
string:"EXPORT(Path=/vol3)" 2>&1)
ret=$?
echo "${output}"
echo $ret
Output:
method return sender=:1.155 -> dest=:1.174 reply_serial=2
0
method return sender=:1.155 -> dest=:1.175 reply_serial=2
string "1 exports added"
0
BUG: 1254494
Change-Id: I44fbe32588ec11f087c8b99b2d55ed55ba73727c
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/12439
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13724
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 946b0ac81f3e776045a8801ed786d452771ac89b
Author: Joe Julian <jjulian@io.com>
Date: Tue Sep 8 09:53:54 2015 -0700
common-ha: distribution neutral location of config files
work on systems with config files in directories other than
/etc/sysconfig.
BUG: 1251821
Change-Id: I009946623b508ba422a4881913455218d8846055
Signed-off-by: Joe Julian <me@joejulian.name>
Reviewed-on: http://review.gluster.org/12132
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13723
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 0f838ce9a4b13d1b7cacf08b8deaf0f5bc543a0a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Sep 14 12:32:09 2015 -0400
common-ha: refresh-config output includes dbus "method return" msg
filter out extraneous text from dbus-send
BUG: 1262881
Change-Id: I2fec5c0cc8d1db0a12a42ca2d727a4320fd57b30
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12174
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13722
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 9a1d300a3e31ec66a12191b27c3bf09d930fd57a
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Sep 2 14:17:55 2015 +0530
CommonHA: Fix the path of 'systemctl' cmd
'systemctl' command path should be '/usr/bin/sytemctl'.
Fixed the typo in the HA-script.
BUG: 1259225
Change-Id: I0e7fcc1eb74419679d78d4cc61253c6edf23b57b
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/12089
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-on: http://review.gluster.org/13721
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit ad252c6b75b001beeaaaea2eaf8dfadadf819774
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Sep 2 17:15:23 2015 +0530
CommonHA: Avoid scp of the config state to the same host
During add-node, have seen an issue where in scp doesn't work
if the source and destination host are same. Fixed the same.
BUG: 1259225
Change-Id: Ib8fe21b3c95d653c62698310d5390b46a3c6bbf4
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/12091
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-on: http://review.gluster.org/13720
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 9a91ecd1b8311c6358f482e549bfe055b0aee94d
Author: Meghana M <mmadhusu@redhat.com>
Date: Wed Aug 12 14:48:39 2015 +0530
common-ha : refresh-config should print sensible output
ganesha-ha.sh --refresh-config printed the dbus-send output
messages as is on the console. Improving the output
of the operation by redirecting the messages to /var/log/messages
and by checking the exit code of the command executed.
The behaviour is also changed a litlle by exiting
when refresh-config fails on any of the nodes.
We don't want to continue changing config files
on other nodes when refresh-config has already failed
on one of the nodes.
BUG: 1254494
Change-Id: I33a1c0f750695135118b4ad4d5fa038b27bc7fec
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11949
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-on: http://review.gluster.org/13719
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 74a30ae3dd1745afe5bdb07baf74abf4de1d121b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Aug 18 02:51:00 2015 -0400
common-ha: concise output for HA status
filter out unnecessary detail from the HA status
BUG: 1250628
Change-Id: I85fb3aaa3dacee2b1c48f46fb7eef6dc255168bc
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11942
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/13718
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit ab1b433d566fb4c4259a978933d627bf9b17be09
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Aug 5 11:16:34 2015 -0400
common-ha: delete virt-IP entry of deleted node
Avoid accumulating invalid/defunct virtual IP entries in the HA
config file.
use correct 'clean' name when adding a node and its virtual IP
Also fix a nit in the sample HA config file
BUG: 1250601
Change-Id: I0e6a251334e854d0003d5930ca804f972900b624
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11841
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13717
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit ea1983b2ea366fe49f32a756ad45bf1c1837cada
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Mar 8 23:05:08 2016 +0530
cluster/ec: Do not ref dictionary in lookup
Problem:
1) dict_for_each loops over the elements without any locks, so the members of
the dictionary can be ref/unrefed while dict_for_each is executed by another
thread leading to crashes.
Basically with distributed ec + disctributed replicate as cold, hot tiers. tier
sends a lookup which fails on ec. (By this time dict already contains ec
xattrs) After this lookup_everywhere code path is hit in tier which triggers
lookup on each of distribute's hash lookup but fails which leads to the cold,
hot dht's lookup_everywhere in two parallel epoll threads where in ec when it
tries to set trusted.ec.version/dirty/size as keys in the dictionary, the older
values against the same key get erased. While this erasing is going on if the
thread that is doing lookup on afr's subvolume accesses these keys either in
dict_copy_with_ref or client xlator trying to serialize, that can either lead
to crash or hang based on if the spin/mutex lock is called on invalid memory.
2) EC deletes GF_CONTENT_KEY from the dictionary, this may lead to extra reads
in case of lookup-everwhere for tiered volumes.
Fix:
Do dict_copy_with_ref() for the lookup-dictionary.
This is avoiding the problem and is not actually fixing the 1st problem.
2nd problem will be fixed.
Change-Id: I5427aa14c48cb7572977d4de9a28c5ffff2b4b95
BUG: 1315560
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13680
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 4b7180989b99c849408289324100ffd98dafe213
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Mar 10 15:53:23 2016 +0530
afr: Add more checks to check bricks being up
Change-Id: I27f1a1c2f28d129ef7fafc676a8d3d6b82bcf2e4
BUG: 1316462
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13667
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 75f5af55191628717e85207fb6cbbc9fda18ea6f
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Mar 11 14:01:31 2016 +0530
snapshot/cli: Keep the dict keys uniform
snapshot info was using a different dictionary key
as compared to other snapshot commands. This was
throwing a recurring error log in cli.log
Change-Id: I9eb9a4541c10a45ec7673a23c89c85a7dce9f3ec
BUG: 1316819
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13677
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 1b86e9de81c170e90fcef7243142400692d8b30a
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Feb 23 20:09:52 2016 +0530
Tier: Avoiding stale entries from causing demotion to stop
When the parent GFID is a stale entry, the lookup on this parent
fails and this in turn fails the demotion process.
This patch will make the stale entry error to be skipped.
Situation for pargfid to be stale:
Consider a folder from a tar file. Once the tar file is untared
the files in the tar-file will start to demote.
when the demotion is under progress, if we tend to delete
the actual folder, then the files under it which are
undergoing demotion will do a lookup on the parent which was
deleted and become stale entry. This stale entry fails the
Lookup and this will fail the demotion of the other files(not from
tar) that are supposed to be demoted.
Change-Id: I3d47c32c4077526d477a25912b0135bab98b23fc
BUG: 1311178
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/13501
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 724e58a614d32300641760695875f67c1b79e183
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Mar 11 16:20:01 2016 -0500
tests: return correct value from run_head_tests when no tests are found
Also added a diff filter to avoid listing deleted tests. Thanks to
Raghavendra Talur for the suggestion.
Change-Id: Ied2d552d227b55027211c07db6ee5dc20979596b
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: https://review.gluster.org/13686
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 792afb504b62b8c22cf605ed2db9b5b796f97cba
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 2 22:09:44 2016 +0530
cluster/afr: Choose local child as source if possible
It is better to choose local brick as source if possible to prevent
over the wire read thus saving on bandwidth. Also changed code to not
attempt data-heal if 'source' is selected as arbiter.
Change-Id: I9a328d0198422280b13a30ab99545370a301dfea
BUG: 1314150
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13585
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Krutika Dhananjay <kdhananj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e00e19a8ddb225fd404a764be8808d7269f89766
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Mar 8 15:44:04 2016 +0530
features/shard: Implement discard fop
Change-Id: Ia5bd8d36b21a586df6556fbec3474892d5871229
BUG: 1261841
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13657
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit b99e3fbb9dcd8e3eef23548044c9614c732a2d18
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 10 10:50:59 2016 -0500
tests: run tests from the most recent commit first
Change-Id: If11f552543bf0f1f0e9756e9f2237b72e44b7aed
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13439
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit bb9eaaf61f83573fb5cd3c5387be340bd51c6fc4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Mar 5 21:41:33 2016 +0530
tests: Use force_umount instead of umount
umount leads to spurious failures with "mount is busy" kind of errors
at the time of umount. Use 'force_umount' instead.
BUG: 1310171
Change-Id: I5a5579288f002de14effc00b793143fef86eb828
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13611
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit e2bcbc1983fe3ecd2f22ef5de08b8df1bef08031
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Mar 10 14:32:03 2016 +0530
snapshot: Use svc->manager during glusterd restart
Instead of using svc->start, we should use svc->manager
as it takes care of initializing svc too, and both starts
and stops snapd as needed.
Change-Id: I3d3afdf4c4203bee3b790a017b820339fd376af6
BUG: 1316437
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13665
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit a8ea13679192b411897d7376228d5a73e20d8a5b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 10 08:56:33 2016 -0500
fdl: fix race during initialization
There was a race between fdl_worker starting to run and setting
this->private in fdl_init. This should never happen on a
multiprocessor, since the new thread should start on a different core
and creating it there should take many times longer than getting from
pthread_create to the end of fdl_init on the original core. The only
way it seems likely is if the new thread is started on the same core
that's already in fdl_init, and the new thread preempts the old, which
many would consider broken . . . but there are plenty of broken thread
implementations and it's hardly surprising that glibc has one. Still,
it's a race and it did show up in regression tests a few times, so it
needs to be fixed.
Change-Id: Ifa5b0ae1ec111860f0d3f55a98aa2b8f2cef84ca
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13674
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b00db0895dc375f91313dbf8ff1f2052d23e91dd
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Feb 29 14:43:58 2016 +0530
protocol client/server: Fix client-server handshake
Problem:
Currently on a successful connection between protocol
server and client, the protocol client initiates a
CHILD_UP event in the client stack. At this point in
time, only the connection between server and client is
established, and there is no guarantee that the server
side stack is ready to serve requests.
It works fine now, as most server side translators are
not dependent on any other factors, before being able
to serve requests today and hence they are up by the time
the client stack translators receive the CHILD_UP (initiated
by client handshake).
The gap here is exposed when certain server side translators
like NSR-Server for example, have a couple of protocol clients
as their child(connecting them to other bricks), and they
can't really serve requests till a quorum of their children are
up. Hence these translators should defer sending CHILD_UP
till they have enough children up, and the same needs to be
propagated to the client stack translators.
Fix:
Maintain a child_up variable in both the protocol client
and protocol server translators. The protocol server should
update this value based on the CHILD_UP and CHILD_DOWN
events it receives from the translators below it. On receiving
such an event it should forward that event to the client.
The protocol client on receiving such an event should forward
it up the client stack, thereby letting the client translators
correctly know that the server is up and ready to serve.
The clients connecting later(long after a server has initialized
and processed it's CHILD_UP events), will receive a child_up status
as part of the handshake, and based on the status of the server's
child_up, can either propagate a CHILD_UP event or defer it.
Change-Id: I0807141e62118d8de9d9cde57a53a607be44a0e0
BUG: 1312845
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13549
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a8bc2acfb8f067f7838cf643076e318205ff035d
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Mar 8 17:22:35 2016 +0530
Tier: displaying status only one the nodes running tierd
When tier status is given on a cluster where one node doesn't
have tierd running, the status is shown as not started.
The status of the node without tierd should not be displayed.
This patch will skip if the current node if the status is not
started
Change-Id: Ibeb39f13133f94a5869b020c5ccd9bd6992323f1
BUG: 1315666
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/13647
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit d3844c92cf9919a1e9df4647cbb47c36ccb9dc18
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Thu Mar 10 07:51:48 2016 +0530
glusterd: fixing few memory leak in glusterd
While freeing memory currently glusterd is not freeing correct
memory. this might result in some serious situation.
With this fix glusterd will free correct memory location.
Change-Id: Ide9c33a2ec5822b560e9e2dfcb6a0b442fc97047
BUG: 1287517
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/13660
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 60f7e7b27664684c8afe13a5c257eaa2489a2ed9
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Mar 7 09:17:48 2016 -0500
nsr-server: fix (?) ENODATA problem on FreeBSD
Change-Id: I5f16a04e34a37e1f4cef38d75aff3479429473e3
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13625
Tested-by: Avra Sengupta <asengupt@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit acbd340537fc9ddb189baba0f3e9dc1c93a802c6
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Feb 9 16:40:36 2016 +0530
tests, shard: fallocate tests refactor
Change-Id: I3f275185f4dcb1939e8074851c8f140c5e40b28d
BUG: 1261841
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13405
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 8cd83eb1bf84df78c5a61dad334c6b4fce3d7773
Author: vmallika <vmallika@redhat.com>
Date: Tue Feb 2 14:34:19 2016 +0530
gluster/uss: change ctime attr of a dir when USS enabled
Consider a testcase:
mount -t nfs host1:/vol1 /mnt
ls /mnt
ls /mnt/.snaps (As expected this fails)
gluster volume set vol1 features.uss enable
Now `ls /mnt/.snaps` should work, but fails with No such file or
directory.
This is because NFS client and Kernel VFS caches the list of files in a
directory.
This cache is updated if there are any changes in the directory attributes.
This patch solves the problem by changing ctime attribute when USS is
enabled
Change-Id: I48b284100d0589f1c0285782a1302080c15d4e1f
BUG: 1163416
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9106
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 5b424b1fb5fcc0de5044f4174aa5d5126be64054
Author: vmallika <vmallika@redhat.com>
Date: Wed Feb 10 06:39:22 2016 +0530
uss/gluster: generate gfid for snapshot files from snapname and gfid
If 'a' and 'b' are hardlinks, we need to generate a virtual
gfid for these files so that the inode number for 'a' and 'b'
are same.
Generate gfid as below:
gfid_of_a = MD5(snapname + back_end_gfid(a))
if '/dir1/a' and '/dir2/b' are hardlinks, then inode number should be
same for
all below files:
/mnt/.snaps/snap1/dir1/a
/mnt/.snaps/snap1/dir2/b
/mnt/dir1/.snaps/snap1/a
/mnt/dir2/.snaps/snap1/b
Change-Id: Ifda793455610e554f3f1e4cbb90d44c02cda4b0f
BUG: 1171703
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9255
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit c37311efbe28fa0d343499849e30ee0c0d7ae204
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Mar 2 15:19:30 2016 +0530
glusterd: Always copy old brick ports when importing
When an updated volinfo is imported in, the brick ports from the old
volinfo should be always copied.
Earlier, this was being done only if the old volinfo was stopped and
new volinfo was started. This could lead to brick ports chaging when the
following sequence of steps happened.
- A volume is stopped
- GlusterD is stopped on a peer
- The stopped volume is started
- The stopped GlusterD is started
This sequence would lead to bricks on the peer with re-started GlusterD
to get new ports, which could break firewall rules and could prevent
client access. This sequence could be hit when enabling management
encryption in a Gluster trusted storage pool.
Change-Id: I808ad478038d12ed2b19752511bdd7aa6f663bfc
BUG: 1313628
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/13578
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 1bdb0c1990b3a8572856edc2c7d743f4b5d196e7
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Feb 8 12:13:54 2016 +0530
tests: Add mechanism for disabled tests
Requirements:
Should be able to skip tests from run-tests.sh run.
Should be granular enough to disable on subset of OSes.
Solution:
Tests can have special comment lines with some comma separated values
within them.
Key names used to determine test status are
G_TESTDEF_TEST_STATUS_CENTOS6
G_TESTDEF_TEST_STATUS_NETBSD7
Some examples:
G_TESTDEF_TEST_STATUS_CENTOS6=BAD_TEST,BUG=123456
G_TESTDEF_TEST_STATUS_NETBSD7=KNOWN_ISSUE,BUG=4444444
G_TESTDEF_TEST_STATUS_CENTOS6=BAD_TEST,BUG=123456;555555
You can change status of test to enabled or delete the line only if all the
bugs are closed or modified or if the patch fixes it.
Change-Id: Idee21fecaa5837fd4bd06e613f5c07a024f7b0c2
BUG: 1295704
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13393
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 1fd22968878302463044908a13ab5b2b0492746d
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Mar 9 04:05:20 2016 -0500
fuse: Address the review comments in the backport
Backport @ http://review.gluster.org/#/c/13626/3
Fix a typo error, consolidate the selinux and capability
check in getxattr and setxattr.
Change-Id: I4303de3d4dd00853169b07577311e03cbb912ed7
BUG: 1316327
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/13653
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Vijay Bellur <vbellur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1867551b9fc87ac381dc0736a5ff5474f85ee0c2
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Mar 7 15:01:39 2016 -0500
features/bit-rot-stub: get frame->local before unwinding
In bit-rot-stub, if unlink fails, then it was unwinding
directly. Then it was trying to cleanup local. But local
would be NULL, since it was unwinding directly without getting
the value of frame->local. The NULL cleanup of local was
causing the brick process to crash.
Change-Id: I8544ba73b2e8dc0c50b1a53ff8027d85588d087b
BUG: 1315465
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/13628
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 5062e56c937b2f22eedf8b20e5b4dfd80326b6b7
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Feb 29 14:05:54 2016 +0530
geo-rep: Fix Entry Creation issue with non root UID/GID
During entry_ops RENAME Geo-rep sends stat info along with the
recorded info from Changelog. In Slave side if Source file exists
Geo-rep renames to Target file by calling os.rename. If source file
does not exists, it tries to create Target file directly using available
stat info from Master. If UID and GID are different in Master for that
file then stat info will have different UID/GID during Create. Geo-rep
gets EACCES when it tries to create a new entry using gfid-access with
different UID/GID.
With this patch, Entry creation with different UID/GID is split into two
operations. Create Entry with UID:0 and GID:0 and then set UID/GID.
Change-Id: I4987e3a205d8513c06fa66198cde145a87003a01
BUG: 1313303
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/13542
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 8641bde43aa8da65e6a4e838a69cb93cb512a66b
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Jan 6 21:23:51 2016 +0530
geo-rep: hard-link rename issues on changelog replay
Problem:
LINK + RENAME changelog when replayed after worker restart causes stale
hard-links to persist since VFS returns success for RENAME if hard-links
point to same inode.
Solution:
Worker detects RENAME being issued on hard-links to the same inode and
unlinks the source file-name. Conditionally rename by verifying that the
source gfid matches with the on-disk gfid on the slave.
Change-Id: I3ff1c30ef79e77503c8b246d46dab8ac3059ccf2
BUG: 1296174
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/13189
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 2ff8272f43b47acadc5f1e1df70c0b664db59786
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Sat Mar 5 16:06:18 2016 -0500
packaging: rpm scriptlet cleanup, handle -p /sbin/ldconfig
The RPM documention indicates that during an rpm install or erase, the
script(lets): %post, %preun, and %postun (and %pre, %build, %install,
etc.) are copied to a temp file, and then the temp file is run as a
(/bin/sh or bash) script.
Unfortunately the documentation is not clear about how rpmbuild and/or
rpm determine where the end of any scriptlet is when it is copied to
the file.
Most things in the glusterfs.spec work correctly as is. These are the
%preun, %post, and %postun scriptlets that are "closed" by a following
%preun, %post, and %postun, or poetentially another scriptlet, e.g.
%file.
The ones that don't work correctly (only one actually) are those where
there is a comment in the spec file before it is closed by another
scriptlet. Further complicating things is that the type of scriptlet
affects what rpm does and what `rpm -qp --scripts ...` shows.
The specific one that didn't work was the "%postun libs" scriptlet. It
is followed by a comment before being "closed" by the %files section (or
scriptlet). It can be written two ways: "%postun libs\n/sbin/ldconfig"
or "%postun libs -p /sbin/ldconfig" Either way it's written, `rpm -qp
--scripts glusterfs-libs...` will include the comment lines between the
%postun libs line and the following %files line.
But the way rpm executes these depends on how they're written. If
written as "%postun libs\n/sbin/ldconfig" rpm will simply run
/sbin/ldconfig with no command line options, i.e.
execve ("/sbin/ldconfig", [ "/sbin/ldconfig" ], [ ]);
But when written as "%postun libs -p /sbin/ldconfig", it will copy
the comment lines to a temp file, and pass the temp file name and "1"
as (command line) parameters, i.e.
execve ("/sbin/ldconfig", [ "/sbin/ldconfig", "/tmp/tmpXXXXXX", "1" ],
[ ]);
Which results in ldconfig exiting with an error. (Remember, both ways show
the comment in `rpm -qp --scripts ...`)
(Note though, that the similar "%postun api -p /sbin/ldconfig" is run
correctly, because it is "closed" by the following "%postun server"
scriptlet.)
Finally, through trial and error, it appears that rpm can be tricked with
a hack, and "closure" of the scriptlet forcedlike this:
%postun libs -p /sbin/ldconfig
%if ( 0%{?_undocumented_hack_closes_scriptlets} )
%postun
%endif
in which case ldconfig appears to run correctly. Note also that here too
the comment will be included in the output of `rpm -qp --scripts ...`
But that's very ugly hack.
Change-Id: I587a490ddcdf47d01605479bc8ef8b0e439108fb
BUG: 1315024
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13613
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 06eae0473878f49f79d8c7baeae307d603828581
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Feb 25 18:27:09 2016 +0530
features/shard: Return ENOTSUP for unsupported fallocate flags
Basis: http://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05101.html
Change-Id: I5bf80b6e8caed3d7f136fc57e16abfb28869e009
BUG: 1261841
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13523
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cae33d9ed13c0d8e3346d4987cf735957076eaa9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Mar 8 10:21:14 2016 +0530
tests: Move tier-file-create.t to bad tests
Change-Id: Iaddb244699b0e2647a67a75f257e4c47e0e69e0d
BUG: 1315560
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13632
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 62bca2d98bb80b1fdd8894312a98d83cd6bb36d9
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Mar 3 23:17:17 2016 +0530
afr: misc performance improvements
1. In afr_getxattr_cbk, consider the errno value before blindly
launching an inode refresh and a subsequent retry on other children.
2. We want to accuse small files only when we know for sure that there is no
IO happening on that inode. Otherwise, the ia_sizes obtained in the
post-inode-refresh replies may mismatch due to a race between
inode-refresh and ongoing writes, causing spurious heal launches.
Change-Id: Ife180f4fa5e584808c1077aacdc2423897675d33
BUG: 1309462
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13595
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit ca4427bc50b6dd7484e41f3742c5016fa33b7b5e
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu Feb 18 11:21:12 2016 -0500
qemu-block: deprecated/defunct, remove from tree
qemu-block xlator is not used by anyone, or so I'm told.
It's also substantially out of date. There's little reason to keep
it in our sources. (And FedoraProject doesn't like bundled software
either.)
Change-Id: I1112a5fe5278b7899484eebc2e74fca713346b75
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13629
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c1dc0f7e98ba679c9052fddaccfb0f5e4830a028
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jan 21 14:48:34 2016 +0530
glusterd: volume get should pick options from priv->opts too
As of now volume get was not looking for all the global options maintained in
option dictionary in glusterd_conf_t. This patch includes the same.
Change-Id: Ib05259a2dcacc4a712cae4217fe4a6553b61da56
BUG: 1300596
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13272
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 86c11bf3d2606f7ef501ecd2040e6378ad09aef0
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Mar 8 13:41:58 2016 +0530
geo-rep: Fix CPU utilization 100% with Popen
Errorstore is maintained by Geo-rep to collect errors from
the child processes opened using Popen. If Popen.communicate
is used then it closes stderr. When stderr is not available
errorstore.tailer() will enter into infinite loop without gap.
With this patch, sleep time added when stderr of Child process
is already closed.
Change-Id: Ic36aabd6de35b259467d0bab7952468432867a94
BUG: 1315601
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/13637
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit b09622df64bb9a4e634a83f3d7a1c60171d99d7f
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Mar 2 11:40:24 2016 +0530
rpc: Connect back only if rpc is not disabled
This is to fix regression caused by below patch -
http://review.gluster.org/#/c/13456/
As discussed over http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/14284,
patch #13456 caused a regression where in if there are any pending
rpc invocations, we end up accessing freed object. This patch
fixes it by allowing reconnect during rpc submit only if rpc
is not disabled.
Change-Id: I4ef4dd52bd42368bb89129f98bc973e46c6a39f4
BUG: 1295107
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/13592
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit bb0e3deb4e370a2876fbd1b078769e6e37911a8a
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Dec 9 17:09:42 2015 +0530
tools/glusterfind: Do not fail cleanup script on volume delete
If glusterfind dir is not present inside GLUSTERD_WORKDIR, then
cleanup script Post Volume delete was failing. This patch safely
handles the absence of glusterfind directory in GLUSTERD_WORKDIR
BUG: 1289935
Change-Id: I9f7e6035e3dc6079927803df942b0f921218c79a
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/12923
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 986ba2b0866b077023af18f5241187473ed58c7c
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Mon Feb 29 15:48:58 2016 +0530
glusterd:upon re-peer probe glusterd should not return response to CLI two times
If a node N1 and node N2 is part of the cluster and a node N2 try to reprobe
node N1 when N1 is disconnected by any means (for eg: either server is down
or glusterd is not running or there is a network outage, or firewall is
blocking port number 24007 on which glusterd listen, etc.), then glusterd
trying to send back two responses to CLI resulting into a double free and
a glusterd crash.
With this fix glusterd will send response to cli only once and prevent
glusterd crash.
Note: glusterd was crashing only when user has done first peer probe with
hostname and re-probe with ip-address or vice-versa.
Change-Id: I92012b147091cf9129f1fbc17834b3f4d7cb46a0
BUG: 1310677
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/13546
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 62a5191d0583acc238523cfa4b5bfdd70faad80b
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Feb 26 06:42:14 2016 -0500
fuse: Add a new mount option capability
Originally all security.* xattrs were forbidden if selinux is disabled,
which was causing Samba's acl_xattr module to not work, as it would
store the NTACL in security.NTACL. To fix this http://review.gluster.org/#/c/12826/
was sent, which forbid only security.selinux. This opened up a getxattr
call on security.capability before every write fop and others.
Capabilities can be used without selinux, hence if selinux is disabled,
security.capability cannot be forbidden. Hence adding a new mount
option called capability.
Only when "--capability" or "--selinux" mount option is used,
security.capability is sent to the brick, else it is forbidden.
Change-Id: I77f60e0fb541deaa416159e45c78dd2ae653105e
BUG: 1309462
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/13540
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 4fbbdba2374d2c5d18f8d3480751084a9902657d
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Mon Mar 7 13:37:31 2016 +0530
glusterd: avoid setting op-version lower than current cluster op-version
Currently glusterd allow setting a cluster op-version which is lower than
current cluster op-version. Though command is successful but it does not
set that lower op-version.
With this fix it will return error message "Required op-version
(requested op-version) should not be lower than current cluster
op-version (current cluster op-version)"
Change-Id: Ia5b61858ee22a5a26721ec12ab12ff48e1a40c82
BUG: 1315186
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/13622
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 197ddc4c53b849c7f9b3d321e4b38bfa5b609b26
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Sun Mar 6 08:32:52 2016 -0500
ganesha: coverity fix in glusterd-ganesha.c
CID 1351698
Allocating buffer of size stat.st_size) to read lines from the file
without an overrrun feels like a bit of a hack. While it's extremely
unlikely that the file would ever be more than a thousand bytes long,
a) we don't want to use bad patterns (and set bad examples or
precedents for elsewhere in the source), and b) what if somehow the
file did become "large." We just don't want to ever risk allocating
huge amounts of memory by accident.
And all the superfluous logic to copy the resulting string? We have
gf_strdup() for that.
And a clean coverity. See following gerrit review comments for the URL.
Change-Id: I5860d6995d0eed06667fd2369df6be53ccff6ceb
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13614
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c66dc2858bb18020ebc804f65683757692433106
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu Feb 18 11:21:12 2016 -0500
qemu-block: deprecated/defunct, remove from tree
qemu-block xlator is not used by anyone, or so I'm told.
It's also substantially out of date. There's little reason to keep
it in our sources. (And FedoraProject doesn't like bundled software
either.)
Change-Id: I4aeb2fdfd962ec6d93de6bae126874121272220a
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13473
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d5ce0c033533d69cf0ac2b1d16143174c75bf865
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Feb 25 18:45:20 2016 +0530
features/index: Get gfid type in readdir
Change-Id: I2a6174e1af70a94a52b0b735fd8504800a7ea173
BUG: 1313135
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13553
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 73ea0e00b8ca9e4ac465f51e74676f59ef05866c
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu Mar 3 14:49:04 2016 -0500
packaging: %post server isn't quiet
firewall-cmd prints out "success" during install
Change-Id: I9b0d3d38170d2fc41fefd6ef555a958c5eeb39aa
BUG: 1312897
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13596
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit cbce18e200fc71b5578c9b4b3c6f18069601ecb7
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Feb 29 05:16:50 2016 +0000
afr: do not set arbiter as a readable subvol in inode context
Problem:
If afr_lookup_done() or afr_read_subvol_select_by_policy() chooses the
arbiter brick to serve the stat() data, file size will be reported as
zero from the mount, despite other data bricks being available. This can
break programs like tar which use the stat info to decide how much to read.
Fix:
In the inode-context, mark arbiter as a non-readable subvol for both
data and metadata.
It it to be noted that by making this fix, we are *not* going to serve
metadata FOPS anymore from the arbiter brick despite the brick storing
the metadata. It makes sense to do this because the ever increasing
over-loaded FOPs (getxattr returning stat data etc.) and compound FOPS
in gluster will otherwise make it difficult to add checks in code to
handle corner cases.
Change-Id: Ic60b25d77fd05e0897481b7fcb3716d4f2101001
BUG: 1310171
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reported-by: Mat Clayton <mat@mixcloud.com>
Reviewed-on: http://review.gluster.org/13539
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 44f3a7165547766487c7b51050b50800a2fa8d82
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Mar 2 11:35:44 2016 +0100
tests: Fix spurious failure of ec-read-policy.t
Change-Id: I5297e24dd10cbfbcd671fe630ae3e960b9daa8f8
BUG: 1313775
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/13575
Tested-by: Raghavendra Talur <rtalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 602341858f6b403ab91899612b73f433e5193f1d
Author: Anuradha Talur <atalur@redhat.com>
Date: Fri Mar 4 01:41:09 2016 +0530
Remove replace-brick-self-heal.t from bad-tests
Unable to recreate any failures even after running
the test for more than an hour in a loop.
Change-Id: Id1c7e60d39bce6b312dbb4ea0975079348bb1649
BUG: 1314549
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/13599
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit e74d4964654820427a402af6ba21cf580b68f7c0
Author: vmallika <vmallika@redhat.com>
Date: Tue Mar 1 16:40:35 2016 +0530
quota: reduce latency for testcase ./tests/bugs/quota/bug-1293601.t
Currently test-case './tests/bugs/quota/bug-1293601.t' runs quota enable
and disable 10 times each, which take a long time.
This is not a real use-case and it is enough to test once.
Change-Id: Ic282d66438f89721f3c392929047ba42b85ad155
BUG: 1313300
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13556
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 46e30ccbef300d2753f9d9cb2f7af9921aed11fe
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Feb 25 14:42:48 2016 +0530
glusterd: reject peer probe from a reinstalled node
In a cluster if a node (say N1) goes through a OS reinstallation then probing
some other node in the cluster from N1 doesn't fail as in
gd_validate_mgmt_hndsk_req () uuid & hostname checks are done separately but
there should be one more check where both the conditions should meet.
Steps to create the problem
- N1 probes N2
- bring down glusterd instance on N2
- remove /var/lib/glusterd/* from N2
- restart glusterd instance on N2
- execute gluster peer probe N1 from N2
Validations in gd_validate_mgmt_hndsk_req () has been improved to handle this
special case
Change-Id: I3ba5d8e243bae07a7a6743d01b019e7014d39171
BUG: 1311874
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13519
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 10ad484158a1a9563657d40528f93947b2363aa5
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Mar 1 13:04:03 2016 +0530
socket: Launch socket_poller only if connect succeeded
For an encrypted connection, sockect_connect() used to launch
socket_poller() in it's own thread (ON by default), even if the connect
failed. This would cause two unrefs to be done on the transport, once in
socket_poller() and once in socket_connect(), causing the transport to
be freed and cleaned up. This would cause further reconnect attempts
from failing as the transport wouldn't be available.
By starting socket_poller() only if connect succeeded, this is avoided.
Change-Id: Ie22090dbb1833bdd0f636a76cb3935d766711917
BUG: 1313206
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/13554
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1aa57e53be45d8467f94fcc6841e2e6dc4e85e83
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Mon Feb 22 08:31:39 2016 -0500
packaging: gratuitous dependencies on rsyslog-mm{count,jsonparse}
remove unnecessary dependencies.
GlusterFS only ships example config files, and the system may not
actually be using rsyslog at all. (It may only be RHEL5 that uses
rsyslog "out of the box.")
Also, several example config files (including gluster-rsyslog-7.2.conf,
gluster-rsyslog-5.8.conf, logger.conf.example) are already installed in
/etc/glusterfs/ by `make install` in the extras directory and are
included in the -server RPM. Installing them (anywhere) in the spec
file is redundant. Furthermore, a query in the fedora-devel mailing
list about the preferred location for these files went unanswered.
Change-Id: I07bd6a8714a05e8b91adc03f101032c1593da360
BUG: 1310437
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13485
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ca42a2a229de0e49e46aabe77fe1a59dd9bd7f2f
Author: vmallika <vmallika@redhat.com>
Date: Thu Mar 3 11:29:56 2016 +0530
MAINTAINERS: add maintainers for quota
Change-Id: I47faaca0f66b8e566ced72646ee6ff8e7cad90d8
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13586
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 19ef46be6e2a4751cd8aa3f845ba2a86b0836860
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Mar 3 16:09:27 2016 +0530
tier: Fix unused-but-set-variable warning
Change-Id: Ie5eaf1075b1c9c29dd7d85bf7b61b22e1fbce422
BUG: 1314291
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13591
Reviewed-by: hari gowtham <hari.gowtham005@gmail.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 8cf79a8e7ceb287f3ed5fdb0b1fb0bc176400489
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Jan 12 16:58:57 2016 +0530
tests/quota : improving tests for quota
tests/basic/quota.t includes all the basic test that
needs to be tested for quota. In most of the other
tests specific to bugs(tests/bugs/quota/*), tests
such as creating and starting volume, enabling quota,
setting limit, writing data, doing list have been done
which is essential to write a individual quota test
file, but, if the specific bug just needs to test
*few* particular cases, I have moved those tests
under tests/basic itself to speedup the regressions.
Basics of inode-quota and it's enforcing, renaming
with quota are basic tests and is hence moved under
tests/basic folder.
In other files, I have removed tests which are not
needed, such as 'pidof glusterd' or checking for
'gluster volume info' or if there are any test which
is already being tested under tests/basic and is being
written again.
Change-Id: Iefd6d9529246d59829cc5bf02687a1861d8462a8
BUG: 1294826
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/13216
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 15f131f22d3a3da0c3b414f8ce63286283a5709a
Author: hari <hgowtham@redhat.com>
Date: Fri Feb 19 13:43:48 2016 +0530
Tier: making detach start fail when brick on hot tier is down
Currently detach tier start happens even when a hot brick is down
this might lead to data loss.
This patch prevents the detach tier start from being executed
successfully if a brick in hot tier is down
Change-Id: I3b6047a44bd01b8a6887d41f799f64de6bf075ef
BUG: 1309999
Signed-off-by: hari <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/13474
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b31bae0dac26cbb916921b32bf8a235a11ed6483
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Jun 11 09:15:17 2015 +0530
MAINTAINERS: Geo-replication maintainer addition
Change-Id: I231e075370c7f883090ecf5792e6f7633773f6c9
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11171
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit bddc395ba5ad2ec52cd2e12af69b51cc88844474
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Mar 3 12:24:49 2016 +0530
glusterd: Avoid ret value of glusterd_resolve_brick in retreive brick path
In glusterd_store_retrieve_bricks() commit a60c39d introduced
glusterd_resolve_brick () call to resolve all the bricks which is incorrect
since by the time peerinfo list may not be constructed. The requirement here was
to get the local brick's uuid populated and match that with MY_UUID.
Fix is to overlook the return code of glusterd_resolve_brick() to ensure that
the failure in resolving non local bricks are genuine and expected.
Change-Id: I22822ae5b4e96fe4eacd50ea5c41e58061557106
BUG: 1313901
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13588
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit d159a353aef9652943a4fb5193c4426ced26dcc5
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Mar 1 17:31:11 2016 +0530
mgmt/glusterd: Show features.shard option in volume-set-help output
Change-Id: If9004c4374b92d058cf56add50a91ecad43a2840
BUG: 1261773
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13565
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit dbbd679ab8e4c14ddd927fd85999e88fcfb67e88
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Mar 1 16:23:22 2016 +0530
features/shard: Fix NULL-dereference when fsync fails
Change-Id: I4e51961c158c3b5c78791846ca7f0f6cf7fb5c4a
BUG: 1313293
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13562
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit a21c483308d3a3ecb3ce62849fa2b25eaac594e5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Feb 27 23:08:06 2016 +0530
cluster/afr: Don't delete gfid-req from lookup request
Problem:
Afr does dict_ref of the xattr_req that comes to it and deletes "gfid-req" key.
Dht uses same dict to send lookup to other subvolumes. So in case of
directories and more than 1 dht subvolumes, second subvolume till the last
subvolume won't get a lookup request with "gfid-req". So gfid reset never
happens on the directories in distributed replicate subvolume for 2nd till last
subvolumes.
Fix:
Make a copy of lookup xattr request.
Also fixed replies_wipe possibly resetting gfid to NULL gfid
BUG: 1312816
Change-Id: Ic16260e5a4664837d069c1dc05b9e96ca05bda88
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13545
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 1bbb3001c3c38737b38fb95f4581ff915853669a
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Sun Feb 28 16:34:50 2016 +0530
cli/tests: disable tiering on NetBSD
As proposed in the following email:
http://www.gluster.org/pipermail/gluster-devel/2016-February/048464.html
Short version: tiering tests on NetBSD are failing often enough to
impede other development, and also to cast doubt on whether tiering even
works on that platform. The most effective way to satisfy both
developers' and users' interests is to disable tiering on NetBSD until
such time as someone becomes available to resolve these problems another
way.
Change-Id: I7375527c339e2650a7e8e900a0d0572013213544
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13535
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 46ba1addfe0113774e9a8497a203172fb8605327
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Jan 10 09:19:34 2016 +0530
afr: Add throttled background client-side heals
If a heal is needed after inode refresh (lookup, read_txn), launch it in
the background instead of blocking the fop (that triggered refresh) until the
heal happens.
afr_replies_interpret() is modified such that the heal is
launched only if atleast one sink brick is up.
Max. no of heals that can happen in parallel is configurable via the
'background-self-heal-count' volume option. Any number greater than that
is put in a wait queue whose length is configurable via
'heal-wait-queue-leng' volume option. If the wait queue is also full,
further heals will be ignored.
Default values: background-self-heal-count=8, heal-wait-queue-leng=128
Change-Id: I1d4a52814cdfd43d90591b6d2ad7b6219937ce70
BUG: 1297172
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13207
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 217968fefc1dde9248a8d0915ae40c1eca153fa0
Author: Jiffin Tony Thottan <jthottan@gmail.com>
Date: Fri Jan 22 17:47:07 2016 +0530
NFS-Ganesha : scripts related changes for supporting multiple export entires for volume
Previously script such as dbus-send.sh, ganesha-ha.sh can handle only one EXPORT{} block.
Change-Id: I2286af4877f96f4334435818f67beea87efa2b1f
BUG: 1275966
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/13283
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 29e34fe925ba02992383824d5b623dd48e44f0f9
Author: Cedric Buissart <cbuissar@redhat.com>
Date: Wed Dec 23 17:29:50 2015 +0100
gluster man page: adding geo-replication chapter
geo-replication options are currently missing from gluster(8) man page.
Change-Id: I5d24de856be264e63d3ff49f9b82346476f20473
BUG: 1293950
Signed-off-by: Cedric Buissart <cbuissar@redhat.com>
Reviewed-on: http://review.gluster.org/13073
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Aravinda VK <avishwan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a38721d701873e4c56e2c4a01e0451db9eb2820a
Author: Milind Changire <mchangir@redhat.com>
Date: Fri Jan 29 13:53:07 2016 +0530
georep: avoid creating multiple entries with same gfid
Problem:
CREATE + RENAME changelogs replayed by geo-replication cause
stale old-name entries with same gfid on slave nodes.
A gfid is a unique key in the file-system and should not be
assigned to multiple entries.
Solution:
Create entry on slave only if lstat(gfid) at aux-mount fails.
This applies to files as well as directories.
Change-Id: Ice3340f4ae1251c2dcef024a2388c4d33b5d4919
BUG: 1296206
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/13316
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 43de99abb63d552eefb4eca03238247695f2db15
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Tue Feb 9 16:44:03 2016 +0530
geo-rep: Fix invalid disk size in gverify.sh
Problem:
Due to the wrong interpretation of disk size, gverify.sh script
exits in between with error "integer expression expected".
This error can be observed, only if gverify.sh is run standalone.
Solution:
Fix the interpretation of disk size.
Also, verify that master and slave's gluster version are same.
Change-Id: Id095dfffd07a93a535a380f617ad215230979870
BUG: 1305839
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/13407
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit e6f581d032eef0e7307b3e8cbda9fb8e78b0629a
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Feb 15 10:59:29 2016 +0100
cluster/ec: Fix invalid config check for directories
The trusted.ec.config xattr is not defined for directories. However
sometimes it could be requested because the inode type of a directory
can temporarily be IA_INVAL.
Requesting such xattr using the xattrop fop when it doesn't exist,
returns a config value full of 0's, which is invalid and caused some
fops to fail.
This patch filters out this case by ignoring config xattr == 0.
Change-Id: Ied51c35b313ea8c3eeae27812f9bae61d3808e92
BUG: 1293223
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/13446
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 356507e948aee848b70a44d7f9b707a73f983a9d
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Feb 17 15:50:05 2016 +0530
features/trash: Retain file permissions during truncate
Consider the situation where directory path for a truncated
file does not exists under trash directory. In this scenario
after creating the required path we failed to create the
orginal file with proper permissions. Eventhough we try to
fetch permissions from local->origpath, it was never filled
with required value in truncate and ftruncate call paths.
This change will copy original location to local->origpath
inside both fop handling functions.
Change-Id: If5930b6d368d08e58f04db999f3f9edb9250bcb9
BUG: 1309342
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/13461
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 608ef1f8e62bedd2e06ea2833e7604555d264a01
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Feb 16 20:22:36 2016 -0500
features/bitrot: do not remove the quarantine handle in forget
If an object is marked as bad, then an entry is corresponding to the
bad object is created in the .glusterfs/quarantine directory to help
scrub status. The entry name is the gfid of the corrupted object.
The quarantine handle is removed in below 2 cases.
1) When protocol/server revceives the -ve lookup on an entry whose inode
is there in the inode table (it can happen when the corrupted object
is deleted directly from the backend for recovery purpose) it sends a
forget on the inode and bit-rot-stub removes the quarantine handle in
upon getting the forget.
refer to the below commit
f853ed9c61bf65cb39f859470a8ffe8973818868:
http://review.gluster.org/12743)
2) When bit-rot-stub itself realizes that lookup on a corrupted object
has failed with ENOENT.
But with step1, there is a problem when the bit-rot-stub receives forget
due to lru limit exceeding in the inode table. In such cases, though the
corrupted object is not deleted (either from the mount point or from the
backend), the handle in the quarantine directory is removed and that object
is not shown in the bad objects list in the scrub status command.
So it is better to follow only 2nd step (i.e. bit-rot-stub removing the handle
from the quarantine directory in -ve lookups). Also the handle has to be removed
when a corrupted object is unlinked from the mount point itself.
Change-Id: Ibc3bbaf4bc8a5f8986085e87b729ab912cbf8cf9
BUG: 1308961
Original author: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/13472
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit f9b347ac35ba772602d18ac7626f9d7346fec5b8
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Feb 29 15:27:31 2016 +0530
tests: fix bug-860663.t
Three changes:
* Removed the second round of file creation, which wasn't really
testing anything useful and was causing spurious failures. Under the
conditions we've set up, the rational expectation would be for the
file-creation helper program to succeed, but the test expected it to
fail.
* Removed Yet Another Unnecessary Sleep.
* Reduced the number of files from 10K to 1K. That's more than
sufficient to test what we're trying to test, and saves significant
time.
Change-Id: If1c623853745ab42ce7d058d1009bbe1dcc1e985
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/13544
Reviewed-by: Joseph Fernandes
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 11b1e496215a6e507e1a92f0a2f8a1b6c9d0a8cb
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jan 19 10:45:22 2016 +0530
glusterd: use string comparison for realpath checks in glusterd_is_brickpath_available
glusterd_is_brickpath_available () used to call realpath() for checking the
whether the new brick path matches with the existing ones. The problem with this
is if the underlying file system is bad for any one of the existing bricks then
realpath() would fail and we wouldn't allow to create the new brick even if it
should be allowed.
Fix is to use string comparison with having a new field real_path in brickinfo
to store the absolute path
Change-Id: I1250ea5345f00fca0f6128056ebd08750d604f0a
BUG: 1299710
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13258
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a6b5ea7bb6d943f68ed2dd1a67169d38d305cfdf
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Feb 25 21:30:33 2016 +0530
protocol/client: Don't change op_ret when xdata_rsp is present
Change-Id: Ia69cc420ad7b5766d513ea2715bbca50d8d57132
BUG: 1312226
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13530
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 4e46cd27e4f6686dfd8e9b822f834fba3eed5dee
Author: hari <hgowtham@redhat.com>
Date: Thu Feb 18 16:58:28 2016 +0530
TIER: avoid reset of ctr-enabled during the issue of gluster v reset
Change-Id: I3f5f29378c8c55cc07a83f5fc1506c4d7e9ac09d
BUG: 1309659
Signed-off-by: hari <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/13470
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 6a7b14ee0bd1b79d5474659050ee984b8692845b
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Jan 22 16:59:53 2016 +0530
snapshot: Fix parent volinfo corruption in snapshot restore
Remove parent_volinfo irrespective of success or failure
of glusterd_lvm_snapshot_remove(). This prevents the
duplication of the volinfo after the execution of
glusterd_snapshot_restore().
When commit fails on originator node, we don't perform
commit on the other nodes, as a result we don't have a
backup of /var/lib/glusterd/vols/<volname> in the
GLUSTERD_TRASH in other nodes. But in the postvalidate
we try to restore from GLUSTED_TRASH and end up cleaning
up /var/lib/glusterd/vols/<volname>. Hence moved
glusterd_snapshot_backup_vol() from commit to prevalidate,
so that the backup is always available when a cleanup is
needed.
Change-Id: Icd471b23faf02bad680b9a1aadc4a0175f7cce8b
BUG: 1300979
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13282
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit ec48dea880fcd60d09eedb66336751ec40573ed6
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Feb 9 03:37:31 2016 +0000
cluster/tier: make promotion and demotion independant
Currently a main loop in tiering spawns promotion and demotion threads,
and does a join to wait for them to complete. When one of the two
threads takes a long time, the main thread waits for it
before exiting the join. It may wait so long the scheduled time
for the other thread is skipped. In the case of demotion, it may be
a long time before another attempt. This patch fixes that by
making the promotion and demotion activities independant. A side
effect of this change is the logic is significantly simplified.
Change-Id: I1196bd4bbfc95e8aa326a9bd4ebf395032369d1c
BUG: 1306852
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/13433
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit eb292832bf4d5fd163c21d16a0d54bcea8238df0
Author: Sakshi <sabansal@redhat.com>
Date: Tue May 26 09:53:55 2015 +0530
glusterd: check if glusterd is started on all nodes and all bricks are started before performing rebalance
Change-Id: I458ea9cd86cf35bdb7d758be55f951ae9f3e66f0
BUG: 1224857
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/10906
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 555ed1efa0b0cf8bbcafec8f018ec9ec41a4e6d8
Author: vmallika <vmallika@redhat.com>
Date: Wed Feb 10 16:27:05 2016 +0530
quota: heal object-limit on a root dir of a newly added brick
When a new brick is added, xattr trusted.glusterfs.quota.limit-objects
is not healed on a root directory.
This patch will fix the problem
Change-Id: I776609ebf4d7822c541b6262e63d465ea3a86db4
BUG: 1306220
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13422
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 759667f6d2b5239a557acafd60aaa2185f4b3757
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jan 12 10:41:46 2016 +0530
glusterd: display user.* options in volume get
As of now volume get framework doesn't consider user.* xattrs to be displayed.
This patch is to include them in volume get output. Please note these options will be
only shown for a given volume name, 'all' as a volume name wouldn't consider them displaying.
Change-Id: Ifc19e89c612e9254d760deaaef50bc1b4bfe02ce
BUG: 1297638
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13222
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit d9a80f99663ab51fe3118f0a3b88de732f2f49f6
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Thu Feb 4 16:02:59 2016 +0530
dht: mkdir must unwind with latest ctime
Currently fops like mkdir used the the ctime it gets
after creating the directory entry. But setting layout
also updates the ctime of a directory. Hence DHT must
get the ctime after the setxattr call and unwind with
the latest ctime to avoid mismatch in time seen by
applications like tar.
Change-Id: Iecbbe3aac5244af5da9788b48ccf299ca56b4bae
BUG: 1302948
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/13352
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 166c12a8ea7b10dc174bd52e2a737e908acd4714
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Dec 2 19:37:55 2015 +0530
geo-rep: Handling Rsync/Tar errors efficiently
Geo-rep processes Changelogs in Batch, if one file in batch
fails with rsync error that Changelog file is reprocessed multiple times.
After MAX_RETRY, it logs all the GFIDs from that batch as Skipped.
This patch addresses following issues,
1. When Rsync/Tar fails do not parse Changelog again for retry
2. When Rsync/Tar fails do not replay Entry operations, only retry
rsync/tar for those GFIDs
3. Log Error in Rsync/Tar only in the last Retry
4. Do not log Skipped GFIDs since Rsync/Tar errors are logged for
only failed files.
5. Changed Entry failures as Error instead of Warning
BUG: 1287723
Change-Id: Ie134ce2572693056ab9b9008cd8aa5b5d87f7975
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/12856
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 592f583e90b2c67a50441b1d9dcb8961c7dcaefc
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Dec 29 11:20:39 2015 +0530
geo-rep: Handle ERANGE error during listxattr
llistxattr in Geo-rep is two syscall instead of one
SIZE = llistxattr(PATH, &BUF, 0);
BUF = create_buf(SIZE);
_ = llistxattr(PATH, &BUF, SIZE);
So if any new xattrs added just after first call by any other worker,
second syscall will fail with ERANGE error.
Now Geo-rep sends BUF with large size(256*100) and gets value
with only one syscall. Raises OSError if fails with ERANGE error
even after sending large BUF.
Change-Id: I8ade4bbe9a0a8ea908ed9dedcd3f2ff4c6fe6f51
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1294588
Reviewed-on: http://review.gluster.org/13106
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 1e668a19d5b79c57e10432a3a32db3f66b585e37
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Feb 19 17:08:56 2016 +0530
tools/glusterfind: New option --no-encode
New option added to skip encoding path in output file. Also handled
Unicode strings.
File paths can have newline characters, to differentiate between each
path patch is encoded according to
RFC3986(https://www.ietf.org/rfc/rfc3986.txt). Due to this consumer
applications have to decode the path before consuming it. With this
option Paths are not encoded, can be directly consumed by
applications.
Unicode encoding is handled automatically
BUG: 1310080
Change-Id: I83d59831997dbd1264b48e9b1aa732c7dfc700b5
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/13477
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 9b759db5145931891edbcd9057e75cc64331a576
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jan 14 17:14:25 2016 +0530
geo-rep: Mask xtime and stime xattrs
Allow access to xtime and stime xattrs only
to gsyncd client and mask them for the rest.
This is to prevent afr from performing self
healing on marker xtime and geo-rep stime
xattr which is not expected as each of which
gets updated them from backend brick and
should not be healed.
Change-Id: I24c30f3cfac636a55fd55be989f8db9f8ca10856
BUG: 1296496
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/13242
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit e4b2788d6d702b0a80e421ecd726d2af70da1879
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Fri Jan 22 16:58:13 2016 +0530
geo-rep: Handle hardlink in Tiering based volume
Problem:
Hardlinks are synced as Sticky bit files to Slave in
a Tiering based volume.
In a Tiering based volume, cold tier is hashed subvolume
and geo-rep captures all namespace operations in cold tier.
While syncing a file and its corresponding hardlink, it is
recorded as MKNOD in cold tier(for both) and
We end up creating two different files in Slave.
Solution:
If MKNOD with Sticky bit set is present, record it as LINK.
This way it will create a HARDLINK if source file exists (on slave),
else it will create a new file.
This way, Slave can create Hardlink file itself (instead
of creating a new file) in case of hardlink.
Change-Id: Ic50dc6e64df9ed01799c30539a33daace0abe6d4
BUG: 1301032
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/13281
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 7ffad35c409996118d800c068718b43981868e1c
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Dec 8 16:06:47 2015 +0530
glusterd: set rpc conn flag in brick connect/disconnect
Change-Id: I1a7b23db8f196616be338baeb8f7f56572a05c90
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/12908
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit fa7d204de99541c86bb2ed37f43dee4b0e1ebbd5
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Feb 25 20:36:11 2016 +0530
tests/glusterd: Parse the new time format
A recent change in cli changed elapsed time format
that broke a test.
This patch will fix the issue with parsing.
Change-Id: I9a4a4b28f654cf2ac223e25abfc9df6570607d74
BUG: 1312036
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13524
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 18351097c9c087fbff60beebcf498b84c05dfef3
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Jan 18 14:44:46 2016 +0530
vagrant-test: Provide option to autostart vm on host boot
If the machines are being used as test machines for active development,
user might want to have them autostart on host boot. You can use -a as
short option or --autostart as longoption with run-tests-in-vagrant.sh
to set the autostart flag on the VM. The autostart value is set to off
by default.
It is done using virsh until vagrant-libvirt supports it in the API.
Change-Id: I5b53ea6d850c991d548dbac0bb8fadd528cabf41
BUG: 1291537
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13252
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit cef26903b278f8e17bd22567e4ae11bcb74fa7bb
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Fri Jan 22 12:08:52 2016 +0530
vagrant-test: Install helper packages
It is useful to have helper packages like gdb, sysstat, valgrind
installed on the dev machines. The pre-baked box that was merged in
commit e29bf0b1f102308f114e04421d80696eebfbf6e3 has those packages
installed.
This patch updates the list of packages installed in the install-pkgs
role for future reference.
Change-Id: I2ee25d40708a4d29652b5bd40b66e3b1fcd33f0c
BUG: 1291537
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13458
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 6480ac2aee574848976f8067d7920ed2504cb474
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Jul 10 12:40:24 2015 +0530
locks: Handle negative values for flock->l_len
As per 'man 3 fcntl',
"If l_len is positive, the area affected shall start at
l_start and end at l_start+l_len−1. If l_len is negative,
the area affected shall start at l_start+l_len and end at
l_start−1. Locks may start and extend beyond the current
end of a file, but shall not extend before the beginning
of the file."
Currently we return EINVAL if l_len is found to be negative.
Fixed the same as mentioned in the man page.
Change-Id: I493ce202c543185fc4ae7266d1aaf9d7e2a66991
BUG: 1241104
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11613
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2ac9493af61206324da7ce4fe023591616d18b87
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Dec 31 13:53:54 2015 +0530
inode: Retire the inodes from the lru list in inode_table_destroy
Inodes from the lru list are not moved to purge list unless they
are retired. Also process the lru list first to unset their parent
as we need to unset their dentry entries (the ones which may not be
unset during '__inode_passivate' as they were hashed) which in turn
shall unref their parent inodes which could be in active list.
These parent inodes when unref'ed may well again fall into lru list
and if we are at the end of traversing the list, we may miss to
delete/retire that entry. Hence traverse the lru list till it
gets empty.
Change-Id: Ib7666e235e9b9644144a7c7933afb5e407e506ca
BUG: 1295107
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13125
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 269a00bb951513849a12ac776e38c19781ee7bc2
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Mon Feb 8 12:14:12 2016 +0530
dht: cleanup dict and free memory in rename code path
Change-Id: I2458e18197bdf7565563a85e9021b5b2850c1825
BUG: 1303945
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/13392
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 6c26d1f7874180ae89afd67d7301a858c57323f3
Author: Sakshi <sabansal@redhat.com>
Date: Tue May 5 10:55:56 2015 +0530
cli: output of rebalance to show run time in proper format
Change-Id: I775f13c8046dd2aeb9d4b86a737dcebb396778b4
BUG: 1223625
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/10544
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2d1efe48f191447927efa1d9721470e24bc45fee
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Thu Jan 7 13:09:58 2016 +0530
tests: remove-brick commit getting executed before migration has completed
Remove brick commit will fail when it is executed while rebalance is in
progress. Hence added a rebalance timeout check before remove-brick commit to
enusre that rebalance has completed.
Change-Id: Ic12f97cbba417ce8cddb35ae973f2bc9bde0fc80
BUG: 1225716
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/13191
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 7e4d911e235aec6b0b1b537962637d1385726540
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Wed Dec 9 20:12:17 2015 +0530
glusterd: fixing few memory leak in glusterd
Current glusterd code base having memory leak. This is because of
memory allocate by dict_allocate_and_serialize function in
"gd_syncop_mgmt_v3_lock" and "gd_syncop_mgmt_v3_unlock"
function is not freeing up meory upon exit.
Fix is to free the memory after exit of the above function.
Thanx Carlos and Roman for finding out the issue and fix.
Change-Id: Id67aa794c84969830ca7ea8c2374f80c64d7a639
BUG: 1287517
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Signed-off-by: Carlos Chinea <carlos.chinea@nokia.com>
Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
Reviewed-on: http://review.gluster.org/12927
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 520babb0a1b66fe392c1b87f07159f9fd6c7c733
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Feb 16 18:50:23 2016 +0530
rpc: Fix for rpc_transport_t leak
The transport object needs to get unref'ed when the rpc clnt
object is getting destroyed. But currently in rpc_clnt_disable()
we set conn->trans to NULL before it gets unref'ed leading to
transport object leak.
This change is to fix it by setting conn-tran to NULL only when
it is being unref'ed.
Change-Id: I79ba34e28ae19eb616035f36bbed1c2f47875b94
BUG: 1295107
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13456
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ec95589d562339f169a5bcb3baa487fad510a8c7
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Feb 8 22:33:56 2016 +0530
gfapi: Use inode_forget in case of handle objects
Currently with gfapi, even if applications release their
reference on paritular inode entries, those entries never
get destroyed as they shall always have positive nlookup
count unless inode_table exceeds lru limit.
Since inodes and their contexts can consume considerable
amount of memory, applications may end up consuming lot of
memory and may even get OOM killed.
To avoid that, have considered below approaches (for handle based access)-
a) Do 'inode_lookup' only if the corresponding inode is created
for the first time and forget it during close of the handle
This shall not work as multiple handle objects can refer to
same inode entry and inode_forget from second handle object
onwards shall result in assert.
b) Do 'inode_lookup' during a handle or fd creation
But this approach shall affect the performance of the fops which
operate on neither handle nor fd.
c) current approach taken-
Applications using glfs handle objects hold a reference
on corresponding inode entries. Hence it is safe to forget
those inodes and make nlookup count to '0' while trying to
delete those handle objects. That way the last unref (i.e,
from the last handle close) shall result in inode_destroy().
Change-Id: Id2c7ab178894a10c0030c143ba71e7813df8d18c
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
BUG: 1295107
Reviewed-on: http://review.gluster.org/13096
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 1e5c7304ba039acddfe15a8d43d8e5b9bb4e93d3
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Feb 23 18:27:09 2016 +0530
gfapi: Add xlator_cbks fops in gfapi
Change-Id: I1fe5dd757e65206f92e0a867b43b49a3c0f2d4cf
BUG: 1311124
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13499
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 63e50bfd5263ed31b6f073584a93842145d5dae5
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Feb 23 18:10:36 2016 +0530
libglusterfs: Change log-level to DEBUG for default_* fops()
Change-Id: I7087476bbc00cd23ba65ea119bc0fe8a9bff347d
BUG: 1311124
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13498
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit c7b14b23f2e1570cfb2362682602cd77ec8128eb
Author: Jiffin Tony Thottan <jthottan@gmail.com>
Date: Mon Feb 22 17:20:58 2016 +0530
gfapi : Avoid double freeing of dict in glfs_*_*getxattr
The dict variable "xattr" is passed to glfs_getxattr_process() and
glfs_listxattr_process() in glfs_*_*getxattrs(). This variable is
unrefed by both functions and again in caller function which may
result in segfault. So it is wrong to call dict_unref() in both
glfs_*xattr_process functions.
Change-Id: I227f55ebc3169f58910863c04ae536a8d789e80e
BUG: 1247603
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/13483
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 10966d53cc9c91b385e4d6cc086475bc72a27502
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Mon Feb 22 11:02:31 2016 -0500
glusterd: coverity warning in glusted_copy_nfs_ganesha_file()
fix unused return value from snprintf.
Also minor cleanup, including safe handling of truncated output by
snprintf.
Change-Id: Ibec8c7e6cc4ef07b6535d01a0719359fa3ef8030
BUG: 1310755
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13486
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fb7e9d5a28711d4d359e2c5c5f8d94e1c5e827e4
Author: Jiffin Tony Thottan <jthottan@gmail.com>
Date: Mon Feb 22 16:50:12 2016 +0530
gfapi : fixing listxattr call for handle ops
Currently listxattr is called as part of glfs_h_getxattrs() when NULL is
passed to name field, but glfs_h_getxattrs_common() inside it will error
out if name is NULL. Therefore listxattr is broken for handle ops.
Change-Id: I9ced6e33525e1e1a50298972e4922c954fc2b223
BUG: 1310620
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/13482
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 71d7f8c4e9a1fee7ed5f4feb10aaf047beb69719
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sat Jan 30 08:47:35 2016 +0530
glusterd: set decommission_is_in_progress flag for inprogress remove-brick op on glusterd restart
While remove brick is in progress, if glusterd is restarted since decommission
flag is not persisted in the store the same value is not retained back resulting
in glusterd not blocking remove brick commit when rebalance is already in
progress.
Change-Id: Ibbf12f3792d65ab1293fad1e368568be141a1cd6
BUG: 1303269
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13323
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
commit bb84ec674c38a14bdb973d4e1c89322b384f63a2
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Jan 29 16:24:02 2016 +0530
glusterd/rebalance: initialize defrag variable after glusterd restart
During reblance restart after glusterd restarted, we are not
connecting to rebalance process from glusterd, because the
defrag variable in volinfo will be null.
Initializing the variable will connect the rpc
Change-Id: Id820cad6a3634a9fc976427fbe1c45844d3d4b9b
BUG: 1303028
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13319
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit f248fa5a1337cd9ff55cee834d70d0dd49195602
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Mar 12 12:09:06 2015 +0530
Snapshot:wrong logging is used
Change-Id: I56e5f5696fbbb4290f95adb9b68f9e43ed037ed3
BUG: 1189473
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9861
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit a0689fd24eb99710018adb9b9e37a35f65b82325
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Jun 30 11:26:54 2014 +0530
socket: reduce rate of readv failure logs due to disconnect
... by using GF_LOG_OCCASIONALLY
Change-Id: I779ff32ead13c8bb446a57b5baccf068ae992df1
BUG: 1114847
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/8210
Tested-by: Atin Mukherjee <amukherj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5141ace29e5867c6d7f729f920d1defb55ff1b4d
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Feb 11 15:37:08 2016 +0530
rpc : build_prog_details should iterate program list inside critical section
While I was analyzing a glusterd crash from free_prog_details, a code
walkthrough detects that we iterate over the rpc svc program list without been
inside the criticial section. This opens up a possibility of a crash when there
is a concurrent writer updating the same list. Solution is to read the list
inside lock.
Change-Id: Ib4b4b0022a9535e139cd3c00574aab23f07aa9d2
BUG: 1306560
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13428
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 7a8527223593aa66c5ae94563d1ab85aac6a6cab
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Mon Feb 15 10:48:18 2016 +0530
glusterd: volume should not start when server quorum is not met
Currently when server quorum is not met then upon executing
# gluster volume start [force] command its starting the volume.
With this patch if server side quorum is not met then it will
prevent starting of the volume.
Change-Id: I39734b2dcf8e90c3c68bf2762d8350aecc82cc38
BUG: 1308402
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/13442
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit ed23826dabf40ed84bfcd8a91d4c095e0dfac4f3
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Fri Feb 5 14:51:10 2016 +0530
dht: file rename must take blocking inode locks
Currently DHT takes non-blocking locks for file rename.
Due to this during parallel renames some clients fail
with EBUSY or ESTALE errors. Hence to avoid application
discontinuity file rename must take blocking inode locks.
Change-Id: I986e9d08b3be359f20b1a3e1564e049b0f3dffd3
BUG: 1304966
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/13366
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 213ef0112e8981ac3c2c029d4f496d0944a3380f
Author: Nithin D <nithind1988@yahoo.in>
Date: Sun Nov 15 22:14:43 2015 +0530
glusterd: Bug fixes for IPv6 support
Problem:
Glusterd not working using ipv6 transport. The idea is with proper glusterd.vol configuration,
1. glusterd needs to listen on default port (240007) as IPv6 TCP listner.
2. Volume creation/deletion/mounting/add-bricks/delete-bricks/peer-probe
needs to work using ipv6 addresses.
3. Bricks needs to listen on ipv6 addresses.
All the above functionality is needed to say that glusterd supports ipv6 transport and this is broken.
Fix:
When "option transport.address-family inet6" option is present in glusterd.vol
file, it is made sure that glusterd creates listeners using ipv6 sockets only and also the same information is saved
inside brick volume files used by glusterfsd brick process when they are starting.
Tests Run:
Regression tests using ./run-tests.sh
IPv4: Ran manually till tests/basic/rpm.t .
IPv6: (Need to add the above mentioned config and also add an entry for "hostname ::1" in /etc/hosts)
Started failing at ./tests/basic/glusterd/arbiter-volume-probe.t and ran successfully till here
Unit Tests using Ipv6
peer probe
add-bricks
remove-bricks
create volume
replace-bricks
start volume
stop volume
delete volume
Change-Id: Iebc96e6cce748b5924ce5da17b0114600ec70a6e
BUG: 1117886
Signed-off-by: Nithin D <nithind1988@yahoo.in>
Reviewed-on: http://review.gluster.org/11988
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 23aeb110f4e489fc515cd1cb15fb92c47d428923
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Jan 27 12:59:58 2016 +0530
build: make /var/run/gluster available everywhere
/var/run/gluster was only avialable with glusterfs-server package.
Move it to primary glusterfs package so that client installations as
well as server installations can generate state-dump in that directory.
Change-Id: I1cdd2c5118ac657b2dab4f9669c6657484b8c600
BUG: 1302200
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/13296
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit c5e5df96ac97fc25222f7efc36e7ed1340b9139f
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Tue Feb 16 17:29:31 2016 +0530
build: fix broken build
fix broken build introduced in
commit "c458433041aafb48ae6d6e5fcf3e1e737dc3fda3"
issue:
$ make
CC libglusterfs_la-y.tab.lo
gcc: error: ./y.tab.c: No such file or directory
gcc: fatal error: no input files
compilation terminated
Change-Id: I9632444e733812d633960b15a4dbc7d299d2f44b
BUG: 1308900
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/13455
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 8806bffb3d9dd8418ab1d6b4e9a7e0344a874598
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Feb 10 15:02:48 2016 +0530
glusterd/snapshot : Remove stale pmap registry entry
Perform a pmap_registry_remove on a stale registry
entry from the previous run of snapd, which makes the
query callback always return the older port number.
Change-Id: I7fc504d2b09d32a9c945ec2c33e0e092a0d186ec
BUG: 1306193
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13420
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 0241448c83482c7dcf8cee9617a89755d748f372
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jan 22 12:11:18 2016 +0530
geo-rep: Script to Schedule Geo-replication
This script can be used to run Geo-replication when required. can be
scheduled using cron job to run Geo-replication.
This script does the following,
1. Stop Geo-replication if Started
2. Start Geo-replication
3. Set Checkpoint
4. Check the Status and see Checkpoint is Complete.(LOOP)
5. If checkpoint complete, Stop Geo-replication
Usage:
python /usr/share/glusterfs/scripts/schedule_georep.py <MASTERVOL> \
<SLAVEHOST> <SLAVEVOL>
For example,
python /usr/share/glusterfs/scripts/schedule_georep.py gv1 fvm1 gv2
To schedule the Geo-replication to run once in a day using cron,
# Run daily at 08:30pm
30 20 * * * root python /usr/share/glusterfs/scripts/schedule_georep.py \
--no-color gv1 fvm1 gv2 >> /var/log/glusterfs/schedule_georep.log 2>&1
BUG: 1300956
Change-Id: I6b1e2ddbf7fc09ef621499b57ae230fd4dbbd9a6
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/13279
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit ca7a95d8e1d7bbef201c2e401951c1025e48e44d
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Dec 14 17:52:37 2015 +0530
Upcall/cache-invalidation: Use parent stbuf while updating parent entry
For *create* fops (CREATE, MKDIR, MKNOD), we invalidate the parent
entry. Hence send parent attributes in the stat field.
Also "UP_PARENT_DENTRY_FLAGS" has to be set only for the fops which shall
result in two invalidations requests - one for the inode on which fop is
being performed and another on parent entry.
In case of CREATE/MKDIR/MKNOD fops, there shall be only one invalidation
request sent, that too on parent inode. We send invalidation directly on
parent inode's gfid. So there is no necessity to set these flags which
when set shall endup invalidating the parent's parent entry.
Change-Id: I7514ee08382081e3e060818ede497dbca26987dc
BUG: 1291259
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/12962
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit b3023743bce83f5eefdafe60e135ecfc5bb25f08
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Wed Jan 20 09:31:00 2016 +0530
glusterfsd: destroy frame after rebalance callback has completed
Rebalance after sending a status notification immediately
destroys the frame. Now in its callback the frame is corrupted.
Rebalance crashes when this corrupted frame is accessed. To avoid
this we must destroy the frame after the callback is completed.
Change-Id: If383017a61f09275256e51c44a1efa28feace87b
BUG: 1300152
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/13262
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 0610a8a18b6aeebaf86f1478ed7efa4d96cce65d
Author: Prashanth Pai <ppai@redhat.com>
Date: Thu Feb 11 18:54:41 2016 +0530
Mark slowest tests in regression test output
Recording of elapsed time is only accurate to the second. This should
be okay. Some *BSD systems may not have '%N' support in date command.
Change-Id: I81e887c4783b052317922f3a4af37ec3676fb67d
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/13430
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 6ad3b858df50f7e0b419da46e6bb801fd26d5f96
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Sat Dec 19 20:27:17 2015 -0500
all: fixes for clang compile warnings
cli/src/cli-cmd-parser.c (chenk)
cli/src/cli-xml-output.c (spandit)
cli/src/cli.c (chenk)
libglusterfs/src/common-utils.c (vmallika)
libglusterfs/src/gfdb/gfdb_sqlite3.c (jfernand +1)
rpc/rpc-transport/socket/src/socket.c (?)
xlators/cluster/afr/src/afr-transaction.c (?)
xlators/cluster/dht/src/dht-common.h (srangana +2)
xlators/cluster/dht/src/dht-selfheal.c (srangana +2)
xlators/debug/io-stats/src/io-stats.c (R. Wareing)
xlators/features/barrier/src/barrier.c (vshastry)
xlators/features/bit-rot/src/bitd/bit-rot-scrub.h (vshankar +1)
xlators/features/shard/src/shard.c (kdhananj +1)
xlators/mgmt/glusterd/src/glusterd-ganesha.c (skoduri)
xlators/mgmt/glusterd/src/glusterd-handler.c (atinmu)
xlators/mgmt/glusterd/src/glusterd-op-sm.h (atinmu)
xlators/mgmt/glusterd/src/glusterd-snapshot.c (spandit)
xlators/mgmt/glusterd/src/glusterd-syncop.c (atinmu)
xlators/mgmt/glusterd/src/glusterd-volgen.c (atinmu)
xlators/protocol/client/src/client-messages.h (mselvaga +1)
xlators/storage/bd/src/bd-helper.c (M. Mohan Kumar)
xlators/storage/bd/src/bd.c (M. Mohan Kumar)
xlators/storage/posix/src/posix.c (nbalacha +1)
Change-Id: I85934fbcaf485932136ef3acd206f6ebecde61dd
BUG: 1293133
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13031
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 8bffd5643636dc55085dcccd2aa5fc5bc6deb4e4
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Fri Dec 18 15:21:27 2015 -0500
all: fix various cppcheck warnings
fixes for various warnings reported by cppcheck
N.B. cppcheck output is in the bugzilla
Change-Id: I33acec127bc4536935fdd8d52a0c490ec54d50b2
BUG: 1292954
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13006
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit d98dcd904cee3c4deab0d8f914df7dfbefaebf4d
Author: vmallika <vmallika@redhat.com>
Date: Tue Feb 2 12:30:16 2016 +0530
USS: pre-existing .snaps should not be listed with 'ls -a' with USS enabled
If there is a .snaps directory pre-exists and when USS is enabled,
it should not be listed with 'ls -a'
Change-Id: I1c43e2decc0bbbd3213b190b675e3a32d04b22d3
BUG: 1303828
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13330
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 5a84674b356d378cac46a974851d4912c87e0349
Author: N Balachandran <nbalacha@redhat.com>
Date: Sat Feb 13 10:02:55 2016 +0530
cluster/dht: Skip subvols if no layout present
Running "rm -rf" on a tiered volume sometimes caused
the client to crash because dht_readdirp_cbk referenced
a NULL layout for the hot tier subvol.
Now, entries are skipped if the layout is NULL. This
can cause "rm -rf" to fail with ENOTEMPTY rmdir failures.
Change-Id: Idd71a9d0f7ee712899cc7113bbf2cd3dcb25808b
BUG: 1307208
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/13440
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit a47143413611ab5474e4b0d4adbf2656c4d1d910
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Feb 8 13:30:49 2016 -0500
experimental: add fdl (Full Data Logging) translator
NSR needs logging that is different than our existing changelog in
several ways:
* Full data, not just metadata
* Pre-op, not post-op
* High performance
* Supports the concept of time-bounded "terms"
Others (for example EC) might need the same thing. This patch adds such
a translator. It also adds code to dump the resulting journals, and to replay
them using syncops, plus (very rudimentary) tests for all of the above.
Change-Id: I29680a1b4e0a9e7d5a8497fef302c46434b86636
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/12450
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit e0cb926f44005d36d706f5b15adc1ebb3b1b5427
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Jan 18 12:16:31 2016 +0000
cli/ afr: op_ret for index heal launch
Problem:
If index heal is launched when some of the bricks are down, glustershd of that
node sends a -1 op_ret to glusterd which eventually propagates it to the CLI.
Also, glusterd sometimes sends an err_str and sometimes not (depending on the
failure happening in the brick-op phase or commit-op phase). So the message that
gets displayed varies in each case:
"Launching heal operation to perform index self heal on volume testvol has been
unsuccessful"
(OR)
"Commit failed on <host>. Please check log file for details."
Fix:
1. Modify afr_xl_op() to return -1 even if index healing of atleast one brick
fails.
2. Ignore glusterd's error string in gf_cli_heal_volume_cbk and print a more
meaningful message.
The patch also fixes a bug in glusterfs_handle_translator_op() where if we
encounter an error in notify of one xlator, we break out of the loop instead of
sending the notify to other xlators.
Change-Id: I957f6c4b4d0a45453ffd5488e425cab5a3e0acca
BUG: 1302291
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13303
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 9cc75e906db3a7fbcc02c66274faf512d808a5f6
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Jan 18 15:06:18 2016 +0530
vagrant-test: Use pre-baked box for better perf
Using Fedora cloud base leads to lot of downloading
time for packages and also it is larger in disk size
once imported into linux.
Change-Id: I2e878e7cb29a79ade4d6e517075ab523062deb53
BUG: 1291537
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13251
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 525aa2c0266d8197b9b5438cfaf0301b4eb60b39
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Dec 10 10:30:32 2015 -0500
NSR : nsr server code generation patch
The NSR-server with this patch, appoints the first node
on every replica subvolume, as the leader for that subvolume.
On receiving a 'write' fop, the leader first checks if there is
quorum in the replica subvolume to proceeed. In case there isn't
it fails with EROFS.
If there is quorum, the leader forwards the fop to the
followers. The followers on receiving the fop, perform the
operation, and based on the success or failure of the outcome
send a +ve or a -ve ack to the leader.
The leader after receiving acks from the followers performs a
quorum check of the acks, to see if it should even try to perform
the fop. If quorum is not being met, and the leader's outcome
wouldn't affect quorum, then it would send -ve ack to the client
without even performing the fop. If quorum is being met, the leader
will then try the fop on itself, and based on it's outcome perform
a quorum check of all the acks received (this time, including it's
own). Based on the result of the quorum check (irrespective of the
outcome on the leader), a +ve or -ve ack is send back to the client.
Change-Id: I860654b74c53e9b139b37dba43848e5504df6dce
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/12705
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit dd5e8871dc2bd9583cb7f274a599d377f143bd44
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 10 15:28:39 2016 +0530
heal: Remove sleep()
I wrote this program from a sample gfapi program which had sleep.
I am not sure why this sleep was needed. So removing it now.
Changed tests/bugs/replicate/bug-1190069-afr-stale-index-entries.t
to execute count_sh_entries every second, instead of comparing
same value over and over.
Change-Id: I7b89d6cab3e50bb7bf4d40a6064f2d8734155bea
BUG: 1306199
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13421
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit a9fa174635351862e6498df490515d634a285510
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Feb 10 17:08:26 2016 +0530
api: glfs_lseek must return repositioned offset for SEEK_SET, SEEK_CUR flags
On success, glfs_lseek() API is responsible for providing the
repositioned offset as its return value. But for SEEK_SET and
SEEK_CUR flags, glfs_lseek() returns -1 on successfully
repositioning the fd offset. Current change is to set ret to
0 after glfd->offset is modified correctly so as to return the
correct offset.
Change-Id: I94d582779a98074cf633289f4b60b3c6a04e4f18
BUG: 1306264
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/13423
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 1d6a81b99ad12261f1d4ca46b73498e77c84b23a
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Feb 4 18:24:55 2016 +0530
cluster/tier : Fixed wrong variable comparison
The wrong variable was being checked to determine
the watermark value.
Change-Id: If4c97fa70b772187f1fcbdf5193e077cb356a8b1
BUG: 1303895
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/13357
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit af187aad89e49cff8dd3efd0d948588dece04686
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jul 6 00:01:44 2015 +0200
fuse: add support for SEEK_HOLE and SEEK_DATA through lseek()
The Linux FUSE kernel module has gained support for passing SEEK_HOLE
and SEEK_DATA on through lseek(). This can greatly improve performance
when working with sparse files.
Linux FUSE introduced support for lseek() with version 4.5. The commit
in mainline Linux is 0b5da8db145bfd44266ac964a2636a0cf8d7c286.
URL: http://thread.gmane.org/gmane.comp.file-systems.fuse.devel/14752
Change-Id: I12496d788e59461a3023ddd30e0ea3179007f77e
BUG: 1220173
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11474
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit fbe82f53bbfc08d36e310c7f0eceec764d802b6f
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Fri Feb 5 12:17:22 2016 +0530
quota: Fix incorrect disk usage shown on a tiered volume
When quota is enabled on a tiered volume, incorrect data usage is
shown, it is because, during the process of migrating files in tiering,
we are accounting both for the src file and dst file at some point. By the
time we make the srcfile as a T file, marker has already accounted the
contri and has updated it's parent and also we are not accounting for the
truncate operation done, which accounts to incorrect data usage even after
unlinking the file. The size can increase drastically with multiple promotes
and demotes since the contri keeps changing and the parent is being updated.
Change-Id: Ie567228786713d7dc257ff374a69ad3be40f9e82
BUG: 1304970
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/13363
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 67abde52b17995d457c44f244c14b57abb377b5a
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Feb 2 04:22:04 2016 +0530
libgfapi: glfd close is not correctly handled for async fop
There is chance that before the async fop is complete client can send
a close. libgfapi destroys glfd on close. Therefore it can lead to
crash or unexpected behaviour when the pening fop reaches libgfapi
layer. Currently we don't provide any api to cancel these outstanding
fops neither we check if the glfd is already closed or not.
Therefore as a fix provided refcount for glfd. Each fop (sync or async)
will take a ref and once the fop is complete it will unref the refcount.
We should not call the registered callback function if glfd is already
closed. To achieve this we maintain state of glfd so that we can safely
take a call if the fd is closed or not.
Change-Id: Ibe71b2225312db3f1be66b244fcf8826c70c357d
BUG: 1303995
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/13340
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit e8dd31384903d04284836516c73062c223f2a31d
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Jan 27 14:56:33 2016 +0530
dht/quota : heal the limit_objects_key xattr needed for inode-quota
Whenever a new brick is added, quota related xattr's
should be healed but currently, the xattr
"quota.limit-objects.<suffix>" needed for inode-quota is
not being healed.
The patch fixes this issue.
Change-Id: I1e7b229126f7b058642bbc3fb5c109bfd8925325
BUG: 1302257
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/13299
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8ce3cfe5bb2a5c334c58215d10de617904a863a6
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jun 21 16:59:15 2015 +0200
posix: implement seek() FOP
The only lseek() options we need are SEEK_HOLE and SEEK_DATA.
Change-Id: I5d15533c53fd710497f97c3cb4a8ea29fba47271
BUG: 1220173
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11484
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 1603e1a54d089b5b0c4523aa25def3c199c474a8
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Thu Jan 28 12:35:40 2016 +0530
cli/quota : quota is not enforcing when limit is set to 0
When limit value is set to 0, quota assumes that limit is not
set and is not enforcing currently. The patch fixes this issue by
restricting the user from setting limit value = 0.
Change-Id: I316653165cd9766600f95b5f23e5b8abcc2b41e7
BUG: 1302554
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/13309
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit f145d78cf2f1be46cfea921f4e1500a6af59cff4
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Fri Nov 20 16:46:31 2015 +0530
build: Filter -D_FORTIFY_SOURCE from CFLAGS
We use python-config to get recommended CFLAGS. It provides
-D_FORTIFY_SOURCE=2 by default that conflicts with our
--enable-debug option or a developer provided no-optimization option.
Hence, filter it out from default CFLAGS.
Change-Id: Id80196baeb55415b1ea334e7b17143e56dfbadb3
BUG: 1283948
Co-authored-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/12707
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 7f4538121fb5a0e75ff2a7b7a5df2b5ba311764b
Author: Jiffin Tony Thottan <jthottan@gmail.com>
Date: Mon Feb 1 11:02:37 2016 +0530
access-control : remove spurious error message from the posix_setxattr_cbk
A check for dictionary is required before calling handling_other_acl_related_xattr()
in posix_setxattr_cbk(). Otherwise following message will be poped up on every settxattr
call.
[2016-01-31 17:38:48.027792] I [dict.c:473:dict_get]
(-->/usr/lib/x86_64-linux-gnu/glusterfs/3.7.6/xlator/system/posix-acl.so
(posix_acl_setxattr_cbk+0x26) [0x7f2334c5c166] -->
/usr/lib/x86_64-linux-gnu/glusterfs/3.7.6/xlator/system/posix-acl.so
(handling_other_acl_related_xattr+0xb0) [0x7f2334c5c0f0]
-->/usr/lib/x86_64-linux-gnu/libglusterfs.so.0(dict_get+0x93)
[0x7f233c04b0c3] ) 0-dict: !this ||
key=system.posix_acl_default [Invalid argument]
Change-Id: I93f7e0f764c94dce38bdde95a68341f69a52122d
BUG: 1303501
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/13325
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 182229d3a4552ede8607b1a4b2dfa70a48bf529e
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Dec 9 14:19:00 2015 -0500
NSR: nsr client code generation patch
This version of the client checks if the error returned
is EREMOTE or ENOTCONN, and if not unwnds the error back
In case of a EREMOTE or ENOTCONN error, it retries on
all the bricks in the replica subgroup, and if the error
still persists, it waits for a sec before going through the
same exercise again.
Change-Id: I916bed32f0820f381dd60fdde3d05b71c69a34dc
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/12388
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 137466b5206cc17d77bd0f451750117450986aad
Author: vmallika <vmallika@redhat.com>
Date: Wed Feb 3 14:32:17 2016 +0530
uss: validate USS option features.snapshot-directory
USS option features.snapshot-directory
contains only 'alphanum, -, _, .'
starts with dot (.)
value cannot exceed 255 characters
and throws error for any other argument.
Change-Id: Iad64635206ddf5599351020d99aafb3dd9d17bc1
BUG: 1168819
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9209
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 15439c15c5751546b2c5ee32b58501e4ad038562
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Feb 4 12:07:36 2016 +0530
cluster/ec: Automate heal for replace brick
Problem:
After a replace brick command, newly added
brick does not contain data which existed
on old brick.
Solution:
Do getxattr after initialization of all the
bricks. This will trigger heal for brick root
as soon as it finds the version mismatch on
newly added brick.
Removing tests from ec-new-entry.t which were
required to simulate automation of heal after
replace brick.
Change-Id: I08e3dfa565374097f6c08856325ea77727437e11
BUG: 1304686
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13353
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit e44c5ef3125d9bc95b1902c6e0dbf051ec73a114
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Dec 24 14:29:33 2015 +0530
performance/open-behind: Fix fdctx dump NULL dereference
Also printing flags correctly in statedump now
Change-Id: Ibfdd74aab5643ecc47d0a88f109d5d1050685f5a
BUG: 1294051
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13076
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 7bb677d4596ca85aea10a4bf260810a2a7756e04
Author: vmallika <vmallika@redhat.com>
Date: Tue Dec 29 17:35:30 2015 +0530
quota: fix quota hook script for add-brick
Hook script should not call any CLI commands
as this can cause parallel operation problem,
so remove quota list command from the script
Change-Id: I76a364133403371b172e063abd5f742075b20a2f
BUG: 1294637
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13110
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 777d208faf7b0f51984e04522265b87b3f3e9383
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Dec 14 16:25:22 2015 -0500
NSR: Volgen Support
Allows the user to convert an afr-volume to a nsr-volume
by using cluster.nsr option in the volume set command
gluster volume set <volname> cluster.nsr <on/off>
Change-Id: Ia1c5aa89d27535f7275d474cf312dc5efb8e222f
BUG: 1158654
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/12943
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 35a30ae5a7979dadd4573975d663028a8bd6061e
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Feb 2 19:28:49 2016 +0530
Allow builds with older version of URCU
Debian Wheezy, which has urcu-0.6 doesn't ship the pkg-config files for
urcu. So when I was checking support, I didn't bother testing Wheezy or
urcu-0.6 as I didn't want to spend time trying to build without
pkg-config support.
But it turns out that urcu-0.6 supports the APIs being used by GlusterD.
This patch improves the configure script to manually search and set URCU
build flags if pkg-config search fails.
Change-Id: I8c2ae748b58e94d89aef61da6fb3c660710a5f3b
BUG: 1304348
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/13345
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 0d6aaa54579942be2b03c0bfec2d5fd0af399384
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jan 22 12:11:40 2016 +0530
cluster/ec: Never return -ve state
Ec manager shouldn't return -ve states, but it is, fixed that.
Change-Id: I3f97c6ba2dbf9da724e8e1ee9b2c9da73f40013d
BUG: 1300929
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13278
Tested-by: Xavier Hernandez <xhernandez@datalab.es>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit e23980fc60851c6b402e2576012acac1e5e5c27f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Feb 3 15:14:13 2016 +0530
tests: Move self-heald.t to bad tests
Change-Id: I49d8f1b9668029d2b8bd35b366b673d7a08a057f
BUG: 1304301
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13344
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 5ae158d1a2059fe637a6b1521c25e17856e93160
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Feb 4 18:18:15 2016 +0530
tests: Cosmetic changes to make results look better
Change-Id: I39116bdca1db3a02bb018af245055fbf8279671d
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13356
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 9a4a1cb645c34e402f07e6c6ec588cb1c32e0b24
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Feb 4 14:32:12 2016 +0530
tests: Add option to disable exit on failure
By default run-tests.sh will quit after any test
fails. If the user is interested to run all the
tests then he/she will have to use the
-c option.
Change-Id: I99a0aafee280325114205b30ab3fd199978b28bb
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13350
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit b252082b0beab08de0c59a0be0ab924fe124cb40
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Feb 2 19:34:01 2016 +0530
tests: combine main and main_and_retry into run_tests
run_tests is now aware of retry option and will handle the re-run within
itself. We don't need main_and_retry and main anymore.
Change-Id: I0f8cad88e29c81588dc0af9f5de78177d0f4e828
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13337
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit bd440a17e71ee471289da8ae0e057d925ab8775f
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Feb 2 19:12:41 2016 +0530
tests: Combine run_all and run_tests
Both the functions perform the same job.
If no args are given or if args is null string then
run_tests will act as run_all.
Change-Id: I27284af95fa012b64bba16ac50da8181edfa6336
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13335
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit d0aafee067c1c0745f366fa5cd8286bb214ccc7e
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Feb 2 18:14:24 2016 +0530
tests: Make match function simpler
We don't use the dir matching code in run_all.
It is used in run_tests but it is not generic enough
and needs work to be fixed.
Rather, making the match function simpler and work for
only files is easier.
This will help with refactoring of run_all and run_tests.
Change-Id: Ifcd1217480738316736184a51813052ac6a1124e
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13334
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 57e855893d750ac804cfbe371a418fb921a7d562
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Jan 18 15:57:41 2016 +0530
Fuse: Add a check for NULL in fuse_itable_dump
Problem: Immediately after starting a disperse volume (2+1)
kill one brick and just after that try to mount it
through fuse. This lead to crash.
Our test scripts use process statedumps to determine various things
like whether they are up, connected to bricks etc. It takes some time
for an active_subvol to be be associated with fuse even after mount
process is daemonized. This time is normally a function of completion
of handshake with bricks. So, if we try to take statedump in this time
window, fuse wouldn't have an active_subvol associated with it leading
to this crash.
This happened while executing ec-notify.t, which contains above steps.
Solution: Check priv and priv->active_subvol for NULL before
inode_table_dump. If priv->active_subvol is null its perfectly fine to
skip dumping of inode table as inode table is associated with an
active_subvol. A Null active_subvol indicates initialization in
progress and fuse wouldn't even have started reading requests from
/dev/fuse and hence there wouldn't be any inodes or file system
activity.
Change-Id: I323a154789edf8182dbd1ac5ec7ae07bf59b2060
BUG: 1299410
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13253
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1ac3b17f6350add2808c094cded32df4c49bad2a
Author: N Balachandran <nbalacha@redhat.com>
Date: Sat Feb 6 21:09:29 2016 +0530
cluster/tier: Create linkfiles to hardlinks correctly
There is a bug in the way hardlinks are handled in tiered volumes. Ideally, the tier linkto files on the cold tier to files that are hardlinks to each other on the hot tier, should themselves be hardlinks of each other. As they are not, they end up being files with the same gfid but different names for the cold tier dht, and end up overwriting the cached-subvol information stored in the dht inode-ctx.
Change-Id: Ic658a316836e6a1729cfea848b7d212674b0edd2
BUG: 1305277
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/13391
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit f8b8a0a1bc2c8a887b083f244040b267e3c754c6
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Jul 1 08:28:07 2015 +0530
fuse: update fuse_kernel.h to version 23
The following changes were made upstream:
- add FUSE_WRITEBACK_CACHE
- add time_gran to fuse_init_out
- add reserved space to fuse_init_out
- add FATTR_CTIME
- add ctime and ctimensec to fuse_setattr_in
- add FUSE_RENAME2 request
- add FUSE_NO_OPEN_SUPPORT flag
Including these changes will make it easier to backport support for
lseek().
Because the fuse_init_out structure changed its size, older versions of
FUSE would fail initializing. When an older version of FUSE is detected,
the fuse_init_out structure is reduced to the previous size. This is
harmless, as the attributes that are not passed, are not used for
earlier versions anyway.
BUG: 1220173
Change-Id: I58c74e161638b2d4ce12fc91a206fdc1b96de14d
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
[ndevos: splitted from http://review.gluster.org/11474
old version fuse_init_out size correction]
Reviewed-on: http://review.gluster.org/11537
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit c456eeaff94f506edc14eea367b7bdcef7edf110
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Feb 4 14:33:54 2016 +0530
vagrant-tests: Fix bug when git branch name has a /
It is possible for a git branch to have a / in it.
Source copy from host to VM used relative path on
the assumption that VM vagrant dir will always be
three levels down the topdir of repo. This assumption
breaks when git branch has a / in it.
Of the two solutions to fix it:
a. Mangle the git branch name to not have a /
b. Accomodate the possibility of have a / in git branch name.
I have chosen b) because that looks cleaner.
Change-Id: I6b71c31da2f5f7c349d6d6882767768b2534d14f
BUG: 1291537
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13355
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit bef525a54ced6f7addca979d9b5d3d4f159b2246
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jan 14 11:11:45 2016 +0530
glusterd: check quorum on restart bricks
While spawning bricks on a glusterd restart the quorum should be checked and
brick shouldn't be started if the volume doesn't meet quorum.
Change-Id: I21bf9055bdf38c53c81138cc204ba05a9ff6444f
BUG: 1298439
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13236
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 8b645d689de984dd615b073b6916ef760c20168b
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Jan 14 09:36:33 2016 +0100
cluster/ec: Handle non-existent config xattr for non regular files
Since we now try to get the 'trusted.ec.config' xattr for inodes of
type IA_INVAL (these inodes will be set to some valid type later),
if that inode corresponds to a non regular file, the xattr won't
exist and we will handle this as an error when it's not.
This patch solves the problem by only considering errors for inodes
that are already known to be regular files.
Change-Id: Id72f314e209459236d75cf087fc51e09943756b4
BUG: 1293223
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/13238
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ashish Pandey <aspandey@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b2e98a8bfb2a938c153ea2b037e043636ab769ea
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jan 25 16:56:05 2016 +0100
tests: add seek program for testing SEEK_DATA/SEEK_HOLE over FUSE
Note that this only works on Linux kernel 4.5 and newer. The program is
not run by a test-case because of this.
BUG: 1220173
Change-Id: Ifdee3c793e33f9d763940130e8d01a61eae5498a
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13291
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 24918428205749e1d6b37a6faba2499a14854d7d
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jun 21 20:29:07 2015 +0200
afr: add seek() FOP
seek() is like a read(), copied the same semantics.
Change-Id: I100b741d9bfacb799df318bb081f2497c0664927
BUG: 1220173
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11483
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 2051ba695a7150e152c12c76260f2e1e834f6594
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Jul 1 18:52:42 2015 +0200
cluster/ec: add seek() FOP
BUG: 1220173
Change-Id: Iaa23ba81df4ee78ddaab1f96b3d926a563b4bb3d
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/11494
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 78f73eb2a6ed3b0f0e3ed0b852a9c465226422c1
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jun 21 23:36:12 2015 +0200
gfapi: add test for glfs_lseek() SEEK_DATA/SEEK_HOLE
Change-Id: I8d0573ed8b2ea5ce976ad140a24be7974dbad0e3
BUG: 1220173
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11486
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 3e9c576d8c5520b9a4385f7c3efb621efc6f4357
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Tue Dec 1 14:23:08 2015 +0530
libglusterfs: close & open cmd_history.log on log rotate
Post log rotate, cmd_history.log is not refreshed (closed & opened back)
due to which new commands still land up in the log rotated file.
Fix is to close and open cmd_history.log file upon log rotation
Change-Id: Ie6990c9d55b0afa544bc5c84de3db49ff4b1299b
BUG: 1286959
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/12832
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 4613fe03863ca694c9572e9e03c3d1ea7ff11fce
Author: Anoop C S <anoopcs@redhat.com>
Date: Fri Nov 27 10:50:14 2015 +0530
gfapi: Remove TODO for merging of locks
pub_glfs_posix_lock() currently merge/split locks via
fd_lk_insert_and_merge(). So removing the same from
TODO list.
Change-Id: I956fbb3a99ada9616392f934034a94be418195c4
BUG: 1202274
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/12770
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit cdb7648930dd321531d014097d2ad12d2a1a11d7
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jun 21 17:04:29 2015 +0200
protocol: implement seek() FOP
Network protocol extensions for the seek() FOP. The format is based on
the SEEK procedure in NFSv4.2.
Change-Id: I060768a8a4b9b1c80f4a24c0f17d630f7f028690
BUG: 1220173
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11482
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit daffb431e20095069f44ffa8fdd6482b13e929c9
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Feb 3 17:15:03 2016 +0100
shard: add seek() FOP as not supported
For getting basic support for SEEK_DATA/SEEK_HOLE, sharding has not been
implemented. Bug 1301647 has been filed to get this new feature in
sharding as well.
Because of a premature merge (and revert), this change is re-applying
everything from commit 2ce3daa94066dcc77cdc6b54a31747b6c7c0c2fc again.
BUG: 1220173
Change-Id: I0fb2d36c65af5cb2d0a064104b74f7a863ec4ed3
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13347
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e2324455740716834e23d9efb5be6245ed5ec67f
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jan 26 23:49:24 2016 +0100
stripe: add seek() FOP as not supported
For getting basic support for SEEK_DATA/SEEK_HOLE, striping has not been
implemented. Bug 1302149 has been filed to get this new feature in
stripe as well.
Change-Id: I9cfed795737609120eafe86f9287d79057b14fe2
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13294
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 60866088fef50b06858148753b6048344008b5ca
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Dec 18 20:35:02 2015 +0100
upcall: add seek() FOP
Change-Id: Ic86919d28cf639b561114dc1440c6ea4bc6f7307
BUG: 1220173
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13005
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 73f86c7e01e2877ee857b77f18a929093ddd2e83
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jun 21 18:32:40 2015 +0200
gfapi: add support for SEEK_HOLE and SEEK_DATA in glfs_lseek()
Change-Id: I142dde11923244809b03fcca8cd4c2f7d5ff3929
BUG: 1220173
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11485
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 465c38580fc9d43bb9550d3064aeb807c64598f9
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Feb 3 18:24:20 2016 +0530
features/trash: Handle unlink unwind properly
When enabled, trash translator does a rename
internally for every unlink request and unwinds
the original unlink call. But this was unwinded
back with prerparent and postparent as NULL which
resulted in changing the parent directory
permissions to 000.
This issue is consistently seen as a failure
when a non-root user executes vim commands which
internally tries to perform stat operations (as
part of swap/backup file creation) on a file
whose parent directory's permission was modified
to 000 due to recent unlink for another file
inside the same directory.
Change-Id: I161a036b37fb815866d50d2d6260ff0ad22d7223
BUG: 1302307
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/13346
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 7c9f1b9d7327ce7b9cd7c788220d2c3b00065971
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jan 27 15:08:03 2016 +0530
geo-rep: Fix gsyncd prefix in gsec_create
gsec_create script is generated after running ./configure
libexec dir was formed using $prefix/libexec, but in Debian based
distributions libexec dir is not present, instead they use lib
directory to store these scripts.
With this patch, full libexec path is fetched during ./configure.
BUG: 1162905
Change-Id: I9f47a38e6ab0027c7df6716136fbe0635e95a593
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/13298
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit cba2f4f4c2e2ecd268c7cb3cfdd18f9a168724c8
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Feb 2 19:24:07 2016 +0530
tests: always use $@ and in quotes
Change-Id: I318d8b0ea60937f74b3280fa2ad26876ce8c3345
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13336
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 40afa39850c79ee8ccff821498e7d8263f4af31e
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Jan 29 15:59:24 2016 -0500
cluster/dht: Cleanup dict in dht_do_rename()
Change-Id: Ib4b3a843e78eccf5b8e0e7776cd0128013a59a3e
BUG: 1303945
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/13322
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 372b39a72bc3513dee591acaa250773bf73a0cc1
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Sat Jan 30 22:35:19 2016 +0100
fuse: fix inode and dentry leaks
When a readdirp was executed, the nlookup count for each inode of the
returned entries was incremented. However the kernel does not increment
the counter for '.' and '..' entries.
This caused kernel to send forgets with a counter smaller than the
inode's current value. This prevented these inodes to be retired when
ref count was 0.
Change-Id: I31901af36ab7b4cdc3e6fa2f30a0263a1a2daef8
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/13327
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit ca566dbb3c39a731b7f13bde96f290435a33045a
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Feb 1 11:46:08 2016 +0530
cluster/afr: Fix heal-info slow response while IO is in progress
Now heal-info does an open() on the file being examined so that
the client at some point sees open-fd count being > 1 and releases
the eager-lock so that heal-info doesn't remain blocked forever
until IO completes.
Change-Id: Icc478098e2bc7234408728b54d8185102b3540dc
BUG: 1297695
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13326
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 75391ab59784f0a8c4fe44b72ae5e7b5c47ae362
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Jan 26 17:47:08 2016 +0530
tier/gfdb : Round-Robin read of query files
1. Each brick on a host will get a separate query file.
2. While reading query record from these query files we
read them in a Round-Robin manner.
3. When an error occurs during migration we rename it to
query file with an time stamp and .err extension for
better debugging.
Change-Id: I27c4285d24fd695d2d5cbd9fd7db3879d277ecc8
BUG: 1302772
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/13293
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: N Balachandran <nbalacha@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 2cde7fc57aaaedb505143932871d7be871ac0854
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Feb 2 22:09:45 2016 +0530
cluster/tier : Reset watermarks in tier
A node which contains only cold bricks and has detected that
the high watermark value has been breached on the hot tier will
never reset the watermark to the correct value. The promotion check
will thus always fail and no promotions will occur from that node.
Change-Id: I0f0804744cd184c263acbea1ee50cd6010a49ec5
BUG: 1303895
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/13341
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 7477c59c4545106b4b4d78202bf0dcde7ef6aeda
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri Jan 22 17:31:48 2016 -0500
cluster/tier: break out of iterating query file once cycle time ends
When iterating the query file during migration, tiering should
break out of the loop once cycle time completes. Otherwise it
may be possible to stay in the loop for a long time. If that
happens updates to files will become stale and have not impact
migration.
Change-Id: Ib60cf74bc84e8646e6a0da21ff04954b1b83c414
BUG: 1301227
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/13284
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit ef08d897e1ccd454bb7976767145142c7ca95566
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Feb 1 12:29:40 2016 +0530
tests: refactor option parsing into a function
Creating a separate function to parse options.
This is required for subsequent patches where we add
more options to run-tests.sh.
Created a variable tests to hold the tests list or
pattern as passing around $@ is not informative.
Change-Id: I032639c07419f5136c604531c5719c13ac4f9fe3
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13328
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit 941505a8c35c7e75b138a512823365f7bc3db976
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu Jan 21 15:03:38 2016 -0500
fuse: use-after-free fix in fuse-bridge, revisited
Prompted by the email exchange in gluster-devel between Oleksandr
Natalenko, xavi, and soumyak, I looked at this because the fuse client
on the longevity cluster has also been suffering from a serious memory
leak for some time. (longevity cluster is currently running 3.7.6)
The longevity cluster manifests the same kernel notifier loop terminated
log message the Oleksandr sees, and some sample runs suggest that the
length passed to the (sys_)write call is unexpectedly and abnormally large.
Basically this fix
a) uses correct types for len and rv,
b) copies the len from potentially incorrectly aligned memory (in a
way that should minimize potential performance issues related to
accessing unaligned memory.)
c) changes log level of the kernel notifier loop terminated message
d) fixes a potential mutex lock/unlock issue
Change-Id: Icedb3525706f59803878bb37ef6b4ffe4a986880
BUG: 1288857
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13274
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit b1cecd5f12aeec0f710be14eafa5ba74ed5a5228
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Dec 21 17:55:49 2015 +0530
heal: Have fixed number of fields in heal info output
Sample output:
⚡ gluster v heal r2 info
Brick localhost.localdomain:/home/gfs/r2_0
/a
/
Status: Connected
Number of entries: 2
Brick localhost.localdomain:/home/gfs/r2_1
Status: Transport endpoint is not connected
Number of entries: -
Brick localhost.localdomain:/home/gfs/r2_2
Status: Connected
Number of entries: 0
Brick localhost.localdomain:/home/gfs/r2_3
Status: Connected
Number of entries: 0
Partial failure will print:
...
<gfid:3efb51cf-5fa5-4bed-817b-afd600e9449e>
Status: Failed to process entries completely. (Transport endpoint is not connected)
Number of entries: 372
...
BUG: 1297897
Change-Id: I79131cbf255acd98f11eedafb53246c465f6665d
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13231
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Sahina Bose <sabose@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit b9751e9d67f4a79746dd3caa15ffcebef6a42731
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Mon Jan 25 01:33:48 2016 +0530
extras/devel-tool: Added gdb_macros for debugging
provided following functions in the script
1) print dictionary (dict_t) items
2) print list members (only address)
Change-Id: I5befb2dcdbf258ab3001ff25212a5862b9cc5321
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/13289
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 9b8261a15cce5c04b1dc77c7758b76d38d231f37
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Dec 30 16:37:05 2015 +0530
snapd: Do not persist snapd port
Currently snapd persists the port it uses
to sign-in with glusterd, without checking
if that particular port is being used by any
other process. As a result, it might erroneously
sign out any other process using the same port.
Hence forcing snapd to ignore the persisted port,
and using a new one while coming up.
Change-Id: Ibb9ec3762aac445f03d96e85660585be4ab27bcb
BUG: 1294794
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13118
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit d70083febb76e85b4f14be98bf7ca0f0801444d9
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jun 21 17:51:24 2015 +0200
syncop: add seek() FOP
Add the new seek() FOP to the syncop framework. gfapi will use this in
the future.
Change-Id: I0c15153beb27de73d5844b6f692175750fc28f60
BUG: 1220173
Singed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11481
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 873a8316960c0bf7d0d28063bf0f04d3f74c3e6c
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jun 21 15:51:00 2015 +0200
core: add seek() FOP
Minimal infrastructure changes for the seek() FOP. This will provide
SEEK_HOLE and SEEK_DATA functionalities.
BUG: 1220173
Change-Id: I4b74fce8b0bad2f45291fd2c2b9e243c4f4a1aa9
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11480
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit be902bc5e3d2bbc3963a9ba6fb594e283fea832c
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jan 24 13:23:19 2016 +0100
Point users of glusterfs-hadoop to the upstream project
The code we have in glusterfs-hadoop/ is old and should not be used
anymore. The plugin for Hadoop HCFS is maintained at the
glusterfs-hadoop project on GitHub:
https://github.com/gluster/glusterfs-hadoop
Removing the old code from the repository, and adding a pointer to the
projects wiki in the MAINTAINERS file.
Change-Id: Ia86d08fb0c73a3f75b706b1e0793e3d7a0f4984c
BUG: 1301352
CC: Jay Vyas <jvyas@redhat.com>
CC: Bradley Childs <bchilds@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13286
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 71e9a15642051dae88078ac55f107d25b51dba54
Author: vmallika <vmallika@redhat.com>
Date: Tue Jan 5 17:50:09 2016 +0530
glusterd: register rpc notification for unix sockets
Previously only CLI was using unix socket to connect to glusterd,
and there was no need to register rpc callback notifications.
Now auxiliary mount process is started with unix socket option.
So we need to register register rpc notifications for unix sockets as
well.
Change-Id: I985839fc91c5c2674d85a7ec94ae24f47898c22d
BUG: 1295763
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13174
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit fc84075947b0df59a3e22e069503c6b745a458b0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Dec 30 10:17:00 2015 +0530
cluster/ec: Create this->itable in all cases
Problem:
glfsheal operates based on mount's volfile which doesn't have iamshd flag due
to which this->itable is NULL, this leads to "inode not found" logs in glfsheal
logs.
Fix:
Ec only allocates itable with 10 inodes, so allocating this->itable in all
cases in init.
Change-Id: I01d3c05e93a17007a4716a2d6f392d2aa306a34b
BUG: 1294743
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13112
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 42becea4c949125b11f70c9928f289bd19d15569
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jan 27 17:04:18 2016 +0530
features / bitrot: Prevent spurious pthread_cond_wait() wakeup
pthread_cond_wait() is prone to spurious wakeups and it's utmost
necessarry to check a boolean predicate for thread continuation.
See man(3) pthread_cond_wait() for details.
The following is done in bitrot scrubber:
if (list_empty (&fsscrub->scrublist))
pthread_cond_wait (&fsscrub->cond, &fsscrub->mutex);
followed by:
list_first_entry (&fsscrub->scrublist, ...)
A spurious wakeup from pthread_cond_wait() with the absence of
list_empty() check causes list_first_entry() to return garbage.
Change-Id: I08786b9686b5503fcad6127e4c2a2cfac4bb7849
BUG: 1302201
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/13302
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit fef066750a6d64e1fad024873063f8fea3ac1c1d
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jan 27 14:55:16 2016 +0530
snapshot: Decreasing VHD_SIZE to 300M
Decreasing the VHD_SIZE in snapshot.rc, as 1G
of lvs are not needed for test setups, and
allocating as much space might not allow the
tests to be run in some setups
Change-Id: I46ad0e2751301ba9f19f7ac548d41fa4521baa75
BUG: 1302234
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13297
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 2af75c1d3b15cc02b9dfdc81e3cda52ca53fa5b3
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Aug 5 16:02:49 2015 +0530
glusterd: improve error logs for unsupported clients
Change-Id: I90be46a7b25cc3efd0e61c9a145852e9027f5f64
BUG: 1302205
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11831
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit c7e2dd7bac03a9aabf3c3e5492e69a48f0d4e38c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jan 8 13:06:27 2016 +0530
cluster/afr: Move remaining gf_logs to gf_msgs
Change-Id: I48d9e5313bd3ccf9fe26c90a7051a8a174d75c49
BUG: 1296818
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/13195
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1e76c55f740661d03bc17c67d4cc3462df78bf23
Author: Pranith Kumar Karampuri <pkarampu@redhat.com>
Date: Wed Jan 27 03:25:37 2016 -0800
Revert "shard: add seek() FOP as not supported"
This reverts commit 2ce3daa94066dcc77cdc6b54a31747b6c7c0c2fc.
Change-Id: Ic00337a69e0a322b14c5cfdf68c06428c5da3a19
Reviewed-on: http://review.gluster.org/13301
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 4985c50c70da3389e2a65f441c506696f47372d1
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Dec 18 21:41:04 2015 +0100
shard: add seek() FOP as not supported
For getting basic support for SEEK_DATA/SEEK_HOLE, sharding has not been
implemented. Bug 1301647 has been filed to get this new feature in
sharding as well.
BUG: 1220173
Change-Id: I5c272855a21501ac31e1a5f4b68ed7245582c17c
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13290
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit bacc7550ea5ebf684857c775516d5da32d09b027
Author: Joseph Fernandes <josferna@redhat.com>
Date: Wed Jan 20 22:27:33 2016 +0530
tier/dht : Default value for demote-freq, max files and mb
Default value for tier-demote-frequency is 3600 sec to avoid
frequent demotions.
Default value for tier-max-mb is 4000 mb
Default value for tier-max-files is 10000 files
Change-Id: Ie60951c478a7462c425059699ab82511aa13fa0a
BUG: 1300412
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/13270
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 35fc4cf27145c31cddc24891d54b9f9ad8d3b388
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Jan 25 13:27:42 2016 +0530
cluster/tier: Ignore quota-deem-statfs for watermark calculation
The tier process watermark calculations were incorrect when the
quota-deem-statfs option was enabled. We now ignore this while
calculating hot tier usage to determine watermark levels.
Change-Id: I308bc24432e2fa5ad1d5703e80fc391433538bbb
BUG: 1301473
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/13288
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: mohammed rafi kc <rkavunga@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit d83bfcaaddcf97dd53dcc7133cca8d7efbc25d3a
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Jan 18 20:50:24 2016 +0100
NetBSD regression reliability: properly cleanup loopback devices
When a loopback device is configured and we forcibly unmount the
filesystem containing the backing store, further vnconfig -l will
complain "vnconfig: VNDIOCGET: Bad file descriptor" causing
failures.
We fix this by iterating on all loopback devices available in /dev,
testing for this condition and manually unconfiguring when it
happens.
BUG: 1129939
Change-Id: I17b956a8ed28a7767f2d0dda83b93c523d3238c2
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/13204
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 29f4321d9ae280ee091144ca25954d5bcfc7c871
Author: Jiffin Tony Thottan <jthottan@gmail.com>
Date: Thu Jan 14 15:07:47 2016 +0530
tests : Modifying crypt xlators unit tests
The "encryption.master-key" should be set before enabling crypt xlators.
Otherwise glusterfs client process(like gluster-NFS) will crash due to the
failure in intialising crypt xlator.
You can see the following messages in client log file
[2016-01-14 08:13:15.740835] E [crypt.c:4298:master_set_master_vol_key]
0-test1-crypt: FATAL: missing master key
[2016-01-14 08:13:15.740859] E [MSGID: 101019]
[xlator.c:429lator_init] 0-test1-crypt: Initialization of volume
'test1-crypt' failed, review your volfile again
[2016-01-14 08:13:15.740890] E [MSGID: 101066]
[graph.c:324:glusterfs_graph_init] 0-test1-crypt: initializing
translator failed
[2016-01-14 08:13:15.740904] E [MSGID: 101176]
[graph.c:670:glusterfs_graph_activate] 0-graph: init failed
[2016-01-14 08:13:15.741676] W [glusterfsd.c:1231:cleanup_and_exit]
(-->/usr/sbin/glusterfs(mgmt_getspec_cbk+0x307) [0x40d287]
-->/usr/sbin/glusterfs(glusterfs_process_volfp+0x117) [0x4086c7]
-->/usr/sbin/glusterfs(cleanup_and_exit+0x4d) [0x407e1d] ) 0-: received
signum (0), shutting down
Change-Id: I124deda505d128eacb15ca20fbdcd1593cb8eba3
BUG: 1298520
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/13240
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit ebc744825dc53a1eeb4c94cbf58d43bd6981dd96
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jan 3 12:57:29 2016 +0100
fuse: pass standard mount options to the kernel
Some of the default mount options were made invalid with glusterfs-3.6.
The /sbin/mount.glusterfs script changed heavily and now requires all
valid mount options to be listed. Earlier versions (glusterfs-3.5 and
before) passed all unknown mount options on to fuse.
With this change, all mount options from 'man 8 mount' are explicitly
included in the /sbin/mount.glusterfs script. Some of the options are
marked with TODO, these are not commonly used and may require some
additional support in Gluster/FUSE too.
BUG: 1294809
Change-Id: Ic312140d7318b54523996bb08772ff065af7eb27
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13166
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 501b7735b6d454de0042b3cf4ea197a9e6b19dc9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jan 13 16:19:15 2016 +0530
features/shard: Implement zerofill FOP
Change-Id: Iabb89a502cc560edd7fe3755623c74a2ccb853d5
BUG: 1261841
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13234
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 73ec19ec426dffb80ef74e9751fb733eaf8ef0e0
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jan 5 15:36:28 2016 +0530
tests: Fix spurious failure in bug-1221481-allow-fops-on-dir-split-brain.t.
Occasionally, when ls is executed, prior to READDIRP, a STAT is wound on
the operand directory. And AFR fails STAT with EIO if it is in metadata split-brain
which "dir" is in the test case in question. As a result, ls also fails with EIO,
causing test 20 to return negative exit status.
The fix is in the test script where the parts that cause the dir to go into
metadata split-brain have been removed. Now "dir" will only have entry
split-brain.
Change-Id: I4e4e6ba0a2401c7168719cd44e5f4f4bcb8fdd89
BUG: 1295702
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13172
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit b05e29bd709e2a76bb0ae4e269664f6aa5dc5534
Author: vmallika <vmallika@redhat.com>
Date: Mon Jan 18 23:31:59 2016 +0530
quota: start aux mount from glusterd with inet address
With below patches, quota aux mount now
uses unix domain socket to connect to
glusterd
http://review.gluster.org/#/c/12645/
http://review.gluster.org/#/c/12819/
When USS is enabled, snapd protocol client tries to
connect to glusterd with inet and fails,
because remote-host option by client process
is set to UDS file
This patch starts the aux client process from glusterd
with inet address
Change-Id: I6967043bfd8824658ea39bfd2842591fcc3280fd
BUG: 1299497
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13255
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 787fa0db6119ca60551ec85e12adbceb67f82dd0
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Jan 21 12:41:55 2016 +0530
protocol/server: Race between server_reconfigure and server_setvolume
During server_reconfigure we authenticate each connected clients
against the current options. To do this authentication we store
previous values in a dictionary during the connection establishment
phase (server_setvolume). If the authentication fails during
reconfigure then we will disconnect the transport.
Here it introduce a race between server_setvolume and reconfugure.
If a reconfigure called before doing a setvolume, the transport
will be disconnected
Change-Id: Icce2c28a171481327a06efd3901f8a5ee67b05ab
BUG: 1300564
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13271
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
commit 01479cb6d9566c8ccc68e46d77b2c9fd756434aa
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Jan 6 13:34:01 2016 +0000
afr : Check if dict is valid in afr_replies_interpret()
posix_mkdir does not send response xdata. So even though replies are
valid, the response xdata dict is NULL. Check if dict is non-null in
afr_replies_interpret before doing dict_get
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: If543d68d8bfd2433519105839d5be106076cc276
BUG: 1294053
Reviewed-on: http://review.gluster.org/13185
Tested-by: Ravishankar N <ravishankar@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit e8620fb7d60c8ee046db85f46bb5ba0b20e79a98
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jan 20 16:35:42 2016 +0530
tests: Move open-behind.t to bad tests list
Change-Id: I505e6dbd13d7922ac7468507c172764d64256389
BUG: 1300253
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13268
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6e62f058195ed735b98311b7b02d1d28cbeda5cc
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Jan 13 14:37:30 2016 +0530
tests: Fix sparse-file-self-heal.t
Psuedo Problem:
https://build.gluster.org/job/rackspace-regression-2GB-triggered/16682/consoleFull
The 'zeroedfile' disk usage comparision which is failing in this .t file
fails so only on XFS. The test passes when the backend is on a s̶a̶n̶e̶r̶
different filesystem like EXT4 or BTRFS. This is due to the speculative
preallocation in XFS which can reserve different disk space on different
XFS mounts for the same version and same file operation. See BZ 1277992
for an example of XFS behaviour.
Fix:
Don't compare the disk usage of the file on the bricks of the replica:
instead, check that the disk space consumed is atleast equal to the size
of the file.
Also remove sparse-file-self-heal.t from is_bad_test()
Change-Id: If43f59549136ebf91f17ff9d958954b3587afe56
BUG: 1298111
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13233
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
commit 172ab3da36b4cc8835421df9e80b908513c3dc97
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Jan 19 16:22:17 2016 +0530
snapshot: Return before redundant quorum check
As of today, we don't support creation of snapshot even
if one brick is down. Hence the older quorum check is
redundant. Returning after performing the check to
see if all bricks are up.
BUG: 1299819
Change-Id: I35661d05a15be0109aaae51b4fe0d5a8ca4333ad
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/13260
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
commit dc8752ebe890957668ab2575d1e381189a7810c5
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Jan 18 12:19:35 2016 +0530
cli: Add arbiter details to volinfo xml output
The following are added:
1. "<arbiterCount>1</arbiterCount>" and
"<coldarbiterCount>1</coldarbiterCount>"
2. "<isArbiter>0</isArbiter>" on the brick info, like so:
<brick
uuid="cafa8612-d7d4-4007-beea-72ae7477f3bb">127.0.0.2:/home/ravi/bricks/brick1
<name>127.0.0.2:/home/ravi/bricks/brick1</name>
<hostUuid>cafa8612-d7d4-4007-beea-72ae7477f3bb</hostUuid>
<isArbiter>0</isArbiter>
</brick>
Also fix a bug in gluster vol info where the abiter brick was shown the
wrong brick of the cold tier after performing a tier-attach.
Change-Id: Id978325d02b04f1a08856427827320e169169810
BUG: 1297750
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13229
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 7146ac92aa5f33b1f2f667ce1b4a0e7962786b6f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Oct 29 17:04:38 2015 +0530
features/shard: Implement fallocate FOP
Change-Id: I6f07074e94b115f6c6c2c59a8a1b58ba44b1c12a
BUG: 1261841
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13196
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit df141461d042bdaa81ae77cb0c6857687ee4e20b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Jan 11 12:58:16 2016 +0000
afr: skip healing data blocks for arbiter
1 ....but still do other parts of data-self-heal like restoring the time
and undo pending xattrs.
2. Perform undo_pending inside inodelks.
3. If arbiter is the only sink, do these other parts of data-self-heal
inside a single lock-unlock sequence.
Change-Id: I64c9d5b594375f852bfb73dee02c66a9a67a7176
BUG: 1286017
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12777
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6c8f153134dcee18011df66192388855b6555bd8
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Jan 14 16:11:27 2016 +0530
protocol/server: Fix memory corruption during client-table-expand.
gf_client_clienttable_expand frees up old entries after expanding. So,
cliententry should be reassigned to a free slot in new array of
cliententries. Earlier it used to point to a slot in oldentries
resulting in a use-after-free bug.
Thanks to Pranith for the assistance provided.
Change-Id: Iabe40c7df475471a7df7bccb302aef496ded3f1c
BUG: 1298498
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/13241
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 072b24e9e6546f10884ea5a0751c4342b2d0a336
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 8 16:43:15 2016 +0100
rpm: glusterfs-server requires -api
The glusterfs-server package requires libgfapi.so for the glfs-heal
binary and possibly other parts.
Also adding %{?_isa} to requirements as described in the Fedora
Packaging Guidelines for Explicit Requires at
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
BUG: 1296992
Change-Id: I96c62876b776d04a7f5d1b1dc34c02302b6ffbe6
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13200
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
commit 3690138003aa26c8a36e0fed85f8505ed3cbf757
Author: Michael Adam <obnox@samba.org>
Date: Mon Jan 4 18:50:38 2016 +0100
hook-scripts: S29CTDBsetup: clean and fix mount commands and options
This refactors the mount options of S29CTDBstart.sh into one
variable, removing the superfluous mentioning of 'default'.
The manual mount command is fixed to:
- also use the common options, thereby adding
_netdev,transport=tcp
(while this does not have an effect for the _netdev
option, it makes a difference for the transport option),
- also use the HOSTNAME variable just like the fstab entry,
- use a "/" in the remote location specification.
Hence it now behaves identically to the fstab mount.
Change-Id: Ibb7613b1b1278ab13745846baa79268db226ef19
BUG: 1295520
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/13170
Tested-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 20706007a573071b7c6c84ad4f3062792dee60d0
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jan 10 13:42:58 2016 +0100
build: place glupy under $prefix while installing
Regression testing on FreeBSD fails due to this error:
--- install-pyglupyPYTHON ---
/usr/home/jenkins/root/workspace/freebsd-smoke/install-sh -c -d '/usr/local/lib/python2.7/site-packages/gluster/glupy'
mkdir: /usr/local/lib/python2.7/site-packages/gluster: Permission denied
mkdir: /usr/local/lib/python2.7/site-packages/gluster: Permission denied
*** [install-pyglupyPYTHON] Error code 1
The installation prefix is set to "/build/install" and glupy should be
placed there as well. The default to "/usr/local" is incorrect.
Change-Id: I166412a271576f2344aecec94c7835f0fe9b1cf3
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13208
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 02f4a230c4e478c84d0799b96c7487c60f5f4cb7
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Thu Jan 14 09:57:47 2016 -0500
build: update link for .git/hooks/commit-msg
Add -L option to curl cmd to follow a redirect
Change-Id: I273248d2a610174cc3905b0ffb8f586deb191f5f
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13244
commit 9009c1b785c5ab6f13d01f5b7aad5193a486191f
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Jan 10 18:00:58 2016 +0100
POSIX shell compliance: == operator
POSIX shell uses = and not ==, the later being a bash extension.
BUG: 1129939
Change-Id: I9d51225de99c1607894211e68808b63100696fef
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/13209
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 0142a619d33b74e58b131a8743d0030d4431f478
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Dec 25 16:19:59 2015 +0100
scripts: correct the usage of -perm in backend-cleanup.sh
extras/backend-cleanup.sh uses deprecated find -perm +xxx syntax:
find [...] -perm +01000 [...]
This GNU extension syntax is deprecated and does not work in GNU
findutils 4.5.11 and later. Please change to find -perm /xxx instead.
The new syntax was introduced in 4.2.25 (October 2005) and should
therefore be available on any relevant system.
BUG: 1294223
Change-Id: Ice742957dd24f0ab4f70a8569dff6f2536e9ac1e
Reported-by: Andreas Metzler <ametzler@bebt.de>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13080
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 47e3d25112c241b65d535945a27eb74029320722
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Jan 13 11:34:27 2016 +0530
upcall: free the xdr* allocations
Free the xdr string allocations after decoding the upcall
cache_invalidation request.
Change-Id: I0ffc64f587d6c8566cba76cf08148f937a735926
BUG: 1295107
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/13232
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 415d13c4032822d3e8f0246ca3b822e9c3f7ab73
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Dec 31 16:39:21 2015 +0530
tests: include unistd.h for fdatasync
gcc throws a warning if unistd.h is not included.
Change-Id: I37f35f60c84fb6667a503696063a4c9987d8ab2f
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13128
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 4c94ada9f752c953a47b5d26dc8e05ad98f8796e
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Jan 11 16:17:29 2016 +0530
performance/write-behind: fix memory corruption
1. while handling short writes, __wb_fulfill_short_write would've freed
current request before moving on to next in the list if request is not
big enough to accomodate completed number of bytes. So, make sure to
save next member before invoking __wb_fulfill_short_write on current
request. Also handle the case where request is exactly the size of
remaining completed number of bytes.
2. When write request is unwound because there is a conflicting failed
liability, make sure its deleted from tempted list. Otherwise there
will be two unwinds (one as part handling a failed request in
wb_do_winds and another in wb_do_unwinds).
Change-Id: Id1b54430796b19b956d24b8d99ab0cdd5140e4f6
BUG: 1297373
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/13213
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 6216e529d0501a5fc5a867ce72049c3741993676
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jan 12 15:04:46 2016 +0530
gfapi: send lookup if inode_ctx is not set
During resolving of an entry or inode, if inode ctx
was not set, we will send a lookup to pupulate inode
ctx for every xlators
This patch also make sure that inode_ctx will be created
after every inode_link. We will store inode_ctx value as
LOOKUP_NEEDED if the inode is liked via readdirp, in all
other case we will store inode_ctx value as LOOKUP_NOT_NEEDED.
Change-Id: I3a10c298944200fa3862127187ae8988e582d352
BUG: 1297311
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13226
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 3c2b25dde76662e17a51d161ec0ada9a058d4809
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jan 12 12:54:42 2016 +0530
fuse: send lookup if inode_ctx is not set
During resolving of an entry or inode, if inode ctx
was not set, we will send a lookup.
This patch also make sure that inode_ctx will be created
after every inode_link
Change-Id: I4211533ca96a51b89d9f010fc57133470e52dc11
BUG: 1297311
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13225
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit ba40aa5c80d91331dd5658703059e592251189b5
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Aug 12 14:30:27 2015 +0530
fuse:sent at least one lookup before actual fop
Fuse shoud sent atleast one lookup for an inode/gfid
populated via readdirp before actual fop to populate
inode ctx for xlators
Change-Id: I5c02ed73f892924c9e404d91cbe0633a275accbd
BUG: 1236032
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11892
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 8b35ea8712fffaf44f736b94a76f3f9f2c440fef
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jan 12 12:04:59 2016 +0530
nfs: send lookup if inode_ctx is not set
During resolving of an entry or inode, if inode ctx
was not set, we will send a lookup.
This patch also make sure that inode_ctx will be created
after every inode_link.
Change-Id: I137a7e2510635ff4ea6d007b671961341f89c949
BUG: 1297311
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13224
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 2713a9024c2bb063b0c0e1743de33df205dc9151
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Dec 21 16:04:20 2015 +0530
cluster/ec: Get size and config for invalid inode
Problem:
After creating an inode and before linking it
to inode table, if there is a request to setattr
for that file, it fails and leads to crash.
Before linking inode to inode table ia_type is IA_INVAL
which will casue have_size and have_config as zero.
Solution:
Check and get size and config if an inode is invalid
Change-Id: I0c0e564940b1b9f351369a76ab14f6b4aa81f23b
BUG: 1293223
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13039
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit cf6229af93611be2a99e7f7209cb016218c14382
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jan 12 12:13:15 2016 +0530
snapview-client: remove check for parent inode type
In lookup call back path, we are checking for parent inode
type to make sure parent inode was set properly, so that
next op on the inode can be successfuly completed.
More info can be found at bugid 1297311
Change-Id: Ifb1b17f472f855f9b12088c3dd8328389d895e77
BUG: 1297311
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13227
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit cae8b788a156f87d20b0fe52ecabbb7517c4fd9e
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Jan 9 05:49:24 2016 +0100
Portability fix: rfc.sh
Function declaration in POSIX shell does not use the 'function' keyword.
This is bash-specific.
BUG: 1129939
Change-Id: Ifc2dddd0c0a99d2672aaa3aa1cdf18d0d1e38336
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/13206
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit a19ac90545e2355eff832c69d83e1bf2e9dbb0ae
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Jan 12 16:38:27 2016 +0530
tests/quota : fix failing test on auxiliary mount point
In test file tests/bugs/quota/bug-1049323.t, test "EXPECT "0" get_aux"
fails in Fedora.
In get_aux function we grep for "/var/run/gluster/<volname>" to check
if auxiliary mount point is created and we return 0 on success else we
return 1. In fedora, auxiliary mount point is created on
"/run/gluster/<volname>". So it fails on Fedora.
The patch fixes it by just grepping for "/run/gluster/<volname>".
Change-Id: Icb59395df4a98109eaa8199cbdbdedcd1cbef27a
BUG: 1297740
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/13228
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit b60e340b6d08a4636a0ea26aef659ccd090120af
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Dec 28 10:26:20 2015 +0100
scripts: prevent running 'showmount' from the start/post hook script
The 31ganesha-start.sh hook script tries to run 'showmount' to see if
the volume that is getting started should get exported by NFS-Ganesha.
It was reported that this caused the 'gluster volume start ...' command
to hang in case rpcbind is not running.
Instead of running 'showmount', we can use DBus to contact NFS-Ganesha
directly, and request the available exports. This will immediately fail
in case NFS-Ganesha is not running.
BUG: 1294446
Change-Id: I3aba1f86fead67116ca5adb1864a8be626c334fa
Reported-by: Jeff Darcy <jdarcy@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13098
Tested-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 927eaecbc61b102a4e43472c630c9fc814de6556
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Dec 30 16:19:44 2015 +0530
glusterd: GD_OP_VERSION should not be a released one
performance.resync-failed-syncs-after-fsync was
introduced after 3.7.6 was released. Hence it should
use 3_7_7 as op version not 3_7_6.
Change-Id: If4def1bf0fdc9fa4938ccb78308bec77eeaa2284
BUG: 1279730
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13117
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 49d15625bdb4daecea3a49edb1780870f8e419f7
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Dec 29 10:54:55 2015 +0530
glusterd/cli: mask out inaccurate scrub statistics
Some of the scrub statistics are inaccurate at the moment and would
successfully fool users at times. It's best to not display these
stats and stick to what is accurate.
Note that the change is only in the CLI part - glusterd (and brick)
supplies _all_ available scrub statistics, but CLI just selectively
sticks to what needs to be displayed.
Change-Id: Ia99f505a2cb10d5406cd37035d082e593f7e9a8c
BUG: 1285989
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/13105
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 6281f5f40d85cf3f25f7ad403b75a1ce93f6ce5d
Author: Michael Adam <obnox@samba.org>
Date: Mon Jan 4 18:21:51 2016 +0100
hook-scripts: remove RHS-2.0 reference from S29CTDB scripts
This is old. And such downstream reference should not
appear in upstream code.
Change-Id: Ifa0664dae0fe5ac913a49afe2fefa43b0112b024
BUG: 1295505
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/13169
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 6f7f200a9a57390f0aac750e68fa4f2b138b6dd8
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Dec 21 23:13:43 2015 +0530
glusterd: import/export brickinfo->uuid
Given a two node cluster with node N1 & N2, if a dummy node N3 is peer probed, the
probed node N3 goes for importing volumes from the probing node (N1), but
it still doesn't have information about the other node (N2) about its membership
(since peer update happens post volume updates) and hence fail to update its
brick's uuid. Post that even though N2 updates N3 about its membership the
brick's uuid was never generated. Now as a consequence when N3 initiates a
detach of N2, it checks whether the node to be detached has any bricks
configured by its respective uuid which is NULL in this case and hence it goes
ahead and removes the peer which ideally it shouldn't have (refer to
glusterd_friend_contains_vol_bricks () for the logic)
Fix is to export brick's uuid and import it at the probed node instead of
resolving it.
Change-Id: I2d88c72175347550a45ab12aff0ae248e56baa87
BUG: 1293414
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13047
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
commit 2c320891cab7f29fe9358d1d40a2962e48ddccf7
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Jan 8 10:36:37 2016 +0530
cluster/dht : Rebalance process crashes due to double fd_unref
The dst_fd was being unrefed twice in case the call
to __dht_rebalance_create_dst_file failed.
Change-Id: I56c5aff7fa3827887e67936b8aa1ecbd1a08a9e9
BUG: 1296611
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/13193
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 9868dd5d29e5b138c1061302ea5ba43d901ac12e
Author: James Augustine <jcaugust81@gmail.com>
Date: Wed Dec 16 14:56:11 2015 -0600
no-mtab (-n) mount option ignore next mount option
The -n option does not take any arguments. It seems like this shift is
removing the next option. On my CentOS 7 system, automount calls
mount.glusterfs with the parameters:
host:/volume /mountpoint -n -o rw,acl,_netdev
This causes the -o option to be siliently ignored.
Change-Id: Ice3c877f6ab346b04292e3dfed968d04d15077a5
BUG: 1297195
Signed-off-by: James Augustine <jcaugust81@gmail.com>
Reviewed-on: http://review.gluster.org/12988
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 862c765bb924a4adc41b6194d901cb8e5baf6234
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Dec 30 14:56:12 2015 +0530
features/bitrot: add check for corrupted object in f{stat}
Check for corrupted objects is done bt bitrot stub component
for data operations and such fops are denied processing by
returning EIO. These checks were not done for operations such
as get/set extended attribute, stat and the likes - IOW, stub
only blocked pure data operations.
However, its necessary to have these checks for certain other
fops, most importantly stat (and fstat). This is due to the
fact that clients could possibly get stale stat information
(such as size, {a,c,m}time) resulting in incorrect operation
of the application that rely on these fields. Note that, the
data that replication would take care of fetching good (and
correct) data, but the staleness of stat information could
lead to data inconsistencies (e.g., rebalance, tier).
Change-Id: I5a22780373b182a13f8d2c4ca6b7d9aa0ffbfca3
BUG: 1296399
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/13120
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 59a20bed6d18f9a14f94f75513a872d902683fea
Author: Michael Adam <obnox@samba.org>
Date: Mon Jan 4 16:45:19 2016 +0100
hook-scripts: remove outdated comment from C29CTDB start scipt
This script does not change Samba's config any more.
Change-Id: Ie6001f9a49006f95b291e24252dc362f2a7db14c
BUG: 1295504
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/13168
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 1b473028865558911325e57ae28df243abde3fb2
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Nov 4 14:55:27 2015 -0500
extras: add script to analyze regression-test failures
Often a test will fail quite frequently, but not so frequently that it
will fail twice in a row for the same patch. This allows it to "fly
beneath the radar" for quite a long time, slowing project-wide progress
until somebody crawls through the logs looking for patterns. This patch
adds a script to automate some of that process.
Change-Id: Ic74fbf6b0bfa34bffd9cb109fd51db019053e2cc
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/12510
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 506e2abb71c0465b242139682f5da7e5b2e5f86f
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Dec 30 21:07:54 2015 +0530
tests: use SIGKILL in cleanup, not SIGTERM
Sending a SIGTERM to test processes and waiting
a second for them to gracefully exit before
sending a SIGKILL seems like a waste of time.
Just send SIGKILL directly.
Change-Id: Icc73b07eae47876ba41955793a8daf77a964a0e0
BUG: 1294826
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13121
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 42536aadb9c44dacfb65ea8a5bdb47959358e4d5
Author: Dan Lambright <dlambrig@redhat.com>
Date: Mon Dec 28 10:57:53 2015 -0500
cluster/tier: allow db queries to be interruptable
A query to the database may take a long time if the database
has many entries. The tier daemon also sends IPC calls to the
bricks which can run slowly, espcially in RHEL6. While it is
possible to track down each such instance, the snapshot
feature should not be affected by database operations. It requires
no migration be underway. Therefore it is okay to pause tiering
at any time except when DHT is moving a file. This fix implements
this strategy by monitoring when control passes to DHT to
migrate a file using the GF_XATTR_FILE_MIGRATE_KEY trigger. If it
is not, the pause operation is successful.
Change-Id: I21f168b1bd424077ad5f38cf82f794060a1fabf6
BUG: 1287842
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/13104
Reviewed-by: Joseph Fernandes
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1707c13b2ac68fe6599e57b30bd6b944815f0b99
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Dec 30 15:25:30 2015 +0530
features/bitrot: Fail node-uuid getxattr if file is marked bad
If xattr is node-uuid and the inode is marked bad, fail getxattr
and fgetxattr with EIO. Returning EIO would result in AFR to
choose correct node-uuid coresponding to the subvolume where
the good copy of the file resides.
Change-Id: I45a42ca38f8322d2b10f3c4c48dc504521162b42
BUG: 1294786
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/13116
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit e355804846908c39681deac5573bba279d67dfc8
Author: vmallika <vmallika@redhat.com>
Date: Tue Dec 22 16:32:49 2015 +0530
quota: handle quota xattr removal when quota is enabled again
When a quota is disable and enabled again before completing
the cleanup operation, this can remove the new xattrs
and quota accounting can become wrong
Remove removing the xattr, check if quota enabled again and the
xattr is new
Change-Id: Idda216f1e7346a9b843dbc112ea3e6faa9c47483
BUG: 1293601
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13065
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 549f8b1060f65d7d9f6ed2da2dcbd693281073cb
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Jan 5 22:16:31 2016 +0530
performance/write-behind: maintain correct transit size in case of short writes.
1. Imagine a write when cache is filled with failed syncs.
2. This write won't be unwound since cache size has exceeded
configured limit.
3. With trickling-writes on by default, the last write request wont be
considered for winding when there is non zero in-transit size.
4. There was a bug in accounting of in-transit size when winds
resulted in short writes. Due to this bug, in-transit size used to be
non-zero even when there are no syncs in progress.
5. Due to 3 and 4, current write request won't be wound till there is
another write or fsync or flush from application. But application
can't do any other fop till current write request is unwound. This
resulted in deadlock and hence application would be hung in 'D'
state.
This patch fixes bug in accounting of in-transit size during short
writes.
Change-Id: I04ce8bb510efaaed7623cac38d69b32dbc3730ce
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
BUG: 1279730
Reviewed-on: http://review.gluster.org/13177
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f5098aad636fbc2810d80c8dffabea7e663c111f
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Dec 30 18:15:04 2015 +0530
vagrant-test: Exit on critical errors
There were quite a few places where exiting the script
made more sense.
More debug messages have been added.
Move back to top directory after the script is complete.
Change-Id: I2a66ee3a68c41a3acd0b7168c56b801fb5567e5f
BUG: 1291537
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13175
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Michael Adam <obnox@samba.org>
commit f291b07055b8c462ea549913e01681542918ef73
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Tue Jan 5 07:52:25 2016 -0500
dht: missleading indendentation, gcc-6
gcc-6 now has -Wmisleading-indentation as part of -Wall.
compiling with gcc-6 gives this warning.
...
dht-diskusage.c: In function ‘dht_subvol_has_err’:
dht-diskusage.c:361:33: warning: statement is indented as if it were
guarded by... [-Wmisleading-indentation]
goto out;
^~~~
dht-diskusage.c:358:25: note: ...this ‘if’ clause, but it is not
if (conf->decommissioned_bricks[i] &&
^~
...
Inspection of the source shows that without braces the loop is
terminated prematurely.
Change-Id: Ica48a8c59ee5d0a206797827d7920259d33b47ec
BUG: 1295784
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13176
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8cbf929995266cb749aa6f3790456f3eab9ddf5d
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue Dec 8 16:28:39 2015 +0530
api: Fix errno being set to EINVAL even on success
BUG: 1289068
Change-Id: I7905ac70a537f23e1844c097a24eaa6cb762fb82
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/12909
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 97d2bd502a763570cf48990a0d83a7b9609d6df9
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Sat Jan 2 23:34:54 2016 +0530
tier/create: store TIER_LINKFILE_GFID in xattr dictionary
In tier_create, a new key TIER_LINKFILE_GFID was introduced to
avoid a race in stale linkfile deletion. Storing this key in
xattr dictionary instead of using local->params dictionary.
Because local->params dictionary was also used to create the file
before stale linkfile deletion, that leads posix_create to fail,
trying to set the added key as extended attributes
Change-Id: I24fecb62b47bee65a1e86103925a67d13304c5df
BUG: 1290677
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13130
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 7bdf345981c6d97de3940b5fb46c731c9c8ef596
Author: Dan Lambright <dlambrig@redhat.com>
Date: Mon Dec 28 10:13:30 2015 -0500
cluster/tier: check watermark during migration
Currently we check the watermarks only before a cycle
begins. We should also check the hot tier's fullness
against the watermarks during the migration so the watermark
is not exceeded as files are promoted.
Change-Id: I2ff87a1c308d64fbdca14bbdf55f3ec3007290ae
BUG: 1293932
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/13103
Reviewed-by: Joseph Fernandes
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit 3915d3080f8d7aaf2ead5c69de230a434e13d1f1
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Dec 30 14:55:48 2015 +0530
cluster/tier: Additional details in error messages
Added file path/gfid when available to the tier log
messages to make debugging easier.
Change-Id: I22dda329367df2b846dcf254594312c997b66083
BUG: 1273043
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/13114
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 52c6b4b568cea5dd365f45f850e79227783b691c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Dec 29 12:42:30 2015 +0530
tier/glusterd: tier daemon not updating the status
Tier process is not updating the status when the process killed
mnually.
Change-Id: Ia5ea903af78ff3582da2242e6058f11c71923fab
BUG: 1294600
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13107
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bc35dee218711ec86a3fb113825ba6b48dedb743
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Dec 30 13:23:33 2015 +0530
wb: remove inline keyword
When compiled with -Werror flag gcc throws the following
error:
‘iov_length’ is static but used in inline
function ‘__wb_modify_write_request’ which is not static.
Let gcc decide what functions to inline and remove the inline
keyword.
Change-Id: I6d832596eefcf08306634936e11d2c8d4b8f9ccd
BUG: 1279730
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/13113
commit 4709822ebf246df50a177a2b0addf88d7bcb3112
Author: hari gowtham <hgowtham@redhat.com>
Date: Mon Dec 28 14:32:50 2015 +0530
Tier : typo in tier help
Change-Id: I75bca55901849cf725e02c782f75ff1e6054fddd
BUG: 1294448
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/13097
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit e787b217e3393deadee0fe48bfca7ca69f501a9d
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Dec 28 19:31:36 2015 +0530
tier/create: Dynamically allocate gfid memory
Currently we are storing the memory as a static pointer.
There is a chance to go that variable in out of scope.
So we should allocate in Dynamic way.
Change-Id: I096876deb8055ac3a44681599591a0a032bc0c24
BUG: 1290677
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13102
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 1be72e22e032cd1e7306eee5b285709c1600cbb7
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Dec 23 23:37:54 2015 +0530
tier/unlink: symlink failed to unlink
during unlink of a file, we will get stat just after
deleting the file, to see if the file is under migration or not.
but this stat call will fail for symlink if the actual file
was deleted.
So it is better not to send stat request from client if it is
a symlink as we are not migrating symlink.
Change-Id: Idc033b24fa3522b5261e579889d2195b43419682
BUG: 1293963
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13074
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 2f76a13b838e0f064ab514e0b22d0af788f038e5
Author: vmallika <vmallika@redhat.com>
Date: Mon Dec 28 17:33:26 2015 +0530
quota: limit xattr for subdir not healed on newly added bricks
DHT after creating missing directory, tries to heal the
xattrs. This xattrs operation fails as INTERNAL FOP key was not set
Change-Id: I819d373cf7073da014143d9ada908228ddcd140c
BUG: 1294479
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/13100
Reviewed-by: Susant Palai <spalai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit e76ff90efa88519afe9213e2096ba41d1b90c858
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Dec 24 15:22:05 2015 +0530
afr: Fix excessive logging in afr_accuse_smallfiles()
Commit 2b7226f9d3470d8fe4c98c1fddb06e7f641e364d did not check for the
validity of a dict before doing a dict_get. Fix that.
Change-Id: Ie21f4da19256b17196f242cd8fd5bb76b0a69c1e
BUG: 1294053
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13077
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 2a8e548e69a90b6d7bc4deef004a6ff384af5a38
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Tue Dec 22 12:05:39 2015 +0530
cli: should not dereference NULL pointer while printing bitrot scrub status
When user execute bitrot scrub status command and scrubber is
pending to do scrubbing then value of last_scrub time will be NULL.
Currently cli is dereferencing NULL pointer in this case, That might
lead to crash.
Fix is to use proper check condition while printing scrub status.
Change-Id: I3c4be8e25d089451c6ab77b16737c01d0348ee70
BUG: 1293558
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/13060
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit f591f381bb80ed733143b2d16390ab0a768c5a99
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Dec 21 12:07:51 2015 +0530
tests: handle bad objects during lookup/inode_refresh
Change-Id: I1848f0e9243c9376e0deba6738757350fe8b704a
BUG: 1290965
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13044
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 065eeb297ebe688e62049d8938c8e8306159d69d
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Nov 24 18:18:01 2015 +0530
tests: Introduce a Vagrant VM based test environment
This introduces a mechanism using which a developer
could easily test the Gluster code in a VM environment.
Also, it will help bring uniformity in the environments
used by various developers.
How to use:
1. git checkout -b custom-branch-name
2. Make changes
3. Execute ./run-tests-in-vagrant.sh
What happens in the background:
1. A new directory is created:
tests/vagrant/vagrant-custom-branch-name
It will serve as the Vagrant dir which has the
Vagrantfile and related ansible playbooks.
The VM is started using Vagrant and provisioned
using ansible.
2. The source dir is recursively copied over to the
VM under /home/vagrant/glusterfs.
3. Gluster is source installed in VM.
What happens in the foreground:
1. run-tests.sh is executed in VM using ssh and output is displayed
in the same terminal with option to use ctrl-c to interrupt the test
midway. The VM would still persist and you could ssh into it.
Also, you can checkout a different branch elsewhere and execute
run-tests-in-vagrant.sh there to get another VM which would
execute tests on that code.
If you wish to make some changes in the code, you could:
a. Change the code in host and run the script again to repeat
the whole process.
OR
b. vagrant ssh into the VM and make the changes in the VM.
Co-authored-by: Kaushal M <kaushal@redhat.com>
Co-authored-by: Michael Adam <obnox@samba.org>
Change-Id: Ic87801172c8b614cdecbdf2a765e1b3370a5faf7
BUG: 1291537
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/12753
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 32048fb436c8c4e92e90492bd40bdbe73b8b12ba
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Dec 23 13:57:14 2015 +0100
build: use 'make install' to install the hook scripts
The installation should be the same on all distributions, and doing
manual installation of files in the .spec is very ugly. This change adds
the rules so that 'make install' places the hook scripts in the right
location.
Also, the hook script(s) for NFS-Ganesha should be part of the
glusterfs-ganesha sub-package and got moved there.
BUG: 1174765
Change-Id: Iba25a7a5112c7d40db4c10ff4a5ac7a5fb4f7c4e
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/13072
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 05280ba1f8d9573d58d6067386747d352f456c8f
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Fri Dec 25 08:11:54 2015 -0500
glusterfs.spec.in: use %global per Fedora pkg guidelines
ref. recent emails in fedora-devel ml
See:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25global_preferred_over_.25define
and the thread beginning at
https://www.redhat.com/archives/fedora-packaging/2009-May/msg00095.html
Also fix a couple instances of %if ... %else ... %endif indentation
to be consistent with the rest of the .spec
Change-Id: Iaf7332fd8601d78bc0d8249033cff12a452654bf
BUG: 1294209
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13079
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 1183c2bce244e3ed7e535f8a15c8e0e6429e34ea
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Dec 11 15:15:53 2015 +0530
glusterd: correct ret code in glusterd_volume_status_copy_to_op_ctx_dict
This patch is to supress the error log of Failed to aggregate rsp_dict where the
above function returns a non zero ret which is not required
Change-Id: If331980291bd369690257215333cea175e2042ec
BUG: 1290734
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/12950
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
commit 5ef158b31cebc6a001f606f0bbe6df6378e54e75
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Dec 17 11:13:36 2015 +0530
glusterd: reduce friend update flood
When in a befriended state, glusterd would broadcast friend updates to
all other peers whenver a ACC or LOCAL_ACC event occurred.
When a downed glusterd came back up and established connections again,
this lead to a flood of friend updates to happen on the order of N^2 (N
is the number of peers in the cluster)
In larger clusters this was problematic, and could lead to very long
times for the cluster to settle down when a peer came back up. Multiple
peers coming back up at the same time would compound the problem.
Broadcasting of friend updates doesn't have much use in places other
that during a peer probe. Instead of broadcasting friend updates on
connection re-establishment, updates can just be exchanged between the
peers involved in the connection.
This patch changes the glusterd friend state-machine to send updates
only to the required peer for ACC or LOCAL_ACC events when in befriended
state. The number of updates sent now is in the order of N.
For a 10 node cluster, the number of updates reduced by 5 times. When
creating the 10 node cluster, the updates reduced from ~500 to ~150.
When a glusterd restarted, the number of exchanges reduced from ~160 to
~35.
BUG: 1292749
Change-Id: Ib6072090c7069b081d018cdaa3dc878819ab1d18
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/12999
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 344c4e68ce380d29a74b89db50e669c39510783f
Author: hari gowtham <hgowtham@redhat.com>
Date: Wed Dec 16 16:18:29 2015 +0530
Tier: "tier start force" command implementation
The start command doesnt restart the tier deamon if the deamon
is running at one node. hence to bring up the tierd on the nodes
where the deamon is down, the force command is implemented.
It skips the check for tierd running.
Change-Id: I0037d3e5ecfe56637d0da201a97903c435d26436
BUG: 1292112
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12983
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 82e48772c641a0298bb3da5fa9e9094dde6bfe21
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Dec 16 21:09:22 2015 +0530
cluster/dht : Ftruncate on migrating file fails with EINVAL
What:
If dht_open is called on a migrating file after the inode_ctx is set,
subsequent FOPs on that fd do not open the fd on the dst subvol.
This is seen when the open-ftruncate-close sequence is repeatedly
called on a migrating file.
A second call to the sequence described above causes dht_truncate_cbk
to call dht_truncate2 as the dht_inode_ctx was already set by the first
call. As dht_rebalance_in_progress_check is not called, the fd is not
opened on the dst subvol.
On a distributed-replicate volume, this causes AFR to
open the fd using afr_fix_open, but with the wrong flags, causing
posix_ftruncate to fail with EINVAL.
The fix: We require fd specific information to make a decision while
handling migrating files.
Set the fd_ctx to indicate the fd has been opened on the dst subvol
and check if it has been set while processing Phase1/Phase2 checks
in the FOP callback functions.
Change-Id: I43cdcd8017b4a11e18afdd210469de7cd9a5ef14
BUG: 1284823
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12985
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 326f40898f5cd029276bba72a2b715f3961f0758
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Fri Dec 18 07:44:45 2015 -0500
build: export minimum symbols from xlators for correct resolution
Revisiting http://review.gluster.org/#/c/11814/, which unintentionally
introduced warnings from libtool about the xlator .so names.
According to [1], the -module option must appear in the Makefile.am
file(s); if -module is defined in a macro, e.g. in configure(.ac),
then libtool will not recognize that this is a module and will emit a
warning.
[1]
http://www.gnu.org/software/automake/manual/automake.html#Libtool-Modules
Change-Id: Ifa5f9327d18d139597791c305aa10cc4410fb078
BUG: 1248669
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13003
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit a6b779b73aef4e071cf36a13eba247b253ee9a26
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Mon Dec 7 10:22:05 2015 -0500
core: add preadv, pwritev, pread, pwrite syscall wrappers
add additional system calls plus pick up a couple missed unwrapped
system calls that seem to have slipped into the master branch.
Change-Id: If268ccd5e9a139ac3ffd38293c67cd2f62ea5b58
BUG: 1289258
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12895
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit cbaf5dd81bc29b3c0dacf8c5828283b63e2306ec
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Dec 15 18:29:06 2015 +0530
ctr/sql: Providing for vol set for sqlcachesize and sqlWALsize and skip recording path
1. Providing vol set option for cache size and wal autocheck point
so that performance can be tuned.
2. Removed recording of file path in the db. Trimming database columns.
Path need not be stored in the db, as PARGFID, GFID, Basename is suffice
to derive the path during migration.
Change-Id: I2cb590451a6d244bc91fe66c6dbffe2c2059dfb8
BUG: 1293034
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12972
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 887b2bb04f799f7eded68a7d0d67dc8ef49a87e3
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Dec 22 12:29:32 2015 +0530
geo-rep: Fix getting subvol count
Tiering doesn't support disperse volume as hot tier,
hence xml output doesn't give 'hotdisperseCount'.
Remove the usage of 'hotdisperseCount' in geo-rep
and return 0 instead.
Change-Id: I736e29257de085a25e38eb02959caad3465ebcda
BUG: 1292084
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/13062
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vivek
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 40d8164e9c4196bbcaacbc14b9c3b80dc50fa6dd
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Dec 10 20:13:22 2015 +0530
tier:delete the linkfile if data file creation fails
If we are creating data file in a hot subvolume
then we will create a linkfile in cold subvolume.
Linkfile creation happens first. If linkfile creation
was successful and data file creation failed, then
linkfile in cold subvolume will become stale.
This patch will delete the linkfile as well, if data
file creation fails.
Also this code duplicates dht_create to make tier_create
Change-Id: I377a90dad47f288e9576c7323b23cf694a91a7a3
BUG: 1290677
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12948
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit d76b0072aa6c1179bc06fb5dbd6dec2fb4723cea
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Nov 17 12:57:54 2015 +0530
performance/write-behind: retry "failed syncs to backend"
1. When sync fails, the cached-write is still preserved unless there
is a flush/fsync waiting on it.
2. When a sync fails and there is a flush/fsync waiting on the
cached-write, the cache is thrown away and no further retries will
be made. In other words flush/fsync act as barriers for all the
previous writes. The behaviour of fsync acting as a barrier is
controlled by an option (see below for details). All previous
writes are either successfully synced to backend or forgotten in
case of an error. Without such barrier fop (especially flush which
is issued prior to a close), we end up retrying for ever even after
fd is closed.
3. If a fop is waiting on cached-write and syncing to backend fails,
the waiting fop is failed.
4. sync failures when no fop is waiting are ignored and are not
propagated to application. For eg.,
a. first attempt of sync of a cached-write w1 fails
b. second attempt of sync of w1 succeeds
If there are no fops dependent on w1 are issued b/w a and b,
application won't know about failure encountered in a.
5. The effect of repeated sync failures is that, there will be no
cache for future writes and they cannot be written behind.
fsync as a barrier and resync of cached writes post fsync failure:
==================================================================
Whether to keep retrying failed syncs post fsync is controlled by an
option "resync-failed-syncs-after-fsync". By default, this option is
set to "off".
If sync of "cached-writes issued before fsync" (to backend) fails,
this option configures whether to retry syncing them after fsync or
forget them. If set to on, cached-writes are retried till a "flush"
fop (or a successful sync) on sync failures. fsync itself is failed
irrespective of the value of this option, when there is a sync failure
of any cached-writes issued before fsync.
Change-Id: I6097c9257bfb9ee5b15616fbe6a0576ae9af369a
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
BUG: 1279730
Reviewed-on: http://review.gluster.org/12594
commit cc1f2634841f176be12b6e4ce80ddf7704541f74
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Dec 15 19:55:05 2015 +0530
libgfchangelog: Allocate logbuf_pool in master xlator
The master xlator needs to allocate 'logbuf_pool'
else 'gf_msg' fails with EINVAL.
Change-Id: I6b2d3450250de7e77126d12b75b0dbc4db414bfb
BUG: 1292463
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12997
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 58e88384cf64f01f51f369be8808d6e87025c405
Author: vmallika <vmallika@redhat.com>
Date: Wed Dec 9 13:13:17 2015 +0530
quota: fix backward compatibility of new quota volinfo option
quota-version features is implemented for 3.7.6
please see below patch for more details:
http://review.gluster.org/#/c/12386
As part of this feature, new volume info option 'quota-version'
was introduced, this can cause check-sum problem
when a one of the node in a cluster is upgraded to 3.7.6
(heterogeneous cluster)
So do a OP_VERSION check when storing this option
in volume info
Change-Id: Ic5b03a1e3f1236b645a065b1fadee7950307e191
BUG: 1283178
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12642
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit ce421c4fbd5c3a3e272f88a36d7fc4c72c157084
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Dec 17 17:41:08 2015 +0530
cluster/afr: Fix data loss due to race between sh and ongoing write
Problem:
When IO is happening on a file and a brick goes down comes back up
during this time, protocol/client translator attempts reopening of the
fd on the gfid handle of the file. But if another client renames this
file while a brick was down && writes were in progress on it, once this
brick is back up, there can be a race between reopening of the fd and
entry self-heal replaying the effect of the rename() on the sink brick.
If the reopening of the fd happens first, the application's writes
continue to go into the data blocks associated with the gfid.
Now entry-self-heal deletes 'src' and creates 'dst' file on the sink,
marking dst as a 'newentry'. Data self-heal is also completed on 'dst'
as a result and self-heal terminates. If at this point the application
is still writing to this fd, all writes on the file after self-heal
would go into the data blocks associated with this fd, which would be
lost once the fd is closed. The result - the 'dst' file on the source
and sink are not the same and there is no pending heal on the file,
leading to silent corruption on the sink.
Fix:
Leverage http://review.gluster.org/#/c/12816/ to ensure the gfid handle
path gets saved in .glusterfs/unlink until the fd is closed on the file.
During this time, when self-heal sends mknod() with gfid of the file,
do the following:
link() the gfid handle under .glusterfs/unlink to the new path to be
created in mknod() and
rename() the gfid handle to go back under .glusterfs/ab/cd/.
Change-Id: I86ef1f97a76ffe11f32653bb995f575f7648f798
BUG: 1292379
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/13001
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c690c8edb74a012ea5941c6335a51d3b58393965
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Dec 22 08:50:26 2015 +0530
tier/snap : Adding tier-snapshot.t to bad test
./tests/basic/tier/tier-snapshot.t to bad test
On RHEL6 the pause tier mechanism times out due to slow IPC calls
between the tier daemon and brick process. A workaround may be to
increase the timeout or improve the speed of RHEL6
Change-Id: I5af6123923416e611672ffe2aaea3f0dd7964dd9
BUG: 1293523
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/13056
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 4176a857cfba4e0f66fd9d310a1d9c9820517937
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Dec 21 10:09:53 2015 +0000
afr: warn if pending xattrs missing during init()
Since commit 6e635284a4411b816d4d860a28262c9e6dc4bd6a
(glusterfs-3.7.7), the afr pending xattrs are stored in the volfile and used
by afr when it initializes. If a cluster is upgraded, prevent afr from loading
until the op-version has been bumped up to 3.7.7 and the volfiles have been
regenerated using a volume set command.
Without this fix, AFR will crash when initialzing.
Change-Id: I14249dedb3f2f77cd754d78d8a9a70fdc5fc8c10
BUG: 1293293
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13038
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 70e9e7d2d8b95d09b827244d76a913c42f47dd83
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Dec 21 14:18:26 2015 +0530
tier/unlink: open fd for special file for fdstat
DUring unlink of a file, dht request stat to see whether
the file is under migration or not. But in posix_unlink
currently we are opening for regular files. so the fdstat
for special files are failing with EBAD
Change-Id: Ic0678e42e7701c3dffb91d98272e664b0fc646b5
BUG: 1293256
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13034
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 6a56e7d302026286606cb1c03d3a2f20d482d157
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed Dec 16 15:28:57 2015 -0500
cluster/tier: do not block in synctask created from pause tier
We had run sleep() in the pause tier callback. Blocking within
a synctask is dangerous. The sleep() call does not inform
the synctask scheduler that a thread is no longer running.
It therefore believes it is running. If a second synctask already
exists, it may not be able to run. This occurs if the thread
limit in the pool has been reached.
Note the pool size only grows when a synctask is created, not
when it is moved from wait state to run state, as is the case
when an FOP completes. When the tier is paused during migration,
synctasks already exist waiting for responses to FOPs to the
server with high probability.
The fix is to yield() in the RPC callback, which will place
the synctask into the wait queue and free up a thread for the
FOP callback. A timer wakes the callback after sufficient
time has elapsed for the pause to occur.
Change-Id: I6a947ee04c6e5649946cb6d8207ba17263a67fc6
BUG: 1267950
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12987
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit e1ad3d4692a4bfd745c161bc21cf96e6b922ede5
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Dec 16 17:16:36 2015 +0530
tier: Demotion failed if the file was renamed when it was in cold
During migration if the file is present we just open the file
in hashed subvol. Now if the linkfile present on hashed is just
linkfile to another subvol, we actually open in hashed subvol.
But subsequent operation will go to linkto subvol ie,
to non-hashed subvol. This operation will get failed
since we haven't opened d on non-hashed.
Change-Id: I9753ad3a48f0384c25509612ba76e7e10645add3
BUG: 1292067
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12980
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Susant Palai <spalai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 0037ada63cb8682522bfe5f5e291363f9f9b8abf
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Dec 15 13:32:29 2015 +0530
tier/dht : Properly free file descriptors during data migration
While tier migration, free src and dst fd's when create of
destination or open of source fails.
Change-Id: I62978a669c6c9fbab5fed9df2716b9b2ba00ddf1
BUG: 1291566
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12969
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit c04193f9302451c2fdd82abb5178b8f7ab4bcd83
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Wed Dec 16 18:04:55 2015 +0530
cli/xml: display correct xml output of tier volume
Currently When hot tier type is distributed-replicate and cold tier
type is disperse volume then #gluster volume info --xml command is
not giving its correct output. In case of HOT tier case its displaying
wrong volume type.
With this fix it will show correct xml output for tier volume
irrespective of all the type of the volume's.
Change-Id: If1de8d52d1e0ef3d0523163abed37b2b571715e8
BUG: 1292084
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/12982
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a6a7d9090c78556cad045e53f495d12c6261c0eb
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Dec 17 12:39:30 2015 +0530
geo-rep: Fix getting subvol number
Fix getting subvol number if the volume
type is tier. If the volume type was tier,
the subvol number was calculated incorrectly
and hence few of workers didn't become ACTIVE
resulting in files not being replicated from
corresponding brick. This patch addresses
the same.
Change-Id: Ic10ad7f09a0fa91b4bf2aa361dea3bd48be74853
BUG: 1292084
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12994
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 843b4de0585b56fc051ece8be17da285a1ce391d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sat Dec 12 11:49:20 2015 +0530
afr: handle bad objects during lookup/inode_refresh
If an object (file) is marked bad by bitrot, do not consider the brick
on which the object is present as a potential read subvolume for AFR
irrespective of the pending xattr values.
Also do not consider the brick containing the bad object while
performing afr_accuse_smallfiles(). Otherwise if the bad object's size
is bigger, we may end up considering that as the source.
Change-Id: I4abc68e51e5c43c5adfa56e1c00b46db22c88cf7
BUG: 1290965
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12955
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 77ae071706e23eb4c8adbb88c386239a902a3f51
Author: Anuradha Talur <atalur@redhat.com>
Date: Wed Dec 9 14:50:41 2015 +0530
heal : Do not print heal count on ENOTCONN
When a brick is not reachable due to ENOTCONN,
there are no entries gathered and this information
should not be printed.
It is a bug intorduced due to commit
9c378026e9561595586a817fee0b439e2c863a22, fixing it.
Change-Id: I45559a9560c297854ea6b4177f86e0be30dc6b78
BUG: 1250803
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12919
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 2ca49fc091fc34be9235937b8c504dc20499f66d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Dec 7 18:03:03 2015 +0530
afr: refresh inode using fstat
For fd based operations (fgetxattr, readv etc.) if an inode refresh is
required, do so using fstat instead of lookup. This is because the file
might have been deleted by another client before refresh but posix
mandates that FOPS using already open fds must still succeed.
Change-Id: Id5f71c3af4892b648eb747f363dffe6208e7ac09
BUG: 1285230
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12894
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit b291aeb96c90088c0506eecc442df18c30bf7630
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Dec 15 19:30:45 2015 -0500
cluster/tier: fix tier-max-files bookeeping and help
The option tier-max-files represents the maximum number
of files trasferred by a node in a gives cycle. Fix help message
to reflect the "per node" aspect. The code transferred one
more file per cycle than the given value.
Also change the default values of max file and max bytes to
very large values, effectively we will not throttle migration
unless the administrator requests it via CLI.
Change-Id: Ic2949ed3d8c35afe7c9ae4db72195603cfb2e28f
BUG: 1292671
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12984
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d99bed58ac08bb05d7dd4a0cd8a27b0501a2df0a
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Dec 9 13:46:17 2015 +0530
geo-rep: Symlink Rename issue
If ENTRY creation failed for symlink in Slave and symlink
renamed in Master. If Source not exists to Rename in Slave
Geo-rep interprets as Create of Target file. Geo-rep sends blob
of regular file to create symlink instead of sending blob of
symlink.
With this patch, Geo-rep identifies symlink and sends respective
blob.
BUG: 1289859
Change-Id: If9351974d1945141a1d3abb838b7d0de7591e48e
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/12917
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Tested-by: Milind Changire <mchangir@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit b4e793f3a1894c7be6829ff59b24366deeb467ec
Author: Michael Adam <obnox@samba.org>
Date: Fri Dec 11 00:37:13 2015 +0100
hook-scripts: fix S30Samba scripts on systemd systems
/etc/init.d/smb does not exist on systemd systems.
Using "service smb <COMMAND>" is the portable way.
It calls init scripts on sysv systems, and redirects
to systemctl on systemd systems.
Change-Id: I7146c9998a51d8b170d3321f3477e92704ae7615
BUG: 1290604
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/12945
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit e8029e77d43322c6067c767cf0cbe90646146f84
Author: Susant Palai <spalai@redhat.com>
Date: Wed Dec 2 04:59:55 2015 -0500
cluster/dht: Handle failure in getxattr
Problem: Currently even if we have received xattrs from any one of
the subvolume, we unwind with error in case the last subvol (which
unwinds) received a negative response.
To handle the case check if any of the subvolume has received
a response and pass it down.
Change-Id: Ia12a1f9671a6764f7550e6dc223324b1039fcc51
BUG: 1287539
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/12845
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1498103e7d54e13f25cbe145712e509a4f476948
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Nov 30 19:02:54 2015 +0530
tier:unlink during migration
files deleted during promotion were not deleting as the
files are moving from hashed to non-hashed.
On deleting a file that is undergoing promotion,
the unlink call is not sent to the dst file as the
hashed subvol == cached subvol. This causes
the file to reappear once the migration is complete.
This patch also fixes a problem with stale linkfile
deleting.
Change-Id: I4b02a498218c9d8eeaa4556fa4219e91e7fa71e5
BUG: 1282390
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12829
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 8a0340665d197df017746ca784965f3b5fb35433
Author: Michael Adam <obnox@samba.org>
Date: Wed Dec 9 18:57:59 2015 +0100
hook-scripts: don't let ctdb script change samba config
There are several reasons why the behaviour in
the hook scripts was bad:
1. A samba installation is clustered or non-clustered.
That does not change because of the availability
of the CTDB lock-volume. If the lock-volume is not
available (and hence CTDB is not available or not
healthy), then Samba won't be operational. But turning
it into a non-clustered Samba-installation can in
the worst case lead to data corruption if clients
manage to access the same files (on share volumes).
Hence 'clustering = yes/no' in Samba's config should
not be touched.
In particular, Samba should not be stopped/started by
the hook script. If needed, then ctdb will take care
of it.
2. Changing the idmap configuration is potentially
dangerous as well. In particular the used tdb2
backend is legacy nowadays and should not be used
any more in new installs. (I stems from the times
when ctdb could not host persistent databases.)
Changing the idmap can result in loss of access
to files or in giving access to files where it is
not intended.
3. The pattern used for detecting need for change is
fragile. It may or may not play well possible
manual changes to smb.conf.
This change removes the parts that change the smb.conf
file and start or stop Samba from the S29CTDB* hook scripts.
Change-Id: I72f7aabafa8f089da4531fca2572a72c22825bcc
BUG: 1290151
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/12930
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit c7655a511dfb41bdd61855ad7f92da5de56a7b10
Author: Jiffin Tony Thottan <jthottan@gmail.com>
Date: Mon Dec 14 15:29:21 2015 +0530
nfs : Inform client to perform extra GETATTR call for 'T' files
Due to the changes from http://review.gluster.org/#/c/12722/,
for tier volume the readirp will be send only to cold subvol,
therefore the resulting list may contain 'T' files. For those
files, by performing additional getattr call will populate the
attributes correctly. This check should be based on inode value
passed from the readdirp(both T files and directory have NULL
value) and skip directory in the same.
Change-Id: Ieb6724b05301cdbf0a0ef15ad9db51014faa0457
BUG: 1291212
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/12960
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 416ae3af1e8b344c16a92a23534ecbaafbfcab33
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Nov 25 15:25:26 2015 +0530
features/bit-rot-stub: delete the link for bad object in quarantine directory
When the bad object is deleted (as of now manually from the backend itself),
along with its gfid handle, the entry for the bad object in the quarantne
directory is left as it is (it also can be removed manually though). But the
next lookup of the object upon not finding it in the backend, sends forget on
the in-memory inode. If the stale link for the gfid still exists in the
quarantine directory, bir-rot-stub will unlink the entry in its forget or in
the next failed lookup on that object with errno being ENOENT.
Change-Id: If84292d3e44707dfa11fa29023b3d9f691b8f0f3
BUG: 1285241
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/12743
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit c89da874972f6face3fcb77bc777bb79453761a5
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Dec 15 14:39:25 2015 +0530
tier/glusterd: Only positive values for freq-thresholds
Fixed error handling for validation for freq-thresholds
Change-Id: Ibe3a9752ac0b525b0c8c0d6c4b4e4d694bd91b88
BUG: 1291603
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12970
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 5f9518b01089513669ec94e4a5c3c66bd24c7700
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Dec 15 18:48:20 2015 +0530
cluster/afr: During name heal, propagate EIO only on gfid or type mismatch
When the disk associated with a brick returns EIO during lookup, chances are
that name heal would return an EIO because one of the syncop_XXX() operations
as part of it returned an EIO. This is inherently treated by afr_lookup_selfheal_wrap()
as a split-brain and the lookup is aborted prematurely with EIO even if it
succeeded on the other replica(s).
Change-Id: Ib9b7f2974bff8e206897bb4f689f0482264c61e5
BUG: 1291701
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12973
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 8638aab8739b16a3b83f4ebacc76c3b4c066d318
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Nov 25 09:49:19 2015 +0530
glusterd/afr: store afr pending xattrs as a volume option
Problem:
When AFR xlator initialises, it uses the name of the client xlators
below it for storing the pending changelogs (xattrs). This can be
problem when some other xlator is loaded in between AFR and the client.
Though that is a trivial 'traverse-graph-till-the-client-and-use-the-name'
fix in AFR's init(), there are other issues like when there's no client
xlator at all when, say, AFR is moved to the server side.
Fix:
The client xlator names are currenly unique and stored as
brickinfo->brick_ids. So persist these ids as comma separated values in
AFR's volume_options and use them as xattr values during init().
Change-Id: Ie761ffeb3373a4c4d85ad05c84a768c4188aa90d
BUG: 1285152
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12738
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 6d0de0383ab971db214fa6d1fd3d0f808f53c1e3
Author: hari gowtham <hgowtham@redhat.com>
Date: Fri Dec 4 18:34:36 2015 +0530
tier/glusterd : making new tier detach command throw warning
For detach tier, the validation was done using the string "detach-tier"
but the new commands used has the string "tier". Making the string use
"tier" to compare, creates problem as the tier status and tier detach
have the keyword "tier". So tier detach and tier status were separated.
and strtok was used to prevent the condition from passing when the
volume name has a substring of "tier". (only the second word from the
string is got and checked if the feature is tier)
Problem: new detach tier command doesnt throw warnings like
"not a tier volume" or " detach tier not started" respectively
instead it prints empty output.
Fix: while validate the volume is checked if its a tiered volume
if yes it is checked if the detach tier is started, else a warning
is thrown respectively.
Change-Id: I94246d53b18ab0e9406beaf459eaddb7c5b766c2
BUG: 1288517
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12883
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bbc29cf7a021da5d52216324046135f5e5bd6650
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Wed Aug 12 01:09:41 2015 +0530
glusterd: DEBUG log should not come after resetting client log level
After resetting diagnostics.client-log-level option still DEBUG log is
logging in scrubber and bitrot log file. After resetting any option
value of that options goes to default value.
This patch will set the default value of client and brick log level to
"INFO" log level.
Change-Id: I4cf04754dcf5ddc908dae4d9bdf525cfcd6cc2bd
BUG: 1252696
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/11887
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit c890f2bee5826468f9546b7e636aeb4bda471ef6
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Dec 15 12:05:25 2015 +0530
test: Move tests/bugs/tier/bug-1286974.t to bad test
Moving this bug into bad test as it causes some spurious
failures
Change-Id: I5fe491858283374e5a061a48c50ac5a02a2941fa
BUG: 1251592
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12967
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b4a176611d0f24bd78aac75f6d2b83fe5bb171d9
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Nov 26 14:35:49 2015 +0530
storage/posix: Implement .unlink directory
Problem: For EC volume, If a file descriptor is open and
file has been unlinked, any further write on that fd will
fail. When a write request comes, EC internally reads some
blocks using anonymous fd. This read will fail as the file
has already been unlinked.
Solution: To solve this issue, we are using .unlink directory
to keep track of unlinked file. If a file is to be unlinked
while its fd is open, move this to .unlink directory and unlink
it from .glusterfs and real path. Once all the fd will be closed,
remove this entry form .unlink directory.
Change-Id: I8344edb0d340bdb883dc46458c16edbc336916b9
BUG: 1286029
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/12816
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 843ab60723608d996fb14068b238a98aa27c6f30
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Dec 10 18:53:37 2015 +0530
features/changelog: Remove incorrect error message
During changelog_rollover, the rename error is
logged even though changelog rollover is successful.
This got mistakenly added as part of commit
64e6836ac8fb96f38a859eea0d8525cd9bd2693f
(http://review.gluster.org/10532). Removing the
same.
Change-Id: I7ac1a16b41de5a6a4d7e714946585dff3ce0e83b
BUG: 1290421
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12940
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 25e159b285a2b72c76c8fc23bb26f980c02acde4
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Wed Nov 25 17:38:43 2015 +0530
bitrot: getting correct value of scrub stat's
When user execute bitrot scrub status command then gluster
is not giving correct value of Number of Scrubbed files,
Number of Unsigned files, Last completed scrub time,
Duration of last scrub.
With this patch scrub status will give correct value for
all the above fields.
Change-Id: Ic966f76d22db5b0c889e6386a1c2219afbda1f49
BUG: 1285989
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12776
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 2c9bc3c76d984794d422c1bfde4dd2827bf1c801
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Dec 1 15:24:11 2015 +0530
bitrot: Update 'scrub status' cmd in man page
Update following bitrot status command in man page.
gluster vol bitrot <volname> scrub status
Change-Id: I86aa123d568711c6b3d655b60cfd901a8d4c3408
BUG: 1286988
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12834
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 6633de83eacf8df7ef56903535ab75144be3a0ce
Author: Joseph Fernandes <josferna@redhat.com>
Date: Sat Dec 12 15:21:06 2015 +0530
dht/rebalance: Use seperate return variable for destination cleanup
Use seperate local return variable for destination cleanup,
without messing with the function return variable.
Change-Id: Iaea9ed2927234fdb888aef7a31ec362090e98196
BUG: 1290975
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12956
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 2506abeb1a1ab8153d1a8cc7dcfd9a1791c8c9d4
Author: Michael Adam <obnox@samba.org>
Date: Mon Nov 30 11:38:15 2015 +0100
tests:bugs:fuse: add setup.sh and teardown.sh to facilitate manual testing
Change-Id: Ia8fe402663bbdabdc10c18ab42a2063466eb42b6
BUG: 1286735
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/12830
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 3a6a5976f81a4a95400f147ac942c1889ab76653
Author: Michael Adam <obnox@samba.org>
Date: Mon Nov 30 10:51:13 2015 +0100
tests:bugs:fuse: add test for bug #1283103 - selinux mount vs security xattrs
BUG: 1283103
Change-Id: Ic4485d650275f67eb6b0b8382a92eb829c06e27c
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/12827
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 3c4e0a7dd7f791898a99b785c7073cb00d02ba47
Author: Alex Markelov <alex@markelov.org>
Date: Sat Oct 31 08:30:08 2015 +0000
Add support for sparse files to tarssh method
Without '--sparse' option tar will not properly archive sparse file
and geo-replication will result in non-sparse file on the remote end.
Here is more on how I arrived at this
http://markelov.org/wiki/index.php/GlusterFS_3.6.1_on_CentOS_6.5:_geo-replication_and_sparse_files_problem
Change-Id: I8d671964a1b48bbb916e4a064571221bf3631494
BUG: 1276839
Signed-off-by: Alex Markelov <alex@markelov.org>
Reviewed-on: http://review.gluster.org/12476
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 7a5eeba07d4de5568c8510621b2e99a82b9e795f
Author: Anuradha Talur <atalur@redhat.com>
Date: Tue Dec 8 17:02:23 2015 +0530
features/index : Prevent logging due to NULL dict
Added a check for non-NULLness of dict before
performing dict_foreach_match on it.
Change-Id: I77d83559934006425ed33745b8a244b2f5d90cb1
BUG: 1250803
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12910
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit afa9ba6a1d6345b509b04f5caf63bb46ad070ef6
Author: Michael Adam <obnox@samba.org>
Date: Wed Nov 18 09:01:30 2015 +0100
fuse: forbid only access to security.selinux xattr if not mounted with 'selinux'
Originally, all selinux.* xattrs were forbidden, causing
for example Samba's acl_xattr module which uses security.NTACL
to fail without the 'selinux' mount option, which is confusing
at least. This change specializes the check to the security.selinux
attribute, so other selinux.* attributes work with or without the option.
Change-Id: I9d3083123efbf403f20572cfb325a300ce2e90d9
BUG: 1283103
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/12826
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 4259aa5f58d204aba7d6a182372494162d357654
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Dec 8 14:31:30 2015 +0530
tests, shard: Remove dependency on strict-write-ordering
Change-Id: I00171a77bdefb1c2e7e4610cb0ade5679bdb761f
BUG: 1289840
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12915
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit b461e8c0deeee9487be00e9d8b916ca2a6cf21db
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Dec 10 12:33:05 2015 +0530
tests: Fix arbiter-statfs.t
..and remove it from bad tests list.
Problem:
https://build.gluster.org/job/rackspace-netbsd7-regression-triggered/12516/consoleFull
++ SETUP_LOOP /d/backends/brick1
++ '[' 1 '!=' 1 ']'
++ backend=/d/backends/brick1
++ case ${OSTYPE} in
+++ awk -F: '/not in use/{print $1; exit}'
+++ vnconfig -l
vnconfig: VNDIOCGET: Bad file descriptor
++ vnd=
++ '[' x = x ']'
++ echo 'no more vnd'
no more vnd
++ return 1
Fix:
TEST the return value of SETUP_LOOP.
Also added EXIT_EARLY to the test case because there is no point in
continuing the test when setting the bricks fail.
Change-Id: I933611c41f93ac646f1170b62db656314c801ef1
BUG: 1290125
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12936
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 330c2ed71789b10834c05219a9aaf5ca45675d2e
Author: anand <anekkunt@redhat.com>
Date: Tue Dec 1 14:30:40 2015 +0530
glusterd: Maintain per transaction op-info object
Issues: Since in op-sm transactions a mix of access to global op-info & per transaction
op-info objects are used, the correctness of op-info object may go for a toss resulting
into incorrect response getting passed back to cli
Fix: Use per transaction op-info object
Change-Id: Ice023bace3e137dfd8e7b13bd5b53545a79a203f
BUG: 1287027
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/12836
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 2f9764fa34bf665b750a9bd90ffcce392d31fca9
Author: N Balachandran <nbalacha@redhat.com>
Date: Wed Dec 9 19:36:42 2015 +0530
tests/tier: spurious failure in rename test
bug-1279376-rename-demoted-file.t fails sometimes
The fix is based on the assumption that the test
failed because the demotion happened too quickly.
Change-Id: Ieccc736f387fcf6afaa72fa9918adb6dd34f2c8a
BUG: 1289845
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12926
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 60eaa066f508ed4b6facc3743f846cb80592048b
Author: Susant Palai <spalai@redhat.com>
Date: Wed Dec 9 03:53:45 2015 -0500
storage/posix: fix dict leak in posix_fgetxattr
Change-Id: I8c53805993570e6f37786dde2103cb884c026791
BUG: 1285230
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/12916
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit ec64b90028fcc80098429815c8e276822062cc6f
Author: Ravishankar N <root@ravi2.(none)>
Date: Wed Dec 2 08:20:46 2015 +0000
glusterd: add pending_node only if hxlator_count is valid
Fixes a regression introduced by commit
0ef62933649392051e73fe01c028e41baddec489 . See BZ for bug
description.
Problem:
To perform GLUSTERD_BRICK_XLATOR_OP, the rpc requires number of xlators (n) the
op needs to be performed on and the xlator names are populated in dictionary
with xl-0, xl-1... xl-n-1 as keys. When Volume heal full is executed, for each
replica group, glustershd on the local node may or may not be selected to
perform heal by glusterd. XLATOR_OP rpc should be sent to the shd running on
the same node by glusterd only when glustershd on that node is selected at
least once. This bug occurs when glusterd sends the rpc to local glustershd
even when it is not selected for any of the replica groups.
Fix:
Don't send the rpc to local glustershd when it is not selected even once.
Change-Id: I2c8217a8f00f6ad5d0c6a67fa56e476457803e08
BUG: 1287503
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12843
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 265ff157cd035c99483402c9a350228f06df1a09
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu Nov 26 14:33:14 2015 +0530
tier/ctr: Check filename in ctr_lookup for nameless lookup
Check filename in ctr_lookup for nameless lookup
Change-Id: I1ab3f658e3b9fee708f6986d1990f16db920d2fb
BUG: 1285663
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12760
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit b3cee20368831b4a05f4f7f26aadce8e27b77f5b
Author: Michael Adam <obnox@samba.org>
Date: Thu Dec 10 01:27:53 2015 +0100
tests: mark several tests as bad
There are currently several spurious tests.
We should bundle adding them to the bad test list
into one patch so that they don't prevent each other's
regression runs from succeeding...
Failing on Linux:
=================
tests/basic/afr/split-brain-healing.t:
https://build.gluster.org/job/rackspace-regression-2GB-triggered/16680/consoleFull
tests/basic/afr/sparse-file-self-heal.t:
https://build.gluster.org/job/rackspace-regression-2GB-triggered/16682/consoleFull
tests/basic/afr/replace-brick-self-heal.t:
https://build.gluster.org/job/rackspace-regression-2GB-triggered/16681/consoleFull
tests/bugs/tier/bug-1279376-rename-demoted-file.t:
https://build.gluster.org/job/rackspace-regression-2GB-triggered/16675/consoleFull
this one thows core:
tests/bugs/snapshot/bug-1140162-file-snapshot-features-encrypt-opts-validation.t
https://build.gluster.org/job/rackspace-regression-2GB-triggered/16674/consoleFull
Failing on NetBSD:
==================
tests/basic/afr/arbiter-statfs.t:
https://build.gluster.org/job/rackspace-netbsd7-regression-triggered/12551/consoleFull
tests/features/weighted-rebalance.t:
https://build.gluster.org/job/rackspace-netbsd7-regression-triggered/12538/consoleFull
Change-Id: I1f48d5631d761b5d3e736bfd918f483bdbd36c5a
BUG: 1290270
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/12933
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 1a5a6f0bb6bfe4cff75b5d15ee3a1402207d86b1
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Dec 8 19:55:22 2015 +0530
tier/dht: files are still going to decommissioned subvol
After detach tier start, creates are still going to hot
tier. Because when creating data files we are not checking for
decommissioned bricks.
Change-Id: I8e28258d9b2367dcc8ad6e5e91d0e54d92fdf771
BUG: 1289602
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12914
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 725a1b041760b48f390530ad1c3e5f218cc8a315
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Dec 8 18:56:31 2015 +0530
tier : Spawn promotion or demotion thread depending on local bricks
Spawn Promotion or Demotion depending if there are any Cold or Hot
bricks present localy.
IF the local HOT brick list is empty dont spawn demote thread.
IF the local COLD brick list is empty dont spawn promote thread.
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Change-Id: I524730e59414dd156c78ec0bd7a3629212697e6e
BUG: 1289578
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12912
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 4478a34fe57fa556eb2cf265139c6fd6c3714e31
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Dec 8 11:06:33 2015 +0530
tests/bug-924726.t: fix grep pattern to get correct glusterfs pid
Change-Id: Ia2444b1b3e45e3e224bcd59e780a0f38c492f133
BUG: 1289428
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/12906
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8eb83e0f57802cb6b3554646cfd99398e52408fa
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Dec 8 19:06:24 2015 +0530
tests: fix brick_up_status
The brick_up_status function wasn't correct after the introduction of
the RDMA port into the `volume status` output.
It has been fixed to use the XML brick status of a specific brick
instead of normal CLI output.
Change-Id: I5327e1a32b1c6f326bc3def735d0daa9ea320074
BUG: 1289584
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/12913
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 63df4c3f8b50d7b1af2edf8942db648da11284b0
Author: Michael Adam <obnox@samba.org>
Date: Wed Dec 9 09:59:40 2015 +0100
glusterd: fix the build
Fix the build broken in 6e9f88cfd4c80c6af7260e5e6537cb76b6c0
Change-Id: I0c5cedff980688cb47f3f0e9f4968c23d2f507d3
BUG: 1289869
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/12918
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
commit dcc6fad8a252b9f604563dd993c20a50021a587f
Author: vmallika <vmallika@redhat.com>
Date: Fri Dec 4 16:51:18 2015 +0530
quota: copy quota_version value in func glusterd_volinfo_dup
quota_version is a new variable introduced for
quota xattr versioning feature.
quota_version was not copied when creating duplicate
volinfo in function 'glusterd_volinfo_dup'
so any feature like snapshot/tiering using
glusterd_volinfo_dup will get the default value
of quota_version instead of the correct number
and can cause a problem
Change-Id: I7b0f418002d49aa7210e2e741e65ee5b2593e6a6
BUG: 1288474
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12881
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 0d85bc7b77dc76f378ce37afc39825fe8120aa9b
Author: vmallika <vmallika@redhat.com>
Date: Thu Dec 3 14:55:36 2015 +0530
glusterd/quota: quota-version conflict in export/import volinfo
When exporting/importing voinfo during handshake,
quota conf and quota xattr version were using same key
'quota-version' and updated wrong values when importing
quota version values.
Change-Id: If939d6f5bc4851d4114963877be72dda21834f0f
BUG: 1287996
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12865
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 448df995361b5d952e454a66d14b118112978050
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Dec 1 09:11:01 2015 +0000
tier/glusterd: Check before starting tier daemon during volume start
We start tier daemon when volume is started without looking into the
previous status. The problem with that if detach-tier is started
and then volume force start is actually starting tier daemon.
This is also fixes a problem where tier daemon is not starting
after detach stop.
Change-Id: I15b56a711e12f0e24f5ab123561258bd448621f7
BUG: 1286974
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12833
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a5575d26bb3abceb14888501eeccc8e5aae4db8a
Author: Susant Palai <spalai@redhat.com>
Date: Wed Nov 25 05:07:03 2015 -0500
posix: fix posix_fgetxattr to return the correct error
posix_fgetxattr used to not updating op_ret
and op_errno (initialized to -1 and ENOENT respectively)
on success cases. Hence, it can return ENOENT even if all
the opertions were sucessful.
Change-Id: I5db3c1821208166a052d734b0be2553d009b8ee4
BUG: 1285230
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/12745
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit d6f969785c128631b576e501c897d8d351d59be1
Author: vmallika <vmallika@redhat.com>
Date: Fri Dec 4 12:36:22 2015 +0530
quota: add 'quota-version' to xlator volume_options structure
Below error is seen in brick log:
0-vol1-quota: option 'quota-version' is not recognized
So add this option to the volume_options structure of
marker xlator
Change-Id: I1bd68a537936ee0f9af85dac74f1377f84edb8f4
BUG: 1283178
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12878
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ed4e778189a01e9f6ed9416d2a5df79c2a85cc2b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Dec 8 12:47:42 2015 +0530
features/shard: Do not update inode-ctx size (again) after xattrop
This is to fix race between parallel writevs that could mess up
the file size value in inode ctx.
Thanks to Pranith for helping with RCA'ing the issue.
Change-Id: Ief94e0b3bcd87a8e2391fb39af1b99d020abd764
BUG: 1289447
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12907
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a5e1a351903cb990410f0341a3173a31788d50c1
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Nov 25 00:04:39 2015 +0530
cli/quota: show used_space,(file,dir) count even when quota limit is not set
Problem:
As of now quota 'list/list-objects' will list the usage only if limit is
set for every directory else it will fail with ENOATTR(If inode/inode-quota
is already configured for the first time).
Feature:
With the patch we are enhancing this command to list the usage even
if quota limit is not set but still the user has to configure
inode/inode-quota for the first time.
Example:
Consider we have /client/dir and /client1(absolute path from mount point):
Quota limit is set only on /client. when we try listing /client/dir or /client1,
it shows "Limit not set".
Fix:
The patch fixes this by showing "used space" in case of list command and
shows "file_count" & "dir_count" in case of list-objects command. This works
fine with xml output as well.
Change-Id: I68b08ec77a583b3c7f39fe4d6b15d3d77adb095a
BUG: 1284752
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/12741
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 648be83103744336739a46f3707853ecfb104246
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Dec 7 13:32:57 2015 +0530
cluster/tier : Fix double free in tier process
The tier process tries to free ipc_ctr_params twice
if the syncop_ipc call in tier_process_ctr_query fails.
ipc_ctr_params is freed when ctr_ipc_in_dict is freed.
But ctr_ipc_out_dict is NULL when syncop_ipc fails, causing
GF_FREE to be called on a non-NULL ipc_ctr_params ptr again.
Change-Id: Ia15f36dfbcd97be5524588beb7caad5cb79efdb4
BUG: 1288995
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12890
Reviewed-by: Joseph Fernandes
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit ece135bdc515863294ff2efd21240806111b3c82
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Dec 3 14:54:32 2015 +0530
glusterd: Disallow peer with existing volumes to be probed in cluster
As of now we do allow peer to get added in the trusted storage pool even if it
has a volume configured. This is definitely not a supported configuration and
can lead to issues as we never claim to support merging clusters. A single node
running a standalone volume can be considered as a cluster.
Change-Id: Id0cf42d6e5f20d6bfdb7ee19d860eee67c7c45be
BUG: 1287992
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/12864
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 62990f54406001f1db643abcfd1133c5cd44df22
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Dec 6 22:05:54 2015 +0530
mount/fuse: Fix use-after-free crash
fouh->len is accessed after 'node' is freed. Also 'rv' is int where as
fouh->len is uint32, changed comparison to ssize_t variables.
BUG: 1288857
Change-Id: Ied43d29e1e52719f9b52fe839cee31ce65711eea
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12886
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2df153614f1db5afdf4965eba3c13dcbef251701
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu Dec 3 15:40:16 2015 +0530
tier/dht: Fix mem leak from lookup response dict
Fixing memory leak from response dict during a parent
lookup to get the path.
Change-Id: I60c23d0b25e7f763f0e53c40e71ee053aba6d555
BUG: 1288019
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12867
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
Tested-by: Joseph Fernandes
commit bfbc07a8ba7d1e3c670f650a3c3ca18a5b6faa90
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu Nov 26 12:42:17 2015 +0530
tier/tier: Ignoring status of already migrated files
Ignore the status of already migrated files and in the
process don't count.
Change-Id: Idba6402508d51a4285ac96742c6edf797ee51b6a
BUG: 1276141
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12758
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit e08fd09a0747744eb3edec68e4145de8b0cd0e6c
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Thu Dec 3 17:41:13 2015 +0530
glusterd: disable ping timer b/w glusterd and make epoll thread count to 1
Currently glusterd is crashing when enable/disable heal and i/o is in
progress on the fuse mount.
This is because of by default multi thread epoll in glusterd is 2.
Workaround is to make epoll thread to 1 and set ping-timeout to 0
Change-Id: Ifbe9b43a361c5409b707539f0ee831c610a5c36b
BUG: 1288059
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/12874
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 334f97ac7bcd8992d7ee84b082840d543726fb9a
Author: Patrick Uiterwijk <puiterwijk@redhat.com>
Date: Mon Aug 18 16:45:21 2014 -0400
Make rfc.sh show what its actually doing
Change-Id: Ifb9246a2680e5f985871d4209b46dd803979c2e1
BUG: 1131275
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
Reviewed-on: http://review.gluster.org/8496
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit dc4866f870ed4edbbb6716dc80fbffffed0f97a4
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed Dec 2 17:13:00 2015 -0500
tests: add bug-924726.t to ignore list
bug-924726.t has had spurious errors in regression tests.
Change-Id: I5514e90909c3ecdd487c0dcf501ebf0952dc4fbb
BUG: 1287872
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12859
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit ec6651f9e26f53dbf715a48a4484dcbef41477de
Author: N Balachandran <nbalacha@redhat.com>
Date: Thu Dec 3 12:52:54 2015 +0530
cluster/tier: fix loading tier.so into glusterd
glusterd occasionally loads shared libraries of translators. This
failed for tiering due to a reference to dht_methods which is defined
as a global variable which is not necessary.
The global variable has been removed and this is now a member of
dht_conf and is now initialised in the *_init calls.
Change-Id: Ifa0a21e3962b5cd8d9b927ef1d087d3b25312953
BUG: 1287842
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12863
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 16b5f7a8f929c14df530ae59d5075e41eb334e83
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Tue Dec 1 19:14:08 2015 +0530
glusterd: stop daemon services upon peer detach correctly
Problem:
Currently glusterd is stopping all the daemons service upon peer detach.
If user have multi node cluster and if user want to detach any node
from the cluster, and detached node having stand alone volume then upon
detaching glusterd stopping all the daemon's of the detached node,
which is having running volume.
Fix:
Upon peer detach it should do peer detach cleanup properly and it should
stop only those daemon on the node on which it require.
Change-Id: I98b8099166f82e235ded6d02261f59a6511a003b
BUG: 1287455
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/12838
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit cb5f97a817d5f73a98f8cbf5e5c2b86ac62e9555
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Wed Dec 2 14:26:47 2015 +0530
geo-rep: use cold tier bricks for namespace operations
Problem:
symlinks are not getting synced to slave in a Tiering based volume.
Solution:
Now, symlinks are created directly in cold tier bricks( in the backend).
Earlier, cold tier was avoided for namespace operations and only
hot tier was used while processing changelogs.
Now, cold tier is HASH subvolume in a Tiering volume.
So, carry out namespace operation only in cold tier subvolume and
avoid hot tier subvolume to avoid any races.
Earlier, XSYNC was used(and changeloghistory avoided) during initial sync
in order to avoid race while processing historychangelog in Hot tier.
This is no longer required as there is no race from Hot tier.
Also, avoid both live and history changelog ENTRY operations from Hot tier to avoid any race with cold tier.
Change-Id: Ia8fbb7ae037f5b6cb683f36c0df5c3fc2894636e
BUG: 1287519
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/12844
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit c6b8cacc38f2c34fb37c1b05d58e476afb5f1a46
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Dec 2 21:19:56 2015 +0100
fuse: pass default SElinux mount options on to the kernel
In order to set default SElinux contexts on a Gluster mount, the
standard SElinux mount options need to be passed to the kernel. The
mount(8) manual page lists "context", "fscontext", "defcontext" and
"rootcontext" as valid options.
BUG: 1287763
Change-Id: I015fe27e4c6ff36a030e3480b23141aca2d91fc2
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/12858
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
commit 45579932abdef36e87afc488c0870ec60c90a83c
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Nov 9 13:37:53 2015 +0530
snapshot/clone : Fix tier pause failure for snapshot clone
On a tiered volume, snapshot clone fails while trying to
pause tier, as we pass volname(snap) to the brick_op_phase module,
which tries to look for the snap volume amongst regular
volumes, and obviously doesn't find it and fail.
Well as snapshot volumes are read only volume, and will not
have tiering daemon acting upon them, there is really no need
to pause tiereing while taking clone of snapshot volumes. Hence
removing the code to pause and resume tiering during clone create.
Change-Id: I2266aba589a830a13a806c0d8a56fd8855143ccd
BUG: 1279327
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/12548
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 831986fbe4a9d22e9daaf9d276555b00e7493b13
Author: Joseph Fernandes <josferna@redhat.com>
Date: Mon Nov 30 16:51:35 2015 +0530
tier/libgfdb/sql: Correcting logic in sql query for read
Correcting query in the where clause
from "a & b | c"
to "a & (b | c)"
where "a" is the condition to join the gf_file_tb and gf_flink_tb
through gfids
"b" is the condition for the write heat
and "c" is the condition for read heat
Change-Id: I99226d82b0efb68fbef3a40f02b215bb2b4370d6
BUG: 1286656
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12823
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e01b1fbf9385d032d6b2c87285eaf03d4cce19a9
Author: Anuradha Talur <atalur@redhat.com>
Date: Mon Nov 23 15:56:28 2015 +0530
heal : Changed heal info to process all indices directories
Change-Id: Ida863844e14309b6526c1b8434273fbf05c410d2
BUG: 1250803
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12658
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0a4f5c738d9b954db24459a562dab6ba984d3c1b
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Nov 2 17:49:44 2015 +0530
snapshot: Fix quorum check for clone
snapshot clone was not performing quorum check
and was just relying on glusterd server quorum.
Wrote glusterd_snap_quorum_check_for_clone(), to
perform the same. Also moved common quorum check code
from glusterd_snap_quorum_check_for_create(), to
glusterd_snap_common_quorum_chk_clone_create() to be
shared by both
Change-Id: Ib78c709186841780876de8ef7d7c9243b7f67995
BUG: 1276023
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/12490
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit d03cb730ad00f8629c791ef068bae3dbebdb113f
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Wed Sep 23 12:21:40 2015 +0530
geo-rep: geo-rep to handle CAPS based Hostname
Problem:
geo-replication session creation fails when Hostname
is having CAPS in it.
Issue is with the regex pattern which handles only small lettered
Hostname.
Fix:
Fix the regex pattern to handle CAPS based hostname as well.
Change-Id: I5c99c102e9706acc2b1fab1e6bf158e68beed373
BUG: 1265522
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/12216
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f2d47a2dbf37d28b31e52c29e9bde29d39b35448
Author: Michael Adam <obnox@samba.org>
Date: Mon Nov 30 13:35:23 2015 +0100
extras: fix deprecation warining in checkpatch.pl
Left braces in patterns need to be escaped.
Otherwise, for perl >= 5.16, we get a warning:
"Unescaped left brace in regex is deprecated, passed through in regex;"
This patch fixes the relevant braces.
Hence perl -c ./examples/checkpatch.pl is clean again.
Change-Id: I938c9c262239f53de57d30a2cff7030f22e63dc1
BUG: 1198849
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/12828
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1ed58c32130b20326bd65fc839b118e70996a53e
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Nov 24 10:31:35 2015 +0530
glusterd:Removing error message in glusterd log during upgrade
when one of the gluster node is upgraded to 3.7 from a lower
version and a mixed cluster is formed, tier related error
messages are displayed in the glusterd log which are removed
Change-Id: I8d0fc43ce049990a6a52306317ea1298a0a91390
BUG: 1282461
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12587
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 0dd9a4206519a279962dbab728fcc72063516aa7
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Nov 25 18:34:29 2015 +0530
geo-rep: fd close and fcntl issue
When any of the open fd of a file is closed
on which fcntl lock is taken even though another
fd of the same file is open on which lock is taken,
all fcntl locks will be released. This causes both
replica workers to be ACTIVE sometimes. This patche
fixes that issue.
Change-Id: I1e203ab0e29442275338276deb56d09e5679329c
BUG: 1285488
Original-Author: Aravinda VK <avishwan@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12752
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit cd2b0b9cef2bfa55a24cc35b2d28d115f2c7062f
Author: Joseph Fernandes <josferna@redhat.com>
Date: Sat Nov 28 17:03:41 2015 +0530
tier/glusterd : Validation for frequency thresholds and record-counters
1) if record-counters is set to off
check if both the frequency thresholds are non-zero, then pop
an error message, with volume set failed.
2) if record-counters is set to on
check if both the frequency thresholds are zero, then pop
an note, but volume set is not failed.
3) If any of the frequency thresholds are set to a non-zero value,
switch record-counters on, if not already on
4) If both the frequency thresholds are set to zero,
switch record-counters off, if not already off
NOTE: In this fix we have
1) removed unnecessary ctr vol set options.
2) changed ctr_hardlink_heal_expire_period to ctr_lookupheal_link_timeout
Change-Id: Ie7ccfd3f6e021056905a79de5a3d8f199312f315
BUG: 1286346
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12780
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 7c401f3ca17e8feec8132970a43e1d7e99e64bd0
Author: Cedric Buissart <cbuissar@redhat.com>
Date: Mon Nov 16 15:32:29 2015 +0100
glusterd-ganesha xlator parser for ganesha-ha.conf
The current method for parsing ganesha-ha.conf is prone to issues :
Before the patch :
- no double quote leads to segfault
e.g. : HA_CLUSTER_NODES=server1,server2
- no check for comments.
e.g. : #HA_CLUSTER_NODES="server1,server2"
would be used if preceding the real value
This is an attempt to a cleaner parser:
1- factorization of parsing code, creating 1 dedicated, more generic
parser
2- double quote are no longer mandatory
3- should not segfault
4- lines are no longer limited to 1024 chars
Resolves RHBZ 1283211
Change-Id: I75f11461fe1b84915d1c5cfe945b47bd81abc2b1
BUG: 1283211
Signed-off-by: Cedric Buissart <cbuissar@redhat.com>
Reviewed-on: http://review.gluster.org/12588
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit e53e232a3ee5a92906550e3ccb3649bbfd3b9c48
Author: Anoop C S <anoopcs@redhat.com>
Date: Mon Nov 23 12:20:09 2015 +0530
build: Remove redundant options from GF_CFLAGS
While configuring, GF_CFLAGS is being populated with redudndant
options as follows:
Normal mode:
GF_CFLAGS = -g -O2 -g -O2 -Wformat -Werror=format-security \
-g -O2 -g -O2 -Wformat -Werror=format-security \
-Werror=implicit-function-declaration
Debug mode:
GF_CFLAGS = -g -O2 -g -O0 -DDEBUG -Wformat -Werror=format-security \
-g -O2 -g -O0 -DDEBUG -Wformat -Werror=format-security \
-Werror=implicit-function-declaration
This patch is to remove this redundancy of options.
Change-Id: Idf6f2536c2a8ae24ba257681fbe9dfdb8bfa4f19
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/12714
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c48ac5271771fc8ab7cf9db7d6d5672dfdccac2b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 1 10:59:41 2015 +0530
cluster/ec: Create copy of dict for setting internal xattrs
Problem:
Ec takes a ref of the request xdata and sets trusted.ec.version/algo etc xattrs
as part of it. But this request xdata could be using same dictionary to do the
operation on multiple subvolumes, due to which other subvolumes will have
internal xattrs of ec in it and will be created on subvols where they are not
supposed to appear.
Fix:
Take a copy of the request xdata/dict to prevent this from happening.
Most of the debugging work and test script is contributed by Nitya.
BUG: 1286910
Change-Id: If146435dfb89656158dbed3862a3e9a0cda60581
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12831
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit a2dd58eafdcef5404fd8ab6674b93b149e6345de
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Nov 20 17:50:50 2015 +0530
defaults: Add 'GF_EVENT_UPCALL' to default_notify
Fix a regression caused by commit#If7d59d
Change-Id: Ib2239b9b0e216302e6c89e21288592d35b8d124b
BUG: 1283983
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/12708
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fa919a8e0141defe9381e41a875ee692232c4093
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Nov 27 12:09:22 2015 +0530
Upcall: Read gfid from iatt in case of invalid inode
When any file/dir is looked upon for the first time, inode
created shall be invalid till it gets linked to the inode table.
In such cases, read the gfid from the iatt structure returned
as part of such fops for UPCALL processing.
Change-Id: Ie5eb2f3be18c34cf7ef172e126c9db5ef7a8512b
BUG: 1283983
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/12773
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 1a0fb162f394a91ad128e8610af390f495c5f232
Author: Anuradha Talur <atalur@redhat.com>
Date: Thu Nov 12 19:45:10 2015 +0530
cluster/afr : Readdirp performance enhancement
Things done :
1) during lookup and inode_refresh as part of read_txn,
request is sent to detect if heal is required or not.
2) If heal is required, be conservative in setting the
readdirp entry inodes to NULL, otherwise don't be.
3) Self-heal-daemon now crawls both indices/xattrop
and indices/dirty directory while healing.
Change-Id: Ic4a4da63fb7e0726eab5f341a200859b29cf7eb7
BUG: 1250803
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12507
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 7446f2733cf6564cd48678542c65d773f09ba5bf
Author: Mohamed Ashiq <mliyazud@redhat.com>
Date: Mon Nov 9 22:09:34 2015 +0530
quota: vol quota fails when transport.socket.bind-address is set in glusterd
When glusterd is binded to specific IP quota fails, since the server is
hardcoded to localhost. IP can be assigned in the glusterd part of quota,
but IP is not populated in cli part. So Quota makes use of glusterfsd's unix
domain socket transport type.
Change-Id: Ib03332cc203795456ee6087017cea08eed3d7417
BUG: 1277105
Signed-off-by: Mohamed Ashiq <mliyazud@redhat.com>
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/12489
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 7686060dc11312e8b1e3cb96f330f28c17938928
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Fri Nov 27 11:18:00 2015 +0530
cli/geo-rep : remove unused code
Change-Id: I8a8e27b4d6c35ea5e57bd0b556fd2c6ab7b496ab
BUG: 1285968
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/12771
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit a204c1db3d60b65b5c2ceed9da20d8005a7dea2b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Nov 26 13:59:30 2015 +0530
features/shard: Set ctime to 0 in fsync callback
... to indicate to md-cache that it should not be caching
file attributes.
Change-Id: Iaef9bf7fec8008ca47d682b4b15984f26421bcd6
BUG: 1285660
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12759
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 36d6a134f19f7afbe43d7777f718ccff14d8c689
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Tue Nov 17 15:11:40 2015 +0530
dht : changing variable type to avoid overflow
For layout computation we find total size of the cluster
and store it in an unsigned 32 bit variable. For large
clusters this value may overflow which leads to wrong
computations and for some bricks the layout may overflow.
Hence using unsigned 64 bit to handle large values.
Change-Id: I7c3ba26ea2c4158065ea9e74705a7ede1b6759c7
BUG: 1282751
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/12597
Reviewed-by: Susant Palai <spalai@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 49c54b0687fd3cc9e986cafa694288471807466a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Nov 26 09:58:39 2015 +0530
features/bit-rot: Fix NULL dereference
Problem:
By the time br_stub_worker is accessing this->private in it's
thread, 'init' may not have set 'this->private = priv'. This
leads to NULL dereference leading to brick crash.
Fix:
Set this->private before launching these threads.
Change-Id: Ic797eb195fdd0c70d19f28d0b97bc0181fd3dd2f
BUG: 1285616
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12754
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit f6a1f5947a07777bde8909c5388c0a7343a53390
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Thu Nov 26 12:32:10 2015 +0530
glusterd: glusterfsd to support volfile-server-transport type "unix"
If glusterfsd uses transport type "unix", 'addrstr' can be empty. So,
it may fail to fetch the trusted volfile in this case. This patch allows
to fetch volfile even if addrstr is empty.
Change-Id: I831c5cd0b07b90ae843ec63f0fad9241d9407f6b
BUG: 1279484
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Signed-off-by: Mohamed Ashiq <mliyazud@redhat.com>
Reviewed-on: http://review.gluster.org/12757
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 55567f0c8cea4196cadf3dd5b7d9469000abe151
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Nov 24 20:59:29 2015 +0530
glusterd/tier: Reset to reconfigured values after detach-tier
After detach-tier commit , we have to reset the option
reconfigured for tier volume
Change-Id: Iae0210259720d6ac14ccc0cc339dc9f54a0c4571
BUG: 1285046
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12736
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 738b44301ac205ae211bf8729be26625338e555e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Nov 26 10:27:37 2015 +0530
cluster/afr: change data self-heal size check for arbiter
Size mismatch should consider that arbiter brick will have zero size file to
prevent data self-heal to spuriously trigger/assuming need of self-heals.
Change-Id: I179775d604236b9c8abfa360657abbb36abae829
BUG: 1285634
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12755
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit aa69c337e6d17ff2815be08afca7857040951565
Author: hari gowtham <hgowtham@redhat.com>
Date: Mon Nov 23 11:58:52 2015 +0530
Tiering: change of error message for "v tier <vname> detach status"
If the volume was not a tiered volume then empty status was being
printed instead of an error message.
Change-Id: I13ccb16e1562966976a48d9365ced4c8a124de59
BUG: 1284357
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12713
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 2522b08d0d8469069aeff741fd3bbcd81bf26937
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Nov 25 12:31:25 2015 +0530
cluster/afr: Remember flags sent by create fop
Problem:
In create fop, afr doesn't remember the flags. When afr has to perform
fixing of the fd that needs to be opened on other bricks because the brick
was down at the time of create, the flags with which it needs to send open
are not present.
Fix:
Remember the flags in the fd_ctx.
Thanks to Nitya for showing us the problem in re-open with the flags.
Change-Id: I8ce1eb50c35fc0722cfc25cb4b6d234ef56180e5
BUG: 1285173
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12739
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 41ecaf3f76291536d3208f08253894c1898d8f94
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Nov 25 16:42:20 2015 +0530
cli: Indicate which brick of the replica is the arbiter
Enhances the cli output for arbiter volumes as requested in the BZ.
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: I28cc34d7d19def043d54291cede25a58dbcc5051
BUG: 1285288
Reviewed-on: http://review.gluster.org/12747
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a58536f848f7dd1207732f519539221dc132c580
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Nov 24 13:45:20 2015 +0530
glusterd: copy snapshot object during duplication of volfile
When creating duplicate volfile for hot/cold tier, we need to
copy the snapshot object in to volfile as it requires to generate
snapshot brick volfile.
Change-Id: I39ccfa20cd1c16ef2801901e3cd3a31c76f8995d
BUG: 1284789
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12734
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
commit 5bf154a2eefc2c09f09c77949c6203709f145cc4
Author: Joseph Fernandes <josferna@redhat.com>
Date: Wed Nov 25 22:52:48 2015 +0530
tier/test: Fixing tests/basic/tier/legacy-many.t
Change-Id: Icbd83afdeac053aec5b3b8fa19665a2908e87d8e
BUG: 1285483
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12751
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit c9df9ab16dd992ff4a85d2bde4a84c5085f607a0
Author: Joseph Fernandes <josferna@redhat.com>
Date: Sat Nov 21 01:04:21 2015 +0530
tier/ctr: Correcting rename logic
Problem: When a file with old_file_name and GFID_1 is renamed with a new_file_name
which already exists and with GFID_2, this is what happens in linux internaly.
a. "new_file_name" is unlinked for GFID_2
b. a hardlink "new_file_name" is created to GFID_1
c. "old_file_name" hardlink is unlinked for GFID_2.
Well this is all internal to linux, and gluster just issues a rename system call
at POSIX layer. But CTR Xlator doesn't delete the entries corresponding to the
"new_file_name" and GFID_2. Thus leaving the stale entry in the DB.
The following are the implications.
a. Promotion are tried on these stale entries which will fail and show
false results in the status of migration,
b. GFID_2 Files with 2 hardlinks, which will have only one hardlink
after the rename will not be promoted or demoted as the DB shows 2 entries.
Solution: Delete the older database entry for the replaced hardlink
Change-Id: I4eafa0872253e29ff1f0bec4283bcfc579ecf0e2
BUG: 1284090
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12711
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit aa7df4ffa54d5043d1053ab34402049ef94579a2
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Nov 23 12:05:54 2015 +0530
glusterd: Change volume start into v3 framework
As part of volume start, if the volume is of tier type
then we need to start tiering daemon also. But before
starting tier daemon all the bricks should be started.
So by changing volume start into v3 framework, we can
do tier start in post validate phase
Change-Id: If921067f4739e6b9a3239fc5717696eaf382c22a
BUG: 1284372
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12718
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 5dba2d8fa9dc090ce37d508c260ad92cab922639
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Oct 15 15:01:23 2015 +0530
tools/glusterfind: add query command to list files
When session information is maintained outside Gluster, there needs to
be some mechanism to list files starting from a time-stamp. This patch
implements the feature via the "query" command-line option.
The only caveat is that the first time the query command is run for the
volume, it will likely report that "historical changelogs are not
available". This is due to the fact that changelogs had not been turned
on for the volume so far. So the volume options need to be turned on
outside glusterfind or the since_time need to be greater than the
current time when the query command is run for the very first time for
the volume. The query command turns on the required volume options for
collecting changelogs.
Change-Id: I6cb7a57a5ecd166210e2eb4deede06d40ccfa996
BUG: 1272006
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/12362
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit ef220bf25fbc00214d9a5ee045e49f5bff73e6cb
Author: Anuradha Talur <atalur@redhat.com>
Date: Thu Nov 12 19:41:33 2015 +0530
features/index : Readdirp performance improvement
Things done :
Index now maintains two different directories :
1) for pending xattrs (trusted.afr.volname-client-n,
trusted.ec.dirty)
2) for on going xattrs (trusted.afr.dirty)
Based on the xattr, index decides the directory
to add/del entry in/from.
Change-Id: Ie04c02ea2d862cf80426a871a9a1e80b0773d9fd
BUG: 1250803
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12468
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a02fe395f164d80b958a0c1a4e220ab549e8c7e9
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Mon Nov 23 17:00:07 2015 +0530
glusterd/bitrot : Integration of bad files from bitd with scrub status command
Currently scrub status command is not displaying list of all the bad files. All
the bad files are avaliable in the bitd daemon.
With this patch it will dispaly list of all the bad file's in the scrub
status command.
Change-Id: If09babafaf5d7cf158fa79119abbf5b986027748
BUG: 1207627
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/12720
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 2cac4adbdb37710d7fb2881089e1128328ec87d0
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Nov 23 13:06:25 2015 +0530
features/shard: Eliminate extra update to postbuf in writev
After an extending write is complete, shard translator updates postbuf
at two places:
1. shard_update_file_size_cbk(), and
2. shard_post_update_size_writev_handler().
This can lead to unexpected behavior if md-cache is part of the client
stack and caches and serves values returned by shard translator in
postbuf. This patch eliminates the update to postbuf in
shard_post_update_size_writev_handler().
Change-Id: I9d107bf57baad66886eebec14aa369b6a3c88c49
BUG: 1284365
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12717
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 55f69862aa43ba5094874c16968cab3f1c26bcd9
Author: vmallika <vmallika@redhat.com>
Date: Wed Nov 18 17:25:14 2015 +0530
quota: fix backward compatibility of quota xattr version
quota-version features is implemented for 3.7.6
please see below patch for more details:
http://review.gluster.org/#/c/12386
Problem is when quota is already enabled,
we suffix 0 to contri xattr key. for backward compatibility
don't add suffix if quota-version is 0
Change-Id: Id7d713b18d989e4e86019969eb511617848127f2
BUG: 1283567
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12660
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 4d726fd7fcaef0da18a8ec7924341f69e4f96403
Author: Mohamed Ashiq <mliyazud@redhat.com>
Date: Thu Nov 5 20:22:02 2015 +0530
afr:vol heal info fails when transport.socket.bind-address is set in glusterd
Problem: If glusterd's bind address is specified using transport.socket.bind- address
option to a specific IP, the heal command 'gluster volume heal <VOLNAME> info' fails
with error '<vol_name>: Not able to fetch volfile from glusterd.Volume heal failed.'
This patch uses Unix domain socket transport type of libglfapi to get the volfile.
Change-Id: Ic4239b339f0246d77f1622c07d5f4708129d30c7
BUG: 1277997
Signed-off-by: Mohamed Ashiq <mliyazud@redhat.com>
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/12508
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 31420f1e04fb95eadb369e50147d7f9736cc865b
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Nov 10 18:46:28 2015 +0530
geo-rep: Fix syntax errors in GsyncdError
%s was not replaced by actual values in GsyncdError
BUG: 1279921
Change-Id: I3c0a10f07383ca72844a46f930b4aa3d3c29f568
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/12566
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 455280408cf54e3922653742a570f4e64dda0019
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Nov 23 15:58:42 2015 +0530
marker : fixing memory leak issue in marker
In marker_readdirp_cbk, variable resolvedpath is not properly freed
and because of which there was a memory leak. The patch fixes it.
Change-Id: I9d80f72e3551aa912369257da3e8e2b261a2067f
BUG: 1284419
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/12719
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d08d372fbb466c598ea8f171cbd4da11af0df31f
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Nov 16 12:26:00 2015 +0530
geo-rep: Fix Geo-rep logging to log datetime in GMT/UTC
Geo-rep is logging in Local time, all other Gluster logs are in
GMT/UTC. It is very difficult to co-relate Geo-rep logs with
other Gluster logs.
BUG: 1282331
Change-Id: Ieae8bda7e4788e587cf4595e21e0e772c210cfbb
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/12583
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 255a2a73d45cd681941b857bf97bb702f607951a
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Sep 7 14:18:45 2015 +0530
tools/glusterfind: StrictHostKeyChecking=no for ssh/scp verification
Also do not use scp command in case copy file from local
node.
Change-Id: Ie78c77eb0252945867173937391b82001f29c3b0
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1260918
Reviewed-on: http://review.gluster.org/12124
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3ea4a71058b161ecb4714e5bb7c2fb5e6489d9e5
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed Nov 4 15:33:22 2015 -0500
cluster/tier: readdirp to cold tier only
It is possible a file would get migrated in the middle
of a readdir operation. If there are four subvolumes A,B,C,D,
and if readdir reads them in order and reaches subvol B,
then, if a file is moved from D to A, it will not be included
in the readdir output.
This phenonema has pre-existed in DHT migration but is more
apparent in tiering.
When a file is moved off the hashed subvolume a T file is created.
For tiering, we will make the cold subvolume the hashed subvolume.
This will ensure the creation of a T file. Readdir will not skip T
files in the tier translator.
Making the cold subvolume the hashed subvolume ensures the T
files created on promotions or creates will be less likely to
fill the volume.
Creates still put the data on the hot subvolume.
Change-Id: Ifde557d3d0e94a4570ca9f115adee3db2ee75407
BUG: 1281598
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12530
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 3cfc74c8bc330d5374bb67256ce2485b91c34c78
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Nov 17 14:45:30 2015 +0530
features/bit-rot: scrubber changes for getting the list of bad objects from stub
Change-Id: I62885e4aba4a9b345db3c78c3291d563ff3d3567
BUG: 1207627
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/12654
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 9ed2b8e38f71b8c15972dfd699b0dc34e671bce6
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Sep 22 16:18:29 2015 +0530
features/changelog: Capture FXATTROP and XATTROP in changelog
GEO-REP INTEROP WITH SHARD FEATURE
shard xlator updates size of the file using FXATTROP
or XATTROP. Hence record the same in changelog.
Change-Id: Ie0c21e9326da05ea78dc1ef3fd32a90ef38b4bb9
BUG: 1265148
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12225
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 5cd3386599019ef61198d4e7a51064b0134e7152
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Nov 2 11:43:12 2015 +0530
features/bit-rot: stub changes for showing bad objects in the status
Change-Id: If905132f6f1df4aebd9ab255e1e8c59902f84fe5
BUG: 1207627
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/12503
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 558b60a404badba0cbd059b085cfb668cc80bb86
Author: Mohamed Ashiq <mliyazud@redhat.com>
Date: Mon Nov 9 20:43:17 2015 +0530
glusterfsd: To support volfile-server-transport type "unix"
glusterfsd fails if the glusterd is bind to specific-IP address.
This patch helps glusterfsd to get the volfile using Unix domain socket.
glusterfs -s <unix socket path> --volfile-server-transport unix
--volfile-id <volume-name> <mount-point>
The patch checks if the volfile-server-transport is of type "unix",
If It is then uses rpc_transport_unix_options_build to get the volfile.
Change-Id: I81b881e7ac5a3a4f2ac83c789c385cf547f0d53e
BUG: 1279484
Signed-off-by: Mohamed Ashiq <mliyazud@redhat.com>
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/12556
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b56b09d23cf31b909d02e3ea09c6cffba8560569
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed Mar 25 18:07:24 2015 +0530
glusterd: cli command implementation for bitrot scrub status
CLI command for bitrot scrub status will be :
gluster volume bitrot <volname> scrub status
Above command will show the statistics of bitrot scrubber.
Upon execution of this command it will show some common
scrubber tunable value of volume <VOLNAME> followed by
statistics of scrubber statistics of individual nodes.
sample ouput for single node:
Volume name : <VOLNAME>
State of scrub: Active
Scrub frequency: biweekly
Bitrot error log location: /var/log/glusterfs/bitd.log
Scrubber error log location: /var/log/glusterfs/scrub.log
=========================================================
Node name:
Number of Scrubbed files:
Number of Unsigned files:
Last completed scrub time:
Duration of last scrub:
Error count:
=========================================================
This is just infrastructure. list of bad file, last scrub
time, error count value will be taken care by
http://review.gluster.org/#/c/12503/ and
http://review.gluster.org/#/c/12654/ patches.
Change-Id: I3ed3c7057c9d0c894233f4079a7f185d90c202d1
BUG: 1207627
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10231
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7180ffa4c851fd3540e7c397bc2517c69fa7e287
Author: hari gowtham <hgowtham@redhat.com>
Date: Thu Nov 19 12:22:19 2015 +0530
Tiering: Adding space between error meassge for detach-tier
Change-Id: I730cf7fa6fbfb3842d337cd3d7b8394b9c3876d8
BUG: 1283488
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12657
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 1473e565433ac6dfca3a5adb26b937cf1686d0fa
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Nov 19 12:00:23 2015 +0530
core : Use correct path in dlopen for socket.so
This patch fixes the path for socket.so file while loading the so dynamically.
Also for config.memory-accounting & config.transport voltype is changed to
glusterd to fix the warning message coming from xlator_volopt_dynload
Change-Id: I0f7964814586f2018d4922b23c683f4e1eb3098e
BUG: 1283485
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/12656
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 9382722fe59f06d4a1998f8f90859a794b59c89e
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Nov 17 14:06:20 2015 +0100
cluster/ec: Mark internal fops appropriately
1) Mark read fops in read-modify-write by EC as internal.
2) Handle uid/gid set/reset correctly
BUG: 1282761
Change-Id: I5c1ce0cd6213367eaead5fed33aa2397c4e46df7
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/12599
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 9fc98d4b55e62c580ae77739d2d8a81a8a69226b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Nov 17 14:00:10 2015 +0530
mgmt/gluster: Handle tier brick volgen
Index xlator watches only some xattrs based on type of volume. i.e.
disperse/afr. When the volume becomes tiered then index is not adding these
options in the volfile leading to no maintenance of indices. Thus no
proactive self-heals. With this fix, we write brick volfiles considering
the type of volume they belong to.
BUG: 1250803
Change-Id: Ibe8f2d4ad5cb350306ab7ca0753e0f9a40b96a26
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12595
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 6de063d6cf9da9dcc943f378b9ef6e578b5d443f
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jul 16 17:05:25 2015 +0530
tools/glusterfind: Handle Keyboard interrupt
Do not print Python traceback when glusterfind command is interrupted
Change-Id: I67383534f965e410fef7ce09798e9d435ef738ae
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1243812
Reviewed-on: http://review.gluster.org/11698
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 4ee5d44a930aa79a1b292dcff591f8bc44d162c0
Author: Aravinda VK <avishwan@redhat.com>
Date: Sun Oct 11 20:26:16 2015 +0530
geo-rep: Fix FD leak from Active Geo-rep worker
Active worker tries to acquire lock in each iteration. On every successfull
lock acqusition it was not closing previously opened lock fd.
To see the leak, get the PID of worker,
ps -ax | grep feedback-fd
watch ls /proc/$pid/fd
BUG: 1225566
Change-Id: Ic476c24c306e7ab372c5560fbb80ef39f4fb31af
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/12332
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 7cb1d5409a8b54bdb66c7d8c9fca449e67e88439
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Aug 4 16:20:13 2015 +0530
geo-rep: Don't log geo-rep safe errors in mount logs
ENOENT is a safe error for geo-replication in case of
rm -rf. RMDIR is recorded in changelog of each brick,
geo-rep processes all changelogs among which one will
succeed and rest will get ENOENT which can be ignored.
Similarly ENOENT can also be ignored in case of all
unlink operation during changelog replay that can
happen when worker goes down and comes back.
Change-Id: I6756f8f4c3fce7a159751a2bfce891ff16ad31a4
BUG: 1250009
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11833
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 8d241dc6c72c107ab8095ea0266268abdc0399cc
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Nov 18 08:30:48 2015 +0530
afr: Drop compatibility lock for data self-heal
In glusterfs 3.4 and older, AFR did not take locks in self-heal domain
during data self-heal. So this compat lock in data domain was added to prevent
older clients from trying to heal a file while an existing self-heal was going
on by a newer client. But the side effect was that all appending writes (which
take full locks in data domain) from mounts would be stalled until self-heal
was complete.
Since glusterfs 3.4 is not supported anymore, remove the compat lock.
Change-Id: I31c8e4d7f3364f769a14eec295154e3c40d9f78e
BUG: 1283032
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12602
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ad1d8b5142925e6e606aa18bc4182550c5331950
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Nov 2 18:52:03 2015 +0530
glusterd/geo-rep: Adding ssh-port option for geo-rep create
Geo-replication uses default ssh port 22 for setup.
i.e., to distribute ssh keys to slaves. In container
environments, custom port number might be used.
Hence to support custom port number for ssh, option
is provided in geo-rep create command to take the
same.
Change-Id: I0fb61959b1c085342b8e4c21ac4e076fba5462f1
BUG: 1276028
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12504
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 9efc3aed1a16a318995fd898c432b32e2ac33e7a
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Nov 9 15:49:50 2015 +0530
cluster/tier: Do not delete linkto file on demotion
The current DHT migration code will always delete the
src linkto file after migration as dht always moves
files to the hashed subvol. This is not the case in tiering.
The lack of linkto files causes rename to fail leaving 2 files
with the same name but different gfids on the volume.
Modified to leave the linkto file behind if the source
volume is the hashed subvolume.
Change-Id: I2b99f7d34b4b719aee6232dc40c6a8f8ba88225d
BUG: 1279376
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12551
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 03077f1ec180c082fc613103f9327760a8ab7646
Author: Anuradha Talur <atalur@redhat.com>
Date: Wed Oct 21 16:49:49 2015 +0530
glusterd/afr : Readdirp performance improvement
Add xlator options to index xlator with xattrs that
it needs to keep track of.
Change-Id: If818673be5e626f77e65cc3a340f8cdd624179c2
BUG: 1250803
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12467
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a17c6ed8b007ac6f40c1a75e8bd1d0c4d88e10bf
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Nov 17 17:01:47 2015 +0530
cluster/ec: Mark self-heal fops as internal
Change-Id: I8ae7af266d3e00460f0cfdc9389a926e5f2fee36
BUG: 1282761
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12598
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit bdd9579e6666482a962fdf6f19c290230d4b822c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Nov 18 09:31:54 2015 +0530
build: add libglusterfs/src/defaults.c to .gitignore
defaults.c is auto-generated since commit
fb2a511493868a9ff0c2926537a4d1d23821ce38. Hence adding it to .gitignore
to stop git from complaining when switching branches.
Change-Id: I586e20f3fe27124c0dc6ba7d151f957d3662a7d0
BUG: 1271325
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12603
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 2b62af096c758a79d0f1a181a224dc691c569dd6
Author: Shyam <srangana@redhat.com>
Date: Thu Oct 8 13:59:44 2015 -0400
core: Add experimental xlator directory
Added an experimental xlator directory under ./xlators/
The intent of this directory is presented in the README.md
that accompanies this commit.
This directory can be disabled from being compiled using,
- configure --disable-experimental
Change-Id: I047f380c91a082d111432f8bbdbd4d7bdcbaa809
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/12321
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a44a10d400c7e4c1d110e23e37f7282d9af65ffa
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Nov 18 11:21:13 2015 +0530
glusterd.service: Ensure rpcbind is started before glusterd
Having the rpcbind.service under the `After` option only ensures that
glusterd.service is started after rpcbind.service if both are
enabled/started at the same time. It doesn't ensure that starting
glusterd.service will start rpcbind.service.
The systemd.unit(5) man page suggests to use both the `Requires` and
`After` options to ensure that rpcbind is started before glusterd,
whenever glusterd is started.
BUG: 1282915
Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/12605
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 3add43880aa7288af65e351d7a4984c3c936df37
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Nov 12 09:57:19 2015 +0100
protocol/client: prevent use-after-free of frame->root
A regression failure generated a coredump on the glusterfs-client side:
(gdb) f 0
#0 0x00007fba6cd76432 in client_submit_request (this=0x7fba68006fc0,
req=0x7fba6579aa70, frame=0x7fba5c0058cc,
prog=0x7fba6cfb53c0 <clnt3_3_fop_prog>, procnum=41,
cbkfn=0x7fba6cd9206d <client3_3_release_cbk>,
iobref=0x0, rsphdr=0x0, rsphdr_count=0,
rsp_payload=0x0, rsp_payload_count=0, rsp_iobref=0x0,
xdrproc=0x7fba79801075 <xdr_gfs3_release_req>) at
/home/jenkins/root/workspace/rackspace-regression-2GB-triggered/xlators/protocol/client/src/client.c:324
324 frame->root->ngrps = ngroups;
(gdb) l
319 gf_msg_debug (this->name, 0, "rpc_clnt_submit failed");
320 }
321
322 if (!conf->send_gids) {
323 /* restore previous values */
324 frame->root->ngrps = ngroups;
325 if (ngroups <= SMALL_GROUP_COUNT)
326 frame->root->groups_small[0] = gid;
327 }
328
(gdb) p *frame->root
Cannot access memory at address 0x64185df000000000
After looking at this in more detail, the flow is like this:
client_submit_request()
|
'- rpc_clnt_submit() // on line 314
|
'- cbkfn() // = client3_3_release_cbk
|
:- STACK_DESTROY (frame->root);
.----'
.----'
|
:- frame->root->ngrps = ngroups; // on line 324
'
So, there is a use-after-free, and it is not needed to restore the
previous groups in frame->root.
Change-Id: I9e7d712183692ed92cfc2f75cd3c2781a9db20e2
BUG: 128128
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/12575
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 4756810289ba4f826f1d7be082fd3590dab663f2
Author: Mohamed Ashiq <mliyazud@redhat.com>
Date: Tue Nov 10 13:18:41 2015 +0530
libgfapi: To support set_volfile-server-transport type "unix"
This patch helps libgfapi to get the volfile using Unix domain socket.
run the attachment file in the bug to test.
The patch checks if the glfs_set_volfile_server transport is of type "unix",
If It is then uses rpc_transport_unix_options_build to get the volfile.
Change-Id: Ifd5d1e7c0d8cc9a906c3c3355b8977141e892a2f
BUG: 1279739
Signed-off-by: Mohamed Ashiq <mliyazud@redhat.com>
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/12563
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 4128c485ba00a180556c2448d8f4ecb89c33767a
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Oct 30 16:09:29 2015 +0530
geo-rep: Allow setting config remote_gsyncd
Restrictive ssh is not used in containerized environment
where networking configuration is "net=host". SSH Pem keys
pushed to the slave without gsyncd path in it. (Patch #12459)
Actual remote_gsyncd path need to be set to actual path of gsyncd.
With this patch, remote_gsyncd is removed from reserved option list.
Change-Id: Ia2063e4654e378b62b2414bdad21143c86ad1b9a
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1276028
Reviewed-on: http://review.gluster.org/12472
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit df48fa072a06d11a7f3c798651f34a6441aa063e
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Oct 28 17:56:50 2015 +0530
geo-rep: New Config option for ssh_port
If different port used for SSH instead of 22, Geo-replication
was failing to establish SSH connection.
ssh_port option can be added using config:ssh_command and
config:ssh_command_tar, but user has to remember complete
ssh command used with parameter to add/modify ssh port.
This patch adds new config option for ssh_port,
gluster volume geo-replication <MASTERVOL> <SLAVEHOST::<SLAVEVOL> \
config ssh_port 52022
Change-Id: I7753a09485f0b1f49d2b2a80b962c720817c96f4
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1276028
Reviewed-on: http://review.gluster.org/12444
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit e14fb82b834bf9226c49e35f48cd10b2a2edd368
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Oct 9 22:31:28 2015 +0530
tests: spurious failure fix for bug-948686.t
Ensured import volume and volume start doesn't race in volinfo by refcounting
volinfo.
Change-Id: I7467eccaba9a00fd63ba0121d8157df24d1c00a6
BUG: 1258714
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/12329
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b1d5689cf04af8ee9fcb356bd00c3b13ea0218f4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Oct 21 12:00:03 2015 -0400
core: use syscall wrappers instead of direct syscalls - regression test
various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.
If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.
Change-Id: Id2207deb81a75e1af6f34bf857e74725f8bb532f
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12410
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 3f7807e7cd9a64942f8c4b0e6cd39796c03aeb86
Author: Dan Lambright <dlambrig@redhat.com>
Date: Sat Nov 14 14:35:26 2015 -0500
cluster/tier make cache mode default for tiered volumes
The default mode for tiered volumes must be cache. The current
test mode was for engineering and should ordinarily not be used
by customers.
Change-Id: I20583f54a9269ce75daade645be18ab8575b0b9b
BUG: 1282076
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12581
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
commit 745188e8ebe765dfcf2d16d2612270385f68b2fa
Author: vmallika <vmallika@redhat.com>
Date: Mon Nov 9 11:55:15 2015 +0530
quota: fix spurious failure
Change-Id: I5d18533d66df3175752a73430f680dcdfdb3c12a
BUG: 1278689
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12546
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 13dfcd1c7cd4927948da4e8b6efdf98cf90498cb
Author: jiffin tony thottan <jthottan@redhat.com>
Date: Mon Nov 16 15:51:01 2015 +0530
marker : handle variable `ret` properly in marker_unlink_cbk
While compiling new source, the following issue got hit :
marker.c: In function 'marker_unlink_cbk':
marker.c:994:29: warning: variable 'ret' set but not used
int32_t ret = 0;
This patch will fix the same.
Change-Id: I0de60bed3351b3aa1cc80f52d178e447826210e7
BUG: 1257694
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/12584
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 7e6521877cdc88d34ded51f14cea37ae7c5eecd1
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Thu Nov 12 13:43:31 2015 +0530
dht: loc should store proper gfid
Change-Id: Ic1393d44a9ed4aaba23d7c9ddea45977b9dae5e4
BUG: 1281265
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/12574
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit cb382ffc1b7eaa5e11062cd099d0c3ee5bd728f1
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Tue Nov 10 10:27:22 2015 +0530
dht: set proper errno when hashed subvol is not found
Change-Id: I0c4c72e2f5a9f8a7c60ef65251c596b54de89479
BUG: 1279705
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/12559
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Susant Palai <spalai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit b054c5e5c223705e4f78370c1ad12ac4e2405543
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Mon Nov 16 19:20:22 2015 -0500
core: use syscall wrappers instead of direct syscalls - tail(2)
tail, as in dog chasing its tail. These are the unwrapped
syscalls that have crept in (or were missed) in the previous
patches.
various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.
If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.
Change-Id: I6015f97109c4250a5a049496a214d19835e4ae19
BUG: 1267967
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12590
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 133e5f9c350ed55bc5a5de988ec1af6c5dfc9807
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Nov 17 08:38:59 2015 +0530
tier/ctr : MArking ./tests/basic/tier/record-metadata-heat.t as bad
./tests/basic/tier/record-metadata-heat.t as bad
Change-Id: I92e1f9f3103e557e99af627d25700946fcb0b7a7
BUG: 1282673
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12591
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit b69e7ca7e8c7dd6bc7526dd204b97199304d7d2f
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Mon Nov 16 10:54:01 2015 -0500
core: use syscall wrappers instead of direct syscalls - tail
tail, as in dog chasing its tail. These are the unwrapped
syscalls that have crept in (or were missed) in the previous
patches.
various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.
If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.
Change-Id: If183487de92fc7cbc47d4c5aa3f3e80eae50b84f
BUG: 1267967
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12589
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e034f6a513ed9501145707474bfd74d2b73e3d1a
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Nov 5 19:57:51 2015 +0530
build: fix ecdh.h and dh.h deps
openssl.ecdh.h and openssl/dh.h are not available on all platforms.
This patch adds check to autoconf and updates relevant source files.
Add missing #include "config.h" to socket.c to make HAVE_OPENSSL_DH_H
and HAVE_OPENSSL_ECDH_H macros available.
Definitions for UTIME_OMIT and UTIME_NOW in
contrib/qemu/util/oslib-posix.c have been selected from
/usr/include/bits/stat.h on Fedora 22
SSL context options SSL_OP_NO_TICKET and SSL_OP_NO_COMPRESSION are now
conditionally set by testing their presence.
glusterfs.spec.in file now adds CFLAGS=-DUSE_INSECURE_OPENSSL for
RHEL < 6 in the %build section.
Change-Id: Ie32a950dad77bb0f09b4ba53edb3e1f3147056f3
BUG: 1258883
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/12517
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit bee72eb86e7ea4eead6ada078d1fc9f47f340d0a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Oct 1 16:28:58 2015 -0400
core: use syscall wrappers instead of direct syscalls - libglusterfs
various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.
If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.
Change-Id: Ieeca2d36adbc884e4cfa0026dba40df70310d40b
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12275
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 7a36b5b75cf9c6ca20baf4870fb9f505e8a7c1c3
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Thu Nov 12 12:28:53 2015 +0530
afr: replica pair going offline does not require CHILD_MODIFIED event
As a part of CHILD_MODIFIED event DHT forgets the current layout and
performs fresh lookup. However this is not required when a replica pair
goes offline as the xattrs can be read from other replica pairs. Hence
setting different event to handle replica pair going down.
Change-Id: I5ede2a6398e63f34f89f9d3c9bc30598974402e3
BUG: 1281230
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/12573
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit fef28f01c040f56882eec141700c2593f01b39e4
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Jul 14 23:24:55 2015 +0530
extras/hooks: Fix parsing of args in S30samba-set.sh
Change-Id: I75756f44757a144b0ed229fcc0e29a273fc75886
BUG: 1242892
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/11668
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit e6ced8ad4f4ec3ec641d69cebc4113273c9da0c2
Author: Dan Lambright <dlambrig@redhat.com>
Date: Thu Oct 1 11:05:25 2015 -0400
cluster/tier: Disallow detach commit when detach in progress
1. Check if detach is running, disallow detach commit if so.
2. Cleanup shutdown of tier daemon on detach: do not rerun fix-layout,
do not send incorrect status back to glusterd.
Change-Id: I97202f748773c1176396a4ffd32a4c7fa9b9c1bc
BUG: 1279637
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12560
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 31f72c53aa05a44b8ad661ece88b2ba4858d503f
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Nov 9 16:43:21 2015 +0530
glusterd: brick failed to start
brick volfiles are generated in post validate, if
it is running version higher than GLUSTER_3_7_5,
else will be running in syncop.
If the code fall back to syncop, and volume is stopped
then we were returning the operation with out generating
volfiles.
Change-Id: I3b16ee29de19c5d34e45d77d6b7e4b665c2a4653
BUG: 1282322
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12552
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 0c093207fe91895222458d20da2ef343d3c8feda
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Oct 14 11:13:50 2015 -0400
build: install and package header files more conventionally
The current way we install and package header files for the -devel
package is a hack. This patch uses more conventional autoconf, libtool,
and rpmbuild idioms to package -devel headers and libraries.
Change-Id: I63ffb3460f5c12b6b355493bd00824ac9e5354c5
BUG: 1271907
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12360
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit d3dc8173baec3a624bb93b91e138b5000bc01f1b
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Fri Nov 13 12:55:17 2015 -0500
packaging: gfind_missing_files not in geo-rep %if ... %endif conditional
if geo-rep is disabled in the build then the gfind_missing_files
are erroneously included in the ganesha sub-package
Change-Id: I440df7e8283bcc8a80aa057c1c9d6f8034ca98d2
BUG: 1281892
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12577
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit a8010aa5bb817c84596fd79a3d2ab5050ca794ba
Author: Ashish Pandey <aspandey@redhat.com>
Date: Mon Oct 12 13:14:08 2015 +0530
cluster/afr : Remove stale indices
Change-Id: Iba23338a452b49dc9fe6ae7b4ca108ebc377fe42
BUG: 1270668
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/12336
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 70acc9fc6e58c3543625aac44e1e1c33d6cbf670
Author: Joseph Fernandes <josferna@redhat.com>
Date: Sun Nov 8 15:33:15 2015 +0530
tier/ctr: Providing option to record or ignore metadata heat
Currently we heat up a file for both data and metadata write.
Here we provide a ctr xlator option called "ctr-record-metadata-heat"
were the admin can decide on recording metadata heat i.e heatup a
file on metadata writes or not.
Metadata data operation are
a. setattr: explicit changing of atime/mtime using utimes,
changing of posix permissions of the file
b. rename: Renaming a file,
c. unlink, link: adding or deleting hardlinks
d. xattrs: setting or removal of xattrs.
NOTE: atime, mtime and ctime change through writev, readv, truncate, mknod
and create will not be considered here as these fops are data and primary
metadata fops.
Defaultly "ctr-record-metadata-heat" is off. Admin can
switch it on using gluster volume set command.
Change-Id: I91157509255dd5cb429cda2b6d4f64582e155e7b
BUG: 1279166
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12540
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 708c97d7b57450763bf1f5a08d477e81206345a7
Author: Bipin Kunal <bkunal@redhat.com>
Date: Fri Nov 13 19:19:17 2015 +0530
docs: move contributor docs to the glusterdocs repository
* Moved few files to glusterdocs repo
* Files were moved in pull requests given below:
https://github.com/gluster/glusterdocs/pull/60
https://github.com/gluster/glusterdocs/pull/62
* This patch removes file from this repo which were
moved to glusterdocs repo
Change-Id: I6e529911e0be66b261961c44bcdbe361aafa2886
BUG: 1206539
Signed-off-by: Bipin Kunal <bkunal@redhat.com>
Reviewed-on: http://review.gluster.org/12576
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit aa994fcaf89da748aaaff33c5994e33c53070061
Author: Kaleb S KEITHLEY <kkeithle@redhat.com>
Date: Fri Nov 13 14:07:03 2015 -0500
build: `make distclean` doesn't clean all it ought to, needs to
Debian builds fail to "build twice in a row" due to left over files
remaining after running `make distclean`
The main culprits are files created from *.in files during ./configure.
In particular these are ./glusterfs-api.pc, ./libgfchangelog.pc,
./libgfdb.pc, and ./tests/env.rc.
The strange one is contrib/umountd/Makefile{,.in}. While these are
created by ./configure - for reasons I don't quite fathom, perhaps
because contrib/umountd is included in EXTRA_DIST - after that
make and make distclean don't descend into the directory to build or
clean it (because it's not needed for Linux, and not built.)
Also removing the `find . -name Makefile -exec rm -f {}\;` from the
gitclean target, it's not needed (redundant) as its prereq distclean
target will have already removed them.
Change-Id: Ifc45b71d852052ef4b92f356279ce2ba2bbc5bb6
BUG: 1279836
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12579
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Tested-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 1c97a6b816f0cd8ebccf2efa0fe823d8f060d496
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed Nov 11 15:54:10 2015 -0500
tests: fix spurious error in fops-during-migration-pause.t
The test did not spend long enough time moving the file for the
pause to occur simultaneously, leading to failure. Solution is
to elongate that time by increasing the file size.
Change-Id: I1727fa9e3f7a987dfa07dd5da44c68d3f17218d9
BUG: 1280428
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12570
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
commit 5b76a1c3de9725b1dc95fff0a4e4073a1260befd
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Nov 10 22:50:55 2015 +0530
tier/libgfdb: Extending log level flexibity in libgfdb
Extending log level flexibity to relevant fops and operations
This is an extension to
http://review.gluster.org/#/c/12491/
Change-Id: I33b2f7732f89f52569fb99baa692c7e3bb4c7ab1
BUG: 1277352
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12567
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 65f7d2615974381e444c33fb7fc83246b1a44dcf
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Nov 10 09:06:54 2015 +0530
cluster/ec: fix bug in update_good
Problem:
Bricks that didn't participate in the fops are considered to be good. This is happening two fold.
Examples:
Case-1:
1) 2+1 volume. 'd1' directory on Brick-0 is bad.
2) readdir takes locks and lock->good_mask is '7'
3) readdir does xattrop and fop->mask is '6'.
4) because fop->expected is '1' lock->good_mask remains '7'
Case-2:
1) when all the bricks are up, it does lock + xattrop before op and figures out
all the bricks are good.
2) By the time second operation starts brick-0 is down. Now lock->good_mask
will always have the '0' bit set as long as the operations are happening on it.
because: "lock->good_mask &= ~fop->mask | fop->remaining" fop->mask doesn't
have '0' th bit.
3) When it comes time to perform the final xattrop in update_size_version
brick-0 comes online because of which it gives the same version to brick-0
as well thinking it has participated in all the transactions till then, even
when it didn't participate in the transactions.
Fix:
Case-1's fix: Update lock->good_mask in ec_prepare_update_cbk with latest
good/bad bricks
Case-2's fix: Consider non-participating brick as bad.
Change-Id: Ic01a733f8180131ded6a3cc784fcb1960758cf23
BUG: 1276989
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12561
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 9728422b373981d039e4a0ec1a7c9dc699e8f33d
Author: Joseph Fernandes <josferna@redhat.com>
Date: Mon Nov 9 20:36:11 2015 +0530
tier/ctr: ignoring bitrot scrubber fops
We had missed adding GF_CLIENT_PID_SCRUB to the internal fops
list of bitrot. Doing that in this fix
Change-Id: I0c7de37e2bf625fb577a32a599a885ee95f5d3bd
BUG: 1278326
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12555
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 8516a644675f66a1a7e886f4815d8aa1fd5aefd1
Author: hari gowtham <hgowtham@redhat.com>
Date: Mon Oct 26 12:07:16 2015 +0530
Remove selinux mount option from "man mount.glusterfs"
Gluster doesn't SELinux mount option, so it is removed.
Change-Id: I471ad98a24b5f5d64279c805b3243cb1168dd3d1
BUG: 1274626
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12422
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bae883e6669b43ed1c5095c19efa55e9c279d5d1
Author: Anoop C S <anoopcs@redhat.com>
Date: Tue Nov 10 16:20:27 2015 +0530
build: Remove systemtap references from source
We don't actually support systemtap. And so it is confusing
to have --enable-systemtap configure option in configure.ac.
This patch removes the systemtap option and corresponding
references from other files which include INSTALL, spec.in,
docs etc.
Change-Id: I719c22ca36f41a2faca156f8e41daea44e64b65e
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/12565
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ce74e751c2d89934fd480ebaf325cfd0874d445e
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Sep 15 16:56:01 2015 +0530
features/gfid-access: Fix entry creation via setxattr for geo-rep
GEO-REP INTEROP WITH SHARD FEATURE
Problem:
Geo-replication uses setxattr interface of gfid-access
xlator to create entries and send explicit setattr
after entry creation to set uid and gid. But between
entry creation and setattr, the inode would not be
linked. Hence operation which accesses inode structure
during setattr by any the below xlator fails.
Solution:
Linking inode would seem the obvious solution but,
gfid-access xlator cannot link inodes and maintain
it as it would result in same inode pointing
to two different paths one being virtual .gfid/<gfid>
path and other being actual path.
The solution is to set uid and gid in frame->root->uid
and frame->root->gid respectively from which posix
extracts and sets.
Change-Id: Ic0749ee471432caeb8ded3152a07de6e64d8538d
BUG: 1265148
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12206
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 15e6ac5c35c746b1b719e8e695be62b7416ea7a2
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Nov 9 13:04:03 2015 +0100
build: MKDIR_P is not defined for Makefiles, use mkdir_p instead
Change-Id: Id6d5263eb7b1c53e72a7668e716e9cc4e34b82cd
Reported-by: Milind Changire <mchangir@redhat.com>
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/12553
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e437478fe08247b68db5ff31a3da4a454bf8438c
Author: Shubhendu Tripathi <shtripat@redhat.com>
Date: Wed Jul 22 16:55:06 2015 +0530
extras: Exit with SUCCESS if no processes to stop
This script might be executed even when there are no
valid processes running to be stopped. In this scenario,
the script should return with SUCCESS
Change-Id: Ia293214a4b5052bc4bef9769f197f7b05c55ffe9
BUG: 1277533
Signed-off-by: Shubhendu Tripathi <shtripat@redhat.com>
Reviewed-on: http://review.gluster.org/11739
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit e4a2cbacef9e3ec79e41c372f9932c3f8c470e76
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Nov 6 17:39:38 2015 +0100
tests: make mount-nfs-auth.t more stable
mount-nfs-auth.t has a funky way of restarting the Gluster/NFS service.
It is a little racy and does not always work. Disabling and enabling the
nfs.disable volume option triggers a restart of the Gluster/NFS service
too, and is much simpler.
Also adding a little more EXPECT_WITHIN statements to prevent the
occasional failures.
Change-Id: I6765e9f021abbe995dfac00fbfc67298e2ec769c
BUG: 1278476
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/12542
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 62aab7cefb4237b7b5434f9a9ecb50e4ebc07c23
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Nov 9 10:19:25 2015 +0530
snapshot: Remove bug-1275616.t from bad tests
Remove bug-1275616.t from bad tests list as
commit 466f56a91265ac928759642a866bdc27e850654f
has fixed the spurious failure.
Change-Id: I0d3d86e4e98e3ca810692835ca0a7f119b759620
BUG: 1279297
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12544
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 3d61ecada12eacc76aebaf7c1bd656642c4a8cd3
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Oct 29 09:30:15 2015 +0000
geo-rep: Make restrictive ssh keys optional
In containerized environment where networking
configuration is "net=host", both host and
containers use the same IP. The validations
gsyncd shell and rsync to be the siblings
fails. Hence, for now, creating restrictive
ssh keys is made optional as follows.
If the argument 'container' is passed, it
will create non restrictive ssh keys else
restrictive ssh keys.
e.g.,
gluster system:: execute gsec_create container
Creates non restrictive ssh keys.
gluster system:: execute gsec_create
Creates restrictive ssh keys.
Change-Id: Ibed362f64b9b4c9931207f863a2da944c6bd1d66
BUG: 1276028
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12459
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 4e9a389cbc06abd78071e1091e2fb1be15cf4bfb
Author: vmallika <vmallika@redhat.com>
Date: Mon Nov 2 15:39:46 2015 +0530
marker: do remove xattr only for last link
With unlink, rename, rmdir, contribution xattrs
are removed. If the file is a last link
then remove_xattr will fail with ENOENT.
So it better to perform remove_xattr
only if there are more links to the file
Change-Id: Ifc1e7fda4d310fd87f6f28a635c9ea78b8f3929d
BUG: 1257694
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12033
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 6c6535a84f65a081685b15751f88c0bfde5eace9
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Aug 12 14:56:27 2015 +0530
md-cache: Remove readdirp fop for md-cache
readdirp call will return inode for each entry and
will share this nodeid with kernal, also md-cache
will cache this gfid and base name. So when a lookup
operation is perfromed on such an inode, md-cache
will wind the call, that prevents populating inode
ctx for other lower layer xlators.
Change-Id: I43c768703a3cc66d05b1c32909d1a2781001cb49
BUG: 1236032
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11894
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 489750f715656b212bde55820e98114e5cabd569
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Oct 29 20:39:57 2015 +0530
gfapi: function exit should use __GLFS_EXIT_FS
glfs api functions must be using __GLFS_EXIT_FS to exit from functions
Change-Id: If6b71d8182f3dffe15a3606f31798904cb67be1b
BUG: 1263056
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/12462
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit e23704df836820aaa303a11f917bcf19a75e0b8c
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Oct 30 17:06:58 2015 +0530
geo-rep: Kill Geo-rep Worker when Agent process dies
When Changelog agent process dies, Geo-replication fails to detect
and worker will run without respective Changelog agent. Status shows
Active/Passive without any progress.
With this patch, Worker process gets killed whenever Changelog
agent dies.
Change-Id: I30b4cc77f924f7e8174b8bfe415ac17f0b3851b4
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1277076
Reviewed-on: http://review.gluster.org/12485
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 16b5e38a2e4d09eef14ec1b28ea7a2b54cc8e329
Author: Anoop C S <anoopcs@redhat.com>
Date: Wed Oct 14 13:11:37 2015 +0530
build: Fix autoconf warnings
This patch avoids the following warnings on running autogen script
. . .
Running autoconf...
configure.ac:896: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in
body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded from...
configure.ac:896: the top level
. . .
This change uses AC_LINK_IFELSE for checking the atomic built-in function
support. Since AC_COMPILE_IFELSE checks for syntactical errors only, we need
to use AC_LINK_IFELSE to achieve the same which is more appropriate.
Reference links:
[1] https://autotools.io/forwardporting/autoconf.html
[2] http://www.gnu.org/software/autoconf/manual/autoconf.html#Generating-Sources
[3] http://www.gnu.org/software/autoconf/manual/autoconf.html#Running-the-Compiler
Change-Id: I4597f2976623496745b66f98bb78a0c9f1b07f79
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/12351
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fd043d86e20ef295304fe540a807316ae6f92ea8
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Oct 15 12:01:14 2015 +0530
dht: heal directory path if the directory is not present
After a successful nameless lookup if the directory is not
present on any of the subvol, then we will get the path of
the directory and will recursively send a named lookp on
each parent directory.
This will help particularly for the scenarios like add brick
and attach-tier.
Change-Id: I64c2118a5ab03bbaa59b0dfc62babdf4472a92a3
BUG: 1272949
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12376
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 02650be1d694618d9e871e121d1f08eecb07f77c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Oct 28 23:10:00 2015 +0530
dht: update cached subvolume during readdirp cbk
This reverts commit bb2370514598a99e6ab268af81df57dc16caa2c5.
issue and impact: readdirp_cbk was not resetting the layout for files,
this causes problem if the files is moved from one cached subvolume
and if the layout was not proper, then there is chance to fail
entry fops if the fops executed with out a lookup. Because the
cached subvolume will not change and the application assumes the
presence of file in cached subvol. so it fails with ENOENT.
The patch preset the layout information in readdirp cbk
for each files in the entry. That leaves the problem the commit
bb2370514598a99e6ab268af81df57dc16caa2c5 try to fix. We will fix the
problem in a separate patch.
Change-Id: I878ec32f44edde2fb9d4f132d9b1b547cde993d9
BUG: 1272949
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12449
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit c49d1f92e23ae993d9d7fa5c10123bd866559ba2
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Sep 21 14:51:13 2015 +0530
geo-rep: Fix syncing chown in xsync crawl
GEO-REP INTEROP WITH SHARD FEATURE
Problem:
The sequence of entry creation and chown in master
is recorded as creation of entry with resulted
user:group in xsync changelog. During sync, entry
creation is always split into two ops, MKNOD and
SETATTR. Hence the issue is not being hit otherwise
it would have failed with EPERM if parent is owned
by different user. But with shard translator being
enabled on slave, doing entry creation with MKNOD and
SETATTR is not allowed, SETATTR fails as it accesses
inode structure which is not linked.
Solution:
The sequence of entry creation and chown in master
should be recorded as MKNOD and SETATTR separately always
and do entry creation with single op in gfid-access
xlator. The gfid-access patch will be sent separately.
Change-Id: I93e554bf9342397a7660503f5128e9709f8a0cd8
BUG: 1265148
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12205
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 4d168504efbd379ef8456781f8cc33a9eb02ea10
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Oct 15 19:40:55 2015 +0530
Revert "fuse: resolve complete path after a graph switch"
This reverts commit d0edb6d555d687f76837515207b9408be0bdd55e.
The same functionality will be provided in a different patch
Change-Id: I3139478b218fa32e803bb088df585fbbdf94af34
BUG: 1272949
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12375
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit c0fedce10b90e88fa48193876c62be488f923bac
Author: Dan Lambright <dlambrig@redhat.com>
Date: Sun Nov 1 10:22:00 2015 -0500
cluster/tier correct promotion cycle calculation
The tier translator should only choose candidate files for promotion
from the most recent cycle, not a multiple of the most recent cycles.
Otherwise user observed behavior can be inconsistent. Remove related
test in tier.t that is subject to race condition.
Change-Id: I9ad1523cac00f904097ce468efa6ddd515857024
BUG: 1275524
Signed-off-by: root <root@rhs-cli-15.gdev.lab.eng.bos.redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12480
Reviewed-by: Joseph Fernandes
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7a0dd0fd6a789fac1022372320f72cb12525835d
Author: Mohamed Ashiq <mliyazud@redhat.com>
Date: Sat Nov 7 00:19:48 2015 +0530
tiering:Message shown in gluster vol tier <volname> status output is incorrect
Change-Id: I15a1a637090f1cc2f200d5c3582317e4aa3cf334
BUG: 1278927
Signed-off-by: Mohamed Ashiq <mliyazud@redhat.com>
Reviewed-on: http://review.gluster.org/12532
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 78ac5015d786bb14091c3b4711aae86c5864c6c4
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Nov 3 12:08:16 2015 +0530
tier/ctr: Ignore CTR Lookup heal insert errors
CTR doesnt read from the DB, so to make sure that file records are
created it does a heal during a lookup. It remembers the decision in
the inode context cache and retrys periodically. When the volume is
restarted it looses all the inode cache from the previous time and CTR
lookup heals tries the heal again, but this time it finds that the records
are already there from sql and logs this error, and remembers this until the
volume is restarted or inode is flushed out of inode cache of the brick.
Solution: the log levels should be reduced to trace for this case and
customers need not see this.
Change-Id: I67b568fb6904f8597e2c6d32894a247c4f500b94
BUG: 1277352
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12491
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit ed3e6695bd6e75d239608833beefdb6d00971aed
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Nov 6 14:23:07 2015 +0530
snapshot: Add bug-1275616.t to bad test list
bug-1275616.t fails spuriously in regression tests
Change-Id: Iea01476a9ffd811091865196e1536361d2298ab7
BUG: 1278418
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12527
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 1ea43dbdebcc3500ebde387c512164f54656e884
Author: vmallika <vmallika@redhat.com>
Date: Fri Nov 6 13:17:26 2015 +0530
quota: fix for spurious failure
Filed a bug# 1278689.
For now marking the testcase tests/bugs/quota/bug-1235182.t' bad
once the bug# 1278689, remove the testcase from bad list
Change-Id: I224f907153d3e5f35834007a40b0050246d8787a
BUG: 1278689
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12526
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 82ae84906332e4566e393788134822c9cf92030a
Author: Joseph Fernandes <josferna@redhat.com>
Date: Wed Oct 14 00:00:41 2015 +0530
tier/libgfdb: Replacing ASCII query file with binary
Earlier, when the database was queried we used to save
all the queried records in an ASCII format in the query file.
This caused issues like filename having ASCII delimiter and used
to take a lot of space. The tier.c file also had a lot of parsing code.
Here we changed the format of the query file to binary.
All the logic of serialization and formating of query record is done
by libgfdb. Libgfdb provides API,
gfdb_write_query_record() and gfdb_read_query_record(),
which the user i.e tier migrator and CTR xlator can use to
write to and read from query file.
With this binary format we save on disk space i.e reduce to 50% atleast
as we are saving GFID's in binary format 16 bytes and not the string format
which takes 36 bytes + We are not saving path of the file + we are also saving on
ASCII delimiters.
The on disk format of query record is as follows,
+---------------------------------------------------------------------------+
| Length of serialized query record | Serialized Query Record |
+---------------------------------------------------------------------------+
4 bytes Length of serialized query record
|
|
-------------------------------------------------|
|
|
V
Serialized Query Record Format:
+---------------------------------------------------------------------------+
| GFID | Link count | <LINK INFO> |..... | FOOTER |
+---------------------------------------------------------------------------+
16 B 4 B Link Length 4 B
| |
| |
-----------------------------| |
| |
| |
V |
Each <Link Info> will be serialized as |
+-----------------------------------------------+ |
| PGID | BASE_NAME_LENGTH | BASE_NAME | |
+-----------------------------------------------+ |
16 B 4 B BASE_NAME_LENGTH |
|
|
------------------------------------------------------------------------|
|
|
V
FOOTER is a magic number 0xBAADF00D indicating the end of the record.
This also serves as a serialized schema validator.
Change-Id: I9db7416fd421e118dd44eafab8b535caafe50d5a
BUG: 1272207
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12354
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 8da83fc6bfa6488ea70ae60a67391fceb60b9686
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Nov 6 14:36:37 2015 +0530
tests/tier : Corrected filename in run-tests.sh
bug-1214222-directories_miising_after_attach_tier.t
was renamed to bug-1214222-directories_missing_after_attach_tier.t
but run-tests.sh was not updated.
Change-Id: I64d6475ffb08e3252e56b4083cb0e828ba3584d9
BUG: 1278709
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12528
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit dbc2d5073930532462af3fa5f31e6212f58e7ac6
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Nov 5 18:19:14 2015 +0530
snapshot: Making bug-1275616.t more regression failure tolerant
snapshot clone creation fails 'spuriously' on the
regression setup coz the brick rpc connect for snap3
in the testcase, happens way after the snap was created.
So adding a EXPECT_WITHIN $PROCESS_UP_TIMEOUT check(read delay)
to help the cause. But this isn't a 100% guaranteed fix, as on an
even slower machine, even this check will fail followed by the
subsequent failures that this patch is trying to fix in the first place
Change-Id: I2f31558b717fd610111f14e451fe444c09f3f254
BUG: 1278418
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/12516
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit eec19b13048cafa33ceb5edca707094e32959402
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Nov 3 18:27:18 2015 -0500
cluster/tier: fix lookup-unhashed on tiered volumes
During attach tier the commit hash must be copied to the hot tier.
Change-Id: I91b92fd8e98696993433856e1436409b657c439d
BUG: 1277716
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12498
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 526322f33e1f796583f30caca6748c0dc407dbeb
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu Nov 5 14:59:54 2015 +0530
tier/ctr: Ignore bitrot related fops
Ignore bitrot related fops since they are internal fops.
Change-Id: I5db8cf4e3fa1b186a6987eed54287bc0e964fbd4
BUG: 1278326
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12512
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 03cca763733b692b2e121931a3405ff5d55e3475
Author: Dan Lambright <dlambrig@redhat.com>
Date: Thu Nov 5 10:04:42 2015 -0500
xlators/nfs add mount-nfs-auth.t to ignored tests list
mount-nfs-auth.t fails spuriously in regression. After discussion with
NFS leads agree to put it into ignored list until the problem is solved.
Change-Id: I44efc3332409ef963819f31d1775138d8a04a0f9
BUG: 1278476
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12521
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a43bb70bdff6d08a1598849ae84fa7f1c26a4bb3
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Oct 28 14:00:41 2015 +0100
cluster/ec: Fix bad management of lock owners
Since the addition of parallel reads patch for ec, a lock can have
more than one owner at the same time. The list of owners was stored
inside the 'owner_list' field of each fop.
The problem was with fops that required more than one lock (like
rename). In this case the same field was used to add the fop to
more than one list, casing an overwrite of the previous list.
This has been solved moving the 'owner_list' field from ec_fop_data_t
to ec_lock_link_t structure.
Change-Id: I6042129f09082497b80782b5704a52c35c78f44d
BUG: 1276031
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/12445
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit cfbe6e55574692fa15ad320330f9145f549c4540
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Oct 30 15:56:14 2015 +0530
mgmt/glusterd: Store arbiter-count and restore it
Problem:
1) Glusterd doesn't remember about arbiter information of replica volume in
store. When glusterd goes down and comes backup, arbiter volumes will
become replica volumes.
2) Glusterd doesn't import/export arbiter information to/from the other peers.
3) Volume info doesn't show any arbiter count in the output.
Fix:
1) Persist arbiter information in glusterd-store
2) Import/Export arbiter information of the volume
3) Change volume info output to show arbiter count.
Change-Id: I2db81e73d2694b01f7d07b08a17b41ad5a55c361
BUG: 1276675
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12475
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c35afeacf16f36d267a7819a60c0ea634a2a4392
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu Oct 29 12:06:57 2015 +0530
tier/dht: Ignoring replica for migration counting
We used to count replica files for migration counting even though
they were ignore for migration as the replica brick didnt have
the ownership (as per the replication xlator either AFR/EC).
As a result the number of files migrated would show a wrong count,
i.e each replicated file would be counted 1 + number of replica.
This patch ignores such cases.
Change-Id: I91aa352ee3b0a5029790653266e9333f3947d0ac
BUG: 1276141
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12453
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 92b2499ac1b28bc24abf4bc1d7c9a9be3a9c43d4
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Tue Nov 3 18:23:56 2015 +0530
v info for disperse count fails while upgrading
The upgrade from 3.7.5-3 to 3.7.5-5 causes the type and number
of bricks for the cold tier to be printed wrong.
Change-Id: Ia45b97c35fef88f9c66e15e5bdb93fd30cb342af
BUG: 1277481
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12495
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 789837adbd6f613b905fcd760948bb22dc88c360
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Jul 28 14:52:00 2015 +0530
geo-rep: Update last_synced_time in XSync
During XSync crawl, last_synced time in status file was not updated.
This patch fixes the issue by updating status file when stime xattr
is updated after Xsync or Changelog Crawl.
Change-Id: I4dc3a2d4c3d8378a939da0868caf1aef4f789599
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1247536
Reviewed-on: http://review.gluster.org/11771
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 4e6c6761d1d0c30718e55bb6e2e86e0021c6e9eb
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Fri Oct 30 16:39:16 2015 +0530
glusterd: move new feature (tiering) enum op to the last of the array
Currently new feature tiering have GD_OP_DETACH_TIER and GD_OP_TIER_MIGRATE
enum in the middle of the glusterd_op_ enum array. In multi nodes
cluster when one of the node upgraded from lower version to higher
version and upon executing command can end up in a mismatch in enum ops
at the receiver ends causing command execution fail.
Fix is to put every new feature glusterd operation enum code to last of
the enum array.
Change-Id: I640f811065e8c84add624237aa80fed43fde5967
BUG: 1276643
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/12473
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 6991258025c5cd733fd31bf754d5307a2cd31c84
Author: hari gowtham <hgowtham@redhat.com>
Date: Mon Nov 2 15:21:19 2015 +0530
correction of message displayed after attach tier
the message after attach tier is saying rebalance.
It is changed according to tiering.
Change-Id: I1834511f86483fa60f404d7defe5be59c025e9d6
BUG: 1277081
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12488
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 834873d52adc984b6a23ba7a5da718c4b9341e9a
Author: N Balachandran <nbalacha@redhat.com>
Date: Fri Oct 30 12:46:22 2015 +0530
cluster/tier : Files skipped during tier query parsing
The tier query parsing code was using fscanf to read each record.
As space is a delimiter for fscanf, filenames containing spaces
caused the parsing to return unexpected values causing various
issues in the tier process, including crashes due to buffer
overflows.
Change-Id: Ife602cb7ecb158fccbc2c89e4d2959bd97098a87
BUG: 1276562
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12469
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 095afde5263c539c79d5c315118e54a035f85ba3
Author: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Date: Thu Oct 29 20:40:00 2015 +0530
glusterd : vol replace-brick fails when transport.socket.bind-address is set in glusterd
Change-Id: Id8c29aa46b526bc003a1d7023714b67805e35a99
BUG: 1276386
Signed-off-by: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/12461
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 22c6cc8b43866a35cfd5635655003110e6601376
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Oct 28 12:30:34 2015 +0530
snapshot: Inherit snap-max-hard-limit from original volume
A snapshot should inherit snap-max-hard-limit from the original
volume while being created and when being restored to, it should
restore the same.
Similarly a clone taken from a snapshot should inherit
snap-max-hard-limit from the snapshot.
Change-Id: If8e90e2ffc10e22086b803ac8e2638a16bcec968
BUG: 1275616
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/12437
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 7fee5b9b10c35a0851b16234cc3af80fe438cbc0
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Oct 28 15:18:07 2015 +0530
snapshot: Don't display snapshot's hard-limit and soft-limit in vol info
The snap-max-hard-limit being displayed in the volume info
currently is propagated from system's snap-max-hard-limit as
that is a global option common for all volumes, and hence ends
up showing the system's snap-max-hard-limit.
We should not be displaying snap-max-hard-limit and
snap-max-soft-limit in the volume info at all, as these are
snap config options and should be set and displayed via snap
config command.
Modified bug-1113476.t to test the same behaviour.
Change-Id: I90891f0cf7fb39fd686787297c7f7cd8c1e7daa1
BUG: 1276018
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/12443
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 57394c8672c5ab550a9266de80fee8606baa4a3d
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Nov 2 11:03:26 2015 +0530
io-stats: fix BSD build failure
Change-Id: Ieb372cb686d32a09c6df31ec849f1b3c52e0e1cd
BUG: 1277024
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/12484
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 325ebffd6b7b44a295bebf67282add20ca5ea7eb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Nov 2 07:56:51 2015 +0530
tests: Move ec-readdir.t to bad tests
Change-Id: Ie7f6d25cbc617ff347aeb7d77fc0a60924c83f09
BUG: 1276989
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12481
Tested-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 799d07ec32e046b62df24504fdf726d99f2c4c54
Author: vmallika <vmallika@redhat.com>
Date: Thu Oct 15 12:41:13 2015 +0530
quota: add version to quota xattrs
When a quota is disable and the clean-up process terminated
without completely cleaning-up the quota xattrs.
Now when quota is enabled again, this can mess-up the accounting
A version number is suffixed for all quota xattrs and this version
number is specific to marker xaltor, i.e when quota xattrs are
requested by quotad/client marker will remove the version suffix in the
key before sending the response
Change-Id: I1ca2c11460645edba0f6b68db70d476d8d26e1eb
BUG: 1272411
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12386
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 75c6eb08e075ae8ab8892a7ec839ca4dbb720bcd
Author: Richard Wareing <rwareing@fb.com>
Date: Tue Jun 23 17:03:11 2015 -0700
debug/io-stats: Add FOP sampling feature
Summary:
- Using sampling feature you can record details about every Nth FOP.
The fields in each sample are: FOP type, hostname, uid, gid, FOP priority,
port and time taken (latency) to fufill the request.
- Implemented using a ring buffer which is not (m/c) allocated in the IO path,
this should make the sampling process pretty cheap.
- DNS resolution done @ dump time not @ sample time for performance w/
cache
- Metrics can be used for both diagnostics, traffic/IO profiling as well
as P95/P99 calculations
- To control this feature there are two new volume options:
diagnostics.fop-sample-interval - The sampling interval, e.g. 1 means
sample every FOP, 100 means sample every 100th FOP
diagnostics.fop-sample-buf-size - The size (in bytes) of the ring
buffer used to store the samples. In the even more samples
are collected in the stats dump interval than can be held in this buffer,
the oldest samples shall be discarded. Samples are stored in the log
directory under /var/log/glusterfs/samples.
- Uses DNS cache written by sshreyas@fb.com (Thank-you!), the DNS cache
TTL is controlled by the diagnostics.stats-dnscache-ttl-sec option
and defaults to 24hrs.
Test Plan:
- Valgrind'd to ensure it's leak free
- Run prove test(s)
- Shadow testing on 100+ brick cluster
Change-Id: I9ee14c2fa18486b7efb38e59f70687249d3f96d8
BUG: 1271310
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/12210
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fbf2fbf44be0f9d62f5bdd6aacd259e3ae892f6f
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Jun 3 09:59:30 2015 -0400
core: fix Ubuntu code audit (cppcheck) results
This change includes an additional fix (forward port) of a fix
made on the release-3.x branches to address a comment made after
the original change was merged on the master branch.
* release-3.7
* Change-Id: Ie15c5919e5bf9b0a1c66e20dc42d80fdfa8bd7f4
* BZ: 1227808
* http://review.gluster.org/11069
Change-Id: I4fc2672ab1a17998b2e40bc43eb6a3e15058a086
BUG: 1109180
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11067
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f89450b328021f5f32dfe7c57aa5292cbb6b6861
Author: anand <anekkunt@redhat.com>
Date: Thu Oct 29 21:36:57 2015 +0530
glusterd: fix info file checksum mismatch during upgrade
issue: probing a new node(>=3.6) from 3.5 cluster is moving the peer to rejected state.
fix: Disperse vol support is added from 3.6 release, so write disperse fields (disperse_count=0
and redundancy_count=0) in vol info file only if cluster version supported.
Change-Id: I11d5e2e337b9bbaddc8e52ca7295ba481beb1132
BUG: 1276423
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/12464
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit ecf32230c98c634bc755001b62e718194f5fda9d
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Oct 27 09:37:56 2015 +0530
afr/glusterd: Fix naming issue in tier related changes
changing some of the function names added recently as
part of the tiering changes.
Change-Id: I238831128ee00cdf83f8a80be937d3528d133099
BUG: 1275489
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12431
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 285c16334e4b9e97ee51c3bd2d91c036492ee1d8
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Aug 27 23:26:40 2015 +0530
snapshot : copying nfs-ganesha export file
While taking snapshot, the export file used by the volume should
copy to snap directory. So that when restore of snapshot happens,
the volume can retain all its configuration for exporting via
nfs-ganesha. The export file is stored at "/etc/ganesha/export" in
the following format "export.<volname>.conf"
The fix handles given cases in the following manner :
case a: The nfs-ganesha(global) is ON during snapshot and restore.
i.) Volume was exported during snapshot. When we restore snapshot,
then volume should be exported back with old configuration file.
ii.) Volume was unexported during snapshot. When we restore snapshot,
then volume should unexported again.
case b: The nfs-ganesha is ON during snapshot and OFF during restore
Volume was exported during snapshot. When we restore snapshot, the
conf will be copied to corresponding location and if nfs-ganesha enabled
again, then volume will be exported.
For the clones, export conf file will created in /etc/ganesha/export and then
export it via ganesha.
Change-Id: Ideecda15bd4db58e991cf6c8de7bb93f3db6cd20
BUG: 1257709
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/12034
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 6b11097a919af78be5eb226630da76bd0be8f275
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri Oct 23 12:10:42 2015 -0400
cluster/tier enable CTR on attach tier
CTR is currently disabled by default, and must be manually enabled
for tiering to start. This is an overhead on the administrator and
easy to overlook. Enable it automatically when a tier is attached.
Change-Id: I0c29de8762faec1bfe6d1376a57eeef3357ad15a
BUG: 1274847
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12420
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
commit a513332d0946cb3e382a9d37fa866f0388f2246f
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Oct 29 12:29:04 2015 +0530
nfs : avoid invalid usage of `cs` variable in nfs fops
Due to changes from http://review.gluster.org/#/c/12162/ a path variable
is added to nfs3_log_common_res() and usually `cs->resolvedloc.path` is
passed for that. But in certain fop function `cs` may not filled due error
and when it is logged using nfs3_log_common_res() results in a crash.
This patch will fix the same.
Change-Id: I5a709818923e7884bd04e329834ee352a1b3a58f
BUG: 1276243
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/12458
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit ec386c1f13b45040d23f839ec2461c3c5437c9ae
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Sep 24 12:59:08 2015 +0530
geo-rep: Handle FXATTROP and XATTROP
GEO-REP INTEROP WITH SHARD FEATURE
If it is FXATTROP or XATTROP in changelog,
add the gfid to rsync queue.
Change-Id: If68d38d7ed00b70a4618cfcc8e75df3fbadbf724
BUG: 1265148
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12226
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 66ef39b6bf4657fe96e6c7fffdbfcbee75fdef3c
Author: Susant Palai <spalai@redhat.com>
Date: Fri Oct 16 09:57:22 2015 -0400
fuse: Avoid redundant lookup on "." and ".." credit: R. Gowdappa
Change-Id: I3bc1534e499f2eccd114db69a29c0b2ce82775db
BUG: 1273315
Reviewed-on: http://review.gluster.org/12374
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 6637583abd272a33119d1a60fc56e24a0d8dc8cb
Author: Susant Palai <spalai@redhat.com>
Date: Wed Aug 26 04:49:29 2015 -0400
cluster/dht/rebalance: rebalance failure handling
At current state rebalance aborts basically on any failure
like fix-layout of a directory, readdirp, opendir etc. Unless it is
not a remove-brick process we can ignore these failures.
Major impact: Any failure in the gf_defrag_process_dir means there
are files left unmigrated in the directory.
Fix-layout(setxattr) failure will impact it's child subtree i.e.
the child subtree will not be rebalanced.
Settle-hash (commit-hash)failure will trigger lookup_everywhere for
immediate children until the next commit-hash.
Note: Remove-brick opertaion is still sensitive to any kind of failure.
Change-Id: I08ab71909bc832f03cc1517172525376f7aed14a
BUG: 1257076
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/12013
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit b71f7e2ae926a0b96f3f6b1484d34739afd63ccb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Oct 26 16:56:25 2015 +0530
cluster/afr: disable self-heal lock compatibility for arbiter volumes
Problem:
afrv2 takes locks from infinity-2 to infinity-1 to be compatible with <=3.5.x
clients. For arbiter volumes this leads to problems as the I/O takes full file
locks.
Solution:
Don't be compatible with <=3.5.x clients on arbiter volumes as arbiter volumes
are introduced in 3.7
Change-Id: I48d6aab2000cab29c0c4acbf0ad356a3fa9e7bab
BUG: 1275247
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12426
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit c9def0454fb7e20321152d0fa18664ea3a7646b4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Oct 1 16:16:52 2015 -0400
core: use syscall wrappers instead of direct syscalls
various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.
If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.
Change-Id: I8ef94c48728666465abf126c778b70c9e5c00e47
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12273
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c30e6cd337e14fe87101fa617ebaa68561f163d1
Author: Mohamed Ashiq <mliyazud@redhat.com>
Date: Wed Jul 15 14:19:49 2015 +0530
cli : 'gluster volume help' output sorted alphabetically
'gluster volume help' output is not sorted alphabetically.
This makes little harder for the user to search or get to know of
few gluster volume commands usage just from gluster cli.
Change-Id: I855da2e4748a5c2ff3be319c50fa9548d676ee8a
BUG: 1242894
Signed-off-by: Mohamed Ashiq <mliyazud@redhat.com>
Reviewed-on: http://review.gluster.org/11663
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
commit 31153370d019a6f6a66daa3ea8867c16f33519fc
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Oct 1 16:31:19 2015 -0400
core: use syscall wrappers instead of direct syscalls - miscellaneous
various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.
If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.
Change-Id: I1f47820534c890a00b452fa61f7438eb2b3f667c
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12276
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 822203a6d18bd8159ef53ed0a9237fbfe5789ca0
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Oct 16 13:52:28 2015 -0400
core: use syscall wrappers instead of direct syscalls -- glusterd
various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.
If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.
Change-Id: I28bf2a5f7730b35914e7ab57fed91e1966b30073
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12379
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5e027e65ad39a73229bef672e07e132c3674d3e3
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Oct 21 21:05:46 2015 +0530
afr: write zeros to sink for non-sparse files
Problem: If a file is created with zeroes ('dd', 'fallocate' etc.) when
a brick is down, the self-heal does not write the zeroes to the sink
after it comes up. Consequenty, there is a mismatch in disk-usage
amongst the bricks of the replica.
Fix: If we definitely know that the file is not sparse, then write the
zeroes to the sink even if the checksums match.
Change-Id: Ic739b3da5dbf47d99801c0e1743bb13aeb3af864
BUG: 1272460
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12371
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ed59b83a0ecb9dfd9a32d6b13eebcce5e1f21576
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Oct 20 11:46:10 2015 +0530
features/shard: Force cache-refresh when lookup/readdirp/stat detect that xattr value has changed
Change-Id: Ia3225a523287f6689b966ba4f893fc1b1fa54817
BUG: 1272986
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12400
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3fd49f8bb6f6c189c29decb9a337423fc2008ee2
Author: Dan Lambright <dlambrig@redhat.com>
Date: Mon Oct 26 14:19:24 2015 -0400
cluster/tier do not log error message on lookup heal for files on hot tier
On fix-layout heal files are scanned. Files found are exist on the hot or cold
subvolume. Those not found in the cold tier would exist on the hot. They
should not be flagged as an error.
Replace INFO with TRACE for common tier migration logs. Frequent migration
was growing the log files too quickly.
On migratation failures, do not acrue files towards cycle limit's budget.
Change-Id: Ie832ee07c43bce5477ae81c939d1fe8416a11615
BUG: 1275383
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12430
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
commit d09b885fc16d5c2bb7cb8b72718632c1235df9c5
Author: Ashish Pandey <aspandey@redhat.com>
Date: Fri Oct 23 13:27:51 2015 +0530
cluster/ec: update version and size on good bricks
Problem: readdir/readdirp fops calls [f]xattrop with
fop->good which contain only one brick for these operations.
That causes xattrop to be failed as it requires at least
"minimum" number of brick.
Solution: Use lock->good_mask to call xattrop. lock->good_mask
contain all the good locked bricks on which the previous write
opearion was successfull.
Change-Id: If1b500391aa6fca6bd863702e030957b694ab499
BUG: 1274629
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/12419
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 776aa04633e8e43ef0400ec23837df001a38e901
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Sep 14 17:09:29 2015 +0530
glusterd: call glusterd_store_volinfo in bump up op-version
After an upgrade, op-version is expected to be updated through gluster volume
set. If the new version introduces any feature which changes volinfo structure
without storing the default values of these new options would result into cksum
issues.
Change-Id: I57b4667f3403839811735bf66bef29e5200a9241
BUG: 1262805
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/12171
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
commit be318f1d8e19d0ad6b1e815adf82722027136f35
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Fri Oct 23 11:57:42 2015 +0530
features/changelog: record mknod if tier-dht linkto is set
This is a series of patches which aims to fix geo-replication
in a Tiering Volume.
Problem:
Consider, a file is placed in volume initially and then hot tier is
attached. During any operation on the file, due to lookup a linkto
file is created in hot tier.
Now, any namespace operation carried out on the file is recorded in
both cold and hot tier.
There is a room for races when both changelogs are replayed.
Solution:
So, We are going to replay (namespace related)operations
only in the hot tier.
Why?
a. If the file is directly placed in Hot tier, all fops will be
recorded in HOT tier.
b. If the file is already present in Cold tier, and if any fop is
carried out, it creates linkto file in Hot tier.
Now, operations like UNLINK, RENAME are captured in Hot tier(by means of linkto file).
This way, we can get both tier's operation in HOT tier itself.
But, We may miss initial Data sync immediately after creating the
file as it is only recording MKNOD. So, if MKNOD encountered
with sticky bit set, queue DATA operation for the corresponding gfid.
( This geo-rep related changes are addressed in this patch: http://review.gluster.org/12326/ )
So, If tier-dht linkto is set, we need to record the corresponding
MKNOD. Earlier this was avoided as it was set as INTERNAL fop.
(This is addressed here in this patch)
Change-Id: I25514fe3e25f68592a8d6361507f8c8a4fcb70b1
BUG: 1266875
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/12417
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit cca2d3e4110bd6ef0cd5e35d3567d6f4445b8bd1
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Mon Sep 28 16:31:54 2015 +0530
features/changelog: ignore recording tiering rebalance fops
Recording of tiering rebalance process's fops like Creation
and Deletion of file must be avoided.
Ignore the fops using corresponding pid.
Change-Id: Ifdc7765598d04d033f93e6339e9b188f7566cb65
BUG: 1266875
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/12239
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 515283807c502bb192fa6d7b8d4394ad2369016b
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Sep 7 00:24:05 2015 +0530
tests: Separate logs for each test
Change-Id: Ib286e3d4d7c432dab8073fce582ccbf723eb31d2
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/12110
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit bcb19dd4445ec95e3a330dfba92ed0d0e377252f
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Oct 27 11:51:33 2015 +0530
tier: Typo while setting the wrong value of low/hi watermark
While setting the wrong value of watermark-hi/low the output
shows "compatiblevalue" whereas it should be "compatible value"
Change-Id: I29c8f9a954928d22e436465f4ebc30bd08640138
BUG: 1275502
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12432
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit be23a031fe434e9cf48e3d7eb3ba1a3a2ed0e0c0
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Oct 19 16:05:17 2015 -0400
tests: fix timeout in mount-nfs-auth.t
The mount timeout was too short. The normal configuration-change path
(construct graph, call reconfigure) and the auth-refresh path might in
effect run serially. Therefore we have to wait for the *sum* of those
two intervals. As with all too-short-timeout problems, the result was
that the test would run fine most of the time. However, it has caused
spurious failures on my own patches a half dozen times, and I have a
half dozen other emails about it nuking other people's as well (most
often but not always on NetBSD).
The fix, obviously, is to calculate and use the right timeout value for
NFS mount actions. Other actions and timeouts have been left alone.
Change-Id: Ic8f013c8c830e33c48bcc6d1b603d6d22a8ba3c5
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/12396
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit a87041fad2afd00f1fa374a97a83a4cbf93bb012
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Sep 24 15:42:14 2015 +0530
features/shard: Support geo-rep for sharded volume
Approach:
Shard xlator on slave side is by passed for all the fops
to geo-rep mount. So each shard on master is considered as a
separate file for geo-rep and it syncs them separately on to
slave. The extended attribute in which shard maintains the
size is also synced from master and shard on slave doesn't
calculate by itself.
Pre-requisites:
1. If master is sharded volume, slave also should be sharded.
2. Slave's shard configurations should be same as master.
3. Geo-rep config of xattr sync should not be disabled.
All other dependant patches:
1. http://review.gluster.org/#/c/12205/
2. http://review.gluster.org/#/c/12206/
3. http://review.gluster.org/#/c/12225/
4. http://review.gluster.org/#/c/12226/
Change-Id: I474220d69fa030b1e06a4fa0868c34fabe02efcf
BUG: 1265148
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12228
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 46bc8f6931756a3fc0981d031bcc6749a17896e7
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Wed Oct 14 11:49:49 2015 +0530
geo-rep: Avoid cold tier bricks during ENTRY operation
This is a series of patch which aims to fix geo-replication
in a Tiering Volume.
Problem:
Consider, a file is placed in volume initially and then hot tier is
attached. During any operation on the file, due to lookup a linkto
file is created in hot tier.
Now, any namespace operation carried out on the file is recorded in
both cold and hot tier.
There is a room for races when both changelogs are replayed.
Solution:
So, We are going to replay (namespace related)operations
only in the hot tier.
Why?
a. If the file is directly placed in Hot tier , all fops will be
recorded in HOT tier.
b. If the file is already present in Cold tier, and if any fop is
carried out, it creates linkto file in Hot tier.
Now, operations like UNLINK, RENAME are captured in Hot
tier(by means of linkto file).
This way, we can get both tier's operation in HOT tier itself.
Now, once the file is demoted to COLD tier, any namespace operation
carried out on the cold tier can be avoided as we directly RECORD
the same in HOT tier.
How?
1. Check whether the brick is cold tier and skip ENTRY operation.
2. Also, if it is cold tier brick, use Xsync(which is used during initial run).
This will help in getting all cold tier bricks changes using File System crawl
and helps in avoiding races with hot tier brick(which can happen
if historychangelog used in cold tier brick).
Dependent patches:
1. http://review.gluster.org/12239
2. http://review.gluster.org/12326
Change-Id: I7692b1dbb8813a7e253451bca02f8f09a5782dde
BUG: 1266875
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/12355
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit ed935025e7609b1801aceb01d66cf73fe9fcf786
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Oct 20 16:27:14 2015 +0530
mount/fuse: use a queue instead of pipe to communicate with thread doing inode/entry invalidations.
Writing to pipe can block if pipe is full. This can lead to deadlocks
in some situations. Consider following situation:
1. Kernel sends a write on an inode. Client is waiting for a response
to write from brick.
2. A lookup happens on behalf of different application/thread on the
same inode. In response, mdc tries to invalidate the inode.
3. fuse_invalidate_inode is called. It writes a invalidation request
to pipe. Another thread which reads from this pipe writes the
request to /dev/fuse. The invalidate code in fuse-kernel-module,
tries to acquire lock on all pages for the inode and is blocked as
a write is in progress on same inode (step 1)
4. Now, poller thread is blocked in invalidate notification and cannot
receive any messages from same socket (on which lookup response
came). But client is expecting a response for write from same
socket (again step1) and we've a deadlock.
The deadlock can be solved in two ways:
1. Use a queue (and a conditional variable for notifications) to pass
invalidation requests from poller to invalidate thread. This is a
variant of using non-blocking pipe, but doesn't have any limit on the
amount of data (worst case we run out of memory and error out).
2. Allow events from sockets, immediately after we read one
rpc-msg. Currently we disallow events till that rpc-msg is read from
socket, processed and handled by higher layers. That way we won't run
into these kind of issues. Also, it'll increase parallelism in way of
reading from sockets.
This patch implements solution 1 above.
Change-Id: I8e8199fd7f4da9eab46a719d9292f35c039967e1
BUG: 1273387
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/12402
commit ca6e35b74fde9c560e91d52b4b08aad52c934e8b
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Fri Oct 9 20:29:30 2015 +0530
geo-rep: Add data operation if mknod with tier attribute
This is a series of patches which aims to fix geo-replication
in a Tiering Volume.
Problem:
Consider, a file is placed in volume initially and then hot tier is
attached. During any operation on the file, due to lookup a linkto
file is created in hot tier.
Now, any namespace operation carried out on the file is recorded in
both cold and hot tier.
There is a room for races when both changelogs are replayed.
Solution:
So, We are going to replay (namespace related)operations
only in the hot tier.
Why?
a. If the file is directly placed in Hot tier, all fops will be
recorded in HOT tier.
b. If the file is already present in Cold tier, and if any fop is
carried out, it creates linkto file in Hot tier.
Now, operations like UNLINK, RENAME are captured in Hot tier(by means of linkto file).
This way, we can get both tier's operation in HOT tier itself.
But, We may miss initial Data sync immediately after creating the
file as it is only recording MKNOD. So, if MKNOD encountered
with sticky bit set, queue DATA operation for the corresponding gfid.
(This is addressed here in this patch)
So, If tier-gfid linkto is set, we need to record the corresponding
MKNOD. Earlier this was avoided as it was set as INTERNAL fop.
(This changelog related changes are addressed in the patch:
- http://review.gluster.org/12417)
Change-Id: I2fa84cfa2b0f86506c3d15d484138ab9651e4f83
BUG: 1266875
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/12326
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 6af6a5b091aba207870c24558360baee3ccc562d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Oct 23 11:19:30 2015 +0530
afr: wind writes only on subvols where preop succeeded
1. Call local->transaction.wind() only on subvols where pre-op
succeeded.
2. Update op_errno in afr_changelog_cbk call path. This fixes a bug in
commit 7945121dda340ec8f25711b2ad3ca70b544de967 where we return EUCLEAN
to the application if pre-op fails on all bricks.
Change-Id: Iab8776e49a992e7a255314bba542742f7607f3ec
BUG: 1272362
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12415
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 821f291d0050ce05c1fff219411859e98211b61c
Author: Joseph Fernandes <josferna@redhat.com>
Date: Fri Oct 23 12:27:32 2015 +0530
tier/ctr: Correcting the internal fop calculation
Correcting the internal fop calculation method, as it had wrong logic.
Change-Id: I1d0b40a1e27548147203ddd503794059652ac049
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12418
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit b67b924b7367386a20c42eecaee937d69ee33988
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Oct 6 13:19:01 2015 -0400
libglusterfs: replace default functions with generated versions
Replacing repetitive code like this with code generated from a more
compact "canonical" definition carries several advantages.
* Ease the process of adding new fops (e.g. GF_FOP_IPC).
* Ease the process of making global changes to existing fops (e.g.
adding "xdata").
* Ensure strict consistency between all of the pieces that must be
compatible with each other, through both kinds of changes.
What we have right now is just a start. The above benefits will only
truly be realized when we use the same definitions to generate stubs,
syncops, and perhaps even parts of gfapi or glupy.
This same infrastructure can also be used to reduce code duplication and
potential for error in many of our translators. NSR already uses a
similar technique, using a few hundred lines of templates to generate a
few *thousand* lines of code. The ability to make a global "aspect"
change (e.g. to quorum checking) in one place instead of seventy has
already been demonstrated there.
Other candidates for code generation include the AFR/EC transaction
infrastructure, or stub creation/resumption in io-threads.
Change-Id: If7d59de7a088848b557f5aea00741b4fe19017c1
BUG: 1271325
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/9411
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 63dd0666142f7f62dcebdfc557fb1a6a5fceabe5
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Oct 20 22:23:17 2015 +0530
tests/tier: Move common functions to tier.rc
Move common functions in tier .t files to tier.rc
Change-Id: Ibc312d987be9d93e7cc7fc47d0bf598bb1c944c2
BUG: 1272319
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12404
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit d31f23ffa70e2adaac1c5cec217c8e413b5bf304
Author: Dan Lambright <dlambrig@redhat.com>
Date: Mon Oct 5 19:52:02 2015 +0000
cluster/tier: add pause tier for snapshots
Snaps of tiered volumes cannot handle files undergoing migration.
We implement a helper mechanism to "pause" migration. Any files
undergoing migration are aborted. Clean up is done to remove
sticky bits and data at the destination. Migration is restarted
after snap completes.
For testing an internal switch is added. It is not exposed externally.
gluster volume set vol1 tier-pause [true|false]
Change-Id: Ia85bbf89ac142e9b7e73fcbef98bb9da86097799
BUG: 1267950
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12304
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b3092e197beeb6f30bc6c2b488dfb532b30c426d
Author: hari gowtham <hgowtham@redhat.com>
Date: Wed Oct 21 12:12:09 2015 +0530
Tier/cli: removing warning message for tiering
The warning message for tiering being under experimental staus is removed.
Change-Id: I7d1d535d380b672c70f03ecc0d24a113600ea43f
BUG: 1273726
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12407
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit c504b6838353de1fb73698e045be40e5df650722
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Oct 20 15:53:15 2015 +0530
cluster/dht : op_ret not set correctly in dht_fsync_cbk
local->op_ret was not set correctly in dht_fsync_cbk in case
of files being migrated
Change-Id: If73ae04368ea0c7f6868c8704dfc2deb2faee753
BUG: 1273372
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12401
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit cdd3c2f2e38a07381fb2fa16eba97864d763ac86
Author: Dan Lambright <dlambrig@redhat.com>
Date: Mon Oct 19 20:42:56 2015 -0400
cluster/tier do not abort migration if a single brick is down
When a bricks are down, promotion/demotion should still be possible.
For example, if an EC brick is down, the other bricks are able to
recover the data and migrate it.
Change-Id: I8e650c640bce22a3ad23d75c363fbb9fd027d705
BUG: 1273215
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12397
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
commit 0f9ebaa0f636cba3272a1ab9ead5905cc5e7d1ec
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Oct 9 22:11:23 2015 +0530
tests: return success if the last test ends up with core and a bad test
Change-Id: Ie2695ebff8678851edb6b0b6e1de37e1f5ec9077
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/12328
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ce0a10a28eff45fe96079f6b25e557ddb53e2c4a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Oct 15 16:08:03 2015 +0530
snapshot: Fix snapshot clone postvalidate
In glusterd_snapshot_clone_postvalidate(), we were deleting
snap object and snap vol, by looking up snapname. Hence, it
was deleting the orignal snapshot from which the clone was
being created
Instead it should fetch the clonename, the respective
clone vol, and its corresponding snap object, and delete them.
Also glusterd_snap_remove(), needs to differentiate a clone
snap object from a snaphsot snap object, as in case of a clone
snap object, we don't have any persisted data in
/var/run/gluster/snaps/ and hence is shouldn't try to delete
anything there.
Change-Id: I02bb22a3898d5720e318a02d6cc32d25f75d317d
BUG: 1272339
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/12364
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 67ab30b32383e9b4f6ea2568be2b9f7ae2e6a23e
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Oct 16 06:23:29 2015 +0530
afr: do not wind write if pre-op fails on all children
1. When winding the pre-op, transaction.pre_op[i] is set. If the pre-op fails,
transaction.failed_subvols[i] is set. If if fails on all chidren, we can
directly proceed to unlock (via afr_changelog_post_op_now) without trying
to wind the write, fail and then go to unlock.
2. 'fop_subvols' seems to be an unused variable, hence removing it.
Change-Id: I9525628daf48082e979b0093fa0478934495e61f
BUG: 1272362
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12368
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
commit b0d36d9a7d43bbfe91912b5b3f3ab5674f14e9a9
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Sep 8 12:27:50 2015 +0530
features/snap : cleanup the root loc in statfs
Problem : In svc_statfs function, wipe_loc is getting called on loc
passed by nfs. This loc is being used by svc_stat which
throws erro if loc->inode is NULL.
Solution : wipe_loc should be called on local root_loc.
Change-Id: I9cc5ee3b1bd9f352f2362a6d997b7b09051c0f68
BUG: 1260848
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/12123
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit b6a621033f0014486148e1cc39b08c655fc879a8
Author: Dan Lambright <dlambrig@redhat.com>
Date: Mon Oct 19 09:04:07 2015 -0400
cluster/tier remove suprious log messages on valid failed migration
On a write to a replica volume, we record in all brick's databases an entry.
When the tier daemon runs, it will only move the file if it is the true
owner of the file as defined by the XATTR_NODE_UUID_KEY.
Change-Id: Ib82717f87a3f94f3d0d9f969773de9e88d6aaf22
BUG: 1273043
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12391
Reviewed-by: Joseph Fernandes
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9b114885acff6071194c07b95a1601e417eb4d6e
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri Oct 16 14:16:32 2015 -0400
cluster/tier update man pages for tier feature
Add to gluster man pages instructions for tier commands.
Change-Id: I0918460eeaba22bb6a11238d4f5501fa8e61da88
BUG: 1272557
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12380
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit 7a9bfdfddfc7da9699052fd2d4fbb9e722d376e8
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Oct 13 17:11:29 2015 +0530
cluster/tier: Changed tier xattr-name value
Each tier layer (for future stacking implementations)
must have a unique xattr name. We are currently using
the name of the tier subvolume excluding the volume name.
Change-Id: Id4adea61dc1c8473fb1d4d7364d1940278c6e129
BUG: 1259298
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12350
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 1fe75ea3e899a2ac1445035f5c4900596a52761a
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Oct 13 23:25:59 2015 +0530
cluster/ec : Remove index entries if file/dir does not exist
Problem: During write and rebalance if a brick is down, index
entries will be created. If the same file gets migrated to
other subvol by rebalance process, these index entries will
remain in index directory. During heal, these indices should
be removed when we get ENOENT or ESTALE for a index.
Solution: Capture correct errno and take appropriate action
to purge these indices.
Change-Id: I1aad8b99e4df2e139648e3bf971e4cb1c4b38699
Bug: 1271358
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/12353
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 23eb64a348ca661f3c91c6de7d368f1c80d105dc
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Sep 28 16:47:01 2015 +0530
protocol/server: define the max number of inodes in lru list as a number
* The max number of inodes in the lru list of the inode table was being defined
in terms of memory units (GF_UNIT_MB) instead of number. And the description
of the option was also referring to it in memory units instead of number.
Change-Id: I48f07e7d2826406697eb2a13714ab22feae81d89
BUG: 1266883
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/12242
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 10506db2ba2664365e69eca03ed2d0dc97a65d1e
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Oct 13 15:02:00 2015 +0530
cluster/dht : Do not migrate files with POSIX locks held
dht_migrate_file does not migrate file locks to the dst file.
Any locks held on the source file are lost once the migration
is complete. This issue is magnified in the case of a tier volume
as file migrations occur more frequently and repeatedly as compared
to a DHT rebalance.
The fix makes 2 changes:
1. Before starting the actual migration process, check if there are
any locks held on the file. If yes, do not migrate the file.
2. The rebalance process tries to lock on the entire file just before
moving into the Phase 2 of the file migration. If the lock acquisition
fails, the file migration does not proceed.
If the lock is granted, the file migration proceeds.
This still leaves a small window where conflicting locks can be granted to
different clients. If client1 requests a lock on the src file just after
it is converted to a linkto file and client2 requests a lock on the dst
data file, they will both be granted, but all FOPs will be redirected
to the dst data file. This issue will be taken up in a subsequent patch.
Change-Id: I8c895fc3cced50dd2894259d40a827c7b43d58ac
BUG: 1271148
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12347
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit fab09c9607f149a43e942d986825762650448fde
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Tue Oct 13 14:40:55 2015 +0530
libglusterfs: pass buffer size to gf_store_read_and_tokenize function
Previously if user set an option where length of key=value goes beyond
PATH_MAX (4096) character then tokenzing the option at the time of
reading configuration file will fail.
This is because of the we was having restraction in fgets to read maximum
of PATH_MAX (4096) length of character.
Consequence of this is when user try to restart glusterd, after setting
key=value length beyond PATH_MAX (4096) character, glusterd will not restart.
With this fix instead of PATH_MAX, consumer of gf_store_read_and_tokenize
function will decide the size of the buffer length.
Change-Id: I655a8ce982effdfff8f3e785ea31f543dbe39301
BUG: 1271150
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/12346
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 58d4052068cd1065c1ab95fb97f80d0af456578f
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Oct 13 14:28:03 2015 +0530
cli/quota : rm -rf on /<mountpoint>/<dir> is not showing quota header
Currently, when 'gluster v quota <VOLNAME> list' command is issued
after an rm -rf on /run/gluster/vol/<directory>, quota output header is
not shown. It is because the list_count was properly calculated with
'gluster v quota <VOLNAME> remove /path' and not with an rm -rf. The patch
fixes this issue.
Change-Id: I5266a8b0b9322b7db1b9e1d6b0327065931f4bcb
BUG: 1269375
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/12345
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 1fb2060938df56c69b58eabccc615a91b8a10126
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Oct 12 15:03:28 2015 +0530
cli : freeing the allocated memory
Change-Id: Ibcbad94c091a9c24fe5aff2d7e8bcd9ac88da7bf
BUG: 1248521
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/12337
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit deaf7ffdeef05bcb169fef319fb7bf6f50f4fd1b
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Thu Sep 24 18:04:23 2015 +0530
glusterd: disabling enable-shared-storage option should not delete volume
Previously when you create volume with "glusterd_shared_storage" name
and if user disable enable-shared-storage option then gluster will
delete the "glusterd_shared_storage" volume.
With this fix gluster will do appropriate validation of
enable-shared-storage option and it will not delete volume with
"glusterd_shared_storage" name if it is a user created volume.
Change-Id: I2bd92f938fb3de6ef496a934933bdcea9f251491
BUG: 1266818
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/12232
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 35e2c749099899b2f56e524fbe577f1c043746de
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Oct 12 17:22:20 2015 +0530
tier/shd: inline warning when compiled with gcc v.5
Change-Id: I487a26263d6e940eed364a831e99f9b8390bc96a
BUG: 1226881
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12342
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Tested-by: Anoop C S <anoopcs@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 1c681afb746773d7badee0644438c913c810a2fd
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jul 29 14:27:07 2015 +0530
features/shard: Return ENOTSUP as opposed to ENOTCONN in unimplemented fops
Change-Id: Idba1070b11c5c1de26ef57e6843c93c105b8b8a5
BUG: 1270694
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12340
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit d16a0ce4fa6f289e0efe6757041f0a38d2824bd5
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Oct 12 13:12:46 2015 +0530
features/shard: Dump private members and addresses in statedump
Change-Id: I3c5e5bd93288c4c9a2665a26c0d6a76e67ecf914
BUG: 1270694
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12334
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 122cbec9dfad84045fe3afb08488c415422d4fa0
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Sep 16 16:35:19 2015 +0530
protocol/client: give preference to loc->gfid over inode->gfid
There are xlators which perform fops even before inode gets linked. Because of
this loc.gfid is preferred at the time of inodelk/entrylk but by the time
unlock can happen, inode could be linked with a different gfid than the one in
loc.gfid (because of the way dht was giving preference) Due to this unlock goes
on a different inode than the one we sent inodelk on, which leads to hang.
Credits to Pranith for the fix.
Change-Id: I7d162d44852ba876f35aa1bb83e4afdb184d85b9
BUG: 1266834
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12233
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 71e3365c85c6d5e34ec3cf882ea925bd1b8f7d34
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Sep 8 13:04:45 2015 +0530
tier/shd: make shd commands compatible with tiering
tiering volfiles may contain afr and disperse together
or multiple time based on configuration. And the
informations for those configurations are stored in
tier_info. So most of the volgen code generation
need to be changed to make compatible with it.
Change-Id: I563d1ca6f281f59090ebd470b7fda1cc4b1b7e1d
BUG: 1261276
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12135
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 752e5219f33788e4a380cbafde3b9baefe31a0cc
Author: vmallika <vmallika@redhat.com>
Date: Wed Oct 7 15:24:46 2015 +0530
quota/marker: dir_count accounting is not atomic
Consider below scenario:
Quota enabled on pre-existing data
Now quota-crawl process will start healing xattrs
Now if write is performed where healing is not complete, there is a
possibility that 'update txn' is started before 'create xattr txn', in
this case dir count can be missed on a dir where quota size xattr is not
yet created.
Solution is to get size xattr and if xattr is missing, add 1 for
dir_count, this requires one additional fop if done in marker during
each update iteration
Better solution is to us xattrop GF_XATTROP_ADD_ARRAY64_WITH_DEFAULT
Change-Id: Idc8978860a3914e70c98f96effeff52e9a24e6ba
BUG: 1243798
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11694
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 89d8804741ee723eedc6a8603f8d8c8c5b040759
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Aug 20 12:19:51 2015 +0530
tier/shd: create shd volfile for tiering
Currently shd graph will only start if it is replicate
or disperse volume. But in case of tiering, volume type
will be tier. So we need to start shd if any of the cold
or hot is compatible with shd volume.
Change-Id: Ic689746ac7d2fc6a9eccdabd8518dc9139829de2
BUG: 1261276
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11962
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 3abdef0caa560957b7f743ec0c45d940febc608b
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Aug 4 20:38:06 2015 +0530
tier/ctr: CTR DB named lookup heal of cold tier during attach tier
Heal hardlink in the db for already existing data in the cold
tier during attach tier. i.e during fix layout do lookup to files
in the cold tier.
CTR xlator on the brick/server side does db update/insert of the hardlink on a namelookup.
Currently the namedlookup is done synchronous to the fixlayout that is
triggered by attach tier. This is not performant, adding more time to
fixlayout. The performant approach is record the hardlinks on a compressed
datastore and then do the namelookup asynchronously later, giving the ctr db
eventual consistency
Change-Id: I4ffc337fffe7d447804786851a9183a51b5044a9
BUG: 1252586
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/11828
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit a15b935197bc417ccc64b54e57ef09e6ce1b35d6
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri Sep 18 00:49:06 2015 -0400
cluster/tier: add watermarks and policy driver
This fix introduces infrastructure to support different
policies for promotion and demotion.
Currently the tier feature automatically promotes and demotes
files periodically based on access. This is good for testing
but too stringent for most real workloads. It makes it
difficult to fully utilize a hot tier- data will be demoted
before it is touched- its unlikely a 100GB hot SSD will have
all its data touched in a window of time.
A new parameter "mode" allows the user to pick promotion/demotion
polcies.
The "test mode" will be used for *.t and other general testing.
This is the current mechanism.
The "cache mode" introduces watermarks. The watermarks
represent levels of data residing on the hot tier.
"cache mode" policy:
The % the hot tier is full is called P.
Do not promote or demote more than D MB or F files.
A random number [0-100] is called R.
Rules for migration:
if (P < watermark_low) don't demote, always promote.
if (P >= watermark_low) && (P < watermark_hi) demote if R < P; promote if R > P.
if (P > watermark_hi) always demote, don't promote.
gluster volume set {vol} cluster.watermark-hi %
gluster volume set {vol} cluster.watermark-low %
gluster volume set {vol} cluster.tier-max-mb {D}
gluster volume set {vol} cluster.tier-max-files {F}
gluster volume set {vol} cluster.tier-mode {test|cache}
Change-Id: I157f19667ec95aa1d53406041c1e3b073be127c2
BUG: 1257911
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12039
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 3e2bbc480e001b7ed137ec6956f182425c1ae2ac
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Sep 24 14:53:52 2015 +0530
Porting developer guide to source code repo from glusterdocs project
Change-Id: Ib8d9c668ebb05863918e6ec2b89908f206626f38
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/12227
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Raghavendra Talur <rtalur@redhat.com>
commit 9f073fb5cc52a6b7a3d8be0c8fae8031b093796b
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri Oct 9 12:18:03 2015 -0400
cluster/tier: fix transpoint endpoint not connected in tier.t (rare)
The script did not cleanly unmount/mount gluster and change the current
working directory when stopping and starting the volume. Most of the
time this problem would self-resolve before subsequent tests, but
very occasionally races would lead to the errors/failures.
Change-Id: I128b913a71e2745512ee81c3d71852311e3b4a1b
BUG: 1270328
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12327
Reviewed-by: Joseph Fernandes
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit de02c43cb2052d5f5f69626d457de2129dd0cb68
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Oct 7 18:39:42 2015 +0530
glusterfsd: Initialize ctx, cmd_args
Change-Id: I9c71ae264665b7bba609c7f86cf42a52a6b47260
BUG: 1269696
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12311
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 50e08ae59ce1881c8b9b445fd63357e0139a48a0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Sep 8 16:23:36 2015 +0530
cluster/ec: Implement gfid-hash read-policy
Add a policy in ec to performs reads from same bricks as long as they
are good. Based on the gfid of the file/directory it determines the
bricks to be considered for reading.
Change-Id: Ic97b5c54c086a28b5e07a330a4fd448551b49376
BUG: 1261260
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12133
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 54424b257977464ab374c7265ca7ece8d0a4922f
Author: Milind Changire <mchangir@redhat.com>
Date: Tue Sep 22 18:30:22 2015 +0530
gfapi: xattr key length check to avoid brick crash
Added check to test if xattr key length > max allowed for OS
distribution and return:
EINVAL if xattr name pointer is NULL or 0 length
ENAMETOOLONG if xattr name length > max allowed for distribution
Typically the VFS does this in the kernel for us. But since we are
bypassing the VFS by providing the libgfapi to talk directly to the
brick process, we need to add such checks.
Change-Id: I610a8440871200ae4640351902b752777a3ec0c2
BUG: 1263056
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/12207
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit d62e11cf7104ee186994450c57af168b6efca616
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Sep 29 15:13:37 2015 +0530
features/shard: Regulate memory consumption by individual shards' inode_t objects
Shard translator will now maintain an lru list of inodes associated with
individual shards of constant size, and will make sure that at no point the
number of these inodes will exceed the configured limit.
This is to keep the memory consumption by the thousands of shards of every large
file from exploding.
Change-Id: I5e60eea5dcf3130257fb431ca70cfaba53cae7f3
BUG: 1252263
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12254
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 7fbd5fcb1277953553d0649733d02eaaff214a78
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Sep 7 14:46:33 2015 +0530
tiering/glusterd: keep afr/ec xlators name constant
afr uses the translator name for locking purpose,
so it is mandatory to keep afr/ec xlators name constant
across graph change
currently when a tier is attached, afr names are appended
either with hot or cold. ie that breaks the above
mentioned constraint.
Change-Id: I3699dcdaa8190bab3ba81cbc01e8fa126d37ba0d
BUG: 1261276
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12134
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 945596a43227b686ec443efbdd8fa08a51fb7b4b
Author: Susant Palai <spalai@redhat.com>
Date: Wed Sep 23 05:01:47 2015 -0400
feature/quota: Make message-id for quota start from 120000
Change-Id: I2076fcab51f4ecc529dffd89ca6ee9eb99d80f09
BUG: 1265531
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/12218
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 60b55573de344d902d150d576a97bcb32c54530f
Author: vmallika <vmallika@redhat.com>
Date: Thu Oct 8 12:37:42 2015 +0530
quota: fix crash in quota_fallocate
list head was not initialized and brick
was crashing with fallocate.
This patch fixes the issue
Change-Id: I9757b88eab61054892f0fe3de63af2683cd4fef7
BUG: 1269754
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12314
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 425b8e329bb130f21eed08116abfc52cad1b9872
Author: Joseph Fernandes <josferna@redhat.com>
Date: Fri Sep 18 19:57:54 2015 +0530
tier/ctr: Solution for db locks for tier migrator and ctr using sqlite version less than 3.7 i.e rhel 6.7
Problem: On RHEL 6.7, we have sqlite version 3.6.2 which doesnt support
WAL journaling mode, as this journaling mode is only available in sqlite 3.7 and above.
As a result we cannot have to progreses concurrently accessing sqlite, without
running into db locks! Well WAL is also need for performace on CTR side.
Solution: This solution is to use CTR db connection for doing queries when WAL mode is
absent. i,e tier migrator will send sync_op ipc calls to CTR, which in turn will
do the query and create/update the query file suggested by tier migrator.
Pending: Well this solution will stop the db locks but the performance is still an issue for CTR.
We are developing an in-Memory Transaction Log (iMeTaL) which will help boost the CTR
performance by doing in memory udpates on the IO path and later flush the updates to
the db in a batch/segment flush.
Change-Id: Ie3149643ded159234b5cc6aa6cf93b9022c2f124
BUG: 1240577
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12191
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Luis Pabon <lpabon@redhat.com>
commit 1214adb7b28908ba4c55014a2ac8d3822412a33c
Author: hari gowtham <hgowtham@redhat.com>
Date: Mon Oct 5 16:17:02 2015 +0530
gluster v status --xml for a replicated hot tier volume
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volStatus>
<volumes>
<volume>
<volName>tiervol</volName>
<nodeCount>11</nodeCount>
<hotBricks>
<node>
<hostname>10.70.42.203</hostname>
<path>/data/gluster/tier/b5_2</path>
<peerid>149ac603-8078-41c5-8f71-7373f2a3016f</peerid>
<status>1</status>
<port>49164</port>
<ports>
<tcp>49164</tcp>
<rdma>N/A</rdma>
</ports>
<pid>8684</pid>
</node>
<node>
<hostname>10.70.42.203</hostname>
<path>/data/gluster/tier/b5_1</path>
<peerid>149ac603-8078-41c5-8f71-7373f2a3016f</peerid>
<status>1</status>
<port>49163</port>
<ports>
<tcp>49163</tcp>
<rdma>N/A</rdma>
</ports>
<pid>8687</pid>
</node>
<node>
<hostname>10.70.42.203</hostname>
<path>/data/gluster/tier/b4_2</path>
<peerid>149ac603-8078-41c5-8f71-7373f2a3016f</peerid>
<status>1</status>
<port>49162</port>
<ports>
<tcp>49162</tcp>
<rdma>N/A</rdma>
</ports>
<pid>8699</pid>
</node>
<node>
<hostname>10.70.42.203</hostname>
<path>/data/gluster/tier/b4_1</path>
<peerid>149ac603-8078-41c5-8f71-7373f2a3016f</peerid>
<status>1</status>
<port>49161</port>
<ports>
<tcp>49161</tcp>
<rdma>N/A</rdma>
</ports>
<pid>8708</pid>
</node>
</hotBricks>
<coldBricks>
<node>
<hostname>10.70.42.203</hostname>
<path>/data/gluster/tier/b1_1</path>
<peerid>149ac603-8078-41c5-8f71-7373f2a3016f</peerid>
<status>1</status>
<port>49155</port>
<ports>
<tcp>49155</tcp>
<rdma>N/A</rdma>
</ports>
<pid>8716</pid>
</node>
<node>
<hostname>10.70.42.203</hostname>
<path>/data/gluster/tier/b1_2</path>
<peerid>149ac603-8078-41c5-8f71-7373f2a3016f</peerid>
<status>1</status>
<port>49156</port>
<ports>
<tcp>49156</tcp>
<rdma>N/A</rdma>
</ports>
<pid>8724</pid>
</node>
<node>
<hostname>NFS Server</hostname>
<path>localhost</path>
<peerid>149ac603-8078-41c5-8f71-7373f2a3016f</peerid>
<status>1</status>
<port>2049</port>
<ports>
<tcp>2049</tcp>
<rdma>N/A</rdma>
</ports>
<pid>8678</pid>
</node>
</coldBricks>
<tasks>
<task>
<type>Tier migration</type>
<id>975bfcfa-077c-4edb-beba-409c2013f637</id>
<status>1</status>
<statusStr>in progress</statusStr>
</task>
</tasks>
</volume>
</volumes>
</volStatus>
</cliOutput>
Change-Id: I69252a36b6e6b2f3cbe5db06e9a716f504a1dba4
BUG: 1268810
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12302
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 526de3d985b8791b51f79a8a28f450ac5e41fe64
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Oct 5 21:36:14 2015 +0530
fuse: resolve complete path after a graph switch
If a graph switch has happended as part of a attach-tier,
then there is a chance to hash fops to newly added brick
before fix-layout. This causes on going i/o to fail.
This patch will resolve a path, for graph switch by sending
recursive lookup to the parent directories. Those lookups
will help to heal the directory.
Change-Id: Ia2bb4b43a21e5cc6875ba1205628744c3f0ce4e5
BUG: 1263549
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12184
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 320dff9f9b1d55a064b02ee67728d39a102cb2ce
Author: Richard Wareing <rwareing@fb.com>
Date: Wed Feb 12 18:37:55 2014 -0800
xlators: add JSON FOP statistics dumps every N seconds
Summary:
- Adds a thread to the io-stats translator which dumps out statistics
every N seconds where N is configurable by an option called
"diagnostics.stats-dump-interval"
- Thread cleanly starts/stops when translator is unloaded
- Updates macros to use "Atomic Builtins" (e.g. intel CPU extentions) to
use memory barries to update counters vs using locks. This should
reduce overhead and prevent any deadlock bugs due to lock contention.
Test Plan:
- Test on development machine
- Run prove -v tests/basic/stats-dump.t
Change-Id: If071239d8fdc185e4e8fd527363cc042447a245d
BUG: 1266476
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/12209
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
commit 2a2545bc14c02bace9c7ca4d6451142d90a54175
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Oct 7 17:43:33 2015 +0530
cluster/afr: Handle stack reset failures
When all the bricks go down in the middle of the self-heal, in AFR_STACK_RESET
afr_local_init will fail because all the bricks are down. So local will remain
NULL for the frame. This leads to crashes as this failure is not handled in
both entry and data self-heals.
Change-Id: I71a02f161f2c4dbfdc8bb7f2a6f32807191ed253
BUG: 1269470
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12309
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 909a848e7c3befe7770a051ed9adee1a75b5e174
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Oct 6 13:05:57 2015 +0530
glusterd/add-brick: change add-brick implementation to v3 framework
add-brick commit first happens on local node and followed by peers.
As part of the commit of local-host glusterd will send the updated
volfiles to the clients connected to the local-host even before the
commit of peers happen. If any of the newly added brick was hosted
by any peer, that brick won't be started when client (connected to
local-host) try to send fops.
By changing to v3 framework we can send post validate ops
after commit operation that helps to send volfile fetch request only
after completing commits on all nodes.
Change-Id: Ib7312e01143326128c010c11fc2ed206f37409ad
BUG: 1263549
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12237
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 0e56fb85b4b1d15c5ede54106f367c572dff2ae5
Author: vmallika <vmallika@redhat.com>
Date: Tue Oct 6 18:16:49 2015 +0530
quota: use copy_frame when creating new frame during quota_check_limit
DHT re-balance, sets frame root PID < 0 and quota_check_limit skips
enforcement if this PID is less than 0.
When creating new frame for quota_check_limit we need to use
copy_frame instead of create_frame, so that all auth information
are copied from original frame.
Change-Id: Ib3b4a3744f8b0d72a8bc32826f6edae836d6faed
BUG: 1267812
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12265
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 40dc969a32503242835f15c11f5364410299a00f
Author: hari gowtham <hgowtham@redhat.com>
Date: Mon Oct 5 17:13:44 2015 +0530
Tier/cli: number of bricks remains the same in v info --xml
The number of bricks count remains one for the cold type.
Actual result:
<numberOfBricks>1 x 2 = 2</numberOfBricks>
Expected result:
<numberOfBricks>3 x 2 = 6</numberOfBricks>
Change-Id: I31480a7808b248ef9ea805cb64f7663d44647ddf
BUG: 1268822
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12303
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit b767c75de060b473256c47990b04a6b92a08b642
Author: Susant Palai <spalai@redhat.com>
Date: Thu Oct 1 04:06:43 2015 -0400
dht/rebalance: fix layout and dict leaks
Change-Id: Ib3911dfa1f950ff9decbe249ad798e97226dd06d
BUG: 1266877
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/12295
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit ebb8946a5b0932aa5fdfeace2191401c85604219
Author: Ashish Pandey <aspandey@redhat.com>
Date: Sun Aug 30 21:24:32 2015 +0530
cluster/ec : Mark new entry changelog in entry self-heal
Problem :
When a new entry is created dirty mark xattrs are not
created this will need full heal to be performed, even
when there are partial failures.
Solution :
Marks new entry changelog in self-heal.
PS: Also fixed erasing of dirty markers when no data heal
is required.
BUG: 1254121
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Change-Id: I156e3d3201afa77efe118e1aaace1d91c90a9613
Reviewed-on: http://review.gluster.org/11938
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 882fe874a08570183fa7f1e7fb39abaf1a6f7a12
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Oct 5 15:30:03 2015 +0530
features/shard: Use the xattr rsp dict to pick shard xattrs in xattrop cbk
The change http://review.gluster.org/#/c/11938/ makes a fix in posix translator
which would cause sharding to fail fops post xattrop without this patch.
Change-Id: If096965b319f393608b0f763402b9b90acb61492
BUG: 1268796
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12300
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 839dfff2738b150b2ec602ba0ba658ed81404f6e
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Oct 5 12:59:18 2015 +0530
tier/cli : throw a warning when user issues a detach-tier commit/force command
Change-Id: Idf7664d509156ce46ef4308ffc07fb556a0aedd2
BUG: 1268755
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/12297
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 6ad5950e4b4711dbbf7bc6bdef5d9475c1ddfa82
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Oct 5 14:55:59 2015 +0530
tests: Move tests/bugs/shard/bug-1245547.t to bad tests list
Change-Id: I389f88cefdeee87b99dcacbac48d2dcc70a97979
BUG: 1268796
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12299
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit bb93bb75311359dae0eb387e2ed1e40c7de656be
Author: Anuradha Talur <atalur@redhat.com>
Date: Mon Oct 5 12:54:34 2015 +0530
tests: Adding bug-1221481-allow-fops-on-dir-split-brain.t to bad test
Adding bug-1221481-allow-fops-on-dir-split-brain.t to bad test as it
is failing spuriously. Will be removed after the failure is
root caused and fixed.
Change-Id: I26b634f01dfa2c60eed21a1286aa83ecaa75fa26
BUG: 1268790
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12298
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 7d47b2519d905e7f11c2107f57c224446cabc489
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Fri Aug 21 00:08:23 2015 +0530
server/protocol: option for dynamic authorization of client permissions
problem:
assuming gluster volume is already mounted (for gfapi: say client transport
connection has already established), now if somebody change the volume
permissions say *.allow | *.reject for a client, gluster should allow/terminate
the client connection based on the fresh set of volume options immediately,
but in existing scenario neither we have any option to set this behaviour nor
we take any action until and unless we remount the volume manually
solution:
Introduce 'dynamic-auth' option (default: on).
If 'dynamic-auth' is 'on' gluster will perform dynamic authentication to
allow/terminate client transport connection immediately in response to
*.allow | *.reject volume set options, thus if volume permissions have changed
for a particular client (say client is added to auth.reject list), his
transport connection to gluster volume will be terminated immediately.
Change-Id: I6243a6db41bf1e0babbf050a8e4f8620732e00d8
BUG: 1245380
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/12229
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 63aeeb48d432f8bbf54600363014636a08636ec4
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Sep 10 12:40:17 2015 +0000
rpc: Remove unused function
Change-Id: I0b96b83ad8d06de9b2f5fc14073b94777885a775
BUG: 1261927
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/12153
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit cc11ee4aaf88eb64bb10eaf260d18a38e2d887c3
Author: Sakshi <sabansal@redhat.com>
Date: Wed Sep 23 15:16:34 2015 +0530
glusterd: validate function for replica volume options
Change-Id: I5b4a28db101e9f7e07f4b388c7a2594051c9e8dd
BUG: 1265479
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/12215
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a8e7e9a0c443947e853e7cd29c1636a4e5025067
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Sep 30 16:41:19 2015 +0530
cli/tier : fixes cli crash when user tries "gluster v tier" command
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Change-Id: I919d8935c849f9be6b2cb43e8332afb821778d89
BUG: 1267539
Reviewed-on: http://review.gluster.org/12258
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 1ef572abc7e91b9951684abf686d49d28fd72e1f
Author: Susant Palai <spalai@redhat.com>
Date: Mon Sep 28 02:22:07 2015 -0400
dht/rebalance: fix mem-leak in migration code path
Change-Id: I37faf983fc02996541f3d96a17cb2a2c2cdb6781
BUG: 1266877
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/12235
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 551d737497138635902542d62b4843ef2aea53a4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Sep 28 13:09:38 2015 +0530
storage/posix: Reduce number of getxattrs for internal xattrs
Most of the gluster internal xattrs don't exceed 256 bytes. So try
getxattr with ~256 bytes. If it gives ERANGE then go the old way
of getxattr with NULL 'buf' to find the length and then getxattr with
allocated 'buf' to fill the data. This way we reduce lot of getxattrs.
Change-Id: I716d484bc9ba67a81d0cedb5ee3e72a5ba661f6d
BUG: 1265893
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12240
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 533342c04cfa40303be1d9d12049a281454ab3fa
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Sep 23 18:56:01 2015 +0530
glusterd, dht: volume set for use-readdirp in dht
Change-Id: Icab246b1d02808864d878d949fa56f9f889b538a
BUG: 1265677
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12221
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 971ebb1a6669857d1947f8a1bc7ffffd2bbd8745
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Sep 9 13:03:37 2015 +0530
quota : xml output modified to give exact available space in bytes
Currrently, 'gluster v quota <VOLNAME> list' command rounds off the
available space and shows it to the user. Now, 'gluster v quota
<VOLNAME> list --xml' command is modified to show the exact available
space in bytes.
Change-Id: I3772e036a2537c1df12f22cf32dfe4ac7940988f
BUG: 1261404
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/12137
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 1004be6c7083eae7e936e4b29da0fae48f29ce98
Author: vmallika <vmallika@redhat.com>
Date: Tue Sep 29 15:27:47 2015 +0530
quota/marker: marker code cleanup
marker is re-factored with syncop approach,
remove unused old code
Change-Id: I36e670e63b6c166db5e64d3149d2978981e2f7c2
BUG: 1240581
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11560
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 839ecb5b688221aed6f769b1b9983d892eb91c92
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Sep 29 12:31:22 2015 +0530
tests: Move georep-basic-dr-tarssh.t to bad tests
Geo-rep tests are failing spuriously in few
regression machines. Hence moving it to bad
till the issue is root caused and fixed.
Change-Id: I25feb8d9c51e03aa9ac0fe70291dc9e54ad043f9
BUG: 1227624
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12248
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit c727efe42a4006ae67986658bd069fe58e1bed55
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Sep 22 15:44:30 2015 -0400
cluster/tier re-enable tier.t in automatic tests
Re-enable tier.t in automatic tests. Disable check
for BSD until recurring problem with SQLlite on it is understood.
Change-Id: Ib13b269ab841a59a0a41d8478c8627b180b16c61
BUG: 1231268
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12208
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 589c7f07c06f57773b5bc9c35c0f1150095e220e
Author: hari gowtham <hgowtham@redhat.com>
Date: Thu Sep 10 20:15:35 2015 +0530
Tier/cli: tier related information in volume info xml
gluster v info didnt differentiate the hot bricks and cold bricks
and other few values
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volInfo>
<volumes>
<volume>
<name>rmbr</name>
<id>72d223fc-96ba-4f4a-ac6e-0d0bc16ef127</id>
<status>1</status>
<statusStr>Started</statusStr>
<brickCount>3</brickCount>
<distCount>1</distCount>
<stripeCount>1</stripeCount>
<replicaCount>1</replicaCount>
<disperseCount>0</disperseCount>
<redundancyCount>0</redundancyCount>
<type>5</type>
<typeStr>Tier</typeStr>
<transport>0</transport>
<xlators/>
<bricks>
<hotBricks>
<hotBrickType>Distribute</hotBrickType>
<numberOfBricks>1</numberOfBricks>
<brick uuid="81">v1:/hb1<name>v1:/hb1</name><hostUuid>81</hostUuid></brick>
</hotBricks>
<coldBricks>
<coldBrickType>Distribute</coldBrickType>
<numberOfBricks>2</numberOfBricks>
<brick uuid="81">v1:/br1<name>v1:/br1</name><hostUuid>81</hostUuid></brick>
<brick uuid="81">v1:/br2<name>v1:/br2</name><hostUuid>81</hostUuid></brick>
<count>0</count>
</coldBricks>
</bricks>
</volume>
</volumes>
</volInfo>
</cliOutput>
Change-Id: I6e52541bb6d8a6a17e17bfcb42434beaac13db56
BUG: 1261837
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12158
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit c0b38587a0b8dc3911040b07dae0f5ced742f8df
Author: Anoop C S <anoopcs@redhat.com>
Date: Sat Sep 12 19:48:06 2015 +0530
protocol/client: Remove dead code from client_rpc_notify
Normally GF_EVENT_CHILD_UP is dispatched after client
handshake. But we have some dead code in client_rpc_notify
which is assumed to do the same on receiving RPC_CLNT_CONNECT.
This dispatch is based on a condition whether "disable-handshake"
is enabled or not. Since we require client-handshake everytime
we have a connect this check for "disable-handshake" is invalid
and no longer required. Moreover this option is never handled
in any of the translators.
Change-Id: Ic862d6ac08cd3b18cf231f50140cd00e84e52ca0
BUG: 1227667
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/12170
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 0920a2a5c6304b9ed772e576df1746ed25421902
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Sep 7 14:29:15 2015 +0530
gfapi: transport and port are optional for glfs_set_volfile_server
Only server is the required argument for glfs_set_volfile_server
and both transport and port are optional. When glfs_set_volfile_server
is invocated multiple times, only on the first invocation we replace
port 0 with 24007 and transport NULL with "tcp".
Hence, replacing the parameters at the entry function is the right way.
Change-Id: If9f4a5f7fd9038eed140e2f47167a8fd11acc2f6
BUG: 1260561
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/12114
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 07f50926ad2fcc66026e49020f2d46732de2a082
Author: vmallika <vmallika@redhat.com>
Date: Tue Sep 22 12:17:50 2015 +0530
posix: xattrop 'GF_XATTROP_ADD_ARRAY_WITH_DEFAULT' implementation
Implementation of xattrop type:
GF_XATTROP_ADD_ARRAY_WITH_DEFAULT
GF_XATTROP_ADD_ARRAY64_WITH_DEFAULT
These operations are similar to 'GF_XATTROP_ADD_ARRAY',
except that it adds a default value if xattr is missing
or its value is zero on disk.
One use-case of this operation is in inode-quota.
When a new directory is created, its default dir_count
should be set to 1. So when a xattrop performed setting
inode-xattrs, it should account initial dir_count
1 if the xattrs are not present
Here is the usage of this operation
value required in xdata for each key
struct array {
int32_t newvalue_1;
int32_t newvalue_2;
...
int32_t newvalue_n;
int32_t default_1;
int32_t default_2;
...
int32_t default_n;
};
or
struct array {
int32_t value_1;
int32_t value_2;
...
int32_t value_n;
} data[2];
fill data[0] with new value to add
fill data[1] with default value
xattrop GF_XATTROP_ADD_ARRAY_WITH_DEFAULT
for i from 1 to n
{
if (xattr (dest_i) is zero or not set in the disk)
dest_i = newvalue_i + default_i
else
dest_i = dest_i + newvalue_i
}
value in xdata after xattrop is successful
struct array {
int32_t dest_1;
int32_t dest_2;
...
int32_t dest_n;
};
Change-Id: Ic6a08473e99fd98299a839d4d8416081a7534efd
BUG: 1243946
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11702
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ad7e70319dc7a754cbd013c6ffe3ea2cfe045205
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Sep 23 21:41:55 2015 +0530
storage/posix: Prevent extra handle-path
In readdirp_fill we already have the path of the file/directory.
No need to construct handle-path again. This saves two lstats and
at least two readlink calls per directory.
Change-Id: I8d1b2afeda3e053265a243d4e9a101192f5f509e
BUG: 1265893
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/12222
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 961d6870d79230a399caa67184d5b2aa43e754ce
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Sep 21 16:57:07 2015 +0530
features/shard: Port log messages to new framework
Change-Id: Iac01e6a89a0d0c37a12a5e47f17f7ced85a31590
BUG: 1265516
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12217
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit cf74db924d9ee17cb1a9595256d43523d0d49a71
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Jul 31 14:11:15 2015 -0400
build: export minimum symbols from xlators for correct resolution
We've been lucky that we haven't had any symbol collisions until now.
Now we have a collision between the snapview-client's svc_lookup() and
libntirpc's svc_lookup() with nfs-ganesha's FSAL_GLUSTER and libgfapi.
As a short term solution all the snapview-client's FOP methods were
changed to static scope. See http://review.gluster.org/11805. This
works in snapview-client because all the FOP methods are defined in
a single source file. This solution doesn't work for other xlators
with FOP methods defined in multiple source files.
To address this we link with libtool's '-export-symbols $symbol-file'
(a wrapper around `ld --version-script ...` --- on linux anyway) and
only export the minimum required symbols from the xlator sharedlib.
N.B. the libtool man page says that the symbol file should be named
foo.sym, thus the rename of *.exports to *.sym. While foo.exports
worked, we will follow the documentation.
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
BUG: 1248669
Change-Id: I1de68b3e3be58ae690d8bfb2168bfc019983627c
Reviewed-on: http://review.gluster.org/11814
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 979131b5406d9e9eaf0bcffe15eb19686c15b2bf
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Fri Sep 11 14:25:14 2015 +0530
extras/hookscripts : introducing additional check in S31ganesha-start.sh
New export file with default configuration will be created for a volume
when it is started again. This patch will create new export file only
when it is not present. This change is required for scenarios such as
snapshot restore , node reboot etc.
Change-Id: I34123911f176dcb29d5c016aa097af3a3b2c727b
BUG: 1261444
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/12159
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 38ed7263eabf4a73892fc6ec64ce92e7ec36b222
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Sep 23 08:27:25 2015 +0530
heal: remove glfsh_print_brick()
Use glfsh_print_brick_from_xl() instead so that the hostname:brickpath
displayed when heal info is run is consistent with other gluster cli
commands like `gluster volume info`.
Change-Id: I30ee3d76d0f68991a25bd678d40ec3bf7e0538c7
BUG: 1265470
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12212
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
commit b1be1b858fe6db35873b59b51866d633d625f923
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Sep 8 18:08:20 2015 +0530
features/shard: Performance improvements in IO path - Part 2
This is change 2/2 of the performance improvements for sharding.
The changes are with respect to maintaining up-to-date values of
file attributes in [f]stat, [f]setattr, link, and [f]truncate
codepaths.
Change-Id: Ia3ce4664fb33be869e4dc76494adbe9c314cc098
BUG: 1258905
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12138
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 711396d98188046ba8704f69aa68247472b9ebbd
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Sep 7 14:57:24 2015 +0530
features/shard: Performance improvements in IO path
This is patch 1/2 of the performance improvement work
for sharding in the IO path.
What this patch does:
Since the primary use-case where sharding is targeted -
VM store - is a single-writer workload, instead of
performing lookup on the base file everytime to gather the
size and block count from the backend in reads, writes and
truncate, now the size and block count is also cached and
kept up-to-date after every inode write in the inode ctx.
TO-DO:
Make changes in rename, link, unlink, [f]setattr and [f]stat
to keep the relevant iatt members up-to-date in the inode ctx.
Change-Id: Ica87d020dabc3a3dbccec814b26b01d6a629ff4d
BUG: 1258905
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12126
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 5842c9f83696e1132640f5826a3d604ebc6b73c3
Author: Sakshi <sabansal@redhat.com>
Date: Mon Jun 22 15:52:22 2015 +0530
glusterfsd : newly added brick receives fops only after it is started
When new bricks are added in the middle of an on-going
fop like 'rm', the volfile changes without waiting for
the newly added bricks to get port. Fops are sent to all
bricks and may fail on some with ENOTCONN as these bricks
may not have a port yet.
This patch ensures that the volfile change happens only
after all the bricks have a port.
Change-Id: I7ed2413475f80d0cc8849fed33036ade8d75a191
BUG: 1233151
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/11342
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
commit d5236024f166843bae23b6285cb5b0d421ecca6f
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Sep 1 15:31:02 2015 +0530
cluster/tier: Handle FOPs on files being migrated
Determine which DHT level is responsible for
handling fops on a file undergoing migration based
on the name of the the linkto xattr set on the file
being migrated and process accordingly.
Change-Id: I82772e39314d4fe7f2ba0dcf22de0c6a374ee139
BUG: 1254428
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12090
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 9dc789eac96ca145fc5140e883be0ab01f7d612f
Author: Sakshi <sabansal@redhat.com>
Date: Thu May 28 10:49:36 2015 +0530
glusterd : check if all bricks are started before performing remove-brick
Change-Id: Ie9e24e037b7a39b239a7badb983504963d664324
BUG: 1225716
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/10954
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 8acd51a64b7d49b6671ca2bef180bcc0cedf6d9e
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Wed Sep 9 17:46:16 2015 +0530
glusterd/utils: glusterd_copy_file does not truncate target file
glusterd_copy_file function copies source file to target. If
the target file already exists and is bigger than the source
file then it can cause file corruption.
Target file should be truncated before copying source content.
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Change-Id: Ie973f3e9fa06309ded6f69dcde41e1b60b3e028e
BUG: 1261482
Reviewed-on: http://review.gluster.org/12141
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bbcbba52676e8b9b34fb4b2e987b6f0b23aa9de0
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Sep 10 16:07:29 2015 +0530
Tier/cli: Change detach-tier commit force to detach-tier force
Current detach-tier cli command support commit force.
Deprecating the same to force.
So the new syntax would be:
volume detach-tier <VOLNAME> <start|stop|status|commit|force>
Change-Id: Ie86dfd72341078c0a1be94767f523730911312ef
BUG: 1261862
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12151
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 47b7b94e8671a62161bd718f37292eb277de97a0
Author: vmallika <vmallika@redhat.com>
Date: Mon Sep 7 12:43:07 2015 +0530
marker: don't account destination linkto-file during internal migration
During a DHT re-balance operation, quota accounts for the destination.
Problem of accounting this destination file are:
1) Migration is an internal operation, 'quota list' shows more usage on the CLI
and this will come to the normal numbers once the migration is complete
2) If the usage is close to the limit set, then we can get 'Disk Quota
Exceeded' errors in the I/O path during file migration
Solution is we should not account of the usage on the destination file
during migration, at the end of the migration. We need to reduce size of
the source directory and accounting for the migrated dest file
We assume that there are sufficent disk space in the back-end. DHT
migrator should make sure that there are sufficient disk space before it
starts the migration process.
Change-Id: Ie3cfe3e4ab5241c2a127ba0edc599a053d30c3a0
BUG: 1260545
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12113
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 12e106da6e3ced5d69b610c5c5465c08ac48c41f
Author: hari gowtham <hgowtham@redhat.com>
Date: Wed Sep 9 19:17:17 2015 +0530
Tiering: change in status for remove brick and rebalance
when we trigger a detach tier start on a tier vol,
it shows in the volume status task as "remove brick" instead of "Detach tier"
Status of volume: vol1
Gluster process TCP Port RDMA Port Online Pid
------------------------------------------------------------------------------
Hot Bricks:
Brick 10.70.42.171:/data/gluster/hbr1 49154 0 Y 25098
Cold Bricks:
Brick 10.70.42.171:/data/gluster/p1 49152 0 Y 25101
Brick 10.70.42.171:/data/gluster/p2 49153 0 Y 25112
NFS Server on localhost N/A N/A N N/A
Task Status of Volume vol1
------------------------------------------------------------------------------
Task : Tier migrate
ID : e11d5a3d-b1ae-4c3f-8f95-b28993c60939
Status : in progress
Status of volume: vol1
Gluster process TCP Port RDMA Port Online Pid
------------------------------------------------------------------------------
Hot Bricks:
Brick 10.70.42.171:/data/gluster/hbr1 49154 0 Y 25098
Cold Bricks:
Brick 10.70.42.171:/data/gluster/p1 49152 0 Y 25101
Brick 10.70.42.171:/data/gluster/p2 49153 0 Y 25112
NFS Server on localhost N/A N/A N N/A
Task Status of Volume vol1
------------------------------------------------------------------------------
Task : Detach tier
ID : 76d700b1-5bbd-43ed-95fd-1640b2b4af31
Status : completed
Change-Id: I4bd3b340d4e700e8afed00e1478b8a8b54dfe2e2
BUG: 1261837
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12149
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit c8ade120202ea96dbcb2476c8633b5ca85026f27
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Sep 10 14:19:06 2015 +0530
Tier/glusterd: Do not allow attach-tier if remove-brick is not committed
When attaching a tier, if there is a pending remove-brick
task, then should not allow attach-tier. Since we are not
supporting add/remove brick on a tiered volume, we won't
able to commit pending remove-brick after attaching the
tier
Change-Id: Ib434e2e6bc75f0908762f087ad1ca711e6b62818
BUG: 1261819
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12148
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit e11d7a4139f493d00a71b0b29f85c72c9f8a38f2
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Sep 10 11:52:27 2015 +0530
tier/glusterd: volume status failed after detach start
After triggering detach start on a tiered volume fails.
This because of brick count was wrongly setting in rebal
dictionary.
Change-Id: I6a472bf2653a07522416699420161f2fb1746aef
BUG: 1261757
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12146
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit b9dd3ab964cdc595d43f2a1e5e5b49032b7e1336
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Sep 15 11:07:03 2015 +0530
Tier/cli: tier related information in volume status command
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volStatus>
<volumes>
<volume>
<volName>v1</volName>
<nodeCount>5</nodeCount>
<hotBrick>
<node>
<hostname>10.70.42.203</hostname>
<path>/data/gluster/tier/hbr1</path>
<peerid>137e2a4f-2bde-4a97-b3f3-470a2e092155</peerid>
<status>1</status>
<port>49154</port>
<ports>
<tcp>49154</tcp>
<rdma>N/A</rdma>
</ports>
<pid>6535</pid>
</node>
</hotBrick>
<coldBrick>
<node>
<hostname>10.70.42.203</hostname>
<path>/data/gluster/tier/cb1</path>
<peerid>137e2a4f-2bde-4a97-b3f3-470a2e092155</peerid>
<status>1</status>
<port>49152</port>
<ports>
<tcp>49152</tcp>
<rdma>N/A</rdma>
</ports>
<pid>6530</pid>
</node>
</coldBrick>
<coldBrick>
<node>
<hostname>NFS Server</hostname>
<path>10.70.42.203</path>
<peerid>137e2a4f-2bde-4a97-b3f3-470a2e092155</peerid>
<status>1</status>
<port>2049</port>
<ports>
<tcp>2049</tcp>
<rdma>N/A</rdma>
</ports>
<pid>6519</pid>
</node>
</coldBrick>
<tasks>
<task>
<type>Rebalance</type>
<id>8da729f2-f1b2-4f55-9945-472130be93f7</id>
<status>4</status>
<statusStr>failed</statusStr>
</task>
</tasks>
</volume>
<tasks/>
</volume>
</volumes>
</volStatus>
</cliOutput>
Change-Id: Idfdbce47d03ee2cdbf407c57159fd37a2900ad2c
BUG: 1263100
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12176
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 70af8233ba20353b78cd2599fb334dd9366a72d0
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jul 21 18:14:22 2015 +0530
tier/dht: unlink fails after lookup in a directory
unlink fails with invalid argument for files that
are being present on cold tier, before attaching.
All of the fops will be hashed to hot_tier after
attach-tier (unless explicitly set the "rule"
option). Lookups sent to directory, will eventually
search the directory using readdirp, and will
populate inode_ctx for the inodes based on the output,
in respective dht_xlators. So the readdirp will
populate inodes_ctx for the files (that is already
present in volume before attaching) in cold-dht
only because it got the entries from the cold-tier.
So when an unlink comes on such an inode, the lookup
associated with the unlink will be send as a
re validate request to cold-tier only, since
already a lookup was performed on the inode,
and the new lookup will succeed. So from the
unlink of dht, it will hash to cold-tier but the
cached_subvol will be cold, since there is a
mismatch in hash and cach , it chose hashed
subvolume and will sent the fop to hot dht,
and the fops fail with EINVAL from the hot-dht
since it does not have inode_ctx stored for
that inode (because, no lookup was performed
from hot-dht).
Change-Id: Ib7c14a9297a22d615f7a890a060be4809b5a745a
BUG: 1236032
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/11675
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 05926f3bf92dfa8eee4c9b2aac72675c07aa680d
Author: hari gowtham <hgowtham@redhat.com>
Date: Tue Sep 15 14:57:24 2015 +0530
Tiering:Changing error message as detach-tier instead of "remove-brick"
Change-Id: Id93424a08f601a8d7540d96a47ed2b0497d4a631
BUG: 1263177
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12177
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 2fd2660d7fd8172482a2168c6f6c391fc049f973
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Sep 15 16:05:25 2015 +0530
tier/cli : adding a check for gluster v tier help command
Currently, 'gluster v tier/attach-tier/detach-tier help' command
shows the usage, and then prints 'Tier command failed'. With this
patch the error message is removed.
Change-Id: I1679fe3303d73ba6b6fdbb7ee18028062d446f39
BUG: 1263224
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/12181
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 75cbf0e2666ff949390ebea6fa2131d630342799
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed Sep 16 10:26:44 2015 -0400
cluster/tier do not flag migration error on already migrated file
In some cases a brick will try to migrate a file that has already
been migrated. This is a legal case, e.g. when both bricks
are replica pairs.
Change-Id: If2578b947014cbbdfb3c6591db9044d6b1d92774
BUG: 1263726
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12185
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Joseph Fernandes
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6df35f9dba1048f4c8aa897f58586cb213f0021e
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Tue Sep 15 16:07:32 2015 +0530
cluster/tier: Fixed a crash in tiering
An incorrect check was causing the arguments to
the promote thread to be cleared before the thread
was done with them. This caused the process to crash
when it tried to dereference a NULL pointer.
Change-Id: I8348309ef4dad33b7f648c7a2c2703487e401269
BUG: 1263204
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12179
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Joseph Fernandes
commit 32bcb16fd3a50714a4a6602086c6e0cf38a39e35
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Sep 14 15:43:31 2015 +0530
afr: perform replace-brick in a synctask
Problem:
replace-brick setxattr is not performed inside a synctask. This can lead
to hangs if the setxattr is executed by epoll thread, as the epoll
thread will be waiting for replies to come where as epoll thread is the
thread that needs to epoll_ctl for reading from socket and listen.
Fix:
Move replace-brick to synctask to prevent epoll thread hang.
This patch is in line with the fix performed in
http://review.gluster.org/#/c/12163/
Change-Id: I6a71038bb7819f9e98f7098b18a6cee34805868f
BUG: 1262345
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12169
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit e041dd0f03e66def0526004cc5f7ecff956bf327
Author: anand <anekkunt@redhat.com>
Date: Tue Sep 15 12:05:51 2015 +0530
systemd/spec/glusterd: Adding EnvironmentFile in glusterd systemctrl service file.
Issue: glusterd was not running in debug mode, this is because of
"systemctrl start glusterd" was not reading configuration from glusterd-sysconfig file.
Fix: Set glusterd-sysconfig file as "EnvironmentFile" and pass args to glusterd.
Change-Id: I6a032a2e86e5a25c39199ddf953bfbd6590d53b6
BUG: 1263087
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/12175
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bc872610d1e24968ec1fd2437cb39de3ff0d25e3
Author: Akhil Bhansali <bhansaliakhil@gmail.com>
Date: Thu Sep 10 15:56:21 2015 +0530
BZ 789278: Coverity bug fixes for logically dead code
Removing the logically dead code as reported by coverity tool run
on GlusterFS.
The code changes are removal of logically dead code, hence did not
run the testcases.
CIDs Fixed starts from 1292652 to 1292663 in sequence.
Signed-off-by: Akhil Bhansali <bhansaliakhil@gmail.com>
Change-Id: I05b35f744c89b5e49b6322635c7a0d367ef10abb
BUG: 789278
Reviewed-on: http://review.gluster.org/12150
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d02c7303e88489f7296794855b88eb0dbe87679b
Author: Sakshi <sabansal@redhat.com>
Date: Mon Aug 31 16:06:35 2015 +0530
dht: reverting changes that takes lock on all subvols to prevent rmdir vs lookup selfheal race
Locking on all subvols before an rmdir is unable to remove all
directory entries. Hence reverting the patch for now.
Change-Id: I31baf2b2fa2f62c57429cd44f3f229c35eff1939
BUG: 1245065
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/12125
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 06acbf13b35e660cbb59c7841d00a6eb3c1363c6
Author: Anuradha Talur <atalur@redhat.com>
Date: Fri Sep 11 18:43:36 2015 +0530
afr : get split-brain-status in a synctask
On executing `getfattr -n replica.split-brain-status <file>` on mount,
there is a possibility that the mount hangs. To avoid this hang,
fetch the split-brain-status of a file in synctask.
Change-Id: I87b781419ffc63248f915325b845e3233143d385
BUG: 1262345
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/12163
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit 7713a122516ea1915936276df0da7ff57ec2cb58
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Sep 10 11:27:42 2015 +0530
tier/glusterd : Disable subvol match check during detach tier
For tiering, user does not have authorization to choose
for bricks to detach, so we don't need to whether subvols
match for the bricks or not.
Change-Id: I7e777ccc1aa261f652f9b158718fcd55185c7794
BUG: 1261741
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12145
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit a0b5c8b290485a4d77eadecd04156c0732134d96
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Fri Sep 11 22:18:03 2015 +0530
cluster/dht : Propagate op_errno on failure
Fixed issue where dht_selfheal_layout_lock_cbk does not propagate
the op_errno.
Change-Id: I0b968339db65d2969e36e64407eeb724cc6516bd
BUG: 1262438
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12165
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit d613f6c8d3351a3cb5ee7b449ba3c1ee374f2244
Author: Susant Palai <spalai@redhat.com>
Date: Fri Sep 11 08:52:44 2015 -0400
dht/cluster: Avoid crash if local is NULL
This patch addresses crash handling if local is NULL. In addition to that,
we were not unwinding if no lock is taken in dht_linkfile_create_cbk(create/mknod).
This patch handles that also.
Change-Id: Ibcff317f10d60e7865fd7ffb9479b3af53c9ef17
BUG: 1260051
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/12160
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 624511f11540b919576d2431ddee234cec5da2ef
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Sep 9 08:34:08 2015 +0530
features/shard: Add appropriate NULL checks to prevent excessive logging
Also,
1) the getxattr() callback must check for the fop return status
before attempting to delete the internal keys.
2) the correct dict was not being used in shard_getxattr_cbk(). This
patch also fixes that issue.
Change-Id: I516a1d98e112b572bcec7d1f1e03e23152567be3
BUG: 1260637
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12136
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 8d41196573655c76d54ce154d98ff735bb7507c0
Author: Dan Lambright <dlambrig@redhat.com>
Date: Thu Sep 10 15:25:55 2015 -0400
cluster/tier fix bug with sql includes introduced by 12031
We accidentally introduced a bug where client translators have a
dependency on sql. This broke freebsd smoke tests. Fix is to
abstract from the client those dependencies.
Change-Id: I7152573a489bacc8f32e6eb139f9ff4408288f5b
BUG: 1260730
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12155
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 21a2c162cab4c9a7a987a46a4327fb17916f9528
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri Sep 11 06:56:47 2015 -0700
Revert "gluster/tier Remove tier.t from spurious failure list"
This reverts commit 3a6e397bccf7ebaf9528617f5615553670211edf.
Change-Id: I7bed21be205dea14c8b0f462bfb117febec5b1b4
Reviewed-on: http://review.gluster.org/12164
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1e335c597add596bc3ab971c3e89472f57907e35
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Aug 17 15:09:57 2015 +0530
nfs : logging improvements
NFS log-warning messages logged twice in cbk function. Though,
the logging messages are not exactly duplicate, instead of
logging twice, they can be merged to one log message and the
other log message is removed in cbk functions.
Example:
(1)
W [nfs3.c:2075:nfs3svc_write_cbk] 0-nfs: 16f4dce6:
/f.195 => -1 (Disk quota exceeded)
(2)
W [nfs3-helpers.c:3443:nfs3_log_write_res] 0-nfs-nfsv3:
XID: 16f4dce6, WRITE: NFS: 69(Resource (quota)
hard limit exceeded), POSIX: 122
(Disk quota exceeded), count: 0, UNSTABLE,
wverf: 1381508849
Here, the second message is more elaborative, and is similar
to (1). Since file name is not present in (2), it is added to (2)
and then removing all mesages of type (1).
Change-Id: I6028ab17b23948493a065dfad92fe4984548511f
BUG: 1254146
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/11936
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 0299e5866e87afc56cb4a6670d8053253e4e4b8c
Author: anand <anekkunt@redhat.com>
Date: Sat Aug 22 01:09:53 2015 +0530
firewall/spec: Create glusterfs firewall service if firewalld installed.
It creates glusterfs firewall service during installation.
glusterfs service : It contains all default ports which needs to be opened.
During installation glusterfs.xml is copied into firewall service directory(/usr/lib/firewalld/services/).
Note:
1.For bricks: It opens the 512 ports, if brick is running out side this range(>49664) then admin need to open the port
for that brick.
2.By default this service is not enabled in any of zone.
To enable this service(glusterfs) in firewall:
1. Get active zone(s) in node
firewall-cmd --get-active-zones
2. Attached this service(glusterfs) to zone(s)
firewall-cmd --zone=<zone_name> --add-service=glusterfs --To apply runtime
firewall-cmd --permanent --zone=<zone_name> --add-service=glusterfs --To apply permanent
Note:
we can also use firewall-config which gives GUI to configure firewall.
Change-Id: Id97fe620c560fd10599511d751aed11a99ba4da5
BUG: 1253967
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/11989
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e7e741fea388b6d7e5f88ca21221ca4f47753b54
Author: Susant Palai <spalai@redhat.com>
Date: Fri Sep 4 05:14:05 2015 -0400
dht/remove-brick: Avoid data loss for hard link migration
Problem: If the hashed subvol of a file has reached cluster.min-free-disk,
for a create opertaion a linkto file will be created on the hashed and
the data file will be created on some other brick.
For creation of the linkfile we populate the dictionary with linkto key
and value as the cached subvol. After successful linkto file creation,
the linkto-key-value pair is not deleted form the dictionary and hence,
the data file will also have linkto xattr which points to itself.This looks
something like this.
client-0 client-1
-------T file rwx------file
linkto.xattr=client-1 linkto.xattr=client-1
Now coming to the data loss part. Hardlink migration highly depend on this
linkto xattr on the data file. This value should be the new hashed subvol
of the first hardlink encountered post fix-layout. But when it tries to
read the linkto xattr it gets the same target as where it is sitting.
Now the source and destination are same for migration. At the end of
migration the source file is truncated and deleted, which in this case
is the destination and also the only data file it self resulting in
data loss.
Change-Id: I36b1d105752bd9467757ecf3f103b45c666783d6
BUG: 1260051
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/12105
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit baf9f6392b4218a3eddcf9f7e91e05b28a851330
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Sep 9 17:25:14 2015 +0530
features/shard: Do not return non-negative status on failure in writev
Change-Id: I5f65c49484e44a05bb7df53c73869f89ad3392e0
BUG: 1261399
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12140
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 3a40677872d8fdc41ce17c29f3dac48046e13774
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Sep 8 12:26:47 2015 -0400
gluster/tier Remove tier.t from spurious failure list
The spurious failure was related to database lock contention,
and was fixed in patch 12031.
Ran tier.t in loop (very many) times successfully to confirm fixed.
Change-Id: Ib7446bcd02c76dea03b4cf273aae0dba27c4ef19
BUG: 1231268
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/12128
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b22bcd488eb5e49425faecc6c1de639131c3c6ce
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri Aug 21 06:45:46 2015 -0400
cluster/tier: add gluster v tier <vol>
Currently the tier feature piggy backs off the rebalance command
syntax to obtain status and this is clumsy. Introduce a new
tier command that can do tier specific operations, starting
with volume status to display counters.
Old commands:
gluster volume attach-tier <vol> [replica count] {bricklist..}
gluster volume detach-tier <vol> {start|stop|commit}
New commands:
gluster volume tier <vol> attach [replica count] {bricklist} |
detach {start|stop|commit} |
status
Change-Id: Ic07b3c6260588162de7d34380f8cbd3d8a7f35d3
BUG: 1255693
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/11984
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1cf0a5e93a4444f7a051feee09c69828ff6a414c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jul 2 14:29:17 2015 -0400
build: Mac OS X build issues, ACLs
Mac OS X doesn't support POSIX ACLs.
Change-Id: I875cd2c0403a0665f1f7572b4d28eb5835958e7f
BUG: 1238798
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11518
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 79afe390abac75da9aa6b77832a6dd906f370ed9
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Aug 19 01:23:23 2015 -0400
build: fix build on Mac OS X, gfapi symbol versions
symbol versions for the handle apis are incorrect in glfs-handles.h
Change-Id: I9f239a4e427ea236a6a837a7c7acc980da10ca79
BUG: 1254850
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11954
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit da41567b3e7ceb915eadda28e23c0afb4fcfac09
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Sep 4 19:46:48 2015 +0530
dht: NULL dereferencing causes crash
If linkfile_create is failed for some reason, then
we are trying to dereference a null variable
Change-Id: I3c6ff3715821b9b993d1bab7b90167de2861e190
BUG: 1260147
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/12106
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit e369ad90b8f298323a8660bff91582a269ba51d9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Sep 8 08:22:23 2015 +0530
features/shard: Filter internal shard xattrs in {get,remove,set}xattr
Change-Id: I40e4a5dbd13d6c3d777e7e01f93dabc83e52b137
BUG: 1260637
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12121
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 8f83bb474a18160d87e3195a45dc0eb026eaa34b
Author: Paul Stauffer <paulds@horde.com>
Date: Mon Aug 17 21:00:11 2015 -0700
bash-completion: Swap order of characters in egrep bracket expression
With glusterfs-cli installed, bash tab completion fails to work and prints an
error message:
$ gluster volgrep: Invalid range end
^C
The problem is caused by the ordering of characters within an egrep bracket
expression in the "_gluster_completion()" function defined in
/etc/bash_completion.d/gluster. The file contains this line:
egrep -ao --color=never "([A-Za-z0-9_-.]+)|[[:space:]]+|." | \
And egrep is interpreting the "-" character in that bracket expression as
indicating a range is being requested, "_-." Fortunately, "_" actually comes
after ".", this range expression is invalid, and egrep throws the error instead
of silently not doing what was intended.
The fix is simply to swap the positions of "-" and "." in that bracket
expression:
egrep -ao --color=never "([A-Za-z0-9_.-]+)|[[:space:]]+|." | \
With this change, bash tab completion works as intended.
Change-Id: Iace2d57a1122b4530987ba6f5f5558b56b094665
BUG: 1243108
Signed-off-by: Paul Stauffer <paulds@horde.com>
Reviewed-on: http://review.gluster.org/11939
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 56fd0fae44be5112629e157e5ae8c66560d13148
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu Aug 27 17:23:07 2015 +0530
tier/ctr: Solving DB Lock issue due to write contention from db connections
Problem: The DB on the brick is been accessed by CTR, for write and
tier migrator, for read and write. The write from tier migrator is reseting
the heat counters after a cycle. Since we are using sqlite, two connections
trying to write would cause a db lock contention. As a result CTR used to fail
to update the db.
Solution: Using the same db connection of CTR for reseting the heat counters.
1) Introducted a new IPC FOP for CTR
2) After the query do a ipc syncop to the underlying client xlator associated
to the brick.
3) CTR in brick will catch the IPC FOP and cleat the heat counters.
Change-Id: I53306bfc08dcdba479deb4ccc154896521336150
BUG: 1260730
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/12031
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit ab455000777c0ac9ce021348ec5206e7fe58f983
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Fri Sep 4 22:10:55 2015 +0530
glusterd: Do not allow "detach-tier commit" unnecessarily
Currently when user execute gluster v detach-tier commit command without
starting detach-tier or without giving force option then gluster will
success this operation.
Detach-tier commit should not allow without giving "force" optioin.
Change-Id: Id161c288f6f3e0f6b298878a5c35a49fcbd9c6e3
BUG: 1260185
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/12107
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 335f08561b2b2f8ce38d906916a02d5032186f8d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Sep 3 09:49:56 2015 +0530
afr: Do not wind the full writev payload to arbiter brick
...because the arbiter xlator just unwinds it without passing it down
till posix anyway. Instead, send a one-byte vector so that afr write
transaction works as expected.
Change-Id: I52913ca51dfee0c8472cbadb62c5d39b7badef77
BUG: 1259572
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12095
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
commit 7458548390116654a323edbc71137a66813d9008
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Wed Aug 5 19:30:20 2015 +0530
xml/tiering: enhance xml output for tiering status related cli commands
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volRebalance>
<task-id>34f47e29-2193-4a86-9b1e-c7e56bdae3d4</task-id>
<op>7</op>
<nodeCount>1</nodeCount>
<node>
<nodeName>localhost</nodeName>
<promotedfiles>0</promotedfiles>
<demotedfiles>0</demotedfiles>
<statusStr>in progress</statusStr>
</node>
</volRebalance>
</cliOutput>
Change-Id: I61083f7b9b0b3bd840982b8c5d6ea4b42e27c9b3
BUG: 1252737
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/11890
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit aed8b990b0a42d548632cf64341451ebc9fea0e0
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Sep 7 16:46:48 2015 +0530
uss : handle `buf` variable properly in svs_glfs_readdir()
The svs_glfs_readdir() is a generic function which is called from
svs_readdir() and svs_readdirp(). But in svs_readdir 'buf' variable
is passed as NULL, then glfs_read_readdir() will fail. This patch
will fix the same.
Change-Id: Id02e4e17e30c85de117db5ddd9f97b578622dff9
BUG: 1260611
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/12117
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ad7cf74a26d8bc1661761be857b3a7f98370ef50
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Fri Aug 21 18:18:09 2015 +0530
glusterd: volume status backward compatibility
volume status message of 3.7 does not display all the brick in a mixed
cluster(3.6 and 3.7). it displays the bricks in 3.7 and misses bricks
in 3.6 due to the key difference for ports.
Status of volume: vol1
Gluster process TCP Port RDMA Port Online Pid
------------------------------------------------------------------------------
Brick 10.70.42.171:/data/gluster/tier/cbr2 49153 0 Y 13494
Brick 10.70.42.203:/data/gluster/tier/cbr2 49154 0 Y 27686
NFS Server on localhost N/A N/A N N/A
NFS Server on dhcp42-203.lab.eng.blr.redhat
.com N/A N/A N N/A
Task Status of Volume vol1
------------------------------------------------------------------------------
There are no active volume tasks
Change-Id: Icf0dc01a3d21d0889c43e2868c646a0c7e07ff25
BUG: 1255694
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/11986
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 80d8b97387bc7f141faac298fb90b8b8136bcc84
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Sep 2 12:19:58 2015 +0530
geo-rep: Fix portability issues with NetBSD
Fixes portability issues in gverify.sh and
libcxattr.py with NetBSD.
Change-Id: Idfaa6cf3815136e6a2343aab98d979b6ab451bbd
BUG: 1257847
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12088
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 9181d81f2d5100062c5e84e5a16f1f27fa555eb2
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Thu Aug 27 15:12:35 2015 +0530
man or info page of gluster needs to be updated with self-heal commands
Change-Id: I6f50f88e56d9d9a8f875c7edac28e2a023b65881
BUG: 1122395
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12030
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ff5a8725482d4aae59a1d70df0ec8332f39d754c
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Sep 2 18:40:32 2015 +0530
tests: Reorganise cleanup function
Change-Id: Ifbfb4b05230f023c244760a7d57c33c4463ce6d9
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/12093
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit db9d07392cad59fe5967af23a29366498f20180f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Sep 3 12:05:12 2015 +0530
tests: check free space only on gluster mount
Change-Id: I06de4f555e66fac2594676572c8f8a4ee08f8131
BUG: 1251346
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12096
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f485bc0ca6795dcdc1984f07ed3f2e3c1fc12c5b
Author: vmallika <vmallika@redhat.com>
Date: Tue Sep 1 14:21:43 2015 +0530
test: fix spurious failure from ./tests/basic/quota-nfs.t
Before checking for the quota usage,
umount and mount NFS mountpoint to flush the NFS cached data.
This test is fails on NetBSD, so marking the test as bad-test
Change-Id: I1f30f5d9a919b3959c9f158366bd2f47569c8e03
BUG: 1258766
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12075
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5ede870c20d252002511ccb4a57cfb3360594ed0
Author: Anoop C S <anoopcs@redhat.com>
Date: Sat Aug 15 10:38:00 2015 +0530
protocol-client/server: Fix incorrect grace-timeout value in logs
When grace-timer is initialized via server/client init,
the default or reconfigured value for grace-timeout is
displayed incorrectly in both server and client logs.
This is because we use gf_time_fmt() to format this
grace-timeout value with gf_timefmt_s as the time format
as shown below:
gf_time_fmt (timestr, sizeof timestr, conf->grace_ts.tv_sec,
gf_timefmt_s);
gf_timefmt_s format is a wrapper for %s format specification
used in strftime library call which populates the number
of seconds since the Epoch [1970-01-01 00:00:00 +0000 (UTC)].
But this particular format is dependent on timezone
[1970-01-01 05:30:00 +0530 (IST)]and thus displayed incorrectly
in logs.
Example:
For IST with default grace-timeout value 10, it is displayed
as -19790 which is calculated as follows,
1970-01-01 00:00:10 - 1970-01-01 05:30:00 = -19790 seconds.
Change-Id: I1bdf5d12b2167323f86f0ca52a37ffb316b3f0a2
BUG: 1227667
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/11930
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ecc2dc4f558d245ce969b3ccedf2f48281678dda
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Sep 3 15:47:01 2015 +0530
features/shard: Fix incorrect op_ret in READV
Change-Id: I31ac99b290f82f4b74236c206193f7641c73d4dc
BUG: 1259651
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12099
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 06818fc33c12df7bd383fa64e331cf51a668eafc
Author: Dan Lambright <dlambrig@redhat.com>
Date: Sun Aug 2 15:17:30 2015 +0100
cluster/tier: avoid filling /var/run with tiering files
We failed to delete old promote/demote workfiles in /var/run.
This fix removes the <pid> postfix so there will be only a
single pair of files.
Change-Id: Ib9aafe7b4a9d4b0c05cf03a94cc1057a423a27d2
BUG: 1253970
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/11931
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit 0ff7e3429dadb54e8039ffdb8a5e419eaf7bff40
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Mon Jun 8 12:33:52 2015 +0530
afr: Correction to self-heal-daemon documentation
The reference in the documentation is outdated and need path modification
Change-Id: Ia3712b5064b35b85f83d3b920ecba35dd867f6d3
BUG: 1229127
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/11117
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit af2c0ed3327dbbfcada71ea690861c921de74b22
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Sep 1 15:54:39 2015 +0530
afr: Unset dirty xattr after setting pending xattr during post-op
In AFR transaction, in the pre-op, the dirty xattr is set. In the
post-op, if the transaction fails on one of the bricks, then on the
healthy brick, the dirty xattr is unset and then the pending xattr (for
the brick that went down) is set in that order. If the brick crashes
after unsetting the dirty xattr, we have lost information about a
pending heal. Hence we need to reverse the order, i.e. set pending xattr
first followed by unsetting the dirty.
Change-Id: I0b8a872cb4579a1bad602f70c76f09691bd582b2
BUG: 1258801
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12078
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit cda7e11d023cb7d66e63400e85944fc21469a669
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 1 12:12:21 2015 -0400
packaging: incorrect %ghost of .../hooks/1/delete causes install failure
.../hooks/1/delete is not a %ghost by virtue of having actual files
namely .../post/S57glusterfind-delete-post.py
Change-Id: I544bcfbc898007c79be11e911e6d66e242018740
BUG: 1258975
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12080
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 0916f82849c9a9db889233e48d93b322b2a29ff8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 29 13:50:09 2015 +0530
storage/posix: Prevent malformed internal link creations
Change-Id: Ia3408f795dcfac143fe898fc5f4d31d2c6f236c1
BUG: 1212110
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10999
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 38e025d94bdc3d3cc584f1004aaf7bc5da7f4173
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Sep 1 21:53:10 2015 +0530
tests: remove arbiter-statfs.t from bad tests
This test case failed due to the G_LOG clobbering NetBSD files which
have been fixed by http://review.gluster.org/11993. Hence removing it
from is_bad_test()
Change-Id: I719fa623f397b1d0799c9fe0c00ad7979143e1b2
BUG: 1256588
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/12057
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 4c493350f94663db0d95391a5cecdf86cf98d4e7
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Sun Aug 2 08:25:45 2015 -0400
build: Fix build on Mac OS X, boolean
bool and true conflict with clang macros in clang on Mac OS X,
possibly with newer (?) versions of clang on Linux
Change-Id: Ia8c56ae68b4ebffb99b0684ac72d68ec50eaa7fa
BUG: 1249391
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11816
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 147c734600bf2ed315b83d23d01de196229401a8
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Mon Aug 10 18:42:05 2015 +0530
geo-rep: Update geo-rep status, if monitor process is killed
Problem:
When the monitor process itself is getting killed, geo-rep session
still shows as active.
Status command will just pick up the content from the status file
to show the output. Monitor process is the one which updates the Status file.
When the monitor process itself gets killed, there is no way to update
the status file. So, geo-rep session status command ends up showing
last updated Status present in the status file.
Solution:
While getting the status output, check whether monitor process is running.
If it is NOT running, update the status as STOPPED.
Change-Id: I86a7ac1746dd8f27eef93658e992ef16f6068d9d
BUG: 1251980
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/11873
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c85b5a6e5910d62dd9f4895ed0730b704b4af4e0
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Aug 31 15:07:49 2015 +0530
Update to MAINTAINERS
Added new maintainers as per discussion in:
http://www.gluster.org/pipermail/gluster-devel/2015-June/045471.html
Removed maintainers who have not been active in a while.
Change-Id: Ia84bb0e7c65834567ac01112665e7848525488bd
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/11330
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b156639fd4495e7c7ba996eb63351b1d66ccb9d0
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Sep 1 11:24:09 2015 +0530
tests: Remove geo-rep tests from bad tests
Remove 'tests/geo-rep/georep-basic-dr-rsync.t' and
'tests/geo-rep/georep-basic-dr-tarssh.t' from bad
tests as it passes on linux machines. It is disabled
only in NetBSD untill portability issues are fixed.
(https://bugzilla.redhat.com/show_bug.cgi?id=1257847)
Also add increase sleep timining to let the data
sync.
Change-Id: Ifc831353a345bcf5605fc4dfba693df891bb6d5b
BUG: 1227624
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/12072
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 6f502764ba9c88a52d2fdad3fc269c7a5b819ea1
Author: Mohamed Ashiq <mliyazud@redhat.com>
Date: Wed Jul 29 23:47:34 2015 +0530
logging : GF_LOG_NONE logs always
Shouldn't GF_LOG_NONE mean "Never log this"? If so, it's not being
tested for and is, instead, treated as a higher priority than
CRITICAL thus is always logged.
Change-Id: Icad1e02a720a05ff21bd54ebf19c0032e6d5ce03
BUG: 1246794
Signed-off-by: Mohamed Ashiq <mliyazud@redhat.com>
Reviewed-on: http://review.gluster.org/11797
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit dfadc2c43c941c8d0e5b4a290cf30b67df7f66c1
Author: Richard Wareing <rwareing@fb.com>
Date: Thu Aug 27 21:06:37 2015 -0700
nfs: Fixes "Remote I/O error" mount failures
- Fixes issue where NFS mount fail with "Remove I/O error" after the
target directory has been deleted and re-created after the gNFSd has
already cached the inode of the first generation of the target
directory.
- The solution is to follow the guidance of the AFR2 comments and
refresh the inode by deleting it from cache and looking it up
again.
BUG: 1258196
Change-Id: I9c7d8bd460ee9e5ea0b5b47d23886b1afcdcd563
Reported-by: Richard Wareing <rwareing@fb.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/12046
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 573cf65cf077424e7b230db36a9078d1e6c1421d
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jul 28 12:11:12 2015 -0400
all: reduce "inline" usage
There are three kinds of inline functions: plain inline, extern inline,
and static inline. All three have been removed from .c files, except
those in "contrib" which aren't our problem. Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone. Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort. This part was easy to do automatically without (as far as I can
tell) any ill effect.
In the process, several pieces of dead code were flagged by the
compiler, and were removed.
Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155
BUG: 1245331
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/11769
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 24d9dc3f8fb9df597e9bcf2ac64e6164ef9c1a60
Author: Mohamed Ashiq <mliyazud@redhat.com>
Date: Wed Aug 12 15:21:17 2015 +0530
libglusterfs:Porting log messages to new framework
Change-Id: I8625b7dc8941720cc7a864b8fddbcc7b4c485fcd
BUG: 1252836
Signed-off-by: Mohamed Ashiq <mliyazud@redhat.com>
Reviewed-on: http://review.gluster.org/11896
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit a820fc697d260e59abe23ff3aff12abcb96a562e
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Sep 1 10:53:19 2015 +0530
tests: add bug-948686.t to bad_tests
bug-948686.t intermittely ends up in a race in GlusterD where one thread deletes
a stale volume and on a volume start request a start is attempted on the same
object which might be freed up by the other thread. We are considering to use
refcounting mechanism while accessing volinfo objects to get rid of this problem
but that needs a significant amount of time in development. Till then adding
this test in bad_tests ()
Change-Id: I3ddc025b07c47b17ea75554d5cc809a839365f10
BUG: 1258714
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/12070
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 445cebf86fedb63d091d050f797d5874914d67d0
Author: Brad Hubbard <bhubbard@redhat.com>
Date: Wed Aug 19 18:56:06 2015 +1000
glusterd: Return better error messages for probe and detach failures
We handle some specific errors and return good error messages for those, but for
the default case where the error code is not recognised we just report "unknown
errno". This patch attempts to at least return the output of strerror to provide
more informative errors.
BUG: 1257149
Change-Id: I0027e74e41adac4ab0c0a929c6fff56878bf39c8
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-on: http://review.gluster.org/12021
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 63a026ca80b9b9ec8f221a936b3aae84db9b458c
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Fri Jul 10 11:27:26 2015 +0530
posix.c posix-helpers.c: porting new log messages
Change-Id: I0c306d796ff49263d8a6c191b24a41da8a21bd2c
BUG: 1252695
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/11609
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 07f7910080f68b30a1c9dd00ea5c5a0139e609bb
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Thu Aug 13 12:53:33 2015 +0530
performance translators : porting the missing gf_log to gf_msg
Change-Id: I5cc2b4669b164fe09637c86da05d2d94589dd7e4
BUG: 1253149
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/11906
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 3b1b60e6fcd0500c828d5960356c4296553b6e6e
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Aug 24 18:01:19 2015 +0530
tests : workaround for the spurious failure in mount-nfs-auth.t
Change-Id: I459a0c60743291a2e164a5e0a76a7e2577afdae0
BUG: 1256352
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/12006
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ce23805b23158b9cd775336f27ac0d5b401e817f
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Aug 13 13:11:32 2015 +0530
tests: Fix return value in geo-rep tests
Remove the function 'data_tests' and TEST
each fop in testcase itself to determine
the exact test that fails.
Change-Id: Iffc3e2ac3b0fc0c7c64259fcdff8f27b146dcb9b
BUG: 1227624
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11907
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b4a311e11b3ce5ff90de6b4ba6bf3681c425b486
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Aug 31 12:43:36 2015 +0530
features/shard: Fix unlink failure due to non-existent shard(s)
Unlink of a sharded file with holes was leading to EINVAL errors
because it was being wound on non-existent shards (those blocks that
fall in the hole region). loc->inode was NULL in these cases and
dht_unlink used to fail the FOP with EINVAL for failure to fetch
cached subvol for the inode.
The fix involves winding unlink on only those shards whose corresponding
inodes exist in memory.
Change-Id: I993ff70cab4b22580c772a9c74fc19ac893a03fc
BUG: 1258334
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12059
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7d524f1dc62d61204b545b35e09bde22fa25e220
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Aug 31 09:56:02 2015 +0530
debug/trace: Print total write size in trace_writev
This is some information I find useful while debugging issues
in shard translator.
Change-Id: Ic35c34c2f52d27b3617fc722dabe558de2056b67
BUG: 1258311
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12053
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b285298d2a5181fd04c2da440c10c26748f7fc92
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Aug 12 14:46:29 2015 +0530
libgfapi : port missing gf_log's to gf_msg
Change-Id: I0c5320c09b4a5ff1e9df61a86ac7bd47c1bb1bbb
BUG: 1252807
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/11891
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit b62b3afe1e891e743b17e5e545f9e5880fe9b76d
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Thu Aug 27 13:10:18 2015 +0530
cluster/dht: Don't set posix acls on linkto files
Posix acls on a linkto file change the file's permission
bits and cause DHT to treat it as a non-linkto file.This
happens on the migration failure of a file on which posix
acls were set.
The fix prevents posix acls from being set on a linkto
file and copies them across only after a file has
been successfully migrated.
Change-Id: Iccf7ff6fba49fe05d691d9b83bf76a240848b212
BUG: 1247563
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12025
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit f9fc149879855b98338f6ae2b33d5286eb807199
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Aug 19 16:54:42 2015 +0530
features/shard: Fix permission issues
This patch does the following:
* reverts commit b467af0e99b39ef708420d3f7f6696b0ca618512
* changes ownership on shards under /.shard to be root:root
* makes readv, writev, [f]truncate, rename, and unlink fops
to perform operations on files under /.shard with
frame->root->{uid,gid} as 0.
This would ensure that a [f]setattr on a sharded file
does not need to be called on all the shards associated with it.
Change-Id: Idcfb8c0dd354b0baab6b2356d2ab83ce51caa20e
BUG: 1251824
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11992
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 29d0099a24f9675e61e5c974f26cc00dfc062950
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Jul 26 11:19:28 2015 +0530
cluster/afr: Make [f]xattrop metadata transaction
Problem:
When xlators above afr do [f]xattrop when one of the bricks is down, after the
brick comes backup, the metadata is not healed because [f]xattrop is not
considered a transaction.
Fix:
Treat [f]xattrop as transaction so that changes done by xlators above afr are
marked for heal when some of the bricks were down at the time of [f]xattrop.
Change-Id: Iea180f9a456509847c3cd8d5d59a0cdc2712d334
BUG: 1248887
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11809
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit eb8a43d020984dc0173e0a2ac0a3446970ffde41
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Aug 26 09:27:42 2015 +0530
features/shard: Fix size update for writes at hole region
Change-Id: Iceccef8f3f466c7ffb9991f8eb248b81e7b80efb
BUG: 1256580
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/12020
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit bf0d5c4387178c43fa84262e08847e770cb1e628
Author: vmallika <vmallika@redhat.com>
Date: Thu Aug 27 21:11:53 2015 +0530
marker: preserve previous dirty flag during update txn
In case if dir has become dirty because of brick crash,
this dirty flag on disk was getting reset in the
next update txn.
This patch now gets the dirty flag before setting the flag
in the update txn and if this value is dirty, it keeps
the flag dirty, so that inspect_directory can fix the
dirty dir
Change-Id: Iab2c343dbe19bd3b291adbfeebe6d9785b6bb9e3
BUG: 1251454
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/12032
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8c56276e21114f2c1ea0e61b05571709297754bc
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sat Aug 29 19:07:55 2015 +0530
event: remove vestigial mutex_unlock from event_dispatch
This was missed erroneously by self in http://review.gluster.org/12004
BUG: 1242421
Change-Id: Id6cb156fd584704486e49bc4c4a7bdd44a98679f
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/12044
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit bf398e5e09dd2f8afefbefc732d4952b8fe0a4c1
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Jul 22 17:08:02 2015 +0200
cluster/ec: Allow read fops to be processed in parallel
Currently ec only sends a single read request at a time for a given
inode. Since reads do not interfere between them, this patch allows
multiple concurrent read requests to be sent in parallel.
Change-Id: If853430482a71767823f39ea70ff89797019d46b
BUG: 1245689
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/11742
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 583aeced93928fe800924394cb6d4752cf3fa906
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Jul 15 16:37:37 2015 +0530
ec : trusted.ec.version xattr of all root directories of all bricks should be same.
Problem:
After replacing the brick using "replace-brick" command and running "heal
full", the version of the root directory of the newly added brick is not
getting healed. heal starts running on the dentries of the root but does not
run on root directory.
Solution:
Run heal on root directory.
Change-Id: Ifd42a3fb341b049c895817e892e5b484a5aa6f80
BUG: 1243382
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/11676
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 3b738ae9b3ab61f65d65697872ac54c5e7671dae
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Wed Aug 26 08:28:59 2015 +0530
gluster/cli: snapshot delete all does not work with xml
Problem: snapshot delete all command fails with --xml option
Fix: Provided xml support for delete all command
Change-Id: I77cad131473a9160e188c783f442b6a38a37f758
BUG: 1257533
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/12027
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
commit 0f07cd6347778f0cfa9571a68a058cc7da12d092
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Tue Aug 11 18:17:31 2015 +0530
glusterd: probing a new node, which is part of another cluster should give error
If user try to add node to extant cluster using "gluster peer probe \
<ip/hostname>" command then command is failing but its not giving
proper cause of failure.
This fix will take control of proper error message during peer probe
with already extant cluster.
Change-Id: I4f993e78c0e1b3e061153b984ec5e9b70085aef5
BUG: 1252448
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/11884
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 91e7f72e876249257a74046ee87a195a8340dee6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jun 2 16:39:35 2015 +0530
fd: Do fd_bind on successful open
- fd_unref should decrement fd->inode->fd_count only if it is present in the
inode's fd list.
- successful open/opendir should perform fd_bind.
Change-Id: I81dd04f330e2fee86369a6dc7147af44f3d49169
BUG: 1207735
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11044
Reviewed-by: Anoop C S <anoopcs@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit c2b97bbadfa83c6bd812c93aa2468985554b8a43
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Aug 28 14:27:20 2015 +0530
event-epoll: Use pollers[] to check if event_pool_dispatch was called
BUG: 1242421
Change-Id: I1a0044653f15d33f89ffe16edc5baba40393dec3
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/12004
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 2b7ab2c46c562021611613ee994c5538bf4d2ada
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Aug 26 15:24:39 2015 +0530
mount/fuse: Log ENODATA as DEBUG in {f}removexattr
Logging ENODATA errors for {f}removexattr at a higher loglevel does not
add a lot of value and causes a log message flood as per multiple reports.
Added a new cbk, fuse_removexattr_cbk() to be used with removexattr fops.
ENODATA now gets logged at loglevel DEBUG in fuse_removexattr_cbk(). This also
prevents more conditional checks in the common fuse_err_cbk() callback.
Change-Id: I1585b4d627e0095022016c47d7fd212018a7194b
BUG: 1257110
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/12015
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 8ea6b4e8a8370ecbfd5ace5e14fa97c910fc02ae
Author: vmallika <vmallika@redhat.com>
Date: Mon Aug 24 08:07:14 2015 +0530
cli: on error invoke cli_cmd_broadcast_response function in separate thread
There is a problem in current CLI framework
CLI holds the lock when processing command.
When processing quota list command, below sequence of steps executed in the
same thread and causing deadlock
1) CLI holds the lock
2) Send rpc_clnt_submit request to quotad for quota usage
3) If quotad is down, rpc_clnt_submit invokes cbk function with error
4) cbk function cli_quotad_getlimit_cbk tries to hold lock to broadcast
the results and hangs, because same thread has already holding the lock
This patch fixes the problem by creating seperate thread for
broadcasting the result
Change-Id: I53be006eadf6aaf348083d9168535530d70a8ab3
BUG: 1242819
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11990
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit ee222028e4f425427a6d9cff17ce2bd2417e8fa2
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Fri Aug 28 10:46:11 2015 +0530
tests: Mark bug-1238706-daemons-stop-on-peer-cleanup.t as bad
This test fails frequently. Use bug number 1257792 when you
move this test out of bad_tests.
Change-Id: Ib65f22096dc9af131c4d2f38b59a857c549a674a
BUG: 1257792
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/12036
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
commit 26364ea39fcb97ba5d3ea15289d2cadff064d375
Author: vmallika <vmallika@redhat.com>
Date: Mon Aug 24 13:14:59 2015 +0530
posix: xattrop 'GF_XATTROP_GET_AND_SET' implementation
GF_XATTROP_GET_AND_SET stores the existing xattr
value in xdata and sets the new value
xattrop was reusing input xattr dict to set the results
instead of creating new dict.
This can be problem for server side xlators as the inout dict
will have the value changed.
Change-Id: I43369082e1d0090d211381181e9f3b9075b8e771
BUG: 1251454
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11995
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 7145a8b3e8aa7bdb2a95cee62281f07f028733d0
Author: vmallika <vmallika@redhat.com>
Date: Thu Aug 20 12:01:57 2015 +0530
marker: fix log when loc.parent and inode gfid is NULL
This patch does the following
1) Set loc.parent if it is NULL
Don't log warning in txn if parent is NULL
2) Don't initiate txn when inode gfid is NULL
3) optimize invoking dirty txn with status flag
Change-Id: I67dd9e6268014b0b257c136e951e6ded0a2e911f
BUG: 1251454
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11863
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ebf9efd9a190c0381691cdb555f91c882e3a60a3
Author: Sakshi <sabansal@redhat.com>
Date: Thu Jul 16 14:31:03 2015 +0530
dht : lock on subvols to prevent lookup vs rmdir race
There is a possibility that while an rmdir is completed on
some non-hashed subvol and proceeding to others. A lookup
selfheal can recreate the same directory on those subvols
for which the rmdir had succeeded. The fix is to take a
blocking inodelk on the subvols before starting rmdir.
Since selfheal requires lock on all subvols, if an rmdir
is in progess acquiring locks will fail and vice versa.
Change-Id: I841a44758c3b88f5e04d1cb73ad36e0cac9fdabb
BUG: 1245065
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/11725
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 753cf73da80c47ba2d7fd14a8921ef05fb9fcebe
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jul 16 18:23:36 2015 +0530
tools/glusterfind: Do not show session corrupted if no status file
When a glusterfind session is created it creates session directories
in all the nodes which are part of the Volume. But session status
file only present in initiated node.
Show Session corrupted only if status file exists and invalid content.
Change-Id: I8443c0335b872645b54c0aa77d9893dbe2589c92
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1243838
Reviewed-on: http://review.gluster.org/11699
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit bccea0a216033f8fb2f738955c6300c1f474d741
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Fri Jul 17 15:51:22 2015 +0530
tools/glusterfind: Prepend prefix in case of delete
In case of delete operation alone, output prefix adding
was not handled earlier.
Output prefix is added now.
Change-Id: Ia91444dddbff501b26a864f6185ca4c0aaf4c802
BUG: 1244144
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/11712
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
commit c0f39b7525d357980788249f0f924a9fb93b62b5
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Aug 12 15:29:31 2015 +0530
protocol/server : porting missing gf_log's to gf_msg
Change-Id: I8818931fafea3c013551a5de23a9f77c81164841
BUG: 1252808
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/11895
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 88073708a3b60ba12592b0d2585337d79fae9149
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Mar 17 19:57:47 2015 +0530
snapshot:cleanup snaps during unprobe
When doing an unprobe, the volume that doesnot
contain any brick of the particular node will be
deleted. So the snaps associated with that volume
should also delete
Change-Id: I9f3d23bd11b254ebf7d7722cc1e12455d6b024ff
BUG: 1203185
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9930
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 2a2766b9e2b251c08850c04cfac5efb2b30534e6
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jul 21 09:57:43 2015 +0530
glusterd: Don't allow remove brick start/commit if glusterd is down of the host of the brick
remove brick stage blindly starts the remove brick operation even if the
glusterd instance of the node hosting the brick is down. Operationally its
incorrect and this could result into a inconsistent rebalance status across all
the nodes as the originator of this command will always have the rebalance
status to 'DEFRAG_NOT_STARTED', however when the glusterd instance on the other
nodes comes up, will trigger rebalance and make the status to completed once the
rebalance is finished.
This patch fixes two things:
1. Add a validation in remove brick to check whether all the peers hosting the
bricks to be removed are up.
2. Don't copy volinfo->rebal.dict from stale volinfo during restore as this
might end up in a incosistent node_state.info file resulting into volume status
command failure.
Change-Id: Ia4a76865c05037d49eec5e3bbfaf68c1567f1f81
BUG: 1245045
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11726
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit d7246b3d375d79a65dc2b00391ddc39545e0cb47
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Aug 24 12:04:54 2015 +0530
tests: Fix corruption of files on NetBSD
This is one more attempt to eliminate corruption
of files by our tests scripts on NetBSD.
Changes done:
1. Have every local variable with a unique name.
2. Change date format to match with gluster's.
3. Pass the parameters to G_LOG without interpretation,
hence the change from $* to $@.
Change-Id: I833a93555da93179a1b39a9e4e7086216c335c3d
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/11993
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
commit 1238cfc69bd47393e0ea2bbbd157db54ac658518
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed May 13 14:48:42 2015 +0530
glusterd : Display status of Self Heal Daemon for disperse volume
Problem : Status of Self Heal Daemon is not
displayed in "gluster volume status"
As disperse volumes are self heal compatible,
show the status of self heal daemon in gluster
volume status command
Change-Id: I83d3e6a2fd122b171f15cfd76ce8e6b6e00f92e2
BUG: 1217311
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/10764
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 7e5852bda0dd6d6106c9d396f6f678291ce77ef9
Author: Anuradha Talur <atalur@redhat.com>
Date: Mon Aug 3 17:09:13 2015 +0530
cluster/afr : Examine data/metadata readable for read-subvol During lookup and discover, currently read_subvol is based only on data_readable. read_subvol should be decided based on both data_readable and metadata_readable.
Credits to Ravishankar N for the logic of afr_first_up_child
from http://review.gluster.org/10905/ .
Change-Id: I98580b23c278172ee2902be08eeaafb6722e830c
BUG: 1240244
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/11551
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 41f7865faf4d79f318397587e9a8773aac4bec78
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Aug 4 18:37:47 2015 +0530
afr: modify afr_txn_nothing_failed()
In an AFR transaction, we need to consider something as failed only if the
failure (either in the pre-op or the FOP phase) occurs on the bricks on which a
transaction lock was obtained.
Without this, we would end up considering the transaction as failure even on the
bricks on which the lock was not obtained, resulting in unnecessary fsyncs
during the post-op phase of every write transaction for non-appending writes.
Change-Id: Iee79e5d85dc7b4c41459d8bdd04a8454bdaf9a9d
BUG: 1250170
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/11827
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit df404bc01f70ed86519ae451b7b70de683a8d641
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Aug 24 16:20:06 2015 +0530
tests: add arbiter-statfs.t/tier.t to bad tests
Recent regression links for proof:
http://build.gluster.org/job/rackspace-netbsd7-regression-triggered/9611/consoleFull
https://build.gluster.org/job/rackspace-netbsd7-regression-triggered/9616/consoleFull
https://build.gluster.org/job/rackspace-regression-2GB-triggered/13613/consoleFull
Filed https://bugzilla.redhat.com/show_bug.cgi?id=1256588 for tracking
arbiter-statfs.t spurious failure and
https://bugzilla.redhat.com/show_bug.cgi?id=1231268 is going to track tier.t's
issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1231268
Change-Id: I61dc8f3d3366b2c784e3ce82bd88900f2651cbef
BUG: 1254127
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/12005
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 7c27d0d3888c2506b0d08916ffe173f2e8625d51
Author: Susant Palai <spalai@redhat.com>
Date: Mon Aug 24 03:04:41 2015 -0400
cluster/dht: avoid mknod on decommissioned brick
Change-Id: I8c39ce38e257758e27e11ccaaff4798138203e0c
BUG: 1256243
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/11998
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 57ddea793a09dd565867c713aa8855e333ad8817
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Aug 17 10:29:19 2015 +0000
heal: Add check for healing directories in split-brain
1. Healing using `bigger-file' option does not make much sense for directories,
hence disallow it and notify the user.
2. Healing using 'source-brick' option for directories performs a conservative
merge. Notify the user about it.
Change-Id: I0acff7b438bdb256615ed0f40d45694f37a77dd5
BUG: 1254167
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/11937
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 35b9cb442233b8ed3faaf21a8eb6021bc5136140
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Thu Jul 2 18:23:51 2015 +0530
glusterd: stop all the daemons services on peer detach
Currently glusterd is not stopping all the deamon service on peer detach
With this fix it will do peer detach cleanup properlly and will stop all
the daemon which was running before peer detach on the node.
Change-Id: Ifed403ed09187e84f2a60bf63135156ad1f15775
BUG: 1255386
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/11509
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 74fd29d39912d2d4df0aa0369bc5ce6ffcf9ed4f
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jul 30 16:37:45 2015 +0530
snapshot: Make fops static for correct resolution of symbols
Few of the snapshot fops (like 'svc_lookup') may not get resolved
while using dynamic loading as there could be other libraries(like libntirpc)
with same routine names. Making them static to resolve the same.
Change-Id: I6577bf3705864f5583425c94427b4e1025a59bcd
BUG: 1248669
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11805
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b83dbc9bbfc98cb64306d484391e06d46e559d93
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Aug 11 16:00:47 2015 +0530
libgfapi: adding 'follow' flag to glfs_h_lookupat()
Previously glfs_h_lookupat won't follow the symlink, this patch
introduces new flag `follow` which will resolve the same. Applications
linking against the new library will need to use the new glfs_h_lookupat
API call.
In order to stay compatible with existing binaries that use the previous
glfs_h_lookupat() function, the old symbol needs to stay available.
Verification that there are two versions of glfs_h_lookupat:
$ objdump -T /usr/lib64/libgfapi.so.0 | grep -w glfs_h_lookupat
0000000000015070 g DF .text 000000000000021e GFAPI_3.7.4 glfs_h_lookupat
0000000000015290 g DF .text 0000000000000008 (GFAPI_3.4.2) glfs_h_lookupat
Testing with a binary (based on anonymous_fd_read_write.c from ./tests/)
that was linked against the old library:
$ objdump -T ./lookupat | grep -w glfs_h_lookupat
0000000000000000 DF *UND* 0000000000000000 GFAPI_3.4.2 glfs_h_lookupat
Enable debugging for 'ld.so' so that we can check that the GFAPI_3.4.2
version of the symbol gets loaded:
$ export LD_DEBUG_OUTPUT=lookupat.ld.log LD_DEBUG=all
$ ./lookupat
$ grep -w glfs_h_lookupat lookupat.ld.log.2543
2543: symbol=glfs_h_lookupat; lookup in file=./lookupat [0]
2543: symbol=glfs_h_lookupat; lookup in file=/lib64/libgfapi.so.0 [0]
2543: binding file ./lookupat [0] to /lib64/libgfapi.so.0 [0]: normal symbol `glfs_h_lookupat' [GFAPI_3.4.2]
Change-Id: I8bf9b1c19a0585f681bc1a7f84aad1ccd0f75f6a
BUG: 1252410
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11883
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit a4610e1e44145680fdaa93fc39f2d07207ffe8d4
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Aug 5 15:56:53 2015 +0530
snapshot: Fix snapshot info's xml output
Display description field with (null) if
no description is present for the snapshot, instead
of removing the field altogether.
Change-Id: I965b08cd6e54eea56c32e2712fab7daa8a663f11
BUG: 1250387
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11834
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 0fdd5c0596655d2f0d610cdcfe5b83061eab6859
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Aug 5 13:49:41 2015 +0530
snapshot/scheduler: Check if volume exists before adding/editing schedules
Before adding or editing a scheduler, check if the volume name provided
in the schedule, exists in the cluster or not.
Added return code VOLUME_DOES_NOT_EXIST(17) for the same.
Change-Id: Ia3fe3cc1e1568ddd10f9193bbf40a098f0fe990a
BUG: 1213349
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11830
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 93f36e89bf46ea95402dac4a6a9e77317601f06c
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Aug 20 14:40:29 2015 +0530
snapshot: Log deletion of snapshot, during auto-delete
When auto-delete is enabled, and soft-limit is reached,
on creation of a snapshot, the oldest snapshot for that
volume is deleted.
Displaying a warning log before deleting the oldest
snapshot.
Change-Id: I75f0366935966a223b63a4ec5ac13f9fe36c0e82
BUG: 1255310
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11963
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 71fec68b4f504018301af2de828aae23f2cd7d8c
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Aug 14 18:28:08 2015 +0530
snapshot/scheduler: Output correction of initialisation
Change-Id: I4a6e00805da7b254b8b08e7bb142960fb6c64923
BUG: 1218164
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11924
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 961de964af01de9cd84d6421225cbce3e461e104
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Aug 5 17:19:29 2015 +0200
SSL improvements: do not fail if certificate purpose is set
Since glusterfs shares the same settings for client-side
and server-side of SSL, we need to ignore any certificate
usage specification (SSL client vs SSL server), otherwise
SSL connexions will fail with 'unsupported cerritifcate"
BUG: 1247152
Change-Id: I7ef60271718d2d894176515aa530ff106127bceb
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/11840
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ac92eadd221d2dc27214a60865982fea45192420
Author: Susant Palai <spalai@redhat.com>
Date: Tue Jun 16 20:35:46 2015 +0530
dht: block/handle create op falling to decommissioned brick
Problem:
Post remove-brick start till commit phase, the client layout
may not be in sync with disk layout because of lack of lookup.
Hence,a create call may fall on the decommissioned brick.
Solution:
Will acquire a lock on hashed subvol. So that a fix-layout or
selfheal can not step on layout while reading the layout.
Even if we read a layout before remove-brick fix-layout and the
file falls on the decommissioned brick, the file should be
migrated to a new brick as per the fix-layout.
Change-Id: If84a12ec34f981adb2b9b224e80f535cfe5bf9f2
BUG: 1232378
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/11260
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 952640e231bf41742101929551b22696f4983c18
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Aug 12 15:25:03 2015 +0530
features/bitrot: Fix scrubber frequency set
When bitrot is configured on multiple volumes
in a cluster and scrubber-frequency is changed
for one volume, it is resetting frequency for
all other volumes w.r.t to its scrubber-frequency.
This should not happen. Changing scrubber-frequency
should affect only that volume on which it is set.
This patch fixes the issue.
Also restricted the logs to the configure volume.
Change-Id: I90d6e864b131e3d8dd4010079a00f924032f2098
BUG: 1252825
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11897
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit aec6bb44fda47e750d6b6cf07485c8633b74b0f7
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Aug 13 14:39:58 2015 +0530
event: add dispatched flag to know if event_dispatch was called
This is important for glusterfs processes that choose to reconfigure
no. of event-threads (a.k.a epoll worker-threads) before they call
event_dispatch on the event_pool. glusterd needs this today.
Change-Id: Ia8df3c958545324472262c555ed84b71797f002e
BUG: 1242421
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/11911
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7c220f9446741feea2122c7d007272b7ad1dce6e
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Aug 13 18:33:08 2015 +0530
afr: launch index heal on local subvols up on a child-up event
Problem:
When a replica's child goes down and comes up, the index heal is
triggered only on the child that just came up. This does not serve the
intended purpose as the list of files that need to be healed
to this child is actually captured on the other child of the replica.
Fix:
Launch index-heal on all local children of the replica xlator which just
received a child up. Note that afr_selfheal_childup() eventually calls
afr_shd_index_healer() which will not run the heal on non-local
children.
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: Ia23e47d197f983c695ec0bcd283e74931119ee55
BUG: 1253309
Reviewed-on: http://review.gluster.org/11912
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit cb914b54a1571c6c93f51adec37cdcf985aa3a65
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Aug 21 10:54:39 2015 +0530
tests: remove unwanted tests from volume-snapshot.t
volume-snapshot.t failspuriously because of having additional test cases
which restarts glusterd and they are really not needed as far as the test
coverage is concerned. Currently glusterd doesn't have a mechanism to indicate
that volumes handshaking has been completed or not, due to this even if the peer
handshaking finishes and all the peers are back to the cluster there could be a
case where any command which accesses the volume structure might end up in
corruption as volume handshaking is still in progress. This is because of volume
list is still not been made URCU protected.
Change-Id: Id8669c22584384f988be5e0a5a0deca7708a277d
BUG: 1255599
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11972
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d7ef23592e9cc3442042b505a9b0a1bc6f33ba8c
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Thu Jul 30 18:29:41 2015 +0530
quota :display the size of soft limit percentage
Display the size equivalent to the soft limit percentage
in gluster v quota <volname> list <path> and
gluster v quota <volname> list-objects <path> command
Change-Id: I31ee82e9e836068348cf9458dcaf13f043d9fd87
BUG: 1248521
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/11808
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 3d2ce5e16bc12319371565bdd3f88e6a6f9ee215
Author: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
Date: Thu Aug 20 16:12:53 2015 +0530
bitrot: Scrubber log should mark bad file as a ALERT in the scrubber log
If bad file detected by scrubber then scrubber should log that bad
file as a ALERT message in scrubber log.
Change-Id: I410429e78fd3768655230ac028fa66f7fc24b938
BUG: 1240218
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/11965
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit eaa974316944f78f8055bb52d6545d0f3721f514
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Jul 1 15:56:58 2015 +0530
protocol/server: forget the inodes which got ENOENT in lookup
If a looked up object is removed from the backend, then upon getting a
revalidated lookup on that object ENOENT error is received. protocol/server
xlator handles it by removing dentry upon which ENOENT is received. But the
inode associated with it still remains in the inode table, and whoever does
nameless lookup on the gfid of that object will be able to do it successfully
despite the object being not present.
For handling this issue, upon getting ENOENT on a looked up entry in revalidate
lookups, protocol/server should forget the inode as well.
Though removing files directly from the backend is not allowed, in case of
objects corrupted due to bitrot and marked as bad by scrubber, objects are
removed directly from the backend in case of replicate volumes, so that the
object is healed from the good copy. For handling this, the inode of the bad
object removed from the backend should be forgotten. Otherwise, the inode which
knows the object it represents is bad, does not allow read/write operations
happening as part of self-heal.
Change-Id: I23b7a5bef919c98eea684aa1e977e317066cfc71
BUG: 1238188
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11489
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ca7ef7807d10cef819909391f0dd9b971a39270a
Author: vmallika <vmallika@redhat.com>
Date: Sun Jul 12 08:49:49 2015 +0530
quota/marker: fix inode quota with rename
There are three problems with marker-rename which
is fixed in this patch
Problem 1)
1) mq_reduce_parent_size is not handling inode-quota contribution
2) When dest files exists and IO is happening
Now renaming will overwrite existing file
mq_reduce_parent_size called on dest file
with saved contribution, this can be
a problem is IO is still happening
contribution might have changed
Problem 2)
There is a small race between rename and in-progress write
Consider below scenario
1) rename FOP invoked on file 'x'
2) write is still in progress for file 'x'
3) rename takes a lock on old-parent
4) write-update txn blocked on old-parent to acquire lock
5) in rename_cbk, contri xattrs are removed and contribution is deleted and
lock is released
6) now write-update txn gets the lock and updates the wrong parent
as it was holding lock on old parent
so validate parent once the lock is acquired
Problem 3)
when a rename operation is performed, a lock is
held on old parent. This lock is release before
unwinding the rename operation.
This can be a problem if there are in-progress
writes happening during rename, where update txn
can take a lock and update the old parent
as inode table is not updated with new parent
Change-Id: Ic3316097c001c33533f98592e8fcf234b1ee2aa2
BUG: 1240991
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11578
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 192f1cb7c66195728751b4e19a43f17c482d0cc8
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Aug 13 11:49:57 2015 +0530
protocol-client/server: Minor logging improvements for better debugging
Adding some log messages to protocol client and server to
ease the debugging process.
Change-Id: I84a05fcde7189d6e6ad5c37c1bbffb148d123517
BUG: 1227667
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/11903
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 83ee5addcd26e804c1522807bc1108bda5382910
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Aug 19 02:43:00 2015 -0400
libgfapi: non-default symbol version macros are incorrect
default symbol versions are in form glfs_h_lookupat@@GFAPI_2.7.4,
versus old, non-default versions are in the form glfs_h_lookup@GFAPI_2.4.2
I.e. "@@" versus "@"
Change-Id: I88a6b129558c0b3a6064de7620b3b20425e80bc9
BUG: 1254863
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11955
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 02f98cb6296ccd3fba49e4eb67f50095311509f5
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jun 18 00:21:59 2015 +0200
rpm: include required directory for glusterfind
The directory was marked as %ghost, which causes the following
installation failure:
Error unpacking rpm package glusterfs-server-3.8dev-0.446.git45e13fe.el7.centos.x86_64
error: unpacking of archive failed on file /var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py;5581f20e: cpio: open
Also, *all* Python files should be part of the RPM package. This
includes generated .pyc and .pyo files.
BUG: 1225465
Change-Id: Iee74905b101912c4a845257742c470c3fe42ce2a
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/11298
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit cb5cd9c50189268b939eba167c706f3eceea9da1
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Aug 10 19:10:21 2015 +0530
features/shard: Ensure shards are owned by the same owner/group as the original file
Change-Id: Id759af8f3ff5fd8bfa9f8121bab25722709d42b7
BUG: 1251824
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11874
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 0cab198a33e32b31997a353db58ed361e2026234
Author: N Balachandran <nbalacha@redhat.com>
Date: Tue Aug 18 13:37:12 2015 +0530
cluster/tier : Use dht_* versions for xlator_fops
The tier xlator was using the default_* versions
for some xlator_fops. Changed to use the dht_*
versions for all xlator_fops
Change-Id: I8252fb3911b8a48a55e9eee42b89bd66bbacf799
BUG: 1254451
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/11948
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 2cab3f725d4c3a7c2ef024c57aeebcb1ec1ff7f5
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Aug 17 14:15:05 2015 +0530
tests: Moving ./tests/basic/mount-nfs-auth.t and ./tests/geo-rep/georep-basic-dr-rsync.t to bad test
Till the spurious regression failures are fixed, moving
these tests to bad test so as to unblock the NetBSD regression
Also added ./tests/geo-rep/georep-basic-dr-tarssh.t to bad test.
Change-Id: I8c0cb355a7832a6a794d2d3550d304947e91e936
BUG: 1254127
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11934
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit adbde4a863a990de8451a0026fe29bf87798927b
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Jul 3 15:27:15 2015 +0530
tiering/glusterd: start tier daemon during volume start
Tier daemon should always run with tier volume. If volume
is stopped and started again, we manually need to start
the tier-daemon, instead this patch will automatically trigger
tier process along with volume start.
A snapshot restored volume will not have node_state_info,
so we need to create and store it dynamically
Change-Id: I659387c914bec7a1b6929ee5cb61f7b406402075
BUG: 1238593
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/11525
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit f1e7679dfa1c9cac4c7293fcc5561cabef2051eb
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Aug 5 16:36:06 2015 +0530
xml output: Fix non-uniform opErrstr xml output
Display <opErrstr/> in case of no operrstr for
all xml output of gluster commands.
Change-Id: Ie16f749f90b4642357c562012408c434cd38661f
BUG: 1245895
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11835
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 1c0e579048d2da51afc870914065d8c4af636d07
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Fri Aug 7 12:37:52 2015 +0200
cluster/ec: Fix write size in self-heal
Self-heal was always using a fixed block size to heal a file. This
was incorrect for dispersed volumes with a number of data bricks not
being a power of 2.
This patch adjusts the block size to a multiple of the stripe size
of the volume. It also propagates errors detected during the data
heal to stop healing the file and not mark it as healed.
Change-Id: I9ee3fde98a9e5d6116fd096ceef88686fd1d28e2
BUG: 1251446
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/11862
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 68ccb1cd70fd2be9763fe07fe39dea1a25cc5c27
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Aug 5 12:07:48 2015 +0530
rdma:restore device linked list structure in case of failure
We maintain a linked list strcture to store device information,
and maintain head in a ctx variable. A new device will be added
at the beginning of list. But if the device creation failed, then
we need to adjust the linked list to proper state.
Change-Id: I07cefd3b808d8973a915728b3ba7f2955d29c92a
BUG: 1250297
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11829
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 98f5b80490c63d7e573f8fb34b5b9768da0ba854
Author: Susant Palai <spalai@redhat.com>
Date: Thu Jun 25 17:40:18 2015 +0530
dht: return non NULL xattr,xdata for ret >= 0
Change-Id: I4a3dd8c00894ceeed4af77df2d960f372281a03b
BUG: 1235989
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/11409
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit ea980a8a55238f50089a2adcd938a55443249d23
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Tue Aug 11 13:45:26 2015 +0530
tests: call cleanup on receiving external signals INT, TERM and HUP
problem:
when executing testcases manually, some time we may want to terminate the
testcase execution in between due to various reasons.
Existing testcase flow has no mechanism to call cleanup before they terminate
abnormally, hence we endup with volume setups and mount points uncleaned.
Solution:
This patch traps such kind of abnormal terminations and calls 'cleanup'
function soon after they are caught and then terminates the testcases
with appropriate status..
$ ./tests/basic/mount-nfs-auth.t
1..87
=========================
TEST 1 (line 8): glusterd
ok 1
RESULT 1: 0
=========================
TEST 2 (line 9): pidof glusterd
ok 2
RESULT 2: 0
=========================
TEST 3 (line 10): gluster -mode=script --wignore volume info
No volumes present
ok 3
RESULT 3: 0
^C
received external signal --INT--, calling 'cleanup' ...
$ glusterd && gluster vol status
No volumes present
Change-Id: Ia51a850c356e599b8b789cec22b9bb5e87e1548a
BUG: 1252374
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/11882
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 0ccb9c87a1c1a26e0962405c5f276241ca5aa744
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Aug 5 19:20:04 2015 +0530
dht/tier :rename fails with EBUSY
When the files was in hot tier and the look up was done already, then
hashed and cached subvolume will be hot-tier. Once the file is moved
from hot-tier to cold-tier, then subsequent lookup will send a
revalidate lookup to hot-tier and it will find out that the file was
actually moved and there is only link in the cached subvolume. So dht
will return an ESTALE to fuse. Upon receiving ESTALE for a lookup, fuse
will create a new inode and sent a fresh lookup. This lookup will be
successful, and it will locate the file properly. Then fuse try to link
the inode, but the older inode was already there in inmemory inode cache
with same gfid and that is also shared with fuse kernal. So inode_link
will return the older ionode itself. So the subsequent rename fop will
come to gluster with the older inode. From dht_rename, we will take a
lock on the inode and after successful inodelk on inode dht will send
lookup before creating a link. this lookup will again find out that the
file is a link file, and then dht will think that file is
migrating/migrated in the mean time, and will send EBUSY.
Change-Id: Ib3a01e5b1d7f64514b04bb6234026d049f082679
BUG: 1248306
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11768
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 362c97387ac3ad44ea68128171e5ed6bdd0d110b
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Aug 11 15:36:26 2015 -0400
cluster/tier: fix 64 bit issue with sql query using times
We overflowed when converting seconds to usecs in preperation for
sql queries. The fix uses uint64_t throughout including subexpressions.
Change-Id: I59bdb742197400dede97f54735b52030920b0d19
BUG: 1231268
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/11885
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
commit f33df149b7ef5cb122b8b9417d9614bd7d6a2d1c
Author: vmallika <vmallika@redhat.com>
Date: Fri Aug 7 15:51:53 2015 +0530
posix: posix_make_ancestryfromgfid shouldn't log ENOENT
posix_make_ancestryfromgfid shouldn't log ENOENT
and it should set proper op_errno
Change-Id: I8a87f30bc04d33cab06c91c74baa9563a1c7b45d
BUG: 1251449
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11861
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 97c09510a3fb7c65343dbb3ac595e5974cd6beb4
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Tue Jul 14 18:23:16 2015 +0530
cli: changing the assignment to comparison operator on an if statement
CID: 1124702
Change-Id: I6366834224a8176824070150b7f2af76b4d65b7f
BUG: 789278
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/11665
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit b425eb81e36bd9e91c0b6cd89725608b646dcc2d
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sat Jun 27 11:04:25 2015 +0530
rpc: add owner xlator argument to rpc_clnt_new
The @owner argument tells RPC layer the xlator that owns
the connection and to which xlator THIS needs be set during
network notifications like CONNECT and DISCONNECT.
Code paths that originate from the head of a (volume) graph and use
STACK_WIND ensure that the RPC local endpoint has the right xlator saved
in the frame of the call (callback pair). This guarantees that the
callback is executed in the right xlator context.
The client handshake process which includes fetching of brick ports from
glusterd, setting lk-version on the brick for the session, don't have
the correct xlator set in their frames. The problem lies with RPC
notifications. It doesn't have the provision to set THIS with the xlator
that is registered with the corresponding RPC programs. e.g,
RPC_CLNT_CONNECT event received by protocol/client doesn't have THIS set
to its xlator. This implies, call(-callbacks) originating from this
thread don't have the right xlator set too.
The fix would be to save the xlator registered with the RPC connection
during rpc_clnt_new. e.g, protocol/client's xlator would be saved with
the RPC connection that it 'owns'. RPC notifications such as CONNECT,
DISCONNECT, etc inherit THIS from the RPC connection's xlator.
Change-Id: I9dea2c35378c511d800ef58f7fa2ea5552f2c409
BUG: 1235582
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/11436
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 494cc1f94fb6d69c86b0551a5a12f7d640f17330
Author: Sakshi <sabansal@redhat.com>
Date: Fri Jun 12 19:42:30 2015 +0530
dht: remove 'null' for directory/file path from brick log for many operations
Change-Id: I39cd2089240c0ad62b749f176847cc5337e57f73
BUG: 1231264
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/11206
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 0890de16a3442038dbba70c65895df1cc8705ce0
Author: Sakshi <sabansal@redhat.com>
Date: Wed May 20 17:33:57 2015 +0530
dht : updating return value for layout set function
Change-Id: I7fd89e00b418391afe0a13c2033919c979cc8bbb
BUG: 789278
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/10869
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 836b3ffecd4cc0f0faeed363394c1d8e79ed361e
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Aug 6 16:53:22 2015 +0530
features/bitrot: Fix rescheduling scrub-frequency
While rescheduling scrub frequency, boot time of
the brick was considered where it is not required
and also delta is calculated using unsigned int
resulting in the loss of fractional part leading to
wrong scrub frequency. Boot time is completely
removed and delta calculation is simplified.
Change-Id: If54697389f663afc86408dc8a01a3ea07e00f2dc
BUG: 1251042
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11853
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 18b55d6e549f1f0292c83f8cdaae3e248d3df010
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Sat Aug 8 01:53:52 2015 +0530
tests: Disable trace mode in G_LOG
We run tests in trace mode(set -x) when
re-running failed tests. G_LOG is a util
function and it need not be executed in
trace mode.
Change-Id: I5490bdcacef6856c5501272c8173828c30aaf373
BUG: 1251592
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/11865
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit eac8ae3e5707c546102aeb65f16f9553635c5f6f
Author: Joseph Fernandes <josferna@redhat.com>
Date: Mon Jul 13 18:45:11 2015 +0530
tier/libgfdb : Setting Freq counters of un-selected files to zero
Change Time Recorder increments the write/read frequency counters
on a read or write of a file, if the "features.record-counters" is
"on". It is the responsibility of the tiering migrator to reset
these counters to zero for un-selected files to reset them to zero
as frequency counters are function of promotion/Demotion cycles.
If the counters are not set to zero then,
1) the counters may overflow in the DB
2) The file may be wrongly promoted or demoted.
This fix will reset the freq counters of un-selected files to zero
after promotion/demotion frequency.
Change-Id: Ideea2c76a52d421a7e67c37fb0c823f552b3da7a
BUG: 1242504
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/11648
Tested-by: Joseph Fernandes
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 3c14b51b349b6c3d6976a0199fc76155857c6d8e
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Aug 6 12:19:23 2015 +0530
features/shard: Fill inode ctx in readdir(p) callback too
The only place where shard translator was initialising inode ctx
was lookup callback. But if the inodes are created and linked through
readdirp, shard_lookup() path _may_ not be exercised before FUSE
winds other fops on them. Since shard translator does an
inode_ctx_get() first thing in most fops, an uninitialised ctx could
cause it to fail the operation with ENOMEM.
The solution would be to also initialise inode ctx if it has not been
done already in readdir(p) callback.
Change-Id: I3e058cd2a29bc6a69a96aaac89165c3251315625
BUG: 1250855
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11854
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 76828ed92a282c88a386111cada727512ac5eced
Author: Dan Lambright <dlambrig@redhat.com>
Date: Thu Aug 6 09:59:35 2015 -0400
cluster/tier: fix demotion when cold tier is EC
We did not set the gfid in the loc structure in tier demotion. EC
has a sanity check which fails FOPs when the loc gfid mismatches
with the file attribute. When the FOP failed demotion was aborted.
Change-Id: I69022c9ccb135b86e1feea93b01801b6a4100509
BUG: 1251121
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/11855
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 214d33e7822dbcedef39a2898134d2e33bcdbbd4
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Jul 22 15:12:36 2015 +0530
quota : checking for absolute path in quota command
Currently, if absolute path is not entered in
"gluster volume quota <vol-name> list <path>",
it just shows the header (Path Hard-limit Soft-limit...)
instead of showing an error message.
With this patch, it shows an error to enter the absolute path.
Change-Id: I2c3d34bfdc7b924d00b11f8649b73a5069cbc2dc
BUG: 1245558
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/11738
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 90aebc80aa351d56720f2a52bf2cc9f76881267f
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Mon Jun 29 15:02:52 2015 +0530
cluster/dht: Reset source file mode bits on migration failure
DHT rebalance uses the sgid and sticky bits to indicate
that a file is being migrated. These were not removed if
the file migration failed.
The fix resets these bits to the original values.
Change-Id: I9801bfc0bd80c0800251ccd66c1c91a51cffd909
BUG: 1236512
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/11454
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5608731da03e964de5f9d81ba6dfef33949aed20
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu May 28 19:26:00 2015 +0530
tests: New simple geo-rep regression test suite
This is a new simple regression test suite for
geo-replication. This is written keeping in mind
the run time for regression test. The existing
regression test suite is rigorous one and could
be run nightly. Hence the existing geo-rep tests
are being removed as part of this.
Also re-enable geo-rep regression with this patch.
Thanks Aravinda for initial template and plan.
Change-Id: If544ac295eaf67ac66e0b071903cc1096e71d437
BUG: 1227624
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11058
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 9dc5c9485db85733e6f0936749bc867163c47e22
Author: Anusha Rao <anusha91rao@gmail.com>
Date: Mon May 4 12:34:09 2015 +0530
features/changelog: Porting log messages to new logging framework
Change-Id: Ic7f842acca52908fd88e0796dc90b82650405b25
BUG: 1194640
Signed-off-by: Anusha Rao <anusha91rao@gmail.com>
Reviewed-on: http://review.gluster.org/10532
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 649da04fac8cc9b959bfc3279c0364a9e2e29173
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Apr 16 17:54:24 2015 +0530
glusterd: log improvement in glusterd_peer_rpc_notify
If ping time out is enabled glusterd can receive a disconnect event from a peer
which has been already deleted resulting into a critical log printed. This patch
ensures that critical message is logged only when its a connect event.
Change-Id: I67d9aa3f60195e08af7dfc8a42683422aaf90a00
BUG: 1212437
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10272
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 051ca4d46d3e33b9b8018ed3997b66004a9de998
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Sat Jun 27 13:17:32 2015 +0530
features/bit-rot-stub: fail the fop if inode context get fails
In stub, for fops like readv, writev etc, if the the object is bad, then the fop
is denied. But for checking if the object is bad inode context should be
checked. Now, if the inode context is not there, then the fop is allowed to
continue. This patch fixes it and the fop is unwound with an error, if the inode
context is not found.
Change-Id: I5ea4d4fc1a91387f7f9d13ca8cb43c88429f02b0
BUG: 1243391
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11449
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 2dfa1477984a9f85010747f26342fceb7ad2ce0a
Author: Pamela Ousley <pousley@redhat.com>
Date: Mon Aug 10 18:38:00 2015 -0400
cluster/tier: fixed pattern matching error in tier.t
The check_counters function contained "grep -o '[0-9*]'", which
was in error. This patch corrects it to "grep -o '[0-9]*'".
This fix was necessary to accommodate for double-digit counters.
Change-Id: Idaa09de4403bf66e741176a7377eba264819ca3b
BUG: 1252121
Signed-off-by: Pamela Ousley <pousley@redhat.com>
Reviewed-on: http://review.gluster.org/11877
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 08cbd2b6c985544ba881a0792737dfd5188914a3
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Aug 7 17:32:29 2015 +0530
tests: add basic/afr/arbiter-statfs.t
This is a test-case for BZ 1251346
Change-Id: Icbde8d17c823a3f2c98056c14a75f0ef5227b848
BUG: 1251346
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/11864
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 44dc7c74e61d3c175c14c8ed8e218d7febe8c0f4
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Jul 23 18:02:10 2015 +0530
Removing 'legacy' directory from glusterfs doc repo
As per http://www.gluster.org/pipermail/gluster-users/2015-July/022918.html.
Change-Id: Ie1473c967a53a34b6e2b4f4653e3e63ae5ea16fa
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/11748
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 5f30b8e176d35aaa8681046cf8c4aab189541a34
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Mon Aug 10 14:47:17 2015 +0530
Removing gluster_find doc
This is already ported to https://github.com/gluster/glusterdocs/tree/master/GlusterFS%20Tools
and no need for duplicate copy.
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Change-Id: Ie7c3c72b3d7f001ddc863e89b4ad933bda4e2816
BUG: 1206539
Reviewed-on: http://review.gluster.org/11870
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit d17f3d7ba9c7e7213520a4a90a00fb6483363091
Author: N Balachandran <nbalacha@redhat.com>
Date: Mon Aug 3 13:57:37 2015 +0530
glusterd/rebalance: trusted rebalance volfile
Creating the client volfiles with GF_CLIENT_OTHER
overwrites the trusted rebalance volfile and causes rebalance
to fail if auth.allow is set.
Now, we always set the value of trusted-client to GF_CLIENT_TRUSTED
for rebalance volfiles.
Change-Id: I95eb510256d18dfa9048f96a1aeb71cca4811811
BUG: 1248415
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/11819
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 2545357d3fad38764e1bd0cd0098dcacda0d1634
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jul 20 16:03:40 2015 +0530
tests: set inode-lru-limit to 1 and check if bit-rot xattrs are wrongy created
This test sets the lru limit of the inode table to 1 and checks if inode forgets
and resolve cause any problem with bit-rot xattrs (especially bad-file xattr).
Change-Id: I1fa25fa2d31dda8d26e8192562e896e5bddd0381
BUG: 1244613
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11718
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit d29be8154e58beffa5dbc98ac8722020416a60f5
Author: Meghana M <mmadhusu@redhat.com>
Date: Mon Aug 3 03:03:07 2015 +0530
Set nfs.disable to "on" when global NFS-Ganesha key is enabled
"nfs.disable" gets set to "on" for all the existing volumes,
when the command "gluster nfs-ganesha enable" is executed.
When a new volume is created,it gets exported via Gluster-NFS on
the nodes outside the NFS-Ganesha. To fix this,
the "nfs.disable" key is set to "on" before starting the volume,
whenever the global option is set to "enable".
Change-Id: I7ce58928c36eadb8c122cded5bdcea271a0a4ffa
BUG: 1251857
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11871
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 86db7605ddeb8565a4cf70272b4407012c5df094
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Aug 6 13:00:18 2015 +0530
Include documentation url in README for reference
Change-Id: Iaa6b6e3b5fd5c3d145a48501e9a5517ae3c12c34
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/11851
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bb974c9350a8842df5c6b3f8eb7ae259d7787c2c
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Sat Aug 8 21:29:55 2015 +0530
tests: Add consistently failing tests to the "bad tests" list
Change-Id: Ie8f296413e012027bb335c41114cacfcde9f6904
BUG: 1251674
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11868
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit acc1bba8ea15ad2a58ef4fc43b33c1aa535d890e
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jul 30 17:03:50 2015 +0530
logging: Stop using global xlator for log_buf allocations
This reverts commit 765849ee00f6661c9059122ff2346b03b224745f.
With http://review.gluster.org/#/c/10417/, struct mem_accnt
is no longer embedded in a xlator_t object, but instead is
allocated separately. Hence this workaround provided to avoid
crashes in logging infrastructure is no longer needed
BUG: 1243806
Change-Id: I1bc006172ebe5e417a5923f8be2f37a6277c5e5d
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11811
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 2123463ddb6fc8e419d26e22f63c58aa65441771
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Aug 6 06:22:38 2015 +0530
rpc-clnt: Check for transport object during rpc connection cleanup
While doing glfs_fini(), all the xlators are first notified of
PARENT_DOWN. protocol-client xlator on receving that notification
does rpc_clnt_disable which disassociates rpc->conn with its
transport object and does socket shutdown. So any further references
to conn->trans should not happen during rpc connection cleanup which
is done mainly as part of epoll event handling of EPOLLERR/EPOLLHUP.
BUG: 1250797
Change-Id: I7d0346451d40372ad59a6a2326176fbb1e694712
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11845
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit e8443a1319c9493c84d71fa9ec662c4412c5af5f
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Aug 5 19:23:01 2015 +0530
quota : volume-reset shouldn't remove quota-deem-statfs
Volume-reset shouldn't remove quota-deem-statfs, unless
explicitly specified, when quota is enabled.
1) glusterd_op_stage_reset_volume ()
'gluster volume set/reset <VOLNAME>' features.quota/
features.inode-quota' should not be allowed as it is deprecated.
Setting and resetting quota/inode-quota features should be allowed
only through 'gluster volume quota <VOLNAME> enable/disable'.
2) glusterd_enable_default_options ()
Option 'features.quota-deem-statfs' should not be turned off
with 'gluster volume reset <VOLNAME>', since quota features
can be set/reset only with 'gluster volume quota <VOLNAME>
enable/disable'.
But, 'gluster volume set features.quota-deem-statfs'
can be turned on/off when quota is enabled.
Change-Id: Ib5aa00a4d8c82819c08dfc23e2a86f43ebc436c4
BUG: 1250582
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/11839
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 174202979e3e9a8cfad0cee16ee299be8f481980
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Aug 7 10:10:54 2015 +0530
afr: Do not wind statfs to arbiter brick
Problem: AFR serves statfs from the brick having the least free space
available. Since the size to be allocated to the arbiter brick in a 3
way replica is supposed to be considerably lesser than the other 2
bricks, statfs will be served from this brick which is incorrect.
Fix: Don't serve statfs from the arbiter brick.
Change-Id: I5af098b9c50626f52cf3d7dbb060bf754c797f05
BUG: 1251346
Reported-by: Fredrik Brandt <fredrikb@denlillaplaneten.se>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/11857
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 3844f1af4c6013b821b6c7ef5953a70d53914e87
Author: anand <anekkunt@redhat.com>
Date: Wed May 20 19:52:11 2015 +0530
glusterd: Stop/restart/notify to daemons(svcs) during reset/set on a volume
problem : Reset/set commands were not working properly. reset command returns
success but it not sending notification to svcs if corresponding graph modified.
Fix: Whenever reset/set command issued, generate the temp graph and compare
with original graph and do the fallowing actions
1.) If both graph are identical nothing to do with svcs.
2.) If any changes in graph topology restart/stop service by calling
svc manager.
3) If changes in options send notify signal by calling glusterd_fetchspec_notify.
Change-Id: I852c4602eafed1ae6e6a02424814fe3a83e3d4c7
BUG: 1209329
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/10850
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit f1708a2f9b1dc71a2d7c1ecbc60c85b32639ef8c
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Aug 5 23:42:41 2015 +0200
cluster/ec: Fix tracking of good bricks
The bitmask of good and bad bricks was kept in the context of the
corresponding inode or fd. This was problematic when an external
process (another client or the self-heal process) did heal the
bricks but no one changed the bitmaks of other clients.
This patch removes the bitmask stored in the context and calculates
which bricks are healthy after locking them and doing the initial
xattrop. After that, it's updated using the result of each fop.
Change-Id: I225e31cd219a12af4ca58871d8a4bb6f742b223c
BUG: 1236065
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/11844
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 1d7fb91cd6990146b693f46b3a635eae81f20739
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Aug 5 19:34:01 2015 +0530
dht/tiering : create new dictionary during migration
To avoid setting wrong xattr during creating link file
Change-Id: Iad8de3521eae17e510035ed42e3e01933d647096
BUG: 1250828
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11838
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 9debdafdbca1c83431c9e08556de372788dc4c1c
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Tue Aug 4 18:09:15 2015 +0530
Updating doc maintainers list
Change-Id: I2064f39d915209679ece48b4484b773dfc8e9778
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/11826
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 63ad603542044e473118d33bcc02f121c86beaa7
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jul 23 18:11:23 2015 +0530
geo-rep: Fix gsyncd failing to start on slave
This is a regression introduced by 2ca6441.
The memory is freed while the caller expects
it be not. The patch fixes the same.
Change-Id: I76d95eef15b3f7af365b392f2426c8b0388254fc
BUG: 1222898
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11751
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 424755b53306710b9ce1fc6f71bc4933728d63a2
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Aug 5 16:58:01 2015 +0530
features/shard: Fix excessive logging in readdir(p) callback
On enabling features.shard on a volume which already has few files,
performing operations on the mount was causing excessive logging of
messages of the following kind:
[2015-08-05 10:57:48.743352] E [shard.c:232:shard_modify_size_and_block_count]
2-dis-shard: Failed to get trusted.glusterfs.shard.file-size for
0b2bd401-c438-4d57-8ae5-8d26105d3396
Turns out this is coming from shard_readdir_cbk() where the shard
translator unconditionally looks for the xattr
'trusted.glusterfs.shard.file-size' in every entry's rsp dict and
logs this error on not finding it. But files that are not sharded
(i.e., the ones that were created before sharding was enabled on the volume)
will not (and should not) have this xattr associated with them.
So these logs are misleading and must be suppressed in readdir(p).
Change-Id: I8d268b4f90a8bf744c7851f1984f5a1b6968fb6a
BUG: 1250441
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11843
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4126eec14fe4923d71366497d08753a347a337a6
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Jul 23 18:16:18 2015 +0530
Remove upgrade guide doc from glusterfs repo
According to the new workflow defined for glusterfs documentation,
the upgrade guide is maintained at https://github.com/gluster/glusterdocs
Refer #https://www.mail-archive.com/gluster-users@gluster.org/msg21168.html
Change-Id: I6b04847d0201d362ec054ee245999b6b42e42ea7
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/11750
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 1585b6ad39c163bb6ecca10fa5b41a040e57ed9b
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jul 21 18:50:12 2015 +0200
fuse: add "resolve-gids" mount option to overcome 32-groups limit
Add a --resolve-gids commandline option to the glusterfs binary. This
option gets set when executing "mount -t glusterfs -o resolve-gids ...".
This option is most useful in combination with the "acl" mount option.
POSIX ACL permission checking is done on the FUSE-client side to improve
performance (in addition to the checking on the bricks).
The fuse-bridge reads /proc/$PID/status by default, and this file
contains maximum 32 groups. Any local (client-side) permission checking
that requires more than the first 32 groups will fail.
By enabling the "resolve-gids" option, the fuse-bridge will call
getgrouplist() to retrieve all the groups from the user accessing the
mountpoint. This is comparable to how "nfs.server-aux-gids" works.
Note that when a user belongs to more than ~93 groups, the volume option
server.manage-gids needs to be enabled too. Without this option, the
RPC-layer will need to reduce the number of groups to make them fit in
the RPC-header.
Change-Id: I7ede90d0e41bcf55755cced5747fa0fb1699edb2
BUG: 1246275
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11732
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit a75928f455b1410e9adeaceee8fce620c19005c8
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Jul 30 13:54:51 2015 +0200
SSL improvements: ECDH, DH, CRL, and accessible options
- Introduce ssl.dh-param option to specify a file containinf DH parameters.
If it is provided, EDH ciphers are available.
- Introduce ssl.ec-curve option to specify an elliptic curve name. If
unspecified, ECDH ciphers are available using the prime256v1 curve.
- Introduce ssl.crl-path option to specify the directory where the
CRL hash file can be found. Setting to NULL disable CRL checking,
just like the default.
- Make all ssl.* options accessible through gluster volume set.
- In default cipher list, exclude weak ciphers instead of listing
the strong ones.
- Enforce server cipher preference.
- introduce RPC_SET_OPT macro to factor repetitive code in glusterd-volgen.c
- Add ssl-ciphers.t test to check all the features touched by this change.
Change-Id: I7bfd433df6bbf176f4a58e770e06bcdbe22a101a
BUG: 1247152
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/11735
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 8ee76bdd89c96c20fa326833de11f1a6ecfe520e
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Jul 23 18:07:08 2015 +0530
Removing glusterfs features doc from glusterfs repo
According to the new workflow defined for glusterfs documentation,
the features are maintained at https://github.com/gluster/glusterfs-specs.
Removing the features dir from the doc repo as per,
https://www.mail-archive.com/gluster-users@gluster.org/msg21168.html
Change-Id: I2f1219c49ef933f6b89a55f2238787d8565d80b6
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/11749
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 18a48155ab48f4430354f972f486dbf845e1417b
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Aug 3 13:28:09 2015 +0530
client, rpc: make ping-timeout configurable for glusterfs clients
Change-Id: Idd94adb0457aaffce7330f56f98cebafa2c4dae8
BUG: 1249499
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/11818
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 85f12571c47909aa798f4129d8554de901439d04
Author: Milind Changire <mchangir@redhat.com>
Date: Thu Jul 16 15:36:17 2015 +0530
tools/glusterfind: password prompts for peer nodes on delete
SSH keys getting deleted on local node caused password prompts for peer
nodes on a delete operation.
This race for session directory cleanup on local node is now addressed
by avoiding the delete path for local node in node_cmd()
The session directory tree is deleted anyway in mode_delete()
Change-Id: I51c4baf4f9c1ed3caa319d4163bef343bd621429
BUG: 1243785
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/11693
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit b5ec8e86cf5fcd708bacb21eaa036b7de3285c13
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Jul 23 17:54:34 2015 +0530
Removing admin guide from glusterfs doc repo
The admin guide is maintained at https://github.com/gluster/glusterdocs.
The admin guide updates should be against above repo and we should only
have one copy. This is based on the discussion happened here:
https://www.mail-archive.com/gluster-users@gluster.org/msg21168.html
Change-Id: If5395e7e8005d3e505d229180ce55d466cb1a1fc
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/11747
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 6b54b664f481dc35c408a8d71e48b74c16bc4296
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Jul 30 11:57:45 2015 +0530
tests: Get more debug info from failed tests
Change-Id: I8e8dd0e4fc6955ce4b1ac9f276362b61ca71f1c5
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/11801
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 89cbcf9f44260e19fa72daa405da7773e7c48ba5
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Jul 30 09:40:24 2015 +0530
glusterd: fix op-version bump up flow
If a cluster is upgraded from 3.5 to latest version, gluster volume set all
cluster.op-version <VERSION> will throw an error message back to the user saying
unlocking failed. This is because of trying to release a volume wise lock in
unlock phase as the lock was taken cluster wide. The problem surfaced because
the op-version is updated in commit phase and unlocking works in the v3
framework where it should have used cluster unlock.
Fix is to decide which lock/unlock is to be followed before invoking lock phase
Change-Id: Iefb271a058431fe336a493c24d240ed833f279c5
BUG: 1248298
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11798
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 5eb521c1a38d96c59934021fa83e2910d1699b32
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Mon Aug 3 06:33:01 2015 -0700
Revert "Add DESTDIR support for pyglupy Makefile"
This reverts commit 871000e3ddb457c9cc5757cd94cfc178e3c1be29.
Change-Id: I05913151d9cb4c50057e5e72859768085041bdc9
Reviewed-on: http://review.gluster.org/11821
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 0205cd5a0f4be2174b8c186f4d9474e069efcb29
Author: Michael Scherer <misc@redhat.com>
Date: Fri Jul 31 16:37:41 2015 +0200
Add DESTDIR support for pyglupy Makefile
Smoke tests run on a new slave on Fedora 22 fail because make install
try to install the python package in /usr/lib/python2.7 without being
root, because there is no $DESTDIR support for that part.
Change-Id: Ibed17dd091a96fbdf5536ac66b8c876b33a39cd6
Signed-off-by: Michael Scherer <mscherer@redhat.com>
Reviewed-on: http://review.gluster.org/11813
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit eb8ea80fffc5e6b946ace4751c2a253393b39646
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jul 28 14:37:47 2015 +0530
geo-rep: Do not crash worker on ESTALE
Handle ESTALE returned by lstat gracefully
by retrying it. Do not crash the worker.
Change-Id: I2527cd8bd1f7d2428cb4fa3f20782bebaf2df12a
BUG: 1247529
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11772
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit dca62da70859a3628f664ee5b53c6460932a71aa
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Jul 3 11:34:20 2015 +0530
glusterd: Do not log failure if glusterd_get_txn_opinfo fails in gluster volume status
The first RPC call of gluster volume status fetches the list of the volume names
from GlusterD and during that time since no volume name is set in the dictionary
gluserd_get_txn_opinfo fails resulting into a failure log which is annoying to
the user considering this command is triggered frequently.
Fix is to have callers log it depending on the need
Change-Id: Ib60a56725208182175513c505c61bcb28148b2d0
BUG: 1238936
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11520
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 22f51ae1b2ed7f5bb7e398e6e0798f550655b850
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jul 30 08:23:37 2015 -0400
build: scripts are not installed with +x bit
scripts listed in Makefile.am as foo_DATA, should be foo_SCRIPTS
to be installed +x
Change-Id: Ib9b98efcea968c03b574726bdc0d4f76cdfd1dc1
BUG: 1225018
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11806
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit b7663f417cf7313ef37a1ddac0d9e642b1dcb02d
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Mon Jun 1 14:35:57 2015 +0530
libglusterfs: write error handling when filesystem have no space left
When no space left on filesystem and user want to perform any operation
which result to change in /var/lib/glusterd/* files then glusterd is
failing to write on temporary file.
Fix is to handle error when write failed on temporary files due to no
space left on file system.
Change-Id: I79d595776b42580da35e1282b4a3cd7fe3d14afe
BUG: 1226829
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/11029
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Cedric Buissart
commit af2ade318b6a8aaca3ff98ed5f529f3fe8c55363
Author: vmallika <vmallika@redhat.com>
Date: Wed Jul 22 14:49:39 2015 +0530
quota/marker: set log-level to debug for ESTALE/ENOENT for marker txn
For all marker txn, it is possible that while the txn in progress
file can be removed.
So log all ENOENT/ESTALE error in debug level
Change-Id: I776ba3cda33fe992f9dcc7baede7206c4ce19553
BUG: 1245544
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11736
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8b25847f0c24b3d60f09b7b9fc69e7d9852590f7
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jul 7 16:27:45 2015 +0530
rebalance/glusterd: Refactor rebalance volfile
performance xlator loaded in rebalance xlators are dummy
translators, since all fops are starting with dht level.
Removing the performance xlators from rebalance volfile
will help to minimize the chance for a graph switch.
The new rebalance xlators will look like->>>
(io-stats)
||
||
||
(----DHT----)
// \\
// \\
// \\
(replica-1) ... (replica-n)
// \\ // \\
// \\ // \\
// \\ // \\
client client client client
Change-Id: I3808e3b48fd0cb3e60ef386b8ac9fd994e2831e3
BUG: 1240621
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11565
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 9cfc36088cec91a8ee52ac451eef1637e44b5556
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 28 19:15:44 2015 +0530
tests: reset IFS after changing it
Many thanks to fanghuang.data@yahoo.com for RC and BUG
https://bugzilla.redhat.com/show_bug.cgi?id=1245425#c0
BUG: 1245425
Change-Id: I411384ad2b81db9941ac136f4e584a3a965d53f1
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11779
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit d6fe3ab342738b3723b8ccd97c1ddfca531e92f0
Author: Milind Changire <mchangir@redhat.com>
Date: Wed Jul 29 14:57:44 2015 +0530
rpc: check for unprivileged port should start at 1024
The current check for unprivileged port starts beyond 1024
i.e. port > 1024
The actual check should start at 1024
i.e. port >= 1024
Change-Id: I78aff3025891e3e78ca6a9a670c89571752157df
BUG: 1247930
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/11788
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8ba2d38f7d0980d5e97828ec32ee2839cea262d7
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Jul 27 12:30:19 2015 +0530
features/shard: Create /.shard with 0777 permissions (for now)
Change-Id: I4e5692f06a189230825f0aeb6487b103bfb66fe1
BUG: 1247108
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11791
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit f7c3c5115fb691305e346f16b6ab41f49af98453
Author: vmallika <vmallika@redhat.com>
Date: Wed Jul 22 09:02:39 2015 +0530
quota: fix parents caching during build ancestry
In build ancestry, we get the list of parents for a file,
these parents are cached in inode ctx.
This caching is not happening because posix is not setting
d_stat information in the leaf node entry
This patch fixes the issue
Inode-ctx is not updated with new parent when
rename performed on same directory.
This patch fixes the issue
There is a possibility of caching stale entries,
consider below example:
1) build_ancestry invoked on a file
2) rename is invoked on the same file
3) buils_ancestry prepared entries of old parent
4) rename completed and in cbk old parent is replaced with
new parent in inode ctx
5) now build_ancestry cbk adds old parent to inode ctx
In this patch we also remove stale entries in writev and fallocate
Change-Id: Ib1854a41b47b14eb775326588352015c83d034de
BUG: 1240949
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11574
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5f6579d47b7a1da7114e02e97719113dcc6f259a
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Jul 29 16:24:37 2015 +0530
tests/tier: mark tiering related spurious failures as bad test
Change-Id: I808845e55103821eb5eda4c0650dc55facad01e2
BUG: 1246229
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11792
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 446e06b5014f4cabca03fdea13b7de773b8e2cc3
Author: Hari Gowtham <hgowtham@redhat.com>
Date: Thu Jul 23 14:44:04 2015 +0530
tiering: Error message change for detach-tier non tier volume
Change-Id: Ib350b201df14b105e475426d2ec20ff5da39a8a1
BUG: 1245935
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/11745
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 2677bf27e281920fe21753656e358057998b1a04
Author: Anand Avati <avati@redhat.com>
Date: Fri Dec 6 17:31:57 2013 -0800
timer: fix race between gf_timer_call_cancel() and gf_timer_proc()
Change-Id: Ie264d3d591352e4a8ddaa90ae2174d9c552396f1
BUG: 1243187
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6459
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 8ca56135605c8ba61eec11287bcaf168c85181fe
Author: Sakshi <sabansal@redhat.com>
Date: Thu Apr 30 18:10:26 2015 +0530
cli : removing extra colon from rebalance status output
Change-Id: I74417471d7d2a86f198037d88dbf7d072c4349c3
BUG: 1218960
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/10475
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c5b0bf69b9dafa6ace444e2a9e91fb5adbc5aea9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 28 18:38:56 2015 +0530
features/shard: Fix block size get from xdata
Instead of using dict_get_ptr, dict_get_uint64 was used. If the first byte of
the value is '\0' then size is returned as 0 because strtoull is used in
data_to_uint64. This will make it seem like the file is not sharded at all.
BUG: 1247108
Change-Id: Id1fc291198ac94b20ae645c04a51db78bab51993
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11778
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7f19d0113daecbc06af455523ecf96dc1d395aa4
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Jul 3 16:32:56 2015 +0530
geo-rep: Fix history failure
Both ACTIVE and PASSIVE workers register to changelog
at almost same time. When PASSIVE worker becomes ACTIVE,
the start and end time would be current stime and register_time
repectively for history API. Hence register_time would be less
then stime for which history obviously fails. But it will
be successful for the next restart as new register_time > stime.
Fix is to pass current time as the end time to history call
instead of the register_time.
Also improvised the logging for ACTIVE/PASSIVE switching.
Change-Id: Idc08b4b55c7a4c575ba44918a98389164ccbee8f
BUG: 1239044
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11524
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 9df36cf066ca5064a8fd349134ae313e85be2ffe
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jul 28 16:02:50 2015 -0400
rpc: fix concurrency bug in gf_authenticate
The basic problem is that gf_authenticate abused global variables to
pass info through dict_foreach. This is not thread-safe, but it wasn't
affecting most people until multi-threaded epoll came along. Now, if
two threads get into this code at the same time - and there's nothing to
prevent it - one of them could free one of the dicts involved while the
other is still using it.
The fix is to pass this same information using a temporary structure
instead of globals. This makes the code smaller and more efficient too.
Change-Id: I72cccc440bb40d5f7ff695250dd014762c7efb73
BUG: 1247765
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/11780
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 40163f99374e85c41526703ec76fbe0d57be08d6
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jul 28 11:25:55 2015 +0530
features/shard: (Re)initialize local->call_count before winding lookup
Change-Id: I616409c38b86c0acf1817b3472a1fed73db293f8
BUG: 1247108
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11770
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0511765de7a7f7329a1e06d0e6620dde080bd44f
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Tue Jul 28 06:42:26 2015 -0700
Revert "Revert "core: avoid crashes in gf_msg dup-detection code""
This reverts commit ca67ac071c56a3bd6f2b2ba3a958f0305db50a3d.
Change-Id: Iba688b524c78b84aaa0992afa5ee8e549603d990
Reviewed-on: http://review.gluster.org/11777
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ef1243dfcc6c40ff42e447e3a5c113e1865021d4
Author: anand <anekkunt@redhat.com>
Date: Fri Jul 24 15:48:50 2015 +0530
glusterd: glusterd crash due to race between handshake and snapshot remove threads
Issue : glusterd was crashing due to race between handshake thread and snapshot
remove
RCA : Snapshot thread referring voinfo and same time volinfo is modified during handshake,
glusterd was crashing due to this inconsistent data of volinfo .
Note: Sending commands without checking cluster status may lead to crash
Fix:.Wait for handshake complete/cluster ready before proceeding commands.
Change-Id: Iefd986664bd9dd225f0abf8f85476d6afd206914
BUG: 1246432
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/11757
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 6685c444d7d52fcfb5ef41a62d388e905d2f7066
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Jul 21 18:05:06 2015 +0200
cluster/ec: Minimize usage of EIO error
Change-Id: I82e245615419c2006a2d1b5e94ff0908d2f5e891
BUG: 1245276
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/11741
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit b87677653dfc8cf82ee273e85ebf00886aef9682
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jul 21 15:13:28 2015 +0530
features/bit-rot-stub: handle REOPEN_WAIT on forgotten inodes
Change-Id: Ia8706ec9b66d78c4e33e7b7faf69f0d113ba68a4
BUG: 1245981
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11729
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 8fd954b7ce454bab46cf3472fa553c52b1deb05d
Author: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Date: Tue Jul 14 12:24:21 2015 +0530
cli : changing the gluster peer probe message
The gluster peer probe command with invalid ips dont report that
IP's can also be a valid in usage.
Change-Id: I8f58341a2b76369ccf62f88ca0ecd8a9a9529af6
BUG: 1242742
Signed-off-by: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Reviewed-on: http://review.gluster.org/11657
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit edd9916ed0d1dba602f636b707a14aa17a7ca93d
Author: anand <anekkunt@redhat.com>
Date: Tue Jul 21 15:42:24 2015 +0530
glusterd: getting txn_id from frame->cookie in op_sm call back
RCA: If rebalance start is triggered from one node and one of other nodes in the cluster goes down simultaneously
we might end up in a case where callback will use the txn_id from priv->global_txn_id which is always zeros and
this means injecting an event with an incorrect txn_id will result into op-sm getting stuck.
fix: set txn_id in frame->cookie during sumbit_and_request, so that we can get txn_id in call back
functions.
Change-Id: I519176c259ea9d37897791a77a7c92eb96d10052
BUG: 1245142
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/11728
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit de96327e4188d436bddce03f2db47f351d8c1f50
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jul 23 12:58:02 2015 +0530
Revert "core: avoid crashes in gf_msg dup-detection code"
This reverts commit 765849ee00f6661c9059122ff2346b03b224745f.
With http://review.gluster.org/#/c/10417/, struct mem_accnt
is no longer embedded in a xlator_t object, but instead is
allocated separately. Hence this workaround provided to avoid
crashes in logging infrastructure is no longer needed.
Change-Id: I460b62780f570cd9873bad17d9327eefc17a1355
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11746
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 347f85ec46cc30187727a52858588f83b3df1e35
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Mon Jun 29 20:41:08 2015 +0530
changelog: test case for verifying empty changelogs avoided
Test case added to check NO EMPTY changelogs gets
created over changelog rollover period.
Change-Id: I83323644e1a0c4b920a472e1179606a0fd54d1d9
BUG: 1237000
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/11460
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 7fa45f3d25c10cc401ad03c359a3114c671bcc64
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jul 22 15:18:20 2015 +0530
features/shard: Handle unlink of files with holes appropriately in unlink() and rename().
Change-Id: I25a02386dc95580c2e76a13fdd8e11a0df234d56
BUG: 1245547
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11737
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 21f273ef187919ae3147eef7c3fac91f269a4e81
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Jul 1 14:47:48 2015 +0530
glusterd: initialize the daemon services on demand
As of now all the daemon services are initialized at glusterD init path. Since
socket file path of per node daemon demands the uuid of the node, MY_UUID macro
is invoked as part of the initialization.
The above flow breaks the usecases where a gluster image is built following a
template could be Dockerfile, Vagrantfile or any kind of virtualization
environment. This means bringing instances of this image would have same UUIDs
for the node resulting in peer probe failure.
Solution is to lazily initialize the services on demand.
Change-Id: If7caa533026c83e98c7c7678bded67085d0bbc1e
BUG: 1238135
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11488
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit db1bbe1c015d79c01e718e3fa30c5037934d7cdc
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jul 23 14:59:19 2015 +0530
posix,shard: Fill in ia_size and ia_blocks before unwinding (f)setattr
The shard xlator will request for size xattrs in its request and
posix will perform xattr_fill of requested keys before unwinding
(f)setattr.
Change-Id: I4ec4779568be6f805724b875b1b4215787112e7f
BUG: 1246082
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11754
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit c2b82292bc7f9af9967db312d33d045d34497b4e
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jul 23 18:08:34 2015 +0530
cluster/afr: Fix incorrect logging in read transactions
afr_read_txn_refresh_done() at its entry point can fail for
reasons like ENOENT/ESTALE but seldom due to EIO, which is something
_AFR_ would internally generate and not receive in response from
a child translator. AFR is reporting "split-brain" for _any_
kind of failure in read txn, of the following kind:
[2015-07-07 18:04:34.787612] E [MSGID: 108008]
[afr-read-txn.c:76:afr_read_txn_refresh_done] 0-vol3-replicate-3:
Failing STAT on gfid 18a973c4-73d3-48b8-942c-33a6f1a8e6b4:
split-brain observed. [Input/output error]
This patch fixes such misleading errors.
To-Do:
Avoid logging EIO if/when split-brain choice is set.
Will do that as part of a separate commit.
Change-Id: Ib513c75168f7026118ad5b3f0b35e9dd498cfe1e
BUG: 1246052
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11756
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9ad85888fa8d6f1424b7ca4f676af68cec5fda1b
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed Jun 24 12:21:02 2015 +0530
rpc: fix binding brick issue while bind-insecure is enabled
problem:
When bind-insecure is turned on (which is the default now), it may happen
that brick is not able to bind to port assigned by Glusterd for example
49192-49195...
It seems to occur because the rpc_clnt connections are binding to ports in
the same range. so brick fails to bind to a port which is already used by
someone else
solution:
fix for now is to make rpc_clnt to get port numbers from 65535 in a descending
order, as a result port clash is minimized
other fixes:
previously rdma binds to port >= 1024 if it cannot find a free port < 1024,
even when bind insecure was turned off(ref to commit '0e3fd04e'), this patch
add's a check for bind-insecure in gf_rdma_client_bind function
This patch also re-enable bind-insecure and allow insecure by default which was
reverted (ref: commit cef1720) previously
Change-Id: Ia1cfa93c5454e2ae0ff57813689b75de282ebd07
BUG: 1238661
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/11512
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 7bf49048f153242d64055c74c299e83360552c8f
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Fri Jul 24 11:33:57 2015 +0530
Adding README for gluster documentation project
Change-Id: I1bcfc14ee3eabeb26a5cea42533c8df5b040f549
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/11753
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 98cda241c662979f99e9a1d660fa59e78b90c612
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Jul 25 10:28:11 2015 +0200
logging: client3_3_removexattr_cbk should not log expected ENODATA
Commit 379dbbfd changed the log level of an expected error message from
GF_LOG_DEBUG to '0'. This causes the message to always get logged. It is
intended to log the warning when the xattr could not be removed (but
exists), removing a non-existing xattr is sufficient as debug.
BUG: 1246736
Change-Id: If11d15d699e8152cc32e0c0c1d65b587c5c48892
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11759
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joe Julian <me@joejulian.name>
Tested-by: Joe Julian <me@joejulian.name>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit f2d473525d8fe9d137a00c9a6c6e94e2a4d8b29d
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jul 12 12:29:12 2015 +0200
dict: dict_set_bin() should never free the pointer on error
dict_set_bin() is handling the pointer that it passed inconsistently.
Depending on the errors that can occur, the pointer passed to the dict
can be free'd, but there is no guarantee.
It is cleaner to have the caller free the pointer that allocated it and
dict_set_bin() returned an error. When dict_set_bin() returned success,
the given pointer will be free'd when dict_unref() calls data_destroy().
Many callers of dict_set_bin() already take care of free'ing the pointer
on error. The ones that did not, are corrected with this change too.
Change-Id: I39a4f7ebc0cae6d403baba99307d7ce408f25966
BUG: 1242280
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11638
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 22a95c34be65b2a4ad5e6d264a50c7bb824582bf
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Jul 18 12:55:39 2015 +0200
dict: merge static/non-static dict_set_* variations
Copy/pasting complete functions for setting one boolean is rather ugly,
this can easily be solved with a helper function that gets the boolean
as an extra parameter.
Also removing dict_set_dynmstr() because there are no callers, and using
GF_MALLOC() or GF_CALLOC() to allocate memory for strings is much more
preferred.
And, as Kaleb pointed out, prefixing functions with an underscore '_' is
reserved for libc internals. Renaming the _dict_*() functions for that
reason.
Change-Id: I8e681954502f17e59c8f5e8a294d3db238d3e5f3
BUG: 1232304
Reported-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11716
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a444f1e835495bafd7f8e93bfadcdfb194d2d5a1
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jul 19 19:26:02 2015 +0200
gfapi: remove unused variables in priv_glfs_process_upcall_event()
Compiling on NetBSD shows these trivial warnings:
api/src/glfs-fops.c: In function 'priv_glfs_process_upcall_event':
api/src/glfs-fops.c:3873:29: warning: unused variable 'object'
api/src/glfs-fops.c:3869:28: warning: unused variable 'gfid'
BUG: 1202274
Change-Id: If0101c64da2333b05958838f58761534ef341d62
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11717
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 52c6377049d6cad8617d10f50e3db8930b194a8d
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jul 16 14:52:36 2015 +0530
rpc,server,glusterd: Init transport list for accepted transport
GlusterD or a brick would crash when encrypted transport was enabled and
an unencrypted client tried to connect to them. The crash occured when
GlusterD/server tried to remove the transport from their xprt_list due
to a DISCONNECT event. But as the client transport's list head wasn't
inited, the process would crash when list_del was performed.
Initing the client transports list head during acceptence, prevents this
crash.
Also, an extra check has been added to the GlusterD and Server
notification handlers for client DISCONNECT events. The handlers will
now first check if the client transport is a member of any list.
GlusterD and Server DISCONNECT event handlers could be called without
the ACCEPT handler, which adds the transport to the list, being called.
This situation also occurs when an unencrypted client tries to establish
a connection with an encrypted server.
Change-Id: Icc24a08d60e978aaa1d3322e0cbed680dcbda2b4
BUG: 1243774
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/11692
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit abfa6f16a1e322819b6c502ddb8125a1c02a554d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 15 06:16:54 2015 +0530
cluster/ec: Handle race between unlock-timer, new lock
Problem:
New lock could come at the time timer is on the way to unlock. This was leading
to crash in timer thread because thread executing new lock can free up the
timer_link->fop and then timer thread will try to access structures already
freed.
Fix:
If the timer event is fired, set lock->release to true and wait for unlock to
complete.
Thanks to Xavi and Bhaskar for helping in confirming that this race is the RC.
Thanks to Kritika for pointing out and explaining how Avati's patch can be used
to fix this bug.
Change-Id: I45fa5470bbc1f03b5f3d133e26d1e0ab24303378
BUG: 1243187
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11670
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit f85fabe2038b2a84e3e637949bd40836909d3e7f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jul 17 16:04:01 2015 +0530
dht: send lookup even for fd based operations during rebalance
Problem:
dht_rebalance_inprogress_task() was not sending lookups to the
destination subvolume for a file undergoing writes during rebalance. Due to
this, afr was not able to populate the read_subvol and failed the write
with EIO.
Fix:
Send lookup for fd based operations as well.
Thanks to Raghavendra G for helping with the RCA.
Change-Id: I638c203abfaa45b29aa5902ffd76e692a8212a19
BUG: 1244165
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/11713
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit d63f17e346446f538da9f889f22f179b7d0e390b
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Apr 13 17:05:44 2015 +0530
libglusterfs: Even anonymous fds must have fd->flags set
We do not set the same flags to anonymous fd that posix uses to open
an anonymous fd in the backend. If there are any xlators which rely on
these flags for their operation they may not work well.
Add proper flags to anonymous fds at the time of their creation and
refer to them for subsequent operations.
Change-Id: Ia99b7ea7d38839f099c7b4aae3c7ead123bc8c67
BUG: 1211221
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/10219
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5e19d01f56c479e2f239cb62e36f4de068ca7ea4
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Jul 7 18:37:42 2015 +0530
quota : validating soft limit percentage.
Change-Id: I14c049c84c468b6415a1de45441b2fed94e8ed4b
BUG: 1240654
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/11566
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ce7e91f273129d975689bc359ffed6693f240334
Author: vmallika <vmallika@redhat.com>
Date: Fri Jul 17 12:50:59 2015 +0530
quota/marker: contribution with list_del can cause mem corruption
There is a possibility that contribution is removed twice from list
during unlink operation (with hard links) or during rename operation
Use list_del_init for a thread safe deltion of member from list
Change-Id: Iff5e0c03cc8f0ed85da0db1739b84b695abf9ea6
BUG: 1244109
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11706
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 6ffcc14f06bac0d7c11f501084cbcb71bae9cb9d
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Jul 16 16:46:23 2015 +0530
nfs: log disabled export/netgroups feature as INFO
If export/netgroups feature is disabled for gluster/nfs, then the "nfs.log"
contains a Warning message which is deceiving for the users. Logging the
message as Info is sufficient.
Change-Id: I3d07e8bc4f09f3eb32014f5a10390d0484b838cf
BUG: 1243805
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/11695
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0d91b175c18be1f1b01a3fa678ced9230775a244
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Jun 25 02:18:42 2015 +0530
storage/posix: Check xdata for NULL before dict_get
Performing a dict_get on xdata can lead to
frequent logging if xdata is NULL.
Change-Id: I1666f0cc958c639ccd816e3738dd4a1efebbff82
BUG: 1235921
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/11390
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 1dfb0267836fff19f8686b3549c260ca5de58d21
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Thu Jul 9 11:37:16 2015 +0530
glusterd: Porting the left out gf_log_callingfns to new framework
Change-Id: I1b0ad54238895475ddbacc4fffacac8dc6e887fe
BUG: 1235538
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/11590
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 314ba6eb8d845d84df47e8495a9f8385daf93bc0
Author: Shyam <srangana@redhat.com>
Date: Fri May 22 14:40:50 2015 -0400
doc: Add documentation for new logging framework
This commit adds a guideline document for using the new message
logging infrastructure.
Change-Id: Iddc6a2b6f244cc5b51dab4c99d963e89b1a9f478
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/10896
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anusha B.Rao <anusha91rao@gmail.com>
Tested-by: Anusha B.Rao <anusha91rao@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 05f04a965e05d77ea84b7ebd1ad1b0dc6765099e
Author: arao <arao@redhat.com>
Date: Thu Feb 12 10:22:42 2015 +0530
features/marker: Fixing dereference after null check
CID: 1124494
The variable was sent as a parameter to the function without the null check,
hence added a check on null and error log accordingly.
Change-Id: I11a649fc9a1bedad17422aeddb8dd8fa225d404e
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9641
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 4011f7861f80aab8bdb4498630453b4fde95a567
Author: anand <anekkunt@redhat.com>
Date: Sat Jun 13 16:46:10 2015 +0530
glusterd: rebalance support for cluster.rc framework
Issue:Rebalance is failing in cluster framework (any simulated cluster environment in same node ).
RCA:
1. we are passing always "localhost" as volfile server for rebalance xlator .
2. Rebalance daemons are overwriting unix socket and log files each other.
(All rebalance processes are creating socket with same name) .
Fix: set vol_file_server, unix socket and log files properly.
Change-Id: I6654461e00c2a164b2f1f1db24a316c4180dd8d5
BUG: 1231437
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/11210
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 28a9ad7d6bb0d980f1ee65566485ee67c1a75960
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Jul 16 13:56:51 2015 +0530
cli: Create missing logbuf_pool
Since logbuf_pool was not created via glusterfs_ctx_defaults_init(),
the following error was present in cli logs repeateadly for each
and every execution of a gluster command.
E [mem-pool.c:417:mem_get0] (-->/usr/local/lib/libglusterfs.so.0(+0x7e262)
[0x7fdbc0b1f262] -->/usr/local/lib/libglusterfs.so.0(_gf_msg+0x804)
[0x7fdbc0ac7844] -->/usr/local/lib/libglusterfs.so.0(mem_get0+0x78)
[0x7fdbc0af5b48] ) 0-mem-pool: invalid argument [Invalid argument]
This change creates ctx->logbuf_pool via glusterfs_ctx_defaults_init()
in cli.c so that the above error is no longer logged in cli logs.
Change-Id: I3fcd9cfefa06ddd52e1989b039ff5637372c3235
BUG: 1243753
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/11691
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 7c587a94017ce0779f4d5f3700cd9f7b9bb17a27
Author: vmallika <vmallika@redhat.com>
Date: Thu Jul 16 19:24:00 2015 +0530
posix: fix mem-leak in posix xattrop
Change-Id: I1dd70f74a98c5875eb316f3c3e560047f128685b
BUG: 1243890
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11700
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 8db9143ff28146c74d84b30f64e5d67b71e27e9d
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sat Jul 11 09:21:27 2015 +0530
glusterd: use 2 epoll worker threads by default
The no. of epoll worker threads can be configured
by adding the following option into glusterd.vol.
option event-threads <NUM-OF-EPOLL_WORKERS>
BUG: 1242421
Change-Id: I2a9e2d81c64beaf54872081f9ce45355cf4dfca7
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/11630
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a44523b330d9f5c07008cd2dd34bd9096124bb1c
Author: vmallika <vmallika@redhat.com>
Date: Wed Jul 15 15:17:31 2015 +0530
quota: fix quota test case
Below command is wrong way of executing
mutilple command with | (pipe)
local cmd="$CLI volume quota $V0 list $QUOTA_PATH | grep $QUOTA_PATH |
awk '{print \$$FIELD}'"
$cmd
This patch fixes the issue
This patch also fixes testcase inode-quota.t, which checking
quota values in wrongs fields
Change-Id: If28732e6a76ea4bf75560f6496c8f56670915cf9
BUG: 1229297
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11673
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit eef44665c60df6d98decfbe76e95e050ece550ea
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jul 14 16:16:00 2015 +0530
protocol/server: use different dict for resolving
protocol/server has to resolve the inode before continuing with any fop coming
from the clients. For resolving it, server xlator was using the same dict
associated with the fop. It causes problems in some situations.
If a directory's inode was forgotten because of lru limit being exceeded, then
when a create fop comes for an entry within that directory, server tries to
resolve it. But since the parent directory's inode is not found in the inode
table, it tries to do a hard resolve by doing a lookup on the parent gfid.
If any xlator below server wants to get some extended attributes whenever
lookup comes, then they set the new keys in the same dict that came along with
the create fop. Now, the lookup of the parent succeeds and the create fop
proceeds with the same dict (with extra keys present). posix xlaror creates
those xattrs that are present in the dict. Thus the xattrs which were not to
be present by default are also set as part of create. (Ex: bit-rot related
xattrs such as bad-file, version and sign xattrs)
Change-Id: I4bdad175a1d7a04a3aa36073667c556d6c260263
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11661
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 7d07c4776efd2d354fa38d87679b0a821bdea453
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jun 16 17:59:23 2015 +0530
features/shard: Use xattrop (as opposed to setxattr) for updates to size xattr
Change-Id: Icd8984976812bb47ae7129426f6c1aa9393b3ab9
BUG: 1232391
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11467
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 4b91f56bf55f51b1df03fdec57c2e0e831f89f5d
Author: Anuradha Talur <atalur@redhat.com>
Date: Tue Jul 7 19:10:26 2015 +0530
doc: remove deprecated replace-brick commands from gluster man page
Change-Id: Ibdd42bf4b59fe8a9df5bad68fbc498b4496c5e53
BUG: 1206539
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/11567
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 271d59d63683a45e0b9d6145d77feb00f554ce1d
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Sun May 17 00:26:06 2015 +0530
features/changelog: fix buffer overrun in changelog-helpers
changelog-helpers.c:1911:17: warning: Size argument is greater than the free
space in the destination buffer strncat (result, pre_dir_name, PATH_MAX);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
changelog-helpers.c:1919:17: warning: Size argument is greater than the free
space in the destination buffer strncat (result, bname, PATH_MAX);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Change-Id: I60ca7fe762f07cb72fe7b69f0253835becaff7b9
BUG: 1222238
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/10802
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 07c63078302d0e54d38352295544706c4623ef7f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Jul 12 18:37:43 2015 +0530
cluster/ec: Propogate correct errno in case of failures
- Also remove internal-fop setting in create/mknod etc xattrs.
Rebalance was failing because ec was giving EIO when lock acquiring fails as
the file/dir doesn't exist. Posix_create/mknod are not setting config xattr
because internal-fop key is present in dict and setxattr for this fails leading
to failure in setting rest of xattrs.
Change-Id: Ifb429c8db9df7cd51e4f8ce53fdf1e1b975c9993
BUG: 1242254
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11639
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 0cdc51f681a0e4d2549805ea8cffaa73d5a19e18
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Tue Jul 14 14:01:14 2015 +0530
glusterd: Pass NULL in glusterd_svc_manager in glusterd_restart_bricks
On restarting glusterd quota daemon is not started when more than one
volumes are configured and quota is enabled only on 2nd volume.
This is because of while restarting glusterd it will restart all the bricks.
During brick restart it will start respective daemon by passing volinfo of
first volume. Passing volinfo to glusterd_svc_manager will imply daemon
managers will take action based on the same volume's configuration which
is incorrect for per node daemons.
Fix is to pass volinfo NULL while restarting bricks.
Change-Id: I2602002a8ba7762fc1eb08123e79fbcf568ecab4
BUG: 1242875
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/11658
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 357be153e35deb53eb9c10cce789648426336226
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jul 6 11:49:31 2015 +0530
glusterd: daemons start/stop should be logged in INFO
Change-Id: I81ceba4b7110140aec790659fcac90403c8e3869
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11538
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit fe1f430818cafcd59b3131199734f4bb1f62667b
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Tue May 19 17:24:45 2015 +0530
geo-replication: fix memory leak in gsyncd
1. leak in str2argv() function:
char *strdup(const char *s);
The strdup() function returns a pointer to a new string which is a
duplicate of the string s. Memory for the new string is obtained
with malloc(3), and can be freed with free(3).
so when using strdup, user has to take care of freeing the memory
allocated by strdup library function.
2. leak in main() function:
str2argv() function calls calloc and allocates memory pointed to argv,
after return from str2argv() memory pointed to argv has to be cleaned
in main().
This patch is to fix 2 memory leaks mentioned above.
Change-Id: I6bf26101e0460a7324ac7bdb69905839688d4987
BUG: 1222898
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/10831
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit b719c9ef0882c36771edfccf6c82791ef6108ca1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 1 14:25:07 2015 +0530
cluster/ec: wind readlink on good subvol(s)
BUG: 1232172
Change-Id: I3a56e487840d86147dd85bf5fbe79b165eae289f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11589
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4b69ea1e1f3ce2e257ffd5b64fee614e97bd7354
Author: vmallika <vmallika@redhat.com>
Date: Tue Jul 7 16:56:12 2015 +0530
quota: Fix crash in quota enforcer
With multiple hardlinks check_quota_limit is invoked for each parent
each of this check_limit can invoke validation
this can cause frame->local to get corrupted during validation.
Testcase tests/bugs/quota/bug-1235182.t fails spuriously with
this problem
Change-Id: I53adc54b431fb5f43e67a94248102ddaf0d7978f
BUG: 1238747
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11510
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ac3e5f68a843ae5cc561ce2c6a928c061da7be27
Author: vmallika <vmallika@redhat.com>
Date: Sun Jul 12 21:03:54 2015 +0530
quota/marker: fix mem-leak in marker
Free local in error paths
Change-Id: I76f69e7d746af8eedea34354ff5a6bf50234e50e
BUG: 1207735
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11617
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit d19126132eb4d669f01f61082c3f1acdd0874808
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Jul 13 11:59:33 2015 +0530
features/bitrot: throttle signer
Pass -DDBR_RATE_LIMIT_SIGNER CFLAGS to enable fixed value throttling
based on TBF to rate limit signer. The following messags is dumped
in bitd log file that this change introduces.
[
[Rate Limit Info] "tokens/sec (rate): 131072, maxlimit: 524288"
]
Bug: 1242809
Change-Id: I063e41d4c7bcddd7a940cc175e89536cd4fe2804
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11641
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit e97def73c44f5c15ca82f6cc048b4ef2ddb88104
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 13 00:53:20 2015 +0530
cluster/ec: Prevent data corruptions
- On lock reuse preserve 'healing' bits
- Don't set ctx->size outside locks in healing code
- Allow xattrop internal fops also on the fop->mask.
Change-Id: I6b76da5d7ebe367d8f3552cbf9fd18e556f2a171
BUG: 1232678
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11640
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit dc454573638434f896c4ecf37bdc01bda1a8b0ab
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Jul 8 12:42:50 2015 +0530
ec : Implement check for the cluster.heal-timeout values for disperse volume.
Problem : User can set wrong values for cluster.heal-timeout
using cli. Any value like string, negative numbers
or 0 could be set.
Solution : Check the value given by user. It should be numerical,
non negative and within the range.
Change-Id: I5184ef1a11bb2c225f42ac9ccb1ba680a86cfe09
BUG: 1239037
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/11573
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit c9ea2cb2c025833f72eb65e6f162e55337515cff
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jul 13 16:16:00 2015 +0530
rpc-transport: socket_poller fixes for proper working of mgmt encryption
socket_poller, the polling function used by ssl own_thread, had two
issues which lead to GlusterD crashes when using management encryption
Issue 1
-------
socket_poller calls functions which require THIS to be set. But, THIS
was being set conditionally. Because of this, functions could sometimes
be called without THIS being set. For example, rpc_transport_notify
could be called for an accepted client socket without THIS being set, as
THIS was only set it the transport wasn't yet connected. This would
cause the process to crash when THIS was accessed by the called
functions.
To fix this, THIS is being set at the start of socket_poller
unconditionally.
Issue 2
-------
DISCONNECT notify was being sent on the listener transport instead of
the client transport. The DISCONNECT event was converted to a
LISTENER_DEAD event in rpcsvc_handle_disconnect, as it could not find
the listener socket of the listener socket. GlusterD was notified of a
LISTENER_DEAD event instead of a DISCONNECT and failed to remove the
client transport from its xprt_list. The transport would subsequently
be freed, leaving the xprt_list with a corrupted/invalid entry. Later,
when GlusterD would iterate over the xprt_list to send notifications, it
would crash when the invalid entry was accessed.
To fix this, DISCONNECT notification in socket_poller is sent on the
client socket, as it is done in the epoll handler.
Change-Id: I0370b7c6d7eb13de10ebf08d91a4a39dc7d64c7a
BUG: 1242570
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/11650
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 1c2543dcb3231f7b1ef76ef685e98dafae68cb58
Author: Anuradha Talur <atalur@redhat.com>
Date: Mon Jul 13 23:34:17 2015 +0530
glusterd: Fix failure in replace-brick when src-brick is offline
Change-Id: I0fdb58e15da15c40c3fc9767f2fe4df0ea9d2350
BUG: 1242609
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/11651
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 0b282dd5d5cc842b48f4393268cfecd549225384
Author: Pamela Ousley <pousley@redhat.com>
Date: Wed Jun 17 15:07:55 2015 -0400
cluster/tier : fix for logical bugs/timing errors in tier.t
The md5sum fingerprints were not correctly compared after moving
files between the hot and cold tiers.
This version of tier.t uses a new function, "check_counters", to
ensure that the number of promotions/demotions is as expected.
This is intended to avoid spurious timing-related errors that were
seen with the old script.
Change-Id: I4a0ae7315493bfd307a0f68f21fa3ea33c88b08f
BUG: 1231268
Signed-off-by: Pamela Ousley <pousley@redhat.com>
Reviewed-on: http://review.gluster.org/11285
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit d74933ae1b0970dd089fc5fdc223d06ed773b7a7
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sat Jul 11 12:27:02 2015 +0530
rpcsvc: add request's address in log
This helps in identifying the remote endpoint whose request arrived at
an non-privileged port.
Change-Id: Ie58155e00229cfcbd0ca5221d79e2e90efb3e2b3
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/11631
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 55fb53c06b3d5bf7be82b5c9be92bd409db4b847
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri Jun 26 16:33:49 2015 -0400
cluster/tier: fixes for migration over ec as cold tier
An opendir is done in rebalance. The graph constructed when
EC is used in tiering may have no local volumes (if
all the hot volumes are on one node and all the others on
another node). Previously the opendir only sent fops down
the local subvolumes for migration. They must be sent down
both the hot and cold subvolumes for tiering.
When setxattr2() received a NULL subvolume; this dereferenced
an uninitialized variable.
When a lookup is done during creation of the destination
file, the xattr dict is "polluted" with virtual xattrs.
These cause subsequent xattrs in the new file to not be
written by posix. They are required by EC.
The inode gfid for "entry_loc" in gf_defrag_migrate_single_file()
was not initialized. This made underlying translators
think the gfid was 0, and failed migration.
Change-Id: I6ccda8ca8e43485b9b354341bbfcb302496f632c
BUG: 1236212
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/11433
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 658600d89ca3ad6fe1f3ae0f87180c8f1c298acb
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed Jul 1 17:55:47 2015 +0530
extra: "enable-shared-storage" key should create shared-storage
Currently while creating shared storage it accept only
"cluster.enable-shared-storage" key. It should also
accept "enable-shared-storage" key.
Change-Id: I4c68782f4b7927ec8cd725e411b0b9db17d9c48d
BUG: 1238224
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/11491
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
commit cf0a8540f61a644f33a4091ab97de34173e4991a
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jun 30 13:10:46 2015 +0530
features/bitrot: move inode state just at the last moment
Which was done at half the set expiry time resulting in actual
IOs incrementing the object version. Now this is done just at
the last moment with re-notification now cut-shorting into
checksum calculation without waiting in the timer-wheel.
BUG: 1242317
Change-Id: If655b77d822ebf7b2a4f65e1b5583dd3609306e7
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11461
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 411af9f3be02ed83db9dc20405211b286d0c6c30
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Fri Jul 10 10:50:40 2015 +0530
rdma : porting missing gf_log to gf_msg
Change-Id: I036b43007fbcd0e528faab8d44e1a7fc820eaf1f
BUG: 1242333
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/11607
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit abc0308aa22cd15a72751560bcf979e61ccf87d1
Author: arao <arao@redhat.com>
Date: Mon Feb 16 16:59:48 2015 +0530
glusterd: Fixing dereference after null check
CID: 1124557
Checking for the pointer itself before dereferencing
it to check for the variable's value it is pointed to.
Change-Id: Idcbb034e4c6d58501697e01e90647b6233a5e5ba
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9661
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit b6cb1eb3e38a9b30f42a08befcdc42625528d3f4
Author: vmallika <vmallika@redhat.com>
Date: Fri Jul 10 14:37:50 2015 +0530
features/quota : Fix spurious failure
Problem : Basically, in this test case a file is created
which exceeds the quota limit. Once the limit is reached
that file will be deleted. At the same moment we are
testing inode-quota. It can so happen that before the
marker updates the information related to deletion of
file, a new file creation operation comes and sees that
quota limit is still exceeded.
Solution : Inducing a check to see if marker updation
completed successfully.
Updated all the test case which has the similar
machanism and also moved the "usage" function
to a common place "volume.rc"
Change-Id: I36ddbc5ebbf1b74c9d326a0d1d5f3b32f20a906a
BUG: 1229297
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11125
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit f0c6d021b820a79d242d10c17f3c8ced583e2c27
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jun 30 11:22:31 2015 +0530
ctr:Avoid assertion failure in lookup
in ctr_lookup, the loc variable need not be comes with pargfid,
though there is a parent for the inode. The same for loc->name
also. From this patch, we will generate loc->name from loc->path
Change-Id: I24a79554748139504ec09f77930f8208d3805977
BUG: 1236128
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11459
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
commit 4880e919637e5f3127b9deee184d0fe1c1912a55
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Tue Jun 16 18:16:18 2015 +0530
libglusterfs: delete duplicate code
This patch saves cpu cyles by deleting duplicated code in most frequently
used functions 'dict_set_static_bin' & 'dict_set_bin' which is already
repeated/executed in function 'bin_to_data'
Change-Id: I8e18b3f2b321e06bb6bd5a67e1782cb159182dd2
BUG: 1232304
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/11255
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a7d58f6f19a5362e329239a62d986522698a76ca
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Fri Jul 10 23:12:28 2015 +0530
features/posix : Avoid double free of a variable in posix_setxattr()
The buffer acl_xattr is introduced in posix_setxattr() as part of
http://review.gluster.org/#/c/11519/. This variable can be freed
twice in the code path , one in dict_unref() and another by explicit
GF_FREE() call in the code. This patch avoids the same.
Change-Id: I31c6384e37ab8d8baaed7a53de668c2eb5d82338
BUG: 1242030
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/11627
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1965d2ff45063e50b280b7777df8373e9f6965a2
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Tue Jun 9 15:25:20 2015 +0530
build: fix gitclean target
$ make gitclean # deleting unexpected 'Makefile' files
...
$ git status
...
deleted: extras/FreeBSD/Makefile
deleted: extras/command-completion/Makefile
deleted: extras/test/ld-preload-test/Makefile
...
This change fix to ignore above built-in makefiles while executing
'gitclean' target
Change-Id: I5365f5a1fe5b36141a6fe7ba27c38a2158f9f3a3
BUG: 1229639
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/11136
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 861f340fd9929e50de70aef527eb8a5e40fbac04
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Sat Jul 11 15:47:18 2015 +0530
access_control : avoid double unrefing of acl variable in its context.
In handling_other_acl_related_xattr(), acl variable is unrefered twice
after updating the context of access_control translator.So the acl variable
stored in the inmemory context will become invalid one. When the variable
accessed again , it will result in brick crash. This patch fixes the same.
Change-Id: Ib95d2e3d67b0fb20d201244a206379d6261aeb23
BUG: 1242041
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/11632
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit f911083505a72587183cf42f4a7329a380c420ac
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Fri Jul 3 15:12:23 2015 +0530
logging: Fixed incorrect buffer size
An incorrect buffer size passed in to_gf_msg_backtrace
prevented the callers from being logged.
Change-Id: I86104d6b3f611455308d5b3420dfb6d456070a23
BUG: 1238952
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/11521
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 88e11802dabb638f9ecead3363b4c48172470949
Author: vmallika <vmallika@redhat.com>
Date: Fri Jul 10 16:04:16 2015 +0530
quota/marker: inspect file/dir invoked without having quota xattrs requested
In a lookup and build ancestry quota xattrs are
not requested, it gives wrong assumption that
quota xattrs are missing and tries to do
healing process
Change-Id: I7135101ec0edc72a6310dbb304227eaa3b16cb46
BUG: 1207735
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11616
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 4dd3020b3f06eaa0e76ea145efe13431199ead11
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Jul 10 14:50:29 2015 +0530
glusterd: Send friend update even for EVENT_RCVD_ACC
In a multi-network cluster, a new peer being probed into the cluster
will not get all the addresses of the peer that initiated the probe in
some cases as it doesn't recieve friend updates from other peers in the
cluster.
This happens when the new peer establishes connection with the other
peers before the other peers connect to the new peer.
Assuming, F is the initiator peer, O is one of the other peers in the
cluster and N is the new peer, the following series of events occur on O
when N establishes the connection first. N is already in the BEFRIENDED
state on O, and the actions happening will refer the BEFRIENDED state
table.
EVENT_RCV_FRIEND_REQ -> results in handle_friend_add_req being called
which injects a LOCAL_ACC
EVENT_RCVC_LOCAL_ACC -> results in send_friend_update being called
which should have sent an update to N, but O
has still not established a connection to N,
so the update isn't sent
EVENT_CONNECTED -> O now connects to N, this results in O sending a
friend_add req to N
EVENT_RCVD_ACC -> friend_add_cbk inject this event, but this event
results in a NOOP when in BEFRIENDED
As a result this O doesn't recieve all the addresses of F. If the
cluster contains any volumes with bricks attached to the missing
addresses of F and O is restarted in this condition, GlusterD will fail
to start as it wouldn't be able to resolve those bricks.
This commit changes the EVENT_RCVD_ACC action for the BEFRIENDED state
from a NOOP to send_friend_update. This makes sure that the new peer
recieves the updates from the other existing peers, irrespective of who
establishes the connection first, thus solving the problem.
Change-Id: Id807bc3032cf4cb13a5ba83819f2d50c96e76e96
BUG: 1241882
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/11625
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit f0e5a3226453ecbefc93deddc267df88111b3ca4
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Jul 10 11:23:07 2015 +0530
syncop: Include iatt to 'syncop_link' args
Include iatt to 'syncop_link' args to fetch proper attributes of
the newly linked inode.
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Change-Id: If6b92961bd7a89add3791ed3a9b494087348b492
BUG: 1241788
Reviewed-on: http://review.gluster.org/11611
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit eef3a4c003c23d6e64d9e8633786eed003969999
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jul 10 15:41:18 2015 +0200
gfapi: correct symbol versioning in glfs-handles.h
Some of the symbol versions exposed to Mac OS X systems are incorrect.
glfs_h_lookupat() has been exported multiple times, for different
versions. Seems to be a simple copy/paste error, but we have not spotted
that during review :-/
The only applications that could be affected by this correcting change,
would need to have linked against the highest versions of
glfs_h_lookupat(). Because Mac OS X is not a mainstream client-side
environment, we do not need to take special precautions for it.
BUG: 1202274
Change-Id: I9ee909ce0f205faa9f110be2101fc6feae20df41
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11623
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a7dc3d5b2e02746caedb1ca721a91af15d257b61
Author: Joseph Fernandes <josferna@redhat.com>
Date: Wed Jul 8 14:35:45 2015 +0530
libgfdb/sql: Fixing broken query of find_unchanged
The find_unchanged query should be
"write_heat <= defined_heat" AND "read_heat <= defined_heat"
and not
"write_heat <= defined_heat" OR "read_heat <= defined_heat"
Change-Id: Ie82e02aafbb7ea14563007307de3350ea022049a
BUG: 1240970
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/11577
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Joseph Fernandes
Tested-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a687e9e4775f16b0399a5f5afb97c9bda60d5038
Author: Meghana M <mmadhusu@redhat.com>
Date: Fri Jul 10 04:23:31 2015 +0530
NFS-Ganesha : Add-node does not copy "exports" directory correctly
Add-node logic has to copy the "exports" directory into the
new node in the same path. There was an error in copying to the correct
path. Fixing it.
Change-Id: I539d1d525cc5614594b76f2cff1ac93a926712cf
BUG: 1241895
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11618
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit a1ef68d2043a9dd83f8d58a0e2002eaa45c724c9
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Jul 8 09:52:15 2015 -0400
glusterd: use a real host name (instead of numeric) when we have one
Change-Id: Ie9cc201204d3d613e3e585cab066a07283db902c
BUG: 1241274
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/11587
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e9eb666f23e38577edea9fa319d711d05f4b3997
Author: Meghana M <mmadhusu@redhat.com>
Date: Thu Jul 9 03:34:07 2015 +0530
NFS-Ganesha : Export fails on RHEL 7.1
We grep for CONFFILE parameter in "/etc/syconfig/ganesha"
file to find out the path of the ganesha config file.
In RHEL 7.1, this parameter does not exist in the file and
we can't find out the ganesha config file. Export
fails invariably due to this. Changing this pattern to
a more generic one and default it to "/etc/ganesha/ganesha.conf"
Change-Id: I4ac97b1b5ee4f5a7e448a351b7c6270385dffe61
BUG: 1241480
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11594
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit cae0e7337b1ef9be473a237891e79a806216ab04
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Jul 6 14:47:58 2015 +0530
features/bitrot: Scrub log improvement
Change-Id: I4937a578185ebacd2558cb8e22f130cd10193188
BUG: 1240219
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11547
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 54a0da430378c2a003e5bc0f4d28164baa0cc6c2
Author: vmallika <vmallika@redhat.com>
Date: Wed Jul 8 22:22:50 2015 +0530
quota/marker: fix spurious failure afr-quota-xattr-mdata-heal.t
During quota-update process if inode info is present in size-xattr and
missing in contri-xattrs, then in function '_mq_get_metadata', we set
contri-size as zero (on error -2, which means usage info present, but inode info missing).
With this we are calculating wrong delta and updating the same.
With this patch we are ignoring errors if inode info in xattrs are missing
Change-Id: I7940a0e299b8bb425b5b43746b1f13f775c7fb92
BUG: 1241153
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11583
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit ba0d65ee93e69b198f89a79fe01be6e1e68dd6a8
Author: vmallika <vmallika@redhat.com>
Date: Thu Jul 2 12:22:49 2015 +0530
quota/marker: use smaller stacksize in synctask for marker updation
Default stacksize that synctask uses is 2M.
For marker we set it to 16k
Also move market xlator close to io-threads
to have smaller stack
Change-Id: I8730132a6365cc9e242a3564a1e615d94ef2c651
BUG: 1207735
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11499
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 0fd78d8c8facac3f50d641c16f9dc8471ba7d8c7
Author: vmallika <vmallika@redhat.com>
Date: Mon Jun 29 19:12:28 2015 +0530
quota/marker: fix mem leak in marker
Problem-1)
Now the marker accounting happens in background,
There is a possibility that before completing
create_xattr_txn another create txn can be initiated
for the same inode.
suppose if few 100 txns are initiated
before completion, this can block all synctask threads
waiting on a lock and this can also consume lot of memory
and can take more time to complete the background accounting
operation.
This patch improves the locking mechanism which
can improve the performance as well reduce memory
consumption
Problem-2)
For every lookup and for all inodes in readdirp
we were initiating a new txn, this can result
in more txn pending in synctask queue and
lead to huge memory consumption. inspect
file/dir should start a txn only if there
is some delta
Problem-3)
When there are multiple write operations on
same inode and all the synctask threads are busy.
As we are checking for updation_status
flag in background, all txn will be move to synctask queue.
This can increase the mem usage.
Only one txn for inode in a queue will be sufficient,
so check and set updation falg before moving txn to
background
Change-Id: Ic42ce00f0a50ce51c7128ba68a1b6a0699a1cd14
BUG: 1207735
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11457
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 2d7583bf35c333935b0a666d99129876fbda5ac2
Author: vmallika <vmallika@redhat.com>
Date: Tue Jul 7 16:03:26 2015 +0530
quota/marker: set lk_owner when taking lock on parent in rename
Before doing a rename operation marker takes inode lock on the file
parent,
here lk_owner is NULL and this can cause accounting problem with
multiple rename on the same directory
This patch fix the problem by setting lk_owner
Change-Id: Ibb789e39b2833e425d0a5fca85282ff1465206cb
BUG: 1240598
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11561
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 934d555d842a057fc65a4d01355a52b621fa0d73
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 7 12:52:30 2015 +0530
glusterd: Fix management encryption issues with GlusterD
Management encryption was enabled incorrectly in GlusterD leading to
issues of cluster deadlocks. This has been fixed with this commit. The
fix is in two parts,
1. Correctly enable encrytion for the TCP listener in GlusterD and
re-enable own-threads for encrypted connections.
Without this, GlusterD could try to esatblish the blocking SSL
connects in the epoll thread, for eg. when handling friend updates,
which could lead to cluster deadlocks.
2. Explicitly enable encryption for outgoing peer connections.
Without enabling encryption explicitly for outgoing connections was
causing SSL socket events to be handled in the epoll thread. Some
events, like disconnects during peer detach, could lead to connection
attempts to happen in the epoll thread, leading to deadlocks again.
Change-Id: I438c2b43f7b1965c0e04d95c000144118d36272c
BUG: 1240564
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/11559
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 2b4b253cd655d4ec732bd80772a0243fff335c55
Author: Anoop C S <anoopcs@redhat.com>
Date: Thu Jul 9 11:06:01 2015 +0530
features/ctr: Reduce the log-level for ctr-disabled message
Since by default CTR translator is disabled, the following
log message is being displayed in brick logs.
[ctr-helper.c:256:extract_ctr_options] 0-gfdbdatastore: CTR Xlator is disabled.
Therefore this change is to reduce the log-level to INFO.
Change-Id: I3b82d6b0dc0445286f91490fb497167a36914a2b
BUG: 1241379
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/11592
Reviewed-by: Joseph Fernandes
Tested-by: Joseph Fernandes
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 7f51e79ea5243a54f1628ce1b25b621364f6fd8d
Author: Joseph Fernandes <josferna@redhat.com>
Date: Wed Jul 8 21:22:53 2015 +0530
libgfdb/ctr: Fixing rename or update of link
Fixing rename or updating of link in
1) libgfdb : handling return from updatelink
2) ctr xlator: correcting freeing of oldbase name in
hardlink list in the update link
Change-Id: I1789c492b81876123cd456051a9ae495e876ad46
BUG: 1241054
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/11584
Tested-by: Joseph Fernandes
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5077879efe23b7fb4dcc68ffb7dba555be328e27
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Jul 8 12:08:25 2015 +0530
gfapi: Update loc->inode accordingly in 'glfs_loc_link'
In case if the inode already exits in the cache, inode_link
returns the pointer to the exiting one instead of using loc->inode.
This will result in issues if that invalid inodei(loc->inode) is referenced
further. Fixed the same.
Change-Id: I7d4a06043e4e731c8404532c47d482175dc2c277
BUG: 1240916
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11572
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 8c180d06a24166fad2999574be6c3e1f999abd8e
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Jul 8 10:14:40 2015 -0400
common-ha: ganesha-ha.sh status tries to read ganesha-ha.conf
status doesn't need to read the config
Change-Id: Id02252abe52820dbc263f4a880bde72a23b121bd
BUG: 1241133
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11581
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit a46492774d326354c61e3d2746792f2306c52168
Author: vmallika <vmallika@redhat.com>
Date: Mon Jul 6 16:18:45 2015 +0530
quotad: create sock listener only after graph init is complete
If FOPs are received before completing graph initialization,
FOP path can crash while accessing uninitialized variables
This patch fixes issue by not creating listener until
graph initialization is complete and hence not receiving
FOP request
Change-Id: I4771e376410843dff44bfe819329a4632523d266
BUG: 1240254
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11552
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 06baa424875aafc15d1e82b524f7be01f1c8f896
Author: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Date: Tue Jun 30 14:47:22 2015 +0530
libglusterfs removing strerror in logging
Change-Id: I8a0f40834da1151ddaef6139af3782bc076df57e
BUG: 1194640
Signed-off-by: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Reviewed-on: http://review.gluster.org/11464
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 792f39fbdf24b1f2dc07b830a72a7b0be1d2f55c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Jul 6 12:15:45 2015 +0530
snapview-client: Allocate memory using GF_CALLOC
loc->path memory should allocate through
GF_CALLOC/GF_MALLOC, since it uses GF_FREE
from loc_wipe.
Change-Id: If3030175dfb07b0e0b6c0a30234857f8a0780035
BUG: 1240184
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11543
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2f351353e4800d9e464864462f33a2b0229e5ae9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 8 17:52:11 2015 +0530
cluster/ec: Don't read from bricks that are healing
BUG: 1232678
Change-Id: I35503039e4723cf7f33d6797f0ba90dd0aca130b
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11580
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 537be054c71fbe349be5cf4c5abd9ef26918562a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jul 8 14:18:19 2015 +0530
glusterd/snapd: Stop snapd daemon when glusterd is restarting
Stop snapd daemon when glusterd is coming back, if uss
is disabled, or volume is stopped.
Change-Id: I4313ecaff19de30f3e9ea76881994509402ed5b0
BUG: 1240952
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11575
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit d2ff31c348445ec78805cc8806fda7ffaf253e22
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jul 8 17:11:42 2015 +0530
tests/uss: Wait for process to come up before testing stat
Fix spurious failure where snapd takes a while to come up.
Change-Id: I32931afd4ff78f8d930c70f49b26f08976033d42
BUG: 1241071
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11579
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e6c07f3b9ecce6f0b1f4068c8c1df8deb8299add
Author: Avra Sengupta <asengupt@redhat.com>
Date: Sun Jul 5 12:57:39 2015 +0530
snapshot/scheduler: Use /var/run/gluster/shared_storage/snaps/tmp_file for writing data into tmp file and then making an atomic rename to the required filename.
The reason for using this location is that it adheres to
the selinux policies.
Also moving the update of the current_scheduler file,
under the lock so as to avoid multiple writes
Change-Id: I61e62b5daf6f1bce2319f64f7b1dfb8b93726077
BUG: 1239269
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11535
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit f26ed8a250572cf474cc376cf7ace5e389da488e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jul 2 09:26:44 2015 +0530
cluster/ec: Remove locks in opendir
With readdir[p] taking locks to figure out which bricks are
good/bad, no need to take any locks on opendir.
BUG: 1232172
Change-Id: I4d924aeeaecab23af08c4598548a20d2a44cd849
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11506
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3671e829bc42d14bd5206d512d42710a7c76f762
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 7 12:40:42 2015 +0530
cluster/ec: Fix use after free bug
In ec_lock() there is a chance that ec_resume is called on fop even before
ec_sleep. This can result in refs == 0 for fop leading to use after free in
this function when it calls ec_sleep so do ec_sleep at start and ec_resume at
end of this function.
Change-Id: I879b2667bf71eaa56be1b53b5bdc91b7bb56c650
BUG: 1240284
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11558
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit a65c3c56b15dbb71ede791f414f41db29e3f47f3
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue May 12 16:36:55 2015 +0530
libgfapi: Gracefully exit when glfd is invalid
When glfs_* methods operating on glfd are invoked after calling
glfs_close(), the program segfaults inside __GLFS_ENTRY_VALIDATE_FD
trying to deference glfd->fd->inode which is invalid.
Also, returning EBADF seemed more specific than EINVAL.
BUG: 1221008
Change-Id: I13a92dca52da9a300252b69e026581b3a9e931fd
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/10759
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit f6a194b582f9fe4c622d7dc3507d264dabf106c2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Jul 7 12:15:17 2015 +0530
tests: Fix ./tests/bugs/replicate/bug-1238508-self-heal.t
Test failed @
http://build.gluster.org/job/rackspace-regression-2GB-triggered/12010/consoleFull
(Reported by Vijaykumar M)
Fix:
s/afr_get_pending_heal_count/get_pending_heal_count
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: I69c44919ae68e3ebb9a5bc58a8e45a0a96fad62e
BUG: 1238508
Reviewed-on: http://review.gluster.org/11556
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit a8ca4f90bf03cdeaa14301f16824c916de3202a0
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jul 6 15:05:43 2015 +0530
glusterd/geo-rep: Fix failure of geo-rep pause
Geo-replication pause fails if one or more of the nodes
in the master cluster is not part of master volume.
If the master volume bricks are not part of the node,
it should be ignored. The check is added to fix the issue.
Change-Id: Iba57d66b6db6919f42a95dd66e6db9ad1b21503b
BUG: 1240229
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11549
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 3fc10ea619267ebbadb2c9ed71bb1b334a9eb777
Author: vmallika <vmallika@redhat.com>
Date: Fri Jul 3 17:32:04 2015 +0530
quota: fix mem leak in quota enforcer
Do inode_unref on parent
Change-Id: I21d82eb8716dd73aa2dc291b3ae8506e4fb4ea8b
BUG: 1207735
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11526
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 0bc220a935fad8c7a82c5d649785e3b5c54897d9
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Jun 16 15:18:50 2015 +0530
glusterd: Correction in Error message for disperse volume create
Problem: If all the bricks are on same server and
creating "disperse" volume without using "force",
it throws a failure message mentioning "replicate"
as volume.
Solution: Adding failure message for disperse volume too
Change-Id: I9e466b1fe9dae8cf556903b1a2c4f0b270159841
BUG: 1232183
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/11250
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 93c6cbe4c7e2a1bf115b41fcecf9d40c8aec9cd1
Author: Avra Sengupta <asengupt@redhat.com>
Date: Sun Jul 5 12:21:31 2015 +0530
glusterd/shared_storage: Use /var/lib/glusterd/ss_brick as shared storage's brick
The brick path we use to create shared storage is
/var/run/gluster/ss_brick.
The problem with using this brick path is /var/run/gluster
is a tmpfs and all the brick/shared storage data will be wiped
off when the node restarts. Hence using /var/lib/glusterd/ss_brick
as the brick path for shared storage volume as this brick and
the shared storage volume is internally created by us (albeit on
user's request), and contains only internal state data and no user data.
Change-Id: I808d1aa3e204a5d2022086d23bdbfdd44a2cfb1c
BUG: 1218573
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11533
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 15db640bd9d7baca1b2614e87e58330abfb91861
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 6 14:23:56 2015 +0530
cluster/ec: Don't read from bad subvols
Change-Id: Ic22813371faca4e8198c9b0b20518e68d275f3c1
BUG: 1232678
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11531
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d32118f583a80dd3ef54d3172a3f8120024f7417
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jul 2 12:44:01 2015 -0400
build: Mac OS X build issues, configure.ac
Mac has sqlite3, but no sysconf pkgconfig
Change-Id: I516613656ea3877c1a019438352b3ef8b62da1f5
BUG: 1238796
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11517
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 597e6504006d879f3b0f53a28c56296b2ad7b9ab
Author: vmallika <vmallika@redhat.com>
Date: Fri Jul 3 15:16:57 2015 +0530
posix: fix mem-leak in posix_get_ancestry error path
Change-Id: I47c8a8f170151f6374fc0420278aedf3ff5443ee
BUG: 1207735
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11522
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 616605be65199ed3e31485e58892a711f9cada23
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Jul 6 15:45:45 2015 +0530
protocol/server: Add null check to gf_client_put
Change-Id: I8bab3cd7387f89743e15e7569f0bc83a7df3c754
BUG: 1240161
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/11550
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit b3cfa8080624f84bcc280c92c291dbf467563dec
Author: anand <anekkunt@redhat.com>
Date: Mon Jun 8 00:19:00 2015 +0530
glusterd: Get the local txn_info based on trans_id in op_sm call backs.
Issue: when two or more transactions are running concurrently in op_sm,
global op_info might get corrupted.
Fix: Get local txn_info based on trans_id instead of using global txn_info for
commands (re-balance, profile ) which are using op_sm in originator.
TODO: Handle errors properly in call backs and completely remove the global op_info from
op_sm.
Change-Id: I9d61388acc125841ddc77e2bd560cb7f17ae0a5a
BUG: 1229139
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/11120
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit cf9512b5254b888a8b6ab2af33391dc9051d799d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 6 12:22:20 2015 +0530
cluster/ec: Remove failed subvols from source/sink computation
Change-Id: Ib0de34c86ee25de361ec821d4015296c514742e0
BUG: 1240210
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11546
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 62771b703642868cabc8a26fbd59dd9cb9b83646
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jun 30 23:01:36 2015 +0530
cluster/ec: Make background healing optional behavior
Provide options to control number of active background heal count and qlen.
Change-Id: Idc2419219d881f47e7d2e9bbc1dcdd999b372033
BUG: 1237381
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11473
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 991e3d9345076d1f9fbb951c9d0bd1f235a06fcc
Author: Anuradha Talur <atalur@redhat.com>
Date: Fri Jul 3 11:35:46 2015 +0530
cluster/afr : expunge first, impunge next in entry selfheal
When entry self-heals are performed, the files/directories
that are to be expunged should be removed first and then
impunge should be done.
Consider the following scenario :
A volume with 2 bricks : b0 and b1.
1) With following hierarchy on both bricks:
olddir
|__ oldfile
2) Bring down b1 and do 'mv olddir newdir'.
3) Bring up b1 and self-heal.
4) Without patch, during self-heal the events occur in
following order,
a) Creation of newdir on the sink brick. Notice that
gfid of olddir and newdir are same. As a result of which
gfid-link file in .glusterfs directory still points to olddir
and not to newdir.
b) Deletion of olddir on the sink brick. As a part of
this deletion, the gfid link file is also deleted. Now, there
is no link file pointing to newdir.
5) Files under newdir will not get listed as part of readdir.
To tackle this kind of scenario, an expunge should be done first
and impunge later; which is the purpose of this patch.
Change-Id: Idc8546f652adf11a13784ff989077cf79986bbd5
BUG: 1238508
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/11498
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 79421e8fd4414539da1f41d8e85d66d179a5953a
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Jun 19 01:41:27 2015 +0530
geo-rep: Fix fd referenced before assignment
Fix fd reference before assignment in mgmt_lock
function.
Change-Id: Ie939d4262a59cae0817ae388658a000576ab69b8
BUG: 1233411
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11318
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit b3adbb97207333006dc02e82f29f645d9b3b5e5c
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jun 26 22:36:31 2015 -0400
tools/glusterfind: RENAME and MODIFY issues
If Modification happens before RENAME, GFID to Path Conversion
converts it into New Path. Delete Modify Entry and insert again
So that MODIFY <NEW NAME> comes after RENAME.
Default value of pgfids and basenames changed to "" instead of NULL
Also fixed RENAME issue of displaying "RENAME <NEW NAME> <NEW NAME>".
Also fixed RENAME followed by missing MODIFY
Change-Id: I8202f6e6ec33f7bd921e71da38677f2ee2dab87a
BUG: 1236270
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/11443
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit d07239779ec7932e8bba10b68d3ba4b99b6e61fa
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jul 2 12:43:09 2015 -0400
build: Mac OS X build issues, no spinlock, need sys_lgetxattr
use regular locks, use our syscall wrappers in libglusterfs
Change-Id: I7e0d00956366806af041b69b65d1f169aa0d2ae2
BUG: 1238793
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11515
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 7f116534bf8fbc94e1910d99628b726f00a698e1
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jul 2 12:08:45 2015 -0400
build: Mac OS X build issues, header guard macros
clang compiler errors
Change-Id: I0aaa9f4353afd34e0e49ccb579b630a768c6c22a
BUG: 1238788
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11513
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit e9ad5897b6f45daacc39bc51666d4c13bdd3961b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jul 2 12:12:53 2015 -0400
build: Mac OS X build issues, gfapi symbol versions
fix broken symbol versions
Change-Id: I153b87d80895ddd4718d0a9e51b4c0712b178bd4
BUG: 1238791
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11514
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 41971c63f1812c8c2a7d3ddf0d1bbb9adf07249e
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Jun 10 00:08:39 2015 +0530
access-control : validating context of access control translator
By introduction of new acl conversion from http://review.gluster.org/#/c/9627/,
an acl can be set using GF_POSIX_ACL_*_KEY xattrs without notifying the
access-control translator. So evenif an acl is set correctly at the backend, it
might not work properly because access-control holds wrong acl information in
its context about that file.
Note : This is a simple workaround. The actual solution consists of three steps:
1.) Use new acl api's for acl conversion.
2.) Move the acl conversion part from access-control translator
3.) Introduces standard acl structures and libaries in access-translator
for caching, enforcing purposes.
Change-Id: Iacb6b323810ebe82f7f171f20be16429463cbcf0
BUG: 1229860
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/11144
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit e882ab07a537e91aa4ae6a91614870a4cb1ddad7
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Jul 2 05:19:19 2015 -0700
Revert "rpc: By default set allow-insecure, bind-insecure to on"
This reverts commit 5bf6522562990f7490d9fc226d58f19891bfb7a4.
This patch introduced a regression where client no longer binds to
privileged port. This is causing lots of regressions. Hence reverting
this patch for now and will be resent after suitable modifications.
Change-Id: Id697013ca6474e9c192e8f58c8179522fa5d397e
Reviewed-on: http://review.gluster.org/11507
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 34fa37d2082eee2860ad5d88c8e22aa67eaa1b6f
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jul 1 12:06:42 2015 +0530
libgfchangelog: Fix example programs
Incorporate the new API 'gf_changelog_init'
introduced in libgfchangelog which should
be called before 'gf_changelog_register'.
Change-Id: I10a9dd5ff3ecc64fd61dcb6b1aa53739e0bdeedd
BUG: 1238063
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11479
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9ead8a0cd371a17cf1d97982d1bbb1a684f2b151
Author: Meghana M <mmadhusu@redhat.com>
Date: Tue Jun 30 23:47:39 2015 +0530
NFS-Ganesha : Unexport fails after S31ganesha-start script is run
The dbus-send script extracts the export ID from the export config file.
It expects the export ID to be written in a particular format. The post-phase
hook-script created the export file in a different format,and the dbus-send
never gets the correct export ID because of this.
Fixing the issue by replacing the write_conf function in the
S31ganesha-start hook-script.Also, NFS-Ganesha service stops when dbus signal is sent more
than once on the same export. Consecutive start/stop operations creates problems.
Fixing all the issues at once.
Change-Id: Ibf639eb3556b1e51dd8dcb0c784a6a7f07badb97
BUG: 1238054
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11477
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 56f2af6a7ef0ddabceaefbfecf37fb04c5f42d26
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Jul 1 16:54:55 2015 +0530
protocol/server: fail setvolume if any of xlators is not initialized yet
We can only start recieving fops only when all xlators in graph are
initialized.
Change-Id: Id79100bab5878bb2518ed133c1118554fbb35229
BUG: 1236945
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/11490
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 52de2bbddc2cce2be43bd328df6543ca9718acbf
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Jun 12 15:12:05 2015 +0530
libgfapi: send explicit lookups on inodes linked in readdirp
If the inode is linked via readdirp, then the consuners of gfapi which are using
handles (got either in lookup or readdirp) might not send an explicit lookup on
that object again (ex: NFS, samba, USS). If there is a replicate volume where
the replicas of the object are not in sync, then readdirp followed by fops might
lead data being served from the subvolume which is not in sync with latest
data. And since lookup is needed to trigger self-heal on that object the
consumers might keep getting wrong data until an explicit lookup is not done.
Fuse handles this situation by sending an explicit lookup by itself (fuse
xlator) on those inodes which are linked via readdirp, whenever a fop comes on
that inode.
The same procedure is done in gfapi as well to address this situation.
Thanks to shyam(srangana@redhat.com) for valuable inputs
Change-Id: I64f0591495dddc1dea7f8dc319f2558a7e342871
BUG: 1236009
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11236
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 1aceac1eb367ff562e13998e4dfcea795c47f516
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 1 22:32:44 2015 +0530
libglusterfs: Use GF_CALLOC/GF_FREE instead of CALLOC/FREE
- Also removed numbers for the types as the string form of type is printed in
statedump now, so the numbers are not needed anymore.
Change-Id: I6e8c15a1dc8cb6187842f96f1d46ec0f26a602b4
BUG: 1237381
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11495
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f6b20925681229b8749b5db78fadf25a99c294cc
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jun 30 18:45:36 2015 +0530
cluster/ec: Add throttling in background healing
- 8 parallel heals can happen.
- 128 heals will wait for their turn
- Heals will be rejected if 128 heals are already waiting.
Change-Id: I2e99bf064db7bce71838ed9901a59ffd565ac390
BUG: 1237381
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11471
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 3490ddfbace77d88cba8db0f87aee86e1059f9b2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jun 30 22:09:57 2015 +0530
cluster/ec: Remove dead code
Change-Id: I99d7a038f29cebe823e17a8dda40d335441185bc
BUG: 1237381
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11472
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 1e6d239f3d1c646289f6f7d7b88f5d7dedf497a0
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jul 1 11:44:53 2015 +0530
protocol/server: Correctly reconfigure auth.ssl-allow
auth.ssl-allow wasn't being handled during reconfigure. This prevented
the ssl-allow list from being live reloaded.
Change-Id: If3435793a5684881b012de77cb254b1847b37810
BUG: 1238072
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/11487
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1379bc87c08b5a9d7f67bd07971d7009997191a4
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Jun 26 11:53:11 2015 +0530
cluster/dht: use refcount to manage memory used to store migration information.
Without refcounting, we might free up memory while other fops are
still accessing it.
BUG: 1235927
Change-Id: Ia4fa4a651cd6fe2394a0c20cef83c8d2cbc8750f
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/11418
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 7be9b0062f05789a9ed99a11155b3ccb44b1e718
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Jun 30 19:26:27 2015 +0530
common-ha: Fix '/var/lib/nfs/statd/state' path creation
'/var/lib/nfs/statd/state' which contains NSM state number
should be a file instead of directory.
Change-Id: Id008b4f4dd810fe6d6b4d2599cbc0b488010384b
BUG: 1237174
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11468
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 9e68f836493887a0bfa6bea98f5c873b9dcb6e3e
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Jun 30 11:15:54 2015 +0530
tiering/quota: failed to match subvolume
quota daemon choose subvolume for a volume using
volume-id specified in graph. For that it expect
a subvolume (DHT) to be named as volume-id. But
tiering translator comes above dht, so it failed to
match the correct subvolume.
Change-Id: I63d4b63cd8fb2806bc7b2b2f100dbef62202e6da
BUG: 1236128
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11431
Reviewed-by: Joseph Fernandes
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 224f9cd95b169094ea70a88dbc46b8e6180b040b
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed Jun 24 12:21:02 2015 +0530
rpc: By default set allow-insecure, bind-insecure to on
since we now use SSL (Secure Sockets Layer) for the security issues, the patch
changes the default setting to allow connections/requests from non-privilaged
ports by setting allow-insecure and bind-insecure to 1
Also added bind functionality for insecure binding which can select from
available local ports dynamically
BUG: 1232658
Change-Id: I927e112223f33611452093e38cd846a0b9347e57
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/11039
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 082d29425ad380d62e5911c1650839f653f5fa51
Author: Meghana M <mmadhusu@redhat.com>
Date: Mon Jun 29 06:16:47 2015 +0530
NFS-Ganesha : Exporting volume fails
Due to a recent fix, the dbus-send.sh looked
for a .export_added file even before it was
created. This resulted in the ganesha.enable
option failing consistently. Fixing it.
Change-Id: I26a68578551b6e38e49a9997e6f6f983fd668971
BUG: 1236561
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11456
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b4cefc54865ca0ee91ca45bf70fe6cd15b2bc6f9
Author: Anuradha Talur <atalur@redhat.com>
Date: Mon Jun 29 13:05:35 2015 +0530
doc : Steps to analize coredumps generated by regression machines.
Change-Id: Iadd879227a08d0dc0706363e7c6c30a6805e19ff
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/11453
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 915f1f23277ebbdfed0d6773b9b7420bf3498749
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sat May 9 07:23:09 2015 +0530
tests: Add the command being 'TEST'ed in all gluster logs
Appends all commands being run under the test framework into the logs
with time stamps. Its a hack but I find it very useful to see what
sections of the logs (across all logs) need to be analysed between
execution of 2 commands.
Here's a sample output:
[2015-06-26 13:25:15.866764479]:++++++++++ G_LOG:tests/basic/afr/quorum.t: TEST: 46 ! test_write ++++++++++
[2015-06-26 13:25:15.872002] I [afr-common.c:1682:afr_local_discovery_cbk] 0-patchy-replicate-0: selecting local read_child patchy-client-1
[2015-06-26 13:25:15.874559] W [fuse-bridge.c:723:fuse_truncate_cbk] 0-glusterfs-fuse: 81: TRUNCATE() /a => -1 (Read-only file system)
[2015-06-26 13:25:15.880554623]:++++++++++ G_LOG:tests/basic/afr/quorum.t: TEST: 47 abc cat /mnt/glusterfs/0/b ++++++++++
[2015-06-26 13:25:15.897767878]:++++++++++ G_LOG:tests/basic/afr/quorum.t: TEST: 48 gluster --mode=script --wignore volume set patchy cluster.quorum-reads on ++++++++++[2015-06-26 13:25:15.994410] I [glusterfsd-mgmt.c:51:mgmt_cbk_spec] 0-mgmt: Volume file changed
[2015-06-26 13:25:17.098519] I [glusterfsd-mgmt.c:51:mgmt_cbk_spec] 0-mgmt: Volume file changed
[2015-06-26 13:25:17.099241] I [glusterfsd-mgmt.c:51:mgmt_cbk_spec] 0-mgmt: Volume file changed
[2015-06-26 13:25:17.099685] I [glusterfsd-mgmt.c:51:mgmt_cbk_spec] 0-mgmt: Volume file changed
[2015-06-26 13:25:17.100055] I [glusterfsd-mgmt.c:51:mgmt_cbk_spec] 0-mgmt: Volume file changed
[2015-06-26 13:25:17.105896] W [MSGID: 108003] [afr.c:94:fix_quorum_options] 0-patchy-replicate-0: quorum-type auto overriding quorum-count 2
[2015-06-26 13:25:17.105936] W [MSGID: 108001] [afr.c:189:reconfigure] 0-patchy-replicate-0: Client-quorum is not met
[2015-06-26 13:25:17.107438] I [glusterfsd-mgmt.c:1507:mgmt_getspec_cbk] 0-glusterfs: No change in volfile, continuing
[2015-06-26 13:25:17.108724] I [glusterfsd-mgmt.c:1507:mgmt_getspec_cbk] 0-glusterfs: No change in volfile, continuing
[2015-06-26 13:25:17.110082] I [glusterfsd-mgmt.c:1507:mgmt_getspec_cbk] 0-glusterfs: No change in volfile, continuing
[2015-06-26 13:25:17.110599] I [glusterfsd-mgmt.c:1507:mgmt_getspec_cbk] 0-glusterfs: No change in volfile, continuing
[2015-06-26 13:25:17.109678070]:++++++++++ G_LOG:tests/basic/afr/quorum.t: TEST: 49 1 mount_get_option_value /mnt/glusterfs/0 patchy-replicate-0 quorum-reads ++++++++++
[2015-06-26 13:25:17.117801] I [afr-common.c:1682:afr_local_discovery_cbk] 0-patchy-replicate-0: selecting local read_child patchy-client-1
Change-Id: Ib51284a0384508350579babaf1ae69cb372e0baa
BUG: 1233018
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10667
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit f82fbfe271b707dcbe90471e80149260b21fff0b
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jun 1 16:10:40 2015 +0200
tests: use single-brick volume for mount-nfs-auth.t
When running with the replica-3 volume, the "big_write" test sometimes
becomes unresponsive. This seems to be an issue (bug 1226941) in the
RPC/socket-layer, and not related to the NFS test itself.
BUG: 1163543
Change-Id: I51115e4b68d45f3ef7902b4f7a8535518d09408f
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11085
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 9d592b74f21fef7e92b0edeaa2270b68cea3b32b
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jun 23 00:03:05 2015 +0200
nfs: a unix-domain-socket should not be created as fifo
Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
BUG: 1235231
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11355
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3625a1ac972ab4a6d7c9bb4d4e74155687e38946
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun May 31 16:27:44 2015 +0200
nfs: refcount each auth_cache_entry and related data_t
This makes sure that all the auth_cache_entry structures are only free'd
when there is no reference to it anymore. When it is free'd, the
associated data_t from the auth_cache->cache_dict gets unref'd too.
Upon calling auth_cache_purge(), the auth_cache->cache_dict will free
each auth_cache_entry in a secure way.
Change-Id: If097cc11838e43599040f5414f82b30fc0fd40c6
BUG: 1226717
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11023
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 2b12d13db63a065164d47f197c909498dc55ea78
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun May 31 14:39:51 2015 +0200
nfs: add a gf_lock_t for the auth_cache->cache_dict
This is the 1st step towards implementing reference counters for the
auth_cache_entry structure. Access to the structures should always be
done atomically, but this can not be guaranteed by the a dict.
Change-Id: Ic165221d72f11832177976c989823d861cf12f01
BUG: 1226717
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11021
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 1facb030db95d711a49c8bbda928c6bff64720fd
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jun 17 23:33:25 2015 +0200
build: always include the VERSION file in 'make dist'
Building a 'make dist' tarball from a non-git directory fails to include
the VERSION file. This subsequently fails to set the version in the
installation directories (for the xlators) and the RPM packaging can not
find the correct files.
This change makes sure to include a VERSION file in the 'make dist'
tarball, no matter from where 'make dist' is run. It mainly addresses
this use case:
$ git clone ... && cd glusterfs
$ ./autogen.sh
$ mkdir /tmp/workdir
$ cd /tmp/workdir
$ $OLDPWD/configure
$ make dist
Change-Id: I3e87b5e16118b68d065fe99790d4b17e0cef9189
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11297
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 7ec23aeb80b41bf967fc4df326e8a6c45009094b
Author: Kotresh HR <khiremat@redhat.com>
Date: Sun Jun 28 13:45:31 2015 +0530
feature/performace: Fix broken build
Fix the build broken because of patch
http://review.gluster.org/#/c/9822/
Change-Id: I0ee502c0fad5be87186c80ab4729036f52f85fa3
BUG: 1194640
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11451
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit c70a95388759552d5c3e4f35a973d09d2b3b623c
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Jun 28 10:15:44 2015 +0200
Revert "Upcall/gfapi: Return ENOTSUP when upcall feature is disabled"
This reverts commit b68f671b2b8a0aafef8f98145aee7044edaa907d from
http://review.gluster.org/11196 . The change depends on modifications to
the cluster xlators, but these are still partially under review.
Dropping this change now, it causes regression tests to fail.
Change-Id: If5ae4a519c9c6312cdb2e2a31acce4b1901f9442
BUG: 1231132
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11452
commit addefa98d97e0ccdf2f55584738fe9a135076336
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu Jun 25 15:04:18 2015 +0530
gfapi : symlink resolution for glfs_object
Generally posix expects symlink should be resolved, before performing an
acl related operation. This patch introduces a new api glfs_h_resolve_symlink()
which will do the same.
Change-Id: Ieee645154455a732edfb2c28834021bab4248810
BUG: 1209735
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/11410
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e42b599607b92cf299482983d162226723feb27f
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Jun 12 13:45:09 2015 +0530
Upcall/gfapi: Return ENOTSUP when upcall feature is disabled
Changes to detect the list of upcall events enabled using GF_FOP_IPC
and return ENOTSUP to applications in case if they poll for any of
the events disabled.
Change-Id: Icc748054ef903598288119dbe99b1e337174662a
BUG: 1231132
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11196
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 11464a40a1ba9dd1575448201653e749dbfb5087
Author: arao <arao@redhat.com>
Date: Fri Mar 6 12:33:05 2015 +0530
afr: Porting messages to new logging framework updated
Change-Id: I94ac7b2cb0d43a82cf0eeee21407cff9b575c458
BUG: 1194640
Signed-off-by: arao <arao@redhat.com>
Signed-off-by: Mohamed Ashiq <mliyazud@redhat.com>
Reviewed-on: http://review.gluster.org/9897
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 078a37cd82edd10d29042f2e089c1c63f3e20390
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Fri Jun 26 14:56:53 2015 +0530
rdma : removing duplicate printing of error string in gf_msg
Change-Id: I206cf80392d430f35558cc11699402c4cef12527
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/11426
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 0f5a996d180ef3e72bff5bc09555191295a936ee
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Jun 24 20:06:01 2015 +0530
features/bit-rot-stub: do not allow setxattr and removexattr on bit-rot xattrs
* setxattr and {f}removexattr of versioning, signature and bad-file xattrs are
returned with error.
Change-Id: Ib423466195d1d8e4c6f80c2906a574e21ed624fb
BUG: 1210689
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11389
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 4e4cdbbbf53e32c2548d5fbcfd64a966a901c420
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue May 26 19:22:14 2015 +0530
features/bit-rot-stub: deny access to bad objects
* Access to bad objects (especially operations such as open, readv, writev)
should be denied to prevent applications from getting wrong data.
* Do not allow anyone apart from scrubber to set bad object xattr.
* Do not allow bad object xattr to be removed.
Change-Id: Ia9185a067233a9f26e3d41d41d11d9a4eb0da827
BUG: 1210689
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11126
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit c666b7016d757e01145c94670524f206298b3663
Author: vmallika <vmallika@redhat.com>
Date: Thu Jun 18 16:31:57 2015 +0530
quota: Fix statfs values in EC when quota_deem_statfs is enabled
When quota_deem_statfs is enabled, quota sends aggregated statfs values
In EC we should not multiply statfs values with fragment number
Change-Id: I7ef8ea1598d84b86ba5c5941a2bbe0a6ab43c101
BUG: 1233162
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11315
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit e58dfc5d97578ee22eea4b85cf7d557a35c187ac
Author: arao <arao@redhat.com>
Date: Mon Jun 22 11:10:05 2015 +0530
Logging: Porting the performance translator logs to new logging framework.
Change-Id: Ie6aaf8d30bd4457bb73c48e23e6b1dea27598644
BUG: 1194640
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9822
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 567bde0bb8fedd0d84c9ff51ee637faa4e81f5cb
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Thu Jun 25 00:57:00 2015 +0530
glusterd: Porting left out log messages to new framework
Change-Id: I70d40ae3b5f49a21e1b93f82885cd58fa2723647
BUG: 1235538
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/11388
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit d24aa97bf7a00781d8a3b796bb8262d6c98ac507
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Tue May 19 15:46:01 2015 +0530
mem-pool,stack,store,syncop,timer/libglusterfs : Porting to a new logging framework
Change-Id: Idd3dcaf7eeea5207b3a5210676ce3df64153197f
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/10827
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit bebcbd023361fbd3334bc6a8cf004a1b39a35123
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Jun 22 17:06:07 2015 +0530
storage/posix: Introduce flag instructing posix to perform prestat, writev and poststat atomically
Change-Id: I9b52ddaed4e306e9a49f39c86450c94bea843a7b
BUG: 1233617
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11345
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 99d17e3379109c294fcebfbf1351068018fdc74c
Author: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Date: Thu Jun 25 12:52:57 2015 +0530
common-utils/libglusterfs : removing strerror to avoid duplicate printing of error message
Change-Id: I0a1c99ae7a2efc657e3465b21dd238e725ae236c
BUG: 1194640
Signed-off-by: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Reviewed-on: http://review.gluster.org/11400
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e86ac24236421a01bbb81a950141be94ae837c90
Author: Anuradha <atalur@redhat.com>
Date: Tue Jun 16 15:57:30 2015 +0530
cluster/afr : truncate all sinks files
Problem : During data self-heal of sparse files,
sparseness of files is lost.
Cause : Earlier, only files with larger ia_size in sinks
were being truncated to ia_size of source. This caused
checksum mismatch of sparse blocks when ia_size of files
in sinks were lesser than ia_size of source file.
Leading to unnecessary healing of sparse blocks.
As a result of which sparseness of files was lost.
Solution : truncate files in all the sinks irrespective of
their size with respect to the source file. After this change,
checksum won't mismatch for sparse blocks and heal won't
be triggered. As a result, sparseness of the files will
be preserved.
Other fixes in this patch :
1) in afr_does_size_mismatch(), check for mismatch only
in sources. Previously, the check was being done for all
children in a replica.
2) in __afr_selfheal_data_checksums_match(), check checksum
mismatch only for children with valid responses.
Change-Id: Ifcdb1cdc9b16c4a8a7867aecf9fa94b66e5301c2
BUG: 1232238
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/11252
Reviewed-by: Prasanna Kumar Kalever
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit fa5586c0e655d2b9e3910f8b2a00a2c1d5b6fa34
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jun 25 00:22:41 2015 +0530
afr: Block fops when file is in split-brain
For directories, block metadata FOPS.
For non-directories, block data and metadata FOPS.
Do not block entry FOPS.
Change-Id: Id7f656f4a513b9d33c457dd7f2d58028dbef8e61
BUG: 1235007
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/11371
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 62eee41803d2285729bef7d1237af39d9275b9b2
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jun 17 15:46:01 2015 -0400
geo-rep: ignore ESTALE as ENOENT
When DHT can't resolve a File it raises ESTALE, ignore ESTALE errors
same as ENOENT after retry.
Affected places:
Xattr.lgetxattr
os.listdir
os.link
Xattr.lsetxattr
os.chmod
os.chown
os.utime
os.readlink
BUG: 1232912
Change-Id: I02015f508d901e4a74dd48e1c52423e78eaf1dcd
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/11296
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 08c3eee0ec3576a0a95229e6b9f7f2a49c469ea3
Author: Meghana M <mmadhusu@redhat.com>
Date: Fri Jun 26 11:27:18 2015 +0530
NFS-Ganesha : Automatically export volume after volume restart
The export file was not getting created in the correct
path. Fixing the path in this patch.
Change-Id: If624266e1a934514868affb712514881d10239dc
BUG: 1231738
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11432
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b32f540fd59eab47b3e698eb6622e68b2839377f
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jun 25 19:49:59 2015 +0530
protocol/server: Include a check to validate xprt->client
rpc_transport entries(xprt) are added to the conf->xprt_list
during client connection with the server. But the client object is created
and assigned to that transport object only during GF_HANDSK_SETVOLUME. Hence
till that period, there could be xprt entries in the xprt_list without client
associated with it. Added a check to validate the client object during upcall
notify.
Change-Id: I11e2fcd8b0a67e35302ede478b777b72d1973456
BUG: 1235542
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11411
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 06bc13b88d69ca3297bb54a1920340a0a7e0fb41
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jun 25 00:47:19 2015 +0530
Upcall: Fix an issue with invalidating parent entries
Any directory or file creation should result in cache-invalidation
requests sent to parent directory. However that is not the case
currently due to a bug while processing these requests in the
upcall xlator. We need to do invalidation checks on parent inode.
Fixed the same. Also fixed an issue with null client entries while
sending upcall notifications.
Change-Id: I3da7c79091291ba36fd8f8ebcfebcd77a192f250
BUG: 1235542
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11387
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 87032427bb655623fa7fcaa743a662367998bb55
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Jun 23 16:35:03 2015 -0400
cluster/tier: stop tier migration after graph switch
On a graph switch, a new xlator and private structures are
created. The tier migration daemon must stop using the
old xlator and private structures and begin using the
new ones. Otherwise, when RPCs arrive (such as counter
queries from glusterd), the new xlator will be consulted
but it will not have up to date information. The fix
detects a graph switch and exits the daemon in this
case. Typical graph switches for the tier case would
be turning off performance translators.
Change-Id: Ibfbd4720dc82ea179b77c81b8f534abced21e3c8
BUG: 1226005
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/11372
commit e9b0da2487762948a607189f8fcad2b1e6efaf0a
Author: Joseph Fernandes <josferna@redhat.com>
Date: Sat Jun 20 14:38:12 2015 +0530
tier/ctr: Ignore creation of T file and Ctr Lookup heal improvememnts
1) Ignore creation of T file in ctr_mknod
2) Ignore lookup for T file in ctr_lookup
3) Ctr_lookup:
a. If the gfid and pgfid in empty dont record
b. Decreased log level for multiple heal attempts
c. Inode/File heal happens after an expiry period, which is configurable.
d. Hardlink heal happens after an expiry period, which is configurable.
Change-Id: Id8eb5092e78beaec22d05f5283645081619e2452
BUG: 1235269
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/11334
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit daf8a2cfce5f11411694424a1b23921b4a519399
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jun 22 11:39:11 2015 -0400
common-ha: fix delete-node
N.B. delete-node is a designed to be "disruptive"
surgically delete a node from the config and stop nfs-ganesh on that
node.
finish the implementation and fix a few minor issues
Change-Id: I964bb72a76ee635b5fc484ec5b541e69eeececcd
BUG: 1234474
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11353
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 44fc479eb1b34c1c5142792711f49d89d9dd429f
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Thu Apr 30 14:28:10 2015 +0530
ec: Porting messages to new logging framework
Change-Id: Ia05ae750a245a37d48978e5f37b52f4fb0507a8c
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/10465
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit f50a296d83ef95ca99b3c1e30fa3f5143104e347
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed Apr 15 06:32:18 2015 -0400
MAINTAINERS: add maintainers for tier feature
Tiering
M: Dan Lambright <dlambrig@redhat.com>
M: Joseph Fernandes <josferna@redhat.com>
S: Maintained
F: xlators/cluster/dht/src/tier.c
F: xlators/features/changetimerecorder
F: libglusterfs/src/gfdb
W: http://www.gluster.org/community/documentation/index.php/Features/data-classification
Change-Id: I4b075a287a556551a2b72273901e1d3176f356aa
BUG: 1194753
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10251
commit 0130beba3081690e28956ab06a9947956f9599fb
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Jun 25 16:30:40 2015 +0530
EC : While Healing a file, set the config xattr
Problem : trusted.ec.config attr was missing for the healed file
Solution: Writing trusted.ec.config while healing a file.
Change-Id: I340dd45ff8ab5bc1cd6e9b0cd2b2ded236e5acf0
BUG: 1235246
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/11407
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 520936371e80f28d9d4934962b28531af029a913
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jun 25 00:18:01 2015 +0530
geo-rep: Fix add user in mountbroker user management
The CLI 'gluster system:: execute mountbroker user <USERNAME> <VOLUMES>'
to set volumes associated with a user replaces existing user and associated
volumes upon setting with existing user. This patch fixes it by appending
the volumes if the user already exists.
It also introduces following CLI to remove volume for a corresponding user.
'gluster system:: execute mountbroker volumedel <USERNAME> <VOLUME>'
<USERNAME>: username
<VOLUME>: comman separated list of volumes to delete
If it is the last volume to be deleted associated with the user,
it will delete the user as well as it doesn't make sense to keep
only user without volumes associated.
Change-Id: I49f4b9279954d9f5d34aca2dd8a69c6f4b87fd19
BUG: 1226223
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11385
Reviewed-by: darshan n <dnarayan@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 7901782f208d09eaef0558f8424e13964f6b3e58
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Jun 22 19:01:39 2015 -0400
features/changelog: Always log directory rename operations
Directory renames are being ignored as special renames. Special
renames can happen only on files. Hence always log directory
rename operations in changelog.
Change-Id: I4fbdb3e02e634a39a8846fb2f7a4c6cc2ba74400
BUG: 1234286
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/11356
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit aa2d74789f4c4fe359d2f410e1aab3accd46d6dc
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Thu Jun 25 16:10:29 2015 +0530
ganesha: volinfo is not persisted after modifying options
ganesha disables gluster NFS when it is enabled. Gluster NFS
is disabled by storing nfs.disable as "on" in volinfo of each
volume in the cluster. But volinfo is not persisted after the
change.
Due to which wrong info is passed in handshake leading to volume
checksum mismatch.
Bug: 1235751
Change-Id: Icd642f5068cc934bb77676fb8ef71b958a7b7384
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/11412
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit d72906d4e064d14d1480f1c714edde504b234cd2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jun 26 11:46:45 2015 +0530
tests: fix basic/afr/replace-brick-self-heal.t failure
Test fails with:
not ok 28 Got "Binary file (standard input) matches" instead of "qwerty"
FAILED COMMAND: qwerty get_text_xattr user.test
/d/backends/patchy1_new/file5.txt
not ok 29 Got "Binary file (standard input) matches" instead of "qwerty"
FAILED COMMAND: qwerty get_text_xattr user.test
/d/backends/patchy0/file5.txt
Failed 2/29 subtests
Fix:
Pass -a flag to grep
Change-Id: I69626fbf95a9ff756046363c5627cf98ea3f1df8
BUG: 1207829
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/11416
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 545a9871527ac182075d7b1de165e8ede4f73ad8
Author: vmallika <vmallika@redhat.com>
Date: Thu Jun 25 14:58:50 2015 +0530
quota: marker accounting goes bad with rename while writing a file
With below test-case, marker accounting becomes bad:
1) Create a volume with 1 brick
2) fuse mount
3) on one terminal write some data
dd if=/dev/zero of=f1 bs=1M count=500 oflag=sync
4) on another terminal execute below rename operation while the write is
still in progress
for i in {1..50}; do
ii=`expr $i + 1`;
mv f$i f$ii;
done
remove-xattr is already on while doing rename operation,
we should not be doing again in background when reducing the
parent size
Change-Id: I969a64bb559e2341315928b55b99203e9ddee3f2
BUG: 1235195
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11403
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 4c43eb9be91d00e45778e4aa598c3b810fc9882f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jun 15 16:32:06 2015 +0530
cluster/ec: wind fops on good subvols for access/readdir[p]
Change-Id: I1e629a6adc803c4b7164a5a7a81ee5cb1d0e139c
BUG: 1232172
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11246
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 4c9ca8293982df0808dbe5330c7d04fdb32b405f
Author: Anuradha <atalur@redhat.com>
Date: Fri Jun 5 16:46:39 2015 +0530
glusterd/ afr : set afr pending xattrs on replace brick
This patch is part one change to prevent data loss
in a replicate volume on doing a replace-brick commit
force operation.
Problem: After doing replace-brick commit force, there is a
chance that self heal happens from the replaced (sink) brick
rather than the source brick leading to data loss.
Solution: During the commit phase of replace brick, after old
brick is brought down, create a temporary mount and perform
setfattr operation (on virtual xattr) indicating AFR to mark
the replaced brick as sink.
As a part of this change replace-brick command is being changed
to use mgmt_v3 framework rather than op-state-machine framework.
Many thanks to Krishnan Parthasarathi for helping me out on this.
Change-Id: If0d51b5b3cef5b34d5672d46ea12eaa9d35fd894
BUG: 1207829
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/10076
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a35c98c971f628020bea2133c3d5fe35870c6865
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jun 26 09:05:26 2015 +0530
libglusterfs: Fix build failure
Change-Id: Ie589c866a53c0cfc167e31d1d14a11bf58c8dabf
BUG: 1207829
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11413
commit f06f5de1713b66f1161a155c8e78a576cb945981
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Tue May 19 15:11:45 2015 +0530
graph/libglusterfs : porting to a new logging framework
Change-Id: I57ed5c979c15559443712a61f0b1a61c7f5557d8
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/10822
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 29fffeb86c2d8b8965eddf3c547119f4ce543d18
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Jun 3 17:10:22 2015 +0530
tiering/rebalance: tier daemon stopped with out updating status
When a subvol goes down, tier daemon stopped immediately, and
the status shows as "Progressing".
With this change, with respect to tier xlator, when a subvol
goes offline it will update the status as failed.
Change-Id: I9f722ed0d35cda8c7fc1a7e75af52222e2d0fdb7
BUG: 1227803
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11068
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 6b09fd697a47701a481214715b9509322be50f1d
Author: Anuradha <atalur@redhat.com>
Date: Thu Jun 11 14:58:05 2015 +0530
cluster/afr : set pending xattrs for replaced brick
This patch is part two change to prevent data loss
in a replicate volume on doing a replace-brick commit
force operation.
Problem: After doing replace-brick commit force, there is a
chance that self heal might happen from the replaced (sink) brick
rather than the source brick leading to data loss.
Solution: Mark pending changelogs on afr children for
the replaced afr-child so that heal is performed in the
correct direction.
Change-Id: Icb9807e49b4c1c4f1dcab115318d9a58ccf95675
BUG: 1207829
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/10448
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit c5066e106054e29bf48f65be00c6e177d73a0e10
Author: Anoop C S <achiraya@redhat.com>
Date: Mon Jun 8 18:21:56 2015 +0530
protocol/client: Properly handle return value in clnt_release_reopen_fd
On account of a lock reacquire failure [in clnt_release_reopen_fd()]
the return value, on submitting the client request for release of
reopened fd, is not honoured correctly.
Change-Id: Iff11523b2cc6f284e806855f32a13d8c4432f1c6
BUG: 1227667
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/11088
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 89019e243b24f69e1b25433e3940bfe8422f1d88
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Jun 16 23:53:32 2015 +0530
snapshot: Fix terminating slash in brick mount path
glusterd_find_brick_mount_path(), returns mount path,
with a terminating '/' at the ned of the string in
cases where the brick dir is a dir in the lvm root dir.
Ignoring the terminating '/' fixes the issue.
Change-Id: Ie7e63d37d48e2e03d541ae0076b8f143b8c9112f
BUG: 1232430
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11262
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit c840aae0fdbb4413b90a02c8d39ccc1ea37795d7
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Jun 25 12:07:24 2015 +0530
features/bitrot: convert pending gf_log() to gf_msg()
Change-Id: Idfd245327b485459ccbda503510b8ca0127bb66c
BUG: 1231619
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11396
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 5b0dc1f00b0bea2226b3f7e5032c1cdf301f7190
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jun 9 10:02:11 2015 +0530
features/bitrot: handle scrub states via state machine
A bunch of command line options for scrubber tempted the use of
state machine to track current state of scrubber under various
circumstances where the options could be in effect.
Change-Id: Id614bb2e6af30a90d2391ea31ae0a3edeb4e0d69
BUG: 1231619
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11149
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 873dbb2c9f9832e020c74a09d282631b099653a9
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jun 24 20:00:11 2015 +0530
geo-rep: Fix ssh issue in geo-rep
In geo-rep mountbroker setup, workers fails with
'Permission Denied' even though the public keys
are shared to all the slave nodes. The issue
is with selinux context not being set for .ssh
and .ssh/authorizedkeys. Doing restorecon on
these entries to set default selinux security
context fixes the issue.
Change-Id: I75e16d22f7a168de6c13b0c7571a7ab75761ae0d
BUG: 1235359
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11383
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: darshan n <dnarayan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 09f237a6e9a33b8379c43b1ea3e24780e3ddae20
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Jun 4 08:50:48 2015 +0530
features/bitrot: cleanup, v2
This patch uses "cleanup, v1" infrastrcuture to cleanup scrubber
(data structures, threads, timers, etc..) on brick disconnection.
Signer is not cleaned up yet: probably would be done as part of
another patch.
Change-Id: I78a92b8a7f02b2f39078aa9a5a6b101fc499fd70
BUG: 1231619
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11148
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit ffac44adfbae8dbe29b3ded27c91b462772be44d
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jun 17 09:35:22 2015 +0530
Revert "tests/bitrot: Induce delay before invoking bitrot subcommands"
This reverts commit a615f6c078c76791318c2a58efcc8baef18c25db.
Change-Id: I8b014a99686cd4ee07da9d26bca561b420c8bec7
BUG: 1231617
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11263
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit b2506ae83c288ed382d037a1aa697f0efa22a94d
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jun 2 21:23:48 2015 +0530
features/bitrot: cleanup, v1
This is a short series of patches (with other cleanups) aimed at
cleaning up some of the incorrect assumptions taken in reconfigure()
leading to crashes when subvolumes are not fully initialized (as
reported here[1] on gluster-devel@). Furthermore, there is some
amount of code cleanup to handle disconnection and cleanup up data
structure (as part of subsequent patch).
[1] http://www.gluster.org/pipermail/gluster-devel/2015-June/045410.html
Change-Id: I68ac4bccfbac4bf02fcc31615bd7d2d191021132
BUG: 1231617
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11147
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 329b6528ccb1b47e9a2315ef361709b2878543b7
Author: vmallika <vmallika@redhat.com>
Date: Wed Jun 24 11:56:30 2015 +0530
quota/marker: fix mem-leak in marker
When removing contribution xattr, we also need to free
contribution node in memory.
Use ref/unref mechanism to handle contribution node memory
local->xdata should be freed in mq_local_unref
There is another huge memory consumption happens
in function mq_inspect_directory_xattr_task
where dirty flag is not set.
Change-Id: Ieca3ab4bf410c51259560e778bce4e81b9d888bf
BUG: 1207735
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11361
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 957848335f62fef1a8d7a53b6eac6b79d921c981
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Tue May 19 15:53:19 2015 +0530
call-stub,circ-buff,client_t,compat,dict/libglusterfs : Porting to a new logging framework
Change-Id: Ie7d180e0ab2fed1270d66504606d1b2522884020
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/10828
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 35004ce75f93d2086f8ea09255fafdb753585549
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jun 24 18:30:18 2015 +0530
geo-rep: Fix glusterd working directory
Mountbroker setup in geo-replication requires
the script 'set_geo_rep_pem_keys.sh to be
run manually out of gluster context. Hence
the ${GLUSTERD_WORKDIR} is never set. So
getting glusterd working dir using 'gluster
system:: getwd'.
Change-Id: Ic2fe85e685016b383e38af0ea43c3f0628c16a32
BUG: 1235292
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11381
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 0ce25f13c21e7fd3f6b8a78ba6950b9963cba282
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jun 23 10:38:27 2015 +0530
geo-rep: Fix toggling of use_meta_volume config
If meta-volume is deleted and use_meta_volume
is set to false, geo-rep still fails complaining
meta volume is not mounted. The patch fixes that
issue.
Change-Id: Iecf732197926bf9ce69112287fccbb1c34e58e6d
BUG: 1234694
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11358
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit e27a57ac00054d303dc2f911a6fa38c59d5a6f21
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Tue May 19 15:40:30 2015 +0530
defaults,globals,iobuf,latency,logging,options,xlator/libglusterfs : porting to a new logging framework
Change-Id: If6a55186cddc3d1c4d22e3d56b45358b84feeb49
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/10826
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a93e67d0dd739e93a5167e6109fb5facaec9e020
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Tue May 19 15:21:46 2015 +0530
event,parse-utils,quota-common-utils,rbthash/libglusterfs : Porting to new logging framework
Change-Id: I13ae9a97fe442c06cf50fe77c63718ea0858dc4d
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/10823
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 113d6df6c2fd6e983b55fe28a227ecc066c615a2
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jun 23 15:40:59 2015 +0530
glusterd: Store peerinfo after updating hostnames
Change-Id: I1d36ac63de810061d60edb28b6f591ae45d5cd3a
BUG: 1234842
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/11365
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
commit 05f5300cfa4be344c703cb324d1aa5e294f1ec17
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Jun 17 14:20:14 2015 +0530
glusterd: fix quorum calculation logic
glusterd_get_quorum_cluster_counts () skips quorum calculation if it finds any
of its peer in QUORUM_WAITING state. This means if any peer probe has been
triggered and at the same point of time a transaction has been initiated, it
might pass through the server quorum check which it should not.
Change-Id: I44eda8905eab3349c9ebf2842e7131d4e758a528
BUG: 1232686
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11275
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 4082bad61c0ff19f13fc0f7da1c8beead81f537c
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jun 23 18:28:56 2015 +0530
geo-rep: Fix geo-rep fanout setup with meta volume
Lock filename was formed with 'master volume id'
and 'subvol number'. Hence multiple slaves try
acquiring lock on same file and become PASSIVE
ending up not syncing data. Using 'slave volume id'
in lock filename will fix the issue making lock
file unique across different slaves.
BUG: 1234882
Change-Id: Ie3590b36ed03e80d74c0cfc1290dd72122a3b4b1
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11367
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit dd0132a1c8cb16ddc6b6b5c3b15d2d8723811e59
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jun 24 08:02:51 2015 +0530
cluster/afr: Pick gfid from poststat during fresh lookup for read child calculation
Change-Id: I12c1e4f67f4ec4affbe13d7daf871044a8a2a12e
BUG: 1235216
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11373
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 641f5f04417966917bdc594ad3982992729d2e73
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Fri Apr 17 17:33:49 2015 +0530
bit-rot : New logging framework for bit-rot log message
Change-Id: I83c494f2bb60d29495cd643659774d430325af0a
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/10297
Tested-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 519d62fe82ac451c9d25fd8bcb51b5b21d5e7f6c
Author: Meghana M <mmadhusu@redhat.com>
Date: Fri Jun 19 05:48:05 2015 +0530
NFS-Ganesha : Implement refresh-config
It is important that we give an automatic way of refreshing the config
when the user has changed the export file manually.
Without this, the user will be forced to restart the server.
Implementing refresh_config by utilizing two other scripts
that are already in place.
Making a few changes to make sure that "--help"
doesn't throw unnecessary error messages.
Change-Id: I6559b89e858526717168ba286e1ff7d9977097c6
BUG: 1233624
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11331
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 08957388db76fd70ed0e2c5d2786df164e83f9fd
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jun 23 15:40:32 2015 +0530
glusterd: use mkdir_p for creating rundir
snapdsvc initialization is now dependent on all subsequent directories and
volfile creations as per commit 2b9efc9.
However this may not hold true correct for all the cases. While importing a
volume we would need to start the service before the store creation.
To avoid this dependency, use mkdir_p instead of mkdir to create rundir
Change-Id: Ib251043398c40f1b76378e3bc6d0c36c1fe4cca3
BUG: 1234819
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11364
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 00de9219579f6ea8ab6ada56f893c3e862ddf96a
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jun 23 00:25:38 2015 +0530
Revert "quota/marker: fix mem-leak, free contribution node"
This reverts commit 8ab6608accb62d6320d1fc1fbe651fcafd376270.
This patch is resulting in memory corruption:
http://build.gluster.org/job/rackspace-regression-2GB-triggered/11193/consoleFull
contribution object might be being used by some other transaction when
we free it. The correct way to handle this is to have a reference based
scheme to manage the contribution object.
Change-Id: Idf9993ed8268029073a3e2d699865587f20d9aea
BUG: 1207735
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11362
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 829399da0018cf6ecb2f6cc5bdddec29f5e6064d
Author: arao <arao@redhat.com>
Date: Fri Jun 12 16:35:53 2015 +0530
dht: Adding log messages to the new logging framework
Change-Id: Ib3bb61c5223f409c23c68100f3fe884918d2dc3f
BUG: 1194640
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/10021
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Joseph Fernandes
Tested-by: Joseph Fernandes
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 20cdf1d505def29459660dd013c73414186bb4b1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu May 28 15:33:18 2015 +0530
cluster/ec: Do not handle GF_CONTENT_KEY
GF_CONTENT_KEY aggregation requires that the fragments on the bricks belong to
same data i.e. no operations are modifying the content while lookup is
performed on it. The only way to know it is to get at least ec->fragments+1
number of responses and see that two different sets of ec->fragments number of
fragments give same data. But at the moment we feel that this slows down
ec-lookup. So removing handling of this for now.
Change-Id: I2da5087f1311d5cdde999062607b143b48c17713
BUG: 1226279
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11003
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit ed7825c7c0c85275f97bea791c73713cbd0ca3f9
Author: Ashish Pandey <aspandey@redhat.com>
Date: Wed Jun 17 12:40:06 2015 +0530
ec: Display correct message after successful heal start
Problem : While launching heal, it shows heal launch
was unsuccessful. However, internaly it was successfully
launched.
Solution : Don't reset op_ret to -1 in for loop for
every brick.
Change-Id: Iff89fdaf6082767ed67523a56430a9e83e6984d3
BUG: 1203089
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/11267
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit e44eeba3f0093acaffc870299d2a89e2fab3fac9
Author: Anoop C S <achiraya@redhat.com>
Date: Wed Jun 3 11:38:13 2015 +0530
protocol/client: Remove unused function clnt_mark_fd_bad()
clnt_mark_fd_bad() is no longer used to mark the fd bad. Instead
we make use of client_mark_fd_bad() to do the same.
Change-Id: I09af892d8c0c5d1cf853ff020e8596c53d9539c0
BUG: 1227667
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/11063
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c3c37dfb557ef701251a4cae441ba2ae1155ce90
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Fri Jun 19 13:36:11 2015 +0530
posix: lstat() failure have to recorded as warning
BUG: 1200364
Change-Id: Ic9cae46e89e49fede2150f420ca0b1e202d84bbe
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9849
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 4b936a87577afefbb2dc4e4f81c472cdb1a7117e
Author: vmallika <vmallika@redhat.com>
Date: Thu Jun 18 12:02:50 2015 +0530
quota: allow writes when with ENOENT/ESTALE on active fd
We may get ENOENT/ESTALE in case of below scenario
fd = open file.txt
unlink file.txt
write on fd
Here build_ancestry can fail as the file is removed.
For now ignore ENOENT/ESTALE on active fd with
writev and fallocate.
We need to re-visit this code once we understand
how other file-system behave in this scenario
Below patch fixes the issue in DHT:
http://review.gluster.org/#/c/11097
Change-Id: I7be683583b808c280e3ea2ddd036c1558a6d53e5
BUG: 1188242
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11307
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit df3be5589b4b14b6a276433262e9b930d79d37cc
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jun 17 15:00:23 2015 +0530
gluster/shared_storage: Add/Remove shared storage from /etc/fstab during enable/disable
While creating/deleting shared storage volume, add/remove the shared storage
entry from /etc/fstab, so as to ensure availability of the shared storage,
even after a node reboot
Change-Id: Ib9edc8fd02c74a677062ca53ffd10be997b056c6
BUG: 1231876
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11272
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 070c6035f1177c1aae34828c475b5f4cb3b37544
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jun 17 14:18:32 2015 +0530
glusterd/mgmt_v3: Print the node info, with failure messages
While reporting multiple failure messages from different
nodes, print the node ip and the failure stage.
Change-Id: I657d3debf1b509e4a27baf9e4b580f1ee32e3c5f
BUG: 1205596
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11234
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 662be7fbbabbc331b50d0da22c6603f327e3eb0e
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Jun 12 17:13:05 2015 +0530
glusterd/uss/snapshot: Intialise snapdsvc after volfiles are created
snapd svc should be initialised only after all
relevant volfiles and directories are created.
Change-Id: I96770cfc0b350599cd60ff74f5ecec08145c3105
BUG: 1231197
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11227
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit bde61434776ef37b25daa354acf85309f680468f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jan 9 08:17:19 2015 +0530
afr: complete conservative merge even in case of gfid split-brain.
Problem:
While performing conservative merge, we bail out of the merge if we encounter a
file with mismatching gfid or type. What this means is all entries that come
after the mismatching file (during the merge) never get healed, no matter how
many index heals are done.
Fix:
Continue with the merging of rest of the entries even if a gfid/type mismatch is
found, but ensure that post-op does not happen on the parent dir in such a case.
Change-Id: I9bbfccc8906007daa53a0750ddd401dcf83943f8
BUG: 1180545
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9429
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 51ddb31fcf07b47b1f97599e9e331e9d6c3dbb99
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Jun 5 10:33:11 2015 +0530
stack: use list_head for managing frames
PROBLEM
--------
statedump requests that traverse call frames of all call stacks in
execution may race with a STACK_RESET on a stack. This could crash the
corresponding glusterfs process. For e.g, recently we observed this in a
regression test case tests/basic/afr/sparse-self-heal.t.
FIX
commit 6658c5338a18ce5452baea7e4e8a5478f1eb37a9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jun 3 16:51:49 2015 +0530
features/shard: Skip shards resolution if lookup on /.shard returns ENOENT
This change is done in [f]truncate, rename, unlink and readv.
Also, this patch also makes lookup in shard delete GF_CONTENT_KEY
as a workaround for the problems with read caching of sparse files
by quick-read. A proper solution would involve shard_lookup_cbk()
performing a readv, aggregating and ordering the responses and setting
it in the xdata before unwinding the response to upper translators, which
will be done in a separate patch.
Change-Id: Ie12edb9ba8c1fcea38fea0a797916cb2a98fb30c
BUG: 1223759
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11065
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 22a0489fac0416bc81dbcf56e7fe0e8645de0f9c
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jun 19 11:36:25 2015 +0200
refcount: correct the documentation
The only check that _gf_ref_get() needs is "== 0" for detecting a
failure. The actual return value is not guaranteed to be the number of
active refences (they can change in other threads anyway).
BUG: 1163543
Change-Id: I8801601eab37046f5a5ee0bce5a62606115ca151
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11328
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit c54cc98edd1a941f24279c41aee35d38cd405b50
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jun 17 22:59:17 2015 +0530
tests/bitrot: Scrub state change tests
Change-Id: Ibb4b503e7d723c86ac381ad3747b1198334bd6ad
BUG: 1231619
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11290
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6916aeac5f2f6ab5aaa15386e6e40e6a8814a438
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Jun 17 18:42:06 2015 +0530
protocol/client : removing duplicate printing in gf_msg
Since the 3rd and 5th argument of gf_msg framework
prints the error string in case of strerror(),
5th argument is removed.
Change-Id: Ib1794ea2d4cb5c46a39311f0afcfd7e494540506
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/11280
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 68381654df90ebe3839601d2831208b2af2831af
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Jun 11 20:19:39 2015 +0530
features/bitrot: log scrub frequency & throttle values
Change-Id: I56d5236c37a413046b5766320184047a908f2c8d
BUG: 1231620
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11190
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6a909b19c27038e67f8d957736d9cd7001f33245
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun May 31 15:16:41 2015 +0200
core: add "gf_ref_t" for common refcounting structures
Checks for compiler supported atomic operations comes from client_t.h.
An example usage of this change can be found in adding reference
counting to "struct auth_cache_entry" in http://review.gluster.org/11023
Basic usage looks like this:
#include "refcount.h"
struct my_struct {
GF_REF_DECL;
... /* more members */
}
void my_destructor (void *data)
{
struct my_struct *my_ptr = (struct my_struct *) data;
... /* do some more cleanups */
GF_FREE (my_ptr);
}
void init_ptr (struct parent *parent)
{
struct my_struct *my_ptr = malloc (sizeof (struct my_struct));
GF_REF_INIT (my_ptr, my_destructor); /* refcount is set to 1 */
... /* my_ptr probably gets added to some parent structure */
parent_add_ptr (parent, my_ptr);
}
void do_something (struct parent *parent)
{
struct my_struct *my_ptr = NULL;
/* likely need to lock parent, depends on its access pattern */
my_ptr = parent_remove_first_ptr (parent);
/* unlock parent */
... /* do something */
GF_REF_PUT (my_ptr); /* calls my_destructor on refcount = 0 */
}
URL: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/11202
Change-Id: Idb98a5861a44c31676108ed8876db12c320912ef
BUG: 1228157
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11022
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 6b2868aaed60f2407e1f1496008b1601dafcea1a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Jun 19 12:32:51 2015 +0530
glusterd/shared_storage: Added help description for enable-shared-storage option
Added help description in gluster volume set help for
cluster.enable-shared-storage option.
Change-Id: I36481d1ca856739e83f0c9c7432ac0cb4131d665
BUG: 1233544
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11324
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 4d7fdbc7cebe604e7de17976d3818be2d32a86ff
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Jun 15 15:59:21 2015 +0530
snapshot: man page modifications
Modified man page to correct snap-max-hard-limit and
snap-max-soft-limit entries.
Change-Id: Ide3405fc94ea5cf6e19504e6dc158938c1bf135b
BUG: 1205037
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11229
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 2d115ae0d4178eedfd0c3140980af1e5d68a2734
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue May 26 10:59:45 2015 +0530
glusterd/tier: configure tier daemon during volume restart
rebalance daemon will be running on every tier volume for
promoting/demoting the files. When volume/glusterd is restarted,
then we need to configure the daemon.
Change-Id: Ib565240a70edea2ec8bc1601c52b40c0783491d3
BUG: 1225330
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10933
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
commit 2ee2f3215c7e7441ee164afb880837850ee905de
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue May 12 14:50:33 2015 +0530
tier/glusterd: Add description for volume set options
Change-Id: Idc2eed77f8d841b6628183867e84601ce605d610
BUG: 1215571
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10757
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit fce954f52549328e31e0a34f69c8a63f1c28e2ec
Author: Meghana M <mmadhusu@redhat.com>
Date: Thu Jun 18 06:39:41 2015 +0530
common-ha : Fixing add node operation
Resource create for the added node referenced a variable
new_node that was never passed. This led to a wrong schema
type in the cib file and hence the added node always ended
up in failed state. And also, resources were wrongly
created twice and led to more errors. I have fixed the variable
name and deleted the repetitive invocation of the recreate-resource
function.
The new node has to be added to the existing ganesha-ha config
file for correct behaviour during subsequent add-node operations.
This edited file has to be copied to all the other cluster nodes.
I have added a fix for this as well.
Change-Id: Ie55138e2657d22298d89db1c08f2e17930686bd6
BUG: 1233246
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11316
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 596ec46f1aab9f377c0ef03b10aa1be0fc47af86
Author: vmallika <vmallika@redhat.com>
Date: Thu Jun 18 14:30:16 2015 +0530
quota/marker: fix mem-leak, free contribution node
When removing contribution xattr, we also need to free
contribution node in memory
Change-Id: I5fe97813a8f39e2f00401976046bd280f2eea54d
BUG: 1207735
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11311
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit a6c59793ab76e662976390517b46879f956b6713
Author: Sakshi <sabansal@redhat.com>
Date: Fri Jun 5 13:48:09 2015 +0530
dht : Error value check before performing rebalance complete
Change-Id: I7a0cd288d16f27b887c7820162efdbe99a039d95
BUG: 1188242
Signed-off-by: Sakshi <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/11097
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit e367aca9ac3014969388fd609831e0a3c6a619e9
Author: anand <anekkunt@redhat.com>
Date: Wed Jun 17 16:11:48 2015 +0530
glusterd: Removing sync lock and unlock inside rcu read critical section
Issue : Glsuterd was crashing during peer probe.
RCA : In glusterd, we are using big lock which is implemented based on sync
task frame work for thread synchronization, sync task frame work swap the threads
if there is no worker pool threads available. Due to this rcu lock and rcu unlock
was happening in different threads (urcu-bp will not allow this), resulting into
glusterd crash.
fix : Removing sync lock and unlock inside rcu read critical section, which was left out by
http://review.gluster.org/#/c/10285/ patch.
Change-Id: Id358dfcc797335bcd3b491c3129017b2caa826eb
BUG: 1232693
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/11276
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit f28f72c955f269f58a120c9f3ba69a01192f63e5
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jun 16 09:33:48 2015 -0400
common-ha: cluster setup issues on RHEL7
* use --name on RHEL7 (later versions of pcs drop --name) we guessed
wrong and did not get the version that dropped use of --name option
* more robust config file param parsing for n/v with ""s in the value
after not sourcing the config file
* pid file fix. RHEL6 init.d adds -p /var/run/ganesha.nfsd.pid to
cmdline options. RHEL7 systemd does not, so defaults to
/var/run/ganesha.pid.
Change-Id: I575aa13c98f05523cca10c55f2c387200bad3f93
BUG: 1229948
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11257
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit f2369cb75f8a9f82234cdff02436365d9185258a
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Jun 18 16:44:55 2015 +0200
cluster/ec: Avoid parallel executions of the same state machine
In very rare circumstances it was possible that a subfop started
by another fop could finish fast enough to cause that two or more
instances of the same state machine be executing at the same time.
Change-Id: I319924a18bd3f88115e751a66f8f4560435e0e0e
BUG: 1233258
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/11317
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 21c512f5f88ada5da56f9af9afe2197f1315f5f5
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jun 17 17:05:22 2015 +0530
tools/glusterfind: Fail glusterfind creation if volume is offline
Following two fixes are done.
1. Fail glusterfind session creation if volume is not online
even before session directories are created. This avoids
'glusterfind list' to pick the session directories and show
status as 'Session Corrupted'.
2. Check of '!Started' instead of wether the volume is 'Stopped'.
It covers all the cases.
Change-Id: I3e9cb384d978ada28f508c07e37d6ceb2272a731
BUG: 1232729
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11278
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 467dd1de0f05b32daf889e47eeb80be382c9c509
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Jun 18 16:23:50 2015 +0530
cluster/dht: Fix Null pointer dereference while logging
Change-Id: I1ea358b83267b0bcdf654ce18fe881fd4a6bf08d
BUG: 1233139
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/11313
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 92ac3494c29eb51b66b280024ce3c6a4e631a715
Author: vmallika <vmallika@redhat.com>
Date: Wed Jun 17 10:33:13 2015 +0530
quota: fix double accounting with rename operation
When a rename operation is performed, we are renaming
the file first and performing remove-xattr when reducing
the contri size from parents.
This remove-xattr fails as the file is alreday renamed,
this failure causes reduce-parent-size to abort resulting
in double quota accounting
This patch fixes the problem. We don't need to perform remove-xattr
operation on a file when performing reduce-parent-size txn as this
will be alreday done before starting reduce-parent-size txn
Change-Id: If86e3dbb0233f6deaaa90bee72cb0ec1689c7325
BUG: 1232572
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11264
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit b50b3d66215de7c3e42309c50db3ee67ccf22dd3
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Jun 17 10:48:03 2015 -0400
common-ha: cluster HA setup sometimes fails
the "s in the VIP_foo="x.x.x.x" lines are problematic now that the
config file isn't sourced.
Revised to also handle names containing '-', e.g. host-11, and FQNs,
e.g. host-11.lab.gluster.org
Change-Id: I1a52afbf398a024cdff851d0c415d8363f699c90
BUG: 1232001
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11281
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 7872051e15f2c6ec8642b38b139671a5b41ea2f5
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Thu Apr 30 16:57:00 2015 +0530
quota/glusterd: porting to new logging framework
Change-Id: I879a181b6d6b97119a6b4fab90a12b8386635383
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/10473
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
commit 840e233e52ff451462c4de61599c702b6eeee65b
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Tue May 19 15:34:43 2015 +0530
fd,inode/libglusterfs : porting to a new logging framework
Change-Id: I4beba3b50456f802824374b6e3fa8079d72f2c00
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/10825
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 45a35dc434bf5d1ce84e8fa9a7962415f6042e71
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Jun 15 17:20:46 2015 +0530
glusterd: Fix snapshot of a volume with geo-rep
Problem:
Snapshot fails for a volume configured with geo-rep
if geo-rep is created with root user with the following
syntax.
gluster vol geo-rep <master_vol> root@<slave_host>::<slave_vol>
It works fine if created with following syntax.
gluster vol geo-rep <master_vol> <slave_host>::<slave_vol>
Cause:
Geo-rep maintains persistent dictionary of slave associated
with master volume. The dictionary saves the slave info
along with 'root@' as sent from cli.
Snapshot while constructing the working dir path to copy
configuration files, constructs using this dictionary.
But the actual working dir is created with out considering
'root@'. Hence the issue.
Fix:
Fix is done at two layers.
1. Parse and negelect 'root@' in cli itself.
2. For existing geo-rep sessions and upgrade scenarios,
parse and neglect 'root@' in snapshot code as well.
Change-Id: If4e04f7f776ef71df4dd1e7e053ef75db98762b2
BUG: 1231789
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11233
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit d88367866a7c7f79ab043dc2df4ac973c19bffde
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Jun 17 14:39:26 2015 +0530
libgfchangelog: Fix crash in gf_changelog_process
Problem:
Crash observed in gf_changelog_process and
gf_changelog_callback_invoker.
Cause:
Assignments to arguments passed to thread is done
post thread creation. If the thread created gets
scheduled before the assignment and access these
variables, it would crash with segmentation fault.
Solution:
Assignments to arguments are done prior to the thread
creation.
Change-Id: I6afc8ccedd050cf4b50b967fef8287a0c834177b
BUG: 1232666
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11273
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 704fb35d0ce2bd96997295be9d053bb86e5d38c4
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Tue May 19 11:45:06 2015 +0530
libglusterfs: fix uninitialized argument value
common-utils.c:2871:17: warning: Function call argument is an uninitialized
value gf_log ("glusterfs", GF_LOG_DEBUG, "lower: %d, higher:%d",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Change-Id: Iffde527a392afe783908aee12040d555c77c6983
BUG: 1222769
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/10814
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5085a46d0b3bbb4529999717df1cb3e5250116f5
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Tue May 19 15:28:30 2015 +0530
common-utils/libglusterfs : Porting to a new logging framework
Change-Id: Iee1c083774c988375a7261cfd6d510ed4c574de2
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/10824
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit e6f6f109678d778294ab1b33a1bc088b7d7abd08
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Jun 13 17:33:14 2015 +0530
cluster/dht: Prevent use after free bug
Change-Id: I2d1f5bb2dd27f6cea52c059b4ff08ca0fa63b140
BUG: 1231425
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11209
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 99f084752908dc473e168f8008ced5592fbbb1e7
Author: Hari Gowtham <hgowtham@dhcp35-85.lab.eng.blr.redhat.com>
Date: Wed May 27 13:17:30 2015 +0530
Porting new log messages for posix
Change-Id: I29bdeefb755805858e3cb1817b679cb6f9a476a9
BUG: 1194640
Signed-off-by: Hari Gowtham <hgowtham@dhcp35-85.lab.eng.blr.redhat.com>
Reviewed-on: http://review.gluster.org/9893
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 48a74ba6837f7f331a16bf2f9d5373aa8ad832c7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Jun 3 12:03:05 2015 +0530
tests: rebalance completed should only check the status for completed
Change-Id: I1abc91cefaf16d1c8351f35e951c26078ef90544
BUG: 1227590
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11055
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 0eced667196bc569bc4311152e209665aafa07da
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue May 19 15:01:08 2015 +0530
rpc: fix possible deadlock left behind in d448fd1
See http://review.gluster.org/9613 for more details.
Change-Id: I05ac0267b8c6f4e9b354acbbdf5469835455fb10
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/10821
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit eb187a021bef13dae95181ced28949220ea0edd9
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jun 15 15:29:41 2015 -0400
common-ha: cluster HA setup sometimes fails
the "s in the VIP_foo="x.x.x.x" lines are problematic now that the
config file isn't sourced.
(A short term work-around is to simply eliminate them.)
Change-Id: I65f375f2d3b8453adb45dc3dbbc7d3fb07cf85d0
BUG: 1232001
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11237
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 97401edc3f4143a7c25c6087bdf62b05b876dca3
Author: Meghana M <mmadhusu@redhat.com>
Date: Mon Jun 15 08:43:44 2015 +0000
NFS-Ganesha: Automatically export vol that was exported before vol restart
Consider a volume that is exported via NFS-Ganesha. Stopping this
volume will automatically unexport the volume. Starting this volume
should automatically export it. Although the logic was already there,
there was a bug in it. Fixing the same by introducing a hook script.
Also with the new CLI options, the hook script S31ganesha-set.sh
is no longer required. Hence, removing the same.
Adding a comment to tell the user that one of the CLI
commands will take a few minutes to complete.
Change-Id: Ibff769ca04fef0c2a129c83fe31fc9c869350e8d
BUG: 1231738
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11247
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 3fec5ae7cfdd0bd815f324dbf9cc85593404a6be
Author: Shreyas Siravara <sshreyas@fb.com>
Date: Fri Jun 12 13:11:35 2015 -0700
nfs: Authentication performance improvements
When file operations are sent to the NFS server, authorized filehandles
are cached using the exportid, mountid, gfid and host as the key to the
cache. This meant that any file OR directory will always fail on the
*first* fop to that filehandle since the cache used the gfid as part of
the key to the cache. However, if an export is authorized, this
effectively means that ALL subdirectories and files in the export
directory are authorized per the permissions of the export. This results
slow times to walking a directory structure over an NFS mount.
Change-Id: Iad811ad7255b454d1712e75a637478401d40791e
BUG: 1232165
Signed-off-by: Shreyas Siravara <sshreyas@fb.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11245
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 430488ebac14c1d0caf01ce1dae52d6db3ff6fea
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Jun 3 10:40:36 2015 +0530
tests: fix spurious failure in bug-857330/xml.t
get-task-status () used to always return 0 *until and unless* the CLI command
itself fails which is unlikely. However if the CLI command fails due to some
reason EXPECT_WITHIN will abort.
Change-Id: Ibe54dcdccc26b3ee003677fc3516cfed98b5c06f
BUG: 1227590
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11054
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 72a56800acb5e523b26ec4747fb1c551f7fbc019
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Jun 4 10:07:38 2015 +0530
features/bitrot: fix fd leak in truncate (stub)
The need to perform object versioning in the truncate() code path
required an fd to reuse existing versioning infrastructure that's
used by fd based operations (such as writev(), ftruncate(), etc..).
This tempted the use of anonymous fd which was never ever unref()'d
after use resulting in fd and/or memory leak depending on the code
path taken. Versioning resulted in a dangling file descriptor left
open in the filesystem effecting the signing process of a given
object (no release() would be trigerred, hence no signing would be
performed). On the other hand, cases where the object need not be
versioned, the anonymous fd in still ref()'d resulting in memory
leak (NOTE: there's no "dangling" file descriptor in this case).
Change-Id: I29c3d2af9bbc5cd4b8ddf38954080e3c7a44ba61
BUG: 1227996
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11077
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 8778ca8626cc4996261f0d68002ca1626f9fcd4b
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Mon Jun 8 13:01:44 2015 +0530
bitrot/glusterd: gluster volume set command for bitrot should not supported
Currently gluster volume set <VOLNAME> bitrot succeeds. gluster volume
set command for bitrot is not supported.
Gluster should only accept gluster volume bitrot <VOLNAME> * commands.
Change-Id: I5ff4b79f202ad018c76188f19d6311aad0d7c166
BUG: 1229134
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/11118
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Atin Mukherjee <amukherj@redhat.com>
commit 70d51da06e2703be1faf09ca043437782c6188b8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jun 1 13:34:33 2015 +0530
storage/posix: Handle MAKE_INODE_HANDLE failures
Change-Id: Ia176ccd4cac82c66ba50e3896fbe72c2da860c20
BUG: 1212110
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11028
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit 2c368ebb337f33bf23c57509b7bed7e5c88c4ad1
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Tue Mar 17 13:16:06 2015 +0530
ops/glusterd: Porting messages to new logging framework
Change-Id: Iafeb07aabc1781d98f51c6c2627bf3bbdf493153
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9905
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit e37482c831304e8b8a904e956c7b198a8503b2f0
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Fri Mar 13 16:55:17 2015 +0530
rebalance,store,glusterd/glusterd: porting to new logging framework
Change-Id: I231b79e3414e60fe67cde577dd585cce83c8bfad
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9877
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 772386f4a7044849e984d7c585bcd9f419ffa3a1
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed May 27 17:00:36 2015 +0530
features/bit-rot: check for both inmemory and ondisk staleness
* Let bit-rot stub check both on disk ongoing version, signed version xattrs and
the in memory flags in the inode and then decide whether the inode is stale or
not. This information is used by one shot crawler in BitD to decide whether to
trigger the sign for the object or skip it.
NOTE: The above check should be done only for BitD. For scrubber its still the
old way of comparing on disk ongoing version with signed version.
* BitD's one shot crawler should not sign zero byte objects if they do not contain
signature. (Means the object was just created and nothing was written to it).
Change-Id: I6941aefc2981bf79a6aeb476e660f79908e165a8
BUG: 1224611
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/10947
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 148ecf4758f96e510b31264262e5f68cc3448f1c
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Fri Jun 12 19:25:26 2015 +0530
NFS-Ganesha : Return corect return value
When any of the nodes in the trusted pool is not listed
in the cluster node list, it receives a wrong return
value. And commit fails on that host. Fixing the same.
Change-Id: Ib208dae7497800cc48b7f7a77f5e708f6c11e676
BUG: 1231257
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11205
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c5f98e7a3c5e2a114a4163bf71db4ee2cc360da7
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Mon Jun 15 16:42:21 2015 +0530
common-ha : Clean up cib state completely
Clean up cluster state on all the machines during tear down.
Change-Id: If9ca65b6ca8790ac97311f33359e28558e90c557
BUG: 1228415
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11231
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 762fec1aca839b8984813fa3b46f8e00d8ed5802
Author: vmallika <vmallika@redhat.com>
Date: Mon Jun 15 11:21:12 2015 +0530
quota: don't log error when disk quota exceeded
When disk quota exceeded, quota enforcer logs
alert message, so no need to log error message
as this can fill up the log file
Change-Id: Ia913f47bc0cedb7c0a9c611330ee5124d3bb6c9d
BUG: 1229609
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11135
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 24518ef19cf10358e4e3306168adb11c6b0b432c
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Apr 6 16:21:43 2015 +0530
protocol/client : porting log messages to new framework
Change-Id: I9bf2ca08fef969e566a64475d0f7a16d37e66eeb
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/10042
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 61d0d08390d0c22f5fbadeb5949d04fe7e34d190
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Fri Jun 5 13:58:28 2015 +0530
features/bitrot: tuanble object signing waiting time value for bitrot
Currently bitrot using 120 second waiting time for object to be signed
after all fop's released. This signing waiting time value should be tunable.
Command for changing the signing waiting time will be
#gluster volume bitrot <VOLNAME> signing-time <waiting time value in second>
Change-Id: I89f3121564c1bbd0825f60aae6147413a2fbd798
BUG: 1228680
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11105
commit 1cf808c049627551a572a05ebe8f99e6483de913
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed Jun 10 15:11:39 2015 +0530
glusterd: subvol_count value for replicate volume should be calculate correctly
glusterd was crashing while trying to remove bricks from replica set
after shrinking nx3 replica to nx2 replica to nx1 replica.
This is because volinfo->subvol_count is calculating value from old
replica count value.
Change-Id: I1084a71e29c9cfa1cd85bdb4e82b943b1dc44372
BUG: 1230121
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/11165
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 72bb43ed95486e722b4d4de5a8a3e72151bdc962
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Thu Mar 12 16:55:20 2015 +0530
handshake,locks,mountbroker,syncop/glusterd:New logging framework
Change-Id: If491a6945b7a0afa10165ff9f9874a244aece36f
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9864
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit e7ef7aee1f83c0bb6036c48824f19c959ceece0d
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Mon Mar 9 16:59:54 2015 +0530
glusterd: Porting messages to new logging framework.
Change-Id: I56ced6fca0246c230cc389132c47a0f60472ed0c
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9836
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bcf20c19c6cd4338f7958b8666d40d8c2687bbed
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jun 9 23:11:13 2015 +0530
tests: test cluster lock in heterogenious cluster
Change-Id: I421f50aeb89213d036b4b40f20a8e0d6bd78d60b
BUG: 1229825
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11143
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 08c45b4bd7322c4c922736b4ea61dc2b4521feee
Author: Susant Palai <spalai@redhat.com>
Date: Mon May 25 16:52:10 2015 +0530
features/quota: port QUOTA messages to new logging framework
Change-Id: I5e3df8860ea35bce14a802391be9b22ad64f1ad4
BUG: 1075611
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/7574
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 0eff67b100f13e974edd44c9f4f26f897f97ef57
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jun 12 12:31:19 2015 +0200
upcall: prevent busy loop in reaper thread
http://review.gluster.org/10342 introduced a cleanup thread for expired
client entries. When enabling the 'features.cache-invalidation' volume
option, the brick process starts to run in a busy-loop. Obviously this
is not intentional, and a process occupying 100% of the cycles on a CPU
or core is not wanted.
Change-Id: I453c612d72001f4d8bbecdd5ac07aaed75b43914
BUG: 1200267
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11198
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 230dc8a0ad62e0a1362aae1a95b4325549b40d7a
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Tue Mar 17 18:03:36 2015 +0530
handler, messages/glusterd: Porting to new logging framework
Change-Id: If67230445678dd895d69f18c9982c3f0fda62dbd
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9910
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit e2b754ddff72279878319a960271c73465972f68
Author: Milind Changire <mchangir@redhat.com>
Date: Sat Jun 13 12:31:55 2015 +0530
tools/glusterfind: print message for good cases
Added messages for printing status of good or default cases
for 'create', 'list', 'post' and 'delete' commands
Change-Id: Ie983bff7f5a66f118de06c225166ff6bee870438
BUG: 1230017
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/11208
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit aee7cf20820ecefb9fac1290ac573832997201e1
Author: Susant Palai <spalai@redhat.com>
Date: Thu Jun 4 22:37:11 2015 +0530
glusterd: Buffer overflow causing crash for glusterd
Problem: In GLUSTERD_GET_DEFRAG_PROCESS we are using PATH_MAX (4096)
as the max size of the input for target path, but we have allocated
NAME_MAX (255) size of buffer for the target.
Now this crash is not seen with source install, but is seen with RPMS.
The reason is _foritfy_fail. This check happens when _FORTIFY_SOURCE
flag is enabled. This option tries to figure out possible
overflow scenarios like the bug here and does crash the process.
Change-Id: I26261be85936d2e94a526fdcaa8d3249f8af11c3
BUG: 1228093
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/11090
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 8331ffcbd55f4bc23b2e5b842d8b070388e95ad2
Author: M S Vishwanath Bhat <vbhat@redhat.com>
Date: Thu Jun 4 17:52:00 2015 +0530
gverify: Adding StrictHostKeyChecking=no for ssh verification
Before actually checking the compatibility between master and
slave, gverify checks if there is a passwordless ssh connection
between master to slave. So if the entry of the slave was not
present in 'known_hosts' file in master gverify used to complain
that passwordless ssh has not been setup. This used to happen
even if there is a passwordless ssh between master to slave.
This patch fixes the above problem by using StrictHostKeyChecking=no
while doing ssh to slave.
Change-Id: I953c278e411ad6bc1dd1966ea6d895b05f890492
BUG: 1228696
Signed-off-by: M S Vishwanath Bhat <vbhat@redhat.com>
Reviewed-on: http://review.gluster.org/11106
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 0e7a5281464bd577b71a55bf9d3eed0b69dab2b8
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jun 12 17:19:55 2015 +0530
spec/geo-rep: Add rsync as dependency for georeplication rpm
If rsync is not installed, Geo-rep will go faulty on started.
Added rsync as dependency for georep rpm
Change-Id: I49614957ccde47645185a65191d6d7baf1cc826c
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1231205
Reviewed-on: http://review.gluster.org/11201
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 48e2570eb6611d1b0915ae997ac06286b713132d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jun 11 14:44:48 2015 +0530
cluster/ec: Prevent Null dereference in dht-rename
Change-Id: I3059f3b577f550c92fb77c6b6b44defd0584cd2e
BUG: 1230647
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11178
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0d51b782f1d8a501e48344da37cf239d9af31955
Author: Milind Changire <mchangir@redhat.com>
Date: Fri Jun 12 12:48:27 2015 +0530
tools/glusterfind: ignoring deleted files
OSError and IOError exceptions were being thrown if files
were deleted after session was created and a subsequent
glusterfind pre was attmepted. glusterfind now detects
this scenario and safely ignores these changes to the
file-system. We also avoid recording deleted file paths
into database in the case where gfid to path resolution
cannot be performed for deleted files.
Also, we now turn on volume option to capture delete paths.
Change-Id: Iaf3883463f5e64643497bd77229ad80a9b2d5da5
BUG: 1228111
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/11194
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit ac1bdfd37d3dc79793657a11d0aafdc88cb66497
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jun 9 10:44:44 2015 +0530
features/changelog: Do htime setxattr without XATTR_REPLACE flag
HTIME_KEY marks the last changelog rolled over. The xattr is
maintained on .glusterfs/changelog/htime/HTIME.TSTAMP file.
On every rollover of the changelog file, the xattr is updated.
It is being updated with XATTR_REPLACE flag as xattr gets
created during changelog enable. But it is once found that
the xattrs on the file is cleared and is not reproduced later
on. This patch protects that case, if it happens by setting
xattr without XATTR_REPLACE flag in failure case.
The reason behind doing this in failure case is not to mask
the actual cause of xattrs getting cleared. This provides
the log message if the original issue still exists but the
consequential effects are fixed.
Also changed the log messages to depict the events happened
during changelog enable.
Change-Id: I699ed09a03667fd823d01d65c9c360fa7bc0e455
BUG: 1230015
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/11150
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit f06105b8b6c8012d714b36cb43d9366325831836
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Fri Mar 20 12:04:32 2015 +0530
glusterd/geo-rep : porting log messages to a new framework
Change-Id: I1f1b99822c2b301d68eaf392af4bbb475151e2c5
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9952
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit aa23c20874a4abbde4c1eac8c8dddb9fc5420c74
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jun 10 14:47:21 2015 +0530
tools/glusterfind: Cleanup session dir after delete
Sessions directories are created in
/var/lib/glusterd/glusterfind/<SESSION>/<VOLUME>, only <VOLUME>
dir is created since same session name can exists for two volumes.
Now cleanup is added, <SESSION> dir will be removed if <SESSION>
contains only one Volume.
Change-Id: I236393659e63eb98342570e0255739f4adea4491
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1230111
Reviewed-on: http://review.gluster.org/11157
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 896a845043f9910253eb9cc3bb37e3863f7fe527
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jun 10 14:14:25 2015 +0530
geo-rep: Validate use_meta_volume option
Added validation for use_meta_volume option.
Change-Id: I64cd9cb4bf383c7267638cab3837fd0cf89071c7
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1230090
Reviewed-on: http://review.gluster.org/11156
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit cc95d4df8b59b46c9606b7a7307ee2d191033c19
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed May 27 18:05:35 2015 +0530
tools/glusterfind: Cleanup glusterfind dir after a volume delete
If `glusterfind delete` command was not run before volume delete, stale
session directories exists in /var/lib/glusterd/glusterfind directories.
Also shows these sessions in `glusterfind list`
When Volume is deleted, Post hook will be run which cleans up the stale
session directories
BUG: 1225465
Change-Id: I54c46c30313e92c1bb4cb07918ed2029b375462c
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10944
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e10872102997af1c63a5cc3ff1ab81c90b54e293
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Wed Mar 18 15:17:45 2015 +0530
sm/glusterd: Porting messages to new logging framework
Change-Id: I391d1ac6a7b312461187c2e8c6f14d09a0238950
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9927
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 06dbc2e6ba2621828e404b04474db7046a653ea8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jun 4 08:21:59 2015 +0530
features/qemu-block: Add comment about root_inode handling
This is handling the comment on 3.7 backport
http://review.gluster.com/11047
Change-Id: I253a8e0bfebde63f25c839efd55ed3cc30e6cd9b
BUG: 1226276
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11076
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
commit 04ba0fb9a5c9b018d4b20464a32f2e41cf509e06
Author: Nandaja Varma <nvarma@redhat.com>
Date: Tue Feb 3 16:35:33 2015 +0530
libglusterfs: Fixing insecure temp file coverity issue
Coverity CID: 1124835
Change-Id: I7e87f2b3bad35cf8a9c64c8502de23662d9f677f
BUG: 789278
Signed-off-by: Nandaja Varma <nvarma@redhat.com>
Reviewed-on: http://review.gluster.org/9565
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sakshi Bansal
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
commit 5bbbcd3d56a2094b487489200f7d3b581dd7da1b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jun 1 14:02:58 2015 -0400
common-ha: handle long node names and node names with '-' and '.' in them
sourcing the /etc/ganesha/ganesha-ha.conf file seemed like a simple
and elegant solution for reading config params, but bash variable names
do not allow '-' and '.' in them.
Also fix incorrect path in shared volume mount
Change-Id: I40140e5da0903221efd316de94dce40229263e15
BUG: 1225572
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11035
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 6ec969a92fc194ac43c24f044c77bc0fd94eaee0
Author: meghana <mmadhusu@redhat.com>
Date: Fri Jun 5 02:56:26 2015 +0530
common-ha : Clean up persistent cib state
Pacemaker saves old configurations in the
directory, "/var/lib/pacemaker/cib". It's
good to clean up this directory during teardown so that
old data doesn't show up the next time.
Change-Id: If0f413ba2da599dd6672b51e60e1d35e674d576b
BUG: 1228415
Signed-off-by: meghana <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/11093
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6b82c9a0cafc298cae7a28852a2407d2f72113d7
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jun 10 15:26:47 2015 +0530
tools/glusterfind: Fix GFID to Path conversion for dir
For Directories, GFID to Path conversion was fine, but wrong
filter was used while updating to db.
Change-Id: Id588adbb25ff5fd357f8cc2d5485bd2eb4a52b65
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1230127
Reviewed-on: http://review.gluster.org/11158
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2c88c3c8a4dab1049f537c98aabeb5ae0679e323
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Thu May 28 11:54:04 2015 +0530
geo-rep: ignore symlink and harlink errors in geo-rep
Ignore logging in case of symlink and hardlink creation
errors, as these are safe errors with respect to
geo-replication.
Change-Id: I3b863fb03ae23dbea907e4dd9477ff85feecad70
BUG: 1225571
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/10957
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bfa9d030cffd74b4c3d5089ead1f2e1d9478225b
Author: Milind Changire <mchangir@redhat.com>
Date: Thu May 28 11:22:50 2015 +0530
tools/glusterfind: verifying volume is online
Volume needs to be online (Started) to perform meaningful
operations i.e. for "create" and "pre". This is now verified.
Change-Id: I207cf1f5e30be0f67a776b866349b59d70a13984
BUG: 1225564
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/10955
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit d2d74112598afa75d87841bb5ffd090babed19b6
Author: Joseph Fernandes <josferna@redhat.com>
Date: Sat Jun 6 10:28:51 2015 +0530
tier/dht: Fixing non atomic promotion/demotion w.r.t to frequency period
This fixes the ping-pong issue i.e files getting demoted immediately
after promition, caused by off-sync promotion/demotion processes.
The solution is do promotion/demotion refering to the system time.
To have the fix working all the file serving nodes should have
thier system time synchronized with each other either manually or
using a NTP Server.
NOTE: The ping-pong issue can re-appear even with this fix, if the admin
have different promotion freq period and demotion freq period, but this
would be under the control of the admin.
Change-Id: I1b33a5881d0cac143662ddb48e5b7b653aeb1271
BUG: 1218717
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/11110
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 43cd26543f0a423f01c10e4342728a323351965c
Author: Dan Lambright <dlambrig@redhat.com>
Date: Thu Jun 4 14:00:34 2015 -0400
cluster/tier: account for reordered layouts
For a tiered volume the cold subvolume is always at a fixed
position in the graph. DHT's layout array, on the other hand,
may have the cold subvolume in either the first or second
index, therefore code cannot make any assumptions. The fix
searches the layout for the correct position dynamically
rather than statically.
The bug manifested itself in NFS, in which a newly attached
subvolume had not received an existing directory. This case
is a "stale entry" and marked as such in the layout for
that directory. The code did not see this, because it
looked at the wrong index in the layout array.
The fix also adds the check for decomissioned bricks, and
fixes a problem in detach tier related to starting the
rebalance process: we never received the right defrag
command and it did not get directed to the tier translator.
Change-Id: I77cdf9fbb0a777640c98003188565a79be9d0b56
BUG: 1214289
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11092
commit b7547ca7a9a3bf4433a331f91bd90dc556a277dc
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Mon Mar 23 11:36:37 2015 +0530
utils/glusterd: Porting to new logging framwork
Change-Id: Iacb30eb675693bcdb3ef9de8e7f43892c5d79f6d
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9967
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit d28c5c98580fb37f1ef3cfb5e17374c5da72f2fe
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Tue Jun 9 17:49:58 2015 +0530
features/changelog: Avoid setattr fop logging during rename
Problem:
When a file is renamed and the (renamed)file's Hashing
falls into a different brick, DHT creates a special file(linkto file)
in the brick(Hashed subvolume) and carries out setattr operation
on that file.
Currently, Changelog records this(setattr) operation in Hashed
subvolume. glusterfind in turn records this operation
as MODIFY operation.
So, there is a NEW entry in Cached subvolume and MODIFY entry
in Hashed subvolume for the same file.
Solution:
Avoid logging setattr operation carried out, by
marking the operation as internal fop using xdata.
In changelog translator, check whether setattr is set
as internal fop and skip accordingly.
Change-Id: I21b09afb5a638b88a4ccb822442216680b7b74fd
BUG: 1230007
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/11137
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 4dd1ec9edd09b1b403a94ca8d04448d0976a0336
Author: Sachin Pandit <spandit@redhat.com>
Date: Thu Jun 4 11:01:38 2015 +0530
features/marker : Pass along xdata to lower translator
The problem was in marker xlator, where during
rename a NULL value is passed during STACK_WIND.
Marker needs to pass the xdata un-modified to next
translator if marker does not rely on that.
Change-Id: I9e47e504fd241263987645abfed7ca13c0d54a80
BUG: 1228492
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/11089
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit f436637ff6c92212fb7a31cb4bb3c54b8b6f37ae
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jun 9 16:32:37 2015 +0200
build: improve detection of new OpenSSL features
Building on Mac OS X revealed that the current check for
CRYPTO_THREADID_set_callback() availability in OpenSSL is not correct.
There also does not seem to be a guarantee that TLSv1_2_method() is
available when TLS1_2_VERSION is #define'd.
Change-Id: I21508065fc181a1c74bee4fd6d23bb5bdf7cea7a
BUG: 1222317
Original-author: Kaleb KEITHLEY <kkeithle@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11140
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit cddb47b331cffc7d76fa8057957493b2e92eb879
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Jun 9 18:00:57 2015 +0530
snapshot/scheduler: Reload /etc/cron.d/glusterfs_snap_cron_tasks when shared storage is available
If shared storage is not accessible, create a flag in /var/run/gluster/
So that when /etc/cron.d/glusterfs_snap_cron_tasks is
available again, the flag will tell us, to reload
/etc/cron.d/glusterfs_snap_cron_tasks
Change-Id: I41b19f57ff0b8f7e0b820eaf592b0fdedb0a5d86
BUG: 1218573
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11139
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 6976f4f29fe3d794a119a6fa4bd9ff791e94d9f3
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Jun 4 14:14:14 2015 +0530
glusterd/tier: glusterd crashed with detach-tier commit force
glusterd crashed when doing "detach-tier commit force" on a
non-tiered volume.
Change-Id: I884771893bb80bec46ae8642c2cfd7e54ab116a6
BUG: 1228112
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11081
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Joseph Fernandes
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit bc747fec8e8d5a4f90e14b6a9e0157e4a4eb655f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jun 10 10:30:03 2015 +0530
cluster/ec: Wind unlock fops at all cost
Problem:
While files are being created if more than redundancy number of bricks
go down, then unlock for these fops do not go to the bricks. This will
lead to stale locks leading to hangs.
Fix:
Wind unlock fops at all costs.
Change-Id: I50a87e8b4d6d2dde5bf7405b82e3aeecd95ad00e
BUG: 1220348
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11152
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit bea6d24bd57f52a351cfbfa8ada173c7c9b49e15
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jun 5 16:38:30 2015 +0200
logging: log "Stale filehandle" on the client as Debug
There are valid use-cases where a "Stale filehandle" is expected. One of
these is deleting a file through NFS-Ganesha. When the "filename" is
deleted, Ganesha will stat the file-handle to update its attributes. The
file-handle would still be valid in the case where there are hardlinks.
There is no need to log "Stale filehandle" as Warning. It is perfectly
fine to have this logged as Debug.
Change-Id: Ib9006d95a5d1f7dd394bf5d5994ad70740ad4ab2
BUG: 1228731
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11107
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 0f576b3b4f7d951f7d39c582c88e0d3df2f3a97f
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Jun 9 17:49:23 2015 +0530
snapshot/scheduler: Check if GCRON_TASKS exists before accessing it's mtime
Change-Id: I873c83d21620527b20d7de428d11582c5499d1af
BUG: 1228613
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11138
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 38050a1be73e838d6f009acfbd1aef04a04ec662
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Wed May 27 15:20:59 2015 +0530
changetimerecorder : Porting to new logging framework
Change-Id: I66e7ccc5e62482c3ecf0aab302568e6c9ecdc05d
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/10938
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
commit a3f3ab3937ad49fb5a3acbb1cf6e868602cb1800
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Tue May 19 14:55:38 2015 +0530
gfdb/libglusterfs : Porting to a new logging framework
Change-Id: I61874561fdf2c175d2b3eec0c85c25f12dc60552
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/10819
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joseph Fernandes
commit 7e8b3815e2897a8788c825aec7384bd4dee2f80c
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Tue Feb 3 13:05:02 2015 +0530
glusterd: coverity fix for string overflow
Coverity CID: 1222523
Coverity CID: 1210990
Coverity CID: 1229877
Coverity CID: 1229876
Coverity CID: 1124855
Change-Id: Iba615724909216f923074cb4585940b919d02166
BUG: 789278
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/9555
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 128f5eaec84d270150a6aadb45acfa535e917c04
Author: arao <arao@redhat.com>
Date: Wed Feb 11 16:59:10 2015 +0530
glusterd: Dereference after null check
CID: 1124588
CID: 1124589
CID: 1124590
CID: 1124591
Either the null pointer is dereferenced before the null check
or the check for null is unnecessary
Change-Id: I87c6b09a4b89c33afd402866e6e249fefb1330f0
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9636
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit b8c4a6488f39975748f92238fe4034a650a44b03
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon May 11 14:43:23 2015 +0530
tier/volume set: Validate volume set option for tier
Volume set option related to tier volume can only be set
for tier volume, also currently all volume set i for tier
option accepts a non-negative integer. This patch validate
both condition.
Change-Id: I3611af048ff4ab193544058cace8db205ea92336
BUG: 1216960
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10751
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Joseph Fernandes
commit f6a3bb954ba0f895232182ac8335504d89a76c3b
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Jun 4 17:17:13 2015 +0530
snapshot/scheduler: Handle OSError in os. callbacks
Handle OSError and not IOError in os. callbacks.
Change-Id: I2b5bfb629bacbd2d2e410d96034b4e2c11c4931e
BUG: 1218060
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11087
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 2206d105d6b8859bed7d177dd61c440d2789102a
Author: anand <anekkunt@redhat.com>
Date: Fri May 22 18:18:11 2015 +0530
libglusterfs: Enabling the fini() in cleanup_and_exit()
Problem 1 : glusterd was crashing due to race between clean up thread and rpc event thread.
Scenario:
As we can observed, X thread is in the process of exiting the process. It has already
run the exit handlers, which cleanup things that require cleaning up. This includes
liburcu resources. By the time Y thread called rcu_bp_register(), the liburcu resources
have been cleaned up. rcu_bp_register() tries to access these non-existent resources,
which leads to the segmentation fault.
Note1:
Crash happen when the process is almost at the point of stopping(exiting), it doesn't have any
serious impact to functionality apart from creating the core dump file and the log message.
Fix .Do proper clean up before calling exit().
Note2: Other xlator have clean up issues,so only glusterd clean up function invoked.
Note3: This patch also solve the selinux issue.
Problem 2 : glusterd runs as rpm_script_t when it's executed from the rpm scriptlet,files created
in this context are set as rpm_script_t, so glusterd unable to access these files when it runs
in glusterd_t context.
Fix: Fini clean up the files while glusterd exiting, so files are recreated by glusterd while
starting with proper SElinux context label.
Change-Id: Idcfd087f51c18a729bdf44a146f9d294e2fca5e2
BUG: 1209461
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/10894
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 280b928d6deabddf3a8c98e77c46aabb274b431b
Author: Shyam <srangana@redhat.com>
Date: Wed Jun 3 14:12:27 2015 -0400
cluster/dht: Increment op-version for lookup-optimize to 3.7.2
3.7.1 has already shipped, so carrying this configuration option
at that op-version will break compatibility. As a result bumping
this to 3.7.2.
Change-Id: I603d82184ec10d0ea3edf550490e960a8523d572
BUG: 1227894
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/11073
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 6aa36fdc6b9df0bd77d8c0ecc16634e404731efe
Author: Shyam <srangana@redhat.com>
Date: Fri Jun 5 16:37:08 2015 -0400
doc: Adding documentation for DHT lookup-optimize option
This is intended to be admin facing documentation, with some granular
details.
Change-Id: I379f8cea5375649fba915e907648e3a71344092d
BUG: 1228818
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/11109
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit e204c24b127171f4290ca55af3a6839e7284f4b7
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jun 4 11:25:35 2015 +0530
Upcall/cache-invalidation: Ignore fops with frame->root->client not set
Server-side internally generated fops like 'quota/marker' will
not have any client associated with the frame. Hence we need a
check for clients to be valid before processing for upcall cache
invalidation. Also fixed an issue with initializing reaper-thread.
Added a testcase to test the fix.
Change-Id: If7419b98aca383f4b80711c10fef2e0b32498c57
BUG: 1227204
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10909
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit ea6024a39794959cceff5ce1b0f651aade07716a
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Jun 7 21:32:32 2015 +0200
Tests portability: umount(8)
1) Avoid hangs on unmounting NFS on NetBSD
NetBSD umount(8) on a NFS mount whose server is gone will wait forever
because umount(8) calls realpath(3) and tries to access the mount before
it calls unmount(2). The non-portable, NetBSD-specific umount -R flag
prevent that behavior.
We therefore introduce UMOUNT_F, defined as "umount -f" on Linux and
"umount -f -R" on NetBSD to take care of forced unmounts, especially
in the NFS case.
2) Enforce usage of force_umount wrapper with timeout
Whenever umount is used it should be wrapped in force_umount with
tiemout handling. That saves us timing issues, and it handles the
NetBSD NFS case.
3) Cleanup kernel cache flush.
We used (cd $M0 && umount $M0 ) as a portable kernel cache flush
trick, but it does not flush everything we need on Linux. Introduce
a drop_cache() shell function that reverts to previously used
echo 3 > /proc/sys/vm/drop_caches on Linux, and keeps
(cd $M0 && umount $M0 ) on other systems.
BUG: 1129939
Change-Id: Iab1f5a023405f1f7270c42b595573702ca1eb6f3
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/11114
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 88a9b5d22cf80e229210734030e9ea365590de0b
Author: Mohamed Ashiq <ashiq333@gmail.com>
Date: Mon May 18 12:15:07 2015 +0530
libglusterfs: Introducing new logging message
Change-Id: I137f1b7805895810b8e6f0a70a183782bf472bf5
BUG: 1194640
Signed-off-by: Mohamed Ashiq <ashiq333@gmail.com>
Reviewed-on: http://review.gluster.org/9898
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 93e3827efd31fa511b6d50509e557bb91e4311a8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Jun 7 10:24:08 2015 +0530
cluster/ec: Prevent double unwind
Problem:
1) ec_access/ec_readlink_/ec_readdir[p] _cbks are trying to recover only from
ENOTCONN.
2) When the fop succeeds it unwinds right away. But when its
ec_fop_manager resumes, if the number of bricks that are up is less than
ec->fragments, the the state machine will resume with -EC_STATE_REPORT which
unwinds again. This will lead to crashes.
Fix:
- If fop fails retry on other subvols, as ESTALE/ENOENT/EBADFD etc are also
recoverable.
- unwind success/failure in _cbks
Change-Id: I2cac3c2f9669a4e6160f1ff4abc39f0299303222
BUG: 1228952
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11111
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 04e7d1b15adf3b636e5b383036cf3126edbfce4f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Jun 8 11:36:12 2015 +0530
cluster/afr: Do not attempt entry self-heal if the last lookup on entry failed on src
Test bug-948686.t was causing shd to dump core due to gfid being NULL.
This was due to the volume being stopped while index heal's in progress,
causing afr_selfheal_unlocked_lookup_on() to fail sometimes on the src brick
with ENOTCONN. And when afr_selfheal_newentry_mark() copies the gfid off the
src iatt, it essentially copies null gfid. This was causing the assertion
as part of xattrop in protocol/client to fail.
Change-Id: I237a0d6b1849e4c48d7645a2cc16d9bc1441ef95
BUG: 1229172
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11119
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7ac6070c38e0a935268bba498fe455a1a8d0da79
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu May 14 17:06:25 2015 +0530
Changing log level to DEBUG in case of ENOENT
Change-Id: I264e47ca679d8b57cd8c80306c07514e826f92d8
BUG: 1193388
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/10784
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 91ee89b964dd23d5283eb97414f088101e5af991
Author: anand <anekkunt@redhat.com>
Date: Fri Apr 10 16:41:25 2015 +0530
glusterd: Stop tcp/ip listeners during glusterd exit
Problem : Because of race between exit thread and rpc thread
causing the glusterd crash while glusterd exiting/stoping.
Fix : Stop tcp/ip socket listeners in cleanup_and_exit to
avoid new rpc events.
Change-Id: Ie9280c8c9d7c350a176529375d861432f3de94ac
BUG: 1209461
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/10197
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 0d09cdb75f7249b7b4cd256d41233547bdfc57d0
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Wed May 20 17:51:29 2015 +0530
gfid-access: Remove dead increment (dead store)
This patch remove stores to variables that are no longer live.
Change-Id: Ib6acd8c70cbb7ea875c01b7cfd6620ac1d641d36
BUG: 1223378
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/10841
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 9047f0293276e7a46630cbe74ad59617cbfa1148
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun May 31 21:50:21 2015 +0200
rpm: add option "--with debug" for rpmbuild/mock
When passing "--with debug" to mock or rpmbuild, the build process will
add the "--enable-debug" option to ./configure. This makes it easier
to build RPMs with debugging enabled.
Change-Id: Ie584a4a03525385b337bbf81e5093f2af1b0b780
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11020
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit da01ece46bb6cea40523399c367e1e4da28140af
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jun 4 09:52:51 2015 +0530
cluster/ec: Don't handle EC_XATTR_DIRTY in response
Problem:
ec_update_size_version expects all the keys it did xattrop with to come in
response so that it can set the values again in ec_update_size_version_done.
But EC_XATTR_DIRTY is not combined so the value won't be present in the
response. So ctx->post/pre_dirty are not updated in
ec_update_size_version_done. So these values are still non-zero. When
ec_unlock_now is called as part of flush's unlock phase it again tries to
perform same xattrop for EC_XATTR_DIRTY. But ec_update_size_version is not
expected to be called in unlock phase of flush because ec_flush_size_version
should have reset everything to zero and unlock is never invoked from
ec_update_size_version_done for flush/fsync/fsyncdir. This leads to stale lock
which leads to hang.
Fix:
EC_XATTR_DIRTY is removed in ex_xattrop_cbk and is never combined with other
answers. So remove handling of this in the response.
Change-Id: If0ea3efec3235a6e312465d8838585fbe752c7ea
BUG: 1227654
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11078
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1a4edf82550dcaaebcd6eaf5f1a717db4856cb2d
Author: Anuradha <atalur@redhat.com>
Date: Fri Jun 5 16:49:14 2015 +0530
heal : Do not invoke glfs_fini for glfs-heal commands
Change-Id: I2fa6789488c4ecebbed049f46c189441fba48535
BUG: 1228635
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/11103
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2e3ff267dcea3482e81891e3968243d6e17cc379
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri May 29 10:40:22 2015 +0530
glusterd/ afr: remove the readdir-failover option from rebalance process
Remove the "replicate*.readdir-failover=off" xlator option from
rebalance process' runner arguments because this is the default behaviour in
afr-v2. i.e. reaaddir failover happens only if it is a new readdir
(offset=0). 'Continuing'readdirs are always wound on the same child
where the first readdir had happened and if that child is down, the
readdir fails.
The option cannot be removed from glusterd_volopt_map because there is a
chance of ending up in peer rejected state in a heterogenous cluster
(typical upgrade scenario) due to volinfo checksum mismatch. TODO:come up with
some warning message to the user for such deprecated options if a volume
set is attempted.
Change-Id: I6a33dc9fae7cccea8c5fd3d9de40d88d13ad3689
BUG: 1225328
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10935
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 479aa4cf05248ca7ddccefff429e021a792a01d9
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Jun 2 15:01:53 2015 +0530
rpc: call transport_unref only on non-NULL transport
BUG: 1227583
Change-Id: Ifac4dd8c633081483e4eba9d7e5a89837b2a453a
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/11041
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 4d3c4539c8de74d5785e9b1d4fad879f0e87302a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jun 3 15:18:08 2015 +0530
snapshot: Fix finding brick mount path logic
Previously while finding brick mount paths
of snap volume's bricks, we were taking brick order
into consideration. This logic fails when a brick is
removed or a tier is added.
Hence modifying the logic to look for the first
occurence of the word "brick" in the brick path.
From there we iterate till we find a '/'. The string
till the first '/' after we encounter the word brick
is the brick mount path.
Change-Id: Ic85983c4e975e701cdfd4e13f8e276ac391a3e49
BUG: 1227646
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11060
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 25e0cb2f42cb1fe81cdd74d926792f75d05322d5
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Jun 3 23:43:55 2015 +0530
features/marker: Cleanup loc in case of errors
Missing loc_wipe() for error paths in mq_readdir_cbk() can
cause memory leaks. loc_wipe() is now done for both happy
and unhappy paths.
Change-Id: I882aa5dcca06e25b56a828767fb2b91a1efaf83b
BUG: 1227904
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/11074
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 60d5125e1ac8c4df0894215225d6147a6f360fd6
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon May 11 12:36:33 2015 +0530
uss: Take ref on root inode
If we recieve a statfs call on snap directory, we will redirect
the call into the root, by creating a new root loc. So it is better to
take a ref on the root inode.
(http://review.gluster.org/#/c/10358/5/xlators/features/
snapview-client/src/snapview-client.c)
Change-Id: I5649addac442d391b2550346b115dec58fed5b86
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10750
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 207bdb2f053efe5373d0f8a448ea4558308fd3bd
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Mon Jun 1 17:48:23 2015 +0530
tests/bitrot: Induce delay before invoking bitrot subcommands
This is to prevent access to uninitialized variable in reconfigure()
that's currently getting inititlized on CHILD_UP.
[
NOTE: This is a temporary fix and would not be needed when BZ
#1226666 is fixed.
]
Change-Id: I8779073fe7f315a380b833ddc248c99958de67d0
BUG: 1226902
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/11033
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 065856fd8f66d633268ccf5d2f59724bebee1710
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu May 14 15:00:59 2015 +0530
glusterd/shared_storage: Provide a volume set option to create and mount the shared storage
Introducing a global volume set option(cluster.enable-shared-storage)
which helps create and set-up the shared storage meta volume.
gluster volume set all cluster.enable-shared-storage enable
On enabling this option, the system analyzes the number of peers
in the cluster, which are currently connected, and chooses three
such peers(including the node the command is issued from). From these
peers a volume(gluster_shared_storage) is created. Depending on the
number of peers available the volume is either a replica 3
volume(if there are 3 connected peers), or a replica 2 volume(if there
are 2 connected peers). "/var/run/gluster/ss_brick" serves as the
brick path on each node for the shared storage volume. We also mount
the shared storage at "/var/run/gluster/shared_storage" on all the nodes
in the cluster as part of enabling this option. If there is only one node
in the cluster, or only one node is up then the command will fail
Once the volume is created, and mounted the maintainance of the
volume like adding-bricks, removing bricks etc., is expected to
be the onus of the user.
On disabling the option, we provide the user a warning, and on
affirmation from the user we stop the shared storage volume, and unmount
it from all the nodes in the cluster.
gluster volume set all cluster.enable-shared-storage disable
Change-Id: Idd92d67b93f444244f99ede9f634ef18d2945dbc
BUG: 1222013
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10793
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit f490d045ed723d120cf1914fa442a5d417811d81
Author: Milind Changire <mchangir@redhat.com>
Date: Wed May 27 16:50:09 2015 +0530
tools/glusterfind: verifying volume presence
An invalid volume name passed to "pre", "post" and "delete"
operations throws up unfriendly errors. This patch presents
friendly error messages.
Change-Id: I233809653379b80b34c2e74c0b6f4fe502c8961e
BUG: 1225424
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/10945
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit a8a9586ca5ec66d7ac2499e4b83c88aee7084b6f
Author: nnDarshan <dnarayan@redhat.com>
Date: Tue May 12 17:57:46 2015 +0530
snapshot/scheduler: Modified main() function to take arguments.
Modified the main function to take script arguments, so that this
script can be used as a module by other programs .
Change-Id: I902f0bc7ddfbf0d335cc087f51b1a7af4b7157fc
BUG: 1220670
Signed-off-by: n Darshan <dnarayan@redhat.com>
Reviewed-on: http://review.gluster.org/10760
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c4724bab0d29d8d447735ae0e09d990d33fab6ec
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Thu May 21 17:13:54 2015 +0530
glusterd: do not show pid of brick in volume status if brick is down.
glusterd is currently showing pid of brick in volume status if brick
goes down.
It should not show pid of brick if brick is down.
Change-Id: I077100d96de381695b338382808bd8c37bf625c7
BUG: 1223772
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10877
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 3b493bed2a5542dea7f6db50c41f6de0774b70b9
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed May 27 14:36:24 2015 +0530
bitrot/glusterd: scrub option should be disabled once bitrot option is reset
Scrubber options should be disabled from the dictionary if user reset
bitrot option.
Change-Id: Ic7e390cf88b9b749f0ada8bbd4632f4cc0c4aff9
BUG: 1220713
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10936
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 5d2dc39272b42f86991ac039e99b40a0a1fb68d5
Author: Shyam <srangana@redhat.com>
Date: Wed Jun 3 13:43:39 2015 -0400
glusterd: Bump op version and max op version for 3.7.2
As 3.7.1 is released, and a DHT configuration option needs higher
op version, bumping the gluster op-version to 3.7.2 (or 30702).
Change-Id: Iaed9e49b86a195653ddca55994e2c2398b2ee3bc
BUG: 1227884
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/11070
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 8bd8eb859ddb67b322992c4adc1cf7f6370eb4cf
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jun 2 17:58:00 2015 +0530
features/quota: Fix ref-leak
Change-Id: I0b44b70f07be441e044d9dfc5c2b64bd5b4cac18
BUG: 1207735
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11045
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 790cd332699f59ff204b2293074656d16dca1ee4
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun May 31 22:29:11 2015 +0200
nfs: allocate and return the hashkey for the auth_cache_entry
The allocation of the hashkey was never returned to the calling
function.
Allocating it with alloca() puts it on the stack, returning from the
function makes the pointer invalid. Functions that are annotated with
"inline" and call alloca(), will not always be inlined. Returning a
pointer allocated with alloca() is in those cases not correct. One such
confirmation was provided by GCC developer Alexandre Oliva:
- http://gcc.gnu.org/ml/gcc-help/2004-04/msg00158.html
It is more correct to call GF_MALLOC() and GF_FREE() for the hashkey. If
this would result in preformance hit, we can always think of using
alloca() again and turn make_hashkey() into a macro (yuck).
Change-Id: Ia86a1f79d33240af4713bfb92f702b0ee6e87eb7
BUG: 1226714
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11019
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ea9d2250bf24ef8157613bddaac133aa859f6287
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun May 17 15:26:03 2015 +0200
build: fix compiling on older distributions
data-tiering is disabled on RHEL-5 because it depends on a too new
SQLite version.
This change also prevents installing some of files that are used by
geo-replication, which is also not available on RHEL-5. geo-replication
depends on a too recent version of Python.
Due to an older version of OpenSSL, some of the newer functions can not
be used. A fallback to previous functions is done. Unfortunately RHEL-5
does not seem to have TLSv1.2 support, so only older versions can be
used.
Change-Id: I672264a673f5432358d2e83b17e2a34efd9fd913
BUG: 1222317
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10803
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0db4f0f734ce4098311d30e4f71c92fae3e492f8
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu May 21 14:58:26 2015 +0530
features/shard: Handle symlinks appropriately in fops
(f)stat, unlink and rename must skip doing inode_ctx_get()
of shard block size on symbolic links.
Change-Id: I68688532164dd2ab491ff5c59b343174f8c4ce7f
BUG: 1223759
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10995
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 40fb2eefd5f8454277a2017f29c6bf02f4ff6d0b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sat May 30 10:23:33 2015 +0530
afr: honour selfheal enable/disable volume set options
afr-v1 had the following volume set options that are used to enable/ disable
self-heals from happening in AFR xlator when loaded in the client graph:
cluster.metadata-self-heal
cluster.data-self-heal
cluster.entry-self-heal
In afr-v2, these 3 heals can happen from the client if there is an inode
refresh. This patch allows such heals to proceed only if the corresponding
volume set options are set to true.
Change-Id: I8d97d6020611152e73a269f3fdb607652c66cc86
BUG: 1226507
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/11012
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 3b85e73234332f05e87ca8616ad04a40a4a4e887
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri May 29 18:11:01 2015 +0530
snapshot/scheduler: Return proper error code in case of failure
ENUM RETCODE ERROR
----------------------------------------------------------
INTERNAL_ERROR 2 Internal Error
SHARED_STORAGE_DIR_DOESNT_EXIST 3 Shared Storage Dir
does not exist
SHARED_STORAGE_NOT_MOUNTED 4 Shared storage is not mounted
ANOTHER_TRANSACTION_IN_PROGRESS 5 Another transaction is in progress
INIT_FAILED 6 Initialisation failed
SCHEDULING_ALREADY_DISABLED 7 Scheduler is already disabled
SCHEDULING_ALREADY_ENABLED 8 Scheduler is already enabled
NODE_NOT_INITIALISED 9 Node not initialised
ANOTHER_SCHEDULER_ACTIVE 10 Another scheduler is active
JOB_ALREADY_EXISTS 11 Job already exists
JOB_NOT_FOUND 12 Job not found
INVALID_JOBNAME 13 Jobname is invalid
INVALID_VOLNAME 14 Volname is invalid
INVALID_SCHEDULE 15 Schedule is invalid
INVALID_ARG 16 Argument is invalid
Change-Id: Ia1da166659099f4c951fcdb4d755529e41167b80
BUG: 1218055
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/11005
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 6a666d14f430c4ebe0888cd49039c0e792627ced
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Tue May 19 23:27:35 2015 +0530
cluster/dht: fix incorrect dst subvol info in inode_ctx
Stashing additional information in the inode_ctx to help
decide whether the migration information is stale, which could
happen if a file was migrated several times but FOPs only detected
the P1 migration phase. If no FOP detects the P2 phase, the inode
ctx1 is never reset.
We now save the src subvol as well as the dst subvol in the
inode ctx. The src subvol is the subvol on which the FOP was sent
when the mig info was set in the inode ctx. This information is
considered stale if:
1. The subvol on which the current FOP is sent is the same as
the dst subvol in the ctx
2. The subvol on which the current FOP is sent is not the same
as the src subvol in the ctx
This does not handle the case where the same file might have been
renamed such that the src subvol is the same but the dst subvol
is different. However, that is unlikely to happen very often.
Change-Id: I05a2e9b107ee64750c7ca629aee03b03a02ef75f
BUG: 1142423
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/10834
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 6edf095e2517d85b4a91d4ee7fee786e3d001f09
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu May 28 16:03:12 2015 +0530
cluster/dht: pass a destination subvol to fop2 variants to avoid races.
The destination subvol used in the fop2 variants is either stored in
inode-ctx1 or local->cached_subvol. However, it is not guaranteed that
a value stored in these locations before invocation of fop2 is still
present after the invocation as these locations are shared among
different concurrent operations. So, to preserve the atomicity of
"check dst-subvol and invoke fop2 variant if dst-subvol found", we
pass down the dst-subvol to fop2 variant.
This patch also fixes error handling in some fop2 variants.
Change-Id: Icc226228a246d3f223e3463519736c4495b364d2
BUG: 1142423
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/10943
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit 8b698c7699b4099f337fb78e1bad91bf46543f82
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Sat May 16 21:23:48 2015 +0530
features/shard: Fix incorrect parameter to get_lowest_block()
Due to get_lowest_block() being a macro, what needs to be passed
to it is the evaluation of the expression (local->offset - 1), without
which its substitution can cause junk values to be assigned to
local->first_block.
This patch also fixes calls to get_highest_block() where if offset and
size are both equal to zero, it could return negative values.
Change-Id: I3ae918a0a3251ffd9ce8d2294bc5f9b681447627
BUG: 1200082
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10804
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit ef203a7dd5d3683684da26d1436aec272e523e94
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Jun 1 11:55:29 2015 +0530
libglusterfs: Copy d_len and dict as well into dst dirent
Also, added memory allocation failure checks in light of the
comments received @
http://review.gluster.org/#/c/10809/2/libglusterfs/src/gf-dirent.c, and
http://review.gluster.org/#/c/10809/1/xlators/features/shard/src/shard.c
Change-Id: Ie4092218545c8f4f8a0e6cc1fec6ba37bbbf2620
BUG: 1226551
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/11026
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit f13213ef7d1b5ffb09e78edb057f67baaf260d56
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jun 2 21:49:13 2015 +0530
contrib/timer-wheel: fix deadlock in del_timer()
commit eaf3bfa added mod_timers() and successfully screwed up
del_timer() by incorrectly wrapping it within double lock
blocks.
del_timer() was included before the above commit for the sake of
timer API completion, thankfully noone used it till now.
Change-Id: I07a454a216cf09dbb84777a23630e74a1e7f2830
BUG: 1227449
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/11050
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 496c9602568190e3fb9baab4f74bf48270095992
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Sun May 31 19:53:41 2015 +0200
cluster/ec: Fix incorrect check for iatt differences
A previous patch (http://review.gluster.org/10974) introduced a
bug that caused that some metadata differences could not be
detected in some circumstances. This could cause that self-heal
is not triggered and the file not repaired.
We also need to consider all differences for lookup requests, even
if there isn't any lock. Special handling of differences in lookup
is already done in lookup specific code.
Change-Id: I3766b0f412b3201ae8a04664349578713572edc6
BUG: 1225793
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/11018
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 9096f3fc79ca535eb2ec0e9b40933d8ee2c2e17a
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Jun 1 16:53:32 2015 +0530
tiering:static function called from a non static inline function
gcc v5.1.1 throws warning for calling a static function from a
non-static inline function.
<snippet from compiler warning>
CC tier.lo
tier.c:610:15: warning: 'tier_migrate_using_query_file' is static but used in inline function 'tier_migrate_files_using_qfile' which is not static
ret = tier_migrate_using_query_file ((void *)query_cbk_args);
^
tier.c:585:47: warning: 'tier_process_brick_cbk' is static but used in inline function 'tier_build_migration_qfile' which is not static
ret = dict_foreach (args->brick_list, tier_process_brick_cbk,
^
tier.c:565:176: warning: 'demotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
tier.c:565:158: warning: 'promotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
tier.c:563:58: warning: 'demotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
tier.c:563:40: warning: 'promotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
ret = remove (GET_QFILE_PATH (is_promotion));
^
CCLD tier.la
</snip>
Change-Id: I46046feeb79ab4e2724b0ba6b02c9ec8b121ff4e
BUG: 1226881
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11032
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 5ab8edc57043f4fa1044aa34d1559034e9edf04a
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Jun 1 15:21:00 2015 -0400
stripe: fix use-after-free
Pretty much a classic case. STRIPE_STACK_UNWIND frees the "local"
structure. In the "virtual xattr" path, used for lock recovery among
other things, we were calling STRIPE_STACK_UNWIND and then continuing to
clean up "our" parts of the just-freed structure. Oops.
Change-Id: Ifa961b89cd21a2893de39a9eea243d184f9eac46
BUG: 1222317
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/11037
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit f6e9c4dfd4b91b91c84f702e7ef9b34293dc7266
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri May 15 13:37:24 2015 -0400
cluster/tier: make attach/detach work with new rebalance logic
The new rebalance performance improvements added new
datastructures which were not initialized in the
tier case. Function dht_find_local_subvol_cbk() needs
to accept a list built by lower level DHT translators
in order to build the local subvolumes list.
Change-Id: Iab03fc8e7fadc22debc08cd5bc781b9e3e270497
BUG: 1222088
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10795
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 4f1b34aae1fa046aa25e2b05f2ff190534a94e41
Author: Shyam <srangana@redhat.com>
Date: Fri May 15 15:50:42 2015 -0400
dht: Add lookup-optimize configuration option for DHT
Currently with commit 4eaaf5 a mixed version cluster would
have issues if lookup-uhashed is set to auto, as older clients
would fail to validate the layouts if newer clients (i.e 3.7 or
upwards) create directories. Also, in a mixed version cluster
rebalance daemon would set commit hash for some subvolumes and
not for the others.
This commit fixes this problem by moving the enabling of the
functionality introduced in the above mentioned commit to a
new dht option. This option also has a op_version of 3_7_1
thereby preventing it from being set in a mixed version
cluster. It brings in the following changes,
- Option can be set only if min version of the cluster is
3.7.1 or more
- Rebalance and mkdir update the layout with the commit hashes
only if this option is set, hence ensuring rebalance works in a
mixed version cluster, and also directories created by newer
clients do not cause layout errors when read by older clients
- This option also supersedes lookup-unhased, to enable the
optimization for lookups more deterministic and not conflict
with lookup-unhashed settings.
Option added is cluster.lookup-optimize, which is a boolean.
Usage: # gluster volume set VOLNAME cluster.lookup-optimize on
Change-Id: Ifd1d4ce3f6438fcbcd60ffbfdbfb647355ea1ae0
BUG: 1222126
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/10797
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 9cfd19797894734adf1c02f471242fbe0f04f924
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue May 5 18:08:25 2015 +0530
glusterd/snapshot: Return correct errno in events of failure - PATCH 2
ENUM RETCODE ERROR
-------------------------------------------------------------
EG_INTRNL 30800 Internal Error
EG_OPNOTSUP 30801 Gluster Op Not Supported
EG_ANOTRANS 30802 Another Transaction in Progress
EG_BRCKDWN 30803 One or more brick is down
EG_NODEDWN 30804 One or more node is down
EG_HRDLMT 30805 Hard Limit is reached
EG_NOVOL 30806 Volume does not exist
EG_NOSNAP 30807 Snap does not exist
EG_RBALRUN 30808 Rebalance is running
EG_VOLRUN 30809 Volume is running
EG_VOLSTP 30810 Volume is not running
EG_VOLEXST 30811 Volume exists
EG_SNAPEXST 30812 Snapshot exists
EG_ISSNAP 30813 Volume is a snap volume
EG_GEOREPRUN 30814 Geo-Replication is running
EG_NOTTHINP 30815 Bricks are not thinly provisioned
Change-Id: I49a170cdfd77df11fe677e09f4e063d99b159275
BUG: 1212413
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10588
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 61afc9c78e35d626e3f522c1fe9fde5a3ff1a600
Author: Anuradha <atalur@redhat.com>
Date: Wed May 13 15:29:57 2015 +0530
cli: Fix incorrect parse logic for volume heal commands
heal-op was being incorrectly set to
GF_SHD_OP_SBRAIN_HEAL_FROM_BIGGER_FILE.
Change-Id: I4d4461c7737feae30102e82f7788083017485669
BUG: 1221128
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/10771
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
commit f3494e79147cc77215151e7e300850dcb85b8358
Author: Susant Palai <spalai@redhat.com>
Date: Mon Jun 30 14:04:34 2014 -0400
DHT/permissoin: Let setattr consume stat built from lookup in heal path
setattr call post mkdir(selfheal) ends up using the mode bits
returned by mkdir,which miss the required suid, sgid and sticky bit.
Hence, the fix is to use the mode bits from local->stbuf which was used
to create the missing directories.
Change-Id: I478708c80e28edc6509b784b0ad83952fc074a5b
BUG: 1110262
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/8208
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit e788b1bb1cf50ab05ba94cf320c2d098ba39b19b
Author: Anuradha <atalur@redhat.com>
Date: Mon May 25 11:07:27 2015 +0530
features/quota : Do unwind if postbuf is NULL
If postbuf in quota_writev_cbk is NULL directly
an unwind should be done. Trying to dereference
it will lead to a crash.
Change-Id: Idba6ce3cd1bbf37ede96c7f17d01007d6c07057a
BUG: 1221577
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/10898
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit d378124518a1477cbdde656f19586b4a1c977685
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu May 7 09:22:04 2015 -0400
common-ha: fix race between setting grace and virt IP fail-over
Also send stderr output of `pcs resource {create,delete} $node-dead_ip-1`
to /dev/null to avoid flooding the logs
Change-Id: I29d526429cc4d7521971cd5e2e69bfb64bfc5ca9
BUG: 1219485
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/10646
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
commit d253154ca731d29161365bf0d5e5dd56355b497a
Author: Dan Lambright <dlambrig@redhat.com>
Date: Thu May 28 14:00:37 2015 -0400
cluster/dht: maintain start state of rebalance daemon across graph switch.
When we did a graph switch on a rebalance daemon, a second call
to gf_degrag_start() was done. This lead to multiple threads
doing migration. When multiple threads try to move the same
file there can be deadlocks.
Change-Id: I931ca7fe600022f245e3dccaabb1ad004f732c56
BUG: 1226005
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10977
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 7fe2d169a1dce9a1d34a57ee9ca237db4b3d5c07
Author: Anoop C S <achiraya@redhat.com>
Date: Fri May 29 16:33:09 2015 +0530
features/changelog: Remove inline keyword to avoid warnings (gcc v5.1.1)
When compiled with gcc5, following warnings were displayed
and volume start failed:
changelog-helpers.h:499:1: warning: inline function 'changelog_dispatch_event'
declared but never defined
changelog_dispatch_event (xlator_t *, changelog_priv_t *, changelog_event_t *);
gf-changelog-journal-handler.c:692:17: warning: 'list_add_tail' is static but
used in inline function 'gf_changelog_queue_journal' which is not static
list_add_tail (&entry->list, &jnl_proc->entries);
Fix is to remove the keyword from function prototype and
definitions.
Change-Id: I188b35b7ca087a94d7a48a052b05a6d845e3b74b
BUG: 1226307
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/11004
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 77fcb3e81e2a6670d9df90b4b2b28d86335fb345
Author: vmallika <vmallika@redhat.com>
Date: Tue Apr 14 10:44:13 2015 +0530
quota: retry connecting to quotad on ENOTCONN error
Suppose if there are two volumes vol1 and vol2,
and quota is enabled and limit is set on vol1.
Now if IO is happening on vol1 and quota is enabled/disabled
on vol2, quotad gets restarted and client will receive
ENOTCONN in the IO path of vol1.
This patch will retry connecting to quotad upto 60sec
in a interval of 5sec (12 retries)
If not able to connect with 12 retries, then return ENOTCONN
Change-Id: Ie7f5d108633ec68ba9cc3a6a61d79680485193e8
BUG: 1211220
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/10230
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 4904f4efd178082af0cdcf068d79efd27ff46659
Author: vmallika <vmallika@redhat.com>
Date: Thu Apr 30 12:35:40 2015 +0530
features/quota: prevent statfs frame-loss when an error happens during ancestry building.
We do quota_build_ancestry in function 'quota_get_limit_dir',
suppose if quota_build_ancestry fails, then we don't have a
frame saved to continue the statfs FOP and client can hang.
Change-Id: I92e25c1510d09444b9d4810afdb6b2a69dcd92c0
BUG: 1178619
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9380
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7fa0ff7e5352afc7e1d92bb3de056d9df7c8bb92
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon May 18 18:06:32 2015 +0530
features/shard: Fix issue with readdir(p) fop
Problem:
When readdir(p) is performed on '/' and ".shard" happens to be
the last of the entries read in a given iteration of dht_readdir(p)
(in other words the entry with the highest offset in the dirent list
sorted in ascending order of d_offs), shard xlator would delete this
entry as part of handling the call so as to avoid exposing its presence
to the application. This would cause xlators above (like fuse,
readdir-ahead etc) to wind the next readdirp as part of the same req
at an offset which is (now) the highest d_off (post deletion of .shard)
from the previously unwound list of entries. This offset would be less
than that of ".shard" and therefore cause /.shard to be read once again.
If by any chance this happens to be the only entry until end-of-directory,
shard xlator would delete this entry and unwind with 0 entries, causing the
xlator(s) above to think there is nothing more to readdir and the fop is
complete. This would prevent DHT from gathering entries from the rest of
its subvolumes, causing some entries to disappear.
Fix:
At the level of shard xlator, if ".shard" happens to be the last entry,
make shard xlator wind another readdirp at offset equal to d_off of
".shard". That way, if ".shard" happens to be the only other entry under '/'
until end-of-directory, DHT would receive an op_ret=0. This would enable it
to wind readdir(p) on the rest of its subvols and gather the complete picture.
Also, fixed a bug in shard_lookup_cbk() wherein file_size should be fetched
unconditionally in cbk since it is set unconditionally in the wind path, failing
which, lookup would be unwound with ia_size and ia_blocks only equal to that of
the base file.
Change-Id: I6c2bc770f1bcdad51c273c777ae0b42c88c53f61
BUG: 1222379
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10809
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit af311d33c29df9ffaec5ec588b812d48c8cb8faa
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri May 29 13:47:14 2015 -0400
build: outdated autotools helper config.* files in dist tarfile
Our jenkins release task clones the source, runs ./autogen.sh (where
config.{guess,sub} come from) and ./configure, before running `make
dist` to product the release glusterfs-X.Y.Z.tar.gz.
The config.{guess,sub} in the tar file come from the archaic autoconf
in CentOS 6.3, which is what the glusterfs jenkins is running on.
We should not be shipping the (arbitrary, old) config.{guess,sub} files
from our jenkins machine.
Change-Id: Ib7643ae2e54d0e25c95f4e93e5dffb22cbe11523
BUG: 1223937
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11009
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 68752f1e6e128f81f890196e441d6c27938155cb
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri May 22 00:37:58 2015 +0530
socket: throttle only connected transport
BUG: 1224016
Change-Id: I2352c6661ae5aee8cf06e572ec0462b76901d46f
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/10887
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bc7f7990de38f96e8ffc8acd7018fcf672ecbf60
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri May 15 14:10:48 2015 +0530
features/bit-rot-stub: implement mknod fop
With the absence of mknod() fop implementation in bitrot stub,
further operations that trigger versioning resulted in crashes
as they expect the inode context to be valid. Therefore, this
patch implements mknod() following similar simantics to fops
such as create().
Furthermore, bitrot stub test C program is fixed to stop lying
and validate obj versions according to the versioning protocol.
Change-Id: If76f252577445d1851d6c13c7e969e864e2183ef
BUG: 1221914
Original-Author: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10790
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 29338477c74d4060d23b3489b638dcf2889a90a7
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed May 27 16:27:25 2015 +0530
featuress/changelog: On snapshot, notify irrespective of failures
During snapshot, changelog barrier is enabled and a
explicit rollover of changelog is initiated. During
rollover of changelog, if any error or changelog is
empty, the notification was not sent to reconfigure
and hence snapshot was failing because of timeout.
This patch addresses it by sending notification
irrespective of failures and sends error if any
back to barrier.
Change-Id: I898af624b44555281a9e43c69066077e0e121c17
BUG: 1225542
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10951
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 2a24b84ef8376f258af9b79e5f0bd8f618591d16
Author: Milind Changire <mchangir@redhat.com>
Date: Mon May 18 19:32:48 2015 +0530
spec: move file peer_add_secret_pub to server RPM
peer_add_secret_pub was developed as part of geo-replication
feature. glusterfind has a dependency on the peer_add_secret_pub
for distributing SSH secrets. The dependency was manifest while
QA testing glusterfind. peer_add_secret_pub is now moved to the
server RPM to support glusterfind without creating a dependency
on the geo-replication RPM
Change-Id: I1345e13fd6d218eb722cd72ca1b9dd04adf4d316
BUG: 1221544
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/10807
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit dee318ef72c16475039dfb2585b7d9cc843d107e
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed May 20 14:34:11 2015 +0530
geo-rep: Ignore ESTALE during unlink/rmdir
during unlink/rmdir of Parent_GFID/Basename, if parent
directory does not exists. Parent GFID will not get resolved
and DHT raises ESTALE instead of ENOENT.
Now ESTALE errors ignored during unlink/rmdir
BUG: 1223280
Change-Id: If275c89fb9fc7d16004550805a4cd65be818540d
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10837
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 59524dfd71f688bf3ff2078195512acac3539132
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri May 29 10:00:13 2015 +0530
features/bitrot: serialize versioning
Current signing interface (fsetxattr()) had couple of issues:
One, a signing request (by bitrot daemon) is denied if the version
against which an object is to be signed is unequal to the current
version of the object (cases where another subsequent modification
increments the version). Such request(s) are rejected with EINVAL
sent back to the signer resulting in a bunch of errors (in logs)
reported by bitrot daemon. Although, the object would be eventaully
signed with the version matching the current version, the "lagging"
request should be correctly handled.
Two, more than one signing request could race against each other
with the object getting signed with a version depending on which
request ended up last in the race. Although harmless to some extent,
such a case could end up marking the object's signature as stale
for infinity (if the object is *never* touched) thereby resulting
in scrubber skipping the object during verification.
This patch fixes these issues by ordering signing request(s) and
fixing version comparison checks at the time of signing.
Change-Id: I9fa83dfa3be664ba4db61d7f2edc408f4bde77dd
BUG: 1221938
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10832
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ccae86494e45975a4e00857a0a7450f73fd50f58
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue May 26 13:01:17 2015 +0530
geo-rep: Fix Data counter issue in status
ENTRY and META operations executed sequentially, DATA operations
are handled async, increment happens when a changelog parsed.
Decrement happens after the sync of all files.
'files_in_batch' was reset multiple times in batch instead of once.
BUG: 1224098
Change-Id: I87617f2fd5f4d3221a1c9f9d5a8efb0686c42bbe
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10911
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3e9478084463d7972ee857dcf3f4fb61292600a0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 29 16:28:10 2015 +0530
features/qemu-block: Don't unref root inode
Root inode doesn't participate in ref/unref. Don't do it
in fini as by the time fini is called itable would be destroyed.
BUG: 1226276
Change-Id: I704d0a3c0813cb8f6c3f1f7d613c89aca8f4f9ad
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11002
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 8698caf1ae522f9495fbccb7a23ec1123aa5bff5
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu May 28 16:54:59 2015 +0200
cluster/ec: Ignore differences in non locked inodes
When ec combines iatt structures from multiple bricks, it checks
for equality in important fields. This is ok for iatt related to
inodes involved in the operation that have been locked before
starting execution. However some fops return iatt information
from other inodes. For example a rename locks source and destination
parent directories, but it also returns an iatt from the entry
itself.
In these cases we ignore differences in some fields to avoid false
detection of inconsistencies and trigger unnecessary self-heals.
Another issue is solved in this patch that caused that the real
size of the file stored into the inode context was lost during
self-heal.
Change-Id: I8b8eca30b2a6c39c7b9bbd3b3b6ba95228fcc041
BUG: 1225793
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/10974
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System
commit f40b6d3b32b87f57715c529ce5d65c5ab56245bf
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed May 27 15:00:00 2015 -0400
common-ha: handle long node names and node names with '-' and '.' in them
sourcing the /etc/ganesha/ganesha-ha.conf file seemed like a simple
and elegant solution for reading config params, but bash variable names
do not allow '-' and '.' in them.
Change-Id: I0d2e6cb21017472b1e0f764335cf28946cca95f0
BUG: 1225572
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/10952
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 8cd398297f655e701f303c2eb234beb2d2356ab0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 29 15:34:09 2015 +0530
heal: Do not call glfs_fini in final builds
BUG: 1226253
Change-Id: Id18a7a3a2b9c2cffea6f3d7c8676712fcf9691e5
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/11001
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b50ae8c1c64d1198488c3a9d3415c9bdef30ae04
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri May 29 11:34:38 2015 -0400
build: xlators/mgmt/glusterd/src/glusterd-errno.h is not in dist tarball
attempts to build RPMs, e.g. in tree with `make -C extras/LinuxRPM
glusterrpms` or from a dist tarball produced in tree will fail with:
glusterd-locks.c:19:28: fatal error: glusterd-errno.h: No such file
or directory compilation terminated
Change-Id: I365dbcd5b7bc3410f4a7752a05f570e4061461d0
BUG: 1226384
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/11007
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 3c731f92e47821df474c0ff6e38347d176ab4473
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri May 29 20:19:57 2015 +0530
tests : fix spurious failure in bug-973073.t
remove_brick_completed needs the same fix as 02c04579
Change-Id: I1a65f9095e4b01e6bb014440fc89696a4eebf8ca
BUG: 1226367
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11006
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit be3fefe0f4fe9dc3ceb8e2d8859876726309cf2b
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon May 18 16:26:02 2015 +0200
build: do not #include "config.h" in each file
Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).
When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.
BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 3194779c373e0f29e040c080796ac371d0362529
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed May 27 11:56:53 2015 +0530
scripts: Added script stop-all-gluster-processes.sh in rpm
This script was not included as part of rpm. Fixed now
BUG: 1204641
Change-Id: I5e559b187253cc2f4f8ea7cf8ec56a32802e5ab2
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10931
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 6315f02239e944bff4450b45374301ad379a7afb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat May 9 23:11:15 2015 +0530
worm: Let lock, zero xattrop calls succeed
Locks can be taken just to inspect the data as well, so allow them.
Xattrops are internal fops so we can allow them as well as longs as
it doesn't change the xattr value, i.e. All-zero xattrop.
Change-Id: Idc06d2043eb472c064db40d811a80058f0bda378
BUG: 1211123
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10727
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: NetBSD Build System
commit 8282f0dc318ee9c5a35311535acba4b0286c2ee1
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed May 20 09:34:26 2015 -0400
glusterfs.spec.in: python-gluster should be 'noarch'
Change-Id: Ic4f498ce87a5a7f21b637da1b63a290b9fe89b66
BUG: 1219954
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/10846
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit d242557c410a2e7ca16a4d1b931b13a120d6b8ae
Author: anand <anekkunt@redhat.com>
Date: Tue May 19 14:31:23 2015 +0530
Build: glusterd socket file cleanup to set SElinux context properly.
Issue : glusterd runs as rpm_script_t when it's executed from the rpm scriptlet, socket file
created in this context is set as rpm_script_t type, glusterd unable to access socket file
when it runs in glusterd_t context (glusted not cleaning socket file while stoping due to
some cleanup issues, so cleanup required in rpm install).
Fix: In rpm post upgrade,remove the glusterd.socket file which is created by glusterd in rpm context.
so that glusterd recreates socket file when it runs in glusterd_t context.
Change-Id: I57041e2e0f9d3e74e12198507a9bd47d09f4a132
BUG: 1223185
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/10815
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8ea59d92a342e7ffa55958629df74103943a03e6
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Apr 20 10:08:03 2015 +0530
features/quota : Make "quota-deem-statfs" option "on" by default, when quota is enabled
As of now it is expected from user to set deem-statfs to "on" when
quota is enabled. Better to turn it "on" by default when quota is enabled.
Change-Id: I85e0b919b1bdb74ac21e256073eebcb55bcb8e2a
BUG: 1213364
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/10299
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit b83b671bd5c88a402ff085e07f80a2185154be7c
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu May 21 11:55:03 2015 +0530
geo-rep: Disable xattrs and acls support with tar_ssh
Geo-rep can't sync xattrs and acls with tar over ssh
for following reasons.
Issue 1: xattrs doesn't sync with tar over ssh.
Reason: untar doesn't respect '--overwrite' option when used along
with '--xattrs'. So it sends unlink if the file exists on
destination and re-creates afresh. But all entry operations
are banned in aux-gfid-mount as it may lead to gfid-mismatch.
Hence fails with EPERM. This happens only when some xattr is
set on a file in master volume.
Issue2: acls on directories does not sync with tar over ssh.
Reason: tar tries to opendir ".gfid/<gfid1>" and is not supported
by gfid-access-translator as readirp can't be handled on
virtual inodes and hence fails with ENOTSUP where as it syncs
for files.
Since the issue is with tar commmand it self and nothing could be
done from gluster side, disabling xattr and acls support with tar
over ssh option.
Geo-rep can sync xattrs and acls with 'rsync' as the sync engine.
Change-Id: I6821d327e7fe15545adef644869aa2389f79c701
BUG: 1223642
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10873
Tested-by: NetBSD Build System
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 951c6e3d2e23b81c54c7eb4836b31e59c6456fd5
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu May 21 17:00:59 2015 +0530
geo-rep: Fix acl mounting in mountbroker setup
Add acl option to geo-rep mount specification template
(georep_mnt_desc_template) for mountbroker setup.
Change-Id: I5b93ebb81bd308fc343c3b9e21c36c78acedcbaa
BUG: 1223741
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10876
Tested-by: NetBSD Build System
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 12ca9bc341f255b7357cc0f2dec2084ab5269ae6
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue May 5 10:58:10 2015 +0530
glusterd/snapshot: Return correct errno in events of failure - PATCH 1
RETCODE ERROR
-------------------------------------------
30800 Internal Error
30801 Another Transaction In Progress
Change-Id: Ica7fd2e513b2c28717b6df73cfb2667725dbf057
BUG: 1212413
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10313
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 84410a1efdd2f38654ee1d85b98a5a81f5304061
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue May 19 17:04:55 2015 +0530
Changing log level from Warning to Debug
Change-Id: Ic4306ebb5a58c2ca310e973bb562be1ca3e4885f
BUG: 1202758
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/10829
Tested-by: NetBSD Build System
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit d48daa615b8782365fd6b08949b998b22b301b45
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu May 7 17:50:25 2015 +0530
snapshot/scheduler: Do not enable scheduler if another scheduler is running
Check if another snapshot scheduler is running before
enabling the scheduler.
Also introducing a hidden option, disable_force
"snapshot_scheduler.py disable_force" will disable the
cli snapshot scheduler from any node, even though the node
has not been initialised for the scheduler, as long as the
shared storage is mounted
This option is hidden, because we don't want to encourage
users to use all commands from nodes that are not initialised.
Change-Id: I7ad941fbbab834225a36e740c61f8e740813e7c8
BUG: 1219442
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10641
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 2261106d9bfc4e13ec058a2d48f81692c44b6359
Author: vmallika <vmallika@redhat.com>
Date: Fri May 22 14:04:31 2015 +0530
quota: quota.conf backward compatibility fix
In release-3.7 the format of quota.conf is changed.
There is a backward compatibility issues during upgrade
1) There can be an issue when peer sync between node-3.6 and node-3.7
2) If the user sets/removes limit, there is will different format of
file in node-3.6 and node-3.7
This patch fixes the issue:
1) restrict the user to execute command quota enable, limit-usage, remove
2) write quota.conf in older format if op-version is less than 3.6
Change-Id: Ib76f5a0a85394642159607a105cacda743e7d26b
BUG: 1223739
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/10889
Tested-by: NetBSD Build System
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 17422e58a93e2af2c730746bd769a381164f451d
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed May 13 14:35:47 2015 +0530
features/bitrot: refactor brick connection logic
Brick connection was bloated (and not implemented efficiently) with
calls which were not required to be called under lock. This resulted
in starvation of lock by critical code paths. This eventally did not
scale when the number of bricks per volume increases (add-brick and
the likes).
Also, this patch cleans up some of the weird reconnection logic that
added more to the starvation of resources and cleans up uncontrolled
growing of log files.
Change-Id: I05e737f2a9742944a4a543327d167de2489236a4
BUG: 1207134
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/10763
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: NetBSD Build System
commit 8ec6926120e11bb1124a2e8866486112a3cb2b60
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue May 12 18:49:15 2015 +0530
glusterd: function to create duplicate of volinfo should copy subvol_count
when we create duplicate volfile from a existing volfile,
we are not copying the variable subvol_count to the new
volfile.
Change-Id: I943aa7fdf1a2ca5bf57522cb2402b6b3165501ac
BUG: 1215002
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10761
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
commit bc096463a6a55eb3e87dbd81870460f3c98ffb97
Author: Shyam <srangana@redhat.com>
Date: Wed May 20 09:47:05 2015 -0400
glusterd: Bump op version and max op version for 3.7.1
As 3.7 is released, and a DHT configuration option needs higher
op version, bumping the gluster op-version to 3.7.1 (or 30701).
Change-Id: I9747cf93b41be72e43077ed8e977e21eed99ccc3
BUG: 1223432
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/10849
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 34e3f59a432f4574d9751cf819312ad073987e41
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri May 15 16:03:00 2015 +0530
tiering/rebalance: Use separate pid/socket file for tiering
When promotion/demotion daemon starts, it uses the same pidfile
as rebalance. This patch will introduce a different pid file
for the same.
Change-Id: Ic484c53f51e00ae6b2d697748a9600b14829e23b
BUG: 1221970
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10792
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
commit 34542756cc1fdc511d912766617ffed336f713a5
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue May 19 14:54:32 2015 +0530
tiering/nfs: duplication of nodes in client graph
When creating client volfiles, xlator tier-dht will
be loaded for each volume. So for services like nfs
have one or more volumes . So for each volume in the
graph a tier-dht xlator will be created. So the graph
parser will fail because of the redundant node in
graph.
By this change tier-dht will be renamed as volname-tier-dht
Change-Id: I3c9b9c23ddcb853773a8a02be7fd8a5d09a7f972
BUG: 1222840
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10820
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 3bba591c1442be46731520aeedadb17977497933
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed May 13 20:33:45 2015 +0530
tier: Do not allow detach-tier commands on a non-tiered volume
Change-Id: Ic92d25db68e40ef4a4388ef42affd1b3ee5a7ec6
BUG: 1221270
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10773
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
commit 7ee3f70eeef7320cb136853ffd912894d61cac9c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed May 13 16:53:22 2015 +0530
tiering: Correct errors in cli and glusterd
Problem 1:
volume info shows Cold Bricks instead of Tier type
eg:
Volume Name: patchy2
Type: Tier
Volume ID: 28c25b8d-b8a1-45dc-b4b7-cbd0b344f58f
Status: Started
Number of Bricks: 3
Transport-type: tcp
Hot Tier :
Hot Tier Type : Distribute
Number of Bricks: 1
Brick1: 10.70.1.35:/home/brick43
Cold Bricks:
Cold Tier Type : Distribute
Number of Bricks: 2
Brick2: 10.70.1.35:/home/brick19
Brick3: 10.70.1.35:/home/brick16
Options Reconfigured:
Problem 2: Detach-tier sending enums of Rebalance
detach-tier has it's own Enum to send with detach-tier command,
using that enums will make more appropriate.
Problem 3:
Wrongly sets hot_brick count during the dictionary copying for response
Change-Id: Icc054a999a679456881bc70511470d32ff8a86e4
BUG: 1211264
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10768
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
commit eb955fa50af1b4de4fcb049e3f78c50defcc2246
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Apr 29 12:00:40 2015 +0530
glusterd/tiering: Exchange tier info during glusted handshake
Change-Id: Ibc2f8eeb32d3e5dfd6945ca8a6d5f0f80a78ebac
BUG: 1211264
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10449
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
commit 0f81e9fafe67fe374df09cbeb0f013461bb2518c
Author: Günther Deschner <gd@samba.org>
Date: Thu Apr 16 11:29:00 2015 +0200
xlators/cluster/dht: Fix Explicit null dereferenced (CID 1291727).
Coverity CID 1291727.
Guenther
Change-Id: I95f01b638f74370f0ef04383f0f9d5799abe31f5
BUG: 789278
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-on: http://review.gluster.org/10300
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit dd68499830f105309e897db41282f41a2a2e2afc
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu May 21 19:55:02 2015 +0530
features/bitrot: reimplement scrubbing frequency
This patch reimplments existing scrub-frequency mechanism used
to schedule scrubber runs. Existing mechanism uses periodic
sleeps (waking up periodically on minimum granularity) and
performing a number of tracking checks based on counters and
sleep times. This patch does away with all the nifty counters
and uses timer-wheel to schedule scrub runs.
Scheduling changes are peformed by merely calculating the new
expiry time and calling mod_timer() [mod_timer_pending() in
some cases] making the code more debuggable and easier to
follow. This also introduces "hourly" scrubbing tunable as an
aid for testing scrubbing during development/testing cycle.
One could also implement on-demand scrubbing with ease: by
invoking mod_timer() with an expiry of one (1) second, thereby
scheduling a scrub run the very next second.
Change-Id: I6c7c5f0c6c9f886bf574d88c04cde14b76e60a8b
BUG: 1224596
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10893
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 111c62994fbe513b2a057c59b86c5813654091b7
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Mon Apr 13 14:24:44 2015 +0530
cluster/dht: Fix dht_setxattr to follow files under migration
If a file is under migration, any xattrs created on it
are lost post migration of the file. This is because
the xattrs are set only on the cached subvol of the source
and as the source is under migration, it becomes a linkto file
post migration.
Change-Id: Ib8e233b519cf954e7723c6e26b38fa8f9b8c85c0
BUG: 1193636
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/10212
Tested-by: NetBSD Build System
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit b6544494d16cbeaaf9a7eabe4f4e247c4902ca4b
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri May 22 11:54:11 2015 +0530
contrib/timer-wheel: mod_timer() and friends
Couple of timer-wheel api's to modify timer expiry times:
mod_timer()
mod_timer_pending()
Both the api's perform almost the same job with one minute
difference: mod_timer_pending() modifies timer expiry only
if the timer is pending (i.e. being tracked in timer-wheel).
Change-Id: Iae64934854ccfd6b081b849bff998ae3c3021bac
BUG: 1224596
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10892
Tested-by: NetBSD Build System
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 576974a7be41883b521b426e977c6cefc00ec72e
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue May 26 21:51:31 2015 +0530
features/bitrot: stub improvements and fixes
This patch refactors the signing trigger mechanism used by bitrot
daemon as a "catch up" meachanism to sign files which _missed_
signing on the last run either due to bitrot being disabled and
enabled again or if bitrot is enabled for a volume with existing
data.
Existing implementation relies on overloading writev() to trigger
signing which just by the looks sounded dangerous and I hated it
to the core. This change moves all that business to the setxattr
interface thereby keeping the writev path strictly for client
IO.
Why not use IPC fop to trigger signing?
There's a need to access the object's inode to perform various
maintainance operations. inode is not _directly_ accessible in
the IPC fop (although, it can be found via inode_grep() for the
object's GFID - the inode just needs to be pinned in memory,
which is the case if there's an active fd on the inode). This
patch relies on good old technique of overloading fsetxattr()
to do the job instead of using IPC fop.
There are some pretty nice cleanups along the lines of memory
deallocations, unncessary allocations and redundant ref()ing
of structures (such as fd's) provided by this patch. All in
all - much improved code navigation.
Change-Id: Id93fe90b1618802d1a95a5072517dac342b96cb8
BUG: 1224600
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10942
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 26be9bed63c549b1363f75c84965eb67d733e915
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Mon May 18 17:37:14 2015 +0530
libgfapi: introduce bit flags for pthread mutex and cond variables
At present stage, the initialization and destroy of conditional
and mutex variables of glfs struct happen in different places and
there is no uniform way of destroying these variables incase
there is a failure when initializing these. The fs mutex and
conditional variables are getting destroyed from glfs_free_from_ctx().
However this destroy is not done by a conditional check inside destroy
function. By introducing bit flags in glfs object, we can make use of the
same (if there is a failure in initialization) in glfs_fini()
which is evolving as one and only function to free fs and ctx resources.
This patch introduce the flags field and set the flags according
to the initialization flow of the mutex and conditional variables
of struct glfs members. Without this patch we are compelled to use
the goto lables and other hacks in init functions to make sure
the resources are freed if there is an error path.
Change-Id: I86e2719fb7ce437419a05699b4f06c14b02d0e69
BUG: 1208482
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/10120
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit f890cfa0c7bf794f542e7481fc8969ccb20ace3a
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu May 21 21:30:54 2015 +0530
spec: correct the vendor string in spec file
Change-Id: Id19c973092af506582741887d12fe00c85022f15
BUG: 1198849
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10885
Tested-by: NetBSD Build System
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 924dac9d6c65db843a04aec5b9c6d9fb950c343e
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat May 23 19:41:56 2015 +0200
build: do not include rpcgen generated files in "make dist"
The .c and .h files are generated by rpcgen, there is no need to include
them in the "make dist" tarball.
BUG: 1198849
Change-Id: Ie6281720e4d485d2b84d98efccfc7053594d1542
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10897
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 10c4c4857a89c14a6979db0c1d0c05c8caec5395
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed May 20 09:10:38 2015 -0400
glusterfs.spec.in: move libgf{db,changelog}.pc from -api-devel to -devel
pkgconfig files in the wrong package results in unexpected package
dependencies
Change-Id: I0551114d09bcc3a7a73e152275175ba6c1bc0da3
BUG: 1223385
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/10843
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 0efe50c3e051f092bdd44fee24760d74584c0c97
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed May 13 19:56:47 2015 +0530
cluster/dht: Don't rely on linkto xattr to find destination subvol during phase 2 of migration.
linkto xattr on source file cannot be relied to find where the data
file currently resides. This can happen if there are multiple
migrations before phase 2 detection by a client. For eg.,
* migration (M1, node1, node2) starts.
* application writes some data. DHT correctly stores the state in
inode context that phase-1 of migration is in progress
* migration M1 completes
* migration (M2, node2, node3) is triggered and completed
* application resumes writes to the file. DHT identifies it as phase-2
of migration. However, linkto xattr on node1 points to node2, but
the file is on node3. A lookup correctly identifies node3 as cached
subvol
TBD:
When we identify phase-2 of a previous migration (say M1), there
might be a migration in progress - say (M3, node3, node4). In this
case we need to send writes to both (node3, node4) not just
node3. Also, the inode state needs to correctly indicate that its in
phase-1 of migration. I'll send this as a different patch.
Change-Id: I1a861f766258170af2f6c0935468edb6be687b95
BUG: 1142423
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/10805
Tested-by: NetBSD Build System
commit e7b7a66bada19a593e888556c62fbe7a982269d6
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu May 14 03:21:10 2015 +0530
afr: allow readdir to proceed for directories in split-brain
Problem:
afr_read_txn() bails out if read_subvol==-1. This meant that for
directories that were in entry split-brain, FOPS like readdir, access,
stat etc were not allowed.
Fix:
Except for getxattr, all other FOPS are wound on the first up child
of afr.
Change-Id: Iacec8fbb1e75c4d2094baa304f62331c81a6f670
BUG: 1221481
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10776
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Tested-by: NetBSD Build System
commit f77ae499098a38ac13ab349764614b8ce624ea54
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu May 21 17:47:33 2015 +0200
fuse: squash 64-bit inodes in readdirp when enable-ino32 is set
The structures returned by readdirp contain the inode 2x. Only one of
them was squashed into 32-bits when enable-ino32 is enabled.
Change-Id: I33a6d28fb118bb23971f918ffeb983d7f033106e
BUG: 1223889
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Cyril Peponnet <cyril@peponnet.fr> [on release-3.5]
Reviewed-on: http://review.gluster.org/10881
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit e626f79efffc69400ded5f5c8a5a44e05396d888
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Thu May 14 14:37:25 2015 +0530
gfapi: zero size issue in glfs_h_acl_set()
When setting the stringified ACLs in the xattr dict through
pub_glfs_h_setxattrs(), the size of the string is always passed as 0.
The correct way is to pass the length of the ACL in text form.
While verifying this issues, it seems that posix_pacl_set() should
return the errno instead of -1. This helps in debugging, otherwise EPERM
would always be returned on an error.
[ndevos: fix off-by-one strlen() and return errno in posix_pacl_set()]
Change-Id: Ia7a7fa1f3a7d615a813c703057dc97b09a0bbb34
BUG: 789278
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10782
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6d0cf5353fe06acba9332fb30dcd913a5a19f48c
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue May 19 14:48:01 2015 +0530
glusterd: fix repeated connection to nfssvc failed msgs
... and disable reconnect timer on rpc_clnt_disconnect.
Root Cause
----------
gluster-NFS service wouldn't be started if there are no
started volumes that have nfs service enabled for them.
Before this fix we would initiate a connect even when
the gluster-NFS service wasn't (re)started. Compounding
that glusterd_conn_disconnect doesn't disable reconnect
timer. So, it is possible that the reconnect timer was
in execution when the timer event was attempted to be
removed.
Change-Id: Iadcb5cff9eafefa95eaf3a1a9413eeb682d3aaac
BUG: 1222378
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/10830
Tested-by: NetBSD Build System
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit fcb2667a135825c7873d57119c36ce77e9db5950
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed May 20 14:33:41 2015 +0530
glusterd : allocate peerid to store in frame->cookie
commit a1de3b05 was using peerid from the stack and storing it in the
frame->cookie and in the subsequent callback it was referred. The existance of
this variable is not guranteed in the cbk since its not dynamically allocated.
Fix is to dynmacially manage peerid in the frame cookie.
This patch also fixes one problem in gd_sync_task_begin () where unlock is not
triggered if the cluster is running with lesser than 3.6 op-version resulting into
commands failing with another transaction is in progress.
Change-Id: I0d22cf663df53ef3769585703944577461061312
BUG: 1223213
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10842
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 318a74c394762f91948b87f3add0ffcfe8fe5249
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed May 13 11:44:49 2015 +0200
features/shard: Skip block count and size update for directories
Change-Id: Iaa7022c95a8d9c9c471db025ec644e0bcc4eeb29
BUG: 1221104
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10772
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 4a66323f431a55e33a076a4e2692f98adf277669
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed May 13 14:25:44 2015 +0200
protocol/client,server: Move EEXIST logs in mkdir and mknod to DEBUG level
Change-Id: I0481258de8da36cbee7c046f53b20359badaf064
BUG: 1221889
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10791
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 17c8f8e56493fede0ebe0c4c0a4880a194850dbf
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed May 27 19:03:12 2015 +0530
cluster/afr: Treat op_ret >= 0 as success in afr_final_errno()
Change-Id: I7ec29428b7f7ef249014f948a5d616bfb8aaf80d
BUG: 1225491
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10946
Tested-by: NetBSD Build System
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 60cfa634efdab12006fd44889c42ef8dc7e217e2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed May 27 16:40:52 2015 +0530
tests: Remove tests from bad tests
All known ec eio issues we know are solved with
http://review.gluster.com/10852
So removing these ec tests from bad tests:
./tests/basic/ec/ec-5-1.t
./tests/basic/ec/ec.t
Removing the following tests because they are one-off failures and the
logs do not show anything significant.
./tests/bugs/replicate/bug-1015990.t
./tests/bugs/glusterfs/bug-867253.t
./tests/basic/afr/sparse-file-self-heal.t
Removing the following tests as they are fixed by 10918:
./tests/basic/ec/quota.t
./tests/basic/quota-nfs.t
./tests/bugs/quota/bug-1035576.t
BUG: 1165041
Change-Id: Ie3701d376ef383375f3e9853df26baa617628cdd
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10930
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3d30d879cb83cc48cb312253c1395f7d2638c6e6
Author: vmallika <vmallika@redhat.com>
Date: Wed May 27 16:25:27 2015 +0530
quota: fix for spurious failure
During ancestry build, loc path was set to invalid
path. path was set to one of its child instead
of itself. Because of this quota accounting was
going wrong
This patch fix the issue
Below mentioned tests removed from bad test list
as part of patch# 10930
./tests/basic/ec/quota.t
./tests/basic/quota-nfs.t
./tests/bugs/quota/bug-1035576.t
Change-Id: Iaa65b2d968c04c9abcd476d0e9f588cb7fd39294
BUG: 1223798
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/10918
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 794f39cb8a10383f25f00d338401fad7d58c5348
Author: Deepak C Shetty <deepakcs@redhat.com>
Date: Tue May 26 14:33:19 2015 +0530
tests: Fix typo in ssl-authz.t
Fixes a typo that was incorrectly causing the ssl cipher
list not to be set properly on the test volume.
Change-Id: I7969988551aa0c76261e41ab2f6247b684dacd49
Signed-off-by: Deepak C Shetty <deepakcs@redhat.com>
Reviewed-on: http://review.gluster.org/10914
Tested-by: NetBSD Build System
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b78d9fd94fda23c3b01b188fa31bb0f77a7fbfa1
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue May 26 15:10:25 2015 +0530
tests/uss.t: wait for connection to complete before accessing a file in snapshot
Change-Id: I82d0cb378d006777d5a304afe8d5be15e92c7245
BUG: 1163543
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/10915
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit aa89ac96d96ee936ee3b56f29e2bf48bfa5e9b70
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed May 27 12:08:54 2015 +0530
meta: implement fsync(dir)
Change-Id: I707c608a9803fe6ef86860ca5578d4d3f63fd2aa
BUG: 1225323
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/10929
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 1b0bb02a5d3bb67ac8c72f534e1db753f8fa04e3
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu May 21 11:17:59 2015 +0530
tier/tier.t: Fixing tier.t crash in regression runs
1) If the database file exists
a. Dont try re-creating the db schema
b. Dont try re-configuring the db.
2) Dont assert in fini_db () when connection is NULL
Change-Id: I15dd103fe7542f70113c1d5e539a99f8cd062be4
BUG: 1163543
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10870
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b47d5a67cc6e3a0432d715569e9ab04bf8c294af
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed May 20 15:17:35 2015 +0200
cluster/ec: Forced unlock when lock contention is detected
EC uses an eager lock mechanism to optimize multiple read/write
requests on the same entry or inode. This increases performance
but can have adverse results when other clients try to access the
same entry/inode.
To solve this, this patch adds a functionality to detect when this
happens and force an earlier release to not block other clients.
The method consists on requesting GF_GLUSTERFS_INODELK_COUNT and
GF_GLUSTERFS_ENTRYLK_COUNT for all fops that take a lock. When this
count is greater than one, the lock is marked to be released. All
fops already waiting for this lock will be executed normally before
releasing the lock, but new requests that also require it will be
blocked and restarted after the lock has been released and reacquired
again.
Another problem was that some operations did correctly lock the
parent of an entry when needed, but got the size and version xattrs
from the entry instead of the parent.
This patch solves this problem by binding all queries of size and
version to each lock and replacing all entrylk calls by inodelk ones
to remove concurrent updates on directory metadata. This also allows
rename to correctly update source and destination directories.
Change-Id: I2df0b22bc6f407d49f3cbf0733b0720015bacfbd
BUG: 1165041
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/10852
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 71c9ae74a504f3b4d3ec4536b4d56ce48a4e0db7
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu May 21 18:45:12 2015 +0200
posix: Do not update unmodified xattr in (f)xattrop
If a (f)xattrop is issued with a value that only contains 0's,
then we don't modify or create the extended attribute. This
is useful to avoid ctime modifications when the only purpose
of the xattrop was to get the current value.
Change-Id: Ia62494e9009962e683c8276783f671da17a8b03a
BUG: 1211123
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/10886
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 3ff6c19dd4bac88b72773ffc9dc87be1c3512ff6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue May 19 20:53:30 2015 +0530
features/locks: Handle virtual getxattrs in more fops
With this patch getxattr of inodelk/entrylk counts can be requested in
readv/writev/create/unlink/opendir.
Change-Id: If7430317ad478a3c753eb33bdf89046cb001a904
BUG: 1165041
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10880
Tested-by: NetBSD Build System
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 9a3ad03c26ec199d7d0c77db103717a57ba93a6a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri May 22 18:38:23 2015 +0530
glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.
Every peer gets a generation number, during it's inception.
This generation number is used to identify the peer throiughout
it's lifetime. This number is assigned based on the current
generation number of the system, which is incremented with every
peer that is added.
The problem arises when we add a peer, and before it gets a rpc_connect
we begin a transaction. In such a case, the peer gets considered in the
transaction, but doesn't participate in it coz it isn't connected yet.
The moment it gets the rpc notification and is connected, it starts
participating in the transaction and all hell breaks loose.
To resolve it, we should assign the peerinfo a new generation number
everytime it's connected, so that this number will be greater than the
generation number that the transaction is acting upon, and even though
the peer is connected it will not participate in the transaction.
We should also assign the new generation number of the peer to the peerctx,
so that the framework that searches for peerinfos based on the generation
number, will still function in the same manner.
Removing ./tests/basic/volume-snapshot-clone.t from bad-tests.
Also removed the duplicate entry of ./tests/bugs/snapshot/bug-1112559.t
from bad-tests. Original entry was removed in
http://review.gluster.org/10840
Change-Id: Ie25e3ecf59b19535b9cded7449e944221fac97a0
BUG: 1224290
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10895
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit d143281efee565f6c5f1f96e802d2b8cb182cc6b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon May 25 16:42:50 2015 +0530
tests: Fix entry-self-heal.t
Because both bricks in the replica pair of patchy are in the same node,
both full healer threads within the same shd try and fail to acquire
non-blocking locks when each one gets lock on one of the bricks,
causing heal to fail occasionally.
Now heals are triggered from the mount as part of inode refresh.
And because the AFR on the mount graph
a. does not treat presence of dirty xattrs as something that needs
a heal (this is true for dirs fool_heal and fool_me) and
b. does not recursively heal the entire hierarchy of subdirs and their
entries in one shot (this is true with source_creations_heal/dir1),
index heal is used to heal fool_heal, fool_me and
source_creations_heal/dir1 wherein only one brick (which is the brick that
contains the good copy of source_creations_heal/dir_1: brick-1) has all
the gfids to be healed copied into its indices/xattrop directory.
Change-Id: I46df4188f16d1623f20cc0d7266b3afaeca6c31f
BUG: 1163543
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10916
Tested-by: NetBSD Build System
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 29f24facac72e301e5732aa721013ed70ed0318c
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed May 20 18:23:58 2015 +0530
glusterd: fix double-free of rebalance process' rpc object
Change-Id: I0c79c4de47a160b1ecf3a8994eedc02e3f5002a9
BUG: 1223338
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/10872
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 2216167c39a7e2c73c63c14cf10983370f618bd0
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue May 26 15:36:52 2015 +0530
tests: remove read-subvol-entry.t from is_bad_test
Change-Id: I81750655d5686709908563e68f40821140397050
BUG: 1163543
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10917
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ab1133011b969b0004440ae1cbd11842db7fc8b4
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue May 26 10:40:49 2015 +0530
tests: add ec/ec.t to is_bad_test
... to avoid ec.t's spurious regression test failure coming in the way
of fixes for other independent spurious regression test failures.
Change-Id: Id393be571685ca1e69732c1149c370b6fd0e6d17
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/10907
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c5ddab47d544bbdceaa01f31cf8ae69fc07e97fd
Author: vmallika <vmallika@redhat.com>
Date: Mon May 25 13:35:48 2015 +0530
Quota: fix testcases not to send parallel writes for accurate quota enforcement
Currently quota enforcer doesn't consider parallel writes
and allows quota to exceed limit where there are high rate
of parallel writes. Bug# 1223658 tracks the issue.
This patch fixes the spurious failures by not sending
parallel writes.
Using O_SYNC and O_APPEND flags and block size
not more that 256k (For higher block size NFS client
splits the block into 256k chinks and does parallel writes)
Change-Id: I297c164b030cecb87ce5b494c02b09e8b073b276
BUG: 1223798
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/10878
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit e0dea2932ed30074d160bab1ad162593ff8fac97
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue May 19 23:09:42 2015 +0530
tests: arbiter.t fix
Wait for AFR's children to be up in glustershd process before attempting heal.
Also, grep (version 2.21) is detecting statedump files as binary, causing tests
to succeed incorrectly. Hence adding the -a switch to force it to treat it as a
text file. Thanks to Vijay Bellur for identifying the issue
(http://lists.gnu.org/archive/html/bug-grep/2015-05/msg00000.html) and the
workaround.
Change-Id: Ie3d9591ffaf44baa0cd8c2baa327aed24378e3df
BUG: 1163543
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10833
Tested-by: NetBSD Build System
Tested-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 8c4dbee681063ba3bc1fe5282336d7c17201c1b6
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu May 21 15:43:35 2015 +0530
tests: data-self-heal.t fix
Use Index heal instead of full heal to heal files because if both bricks are on
the same node, the 2 full heal threads might compete and fail to acquire the non
blocking locks and the file might not get healed during the full heal crawl.
Change-Id: I3b9e2de7b0366b4bc40b54314807ef165baad68f
BUG: 1163543
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10875
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 9b426213e89befd9cb7027b6608e78325c3c8140
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri May 22 10:08:37 2015 +0530
tests: add more tests to bad_test for the interim
Change-Id: Icd92f1b999c8cda310053306c63a7445146a55db
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/10888
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit cdc6ce4c4165c1117f5b8000dc438a942f8eef8a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 20 23:56:17 2015 +0530
cluster/ec: Fix use after free crash
ec_heal creates ec_fop_data but doesn't run ec_manager. ec_fop_data_allocate
adds this fop to ec->pending_fops, because ec_manager is not run on this heal
fop it is never removed from ec->pending_fops. When it is accessed after free
it leads to crash. It is better to not to add HEAL fops to ec->pending_fops
because we don't want graph switch to hang the mount because of a BIG
file/directory heal.
BUG: 1188145
Change-Id: I8abdc92f06e0563192300ca4abca3909efcca9c3
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10868
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 23b82472a752403dbf6390b3241489a74b215983
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed May 20 17:49:25 2015 +0530
tests: Removing tests/bugs/snapshot/bug-1112559.t from test-suite
The fix that introduced this test has been reverted as part of design change.
Hence removing it from the test-suite
Change-Id: I7acaf387ec3035f736498a437c736fe70970d421
BUG: 1219738
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10840
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 239ab095d4da3d091e3228ba6864d5ef4a19621a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri May 8 09:53:50 2015 +0530
glusterd: populate errstr if gd_syncop_submit_request fails
Change-Id: Ie4a3edef5d553fc07de53b46f9485c46a4305245
BUG: 1219732
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10659
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 79f1e674f0b84953b782c1d047a76c49323775c0
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu May 14 20:07:10 2015 +0200
cluster/ec: Correctly cleanup delayed locks
When a delayed lock is pending, a graph switch doesn't correctly
terminate it. This means that the update of version and size xattrs
is lost, causing EIO errors.
This patch handles GF_EVENT_PARENT_DOWN event to correctly finish
pending udpdates before completing the graph switch.
Change-Id: I394f3b8d41df8d83cdd36636aeb62330f30a66d5
BUG: 1188145
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/10787
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 0c412d5f963da2d921ab24f19efa89f146c4defe
Author: zhoushicheng <madaozhou@gmail.com>
Date: Fri Apr 10 12:10:26 2015 +0800
test: Fix sparse file self heal test
This patch solves problems caused by XFS with speculative preallocation feature on :
Test EXPECT "1" has_holes $B0/${V0}0/big2bigger would fall when XFS has not freed the preallocated blocks.
It is caused by XFS speculative preallocation feature. The test would pass if this feature is disabled.
Speculative preallocation can speed up under linux 3.8(and later).
Otherwise, the test would pass by dropping cache manually to speed up speculative preallocation.
As in http://review.gluster.org/#/c/10411/, using "( cd $M0 ; umount $M0 )" to drop caches, which is
better than "echo 3 > /proc/sys/vm/drop_caches".
drop caches operation was added in test:
tests/basic/afr/sparse-file-self-heal.t
BUG: 1206461
Change-Id: Ie2c9d1b92fa8307c44498752fdd100eb86f9689c
Signed-off-by: zhoushicheng <madaozhou@gmail.com>
Reviewed-on: http://review.gluster.org/10253
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5679e1881e37f3be032d207d07f42d4b5faba7c4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 18 14:46:55 2015 +0530
cluster/ec: Handle lookup failures while op in progress
Change-Id: Ia1834ec23d5de615526d4d4e4d2e32aff155b7f7
BUG: 1211962
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10806
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit a12256ece56c48c53f0d7aafb260ba8d7ae3c7be
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue May 19 10:01:05 2015 +0530
tests: Remove bug-976800.t from is_bad_test()
commit d4d9cfc82d7cf77972 has already fixed this test.
Change-Id: I7ecef580af6c7a3b3b786ab583705123475afcb6
BUG: 1220058
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/10813
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 11700e2d1b9fc238f2110a7f0b1f48897e1c5929
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Tue May 19 01:09:05 2015 +0530
move trash doc to features sub directory
Change-Id: I3ca9a0c8fddc7af516aaf5a6d4a880fb24e3c058
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10810
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anoop C S <achiraya@redhat.com>
commit 85070c6f0a5978a84ded50a34ee92d6eb1be5f2d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun May 10 11:57:15 2015 +0530
tests: data-self-heal.t-create files from the mount point.
Currently data-self-heal.t creates files directly on the brick and sets
the trusted.gfid xattr. Later it depends on stat from mount to create
the .glusterfs/<gfid hard link>. The link creation doesn't seem to be
happening always. Hence changing the test to create files from the mount
point before modifying afr xattrs in the backend and triggering heal.
Also disabled all performance translators. With these changes,
http://review.gluster.org/#/c/10667/ is not failing in data-self-heal.t
Change-Id: I7d054e52b97aeb0bdc2fdf9d70a8cf33318d4310
BUG: 1218304
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10530
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 2500bcda2623d8fddafc08f119c67fe3be434656
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon May 11 03:32:20 2015 +0200
Tests: avoid hang in br-stub.t
br-stub.t forgot to unmount the NFS mount, leading to the situation
where cleanup code had to do it after glusterfs daemon were shut
down. NetBSD has trouble dealing with this situation and may enter
endless wait for the NFS server to come back.
Fix is simply to unmount before the end og the script
BUG: 1129939
Change-Id: I972d379172a75f29ad11abc66d700c2d31106194
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10748
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit dea3bd88660ee000abfd34dcbdd4146e318c51d0
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat May 16 17:57:37 2015 +0200
tests: write log for glupy.t to the standard log directory
There is (or was) a spurious test in glupy.t for which a separate log
file was setup. The directory where the log is saved, is not available
on NetBSD and this causes glupy.t to always fail, without a log.
Instead of hard-coding the path to the log, use "gluster --print-logdir"
to provide a LOGDIR environment variable. glupy.t now writes the log to
an existing directory.
BUG: 1163543
Change-Id: Ifa73198d06fa267856d0da9d25a4380329909124
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10801
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 54f0ec4e61234e3e41ec29d5be8223c1e52ebee6
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed May 13 11:41:31 2015 +0200
nfs: Use uuid_clear() instead of memset
Fixes the following incorrect usage:
mount3.c: In function '__mnt3_build_mountid_from_path':
mount3.c:705:24: warning: 'sizeof' on array function parameter 'mountid' will
return size of 'unsigned char *' [-Wsizeof-array-argument]
length = sizeof(mountid);
^
mount3.c:699:58: note: declared here
__mnt3_build_mountid_from_path (const char *path, uuid_t mountid)
^
mount3.c: In function '__mnt3_get_mount_id':
mount3.c:732:24: warning: 'sizeof' on array function parameter 'mountid' will
return size of 'unsigned char *' [-Wsizeof-array-argument]
length = sizeof(mountid);
^
mount3.c:726:46: note: declared here
__mnt3_get_mount_id (xlator_t *mntxl, uuid_t mountid)
Change-Id: I08f46c5994578fc99a7b61681e808d1115e41d71
BUG: 1221095
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/10765
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b34d64812564c15ab9ab77669394d762b85729e6
Author: Dan Lambright <dlambrig@redhat.com>
Date: Fri May 15 14:16:00 2015 -0400
cluster/tier: load libgfdb.so properly in all cases
We should load libgfdb.so.0, not libgfdb.so
Change-Id: I7a0d64018ccd9893b1685de391e99b5392bd1879
BUG: 1222092
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10796
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Joseph Fernandes
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9bf02ddbbecba0a7c8c73cb1310b9f3e607587fe
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Thu May 14 12:10:01 2015 +0530
fuse: fix return value check for setuid
setuid() sets the effective user ID of the calling process. If the
effective UID of the caller is root, the real UID and saved set-user-ID
are also set. On success, zero is returned. On error, -1 is returned,
and errno is set appropriately.
there are cases where setuid() can fail even when the caller is UID 0;
it is a grave security error to omit checking for a failure return from
setuid(). if an environment limits the number of processes a user can
have, setuid() might fail if the target uid already is at the limit.
Fix is to check return value of setuid.
Change-Id: I7aa5ab5e347603c69dc93188417cc4f4c81ffc75
BUG: 1221490
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-on: http://review.gluster.org/10780
Reviewed-by: Prasanna Kumar Kalever
Tested-by: Prasanna Kumar Kalever
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
commit f395227ce527aab9d2c1861573da4e0438830033
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 13 16:57:49 2015 +0530
cluster/ec: Prevent unnecessary self-heals
When a blocking lock is requested, lock request is succeeded even when
ec->fragment number of locks are acquired successfully in non-blocking locking
phase. This will lead to fop succeeding only on the bricks where the locks are
acquired, leading to the necessity of self-heals. To prevent these un-necessary
self-heals, if the remaining locks fail with EAGAIN in non-blocking lock phase
try blocking locking phase instead.
Change-Id: I940969e39acc620ccde2a876546cea77f7e130b6
BUG: 1221145
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10770
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit ea7537ca49f09d5b4aaadc1d488c38cbe730e7fc
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Thu May 14 19:33:44 2015 +0530
dht/rebalance : Fixed rebalance failure
The rebalance process determines the local subvols for the
node it is running on and only acts on files in those subvols.
If a dist-rep or dist-disperse volume is created on 2 nodes by
dividing the bricks equally across the nodes, one process might
determine it has no local_subvols.
When trying to update the commit hash, the function attempts to
lock all local subvols. On the node with no local_subvols the dht
inode lock operation fails, in turn causing the rebalance to fail.
In a dist-rep volume with 2 nodes, if brick 0 of each replica
set is on node1 and brick 1 is on node2, node2 will find that it has
no local subvols.
Change-Id: I7d73b5b4bf1c822eae6df2e6f79bd6a1606f4d1c
BUG: 1221696
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/10786
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7a04477bfd8d873a4d8b17bc49f357f842d76dae
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Thu Apr 23 13:23:55 2015 +0530
dht : null dereference coverity fix.
CID : 1124521
Change-Id: Ie524935d636195cb6894074095b9b98fe28dbc2c
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/10348
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sakshi Bansal
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit f25cb6d367324c1d6e205ee3cdd678cbeb8e279c
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed May 13 15:21:29 2015 +0530
quota/glusterd: on read call number of byte read should equal to buffer length
glusterd is crashing when user try to set limit-usage on quota. Because
in the read call number of byte is going to be read is more then buffer
lenght.
Change-Id: Ie507eb68ebc0d0daa1012baef1bf724e202e3baa
BUG: 1221025
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10766
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 296f2d7df1bd1a4ed2ef2b33bfdb1993d311751e
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Wed May 13 04:49:15 2015 +0530
NFS-Ganesha : Disable ACL by default
ACLs need to be disabled by default.
To enable ACLs, the user has to change the
export file manually, set Disable_ACL=False
and run ganesha-ha.sh --refresh-config.
Changing the default export file to
accommodate these changes.
Change-Id: If3fe0f237344c594a43ad6fc5d351bd391ae5256
BUG: 1221131
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/10769
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit f7098a576556501d2b2f3ad1b6df24e533bef7c1
Author: Anuradha <atalur@redhat.com>
Date: Tue May 12 12:53:30 2015 +0530
cluster/afr : Do not copy dict when it is NULL
In afr_lookup_xattr_req_prepare(), dict_copy was
done even though source dict was NULL.
Change-Id: I85a5d2823ba021e7f78c1ce13402a0f16b08cb51
BUG: 1220332
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/10755
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 0489660564139374d44b7311d45bde50658f14bf
Author: Susant Palai <spalai@redhat.com>
Date: Tue May 12 12:56:37 2015 +0530
dht/rebalance: Change log_level to DEBUG
Change-Id: I646367581d8ee8a9e5966ee302b19273a0c780ff
BUG: 1220329
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/10756
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 6ad84cc5c3166bbc8e46f1409d4c2ce2017691d3
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Mon May 11 17:43:40 2015 +0530
rpm: marker xlator should part of the server sub-package
Currently marker translator is part of extra-xlator package. Installing
only the glusterfs-server package and required dependencies does not
make it possible to create a volume and starte it. Starting the volume
will fail. The brick logs compain that type feature/marker is not valid:
W [xlator.c:192:xlator_dynload] 0-xlator: /usr/lib64/glusterfs/3.7.0beta1/xlator/features/marker.so: cannot open shared object file: No such file or directory
E [graph.y:212:volume_type] 0-parser: Volume 'rvstore-marker', line 78: type 'features/marker' is not valid or not found on this machine
Fix is to include the marker translator in the server package. It should
not be part of extra-xlator package.
Change-Id: I77fe8a0bcf7d6f1dbff62d663e840e9e45805614
BUG: 1220381
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10752
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ae0943a3a61f305eac4c30bf4e4357396c784fca
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Sat May 9 19:35:31 2015 +0530
tests: Wait for NFS exports to be ready before mount
Change-Id: Ie71e8c80d6a43dd618c9decb946a459b211295ce
BUG: 1219846
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/10724
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit eb10272e97ae0c9494d809919a199c60b1633415
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Apr 23 23:13:50 2015 +0530
uss : implement statfs fop for snapd
snapview-client and snapview-server doesnot have statfs
fop implemented
Change-Id: I2cdd4c5784414b0549a01af9a28dbc723b7cdc67
BUG: 1176837
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10358
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 403d1c2bdcf5586b87db9b3ce6f5c1d855cbb109
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed May 7 19:31:30 2014 +0000
dht: make lookup-unhashed=auto do something actually useful
The key concept here is to determine whether a directory is "clean" by
comparing its last-known-good topology to the current one for the
volume. These are stored as "commit hashes" on the directory and the
volume root respectively. The volume's commit hash changes whenever a
brick is added or removed, and a fix-layout is done. A directory's
commit hash changes only when a full rebalance (not just fix-layout)
is done on it. If all bricks are present and have a directory
commit hash that matches the volume commit hash, then we can assume
that every file is in its "proper" place. Therefore, if we look for
a file in that proper place and don't find it, we can assume it's not
on any other subvolume and *safely* skip the global (broadcast to all)
lookup.
Change-Id: Id6ce4593ba1f7daffa74cfab591cb45960629ae3
BUG: 1219637
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/7702
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c04b26b6acb798432b75c7bacc5eba0dd2b627b0
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Apr 22 20:07:11 2015 +0530
cli/tiering: volume info should display details about tier
>> gluster volume info patchy
Volume Name: patchy
Type: Tier
Volume ID: 8bf1a1ca-6417-484f-821f-18973a7502a8
Status: Created
Number of Bricks: 8
Transport-type: tcp
Hot Tier :
Hot Tier Type : Replicate
Number of Bricks: 1 x 2 = 2
Brick1: hostname:/home/brick30
Brick2: hostname:/home/brick31
Cold Bricks:
Cold Tier Type : Disperse
Number of Bricks: 1 x (4 + 2) = 6
Brick3: hostname:/home/brick20
Brick4: hostname:/home/brick21
Brick5: hostname:/home/brick23
Brick6: hostname:/home/brick24
Brick7: hostname:/home/brick25
Brick8: hostname:/home/brick26
Change-Id: I7b9025af81263ebecd641b4b6897b20db8b67195
BUG: 1212400
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10339
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9c444739c6181a6748ece71bca3197cf8a6c2d67
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed May 6 14:23:34 2015 +0530
features/bitrot: scrubber should crawl based on the scrubber frequency value
Currently scrubber is crawling all the files continuously. It should
crawl files based on the scrubber frequency which user have set.
By default scrubber crawling frequency value will be biweekly.
Change-Id: I5762a92c1e700134cfe4283d1f631904adbfe31d
BUG: 1208131
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10602
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7d59c28bedcc1185bd63ff3e3241cab35cf0c20f
Author: Joseph Fernandes <josferna@redhat.com>
Date: Fri May 8 16:36:00 2015 +0530
CTR/Libgfdb: Log typo fix
Log typo fix for CTR Xlator and Libgfdb
Change-Id: I8d7208b9756199f8dc0a72771a3c953b4fa00f3f
BUG: 1215896
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10668
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 167e5c15b62ba9afaa9c9c299fd556c758a25cd1
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat May 9 21:05:02 2015 +0200
glupy: remove debug test in libpython runtime search path detection
A configure test was recently added to add libpython runtime search
path to glupy.so xlator. The vesion committed was a debug test, it
searched pythonxx and not python to check for failure.
Fix by removing the xx debug test in python's name.
BUG: 1129939
Change-Id: I7b691be17fc2a2c812f68710869b1a9a85ced84c
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10732
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a01f5b0216e83b1f0c0532d181a06e000a813150
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Apr 22 11:17:08 2015 +0530
cli/tiering: display hot tier, and cold tier separately
cli commands display the brick information without a way
to distinguish hot tier, and cold tier.
This patch will change all the cli related output, without
changing the corresponding xml output.
This patch will change following things
>> gluster volume info
Volume Name: patchy
Type: Tier
Volume ID: 7745d367-811a-4fe9-a500-d04e7afa94bf
Status: Created
Number of Bricks: 3 x 2 = 6
Transport-type: tcp
Hot Bricks:
Brick1: hostname:/home/brick21
Brick2: hostname:/home/brick20
Cold Bricks:
Brick3: hostname:/home/brick19
Brick4: hostname:/home/brick16
Brick5: hostname:/home/brick17
Brick6: hostname:/home/brick18
>>gluster volume status
Status of volume: patchy
Gluster process TCP Port RDMA Port Online
Pid
------------------------------------------------------------------------------
Hot Bricks:
Brick hostname:/home/brick21 49152 0 Y
4690
Brick hostname:/home/brick20 49153 0 Y
4707
Cold Bricks:
Brick hostname:/home/brick19 49154 0 Y
4724
Brick hostname:/home/brick16 49155 0 Y
4741
Brick hostname:/home/brick17 49156 0 Y
4758
Brick hostname:/home/brick18 49157 0 Y
4775
NFS Server on localhost 2049 0 Y
4793
Task Status of Volume patchy
------------------------------------------------------------------------------
There are no active volume tasks
>>gluster volume status pathy detail
Status of volume: patchy
Hot Bricks:
------------------------------------------------------------------------------
Brick : Brick hostname:/home/brick21
TCP Port : 49162
RDMA Port : 0
Online : Y
Pid : 22677
File System : ext4
Device :
/dev/mapper/luks-cd077c56-42ba-44b1-8195-f214b9bc990c
Mount Options : rw,seclabel,relatime,data=ordered
Inode Size : 256
Disk Space Free : 127.3GB
Total Disk Space : 165.4GB
Inode Count : 11026432
Free Inodes : 10998043
------------------------------------------------------------------------------
Brick : Brick hostname:/home/brick20
TCP Port : 49161
RDMA Port : 0
Online : Y
Pid : 22660
File System : ext4
Device :
/dev/mapper/luks-cd077c56-42ba-44b1-8195-f214b9bc990c
Mount Options : rw,seclabel,relatime,data=ordered
Inode Size : 256
Disk Space Free : 127.3GB
Total Disk Space : 165.4GB
Inode Count : 11026432
Free Inodes : 10998043
Cold Bricks:
------------------------------------------------------------------------------
Brick : Brick hostname:/home/brick19
TCP Port : 49157
RDMA Port : 0
Online : Y
Pid : 22501
File System : ext4
Device :
/dev/mapper/luks-cd077c56-42ba-44b1-8195-f214b9bc990c
Mount Options : rw,seclabel,relatime,data=ordered
Inode Size : 256
Disk Space Free : 127.3GB
Total Disk Space : 165.4GB
Inode Count : 11026432
Free Inodes : 10998043
------------------------------------------------------------------------------
Brick : Brick hostname:/home/brick16
TCP Port : 49158
RDMA Port : 0
Online : Y
Pid : 22518
File System : ext4
Device :
/dev/mapper/luks-cd077c56-42ba-44b1-8195-f214b9bc990c
Mount Options : rw,seclabel,relatime,data=ordered
Inode Size : 256
Disk Space Free : 127.3GB
Total Disk Space : 165.4GB
Inode Count : 11026432
Free Inodes : 10998043
------------------------------------------------------------------------------
Brick : Brick hostname:/home/brick17
TCP Port : 49159
RDMA Port : 0
Online : Y
Pid : 22535
File System : ext4
Device :
/dev/mapper/luks-cd077c56-42ba-44b1-8195-f214b9bc990c
Mount Options : rw,seclabel,relatime,data=ordered
Inode Size : 256
Disk Space Free : 127.3GB
Total Disk Space : 165.4GB
Inode Count : 11026432
Free Inodes : 10998043
------------------------------------------------------------------------------
Brick : Brick hostname:/home/brick18
TCP Port : 49160
RDMA Port : 0
Online : Y
Pid : 22552
File System : ext4
Device :
/dev/mapper/luks-cd077c56-42ba-44b1-8195-f214b9bc990c
Mount Options : rw,seclabel,relatime,data=ordered
Inode Size : 256
Disk Space Free : 127.3GB
Total Disk Space : 165.4GB
Inode Count : 11026432
Free Inodes : 10998043
Change-Id: I7d584eb8782129c12876cce2ba8ffba6c0a620bd
BUG: 1206546
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10328
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 544bdb403450178528bea19539a983f8e1418e2f
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Sun May 10 11:36:36 2015 +0530
test: disable ec-3-1.t, ec-5-1.t, ec-12-4.t bad test cases
These tests are frequently failing regressions now.
Change-Id: I9dd51eb124e1cbabc52d7b083f0bbed55526b57e
BUG: 1220058
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10743
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 620408e072ae67c68d41ef769b9b2004dde5ade7
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Fri May 8 13:08:22 2015 +0530
bitrot: Volfile generation should not proceed if node doesn't have any brick.
glusterd crashes when bitrot is enabled on a distributed volume from a node
which doesn't host a brick.
While generating volfile glusterd should check number of brick on that node. If
node doesn't have any brick then graph generation for bitrot and scrubber should
not proceed further.
Change-Id: I2158113e20e93738cde2a22fd73f0ae6b22aae9e
BUG: 1219784
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10664
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 01d5b6515a77cd4569cea2b0a7f765d92c926c60
Author: Aravinda VK <avishwan@redhat.com>
Date: Sat May 9 10:03:42 2015 +0530
geo-rep: Update Not Started to Created in code and doc
"Not Started" status is now "Created", replaced "Not Started"
string in code and doc.
Change-Id: If7d606c2cc8156e41291e7eebe9d0da4ad7ac28d
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1219937
Reviewed-on: http://review.gluster.org/10698
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 313e3e6ab8497444000eaf2f2b325d35e5f2581a
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Jan 7 12:29:48 2015 +0100
ec: Fix failures with missing files
When a file does not exist on a brick but it does on others, there
could be problems trying to access it because there was some loc_t
structures with null 'pargfid' but 'name' was set. This forced
inode resolution based on <pargfid>/name instead of <gfid> which
would be the correct one. To solve this problem, 'name' is always
set to NULL when 'pargfid' is not present.
Another problem was caused by an incorrect management of errors
while doing incremental locking. The only allowed error during an
incremental locking was ENOTCONN, but missing files on a brick can
be returned as ESTALE. This caused an EIO on the operation.
This patch doesn't care of errors during an incremental locking. At
the end of the operation it will check if there are enough successfully
locked bricks to continue or not.
Change-Id: I9360ebf8d819d219cea2d173c09bd37679a6f15a
BUG: 1176062
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9407
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 3a5e775077048d5a0b3bbe26e98484ed107bc9d7
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat May 9 19:56:07 2015 +0200
gfapi: fix compile warning in pub_glfs_h_access()
While compiling libgfapi, the following warning is reported:
Making all in src
CC libgfapi_la-glfs-handleops.lo
In file included from glfs-handleops.c:12:0:
glfs-handleops.c: In function 'pub_glfs_h_access':
glfs-internal.h:216:14: warning: 'old_THIS' may be used uninitialized in this function [-Wmaybe-uninitialized]
THIS = old_THIS; \
^
glfs-internal.h:202:36: note: 'old_THIS' was declared here
#define DECLARE_OLD_THIS xlator_t *old_THIS = NULL
^
glfs-handleops.c:1159:2: note: in expansion of macro 'DECLARE_OLD_THIS'
DECLARE_OLD_THIS;
^
CCLD libgfapi.la
CCLD api.la
The DECLARE_OLD_THIS macro should be done with the declarations of all
the other variables used in this function. Moving the macro further up
in the function prevents this warning.
Change-Id: I2bedc1aa074893ae3e2c933abc5a167ab5b55f41
BUG: 1210934
Reported-by: Shyamsundar Ranganathan <srangana@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10728
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit aa874b04f0e1d837544f07812e3a47f1d4acbbee
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Apr 27 17:18:36 2015 +0530
glusterd/tiering : cksum mismatch for tiered volume
Once we updated the volinfo from orginator node, the hot
type was overwritten with volume type.
Then the same dictionary was sent to peer node to perform
the commit of attach-tier, that will cause hot type to
replace with volume type, eventually end up in cksum
mismatch
Change-Id: I402dceb4d672d0b3a7b91a92f52c1057050dbedc
BUG: 1215660
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Conflicts:
xlators/mgmt/glusterd/src/glusterd-brick-ops.c
Reviewed-on: http://review.gluster.org/10406
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e9f90320973576c0a407ff10501af7ed3127687d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat May 9 21:23:56 2015 +0530
Disable all bad tests
Change-Id: Ib70330f6b635af563044346fe525e6555c83d0d2
BUG: 1220058
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10725
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit f988eedc51a397fdfb3f8649483afe73fad86a4e
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Apr 28 04:40:00 2015 -0400
core: use reference counting for mem_acct structures
When freeing memory, our memory-accounting code expects to be able to
dereference from the (previously) allocated block to its owning
translator. However, as we have already found once in option
validation and twice in logging, that translator might itself have
been freed and the dereference attempt causes on of our daemons to
crash with SIGSEGV. This patch attempts to fix that as follows:
* We no longer embed a struct mem_acct directly in a struct xlator,
but instead allocate it separately.
* Allocated memory blocks now contain a pointer to the mem_acct
instead of the xlator.
* The mem_acct structure contains a reference count, manipulated in
both the normal and translator allocate/free code using atomic
increments and decrements.
* Because it's now a separate structure, we can defer freeing the
mem_acct until its reference count reaches zero (either way).
* Some unit tests were disabled, because they embedded their own
copies of the implementation for what they were supposedly testing.
Life's too short to spend time fixing tests that seem designed to
impede progress by requiring a certain implementation as well as
behavior.
Change-Id: Id929b11387927136f78626901729296b6c0d0fd7
BUG: 1211749
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10417
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 85623a33cbdbca182881a9c814b4766faf9c5b27
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Sat May 9 15:38:51 2015 +0530
tests: fix bitrot spurious failures
Change-Id: I342b7f8ec9c37cfd8d4cbd4090319330345bed4c
BUG: 1220016
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10707
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 47462e33f7e56ab12ea6283251536ed0e1f96cad
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sat May 9 12:23:10 2015 +0530
tests: fix bitrot spurious failures
Change-Id: I55bd62480b7ee38cf7b29aeba67b19b0c5bbe2fb
BUG: 1220016
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10702
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 9df269016b342439d2c3cb05f7f65dfca84b7993
Author: anand <anekkunt@redhat.com>
Date: Thu May 7 12:23:25 2015 +0530
glusterd: Invoking daemon reconfigure functions correctly
Problem : Scrub and bitd reconfigure functions were not invoking if
quota is not enabled.
Reason : In glusterd_svcs_reconfigure, if quota is not enabled then
it is returning in the middle of the function without calling bitd
and scrub reconfigure functions.
Fix : If quota is not enable on volume, skip quota reconfigure and
continue for other daemon reconfigure.
This patch also address the state dump issue for bitd and quotad
(logs the scrub and bitd info into state dump).
Change-Id: I39ea004b70c95543c08496245be595b3ea044a29
BUG: 1219355
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/10622
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 0a2723368846d54f65391552e00153f1fffb4916
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Apr 17 12:00:48 2015 +0530
cluster/dht: change log level of developer logs to DEBUG
A few log messages in dht directory self heal at log level INFO are useful
only for developers and these logs tend to casue excessive logs in our
log files. Hence moving the log level of such logs to DEBUG.
Change-Id: I8a543f4ddeb5c20b2978a0f7b18d8baccc935a54
BUG: 1217949
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/10281
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3f2b2014ad6fa4c1980ca45d82258e2835bbd095
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Tue May 5 17:03:39 2015 +0530
geo-rep: rename handling in dht volume(changelog changes)
Background:
Glusterfs changelogs are stored in each brick, which records the changes
happened in that brick. Georep will run in all the nodes of master and processes
changelogs "independently". Processing changelogs is in brick level, but
all the fops will be replayed on "slave mount" point.
Problem:
With a DHT volume, in changelog "internal fops" are NOT recorded.
For Rename case, Rename is recorded in "hashed" brick changelog.
(DHT's internal fops like creating linkto file, unlink is NOT recorded).
This lead us to inconsistent rename operations.
For example,
Distribute volume created with Two bricks B1, B2.
//Consider master volume mounted @ /mnt/master and following operations
executed:
cd /mnt/master
touch f1 // f1 falls on B1 Hash
mv f1 f2 // f2 falls on B2 Hash
// Here, Changelogs are recorded as below:
@B1
CREATE f1
@B2
RENAME f1 f2
Here, race exists between Brick B1 and B2, say B2 will get executed first.
Source file f1 itself is "NOT PRESENT", so it will go ahead and create
f2 (Current implementation).
We have this problem When rename falls in another brick and
file is unlinked in Master.
Similar kind of issue exists in following case too(multiple rename):
CREATE f1
RENAME f1 f2
RENAME f2 f1
Solution:
Instead of carrying out "changelogging" at "HASHED volume",
carry out at the "CACHED volume".
This way we have rename operations carried out where actual files are present.
So,Changelog recorded as :
@B1
CREATE f1
RENAME f1 f2
Note:
This patch is dependent on dht changes from this patch.
http://review.gluster.org/10410/
changelog related changes are separated out for review.
In changelog, xdata passed from DHT is considered as :
1. In case of unlink (internal operation as part of rename), xdata value
is set , it is considered as RENAME and recorded accordingly.
2. In case of rename (Hash and Cache different), xdata value is NOT
set, recording rename operation is SKIPPED.
BUG: 1141379
Change-Id: Ifca675e6d4ef8c4e3b7ef4a7ec85de8b3a38dc08
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/10220
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit e58a23dcb5e048ce0fb491926e93f54109204dd5
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Apr 30 12:28:17 2015 +0530
tools/glusterfind: GFID to Path conversion using Changelog
Records fop information collected from Changelogs in sqlite database.
This is only working database, not required after processing.
After post processing, output file is generated by reading these
database files.
This is applicable only in incremental run, When a changelog is
parsed, all the details are saved in Db. GFID to Path is converted
to those files for which information is available in Changelogs.
For all the failed cases, it tries to convert to Path using Pgfid,
if not found GFID to Path is done using find.
BUG: 1201284
Change-Id: I53f168860dae15a0149004835e67f97aebd822be
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10463
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 61e49e0bbe7e7c3eed5fcebe59113a7079208d83
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Sat May 2 17:31:07 2015 +0530
cli/tiering: Enhance cli output for tiering
Fix for handling cli output for attach-tier and
detach-tier
Change-Id: I4d17f4b09612754fe1b8cec6c2e14927029b9678
BUG: 1211562
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10284
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c723d9128e13f1925c414e353d6aa445a2e1fb0d
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Apr 20 14:03:58 2015 +0530
tools/glusterfind: Partial Find
Enabled by default, if one node fails Glusterfind will not fail
to return list of files from other nodes. This behavior can be changed
using --disable-partial
Now session is maintained in each nodes as well as in initiator node.
Every pre command will pick the status file from respective node and
start collecting list of changes happened after the status time.
--reset-session-time, new option to force reset the session time.
Next incremental run will start from this time.
Change-detector argument is removed since Changelog mode is required
to detect deletes and Renames.
Change-Id: I0b83bc7c0e1b30b13de772b2d21fe968db4ff964
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1201289
Reviewed-on: http://review.gluster.org/10320
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 356a4c0dc7273f8535389718dac3a29b390ece8b
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri May 8 21:03:09 2015 +0530
features/changelog: Fix buffer overflow in snprintf
Change-Id: Ie7e7c6028c7bffe47e60a2e93827e0e8767a3d66
BUG: 1219894
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10687
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
commit 6454460ea7522de2de472b8769a07d1eb2eac3ba
Author: Aravinda VK <avishwan@redhat.com>
Date: Sat May 9 00:26:14 2015 +0530
geo-rep: Fix corrupt gsyncd output
When gsyncd fails with Python traceback, glusterd fails
parsing gsyncd output and shows error.
BUG: 1219937
Change-Id: Ic32fd897c49a5325294a6588351b539c6e124338
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10694
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 22b2203039599ca47b3e9b63276f3d5b2c3d7b59
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Sat May 2 19:19:27 2015 +0530
tiering: Remove unwanted check for tier type volume
Change-Id: I2def61ebf348558e5f6a138265e3329d9a5407a3
BUG: 1216898
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10494
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
commit bc00a4cc33ab1d3456b12cf78ec99e5d80a61817
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Apr 29 13:03:52 2015 +0530
libgfapi: Store and restore THIS in every API exposed by libgfapi
Storing and restoring THIS:
When the APIs exposed by libgfapi are called by other xlators like
snapview server etc. the THIS value is overwritten to contain the
THIS of libgfapi(viz libgfapi master xlator). Hence using 'THIS'
in any xlator after calling libgfapi API will lead to issues.
One such issue was uncovered in snapview and the patch
http://review.gluster.org/#/c/9469/ was sent to workaround this issue.
Hence, storing and restoring THIS, at the entry and exit of every API
exposed by libgfapi.
Change-Id: I6f330dde25e7700fb26339d667a7ccd193ec6ba0
BUG: 1210934
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9797
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a86282863290ac4baf450991b4c52b94f2a66555
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu May 7 10:58:46 2015 +0530
tests : workaround fix for volume-snapshot-clone spurious failure
Snippet of the existing test:
TEST kill_glusterd 2;
TEST $glusterd_2;
sleep 5
EXPECT_WITHIN $PROCESS_UP_TIMEOUT 'Started' volinfo_field ${V0}_clone 'Status';
EXPECT_WITHIN $PROCESS_UP_TIMEOUT 'Started' volinfo_field ${V1}_clone 'Status';
stop_force_volumes 2
The above EXPECT_WITHINs will not wait as the volumes were never stopped which
results into immediate trigger of volume stop where handshaking is not
completed. A workaround would be to check whether handshaking is completed and
then proceed.
Change-Id: Id3468b56f801212fc8e19ff196bc99e5e2358471
BUG: 1163543
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10619
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Justin Clift <justin@gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 597f3c9942cde5808fffb1ec097e3a1d80f5b73e
Author: Hari Gowtham <hari.gowtham005@gmail.com>
Date: Mon Apr 13 16:06:56 2015 +0530
nfs.c nfs3.c: port log messages to a new framework
Change-Id: I9ddb90d66d3ad3adb2916c0c949834794ee7bdf3
BUG: 1194640
Signed-off-by: Hari Gowtham <hari.gowtham005@gmail.com>
Reviewed-on: http://review.gluster.org/10216
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit e1ebe7bf4933b80253121866a07d4d5ed82699ec
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Apr 9 15:38:47 2015 +0530
features/bit-rot-stub: versioning of objects in write/truncate fop instead of open
* This patch brings in the changes where object versioning is done in write and
truncate fops instead of tracking them in open and create fops. This model
works for both regular and anonymous fds. It also removes the race associated
with open calls, create and lookups.
This patch follows the below method for object versioning and notifications:
Before sending writev on the fd, increase the ongoing
version first. This makes anonymous fd write similar to the regular
fd write by having the ongoing version increased before doing the
write.
Do following steps to do versioning:
1) For anonymous fds set the fd context (so that release is invoked) and add
the fd context to the list maintained in the inode context.
For regular fds the above think would have been done in open itself.
2) Increase the on-disk ongoing version
3) Increase the in memory ongoing version and mark inode as non-dirty
3) Once versioning is successfully done send write operation. If
versioning fails, then fail the write fop.
5) In writev_cbk mark inode as modified.
Change-Id: I7104391bbe076d8fc49b68745d2ec29a6e92476c
BUG: 1207979
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/10233
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e672a20e3c84d5a8db579bb4bba3ba98a09ea1c8
Author: Dan Lambright <dlambrig@redhat.com>
Date: Thu Apr 16 05:21:16 2015 +0100
glusterd: add counter support for tiered volumes
This fix adds support to view the number of promoted or demoted
files from the cli. The mechanism is isolmorphic to checking
the status of volumes being rebalanced.
gluster volume rebalance <vol> tier status
Change-Id: I1b11ca27355ceec36c488967c23531202030e205
BUG: 1213063
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10292
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit de1cda674b1fc6f97294ccfb44f0a0b3950eee74
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 8 16:18:13 2015 +0530
tests: Disable flush-behind
Change-Id: Ibbb6b03d2878ef4a049f737662c31e70a68e5755
BUG: 1219816
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10666
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 0f6fa9527f107bed2c128e6efbc8c32a87b0b0cc
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri May 8 20:38:33 2015 +0530
features/changelog: Fixing compilation issue
This issue introduced due to manual rebase.
Change-Id: I0589f4a0a1270190340f419b8022d6483bcf853d
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1219479
Reviewed-on: http://review.gluster.org/10685
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit ee971c1d60341fba76521ab0abf90f565a90ae8d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Apr 26 14:28:00 2015 +0530
cluster/ec: Change meaning of trusted.ec.dirty
- With this change, the xattr will represent if the file needs to be healed or
not. It will have different values for data/entry and metadata changes.
- inode ref leaks and dict_set_dynstr related leaks fixed
- Added support for trylock/lock based on heal-cmd execution or not
in data heal.
- Made fixes to pass regression runs
Change-Id: I9d8def4c2badde18a76b7898816fecfac113737a
BUG: 1215265
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10385
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d989a6f312ccdafbb05fc0b255784c9bb206bc60
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri May 8 05:59:15 2015 +0200
Tests: fix file count in ec-readdir.t
On BSD systems, ls(1) reports dot-files when it is run as root, while
Linux ls(1) does not do that. In ec-readdir.t, this means the directory
count is different because of .trashcan directory.
Fix this by using ls $M0/* instead of ls $M0
BUG: 1129939
Change-Id: Ia337c8a8e68a163ed527c0e4cbe313072ab1672b
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10657
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 05f55fa447c7952069d4b454a17f4752a3358fdf
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Apr 25 15:58:09 2015 +0530
cluster/ec: data heal implementation for ec
Data self-heal:
1) Take inode lock in domain 'this->name:self-heal' on 0-0 range (full file),
So that no other processes try to do self-heal at the same time.
2) Take inode lock in domain 'this->name' on 0-0 range (full file),
3) perform fxattrop+fstat and get the xattrs on all the bricks
3) Choose the brick with ec->fragment number of same version as source
4) Truncate sinks
5) Unlock lock taken in 2)
5) For each block take full file lock, Read from sources write to the sinks, Unlock
6) Take full file lock and see if the file is still sane copy i.e. File didn't become unusable while the bricks are offline.
Update mtime to before healing
7) xattrop with -ve values of 'dirty' and difference of highest and its own
version values for version xattr
8) unlock lock acquired in 6)
9) unlock lock acquired in 1)
Change-Id: I6f4d42cd5423c767262c9d7bb5ca7767adb3e5fd
BUG: 1215265
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10384
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 50d0d6e6e19e016a4bfb63a166951f00531cad23
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Apr 16 09:25:31 2015 +0530
cluster/ec: metadata/name/entry heal implementation for ec
Metadata self-heal:
1) Take inode lock in domain 'this->name' on 0-0 range (full file)
2) perform lookup and get the xattrs on all the bricks
3) Choose the brick with highest version as source
4) Setattr uid/gid/permissions
5) removexattr stale xattrs
6) Setxattr existing/new xattrs
7) xattrop with -ve values of 'dirty' and difference of highest and its own
version values for version xattr
8) unlock lock acquired in 1)
Entry self-heal:
1) take directory lock in domain 'this->name:self-heal' on 'NULL' to prevent
more than one self-heal
2) we take directory lock in domain 'this->name' on 'NULL'
3) Perform lookup on version, dirty and remember the values
4) unlock lock acquired in 2)
5) readdir on all the bricks and trigger name heals
6) xattrop with -ve values of 'dirty' and difference of highest and its own
version values for version xattr
7) unlock lock acquired in 1)
Name heal:
1) Take 'name' lock in 'this->name' on 'NULL'
2) Perform lookup on 'name' and get stat and xattr structures
3) Build gfid_db where for each gfid we know what subvolumes/bricks have
a file with 'name'
4) Delete all the stale files i.e. the file does not exist on more than
ec->redundancy number of bricks
5) On all the subvolumes/bricks with missing entry create 'name' with same
type,gfid,permissions etc.
6) Unlock lock acquired in 1)
Known limitation: At the moment with present design, it conservatively
preserves the 'name' in case it can not decide whether to delete it. this can
happen in the following scenario:
1) we have 3=2+1 (bricks: A, B, C) ec volume and 1 brick is down (Lets say A)
2) rename d1/f1 -> d2/f2 is performed but the rename is successful only on one
of the bricks (Lets say B)
3) Now name self-heal on d1 and d2 would re-create the file on both d1 and d2
resulting in d1/f1 and d2/f2.
Because we wanted to prevent data loss in the case above, the following
scenario is not healable, i.e. it needs manual intervention:
1) we have 3=2+1 (bricks: A, B, C) ec volume and 1 brick is down (Lets say A)
2) We have two hard links: d1/a, d2/b and another file d3/c even before the
brick went down
3) rename d3/c -> d2/b is performed
4) Now name self-heal on d2/b doesn't heal because d2/b with older gfid will
not be deleted. One could think why not delete the link if there is
more than 1 hardlink, but that leads to similar data loss issue I described
earlier:
Scenario:
1) we have 3=2+1 (bricks: A, B, C) ec volume and 1 brick is down (Lets say A)
2) We have two hard links: d1/a, d2/b
3) rename d1/a -> d3/c, d2/b -> d4/d is performed and both the operations are
successful only on one of the bricks (Lets say B)
4) Now name self-heal on the 'names' above which can happen in parallel can
decide to delete the file thinking it has 2 links but after all the
self-heals do unlinks we are left with data loss.
Change-Id: I3a68218a47bb726bd684604efea63cf11cfd11be
BUG: 1213358
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10298
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0651e05f7398e954855605a80e2b8299096f11cb
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Wed Apr 29 17:33:43 2015 +0530
features/changelog: Avoid creation of empty changelogs
An empty changelog when rolled over gets unlinked and indexed with
a modified path-name in htime file. The modification is "changelog"
not "CHANGELOG" in basename of the empty changelog file.
Change-Id: I77fd0b48b5c33c245418f5ac7a9756f08ece24d9
BUG: 1208470
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/9572
Tested-by: NetBSD Build System
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c76fc833f3ef75b07eac360f1000cc17f84b410c
Author: Joseph Fernandes <josferna@redhat.com>
Date: Fri May 8 15:18:06 2015 +0530
tiering: Correction to tiering documentation
1) convert to md format
2) Add info about ctr and libgfdb
Change-Id: I531d8a0bff8195f759302c5e613c7af2113729eb
BUG: 1218638
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10665
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 450e2505c53b7b7e2be54c92fb09af27a75a10a1
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri May 8 11:26:20 2015 +0530
tests: Marked tests/bugs/snapshot/bug-1112559.t as bad-test
The fix that introduced this test has been reverted as part of design change.
Hence marking it as a bad test.
Change-Id: I811b6050edbf4bbb40b9ef518604d21d386f6d5c
BUG: 1219738
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10660
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8262efe30c9a85a421bfa3b45294e575770248d2
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue May 5 10:28:15 2015 +0200
rpm: reduce package dependencies and add -client-xlators
Restructuring the RPM packages in order to reduce the dependencies that
get installed for glusterfs-api (mainly on request for Qemu hosts).
The dependencies of these packages look roughly like this:
.------------------.
| glusterfs-server |
'-------+----------'
|\
| \
| '---------------+--------------------.
| | |
| v v
| .----------------. .---------------.
| | glusterfs-fuse | | glusterfs-api |
| '--------+-------' '------+--------'
| /| /|
| / | / |
| / | / |
| / | / |
| .-----------+----=---------------' |
|/ | |
v v v
.-----------. .--------------------------.
| glusterfs | | glusterfs-client-xlators |
'-----------' '--------------------------'
With this structure, users can install glusterfs-server, glusterfs-fuse
or glusterfs-api (libgfapi) without getting any unneeded xlators or
other scripts/binaries.
The "glusterfs" and "glusterfsd" binary (symlinked) is now part of the
glusterfs-fuse package (moved from glusterfs). This does not make a
difference for glusterfs-server installations, because a server
installation always needs the glusterfs-fuse package for doing internal
mounts.
The advantage is that glusterfs-api does not pull in any executables
that get into the $PATH. This has caused confusion before when people
tried to remove the (wrongly assumed) server-only "glusterfsd" binaries.
URL: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10643
Change-Id: Id03f1a634ea3c62ab7008345be92e01ccf43b1a6
BUG: 1195947
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10554
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit ae8a940363332380694b21cec184202f24199963
Author: arao <arao@redhat.com>
Date: Tue Feb 17 16:53:14 2015 +0530
dht: Fixing dereference after null check
CID: 1223229
The 'loc' ptr is not checked before
dereferencing, which is handled.
Change-Id: Icf668150bde190e6f1b9f58a038099338516efe8
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9666
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 0c7977408acd9d22c50c3a1e4e2be3369e334bff
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon May 4 11:58:23 2015 +0530
features/bitrot: Scrubber pause/resume
With logical scan/scrub split, pausing filesystem scrubber is an
override to the thread throttling mechanism, which effectively
throttles "down" number of scrubber threads to zero. This causes
scanner to wait until threads are spawned again (when resumed)
thereby continuing where it left off (since the file tree walk
stack is effectively preserved when the main scanner thread
is waiting for scrubbers to consume scanned entries).
The only catch is when scrubber daemon restarts: file tree walk
stack is lost and scrubbing initiates from root. This is probably
OK for now (can be changed later to persist parent directory
information before entering pause state).
Change-Id: I5109a749b7fccd0f5367765078f46e6522dd32a1
BUG: 1208131
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10521
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 017e20c18ef63f5368a70cf8041d49b58dbb82d4
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Apr 23 16:24:43 2015 +0530
tiering: Do not allow some operations on tiered volume
Some operations like add-brick,remove-brick,rebalance,
replace-brick are not supported on tiered volume.
But there is no code level check for this. This patch
will allow to do the same
Change-Id: I12689f4e902cf0cceaf6f7f29c71057305024977
BUG: 1205624
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10349
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 64c9c01765763b7176b5e7dc834235d864d62e12
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Apr 27 21:34:34 2015 +0530
features/bitrot: Throttle filesystem scrubber
This patch introduces multithreaded filesystem scrubber based
on throttling option configured for a particular volume. The
implementation "logically" breaks scanning and scrubbing with
the number of scrubber threads auto-configured depending upon
the throttle configuration. Scanning (crawling) is left single
threaded (per brick) with entries scrubbed in bulk. On reaching
this "bulk" watermark, scanner waits until entries are scrubbed.
Bricks for a particular volume have a set of thread(s) assigned
for scrubbing, with entries for each brick scrubbed in a round
robin fashion to avoid scrub "stalls" when a brick (out of N
bricks) is under active scrubbing.
This mechanism helps us implement "pause/resume" with ease: all
one need to do is to cleanup scrubber threads and let the main
scanner thread "wait" untill scrubbing is resumed (where the
scrubber thread(s) are spawned again), therefore continuing
where we left off (unless we restart the deamons, where crawl
initiates from root directory again, but I guess that's OK).
[
NOTE:
Throttling is optional for the signer daemon, without which
it runs full throttle. However, passing "-DBR_RATE_LIMIT_SIGNER"
predefined in CFLAGS enables CPU throttling (during checksum
calculation) thereby avoiding high CPU usage.
]
Subsequent patches would introduce CPU throttling during hash
calculation for scrubber.
Change-Id: I5701dd6cd4dff27ca3144ac5e3798a2216b39d4f
BUG: 1207020
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10511
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9a862ad86a82183f79f9483fcab2ead61523b991
Author: Dan Lambright <dlambrig@redhat.com>
Date: Thu May 7 22:48:24 2015 -0400
Documentation for tiering feature. (WIP)
This is a WIP.
Change-Id: Ia36f77d158a370f77cb866a32308b27e10d39b5e
BUG: 1218638
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10656
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 3cb543198b13dc9c64ea17f192f1d026662e78f3
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed May 6 18:18:25 2015 +0530
tiering/cli: while attaching tier to volume cli should ask question
Because of tiering feature is recommended only for testing purpose in
this release, attaching tier should get a confirmation from the user
before proceeding with the command.
Change-Id: I141bbb1d0439f0a28eb51d17f7800908e35c75ad
BUG: 1219032
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10610
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0deb818086d17e9c1a80e8fa3229c934c1b60d5d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue May 5 06:50:46 2015 +0530
features/shard: Implement [f]truncate fops
To-Do:
* Make ftruncate work even in the absence of path
* Aggregate and update ia_blocks appropriately when a file is
truncated to a lower size.
Change-Id: Ifd24c2f5e80d2c3bc921261f5481251df8948126
BUG: 1207615
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10631
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 104c60f7d08746ca86a512246fd52e1d837924ef
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed May 6 10:28:56 2015 +0200
nfs: allocate the auth_cache->cache_dict on auth_cache_init()
It seems possible that auth_cache->cache_dict is not always allocated
before it is accessed. Instead of allocating the dict upon the 1st
access, just create it in auth_cache_init().
Change-Id: I00e60522478b433cb0aae0c1f0948eac544dfd2b
URL: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10710
BUG: 1143880
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10600
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: NetBSD Build System
commit cc82afa9e0d5ca49e56a6396a85fddec630a4b21
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu May 7 12:39:05 2015 +0200
glupy: fix tuntime search path and python module directory layout
1) The glupy.so xlator should embed the runtime search path for
the python libraries. Unfortunately, python-config does not
gives the appprioate flags, therefore we need to also use
pkg-config to obtain them
2) Fix the glupy python module directory layout so that python
can import the module without problem
That two fixes seems to let glupy.t pass on NetBSD again.
BUG: 1129939
Change-Id: I397aa726ab8bf7d91fa0d6d870a30910a5f4a5d9
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10616
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 5a1555c6316589adc86c4fcda09e7018ebe8822f
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu May 7 20:28:11 2015 +0200
Restore build on non Linux systems
This change broke the build on NetBSD, FreeBSD, and MacOS X:
http://review.gluster.org/10526/
We restore the build with two fixes:
- Use POSIX-compliant sysconf(_SC_NPROCESSORS_ONLN) to get the
number of processors, instead of Linux specific get_nprocs().
That let us remove Linux-specific #include <sys/sysinfo.h>
- Only define MAX() if it is not already defined. NetBSD defines
it in <sys/param.h> which is already included
BUG: 1129939
Change-Id: I62341c670598670e47ea2f69ab94864f96588b18
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10652
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d431f5900e97ea3bdd35692ebbcc043fa6b70db1
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Thu May 7 15:34:06 2015 +0530
NFS-Ganesha : Improved sed expression in cleanup
The global config file should not be emptied when
tear down is called. Improving the sed expression
to delete the ".conf" files only
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Change-Id: Ida3d303f629cb512c02dadacce1ec7e5f07db018
BUG: 1218854
Reviewed-on: http://review.gluster.org/10630
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1a76c49edd4c2efed8b604a1087eadaf2d15a2b7
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri Apr 17 15:00:13 2015 +0530
features/bit-rot: Token Bucket based throttling
BitRot daemons (signer & scrubber) are disk/cpu hoggers when left
running full throttle. Checksum calculations (especially SHA family
of hash routines) can be quite CPU intensive. Moreover periodic
disk scans performed by scrubber followed by reading data blocks
for hash calculation (which is also done by signer) generate lot
of heavy IO request(s). This causes interference with actual client
operations (be it a regular client or filesystems daemons such as
self-heal, etc..) and results in degraded system performance.
This patch introduces throttling based on Token Bucket Filtering[1].
It's a well known algorithm for checking (and ensuring) that data
transmission conform to defined limits and generally used in packet
switched networks. Linux control groups (Cgroups) uses a variant[2]
of this algorithm to provide block device IO throttling (cgroup
subsys "blkio": blk-iothrottle).
So, why not just live with Cgroups?
Cgroups is linux specific. We need to have a throttling mechanism
for other supported UNIXes. Moreover, having our own implementation
gives much more finer control in terms of tuning it for our needs
(plus the simplicity of the alogorithm itself).
Ideally, throttling should be a part of server stack (either as a
separate translator or integrated with io-threads) since that's
the point of entry for IO request(s) from *all* client(s). That
way one could selectively throttle IO request(s) based on client
PIDs (frame->root->pid), e.g., self-heal daemon, bitrot, etc..
(*actual* clients can run full throttle). This implementation
avoids that deliberately (there needs to be a much more smarter
queueing mechanism) and throttles CPU usage for hash calculations.
This patch is just the infrastructure part with no interfaces
exposed to set various throttling values. The tunable selected
here (basically hardcoded) avoids 100% CPU usage during hash
calculation (with some bursts cycles). We'd need much more
intensive test(s) to assign values for various throttling
options (lazy/normal/aggressive).
[1] https://en.wikipedia.org/wiki/Token_bucket
[2] http://en.wikipedia.org/wiki/Token_bucket#Hierarchical_token_bucket
Change-Id: Icc49af80eeab6adb60166d0810e69ef37cfe2fd8
BUG: 1207020
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10307
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit eda6259f9cbc2ee952f42f96812d5c0a075d2354
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Apr 29 15:52:37 2015 +0200
Tests: use a portable way to flush kernel cache
On Linux, kernel cache can be flushed using
echo 3 > /proc/sys/vm/drop_caches
This non-portable approach can be replaced by an on-purpose
failed attempt to unmount: if the mount point is the current
directory and umount is called, the kernel will flush inodes
until it realize it cannot complete the operation because
root of filesystem is busy:
( cd $M0 ; umount $M0 )
Unfortunately this does not flush everything. Entries may
still be present in the kenrel FUSE cache. Using $GFS to
mount the filesystem ensure --entry-timeout=0 and clears
this problem.
Some stall information may also remain in glusterfs caches,
and that may have to be adressed by appropriate volume option.
For instance tests/bugs/rpc/bug-954057.t needs to disable
performance.stat-prefetch. Qtherwise, root's new credentials
are not evaluated after root-quash is enabled. The test could
also be done with performance.stat-prefetch enabled using
various tricks: copying the file to read, creating a hard link
on it, or just waiting long enough for metadata cache to expire.
BUG: 1129939
Change-Id: I54929e899d55c04dcd9d947809133549f01fd0e1
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10411
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c75ab574c7e560ee909a8de35570240790bbcb03
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue May 5 18:20:19 2015 +0530
geo-rep: Fix Default values in Xml output
Default Values for last_synced, checkpoint_time and
checkpoint_completion_time was zero instead of 'N/A'
BUG: 1212410
Change-Id: Ie775508f8dcb9ba6f311946a2039739e4336d9a6
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10580
Reviewed-by: darshan n <dnarayan@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bbe27380a7694a92c1d08faab21e451cb9bf8a35
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Apr 21 23:45:07 2015 +0530
tools/glusterfind: Rpm install dependencies added
Argparse Python library is available as standard library in Python 2.7
In rhel, we need to install python-argparse.
Also added pyxattr dependency to the spec file.
Change-Id: Ie50278eddf81e7cbf98d1e8d27e411b46676b432
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1209138
Reviewed-on: http://review.gluster.org/10321
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0ced18fa46b1f2d8125aafb6c7833ad2af2b989c
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue May 5 14:26:05 2015 +0530
geo-rep: Fix Rsync hang issue
When rsync is executed using Python subprocess, by default
stdout of subprocess will be None. With the log rsync performance
patch stdout is assigned to PIPE. Rsync writes to that PIPE
whenever it syncs files. If log_rsync_performance is disabled
then nobody will consume stdout and that gets full. Rsync hangs
if PIPE is full.
log_rsync_performance option is introduced with patch 10070
With this patch stdout=PIPE only if log_rsync_performance is
enabled. Also removed -v option from Rsync.
Thanks Venky and Kotresh for RCA.
BUG: 1218552
Change-Id: I4ebcfb6999358c8e2c147f7964255bd836ed7499
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10556
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c771e840ac1c33cec565a2c3e33b24bc8f985bbc
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Wed May 6 12:13:31 2015 +0530
NFS-Ganesha: Add-node and delete-node changes in HA implementation
NFS-Ganesha related config files have to be copied over to the new node
and NFS-Ganesha service has to be started.
Similary NFS-Ganesha service has to be stopped when a node is
deleted from the HA cluster.
Change-Id: Ia38e72cac86713fe23b7d1b829a256637a9ca796
BUG: 1212816
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/10596
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 44c7f4eda30554b3399d87e6d573619ef3d0eb11
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Feb 12 18:59:35 2015 +0530
snapshot: Handshake with glusterd is not proper
If a snap is activated or deactivated, when a node is down,
it is not retrieving the data properly during the handshake
of glusterd
With this patch, a version check will made when a glusterd
is started running. If there is a mismach in version, then
peers will exchange the healed data.
Change-Id: I8bd2a347723db2194d3fa73295878b4dd2e9be5d
BUG: 1122377
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9664
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit e01a7937d5b55b0169447e265ddfda1101486fc9
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Tue May 5 23:47:58 2015 +0530
tests: Spurious failure in fop-sanity.t
Modified the calls to open in fops-sanity.c to pass in
the mode as well if flags includes O_CREAT (as per man page).
The missing mode randomly caused T files to be created causing DHT
to treat them as linkto files and fail the fop.
Modified 2 other files where the mode was not being provided.
Change-Id: I047573d43655b4957d0703f7df36238f7e729c1f
BUG: 1218951
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/10590
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 9e5b6d0f5411ef28fd1acf2981fd4022728ebbb1
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Apr 3 18:03:50 2015 +0200
stripe: set ENOENT when a READ hits EOF
The NFS-server sets EOF only in the READ reply when op_errno is set to
ENOENT. Xlators are expected to set op_errno to ENOENT when EOF is
reached, op_ret will contain the number of bytes returned by the READ.
When an NFS-client (like VMware ESXi) do a READ that exceeds the size of
the file, errno should be set to EOF and the return value contains the
number of bytes that are read (from the requested offset, until the end
of the file). Not setting EOF on a correct short READ, can result in
errors on the NFS-client.
This is not an issue with the Linux NFS-client (or VFS). Linux is smart
enough to not try to read more bytes than the file contains.
BUG: 1209298
Change-Id: Ib15538744908a6001d729288d3e18a432d19050b
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10142
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 759348f849581baaa008037706b42efb4df60dda
Author: Susant Palai <spalai@redhat.com>
Date: Mon May 4 16:43:02 2015 +0530
dht/rebalance: Throttle rebalance
Throttle value will be "normal" by default. For throttling down,
a thread will be put in to sleep. And for throttling up,
gf_defrag_process_dir will wake up the sleeping threads.
Change-Id: I74d530e3effd6e60e6eec81ccc8ff65789fa9c13
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/10526
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 9c08ad24a9df14a1fb2aa7c3128744721b96d35b
Author: Anuradha <atalur@redhat.com>
Date: Thu Apr 30 15:31:13 2015 +0530
cluster/afr : Prevent inode-evict during split-brain resolution
1) Provided setfattr command to set timeout for split-brain
choice.
2) If split-brain inspection/resolution is being done
from the mount for a file, ref the inode when
split-brain-choice is set.
This inode will be unconditionally unref-ed after timeout
seconds set by the user/default otherwise.
3) Updated the doc and testcase to reflect the changes.
Change-Id: I15c9037dee28855f21e680e7e3632e1f48dba4e1
BUG: 1209104
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/10134
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 4affe769653ac062043bed92ebb2cf3583c715bc
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Mon Apr 13 12:34:26 2015 +0530
bitrot/glusterd: Bitrot scrub pause/resume should give proper error
bitrot scrubber paused/resume command should give proper error messages if
scrubber already pause/resume and user again try to perform same
operation on a volume.
Change-Id: I01ad69c80f03b177535a4e5f1c95ab7709a804b0
BUG: 1210684
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10209
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit f94350c6e6bf0fde721648302955e36f3cae040e
Author: Kaushal M <kaushal@redhat.com>
Date: Wed May 6 13:10:15 2015 +0530
glusterd: Use generation number to find peerinfo in RPC notifications
The generation number for each peerinfo object is unique. It can be used
to find the exact peerinfo object, which is required for peer RPC
notifications.
Using hostname and uuid matching to find peerinfos can return incorrect
peerinfos to be returned in certain cases like multi network peer probe.
This could cause updates to happen to incorrect peerinfos.
Change-Id: Ia0aada8214fd6d43381e5afd282e08d53a277251
BUG: 1215018
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/10495
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bf0084969aee989823eeb32847a7dc014547826b
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Fri Mar 27 15:20:03 2015 +0530
glusterd: remove replace brick with data migration support form cli/glusterd
Replace-brick operation with data migration support have been
deprecated from gluster.
With this fix replace brick command will support only one commad
gluster volume replace-brick <VOLNAME> <SOURCE-BRICK> <NEW-BRICK> {commit force}
Change-Id: Ib81d49e5d8e7eaa4ccb5830cfec2bc081191b43b
BUG: 1094119
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10101
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 043a3e7257c3aa39d4fcad959dc0d3d989398cc9
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Apr 9 00:14:50 2015 +0530
features/changelog: Version support for Changelog Parser
As optional feature, during unlink, full path will be recorded.
Changelog Version number to be bumped up to 1.2.
With this patch, parser checks the version number before parsing
and handles accordingly.
Change-Id: Ic1ad98259c39e417029a08e26a1d4b467817e65a
BUG: 1214561
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10166
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit ccf04608feb66b1926162eabbe7e20606a367886
Author: Ashish Pandey <aspandey@redhat.com>
Date: Tue Apr 21 17:22:40 2015 +0530
cluster/ec: add separate versions for data/entry, metadata
Adding 64 bits in "version" key of extended attributes. First 64 bits (Left)
represents Data version. Last 64 bits (right) represents Meta Data version.
Note: 3.7 and 3.6 version ec can't co-exist with this change because xattrop in
3.6 will fail with ERANGE as the buffer passed to it will be '8' bytes where as
the value will be 16 bytes in 3.7. Where as 3.7 version clients can work with
old version files. For upgrades we need to tell users to complete heals and
then upgrade
BUG: 1215265
Change-Id: Ib85114680cb7e75b8371c984d9f7b6401c1ffb93
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/10312
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit c5e00c556c8ac0e9c5fd205b1792bfacf05396e3
Author: vmallika <vmallika@redhat.com>
Date: Thu Apr 30 16:50:47 2015 +0530
quota/marker: turn off inode quotas by default
inode quota is a new feature implemented in glusterfs-3.7
if quota is enabled in the older version and is upgraded
to a new version, we can hit setxattr spike during self-heal
of inode quotas. So, when a quota is enabled, turn off
inode-quotas with a xlator option.
With this patch, we still account for inode quotas but only
when a write operation is performed for a particular file.
User will be able to query inode quotas once the Inode-quota
xlator option is enabled.
Change-Id: I52fb28bf7024989ce7bb08ac63a303bf3ec1ec9a
BUG: 1209430
Signed-off-by: vmallika <vmallika@redhat.com>
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/10152
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3b9fe12e1ddeec9c11a7ba1df46adf2337e4c231
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Wed May 6 09:58:11 2015 +0530
NFS-Ganesha : Do not empty global config file when cluster is torn
The global config file will need new blocks to support client lock recovery.
Current cleanup function empties the entire file. Deleting only "include"
lines in the config file.
Change-Id: I21f09e30a738d2ba01861ce480ecf906667d887b
BUG: 1218854
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/10592
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 0db1d760d3d9c4f6f1c729499c0840a11fa75a01
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Mon Apr 20 10:41:47 2015 +0530
NFS-Ganesha : Locking global options file
Global option gluster features.ganesha enable
writes into the global 'option' file. The snapshot
feature also writes into the same file.
To handle concurrent multiple transactions correctly,
a new lock has to be introduced on this file.
Every operation using this file needs
to contest for the new lock type.
Change-Id: Ia8a324d2a466717b39f2700599edd9f345b939a9
BUG: 1200254
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/10130
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit ab2db37433cdc2f8e0d62870515af764ca4cd760
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed May 6 16:26:03 2015 +0530
doc/admin-guide: BitRot command line usage
Change-Id: Ic3c9da566673f4d9b1d0974c5aa15121da087fba
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10607
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 6e98cbcc9e8c8d331382edef2d7cc85407080c7c
Author: Joseph Fernandes <josferna@redhat.com>
Date: Fri Apr 24 19:22:44 2015 +0530
ctr/xlator: Named lookup heal of pre-existing files, before ctr was ON.
Problem: The CTR xlator records file meta (heat/hardlinks)
into the data. This works fine for files which are created
after ctr xlator is switched ON. But for files which were
created before CTR xlator is ON, CTR xlator is not able to
record either of the meta i.e heat or hardlinks. Thus making
those files immune to promotions/demotions.
Solution: The solution that is implemented in this patch is
do ctr-db heal of all those pre-existent files, using named lookup.
For this purpose we use the inode-xlator context variable option
in gluster.
The inode-xlator context variable for ctr xlator will have the
following,
a. A Lock for the context variable
b. A hardlink list: This list represents the successful looked
up hardlinks.
These are the scenarios when the hardlink list is updated:
1) Named-Lookup: Whenever a named lookup happens on a file, in the
wind path we copy all required hardlink and inode information to
ctr_db_record structure, which resides in the frame->local variable.
We dont update the database in wind. During the unwind, we read the
information from the ctr_db_record and ,
Check if the inode context variable is created, if not we create it.
Check if the hard link is there in the hardlink list.
If its not there we add it to the list and send a update to the
database using libgfdb.
Please note: The database transaction can fail(and we ignore) as there
already might be a record in the db. This update to the db is to heal
if its not there.
If its there in the list we ignore it.
2) Inode Forget: Whenever an inode forget hits we clear the hardlink list in
the inode context variable and delete the inode context variable.
Please note: An inode forget may happen for two reason,
a. when the inode is delete.
b. the in-memory inode is evicted from the inode table due to cache limits.
3) create: whenever a create happens we create the inode context variable and
add the hardlink. The database updation is done as usual by ctr.
4) link: whenever a hardlink is created for the inode, we create the inode context
variable, if not present, and add the hardlink to the list.
5) unlink: whenever a unlink happens we delete the hardlink from the list.
6) mknod: same as create.
7) rename: whenever a rename happens we update the hardlink in list. if the hardlink
was not present for updation, we add the hardlink to the list.
What is pending:
1) This solution will only work for named lookups.
2) We dont track afr-self-heal/dht-rebalancer traffic for healing.
Change-Id: Ia4bbaf84128ad6ce8c3ddd70bcfa82894c79585f
BUG: 1212037
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10370
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a2aa4254b1df93b195f49ceff63a193c99b95c7a
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Apr 15 12:15:58 2015 +0530
nfs : fix for coredump caused by export/netgroup feature in the regression
Change-Id: Idaae234b9e81c40040393e748db1f61363a48ed0
BUG: 1211913
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/10250
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 5d2b6f9250b81896c16d9464855671a49cc8864e
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Apr 9 16:26:31 2015 +0530
features/bitrot: Follow xattr naming conventions
Instead of "trusted.glusterfs.bit-rot.*" use "trusted.bit-rot.*"
NOTE:
With this patch, data on existing volumes would be resigned
(which should be OK as of now since we do not expect many
users as of now :-))
Change-Id: I926c7bca266a9c8f2cb35d57c4d0359aa5cecfa0
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10181
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 08a97d9375697a79712f488350e6f7397d4f2898
Author: Susant Palai <spalai@redhat.com>
Date: Tue May 5 18:11:52 2015 +0530
dht/rebalance: Go to exit if defrag is NULL
Problem: In case a defrag is null, going to out section will crash rebalance.
Change-Id: I8b3ee1ad85dc23ef0e2f2dd6f912d07216bd619f
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/10582
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit f1eaba0ca6a20d26a5a8e38ab39f336ba3e1bb12
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Sat Apr 25 18:50:46 2015 +0530
features/shard: Implement readv() fop
Change-Id: I4cc060710482de8633141170dd35f669f01f639b
BUG: 1207615
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10528
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a0eafcdeeb918bc5cfcb607ecca79192058898a6
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Mar 11 14:20:48 2015 +0530
libgfapi : anonymous fd support
Anonymous fd's are floating fd assigned to a glusterfs client
without a explicit file open. Here either it will create a new
anonymous fd or existing anonymous fd in the client stack for
requested file.The anonymous fd's are mainly used for IO's.
This patch introduces two api's glfs_h_anonymous_read and
glfs_h_anonymous_write which performs read and write respectively
Change-Id: Id646f2220e8387b2f8bb244c848dc1db6761444f
BUG: 1204651
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9971
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1484b38b3920b5ff45eb8b5449550e0ef2ee9df3
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Tue May 5 18:19:51 2015 +0530
Cache-invalidation : set to on/off depending on ganesha.enable value
Multi-Head NFS-Ganesha servers need upcall (cache-invalidation)
support to notify them in case of any changes to the files in the backend.
Hence, upcall xlator option "features.cache-invalidation" needs to be enabled
when ganesha.enable is set to 'on'. Similarly, this feature needs
to be disabled when ganesha.enable is set to 'off'
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Change-Id: Ifdd1d50e48a2bd2a388f73c0b9e318c6092ac190
BUG: 1213752
Reviewed-on: http://review.gluster.org/10581
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 90ea6a6211bddf0e79caa439643f2f1f8db6a3f7
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Apr 23 22:57:39 2015 +0530
api/libgfapi: Add support for statfs handle
snapd feature require statfs fops and thereby
handle of statfs
Change-Id: I037ee846aee3971826a73c592e15f1be27796c64
BUG: 1176837
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10356
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit d9bac2eae66bccb3d697ad490ec1156c20362918
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue May 5 08:47:38 2015 -0400
build: gluster-api-devel requires libacl-devel
building libvirt fails
Change-Id: I355879e6c6f56e49c4ee78e1a9763598acacd074
BUG: 1218625
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/10579
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fdb2719189df155c26929b4b04ac7ea437373f52
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue May 5 08:48:01 2015 +0530
cleanup: Unmount all fuse mounts
Change-Id: I851b4bd74b595d739f7bf9eea920d07e31fa5fbc
BUG: 1202244
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10540
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b45d871d96a7b4be4b54db6401063c997c1504f7
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed Apr 29 15:35:56 2015 -0400
guster/dht: tiered volumes may not allow access to files undergoing migration
If a read IO occurs against a file that has reached rebalance
phase 2, we redirect the IO to the destination. For tiered
volumes, when we try to reopen the file (on the destination),
the lower level DHT receives the open call and fails; it does
not have a "cached subvol". Fix is to "teach" the lower level
DHT of the new location by sending a locate before the open.
Change-Id: Ia4acb0035ff1da15f6a8f9ed54f43c76e8b98f5f
BUG: 1214048
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Signed-off-by: root <root@gprfs018.sbu.lab.eng.bos.redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10324
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 91403e6bd4e4fe259fdc019c86c729bb722d0470
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Mon Apr 27 21:18:10 2015 +0530
geo-rep: rename handling in dht volume
Background:
Glusterfs changelogs are stored in each brick, which records the changes
happened in that brick. Georep will run in all the nodes of master and
processes changelogs "independently".
Processing changelogs is in brick level, but all the fops will be replayed
on "slave mount" point.
Problem:
With a DHT volume, in changelog "internal fops" are NOT recorded.
For Rename case, Rename is recorded in "hashed" brick changelog.
(DHT's internal fops like creating linkto file, unlink is NOT recorded).
This lead us to inconsistent rename operations.
For example,
Distribute volume created with Two bricks B1, B2.
//Consider master volume mounted @ /mnt/master
and following operations executed:
cd /mnt/master
touch f1 // f1 falls on B1 Hash
mv f1 f2 // f2 falls on B2 Hash
// Here, Changelogs are recorded as below:
@B1
CREATE f1
@B2
RENAME f1 f2
Here, race exists between Brick B1 and B2, say B2 will get executed first.
Source file f1 itself is "NOT PRESENT", so it will go ahead and create
f2 (Current implementation).
We have this problem When rename falls in another brick and
file is unlinked in Master.
Similar kind of issue exists in following case too(multiple rename):
CREATE f1
RENAME f1 f2
RENAME f2 f1
Solution:
Instead of carrying out "changelogging" at "HASHED volume",
carry out at the "CACHED volume".
This way we have rename operations carried out where actual files are present.
So,Changelog recorded as :
@B1
CREATE f1
RENAME f1 f2
credit: sarumuga@redhat.com
PS: Some of the races as the one below are _NOT_ fixed by this patch
* f1 and f2 exist. B1 and B2 are their respective cached subvols. For
both files hashed-subvol == cached-subvol
* mv f1 f2 on master.
* B1 has change-log entry of rename f1 f2
* rebalance migrates f2 from B1 and B2
* mv f2 f1 on master.
* B2 has change-log entry of rename f2 f1
Since changelog entries (rename f1 f2) and (rename f2 f1) are processed
independently by gsyncds, which of either f1 and f2 survives on slave
is subject to race. Note that on master its file f1 with name f1 which
survived. On slave it can be either file f1 with name f1 or file f2
with name f2 based on who wins the race of processing changelog.
Change-Id: Iebc222f582613924c3a7cba37fb6d3e2d8332eda
BUG: 1141379
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/10410
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 93d60fab25139b8af4fb646cce350756ff318d62
Author: Joseph Fernandes <josferna@redhat.com>
Date: Sun May 3 12:41:40 2015 +0530
dht/tier/rebalancer: Fix reset of tiering client pid
In the patch http://review.gluster.org/#/c/9657
the client pid set by tiering migration was getting over-
written in dht_start_rebalance_task(). Just corrected it
in dht_setxattr() before calling dht_start_rebalance_task()
and removed it from dht_start_rebalance_task().
Change-Id: I37cfa111f83a4e5d498042575c93799f60b49870
BUG: 1217937
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10502
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit b5f3316c82ba787f80f7f844338f4aafa4a70ce7
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Apr 24 15:33:25 2015 +0530
tiering: Send both attach-tier and tier-start together
After attaching tier, we have to start tier rebalance process.
This patch is to trigger tier start along with attch-tier.
Change-Id: I39380f95123f0087a82213ef263f9f33adcc5adc
BUG: 1214222
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10363
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit f34ef1ec47be876d72a639af86be159562023043
Author: Dan Lambright <dlambrig@redhat.com>
Date: Mon May 4 12:38:26 2015 -0400
glusterd/tiering: disable tiering if cluster runs older gluster versions
Do not allow attach or detach tier to work if any of the nodes
is running gluster code < 3.7.
Change-Id: Id9af8f4057f6fad9cb703ec7645bc01eccb11fc1
BUG: 1218287
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10531
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 260c4338b5cf1b59ead9d2b56b1b6d69459b4ea2
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Apr 28 16:26:33 2015 -0400
cluster/tier: don't use hot tier until subvolumes ready
When we attach a tier, the hot tier becomes the hashed
subvolume. But directories may not yet have been replicated by
the fix layout process. Hence lookups to those directories
will fail on the hot subvolume. We should only go to the hashed
subvolume once the layout has been fixed. This is known if the
layout for the parent directory does not have an error. If
there is an error, the cold tier is considered the hashed
subvolume. The exception to this rules is ENOCON, in which
case we do not know where the file is and must abort.
Note we may revalidate a lookup for a directory even if the
inode has not yet been populated by FUSE. This case can
happen in tiering (where one tier has completed a lookup
but the other has not, in which case we revalidate one tier
when we call lookup the second time). Such inodes are
still invalid and should not be consulted for validation.
Change-Id: Ia2bc62e1d807bd70590bd2a8300496264d73c523
BUG: 1214289
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10435
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit 3b656973a1473d30a702e13fd8449d0851f54b1a
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue May 5 09:41:23 2015 +0200
Tests: wworkaround NetBSD failures in cdc.t
The volume reset network.compression operation cause brick processes to
be restarted. If the volume is already started, a brick process is already
there and the restart will fail, as the brick TCP port is already in use.
Because the new brick process is not started, the volume is left with
no brick online, and the volume stop operation will timeout waiting
for bricks to stop.
Obviosuly we have two bugs here
- If volume reset network.compression needs to restart the bricks, it
should first make sure the previous brick process is terminated
- volume stop should not wait forever for bricks to come back online
This change does not fix the bugs but just makes sure the volume
is stoped before volume reset network.compression, so that the failure
oes not happen.
BUG: 1129939
Change-Id: I9cd5cdc767ef6ee9dd31f2121d672dc3bfdce45f
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10553
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2f1e6002330c8eae21e79c03072165177d590d90
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Apr 30 13:28:44 2015 +0530
Upcall: Send stat as part of cache_invalidation notifications
Have added support to send attributes of both entries and
its parent (include oldparent in case of RENAME fop) in the
same notification request to avoid multiple rpc requests.
Also, made changes in gfapi to send parent object and its
attributes changed in a single upcall event.
Change-Id: I92833da3bcec38d65216921c2ce4d10367c32ef1
BUG: 1200262
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10460
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 0a22be8390a0f6804a02384409b83df952163b25
Author: Aravinda VK <avishwan@redhat.com>
Date: Sun Apr 12 17:46:45 2015 +0530
geo-rep: Minimize rm -rf race in Geo-rep
While doing RMDIR worker gets ENOTEMPTY because same directory will
have files from other bricks which are not deleted since that worker
is slow processing. So geo-rep does recursive_delete.
Recursive delete was done using shutil.rmtree. once started, it will
not check disk_gfid in between. So it ends up deleting the new files
created by other workers. Also if other worker creates files after one
worker gets list of files to be deleted, then first worker will again
get ENOTEMPTY again.
To fix these races, retry is added when it gets ENOTEMPTY/ESTALE/ENODATA.
And disk_gfid check added for original path for which recursive_delete is
called. This disk gfid check executed before every Unlink/Rmdir. If disk
gfid is not matching with GFID from Changelog, that means other worker
deleted the directory. Even if the subdir/file present, it belongs to
different parent. Exit without performing further deletes.
Retry on ENOENT during create is ignored, since if CREATE/MKNOD/MKDIR
failed with ENOENT will not succeed unless parent directory is created
again.
Rsync errors handling was handling unlinked_gfids_list only for one
Changelog, but when processed in batch it fails to detect unlinked_gfids
and retries again. Finally skips the entire Changelogs in that batch.
Fixed this issue by moving self.unlinked_gfids reset logic before batch
start and after batch end.
Most of the Geo-rep races with rm -rf is eliminated with this patch,
but in some cases stale directories left in some bricks and in mount
point we get ENOTEMPTY.(DHT issue, Error will be logged in Slave log)
BUG: 1211037
Change-Id: I8716b88e4c741545f526095bf789f7c1e28008cb
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10204
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c767848f804bbe0b2fc131ac4948741916f27109
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Mar 11 12:20:38 2015 +0530
rdma:properly handle iobuf_pool when rdma transport is unloaded
We are registering iobuf_pool with rdma. When rdma transport is
unloaded, we need to deregister all the buffers registered with
rdma. Otherwise iobuf_arena destroy will fail.
Also if rdma.so is loaded again, then register iobuf_pool with
rdma
Change-Id: Ic197721a44ba11dce41e03058e0a73901248c541
BUG: 1200704
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9854
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit a3a18731168109a45ffc48a729f1df72fc74f636
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Apr 28 10:24:28 2015 -0400
build: Autogenerated files delivered in dist tarball
Change-Id: I99028fe6ff4547f837b0997543234a9020b75607
BUG: 1216067
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/10429
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9503b21a38974f77b6b91e74a2a9fa1a651055b8
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Sat Apr 11 01:03:13 2015 +0530
glusterd: Coverity fix
CID: 1293504 (Calling xlator_set_option without checking return value )
CID: 1293502 (Dereferencing a pointer that might be null xl when calling
xlator_set_option)
CID: 1293500 (Assigning value from dict_get_int32(dict, "type", &type)
to ret here, but that stored value is overwritten before
it can be used.)
Change-Id: I5314fb399480df70bd77bc374e3b573f2efd5710
BUG: 1093692
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10201
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 2f0b2b8c4d5c5411757ed79552fc6accd71d3eb0
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Apr 30 14:14:14 2015 +0530
snapshot/scheduler: Use os.path.realpath() for path validation
In order to accomodate systems, where /var/run is a symlink to
/run, we are using os.path.realpath() for path validations.
Change-Id: I4eae536867ec6c88f92c762b92f5c1966b622bde
BUG: 1216931
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10464
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 49bdc93ede5bec7dcbc35f929395ca96b3279386
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue May 5 10:07:13 2015 +0530
doc: AFR arbiter volume usage
Contains information on creation and behaviour of replica 3 arbiter volumes.
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Change-Id: I6af4aa3488649686fdb9b839c733046160e0785b
BUG: 1199985
Reviewed-on: http://review.gluster.org/10541
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit e2e460f1072df85a663ea769b7bcbefb91d88e0b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue May 5 08:31:39 2015 +0530
tests: Unmount aux quota mount
Change-Id: Ie4ec40230e6b92d2e694b804a991246050b5fa51
BUG: 1202244
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10539
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Sachin Pandit <spandit@redhat.com>
commit 530f9aad50e814536f74d1519cb2652c6ae6c970
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Mar 12 16:07:13 2015 +0530
geo-rep: Status Enhancements
Discussion in gluster-devel
http://www.gluster.org/pipermail/gluster-devel/2015-April/044301.html
MASTER NODE - Master Volume Node
MASTER VOL - Master Volume name
MASTER BRICK - Master Volume Brick
SLAVE USER - Slave User to which Geo-rep session is established
SLAVE - <SLAVE_NODE>::<SLAVE_VOL> used in Geo-rep Create command
SLAVE NODE - Slave Node to which Master worker is connected
STATUS - Worker Status(Created, Initializing, Active, Passive, Faulty,
Paused, Stopped)
CRAWL STATUS - Crawl type(Hybrid Crawl, History Crawl, Changelog Crawl)
LAST_SYNCED - Last Synced Time(Local Time in CLI output and UTC in XML output)
ENTRY - Number of entry Operations pending.(Resets on worker restart)
DATA - Number of Data operations pending(Resets on worker restart)
META - Number of Meta operations pending(Resets on worker restart)
FAILURES - Number of Failures
CHECKPOINT TIME - Checkpoint set Time(Local Time in CLI output and UTC
in XML output)
CHECKPOINT COMPLETED - Yes/No or N/A
CHECKPOINT COMPLETION TIME - Checkpoint Completed Time(Local Time in CLI
output and UTC in XML output)
XML output:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
cliOutput>
geoRep>
volume>
name>
sessions>
session>
session_slave>
pair>
master_node>
master_brick>
slave_user>
slave/>
slave_node>
status>
crawl_status>
entry>
data>
meta>
failures>
checkpoint_completed>
master_node_uuid>
last_synced>
checkpoint_time>
checkpoint_completion_time>
BUG: 1212410
Change-Id: I944a6c3c67f1e6d6baf9670b474233bec8f61ea3
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10121
Tested-by: NetBSD Build System
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ce0b8d9a485c04ab2c4f860b34f10111c1f93549
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Apr 10 13:05:02 2015 +0530
doc/snapshot: doc for snapshot clone
Change-Id: Ie53e6ab780ab67ffe0c4f6d92fe4c0b779cec2c9
BUG: 1199894
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10187
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit f775f79809f15e9f2873338c935e660e7843b859
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Apr 13 11:56:35 2015 +0530
doc/geo-rep: Doc changes w.r.t common shared gluster meta volume
Change-Id: I71c466537a191caa5c5a4a11e67df384c24c73ef
BUG: 1210344
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10447
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 38882c393c212f8e80f474c1241d02318d9ecfd0
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue May 5 07:57:10 2015 +0530
doc: Feature doc for shard translator
Source: https://gist.github.com/avati/af04f1030dcf52e16535#sharding-xlator-stripe-20
Change-Id: I127685bacb6cf924bb41a3b782ade1460afb91d6
BUG: 1200082
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10537
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 86813a8310ca447349ea58ed5ba9b962a8cd5dc5
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Apr 15 22:22:08 2015 +0530
afr: add arbitration support
Add logic in afr to work in conjunction with the arbiter xlator when a
replica 3 arbiter volume is created. More specifically, this patch:
* Enables full locks for afr data transaction for such volumes.
* Removes the upfront marking of pending xattrs at the time of pre-op
and defer it to post-op. (This is an arbiter independent change and is made for all afr transactions.)
* After pre-op stage, check if we can proceed with the fop stage without
ending up in split-brain by examining the changelog xattrs.
* Unwinds the fop with failure if only one source was available at the
time of pre-op and the fop happened to fail on particular source brick.
* Skips data self-heal if arbiter brick is the only source available.
* Adds the arbiter-count option to the shd graph.
This patch is a part of the arbiter logic implementation for 3 way AFR
details of which can be found at http://review.gluster.org/#/c/9656/
Change-Id: I9603db9d04de5626eb2f4d8d959ef5b46113561d
BUG: 1199985
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10258
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit f9e62a4321eb6484cfc1fedde4e672f0621ad1e3
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Thu Mar 5 13:41:10 2015 +0530
mgmt/glusterd: Porting messages to new logging framework
Change-Id: I25f3536446798ea1cffd6b5dfbb3d2398766fcf3
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9808
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
commit 8d64b907f95411f36e9810130b98de94af508087
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Apr 27 01:20:02 2015 +0530
libglusterfs: Fix cluster_entrylk retry
Change-Id: I92ff46bae36d39a449d4bbaedc88a322992f65eb
BUG: 1215265
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10391
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 310bd22fb961f43ca8c23d88b14c47e67b21de3d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Mar 31 23:07:09 2015 +0530
cluster/ec: Fix dictionary compare function
If both dicts are NULL then equal. If one of the dicts is NULL but the other
has only ignorable keys then also they are equal. If both dicts are non-null
then check if for each non-ignorable key, values are same or not. value_ignore
function is used to skip comparing values for the keys which must be present in
both the dictionaries but the value could be different.
geo-rep's stime xattr doesn't need to be present in list xattr but when
getxattr comes on stime xattr even if there aren't enough responses with the
xattr we should still give out an answer which is maximum of the stimes
available.
Change-Id: I8de2ceaa2db785b797f302f585d88e73b154167d
BUG: 1207712
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10078
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 3da89164a4e0a0ac267e01bbfff0cda1edb989f3
Author: Ashish Pandey <aspandey@redhat.com>
Date: Thu Apr 9 17:27:46 2015 +0530
cluster/ec: Use fd instead of loc for get_size_version
Change-Id: Ia7d43cb3b222db34ecb0e35424f1766715ed8e6a
BUG: 1188242
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/10176
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4dc998d9515135446f6fdc9bb2baa1c1096a9d17
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon May 4 14:19:36 2015 +0530
snapshot/uss: fix regression failure in bug-1162498.t
.snaps seems to take some time, before it is available based
on the state of the system. Using EXPECT_WITHIN instead of TEST
to check the contents of .snaps, hence giving it some time to
come up.
Change-Id: Iac166500d5a09ba8bab00d994c27a9ad0a01b9c3
BUG: 1218120
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10518
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a8b5a71134d8fff3f8738901117cecda58452612
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon May 4 17:49:16 2015 -0400
tests: fix failures due to not unmounting $M2 (/mnt/glusterfs/2)
Our failure to unmount meant that both mkdir and rmdir would fail in
cleanup(). Because one of those mkdirs was the last thing cleanup()
executed, it would fail, so the test would fail, so the entire
regression run would fail. The fix has two parts.
(1) Unmount the offending directory.
(2) Make sure cleanup() returns success even if that last mkdir
failed.
That might keep us from consistently blowing up regression runs on the
very first tests (basic/afr/data-self-heal.t) that we execute.
Change-Id: I7a9761bd28761a5ee2face3db8112e9c3f6c5dc8
BUG: 1163543
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10536
Reviewed-by: Justin Clift <justin@gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 045ea827852d08be25effb9fa23eb1778bd04924
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Apr 29 08:05:21 2015 +0530
rpc: Included necessary stats in 'gfs3_cbk_cache_invalidation_req'
To avoid extra network fops, it will benifit clients if the server
can send the updated stat of the file/dir and of the parent directory
(including oldparent in case of RENAME fop) while sending
GF_CBK_CACHE_INVALIDATION upcall event.
This patch handles rpc protocol changes.
Change-Id: Ic096a61c4d24a8d75a8285be78deb237d7ef9484
BUG: 1200262
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10452
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b16bbf4e44ad8f5d974c21f74b2845e2d2098bb4
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Apr 22 15:48:52 2015 +0530
Upcall: Cleanup expired client entries
To cleanup expired client entries (with access_time > 2*CACHE_INVALIDATION_TIMEOUT),
have
* defined a global list to contain all the upcall_inode_ctx allocated
* Every time a upcall_inode_ctx is allocated, it is added to the global list
* during inode_forget, that upcall_inode_ctx is marked for destroy
* created a reaper thread which scans through that list
* cleans up expired client entries
* frees the inode_ctx with destroy_mode set.
Note: This reaper thread is initialized only when features.cache_invalidation option
is enabled.
Change-Id: Iea2a63eb31b8e08d5709e7e090cf26fd13d01265
BUG: 1200267
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10342
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 9ba3181d09b6d61f435e394e1f5535019cebd3c6
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Apr 22 22:34:41 2015 +0530
gfapi: Skip and delete the upcall entry if not found
We could run into situations where in gfapi received a upcall
notification for a file and the file may have got deleted by then.
Hence, incase of error while trying to create handle from gfid,
log it, delete the entry and return with CBK_NULL reason.
Change-Id: I191f10f44d6804be07734a6be63a3ca08f455f0e
BUG: 1213773
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10341
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 061867c3b7abad72d1f1798dbe0065451124ceb1
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Apr 14 14:42:46 2015 +0530
feature/changelog: Capture path for deletes
PROBLEM:
There is no way to get the path of deleted file if we
have gfid from changelog since the file is already deleted.
SOLUTION:
Do a recursive readlink on parent gfid in backend .glusterfs
path to get the complete path in I/O callpath in changelog
translator and capture it in callback.
The path captured is relative from the brick root. The field
separator used is '\0'.
e.g.,
......\0<pgfid>/bname\0<relative-path>\0<next-record>
ADDITIONAL REQUIRED CHANGES:
1. The changelog translator option called "changelog.capture-del-path"
is introduced to enable or disable the capturing of deleted entry
path.
e.g.,
gluster vol set <vol-name> changelog.capture-del-path on/off
If capture-del-path is disabled, '\0' is captured instead of
relative path.
e.g.,
......\0<pgfid>/bname\0\0\0<next-record>
2. The minor number in the version of changelog is bumped up from v1.1
to v1.2.
3. If recursive readlink is failed for some reason, it will capture
\0 in place of <relative path>.
e.g.,
......\0<pgfid>/bname\0\0\0<next-record>
(same as when caputre-del-path option is disabled)
4. If bname argument passed to "resolve_pargfid_to_path" function
is NULL and pargfid is ROOT, "." is returned. This is not the
case with changelog, where bname is always passed. This is
applicable to other consumers of "resolve_pargfid_to_path"
routine.
NOTE:
Changelog parser should consider the above new changes
and should parse accordingly.
Change-Id: I040ed429b5aa7d391033fc6a540edbf07fc37827
BUG: 1214561
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10288
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: NetBSD Build System
commit 926d43ce42975a2a20ba8bb317128c8dfdf067f5
Author: anand <anekkunt@redhat.com>
Date: Tue Apr 28 22:42:14 2015 +0530
glusterd: Enable readdir-ahead by default on new volumes
With gluster-3.7, 'performance.readdir-ahead' will be enabled by default on
new volumes when the cluster op-version supports it.
Change-Id: I44e76a69e7d1c11e6dfad72c941caf887bb810ee
BUG: 1216187
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/10433
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 89ee9013b3e3835780de6bb218b62f04efa471bb
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon May 4 17:01:18 2015 +0530
Upcall: Feature doc for Upcall infrastrucutre
Change-Id: I802ba2f13fde6c05da1ed355e340f071e9d20d30
BUG: 1200262
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10525
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a522ae3d1c2e49b8f17dd6c4543225581284d23d
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Apr 24 17:31:03 2015 +0530
rpc: Maintain separate xlator pointer in 'rpcsvc_state'
The structure 'rpcsvc_state', which maintains rpc server
state had no separate pointer to track the translator.
It was using the mydata pointer itself. So callers were
forced to send xlator pointer as mydata which is opaque
(void pointer) by function prototype.
'rpcsvc_register_init' is setting svc->mydata with xlator
pointer. 'rpcsvc_register_notify' is overwriting svc->mydata
with mydata pointer. And rpc interprets svc->mydata as
xlator pointer internally. If someone passes non xlator
structure pointer to rpcsvc_register_notify as libgfchangelog
currently does, it might corrupt mydata. So interpreting opaque
mydata as xlator pointer is incorrect as it is caller's choice
to send mydata as any type of data to 'rpcsvc_register_notify'.
Maintaining two different pointers in 'rpcsvc_state' for xlator
and mydata solves the issue.
Change-Id: I7874933fefc68f3fe01d44f92016a8e4e9768378
BUG: 1215161
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10366
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 900c3eca58f42836cc87b37cef7b4e09c0c17657
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Apr 28 19:17:40 2015 +0530
tiering/cli: Check replica count and bricks are proper or not
Right now, attach-tier calls parsing function for add-brick.
Add-brick does not have any check for brick count and replca
count compatibility.
Change-Id: I44ec13eadffc003a9ebf8c4eb0193df559933a68
BUG: 1215122
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10428
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2ec6baf674d509de7e9fe561edbd80997cdb96ab
Author: vmallika <vmallika@redhat.com>
Date: Wed Apr 15 17:35:07 2015 +0530
quota: support for inode quota in quota.conf
Currently when quota limit is set, corresponding gfid
is set in quota.conf. This patch supports storing
inode-quota limits in quota.conf and also stores
additional byte for each gfid to differentiate
between usage quota limit and inode quota limit.
Change-Id: I444d7399407594edd280e640681679a784d4c46a
BUG: 1202244
Signed-off-by: vmallika <vmallika@redhat.com>
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/10069
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f42823a624b30915b995b4fd683f3a3ce08895c0
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Apr 15 13:30:34 2015 +0530
glupy: package glupy as a subpackage under gluster namespace
Currently glupy files resides in gluster namespace of python site packages.
The other projects like libgfapi-python ..etc are evolving and need to share
the gluster namespace. The current structure makes things difficult as all
subpackages have its own __init__ files and other files.
One subpackage can not any more own gluster namespace.
The attempt is to make below structure for gluster namespace so that
it is more portable and scalable for future use.
<sitepackages>/gluster/
|
-- __init__.py
|
|
-- glupy
|
-- __init__.py
-- glupy.py
-- ........
|
|
-- gfapi
|
-- __init__.py
-- gfapi.py
-- ........
By above structure clients can import:
>>> from gluster import glupy
>>> from gluster import gfapi
libgfapi-python project has been moved to this structure via
http://review.gluster.org/#/c/9668/
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Change-Id: I54886200ddb6a4153a74d9e187aeca7cad79ef9e
BUG: 1211900
Reviewed-on: http://review.gluster.org/10248
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit e78e74fa7fef0b1c87fcb3d892331d62f384d08f
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Apr 28 18:09:29 2015 +0530
geo-rep: Fix ignoring geo-rep safe errors
Fix ignoring geo-rep safe errors in fuse layer
and also ignore logging in client translator
for mknod. Though it is rare, to happen with
mknod, it might happen with history crawl on
overlapping changelogs replay.
Change-Id: I7e145cd1dc53f04d444ad2e68e66e648be448e61
BUG: 1210562
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10422
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 6d6a9d3c98fab3535ded9dedeb8be03de86c7159
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Apr 28 14:40:27 2015 +0530
tools/glusterfind: New option to pre --regenerate-outfile
When pre command is run twice, it overwrites the outfile.
Now pre command will fail when executed twice. To force the
regeneration use --regenerate-outfile
Change-Id: I0cf7a139522812ece4decdfbcba667a05ce5c35e
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1207028
Reviewed-on: http://review.gluster.org/10418
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 3811b75eb7cdf28ded7ad7152d1e9106ac760895
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Thu Apr 9 15:36:20 2015 +0530
glusterd: gluster volume status should show status of bitrot and scrubber daemon
Command gluster volume status <VOLNAME> should show the status of bitrot
and scrubber daemon and its pid information.
Along with displaying bitrot and scrubber daemon information in gluster
volume status command there should be command to show its individual status
separately.
Command to show individual status of bitrot and scrubber daemon will
following.
command to show only bitd daemon information will be
gluster volume status <VOLNAME> bitd
command to show only scrubber daemon information
gluster volume status <VOLNAME> scrub
Change-Id: Id86aae1156c8c599347c98e2a538f294d37376e4
BUG: 1209752
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10175
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit e654ffc2c513f0785c989c711d1309f15ef60e94
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 1 11:01:15 2015 +0530
tests: Check aux umount is unmounted for quota tests
Change-Id: If57d08f3446755ea41f66ca258efcc8ea5a89063
BUG: 1217701
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10480
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e6a6f3b10c7dd3ddcb5399c1cafb8f76081e06e3
Author: Susant Palai <spalai@redhat.com>
Date: Thu Apr 30 13:25:39 2015 +0530
dht: Add a null check before freeing dir_dfmeta and tmp_container
Change-Id: Ifbba6f340adfe2b4e3ad07260fbf4a25698ad8df
BUG: 1217949
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/10459
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 096cf911730d7c6f80f2766329cdca12046bf49b
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Apr 27 15:00:36 2015 +0200
tier: relax libgfdb required version number
When calling dlopen() for libgfdb, do not specify the library version
number "libgfdb.so.0.0.1", since libtool will not always create libraries
or link with that name with the full 3-digit version. For instance on
NetBSD only up to the 2-digit version is available and "libgfdb.so.0.0.1"
does not exist.
Instead, just specify "libgfdb.so" and rely on smymlinks installed by
libtool to find the relevant library.
BUG: 1129939
Change-Id: I074b1009d3622a122fdaeb4b99658bca3277e211
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10407
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 27d4d965fa6a0b72a9f20161f9d1901087a3c1db
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Thu Apr 23 18:44:30 2015 +0530
features/bitrot: Per volume bitrot translator
Currently whatever bitrot/scrubber tunable value user set for one
volume that value is considering for all other volumes also.
Each volume should act on their respective bitrot/scrubber tunable
value.
For handling bitrot/scrubber tunable value independently with respect
to all the volume bitrot and scrubber translator should run seperatly
for each volume.
Change-Id: I1d9379508afe6cfd2f78e3ebf29c829c362d84a9
BUG: 1170075
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10352
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit dcf5652a9b137a2ee424794a2c6069065efa04c2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 1 20:12:50 2015 +0530
tests: Fix spurious failures
- Use REBALANCE_TIMEOUT in EXPECT_WITHIN
- Use fdatasync to prevent write-behind from giving success
- Add logfile to glupy
Change-Id: I51ab51644aaa4aa9d49f185e7b8959bb58be966b
BUG: 1217766
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10487
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bb2d2b51d57c3608137eda4bb3fd52ba622d3555
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Apr 28 18:51:38 2015 +0530
features/shard: Add "is-directory" checks in stat/fstat
During mount, NFS directly calls stat on the root of the volume
without sending a lookup on it. This was causing inode_ctx_get_block_size()
to fail on /. A check is now added in [f]stat which would ensure no action
is taken by shard xlator when the operation is on a directory.
Change-Id: I81849eeddfdad9f271155442408d95b4a25d7647
BUG: 1207615
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10427
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1024e43a8bd4f770ac6403c5e7a05ced3e9ded94
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun May 3 15:07:56 2015 +0200
rpm: fix dependency on python-gluster
The glusterfs-extra-xlators tries to install python-glusterfs. This is
incorrect, the package is called python-gluster.
BUG: 1211848
Change-Id: Id48a63ebe893c2bab90fab37ea3e32e601fae0fa
Reported-by: Meni Yakove <myakove@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10508
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fc27f6807e29af1ac7328c572b2080a8c8f57844
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Apr 30 11:34:14 2015 +0530
Upcall: Handle missing fops in the upcall xlator
Change-Id: I968980dc4df458ec427e33503363bbd017e1163e
BUG: 1200271
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10194
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 017f4df6a156a009999fe7487ce9134f4da468d8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 1 21:51:09 2015 +0530
tests: Disable flush behind so that file will be closed
Change-Id: I97eb8d236448e8783f09b4922aa465a2b1b3979b
BUG: 1217788
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10488
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 0832949c366c5e5e82bdf763586a2a2ac5266060
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Apr 13 20:28:21 2015 +0530
features/changelog: Consider only changelog on/off as changelog breakage
Earlier, both chagelog on/off and brick restart were considered
to be changelog breakage and treated as changelog not being
continuous. As a result, new HTIME.TSTAMP file was created on
both the above cases. Now the change is made such that only
on changelog enable/disable, the changelog is considered to be
discontinuous. New HTIME.TSTAMP file is not created on brick
restart, the changelogs files are appended to last HTIME.TSTAMP
file.
Treating changelog as continuous in above scenario is important
as changelog history API will fail otherwise. It can successfully
get changes between start and end timestamps only when changelog
is continuous (Changelogs in single HTIME.TSTAMP file are treated
as continuous). Without this change, changelog history API would
fail, and it would become necessary to fallback to other mechanisms
like xsync FSCrawl in case geo-rep to detect changes in this time
window. But Xsync FSCrawl would not be applicable to other
consumers like glusterfind.
Rationale:
1. In plain distributed volume, if brick goes down, no I/O can
happen onto the brick. Hence changelog is intact with data
on disk.
2. In distributed replicate volume, if brick goes down, since
self-heal traffic is captured in changelog. Eventually,
I/O happened whend brick down is captured in changelog.
Change-Id: I2eb66efe6ee9a9228fb1fcb38d6e7696b9559d5b
BUG: 1211327
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10222
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
commit c3ff20490b3f48bfb088806125799ee80a40ba57
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Apr 29 12:09:26 2015 +0530
features/shard: Take hole size into account while computing ia_size
Change-Id: I1a90ad6669c1cb79aaae6b4bd9621c75d9985c8a
BUG: 1207615
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10446
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d79e84831ae41caa3d9074aa406dda976e40b3f1
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Apr 24 17:07:37 2015 +0200
protocol: increase default group-cache-timeout to 300 seconds
sssd uses 300 seconds by default too. There is no need to overload sssd
with requests that it would have cached.
BUG: 1215187
Change-Id: I3f04ea8cc90180d863253a9f46d62b71810a7b34
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10371
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3297a300fc397a664a5bde000e5fceb6e8b7ebb8
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Apr 30 12:02:28 2015 +0530
geo-rep: Fix minor bugs in meta-volume setup
1. Access unreferenced access of fd:
In meta volume configuration for geo-rep, if
geo-rep directory is not created yet, open fails
with no fd, but it is accessed in close(fd). So
after creating 'geo-rep' directory in meta-volume,
open the lock file to get fd.
2. Fix volume_id in forming lock file name.
For the very first time, gconf.volume_id would
be null, as config is not reloaded yet. Hence, use
'uuid' function to get the volume id.
Change-Id: I8381ab7a44bc800df25d596218466641c10937a4
BUG: 1210344
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10458
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: NetBSD Build System
commit 74a417ef145c8f0bab5f6c619ceae3a24e389624
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu Apr 9 15:07:54 2015 +0530
ctr/libgfdb: Performance enhancer for unlink/create/rename/link fops
1) ctr_link_consistency option for ctr xaltor is provided so that
the user can choose to switch it on or off.
/* For link consistency we do a double update i.e mark the link
* during the wind and during the unwind we update/delete the link.
* This has a performance hit. We give a choice here whether we need
* link consistency to be spoton or not using link_consistency flag.
* This will have only one link update */
2) In delete the wind time recording is moved to unwind path.
/* Special performance case:
* Updating wind time in unwind for delete. This is done here
* as in the wind path we will not know whether its the last
* link or not. For a last link there is not use to update any
* wind or unwind time!*/
Change-Id: I209472fb816f939db4a868b97ba053b028f17ea6
BUG: 1217786
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10170
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 57bb689a110eecd7cd52650a757bbf2607ec4f53
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu Apr 30 16:54:16 2015 +0530
glusterd/quota/tiering: Fixing volgen of quotad
The quotad's graph generation was happening wrongly for
tiered volume. The check is been inserted.
Change-Id: I5554bc5280b0fbaec750e9008fdd930ad53a774f
BUG: 1214219
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10474
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 961104d33d771645bc58bef025c7bf4db9f81a9a
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu Apr 16 12:30:16 2015 +0530
dht/rebalancer: Marking tiering migration fops
This is a follow up patch for http://review.gluster.org/#/c/10080
In the above, the suggested change in
http://review.gluster.org/#/c/10080/7/xlators/cluster/dht/src/dht-rebalance.c
doesnot work. The reason it doesnt work is promotion and demotion are done in
a multithread way. Whenever a promotion or demotion thread is called, the frame
of the old sync_op thread is not carried with it. As a result the frame->root->pid
is not set.
Solution:
When the file is getting migrated, we get a tiering.migration key_value in the
xattr dict, so that we pass this dic key-value when we do syncop_setxattr()
to do data migration and set the frame->root->pid GF_CLIENT_PID_TIER_DEFRAG
in dht_setxattr() just before calling dht_start_rebalance_task().
Change-Id: I86fef2d961b32fdd2c0c69d8512cbe846b393404
BUG: 1194753
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10266
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 598ec811541b2795755045493fa6f8ccce7655eb
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Apr 28 11:53:33 2015 +0200
nfs: fix spurious failure in bug-1166862.t
In some environments, "showmount" could return an NFS-client that does
not start with "1". This would cause the test-case to fail. The check is
incorrect, the number of lines should get counted instead.
Also moving the test-case to the .../nfs/... subdirectory.
BUG: 1166862
Change-Id: Ic03aa8145ca57d78aea01564466e924b03bb302a
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10419
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e165c9cdee866b7749945b49fbe123061a407e58
Author: Nandaja Varma <nvarma@redhat.com>
Date: Tue Feb 3 13:17:04 2015 +0530
changelog: Fixing buffer overrun coverity issues.
Coverity IDs:
1214630
1214631
1214633
1234643
Change-Id: I172c4f49bf651b2324522f9e661023f73ca05339
BUG: 789278
Signed-off-by: Nandaja Varma <nvarma@redhat.com>
Reviewed-on: http://review.gluster.org/9557
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sakshi Bansal
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 8e650a96ccf3539c40b2195aa85c348b57893b47
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Apr 27 12:33:06 2015 +0530
cli/tiering : Parse detach-tier command properly
gluster detach-tier help should show the usage of
detach-tier command properly.
Also, instead of force option, if any other was given,
then the command should fail with a usage message
Change-Id: Ie801529176db067c98fd1bfada056cbc647973fb
BUG: 1211570
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10303
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 125e3ac06f3fcfe07432cc0e9af2d85e24ec4a33
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Apr 15 12:29:16 2015 +0530
build: Introducing python-gluster package
Currently the gluster namespace/module is owned by glusterfs-api rpm.
Because of this, other packages (extra-xlators or libgfapi-python)
have to depend on glusterfs-api to get the gluster namespace. The gluster
namespace should be owned by a core package.This patch introduce new package
called python-gluster and moves the ownership of gluster module
to python-gluster.
Change-Id: Ib75ab922736f3bea6355da4d8dbec3a08b2844d5
BUG: 1211848
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10244
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit a8d87e270bfe4c88d6cd015c10ff71ed241095a1
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Apr 14 04:03:36 2015 +0530
Upcall: Replaced opaque gfid with string in rpc cbk args
For GF_CBK_CACHE_INVALIDATION, have changed the type of gfid
to be string (cannonical form) instead of opaque byte format
to ensure correctness across platforms supporting different
endianness.
BUG: 1200262
Change-Id: Iac4372714f4b4ebcd9c4393aaf46ceba3f37f587
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10224
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d48ac0f41acfc71181f06ab21bc6f6ae1d08e327
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Mar 30 16:56:59 2015 +0530
Upcall: Process each of the upcall events separately
As suggested during the code-review of Bug1200262, have modified
GF_CBK_UPCALL to be exlusively GF_CBK_CACHE_INVALIDATION.
Thus, for any new upcall event, a new CBK procedure will be added.
Also made changes to store upcall data separately based on the
upcall event type received.
BUG: 1200262
Change-Id: I0f5e53d6f5ece16aecb514a0a426dca40fa1c755
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10049
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 08159ba30da3c37da5f56f3ceb604ab90e87d6db
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Fri Apr 17 10:56:57 2015 +0530
NFS-Ganesha: Handling CLI commands when NFS-Ganesha keys are set
When ganesha.enable is set to on and features.ganesha is
enabled, there are a few behaviour changes that should
be seen in other volume operations.
1. ganesha.enable can be set to 'on' only
when features.ganesha is set to 'enable'
2.When gluster vol is started, and if ganesha.enable
key was set to 'on', it should automatically export the volume
via NFS-Ganesha.
3.When ganesha.enable is set to 'on', and a volume
is stopped, that volume should be unexported via NFS-Ganesha.
4. gluster vol reset <volname>
If ganesha.enable was set to on, then unexport the
volume via NFS-Ganesha.
5. gluster vol reset all
If features.ganesha is set to enable, as part
of reset all, set it to disable. This translates
to teardown cluster.
All the above problems are fixed by checking the global key
and value, depending on the value, specific functions are called.
And also, functions related to global commands
are moved to cli-cmd-global.c
Commit phase of features.ganesha enable/disable
runs the ganesha-ha.sh setup/teardown respectively.
Before the script begins, it is important that the
NFS-Ganesha service starts on all the HA nodes.
Having the start service commands in the
commit phase could lead to problems.
Moving the pre-requisite service start
commands to the 'stage' phase.
Change-Id: I5a256f94f8e1310ddcd5369f329b7168b2a24c47
BUG: 1200265
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/10283
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 324b33fbf65a8dd3aaccb55da96633020e12dce5
Author: Venky Shankar <vshankar@redhat.com>
Date: Sun Apr 26 16:25:08 2015 +0530
features/bitrot: Use global timer wheel
Change-Id: I761927ea263b4144b851881f25791fda5b794f59
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10381
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c0e8d002b37b0dcae3211e16574fe309e4768570
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Tue Apr 14 00:48:24 2015 +0530
bitrot: Scrubber log should report 'bad' file detection as ALERT in log
If scrubber detect any bad object by mismatching of checksum of scrubber
and signer then log messages shold come as a Alert instead of warning.
Change-Id: I075d80700cbe6182e525a04419a80ab18419ff91
BUG: 1210687
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10226
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit b74855b40c3d804b34d454ea986baec8d356db78
Author: vmallika <vmallika@redhat.com>
Date: Tue Apr 28 12:52:56 2015 +0530
quota: Validate NULL inode from the entries received in readdirp_cbk
In quota readdirp_cbk, inode ctx filled for the all entries
received.
In marker readdirp_cbk, files/directories are inspected for
dirty
There is no guarantee that entry->inode is populated.
If entry->inode is NULL, this needs to be treated as readdir
Change-Id: Id2d17bb89e4770845ce1f13d73abc2b3c5826c06
BUG: 1215550
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/10416
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 4fac4c18d23c2ce3ae73e83aa496254f161c67fa
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed Apr 15 11:37:22 2015 +0530
glusterd: do not pass volinfo in glusterd_svc_manager function
On restarting of glusterd first it will start all the bricks present
in the volume then it will start all the services. During starting of
all the services it may pass volinfo as a NULL. It will cause Assert
failure in glusterd_bitdsvc_manager function and will cause a glusterd
crash.
Change-Id: Ia14cf5022da88516cdd576eb2d1e0e7b17a3782b
BUG: 1207029
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10241
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 2f595a6cc4513513886f8f04eb9f6d550d2222d4
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Sat Apr 11 17:05:45 2015 +0530
glusterd: volume info should not show "feature.scrub: resume" if scrub resumed
If bitrot is enable on the volume and if user paused the scrub process and then
resume the scrub process then command #gluster volume info <VOLNAME> should show
status of option features.scrub: Active.
If bitrot is enable on the volume and user disable the bitrot on the volume then
command #gluster volume info <VOLNAME> should show status of option
features.scrub: Inactive.
If bitrot is enable on the volume and user paused the scrub porcess then command
gluster volume info <VOLNAME> should show the status of option
features.scrub: pause.
Change-Id: I55972eef3b8570b7cb05dc28700d4e28dc45a86a
BUG: 1209818
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10207
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit f3a197f51dd7e65fa4bd444ab0a7b4a7cd4f23ae
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Apr 29 12:02:05 2015 +0530
snapshot/scheduler: Use shutil.move instead of os.rename()
os.rename is a wrapper on top of the rename function,
which fails with invalid cross-device link if /tmp
is a tmpfs. Hence using shutil.move
Change-Id: Ia026d2a810b725ccd398db895e612c53bc6a2f95
BUG: 1214574
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10347
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c612d3992954d8a472155b08c58ba33f967ce507
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Apr 28 18:42:41 2015 +0530
glusterd: Use uint32_t for peerinfo generation number
Using a uint64_t for the peerinfo generation number was overkill for how
the generation number is used within GlusterD. It also prevented
GlusterD from running on 32-bit architechtures, as uatomic_add_return
doesn't support 64-bit values on 32-bit architechtures.
This change was developed on the git branch at [1]. This commit is a
combination of the following commits on the development branch.
b78dba4 Use 32-bit generation number
2c37e4b Change other generation number variables to uint32_t
[1]: https://github.com/kshlm/glusterfs/tree/urcu
Change-Id: I0f310f56a4fb97d6bcbc23255a379ed5bb1ed9e1
BUG: 1205186
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/10425
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 67f26bbfc0fe5eced355188bdf797f6494038556
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Apr 29 21:03:39 2015 +0200
build: glfsheal should link against $(UUID_LIBS)
Without this, building fails on Debian Jessie:
/usr/bin/ld: glfs-heal.o: undefined reference to symbol 'uuid_clear@@UUID_1.0'
/lib/x86_64-linux-gnu/libuuid.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
Makefile:503: recipe for target 'glfsheal' failed
While at it, clean some of the unused defines too.
BUG: 1206587
Change-Id: I2e513b2a806e6241542e60007d720cca16dabb06
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10453
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 8ff265cc559344720b9f199f02011c8a9323e17a
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Mar 11 20:11:09 2015 +0530
protocol/server : port log messages to new framework.
Change-Id: I7901f55d06716161cc31d2b79a600a16b5ec2ef8
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9874
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 4b66b7405bede9b6c5c3bc08585fef55f3b0d999
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Apr 30 04:57:11 2015 +0200
Fix ENOKEY build failure on non Linux systems
ENOKEY is Linux specific, using it will fail the build on any other
system. Proposed fix is to use EINVAL instead.
BUG: 1129939
Change-Id: I7bdcb8dbc55aa50760c46c0d2ed932083b3066ed
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10456
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit c9e14181fe8bf430342426cb628de3b5ba70a5a0
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Apr 29 11:38:11 2015 +0530
rdma: porting rdma to a new message id logging format
Change-Id: I71e940817ae0a9378e82332d5a8569114fc13482
BUG: 1194640
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9868
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 4de75f6d10858dd9f22c4519acb7db2328a8c428
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Apr 14 08:17:10 2015 -0400
common-ha: delete-node implementation
omnibus patch consisting of:
+ completed implemenation of delete-node (BZ 1212823)
+ teardown leaves /var/lib/nfs symlink (BZ 1210712)
+ setup copy config, teardown clean /etc/cluster (BZ 1212823)
setup for copy config, teardown clean /etc/cluster:
1. on one (primary) node in the cluster, run:
`ssh-keygen -f /var/lib/glusterd/nfs/secret.pem`
Press Enter twice to avoid passphrase.
2. deploy the pubkey ~root/.ssh/authorized keys on _all_ nodes, run:
`ssh-copy-id -i /var/lib/glusterd/nfs/secret.pem.pub root@$node`
3. copy the keys to _all_ nodes in the cluster, run:
`scp /var/lib/glusterd/nfs/secret.* $node:/var/lib/glusterd/nfs/`
N.B. this allows setup, teardown, etc., to be run on any node
Change-Id: I9fcd3a57073ead24cd2d0ef0ee7a67c524f3d4b0
BUG: 1213933
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/10234
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bdfe2f1c8fcb210f9f9290ef46ae80a3e71f17be
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Apr 16 11:34:18 2015 +0530
features/shard: Implement rename() fop
Change-Id: Ia39fa0f29eac84c18d13a94f704b1703565b504e
BUG: 1207615
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10373
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8671b692186e5f5cee5eb77c2757c5560bed6c19
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sat Apr 18 18:40:55 2015 +0530
tests: Await for graph switch before testing open fop count
In performance/open-behind.t, a test for open fop reaching the brick is done by
switching off open-behind and performing a read operation. If the read operation
is performed before a graph switch, the read happens on the old graph and hence
open does not get accounted in the brick.
To overcome this EXPECT_WITHIN 10 seconds has now been added to ensure that a
graph switch has happened. The read operation happens subsequently after the
graph switch.
Cleaned up a "No volumes present" message from stderr while doing this.
Change-Id: I1e1c0d7e4bd2057520b4dd46157d18f30837b8c9
BUG: 1213066
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/10293
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Raghavendra Bhat <raghavendra@redhat.com>
commit bf6c8a49391eee6bae033c93d11c737ffcc9d3a9
Author: Susant Palai <spalai@redhat.com>
Date: Sun Apr 26 23:49:56 2015 +0530
dht: tackle thread race in dht_getxattr_cbk
problem:
1. When two threads execute in parallel in dht_getxattr_cbk
it may so happen that, both may find local->xattr to be NULL. As
a result dht_aggregate_xattr may not get executed.
2. In dht_getxattr_cbk,
thread1 thread2
T1 this_call_cnt = 2 -1
T2 this_call_cnt = 1 - 1
T3 fills local_xattr
T4 DHT_STACK_UNWIND -> local_wipe
T5 tries to dereference local
which is already freed,
leading to crash.
Solution:
for problem1: Execute critical section inside frame lock
to resolve race.
for problem2: Calculate this_call_count just before out section.
Change-Id: I9827ac8fafebb0c733a4e4f3c710b752f1cd45fa
BUG: 1215592
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/10389
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit d38a940287e3a92d1e3ee256fa15609b6870eb5e
Author: Susant Palai <spalai@redhat.com>
Date: Sun Apr 12 15:55:02 2015 +0530
rebalance: Introducing local crawl and parallel migration
The current patch address two part of the design proposed.
1. Rebalance multiple files in parallel
2. Crawl only bricks that belong to the current node
Brief design explanation for the above two points.
1. Rebalance multiple files in parallel:
-------------------------------------
The existing rebalance engine is single threaded. Hence, introduced
multiple threads which will be running parallel to the crawler. The
current rebalance migration is converted to a "Producer-Consumer"
frame work.
Where Producer is : Crawler
Consumer is : Migrating Threads
Crawler: Crawler is the main thread. The job of the crawler is now
limited to fix-layout of each directory and add the files which are
eligible for the migration to a global queue in a round robin manner
so that we will use all the disk resources efficiently. Hence, the
crawler will not be "blocked" by migration process.
Producer: Producer will monitor the global queue. If any file is
added to this queue, it will dqueue that entry and migrate the file.
Currently 20 migration threads are spawned at the beginning of the
rebalance process. Hence, multiple file migration happens in parallel.
2. Crawl only bricks that belong to the current node:
--------------------------------------------------
As rebalance process is spawned per node, it migrates only the files
that belongs to it's own node for the sake of load balancing. But it
also reads entries from the whole cluster, which is not necessary as
readdir hits other nodes.
New Design:
As part of the new design the rebalancer decides the subvols
that are local to the rebalancer node by checking the node-uuid of
root directory prior to the crawler starts. Hence, readdir won't hit
the whole cluster as it has already the context of local subvols and
also node-uuid request for each file can be avoided. This makes the
rebalance process "more scalable".
Change-Id: I73ed6ff807adea15086eabbb8d9883e88571ebc1
BUG: 1171954
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/9657
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit ad3e0c74a99c8ebdc047cdb9fc2b28e3e8a49866
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Thu Apr 16 17:50:04 2015 +0530
cli,doc: man page of gluster (man gluster) should show bitrot command information
Currently when user type incorrent bitrot specific command then every
time cli error suggest wrong command to reuse.
With this fix it cli will suggest specific bitrot command when user type
wrong bitrot command.
With this fix it will also display bitrot command information in man page
by typing 'man gluster'
Change-Id: I7dbf31332a8cc0723e54e8a37fea0afe19d95e0e
BUG: 1207532
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10273
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 91cd4bda932cef2fc61d917cd9f6ce14993fc47f
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Apr 7 12:49:37 2015 +0530
nfs/auth,exports,netgroup : port log messages to new framework
Five gf_log messages are not changed to gf_msg because gf_msg
not sending the output to STDOUT.
Bug id : BZ1215017
Change-Id: Ie8de286355becc3fd73fa80057734b834cf40b04
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/10173
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit 6a89362838be177e625d0e53a5c9e197f838033f
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Tue Apr 28 17:08:32 2015 +0530
libglusterfs: allocate a segment for quota logging
Change-Id: Ia71488a20147ec3e99548aea15b4a57bb325fd06
BUG: 1194640
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10420
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f630f757d0bdcf693aa428bda972f36cf4637e2f
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Apr 6 17:30:02 2015 +0530
nfs: Enable throttling for rpcsvc
Busy nfs servers need throttling to prevent duplicate requests
from casuing an increase in memory consumption.
Change-Id: I855bb1e841ba06b523e55f86f7788a0f7a49d444
BUG: 1212385
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/10269
Tested-by: NetBSD Build System
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 56635777e25ebc6a889f68bccf1f0e102f44f2e9
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Apr 6 12:55:13 2015 +0530
rpc: Perform throttling conditionally
This change makes rpc's throttling to be performed only if
attribute throttle is set in rpcsvc_t.
Change-Id: I24620095570e206f5dc8fc6208fcf55cb22a1658
BUG: 1212385
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/10268
Tested-by: NetBSD Build System
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit ba2dc724f0f64ff3d86f08aef39b9983b2c9db77
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Apr 6 12:34:55 2015 +0530
rpc: Introduce attribute throttle for rpcsvc_t
This attribute will be used to set/unset throttling for
a rpcsvc_t program subsequently.
Following APIs have been added to get/set throttle.
int
rpcsvc_set_throttle (rpcsvc_t svc, gf_boolean_t value);
gf_boolean_t
rpcsvc_get_throttle (rpcsvc_t svc);
Change-Id: Ica8a9166cef22eb92d81fe68e48d0a5e24a1ef95
BUG: 1212385
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/10267
Tested-by: NetBSD Build System
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 07b43734b2f074fe3647d28c564c5ddc552eb5bb
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Apr 13 16:26:56 2015 +0530
nfs / acl3.c, nlm files : port log messages to new framework
Porting log messages to a new framework for acl3.c, nlm4.c,
nlmcbk_svc.c
Change-Id: Iee4daae4fe1460eddf95d285615335b836d7f958
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/10217
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 94a930f132668026513bd4abb81c81b5f8709263
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Apr 13 15:50:12 2015 +0530
nfs / nfs files : porting log messages to new framework
Porting log messages to a new framework for nfs-common.c,
nfs-fops.c, nfs-fops.h, nfs-inodes.c, nfs3-fh.c, nfs3-helpers.c.
Change-Id: I55cd94de62eafe6ad3754cd065d7459a81a9f285
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/10214
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit d5234b1c6b866945db1a6f2e547a524719732aa7
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Apr 13 12:21:09 2015 +0530
nfs / mount files : porting log messages to a new framework
Porting log messages to a new framework for mount3udp_svc.c,
mount3.c, mount3-auth.c files.
Change-Id: I1e9cab500b6052bfac43c5ae1c82278e20d2f898
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/10210
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit b7272214531ec1d12a0c18b0c939c1810e27332c
Author: Aravinda VK <avishwan@redhat.com>
Date: Sat Apr 11 20:03:47 2015 +0530
geo-rep: Limit number of changelogs to process in batch
Changelog processing is done in batch, for example if 10 changelogs
available for processing then process all at once. Collect Entry, Meta
and Data operations separately, All the entry operations like CREATE,
MKDIR, MKNOD, LINK, UNLINK will be executed first then rsync will be
triggered for whole batch. Stime will get updated once the complete
batch is complete.
In case of large number of Changelogs in a batch, If geo-rep fails after
Entry operations, but before rsync then on restart, it again starts from the
beginning since stime is not updated. It has to process all the changelogs
again. While processing same changelogs again, all CREATE will get EEXIST
since all the files created in previous run. Big hit for performance.
With this patch, Geo-rep limits number of changelogs per batch based on
Changelog file size. So that when geo-rep fails it has to retry only last batch
changelogs since stime gets updated after each batch.
BUG: 1210965
Change-Id: I844448c4cdcce38a3a2e2cca7c9a50db8f5a9062
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10202
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 135cad4af85b976fe6c76dc3e778ad930e2258b9
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Sat Apr 25 12:44:15 2015 +0530
libgfapi : port gfapi to new logging framework
Change-Id: Iaa0a92f82b9a0a26eda1a8d72b3b66ce66fab443
BUG: 1194640
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9918
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 3f6d28ff9305d494be908ab6e82b59bf347af588
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Apr 27 00:00:08 2015 +0530
cluster/ec: Handle unhandled states
This was leading to hangs when get_size_and_version fails
Change-Id: Iad9408c2dacc9a74594b8d2f94c95f402533b0f1
BUG: 1215265
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10390
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 2e685e93579921fd492ebb7ed69f12131b81d2e2
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Mon Apr 27 12:48:07 2015 +0530
libglusterfs: update glfs-messages header for reserved segments
all the logging patches will be dependent on this segment allocation.
Sending this change as a seperate one to avoid the conflicts.
Change-Id: Iedd72ab6dc3526f1a6b01828807b5e6b9edcba90
BUG: 1194640
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10400
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0bb645081948ef219aa8bbd8f04977c4277ef5ac
Author: anand <anekkunt@redhat.com>
Date: Fri Apr 17 14:19:46 2015 +0530
libglusterfs: Implementation of sync lock as recursive lock to avoid crash.
Problem : In glusterd,we are using big lock which is implemented based on sync
task frame work for thread synchronization and rcu lock for data consistency.
sync task frame work swap the threads if there is no worker poll threads
available,due to this rcu lock and rcu unlock was happening in different threads
(urcu-bp will not allow this),resulting into glusterd crash.
fix : To avoid releasing the sync lock(big lock) in between rcu critical
section,implemented sync lock as recursive lock.
More details:
link : http://www.spinics.net/lists/gluster-devel/msg14632.html
Change-Id: I2b56c1caf3f0470f219b1adcaf62cce29cdc6b88
BUG: 1211640
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/10285
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 58f16c752832fae89aad7cb250037e1faf60fd7c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Apr 15 22:53:21 2015 +0530
arbiter: load arbiter xlator on every 3rd brick of a replica 3 AFR subvol
Logic for adding the 'glusterd_brickinfo->group' member and using it to
find the brick positon has been taken from http://review.gluster.org/#/c/9919.
Thanks to Jeff Darcy for that.
This patch is a part of the arbiter logic implementation for 3 way AFR
details of which can be found at http://review.gluster.org/#/c/9656/
Change-Id: Idbfe4f29ee8e098e0102def8f38b32314316b188
BUG: 1199985
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10257
Tested-by: NetBSD Build System
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 436f7954c9eb4ece8a0caa37c383509663a6e5b3
Author: Milind Changire <mchangir@redhat.com>
Date: Mon Mar 30 16:53:05 2015 +0530
geo-rep: log ENTRY failures from slave on master
ENTRY operations failures on slave left no trace for debugging purposes.
This patch captures such failures on slave cluster and forwards them to
the master and logs them. Failures of specific interest are the ones
which return code EEXIST on the failing operations.
Change-Id: Iecab876f16593c746d53f4b7ec2e0783367856bb
BUG: 1207115
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: http://review.gluster.org/10048
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 877412d1498c1879e31e477f4ebd1993de2eb808
Author: vmallika <vmallika@redhat.com>
Date: Thu Apr 16 08:10:01 2015 +0530
quota: display error when inode-quota cmds executed with cluster ver < 3.7
In a heterogeneous cluster with op_version less than 3.7, inode quotas will
be accounted on those bricks which has glusterfs version 3.7 and this is
not available in older version.
This will have incorrect values displayed when user queries inode count
from CLI.
This patch will display error when inode-quota commands
are executed with cluster version less than 3.7
Change-Id: Ia0e6d5635d1d8e7b2e2cfc3daa7b7f9e314a263a
BUG: 1212253
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/10261
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cdddc98d18e57955a7e3eb0dd0ab4d7508665e2d
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Apr 10 17:03:02 2015 +0530
geo-rep: Adhering to the common storage for geo-rep
Making geo-rep use the common storage shared by nfs,
snapshot and geo-rep. The meta volume should be named
as gluster_shared_storage, and it should be mounted
at "/var/run/gluster/shared_storage/".
geo-rep will have create a directory called 'geo-rep'
in the meta-volume and all the lock files are created
inside it.
Change-Id: I82d0bff9be191f75f643606a9a21d53559047ac4
BUG: 1210344
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10196
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 07d7465474d2987e866d50236eada35c944d5c2a
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Apr 27 22:32:59 2015 +0530
libglusterfs: Fix the return value of inode_ctx_get2()
Currently inode_ctx_get2 return success for value2 even if it is
not found. This patch fixes the same.
Change-Id: I6bf3e6cb280ab3b9b8818bf48dc6e42a349dfa5d
BUG: 12002268
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/10412
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 38980ab0ac8e027d6d1cabd615f45fe35be62e96
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Sun Apr 26 20:38:30 2015 -0400
build: configure: automake defaults to max filename length=99 chars
automake's default rule for making tar files invokes tar with options
to use Unix V7 tar file format, which has a maximum FQ pathname length
of 99 characters. Some of the new tests in .../tests/bugs/... have names
that are longer than 99 chars. These files are dropped from the dist
tarfile.
automake can be configured to use a newer (POSIX 2001) tar format that
does not have limits on the length of file names.
Change-Id: I2f3f239e410c66aa13b1257dc734691741b7c667
BUG: 1215486
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/10392
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Justin Clift <justin@gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit baedd6e9c89293a348ca5295cc916396850a0e6d
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Apr 27 06:32:40 2015 +0200
tier: fix off-by-one overrun in UUID string
UUID strings are UUID_CANONICAL_FORM_LEN (36) bytes long
plus the trailing nul character that various function (e.g.:
uuid_unparse) will add. As a consequence, UUID strings must
be declared as UUID_CANONICAL_FORM_LEN+1 long, otherwise
we get a off-by-one overrun that corrupts the next variable
on stack.
BUG: 1129939
Change-Id: I5837ad6ca06fa17cc7ab143eedd02d8099ecca2a
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10394
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0ada6afda3658d7ad92e2a47467500860bd2315f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Apr 26 17:59:49 2015 +0530
storage/posix: prevent NULL dereference
filler->fd is never set but used.
Change-Id: Icf21c439b37c9faa3751658a9e63a74570ed153c
BUG: 1215265
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10383
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 80d10c7354ce90b240153416f7ed4ebbc66b5e50
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Feb 4 23:08:31 2015 +0530
geo-rep: Re Enable ignore_deletes Option
If this option is set, Deletes will not be propogated to Slave.
This option is applicable for UNLINK and RMDIR.
gluster volume geo-replication <MASTER> <SLAVEHOST>::<SLAVEVOL> \
config ignore_deletes true
Default value is false.
PS: Use this option with caution, If you create the file in master
with same path then it fails to sync to slave. Old file in Slave
will have different GFID compared to New.
BUG: 1189363
Change-Id: I1f7816d1ea36460a654873739d3fb1b6c13e0f8d
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9583
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 167d324447ea6b25513501700876e93c8b7631dd
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Mar 17 12:18:30 2015 +0530
geo-rep: Do not fail-back to xsync if Changelog is failed
Unless change_detector is set to xsync, do not fallback to
xsync, except during Initial Sync or Partial History.
When a brick goes down, Changelog exception is raised due
to which geo-rep fallback to xsync. Even after brick comes
back geo-rep will not consume Changelog.
BUG: 1202649
Change-Id: I1f8ea26ac7735f6ee09b3b143ee3eb66bfc9fc37
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9758
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 1ca249463269d803adc4bf8b8890a3661e6008a7
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Wed Mar 4 17:07:53 2015 +0530
Snapshot: New logging framework implementation of snapshot messages.
Change-Id: I3e8b5f6ae59d16752beb8053c2afddfb5c00be14
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9796
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
commit c79c207477a432561054e3d63864c59af24ca477
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Wed Apr 22 15:57:44 2015 +0530
glusterd: New logging framework, all the message label
Change-Id: I5f83b070638384b3f2e3efe936f64080c3334eab
BUG: 1194640
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/10332
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit 4df5259ec96450f926c5b23b19f03cc252caf02c
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Fri Apr 10 15:54:27 2015 +0530
libglusterfs/syncop: Pass xdata even in error case
xdata should be passed even in error cases.
lookup() call was missed in previous patch set.
Change-Id: I1ad2c452d05a3b4433b640762aaea5d3a91f2ba5
BUG: 1209869
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/10193
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 133427e5bd307a603d40d5c8f86f5de0fb3b043e
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Apr 10 13:02:59 2015 +0530
glusterd: Remove direct references to peerinfo in frame cookies
RCU protection requires that we don't have direct references to
protected data structures outside read-critical sections
This change was developed on the git branch at [1]. This commit is a
combination of the following commits on the development branch.
82ebfdd Remove direct references to peerinfo in frame cookies
dec4bec Remove incorrect and unneeded code from
gd_syncop_mgmt_v3_unlock_cbk_fn
7aced7b Use stack allocated uuid for frame cookie.
38e4124 Address comments from 10192/2
[1]: https://github.com/kshlm/glusterfs/tree/urcu
Change-Id: Ic50e5fca0be72af5090f4cf318efa55d29075de9
BUG: 1205186
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/10192
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c14fdd6c4ccbd5efe1d2921bab33cfd6d6001abc
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Apr 26 10:40:18 2015 +0530
syncop: Implement syncop_fxattrop
Change-Id: Ifc7937ceb451f6e11e40a9513017226fd0f115b0
BUG: 1215265
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10382
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 77a5f4166e56049b804f6b993d4915dcb07b949f
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Apr 13 10:37:55 2015 +0530
glusterd: incorrect rsp.op_ret handling in volume get in cli
Change-Id: Iabe99c06166578fc90121e7cfdca4a6a3f5328ae
BUG: 1211132
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10229
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit d54e9efcbd6e237cf88dcf3111e00ab0d50c3770
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Apr 20 17:37:21 2015 +0530
glusterd: initialize snapd svc at volume restore path
In restore path snapd svc was not initialized because of which any glusterd
instance which went down and came back may have uninitialized snapd svc. The
reason I used 'may' is because depending on the nodes in the cluster. In a
single node cluster this wouldn't be a problem since glusterd_spawn_daemon takes
care of initializing it.
Change-Id: I2da1e419a0506d3b2742c1cf39a3b9416eb3c305
BUG: 1213295
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10304
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 45a7554701166fe12a270f2e61ffed3013565489
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Apr 16 17:45:04 2015 +0530
cli: fix vol_type in volume info xml
xml parsing of voltype should be inline with the cli
Change-Id: I41ddddac00d07f03b56a041e1c3f5a132fbd7393
BUG: 1212398
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10271
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit eafd5dcbb0d0e1f2455465cc6dc8f4c6e3a4800d
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri Apr 24 10:10:35 2015 +0530
core: Global timer-wheel
Instantiate a process wide global instance of the timer wheel
data structure. Spawning glusterfs* process with option arg
"--global-timer-wheel" instantiates a global instance of
timer-wheel under global context (->ctx).
Translators can make use of this process wide instance [via a
call to glusterfs_global_timer_wheel()] instead of maintaining
an instance of their own and possibly consuming more memory.
Linux kernel too has a single instance of timer wheel where
subsystems such as IO, networking, etc.. make use of.
Bitrot daemon would be early consumers of this: bitrot translator
instances for multiple volumes would track objects belonging to
their respective bricks in this global expiry tracking data
structure. This is also a first step to move GlusterFS timer
mechanism to use timer-wheel.
Change-Id: Ie882df607e07acaced846ea269ebf1ece306d6ae
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10380
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7528c1140b93c247bbe801d5b144ca5877e238e2
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri Apr 24 21:43:25 2015 +0530
bitrot/scrub: fix induced throttling in syncop_ftw_throttle()
Failing to reset scanning counter causes "incorrect" delay of around
50 seconds per directory entry. This causes scrubber to run extremely
slowly.
[
NOTE: This is a temporary fix. With the introduction of token
bucket based throttling, inducing throttle via sleep()
call would be unneeded.
]
Also, fix logging messages in scrubber to log brick and full path
of the object which is identified/marked as corrupted.
Change-Id: Id501bd15dcdbd8a09613f80f9d84050304740027
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10375
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
commit 3d3c3ad21bf364f49fe917697858faf74afd396f
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Apr 25 05:03:47 2015 +0200
Tests: fix spurious failures in trash.t
Fix timing problems that cause rare spurious failures in trash.t
BUG: 1129939
Change-Id: I673e033b53b6b4bb993c22fadbdcee725b2c1e96
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10360
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c7ce278202ece9f0bbd406d67c673fca3f81e5ea
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Dec 2 10:54:53 2014 +0100
nfs: make it possible to disable nfs.mount-rmtab
When there are many NFS-clients doing very often mount/unmount actions,
the updating of the 'rmtab' can become a bottleneck and cause delays. In
these situations, the output of 'showmount' may be less important than
the responsiveness of the (un)mounting.
By setting 'nfs.mount-rmtab' to the value "/-", the cache file is not
updated anymore, and the entries are only kept in memory.
BUG: 1169317
Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
Reported-by: Cyril Peponnet <cyril@peponnet.fr>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9223
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 734f137934bb317e208b7b307c93e7e5807077fe
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Apr 19 09:40:34 2015 +0200
tiering: skip CTR-xlator and config options when disabled
When compiling with --disable-tiering, GlusterD should not contain any
references to the ChangeTimeRecorder xlator or any of the data tiering
options.
BUG: 1213125
Change-Id: Idb46fb80f0ca8b66115e06841d9ec15ba14c24a0
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10296
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 47361dd0c0828c47f55a40fd31912758225459f3
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Apr 9 19:00:58 2015 +0530
geo-rep: Don't log geo-rep safe errors in mount logs
EEXIST and ENOENT are safe errors for geo-replication.
Since mkdir is captured in all the bricks of the changelog.
mkdir is tried multiple times as per the number of bricks.
The first one to process by gsyncd will succeed and all
others will get EEXIST. Hence EEXIST is a safe error
and can be ignored. Similarly ENOENT also in rm -rf case.
And also gsyncd validates these errors and log them in
master if it is genuine error. This is coming up with
the patch http://review.gluster.org/#/c/10048/
Hence ignoring above said safe errors.
Change-Id: I10ae86b11d49c7c3ba2be3110dace6b33daa509e
BUG: 1210562
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10184
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 03de9bde8d8eb353c5580013ecb5452f7adc6154
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Tue Apr 7 18:43:30 2015 +0530
libglusterfs: avoid crash due to ctx being NULL
Change-Id: Ib667ed42f0b598baddb829b448d6efc3d8e044f1
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10155
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b58f112fe6547bda4afa120b7794098311604fce
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Tue Apr 7 11:27:19 2015 +0530
cli: Error out when there is not enough memory
Change-Id: Ia8d061de5be1343cc10a945f6cf011686a770d33
BUG: 1211594
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10144
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 288951b5876b435b3a40e9a4493471e8397da8e5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Apr 14 13:45:33 2015 +0530
libglusterfs: Implement cluster-syncop
This patch implements syncop equivalent for cluster of xlators. The xlators on
which the fop needs to be performed is taken in input arguments to the
functions and the responses are gathered and provided as the output.
This idea is taken from afr-v2 self-heal implementation by Avati.
Change-Id: I2b568f4340cf921a65054b8ab0df7edc4478b5ca
BUG: 1213358
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10240
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 15d974483a1e24c24ee56ba7e63586d28f47843e
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Apr 13 15:32:58 2015 +0530
features/shard: Implement unlink fop
Change-Id: I5cdd805821a4f3657f490223b97f42c724ee588f
BUG: 1207615
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10249
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 85dc0ac0c370889cd755cd804aa5481d983c6c32
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Apr 23 08:30:11 2015 +0530
cluster/ec: Perform inode-write on healing subvols
If the version numbers do not match, then writes are performed only on at least
N-R bricks which have same version. But if we want to do healing of files which
are constantly modified we need to allow writes on subvols that are undergoing
heal. Data healing will mark 62nd bit while the heal is going on. When the data
transaction sees that this bit is set it needs to perform the fop on that
subvol irrespective of whether the versions match or do not match. Fop is
considered successful only if N-R non-healing bricks succeed.
Change-Id: I69a17582df397aaf6e8ca4b5e746c7ca802cbbde
BUG: 1215265
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10372
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit de73cc5275db82f87c2d8bd93bd62022fb4c9388
Author: Günther Deschner <gd@samba.org>
Date: Mon Apr 20 13:16:59 2015 +0200
xlators/cluster/dht: Fix Resource leak (CID 1291751)
Coverity CID 1291751.
Guenther
Change-Id: Ibe9dc3662811dc5889f85fa063ab9211fcaf7f12
BUG: 789278
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-on: http://review.gluster.org/10301
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 80ea6584cde934c1a19bba9d49d9534f1d6fff19
Author: Anoop C S <achiraya@redhat.com>
Date: Fri Apr 24 17:32:18 2015 +0530
gfapi: Reduce the log-level from ERROR to TRACE
Change-Id: I0b87f8ccc755a32ac64547c5f5973ea5c468018f
BUG: 1202274
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/10364
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
commit 585fce89c120cb24240cc336e8cb01425c11ff8c
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Apr 24 19:10:11 2015 +0530
tests : Skip geo-rep regression for now
As geo-rep regression is causing cores,
it is being disabled for now and will be
re-enabled once the issues are fixed.
Change-Id: Ie846b599369acb4a8fd814d1e889cffb4610a2c8
BUG: 1163543
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10369
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 0c1b1fbb5a455246182f20b35925e4ed5aa1c0ef
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Apr 24 16:24:52 2015 +0530
timer: Fix use after free issue
Change-Id: I056c9777b242a11af7f576ad19b2db93dbdf82d4
BUG: 1215117
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10367
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bc7325fc0f914c96ca4d1961ea6834c54a5a50d1
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Mar 25 15:04:19 2015 +0530
features/trash : Notify CTR translator if an unlink happens to a file
This implementation is same as the posix_unlink_cbk() where CTR sends
a request during a unlink to send the number of links to the inode
and posix obliges sending it using the unwind xdata dict.
For Trash xlator a unlink is stat + mkdir(if parent is not present)
+ rename. And hence this is handled in trash_unlink_rename_cbk().
Change-Id: I402e83567b88e3c9fe171379693c82937af567f9
BUG: 1205545
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/9989
Tested-by: NetBSD Build System
Tested-by: Joseph Fernandes
Reviewed-by: Joseph Fernandes
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e635cb1f37ab0053af73ef42a2120de779119e82
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Apr 16 17:46:49 2015 +0530
build: correct the version in glusterfs-api.pc
The version in glusterfs-api.pc has moved backwards, breaking existing
versioned dependencies in QEMU. The following table contains the
GlusterFS version and the version for glusterfs-api.pc:
.------------------------.
| GlusterFS | pkg-config |
|-----------+------------|
| 3.4.x | 4.3.4.x |
| 3.5.x | 6.3.5.x |
| 3.6.x | 7.3.6.x |
| 3.7.x | 7.3.7.x |
| master | 7.x.y.z |
'------------------------'
BUG: 1211836
Change-Id: I62168a0ab4f0c78e61987371ae75a0d2dd56ced8
URL: http://thread.gmane.org/gmane.comp.emulators.qemu/330176
Reported-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10308
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c38919e16a7d6116a49655109a03587ebe4657ef
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed Apr 15 12:32:11 2015 +0530
cli: validate brick while creating replicate volume
When user create replicate volume by typing incomplete command
"gluster volume create <VOLNAME> replica replica_count" then cli
is crashing.
Fix is to validate command properly. If user have not given any brick
then it should return proper cli command usage error message.
Change-Id: I3d4096a144e20f21ab956049af1dae196217a807
BUG: 1211576
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10245
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit 69a2016b41ebe2200098eb2d261dfc1042f8c9a7
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Apr 23 23:14:45 2015 +0530
tests: Add tests/basic/ec/ec-12-4.t to bad_test()
Lot of recent regression runs have been affected by this.
Change-Id: I16dceae5c18c73ddca60e90f8c0fe782ef59d7f3
BUG: 1163543
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/10357
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: NetBSD Build System
commit 147b9d90ce3b2e617f8d44d43b35b9808143a9e9
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Apr 23 10:18:49 2015 +0530
geo-rep: Changes required as part of changelog version 1.2
The index value for UNLINK and RMDIR in changelog
is no more the last index. It varies based on whether
the 'changelog.capture-del-path' is enabled or not.
Hence, fixed index is used.
The option to capture deleted path in changelog comes
with the patch: http://review.gluster.org/#/c/10288/
And the parser changes with http://review.gluster.org/#/c/10166/
Change-Id: Idc1a2e2bf90c888be4524d3ce74865aea09485de
BUG: 1214561
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10344
Tested-by: NetBSD Build System
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit a3b2df285ec2851f05dd8988f796be3feebd6af4
Author: Anoop C S <achiraya@redhat.com>
Date: Wed Apr 15 13:01:51 2015 +0530
features/trash: Minor coverity fixes
CID 1288784
CID 1288785
CID 1288795
CID 1288796
CID 1288797
CID 1288802
Change-Id: I51dd7653a2dce3b7b6387e5d91c1c07eb157a04b
BUG: 789278
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/10315
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Tested-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
commit eb2e0da287c3a303893775e5969833dfc62fbf0d
Author: arao <arao@redhat.com>
Date: Tue Feb 17 15:14:53 2015 +0530
dht: Fixing dereference after null check
CID: 1175023
The check for null is made before dereferencing
the pointer variable alongside.
Change-Id: I827927f2fcf6d1f365f4d6b5a678373020b9daf9
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9663
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit db142f9a81caed72003132eca256fd7ea5c1075f
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Apr 8 17:39:56 2015 +0530
tools/glusterfind: Do not fail to list if Session is invalid
If session is invalid, Show the session time as "Session Corrupted"
BUG: 1209843
Change-Id: I10f7fb79f6a3a2cabab3f21bce86f2a2f424e8b6
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10164
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: NetBSD Build System
commit 09691c2261c5c7003e03f8a8c00a0872d37cca2a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Apr 20 23:23:55 2015 +0530
cluster/afr,dht: Fix memleak after syncop_readlink
Change-Id: Ia71c14c2c2709c541075748c9011437e0d8cac4b
BUG: 1213542
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10305
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit ab3fc1a282bf12839e937f04a09913229fefc6e9
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Apr 23 06:32:38 2015 +0200
Tests: trash.t portability fixes
Fix various portability problems in trash.t
- work around timing issues
- avoid wildcard usage only supported by bash
Original patch from Anoop C S and Jiffin Tony Thottan.
Removed LONGER_HEAL_TIMEOUT from previous patch as it
seems to run fine without it now.
BUG: 1129939
Change-Id: I0f6f484209ef4db7e0a7b733b863927cb248e73e
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10327
Reviewed-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 48de0dbe4706bb5f39e8a2443f25451294a9b495
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Apr 13 15:23:51 2015 +0530
features/trash : fixing trash dir option
Previously, problem was caused due to buffer overflow of variable used
in the code. This patch fix the same.
Change-Id: I3df5e06044470022f9475d93d33447db35384da2
BUG: 1132465
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/10215
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9965d3cbc58c5bb773aec23f461ef2ecf4fb2206
Author: Dan Lambright <dlambrig@redhat.com>
Date: Mon Apr 13 02:42:12 2015 +0100
glusterd: support for tier volumes 'detach start' and 'detach commit'
These commands work in a manner analagous to rebalancing when removing a
brick. The existing migration daemon detects "detach start" and switches
to moving data off the hot tier. While in this state all lookups are
directed to the cold tier.
gluster v detach-tier <vol> start
gluster v detach-tier <vol> commit
The status and stop cli commands shall be submitted separately.
Change-Id: I24fda5cc3ba74f5fb8aa9a3234ad51f18b80a8a0
BUG: 1205540
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Signed-off-by: root <root@localhost.localdomain>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10108
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: NetBSD Build System
commit fb5b899e8166eea3cdec71a09cfea0eccb39d00a
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Apr 15 22:58:59 2015 -0400
tests: ignore results from some spuriously-failing tests
These tests were selected based on a survey of the last 50 apparently
spurious regression failures involving only one test, as of April 21, 2015.
They were responsible for the following number of failures out of those 50.
volume-snapshot.t: 24
uss.t: 8
glupy.t: 5
In other words, they were responsible for 74% of those failures. Until
they're fixed (or we find some generic problem to which they're particularly
vulnerable for some reason), ignoring their results should significantly
improve our regression-test success rate.
Change-Id: Ia0c2600df387f0bccc9dce819582fc883bdb5b89
BUG: 1163543
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10322
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 042c154051c555c71e7f37d751d9c2913ca7914f
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Apr 21 11:48:15 2015 -0400
core: avoid crashes in gf_msg dup-detection code
Use global_xlator for allocations so that we don't try to free objects
belonging to an already-deleted translator (which will crash).
Change-Id: Ie72a546e7770cf5cb8a8370e22448c8d09e3ab37
BUG: 1212660
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10319
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ceec3b89dfde99b9a0865330645399565e109968
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Mar 27 16:03:20 2015 +0530
features/shard: Consume size and block count in metadata read ops
Metadata read fops like lookup, stat etc will now fetch the xattr that
holds the size and block count information, extract the size and block
count fields and set them in respective stbuf before unwinding the
resultant iatt to the parent xlator.
Change-Id: I881be8955092fa6b75f8b0e4f3deb01344cb638e
BUG: 1207603
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10098
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 66b53e18a023bcf1374e7ce08b1f1e4ea2b17bcb
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Apr 16 19:28:21 2015 +0200
Fix case mistake for MKDIR_P in Makefiles
Some makefiles used $(mkdir_p) instead of the corectly defined $(MKDIR_P).
The former is substituted as an empty string, leading to possible failures
depending of the user shell tolerance. NetBSD's /bin/sh seems to choke
more easily than Linux's /bin/bash, but if the later does not fail, it
does not created the intended directories anyway.
BUG: 1129939
Change-Id: I8caed4000f3c91cb3a685453848fb854793945ed
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10276
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit ef13556bedd6d97b63e852449dbb0c56bf22c3b3
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Apr 14 04:35:09 2015 +0530
gfapi: Modified CACHE_INVALIDATE flags
Have prefixed CACHE_INVALIDATE flags exposed via gfapi with 'GFAPI_'.
In addition as INODE_UPDATE is asynchronous and may need some
support in NFS-Ganesha, have taken it out for now. Will revisit it
later.
Change-Id: Icbbc2c92a61c9225b6c5bc8c4212e8c4a3a0a10f
BUG: 1200262
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10225
Tested-by: NetBSD Build System
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 71043fc4d5ba912123a1f6b3f346b7d919efdab8
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Apr 14 13:08:34 2015 +0530
gfapi: Fix in glfs_h_create_from_handle
While constructing glfs_object from the handle given, incase
if inode is found in the inode table, we need not do "syncop_lookup"
unless we need to return the inode attributes.
BUG: 1200262
Change-Id: I4682d9e4420a0bcb1b3e807b801ccb3d8de3d2cd
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10232
Tested-by: NetBSD Build System
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 3b6b0580bbbcb73171649c13fe9a019a9219cf9d
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Apr 17 18:06:17 2015 +0200
Correctly return error for run-tests.sh -r
In recent modification introducing the -r option for run-tests.sh,
there was a missing bit: When -r is used, the regression result is
not returned and the outcome is always considered as a success.
Fix it by correctly reporting the status.
Change-Id: If4e3c96d51037fbcf6d9d0e10a3dd3e12da77447
BUG: 1129939
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10289
Tested-by: NetBSD Build System
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0b566d1b24e84ca3b3d85c0b2300a0010223b3f4
Author: Günther Deschner <gd@samba.org>
Date: Wed Apr 15 12:10:34 2015 +0200
xlators/storage/posix: Fix Dereference before null check (CID 1293501).
Coverity CID 1293501.
Everywhere in this call "name" is explicitly checked for NULL derreference just
not here in this path.
Guenther
Change-Id: Ie3e7b704702cb979a036052238ed65eda1531407
BUG: 789278
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-on: http://review.gluster.org/10252
Tested-by: NetBSD Build System
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fcddb03caff888b4c0a5645d95e2beb709d5ea7e
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Apr 17 15:15:50 2015 +0200
Tests: python portability
Make sure to use $PYTHON defined from tests/env.rc so that we get the
path to the actually detected python interpreter.
BUG: 1129939
Change-Id: Ibf3e88f190d5e0c6a4a08e8d5ef9d0b5cba5078a
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10286
Tested-by: NetBSD Build System
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 510446a32546a6475b19f8028ffcf9dda5beff25
Author: Michael Adam <obnox@samba.org>
Date: Wed Apr 15 09:15:23 2015 +0200
gfapi: fix potential non-0-terminated string (CID 1134002)
Use correct target buffer length for strncpy and make
sure that the target string is 0 terminated.
Fixes Coverity ID 1134002.
Change-Id: I97a74a94a818eb08a711e547f2ac6ae46087f065
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10247
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit b91e6779a237b8d764baba300280fad08c69ffd8
Author: Michael Adam <obnox@samba.org>
Date: Wed Apr 15 08:34:13 2015 +0200
upcall: fix use-after free (CID 1288760, 1288761)
Coverity IDs:
1288760 - Read from pointer after free
1288761 - Use after free.
Change-Id: Ide9405b9c30a3e27941054a4ae61f585ef09cd8c
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10242
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 01ee8cc305a94bdc6aa3dd6f37ec9a27d3159e07
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Apr 16 12:11:24 2015 +0530
geo-rep/cli : Fix geo-rep cli crash
Fixes crash when "gluster vol geo-rep <master-vol> status"
is run because of incorrect argc and index comparison.
Change-Id: Id14d63d020ad9c5951b54ef50e7c140e58d9d7a6
BUG: 1212063
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10264
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: NetBSD Build System
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b9afb1bac729949adf0a235e499ff0422d6a6731
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Apr 15 22:58:59 2015 -0400
tests: report run_all status correctly on failure
Change-Id: I469c78db4c9be8f81729a6f835355f8806f65e64
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10259
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d5487c593285a92293008749de99a4f704f6ead0
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Apr 13 05:47:09 2015 +0000
quick-read: Do a null check before unref
Commit 4ea5b8d2046b9e0bc7f24cdf1b2e72ab8b462c9e seems to have removed the check
as a part of static analyis fixes but I'm seeing errors in the client log.
--------------------
touch /mnt/fuse_mnt/zero-byte-file
echo 3 > /proc/sys/vm/drop_caches
cat /mnt/fuse_mnt/zero-byte-file
mount log:
[2015-04-13 05:52:21.683256] E [iobuf.c:790:iobuf_unref] (-->
/usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x232)[0x7feda12c0e24] (-->
/usr/local/lib/libglusterfs.so.0(iobuf_unref+0x56)[0x7feda1304c8e] (-->
/usr/local/lib/glusterfs/3.7dev/xlator/performance/quick-read.so(qr_readv_cached+0x466)[0x7fed95b7e2fc]
(-->
/usr/local/lib/glusterfs/3.7dev/xlator/performance/quick-read.so(qr_readv+0x70)[0x7fed95b7e385]
(-->
/usr/local/lib/libglusterfs.so.0(default_readv_resume+0x270)[0x7feda12d4401]
))))) 0-iobuf: invalid argument: iobuf
--------------------
Hence re-adding the checks.
Note: I'm using the same BZ Id used for the original commit though it is in
MODIFIED state just for correlation.
Change-Id: I79749814a9d4082933e3b306ce449492ee5b43a5
BUG: 1109180
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/10206
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ed359a89c0668340cfc50cbe2479335311df00ec
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Wed Feb 25 11:43:14 2015 +0530
glusterd/snapshot: Fix memory leak while using scandir
scandir allocates memory for dirent entries.
Ensure to free them up once they are used.
Noticed this while looking for a sample scandir implementation.
Change-Id: Iff5f76e93e698d3f454f273d9dd7d9a15cf63953
BUG: 1196027
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/9739
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 84d926313c8457f2208b0a213096c5af9e4a8b6b
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Apr 6 06:21:05 2015 +0200
Auto-retry failed tests to workaround spurious failures
Add a -r flag to run-tests.sh that will cause failed tests to be
retried once. The idea is to reduce the impact of spurious failures:
no need to retrigger in jenkins, and no need to replay all the tests.
Change-Id: I176bb32678835a669992fbac7de4dd14ee5c62bc
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10128
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 01df773c774e26c37b20153056ad43accbd847fe
Author: vmallika <vmallika@redhat.com>
Date: Wed Apr 15 05:50:01 2015 +0530
quota/marker: fix inode quota healing after glusterfs upgrade
There is a problem during upgrade where, inode quotas are not healed in
the contri xattrs.
Healing happens if contri xattrs are missing.
But healing doesn't happen if contri xattrs are present and inode quota
values are missing in the contri xattrs.
This patch fixes the problem
Change-Id: I6c88b74b5bb333a97c5419e24cc4ada82839f474
BUG: 1211808
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/10239
Tested-by: NetBSD Build System
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit dfce2f3b9e575e46e09269e6f241f78e68d1e55e
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Apr 7 15:32:18 2015 -0400
tests: early bail-out on bad status or new core file(s)
This started as a way to identify which test created new core files,
since that's a critical piece of debugging information that's missing
when we only check for cores at the end of a run. It also exits
*immediately* either on bad status or discovery of a new core file.
This allows the run to be retried or aborted quickly, to reduce the
latency of all jobs in the regression-test pipeline.
Change-Id: Ib4a1c779b44f041ab8728f772874f6c23de95929
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10157
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 74f759d6ef738ce2035dca5acfa2a5c1543e009c
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Apr 10 20:12:57 2015 +0530
geo-rep: Added GF_CPPFLAGS to Makefile.am
This change is required to include contrib files in glusterfs.h
Change-Id: I40ef2c495015a6861fdd9f6a72599f094a89eb2a
BUG: 1200262
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/10200
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit b3f1ccbea11222cdb03abf62d1d348fe48a58b05
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Apr 13 16:46:57 2015 -0400
doc: correct omission of author credit for Translator 101
Change-Id: I4d3cb518c9c45c99a2011d538d4ca24f6b676d76
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Change-Id: I4d3cb518c9c45c99a2011d538d4ca24f6b676d76
Reviewed-on: http://review.gluster.org/10223
Tested-by: NetBSD Build System
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 7e732a6d76b1b774f27c79262b52744e5b505232
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Mon Apr 13 14:08:53 2015 +0530
NFS-Ganesha : Use common meta-volume for shared storage
A fixed name and mount point is used to share the common volume
required by various components. Make appropriate changes on the
NFS-Ganesha to accomodate the commom meta-volume as the
shared storage.
Change-Id: I9c87e486c2bb3a414f9773c74ed46e111f3c9c14
BUG: 1210344
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/10211
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
commit 4b23c7bb64890f180cc6ce8beb8aa0937902f7a6
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Apr 10 15:17:05 2015 +0530
glusterd: Store ping-timeout in glusterd conf in memory
As of now glusterd_conf_t's ping-timeout was of no use and hence statedump was
not reflecting correct ping-timeout value configured in glusterd.vol
Change-Id: I76ba7b721264565751538c7fcdcb801a28317581
BUG: 1210627
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10191
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit a65b8580b596ceb759e7a43e802771196eb0b101
Author: vmallika <vmallika@redhat.com>
Date: Wed Apr 1 20:03:37 2015 +0530
quota/disperse: handle inode quotas in xattr aggregate
with the inode quota feature, quota size is now
increased from 64bit to 192bits which contains
values of 'file size', 'file count' and 'dir count'
This change in quota size xattr needs to be handled
in disperse xattr aggregation
Signed-off-by: vmallika <vmallika@redhat.com>
Change-Id: I5fd28aa9f5b8b6cba83a98360236417a97ac16ee
BUG: 1207967
Reviewed-on: http://review.gluster.org/10112
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 2233d9c931269177d7ead91b4541101880c96fe7
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Apr 7 11:39:29 2015 +0530
admin/doc : Object count for quota
Change-Id: I271cca911f6dd1f481634063919a587843d93e50
BUG: 1190108
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/10171
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 404f745bcc30ec7c9fd9337e80e1753576c18c2d
Author: Justin Clift <justin@gluster.org>
Date: Sun Apr 12 16:23:55 2015 +0100
Fix incorrect rfc.sh and checkpatch.pl use of "jenkins" instead of "gerrit"
Change-Id: I6e78477554097a2be5aad8e3fb196970fb30dac2
Signed-off-by: Justin Clift <justin@gluster.org>
Reviewed-on: http://review.gluster.org/10203
Tested-by: NetBSD Build System
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 61a54424a210e64b260c6b673d144a5d34da3580
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 30 13:50:11 2015 +0530
cluster/ec: Entry self-heal fixes
- Directory deletion should always happen with 'rm -rf' flag, otherwise the
call may fail with ENOTEMPTY.
- Instead of doing an explicit 'link' call, perform mknod call with
GLUSTERFS_INTERNAL_FOP_KEY which acts as 'link' if the
gfid already exists.
Change-Id: I8826f92170421db37efb67dfc00afad4ab695907
BUG: 1207085
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10045
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 6ec1ff4ef3aee37d10ae1dd564afcff0484f87cb
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Apr 7 13:56:16 2015 +0530
doc : pNFS support for gluster volumes
Change-Id: I910f8f786849b4ece3d3c258c2c52537edc173dd
BUG: 1209380
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/10145
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit fe357b735946c161d5f4f4aa68186c7cb66807b6
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Fri Apr 10 19:14:42 2015 +0530
NFS-Ganesha : Fixing HA script invocation and others
gluster features.ganesha disable failed invariably.
And also, there were problems in unexporting
volumes dynamically.Fixed the above problems.
Change-Id: I29aa289dc8dc7b39fe0fd9d3098a02097ca8ca0c
BUG: 1207629
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/10199
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: NetBSD Build System
commit 246635bcdddb6fd837cc04fc67cca792166d90e4
Author: Vijaykumar Koppad <vkoppad@redhat.com>
Date: Fri Jun 13 17:52:30 2014 +0530
Geo-rep: Adding regression tests for geo-rep
This patch introduces upstream regression suit for geo-replication
* Modifies cleanup (tests/include.rc) to remove everything but
hook-scripts.
Prerequisites:
* Passwordless SSH from root to root of current host.
* Export /build/install/sbin and /build/install/bin to PATH
variable for root user.
Change-Id: I433dd8bbb17edba9baaf516fe0dce3133ba39184
BUG: 1101111
Signed-off-by: Vijaykumar Koppad <vkoppad@redhat.com>
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7392
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 36adc716791b62588402d199793b1b4f8e6d9fbd
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Apr 7 15:05:09 2015 +0530
tools/glusterfind: Prevent ssh public key overwrite issue
Same ssh key was used for all the sessions, when multiple
sessions created in Cluster, public keys get overwritten by
newest sessions. Moved ssh keys to respective session dir.
BUG: 1206547
Change-Id: I3d8fac9b24bc7c71445c7b4deae83104693e7dab
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10150
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 87fa31844e223e86a57b31e176b43f76b0852370
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed Apr 8 00:27:54 2015 +0530
glusterd: Restarting glusterd should not reset bitrot tunable value to default
Previously when user restart glusterd then bitrot tunable value for option
"scrub-throttle", "scrub-frequency", "scrub" cleared. glusterd was not storing
these bitrot tunable value properly.
With this fix it will store scrub-throttle, scrub-frequency, scrub, bitrot
tunable value in /var/lib/glusterd/vols/<volname>/info file and it will resume
these value when glusterd restart.
Change-Id: I58e756e14fbb8513a6f878f808ea148e7aa33cb0
BUG: 1209751
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10159
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit aecc2d170abc6a91f38768ae3cbfc2fc6f39e04a
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Fri Apr 10 14:16:36 2015 +0530
bitrot/glusterd: Scrubber should not crawl bricks if bitrot is not enable
If user create multiple volume and user enable bitrot only for few
volume then scrubber should not crawl bricks of volume on which bitrot
is not enable.
Fix is while volfile generation check whether bitrot is enable on that
particular volume or not. If bitrot is enable then only it add bricks of
that volume in scrubber volfile.
Change-Id: I53687c8e1acb39f8e4a712028b73f0b7006122b9
BUG: 1207547
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10190
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit f3e4289f3954354ea1e3fec5b801b4338d17c9e7
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Fri Apr 10 16:15:53 2015 +0530
doc: add translator development urls in developer guide
Change-Id: If74550dfea9121c69a86b13d52a02ce11f3bdc31
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10195
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit cb2ffaf3e761624c89f937b84624e0be9a85907f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Apr 8 14:48:32 2015 +0530
storage/posix: Introduce xattr-fill on fds
... with some of the code borrowed from http://review.gluster.org/#/c/3904/
Change-Id: I4901ef14d6f843d8d69f102d43d21b60ba298092
BUG: 1207603
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10180
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 06881e67472bdadd88665991388946f55735ca59
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Mar 26 15:18:54 2015 +0530
glusterd: Replace transaction peers lists
Transaction peer lists were used in GlusterD to peers belonging to a
transaction. This was needed to prevent newly added peers performing
partial transactions, which could be incorrect.
This was accomplished by creating a seperate transaction peers list at
the beginning of every transaction. A transaction peers list referenced
the peerinfo data structures of the peers which were present at the
beginning of the transaction. RCU protection of peerinfos referenced by
the transaction peers list is a hard problem and difficult to do
correctly.
To have proper RCU protection of peerinfos, the transaction peers lists
have been replaced by an alternative method to identify peers that
belong to a transaction. The alternative method is to the global peers
list along with generation numbers to identify peers that should belong
to a transaction.
This change introduces a global peer list generation number, and a
generation number for each peerinfo object. Whenever a peerinfo object
is created, the global generation number is bumped, and the peerinfos
generation number is set to the bumped global generation.
With the above changes, the algorithm to identify peers belonging to a
transaction with RCU protection is as follows,
- At the beginning of a transaction, the current global generation
number is saved
- To identify if a peers belonging to the transaction,
- Start a RCU read critical section
- For each peer in the global peers list,
- If the peers generation number is not greater than the saved
generation number, continue with the action on the peer
- End the RCU read critical section
The above algorithm guarantees that,
- The peer list is not modified when a transaction is iterating through
it
- The transaction actions are only done on peers that were present when
the transaction started
But, as a transaction could iterate over the peers list multiple times,
the algorithm cannot guarantee that same set of peers will be selected
every time. A peer could get deleted between two iterations of the list
within a transaction. This problem existed with transaction peers list
as well, but unlike before now it will not lead to invalid memory access
and potential crashes. This problem will be addressed seprately.
This change was developed on the git branch at [1]. This commit is a
combination of the following commits on the development branch.
52ded5b Add timespec_cmp
44aedd8 Add create timestamp to peerinfo
7bcbea5 Fix some silly mistakes
13e3241 Add start time to opinfo
17a6727 Use timestamp comparisions to identify xaction peers instead
of a xaction peer list
3be05b6 Correct check for peerinfo age
70d5b58 Use read-critical sections for peer list iteration
ba4dbca Use peerinfo timestamp checks in op-sm instead of xaction peer
list
d63f811 Add more peer status checks when iterating peers list in
glusterd-syncop
1998a2a Timestamp based peer list traversal of mgmtv3 xactions
f3c1a42 Remove transaction peer lists
b8b08ee Remove unused labels
32e5f5b Remove 'npeers' usage
a075fb7 Remove 'npeers' from mgmt-v3 framework
12c9df2 Use generation number instead of timestamps.
9723021 Remove timespec_cmp
80ae2c6 Remove timespec.h include
a9479b0 Address review comments on 10147/4
[1]: https://github.com/kshlm/glusterfs/tree/urcu
Change-Id: I9be1033525c0a89276f5b5d83dc2eb061918b97f
BUG: 1205186
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/10147
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 39fb1335370f2b1c7b79f944627754479fe308f6
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Apr 9 18:44:23 2015 +0530
nfs: do not overwrite the return value and errno of resolve operation
* In auth status check which is done in the resume function, the op_ret and
op_errno values saved in nfs3_call_state are overwritten by the return value
of the auth status check function.
Change-Id: Id4682ddd399c78a1cef6313a534892ef309c57a6
BUG: 1210338
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/10179
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 3caecf3df00783e44f123e1e032687361f9f2cdd
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Mar 10 15:13:29 2015 +0530
configure.ac: print yes/no instead of 1/0 in output
POSIX_ACLS support in output of configure shows
0/1 instead of no/yes.
Added BUILD_POSIX_ACLS to make value consistent.
Change-Id: Ife728d0d03ff0eb03d4389fefc04507a76205ccd
BUG: 1185654
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/9848
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: NetBSD Build System
commit 77b903bcb2eab72d54e8707c4d58ffc79e5866f3
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Apr 8 10:49:07 2015 +0200
crypt xlator: Fix memory coruption after free
crypt xlator allocated local memory through mem_get0(), but code called
through STACK_DESTROY()/FRAME_DESTROY() does not expect memory to be
allocated that way: it will use GF_FREE() even for data allocated by
mem_get0(), which should be given the mem_put() treatment. As a result,
allocating using mem_get0(), while relying on FRAME_DESTROY() cleanup
led to memory corruption.
Using GF_CALLOC() instead of mem_get0() sets memory allocation on par
with cleanup code, and crypt.t can pass on NetBSD.
The initial patch was crafted by Raghavendra Talur.
BUG: 1129939
Change-Id: Ib71b4b57f8d1bb782f950e3c8fa74a4f7e10946e
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10109
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 368e8d9c712d016410c3cc9dd92bedd34a1597ae
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Apr 10 10:51:02 2015 +0200
Tests: fix spurrious failure in mount-nfs-auth.t
Work around a timing-caused spurious error introduced by
http://review.gluster.org/10047
BUG: 1129939
Change-Id: I0597377799f2464d9516fe710fa6e39c1f67a858
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/10182
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b8eb926307fcc6459e62b3895a640292dedb8a50
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 8 21:42:49 2015 +0530
cluster/ec: Fix readdir de-itransform
Problem:
gf_deitransform returns the glbal client-id in the complete graph. So except
for the first disperse subvolume under dht, all the other disperse subvolumes
will return a client-id greater than ec->nodes, so readdir will always error
out in those subvolumes.
Fix:
Get the client subvolume whose client-id matches the client-id returned by
gf_deitransform of offset.
Change-Id: I26aa17504352d48d7ff14b390b62f49d7ab2d699
BUG: 1209113
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10165
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 62c6a1bf75d525d34dec283f752cab420fac6b14
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Apr 7 15:02:30 2015 +0530
features/bit-rot: Mark versioning fsetxattr as internal fop
Changelog xlator was capturing bitrot-stub's fsetxattr sent
for versioning. Since it was using the same frame as of the
create fop, there was inconsistency in fop number and gfid
of capturing metadata. So fix is to mark fsetxattr used for
versioning as internal and add internal fop filter in
changelog_fsetxattr.
Change-Id: I51ff468995139838b22bf293a59a0713a92ee7a5
BUG: 1170075
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10148
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit dfe8b4b0d9f6d958f8795d9adefb4fb90a44414b
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Apr 3 18:14:13 2015 +0200
build: make contrib/uuid dependency optional
On Linux systems we should use the libuuid from the distribution and not
bundle and statically link the contrib/uuid/ bits.
libglusterfs/src/compat-uuid.h has been introduced and should become an
abstraction layer for different UUID APIs. Non-Linux operating systems
should implement their compatibility layer there.
Once all operating systems have an implementation in compat-uuid.h, we
can remove contrib/uuid/ from the repository completely.
Change-Id: I345e5357644be2521685e00358bb8c83c4ea0577
BUG: 1206587
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10129
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 092b71561ea17302f184f431aedd659670b7aa6f
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Fri Feb 6 11:44:22 2015 +0530
rpc-lib: Fixing the coverity issues
Coverity CIDs:
1210973
1124887
1124888
1124682
1124849
1124503
Change-Id: I012f6cf9d14753f572ab94aae6d442d1ef8df79a
BUG: 789278
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9600
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 44f63cd46fdece9614108ed71703ae2df162989d
Author: arao <arao@redhat.com>
Date: Wed Feb 11 18:58:08 2015 +0530
io-stats: Fixing dereference after null check.
CID: 1124492
If 'this' pointer fails to exist then the component is hard-coded
in the gf_log if not it is dereferenced.
Change-Id: I988137d4f5ac4c9aedef7cef0c75b167a8a5c59f
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9639
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ae44a8fa365a46ce2be07006b5d0f2c216841bf9
Author: vmallika <vmallika@redhat.com>
Date: Wed Apr 1 16:56:00 2015 +0530
quota/cli: validate quota hard-limit option
Quota hard-limit is supported only upto: 9223372036854775807 (int 64)
In CLI, it is allowed to set the value upto 16384PB (unsigned int 64),
this is not a valid value as the xattrop for quota accounting and
the quota enforcer operates on a signed int64 limit value.
This patches fixes the problem in CLI and allows user to set
the hard-limit value only from range 0 - 9223372036854775807
Change-Id: Ifce6e509e1832ef21d3278bacfa5bd71040c8cba
BUG: 1206432
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/10022
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0090bc5638c609fe348c6c86e73db3c346136207
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Mar 31 18:09:25 2015 +0530
cluster/ec: Ignore volume-mark key for comparing dicts
Change-Id: Id60107e9fb96588d24fa2f3be85c764b7f08e3d1
BUG: 1207712
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10077
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 4df0badb11ed8ea46c4cce53a5694a22c410adad
Author: shravantc <shravantc@ymail.com>
Date: Wed Apr 1 18:31:58 2015 +0530
doc: update on admin geo replication
updated the geo replication session status
added configurable options available for geo replication
updated mountbroker for slaves, added simplified steps for
auxiliary gluster mount setup for the agent.
Change-Id: Ie8dac5ddb945ee93bcb8bc7694d35b0c6c01c606
BUG: 1206539
Signed-off-by: shravantc <shravantc@ymail.com>
Reviewed-on: http://review.gluster.org/10103
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit d8fe162d4fd0b79ff59d86c6ac60e178727812ec
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Fri Mar 6 13:26:30 2015 +0530
cluster/ec: Fix iobuf mem leak
iobuf_get and iobref_add implicitly
ref the iobuf.
Hence, it is necessary to unref iobuf
before setting it to NULL.
Change-Id: Icadd8925574cf04fe708d8090868e49356653a8e
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/9818
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1c33bcac5a9a3b8bf099d058b71a0005f1c4aabc
Author: GauravKumarGarg <ggarg@redhat.com>
Date: Tue Mar 31 16:41:08 2015 +0530
glusterd: bitd daemon should not start on the node which dont have any brick
If user enable bitrot from node1 which have brick then glusterd starting
bitd daemon on node1 as well as glusterd starting bitd deamon on another node2
which does not have any brick (node1 and node2 are part of cluster).
With this fix glusterd will not start bitd daemon on the node which
don't have brick.
Change-Id: Ic1c68d204221d369d89d628487cdd5957964792e
BUG: 1207029
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10071
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 46cba35107144a0e0c3b3ad29ddb9a5be16e6319
Author: Nandaja Varma <nvarma@redhat.com>
Date: Wed Feb 4 16:59:55 2015 +0530
gluster-cli : Removing logically dead code
Coverity CID: 1124451
Change-Id: I7b2901fdd2ace4666f9e2c6deaf3838322a1c6ff
BUG: 789278
Signed-off-by: Nandaja Varma <nvarma@redhat.com>
Reviewed-on: http://review.gluster.org/9579
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f68d640e2be342aace84e5bad994c8662371a40d
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Mar 26 15:45:55 2015 +0530
doc/geo-rep: Mountbroker User Management
BUG: 1136312
Change-Id: I1c8374de6e7ec93e401ec1c224752bfa5538adee
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10007
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit db1cc77c3d97c1d8b3b342cbd08e4295f5ee4c60
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Mar 23 14:25:49 2015 +0530
snapshot:Fetching wrong peer data during probe
When adding a new friend to the cluster, the snap volfile
are populating with wrong information for reconfigured option.
For snap volumes, reconfigured data's are filling from the
regular volumes data. This is because wrong dictionary key is
used here.
Change-Id: I659ebdc48c33419a2b825f26ce1f174abc8ea7dd
BUG: 1204636
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9969
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 2e16fe43f755a31a7379dcd79175491b977d891f
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Apr 9 19:39:12 2015 +0530
snapshot/scheduler: Adhering to the common storage for scheduler
Making snapshot scheduler use the common storage
shared by nfs, snapshot and geo-rep. The meta volume
should be named as gluster_shared_storage, and it
should be mounted at "/var/run/gluster/shared_storage/".
Each component(nfs, snapshot, and geo-rep) should have
their own repos inside the shared storage, and perform
their operations in the shared storage
Change-Id: I4f670bf089c80037bd2b0716ddf743f48d7411ca
BUG: 1210344
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10183
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 94d3086b572117669d28d02ed1fed9c9f2f09dc9
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Mar 16 13:12:12 2015 +0530
glusterd/snapshot : While snapshot restore, compute quota checksum.
Problem : During snapshot restore we anyways copy the quota conf file
after that we need to compute the checksum for that. If not, there
might be a checksum mismatch during glusterd handshake.
Solution : Compute a checksum file for quota conf file if its
present.
Change-Id: Ic4a6567c6ede9923443abf4ca59380679be88094
BUG: 1202436
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/9901
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 81d9faf84638f893c2e38f384259553889e74568
Author: Joseph Fernandes <josferna@redhat.com>
Date: Fri Jul 4 11:45:03 2014 +0530
glusterd/snapshot: Fix CLI msg for snap limit set
Change of message from "will lead to deletion of snaps"
to "Will limit creation of new snaps" when setting the
snapshot limits.
Change-Id: I4732555bb35d3ad30c2cef6ea6c7da42a8edf35d
BUG: 1116263
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/8236
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit caef395840559ce205b1293f5cdb48eb9f58e915
Author: Nandaja Varma <nvarma@redhat.com>
Date: Wed Feb 4 17:19:40 2015 +0530
gluster-cli : Extra checks for word_count removed.
Coverity IDs:
1124453
1124454
In the first case, In the beginning of the function check is made
to see of the word_count is less than 4. If yes it returns. So it
wouldn't reach this part if that check takes the true path. So
this code is logically dead.
In second and third case, this is in false branch for word_cound <6.
So word_count can't possibly be less than 5 at this point.
Change-Id: Id5e1c81045ce7bc0ee6b7612ea54ef2b7f54b699
BUG: 789278
Signed-off-by: Nandaja Varma <nvarma@redhat.com>
Reviewed-on: http://review.gluster.org/9582
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fc3718a975792930bd679431cd3c1ddf71cbc4fa
Author: arao <arao@redhat.com>
Date: Thu Feb 12 12:49:33 2015 +0530
features/quota: Fixing Logically dead code
CID: 1134007
The code never reaches the condition check on retlen in
ret label, hence removing the dead code.
Change-Id: Ia0108b69489bb78a2561ff8da6e00685f472ae82
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9644
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit db043e1c61202d083ad1ac39646ff965b6b9dd28
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Apr 9 14:58:25 2015 +0530
snapshot/scheduler: Validate the number of entries in schedule
A valid schedule entry in snapshot schedule must have
six elements and adhere to the following format
* * * * *
| | | | |
| | | | +---- Day of the Week (range: 1-7, 1 standing for Monday)
| | | +------ Month of the Year (range: 1-12)
| | +-------- Day of the Month (range: 1-31)
| +---------- Hour (range: 0-23)
+------------ Minute (range: 0-59)
Change-Id: Idf03a3c43a461295dd3e2026bbcd0420319dd0e0
BUG: 1209408
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10169
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit d49adf050869e95f25a2de6411a930ec184fa2f4
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Apr 9 14:24:43 2015 +0530
snapshot/scheduler: Fix deleting of snapshot schedule
Check if the argument has an attribute before
validating the attribute.
Change-Id: Ia4c6c91c2fca2ec3e82b47d81fbc19a5e0f17eb4
BUG: 1210204
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10168
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 27872154f936691a5f05c42c8240012fbe2174fc
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Apr 6 14:34:45 2015 +0530
snapshot/scheduler: Only run if shared storage is mounted
Before running any snapshot scheduler op command,
verify if /var/run/gluster/snaps/shared_storage/ exists
and if the shared storage is mounted at it.
Change-Id: Ibb6ba6c01c227cacf9a19d1bf9264500373a4ed6
BUG: 1209112
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10135
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 701277c4de7069ad5333c169716c2d202e65db28
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 1 09:06:53 2015 +0530
doc: Fix command parameters in geo-rep doc
Change-Id: Ie408e702999fb40d10f049e5238c64d70cde203e
BUG: 1207939
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10081
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 4c6b185714c9484a3c73af8a8e2c3697666f4bfe
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Feb 9 17:10:49 2015 +0530
rpc: fix deadlock when unref is inside conn->lock
In ping-timer implementation, the timer event takes a ref on the rpc
object. This ref needs to be removed after every timeout event.
ping-timer mechanism could be holding the last ref. For e.g, when a peer
is detached and its rpc object was unref'd. In this case, ping-timer
mechanism would try to acquire conn->mutex to perform the 'last' unref
while being inside the critical section already. This will result in a
deadlock.
Change-Id: I74f80dd08c9348bd320a1c6d12fc8cd544fa4aea
BUG: 1206134
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9613
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ae4f9fa5042b319d1d9c86738e5835bba7678e1e
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Sun Feb 15 19:22:13 2015 +0530
glusterd: remove-brick status/stop should not show output for non-existing brick
Previously when user start remove-brick operation on a volume then by
giving non-existing brick for remove-brick status/stop command it was
showing remove-brick status/stoping remove-brick operation on a volume.
With this fix it will validate bricks which user have given for
remove-brick status/stop command and if bricks are part of volume then
it will show statistics of remove-brick operation otherwise it will show
error "Incorrect brick <brick_name> for <volume_name>".
Change-Id: I151284ef78c25f52d1b39cdbd71ebfb9eb4b8471
BUG: 1121584
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/9681
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 9789e1a44adf4d23dba35059b3f783227fc9aaef
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Mar 25 15:11:48 2015 +0530
Snapshot: Remove brick details on snapshot create error
Since we are not providing complete details of stopped
bricks on snapshot create error, it is better to remove
the incomplete brick details.
BUG: 1205596
Change-Id: I73386059c0d29a6cbe7f2bb6834d8b8fb393db0a
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9999
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5eb7b0466f1e9f5f03a739fe28175cad4b13e5a7
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Apr 2 23:06:18 2015 +0530
glusterd: Better GlusterD handshake request validation
To allow handshake requests to be validated correctly in a multi network
environment, the request validation process has been improved.
The handshake request initiator will add it's peer ID the request.
The handshake request reciever will allow a request (as before) if,
- it has no peers, or
- the request came from a known peer
Identifying the known peer is done as follows.
- If the request contains a peer ID, it is matched against the IDs in
the peer list. If a match is found, the request is allowed.
- The address of the incoming request is matched against the peer
addresses in the peer list. If a match is found, the request is
allowed.
- Otherwise, the request if disallowed
Change-Id: I9eabe2935d16276bb147dfeebf8c8beb08e01411
BUG: 1207611
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/10122
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit df5ef21b5922d33ec02a84d60d28f9328f9cf630
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Mon Apr 6 18:52:50 2015 +0530
doc: cleanup parent doc directory
Change-Id: I65fee850c30e437abef695d2804af74617cc45fe
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10106
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 4c0371b76b5248eebfb9baa575986d0ca4b3b470
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Nov 26 12:35:23 2014 +0530
cli: Allow options prefixed with '--' for geo-rep config cmds
Geo-replications allows users to send rsync_options from
cli but while parsing, options prefixed with '--' are
treated as unrecognized apart from a few options. Because
of this rsync_options can't be set through cli. This
patch allows such options if it's a geo-rep config command.
e.g.
gluster vol geo-rep master fedora1::slave config rsync-options \
"--bwlimit=1.5m"
Change-Id: I4b4f10c0efd3f3a362ece65e697d5ce1498f84ac
BUG: 1168108
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9198
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 59c8890afc7a2b957efc0e28808f980428aa3787
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Jun 30 07:20:46 2014 +0000
glusterd/geo-rep: Check if the state file is present or not.
Currently every geo-rep operation other than start and stop
force, checks if the state-file is present or not before
performing the operation. This check is done to confirm that
the session on which the op is being performed is created.
This patch makes the start command also perform the same check
and accordingly display the correct error.
Change-Id: Ifd8bdfa3f362e91f58ead3202e2ebdbd411080e5
BUG: 1114469
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/8202
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 9109dc48d680ca7f7477c543d5484807c768bf07
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Mar 31 14:34:22 2015 -0400
socket: use OpenSSL multi-threading interfaces
OpenSSL isn't thread-safe unless you register these locking and thread
ID functions. Most often the crashes would occur around
X509_verify_cert, even though it's insane that the certificate parsing
functions wouldn't be thread-safe. The bug for this was filed over
two years ago, but it didn't seem like a high priority because the bug
didn't bite anyone until it caused a spurious regression-test failure.
Ironically, that was on a test for a *different* spurious
regression-test failure, which I guess is just deserts[1] for leaving
this on the to-do list so long.
[1] Yes, it really is "deserts" in that phrase - not as in very dry
places, but from late Latin "deservire" meaning to serve well or
zealously. Aren't commit messages educational?
Change-Id: I2a6c0e9b361abf54efa10ffbbbe071404f82b0d9
BUG: 906763
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10075
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3fde88988cdcf81b4c1b7a19e52b5e077605fed4
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Mar 30 16:03:24 2015 +0530
tests : modifcation in mount-auth-nfs.t
In the previous test script, for every change in export/netgroup file
the volume is restarted to accodomate those changes. New changes will
avoid those restarts.
Change-Id: I2a6052075637f8e833096c6b3fcc01139dea85e4
BUG: 1143880
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/10047
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7c07e0a17dd075bc064f51a40f190e5290a1f7a4
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Apr 7 16:47:15 2015 +0530
tools/glusterfind: Check existence of Session
Use glusterfind list command to check a session is valid or not
glusterfind list --session <SESSION> --volume <VOLUME>
Session exists if return code($?) is zero else invalid session
Change-Id: I37faa09e4e1bf2f10725dd8e5b0cc36a36a3cad4
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1205057
Reviewed-on: http://review.gluster.org/10154
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 67df7adf7cf68ef2426125d47088ccea8f7b61a6
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Apr 8 17:17:13 2015 -0400
tests: remove tests for clear-locks
These are suspected of causing core dumps during regression tests,
leading to spurious failures. Per email conversation, since this
isn't a supported feature anyway, the tests are being removed to
facilitate testing of features we do support.
Change-Id: I7fd5c76d26dd6c3ffa91f89fc10469ae3a63afdf
BUG: 1195415
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10167
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3a0ed9380f936d596c5071f0d6993daba918f449
Author: arao <arao@redhat.com>
Date: Wed Apr 1 12:29:24 2015 +0530
cli: Fixing dereference after null check and dead code removal
CID: 1124609
CID: 1124596
CID: 1124471
CID: 1124475
CID: 1124476
The pointer variables are checked before
dereferencing and the dead code is removed
BUG: 789278
Change-Id: Ia532733a64401d71ccf1f2b6e434d7bc910e0ed1
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/10083
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6a76b778a629598af18b21580c0931ca0306848a
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Apr 8 14:43:47 2015 +0530
features/bitrot-stub: Packed format for version xattr
Using __attribute__ ((__packed__)) for object signature xattr
saves some bytes (7 bytes to be particular) occupied by the
extended attribute on-disk as compared to the unpacked format.
Change-Id: I91a6a0a54aa60e6fd8c357d72f7601b6ed213f2d
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10161
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 338b55460a5cabbc640f0d0cba767f44ef1f1d0d
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Mon Apr 6 15:23:55 2015 +0530
cli: gluster volume help should give sufficient information for bitrot
Previously command "gluster volume help | grep bitrot" was not giving
sufficient information for bitrot.
With this fix command "gluster volume help" will give appropriate information
for bitrot.
Change-Id: Ic385c760d4ecbfb16ff5d90dba8940b3616035e5
BUG: 1207532
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10133
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 0b4e9d44043a0b6e2341a4f2ae0f74bb4d79bff2
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Wed Mar 25 21:07:36 2015 +0530
Cluster/DHT Mismatching gfid values in dht_local_t
If multiple files with the same name but different gfids
exist on different subvolumes, dht_lookup_everywhere_cbk()
copies the gfid from the last received response into
local->gfid but does not update the local->stbuf structure.
dht_linkfile_create() uses the value in local->gfid, but
dht_linkfile_attr_heal() uses the one in local->stbuf, causing
a mismatch and failure while trying to heal the linkfile attrs.
Change-Id: I80d152be95b42d736c5d9182b955f42e374b82a5
BUG: 1205785
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/9998
Reviewed-by: Susant Palai <spalai@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 84f812eea178e296e01a8f775ee572464df25436
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Apr 8 12:19:18 2015 +0530
dht : null dereference coverity fix
Change-Id: I700e7ebdfe4929a6d74406ea081059bdddcf7a79
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9628
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit c155202df1d9d74356d69a8528c282c4a5930fbd
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Apr 1 17:50:25 2015 +0530
libglusterfs: avoid possibility of crash when ctx is null
ctx is passed to gf_log_inject_timer_event() and pass through to
__gf_log_inject_timer_event() where the struct members are getting
dereferenced, and can cause crash if the passed ctx is null. This patch
avoids the issue.
Change-Id: I153dbb5d3744898429139e3d40bb4f0e9093632a
BUG: 1208118
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10102
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 86a54bc9888e888e3ed6e10fe0c711cdc37dc6a7
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Apr 1 17:26:25 2015 +0530
snapshot: correct error message in snapshot helper
Change-Id: Ic01a5d4115383f1245bae3fba2bf92e23c8213ff
BUG: 1194640
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9747
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit d00a34613a10e25306e6eb9470d32904db9f6b77
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Apr 8 08:03:58 2015 -0400
ganesha-ha: more robust pid file handling
fix bug with reading pid file to determine if ganesha.nfsd is running
Change-Id: I4050a119e2be93578045a221b67f616e152546d9
BUG: 1188184
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/10163
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 2a0f549f77d403ef7ad941fa392b4d672b80daeb
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Apr 1 16:00:05 2015 +0530
features/shard: Introduce file size xattr
With each inode write FOP, the size and block count of the file will be
updated within the xattr. There are two 64 byte fields that are
intentionally left blank for now for future use when consistency
guarantee is introduced later in sharding.
Change-Id: I40a2e700150c1f199a6bf87909f063c84ab7bb43
BUG: 1207603
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10097
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0608dfbdbfcc8b227c3619ebd57f44d60b1838e4
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Mar 11 18:36:01 2015 +0530
libglusterfs/syncop: Add xdata to all syncop calls
This patch adds support for xdata in both the
request and response path of syncops.
Few calls like lookup already had the support;
have renamed variables in few places to maintain
uniformity.
xdata passed downwards is known as xdata_in
and xdata passed upwards is known as xdata_out.
There is an old patch by Jeff Darcy at
http://review.gluster.org/#/c/8769/3 which does the
same for some selected calls. It also brings in
xdata support at gfapi level.
xdata support at gfapi level would be introduced
in subsequent patches.
Change-Id: I340e94ebaf2a38e160e65bc30732e8fe1c532dcc
BUG: 1158621
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/9859
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9d256d28dca22f01c061845baf6e0a6a655ecb4c
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Apr 6 13:06:31 2015 +0530
nfs : introducing logging framework for nfs translator
Change-Id: I3a47cdd06595c87da8e822d11683d68b43c11cda
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9945
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 34153fe2cf84dbf3e94c3847e3354ee0670717bd
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Apr 2 01:03:24 2015 +0530
doc: introduce upgrade guide
Eventhough we have release branches, its better to keep track of
upgrade procedures of previous versions. This way we always have
pointers to upgrade process.
Change-Id: If7a5af0e9efc36bf0343487819a4d311775e65a8
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10107
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit 6843c30c8b8484231b9647d88af4ee532319085d
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Apr 8 14:46:33 2015 +0530
features/bitrot-stub: header file update in noinst_HEADERS
Missing "bit-rot-object-version.h" causing devrpm failures.
Change-Id: I5af326c5871cc468a10dece4772b29eda06c4fa9
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10160
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 36f0a70405f63acafd9db78bae757121f9e2ff90
Author: Joseph Fernandes <josferna@redhat.com>
Date: Wed Apr 1 02:56:23 2015 +0530
ctr : Fix for heating of files during promotion/demotion
This fix will solve the heating of the files during the promotion
or demotion.
Promotion:
~~~~~~~~~
When a file gets promoted it get the current time stamp
during creation only, but following writes or reads during the
migration wont heat the file.
Demotion:
~~~~~~~~
When a file gets demoted it get the wind/unwind time stamp is set to
zero. The following writes or reads during the migration wont heat
the file.
What is remaining ?
~~~~~~~~~~~~~~~~~
Bug 1209129 ( https://bugzilla.redhat.com/show_bug.cgi?id=1209129 )
Inspite of this fix there is still a issue remaining, i.e the heat of
the file is not keep intact during a internal rebalance activity i.e
a rebalance within a tier.
Change-Id: I01e82dc226355599732d40e699062cee7960b0a5
BUG: 1207867
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10080
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 42883450d74c6405a898e14272f48a5db6d9c22e
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Mar 30 15:24:00 2015 +0530
glusterd:Change glusterd_list_add_order to add entry in ascending order
Change-Id: I0f82b1b5ad37e06135e9af33a4b5342ddde3ca94
BUG: 1207132
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10046
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit ab616e1c49cc1ae82fd041006ca7cbece58a60cd
Author: Michael Adam <obnox@samba.org>
Date: Tue Mar 31 09:50:44 2015 +0200
features/changelog: fix possible illegal memory access (CID 1288819)
Coverity CID 1288819
strncpy executed with a limit equal to the target array
size potentially leaves the target string not null terminated.
Make sure the copied string is a valid 0 terminated string.
Change-Id: Ie2d2970f37840146aa18724be3b89e93194c8160
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10062
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 5b3190211295250fa81a719a880614a6f26965d1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Mar 29 10:13:45 2015 +0530
cluster/ec: Have same ec_manager_* for [f]set/[f]removexattr
ec_manager_xxx() function for [f]set/[f]remove xattr is exactly same except the
reporting part. So moved that to common function and use same
ec_manager_xattr() function for all these fops.
Change-Id: Iaa57023b800f8d1f3f6a827f4ceba9b0a0337336
BUG: 1199767
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10036
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 4de59fdecd803c1956a35e76d95bb8cbf1d8aae2
Author: Dan Lambright <dlambrig@redhat.com>
Date: Mon Mar 30 14:27:44 2015 -0400
glusterd: Support distributed replicated volumes on hot tier
We did not set up the graph properly for hot tiers with replicated
subvolumes. Also add check that the file has not already been moved
by another replicated brick on the same node.
Change-Id: I9adef565ab60f6774810962d912168b77a6032fa
BUG: 1206517
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10054
Reviewed-by: Joseph Fernandes <josferna@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 9de820dec41a4ffbde40cfcd0033dcf53ea0c73d
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Mar 31 15:48:18 2015 +0530
bitrot/scrub: Scrubber fixes
This patch fixes a handful of problem with scrubber which
are detailed below.
Scrubber used to skip objects for verification due to missing
fd iterface to fetch versioning extended attributes. Similar
to the inode interface, an fd based interface in POSIX is now
introduced.
Moreover, this patch also fixes potential false reporting by
scrubber due to:
An object gets dirtied and signed when scrubber is busy
calculatingobject checksum. This is fixed by caching the
signed version when an object is first inspected for
stalenes, i.e., during pre-compute stage. This version is
used to verify checksum in the post-compute stage when the
signatures are compared for possible corruption.
Side effect of _not_ sending signature length during signing
resulted in "truncated" signature to be set for an object.
Now, at the time of signing, the signature length is sent
and is used in place of invoking strlen() to get signature
length (which could have possible 00s). The signature length
itself is not persisted in the signature xattr, but is
calculated on-the-fly by substracting the xattr length by
the "structure" header size.
Some of the log entries are made more meaningful (as and aid
for debugging).
Change-Id: I938bee5aea6688d5d99eb2640053613af86d6269
BUG: 1207624
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10118
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c8154af19e32de4b7e594af7f77e3c92f282f989
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Apr 6 18:14:53 2015 +0530
tests/bitrot-stub: Object versioning test(s)
This patch introduces basic object versioning test(s) which
is required for bitrot detection to work correctly. Basic
test(s) such as opening a file in read-only mode, single
open, multiple open()s are covered on FUSE mount _only_ as
stub does not support anonymous fds yet. For this reason,
the test case disables open-behind.
Actual verification is implemented as a C source which
makes use of the same on-disk data structures as used by
the stub code. The data structures are moved to separate
header file which is included by the test script. Such
modularization helps in future enhancements to keep the
version "data type" opaque and provide handful of APIs
version checking (equal/greater/etc..).
[
This is just a start and should grow over time as stub
is enhanced and codebase matures.
]
Change-Id: Ibee20e65a15b56bbdd59fd2703f9305b115aec7a
BUG: 1201724
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10140
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c47d587623c117dda58fcba03f600aabb33fc751
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Mar 30 21:46:25 2015 +0530
features/bitrot-stub: Enhancement to versioning protocol
.. and potential bug fixes / memleak.
While assigning initial version to an object, both extended attributes
(namely, ongoing version and the default signing version) were persisted.
This is optimized to just persist the ongoing version along with safe
handling of xattr request(s) in it's absence. This is better than the
earlier approach as the two xattr sets were not atomic anyway (allowing
a request to sneak in between between two set operations). This also
allows to perform sanity checks on objects during lookup()/getxattr():
objects with missing ongoing version but presence of signature are
possible candidates of tampering (and catching implementation bugs).
There were couple of instances in the code where versioning xattrs
were incorrectly removed before in-memory versions were initialized,
which have been fixed with this patch. A memory leak in the IPC code
path is also fixed.
Change-Id: I01c690ccfe7156a883582275f40f79a7c10c0900
BUG: 1207054
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/10117
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e372dc565c6301720b39709378401c2b419dd1da
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Apr 7 21:45:49 2015 +0530
storage/posix: Introduce xattr_fill capability in posix_stat
Change-Id: I2b6503ad9333f445ebdcd9fa660da20b861b985f
BUG: 1207603
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10158
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 0877d9c258dd153bf64ed929e50df5ba8e283079
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Apr 7 16:36:27 2015 +0530
tests: Replace getxattr with getfattr
Change-Id: Ibbe97dae51a81c8d5142c53a57fd9c630dfb6f46
BUG: 1191396
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10153
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c903a10cd4d38f7aac85759f97dd18d621842f25
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Feb 4 12:14:52 2015 +0530
afr : null dereference coverity fix.
CID : 1194648
Change-Id: Ib26e7cdbf412d563240885fb3113bcc1fe5c9c49
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9571
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 0669c63d586894a2d56e61c52d033b889cf49523
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Feb 2 19:19:07 2015 +0530
Cluster/afr : Coverity fix.
CID:1194644
Childup[] value will not be equal to -1 when afr_xl_op() function gets called
Change-Id: Iaf7a9d41a54f6b2d52d9ba5dadb638f328afe14b
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9540
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit e41b88f2a9dbc6ac8b31a913a89f27f398684184
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Apr 7 16:20:43 2015 +0530
doc : GlusterFS NFS-ganesha integration
Change-Id: Ie18df44d32125afcc750e1f0f2c4728aa2d93699
BUG: 1209380
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/10151
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit c41cd9d6546e09730eaa446d9cf971c1b8ea0e6b
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Apr 2 15:14:48 2015 +0530
snapshot/scheduler: Don't append timestamp in scheduled snapshots
The scheduled snapshots will now have names as follows:
Scheduled-<jobname>-<volume name>.
Stopped appending time-stamp in scheduled snapshots because
time-stamps are appended in snapshots by default unless
explicitly asked not to.
Therefore snapshot created from "Job1" of "test_vol" volume
will look like
Scheduled-Job1-test_vol_GMT-2015.04.02-09.43.02
Change-Id: I75b4a87d265ed55193f08153fd7ffe521cc5ef68
BUG: 1208097
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10115
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 36b4704c24b0beded6565298bec6391b15b855fa
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Apr 6 14:56:21 2015 +0530
snapshot/scheduler: Remove unwanted schedule enable check
Allow add, edit, list, delete of schedules even when
snapshot scheduling is disabled.
Change-Id: Ie55ea7d6e9b3fccd914a786cc54bb323ac765a98
BUG: 1209117
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10136
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c8cf7adf9534b4165bd2aed7090f8628707b8bcf
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Apr 6 14:13:09 2015 +0530
snapshot/scheduler: Check the correctness of Jobname and Volname
Check for the correctness of Jobname and Volname. They should
not be empty, and should contain only one word.
If this condition is met, the rest of the whitespaces are
also striped, before processing the command.
Change-Id: I2c9503ab86456e0f4b37e31d483ee8b2d0b0e1af
BUG: 1209120
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10137
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7027c6b49eda9c3655833045d1c667ad1513442a
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Feb 10 14:59:09 2015 +0530
dht : coverity fixes
CID : 1124352,1124365 (unchecked return value),
1124377 ( logically dead code),
1124511 (null dereference)
Change-Id: I61e029a078559cfe15d36bf0aa53418f6214e5cb
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9622
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cb934201c37cdae8ce4752cba1616440c7889477
Author: Ernestas Lukoševičius <ernetas@gmail.com>
Date: Thu Apr 2 23:28:29 2015 +0300
mount.glusterfs: mounting volumes with volume files
This is a patch for bug-1208676.
When using volume files to mount glusterfs volume,
this line is always true:
[ -z "$volume_id" -o -z "$server_ip" ] && {
That's because at this place, $volume_id and $server_ip are
set only and only if the $volfile_loc file was unreadable
or undefined.
Change-Id: Icdf7612ac13a8f953f2a2adaa426b6339cd9f8fd
BUG: 1208676
Signed-off-by: Ernestas Lukoševičius <ernetas@gmail.com>
Reviewed-on: http://review.gluster.org/10126
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit ec8bc41f834288d090dd4d66c21d8a5547467362
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Apr 1 15:13:11 2015 +0530
features/shard: Refactor code
* Renamed shard_writev_create_write_shards() to shard_common_resolve_shards()
to appropriately reflect its functionality and for reuse in other fops too.
* Move code common to MKNOD and CREATE into a macro.
* Cut down on if nesting in shard_lookup_cbk()
Change-Id: I488255499673accd426390c6d42f2b39bab3d637
BUG: 1205661
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10096
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fa2b0fed384004eeb1a45d2f3e72465cc772f72a
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Apr 6 20:44:09 2015 -0400
tests: fix spurious regression in uss.t
Sometimes .snaps just doesn't seem to be available right after a
mount. I have no idea, but maybe wrapping the next command in an
EXPECT_WITHIN will cut down on the spurious test failures.
Change-Id: I9bfda9d34e10ff0b783337e700ab8255dc6795ab
BUG: 1209286
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10143
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dec69ac3dbcffef3be4bf1fa657eed760769765b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Mar 24 12:09:52 2015 +0530
cluster/ec: Refactor inode-writev
All _cbk() functions in inode-write.c do same things, i.e. store
op_ret/op_errno, stat structures if they are available and combine them. Moved
this common operation into one function ec_inode_write_cbk() and made all the
other _cbk() functions to use this instead.
Change-Id: I2387b9f2d9598ced6299a26ea1900e9deb9fadc4
BUG: 1199767
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9981
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit aff0da2c94cb84edf240b61ffcb419c61b2cc611
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Apr 3 14:14:35 2015 +0530
performance/md-cache: set right error check in {f}getxattr_cbk()
Currently mdc_{f}getxattr_cbk() check(s) for a non-zero value to
determine if any cache update has to be performed. Right from
posix xlator, op_ret has a positive value upon success and -1 upon
failure. This patch sets right the check in getxattr callbacks so
that xattr cache update happens for successful calls.
Change-Id: Ifa5ec38bdf7e3dc095de9a56d91559b13cd9e8b6
BUG: 1208784
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/10127
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 32bb10e2b175ff53a60210d63a93826fa9df82e1
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Mar 23 15:07:47 2015 +0530
extras: Fix stop-all-gluster-processes.sh script
"test -n" command takes single string as argument. The
command was failing with "Too many arguments" when multiple
pids are got.
Change-Id: Icc409082f492c72522168d5e203684f00f52cf1b
BUG: 1204641
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9970
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2360a7f0cbcb833be3d5ef69bfb5597441071c99
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Apr 6 12:30:42 2015 +0530
tests: move bug-1168875.t to tests/bugs/snapshot folder
Change-Id: Ie4e960002b8de7e31f91365785c44df3ac04c88d
BUG: 1178685
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10131
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1f342313fee7cd839184d0a5321c54f73d14af67
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Apr 2 15:07:31 2015 +0530
glusterd: fix Null pointer dereference in bitrot disable
CID : 128806
Change-Id: Ia143a28a3dcb80d2175c908bd152c3d0b821bbb5
BUG: 789278
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10113
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit cc698cf562d56164b87c746266d1aba374981a00
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Fri Mar 20 18:35:26 2015 +0530
cluster/dht: Unwind with proper op_ret
1. Expected behavior of get_real_filename feature.
A getxattr on a existing dir with glusterfs.get_real_filename:<filename>
as key should result in one of the following things.
a. A value returned for that key having the real filename (a file whose
match is a case insensitive match to the filename passed in key).
b. op_ret = -1 and errno set to ENOENT meaning that no such file exists
under the specified dir in any case.
c. op_ret = -1 and errno set to ENODATA. This is a case assuming no
xlator interprets the glusterfs.get_real_filename key and it get
passed down to the posix xlator. Naturally, posix xlator would not
find any xattr with this key and would return ENODATA. This will be
interpreted specially by the caller as the feature not being supported
by underlying glusterfs.
2. What assumptions are wrong?
Initially the key used to be user.glusterfs.get_real_filename.
In that case, when posix xlator did a getxattr call it would have
received ENODATA as error. However, the key has now changed to
glusterfs.get_real_filename. This leads to a EOPNOTSUPP error instead.
Considering the above information, this is a rewrite of
get_real_filename logic in dht.
Change-Id: I012e9150047fc8563be91b0d112a368ac1cbf598
BUG: 1204140
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/9956
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 5d757531bfa22560d8b3fc4d26711f699681c2c2
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Mon Apr 6 18:17:10 2015 +0530
cluster/dht: fix spurious smoke test failure
There is smoke test failure due to implici declaration of function
"uuid_parse" and "uuid_compare".
Fix is to change these function caller name to "gf_uuid_parse" and
"gf_uuid_compare."
Change-Id: I79efa00c44d112c2ca732a9d9711c07bd5f1a069
BUG: 1207532
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/10139
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit a186b03496174ec1758bab758f470bd87a05319f
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Mon Mar 30 12:49:13 2015 +0530
build: sort gitignore entries
Change-Id: I79d315efb47577ab88d090a96df13f1f92ed276c
BUG: 1198849
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10099
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 53dacf5550bb2eb3c44a9ec8d5c49be56c9210cd
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 6 15:01:15 2015 +0530
build: add more files to .gitignore
Change-Id: Icef0d7f443f7caf3aa386d3a6978f98cf3a5a4af
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10132
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f29db0563e74f6b7da8f3af94f103303201b5e29
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Mar 24 13:59:00 2015 -0400
cluster/dht: fix tier.c problems found prior to feature freeze
This patch resolves tiering translator issues taken from the list
in bug 1203776. These issues have been selected to be fixed
first. The rest will be fixed in a subsequent patch (or are not a
problem).
3. Replace hardcoded #defines of promote/demote file names
6. Use loc_wipe() in migrate_using_query_file()
9. Only promote/demote files on the same node on which they reside.
14. Replace calloc with GF_CALLOC in tier.c and ensure freeing done
properly.
15. Handle if parse_query_str fails
22. Only load gfdb library on server side, remove SQL references
from client.
Change-Id: I6563b11e58ab2e4c6b1ce44db755781ad6d930fb
BUG: 1203776
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/9987
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit d80e5f0d9225ac31f61ae21f0018501a15cbd42a
Author: Michael Adam <obnox@samba.org>
Date: Tue Mar 31 09:41:10 2015 +0200
features/changelog: fix possible illegal memory access (CID 1288821)
Coverity CID 1288821
strncpy executed with a limit equal to the target array
size potentially leaves the target string not null terminated.
Make sure the copied string is a valid 0 terminated string.
Change-Id: I5ecc60549864cf50e3facbb8a2d9228cd67b57b5
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10061
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 25aaf6d327fec4e7eb08ad4208b604570093d2d8
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Apr 2 10:09:39 2015 +0530
glusterd: remove duplicate entries from volume set help
gluster volume set help was displaying redundant entries for
performance.cache-size & network.tcp-window-size as the same key is used in
different translators. Fix is to consider all the redundant ones as NO_DOC
Change-Id: I7739d992f6fdbb24765caedbb05099d269110476
BUG: 1005344
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10110
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 5b542a05afdf241389cd15456f7a5cd719301d6d
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Mon Feb 9 17:39:20 2015 +0530
snapview: Fixing the coverity issues
Coverity CIDs:
1228601
1220056
1238185
1257624
Change-Id: Idb4cc3b44bc3ccb8b497ce355e1e3bacfb176db9
BUG: 789278
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9615
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 49d930c5feca6519cb7ef62b779ae6211bf8e1a8
Author: Anoop C S <achiraya@redhat.com>
Date: Tue Mar 24 14:34:52 2015 +0530
features/trash: More coverity fixes
The following CIDs are being addressed:
1288792
1288794
Change-Id: Ic2cdaf43f05488e04616ceb801b47a47c6a93656
BUG: 789278
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/10082
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 89b4adb520c3ba8027645fd195e6a4fff2713771
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Tue Feb 17 17:27:03 2015 +0530
cli: Removing negative value check for unsigned variable (coverity fix)
CID: 1124663
Change-Id: Ic24014cdb9a68ed310c5e3dcf21fcebd6bf9da60
BUG: 789278
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9669
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit deee011205c6fc4963e2d36fbff137b20fb326e1
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Apr 2 12:51:34 2015 +0530
snapshot/scheduler: Fix the snapshot create command.
The create command being executed was sent with wrong
parameters.
Change-Id: I9b3cf23b3a02cf8309d50bf70439ad02b37f191a
BUG: 1208067
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/10114
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6ae51d4765dd8a7e0ac3e3d61c14c119814f02dc
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Apr 2 15:51:30 2015 +0200
Avoid conflict between contrib/uuid and system uuid
glusterfs relies on Linux uuid implementation, which
API is incompatible with most other systems's uuid. As
a result, libglusterfs has to embed contrib/uuid,
which is the Linux implementation, on non Linux systems.
This implementation is incompatible with systtem's
built in, but the symbols have the same names.
Usually this is not a problem because when we link
with -lglusterfs, libc's symbols are trumped. However
there is a problem when a program not linked with
-lglusterfs will dlopen() glusterfs component. In
such a case, libc's uuid implementation is already
loaded in the calling program, and it will be used
instead of libglusterfs's implementation, causing
crashes.
A possible workaround is to use pre-load libglusterfs
in the calling program (using LD_PRELOAD on NetBSD for
instance), but such a mechanism is not portable, nor
is it flexible. A much better approach is to rename
libglusterfs's uuid_* functions to gf_uuid_* to avoid
any possible conflict. This is what this change attempts.
BUG: 1206587
Change-Id: I9ccd3e13afed1c7fc18508e92c7beb0f5d49f31a
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10017
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 4a6ea7b0e04a66da069d4af540550f4db5fec961
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Apr 1 14:39:01 2015 +0530
features/shard: Create and use xattr_req dict as and when needed
Reusing local->xattr_req for the several calls and callbacks per xlator fop
would cause keys set from previous call/cbk (sometimes even by the xlators
below) to remain which in some cases can lead to errors. For instance, the
presence of "trusted.glusterfs.dht.*" keys (which are remnants of the previous
call/cbk), can cause the GF_IF_INTERNAL_XATTR_GOTO() check in DHT to fail when
the same dict is used to wind [f]setxattr.
Change-Id: I8612d020f83f3dc55e4a34d10ccbdaf11d7b4fdd
BUG: 1205661
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10095
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7bdc05a2b3c0464d65deb114638b2f9293443c0a
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed Mar 25 14:25:33 2015 -0400
cluster/dht: Fix coverity bug in tiering code
The bug was:
*** CID 1291734: Error handling issues (CHECKED_RETURN)
/xlators/cluster/dht/src/tier.c: 451 in tier_build_migration_qfile()
The fix is to check the return code to the remove library call.
It is legal to fail, we just log an INFO level message.
Change-Id: I026eb49276b394efa3b8092ee2cc209c470aacb2
BUG: 1194753
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/10000
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 26ee41ef3c761b86a15fbbd14c929b09f43a7648
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Apr 1 14:04:36 2015 +0530
features/shard: Fail writes if /.shard already exists as a file
Change-Id: Id7250ca4637c37a005cf2def43d5b843c1ea6562
BUG: 1205661
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10094
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7a176a0f4fcaf84bea6498b1f676a23f54b92bc8
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Mar 31 20:13:59 2015 +0530
libgfchangelog: Use correct 'this' pointer on new thread creation
When libgfchangelog is linked with non xlator application,
it should point to 'master' xlator which is initiated separately.
When ever a new thread is created, 'THIS' points to the global
xlator. 'THIS' should point to corresponding xlator even then.
This patch adjusts the pointer accordingly.
Change-Id: I2a199bb3c73146a0329540aedcbae697a00f6f0a
BUG: 1207643
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10074
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit c99c5e3e1954c47a177f4dacaf010a7598026112
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Thu Apr 2 10:15:07 2015 +0530
tests: Spurious failure in bug-1117851.t
This test runs file renames in a loop in the background and
expects them to be done within 75 seconds. On slower VMs the
operation takes about 75-80 seconds to complete causing the
test to fail randomly. Increased the timeout to 120 seconds.
Change-Id: I103e630c5a1bcea1fb4c7842892a2e67714c3fbb
BUG: 1163543
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/10111
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit c349ca136a69499befebd7ac66857458c71368db
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Jan 27 16:44:20 2015 +0530
glusterd: compute quorum on peers in cluster
... and not on peers participating in an ongoing
transaction.
Change-Id: I6bdb80fd3bf3e7593fdf37e45a441d4a490469b8
BUG: 1205592
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/9493
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 20fdfac89b16628ace350d83f50b061fa560795f
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Apr 1 17:09:28 2015 +0530
doc: remove latex and pdf files
Change-Id: I45443e763836c440f9e1ed83f34de486dbfe8ac8
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10089
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 25ce8923a4c121a61fb5473afec4ce1c8d448890
Author: shravantc <shravantc@ymail.com>
Date: Thu Apr 2 15:46:17 2015 +0530
doc : editing admin managing volumes
added Non Uniform File Allocation details and additional options
fixed formatting issues
fixed broken links
Change-Id: I387f29e7aab3adab9ae11d5d7474d587e249c7d0
BUG: 1206539
Signed-off-by: shravantc <shravantc@ymail.com>
Reviewed-on: http://review.gluster.org/10116
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 07ff5d16f93e65211276fa3431ff0f902240138c
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Mar 31 17:03:42 2015 +0530
geo-rep: Log Rsync performance
Introducing configurable option to log the rsync performance.
gluster volume geo-replication <MASTERVOL> <SLAVEHOST>::<SLAVEVOL> \
config log-rsync-performance true
Default value is False.
Example log:
[2015-03-31 16:48:34.572022] I [resource(/bricks/b1):857:rsync] SSH: rsync
performance: Number of files: 2 (reg: 1, dir: 1), Number of regular files
transferred: 1, Total file size: 178 bytes, Total transferred file
size: 178 bytes, Literal data: 178 bytes, Matched data: 0 bytes,
Total bytes sent: 294, Total bytes received: 32, sent 294 bytes
received 32 bytes 652.00 bytes/sec
Change-Id: If11467e29e6ac502fa114bd5742a8434b7084f98
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 764827
Reviewed-on: http://review.gluster.org/10070
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 564d5c19d66a059abce177fcb7e6b401dafa9c69
Author: arao <arao@redhat.com>
Date: Wed Feb 18 13:11:42 2015 +0530
rpc: Fixing dereferencing after null check
CID: 1124607
The pointer variable is checked for NULL and
logged accordingly.
Change-Id: Ied0d7f7ff33da22198eca65f14816b943cae5541
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9674
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f5c4379ce9cc51a1c07c4c504ff3248f65ad4d64
Author: Michael Adam <obnox@samba.org>
Date: Tue Mar 31 02:28:07 2015 +0200
features/changelog: fix possible illegal mem access (CID 1288822)
Coverity CID 1288822 (#1 of 2)
strncpy executed with a limit equal to the target array
size potentially leaves the target string not null terminated.
In this case the strncpy is not needed due to the snprintf
with the same target buffer which follows immediately.
This patch also removes the now unneeded scratch_dir
argument to gf_changelog_init_history(), which is semantically
correct, since scratch_dir has previously been filled into
jnl->jnl_working_dir by the caller, and this is now used to
fill hist_scratch_dir.
Change-Id: Ib1ed3a1058e80e34191758921b49c29030d6c9db
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10058
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b5a4a2dcf2a1272886ed7dff8830fa96d0fab7cc
Author: Michael Adam <obnox@samba.org>
Date: Mon Mar 30 19:48:27 2015 +0200
features/bit-rot: fix CID 1124725 - use after free
Coverity fixes:
CID 1124725
CID 1291742
The problem is that gf_tw_cleanup_timers() frees the handed
in priv->timer_wheel but it can not set the pointer to NULL,
so subsequent checks for priv->timer_wheel show it as not NULL
and allow for access after free.
The proper change might be to change gf_tw_cleanup_timers() to
take a reference to the pointer and set it to NULL after free,
but since it is under contrib/, I did not want to change that
function. Instead this patch uses the function's return code
which was not used previously. (Maybe this should even be done
in a wrapper macro or function?)
Change-Id: I31d80d3df2e4dc7503d62c7819429e1a388fdfdd
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10056
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit d934090249eaab6147d74c758dfa6ec1eb5008d8
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Mar 9 09:06:20 2015 +0100
Tests: fix spurious failure in read-subvol-entry.t
read-subvol-entry.t tests that if a brick has pending operations,
it is not used for readdir operations. On NetBSD this test exhibits
spurious failures, with the wrong brick being used to perform readdir.
It happens because when afr_replies_interpret() looks at xattr for
pending attributes, it uses alternative bahvior whether it is working
on a directory or another object. The decision is based on inode->ia_type,
which may be IA_INVAL at that time if we come there from:
afr_replies_interpret.()
afr_xattrs_are_equal()
afr_lookup_metadata_heal_chec()
afr_lookup_entry_heal()
afr_lookup_cbk()
Using replies[i].poststat.ia_type, which is correctly set, works around
the problem.
BUG: 1129939
Change-Id: Id9ccdd8604f79a69db5f1902697f8913acac50ad
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9831
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0980a7ed3054e1b630dabb6503172f9580331d0c
Author: vmallika <vmallika@redhat.com>
Date: Mon Mar 2 12:34:45 2015 +0530
DHT: move regular expression log message to DEBUG
Change-Id: I8652208aa2c3a600816c911a9e8af557c67d37c4
BUG: 1197585
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9777
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 46021c44bc3ee64e5e23850b92bdc8b926f8b638
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Feb 2 11:57:54 2015 +0530
Xlators : Fixed typos
Change-Id: I948f85cb369206ee8ce8b8cd5e48cae9adb971c9
BUG: 1075417
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9529
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 9a6e6975587ac60953864ca7808e28b02fbbaad8
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Apr 2 00:29:59 2015 +0530
glusterd: Fix rebase errors introduced by 4b18fba
4b18fba 'glusterd: group server-quorum related code together' a
refactoring change, introduced some errors related to usage of
userspace-rcu lists when rebasing. This patch fixes it.
Changes done include,
- Redo changes done by
673ba26 glusterd: Replace libglusterfs lists with liburcu lists
- Redo changes done by
c7785f7 glusterd: Protect the peer list and peerinfos with RCU.
- Redo changes done by
891c7d0 glusterd: Prevent possible deadlock due to
glusterd_quorum_count
Change-Id: I789e5bc8b209d9ed6dd951d609baa90e89817639
BUG: 1205592
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/10105
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 18db2bd765d613b4b4fb110137609193fb1bddd2
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Mar 5 18:19:30 2015 +0530
iobuf: Do not call __iobuf_ref directly
iobuf_get will be creating the iobuf and
hence lock is not necessary to increment ref.
However, it is a good practice to call
iobuf_ref instead of __iobuf_ref so that
we have a single point to get refs and
this can be used later to do mem
accounting etc.
Change-Id: I1fd328c3c463c23fd5f6df505ccb5c86f6207f28
BUG: 1199075
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/9812
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b69d57c73e118bcd2034fae792f9d2e513b7376a
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Mar 30 17:44:50 2015 +0530
geo-rep: Copy geo-rep hook-script during source install
The hook-script S56glusterd-geo-rep-create-post.sh was not
copying to glusterd working directory when geo-rep is
installed through source. Hence the geo-rep create fails
unless the script is manually copied. This patch addresses
the issue by copying the hook-script during make install.
Change-Id: I185a877ed720e8300f0e888ab481d0c8c23bf815
BUG: 1207201
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10051
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 5569231317579efd8fdf1c55ec5b7fde6b284d3c
Author: Michael Adam <obnox@samba.org>
Date: Tue Mar 31 09:56:35 2015 +0200
libgfdb: fix possible illegal memory access (CID 1288820)
Coverity CID 1288820
strncpy executed with a limit equal to the target array
size potentially leaves the target string not null terminated.
Make sure the copied string is a valid 0 terminated string.
Change-Id: I39ff6a64ca5b9e30562226dd34c5b06267b75b87
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10063
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Joseph Fernandes <josferna@redhat.com>
Tested-by: Joseph Fernandes <josferna@redhat.com>
commit c899a5fa669245732771ec06406561998219f9ba
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Feb 25 14:27:32 2015 +0530
snapshot: remove volname(s) to volname for snapshot create
Since we are not supporting snapshot of a multiple volume,
it is wrong to display
snapshot create <snapname> <volname(s)> [no-timestamp]
[description <description>] [force]
So changing volname(s) to volname
Change-Id: I5d367c319ab30ff5f1c89bc8de795f3436820bcc
BUG: 1196108
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9741
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit cc41b27287a0d5801eb7580b0ac07f688a1b84c2
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Mar 31 18:26:48 2015 +0530
tools/glusterfind: Validate Volume name before session Create
Do not create Session directories if Volume does not exists.
Change-Id: I60c9107135c2bed2a7198582267b2328dec7e868
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1206065
Reviewed-on: http://review.gluster.org/10072
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit d037c53d3aed5f4218dc01589935646049ee1666
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Mar 19 17:36:52 2015 +0530
tools/glusterfind: Convert Output file path to absolute path
BUG: 1203656
Change-Id: Ie6c8f38894466246c453b2a863538a420acfe9f7
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10011
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 88302fa01ab94bf70d7e7c8e961b33b360abc4cc
Author: shravantc <shravantc@ymail.com>
Date: Mon Mar 30 11:07:34 2015 +0530
doc : editing admin directory quota
added 'setting alert time' to managing directory quota.
added 'Displaying Quota Limit Information Using the df Utility' to displaying quota limit information.
Change-Id: Iaaf6201e8aa3687ee70ae28c41b870f2d7a4127f
BUG: 1206539
Signed-off-by: shravantc <shravantc@ymail.com>
Reviewed-on: http://review.gluster.org/10039
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 39343eb5a66872da901fe11b7ca540a44b8d5692
Author: Michael Adam <obnox@samba.org>
Date: Tue Mar 31 02:36:30 2015 +0200
features/changelog: fix possible memory illegal access (2 of 2, coverity)
Coverity CID 1288822 (#2 of 2)
strncpy executed with a limit equal to the target array
size potentially leaves the target string not null terminated.
Make sure the copied string is a valid 0 terminated string.
Change-Id: If283dd6f716912f65729edf6ea26a4331a697151
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10059
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 68aa240add6cf590741d27e8570356ed662cf017
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Jan 27 15:12:03 2015 +0530
glusterd: group server-quorum related code together
Server-quorum implementation was spread in many files. This patch
brings them all together into a single file, namely
glusterd-server-quorum.c. All exported functions are available via
glusterd-server-quorum.h
Change-Id: I8fd77114b5bc6b05127cb8a6a641e0295f0be7bb
BUG: 1205592
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9492
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 9b035b32fe715af9c93274dbe7654e9a569fea0f
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Fri Mar 6 16:11:16 2015 +0530
glusterd: gluster command should retrieve current op-version of the NODE
Problem:
glusterd was failing to get some specific volume option. for eg:
gluster volume get <vol-name> cluster.op-version
Fix:
glusterd should set count value in dictionary while retrieving specific volume
option.
Change-Id: Iada768ea3d8a0006895525eca2c2dcc40432a4ea
BUG: 1199451
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/9821
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit ad3e9a25f88114e7071f67ca7673a023f5c42797
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Mar 24 11:38:40 2015 +0530
Snapshot: Add/Modify snapshot section in man gluster
Change-Id: I771846c678fbfa8d941f09ef2e1de3729079aa79
BUG: 1205037
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9976
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit 8b88e4d2fa5bbd128bcf6550a2effe41b99f214f
Author: Michael Adam <obnox@samba.org>
Date: Mon Mar 30 19:25:02 2015 +0200
features/bit-rot: fix assignment instead of check (Coverity fix)
Fixes Coverity CIDs 1291728, 1291723, 1291732.
Change-Id: I62f3d540cac0f555fe2839b8418e59691c3ff4fd
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10055
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 7cd0c8c72468de91bad41c2deb86560aab575d2e
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Mon Mar 30 18:59:52 2015 +0530
libgfapi : return if gf_strdup failed
Change-Id: Ic8ad48b8118a8505ebbab2e9084007acca7226e9
BUG: 1198963
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9807
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 66bee208fe8a27ce943d9e056c4c864f393f53dd
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Mar 30 13:22:45 2015 -0400
tests: fix volume_exists to be used from EXPECT_WITHIN
Fixes the spurious volume-snapshot-clone.t regression failures. In
brief, the problem is that the script wasn't waiting for config commands
to complete, and would *sometimes* query the status of a volume while
that volume was still being deleted.
It turns out that "!" doesn't work properly from EXPECT_WITHIN, so there
was a choice between changing that or changing volume_exists. This
seemed less risky. Because of code duplication, two instances of the
function had to be changed, and the other caller (volume-snapshot.t) did
too.
Change-Id: I766d4dc7c5b11038ede8e45d9d1f29cd02a622a0
BUG: 1163543
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10053
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e547105a08c5afa34f3a2585ef8f05bdc4dfaf22
Author: Michael Adam <obnox@samba.org>
Date: Tue Mar 31 13:47:21 2015 +0200
features/trash: fix remove_trash_path in the internal case
In the internal case, copy_trash_path adds a second
path component "internal_op/", so remove_trash_path
should remove it again. Originally, remove_trash_path
did the same thing in the internal and non-internal case.
This patch fixes this problem.
Change-Id: If247d18217a2375d369672182f69a54881df26b9
BUG: 1207709
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10073
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1344f03b155463d2f0d438d942a2157c60960014
Author: Michael Adam <obnox@samba.org>
Date: Tue Mar 31 10:30:22 2015 +0200
features/trash: fix remove_trash_path() to do what it is intended.
The intention is to set the the rem_path string pointer that
is handed in from the outside. So the string has to be passed
in by reference, or else the function just sets a pointer on
the stack.
Found by Coverity, CID 1288791
Also fixes:
CID 1288791
CID 1288809
CID 1288810
CID 1288814
CID 1288815
CID 1288817
CUD 1288818
Change-Id: I6ef5eeb58b83a875cf90513291abe37dee3fc9fb
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10064
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5a060756528f2cdc556693a72896525289240263
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Jan 5 05:11:46 2015 +0530
test : fix for quota-anon-fd-nfs.t spurious failure
quota with nfs sometimes fails to get parent
with nameless lookups. This is fixed with patch# 9478
Hence, adding nfs test-case back again.
Change-Id: I9ede7c7dae4604aa7fa03ce7c36f46a9879b7479
BUG: 1163543
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/9381
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5eb2731cf0474521a9d4bc2d0ff1ee2d70cb0355
Author: vmallika <vmallika@redhat.com>
Date: Fri Mar 20 14:25:58 2015 +0530
quota: enhancement of build ancestry
There can a small race window where marker accounting will
be missed.
Consider below example where NFS mount is used
and bricks are restarted and a write operation is performed
Currently:
T1: lookup from protocol server, quota will initiate ancestry build
T2: opendir FOP from ancestry build
T3: write FOP from client
T4: write_cbk
T5: marker initiate accounting.
There will be a problem here and txn aborts,
because build_ancestry is not complete
and parent not found for an inode
T6: opendir_cbk
T7: initiate readdirp, posix builds ancestry in readdirp
With this patch, now calling readdirp on anonoymous fd
during build ancestry:
T1: lookup from protocol server, quota will initiate ancestry build
T2: readirp FOP from ancestry build, posix builds ancestry in
readdirp
T3: write FOP from client
T4: write_cbk
T5: marker initiate accounting.
No problem here as build ancestry was performed at T1
Change-Id: I2c262c86f34f6c574940a6b8772d94f2bade9465
BUG: 1184885
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9954
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit e51190d8b1aa35d2c70812bf736bbceebf4a65ab
Author: vmallika <vmallika@redhat.com>
Date: Mon Mar 2 13:10:24 2015 +0530
function gf_string2bytesize_range should handle 'xB' byte values
Change-Id: I208289aae2423e4bb015cf33bafd2a961e1c3fc6
BUG: 1197593
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9779
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1bfa6eb39c1cf3af5b696aaa0639b27cc7f397f3
Author: Michael Adam <obnox@samba.org>
Date: Tue Mar 31 12:30:06 2015 +0200
features/trash: fix storing/wiping of eliminate path (coverity)
Functions store_eliminate_path() and wipe_eliminate_path() take
eliminate as a plain pointer not pointer to pointer. Hence
store_eliminate_path fails to hand the allocated and filled
eliminate data out to the caller (in particular leaking memory),
and wipe_eliminate_path() fails to NULL the freed eliminate path.
This leads to several leak and access after free errors found
by Coverity. This patch fixes the issue by handing in eliminate
by reference and in the case of wipe_eliminate path, also NULLing
out the free'd pointer.
This fixes the following coverity IDs:
CID 1288759
CID 1288790
Change-Id: I7520ae42c5f6e369a145bea67b4ff95b75d2ae73
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10068
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f68490ddf9e15c8e561518cafe0dbd6fc9ab5897
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Mar 30 13:10:00 2015 +0530
doc/geo-rep: Documentation for management volume for geo-rep
Documented new changes to admin guide for setting up
geo-replication with the new active/passive switching
logic that comes with http://review.gluster.org/#/c/9759/
Change-Id: I47de9d2c1e678f7ad789f0ca2acf7ce67eb96c62
BUG: 1196632
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10043
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3450a293560f37a8490aee4b37280e95a6f56acc
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Mar 24 10:30:31 2015 +0530
Upcall: Added xlator options to enable cache-invalidation
Added two xlator options to enable cache-invalidation and set
cache-invalidation-timeout.
In addition, made few minor changes in the upcall processing code
in gfapi.
Change-Id: Ie0b32ca8348e34e3fe4f1e7df30cc925fa4aad31
BUG: 1200271
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/9975
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1c5f53af905febe86c1a6bad598d147d12c9aa3c
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Wed Mar 25 15:11:57 2015 +0530
NFS-Ganesha: Start and stop NFS-Ganesha service in a platform independent way
Check for what binaries are installed at run time,
pick appropriate command and perform the required
action. The service managers supported are systemctl,service
and invoke-rc.d.
Change-Id: I8deef2bfe5a09da5b055fe6176a58452a882fa76
BUG: 1202316
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/9991
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit bfcff607f9736995b6bf9a9a42a0957b4bb13e21
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Mar 3 00:27:34 2015 +0100
build: require cmocka >= 1.0.1
Our mem-pool unit test does a funky realloc(ptr, 0) as an alternative to
free(ptr). cmocka 1.0.0 has a bug where this is not handled correctly
and thinks to detect a memory leak. The next cmocka release will have
this bug fixed, making our unit tests require cmocka >= 1.0.1.
URL: https://cmocka.org/archive/cmocka/2015-02/0000059.html
Change-Id: I3d7f9b4cf7ace3f958158425ecbcc8f176579122
BUG: 1067059
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9801
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Andreas Schneider <asn@fedoraproject.org>
Tested-by: Andreas Schneider <asn@fedoraproject.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 0c03fefeab12160ee2ab7bf880b35c90a3f8c0f5
Author: Nandaja Varma <nvarma@redhat.com>
Date: Wed Feb 4 13:21:50 2015 +0530
gluster-cli: Fixing operand error and removing logically dead code.
Assign used instead of comparison
Coverity CIDs:
1124391
1124346
1124369
1124370
1124702
1124390
1124397
Change-Id: If015382917cad65edc2fee38ae6328f1d072d6f6
BUG: 789278
Signed-off-by: Nandaja Varma <nvarma@redhat.com>
Reviewed-on: http://review.gluster.org/9574
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 000b5c3386e2c8af16b49a706489e1baef8fb83a
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Wed Feb 18 16:32:17 2015 +0530
libglusterfs : dead code fix.
CID : 1124884
Change-Id: I3332e844a01c1432f1d80a6acda7a87e8b01801c
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9677
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a39496dafe4cba210af521293b2584b5ccf65a5a
Author: arao <arao@redhat.com>
Date: Tue Feb 10 02:51:43 2015 +0530
features/changelog: Fixing Deference after null check
CID: 1124481
The goto label 'out' was trying to
dereference a pointer which might be
null, hence a check on not null is
made before the use of it.
Change-Id: I813e523207b8218a7a28c2b3ac36a8e472e36c89
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9617
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 629e5fe6874393b2f58b1a1d16c6d8fec42185fb
Author: arao <arao@redhat.com>
Date: Thu Feb 19 10:13:22 2015 +0530
fuse: Removal of dead code
CID: 1124386
Dead code/ Unreachable code and related
unsed variable are removed.
Change-Id: Iafd317f01778dfe61f8a0e5398341e4f3a62d7a5
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9690
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 27a1161355a2f22742ca065befc943376c1f7618
Author: arao <arao@redhat.com>
Date: Tue Feb 17 14:54:45 2015 +0530
features/snapview-server: Fixing explicit null dereferencing.
CID: 1238184
The pointer was not checked for null before
dereferencing in the 'out' label, which is
resolved now.
Change-Id: I8aa7520102b84f63727754b8ac9c1f87ef8a6671
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9662
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 098566427f6ad10e58082398cca5ae2ad202e42e
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Wed Feb 11 11:29:20 2015 +0530
fuse: Fixing the coverity issues
Coverity CID:
1124806
1124692
Change-Id: I6dcf245ded9796fb42516eca63211d855262c26f
BUG: 789278
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9629
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d62fc900ae8490c3556a7a0a9d281d8cf0c61f5b
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Mon Feb 9 17:16:22 2015 +0530
marker, quota: Fixing the coverity issues
Coverity CIDs:
1124601
1124690
1134008
1134009
Change-Id: I93992b11bb6d8f7edd065f602aec2cd7a8b433d0
BUG: 789278
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9614
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c20d7e5f53b21aaacdf30ed4a75cb8c10e20b747
Author: Nandaja Varma <nvarma@redhat.com>
Date: Wed Feb 4 14:47:36 2015 +0530
gluster-cli : Fixing "argument can't be negative" coverity issue.
Here value of fd can never have a negative value if it is to be
closed. So changing the check from if (fd) to if (fd >= 0)
Coverity CIDs:
1124652
1124653
Change-Id: I8491afa93bab10acd2c2e01993a7f7468ca9ff87
BUG: 789278
Signed-off-by: Nandaja Varma <nvarma@redhat.com>
Reviewed-on: http://review.gluster.org/9577
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2b6867c74a052e1093a81ba7a5ad9547ce5b2b2b
Author: Michael Adam <obnox@samba.org>
Date: Tue Mar 31 02:01:40 2015 +0200
fuse: add missing return in error path (CID 1288092)
Fixes Coverity CID 1288092.
Change-Id: I95347915b1dee6003d7a1cfb86f12cf2cd7310f8
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10057
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d4f5d48a2fa517ab54df6896b0dd514556054de8
Author: vmallika <vmallika@redhat.com>
Date: Fri Mar 27 17:09:08 2015 +0530
quota/cli: improve cli error message when setting limit on invalid path
Change-Id: I5976777adf770d42aa33ebbe3833fb14c1ff658e
BUG: 1206535
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/10026
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9c6e4077419d2be89ebe3b9078c1ad284b3fb4bb
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Mar 19 12:05:16 2015 +0100
Tests: portability fixes for ipc.t
This fixes portability problems in ipc.t so that it can run on NetBSD:
1) EOPNOTSUPP value is OS-dependent. Learn it from system headers
instead of hard-coding it in the script
2) liglusterfs embbeds its own UUID implementation. The function name
may be the same as in built(in implementation from libc, but with
different prototype. In that case, we must make sure python will
use libglusterfs's version, otherwise we will crash in libc's UUID
code. Since dlopen() does not make any guarantee on what symbol
will be used, me need to preload libglusterfs when loading python.
This is done using LD_PRELOAD.
3) In python code we need to load with RTLD_GLOBAL global in order
to have dependencies loaded
4) Python's ctypes.util.find_library does not lookup LD_LIBRARy_PATH
and may therefore miss the library. On failure, retry with less
portable but more reliable explicit name
BUG: 1129939
Change-Id: I024cdfd03a5a42a8ec23de38a99e7349aba92ea8
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9944
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d324d44f26d608a7f27c3079594b700f6f9975c8
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 19 15:15:07 2015 -0400
tests: fix online_brick_count
It turns out that "pidof" is unreliable on some platforms (e.g. Fedora
21) because it will show spurious entries for processes using the same
inode under a different name. Use "pgrep" instead because it's
name-based and doesn't get confused by glusterd/glusterfs being links
to glusterfsd.
Also changed bug-913555.t because it had the same mistake in its own
version of the same function. Now it uses the common version.
Change-Id: I5d70edd5655faa5470e0f378b8c16a6adacbd4b4
BUG: 1163543
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/9948
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 787ae2e5a3ca007979b49b4f1b335c1d3b30dd89
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 26 16:06:36 2015 +0530
cluster/ec: Implement heal info for ec
This also lists the files that are on-going I/O, which
will be fixed later.
Change-Id: Ib3f60a8b7e8798d068658cf38eaef2a904f9e327
BUG: 1203581
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10020
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 0850a77904bde0e07215be644573f5de1dc13059
Author: Joseph Fernandes <josferna@redhat.com>
Date: Mon Mar 30 17:23:29 2015 +0530
Gfdb Query Fix and Volume option fix
1) Query fix in find_changed_with_freq()
2) Volume option typo fix for write_freq_threshold
and read_freq_threshold
Change-Id: I38e154818178aab412b2d7b2914cd29acef66ffb
BUG: 1207343
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/10050
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 6f70b298f67d49bdd106102a9764fe5df78e4126
Author: shravantc <shravantc@ymail.com>
Date: Mon Mar 30 14:59:35 2015 +0530
doc: editing admin setting volumes
added procedure/steps to format and mount volumes
before volumes are created. Includes step by step
creation of thinly provisioned volumes.
Change-Id: I92325d84d8b322948a7a58daf0de79e2097d252a
BUG: 1206539
Signed-off-by: shravantc <shravantc@ymail.com>
Reviewed-on: http://review.gluster.org/10044
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 29e4634a5595ffc668944bdacf6de033ebe1fa11
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Mar 27 23:43:05 2015 +0530
build:change dependency for librdmacm to version >= 1.0.15
Thanks to Niels for the fix
Change-Id: I0954b6f498461dde2b986da9e0e45775175249c9
BUG: 1206744
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/10028
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5189f6ca25414109e6479612ad802e2edfda9c05
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Mon Mar 30 12:32:27 2015 +0530
build: ignore cscope files
It is common for developers to use cscope and generate
these cscope.* files with: cscope -b -q or with some
other switches of cscope. This patch avoid 'git' to worry
about the same.
Change-Id: I3525e6f1a36f9800f4c27a2cdc6ea9c668981717
BUG: 1198849
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10040
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8ec78a6b2afd71016192300d4bf8e8770455ae6c
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Mar 25 23:39:16 2015 +0530
geo-rep: Add support for acls
This patch adds support for ACLS. When it sees SETXATTR
in Changelog, it adds the file to data queue. rsync/tar+ssh
will take care of syncing ACLS. User set ACLS will be
synced to Slave.
This requires "system.posix_acl_access" to go through when
client-pid is equal GF_CLIENT_PID_GSYNCD in fuse layer.
New config interface is introduced, sync-acls
Which can be set using geo-rep config(Default is True)
gluster volume geo-replication <VOLUME> <SLAVEHOST>::<SLAVEVOL> \
config sync-acls false
Change-Id: I7eb3523fa72b8fed830efc98138891244e830d65
BUG: 1187021
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10001
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit f7ef8426bcbfce4e630ff67e393e1e5dcf74b20c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Mar 30 09:04:15 2015 +0200
changelog xlator: avoid unsupported threaded event-poll usage
The changelog xlator was modified to use a poller thread, which uses
the same event pool as the xlator stack. Unfortunately, such threaded
usage of event pool is not supported by event-poll code, only
event-epoll supports it. As a result, platforms such as NetBSD that
lack epoll support got broken.
The fix is to remove the poller thread, which does not cause any
functionnality loss because the xlator stack event poll is
functionnal. That lets NetBSD pass AFR tests again.
BUG: 1129939
Change-Id: I3d73cf58e2ed8d92d9e0191f7abda3c37dea4159
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10030
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9863832dc61c18b6aeafb44b7c58f4bc677ae590
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Mon Mar 30 12:21:05 2015 +0530
doc: restructure developer docs to new layout
The developer oriented information is scattered in source
and its very difficult to identify which are those.
With this patch subdirs are created under developer-guide
which will be the parent for developer notes. The changes
suggested in http://review.gluster.org/#/c/8827/ are also
included in this patch.
Change-Id: I4c8510d52c49f4066225f72cac8f97f087d6c70c
BUG: 1206539
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/10038
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit c6ac2b41ff6be5b7d6ef4ebc2c459fab76de394c
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Mar 26 16:58:22 2015 +0530
tools/glusterfind: Changelog_init before changelog_register
With the new Changelog RPC based approach, Changelog_init
needs to be called before changelog_register
BUG: 1206127
Change-Id: I817b84016d3f9ffdf2ea7a4e177953fe14ccc323
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10009
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 17726bb0653a65c5e1c234fb1f4d8a74acbd6f11
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Thu Feb 12 11:20:49 2015 +0530
qemu-block: Fixing coverity issue(Unused value)
Coverity ID: 1124889 1124889 1124889 1124889 1124889 1124889 1124889
1124889 1124889 1124889 1124889
Change-Id: I82d57022c4a06fb70573b4e9436f934185f8fb84
BUG: 789278
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9642
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit ee8a78bbf096f6d7048d050f1e4a1006794eac3f
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Mar 12 15:43:56 2015 +0530
core : free up mem_acct.rec in xlator_destroy
Problem:
We've observed that glusterd was OOM killed after some minutes when volume set
command was run in a loop.
Analysis:
Initially the suspection was in glusterd code, but a deep dive into the codebase
revealed that while validating all the options as part of graph reconfiguration
at the time of freeing up the xlator object its one of the member mem_acct is
left over which causes memory leak.
Solution:
Free up xlator's mem_acct.rec in xlator_destroy ()
Change-Id: Ie9e7267e1ac4ab7b8af6e4d7c6660dfe99b4d641
BUG: 1201203
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9862
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit c7b740a7eb11519b513c0321ffba9272d13d6d37
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Sat Mar 21 15:57:13 2015 +0530
glupy: correct the definition of GlusterFS in setup.py
Change-Id: I31597a623b4ebf3d3129067eb20c661c910b97fe
BUG: 1198849
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9958
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5f2265ad576a7870b98c034b6e7845ec5678a539
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Mar 26 11:25:58 2015 +0100
mem-pool: invalidate memory on GF_FREE to aid debugging
Debugging where memory gets free'd with help from overwriting the memory
before it is free'd with some structures (repeatedly). The struct
mem_invalid starts with a magic value (0xdeadc0de), followed by a
pointer to the xlator, the mem-type. the size of the GF_?ALLOC()
requested area and the baseaddr pointer to what GF_?ALLOC() returned.
With these details, and the 'struct mem_header' that is placed when
calling GF_?ALLOC(), it is possible to identify overruns and possible
use-after-free. A memory dump (core) or running with a debugger is
needed to read the surrounding memory of corrupt structures.
This additional memory invalidation/poisoning needs to be enabled by
passing --enable-debug to ./configure.
Change-Id: I9f5f37dc4b5b59142adefc90897d32e89be67b82
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10019
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit d54d5f9bc1fdc681fa041d9fbead0025f3bf0e3c
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Mar 19 15:39:20 2015 +0530
tools/glusterfind: Ignore .trashcan dir during Brick Crawl
BUG: 1203650
Change-Id: Icf81726ad34bd5cfec6d8e06763b02a159e84c2e
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/10010
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 6177ac09dde4e051443d08ca96f55cbf72fcf539
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Mar 30 05:43:12 2015 +0200
Tests: portability fixes
Fix various portability problems in mount-nfs-auth.t,
quota-ancestry-building.t and trash.t:
- dd bs=1M is not portable, use dd bs=1024k instead
- dd bs=1MB is not portable iether, use dd bs=1000000 instead
- After restarting NFS service, wait for it to become available
- After killing a process, wait for it to terminate
- BSD awk does not accept a=b="", use a=""; b="" instead
- NetBSD displays the original program name in paenthesis at the end
of ps output. Strip it using sed 's/ *([^()]*)$//' is we want just
the command
- Do no use umount $N0, which leads to many troubles solved by
EXPECT_WITHIN $UMOUNT_TIMEOUT "Y" umount_nfs $N0
- The -p option for mkdir must be before the directory name
- du -b is not portable. Use ls -l instead.
BUG: 1129939
Change-Id: I3d44a10a37d47ebb6a263c206566487e3ffb85d8
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10033
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Anoop C S <achiraya@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 69046c8cba193744459e81010ce1eedc3c2b07aa
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Fri Mar 20 18:57:52 2015 +0530
libgfapi: revamp glfs_new function
Current glfs_new() function is not flexible enough to error out
and destroy the struct members or objects initialized just before the
error path/condition. This make the structs or objects to continue or
left out with partially recorded data in fs and ctx structs and cause
crashes/issues later in the code path. This patch avoid the issue.
Change-Id: Ie4514b82b24723a46681cc7832a08870afc0cb28
BUG: 1202492
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9903
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 1e5207915aa618b8f82b95d36ae928ec63ad2765
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Mon Mar 30 12:44:06 2015 +0530
doc: Fix Jeff Darcy's links in docs
Change-Id: I4bc859662088a55fe70714feb3c47ed02ad08e94
BUG: 1206539
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/10041
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit f2c95a9ecb4189bcaf0495bc49333a1a05c7c0de
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Jan 16 14:28:09 2015 +0530
glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref
volinfo has its own ref counting mechanism. While deleting a
volinfo object its always wiser to check there is 0 reference
to it and then delete it.
Change-Id: I446bd83432bd94aa19e29c6026367dfc1231786f
BUG: 1183463
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9462
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 4190a937058d4ff9751adc7a9b5c66592b6d3257
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Mar 24 16:29:13 2015 +0530
features/trash : Discarding extended truncate for trash-translator
Change-Id: I5c571cbb2d6da1e95831ec206639926722a9d281
BUG: 1132465
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/9984
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3425a1b8915535767e544cbb67f22f84bd29c0c5
Author: Nandaja Varma <nvarma@redhat.com>
Date: Thu Feb 5 13:37:37 2015 +0530
bd: coverity fixes, removing logically dead code and correcting checks
Coverity CIDs:
1128910
1128911
1128913
1128912
1134020
Change-Id: I2d871723fbfe43f9ff6b3beba7a99b0d81d4aff5
BUG: 789278
Signed-off-by: Nandaja Varma <nvarma@redhat.com>
Reviewed-on: http://review.gluster.org/9588
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 61d495d7f0bfd71e47c276afc11df144a7c1d476
Author: arao <arao@redhat.com>
Date: Wed Feb 18 14:57:31 2015 +0530
protocol-client: Removal of Dead Code
CID: 1124448
CID: 1124449
Removal of the dead code in the 'out' label.
Change-Id: Ibdd05cbb6e2204f6aefdf442698225883c2d7734
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9676
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 86b864bac3af289b5d7682527a62e2af357ab2af
Author: arao <arao@redhat.com>
Date: Thu Feb 19 14:37:18 2015 +0530
symlink-cache: Fixing coverity issues
CID: 1124389
Misspelt variable leading to dead code
and memory leak, corrected.
Change-Id: I1278f07f81e2db33640e0f289558d919343cb6ce
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9694
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6b02754cd74c9e0970d7672e46d2416957a9ebf3
Author: arao <arao@redhat.com>
Date: Tue Feb 10 11:06:27 2015 +0530
bd: Fixing dereference after null check(FORWARD_NULL)
CID: 1128907
The pointer variable 'bdatt' redirected to a goto label
when the value was NULL and in the other condition when it is not NULL
, hence the bdatt is again checked for NULL at 'reverse xattr' label.
Change-Id: I2289cbf30fde9faf97e6eebd4902953a44049f9e
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9619
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 009bf69d6a2a27d99ad49904694f2ce6db68e5fa
Author: arao <arao@redhat.com>
Date: Thu Feb 12 15:27:00 2015 +0530
protocol-client: Removal of Logically dead code.
CID: 1124447
The values of the pointer varibale checked,
before going to out label was always NULL,
hence dead code related to that is removed.
Change-Id: I0f9b84c7feb34072814557ddd023f2ae1c64ef7e
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9646
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b67b2dcd4ca7b4f27e7554a8f12a3c810ffa1043
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Feb 9 12:56:17 2015 +0530
cli : logically dead code removed
CID : 1124396
1124398
Change-Id: I708703529bbfe78c295523d2f4b85a55566a6249
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9606
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e5b8742816cab3e0e3810e2761d9bccbfe23aea7
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Mon Feb 16 14:26:54 2015 +0530
io-stats : null dereference coverity fix.
CID :1124502
Change-Id: I2911be340e8e48a52e951d0f04f6a96f3c219fab
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9659
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 934cd760f7713718848f3796741daa504f969e2c
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Thu Feb 12 11:47:31 2015 +0530
protocol-client : dead code removed.
CID : 1124415,1124416,
1124417,1124418,
1124419,1124420,
1124425,1124426,
1124427,1124428,
1124445,1124446.
Change-Id: Ib140b8907f4548f41fccb8044772397760fff835
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9643
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b8d59c318d87fabc92fedf2e8eb8856e3a2771b5
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Fri Feb 6 16:29:09 2015 +0530
protocol/client : logical dead code removed
CID :112438{2,3,4,5}
11244{03,04,05,06,07,08,09,10,11,12,13,14,30,31,32,33}
11244{34,35,36,37,38,39,40,41,42,43,44,56,57,58,59,60}
11244{61,62,63,64,65,66,67,68,69,70}
1128902
Change-Id: I1b53aeee83209728d5711540210d19314f4165bc
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9601
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bd1442bc625bb46b4cc18c261bf830f675bffe7b
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Feb 17 17:17:40 2015 +0530
posix : unchecked return value coverity fix.
CID : 1124364
Change-Id: I1e16e3ff46b191ba2ea527e628c77a99a56f6c31
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9667
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 57ad5f28dab1b32262b385f3ed135bea447ec8d1
Author: shravantc <shravantc@ymail.com>
Date: Fri Mar 27 17:44:01 2015 +0530
doc : editing admin_ACLs.md
Updating control entries
Change-Id: Iad5c9dcdf03fe987d1048078db6158f0e7c737a8
BUG: 1206539
Signed-off-by: shravantc <shravantc@ymail.com>
Reviewed-on: http://review.gluster.org/10027
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anjana Sriram <asriram@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit fee73564e93c7fdd651d78e1fa1e0acf7393b34a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sun Mar 29 19:59:19 2015 +0530
glusterd: Use txn_opinfo instead of global op_info in glusterd_volume_heal_use_rsp_dict
Due to http://review.gluster.org/#/c/9908/ global opinfo is no more a valid
place holder for keeping transaction information for syncop task.
glusterd_volume_heal_use_rsp_dict () was referring to global op_info due to
which the function was always asserting on the op code.
Change-Id: I1d416fe4edb40962fe7a0f6ecf541602debac56e
BUG: 1206655
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10034
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 2289a638256e4dd18d9496bbedbfb2ac4bbad788
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sat Mar 28 21:09:57 2015 +0530
glusterd : fix memory overrun for opinfo.local_xaction_peers
Due to incorrect sizeof local_xaction_peers was not allocated as intended which
lead a memory overrun in gf_free while freeing local_xaction_peers.
Change-Id: Ie4d63289aae51727eea091bce0e6cb0a496ce7cf
BUG: 1204727
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/10032
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit fee6411eacb5759ab834cb256808e74d11d196bd
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 19 15:21:12 2015 -0400
socket: use TLS 1.2 instead of 1.0
Change-Id: I96e9b37e4855f5e12b2dbecf1f0b0887b21ad5ad
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/9949
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 96bf7d1a735ec920d40a7c1ff3003e963ec2121f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Mar 24 11:36:59 2015 +0530
features/shard: Bug fixes
* Return number of bytes written in writev cbk on success
* Eliminate separate inode table for sharding xlator.
* Fix appearance of "shard" as an option within the
volfile for subvolume of type features/shard.
* Fix values of min and max allowed shard block size
* Return @new as opposed to NULL in shard_create_gfid_dict() on success
Change-Id: I6319d377a196d1c5ceed1f65d337ff8eabcb21f8
BUG: 1205661
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/10003
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 875fc32e380d047201add254d143be1b92cf3215
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Mar 19 19:32:44 2015 +0100
md-cache: cache virtual POSIX ACL xattrs
http://review.gluster.org/9627 introduces two new virtual extended
attributes that are used similar to the existing POSIX ACL xattrs. These
new xattrs should get cached in the same way.
BUG: 1185654
Change-Id: I6294b4f9ade887e29f8bd8ae5a3642891df8a631
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9947
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fa06799dbdf8a796b4a5c1db4db88291f9e1bbe0
Author: Anoop C S <achiraya@redhat.com>
Date: Thu Mar 26 12:00:39 2015 +0530
features/trash: Removing dead callbacks
Since ftruncate create, mkdir, writev, readv and
unlink calls are being re-directed to corresponding
truncate calls, we no longer need their cbks. So
removing those cbks for now.
Change-Id: I41ecde7093a555b3bf69b66afaa8eca835b4982a
BUG: 1132465
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/10002
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bd9e47ddd707b9b4008c1c40452a25cf2d5eaea0
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Mar 26 12:11:55 2015 -0400
build: attr package dependency
Already fixed in the Fedora dist-git glusterfs.spec
Change-Id: Icad7c4527d4b83417cbb81957e7b5da8b4d36368
BUG: 1184627
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/10016
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 33edf36448e2e181303ba84478f3df087e7c5e9d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 26 12:24:02 2015 +0530
features/snapview-client: Don't free un-allocated memory
Change-Id: I8636ced27448dde4f2c11370fe2026067d4a7e74
BUG: 1203637
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10004
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit caa36c8cc34c04085aaa261aaeb9a2fdb378f727
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 25 15:32:42 2015 +0530
cluster/ec: Use fd when appropriate for updating size/version
Change-Id: I5d3aca101c8cdda406d31d06c40404fa6a2b7170
BUG: 1192378
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9995
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit e0e6463eeb04a8342485f64d90ecb357851878e3
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 26 08:38:11 2015 -0400
tests: fix spurious failures in bug-1190734.t (remove-brick)
This is the second leading cause of spurious failures, including those
in tests for other spurious-regression-failure fixes (creating a bit of
a "catch 22" situation). While these failures have been hard to
reproduce except during full regression-test runs, two changes have been
made that might make this test more resilient to certain types of
failures.
* Use a specific "ls" instead of a general "find" to list/count only
the files we're interested in, without (possibly) including transient
artifacts from the "remove-brick" command.
* Retry the file count up to five times, just in case there are other
transient conditions causing it to yield the wrong result.
Also, "inlining" some of the functions for removing the brick might help
to highlight exactly which command within those functions was failing.
Change-Id: I5a462b91fb4e04d9e9a53cc60f9db11b89101107
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/10013
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4698ee919678890038c7f736ad46e47ea973066b
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri Mar 20 03:13:27 2015 +0530
geo-rep: Use gfchangelog context init API
With the RPC based changes to {libgf}changelog, changelog_init
is required before changelog_register.
Change-Id: Id125b2bd2e51aaaffa22ecab463dfb739c50d83c
Signed-off-by: Venky Shankar <vshankar@redhat.com>
BUG: 1170075
Reviewed-on: http://review.gluster.org/9993
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Tested-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 57592581ff9051533b54343f11a7b5540dd060a1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 26 21:08:12 2015 +0530
xlators/lib: Handle NULL 'name' for marker xattrs
Change-Id: I18f00b7e92f483673250821c457d1e8be2eef081
BUG: 1200372
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10015
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cbba1197ddcda986328166898481c13e473b3f94
Author: anand <anekkunt@redhat.com>
Date: Thu Mar 26 13:15:48 2015 +0530
glusterd: clean up global xaction_peer occurances
Remove xaction_peers from glusterd_conf_t which was left out by
http://review.gluster.org/#/c/9980/ patch
Change-Id: I8494ec181ec11922861d7bad12c46d45e036637b
BUG: 1204727
Signed-off-by: anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/10006
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c62b5aefe2a16b8f9e0ea7cf2f34f73c370d6078
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Jun 17 17:44:11 2014 +0530
tests: Added a script to test the glfs_fini hang fix
The script has been added as '.sh' instead of '.t' to avoid regression
tests failure which may happen due to instability of glfs_fini.
In addition, there is still some support needed to compile libgfapi*
tests in our current regression test framework.
BUG: 1093594
Change-Id: If66817f330320e8c092340008b36616e1d954127
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/8092
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit a7ef3d8696443d2ed6751d46e5ae49e9f3170e35
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Mar 25 09:21:06 2015 -0400
tests: fix rebalance_completed
This was causing spurious faiures in bug-884455.t and possibly
elsewhere.
Change-Id: Iad6b7515ca0c7c485300f79dcd2477efc76877f8
BUG: 1163543
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/9994
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 659f4c5e7fbcef808e3a695aea582e49cd8d7431
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 26 12:38:36 2015 +0530
glfsheal: Do not print pending heals for non-afr xls
Change-Id: Ib9a1998b964af1435e86de2c861ecb1c0e9026c9
BUG: 1203637
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10005
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 929c320bc57db960ba5fb51b8c55d2ec9382a317
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Mar 2 11:14:08 2015 +0100
nfs: do not fail to start when optional RPC-programs fail to register
Some RPC-programs are not strictly required for the NFS-server. When
these optional protocols fail to get registered at the portmapper, there
is no need to fail the starting of the NFS-server.
Required RPC-programs:
- NFS
- MNT
Optional RPC-programs:
- NLM
- ACL
Change-Id: Ife8ad871cff47554e3f42eb457c76431d0181964
BUG: 1205579
Tested-by: Brad Hubbard <bhubbard@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9988
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
commit fd1a627a52b1a3d1a2a99514d1ffeabc6b65fc94
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Mar 20 11:22:50 2015 +0530
cli: log gluster version in cli init
Change-Id: I4994043d303212da795c76867a7ee4355d318a8c
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9951
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 60df2f16842644c8229d02ece30381220fdb4c14
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Mar 25 10:39:20 2015 +0530
glusterd: clean up global xaction_peer occurances
With http://review.gluster.org/#/c/9972/ there is no more need to maintain
xaction_peers in glusterd_conf_t. This patch cleans up code for all the
occurances of xaction_peers.
Change-Id: I4fbf2df0fa9b8a8751029be36be7f76f6464cc76
BUG: 1204727
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9980
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 871c3145ce1c2514e5ae6c0d3ee45e5372bb3f4f
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Mar 24 11:27:52 2015 +0530
glusterd: Maintain local xaction_peer list for op-sm
http://review.gluster.org/9269 addresses maintaining local xaction_peers in
syncop and mgmt_v3 framework. This patch is to maintain local xaction_peers list
for op-sm framework as well.
Change-Id: Idd8484463fed196b3b18c2df7f550a3302c6e138
BUG: 1204727
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9972
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit bf34ff2905d3f8e487f4e6232714352470d1bb6a
Author: Anoop C S <achiraya@redhat.com>
Date: Wed Mar 25 19:51:41 2015 +0530
features/ctr: Removing rpc-lib, rpc-xdr and api from CPPFLAGS
Changetimerecorder doesn't seem to use rpc-lib, rpc-xdr
and gfapi in the source. So removing those from Makefile.am
Change-Id: I21c71db6212c10ba3821c6c456958a45c5312d41
BUG: 1198849
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/9997
Reviewed-by: Joseph Fernandes <josferna@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 20a3138910e84f24801338b045e2664aa5bcd19d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 11 17:43:12 2015 +0530
libxlator: Change marker xattr handling interface
- Changed the implementation of marker xattr handling to take just a
function which populates important data that is different from
default 'gauge' values and subvolumes where the call needs to be
wound.
- Removed duplicate code I found while reading the code and moved it to
cluster_marker_unwind. Removed unused structure members.
- Changed dht/afr/stripe implementations to follow the new implementation
- Implemented marker xattr handling for ec.
Change-Id: Ib0c3626fe31eb7c8aae841eabb694945bf23abd4
BUG: 1200372
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9892
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0ce70ad1a0e723817a3344e0de3835ea7b95c68d
Author: vmallika <vmallika@redhat.com>
Date: Thu Mar 19 07:02:24 2015 +0530
posix: handle failure from posix_resolve
When building ancestory, posix_resolve gets the inode
from the gfid. We need to handle the failure case from
this function
Change-Id: I19f0f0c739686b1b0ef96309212aa1c7911b3589
BUG: 1203629
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9941
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit c86e0e9f33305db8af5ac9348d98832bdb039ca8
Author: Joseph Fernandes <josferna@redhat.com>
Date: Mon Mar 23 19:49:19 2015 +0530
Fixing build of xlator/cluster/dht/src/dht-rebalance.c when tiering is disabled
1) Removed unnecessary include tier.h in dht-rebalance.c
2) tier xlator will only compile when tiering is enabled in configure.ac
Change-Id: Ia21aa9ff403506dc898a83236e9e2d382a0594da
BUG: 1204604
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/9973
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit afdd214fb10e57c6c9047b6b02b5429b7748982f
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Tue Mar 24 18:20:42 2015 +0530
glusterd: bitrot scrub-throttle/scrub-frequency/scrub option handling
CLI commands for bitrot features:
volume bitrot <volname> {scrub-throttle frozen|lazy|normal|aggressive}
volume bitrot <volname> {scrub-frequency daily|weekly|biweekly|monthly}
volume bitrot <volname> {scrub pause|resume}
These commands will handle their options and set respective value in
dictionary.
Change-Id: I1e8aa1b1c7d91a7f0faec9a2968b3072f42f8ba8
BUG: 1170075
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/9985
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 06ff38fea61c786f8c3e3f81c22f5a8e8a7d227d
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Mar 24 12:56:09 2015 +0530
glusterd: Prevent possible dealock in glusterd_friend_remove
This change was developed on the git branch at [1]. This commit is a
combination of the following commits on the development branch.
b02290e Prevent possible dealock in glusterd_friend_remove
[1]: https://github.com/kshlm/glusterfs/tree/urcu
Change-Id: I1efeaf18f2054f4252ee95244908613542d209d9
BUG: 1205186
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/9979
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 22ed67847e454a844c9aad7385e019ee5fff5eb7
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Mar 24 12:15:19 2015 +0530
glusterd: Prevent possible deadlock due to glusterd_quorum_count
Also rename the macro glusterd_quorum_count to GLUSTERD_QUORUM_COUNT so
that it stands out as a macro.
This change was developed on the git branch at [1]. This commit is a
combination of the following commits on the development branch.
0fbd7ba Prevent possible deadlock due to glusterd_quorum_count
5da3062 Rename glusterd_quorum_count to GLUSTERD_QUORUM_COUNT
b3aa3c4 Enclose GLUSTERD_QUORUM_COUNT definition in a do-while block
[1]: https://github.com/kshlm/glusterfs/tree/urcu
Change-Id: Ic4b3949f303d72ce53e0139f62b83b8d13fb4e47
BUG: 1205186
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/9978
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c363fd37b966d4d3cd41f39eda4de1f63bea7468
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Mar 23 16:23:00 2015 -0400
ganesha-ha: ganesha-ha.sh --status (one-liner) implementation
Change-Id: I17b7f6864dd8c1f89500a4bb89f1c249835e68da
BUG: 1188184
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/9974
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit eba26b61bd42229e8be7b5904b893d7324167d9f
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Mar 24 10:54:25 2015 +0100
rpm: move libgfdb to the glusterfs-server package
libgfdb is only used by processes that run on Gluster servers. There is
no need to have this library (and its sqlite dependency) on any system
that installs a glusterfs package.
BUG: 1194753
Change-Id: I6b7fdc70210ef2a847efd596a0c995f0a4cf5d9b
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9983
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 0fce9d1aebe4386db7deed418ac3b5416273af96
Author: Nandaja Varma <nandaja.varma@gmail.com>
Date: Wed Feb 18 16:40:03 2015 +0530
glusterd: Fixing wrong array comparison (Coverity fix)
Coverity CID: 1256175
Change-Id: Ib29fc2eaa54a7ce8369918e68bf117d0f04ca94d
BUG: 789278
Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com>
Reviewed-on: http://review.gluster.org/9679
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9974ad76fcd9f440ee02c27e93f4b5d8af6663a9
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Feb 18 17:01:21 2015 +0530
doc: document bit-rot feature
Change-Id: Ibad640d01975906b7642c76a1649e3e272f3a8bc
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9712
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ff2dc155c7325555d432a54f7489ce2db66edaee
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri Mar 13 21:23:20 2015 +0530
features/bit-rot: filesystem scrubber
Scrubber performs signature verification for objects that were
signed by signer. This is done by recalculating the signature
(using the hash algorithm the object was signed with) and
verifying it aginst the objects persisted signature. Since the
object could be undergoing IO opretaion at the time of hash
calculation, the signature may not match objects persisted
signature. Bitrot stub provides additional information about
the stalesness of an objects signature (determinted by it's
versioning mechanism). This additional bit of information is
used by scrubber to determine the staleness of the signature,
and in such cases the object is skipped verification (although
signature staleness is performed twice: once before initiation
of hash calculation and another after it (an object could be
modified after staleness checks).
The implmentation is a part of the bitrot xlator (signer) which
acts as a signer or scrubber based on a translator option. As
of now the scrub process is ever running (but has some form of
weak throttling mechanism during filesystem scan). Going forward,
there needs to be some form of scrub scheduling and IO throttling
(during hash calculation) tunables (via CLI).
Change-Id: I665ce90208f6074b98c5a1dd841ce776627cc6f9
BUG: 1170075
Original-Author: Raghavendra Bhat <rabhat@redhat.com>
Original-Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9914
Tested-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bdae47f7129dfad184468b4b90eb79da5e0696f5
Author: Venky Shankar <vshankar@redhat.com>
Date: Sun Feb 15 15:05:19 2015 +0530
features/bit-rot: Implementation of bit-rot xlator
This is the "Signer" -- responsible for signing files with their
checksums upon last file descriptor close (last release()).
The event notification facility provided by the changelog xlator
is made use of.
Moreover, checksums are as of now SHA256 hash of the object data
and is the only available hash at this point of time. Therefore,
there is no special "what hash to use" type check, although it's
does not take much to add various hashing algorithms to sign
objects with. Signatures are stored in extended attributes of the
objects along with the the type of hashing used to calculate the
signature. This makes thing future proof when other hash types
are added. The signature infrastructure is provided by bitrot
stub: a little piece of code that sits over the POSIX xlator
providing interfaces to "get or set" objects signature and it's
staleness.
Since objects are signed upon receiving release() notification,
pre-existing data which are "never" modified would never be
signed. To counter this, an initial crawler thread is spawned
The crawler scans the entire brick for objects that are unsigned
or "missed" signing due to the server going offline (node reboots,
crashes, etc..) and triggers an explicit sign. This would also
sign objects when bit-rot is enabled for a volume and/or after
upgrade.
Change-Id: I1d9a98bee6cad1c39c35c53c8fb0fc4bad2bf67b
BUG: 1170075
Original-Author: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9711
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7efa3c40a394dd2aa67e4a76596a39037f48ac52
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri Mar 13 22:00:22 2015 +0530
cli/glusterd: CLI interface for BitRot detection
* BitRot enable/disable CLI per volume
* Volfile generation for Scrubber
* Relevant glusterd infrastructure
Change-Id: I1212af63f93ecc52b22ee6da920e1664f66a1e39
BUG: 1170075
Original-Author: Raghavendra Bhat <raghavendra@redhat.com>
Original-Author: Venky Shankar <vshankar@redhat.com>
Original-Author: Gaurav Kumar Garg <ggarg@redhat.com>
Original-Author: Anand Nekkunti <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/9986
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f6f2d58b27f9a676866faeebfc376c5055c50f76
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jan 7 11:14:31 2015 +0530
mgmt/glusterd: generate volfile for BitD
* Implement the skeleton of bit-rot xlator.
Original-Author: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Signed-off-by: Anand Nekkunti <anekkunt@redhat.com>
Change-Id: If33218bdc694f5f09cb7b8097c4fdb74d7a23b2d
BUG: 1170075
Reviewed-on: http://review.gluster.org/9710
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 057d115ad32722428730b1d1558f60132a494e69
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Mar 5 14:50:26 2015 +0530
libglusterfs: check and act based on gf_malloc result.
Change-Id: If54f4be7db8b6f98e65570b09c07251e21ebae15
BUG: 1194640
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9837
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit eaab457e1ec4191003982a2a3f4ab91e0ca0f3e2
Author: Venky Shankar <vshankar@redhat.com>
Date: Sun Mar 15 04:26:15 2015 +0530
Update MAINTAINERS file
- Added maintainers for BitRot detection
Change-Id: Ib5dae02176372e33c7b616f161d909815edbb53f
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9916
Tested-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 83efa1be30512a146f0a337fe3e02edf84aacd28
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sat Aug 30 16:15:36 2014 +0530
read-only: read-only/worm translator should be in brick graph by default
Problem:
read-only/worm translator is not loaded by default in brick graph because of which
when read-only option is set through volume set volume still remains writable
untill the bricks are restarted as the translator does not have an inmemory flag
to decide whether the read-only/worm option is turned or not.
Solution:
read-only/worm should be loaded by default in brick graph and the read-only/worm
option can be toggled through volume set command. read-only/worm translator now'
has an in-memory flag to decide whether the volume is read-only or not and based
on that either reject the fop or proceed.
Change-Id: Ic79328698f6a72c50433cff15ecadb1a92acc643
BUG: 1134822
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8571
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f84b1741ebc30a311463d127652b01dd225cd61f
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Feb 9 18:28:21 2015 +0530
Bitrot Stub
Bitrot stub implements object versioning required for identifying
signature freshness. More details about versioning is explained
as a part of the "bitrot feature documentation" patch.
Change-Id: I2ad70d9eb109ba4a12148ab8d81336afda529ad9
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9709
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit eb289b6ae0787eeb0bc61c71eafb9905c2d50438
Author: Venky Shankar <vshankar@redhat.com>
Date: Sun Mar 15 03:43:49 2015 +0530
core: Add inode context merge callback
Certain translators may require to update the inode context
of an already linked inode before unwinding the call to the
client. Normally, such a case in encountered during parallel
operations when a fresh inode is chosen at call (wind) time.
In the callback path, one of inodes is successfully linked
in the inode table, thereby the other inodes being thrown
away (and the inode pointers for these calls being pointed
to the linked inode).
Translators which may have strict dependency on the correct
value in the inode context would get stale values in inode
context. This patch introduces a new callback which provides
gives translators an opportunity to "patch" their respective
inode contexts. Note that, as of now, this callback is only
invoked during create()s unwind path. Although this might
needed to be done for all dentry fops and lookup, but let
that be done as an when required (bitrot stub requires
this *only* for create()).
Change-Id: I6cd91c2af473c44d1511208060d3978e580c67a6
BUG: 1170075
Original-Author: Raghavendra Bhat <rabhat@redhat.com>
Original-Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9913
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit b94647aeeed4a10dbfb25a19420b65932aa1fcac
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Feb 25 22:21:32 2015 +0530
features/changelog: Make use of IPC fop
Translators which wish to send event notifications can send
"down" an IPC FOP with op_type as GF_IPC_TARGET_CHANGELOG
and xdata carrying event structures (changelog_event_t).
Change-Id: I0e5f8c9170161c186f0e58d07105813e34e18786
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9775
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7f0037f4074535af68bb51d87133d814ddc267f8
Author: Venky Shankar <vshankar@redhat.com>
Date: Sat Mar 21 19:59:45 2015 +0530
libgfchangelog: cleanups on disconnection
[WIP patch as of now, just needs a little tweak]
A pending TODO in the code caused regressions to fail as
bitrot daemons are spawned during volume start (equivalent
to enabling bitrot by default). The problematic part that
casued such failures is during brick disconnections with
unsafe handling of event data structured in the code.
With this patch, data structures are properly cleaned up
with care taken to cleanup all accessors first. This also
fixes potential memory leaks which was bluntly ignored
before.
Change-Id: I70ed82cb1a0fb56c85ef390007e321a97a35c5ce
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
original-author: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9959
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 4488f7c06afaaeb79cbc3abdcc669d46d92405fc
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Mar 19 10:09:04 2015 +0530
libgfchangelog: Fix faulty reference to xlator context
Problem:
libgfchangelog initializes global xlator on library load (via
constructor: _ctor) and mangles it's xlator context thereby
messing with certain important members of the command structure.
On receiving an RPC disconnection event, if the point-of-execution
was in libgfchangelogs context, accessing ->cmd_args during RPC
notify resulted in a segfault.
Fix:
Since the libarary needs to be able to work with processes that
have a notion of an xlator (THIS in particular) and without it,
care needs to be taken to allocate the global xlator when needed.
Moreover, the actual fix is to use the correct xlator context
in both cases. A new API is introduces when needs to be invoked
by the conusmer (although this could have been done during
register() call, keeping it a separate API makes thing flexible
and easy).
Test:
The issue is observed when a brick process goes offline. This is
triggered when test cases (.t's) are run in bulk, since each
test essestially spawns bricks processes (on volume start) and
terminates them (volume stop). Since bitrot daemon, as of now,
spawns upon volume start, the issue is much observed when the
volume is taken offline at the end of each test case. With this
fix, running the basic and core test cases along with building
the linux kernel has passed without daemon segfaults.
Thanks to Johnny (rabhat@) for helping in debugging the issue
(and with the fix :)).
Change-Id: I8d3022bf749590b2ee816504ed9b1dfccc65559a
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9953
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit b1187d33c8e9855634c919e6a40e7133665bf624
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Wed Mar 18 14:12:03 2015 +0530
features/trash: Handling hardlinks in trash translator
In the current code of trash translator, file is moved to
trash directory without checking whether it is the last
hardlink.This may lead to inconsistency for a file in that
gluster volume.To avoid those scenarios,so a file is moved
to trash directory only if it is the last hardlink.
Change-Id: Id098e53a2236c6406ef91e6e2599ea2cff9bace3
BUG: 1132465
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/9926
Reviewed-by: Anoop C S <achiraya@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bd0c7a76433fea5ffafcdfd34729532c17dd51b0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Mar 6 21:09:10 2015 +0530
cluster/ec: Refactor ec-dir-write
- Also fixed iatt_combine to go over all the valid iatts
Change-Id: I1d52d705ed0437f602357acde3e479cedb748681
BUG: 1199767
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9827
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e89f0c8fa88dcaf9c072ad94ffcac2c5e1279ba7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Mar 17 16:47:22 2015 +0530
glusterd: Do not use global opinfo in syncop
Global opinfo should not be referred by syncop framework as it uses local
txn_opinfo for every transaction. There is one place in the codebase where the
global opinfo is set with the local txn_opinfo which can lead to an incorrect
opinfo for an on-going op-sm transaction which refers to the same global opinfo.
Change-Id: Ida63a8871b8d03fe646146eddfd3f2473f1b1d7c
BUG: 1202745
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9908
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 88a4cc826970d617a0cf6e531d4c5c29abec68fd
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Mar 19 10:38:23 2015 +0100
build: let checkpatch check for a trailing dot
The subject of a patch should not end with a dot (.). It is not common
to have subjects of emails end with a dot, and neither is it common for
patches.
Change-Id: Id090241393aee3ca99df4887bdb2d7a7a8913164
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9940
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ira Cooper <ira@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 045c1437cf01b71f3400995ec4f54000e1ffca49
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Mar 22 13:17:46 2015 +0100
build: only include sys/sysctl.h when sysctl() is used
BUG: 1198849
Change-Id: I9597b4b7f37994865f88b99651ea9ec89787f5cf
Reported-by: Adam Borowski <kilobyte@angband.pl>
URL: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778790
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9963
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 2537c0e0aa8c560add8387fd19bd7583c97c6518
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Mar 22 12:21:05 2015 +0100
tests: move test-cases into their own component subdirectories
Change-Id: I0327a48ba5a1a217f54557386b1ae1b986702340
BUG: 1178685
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9962
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 54e36b0408c2308f53af9dde5e62425c4ed6586d
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Mar 22 12:13:42 2015 +0100
tests: move libgfapi tests to their own gfapi subdir
Also, glfs_fini() is currently not stable yet, this test case causes
many regression failures. The .t file has been renamed to .sh so that
the test does not get run automatically, but can be run easily by hand.
BUG: 1093594
Change-Id: I63fa4ddf798a505bc94d13d32dd02f22a9b7ab73
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9961
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 17727ea55dbfb72b059a5ef73ae2a55c52a104a2
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Mar 22 14:44:08 2015 +0100
build: tier.h does not need to include sys/xattr.h
FreeBSD does not have sys/xattr.h, including it in tier.h breaks
building on FreeBSD. There is nothing in tier.h that seems to require
definitions from the sys/xattr.h header, just remove it.
BUG: 1194753
Change-Id: If970272a0ce7728e0f18e5ae026880688ac31408
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9965
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
commit 75785771e381380c2ec7d88d02bcf6648b15e53b
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Mar 22 13:38:03 2015 +0100
build: pass SQLITE_CFLAGS while building dht files that include tier.h
Building on FreeBSD has been broken by http://review.gluster.org/9724
which introduces the cluster/tiering xlator. The CFLAGS passed to the
compiler do not include the path where sqlite3.h can be found.
In fact, an attempt was made to pass the flags on, but a later variable
overwrite these again.
BUG: 1194753
Change-Id: I1c890fa9a0d82492726306fe6b03bd50ca985e31
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9964
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
commit 1ad947b0259a3ef24cf7f6784975a0ad58715a17
Author: Dan Lambright <dlambrig@redhat.com>
Date: Sun Mar 22 15:27:14 2015 -0400
cluster/dht: Fix spurious failure in tier test.
Need to wait for a few seconds for rebalancing to complete
before stopping volume.
Change-Id: Ib81c02645240e7d74ebfb3e31ccbc612fc77b119
BUG: 1194753
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/9966
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 3ee5ed8da860a363fe1e03f127b0a39f5c726fb2
Author: Dan Lambright <dlambrig@redhat.com>
Date: Sun Feb 22 11:05:58 2015 -0500
cluster/dht: Add tier translator.
The tier translator shares most of DHT's code. It differs in how
subvolumes are chosen for I/Os, and how file migration (cache promotion
and demotion) is managed. That different functionality is split to either
DHT or tier logic according to the "tier_methods" structure.
A cache promotion and demotion thread is created in a manner
similar to the rebalance daemon. The thread operates a timing
wheel which periodically checks for promotion and demotion candidates
(files). Candidates are queued and then migrated. Candidates must exist on
the same node as the daemon and meet other critera per caching policies.
This patch has two authors (Dan Lambright and Joseph Fernandes). Dan
did the DHT changes and Joe wrote the cache policies. The fix depends on
DHT readidr changes and the database library which have been submitted
separately. Header files in libglusterfs/src/gfdb should be reviewed in
patch 9683.
For more background and design see the feature page [1].
[1]
http://www.gluster.org/community/documentation/index.php/Features/data-classification
Change-Id: Icc26c517ccecf5c42aef039f5b9c6f7afe83e46c
BUG: 1194753
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/9724
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d13af1168355d1ddf13a9423c29216cd8c270c65
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Mar 18 10:37:00 2015 +0530
geo-rep/gverify: Ignore .trashcan while checking slave is empty.
With trash translator, '.trashcan' is created in gluster volume
during init. So geo-rep create used to fail, with slave not
being empty. The gverify script should ignore '.trashcan' while
checking whether slave is empty.
Change-Id: Ib7ee265c6aa99b63c7ccf103747d47a6f756ad35
BUG: 1203086
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9921
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 15feabfb6b4459ccb7beb5583ac10f105b991fcc
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Mar 20 19:28:22 2015 +0530
tiering/CTR:build CTR only if tiering is enabled
Thanks to Niels for this fix
Change-Id: I9a13c3de3ed5d4eb06c6af61a2519bf27f1b6259
BUG: 1194753
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9957
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 014869ede0dbea2a8d843bfd2dec50d76060e395
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Fri Mar 13 15:33:06 2015 +0530
doc: adding logging details in admin guide.
Change-Id: I4552d98ff6b51e8171865cd0a569f6e793db9dd0
BUG: 1194640
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9876
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit 65827bdd9a547f8557fc0fa0b3337c02e77b2c0e
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Mar 19 20:30:13 2015 +0100
build: remove broken and unused _la_LIBADD variable
While building, the following warning is displayed:
xlators/features/arbiter/src/Makefile.am:7: variable `_la_LIBADD' is defined but no program or
xlators/features/arbiter/src/Makefile.am:7: library has `_la' as canonical name (possible typo)
The _la_LIBADD really seems like a typo, dropping it should not be harmful to
anything, except for the warning that will now be gone.
BUG: 1199985
Change-Id: I3f3ba911f59df2e51fdc6387295fff4bbcc5a12d
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9950
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3efaeffe478ed8d5f1a6f537875089a755268b09
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Mar 19 16:48:16 2015 +0100
build: pass the correct CFLAGS and LDFLAGS when linking (to) libgfdb
Change-Id: Id9a7d0f457d9759ab7d0a52a4000b5ae36d211f8
BUG: 1194753
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9946
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 561daff6e711ac0d3b069fb745c125e786295ebc
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Nov 21 11:47:23 2014 +0530
features/shard: Introducing sharding translator
Based on the high-level design by Anand V. Avati which can be found @
https://gist.github.com/avati/af04f1030dcf52e16535#sharding-xlator-stripe-20
Still to-do:
* complete implementation of inode write fops - [f]truncate,
zerofill, fallocate, discard
* introduce transaction mechanism in inode write fops
* complete readv
* Handle open with O_TRUNC
* Handle unlinking of all shards during unlink/rename
* Compute total ia_size and ia_blocks in lookup, readdirp, etc
* wind fsync/flush on all shards
Note: Most of the items above are related. Once we come up
with a clean way to determine the last shard/shard count for
a file/file size and the mgmt of sparse regions of the file,
implementing them becomes trivial.
Change-Id: Id871379b53a4a916e4baa2e06f197dd8c0043b0f
BUG: 1200082
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9841
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e56a81f9b96f33eb04d9ea59fa54af1f103c7faa
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Mar 19 12:33:51 2015 +0000
afr: arbiter xlator
This patch adds the arbiter translator into the tree. This is a server
side xlator used for replica 3 volumes. It sits above posix and will be
loaded on the 3rd (last) brick of every afr subvolume in a replica 3
configuration. It intercepts inode read/write operations: reads are
unwound with ENOTCONN, inode writes are unwound with success without
actually passing them down to posix. Metadata operations are allowed to
pass through.
The CLI for creating a 3 way replica with arbiter is also added but kept
disabled (A 'normal' 3 way replica is created instead).
This patch is a part of the arbiter logic implementation for 3 way AFR,
details of which can be found at http://review.gluster.org/#/c/9656/
Change-Id: I395b81f49d5da52c466daf5c8518f1bbad9c16fa
BUG: 1199985
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9840
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ef2dc6e72ff117e57b9d2f816e7a2cd4f5a2f2f0
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Mar 19 13:12:02 2015 +0100
build: correctly install the snap_scheduler tools
The current way of installing the snap-scheduler tools breaks the
building of RPMs. The tools should be installed in /usr/sbin and there
is no need to change the attributes/permissions after the installation.
Change-Id: I1b8e206748617fb000d956b1b5da52d126971c29
BUG: 1203557
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9939
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 68f4370b55ea9d59187da4b79caceb3aa761edde
Author: Anuradha <atalur@redhat.com>
Date: Wed Feb 25 15:09:28 2015 +0530
cluster/afr : enable inspection & resolution of files in split-brain
Part 2/2 patch to enable users analyze and resolve
split-brain.
This patch enables :
1) Users to inspect the files in data and metadata split-brain.
2) Resolve the split-brain.
Both using a series of setfattr commands.
Consider a volume "test" with 2 bricks.
1) To inspect a file f1:
setfattr -n replica.split-brain-choice -v test-client-0 f1
After the execution of this command, if no read_subvol
is found, reads will be served from test-client-0 (corresponding
to brick-0).
2) To resolve split-brain :
setfattr -n replica.split-brain-heal-finalize -v test-client-0 f1
Execution of this command will lead to the resolution
of data and metadata split-brain with subvol mentioned in the
command (test-client-0 here) as the source and the rest as sink.
Change-Id: Ia20f3ee5abd3119e3d54fcc599f1e55ac65fd179
BUG: 1191396
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/9743
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3dc08d62c7e5e7973e66f34fa6d8665798207c75
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed Feb 25 16:11:23 2015 -0500
glusterd: CLI commands to create and manage tiered volumes.
A tiered volume is a normal volume with some number of new bricks
representing "hot" storage. The "hot" bricks can be attached or
detached dynamically to a normal volume. When this happens, a new graph
is constructed. The root of the new graph is an instance of the tier
translator. One subvolume of the tier translator leads to the old volume,
and another leads to the new hot bricks.
attach-tier <VOLNAME> [<replica> <COUNT>] <NEW-BRICK> ... [force]
volume detach-tier <VOLNAME> [replica <COUNT>] <BRICK>
... <start|stop|status|commit|force>
gluster volume rebalance <volume> tier start
gluster volume rebalance <volume> tier stop
gluster volume rebalance <volume> tier status
The "tier start" CLI command starts a server side daemon. The daemon
initiates file level migration based on caching policies. The daemon's
status can be monitored and stopped.
Note development on the "tier status" command is incomplete. It will be
added in a subsequent patch.
When the "hot" storage is detached, the tier translator is removed
from the graph and the tiered volume reverts to its original state as
described in the volume's info file.
For more background and design see the feature page [1].
[1]
http://www.gluster.org/community/documentation/index.php/Features/data-classification
Change-Id: Ic8042ce37327b850b9e199236e5be3dae95d2472
BUG: 1194753
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/9753
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 2749d86c0dabdecf8a8cd4b51e370a702a7cd6dc
Author: Anuradha <atalur@redhat.com>
Date: Mon Mar 16 15:18:57 2015 +0530
doc: heal info and split-brain resolution document
Documentation for gluster volume heal info and split-brain
resolution.
Change-Id: Iacb30dff939c1acf06c24bd8844294d4a90ab38d
BUG: 1154599
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/9595
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 6c1e2096b918b1cced34e3686a8a92682942946b
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Mar 18 22:07:19 2015 +0100
gfapi: space/tab conversion in gfapi.map
The last two patches incorrectly add symbols indented by spaces. The
rest of the file uses tabs. This change corrects these occurences.
Change-Id: Ibfb057b78c1203a594bfeb73a2955e798e86c8e1
BUG: 1185654
Reported-by: Kaleb S. Keithley <kkeithle@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9937
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 6c623791b10d3f25102478ae9e8a993358e2186b
Author: Joseph Fernandes <josferna@redhat.com>
Date: Wed Mar 18 19:55:31 2015 +0530
Adding ChangeTimeRecorder(CTR) Xlator to GlusterFS
**********************************************************************
ChangeTimeRecorder(CTR) Xlator |
**********************************************************************
ChangeTimeRecorder(CTR) is server side xlator(translator) which sits
just above posix xlator. The main role of this xlator is to record the
access/write patterns on a file residing the brick. It records the
read(only data) and write(data and metadata) times and also count on
how many times a file is read or written. This xlator also captures
the hard links to a file(as its required by data tiering to move
files).
CTR Xlator is the consumer of libgfdb.
To Enable/Disable CTR Xlator:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gluster volume set <volume-name> features.ctr-enabled {on/off}
To Enable/Disable Frequency Counter Recording in CTR Xlator:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gluster volume set <volume-name> features.record-counters {on/off}
Change-Id: I5d3cf056af61ac8e3f8250321a27cb240a214ac2
BUG: 1194753
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/9935
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4f92c391a8af9583d185a789fe5ef373f4bffb14
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 1 13:15:45 2015 +0100
glusterfsd: add "print-netgroups" and "print-exports" command
NFS now has the ability to use a separate file for "netgroups" and
"exports". An administrator should have the ability to check the
validity of the files before applying the configuration.
The "glusterfsd" command now has the following additional arguments that
can be used to check the configuration:
--print-netgroups: Validate the netgroups file and print it out
--print-exports: Validate the exports file and print it out
BUG: 1143880
Change-Id: I24c40d50110d49d8290f9fd916742f7e4d0df85f
URL: http://www.gluster.org/community/documentation/index.php/Features/Exports_Netgroups_Authentication
Original-author: Shreyas Siravara <shreyas.siravara@gmail.com>
CC: Richard Wareing <rwareing@fb.com>
CC: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9365
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 18cd858fe7eb7105b872d7c773f8ba2d6f845465
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Feb 3 19:05:28 2015 +0530
contrib/timer-wheel: import linux kernel timer-wheel
This patch imports timer-wheel[1] algorithm from the linux
kernel (~/kernel/time/timer.c) with some modifications.
Timer-wheel is an efficent way to track millions of timers for
expiry. This is a variant of the simple but RAM heavy approach
of having a list (timer bucket) for every future second.
Timer-wheel categorizes every future second into a logarithmic
array of arrays. This is done by splitting the 32 bit "timeout"
value into fixed "sliced" bits, thereby each category has a
fixed size array to which buckets are assigned.
A classic split would be 8+6+6+6 (used in this patch) which
results in 256+64+64+64 == 512 buckets. Therefore, the entire
32 bit futuristic timeouts have been mapped into 512 buckets.
[
NOTE:
There are other possible splits, such as "8+8+8+8", but
this patch sticks to the widely used and tested default.
]
Therfore, the first category "holds" timers whose expiry range
is between 1..256, the next cateogry holds 257..16384, third
category 16385..1048576 and so on. When timers are added,
unless it's in the first category, timers with different
timeouts could end up in the same bucket. This means that the
timers are "partially sorted" -- sorted in their highest bits.
The expiry code walks the first array of buckets and exprires
any pending timers (1..256). Next, at time value 257, timers
in the first bucket of the second array is "cascaded" onto
the first category and timers are placed into respective
buckets according to the thier timeout values. Cascading
"brings down" the timers timeout to the coorect bucket
of their respective category. Therefore, timers are sorted
by their highest bits of the timeout value and then by the
lower bits too.
[1] https://lwn.net/Articles/152436/
Change-Id: I1219abf69290961ae9a3d483e11c107c5f49c4e3
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9707
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 809e4e4c9b0eb032530d7dfb6da164739f155685
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Mar 18 19:50:03 2015 +0530
geo-rep: Ignore .trashcan during xsync crawl.
With trash feature, .trashcan directory gets created
at each export directory. Xsync picks .trashcan to sync
and fails with EPERM. Xsync should ignore .trashcan
directory.
Change-Id: I45bd226c96011ace2c40dd2de878d886c7d34ce5
BUG: 1203293
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9934
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit af69a89ca7b2e26f8eff6cce9963ba60fa4c6c62
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Feb 3 19:03:30 2015 +0530
libglusterfs/rot-buffs: rotational buffers
This patch introduces rotational buffers aiming at the classic
multiple producer and multiple consumer problem. A fixed set
of buffer list is allocated during initialization, where each
list consist of a list of buffers. Each buffer is an iovec
pointing to a memory region of fixed allocation size. Multiple
producers write data to these buffers. A buffer list starts with
a single buffer (iovec) and allocates more when required (although
this can be preallocatd in multiples of k).
rot-buffs allow multiple producers to write data parallely with
a bit of extra cost of taking locks. Therefore, it's much suited
for large writes. Multiple producers are allowed to write in the
buffer parallely by "reserving" write space for selected number
of bytes and returning pointer to the start of the reserved area.
The write size is selected by the producer before it starts the
write (which is often known). Therefore, the write itself need not
be serialized -- just the space reservation needs to be done safely.
The other part is when a consumer kicks in to consume what has
been produced. At this point, a buffer list switch is performed.
The "current" buffer list pointer is safely pointed to the next
available buffer list. New writes are now directed to the just
switched buffer list (the old buffer list is now considered out
of rotation). Note that the old buffer still may have producers
in progress (pending writes), so the consumer has to wait till
the writers are drained. Currently this is the slow path for
producers (write completion) and needs to be improved.
Currently, there is special handling for cases where the number
of consumers match (or exceed) the number of producers, which
could result in writer starvation. In this scenario, when a
consumers requests a buffer list for consumption, a check is
performed for writer starvation and consumption is denied
until at least another buffer list is ready of the producer
for writes, i.e., one (or more) consumer(s) completed, thereby
putting the buffer list back in rotation.
[
NOTE:
I've not performance tested this producer-consumer model
yet. It's being used in changelog for event notification.
The list of buffers (iovecs) are directly passed to RPC
layer.
]
Change-Id: I88d235522b05ab82509aba861374a2312bff57f2
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9706
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit a8eaf4dc779485fd964bda606defdc694bc90e37
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Tue Mar 10 15:04:59 2015 +0530
cli/glusterd: cli command implementation for bitrot features
CLI command for bitrot features.
volume bitrot <volname> enable|disable
Above command will enable/disable bitrot feature for particular volume.
BUG: 1170075
Change-Id: Ie84002ef7f479a285688fdae99c7afa3e91b8b99
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Signed-off-by: Anand nekkunti <anekkunt@redhat.com>
Signed-off-by: Dominic P Geevarghese <dgeevarg@redhat.com>
Reviewed-on: http://review.gluster.org/9866
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ff64f014fe3a5b034e8bc32a74d356c4fd088bd7
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Feb 9 18:03:20 2015 +0530
snapshot/scheduling: A cron based scheduler for snapshot scheduling
GlusterFS volume snapshot provides point-in-time copy
of a GlusterFS volume. Currently, GlusterFS volume
snapshots can be easily scheduled by setting up
cron jobs on one of the nodes in the GlusterFS
trusted storage pool. This has a single point failure (SPOF),
as scheduled jobs can be missed if the node running the cron
jobs dies.
The solution to the above problems is addressed in this patch.
The snap_scheduler.py helper script expects the user to install
the argparse python module before using it.
Further details for the same are available at:
http://www.gluster.org/community/documentation/index.php/Features/Scheduling_of_Snapshot
Change-Id: I2c357af5b7d3e66f270d20eef50cdeecdcbe15c7
BUG: 1198027
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9788
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 138e10eea0012b1bbe96815214a9107f16e11005
Author: vmallika <vmallika@redhat.com>
Date: Wed Mar 18 23:17:23 2015 +0530
features/quota : Introducing inode quota
==========================================================================
Inode quota
==========================================================================
= Currently, the only way to retrieve the number of files/objects in a =
= directory or volume is to do a crawl of the entire directory/volume. =
= This is expensive and is not scalable. =
= =
= The proposed mechanism will provide an easier alternative to determine =
= the count of files/objects in a directory or volume. =
= =
= The new mechanism proposes to store count of objects/files as part of =
= an extended attribute of a directory. Each directory's extended =
= attribute value will indicate the number of files/objects present =
= in a tree with the directory being considered as the root of the tree. =
= =
= The count value can be accessed by performing a getxattr(). =
= Cluster translators like afr, dht and stripe will perform aggregation =
= of count values from various bricks when getxattr() happens on the key =
= associated with file/object count. =
A new interface is introduced:
------------------------------
limit-objects : limit the number of inodes at directory level
list-objects : list the directories where the limit is set
remove-objects : remove the limit from the directory
==========================================================================
CLI COMMAND:
gluster volume quota <volname> limit-objects <path> <number> [<percent>]
* <number> is a hard-limit for number of objects limitation for path "<path>"
If hard-limit is exceeded, creation of file/directory is no longer
permitted.
* <percent> is a soft-limit for number of objects creation for path "<path>"
If soft-limit is exceeded, a warning is issued for each creation.
CLI COMMAND:
gluster volume quota <volname> remove-objects [path]
==========================================================================
CLI COMMAND:
gluster volume quota <volname> list-objects [path] ...
Sample output:
------------------
Path Hard-limit Soft-limit Used Available
Soft-limit exceeded?
Hard-limit exceeded?
------------------------------------------------------------------------
--------------------------------------
/dir 10 80% 10 0
Yes
Yes
==========================================================================
[root@snapshot-28 dir]# ls
a b file11 file12 file13 file14 file15 file16 file17
[root@snapshot-28 dir]# touch a1
touch: cannot touch `a1': Disk quota exceeded
* Nine files are created in directory "dir" and directory is included in
* the
count too. Hence the limit "10" is reached and further file creation
fails
==========================================================================
Note: We have also done some re-factoring in cli for volume name
validation. New function cli_validate_volname is created
==========================================================================
Change-Id: I1823497de4f790a2a20ebb1770293472ea33ee2b
BUG: 1190108
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9769
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 751f2458eda958d606a0c108e489eb708183c204
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Mar 4 18:05:30 2015 +0530
geo-rep / gsyncd: use RTLD_GLOBAL while loading libgfchangelog
With the RPC based changes to {libgf}changelog, loading shared
objects dynamically would need symbols to be available from
other shared libraries. As an example, creating an RPC listner
loads the RPC transport shared object which requires symbols
to be available from already loaded shared objects.
Using RTLD_GLOBAL makes the symbols available for symbol
resolution of subsequently loaded libraries.
Change-Id: I3d3ef790eded82911f05836c707509157680645c
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9814
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5444d312903c9b3778b88878c7c5772e2119581b
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Feb 3 19:22:16 2015 +0530
features/changelog: RPC'fy {libgf}changelog
This patch introduces RPC based communication between the changelog
translator and libgfchangelog. It replaces the old pathetic stream
based interaction that existed earlier (due to time constraints :-/).
Changelog, upon initialization starts a RPC server (rpcsvc) allowing
clients to invoke a probe API as a bootup mechanism to request for
event notifications. During probe, clients can choose an event
filter specifying the type(s) of events they are interested in. As
of now there is no way to change the event notification set once
the probe RPC call is made, but that is easier to implement.
The actual event notifications is done on a separate RPC session.
The client (libgfchangelog) itself starts and RPC server which the
changelog translator "connects back" during probe. Notifications
are dispatched by a bunch of threads from the server (translator)
and the client optionally orders them if ordered notifications
are requried. FOPs fill in their respective event details in a
buffer (rot-buffs to be particular) and a bunch of threads
(consumers) swap the buffers out of roatation and dispatch them
via RPC. To avoid writer starvation, then number of dispatcher
threads is one less than the number of buffer list in rot-buffs.x
libgfchangelog becomes purely callback based -- upon event
notification from the server (and re-ordering them if required)
invoke a callback routine specified by consumer(s).
A major part of the patch is also aimed at providing backward
compatibility for geo-replication, which was one of the main
consumer of the stream based API. Also, this patch does not\
"turn on" event notifications for all fops, just a bunch which
is currently in requirement. Another pain point is that the
server does not filter events before dispatching it to the
clients. That load is taken up by the client itself (although
it's done at the library layer rather than making it hard on
the callback implementor). This needs improvement and care
needs to be taken to not load the server up with expensive
filtering mechanisms.
Change-Id: Ibf60a432b68f2dfa60c6f9add2bcfd37a9c41395
BUG: 1170075
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/9708
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ab0b7dc45bf35fd926beda9b3dbdfd10331f4ec4
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Feb 24 19:42:49 2015 +0100
gfapi: add glfs_h_acl_set() and glfs_h_acl_get()
These two functions add support for POSIX ACLs through the GFAPI-handle
interface.
The initial infrastructure for POSIX ACLs based on libacl has been added
with the required changes to the POSIX xlator:
- http://review.gluster.org/9627
NetBSD does not support POSIX ACLs, so using any of the functions should
return ENOTSUP.
URL: http://www.gluster.org/community/documentation/index.php/Features/Improved_POSIX_ACLs
Change-Id: Ie74f3f963c3f9d576cb2f2a1e6d97e3cd4b01eda
BUG: 1185654
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9736
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2ae4fd2dbf9496b4e932dedfe34b8cd28dca936a
Author: Joseph Fernandes <josferna@redhat.com>
Date: Wed Feb 18 19:45:23 2015 +0530
Adding Libgfdb to GlusterFS
*************************************************************************
Libgfdb |
*************************************************************************
Libgfdb provides abstract mechanism to record extra/rich metadata
required for data maintenance, such as data tiering/classification.
It provides consumer with API for recording and querying, keeping
the consumer abstracted from the data store used beneath for storing data.
It works in a plug-and-play model, where data stores can be plugged-in.
Presently we have plugin for Sqlite3. In the future will provide recording
and querying performance optimizer. In the current implementation the schema
of metadata is fixed.
Schema:
~~~~~~
GF_FILE_TB Table:
~~~~~~~~~~~~~~~~~
This table has one entry per file inode. It holds the metadata required to
make decisions in data maintenance.
GF_ID (Primary key) : File GFID (Universal Unique IDentifier in the namespace)
W_SEC, W_MSEC : Write wind time in sec & micro-sec
UW_SEC, UW_MSEC : Write un-wind time in sec & micro-sec
W_READ_SEC, W_READ_MSEC : Read wind time in sec & micro-sec
UW_READ_SEC, UW_READ_MSEC : Read un-wind time in sec & micro-sec
WRITE_FREQ_CNTR INTEGER : Write Frequency Counter
READ_FREQ_CNTR INTEGER : Read Frequency Counter
GF_FLINK_TABLE:
~~~~~~~~~~~~~~
This table has all the hardlinks to a file inode.
GF_ID : File GFID (Composite Primary Key)``|
GF_PID : Parent Directory GFID (Composite Primary Key) |-> Primary Key
FNAME : File Base Name (Composite Primary Key)__|
FPATH : File Full Path (Its redundant for now, this will go)
W_DEL_FLAG : This Flag is used for crash consistancy, when a link is unlinked.
i.e Set to 1 during unlink wind and during unwind this record
is deleted
LINK_UPDATE : This Flag is used when a link is changed i.e rename.
Set to 1 when rename wind and set to 0 in rename unwind
Libgfdb API:
~~~~~~~~~~~
Refer libglusterfs/src/gfdb/gfdb_data_store.h
Change-Id: I2e9fbab3878ce630a7f41221ef61017dc43db11f
BUG: 1194753
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/9683
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit abfb6ad4b8b4d0ee17fb82f9afe9715085642068
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Mar 18 15:25:08 2015 +0530
marker: fix compile time warning on buf arg.
Problem:
marker-quota.c: In function 'mq_inspect_directory_xattr_task':
marker-quota.c:3451:31: warning: variable 'buf' set but not
used [-Wunused-but-set-variable]
struct iatt buf = {0,};
Change-Id: I211378328bdb2509a5d2a186d173f7f30a670c8a
BUG: 1198849
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9928
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d79a40e0a5abb5d5dc930800a330a9c5cf0e1b41
Author: vmallika <vmallika@redhat.com>
Date: Thu Jan 22 17:40:44 2015 +0530
Quota: Build ancestry in the lookup
Marker can fail or can account incorrect numbers when it doesn't find a
ancestry for a inode.
Solution:
Current build_ancestry is done only on demand in the write/create FOPs
in quota enforcer.
It is good to do this in the quota_lookup as well.
Change-Id: I8aaf5b3e05a3ca51e7ab1eaa1b636a90f659a872
BUG: 1184885
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9478
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c1f12e98b155774957a0cd84660c77702ab43315
Author: Dan Lambright <dlambrig@redhat.com>
Date: Wed Feb 18 14:49:50 2015 -0500
cluster/dht: Change the subvolume encoding in d_off to be a "global" position in the graph rather than relative (local) to a particular translator.
Encoding the volume in this way allows a single translator to manage
which brick is currently being scanned for directory entries. Using a
single translator minimizes allocated bits in the d_off. It also allows
multiple DHT translators in the same graph to have a common frame of
reference (the graph position) for which brick is being read. Multiple
DHT translators are needed for the Tiering feature.
The fix builds off a previous change (9332) which removed subvolume
encoding from AFR. The fix makes an equivalent change to the EC
translator.
More background can be found in fix 9332 and gluster-dev discussions [1].
DHT and AFR/EC are responsibile (as before) for choosing which brick to
enumerate directory entries in over the readdir lifecycle.
The client translator receiving the readdir fop encodes the dht_t. It
is referred to as the "leaf node" in the graph and corresponds to the
brick being scanned.
When DHT decodes the d_off, it translates the leaf node to a local
subvolume, which represents the next node in the graph leading to
the brick.
Tracking of leaf nodes is done in common utility functions. Leaf nodes
counts and positional information are updated on a graph switch.
[1] www.gluster.org/pipermail/gluster-devel/2015-January/043592.html
Change-Id: Iaf0ea86d7046b1ceadbad69d88707b243077ebc8
BUG: 1190734
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/9688
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 2e0463e5bfadb4db042bf86dfe08316637b97b73
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Mon Feb 2 16:23:22 2015 +0530
CLI : GLobal option for NFS-Ganesha
A new global CLI option has been introduced for NFS-Ganesha.
gluster features.ganesha enable/disable.
This option is persistent and shall be inherited
by new volumes created after this option is set.
gluster features.ganesha enable
It carries out the following functions:
1. Disables gluster-nfs across the cluster
2. Starts NFS-Ganesha server on a subset of nodes and exports '/'.
3. Creates the HA cluster for NFS-Ganesha.
4. Writes the option into the global config file.
gluster features.ganesha disable
1. Stops NFS-Ganesha server.
2. Tears down the HA cluster for NFS-Ganesha
With this change the older volume set
options with keys "nfs-ganesha.host"
and "nfs-ganesha.enable" will no longer
be supported. This commit has only has the
CLI related changes. Another patch will
be submitted to support this feature entirely.
Change-Id: Ie4b66a16c23b33b795738654b9a68f8e2c34efe3
BUG: 1188184
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/9538
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 25638e842d1b3ccfbf3cf705ea4d4f3a2656d622
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Fri Mar 13 19:39:13 2015 +0530
dht: suggest to add more bricks when min-free-disk is exceeded.
Change-Id: I628fbd99c2478fcb8bb6e5be55e43467f25227bf
BUG: 1165870
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9879
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 12eacc3b123ba4bb3ec3e8bd0ab9e97ef6455c62
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Mar 16 11:36:38 2015 +0100
Tests: do not hardcode NFS state directory
tests/basic/mount-nfs-auth.t hardcoded /var/lib/glusterd/nfs/
as the NFS state directory, cuasing failures if glusterfs was
configured with state in another location.
Fix this by obtaning the directory through a gluster volume get
command. The nfs.mount-rmtab key gives us a file inside the
directory we are looking for.
This fixes tests/basic/mount-nfs-auth.t regression on NetBSD.
BUG: 1129939
Change-Id: I19184859c03faf5b9aeb95d080cf90fa581be380
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9896
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit aaa1799974db52e35eb03dff85a0968379f3eb70
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Mar 12 23:51:41 2015 +0530
doc: correct component name in manage volumes.
Change-Id: I12cb0cdacace755d6c545c8697a4e18d6035954b
BUG: 1075417
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9869
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit e65cb6cc0488edd8eade2a5f6be8c516b8bb4863
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Mar 17 20:40:58 2015 +0100
Tests: ls portability regarding dot-files
When run as root, BSD ls(1) lists dot-files, which includes
.glusterfs in split-brain-healing.t's usage. This leads to failure.
gfid-self-heal.t suffers the same problem.
Fix by filtering out dot-files in ls(1) output
NB: split-brain-healing.t also requires http://review.gluster.org/9831
to pass on NetBSD.
BUG: 1129939
Change-Id: Ic572d3abf685e9b43f32ddee8a13b5f5c4ae641f
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9885
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 8dc4f50d9c374e95b342eeebc33df64afeae3ea6
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 1 13:15:45 2015 +0100
glusterd: add new NFS options for exports/netgroups and related caching
The following options for the Gluster/NFS server are added :
- nfs.exports-auth-enable
- nfs.auth-refresh-interval-sec
- nfs.auth-cache-ttl-sec
BUG: 1143880
Change-Id: I37a73966c4ed27cd0f8c77200ef68a0d12b385b8
Original-author: Shreyas Siravara <shreyas.siravara@gmail.com>
CC: Richard Wareing <rwareing@fb.com>
CC: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9364
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c2c9833b493113822f5b2cd13832c0d49a9ea302
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Mar 5 00:54:36 2015 +0530
doc: document glusterfind feature
Change-Id: I759f05d63028d6a52c3e1ee2ab9892583c4832e7
BUG: 1193893
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9800
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6d9d3b13b5ae1e45729f99f41b3d33e500fcffb0
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Mar 17 12:06:25 2015 +0530
glusterd: Remove compilation warning
In glusterd_peerinfo_destroy, cast the passed 'strcut rcu_head *'
pointer to 'gd_rcu_head *' before use in caa_container_of() to prevent
the incompatible-pointer compilation warning.
Also, refactor peerinfo->head to peerinfo->rcu_head to reduce confusion
when reading code.
This change was developed on the git branch at [1]. This commit is a
combination of the following commits on the development branch.
aa4a0bc Rename peerinfo->head to peerinfo->rcu_head
c79144b Cast struct rcu_head * to gd_rcu_head * to prevent warning
1d222c3 More head -> rcu_head renames
[1]: https://github.com/kshlm/glusterfs/tree/urcu
BUG: 1191030
Change-Id: I7ede02090413839563ce44fdf6289697b28777e7
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/9922
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f292036f2adc14b4df2109a8de647c2aa18e0f9e
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Mar 18 12:58:59 2015 +0530
geo-rep: Remove Generated file From git
geo-replication/src/peer_mountbroker
BUG: 1136312
Change-Id: Ib9b287b4e1183cb44acbf01184a240be7f09be7c
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9923
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 608067a4f380134555c0ce158a1c57ec5a070488
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Feb 18 19:07:23 2015 +0530
feature/glusterfind: A tool to find incremental changes
Documentation is available in patch:
http://review.gluster.org/#/c/9800/
A tool which helps to get list of modified files or list of all files in
GlusterFS Volume using Changelog or find command.
Usage
=====
glusterfind --help
Create:
-------
glusterfind create --help
The tool creates status file $GLUSTERD_WORKDIR/SESSION/VOLUME/status
and records current timestamp to initiate the session. This timestamp
will be used as start time for next runs.
As part of create also generates ssh key and distributes to all peers.
and enables build.pgfid and changelog using volume set command.
Pre:
----
glusterfind pre --help
This command is used to generate the list of files modified after session
creation time or after last run. To get list of all files/dirs in Volume,
run pre command with `--full` argument.
The tool gets all nodes details using gluster volume info and runs node
agent for each brick in respective nodes via ssh command. Once these node
agents generate the output file, tool copies to local using scp. Merges all
the output files to generate the final output file.
Post:
-----
glusterfind post --help
After consuming the list, this sub command is called to update the session
time based on pre command status file.
List:
-----
glusterfind list --help
To view all the sessions
Delete:
-------
glusterfind delete --help
Delete session.
Known Issues
------------
1. Deleted files will not get listed, since we can't convert GFID to
Path if file/dir is deleted.
2. Only new name will get listed if Renamed.
3. All hardlinks will get listed.
Change-Id: I82991feb0aea85cb6ec035fddbf80a2b276e86b0
BUG: 1193893
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9682
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ef570b27105b526d96a6cb8ca4f3aefed0584eaf
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Mar 17 13:16:45 2015 +0530
cluster/afr: Make read child match check in afr optional
Having this particular check which was introduced by
commit c78998c39f0857ea7aacba360632c148afc54a55 causes a drop in
performance in readdirp. So the behavior is made configurable with this
patch.
Change-Id: I2858fc18b3539df7aa6d3f489e0d5cfaeb8a9b3c
BUG: 1202669
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9917
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 9de8b833f6f972e2248f880a06c95450154322c8
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Wed Mar 18 11:33:50 2015 +0530
NFS-Ganesha: Volume set option for managing NFS-Ganesha exports.
A dummy translator has been introduced as a place
holder for functions related to managing NFS-Ganesha
exports. A volume set option is introduced to
manage volume level exports.
gluster vol set <volname> ganesha.enable ON/OFF
1. gluster volume set <volname> ganesha.enable ON
It creates the export config file with a unique export ID.
Sends a DBus signal to export this volume dynamically.
2. gluster vol set <volname> ganesha.enable OFF
Unexports the specific volume. Deletes the specfic
config file related to the volume.
This change also removes the handling of the older
keys "nfs-ganesha.enable" and "nfs-ganesha.host"
Change-Id: I8d4a0b542326a6a0c8e4711600b106274d666587
BUG: 1188184
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/9585
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 7cc1066b558d3a7793102d5b9721dfd5ffa0c697
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Feb 23 17:28:47 2015 +0530
Snapshot/clone: clone of a snapshot that will act as a regular volume
snapshot clone will allow us to take a snpahot of a snapshot.
Newly created clone volume will be a regular volume with read/write
permissions.
CLI command
snapshot clone <clonename> <snapname>
Change-Id: Icadb993fa42fff787a330f8f49452da54e9db7de
BUG: 1199894
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9750
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9802c29fa8828237be61e3f5e376672704fbac95
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Mar 16 15:47:30 2015 +0530
libgfapi, timer: Fix a crash seen in timer when glfs_fini was invoked.
The crash is seen when, glfs_init failed for some reason
and glfs_fini was called for cleaning up the partial initialization.
The fix is in two folds:
1. In timer store and restore the THIS, previously
it was being overwritten.
2. In glfs_free_from_ctx() and glfs_fini() check for
NULL before destroying.
Change-Id: If40bf69936b873a1da8e348c9d92c66f2f07994b
BUG: 1202290
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9895
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2d5a72ef08978b99508c7a3b856f28e3c5a66b0d
Author: Anoop C S <achiraya@redhat.com>
Date: Tue Mar 17 16:29:53 2015 +0530
features/trash: Avoid unnecessary logging from trash_local_wipe
Even when trash translator is disabled, the following error
is being logged for each unlink/truncate/ftruncate calls.
[...] E [trash.c:221:trash_local_wipe] (--> ...
... ) 0-trash: invalid argument: local
This change replaces GF_VALIDATE_OR_GOTO macro with simple
if condition.
Change-Id: I7e6754cd53ec7c2d84669b6d40d883a2d1eee41e
BUG: 1132465
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/9909
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 4415680fb9001fae29e38e1a4d3ab239bf965b64
Author: vmallika <vmallika@redhat.com>
Date: Tue Mar 17 20:05:19 2015 +0530
Quota/marker : Support for inode quota
Currently, the only way to retrieve the number of files/objects in a
directory or volume is to do a crawl of the entire directory/volume.
This is expensive and is not scalable.
The new mechanism proposes to store count of objects/files as part of
an extended attribute of a directory. Each directory's extended
attribute value will indicate the number of files/objects present
in a tree with the directory being considered as the root of the tree.
Currently file usage is accounted in marker by doing multiple FOPs
like setting and getting xattrs. Doing this with STACK WIND and
UNWIND can be harder to debug as involves multiple callbacks.
In this code we are replacing current mechanism with syncop approach
as syncop code is much simpler to follow and help us implement inode
quota in an organized way.
Change-Id: Ibf366fbe07037284e89a241ddaff7750fc8771b4
BUG: 1188636
Signed-off-by: vmallika <vmallika@redhat.com>
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/9567
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 3d45f7add04850aaebec3b812f5f826152d2c14d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Mar 17 12:02:32 2015 +0530
tests: Fix spurious failure in bug-866459.t
10.TEST kill_brick $V0 $H0 $B0/${V0}1
11.-EXPECT '1' echo `pgrep glusterfsd | wc -l
Problem:
On my Fedora 21 laptop, #11 always fails:"not ok 11 Got "2" instead of "1"
On debugging, I found that after killing, the kernel takes some time to
clean up the process until which it appears as defunct in the pgrep
output:
root 21795 2.0 0.0 0 0 ? Zsl 11:57 0:00 [glusterfsd] <defunct>
Fix:
As long as TEST kill_brick is successful, we really don't need to double
check with the pgrep output. Hence removing that line.
Change-Id: Ia10e0a04803e54a074f73da6523fa6a98c677d58
BUG: 1163543
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9904
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 42e19645b1517cfa7d461890be53c66408eaa3ca
Author: Soumya Koduri <skoduri@redhat.com>
Date: Mon Feb 16 11:47:58 2015 +0530
gfapi: APIs to store and process upcall notifications received
In case of any upcall cbk events received by the protocol/client,
gfapi will be notified which queues them up in a list (<gfapi_cbk_upcall>).
Applicatons are responsible to provide APIs to process & notify them in case
of any such upcall events queued.
Added a new API which will be used by Ganesha to repeatedly poll for any
such upcall event notified (<glfs_h_poll_upcall>).
A new test-file has been added to test the cache_invalidation upcall events.
Below link has a writeup which explains the code changes done -
URL: https://soumyakoduri.wordpress.com/2015/02/25/glusterfs-understanding-upcall-infrastructure-and-cache-invalidation-support/
Change-Id: Iafc6880000c865fd4da22d0cfc388ec135b5a1c5
BUG: 1200262
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/9536
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit b71c5e8c90c66c430d7b377835eedc48c00c6bc0
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Mar 17 09:27:05 2015 -0400
NFS-Ganesha: Install scripts, config files, and resource agent scripts
Resubmitting after a gerrit bug bungled the merge of
http://review.gluster.org/9621 (was it really a gerrit bug?)
Scripts related to NFS-Ganesha are in extras/ganesha/scripts.
Config files are in extras/ganesha/config.
Resource Agent files are in extras/ganesha/ocf
Files are copied to appropriate locations.
Change-Id: I137169f4d653ee2b7d6df14d41e2babd0ae8d10c
BUG: 1188184
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/9912
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit cf429c1954595556f1e23d68817227cbd84d59b2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Mar 5 11:29:25 2015 +0000
afr: remove stale index entries
Problem:
During pre-op phase, the index xlator
1. Creates the entry inside .glusterfs/indices/xattrop
2. Winds the xattrop fop to posix to mark dirty/pending changelogs.
If the brick crashes after 1, the xattrop entry becomes stale and never
gets removed by shd during subsequent crawls because there is nothing to
heal (changelogs are zero).
Though the stale entry does not get displayed in the output of 'heal
info' command, it nevertheless stays there forever unless a new write
transaction is performed on the file.
Fix:
During index self-heal if afr xattrs are found to be clean (indicated by
ret value of 2 on a call to afr_shd_selfheal(), send a dummy
post-op with all 0s for the xattr values, which makes the index xlator
to unlink the stale entry.
Change-Id: I02cb2bc937f2e3f3f3cb35d67b006664dc7ef919
BUG: 1190069
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9714
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 4ba8d4564e9981bf4384ebf926b2d9c6cdbd7b7c
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Mar 10 20:14:47 2015 -0400
every/where: add GF_FOP_IPC for inter-translator communication
Several features - e.g. encryption, erasure codes, or NSR - involve
multiple cooperating translators which sometimes need a "private" means
of communication amongst themselves. Historically we've used virtual or
synthetic xattrs, but that's not very elegant and clutters up the
getxattr/setxattr path which must also handle real xattr requests. This
new fop should address that.
The only argument is an int32_t "op" which should be recognized by the
target translator. It is recommended that translators using these
feature follow some convention regarding the ops that they define, to
avoid conflicts. Using a hash of the target translator's type string as
a base for a series of ops would probably be a good start. Any other
information can be passed in both directions using xdata.
The default behavior for this fop, as with any other, is to pass through
to FIRST_CHILD. That makes use of this fop "transparent" to other
translators that were written before it existed, but it also means that
it only really works with pass-through translators. If a routing
translator (such as DHT) or a fan-out translator (such as AFR) is
involved, the IPC might not reach its intended destination unless those
translators are modified to forward IPC fops along all paths.
If an IPC gets all the way to storage/posix it is considered an error,
much like an uncaught exception. We don't actually *do* anything in
that case, but we do log it send back an EOPNOTSUPP error. This makes
the "unrecognized opcode" condition distinguishable from the "no IPC
support" condition (which would yield an RPC error instead) so clients
can probe for the presence of a handler for their own favorite opcode
and either use that or use old-school xattrs depending on the result.
BUG: 1158628
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Change-Id: I84af1b17babe5b30ec03ecf027ae37d09b873968
Reviewed-on: http://review.gluster.org/8812
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cec96e4d0557712ae62d30d9abcbb4006ee3e5cb
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Feb 17 12:12:11 2015 +0100
socket: use TCP_USER_TIMEOUT to detect client failures quicker
Use the network.ping-timeout to set the TCP_USER_TIMEOUT socket option
(see 'man 7 tcp'). The option sets the transport.tcp-user-timeout option
that is handled in the rpc/socket layer on the protocol/server side.
This socket option makes detecting unclean disconnected clients more
reliable.
When the socket gets closed, any locks that the client held are been
released. This makes it possible to reduce the fail-over time for
applications that run on systems that became unreachable due to
a network partition or general system error client-side (kernel panic,
hang, ...).
It is not trivial to create a test-case for this at the moment. We need
a client that unclean disconnects and an other client that tries to take
over the lock from the disconnected client.
URL: http://supercolony.gluster.org/pipermail/gluster-devel/2014-May/040755.html
Change-Id: I5e5f540a49abfb5f398291f1818583a63a5f4bb4
BUG: 1129787
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8065
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Santosh Pradhan <santosh.pradhan@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit e08b77d2a53842baf5fd67bab60bcce3c5c70c2e
Author: Soumya Koduri <skoduri@redhat.com>
Date: Sun Feb 15 23:35:56 2015 +0530
Upcall: New xlator to store various states and send cbk events
Framework on the server-side, to handle certain state of the files
accessed and send notifications to the clients connected.
A generic and extensible framework, used to maintain states in
the glusterfsd process for each of the files accessed
(including the clients info doing the fops) and send
notifications to the respective glusterfs clients incase of
any change in that state.
This patch handles "Inode Update/Invalidation" upcall event.
Feature page:
URL: http://www.gluster.org/community/documentation/index.php/Features/Upcall-infrastructure
Below link has a writeup which explains the code changes done -
URL: https://soumyakoduri.wordpress.com/2015/02/25/glusterfs-understanding-upcall-infrastructure-and-cache-invalidation-support/
Change-Id: Ie3d724be9a3419fcf18901a753e8ec2df2ac802f
BUG: 1200262
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/9535
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a910658e4c3645a7590b4d1b2b0158d640b0e8d2
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Jan 6 18:20:45 2015 +0530
geo-rep: mountbroker user management
Non root geo-replication setup is now simplified. This
patch provides cli for mountbroker user and options management
To set Options,
gluster system:: execute mountbroker opt <KEY> <VALUE>
# for example,
gluster system:: execute mountbroker opt mountbroker-root /var/mountbroker-root
gluster system:: execute mountbroker opt geo-replication-log-group geogroup
gluster system:: execute mountbroker opt rpc-auth-allow-insecure on
To remove option,
gluster system:: execute mountbroker optdel <KEY>
# for example,
gluster system:: execute mountbroker optdel geo-replication-log-group
To add/edit user,
gluster system:: execute mountbroker user <USERNAME> <VOLUMES>
# for example
gluster system:: execute mountbroker user geoaccount slavevol1,slavevol2
To remove user,
gluster system:: execute mountbroker userdel <USERNAME>
# for example
gluster system:: execute mountbroker userdel geoaccount
For info,
gluster system:: execute mountbroker info
gluster system:: execute mountbroker -j info
For JSON output add -j after mountbroker, for example,
gluster system:: execute mountbroker -j user geoaccount slavevol1,slavevol2
PS: Each peer prints its own JSON output, aggregator required from consumer side
BUG: 1136312
Change-Id: Ie52210c0bcc91ac2ffd3ba58988222ffca62b47f
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9398
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: darshan n <dnarayan@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 61a730443ee6ce0f232efc502453a4b97e4b8279
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Mon Mar 9 19:12:03 2015 +0530
inode: 'this' has been set unwantedly.
Problem:
CC libglusterfs_la-inode.lo
inode.c: In function 'inode_table_destroy':
inode.c:1630:19: warning: variable 'this' set
but not used [-Wunused-but-set-variable]
xlator_t *this = NULL;
Change-Id: If4b37ab896ee0a309826d4be48c6599d6ec2710b
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9846
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
commit 4a02f75867509c77abbf8d1befd954da1761c973
Author: vmallika <vmallika@redhat.com>
Date: Mon Mar 16 15:38:16 2015 +0530
remove spurious failure test from bug-1087198.t
Consider below scenario in the quota xlator
T1 - write with delta1 bytes on fd1
check_limit sees that delta1 bytes is not exceeding soft limit
T2 - write with delta2 bytes on fd1
check_limit sees that delta2 bytes is not exceeding soft limit
T3 - delta1 and delta2 bytes are written to the disk.
Here delta1 and delta2 are checked separately and do not exceed
limit, but they together exceed the limit which is not checked.
We need to find a solution to solve this problem. Till then for
other regressions to pass, we remove the the test which checks for
soft limit crossed.
Change-Id: I8f76754e975c3315557a4c570db8bb5d9e56de15
BUG: 1202292
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9894
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fa626c649cab1ba3e19f7f97e5a41ff1946a35bf
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Mar 15 23:07:01 2015 +0100
tests: prevent regular hangs in ec/nfs.t
When the test systems gets into a memory pressure state (the Jenkins VMs
do not have much RAM), the localhost NFS-mount can get hung. It is
possible to prevent this by writing with O_DIRECT. Unfortnately, the
'dd' command on NetBSD does not seem to support such an option.
The alternative is to reduce the I/O that can get cached on the
NFS-client, like reducing the "count" option for "dd".
Change-Id: I1da9cb41133bb934bcbae0a6bc091f798514ed3d
BUG: 1163543
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9883
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit 9f8bf8ba2311496a57e64b912887cbf303aa1158
Author: Anoop C S <achiraya@redhat.com>
Date: Fri Feb 27 15:14:08 2015 +0530
Features/trash : Combined patches for trash translator
This is the combined patch set for supporting trash feature.
http://www.gluster.org/community/documentation/index.php/Features/Trash
Current patch includes the following features:
* volume set options for enabling trash globally and
exclusively for internal operations like self-heal
and re-balance
* volume set options for setting the eliminate
path, trash directory path and maximum trashable
file size.
* test script for checking the functionality of the
feature
* brief documentation on different aspects of trash
feature.
Change-Id: Ic7486982dcd6e295d1eba0f4d5ee6d33bf1b4cb3
BUG: 1132465
Signed-off-by: Anoop C S <achiraya@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/8312
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit edc7fe9014bf13a26116fd6c29d101dcafd62849
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Fri Mar 13 19:08:38 2015 +0530
gfapi: improve source comments and error messages.
Change-Id: I0bfa44eb5b5f21e381af3e71c26ea863e4adc46f
BUG:1202274
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9878
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 08aa6d46296c73f26fd1eb9c2a819aa786dccee8
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Mar 11 17:19:42 2015 +0530
libgfapi: initialize child_down_count cond. variable.
currently glfs_new_from_ctx() does not initialize child_down_count
conditional variable, but, glfs_free_from_ctx()
destroy this variable. mnt3udp_get_export_subdir_inode() from mount3
calls glfs_free_from_ctx(), so bound to invite problems. This patch
avoids the issue.
Change-Id: I8c1ed83f0b39248edbb78db25c9434274b538e80
BUG: 1200879
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9857
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit affbcaeca66e9e521b2fe9f4f1724e2710c085b9
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jan 8 19:24:59 2015 +0530
glusterd: Protect the peer list and peerinfos with RCU.
The peer list and the peerinfo objects are now protected using RCU.
Design patterns described in the Paul McKenney's RCU dissertation [1]
(sections 5 and 6) have been used to convert existing non-RCU protected
code to RCU protected code.
Currently, we are only targetting guaranteeing the existence of the
peerinfo objects, ie., we are only looking to protect deletes, not all
updaters. We chose this, as protecting all updates is a much more
complex task.
The steps used to accomplish this are,
1. Remove all long lived direct references to peerinfo objects (apart
from the peerinfo list). This includes references in glusterd_peerctx_t
(RPC), glusterd_friend_sm_event_t (friend state machine) and others.
This way no one has a reference to deleted peerinfo object.
2. Replace the direct references with indirect references, ie., use
peer uuid and peer hostname as indirect references to the peerinfo
object. Any reader or updater now uses the indirect references to get to
the actual peerinfo object, using glusterd_peerinfo_find. Cases where a
peerinfo cannot be found are handled gracefully.
3. The readers get and use the peerinfo object only within a RCU read
critical section. This prevents the object from being deleted/freed when
in actual use.
4. The deletion of a peerinfo object is done in a ordered manner
(glusterd_peerinfo_destroy). The object is first removed from the
peerinfo list using an atomic list remove, but the list head is not
reset to allow existing list readers to complete correctly. We wait for
readers to complete, before resetting the list head. This removes the
object from the list completely. After this no new readers can get a
reference to the object, and it can be freed.
This change was developed on the git branch at [2]. This commit is a
combination of the following commits on the development branch.
d7999b9 Protect the glusterd_conf_t->peers_list with RCU.
0da85c4 Synchronize before INITing peerinfo list head after removing
from list.
32ec28a Add missing rcu_read_unlock
8fed0b8 Correctly exit read critical section once peer is found.
63db857 Free peerctx only on rpc destruction
56eff26 Cleanup style issues
e5f38b0 Indirection for events and friend_sm
3c84ac4 In __glusterd_probe_cbk goto unlock only if peer already
exists
141d855 Address review comments on 9695/1
aaeefed Protection during peer updates
6eda33d Revert "Synchronize before INITing peerinfo list head after
removing from list."
f69db96 Remove unneeded line
b43d2ec Address review comments on 9695/4
7781921 Address review comments on 9695/5
eb6467b Add some missing semi-colons
328a47f Remove synchronize_rcu from
glusterd_friend_sm_transition_state
186e429 Run part of glusterd_friend_remove in critical section
55c0a2e Fix gluster (peer status/ pool list) with no peers
93f8dcf Use call_rcu to free peerinfo
c36178c Introduce composite struct, gd_rcu_head
[1]: http://www.rdrop.com/~paulmck/RCU/RCUdissertation.2004.07.14e1.pdf
[2]: https://github.com/kshlm/glusterfs/tree/urcu
Change-Id: Ic1480e59c86d41d25a6a3d159aa3e11fbb3cbc7b
BUG: 1191030
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/9695
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 975ea5e66cfbe71c5e70ddfbcc65489b8cc1030c
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Mar 11 13:31:09 2015 +0530
geo-rep: Do not use xsync_upper_limit for change detection
Use register time(xsync_upper_limit) only for stime update, do not
use for change detection.
Problem 1:
If a file created before geo-rep, xtime xattr does not exist.
Geo-rep updates xtime of the file to current time if not exists.
xtime > upper_limit so geo-rep will not pick those files. Changelog
either will have SETXATTR, and fails to sync the file.
Problem 2:
If a file is created before geo-rep create and updated after
geo-rep start. xtime of the file is greater than upper limit(geo-rep
start time/changelog register time). Geo-rep(XSync) will not pick this
file for syncing. Changelog will have only DATA recorded for that file.
Geo-rep tries DATA without any ENTRY ops and fails with rsync error.
BUG: 1200733
Change-Id: Ie4e8f284db689d2c755ef8e7ecbb658db1c0785f
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9855
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Tested-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d7f157ba9e430066168261867589a1cac6a76638
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Feb 23 14:46:48 2015 +0530
feature/geo-rep: Active Passive Switching logic flock
CURRENT DESIGN AND ITS LIMITATIONS:
-----------------------------------
Geo-replication syncs changes across geography using changelogs captured
by changelog translator. Changelog translator sits on server side just
above posix translator. Hence, in distributed replicated setup, both
replica pairs collect changelogs w.r.t their bricks. Geo-replication
syncs the changes using only one brick among the replica pair at a time,
calling it as "ACTIVE" and other non syncing brick as "PASSIVE".
Let's consider below example of distributed replicated setup where
NODE-1 as b1 and its replicated brick b1r is in NODE-2
NODE-1 NODE-2
b1 b1r
At the beginning, geo-replication chooses to sync changes from NODE-1:b1
and NODE-2:b1r will be "PASSIVE". The logic depends on virtual getxattr
'trusted.glusterfs.node-uuid' which always returns first up subvolume
i.e., NODE-1. When NODE-1 goes down, the above xattr returns NODE-2 and
that is made 'ACTIVE'. But when NODE-1 comes back again, the above xattr
returns NODE-1 and it is made 'ACTIVE' again. So for a brief interval of
time, if NODE-2 had not finished processing the changelog, both NODE-2
and NODE-1 will be ACTIVE causing rename race as mentioned in the bug.
SOLUTION:
---------
1. Have a shared replicated storage, a glusterfs management volume specific
to geo-replication.
2. Geo-rep creates a file per replica set on management volume.
3. fcntl lock on the above said file is used for synchronization
between geo-rep workers belonging to same replica set.
4. If management volume is not configured, geo-replication will back
to previous logic of using first up sub volume.
Each worker tries to lock the file on shared storage, who ever wins will
be ACTIVE. With this, we are able to solve the problem but there is an
issue when the shared replicated storage goes down (when all replicas
goes down). In that case, the lock state is lost. So AFR needs to rebuild the
lock state after brick comes up.
NOTE:
-----
This patch brings in the, pre-requisite step of setting up management volume
for geo-replication during creation.
1. Create mgmt-vol for geo-replicatoin and start it. Management volume should
be part of master cluster and recommended to be three way replicated
volume having each brick in different nodes for availability.
2. Create geo-rep session.
3. Configure mgmt-vol created with geo-replication session as follows.
gluster vol geo-rep <mastervol> slavenode::<slavevol> config meta_volume \
<meta-vol-name>
4. Start geo-rep session.
Backward Compatiability:
-----------------------
If management volume is not configured, it falls back to previous logic of
using node-uuid virtual xattr. But it is not recommended.
Change-Id: I7319d2289516f534b69edd00c9d0db5a3725661a
BUG: 1196632
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9759
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f3d09bc38ebb8eef30e23e9416d37fffa4b67d39
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Jan 29 15:53:19 2015 +0530
tools: Finds missing files in gluster volume given backend brickpath
The tool finds the missing files in a geo-replication slave volume.
The tool crawls backend .glusterfs of the brickpath, which is passed
as a parameter and stats each entry on slave volume mount to check
the presence of file. The mount used is aux-gfid-mount, hence no path
conversion is required and is fast. The tool needs to be run on every
node in cluster for each brickpath of geo-rep master volume to find
missing files on slave volume. The tool is generic enough and can be
used in non geo-replication context as well.
Most of the crawler code is leverged from Avati's xfind and is modified
to crawl only .glusterfs (https://github.com/avati/xsync)
Thanks Aravinda for scripts to convert gfid to path.
Change-Id: I84deaaaf638f7c571ff1319b67a3440fe27da810
BUG: 1187140
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9503
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 98b151d379a445fe58b35db719d84f3122f6828b
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Mar 4 18:38:07 2015 +0530
xlator: avoiding possibility of a crash if (xl->ctx) is NULL.
Change-Id: I41acd9970bef04bb16cd4d8532a84a95d5fb642a
BUG: 1199003
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>.
Reviewed-on: http://review.gluster.org/9810
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0e8c453c91551fd2c32b13e78b541c2a2d09ed20
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Mar 15 14:16:56 2015 +0100
nfs: improve cleanup of 'struct exports_file' to prevent memory leak
BUG: 1143880
Change-Id: I359470a1edb935e206eeeecd4de7022530fb397a
Reported-by: Vijay Bellur <vbellur@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9882
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 81942dcb822d75512441e09336e055d070e9c02c
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Mar 13 11:37:14 2015 +0530
rdma:changing list iteration to safe mode
Change-Id: I2299378f02a5577a8bf2874664ba79e92c3811b5
BUG: 1201621
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9872
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c481bc8880c993fe4c35342988846b1a1272e19c
Author: arao <arao@redhat.com>
Date: Thu Feb 12 10:12:35 2015 +0530
fuse: Fixing dereference after null check
CID: 1124496
The pointer is not checked against null and is dereferenced anyway,
which is now checked.
Change-Id: Ib810546445596671b3656f01a14bbad02cdc221c
BUG: 789278
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9640
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 16d59b301c7343ac85f6cac2986a827466f4a907
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Feb 3 13:17:19 2015 +0530
xlators/storage/bd : Unused value is removed.
CID:1128926
Change-Id: I5ad1229e225a36f995245a847db1a19609a18cd8
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9556
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 050cfec6ebf6bc9f509f8483655f8fb2f3f1e7ee
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Mar 11 23:00:09 2015 -0400
nfs: use free() for getline() allocated string in netgroups
'line' is allocated through getline() which uses malloc(). GF_FREE()
will fail to release the memory because it can not find the expected
mem-pool header. Instead of GF_FREE(), free() should be used for strings
that get allocated with getline().
Subsequent calls to getline() with a non-NULL pointer will get the size
of the allocation adjusted with realloc().
Change-Id: I612fbf17d7283174d541da6f34d26e4f44e83bfa
BUG: 1143880
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9860
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c44d0957d08c955081d773a7793b6c2c999a2430
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 1 13:15:45 2015 +0100
gNFS: Export / Netgroup authentication on Gluster NFS mount
* Parses linux style export file/netgroups file into a structure that
can be lookedup.
* This parser turns each line into a structure called an "export
directory". Each of these has a dictionary of hosts and netgroups
which can be looked up during the mount authentication process.
(See Change-Id Ic060aac and I7e6aa6bc)
* A string beginning withan '@' is treated as a netgroup and a string
beginning without an @ is a host.
(See Change-Id Ie04800d)
* This parser does not currently support all the options in the man page
('man exports'), but we can easily add them.
BUG: 1143880
URL: http://www.gluster.org/community/documentation/index.php/Features/Exports_Netgroups_Authentication
Change-Id: I181e8c1814d6ef3cae5b4d88353622734f0c0f0b
Original-author: Shreyas Siravara <shreyas.siravara@gmail.com>
CC: Richard Wareing <rwareing@fb.com>
CC: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8758
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8c202f4302e50578c2d58a3ed767cae31075d41e
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 1 13:15:45 2015 +0100
nfs: add auth-cache for the MOUNT protocol
Authentication cache for the new fine grained contol for the MOUNT
protocol. The extended authentication (see Change-Id Ic060aac) benefits
from caching the access/permission checks that are done when an
NFS-client mounts an export.
This auth-cache will be used by Change-Id I181e8c1.
BUG: 1143880
Change-Id: I1379116572c8a4d1bf0c7ca4f826e51a79d91444
Original-author: Shreyas Siravara <shreyas.siravara@gmail.com>
CC: Richard Wareing <rwareing@fb.com>
CC: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9363
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e286918f73b79004f733762b080cf9545598430b
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 1 13:15:45 2015 +0100
nfs: more fine grained authentication for the MOUNT protocol
The /etc/exports format for NFS-exports (see Change-Id I7e6aa6b) allows
a more fine grained control over the authentication. This change adds
the functions and structures that will be used in by Change-Id I181e8c1.
BUG: 1143880
Change-Id: Ic060aac7c52d91e08519b222ba46383c94665ce7
Original-author: Shreyas Siravara <shreyas.siravara@gmail.com>
CC: Richard Wareing <rwareing@fb.com>
CC: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9362
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e10a2f9d442f77de664028ab5832fd6c630f5351
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 1 13:15:45 2015 +0100
nfs: add support for separate 'exports' file
The Linux kernel NFS server uses /etc/exports to manage permissions for
the NFS-clients. Extending the Gluster/NFS server to support a similar
scheme is needed for many deployments in enterprise environments.
BUG: 1143880
Change-Id: I7e6aa6bc6aa1cd5f52458e023387ed38de9823d7
Original-author: Shreyas Siravara <shreyas.siravara@gmail.com>
CC: Richard Wareing <rwareing@fb.com>
CC: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9361
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ddde193c12f5b55ba2f6374528661320d8a253ce
Author: vmallika <vmallika@redhat.com>
Date: Wed Mar 11 18:03:47 2015 +0530
syncop: assign lk_owner for the newly created frame
syncop_inodelk doesn't work properly as lk_owner is not set
in the frame created by 'synctask_create'.
There is a possibility that more than one thread can acquire inode lock
with syncop_inodelk
Change-Id: I8193edb0d24b3a6e3a3f6a0c5d7ab5a1be8e7daf
BUG: 1188636
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9858
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0a3917bf1be6c2752102527572c231faac66f6cc
Author: darshan n <dnarayan@redhat.com>
Date: Wed Mar 4 19:18:10 2015 +0530
geo-rep-cli: added a new option "no-verify" to geo-rep create.
This patch adds a new option called as "no-verify" to geo-rep
create command. With no-verify option, following checks does
not take place before session creation:
* if ssh port 22 is open in slave
* has proper passwordless ssh login setup
* slave volume is created and is empty
* if slave has enough memory
This option is needed by ovirt-engine as the tasks done
by push-pem is taken care by ovirt-engine and also the
above checks are done. Thus creation of password-less
ssh can be avoided when geo-replication is managed
through ovirt.
Usage: volume geo-replication [<VOLNAME>] [<SLAVE-URL>]
{ create [[no-verify]|[push-pem]] [force]|
start [force]|stop [force]|pause [force]|
resume [force]|config|status [detail]|
delete } [options...]
Change-Id: I975265f27d6434be5409438257d09cd4190c9159
BUG: 1198615
Signed-off-by: darshan n <dnarayan@redhat.com>
Reviewed-on: http://review.gluster.org/9799
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 033bd21ef8182a93d4b0ea97160caa32058a7f6b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Mar 10 22:11:57 2015 +0530
cluster/afr: Convert quota size from n/w to host order before use
Change-Id: I3e4fe15716556441546fcd62b8ac2833869b21cf
BUG: 1200670
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9853
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 83cf143ffdcfa3d11a65126edbf921e3db334f58
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 1 13:15:45 2015 +0100
nfs: add structures and functions for parsing netgroups
Netgroups are often used by enterprises to group a set of systems. The
NFS /etc/exports file support the @netgroup notation, and Gluster/NFS
will get extended to support this notation as well. For this, it is
needed that Gluster/NFS learns to parse the netgroup format.
A change to glusterfsd (Change-Id I24c40d5) will add test cases where
the parsing is used for regression testing.
BUG: 1143880
Change-Id: Ie04800d4dc26f99df922c9fcc00845f53291cf4f
Original-author: Shreyas Siravara <shreyas.siravara@gmail.com>
CC: Richard Wareing <rwareing@fb.com>
CC: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9360
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3ab6d25d8dd18de1facd1db8b1f63e9640353efd
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Mar 10 19:27:50 2015 +0530
glusterd: create nfs volfile even when NFS is disabled on all volumes
This is required to determine if gluster-nfs daemon needs to be
restarted. With http://review.gluster.org/9835 gluster-nfs volfile
wouldn't be created if all volumes had nfs disabled before they were
started even once. With the existing code, we wouldn't be able to
determine if gluster-nfs needs to be restarted or reconfigured without
the gluster-nfs volfile. This fix is ensure that we generate the
gluster-nfs volfile even if it wouldn't be started, to honour the above
requirement.
Change-Id: I86c6707870d838b03dd4d14b91b984cb43c33006
BUG: 1199944
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9851
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c9265beff00341cf3d31720a95cdb7d735260fe6
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Feb 19 15:52:28 2015 +0530
rdma: Free resources related to iobuf in fini
If rdma transport is destroyed because of any reason,
then rdma.so will be unloaded. But we are not setting
iobuf registeration function to null. After this, if
an iobuf request is came, then we will try to call a
function which is not loaded.
Change-Id: I3293f9974e16d8e865131785ee697ea02be8cdfc
BUG: 1187456
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9697
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit eb5977aef2c6d49315945a479d2fb5b81c363d64
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Feb 26 16:01:51 2015 +0530
rdma:enhance logging when a connection error occur
Change-Id: I6146307949a3d852d3af5f8b273004ad6b27451b
BUG: 1196584
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9756
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0477b3ed70541b6e7cba1f96370cf1f3c8c064cc
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Mar 10 12:12:01 2015 +0530
libglusterfs: Replace pipe2 with pipe.
pipe2() doesn't works on Linux kernel version < 2.6.27 and
glibc < version 2.9. Hence replacing it with pipe(),
so that the build will not fail on Centos5.
Change-Id: If17aed0d51466cd7528cf8dde0edfa28b68139e5
BUG: 1200255
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9844
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 907a8d88fdf0d54b3045e4e9aa87bf98e724bfaa
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu May 1 08:23:52 2014 -0400
glusterfs.spec.in: minor/nit changes to sync with Fedora spec
sync with fedora spec
Change-Id: Iddc55fbf82e5c4690669aa5836dc109b3d3fe19a
BUG: 1091408
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/7632
commit 56510f7618e3e7de349af773be5e8f85bfcc05d6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Feb 3 05:30:50 2015 -0500
build: don't report (hide) systemtap config option
We don't actually support systemtap. We don't have any systemtap
enablement. The configure doesn't actually do anything to configure
systemtap support. It's confusing to show that systemtap is disabled,
someone might try to run --enable-systemtap, and then we'll show that
it's enabled, but it still doesn't actually do anything.
Hide it until such time as we actually have some real systemtap support
Change-Id: I8617121bee5bc724027e5f4d5eed00fd3c5a4ab2
BUG: 865734
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/9564
commit 63ba0c865fb0fc608a9c1a83dcaefc00436de4a8
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Feb 3 04:05:08 2015 -0500
doc: convert gfapi symbol version to markdown and move to doc
Change-Id: Iaa0dd288b24240660594023e04a7fd84e7e62a5e
BUG: 1188557
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/9561
commit 79ebe4d45141cec442f17953c386f9ccef4c55d1
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Mar 4 16:22:39 2015 +0100
build: add more generated files to .gitignore
Added *_unittest, *.log, *.trs, extras/run-gluster.tmpfiles and
heal/src/glfsheal. Sorted the list of files to make it easier to modify
in future.
Change-Id: I0f21a03a89e61f84c6a85c8f1f98712c5819d633
BUG: 1198849
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9803
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit fed85f800e8ce952bbd81131732878e739b9a5bf
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Mar 9 18:39:07 2015 -0400
tests: add a helper script to identify line-numbers and commands of test-cases
Use the tests/utils/testn.sh after a regression test failed to identify
what command/line number belongs to the test-number.
Jenkins will have something like this in the console output:
Test Summary Report
-------------------
./tests/bugs/quota/bug-1087198.t
Failed test: 18
Call the script like:
$ ./tests/utils/testn.sh ./tests/bugs/quota/bug-1087198.t 18
56 TEST grep -e "\"Usage crossed....
BUG: 1200174
Change-Id: I661c1178d7f5bc50fd40679232c65734c2bc5477
Original-author: Pranith Kumar K <pkarampu@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9842
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 2b25a3e4cf0ab9f26904ba8eb954607dc73dab06
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Mar 6 15:16:35 2015 +0530
Performance: Replace ASSERTS in xlator fini() with info messages, for the known leaks.
There are few known leaks in read-ahead and quick-read xlator fini().
Until they are fixed replacing the ASSERTS with info, else any call
to glfs_fini() in debug mode will core dump.
Change-Id: Id60c6f952574863fc77c7d101cb5d5e9113090d8
BUG: 1199436
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9819
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 524153f3b906721892fbcbe8a4b40f2ce12eb65e
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Feb 5 16:12:53 2015 +0530
snapshot: append timestamp with snapname
Appending GMT time stamp with snapname by default.
If no-timestamp flag is given during snapshot creation,
then time stamp will not append with snapname;
Initial consumer of this feature is Samba's Shadow Copy
feature. This feature allows Windows user to get previous
revisions of a file. For this feature to work snapshot
names under .snaps folder (USS) should have timestamp in
following format appended:
@GMT-YYYY.MM.DD-hh.mm.ss
PS: https://www.samba.org/samba/docs/man/manpages/vfs_shadow_copy2.8.html
This format is configurable by Samba conf file. Due to a
limitation in Windows directory access the exact format
cannot be used by USS. Therefore we have modified the file
format to:
_GMT-YYYY.MM.DD-hh.mm.ss
Snapshot scheduling feature also required to append timestamp
to the snapshot name therefore timestamp is appended in
snapshot creation itself instead of doing the changes in
snapview server.
More info:
https://www.mail-archive.com/gluster-users@gluster.org/msg18895.html
Change-Id: Idac24670948cf4c0fbe916ea6690e49cbc832d07
BUG: 1189473
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9597
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 3d1dcba296dd837cdf5249b308f30e89d715d836
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Feb 27 16:04:29 2015 +0530
mgmt/glusterd: Changes required for disperse volume heal commands
- Include xattrop64-watchlist for index xlator for disperse volumes.
- Change the functions that exist to consider disperse volumes also
for sending commands to disperse xls in self-heal-daemon.
Change-Id: Iae75a5d3dd5642454a2ebf5840feba35780d8adb
BUG: 1177601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9793
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 706de09eddb4d88520ee328e4898bdafe3e96331
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Mon Mar 9 18:13:39 2015 +0530
rdma: return proper data type.
Change-Id: I9bb0898af96cfcfaba0f0c976a7808bc6ea08e6a
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9838
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit a3a010b16a7eb631a74fae5496b7f048cf95e99b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Feb 27 16:01:31 2015 +0530
cluster/ec: Add self-heal-daemon command handlers
This patch introduces the changes required in ec xlator to handle
index/full heal.
Index healer threads:
Ec xlator start an index healer thread per local brick. This thread keeps
waking up every minute to check if there are any files to be healed based on
the indices kept in index directory. Whenever child_up event comes, then also
this index healer thread wakes up and crawls the indices and triggers heal.
When self-heal-daemon is disabled on this particular volume then the healer
thread keeps waiting until it is enabled again to perform heals.
Full healer threads:
Ec xlator starts a full healer thread for the local subvolume provided by
glusterd to perform full crawl on the directory hierarchy to perform heals.
Once the crawl completes the thread exits if no more full heals are issued.
Changed xl-op prefix GF_AFR_OP to GF_SHD_OP to make it more generic.
Change-Id: Idf9b2735d779a6253717be064173dfde6f8f824b
BUG: 1177601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9787
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit add29e84d85a47a2fa239d7e41a55aab549f3895
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Feb 10 19:13:35 2015 +0100
posix: add ACL translation for the GF_POSIX_ACL_*_KEY xattr
Adding support for two virtual extended attributes that are used for
converting a binary POSIX ACL to a POSIX.1e long ACL text format. This
makes it possible to transfer the ACL over the network to a different OS
which can convert the POSIX.1e text format to its native structures.
The following xattrs are sent over RPC in SETXATTR/GETXATTR procedures,
and contain the POSIX.1e long ACL text format:
- glusterfs.posix.acl: maps to ACL_TYPE_ACCESS
- glusterfs.posix.default_acl: maps to ACL_TYPE_DEFAULT
acl_from_text() (from libacl) converts the text format into an acl_t
structure. This structure is then used by acl_set_file() to set the ACL
in the filesystem.
libacl-devel is needed for linking against libacl, so it has been added
to the BuildRequires in the .spec.
NetBSD does not support POSIX ACLs. Trying to get/set POSIX ACLs on a
storage server running NetBSD, an error will be returned with errno set
to ENOTSUP. Faking support, but not enforcing ACLs seems wrong to me.
URL: http://www.gluster.org/community/documentation/index.php/Features/Improved_POSIX_ACLs
BUG: 1185654
Change-Id: Ic5eb73d69190d3492df2f711d0436775eeea7de3
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9627
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 9eacd8642ac731d82137dc96af93eaff735af412
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Mar 9 10:29:29 2015 +0100
Tests: fix spurious failure in sparse-file-self-heal.t
On NetBSD sparse-file-self-heal.t often fails because $HEAL_TIMEOUT
is too short. Raising to 80s works around the problem, as discovered
by Anuradha Talur
BUG: 1129939
Change-Id: Ia950ff70ace24771ab1ef7fce51861f2417f86ab
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9833
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit aea5ae5483f5865efc9c6b64005dbc3ee6343915
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Mar 9 15:53:53 2015 +0530
glusterd: don't start gluster-nfs when NFS is disabled
Change-Id: Ic4da2a467a95af7108ed67954f44341131b41c7b
BUG: 1199944
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9835
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ef509a86c24042d12e8525fef85e8332ba23377f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 9 19:35:14 2015 +0530
Fix dictionary leaks in ancestry-building code.
Change-Id: I7a4a24ed95f897d1c14d89f3869c20ba40f85b7f
BUG: 1188636
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9839
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3e07b2dd214a56d70e0fed4580ec8fc2e04dbb1b
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Mon Mar 9 12:07:57 2015 +0530
core : using gluster-like memory allocation for parse-utility feature
Change-Id: I58dc7e0dc8d4ac4e10795e0536fcd0e1722116ed
BUG: 1143880
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/9830
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0d2fcbb3dec56d52b8a851da756a72595f345074
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Mar 7 06:10:41 2015 +0100
glfsheal: Avoid infinite loop on exit
Make sure we do not get stuck looping forever in event_dispatch_destroy()
by limiting the retries when waiting for other threads, and by giving up
when writing to other thread fails.
This fixes regression tests hanging forever on NetBSD.
BUG: 1129939
Change-Id: I4459cfb1ab7294e8c15a21b592e0154c22abae07
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9825
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 87a8f2a12f6e1bf2ff1f08aed286e7d40d9eb6af
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Mar 5 17:28:08 2015 +0530
rdma: 'list','wr' and 'new' memory has to be verified.
Change-Id: I29a8825107b8f4cefe4f4c59296e98fe675ee943
BUG: 1199053
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9811
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit d8a05d705fec9cb76a1fbf3be978836c830c2d46
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Mar 6 12:37:15 2015 +0530
libxlator: Make sure marker_xattr is valid
Problem:
marker_xattr is allocated only when the op_ret is 0. If the final response is
a failure, then the marker time is dict_set with key as NULL. this will be
changed to ref:<address-of-value> by dict_set, so the value won't appear on the
marker-key when the getxattr_cbk is in dht. So dht unwinds with failure EINVAL.
Fix:
Always populate marker_xattr. Fixed dict mem-leak as well.
Change-Id: I1752f277a8852c47b0a2ccce9fd72ee88456ac02
BUG: 1199406
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9817
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 684eccabd88cb1b4efecbc8c8ff50c6358ba0137
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Mar 6 14:36:52 2015 +0530
cluster/afr: Handle getxattr of quota-size key
Afr needs to query QUOTA_SIZE_KEY from all the subvolumes and return the
value which is maximum of the readable bricks.
Change-Id: Ibb9064c8652aea0d984796e7a06f8adca72aa971
BUG: 1199431
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9820
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 1e8b47371bd18420a765c5f6b6f69209b37f6d41
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Jan 31 00:32:05 2015 +0530
mgmt/glusterd: Add bind-insecure option
Also deleted default values for disperse-self-heal-daemon and locks.trace
Change-Id: Icc927d176aa10f06b40c114aa296b02dbad3a8ff
BUG: 1187858
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9516
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit c682e39e03f63446c50e7348ed357333ce9f5983
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Feb 27 23:47:26 2015 +0100
nfs: prevent logging missing 'system.posix_acl_access' xattrs
Change http://review.gluster.org/9773 addresses the majority of the
logging, but it seems it is still possible to trigger the excessive
logging by requesting the ACL on files directly. Lets squash those too.
BUG: 1197253
Change-Id: I9e90ddd45f1a39641478f34c69c64dfe1c11c727
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9781
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
commit f4f2c198f2c4e3502b1b710c95d1dd799179da89
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue Feb 24 16:48:20 2015 +0530
gfapi: Add NULL check for volname in glfs_new()
BUG: 1199388
Change-Id: I66cb65355504eb47e4392576029a9a5422996a1b
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/9735
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 83bb1d29e0c5d1628eb60646152b857a631bec6e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jun 13 11:45:53 2014 +0530
Use common loc-touchup in fuse/server/gfapi
Change-Id: Id41fb29480bb6d22c34469339163da05b98c1a98
BUG: 1115907
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8226
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6aa719b8c195488dfa3d591d0b4a04f22e6cf523
Author: Nico Schottelius <nico@freiheit.schottelius.org>
Date: Fri Mar 6 16:25:33 2015 +0100
Replace /dev/stderr with >&2 in mount scripts
/dev/stderr is not available on boot in CentOS 7 and thus
mounting anything from /etc/fstab at boot time fails.
Instead of using /dev/stderr, the standard error redirection ">&2" is being used.
Change-Id: I15d07cd49e6b0392331047edb441925f48047b2b
BUG: 1199545
Signed-off-by: Nico Schottelius <nico@freiheit.schottelius.org>
Reviewed-on: http://review.gluster.org/9824
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 60bdc1df2d3cdffddaa61c9aa6825803bc6c9657
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Mar 6 10:59:01 2015 +0530
protocol: Fix typos in option description
Change-Id: I7cf559fa5ffe3f6c437169820a86a7ee2f58b478
BUG: 1199382
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9816
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 30c04b02c862f062f28c2e972243288ac836a778
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Feb 24 16:36:05 2015 +0530
cluster/dht: create request dictionary if necessary during refresh layout.
Change-Id: I5a5d793c86ee5de345608eede5618e4e6c02af9f
BUG: 1195668
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/9733
commit e979ac2c76ddabb016716a4e62731868315c1ec8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Feb 2 18:49:01 2015 +0530
cluster/afr: Implementation of quorum-reads
Provide a way of disabling reads when quorum is not met.
Change-Id: Ic4f57c2b87a0b8514600759de3a7a47e217fe3b5
BUG: 1187885
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9543
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 755880174d99f0ab385a6c1904a355fabed05763
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 2 08:09:41 2015 +0530
cluster/ec: Allow heal on name less loc
loc->parent may not always be populated. Even in those cases,
self-heal should happen if it can be completed using nameless loc.
Change-Id: I8871fc811bec8b881ae7fb09dcd202c6693b9877
BUG: 1177601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9717
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 98fb8fafc4670906a9cb4af2d37dfd1a401aa05f
Author: Aravinda VK <avishwan@redhat.com>
Date: Sun Mar 1 11:48:12 2015 +0530
geo-rep: Avoid duplicate entries in authorized_keys file
When Georep create(force) command is run multiple times
it appends master nodes public keys to Slave nodes without
checking the existence of the key.
With this patch, create push-pem force adds pub key only if
not available in authorized_keys.
BUG: 1197433
Change-Id: Iad57f6c45698e258ad1a547fa7a2e376a315f0cd
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9776
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3ca734ef6652ec6726b50025e234d7f59b04b6e0
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Mar 3 17:22:30 2015 +0530
geo-rep: Handle ENOENT during cleanup
shutil.rmtree was failing to remove file if file was not
exists. Added error handling function to ignore ENOENT if
a file/dir not present.
BUG: 1198101
Change-Id: I1796db2642f81d9e2b5e52c6be34b4ad6f1c9786
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9792
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
commit 1dab89b638e14b8caa466ddb51d1dcb95f81fb6c
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Feb 18 14:47:01 2015 +0100
testing: Switch to cmocka the successor of cmockery2
This uses https://cmocka.org/ as the unit testing framework.
With this change, unit testing is made optional as well. We assume there
is no cmocka available while building. cmocka will be enabled by default
later on. For now, to build with cmocka run:
$ ./configure --enable-cmocka
This change is based on the work of Andreas (replacing cmockery2 with
cmocka) and Kaleb (make cmockery2 an optional build dependency).
The only modifications I made, are additional #defines in unittest.h for
making sure the unit tests function as expected.
Change-Id: Iea4cbcdaf09996b49ffcf3680c76731459cb197e
BUG: 1067059
Merged-change: http://review.gluster.org/9762/
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Change-Id: Ia2e955481c102d5dce17695a9205395a6030e985
Reviewed-on: http://review.gluster.org/9738
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 216da256b1dc5871783d8c9f8f3ae232166abf49
Author: Michael Scherer <misc@zarb.org>
Date: Mon Mar 2 16:24:05 2015 +0100
build: adjust checkpatch for HEAD.
README is called README.md in git HEAD, and we have a directory
heal.
Change-Id: I2e698b95c6924b5b21aa54257fefd6a6698255ee
BUG: 1198849
Signed-off-by: Michael Scherer <misc@zarb.org>
Reviewed-on: http://review.gluster.org/9784
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 60ace88c7c6a93ecba5558dd285652b733c80de7
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Tue Feb 3 15:21:51 2015 +0530
xlators/dht : divide by zero coverity fix
CID:1226163. BUG: 789278
Change-Id: Ie31d65da236d7029784defad963672b2ded2676a
BUG:1192435
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9563
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 07b1a98fe9bda557dee6338ed026ed0bbbe704ae
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Mar 5 14:23:38 2015 +0530
cluster/dht: fixes to should_layout_fix logic
* Don't consider "dir-spread-count" option. This option is not
supported.
* Consider transition to weighted to equal distribution or vice-versa
a valid case for fixing the layout.
Change-Id: I0dcfe555dae9269ce20a41611cfdaa4f96c9e98b
BUG: 1196615
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/9809
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7db127895b88af0e6726ac8a710ec4ee18f626b1
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Mar 4 14:37:05 2015 +0530
rdma:setting wrong remote memory.
when we send more than one work request in a single call,
the remote addr is always setting as the first address of
the vector.
Change-Id: I55aea7bd6542abe22916719a139f7c8f73334d26
BUG: 1197548
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9794
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit e89b7654a7cfb844d66789d82e9ebcd412d26daf
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Feb 19 19:35:17 2015 +0530
cluster/afr: Do not increment healed_count if no healing was performed
PROBLEM:
When file modifications are happening while index heal is launched,
index healer could pick up entries which appeared in indices/xattrop
transiently during the course of the operations on the mount point, and
do not really need any heal. This will cause index healer to keep doing
index-heal in a loop as long as it finds this entry, by believing that
it did successfully heal some gfids even when it didn't.
FIX:
afr_selfheal() now returns a 1 to indicate that it did not (need to)
heal a given gfid. afr_shd_selfheal() will not increment healed_count
whenever afr_selfheal() returns a 1.
Change-Id: I0d97e11392a032a852e8c6508f691300ef0e5b98
BUG: 1194305
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9713
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e4c8afa05adc167f8224e1b00c22176db6faa190
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Feb 19 04:09:26 2015 +0530
libglusterfs: Change iobuf_pool_destroy to destroy all the arenas.
Change-Id: If5e9d4ce98f845d3b52565ac62970959e663497f
BUG: 1093594
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9699
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 9c5d80c4af4a94f313c7da51891b9417770a33e8
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Wed Mar 4 19:16:20 2015 +0530
tests: Spurious failure in bug-1117851.t
This test runs file renames in a loop in the background and
writes to a status file to indicate that it is done.
However, the status file was also created in the background
and was sometimes not created in time before the test which
checked the contents.
Change-Id: Ida29456fbdc006f1da84a5f25a629cc6fa9830f4
BUG: 1163543
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/9798
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit d69d3fa3a5c55f6c53cd29dab9464c85d2dad0ea
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Feb 19 21:29:02 2015 +0530
glfs_fini: Clean up all the resources allocated in glfs_new.
Initially even after calling glfs_fini(), all the threads created
during init and many other resources like memory pool, iobuf pool,
event pool and other memory allocs were not being freed.
With this patch these resources are freed in glfs_fini().
The two thumb rules followed in this patch are:
- The threads are not killed, they are made to exit voluntarily,
once the queued tasks are completed. The main thread waits for
the other threads to exit.
- Free the memory pools and destroy the graphs only after all the
other threads are stopped, so that there are less chances of
hitting access after free.
Resources freed and its order:
1. Destroy the inode table of all the graphs - Call forget on all the inodes.
This will not be required when the cleanup during graph switch is
implemented to perform inode table destroy.
2. Deactivate the current graph, call fini of all the xlators.
3. Syncenv destroy - Join the synctask threads and cleanup syncenv resources
Sets the destroy mode, complete the existing synctasks, then join the
synctask threads.
After entering the destroy mode,
-if a new synctask is submitted, it fails.
-if syncenv_new() is called, it will end up creating new threads,
but this is called only during init.
4. Poller thread destroy
Register an event handler which sets the destroy mode for the poller.
Once the poller is done processing all the events, it exits.
5. Tear down the logging framework
The log file is closed and the log level is set to none, after this
point no log messages appear either in log file or in stderr.
6. Destroy the timer thread
Set the destroy bit, once the pending timer events are processed
the timer thread exits.
Note: Log infrastructure should be shutdown before destroying the timer
thread as gf_log uses timers.
7. Destroy the glusterfs_ctx_t
For all the graphs(active and passive), free graph, xlator structs and few other lists.
Free the memory pools - iobuf pool, event pool, dict, logbuf pool,
stub mem pool, stack mem pool, frame mem pool.
Few things not addressed in this patch:
1. rpc_transport object not destroyed, the PARENT_DOWN should have
destroyed this object but has not, needs to be addressed as a part
of different patch
2. Each xlator fini should clean up the local pool allocated by its xlator.
Needs to be addresses as a part of different patch.
3. Each xlator should implement forget to free its inode_ctx.
Needs to be addresses as a part of different patch.
3. Few other leaks reported by valgrind.
4. fd and fd contexts
The numbers:
The resource usage by the test case in this patch:
Without the fix, Memory: ~3GB; Threads: ~81
With this fix, Memory: 300MB; Threads: 1(main thread)
Change-Id: I96b9277541737aa8372b4e6c9eed380cb871e7c2
BUG: 1093594
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/7642
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 2cfff12547fe22ed3118e8b47958619dd45f1100
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Mar 3 17:21:54 2015 +0530
glusterd: Start quotad before spawning bricks during glusterd restart
Change-Id: I66edc1b98b70a494e069df95a6f347634c8f862d
BUG: 1198076
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/9791
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c744d2dc5477bb7c5c2195b42a5c47bb855de446
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Dec 14 21:33:17 2014 +0100
changelog: Unchecked buffer fill in gf_history_changelog_next_change
A gf_history_changelog_next_change() calls gf_readline() to fill a
buffer without checking buffer size. The size of maxlen is not verified
to be less than the lenght of buffer. This could result in the over
filling of buffer of maxlen is greater than PATH_MAX.
Check the size of maxlen to be less than PATH_MAX and return a fail code
as needed.
BUG: 1174017
Change-Id: Ic53b1a6e25af69a339bc15fb2d233dc1e457910f
Reported-by: Keith Schincke <kschinck@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9275
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 96bfa2707961db106ce2a70d00f2b932a2e52a96
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Fri Sep 26 17:57:58 2014 +0530
doc: Update glusterfs introduction doc.
Change-Id: I4e9520bf46b7b9611c3719623a940b16b4cadda0
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8870
Reviewed-by: Justin Clift <justin@gluster.org>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit ebd88f9a2a68f66c4b70e8d3caf50825e6b5b0a4
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jan 6 18:23:41 2015 +0530
glusterd: Replace libglusterfs lists with liburcu lists
This patch replaces usage of the libglusterfs lists data structures and
API in glusterd with the lists data structures and API from liburcu. The
liburcu data structes and APIs are a drop-in replacement for
libglusterfs lists.
All usages have been changed to keep the code consistent, and free from
confusion.
NOTE: glusterd_conf_t->xprt_list still uses the libglusterfs data
structures and API, as it holds rpc_transport_t objects, which is not a
part of glusterd and is not being changed in this patch.
This change was developed on the git branch at [1]. This commit is a
combination of the following commits on the development branch.
6dac576 Replace libglusterfs lists with liburcu lists
a51b5ab Fix compilation issues
d98a06f Fix merge issues
a5d918e Remove merge remnant
1cca113 More style cleanup
1917be3 Address review comments on 9624/1
8d10f13 Use cds_lists for glusterd_svc_t
524ad5d Add rculist header in glusterd-conn-helper.c
646f294 glusterd: add list_add_order API honouring rcu
[1]: https://github.com/kshlm/glusterfs/tree/urcu
Change-Id: Ic613c5b6e496a677b9d3de15fc042a0492109fb0
BUG: 1191030
Signed-off-by: Kaushal M <kaushal@redhat.com>
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9624
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
commit 2997547f54589f42312f7ef04997f2389c34c79c
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Feb 26 22:50:25 2015 +0530
cluster/dht: Fixes to should_fix_layout logic
* With recent introduction of locking in self-heal codepath,
fix layout was not allowed to progress during remove-brick.
This patch fixes the issue.
* dht_should_fix_layout also considers "dir-spread-count" option if
set, to determine whether we should proceed with fix-layout or not.
Change-Id: Icd96986f7af705744131d62e7f1456114ac1ee53
BUG: 1196615
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/9764
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit 22dd903fc45d421e569962a6ba34bcc9c215d3eb
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 1 13:15:45 2015 +0100
core: add generic parser utility
This generic parser will get used for parsing the netgroups and exports
files for the Gluster/NFS server. The parsing of netgroups shows how the
parser can be used (see Change-Id Ie04800d4).
BUG: 1143880
Change-Id: Id4cf2b0189ef5799c06868d211d3fcd9c8608c08
Original-author: Shreyas Siravara <shreyas.siravara@gmail.com>
CC: Richard Wareing <rwareing@fb.com>
CC: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9359
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 34fcc5abe228057e282183f5ff5d87c0041b9f0c
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Feb 18 21:40:46 2015 +0530
event_pool: Add the code to destroy the poller threads and event pool gracefully.
Change-Id: I49b6ceebb45773620c318fb5d20b81623db75ab6
BUG: 1093594
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9691
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit d87dc5d72041bb94932bfb9ea37cf994bbd3ef29
Author: Manikandan Selvaganesh <mselvaga@redhat.com>
Date: Thu Feb 5 10:59:48 2015 +0530
dht : logically dead code removed
CID :1124378
1124401
Change-Id: Ib48e4a8d3fb12c4e0323a3946afb46eeb3926984
BUG: 789278
Signed-off-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Reviewed-on: http://review.gluster.org/9584
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit f4dbdfc1b2c71631a74c2ed53e61506e6777836f
Author: vmallika <vmallika@redhat.com>
Date: Mon Mar 2 12:52:22 2015 +0530
quota: quotad.socket files should be created under /var/run/gluster
Change-Id: I49502a4f7516c02f7e321c16eebd748545afde07
BUG: 1197587
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9778
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6dd0d684b8fc70209df49805b354c28a2a0e9785
Author: Michael Scherer <misc@zarb.org>
Date: Mon Mar 2 16:13:40 2015 +0100
tests: prevent deleting /etc/passwd
This happened twice last week on our gluster jenkins slave,
http://www.gluster.org/pipermail/gluster-infra/2015-March/000818.html
Change-Id: I40ff0e143256fb1b33ee4ab6dd0850727f9e2135
BUG: 1163543
Signed-off-by: Michael Scherer <misc@zarb.org>
Reviewed-on: http://review.gluster.org/9785
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit af6eac70b25cdabb23a7720ac1fbd4da8019391b
Author: Mark Lipscombe <mlipscombe@gmail.com>
Date: Fri Feb 27 15:36:48 2015 -0800
rdma: segfault trying to call ibv_dealloc_pd on a null pointer if ibv_alloc_pd failed
If creating an ib protection domain fails, during the cleanup
a segfault will occur because trav->pd is null.
Bug: 1197260
Change-Id: I21b867c204c4049496b1bf11ec47e4139610266a
Signed-off-by: Mark Lipscombe <mlipscombe@gmail.com>
Reviewed-on: http://review.gluster.org/9774
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit c8ff45c731d7eca50a1cc2fa8e4b97dd9e4e147b
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Feb 25 17:10:12 2015 +0530
afr: catch proper result of glfs_set_volfile_server
Change-Id: I5a1db7b88c33bf5faa7a8848502357b052a799f4
BUG: 1194640
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9746
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit fc284f96473d81549254da907eebc050c1a3e6c8
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Feb 19 03:45:34 2015 +0530
libglusterfs: Add functions for xlator and graph cleanup.
Change-Id: If341e3c0a559aa5bbca9c1263a241c6592c59706
BUG: 1093594
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9696
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7b9ae6406fcf7f256b60439393d24bdcd55fd615
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Feb 19 05:29:02 2015 +0530
libglusterfs: Add timer thread destroy code.
Change-Id: Iafbbbfd9319751742b3c79419e1dd8e2958fee07
BUG: 1093594
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9701
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b9339e4d0fa8d5d0b223af8fb615ea830a1a6b08
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Feb 19 01:24:29 2015 +0530
syncop: Add the code to destroy the synenv processors and syncenv structures
Change-Id: I28020eb2fc08d886cd7c05ff96daf7ebb4264ffe
BUG: 1093594
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9693
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5a09d681cd20bd5d5af809d89335ded21d324281
Author: Poornima G <pgurusid@redhat.com>
Date: Thu Feb 19 04:49:35 2015 +0530
libglusterfs: Add inode table cleanup APIs.
Took the inode context free code from the patch
http://review.gluster.org/#/c/4775/18/libglusterfs/src/inode.c
Change-Id: I05fc025763fe4ce61dc61503de27ec1d3a203e50
BUG: 1093594
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9700
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9db011869a499e2af02cdfffc68e788ed9679940
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Fri Feb 20 18:01:50 2015 +0530
logging: Adding msg id segment for common errors.
By this reservation, we are assigning some space for common errors
like dict_{get,set},memory accounting..etc.
Change-Id: Iee0f65b3dc4e00819f344bed01989352a4f8a87b
BUG: 1194640.
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9752
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 3967c5279deafc83b40c44146a58d156d00b1a5c
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jan 28 17:19:42 2015 +0530
geo-rep: Add support for xattrs
This patch adds support for xattrs. When it sees SETXATTR
in Changelog, it adds the file to data queue. rsync/tar+ssh
will take care of syncing xattrs. User set xattrs will be
synced to Slave.
New config interface is introduced, sync-xattrs
Which can be set using geo-rep config(Default is True)
gluster volume geo-replication <VOLUME> <SLAVEHOST>::<SLAVEVOL> \
config sync-xattrs false
Change-Id: I70626d854a0d616469dd54d61e5ef155ed8b67d8
BUG: 1196690
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9499
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6a52d0471f0ba974663a7bb638114a90a0cd60c5
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Dec 17 21:43:57 2014 +0530
geo-rep: Unit tests infrastructure for geo-replication
Added sample unit test file,
$GLUSTER_SRC/geo-replication/tests/unit/test_syncdutils.py
Install unittest dependencies, (tox https://tox.readthedocs.org/en/latest/,
nose https://nose.readthedocs.org/en/latest/)
sudo pip install --upgrade tox nose
To run pep8 coding standards tests,
cd $GLUSTER_SRC/geo-replication
tox -e pep8
To run unit tests,
cd $GLUSTER_SRC/geo-replication
tox -e py27
py27 is for with Python 2.7+, or py26 for systems
with Python 2.6+
Change-Id: Ibdefe2c9d73afda9a7fa1c0db5b126f592b7cb40
BUG: 1177722
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9290
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b9aee7fbcada947584c566680542d1e822c2db64
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Feb 18 15:16:17 2015 +0530
protocol/client: defer cleanup of private until RPC notifications are handled.
This fix is required for glfs_fini to be able to perform fini on client
xlators in a graph. We are deferring freeing of client xlator's private
until all RPC related resources are destroyed. This guarantees that
client xlator would free RPC related resources provided its private
structures are still accessible via its this pointer.
'Weak' property: If there are no epoll threads executing after calling
fini() on a client xlator, then all its RPC related resources are
guaranteed to be freed. We can now free the corresponding 'this'
pointer.
Change-Id: Ie00b14dda096ac128e1c37e0032f07d17fd701ce
BUG: 1093594
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9680
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9d3632439add153c9841a8d038004f98df355144
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Feb 23 16:10:33 2015 +0530
epoll: Fix a leak in slot allocation.
When the slots_used in a table becomes 0, the table will not
get reused, leading to a leak.
This patch fixes the leak.
Change-Id: Ib86826d287368174ea7ebe0d0d64b2dec574634e
BUG: 1093594
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9725
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 364efa965e49d1c0160493f3d7b8720721373e56
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Feb 27 23:47:26 2015 +0100
nfs: prevent logging missing 'system.posix_acl_*' xattrs
The nfs.log gets spammed with messages that the system.posix_acl_access
and system.posix_acl_default xattrs are not set. The logging happens
because the dictionary that contains the xattrs is empty/NULL in case
the getxattr() did not return any contents for the ACLs.
Change-Id: Id31e30635146599915c6d8674a2dde065f348adc
BUG: 1197253
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9773
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
commit c223aee555b5092f923db54755811c786f7df30c
Author: Shyam <srangana@redhat.com>
Date: Mon Feb 23 10:00:39 2015 -0500
epoll: Fix broken RPC throttling due to MT epoll
The RPC throttle which kicks in by setting the poll-in event on a
socket to false, is broken with the MT epoll commit. This is due
to the event handler of poll-in attempting to read as much out of
the socket till it receives an EAGAIN. Which may never happen and
hence we would be processing far more RPCs that we want to.
This is being fixed by changing the epoll from ET to LT, and
reading request by request, so that we honor the throttle.
The downside is that we do not drain the socket, but go back to
epoll_wait before reading the next request, but when kicking in
throttle, we need to anyway and so a busy connection would degrade
to LT anyway to maintain the throttle. As a result this change
should not cause deviation in the performance much for busy
connections.
Change-Id: I522d284d2d0f40e1812ab4c1a453c8aec666464c
BUG: 1192114
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/9726
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit ee3799f4a6c09f85bb4733d69053b656f1341fd0
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu Jan 29 12:56:35 2015 +0530
rpcsvc: New rpc routines defined to send callback requests
Change-Id: I7f95682faada16308314bfbf84298b02d1198efa
BUG: 1188184
Signed-off-by: Poornima G <pgurusid@redhat.com>
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/9534
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 21499bd51d44741a11c8dac64e11becc5738eafe
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Feb 27 15:30:04 2015 +0100
nfs: nfs3_stat_to_fattr3() improvement
During a review of backorti http://review.gluster.org/9170, Kaleb points
out:
ick, return-by-value. About 50% slower than passing a pointer to the
target struct.
Change-Id: I4464e6a4e50d82d446a834892d0308332b7c32d0
BUG: 1197142
Reported-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9772
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b21d5668acbdc89a57ab028c100bca827466fc05
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Feb 27 16:46:58 2015 +0100
NetBSD Portability fix: use pkill instead of killall
NetBSD does not have the killall command.
BUG: 1129939
Change-Id: Ie022bfb7efd6288ab19050addcfbd2822fbc78c0
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9771
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit aca40d69e300f5e02c06f12948980a12eda6a644
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Feb 25 15:49:11 2015 +0530
socket: allow only one epoll thread to read msg fragments
__socket_read_reply function releases sock priv->lock briefly for
notifying higher layers of message's xid. This could result in other
epoll threads that are processing events on this socket to read further
fragments of the same message. This may lead to incorrect fragment
processing and result in a crash.
Change-Id: I915665b2e54ca16f2ad65970e51bf76c65d954a4
BUG: 1197118
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/9742
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 2ead81ca425743b74fcd3de10070341842a4f6bb
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Feb 27 13:25:37 2015 +0100
Tests: At cleanup time, kill rpc.statd on NetBSD
The NFS server cannot start is a rpc.statd is still running. Make
sure the cleanup procedure remove any leftover rpc.statd.
BUG: 1129939
Change-Id: I03c41b18526583f3304321e4e4a27e99b8fbf1f6
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9770
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit dfe583f06c1974727b7a44f5e7bf0c2078007bf2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 25 11:37:57 2015 +0530
libglusterfs: Moved common functions as utils in syncop/common-utils
These will be used by both afr and ec. Moved syncop_dirfd, syncop_ftw,
syncop_dir_scan functions also into syncop-utils.c
Change-Id: I467253c74a346e1e292d36a8c1a035775c3aa670
BUG: 1177601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9740
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4d5f7ca4103c575ef141480fa3d7560a88e2a2aa
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Feb 27 03:50:40 2015 +0100
Tests: give sane default for NetBSD NFS mount retry count
Default NetBSD NFS retry count is 10000, which means tests will loop
for a long time if the server is not available.
We fix this by setting a default retry count to 2 (1 seems to low and
breaks regression). If mount_nfs is called with a retry option, it will
overrride this default.
BUG: 1129939
Change-Id: I1ae16f8caa74d6e9af1aa7a55fd111178af0ad78
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9763
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit eb8894dd43cc72603f09bc8792b2c901121f20e7
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Feb 25 15:44:59 2015 +0530
libgfapi: In glfs_init() set the cwd to "/".
Initially, when the cwd is NULL, while resolving a
relative path, it was taken to be relative from the root
of the volume.
But this behaviour changed with the patch:
http://review.gluster.org/#/c/9671/
with this patch, if cwd is NULL, all the fops on the files
(given relative path) under root directory will fail.
Hence, setting the cwd to "/" during glfs_init() itself.
Change-Id: I65018f6cd42539d09852069b84099034b9925418
BUG: 1196019
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/9744
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 981951950c880b4597676abdb02c891b7242b11a
Author: Anoop C S <achiraya@redhat.com>
Date: Sat Dec 20 12:22:02 2014 +0530
cluster/dht: Propagate an event only after hearing the same from all subvolumes
In dht_notify(), we propagate each event without checking whether
all subvolumes have reported the same event earlier. As a result
separate events are being forwarded for each dht-subvolume.
This change is to make sure that we propagate a particular event
only if all other subvolumes have already reported the same event
once earlier.
Change-Id: I6c73fa105e967f29648af9e2030f91a94f2df130
BUG: 1176543
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/9322
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit fe693b9f37b79154ade704164df09f8e0779240f
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Feb 26 13:59:02 2015 +0100
dht: fix for dht_lock_count() compile error
dht-common.h includes a function definition with "inline", but the
function is not declared in the header. Dropping the "inline" compile
directive so that linking against .o files works correctly.
BUG: 1196650
Change-Id: I105be591125b29cd455769b0c4ff22d6e139227d
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9760
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 6f0b0c8c808590c291c059e7aee9c65b6302e8db
Author: Mark Lipscombe <mlipscombe@gmail.com>
Date: Tue Feb 24 12:28:27 2015 -0800
rdma: Fix failure to call rdma_bind_addr if unable to bind privileged port.
When unable to bind a privileged port, rdma_bind_addr is not called.
This patch fixes that.
Change-Id: I175884a5d6a08b93dc62653ee0a6622bfc06e618
Bug: 1195907
Signed-off-by: Mark Lipscombe <mlipscombe@gmail.com>
Reviewed-on: http://review.gluster.org/9737
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit dbcc0229a977068ea37aa5b7cb03f9552c0558e6
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Feb 25 20:34:41 2015 +0530
mgmt/glusterd: Refactor brick graph generation in volgen.
This commit does the following:
1. Adds several new functions for generation of brick xlator units
in a volgen. Each such function takes care of generation of only
one xlator in volgen.
2. A new table, server_graph_table, links all individual graph generation
functions together. The order of xlator function generators in the
table determines the topology of the brick graph.
3. server_graph_builder() invokes individual graph generators by walking
through server_graph_table. Addition of debug xlators into the brick
graph is also handled by this walk. As a result, a lot of cruft that
is present in the exisiting implementation of this function gets
cleaned up.
4. get_server_xlator() now makes use of server_graph_table to determine
whether a xlator key corresponds to a server xlator or not.
Change-Id: I46bb6e331544150302eb5b33c4007917aff2586d
BUG: 1188196
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/9751
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit e4d75023571532338ba6d75706baeac1df399658
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Feb 24 10:25:16 2015 +0530
cluster/dht: serialize execution of dht_discover_complete and STACK_DESTROY (frame).
In the current code, dht_discover_complete can be invoked because of:
1. attempt_unwind is true
2. we are processing reply from the last subvolume
In scenario 1, following race is possible:
T1: calls dht_frame_return.
T2: calls dht_frame_return. This happens to be last call and hence it
invokes dht_discover_complete, goes ahead and destroys frame
T1: since attempt_unwind is true, calls
dht_discover_complete. However, since frame is already freed, call
to dht_discover_complete can result in a crash.
The fix is to make sure that destruction of the frame is done only by
the thread executing dht_discover_complete.
Change-Id: I45765b90c4a9d0af0b33f8911b564d99e12d099e
BUG: 1195120
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/9729
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit bd0bcf1780427ad909123e4a171bc379cebc94f9
Author: Anuradha <atalur@redhat.com>
Date: Mon Feb 9 12:44:33 2015 +0530
cluster/afr : provide split-brain info by using getxattr
This patch is one part to enable users analyze and resolve
split-brain.
Problem : To know if a file is in data/metadata split-brain
Solution : Performing "getfattr -n afr.split-brain-status
<path-to-file>" from the mount provides this information.
Also provides the list of afr children to analyse to
get more information.
Change-Id: I4d9b429794759a906371416cb84c84a212e2c7b9
BUG: 1191396
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/9633
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 1ba11c7df28d31ae62314f25e55d77cadf3d38c6
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Wed Feb 25 19:37:22 2015 +0530
spec: correcting GlusterFS string
Change-Id: Ia39d81f89cf783016700c8059f6a788029ee1b13
BUG: 1075417
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9749
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6820583c4cdac76c07787e17769b099eb1f789e5
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Mon Feb 23 20:50:37 2015 +0530
README: Adding information about Gluster dev workflow
In the README.md (which is automatically rendered in
github) there is no information about GlusterFS
workflow. So community members send pull requests in
github.
This patch will put the workflow information, so that
it would be easy for community members to know about
it by looking at GlusterFS's github mirror.
Change-Id: I62718f75aa26a45fe28e3e9399d1aa2338211c73
BUG: 1195336
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/9727
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 45dcae969194266e9678bf81973d1de257ba301f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Feb 6 17:06:28 2015 +0530
features/index: Add option to track specific xattrs for xattrop64
This enables trusted.ec.dirty to be tracked in index
Change-Id: Ief1619110859f6f9ccee3da229f0688b73e2124b
BUG: 1177601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9602
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 61086ef7284f0eafa3931ccf80929620664b4c7b
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Feb 15 17:56:51 2015 +0100
Portability fix: rpc.statd location
rpc.statd is in /usr/sbin on NetBSD
BUG: 1129939
Change-Id: I6d09e2525cc8242ef3d25d3d5421d57aac711ea4
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9654
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 0e10e12fceec7adaab62d47f9f25f77f66f279eb
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Feb 9 09:26:46 2015 +0100
ec: Add trusted.ec.dirty xattr
This xattr will be incremented before each data modifying operation and
decremented after it. This will add the possibility to detect partially
updated writes and refuse them on reads.
It will also be useful for interacting with index xlator and have a way
to heal dispersed files from the self-heal daemon.
Change-Id: Ie644a8dd074ae0f254c809c5863bdb030be5486a
BUG: 1190581
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9607
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6c7075fd33beaef24deab47725b52d73a5f3db26
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 20 12:58:20 2015 +0530
glusterd/snapshot: Fix the ret check in gd_restore_snap_volume
In gd_restore_snap_volume(), irrespective of the ret value
we were trying to do a list_add_tail to new_volinfo variable.
There might be cases where this variable might be NULL, and hence
cause a crash.
Change-Id: I158c5ae655ea27c9a91be3cb9d95a80a3dd05559
BUG: 1194538
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/9719
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 1de680f398c88ca4fc47872147c12126ed45c093
Author: Soumya Koduri <skoduri@redhat.com>
Date: Tue Jan 27 16:53:35 2015 +0530
libglusterfs: Added support to set 'frame->root->lkowner'
This support can be used by the clients using SYNCOP framework,
to pass unique owners for various locks taken on a file, so that
the glusterfs-server can treat them as being locks from different owners.
Change-Id: Ie88014053af40fc7913ad6c1f7730d54cc44ddab
BUG: 1186713
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/9482
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 3a7e84f1aa781c543347ce783a3c820898b94ba5
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jan 6 15:12:59 2015 +0530
build, glusterd: Add liburcu to build system
This patch adds liburcu related checks to the build system and updates
the spec file to require 'userspace-rcu'.
liburcu >= 0.7 is required to build GlusterFS, but 0.8 and above is
preferred. For cases when liburcu 0.7.x is the available version, some
function definitions (currently just one) from liburcu-0.8.6 have been
made available in /contrib/userspace-rcu/.
This change was developed on the git branch at [1]. This commit is a
combination of the following commits on the development branch.
a5cd6bd Add userspace-rcu checks to configure.ac
fe5ced3 Add URCU libs to glusterd libtool flags
1e43302 Add local definition of cds_list_add_tail_rcu for
liburcu-0.7
98da755 Move local definition of cds_list_add_tail_rcu into contrib
8c44dfd Update spec file to include userspace-rcu0466e33 Rename
rculist-additional.h to rculist-extra.h
947c7b3 Add rculist-extra.h to dist
19f32ad Address review comments 9605/1
[1]: https://github.com/kshlm/glusterfs/tree/urcu
Change-Id: Ifbb617d0dacce8fa01214f894badb9d8cdcaf56f
BUG: 1191030
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/9605
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 444c8f86b41c8f79dd9f0094a187aa2c8a5655e2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Feb 9 14:20:28 2015 +0530
cli: Provide CLI to create disperse volume with data, redundancy counts
Change-Id: Iba44be565c895e26b19b5ff85a886873f6b53e5c
BUG: 1177601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9616
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 90c9e660db125441dad733a7177139a528bd7ac3
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Feb 17 06:55:22 2015 +0530
gfapi: handle inode_link failures gracefully
Bug: 1193757
Change-Id: I73bfb91a6a73ad4f06e8828d2d7efd34d9873888
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/9671
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 658085b16f7dcb8ac1ca0021227e1e3c2dc35d3f
Author: vmallika <vmallika@redhat.com>
Date: Thu Feb 19 17:54:03 2015 +0530
Fix for test usst.t and bug-1167580-set-proper-uid-and-gid-during-nfs-access.t
testcase usst.t and
bug-1167580-set-proper-uid-and-gid-during-nfs-access.t
uses below method to generate random string
cat /dev/urandom | tr -dc 'a-zA-Z' | fold -w 8 | head -n 1
Doing a cat on /dev/urandom can consume more CPU usage.
Change to:
uuidgen | tr -dc 'a-zA-Z' | head -c 8
Change-Id: I9cb562557ae860026fb5e140ed9b5e297b4428d9
BUG: 1163543
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9703
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 3b8d7b4a1d9f35d01b40e17510085420bf1e5484
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Feb 11 17:13:45 2015 +0530
glusterd: nfs,shd,quotad,snapd daemons refactoring
This patch ports nfs, shd, quotad & snapd with the approach suggested in
http://www.gluster.org/pipermail/gluster-devel/2014-December/043180.html
Change-Id: I4ea5b38793f87fc85cc9d2cf873727351dedffd2
BUG: 1191486
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9428
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
commit 266317b5239fdbbfad08bc992fca4e295da21322
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Feb 18 12:15:55 2015 +0530
cluster/dht: synchronize with other concurrent healers while healing layout.
Current layout heal code assumes layout setting is idempotent. This
allowed multiple concurrent healers to set the layout without any
synchronization. However, this is not the case as different healers
can come up with different layout for same directory and making layout
setting non-idempotent. So, we bring in synchronization among healers
to
1. Not to overwrite an ondisk well-formed layout.
2. Refresh the in-memory layout with the ondisk layout if in-memory
layout needs healing and ondisk layout is well formed.
This patch can synchronize
1. among multiple healers.
2. among multiple fix-layouts (which extends layout to consider
added or removed brick)
3. (but) not between healers and fix-layouts. So, the problem of
in-memory stale layouts (not matching with layout ondisk), is not
_completely_ fixed by this patch.
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Change-Id: Ia285f25e8d043bb3175c61468d0d11090acee539
BUG: 1176008
Reviewed-on: http://review.gluster.org/9302
Reviewed-by: N Balachandran <nbalacha@redhat.com>
commit d9ec7ce7941556001b0c0aaac6a6c15835d863af
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Thu Feb 19 17:30:35 2015 +0530
Storage/posix : Adding error checks in path formation
Modified a few log messages added for this fix.
Also set the op_errno in an error check.
Change-Id: I87caf2f89031aedad1aaee001aef54896dbecd3b
BUG: 1113960
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/9702
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 7ac968b80d2a80a19c9e2372e341c514e88d8754
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Jan 12 17:59:16 2015 +0530
geo-rep: Add support for non standard AuthorizedKeysFile location
In /etc/ssh/sshd_config, AuthorizedKeysFile can be customized
using %u and %h variables, %u will be replaced by user name
and %h will be replaced by home dir name. Default location is
.ssh/authorized_keys
For example,
AuthorizedKeysFile .ssh/authorized_keys
AuthorizedKeysFile %h/.my_secret_dir/authorized_keys
AuthorizedKeysFile /etc/ssh/keys/%u/authorized_keys
PS: Support only added for %h and %u in sshd_config
BUG: 1181117
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Change-Id: Ic6ba20f9d202762dfdb6d0c73ea42e7f7c64e177
Reviewed-on: http://review.gluster.org/9436
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 018c0a9d1fc6ea9b1ae26979d5032910ee26b833
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jan 15 15:19:50 2015 +0530
geo-rep: Archive Changelogs and avoid generating empty XSync changelogs
With this patch,
- Hybrid Crawl will not generate empty Changelogs
- Archives Changelogs when processed(Hybrid(XSync), History,
and Changelog Crawl
- Passive worker cleans up its processing directory
BUG: 1169331
Change-Id: I1383ffaed261cdf50da91b14260b4d43177657d1
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9453
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 8728ab18668d3737c6589bb2d383341e9faed272
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue Jul 22 18:49:44 2014 +0530
posix: Fix unlink failing under specific condition
PROBLEM:
Files are undeletable when these three conditions are met:
1. File does not have trusted.pgfid.<gfid> xattr set.
This won't be set when build-pgfid is off (default).
2. File has hardlink count > 1.
3. build-pgfid option is turned on.
FIX:
Allow unlink on files not having trusted.pgfid.<gfid> xattr.
Change-Id: I58a9d9a1b29a0cb07f4959daabbd6dd04fab2b34
BUG: 1122028
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/8352
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit a6bfb7bb6b8655c7ac47c04c65db4ec59053c2f4
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Feb 12 17:29:28 2015 +0530
client/server: fix reconfigure for event-threads option
Change-Id: Ica8bca13e4feb941e22651b642b848be165ccc9e
BUG: 1104462
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9648
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit ba54187296e6fab7cc5f9eb2e4687fdd75387e54
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Feb 3 05:01:38 2015 +0530
features/quota : Fix XML output for quota list command
Sample output:
---------------
Sample 1)
----------
[root@snapshot-28 glusterfs]# gluster volume quota vol1 list /dir1 /dir4 /dir5 --xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volQuota>
<limit>
<path>/dir1</path>
<hard_limit>10.0MB</hard_limit>
<soft_limit>80%</soft_limit>
<used_space>0Bytes</used_space>
<avail_space>10.0MB</avail_space>
<hl_exceeded>No</hl_exceeded>
<sl_exceeded>No</sl_exceeded>
</limit>
<limit>
<path>/dir4</path>
<path>No such file or directory</path>
</limit>
<limit>
<path>/dir5</path>
<path>No such file or directory</path>
</limit>
</volQuota>
</cliOutput>
Sample 2)
---------
gluster volume quota vol1 list --xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volQuota/>
</cliOutput>
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<volQuota>
<limit>
<path>/dir</path>
<hard_limit>10.0MB</hard_limit>
<soft_limit>80%</soft_limit>
<used_space>0Bytes</used_space>
<avail_space>10.0MB</avail_space>
<hl_exceeded>No</hl_exceeded>
<sl_exceeded>No</sl_exceeded>
</limit>
<limit>
<path>/dir1</path>
<hard_limit>10.0MB</hard_limit>
<soft_limit>80%</soft_limit>
<used_space>0Bytes</used_space>
<avail_space>10.0MB</avail_space>
<hl_exceeded>No</hl_exceeded>
<sl_exceeded>No</sl_exceeded>
</limit>
</volQuota>
</cliOutput>
Change-Id: I8a8d83cff88f778e5ee01fbca07d9f94c412317a
BUG: 1185259
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/9481
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 91dbad981cf5ca9701d9d6f39303de05290cf7a3
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Feb 18 22:50:34 2015 +0530
rdma: free rdma priv data if init fails
Change-Id: I57b38c8783666e806836dacf3f74cf9f6876070a
BUG: 1164079
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9687
Reviewed-by: mohammed rafi kc <rkavunga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit b1f7b78693eb6234d64690c7e5bf8942670d71f4
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Wed Dec 17 13:58:56 2014 +0530
Storage/posix : Adding error checks in path formation
Renaming directories can cause the size of the buffer
required for posix_handle_path to increase between the
first call, which calculates the size, and the second call
which forms the path in the buffer allocated based on
the size calculated in the first call.
The path created in the second call overflows the
allocated buffer and overwrites the stack causing the
brick process to crash.
The fix adds a buffer size check to prevent the buffer
overflow. It also checks and returns an error if the
posix_handle_path call is unable to form the path instead
of working on the incomplete path, which is likely to cause
subsequent calls using the path to fail with ELOOP.
Preventing buffer overflow and handling errors
BUG: 1113960
Change-Id: If3d3c1952e297ad14f121f05f90a35baf42923aa
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/9289
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 3784a3072e04f4be797db6c61b6b3654726ad160
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Nov 24 17:07:02 2014 +0530
cli: volume status for tcp,rdma type volume display only tcp port
For tcp,rdma type voumes, there will be two ports, one for tcp
and one for rdma. But volume status command only display tcp port.
By this change, adding an extra column for rdma port and changing
the port to tcp port.
Eg:
>gluster volume status pathy
>For tcp,rdma type volume
Status of volume: patchy
Gluster process TCP Port RDMA Port Online Pid
------------------------------------------------------------------------------
Brick brickname 49152 49153 Y 14158
>For rdma type volume
Status of volume: patchy
Gluster process TCP Port RDMA Port Online Pid
------------------------------------------------------------------------------
Brick brickname 0 49153 Y 14158
For tcp type volume
Status of volume: patchy
Gluster process TCP Port RDMA Port Online Pid
------------------------------------------------------------------------------
Brick brickname 49152 0 Y 14158
>gluster volume status patchy detail
Status of volume: xcube2
------------------------------------------------------------------------------
Brick : Brick brickname
TCP Port : 49152
RDMA Port : 49153
Online : Y
Pid : 14158
File System : ext4
Device :
/dev/mapper/luks-2099dd4a-0050-4cae-ad7b-c6a0498c4e88
Mount Options : rw,seclabel,relatime,data=ordered
Inode Size : 256
Disk Space Free : 31.1GB
Total Disk Space : 47.9GB
Inode Count : 3203072
Free Inodes : 2926789
>gluster volume status xcube --xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr>(null)</opErrstr>
<volStatus>
<volumes>
<volume>
<volName>xcube</volName>
<nodeCount>2</nodeCount>
<node>
<hostname>hostname</hostname>
<path>/home/brick1</path>
<peerid>2d7bcb95-3d26-4d4f-b3c6-e2ee01b71662</peerid>
<status>1</status>
<port>49152</port>
<ports>
<tcp>49152</tcp>
<rdma>N/A</rdma>
</ports>
<pid>5657</pid>
</node>
<node>
<hostname>NFS Server</hostname>
<path>localhost</path>
<peerid>2d7bcb95-3d26-4d4f-b3c6-e2ee01b71662</peerid>
<status>1</status>
<port>2049</port>
<ports>
<tcp>2049</tcp>
<rdma>N/A</rdma>
</ports>
<pid>5665</pid>
</node>
<tasks/>
</volume>
</volumes>
</volStatus>
</cliOutput>
Change-Id: I81aab226edbd400d29cd3f510af4f344dd99ba51
BUG: 1164079
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9191
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit c678e7f243b586e697b9b6e0c8717c91c23fddcf
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Feb 17 15:50:54 2015 +0530
glusterd: Use correct format specifier for dumping peer hostname
Change-Id: Ifdde4f8256fa463472959078f53d033e5c55207e
BUG: 1139682
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9665
Reviewed-by: Anand Nekkunti <anekkunt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit aee382c884fd5c00c674e9bdc08ef5c8c9683822
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Feb 17 20:17:58 2015 +0530
rdma: pre-register iobuf_pool with rdma devices.
registring buffers with rdma device is a time consuming
operation. So performing registration in code path will
decrease the performance.
Using a pre registered memory will give a bettor performance,
ie, register iobuf_pool during rdma initialization. For
dynamically created arena, we can register with all the
device.
Change-Id: Ic79183e2efd014c43faf5911fdb6d5cfbcee64ca
BUG: 1187456
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9506
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit ae5b39ac97d3cb13ca25421c88c2c8c46852486c
Author: Shyam <srangana@redhat.com>
Date: Wed Nov 12 10:12:13 2014 -0500
cluster/dht: Fix dht_link to follow files under migration
Currently if a file is under migration, a hardlink to that file
is lost post migration of the file. This is due to the fact that
the hard link is created against the cached subvol of the source
and as the source is under migration, it shifts to a linkto file
post migration. Thus losing the hardlink.
This change follows the stat information that triggers a phase1/2
detection for a file under migration, to create the link on the new
subvol that the source file is migrating to. Thereby preserving the
hard link post migration.
NOTES:
The test case added create a ~1GB file, so that we can catch the file
during migration, smaller files may not capture this state and the
test may fail.
Even if migration of the file fails, we would only be left with stale
linkto files on the subvol that the source was migrating to, which is
not a problem.
This change would create a double linkto, i.e new target hashed subvol
would point to old source cached subol, which would point to the real
cached subvol. This double redirection although not handled directly in
DHT, works as lookup searches everywhere on hitting linkto files. The
downside is that it never heals the new target hashed subvol linkto
file, which is another bug to be resolved (does not cause functional
impact).
Change-Id: I871e6885b15e65e05bfe70a0b0180605493cb534
BUG: 1161311
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/9105
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: susant palai <spalai@redhat.com>
Reviewed-by: venkatesh somyajulu <vsomyaju@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 0b838f966ac356fffe3c27865fcbcddcc52aec46
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Fri Feb 13 17:10:37 2015 +0530
build: .cmd_log_history should be renamed to cmd_history.log post upgrade.
While upgrading from glusterfs-version < 3.6 to glusterfs-3.6,
.cmd_log_history hidden file still present in /var/log/glusterfs/ directory.
With this fix it will not have .cmd_log_history hidden file and it will
rename it to cmd_history.log file.
Change-Id: I2c1658056ddd75ce923f100961205a3b78394466
BUG: 1165996
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/9652
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 88c8e3351d0fea65763eb88acbeb5b6cb3f8327d
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Feb 10 17:11:21 2015 +0530
rdma: reduce log level from E to W
glusterd process, when try to initialize default vol file, will
always through an error if there is no rdma device. Changing the
log levels and log messages to more appropriately.
Change-Id: I75b919581c6738446dd2d5bddb7b7658a91efcf4
BUG: 1188232
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9559
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 67f0279462a9e2a01d9a02268fd4d2cabd3a8dda
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Dec 23 11:31:37 2014 +0530
rdma:read multiple wr from cq and ack them in one call
we are reading one work completion request at a time
from cq, though we can read multiple work completion
requests from cq. Also we can acknowledge them in
one call itself. Both will give a better performance
because of less mutual exclusion locks are being performed.
Change-Id: Ib5664cab25c87db7f575d482eee4dcd2b5005c04
BUG: 1164079
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9329
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit df8dbef88ea00ce6b4b9e813a7a8d42617daf381
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Feb 10 16:43:50 2015 +0530
feature/gfid-access: Send a named lookup before trying to create a file.
Normally a named-lookup is done by the kernel on an entry before it
issues a dentry creation fop like create/mknod etc. This will enable
cluster translators like dht to maintain internal consistency like
deleting a linkto file if no corresponding datafile is present etc.
While handling file creation on auxiliary gfid mounts, we issue dentry
creation fop without issuing a lookup. If there are stale-linkto files,
creation would fail with EEXIST, however access would fail since there
is no datafile. A named lookup would cleanup the linkto file allowing
create to succeed.
Change-Id: I2932107296adac710dd179df7d0946b8697a497a
BUG: 1191413
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9634
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 96af7398784131999782e6f36594de3e6ff1be19
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jan 6 20:26:39 2015 +0530
glusterd/geo-rep: Allow replace/remove brick if geo-rep is stopped.
Replace brick:
If geo-replication was configured on a volume, replace brick
used to fail. This patch allows replace brick to go through
if all geo-rep sessions corresponding to that volume is stopped.
Remove brick:
There was no check for geo-replication for remove brick. Enforce
'remove brick commit' to fail if geo-rep session corresponding
to volume is running. Allow 'remove brick commit' only if all of
the geo-rep sessions corresponding to that volume is stopped.
Code is re-organized for better readability.
Change-Id: I02282c2764d8b81e319489c977847e6e437511a4
BUG: 1179638
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9402
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: ajeet jha <ajha@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit cb3c1f74f033c0e86d0a3c9b447da8adcd2d67bc
Author: Dan Lambright <dlambrig@redhat.com>
Date: Tue Dec 16 10:28:57 2014 -0500
cluster/dht: Modify dht-rebalance.c to use trusted.distribute.migrate-data rather than distribute.migrate-data and work with CLI.
The change makes this work both when it is internally driven and from the
shell. The problem is further described in bugzilla # 1147107.
Change-Id: I4fe04cae661dca25432530ddf5ac6ff2c957d6b3
BUG: 1147107
Signed-off-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-on: http://review.gluster.org/9284
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 1e90aebf31b6b1e4b2169e8e6e3fc251f7a5ba54
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Feb 12 18:11:46 2015 +0100
Temporarily remove nfs.t to avoid regression failures
Test basic/ec/nfs.t is causing many regression failures due to
a problem related with NFS.
While the NFS problem is solved, this patch removes the test
to avoid more regression failures.
Change-Id: I29884c5e06732e427130d1bc82f1b83553916f95
BUG: 1192114
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9649
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 8b74bc5a2226f640a5cd08decc3b7adc1fd77ed9
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Dec 22 15:16:43 2014 +0530
rdma: post multiple work request in a single call.
ibv_post-send will allow to send multiple work request
in a single call posting as linked list.
So if the payload count > 1, we can perform the data
operation in a single call to ibv_post_send.
Change-Id: Ib2e485cbbe6887919109e73e17d4fab595d5e65e
BUG: 1164079
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9327
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 157e676473eb3201e45f64073b97edcea626f9cb
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Dec 22 11:04:50 2014 +0530
rdma : agregate a vectored read as one
For a vectored read with payload count>1 will make two read
requests and to hold that a single contiguous memory is allocated.
So after completing the read request, instead of sending as vector
we will aggregate all the reads one.
Change-Id: I15e7d7bddc1a62d5097a39392575f47cfff3d3a8
BUG: 1164079
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9321
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 2ed22cf94587230439893427edac8fbbafa9a6c0
Author: Shyam <srangana@redhat.com>
Date: Sun Feb 8 20:08:46 2015 -0500
epoll: Initialize server/client xlator event-threads correctly
In the patch http://review.gluster.org/#/c/9488/ the default
configuration for server and client protocol xlators, had
event-threads set to 2, but the default conf was not updated
with these values, hence the default threads remained at 1.
This patch corrects the same by first updating the thread count
from the default configuration before updating it with the
latest.
Change-Id: I3ce54053a59ca796b004fa5462e43ca19a5f2915
BUG: 1104462
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/9604
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6fd487d45d98618a4a5056c888c0838152205b94
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Mon Feb 9 15:41:37 2015 +0530
api: coverity fix.
CID 1214617: dereference NULL return value.
Change-Id: I57447c3b1663edadfa966892c53bc2a16d4a166f
BUG: 789278
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/9610
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 32405e069188cb17b63b3897f91c3ea36bc87dbb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Jan 31 16:07:03 2015 +0530
cluster/afr: Enable auto-quorum for replicate with odd number of bricks
Change-Id: I908934f1f22cf7d2d0ceccc0dedf28a69861997f
BUG: 1187885
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9517
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit 9e3a0bdebf8733621ffcef7b6efb4debb8a7ac4d
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Feb 5 15:41:35 2015 +0530
protocol/client: sequence CHILD_UP, CHILD_DOWN etc notifications
... from all bricks in the volume
This patch is important in the context of MT epoll. With MT epoll,
notification events from client xlators could reach cluster xlators like
afr, dht, ec, stripe etc. in different orders.
For e.g, In a distributed replicate volume of 2 bricks, namely Brick1
and Brick2, the following network events are observed by a mount
process.
- connection to Brick1 is broken.
- connection to Brick1 has been restored.
- connection to Brick2 is broken.
- connection to Brick2 has been restored.
Without establishing a total ordering of events, we can't guarantee that
cluster xlators like afr, dht perceive them in the same order. While we
would expect afr (say) to perceive it as only one of Brick1 and Brick2
going down at any given time, it is possible for the notification of
Brick2 going offline to race with the notification of Brick1 coming back
online.
Change-Id: I78f5a52bfb05593335d0e9ad53ebfff98995593d
BUG: 1104462
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9591
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2413a2d3d39409e00a964c8c8c8497c4cdeb438f
Author: Shyam <srangana@redhat.com>
Date: Mon Jan 26 14:20:31 2015 -0500
epoll: Adding the ability to configure epoll threads
Add the ability to configure the number of event threads
for various gluster services.
Currently with the multi thread epoll patch, it is possible
to have more than one thread waiting on socket activity and
processing the same. This thread count is currently static,
which this commit makes dynamic.
The current services which use IO path, i.e brick processes,
any client process (nfs, FUSE, gfapi, heal,
rebalance, etc.a), gain 2 set parameters to control the number
of threads that are processing events. These settings are,
- client.event-threads <n>
- server.event-threads <n>
The client setting affects the client graph consumers, and the
server setting affects the brick processes. These are processed
and inited/reconfigured using the client/server protocol xlators.
Other services (say glusterd) would need to extend similar
configuration settings to take advantage of multi threaded event
processing.
At present glusterd is not enabled with this commit, as it does not
stand to gain from this multi-threading (as I understand it).
Change-Id: Id8422fc57a9f95a135158eb6477ccf9d3c9ea4d9
BUG: 1104462
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/9488
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bd8a32c7c5c9ded8da196a27810f4f01c3721e2f
Author: Vijaikumar M <vmallika@redhat.com>
Date: Thu Jun 19 15:41:22 2014 +0530
epoll: edge triggered and multi-threaded epoll
- edge triggered (oneshot) polling with epoll
- pick one event to avoid multiple events getting picked up by same
thread
and so get better distribution of events against multiple threads
- wire support for multiple poll threads to epoll_wait in parallel
- evdata to store absolute index and not hint for epoll
- store index and gen of slot instead of fd and index hint
- perform fd close asynchronously inside event.c for multithread safety
- poll is still single threaded
Change-Id: I536851dda0ab224c5d5a1b130a571397c9cace8f
BUG: 1104462
Signed-off-by: Anand Avati <avati@redhat.com>
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/3842
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ee4dd1f82da63efe63ba5791dc8fea23b3a62b93
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Feb 5 21:26:04 2015 +0530
cluster/afr: Re-introduce heal-timeout option
Change-Id: I87484c810006a92ed7489284b6d74e9b0aecae80
BUG: 1177601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9598
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 38c782c53db78590a7c3b5b9b983cd67d0521e97
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Feb 5 21:23:37 2015 +0530
syncop: Provide syncop_ftw and syncop_dir_scan utils
ftw provides file tree walk.
dir_scan does just a readdir not readdirp.
Also changed Afr's self-heal-daemon's crawling functions to use this.
These utils will be used by ec in future to do proactive/full healing.
Change-Id: I05715ddb789592c1b79a71e98f1e8cc29aac5c26
BUG: 1177601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9485
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 144d096d6d098d988a6b3731d290bfc0d73d06c5
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Fri Jan 30 11:47:11 2015 +0100
ec: Special handling of anonymous fd
Anonymous file descriptors need to be handled specially because
they can be used in some non standard ways (i.e. an anonymous fd
can be used without having been opened).
This caused NFS to fail on some operations because ec always
expected to have a previous successful opendir call (from patch
http://review.gluster.org/9098/).
This patch treats all anonymous fd as opened on all subvolumes.
Change-Id: I09dbbce2ffc1ae3a5bcbb328bed55b84f4f0b9f8
BUG: 1187474
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9513
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0690b0c818ca65705b2e0a96b69480569e6533ad
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Feb 4 15:39:31 2015 +0530
rpc: fix ref leak in ping timer
Change-Id: I4ddc371d01ec763706a168a215410015ee2a3787
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9578
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 8f64913d91c5910f5c329a6f8ebbb29fcc4204ec
Author: GauravKumarGarg <ggarg@redhat.com>
Date: Wed Nov 12 17:41:33 2014 +0530
DHT: cluster.min-free-disk option should validate correctly
PROBLEM:
Previously gluster accepting input value as a percentage which is out of range
[0-100] and accepting input value as a size (unit is byte) which is fractional
for option cluster.min-free-disk.
FIX:
Now with this change it will refer to correct validation function
and it will accept value that is in range [0-100] for input value as a
percentage and unsigned integer value for input as a size (unit in byte)
for option cluster.min-free-disk.
Change-Id: Iee1962a100542e146276cfc8a4068abddee2bf2d
BUG: 1163108
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/9104
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 978d5541c477a0c11b1e414b30ad9b7a68aaaed8
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Feb 3 21:34:45 2015 +0530
cluster/afr: Fix parent read subvol selection policy in lookup
When lookup has succeeded on multiple subvols of AFR (including
the read child of the parent dir) and all of them are "readable",
ideally the call must be unwound with postparent from the parent's
read child. But that is not the case, due to a bug introduced in
the commit c78998c39f0857ea7aacba360632c148afc54a55. This patch
fixes the issue.
Change-Id: I83b0c26494a5d0bdbc30fcbe974fbdb6f7e9c84a
BUG: 1179169
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9569
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9dffe6394f8854ec6f2534ca32541d06e0115c5a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Feb 4 14:13:05 2015 +0530
tests : spurious failure fix in heald.t
Problem : heald.t uses EXPECT to check whether shd process is up or not, but as
shd is spawned with NO_WAIT end of volume start transaction doesn't gurantee
that the process will be up by that time.
Solution : Use EXPECT_WITHIN instead of EXPECT
Change-Id: Ic81725aa7e7cde9c0c873837fcc4a73d8318dfa0
BUG: 1163543
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9575
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 98bcd77783c9b80b4940cac67a9a42ddd8105cc3
Author: Anand <anekkunt@redhat.com>
Date: Fri Jan 9 14:24:08 2015 +0530
libglusterfs : Corrected functions calls.
Problem : There was mismatch between arguments and parameters in some functions
(ex:glusterfs_uuid_buf_get,glusterfs_lkowner_buf_get). It could lead to stack overflow issues .
Fix : Arguments are removed during calling these function.
Change-Id: Icb41bd4119502d192d9cc7242d385ebe62cdb51a
BUG: 1180424
Signed-off-by: Anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/9427
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 98405cae40d332e04040bfed91c57937fffb61bb
Author: arao <arao@redhat.com>
Date: Thu Jan 29 16:37:35 2015 +0530
geo-rep: Fixing the typo errors
Change-Id: Iacc67e4ba9ac45e0858f3befe84ffb8fccf7e1c3
BUG: 1075417
Signed-off-by: arao <arao@redhat.com>
Reviewed-on: http://review.gluster.org/9502
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 4e6f69ef0179cf15f911b3c72249272642c72a24
Author: Nandaja Varma <nvarma@redhat.com>
Date: Fri Jan 30 14:17:23 2015 +0530
tests: Removing rpmbuild/mock check from run-tests.sh
Checks for rpmbuild/mock is removed from run-tests since this check
is not in the glusterfs-regression-tests package.
Alongside, the dependency mock is also removed from glusterfs.spec.in
as mock is only used by basic/rpm.t.
Change-Id: I5a9036141d0900b3a0bedd95b8c58fb0cdc13ca1
BUG: 1178008
Signed-off-by: Nandaja Varma <nvarma@redhat.com>
Reviewed-on: http://review.gluster.org/9512
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 1aa538e4f362f5376c821767038d6e6649790077
Author: Sakshi Bansal <sabansal@redhat.com>
Date: Fri Jan 30 11:26:07 2015 +0530
tests: fixing typo errors
Change-Id: I8caab03531d74c64dcfa05c35a7daeee646cd2fa
BUG: 1075417
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/9507
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/9548
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 44afb7352390466dde790df11fe8f3877fe003e2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Feb 1 15:03:46 2015 +0530
cluster/ec: Wait for all bricks to notify before notifying parent
This is to prevent spurious heals that can result in self-heal.
Change-Id: I0b27c1c1fc7a58e2683cb1ca135117a85efcc6c9
BUG: 1179180
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9523
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 81a840c8673d2b16538567c51add8b7edc317043
Author: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Fri Jan 30 12:57:21 2015 +0530
tests/snapshot: Avoid errors on make dist.
Problem:
"make dist" gives the following error:
tar: bug-1140162-file-snapshot-and-features-encryption-option-validation.t:
file name is too long (max 99); not dumped
Here, .t file is not getting included on the "make dist" tarball as file
name is too long for the "tar" command. Result is, upon distributing the tests
through the tarball, this particular test will not get run on the target system.
Solution:
Rename the file to a shorter one(less than 99) to avoid this error.
Change-Id: I29c8da649b8b5e00b3b4dada02c8b69b2d7f0e2c
BUG: 1140162
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/9511
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 4da240ef92d68da7572f5ab3787b79de26ad9969
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jan 7 21:56:58 2015 +0530
geo-rep: Adding Slave user field to georep status
New column introduced in Status output, "SLAVE USER",
Slave user is not "root" in non root Geo-replication setup.
Added additional tag in XML output <slave_user>
BUG: 1180459
Change-Id: Ia48a5a8eb892ce883b9ec114be7bb2d46eff8535
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9409
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 887bed266ff4687f27d8c3f98fc58373c5310072
Author: Anand <anekkunt@redhat.com>
Date: Thu Jan 29 14:01:12 2015 +0530
glusterd : Corrected server.statedump-path description.
Problem : gluster volume set help for server.statedump-path has wrong
description.
Fix : Server.statedump-path description corrected .
Change-Id: I10f5494a01c6dbbb2204665666f3c3c1ad4599e8
BUG: 1186993
Signed-off-by: Anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/9500
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 893769abac791aae98d8f814d593961be43c39aa
Author: Dennis Schafroth <dennis@schafroth.dk>
Date: Sat Jan 31 19:23:16 2015 +0100
Compare key with GF_XATTR_LOCKINFO_KEY with length of GF_XATTR_LOCKINFO_KEY instead of length of 0
BUG: 1187952
Change-Id: I0a97c553e85a0f9260ab01d4b48c64831bf67c18
Signed-off-by: Dennis Schafroth <dennis@schafroth.com>
Reviewed-on: http://review.gluster.org/9518
Reviewed-by: Joe Julian <joe@julianfamily.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 801d1c8f31f066e141d4f4fec9bfdd47e358542b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Feb 1 12:40:21 2015 +0000
doc: self-heal daemon
Documentation describing how the self-heal daemon works for replicate
volumes.
Change-Id: I89bdbbeee7f5106f0ee71870e11aa9c96f90753d
BUG: 1118309
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9537
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 590d90282c59741fc44dc14524fdac6bd48138dd
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jan 22 13:53:47 2015 +0530
cluster/afr: When parent and entry read subvols are different, set entry->inode to NULL
That way a lookup would be forced on the entry, and its attributes will
always be selected from its read subvol.
Change-Id: Iaba25e2cd5f83e983fc8b1a1f48da3850808e6b8
BUG: 1179169
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9477
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 943a795ccc8a48ddc9669ef9449be80dcd54f71d
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Feb 1 03:48:05 2015 +0100
Emulate Linux truncate for G and GB units
Recent modification in sparse-file-self-heal.t added a
truncate -s 1G, and that unit was not emulated correctly
for non Linux systems. As a result, all regression tests
hang. Fill the gap to restore regression.
BUG: 1129939
Change-Id: Ib45376b4b2e74d1868f3ebdd5564b2186b4318fa
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9519
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 450e358ac81056a17da4cd8f8f2e4751232fb47d
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jan 19 10:20:28 2015 +0100
build: do not include automake/autoconf cache in the 'make dist' tarball
Remove the caches from the 'dist-hook' target that 'make dist' executes.
Also, there is no need to run ./configure inside contrib/argp-standalone
if it will not get used. configure.ac has been modified to only
configure the contrib/argp-standalone sources for distributions that do
not have the <argp.h> header available.
BUG: 1183538
Change-Id: Iedd67139ec83f0076e24ed0d575f9053ac1a94ec
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9463
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 482c9d605cde3c5476767c1affeb2d4124dcb19b
Author: Anuradha <atalur@redhat.com>
Date: Fri Jan 23 10:51:11 2015 +0530
afr : Change in heal info split-brain command
Implementation of heal info split-brain command with
glfs-heal.
Change-Id: I233eb790de6eb5468a4cbb12a1cef0f97db2a1d2
BUG: 1183019
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/9459
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit afcfa54b7a7eef1464740c17034b27aeffe7f29e
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jan 23 11:12:54 2015 +0530
afr: Don't write to sparse regions of sink.
Problem:
When data-self-heal-algorithm is set to 'full', shd just reads from
source and writes to sink. If source file happened to be sparse (VM
workloads), we end up actually writing 0s to the corresponding regions
of the sink causing it to lose its sparseness.
Fix:
If the source file is sparse, and the data read from source and sink are
both zeros for that range, skip writing that range to the sink.
Change-Id: I787b06a553803247f43a40c00139cb483a22f9ca
BUG: 1166020
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9480
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 73811d8990a3640af22ac4d9a3ea39c91156eb6b
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Wed Jul 9 00:18:13 2014 +0530
doc: Fix typos in stripe xlator src, no code changes present
Change-Id: Icec4e6b0fe7845667b59e13e261734a5f69eba7e
BUG: 1075417
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8264
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 4b4e5523e73817af62bcb640f0c14f3df8b9fa93
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jan 21 08:25:23 2015 +0000
glusterd/snapshot: Fail snap create even if one brick is down.
In a n-way replication, where n>=3 fail snapshot,
even if one brick is down.
Also check for glusterd quorum, irrespective of the force option
Modified testcase tests/bugs/snapshot/bug-1090042.t because
it tested the successful creation of snapshot with force
command.
Change-Id: I72666f8f1484bd1766b9d6799c20766e4547f6c5
BUG: 1184344
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/9470
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 396e9a14f9d0cbe86f930eb906f74c0d90fb6f68
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Jan 13 20:25:34 2015 +0530
doc: Add doc for rdma transport.
Also corrected few things related to rdma documentation
in other docs.
Change-Id: If35d7e2e884974ff3719f6a9f111f7b45ac8c0ec
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/9443
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Ben England <bengland@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 153c828afa61d7a7f93b2f31e65ea46ea38d7c05
Author: hchiramm <hchiramm@redhat.com>
Date: Thu Sep 25 13:23:46 2014 +0530
doc: update glossary documentation
Change-Id: I0da7c3aaaeb43f633b4d6355ef83ac2d21e24d68
Signed-off-by: Divya <dmuntima@redhat.com>
Signed-off-by: Pavithra <psriniva@redhat.com>
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8847
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit f271ddca71ff524caa18aa1c8d1937bd4403e156
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jan 8 15:39:40 2015 +0530
cluster/ec: Handle CHILD UP/DOWN in all cases
Problem:
When all the bricks are down at the time of mounting the volume, then mount
command hangs.
Fix:
1. Ignore all CHILD_CONNECTING events comming from subvolumes.
2. On timer expiration (without enough up or down childs) send
CHILD_DOWN.
3. Once enough up or down subvolumes are detected, send the appropriate event.
When rest of the subvols go up/down without changing the overall
ec-up/ec-down send CHILD_MODIFIED to parent subvols.
Change-Id: Ie0194dbadef2dce36ab5eb7beece84a6bf3c631c
BUG: 1179180
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9396
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9f6c1188a076ba0f3c3a09ee9fa67a8ebccb529f
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Sat Nov 8 21:46:41 2014 +0100
ec: Fix posix compliance failures
This patch solves some problems that caused dispersed volumes to not
pass posix smoke tests:
* Problems in open/create with O_WRONLY
Opening files with -w- permissions using O_WRONLY returned an EACCES
error because internally O_WRONLY was replaced with O_RDWR.
* Problems with entrylk on renames.
When source and destination were the same, ec tried to acquire
the same entrylk twice, causing a deadlock.
* Overwrite of a variable when reordering locks.
On a rename, if the second lock needed to be placed at the beggining
of the list, the 'lock' variable was overwritten and later its timer
was cancelled, cancelling the incorrect one.
* Handle O_TRUNC in open.
When O_TRUNC was received in an open call, it was blindly propagated
to child subvolumes. This caused a discrepancy between real file
size and the size stored into trusted.ec.size xattr. This has been
solved by removing O_TRUNC from open and later calling ftruncate.
Change-Id: I20c3d6e1c11be314be86879be54b728e01013798
BUG: 1161886
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9420
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 96f08478963e4c74554928a395493f5c2fd64fa1
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Jan 11 23:13:08 2015 +0530
libglusterfs: Avoid initializing per process globals more than once.
gfapi consumers can invoke glusters_globals_init() multiple times
through glfs_new(). This will result in re-initialization of already
inited variables and non deterministic behavior. To avoid this, a
new function gf_globals_init_once() has been added. The invocation
of this function is guarded through pthread_once(), thereby ensuring
single initialization of per process globals.
Change-Id: I0ecde02ee49e0c7379c2eb0f1c879d89774ec82f
BUG: 1184366
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/9430
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1fddd8c69a1f860dcee5fcfc823ae0672cff9063
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jan 20 17:57:22 2015 +0530
uss: disable memory accounting for the snapshot daemon
* Bring in option to disable memory accounting for a glusterfs process
This reverses the changes done by the commit
7fba3a88f1ced610eca0c23516a1e720d75160cd.
* Change the key from "memory-accounting" to "no-memory-accounting", as by
default all the glusterfs process enable memory accounting now. So to
disable memory accounting for some process, "no-mem-accounting" argument has
to be passed.
Change-Id: I39c7cefb0fe764ea3e48f4e73e1305b084c5f497
BUG: 1184366
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/9469
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1482f709513654cd87b52f72043e529aed2eb91d
Author: Shyam <srangana@redhat.com>
Date: Tue Jan 27 10:42:54 2015 -0500
test: Check till probe timeout, for conf change sync across glusterd
Currently the test case changed here, checks for the peer count to
be 1 until probe timeout and then checks for the changed
configuration, if it has been synced.
The peer count is not a gurantee that the configuration is also
in sync, hence changing this test case to check for the conf
update till probe timeout, by which time it should be in sync
(or at least that is our tolerance), and the test case deemed
as passing.
Change-Id: I4b1560979cfde3bd3bd691852d7d3a63e253bcf2
BUG: 1181203
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/9498
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 6fc4d69442ae0f5d6efdfe76159a104981650369
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Jan 27 17:42:53 2015 +0530
feature/changelog: Fix changelog and history scan failure.
Fixes bad file descriptor issue while cleaning up
scratch directory during gf_changelog_register.
Change-Id: Ia6aa8d55dcc2209144b48b6583681a155d919c42
BUG: 1162057
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9495
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit eb43b0651666386f12468d8df045d1b477145e18
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Jan 14 15:20:09 2015 +0530
Remove inactive maintainers.
Change-Id: I2b3916134c060d1beb35c36423fa28e6de54793c
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/9445
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit da7b34d816d1d09547abeb5e0da522b4cd36c4b2
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Jan 23 11:24:07 2015 +0100
tests/features/ssl-authz.t: Fix spurious failures
Fix two spurious failures in tests/features/ssl-authz.t
1) Wait for bricks to come online after starting a volume, so that
the mount is usable without "socket not connected" error
2) For a mount that must fail, we may get the situation where there
is no mount at all, which means creating a file will write to the
mount point instead of failing. To cover that case, write the
file and check it is absent from the brick.
BUG: 1129939
Change-Id: If95e1d65ab23d11123f778c20f8110a3177b0e7f
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9483
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e5c932f03b4a989eeda22fdd93713b59e793221f
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Nov 5 22:37:48 2014 -0500
socket: fix segfaults when TLS management connections fail
Change-Id: I1fd085b04ad1ee68c982d3736b322c19dd12e071
BUG: 1160900
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/9059
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 727fc1c938d80af730a8dc28735511840a2297e4
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Oct 13 04:57:54 2014 +0530
glusterd/quota : remove quota-deem-statfs and quota-timeout values when quota is disabled.
problem : If quota is disabled then all the options associated with
quota is removed, except quota-deem-statfs and quota-timeout.
When gluster volume info is issued then the user can see that quota
is disabled whereas quota-deem-statfs and quota-timeout values still
exist.
Solution : remove quota-deem-statfs and quota-timeout option when quota is
disabled
NOTE : If features.quota-deem-statfs is turned on, it takes quota limits
into consideration while estimating fs size.
Change-Id: I8cca6a8f47d2355799228643aedc8fc03896cfad
BUG: 1151933
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8924
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 569672078b7b7ede9a8372ad685304420dc2dbb1
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Jan 27 07:57:27 2015 +0000
glusterd/snapshot: Ignore failure to copy geo-rep files.
In case a new node is added to the peer, after a snapshot was
taken, the geo-rep files are not synced to that node. This
leads to the failure of snapshot restore. Hence, ignoring the
missing geo-rep files in the new node, and proceeding with
snapshot restore. Once the restore is successful, the missing
geo-rep files can be generated with "gluster volume geo-rep
<master-vol> <slave-vol> create push-pem force"
Change-Id: I1c364f8aefdd6c99b0b861b6d0cb33709ec39da2
BUG: 1181418
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/9489
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit e1b381199994ad88780c13faccde6f1c46d42bc6
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Jan 13 09:31:18 2015 +0000
glusterd/snap: Fix restore cleanup
If restore commit is successful on the originator and
a few nodes, but fails on some other node, restore cleanup
should restate the volume and the snapshot in question
as it was before the command was run.
Change-Id: I7bb0becc7f052f55bc818018bc84770944e76c80
BUG: 1181418
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/9441
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 91c5f5c65f26bf56162304976556e26ca32b5d09
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Sun Dec 21 22:01:03 2014 +0530
features/marker: do not call inode_path on the inode not yet linked
* in readdirp callbak marker is calling inode_path on the inodes that
are not yet linked to the inode table.
Change-Id: I7f5db29c6a7e778272044f60f8e73c60574df3a9
BUG: 1176393
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/9320
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit da61d9c268923e2109c3f4d65e91779fda755f50
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jan 20 14:58:34 2015 +0530
cluster/dht: In MKDIR(), aggregate iatts from non-hashed subvols too
PROBLEM:
Gathering iatts from ONLY the hashed subvol during MKDIR and unwinding
them can cause md-cache to cache and serve these values for a while to
the application.
And then, at a later point of time, when a LOOKUP on either the dir or
its parent gathers attributes from all subvolumes of dht and things are
evened out as part of DHT_UPDATE_TIME, the application could be getting
a different set of [cm]times (i.e., one of the non-hashed subvolumes'
times could be selected by virtue of having the highest values),
causing it to think the directory underwent modification even when it
might not have.
The effect of this bug becomes apparent in programs like tar, which rely
on the ctime of the files before and after archiving a file to
ascertain that the file remained unchanged during this time.
FIX:
Aggregate iatts from ALL sub-volumes of DHT during MKDIR.
Change-Id: I04c4ca3e3b9552772e2b089be680f8afeb72089e
BUG: 1179169
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9465
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 1893bff11c8fd9fcc1be657f2e087b63b1cda225
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jan 22 12:57:10 2015 +0530
performance/md-cache: Initialise local->loc before winding nameless lookup
That way, in the cbk, the latest values are updated in the cache.
Change-Id: Ia149e352e4763e8f5b910a3f4cb64d2dda4534b1
BUG: 1179169
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9476
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 6ec5ec8a65d7d01e3b7e7c2bff6c55a9d1a27ab6
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Jan 16 14:32:09 2015 +0530
geo-rep: Handle copying of common_secret.pem.pub to slave correctly.
Current Behaviour:
1. Geo-replication gsec_create creates common_secret.pem.pub file
containing public keys of the all the nodes of master cluster
in the location /var/lib/glusterd/
2. Geo-replication create push-pem copies the common_secret.pem.pub
to the same location on all the slave nodes with same name.
Problem:
Wrong public keys might get copied on to slave nodes in multiple
geo-replication sessions simultaneosly.
E.g.
A geo-rep session is established between Node1(vol1:Master) to
Node2 (vol2:Slave). And one more geo-rep session where
Node2 (vol3) becomes master to Node3 (vol4) as below.
Session1: Node1 (vol1) ---> Node2 (vol2)
Session2: Node2 (vol3) ---> Node3 (vol4)
If steps followed to create both geo-replication session is as
follows, wrong public keys are copied on to Node3 from Node2.
1. gsec_create is done on Node1 (vol1) -Session1
2. gsec_create is done on Node2 (vol3) -Session2
3. create push-pem is done Node1 - Session1.
-This overwrites common_secret.pem.pub in Node2
created by gsec_create in second step.
4. create push-pem on Node2 (vol3) copies overwrited
common_secret.pem.pub keys to Node3. -Session2
Consequence:
Session2 fails to start with Permission denied because of wrong
public keys
Solution:
On geo-rep create push-pem, don't copy common_secret.pem.pub
file with same name on to all slave nodes. Prefix master and
slave volume names to the filename.
NOTE: This brings change in manual steps to be followed to setup
non-root geo-replication (mountbroker). To copy ssh public
keys, extra two arguments needs to be followed.
set_geo_rep_pem_keys.sh <mountbroker_user> <master vol name> \
<slave vol name>
Path to set_geo_rep_pem_keys.sh:
Source Installation:
/usr/local/libexec/glusterfs/set_geo_rep_pem_keys.sh
Rpm Installatino:
/usr/libexec/glusterfs/set_geo_rep_pem_keys.sh
Change-Id: If38cd4e6f58d674d5fe2d93da15803c73b660c33
BUG: 1183229
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9460
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 6e83429217ab8ffa9b396fa9f3a44a16129b7072
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Jan 21 06:24:47 2015 +0100
glusterd: Fix spurious volume delete failure
If volume uses quota, volume delete operation should unmount the
auxiliary quota mount usin glusterd_remove_auxiliary_mount(). This
may fail with EBADF is the mount is already gone. In that situation,
ignore the error so that volume delete succeeds.
This fixes a spurious failure on NetBSD in tests/basic/quota.t 74-75
BUG: 1129939
Change-Id: I69325f71fc2c8af254db46f696c8669a4e6bd7e4
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9468
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c946d04eca683f9f624fd1979e04b0c6f3c921fd
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Dec 31 14:26:37 2014 +0530
glusterd: Fix strtok_r parsing.
Found a bug where a replica 2 volume creation prompts
saying the bricks are in the same hosts even when they
are in different hosts.
Change-Id: Ie55addae55c55e32ad2b5339530ab71f0e3711ab
BUG: 1091935
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/9373
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 7796bb97f946d2a8f2e0c905ce8b4397da1b216b
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Jan 7 09:53:52 2015 +0530
cli: volume-info <VOLNAME>, peer-status to report failure before exit
BUG: 1181203
Change-Id: I84260d66135b1980f93b258d5de58c9e6b7a8402
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9399
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 72d0caec29f287ede9a6b4e3de2f0480b565ce9b
Author: GauravKumarGarg <ggarg@redhat.com>
Date: Wed Dec 24 16:39:03 2014 +0530
glusterd: quorum validatation in glusterd syncop framework
Previously glusterd was not checking quorum validation in syncop framework.
So when there is loss in quorum then few operation (for eg. add-brick,
remove-brick, volume set) which is based on syncop framework passed
successfully with out doing quorum validation check.
With this change it will do quorum validation in syncop framework and it will
block all operation (except volume set <quorum options> and "volume reset all"
commands) when there is loss in quorum.
Change-Id: I4c2ef16728d55c98a228bb86795023d9c1f4e9fb
BUG: 1177132
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/9349
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 319381561d2ea81a16ca45ef7ff2d0626d4e6fa9
Author: Anand <anekkunt@redhat.com>
Date: Wed Jan 14 22:23:05 2015 +0530
glusterd: Added iov error checking in rpc callbacks.
Problem : glusterd was crashing with SIGABRT if rpc connection is failed in
debug mode.
Reason : It was happening due to iov is passing to assert() before checking
rpc status in rpc call back function (rpc is calling callback function with
setting rpc status as -1 and passing NULL to iov if connection is failed).
Fix : Error checking for iov added after checking the rpc status verified
and error messages are added properly .
Change-Id: I35c05c438444d0454aadac4e45524565a7be68a8
BUG: 1181543
Signed-off-by: Anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/9449
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 7450882adc54eb2e88a2f388d3193fd620da8416
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jan 19 11:17:20 2015 +0100
gfapi: allow transport=NULL for set_volfile_server()
Users of gfapi should not need to care about the supported transport
methods, this is an advanced option. Simple use-cases for libgfapi
should be able to pass NULL as transport, and the libraries should take
care of connecting to the Gluster server(s) correctly.
BUG: 1183547
Change-Id: Id93f96a3d10ae9fb69d53192642145ba8deed863
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9464
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit a55c10cbf53f7562bda1fe670a9c6ea78c5a09f2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Dec 29 15:32:28 2014 +0530
mgmt/glusterd: Implement Volume heal enable/disable
For volumes with replicate, disperse xlators, self-heal daemon should do
healing. This patch provides enable/disable functionality for the xlators to be
part of self-heal-daemon. Replicate already had this functionality with
'gluster volume set cluster.self-heal-daemon on/off'. But this patch makes it
uniform for both types of volumes. Internally it still does 'volume set' based
on the volume type.
Change-Id: Ie0f3799b74c2afef9ac658ef3d50dce3e8072b29
BUG: 1177601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9358
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c86d37154b39a9db41a92fd945050784afc107f8
Author: GauravKumarGarg <ggarg@redhat.com>
Date: Tue Jan 6 16:58:38 2015 +0530
glusterd: option features.uss should accept only boolean value
"features.uss" with a non-boolean value gets set in the volume option
table because of which subsequent volume set operation fails since
features.uss does not contain a valid boolean value.
Fix is not to allow a non-boolean value to get set in the volume option
table. "features.uss" option should have validation function "validate_uss"
which validate the input value given by user.
Change-Id: I4a212f876627a4979715183b0d488fd69095f193
BUG: 1179175
Signed-off-by: ggarg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/9395
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit ae64e799aea0a0b69d9c81b722c07598ad96bf45
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Jul 4 19:40:14 2014 -0700
doc: add documentation for DHT
Change-Id: Iaa1ea72499a81134eb57a15867e0d08dd9c55bbd
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8240
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 52250ae976a2f382d4aa3896d257bff4512201e9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Jan 16 14:26:45 2015 +0530
cluster/dht: Fix incorrect updates to parent times
In directory write FOPs, as far as updates to timestamps associated
with parent by DHT is concerned, there are three possibilities:
a) time (in sec) gotten from child of DHT < time (in sec) in inode ctx
b) time (in sec) gotten from child of DHT = time (in sec) in inode ctx
c) time (in sec) gotten from child of DHT > time (in sec) in inode ctx
In case (c), for time in nsecs, it is the value returned by DHT's child
that must be selected. But what DHT_UPDATE_TIME ends up doing is to choose
the maximum of (time in nsec gotten from DHT's child, time in nsec in inode ctx).
Change-Id: I535a600b9f89b8d9b6714a73476e63ce60e169a8
BUG: 1179169
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9457
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit b2c687b810102f0838529805710eae5bbeef8af9
Author: vmallika <vmallika@redhat.com>
Date: Thu Jan 8 16:03:04 2015 +0530
quota: For a link operation, do quota_check_limit only till the common ancestor of src and dst file
In a dht_rename, if src_cached and dst_hashed are different, then
rename is split into link and unlink.
We need to handle quota_link properly.
We have fixed quota_rename in patch# 8940, we need to handle quota_link
similarly
> http://review.gluster.org/#/c/8940/
> quota: For a rename operation, do quota_check_limit only till the
> common ancestor of src and dst file
> Example:
> set quota limit set to 1GB on /
> create a file /a1/b1/file1 of 600MB
> mv /a1/b1/file1 /a1/b1/file2
> This rename fails as it takes delta into account which sums up to 1.2BG.
> Though we are not creating new file, we still get quota exceeded error.
> So quota enforce should happen only till b1.
> Similarly:
> mv /a/b/c/file /a/b/x/y/file
> quota enforce should happen only till dir 'b'
> Change-Id: Ia1e5363da876c3d71bd424e67a8bb28b7ac1c7c1
> BUG: 1153964
> Signed-off-by: vmallika <vmallika@redhat.com>
> Reviewed-on: http://review.gluster.org/8940
> Tested-by: Gluster Build System <jenkins@build.gluster.com>
> Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
> Tested-by: Raghavendra G <rgowdapp@redhat.com>
Change-Id: I2c814018d17f7af1807c1d1d162d8bdcbb31e491
BUG: 1153964
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9419
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 2857a6af5296cb50badea6288753d7018cbe795a
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 16 13:48:49 2015 +0100
build: add a tmpfiles.d config file for /run/gluster
New distrubutions have a /run directory on a volatile tmpfs filesystem.
This causes /run/gluster to be removed with each reboot. A tmpfiles.d
configuration is used to create the directory on boot.
EL5 and EL-6 do not use /run, current Fedora versions do. By checking
%{_tmpfilesdir} in the .spec, we can identify if the distribution uses
tmpfiles.d.
Change-Id: I231e7d6603d573cb905246558e14a51577c0eb56
BUG: 1182934
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9458
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit 603a48904b335b9299ba1f7ce0d26faa524e21c0
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Jan 5 09:39:07 2015 -0500
tests: let force_umount work on multiple items
Some scripts (e.g. features/weighted-rebalance.t) try to unmount
multiple mountpoints at once, using UMOUNT_LOOP. This dutifully
passes the $* list through to force_umount, which (prior to this
fix) would only unmount $1 instead of the whole set. This would
leave those devices mounted, which would not only be a resource
leak itself but would cause other cleanup actions to fail.
Change-Id: I2e3379c85792765025540f10be7cb37b8a4c1bcf
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/9386
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 29d126b361225b2885d9013337d2f83ad35d8e17
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Jan 13 10:50:06 2015 +0100
ec: Don't use inodelk on getxattr when clearing locks
When command 'clear-locks' from cli is executed, a getxattr request
is received by ec. This request was handled as usual, first locking
the inode. Once this request was processed by the bricks, all locks
were removed, including the lock used by ec.
When ec tried to unlock the previously acquired lock (which was
already released), caused a crash in glusterfsd.
This fix executes the getxattr request without any lock acquired
for the clear-locks command.
Change-Id: I77e550d13c4673d2468a1e13fe6e2fed20e233c6
BUG: 1179050
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9440
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0bc2266d3d62fe7400de426e2760514412bbb641
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Jan 15 09:38:04 2015 +0100
ec: Remove unneeded 'inline' for ec_is_internal_xattr()
An incorrectly placed 'inline' keyword caused compilation warnings
with gcc 5.
Change-Id: I2bf8c39b1514ea7dac13e82eb3b6ff4b98e62c79
BUG: 1182267
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9452
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bfcf3eb0466bc7ae6be2db592d298e25a75a243d
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jan 13 11:52:13 2015 +0530
tests: increase PROBE_TIMEOUT value to 60 secs
Its noticed that in a slower build system, nodes may take more than 20 secs to
finish the handshaking.
One of the recent regression failure
http://build.gluster.org/job/rackspace-regression-2GB-triggered/3635/consoleFull
is the proof for it.
Change-Id: Ibb69c51f31a697d5cb23bb688db80092c1de3047
BUG: 1163543
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9438
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Anand Nekkunti <anekkunt@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a03b258109d801ff623011c50dac4ad680c8676b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jan 12 17:05:32 2015 +0530
cluster/dht: Don't restore entry when only one subvolume is present
Problem:
When rmdir fails with op_errno other than ENOENT/EACCES then self-heal
is attempted with zeroed-out stbuf. Only ia_type is filled from inode,
when the self-heal progresses, it sees that the directory is still
present and performs setattr with all valid flags set to '1' so the
file will be owned by root:root and the time goes to epoch
Fix:
This fixes the problem only in dht with single subvolume. Just don't
perform self-heal when there is a single subvolume.
Change-Id: I6c85b845105bc6bbe7805a14a48a2c5d7bc0c5b6
BUG: 1181367
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9435
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit a7c5c469b14307e2d010dd2d16e868dc5fe13fee
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Nov 10 12:41:49 2014 +0530
features/changelog: Cleanup .processing and .current directory
On changelog_register cleanup .processing, .history/.processing,
.current and .history/.current from the working directory.
Moved glusterd_recursive_rmdir and glusterd_for_each_entry to common
place(libglusterfs) and renamed as recursive_rmdir and
GF_FOR_EACH_ENTRY_IN_DIR respectively
BUG: 1162057
Change-Id: I1f98468a344cead039026762a805437b2f9e507b
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9082
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 93f1d2df8ffb40d01a464a01b9659eb99b7cb41f
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Jan 14 17:55:53 2015 +0100
NetBSD portability fix: recover errno on runner error
Some time ago we introduced F_CLOSEM to efficiently close unused
file descriptors when using a runner. But since it also close the
file descriptor used to send back errno to glusterd, it got unable
to detect an error on execve().
Fix this by backing out F_CLOSEM usage.
BUG: 1129939
Change-Id: I40d3255555145e04e8feafaa2ff4e5fb1570e9a2
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9447
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 295e635eb468ef615ecaee70eb0a775f666a7933
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Dec 17 13:19:00 2014 +0530
protocol/client: Prevent "Dereference after NULL check" errors.
Fixes 46 defects marked as "Dereference after NULL check" errors
in coverity scan for client xlator.
Change-Id: I0b4c991a3995ce74d7885fc5470ec7f5c589b411
BUG: 789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/9287
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit bc4c2b52dd4efcdf01c5f629416f639c319b6a19
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jan 14 17:10:41 2015 +0530
storage/posix: Don't try to set gfid in case of INTERNAL-mknod
Change-Id: I96540ed07f08e54d2a24a3b22c2437bddd558c85
BUG: 1088649
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9446
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 9431135e5362408d40e2a81a353630a0f46efc61
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jan 9 14:43:22 2015 +0000
cluster/afr: split-brain resolution CLI
Extend the AFR heal command to include automated split-brain resolution.
This patch [3/3] is the final patch for afr automated split-brain resolution
implementation.
"gluster volume heal <VOLNAME> [full | statistics [heal-count [replica
<HOSTNAME:BRICKNAME>]] |info [healed | heal-failed | split-brain]| split-brain
{bigger-file <FILE> |source-brick <HOSTNAME:BRICKNAME> [<FILE>]}]"
The new additions being:
1.gluster volume heal <VOLNAME> split-brain bigger-file <FILE>
Locates the replica containing the FILE, selects bigger-file as source and
completes heal.
2.gluster volume heal <VOLNAME> split-brain source-brick <HOSTNAME:BRICKNAME>
<FILE>
Selects <FILE> present in <HOSTNAME:BRICKNAME> as source and completes heal.
3.gluster volume heal <VOLNAME> split-brain <HOSTNAME:BRICKNAME>
Selects all split-brained files in <HOSTNAME:BRICKNAME> as source and completes
heal.
Note: <FILE> can be either the full file name as seen from the root of the
volume (or) the gfid-string representation of the file, which sometimes gets
displayed in the heal info command's output.
Entry/gfid split-brain resolution is not supported.
Example can be found in the test case.
Change-Id: I4649733922d406f14f28ee9033a5cb627b9538b3
BUG: 1136769
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9377
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 26e8d97e8ecff70f50f836c679942ae57dd98080
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jan 9 15:36:42 2015 +0000
api: versioned symbols for glfs_resolve()
A minor fix not addressed in http://review.gluster.org/#/c/9143/.
Needed by http://review.gluster.org/#/c/9377/5/ to resolve a merge conflict and
for a sucessful compile without warnings about implicit declarations.
Change-Id: I4aeb3b53887687096b69516c42a0888c6e137bf6
BUG: 1160709
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9439
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 84fc457253845abd05381a5eac29a909ac2c4e77
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jan 8 09:43:50 2015 +0530
rpc: initialise transport's list on creation
Initialising the transport's list, meant to hold clients connected to
it, on the first connection event is prone to race, especially with the
introduction of multi-threaded event layer.
BUG: 1181203
Change-Id: I6a20686a2012c1f49a279cc9cd55a03b8c7615fc
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9413
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 24c1fd3c721441d7814aa23fdf2c9112ed4cea11
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jan 13 11:40:03 2015 +0530
tests: move all snapshot test cases from glusterd to snapshot component
Change-Id: Id04037a38e80fe9b400678cfe6bc731cdefae834
BUG: 1178685
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9437
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 352735d20d6bf33cee59aedc0ae5a81f77906551
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Jan 12 12:19:17 2015 +0530
geo-rep: Handle Volume status error while getting slave nodes
gluster volume status command not returns xml output, when any
error like "Transaction in Progress", we need to handle returncode
along with xml error.
BUG: 1151412
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Change-Id: Id5b7712df7cff58744b4c5a0d00870aec1d926a8
Reviewed-on: http://review.gluster.org/9432
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 11729203f3a744a275dd4b09aa1319f264ec8d89
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jan 12 12:50:50 2015 +0530
storage/posix: Set gfid after all xattrs, uid/gid are set
Problem:
When a new entry is created gfid is set even before uid/gid, xattrs
are set on the entry. This can lead to dht/afr healing that file/dir
with the uid/gid it sees just after the gfid is set, i.e. root/root.
Sometimes setattr/setxattr are failing on that file/dir.
Fix:
Set gfid of the file/directory only after uid/gid, xattrs are setup
properly. Readdirp, lookup either wait for the gfid to be assigned
to the entry or not update the in-memory inode ctx in posix-acl
xlator which was producing lot EACCESS/EPERM to the application
or dht/afr self-heals.
Change-Id: I0a6ced579daabe3452f5a85010a00ca6e8579451
BUG: 1088649
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9434
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit a2e91dd3240295280274251a23d7b91703f9fc7f
Author: Shyam <srangana@redhat.com>
Date: Thu Jan 8 13:56:08 2015 -0500
fuse: Fix cores in notify function when this is executed in parallel
The fuse notify function gets called by the epoll or the poll thread
and till the point there is a single epoll thread, 2 notify
instances would not race with each other.
With the upcoming multi thread epoll changes, it is possible that
2 epoll threads invoke the notify function. As a result races
in this function are fixed with this commit.
The races seen are detailed in the bug, and the fix here is to
enforce a (slightly) longer critical section when updating the
fuse private structure and reserving state updates post error
handling.
Change-Id: I6974bc043cb59eb6dc39c5777123364dcefca358
BUG: 1180231
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/9421
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 63ecf779ce109dfd613e684432f05a930e85b02e
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Jan 9 10:15:04 2015 +0530
glusterd: quorum calculation should happen on global peer_list
Apart from snapshot, for all other transactions quorum should be calculated on
global peer list.
Change-Id: I30bacdb6521b0c6fd762be84d3b7aa40d00aacc4
BUG: 1177132
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9422
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c8f01dd34a5ff75ee145ad2c2310697436b1365e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jan 12 10:33:06 2015 +0530
storage/posix: Set correct fsgid before doing symlink
Change-Id: Ic50dfa5e5084c7b148e42a5014cca2b47c8ab5ed
BUG: 1180986
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9431
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit f709dadec42610ed9e1808903c4898babacc6f66
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Nov 18 11:08:16 2014 -0500
api: versioned symbols in libgfapi.so for compatibility
Use versioned symbols to keep libgfapi at libgfapi.so.0.0.0
Revisited to address broken build on Mac OS X
See http://review.gluster.org/9036
Rebased to include http://review.gluster.org/#/c/9376/ (glfs_resolve())
but note that gerrit's "Rebase Change" couldn't do it.
N.B. noticed that glfs_get_volumeid() decl in glfs.h was missing
the __THROW, added it.
On systems using ELF and the GNU toolchain, symbol versions are created
with a .symver asm operand in the .c source file. Clang is claimed to
be compatible with gcc, so we'll pretend for now that this also works
with clang.
On Mac OS X, aliases are created with __asm "magic" in the .h header
file. In the normal case, when both the decl and defn match, that's
all that's needed. In our case though the decl and defn don't match ---
we have, e.g. a defn such as 'int glfs_foo(...)' and the corresponding
decl is 'int pub_glfs_foo(...)'. To make this work we create the necessary
aliases in the library at link time with the -alias_list link option.
Note that this results in there being pairs of symbols in the .dylib,
e.g. _pub_glfs_foo and _glfs_foo$GFAPI_3.4.0. We could use another
link option, -unexported_symbols_list to elide the _pub_glfs_* symbols.
(And we probably should.)
Linux symbol versioning was essentially copied from Solaris; in general
I would expect this to "just work" on Solaris, but until someone tries
we don't really know.
Change-Id: Icb96a3c2d80be7b6d7a6849bb9168f03a947f47c
BUG: 1160709
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/9143
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit ed10cbb92cef34a33b5ebec7ec6ad90059aeee85
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Jan 9 10:36:38 2015 +0530
glusterd: glusterd socket files should reside in /var/run/gluster
glusterfs socket files should not reside outside of gluster folder.
Change-Id: I5d7b43b11c8c78a32df8aaf38917b80e4e33c9d0
BUG: 1180972
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9423
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 80617fee730cdb57baf172fcdff0502659df6f2d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jan 7 20:48:51 2015 +0530
tests: ancestry building quota tests on fuse mount
quota-anon-fd-nfs.t is essentially testing ancestry building code path and
quota limit reaching. Since nfs client and server on same machine leads to
deadlocks, it is better to use fuse mount to trigger these code paths. Just
stop the volume and start again, this wipes the inode table clean. Performing
writes after this will trigger ancestry building + quota checks.
Change-Id: I2d37a8662040a638d3fac3f9535d32498a5b434d
BUG: 1163543
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9408
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 3782a4d1fa18828a4e4d2ce0b2a55a3260fb2303
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Jan 10 05:49:42 2015 +0100
Spare spurious regression in quota.t
Like quota-nfs.t, quota.t shows spurious regressions because dd
writes too fast. Reuse the C program used by quota-nfs.t to
write slowly, and rename it to show it is not specific to quota-nfs.t
BUG: 1129939
Change-Id: I14b50e368023e88dc8bcc76c266cc908d62f89e2
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9410
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8728d48eb07a5f1769f59ded3facbcdf85553b7c
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jan 6 10:03:49 2015 -0500
transport: fix default behavior for SSL authorization
Previously, enabling SSL authentication/encryption but not authorization
required explicitly setting ssl-allow=*. Now that same behavior is the
default (i.e. when ssl-allow is not set).
Also, there's no reason that a name used for *login* auth (typically a
UUID for internal purposes or a human name when using SSL) should
validate as an RFC-compliant host name or IP address. Therefore the
validation only occurs when the auth type is "addr" (not "login" or
anything else).
Change-Id: I01485ff4f0ab37de4b182858235a5fb0cf4c3c7d
BUG: 1179208
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/9397
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1132088a36bbb0fe9d661bf3e359c565929ec5b6
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Jan 8 06:22:17 2015 +0100
Fix bad shell calculation in tests/basiv/afr/self-heald.t
A shell variable calculation in tests/basiv/afr/self-heald.t
resulted in spurious regression failure at test 67.
This is wrong and always produce an error: $((`date +"%j"`))%2
This still fails because date +"%j" produces 008, which is considered
an octal value: $((`date +"%j"` %2 ))
This works: $((`date +"%j"|sed 's/^0*//'` % 2 ))
BUG: 1129939
Change-Id: I5d0d27b7bb64ef7d56bafebe71aafe01eb2f39a7
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9414
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d78f3b5bfd9900c0b0ff692c79db2c33faf6ceaa
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Sat Nov 8 21:07:09 2014 +0100
ec: Remove O_APPEND from flags on create and open.
Allowing O_APPEND flag to pass through to the brick files
corrupts fragment contents because writes are not stored on
the desired place.
Write fop has been modified so that it uses current file
size as its write offset. This guarantees that all writes,
even those comming from different file descriptors and
clients, will write to the end of the file.
Change-Id: I9f721f12217a98231fe52e344166d1c94172c272
BUG: 1161621
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9079
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 98831e0770ae7c1e892dea8dec4e891cc286714d
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Fri Aug 8 09:47:10 2014 +0200
protocol/server: Fix possible memory leaks of xdata
There was a memory leak of xdata argument in fops (f)setxattr,
(f)xattrop and statfs. This leak was minor because xdata is
rarely, or even not used at all, in this fops.
Change-Id: Ie1083ae227755a11cf72f8d89595520a5afb3042
BUG: 1127653
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8434
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0be1d9a4ac8e08db1d9b92a8a67913b448bf5af2
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Dec 31 12:47:47 2014 +0530
feature/changelog: Logging entry as well for explicit sync virtual xattr.
This is an improvement over the patch 'http://review.gluster.org/9337'
to trigger explicit geo-rep sync on regular files even if entry is not
present on the slave. An attempt is made to find the pargfid and
if available captures CREATE along with DATA in changelog.
CREATE is captured with default file permissions. Setting this virtual
setxattr on directories captures MKDIR in changelog. The value of
setxattr can be as follows.
If value = "1" : Both CREATE and DATA is captured in changelog if
pargfid is available, else on DATA is captured.
value = "any other: ENOTSUP is returned.
Usage:
setfattr -n glusterfs.geo-rep.trigger-sync -v "1" <file-path>
NOTE: This patch supports explicit record of entries only for
directories and regular files.
Change-Id: Iedde8b2c8bc3b78db524050d8c866ff664811d01
BUG: 1176934
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9370
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 9d46a2ea74cda6f670dc3747117c43f67b529afc
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jan 5 16:21:52 2015 +0530
cluster/ec: Handle internal xattr get/set
Problem:
Internal xattrs of EC like trusted.ec.size/config/version
can be modified by users and that can lead to misbehavior
in EC.
Fix:
Don't let the user modify the xattrs. Hide these xattrs
in getfattr outputs.
Change-Id: I39cec96ae12826b506b496fda7da74201015fd75
BUG: 1178688
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9385
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit cf00552693661b3c4406c0ab1a81ac5ae0f70109
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jan 7 12:08:48 2015 +0530
cluster/ec: Do not modify quota, selinux xattrs in healing
Problem:
EC heal tries to heal quota-size, selinux xattrs as well. quota-size is
private to the brick but since quotad accesses them using the standard
interface as well, they can not be filtered in the fops.
Fix:
Ignore QUOTA_SIZE_KEY and SELINUX xattrs during heal.
Change-Id: I1572f9e2fcba7f120b4265e034953a15ff297f04
BUG: 1179640
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9401
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ac800da505fbe80cc1ca58314f0d46138d31b7bd
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Jan 8 08:35:33 2015 +0000
glusterd: use list_for_each_entry_safe for cleanup
Use list_for_each_entry_safe() instead of
list_for_each_entry() for cleanup of local
xaction_peers list.
Change-Id: I6d70c04dfb90cbbcd8d9fc4155b8e5e7d7612460
BUG: 1173414
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/9416
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 2c4f5e4e5183ca5f787a32a40f87d58f2ccf1ff8
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Jan 6 07:40:32 2015 +0000
glusterd: Refactor glusterd-utils.c
Refactor glusterd-utils.c to create
glusterd-snapshot-utils.c consisting of all snapshot
utility functions.
Change-Id: Id9823a2aec9b115f9c040c9940f288d4fe753d9b
BUG: 1176770
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/9391
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 3022c375206c552bd548f08fa56810a244ac3f15
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Jan 7 15:16:32 2015 +0530
avoid memory leaks in snapview-server
* snapview-server in readdirp, creates the inode for entries with names "." and
".." for each readdirp operation without creating dentries leading to memleak.
It should have avoided creation of inodes for those entries
Change-Id: I3b2025fd10872fcc3303d0becec764ffd4e37601
BUG: 1179663
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/9404
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3b854a3b889a388e7947b020f61a5adde74f404c
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Jan 6 04:26:09 2015 +0530
test : removing quota-anon-fd-nfs.t for time being.
I am removing quota-anon-fd-nfs.t for time being as it is causing
lots of regression failure. Meanwhile I will be working in parallel
to find out the root cause for this spurious failure in another patch
(http://review.gluster.org/#/c/9381/). I'll revert this patch once a proper fix is found.
Change-Id: I0ef205241219ed3210d58d2b487f1b00292115f0
BUG: 1163543
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/9390
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 6443498c86294131bddefed111266166b7ef15e8
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jan 1 15:55:22 2015 +0000
api: export glfs_resolve()
glfs_resolve() is an internal function in libgfapi. Export it so that it can be
used by glfs-heal.c. The change is done in line with the approach followed in
commit 7e497871d11a3a527e2ce192e4274322631f27d0 (http://review.gluster.org/9036)
This patch [2/3] is required as a part of afr automated split-brain resolution
implementation.
Change-Id: If9057f2a037fd25a0dfa231683bfbaa72d3cb1b2
BUG: 1136769
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9376
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 87653bba6fc940adb4c95abd2cc205e67dcdfec6
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Dec 26 12:18:31 2014 +0530
glusterd: cluster quorum count check correction
Due to the recent change introduced by commit
da9deb54df91dedc51ebe165f3a0be646455cb5b cluster quorum count calucation now
depends on whether the peer list is either all peers or global transaction peer
list or the local transaction peer list.
Change-Id: I9f63af9a0cb3cfd6369b050247d0ef3ac93d760f
BUG: 1173414
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9350
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit fc2b634cecbeaf413ac470dd2f0d46dd56356039
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Dec 26 12:57:48 2014 +0100
tests: move all test-cases into component subdirectories
There are around 300 regression tests, 250 being in tests/bugs. Running
partial set of tests/bugs is not easy because this is a flat directory
with almost all tests inside.
It would be valuable to make partial test/bugs easier, and allow the use
of mulitple build hosts for a single commit, each running a subset of
the tests for a quicker result.
Additional changes made:
- correct the include path for *.rc shell libraries and *.py utils
- make the testcases pass checkpatch
- arequal-checksum in afr/self-heal.t was never executed, now it is
- include.rc now complains loudly if it fails to find env.rc
Change-Id: I26ffd067e9853d3be1fd63b2f37d8aa0fd1b4fea
BUG: 1178685
Reported-by: Emmanuel Dreyfus <manu@netbsd.org>
Reported-by: Atin Mukherjee <amukherj@redhat.com>
URL: http://www.gluster.org/pipermail/gluster-devel/2014-December/043414.html
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9353
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 112d2c09e16f3c6c058fd755d374f3c7ebd3da38
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jan 1 15:16:41 2015 +0000
libglusterfs: change signature of syncop_(f)getxattr
Pass xdata dict to syncop_(f)getxattr calls.
This patch [1/3] is required as a part of afr automated split-brain resolution
implementation.
Change-Id: I3970b3dd6daf64681a031e37f8e9afb14fb3d668
BUG: 1136769
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9375
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d824158818187cbcb6b01b97d2255d69243bd387
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Jan 5 16:02:40 2015 +0530
cli: logging improvements
1. cli used to log messages at all log levels. This is related to
a peculiar behavior of gcc which treats any enum variable whose type
has non-negative only defined values to be an unsigned integer.
This would cause cli's loglevel (defaulted from state->loglevel) to be
set as (uint)-1 previously and hence all log messages across
levels would appear in the cli log file. Now cli's loglevel defaults to
log level INFO.
2. Changed logging level of messages of type "Returning %d".. to DEBUG.
Change-Id: I05094e523fc277d9ad32cc9d76aee873c0fd3859
BUG: 1168809
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/9383
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 424bcb3c0eab5f8c625154ee8eade82fb9aa7d19
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Dec 31 15:15:53 2014 +0530
cluster/afr: serialize inode locks
Problem:
Afr winds inodelk calls without any order, so blocking inodelks
from two different mounts can lead to dead lock when mount1 gets
the lock on brick-1 and blocked on brick-2 where as mount2 gets
lock on brick-2 and blocked on brick-1
Fix:
Serialize the inodelks whether they are blocking inodelks or
non-blocking inodelks.
Non-blocking locks also need to be serialized.
Otherwise there is a chance that both the mounts which issued same
non-blocking inodelk may endup not acquiring the lock on any-brick.
Ex:
Mount1 and Mount2 request for full length lock on file f1. Mount1 afr may
acquire the partial lock on brick-1 and may not acquire the lock on brick-2
because Mount2 already got the lock on brick-2, vice versa. Since both the
mounts only got partial locks, afr treats them as failure in gaining the locks
and unwinds with EAGAIN errno.
Change-Id: Ie6cc3d564638ab3aad586f9a4064d81e42d52aef
BUG: 1176008
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9372
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit cfce669f8b59beeba1805e6ead7088d86d263d37
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Dec 24 14:11:42 2014 +0530
tests: return non-zero value instead of exit in functions within the test run
using 'exit 1' would terminate the test script which means cleanup
will never get triggered for that test run which is incorrect.
Instead use 'return 1'.
Change-Id: I48c36cff4b2ddfcc2bd8ceb85484720161fe58f0
BUG: 1163543
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9333
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit ac0fcc80fce7990928c3d02d060506e5b21aa391
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Jan 2 12:28:12 2015 +0530
features/uss: Perform NULL check on @name in svc_getxattr
LISTXATTR fop is internally converted into a GETXATTR with
the "name" parameter set to NULL. In svc_getxattr(), a listxattr
was causing a crash because of a NULL pointer dereference on @name.
FIX:
Add the necessary NULL check.
Change-Id: I70024d40dc0695648c6d41b423c2665d030e1232
BUG: 1178079
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9378
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bd5c1bee24f9f92cfcf59eeb5a68d6c83aa59a7d
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Dec 24 14:17:21 2014 +0100
Do not use umount -l on non Linux systems
Lazy unmount are only supported on Linux. Force umount instead, since
this code path is used in emergency exit anyway.
On NetBSD, just have the filesystem calling exit, the kernel will unmount.
BUG: 1129939
Change-Id: If623ebf60b7a747ea7e78034b6d71ec2241dea4a
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9334
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 04e94534da9c20b56242934b6b86d03233ff4a10
Author: Anuradha <atalur@redhat.com>
Date: Tue Dec 30 18:54:33 2014 +0530
afr: Fixes to commit 85427a23c238499137cbfaafdb7b6ad27f67506a
* Fixed a dict leak
* Re-added 'return on failure' check
Change-Id: I07edd03e4608fd2b7c4a91019a0e43033e6e78b2
BUG: 1163804
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/9368
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 2f0621875ea8e11f293ec67d4d86b5c20799f69f
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Dec 30 17:16:57 2014 +0530
build: Remove files completely in make uninstall.
If we create symlinks are part of make install,
should remove them as part of make uninstall.
Change-Id: Ie6e641caed60104cd256de4f020c1c6743d4ae60
BUG: 1177767
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/9367
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit ece90f7883107579074006dbd11044a2899a1df7
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Nov 12 17:36:37 2014 +0530
doc: added did-you-know.md to document the less-known
behaviours and features of GlusterFS
Change-Id: Ibabc6398be9fb1c20127aaad2c51a629fed7c10b
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9103
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit c3862440fe9a2caa6b4a020213d0bdf97df886f1
Author: Kotresh HR <khiremat@redhat.com>
Date: Tue Dec 30 10:47:49 2014 +0530
test: Make gfid-access.py more generic.
Few of the hard coded values, uid, gid and file permissions
are made as arguments to make the script more generic.
Also fixes the permission issue which was hard coded
as integer instead of octal.
Change-Id: Icec700770de2b7cae00e02f783d072860e6d5e2b
BUG: 1176934
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9366
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 943bb39b454240c68a003d3b02dd0a4490cdd07e
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Dec 26 19:12:22 2014 +0530
geo-rep: Error handling in tar+ssh mode
Georep raises exception if tar+ssh fails and worker
dies due to the exception.
This patch adds resilience to tar+ssh error and geo-rep
worker retries when error, and skips those changelogs
after maximum retries.(same as rsync mode)
Removed warning messages for each rsync/tar+ssh failure
per GFID, since skipped list will be populated after Max
retry. Retry changelog files log also available, hence
warning message for each GFID is redundent.
BUG: 1177527
Change-Id: I3019c5c1ada7fc0822e4b14831512d283755b1ea
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/9356
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 3de95826afdc664c8639266a2f88578a336112af
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Dec 24 21:26:28 2014 +0530
feature/changelog: Virtual xattr to trigger explicit sync in geo-rep.
A virtual xattr "glusterfs.geo-rep.trigger-sync" is provided
in glusterfs through changelog translator. Geo-rep triggers
a explicit data sync on setting this xattr on a file.
Changelog captures a DATA entry on file's gfid on setting this
virtual xattr on a file. This is supported only for files. It
doesn't support directories.
Usage: setfattr -n glusterfs.geo-rep.trigger-sync <file-path>
Change-Id: Ia689326ac2dcb31035ffbecad2c548eda4eb9245
BUG: 1176934
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9337
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 20ce307d3b7ddc2aff00d60d45b4c3874f90bb1b
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Dec 19 16:36:25 2014 +0530
glusterd: Move statedump utils into a new file.
Change-Id: I1bf26c9d294e95f7b82cfc7a96f9d5575f5e0362
BUG: 1176770
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9313
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 1b57f563f3e5fa3d5aa24685c3b3998fec5cf99a
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Dec 18 09:18:12 2014 +0530
glusterd: check_volume_exists should query in-memory representation
... instead of consulting the on-disk data directory. There is no reason
why the on-disk is more accurate than the in-memory representation. In
fact, it is the other way around when a node is reconciling
volume/cluster configuration with the rest of the cluster.
Change-Id: I786823efdf1d0f6b9e6fcdb72d51e5227c399ce1
BUG: 1176770
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9292
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 390479ea3294f316adf4b4420cb9aa82bff7e21f
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Dec 26 10:12:11 2014 +0530
glusterd: coverity fix for overrun in glusterd_stop_uds_listener
CID: 1260432
Change-Id: I6845bc4c231b53428419a5a2ad0c78ea9da31058
BUG: 1093692
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9338
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c44079f26796b6470cdd43957188e3227325b6bb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Dec 26 10:36:00 2014 +0530
mgmt/glusterd: Add option to enable lock trace
Change-Id: I24ed0f866d53e91a8323c043a38f73207cbfd7d2
BUG: 1168189
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9351
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c50d7d12039dd3bd501cd91ec79339647521a3b0
Author: vmallika <vmallika@redhat.com>
Date: Wed Dec 24 15:13:36 2014 +0530
quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file
Example:
set quota limit set to 1GB on /
create a file /a1/b1/file1 of 600MB
mv /a1/b1/file1 /a1/b1/file2
This rename fails as it takes delta into account which sums up to 1.2BG.
Though we are not creating new file, we still get quota exceeded error.
So quota enforce should happen only till b1.
Similarly:
mv /a/b/c/file /a/b/x/y/file
quota enforce should happen only till dir 'b'
Change-Id: Ia1e5363da876c3d71bd424e67a8bb28b7ac1c7c1
BUG: 1153964
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8940
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 40c6fe3a61dc92a1f0b33fd569bf3b360a6e1dca
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Nov 17 14:27:47 2014 +0530
cluster/afr: Make entry-self-heal in afr-v2 compatible with afr-v1
Problem:
entry self-heal in 3.6 and above, takes full lock on the directory only for the
duration of figuring out the xattrs of the directories where as 3.5 takes locks
through out the entry-self-heal. If the cluster is heterogeneous then there is
a chance that 3.6 self-heal is triggered and then 3.5 self-heal will also
triggered and both the self-heal daemons of 3.5 and 3.6 do self-heal.
Fix:
In 3.6.x and above get an entry lock on a very long name before entry self-heal
begins so that 3.5 entry self-heal will not get locks until 3.6.x entry
self-heal completes.
Change-Id: I71b6958dfe33056ed0a5a237e64e8506c3b0fccc
BUG: 1168189
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9227
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit da0d4b26c1499deec8b0029b5fd31c2e92949413
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Nov 14 14:23:31 2014 +0530
features/locks: Add lk-owner checks in entrylk
For backward compatibility of entry-self-heal we need
entrylks to be accepted by same lk-owner and same client.
This patch introduces these changes.
Change-Id: I67004cc5e657ba5ac09ceefbea823afdf06929e0
BUG: 1168189
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9125
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bccd4cbe368da99a268883219182c01b671027a6
Author: Anand Avati <avati@redhat.com>
Date: Tue Dec 23 10:04:00 2014 -0800
afr: stop encoding subvolume id in readdir d_off
The purpose of encoding d_off in AFR is to indicate the
selected subvolume for the first readdir, and continue all
further readdirs of the session on the same subvolume. This is
required because, unlike files, dir d_offs are specific to the
backend and cannot be re-used on another subvolume. The d_off
transformation encodes the subvolume id and prevents such
invalid use of d_offs on other servers.
However, this approach could be quite wasteful of precious d_off
bit-space. Unlike DHT, where server id can change from entry to
entry and thus encoding the server id in the transformed d_off
is necessary, we could take a slightly relaxed approach in AFR.
The approach is to save the subvolume where the last readdir
request was sent in the fd_ctx. This consumes constant space (i.e
no per-entry cache), and serves the purpose of avoiding d_off
"misuse" (i.e using d_off from one server on another).
The compromise here is NFS resuming readdir from a non-0 cookie
after an extended delay (either anonymous FD has been reclaimed,
or server has restarted). In such cases a subvolume is picked
freshly. To make this fresh picking more deterministic (i.e, to
pick the same subvolume whenever possible, even after reboots),
the function afr_hash_child (used by afr_read_subvol_select_by_policy)
is modified to skip all dynamic inputs (i.e PID) for the case
of directories.
Change-Id: I46ad95feaeb21fb811b7e8d772866a646330c9d8
BUG: 1163161
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/9332
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 16870e8563ef016085eee5b45353105da3ce2f73
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Jun 23 22:59:14 2014 +0530
features/marker: log message clean up
1. Changed log messages to be more appropriate.
2. Changed loglevel of failures in fop_cbks to be recorded as TRACE.
Logging of failures at higher loglevels is unessential in non-endpoint
translators.
3. Removed a log message related to memory allocation failure.
BUG: 1174087
Change-Id: I63c560c3bbd12706357fb3f696378c1a1e1efb44
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/8168
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 30ad616d0493ba1dd5a80c41ecb7d4bcde5e2fee
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Dec 23 21:13:32 2014 +0530
geo-rep: Sync atime, mtime to slave when SETATTR
Existing geo-rep only syncs chown and chmod, with this
patch geo-rep also syncs atime and mtime.
Change-Id: Iea52d86682873bb4a47eeb0d325f5b9ddf2de2cf
Signed-off-by: Aravinda VK <avishwan@redhat.com>
BUG: 1176934
Reviewed-on: http://review.gluster.org/9331
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 224e5b58e7d6a33a62ea66e3a734d4d61193b544
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Dec 19 16:38:43 2014 +0530
afr: coverity fixes
Some fixes for the 17th Dec 2014 run.
https://scan6.coverity.com:8443/reports.htm#v31028/p10714/g31029
Change-Id: Ia4410ef87a56fffb61803d0a4e62369b058e1cfb
BUG: 1176089
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9314
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit c229a362ae9fe2c93a4cc2722b966dcdbc48122e
Author: Anuradha <atalur@redhat.com>
Date: Fri Dec 12 12:56:22 2014 +0530
cluster/afr : Change in volume heal info command
gluster volume heal <volname> info command
will now also display if the files listed (in the output
of the command) are in split-brain or possibly being
healed.
This patch also fixes build warning that occurs.
Change-Id: I1fc92e62137f23b2b9ddf6e05819cee6230741d1
BUG: 1163804
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/9119
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 0fa27c8c9fe033f8954a99e8f9d925ed4a1f068c
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Dec 19 17:07:50 2014 +0530
glusterd: fix unix domain notify fn
... and unlink the 'right' socket file
Change-Id: Id12ee8c622914555b7933104e13b43b3b31b5d19
BUG: 1176770
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9315
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit 2c018e6ca4b5e4ec73df5dfece6bcfccf6991d24
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Dec 23 06:54:50 2014 +0100
Avoid spurious directory metedata split brain
When directory content is modified, [mc]time is updated. On
Linux, the filesystem does it, while at least on NetBSD, the
kernel file-system independant code does it. This means that
when entries are added while bricks are down, the kernel sends
a SETATTR [mc]time which will cause metadata split brain for
the directory. In this case, clear the split brain by finding
the source with the most recent modification date.
BUG: 1129939
Change-Id: Ic0177e0df753a4748624d0b906834ed54593adb9
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9291
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 43ff47ceff6340545e1df5c9b77893f2ffd0736d
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Dec 12 07:21:19 2014 +0530
glusterd: Maintain per transaction xaction_peers list in syncop & mgmt_v3
In current implementation xaction_peers list is maintained in a global variable
(glustrd_priv_t) for syncop/mgmt_v3. This means consistency and atomicity of
peerinfo list across transactions is not guranteed when multiple syncop/mgmt_v3
transaction are going through.
We had got into a problem in mgmt_v3-locks.t which was failing spuriously, the
reason for that was two volume set operations (in two different volume) was
going through simultaneouly and both of these transaction were manipulating the
same xaction_peers structure which lead to a corrupted list. Because of which in
some cases unlock request to peer was never triggered and we end up with having
stale locks.
Solution is to maintain a per transaction local xaction_peers list for every
syncop.
Please note I've identified this problem in op-sm area as well and a separate
patch will be attempted to fix it.
Finally thanks to Krishnan Parthasarathi and Kaushal M for your constant help to
get to the root cause.
Change-Id: Ib1eaac9e5c8fc319f4e7f8d2ad965bc1357a7c63
BUG: 1173414
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9269
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 3abfa933a1ba93a99516119e8ff41faee36ceec8
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Dec 19 18:27:14 2014 +0100
gfapi: always close the fd in glfs_h_creat()
When running stress and performance tests against nfs-ganesha, the
number of open file descriptors increases continously. If the tests run
long enough, the brick processes will eventually run out of file
descriptors.
This seems to be caused by glfs_h_creat() which allocates a 'struct
glfs_fd', but does not release it. A normal glfs_creat() returns the
file descriptor to the application, whereas glfs_h_creat() returns a
handle (struct glfs_object). The file descriptor associated with the
handle can not be release by glfapi-applications.
This fd-leak can be prevented by destroying the 'struct glfs_fd' before
returning the 'struct gfls_object' to the gfapi-application.
Change-Id: I32465077a35cd0449a8e584c53899b32f022e5af
BUG: 1176242
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9318
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 70522f4866b209015a9fed9b1abd2125ea4507e2
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Sep 5 07:32:20 2014 +0000
glusterd: Returning success from mgmt_v3 handler functions
The mgmt_v3 handler functions already send the ret code as
part of the *send_resp calls, and further propagating the
ret code to the calling functions will lead to double deletion
of the req object. Hence returning success from the mgmt_v3
handler functions.
Change-Id: I1090e49c54a786daae5fd97b5c1fbcb5d819acba
BUG: 1138577
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/8620
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit bc897c47d65b162c083561e1c8ef6c16eea16c13
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Dec 17 11:20:20 2014 +0000
glusterd: Copy brick port no. if brick is running
Instead of relying on brickinfo->status, check if the brick
process is running before copying the brick port number.
Change-Id: I246465fa4cf4911da63a1c26bbb51cc4ed4630ac
BUG: 1175700
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/9297
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 9d0d7a01417e058adbe74293bcd3641257bc6c7f
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Dec 16 12:34:19 2014 +0530
mgmt/glusterd: do not restart nfs server when snapshot is deactivated
Change-Id: Ie5eaa2beb4446640b22873f91e17da90d1cd8fad
BUG: 1174625
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/9280
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit d62ac0a951e0749a6178d990571b58787ceaa82a
Author: Humble Devassy Chirammal <hchiramm@redhat.com>
Date: Thu Dec 11 12:50:14 2014 +0530
MAINTAINERS: Adding new sub maintainers.
http://supercolony.gluster.org/pipermail/gluster-devel/2014-December/043177.html
Change-Id: Iec587f383cf8da9832932194e2518a6bd99c6380
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9266
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit db04a50e6adaae3d48e69aea5400445d8f7c5660
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Dec 16 19:01:20 2014 +0530
performance/readdir-ahead: indicate EOF for readdirp
posix xlator sends op_errno as ENOENT and op_ret as 0, to indicate readdir has
been completed. readdir-ahead should send that op_errno that it has saved in the
fd context, when it serves the readdir requests. Otherwise some xlators sitting
above performance xlators such as snapview-client, which checks for end of
readdir operation by checking op_ret to 0 and op_errno to ENOENT will not be
able to identify end of readdir.
Change-Id: Ib0835136c61cb1e0d7df933226c479c7db703a71
BUG: 1174783
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/9283
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e6e8e677966083b06f1b5873ae2602b2209cde2e
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Dec 10 13:28:17 2014 +0100
ec: Fix more mutex related coverity scan issues
This patch solves CID 1257622.
Change-Id: I95680c7de49cd84011d2ad38f02e5fad82e15c90
BUG: 1170254
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9263
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 277b8eee08af549bee1c132661e399ca2c1f04ae
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Dec 16 17:06:20 2014 +0100
Regression test portability: ec.t
This test unmount/remount the filesystem to invalidate cache,
but this leads to timing problems on NetBSD. We can work them
around without sleeping by remounting on another mount point.
BUG: 1129939
Change-Id: I10b3183e5e715053de162a6980af188710b607bb
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9285
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit a4ae2d7dc7704fb3d5ee11509a86c58985e43d27
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Dec 17 10:41:05 2014 +0100
telldir()/seekdir() portability fixes
POSIX says that an offset obtained from telldir() can only be used
on the same DIR *. Linux is abls to reuse the offset accross
closedir()/opendir() for a given directory, but this is not portable
and such a behavior should be fixed.
An incomplete fix for the posix xlator was merged in
http://review.gluster.com/8926
This change set completes it.
- Perform the same fix index xlator.
- Use appropriate casts and variable types so that 32 bit signed
offsets obtained by telldir() do not get clobbered when copied into
64 bit signed types.
- modify glfs-heal.c and afr-self-heald.c so that they do not use
anonymous fd, since this will cause closedir()/opendir() between
each syncop_readdir(). On failure we fallback to anonymous fs
only for Linux so that we can cope with updated client vs not
updated brick.
- Avoid sending an EINVAL when the client request for the EOF offset.
Here we fix an error in previous fix for posix xlator: since we
fill each directory entry with the offset of the next entry, we
must consider as EOF the offset of the last entry, and not the
value of telldir() after we read it.
- Add checks in regression tests that we do not hit cases where
offsets fed to seekdir() are wrong. Introduce log_newer() shell
function to check for messages produced by the current script.
This fix gather changes from http://review.gluster.org/9047
and http://review.gluster.org/8936 making them obsolete.
BUG: 1129939
Change-Id: I59fb7f06a872c4f98987105792d648141c258c6a
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9071
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 9a31fb29cdba2ec52eed624a5f289749938da67b
Author: vmallika <vmallika@redhat.com>
Date: Thu Dec 11 11:18:03 2014 +0530
uss/gluster: In SVS, check for entry-point in dict only if inode_ctx is not available
Change-Id: I990487003b712bf4aed8f54291417965f301655e
BUG: 1172430
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9265
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit f38c374490fabb7e7854b7762ef90537c531721e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Dec 15 17:18:06 2014 +0530
gfapi: use different name for GETSPEC callback than the one used by glusterfsd
Change-Id: Ibd5be1e1080f9da4ac1fb9112538b3320ef2ff28
BUG: 1174205
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/9277
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit a42f9e0a060bbfa79cbf6bbd454207baed1773d0
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Dec 12 14:12:35 2014 +0100
build: prevent double packaging of geo-replication and other scripts
The regression-tests sub-package contains /usr/share/glusterfs/* instead
of including only the needed files. This causes some of the scripts that
are part of geo-replication to be packaged twice.
BUG: 1169005
Change-Id: Ib452e73f3c1775b252ab257aab852ad9af857e74
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9272
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 2a23e16a7db00e60ecbb1376130b798a10738680
Author: Morten Johansen <morten@bzzt.no>
Date: Thu Nov 6 12:05:24 2014 +0100
Update admin_distributed_geo_rep.md
Fixed typo
Change-Id: If4281237394ed96b32ec2d6227827214908052cf
Signed-off-by: Justin Clift <justin@gluster.org>
Reviewed-on: http://review.gluster.org/9268
Reviewed-by: M S Vishwanath Bhat <vbhat@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5c45ae06d72ef506e7776ddc122d529145821fc2
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Dec 9 23:20:18 2014 +0530
features/snapview-client: handle fsync fop
Change-Id: Idaf46bd7497266af837789b09a0c62698f56ee4e
BUG: 1172262
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/9258
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cd9500584e677f54dd33098e143867f71120e009
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Dec 4 15:40:52 2014 +0100
fuse: protect checking/modifying graph->used with a mutex
While reviewing http://review.gluster.org/#/c/9060/ we noticed that fuse
checks/modifies graph->used in a unlocked way. There is a potential race
in case when fuse_graph_setup() gets called from two different threads
(currently unlikely, but poller/notify() might change in future?).
In libgfapi we came to the conclusion that each glfs structure can be
used to protect the checking/updating of graph->used. In fuse this would
be the fuse_private_t with sync_mutex.
BUG: 1170643
Change-Id: If5ab5468d22fdb92cfb24a469f538f63f12baf78
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9237
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit ebb5038a24669215ff399e92d30e5f8bdcbcd254
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sun Dec 7 16:57:54 2014 -0800
build: FreeBSD 11-Current causes libtool to fail with '-shared'
Thanks for Markiyan Kushnir <markiyan.kushnir@gmail.com> for
reporting this
Change-Id: I7f637295c7c2d54c33a4c16e29daf0b518874911
BUG: 1111774
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/9251
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 6a49b686a69751fc1ff7aec0a5f3560e43019bc7
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Dec 10 11:10:52 2014 +0100
client_t: fix for potential NULL pointer dereference
In case an error occurs, 'client' is free'd. The log message just before
exiting the function should therefore not use the structure anymore.
BUG: 789278
Change-Id: I0848328b29585057cd037a5972c4e5f06a7f978b
CID: 1226165
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9262
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 99840d5f0b9e988bdb0777da26cf12e4f22d0348
Author: Jan-Hendrik Zab <zab@l3s.de>
Date: Thu Dec 4 23:41:09 2014 +0100
Stop logrotate from complaining about missing files.
Previously logrotate reported errors for files missing in
"/var/log/glusterfs/geo-replication-slaves/*/*.log". Fixed by reordering
directives in the example config.
Change-Id: I7cdb9e0d82f08aa27d5e26664660204fdeb8e98e
BUG: 1170825
Signed-off-by: Jan-Hendrik Zab <zab@l3s.de>
Reviewed-on: http://review.gluster.org/9264
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit d8069ac0dbb3f35eac62a53c24e749bae96f5fb6
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Aug 25 16:21:08 2014 +0530
rpc/rpcsvc: add peername to log messages
This would allow users/developers to associate rpc layer log messages
to the corresponding connection.
Change-Id: I040f79248dced7174a4364d9f995612ed3540dd4
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/8535
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 367d1dc9660156e5bee0f0430eccf5b46d133384
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 9 10:57:10 2014 +0530
storage/posix: Set errno for xattrop failures
Change-Id: I4d44068c8da5257227d62906ec18ae16f6ed6c02
BUG: 1172477
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9261
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 5dc4d595a47f27c96079c9677495968e444a32a9
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Dec 9 12:24:38 2014 +0100
nfs: prevent potential NULL dereference in mnt3_readlink_cbk()
In case 'mres' is NULL, we jump to 'mnterr' where 'mres->req' will be
used. This will cause a segmentation fault, which we really do not want.
Change-Id: I01d6f3aa0343def54dcd4a5610001ff7d62c8834
CID: 1256179
BUG: 789278
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9257
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 2bc3e5303b2b9e0290596cb4c57b59b107a29220
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Nov 28 18:08:53 2014 +0530
features/snapview-client: handle readdir requests differently for samba
* For samba export, the entry point is also added to the readdir response.
Change-Id: I825c017e0f16db1f1890bb56e086f36e6558a1c2
BUG: 1168875
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/9218
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c91fb3ff1401cc0757805554a161a9470cdbe614
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Dec 5 14:35:08 2014 +0530
cluster/afr: Associate the inode returned by inode_link() with corresponding entry
Change-Id: Ic4436a64075a2615a2293cdfdf2ba6622827cafa
BUG: 1129939
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9254
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 7350db4d6307d27d9a87e036c289051bf8eb173e
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Nov 28 17:54:52 2014 +0530
api, glusterfsd: Cleanup upon failure in glusterfs_ctx_defaults_init()
This got introduced due to 656711d935000c16. Coverity
also picked this up as CIDs 1256176, 1256178, 1256180.
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Change-Id: If12fa0075634383975846181917a2f9650f790e3
BUG: 789278
Reviewed-on: http://review.gluster.org/9213
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit a6aeadba23b9fa3471707d11f3aa31c513c82c05
Author: GauravKumarGarg <ggarg@redhat.com>
Date: Fri Nov 28 12:02:20 2014 +0530
glusterd: Coverity fix for string_overflow overrun
In function glusterd_dump_peer() it is copying "input_key" into "key"
buffer without checking the length which might cause string_overflow
overrun. Similar problem with other coverity issue.
With this fix it will copy "input_key" into "key" buffer by maximum
length of buffer.
Coverity CID: 1256171
Coverity CID: 1256172
Coverity CID: 1256174
Change-Id: I4e092309d9503bd79ff82cf83ed5e8d758743453
BUG: 1093692
Signed-off-by: Gaurav Kumar Garg ggarg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/9208
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 8bc22d8c2c273f0b99b2fb819291a8326b092b6e
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Mon Dec 8 14:25:22 2014 +0530
gfapi: new inode created in glfs_resolve_component even if inode is in inode table
problem: USS allows split-brain file to be accessed while main volume
gives I/O error.
cause:
AFR detects split-brain on lookup. It stores this information in
inode context. open and readv fop checks this flag from inode context.
open and readv fop fails if split-brain flag is set for the file.
USS uses gfapi to access snapshot volume. During open call
gfapi internally calls glfs_resolve_component. glfs_resolve_component
generates a new inode even if inode is present for the file.
Because of which afr_lookup acts on a new inode which does not
contain the split-brain flag.
Bug: 1171615
Change-Id: I1b4fddf4bd3c734a319ecfae804a3439866d157c
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/9253
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit d5d37350d41254e327b5b3c5f0af02a0b934b8a1
Author: Anoop C S <achiraya@redhat.com>
Date: Wed Oct 29 09:12:46 2014 -0400
libgfapi: Wait for GF_EVENT_CHILD_DOWN in glfs_fini()
Whenever glfs_fini() is being called, currently no
check is made inside the function to determine whether
the child is already down or not. This patch will wait
for GF_EVENT_CHILD_DOWN for the active subvol and
then exits.
TBD:
Apart from the active subvol, wait for other CHILD_DOWN
events generated through operations like volume set in
future.
Change-Id: I81c64ac07b463bfed48bf306f9e8f46ba0f0a76f
BUG: 1153610
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/9060
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit f495f1433dd5761324fcb76984ecda305f9bfac9
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Fri Dec 5 19:46:53 2014 +0530
rdma:vectored write fails for rdma.
For rdma write with payload count greater than one
will fail due to insuffient memory to hold the
buffers in rpc transport layer. It was expecting
only one vector in payload, So it can only able
to decode the first iovec from payload, and the
rest will be discarded.
Thnaks to Raghavendra Gowdappa for fixing the
same.
Change-Id: I82a649a34abe6320d6216c8ce73e69d9b5e99326
BUG: 1171142
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9247
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 146173161d60b7e8a706958eb590cf34187288d9
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Dec 1 09:21:32 2014 +0100
build: only install geo-rep scripts when enabled
When geo-replication is not enabled, the related scripts should not get
installed. EPEL-5 does not support geo-replication, and the installed
but unpackaged scripts cause rebuilding for .el5 to fail.
BUG: 1169005
Change-Id: I1b6a352b73bd1ed1c5b330f54e26e81aed9a5a4e
Reported-by: Lalatendu Mohanty <lmohanty@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9221
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4941e782a84e7605f95010111a60c6d6789345df
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Nov 11 18:45:01 2014 +0100
ec: Fix return errors when not enough bricks
Changes introduced by this patch:
* Fix an incorrect error propagation when the state of the life
cycle of a fop returns an error.
* Fix incorrect unlocking of failed locks.
* Return ENOTCONN if there aren't enough bricks online.
* In readdir(p) check that the fd has been successfully open by
a previous opendir.
Change-Id: Ib44f25a1297849ebcbab839332f3b6359f275ebe
BUG: 1162805
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9098
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4b1fb484e15959347c47bfc478689a74cb6d1aed
Author: Jan-Hendrik Zab <zab@l3s.de>
Date: Thu Dec 4 14:06:15 2014 +0100
Fixed small typo in marker.c
Change-Id: Iec89e7141f6ff3216355d8a6b971617e16df679b
BUG: 1075417
Signed-off-by: Jan-Hendrik Zab <zab@l3s.de>
Reviewed-on: http://review.gluster.org/9238
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e6a36f1dcc96028bb3631f59498175d97efd0094
Author: vmallika <vmallika@redhat.com>
Date: Wed Dec 3 15:10:44 2014 +0530
uss/gluster: Send success on parent lookup of entry-point
When a lookup sent to snapview-server for entry-point directory
protocol server first tries to resolve gfid of a parent directory.
looking up the parent gfid from a latest snapshot can fail if the
volume is a restored volume. As this gfid is already looked-up by
snapview-client, we can return success for the parent gfid.
Change-Id: Ic9b20561ef79b93032f07c3a81eae54a94e1747b
BUG: 1162498
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9229
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2a89c45d6f00b2584495031d33c55873ea88fa57
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Dec 5 11:16:07 2014 +0530
cluster/afr: Eliminate locking in sh domain in metadata self-heal
Change-Id: I9ef25a17c9a43ba06fac2ad3f7c18cb47de91537
BUG: 1170913
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9240
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit d437fb7590f6179b79adc4dbbb32325b6266d468
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Dec 1 11:00:44 2014 +0100
ec: Temporary fix for quota.t
This fix solves a problem with tests/basic/ec/quota.t that generates
a segmentation fault in DHT.
This is a temporary fix until bug #1167793 is solved.
Change-Id: I8587e66a63375ba2b312e8c0bfa1dd0d94d4c19f
BUG: 1129939
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9222
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7d964e4d799741f4a9719d3817dd951c7b6b9847
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Dec 3 16:42:31 2014 +0100
ec: Fix mutex related coverity scan issues
This patch solves 3 issues detected by coverity scan:
CID1241484 Data race condition
CID1241486 Data race condition
CID1256173 Thread deadlock
With this patch, inode lock is never acquired inside a region locked
with fop->lock.
Change-Id: I35c4633efd1b68b9f72b42661fa7c728b1f52c6a
BUG: 1170254
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9230
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 24ee2f570830203704ac2925fccead3582e13077
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Nov 25 09:54:29 2014 +0100
ec: Fix incorrect value of EC_MAX_NODES
EC_MAX_NODES was incorrectly calculated. Now the value if computed
as the minimum between the theoretical maximum and the limit imposed
by the Galois Field.
Change-Id: I75a8345147f344f051923d66be2c10d405370c7b
BUG: 1167419
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9193
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit c080ec5242c283d2bd6b38fd98e148e9a12c4e4f
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Fri Nov 7 12:12:19 2014 +0100
ec: Fix self-healing issues.
Three problems have been detected:
1. Self healing is executed in background, allowing the fop that
detected the problem to continue without blocks nor delays.
While this is quite interesting to avoid unnecessary delays,
it can cause spurious failures of self-heal because it may
try to recover a file inside a directory that a previous
self-heal has not recovered yet, causing the file self-heal
to fail.
2. When a partial self-heal is being executed on a directory,
if a full self-heal is attempted, it won't be executed
because another self-heal is already in process, so the
directory won't be fully repaired.
3. Information contained in loc's of some fop's is not enough
to do a complete self-heal.
To solve these problems, I've made some changes:
* Improved ec_loc_from_loc() to add all available information
to a loc.
* Before healing an entry, it's parent is checked and partially
healed if necessary to avoid failures.
* All heal requests received for the same inode while another
self-heal is being processed are queued. When the first heal
completes, all pending requests are answered using the results
of the first heal (without full execution), unless the first
heal was a partial heal. In this case all partial heals are
answered, and the first full heal is processed normally.
* An special virtual xattr (not physically stored on bricks)
named 'trusted.ec.heal' has been created to allow synchronous
self-heal of files.
Now, the recommended way to heal an entire volume is this:
find <mount> -d -exec getfattr -h -n trusted.ec.heal {} \;
Some minor changes:
* ec_loc_prepare() has been renamed to ec_loc_update().
* All loc management functions return 0 on success and -1 on
error.
* Do not delay fop unlocks if heal is needed.
* Added basic ec xattrs initially on create, mkdir and mknod
fops.
* Some coding style changes
Change-Id: I2a5fd9c57349a153710880d6ac4b1fa0c1475985
BUG: 1161588
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9072
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 49b512f1ceba6d5dc79669325189db1ef2573bd5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Dec 4 07:20:35 2014 +0530
protocol/server: No root-squash checks for self-heal pid
Problem:
Self-heal pid used to be -1 which was colliding with gsyncd. Gsyncd
was not checked for root-squash authentication. Recently self-heal
pid changed to -6, but root-squash authentication is not disabled
for this.
Fix:
disable root-squash authentication for self-heal
Change-Id: I93233d4ae681cb936d166b22992eb47c658ea977
BUG: 1170407
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9231
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5636ca8e1ecbca36719177eb81fdd2f77849500e
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Nov 20 22:42:37 2014 +0530
features/index: closedir() if fd_ctx_set() fails in __index_fd_ctx_get.
Change-Id: I9ab599cf4a90c2e285d63ec0f56af210709285b6
BUG: 1166284
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/9168
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 977acd6f87c7d60bada0c1f3815e5ecd6a6898bc
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Nov 26 11:40:15 2014 +0100
Regression test portability: basic/afr/resolve.t
Final test in basic/afr/resolve.t checks for a failure after
breaking the backend. But since the tested file was accessed
just before that operations, it may still be in kernel page
cache. As a result, file read is handled by kernel cache and
never sent to the filesystem, and the test is successful
where it should have failed.
Fix this by waiting 10s before reading the supposed-to-be-broken
file.
BUG: 1129939
Change-Id: I97efc00bc8a5f954b1df786cdede468af8bf6485
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9075
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a478e7bfea3835615cb3f88e243307ad9ecada74
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Dec 4 06:53:25 2014 +0100
Regression test portability: stat
Improve Linux stat emulation for BSD so that it can handle multiple
files at once. This is required now tests/basic/afr/data-self-heal.t
uses that syntax.
BUG: 1129939
Change-Id: I2720d0e8a0d4dedbb8d51fcde3586b4e7d8bb492
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9232
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a15bf356ead50667e0cada8dd3e54122bc0bb066
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Dec 1 10:08:53 2014 +0000
heal: free leaked frames.
'gluster v heal <VOLNAME> info` waits for about 10 seconds before printing the
heal info and exiting.
Problem: glfsh_process_entries() is not freeing the frames it created.
Thus when glfs_fini() is called, it busy waits for 10 seconds for background
frames to finish before returning error.
Fix: Destroy the frames in that are created in glfsh_process_entries().
Change-Id: I5484d1b7301a355b913ae9c15b8a62471036c755
BUG: 1169335
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9224
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 945ae54f88c883e5b8984c2776b739318270f49b
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Fri Jun 27 16:28:52 2014 +0530
Glusterfs/posix: Stack corruption in posix_handle_pump
posix_handle_pump can corrupt the stack if the buffer
passed to it is too small to hold the final path.
Fix :
Check if the buffer is sufficiently large to hold the new path
component before modifying it. This will prevent the buffer
overrun but the path returned will most likely have too many symbolic
links causing subsequent file ops to fail with ELOOP.
The callers of this function do not currently check the return value.
The code needs to be modified to have all callers check the return
value and take appropriate action in case of an error.
Change-Id: I6d9589195a4b0d971a107514ded6e97381e5982e
BUG: 1113960
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/8189
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6ee5122dd0a51510b8a48c054d13e5c1168f612c
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Nov 26 12:09:56 2014 +0000
tests: change license of arequal-checksum.c to include GPL v2.
In line with the licensing scheme of other files in the project.
Change-Id: Ic4c7dfcd2f2ceaeda9ec05bd37de8ef49a1c6206
BUG: 1168207
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9203
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cd57e13eb63b119a1abca319a8d97218e469e46b
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Nov 26 12:17:08 2014 +0100
ec: Change license
Change-Id: Iae90ade2421898417b53dec0417a610cf306c44b
BUG: 1168167
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9201
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fc070881881820de71ccef409a924eb0ee47012e
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Nov 29 06:20:58 2014 +0100
Regression test portability: stat(1)
- Improve Linux stat(1) emulation for BSD: %t and %T should be 0 for non
device nodes.
- Remove what seems like a typo in entry-self-heal.t, which blocks in
Linux stat(1) emulation for BSD.
BUG: 1129939
Change-Id: I7635aa105e6d309cdb74608bdaba4135c7c00dd4
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9217
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 29bd8026f610710ce64b4f2a9a67ec4ab8c95e47
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Nov 30 18:26:17 2014 +0100
Regression test portability: basic/file-snapshot.t
- For some odd reason, setfattr(1) could fail on big-file just after
it was created by touch(1). Add a test in between to wait for the
file to be visible by ls(1).
- After switching to a snapshot, the file content is still in kernel
cache, and the old content may be readen for a few seconds after
the snapshot switch. Use ( cd $M0 && umount $M0 ) to flush vnodes
and therefore invalidate the cache.
- Unmount the mount point at the end of the test for the cleanliness
sake.
BUG: 1129939
Change-Id: I5a0d14db13e79323147761dfe50c41ae6a1cb844
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9220
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e257b450f1c510e06449c5ee597bd9172987c3cd
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Fri Nov 28 15:24:46 2014 +0530
uss: CIFS gives error while accessing .snaps directory
CIFS sends getxattr call while accessing .snaps directory.
snapview server should return ENODATA if getxattr is called
on .snaps folder. Also flush on .snaps folder should be handled.
Windows client sends and getxattr call on the parent folder
of .snaps with a special key to get the real filename of a file.
This is used by samba to do case insensitive check of files.
Fixed few FreeBSD compilation error.
bug: 1168875
Change-Id: I74d5cb4419568c8ed8709ba6d1ddff0e41392204
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/9211
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8de8162695945a321be128a65a86d5d76d515a27
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Aug 21 08:50:23 2014 +0530
tests: Data self-heal test cases
Change-Id: I74d08797b791ea6649d9aba585996e9ec680e3f8
BUG: 1128721
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8538
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit f346ccd93f1e07fb54bc99b069714b429a2e305f
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Nov 28 17:24:13 2014 +0530
glusterd: use synclock_t for synchronizing concurrent '\op_sm\' invocations
In glusterd_op_sm(), we lock and unlock the gd_op_sm_lock mutex.
Unfortunately, locking and unlocking can happen in different threads
(task swap will occur in handler call with use of synctasks).
This case is explictely covered by POSIX: the behavior is undefined.
http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_lock.html
When unlocking from a thread that is not owner, Linux seems to be fine
(though you never know with unspecified operation), while NetBSD returns
EPERM, causing a spurious error in tests/basic/pump.
To fix this, we use synclock_t which was precisely meant for this.
synclock is a pthread_mutex_t like synchronization object which uses the
synctask handle for owner and is immune to the task being run on
multiple threads during its lifetime.
Change-Id: Idca15190d42f32a843088cc8236138f676377586
BUG: 1129939
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9212
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit 11fe67d979883d734cdabcdeb67a99bb3009090c
Author: Petr Medonos <petr.medonos@etnetera.cz>
Date: Mon Nov 17 12:37:25 2014 +0100
mgmt/glusterd: Out of bounds access to fs_info struct
Change-Id: Ifa0d4ac17f9da94660a7b7f567a0f07b5cec7aec
BUG: 1164775
Signed-off-by: Petr Medonos <petr.medonos@etnetera.cz>
Reviewed-on: http://review.gluster.org/9138
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 1b3af2ebbc02c23bf4782e5ad89c16933a7b6de8
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Nov 25 07:20:38 2014 +0530
USS : fill proper uid and gid during a access call from nfs
Problem : when an user tries to access a file/folder for which
he does not have a proper permission required then fuse gives out
a proper error "Permission denied", but nfs does not give out that
error, rather he can access the file/folder. The reason being uid and
gid of call frame stack takes a default value of uid and gid which
point to root permission.
Solution : Set a proper uid and gid during a access call from nfs
Change-Id: Ib060706fde66ec7e60f242fab1f3e59122ed2245
BUG: 1167580
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/9194
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit afbdd9344c9a86a18e3d75b7f615d9ab2c62e34f
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Nov 24 08:24:24 2014 +0000
glusterd/uss: Create rebalance volfile.
Create a new rebalance volfile, which will not contain
snap-view client translators, irrespective of the status
of USS.
This volfile, will be created and regenerated everytime
the fuse-volfile is generated, and will be consumed
by the rebalance process.
Change-Id: I514a8e88d06c0b8fb6949c3a3e6dc4dbe55e38af
BUG: 1164711
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/9190
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 8816c61ce4490abddaa7c1a52144077109a55e64
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Nov 28 10:46:20 2014 +0530
glusterd/uss: if snapd is not running, return success from glusterd_handle_snapd_option
glusterd_handle_snapd_option was returning failure if snapd is not running
because of which gluster commands were failing.
Change-Id: I22286f4ecf28b57dfb6fb8ceb52ca8bdc66aec5d
BUG: 1168803
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9206
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit a04d11d2cd09d7f1b6cc69ef072482ab4867ca1a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Nov 28 12:03:24 2014 +0530
glusterd: logging improvement in txn_opinfo getter/setter function
There is a code path (__glusterd_handle_stage_op) where glusterd_get_txn_opinfo
may fail to get a valid transaction id if there is no volume name provided in
the command, however if this function fails to get a txn id in op state machine
then its a serious issue and op-sm is impacted. From debugability aspect gf_log
() can never give the consumer of this function, so logging these failures with
gf_log_calling_fn is must here.
Change-Id: I4937a9fb20cc6a747fd30dcd9fd4936398d0602a
BUG: 1168809
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9207
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 32ec1e7b5226767eb39a7ae9b2fad5e3106a73b7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Nov 21 12:20:07 2014 +0530
posix: remove duplicate dirfd calls in posix_opendir
BUG: 1168910
Change-Id: I285d352d20374bb3edee2db42d062d4724198425
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9186
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f868856b74300bec58acae1cd8291f5bec7e022f
Author: Edward Shishkin <edward@redhat.com>
Date: Mon Oct 27 21:35:16 2014 +0100
Prevent metadata corruption in the race conditions between FOP->open() and FOP->link().
Problem: crypt_open() modifies @local->format, which is used
by crypt_link() to store the updated metadata string on disk.
This results in metadata corruption.
Fixup: Don't modify @local->format by FOP->open(). Instead
modify a local copy, allocated in the low-level meta-data
handler open_format_v1().
Change-Id: I046bb39ddefc33afe59c8d3b1a2fa798298f8499
BUG: 1157839
Signed-off-by: Edward Shishkin <edward@redhat.com>
Reviewed-on: http://review.gluster.org/8982
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ebb4fa6afb4d1b484cd74f6ecee8ed2abf1be519
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Nov 27 09:13:36 2014 +0100
posix: Fix buffer overrun in _handle_list_xattr()
In _handle_list_xattr() we test remaining_size > 0 to check that
we do not overrun the buffer, but since that variable was unsigned
(size_t), the condition would let us go beyond end of buffer if
remaining_size became negative.
This could happen if attribute list grew between the first
sys_llistxattr() call that gets the size and the second sys_llistxattr()
call that get the data. We fix the problem by making remaining_size
signed (ssize_t). This also matches sys_llistxattr() return type.
While there, we use the size returned by the second sys_llistxattr()
call to parse the buffser, as it may also be smaller than the size
obtained from first call, if attribute list shrank.
This fixes a spurious crash in tests/basic/afr/resolve.t
BUG: 1129939
Change-Id: Ifc5884dd0f39a50bf88aa51fefca8e2fa22ea913
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9204
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0ba07cf98a63ce94cdabc6587e8d8edb56ed0f77
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Nov 25 10:41:53 2014 +0100
glupy: build fix if python and glusterfs prefix differ
If python is installed in ${pythonprefix} and glusterfs
in ${glusterfsprefix}, we have the following values:
${PYTHON}-config --prefix => ${pythonprefix}
$libdir => ${glusterfsprefix}/lib
Using LDFLAGS="-L`${PYTHON}-config --prefix`/$libdir" we lookf for
python libraries in ${pythonprefix}/${glusterfsprefix}/lib while
we should be looking for ${pythonprefix}/lib
Replacing $libdir by lib breaks bug 1159248, so let us look in both
${pythonprefix}/lib and ${pythonprefix}/$libdir
BUG: 1129939
Change-Id: I2fef1b795235d1543a0e5ac619c6c2d59127fb66
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9137
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit f2eedc6bce4e57737d3f6301ad6c006d597202b4
Author: vmallika <vmallika@redhat.com>
Date: Thu Nov 27 18:38:59 2014 +0530
gluster/uss: Handle notify in snapview-client
As there are two subvolumes in snapview-client, there is
a possibility that the regular subvolume is still down and
snapd subvolume come up first. So if we don't handle this situation
CHILD_UP event will be propagated upwards to fuse when regular subvolume
is still down. This can cause data unavailable for the application
Change-Id: I9e5166ed22c2cf637c15db0457c2b57ca044078e
BUG: 1168643
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9205
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f372ff0c63a6eeb2c26c22f8b53e88c8037fefc7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Oct 1 10:58:19 2014 +0530
tests: entry self-heal test cases
Change-Id: I9390bc9274eb2485af541c4044bac12e48c44064
BUG: 1128721
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8539
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e5813462203173691bc3e07abeeabc9bb91d61fa
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Nov 26 09:59:25 2014 +0100
Regression test portability: batch of bugs (volume 2)
Fix various regression test portability in tests/bugs.
bug-861542.t
- Avoid syntax specific to GNU sed.
bug-860663.t
- Command argument length is system dependent, and specifying 1000 file
path may overflow it. Use a C program to do the job in a portable and
efficient way.
- Add a test that we created the specified amount of files.
bug-858242.c, bug-808400-fcntl.c, bug-808400-flock.c
- fstat64() is Linux-specific. Define it as fstat for other systems.
bug-823081.t
- Use portable tail -n instead of tail --lines
In many tests:
- Do not assume python interpreter name. Use $PYTHON as defined
in env.rc by configure.
utils/libcxattr.py
- If python version is 2.6 or higher, use a portable mechanism to
recover errno. The original version is retained for python version
2.5 and earlier but it only works on Linux.
BUG: 1129939
Change-Id: If2fea1ffec5cc6ab2de426fb200e884450afe61b
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9097
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit de715a8acb018b6a5a16aeaa9734a8d8cb7ab259
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Jun 18 14:46:05 2014 -0400
core: fix remaining *printf formation warnings on 32-bit
This fixes a few lingering size_t problems. Of particular note are
some uses of off_t for size params in function calls.
There is no correct, _portable_ way to correctly print an off_t. The
best you can do is use a scratch int64_t/PRId64 or uint64_t/PRIu64.
Change-Id: I86f3cf4678c7dbe5cad156ae8d540a66545f000d
BUG: 1110916
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/8105
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e24eeec3ae5aec0b5d1cecfb0dafd6543cc93f31
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Tue Sep 23 23:05:16 2014 +0530
doc: Avoid duplicate rdma notes.
Change-Id: I5ede0ffad3870d8d86cb5d551ce188c649b04b44
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8826
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2fcfe1dd1ed3f71c407b2993d4ed9f4b1b4e828a
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Aug 26 12:57:59 2014 +0530
extras: geo-rep: Customize the generate gfid script to dirs list
generate-gfid-file.sh now accepts dirs list file and generate
gfids only for those dirs list.
Change-Id: Ia78a0a744dc8a079db56c38578cc6fcac2a6fa90
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/8540
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 14f4d4b481fdf59b8ee987f42c3b47f6ca80fce4
Author: Poornima Gurusiddaiah <pgurusid@redhat.com>
Date: Tue Jul 1 14:38:54 2014 +0530
dict: Remove the redundant hash calculation when the hash size is 1
Currently the dict is created with hash size 1, i.e. there is
only one hash bucket and the calculation of hash decomes redundant.
Change-Id: Id70aea0d798902494ebb6d82955d97d591bc73d2
BUG: 789278
Signed-off-by: Poornima Gurusiddaiah <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/8211
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6dc7a73f4c3d8437685650594bfc7efa199125e2
Author: vmallika <vmallika@redhat.com>
Date: Thu Nov 20 20:36:00 2014 +0530
gluster/uss: Handle ESTALE in snapview client when NFS server restarted
When NFS server is restarted inode-context is lost.
Nameless lookup will be sent to regular volume.
If the gfid is from virtual graph, lookup will fail
with ESTALE. We need to send a lookup to snapview server
Change-Id: I22920614f0d14cb90b53653fce95b6b70023eba6
BUG: 1166197
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9153
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1989fb168c6b94ce4563e7bbe24fc474d4370072
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Nov 13 22:39:44 2014 +0530
dict: Write dict_foreach_* in form of dict_foreach_match
Change-Id: Iaa3454f7f3b6516660b1976bea63e39ea7795f8f
BUG: 1164051
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9121
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d709027b66421461ad056bd8a97a37ec3db95e25
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Jun 13 11:09:25 2014 -0400
core: fix Ubuntu code audit (cppcheck) results
See also http://review.gluster.org/#/c/7693/, BZ 1091677
AFAICT these are false positives:
[geo-replication/src/gsyncd.c:100]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:403]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1201]: (error) Possible null pointer dereference: fde
[xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr
Test program:
[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[tests/basic/fops-sanity.c:55]: (error) Buffer overrun possible for long command line arguments.
the remainder are fixed with this change-set:
[cli/src/cli-rpc-ops.c:8883]: (error) Possible null pointer dereference: local
[cli/src/cli-rpc-ops.c:8886]: (error) Possible null pointer dereference: local
[contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 2) requires 'long *' but the argument type is 'unsigned long *'.
[contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 3) requires 'long *' but the argument type is 'unsigned long *'.
[xlators/cluster/dht/src/dht-rebalance.c:1734]: (error) Possible null pointer dereference: ctx
[xlators/cluster/stripe/src/stripe.c:4940]: (error) Possible null pointer dereference: local
[xlators/mgmt/glusterd/src/glusterd-geo-rep.c:1718]: (error) Possible null pointer dereference: command
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:942]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:1026]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-sm.c:249]: (error) Possible null pointer dereference: new_ev_ctx
[xlators/mgmt/glusterd/src/glusterd-snapshot.c:6917]: (error) Possible null pointer dereference: volinfo
[xlators/mgmt/glusterd/src/glusterd-utils.c:4517]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:6662]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:7708]: (error) Possible null pointer dereference: this
[xlators/mount/fuse/src/fuse-bridge.c:4687]: (error) Uninitialized variable: finh
[xlators/mount/fuse/src/fuse-bridge.c:3080]: (error) Possible null pointer dereference: state
[xlators/nfs/server/src/nfs-common.c:89]: (error) Dangerous usage of 'volname' (strncpy doesn't always null-terminate it).
[xlators/performance/quick-read/src/quick-read.c:586]: (error) Possible null pointer dereference: iobuf
Rerunning cppcheck after fixing the above:
As before, test program:
[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[tests/basic/fops-sanity.c:55]: (error) Buffer overrun possible for long command line arguments.
As before, false positive:
[geo-replication/src/gsyncd.c:100]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:403]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1201]: (error) Possible null pointer dereference: fde
[xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr
False positive after fix:
[xlators/performance/quick-read/src/quick-read.c:584]: (error) Possible null pointer dereference: iobuf
Change-Id: I20e0e3ac1d600b2f2120b8d8536cd6d9e17023e8
BUG: 1109180
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/8064
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 32fc3f3f3558ab79a6d5f160b3b7634bad06d87f
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Nov 20 14:06:03 2014 +0530
cli: .cmd_log_history should not be hidden
Change-Id: I4513a2c260530855e09be64083e9344108c7a6c0
BUG: 1165996
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9150
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit bdaf6898bb489f3200164d76b0c335e6aec2aaac
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Nov 21 10:37:52 2014 +0530
tests: mgmt_v3_locks.t fix
this patch fixes a small issue introduced by http://review.gluster.org/#/c/9114/
Change-Id: I42a91544fad2b5f8af70670e4c4cadcac094dd05
BUG: 1163543
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9171
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: 长财 余 <einstcrazy@gmail.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit a94b0f63732d7365c0ba5207f88f9a805fa376b0
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Nov 20 11:58:16 2014 +0100
Regression tests portability: Do not 'cd' into volume
Changing current directory to the root of the volume to
execute tests from there keeps an open file descriptor
to it that could interfere with some tests.
I've removed all 'cd' and used abosulte paths on all
tests.
Change-Id: Ic54afb7d7974e9e80818201bcd99ee2b01d00442
BUG: 1129939
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9151
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
commit c5140c2f1aa6a5b4dc2c7ef9ce4a89e9e4f14658
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Nov 2 19:15:49 2014 +0100
Replace copied (from rsync) checksum code by adler32() from zlib
The weak checksum code that is included in libglusterfs has initialy
been copied from the rsync sources. Instead of maintaining a copy of a
function, we should use a function from a shared library. The algorithm
seems to be Adler-32, zlib provides an implementation.
The strong checksum function has already been replaced by MD5 from
OpenSSL. It is time to also remove the comments about the origin of the
implementation, because it is not correct anymore.
Change-Id: I70c16ae1d1c36b458a035e4adb3e51a20afcf652
BUG: 1149943
Reported-by: Wade Mealing <wmealing@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9035
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4a35eb1ebfec50ab87174df74dfc26440b255b2b
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Tue Nov 18 14:58:20 2014 +0530
rdma:Removing RDMA tech preview cli message.
Creation of rdma and tcp,rdma volume will display a
warning message since it was in tech preview. This
patch will remove the warning message during the
volume creation.
Change-Id: I54f46097073bcb5a757ab047f540cd9b92553897
BUG: 1164079
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9141
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 21d1f12526c4a05abf00232f668b3b337af4d783
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Wed Nov 19 17:22:21 2014 +0530
mount:Handle -o transport option in mount.glusterfs
In current scenario ,when tcp transport type(default)
specified for mounting,glusterfs mount script won't
append '.tcp' to volume name.But to accommodate the change
in http://review.gluster.org/#/c/9146/, we need to
append ".tcp" with volfile-id if '-o transport=tcp' is given.
Change-Id: I506edeb339de062087f820f10e17c7d67b8b63fe
BUG: 1164079
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9147
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit e49058448484029a1a2fbe54223df421f47e0f02
Author: GauravKumarGarg <ggarg@redhat.com>
Date: Mon Nov 17 12:50:49 2014 +0530
glusterd: Add hostname/ip-address along with host's UUID in glusterd log message
Previously when host disconnected from cluster then glusterd logs
identifies host using host's UUID.
Now with this fix, UUID along with host's ip will be present in
glusterd log message when one of the peer disconnected from cluster.
So it will enhancement better readability of user from log file.
Change-Id: I3b7eaf1b1a8963ef2096e67a78cf69f67d5d5166
BUG: 1101382
Signed-off-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/9136
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 4ecd744ba1088292bafaf7e4c48da3abbbfb0382
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Nov 20 16:26:36 2014 +0100
pkg-config: make the version in gluster-api.pc backwards compatible
Once we released gluster-api.pc with version=4. Since then we undid the
library versioning and replaced it with symbol-versioning. The current
libgfapi.so has version 0, but the symbols have the version from the
main package at the time they were added.
Because other packages (like samba) use the pkg-config version, we can
not drop it, or decrease the version easily. The simplest solution is to
keep the version=4 and add sub-digits for the actual package/symbol
versions. In future, the version in gluster-api.pc will be like 4.3.x.y.
Change-Id: If359c8de5b847a7e818199a7246636113837da2d
BUG: 1166232
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9154
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0f2141ed5ec7d7e3e03517ae8a327f0e6590e60f
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jun 16 12:29:03 2014 -0400
core: use gf_time_fmt() instead of localtime()+strftime()
gf_time_fmt() has existed since 3.3; it provides consistent timestamps
(i.e. UTC times) throughout the implementation. (BTW, the other name for UTC
is GMT.)
N.B. many (all?) commercial storage solutions use UTC time for logging.
This makes for easier debugging across geographically distributed systems.
Also adding a "%s" fmt for portably printing time as simple numeric
value on systems regardless of whether 32-bit or 64-bit time_t. Plus a
minor tweak to return a ptr to the dest-string to allow gf_time_fmt()
to be passed as a param in a *printf().
Someday we should pick the "one true" timestamp format and revise all
calls to gf_time_fmt() to use it instead of the five or six different
formats.
Change-Id: I78202ae14b7246fa424efeea56bf2463e14abfb0
BUG: 1109917
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/8085
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c04696c95ec82da23e897e30680c0a97e2747cbf
Author: vmallika <vmallika@redhat.com>
Date: Tue Nov 18 17:23:06 2014 +0530
tests: spurious failure fix for bug-1164613.t
Snapshot bricks are started asynchronously.
It might take sometime before accessing the file.
Change-Id: I62633974eca21f86632f7005ce6fd5c856b8be90
BUG: 1163543
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9142
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit cfc96c67c4df1cff4d65c3132664af657880bed1
Author: Anoop C S <achiraya@redhat.com>
Date: Wed Nov 19 16:27:05 2014 +0530
rdma: Client volfile name change for supporting rdma
For rdma only volumes, daemons like snapd, glustershd
etc make use of tcp transport for their operations.
This patch will introduce the support of rdma by default
for those daemons in rdma only volumes. In order to
accomodate this change we rename the tcp client volfile
labels from
<volname>-fuse.vol
to
<volname>.tcp-fuse.vol
Change-Id: Id9727b97d00e62a4a1556b9c0c56653d45c8fe1d
BUG: 1164079
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/9146
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 23868fe1d2d75a739653904bee5755f2684eebea
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Nov 15 23:30:31 2014 +0100
md-cache: check mtime_nsec and ctime_nsec fields for changes too
When md-cache checks for an updated mtime/ctime in order to see if it
should request a cache invalidation, it only looks at the whole-second
"mtime" and "ctime" fields. If a file was modified a fraction of a
second after the time of the cached data, md-cache won't notice the
change.
BUG: 1164506
Change-Id: Ieb7baa46f84489d2d7ea8d60a7fb2595564eb955
Original-author: Philip Spencer <pspencer@fields.utoronto.ca>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9131
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c2a9382dceb9b6e34de7a4b56631e95da97faef1
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Nov 15 22:44:09 2014 +0100
md-cache: cache the iatt when readv() was successful
When md-cache is handling a readv callback, its logic is to skip
checking the file's iatt (to see if it has changed since the time of the
last cache) if "op_ret != 0".
This is a mistake, and the intent was to skip only on error; for other
fops, op_ret is 0 on success and nonzero on error, and md-cache has the
same code for them.
For readv, though, op_ret is the number of bytes read, so it will
normally be positive except on EOF.
BUG: 1164503
Change-Id: Ifc0f2084b41b6f8d075a9260dc7cf69e97535eed
Original-author: Philip Spencer <pspencer@fields.utoronto.ca>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9129
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 07e72873a70202fd574b6806d6fff3c5422de86e
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Nov 17 15:52:28 2014 +0100
Regression tests portability: basic/ec/self-heal.t
When checking for bricks availability, use ls -l produces a more reliable
result than just ls.
BUG: 1129939
Change-Id: Ided548a8f4154714d2c33ec538d0623d7c328952
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9133
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
commit c1581b0c34d7ddcb81cfc68ae086d98f0cd9f2d1
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Nov 13 07:03:54 2014 +0530
tests: spurious failure fix for quota-anon-fd-nfs.t
Change-Id: I4f7ee68c514d8d322e25cf74167f288a8b6f8164
BUG: 1163543
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9108
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fe732d1477c048c7a451f8c454d39622b82624ce
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue Oct 21 08:59:46 2014 -0400
rdma :mount fails for nfs protocol in rdma volumes
When we mount rdma only volume or tcp,rdma volume using newly
peer probed IP's(nfs-server on new nodes) through nfs protocol,
mount fails for rdma only volume and mount happens with
help of tcp protocol in the case of tcp,rdma volumes. That is for
newly added servers will always get transport type as "socket".
This is due to nfs_transport_type is exported correctly and
imported wrongly.
This can be verified by the following ,
* Create a rdma only volume or tcp,rdma volume
* Add a new server into the trusted pool.
* Checkout the client transport type specified nfs-server
volgraph.It will be always tcp(socket type) instead of rdma.
* And also for rdma only volume in the nfs log, we can see
'connection refused' message for every reconnect between
nfs server and glusterfsd.
BUG: 1157381
Change-Id: I6bd4979e31adfc72af92c1da06a332557b6289e2
Author: Jiffin Tony Thottan <jthottan@redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/8975
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit fa172faf433b6361445b6fd2d6bef13e1cf4bb87
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Nov 13 06:59:41 2014 +0530
tests: spurious failure fix in mgmt_v3_locks.t
Change-Id: I7c4599648b5d47d93a447e58c063fab21e8f9ef7
BUG: 1163543
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9114
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit 11ae8c67b0ad047ef4131599718b7ccbc15b1534
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Oct 30 10:35:57 2014 +0530
rdma:client process will hang if server is started to send the request before completing connection establishment
in rdma, client and server will interchange their available
buffers during the handshake to post incoming messages.
Initially the available buffer is set to one, for the first message
during handshake,when first message is received, quota for
the buffer will set to proper value. So before receiving the message
if server started to send the message, then the reserverd buffer for
handshake will be utilised, then the handshake will fail because
of lack of buffers. So we should block sending messages by server
before proper connection establishment.
Change-Id: I68ef44998f5df805265d3f42a5df7c31cb57f136
BUG: 1158746
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9003
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 34e1b720ef2ae2f0d80328a62e1d9beda3a5f29f
Author: Anoop C S <achiraya@redhat.com>
Date: Wed Nov 12 18:02:15 2014 +0530
rdma: Wrong volfile fetch on fuse mounting tcp,rdma volume via rdma
As of now for both tcp only volumes and rdma only volumes, volfile
names are in the format <volname>-fuse.vol. This patch will change
the client volfile namings as shown below.
* TCP mounts always use <volname>-fuse.vol
* RDMA mounts always use <volname>.rdma-fuse.vol
Following the above naming convention, for tcp,rdma volumes both
volfiles will be present under /var/lib/glusterd/vols/<volname>/
such that rdma only volume can be mounted as
mount -t glusterfs -o transport=rdma <server/ip>:/<volname> <mount-point>
OR
mount -t glusterfs <server/ip>:/<volname>.rdma <mount-point>
The above command format can also be used to fuse mount a tcp,rdma
volume via rdma transport.
When we try to fuse mount a tcp,rdma volume with transport-type
as rdma it silently mounts via tcp. This change will also make
sure that it fetches the correct volfile based on the
transport-type specified from client side.
BUG: 1131502
Change-Id: I34da4b01ac813b69494a43188f51145457412923
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-on: http://review.gluster.org/8498
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 043dd9aa90e93a949e47731eee29218030218a7e
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Oct 16 11:28:33 2014 +0530
rdma: client connection establishment takes more time
For rdma type only volume client connection establishment
with server takes more than three seconds. Because for
tcp,rdma type volume, will have 2 ports one for tcp and
one for rdma, tcp port is stored with brickname and rdma
port is stored as "brickname.rdma" during pamap_sighin.
During the handshake when trying to get the brick port
for rdma clients, since we are not aware of server
transport type, we will append '.rdma' with brick name.
So for tcp,rdma volume there will be an entry with
'.rdma', but it will fail for rdma type only volume.
So we will try again, this time without appending '.rdma'
using a flag variable need_different_port, and it will succeed,
but the reconnection happens only after 3 seconds.
In this patch for rdma only type volume
we will append '.rdma' during the pmap_signin. So during the
handshake we will get the correct port for first try itself.
Since we don't need to retry , we can remove the
need_different_port flag variable.
Change-Id: Ie8e3a7f532d4104829dbe995e99b35e95571466c
BUG: 1153569
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/8934
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit ddb745ded872d48e21daa5047f637b376f1bdc0d
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Sep 18 04:21:04 2014 -0400
rdma:rdma fuse mount hangs for tcp,rdma volumes if brick is down.
When we try to mount a tcp,rdma volume as rdma
transport using FUSE protocol, then mount will
hang if the brick is down. When we kill a process,
signal will be received in glusterfsd process and
it will call pmap_signout with port listening on tcp only.
In case of the tcp,rdma there will be two ports,
and port which is listening for rdma will not
called for sign out.
So the mount process will try to connect to a port
which is not open and it will keep trying to connect.
This patch will call pmap_signout for rdma port also,
So when mount tries to get the brick port,it will fail.
Change-Id: I23676f65f96eb90b69b76478f7a21412a6aba70f
BUG: 1143886
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/8762
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit e32d91076aed92cf656fbf7467eabfa83e762f1d
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Nov 15 23:07:04 2014 +0100
changelog: correct mmap() error checking
Upon failure, mmap() returns MAP_FAILED, which is not equal to NULL.
This small correction makes sure that the potential error gets caught
and handled.
BUG: 1138621
Change-Id: I0a88b5187afa7187dcaa8f7d2cb0f9bb775c929d
Reported-by: Santosh Pradhan <santosh.pradhan@gmail.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9130
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit ec06f53cd8dae5c7e750c9bdcf46328212284b26
Author: Sachin Pandit <spandit@redhat.com>
Date: Wed Nov 5 11:09:59 2014 +0530
USS : Kill snapd during glusterd restart if USS is disabled
Problem : When glusterd is down on one of the nodes and during that
time if USS is disabled then snapd will still be running
in the node where glusterd was down.
Solution : during restart of glusterd check if USS is disabled,
if so then issue a kill for snapd.
NOTE : The test case which I wrote in my previous patchset
is facing some spurious failures, hence I thought of removing
that test case. I'll add the test case once the issue is resolved.
Change-Id: I2870ebb4b257d863cdfc319e8485b19e932576e9
BUG: 1161015
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/9062
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit d3c4208a82a9027b7b78e15a62c8cd65feed7dff
Author: vmallika <vmallika@redhat.com>
Date: Mon Nov 17 07:14:28 2014 +0530
gluster/uss: Don't send failure when accessing snap with name same as entry-point name
In a scenario, if the snap name is same as the snap-directory than cd to
snaps/snaps fails.
Send a lookup to snap-view server instead of failing
Change-Id: Ie7b811815ff30961500592bbc8cdb514a9d76ef5
BUG: 1164613
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9135
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 9efaa4983807e517807962018d83942457a591de
Author: Shyam <srangana@redhat.com>
Date: Thu Nov 6 10:43:37 2014 -0500
cluster/dht: Fix subvol check, to correctly determine cached file rename
The check to treat rename as a critical failure ignored when the cached
file is being renamed to new name, as the new name falls on the same
subvol as the cached file. This is in addition to when the target of the
rename does not exist.
The current change is simpler, as the rename logic, renames the cached
file in case the target exists and falls on the same subvol as source
name, OR the target does not exist and the hash of target falls on the
same subvol as source cached. These conditions mean we are renaming the
source, other conditions mean we are renaming the source linkto file
which we do not want to treat as a critical failure (and we also instruct
marker that it is an internal FOP and to not account for the same).
Change-Id: I4414e61a0d2b28a429fa747e545ef953e48cfb5b
BUG: 1161156
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/9063
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: susant palai <spalai@redhat.com>
Reviewed-by: venkatesh somyajulu <vsomyaju@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7cf29da4ecfa737b9a35785f682165eacd16f85a
Author: Rudra Siva <rudrasiva11@gmail.com>
Date: Sun Nov 16 08:37:40 2014 -0500
client: writev,fsync to use correct rsp structure
Presently writev_cbk and fsync_cbk pass truncate_rsp for decoding, this
should not create any problems as they are structurally the same. Should
they diverge in the future this could show up as a bug.
Change-Id: Id7da7b6a20f468ca943ceb7926de64b7692f7ec8
BUG: 1164559
Signed-off-by: Rudra Siva <rudrasiva11@gmail.com>
Reviewed-on: http://review.gluster.org/9134
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 17b1f1e0a920e3a909424bdee39db515548eed9d
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jul 10 07:30:42 2014 -0400
client: pass xflags for unlink
Nobody seems to use these currently, but I tried to for some debugging,
and that led to a few head-scratches before I figured out that it wasn't
being passed across the server/client boundary. Might as well fix it
before somebody tries to use it for real and has to go through the same
exercise.
Change-Id: Ieddfac106103db02fdf488c86f3f979d29a6ab83
BUG: 1158614
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8287
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit daa8ee7425258f1e82e76ca1c60145648eb61e3f
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Fri May 9 15:30:04 2014 +0530
mem_acct : Check return value of xlator_mem_acct_init().
some code does not check xlator_mem_acct_init()
return, thus fails to capture wrong memory accounting
initialization. This patch fix the same.
Change-Id: I01eab19d6cef472afd850b0f964132c01523492a
BUG: 1123768
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/7728
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 9ced22f1fe864512e4046120d820957eb7f8385f
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Nov 13 13:55:36 2014 +0100
ec: Avoid self-heal on directories on (f)stat calls
To avoid inconsistent directory listings, a full self-heal
cannot happen on a directory until all its contents have
been healed. This is controlled by a manual command using
getfattr recursively and in post-order.
While navigating the directories, sometimes an (f)stat fop
can be sent. This fop caused a full self-heal of the directory.
This patch makes that (f)stat only initiates a partial self-heal.
Change-Id: I0a92bda8f4f9e43c1acbceab2d7926944a8a4d9a
BUG: 1163760
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9117
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fb395eac62ddfe0590103933194f9907946d1212
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Oct 21 13:29:07 2014 -0400
doc: update rebalance doc, add SSL/TLS doc
Change-Id: I5d21aabaa6bfa6de40459c9a1969832a0a5d75e1
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8961
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1a703535c87d51d41f65822c66716e112e3dc87a
Author: jiffin <jthottan@redhat.com>
Date: Tue Nov 4 20:33:01 2014 +0530
gNFS : make it possible to mount a subdir that actually is a symlink
We are using the function to export all sub-directories in a gluster volume via nfs.
For real directories it works fine but if we have a symbolic link which points to the
directory, it is not possible to mount that directory via nfs and the nameof the link.
Kernel nfs resolves symlink handle to directoryhandle , similar gluster nfs should
resolve the symbolic link handle into directory handle.
Change-Id: I8bd07534ba9474f0b863f2335b2fd222ab625dba
BUG: 1157223
Signed-off-by: jiffin tony thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/9052
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 558545e7e861bcdea8d9167dcf8dd173f4c045cf
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Nov 12 12:02:44 2014 +0000
uss/snapd: Handle readlink fops on snap view server
Handle readlink fops in case of symlinks on
snap view server
BUG: 1162462
Change-Id: Ia08e9e9c1c61e06132732aa580c5a9fd5e7c449b
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/9102
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7f30421d5c940dd0cc1bd7d4aed8534331cc4f3d
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Mon Oct 13 11:12:14 2014 +0530
rdma: glusterd crash if rdma_disconnect is called as soon as connect a request.
we are initializing connection in server side immediately after
rdma_accept is called. But we are delaying adding the transport
to listener list until getting RDMA_CM_EVENT_ESTABLISHED event.
Before getting this event if disconnect is called glusterd will
try to remove the transport from list which is not added. So if
the list is empty it causes a glusterd crash . In this patch we
will call the function to initialize the connection as soon as
rdma_accept is called.
Change-Id: I019480297a85349ede3101ee9c7c1596dc5c73e2
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
BUG: 1164079
Reviewed-on: http://review.gluster.org/8925
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 0b5cbc18bf7c42ecfdab9cb93ec1359eca72a8d8
Author: vmallika <vmallika@redhat.com>
Date: Fri Nov 14 12:06:39 2014 +0530
mgmt/glusterd: Validate the options of uss
Change-Id: Id13dc4cd3f5246446a9dfeabc9caa52f91477524
BUG: 1111554
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8133
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 1abb940acfff9ff6e0047f1287ebeef17b29b147
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri Nov 14 12:06:39 2014 +0530
posix: Changed order of chown and chmod
Problem:
Rebalance process runs in the root mode. If a normal
user create a file and if it requires migration then
because the migrated file is created by root, its owner and
mode should be changed to the source normal user and
permission should be changed the previous mode. If
the suid bit is also set, then at the destination
suid bit should also be set.
Two operations are performed in the given order:
1. chmod
2. chown
But chown resets the suid bit. So changed the order
of these two operations so that first chown will be
performed and then chmod will be performd so that
suid bit will be preserved.
Change-Id: Ib63b5cf528f8336b69bf090ad43bb02eec1d1602
BUG: 1086228
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/7435
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dae67439f4b23ebde34681451fd19b0d5c823e83
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Nov 12 12:15:11 2014 +0530
cli : Maintain separate cli log file per cli instance for cluster regression tests
Change-Id: I7f49f4999d997b99c103fd67d13f972937e3aa92
BUG: 1162987
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9100
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 41e634f03eae2de6ee2065c83e02b0e041f2962c
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Sep 18 11:47:23 2014 +0530
gfapi: Change lookup logic for "/.." and "/." .
We should handle /.. and /. in unique way,
otherwise we may end up setting glusterfs xattrs
on parent of the brick dir.
Change-Id: I206bb1751622bd912bc678fd52f4eddfd9b907c8
BUG: 1128648
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/8455
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f9f944843c081749dc27033c204c9a64eeeb8e7c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Nov 8 06:59:47 2014 +0100
Regression test portability: wc
NetBSD wc displays number with leading spaces, which cause arithmeric
operations on values from wc -l to fail.
Fix the problem by defining a wrappers that removes spaces.
BUG: 1129939
Change-Id: I6fa147cf07772f58d9e19e0efd1dae5dad3a4219
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9076
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a007a9e8755b316b0cb74b42630e051ebc3a8e3c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Nov 4 15:56:36 2014 +0100
Portability fix: mount.glusterfs
Remove bash-specific syntax from mount.glusterfs
BUG: 1129939
Change-Id: Iec3a52686f7cee1825ac5a06c11fb8ac4d3e5d65
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9044
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 92b2bbe3f1ad0c77c1849d70ecc454e463bfa94f
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Nov 4 20:53:24 2014 +0100
Build fix: xdrgen
As discovered in https://review.gluster.org/8762, BSD systems fail to
run xdrgen during glusterfs build. This seems to be caused by a
difference between BSD make and GNU make whith implcit targets. The
former seems to use absolute path here, which means we should not
prepend it with the current directory path, otherwise we have the
directory path twice and the files cannot be found my make.
This is a second attempt after I178123bf6f3d9e963ff5b78839d498f530c05a97
which was broken and reverted in I3c8966288f66d0eafa2e94490e3b64a057b4f2c0
BUG: 1157839
Change-Id: I797c536c319a156b71a42c82cbaf80bbf17b7234
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9046
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 20bccdb1f8f11fa58e5d43982bff2ba1f5218e6f
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Oct 30 11:46:56 2014 +0530
rdma:setting rdma REUSEADDR flag to rdma id.
When we restart the process, it will go TIME_WAIT state to make sure that
all the data in the transport is successfully delivered. REUSEADDR
allows server to bind to an address which is in TIME_WAIT state.
Change-Id: Ic7deb0d7442c29494fe088598ffe9c87977c04ff
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9005
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 1f9304423c527976b5b8f4232ca7ff06a2951b0d
Author: vmallika <vmallika@redhat.com>
Date: Thu Nov 13 07:11:00 2014 +0530
glusterd/snapshot: Don't append nouuid mount option for snapshot brick if original brick already has this option
Change-Id: I2841d2ac371a3e9505f6061f35d1d447946c0bae
BUG: 1133456
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8526
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 8223e3d2715b8f25d05c53eede2c6d73d505c1c7
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Mon Nov 10 15:20:51 2014 +0530
gNFS: Allow reading ACLs even without read permissions on the file.
When root-squash is enabled or when no permissions are given to
a file, NFS threw permission errors. According to the kernel-nfs
behaviour, no permissions are required to read ACLs.
When no ACLs are set, the system call sys_lgetxattr fails and
returns a ENODATA error. This translates to ESERVERFAULT error
in NFS. Fuse makes an exception to this error and returns a success
case. Similar changes are made here to achieve the expected behaviour.
Change-Id: I46b8f5911114eb087a3f8ca4e921b6b41e83f3b3
BUG: 1161092
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9085
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 00352978bd94d5685951245768b7731f9dbeb47d
Author: vmallika <vmallika@redhat.com>
Date: Thu Nov 13 15:13:39 2014 +0530
uss/gluster: creating file/directories inside .snaps should fail with EROFS
When an attempt is made to create file/directories inside .snaps, it
fails with wrong error message as "Stale file handle". It should fail
with "Read-only file system"
Change-Id: I3a812a0afc4762cbb71ab180b9394c866e576a66
BUG: 1159840
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9039
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a8559fa6eafaf8d18502b91306b961f8dc03691c
Author: Sachin Pandit <spandit@redhat.com>
Date: Thu Nov 13 03:57:57 2014 +0530
test/uss : activate the snapshot after creating.
Till now we were activating the snapshot along with the snapshot create.
But one of the recent patches has changed that behavior. Now we have
to explicitly issue activate-on-create using snapshot config if we
want snapshot to be activated during snapshot create.
Till patch fixes the regression failure which is seen lately.
Change-Id: Ic53b16e22569e521bd70dd3bfa7154a0424151ce
BUG: 1155042
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/9113
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit d51fe3820e7a2e23f7a4764f094c9e1381004cbe
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Nov 1 13:05:08 2014 +0100
build: fix glupy linking warnings
While building glupy on x86_64, the following warnings are thrown:
Making all in glupy
Making all in src
CC glupy.lo
CCLD glupy.la
/usr/bin/ld: skipping incompatible /usr/lib/libdl.so when searching for -ldl
/usr/bin/ld: skipping incompatible /usr/lib/libutil.so when searching for -lutil
/usr/bin/ld: skipping incompatible /usr/lib/libm.so when searching for -lm
/usr/bin/ld: skipping incompatible /usr/lib/librt.so when searching for -lrt
/usr/bin/ld: skipping incompatible /usr/lib/libpthread.so when searching for -lpthread
/usr/bin/ld: skipping incompatible /usr/lib/libc.so when searching for -lc
The libraries to link against are in /usr/lib64 on x86_64 in Fedora,
RHEL and CentOS. Other architectures or distributions may use a
different path. Instead of hardcoding "/lib" in configure.ac, the
variable $libdir should be used so that the path gets adapted to the
distribution and architecture.
Change-Id: Iae5db3ee8a62959ccb7f958d7c95eb77c4d4b1dd
BUG: 1159248
Reported-by: Kiran Patil <kiran@fractalio.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9033
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 685099bb607eea24d0edb2b54ae5da0ffc4f9e3b
Author: vmallika <vmallika@redhat.com>
Date: Tue Oct 28 12:25:43 2014 +0530
glusterd/snapshot: Snapshot should be deactivated when it is created
By default snapshot should be deactivated and this should be a
configurable option.
This behaviour can be configured by the command below:
gluster snapshot config activate-on-create <enable|disable>
Change-Id: I1911595c32beed43bb2fca4bf99f0d264b422513
BUG: 1157991
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8985
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 9ad36b6c535273d68bd8f6389cde0ed568c42669
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Oct 21 08:42:40 2014 +0000
glusterd/snapshot: Check if LVM device path exists before delete.
Check if the LV is present before deleting the LV. In case where
the LV is absent (already deleted?), need not fail the snap delete
operation.
Also check if the LV is mounted before trying umount. In case it
isn't umounted, only remove the LV.
Change-Id: I0f5b2674797299d8748c6fac5b091f0caba65ca4
BUG: 1104714
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/8954
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 9a3d8a1626bbbb6b8a61160a5f54e9559dfe6167
Author: vmallika <vmallika@redhat.com>
Date: Wed Nov 5 11:53:38 2014 +0530
uss/gluster: Move all uss related logs into subfolder
For USS we have 1 snapd log per volume and as many snap logs for volume.
For example if there are 4 volumes having 256 snaps each and USS is
enabled than total number of logs under /var/log/glusterfs for USS would
be 1028 logs.
Total logs = (4(snapd per volume) + 4(volumes)*256(snaps)) = 1028
Hence, it makes sense to move into into sub-folder structure like
/var/log/glusterfs/snaps/<vol-name>/<snapd + snaps logs>
Change-Id: I29262e6458c3906916923cd67d1145d6ae10bec3
BUG: 1160534
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9050
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 5b6e16d1afd2d520d4d4e35e2cd579c86d1424be
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Oct 21 07:57:22 2014 +0530
USS : Display only the activated snapshots
Instead of displaying all the snapshots in the uss world,
it is better if we display only the activated snapshots.
Change-Id: I70d3ec212b62ec15956ae3e826bc4201d8dedd17
BUG: 1155042
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8958
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 4c6538b7d0110827b8bd535c039dee7935fca89c
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Oct 28 14:00:29 2014 +0100
ec: Correctly handle quota xattrs
Change-Id: I35e11d83c318210d44b918e847cf13db35b01510
BUG: 1158008
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8990
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9377dbe6b82b06273def8037c2344cb37b9604c3
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Nov 4 16:44:58 2014 +0530
extras/hookscripts: Fix set behaviour for user.cifs and user.smb
Setting either of user.cifs or user.smb to disable should disable smb
shares when the smb share is already available.
Change-Id: I213ffca9cedc14107daeb30271d1f41dd9d7fcf4
BUG: 1105147
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/9042
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 30be9d6a527808720c02231ab06002e8384f93c6
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Fri Nov 7 15:29:45 2014 +0530
Cluster/DHT : Rebalance skipped file count fix
The return value in dht_migrate_file is used to indicate the status
of the file migration. This value was being masked by the lock operation
causing the skipped and failure file counts to be incorrectly calculated.
Change-Id: Ice3d2f5d57766e18aa52659f22a76867d188dc65
BUG: 1161518
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/9070
Reviewed-by: susant palai <spalai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c9944c267575d879a71ca73c620a76e3b179cebf
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Nov 6 10:37:06 2014 +0530
features/marker: Filter internal xattrs in lookup
Afr should ignore quota-size-key as part of self-heal
but should heal quota-limit key.
Change-Id: Ic0b06bd20a563a00d6bfdc2dc5a76c661e533ecb
BUG: 1161106
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9061
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 503d65b9005c85f9eb4de946e56a352bf2c7c98d
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Nov 8 09:47:10 2014 +0100
store: fix compile warning in gf_store_unlock()
The following warning is logged when building on Fedora 20:
store.c:712:15: warning: ignoring return value of 'lockf', declared
with attribute warn_unused_result [-Wunused-result]
It does not really matter if unlocking fails, close() will release the
lock in any case. But, log the error in case close() can not finish and
hangs indefinitely (is that possible?).
Change-Id: If6c832f9aec10da6c1adb761b13b58e22d38a065
BUG: 1009076
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9078
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0062ebf09cd8782e7908ee30c66ee9cd21d315e9
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Oct 31 06:52:39 2014 +0530
cli: for rpc timeout throw a time out message
Change-Id: I9660df1c3b2707583bd95806011b650cd1a2df1b
BUG: 1161037
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9017
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 7ddc65dcdb77e5ca3c724dae7d558557358a1861
Author: vmallika <vmallika@redhat.com>
Date: Wed Oct 8 12:26:37 2014 +0530
glusterd/snapshot: mount snapshot volume with read-only option
Snapshot volumes are readonly. If you mount the volume to the client it
doesn't allow writes, but its attributes are rw which contradicts the
functionality.
mount script should set read-only attributes for snapshot volumes.
Change-Id: I056253abd8dfe7b2b43a064fbdbd9c16b8eca679
BUG: 1132946
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8518
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 0cf0373150a3c25273408b79a1710f615f69384a
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Nov 10 09:34:39 2014 +0100
Spurious failures fix for bug-948729.t and bug-948729-mode-script.t
Change I816b36e1d3e6933f92acf19d9be8eeaaa333356e causes sprurious
failures in bug-948729.t and bug-948729-mode-script.t
This seems to be caused by leftover information in /d/backends/
probably in a dot-prefixed directory.
Attempt to fix this by removing /d/backends and other work directories
on cleanup. While there we test and report failure to remove anything.
BUG: 1129939
Change-Id: I0373c7f3c507db8ab509e8fd3aca2a386bea807e
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9081
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 12268171fb878e6c89b56f40a835035bde2c56f1
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Nov 6 14:32:57 2014 +0100
Regression test portability: batch of bugs (volume 1)
Fix various regression test portability in tests/bugs.
bug-1004744.t:
- Slower systems really requires an increased REBALANCE_TIMEOUT in include.rc
bug-1023974.t:
- use the -p option to mkdir before the path for portability sake.
bug-1051896.t and bug-847622.t:
- skip ACL test for NetBSD as it has no POSIX 1e ACL support.
bugs-1053579.t:
- Override the amount of secondary groups depending of the maximum
the system supports.
- Specify seq(1) format to avoid having trailing .00
- Use more portable su -m USER -c COMMAND (also in bug-884597.t)
- NetBSD does not fail high GID with NFS
bug-1058663.c:
- Depending on architecture, NetBSD can have SIGSEGV instead of SIGBUS
bug-762989.t and bug-867253.t:
- For non Linux systems, skip tests on features that are Linux-specific
bug-765473.t;
- Fix a {1} that bash is supposed to expand in 1 but does not, replace by 1.
- Sync volume to make sure it imediatly knows a fd got bad
BUG: 1129939
Change-Id: I5405f94ccb8f20d35b3095096b0602c43719a1ae
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9009
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1f62dfc8afab0436be7d823e96338e571d52fb6f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Oct 30 10:56:17 2014 +0530
inode: Handle '/' in basename in inode_link/unlink
Problem:
inode_link is sometimes called with a trailing '/'. Lookup, dentry
operations like link/unlink/mkdir/rmdir/rename etc come without trailing
'/' so the stale dentry with '/' remains in the dentry list of the inode.
Fix:
Add assert checks and return NULL for '/' in bname.
Fix ancestry building code to call without '/' at the end.
Change-Id: I9c71292a3ac27754538a4e75e53290e182968fad
BUG: 1158751
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9004
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0f41ed58d84b0495aa8f3c7823bef01d69cfaf00
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Nov 5 12:36:32 2014 +0530
feature/gfid-access: Always send setattr down in overloaded setxattr.
Problem: File ownership is not being preserved for root in geo-rep
mountbroker setup.
Analysis and Cause:
Entry creations for geo-rep is overloaded in ga_setxattr.
It happens in two phase, entry creation followed by setattr
to preserve ownership as in master.
If uid and gid of file being synced is root, setattr was
not being sent down. Since, the file creation happens with
non-root user in mountborker geo-rep setup, if setattr is
not done explicitly, file ownership is not preserved for root.
Solution:
Always pass setattr down in overloaded ga_setxattr.
Change-Id: I062215c1b2379d515f28ec7f271077ad37182c7e
BUG: 1104954
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9051
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 91afc489e683630cae80dd45b9dee30ea50f781d
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Nov 3 16:07:30 2014 -0500
api: versioned symbols in libgfapi.so for compatibility
Use versioned symbols to keep libgfapi at libgfapi.so.0.0.0
Some nits uncovered:
+ there are a couple functions declared that do not have an
associated definition, e.g. glfs_truncate(), glfs_caller_specific_init()
+ there are seven private/internal functions used by heal/src/glfsheal
and the gfapi master xlator (glfs-master.c): glfs_loc_touchup(),
glfs_active_subvol(), and glfs_subvol_done(), glfs_init_done(),
glfs_resolve_at(), glfs_free_from_ctx(), and glfs_new_from_ctx();
which are not declared in glfs.h;
+ for this initial pass at versioned symbols, we use the earliest version
of all public symbols, i.e. those for which there are declarations in
glfs.h or glfs-handles.h.
Further investigation as we do backports to 3.6, 3.4, and 3.4
will be required to determine if older implementations need to
be preserved (forward ported) and their associated alias(es) and
symbol version(s) defined.
FWIW, we should consider linking all of our libraries with a map, it'll
result in a cleaner ABI. Perhaps something for an intern to do or a
Google Summer of Code project.
Change-Id: I499456807a5cd26acb39843216ece4276f8e9b84
BUG: 1160709
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/9036
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9c33b03530c5e7a660be9fe02a3277e6bc52b9ea
Author: ggarg <ggarg@redhat.com>
Date: Tue May 27 17:08:53 2014 +0530
barrier: Correct gfid in statedump of barriered fops
In brick statedump file the barriered fop's gfid was showing 0 when
statedump was taken. This is because of statedump code was not
referring to correct gfid.
With this change statedump code will use correct gfid and gfid will
not be 0 in statedump file when barrier is enable and user takes
statedump of volume.
Change-Id: Ia296cba7e132402df53c602daa160c1c2cd21245
BUG: 1099369
Reviewed-on: http://review.gluster.org/7893
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit dfc102adf89dec46e781838afbe24f09a48b47b3
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Oct 27 12:12:03 2014 +0530
glusterd : release cluster wide locks in op-sm during failures
glusterd op-sm infrastructure has some loophole in handing error cases in
locking/unlocking phases which ends up having stale locks restricting
further transactions to go through.
This patch still doesn't handle all possible unlocking error cases as the
framework neither has retry mechanism nor the lock timeout. For eg - if
unlocking fails in one of the peer, cluster wide lock is not released and
further transaction can not be made until and unless originator node/the node
where unlocking failed is restarted.
Following test cases were executed (with the help of gdb) after applying this
patch:
* RPC timesout in lock cbk
* Decoding of RPC response in lock cbk fails
* RPC response is received from unknown peer in lock cbk
* Setting peerinfo in dictionary fails while sending lock request for first peer
in the list
* Setting peerinfo in dictionary fails while sending lock request for other
peers
* Lock RPC could not be sent for peers
For all above test cases the success criteria is not to have any stale locks
Change-Id: Ia1550341c31005c7850ee1b2697161c9ca04b01a
BUG: 1154635
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9012
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit a57805c3dcafe8eaac6db85a4d703ba80333f638
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Oct 29 20:35:10 2014 +0100
glupy: portability fixes
Fixes portability problems so that NetBSD passes tests/features/glupy.t
- Use python-config to detect python build environment on all systems,
not just Linux and Darwin.
- Get the site-package directory from python and make sure we install
glupy.py there, Previously we installed within glusterfs prefix,
which caused a problem if it was different that python's prefix.
- Set PYTHONPATH for tests so that the detected site-packages is used
in python's search path. This should be useless, but let us have it
just in case.
- Pass glupy.so path from glusterfsd to glupy.py through an
environment variable and use it in CDLL instead of "", as the
later seems not portable (at least it fails on NetBSD).
- Use gil_init_key pthread_getspecific to avoid deadlocks (that
code was #ifdef out, perhaps because it was not needed on Linux,
but it seems to be required for NetBSD.
- Recover the error message from Python and send it to the logs
to help debugging problems.
BUG: 1129939
Change-Id: Icc71e77d6940f0759cc14c5c5cf7ca6fa431e0d2
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8978
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ada434a3afd8275c43327163918ea7aa8add03b7
Author: vmallika <vmallika@redhat.com>
Date: Tue Nov 4 17:32:18 2014 +0530
uss/gluster: Fix typo error in the description for USS under "gluster volume set help"
gluster volume set help for uss shows "User Servicable Snapshots"
whereas it should be "User Serviceable Snapshots"
Change-Id: I3cc8b3ea2cb6d209e1a12678eb7d0e68f4160d99
BUG: 1160236
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/9041
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit aafe885387e315a2754ebe03300fb9ebbc9c07f9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Nov 5 09:04:50 2014 +0530
storage/posix: Treat ENODATA/ENOATTR as success in bulk removexattr
Bulk remove xattr is internal fop in gluster. Some of the xattrs may have
special behavior. Ex: removexattr("posix.system_acl_access"), removes more than
one xattr on the file that could be present in the bulk-removal request.
Removexattr of these deleted xattrs will fail with either ENODATA/ENOATTR.
Since all this fop cares is removal of the xattrs in bulk-remove request and
if they are already deleted, it can be treated as success.
Change-Id: Id8f2a39b68ab763ec8b04cb71b47977647f22da4
BUG: 1160509
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9049
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cec8c053df3de38be14ccb8ad1c46a7f06309a5d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Oct 28 11:48:02 2014 +0530
cluster/afr: Preserve errno in case of failures on all subvols
Problem:
When quorum is enabled and the fop fails on all the subvolumes,
op_errno is set to EROFS which overrides the actual errno returned
from bricks.
Fix:
Don't override the errno when fop fails on all subvols.
Change-Id: I61e57bbf1a69407230ec172a983de18d1c624fd2
BUG: 1157976
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8984
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a0f41b5345372aa431e29a8e5da7492608f49268
Author: Shyam <srangana@redhat.com>
Date: Fri Oct 24 15:44:22 2014 -0400
xlator/io-stat: Check and copy loc->path
Cases where loc->path is NULL, the current code in create/open/mkdir
would copy the same blindly and as a result coredump.
This is a preventive fix for the coredump. The reason for loc->path
to be NULL in certain cases is yet to be determined.
One such case is when resolve_loc_touchup fails to get inode_path due
to loops in the inode table.
Change-Id: Ic2ddf2cc9f2acaf9b939afc11afd193b4402ee7c
BUG: 1159221
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/9029
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f212a1acb35b46770c1ffc9593d0b39e9165f6ee
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Nov 4 03:18:08 2014 -0800
Revert "Build fix: xdrgen"
This reverts commit 12bc39c144aa41a097435f2aab304ddfbbb9b625
This causes all regression tests to fail. Reverting for now, we can include a
correct fix later.
Change-Id: I3c8966288f66d0eafa2e94490e3b64a057b4f2c0
URL: http://supercolony.gluster.org/pipermail/gluster-devel/2014-November/042759.html
BUG: 1157839
Reported-by: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9040
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ac21cedc708e38778d208177e1358d3fe24b1c4a
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Sep 25 10:12:46 2014 +0530
features/quota: Use per-volume log file for crawler
Change-Id: I195b3309bae7e684b7dbf771e4f3b4778d0dac4c
BUG: 1146377
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8843
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 60849be3e19ebe61dde397228f0013ef4accca33
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Sat Nov 1 22:16:32 2014 +0530
Cluster/DHT : Fixed crash due to null deref
A lookup on a linkto file whose trusted.glusterfs.dht.linkto
xattr points to a subvol that is not part of the volume
can cause the brick process to segfault due to a null dereference.
Modified to check for a non-null value before attempting to access
the variable.
Change-Id: Ie8f9df058f842cfc0c2b52a8f147e557677386fa
BUG: 1159571
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/9034
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: venkatesh somyajulu <vsomyaju@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c972712fe109eb4bfb2304faf506f4924c804ef5
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Oct 31 07:06:52 2014 +0530
glusterd/geo-rep: Fix glusterd crash in non-originator slave node.
Problem: glusterd crashes in non-originator slave node during geo-rep
create push-pem.
Cause: In glusterd_op_copy_file, the value of the key "common_pem_contents"
is freed explicitly even after dict_set is successful when it is
taken cared by dict_free.
Solution: Free only in failure cases before dict_set.
Change-Id: I65b5f32ee2b946107ad279b1fe3d728ec699bc7e
BUG: 1159119
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/9018
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 86e83148bf759c9726ca4fa9a97dd1a8565b19f9
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Oct 31 04:58:59 2014 +0100
Build fix: xdrgen
As discovered in https://review.gluster.org/8762, BSD systems fail to
run xdrgen during glusterfs build. This seems to be caused by a
difference between BSD make and GNU make whith implcit targets. The
former seems to use absolute path here, which means we should not
prepend it with the current directory path, otherwise we have the
directory path twice and the files cannot be found my make.
BUG: 1157839
Change-Id: I178123bf6f3d9e963ff5b78839d498f530c05a97
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9016
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit b2ea29148baf96042eeeffa95018520b81e6b14e
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Oct 28 18:19:30 2014 -0700
rebalance: ``check_free_space`` should ignore quota_statfs
quota_statfs() returns aggregated details of space usage
of bricks this causes distribute to be confused during
``rebalance``, where ``statfs()`` values are used to
schedule file migration.
We can make sure the values of ``statfs`` are from
individual bricks by selectively instructing
``quota_statfs()`` to return non aggregated values.
Change-Id: I1397faeee66a1b9c26709cfda693286d227a4170
BUG: 1158262
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8996
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f7b3e9c8a6501a64aab882dfe7f2a933917e6be8
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Oct 31 09:33:05 2014 +0100
gluster --xml: survive missing fields
Do not fail gluster --xml volume status detail with an empty output
if some field is missing.
Required for NetBSD to pass tests/bugs/bug-861542.t
BUG: 1129939
Change-Id: I7e2097dee5e18a5f3bb8fe6f14be53b33f4aa6b1
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/9024
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 65c61ad172603ef931027604bfc964501aec3371
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Oct 31 12:51:15 2014 +0530
cluster/afr: Perform post-op in entry selfheal inside locks
Take entrylks in xlator domain before doing post-op (undo-pending) in
entry self-heal. This is to prevent a parallel name self-heal on
an entry under @fd->inode from reading pending xattrs while it is
being modified by SHD after entry sh below, given that
name self-heal takes locks ONLY in xlator domain and is free to read
pending changelog in the absence of the following locking.
Change-Id: Ie083ceab10155c460447f04bdce7688480f1ac4f
BUG: 1128721
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/9020
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8159d2a268f25e5f26a8fef9aa9215e30594fa6c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Oct 31 09:26:28 2014 +0100
Regression test portability: mock
After some attempts at using mock on NetBSD which pulled a lot of
dependencies, it seems that software really assumes the OS is
Linux: chrooted build will fail because of missing Linux files.
As a result, make tests/basic/rpm.t Linux-only, and remove mock
and rpmbuild checks for non Linux systems.
BUG: 1129939
Change-Id: Ica2eb74dd23fbec379a26051a8f61b0dfc07a115
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8949
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit cf555aea4c0e0efc23f3e0b3b9628567eed91371
Author: jiffin <jthottan@redhat.com>
Date: Thu Oct 30 15:58:56 2014 +0530
gNFS : mount fails if connection to brick(s) is not established yet.
Connection between gluster-nfs and brick process requires
time (especially for rdma).During that time when we try to
mount using nfs ,it will fail saying that volume not found.
So we need a check using 'is_nfs_export_available'before
mounting to ensure volume is available.This patch will provide
the check before nfs mount if it is not given in the test files
Change-Id: I242eb6e3118ebaca1df46314302a203a0c9738a8
BUG: 1158831
Signed-off-by: jiffin tony thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/9011
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit f7bb9af82cf9e096b9bed4075f23e33d4e6d64bb
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Oct 14 15:16:24 2014 -0400
glusterd: add option support for own-thread
Like enabling SSL, enabling own-thread has to be done separately for
clients and servers.
* client.own-thread for clients (including internal like self-heal)
* server.own-thread for servers (including e.g. glusterd)
It's very unlikely that you would ever want to set one without the
other, but they're separate anyway just in case. Check for "private
polling thread" in the relevant logs to make sure the option took
effect, because otherwise you might not notice any difference besides
inreased performance. ;)
Change-Id: Ifaee8de52f0b959bcdf7f6b56faeee549ee56604
BUG: 1158648
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8931
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c0cb06b1fea3419a0c96c5297506fd1c30f9e47b
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Oct 29 17:47:48 2014 +0530
features/snapview-server: verify the fs instance in revalidated lookups as well
Change-Id: Id5f9d5a23eb5932a0a53520b08ffba258952e000
BUG: 1151004
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8999
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1be2fe6da179abe05e7c2ef7bae8a82f07a66564
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Aug 4 09:52:09 2014 +0200
Use F_CLOSEM if available
Use F_CLOSEM to close all file descriptors if available.
BUG: 764655
Change-Id: Ib3c682825b89c163ebb152848f2533b3cb62cdce
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8379
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cfa7ab31773752c2bc66ae3fc75b83ded0e5463f
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Oct 29 01:17:25 2014 +0100
Regression test portability: TAP
Even with successful tests on NetBSD, we had a failure message at
the end: "No plan found in TAP output"
This was caused by a white space left padded numerical variable.
Stripping the white spaces fixes the problem.
While there add SKIP_TEST for NetBSD on unspported tests so that
it does not triger a failure.
BUG: 1129939
Change-Id: I8d0bc125c4208974657977568d838ee2dd19783c
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8981
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 148013ee80b4a4a32dfa4b6caf028feef9c72dbe
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Oct 28 18:27:20 2014 +0100
Lazy umount emulation: deal with stopped volumes
On non Linux systems, lazy umount is emulated using contrib/umountd.
It first check that the path given to unmount exists, but it should
not give up on ENOTCONN as it is what happens when a volume is mounted
but stopped.
This lets NetBSD pass tests/bugs/bug-1049323.t
BUG: 1129939
Change-Id: I3451362453607a0fd82b095a9e5aa6f63bfe869a
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8991
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2ff2efdb8343ba75d8f478af003718fcbe9bbde4
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Oct 9 09:08:57 2014 +0200
Regression test portability: loopback devices
Introduce functions to deal with loopback devices setup, mount
and umount.
Remove test for xfsprogs for non Linux systems, as loopback devices
can be populated with other filesystems (e.g.: FFS for NetBSD)
While there, remove mount.nfs test for non Linux systems. At least
NetBSD has it in base system as mount_nfs.
BUG: 1129939
Change-Id: I816b36e1d3e6933f92acf19d9be8eeaaa333356e
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8914
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 72aa703ca7b63ca203b697b673c94d092da5d090
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Oct 1 06:50:02 2014 +0200
Regression test portability: useradd/userdell
Adjust useradd/userdel flags for NetBSD. Similar work will have to be
done for other non Linux systems
BUG: 1129939
Change-Id: I2a30819a4915d04473f0ef0c0c063de6015212a1
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8895
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit c973a3d3378f963fe4a10fa5e8e48ebcec0dbc13
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Oct 28 13:06:50 2014 +0530
glusterd: Store rebalance state on all peers
The rebalance state was being saved only on the peers participating in
the rebalance on a rebalance start. This change makes sure all nodes
save the rebalance state.
Change-Id: I436e5c34bcfb88f7da7378cec807328ce32397bc
BUG: 1157979
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/8998
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 5a4b9e90b4ff14ec51616ae247ca71426e9d11f0
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Sep 23 14:56:40 2014 +0530
doc: iobuf and iobref documentation.
Change-Id: Ib6d8121a968e8160c587a8553b7333262bb44975
BUG: 1118309
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/8818
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fa862ec886f4bcd7c8bb13a005d7dd422db9bd00
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Aug 4 16:27:52 2014 +0530
doc: Introduction to meta xlator.
... in the form of examples. This is by no means exhaustive. Meta
xlator is not as well known as it should be for its own good. This
patch is to get the ball rolling.
Change-Id: I5898c37aa15706e886af68f19caac48c175df90b
BUG: 1144282
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/8410
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 34f4137ee526b962d8c24c0184f1d3f2968f7121
Author: Joe Julian <me@joejulian.name>
Date: Tue Oct 21 23:37:44 2014 -0700
Fixed missing / in replace-brick pause example
BUG: 1155421
Change-Id: I079f738e8381bada4595d3600921a39581edaea7
Signed-off-by: Joe Julian <me@joejulian.name>
Reviewed-on: http://review.gluster.org/8963
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c86ae464635d4b00b28e8c6e3bbcd0061bce7073
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Oct 22 21:08:03 2014 +0200
Regression test portability: self-heald.t
Fix portability problems in updated self-heald.t:
- Use the k suffit in dd(1) bs argument instead of less portable M and K
- Error message for disconnected bricks in NetBSD is "Socket is not connected"
- On touch d/a while bricks are down, NetBSD updates d ctime/mtime even
on bricks where a is not present, resulting in a different to-be-healed
count than on Linux. We now tes both values. If NetBSD behavior is a bug,
it is not in the heal process and should be tested somewhere else.
This also requires fixes in heal process: http://review.gluster.org/8936
BUG: 1129939
Change-Id: Ibda1902a8fd64aa7cc5202744adca825e6b251c9
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8968
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1f4e0358f5b72eb7fe3ad7a3d7f067ec70e99233
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Wed Oct 29 00:44:33 2014 +0530
logrotate: gluster logrotate config should not be global
Issue : Previously glusterfs logrotate config file pollutes
global config. So moved the directives inside the curly braces,
so they don't pollute the global config state.
Change-Id: I8836893dfcdf457d9c5d766612d687bfce64e2ae
BUG: 1126802
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/8994
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8ac3ab5f3d8637ba39be3c501e1365a42154d8cd
Author: Susant Palai <spalai@redhat.com>
Date: Tue Oct 28 02:53:39 2014 -0400
CLI: Show warning message only for remove-brick commit
Earlier warning message for checking the removed-bricks for
any unmigrated files was thrown both for remove-brick commit
and force.
With this change the warning message will be shown only for
remove-brick commit.
Change-Id: Ib1fa47d831d5189088c77c5cf709a25ff36d7379
BUG: 1157974
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/8983
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 5fc8f2ab52900350a7d038e208d3e9af17dcb661
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Oct 14 12:11:24 2014 +0200
Avoid spurious EINVAL in posix_readdir()
On non Linux systems, we check that seekdir() succeeds and we return
EINVAL if it does not. We need this to avoid infinite loops if some
other component in GlusterFS makes an invalid seekdir() usage. This
was introduced in this change: http://review.gluster.org/#/c/8760/
But seekdir() also fails when using the offset returned for the
last entry, and this is expected behavior. As a result, the seekdir()
test produces a spurious EINVAL when reaching end of directory. That
error is not propagated to calling process, but it may harm internal
GlusterFS processing. At least it produce a spurious error message
in brick's log.
We fix the problem by remembering the last entry offset in fd private
data. When a new posix_readdir() invocation requests that offset,
we avoid returning EINVAL.
BUG: 1129939
Change-Id: I4e67a2ea46538aae63eea663dd4aa33b16ad24c7
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8926
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9cb1c20e7b7b84d2ee1069c7f4e6d8d4e7e080e3
Author: Kotresh HR <khiremat@redhat.com>
Date: Wed Oct 22 12:09:01 2014 +0530
feature/changelog: Fix changelog missing SETATTR entries.
Problem: Valid SETATTR entries are missing in changelog when more
than one metadata operation happen on same inode within
changelog roll-over time.
Cause: Metadata entries with fop num being GF_FOP_NULL are logged
in changelog which is of no use. Since slice version
checking is done for metadata entries to avoid logging of
subsequent entries of same inode falling into same
changelog, if the entry with GF_FOP_NULL is logged first,
subsequent valid ones will be missed.
Solution: Have a boundary condition to log only those fops whose fop
number falls between GF_FOP_NULL and GF_FOP_MAXVALUE.
Change-Id: Iff585ea573ac5e521a361541c6646225943f0b2d
BUG: 1104954
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8964
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 5e80ada05f72664af65a0da8c50b767f44cd2bb1
Author: Anand Avati <avati@redhat.com>
Date: Tue Oct 28 14:05:06 2014 -0700
inode: include dentry cycle checks for all existing inodes
inode_link() has the responsibility of maintaining the DAGness of
the dentry tree, and prevent cyclic loops from forming. To do this
the technique used is to perform cyclic check only while linking
inodes which already were linked in the inode table (i.e linking
a new_inode() can never form a loop).
While this was how it was supposed to be all along, the @old_inode
variable was missed out to get updated if the given inode to inode_link
itself was already linked (i.e, the code was only handling a complex
case when the given new inode had a gfid which already existed)
Without this patch, it is possible to call inode_link in a specific
way which results in dentry loops.
Change-Id: I4c87fa2d63f11e31c73d8b847e56962f6c983880
BUG: 1158226
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/8995
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit dd8737660bd9ddeee65a67fcc3013757592cf564
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Oct 15 12:56:48 2014 +0530
glusterd: op state machine shouldn't use global peer list
Problem : op state machine was relying on the global peer list while sending
lock/stage/unlock commit rpc requests to the peers in the cluster. Trusting on
global peer list structure is dangerous as this structure gets modified if any
peer modification command is attempted in the cluster when there is a ongoing
transaction going through the state machine. An ideal usecase of this problem
when rebalance is in progress and peer probe is executed rebalance op-sm and
peer probe may run into race making peerinfo structure go for toss.
Solution: Use local copy of peer list (xaction_peers) in glusterd op-sm.
Change-Id: I1ff7118dc6a9a72633e2e87b7ab7bae1796595e0
BUG: 1152890
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8932
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 7234c9a547f315d8f0e1f3eab462c5dc62218570
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Oct 24 17:10:15 2014 +0200
Regression test portability: quota-anon-fd-nfs.t
Fix portability problems in quota-anon-fd-nfs.t
- Use mount_nfs wrapper and include nfs.rc to get it defined.
- umount NFS before cleanup to avvoid deadlocks.
- umount -l is Linux-specific, use umount -f on BSD.
- wait for 1s for portmap registration before mouting NFS.
- mount from $H0 instead of localhost: the later fails on NetBSD.
- Test quota without filling GB of data, 20MB is enough and it
will be gentle with smaller setups.
- wait for write behind to complete before testing quota overflow
BUG: 1129939
Change-Id: I097d5faed2fa7b6438aaa56def85172f23bbe7dc
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8969
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Kiran Patil <kiran@fractalio.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2380cf76c6182ad02ab9cd91e5666edc3dfbbc34
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jun 5 11:12:22 2014 +0530
geo-rep: gid is not set in entry ops
uid is sent in place of gid while CREATE and
MKDIR.
Change-Id: Icd1072cb9dcbfc1f419a3cdd456f3d02168175fa
BUG: 1104954
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/7984
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 64613e1e68fc8c158dbbbaf8057a084d84fbe3b1
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Tue Jul 1 07:52:27 2014 -0400
Posix: Brick failure detection fix for ext4 filesystem
Issue: stat() on XFS has a check for the filesystem status but
ext4 does not.
Fix: Replacing stat() call with open, write and read to a new file under the
"brick/.glusterfs" directory. This change will work for xfs, ext4 and other
fileystems.
Change-Id: Id03c4bc07df4ee22916a293442bd74819b051839
BUG: 1130242
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/8213
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1f12ae21132e7317cfc7ae679a559a2de78b1319
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Oct 27 10:28:55 2014 +0100
changelog: replace MAKE_HTIME_FILE_PATH with snprintf()
The used once MAKE_HTIME_FILE_PATH macro uses strcpy and strcat into a
fixed buffer without checking the input lengths.
Recommend replacing with a snprintf.
Change-Id: Ia0245096774dc84be1b937e1d5750f3634fff034
BUG: 1099645
Reported-by: Keith Schincke <kschinck@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8977
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 692693ca2b4da9f60ef5b5da48ccce2b07821159
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Aug 5 08:29:42 2014 -0400
glusterfs.spec.in: use upstream logrotate exclusively
retiring Fedora dist-git *.logrotate files
Change-Id: I6a94aac6f45573216de3f9e673d10db6de5ccb98
BUG: 1126832
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/8418
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 53a84202bd24a15bdb6aa30e1e0c4425353c9339
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Fri Oct 24 15:03:12 2014 +0200
ec: Correctly handle xtime extended attribute
Change-Id: I2bd34f063d6bf1835d5ae57a8e9aa03f3ec3deb3
BUG: 1156404
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8972
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0854e7d368647da6cb7480a9640e0a79b7b6b02a
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Oct 9 17:32:48 2014 +0530
features/snapview-server: check if the reference to the snapshot world is correct before doing any fop
The following operations might lead to problems:
* Create a file on the glusterfs mount point
* Create a snapshot (say "snap1")
* Access the contents of the snapshot
* Delete the file from the mount point
* Delete the snapshot "snap1"
* Create a new snapshot "snap1"
Now accessing the new snapshot "snap1" gives problems. Because the inode and
dentry created for snap1 would not be deleted upon the deletion of the snapshot
(as deletion of snapshot is a gluster cli operation, not a fop). So next time
upon creation of a new snap with same name, the previous inode and dentry itself
will be used. But the inode context contains old information about the glfs_t
instance and the handle in the gfapi world. Directly accessing them without
proper check leads to ENOTCONN errors. Thus the glfs_t instance should be
checked before accessing. If its wrong, then right instance should be obtained
by doing the lookup.
Change-Id: Idca0c8015ff632447cea206a4807d8ef968424fa
BUG: 1151004
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8917
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f70c5022eb3cf1f307c96beb7255509425dba744
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Sep 23 13:02:56 2014 +0530
doc: documentation of inode and dentry management
Change-Id: Ica510752d011596e8ecff5ea13c4b2bbf76ba186
BUG: 1145475
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8815
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 482b7572f0f7967ffb781ddd5cf6f6cc6eaad046
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Aug 15 11:13:46 2014 +0200
glusterd: really get the inode size for a brick
The device to get the inode size from does not get passed to the tool
(tune2fs, xfs_info or the like) that is called. This is probably just an
oversight. While correcting this, cleanup some bits of the function too.
Change-Id: Ida45852cba061631fb304bc7dd5286df1a808010
BUG: 1130462
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8492
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit d8910586e8e916cd7e4ac73e1764444c2da74463
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Oct 15 09:44:55 2014 +0200
ec: Fix rebalance issues
Some issues in ec xlator made that rebalance didn't complete
successfully and generated some warnings and errors in the
log. The most critical error was a race condition that caused
false corruption detection when two specific operations were
executed sequentially and they shared the same lock.
This explains the problem:
1. A setxattr is issued.
2. setxattr: ec locks the inode before updating the xattr.
3. setxattr: The xattr is updated.
4. setxattr: Upper xlator is notified that the operation completed.
5. setxattr: A background task is initiated to update the version
of the file.
6. A stat is issued on the same file.
7. stat: Since the lock is already acquired, it's reused.
8. stat: A lookup is issued to determine version and size
information of the file.
At this point, operations 5 and 8 can interfere. This can make that
lookup sees different information on each brick, determining that
some bricks are corrupted and incorrectly excluding them from the
operation and initiating a self-heal. In some cases this false
detection combined with self-heal could lead to invalid updates of
the trusted.ec.size xattr, leaving the file smaller than it should
be.
This only happens if the first operation does not perform a lookup,
because chained operations reuse the information returned by the
previous one, avoiding this kind of problems.
To solve this, now the background update is executed atomically with
the posterior unlock. This avoids some reuses of the lock while
updating. However this reduces performance because the window in
which new requests can reuse the lock is much smaller now. This has
been alleviated by using the same technique implemented in AFR (i.e.
waiting some time before releasing the lock).
Some minor changes also introduced in this patch:
* Bug in management of 'trusted.glusterfs.pathinfo' that was writing
beyond the allocated space.
* Uninitialized variable.
* trusted.ec.config was not created for regular files created with
mknod.
* An invalid state was used in access fop.
Change-Id: Idfaf69578ed04dbac97a62710326729715b9b395
BUG: 1152902
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8947
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d542662df6d9f7f922d83d175179a59e047234aa
Author: Kotresh HR <khiremat@redhat.com>
Date: Mon Sep 8 15:04:15 2014 +0530
geo-rep/glusterd: Enable changelog and marker during geo-rep create.
PROBLEM:
Geo-rep misses few a files to sync when I/O happenned during
geo-rep start.
ANALYSES:
To use the available changelogs to handle deletes/renames,
'xsync upper limit' is introduced which limits the xsync
crawl till the changelog register time. But there is a
small time interval between the changelog register time and
the time changelog actually enabled. If there is I/O between
this interval, it will not be synced through xsync as it is
beyond changelog register time and not through changelog also
as changelog is not actually enabled.
SOLUTION:
Enable changelog and marker during geo-rep create instead
of geo-rep start so that entries are captured in changelog
and above said interval is nullified.
Change-Id: Ic5f0457a4b67a335cbbb37d34db5f8cb8bc901c4
BUG: 1139196
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8650
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit d8dc7cf67cc36b9c7b60cfaf7ca3d8003e9fc009
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Oct 21 16:54:48 2014 -0400
socket: disallow CBC cipher modes
This is related to CVE-2014-3566 a.k.a. POODLE.
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-3566
POODLE is specific to CBC cipher modes in SSLv3. Because there is no
way to prevent SSLv3 fallback on a system with an unpatched version of
OpenSSL, users of such systems can only be protected by disallowing CBC
modes. The default cipher-mode specification in our code has been
changed accordingly. Users can still set their own cipher modes if they
wish. To support them, the ssl-authz.t test script provides an example
of how to combine the CBC exclusion with other criteria in a script.
Change-Id: Ib1fa547082fbb7de9df94ffd182b1800d6e354e5
BUG: 1155328
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8962
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 78c72d056212fe003993fc0c144884c9c7ff4cdd
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Tue Oct 21 19:50:29 2014 +0530
Hooks : Infinite while loop introduced by another change.
A change made to all the hook scripts introduced an
infinite while loop in the script S31ganesha-reset.sh.
It resulted in 100% CPU usage by this script.
Change-Id: If62d8f0e065c6e6511363b8b26eae433f59bc5c3
BUG: 1155489
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/8966
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a4d444af7886f8e0532f36adb361e7e7e37cf2de
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sun Oct 19 12:42:05 2014 -0700
libglusterfs: Do not redefine AT_SYMLINK_NOFOLLOW on Darwin
Change-Id: I6c31b0a01da4b2ad05d4df67418e917c2774faa9
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8943
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit f8c5f47746c54e0fe5d473bba4e5488876c3dd36
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Oct 8 09:20:11 2014 +0200
ec: Fix self-heal issues
Problem: Doing an 'ls' of a directory that has been modified while one
of the bricks was down, sometimes returns the old directory
contents.
Cause: Directories are not marked when they are modified as files are.
The ec xlator balances requests amongst available and healthy
bricks. Since there is no way to detect that a directory is
out of date in one of the bricks, it is used from time to time
to return the directory contents.
Solution: Basically the solution consists in use versioning information
also for directories, however some additional changes have
been necessary.
Changes:
* Use directory versioning:
This required to lock full directory instead of a single entry for
all requests that add or remove entries from it. This is needed to
allow atomic version update. This affects the following fops:
create, mkdir, mknod, link, symlink, rename, unlink, rmdir
Another side effect is that opendir requires to do a previous
lookup to get versioning information and discard out of date
bricks for subsequent readdir(p) calls.
* Restrict directory self-heal:
Till now, when one discrepancy was found in lookup, a self-heal
was automatically started. This caused the versioning information
of a bad directory to be healed instantly, making the original
problem to reapear again.
To solve this, when a missing directory is detected in one or more
bricks on lookup or opendir fops, only a partial self-heal is
performed on it. A partial self-heal basically creates the
directory but does not restore any additional information.
This avoids that an 'ls' could repair the directory and cause the
problem to happen again. With this change, output of 'ls' is
always consistent. However, since the directory has been created
in the brick, this allows any other operation on it (create new
files, for example) to succeed on all bricks and not add additional
work to the self-heal process.
To force a self-heal of a directory, any other operation must be
done on it. For example a getxattr.
With these changes, the correct healing procedure that would avoid
inconsistent directory browsing consists on a post-order traversal
of directoriesi being healed. This way, the directory contents will
be healed before healing the directory itslef.
* Additional changes to fix self-heal errors
- Don't use fop->fd to decide between fd/loc.
open, opendir and create have an fd, but the correct data is in
loc.
- Fix incorrect management of bad bricks per inode/fd.
- Fix incorrect selection of fop's target bricks when there are bad
bricks involved.
- Improved ec_loc_parent() to always return a parent loc as
complete as possible.
Change-Id: Iaf3df174d7857da57d4a87b4a8740a7048b366ad
BUG: 1149726
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8916
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 22376dd33dc55d13b494a9c9af2258ba2da4f1eb
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Oct 21 14:44:03 2014 +0530
libglusterfs: include compat-errno.h in common-utils to avoid smoke failures
Change-Id: I14ae91bf20a0eb7a79b3d6028844f55642eb5426
BUG: 1151303
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8955
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a1e4d603ab459681041d4c03a1caf71969276534
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Oct 14 18:23:44 2014 +0200
Regression test portability: quota.t
- Use du -k to have size reported in kB, as NetBSD defaults to blocks
- on overquota, Linux says 'No space left' and NetBSD 'Disc quota exceeded'
BUG: 1129939
Change-Id: I6a2baef94cb60e9fabf06a6f8d01f2acb6ee0a30
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8930
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1ea7935a4d49693609f807656d8e73ad0391152a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Oct 17 11:46:46 2014 +0530
performance/io-threads: Fix static analysis error
stub->fop can be more than FOP_MAX is what static analysis is complaining. This
patch doesn't allow any 'log' to be printed in the case fop value is not in the
definied range. It gives EINVAL instead.
Change-Id: I293381e2c1ad0ab45154b0192a637612becaf744
BUG: 1153935
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8939
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 526e0908d42f8beb5aa44a047955c5b542d75534
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Oct 10 09:51:28 2014 +0530
logs: Do selective logging for errnos
Problem:
Just after replace-brick the mount logs are filled with ENOENT/ESTALE
warning logs because the file is yet to be self-healed now that the
brick is new.
Fix:
Do conditional logging for the logs. ENOENT/ESTALE will be logged at
lower log level. Only when debug logs are enabled, these logs will
be written to the logfile.
Change-Id: If203d09e2479e8c2415ebc14fb79d4fbb81dfc95
BUG: 1151303
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8918
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c7af29146d5149b6b27ea6c3743b5efb4aeecbe0
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Sep 29 11:31:24 2014 +0200
ec: Fix 32 bits issues on file size calculation
Some additional 32 bits issues have been added by a recent patch.
This patch solves it.
Change-Id: Ice81032fbe8e36e5ccad19a781b7876891993906
BUG: 1146903
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8882
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2dbdf810ed3364bb1a64b2aafc5f2470c99730be
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Oct 6 16:34:58 2014 +0200
ec: Fix incorrect management of healed bricks
The final lookup made to restore final file attributes after a self-heal
did clear the mask of bad bricks, causing that the final setattr won't
modify any brick at all. This caused that some attriutes, specially the
modification time of the file didn't get updated properly.
Now the mask of healed bricks is saved before doing the last lookup.
It's also used to correctly report the repaired bricks.
Change-Id: Ib94083c9e1b562515dfb54f9574120f1f031dccc
BUG: 1149723
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8905
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dbb77a541e3e87d494acec4a2fa3ed5d6b827358
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Oct 10 16:13:25 2014 +0530
geo-rep: Failover when a Slave node goes down
When a slave node goes down, worker in master node
can connect to different slave node and resume the operation.
Existing georep was not checking the status of slave node before
worker restart. With this patch, geo-rep worker will check the
node status using `gluster volume status` when it goes faulty.
BUG: 1151412
Change-Id: If3ab7fdcf47f5b3f3ba383c515703c5f1f9dd668
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/8921
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit e50cd5d9b5d9a7ecd6f85b41e50e6c7d8eba780d
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Oct 17 16:55:05 2014 -0700
heal/src: Fix build failure on OSX
Fix involves removing GF_GLUSTERFS_CFLAGS is a
non-existent configure value, use GF_CFLAGS instead
Change-Id: Id5e29f46589dd75c1f71c53ffaf8af60584782c7
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8942
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Justin Clift <justin@gluster.org>
commit 834485f60ce1d287715b418ad67e387954c7e5e4
Author: Kotresh H R <khiremat@redhat.com>
Date: Fri May 30 01:43:15 2014 +0530
feature/geo-rep: Fix skipped files logging.
When changelog is failed to process even after max
retries, files are skipped but were not logging.
This patch addresses this issue to log the skipped
files.
Change-Id: Ic617e4151231fe18a171efa57a119e21164e1a6a
BUG: 1103577
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7945
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 656beb3849667b1f3754f7f61b499ef81464548b
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Sep 4 21:47:50 2014 +0530
glusterd: statedump support
Although glusterd currently has statedump support but it doesn't dump its
context information. Implementing glusterd_dump_priv function to export per-node
glusterd information would be useful for debugging bugs. Once implemented, we
could enhance sos-report to fetch this information. This would potentially
reduce our time to root cause and data needed for debugability can be dumped
gradually.
Following is the main items of the dump list targeted in this patch :
* Supported max/min op-version and current op-version
* Information about peer list
* Information about peer list involved while a transaction is going on
(xaction_peers)
* option dictionary in glusterd_conf_t
* mgmt_v3_lock in glusterd_conf_t
* List of connected clients
* uuid of glusterd
* A section of rpc related information like live connections and their
statistics
There are couple of issues which were found during implementation and testing
phase:
- xaction_peers of glusterd_conf_t was not initialized in init because of which
traversing through this list head was crashing when there was no active
transaction
- gf_free was not setting the typestr to NULL if the the alloc count becomes 0
for a mem-type earlier allocated.
Change-Id: Ic9bce2d57682fc1771cd2bc6af0b7316ecbc761f
BUG: 1139682
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8665
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 31e729824ec2011ff9c15d7229a7185070faca78
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Dec 15 08:05:04 2013 +0530
heal: glfs-heal implementation
Thanks a lot to Niels for helping me to get build stuff right.
Change-Id: I634f24d90cd856ceab3cc0c6e9a91003f443403e
BUG: 1147462
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6529
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9d82d85f055b43aa599bd08194964bb8857d8577
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Oct 13 15:19:35 2014 -0700
Revert "extras: reverse test for '}' vs. following 'else' placement"
This reverts commit 0a8371bdfdd88e662d09def717cc0b822feb64e8.
Change-Id: I946f449ad213cea70fbbd9cd3951f5838b9f82e5
BUG: 1120646
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8927
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 81f1b23f5e4f7ce2425d8daad008341ace18c670
Author: Kotresh HR <khiremat@redhat.com>
Date: Fri Oct 3 17:35:47 2014 +0530
glusterd/geo-rep: Fix race in updating status file
When geo-rep is in paused state and a node in a cluster
is rebooted, the geo-rep status goes to "faulty (Paused)"
and no worker processes are started on that node yet. In
this state, when geo-rep is resumed, there is a race in
updating status file between glusterd and gsyncd itself
as geo-rep is resumed first and then status is updated.
glusterd tries to update to previous state and gsyncd
tries to update it to "Initializing...(Paused)" on
restart as it was paused previously. If gsyncd on restart
wins, the state is always paused but the process is not
acutally paused. So the solution is glusterd to update
the status file and then resume.
Change-Id: I348761a6e8c3ad2630c79833bc86587d062a8f92
BUG: 1149982
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8911
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 20c38f8d4ca668513e5a148bdedb8d9a7bca868a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Sep 2 17:26:38 2014 +0530
glusterd: print the peer name instead of a null UUID in a rpc failure message
This patch improves the failure message by printing the correct peer name
instead of a blank uuid in case of rpc connection is lost/broken.
Change-Id: Ia232792051f23896883b239982cb48130e3ce60e
BUG: 1146902
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8597
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 81a1573ada1761f8c0822512393650a3dfa4e85e
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Oct 7 10:08:20 2014 +0200
glusterd: make bricks respect 'transport.socket.bind-address'
When GlusterD starts the brick processes, these will listen on all
interfaces. When the 'transport.socket.bind-address' option is set in
glusterd.vol, the brick processes should only listen on the specified
hostname or IP-address.
Change-Id: I8e7d1f294904081137c23f3446261329d0d13bba
BUG: 1149863
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8910
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 2bfa5b96cd651ae6499a0888fc5d48e4c88d4eae
Author: Mohammed Rafi KC <rkavunga@redhat.com>
Date: Thu Sep 25 15:36:30 2014 +0530
rdma: mount hangs for rdma type transport.
rdma transport type mount will hang if there is a delay
in network to receive,we will set transport as connected
if we get an event type RDMA_CM_EVENT_ESTABLISHED,
we cannot assure whether client or server will get the
event first, the only condition is that the side which
sends the first request should wait for the event.
If client gets the event first, then it sends DUMP request,
in server side the request will reach, but it will reject
the rpc request since it didn't get the RDMA_CM_EVENT_ESTABLISHED.
So in server we will set the connected flag as soon
as rdma_accept is called.
Change-Id: Iac5845e3592666daa575c727822889779b5bd203
BUG: 1146492
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/8850
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 7542a42b45db4e4f3df329761d76dd52f438c6da
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Oct 6 22:51:22 2014 +0200
glusterd: pass the bind-address to starting services
When the transport.socket.bind-address option is set to a hostname or
ip-address, the services started by GlusterD fail to connect to the
management daemon. GlusterD always forces the services to connect to the
"localhost" hostname, even if it is not listening on that address.
GlusterD should take the transport.socket.bind-address option into
consideration, and pass that to the glusterfs-clients with the -s or
--volfile commandline parameter.
Note that this is not a change that removes all hard-coded dependencies
on "localhost". This change merely makes it possible to start required
services when the transport.socket.bind-address option is set.
Change-Id: I36a0ed6c69342e6327adc258fea023929055d7f2
BUG: 1149863
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8908
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit cc219264b8c5aa05d1d6a9d87ff6201330f335b3
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Tue Jul 22 16:56:57 2014 +0530
gNFS: Subdir mount does not work on UDP proto
After enabling nfs.mount-udp, mounting a subdir on a volume over
NFS fails. Because mountudpproc3_mnt_3_svc() invokes nfs3_rootfh()
which internally calls mnt3_mntpath_to_export() to resolve the
mount path. mnt3_mntpath_to_export() just works if the mount path
requested is volume itself. It is not able to resolve, if the path
is a subdir inside the volume.
MOUNT over TCP uses mnt3_find_export() to resolve subdir path but
UDP can't use this routine because mnt3_find_export() needs the
req data (of type rpcsvc_request_t) and it's available only for
TCP version of RPC.
FIX:
(1) Use syncop_lookup() framework to resolve the MOUNT PATH by
breaking it into components and resolve component-by-component.
i.e. glfs_resolve_at () API from libgfapi shared object.
(2) If MOUNT PATH is subdir, then make sure subdir export is not
disabled.
(3) Add auth mechanism to respect nfs.rpc-auth-allow/reject and
subdir auth i.e. nfs.export-dir
(4) Enhanced error handling for MOUNT over UDP
Change-Id: I42ee69415d064b98af4f49773026562824f684d1
BUG: 1118311
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/8346
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 44b6fa6ab7e063ce1a4289884b33d61eeb5f8644
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Oct 2 05:18:20 2014 +0200
Regression test portability: rpc-coverage
- pull include.rc when running rpc-coverage.sh to get BSD stat(1)
compatibility.
- fix type in statfs_test and use mode instead of size so that
it cannot pass by chance like it did.
- BSD tail does not support --pid; Avoid that option by making
the test simplier.
- Use a subshell instead of pushd/popd, which seems more reliable.
- Use flock -x instead of flock -e: same result on Linux, compatible
with NetBSD flock.
- when using file descriptors in the shell, avoit too high numbers
otherwise we can easily hit the descriptor limit.
BUG: 1129939
Change-Id: I51bad02a0ef47f20e4a2c49098c1c6701b7e6b09
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8566
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit edda66235a7846314ed9bb4c1a4c0fa924084e94
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Oct 6 22:46:44 2014 +0200
build: include contrib/umountd in the 'make dist' tarball
When running 'make dist' on Linux, the new contrib/umountd directory and
contents is not included in the resulting tarball. This causes the build
from the tarball to fail.
Change-Id: Ic575040212d91c6368f04b015cc9d2d5b2969a3a
BUG: 1129939
Reported-by: Emmanuel Dreyfus <manu@netbsd.org>
URL: http://supercolony.gluster.org/pipermail/gluster-devel/2014-October/042441.html
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8907
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7cf9de8190414b3c734705da890a53030535d29e
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Oct 1 20:41:58 2014 +0200
ec: Fix memory leak caused by undestroyed fops
Operations processed by ec_dispatch_one() were not correctly
completed by ec_complete(), leaving some structures in memory.
Now ec_complete() also calls ec_resume() for this type of fops.
Change-Id: Iaf0f2e8227399ebb735db9f1bd007593e0ece041
BUG: 1148520
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8896
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8af575d6a8ced4afb0471835c7c17fdbe03b7c12
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Sep 21 13:57:47 2014 +0200
Do not hardcode umount(8) path, emulate lazy umount
1) Use a system-dependent macro for umount(8) location instead of
relying on $PATH to find it, for security and portability sake.
2) Introduce gf_umount_lazy() to replace umount -l (-l for lazy) invocations,
which is only supported on Linux; On Linux behavior in unchanged. On other
systems, we fork an external process (umountd) that will take care of
periodically attempt to unmount, and optionally rmdir.
BUG: 1129939
Change-Id: Ia91167c0652f8ddab85136324b08f87c5ac1e51d
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8649
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5a939780ad0532c39d8cf3055f9c2be815df0b76
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Oct 2 02:14:07 2014 +0200
POSIX filesystem compliance: PATH_MAX
POSIX mandates the filesystem to support paths of lengths up to
_XOPEN_PATH_MAX (1024). This is the PATH_MAX limit here:
http://pubs.opengroup.org/onlinepubs/009604499/basedefs/limits.h.html
When using a path of 1023 bytes, the posix xlator attempts to create
an absolute path by prefixing the 1023 bytes path by the brick
base path. The result is an absolute path of more than _XOPEN_PATH_MAX
bytes which may be rejected by the backend filesystem.
Linux's ext3fs PATH_MAX seems to defaut to 4096, which means it
will work (except if brick base path is longer than 2072 bytes but
it is unlikely to happen. NetBSD's FFS PATH_MAX defaults to 1024,
which means the bug can happen regardless of brick base path length.
If this condition is detected for a brick, the proposed fix is to
chdir() the brick glusterfsd daemon to its brick base directory.
Then when encountering a path that will exceed _XOPEN_PATH_MAX once
prefixed by the brick base path, a relative path is used instead
of an absolute one. We do not always use relative path because some
operations require an absolute path on the brick base path itself
(e.g.: statvfs).
At least on NetBSD, this chdir() uncovers a race condition which
causes file lookup to fail with ENODATA for a few seconds. The
volume quickly reaches a sane state, but regression tests are fast
enough to choke on it. The reason is obscure (as often with race
conditions), but sleeping one second after the chdir() seems to
change scheduling enough that the problem disapear.
Note that since the chdir() is done if brick backend filesystem
does not support path long enough, it will not occur with Linux
ext3fs (except if brick base path is over 2072 bytes long).
BUG: 1129939
Change-Id: I7db3567948bc8fa8d99ca5f5ba6647fe425186a9
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8596
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 15f1608af33c42feb88b789459bf65b7d6c7e75e
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Sep 18 18:42:34 2014 +0200
test/ec: Fix spurious failures caused by self-heal
The sha1sum of a file may update the access time of that file.
If this happens while a brick is down, as it is forced in the
test, that brick doesn't get the update, getting out of sync.
When the brick is restarted, self-heal repairs the file, but
the test shouldn't access brick contents until self-heal finishes.
If this is combined with a kill of another brick before self-heal
has finished repairing the file, the volume could become inaccessible.
Since the purpose of these tests is only to check ec functionality
(there is another test that checks self-heal), the test that corrupts
the file has been removed.
Additional checks to validate the state of the volume have been added
to avoid some timing issues.
BUG: 1144108
Change-Id: Ibd9288de519914663998a1fbc4321ec92ed6082c
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8892
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2ab9d340cc077dcb8b27455e0e2af533dbf7f668
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Sep 30 17:47:26 2014 +0200
ec: Add state dump support
Change-Id: I4504f3050674dde217e79af28cb4d2b5370fe2d5
BUG: 1148010
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8891
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 48670fc77708468f73c21c21f67c8b91c9358226
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Sep 29 17:27:14 2014 -0400
extras: reverse test for '}' vs. following 'else' placement
The two-line form "}\nelse {" has been more common than the one-line
form "} else {" in our code for years, and IMO for good reason (see
the comment in the diff).
Change-Id: Ic22c76fe76f0d91300daff36e755a18a8db58852
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8888
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d2e5ad30aa1afa5eeac0f09b65f70d983a41b90f
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Sep 29 20:03:58 2014 +0200
gNFS: allow truncate() from SETATTR over NFS for owner
NFSv3 does not have a TRUNCATE procedure, instead it is part of the
SETATTR (change the 'size' attribute). SETATTR with a new 'size'
succeeds on other NFS-servers, even when the owner of the file does not
have write permissions. Make Gluster/NFS behave the same way, by
checking if the RPC/pid comes from the NFS-server, and allow truncate()
when the file is owned by the user calling SETATTR.
BUG: 955753
Change-Id: I4b7cb8efe5a2032c6cd2eef6af610032f76d8b39
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8889
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
commit 4a31663c40ea36e8f4be267d94c3e9b710c08307
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Oct 1 06:18:50 2014 +0200
Regression test portability: truncate
Use truncate -s 1M instead of truncate --size=1m for portability sake
BUG: 1129939
Change-Id: I5bf6ca1f9bb4fa3c91796a659a06bf368776b3e5
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8894
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 67bde1c2947c645cac8e3c52212fb688dff61f85
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 29 15:23:21 2014 +0200
Regression test portability: stat
Improve BSD compatibility for stat. The new version attemps to spawn
less stat subprocesses.
Also add translation for %X %Y and %Z
BUG: 1129939
Change-Id: I2b2134f9e8336a952aee6c7679ba0491abd5a35c
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8565
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 0aa17a0837027f1c2521ce9457237309f295beea
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Sep 22 17:56:57 2014 +0200
Regression test portability: rpmbuild
rpmbuild is required, check for its presence.
BUG: 1129939
Change-Id: Iae8534bf897a4605620277688a180d6542c1c80b
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8810
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit b1b185e4c9af6ddcb37d5365fcc8941cb18d84e0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Aug 20 21:50:06 2014 +0530
cluster/afr: Add afr-v1 xattr compatibility
All the special cases v1 handles and also
self-accusing pending changelog from v1 pre-op also is handled
in this patch.
Change-Id: Ie10f71633fb20276f01ecafbd728f20483e7029c
BUG: 1128721
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8536
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 247a9ac7b4644efab1ac352321df53bd5e08714a
Author: vmallika <vmallika@redhat.com>
Date: Mon Sep 29 13:02:30 2014 +0530
glusterd/quota: Heal pgfid xattr on existing data when the quota is enable
The pgfid extended attributes are used to construct the ancestry path
(from the file to the volume root) for nameless lookups on files.
As NFS relies on nameless lookups heavily, quota enforcement through NFS
would be inconsistent if quota were to be enabled on a volume with
existing data.
Solution is to heal the pgfid extended attributes as a part of lookup
perfomed by quota-crawl process. In a posix lookup check for pgfid xattr
and if it is missing set the xattr.
Change-Id: I5912ea96787625c496bde56d43ac9162596032e9
BUG: 1147378
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8878
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 95bf3477ae193d5368f384b86b7190d58436fb90
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Sep 29 03:06:24 2014 +0200
Fix invalid seekdir() usage
According to POSIX, seekdir() should only be given offset obtained from
telldir() on the same DIR *
http://pubs.opengroup.org/onlinepubs/9699919799/functions/seekdir.html
Code from afr-self-heald.c and index.c is operating outside of the
specification, by doing using seekdir() with offset from a previously
open/close/re-open directory. This seems to work on Linux (although with
no guarantee it will always in the future). On NetBSD the seekdir()
with a in invalid offset is a nilpotent operation, and causes an infinite
loop, since index_fill_readdir() always restart from the beginning of the
directory.
The situation is fixed by using a non anonymous fd in afr-self-heald.c:
we explicitely open the directory so that it remains open on the brick
side during the timeframe where we want to reuse offsets in seekdir().
This requires adding an opendir fop in index xlator.
If the brick was not updated, the opendir will fail and we fallback
to the standard violating approach for backward compatibility on Linux.
On other systems we fail since it never worked.
While there, add tests to check seekdir() success in index and posix
xlators, so that incorrect usage from calling code produce an explicit
error instead of an infinite loop. We can only do it on non Linux systems,
for the sake of backward compatibility when the brick was updated but
not the client.
BUG: 1129939
Change-Id: I88ca90acfcfee280988124bd6addc1a1893ca7ab
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8760
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9f0cc8274d916784d5aab4760894bee844fbad0b
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Sep 29 15:48:55 2014 +0200
doc: added documentation for dispersed volumes
Change-Id: I8a8368bdbe31af30a239aaf8cc478429e10c3f57
BUG: 1147563
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8885
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 311aa94b974205b0eee4c75f99ffb4bcaaa626d7
Author: GauravKumarGarg <ggarg@redhat.com>
Date: Mon Sep 29 14:03:49 2014 +0530
glusterd: Perform brick order check in originator node.
Currently in case of multi node cluster brick-order check for
replicate volume done on every node. Its waste of time to perform
brick order check on every node.
This change will perform brick order check only at originator node.
Change-Id: I8687fd28e587de8a280a9003b015ccd5729c9740
BUG: 1091935
Signed-off-by: ggarg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/8881
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit 13e5f33056755cb8f69ab4bb1546e1c39093aa77
Author: Sachin Pandit <spandit@redhat.com>
Date: Thu Sep 25 08:32:52 2014 +0530
USS : Decide the log entry based on the type of graph.
Problem : When a lookup is issued, and if the entry is not found
then snapview-client will log failure stating that
"Lookup on normal graph failed with error Stale file handle"
irrespective of type of graph it received call back from.
Solution : Introduced a check to find out the graph from which
the snapview-client received call-back.
Change-Id: Iadd5b525c394be3675d40231711058e1cf1396cd
BUG: 1146479
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8851
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7b2d9af64dc94baaffffa78901b9325c1980eddd
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Sep 17 11:33:23 2014 +0530
cluster/afr: Launch self-heal only when all the brick status is known
Problem:
File goes into split-brain because of wrong erasing of xattrs.
RCA:
The issue happens because index self-heal is triggered even before all the
bricks are up. So what ends up happening while erasing the xattrs is, xattrs
are erased only on the sink brick for the brick that it thinks is up leading to
split-brain
Example:
lets say the xattrs before heal started are:
brick 2:
trusted.afr.vol1-client-2=0x000000020000000000000000
trusted.afr.vol1-client-3=0x000000020000000000000000
brick 3:
trusted.afr.vol1-client-2=0x000010040000000000000000
trusted.afr.vol1-client-3=0x000000000000000000000000
if only brick-2 came up at the time of triggering the self-heal only
'trusted.afr.vol1-client-2' is erased leading to the following xattrs:
brick 2:
trusted.afr.vol1-client-2=0x000000000000000000000000
trusted.afr.vol1-client-3=0x000000020000000000000000
brick 3:
trusted.afr.vol1-client-2=0x000010040000000000000000
trusted.afr.vol1-client-3=0x000000000000000000000000
So the file goes into split-brain.
Change-Id: I1185713c688e0f41fd32bf2a5953c505d17a3173
BUG: 1142601
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8755
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e5e104aae0bed7634831b223389e4a7e3bf1b2b9
Author: Anuradha <atalur@redhat.com>
Date: Fri Sep 26 14:18:05 2014 +0530
cluster/afr : Fix incorrect looping of index healer
Sending appropriate return value from afr_selfheal()
fixes the issue.
Credits : Krutika Dhananjay and Pranith Kumar.
Change-Id: I01dbd49476f6bfbd02028fdde1f60cc0324a1e39
BUG: 1146812
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/8868
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit baa857eb9628056fa25a39dc27d2d0a2587dd8fc
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Sep 26 10:12:47 2014 -0700
Sane default for SSL on OSX
- /opt/local is not preferred anymore use /usr/local
Change-Id: I30cad4cbd28850063f26121cace05371e13bb314
BUG: 1129939
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8872
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2dfd3f8d7aebc9a7c2c0aabe55aff5e5045e7b5f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Aug 29 10:42:02 2014 +0000
glusterfs: allow setxattr of keys with null values.
Disk based file systems allow to get/set extended attribute key-value pairs where
value can be null. Fuse/libgfapi clients must be able to do the same on a
gluster volume.
Change-Id: Ifc11134cc07f1a3ede43f9d027554dcd10b5c930
BUG: 1135514
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/8567
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 14391148ec48b04328fd5305809b672a8950b201
Author: Kotresh HR <khiremat@redhat.com>
Date: Thu Sep 25 17:34:43 2014 +0530
geo-rep: Fix rename of directory syncing.
The rename of directories are captured in all distributed
brick changelogs. gsyncd processess these changelogs on
each brick parallellaly. The first changelog to get processed
will be successful. All subsequent ones will stat the 'src'
and if not present, tries to create freshly on slave. It
should be done only for files and not for directories.
Hence when this code path was hit, regular file's blob
is sent as directory's blob and gfid-access translator
was erroring out as 'Invalid blob length' with errno as
'ENOMEM'
Change-Id: I50545b02b98846464876795159d2446340155c82
BUG: 1146823
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8865
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 97df8cb6d6cff9bf0c18eb41f13411d4c11552a3
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Sep 29 08:48:40 2014 +0530
cluster/afr: Fix inode leak
Change-Id: I723b65d6fcae5bd39c0daece3b2f48baf0a72166
BUG: 1145471
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8875
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 3e2e2b0903bd68414ad2285c4f7b32029d1a93bd
Author: hchiramm <hchiramm@redhat.com>
Date: Thu Sep 25 11:28:21 2014 +0530
spec: Change summary of glusterfs to distributed file system.
BUG:1146519
Change-Id: I9b24321d9e677b535f8d79691862cf919553d635
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8844
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit 76f9e06f660757a99213092aaa4a7dd615dd79fe
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Sep 23 07:46:16 2014 +0200
Use sane OS-dependent defaults for SSL configuration
Current code assumes /etc/ssl exists, which may not be the case.
Attempt to guess sane default for a few OS.
BUG: 1129939
Change-Id: I0f3168f79b8f4275636581041740dfcaf25f3edd
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8790
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 226e17362145a4c0a744fe79716215e80c0f7f26
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Sep 25 15:28:03 2014 +0200
Do not forbid fallocate on non Linux systems
Linux fallocate() differs from posix_fallocate() by
an extra flag that can have the FALLOC_FL_KEEP_SIZE value;
Do not test FALLOC_FL_KEEP_SIZE existence to enable fallocate()
in posix xlator, as sys_fallocate() in libglusterfs provides
support for both implementations.
BUG: 1129939
Change-Id: Idf41a0396028a15e81281791bf6912d7fd674e3f
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8856
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 64541a48ae861882f39180277ddbe258e0a8f8fe
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Sep 25 16:27:52 2014 +0530
cluster/afr: More dict_t leak fixes
Change-Id: I6618b7b2df0f88a3e6252f9136135cf402147a37
BUG: 1134221
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8852
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit dc0426b416014ae780abede018f5b69d2932bb74
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 25 09:11:46 2014 -0400
glusterfs.spec.in: add psmisc to -server subpackage
apparently some minimalist installs omit psmisc
psmisc is needed for the killall in various %pre and %post scriptlets
smarter logic for restarting glusterd in %post server
Change-Id: I505573b364cc27321bb4117a387bdf71fe3ce310
BUG: 1146426
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8867
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit ac4bbb32c1832bb25cb136713dc762030871a297
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Sep 17 12:59:52 2014 +0530
geo-rep: fix same file different gfid in master and slave
While processing RENAME in changelog, if the file is unlinked
in master, then geo-rep was sending UNLINK to slave instead of
RENAME.
If rsync job fails if one of the file failed to sync in the job.
This patch adds logic to remove GFID from data list if the same
changelog has UNLINK entry for it after the DATA. Or it removes
those GFIDs during retry of changelogs processing.
BUG: 1143853
Change-Id: I982dc976397cd0ab676bb912583f66a28f821926
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/8761
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 7a6ad557d25a90724352b3c1f5f8d91c5613846d
Author: Gaurav Kumar Garg <ggarg@redhat.com>
Date: Wed Sep 10 17:33:20 2014 +0530
glusterd: file-snapshot and features-encryption options should be validate correctly
By giving non-boolean value to volume set command for features.file-snapshot
and features.encryption option the command failed after that subsequent
volume set request with valid value of the existing any volume set option
fail.
Previously when user supplies a non-boolean value in volume set command
for features.file-snapshot and features.encryption option's then
validation of that value was done by volinfo->dict but actual value
of that option store in input dictonary. Now with this change it
will refer correct dictonary for validation of supplies value.
Change-Id: I4a93d8be848cd33fdf4b4eb9b1a8d15ec9d1e66a
BUG: 1140162
Reviewed-on: http://review.gluster.org/8688
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit b1f87178a7ee71efbf5382979bfaef3180b460cd
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Sep 16 17:11:39 2014 +0200
32 bit fix: use off_t and not size_t for truncate()
Make sure off_t and not size_t is used when holding file offsets for
ftruncate()/truncate(). It works on 64 bit machines where
sizeof(size_t) == sizeof(off_t) == 8, but breaks for big offsets on 32 bit
machines because sizeof(size_t) == 4 and sizeof(off_t) == 8
BUG: 1129939
Change-Id: Ia2637be772ba9b11731d59fdbffbd269f0ff56c8
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8742
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1945e1cb3232a4897cb1ba8003c30c960e09216e
Author: Bala.FA <barumuga@redhat.com>
Date: Wed Jul 2 14:21:39 2014 +0530
build: remove /sbin/ldconfig as interpreter
using /sbin/ldconfig as interpreter in pre/post/postun throws error
/sbin/ldconfig: relative path `1' used to build cache
BUG: 1145989
Change-Id: Ic321f200d92d2e49ff797965a006f63f483d29be
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/8835
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 428ce3153b1e092c894a1f531d44223b446ca1e9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Sep 23 17:03:53 2014 +0530
cluster/afr: Fix locking issues in entry self-heal
Original reporter of the bug & designer of the solution:
Pranith Kumar K <pkarampu@redhat.com>
Change-Id: I9ed89aa92e4cd0f8049f5f6c7a3701e52989ae5e
BUG: 1128721
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8837
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 645bcf919dea96d3730bc5ce806197f13cf81ef0
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Sep 24 15:52:58 2014 -0700
OSX/FreeBSD: Regression fix
Introduced in "1f6e992f1aaa676be5bd47d17e58f1171825cf43"
Change-Id: I655cf613ca93a749ab5403cb3ec038e739993e2e
BUG: 1146279
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8841
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Justin Clift <justin@gluster.org>
commit 97063ff707244c196c9d3615e80753c55100246b
Author: ggarg <ggarg@redhat.com>
Date: Tue Apr 29 09:58:16 2014 +0530
glusterd: Move brick order check from cli to glusterd.
Previously the brick order check for replicate volumes on volume
create and add-brick was done by the cli. This check would fail
when a hostname wasn't resolvable and would question the user
if it was ok to continue. If the user continued, glusterd would
fail the command again as the hostname wouldn't be resolvable.
This was unnecessary.
This change, moves the check from cli into glusterd. The check
is now performed during staging of volume create after the
bricks have been resolved. This prevents the above condition
from occurring.
As a result of this change, the user will no longer be
questioned and given an option to continue the operation
when a bad brick order is given or the brick order check
fails. In such a case, the user can use 'force' to bypass
the check and allow the command to succeed.
Change-Id: I009861efaf3fb7f553a9b00116a992f031f652cb
BUG: 1091935
Signed-off-by: ggarg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/7589
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 5eea7464050a71f2924a531715c42affa874a805
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Sep 13 12:08:56 2014 +0530
cluster/afr: Fix spurious metadata self-heals
- Added logging for metadata and data self-heals which helped
in debugging this issue.
- Added checks to skip self-heals when no sinks are available to heal
Change-Id: I0d50dceb84cd9ad4fe00e0b749ddf7d4ff42348a
BUG: 1128721
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8709
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit df08e8e61334f41e2e87cdf0a09370fd30ff773e
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Sep 19 19:08:05 2014 +0530
protocol: Log ENODATA & ENOATTR logs at DEBUG loglevel in removexattr_cbk.
Prevents messages of the following type from being seen by default in the log files:
[2014-09-19 07:57:39.877806] W
[client-rpc-fops.c:1232:client3_3_removexattr_cbk] 0-<volume_name>-client-0:
remote operation failed: No data available
[2014-09-19 07:57:39.877963] W
[client-rpc-fops.c:1232:client3_3_removexattr_cbk] 0-<volume_name>-client-1:
remote operation failed: No data available
Change-Id: I3b1a121b0fc272eb772547275bb8085ed19db5a1
BUG: 1144527
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/8781
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 34bae73c9c35e80c51678e0e605d8723a34e24a0
Author: Anuradha <atalur@redhat.com>
Date: Tue Sep 23 18:24:09 2014 +0530
cluster/afr: Fixed mem leaks in self-heal code path.
AFR_STACK_RESET previously didn't cleanup afr_local_t,
leading to memory leaks. With this patch, cleanup is
done.
All credit goes to Pranith Kumar Karampuri.
Change-Id: I3c727ff4bb323dccb81da4b3168ac69bb340d17d
BUG: 1145471
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/8821
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 26fb176c26cd4c5933251c6d282040a79eea79ed
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Sep 22 16:48:50 2014 -0400
build: remove warnings for recommended style
Specifically:
* space before function arguments
* brace around single statement
Ideally we would *reverse* these tests so they warn under the exact
opposite conditions, but that would mean learning the internals of a
script written in a defective language with cryptic variable names and
too few comments. Life's too short. For now, just cutting down on some
of the spam (which might obscure more serious issues) should suffice.
BUG: 1120646
Change-Id: I5ec684d0d788a34f29af9b1761743c8860973993
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8813
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 5eb86abdc75ec6573989c94318667228cf8c3f52
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Sep 22 10:59:37 2014 -0700
extras/checkpatch.pl: update coding guidelines script
- Allow 'quoted string split across lines' since its a
GlusterFS common practice
- Remove a useless "+" - perl 5.20 complains with following
warning "Useless use of greediness modifier '+'"
Change-Id: Ibaf276ec84757b3ecc3e6db7f5e720b8e8a12dff
BUG: 1120646
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8811
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 44f29f122582321f08f5bb67c4a914c004a70795
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Sep 23 07:03:11 2014 +0530
doc/snapshot : admin guide updation.
Change-Id: I1980bc0984f941cd415fbc754495353f561155a8
BUG: 1145069
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8817
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b9696962ac73bd3bc577a507d3c1f4838178b3be
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Sep 20 06:57:24 2014 +0200
Do not hardcode setfattr(1) path
Turn setfattr(1) absolute path into an OS-dependant macro. Let compiler
option override it to fit custom installation if needed.
BUG: 1129939
Change-Id: I8f469c5741a85b6e8d8f6299a9540b3d64611d2f
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8786
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit afa3e73186a98ea30179763e5c1c33486a8dbc49
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Sep 18 16:50:47 2014 +0200
ec: Add config information in an xattr
To simplify backward compatibility of the ec xlator when some
parameter or the implementation itself is changed, a new xattr
is added to each file with the configuration needed to recover
it.
The new attribute is called 'trusted.ec.config', and it's a 64-bit
value containing the following information:
8 bits: version of the config information (currently always 0)
8 bits: algorithm used to encode the file (currently always 0)
8 bits: size of the galois field (currently always 8)
8 bits: number of bricks
8 bits: redundancy
24 bits: chunk size (currently 512)
This new xattr could allow, in a future version, to have different
configurations per file.
Change-Id: I8c12d40ff546cc201fc66caa367484be3d48aeb4
BUG: 1140861
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8770
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 69321a97e93122d480d8c0c4ae4b15ece464ebfe
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Sep 23 04:53:47 2014 +0530
test : Fix for spurious failure
Problem : Once the features.uss is enabled it does not wait for
the process to be created. And if we try to check for
the pid of the snapd then it will not be present which
causes a failure.
Solution : Adding a EXPECT_WITHIN which waits to get the pid
until certain time period.
Change-Id: If075860173a996f9eee13b346e939686b94ec3f6
BUG: 1145450
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8814
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1639f6431781efc98e3dd3d9ccd6976364b4519b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Sep 18 18:26:08 2014 +0530
cluster/afr: Do not reset pending xattrs on gfid or type mismatch in entry-sh
Change-Id: Ie27219a376382e2455a0fcc094f8b7eb243738ae
BUG: 1140613
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8816
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6a741f7bac546c488d837b7596e29f4d6856c740
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Sep 23 12:43:02 2014 +0530
cluster/afr: Don't start heal when lookup succeeds on < 2 children
Problem:
When self-heal code doesn't see at least 2 successes on looking up children,
then self-heal can't be done. What is happening now is if all the lookups fail
then the pending changelog is all zeros in xattrs so all the children are
becoming sources and leading to crashes when the code paths further assume that
some data structures are populated properly
Fix:
Don't proceed with self-heals when < 2 children succeed lookups.
BUG: 1128721
Change-Id: Iffdf0feebb6f98812d9d01cdd0cf97f3e19ba76f
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8698
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit dbb1d806d48d937e7a68577f69132bb4c6918c00
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jun 19 15:31:46 2014 +0530
glusterd: Authenticate management handshake requests
Management handshake requests, which are used to validate op-version
supported by the peers, are now only allowed if,
- the glusterd doesn't have any other peer, or
- the request was sent by another peer.
This prevents the op-version of a peer being changed because of a
connection attempt by an invalid peer.
Change-Id: I248c386ed5ec4f8360e7b5e7f9ab74b7e8a7fc65
BUG: 1109741
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/8126
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 0b13c38b58c34fabbb38243d8db74044398caf9b
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Mon Sep 22 13:29:13 2014 +0530
cluster/dht: Modified the calculation of brick_count
Whenever new_layout is calculated for a directory,
we calculate the number of childs of dht, who will get
the actual(Non-zero) layout-range, and assign range
to only those subvolume and other will get 0 as
their layout->start and layout->stop value.
This calculation is based on either
a) weight_by_size or
b) number of brick who will be assigned the non-zero range
So if in case we are not assigning the layout based
on weight_by_size, we should choose the "bricks_to_use"
instead of "bricks_used".
In regression test,
we found that priv->du_stat[0].chunks was zero. In this
case "bricks_used" variable will be zero, which will cause
crash for
chunk = ((unsigned long) 0xffffffff) / bricks__used;
calculation.
Change-Id: I6f1b21eff972a80d9eb22771087c1e2f53e7e724
BUG: 1143835
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8792
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 08211eeb3117ce702c69555ea8e48b76e57327aa
Author: hchiramm <hchiramm@redhat.com>
Date: Mon Sep 22 11:07:46 2014 +0530
doc: Include details of thin volume creation in snapshot guide.
Change-Id: I12b49c0e8af2cc3d91c29300fdfc47d772d380d7
Signed-off-by: hchiramm <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8791
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e73ae33dd122afc61bebc6fe3aac63292a22abd7
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Sep 5 14:55:01 2014 +0530
synctask: add backtrace per waiting task
The backtrace is 'saved' in a per-task buffer.
This would come handy while debugging code using
synctasks.
Change-Id: I732b275f6d15b31f31361f5ecf2ba47cacde9b54
BUG: 1138503
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/8622
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bf161cf9346a72408bff76b79296b3a0cc9345c9
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Sep 3 11:03:06 2014 +0530
glusterd: Add last successful glusterd lock backtrace
Also, moved the backtrace fetching logic to a separate function.
Modified the backtrace fetching logic able to work under memory pressure
conditions.
Change-Id: Ie38bea425a085770f41831314aeda95595177ece
BUG: 1138503
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/8584
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit 7d8eb0c6f6fb6a54193946dee47d70588fc5d3fd
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 16 14:05:17 2014 -0400
tests: regression, can't run `prove $t` in subdirs
In various tests we already use the pattern:
. $(dirname $0)/../include.rc
to locate various .rc files.
Use the same pattern we already use to also find the new env.rc
Change-Id: I0d438446fa00be2c143b5cf46025866182c94814
BUG: 1142419
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/8754
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9aa1645528d4aafd17aff46c3a5a4827cb556919
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Sep 18 14:36:38 2014 +0530
cluster/dht: Fix dict_t leaks in rebalance process' execution path
Two dict_t objects are leaked for every file migrated in success codepath.
It is the caller's responsibility to unref dict that it gets from calls to
syncop_getxattr(); and rebalance performs two syncop_getxattr()s per file
without freeing them.
Also, syncop_getxattr() on GF_XATTR_LINKINFO_KEY doesn't seem to be using
the response dict. Hence, NULL is now passed as opposed to @dict to
syncop_getxattr().
Change-Id: I5a4b5ab834df3633dea994f239bbdbc34cbe9259
BUG: 1142052
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8763
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1e9a90aee698c6d383003f1b9430fba253594b7a
Author: Gu Feng <flygoast@126.com>
Date: Tue Sep 9 18:00:22 2014 +0800
socket: Fixed parsing RPC records containing multi fragments
In __socket_proto_state_machine(), when parsing RPC records containing
multi fragments, just change the state of parsing process, had not
processed the memory to coalesce the multi fragments.
Change-Id: I5583e578603bd7290814a5d26885b31759c73115
BUG: 1139598
Signed-off-by: Gu Feng <flygoast@126.com>
Reviewed-on: http://review.gluster.org/8662
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 239f9a29ec6530a1b8306006935783f2ee11def8
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Sep 10 23:43:07 2014 +0200
ec: Fix invalid inode lock in ftruncate
The fops 'truncate' and 'ftruncate' share some code and inodelk()
was always made against the inode inside the loc_t structure
instead of that of fd_t. Since ftruncate has the loc initialized
to NULL, this fop was executed without any lock, allowing some
concurrent modifications in the file size.
Also changed the way in which 'fop' and 'ffop' are differentiated
in shared code. Now it uses 'id' field instead of checking if 'fd'
is NULL.
Change-Id: Ibd18accf2652193b395a841b9029729e5f4867c6
BUG: 1140396
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8695
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit beb55386889f4145639d1898971af822923dffb0
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Sep 15 11:57:43 2014 +0200
ec: Fix some size_t vars to 64 bits even on 32 bits machines
The 64 bits 'trusted.ec.size' extended attribute was incorrectly
computed on 32 bits machines due to an overflow on negative
numbers.
Also changed some potentially dangerous uses of size_t in other
places.
Change-Id: Id76cfe49a2f350e564b5c71d8c8644fb9ce86662
BUG: 1125312
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8738
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8dad87b96748450cd78b9e3a9ab79617e5fc3207
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Jun 25 21:22:49 2014 -0700
extras/checkpatch.pl: linux kernel style patch verification
This is to bring in adherence to coding policy, prior to patch
submission for review.
- no tabs
- no whitespace
- indentation (linux style) etc.
This is in the interest at large for the GlusterFS codebase
to be more cleaner and readable.
./rfc.sh - now supports running this for all patches diverged
from "origin/master" revision.
NOTE: One should take this as a handle for good guidelines and
never use it as a tool for correctness, use common-sense in all
the cases ;-)
Change-Id: Ib9a5ed207cde152cb92b8d38cec83e8ce9ef7f28
BUG: 1120646
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8181
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anders Blomdell <anders.blomdell@control.lth.se>
commit 9687134daaa5a6b85a7205fa2d39b54b8531a770
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sun Jun 8 00:46:29 2014 +0530
storage/posix: Log when mkdir is on an existing gfid but non-existent path.
consider following steps on a distribute volume
1. rename (src, dst) on hashed subvolume
2. snapshot taken
3. restore snapshots and do stat on src and dst
Now, we end up with two directories src and dst having same gfid,
because of distribute creating directories on non-existent subvolumes
as part of directory healing.
This can happen even with race between rename and directory healing in
dht-lookup. This can lead to undefined behaviour while accessing any
of both directories. Hence, we are logging paths of both
directories, so that a sysadmin can take some corrective action when
(s)he sees this log. One of the corrective action can be to copy
contents of both directories from backend into a new directory and
delete both directories.
Since effort involved to fix this issue is non-trivial, giving this
workaround till we come up with a fix.
Change-Id: I38f4520e6787ee33180a9cd1bf2f36f46daea1ea
BUG: 1105082
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8008
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit c17eb0b6a5e7af5fb18b560e4cd0496ab89f6c2f
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Sep 4 23:58:18 2014 +0530
syncop: Invoke dict_unref() in inodelk only if dictionary is not NULL
In the absence of this check, logs can get flooded with messages like this when rebalance is run:
[2014-09-04 17:48:07.148262] W [dict.c:480:dict_unref] (-->/lib64/libc.so.6()
[0x30daa47a00] (-->/usr/local/lib/libglusterfs.so.0(synctask_wrap+0x12)
[0x7fa20b7c6ec2]
(-->/usr/local/lib/glusterfs/3.7dev/xlator/cluster/distribute.so(dht_migrate_file+0x23f)
[0x7fa200fdb58f]))) 0-dict: dict is NULL
Change-Id: I4c93e4485293b35d86ba07df4d583d2758ec3f49
BUG: 1130888
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/8601
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 4cb13fc34490720c01067d275702457bd841155a
Author: Anuradha <atalur@redhat.com>
Date: Mon Sep 8 18:32:04 2014 +0530
cluster/afr: Set all the xattrs needed by index xlator
Index xlator removes the index file from indices
xattrop directory in case the value for keys sent
are zero.
If all the required keys are not set by afr
then index file might be removed in an invalid
way.
With this change all the keys required by index
xlator are set by afr such that invalid removal of
files does not occur.
Change-Id: Idbed0764a95157fd5cab8d6685057a43788fc7df
BUG: 1139230
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/8652
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit d45023257e8959f4aff5d7e04f7bdd5d2e446d99
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Aug 7 06:37:30 2014 +0200
Regression test portability: arequal-checksum
Emulate GNU libc extension FTW_SKIP_SUBTREE for system that lack it.
FTW_ACTIONRETVAL is another GNU libc extension we just ignore now.
BUG: 764655
Change-Id: I25d9641055a30fe72b4e248f51b53b2a3ba637e9
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8427
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d6589c8c6c6bb61304ea612590fee43c91afdf99
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Aug 10 10:08:52 2014 +0200
Do not assume sizeof(size_t)
This fixes an assumption that sizeof(size_t) == sizeof(uint64_t), which
is not guaranteed. At least on NetBSD/i386, size_t is 32 bit long.
Caught by tests/basics/file-snapshot.t
BUG: 764655
Change-Id: Ib7620a2ffe8758521886af37bc280101a040d860
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8441
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 6fd9fc554d3ed032e1f645351af69bc25a92af41
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Thu Sep 11 17:31:59 2014 +0530
cluster/dht: Changed log level to DEBUG
Change-Id: Ia4dde95367b44d63f57f0840c2a2f351b1cfb072
BUG: 1138602
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8697
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 58b7605b615ab831db916db4bbbed24cbef02962
Author: Justin Clift <justin@gluster.org>
Date: Wed Jun 25 22:52:50 2014 +0100
Typo fix THANKS message
BUG: 1142045
Change-Id: I9323453d475779a01516adcb4c959e6ac4cf689c
Reviewed-on: http://review.gluster.org/8174
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dc19c7c2ec6f82d7e5ce5eb3789e1679df3ff41e
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Jul 14 17:34:04 2014 +0200
ec: Optimize read/write performance
This patch significantly improves performance of read/write
operations on a dispersed volume by reusing previous inodelk/
entrylk operations on the same inode/entry. This reduces the
latency of each individual operation considerably.
Inode version and size are also updated when needed instead
of on each request. This gives an additional boost.
Change-Id: I4b98d5508c86b53032e16e295f72a3f83fd8fcac
BUG: 1122586
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8369
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit c15f8e40113beb74402401592bad200c0eca2c30
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Jul 15 13:42:28 2014 +0200
ec: Only heal data/metadata when inode has enough information
Sometimes loc_t structure in a heal request doesn't contain enough
information to do an inodelk call (basically the gfid is missing).
In these cases, self heal only recovers entry information.
Change-Id: I459990c7df728ff4baf164df046672ddcde3efa5
BUG: 1122581
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8368
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 83f6cbeeeb3c0cc7d804a39b7d72a2ccd7d9a29e
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Sep 10 16:51:19 2014 +0530
features/quota: fixes to dentry management code in rename.
1. After a successful rename (src, dst), the dentry
<dst-parent, dst-basename> would be associated with src-inode.
2. Its src inode that survives if both of src and dst are present.
The fixes are done based on the above two observation.
Change-Id: I7492a512e3732b1455c243b02fae12d489532bfb
BUG: 1140084
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8687
Reviewed-by: susant palai <spalai@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0d1cbd7037186984db6c97a967a52cbd2eb16f6f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Sep 14 16:51:25 2014 +0530
cluster/afr: Handle EAGAIN properly in inodelk
Problem:
When one of the brick is taken down and brough back up in a replica pair, locks
on that brick will be allowed. Afr returns inodelk success even when one of the
bricks already has the lock taken.
Fix:
If any brick returns EAGAIN return failure to parent xlator.
Change-Id: I5b842d0fc094359cc4231494053d2bfeb606bbbe
BUG: 1141539
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8710
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit af6a511344b7924777c33ec4379dd65d43e5169d
Author: Justin Clift <justin@gluster.org>
Date: Mon Sep 15 08:44:25 2014 +0100
osx: LaunchDaemon plist filename should start with org instead of com
Change-Id: I5e06bcc473224667387c555355d7e1e81bf4911b
BUG: 1141659
Reviewed-on: http://review.gluster.org/8734
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c2b02f5a26c2aa0db20491ddd87746d368e13df2
Author: Justin Clift <justin@gluster.org>
Date: Mon Sep 15 09:48:05 2014 +0100
osx: Remove legacy extras/MacOSX directory
BUG: 1141682
Change-Id: Ic84171b070985a11b70d4548aa5e507a121d2164
Signed-off-by: Justin Clift <justin@gluster.org>
Reviewed-on: http://review.gluster.org/8736
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f43537a7ac9205340adf50604c40085823fb1666
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Sep 12 16:54:45 2014 +0530
tests: Fix typo in M2 definition
Thanks to Anoop CS for finding the bug
Change-Id: I237e3a396967096b8e49200aed279af970e0a4d5
BUG: 1141167
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8707
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Justin Clift <justin@gluster.org>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3b5bf79eefb3bb2f40987ebc19232bb54d9e0e25
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jul 17 12:15:54 2014 +0530
snapview-server: get the handle if its absent before doing any fop
* Now that NFS server does inode linking in readdirp, it can resolve the
gfid (i.e. find the right inode from its inode table) present in the
filehandle sent by the NFS client on which a fop came. So instead of
sending the lookup on that entry, it directly sends the fop. But
snapview-server does not get the handle for the entries in readdirp
(because doing a lookup on each entry via gfapi would be costly. So it
waits till a lookup is done on that inode, to get the handle and the
fs instance and fill it in the inode context). So when NFS resoves the
gfid and directly sends the fop, snapview-server will not be able to
perform the fop as the inode contet would not contain the fs instance
and the handle. So fops should check for the handle before doing gfapi
calls. If the handle and fs instance are not present in the inode context
they should get them by doing an explicit lookup on the entry.
Change-Id: Idd648fbcc3ff6aadc3b63ff236561ca967b92f5d
BUG: 1115949
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8324
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3847521fe85deb752fbc761b6b1971c4cbe861d8
Author: hchiramm <hchiramm@redhat.com>
Date: Fri Sep 12 11:37:09 2014 +0530
doc: Move bd translator documentation to xlators directory.
Change-Id: I21bd1cc6d0220035d28ca15e1e32b25a6c5a184a
Signed-off-by: hchiramm <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8700
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit ce81694e957c554e4e746caafe2e5b3d6cf1399f
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Sep 12 13:06:57 2014 +0530
test: cleanup should clean all left over (stale) mounts
This is a temporary work around to fix the spurious failures seen in ec
testcases. As per the initial analysis it looks like quota
(glusterd_quota_initiate_fs_crawl) is causing a mount point in /tmp to be stale.
Once the root cause is identified this fix can be reverted as well.
Change-Id: I8686f144ed298124074f749e75c13028ec00be01
BUG: 1092850
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8703
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Justin Clift <justin@gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4dc0af9f72d75202fbe0668a935bbafcbba7e9d8
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Aug 5 18:28:25 2014 +0200
ec: Do not destroy inode context on inode invalidation
Currently there is no need to handle inode invalidation requests,
so this callback has been removed.
Change-Id: I0ac2e47679bf62b1493e0403178305923bc036e8
BUG: 1126932
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8420
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 357d8a0227b998e9a63791fcb002ede188d500eb
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon Aug 4 20:50:31 2014 +0200
ec: Removed SSE2 dependency
This patch implements the Galois Field multiplications using pure C
code without any assembler support. This makes the ec xlator portable
to other architectures.
In the future it will be possible to use an optimized implementation
of the multiplications using architecture dependent facilities (it
will be automatically detected and configured). To allow bricks with
different machine word sizes to be able to work seamlessly in the
same volume, the minimum fragment length to be stored in any brick
has been fixed to 512 bytes. Otherwise, different implementations
will corrupt the data (SSE2 used 128 bytes, while new implementation
would have used 64).
This patch also removes the '-msse2' option added on patch
http://review.gluster.org/8395/
Change-Id: Iaf6e4ef3dcfda6c68f48f16ca46fc4fb61a215f4
BUG: 1125166
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8413
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
commit 6520c49ee96689a53caf76db7516d39cea7f0262
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Sep 10 23:39:19 2014 +0200
tests/ec: Avoid spurious umount failures
Change-Id: Id22d64a95adf3666a5e4208f87f9a6d91c40b267
BUG: 1092850
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8694
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e3a0294168a61942f85e4fc33a78797dfc638288
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue Sep 9 12:32:20 2014 +0530
cluster/dht: Changed log level to DEBUG
Change-Id: I7a4ee0c5a6a94bd4f31aff510a2971750913ed45
BUG: 1138602
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8621
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: susant palai <spalai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e35a0ef74b3aef2047aba7194e9d67c76f61062e
Author: Susant Palai <spalai@redhat.com>
Date: Tue Sep 9 06:05:24 2014 -0400
CLI: Show warning on remove-brick commit Signed-off-by: Susant Palai <spalai@redhat.com>
Change-Id: I48a4168f81bd272216549c76b0bc1b23e34894d6
BUG: 1136702
Reviewed-on: http://review.gluster.org/8664
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ff5e5cae9126b95045f310ea48b388d1d829d736
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Sep 9 11:33:14 2014 +0530
cluster/dht: fix memory corruption in locking api.
<man 3 qsort>
The contents of the array are sorted in ascending order
according to a comparison function pointed to by compar, which is
called with two arguments that "point to the objects being
compared".
</man 3 qsort>
qsort passes "pointers to members of the array" to comparision
function. Since the members of the array happen to be (dht_lock_t *),
the arguments passed to dht_lock_request_cmp are of type (dht_lock_t
**). Previously we assumed them to be of type (dht_lock_t *), which
resulted in memory corruption.
Change-Id: Iee0758704434beaff3c3a1ad48d549cbdc9e1c96
BUG: 1139506
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8659
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1faa1dcfbdc513b24e5cdcb8a9714cb459d8e8c5
Author: Shyam <srangana@redhat.com>
Date: Tue Sep 9 13:31:51 2014 -0400
cluster/dht: Fixed double UNWIND in lookup everywhere code
In dht_lookup_everywhere_done:
Line: 1194 we call DHT_STACK_UNWIND
and in the same if condition we go ahead and call, goto
unwind_hashed_and_cached; which at Line 1371 calls another UNWIND.
As is obvious, higher frames could cleanup their locals and on
receiving the next unwind could cause a coredump of the process.
Fixed the same by calling the required return post the first unwind
Change-Id: Ic5d57da98255b8616a65b4caaedabeba9144fd49
BUG: 1139812
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/8666
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: susant palai <spalai@redhat.com>
commit 77f1370202665e22aaa1ef7b205b238084e96f8b
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Sep 8 23:33:00 2014 +0530
doc: Remove volume rename from gluster's man page.
Change-Id: I5cde789088417f26d0c8319a1b24fdaa2c37dfe6
BUG: 1031328
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/8656
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b949e82d0a836c321f2e47f75fc51f429bdffb85
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Sep 8 21:52:30 2014 +0530
quota/marker: Fix dict leaks
Unref dicts in quota and marker functions before they return.
Change-Id: I772edc7b46657a70fb136e037576c65e9beeaca8
BUG: 1139327
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/8655
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 70ead6ec6be7f163442cc3aad568bb917582623f
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jun 17 00:28:01 2014 +0530
snapview-server: register a callback with glusterd to get notifications
* As of now snapview-server is polling (sending rpc requests to glusterd) to
get the latest list of snapshots at some regular time intervals
(non configurable). Instead of that register a callback with glusterd so that
glusterd sends notifications to snapd whenever a snapshot is created/deleted
and snapview-server can configure itself.
Change-Id: I17a274fd2ab487d030678f0077feb2b0f35e5896
BUG: 1119628
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8150
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8e883bf8ef3cd83940771dbfb517c776cb32e104
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Mon Sep 8 16:44:23 2014 +0530
gNFS: Fix memory leak in setacl code path
If ACL is set on a file in Gluster NFS mount (setfacl command),
and it succeed, then the NFS call state data is leaked. Though
all the failure code path frees up the memory.
Impact: There is a OOM kill i.e. vdsm invoked oom-killer during
rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
FIX:
Make sure to deallocate the memory for call state in acl3_setacl_cbk()
using nfs3_call_state_wipe();
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Change-Id: I9caa3f851e49daaba15be3eec626f1f2dd8e45b3
BUG: 1139195
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/8651
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 200b2f1ade61643b35973dce4b290632774a93d8
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Sep 1 14:07:15 2014 +0200
Always check for ENODATA with ENOATTR
Linux defines ENODATA and ENOATTR with the same value, which means that
code can miss on on the two without breaking.
FreeBSD does not have ENODATA and GlusterFS defines it as ENOATTR just
like Linux does.
On NetBSD, ENODATA != ENOATTR, hence we need to check for both values
to get portable behavior.
BUG: 764655
Change-Id: I003a3af055fdad285d235f2a0c192c9cce56fab8
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8447
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit ec73e6355f3a81d33216404c970c61f3fe39f2f0
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Sep 4 19:30:48 2014 +0530
tests: Don't check for init process.
As a way of checking for existence of pidof
we were checking for init process, which may
not be true in case of Containers.
Change-Id: I402e7ab4f2459057826ed24094e87dd605eaac8a
BUG: 1073168
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/8600
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 80c2271ad447f327b9b7f57dc44d3f43281e66b0
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Sep 3 20:49:53 2014 +0000
cluster/afr: perform list-xattr during lookup
Detect and heal mismatching user extended attributes during lookup.
'Forward' port of http://review.gluster.org/#/c/7444/
Change-Id: Id03c9746f083ffd3014711d0b3a2e5a71a45eed4
BUG: 1134691
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/8558
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6d43c17f4b56928c4e9465259f458f4ac5e4c70b
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Fri Sep 5 09:42:18 2014 +0530
RPM spec file: Fixed the description for glusterfs
Previously description was saying glusterfs is a
clustered file-system which changed to ditsributed
file-system.
Change-Id: I3ee80024ba317e912890ceff2080b82ce111be95
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/8619
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c3263a8add79ba483b8311d5c01164ae0652cbcc
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Sep 5 15:11:06 2014 +0200
Build fix: -lz for qemu-block xlator
LIBZ_LIBS has been changed into ZLIB_LIBS everywhere in the
sources, except in qemu-block xlator. Fix it so that it can
find -lz and link correctly.
BUG: 1129939
Change-Id: I34ded175f056d1a0898804fe602e3d2d2cba27f5
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8623
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 8e22454cb569f8967876d67e293ee57fbbf52f2e
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Aug 23 02:14:36 2014 -0700
porting: Provide setfattr/getfattr implementation
- Use 'getfattr' properly avoid redundant options during xattr query
- Untabify certain parts of tests (remove tabs)
- Avoid backtick evaluation for certain values to make code more portable.
- Use awk on FreeBSD/Darwin, since 'wc' implementation is broken and adds
spurious spaces in its output.
Change-Id: I7dcc0b70874e43b4cda8c306ed18a31b7a3f990a
BUG: 1131713
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8520
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
commit 0a78e7733848aced5451e9c4e06f402bfebe9ce7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sat Aug 30 17:41:01 2014 +0530
barrier: features.barrier should be a NO_DOC
features.barrier is turned on/off internally by snapshot feature and hence it
should not be exposed to the customer and this option should not be documented.
Change-Id: Id9a421f94e291f1dc77044904bb18dd730c2d43e
BUG: 1135691
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8572
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 548f6aab1dfad58172ee4418d53849ad74fb2492
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Sep 2 09:08:58 2014 +0200
Regression test portability: EXPECT
Make sure test_expect_not_footer() and test_expect_footer() work on
non empty strings, otherwise it may produce errors such as in pgfid_feat.t
on NetBSD:
not ok 12 Got "" instead of ""
This a a missing bit from previosuly merged patchset:
I9cb76ba863897126534c3808fb0c9e564659835f
BUG: 1129939
Change-Id: I2635b67deec9cf60295faab52e7421947b1f7bda
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8576
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0656b4dd5822397689aa41d5c5afd05af044a5fb
Author: Vipul Nayyar <nayyar_vipul@yahoo.com>
Date: Sun Jul 6 03:19:07 2014 +0530
io-stats: Adding private data dumping method
For the glusterfsiostat tool to be able to gather stats about mounted volumes
from meta xlator, private information in the io-stats xlator needs to be dumped
in the .meta folder.
Added functionality for total data being read/written to be dumped along with
latency related information for all fop functions present in io-stats.
Change-Id: I75486f0ca361844a643861789f6c1406f439674c
BUG: 1130023
Signed-off-by: Vipul Nayyar <nayyar_vipul@yahoo.com>
Reviewed-on: http://review.gluster.org/8244
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 94083baf015402ac231d944a483bb3a18c6e2fb2
Author: Anuradha <atalur@redhat.com>
Date: Wed Sep 3 19:04:02 2014 +0530
cluster/afr : Mark pending changelog xattrs for new creations
Based on type of file, set appropriate pending changelogs
for new entries.
Change-Id: Ifd124bf9bc54b996ce83ab9f39d03b3ccca7eb3c
BUG: 1130892
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/8555
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit fe546182f419bbd8c0d2e854947ddb87804b744b
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Wed Sep 3 14:42:43 2014 +0530
cluster/dht: Added code to capture races in dht-lookup path
Change-Id: I9270d2d40ebd4b113ff961583dfda7754741f15b
BUG: 1116150
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8430
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d50a4c40347c1b9753b6ecfebdbd5b278bdfc4cc
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Sep 2 21:05:56 2014 +0530
cluster/afr: Minor fixes to #8574
* Fixed a bug in afr_selfheal_name_type_mismatch_check()
* Fixed indentation
* Removed redundant 'continue' statements
Change-Id: Ie58b5dec9085ce9fe46ae9f244ebae1b1cef7ac5
BUG: 1132469
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8586
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 46624124586b95fb8a4a8ea22031c5889fb5503e
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Wed Sep 3 14:18:00 2014 +0530
storage/posix : Missing space in log message
Added a space in a log message
Change-Id: Iabd50e6b5c9ff4673f59d6b52b785894b3dcdaf9
BUG: 1116150
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/8585
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 433f6bf0f70d172ac8c912a4645d32216647c8ce
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Sep 3 10:29:07 2014 +0530
glusterd: Improve debugging experience for glusterd locks
Today, when glusterd's internal locking mechanism fails
with invalid type or when another competing lock is being
held, the log message doesn't provide enough information
directly as to which command saw this (first). Following
is a snippet of how a failure would look in the log file.
This would greatly assist in debugging.
[2014-09-03 04:57:58.549418] E
[glusterd-locks.c:520:glusterd_mgmt_v3_lock]
(-->/usr/local/lib/glusterfs/3.7dev/xlator/mgmt/glusterd.so(__glusterd_handle_create_volume+0x801)
[0x7f30b071e651]
(-->/usr/local/lib/glusterfs/3.7dev/xlator/mgmt/glusterd.so(glusterd_op_begin_synctask+0x2c)
[0x7f30b072e19c]
(-->/usr/local/lib/glusterfs/3.7dev/xlator/mgmt/glusterd.so(gd_sync_task_begin+0x55d)
[0x7f30b072de6d]))) 0-management: Invalid entity. Cannot perform locking
operation on vol types
Change-Id: I0595f49d60e620e8b065f3506bdb147ccee383a7
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/8580
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 94333d83dda913b051bc043237bec5d9aaa161d7
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Sep 3 10:50:31 2014 +0530
glusterd: Prevent rebalance starting with old clients
Glusterd will prevent rebalance from starting when clients older than
glusterfs-v3.6.0 are connected to a volume. This is needed as running
rebalance with old clients connected could lead to data loss in some
cases. The DHT xlator on newer clients (>= 3.6.0) has been fixed to
prevent the data loss issues.
Change-Id: If58640236382a2fc13f73f6b43777f01713859f7
BUG: 1136201
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/8583
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c99e8cbc50bd184ebb0bb65ce60cb2631e14fd33
Author: Vijaikumar M <vmallika@redhat.com>
Date: Tue Sep 2 17:43:43 2014 +0530
glusterd: Set the rlimit for Open FDs to higher value
Default 'open FD limit' is 1024. As the number of volumes/bricks
increases, brick-to-glusterd socket FDs also increases in glusterd and
runs out of the limit.
Solution is to set the 'Open FD' limit to higher value in glusterd
Change-Id: Iaa60b2155df2fa5a0759e054bdebffbc09f63ec1
BUG: 1136352
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8578
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 55f2d1c533f6aa49bfcb900fd31918119122a8ae
Author: Susant Palai <spalai@redhat.com>
Date: Tue Sep 2 05:29:52 2014 -0400
CLI: Adding warning message in case remove-brick commit executed
Change-Id: Ia2f1b2cd2687ca8e739e7a1e245e668a7424ffac
BUG: 1136702
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/8577
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ca8ae4e725f9e7f06331b9847d97d3f705180b61
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Wed Sep 3 10:42:47 2014 +0530
Cluster/DHT: Changing rename log severity
Changing log level for a rename message from debug
to info to improve debuggability
Change-Id: I53031fcf97fffd62095692477330ecde0cf47dcd
BUG: 1130888
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/8582
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 2e5702be86697278564b59f56d18c78a61adafa1
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Aug 27 10:47:24 2014 +0530
cluster/dht: remove specifying cached-subvol as part of name in unlink.
commit 667b2496c3f29e24ed359a05b0f44df0d1894969 introduced a
functionality where we can specify the subvol where file is stored. As
part of same commit, dht_unlink was also changed to accept
cached-subvol as part of name. While it makes sense to specify subvol
while creating file, there is no necessity for specifying the subvol
during unlink, since the default unlink logic works fine with this
functionality too. Also, this code in unlink doesn't work well when
files get migrated by rebalance process. Hence removing it.
Change-Id: Ic3fc32ad657e2dcd677a4c80b04a618029eddd89
BUG: 1130888
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8548
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5ba13b86f9b812570246f61713b90e1c2be82429
Author: Shyam <srangana@redhat.com>
Date: Tue Sep 2 12:37:07 2014 -0400
cluster/dht: Modified test case to note rename failures as errors
The bug referenced in this change, had an race condition that is now
fixed by the following commits that are posted for review.
http://review.gluster.org/#/c/8563/
http://review.gluster.org/#/c/8570/
These changes would now make the winning client not fail a rename,
in case it failed to rename the linkto file. Hence when one client
wins the link race, and the other still deletes the linkto file,
the rename failure by the winning client is not a critical failure,
hence it resolves the issue posted in the bug.
As a result modifying the test case to treat the rename failures
as errors, to catch any future issues.
Change-Id: Ibe9caac7ee87dcbc4f581cfbd36173b734859ccb
BUG: 1123950
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/8579
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b3fd81d3b0278d2f44b770d9ab35f8ffc27a59bc
Author: Shyam <srangana@redhat.com>
Date: Fri Aug 29 15:20:40 2014 -0400
cluster/dht: Rename should not fail post hardlink creation
In the rename path, we wind the creation of newname hardlink and
linkto file in dst hashed a the same time. If the linkto creation
fails, but the link creation succeeds, we enter the failure code
and cleanup the created newname hardlink.
In the interim if another client looks up newname and finds it as
a hardlink from FUSE, it could send an unlink for oldname instead
of a rename. This combined with the above cleanup code could end
up losing all the files copies, and thereby losing data.
This fix separates these steps into 2 parts, creating the linkto
first and then the link file, so that post link file creation no
failures would cleanup the newname file. If linkto fails then link
is not attempted, thereby not polluting the name space with
newname.
Change-Id: I61da8e906060da16a31ea1076eec2f01fd617f44
BUG: 1130888
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/8570
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7741f09000efc32a820b3eba860e41b494b26ef3
Author: Shyam <srangana@redhat.com>
Date: Wed Aug 27 15:27:46 2014 -0400
cluster/dht: Treat linkto file rename failure as non-critial error
It is a critical failure iff we fail to rename the cached file
if the rename of the linkto failed, it is not a critical failure,
and we do not want to lose the created hard link for the new
name as that could have been read by other clients.
NOTE: If another client is attempting the same oldname -> newname
rename, and finds both file names as existing, and are hard links
to each other, then FUSE would send in an unlink for oldname. In
this time duration if we treat the linkto as a critical error and
unlink the newname we created, we would have effectively lost the
file to rename operations.
Repercussions of treating this as a non-critical error is that
we could leave behind a stale linkto file and/or not create the new
linkto file, the second case would be rectified by a subsequent
lookup, the first case by a rebalance, like for all stale linkto
files
Change-Id: Ia53ad8b43c3cf8f48ef5b43fd1fec4274e807556
BUG: 1130888
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/8563
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 84bfbadd348ffc9e46126aae1c562643aa3e91ae
Author: hchiramm <hchiramm@redhat.com>
Date: Wed Aug 27 12:24:24 2014 +0530
core: update INSTALL file.
Change-Id: Ie6f041810da647e39d4bbb5384f51dadd6f69b30
Signed-off-by: hchiramm <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8573
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 71d4c3129005f7d11608aee655fe92152fee116b
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sat Aug 30 16:33:59 2014 +0530
USS: initialize a list before using it.
Change-Id: Iba35e4397646a67384e878fbe7bdfb7586fc07f9
BUG: 1130888
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8569
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6290691fce7c41b6294d39532ef193fb43956e14
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Aug 21 17:27:17 2014 +0530
cluster/afr: Propagate EIO on inode's type mismatch
Original author of the test script:
Pranith Kumar K <pkarampu@redhat.com>
Change-Id: If515ecefd3c17f85f175b6a8cb4b78ce8c916de2
BUG: 1132469
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8574
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit f10590fdaa1a9504a2ff2456f63dc4b1325010e7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Sep 2 09:40:44 2014 +0530
storage/posix: Prefer gfid links for inode-handle
Problem:
File path could change by other entry operations in-flight so if renames are in
progress at the time of other operations like open, it may lead to failures.
We observed that this issue can also happen while renames and readdirps/lookups
are in progress because dentry-table is going stale sometimes.
Fix:
Prefer gfid-handles over paths for files. For directory handles prefering
gfid-handles hits performance issues because it needs to resolve paths
traversing up the symlinks.
Tests which test if files are opened should check on gfid path after this change.
So changed couple of tests to reflect the same.
Note:
This patch doesn't fix the issue for directories. I think a complete fix is to
come up with an entry operation serialization xlator. Until then lets live with
this.
Change-Id: I10bda1083036d013f3a12588db7a71039d9da6c3
BUG: 1136159
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8575
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c0399068747d5f4dc8db522f180d778344743dc4
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 8 06:12:04 2014 +0200
Regression test portability: mknod
Linux mknod(2) is able to create fifo and named sockets. NetBSD and
FreeBSD use mkfifo(2) and socket(2)/bind(2) for that.
BUG: 764655
Change-Id: I1d3969e3fcb6afdbd184c28bd268ffa2da7ae202
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8433
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 736d19ea2918da5e9688c1e1a47c8d657235b7e8
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Aug 30 06:59:29 2014 +0200
Regression test portability: EXPECT
Make sure test_expect_not_footer() and test_expect_footer() work on
non empty strings, otherwise it may produce errors such as in pgfid_feat.t
on NetBSD:
not ok 12 Got "" instead of ""
BUG: 1129939
Change-Id: I9cb76ba863897126534c3808fb0c9e564659835f
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8568
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fb8566a3682a62787f152a874a19badcc62a4fc7
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Aug 31 05:45:16 2014 +0200
Regression test portability: LVM
Skip any test involving LVM on NetBSD as LVM is not supported
BUG: 1129939
Change-Id: I2237bae1128d1a81047c9ff7f905431156daf8b7
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8556
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5861f74c58786c5f04a883c9a61f86d97d86230c
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Tue Aug 26 16:40:49 2014 +0530
Hook scripts should exit with correct exit status.
When volume set options other than nfs-ganesha.host and nfs-ganesha.enable
are executed, the hook script S31ganesha-set.sh should exit with
exit status 0. The present behaviour results in an error message in
one of the logs that could be misleading.
Similarly, hook script S30samba-set.sh should exit with
exit status 0 if samba is not installed. Fixing the issue
with a minor change in the script.
Change-Id: I35d1dc8400bb7043385800ed97adc5321829437f
BUG: 1122978
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/8385
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d26c8c1996febce16d6042602f1a6e07625c32c0
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Aug 28 09:58:43 2014 +0530
statedump: Print curr_stdalloc in mempool statedump ...
...for, it is curr_stdalloc that is incremented for every mem_get()
and decremented on every call to mem_put() and can be used to detect
leaks, when cold_count is 0.
Change-Id: I418a132c3ea4c0b99ea5c6840ff3024d8d19ddf4
BUG: 1134221
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8557
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit c448e320b92ba4b6fea937e1c4e94057c1ad99b7
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Aug 28 10:46:50 2014 +0200
build: fixes for compiling with -Werror=format-security
Nightly builds on Fedora Rawhide (x86_64 and i686) started to fail with the
following error:
cli-rpc-ops.c: In function 'gf_cli_get_vol_opt_cbk':
cli-rpc-ops.c:9339:25: error: format not a string literal and no format arguments [-Werror=format-security]
cli_err (msg);
^
The cli_err() should be called with a format-string like "%s" to prevent
unexpected errors.
Change-Id: I6a287795fb8b7a305c8f14323456eeabf68d100c
BUG: 1134773
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8560
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit f84d98d65840a9514d61be62d14c3df3f333b90d
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Aug 29 00:11:38 2014 -0700
porting: Remove unnecessary code from mount_darwin.c
- Cleanup mount_darwin.c to make it cleaner
- Restructure the code to be more readable
- Avoid unnecessary delays invoking `mount_osxfusefs`
Change-Id: I7f28875b0ec872a08bf8e77dfc8ebe5eca750d0e
BUG: 1135348
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8564
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 0d87e3387ace212f990d63d99ee5a405a19398f4
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Aug 19 18:24:23 2014 -0700
porting: various fixes regression tests OSX/FreeBSD
- `wc -l` on OSX/FreeBSD adds spurious spaces, this clobbers
up TAP output parsers - fix it.
- `umount -l` doesn't exist on OSX/FreeBSD use 'umount -f' if
available.
- Add check for 'file' version, to handle mime type variations
across versions
- Converge 'glusterfs --attribute-timeout=0 --entry-timeout=0'
into '$GFS'
- Modify remaining 'mount -t nfs' to use 'mount_nfs'
- Update sha1sum for OSX to use 'openssl sha1'.
Change-Id: Id1012faa5d67a921513d220e7fa9cebafe830d34
BUG: 1131713
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8501
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit ed3baa8da081c30ba29446278c20f3bad2b4563c
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Aug 26 14:57:42 2014 -0700
dht: Avoid using inline, if necessary use it with 'static inline'
This avoids flat namespace problems on OSX and with clang
Change-Id: Id80d94d71b120c6b1166218caa8cf9cf7f2da03a
BUG: 1130888
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8547
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e3e1c43d9deabcbd1671c1670ba6b7634f13b593
Author: Prashanth Pai <ppai@redhat.com>
Date: Wed Aug 27 15:02:49 2014 +0530
doc: Converting GFID to Path.
This is an attempt to document various possible ways to externally
get file/dir path from its GFID.
Change-Id: Ic31725a9706ddae8972aea9bb58f3b70978dbd06
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/8552
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7c27d50e9bde5e9b712e2376214fecff83358df6
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Aug 21 21:35:52 2014 +0530
cluster/dht: synchronize rename and file-migration
Change-Id: I4f243c946f76d440680b651235f925e3d0ebf0fd
BUG: 1130888
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8523
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 274429f1e5e98d25dcbec90915996658b6d3f3b5
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri Aug 22 17:07:15 2014 +0530
storage/posix: Don't unlink .glusterfs-hardlink before linkto check
BUG: 1116150
Change-Id: I90a10ac54123fbd8c7383ddcbd04e8879ae51232
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8559
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0506ad3f055ba32217d5824212e57f4e34327571
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Aug 27 11:27:33 2014 +0530
cluster/dht: invoke callback when there are no locks to be unlocked.
Change-Id: I375cb68f1075c2d58cf9d09ed6bd5e2746e1637d
BUG: 1130888
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8549
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2d1f82ad5d7f824fbe81a8cce0ee192479973473
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Aug 27 15:14:04 2014 +0530
cluster/afr: Fix dict_t leaks
dict_t objects that are ref'd in alloca'd "replies" in
afr_replies_copy() are not unref'd after "replies" go out of scope.
Change-Id: Id5a6ca3c17a8de72b94b3e0f92165609da5a36ea
BUG: 1134221
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8553
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c8450ddbda3fad71ea457dee3620dd85a9d49c4c
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Aug 25 05:42:38 2014 +0530
cli/snapshot : Add confirmation dialog to snapshot restore operation
When restoring a volume, the user is not prompted for confirmation.
Since restoring a volume rolls back the data to a previous point in time,
there is the potential for updates to be lost.
Hence it is better to display a confirmation dialogue during snapshot
restore operation.
Change-Id: I7b23eaeb43ad2aafa508e2ca5750d9b0fc7d6e36
BUG: 1133426
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8525
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit b500cf62d7b6e9f97a510a7f6a4be412b27abc23
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue Jul 15 17:00:09 2014 +0530
Add build generated *.py[oc] to .gitignore
Related to:
http://review.gluster.org/8237
Change-Id: I8f888f0363c4358026ad17b2dc288014f7c51466
BUG: 1119328
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/8311
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ebab298155d494ef4aa0969f6d1967c8f090cac6
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Aug 27 10:35:15 2014 +0200
rpm: fix date in %changelog
When building rpms, the following warning is printed:
warning: bogus date in %changelog: Thu Jun 29 2014 Humble Chirammal <hchiramm@redhat.com>
This orginates from the following change:
> Change-Id: I4988a025bd18716fd6d355431196540e140224b3
> Reviewed-on: http://review.gluster.org/8116
The date of the change was the 19th, not the 29th. Correcting the date and the
order of the changelog entries prevents this warning.
Change-Id: Ied2d25ae3c81c58ec8ab35ff54be169ba6428ed6
BUG: 1108669
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8551
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3d05ed13c760e4aaacded95ab71df422db95f6a1
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Wed Jul 9 00:31:57 2014 +0530
gNFS: correct some typos in comments.
Change-Id: I304c760c2318edd4bab985ca19bf9ce62fd21a3c
BUG: 1075417
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8265
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 186ec8b42fc3c97d63c0addfdc2b657612e45d05
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Aug 26 14:40:01 2014 -0700
glusterd: Add xml specific functions in HAVE_LIB_XML block
Build failure on OSX and also on Linux with '--disable-xml-output'
introduced in following commit "c080403393987f807b9ca81be140618fa5e994f1"
Change-Id: I0db92c9f5e319dc1932bed9ecc1acc98adb57de3
BUG: 983317
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8546
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit c8ff81eed2428f4b42a93cbfefbd7a97e58f0a8d
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Aug 19 16:14:03 2014 -0700
porting: `pidof` portability for OSX/FreeBSD
- Provide a portable `pidof` just to be used specifically with
glusterfs regression tests on OSX and FreeBSD. This was
written after countless hrs of effort to get a sane `pidof`
working on either of the environments.
`pidof` comes at the wake of lack of proper procfs support
and also incompatible way of handling process names since
glusterd/glusterfs are symbolic links to 'glusterfsd'
- tests/utils/* directory should be part of 'PATH' to avoid
abspath calculation using $(dirname)
- cleanup() - rpcinfo command prints error on FreeBSD/OSX fix it
Change-Id: I35f86273624cb279da1c8fae056ca27669e251d8
BUG: 1131713
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8499
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 33a10e5a81b5ece7bbdf5a75cef80bfca2da0a49
Author: hchiramm <hchiramm@redhat.com>
Date: Tue Aug 26 15:29:29 2014 +0530
doc: move split_brain.md to debugging dir.
Change-Id: I4558514bca9365b4563e74f166f2a0156f798d0f
Signed-off-by: hchiramm <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8544
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0a2a61dbd0afe5378cb14ba0799e65c02a0b8609
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Aug 14 16:44:23 2014 +0530
libglusterfs/syncop: implement inodelk
Change-Id: Iea489157490b70cb2bb03576b0d4943c6d8f052d
BUG: 1130888
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8522
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 377131e187d7a5cdbda5238fe40540eed03d6f01
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Aug 11 10:14:18 2014 +0530
cluster/dht: introduce locking api.
Change-Id: I41389ba91951d3e63e617aa32cd0bee848261c72
BUG: 1130888
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8521
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3aced1297d090168c12ef84ca9c6f34287a24439
Author: Ajeet Jha <ajha@redhat.com>
Date: Tue Aug 26 14:39:24 2014 +0530
features/changelog: Removal of redundant fop color count while draining.
Change-Id: Ie5581579df63513e636fa3dd92dd90699ea7d999
BUG: 1128093
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/8542
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1285aad375cc53920607459dbebd8ff1f3b2139c
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Jun 30 10:33:25 2014 +0530
cli/glusterd: Support of volume get for a specific volume option
This patch introduces a cli command to display a specific volume option/all
volume options of a specific volume with the following usage:
Usage: volume get <VOLNAME> <key|all>
Change-Id: Ic88edb33c5509d7a37cd5ade6341e45e3cdbf59d
BUG: 983317
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8305
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1475f007456500c497b4be779bee296d9924a9cf
Author: Ajeet Jha <ajha@redhat.com>
Date: Sat Aug 23 19:06:45 2014 +0530
features/changelog: Crash consistency of changelog wrt snapshot
This patch introduces call-path fop details logging for data operations
in CHANGELOG.SNAP. This feature is enabled with barrier-enable
notification and disabled with barrier-disable notification.
Change-Id: Ib548d34203eb99cea478a6baff402e82251c73a4
BUG: 1128093
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/8533
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6d8b37947622923060558c2e98e1d44b75185799
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue Aug 26 14:44:28 2014 +0530
doc: Remove outdated admin_UFO.md
Remove outdated admin_UFO.md file and add file to point to upstream
SwiftOnFile repo and documentation.
Change-Id: I87e17c11197e0ed3dd9f10a3ace88c2b3c23566e
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/8543
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2b92a480ef2d79068e7e0615a2ded30de1882b19
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Aug 23 23:46:51 2014 -0700
tests: bug-1002207.t - should mount glusterfs before tests
Change-Id: I9238ea8cf4e5ad9bab384ef08d873a5b0e578a33
BUG: 1133266
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8519
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fb83345e8151b5d73d521b1f58e326ce97d13094
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Aug 8 11:52:17 2014 +0530
cluster/afr: Fix all locked_on bricks are sinks check in self-heals
Problem:
Counts may give wrong results when the number of bricks is > 2. If the
locks are acquired on one source and sink, but the source accuses even the
down sink then there will be 2 sinks and lock is acquired on 2 bricks so
even when there is a clear source and sink **_finalize_source functions think
the file/directory is in split-brain.
Fix:
Check that all the bricks which are locked are sinks.
Change-Id: Ia43790e8e1bfb5e72a3d0b56bcad94abd0dc58ab
BUG: 1128721
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8456
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b1b2721b04c8d6dab8a8c33f8e09f804d47851f3
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Aug 25 09:46:14 2014 +0530
cli/snapshot : update of a snapshot delete syntax in documentation
Change-Id: Id1a4b9684a8dd5750ee6eed841e3d5195407fb7e
BUG: 1112613
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8534
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 656be706cea973dca2026dbfdf9f546d61be3970
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Aug 16 02:32:49 2014 +0200
Fix glustershd detection on volume restart
On NetBSD and FreeBSD, doing a 'gluster volume start $volume force' causes
NFS server, quotad, snapd and glustershd to be undetected by glusterd once the
volume has restarted. 'gluster volume status' shows the three processes
as 'N' in the online column, while they have been launched successfully.
This happens because glusterd attempts to connect to its child processes
just between the child does a unlink() on the socket in
__socket_server_bind() and the time it calls bind() and listen().
Different scheduling policy may explain why the problem does not happen
on Linux, but it may pop up some day since we make no guaranteed
assumptions here.
This patchet works this around by introducing a boolean
transport.socket.ignore-enoent option, set by nfs and glustershd,
which prevents ENOENT to be fatal and cause glusterd to retry and
suceed later. Behavior of other clients is unaffected.
BUG: 1129939
Change-Id: Ifdc4d45b2513743ed42ee235a5c61a086321644c
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8403
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 65eb06c71abe45eefd50aa58a403c66a8e1dd4a3
Author: ggarg <ggarg@redhat.com>
Date: Mon Apr 14 16:38:15 2014 +0530
cli: Fixing ambiguous message error for rebalance <volname> start command
Previously output message of command 'gluster volume rebalance <volname>
start/start force/fix-layout start' was ambiguous and poorly formatted.
Previously output message was: "volume rebalance: <volname>: success:
Starting rebalance on volume <volname> has been successful."
Now with this fix properly formatted output message is:
"volume rebalance: <volname>: success: Rebalance on <volname> has been
started Successfully. Use rebalance status command to check status of
the rebalance process."
Change-Id: I23268fc13b05d1b39ffe4c702d0e4f73085acd1c
BUG: 1087487
Signed-off-by: ggarg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/7473
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2d25b551f8ad7ef45e967a15eaa40f64ccd26aec
Author: Vijaikumar M <vmallika@redhat.com>
Date: Thu Aug 21 17:07:25 2014 +0530
glusterd: Parsing key/value pair with value containing '='
Parsing key/value pair in the brickinfo file, where value contains '='
would truncate everything after '=' in value.
For example:
A key/value pair
mnt-opts=rw,noatime,allocsize=1MiB,noattr2
is parsed as:
mnt-opts=rw,noatime,allocsize
BUG: 1132451
Change-Id: I756b2fc4b06875267212b1a5c3e91c5a40c6accb
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8524
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit aeeafc5295ca06781a019fee689777dd6d2128d2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Aug 1 18:30:32 2014 +0530
mount/fuse: Handle fd resolution failures
Problem:
Even when the fd resolution failed, the fop is continuing on the
new graph which may not have valid inode. This lead to NULL layout
subvols in dht which lead to crash in fsync after graph migration.
Fix:
- Remove resolution error handling in FUSE_FOP as it was only added
to handle fd migration failures.
- check in fuse_resolve_done for fd resolution failures and fail the
fop right away.
- loc resolution failures are already handled in the corresponding
fops.
- Return errno from state->resolve.op_errno in resume functions.
- Send error to fuse on frame allocation failures.
- Removed unused variable state->resolved
- Removed unused macro FUSE_FOP_COOKIE
Change-Id: I479d6e1ff2ca626ad8c8fcb6f293022149474992
BUG: 1126048
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8402
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ad9a3c90874da39af6a96a6b4007022a411a98ef
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Aug 22 17:15:13 2014 +0530
features/changelog: barrier all entry creation fops
when a snapshot is taken, there are chances of entry creation fops
not being recorded either in changelog or through the recursive
ancestry xtime updation by marker. This causes consumers of changelog
(primarily geo-replication as of today) to not be aware of these entries
after a snapshot is restored. This can lead to inconsistencies. This patch
is an interim workaround to barrier creates till changelog becomes completely
crash consistent.
BUG: 1128093
Change-Id: Ie0dbfd74beecb88df5c2ddf9fc680af91547c3f3
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/8517
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: ajeet jha <ajha@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit dee1e762ea4eab4b654322859b3bf4c126683a22
Author: jonKSA <cope.jonathan@gmail.com>
Date: Wed Aug 20 12:34:37 2014 -0500
doc: Update admin_guide for hadoop.
Current version of admin_Hadoop.md contains an
obsolete set of instructions.Changes are purely
textual; no code changes.Linking to a community
site extends the viability of the doc and allows
instructions to keep pace with future versions.
Instructions have been validated.
Change-Id: Ie330b2a23513ae140d3cd5f19af3045fff3bc9d5
BUG: 1132105
Signed-off-by: jonKSA <cope.jonathan@gmail.com>
Reviewed-on: http://review.gluster.org/8505
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d45cea8d312438dd14e9ac0e3995b3e81509df0c
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Fri Aug 22 15:16:40 2014 +0530
Cluster/DHT : Additional log messages
Adding log messages in the rename and lookup calls to
help with debugging.
Change-Id: I13b1c6f98fb49ead45362550c46359ab1f9028c0
BUG: 1130888
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/8516
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit f1d080f39d597cd31176c4ac5cc088b386ea1b2f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Aug 21 15:15:46 2014 +0530
tests: metadata self-heal tests
Change-Id: Idef49b22018908c0a2ed95852b0670a91a750eba
BUG: 1132913
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8515
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 635ea18087bb22f9077108ba99800bd3e893d1a3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Aug 21 17:30:10 2014 +0530
cluster/afr: Perform metadata sync inside metadata locks
Change-Id: Ie55b3d37cacbdad74a3f63c3b0f025b0ffd0104a
BUG: 1132461
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8514
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 61717368011053cf3b9e81292489b70dfcb61a5b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Aug 13 11:11:17 2014 +0530
cluster/afr: Perform gfid heal inside locks.
Problem:
Allowing lookup with 'gfid-req' will lead to assigning gfid at posix layer.
When two mounts perform lookup in parallel that can lead to both bricks getting
different gfids leading to gfid-mismatch/EIO for the lookup.
Fix:
Perform gfid heal inside lock.
BUG: 1129529
Change-Id: I20c6c5e25ee27eeb906bff2f4c8ad0da18d00090
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8512
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit 3d602231c796cd02133508ac48e91c706847ebab
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Aug 21 22:22:37 2014 -0700
client: client3_3_readdir() - initialize ``local`` properly
A crash is observed in the following scenario on OSX
~~~
(gdb) p readdir_rsp_size
$1 = 1552
GLUSTERFS_RPC_REPLY_SIZE == 24
GLUSTERFS_RDMA_MAX_HEADER_SIZE == 228
((1552 + 24 + 228)) == 1804
GLUSTERFS_RDMA_INLINE_THRESHOLD == 2048
if ((readdir_rsp_size +
GLUSTERFS_RPC_REPLY_SIZE +
GLUSTERFS_RDMA_MAX_HEADER_SIZE) > GLUSTERFS_RDMA_INLINE_THRESHOLD)
----> False
~~~
``local`` is never initialized leads to NULL reference later.
This patch makes sure that local is initialized, correctly as its
done in client3_3_readdirp() call.
Change-Id: I46931fc96900b7740ae71536c954bb9deda5c879
BUG: 1132796
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8511
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit ea50fea14467410f993566043b0a13ed8d108ec0
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Aug 12 04:14:21 2014 +0530
glusterd/snapshot : Fail the snapshot create operation if geo-rep is running.
As one of the recommandations for taking a snapshot is not to have
an active geo-replication session, its better to display an error
saying session is active when snapshot create command is issued.
Change-Id: I94593dbd2659610e033ca316176dda1ac8dc5ce6
BUG: 1129038
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8461
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit a780e8dbafb68f047bd1276a005e83ae7cd5b870
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Aug 20 10:50:35 2014 +0200
Fix quotad RPC options use-after-free bug in gluster
In cli/src/cli.c:cli_quotad_clnt_rpc_init(), dict_unref (rpc_opts)
causes the options to be freed while code in rpc/rpc-transport/socket
still relies on it. The options are corrupted when memory is reallocated,
which sometimes leads to a crashes on NetBSD when socket_connect()
attempted to read options.
Fix the problem by not doing the dict_unref(). Make sure the rpc_opts
are freed on error, though.
BUG: 1129939
Change-Id: If1d6ea50cc3e1599e9e369863c8db0c0694d3671
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8502
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit fd1f2e889854c40ce567271feef91d43e2cf968b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Aug 21 10:44:14 2014 +0530
cluster/afr: Set pending changelog based on filetype for new entries
Change-Id: Ib6eea2dfe43aacf1f3446cc023adecbcf8645d48
BUG: 1132102
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8506
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1fe953e9bab0f396d0c1cccad6e7051edd5ff206
Author: Kotresh H R <khiremat@redhat.com>
Date: Fri Aug 8 17:17:20 2014 +0530
geo-rep/glusterd: API to check active geo-rep session for the volume
Requirement:
Snapshot needs an API to fail the CLI if any geo-rep session is active
for that volume.
Solution:
A function "gd_vol_is_geo_rep_active" is provided to check if any
geo-rep session is active for that volume. An in memory dict called
'gsync_running_slaves' is maintained in 'volinfo' structure to keep
track of active geo-rep session for the volume. The key
'slavenode::slavevol' with value 'running' is added whenever geo-rep
is started/resumed into the dict and the same is removed if
stopped/paused. So the 'count' in dict is used to decide whether the
geo-rep is active or not for that volume.
Also added "this->name" in gf_log in routines which this patch is
touched.
Change-Id: I2b5de7dd686541c6b89c0fd0f7a4dbc92eecfac5
BUG: 1129008
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8459
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit a4a005ee67ea24b9058519e71d2a362a8825923e
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 8 05:39:38 2014 +0200
Regression test portability: mktemp
Linux mktemp accepts to run without a template, NetBSD mandates it. Since
the template option has the same syntax, add it everywhere. While there,
also do this in scripts outside of regression testing.
BUG: 764655
Change-Id: I3ec140afbc9009257c81a56d77afcc21fef74cc4
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8432
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit e2aa6cfb83c177a1e14c32610ad4e781af78efc4
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Aug 10 19:56:06 2014 +0200
Regression test portability: sha1sum
Provide a shell function for sha1sum if missing
BUG: 764655
Change-Id: I8b232af8aab7f95ba7c7ad83e37a111d562201a5
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8450
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 053a6a4865ce24ba794fa50eed8dda2be2eeface
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Aug 13 06:04:25 2014 +0200
Regression test portability: dd
Use dd msgfmt=quiet also in truncate replacement
BUG: 764655
Change-Id: I5ad022c1dc65ecc98996ccbe8a3d0e9de162aa1a
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8464
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit eba5556c4af514c7bc704d017d38145a36af1eec
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Aug 14 11:45:02 2014 +0200
Regression test portability: 127.0.0.0/8
On Linux, the host answers any address in 127.0.0.0/8
On NetBSD, any address must be configured with ifconfig lo0 alias before
it can be used.
BUG: 1129939
Change-Id: Ia628716c104d955817a95e0c5e04ead924bb4847
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8483
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 5ff9cd59652760761b45aec62f37e264dcc05265
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Aug 19 17:55:46 2014 +0200
Regression test portability: mount
Address various portability-related problems related to mount
- In order to address the non-portability of NFS mount options,
use the mount_nfs shell function everywhere, and use it to
translate options.
- Make sure NFS mounts are unmounted before shutting down the
daemons in order to avoid deadlock. The change is done in every
test that did not unmounted NFS mounts at the end of the script,
and in global cleanup function as well. The force_umount shell
function from volume.rc was duplicated as umount_nfs in nfs.rc
so that we do not have to add an include on volume.rc for all
NFS tests that do not need it.
- The FUSE mount type on NetBSD is puffs|perfuse|fuse.glusterfs
instead of just fuse.glusterfs, make the regexp configurable
in include.rc
- Finding wether the mount is RO or RW in mount output needs
a system-dependent command configurable in include.rc
- mount options in /proc/mounts may be limited to "rw", adjust
the regexp for this case where there is no comma
And while there change rm into rm -f in tests/basic/mount.t
for removal opearation that should fail, since rm may ask
for confirmation
Change-Id: I1fb708486ec350b2885e2404879561c1020fa8fd
BUG: 1129939
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8494
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit cca53eb9c13c927151bc67033965c777ffaee957
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jul 17 12:06:58 2014 +0530
client: Add ping-timeout to statedump
The ping timeout value of a client xlator can be seen by,
># cat $META/graphs/active/vol-client-0/private |grep ping_timeout
ping_timeout = 42
where $META is /<fuse-mountpt>/.meta
Change-Id: I4f68f184fc3f30871269a23fc4a82a1378396058
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/8321
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 21131289bf5a4b051ed8715a343e45234ba1cf6e
Author: Patrick Uiterwijk <puiterwijk@redhat.com>
Date: Mon Aug 18 16:35:10 2014 -0400
who-wrote-glusterfs: use the set $GITDM_REPO variable
Change-Id: Ic119f83fff3930e164f3c81df1c9b60d5eb2d99f
BUG: 1131272
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
Reviewed-on: http://review.gluster.org/8495
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 55d3219a99c22838f4354fc05a55ba5e0179c141
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Aug 8 15:06:11 2014 +0530
geo-rep: Fixing issue with xsync upper limit
While identifying the file/dir to sync, xtime of the file was compared
with xsync_upper_limit as `xtime < xsync_upper_limit` After the sync,
xtime of parent directory is updated as stime. With the upper limit
condition, stime is updated as MIN(xtime_parent, xsync_upper_limit)
With this files will get missed if `xtime_of_file == xsync_upper_limit`
With this patch xtime_of_file is compared as
xtime_of_file <= xsync_upper_limit
BUG: 1128093
Change-Id: I5022ce67ba503ed4621531a649a16fc06b2229d9
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/8439
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f82aa21a2e9819516305c8b0981852742efa8b68
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Aug 18 12:11:35 2014 +0200
NFS: stripe-xlator should pass EOF at end of READDIR
NFS READDIR replies are made of a header, a sequence of
entries, and a EOF flag. When GlusterFS's NFS server is
used along with stripe xlator, it fails to set the EOF
flag, which violates NFS RFC and confuses some clients.
The bug is caused because nfs xlator sets EOF if it gets
op_errno set to ENOENT. That value is produced in storage
xlator and propagated through server, client, and other
xlators until stripe xlator handles it. stripe only passed
op_errno if op_ret < 0, which is not the case here. This
change set adds a special case for that situation to fix
the problem.
Change-Id: Ie6db94b0515292387cfb04c1e4a9363f34fcd19a
BUG: 1130969
Reported-by: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8493
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
commit 1526ee2421a57171cdc480f29ba40782c8dba44c
Author: Shyam <srangana@redhat.com>
Date: Tue Aug 12 10:48:27 2014 -0400
cluster/dht: Fix dht_access treating directory like files
When the cluster topology changes due to add-brick, all sub
volumes of DHT will not contain the directories till a rebalance
is completed. Till the rebalance is run, if a caller bypasses
lookup and calls access due to saved/cached inode information
(like NFS server does) then, dht_access misreads the error
(ESTALE/ENOENT) from the new subvolumes and incorrectly tries
to handle the inode as a file. This results in the directories
in memory state in DHT to be corrupted and not heal even post
a rebalance.
This commit fixes the problem in dht_access thereby preventing
DHT from misrepresenting a directory as a file in the case
presented above.
Change-Id: Idcdaa3837db71c8fe0a40ec0084a6c3dbe27e772
BUG: 1125824
Signed-off-by: Shyam <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/8462
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ba825b31a2e81a859e0617951a72890fbf2a200a
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Aug 7 17:01:18 2014 +0200
Regression test portability: stat
Linux uses stat -c, stat --printf= or stat --printf
NetBSD uses stat -f with different format strings. This change set
changes all stat usage to stat -c and introduce a shell stat()
fonction to perform the format string translation.
BUG: 764655
Change-Id: I024fca7c1b736b053f5888cbf21da0a72489ef63
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8424
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit dd2d9713de1c7806bb756226f3c945e067695d00
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Aug 13 02:00:05 2014 +0200
Regression test portability: mkdir
mkdir -v (verbose) is not portable, just remove it.
BUG: 764655
Change-Id: If344792caf977698abe0bf497d9083bc9333df55
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8463
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 0b0eeb60b7c36323a85dbf5a88b48c9420220182
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Aug 10 00:02:21 2014 +0200
Enable aux-gfid-mount option on non Linux systems
The aux-gfid-mount works on non Linux systems, and it is required
to pass tests/basic/gfid-access.t
BUG: 764655
Change-Id: Ic6c8ef425e091440a139bbd25fadbf4f82e378cb
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8446
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 60b9a1add75745f108892b38584ac2da831c73a3
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Aug 12 18:19:30 2014 +0530
geo-rep: Handle RMDIR recursively
If RMDIR is recorded in brick changelog which is due to
self heal traffic then it will not have UNLINK entries for
child files. Geo-rep hangs with ENOTEMPTY error on slave.
Now geo-rep recursively deletes the dir if it gets ENOTEMPTY.
BUG: 1129702
Change-Id: Iacfe6a05d4b3a72b68c3be7fd19f10af0b38bcd1
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/8477
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit cd74094ad3ac7a14626b30cbf244a8b33d38cfe9
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Thu Aug 7 16:28:48 2014 +0530
cluster/dht: Added keys in dht_lookup_everywhere_done
Case where both cached (C1) and hashed file are found,
but hash does not point to above cached node (C1), then
dont unlink if either fd-is-open on hashed or
linkto-xattr is not found.
Change-Id: I7ef49b88d2c88bf9d25d3aa7893714e6c0766c67
BUG: 1116150
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Change-Id: I86d0a21d4c0501c45d837101ced4f96d6fedc5b9
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8429
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: susant palai <spalai@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c44976ed2f016a345d728c5c931f9717a27b7f30
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Aug 8 01:56:23 2014 -0700
porting: FreeBSD related changes to regression scripts
- json_verify do not use '/usr/bin' let bash evaluate the location
- TEST for test code compilation `bug-1051896.t`, `bug-1058663.t`,
bug-905864.t
- run-tests.sh - better checks for installed packages
Change-Id: Ic7feda36ddfc082c609aabd75da2e9a8f59a92b3
BUG: 1111774
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8435
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Emmanuel Dreyfus <manu@netbsd.org>
commit 5a8638dee58ea75b15ea51ed8ddf7b2465cbf428
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Aug 13 10:27:47 2014 -0400
rdma: glusterfsd SEGV at volume start
glusterfsd NULL ptr deref in proto/server: get_frame_from_request()
with 'transport rdma' volume
no test case, our regression test framework doesn't have Infiniband.
If it did, the test case would be to create a 'transport rdma' volume,
start it, and create/write/read/delete files on the volume.
Change-Id: I91a6956bdf8f61f3853e0c0951744460ba138576
BUG: 1129708
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/8479
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 03692894ba735cde4f90ebef50b34049020b4330
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Aug 13 15:20:20 2014 +0200
NetBSD /dev/fuse detection
NetBSD's FUSE being pure userland implementation, there is no /dev/fuse
to open. Test /dev/puffs (kernel fs-in-userland subsystem supporting FUSE)
insead.
BUG: 764655
Change-Id: Ia65e95c246dc31ea2839cf64d7c851430828542e
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8478
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit d538e6ee66c3be8f7910e101ea645f16fe154c3d
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Aug 13 10:17:50 2014 +0530
tests: trigger entry heals by lookup
Trigger entry heals explicitly by lookup until heal full is fixed in
afr v2 to do conservative merge.
Change-Id: I474b518045bebcf399bc414caff3b415259381d6
BUG: 1127148
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/8465
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 782df7edf6b4241af23510958f0147e646ece12b
Author: ggarg <ggarg@redhat.com>
Date: Tue Jun 17 16:25:03 2014 +0530
glusterd: Coverity fix for going out of scope leaks of directory pointer
In function volgen_apply_filters() directory stream associated with
"filterdir" should be close after opening directory stream corresponding
to directory name. closedir() also closes the underlying file descriptor
associated with "filterdir".
Coverity CID: 1124723
Change-Id: I78ed04047ded98bf95d201afed01c727aa506882
BUG: 789278
Reviewed-on: http://review.gluster.org/8088
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit a5386bc0de27fcb404a137a45b69d4f294c9e859
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Aug 11 17:36:12 2014 -0700
porting: OSX/Darwin 10.9 porting issues
xdrproc_t() arguments are variadic and non-variadic
On OSX > 10.9
-------------
typedef bool_t (*xdrproc_t)(XDR *, void *, unsigned int);
On OSX < 10.9
------------
typedef bool_t (*xdrproc_t)(XDR *, ...);
FreeBSD all versions
------------
typedef bool_t (*xdrproc_t)(XDR *, ...);
NetBSD 6.1.4
-----------
typedef bool_t (*xdrproc_t)(XDR *, const void *);
Linux all versions
-----------
typedef bool_t (*xdrproc_t)(XDR *, void *,...);
This weird and odd implementations across various platforms
should be handled properly.
Change-Id: Iad8b7da2e5b82526bf3708cff31ab10ce09f59c9
BUG: 1128820
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8458
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 2414f84e2d098c43ce8e3c53d543f9d151c822fb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Aug 11 20:22:53 2014 +0530
cluster/afr: Fix mem-leak
Problem:
local->xattr_req is already reffed with xattr_req that comes
in lookup fop. But when afr_lookup_xattr_req_prepare is called
local->xattr_req is over-written with dict_new() which leads
to ref leak on the dict which came in lookup fop
Fix:
Create local->xattr_req only when it is NULL
Change-Id: Ib1548f2df97688859f2cace44b93b3b733297c36
BUG: 1128801
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8457
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ff4e4927adb493636f2d40d892f1764d070c8ec1
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Aug 9 23:54:15 2014 -0700
osx: Enable qemu feature build on Darwin
Change-Id: Ie5d437aa6c52c180fd8d54680c5f882e75c0bf7e
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8448
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 49cf07af11caa6fa271b86409b80d25dc61f1d76
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Aug 10 19:44:58 2014 +0200
Always build EC xlator
Now EC xlator does not require MMX anymore, always build it.
BUG: 764655
Change-Id: I50a64e22c080f2759eaa57786e7f69c34f11f89c
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8451
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit bef4ca0e10a27169e337c5c63e425a871db869b0
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Aug 8 02:59:34 2014 -0700
osx: snapview-server fails to build on OSX use 'syscall.h'
Change-Id: I29aeb32a972ed6d19e779b9e79fce9a489848497
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8436
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e46de700fbc901087ed47ed39951c56e950e833c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 8 12:01:34 2014 +0200
Search zlib without pkg-config
NetBSD has zlib installed in base system and no .pc file for it. In
order to discover it, fallback to AC_CHECK_LIB is PKG_CHECK_MODULES
fail to find it.
This enables cdc xlator, and we pass tests/basic/cdc.t
BUG: 764655
Change-Id: Ide84402aa38edc2709d12e2530401c6b8c722529
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8437
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit ff0b0829e8f1b11ed9478fe5496983352e64eec7
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Aug 4 13:22:10 2014 +0200
Regression test portability: xargs
Linux xarg complains about an empty input, while NetBSD xargs does not.
This breaks tests where xargs is in a pipe after a command that should
be tested. Make sure we test the first command without xargs
BUG: 764655
Change-Id: I754d7d52332221c462ce3594f4e8d8d62ae606d5
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8280
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 88b01857a0c045d9a7a1fc4994fd189725edf9e9
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Fri Aug 8 15:54:03 2014 +0530
mount: Verify mount failure in mount.glusterfs wrapper.
The result of mount command execution is not checked properly, thus
no proper message given for the end user. This patch fix the same.
Bug Id: 1128165
Change-Id: I3882e34e840ed15b5ce48ed5e1ad51208e2be913
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8438
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 0f5a52249b8dd7cad57cabb716d2345fd3f90de4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Aug 8 10:01:35 2014 -0400
extras/LinuxRPM: error in Makefile.am
Change-Id: I50de95ca6eff09338ce4a6f9f2b42aeccd10cae2
BUG: 1128192
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/8444
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit d47ea72a95184a35d2041b4c6887e110cb63a94f
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 8 05:19:15 2014 +0200
Wrong test in self-heal.t
self-heal.t checks for gfid before and after an operation, but fails
to do it on the same file since the prefix is not the same: undefined
$B1 before and $B0 after.
The errorcause the test to fail on NetBSD. I do not know how this test
could pass on Linux before.
BUG: 764655
Change-Id: I6df1175e177855afca1736cf8c847c51fe407576
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8431
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 8c856527fc2c2ae8fda499340c71b5f91f0be6ad
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sun Jun 29 18:56:44 2014 -0700
build: make GLUSTERD_WORKDIR rely on localstatedir
- Break-way from '/var/lib/glusterd' hard-coded previously,
instead rely on 'configure' value from 'localstatedir'
- Provide 's/lib/db' as default working directory for gluster
management daemon for BSD and Darwin based installations
- loff_t is really off_t on Darwin
- fix-off the warnings generated by clang on FreeBSD/Darwin
- Now 'tests/*' use GLUSTERD_WORKDIR a common variable for all
platforms.
- Define proper environment for running tests, define correct PATH
and LD_LIBRARY_PATH when running tests, so that the desired version
of glusterfs is used, regardless where it is installed.
(Thanks to manu@netbsd.org for this additional work)
Change-Id: I2339a0d9275de5939ccad3e52b535598064a35e7
BUG: 1111774
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8246
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bcce8e63b201984e03f67a8ac2c446fc3443f738
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Jul 29 02:21:20 2014 +0200
Regression test portability: truncate, md5
Add shell functions to replace truncate and md5, which are Linux specific
Resubmit because of failed regression test with no apparent cause
BUG: 764655
Change-Id: I07200cf886bd52904a5cf63c66f43f0b1cc91540
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8341
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 55b7011df1290fb9dedf02c0fb98542a0ff79fde
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Aug 5 12:35:10 2014 -0700
tests: weighted-rebalance.t shouldn't write to '/dev/tty'
On our jenkins instance "/dev/tty" doesn't exist, necessary
output fails as below message
~~~
./tests/features/weighted-rebalance.t: \
line 72: /dev/tty: No such device or address
~~~
Comment out the debugging code
Change-Id: Iba29b80c8ba2dcaab3d6654d7c54332a915bffb8
BUG: 1114680
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8421
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ca1f9bd32cf45eab20fbac5de2fa4493e676d6c7
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Wed Jul 9 00:54:48 2014 +0530
libglusterfs: wrong function definition of synclock_destory().
synclock_destory() has been prototyped in syncop.h,
how-ever synclock_destroy() is the actual function used in syncop.c.
Correcting this function definition along with few typos.
Change-Id: I35a818190c1d37c303279ca7a820f01895751bd9
BUG: 1075417
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8266
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5ebc85ea339d154ca21bf01fde8ae451270fa3c0
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Jul 23 18:24:55 2014 +0530
doc: afr-locks and its evolution
History and current state of how AFR uses the inode and entry locks
provided by the locks xlator
Thanks to Pranith for patiently explaining this.
Change-Id: I25d21c6361e95aa0b3edcffe9b3b9e470f488bc6
BUG: 1118309
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/8364
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 63823837fce7668df4f78f6a6794fba745c99c4e
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Tue Jul 29 18:51:21 2014 +0530
gluster vol set nfs-ganesha.enable off fails to unexport volume.
Due to a parameter type change in upstream nfs-ganesha
( v2.1 and above ), gluster vol set <volname> nfs-ganesha.enable
off doesn't unexport the volume in question if it was already
exported.
A minor change in the hook script would result in the
expected behaviour.
Change-Id: I46f76f3cde6b6ebd7a94d5ee16f05a3648a2840f
BUG: 1124711
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/8390
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 257e9ca905a689f22e0ecc809f32d9d601ea3f8c
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Jul 29 18:50:29 2014 -0700
socket: add boundary checks for iobuf_get2 over rpc_hdr_bytes
A malformed packet can cause a OOM while peforming iobuf_get2()
on a large enough packet side.
Such a scenario is observed when running vulnerability tests,
it would look like one of those tests perhaps based on DDOS (Denial
of Service) attacks hand-crafts a RPC packet which is of a large
enough size - since we do not verify the size and do not provide
any boundary checks, there are secenarios where it leads to OOM.
Reproducible consistently with those tests has revealed that we
should be ideally be adding a boundary check.
Limit such an allocation to a 1gigabyte, as it might be sufficient
to handle for all variety of RPC packets.
Change-Id: I5f1411dd96d6f167993d28a1718ffef2fb4e9923
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8384
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit c9abea2be54d247513ad67041de64afedbecdd6b
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Aug 2 05:42:39 2014 +0200
Regression test portability: arequal-checksum
Building arequal-checksum on non Linux systems requires a few adjustments:
- use __builtin_alloca() on all platforms
- on systems without argp, get it from contrib/standalone-argp
(this requires adding cflags support to the build_tester function)
- FTW_ACTIONRETVAL option to nftw(3) is GNU libc specific, work around
if it does not exist.
- md5sum is Linux-specific. Use md5 -n on NetBSD and md5 -q on FreeBSD/Darwin
- Use 'cc' as synonymous for all compilers, it can behave as gcc/clang depending
on which is default
- cleanup tabs/whitespaces
BUG: 764655
Change-Id: I9090c17da596fbf00fc1fbd7593163ce8cd3b84c
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8283
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9af482e76639b5a2c198ca021cc41b01eee1a616
Author: Kotresh H R <khiremat@redhat.com>
Date: Fri Aug 1 16:12:38 2014 +0530
feature/geo-rep: Keep marker.tstamp's mtime unchangeable during snapshot.
Problem:
Geo-replicatoin does a full xsync crawl after snapshot
restoration of slave and master. It does not do history crawl.
Analysis:
Marker creates 'marker.tstamp' file when geo-rep is started
for the first time. The virtual extended attribute
'trusted.glusterfs.volume-mark' is maintained and whenever
it is queried on gluster mount point, marker fills it on
the fly and returns the combination of uuid, ctime of
marker.tstamp and others. So ctime of marker.tstamp, in other
sense 'volume-mark' marks the geo-rep start time when the
session is freshly created.
From the above, after the first filesystem crawl(xsync) is
done during first geo-rep start, stime should always be less
than 'volume-mark'. So whenever stime is less than volume-mark,
it does full filesystem crawl (xsync).
Root Cause:
When snapshot is restored, marker.tstamp file is freshly
created losing the timestamps, it was originally created with.
Solution:
1. Change is made to depend on mtime instead of ctime.
2. mtime and atime of marker.tstamp is restored back when
snapshot is created and restored.
Change-Id: I4891b112f4aedc50cfae402832c50c5145807d7a
BUG: 1125918
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8401
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 89b7f5647f8dfac1c45c733702027ec30250a9a5
Author: Kotresh H R <khiremat@redhat.com>
Date: Mon Aug 4 15:33:02 2014 +0530
geo-rep/libgfchangelog: Support of symlinks while creation of working dir.
In gf_changelog_register, enable symlink support while creating
working directory if its not already created.
Change-Id: I4b81762d04f5276a65087d2ff94f2a36dc504b58
BUG: 1125843
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8409
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 912728cf420b6f0fc92fef4683ebb81d24914ea6
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Jul 31 05:37:37 2014 +0200
Do not call rpc_transport_unref() on NULL trans
rpc_clnt_disable() sets rpc->conn->trans to NULL, hence we should not
call rpc_transport_unref() afterwards. I moved it before the
rpc_clnt_disable() call, but I am not sure it should be called at all,
perhaps it should just go away.
BUG: 764655
Change-Id: I488d0207494e3a3fad52e64e67b2e740b236b864
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8393
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 2693d4eb0bd3a2db493c42c03b854fa0ef5be0f7
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Aug 1 01:30:45 2014 +0530
glusterd: Bump max op version
Change-Id: Ic66a0a751233ebbcb65d13f7e3265a046fae9a0b
BUG: 1125431
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8397
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 78b3ac27a75a9c3036df9c74e014606fdb450aa3
Author: Vijaikumar M <vmallika@redhat.com>
Date: Thu Jul 31 14:37:19 2014 +0530
glusterd/snapshot: Inherit the mount options of a original brick when creating snapshots
When creating a snapshot a LVM is created at the backend and is mounted
under /var/run/gluster/snaps/... However, this mount does not inherit
the mount options for the original brick acting as the parent for the
snap.
If the snap is restored, this could lead to performance degredations,
functional limitations, or in extreme scenarios even potential data
loss.
Change-Id: I67d70fd83430d83dacc5380c6c928e27fb9c9e1b
BUG: 1125180
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8394
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 199baf3194cf4a6beee1f726fff8e657701a3c41
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Jul 8 17:52:57 2014 +0200
cluster/ec: Fix incorrect management of NFS requests
Some operations, specially those comming from NFS, do not use a
regular fd and use an anonymous fd (i.e. a previous open call has
not been sent). Any context information created during open or
create will not be present on these fd's, so we simply return NULL
for contexts of those fd.
Also it seems that NFS can send write requests with a very big
buffer (higher that the default value of 128 KB). Some changes
have been made to correctly handle these large buffers.
Change-Id: I281476bd0d2cbaad231822248d6a616fcf5d4003
BUG: 1122417
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8367
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d3c8f60d2f814af5b892d449b42567d6c8273e8d
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Tue Jul 15 18:43:44 2014 +0200
ec: Test volume mount point in a better way
An 'ls -a1' on an empty volume seems to return 3 entries instead
of the expected 2 ('.' and '..') in the build servers. I changed
the test to a simple 'stat', which is enough and more reliable.
Change-Id: I12d0f47394ad378b40fc9b86507cdb3543f99970
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8313
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0ad662dc8dd4a9572bf817c2e5e75594f8dc249d
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Jul 16 16:52:42 2014 +0200
tests: Avoid test bug-884597.t to loop infinitely
If some unexpected error happens while this test is trying to
create a linkto file, an infinite loop is generated and the test
never ends.
This patch limits the number of retries it can do to find that
file.
Change-Id: Ie556c509116109ead99c78d671b2669b4428faac
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8318
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b5c301fae7e520302cb3b2a2d1e3748de1ff43a7
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Tue Jul 29 20:20:13 2014 +0530
nfs-ganesha dumps core when Pynfs tests OPDG1O and OPDG11 are run.
Assgining -1 to ret if fd_create fails. The tests somehow
enter an error case 'if' block (this will be a separate bug fix),
before glfd is created. Need an addiitional check to see
if glfd exists before entering the 'else' block in 'out'.
glfs_h_creat was missing a similar check, adding that in
this bug fix.)
Change-Id: I3b69540c53e8169538848b9e7f23ffc8ef0ac189
BUG: 1121062
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/8333
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f78c3166e49533f67f37de5a5cba3f3ce1292140
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Aug 2 02:23:34 2014 +0200
Regression test portability: system-specific cleanup
Add NetBSD system-specific cleanup code
Define killall as pkill when it is missing.
BUG: 764655
Change-Id: I3a1cfa3029fd60ede334a670fc115c211700063d
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8290
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 25d07e5b59c0627de6ce20cf14c3832745fc6365
Author: Kotresh H R <khiremat@redhat.com>
Date: Fri Aug 1 14:08:56 2014 +0530
geo-rep/libgfchangelog: Create working dir during changelog_register if not present.
Earlier, xysnc's register was being called first,
which was creating working directory before calling
changelog_register. Now it is history crawl first.
Hence working directory would not have been created.
Create it in gf_changelog_register itself if it is
not already created.
Change-Id: Ief3f2b87deaf5da16c135b64be1be42e0a7647f3
BUG: 1125843
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8399
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 970a97f271231eadb8606e8ff544959aa4110057
Author: Zhang Huan <zhhuan@gmail.com>
Date: Fri Mar 7 11:08:47 2014 +0800
storage/posix: fix issue in posix_fsync
Fix the issue that posix_fsync does not correctly return and save
error code in op_errno when call to sys_fdatasync fails.
Change-Id: Id0b62cfa009dbb52c8a0992abd5c46330fa0a8c0
BUG: 1125814
Signed-off-by: Zhang Huan <zhhuan@gmail.com>
Reviewed-on: http://review.gluster.org/8398
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ba01d52287abb1dc56a562acf8ff4ee84a8b372c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 15 21:45:35 2014 +0530
doc: mem-pool documentation
Change-Id: I9bc454c92a078de5e3a30372a50c6f2cbdcd6c21
BUG: 1118309
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8343
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ece3ae61930d2a647e001b1ad57d8c95d5e94dc5
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri Jul 25 17:21:04 2014 +0530
cluster/dht: Modified logic of linkto file deletion on non-hashed
Currently whenever dht_lookup_everywhere gets called, if in
dht_lookup_everywhere_cbk, a linkto file is found on non-hashed
subvolume, file is unlinked. But there are cases when this file
is under migration. Under such condition, we should avoid deletion
of file.
When some other rebalance process changes the layout of parent
such that dst_file (w.r.t. migration) falls on non-hashed node,
then may be lookup could have found it as linkto file but just
before unlink, file is under migration or already migrated
In such cased unlink can be avoided.
Race:
-------
If we have two bricks (brick-1 and brick-2) with initial file "a"
under BaseDir which is hashed as well as cached on (brick-1).
Assume "a" hashing gives 44.
Brick-1 Brick-2
Initial Setup: BaseDir/a BaseDir
[1-50] [51-100]
Now add new-brick Brick-3.
1. Rebalance-1 on node Node-1 (Brick-1 node) will reset
the BaseDir Layout.
2. After that it will perform
a) Create linkto file on new-hashed (brick-2)
b) Perform file migration.
1.Rebalance-1 Fixes the base-layout:
Brick-1 Brick-2 Brick-3
--------- ---------- ------------
BaseDir/a BaseDir BaseDir
[1-33] [34-66] [67-100]
2. Only a) is BaseDir/a BaseDir/a(linkto) BaseDir
performed Create linktofile
Now rebalance 2 on node-2 jumped in and it will perform
step 1 and 2-a.
After (rebal-2, step-1), it changes the layout of the BaseDir.
BaseDir/a BaseDir/a(link) BaseDir
[67-100] [1-33] [34-66]
For (rebale-2, step-2), It will perform lookup at Brick-3 as w.r.t new
layout 44 falls for brick-3. But lookup will fail.
So dht_lookup_everywhere gets called.
NOTE: On brick-2 by rebalance-1, a linkto file was created.
Currently that linkto files gets deleted by rebalance-2 lookup as it
is considered as stale linkto file. But with patch if rebalance is
already in progress or rebalance is over, linkto file will not be
unlinked. If rebalance is in progress fd will be open and if rebalance
is over then linkto file wont be set.
Change-Id: I3fee0d28de3c76197325536a9e30099d2413f079
BUG: 1116150
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8345
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 924eed5c738b705d4a3d3bec9fa829093a837b3b
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Jul 31 11:51:12 2014 +0200
ec: Add -msse2 option to avoid fedora/rawhide compilation errors
This solves a compilation error on some compiler versions.
To avoid compilation issues on non-Intel architectures, patch
http://review.gluster.org/8366/ has already been merged. It
disables ec on those architectures.
These modifications are temporary patches until a proper
solution for bug #1125166 is ready.
Change-Id: I74d0b79e84601cc4f86ad08ce0f8102b99a79a68
BUG: 1125168
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8395
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fc1b16ede15dc99248f652152d8eea6bb1bc7e5e
Author: Anders Blomdell <anders.blomdell@control.lth.se>
Date: Tue Jul 29 17:11:20 2014 +0200
Symlink mtime changes when rebalancing
Added mtime preservation for special files during rebalance.
Change-Id: If04921d4d66853fde8b4d8a3ab748790864f8f42
BUG: 1122443
Signed-off-by: Anders Blomdell <anders.blomdell@control.lth.se>
Reviewed-on: http://review.gluster.org/8383
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7b0de6f73db536fa2620d0a4b0da064a5e283451
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jul 10 12:49:53 2014 +0530
client/rpc: Add ping and msgs stats
This can be seen as below,
># cat $META/graphs/active/vol-client-0/private |grep ping_msgs_sent
ping_msgs_sent = 2
># cat $META/graphs/active/vol-client-0/private |grep "^msgs_sent"
msgs_sent = 13
where $META is /<fuse-mountpt>/.meta
Change-Id: I2107ec2b045bac701377760635e18758adb943a3
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/8285
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a15bf492bc66c33923550b31b2002c8a45570346
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Jul 29 02:32:14 2014 +0200
Regression test portability: run-test.sh
- Check for pidof(8) presence. It may not be present on non Linux systems
- Add a -f flag to run-tests.sh to bypass utility presence checks
Submit again because of spurious regression test failure
BUG: 764655
Change-Id: Iee6282c686c63a01808543054f8e5a3b5b79fca2
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8279
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 973ce0f53c5c25210577a7390849494afc50dd74
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jul 30 15:19:38 2014 +0200
build: fix compile issue in unittest on EPEL-5
When building the current master branch on EPEL-5, the following error
is observed:
CC dht_layout_unittest-dht_layout_mock.o
unittest/dht_layout_mock.c:77:2: error: no newline at end of file
make[5]: *** [dht_layout_unittest-dht_layout_mock.o] Error 1
make[5]: *** Waiting for unfinished jobs....
EPEL-5 has this gcc:
$ gcc --version
gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-54)
The fix is simple enough, dht_layout_unittest-dht_layout_mock.c should
have a line ending.
BUG: 1124858
Change-Id: I8ca7a1699fd1c35694073b9577f94ae525854713
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8392
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Luis Pabon <lpabon@redhat.com>
commit e2ab17f9102ffd41bffee2cdaea0ee6b1d341aa6
Author: Anders Blomdell <anders.blomdell@control.lth.se>
Date: Tue Jul 8 15:36:45 2014 +0200
Make RPM's with current git tag
1. clear autom4te.cache
2. autogen.sh
3. configure --with-previous-options
Change-Id: I90c1820d22207d18b1bb367444b21918467baea5
BUG: 1117921
Signed-off-by: Anders Blomdell <anders.blomdell@control.lth.se>
Reviewed-on: http://review.gluster.org/8293
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 41b6747df6c1bd9d11ff57fe0de84cde11c548de
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed May 21 10:22:22 2014 +0530
nfs/drc: Fix memory corruptions
* A wrong memory allocator was used to (de)allocate nodes (not data in
them) of rb tree. This patch uses default allocator, since that suits
our purpose.
* Fix reference counting of client, though hitting the codepath
containing this bug is highly unlikely.
Change-Id: I7692097351d6e54288fee01da5af18e761fd0e8c
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
BUG: 1067256
Reviewed-on: http://review.gluster.org/7816
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 141ba63904f070c1dbba8c239a7463234659ee2d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jul 22 13:45:41 2014 +0530
cluster/afr: Improve inodelk/entrylk failure log messages
Change-Id: Ie792875546b4f8e11ebf870a6e63aaf5cb221976
BUG: 1121920
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8344
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 2e71517e9330460fec30b2271896eaf5213b8869
Author: Vijaikumar M <vmallika@redhat.com>
Date: Tue Jul 15 13:49:41 2014 +0530
glusterd: Error msg for snapshot status for no existing snaps should be aligned with error messages of info and list
When a snapshot operation like status, info, list
performed on a non-existing snapshot.
For Status error message is displayed as 'Snap not found'
For List and Info error message is displayed as 'Snapshot does not exist'
Have the consistant error message all the places
Change-Id: I7b241217dba62fda844481731a6858e4ecb12897
BUG: 1119641
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8309
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit d01bd40fe2ad005af7e6ebf68c250ade6da9f851
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Sun Jul 27 10:36:52 2014 -0400
glusterd/snapshot: Proper err msg for snapshot create command
problem: Snapshot command fails if one or more bricks are not thinly
provisioned. But the error message is a generic error message which
is confusing to the user.
fix: Provide correct error message in case of failure.
Change-Id: Iad247f966423a8f73ef6da57cab7ed6cddc05861
BUG: 1123646
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/8377
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 9b41d77718530abbd7a49f71707b397b05843f6a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jul 22 11:43:09 2014 +0530
cli : glusterd getspec usage correction
gluster system getspec asks to input volume-id instead of volume name
Change-Id: I0baef9c937fc8948477aa65c8f98916b28c1e484
BUG: 1121870
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8342
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit aaf6f579ed8089fff149bc931fb2e526bd6ab64d
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Mon Jul 21 18:46:14 2014 +0530
dht: fix rename race
Additional check to check if we created the linkto
file before deleting it in the rename cleanup function
Change-Id: I919cd7cb24f948ba4917eb9cf50d5169bb730a67
BUG: 1117851
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/8338
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5b9a9da96bf76683e6264b17979696b376979ab4
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Jul 17 21:59:26 2014 +0530
storage/posix: removing deleting entries in case of creation failures
The code is not atomic enough to not to delete a dentry created by a
prallel dentry creation operation.
Change-Id: I9bd6d2aa9e7a1c0688c0a937b02a4b4f56d7aa3d
BUG: 1117851
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8327
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 16f618128b95f8d7e92ae9c40f7d26a650bf9fa0
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Jul 28 09:53:50 2014 +0530
doc : man page and admin-guide for newly introduced snapshot delete option.
Change-Id: Iab5e7f63d673a2040e8d83ab7280121ff468836e
BUG: 1112613
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8378
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 75a859ca52bdccfb83c48a093da2e1775daf0340
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Jun 6 12:51:57 2014 +0530
libgfapi : glfs_create()/glfs_h_creat()/glfs_open()/glfs_h_open() should set fd->flags before syncop_open()
glfs_create() and glfs_open() do not set fd->flags before calling syncop_open().
This patch addresses this problem and ensure the flags are set in fd before
invoking syncop_open()
Change-Id: I9ef3243b1de610e1dd1a3e37b66fc2f763a865f9
BUG: 1096047
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7999
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 939338cc2fa7cbd080536d405e9d37f142622ed5
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Jul 10 06:02:38 2014 +0200
Regression test portability: ps
ps aux is truncated to the terminal width on NetBSD, Use ps auxww to
avoid that
BUG: 764655
Change-Id: I28a2fc23e2823dd6524a72da30111b86fc4bfa7b
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8281
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 7e6eaa892e9f883d8563f3322082ba1a0baabd34
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Jul 10 15:13:27 2014 +0200
Regression test portability: hostname
The --fqdn option to hostname is Linux only
This is resubmission of the same patch. I assume the regression test
is a test bug
BUG: 764655
Change-Id: I6437124186435f10d1ee6a847e2593554d633716
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8282
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 71a78b014244085de843c36690b1fc6393b4b46d
Author: Kotresh H R <khiremat@redhat.com>
Date: Wed Jul 23 18:12:39 2014 +0530
tests/bug-961307.t: echo output string in case of failure for easy debug.
Change-Id: I5bb5d7f2d9380da3247588e8eff10b559e17ff3f
BUG: 1122533
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8362
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a0c1dcd6f373d0dc710304558a778d147149fb02
Author: Anders Blomdell <anders.blomdell@control.lth.se>
Date: Thu Jul 24 16:55:45 2014 +0200
Allow gluster to be used with linux automounter
Added (ignored) -n option to mount.glusterfs command
Change-Id: I9209da215d38507cd9d01b1e9af4aecff4414f83
BUG: 1123004
Signed-off-by: Anders Blomdell <anders.blomdell@control.lth.se>
Reviewed-on: http://review.gluster.org/8373
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f066ddc03c537d1e0fe8ca2a31f9e54aee3a5d47
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Sat Jul 12 22:31:45 2014 +0530
rpc,glusterd: Set ret to 0 after call to rpc_clnt_submit()
This is to guard against a double STACK_DESTROY in the event that
rpc_clnt_submit() failed and returned -1 anytime after sending the
request over the wire. in which case the stack could be destroyed
twice: once in the callback function of the request and once in
the error codepath of some of the callers of glusterd_submit_request().
This bug was introduced in http://review.gluster.org/#/c/8257/
Change-Id: I18a345db6eafc62ba312743201ced7d3f8697622
BUG: 1116243
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8301
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ac7b7bcbc3bf17f10a29312b29c60f221dc615c1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 9 17:31:52 2014 +0530
doc: How to generate and read statedump
Thanks to Poornima G's help with iobuf
Section explanation.
Change-Id: I17737fdbd1f402914f7e67fb4047f5c26ea5c36c
BUG: 1118309
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8288
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 01e6708e7bde4068ea2a4bea5a925e5ed32d4331
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Jul 27 08:45:50 2014 +0200
Attempt to fix cmockery2 build
The current code assumes cmockery2 is installed in default paths.
Use PKG_MODULES_CHECK to find it using pkg-config if it is not. If
not found by pkg-config, try AC_CHECK_LIB.
There are also some build flag adjustement so that local overrides
do not loose the required -I flags.
This includes and enhance http://review.gluster.org/8340/
BUG: 764655
Change-Id: Ide9f77d1e70afe3c1c5c57ae2b93127af6a425f9
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8365
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 66c61db2c33b18fd748dbd40ad121021652e5398
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Jun 23 09:35:52 2014 +0530
feature/snapshot : Interface to delete all snapshots belonging to a system as-well-as to a particular volume.
Problem :
With the current design we can only delete a single snapshot.
And the deletion of volume which contains snapshot is not allowed.
Because of that user might be forced to delete all the snapshots
manually before he is allowed to delete a volume.
Solution:
Following is the interface with which user can delete
all the snapshots of a system or belonging to a particular volume.
Syntax : gluster snapshot delete all
*To delete all the snapshots present in a system
Syntax : gluster snapshot delete volume <volname>
*To deletes all the snapshot present in a volume specified.
========================================================================
Sample Output:
Case 1 : Deleting a single snapshot.
[root@snapshot-24 glusterfs]# gluster snapshot delete snap1
Deleting snap will erase all the information about the snap. Do you still want to continue? (y/n) y
snapshot delete: snap1: snap removed successfully
-----------------------------------------------------------------
Case 2 : Deleting all the snapshots in a Volume.
[root@snapshot-24 glusterfs]# gluster snapshot delete volume vol1
Volume (vol1) contains 9 snapshot(s).
Do you still want to continue and delete them? (y/n) y
snapshot delete: snap2: snap removed successfully
snapshot delete: snap3: snap removed successfully
snapshot delete: snap4: snap removed successfully
snapshot delete: snap5: snap removed successfully
.
.
.
-----------------------------------------------------------------
Case 3 : Deleting all the snapshots in a system.
[root@snapshot-24 glusterfs]# gluster snapshot delete all
System contains 4 snapshot(s).
Do you still want to continue and delete them? (y/n) y
snapshot delete: snap7: snap removed successfully
snapshot delete: snap8: snap removed successfully
snapshot delete: snap9: snap removed successfully
snapshot delete: snap10: snap removed successfully
========================================================================
Change-Id: Ifec8e128ab2011cbbba208376b9c92cfbe7d8d71
BUG: 1112613
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8162
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 039db10942c1c37544151dfff46a9f5f87da4e0e
Author: Sachin Pandit <spandit@redhat.com>
Date: Wed Jul 23 08:24:19 2014 +0530
doc : man page for snapshot commands
This patch also contains few modifications in admin documentation.
Change-Id: I7bc2a88e6cbcfe81dcfafc2956f5b7c5524b0f0b
BUG: 1122399
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8357
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 46b7aa02b80a9bcc9967b75c34dc043f5eb0d2b4
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jul 17 08:30:52 2014 +0000
glusterd: update volinfo->subvol_count during remove-brick operation.
Problem:
In glusterd_op_remove_brick(), volinfo->subvol_count was getting updated only if
the replica count was reduced due to which subvol_matcher_verify() gave false
errors under certain scenarios (see bug description).
Fix:
updated subvol_count for every remove-brick operation.
Change-Id: Id72691e2bda1c624cd7d8cae92f6bf32c101a6d3
BUG: 1120647
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/8326
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 819a3d4a58e978f191dd08b385ad45567a2353fe
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sun Jul 20 14:59:42 2014 -0700
glusterd: Avoid spurious WARNING 'op_ctx modification failed'
This patch fixes by wrapping this whole scenario and skips
op_ctx modification for necessary commands.
Change-Id: I3ecec19caefdc699d9a2dabfb456a89758ae4aa4
BUG: 1066529
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8337
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 6a9f447a2612e7de41efb5a678b4e5d034cabb38
Author: ndarshan <dnarayan@redhat.com>
Date: Tue Jul 22 14:19:19 2014 +0530
cli: Xml output for geo-replication status command.
This patch adds xml output for geo-replication status
and status detail command.
sample:
--------------------------------------------------------------
<geoRep>
<volume>
<name>master</name>
<sessions>
<session>
<session_slave>:2a301d66-b9d2-44b4-b827-d680d67123eb:ssh://XXXXXXXXXX::slave</session_slave>
<pair>
<master_node>localhost.localdomain</master_node>
<master_node_uuid>2a301d66-b9d2-44b4-b827-d680d67123eb</master_node_uuid>
<master_brick>/root/master_b1</master_brick>
<slave>ssh://XXXXXXXXXXX::slave</slave>
<status>faulty</status>
<checkpoint_status>N/A</checkpoint_status>
<crawl_status>N/A</crawl_status>
</pair>
</session>
</sessions>
</volume>
</geoRep>
-------------------------------------------------------------
Change-Id: Ia19dbe751c3ab1ec7cb8923cdd6c8b99c374072f
BUG: 1121518
Signed-off-by: ndarshan <dnarayan@redhat.com>
Reviewed-on: http://review.gluster.org/8089
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 2686826e9c8b8c7ced4290e543bba24d69d23c99
Author: Vijaikumar M <vmallika@redhat.com>
Date: Thu Jul 24 12:47:04 2014 +0530
glusterd/snapshot: Print correct error message on cli for snapshot operation performed on a cluster with op-version less than 30600
Currently we get error message as on cli 'Another transaction is in progress
Please try again after sometime' when a snapshot operation is performed
on a cluster with op-version less than 30600.
We need to print the correct error message in this case.
Change-Id: I5f144428d928393c3796bde96ce6e3a40fca8141
BUG: 1122816
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8371
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 38dacbb47c1bf70c881db2307e5c6dfcf0cbd383
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jul 23 18:08:08 2014 +0530
cli: Fix no libxml compilation for snapshot status
BUG: 1122186
Change-Id: Ib887f2194258e85d40f65a758b6a963a17911395
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/8363
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
commit bad1114dfe5a0920d1b5ec032f44d86afe2a2433
Author: Sachin Pandit <spandit@redhat.com>
Date: Thu Jun 26 07:51:02 2014 +0530
cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info.
Problem : Even though snap-max-hard-limit, snap-max-soft-limit and
auto-delete values were not set explicitly, It was getting showed
in the output of gluster volume info.
Solution : Check if the value is already present in dictionary
(That means, it is set), If value is not present then consider
the default value,
NOTE : This patch doesn't solve the problem where the values
which is set globally are being displayed in gluster volume info
Change-Id: I61445b3d2a12eb68c38a19bea53b9051ad028050
BUG: 1113476
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8191
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 9ae86cc68126411e4c14e901654f35796dabe286
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Jun 23 13:43:20 2014 +0530
geo-rep: minimize xsync crawl usage and set upper limit to xsync crawl
For effective handling of deletes and renames use history crawl
as much as possible. History crawl will run in loop till it syncs
all data before live changelog time.
When it uses xsync crawl(fallback when changelog not available, or
very first crawl) it sets upper limit to crawl.
After completing History crawl, it checks actual end time returned
by history api to compare with register time, if actual end is less
than register time then run history crawl one more time.
If first turn history processing time is less than the CHANGELOG
ROLLOVER TIME then sleep for the difference, After sleep if it is
guaranteed that rollover will happen and switches to live changelog
consumption without switching to xsync. This sleep is only when
history processing completed < CHANGELOG_ROLLOVER_TIME and sleep
only after the first turn, So will not affect the performance.
BUG: 1112238
Change-Id: I644ef24b07e42e81cec96a025ebd21244a555ec0
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/8151
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 9f35d0db7cf4fc97efb55e8aa240d58bbd790e97
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri Jul 18 15:36:42 2014 +0530
features/changelog: Capture "correct" internal FOPs
This patch fixes changelog capturing internal FOPs in a cascaded
setup, where the intermediate master would record internal FOPs
(generated by DHT on link()/rename()). This is due to I/O happening
on the intermediate slave on geo-replication's auxillary mount with
client-pid -1. Currently, the internal FOP capturing logic depends
on client pid being non-negative and the presence of a special key
in dictionary. Due to this, internal FOPs on an inter-mediate master
would be recorded in the changelog. Checking client-pid being
non-negative was introduced to capture AFR self-heal traffic in
changelog, thereby breaking cascading setups. By coincidence,
AFR self-heal daemon uses -1 as frame->root->pid thereby making
is hard to differentiate b/w geo-rep's auxillary mount and self-heal
daemon.
Change-Id: Ib7bd71e80dd1856770391edb621ba9819cab7056
BUG: 1122037
Original-Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8347
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d1561139eaf06dc002477f4f6172d9ca9b1df1ab
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Jul 23 15:11:56 2014 +0200
Disable Erasure Code xlator if MMX is missing
Erasure Code xlator requires MMX instruction set.
Disable building it if MMX is missing.
BUG: 764655
Change-Id: Id9fe87db33e00c5630c1f3633ebd50fc4ebaec4d
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8366
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d37a655e36d9f5e9cdc38c292a0d8367a3df5ed9
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jul 23 12:47:33 2014 +0530
Bump op-version for 3.7.0
Change-Id: I4542edeca140bc2252d765b5cfc2e24d1d90cdb1
BUG: 1122398
Reviewed-on: http://review.gluster.org/8354
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 922176464307869251f5d1b652b314d03601876d
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Jul 16 15:49:48 2014 -0700
porting: include compat-errno.h for errno's
disperse module fails to compile since
ENODATA is non-existent on FreeBSD/Darwin
Use errno conversion in compat-errno.h to avoid
build issues.
Change-Id: I8203b7195c198c77202bde9bbec1813a487f923a
BUG: 1111774
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8320
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit c22e661b4c7196bbaedb3f9d44413389c12cede6
Author: Varun Shastry <vshastry@redhat.com>
Date: Wed Jul 9 15:16:00 2014 +0530
features/marker: Fill loc->path before sending the control to healing
Problem:
The xattr healing part of the marker requires path to be present in the loc.
Currently path is not filled while triggering from the readdirp_cbk.
Solution:
Current patch tries to fill the loc with path.
Change-Id: I5c7dc9de60fa79ca0fe9b58d2636fd1355add0d3
BUG: 1118591
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/8296
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 0ebaf8ab9d091ff8d1e81435f880003eb5e737cc
Author: ndarshan <dnarayan@redhat.com>
Date: Mon Jul 21 13:55:33 2014 +0530
cli: Xml output for geo-replication config command
This patch adds xml output for geo-replication config
command.
sample:
---------------------------------------------------------------------
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<geoRep>
<config>
<parameter1_name>value</parameter1_name>
<parameter2_name>value</parameter2_name>
...
...
...
</config>
</geoRep>
</cliOutput>
---------------------------------------------------------------------
Change-Id: Iac0451983ae5d0e65b95604eb1c29b968e1ee22f
BUG: 1121518
Signed-off-by: ndarshan <dnarayan@redhat.com>
Reviewed-on: http://review.gluster.org/8270
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 9b9c53cf3a8458698cfe3b86378f2d726ed13adf
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Wed Jul 16 13:50:53 2014 +0200
ec: Fixed coveriry scan issues
CID list:
1226163 Logically dead code
1226166 Missing break in switch
1226167 Missing break in switch
1226168 Missing break in switch
1226169 Missing break in switch
1226170 Missing break in switch
1226171 Missing break in switch
1226172 Missing break in switch
1226173 Missing break in switch
1226174 Missing break in switch
1226175 Missing break in switch
1226176 Missing break in switch
1226177 Missing break in switch
1226178 Data race condition
1226179 Data race condition
1226180 Data race condition
1226181 Thread deadlock
1226182 Uninitialized pointer read
1226183 Uninitialized pointer read
1226184 Read from pointer after free
Change-Id: I4d33aa42289371927175c43bb29e018df64fb943
BUG: 789278
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8317
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 117584d54747dd409eb45fd66d06bce0aeaabf16
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Jul 14 13:07:08 2014 +0000
gluster: Fix the recursive goto outs in the source code.
Added a script check_goto.pl, that when run from
the source code root, will scan all .c files to match
the following pattern:
label:
if (condition)
goto label;
On finding such a pattern the script will print the file name
and the line number. There are certain cases where the above
recursive pattern is intended. Hence adding those labels to
ignore-labels. Thanks Vijaikumar Mallikarjuna for the perl
script.
Also fixed all such existing errors
Change-Id: I1b821d0a8c296f16e40faff20bd029bdc880c2e9
BUG: 1119256
Signed-off-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/8307
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 1fa2dcfb4a094c1a8aa65d2ffa88fa6e37e1311d
Author: Anders Blomdell <anders.blomdell@control.lth.se>
Date: Fri Jul 11 19:10:21 2014 +0200
Use C-locale for numeric/string conversion routines
(strtod, ...) or config file parsing might fail.
Change-Id: I649f29bbf87222399a0c2d1ed5a3bf136c613b9b
BUG: 1117951
Signed-off-by: Anders Blomdell <anders.blomdell@control.lth.se>
Reviewed-on: http://review.gluster.org/8299
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ceca8b40c712df992d781a76ff75c3e2c65e07bc
Author: Tiziano Müller <tiziano.mueller@stepping-stone.ch>
Date: Fri Jul 18 09:24:38 2014 +0200
build: add libraries to LIBADD instead of LDFLAGS
For a number of linker flags the order of the object files and the libs
to link against matter (for example -Wl,--as-needed). Make sure that
libraries are added via the LIBADD variable instead of LDFLAGS and
therefore always come after the object files.
Change-Id: I59d114752a0c7664b8678a72082ba5e445497fe5
Signed-off-by: Tiziano Müller <tiziano.mueller@stepping-stone.ch>
Reviewed-on: http://review.gluster.org/8331
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 722e8c9e279e23cd64282ad406490d2b9df9862b
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Jul 12 02:15:14 2014 -0700
fuse: fuse_readlink_cbk() - linkname NULL termination unnecessary
op_ret incremented to compensate for NULL terminating character
leads to self referential loop where OSXFUSE which would reply
on a same READLINK() over and over again
~~~
[2014-07-12 08:41:29.815473]
T [fuse-bridge.c:1372:fuse_readlink_cbk] 0-glusterfs-fuse:
1: /a/b/1 => ../../1
[2014-07-12 08:41:29.815820]
T [fuse-bridge.c:1372:fuse_readlink_cbk] 0-glusterfs-fuse:
0: /a/b/1 => ../../1
[2014-07-12 08:41:29.816165]
T [fuse-bridge.c:1372:fuse_readlink_cbk] 0-glusterfs-fuse:
1: /a/b/1 => ../../1
~~~
It happens due to the problem being (op_ret + 1) > strlen(linkname),
for some odd reason this isn't an issue on Linux where there are odd
safegaurds on these things - Example of following code
~~~
((char *)linkname)[op_ret] = '\0';
send_fuse_data (this, finh, (void *)linkname, op_ret + 2048); <---- Here!
~~~
This behaves normally with no issue, the reasoning i have is that
internally 'readlink()' is verified with strlen() again or perhaps the size
is re-adjusted to the strlen() of `linkname`
This isn't the case on OSX, one needs to make sure that
~~~
strlen(linkname) == op_ret
~~~
Otherwise you would get READLINK() loops as shown above.
This patch fixes the problem.
Many thanks to Anand Avati for helping me out on this.
Change-Id: Ia35818de78a5e4d89bad03ab06e2c5ed6e6753a4
BUG: 1095525
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8300
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4c709ab32cc60f8597a35fa950b42204755f2228
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Jul 16 15:41:05 2014 -0700
porting: extattr_remove_fd() doesn't exist
Fix typo extattr_remove_fd() --> extattr_delete_fd()
Change-Id: I0dc3399722eb272d3c04836726e22b212ef15eba
BUG: 1111774
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8319
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3321628b09fd6032e96963748e19e771b298ba6a
Author: Luis Pabon <lpabon@redhat.com>
Date: Wed Apr 23 16:18:57 2014 -0400
build: Support for unit tests using Cmockery2
This patch will allow for developers to create unit tests for
their code. Documentation has been added to the patch and
is available here:
doc/hacker-guide/en-US/markdown/unittest.md
Also, unit tests are run when RPM is created.
This patch is a replacement for http://review.gluster.org/#/c/7281
which removed unit test infrastucture from the repo due to multiple
conflicts. Cmockery2 is now available in Fedora and EPEL, and soon
to be available in Debian and Ubuntu. For all other operating
systems, please install from the source:
https://github.com/lpabon/cmockery2
BUG: 1067059
Change-Id: I1b36cb1f56fd10916f9bf535e8ad080a3358289f
Signed-off-by: Luis Pabón <lpabon@redhat.com>
Reviewed-on: http://review.gluster.org/7538
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d6ceca44ac16cdae3b590ce998b41ca4a8ac52f9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 9 15:03:16 2014 +0530
features/gfid-access: Print real-gfid in statedump
Change-Id: I1cac8f3ccfcf1fda64ff8470d4f2000d05dcab63
BUG: 1117733
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8271
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9b5448bf802272d82acdc14e8283a12a475039d2
Author: Susant Palai <spalai@redhat.com>
Date: Mon Jun 30 07:01:10 2014 -0400
DHT/mkdir : Fill the stbuf from the subvols on which directory creation was successful.
Problem: In case a mkdir sees EEXIST on a non-hashed subvol it reports
error to the application.
Change-Id: I44b2f32fc1069e609d788b6d25b9366b1460395c
BUG: 1114557
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/8203
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Anders Blomdell <anders.blomdell@control.lth.se>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 288cf235195255cf9e937126b653b2bc8ad9e348
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Jul 16 16:03:00 2014 +0530
protocol/client: Log ENOENT and ENODATA messages to debug.
Change-Id: I6f8ccf1650ff74e46e5a93a6701d4e694118b273
BUG: 1120136
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/8315
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 037811033f1b6f80dc2cf9d30d7d72698d2c8fc5
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue Jul 15 18:17:19 2014 +0530
cluster/dht: Fix races to avoid deletion of linkto file
Explanation of Race between rebalance processes:
https://bugzilla.redhat.com/show_bug.cgi?id=1110694#c4
STATE 1: BRICK-1
only one brick Cached File
in the system
STATE 2:
Add brick-2 BRICK-1 BRICK-2
STATE 3: Lookup of File on brick-2
by this node's rebalance
will fail because hashed
file is not created yet.
So dht_lookup_everywhere is
about to get called.
STATE 4: As part of lookup
link file at brick-2
will be created.
STATE 5: getxattr to check that
cached file belongs to
this node is done
STATE 6:
dht_lookup_everywhere_cbk detects
the link created by rebalance-1.
It will unlink it.
STATE 7: getxattr at the link
file with "pathinfo" key
will be called will fail
as the link file is deleted
by rebalance on node-2
Fix:
So in the STATE 6, we should avoid the deletion of link file. Every time
dht_lookup_everywhere gets called, lookup will be performed on all the nodes.
So to avoid STATE 6, if linkto file is found, it is not deleted until valid
case is found in dht_lookup_everywhere_done.
Case 1: if linkto file points to cached node, and cached file exists,
uwind with success.
Case 2: if linkto does not point to current cached node, and cached file
exists:
a) Unlink stale link file
b) Create new link file
Case 3: Only linkto file exists:
Delete linkto file
Case 4: Only cached file
Create link file (Handled event without patch)
Case 5: Neither cached nor hashed file is present
Return with ENOENT (handled even without patch)
Change-Id: Ibf53671410d8d613b8e2e7e5d0ec30fc7dcc0298
BUG: 1116150
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8231
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 115cb377155d058b25fbc818fe40c5084dbb28d1
Author: Susant Palai <spalai@redhat.com>
Date: Wed Jul 9 09:31:45 2014 -0400
DHT/Create : Failing to identify a linkto file in lookup_everywhere_cbk path
In case a file is not found in its cached subvol we proceed with
dht_lookup_everywhere. But as we dont add the linkto xattr to the
dictionary, we fail to identify any linkto file encountered.The
implication being we end up thinking the linkto file as a regular file
and proceed with the fop.
Change-Id: Iab02dc60e84bb1aeab49182f680c0631c33947e2
BUG: 1117923
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/8277
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e08e5d03e4eebdb4139e285f21b888a042b208ba
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jul 8 21:56:04 2014 -0400
dht: fix rename race
If two clients try to rename the same file at the same time, we
sometimes end up with *no file at all* in either the old or new
location. That's kind of bad. The culprit seems to be some overly
aggressive cleanup code. AFAICT, based on today's study of the code,
the intent of the changed section is to remove any linkfile we might
have created before the actual rename. However, what we're removing
might not be our extra link. If we're racing with another client that's
also doing a rename, it might be the only remaining link to the user's
data. The solution, which is good enough to pass this test but almost
certainly still not complete, is to be more selective about when we do
this unlink. Now, we only do it if we know that, at some point, we did
in fact create the link without error (notably ENOENT on the source or
EEXIST on the destination) ourselves.
Change-Id: I8d8cce150b6f8b372c9fb813c90be58d69f8eb7b
BUG: 1117851
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8269
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e7f5a451297e7e1166e23bff3dcf32875428202b
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jul 17 14:17:17 2014 +0530
glusterd: Correctly reset volinfo->caps during volume create
Change-Id: I012899be08a06d39ea5c9fb98a66acf833d7213f
BUG: 1120589
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/8323
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 86c0b548c94f251f61a123ea239fa001e48cf468
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Jul 14 09:07:19 2014 -0700
porting: use __builtin_ffsll() instead of ffsll()
- NetBSD/Darwin doesn't implement ffsll()
- use Compiler builtin
Change-Id: Iee78b4b81747b0bd3877fd2fcb98746f642ce080
BUG: 764655
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8308
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Justin Clift <justin@gluster.org>
commit 4d653ea16566ee4e2f99a58976eb52476b4f0389
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Jun 4 18:40:00 2014 +0530
libgfapi: Fixed an issue with healing files during glfs_resolve
While resolving any path during the first lookup, libgfapi
should generate and send gfid as well along with the new inode
created to the syncop_lookup(..) so that POSIX translator
can heal the files with missing gfid using the new gfid passed.
This wasn't happening correctly in the current "glfs_resolve_component(..)"
implementation. Fixed the same.
Also have added the changes from http://review.gluster.org/5337 in
libgfapi, which is a fix to unlink the inode on revalidate if entry not found.
In addition to the above, have cleaned up a redundant gfapi log mesage.
Change-Id: I0757dda782d16ba6bdbe7ebdbde9c43381229b0a
BUG: 1116854
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/7976
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8581d03c9043ad03457d0ce4aab1a1c9a8d5be9b
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jul 3 17:13:38 2014 +0530
make snapview-server more compatible with NFS server
* There was no handle based API for listxattr. With this change, glfs_h_getxattrs
also handles the listxattr functionality by checking whether the name is NULL
or not (like posix). But all the gfapi functions for listxattr
(glfs_h_getxattrs AND glfs_listxattr AND glfs_flistxattr) returns the names of
the xattrs in a buffer provided by the caller. But snapview-server has to
return the list of xattrs in a dict itself (similar to posix xlator). But
the buffer just contains the names of the xattrs. So for each xattr, a zero
byte value is set (i.e. "") into the dict and sent back. Translators which
do xattr caching (as of now md-cache which caches selinux and acl related
xattrs) should not cache those xattrs whose value is a zero byte data ("").
So made changes in md-cache to ignore zero byte values.
* NFS server was not linking the inodes to inode table in readdirp. This was
leading to applications getting errors. The below set of operations would
lead to applications getting error
1) ls -l in one of the snaopshots (snapview-server would generate gfids for
each entry on the fly and link the inodes associated with those entries)
2) NFS server upon getting readdirp reply would not link the inodes of the
entries. But it used to generate filehandles for each entry and associate
the gfid of that entry with the filehandle and send it as part of the
reply to nfs client.
3) NFS client would send the filehandle of one of those entries when some
activity is done on it.
4) NFS server would not be able to find the inode for the gfid present in the
filehandle (as the inode was not linked) and would go for hard resolution
by sending a lookup on the gfid by creating a new inode.
5) snapview-client will not able to identify whether the inode is a real inode
existing in the main volume or a virtual inode existing in the snapshots
as there would not be any inode context.
6) Since the gfid upon which lookup is sent is a virtual gfid which is not
present in the disk, lookup would fail and the application would get an
error.
To handle above situation, now nfs server also does inode linking in readdirp.
Change-Id: Ibb191408347b6b5f21cff72319ccee619ea77bcd
BUG: 1115949
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8230
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2d679a442d30520b2d403b775117bb1414797ed2
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jul 15 15:55:34 2014 +0530
mgmt/glusterd: do not check for snapd handle in restore if uss is disabled
Change-Id: I01afe64685a5794cce9265580c6c5de57a045201
BUG: 1119582
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8310
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 1af97ad88d59fff33097b14e726f5ab94751964b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Jul 14 10:48:01 2014 -0400
tests: make dd less noisy
Also fixed one case in quota.t where error output is expected. There
are probably other similar cases which can be fixed separately.
Change-Id: If80fad0d9fcff6f8ca91d00f4f7b2d5f3fef4256
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8298
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e82f265fdb3fc73559df0d33ffa1914481faee25
Author: Anders Blomdell <anders.blomdell@control.lth.se>
Date: Thu Jul 10 20:17:25 2014 +0200
Add possibility to run single tests
Change-Id: I9282b711c09611bd0fd4cc814f3ec34aa67d10c0
BUG: 1118453
Signed-off-by: Anders Blomdell <anders.blomdell@control.lth.se>
Reviewed-on: http://review.gluster.org/8291
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fdf0da6aa9ca02443ad9c9ab81ef72248fedf057
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 15 09:06:58 2014 +0530
glusterd: Improvements to peer identification
This patch improves the peer identification mechanism in glusterd and
lays down the framework for further improvements, including better multi
network support in glusterd.
This patch mainly does two things,
1. Extend the peerinfo object to store a list of addresses instead of a
single hostname as it does now. This also includes changes to make the
peer update behaviour of 'peer probe' to add to the list.
2. Improve glusterd_friend_find_by_hostname() to perform better matching
of hostnames. glusterd_friend_find_by_hostname() now does and initial
quick string compare against all the peer addresses known to glusterd,
after which it tries a more thorough search using address resolution and
matching the struc sockaddr's.
The above two changes together improve the peer identification situation
in glusterd a lot.
More information regarding the problem this patch attempts to resolve
and the approach chosen can be found at
http://www.gluster.org/community/documentation/index.php/Features/Better_peer_identification
This commit is a squashed commit of the following changes, the
development branch of which can be viewed at,
https://github.com/kshlm/glusterfs/tree/better-peer-identification or,
https://forge.gluster.org/~kshlm/glusterfs-core/kshlms-glusterfs/commits/better-peer-identification
commit 198f86e60fab74faf082eaa02657a4d8f60b92f0
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 15 14:34:06 2014 +0530
Update gluster.8
commit 35d597f3a6b3248373e727f7b7e889c92554d56c
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 15 09:01:01 2014 +0530
Address review comments
https://review.gluster.org/#/c/8238/3
commit 47b5331e17304477322bd2daed5bbed503c34ca1
Merge: c71b12c 78128af
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 15 08:41:39 2014 +0530
Merge branch 'master' into better-peer-identification
commit c71b12c164330e8d19d1df4734ab34ef9a8caad2
Merge: 57bc9de 0f5719a
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jul 10 19:50:19 2014 +0530
Merge branch 'master' into better-peer-identification
commit 57bc9de9e4f49ff2b1620df9906cda50a3527a25
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jul 10 19:49:08 2014 +0530
More fixes to review comments
commit 5482cc363a687a9e246a0780ec88acd53e218501
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jul 10 18:36:40 2014 +0530
Code refactoring in peer-utils based on review comments
https://review.gluster.org/#/c/8238/2/xlators/mgmt/glusterd/src/glusterd-peer-utils.c
commit 89b22c34757178f64d5fbaffa31e6302f841c060
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jul 10 12:30:00 2014 +0530
Hostnames in peer status
commit 63ebf9485cf50d736cf640238a1ab241671fcaf1
Merge: c8c8fdd f5f9721
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jul 10 12:06:33 2014 +0530
Merge remote-tracking branch 'origin/master' into better-peer-identification
commit c8c8fdd2104b5b6b8a1af739b1dd952b74e6dd66
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jul 9 18:35:27 2014 +0530
Hostnames in xml output
commit 732a92a0167ad7b1d70edbc35ebd8307c2766ae1
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jul 9 15:12:10 2014 +0530
Add hostnames to cli rsp dict during list-friends
commit fcf43e3e317508f0c225024738a988a4af8e9205
Merge: c0e2624 72d96e2
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jul 9 12:53:03 2014 +0530
Merge branch 'master' into better-peer-identification
commit c0e262416728a3c536a8347a216e471eb2251535
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jul 7 16:11:19 2014 +0530
Use list_for_each_entry_safe when cleaning peer hostnames
commit 6132e60224eb592f3657e535a12a3e72c772da42
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jul 7 15:52:19 2014 +0530
Fix crash in gd_add_friend_to_dict
commit 88ffa9a508fd5aac0b2a76e6e76487ce0cab786a
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jul 7 13:19:44 2014 +0530
gd_peerinfo_destroy -> glusterd_peerinfo_destroy
commit 4b36930a715b1e13cd1a77d136ef1cf78a06d574
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jul 7 12:50:12 2014 +0530
More refactoring
commit ee559b081d608c6501c10ae22166f26eeb65690e
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jul 7 12:14:40 2014 +0530
Major refactoring of code based on review comments at
https://review.gluster.org/#/c/8238/1/xlators/mgmt/glusterd/src/glusterd-peer-utils.h
commit e96dbc7bbb05fad2a9c424de41a394b8023fe48d
Merge: 2613d1d 83c09b7
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jul 7 09:47:05 2014 +0530
Merge remote-tracking branch 'origin/master' into better-peer-identification
commit 2613d1daebff0c56812de821c06ed4c16bb9d447
Merge: b242cf6 9a50211
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Jul 4 15:28:57 2014 +0530
Merge remote-tracking branch 'origin/master' into better-peer-identification
commit b242cf66d95dd3dd5e3975aa430baa6bd74b8a29
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Jul 4 15:08:18 2014 +0530
Fix a silly mistake, if (ctx->req) => if (ctx->req == NULL)
commit c835ed26433830ceed57289143f596cf60421558
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Jul 4 14:58:23 2014 +0530
Fix reverse probe.
commit 9ede17f9329b854b02e8ad159f173244789fd08c
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Jul 4 13:31:32 2014 +0530
Fix friend import for existing peers
commit 891bf74c7350064dfb008d1b7294bcec28d680fd
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Jul 4 13:08:36 2014 +0530
Set first hostname in peerinfo->hostnames to peerinfo->hostname
commit 9421d6a217381a7427a7d84f369280883ca4297a
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Jul 4 12:21:40 2014 +0530
Fix gf_asprintf return val check in glusterd_store_peer_write
commit defac978c1d94011ce8195e311839b9ffce057e7
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Jul 4 11:16:13 2014 +0530
Fix store_retrieve_peers to correctly cleanup.
commit 00a799f5de1121b0cb7421da8285f9407063e1bd
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Jul 4 10:52:11 2014 +0530
Update address list in glusterd_probe_cbk only when needed.
commit 7a628e8a9c562d85709c69cfa13fb1774c521b75
Merge: d191985 dc46d5e
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Jul 4 09:24:12 2014 +0530
Merge remote-tracking branch 'origin/master' into better-peer-identification
commit d1919858e6639d2b54d716a61f662d9752ec5ff1
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 1 18:59:49 2014 +0530
gf_compare_addrinfo -> gf_compare_sockaddr
commit 31d8ef730d408f8d9ba8f504fa648f7dcd59da87
Merge: 93bbede 86ee233
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 1 18:16:13 2014 +0530
Merge remote-tracking branch 'origin/master' into better-peer-identification
commit 93bbedeac5181e29f59b2acd08f638146812ec41
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 1 18:15:16 2014 +0530
Improve glusterd_friend_find_by_hostname
glusterd_friend_find_by_hostname will now do an initial quick search for
the peerinfo performing string comparisions on the given host string. It
follows it with a more thorough match, by resolving the addresses and
comparing addrinfos instead of strings.
commit 2542cdbc45aa9cfcaf1f174686158d5565cdd07b
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 1 17:21:10 2014 +0530
New utility gf_compare_addrinfo
commit 338676e8389a44bd91136eebd110197429c2566c
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 1 14:55:56 2014 +0530
Use gd_peer_has_address instead of strcmp
commit 28d45be51f594328741c44455bd80ac9d64ca501
Merge: 728266e 991dd5e
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 1 14:54:40 2014 +0530
Merge branch 'master' into better-peer-identification
commit 728266eb16d5f5a4bf36266044425ae164337f99
Merge: 7d9b87b 2417de9
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jul 1 09:55:13 2014 +0530
Merge remote-tracking branch 'origin/master' into better-peer-identification
commit 7d9b87b84955ec17daeaf88a3e7462914039430f
Merge: b890625 e02275c
Author: Kaushal M <kshlmster@gmail.com>
Date: Tue Jul 1 08:41:40 2014 +0530
Merge pull request #4 from vpshastry/better-peer-identification
Better peer identification
commit e02275c52fb83c72ad082c098fd3e432c2b9c526
Merge: 75ee90d b890625
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Jun 30 16:44:29 2014 +0530
Merge branch 'better-peer-identification' of https://github.com/kshlm/glusterfs into better-peer-identification-kaushal-github
commit 75ee90d2f272e49b94d24c9ca4571e89a83055ff
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Jun 30 15:36:10 2014 +0530
glusterd: add to the list if the probed uuid pre-exists
Signed-off-by: Varun Shastry <vshastry@redhat.com>
commit b890625d8164c660695daef3285c67979eef723e
Merge: 04c5d60 187a7a9
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jun 30 11:44:13 2014 +0530
Merge remote-tracking branch 'origin/master' into better-peer-identification
commit 04c5d60cb938c8d94b214689580b40abb1b0ffcd
Merge: 3a5bfa1 e01edb6
Author: Kaushal M <kshlmster@gmail.com>
Date: Sat Jun 28 19:23:33 2014 +0530
Merge pull request #3 from vpshastry/better-peer-identification
glusterd: search through the list of hostnames in the peerinfo
commit 0c64f3346a977f9165ac55a84a1e03c40a7573a7
Merge: e01edb6 3a5bfa1
Author: Varun Shastry <vshastry@redhat.com>
Date: Sat Jun 28 10:43:29 2014 +0530
Merge branch 'better-peer-identification' of https://github.com/kshlm/glusterfs into better-peer-identification-kaushal-github
commit e01edb63153a1008db70b8fa76ae5b535e099326
Author: Varun Shastry <vshastry@redhat.com>
Date: Fri Jun 27 12:29:36 2014 +0530
glusterd: search through the list of hostnames in the peerinfo
Signed-off-by: Varun Shastry <vshastry@redhat.com>
commit 3a5bfa15855e660db2bfde644727371dd2d618cc
Merge: cda6d31 371ea35
Author: Kaushal M <kshlmster@gmail.com>
Date: Fri Jun 27 11:31:17 2014 +0530
Merge pull request #1 from vpshastry/better-peer-identification
glusterd: Add hostname to list instead of replaceing upon update
commit 371ea354f198b4182382d5403c5960c0b2add6b6
Author: Varun Shastry <vshastry@redhat.com>
Date: Fri Jun 27 11:24:54 2014 +0530
glusterd: Add hostname to list instead of replaceing upon update
Signed-off-by: Varun Shastry <vshastry@redhat.com>
commit cda6d3152886623ecbf46baf0048ebe0119b30b6
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jun 26 19:52:52 2014 +0530
Import address lists
commit 6649b54aa0440130c08e827e0a1d1bbfb840eca9
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jun 26 19:15:37 2014 +0530
Implement export address list
commit 55990034eead92bc9b936240029e460a4bf152d5
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jun 26 18:11:59 2014 +0530
Use first address in list to when setting up the peer RPC.
commit a35fde8d19b9988eb04c652fb3a5e4f84d90ad00
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jun 26 18:03:04 2014 +0530
Properly free addresses on glusterd_peer_destroy
commit 1988081db09ac9205f3dc7268cef8be267f3ce8b
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jun 26 17:52:35 2014 +0530
Restore peerinfo with address list implemented.
commit 66f524d5749a12f4910dd6b06c9d91f37e1d831e
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jun 23 13:02:23 2014 +0530
Move out all peer related utilities from glusterd-utils to glusterd-peer-utils
commit 14a2a326a4dff11b55490dca2a14f39320931340
Author: Kaushal M <kaushal@redhat.com>
Date: Tue May 27 12:16:41 2014 +0530
Compilation fix
commit c59cd351d0a102d0d5f3ea9001fd33c4edcb262f
Author: Kaushal M <kaushal@redhat.com>
Date: Mon May 5 12:51:11 2014 +0530
Add store support for hostname list
commit b70325f0beb884ad12645ef40185f0bf6cedd741
Author: Kaushal M <kaushal@redhat.com>
Date: Fri May 2 15:58:07 2014 +0530
Add a hostnames list to glusterd_peerinfo_t
glusterd_peerinfo_new will now init this list and add the given hostname
as the lists first member.
Signed-off-by: Kaushal M <kaushal@redhat.com>
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Change-Id: Ief3c5d6d6f16571ee2fab0a45e638b9d6506a06e
BUG: 1119547
Reviewed-on: http://review.gluster.org/8238
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 603d4b67643956a819439de04d3837a2ceff10c1
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Wed Jul 9 01:22:54 2014 +0530
compress: Change variable name
'writen' and 'total_writen' variables has been defined in compress
xlator. This patch replaced those with proper name.
Change-Id: If8e38fae8f997a92686a891d64cbaf6b0b69129a
BUG: 1075417
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8268
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit c7d37d027556af12e6ec18d19f4994ba715f5d08
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue Feb 25 17:28:10 2014 +0530
cli: Changed "rebalance start" output
Change-Id: Ie87f1a2107b07a6e519ed894a74edf3b3e0a8340
BUG: 1063230
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/6946
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 72fb482fcf80a144badf28463248bd7493c9f236
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Jul 7 14:36:18 2014 +0530
glusterd: Fix for resource leak coverity bug 1223045.
Change-Id: I96261e7f5cd7b5550d3100750c80190dd932a8ab
BUG: 789278
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/8252
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 54833d87a6a07ff18fba7d0643208f7809b7734c
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Thu May 29 11:04:56 2014 +0530
gfapi : remove gfapi.py to avoid confusion
python binding of libgfapi is evolving via libgfapi-python
project. The example available here confuses end users,
so removing it from this path.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Bug Id: 1119328
> Reviewed-on: http://review.gluster.org/7920
> Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
> Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
> Reviewed-by: Thiago da Silva <thiago@redhat.com>
> Reviewed-by: Prashanth Pai <ppai@redhat.com>
> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Change-Id: I17b3aa0f0505342496019ce012cca21d84184027
Reviewed-on: http://review.gluster.org/8237
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 535c6c773dc93e896ed0a9e9982adf521b9672a6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 8 16:42:02 2014 +0530
cluster/afr: Fix dirent leak
afr does itransform by taking the list of entries given by client xlator
to separate list but doesn't free that list.
Change-Id: Ibb4d38b4934b2bb924385c88f9d7942fad933cb9
BUG: 1117243
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8261
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit 4dc7281075d028fb42c0a618fa96231d77c01512
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Thu Jun 19 16:51:57 2014 +0530
Autoload fuse module in centos5/el5 versions.
This patch dynamically load 'fuse' module with the installation
of glusterfs-fuse package in centos/el5 distributions.
Change-Id: I4988a025bd18716fd6d355431196540e140224b3
BUG: 1108669
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8116
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 52a3e62853651de8ee21e5de3b4bbf90a899fae3
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Wed Jul 9 01:14:58 2014 +0530
changelog: variable 'writen' is changed
This patch change the variable name to 'written' in changelog, along
with few other typo fixing.
Change-Id: I1d3cbea5c89fc0a15233bb6e61b4fbd4bfdd3a67
BUG: 1075417
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/8267
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 8cca44a6db6b0cc65a5c91a0617f6afebd510b3d
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jul 9 18:36:18 2014 +0530
test: utility to create files with a specific gfid
python test utility that uses setxattr() interface to
create files with a predefined gfid (which is also used
by geo-replication). this utility aids in writing test
cases for gfid-access translator.
Change-Id: Ib11248844a094cc02dae74d969f2e9212f94ede4
BUG: 1111490
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/8275
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4309644974daf48a5c05095e3d5641405edf7430
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Jul 10 05:45:52 2014 +0200
Regression test portability: dd usage
NetBSD, FreeBSD, and MacOS X dd(1) bs argument uses m for megabyte, while
Linux uses M. Use bs=1024k instead of bs=1M for better compatibility.
BUG: 764655
Change-Id: I603f57adbc9b31f6d634b918726437fbfce42e03
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/8278
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Justin Clift <justin@gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8a156f3c0429c485baa12bd9025e6d8f42af6e1e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 14 12:49:58 2014 +0530
protocol/server: Add extra space between words
Change-Id: Id658db992a43202602e0c30d2c8ca639c4aeadd6
BUG: 1119167
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8304
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 9071413fe573d6cd0162f7ad7c0c5f02d35dd3f0
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jul 8 13:05:15 2014 +0530
features/gfid-access: error handling for entry creation
Proceed with setattr() only on a successfull entry creation.
Winding a setattr() using a freshlyOC initiated inode would
most likely fail in one translator or the other (e.g. DHT
expecting the layout information to be set in the inode
context), which is the case if the inode was not looked up.
Therefore, gfid-access handles failure entry creations and
passes the _correct_ errno back to the client instead of
continuing with setattr() call and probably returning back
incorrect errno. Also, filling up inode->gfid is required
as the new inode is not looked up and ->gfid would be
certainely required for inode operations.
Change-Id: Ie92f5647a89bf558c07710ab0400bce69d59fc31
BUG: 1111490
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/8260
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 83fa3c9455ed5c2a3bec065f5883aeaa8b298453
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jul 9 09:40:42 2014 +0000
glusterd/snapshot: Update fstype for local bricks only
While creating snapshot, update fstype for local bricks only
and not for bricks hosted on other nodes
Also returning ret as 0, in case no cleanup is required in
post-validation, so that a post-validation failure is not
logged, every time a pre-validation failure happens.
Change-Id: I6364e33cfd9528e0a988ee48f3443239ee884336
BUG: 1111060
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/8272
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c5a2f09bdfe96ed3a36f8bae9ec201f36917f3cc
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Mon May 5 13:37:34 2014 +0530
cli/snapshot: provide --xml support for all snapshot command
Now --xml option can be used with all snapshot command. It
will form the cli output in xml form.
Change-Id: Ifc0ac31d2a9f91e136e87f3b51a629df7dba94e8
BUG: 1096610
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/7663
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6f6c1ed23eb085f4f77ca4f74ecdfc14f37d4a7d
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jun 17 13:42:45 2014 +0000
dht: support heterogeneous brick sizes
Calculation of layouts now considers the size of each brick, so that
smaller bricks don't get an "unfair" share of allocations and start
returning ENOSPC while the larger bricks still have plenty of space.
The observation has been made that some clients might get ENOTCONN when
trying to fetch disk-size information, and end up calculating layouts
differently. The following meta-observations can be made.
(1) This scenario is extremely unlikely in configurations with AFR.
(2) The most likely consequence of this scenario is that some files will
be placed sub-optimally by the client with the obsolete (non-weighted)
layout. They'll still be found anyway, so this isn't a show stopper.
(3) Without this patch it's *guaranteed* that some files will be placed
sub-optimally, because any layout that fails to account for brick sizes
is sub-optimal.
(4) We shouldn't be doing fix-layout from two nodes simultaneously
anyway. That's inefficient at best. Any instances of such behavior are
separate bugs, which should be fixed separately.
(5) In the most extreme edge case, two nodes doing weighted and
non-weighted layout fixes could race and end up creating an internally
inconsistent layout. This condition is still transient; it will be
detected and repaired automatically the next time anyone fetches the
layout. (If it's not that's also a preexisting bug that can show up in
other contexts.)
In conclusion, it's not the purpose of this patch to fix bugs elsewhere
in DHT. Its purpose is to make life incrementally better for users who
add new hardware with larger disks etc. than the older equipment. It's
only one part of an ongoing process to improve layout management and
repair, all the way up to support for multiple hash rings or tiering.
Change-Id: I05eb6f9eface9cdaf8622e0260c8c7f29020447f
BUG: 1114680
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8093
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 745577c662425f52b4f46af2f53d2958d1165b1e
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Mon Jul 7 16:17:05 2014 +0530
DHT/Logging Changed the log level of a message from none to debug as none does not print a log level in the log file.
Change-Id: I463d1095d69bbd0036958282da13cb8e0226f34f
BUG: 1116797
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/8253
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4207e8ed8a9c1eaca1d6dc5c549b2f98578477ff
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu May 15 10:35:14 2014 +0200
cli/glusterd: Added support for dispersed volumes
Two new options have been added to the 'create' command of the cli
interface:
disperse [<count>] redundancy <count>
Both are optional. A dispersed volume is created by specifying, at
least, one of them. If 'disperse' is missing or it's present but
'<count>' does not, the number of bricks enumerated in the command
line is taken as the disperse count.
If 'redundancy' is missing, the lowest optimal value is assumed. A
configuration is considered optimal (for most workloads) when the
disperse count - redundancy count is a power of 2. If the resulting
redundancy is 1, the volume is created normally, but if it's greater
than 1, a warning is shown to the user and he/she must answer yes/no
to continue volume creation. If there isn't any optimal value for
the given number of bricks, a warning is also shown and, if the user
accepts, a redundancy of 1 is used.
If 'redundancy' is specified and the resulting volume is not optimal,
another warning is shown to the user.
A distributed-disperse volume can be created using a number of bricks
multiple of the disperse count.
Change-Id: Iab93efbe78e905cdb91f54f3741599f7ea6645e4
BUG: 1118629
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/7782
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 51d6d09374172d899824a144ee1d8c41f5dcc175
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Mon May 5 12:57:34 2014 +0200
cluster/ec: Added erasure code translator
Change-Id: I293917501d5c2ca4cdc6303df30cf0b568cea361
BUG: 1118629
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/7749
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 877ff215cf2ed4d535561b80f6abc49eb482fda2
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu Jul 10 10:19:06 2014 +0200
tests: Fixed spurious failure in bug-887098-gmount-crash.t
This script was trying to see if the mount process died by doing a
'ps ax' and a grep of the original pid in the results. After that
the pid of the first line returned by grep was compared to the
original pid.
This method can lead to false negatives because it's possible that
the original pid appears in some other part of the 'ps ax' list.
This patch uses get_mount_process_pid() from volume.rc to check if
the process is still alive.
Change-Id: I0285366e601a146793c47e9c1156a4bb36d6fcb3
BUG: 1092850
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/8286
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c2528ac24eb13b410398da3d32fb522997b6ff54
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jun 18 23:36:48 2014 +0530
features/changelog: prevent deadlock on thread cancellation
helper threads (fsync, rollover) wake up periodically and perform
their respective operation under a lock (crt->lock). These threads
are also subjected to cancellation under some circumstance such as
disabling changelog. This is inherently dangerous when funtions
which are cancellation points for pthread_cancel(3) are used
in the locked region.
Consider this
pthread_mutex_lock(&mutex);
{
/* ... */
ret = fsync (fd); <-- cancellation point
/* ... */
}
pthread_mutex_unlock(&mutex);
A pthread_cancel(3) by another thread just before fsync(3) but
after pthread_mutex_lock(3) would result in the thread getting
cancelled when fsync(3) is invoked, thereby never unlocking the
mutex. Moreover, in case of changelog translator, the locked
region (under crt->lock in changelog-rt.c) is also the code
path for fop changelog updation. Therefore, unlocking the
mutex in thread cleanup handler (pthread_cleanup_pop(3)) might
prematurely release the mutex during fop updation path.
This patch fixes such problems existing in fsync and rollover
threads. Fix is to enter the locked region with cancellation
disabled and enable it after mutex unlock. Also, test for a
cancellation request early on in case none of the functions
are cancellation points.
Change-Id: I1795627a12827609c1da659d07fc1457ffa033de
BUG: 1110917
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/8106
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 500091caaa1fda1126908f7aa5e5a615e7764995
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Jul 8 13:06:04 2014 +0530
glusterd/regression: Temp fix for spurious err
As discussed in the mail,
Disabling the checking of snap brick status until
the investigation is done on the port bind issue.
Change-Id: I8854cee050de1b7f843e3d40631b6cb61fd8583e
BUG: 1112559
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/8259
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a4c16e0695b289ecf0f4c661907203d064a618a1
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jul 3 14:01:20 2014 +0000
socket/glusterd/client: enable SSL for management
The feature is controlled by presence of the following file:
/var/lib/glusterd/secure-access
See the comment near the definition of SECURE_ACCESS_FILE in glusterfs.h
for the rationale. With this enabled, the following rules apply to
connections:
UNIX-domain sockets never have SSL.
Management-port sockets (both connecting and accepting, in
daemons and CLI) have SSL based on presence of the file.
Other IP sockets have SSL based on the existing client.ssl and
server.ssl volume options.
Transport multi-threading is explicitly turned off in glusterd (it would
otherwise be turned on when SSL is) due to multi-threading issues.
Tests have been elided to avoid risk of leaving a file which will cause
all subsequent tests to run with management SSL still enabled.
IMPLEMENTATION NOTE
The implementation is a bit messy, and consists of two stages. First we
decide whether to set the relevant fields in our context structure, based
on presence of the sentinel file OR a command-line override. Later we
decide whether a particular connection should actually use SSL, based on the
context flags plus what kind of connection we're making[1] and what kind of
daemon we're in[2].
[1] inbound, outbound to glusterd port, other outbound
[2] glusterd, glusterfsd, other
TESTING NOTE
Instead of just running one special test for this feature, the ideal
would be to run all tests with management SSL enabled. However, it
would be inappropriate or premature to set up an optional feature in the
patch itself. Therefore, the method of choice is to submit a separate
patch on top, which modifies "cleanup" in include.rc to recreate the
secure-access file and associated SSL certificate/key files before each
test.
Change-Id: I0e04d6d08163893e24ec8c031748c5c447d7f780
BUG: 1114604
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8094
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 50783a74c9e9563c045a2a37ec37a522795b2994
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Tue Jul 8 10:03:56 2014 +0530
Gluster/Doc : Updated admin guide diagrams
Updated the diagrams for the sections on setting up
distributed replicated volumes and striped replicated volumes
Change-Id: I44ecd2aba75816fdb2f6324c4337cf5fb621ecae
BUG: 1113842
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/8256
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ac95eecf6bbd4b884dae395305a06671a647059d
Author: Meghana Madhusudhan <mmadhusu@redhat.com>
Date: Sun Jul 6 17:30:50 2014 +0530
Changing the position of nfs-ganesha.log
Changing the position of ganesha.log from /tmp/ganesha.log
to /var/log/nfs-ganesha/ganesha.nfsd.log
Change-Id: Iff95fbc7fc690f4fdbc1789d84f3e41aaca9045b
BUG: 1116723
Signed-off-by: Meghana Madhusudhan <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/8249
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 38184d06a8889975028d62e7fb6e7fa9d74e2cbb
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Jun 30 21:50:14 2014 +0000
libgfapi: succeed lookup of "/.."
For the root dir, ".." should resolve to itself.
i.e. when
glfs_h_lookupat (fs, NULL, "/..", &stat)
(or)
glfs_h_lookupat (fs, root, "..", &stat)
is performed, stat must contain root dir's information.
Change-Id: I1c92091cdc4ff00e6b17e5fa349009c6dfc441c1
BUG: 1114814
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/8207
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 3519df6382c4fab1083e3b8793efb57cff0c6ab3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 8 21:57:09 2014 +0530
tests: Print EXPECT style error messages rather than 'not ok'
Change-Id: Ib23426c5ede0ab71387a6a112b313aa448b872cd
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8263
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f812ddf12e43991dac746c04ae02e8b73e7d2306
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Jul 8 08:18:27 2014 +0530
rpc: Do not reset @ping_started to 0 in ping callback
This is to avoid indefinite recursion of the following kind, that could
lead to a stack overflow:
rpc_clnt_start_ping() -> rpc_clnt_ping() -> rpc_clnt_submit() ->
rpc_clnt_start_ping() -> rpc_clnt_ping() -> rpc_clnt_submit() ...
and so on,
since it is possible that before rpc_clnt_start_ping() is called a
second time by the thread executing this codepath, the response to
previous ping request could ALWAYS come by and cause epoll thread to
reset conn->ping_started to 0.
This patch also fixes the issue of excessive ping traffic, which was
due to the client sending one ping rpc for every fop in the worst case.
Also removed dead code in glusterd.
Change-Id: I7c5e6ae3b1c9d23407c0a12a319bdcb43ba7a359
BUG: 1116243
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8257
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c7d53eabd7c3d0cfca3cf0841ded5c37cf4eae1d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Jul 5 12:19:28 2014 +0530
client_t: Fix memory leaks
- Assign frame->root->client so that gf_client_unref happens
in server_connection_cleanup_flush_cbk
- Avoid taking extra ref in gf_client_get
TODO:
The whole reason why there are two types of refs
bind, ref-count is to avoid lock inside lock which
is not the case now. I will be sending one more patch
which will accomplish that as well as changing the
tablearray to list
Change-Id: Ic9971cf248c5ee2cdbfdef8e9ff6d54e3ec60ced
BUG: 1116672
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8247
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a02d3c6ad74269d43026a3e8a0d2de2eb5058184
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jun 20 12:59:43 2014 +0530
geo-rep: Avoid duplicate stat in xsync changelog processing
When A file/dir is identified for metadata sync, it was doing
duplicate stat to get the metadata to sync.
With this patch it avoids doing one additional stat call. Xsync
performance will improve.
rsync will copy files metadata, so no need to include for
processing.
BUG: 1111490
Change-Id: I79dad6375fa4742d9aaca7d9856993c184a744dc
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/8124
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit b0b7e4e8a38c8b05729758bbd4129bafa1ce00cb
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed May 28 18:36:34 2014 +0200
tests/rpm.t: delete the working directory in case it exists
Change-Id: Iea15d296e22a36b119f04aff61a975811054c20b
BUG: 1092850
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7916
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 70d49758071213201f537cb0ee03c2ee7b1ab557
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Jul 5 11:44:30 2014 +0200
nfs: prevent assertion error with MOUNT over UDP
The MOUNT service over UDP runs in a separate thread. This thread does
not have the correct *THIS xlator set. *THIS points to the global (base)
xlator structure, but GF_CALLOC() requires it to be the NFS-xlator so
that assertions can get validated correctly.
This is solved by passing the NFS-xlator to the pthread function, and
setting the *THIS pointer explicitly in the new thread.
It seems that on occasion (needs further investigation) MOUNT over UDP
does not unregister itself. There can also be issues when the kernel NLM
implementation has been registered at portmap/rpcbind, so adding some
unregister procedures in the cleanup of the test-cases.
Change-Id: I3be5a420fc800bbcc14198d0b6faf4cf2c7300b1
BUG: 1116503
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8241
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e40cd1d81cabd62051763ed79d4bce18b95d22be
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Jun 28 04:40:05 2014 +0530
Changes in statedump for stack, frame, locks
Internal call-stacks don't have lk-owner so it is a bit
difficult to confirm if a stack hung by comparing two
statedump files. This change prints call-stack, frame's
address. This should solve the comparison problem.
Lock times and log times don't have same timezone because
of which one has to manually convert the times for debugging
the issues. This change prints blocked, granted times also
in UTC.
Also fixed line truncation issue when client-unique-string
is big.
Change-Id: I116372c0d63476823a36ca6dbfba91648f9234cc
BUG: 1114188
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8197
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ee80ba7e3e0f86a8d868af5bc32c73903cd61322
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Jul 5 07:09:00 2014 +0530
statedump: Don't print mem-type numbers
Change-Id: I381bfa9535fe60c37758761d34b98dbbc4e5f569
BUG: 1114188
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8239
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Justin Clift <justin@gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7bb349b02512b3c0c93e869268649cc098a7767b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jul 3 06:50:56 2014 +0530
features/gfid-access: Fix entry operations
Problem:
When more than one aux-mounts are performing rmdir .gfid/<pargfid>/dir
simultaneously, then sometimes a hang is observed. In gfid-access xlator When
virtual parent/inode are replaced with real parent/inode in loc, virtual
pargfid/gfid are not replaced with real pargfid/gfid respectively. Afr is using
parent_loc->gfids to order the entry locks. But parent_loc->gfid contains
random/virtual gfid generated by gfid-access xlator. Entrylk in client xlator
is using loc->inod->gfid for sending entrylk which has 'real' gfid. Because the
ordering is happening based on random gfids, One mount orders the locks as (L1,
L2) where as the other orders them as (L2, L1) leading to a dead-lock thus
a hang.
Fix:
Replace virtual pargfid/gfid with real pargfid/gfid when virtual-inodes are
replaced with real-inodes in loc.
BUG: 1114501
Change-Id: Ie94e816122ef9e7aad51605adbf49291de60827e
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8204
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 8c51e5a1bc4023c2f9ee7aac9ecb53fa9be7ad61
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jul 3 13:27:13 2014 +0000
socket: add certificate-depth and cipher-list options for SSL
Change-Id: I82757f8461807301a4a4f28c4f5bf7f0ee315113
BUG: 1114604
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8040
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 42e9eece2ab2de093082fea914775be45696f12d
Author: Joseph Fernandes <josferna@redhat.com>
Date: Mon Jun 30 08:07:36 2014 +0530
glusterd/snapshot: fixing glusterd quorum during snap operation
During a snapshot operation, glusterd quorum will be checked only
on transaction peers, which are selected in the begin of the
operation, and not on the entire peer list which is susceptible
for change for any peer attach operation.
Change-Id: I089e3262cb45bc1ea4a3cef48408a9039d3fbdb9
BUG: 1114403
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/8200
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit 3d5229b0bfe0840aaba79a447f3329142212f028
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Thu Jul 3 19:46:59 2014 +0530
cluster/dht: Added logging of new layout for dir-selfheal
Added a log which logs the new layout which will be used
for the directory self healing
It prints:
a) Subvolume name
b) Error --> Is needed because layout healing depends on
the error and having it in log will help in
debugging
c) Start Starting of the layout range
d) Stop Ending of the layout range
Change-Id: I48c9c697716a899165ed29b737362a75c62e09b3
BUG: 1113066
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8173
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e4e7b433e5c6b1b4b089c2e914dd70be5c3a747b
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue Jul 1 20:25:04 2014 +0530
glusterd/snapshot: Change file-system uuid to file-system label
Problem: In XFS changing file-system UUID with xfs_admin is causing
too much delay with large file-system. The time taken by xfs_admin
tool to change UUID is directly proportional to the size of the file
system.
Cause: In XFS file-system UUID is stored in file-system superblock.
Therefore for chaning UUID all the superblock needs to be changed.
Fix: Instead of using file-system UUID use file-system label.
Change-Id: Ifb4c668fb29cfc1c89d9b221abc8d09dc09589ec
BUG: 1115107
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/8215
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit b9315a91ea10d6b71d84a70ced62cf87f0fbc8f2
Author: Jose Castillo <jcastillo@redhat.com>
Date: Tue Jul 1 15:51:07 2014 +0200
Avoid hard-coded x86_64 arch in tests/basic/rpm.t
tests/basic/rpm.t hard-codes x86_64 to pick the build-root for mock, causing
errors when called from a different architecture. With this patch, we use
'uname -i' to select the right architecture.
v2: Fixed typo as suggested by Justin Clift.
Change-Id: I07bc2af9317dc315bca460149ea3430071537780
BUG: 962169
Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Reviewed-on: http://review.gluster.org/8214
Reviewed-by: Vikhyat Umrao <vumrao@redhat.com>
Reviewed-by: Justin Clift <justin@gluster.org>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 48c9e05c52b5fbd61f7e83e711f48947165ddb72
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Jul 1 19:03:52 2014 -0700
porting: Enable 64bit inode properly on Darwin
Usage of -D__DARWIN_64_BIT_INO_T was wrong, use
-D_DARWIN_USE_64_BIT_INODE instead
Change-Id: I4b532232d0a61fe30f08c41ffeba50fff4ecd79e
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8219
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 8b640c6a11521db0ef98e8de8b750c549c600a94
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Jul 1 16:08:40 2014 -0700
porting: Provide fallocate and fremovexattr for OSX
Change-Id: I563216f83edaff6d01a251ef0c1746a14aec700c
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8217
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit f456fa84da0e6ecafb0f6428fae75c934c2058d9
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Jun 21 02:00:23 2014 -0700
porting: Port for FreeBSD rebased from Mike Ma's efforts
- Provides a working Gluster Management Daemon, CLI
- Provides a working GlusterFS server, GlusterNFS server
- Provides a working GlusterFS client
- execinfo port from FreeBSD is moved into ./contrib/libexecinfo
for ease of portability on NetBSD. (FreeBSD 10 and OSX provide
execinfo natively)
- More portability cleanups for Darwin, FreeBSD and NetBSD
- Provides a new rc script for FreeBSD
Change-Id: I8dff336f97479ca5a7f9b8c6b730051c0f8ac46f
BUG: 1111774
Original-Author: Mike Ma <mikemandarine@gmail.com>
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8141
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 838da96ab0c2e0861d7e38e19fa4518b905b79d9
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jun 26 16:52:36 2014 -0400
libglusterfs/client_t: cliententries are never expanded
clienttable->cliententries are never expanded once all the available
entries have been used.
Also removed a couple chatty log messages.
Change-Id: Iff2d92fe1116cc6c6b72ff3d173aee26e69780ed
BUG: 1113745
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/8184
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 47b67dc03eaaff7e13dba4bb2db9917e86f6153c
Author: Vikhyat Umrao <vumrao@redhat.com>
Date: Tue Jun 3 19:15:42 2014 +0530
build: glusterfs.spec.in, adding nfs-utils package dependency for server package
nfs-utils provides rpc.statd and it is a requirement for gluster-nfs
Change-Id: I054b7d6d8fb1efe0fed9c90077a93c4f559c1ef4
BUG: 1065654
Reported-by: Satheesaran Sundaramoorthi <sasundar@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
Reviewed-on: http://review.gluster.org/7966
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 46ef748b05efd651f0aca840566afdd1727d8f5b
Author: Vijaikumar M <vmallika@redhat.com>
Date: Fri Jun 20 15:40:46 2014 +0530
cli: Format the hostname column properly in the 'pool list' o/p
In the pool list output, if the hostname is lengthier, then the indentation was not proper.
Solution:
1) get the full list of hostnames first (prior to display)
2) Determine the maximum length of the hostname strings from that
3) Create an appropriate display padding amount, using the length from (2)
Change-Id: Icc3724975a5e30b02b8e06db709930cbac5e0875
BUG: 1028871
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/8127
Tested-by: Justin Clift <justin@gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit abe61bbd04f742bc8afaddfaf81edf69a3fb0750
Author: Sachin Pandit <spandit@redhat.com>
Date: Wed Jun 25 03:57:42 2014 +0530
TESTS : replace "umount" with "force_umount" giving 5 retries.
Change-Id: I89dd87b9843273c57843bb28706f284e32debc48
BUG: 1092850
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8167
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fd7011f9b8409194732c622429ae8006a33f417e
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Apr 17 23:21:05 2014 +0000
rpc/auth: allow SSL identity to be used for authorization
Access to a volume is now controlled by the following options, based on
whether SSL is enabled or not.
* server.ssl-allow: get identity from certificate, no password needed
* auth.allow: get identity and matching password from command line
It is not possible to allow both simultaneously, since the connection
itself is either using SSL or it isn't.
Change-Id: I5a5be66520f56778563d62f4b3ab35c66cc41ac0
BUG: 1114604
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/3695
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8f1138c496e659b62bddd151bd796ddd7dcc3069
Author: Joseph Fernandes <josferna@redhat.com>
Date: Wed May 28 13:56:04 2014 +0530
glusterd/snapshot : Fix for snap create preval for remote peer err msg
Fix for the snap create prevalidation error collation when remote peer failed.
Change-Id: If9563580eae4d9bc4d4d795f0b434f2c85b94007
BUG: 1101993
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/7899
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 4d42d92aac5766818f3d7bd7237c97fb97039e3a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jun 26 17:14:39 2014 -0400
build/glusterfs.spec.in: %post server doesn't wait for old glusterd
'killall glusterd' needs to wait for the old glusterd to exit
before starting the updated one, otherwise the new process can't
bind to its socket ports
Change-Id: Ib43c76f232e0ea6f7f8469fb12be7f2b907fb7c8
BUG: 1113543
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/8185
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c32f5bdec5fa3819229c534676e5dc3485aa8999
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jun 30 20:56:58 2014 +0530
performance/md-cache: Guard against null dict
BUG: 1114677
Change-Id: Ica4f4ad97d7d1edc3e48e7f1a6ec70b14acffc66
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8205
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fc0fed2bf4d8c64f32476f7c36691bbc5441c9b1
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jun 27 12:46:34 2014 +0200
Add contact data for the new port maintainers
New port maintainers have been announced. These should be included in
the MAINTAINERS file. Also include some corrections and add missing status
tags.
URL: http://supercolony.gluster.org/pipermail/gluster-devel/2014-June/041223.html
Change-Id: I0729c0ea5fec8a645f18543915c0c0c3fce34329
BUG: 1040351
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8188
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4cdf74beca5fb00de0e3d1d2eb6f30e1a4d517bb
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Jun 26 16:25:59 2014 +0530
geo-rep: History Change detector method select issue
Geo-rep does history crawl even if change-detector is set
to xsync.
This patch fixes by taking priority to user configured
change detector.
BUG: 1113525
Change-Id: Ic6c34e187c9cb6608c9ef8a010ea07015ba60a80
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/8183
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 9e6bcd87a628d7e61d59aae9d8bf453d66ee3885
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jul 1 11:57:19 2014 +0530
mgmt/glusterd: use the right rpc for snapd while getting pending node rpc
* Also changed the testcase bug-1111041.t to correctly get the snapshot
daemon's pid
Change-Id: I22c09a1e61f049f21f1886f8baa5ff421af3f8fa
BUG: 1111041
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8209
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit b06823c6d981d045dbd052839634ba7cf0f1739f
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jun 19 15:51:39 2014 +0530
mgmt/glusterd: display snapd status as part of volume status
* Made changes to save the port used by snapd in the info file for the volume
i.e. <glusterd-working-directory>/vols/<volname>/info
This is how the gluster volume status of a volume would look like for which the
uss feature is enabled.
[root@tatooine ~]# gluster volume status vol
Status of volume: vol
Gluster process Port Online Pid
------------------------------------------------------------------------------
Brick tatooine:/export1/vol 49155 Y 5041
Snapshot Daemon on localhost 49156 Y 5080
NFS Server on localhost 2049 Y 5087
Task Status of Volume vol
------------------------------------------------------------------------------
There are no active volume tasks
Change-Id: I8f3e5d7d764a728497c2a5279a07486317bd7c6d
BUG: 1111041
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8114
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 815e54a4bd411b5e1ea8c3d1bfa41fa7f72449cb
Author: Kotresh H R <khiremat@redhat.com>
Date: Sat Jun 28 12:18:52 2014 +0530
feature/changelog: Fix for missing changelogs at backend.
Problem:
A few changelog files are missing at the backend
during snapshot with changelog enabled.
Cause:
Race between actual rollover and explicit rollover.
Changelog rollover can happen either due to actual
or the explict rollover due to snapshot. Actual
rollover is controlled by tuneable called rollover-time.
The minimum granularity for rollover-time is 1 second
Explicit rollover is asynchronous in nature and happens
during snapshot.
Basically, rollover renames the current CHANGELOG file
to CHANGELOG.TIMESTAMP after rollover-time. Let's assume,
at time 't1', actual and explicit rollover raced against
each other and actual rollover won the race renaming the
CHANGELOG file to CHANGELOG.t1 and opens a new
CHANGELOG file. An immediate explicit rollover at time
't1' happened with in the same second to rename
CHANGELOG file to CHANGELOG.t1 resulting in purging the
earlier CHANGELOG.t1 file created by actual rollover.
Solution:
Adding a delay of 1 sec guarantees unique CHANGELOG.TIMESTAMP
during explicit rollover.
Thanks Venky, for the all the help in root causing the issue.
Change-Id: I8958824e107e16f61be9f09a11d95f8645ecf34d
BUG: 1109692
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8196
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 90329a7aace62a0bf6ef4da73223ba6558013359
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jun 23 12:09:30 2014 +0530
debug/io-stats: Free conf on init failures
Change-Id: I1d227f7b2b8f8ad8d44df8711654ee885e79cf38
BUG: 1111557
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8148
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cbd075eccce62c20f9390048308601e163677055
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jun 27 17:52:25 2014 +0530
geo-rep: Fix the fd leak in worker/agent spawn
worker and agent uses pipe to communicate, if worker dies
for some reason agent should get EOF and terminate.
Each worker-agent spawning is done in thread, Due to race
if multiple workers in same node retain the pipe refs of
other workers. Hence agent will not get EOF even if
worker dies.
BUG: 1114003
Change-Id: I36b9709b9392299483606bd3ef1db764fa3f2bff
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/8194
Tested-by: Justin Clift <justin@gluster.org>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit fb54974589fd834faaff027a71014fb40f152fc4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jun 26 07:15:17 2014 +0530
tests: Trigger dir heal by lookup
Heal full in v2 needs some improvements which Ravi
is working on. Fixed the script to heal based on lookup
from mount until then.
Change-Id: I7b5f8a294019d9f8cfc9c2346d7997f31b4c3d7c
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8178
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c0969193710c104134219623f4a9acccb40d0cdb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jun 26 11:29:19 2014 +0530
quotad: Remove dead code
client_t is created by server xlator for managing connection related
resources. Quotad doesn't do that. So no need to handle anything related
to it.
Change-Id: I83e6f9e1c57458d60529dc62086bb63642932d49
BUG: 1113403
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8180
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cd1fdf794a18e75030f01827a965965bf583bdc6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jun 26 12:55:39 2014 +0530
libglusterfs: Ref root inode only once
Change-Id: I75f309fc1fabb17c392697205b2b5cae6d855e72
BUG: 1113437
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8182
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d312cc4f48648641844738d4b94752548a03d110
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jun 11 10:38:45 2014 +0530
features/gfid-access: Handle loc modification correctly for virtual dirs
Change-Id: I6e3321534dc2f711519b18e8bffb691ab952a8ba
BUG: 1112659
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8163
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b548e9e9bef1b9638257ccdce45ddc58e44b692b
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Jun 27 11:38:57 2014 +0000
glusterd/snapshot: Correct the mount path check
Before removing a lvm, we check if the lvm is mounted
on the brick path. If not, we remove the brick path only.
Correcting this check to support restore cases, where the
volname is not the non-hyphanated uuid, but the original
volume's name.
Change-Id: If158f4651d36efa2f94523458faf826230e9c76a
BUG: 1113975
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/8192
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: Justin Clift <justin@gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c864e3f70ea500736b50cd773ddf05d06327e0c5
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Jun 17 17:37:46 2014 +0530
glusterd : Coverity fix in __server_getspec
spec_fd handle should be closed in all the possible cases
CID : 1124768
Change-Id: I28390dc76a646a19258520570acef562b8d6fb1e
BUG: 789278
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8091
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit e22068578b2bd373f59f5892d1e536ab5e779e6d
Author: Joseph Fernandes <josferna@redhat.com>
Date: Tue Jun 24 14:19:29 2014 +0530
glusterd/snapshot: Fixed errmsg and Quorum check in Snapshot Operation
1) Removing the static message "unbarrier brick opfailed" and log
errors / message in places.
2) Calling the Snapshot Volume Quorum check if the commit
is passed, as the check(which checks the sanity of
glusterds or snapvolume) a successful commit makes more sense.
Change-Id: I7b8f77aa9b2e553893a6ae71bd4b5bbbb60ab8f1
BUG: 1112559
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/8158
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 57c3d2a73def1c7ddc8c7bd240137d171fa2440e
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon May 26 17:18:17 2014 +0530
dht: pass xdata to xlators above.
Change-Id: I96e9feb88443fcd7da40c33c0e8c4e2645b1fcf3
BUG: 1096047
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/7872
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 03df5150c8b9e33d193f80ce6bd5fdea85e9ecce
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Jun 24 15:00:59 2014 -0700
glusterd/snapshot: verify for lvm commands
On non-Linux platforms we need to verify the
run time availability of LVM specific commands
and fail accordingly with a message.
Change-Id: Ie1e3870648f01ee129e390e2240c66e0c6249b90
BUG: 1061685
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8165
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
commit a3082298681e7dd011564dcbc72d01249a122274
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Jun 23 05:11:11 2014 +0530
glusterd/snapshot : Logging the soft-limit reach warning and hard-limit failure.
Change-Id: I5083d30c04c784b7f134b8a919b84c225c25f806
BUG: 1112085
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8147
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit a68f1d3b95bafe2e991134995030711b03ab810a
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sun Jun 22 14:35:23 2014 -0700
tests: attr/xattr.h doesn't exist without libattr-devel fix it
Use sys/xattr.h - glibc provided rather than external libs
Change-Id: Iacf80c1089f11a5a9b46d24e2a62e41fa0c4f5ae
BUG: 1084422
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8146
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: M S Vishwanath Bhat <vbhat@redhat.com>
commit af5cfff2bf64b4818c3c9262a54a0c3e86125ed9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Sun Jun 22 15:20:19 2014 +0530
cluster/stripe: Fix EINVAL errors on quota enabled volumes
Write operations on directories with quota enabled used to fail with
EINVAL on stripe volumes. This was due to assert failure in
stripe_lookup(), meant to ensure loc->path is not NULL. However,
in nameless lookup (in this particular case triggered by quotad, which
has stripe xlator in its graph), loc->path can be legitimately NULL.
The fix involves removing this check in stripe_lookup().
Change-Id: Ibbd4f68763fdd8a85f29da78b3937cef1ee4fd1e
BUG: 1100050
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8145
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8727adad6e21a2875db3ac1a7ce1964264744a2b
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Fri Jun 6 12:22:04 2014 +0530
gNFS: Fix multi-homed m/c issue in NFS subdir auth
NFS subdir authentication doesn't correctly handle multi-homed
(host with multiple NIC having multiple IP addr) OR multi-protocol
(IPv4 and IPv6) network addresses.
When user/admin sets HOSTNAME in gluster CLI for NFS subdir auth,
mnt3_verify_auth() routine does not iterate over all the resolved
n/w addrs returned by getaddrinfo() n/w API. Instead, it just tests
with the one returned first.
1. Iterate over all the n/w addrs (linked list) returned by getaddrinfo().
2. Move the n/w mask calculation part to mnt3_export_fill_hostspec()
instead of doing it in mnt3_verify_auth() i.e. calculating for each
mount request. It does not change for MOUNT req.
3. Integrate "subnet support code rpc-auth.addr.<volname>.allow"
and "NFS subdir auth code" to remove code duplication.
Change-Id: I26b0def52c22cda35ca11766afca3df5fd4360bf
BUG: 1102293
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/8048
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 9d18e9b383557ef9e84e4ac91f9efee65c4b4862
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Jun 23 13:20:07 2014 -0700
glusterd: Use mkdir_p to create DEFAULT_WORKDIR
On non-Linux platforms FSH(Filesystem Hierarchy Standard)
is not followed 'create' the default expected directory.
Change-Id: Ia55dc99aa398efb6d2d140985cbc0ae11bdc763c
BUG: 1111774
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8155
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 6dfd66a1bad897adafadf5fac3abe23a132931eb
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Jun 20 08:40:47 2014 -0400
xlators/mgmt: don't allow glusterd fork bomb (cache the brick inode size)
Was don't leave zombies if required programs aren't installed
Also, the existing if (strcmp (foo, bar) == 0) antipattern leaves me
underwhelmed -- table driven is better;
I like fully qualified paths to system tools too.
File systems aren't going to change their inode size. Rather than
fork-and-exec a tool repeatedly, hang on to the answer for subsequent
use. Even if there are hundreds of volumes the size of a dict to keep
this in memory is small.
Change-Id: I704a8b1215446488b6e9e051a3e031af21b37adb
BUG: 1081013
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/8134
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 18b42d19d4daa183e698d522409263f430d89aa3
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Jun 23 12:36:17 2014 +0530
cluster/afr: change message description in afr-messages.h
Changed the description of AFR_MSG_SUBVOL_UP to make it more meaningful.
Change-Id: I30fa13c2e9a280a22d48e777d259d04a3b71deef
BUG: 1075611
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/8149
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit cab24e71d95ba1043241046527554fa97e0dee2c
Author: Poornima Gurusiddaiah <pgurusid@redhat.com>
Date: Thu Jun 19 16:19:23 2014 +0530
libgfapi: In glfs_*chown, if uid or gid is -1, do not set the corresponding flag.
Change-Id: I23d0caa36c37dd5372f6e1d6a27c7904f4df547b
BUG: 1111563
Signed-off-by: Poornima Gurusiddaiah <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/8115
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Justin Clift <justin@gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d1c857f670335a6e384fab23540ec320a1040270
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sat Jun 21 19:20:46 2014 +0530
cluster/dht: handle ESTALE appropriately in rmdir codepath.
Till we separated the scenario of a file/directory not existing from
parent not existing [1], we used to include a subvolume in the layout
of a directory even if it is not present on that subvolume. This was
done to allow a lookup racing with mkdir to create correct layout.
However, there are other scenarios as well where a directory is not
present. One such situation is trying to create a directory after an
add-brick. Since there is no guarantee that all the ancestors are
created after an add-brick (and hence directory cannot be created), the
newly added brick should not be part of the layout. However, we used to
consider newly added brick as part of layout (even before we do
fix-layout of all the ancestors) and this was the root cause of [2].
With [1], this issue got fixed and hence [2] got fixed too. However,
[1] is not complete in the sense we didn't modify rmdir codepath
appropriately. This patch fixes that gap.
[1] http://review.gluster.org/6322
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1006809
Change-Id: I79ab96bb8abb6f3d90bb6e235a1c465e1be0fd19
BUG: 1032894
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/8142
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 9196829bc5edd55324222c35477ac64b1539d10b
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Fri Jun 20 20:01:59 2014 +0530
glusterd/snapshot: delete temporary folder after snapshot create
snapshot create create temporary folders in /tmp location with
the name xfsmountXXXXXX. It should be cleaned up after snapshot
create
Change-Id: Idd0c480c1eee7f0fdeba92ae427510faac0f5234
BUG: 1111614
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/8138
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 87ae0a63e9849b02fdb213683f31688f18c6ae7e
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Fri Jun 20 18:04:33 2014 +0530
glusterd/snapshot: cli error message corrected
snapshot delete on failure used to give invalid error
message.
Change-Id: I65d6edf8004c9a1bb91f28fa987b2d1629134013
BUG: 1111603
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/8137
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 452ff4fdfaedac1c6723901f1eab38715d4916e1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jun 19 13:51:41 2014 +0530
tests: Change umount with force_umount with 5 retries
Change-Id: I0e2dbdfd34080328dfa6b4eebef0366f2b0fcb04
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8117
Tested-by: Justin Clift <justin@gluster.org>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 73bc3ea773c93c31ebf1ee31779c6ec1790fcf11
Author: Ravishankar N <root@ravi3.(none)>
Date: Thu Jun 19 17:41:25 2014 +0000
cluster/stripe: don't treat ESTALE as failure in lookup
Problem:
In a stripe volume, symlinks are created only on the first brick via the
default_symlink() call. During gfid lookup, server sends ESTALE from the other
bricks, which is treated as error in stripe_lookup_cbk()
Fix:
Don't treat ESTALE as error in stripe_lookup_cbk()
Change-Id: Ie4ac8f0dfd3e61260161620bdc53665882e7adbd
BUG: 1111454
Signed-off-by: Ravishankar N <root@ravi3.(none)>
Reviewed-on: http://review.gluster.org/8135
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 15eb23b23157d1797510186e03e5f56af175d78e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Jun 20 15:54:57 2014 +0530
features/snapview-client: put local back to mempool after unwind
Change-Id: I3a709a835b21edf757ee5a1cd04cd9d1c59201dc
BUG: 1111552
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8128
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 273ade8a6b8afad467310a8239f5e5a1a5784c85
Author: Ajeet Jha <ajha@redhat.com>
Date: Thu Jun 19 17:37:18 2014 +0530
features/changelog: Fix for history api issue during upgrade
On failure during history changelog availability check, there
was an attempt to destory attribute (of consume thread) which
was not initialised.
Change-Id: Ica7a98ee70eb1303303884b01ef76ab71430a351
BUG: 1111169
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/8118
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit de9ab3896c0fba2ebb01c32ee340f7d0df542db5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jun 20 16:06:42 2014 +0530
libglusterfs: Don't allow '-0' as input value for numbers
Problem:
io-stats tries to init log-buf-size as uint32. All gf_string2u*** functions
which get the unsigned values from string don't want the string to contain '-'.
So the GF_OPTION_INIT with '-0' as value fails init in io-stats, but by that
time 'ret' is already reset to 0. Io-stats ends up returning 0 even when init
failed. Because of this caller of init thinks initialization is successful when
it is not. iostat_xlator->private is still NULL. Because of this when a fop
tries to access members of io-stat-private structure, it crashes.
Fix:
I initially thought may be we should fix all gf_string2u*** functions to
accept '-0'. But all these functions are used only for setting volume options.
If we accept '-0', gluster volume info shows output as follows:
diagnostics.brick-log-buf-size: -0
This seemed ugly, so I felt it is better to disallow '-0' as valid input for
numbers.
Also fixed return value in cases of failures in io-stats.
Change-Id: I67ac92853b6d2be70516ad1d07505ffd9f058aa4
BUG: 1111557
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8129
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ca0045116a36c177d899a235792fecb11f3d1a91
Author: ggarg <ggarg@redhat.com>
Date: Wed May 28 15:01:16 2014 +0530
glusterd: Spelling correction in glusterd log message
Change-Id: I062302f97a88c528096a92b8dcb33860067e7c22
BUG: 1101691
Correction: "Received" instead of "Recieved"
Reviewed-on: http://review.gluster.org/7902
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 7f34213b328b2270a3b9de3c58674e1549ce0833
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Jun 20 07:48:19 2014 -0700
Revert "gfapi : remove gfapi.py to avoid confusion"
This reverts commit d0547a28f59d80ed572652af3e327b761c4e540f
Change-Id: I79ff562fff33d4ad7ca34c6442eb0e980890965a
Reviewed-on: http://review.gluster.org/8139
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 1ae486d64b1bc1aabffffc97e9cbe85d42d4716b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jun 19 05:06:53 2014 +0000
features/index: Don't delete current xattrop index.
Delete the base entry in indices/xattrop only when it is stale.
Change-Id: I675c1510dd8293d068e31b552b0de48f50aac658
BUG: 1101647
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/8119
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 8f3393b795cd9803d14a53a069851e7f2c673dfa
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Thu May 29 11:04:56 2014 +0530
gfapi : remove gfapi.py to avoid confusion
python binding of libgfapi is evolving via libgfapi-python
project. The example available here confuses end users,
so removing it from this path.
Change-Id: I90a0a29972f5230b8b440e8941aaca8a62e497a6
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/7920
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Thiago da Silva <thiago@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit beb847af7e3164da7f8cc6a417cb5948334fa30d
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jun 16 19:08:18 2014 +0530
tests: changes to some of the uss testcases
Made the below changes
tests/basic/uss.t: removed the older way of getting the list of snapshots
bugs/bug/bug-1109770.t: added uss disable test also to check snapd behavior
Change-Id: I57b6bc8fa82bcaa544f483ad382e1bb4d11ef122
BUG: 1092850
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8081
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4290f066a1f4db0b9ee27e0d68cfddff20cafef6
Author: Kotresh H R <khiremat@redhat.com>
Date: Fri Jun 6 03:27:21 2014 +0530
feautre/gfid-access: Fix EINVAL when stat on .gfid
Problem: Some of the inode operations on '.gfid'
virtual directory was resulting in the error
EINVAL from dht after failing to find the layout.
Solution: Inode operations on '.gfid' virtual directory
should not wind further down and should be handled
accordingly in the gfid-access translator itself.
Change-Id: I156cb10ffea0c46b0d747e26f74538d7fb01a1dd
BUG: 1105891
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8011
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1d1b2bade86e03385990323b02406eaa97cc4975
Author: Kotresh H R <khiremat@redhat.com>
Date: Wed Jun 18 13:30:26 2014 +0530
feature/geo-rep: Fix to retain pause state of gsyncd on restart
On soft reboot, geo-rep monitor is writing 'faulty' into status
file. It should not do it if previous state is paused as
glusterd depend on the state file on node restart.
Change-Id: Idd45abf13350b087371935f1b4f6e1a346433d27
BUG: 1101410
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8097
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 91ed440bc51e15b5c4420c01aa3a5acc590ab810
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jun 19 15:21:33 2014 +0530
glusterd: Check mount_dir for own bricks only during start
During the start volume commit op brickinfo->mount_dir was being checked
for all bricks by glusterd. This could lead to failures starting the
volumes which were carried forward on upgrade.
Change-Id: If3d3ee4b2b9f68341ff4422dd90faf32bc3e898f
BUG: 1111124
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/8113
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit a2069c84e491236837b190d3a7c97c1f3186476a
Author: Sachin Pandit <spandit@redhat.com>
Date: Fri Jun 13 08:55:31 2014 +0530
docs : Admin document updation for snapshot commands.
Change-Id: I8460e7feed7e1b0cf37e735852f5c269adfadd77
BUG: 1061685
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8060
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e511d3403594b9d0d6cf8e205761af165cf7f8ed
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jun 18 22:10:12 2014 +0530
tests: Provide force_umount with 5 retries
Change-Id: I2b5784c48eedcccb17690de438addd29075926bd
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8104
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 01569983be4d4543e1fa5d0b1aa7a36df3181a8a
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Wed Jun 18 11:06:21 2014 +0530
Cluster/DHT : Logging changes
Removed trailing spaces from the code
Change-Id: I427c9a01b514824f903e301863c2c29071db6483
BUG: 1075611
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/8096
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e7fcac4269bc78ef00d1947e2af1bfafd9ab0b4f
Author: Varun Shastry <vshastry@redhat.com>
Date: Wed Jun 18 17:55:54 2014 +0530
features/quota: Fix dict leak
Change-Id: I971a52163c0f1a887bbb8585cd69df2339af51cb
BUG: 1110777
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/8102
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 410e6b13ef3dd0d4037ad40c0dd220ead8c07b1d
Author: Varun Shastry <vshastry@redhat.com>
Date: Thu Dec 26 15:30:49 2013 +0530
features/quota: Make dht_statfs_cbk more fool proof from quota_deem_statfs
Problem:
The function depends on the fact that if quota-deem-statfs option is enabled,
all of the subvolumes send their xdata with quota-deem-statfs flag ON. But,
this may not be true in case of errors in some of the subvolumes.
There is a decision/policy made which assumes quota-deem-statfs to be ON if at
least ONE of the subvolumes sends the flag ON. By this, df reports quota
modified statfs values if *at least ONE* of the bricks sends the
quota-deem-statfs flag ON. This can be visualized with the below "Transition
Diagram/State Machine".
Event: Each Quota deem statfs status from the individual bricks
Action: Decision taken on the calculation of the statvfs received
State: Whether quota deem statfs is ON or OFF (0: OFF, 1: ON)
Input: Event from individual bricks
___ ___
/ \ OFF* / \ (OFF|ON)*
| | | |
\ / ON \ /
-----> 0 ----------------> 1
The below Transition Function depicts the relation between the statfs
calculation based on the events received.
State Event action
-------------------------------------
OFF OFF OFF
OFF ON REPLACE
ON OFF NEGLECT
ON ON COMPARE
Change-Id: I0e8fb7d3945a3ca3dde0bb99de6cd397e27a3162
BUG: 1048786
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/6652
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 59a3c0991759ec931b20aa793105b8cbf25a2da1
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jun 18 11:28:05 2014 +0000
glusterd/snapshot: Updating "global-option-version" in /var/lib/glusterd/options
When auto-delete option is set, we should update the
"global-option-version" in /var/lib/glusterd/options
to the next version.
Change-Id: Ic561f33531a27cb8cca01d25632511205927268a
BUG: 1104642
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/8099
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit fc998d08bbb0cbad644e275991c1bc9e7cb895a2
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Jun 5 23:09:56 2014 -0700
snapview/server: warning cleanup after clang complaints
- svs_inode_new()/svs_fd_new() should only need "no" arguments as
presented
- define variables only with usability :-)
Change-Id: I10a8d189a088701b29f26b6e4913560e32d16e75
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7998
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 72ae3cfa7f61392798649f111e1ce87edaac0d74
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Jun 13 18:50:44 2014 -0700
glusterd: Avoid simple inline function definitions with local scope
C99/clang treats simple 'inline' function definitions as external
scoped functions - this leads to flat_namespace issue on OSX.
Avoid them by making them 'static inline' instead.
Change-Id: I03deb4a72e0ba16e5e21e9739792b777898b67ed
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8067
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 08e4609e5bf5f367e43986302bd69d485ae77c7d
Author: Kotresh H R <khiremat@redhat.com>
Date: Fri May 30 17:03:30 2014 +0530
feature/geo-rep: Fix for changelog agent becoming zombie.
Monitor process spawns changelog agent and is not
wait on it, hence becoming zombie. When worker is
dies/killed, it respawns both worker and corresponding
agent leaving the earlier changelog agent in zombie
state. This patch addresses this issue by waiting
on agent process in montor process.
Change-Id: I571b7d6487133848edca67e7446f1caa70ae01c9
BUG: 1103643
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7956
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 13680dbef827b0e961bfb41bc35343875f86d687
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue Jun 17 15:09:50 2014 +0530
cluster/dht: Do layout self healing of directory for nameless lookup
Problem: Currently in the nameless lookup code path, if at the
end of the lookup, even if it detects that layout
anamolies are there, layout healing will not be done as
there is no code to heal it.
So there can be race between mkdir and lookup.
Assume mkdir is going on from some other mount point,
Say, M1. Directories are created on some nodes but layout
is not set yet.
Now from M2, nameless lookup goes, lookup will be success
full as the directory is present on some of the nodes, but
it won't heal layout. Now if create goes after lookup fop,
because layout is absent, file creation will fail.
Fix: Included the code of layout self-heal in the nameless
lookup path. At the end of lookup, layout will be computed
as it would have been in the named lookup, but it will be
set to those node only, where directory is present.
So after that if create fop goes, the probabiliy to get the
subvolume with proper hash-range is high now, so reduces
the race window.
Other: Whenever a directory is created, we have to choose a brick
from which we start allocating layout in a circular fashion.
To calculate this starting brick, I have changed the candidate
from name of the directory to gfid of the directory
But to compute where a given file belongs, we will still
use the name of the file. Hash computed from the name of the
file should belong to any one of the directory-hash-range
Calculation of hash for a file is acting as a consumer and the
setting of directory layout based on gfid is acting as a producer,
which are independent from each other.
Change-Id: I3808c55082cd1b5c72d2c77cbbc063f55aa38bee
BUG: 1095888
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/7493
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bc00ae7ab10c04c5f1f4f0e0f9696bd8126c7756
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue Jun 17 14:45:44 2014 +0530
cluster/dht: Bring option to choose gfid or name based hashing
Change-Id: I11794eb2adceb88e75864aede450e904431a6273
BUG: 1095888
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8049
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 732599b58b4ed07d53441e90d468c5a9d4cd43c7
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Sun Jun 1 11:05:51 2014 +0530
mention use-readdirp option in mount section
Change-Id: I843a8b7713f96dcb5fdb07b8cadc47b4adc0a7b9
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/7939
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e1ce2397f0808841573b7d4e97d0a01d5cd5a75c
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Nov 15 13:17:42 2013 +0530
extras: add a script to stop all the glusterfs process
Change-Id: I9f73bf0308625695ed78db06478963d16644852a
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/6270
Reviewed-by: Sachidananda Urs <sacchi@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 706f576dff86b68efc2a6041de97f5733e178646
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jun 16 20:38:42 2014 +0530
mgmt/glusterd: save the snapd port in volinfo after starting snapd
Change-Id: I9266bbf4f67a2135f9a81b32fe88620be11af6ea
BUG: 1109889
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8084
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit 1578d8f8762a6355a44e81052a4a4656b770c8e1
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jun 16 18:56:18 2014 +0530
glusterd: Use blocking quotad start only on quota enable
Having quotad always being using the blocking runner variant is
problematic. In some cases where quotad was started from the epoll
thread, it lead to a deadlock which lead to glusterd becoming
unresponsive.
This patch makes the default quotad_start function use the non-blocking
runner_nowait variant. The blocking start is used only when quotad is
started on quota enable command.
Change-Id: Ib27042748d69ea28e68badcfaddf61589aae4eba
BUG: 1109872
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/8082
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 0e97bd2f2198a2d965f8c32e76ff6a73782536cf
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Jun 15 08:40:49 2014 +0530
tests: Avoid sleep
Change-Id: I7169be3532232754b9461c4e1b27bf6bc857f7a6
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8083
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cff34584242fbb2abbdbd4873b1dfa705a6eed5e
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Jun 16 17:39:08 2014 +0530
glusterd: Fail peer probe/detach commands when peer detach is ongoing
Change-Id: Ifd8099bc235eb395e8fd9ead3197bef71c78042b
BUG: 1109812
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/8079
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 19ad8ae7e426e2190b60bcecea4daddfb7ad2ddc
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Mon Jun 16 15:39:57 2014 +0530
cluster/dht: make loc->inode instead of loc->parent
parent's inode should be taken from loc->inode.
Change-Id: I979b7333efa93b1e8f4c73ccf048d48e308f9289
BUG: 1104653
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/8073
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e63cc7feb284c1529322a82d8c81d33afc9acf86
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Fri May 30 11:26:40 2014 +0530
Cluster/DHT: New logging framework
Moved all relevant DHT gf_log calls to the new logging
framework.
Change-Id: I3af3cfe0416e332774a6c4ff6a091d006c400af2
BUG: 1075611
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/7929
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 68cb276cc1e77bbfd86eba82fe807ee41f078c4b
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jun 16 16:11:46 2014 +0530
mgmt/glusterd: volume stop should also stop its snapview-daemon
Change-Id: I702372c6c8341b54710c531662e3fd738cfb5f9a
BUG: 1109770
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8076
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b2b9e6ed57b97fdc4c5b763e3d5a7d8822fe3168
Author: Anand Subramanian <anands@redhat.com>
Date: Mon Jun 16 07:10:32 2014 +0530
Minor fixes for correcting the goto statements for frame destroy and checking pthread_mutex_lock return values
* Also some coverity fixes
Signed-off-by: Anand Subramanian <anands@redhat.com>
Change-Id: I0c27b913e62b0a072e508e37a3fb3421a9ca9503
BUG: 1105439
Signed-off-by: Anand Subramanian <anands@redhat.com>
Reviewed-on: http://review.gluster.org/8071
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2af24f027de83a2a94d01848be040a507bcded6a
Author: Susant Palai <spalai@redhat.com>
Date: Tue May 13 12:56:17 2014 -0400
DHT/readdirp: Directory not shown/healed on mount point if exists on single brick(non first up subvolume).
Problem: If snapshot is taken, when mkdir has succeeded only on
hashed_subvolume, then after restoring snapshot the directory
is not shown on mount point.
Why: dht_readdirp takes only those directory entries in to
account, which are present on first_up_subvolume. Hence, if the
"hashed subvolume" is not same as first_up_subvolume, it wont be listed
on mount point and also not healed.
Solution:
Case 1: (Rebalance not running)If hashed subvolume is NULL or down then
filter in first_up_subvolume. Other wise the corresponding hashed subvolume
will take care of the directory entry.
Case 2: If readdirp_optimize option is turned on then read from first_up_subvol
Change-Id: Idaad28f1c9f688dbfb1a8a3ab8b244510c02365e
BUG: 1092433
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/7599
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 000f4ad6ce120592a3f9e1f4f1e8fd6b6482cb0b
Author: Kotresh H R <khiremat@redhat.com>
Date: Mon Jun 16 12:30:39 2014 +0530
features/changelog: Do not ignore self-heal fops in changelog
Problem: Geo-rep fails to sync some files to slave as the
changelog entries are missing for those files.
Cause: Fops happened when the active brick is down and
self- healed later when it came up.
Solution: Capture self-heal fops as well in changelog so
those entries are not missed.
Change-Id: Ibc288779421b5156dd1695e529aba0b602a530e0
BUG: 1109692
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8070
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6f92136b24cbb8bdb88b116ee84524173b8687df
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Jun 9 07:52:37 2014 +0530
glusterd/snapshot : override postvalidate for few snapshot commands.
snapshot info, list, config display and status does not
require any operations to be performed during postvalidate stage.
Hence it is better to override these commands in postvalidate.
Or else there will be a warning in log message saying "postvalidation
failed".
Change-Id: I14d64f7bf9adee8821067dd74d5027215d7b02f8
BUG: 1106406
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8014
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 63952ea386101200ec7b7883e620acfa073cd8df
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Jun 15 16:19:15 2014 +0530
tests: Validate self-heal daemon completions
Removed sleep with EXPECT_WITHIN
Heal full doesn't generate indices until the files/dirs are
recreated. So wait until they are re-created and then
wait for heal completion.
Change-Id: I82399f6a17f94ecc101db45b83d8ef7bfa9c64dd
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8069
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ace7f71e93d5e80e3ea2ce0d4a81a3d4fe4329d4
Author: Varun Shastry <vshastry@redhat.com>
Date: Wed Jun 4 12:43:18 2014 +0530
features/quota: No root squash for quota aux mount by default
With change 28209283a67f13802cc0c1d3df07c676926810a2, the root squash option
is enabled by default even for the trusted clients. This disallowed quota
auxiliary mount from setting the limit.
This patch adds the quota aux mount process to list of 'special' clients which
have the root squash disabled by default.
Change-Id: Ie6583dd3deb170563daf001239c51bcff1ce078b
BUG: 1104692
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/7967
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit e2674511271cd9ecabba96ec2316538e1e917d02
Author: Anand Subramanian <anands@redhat.com>
Date: Thu May 15 08:19:14 2014 +0530
Get snapshot info dynamically via new rpc and infra for snapview-server to refresh snaplist
BUG: 1105439
Change-Id: I4bb312a53d88f6f4955e69a3ef2b4955ec17f26d
Signed-off-by: Anand Subramanian <anands@redhat.com>
Reviewed-on: http://review.gluster.org/8001
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 34d057ab1e2df396cafd1880d05375ad8a9190df
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Jun 15 07:54:02 2014 +0530
tests: Fix spurious failure for tests/bugs/bug-918437-sh-mtime.t
Change-Id: I355ae02bed54753480279ddb058cc4b19ace6792
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8068
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f7f8b8fa68c7e3279f809ccc950c610a909fd2ae
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Thu Jun 12 14:18:05 2014 +0530
dht/rebalance: Do not allow rebalance when gfid mismatch found
Due to race condition, it may so happen that, gfid obtained
in readdirp and gfid found by lookup are different for a given
name. in that case do no allow the rebalance.
Readdirp of an entry will bring the gfid, which will be stored
in the inode through inode_link, and when lookup is done and
gfid brought by lookup is different from the one stored in the
inode, client3_3_lookup_cbk will return ESATLE and error will be
captured by rebalance process.
Change-Id: Iad839177ef9b80c1dd0e87f3406bcf4cb018e6fa
BUG: 1104653
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/7973
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 26c4b88dcbb4d3a44a3cf6c752d6508f36520c3e
Author: Joe Julian <me@joejulian.name>
Date: Thu May 22 10:24:22 2014 -0700
doc: Fix peer probe deficiencies
Added the command to probe the first server to assign it a hostname
Change-Id: I9c25f1ce3175e1ffe024f6b6ae14a4526228489a
BUG: 1095594
Reviewed-on: http://review.gluster.org/7852
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2d91c4e349cae0d8887630304bc78e98b56998f3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jun 12 20:38:34 2014 +0530
Fix resolution issues across fuse/server/afr
Problems with fuse/server:
Fuse loc touch up sets loc->name even when pargfid
is not known. Server lookup does (pargfid, name) based
lookup when name is set ignoring the gfid. Because of this server
resolver finds that the lookup came on (null-pargfid, name) and
fails the lookup with EINVAL.
Fix:
Don't set loc->name in loc_touchup if the pargfid is not known.
Did the same even for server-resolver
Problem with afr:
Lets say there is a directory hierarchy a/b/c/d on the mount and the
user is cd'ed into the directory. Bring down one of the bricks of replica and
remove all directories/files to simulate disk replacement on that brick. Now
this brick is brought back up. Creates on the cd'ed directory fail with ESTALE.
Basically before sending a create of 'f' inside 'd', fuse sends a lookup to
make sure the file is not present. On one of the bricks 'd' is present and
'f' is not so it sends ENOENT as response. On the new brick 'd' itself is not
present. So it sends ESTALE. In afr ESTALE is considered to be special errno on
witnessing which lookup has to fail. And ESTALE is given more priority than
ENOENT. Due to these reasons lookup fails with ESTALE rather than ENOENT. Since
lookup didn't fail with ENOENT, 'create' can't be issued so the command is
failed with ESTALE.
Solution:
Afr needs to consider ESTALE errno normally and ENOENT needs to
be given more priority so that operations like create can proceed even when
only one of the brick is up and running. Whenever client xlator identifies
that gfid-changed, it sets that information in lookup xdata. Afr uses this
information to fail the lookup with ESTALE so that top xlator can send
fresh lookup.
Change-Id: Ica6ce01baef08620154050a635e6f97d51029ef6
BUG: 1106408
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8015
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e87d00dc08b5a1b3a655fb5e5f12a43c8334cc9f
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Jun 13 11:23:29 2014 +0000
glusterd/snapshot: Update fstype and fsuuid
Update fstype and fsuuid before creating missed snapshot
Change-Id: Ie9af0065fab288bd1c1a26396428f0cee6335f97
BUG: 1109142
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/8062
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Justin Clift <justin@gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 5ae371a898da43de613eb3450f36027917e9399c
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jun 12 12:45:26 2014 +0530
cleanup: Fix order of arguments passed in log message
Change-Id: Iae85cdfc223875688ea17155fffcf2a3a435d245
BUG: 764890
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8044
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d2613a062a3ac5018155fadbb10ea713896aeb37
Author: Justin Clift <justin@gluster.org>
Date: Fri Jun 13 03:33:51 2014 +0100
tests: add missing check for yajl to run-tests.sh
Also add it to the regression test Requires line, along with other
missing dependencies.
Change-Id: I2a83eb6797bafe8883d90565bb4c1ab93c074644
BUG: 1108958
Reviewed-on: http://review.gluster.org/8054
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a577ad7c9b14503daac35300eadae650652a84ad
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Jun 13 12:01:34 2014 +0530
logging: Flush log messages logged via gf_log_callingfn()
Change-Id: Id1d83a6c5985dd57ef3cf1e3d2f4d04ff2dbabfa
BUG: 889157
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8058
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 69f509b7a975104151a15d829c0eb3cbb857f987
Author: Varun Shastry <vshastry@redhat.com>
Date: Wed Jun 4 15:01:14 2014 +0530
extras: bash command completion for gluster
Change-Id: Ifd6e68b0288dc65e41e467b4ad02bfc3bded341f
BUG: 1108767
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/7979
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b573672fe6a20f2a1cafc201de8e7aeaaa2bea9b
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jun 12 20:14:33 2014 +0530
get the path from the loc->path in the lookup instead of resolver doing it
Change-Id: I7448e1199f4fd32fb0ae127b36dcf06641a153a9
BUG: 1108887
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8053
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 58ee0eadaae8337ba96a0511230a753735d84144
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jun 12 15:02:06 2014 +0530
glusterd: More snapshot backward compatability fixes
Several volume operations, start, add-brick and replace-brick, expected
the presence of a bricks mount directory, which is required for the
snapshot feature. This should only be expected when snapshot is
supported in the cluster.
Change-Id: I92017bb5e069392352f9800cef1ddc80045fda35
BUG: 1101903
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/8046
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 957765acacacaa33268e331f28cb7050cb3ce02a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Jun 6 12:48:32 2014 +0000
glusterd/snapshot: Fix snap delete cleanup
During commit the first thing that should happen is the
snaps should be marked as GD_SNAP_STATUS_DECOMMISSION.
So that if the node goes down the marked snap can be
cleaned up when the node is coming back. Also during snap
handshake while accepting snapshot from peer, we should
check if the snap in question is decomissioned. In that
case we shouldn't be accepting the peer data.
Change-Id: Ib4e38d1b6bf49411928623fbc9f72f2b37b72086
BUG: 1104714
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7996
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 93ac492fc40f0fce0c6dbf58f4b53621ee94abb3
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Fri Jun 13 10:49:47 2014 +0530
glusterd/snapshot: Fix for snapshot restore failure
Problem: If restore fails due to quorum failure then the subsequent restore fails.
Cause: Volume store is backed up during prevalidate failure and it is
reverted or cleaned based on failure or success of the commit phase.
In case of quorum failure we were not reverting the backup.
Fix: Take backup when all the validation is done including quorum check.
Change-Id: I55d57f6ee85fac04a0e6cbd0291a402601c725d6
BUG: 1109024
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/8056
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit bbbb191ab47d750bfd0084d9c099d0a99c253926
Author: Sachin Pandit <spandit@redhat.com>
Date: Wed Jun 11 09:03:16 2014 +0530
glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.
This patch provides an interface to enable or disable
the auto-delete feature.
Syntax : gluster snapshot config auto-delete <enable/disable>
DETAILS :
1) When auto-delete feature is disabled, If the the soft-limit is
reached then user is given a warning about exceeding soft-limit
along with successful snapshot creation message (oldest snapshot is
not deleted). And upon reaching hard-limit further snapshot creation
is not allowed.
Example :
------------------------------------------------------------------
|Case - 1: Upon reaching soft-limit
|
|Snapshot create : snap successfully created.
|Warning : soft-limit of volume (vol) is reached. Snapshot creation
|is not possible once hard-limit is reached.
|
|-----------------------------------------------------
|Case - 2: Upon reaching hard-limit
|
|Snapshot create : snap creation failed.
|Error : hard-limit of volume (vol) is reached, Hence it is not
|possible to take further snapshots. Please delete few snapshots
|of the volume (vol) before taking another snapshot.
------------------------------------------------------------------
2) When auto-delete feature is enabled, then as soon as the soft-limit
is reached the oldest snapshot is deleted for every successful snapshot
creation (same as existing method), With this it is made sure that
number of snapshot created is not more than snap-max-hard-limit.
Change-Id: Ie3ca64bbd2c763371f541cd2e378314e73b695b4
BUG: 1105415
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8017
Tested-by: Justin Clift <justin@gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3ebf648c4ba17f8d9d707566b4e551ec0a17326e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jun 3 00:28:08 2014 +0530
protocol/server: reflect lru limit in inode table also
Upon reconfigure, when lru limit of the inode table is changed,
the new value was just saved in the private structure of the
protocol/server xlator and the inode table used to have the older
values still. A brick start was required for the changes to get
reflected. To handle it, traverse through the xlator tree and check
whether a xlator is a bound_xl or not (if it is a bound_xl it would
have its itable pointer set). If a xlator is a bound_xl, then get
the inode table of that bound_xl and set its lru limit to new value
given via cli. Also prune the inode table so that extra inodes are
purged from the inode table.
Change-Id: I6909be028c116adaa1d1a5108470015b5fc6f09d
BUG: 1103756
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7957
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit c21db73e480ae7124d0ed40154c7379d92b50aa2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jun 13 11:26:28 2014 +0530
tests: Fix spurious failure in tests/bugs/bug-830665.t
Problem with script:
EXPECT_WITHIN fails the test if the command it executes fails.
There is a possibility that the file script tries to 'cat' may not exist.
In those cases it would fail leading to spurious failures.
Fix:
Add a function which returns empty string when the file doesn't exist
and 'cat' file when it does exist.
Change-Id: I0abfb343f2fce1034ee4b5b680e3783c4f6e8486
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8057
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1e65be4b9b9681bc62ca10d3b214f089647ee959
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jun 13 08:42:25 2014 +0530
tests: Revert janitor link file removal test
I found that order of execution in afr-v2 self-heal is causing
the links to disappear some times. I need to fix that issue
and then submit this test again
Change-Id: Ia886feb796b7854645813f486b7b7ac4e944ed17
BUG: 1101143
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8055
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit f2a37574be6379144d00c6c524f83c1dc8b7af66
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jun 12 12:42:05 2014 +0530
cleanup: Fix domain in log message
Change-Id: I554b9bcacf6c8acd6dffea0a485fc50e82c3dc04
BUG: 764890
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/8043
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1ed9f4e67c8e9d29c0b68e7fe9e9c22270ac11f2
Author: Kotresh H R <khiremat@redhat.com>
Date: Wed Jun 11 16:23:40 2014 +0530
feature/changelog: Fix compilation warning 'set but not used'
Change-Id: I37de39aec341fbde9516aa8f8c963b70bd808bac
BUG: 1108034
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8035
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 2b30987963822ab4d34007b2b195edaa5b03c92a
Author: ggarg <ggarg@redhat.com>
Date: Thu Jun 12 18:51:51 2014 +0530
tests: fix for spurious failure:
Change-Id: I39cc497f12c83aa055acb6e88e4c3e1e8774e577
BUG: 1089668
Signed-off-by: ggarg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/8050
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit f516375b0a2707acf21cfc3aa36b4b415e1a9351
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jun 4 12:30:44 2014 +0000
glusterd/geo-rep: Create the conf file path correctly
In case of mount brocker, the conf file path needs to
be correctly created, and then fetch the status file
Change-Id: Iaa1b04ee46f10961a7056e834170d68282c36efa
BUG: 1104649
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7977
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 61ee940fbe6ba3536d2821f1529e38a541d5fd2c
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Jun 5 13:17:24 2014 -0700
geo-rep/gverify: Never use ping to check for host reachability
On many linux distributions with iptables enabled, ICMP traffic
is usually dropped even when port 22 is open for SSH service
So practically `ping` is an unreliable command
~~~
root@rhs1:/var/log/glusterfs # gluster volume geo-replication geo-test \
17.16.10.1::geo-test-slave create push-pem force
172.16.10.1 not reachable.
geo-replication command failed
~~~
~~~
root@rhs1:/var/log/glusterfs # ping 172.16.10.1
PING rhs2.sjc.redhat.com (172.16.10.1) 56(84) bytes of data.
From rhs2.sjc.redhat.com (172.16.10.1) icmp_seq=1 Destination Host Prohibited
...
...
~~~
~~~
root@rhs2:/var/log/glusterfs # service iptables status | grep 22
4 ACCEPT tcp -- 0.0.0.0/0 0.0.0.0/0 tcp dpt:22
root@rhs2:/var/log/glusterfs # service iptables status | grep icmp-host-prohibited
25 REJECT all -- 0.0.0.0/0 0.0.0.0/0 reject-with icmp-host-prohibited
~~~
Change-Id: I33206ca071aa5d755c0762f7c486da222ec3c7db
BUG: 1105337
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7997
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 8f0e26f82b6fa1e9bd2c5fc27a3e4723144afd18
Author: Poornima <pgurusid@redhat.com>
Date: Wed Feb 5 02:50:08 2014 +0000
glusterd/geo-rep: Fix the resource leaks.
Change-Id: Ic741250999880bdf9e1226cd3eefa791fb66a888
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6905
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 02f4b4f296d6294bc50f6da0f9b6b5d21aff979c
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Wed Apr 30 15:25:29 2014 +0530
Core: Fix issues reported by Cppcheck
Fixed in this patch:
[glusterfs/extras/geo-rep/gsync-sync-gfid.c:105]: (error) Resource leak: fp
[glusterfs/libglusterfs/src/xlator.c:651]: (error) Uninitialized variable: gfid
[glusterfs/libglusterfs/src/xlator.c:652]: (error) Uninitialized variable: gfid
[glusterfs/xlators/cluster/ha/src/ha.c:2699]: (error) Possible null pointer dereference: priv
[glusterfs/xlators/features/changelog/src/changelog.c:1464]: (error) Possible null pointer dereference: priv
[glusterfs/xlators/mgmt/glusterd/src/glusterd-mgmt-handler.c:865]: (error) Possible null pointer dereference: ctx
[glusterfs/xlators/mgmt/glusterd/src/glusterd-mgmt-handler.c:194]: (error) Possible null pointer dereference: ctx
[glusterfs/xlators/mgmt/glusterd/src/glusterd-syncop.c:1408]: (error) Possible null pointer dereference: this
[glusterfs/xlators/mgmt/glusterd/src/glusterd-utils.c:7002]: (error) Possible null pointer dereference: path_tokens
Fixed in 3.4 and 3.5 branch (http://review.gluster.org/#/c/7583/ ,
http://review.gluster.org/#/c/7605/ will be backported in a separate patch)
[glusterfs/xlators/mount/fuse/src/fuse-bridge.c:4688]: (error) Uninitialized variable: finh
[glusterfs/xlators/mount/fuse/src/fuse-bridge.c:3081]: (error) Possible null pointer dereference: state
[glusterfs/xlators/cluster/dht/src/dht-rebalance.c:1719]: (error) Possible null pointer dereference: ctx
[glusterfs/xlators/cluster/stripe/src/stripe.c:4940]: (error) Possible null pointer dereference: local
[glusterfs/xlators/mgmt/glusterd/src/glusterd-replace-brick.c:915]: (error) Resource leak: file
[glusterfs/xlators/mgmt/glusterd/src/glusterd-replace-brick.c:999]: (error) Resource leak: file
[glusterfs/xlators/mgmt/glusterd/src/glusterd-sm.c:248]: (error) Possible null pointer dereference: new_ev_ctx
[glusterfs/xlators/mgmt/glusterd/src/glusterd-utils.c:5297]: (error) Possible null pointer dereference: this
[glusterfs/xlators/mgmt/glusterd/src/glusterd-utils.c:6273]: (error) Possible null pointer dereference: this
[glusterfs/xlators/performance/quick-read/src/quick-read.c:586]: (error) Possible null pointer dereference: iobuf
[glusterfs/xlators/nfs/server/src/nfs-common.c:89]: (error) Dangerous usage of 'volname' (strncpy doesn't always null-terminate it).
False positives
[glusterfs/geo-replication/src/gsyncd.c:99]: (error) Memory leak: str
[glusterfs/geo-replication/src/gsyncd.c:395]: (error) Memory leak: argv
[glusterfs/xlators/nfs/server/src/nlm4.c:1199]: (error) Possible null pointer dereference: fde
[glusterfs/xlators/mgmt/glusterd/src/glusterd-geo-rep.c:1659]: (error) Possible null pointer dereference: command
[glusterfs/xlators/mgmt/glusterd/src/glusterd-utils.c:7001]: (error) Possible null pointer dereference: path_tokens
Insignificant/Don't care
[glusterfs/contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 2) requires 'long *' but the argument type is 'unsigned long *'.
[glusterfs/contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 3) requires 'long *' but the argument type is 'unsigned long *'.
[glusterfs/extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[glusterfs/xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[glusterfs/xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[glusterfs/xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr
Change-Id: I7696ed1a2a9553b79f9714e10210a8d563a5abd8
BUG: 1091677
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/7693
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4b7c6d9aa2b356062a968dff306cd8c6169af7a1
Author: Sachin Pandit <spandit@redhat.com>
Date: Thu Jun 12 04:31:47 2014 +0530
tests : Fix for spurious failure of bug-1104642.t.
Problem :
This test case checks whether global option is updated
when glusterd goes down and comes back up.
There might be a scenario where the handshake is not
completed yet and we issue a volume info in between.
In that case when we try to grep a key from gluster volume info
output it might not be there.
Hence to get some time we can issue a peer status command
and verify that the peer count is correct.
Change-Id: I2933d55ce8c80517a555fa3c2e4cd768cde30abf
BUG: 1104642
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/8041
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ea61c35dfa2fac0ffb547485617b837e21b001fb
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Jun 5 18:24:56 2014 +0530
extras/hookscripts: When set option disables smb, don't start smb.
When user.smb or user.cifs option is set to disable, we remove the
share options from smb.conf. If smb process is running, a sighup is
required but we should not start the process if its not running.
Change-Id: I1e2163ff209ba858380f7da459ff1dba3cf673f2
BUG: 1105123
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/7994
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 307113e1bd04f0a298074442038e9db65066a5a8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 9 08:43:45 2014 +0530
tests: Add fops sanity
Original-Authors: MS Vishwanath and Sachidananda URS
Change-Id: I7a76b74fc4de24a2d7ec5932ff2c47754abf0521
BUG: 1084422
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7928
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b3a9d8a02f0e7e3a574cd9aae7ff6c219884dc26
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Thu Jun 5 10:00:33 2014 +0530
glusterd/snapshot: Update file-system uuid during snap creation
After the brick snapshot file-system UUID of the origin
brick and the snapshot brick will be identical. If user
is using file-system UUID to mount the backend bricks
then this will result in unexpected behaviour.
Fix: After taking the LVM snapshot create new UUID for
the snapshot brick.
Change-Id: I339c90abd72dd392de195b674ea22217e63dfd48
BUG: 1105484
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/8002
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 5e3eef713dc34b5e324a21bda2b8c5f8d85ebf18
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jun 9 18:33:21 2014 +0530
mgmt/glusterd: provide interface for configuring the entry point to snapshots
Change-Id: Ibfd0e43db8e5f3f0f2ab6ec6bed88f71397c0bf4
BUG: 1107531
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/8025
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 8a9d25ab63053405729ba9bb4203da430f24542a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 23 12:51:28 2014 +0530
storage/posix: Janitor should guard against dir renames.
Problem:
Directory rename while a brick is down can cause gfid handle of that directory
to be deleted until next lookup happens on that directory.
*) Self-heal does not have intelligence to detect renames at the moment. So it
has to delete the directory 'd' using special flags, because it has to perform
'rm -rf' of that directory as it is not empty. Posix xlator implements this by
renaming the directory deleted to 'landfill' directory in '.glusterfs' where
janitor thread will perform actual rm -rf by traversing the directory. Janitor
thread wakes up every 10 minutes to check if there are any directories to be
deleted and deletes them. As part of deleting it also deletes the gfid-handles.
Steps to hit the problem:
1) On a replicate volume create a directory 'd', file in 'd' called 'f' so the
directory 'd' is not empty.
2) bring one of the bricks down (lets call it brick-a, the other one is brick-b
3) Rename d to d1
4) When brick-a comes online again, self-heal deletes directory 'd' and creates
directory 'd1' on brick-a for performing self-heal. So on brick-a,
gfid-handle of 'd' pointing to 'da is deleted and recreated to point to 'd1'.
5) This directory 'b' with all its directory hierarchy (for now just the file
'f') will be under 'landfill' directory.
6) When janitor thread wakes up and deletes directory 'd' and gfid-handle of
'd' without realizing that it is now pointing to 'd1'. Thus 'd1' loses its
gfid-handle
Fix:
Delete gfid-handle for a directory only when the gfid-handle is stale.
Change-Id: I21265b3bd3852f0967d916aaa21108ae5c9e7373
BUG: 1101143
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7879
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e41a55d87e6ccaa5ca8131315b40b15d8a369066
Author: Kotresh H R <khiremat@redhat.com>
Date: Wed Jun 11 14:18:02 2014 +0530
geo-rep/glusterd: Fix glusterd crash during geo-rep config reset.
Problem:
When "\!<config-option>" (i.e., reset) is used in geo-rep config,
glusterd crashes with NULL pointer dereference of 'op_value' in
glusterd_gsync_op_already_set.
Solution:
glusterd_gsync_op_already_set should be called only for geo-rep
set option. So bypass glusterd_gsync_op_already_set for reset.
Change-Id: I9d8ef242abf02011139d76a72564f66d68cc8585
BUG: 1107984
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/8032
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 2e1afd3a8d4d4080442b8c37a9c2af2553e9760b
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jun 6 16:04:40 2014 +0530
geo-rep: Making replica failover check interval configurable
Replica failover check interval is hardcoded to 60 sec
by default. Now this option is made configurable and
defaulted to 1 sec.
To change the default value
gluster volume geo-replication <MASTERVOL> \
<SLAVEHOST>::<SLAVEVOL> config replica_failover_interval 15
Change-Id: Iada1b80d510452dcfedebd8a21bebd62394b0597
BUG: 1066410
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/8003
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 741bd3ae56b7000a705ce677ca13d7c2255c5e76
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Jun 4 17:41:10 2014 +0530
geo-rep: entry_ops errors handling
Xattr.lsetxattr_l call will not raise OSError which
errno_wrap can handle, so we need to use Xattr.lsetxattr
to get proper OSError and errno_wrap ignores or retries
accordingly.
Change-Id: Ie0a777152ddbaf9ed80c977e4704974fec997bea
BUG: 1105083
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/7972
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit b1661e9ffd27a324ead75cc830ddc19360e7cb63
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Jun 6 18:43:15 2014 -0700
scripts: CTDB lockvol ping-timeout should be 10secs
commit "4044e387dd40e2d12145fd32d5fd715406fcec8e" approach
to this led to deadlocks instead we rely on an old trick at
client side - without any need to modifying the volume globally.
Change-Id: I6e3c6bf9c0a3a0dd99a51b5d2a6c1f050ed2384c
BUG: 1091600
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/8007
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3c138f781ad7068d065dbc2a99226c630a783083
Author: Poornima <pgurusid@redhat.com>
Date: Sun Feb 9 23:29:23 2014 +0000
protocol: Fix a possible memory leak.
Change-Id: Ia3e7e33389b4d3a5e058b6b2fb2f1c3cb224d6fd
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6950
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 47a55239052c80cd22c4e2f033289a2e204e2f92
Author: Sachin Pandit <spandit@redhat.com>
Date: Wed Jun 4 03:41:35 2014 +0530
glusterd/snapshot : Store the global snapshot config limit in options.
Problem : Initially we used to save the global config
limit in glusterd.info, The problem with that approach
was glusterd.info is local to a particular glusterd
and hence is not synced during the handshake of glusterds.
Solution : Store the global snapshot config in options,
which is synced during handshake.
Change-Id: I4c688bb4052a57df28aadba8581b14e2ddb510ef
BUG: 1104642
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7971
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit b22d7f9af25fbb0d3b691ba5b1162eebdae6f9ea
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Jun 5 09:22:34 2014 +0530
features/locks: Clean up logging of cleanup in DISCONNECT codepath
Now, gfid is printed as opposed to path in cleanup messages.
Also, refkeeper update is eliminated in inodelk and entrylk.
Instead, the patch ensures inode and pl_inode are kept alive as
long as there is atleast one lock (granted/blocked) on an inode.
Also, every inode is unref'd appropriately on a DISCONNECT from the
lock-owning client.
Change-Id: I531b1a02fe1b889fdd7f54b1fd522e78a18ed1df
BUG: 1104915
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7981
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6146e028c3f4699c9930cb6e7d2e86f220e8d179
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jun 11 10:39:35 2014 +0530
tests: Remove spurious failure test
Change-Id: If428a505c9b5fed31150d6375a318d10e0dc64cb
BUG: 1107937
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8031
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 907b803cf1ff0930faad4f6eb9c2771065e12539
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue May 27 08:34:06 2014 +0000
glusterd/snapshot: Remove mnt pt, while removing lvm
During a delete/restore snapshot remove the mnt point dir
created at /var/run/gluster/snaps along with the lvm
mounted on it.
Also removed glusterd_recreate_vol_brick_mounts and
renamed glusterd_store_recreate_brick_mounts as
glusterd_recreate_vol_brick_mounts, inorder to reduce
redundant multiple calls
Change-Id: Ie87907ebbf8ef790fba07ef8581d2eb8d55658d0
BUG: 1101463
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7889
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 2d5698275e1a5d658778c3b61ef99a7846af5ad9
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Jun 5 04:44:25 2014 +0000
glusterd/snapshot: Don't update the snap volume's op_version
After the features.barrier key is removed from the snap_vol
dict, it's op_version should also be updated, so that it
doesn't inherit the op_version of the original volume when
it had the key set.
Also in glusterd_volinfo_dup(), which duplicates volinfo the volume
op_version should not be updated, rather the original volume's
op_version should be used.
Change-Id: Ib2250700f649e6c906b14aeccee5e78f71d69780
BUG: 1104944
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7986
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 11afe03ca42fae5d67ab52c85439c039a2d04255
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Mar 19 19:32:15 2014 +0530
gsyncd / geo-rep: FSH recommended log locations
Upgrading "working_dir" on the fly is a bit unclean yet
(though it works) as currently config upgrade does not
support "old" values to be expanded by using configuration
variables.
Change-Id: I44ed65c281f2e0ce3b6b467addc5c1c88ac674e7
BUG: 1077516
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/7375
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b0867293ebc3a89aff2b6d242153bf5affc4d0e5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Jun 8 11:23:26 2014 +0530
features/gfid-access: Fix inode leaks and loc path corruption
Change-Id: Ib506db28415d57b344aa90e07e74666ad2063c64
BUG: 1104919
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8009
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f4634c616260f8fadb9c76b0d830ca65283e6542
Author: Ajeet Jha <ajha@redhat.com>
Date: Mon Jun 2 14:49:07 2014 +0530
features/changelog: skipping empty changelogs in history
Empty changelgs are unlinked and htime-update is bypassed
while publishing partially written changelog.
Change-Id: I1533ad431e4fbf592d2f38837fce782932d01e9c
BUG: 1105466
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/7949
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit a339613311fdce34ebabad8266957f43a0e07d2f
Author: Sachin Pandit <spandit@redhat.com>
Date: Fri May 30 08:47:32 2014 +0530
glusterd/snapshot : Dont create quota.conf if quota is not enabled.
Problem : Quota.conf was getting created during handshake of glusterds
even if quota was not enabled.
Solution : Check if quota is enabled. If not, then dont create quota.conf.
Change-Id: I55ae487aab5759b25a561705645c1c77ff108670
BUG: 1101483
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7934
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 6cbc82015ff674d738f44c04325a2c9129e65f21
Author: Kotresh H R <khiremat@redhat.com>
Date: Mon May 5 15:33:25 2014 +0530
feature/changelog: Add timeout to changelog barrier.
This patch introduces configurable 'changelog-barrier-timeout'
in changelog. The default changelog-barrier-timeout is set to
120 sec which is same as barrier-timeout of barrier translator.
On this timeout, all the barriered fops are unbarriered. It is
safe to have this internal timeout for changelog barrier to
prevent it from indefinite barrierring of fops if barrier
disable notification does not come from snapshot for some
reason.
Change-Id: Iad07807935f88222cdefcd46312b4b6579186dce
BUG: 1094226
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7669
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 1c145a45228384888d37a0aa889ee3e1c397c705
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Jun 9 21:58:29 2014 +0530
gsyncd / geo-rep: Xsync crawl metadata synchronization
Added "metadata" record for directory and file creations
during the intial crawl.
Change-Id: I811ae26e0144cadf7249cb64541ec354ab83fe66
BUG: 1106604
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/8018
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 52a7d4b04d9670f7174a2e798adffdc9062f90e8
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon May 26 12:12:36 2014 +0530
glusterd : glusterd message-id comments to support extracting the msg-id description through doxygen
Change-Id: Ic9660519ae505b78e976e092e7ac80ae63b12a7f
BUG: 1075611
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7867
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Pavithra Srinivasan <psriniva@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 1010d98d42d432740aa67b119d3382260b60360f
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Jun 5 10:06:47 2014 +0530
features/gfid-access: Fix memory leaks.
Change-Id: I90f6cdb1c8c4face1bb72a9cc77818d308389e45
BUG: 1104919
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/7982
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 817adaf506816410e3d43612ce0a4760756bbbe0
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jun 2 14:47:15 2014 +0530
mgmt/glusterd: delete only the oldest snapshot as part of autodelete
Now this is how autodelete behaves:
1) Upon creation when the max-soft-limit exceeds, the oldest snapshot is
deleted. i.e if hard limit is 100 and by default soft limit is 90.
Whenever snap count reaches 90, every new create results in the deletion
of the oldest snapshot.
2) If the snap limit (hard) is reconfigured and brought down
the current snap count, then no snapshot is deleted and the next snapshot
create fails as the current snapcount is more than the hard limit.
3) When soft limit is brought down: say max limit is 100 and by default soft
limit is 90 and current snap count is 90. Now, soft limit is changed to
70 (70%). In this case the snapshot count remains 90 itself (i.e extra
20 snapshots more than the soft limit are not deleted) and for every new
create the oldest snapshot is deleted.
Change-Id: I1f3b4b9eb093649f8628ebf09a15bd2570ddf340
BUG: 1103665
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7951
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 877358dd1896da479fa49ba01f67ae7b09a7be0b
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jun 3 16:14:35 2014 +0530
glusterd: Better op-version values and ranges
Till now, the op-version was an incrementing integer that was
incremented by 1 for every Y release (when using the X.Y.Z release
numbering). This is not flexible enough to handle backports of features
into Z releases.
Going forward, from the upcoming 3.6.0 release, the op-versions will be
multi-digit integer values composed of the version numbers, instead of a
simple incrementing integer. An X.Y.Z release will have XYZ as its
op-version. Y and Z will always be 2 digits wide and will be padded with
0 if required. This way of bumping op-versions allows for gaps in
between the subsequent Y releases. These gaps will allow backporting
features from new Y releases into old Z releases.
Change-Id: I463f82902d997ec07e76dae58ac935f33e6393c2
BUG: 1104997
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/7963
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c6142a450a29b00aa9a6ff994c7b19527ba40632
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Fri May 30 12:37:23 2014 +0530
rpc: Reconfigure() does not work for auth-reject
Problem:
If volume is set for rpc-auth.addr.<volname>.reject with value
as "host1", ideally the NFS mount from "host1" should FAIL. It
works as expected. But when the volume is RESET, then previous
value set for auth-reject should go off, and further NFS mount
from "host1" should PASS. But it FAILs because of stale value
in dict for key "rpc-auth.addr.<volname>.reject".
It does not impact rpc-auth.addr.<volname>.allow key because,
each time NFS volfile gets generated, allow key ll have "*"
as default value. But reject key does not have default value.
FIX:
Delete the OLD value for key irrespective of anything. Add
NEW value for the key, if and only if that is SET in the
reconfigured new volfile.
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Change-Id: Ie80bd16cd1f9e32c51f324f2236122f6d118d860
BUG: 1103050
Reviewed-on: http://review.gluster.org/7931
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e935f32a0b2c6228e4816cc56c9b6ef2cfa2778b
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Jun 4 23:01:41 2014 +0530
tests: add testcase for user servicable snapshots
Change-Id: Ida59727f592c85e81a438e0034a9f94582734417
BUG: 1094815
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7980
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 52a3f810245e1f0e2650e57a74159b3ee666d8ee
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Jun 4 18:43:36 2014 +0530
snapview-server: coverity fixes
Change-Id: If4c866b1155bedabd5cf65dae22fa565b7440938
BUG: 1094815
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7975
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9e98cf238404f77fcdc87158b0a4212c548bf3cb
Author: Sachin Pandit <spandit@redhat.com>
Date: Wed Jun 4 10:30:59 2014 +0530
mgmt/glusterd : Import the global options irrespective of change in volume information.
Problem : global options maintained by glusterd was getting
synced only when there was change in volume information.
Solution : Import the global option irrespective of change in
volume information.
Change-Id: I9e59b3cb25bdc19601a09fcf8df2e31a8481ece0
BUG: 1104642
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7970
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit a2548c59e6e6a63e4908ab09ec63047647359f27
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jun 6 12:45:12 2014 +0200
gNFS: Make NFS DRC off by default
DRC in NFS causes memory bloat and there are known memory corruptions.
It would be good to disable drc by default till the feature is stable.
Change-Id: I93db6ef5298672c56fb117370bb582a5e5550b17
BUG: 1105524
Original-patch-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/8004
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 152a9c08f0a597779aa8b5b8d89fa507bfc52685
Author: Susant Palai <spalai@redhat.com>
Date: Sun Jun 1 04:37:22 2014 -0400
Rebalance: Avoid setting other component's xattrs
Problem 1:
In "gf_defrag_handle_hardlink" we used to do setxattr on internal
afr keys. Which lead to afr aborting the op saying "operation not
supported".
Solution : Sending a new xattr with only required keys.
Problem 2:
Hardlink migration tries to create linkto files for 2nd to (n-1)th
hardlink of a file on their respective hashed_subvolumes. It may so
happen that the linkto file already exists on the hashed subvolume
may be due to an earlier lookup or hashed subvolume on the older
graph is same as that on the new graph. Hence any new link call may
fail with EEXIST.
Solution: Will log the message with DEBUG level for EEXIST . Otherwise will
log with ERROR level.
Change-Id: I51f9bfc8cf5b9d8e94a9d614391662fddc0874d4
BUG: 1066798
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/7943
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b062b7e9f511062a1e10aa8185add5058d16c9ca
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Jun 4 19:53:50 2014 +0530
features/gfid-access: calloc gfid and set in xdata
Problem: the gfid passed to ga_fill_tmp_loc() was a stack variable which
the function set in the xdata dictionary. Accessing it in a later point
in time gave unexpected values.
This was easy to hit when AFR was involved like so:
ga_mknod()--->xxx-->afr_mknod():
In afr_mknod transaction, once the stack-winds for the lock-phase are sent,
the gfid in xdata becomes out of scope. When we send the actual op i.e.
afr_mknod_wind(), the gfid in xdata is stale, causing posix to set junk
gfids on the files.
Fix:
calloc the gfid and set it in the dict.
Thanks to Pranith for the RCA!
Change-Id: I0291fce34745268dc63095fc41fe31c7213dd5e1
BUG: 1104707
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7978
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 46d878257a13bb6cf98a4adb607522d8db8d27a8
Author: Vijaikumar M <vmallika@redhat.com>
Date: Thu Jun 5 13:26:22 2014 +0530
gluster: Set ping-timeout between glusterd peer rpc connection
With Patch# http://review.gluster.org/#/c/7753/, ping-timeout
got disabled between glusterd peer rpc connection.
This would create regression for bug#1034479
Change-Id: Ib7a756fce7d349ce5b7b4c6a287f2d040c83fc76
BUG: 1097224
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7989
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 3c722bcb6b86109b727d399415e621f884b437dd
Author: Kaushal M <kaushal@redhat.com>
Date: Wed May 28 16:57:14 2014 +0530
glusterd: Preserve backward compatibility during sync and store
The glusterd volinfo struct gained several new members to support the
volume snapshot feature. These members are also being exported/imported
during volume sync and being stored/restored. This export/import and
save/restore explicitly required these members to be present, and would
fail if they were not. This lead to the failure of backward
compatibility, preventing new peers from correctly interacting with
older peers (especially during a rolling upgrade).
This patch contains changes needed to preserve the backward
compatibility in the places specified. The snapshot members of the
volinfo will now be exported/imported and stored only when the cluster
op-version is >= 4, ie. all peers in the cluster support snapshot.
No change is required for the restore code as, the new members will be
left at the default zero values if corresponding entries are absent in
the stored volinfo.
Change-Id: I79e4bc5780c991ec305b7b5e7d71c16afb6a4c40
BUG: 1101903
Reviewed-on: http://review.gluster.org/7944
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit bd5cf55ca5850a5ae344ef2ea2930fe6c4889c43
Author: Kotresh H R <khiremat@redhat.com>
Date: Sun May 25 23:41:48 2014 +0530
feature/geo-rep: Fix to retain pause state of gsyncd on restart.
A new gsyncd options '--pause-on-start' is introduced. When node
reboots, if the status is paused, gsyncd is started with this
option. After gsyncd spawns worker and agent, worker will send
SIGSTOP to negative pid of monitor to enter pause mode.
Change-Id: I5aad82c9a9fc8c243f384940b77d25e26e520d6d
BUG: 1101410
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7885
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 83d3d039c9e04e96f936bc0f2b0ec41e30060990
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Jun 2 14:11:29 2014 +0530
logging: Prior to log initialization, print all logs to syslog.
There can be calls to gf_msg even before caling logging_init().
Currently such messages appear on stderr. In this patch, gf_msg
is changed to log messages to syslog if the logging framework is
not inited.
Change-Id: I8fcf562f9d07b5b6b789fbd9e6f37b354de16b98
BUG: 1103623
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/7948
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f4e6bf11fc464cd0eb0f1cdb8a27f972fc334bed
Author: Vijaikumar M <vmallika@redhat.com>
Date: Fri May 23 14:42:08 2014 +0530
glusterd: Handle rpc_connect failure in the event handler
Currently rpc_connect calls the notification function on failure in the
same thread, glusterd notification holds the big_lock and
hence big_lock is released before rpc_connect
In snapshot creation, releasing the big-lock before completeing
operation can cause problem like deadlock or memory corruption.
Bricks are started as part of snapshot created operation.
brick_start releases the big_lock when doing brick_connect and this
might cause glusterd crash.
There is a similar issue in bug# 1088355.
Solution is let the event handler handle the failure than doing it in
the rpc_connect.
Change-Id: I088d44092ce845a07516c1d67abd02b220e08b38
BUG: 1101507
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7843
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 0065bcfe0dd5371f8c3d40da4b99e698edb8f9a0
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon May 26 10:35:45 2014 +0530
features/quota: unref and set priv->rpc_clnt to NULL once disabled.
Change-Id: Ic1a6bc36b26cf31f00644bd674b24daa11745e64
BUG: 1103636
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/7876
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8884dfaa638c27c4d6feef72bff3ca5b512c4973
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Fri May 23 20:04:35 2014 +0530
doc: Document libgfapi and its apis,usage,bindings..etc
Change-Id: I3435f9a88acafa905e879c68bb7aa8b16023cf02
BUG: 1086766
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Soumya k <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/7865
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 046182e8bc16e1c234d21715a44de17aa4066067
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed May 28 12:23:43 2014 +0000
glusterd/geo-rep: Not setting the user name as the user group by default
Also removing multiple mounts in gverify.sh
Change-Id: I1567a9f711222c5f571a12f7c4ab49cef32d60c9
BUG: 1101948
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7911
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 3249ba7801e0885920d2b1f6986af6070c43674c
Author: Sachin Pandit <spandit@redhat.com>
Date: Thu May 15 09:24:33 2014 +0530
cli/snapshot : Dont Do the validation of snapshot config limit in CLI code path.
Problem : If we try to set the volume snap limit to
more that 256, it always shows value cannot exceed 256,
irrespective of system max limit.
Solution : Dont do validation in CLI side.
Change-Id: I292c0bc91a1806cd4906fca0151dd98135e6e49a
BUG: 1098122
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7777
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit abab4f8aa6cd34f351a1bdb5c22607d686b708e9
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Jun 3 05:50:53 2014 +0530
glusterd/snapshot : Remove the barrier key from snap volinfo before generating brick volfile.
Problem : During snapshot creation if I/O is in progress,
then barrier value is enabled. Hence during snapshot create
and in-turn snapshot restore the barrier value is set to enable.
Because of this further I/O on the mount point fails.
Solution : Remove the barrier key from newly created snap volinfo
before generating the brick volfiles.
Change-Id: I180b3adfbb364159fd353b2d0fb630e004099aa5
BUG: 1098487
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7892
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit bddbe1f445c75a5492024c3ec4ec2ba219967e24
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri May 30 01:07:04 2014 -0700
build: Avoid gcc pragmas when clang is enabled
Change-Id: I86544a9bfd24ef1a69315c0f6c3abcdd9aeb2c69
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7932
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d1864bbd51c4e5f232b2b4a5c3a25416e4f36af0
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jun 3 11:55:49 2014 +0530
mgmt/glusterd: return proper value upon quorum failure in snapshot create
Change-Id: I5474a7cdf03236121bef383955ab403e945cd7ae
BUG: 1101561
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7961
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit f31fc4608d1128e6b3ee98c2240c15bfeb66f963
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Apr 1 09:20:05 2014 +0530
glusterd/status : First fetch the snapcount and then send the rpc call for individual snapshots for snapshot status
Problem :
Initially, we used to do all the calculation in the
glusterd side, once all the information related to
snap was fetched, it was aggregated into one
dictionary and that was sent back to CLI. Problem
with this approach was, when number of snapshots
are very high then CLI will timeout.
Solution:
First fetch snapcount and snapname from glusterd,
then make a individual calls using the snapname
fetched. This will resolve the timeout problem.
Change-Id: I32609b3898ed227c804dd4d8ee4516f081240756
BUG: 1087676
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7456
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 46566e66c539bee80935e2b1b9d6b1d11146756a
Author: Varun Shastry <vshastry@redhat.com>
Date: Tue May 6 12:39:20 2014 +0000
glusterd: Changes to provide interface for USS
The changes which consists of the translators for the USS (User Servicable
Snapshots) is submitted as a separate patch. Current patch provides the
CLI access to the feature.
Change-Id: I6b98a42fcfa82f0870d8048fe0bb53141565e9c6
BUG: 1094815
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/7705
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 93d93cea81a855841bf8f1c2179a009e339925a3
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jun 2 12:54:52 2014 +0530
snapview-server: use telldir api to get the offset of the dentry
* dirent structure (struct dirent) in NetBSD does not contain the offset
member. Direct access of offset from struct dirent (used here to copy
its contents to gf_dirent_t structure after making readdir call) causes
glusterfs build failures on NetBSD. So like posix does, use telldir api
to get the offset of the dentry (in this case glfs_telldir).
Change-Id: I72472c16cbf55dd99ea80ba982b0a4205e6ebffb
BUG: 1103591
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7946
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c05b57c7c3430f09fa284686733b152e7f0ea31b
Author: Meghana M <mmadhusu@redhat.com>
Date: Tue May 27 16:01:17 2014 +0530
Hooks/nfs-ganesha:Change the hook script to enable new function signature of add export.
Minor changes in the hook script to avoid some
possible confusion when volume set options are used.
Adding a few additional checks to ensure correct behaviour.
Edited a few config parameters that have changed in upstream
ganesha recently.
Change-Id: I85b842cbbd4b35b7f72f3beb60abf6532ddaa8c7
BUG: 1101416
Signed-off-by: Meghana M <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/7890
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 166a04dcc0a03c44c9f51650c228115271677ce8
Author: Poornima G <pgurusid@redhat.com>
Date: Fri May 23 12:58:56 2014 +0530
glfs_fini: Fix a possible hang in glfs_fini.
glfs_fini is called when there is a failure in glfs_new,
glfs_init etc. If an application sees a failure in glfs_new
and calls glfs_fini, it will result in hang in glfs_fini.
Fixed the hang.
Change-Id: I80b52cd76d1d7f3fe9a10a91b7226d54176a8982
BUG: 1091335
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/7857
Reviewed-by: soumya k <skoduri@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit dc46a8c39c4648272cb72e852b1a1395cfe26713
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu May 29 11:59:30 2014 +0000
glusterd: Fetching the txn_id before performing glusterd_op_bricks_select in glusterd_brick_op()
In glusterd_brick_op(), the txn_id mut be fetched before
failing the transaction for any other reason. Moving
the fetching of txn_id to the beginning of the function.
Also initializing txn_id to priv->global_txn_id where it
wasn't initialized.
Change-Id: I44d7daa444f00a626f24670c92324725f6c5fb35
BUG: 1102656
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7926
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit efe97d34e60804a819c47bad58869c89e929ad99
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed May 21 05:45:39 2014 +0200
NetBSD qemu build fixes
Fix NetBSD build for glusterfs built in qmeu sources
BUG: 764655
Change-Id: I4428a88b1e0d7c5f6740022861ffe230dbbd84bd
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/7815
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3f0690df7703507309f12e13aa95fcfde6efed87
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed May 21 17:47:03 2014 +0530
cluster/dht: Fix min-free-disk calculations when quota-deem-statfs is on
PROBLEM:
As part of file creation, DHT sends a statfs call to all of its
sub-volumes and expects in return the local space consumption and
availability on each one of them. This information is used by DHT to
ensure that atleast min-free-disk amount of space is left on each
sub-volume in the event that there ARE other sub-volumes with more
space available.
But when quota-deem-statfs is enabled, quota xlator on every brick
unwinds the statfs call with volume-wide consumption of disk space.
This leads to miscalculation in min-free-disk algo, thereby misleading
DHT at some point, into thinking all sub-volumes have equal available
space, in which case DHT keeps sending new file creates to subvol-0,
causing it to become 100% full at some point although there ARE other
subvols with ample space available.
FIX:
The fix is to make quota_statfs() behave as if quota xlator weren't
enabled, thereby making every brick return only its local consumption
and disk space availability.
Change-Id: I211371a1eddb220037bd36a128973938ea8124c2
BUG: 1099890
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7845
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 39d2bd5c398e09e0534c33d535850bd7a52232a9
Author: Soumya Koduri <skoduri@redhat.com>
Date: Thu May 22 11:22:12 2014 +0530
libgfapi: Fixed few memory leaks in glfs_h_getxattr, glfs_h_setxattr calls. Also replaced the tabs with spaces in that entire file.
Change-Id: Iee6dc031d27fe8d26caf90736d4b2ac7bc8c5206
BUG: 1089414
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/7841
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bfbc7d9b8a3b9bbcd3000f75978085e5dff73723
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Sep 25 14:17:50 2013 +0530
afr-v1 documentation.
Change-Id: I0cb77e2e64492704f9fc016d9ba9872237664aa4
BUG: 1086781
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6574
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit cdb4f75f963c0a7db2d93ff2b34ac4de7f7250ce
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue May 27 17:46:08 2014 +0530
mgmt/glusterd: return failure when server quorum is not met
Change-Id: I0a7df141d01cf70da5aac9658b2a5a19f660dd3b
BUG: 1101561
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7894
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit b6e5ac2507f340a8b9036312b9e713c19c3980c9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun May 18 19:33:27 2014 +0530
storage/posix: Remove special handling of ENOTSUP for [f]setxattr.
Change-Id: I7df7b2263336af0abe5bc91c674f9401aff6c3e0
BUG: 1098794
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7788
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dc2aeaa5daa2d9116c554363740cec7270514bb2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu May 22 10:25:47 2014 +0530
cluster/afr: Add descriptions to message-ids.
Change-Id: I7ec2821c96d4cbff78b4959d9b07019896cc9a2c
BUG: 1075611
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7840
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 7869c9ba13b41b462d1ef65d82bc85f317150bcd
Author: Vijaikumar M <vmallika@redhat.com>
Date: Mon May 19 13:09:07 2014 +0530
cli: 'Snapshot Volume: yes/no' for volume info needs to be removed
With initial design where the snap volume used to be displayed in
gluster volume info,
we used "Snap Volume: yes/on" to distinguish the volume whether its a
snap volume or the original volume.
But with new design the snap volumes are not listed in the volume info,
hence this entry (snap volume:) doesn't make sense to show.
Change-Id: Ic5b9948bf4ef74e89a611742c74a8989cb406866
BUG: 1098910
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7794
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit c5337dc44447482657db843f2001ce1b74af8a16
Author: Vijaikumar M <vmallika@redhat.com>
Date: Tue May 20 12:25:47 2014 +0530
glusterd/snapshot: Use external umount for un-mounting snapshot
umount2 doesn't cleanup /etc/mtab entry after doing umount,
so use external umount command for un-mount operation.
Change-Id: I1a91a700433e2bf15dd21e6fcdd9da54441048d1
BUG: 1098084
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7775
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit a2f1492656478346a76d04ae6bbd5a883c200f5e
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Thu May 22 17:31:11 2014 +0530
doc: Add 'expose volume capabilities' details of bd-xlator
Change-Id: If7a89a36c2eca653e4fa7f59597ac8b03e4bc747
BUG: 1086749
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Bharata B Rao <bharata.rao@gmail.com>
Reviewed-on: http://review.gluster.org/7844
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 646760169816aaf293129e29be40e9120bccee94
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed May 28 21:56:02 2014 +0530
doc/rdmacm: fix formatting errors.
BUG: 1086743
Change-Id: I24798ef1e359dc2508d495e244151e93537b52a4
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/7914
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 2bf184a10a2c8586bd287d1addb9969918afad8c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed May 28 13:55:59 2014 -0400
features/glupy: GPLv2 or LGPLv3+ license
Change-Id: I1ce4735619ac03a81f6ed43bba27c9fbb25c4de1
BUG: 1102305
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/7917
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 651c3ebb776f7bffffea2812155726a542f301f4
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue May 27 05:30:29 2014 +0200
NetBSD build fix for gettext
NetBSD's gettext is in libintl, hence search it at configure time.
BUG: 764655
Change-Id: I651a74fe49c3f087fe135dab3453fd5b18b4268a
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/7880
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit aefe14957ef8f5fa634b6076708775cd4009ebb0
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed May 28 15:12:42 2014 +0530
doc: add readdir-ahead documentation
Change-Id: Ib6fc3c9b59b498bfe3fb3dfc23dca874bdc0d21d
BUG: 1086755
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/7903
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit f65eb942a68c05134f088a3e59ecb62842b4ee98
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu May 29 06:53:32 2014 +0000
tests/cluster.rc: Moving the glusterd logs for cluster testcases
Moving the glusterd logs for cluster testcases from /d/backends to
logdir.
Change-Id: I6f22ca0c2faa87b0774e718c6c26d6547afd7c51
BUG: 1102593
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7924
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b4e744989b9084edde425c923efff19f5145d198
Author: Poornima G <pgurusid@redhat.com>
Date: Thu May 22 16:46:15 2014 +0530
rpm: Rename old hookscripts in an RPM-standard way.
Change-Id: I5e47ac8af8033821787281574276f38933de73cf
BUG: 1100251
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/7362
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ccc1ee09e28ef368dc5773682240e375fec957fc
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed May 7 20:13:43 2014 +0530
user servicable snapshots
Change-Id: Idbf27dbe088e646a8ab81cedc5818413795895ea
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Anand Subramanian <anands@redhat.com>
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7700
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4033bca412719422dae3facef34f3a604b58e3eb
Author: Susant Palai <spalai@redhat.com>
Date: Fri May 9 00:39:10 2014 -0400
Posix/readdirp : Avoid filling wrong stat info for dentry in readdirp
Problem: Upon no entry found for a dentry, posix_readdirp_fill
used to fill the stat for the current entry with the
previous one.
Solution: Continue with other entries if lstat failed for current
one
Change-Id: Ic96b5900451ed6c8de59acf9fee2e116649d3cdb
BUG: 1096578
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/7733
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 398940090c0d722efe801e75283f406b9bff61d2
Author: Susant Palai <spalai@redhat.com>
Date: Wed Feb 19 05:47:07 2014 +0000
DHT: Wrong error handling in gf_defrag_migrate_data
Problem:
Because of the condition (err = op_errno), err was set to
zero always and ENOSPC error will be logged always. "dht_check_free_
space" was returning 1 and it was mapped to EPERM in "rebalance_task
_completion".
Solution: Changed the return value in dht_check_free_space to -1
as in rebalance_task_completion op_ret value -1 is mapped to ENOSPC.
And fixed the wrong error condition after syncop_setxattr in
gf_defrag_migrate_data.
Change-Id: I474ea1bef3b1e34c89814ed0091dd02bd5b63737
BUG: 1054703
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/6727
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ecd6652dc40968a1333414293f4d58424bbddd07
Author: Susant Palai <spalai@redhat.com>
Date: Wed Mar 19 17:22:10 2014 +0000
DHT/Mkdir: Fail mkdir with ENOENT, if parent is not available
Change-Id: I54227bcafb6d0d8cf716a679d2a34be7fc916898
BUG: 1078847
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/7306
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b7a83036a55a1dde4e4cbcc23dddaf02f3f2e8a3
Author: Kotresh H R <khiremat@redhat.com>
Date: Fri May 23 15:43:25 2014 +0530
feature/gfid-access: Adding documentation
Adding documentation to feature 'gfid-access' translator.
Change-Id: Ib70c0957ea22580cef2c7219a31dd9df33e9cd37
BUG: 1086751
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7862
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 744c2817ad3989f1c539bad336e6a6f0523dae86
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed May 28 14:37:18 2014 +0530
transport/rdma: Add rdma connection manager documentation
Change-Id: I15ad9cafbe607074ddb9b36f9e879c8421f6eae2
BUG: 1086743
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/7901
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 026670a0b4b0ba96bf382d5f3da2cb70e4484aa4
Author: Susant Palai <spalai@redhat.com>
Date: Tue May 27 01:29:38 2014 -0400
doc: quota-scalability documentation
Change-Id: Ia6516293a7d6dc2643bb05767875b0cb651a65ef
BUG: 1086754
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/7882
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 5927b29940e7ad144e1911b03e75d631fdda0b53
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu May 15 11:50:53 2014 +0530
cluster/afr: Don't support heal info healed/heal-failed commands
Change-Id: Iecfd3150e4f4e795e3403bcb1ac56340759a37d0
BUG: 1098027
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7766
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 100906935f369f618679fe295bf4f845c78c3d4c
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed May 21 13:30:02 2014 -0700
features/changelog: NULL termination after memcpy should be of dest pointer
snippet code
<
..memcpy (bufff, src, len - 1);
..*(src + len) = '\0'; ---> Wrong!
>
Source buffer lvalue() referencing with offset style NULL
termination is wrong and unnecessary when we have a destination
buffer, it is the destination buffer which should look to be NULL
terminated
Makes it more readable and also clearly logical.
<
..memcpy (bufff, src, len - 1);
..bufff[len -1] = '\0'; ---> Correct!
>
Change-Id: I6d7f312aaa5c541f0345649ff1ef9f193892b674
BUG: 1099986
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7836
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit b77397294645b54c5c60fa5f9a747457de554e7d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue May 20 19:18:31 2014 +0530
tests: Run prove in UTC timezone
This will make it easy in finding the relevant logs easy.
Change-Id: I9ac9988327ea28c20477655df9c9f606fd7d6c8e
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7810
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit da66d6694d040889324ad19adda488ae2859886d
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu May 22 14:18:39 2014 +0000
glusterd/snapshot: Invoke restore cleanup for missed restores
While performing missed restores invoke restore cleanup,
to cleanup the snap file (from which the vol was restored)
and also the old volinfo and if the old volume is a
restored volume, then its lvm too.
Change-Id: Ifa5700c69f49fa0e22e0060a039c2e5c0b02b585
BUG: 1100324
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7848
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 1265b5dee423b65875068f5590cd3e430bac2474
Author: Kasturi Narra <knarra@redhat.com>
Date: Fri May 23 19:52:10 2014 +0530
doc:Adding documentation for glusterfs and ovirt integration
Change-Id: Ie3b42a74198150c7e353d360ad38ac127d1a5ca2
BUG: 1086782
Signed-off-by: Kasturi Narra <knarra@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/7772
Reviewed-by: Sahina Bose <sabose@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Shubhendu Tripathi <shtripat@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 29cb7e66657796e852a79440fd82a4ffca162f77
Author: Susant Palai <spalai@redhat.com>
Date: Mon May 12 01:55:15 2014 -0400
Glusterd/Rebalance: Update rebalance status properly in node_state.info
credit: kaushal@redhat.com
spalai@redhat.com
Change-Id: I08d0771e2168a4a6ebd473e8a937b8b2eda1341a
BUG: 1075087
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/7214
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 7d7136dcf1031e703ab96268a93e0384904f7672
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Mon May 26 16:52:39 2014 +0530
doc: update details about posix acl on nfs mount
Change-Id: I591f2393a11893c77990a5b994196cb0a01358aa
BUG: 1086774
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/7871
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit f7f2ea2b6c91e4bd452f830f97753cf9c2dca844
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed May 21 20:49:22 2014 +0530
gsyncd : Use --remote-host option during cli invocation
Required for unprivileged geo-replication sessions to
execute glusterd commands (which are however restricted).
Change-Id: Ib83b81defa061717f4465ffa665450d0f5d3d20d
BUG: 1077452
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/7833
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fdbd780241fcc5892f3f9eec5c1106935ef64f1b
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed May 21 14:18:06 2014 +0530
gsyncd / geo-rep: Mountbroker cli to use INET sockets
unprivileged geo-replication session runs the slave gsyncd
process as unprivileged, thereby executing gluster cli commands
as an unprivileged user. By default, cli to glusterd
uses unix domain sockets, thereby restricting cli command
execution by non root users.
This patch introduces '--remote-host' cli option to force
cli to use INET socket. For this to work, the following
needs to be added in glusterd volfile
option rpc-auth-allow-insecure on
Change-Id: I84b1711281bbcbde156200f80ebdb065afb55488
BUG: 1077452
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/7820
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c479429e3f73067930c1284f6b91b48dbd55eb6b
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed May 21 11:54:24 2014 +0530
gsyncd / geo-rep: fix cli query for volinfo fetch
With an unprivileged geo-replication session, monitor
was using user@slave for --remote-host option for gluster
cli, thereby failing to sucessfully connect to the slave
glusterd.
This patch fixes the issue by selecting the hostname/IP
from the speicified slave endpoint url.
- For privileged geo-replication sessions, this patch
has no effect as the slave endpoint url is just the
hostname/IP.
Change-Id: I88f66c406a8d9a34db7fc626965f949075e3ceac
BUG: 1077452
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/7818
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c87d7211a6972f3f2773b983310f8de5dd740d96
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue May 20 19:57:37 2014 +0530
mgmt/glusterd: Allow mount/umount requests over AF_INET
Along with a simple naming convention change to avoid
confusion as per below.
s/gd_svc_cli_prog_ro/gd_svc_cli_trusted_progs/
s/gd_svc_cli_actors_ro/gd_svc_cli_trusted_actors/
Change-Id: Ibc73d88846636656f060a811f641f37a1a864615
BUG: 1077452
Original-Author: Vijay Bellur <vbellur@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/7821
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fa55fa6ff5a4a6ac781cea61af3c837b9b4f470d
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue May 20 14:50:25 2014 +0000
glusterd/geo-rep: Creating .ssh dir with right ownership
Also adding -P option to the usage of df for portability in gverify.sh
Change-Id: I0be19d26ea63769a934c6ccbfc04ef80768ebc9a
BUG: 1099041
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7812
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
commit 87ef484b50c0063ff914ac02fdbe5117f07d31db
Author: Anand Avati <avati@redhat.com>
Date: Sun May 18 11:40:27 2014 -0700
meta: fix compile warning
Change-Id: Ic346458b0e7264469d617b8313d4087b4b21c4b8
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7789
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 5361361168e00864462c58ae45907b08a7687124
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 23 13:06:26 2014 +0530
libglusterfs: Fix unused variable warning
Change-Id: If385ba0993fdbd3e3b7500b2b6631721911e0ab3
BUG: 1100144
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7858
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 07f2cf31112a3fdc8db837d0a5f80460fd624fcb
Author: Nithya Balachandran <nbalacha@redhat.com>
Date: Tue May 13 10:48:39 2014 +0530
Doc: Indentation fix for Gluster man page
Corrected the indentation for the Log Commands section
Change-Id: I9c706bc727d67e4ae3bde4d2556b3ffcd920ceeb
BUG: 1097051
Signed-off-by: Nithya Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/7746
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 679299b6616aa01f1a5b7404acf4ddd36800f2d8
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri May 23 10:18:35 2014 +0530
doc: fix brick port ranges in admin guide.
Change-Id: Ie6ac43ea435b7b21ac2b7975cbfe38126b170100
BUG: 1095595
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/7855
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 8ea8397e5affebc72b11f21b7b288016296de7c1
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri May 23 14:13:57 2014 +0530
doc: distributed geo-replication
Change-Id: Id89089aa52066634e8a6428c2bf00ea4f30f1943
BUG: 1086758
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/7859
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit eb6cc626fbbf4cb33ee71d5b034286da8c313de0
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu May 22 14:31:13 2014 +0000
glusterd/vol_locks: Dereference ctx->dict, only if ctx != NULL
Change-Id: I7f753aff197fe08fad255fc75d7f88d2a4632de8
BUG: 1100325
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7849
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b41143dde6af14e702363efa7ea31c824558cc65
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 21 17:15:34 2014 +0530
encryption/crypt: Don't perform open on symlinks
Change-Id: I9be8634f8f3b09def21ba977050330aa3f26c230
BUG: 1099858
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7824
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b22a321aa107e998d49f6cae6c500db33e8520c4
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri May 23 10:55:33 2014 +0530
doc: changelog consumer library
Change-Id: I1e641e1a61b78c84ed610a56eabdad1075865cd3
BUG: 1086758
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/7856
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit 717e999d0713e25a7edcd2fe30845bb00556426c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 21 22:37:13 2014 +0530
libglusterfs: Provide a way to disable mempool effects
Problems:
- Mempool comes in the way of debugging mem-leaks/corruptions
because tools like valgrind can't detect mem-pools.
- Accessing freed pointers may crash only when the mem-pool
is completely exhausted.
Solution:
In DEBUG builds set mempool count to 0 irrespective of the
pool size requested. This should help in debugging
memory-leaks/corruptions.
Change-Id: I7c6a2d696e330f12acff57ebdc589cc150e9ab79
BUG: 1100144
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7835
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c73164eae7cdebdfbe36ff79368816c97c09f2a0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 21 15:17:23 2014 +0530
storage/posix: Don't allow open on symlink
Change-Id: Ie38ecad621d5cb351c607c9676814c573834cb0b
BUG: 1099858
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7823
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1cd2b025ff0815ea63a7d360316cc90897cbbbe8
Author: Varun Shastry <vshastry@redhat.com>
Date: Sun Mar 23 13:28:36 2014 +0530
features/quota: Send the immediate parent with limit in quota statfs adjustment
Problem:
Assume the directory structure /quota_limit_dir/subdir and quota_limit_dir is
set with some limit. When quota-deem-statfs is enabled the output of
'df /quota_limit_dir' would display quota modified values wrt to
quota_limit_dir where as 'df /quota_limit_subdir/subdir' would display the
quota modified values wrt volume root (/).
This behaviour is not expected since, when mounted with subdirectory admin
doesn't want users to know information above the subdirectory mounted.
Solution:
Any subdirectory within a quota_limit_dir would show the modified values as in
the /quota_limit_dir. It searches for the nearest parent that has quota limit
set and modifies the statvfs wrt that.
Change-Id: Ie10fae8999bddbb766b1dbeb881723ed80dce688
BUG: 1080296
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/7330
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 84d8fc019637ac06b47d7df18c97938cdac22190
Author: Vijaikumar M <vmallika@redhat.com>
Date: Thu May 22 11:58:06 2014 +0530
glusterd/snapshot: brick_start shouldn't be done from child thread
When creating a volume snapshot, the back-end operation 'taking a
lvm_snapshot and starting brick' for the each brick
are executed in parallel using synctask framework.
brick_start was releasing a big_lock with brick_connect and does a lock
again.
This will cause a deadlock in some race condition where main-thread waiting
for one of the synctask thread to finish and
synctask-thread waiting for the big_lock.
Solution is not to start_brick from from synctask
Change-Id: Iaaf0be3070fb71e63c2de8fc2938d2b77d40057d
BUG: 1100218
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7842
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 7fc451ea8c6ef8fe24c3ce926639aca55275f161
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu May 8 12:30:23 2014 -0300
logging: remove unused message-id scripts
The current unused implementation for message-ids in the logs depends on
automatically generated files. The generated files are not included in
the distributed tarball. This causes issues when distributions build
packages, they need to re-run ./autogen.sh to create the needed files.
I thought of including the generated files in the distribution tarball.
However, the contents of these files are not actively used, so it seems
to make more sense to drop it all together. These functions were the
only users of libintl and gettext too, so dropped the requirement
checking from configure.ac.
A replacement for the message-id logging framework is in progress. Any
changes that this patch makes, can be reverted in the submission of
patches for the new framework.
Reference: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6212
Change-Id: Iea82dd3910944a5c6be3ee393806eccabd575e11
BUG: 1038391
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7714
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 98cf6742a836a4f8adf15fc6e2bed6b01031048c
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Wed May 21 21:56:54 2014 +0530
doc: Add details on qemu glusterfs integration
Change-Id: Ib3cd71f278c29483a467ee5afdd1aeb9e5f54547
BUG: 1086783
Signed-off-by: Bharata B Rao <bharata.rao@gmail.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Satheesaran S <satheesaran@gmail.com>
Reviewed-on: http://review.gluster.org/7834
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit de5d05c6ca946341496de884585a52cf5afd92f8
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon May 19 09:25:34 2014 +0200
tests/rpm: always run ./autogen.sh to create missing files
In some occasions 'install-sh' seems to be missing in the 'make dist'
tarball when ./autogen.sh has not been run (skipped when 'configure'
exists). With this changes, 'autogen.sh' is always run so that missing
files should get added to the tarball.
Also write the logs from mock to a known location, and copy them to the
'/var/log/' directory that Jenkins archives after a regression test
failure. This makes it easier to find build issues that mock detects.
Change-Id: I8d0cf1afef61ebab0137aa0d20521e75a35ddbdd
BUG: 1038391
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7786
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0c815f79e72b4de2b1910c6f1cb800534f84f178
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu May 22 05:53:02 2014 +0530
tests: s/timeout/EXPECT_WITHIN/
Also fixed nfs.rc so that regression build works on my fedora VM
Change-Id: Ife36343bf1a590430e24065b9bcdf5bed3ae546d
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7837
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a438374581db470acf07b6bdeb359baab0a4924b
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Tue May 20 17:49:11 2014 +0530
doc: Add block device xlator details
Change-Id: I4c24a7f0a4339364a80e5d1be0fc8de6b9c189c1
BUG: 1086762
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/7809
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d9f8504b8ebb4cafaed64a948c97cc0246df36a9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue May 20 20:38:18 2014 +0530
Tests: Umount nfs mount before volume stop
Change-Id: Ia1b98ee56bfa562c3f97f1649699f49917ebbfc7
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7813
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit be4c84e6861de182ed567aee293fc68017174822
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue May 20 19:50:10 2014 +0530
doc: afr-statistics command documentation
Change-Id: I44ae593c319a3ad2f724e1d8e9557d94c4200765
BUG: 1086748
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/7791
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 4e4447bb4cad0b89a1ab9fa9706ba3cdcb61e4cd
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon May 19 11:55:34 2014 +0000
glusterd/geo-rep: Use getent passwd instead of $HOME
$HOME might not be set in the env variables, as is the case
when these scripts are executed using the runner framework.
Hence using getent passwd instead of $HOME
Change-Id: I99f6bcd788d727be534b3040600d66c8dbb7ee92
BUG: 1099041
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7803
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 40c0130741fd46832c8d254bc0db41dc7f6d89bc
Author: Humble Chirammal <hchiramm@redhat.com>
Date: Mon May 19 17:11:47 2014 +0530
doc: zerofill api documentation
Change-Id: I437735d68fdcc4a55f12fd51b1d40cd7a32ad783
BUG: 1086756
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/7800
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 15b4d2f726cb061d2e39bcf1f91ebeee3efc2a6c
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat May 17 16:26:34 2014 -0700
rpc: make sure we use relative path
In commit "618d465295df02ae6d53be1327947a210bb8b47d" we made
change regarding NetBSD make by replacing `$<`, fix it
accordingly.
Change-Id: Ief82887253ede8216efd0ae7d5f73329f1492846
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7787
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Justin Clift <justin@gluster.org>
commit 850f6a8f10f7b2fc1e083de78c4f7efc9cfa1efd
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 19 13:29:06 2014 +0530
tests: Use uniform timeouts
Change-Id: I479ab941b3b2da3b16f624400fbd300f08326268
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7799
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0e3636c63ee5f3cb0211702a3489812678549bd7
Author: Vijaikumar M <vmallika@redhat.com>
Date: Tue May 13 17:36:01 2014 +0530
glusterd: Disable ping-timer between glusterd and brick process
When there are too many IO happening, brick process epoll thread
will be busy and fails to respond to the glusterd pick packet within
30sec.
Also epoll thread can be blocked by a big-lock.
Solution is to disable ping-timer by default and only enable where ever
required
Later when the epoll thread model changed and made lighter,
we need to revert back this change. http://review.gluster.com/3842 is
one such approach.
Change-Id: I7f80ad3eb00f7d9c4d4527305932f7cf4920e73f
BUG: 1097224
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7753
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c2a4b72ba77b268c7b430edf5d1f9f4b19fa92ee
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Fri May 9 15:01:19 2014 +0530
rpcsvc: Validate RPC procedure number before fetch
While accessing the procedures of given RPC program in,
rpcsvc_get_program_vector_sizer(), It was not checking boundary
conditions which would cause buffer overflow and subsequently SEGV.
Make sure rpcsvc_actor_t arrays have numactors number of actors.
FIX:
Validate the RPC procedure number before fetching the actor.
Special Thanks to: Murray Ketchion, Grant Byers
Change-Id: I8b5abd406d47fab8fca65b3beb73cdfe8cd85b72
BUG: 1096020
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/7726
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 54c610b49df6cdaa94e49eec5ec5ceb97a2f88df
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue May 13 17:42:14 2014 -0700
api: non glibc c++ systems do not define __THROW
Let __THROW be defined conditionally for more portability
Change-Id: I6e7cb1eb59b84988e155e9a8b696e842b7ff8f7f
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7757
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f909f7edff10c6dd1b9da7210a8a34a4266a8c8e
Author: Anand Avati <avati@redhat.com>
Date: Fri May 16 21:31:02 2014 -0700
meta: add .file_write method into meta_ops
Add .file_write method in meta_ops and make write support into
virtual files (like loglevel, measure_latency) much simpler.
Change-Id: I812f782f645605c56f81b158bb0f289b3c8f909a
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7785
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c0b78cf4e724a85e82c5a4b695204029f7e5bc6e
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri May 16 16:58:20 2014 +0200
NetBSD build fixes
- Shell scripts: == is specific to bash and ksh. Use = instead.
- Shell scripts: use sh instead of bash if bash functionnality is not used
- Shell scripts: ${var/search/replace} is specific to bash
- sed: The -i option is specific to GNU sed.
- Makefiles: $< outside of generic rules only work in GNU make.
- xdrproc_t() is not universally defined as variadic. Do not specify third
argument if it is not used
- NetBSD FUSE specific: only include <perfuse.h> in FUSE client code,
it harms in other locations
- configure: Search for gettext() in libintl as NetBSD stores it there
- Like MacOS X, NetBSD has unmount(2) and not umount(2) (un vs u)
Some other build issues previously included in this change were
removed:
- __THROW macro, addressed in http://review.gluster.com/#/c/7757/
- getmntent() compat shared with MacOS X, in http://review.gluster.com/#/c/7722/
This patchset adds warning fixes for mount_glusterfs
BUG: 764655
Change-Id: I2f1faf8ff96362d3e2baf237b943df619011f1f4
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/7783
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
commit 24157279279246be0f6082e6f645bcd62d07688f
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu May 15 00:15:52 2014 -0700
contrib: Cross platform fixes after recent commits
- provide a getment_r () version which behaves as
re-entrant with some caveats for NetBSD/OSX specific.
- some apparent warning issues fixed, always use PRI* format
specification avoid using %ld i.e not portable
Change-Id: Ib3d1a73b426e38b436b356355b97db0104a1a4a5
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7722
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 01ffd6e8e33ccda1a915eed10cf5784747448087
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri May 16 15:41:33 2014 +0530
cluster/afr: move messages to new logging framework
Change important (from a diagnostics point of view) log messages to use
the gf_msg() framework.
Change-Id: I0a58184bbb78989db149e67f07c140a21c781bc2
BUG: 1075611
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7784
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 7ebbe71c5edb23dd58e3a614389a5dd5ce17a057
Author: Meghana <mmadhusu@redhat.com>
Date: Mon May 12 12:26:18 2014 +0000
Hooks:Modified S31ganesha-set.sh to enable dynamic exports via NFS-ganesha
Dbus signals have to be sent to add and remove exports on the fly,
without restarting nfs-ganesha server. Adding those signals in
the hook script to enable the same.
Adding another to check to enable IP modification,
without restarting nfs-ganesha.Adding checks to find the
configuration file in /etc/glusterfs-ganesha.
Removing nested volume set options. This introduces
some issues that will be documented clearly.
Signed-off-by: Meghana <mmadhusu@redhat.com>
Change-Id: I28f7983f2d18529dc813ddc9773b33c6caee1ad4
BUG: 1095656
Signed-off-by: Meghana <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/7709
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 13a4fc75605dc619453ad64dbd53274bcde5e9b4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu May 15 14:40:16 2014 +0530
tests: Wait for nfs export to be available
Change-Id: I59a5e0cb78f2b670761a65272b8ab1d7bdb3668a
BUG: 1092850
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7773
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f7382b0fb78e982f8f505026a70f1868bdd2250c
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri May 2 13:55:59 2014 +0530
logging: Add extra logs to enable testing of log suppression
Note:
This patch may be reverted once the testing effort is complete,
if desired.
Change-Id: I840399c531a43049749073d4d59bc0c85f525be3
BUG: 1075611
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7681
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6a2e2027622443a43f2a0c87d92bd0fb214980ed
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 7 21:38:46 2014 +0530
protocol/client,server: Suppress ESTALE logs
Change-Id: I5c5e016138be2417eacf81812313dc854907fa47
BUG: 1095256
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7696
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 0147f7048a2bbef7e4ba6c87b31d88a4888c5154
Author: Kotresh H R <khiremat@redhat.com>
Date: Thu May 15 12:52:22 2014 +0530
gsyncd/geo-rep: Fix remote vol info fetching for non-root
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Change-Id: If1d2cab3fcfe2391105551e54f0b9729a7c204e4
BUG: 1077452
Reviewed-on: http://review.gluster.org/7767
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit bc2d03d7d1d964a74f4862213d6decff89d3a989
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed May 14 05:17:13 2014 +0000
glusterd/snapshot: Putting back the missed_snaps_list code
Setting of missed_snap_count was removed as part of an
earlier patch. Putting back the code.
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Change-Id: Ib6412d6100145e94d10f6f4a8a1fe4e645c1a69e
BUG: 1097725
Reviewed-on: http://review.gluster.org/7764
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit e55ad88e971cea57500132ca01adf828661d78ea
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon May 5 23:27:28 2014 +0000
glusterd: Differentiate snap-volume directories properly.
If /var/lib/glusterd is hosted on xfs system, the entry->d_type
not showing the correct d_type owes to the restore path prematurely
exiting. Hence checking entry->d_name to differntiate <snap-name>/info
file, missed_snaps_list file and the <snap-name>/geo-replication
directory, from the actual volume directories, without impacting
the gluster volumes.
Change-Id: I9a774a845282fe7cc697e37bbcf7c4545aee7678
BUG: 1094557
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7680
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit c639e76ba91007e945ec517e9b7bc78f7f498e8e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Apr 29 05:49:21 2014 +0530
cluster/afr: Fix bugs in quorum implementation
- Have common place to perform quorum fop wind check
- Check if fop succeeded in a way that matches quorum
to avoid marking changelog in split-brain.
BUG: 1066996
Change-Id: Ibc5b80e01dc206b2abbea2d29e26f3c60ff4f204
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7600
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
commit e9547fe55c12fc3761a5b229b9e9a80114fb18af
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Wed May 14 11:28:15 2014 +0530
libglusterfs: Use strncpy() instead of strcpy()
Use secure strncpy() to copy the input data to static buffer
and make sure to NULL terminate the copied buffer (if source
buffer is longer than static buffer).
Change-Id: If3564f1398c8eb92669d4bc92700bbdf6ee2278e
BUG: 1097417
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/7759
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit b36f4d9d2948c66a37c48b386d5fff632c26b50a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon May 12 00:06:32 2014 +0000
glusterd/geo-rep: Allow gverify.sh and S56glusterd-geo-rep-create-post.sh to operate for non-root privileged slave volume
Mounting the slave-volume on local node, to perform disk checks
in order to allow gverify.sh to operate for non-root privileged
slave volume
Allowing the hook script S56glusterd-geo-rep-create-post.sh
to operate for non-root privileged slave volume
Modified peer_add_secret_pub.in to accept username as argument
and add the pem keys to the users's_home_dir/.ssh/authorized_keys
Wrote set_geo_rep_pem_keys.sh which accepts username as argument
and copies the pem keys from the user's home directory to
$GLUSTERD_WORKING_DIR/geo-replication/ and then copies the keys
to other nodes in the cluster and add them to the respective
authorized keys. The script takes as argument the user name and
assumes that the user will be present in all the nodes in the
cluster. It is not needed for root.
To summarize:
For a privileged slave user, execute the following on master node as super user:
gluster system:: execute gsec_create
gluster volume geo-replication <master_vol> [root@]<slave_ip>::<slave_vol> create push_pem
For a non-privileged slave user execute the following on master node as super user:
gluster system:: execute gsec_create
gluster volume geo-replication <master_vol> <slave_user>@<slave_ip>::<slave_vol> create push_pem
then on the slave node execute the following as super user:
/usr/local/libexec/glusterfs/set_geo_rep_pem_keys.sh <slave_user>
BUG: 1077452
Change-Id: I88020968aa5b13a2c2ab86b1d6661b60071f6f5e
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7744
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 556a374836acb50ad27c0d067437d5acb76eb356
Author: Venky Shankar <vshankar@redhat.com>
Date: Sun May 4 01:34:08 2014 +0530
gsyncd / geo-rep: Partial support for Non-root geo-replication.
This patch enables geo-replication to be run as an unprivileged
user. As of now, this is just the partial support, but is very
close to achieve full functionality.
Current limitation
* Geo-replication executed Gluster CLI commands on the slave
via SSH. On a non-root setup, Gluster CLI would run as an
unprivileged user, failing to execute the command. As a
workaround (for testing), setuid(2) Gluster CLI executable
or use the glusterd option to accept commands by unprivileged
CLI process. The nature of cli commands are "system::"
commands (for key management) and remote volume info fetching.
Remote volume info fetching has been modified to use --remote-host
gluster cli option rather than ssh and remote cli execution.
Change-Id: Ica89e2ba9b7f48fd6e1c876c477d7822dc693617
BUG: 1077452
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/7658
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b891b823849e438f18061bc54ca611990ad762c1
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Feb 19 20:47:46 2014 +0530
features/changelog : historical journal consumption.
Facilitates Glusterfs with the ability to detect file-operations
happened in past by scanning the back-end(brick-level) glusterfs
journal (changelog).
Design:
* List of changelogs produces in one perfectly running session are
stored in htime file which also holds necessary information about
the session start and end time.
* Involves fixed sized seeks to identify N'th changelog in the list.
* Requires O(log n), (where n is number of changelogs in the list),
time to identify the end changelog for the given start-end time
interval.
Currently the background processing of changelogs is sub optimal. BZ
1097041 tracks the development effort.
For complete design, refer the below link:
http://lists.nongnu.org/archive/html/gluster-devel/2014-02/msg00206.html
Change-Id: I27e49f75e492e843084d0ecaf9130224d08462a0
BUG: 1091961
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/6930
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a3837cff33668c1dbab37879fb85d3d6cf8ff220
Author: Kaushal M <kaushal@redhat.com>
Date: Mon May 12 11:22:36 2014 +0530
glusterd: Allow setting volume options by default based on op-version
A new function glusterd_enable_default_options is introduced, which will
set some volume options on a volume based on op-version. This function
is called near the end of the volume create and will allow some options
to be enabled based on op-version on newly created volumes. This will
also be called during volume reset, to reset the options to their
default values if they had changed.
Change-Id: I91057d9e42409b17a884728b43ae3721328d4831
BUG: 1096616
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/7734
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 8ee3e636dcb6c20a54b827994e1f15564bf8b7e4
Author: Kotresh H R <khiremat@redhat.com>
Date: Fri May 2 13:09:03 2014 +0530
geo-rep/glusterd: Pause and Resume feature for geo-replication
This patch introduces pause and resume cli command
for geo-replication.
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Change-Id: I4f5e58e9175fe85077d56088473252391fb57de7
BUG: 1093602
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7643
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit e82a524c1bb67dbaed86197ad5e23017736f1a26
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon May 12 07:54:59 2014 +0530
glusterd/snapshot : Quorum check should not be made if we perform snapshot status command.
Problem : Snapshot status command used to fail as it used to
hit the quorum check path.
Solution : The condition checking where snapname is fetched
based on the presence of snap_volume is moved inside create
switch case.
And also moved the chunk of code which does the actual
quorum check to new function to make the code more
readable.
Change-Id: Idda2d7c576cdfab3a7d087bfa74bfa616372c20e
BUG: 1096700
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7737
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit b8c6bcdbc6b70bc42b65bd23c0229ca672de109a
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue May 13 11:56:50 2014 +0530
geo-rep: Changelog History API changes
Additional argument added to API gf_history_changelog,
actual_end - The end time till where changelogs are available.
Added sort to history_get_changes API output.
BUG: 1091961
Change-Id: Id043409882a83cd0a7b9adc3d34d5147d17e532e
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/7747
Reviewed-by: ajeet jha <ajha@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit ed82ec43f3d6fb856a38497186fe21ee3f93e294
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Apr 30 11:12:40 2014 +0530
glusterd : barrier enable/disable should fail if already enabled/disabled
In barrier notify function, if we fail to set the barrier option execution goes
to default_notify which returns 0 and command returns success.
Fix : We need not call the default_notify function when handling
GF_EVENT_TRANSLATOR_OP in barrier xlator's notify.
Change-Id: Ia2c361b43cca7791c29829d69dcd6fc7923102f6
BUG: 1092841
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7609
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 072fae8922121648165406a7a5e038be63895e13
Author: Kaushal M <kaushal@redhat.com>
Date: Wed May 7 18:17:11 2014 +0530
glusterd: On gaining quorum spawn_daemons in new thread
During startup, if a glusterd has peers, it waits till quorum is
obtained to spawn bricks and other services. If peers are not present,
the daemons are started during glusterd' startup itself.
The spawning of daemons as a quorum action was done without using a
seperate thread, unlike the spawn on startup. Since, quotad was launched
using the blocking runner_run api, this leads to the thread being
blocked. The calling thread is almost always the epoll thread and this
leads to a deadlock. The runner_run call blocks the epoll thread waiting
for quotad to start, as a result glusterd cannot serve any requests. But
the startup of quotad is blocked as it cannot fetch the volfile from
glusterd.
The fix for this is to launch the spawn daemons task in a seperate
thread. This will free up the epoll thread and prevents the above
deadlock from happening.
Change-Id: Ife47b3591223cdfdfb2b4ea8dcd73e63f18e8749
BUG: 1095585
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/7703
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit b2d19a4a6c59cc93b4f4e35d09857470826c90b2
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed May 7 14:05:31 2014 +0530
libgfapi: Added support to fetch volume info from glusterd and store in glfs object.
Defined new APIs in the libgfapi module, given a glfs object,
* to send handshake RPC call to glusterd process to fetch UUID of the volume
* store it in the glusterfs_context linked to the glfs object.
* to parse UUID from its cannonical string format into 16-byte array
before sending it to the libgfapi users.
Defined a RPC call in glusterd which can be used to query volume related
info by other processes using 'clnt_handshake_procs'.
Note - Currently this RPC call to glusterd process is used only to fetch UUID.
But it can be extended to get other volume related structures as well.
In addition to the above, defined a new variable to keep track of such handshake
RPCs still in progress to make sure all the corresponding RPC callbacks have been
processed before libgfapi returns the glfs object initialized.
Also bumping up the GFAPI current version number since there is a new API
"glfs_get_volume_id" defined and exposed by libgfapi as part of these changes.
Change-Id: I303f76d7177d32d25bdb301b1dbcf5cd73f42807
BUG: 1090363
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/7218
Reviewed-by: Anand Avati <avati@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 58d2c7bdde51608494c7377f43005ea5c753c853
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Apr 17 18:32:07 2014 +0200
rpc: implement server.manage-gids for group resolving on the bricks
The new volume option 'server.manage-gids' can be enabled in
environments where a user belongs to more than the current absolute
maximum of 93 groups. This option triggers the following behavior:
1. The AUTH_GLUSTERFS structure sent by GlusterFS clients (fuse, nfs or
libgfapi) will contain only one (1) auxiliary group, instead of
a full list. This reduces network usage and prevents problems in
encoding the AUTH_GLUSTERFS structure which should fit in 400 bytes.
2. The single group in the RPC Calls received by the server is replaced
by resolving the groups server-side. Permission checks and similar in
lower xlators are applied against the full list of groups where the
user belongs to, and not the single auxiliary group that the client
sent.
Change-Id: I9e540de13e3022f8b63ff893ecba511129a47b91
BUG: 1053579
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7501
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9774f893574fe79ec905ccf59f21e6e0a9346f69
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue May 6 14:38:40 2014 -0700
tests: min-free-disk test was incomplete
- use '%' when we mean it for clarity
- in bash we need to evaluate counter decrements
Change-Id: Ibd17126945e8a335fa2671d658a2e0c71049fd1e
BUG: 874554
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7687
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a00ed8e784e4164cfc6b7080b939f8b9cc6cf8e5
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Apr 29 12:14:24 2014 +0530
geo-rep: Pause and Resume feature for geo-replication
Changelog consumption/processing now happens in seperate process
group than monitor. When monitor process group gets SIGSTOP all
worker process, ssh, rsync will be paused except the changelog
processing. When it gets SIGCONT it resumes its operation.
Changelog agent runs as RepceServer, geo-rep worker communicates
with changelog agent using RepceClient.
Change-Id: I35c333e4d8b13d03a7808aed601960eef23cfa04
BUG: 1093602
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/7322
commit 62200421e93e0f104286df4254c5fa1cc4a0afb7
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon May 5 11:04:00 2014 +0530
geo-rep: Changelog History consumption more fixes
Number of parallel threads to process changelog history
is made configurable via sync_jobs
Change-Id: Idcd8e655d9df540cfa48648b9e98af941f95e9d0
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/7660
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit b7af4a9876dbde88213df347d16312dda2322673
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu May 8 16:54:00 2014 +0530
geo-rep: Loading libgfchangelog.so only while running geo-rep
In source install, libgfchangelog is installed in /usr/local/lib
When glusterd runs /usr/local/libexec/glusterfs/python/gsyncd --version
it fails to find library without LD_LIBRARY_PATH.
This patch avoids loading library when it is run from glusterd
during start.
BUG: 1096026
Change-Id: I59912227ac27ff4877d947a7c8f1fe2e8c5be06e
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/7713
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 8c84699b94082e5a41f7f987fff27d95420f40fe
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Apr 29 00:14:54 2014 +0530
mgmt/glusterd: delete oldest snapshot upon exceeding soft-limit
Change-Id: I2d6ebae3ced1910f2dee43eeb9fc430e9f31073f
BUG: 1061685
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7587
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit fd4472f88f35b31a1a9b57753bc951844dfab360
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Mon May 5 14:34:55 2014 +0530
glusterd/snapshot: volume gets deleted if restore fails
If the restore command fails in pre-validate phase
then main volume gets deleted.
Fix: Perform cleanup only when pre-validate passes.
Change-Id: I7128c8582c3dd166a5683babb7e136ad0b56f0ac
BUG: 1061685
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/7665
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 46eeb20602cc889d9764b6fc06ad82007abcf66a
Author: Vijaikumar M <vmallika@redhat.com>
Date: Tue May 6 14:56:23 2014 +0530
glusterd/snapshot: Don't release big_lock before completing snapshot creation
Releasing the big-lock can cause problem like deadlock or memory
corruption.
Same happened with bug 1091926 where glusterd on node-2 entered a commit
phase and released a big-lock.
The originator node received timeout for the commit phase and
triggered a post-validate cleanup to the node-2.
Now node-2 continued to work with the object that are alreday cleaned-up
and resulted in a crash.
Solution is to not to release big-lock in the commit phase of snapshot
creation.
Change-Id: I571194fdb0b0ecc91bd13f2a9fc92fe4338d14dc
BUG: 1091926
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7579
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 75cb9527f12af396b8e0efa6d9ba700ed0682f0d
Author: Vijaikumar M <vmallika@redhat.com>
Date: Mon May 5 12:43:26 2014 +0530
glusterd/snapshot: Execute lvm snapshots in parallel
Back-end LVM Snapshot is executed parallely as synop task
This helps is gaining performance when there are more bricks in a
node.
This patch also removes unwanted logs printed in snapshot cleanup
Change-Id: I3174cb4547ebb670eca37a98eb9d75ecb0672a90
BUG: 1061685
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7461
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 80c362697d3eeb1decd7415028d20bb39b5ce2f0
Author: Vijaikumar M <vmallika@redhat.com>
Date: Tue May 6 14:32:28 2014 +0530
glusterd/snapshot: Add brick-count suffix for the LVM snapshot
When there are more than one brick created from the same LVM volume
group, there will be a conflict with the LVM snapshot name we use.
Solution is to add a brick-count suffix to the LVM snapshot name
Change-Id: I7258e69fe0b50e86b81c66ab1db523ab3c7cbae0
BUG: 1091934
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7581
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit f518fbd9a337d8ad0945959c105b1573c2033f64
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sun May 4 01:04:11 2014 -0700
runtime: Disable optimization for OSX versions < 10.9
Optimization flags has led to segfaults at wrong locations
throughout gluster code for versions < 10.9
Assuming this to be a compiler bug, disable optimization
flags
Change-Id: Ia2dc983dc5bb06935f03b68c07688ce41255d7da
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7656
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Justin Clift <justin@gluster.org>
commit 90deac9b680d02637ee408f38a3bb1a6283d1ff1
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed May 7 09:59:56 2014 +0530
Update Maintainers to reflect recent changes
Change-Id: I8dc3347d88942473810c2b4c9d52a69ecb6129e8
BUG: 1040351
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/7689
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
commit 363054d44aef261c6bedc54e2fd8ccee67b45d99
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 5 09:18:35 2014 +0530
cluster/afr: Remove stale index in self-heal codepath
Change-Id: I635fc0fa955b33590f1c5b4dfec22d591ea8575c
BUG: 1032894
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6592
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1a63bebc0a972e23e905aa4fb53cbfa6df448ade
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed May 7 18:03:34 2014 +0530
libgfchangelog: memory accounting intialization
Needed as memory accounting turned ON by default now.
Without this, GF_{CALLOC,MALLOC} calls assert.
Change-Id: Ie54a6efb61871e70d4f7c796d9c86a867051e2e0
BUG: 1094708
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/7698
Reviewed-by: Kotresh HR <khiremat@redhat.com>
commit 12053f8e4d99dadbd3bddbea67f4d00b6d054696
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 5 11:29:12 2014 +0530
mgmt/glusterd: Prevent spurious brick restarts
Change-Id: I7ee5d18b926d6c31e3e4ea2f5fbe9050c8e1dee8
BUG: 959986
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4954
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 6fdfc136fde67a2055a7b840d0065be2438de64d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon May 5 11:28:25 2014 +0530
mgmt/glusterd: Perform Pending quorum actions after Op
Change-Id: I2bb67b5fb4a6f6dac892ef3206e7a79706018a6e
BUG: 959986
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4955
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 6c8309a5304fd799673845cefc5062f70655caea
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue May 6 04:19:48 2014 +0000
glusterd: Use a calloc-ed copy of txn_id for glusterd_do_replace_brick
As glusterd_do_replace_brick() is spawned through gf_timer_call_after(),
by the time it's called the event is freed, and the txn_id is lost.
Hence using a calloc-ed copy, which will be freed as a part of rb_ctx
dict.
Change-Id: I3e309fe1a7ba96ad1d1ce01f4d2aa18178f59244
BUG: 1095097
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7686
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 78a396a895e012191664cc6ea1c42bdc0fc92d24
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Apr 14 11:24:12 2014 +0530
mgmt/glusterd: quorum check before taking the snapshot
without force option:
quorum fails if glusterds are not in quorum. If glusterd are in quorum, then
volume quorum (i.e quorum of the bricks) is checked. volume quorum fails even if
one of the bricks are down.
with force option:
even though the glusterds are not in quorum, and some bricks are down, the
quorum check of the volume (i.e bricks) is done and if the volume quorum is
met, snapshot is taken.
Change-Id: I06971e45d5cf09880032ef038bfe011e6c244268
BUG: 1061685
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7463
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 4462278e0316497b2342aeaee5bbc756bb45b077
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat May 3 14:52:11 2014 -0700
glusterd: NFS server wrongly started with `DEBUG` log-level
Disable DEBUG
Change-Id: I011231ba3df4a42f892f1305867bfc74bb101269
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7654
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit b8e640d156cc1acecd53335b78d52aca204df037
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue May 6 16:04:43 2014 +0530
gsyncd / geo-rep: Initialize default memory accounting
commit 7fba3a8 enables memory accounting by default. Since
geo-replication binary (gsyncd) does not declare a memory
accounting function, call like GF_{CALLOC,MALLOC} result
int asserts.
This patch initializes default memory accounting.
Change-Id: I9ad1de8bca6745a9899a006a863a7cfeef73d52f
BUG: 1094708
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/7683
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9a185730069ce107cd4b5c1044dad1c86fe1f018
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Sat May 3 12:52:44 2014 +0530
glusterd : Port glusterd sync log messages to gf_msg API
Change-Id: Ic3ed2c96d8fc3a15fedaa80517a2c79c0c858963
BUG: 1075611
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7652
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit d88c48dc1afdc75bdcc5f353d8d67afe8fbb8525
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri May 2 15:09:25 2014 +0530
glusterd: port network failure log messages to gf_msg API
Change-Id: I23df6d179e9d66a71721e9844a34c5b96586f90f
BUG: 1075611
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/7462
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 0cb143fec172a995b53cab1666a6e3ce48be37d7
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Apr 28 13:17:22 2014 +0530
glusterd: Port server quorum messages to the gf_msg API
Change-Id: I84716cc07f3cbd8c1b2825a5676d6693fed6fade
BUG: 1075611
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/7578
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 7f44ff602313d664999cda6810361a2f54c0142a
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon May 5 15:51:18 2014 +0530
rpc: don't stop sending ping packets to an active server.
- Removed an unnecessary ref on rpc_clnt object.
- Removed saved_frames_delete function, which was unused.
Change-Id: Ie8a9c4bb20c1fd59744b64b56eb043eca095e5e3
BUG: 1094655
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/7678
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
commit 618f7ba8fc5b13ef71bb37385a4ba897c4fb255c
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Apr 29 19:12:20 2014 +0530
glusterd: Allow bumping up the cluster op-version
This patch allows a user to bump up the cluster op-version by doing
# gluster volume set all cluster.op-version <OP-VERSION>
The op-version will be bumped only if
- all the peers in the cluster support it, and
- the new op-version is greater than the current cluster op-version
This set operation will not do any other change other than changing and
saving the cluster op-version in the glusterd.info file. It will NOT,
- change any existing volume
- add the option to the global options list
- fix the cluster op-version to the given version, it can be bumped up
by other volume set commands.
Change-Id: I084b4fcc45e79dc2ca7b7680d7bb371bb175af39
BUG: 1092592
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/7603
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit b6db42fee7d4f31b6c16b68db71c325ead53d186
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Apr 22 10:27:23 2014 +0000
glusterd/snashot: Perform missed snap creates
When a brick is started, and the glusterfsd process requests
for volfile, the brick_name is sent in the req dict. In
glusterd, after fetching the spec the brick_name is looked
up in the missed_snap_list, and any missing snap creates on
the same brick are performed. After this, the glusterd
responds back with the specfile.
Also collate brick data from the node's hosting the bricks
during restore. In case the data is absent, the local node's
data is used. This is needed to ensure that, during a restore
we collect the information created when a missed snap create
is performed.
Change-Id: I47cefdeba96f2702be810965734cf0fac61d3d2d
BUG: 1061685
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7551
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit fb18896088ffb3848274d7fbbab52675b7c6fe36
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Apr 23 04:26:24 2014 +0000
glusterd: Fetch brick mount_dirs during brick create.
Fetch the mount directory path for a brick, during
volume create, add-brick, and replace-brick.
When a snap-create is missed, use this mount directory
information to create the brick path for the missed snap brick.
Change-Id: Iad3eec96a32cf340f26bdf3f28e2f529e4b77e31
BUG: 1061685
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7550
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit a1b7a2645f412f597f2c11e58643e658fdd34a13
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat May 3 13:25:41 2014 -0700
meta: print in json for stack/frames, cmdline and version
- Follow formatting rules based on RFC4627 -
http://www.ietf.org/rfc/rfc4627.txt
- Add checks for json in regression test meta.t
Change-Id: I480d32ce042b202d3ed8939623c629a03b458551
BUG: 1089216
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7653
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 73d61ab32ec2c3e58f0d873617b7aabb6e3c45cd
Author: Anand Avati <avati@redhat.com>
Date: Sat Mar 29 06:01:36 2014 -0700
meta: export process state dump
Various parts of process state dump are exposed
through most appropriate virual files/dirs
Change-Id: Iff30f8ea76552f2f6d9c98def688c5ec4bc6f2af
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7542
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
commit eb418e10e55d1ff39ebcf3ad027e76a19336f4c2
Author: Anand Avati <avati@redhat.com>
Date: Wed Mar 26 11:52:53 2014 -0700
meta: (re-)Implement Meta translator
The meta translator exposes details about glusterfs itself
in the form of a virtual namespace.
Loading the translator on the client side creates the
meta virtual view under $mntpoint/.meta by default. The
directory is not listed (even with ls -a) and can be
accessed by doing a "cd /mnt/.meta"
Change-Id: I5ffdf39203841a9562a8280a1f79dc76d4dded5d
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7509
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
commit 145f46ed6fe466af7ac9b7e46e50dc04749f9daf
Author: Anand Avati <avati@redhat.com>
Date: Sat Mar 29 06:59:39 2014 -0700
mem-accounting: enable memory accounting by default
memory accounting are constant time operations which
involve a few pointer dereferences and integer increments
(no loops or searches etc.)
benefits of having memory usage info outweigh the minor
accounting overheads
Change-Id: If9bc6db5ffd0e00f0fd64b2f6eed094bf3543996
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7543
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
commit 30aaa9c08b72ac69b47d3087799b79c1b4570aaf
Author: Anand Avati <avati@redhat.com>
Date: Sat Mar 29 06:48:52 2014 -0700
mem-accounting: store type string and print in meta
Change-Id: Ied1de473c72967110b54f033768f7ac60bf66edc
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7541
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
commit a5d2719e550efe126b341eea4cdc2e2e8870ea9c
Author: Anand Avati <avati@redhat.com>
Date: Sat Mar 29 04:45:17 2014 -0700
statedump: strfd based APIs
Expose strfd based APIs for extracing various types of xlator
state information.
Change-Id: Ibbb6594b6fb31206bc6a1b1ea6514ed41889583b
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7540
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
commit 2c321d77523397576f3b8ca2b8ba26195ef87dab
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu May 1 10:29:54 2014 +0530
mgmt/gluster: Use fsync instead of O_SYNC
Glusterd uses O_SYNC to write to temp file then performs renames
to the actual file and performs fsync on parent directory. Until
this rename happens syncing writes to the file can be deferred.
In this patch O_SYNC open of temp file is removed and fsync of the
fd before rename is done.
Change-Id: Ie7da161b0daec845c7dcfab4154cc45c2f49d825
BUG: 908277
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7370
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 86b7e62805ff811833326a115ab5de077dce7eb0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 2 15:36:14 2014 +0530
glusterfs.spec: Add missing files in %files section
Thanks to Niels for all the help in finding RCA.
Change-Id: I5678c53a5c04de18ccd676fbaf5bf8b0c77c9c14
BUG: 1080970
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7645
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 89e8ede54d8a2f761896deee82ec49e2bb297e7f
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat May 3 16:17:04 2014 -0700
changelog: in C99 `inline` shouldn't be part of function definition
- C99 standard dictates that `inline` should be used only to hint
function implementation not as a definition
- http://clang.llvm.org/compatibility.html#inline
This also leads to run time issues as 'undefined symbols'
- Remember to use adding explicit headers when using an external
function
Change-Id: I66a9030da7ac38ded6e0b6a977182be977382fa2
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7655
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 34faf2d23231f6cfa245a1c9f91253fa65c51ca3
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat May 3 00:02:03 2014 -0700
glusterd/snapshot: umount2 on OSX/NetBSD is unmount
Change-Id: I8de4d47bb2a54b915243ea029cce2585fba34876
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7651
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Justin Clift <justin@gluster.org>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1dd44656811b47183b6a4bc50f9d19eea04c08dc
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Apr 25 01:26:30 2014 -0700
glusterd: Allow symlink parent for snap_mount_folder
If '/var' is a symlink which is on OSX, 'glusterd'
initialization fails which is not necessary fix it.
Change-Id: I83adc16cfc0e0deaa18acf74ba99299ba4a21d60
BUG: 1061685
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7558
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3a573624424c994360c813f9d2022ae5776daf3c
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Fri Apr 25 18:04:08 2014 +0530
protocol/server: Validate outstanding-rpc-limit
server.outstanding-rpc-limit by passes validation enforcement of gluster
as protocol/server ignores any keys starting with rpc (rpc* wildcard).
Which also causes a side effect, i.e. help text gets displayed as NULL.
Change-Id: I925e028529d671e1e29a0c7ff7e625fdb49a1be4
BUG: 1091364
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/7562
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b916ff74be023949154724f60c8c3fa32bdfecf2
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Tue Apr 8 17:10:25 2014 +0530
glusterd : Volname, brickpath & volfpath length validation
While creating a volume and adding a brick validation for _POSIX_PATH_MAX is
done on absolute pathname instead of relative pathname due to which a brickpath
having less than _POSIX_PATH_MAX may also fail the validation if the directory
length is greater than (_POSIX_PATH_MAX -strlen(brickpath/volume name).
Also this fix addresses one cli response message correction which says the
volume file is too long instead of brick path is too long (when brickpath
length validation doesn't fail and vol file length validation fails.)
It is also important to note that with the current design of volfile naming, it
can not be guranteed that volname and brickpath can have max of _POSIX_PATH_MAX
characters.
Change-Id: I1283d1f9dea96ae797620002c8723719f26a866d
BUG: 1085330
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7420
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4cd3f287abeede950c406fc902b67c86339c8c5f
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Apr 15 17:48:16 2014 +0530
mgmt/glusterd: handle postvalidate carefully when prevalidate fails
* Also changed the order of peers retrieval and snapshot retrieval
upon glusterd start, so that the snapshot bricks can be properly
resolved while cleaning up the snapshots.
Change-Id: I120704e4412a9cadb8d90a9b7969f2b4a1196bc5
BUG: 1061685
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/7494
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 205eefce740a945d45d3cfaa2c1692ddf9dd543a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu May 1 17:42:19 2014 +0530
barrier : fsync call over NFS should be barriered when barrier is enabled
barrier_fsync was not getting hit when fsync call is issued from the
application over NFS mount.
Investigation reveals that NFS doesn't send an explicit fsync call to the
glusterfs server, however NFS converts it with a stable write with O_DSYNC
flag, so for a fsync call over NFS mount point, barrier feature always
needs to check for writev and its correspoding flags. So to meet all the
coditions of write with O_SYNC and fsync getting blocked when barrier is
enabled the check has been modified with following:
if (!((flags | fd->flags) & (O_SYNC | O_DSYNC)))
Point to be noted here is we need to check both fd's flag and the explicit
flag as for NFS write fd->flags is 0.
Bug ID : 1091902
Change-Id: Ifd5377fca2cc93bb72158dd525b2aab8b4164ca8
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7633
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a1c43528534f696b8203e14c03989bc6f6563cc9
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Apr 23 17:21:41 2014 +0530
barrier : barrier O_SYNC write incorrect flag check
barrier_writev function was doing the following check to determine whether its a
O_SYNC write or not:
if (!(flags & O_SYNC))
The problem here is this flag is not fd's flag and gfapi write does not copy
open call fd's flag into write flag because of which O_SYNC writes were not
getting barriered even if barrier was enabled.
The check has been modified as:
if (!(fd->flags & (O_SYNC | O_DSYNC)))
Change-Id: I07b23852d150b81c7317100ca6d22d082ad897cd
BUG: 1090488
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7549
Reviewed-by: Varun Shastry <vshastry@redhat.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8e40f17ebfc0fe3170962f3a31bfc9eada59b02e
Author: Meghana M <mmadhusu@redhat.com>
Date: Mon Mar 24 13:58:38 2014 +0530
cli/hooks : Add volume set options to enable/disable nfs-ganesha support.
1. gluster volume set nfs-ganesha.enable ON/OFF
If the option is set to ON, the volume field in the nfs-ganesha configuartion file is
edited. Gluster-nfs is disabled on that volume and the volume is exported using
nfs-ganesha.
2.gluster volume set nfs-ganesha.host IP
This is used to provide the IP of the nfs-ganesha host.
Note : nfs-ganesha.host MUST be set before using nfs-ganesha.enable ON
The switch from gluster-nfs to nfs-ganesha is mostly done by the hook-scripts
in the post phase of the 'set' option. As a result, gluster volume reset does not
function as it is expected to. By default, nfs-ganesha will be set to off but the
process will not be killed.
Hence, a few changes have to be made post 'reset' option as well. Those changes
also have been added.
Change-Id: I7fdc14ee49d1724af96eda33c6a3ec08b1020788
BUG: 1092283
Signed-off-by: Meghana <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/7321
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 92c1e9bf1805f361c6d9a97e84f5e3a83d620f77
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Wed Apr 23 18:36:34 2014 +0530
glusterd/snapshot: Restore cleanup
If restores fails for some reason then we should revert
the restore operation. To do so we take the backup of
vols folder before doing a restore and if the restore
fails then we revert the changes done.
Change-Id: I97f72aec3a34fc122bf137beb336e94db3a04dff
BUG: 1061685
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/7548
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 03e0fbf4d60e76071846cb6e7a0480107eecb5b5
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Apr 29 14:28:29 2014 +0530
extras/hookscripts: Remove %P from smb share path value.
We had added %P in the value for path in smb share definitions to
avoid ctdb errors. However, %P does not work well for windows
clients and they fail to access the share.
Solution for the original problem:
The error messages were being generated by a monitoring script that ctdb
runs. The script reads the path value from testparm and tests if it exists
in the local machine. This particular check does not hold valid for
virtual file system backends like gluster. There is no harm in asking
ctdb to not to check the existence of such backend and can be done by
setting the following config in ctdb.conf:
CTDB_SAMBA_SKIP_SHARE_CHECK=YES.
Change-Id: I91627c8a279126a5cc24c6347847f9bfbad53dd5
BUG: 1068776
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/7598
Reviewed-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
commit 5ca59d55feef47c2deec532e6c17e9a45471b64e
Author: Xavier Hernandez <xhernandez@datalab.es>
Date: Thu May 23 11:13:25 2013 +0200
storage/posix: do not dereference gfid symlinks before posix_handle_mkdir_hashes()
Whenever a new directory is created, its corresponding gfid file must
also be created. This was done first calling MAKE_HANDLE_PATH() to get
the path of the gfid file, then calling posix_handle_mkdir_hashes() to
create the parent directories of the gfid, and finally creating the
soft-link.
In normal circumstances, the gfid we want to create won't exist and
MAKE_HANDLE_PATH() will return a simple path to the new gfid. However if
the volume is damaged and a self-heal is running, it is possible that we
try to create an already existing gfid. In this case, MAKE_HANDLE_PATH()
will return a path to the directory instead of the path to the gfid.
To solve this problem, every time a path to a gfid is needed, a call to
MAKE_HANDLE_ABSPATH() is made instead of the call to MAKE_HANDLE_PATH().
Change-Id: Ic319cc38c170434db8e86e2f89f0b8c28c0d611a
BUG: 859581
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/5075
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c96ab507e1f17f7e4791c6dc7f5f0f2a92956fa8
Author: ggarg <ggarg@redhat.com>
Date: Mon Apr 21 18:59:00 2014 +0530
glusterd: Differentiate rebalance status and remove-brick status messages
previously when user triggred 'gluster volume remove-brick VOLNAME
BRICK start' then command' gluster volume rebalance <volname> status'
showing output even user has not triggred "rebalance start" and when
user triggred 'gluster volume rebalance <volname> start' then command
'gluster volume remove-brick VOLNAME BRICK status' showing output even
user has not run rebalance start and remove brick start.
regression test failed in previous patch. file test/dht.rc and
test/bug/bug-973073 edited to avoid regression test failure.
now with this fix it will differentiate rebalance and remove-brick
status messages.
Signed-off-by: ggarg <ggarg@redhat.com>
Change-Id: I7f92ad247863b9f5fbc0887cc2ead07754bcfb4f
BUG: 1089668
Reviewed-on: http://review.gluster.org/7517
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f5f2320b9a45994cee38e759c4335cb01f6c629b
Author: Joseph Fernandes <josferna@redhat.com>
Date: Mon Apr 14 19:18:41 2014 +0530
glusterd/snapshot: Activation and De-activation of snapshot
Previously, snapshots by default were activated on creation and there was
no option to activate or deactivate them on demand.
This will allow the user to activate and deactivate on demand.
The CLI goes as follows
1) Activate the snap using a command "gluster snapshot activate <snapname> [force]"
2) Deactivate the snap using a command "gluster snapshot deactivate <snapname>"
Note: Even now the snapshot will be activated during creation.
Change-Id: I0946d800780f26c63fa1fcaf29aabc900140448f
BUG: 1061685
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/7476
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 44f73c19852b5a78b85c2470d45846d56330b9df
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Mon Apr 28 19:14:20 2014 +0530
glusterd/snapshot: Move read-only xlator to client graph
read-only xlator is moved from server graph to client graph
so that AFR & DHT healing can take place at server
Change-Id: I140ec962330c59d3b44f9bc8084a1544a1fd6c54
BUG: 1061685
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/7582
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c20d238a2ef2f77996b83414317ec54e4d02aef8
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Apr 14 14:51:28 2014 +0530
glusterd: avoid repetitive logging of disconnect messages
NFS/SHD process disconnecting from glusterd, when the respective service
are down, would lead to repeated logging of disconnect related messages,
owing to the rpc reconnect logic in glusterfs(d). This patch addresses
that by logging the disconnect only on the first disconnect event.
Change-Id: I4008d2436721f4ba093270df4ccb3fc885f22ca0
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/7468
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a40026894bd4f15053246758cb0cd1d1f87a81cd
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Apr 26 01:29:46 2014 -0700
scripts: CTDB lockvol ping-timeout should be 10secs
Users often forget to update the ping-timeout, perhaps
we should take care of this automatically
Change-Id: I6d14df8aa52665847233cb1760dfd54f41baadec
BUG: 1091600
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7569
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jose A. Rivera <jarrpa@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f63461b1841e6037510b27369faae036f99bfc4b
Author: Kotresh H R <khiremat@redhat.com>
Date: Fri May 2 09:48:31 2014 +0530
features/changelog: Fix to remove Warning message.
Fix warning message introduced in changelog
draining patch. It is not caught in gcc 4.4,
caught in gcc 4.8!!
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Change-Id: I01a8fda2102a409dd6e935805d4d48b41b615fe8
BUG: 1091817
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7636
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit cf4c206a877ba3f1057f371bd7a43a429033c7b0
Author: Sachin Pandit <spandit@redhat.com>
Date: Sat Apr 26 14:06:47 2014 +0530
glusterd/snapshot : Copy the quota config and cksum file before taking a snapshot
Quota config and cksum file needs to be copied before taking a
snapshot, so that when a snapshot is restored these files is
copied back to the original place, and the restored snap volume
can make use of these quota files.
Before taking a snapshot the quota files are copied to
/var/lib/glusterd/snaps/<snapname>/quota/
Change-Id: Id175f28d4ee47be64d7491c6aae81a1794928490
BUG: 1061685
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7527
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ed66b9cba896f986f9295b4fda72397e142ddaa6
Author: Sachin Pandit <spandit@redhat.com>
Date: Tue Apr 22 08:09:18 2014 +0530
glusterd/snapshot : Copy geo-rep status and config files before taking a snapshot.
geo-rep status and conf files needs to be copied before taking a snapshot.
The idea here is, when the snapshot is restored, these config and status
files needs to be placed back in geo-replication folder so that
geo-replication can start with the same state it was when taking
a snapshot.
Details :
Before a snapshot is taken, Copy the status and config files present
in /var/lib/glusterd/geo-replication/.
The files copied are gsyncd.conf and status files of each session
belonging to a volume whose snapshot is about to be taken.
Change-Id: I0234ecd846883350c59777c2505290729de0ce05
BUG: 1061685
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7495
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a2c0a7b1d5cf78611f3c0a0b9d253988bdf3f8f2
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jan 29 03:06:19 2014 +0000
glusterd/geo-rep: Looks for state_file and pid-file in gsyncd_template.conf
If entries like state_file or pid-file are missing in the gsyncd.conf
or if the gsyncd.conf is also missing, glusterd looks for the missing
configs in the gsyncd_template.conf
status will display "Config Corrupted" as long as the entry is missing in
the config file. Missing state-file entry in both config and template
will not allow starting a geo-rep session.
However stop force will successfully stop an already running session,
if the state-file entries are missing in both the config file and
the template, as long as either of them have a pid-file entry.
if the pid-file entry is missing in the gsyncd.conf file, starting a
geo-rep session will not be allowed.
if the pid-file entry is missing in an already started session, then
stop force will fetch it from the config template and stop the session.
if the pid-file entry is missing in both the config and the template,
stop force will fail with appropriate error stating pid-file entry is missing.
Change-Id: I81d7cbc4af085d82895bbef46ca732555aa5365d
BUG: 1059092
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/6856
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 480938c62d7fd635c58e67fd1a948fb85701e4c7
Author: Kotresh H R <khiremat@redhat.com>
Date: Tue Apr 8 13:50:30 2014 +0530
features/changelog: Barrier in changelog during snapshot.
Changelog barriers unlink, rename, rmdir fops on barrier 'on'
notification from glusterfsd mgmt layer and unbarriers the
same on barrier 'off' notification during snapshot.
Please see the following link for more details.
http://www.gluster.org/community/documentation/index.php/Changelog_Design_changes_for_snapshot
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Change-Id: Iea9c62fafc86242f9404e03679b1941aa9c88c9a
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7415
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Varun Shastry <vshastry@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f126c6b6bcf886d1d6546b763af743bdee0f9919
Author: Kotresh H R <khiremat@redhat.com>
Date: Mon Mar 10 20:03:55 2014 +0530
feature/changelog: Draining of in-transit fops in changelog.
This is required for Geo-rep to work with snapshots.
Following things are done in this patch.
1. Draining of in-transit fops during changelog rollover.
2. Explicit rollover of changelog when snapshot barrier
notification comes. During this, intransit fops are
drained and changelog is rolled over.
For more details on the purpose of the patch. Please
visit following link.
http://www.gluster.org/community/documentation/index.php/Changelog_Design_changes_for_snapshot
Change-Id: I22690131e19d3027f6d8957178bdc3431b9062f6
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7216
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Varun Shastry <vshastry@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 923fdb2cf0555812c843bfedb16d5a2c6d30ed74
Author: Sachin Pandit <spandit@redhat.com>
Date: Wed Apr 30 00:41:56 2014 +0530
glusterd/snapshot : Barrier code integration with snapshot codebase.
As we have new barrier translator in place, we are making use of
that during snapshot phase.
During snapshot create (pre-commit), we enable the barrier feature
and after the commit we disable it.
Change-Id: I94212b1c06b0d9b12255ee98313e2d8549b34b17
BUG: 1061685
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7561
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4316230aa1549fc9230d431e34007bd0f890be9d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 30 03:31:06 2014 +0530
mgmt/glusterd: Fix wrong usage of snprintf
Change-Id: I7db752390bb742fb9f6cacce84563ff782ae352b
BUG: 1087677
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7608
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit c4ab5b674a4c6e8ec2690ef9c87ff09107e03fee
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 30 03:05:48 2014 +0530
storage/posix: Remove dead code in xattrop
Change-Id: I48ba81ad342e3c8fe1d81f8e57e61676dd356fb0
BUG: 1092749
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7318
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b88018519ab51f9c30bbba026c1129b2ed7a9130
Author: Anand Avati <avati@redhat.com>
Date: Tue Apr 29 13:54:53 2014 -0700
logging: use duplicate stderr, instead of re-opening
The special filename "-" is supposed to log to stderr. Instead of
trying to explictly open "/dev/stderr" again (which may not be possible
as permissions might have changed by then), dup the stderr and use
the copy.
It is not a good idea to use @stderr global variable directly, as
ctx->log.logfile is fclose()d in glfs_fini() (was fixed in
http://review.gluster.org/6452)
Change-Id: Ia6c538fe363905588dcf4fc4783804073956a586
BUG: 1088589
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7607
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1c036490fa879fc38e5acf38ce4e2516b73de853
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Feb 7 11:02:10 2014 +0530
logging: Introduce suppression of repetitive log messages
Change-Id: I8efa08cc9832ad509fba65a88bb0cddbaf056404
BUG: 1075611
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7475
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6ae88c7e95ed323709c77d9f630bcb77d12adb1d
Author: Joseph Fernandes <josferna@redhat.com>
Date: Mon Apr 21 20:28:22 2014 +0530
snapshot create force option
Implement force option in snapshot create i.e
1) Creation of snapshot fails if the original volume
bricks are down
2) With a force option creation of snapshot will continue
even if the original volume bricks are down.
This was the fix for bugs 1089527 and 1083502
Change-Id: I8de0242adf8ee0af00db9fa8701d86fabc12e7fc
BUG: 1090042
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/7520
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ff3a3cb56f095928b7d981fb5a5588bbd22679c6
Author: Vijaikumar M <vmallika@redhat.com>
Date: Tue Apr 29 18:56:56 2014 +0530
glusterd/snapshot : Fix for snapshot delete failure
Problem : snapshot delete used to fail when executed in loop,
as there was race between process kill and umount.
Solution : Before an umount is issued check if the process
is still running, If so then issue for process termination.
Give three tries for doing umount operation
Change-Id: I7f4315e5d7d4a156dd513ec77443ead6ccd37b2e
BUG: 1090449
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7532
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 89ffadb79730e40a3fa388073067db0a60f41624
Author: Joseph Fernandes <josferna@redhat.com>
Date: Mon Apr 21 19:29:01 2014 +0530
snapshot create CLI msg correction
Uniformity in cli output while creating snapshots
Change-Id: Ic0fd09bbde9a1f55c441e1745f93c588d2e4c1a1
BUG: 1090041
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/7518
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit cecedda5239719cef4cc0e44365bc0fee8fd5cb5
Author: Joseph Fernandes <josferna@redhat.com>
Date: Thu Apr 17 19:42:06 2014 +0530
Glusterd crashes when a same command eg snapshot create is fired simultaneously on a node
Cause: In glusterd_mgmt_v3_initiate_snap_phases() , the function
glusterd_mgmt_v3_post_validate() asserts on the NULL value of
req_dic. req_dic is not initialized as
glusterd_mgmt_v3_initiate_lockdown() is not able to acquire the lock
and comes to the "out" section, before initializing req_dic
(via glusterd_mgmt_v3_build_payload)
Fix: Call glusterd_mgmt_v3_post_validate() only if the lock is
acquired.
Change-Id: I7cb55b6c0013ad1c8bbb922a62c34aab097bafe9
BUG: 1090047
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Reviewed-on: http://review.gluster.org/7500
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 823b995d821cc5ae117283d5eb64a4554da1dd51
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Feb 7 11:24:41 2014 +0530
geo-rep: Consume Changelog History API
Every time when geo-rep restarts it first does FS crawl using
XCrawl and then switches to Changelog Mode. This is because changelog
only had live API, that is we can get changes only after registering.
Now this(http://review.gluster.org/#/c/6930/) patch introduces History
API for changelogs. If history is available then geo-rep will use it
instead of FS Crawl.
History API returns TS till what time history is available for
given start and end time. If TS < endtime then switch to FS Crawl.
(History => FS Crawl => Live Changelog)
If TS >= endtime, then switch directly to Changelog mode
(History => Live Changelog)
Change-Id: I4922f62b9f899c40643bd35720e0c81c36b2f255
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/6938
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 41de3ed072a9737c97cde58e4a2a8d2ebc6c2287
Author: Sachin Pandit <spandit@redhat.com>
Date: Mon Apr 28 05:58:41 2014 +0530
glusterd/snapshot : Clean up of old barrier code.
As a new barrier translator is introduced, we dont require
the old barrier code. Hence cleaning thar up.
Change-Id: Ieedca6f33a746898f0d2332fda1f1d4c86fff98f
BUG: 1061685
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7577
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6b63b9128c47ff6027c2e68cc0ad2f90557cfef3
Author: Sachin Pandit <spandit@redhat.com>
Date: Thu Apr 3 10:00:04 2014 +0530
snapshot/config : Fix for bug which states gluster snapshot config command should only accept the decimal numeric value.
Syntax : gluster snapshot config [volname]
[snap-max-hard-limit <count>]
[snap-max-soft-limit <percentage>]
Problem : Snapshot config used to consider the alphanumeric value
staring with digit as an integer (Example: "9abc" is converted to "9").
Solution : Refined the code to check if the entered value is numeric.
This patch also fixes some of the minor problems related to snapshot
config.
1) Output correction in gluster snapshot config snap-max-soft-limit.
2) setting the soft limit to greater than 100% displays that "Invalid
snap-max-soft-limit 0". The error message used to display "zero" in
the output, Changed this to display relevant value.
3) Setting greater than allowed snap-max-hard-limit output needs to
have space in between.
Change-Id: Ie7c7045722fe57b2b3c50c873664b67c28eb3853
BUG: 1087203
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7457
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6a5e0000956b05a8bf81067951ad1fcd7a0c9348
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Apr 28 15:27:13 2014 -0700
glusterd: make sure that mntent.h is conditionally included
Change-Id: I39c362c0908166707e10e8820cc1ee9a0989dcbe
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7584
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 7a1fe0ce2b938d191c2b7037ae26bb5fa6ea9534
Author: Anand Avati <avati@redhat.com>
Date: Sat Mar 29 04:54:16 2014 -0700
strfd: introduce strvprintf() API
variant of strprintf() which accepts va_list as parameter
instead of variable args (...)
Change-Id: I205acf3aaf5440890d5f9cad693c6a358a5d9218
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7539
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit a7b18f27ce4f09e7b120937387301b2900725170
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Apr 7 10:57:45 2014 +0530
glusterd: Ping timer implmentation
This patch refactors the existing client ping timer implementation, and makes
use of the common code for implementing both client ping timer and the
glusterd ping timer.
A new gluster rpc program for ping is introduced. The ping timer is only
started for peers that have this new program. The deafult glusterd ping
timeout is 30 seconds. It is configurable by setting the option
'ping-timeout' in glusterd.vol .
Also, this patch introduces changes in the glusterd-handshake path. The client
programs for a peer are now set in the callback of dump_versions, for both
the older handshake and the newer op-version handshake. This is the only place
in the handshake process where we know what programs a peer supports.
Change-Id: I035815ac13449ca47080ecc3253c0a9afbe9016a
BUG: 1038261
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5202
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 258e421df4e3de9d4d08abc3d895bf60ff7bfce1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 19 07:52:48 2014 +0530
storage/posix: add list xattr capability to lookup
BUG: 1078061
Change-Id: Ie26d28b8a74aa0d1eceff14a84c3cd3e302dcdb5
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7293
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 34739ef958e35f6506962d860582fe6d28502943
Author: Varun Shastry <vshastry@redhat.com>
Date: Fri Apr 11 17:31:32 2014 +0530
feature/quota: Logging corrections
This patch solves the inconsistent quota usage logging when soft limit reached.
Change-Id: I47e7f1e65ed4b8306a999a20cc8f6b1772d47627
BUG: 1087198
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/7451
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4266d9b124237facf0f64726f9b6d53ef6194a47
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Feb 11 10:07:24 2014 +0530
cli: Add a cli command to enable/disable barrier
This patch adds a new
'gluster volume barrier <VOLNAME> {enable|disable}'
cli command. This helps in testing the brick op code path when testing
the barrier xlator.
This patch can be reverted later if not required for end users.
Change-Id: Icd86a2d13e7f276dda1ecbb2593d60638ece7dcd
BUG: 1060002
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6958
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 145efc8eb17139bc142c17dad4771625a632bf18
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Feb 6 13:04:32 2014 +0530
glusterd: Add a barrier brick-op
This patch introduces a new 'barrier' brick-op which will be used to
activate/deactivate the barriering on the bricks. This includes
barriering in the barrier xlator and in the changelog xlator. All the
required code has been including a bricks select function, a payload
builder and a brick-op handler.
Change-Id: I91d9d77f691c2e89823f7dc4e84900ec40dc4dd2
BUG: 1060002
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6943
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d15366b39a297db8f49353fbd0e884355e1f62dc
Author: Sachin Pandit <spandit@redhat.com>
Date: Sat Apr 19 16:30:19 2014 +0530
glusterd/snapshot : Dont acquire a lock if config is of type DISPLAY.
Problem : Currently we are acquiring a lock if we give
"gluster snapshot config <volname>". As this is just a
Read-Only command, we need not acquire a lock.
Solution : This patch checks if the command given is of
type DISPLAY. If so, then glusterd_v3_mgmt framework is
not called, as reading information from local node is
enough.
This Patch also fixes "Assertion failed: volname" while
doing the system config change when snap create was in
progress.
Change-Id: Ie8991f2cd746987b11152006e113e8706516138b
BUG: 1087677
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7458
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 43fa7d51f7df90a943fe1e05c3a7fcbff19cc3e6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Apr 25 10:14:14 2014 -0400
build: glusterfs.spec.in, minor/nit changes to sync with Fedora spec
minor/nit changes to sync with Fedora spec
Change-Id: I939eb79d5c3a19c09a3df3f30c82c86e1a610cd0
BUG: 1091408
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/7565
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 69781497170e66bdb913cae30efe4e4d52e8a364
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Apr 28 10:59:04 2014 +0530
logging: Fix msg-id segment allocation
Change-Id: I85efa4b91c263d7374d34dd0d84e9f1032d07ab6
BUG: 1075611
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7580
Reviewed-by: N Balachandran <nbalacha@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit df4d1e023da53cdf1d3b3f1ef7063ab9972e78a3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Apr 29 06:05:46 2014 +0530
debug/trace: Fix length issue found in compilation
Change-Id: I1cd7fd6464d0912294009c2293ed70f3f6744930
BUG: 1092196
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7586
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e48ac4cae1659bfb2d0c3c4524decb83fa9f3a71
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Apr 28 16:31:15 2014 -0700
nlm: fix rpc.statd typo
Change-Id: I701fd82a8dd5a72727b8035bc6c2861465f1aa1f
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7585
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit d5f47275a579982be0a2267a25037e10b5fc8f1c
Author: Soumya Koduri <skoduri@redhat.com>
Date: Wed Apr 23 12:41:33 2014 +0530
libgfapi: A minor bug-fix in glfs_h_setxattr and glfs_h_removexattr calls.
Change-Id: I62f63da37edf722d6d79c75f72ee7403e93e4936
BUG: 1089414
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/7529
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Meghana M <mmadhusu@redhat.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9ea2f60500bcc25b4e0a9403e44f6086a48ea4c7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Apr 25 20:36:11 2014 +0530
cluster/afr: Fix inode_forget assert failure
Problem:
If two self-heals are triggered on same inode in
parallel then one inode will be linked and the other
inode will not be linked as an inode with that gfid
is already linked in inode table. Calling inode-forget
on that inode leads to assert failure.
Fix:
Always use linked inode for performing self-heal.
Added inode-forgets in other places as well even though
its not really a memory leak.
Change-Id: Ib84bf080c8cb6a4243f66541ece587db28f9a052
BUG: 1091597
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7567
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9dcd160c74284ceccf0f7f214959629dcf2b2a18
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Mar 21 08:35:12 2014 +0530
dict: de-allocate data on dict-set failures
Found the bug while browsing code. Very difficult to hit this though.
Change-Id: I84bd5d23d19b6aa16866fc0f1b56aa22cb8a5f1f
BUG: 1079215
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7310
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 75b379d762e82139cdd5eac67ea3be70852d0e9e
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Thu Apr 24 14:39:20 2014 +0530
glusterd: Help does not show performance.nfs.* opt
Gluster does not display performance.nfs.* options in help.
In Gluster NFS, write-behind is the only performance xlator
which gets loaded. Gluster volume set help should display all
the options provided by write-behind xlator.
Change-Id: I4a41151a6c15eeed8e8d123a6044c6f0c42b56b0
BUG: 1090826
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/7546
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dedf950dc185b3287aeef9d2c5476b25f5c7c9de
Author: ggarg <ggarg@redhat.com>
Date: Fri Mar 28 12:23:17 2014 +0530
cli: Error out when character "." is available in volume name
previously it was failed without showing any information why it is failed.
Now with this fix, when "." or any non alphanumeric character
present in volume name, it will give error messages
Change-Id: I17e8e69c08345c4d760f3ba333fe841e754bc9c8
BUG: 921215
Signed-off-by: ggarg <ggarg@redhat.com>
Reviewed-on: http://review.gluster.org/7364
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fd18c808f874291b59dac5f065d934db7780ea61
Author: Kotresh H R <khiremat@redhat.com>
Date: Thu Feb 13 23:53:27 2014 +0530
features/libgfchangelog: APIs to process history changelogs.
1. Create directories in following fashion for history API's
usage when consumer is registered with libgfchangelog
shared library through gf_changelog_register.
scratch_dir/.history
scratch_dir/.history/.current
scratch_dir/.history/.processed
scratch_dir/.history/.processing
2. Added new file 'gf-history-changelog.c' and following APIs
are provided for consumers to process history changelogs.
1. gf_history_changelog_scan:
Move processed history changelog file from
.processing to .processed
2. gf_history_changelog_next_change:
Return the next history changelog file entry.
Zero means all history chanelogs are consumed.
3. gf_history_changelog_done:
Scan .processing directory and generate a list of
change entries.
4. gf_history_changelog_start_fresh:
For a set of changelogs, start from the begining.
NOTE: Though this patch provides above funcationalities.
It is considered functionally full with the
patch (http://review.gluster.org/#/c/6930/).
Change-Id: I200780c7278e0a6c008910d93faad5858a4b3e76
Original-author: Kotresh H R <khiremat@redhat.com>
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/6998
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 47464979f2431a7488459da91c6e42bcc27262f6
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Apr 22 00:52:57 2014 +0000
glusterd/snapshot: Compare and update snapshots during peer handshake
During a peer-handshake, after the volumes have synced, and the list of
missed snapshots have synced, the node will perform the pending deletes
and restores on this list. At this point, the current snapshot list in
the node will be updated, and hence in case of conflicts arising during
snapshot handshake, the peer hosting the bricks will be given precedence
Likewise, if there will be a conflict, and both peers will be in the same
state, i.e either both would be hosting bricks or both would not be hosting
bricks, then a decision can't be taken and a peer-reject will happen.
glusterd_compare_and_update_snap() implements the following algorithm to
perform the above task:
Step 1: Start.
Step 2: Check if the peer is missing a delete on the said snap.
If yes, goto step 6.
Step 3: Check if there is a conflict between the peer's data and the
local snap. If no, goto step 5.
Step 4: As there is a conflict, check if both the peer and the local nodes
are hosting bricks. Based on the results perform the following:
Peer Hosts Bricks Local Node Hosts Bricks Action
Yes Yes Goto Step 7
No No Goto Step 7
Yes No Goto Step 8
No Yes Goto Step 6
Step 5: Check if the local node is missing the peer's data.
If yes, goto step 9.
Step 6: It's a no-op. Goto step 10
Step 7: Peer Reject. Goto step 10
Step 8: Delete local node's data.
Step 9: Accept Peer Data.
Step 10: Stop
Change-Id: I79be0f0f5f2a4f5c72277a4e77c2be732af432e1
BUG: 1061685
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7525
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 56619fa7807ff3a37a8447953f096e79385b9caa
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Apr 21 03:32:00 2014 +0000
glusterd: Rename the export dictionary as peer_data
During a glusterd handshake, a dictionary is passed among
the peers which contains, info of volumes, global opts,
and now also info of snaps and list of missed snaps
As it now contains more than just volume specific data,
renaming the dict in the code-base from "vols" to "peer_data"
Change-Id: Ib457172789ddd0d8978b08bceab0988c48e9eea7
BUG: 1061685
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7524
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit da749213770367f35f9f8615c2ca433e696dd51d
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Apr 3 03:36:28 2014 +0000
glusterd/snapshot: Recreate the mount dirs and mount the lvm snapshots on node reboot.
The lvm snapshots of the bricks are mounted at /var/run/gluster/snaps/ or
/run/gluster/snaps. These paths being on a tempfs, on reboot are removed.
So when glusterd starts, we need to recreate these paths, activate the
respective logical volumes (lvm snapshots of the bricks), and mount
these logical volumes at their respective paths.
Change-Id: Ic5ef61e79a25d9830df717c592391965fe09db62
BUG: 1061685
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7452
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b34bb2e265bd638226273195aa39c08898c1c4c1
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Apr 7 06:02:10 2014 +0000
glusterd/snapshot: Perform missed snap deletes and restores.
Replacing is_volume_restored(gf_boolean_t) with
restored_from_snap(uuid_t) in glusterd_volinfo_
Also removed gd_restore_snap_volume from glusterd-volgen.c
to glusterd-snapshot.c
Change-Id: Ic615a1658cfaffa98d4590506ac82f20bf709ad6
BUG: 1089906
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7455
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f129baafa7728686e2647c7a0322160f5c1d3a39
Author: Yuan Ding <beback198611@gmail.com>
Date: Mon Apr 21 22:10:13 2014 +0800
gNFS: gNFS drc cache failed to detecte duplicates.
After the drc cache get full, message "DRC failed to detect duplicates" keep
printed in the log.
The root cause is drc_compare_reqs use the wrong compare type. This function
should use type drc_cache_op_t as its input type. Since all rbtree related code
(except function rpcsvc_drc_lookup) in drc cache pass drc_cache_op_t as compare
type. Only rpcsvc_drc_lookup use type rpcsvc_request_t. It has been modified
too.
Change-Id: I925c097debe6b82f267986961fd4e7755f3de9af
BUG: 1089676
Signed-off-by: Yuan Ding <beback198611@gmail.com>
Reviewed-on: http://review.gluster.org/7519
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 066588278e542566b0bb2414048d6b74d0e44544
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Mar 3 18:00:59 2014 +0530
Barrier: Barrier translator options configuration
barrier enable/disable, barrier-timeout configuration in barrier translator.
Change-Id: I7cbf9cd4f5e55d42dcc6b7cd6827234566c7b6f3
BUG: 1060002
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7177
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7c18129e31d336c3f33f212e1482245f21871f1a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Apr 7 05:25:28 2014 +0000
glusterd/snapshot: Adding snap_vol_id and snap_uuid to missed_snap_list
Persisting missing snapshot info on disk as well as in memory in
the following format:
-------------NODE-UUID--------------:--------------SNAP-UUID-------------=---------SNAP-VOL-ID------------:BRICKNUM:-------BRICKPATH--------:OPERATION:STATUS
927cb5fe-63da-48f5-82f6-e6a09ddc81c4:8258b18f-d408-483d-8239-204039dc6397=a17b4fe42c5a45f7a916438643edaa13: 3 :/brick/brick-dirs/brick3: 1 : 1
927cb5fe-63da-48f5-82f6-e6a09ddc81c4:8258b18f-d408-483d-8239-204039dc6397=a17b4fe42c5a45f7a916438643edaa13: 3 :/brick/brick-dirs/brick3: 3 : 1
927cb5fe-63da-48f5-82f6-e6a09ddc81c4:8258b18f-d408-483d-8239-204039dc6397=83a3cc05453b46b2a7eda4c9a9208638: 3 :/brick/brick-dirs/brick3: 1 : 1
This data will be stored on disk at /var/lib/glusterd/snaps/missed_snaps_list
In memory we maintain the data as a list of glusterd_missed_snap_info
in conf, the key for this list are the first two fields,
i.e NODE-UUID:SNAP-UUID.
For every NODE-UUID:SNAP-UUID, there can be multiple operations missed
on multiple bricks. So we maintain a list of glusterd_snap_op_t
for every node of glusterd_missed_snap_info
This list is maintained or updated during snapshot create, delete, and restore
operations which are the only operations that if missed, are recorded in this
list.
During snapshot create, if a node is down, or a brick is down, we don't
receive their mount point infos. snap_status of such bricks is marked as
-1, and their brick details are added to this list.
During snapshot delete, we check from originator node, if any other
nodes, holding bricks of the said snap are down. Those are also added to the list.
Also if the node is up, but the snapshot was pending for a snap
brick, and its snap_status is -1, we add that to the list too.
When a subsequent delete entry is processed for an already existing
create entry, we just mark the create entries status as done (2), and don't
add the delete entry to the list.
During snapshot restore, we check from originator node, if any other
nodes, holding bricks of the said snap are down. Those are also added to the list.
Also if the node is up, but the snapshot was pending for a snap
brick, and its snap_status is -1, we add that to the list too.
Like delete when a subsequent restore entry is processed for an already existing
create entry, we just mark the create entries status as done (2), and don't
add the restore entry to the list.
Change-Id: I54f63e28d3c40555d0f84528f38227103171f594
BUG: 1061685
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7454
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 98280bfe275f5bd9fc96ece68e257ab6fc0b9b05
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Apr 27 15:03:58 2014 +0200
Update references to the maillinglist to gluster-devel@gluster.org
gluster-devel@nongnu.org has moved to gluster-devel@gluster.org. All
occurrences in the current (non legacy) documentation and code have been
adjusted.
Change-Id: I053162e633f7ea14fd3eed239ded017df165147c
BUG: 1091705
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7573
Reviewed-by: Justin Clift <justin@gluster.org>
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 2c188dafbd0fae6af5611e469141f6ef0ac2e2ed
Author: Kasturi Narra <knarra@redhat.com>
Date: Wed Apr 23 14:04:59 2014 +0530
doc: Adding user documentation for WORM feature
Change-Id: Ic31c8305254dd00eae986fbb322cac3761b5d330
BUG: 1086760
Signed-off-by: Kasturi Narra <knarra@redhat.com>
Reviewed-on: http://review.gluster.org/7530
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a582a6a5112afb6a75db77801b21ebdf716ffb95
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Apr 24 13:38:31 2014 +0200
fuse: minor improvements for readdir(plus)
Instead of using 'int' for the sizes, use a 'size_t' as it is more
correct. Save the size of a fuse_dirent in a temporary variable so that
strlen() on the filename is called fewer times.
Also correcting some typos in comments.
Change-Id: Ic62d9d729a86a1a6a53ed1354fce153bac01d860
BUG: 1074023
Reported-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7547
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 212536d83b45833fd7e9f2aa9cc79e80a49d7abc
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Apr 26 20:19:38 2014 -0700
rpcgen: After recent changes parallel builds failed
Parallel builds failed due to make file would overrun
xdrgen (internally xdrgen uses tempfiles to add License
header).
Seperate out header and source generation and add explicit
dependency to fix it.
Change-Id: Id20f548493540b0f17a2300f0775646f9f20789c
BUG: 1090807
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7572
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0e7245d5975e8d6c23503d7551c89346d1a86434
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Apr 27 07:00:34 2014 +0530
libglusterfs: Define macro GF_PRI_USEC for Linux as well
Change-Id: I073f1f4ead4391d497fbb7603f9ee0257271493b
BUG: 1089172
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7571
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0894fa19003ce1b6bfffd82bb8d2426ad5d29405
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Thu Apr 24 12:55:05 2014 +0530
gNFS: Log properly for pmap_getport() fail in NLM
In NLM callback path, if pmap_getport() FAILs, it just log the error
message saying "Is firewall running on the client". It may happen
that RPC services are not running e.g. "rpcbind" is not running or
nlockmgr (NLM) is not registered with portmapper which all can be
checked using "rpcinfo -p" command.
FIX:
Modify the log message to include the later case mentioned
above.
Change-Id: If422275b2ab59d1e974a6caa37132f31e9a34329
BUG: 1090782
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/7544
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 6b5867518b9d281b9b3cbef35eaf4622a79f76d8
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Apr 24 16:37:05 2014 +0530
features/locks: Remove stale entrylk objects from 'blocked_locks' list
* In the event of a DISCONNECT from a client, as part of cleanup,
entrylk objects are not removed from the blocked_locks list before
being unref'd and freed, causing the brick process to crash at
some point when the (now) stale object is accessed again in the list.
* Also during cleanup, it is pointless to try and grant lock to a
previously blocked entrylk (say L1) as part of releasing another
conflicting lock (L2), (which is a side-effect of L1 not being
deleted from blocked_locks list before grant_blocked_entry_locks()
in cleanup) if L1 is also associated with the DISCONNECTing client.
This patch fixes the problem.
Change-Id: I3d684c6bafc7e6db89ba68f0a2ed1dcb333791c6
BUG: 1089470
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7560
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 003c3bef02c9d66f9a9ea15e10d765aae1bdcf90
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Apr 2 05:39:22 2014 +0000
glusterd/snapshot-handshake: Perform handshake of missed_snaps_list.
In a handshake, create a union of the missed_snap_lists of the two peers.
If an entry is present, its no op.
If an entry is pendng, and the peer entry is done, mark own entry as done.
If an entry is done, and the peer ertry is pending, its a no-op.
If its a new entry, add it.
Change-Id: Idbfa49cc34871631ba8c7c56d915666311024887
BUG: 1061685
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7453
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 48ce518381fd8d1a434aebfda0766fa2a6f05f63
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Apr 25 16:08:09 2014 -0700
rpcgen: 'hyper' is 64bit undefined on Darwin use quad_t
"9819fcedf10f1430d4969c86e6df4dfe975b7dcf" After the commit i
observed that we never used "hyper" as defined in .x previously
in the .[c,h] files.
Change-Id: I26152141bca6e789c4a3b3158fffe0a65e4b0878
BUG: 1090807
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7566
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9297f21c109d77baea93fc6cc251f75aeea63e36
Author: Bala.FA <barumuga@redhat.com>
Date: Fri Apr 25 11:16:02 2014 +0530
build: fix RHEL 7 build issue
Glusterfs build on RHEL 7 fails with "Installed (but unpackaged)
file(s) found". This patch fixes it.
BUG: 1058188
Change-Id: I8f37935b75ba02d085e75a66cdbc4017d82faa2e
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/7557
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 49a14ece5dc5b927b2a574af9f4569dbf7d5e26b
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Apr 22 13:27:35 2014 -0700
rpcgen: Remove autogenerated files instead build on demand
Avoid modifying autogenerated files and keeping them in
repository - autogenerate them on demand from ".x" files
Change-Id: I2cdb1fe9b99768ceb80a8cb100fa00bd1d8fe2c6
BUG: 1090807
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7526
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1e3a0d7d39985fd108e0d37ba8171d5af9552e97
Author: Kotresh H R <khiremat@redhat.com>
Date: Thu Apr 24 14:21:46 2014 +0530
feature/changelog: Change default rollover and fsync-interval time
This will change the following default configurables.
1. rollover-time: from 60 to 15.
2. fsync-interval: from 0 to 5.
Change-Id: I9c8db01376967c4f19547ec87f54833f8b139d29
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7545
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 3cb8eeea0b01b96601882d6f3286045fd46c387b
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Apr 24 17:09:24 2014 -0700
osx: Compilation fixes
Change-Id: I822936cbeb4ec8af46be8e94644ea666b919ae5c
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7556
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 554dc6eb22d754255f26e5a35f2dab7520cafdc7
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Sat Apr 19 20:03:38 2014 +0530
features/locks: Remove stale inodelk objects from 'blocked_locks' list
* In the event of a DISCONNECT from a client, as part of cleanup,
inodelk objects are not removed from the blocked_locks list before
being unref'd and freed, causing the brick process to crash at
some point when the (now) stale object is accessed again in the list.
* Also during cleanup, it is pointless to try and grant lock to a
previously blocked inodelk (say L1) as part of releasing another
conflicting lock (L2), (which is a side-effect of L1 not being
deleted from blocked_locks list before grant_blocked_inode_locks()
in cleanup) if L1 is also associated with the DISCONNECTing client.
This patch fixes the problem.
* Also, the codepath in cleanup of entrylks seems to be granting
blocked inodelks, when it should be attempting to grant blocked
entrylks, which is fixed in this patch.
Change-Id: I8493365c33020333b3f61aa15f505e4e7e6a9891
BUG: 1089470
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7512
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 95f91e6caff1a856eddaec92487785a55a51aef2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 23 14:05:10 2014 +0530
rpcsvc: Ignore INODELK/ENTRYLK/LK for throttling
Problem:
When iozone is in progress, number of blocking inodelks sometimes becomes greater
than the threshold number of rpc requests allowed for that client
(RPCSVC_DEFAULT_OUTSTANDING_RPC_LIMIT). Subsequent requests from that client
will not be read until all the outstanding requests are processed and replied
to. But because no more requests are read from that client, unlocks on the
already granted locks will never come thus the number of outstanding requests
would never come down. This leads to a ping-timeout on the client.
Fix:
Do not account INODELK/ENTRYLK/LK for throttling
Change-Id: I59c6b54e7ec24ed7375ff977e817a9cb73469806
BUG: 1089470
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7531
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ff68a5a1bbb0adb29f4bac012a4b6cac6c5faf35
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Apr 17 15:54:34 2014 -0700
build: MacOSX Porting fixes
git@forge.gluster.org:~schafdog/glusterfs-core/osx-glusterfs
Working functionality on MacOSX
- GlusterD (management daemon)
- GlusterCLI (management cli)
- GlusterFS FUSE (using OSXFUSE)
- GlusterNFS (without NLM - issues with rpc.statd)
Change-Id: I20193d3f8904388e47344e523b3787dbeab044ac
BUG: 1089172
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Signed-off-by: Dennis Schafroth <dennis@schafroth.com>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Dennis Schafroth <dennis@schafroth.com>
Reviewed-on: http://review.gluster.org/7503
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8d86b6dc1cfa40fb8cad6e665103f492436e6b64
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Apr 23 15:53:41 2014 +0000
tests: print info about failed tests
It's a bit frustrating to run a test normally (e.g. during development),
see a failure, and then have to re-run it with DEBUG=1 to see what
actually failed. This tiny patch prints out the command line of the
test that just failed, even if DEBUG=0 (in fact only if DEBUG=0 since
otherwise it would be redundant).
Change-Id: Icffa096d0bcc6f35176f0e47d9d1bc538698ca2c
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/7537
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c488b527676e96554e47219363595ae14f807f27
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Wed Apr 9 10:19:43 2014 +0530
gNFS: Support wildcard in RPC auth allow/reject
RFE: Support wildcard in "nfs.rpc-auth-allow" and
"nfs.rpc-auth-reject". e.g.
*.redhat.com
192.168.1[1-5].*
192.168.1[1-5].*, *.redhat.com, 192.168.21.9
Along with wildcard, support for subnetwork or IP range e.g.
192.168.10.23/24
The option will be validated for following categories:
1) Anonymous i.e. "*"
2) Wildcard pattern i.e. string containing any ('*', '?', '[')
3) IPv4 address
4) IPv6 address
5) FQDN
6) subnetwork or IPv4 range
Currently this does not support IPv6 subnetwork.
Change-Id: Iac8caf5e490c8174d61111dad47fd547d4f67bf4
BUG: 1086097
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/7485
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 60d8b739fea080cceff6c857b5b9753f3a047b47
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Apr 9 11:53:33 2014 +0530
glusterfs-server : barrier timeout tuning fix
Problem : Reconfiguration of barrier timeout through gluster volume set shows a
success but it never changes the default timeout value which is 120 seconds.
After digging into the code deeper, it was found that timeout is never modified
in reconfigure() as the first check i.e. whether barrier is already enabled or
disabled always fails since barrier option is not modified in this request.
Fix : Introduced notify() in barrier translator which will take care of the rpc
request to enable/disable barrier. reconfigure() will simply set barrier
enable/disable and timeout options blindly without any validation.
Please note this patch only contains the changes in barrier translator however
from complete code flow perspective the caller in the glusterfsd mgmt should
call notify instead of reconfigure to fix this problem.
Change-Id: I1371b294935f6054da7c1dc6a9a19f1d861e60fb
BUG: 1085671
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7428
Reviewed-by: Varun Shastry <vshastry@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e626a3807b6a5df81d17875dc1b4fba4c7c63810
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Apr 14 17:39:43 2014 +0530
doc : remove brick usage change
This patch takes care of changing admin guide (admin_managing_volumes.md) for
remove-brick usage change. 3.6 version onwards remove-brick requires an explicit
option (start/force etc).
Change-Id: If6c5b0bf2c30c2b9a8c7644d314e2593006818c2
BUG: 1086737
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7474
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ec5200a4cf579e97b3db685c14814d1de637a8a9
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Apr 14 12:39:36 2014 +0000
snapshot: use volume's brick_ids for the snaps
brickinfo->brick_id was introduced to establish persistence of client xlator
names and AFR chanelog attributes (http://review.gluster.org/7155). The
snapshot volumes must also use the same IDs during snapshot create and
restore to maintain persistence.
Change-Id: I13d66d19b63520061ba9ec5f0ce661cf3b9eeafe
BUG: 1066778
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7477
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2d4bcf480654140183f31b2ee8a22bcb942ee439
Author: Kasturi Narra <knarra@redhat.com>
Date: Tue Apr 15 18:45:12 2014 +0530
doc: Adding documentation for file-snapshot
Change-Id: I52b70a2fb24f5e3f802f0ce8b1c50102c267e218
BUG: 1086750
Signed-off-by: Kasturi Narra <knarra@redhat.com>
Reviewed-on: http://review.gluster.org/7487
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit c2ae01ef45f1968f29a10b4541aee87938ff9721
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Apr 21 13:53:29 2014 +0530
glusterd: pass the right argument for perf subgraph
Change-Id: Ic292dcd8e477066c1079f0f1e170f5153459b029
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/7514
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7fe6d31544c29a9da9bdaa2559ff769875a8f989
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Mar 27 20:34:44 2014 +0100
fuse: prevent READDIR(P) from writing to much data to /dev/fuse
In an environment with mixed architectures (32-bit servers, 64-bit
client), it is possible that the on-wire Reply on a READDIR(P) procedure
contains more direntries than the client can fit in the maximum size
that the fuse-request indicated.
A direntry is a dynamically sized structure, because the structure
contains the name of the entry. The client sends a maximum size in the
READDIR(P) Call to the server, and the server uses this size to limit
the number of direntries to return. In case the server can pack more
direntries in the requested maximum size (due to alignment differences
between the architectures), it can happen that the client unpacks the
list of direntries into a buffer that exceeds the maximum size that was
given in the initial fuse-request.
This change introduces a check for the maximum requested size of the
fuse-response in fuse_readdir_cbk() and fuse_readdirp_cbk(). When the
conversion from gluster-direntries to the fuse-direntry format takes
place, the maximum size is checked, and the 'extra' direntries are
discarded. The next readdir()/getdents() that is done, will fetch the
just discarded direntries again.
In addition to this bugfix, some extra logging in send_fuse_iov() and
send_fuse_data() has been added to help diagnosing similar issues.
Change-Id: If2eecfcdf9c248f3820035601446d2c89ff9d1a1
BUG: 1074023
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7278
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ae944a200a1189db0c0cb6e246ca8528586e5ffe
Author: Anand Avati <avati@redhat.com>
Date: Thu Mar 27 21:21:12 2014 -0700
strfd: memory backed file descriptor
A file descriptor like interface, backed by a string, on which
fprintf() like IO can be performed. Internally the backing string
is grown on demand.
Useful in generating virtual file content on the fly (used in meta)
Change-Id: I60d8751c4c750f3f06aa454a4ccd9909b3ac8ac7
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7508
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c8e06840a972e2f990adea44cb7b694557d64bb7
Author: Anand Avati <avati@redhat.com>
Date: Thu Mar 27 08:03:52 2014 -0700
common-utils: new dirent compatible time fmt
Introduce a new time format without "/" and spaces, in order to
be used in (virtual) filenames.
Change-Id: I468be54f1ec7f45265add4c458e19d95567439f7
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7507
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 1c25a4e9d6732f61f9d567f894fe1cf1c6830fd4
Author: Anand Avati <avati@redhat.com>
Date: Thu Mar 27 06:35:34 2014 -0700
fuse: allow xlators to request for direct-io-mode on virtual files
Translators like meta, create virtual files with dynamic content
generated only at the time of open(). Therefore the file size
returned in lookup or stat is 0 (just like files in /proc). However
the VFS does not read beyond the size, and if the size is 0, no
READ ever reaches gluster for that file -- unless direct-io-mode
is enabled.
This patch allows translators to return "direct-io-mode" flag for
such 0-byte virtual files in xdata of open_cbk/create_cbk.
Change-Id: I3fe3312cd96baa4eecfe1247ab7255b4f455f049
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7506
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit e48f9f8d131d78bd38568fbc5ba20107aaedfaab
Author: Anand Avati <avati@redhat.com>
Date: Thu Mar 27 23:53:58 2014 -0700
fuse-resolve: loc_wipe() after inode_link()
the inode to be linked may have the last ref. loc_wipe() can
destroy it before inode_link() gets to ref it.
Change-Id: Ic2d44084e6e9c8289f35cae82c8e4575af105398
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7505
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6624b5d6e7a177608e9ac408edf136fb0edb741b
Author: Anand Avati <avati@redhat.com>
Date: Wed Mar 26 10:59:27 2014 -0700
defaults: add new symbol default_fops
with members filled with pointers to appropriate default methods
Change-Id: I6cdc43e4f6776e2ad45cd5cbca5642e0c639ffde
BUG: 1089216
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7504
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit bfa39a4a3a3261c22d616dbf2bc15279d5c5eb26
Author: Soumya Koduri <skoduri@redhat.com>
Date: Fri Mar 21 12:57:14 2014 +0530
Added Handle-based ops to get/set/remove extended attributes in the libgfapi.
Change-Id: I1a8e666018d7b93e0bba2d9882935681da909980
BUG: 1089414
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/7308
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 371a14deec88b558c0a4b11502e61e5f95cda4a3
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Apr 17 12:07:04 2014 +0200
rdma: correct some spelling mistakes
Change-Id: Ib7018aa8a79d36ab942516457a79039cb3e67355
BUG: 1088849
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7498
Reviewed-by: Vikhyat Umrao <vumrao@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 363f02e2c132b06319a5c735e2ca1ef470bce292
Author: Anand Avati <avati@redhat.com>
Date: Tue Apr 1 17:28:55 2014 -0700
cluster/dht: force set dir inode ctx cached time in setattr()
In setattr, the inode times may have been explicitly set "back
in time". In such cases, if the inode ctx times are not force
set, then they continue to be higher and continue serving the
higher/older value in future calls to dht_inode_ctx_time_update()
Change-Id: I9cbfa7cf7c4069b0106d1f462de08c5d59bc91b5
BUG: 1083324
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/7378
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9746fdafeee8d659b8305c1e7b25276c3589002d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Sep 17 17:01:07 2013 +0530
Add upgrade scripts for quota
Change-Id: I289662300d32f75e2fc6e789037c3224054a38a5
BUG: 969461
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7418
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cdf3c1945b036ef6f74ce65208955bc466fee442
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Sep 18 14:12:58 2013 +0530
doc: Upgrade steps for quota
Change-Id: Ib007029f74f52d28e424a15950d46504336bde10
BUG: 969461
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7419
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c5ccaf274b66a53830d37d4e7acff9960c29c3cc
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 14 12:36:50 2014 +0200
mount.glusterfs: return 32 in case of double mounting
The mount.nfs helper returns 32 for this particular error case. It makes
sense for mount.glusterfs to return the same error value.
Change-Id: I628f4c93bc796bb096e91857195ffd3d296eaae9
BUG: 1031973
Reported-by: Deepak C Shetty <deepakcs@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7469
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4de3b5174016dfd8f14613fed6cc965978023c45
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Apr 16 12:05:14 2014 -0700
scripts: Use `/bin/bash` not `/bin/sh`
If using `/bin/sh` this is what we see
$ ./who-wrote-glusterfs.sh
./who-wrote-glusterfs.sh: 39: shift: can't shift that many
Use `/bin/bash` instead where 'shift' without an argument
is supported.
Change-Id: I2be05f0062eb8456631c1cee859757052f1b6dc7
BUG: 1087771
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7496
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7177b4c6252aeeafbb1918aeba03fd809177178f
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Apr 15 18:06:24 2014 +0000
doc: add documentation for NUFA feature
Change-Id: I00f1c669d4ebc61f09c50f8de4c893907f6d75c2
BUG: 1086745
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/7489
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 983a101daa6cce59a9dd1220247fdb5cc4bac3af
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Apr 15 20:12:04 2014 +0000
doc: add documentation for server-quorum feature
Change-Id: Ifaf5c18a320270a9b98c7b25536281fa42b64ad3
BUG: 1086765
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/7491
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit f783d8b92514c6b1a9deb7a782c23c1b5f89c38f
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Apr 15 11:24:31 2014 +0200
scripts: add new email aliases
Two developers started to use new email addresses, marking them as
aliases. Also assign @gmail.com addresses to the "(unknown)" employer.
Change-Id: Ic5722c1611b003182c0288ba530d6ab275c2ca1b
BUG: 1087771
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7484
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit fa7a476ca064736986758d80737e094466c553dc
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue Apr 15 10:26:31 2014 +0530
doc: Add doc for network compression xlator
Change-Id: Iaed94f1bfe7c97eade95923759980a1d10805663
BUG: 1086752
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/7479
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7734c71e4d683b8fdd08cbc84b2ddcc12f967ba7
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Apr 2 11:36:20 2014 +0530
dict: add dict_set_dynstr_with_alloc
There is an overwhelming no. of instances of the following pattern in
glusterd module.
...
char *dynstr = gf_strdup (str);
if (!dynstr)
goto err;
ret = dict_set_dynstr (dict, key, dynstr);
if (ret)
goto err;
...
With this changes it would look as below,
ret = dict_set_dynstr_with_alloc (dict, key, str);
if (ret)
goto err;
Change-Id: I6a47b1cbab4834badadc48c56d0b5c8c06c6dd4d
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/7379
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 6e18751ce44ffe1b580934c79d8bfc062281c5e8
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Apr 10 14:43:47 2014 -0400
configure: argp-standalone is always built, even when not needed
This patch still configures argp, i.e. creates Makefile in
/contrib/argp-standalone, for the `make dist`, but there's no reason
to compile it when it's not going to be linked into anything.
Change-Id: Id0fcb717b5821d8a4c176e6274339f46b3a4a249
BUG: 1086773
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/7440
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ec885a99397fee113bf4c1f71c96d6aafab7cfd7
Author: Bala.FA <barumuga@redhat.com>
Date: Thu Apr 10 14:03:55 2014 +0530
build: set run levels for glusterd init script properly
'chkconfig --add glusterd' does not set run levels for start/stop.
This patch fixes it.
Change-Id: I8962f5207d034b6875353e15eb60c4d08c5a4fe4
BUG: 1086141
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/7432
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e1e0fddb9e56913059fe49228f052e9454920c84
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Apr 10 10:54:01 2014 -0700
pkg-version: Use /bin/bash instead of /bin/sh
`function` is reserved word only available in /bin/bash,
Using `/bin/sh` with `function` keyword fails on Ubuntu.
Change-Id: Ia0fff8f13ace2a0eb1dac50093ff42294d960814
BUG: 1074919
Reviewed-on: http://review.gluster.org/7439
Reviewed-by: Bala FA <barumuga@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9ccaeba1c0f2f0f1014ece9b2804e477946cc839
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Mar 11 15:05:44 2014 +0530
logging: Make logger and log format configurable through cli
Change-Id: Ic4b701a6621578848ff67ae4ecb5a10b5f32f93b
BUG: 1075611
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7372
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 452c987848b1ab4f215cf32bee588aa931acb561
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Apr 10 22:09:53 2014 +0200
mount.glusterfs: return an error when mounting failed
When mounting fails, mount.glusterfs incorrectly returns 0 for some
error cases, it should return 1 instead. Also make sure that error
messages are redirected to /dev/stderr and not printed to stdout.
Unfortunately it is not possible with the current test-scripts to test
commands like 'mount -t glusterfs ...'. Any mounting of Gluster volumes
is done directly with the 'glusterfs' command instead.
Change-Id: Ica9d45b6d5ae537de869a1fa0f6c3edab47225d1
BUG: 1031973
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7441
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 56f21d141c4324c9e827f5a89dd7b4a76982539e
Author: M S Vishwanath Bhat <vbhat@redhat.com>
Date: Thu Apr 10 22:21:22 2014 +0530
Adding admin-guide for distributed-geo-rep
Change-Id: Icbbc9d3fc14fc1a5ae9550f096eb69dda41e92a4
BUG: 1086796
Signed-off-by: M S Vishwanath Bhat <vbhat@redhat.com>
Reviewed-on: http://review.gluster.org/7437
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 90eef06f9f2c894434abfc260ad17322e357f331
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Apr 11 12:56:24 2014 +0200
doc: add documentation for the "Brick Failure Detection" feature
The documentation from the feature page should be included in the
sources.
Change-Id: I4fd67ce1c56afc5236c00de8be9110dfa6bbe91f
BUG: 1086700
Feature-page: http://www.gluster.org/community/documentation/index.php/Features/Brick_Failure_Detection
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7449
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 87b2e844bc2b8789c673903a2761c78946dcaf4a
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jul 11 19:42:16 2013 +0530
cli,glusterd: Improve detach check validation
This patch improves the validation for the 'peer detach' command.
A check for if volumes exist with some bricks on the peer being detached
validation is added in peer detach code flow (even force would have this
validation).
This patch also gurantees that peer detach doesn't fail for a volume with all
its brick on the peer which is getting detached and there are no other bricks on
this peer.
The following steps need to be followed for removing a downed and unrecoverable
peer.
* If a replacement system is available
- add it to the cluster
- use replace-brick to migrate bricks of the downed peer to the new
peer (since data cannot be recovered anyway use the 'replace-brick
commit force' command)
or,
If no replacement system is available,
- remove bricks of the downed peer using 'remove-brick'
Change-Id: Ie85ac5b66e87bec365fdedd8352b645bb25e1c33
BUG: 983590
Signed-off-by: Kaushal M <kaushal@redhat.com>
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/5325
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 84d68e6050b3ebddd1bcea5adcc221bb1ee65dca
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Feb 19 16:30:11 2014 +0530
gluster: GlusterFS Volume Snapshot Feature
This is the initial patch for the Snapshot feature. Current patch
includes following features:
* Snapshot create
* Snapshot delete
* Snapshot restore
* Snapshot list
* Snapshot info
* Snapshot status
* Snapshot config
Change-Id: I2f46920c0d61c515f6a60e0f8b46fff886d9f6a9
BUG: 1061685
Signed-off-by: shishir gowda <sgowda@redhat.com>
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Signed-off-by: Joseph Fernandes <josferna@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7128
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9cf2e9006f008ad90ba5e718cfaa9c43033bab9c
Author: Bala.FA <barumuga@redhat.com>
Date: Fri Feb 28 11:10:51 2014 +0530
build: rearrange spec file elements
This is majorly cleanup wrt spec file elements/definitions. This
patch fixes to ease adding downstream specific conditions.
BUG: 1074939
Change-Id: I311abf8457417591a0d08569d3f83d73fa63cdc0
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/7165
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 4ebbdcbe0bcf057ad89df54599403c76dd2e0c1c
Author: Bala.FA <barumuga@redhat.com>
Date: Thu Feb 27 12:39:43 2014 +0530
build: set version based on git tag or specific
This patch brings version and release number generated at build time
using git tags or fixed content from VERSION file.
With git tag, version/release number are got from output of
'git describe --tags --match "v[0-9]*"' command.
This behavior can be overriden by having VERSION file with fixed
version/release. The VERSION file should have text describing version
and release for example something like 'v3.4.0-1'
For testing this patch, its required to remove autom4te.cache
directory to avoid seeing previously set version.
BUG: 1074919
Change-Id: I8f68172e8b389b0ba0846e9adb4b597e67a909aa
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/7164
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit b8bed314580493a340da5057636ea0a68382947b
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Apr 8 14:37:33 2014 +0530
cluster/afr: Set right argument order for STACK_WIND_COOKIE
Change-Id: Ia26e17a7147ed825319c7c29880b9cf4ae80a48c
BUG: 1085259
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/7416
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1bd3d1bedd17bf57af9500b6f25b8ab651121237
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 27 18:51:08 2014 +0000
glusterd: call runner_end even if runner_start fails
Change-Id: I5eca01a131307ba3be2aed4922eea73025ff284c
BUG: 1081013
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/7360
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ddb1e32f366a890b3a2821743b7fc4070e7ad470
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Apr 8 23:45:31 2014 +0530
cluster/afr: Mem leak fixes found in valgrind for iozone
Change-Id: I869d191dc3470b2208c17343bbf772f01ef744cb
BUG: 1085511
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7424
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f6ca41b06c91cc7b769ccd1f28b5c1f012e8a303
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Apr 8 12:28:04 2014 +0530
features/locks: Fix a missing assignment in new_entrylk_lock()
Change-Id: If5c03456d61ec930d588b57781fb545eed18e4a2
BUG: 1085220
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/7413
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
commit 3a41ea6fa78b2e67245e0acadc14910336caa233
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Apr 7 10:19:37 2014 +0530
cluster/afr: Init local on txn-frame for zerofill
Change-Id: I516f4fb0237dd0b3e512117bf987cea69f8678b8
BUG: 1084485
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7407
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 65273d3033c5b6ca3f180dd2ba8b5667d34c75c5
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Mar 20 18:13:49 2014 +0100
rpc: warn and truncate grouplist if RPC/AUTH can not hold everything
The GlusterFS protocol currently uses AUTH_GLUSTERFS_V2 in the RPC/AUTH
header. This header contains the uid, gid and auxiliary groups of the
user/process that accesses the Gluster Volume.
The AUTH_GLUSTERFS_V2 structure allows up to 65535 auxiliary groups to
be passed on. Unfortunately, the RPC/AUTH header is limited to 400 bytes
by the RPC specification: http://tools.ietf.org/html/rfc5531#section-8.2
In order to not cause complete failures on the client-side when trying
to encode a AUTH_GLUSTERFS_V2 that would result in more than 400 bytes,
we can calculate the expected size of the other elements:
1 | pid
1 | uid
1 | gid
1 | groups_len
XX | groups_val (GF_MAX_AUX_GROUPS=65535)
1 | lk_owner_len
YY | lk_owner_val (GF_MAX_LOCK_OWNER_LEN=1024)
----+-------------------------------------------
5 | total xdr-units
one XDR-unit is defined as BYTES_PER_XDR_UNIT = 4 bytes
MAX_AUTH_BYTES = 400 is the maximum, this is 100 xdr-units.
XX + YY can be 95 to fill the 100 xdr-units.
Note that the on-wire protocol has tighter requirements than the
internal structures. It is possible for xlators to use more groups and
a bigger lk_owner than that can be sent by a GlusterFS-client.
This change prevents overflows when allocating the RPC/AUTH header. Two
new macros are introduced to calculate the number of groups that fit in
the RPC/AUTH header, when taking the size of the lk_owner in account. In
case the list of groups exceeds the maximum possible, only the first
groups are passed over the RPC/GlusterFS protocol to the bricks.
A warning is added to the logs, so that most system administrators will
get informed.
The reducing of the number of groups is not a new inventions. The
RPC/AUTH header (AUTH_SYS or AUTH_UNIX) that NFS uses has a limit of 16
groups. Most, if not all, NFS-clients will reduce any bigger number of
groups to 16. (nfs.server-aux-gids can be used to workaround the limit
of 16 groups, but the Gluster NFS-server will be limited to a maximum of
93 groups, or fewer in case the lk_owner structure contains more items.)
Change-Id: I8410e59d0fd246d601b54b961d3ae9cb5a858c10
BUG: 1053579
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7202
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4ca3f29a4a4019de15fab27c7a49eb40b49046f5
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Apr 8 15:29:08 2014 +0530
geo-rep: fix the code bug introduced due to flake8 refactoring
Sorry for the bug, which got introduced due to code refactoring.
http://review.gluster.org/#/c/7311/
Change-Id: Ide519ca114aa8a7d7624d7af99945c857f069069
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/7417
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 506b4772daac2949c50988f196907c3c4e976367
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Apr 7 17:38:32 2014 +0530
gfapi: In glfs_set_volfile_server() remove the port number check.
The documentation for glfs_set_volfile_server() api says that the
port zero is a valid value. Specifying 0 uses the default port
number GF_DEFAULT_BASE_PORT. Hence removing the check for port being
zero.
Change-Id: I942a7fe54a418231a438ab67756537df8f28d2de
BUG: 1084964
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/7409
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 12e405d1944f3a2397418c3b8828c699500501e4
Author: Justin Clift <justin@gluster.org>
Date: Sat Apr 5 03:38:17 2014 +0100
tests: Increase bug-865825.t wait time for self-heal daemon
BUG: 1084653
Change-Id: I057bbd2e50803344552314b32d2d0e6240bf9604
Signed-off-by: Justin Clift <justin@gluster.org>
Reviewed-on: http://review.gluster.org/7404
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e6a2acfb983bc0529d927e10eba417ad64d2c5c0
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Mar 21 12:33:10 2014 +0530
geo-rep: code pep8/flake8 fixes
pep8 is a style guide for python.
http://legacy.python.org/dev/peps/pep-0008/
pep8 can be installed using, `pip install pep8`
Usage: `pep8 <python file>`, For example, `pep8 master.py`
will display all the coding standard errors.
flake8 is used to identify unused imports and other issues
in code.
pip install flake8
cd $GLUSTER_REPO/geo-replication/
flake8 syncdaemon
Updated license headers to each source file.
Change-Id: I01c7d0a6091d21bfa48720e9fb5624b77fa3db4a
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/7311
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a58a4d1deb0fe91b255056ef2b2530f88706e72f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Mar 27 15:04:40 2014 +0530
tests/afr: self-heal
Basic functional tests related to self-heal.
arequal-checksum.c is taken from
https://github.com/raghavendrabhat/arequal after consent from all
authors.
Change-Id: I43facc31c61375f4dbe58bbb46238e15df5c9011
BUG: 1080759
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7357
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1c45a2ded9dcdea852f10ab5940e49f05f459e9b
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Mar 4 12:04:37 2014 +0530
feature/barrier: Add statedump support
This patch adds statedump support for barrier. This currently dumps
barrier xlators private information and the queue of barriered fops.
Change-Id: I273eb6e676db02c40c363feeff58a79737dc041e
BUG: 1060002
Reviewed-on: http://review.gluster.org/7136
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ba3becdc28d28b482c719857b75e3d3e9a5154c0
Author: Varun Shastry <vshastry@redhat.com>
Date: Wed Feb 5 13:02:34 2014 +0530
features/barrier: add barrier translator
gluster feature page:
http://www.gluster.org/community/documentation/index.php/Features/Server-side_Barrier_feature
Change-Id: Ia9f8802a54d1ffbd1cf789b80f5d30819bf65f64
BUG: 1060002
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/6928
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4e8a111b065313b3677b454e70895ebe41f69dd8
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Sun Mar 30 08:37:02 2014 +0530
log: Add missing log message from glusterfsd.c to glusterfsd-messages.h
... by retaining GLFS_NUM_MESSAGES as 33 which is its correct value.
Also replace all occurrences of gf_log with gf_msg/gf_msg_debug.
Change-Id: Ibfbe1d645de521e8d59ca406f78b1a8eb08aa7e0
BUG: 1075611
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/7371
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 348c6ebb7f8f3827ce9e2d1157511f1336b4db8a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Apr 3 07:38:15 2014 -0400
rpm: fix broken glusterfs-server install of hooks
the %ghost hook directories are no longer ghosts now that files
are installed in them
Change-Id: I6133b891c73d87e4e35dc9c6c7ba7febbc9e2e7f
BUG: 1080970
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/7391
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Justin Clift <justin@gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3b0f3b504238a3ad6bfc4ba01e581e784b77ed9c
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Mar 26 16:55:12 2014 -0700
build: move argp-standalone into contrib/ directory
Change-Id: Iedcddf95c3577da644c0aebbb297b04c93f1b6fe
BUG: 1081274
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7352
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 49df64bcc744bc49ce487ed09bea9176daf6d15e
Author: Justin Clift <justin@gluster.org>
Date: Fri Apr 4 18:22:50 2014 +0100
cli: Trivial wording improvement of a comment
Change-Id: Ib569b39bdf0357c30c94c7a1b8d3ff87b811841c
Reviewed-on: http://review.gluster.org/7403
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Justin Clift <justin@gluster.org>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ed3398710808b3f3686a6613226e5a7d45fb1245
Author: Brian Foster <bfoster@redhat.com>
Date: Fri Apr 4 12:59:58 2014 +0000
afr: Simple 1-liner fix for crash in Rackspace
BUG: 1084485
Change-Id: I89ddf10add041638ef70baebbce0ec2807ef4b6d
Signed-off-by: Justin Clift <justin@gluster.org>
Reviewed-on: http://review.gluster.org/7402
Reviewed-by: Anand Avati <avati@redhat.com>
commit 27b2f5b60bed00fe285c87cbdffe17b2b03bc521
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Thu Apr 3 15:10:58 2014 +0530
cli : Removal of dead code
dead code reported by covscan is removed from cli-cmd-parser.c
Fix for coverity CID: 1195423
Change-Id: Ice1771dc8b3ef47fd2e63b380b12e850dc1d5d95
BUG: 789278
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7389
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 542928581a87127c6e4d0f12bdee52b9a6583265
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Mar 26 11:22:12 2014 +0530
tests/afr: select correct read-child for entry OPs.
Change-Id: If375c937579a18d603ed70232130a4664060e9d6
BUG: 1080759
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7344
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 972b3fb5b6ab811613784a726797e4be608ab0c8
Author: Justin Clift <justin@gluster.org>
Date: Thu Apr 3 18:33:19 2014 +0100
tests: Adjust test 767095 to cope with long hostnames
BUG: 1084147
Change-Id: Ie1ff8852a501690e681072c54620d305b5e20d6a
Signed-off-by: Justin Clift <justin@gluster.org>
Reviewed-on: http://review.gluster.org/7395
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ee3e2dbfa5c9c540f432bb4f7cbda6b9de0f2ebc
Author: Prashanth Pai <ppai@redhat.com>
Date: Tue Mar 25 16:15:15 2014 +0530
features/glupy: Add mem accounting support
When glusterfs is built from source using -DDEBUG flag and glupy
xlator is added to vol file, the brick process used to crash when
mounting the volume.
This fix is largely derived from the fix submitted for BZ #1035751.
Thanks to Justin Clift for helping in tracking this down.
BUG: 1035751
Change-Id: Id64f92eecc9335e34dd08812fe176774e7723c2c
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/7332
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 04515e5f3c5be513750f8d44427737149537431c
Author: Kotresh H R <khiremat@redhat.com>
Date: Tue Mar 25 11:11:41 2014 +0530
features/gfid-access: Fix possible inode memory corruption.
During lookup, the inode is not ref'd. Added code
to ref the inode in call path and unref in cbk path.
Also fixed a case where we should always be putting
linked inode into context as it is not guaranteed
that we get same inode that we passed in a call to
inode_link.
Change-Id: Iaec083a9258658bef3047e83956729d3dbcd9a59
BUG: 1080295
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7329
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 3d809470f08102faf3bfde8abd79516d545ca650
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Wed Mar 19 11:30:22 2014 +0530
cli: remove-brick no longer defaults to commit-force
Problem : When gluster volume remove-brick is executed with out any option, it
defaults to force commit which results in data loss.
Fix : remove-brick can not be executed with out explicit option, user needs to
provide the option in the command line else the command will throw back an usage
error.
Earlier usage : volume remove-brick <VOLNAME> [replica <COUNT>] <BRICK> ...
[start|stop|status|commit|force]
Current usage : volume remove-brick <VOLNAME> [replica <COUNT>] <BRICK> ...
<start|stop|status|commit|force>
Change-Id: I2a49131f782a6c0dcd03b4dc8ebe5907999b0b49
BUG: 1077682
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/7292
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <sam.somari@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 06fb7903cf6c12e09c01771c00b42479d7bf341b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 24 22:54:03 2014 +0530
cluster/afr: Remove eager-lock stub on finodelk failure
Problem:
For write fops afr's transaction eager-lock init adds transactions
that can share eager-lock to fdctx list. But if eager-lock finodelk
fop fails the stub remains in the list. This could later lead to
corruption of the list and lead to infinite loop on the list
leading to a mount hang.
Fix:
Remove the stub when finodelk fails.
Change-Id: I0ed4bc6b62f26c5e891c1181a6871ee6e4f4f5fd
BUG: 1063190
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6944
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d4ca20f3dd6e2dfe114b4bbaa0a2ef00f1d7ad49
Author: Varun Shastry <vshastry@redhat.com>
Date: Tue Mar 25 09:36:45 2014 +0530
tests/quota: Wait till the rebalance is complete
Change-Id: Ia6f0c81fb1542ce1de965a69a61535691df056c3
BUG: 1077159
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/7380
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Justin Clift <justin@gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 02de2da4bc6fa1a5ab885e74aca49cab35c7ebdd
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Mar 22 01:33:06 2014 -0700
gfapi: glfs_set_volfile_server() now entertains multiple calls
Previous API:
glfs_set_volfile_server (..., const char *host, ...) - single call
New API's:
glfs_set_volfile_server (..., const char *host1, ...)
glfs_set_volfile_server (..., const char *host2, ...)
Multiple calls to this function with different volfile servers,
port or transport-type would create a list of volfile servers
which would be polled during `volfile_fetch_attempts()`
glfs_unset_volfile_server (..., const char *host, ...) to remove
a server from the list (this is provided for future usage)
Change-Id: I313efbd3efbd0214e2a71465f33195788df406cc
BUG: 986429
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7317
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 449c2df356f32d3444f502a96d92fff2da97bf5a
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Mar 26 11:09:17 2014 +0530
tests/afr: gfid mismatch test
Change-Id: I12bae9c4035d5b28292e8085a5b600a3e22abaf4
BUG: 1080759
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7342
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d206d4b4f1733919687883f83f8153755f0e1443
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Mar 26 11:41:37 2014 +0530
tests/afr: select correct read-child for data OPs.
Change-Id: If84bc489b6c45bde3bdb858da5f1600cea78c8a5
BUG: 1080759
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7345
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c23d53054d092e48368e0e76955ebe15e9a721b8
Author: Susant Palai <spalai@redhat.com>
Date: Tue Feb 18 13:03:50 2014 +0000
DHT/Rebalance : Hard link Migration Failure
Probelm : __is_file_migratable used to return ENOTSUP
for all the cases. Hence, it will add to the failure
count. And the remove-brick status will show failure
for all the files.
Solution : Added 'ret = -2' to gf_defrag_handle_hardlink to
be deemed as success. Otherwise dht_migrate_file will try to
migrate each of the hard link, which not intended.
Change-Id: Iff74f6634fb64e4b91fc5d016e87ff1290b7a0d6
BUG: 1066798
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/7124
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 51e74c5d887168890c4d05f8adaddfb5105c0cd6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 26 11:03:01 2014 +0530
tests: Stale file lookup test
Change-Id: I6edfc5b7ee42677e92d9cff6a7180692d20e9310
BUG: 1080759
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7341
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 47890fc242194a6a1f3af3fa759c0f191c908591
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Mar 25 10:13:35 2014 -0700
doc: Update manpages
Change-Id: Id14c7c3229ed266cd15915a2136e3290ce2c5ed2
BUG: 1031328
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7338
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d51795bf721f7e253524a52344d0ce359e6f7996
Author: ShyamsundarR <srangana@redhat.com>
Date: Fri Dec 20 13:19:00 2013 +0530
log: enhance gluster log format with message ID and standardize errno reporting
Currently there are quite a slew of logs in Gluster that do not
lend themselves to trivial analysis by various tools that help
collect and monitor logs, due to the textual nature of the logs.
This FEAT is to make this better by giving logs message IDs so
that the tools do not have to do complex log parsing to break
it down to problem areas and suggest troubleshooting options.
With this patch, a new set of logging APIs are introduced that
take additionally a message ID and an error number, so as to
print the message ID and the descriptive string for the error.
New APIs:
- gf_msg, gf_msg_debug/trace, gf_msg_nomem, gf_msg_callingfn
These APIs follow the functionality of the previous gf_log*
counterparts, and hence are 1:1 replacements, with the delta
that, gf_msg, gf_msg_callingfn take additional parameters as
specified above.
Defining the log messages:
Each invocation of gf_msg/gf_msg_callingfn, should provide an ID
and an errnum (if available). Towards this, a common message id
file is provided, which contains defines to various messages and
their respective strings. As other messages are changed to the
new infrastructure APIs, it is intended that this file is edited
to add these messages as well.
Framework enhanced:
The logging framework is also enhanced to be able to support
different logging backends in the future. Hence new configuration
options for logging framework and logging formats are introduced.
Backward compatibility:
Currently the framework supports logging in the traditional
format, with the inclusion of an error string based on the errnum
passed in. Hence the shift to these new APIs would retain the log
file names, locations, and format with the exception of an
additional error string where applicable.
Testing done:
Tested the new APIs with different messages in normal code paths
Tested with configurations set to gluster logs (syslog pending)
Tested nomem variants, inducing the message in normal code paths
Tested ident generation for normal code paths (other paths
pending)
Tested with sample gfapi program for gfapi messages
Test code is stripped from the commit
Pending work (not to be addressed in this patch (future)):
- Logging framework should be configurable
- Logging format should be configurable
- Once all messages move to the new APIs deprecate/delete older
APIs to prevent misuse/abuse using the same
- Repeated log messages should be suppressed (as a configurable
option)
- Logging framework assumes that only one init is possible, but
there is no protection around the same (in existing code)
- gf_log_fini is not invoked anywhere and does very little
cleanup (in existing code)
- DOxygen comments to message id headers for each message
Change-Id: Ia043fda99a1c6cf7817517ef9e279bfcf35dcc24
BUG: 1075611
Signed-off-by: ShyamsundarR <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/6547
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bc0774211b0da8bbcac4adec0fece083bfbe735b
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Mar 26 17:30:32 2014 +0530
rpm: Include the hook scripts of add-brick, volume start, stop and set.
Change-Id: I9485da3d9a54a52cc524daff8f4f4caca3a6065d
BUG: 1080970
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/7346
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 06b40b0b0de4954b01c2de11070ef1b889cd33e2
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Mar 10 06:55:11 2014 +0000
glusterd: suppress spurious error message during startup
From glusterd log:
----------
E [glusterd-store.c:1981:glusterd_store_retrieve_volume] 0-: Unknown key:
brick-0
----------
The message is emitted from glusterd_store_retrieve_volume() when it reads the
volinfo file because it doesn't do anything with the key-value pair. Suppress the
error. The key is needed by glusterd_store_retrieve_bricks() which anyway
re-reads it.
Also change the log level to WARNING since we do not error out if an unknown key
is got while parsing the volinfo file.
Change-Id: Icd7962d9e16e0f90e6a37ee053dcafe97d2cab94
BUG: 1079279
Reviewed-on: http://review.gluster.org/7314
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 08ee891617e73a34ec17cf0678f33d7b944d6e1b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Mar 25 11:07:31 2014 +0530
cluster/afr: Sparse file self-heal canges
- Fix boundary condition for offset
- Honour data-self-heal-algorithm option
- Added tests for sparse file self-healing
Change-Id: I14bb1c9d04118a3df4072f962fc8f2f197391d95
BUG: 1080707
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7339
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ce05a07c72b8ed3361c502b5143359196b82bcbe
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Mar 23 08:01:15 2014 +0530
features/compress: Add mem accounting support for compress
Change-Id: I89a7a4cd64ef65ad3bab180d66797a62b4e1e195
BUG: 923540
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7320
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 96b8f40a5b11ced48266624d8354bab1a02052c1
Author: Justin Clift <justin@gluster.org>
Date: Fri Mar 21 20:13:16 2014 +0000
features/glupy: Rename Glupy python module to avoid namespace conflict
* Rename gluster.py to glupy.py to avoid namespace conflict (#1018619)
* Move the main Glupy files into glusterfs-extra-xlators rpm
* Move the Glupy Translator examples into glusterfs-devel rpm
* Add Glupy entry to the MAINTAINERS file
BUG: 1018619
Change-Id: I48de598ba5ae8eec0e7e276bbcca1abb0e549cef
Signed-off-by: Justin Clift <justin@gluster.org>
Reviewed-on: http://review.gluster.org/6979
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit abd8a604451a4f880fc0aa384fcc4d75714e2685
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Feb 27 08:23:33 2014 +0000
glusterd: op-version check for brickops.
cluster op-version must be atleast 4 for add/remove brick to proceed.
This change is required for the new afr-changelog xattr changes that
will be done for glusterFS 3.6 (http://review.gluster.org/#/c/7155/).
In add-brick, the check is done only when replica count is increased
because only that will affect the AFR xattrs.
In remove-brick, the check is unconditional failing which there will be
inconsistencies in the client xlator names amongst the volfiles of
different peers.
Change-Id: If981da2f33899aed585ab70bb11c09a093c9d8e6
BUG: 1066778
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7122
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fa72abad063133ec50889233e143a92078edfcea
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Feb 25 09:17:18 2014 +0530
glusterd: persistent client xlator/ afr changelog names
-Add a unique brick-id field to glusterd_brickinfo_t
-Persist the id to the brickinfo file
-Use the brick-id as the client xlator name during vol create, add-brick and
replace-brick operations.
-For older volumes,generate the id in-memory during glusterd restore but defer
writing it to the brickinfo file until the next volume set operation.
-send and receive the brick-ids during peer probe.
Feature page:
www.gluster.org/community/documentation/index.php/Features/persistent-AFR-changelog-xattributes
Related patch:
http://review.gluster.org/#/c/7122
Change-Id: Ib7f1570004e33f4144476410eec2b84df4e41448
BUG: 1066778
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7155
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6c1e5dcef50a2f0043de19bfb1d49072bc61ac15
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Fri Feb 7 16:45:58 2014 +0530
glusterfsd: Remove dead code.
Previous cleanup of this function had removed some lines
which had left dead code. Just removing that.
Fix for coverity CID: 1167461 .
Change-Id: I2a34fc407ce0eb4c4ba759c8ce6574a00b37020a
BUG: 789278
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/6937
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0420e48591a66b914b4b335416a6a354921da39b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Mar 22 19:30:45 2014 +0530
encryption/crypt: Add mem-accounting for crypt xlator
Without these changes crypt.t crashes when compiled with -DDEBUG
Change-Id: I1f7372aa30a09dbe3ae81d1dd598cf36e17fe0b7
BUG: 1030058
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7319
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f240e24033354b72e71bcbbb1a797f122d796c34
Author: Susant Palai <spalai@redhat.com>
Date: Thu Feb 27 06:50:15 2014 +0000
Glusterd/Remove-brick: Reconfigure the nfs server volfile upon remove-brick start
Problem : For remove-brick start operation all client volfiles are reconfigured
except nfs server volfile. Hence, even after layout is fixed by the rebalance
process, the nfs clients dont see the change and go on creating directories and
files in the decommissioned brick which leads to data loss after remove-brick
commit.
Solution : Reconfigure the nfs server volfile for remove-brick start
credit: kaushal@redhat.com
spalai@redhat.com
Change-Id: Ib8cd8b45a9e1f888d5e00dff65cdf77c1613a2af
BUG: 1070734
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/7162
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit acf0f23ad6f0b721315fce95d981f16ac57160f3
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Mar 10 18:28:02 2014 +0530
debug/io-stats:fix compile warning
Compiler Warning:
---------------------------------------------------------
io-stats.c: In function 'io_stats_dump':
io-stats.c:950:24: warning: comparison between 'gf1_cli_stats_op' and
'enum gf1_cli_info_op' [-Wenum-compare]
if (op == GF_CLI_INFO_ALL ||
io-stats.c:951:24: warning: comparison between 'gf1_cli_stats_op' and
'enum gf1_cli_info_op' [-Wenum-compare]
op == GF_CLI_INFO_CUMULATIVE)
^
---------------------------------------------------------
Fix: Use the appropriate enum in function defintion of io_stats_dump().
Note: Using the same BZ ID as the commit that introduced this argument.
Change-Id: I24e1aaf9ab86b4f337e3daa729d561ec208f2a95
BUG: 1030580
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7217
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8b11b102422b7d4f60d3bc4d3f516d9efa1cfd9b
Author: Anand Avati <avati@redhat.com>
Date: Thu Jan 16 16:14:36 2014 -0800
cluster/afr: refactor
- Remove client side self-healing completely (opendir, openfd, lookup)
- Re-work readdir-failover to work reliably in case of NFS
- Remove unused/dead lock recovery code
- Consistently use xdata in both calls and callbacks in all FOPs
- Per-inode event generation, used to force inode ctx refresh
- Implement dirty flag support (in place of pending counts)
- Eliminate inode ctx structure, use read subvol bits + event_generation
- Implement inode ctx refreshing based on event generation
- Provide backward compatibility in transactions
- remove unused variables and functions
- make code more consistent in style and pattern
- regularize and clean up inode-write transaction code
- regularize and clean up dir-write transaction code
- regularize and clean up common FOPs
- reorganize transaction framework code
- skip setting xattrs in pending dict if nothing is pending
- re-write self-healing code using syncops
- re-write simpler self-heal-daemon
Change-Id: I1e4080c9796c8a2815c2dab4be3073f389d614a8
BUG: 1021686
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6010
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2befe695fb20ca1aecfe11caf0f4a872b86aca3e
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Mar 19 18:03:54 2014 +0100
build: do not create versioned <xlator>.so files
There has been a misspelled option in the Makefile.am files. The option
is called -avoid-version, and not -avoidversion.
It is not trivial to provide a test-case for this. One way would be to
check generated RPMs with a command like this (output should be empty):
$ rpm -qlp *.rpm | grep -E '/xlator/.+.so.0'
Change-Id: I2a6cc557eada4d098b73af5a254f8c75707543da
BUG: 1078365
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7299
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ceb777f19c9a11a09d7facb92b4e7f3592a3a77d
Author: Kotresh H R <khiremat@redhat.com>
Date: Tue Mar 18 14:45:42 2014 +0530
geo-rep/glusterd: Fix geo-rep status on introduction of volume lock
Getting op context in 'glusterd_op_gsync_set' is no longer
valid as it is expected that 'rsp_dict' sent from caller is
filled. It was fine till now as no one was setting the op
context. The introduction of volume locks sets it,
consequently breaking geo-rep status command. Hence the
code that gets dict from op context if present is removed.
Also corrected some indentation issues in 'glusterd_op_gsync_set'
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Change-Id: Ieacd6e6c9be3c92159f849caca2acf5aabca1e32
BUG: 1077697
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7289
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3b0737d70c6611a81d6653be6be93635ef09a433
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Mar 19 12:00:44 2014 +0530
geo-rep: Fix ValueError - signal only works in main thread
When a worker process not confirmed within 60 seconds of start
then monitor thread was terminated instead of stopping and restarting
the worker thread.
Before terminate monitor thread tries to add a signal handler for
SIGTERM to cleanup the stuff before terminate. Signal handling will
not work inside thread, so ValueError was raised.
This patch will not terminate monitor thread, instead only kills and
restarts the worker.
Change-Id: I14df26c0cc3097af29293c81536c13b86075e28f
BUG: 1078068
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/7294
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 7bdf5d2e6a86ea617f6894751c34c0563da5c706
Author: arvindch <achembarpu@gmail.com>
Date: Mon Mar 17 20:50:39 2014 +0530
fixed a few misspellings. no code changes present
Change-Id: Ia1a771301e9f1becbbffd8afd7eb68bec9696ef8
BUG: 1075417
Signed-off-by: arvindch <achembarpu@gmail.com>
Reviewed-on: http://review.gluster.org/7283
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Anand Avati <avati@redhat.com>
commit 85eab91b742d04f92ef98c3a076be68249b2dfb1
Author: Luis Pabon <lpabon@redhat.com>
Date: Sun Mar 16 23:07:19 2014 -0400
build: Remove cmockery2 from repo
While we wait for cmockery2 to be available from Fedora,
we can remove cmockery2 from the repo.
BUG: 1077011
Change-Id: I75d462c607cd376a5d838ea83f4d12eb59757e73
Signed-off-by: Luis Pabon <lpabon@redhat.com>
Reviewed-on: http://review.gluster.org/7281
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 97efbd63c8fd1ae735d9ff5c6efff67d41670968
Author: AkshataDM <oxta28@gmail.com>
Date: Sat Mar 15 23:33:38 2014 +0530
Made spelling changes to 19 files
Change-Id: If91cf44578fe0b5176ea01ae5c5962e31606f640
BUG: 1075417
Signed-off-by: AkshataDM <oxta28@gmail.com>
Reviewed-on: http://review.gluster.org/7280
Reviewed-by: Varun Shastry <vshastry@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 6a955409372b9e024127115b23cd9a253c03ff0b
Author: Meghana <mmadhusu@redhat.com>
Date: Tue Mar 11 14:52:34 2014 +0000
Changing the errno in glfs_h_rename
Change-Id: I006215d910ee854aee488f3880f39ed425f294cc
BUG: 1075488
Reviewed-on: http://review.gluster.org/7226
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d852f6debad1743134f2bb192d63c6cc61d7f52c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 12 19:56:08 2014 +0530
storage/bd: Fix allocations/deallocations
Change-Id: I39c9eb083fc1c144fe6f011dd983b877fbbff0f7
BUG: 1075717
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7230
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 1dc099186ace8d1ec1a09eef7d1f35d217866128
Author: Varun Shastry <vshastry@redhat.com>
Date: Wed Mar 12 15:22:14 2014 +0530
features/quota: fix the dict leak when quota is off
Change-Id: Iafe0c5104e38a1e34de1f2c2a19682178eb60e11
BUG: 1075506
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/7227
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c2511ca4c0d950c5254def719a9a754b37341b72
Author: Anand Avati <avati@redhat.com>
Date: Sat Mar 8 12:50:47 2014 -0800
locks: fix unconditional op_ret success of entrylk
Bug introduced in recent refactoring. op_ret of entrylk() was always
getting set to 0 even though second locker wouldn't have gotten a lock.
This was resulting in multiple contenders to get locks granted at the
same time.
Change-Id: I99c187a9285fb80cc500b38f468f2ebda7048cab
Signed-off-by: Anand Avati <avati@redhat.com>
BUG: 849630
Reviewed-on: http://review.gluster.org/7224
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 449b521a0180a699f33de7cc378d20ce4f79b3a8
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Mar 11 09:32:03 2014 -0700
scripts: CTDB hooks should add `_netdev` for network mounts
Change-Id: I86ad5e9ed291866a8d478768fb447e269f51c39e
BUG: 1075182
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7221
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Jose A. Rivera <jarrpa@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1f1ec29d5afd68830dc8bf7f41cad2f84809b5d3
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Mar 6 19:09:13 2014 +0530
hook-scripts: Move smb hooks to right place.
Moved the hook-scripts to dirs corresponding to event.
Also, edited S30samba-set.sh to with changes in
other two hook scripts to bring uniformity.
Change-Id: Ib98c0a18d4bb5d0ba4b881b2e19b40d72580b1c2
BUG: 1073468
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/7201
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Bala FA <barumuga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1a318ac835f3e95002e90517dbeff852a7934558
Author: Justin Clift <justin@gluster.org>
Date: Thu Mar 6 16:53:50 2014 +0000
tests: Add initial sanity checks to the GlusterFS Test Framework
BUG: 1073168
Change-Id: I0b995d94fe83053d3294df1b5fad2eef3b4355d3
Signed-off-by: Justin Clift <justin@gluster.org>
Reviewed-on: http://review.gluster.org/7193
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 96ef3e0f906f46639ebf45a45ad1a152448d1ec3
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Mar 5 04:46:50 2014 +0000
glusterd: send/receive volinfo->caps during peer probe.
Problem: volinfo->caps was not sent over to newly probed peers, resulting in a
'Peer Rejected' state due to volinfo checksum mismatch.
Fix: send/receive volinfo capability when peer probing.
Change-Id: I2508d3fc7a6e4aeac9c22dd7fb2d3b362f4c21ff
BUG: 1072720
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7186
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 050b39515f4f4d7ba9081e200f79932a8bf6f7d5
Author: Satheesaran <satheesaran@gmail.com>
Date: Thu Mar 6 15:40:31 2014 +0530
glusterd: Fixed typo in console message during volume create
While creating a volume, if the brick is created on the root
partition, then the error statement is thrown.
This error statements was containing two "is" in it.
Removed one of the "is"
Change-Id: I0d83f0feccda34989f7e2b97041d1f15ec9e2f00
BUG: 1065551
Signed-off-by: Satheesaran <satheesaran@gmail.com>
Reviewed-on: http://review.gluster.org/7198
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 96a0e311324e37c91597f5e935dd7c30d77a7695
Author: Justin Clift <justin@gluster.org>
Date: Fri Mar 7 18:01:05 2014 +0000
build: Don't build geo-replication rpms when on EL5
Also fixes a typo bug where geo-replication isn't
being disabled correctly
BUG: 1074045
Change-Id: I28d42637bedcc28d65b6a34ab0183559202c4aed
Signed-off-by: Justin Clift <justin@gluster.org>
Reviewed-on: http://review.gluster.org/7210
Reviewed-by: Joe Julian <joe@julianfamily.org>
Tested-by: Joe Julian <joe@julianfamily.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 1dadc23b6318f0d404e12e674a49db1931a3b379
Author: Kotresh H R <khiremat@redhat.com>
Date: Fri Mar 7 16:35:01 2014 +0530
geo-rep: quick-fix for remote xtime set failed
Remote xtime is required for failover/failback,
this patch is quick fix to avoid the OSError.
Code is masked out, this need to be resolved when
failover/failback is worked on.
Change-Id: If339d88a2ccd8ef18a3b3c015df765c93dcb020c
BUG: 1073844
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7206
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ac3c557df120a03eedb3eb4fd048841f4fce10e9
Author: Luis Pabon <lpabon@redhat.com>
Date: Thu Feb 20 13:50:19 2014 -0500
build: GlusterFS Unit Test Framework
This patch will allow for developers to create unit tests for
their code. Documentation has been added to the patch and
is available here:
doc/hacker-guide/en-US/markdown/unittest.md
Also, unit tests are run when RPM is created.
BUG: 1067059
Change-Id: I95cf8bb0354d4ca4ed4476a0f2385436a17d2369
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Signed-off-by: Luis Pabon <lpabon@redhat.com>
Reviewed-on: http://review.gluster.org/7145
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Justin Clift <justin@gluster.org>
Tested-by: Justin Clift <justin@gluster.org>
commit e42ab871335479015524b9f4591b5b6957d2f0cb
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Feb 28 14:41:52 2013 +0530
cli: Changed log rotate command format to common format.
Problem:
The syntax of log rotate was
volume log rotate <volname> [<brick>]
All other commands are of the form:
volume <verb|noun> <volname> [<actions>|options]
Solution:
Changed log rotate command usage to common format.
Old syntax is also supported, it will be deprecated
in next release.
Change-Id: Ia6f6665185a1549c6f79ca763599b446f29e2c78
BUG: 844187
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/4594
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit aa5229bc6ae6ffc83ba9bd584a53b0da9847e41a
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Mar 4 16:53:33 2014 +0000
api: add glfs_get_volfile
From the API-header description:
> Sometimes it's useful e.g. for scripts to see the volfile, so that
> they can parse it and find subvolumes to do things like split-brain
> resolution or custom layouts. The API here was specifically intended
> to make access e.g. from Python as simple as possible.
>
> Note that the volume must be started (not necessarily mounted) for
> this to work.
Change-Id: If3f55ee9611cdf4b77aa53659f0af0d21957817d
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/7183
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b80090f5411b96f584fdf44f99874fc413a6474e
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Jan 21 23:41:07 2014 +0530
rpc: transport may be destroyed while rpc isn't
rpc_clnt object is destroyed after the corresponding transport object is
destroyed. But rpc_clnt_reconnect, a timer driven function, refers to
the transport object beyond its 'life'. Instead, using the embedded
connection object prevents use after free problem wrt transport object.
Also, access transport object under conn->lock.
Change-Id: Iae28e8a657d02689963c510114ad7cb7e6764e62
BUG: 962619
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6751
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 26f7a84870e396c0749045018b41abb4769e198b
Author: Poornima G <pgurusid@redhat.com>
Date: Fri Feb 28 12:13:55 2014 +0530
libglusterfs/inode: Fix NULL dereferences.
There could be scenarios where the inode_ctx_get() can
be called to only check if the context exists, in such
cases the buffer for the context might not have been passed.
Hence fix inode_ctx_get() to not crash, when the buffer
is not passed.
Change-Id: I607d86eb401ccab0e5cd75f6f977c454994ec063
BUG: 789278
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/7167
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6f1608189e5e9697448972d35a04d49b29955915
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Feb 28 17:34:03 2014 +0100
Reduce logging caused by non-existing extended attributes
This changes the following log messages from INFO (default value) to
DEBUG. We do not really care if someone tries to read extended
attributes that do not exist.
[2013-12-09 12:19:05.924497] E [posix.c:3539:posix_fgetxattr] 0-dis-rep-posix: fgetxattr failed on key system.posix_acl_access (No data available)
[2013-12-09 12:19:05.924545] I [server-rpc-fops.c:863:server_fgetxattr_cbk] 0-dis-rep-server: 13074: FGETXATTR 1 (b8381953-ffa5-40fa-90dd-ae122335cc4b) (system.posix_acl_access) ==> (No data available)
Change-Id: Idbbeb026f81e67025a2b36d7bfeb125ad2a1f61b
BUG: 1027174
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7171
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 773ae2b50be60f017ceb0c1c8dfb7825c8a918c4
Author: Susant Palai <spalai@redhat.com>
Date: Fri Feb 28 17:19:43 2014 +0000
cli: Rectify grammar in the "Usage" of "rebalance" command
Problem: Currently Usage of rebalance command is : " Usage: volume rebalance
<VOLNAME> [fix-layout] {start|stop|status} [force] "
1) "force" option can be only used with "start" .
2) "fix-layout" option can be only used with "start"
But the current usage says "fix-layout" operation can be stopped and can get the
status of "fix-layout" operation and also "stop" ,"status" operation can be used
with "force" option which is not correct.
Change-Id: I48e6c64c124f5803c8f09c78df0e14dc2b6a348a
BUG: 1071411
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/7172
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 6ba35bc93ac3e93d62d6c29657e09bbf0a2505e3
Author: Justin Clift <justin@gluster.org>
Date: Fri Feb 28 15:17:21 2014 +0000
build: Add missing rpmbuild/BUILD dir for CentOS 5.x
The rpmbuild/BUILD directory isn't created automatically
by the build system on CentOS 5.x. This 1-line patch
adds its creation to the build process.
BUG: 1071504
Change-Id: I90ad70608776cb491f2ba92fb7d6044cff4defcc
Signed-off-by: Justin Clift <justin@gluster.org>
Reviewed-on: http://review.gluster.org/7175
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a8dcb9411a9af0a5b0aa7a0d7293bc7756002869
Author: Edward Shishkin <edward@redhat.com>
Date: Fri Dec 13 21:17:44 2013 +0100
Added test case for crypt translator
Change-Id: I7a28a1285c19c3279c2f71e9d9914cf14c761858
BUG: 1030058
Signed-off-by: Edward Shishkin <edward@redhat.com>
Reviewed-on: http://review.gluster.org/6504
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4b3f3a00abfbaaabb39e262ed55b8c9c07ef40fd
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jan 28 10:06:13 2014 +0100
write-behind: track filesize when doing extending writes
A program that calls mmap() on a newly created sparse file, may receive
a SIGBUS signal. If SIGBUS is not handled, a segmentation fault will
occur and the program will exit.
A bug in the write-behind translator can cause the creation of a sparse
file created with open(), seek(), write() to be cached. The last write()
may not be sent to the server, until write-behind deems this necessary.
* open(.., O_TRUNC, ...)/creat() the file, it is 0 bytes big
* seek() into the file, use offset 31
* write() 1 byte to the file
* the range from byte 0-30 are unwritten so called 'sparse'
The following illustration tries to capture this:
Legend:
[ = start of file
_ = unallocated/unwritten bytes
# = allocated bytes in the file
] = end of file
[_______________#]
| |
'- byte 0 '- byte 31
Without this change, reading from byte 0-30 will return an error, and
reading the same area through an mmap()'d pointer will trigger a SIGBUS.
Reading from this range did not trigger the outstanding write() to be
flushed. The brick that receives the read() (translated over the network
from mmap()) does not know that the file has been extended, and returns
-EINVAL. This error gets transported back from the brick to the
glusterfs-fuse client, and translated by the Linux kernel/VFS into
SIGBUS triggered by mmap().
In order to solve this, a new attribute to the wb_inode structure is
introduced; the current size of the file. All FOPs that can modify the
size, are expected to update wb_inode->size. This makes it possible for
extending writes with an offset bigger than EOF to mark the unwritten
area as modified/pending.
Change-Id: If5ba6646732e6be26568541ea9b12852a5d0b988
BUG: 1058663
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/6835
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ca8e0ad79ad9a443f733566677b9f56a9eeec04a
Author: Kotresh H R <khiremat@redhat.com>
Date: Tue Feb 25 16:20:46 2014 +0530
geo-rep/gfid-access: Fix errno for non-existent GFID.
Because of http://review.gluster.org/#/c/6318/ patch,
ESTALE is returned for a lookukp on non-existent GFID.
But ENOENT is more appropriate when lookup happens
through virtual .gfid directory on aux-gfid-mount
point. This is avoids confusion for the consumers
of gfid-access-translator like geo-rep which expects
ENOENT.
Change-Id: I4add2edf5958bb59ce55d02726e6b3e801b101bb
BUG: 1069191
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/7154
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3446b855f5d057a28c275670959a06bccd29e4be
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jan 16 01:24:41 2014 +0530
socket: don't send notification 'up' on socket_writev failure
Change-Id: If4e4b95fe025a412f25313d83c780046dfec5116
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6716
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 3efc3e8c144ac4a53a9d930b817edaf144ba1647
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Feb 16 16:58:46 2014 +0100
rpm: drop the glusterfs-devel dependency from glusterfs-api
This dependency was introduced when the Fedora packaging change for Bug
1016938 was (incorrectly) merged back into the upstream community
version.
Change-Id: I74a52c96533fa381e86b47f719480f00b12722ac
BUG: 1065750
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/7022
Reviewed-by: Justin Clift <jclift@redhat.com>
Tested-by: Justin Clift <jclift@redhat.com>
commit f8bd38c919e61a3f182e35226f52ab4ccc81d35b
Author: Prashanth Pai <ppai@redhat.com>
Date: Mon Feb 17 20:42:42 2014 +0530
feature/compress: Validate option and enable doc
* Validate network.compression option
* Enable descriptions of xlator configurable options
* Improve indentation in code
* Make network.compression.mode not configurable by user.
This is similar to "iam-self-heal-daemon" option in AFR xlator.
Fixes BUGs: 1065658, 1065640, 1065655
Change-Id: I99d82b574ee0e5c8c2baf5f5d52dbf8d015d330a
BUG: 1065640
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/7024
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5800fa7f94da1e3ecb30971d82fa7b8b0affdbbe
Author: Vijaykumar Koppad <vkoppad@redhat.com>
Date: Wed Feb 19 18:51:26 2014 +0530
build: fail configure if the libxml2 devel package is missing.
Problem:
Geo-replication uses volume info xml output.
While installing glusterfs through build+install from source,
and if the libxml2-devel package is not present in the system,
build will succeed with just warning and XML output : no.
If user fails to observe this and doesn't know that
geo-rep is dependent on xml output, user won't be able use
geo-rep.
Solution:
If libxml2-devel is unavailable, and if geo-rep is enabled error out in configure,
otherwise just warn with XML_OUTPUT = no.
If the xml-output is disabled while configuring, error out if
geo-rep is enabled, otherwise just warn.
Change-Id: Icde5d0c1e5f3b869e7db6ed6a046bdc49b450fcb
BUG: 1066997
Signed-off-by: Vijaykumar Koppad <vkoppad@redhat.com>
Reviewed-on: http://review.gluster.org/7131
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a0b1400b07cadba0c89a7e82e682b2ff1a8ddc8a
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Feb 21 12:45:48 2014 -0800
extras/hookscripts: Add `%P` as default relative root
ctdb in its monitoring script looks for the "path" variable
values at the system level not at share level.
This relative root path, if any should be default for all
volumes, to avoid issues with ctdb when doing subdirectory shares.
Error:
2014/02/21 12:50:34.355754 [41083]: ERROR: samba directory "/foodir" not available
Fix: Add %P in your smb.conf
[gluster-foodir]
...
...
path = %P/foodir
...
...
Change-Id: If3c110d844ba8301c901dbce40b23cac99d6d55b
BUG: 1068776
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/7147
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4950ab906acd2b9e8781359ab9178cb8bb504411
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Feb 15 17:54:38 2014 +0530
performance/io-threads: Remove code duplication
Change-Id: Ic905cc6074c796efce2972857b79ab53700a2de4
BUG: 1065657
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7010
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 690bccffa24b48b874b0e25778efc5b56d78b954
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Feb 18 12:22:59 2014 +0530
glusterd: Check for ctx before dereferencing it.
Fix for coverity CID: 1175010 & 1175011
Change-Id: Ib894fadf94c36704166ac0e2a3b6febf9b3fe446
BUG: 789278
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/7025
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 71029f8e3b4e22bcc1a9a8171d9b0492224d404e
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Feb 18 16:47:09 2014 +0530
rpc/socket: Avoid excessive INFO logs when SSL is not configured.
Change-Id: I7f4dd2ae4225c8d3783417d0c3d415178f04c0da
BUG: 1067011
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/7031
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fba54037f0f4da4c720f44c34fe9c0692ca5dec3
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Feb 18 15:44:56 2014 +0530
build: Don't discard CFLAGS in configure
The configure script was discarding the passed CFLAGS inadvertently.
This caused failures while building rpms on epel7 and fedora-{19,20}, as
the hardened CFLAGS passed by rpmbuild on these distros were discarded
which lead to the failure of rpmbuild.
Thanks to Neils de Vos for helping track this down.
Change-Id: I5b2aa5d449d13bf67df6c19cda178bddfe6c3652
BUG: 1066385
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/7029
Reviewed-by: Justin Clift <jclift@redhat.com>
Tested-by: Justin Clift <jclift@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 468229f36f5740babd29b6b7d982a5e9b1b3554b
Author: Justin Clift <jclift@redhat.com>
Date: Wed Feb 19 14:19:03 2014 +0000
Changed Amar's email address to his gmail one
Change-Id: Ia4a3d4f3e1be6dfcf0c23e8d481475927e3605da
Reviewed-on: http://review.gluster.org/7133
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit d027e588909f025bd8d7f83201ad915fd100c428
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Feb 13 12:31:58 2014 +0530
protocol/auth: Fix a possible double free.
Assign NULL to addr_cpy to avoid double free.
Fix for coverity CID: 1124891
Change-Id: I0cd6721f066170190d8b5441ecdbc1704ed5e75b
BUG: 789278
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/6993
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d50c88f01d07e00cda99de5c6050913a6af22f41
Author: Poornima G <pgurusid@redhat.com>
Date: Wed Feb 19 14:12:29 2014 +0530
libgfapi: In glfs_resolve_at(), do not override the previous return value.
Overriding ret to contain glfs_loc_touchup()s' return value implies that
if glfs_loc_touchup() is successful, glfs_resolve_at() is also successful
which is not necessarily true. This was causing glfs_resolve_at() to
succeed even if it couldn't resolve, thus create and other fops would
fail. Hence overriding ret only if glfs_loc_touchup() fails.
Change-Id: I0804afbd120b3798abe07e870bfc40bf162bc289
BUG: 1066837
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/7125
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a6adcb337bfabcee1a1cbbc7bd190c6d2ab17721
Author: Poornima <pgurusid@redhat.com>
Date: Tue Feb 4 22:52:14 2014 +0000
mount/fuse: Fix the NULL dereference errors reported by coverity.
Change-Id: I9df57e11b115d7323931735c86b586c0b65fa414
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6990
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 35a12a99ba527486c26cb17cf5dc9c02e467c4cb
Author: Soumya <skoduri@redhat.com>
Date: Sat Feb 15 16:08:22 2014 +0530
Docs: Fixed few broken link issues in the doc admin_settingup_clients.md Signed-off-by: Soumya <skoduri@redhat.com>
Change-Id: If01c1a34aaf6a84b3c95d56a9536b38cd9773cbe
Reviewed-on: http://review.gluster.org/7009
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 44f1a20d363805f4a204e8daa6ce7be8f2e331d1
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Feb 10 17:11:03 2014 +0530
io-cache: Unlock and then goto out in failure case.
Fix for coverity bug CID:1124625
Change-Id: I76df453a17f2af7c48a80b6fc0ccd411ab96e371
BUG: 789278
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/6949
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 16d48fee1ddb899b81d72baa1b60c7534648f3e4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jan 8 17:01:44 2014 +0530
protocol/client: conn-id should be unique when lk-heal is off
Problem:
It was observed that in some cases client disconnects
and re-connects before server xlator could detect that a
disconnect happened. So it still uses previous fdtable and ltable.
But it can so happen that in between disconnect and re-connect
an 'unlock' fop may fail because the fds are marked 'bad' in client
xlator upon disconnect. Due to this stale locks remain on the brick
which lead to hangs/self-heals not happening etc.
For the exact bug RCA please look at
https://bugzilla.redhat.com/show_bug.cgi?id=1049932#c0
Fix:
When lk-heal is not enabled make sure connection-id is different for
every setvolume. This will make sure that a previous connection's
resources are not re-used in server xlator.
Change-Id: Id844aaa76dfcf2740db72533bca53c23b2fe5549
BUG: 1049932
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6669
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cf047f782c3372882846293afad82d5b3f4f4f86
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Feb 14 08:20:44 2014 -0500
storage/posix: lgetxattr called with invalid keys on the bricks
More invalid keys have crept in since this was fixed. We need a better
strategy for avoiding this than the current noticed-in-an-strace...
Cleaning tabs while I'm at it.
Change-Id: I2ea97f6d1ab2a9fd569b5b5e01a4de891401fb81
BUG: 765202
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/7003
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bb44a66c5ee3ba4b2de7f3cc11ff3571452d8335
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Feb 12 14:37:23 2014 +0530
glusterfsd: Use gf_strdup instead of assigning a literal.
Fix for coverity bug CID:1124340
Change-Id: Ibf8700bdeaaddade02e63470a773c5fe2aabc645
BUG: 789278
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/6984
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 29e6c309418d36cf28be1624bad5fdb766f026c0
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sat Feb 15 12:14:19 2014 +0530
rpc: Fix a crash due to NULL dereference
Change-Id: Ib2bf6dd564fb7e754d5441c96715b65ad2e21441
BUG: 1065611
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/7007
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bcac829147632d6fe3969137fa2a04974c78df09
Author: Poornima <pgurusid@redhat.com>
Date: Wed Feb 12 03:18:43 2014 +0000
protocol/client: Fix the possible resource leaks.
Change-Id: Ib86dee366f5a6f0971c6472d1fb2c32dbf7f0102
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6985
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9de0fcb8cd05bdf1116e739b4742ab0cceeca353
Author: Ira Cooper <ira@samba.org>
Date: Tue Feb 11 07:05:29 2014 -0500
glusterd: Free dup_value when error path is taken.
When the error path is taken here, the data that was allocated for
dup_value is never freed. This patch frees it.
Thanks to Kaleb Keithley <kkeithle@redhat.com> for his suggestions on how
to fix this.
Change-Id: Iad88b9ab035602d15961b46c4954d54d54e0d65e
CID: 1124705
BUG: 789278
Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-on: http://review.gluster.org/6780
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit cc82a2748e24b6c37d648b6acd86e555f8cd51e9
Author: Jose A. Rivera <jarrpa@redhat.com>
Date: Wed Feb 5 08:50:30 2014 -0600
libgfapi: Add proper NULL checks
Two spots check for NULL after the pointer in question has already been
dereferenced. Checked for NULL (and set errno when needed) at appripriate
spots, added a few NULL checks further up the stack, and some whitespace
cleanup.
BUG: 789278
CID: 1124800
CID: 1124805
Change-Id: I1dd4ad3f285cca36f4e3f739288f154ec120aebb
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-on: http://review.gluster.org/6908
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 125b72360068289101b14fbd9707790db77e9657
Author: Jose A. Rivera <jarrpa@redhat.com>
Date: Wed Feb 5 09:11:55 2014 -0600
glusterfsd: Check for NULL before dereference.
BUG: 789278
CID: 1124805
Change-Id: I5926a4e59790f142d65f034726c9c369c2ad7808
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-on: http://review.gluster.org/6909
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1ee1957141dfba748810a06fb799a626296e24f3
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Feb 11 02:22:32 2014 +0000
glusterd/Vol-Locks : Moving globals into glusterd priv and code refactoring
Moved globals(vol_lock and txn_opinfo dicts and global_txn_id) into
glusterd priv
Moved glusterd_op_send_cli_response() out of gd_unlock_op_phase
as gd_unlock_op_phase and glusterd_clear_txn_opinfo should only
be called if the txn id has been successfully generated. The
cli resp should be sent irrespective of that.
Changed log levels from ERROR to WARNING for some volume lock logs
where the logs are expected and is not an error
Added logs for better transparency of transaction ids.
Change-Id: Ifac9b23aa9f1648c9ae252cfd3ac50bb2ed46728
BUG: 1011470
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/6976
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9019200ef50f1441d2306bc332afd732acef07d4
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Feb 12 17:23:28 2014 +0530
add build-gfid option to enable pgfid tracking ...
.. for inode to pathname mapping
Change-Id: I0486d85b02e86d739fc1d8ea16d118fb666abf60
BUG: 1064863
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6989
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7906f730f2b1289952557c9177140d1900e4ba63
Author: Justin Clift <jclift@redhat.com>
Date: Wed Feb 12 04:17:29 2014 +0000
Removed the old and unused non-Glupy Python bindings code
BUG: 1064096
Change-Id: Ifd34f46f0f0b45bbc27d35953e6ecbca36753886
Signed-off-by: Justin Clift <jclift@redhat.com>
Reviewed-on: http://review.gluster.org/6980
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 23d64eb9087b9d77112256d57efa76d013a474d4
Author: Justin Clift <jclift@redhat.com>
Date: Thu Feb 6 16:24:25 2014 +0100
Clean up some weirdness with the gf_resolve inet defines
Change-Id: I6bf6101aa0b5d6624891a8ebed2ac1fec2e11e1c
Reviewed-on: http://review.gluster.org/6948
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit de49cb48c3e07143fb6927fa3ae8264549be760b
Author: Anand Avati <avati@redhat.com>
Date: Mon Jan 27 00:58:45 2014 -0800
syncops: add support for custom PID
AFR self-heal needs to issue syncops with special PID. Extend
the custom UID/GID support to include custom PIDs
Change-Id: I736c0e177f862b029f203acc87f9eb46c8cb839b
BUG: 1021686
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6888
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit c6a52d9d57ffa5e1439ce57cf74117014c744a1f
Author: Anand Avati <avati@redhat.com>
Date: Thu Feb 6 12:32:01 2014 -0800
storage/posix: calculate checksum only over read data
If the last block of a file is not aligned to the requested
size, checksum is calculated over junk data in the iobuf. Or
it could be zeroes, resulting in a spurious checksum match
in self-heal.
Change-Id: I41422e08de90013dabfc348ec6fbb8ecdd4f8fb8
BUG: 1021686
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6932
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit d14f60ec1430dc456437cfb54a19a4cfc3d7a593
Author: Anand Avati <avati@redhat.com>
Date: Fri Feb 7 14:29:34 2014 -0800
core: add @xdata parameter to syncop_[f]removexattr()
To be used in afr metadata self-heal
Change-Id: I8dac4b19d61e331702427eeb5b606aab3d20b328
BUG: 1021686
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6941
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit f2b9e926a18f8eb1e8389b9fa24306be9c1a03e9
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Feb 12 14:39:03 2014 +0100
Use libglusterfs wrapper to make setxattr portable
BUG: 764655
Change-Id: I332922521bef5684f18d5f7b226cb36d5303ae47
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6982
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d16989e35b085e1900d563b6a5bff1e2b20a7513
Author: Poornima <pgurusid@redhat.com>
Date: Wed Feb 12 02:44:09 2014 +0000
cluster/stripe: Fix the possible resource leaks.
Change-Id: Ic6fbc8c843f80edd7458d15229eb72a5609973a5
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6986
Reviewed-by: Amar Tumballi <amarts@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4a5a6a428f538e48c3bd97c049cc8d46ca643d3c
Author: Christopher R. Hertel <crh@redhat.com>
Date: Fri Feb 7 16:46:23 2014 -0600
xlators/rot-13: Free memory when returning on error.
Added GF_FREE() calls to free allocated memory that was left
behind otherwise.
BUG: 789278
CID: 1124725
Change-Id: I5aa086d6b13a93e14de50e47e02b0e9813af9572
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-on: http://review.gluster.org/6940
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f65f3dcaeb20380c5a03583be2223679206f2587
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Mon Feb 10 20:52:57 2014 +0530
glusterd: Fix possible leaks on failure code path
Fix the memory leaks in socket and glusterd in failure code
paths reported by Coverity.
CIDs: 1124777, 1124781, 124782
Change-Id: I63472c6b5900f308f19e64fc93bf7ed2f7b06ade
BUG: 789278
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6954
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a46fde9a78d003880fe47176d2da2e74437c40b5
Author: Kotresh H R <khiremat@redhat.com>
Date: Wed Dec 4 14:14:20 2013 +0000
geo-rep: Fix gsyncd restart issue.
New function 'glusterd_gsync_op_already_set' is written which compares
the geo-rep configuration value in gsync.conf with the one sent from
cli. The generic function is written to compare op_value for any
op_name sent from cli as this issue can happen with any configuration
setting other than use-tarssh also. This routine is used to avoid
restart of gsyncd if the configuration value is set to same as in
gsyncd.conf.
Also added error checking when glusterd_gsync_configure fails.
Earlier, eventhough 'glusterd_gsync_configure' fails, error
was not getting catched and success message was shown.
Change-Id: If4dcd0ffc09e6e67c79ba86238f03eff1b7c7645
BUG: 1060797
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/6897
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d1bc94451a7abf18b0dd687c1ea990defb725c71
Author: Poornima <pgurusid@redhat.com>
Date: Sun Jan 26 22:08:46 2014 +0000
performance/io-cache: Fix dereferencing of freed pointer
Change-Id: Ic4276c6d76c36f4eb77282dc06d2b8b212b58f08
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6822
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6895ef5e07246535a803d8565123b16420dde292
Author: Poornima <pgurusid@redhat.com>
Date: Sun Feb 9 22:57:56 2014 +0000
cluster/stripe: Fix the resource leaks.
Change-Id: Ieb1fe112686f4932a6272a0117c1373e736d5b4e
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6951
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6cb279375de03553c8eba5008d36342bb957cfd3
Author: Luis Pabon <lpabon@redhat.com>
Date: Sun Feb 9 21:57:45 2014 -0500
build: CFLAGS was being polluted by python flags
The CFLAGS were being polluted by the python test for glupy. The
test also sets CFLAGS -NDEBUG even when passing --enable-debug to
configure.
To fix it, the patch now saves the necessary python flags into
new makefile flags which can now be used by the glupy Makefile.am.
BUG: 1063541
Change-Id: I8546a64b8ad4fe9318a97fb6a2f0c36087be1b29
Signed-off-by: Luis Pabon <lpabon@redhat.com>
Reviewed-on: http://review.gluster.org/6957
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 073708d79df685554adcedc57faf257ee49ea677
Author: Poornima <pgurusid@redhat.com>
Date: Fri Jan 17 02:45:56 2014 +0000
gfapi: Set log level to GF_LOG_NONE after closing log file in glfs_fini
Currently any logs that are logged after calling glfs_fini will
appear on stderr. Ideally to the end of the glfs_fini all the
operations will be complete and there should be no further logging.
But it appears that the client translator is still up and prints
some log messages even after calling glfs_fini.
In this patch the log level is set to GF_LOG_NONE once the log file
is closed. This fix is not required if wait for "CHILD_DOWN" event
is implemented in glfs_fini.
Change-Id: Idde80e9a89f3a5264d02b7e6fc2a84d67550b20a
BUG: 1054696
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6726
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f4f30924815959a9f4acb198318c9391cf067d5d
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Feb 11 13:16:38 2014 +0530
mount.glusterfs: backward compatible option for root-squashing
Change-Id: I74fa6686cff84cfad4a2587a0061e6bb2beea081
BUG: 954057
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/6975
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 29f69ca2433b444f0a826302f63d85030d71ed54
Author: Ravishankar N <ranaraya@redhat.com>
Date: Wed Jan 29 12:09:42 2014 +0000
storage/posix: perform chmod after chown.
Problem:
When a replica brick is added to a volume, set-user-ID and set-group-ID
permission bits of files are not set correctly in the new brick. The issue
is in the posix_setattr() call where we do a chmod followed by a chown.
But according to the man pages for chown:
When the owner or group of an executable file are changed by an unprivileged
user the S_ISUID and S_ISGID mode bits are cleared. POSIX does not specify
whether this also should happen when root does the chown().
Fix:
Swap the chmod and chown calls in posix_setattr()
Change-Id: I094e47a995c210d2fdbc23ae7a5718286e7a9cf8
BUG: 1058797
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/6862
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f2433045606bb1c9c16b4021914128fc51ef7b09
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Wed Jan 29 17:09:55 2014 +0530
gNFS: Coverity fix for possible memory leak
In nfs_gfid_dict(), if dict_new() fails, the control goes to
out: block and dyngfid resource (dynamically allocated by
GF_CALLOC()) is leaked.
Add a validation for memory returned by GF_CALLOC()
Drop unnecessary "goto" statements
Coverity CID: 1124764
Change-Id: Idda7923cc1c32260b3353f7a9141aa1cf43e4fe1
BUG: 789278
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6852
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3e131704267df6ee82cfe8f8f25616bb6dab6007
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue Feb 4 17:13:34 2014 +0530
dht: Modified dht-statedump to print all subvolume_status
Change-Id: I1aae33472bd15fc2bd7a170544f2994534fdf246
BUG: 1058204
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/6800
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 468304d086e88a9e5cd18c897e65505d84ef25ad
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Feb 3 10:58:47 2014 -0500
libglusterfs/client_t.c: rhel5/i386 atomic, link failure
RHEL5's gcc-4.1.2 on i386 does not have built-in atomic __sync_*()
Change-Id: If7b1027570a6c8c962392871b002be0a37258ed3
BUG: 1060703
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/6894
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bb9edc8064ae183a15f9009e026eba2d5a828d27
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Apr 19 12:27:03 2013 +0530
protocol/server: do not do root-squashing for trusted clients
* As of now clients mounting within the storage pool using that machine's
ip/hostname are trusted clients (i.e clients local to the glusterd).
* Be careful when the request itself comes in as nfsnobody (ex: posix tests).
So move the squashing part to protocol/server when it creates a new frame
for the request, instead of auth part of rpc layer.
* For nfs servers do root-squashing without checking if it is trusted client,
as all the nfs servers would be running within the storage pool, hence will
be trusted clients for the bricks.
* Provide one more option for mounting which actually says root-squash
should/should not happen. This value is given priority only for the trusted
clients. For non trusted clients, the volume option takes the priority. But
for trusted clients if root-squash should not happen, then they have to be
mounted with root-squash=no option. (This is done because by default
blocking root-squashing for the trusted clients will cause problems for smb
and UFO clients for which the requests have to be squashed if the option is
enabled).
* For geo-replication and defrag clients do not do root-squashing.
* Introduce a new option in open-behind for doing read after successful open.
Change-Id: I8a8359840313dffc34824f3ea80a9c48375067f0
BUG: 954057
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4863
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit beba43d70049be207a43a0fe7977f58f85cc002b
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Feb 6 13:03:58 2014 +0530
glusterd: Volume locks and transaction specific opinfos
With this patch we are replacing the existing cluster-wide
lock taken on glusterds across the cluster, with volume locks
which are also taken on glusterds across the cluster, but are
volume specific. So with the volume locks we are able to perform
more than one gluster operation at the same time, as long as the
operations are being performed on different volumes.
We maintain a global list of volume-locks (using a dict for a list)
where the key is the volume name, and which saves the uuid of the
originator glusterd. These locks are held and released per volume
transaction.
In order to acheive multiple gluster operations occuring at the
same time, we also separate opinfos in the op-state-machine, as a
part of this patch. To do so, we generate a unique transaction-id
(uuid) per gluster transaction. An opinfo is then associated with
this transaction id, which is used throughout the transaction. We
maintain a run-time global list(using a dict) of transaction-ids,
and their respective opinfos to achieve this.
Upstream Feature Page: http://www.gluster.org/community/documentation/index.php/Features/glusterd-volume-locks
Change-Id: Iaad505a854bac8de8f83beec0357eb6cde3f7ea8
BUG: 1011470
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5994
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b669bf53cf7e52e88714d50d55bfd79c5c4c5b94
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Jan 20 12:23:35 2014 +0530
geo-rep: Config file upgrade
When old config file is used with new geo-rep, config item like
'georep_session_working_dir' was missing in old config file.
With this patch geo-rep sets the default value for new items.
Following config options supported:
- georep_session_working_dir
- gluster_params
- ssh_command_tar
BUG: 1036539
Change-Id: I389c62e749f3b567f9ecf96d4b41367ef962c025
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/6934
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 18aafb64f4cd1fa3a424e407148cd2cba6ead203
Author: Poornima <pgurusid@redhat.com>
Date: Thu Jan 30 05:36:42 2014 +0000
performance/io-cache: Fix for the bugs reported by coverity
Change-Id: I24c10d874511a2f24dda2fb84d31f5074da1616f
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6869
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 08160b5a6ce1cd596e7c59418c6c0a1a94163ff5
Author: Poornima <pgurusid@redhat.com>
Date: Tue Feb 4 23:11:59 2014 +0000
features/quota: Fix NULL dereference error reported by coverity.
Change-Id: I48c1ebcb3261fa5da721e5b48d17c6c873df256d
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6907
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3688f5167264526828db2099cf34146642f0c0ec
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Feb 6 17:16:20 2014 +0530
spec: geo-rep: Include hooks and upgrade scripts
Added hook script S56glusterd-geo-rep-create-post.sh to
%{_sharedstatedir}/glusterd/hooks/1/gsync-create/post/ and upgrade
scripts added to %{_datadir}/glusterfs/scripts/
BUG: 1036539
Change-Id: Id114b827824e55516181ab8f564d419c258be3e2
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/6926
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 97669f7f19894564ae883b83329e4e33480b22ef
Author: Christopher R. Hertel <crh@redhat.com>
Date: Thu Feb 6 12:39:24 2014 -0600
cluster/afr: goto statements may cause exit before memory is freed.
Memory is allocated for pump_priv and for pump_priv->resume_path, but if
an error is detected the references to that memory go out of scope and
the memory is never freed.
This patch assures that the memory is freed on error.
Patchset 2: These are Kaleb's recommended changes which, compared to my
original fix, are more comprehensive and provide a more
complete resolution to the memory leakage bugs in this
function. The bug reported by Coverity was limited to a
single memory allocation.
BUG: 789278
CID: 1124737
Change-Id: Ie239e3b5d28d97308bf948efec6a92f107bc648b
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-on: http://review.gluster.org/6929
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 961073ba33af75bbd38ab383c897b6f347cbb371
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Feb 9 18:51:02 2014 +0530
tests: Set hard and soft timeouts to 0 to ensure enforcement.
Change-Id: Ib233d00ea73e4141a404a2abadf9f6f81896c14d
BUG: 1038598
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6942
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit 5fda188333645a82f2b44d1cacdb57873756ae34
Author: Anuradha <atalur@redhat.com>
Date: Thu Dec 5 19:02:10 2013 +0530
quota : changes in quota list command
Changes are made to quota list command such that it also
shows whether hard-limit and soft-limit are exceeded or not.
A test case to check the same is added.
Change-Id: Idb365acfc5d1f2d9f3373dd5f98573d5fe87b50f
BUG: 1038598
Signed-off-by: Anuradha <atalur@redhat.com>
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/6441
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ebe9f25821a553eaafee128f2f3b01b3a25989e4
Author: Vijaykumar M <vmallika@redhat.com>
Date: Fri Jan 3 12:11:19 2014 +0530
glusterd: add volinfo to the list data structure in an order
Currently volinfo is added at the end of the list while creating a volume.
On gluster restart, readdir will not provide the ordered list and the data
is populated in the same order as readdir.
Solution is to insert the volinfo to the list in an order
Change-Id: I1716ac6abbd7dd301a7125425fc413c6833f7a48
BUG: 1039912
Signed-off-by: Vijaykumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6472
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit e25ea62d25e38023f75cce08b69eee1b4ea9dca2
Author: Christopher R. Hertel <crh@redhat.com>
Date: Mon Jan 27 16:38:14 2014 -0600
performance/quick-read: Allocated memory not freed when not used.
If memory is successfully allocated in the call to qr_content_extract(),
but is not used, it is not being freed. This patch frees the allocated
memory if it is not passed to qr_content_refresh().
BUG: 789278
CID: 1124735
Change-Id: I1c1f03a3b92fa26321ec6ee8822e6fa41da79875
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-on: http://review.gluster.org/6827
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e7921e1b0c3bef5062e5f39f10f785727837af89
Author: Susant Palai <spalai@redhat.com>
Date: Wed Jan 29 10:47:20 2014 +0000
cluster/dht: If hashed_subvol is NULL, do not fail
Problem: With the current implementation we are allowing unlink
of a file if hashed subvol is down and cached subvol is up.
For the above op to work we should have the info of hashed_subvol.
But incase we do remount of the volume we will have a zeroed layout
for the disconnected subvol(start=0, stop=0, err=ENOTCONN) which will
result into hashed_subvol being NULL and failing unlink op.
Solution: Dont fail if hashed_subvol is NULL. Check cached subvol
and unlink in cached subvol. The linkto file in the hashed subvol
can be remove later.
Change-Id: Ic1982c15c8942a1adcb47ed0017d2d5ace5c9241
BUG: 983416
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/6851
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 08f5fa42c9eaa27c71459d116aa9043ec06dd223
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Jan 29 13:38:36 2014 +0000
tests: Increase Expect Within time so that valid patches pass
In some cases it is observed that fix-layout takes more
than 20 seconds to complete, causing test to fail.
Increasing it to a safe value of 30.
Change-Id: I4ac8769e3a1594240ecda96700944ab3702daacc
BUG: 1004744
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/6855
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1234efdb45c7741bfa687053a5e9716a2f8d3e55
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat May 18 11:52:09 2013 +0530
features/marker-quota: more stringent error handling in rename.
If an error occurs and op_errno is not set to non-zero value, we can
end up in loosing a frame resulting in a hung syscall. This patch
adds code setting op_errno appropriately in storage/posix and
makes marker to set err to a default non-zero value in case of
op_errno being zero.
Change-Id: Idc2c3e843b932709a69b32ba67deb284547168f2
BUG: 833586
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/5032
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 58de3e8d370243f3a2637b40b87d7f167ff8f92a
Author: Christopher R. Hertel <crh@redhat.com>
Date: Thu Feb 6 19:32:35 2014 -0600
libglusterfs..xlator.c: Close a library handle.
Simple fix to ensure that a library handle is closed if it is not
actually used.
BUG: 789278
CID: 1124783
Change-Id: Ia3e734c46e1ad8c97cb8cc7f1a5616606bfbc550
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-on: http://review.gluster.org/6933
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8072a5721fb383b6e22085c38509b69c6e38b1e9
Author: Jose A. Rivera <jarrpa@redhat.com>
Date: Thu Feb 6 14:19:43 2014 -0600
libgfapi: Don't ignore return value of glfs_loc_touchup()
BUG: 789278
CID: 1124353
Change-Id: I7d2958cbc98faf45d723f17868c515762c50c618
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-on: http://review.gluster.org/6931
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0dfa7072887cd05fc2bc90dc4017babc11863f17
Author: Poornima <pgurusid@redhat.com>
Date: Wed Feb 5 00:15:33 2014 +0000
cluster/afr: Fix memory leak.
Change-Id: I811d104684905a5a9a794cde8e925bd1a97f6546
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6906
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8aabaa2e4e2dd293c337d6a56127a666287177d0
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Feb 6 15:22:11 2014 +0530
features/quota: fix crash in error handling after building ancestry.
Change-Id: Ifbebf1aa496d49a6c4bb30258b83aaf9792828e5
BUG: 1059833
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6923
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e6b68048300fd9d92b59f21fadcae5ad0348d350
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Feb 4 18:26:57 2014 +0530
glusterd: Fix a memory leak.
errmsg may have malloc'ed memory, free it before leaving function.
Change-Id: I4ab3b9db7a48a5e256eb8a08b8ab49818ce6ca1b
BUG: 789278
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/6902
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4e3acb974f92d5a5f40cf0cf1145a586d2356afb
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 7 06:04:23 2014 +0000
gverify: Correcting variable names
Change-Id: I851a50e0ebb7554b821fb591375bb6ebd6240ade
BUG: 1036539
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/6939
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a8e352d8aa0b856adbb21a5794d7ea410cfc4200
Author: Christopher R. Hertel <crh@redhat.com>
Date: Fri Jan 31 12:13:30 2014 -0600
features/index: Close directories left open on error.
Two directory streams are opened, but not always closed if the function
exits with an error. This patch aims to ensure that the directories are
closed in call cases.
Some return values may be explicitly discarded. This is done to avoid
having a successful call to closedir() overwrite the value of ret.
Also, the errno value is preserved in case a calling function needs to
check errno.
BUG: 789278
CID: 1124710
CID: 1124711
Change-Id: I6bf3b5c9c6a1ec9a99cc9178243ea98572c2bac2
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-on: http://review.gluster.org/6883
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7fa1a39b1cc63f62452a6841c28e564619034a9a
Author: Poornima <pgurusid@redhat.com>
Date: Thu Jan 23 02:08:19 2014 +0000
quick-read: Remove unref of a freed iobuf.
Change-Id: Ie21414658db571c9a483730b6d5e8997f04255c1
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6823
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 091843eedecea1a053d8e0af1465c1588a59f82c
Author: Poornima <pgurusid@redhat.com>
Date: Tue Feb 4 05:55:02 2014 +0000
glusterd: Fix the NULL dereference errors reported by coverity.
Change-Id: I51c120dfe2db44a2b74f35e5cafb4f364ed6e66e
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6901
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 60100373cc910e3c6d2638f71ab325c832950b3f
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Mon Feb 3 15:12:22 2014 +0530
gNFS: Possible NULL pointer dereference
In NFS-ACL code (acl3.c) i.e. acl3svc_setacl(), contol can
go to "acl3err" block from setaclargs.mask validation or
acl3_validate_gluster_fh() and acl3_map_fh_to_volume() macros.
But at this point of time "cs" is yet to be init'd (the macro
acl3_handle_call_state_init() is not yet invoked) which can
cause a NULL ptr deref.
FIX:
Refactor the acl3 code.
Coverity ID (CID): 1124491
Change-Id: I3aca38770e03ce59d1705653b6d8349e6cc153b2
BUG: 789278
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6890
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0e75a252d2902e87c3f4638fb9765eaf7fac444b
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Feb 4 15:57:05 2014 +0530
changelog: When connection is unsuccessful, close socket too.
Bug fix for Coverity CID: 1124791
Change-Id: I0362d45123ebc250290f3a5231f7fb113fa41212
BUG: 789278
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/6900
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 55c562b21a5331a775d6ca01f314dbeb4c025184
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Jan 28 17:42:21 2014 -0800
geo-replication: gverify should use disk_size and available_size
"commit ef4bb42382a5c9c3ca0907136669a659c2a20311" was incomplete since
reduction in sizes doesn't really have any affect on the problem when
disks sizes are similar.
Actual fix is to verify disk_size and then verify available_size
Change-Id: Idb57f606df229c0bdaeda8852c74e84d29109ffc
BUG: 1020154
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6844
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 2f1b9277886eeac32865973215663471998d8e12
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jan 8 10:22:48 2014 +0530
gsyncd / geo-rep: invoke changelog process() on non-empty change list
Change-Id: Ida4890abdc90d683a4a83127a1573bbb3829ea23
BUG: 1036539
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/6793
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 48a3b0746996a46c3332de5600ca11a45b4af1f2
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Dec 12 17:03:09 2013 +0530
gsyncd / geo-rep: ignore DHTs sticky bit file during crawl
Change-Id: Ide927759c6a3d5301475eac9f6e785aa901d426e
BUG: 1036539
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/6792
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1a57d3a52ea554211921d87b59d99a127352f717
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Nov 18 19:13:27 2013 +0530
gsyncd / geo-rep: "patch" up missing stime
In cases (mostly upgrade) of unavailability of "stime" key and
availability of "xtime" (slave's xtime), introduce "stime" key
on the fly by setting it to the value to "xtime".
Change-Id: Iaa424662d838154c8abc2cf00830c7f9d6be45ac
BUG: 1036539
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/6791
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bbb227186050ff13797bb85c5f3e3f41dff99eb3
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Jan 20 19:38:44 2014 +0530
gsyncd / geo-rep: cleanup the "tar" process
A missing cleanup for the "tar" process (when tar+ssh
is used as the sync engine).
Change-Id: Ib9599b43e7ec606c70b7c5598793417142be3c0b
BUG: 1036539
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/6794
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0b17614c55f14f2fb3705c7e0a2e247f5b443dff
Author: Susant Palai <spalai@redhat.com>
Date: Mon Feb 3 08:50:07 2014 +0000
cli/cli-xml : skipped files should be treated as failures for remove-brick operation.
Fix: For remove-brick operation skipped count is included into
failure count.
clixml-output : skipped count would be zero always for remove-brick
status.
Change-Id: Ic0bb23b89e0cf5b884b6d1ae42bbf98deedc9173
BUG: 1060209
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/6889
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6281c4c756e022853621d79ff4d9d1e67efaa5ac
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Jan 30 19:50:06 2014 +0530
changelog: Restrict length of unix socket files to UNIX_PATH_MAX.
Bug fix for Coverity-CID 1124847.
Change-Id: I410ef8e06cbc491b1f72535298fae5e9bc77220d
BUG: 789278
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/6870
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e068a5defcaad6a1bad893f77928625a490fc187
Author: Christopher R. Hertel <crh@redhat.com>
Date: Fri Jan 31 15:11:37 2014 -0600
libglusterfs: Allow all valid file handle values to be closed.
Zero (0) is a valid file handle. The code, as written, interprets return
values of open(2) that are less than or equal to zero to indicate an
error. Only -1 indicates an error.
BUG: 789278
CID: 1124756
Change-Id: Ie77c25f1f557d5d5adcec464b49dc7df2e3dc7e5
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-on: http://review.gluster.org/6884
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ba89289ce71bbc01f9873d89224d5353b5d99f80
Author: Poornima <pgurusid@redhat.com>
Date: Thu Jan 30 02:23:13 2014 +0000
Fix for 'use after free' errors reported by coverity.
Change-Id: I941fc89b2d696c7f227330321ed4bba3ed1deac4
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6868
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dea2bdf248b6dc36f2fcb68ffa86e5af3a0d90d7
Author: Poornima <pgurusid@redhat.com>
Date: Fri Jan 31 01:12:32 2014 +0000
mgmt/glusterd: Fix double free.
Change-Id: I7a8b7772849715b019c86c6c768f33c1d9dcb27c
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6881
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1e47d8a467a7a60cd72b141f5bd3fa5cf969e0a1
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Mon Feb 3 17:49:51 2014 +0530
Problem : getfattr fails and mount point becomes inaccessible while fetching glusterfs.ancestry.path key value for a gfid from aux-gfid-mount based mount point.
Analysis : The caller of posix_make_ancestryfromgfid() function i.e.
posix_get_ancestry_non_directory() is sending an incorrect type value as
an argument leading to a crash in posix_make_ancestral_node() (head
dirent pointer is NULL and an attempt to dereference causes seg fault).
For a non directory operation this piece of code should not have been
executed but due to incorrect type value this happened.
Solution : In posix_make_ancestryfromgfid() call type is passed as
logical or of type and POSIX_ANCESTRY_PATH instead of logical or of
POSIX_ANCESTRY_PATH and POSX_ANCESTRY_DENTRY.
Change-Id: Iaf844bea91396c5e2ee295d5a082998fda66f0a9
BUG: 1060104
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/6892
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d960bc9811620cfbb6d1d51494252a16f0416373
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Feb 5 21:50:20 2014 +0530
tests/basic: Prevent mount-options.t from being run.
mount-options.t introduces a race leading to failures in
regression tests. Hence disabling the test unit till we
sort out the race.
Also removing the workaround introduced in mount.t.
Change-Id: I7d60413bbff8597f90153cca838e326247e96cd9
BUG: 1060654
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6911
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit be2ccdba6cb6a41771112bd248332b9afc5640f6
Author: Lukas Bezdicka <lukas.bezdicka@gooddata.com>
Date: Wed Jan 29 11:20:08 2014 +0100
libxlator: fix memleak in cluster_markerxtime_cbk and cluster_markeruuid_cbk
Change-Id: Ide3574bf9f661b077f707990d47821feda18b1a3
BUG: 841617
Reviewed-on: http://review.gluster.org/6850
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 70a896c75c507daf602a8540d98ca90b61a84bd5
Author: surabhi <sbhaloth@redhat.com>
Date: Mon Jan 27 14:09:10 2014 +0530
libglusterfs:Fixing Dereference NULL return value.
1.Checking of data for NULL.
Change-Id: If49513f7c3fd1dc443c05dc62ed07d3254059e6e
BUG: 789278
Signed-off-by: surabhi <sbhaloth@redhat.com>
Reviewed-on: http://review.gluster.org/6799
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6d61ae729b9f666680c5403a99384be73424f91a
Author: ShyamsundarR <srangana@redhat.com>
Date: Tue Jan 28 11:09:10 2014 +0530
cluster/dht: Set restrictive open flags for files under rebalance
Files that are being rebalanced are created in the new volume
and access path needs to open these files to write changing
data in parallel to both the old and new locations. While opening
the file in the new location, we need to restrict the open flags
to not use truncate or create and fail if exist flags, to prevent
open failures or inadvertently truncate the file under rebalance.
Change-Id: I12130e0377adc393f1925c45585200ad991fd0d5
BUG: 1058569
Signed-off-by: ShyamsundarR <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/6830
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 72d42d83e39f69d407d978fa088c5093b7ea0ee2
Author: Christopher R. Hertel <crh@redhat.com>
Date: Mon Jan 27 17:49:29 2014 -0600
features/index: Loop exit without freeing in-use memory.
If the while loop is exited via the goto, the call to closedir(3) is
skipped, leaving an open directory stream. This patch ensure that the
directory is closed if the loop is exited via the goto.
BUG: 789278
CID: 1124763
Change-Id: Iec5da4b8d32c0a93c10d035ff38d0c063fd97cda
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-on: http://review.gluster.org/6828
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f4685d46162718d04a4f9b8d0de901dad5d1005e
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Sat Feb 1 22:49:22 2014 +0530
glusterd: Reset opinfo.op ONLY if lock succeeded
Change-Id: I0244a7f61a826b32f4c2dfe51e246f2593a38211
BUG: 1060434
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/6885
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 2d81ec1eaf5827c2d42fb5f38b6d88e2a3767233
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jan 29 16:57:12 2014 +0530
glusterd: Bump MAX_OP_VERSION to 4
Change-Id: Ib017a7d8ad8017bdcf15035018f4d04ecb5560e9
BUG: 1059206
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6853
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 747971f3518e8e9b67b83bde2592edbfc567fac3
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Tue Jan 21 02:27:03 2014 +0530
quota: Fixing a possibility of GF_FREE on an array pointer
Issue: when the charecter pointer is not heap allocated by the program
we should not do GF_FREE on it.
Change-Id: Ibccc25491a9ab924fd5b82c14566f551a061ec2e
BUG: 789278
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6741
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit dde4f906847af8d265fd615b426b7631409ce6fd
Author: Poornima G <pgurusid@redhat.com>
Date: Tue Jan 21 23:50:23 2014 +0000
cluster/dht: Fix layout sorting
The layout was not being sorted in the ascending order leading
to the wrong detection of holes/overlaps.
From looking at the previous git commits it appears that the initial version itself had the err comparison code.
Deductions from the current dht_layout_sort():
1. The zero'ed out layouts should be in the from of list, if needed
2. The layout should be sorted in the ascending order of layout error value.
3. The layout should be sorted in the ascending order of the layout 'start'.
But In some cases, with the err comparison code its not sorted in the ascending order. Example: If the input is as below for dht_layout_sort(), the sorting doesn't happen in ascending order.
Input:
0-1 err:0 2-3 err:0 6-7 err:0 0-0 err:20 4-5 err:0
With the current sort, Output:
4-5 err:0 0-0 err:0 0-1 err:0 2-3 err:0 6-7 err:0
Expected: 0-0 err:20 0-1 err:0 2-3 err:0 4-5 err:0 6-7 err:0
Looking at dht_layout_anomalies() it appears that, it doesn't require the layout to be sorted based on error value.
The other solution was to replace line 468 with:
if ((layout->list[i].err || layout->list[j].err) && (layout->list[i].start > layout->list[j].start))
Since dht_layout_anomalies() didn't expect the layout to be sorted based on the error, removed the err comparison.
Change-Id: I1215f6cd53efc7dba01c0958ba6cc7609dab6ff5
BUG: 1056406
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6757
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 66136ba16527f451e894a76851342b28da9d6e52
Author: Christopher R. Hertel <crh@redhat.com>
Date: Mon Jan 27 14:52:37 2014 -0600
cluster/dht: Abandoned memory if a call fails
If the call to dict_set_dynstr() fails, the memory indicated by
xattr_buf will not have been stored in the dictionary, so it must be
freed.
Patch set 2: Added a missed call to GF_FREE(). Fixed a formatting
consistency issue.
Patch set 3: Cleaned a minor style nit.
BUG: 789278
CID: 1124786
Change-Id: Id1f85bd2cbfac0b8727a3f6901f0a50ba921817d
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-on: http://review.gluster.org/6826
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 52ebbce6c581d63b27bf70db3e0fdbb1f6f1f88a
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Jan 22 14:08:45 2014 -0800
mount.glusterfs/glusterfsd: Add dummy deprecated *fetch-attempts options
volfile-max-fetch-attempts and fetch-attempts were not deprecated
properly at 'b610f1be7cd71b8f3e51c224c8b6fe0e7366c8cf'.
Provide a way for backward compatibility for broken third party apps.
Change-Id: I597b50df08823e74691c5a20a4da4d13aab4b7ff
BUG: 1045309
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/6544
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6e79f86837dc96b6422fd9f9c3b6ea920c5f0259
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jan 24 17:27:38 2014 +0530
glusterd: Fix race in pid file update
This patch only removes lines of code. For personal gratification, giving a
detailed explanation of what the problem was.
When glusterd spawns the local brick process, say when a reboot of the node
occurs,the glusterd_brick_start() and subsequently the
glusterd_volume_start_glusterfs() function gets called twice; from
glusterd_spawn_daemons() and glusterd_do_volume_quorum_action() respectively.
This causes a race, best described by a pseudo-code of current behaviour.
glusterd_volume_start_glusterfs()
{
if(!brick process running) {
step-a) reap pid file( i.e. unlink it)
step-b) fork a brick process which creates and locks pid file and
binds the process to a socket.
}
}
Time Event
---- -----
T1 Call-1 arrives, completes step-a, starts step-b
T2 Call-2 arrives, enters step-a as Call-1's forked child is not
yet running.
T3 Call-1's forked child is alive, creates pidfile and locks it,binds
its address to a socket.
T4 Call-2 performs step-a; i.e.unlinks the pid file created by Call-1 !!
(files can still be stil be unlinked despite a lockf on it)
T5 Call-2 does step-b, and the forked child process creates a *new* pid file
with it's pid and locks this file.
T6 But Call-2's brick process is not able to bind to socket as it
is already in use (courtesy T3) and hence exits (so no locks anymore on the pidfile).
Result:
- Pid file now contains PID of an extinct brick process.
- `gluster volume status` shows this PID value. It also notices that there is no
lock held on pid file by the currently running brick process (created by Call-1)
and hence shows N/A for the online status.
Also, as a result of events at T4, "ls -l /proc/<brick process PID>/fd/pidfile"
shows up as deleted.
Fix:
1.Do not unlink pid file. i.e. avoid step-a. Now at T5,Call-2's brick process
cannot obtain lock on pid file (Call-1's process still holds it) and exits.
2. Unrelated, but remove lock-unlock sequence in glusterfs_pidfile_setup()
which does not seem to be doing anything useful.
Change-Id: I18d3e577bb56f68d85d3e0d0bfd268e50ed4f038
BUG: 1035586
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/6786
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d83669d49f3d3eeeabef72ba7029488337a40b11
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Jan 30 22:27:24 2014 +0530
tests: Fix regression failures
Change-Id: I83dc651a5ce87adf51d1f539400cd91c801fc460
BUG: 1045309
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6874
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit c899dd768bb0e9643a669843acc463fe2887a250
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Jan 25 02:39:11 2014 -0800
build: GFAPI_VERSION should be 6.0.0 not 0.0.6
------------------------------------->
"In essence, every time you make a change to the library and
release it, the C:R:A should change. A new library should
start with 0:0:0. Each time you change the public interface
(i.e., your installed header files), you should increment the
CURRENT number."
So the version which was 3 became 5 when discard API was added
and became 6 when zerofill was added. As per the above description,
API addition will result in a change to the installed header (glfs.h)
and hence warrants a change in CURRENT number ? Should you have
changed the version to 6.0.0 instead of 0.0.6 ?
<------------------------------------
Thanks Bharata B Rao <bharata.rao@gmail.com> for pointing this out
Change-Id: I0aa980a6713fbd28922a94c5debb170a89aa3512
BUG: 862082
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6790
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Bharata B Rao <bharata.rao@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 774cb2c99ed947a82bad0a34ae0edc3fc61de621
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Mon Jan 20 19:24:31 2014 +0530
geo-rep: Fixing a memory leak issue reported by Coverity
Issue: "errmsg" is allocated memory through GF_CALLOC in function "gf_strdup"
Fix: using GF_FREE to free the memory
Change-Id: Iee8f8d806ea995591feee8e4ed0a0798ad07a8c4
BUG: 789278
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6740
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit c2d7dc98f0bbd9d23d79389b216cb81968c435e8
Author: Vijaykumar M <vmallika@redhat.com>
Date: Fri Dec 13 14:18:16 2013 +0530
dht: do not remove linkfile if file exist in cached sub volume
Currently with rmdir, if a directory contains only the linkfiles
we remove all the linkfiles and this is causing the problem when the cached
sub volume is down and end-up with duplicate files showing on the mount point.
Solution: Before removing a linkfile check if the
files exists in cached subvolume.
Change-Id: Iedffd0d9298ec8bb95d5ce27c341c9ade81f0d3c
BUG: 1042725
Signed-off-by: Vijaykumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6500
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ec45f56cd20605451df1ac34f962a4a9129a38ed
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 28 15:16:59 2014 +0530
cluster/afr: Add gfid to index in wind un-conditionally
Problem:
If brick crashes just after performing xattrop before
reaching index _cbk then the gfid will not be added to/deleted from
index. If it is not deleted it will be deleted when self-heal is
triggered. But if the crash happens before the file is added to index,
user may think the system does not need self-heal even when there is
this file that needs to be healed.
Fix:
Add file to index un-conditionally in wind phase. This way the
file remains in index even when brick process crashes before reaching
_cbk. This does not affect performance because of caching(check
_index_action) built into index xlator.
Change-Id: Ie83ac6aa1ac0ff66862e757864865b47ab39404d
BUG: 1058713
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6836
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 93a7381510d4dd352d4cc73aee9cd8a51a7f4dc2
Author: Poornima <pgurusid@redhat.com>
Date: Thu Jan 23 22:55:45 2014 +0000
features/qemu-block: Remove unref of freed iobuf
Change-Id: I507a6504b379eef54be77b54d6e2beee63975ebf
BUG: 789278
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6824
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2f9737b99351adcc2bc449d9df3d2591861c6c44
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Dec 20 15:43:08 2013 +0530
tests: Add sanity check for mount-options
Change-Id: Ica246f99b8cdb6c0cf0e9143f50be056e37d3b7f
BUG: 1045309
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6550
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e082b16d983ce783bbbb1f6ff685075e949c01c7
Author: Varun Shastry <vshastry@redhat.com>
Date: Wed Oct 23 16:10:31 2013 +0530
features/quota: Correct the statfs calculation when set limit is beyond ...
actual disk space.
Fixed one of the cases where 'df' values data show wrong when the quota limit
is greater than back-end disk space.
Change-Id: I09fb71a37602c6f3daf6b91dd3fd19b7f5f76817
BUG: 969461
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/6126
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8b752308ceff55d9908ba18bd4463b94a109b32f
Author: Ajeet Jha <ajha@redhat.com>
Date: Fri Jan 24 15:48:32 2014 +0530
mount/fuse: adding a setxattr filter pass for geo-rep create.
Adding filter pass for setxattr when key is "glusterfs.gfid.newfile".
This was blocking creates at slave volume.
Change-Id: I61455abd8688c52ac6894b5a04ba050076117ea3
BUG: 1054199
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/6797
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
commit 28e6c33de535e6874e5fac184676af492cc8b4f6
Author: Ajeet Jha <ajha@redhat.com>
Date: Thu Jan 16 17:25:49 2014 +0530
features/gfid-access: populating inode during virtual_lookup_cbk.
Setting appropriate ia_type and gfid for the inode, obtained during
virtual_lookup_cbk of a directory by doing an "inode_link".
Change-Id: I9582570c82e70ff5f1d4e441f9e9868ef82e9dc6
BUG: 1054199
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/6723
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9876e779de234d96deb2ed75ea541a00b31d340e
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Jan 24 15:16:39 2014 +0530
mgmt/glusterd: Set right op versions for few options.
compression and changelog translators appear first in 3.5. op-versions
of options corresponding to these translators should be 3.
Change-Id: Ib514207743e36eba53c3d5cf477c85136cf30b42
BUG: 923540
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6774
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d77564b54aee14a3c4f2e2f6aff45475ff409ad3
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Jan 15 11:47:26 2014 +0530
cluster/afr: Change default_value for option self-heal-daemon
Change-Id: Ic3c8e179a63e82a4e416aea620796f8bb3236c7c
BUG: 1052759
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6706
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4946f00b73fb18a33f15d6d11bc4f37e1a877b19
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Dec 27 17:54:50 2013 +0530
tests: Add rpc coverage tests.
1. Moves rpc-coverage.sh from extras/ to tests/basic/
2. Fixes a symlink test
Change-Id: I2fb8f8441434acfd7bd7fff72deedfbd2410d08c
BUG: 764966
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6609
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 5447ca273e39115c1e9ee3237b889c65c1d89d8c
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Jan 23 12:40:09 2014 +0530
features/gfid-access: fix lookup on .gfid/<parent>/bname
In gfid translator, lookup was not handling the case when
the lookup is sent on .gfid/<parent>/bname. In this case,
we flip with fake inode of the parent with the real inode
in loc and send it downwards.
Change-Id: I639ff1dce10ffc045da419e333d455e208b6a0f0
BUG: 1057881
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/6795
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5be141c242a6d5a359f7edb7520d253ce3661b9b
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Dec 23 14:54:05 2013 +0530
mgmt/glusterd: make sure quota enforcer has established connection with quotad before marking quota as enabled.
without this patch there is a window of time when quota is marked as
enabled in quota-enforcer, but connection to quotad wouldn't have been
established. Any checklimit done during this period can result in a
failed fop because of unavailability of quotad.
Change-Id: I0d509fabc434dd55ce9ec59157123524197fcc80
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
BUG: 969461
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6572
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 89352d765b48e504829e8118a5d3dbdfb639f3f9
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Sat Nov 9 13:44:18 2013 +0530
features/quota: maintain correct link_count in ancestry building codepath.
Ancestry building codepath can be executed simultaneously when a file
has hardlinks. So, following fixes are needed:
* modify local->link_count under locks in ancestry building codepath.
* before invoking check_limit on newly constructed parents,
link_count should not be set, but instead incremented by as many
number of new invocations of check_limit.
* decrementing link_count and the check whether the count has hit zero
to resume the waiting call_stub should be atomic.
Change-Id: I6f52e50547362a5ded6bd9f085570223aea372d1
BUG: 969461
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6491
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7d06b9e721b93654661d2c07e14a60a0e71237f5
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Dec 2 09:32:53 2013 +0530
features/quota: remove in-memory accounting of files in enforcer
Accounting was done in enforcer (though marker is the ultimate source
of truth) to offset cached directory size becoming stale. However,
with enforcer being moved to brick we can no longer maintain correct
cluster wide size for a directory. Hence removing accounting code from
enforcer.
Change-Id: I5ea94234da4da85ed5f5ced1354d8de3454b3fcb
BUG: 969461
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6434
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 01d4e2e4c601d8e65c1d3f75172f1cf3ce366b37
Author: Anand Avati <avati@redhat.com>
Date: Fri Jan 24 18:30:32 2014 -0800
tests: support regex in EXPECT constructs
Instead of just strings, provide the ability to specify a regex
of the pattern to expect
Change-Id: I6ada978197dceecc28490a2a40de73a04ab9abcd
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6788
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a5db98618d9cf18ea835c251fc8b8788b574082b
Author: Ira Cooper <ira@samba.org>
Date: Fri Jan 24 11:24:28 2014 -0500
glusterd: Free op_errstr before it goes out of scope.
Also removed the NULL check on path_list, as it shouldn't be needed.
Change-Id: I5b655f7b383f301afa8fc1c1c09b31e2afe47f0f
CID: 1138527
BUG: 789278
Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-on: http://review.gluster.org/6784
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9b7728e7a5c122025bd3e63f9db53e6f59ac0a4e
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Nov 4 16:21:14 2013 +0530
cluster/dht: set op_errno correctly during migration.
Change-Id: I65acedf92c1003975a584a2ac54527e9a2a1e52f
BUG: 1010241
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6219
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f525eae750cba1b1fa7e6647f9107f9782ab3687
Author: Ira Cooper <ira@samba.org>
Date: Fri Jan 24 09:25:58 2014 -0500
nfs/server: Logic error in mount tab handling.
This error likely causes a double free and also a memory leak.
Change-Id: I299209a8b5bf8aaf487e52e9a4f00948e1d40eb5
CID: 1124703
BUG: 789278
Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-on: http://review.gluster.org/6778
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f24c7ac757adf209e824bb746df6576e28bcd497
Author: Ira Cooper <ira@samba.org>
Date: Fri Jan 24 09:54:19 2014 -0500
glusterd: Free leaked error message.
The way the previous code was written you couldn't tell if the string was
from the data area, or allocated, so we switched how the error message
is printed, and now free unconditionally.
Change-Id: Ia83cf9893acdfb5d537a61cc0bbf4aa7689e483d
CID: 1124704
BUG: 789278
Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-on: http://review.gluster.org/6779
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7443e4b2bce0a6fad927cd4ba8f9c9896005918a
Author: Ira Cooper <ira@samba.org>
Date: Tue Jan 21 22:46:59 2014 -0500
mgmt: Fix memory leak of brickid from gf_asprintf.
No GF_FREE, so one was put into the return path with proper checking.
Change-Id: Idde2803608409dcbf216062f83b7f4493946ba70
CID: 1124718
BUG: 789278
Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-on: http://review.gluster.org/6755
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2d020d7c12100a18f0410f24c5fedcc0a2bdd598
Author: Jose A. Rivera <jarrpa@redhat.com>
Date: Fri Jan 24 10:00:02 2014 -0600
libgfapi: Remove useless call to lstat
There's no need to lstat cmd_args->volfile, since we already
check to see if fopen fails. The error message was largely the
same.
BUG: 789278
CID: 1124869
Change-Id: I10827154b32c72d2e4a1ab0d3c1e464f8af6ffee
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-on: http://review.gluster.org/6783
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 40ed506aba525e7374d0b2becb9716361dc9caf3
Author: Jose A. Rivera <jarrpa@redhat.com>
Date: Fri Jan 24 09:56:17 2014 -0600
libgfapi: Fix pointer dereference before NULL check
ctx is not checked for NULL before it is dereferenced, though the
check in "err" seems to suggest we should guard against it.
BUG: 789278
CID: 1124827
Change-Id: I6ed0b42992af5f370cce9aa2feb56811cdd54b42
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-on: http://review.gluster.org/6782
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2aac5f65e2d6be5afb28a43752b5bf2c99c7bd83
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Nov 27 11:48:29 2013 +0530
features/quota: use STACK_WIND_TAIL when quota is turned off.
Change-Id: I8a0b7f3a1995a72560c210efbad1eaafb0bdf329
BUG: 969461
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6373
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e783cf24b24790a046bec1f8896669fd0a2a33ee
Author: Dawit Alemu <dalemu@redhat.com>
Date: Mon Dec 30 22:59:39 2013 -0500
cli: Add options to the CLI that let the user control the reset of stats
"volume profile info" automatically clears incremental stats. There
isn't a command to:
- fetch stats without clearing incremental stats and
- clear cumulative and incremental stats
This change introduces two arguments (i.e. peek and clear). 'clear'
will wipe both incremental and cumulative stats. 'peek' fetches stats
without wiping incremental stats.
'volume profile info peek' - fetches incremental and cumulative stats
without wiping incremental stats
'volume profile info incremental peek' - fetches incremental stats
without wiping incremental stats
'volume profile info clear' - clears both incremental and cumultiave
stats
Change-Id: I91834515ad672eca5f882809941147d7d997c4c9
BUG: 1047416
Signed-off-by: Dawit Alemu <dalemu@redhat.com>
Reviewed-on: http://review.gluster.org/6620
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 71e0321e32fc977810b2c52589d89420332cde92
Author: Jose A. Rivera <jarrpa@redhat.com>
Date: Wed Jan 22 21:51:42 2014 -0600
libgfapi: Fix pointer dereference before NULL check
Call to dict_keys_join dereferences xattr before it is checked
for NULL. Restructured the function to check for NULL earlier and
call dict_unref only when needed.
BUG: 789278
CID: 1124826
Change-Id: I732fa304ad6f3b921c589832d13f73bbd36f589c
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-on: http://review.gluster.org/6763
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 028c4738242ebbc47c0f5726405353c0f735917b
Author: Christopher R. Hertel <crh@redhat.com>
Date: Thu Jan 23 15:37:09 2014 -0600
cluster/dht: goto statements may cause loop exit before memory is freed.
Memory is allocated at the top of the while loop via a call to
gf_strdup(), but there are several goto calls that exit the loop, and
the memory is not freed before each of those calls to goto. This fix
moves the final call to GF_FREE() higher in the loop so that the memory
is correctly freed.
Two variables, dup_str and str_tmp1, point to portions of the allocated
memory. Neither are used past the final call to GF_FREE( dup_str ).
BUG: 789278
CID: 1124780
Change-Id: Id24b80cdbfd8b8855c80fffec63d7fce98cbed4a
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-on: http://review.gluster.org/6771
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1122a9c233f2e8adba4975133d8e63308b7116f7
Author: Christopher R. Hertel <crh@redhat.com>
Date: Thu Jan 23 13:43:14 2014 -0600
cluster/stripe: Remove redundant code blocks
This appears to have been a cut&paste error. The same set of 12 lines
was repeated three times, causing a pointer to allocated memory to be
overwritten twice resulting in a memory leak.
This patch removes the redundant code.
BUG: 789278
CID: 1128915
Change-Id: I3e4a3703b389c00e2a4e99e0a7368c5a3dda74d0
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-on: http://review.gluster.org/6769
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9ddf2719d77ad1477e53468a96ada4056552ee80
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 23 12:12:07 2014 +0100
features/compress: rename "compress" option to "network.compression"
Prevent mistaking the "compress" options for storage (at rest)
compression. The cdc-xlator is implemented to support compressing of
network traffic (READ and WRITE FOPs).
URL: http://www.gluster.org/community/documentation/index.php/Features/On-Wire_Compression_+_Decompression
Change-Id: I9fedf4106dcb226d135ab92e4b533aff284881d7
BUG: 1053670
CC: Venky Shankar <vshankar@redhat.com>
CC: Prashanth Pai <ppai@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/6765
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 149542d4f3e0479ce9b00e73ff145093fe0f25f8
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jan 23 18:18:02 2014 +0100
protocol: pass the size of the data in the WRITE on-wire FOP
Capturing GlusterFS traffic with tcpdump and displaying it in Wireshark
shows that the size of all WRITEs are 0 bytes. It seems that the
attribute is not used, and the size is calculated an other way.
Even if the size attribute is not used (yet), it should be set correctly
to prevent confusing while debugging network traffic with Wireshark or
other tools.
Note that the on-wire format is not being changed with this patch. The
size is already part of the structure that is exchanged between the
client and server.
Change-Id: I9d67fe17bf203672116dea4948328e2af4004677
BUG: 1057264
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/6766
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vikhyat Umrao <vumrao@redhat.com>
commit 7f94a53815d3212e5d068ecfc3fcc807e6d77c20
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Dec 16 23:55:47 2013 +0530
gfid-access: fix the issue of entry creation with wrong gfid
* dict_set was happening with a string instead of 'uuid_t' causing
entry creations to happen with wrong gfid
* revalidate was causing excessive ESTALE logs as lookup was
happening on '.gfid/' path itself causing server to become clueless
Change-Id: I3b76ce7fdec9c2ff785be21f506f859f489f80f0
BUG: 1054199
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/6520
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 683709b35a84ab27673096c33895d57d9d004ab6
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Nov 7 12:52:23 2013 +0530
geo-rep: get new config value after config value reset
When config.read is called it preserves the previous values
from the the previously opened config file.
For example
import ConfigParser
config = ConfigParser.RawConfigParser()
config.read("defaults.conf")
config.read("preferences.conf")
When change in config file is identified it will open new
instance of config to avoid getting old config values.
Change-Id: Iec677e61ebd2c59c95aea94481f569d78bd913e4
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/6747
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3b58dd058d90b69bb84c45c2cd12d0448d30b2f0
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Jan 17 16:45:55 2014 +0530
geo-rep: Fix no error when slave size less than master size
in df command output, default block-size is 1K, but BUFFER_SIZE is
in bytes, so verify will succeed even if slave size is less than
master size.
Added -B1 to df command(that is --block-size=1) to get all values in
bytes.
BUG: 1056518
Change-Id: I2384d2a6f2505d967e0538b95fbf111c15b26f30
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/6746
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3affe9d094bb909268d88d8bb48b2fcb3eb50901
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Dec 2 15:49:58 2013 +0530
cluster/dht: Set quota limit key in dht_selfheal of dirs.
Also fixed check in dht_is_subvol_in_layout to check if the
layouts are zero'ed out.
Change-Id: I4bf8ebf66d3ef1946309b6c9aac9e79bf8a6d495
BUG: 969461
Signed-off-by: shishir gowda <sgowda@redhat.com>
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/6392
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2d58d77354ed962bd874ddfcaed4cc55e9316c44
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Jan 21 22:03:41 2014 -0800
storage/posix: HANDLE_PFX is redundant use GF_HIDDEN_PATH instead
GF_HIDDEN_PATH usage would help in better readability of the code
and avoids bugs produced from redundant macro constants.
Change-Id: I2fd7e92e87783ba462ae438ced2cf4f720a25f5c
BUG: 990028
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6756
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cc5b324d08ae5131b0db9a98479d79be00316acc
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Dec 18 00:02:58 2013 +0530
geo-rep: optimizing update stime after directory synchronization
Since xsync crawl generates new changelog when number of entries
reaches 8K or when directory is reached. If a directory has number
of files less than 8K then respective changelog file will have less
entries. Since xsync generated changelog files processed one after
the other, so syncjobs are underutilized. hence low bandwidth
utilization.
With this patch, changelog will be generated for 8K entries only,
but stime will be accumulated. Multiple dirs stime will be
updated together since the generated changelog will have entries
accross the dirs.
Change-Id: Ib0b40962a070f855f47f887d0840e412fb7928e1
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/6744
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 8d1c9618797138b8f45dcacdc192a8edf80b3e65
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Jan 21 16:39:12 2014 +0100
Create /var/run/gluster at install time
BUG: 764655
Change-Id: I67c33984a797bc92c7035724695c5ef2bbdf5267
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6750
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0ef3e2bd732e780cb67dc505d5e7ba998e0c7ee6
Author: Susant Palai <spalai@redhat.com>
Date: Thu Dec 12 06:20:55 2013 +0000
quota: filter glusterfs quota xattrs
Change-Id: I86ebe02735ee88598640240aa888e02b48ecc06c
BUG: 1040423
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/6490
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit f960069fa828924e39ccae95a0b6179ec4eedbeb
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Jan 22 14:47:23 2014 +0100
Fix build with c99 compilers
BUG: 764655
Change-Id: If5dfdc9c7427bd3d39d8da8f79e33ae2da6a3137
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6034
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bb05cfc9778bc33f65338908be6a2f02fa2d81e0
Author: Anand Avati <avati@redhat.com>
Date: Sun Jan 19 19:44:06 2014 -0800
locks: set @lock->frame = NULL when lock is granted
This way disconnect cleanup code can differentiate which locks
are granted vs blocked.
Change-Id: I2a835c6865b6c804231d852953ea84eeccef35a3
BUG: 849630
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6730
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 56b69eeeea7a04c9e2ba2187e014cfbf9d5ed156
Author: surabhi <sbhaloth@redhat.com>
Date: Tue Jan 21 14:55:29 2014 +0530
core:Fixing NULL dereference issue.
1.Checking of frame before calling STACK_DESTROY (frame->root)
Signed-off-by: surabhi <sbhaloth@redhat.com>
Change-Id: I21d27a8b4e556c00cd123afe8512e010a1a1f80d
BUG: 789278
Signed-off-by: surabhi <sbhaloth@redhat.com>
Reviewed-on: http://review.gluster.org/6749
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 15221b0aa2570e8fbeb001d8363c52ced69fd2e8
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Jan 22 00:45:01 2014 +0530
rpc: use GF_FREE when a string is gf_strdup'd.
Change-Id: I522c30a600e712be9cc09393104e228e4d8e13f5
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6752
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e8704f5072f4c4aca48e75d57086060e5f2f2808
Author: Ira Cooper <ira@samba.org>
Date: Tue Jan 21 20:42:22 2014 -0500
glusterd: Fix memory leak of hostname.
The if causes a goto that allows the GF_FREE to be missed.
BUG: 789278
Change-Id: Ic2c20b7623ea880b8ab2d11ebe510a62633a036d
CID: 1124785
Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-on: http://review.gluster.org/6754
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 575426c587951b8668b24b79b1f3184e47804b51
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jan 15 14:22:44 2014 +0100
build: Install /var/lib/glusterd/groups/virt by default
/var/lib/glusterd/groups/virt is not installed by default, but that
should be the case. It is provided as extras/groups-virt.example.
"make install" should correctly install this file, and the rpm packages
should include it.
Change-Id: I5284306cfc2882e3147bd72f496ad29db906fcb2
BUG: 1053854
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/6717
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 69643df4f7d4d54a057bc6bba22386240a0045a9
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Oct 28 19:14:49 2013 +0530
quota: get directory size before enforcing quota on rename
Change-Id: If18cab5992ddc91457782786942971deb1b51ead
BUG: 1023974
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6155
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2c2e99c1409baf83d18008194feb8776fdf34546
Author: Susant Palai <spalai@redhat.com>
Date: Mon Jan 6 12:38:08 2014 +0000
quota: unmount quota aux mount for volume stop
Previously df -h used to display "Transport end point not connected"
for quota auxiliary mount after volume is stopped. This patch
unmounts the auxiliary mount when the volume is stopped in all peer
nodes for that volume.
Change-Id: I78abb44386cd8242a532f92c13df8bdb57c78e31
BUG: 1049323
Signed-off-by: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/6656
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 320c9f04a580798a7820f1376dec9c2c423a3c7e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Dec 11 09:33:53 2013 +0530
syncop: Change return value of syncop
Problem:
We found a day-1 bug when syncop_xxx() infra is used inside a synctask with
compilation optimization (CFLAGS -O2).
Detailed explanation of the Root cause:
We found the bug in 'gf_defrag_migrate_data' in rebalance operation:
Lets look at interesting parts of the function:
int
gf_defrag_migrate_data (xlator_t *this, gf_defrag_info_t *defrag, loc_t *loc,
dict_t *migrate_data)
{
.....
code section - [ Loop ]
while ((ret = syncop_readdirp (this, fd, 131072, offset, NULL,
&entries)) != 0) {
.....
code section - [ ERRNO-1 ] (errno of readdirp is stored in readdir_operrno by a
thread)
/* Need to keep track of ENOENT errno, that means, there is no
need to send more readdirp() */
readdir_operrno = errno;
.....
code section - [ SYNCOP-1 ] (syncop_getxattr is called by a thread)
ret = syncop_getxattr (this, &entry_loc, &dict,
GF_XATTR_LINKINFO_KEY);
code section - [ ERRNO-2] (checking for failures of syncop_getxattr(). This
may not always be executed in same thread which executed [SYNCOP-1])
if (ret < 0) {
if (errno != ENODATA) {
loglevel = GF_LOG_ERROR;
defrag->total_failures += 1;
.....
}
the function above could be executed by thread(t1) till [SYNCOP-1] and code
from [ERRNO-2] can be executed by a different thread(t2) because of the way
syncop-infra schedules the tasks.
when the code is compiled with -O2 optimization this is the assembly code that
is generated:
[ERRNO-1]
1165 readdir_operrno = errno; <<---- errno gets expanded
as *(__errno_location())
0x00007fd149d48b60 <+496>: callq 0x7fd149d410c0 <address@hidden>
0x00007fd149d48b72 <+514>: mov %rax,0x50(%rsp) <<------ Address
returned by __errno_location() is stored in a special location in stack for
later use.
0x00007fd149d48b77 <+519>: mov (%rax),%eax
0x00007fd149d48b79 <+521>: mov %eax,0x78(%rsp)
....
[ERRNO-2]
1281 if (errno != ENODATA) {
0x00007fd149d492ae <+2366>: mov 0x50(%rsp),%rax <<----- Because
it already stored the address returned by __errno_location(), it just
dereferences the address to get the errno value. BUT THIS CODE NEED NOT BE
EXECUTED BY SAME THREAD!!!
0x00007fd149d492b3 <+2371>: mov $0x9,%ebp
0x00007fd149d492b8 <+2376>: mov (%rax),%edi
0x00007fd149d492ba <+2378>: cmp $0x3d,%edi
The problem is that __errno_location() value of t1 and t2 are different. So
[ERRNO-2] ends up reading errno of t1 instead of errno of t2 even though t2 is
executing [ERRNO-2] code section.
When code is compiled without any optimization for [ERRNO-2]:
1281 if (errno != ENODATA) {
0x00007fd58e7a326f <+2237>: callq 0x7fd58e797300
<address@hidden><<--- As it is calling __errno_location() again it gets the
location from t2 so it works as intended.
0x00007fd58e7a3274 <+2242>: mov (%rax),%eax
0x00007fd58e7a3276 <+2244>: cmp $0x3d,%eax
0x00007fd58e7a3279 <+2247>: je 0x7fd58e7a32a1
<gf_defrag_migrate_data+2287>
Fix:
Make syncop_xxx() return (-errno) value as the return value in
case of errors and all the functions which make syncop_xxx() will need to use
(-ret) to figure out the reason for failure in case of syncop_xxx() failures.
Change-Id: I314d20dabe55d3e62ff66f3b4adb1cac2eaebb57
BUG: 1040356
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6475
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4508f5a73bcab53a30631f6585fdef264bc5bbc9
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Aug 17 13:01:23 2013 -0700
build: Start using library versioning for various libraries
According to libtool three individual numbers stand for
CURRENT:REVISION:AGE, or C:R:A for short. The libtool
script typically tacks these three numbers onto the end
of the name of the .so file it creates. The formula for
calculating the file numbers on Linux and Solaris is
/path/to/library/<library_name>.(C - A).(A).(R)
As you release new versions of your library, you will
update the library's C:R:A. Although the rules for changing
these version numbers can quickly become confusing, a few
simple tips should help keep you on track. The libtool
documentation goes into greater depth.
In essence, every time you make a change to the library and
release it, the C:R:A should change. A new library should start
with 0:0:0. Each time you change the public interface
(i.e., your installed header files), you should increment the
CURRENT number. This is called your interface number. The main
use of this interface number is to tag successive revisions
of your API.
The AGE number is how many consecutive versions of the API the
current implementation supports. Thus if the CURRENT library
API is the sixth published version of the interface and it is
also binary compatible with the fourth and fifth versions
(i.e., the last two), the C:R:A might be 6:0:2. When you break
binary compatibility, you need to set AGE to 0 and of course
increment CURRENT.
The REVISION marks a change in the source code of the library
that doesn't affect the interface-for example, a minor bug fix.
Anytime you increment CURRENT, you should set REVISION back to 0.
Change-Id: Id72e74c1642c804fea6f93ec109135c7c16f1810
BUG: 862082
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5645
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c048dc1e0feefc19e39c5389d63af572257c02da
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Tue Jan 14 23:50:51 2014 +0530
core: Coverity issue "Use of uninitialized scalar variable"
Issue:
1. In "unlink (export_path)" "export_path" might contain an arbitrary value left from earlier
computations.
2. In "(msg[0] != '\0')" msg might contain an arbitrary value
Change-Id: Icca8f557fd6b5e046dff1d5a84a72061975868d0
BUG: 789278
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6701
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4e7d87289fc4aa50b4205c1117a601d4db179c77
Author: Varun Shastry <vshastry@redhat.com>
Date: Fri Dec 27 15:39:19 2013 +0530
features/quota: Handle the corner case in statfs call
Problem: Even though limit is not set quota used to send 'quota-deem-statfs'
key in the dictionary resulting in incorrect calculations.
Change-Id: I643cb35cca6648e40f1c745135280876958ddaa9
BUG: 1046894
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/6607
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
commit fed3e501214495186622257e3c4c0f2a10729ce5
Author: Varun Shastry <vshastry@redhat.com>
Date: Fri Nov 29 14:49:33 2013 +0530
features/quota: Make grep search more accurately
The hook script was searching the info file for "features.quota" to know the
quota status (enable/disabled). When features.quota-deem-statfs the grep is not
accurate. Fixed this issue.
Change-Id: I4104a93c1c1e0ac9fd7ef7bfef993425ab50e651
BUG: 969461
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/6380
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 319ef51f6a39617d93de37ddabe6395dc7af4e9d
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Dec 17 16:04:46 2013 +0530
quota: fix recording of last alert log message
PROBLEM:
Alert log messages, corresponding to disk usage crossing soft-limit on a
directory, weren't being logged as often as expected.
CAUSE:
The mechanism in place to log alert messages, once every alert-time
seconds, set the previous logged time incorrectly.
FIX:
Update previous logged time only if we logged an alert message, ie. when
the "time was right" to alert.
Change-Id: Iafcb7be11e3240e2d04b0bb29ddb88e4f4a1bd25
BUG: 969461
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6532
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1b4b3b2f708160cef0296f41e07c07a25ed67da4
Author: Varun Shastry <vshastry@redhat.com>
Date: Tue Oct 22 16:12:58 2013 +0530
features/quota: Metadata cleanup
Quota and marker uses 'trusted.glusterfs.quota*' and 'trusted.pgfid*' xattrs to
store its configurations and accounting information and also to build the
parent inode chain in case of absense of path.
Problem:
After disabling and then enabling quota back, the xattrs may contain stale data
leading to impaired accounting and thus improper enforcement.
Solution:
Clean up all the quota related xattrs after quota disable.
Marker xlator implements a virtual xattr to cleanup quota and pgfid xattrs. In
this approach glusterd mounts an auxiliary mount and sends the below command to
all the files by crawling the mountpoint.
#setfattr -n "glusterfs.quota-xattr-cleanup" -v 1 <path/to/file>
Credit:
Krishnan Parthasarathi <kparthas@redhat.com>
Varun Shastry <vshastry@redhat.com>
Change-Id: I9380eca58a285dc27dd572de1767aac8f2cd8049
BUG: 969461
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/6369
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dc237854db12c54ea16ab82363b078236903af08
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Jan 9 17:03:37 2014 +0530
test: Remove unnecessary code from test.
We have not meddled with mount point to check for it again.
Change-Id: I88eed777b6573a320065b9e14c2031db964e36d0
BUG: 1053362
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/6675
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f7a5bb393190a4b57e89ca57ce663ecaf9b9ac79
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Tue Jan 14 12:35:54 2014 +0530
libgfapi: Fixing possible dereferencing of null pointer "glfd"
Fix: Putting a check so that pointer derefrence does not happen
when "gfld" is null
Change-Id: I281b10be445bbeec3a2728fc139d5ac94372e5b6
BUG: 789278
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6697
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 78bd282f38f8cbb969e42237f36751d2d3380cf8
Author: ndarshan <dnarayan@redhat.com>
Date: Fri Dec 27 03:11:19 2013 -0500
cli: Addition of new child elements under brick in volume info xml.
Added new child elements; name and hostUuid under brick in
volume info xml where name and host uuid of the bricks are stored.
This does not break backward compatibility as the old value under
brick is not removed.
Change-Id: Ib9e388889c8dc0c7cd34dcc1871a59003f982f36
Signed-off-by: ndarshan <dnarayan@redhat.com>
Reviewed-on: http://review.gluster.org/6604
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d6734c64ae7b2906985b7cded1a13a3a7387a9eb
Author: Vijaykumar M <vmallika@redhat.com>
Date: Mon Dec 30 18:06:56 2013 +0530
dht: Ignore directory with missing xattrs, which have err == 0, and start == stop
From the history (Patch: http://review.gluster.org/4668/)
When subvols-per-directory is < available subvols, then there are layouts
which are not populated. This leads to incorrect identification of holes or
overlaps. We need to ignore layouts, which have err == 0, and start == stop.
In the current scenario (start == stop == 0).
Additionally, in layout-merge, treat missing xattrs as err = 0. In case of
missing layouts, anomalies will reset them.
For any other valid subvoles, err != 0 in case of layouts being zeroed out.
Also reverted back dht_selfheal_dir_xattr, which does layout calculation only
on subvols which have errors.
Change-Id: Idb72a869f1a6f103046bb7e6fe0019f6ac853fd4
BUG: 1047331
Signed-off-by: Vijaykumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6618
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b1a2d8784200bb2b496e98c42fb7cacd878b08d0
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Tue Jan 14 11:21:44 2014 +0530
gNFS: Set default outstanding RPC limit to 16
With 64, NFS server hangs with large I/O load (~ 64 threads writing
to NFS server). The test results from Ben England (Performance expert)
suggest to set it as 16 instead of 64.
Change-Id: I418ff5ba0a3e9fdb14f395b8736438ee1bbd95f4
BUG: 1008301
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6696
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: ben england <bengland@redhat.com>
commit dedfa9f5e1fbb1bc626806e019c2dab5b5d9ec5d
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Tue Jan 14 23:24:50 2014 +0530
geo-rep: Fixing null pointer dereference of "op_value"
Change-Id: Id39743eaa5a52cc7fd4e2a1378a23384f5ef1fed
BUG: 789278
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6700
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
commit 0b5f805157b76273f920d6d3797ca828dd3dc683
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jan 13 12:42:31 2014 +0530
cli: Don't override cli mode when stdin in not a tty
Change-Id: I801c6e6ecd6c5a91e487e8e54ec5f684d450a080
BUG: 1047378
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6687
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 94b90eeb8c274af4902ecee0aa80f1ffc105ba81
Author: Kotresh H R <khiremat@redhat.com>
Date: Wed Jan 8 10:52:28 2014 +0530
glusterd/geo-rep : Allow volume to stop if geo-rep is not active.
In staging phase of volume stop, code is added to read the state_file
for each slave of the master to which the volume belongs. If any of the
geo-rep session is active with at least one slave, volume is not
allowed to stop else it is allowed.
Change-Id: I4a01a357fc86b872e9635b3d19998cdbd9545114
BUG: 1049727
Signed-off-by: Kotresh H R <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/6663
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 48591813bd3e66a17b589f9515329a4c5766a3db
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jan 2 20:11:19 2014 +0530
socket: propogate connect failure in socket_event_handler
This patch prevents spurious handling of pollin/pollout events on an
'un-connected' socket, when outgoing packets to its remote endpoint are
'dropped' using iptables(8) rules.
For eg,
iptables -I OUTPUT -p tcp --dport 24007 -j DROP
Change-Id: I1d3f3259dc536adca32330bfb7566e0b9a521e3c
BUG: 1048188
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6627
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 7e03709af8ea5f9c5c50c52e9faa67e0fb147edf
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Jan 3 11:59:43 2014 +0530
consolidate code for #ifdef HAVE_LINKAT usage
sys_link() now does
ifdef HAVE_LINKAT
linkat (...)
else
link (...)
endif
Use sys_link() in all places where we previously had the
conditional behavior.
Change-Id: I8bce5ac1175efd2ba7ab4bb5b372f6d1e0365d28
BUG: 764655
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6633
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 28bf846ec2f563a4414c9c7b76c04b19f8111b19
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Jan 12 22:39:14 2014 +0530
storage/posix: UNWIND right op_error and op_errno in *setxattr()
1. errno was being set after gf_log() in posix_{f}handle_pair, this
would cause errno to be overwritten.
2. dht would expect -1 for indication of failure in setxattr
callback (dht_err_cbk()). posix_{f}setxattr has been changed to set
op_ret as -1 instead of -op_errno.
3. dict_foreach() has been changed to return an error if the invoked
fn() returns < 0.
Bug report and test case credits to Zorro Lang <zlang@redhat.com>
Change-Id: I96c15f12a5d7717b7584ba392f390a0b4f704a98
BUG: 1051896
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6684
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7e10f4576cfb581138501075141e058d2a998b5d
Author: Anand Avati <avati@redhat.com>
Date: Tue Dec 3 16:30:45 2013 -0800
locks: various fixes
- implement ref/unref of entry locks (and fix bad pointer deref crashes)
- code cleanup and deleted various data types
- fix improper read/write lock conflict detection in entrylk
- fix indefinite hang of blocked locks on disconnect
- register locks in client_t synchronously, fix crashes in disconnect path
Change-Id: Id273690c9111b8052139d1847060d1fb5a711924
BUG: 849630
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6638
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9baf5b0fff4d48b44e03bb7df58e582cb14faf18
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri Jan 3 13:54:25 2014 +0530
cluster/afr: Unable to self heal symbolic links
Problem:
Under the entry self heal, readlink is done at the
source and sink. When readlink is done at the sink,
because link is not present at the sink, afr expects
ENOENT. AFR translator takes decisions for new link
creation based on ENOENT but server translator is modified
to return ESTALE because of which afr xlator is not able
to heal.
Fix:
The check for inode absence at server includes ESTALE as
well.
Change-Id: I319e4cb4156a243afee79365b7b7a5a7823e9a24
BUG: 1046624
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/6599
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f2b7aca2853e8c289cd77ea859e2091af295c8c2
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Fri Jan 10 11:57:05 2014 +0530
gNFS: Server sets ACL mask wrongly in GETACL reply
FIX:
1. Set the ACL mask what was requested by client
2. Validate the ACL mask in SETACL routine
Change-Id: Icb8576a8fe2684e0beaf94e8db6a92bc70bbfe7f
BUG: 1051865
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6683
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dbf370705e27d3e567f720b3eaf6334b76ca3758
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Dec 9 17:51:40 2013 +0530
mgmt/glusterd: Improve the description in volume set help output
Change-Id: I785648970f53033a69922c23110b5eea9e47feb3
BUG: 1046030
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/6573
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7aab46c7446022a61cd8842e600b107320874e41
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Sun Jan 5 01:01:39 2014 +0530
glusterd: Comments for missing break in switchcase of glusterd_op_stage_quota
Change-Id: I3ac5b73b9703a390f1de9cd6a999dfd8ec27d379
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6645
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 5cf9dc6ff1590ce70a499fdf43dcca17848c6398
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Dec 30 09:59:18 2013 +0530
glusterd: Relocate rebalance sockfile
The defrag sockfile was moved from priv->workdir to
DEFAULT_VAR_RUN_DIRECTORY. The format for the new path of the defrag
sockfile is 'DEFAULT_VAR_RUN_DIRECTORY/gluster-rebalance-<vol-id>.sock'.
This was needed because the earlier location didn't have a fixed length
and could exceed UNIX_PATH_MAX characters. This could lead to the
rebalance process failing to start as the socket file could not be
created.
Also, for keeping backward compatiblity, glusterd_rebalance_rpc_create
will try both the new and old sockfile locations when attempting
reconnection.
Change-Id: I6740ea665de84ebce1ef7199c412f426de54e3d0
BUG: 1049726
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6616
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1bd5d13e42c40bb36d6adf936db5179f36c66c9d
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Fri Jan 10 12:26:29 2014 +0530
MAINTAINERS: Update BD
BUG: 1040351
Change-Id: I2cbbae22e84fe7f8593db22a32ceb87ca97f46da
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/6679
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit b79dfedfb454cbe11734fba182150b05443595c7
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Mon Jan 6 13:37:24 2014 +0530
libgfapi : Fixing some NULL pointer dereferencing issues.
1. Fixing dereferencing null pointer "gio"
2. Checking "frame" before calling STACK_DESTROY (frame->root)
Change-Id: If2ce8804a8e9f3f99f71a8c0d13900afb5635072
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6313
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0a7ec49fae49d88c68d491a04ec6b606beb9a311
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Wed Jan 8 14:25:08 2014 +0530
geo-rep: Fixing an incorrect memcpy operation.
Currently we are copying a higher size variable to lower size
variable i.e. copying a NAME_MAX to PATH_MAX sized variable
in "memcpy (sts_val->worker_status, monitor_status, strlen(monitor_status));"
Change-Id: I81dca8e81a4aea5545d5982aed20e05a5e08641c
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6667
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4503c52aec9f7a38923790e22dad99ddbd458daa
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Dec 24 08:23:13 2013 -0800
rpc/auth: Avoid NULL dereference in rpcsvc_auth_request_init()
Code section is bogus!
------------------------------------------
370: if (!auth->authops->request_init)
371: ret = auth->authops->request_init (req, auth->authprivate);
------------------------------------------
Seems to have been never been used historically since
logically above code has never been true to actually execute
"authops->request_init() --> auth_glusterfs_{v2,}_request_init()"
On top of that under "rpcsvc_request_init()"
verf.flavour and verf.datalen are initialized from what is
provided through 'callmsg'.
------------------------------------------
req->verf.flavour = rpc_call_verf_flavour (callmsg);
req->verf.datalen = rpc_call_verf_len (callmsg);
/* AUTH */
rpcsvc_auth_request_init (req);
return req;
------------------------------------------
So the code in 'auth_glusterfs_{v2,}_request_init()'
performing this operation will over-write the original
flavour and datalen.
------------------------------------------
if (!req)
return -1;
memset (req->verf.authdata, 0, GF_MAX_AUTH_BYTES);
req->verf.datalen = 0;
req->verf.flavour = AUTH_NULL;
------------------------------------------
Refactoring the whole code into a more understandable version
and also avoiding a potential NULL dereference
Change-Id: I1a430fcb4d26de8de219bd0cb3c46c141649d47d
BUG: 1049735
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6591
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 55281b0b818125297f926b06a863565b06e4b38b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 7 15:54:14 2014 +0530
cluster/afr: Stop index crawl on pending full crawl
Full crawl is executed when index self-heal is useless, like
disk replacement. So if there are on-going index crawls, they
should be stopped inorder to start full self-heals.
Change-Id: I9a1545f1ec4ad9999dc08523ce859e4fa152e214
BUG: 1049355
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6659
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d6460fcb09e12199b153ceef965dcb933df1f3c7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 7 15:23:19 2014 +0530
cluster/afr: Don't accept heal commands until graph is up
Change-Id: Icca6c23b6a5965f462db8b65af3eb2e141c7cd39
BUG: 1049355
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6658
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c79a673a577d2ae19712a382bf094199b55fff69
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Tue Jan 7 14:22:03 2014 +0530
gNFS: mnt3_find_export() by pass AUTH check
NFS subdir mount does not respect nfs.rpc-auth-reject option
in the volume. If the volume is being mounted, then it would
validate the AUTH by mnt3_check_client_net() but if the client
is mounting a subdir, the control takes a different code path
i.e. mnt3_find_export() which does not bother about the AUTH.
FIX:
Enforce the AUTH check in mnt3_parse_dir_exports() which is
invoked by mnt3_find_export() for subdir mount.
Change-Id: I6fdd3e6bd6cbd32b0d9ca620cc4c30fdaff9ca30
BUG: 1049225
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6655
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5b3374563823358ceb5e17be04650afe95f15530
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Jan 4 17:29:26 2014 +0100
build: the main glusterfs package should not provide glusterfs-libs
Because of this incorrect provides, there is no requirement to update
glusterfs-libs. Most users will get a newer glusterfs-libs when updating
anyway, but users that manually select RPMs for updating my skip the
package, which will break their system.
Change-Id: I636dfac3f0a521924f1c2e82948bb513b0a5c9f9
BUG: 950083
Fedora-BUG: 1048489
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/6642
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 8852a12cb1422a269c4ea40dad8b17b7c95d9f60
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Dec 11 10:17:46 2013 +0100
Add the MAINTAINERS file
Different projects (Linux kernel, QEMU, ...) have a MAINTAINERS file in
the root of the git repository. This file mostly lists the maintainers
or main committers for certain files and directories. On occasion it
would be very helpful to know who to add as a reviewer for proposed
patches.
Change-Id: Ide68779c7477529808ccb0e7d421db160e3222ea
BUG: 1040351
URL: http://lists.nongnu.org/archive/html/gluster-devel/2013-11/msg00045.html
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/6480
Reviewed-by: Amar Tumballi <amarts@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 22f370316d52c2d7c8427ca7da0f1b0e227ca113
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Thu Jan 2 20:04:46 2014 +0530
Crypt: Fixing incorrect placement of GF_FREE i.e. we are trying access the memory after freeing it using GF_FREE
Change-Id: I2b22fd421131c618bd0d7c246ebf09f14751ad30
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6626
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8b4c5b839dd19d0131c242069fa136e264d4b80a
Author: Atin Mukherjee <amukherj@redhat.com>
Date: Fri Jan 3 13:36:40 2014 +0530
Glusterd : glusterd process generates core due to NULL store handle
Problem : glusterd crashed as backtrace revealed that store handle was
set to NULL.
Solution : In glusterd_store_global_info() function out block the
handle is dereferenced with out any NULL check which caused this
segmentation fault. A NULL check is introduced to avoid this. While
testing this fix, another issue was noticed where GF_ASSERT macro again
does not gurantee the NULL dereference check and hence this macro call
has been replaced by GF_VALIDATE_OR_GOTO macro call in places where
there is a danger of macro getting crashed due to NULL dereference
check.
Change-Id: Ic301aa45ce4bbdc2da751d2386439df7bb24c016
BUG: 1040844
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/6619
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a5461ec44812269b37692858d54c235baa3d0ce3
Author: Vijaykumar M <vmallika@redhat.com>
Date: Wed Dec 18 14:32:25 2013 +0530
pathinfo: Provide user namespace access.
Do not allow to setxattr for pathinfo
This change was missed out when submitted patch: http://review.gluster.org/5101/
Change-Id: Ifd32d95089b9bacc5dee80a8b924bb8713dca8a1
Signed-off-by: Vijaykumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6535
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ae41c4b429eb6988804ab460cd10f056b182cf14
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Thu Jan 2 20:55:59 2014 +0530
gNFS: Small memory leak in rpcsvc_drc_init()
1. The routine rpcsvc_drc_init() is only used while initialization of
NFS xlator. It should just check for nfs.drc option and init DRC feature
accordingly. If it's set to OFF, then rpcsvc_drc_init() allocates memory
for svc.drc and set ret value to 0 and goes to out: block where drc is
leaked.
2. rpcsvc_drc_init() should just allocate svc.drc and init it. Here
svc.drc can never be valid.
3. If svc.drc gets init'd here, no point of checking for drc type here.
Change-Id: I4085771cdb8c9c15d1b9c548b77929a37f27c124
BUG: 1047902
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6628
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d58b99a0475dc77bce1d2afad06ee7dee912e161
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Fri Jan 3 10:32:16 2014 +0530
gNFS: Possible SEGV crash in NFS while DRC is OFF
In rpcsvc_submit_generic(), FILE: rpc/rpc-lib/src/rpcsvc.c, while caching
the reply (DRC), the code does not check if DRC is ON and goes ahead
assuming DRC is on and try to take a LOCK on drc.
FIX: Put a check on svc->drc by rpcsvc_need_drc().
Change-Id: I52c57280487e6061c68fd0b784e1cafceb2f3690
BUG: 1048072
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6632
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a0681831dc88d1f8330136b82cc97e047668942d
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Jan 3 11:23:02 2014 +0530
performance/io-cache: reduce the severity of log-message
During a genuine error condition like network outage, the log grows
with redundant information.
Change-Id: I5a4f2f62da10ef656f14200c4c84a6917b1f0ddd
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
BUG: 1048084
Reviewed-on: http://review.gluster.org/6635
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 428f114f7f79c21934f7632dd4f9848d24b32240
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jan 2 23:06:39 2014 +0530
glusterd: update volinfo->subvol_count in newly added peers
Update the subvol_count when a peer imports information about the friend
volumes.
Change-Id: Id3884bd5727ff22be7ed87f43a1ec1b5fe34813c
BUG: 1047955
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/6629
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 45a0fb600b6f13ade690b8cd4b0515916d6b7787
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Dec 28 08:31:55 2013 +0100
Use linkat() instead of link() for portability sake
POSIX does not says wether link(2) on symlink should link on
symlink itself or on target. Linux use symlink, most other
systems use target. Using linkat(2) allows the behavior to be
specified, so that the behavior is portable.
Also fix configure test for NetBSD linkat(2), which ceased to work.
BUG: 764655
Change-Id: I2633fde3b0828ca8c199e11c827720c513e15852
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6613
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 06a83db3737d9e4f02340f93fb4f588a654a079c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Dec 19 14:11:45 2013 +0100
Use linkat() instead of link() for portability sake
POSIX does not says wether link(2) on symlink should link on
symlink itself or on target. Linux use symlink, most other
systems use target. Using linkat(2) allows the behavior to be
specified, so that the behavior is portable.
Also fix configure test for NetBSD linkata(2), which ceased to work.
BUG: 764655
Change-Id: Iccd27ac076b7a74e40dcbaa1c4762fd3ad59da5f
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6539
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bd81274d7cbb7c6535f90bc7259ec7b978aa8d7b
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Jan 1 21:36:27 2014 +0530
libglusterfs: Add missing goto in eh_new()
Change-Id: I64bbd8d5d919e78286a0521b62ca75f22ad296fa
BUG: 795419
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6623
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 6ffe0a39c2e08b20640dee05b5c14aac189129ee
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Dec 23 18:28:36 2013 +0530
mount/fuse: Remove duplicate GET_STATE call
Change-Id: I5716cb0e9914f78489e3422a03efc689f5ebc413
BUG: 952029
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6579
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b91f24ea1debd18e2b81486f5f80c902170bf1c0
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Dec 23 12:53:32 2013 +0100
rpc/server: add anonuid and anongid options for root-squash
Introduce new options to modify the behaviour of server.root-squash.
With server.anonuid and server.anongid the uid/gid can be specified and
the root user (uid=0 and gid=0) will be mapped to the given uid/gid
instead of nfsnobody (uid=65534 and gid=65534).
Many thanks to Vikhyat Umrao for writing the majority of the test-case!
Change-Id: I6379a3d2ef52b9b9707f2f6f0529657580c8d779
BUG: 1043886
CC: Vikhyat Umrao <vumrao@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/6546
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Vikhyat Umrao <vumrao@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 179150f09f9e0800e6f0d5bc8a0898bb0c147797
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Dec 23 02:52:12 2013 -0800
crypt: On calloc failure follow goto statement
At
--------------------------------------------
1423 if (local->vec.iov_base == NULL) {
--------------------------------------------
This condition being true leads to NULL pointer
to be passed into `memcpy` later at
----------------------------------------------------
1432 memcpy((char *)local->vec.iov_base + copied,
----------------------------------------------------
Avoid this by clean exit through a goto statement with
in the conditional.
Change-Id: I2546b7dd634dc251adae8ca39497c4c3ef520f62
BUG: 1030058
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6576
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Edward Shishkin <edward.shishkin@gmail.com>
Tested-by: Edward Shishkin <edward.shishkin@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 16d90acf3c640fed85aa10df15288c84ecb1bc9f
Author: Louis Zuckerman <me@louiszuckerman.com>
Date: Sat Dec 28 00:34:47 2013 -0500
Updating extras/Ubuntu with latest upstart configs (BUG: 1047007)
Change-Id: Ia769589f6af1d7ca3577185fd4c56eb9f43b3e2e
BUG: 1047007
Signed-off-by: Louis Zuckerman <me@louiszuckerman.com>
Reviewed-on: http://review.gluster.org/6611
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e122341f0f2f82d40a0e6b6ef34dee1b41590b81
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Dec 27 14:24:29 2013 +0530
features/index: Minor improvement in log message.
Change-Id: Ic4f39785dab5ad64def4c06d7bd2f2dec09e19ab
BUG: 1045690
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6606
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8dc01e32a885f5cf8e906ebec6d5243e3d4cf1b8
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri Dec 27 16:51:29 2013 +0530
test: Modified bug-1037501.t script
Change-Id: I3114009681d49249fe292f94a464efc419c944cb
BUG: 1037501
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/6596
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5b7c6d59088cd0f6cbc61efb4f69a77fe910f89f
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Dec 27 18:00:45 2013 +0530
protocol/server: Change log message severity
Change-Id: Ia6aaf8a106c26fa7118c86fadb6805d2877bb6ee
BUG: 849630
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6610
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8fceb6aa7b7ce9d8de43f1a9bfd41f78a5320f2d
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Dec 23 11:13:17 2013 -0800
build: fix day in the %changelog
This fixes `warnings` during build tests `rpm.t`
Change-Id: I706ceb1a39d046fe26f70f7b1b06f059abd5d3c0
BUG: 1000019
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6584
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 31802ec56860d5d5b59a32c191a2ff9c32a78a9e
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Dec 24 17:58:21 2013 +0530
socket: unix socket connect path can't be greater than UNIX_PATH_MAX characters
Change-Id: I74788b63dd1c14507aa6d65182ea4b87a2e1f389
BUG: 1046308
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6589
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a5f4afe825781f31c4321d6ddcece62b2e844af1
Author: Poornima G <pgurusid@redhat.com>
Date: Mon Dec 23 05:11:15 2013 +0000
gfapi: Closed the logfile fd and initialize to NULL in glfs_fini
Currently if logfile is closed and other threads call gf_log
after glfs_fini() is executed, it may lead to memory corruption.
Adding gf_log_fini() which closes the logfile and initializes
the logfile to NULL, thus any further logging happens to stderr.
Also added gf_log_globals_fini() which should be filled in the
future to release all the logging resources.
Change-Id: I879163e1a3636e65300d166f782517ee773cab65
BUG: 1030228
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6552
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 96b2ac0404c27eb9ea2a4d6d94c8ee887d586cba
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Dec 23 14:02:12 2013 +0530
cli: Fix xml output for volume status
The XML output for volume status was malformed when one of the nodes is
down, leading to outputs like
-------
<node>
<node>
<hostname>NFS Server</hostname>
<path>localhost</path>
<peerid>63ca3d2f-8c1f-4b84-b797-b4baddab81fb</peerid>
<status>1</status>
<port>2049</port>
<pid>2130</pid>
</node>
-----
This was happening because we were starting the <node> element before
determining if node was present, and were not closing it or clearing it
when not finding the node in the dict.
To fix this, the <node> element is only started once a node has been
found in the dict.
Change-Id: I6b6205f14b27a69adb95d85db7b48999aa48d400
BUG: 1046020
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6571
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a8f6fe9bbe55f58ec125b6681499885c54de55fb
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Dec 20 12:27:30 2013 +0530
mount.glusterfs:export PATH environment variable
Problem: spurious warning:
mount -t glusterfs 10.70.7.228:repvol /mnt/fuse_mnt/
WARNING: getfattr not found, certain checks will be skipped..
Fix:
export PATH so that getfattr search succeeds.
Change-Id: Ib19e2899e43a7d763a136b9fbc90823f743597a5
BUG: 1040348
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/6545
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 624448a0dfa919d99ba68f79198f4b3d7e230374
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Mon Dec 23 16:27:42 2013 +0530
bd: Check for capabilities for creating thin lv
Check capabitlies of the volume before trying to create thin LV.
BUG: 1028672
Change-Id: I1375f6f2a7576e223fc5d7cd40315999446db86a
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/6577
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b0467e01ca1343a3ef90dc15abe98537102c4534
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Dec 23 09:32:22 2013 +0000
cluster/afr: avoid race due to afr_is_transaction_running()
Problem:
------------------------------------------
afr_lookup_perform_self_heal() {
if(afr_is_transaction_running())
goto out
else
afr_launch_self_heal();
}
------------------------------------------
When 2 clients simultaneously access a file in split-brain, one of them
acquires the inode lock and proceeds with afr_launch_self_heal (which
eventually fails and sets "sh-failed" in the callback.)
The second client meanwhile bails out of afr_lookup_perform_self_heal()
because afr_is_transaction_running() returns true due to the lock obtained by
client-1. Consequetly in client-2, "sh-failed" does not get set in the dict,
causing quick-read translator to *not* invalidate the inode, thereby serving
data randomly from one of the bricks.
Fix:
If a possible split-brain is detected on lookup, forcefully traverse the
afr_launch_self_heal() code path in afr_lookup_perform_self_heal().
Change-Id: I316f9f282543533fd3c958e4b63ecada42c2a14f
BUG: 870565
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/6578
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Varun Shastry <vshastry@redhat.com>
commit d00d83500d74e7df50c103f78b1796cf3a434800
Author: James Shubin <james@shubin.ca>
Date: Sat Dec 21 03:35:37 2013 -0500
Fix typos, and spacing issues.
Change-Id: I459ba4e87e9bc4f1c373f7abe8701bfa8450253c
BUG: 1045690
Signed-off-by: James Shubin <james@shubin.ca>
Reviewed-on: http://review.gluster.org/6556
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1d64043a0b71aa66b6f62bb300971aca0fe6260a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Dec 22 18:32:11 2013 +0530
cli: Throw a warning during replace-brick
Change-Id: Ia024d055645ac2ec5cd506f2533831a159b38c20
BUG: 1039954
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6559
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit f1516fccbf41cc26340c4ed06a8367896358b59d
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sat Dec 21 23:35:19 2013 +0530
cli: Throw a warning during creation of rdma volumes.
Change-Id: I77155a7a4ff56a10079aab206af197e9d03e8a8a
BUG: 1017176
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6557
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e73d3be1a0cfb79155d11d10ec12e444df23724b
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Dec 16 10:29:19 2013 +0530
glusterd: make volinfo a refcnt'ed object.
Add glusterd_volinfo_remove(..) which removes @volinfo from the list
of volumes in the cluster and performs an unref on @volinfo
Change-Id: I5f546ca58f61bc334ab1bab4c51c4a21e1f66161
BUG: 1038051
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6521
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9763b5ae775a7bc5e65fe142bb07a1f8e3390457
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Dec 17 01:12:05 2013 +0530
glusterd: rebalance to ref volinfo before starting
Change-Id: Ib316897dcbd0748bfb3bfcda186b9fe30c07f80f
BUG: 1038051
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6522
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 1ea873cd83a6914ae8a6deecd6b6f41ccca0e086
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Thu Dec 19 18:11:38 2013 +0530
cluster/afr: For entry self heal, mark all source bricks
Problem:
Whenever a new brick is added into a replicate volume, all
source bricks are not marked as source. Only one of them is
marked as source. Here marked as source refers to adding
extended attribute at the backend of a file corresponding to
the newly added brick. As well as source bricks should point
to the newly added brick so that heal can be triggered.
Fix:
All source bricks will now point to newly added bricks and heal
can be triggered based on the extended attributes.
Change-Id: I318e1f779a380c16c448a2d05c0140d8e4647fd4
BUG: 1037501
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/6540
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit baa066063ec19da1f3576459331ed255c4826ca5
Author: Anuradha Talur <atalur@redhat.com>
Date: Sun Dec 15 13:26:15 2013 +0000
glusterd : enable/disable quota using volume set cmd deprecated.
Using the command 'gluster volume set <volname> quota {on|off}'
doesn't really enable/disable quota. So, a message to the user is
provided. Message asks the user to use 'gluster volume
quota <volname> {enable|disable}' instead.
Improvement of the previous method to solve the issue.
Change-Id: Ibeda35bb49ec7b541d53e592b48fd132380fce76
BUG: 1024626
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/6512
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 36870a018d38338fbfe40c810825ca17bb482b09
Author: Vijaykumar M <vmallika@redhat.com>
Date: Wed Dec 18 12:38:26 2013 +0530
glusterd: hold the lock when submitting ACC in replace-brick
replace-brick handler sets the timer to perform the replace operation and unlocks the big_lock.
So we need to lock inside 'glusterd_do_replace_brick' before submitting the ACC
Change-Id: I5525c62533bd92d3ac46587e5353e2443ad85851
BUG: 1044337
Signed-off-by: Vijaykumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6534
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 81128ccd48973e5ad4cb99230ca0a67b348aa712
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Dec 17 11:43:22 2013 +0530
glusterd: ignore failure to stop a stopped service.
kill(2) returns -1 with errno set to ESRCH when the pid of the process
being killed doesn't exist. Failing glusterd_brick_stop on a stopped
brick could result in volume-stop failing, in commit phase.
This fix prevents that from happening.
Change-Id: I00f46fa06e489a671efbb8e4119f545f8ccea329
BUG: 1038051
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6525
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7fad330f38be20c0853c8401feede52ca2623329
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Dec 17 16:09:02 2013 +0530
glusterd: Fix stopping of stale rebalance processes
Trying to stop rebalance process via RPC using the GD_SYNCOP macro,
could lead to glusterd crashing. In case of an implicit volume update,
which happens when a peer comes back up, the stop function would be
called in the epoll thread. This would lead to glusterd crashing as the
epoll thread doesn't have synctasks for the GD_SYNCOP macro to make use
of.
Instead of using the RPC method, we now terminate the rebalance process
by kill(). The rebalance process has been designed to be resistant to
interruption, so this will not lead to any data corruption.
Also, when checking for stale rebalance task, make sure that the old
task-id is not null.
Change-Id: I54dd93803954ee55316cc58b5877f38d1ebc40b9
BUG: 1044327
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6531
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 356fcb6337252973cab73a98f6c898b4d2476c16
Author: James Shubin <james@shubin.ca>
Date: Fri Dec 13 10:44:34 2013 -0500
Added Puppet-Gluster documentation from Puppet-Gluster project.
Change-Id: I196d97fb446f5938671c4cde6c460334999679cf
Signed-off-by: James Shubin <james@shubin.ca>
Reviewed-on: http://review.gluster.org/6507
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 4a9c5288f98c474e3cf24dc15f59f8d209bba0fc
Author: James Shubin <james@shubin.ca>
Date: Fri Dec 13 10:44:34 2013 -0500
Add boilerplate for easy, local, documentation testing.
Change-Id: I5386b4e1f05a30b051d81eaca557c93ede198b51
Signed-off-by: James Shubin <james@shubin.ca>
Reviewed-on: http://review.gluster.org/6506
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 2b08b7a9065a3c5316456541c24aaf7d8066dfc2
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Tue Dec 17 08:43:50 2013 +0530
gNFS: Client cache invalidation with bad fsid
1. Problem:
Couple of issues are seen when NFS-ACL is turned ON. i.e.
i) NFS directory access is too slow, impacting customer workflows
with ACL
ii)dbench fails with 100 directories.
2. Root cause: Frequent cache invalidation in the client side when ACL
is turned ON with NFS because NFS server getacl() code returns the
wrong fsid to the client.
3. This attr-cache invlaidation triggers the frequent LOOKUP ops for
each file instead of relying on the readdir or readdirp data. As
a result performance gets impacted.
4. In case of dbench workload, the problem is more severe. e.g.
Client side rpcdebug output:
===========================
Dec 16 10:16:53 santosh-3 kernel: NFS:
nfs_update_inode(0:1b/12061953567282551806 ct=2 info=0x7e7f)
Dec 16 10:16:53 santosh-3 kernel: NFS:
nfs_fhget(0:1b/12061953567282551806 ct=2)
Dec 16 10:16:53 santosh-3 kernel: <-- nfs_xdev_get_sb() = -116 [splat]
Dec 16 10:16:53 santosh-3 kernel: nfs_do_submount: done
Dec 16 10:16:53 santosh-3 kernel: <-- nfs_do_submount() = ffffffffffffff8c
Dec 16 10:16:53 santosh-3 kernel: <-- nfs_follow_mountpoint() = ffffffffffffff8c
Dec 16 10:16:53 santosh-3 kernel: NFS: dentry_delete(clients/client77, 20008)
As per Jeff Layton, This occurs when the client detects that the fsid on
a filehandle is different from its parent. At that point, it tries to
do a new submount of the new filesystem onto the correct point. It means
client got a superblock reference for the new fs and is now looking to set
up the root of the mount. It calls nfs_get_root to do that, which basically
takes the superblock and a filehandle and returns a dentry. The problem
here is that the dentry->d_inode you're getting back looks wrong. It's not
a directory as expected -- it's something else. So the client gives up and
tosses back an ESTALE.
Which clearly says that, In getacl() code while it does the stat() call
to get the attrs, it forgets to populate the deviceid or fsid before
going ahead and does getxattr().
FIX:
1. Fill the deviceid in iatt.
2. Do bit more clean up for the confusing part of the code.
NB: Many many thanks to Niels de Vos and Jeff Layton for their
help to debug the issue.
Change-Id: I8d3c2a844c9d1761051a883b5ebaeb84062a11c8
BUG: 1043737
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6523
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1e0aaf2c70af250f667ddbadac4f0cc85d9256fc
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Dec 9 16:46:06 2013 +0530
cluster/afr: Add foreground self-heal launch capability through lookup
Also renamed allow-sh-for-running-transaction -> attempt-self-heal
Change-Id: I134cc79e663b532e625ffc342c59e49e71644ab3
BUG: 1039544
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6463
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: venkatesh somyajulu <vsomyaju@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 23ee7005ebf968ed4ac6a0ff7b63d814760a137d
Author: Prashanth Pai <ppai@redhat.com>
Date: Fri Dec 13 16:20:11 2013 +0530
doc: Fix markdown format errors
Made the following minor changes:
* Fix broken links and point to correct image paths
* Remove dead links and references
* Fix table format to conform to Github Flavoured Markdown
* Add few common terms to glossary
* Maintain consistency of format in writing headings <h1..h6>
* Remove irrelevant files
* Remove references to contact Red Hat support.
Change-Id: I4aed4945d56b5d68b8ea133ce5fa3162bfc2864f
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/6514
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d5233f5f35132114de695cbcb3557228da1cff22
Author: Vijaykumar M <vmallika@redhat.com>
Date: Thu Dec 12 11:40:36 2013 +0530
pathinfo: Provide user namespace access.
Locality can be now queried by unprivileged users with
key "glusterfs.pathinfo".
Setting both "glusterfs.pathinfo" and "trusted.glusterfs.pathinfo"
on disk is prevented with this patch.
Original Author: Vijay Bellur <vbellur@redhat.com>
Change-Id: I4f7a0db8ad59165c4aeda04b23173255157a8b79
Signed-off-by: Vijaykumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/5101
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0fc07713bccfad04a79db5f30f05c2f38a99923f
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Aug 8 15:50:31 2013 +0530
rpc,glusterd: Use rpc_clnt notifyfn to cleanup mydata
rpc:
- On a RPC_TRANSPORT_CLEANUP event, rpc_clnt_notify calls the registered
notifyfn with a RPC_CLNT_DESTROY event. The notifyfn should properly
cleanup the saved mydata on this event.
- Break the reconnect chain when an rpc client is disabled. This will
prevent new disconnect events which can lead to crashes.
glusterd:
- Added support for RPC_CLNT_DESTROY in glusterd_brick_rpc_notify
- Use a common glusterd_rpc_clnt_unref() function throught glusterd in
place of rpc_clnt_unref(). This function correctly gives up the
big-lock before performing the unref.
Change-Id: I93230441c5089039643fc9f5632477ef1b695348
BUG: 962619
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5512
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7b5022f3bce6662e7fd103dfa3246611bdd935bf
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Dec 10 11:34:06 2013 +0530
glusterd: Save/restore/sync rebalance dict
A dictionary was added to store additional information of a rebalance
process, like the bricks being removed in case of a rebalance started
by remove-brick. This dictionary wasn't being stored/restored or synced
during volume sync, leading to errors like a volume status command
failing. These issues have been fixed in this patch. The rebalance dict
is now stored/restored and also exported/imported during volume sync.
Also, this makes sure that the rebalance dict is only create on
remove-brick start. This adds a bricks decommissioned status to the
information imported/exported during volume sync.
Change-Id: I56fed23dc2de80a96648055fe705e9c3ffd55227
BUG: 1040809
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6492
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c61bb88fad3834706740ef064e8994256142e7e0
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Dec 9 17:12:49 2013 +0530
glusterd: Fix incorrect remove-brick status
PROBLEM:
'remove-brick status' was reported to be showing the status
of a previous rebalance op that was aborted, on the node which
doesn't participate in the remove-brick operation.
FIX:
Unconditionally reset defrag status to NOT_STARTED whenever a
remove-brick or a rebalance op is attempted.
Change-Id: Iddf3a14a2ef352e77e0f690fe65aa36ec3011257
BUG: 1040371
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/6482
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 96e3546314301b0a64852b9ed2ba9babc905ec48
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Wed Dec 11 14:32:49 2013 +0530
features/quota: log usage only if hard limit not exceeded.
Change-Id: I60abf576999996e0d0d65534e1e416f6e10994c8
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
BUG: 969461
Reviewed-on: http://review.gluster.org/6479
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1fab20ce0686793822c49bfa5aea26df9c5825cc
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Dec 10 07:26:46 2013 -0500
build: Merge glusterfs.spec changes from Fedora
sync with FedoraSCM glusterfs.spec
N.B. the %doc hack for clear_xattrs.sh doesn't work in the CentOS 5 mock
builds of the rpm.t regression test, thus I'm leaving that out for now
Change-Id: I6fa85618c916a90fdbed5b231ea58bb51c9d2b70
BUG: 950083
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/6473
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 4a6a16dbccf707a94d3cd0089a393e0190668fbd
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Dec 11 17:30:13 2013 +0530
glusterd: fix error in remove-brick-replica validation
Problem:
Reducing replica count of a volume using remove-brick command fails
if bricks are specified in a random order.
Fix: Modify subvol_matcher_verify() to permit order agnostic
replica count reduction.
Change-Id: I1f3d33e82a70d9b69c297f69c4c1b847937d1031
BUG: 1040408
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/6489
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3b0329583ab93ded3a983de2a2112e370d650585
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Sep 14 19:51:13 2013 -0700
mount.glusterfs: getopts support and cleanup
This patch is an attempt to provide some much needed
cleanup for future maintenance of `mount.glusterfs`
- Add checks for command failures
- Spliting large code into subsequent simpler functions
- Standardized variables
- use 'bash' instead of 'sh' - since string manipulation
and variable handling is far superior
- Overall code cleanup and Copyright change to Red, Hat Inc.
- Add new style of mounting with a comma separated list
~~~
$ mount -t glusterfs <IP1/HOSTNAME1>,<IP2/HOSTNAME2>,..<IPN/HOSTNAMEN>:/<VOLUME> <MNT>
~~~
- Update age old `manpage` with new options :-)
Change-Id: I294e4d078a067d67d9a67eb8dde5eb2634cc0e45
BUG: 1040348
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5931
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b0f311bcbdf1abbd8d736bc4a8f593e31b86bda5
Author: Anand Avati <avati@redhat.com>
Date: Thu Dec 12 15:43:28 2013 -0800
dht: handle ESTALE/ENOENT in dht_access
Had misssed out dht_access in the previous round of cleanup
Change-Id: Ib255b9ad13ca62a8bc2eea225c46632aff8e820f
BUG: 1032894
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6496
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
commit dc1ba662eb0b6b4d97f4d509ed020fb77d07f227
Author: Anand Avati <avati@redhat.com>
Date: Tue Dec 10 14:28:22 2013 -0800
posix: if brick-uid or brick-gid is not specified, do not set
Current code would set owner uid/gid explicitly to 0/0 on start
even if none was specified. Fix it.
Change-Id: I72dec9e79c51bd1eb3af5334c42b7c23b01d0258
BUG: 1040275
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6476
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Lukáš Bezdička <lukas.bezdicka@gooddata.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6555c2f719eeebf019c373cbd65381819a195af0
Author: Ajeet Jha <ajha@redhat.com>
Date: Mon Dec 2 12:55:18 2013 +0530
glusterd/geo-rep: more glusterd and cli fixes for geo-rep.
-> handle option validation cases in reset case.
-> Creating valid conf path when glusterd restarts.
-> Reading the gsyncd worker thread status and displaying it.
-> Displaying status-detail per worker.
-> Fetch checkpoint info in geo-rep status.
-> use-tarssh value validation added.
misc: misc geo-rep fixes based on cluster, logrotate etc..
-> cluster/dht: fix 'stime' getxattr getting overwritten.
-> cluster/afr: return max of 'stime' values in subvol.
-> geo-rep-logrotate: Sending SIGHUP to geo-rep auxiliary.
-> cluster/dht: fix convoluted logic while aggregating.
-> cluster/*: fix 'stime' min/max fetch logic.
Change-Id: I811acea0bbd6194797a3e55d89295d1ea021ac85
BUG: 1036552
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/6405
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 205dd3482496f05dac950dd97e57b43546d65bf1
Author: Ajeet Jha <ajha@redhat.com>
Date: Mon Dec 2 12:37:34 2013 +0530
gsyncd / geo-rep: geo-replication fixes
-> "threaded" hybrid crawl.
-> Enabling metatadata synchronization.
-> Handling EINVAL/ESTALE gracefully while syncing metadata.
-> Improvments to changelog crawl code.
-> Initial crawl changelog generation format.
-> No gsyncd restart when checkpoint updated.
-> Fix symlink handling in hybrid crawl.
-> Slave's xtime key is 'stime'.
-> tar+ssh as data synchronization.
-> Instead of 'raise', just log in warning level for xtime missing cases.
-> Fix for JSON object load failure
-> Get new config value after config value reset.
-> Skip already processed changelogs.
-> Saving status of each individual worker thread.
-> GFID fetch on slave for purges.
-> Add tar ssh keys and config options.
-> Fix nlink count when using backend.
-> Include "data" operation for hardlink.
-> Use changelog time prefix as slave's time.
-> Process changelogs in parallel.
Change-Id: I09fcbb2e2e418149a6d8435abd2ac6b2f015bb06
BUG: 1036539
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/6404
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8d93cd709f5cbf8a1d4a094756576d0dc679161b
Author: Ajeet Jha <ajha@redhat.com>
Date: Mon Dec 2 13:04:51 2013 +0530
features/changelog: more changelog fixes.
-> log additional records.
-> include FOP number for metadata.
-> prevent crash if inode is not found in a fop.
Change-Id: I9edd4b71819ebd68c6a2b4150ae279c471d129da
BUG: 1036536
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/6403
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 103694a4ef4e1e1078560436902501b763798c0d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Dec 11 15:19:25 2013 +0530
cluster/dht: Make sure gf_defrag_migrate_data is not optimized
Problem:
Whenever there syncop_xxx() is used inside a synctask and gcc
optimizes it when compiled with -O2 there is a problem where
'errno' would not work as expected.
Fix:
Until http://review.gluster.com/6475 is reviewed and merged
we are making sure the function is not going to be optimized.
Change-Id: I504c18c8a7789f0c776a56f0aa60db3618b21601
BUG: 1040356
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6481
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7fcef01a2b9aca9cef15e649eacb3de0cacb5738
Author: Anuradha <atalur@redhat.com>
Date: Wed Oct 30 11:57:38 2013 +0530
cli : enabling/disabling quota using volume set cmd deprecated
Using the command 'gluster volume set <volname> quota {on|off}'
doesn't really enable/disable quota. So, a message to the user is
provided. Message asks the user to use 'gluster volume
quota <volname> {enable|disable}' instead.
Change-Id: Ic4e12d5f8298ca9233639b4f6f8601ed6937fecb
BUG: 1024626
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/6192
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c83d01a79dd6ed1ddb80267ff79627c467eb8d4b
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Sep 6 14:50:35 2013 +0530
gfid-access: do chown() after creating the new entries
changing the 'frame->root->uid' on the fly is not a good idea as
posix-acl xlator on brick process would fail the op.
Change-Id: I996b43e4ce6efb04f52949976339dad6eb89bede
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 847839
Reviewed-on: http://review.gluster.org/5833
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit de69c5709638bdb4ecd5d5c14691a49af0b61ed6
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Nov 22 11:27:14 2013 +0530
glusterd: Improve rebalance handling during volume sync
Glusterd will now correctly copy existing rebalance information when a
volinfo is updated during volume sync. If the existing rebalance
information was stale, then any existing rebalance process will be
termimnated. A new rebalance process will be started only if there is no
existing rebalance process. The rebalance process will not be started if
the existing rebalance session had completed, failed or been stopped.
Change-Id: I68c5984267c188734da76770ba557662d4ea3ee0
BUG: 1036464
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6334
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit eec786a373f02fa80019a8b5718c48667ec470af
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Dec 5 11:16:55 2013 +0530
dht: Set status to FAILED when rebalance stops due to brick going down
Change-Id: I98da41342127b1690d887a5bc025e4c9dd504894
BUG: 1038452
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6435
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <gowda.shishir@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9afa6117255b4974e36eaf297c33a15ebbb30f46
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Dec 9 16:10:56 2013 +0530
mount/fuse: cleanup old graphs.
After a graph switch, a PARENT_DOWN event from fuse indicates
protocol/client to shutdown all its sockets. However, this event will
be sent only when the first fop is received from fuse mount after
graph switch. Also, this event is sent only on previously active graph.
So, if there are multiple graph switches when there is no activity on
mountpoint, we'll be left with a list of graphs with their sockets
still open.
This patch fixes the issue by sending PARENT_DOWN to previously
non-active graph when a new graph is available irrespective of whether
there is an activity on mount-point.
Change-Id: I9e676658d797c0b2dd3ed5ca5a56271bd94b4bb6
BUG: 924726
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/4713
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b0b12e83390fe112c3a5ddb20238c24a0612c37e
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Dec 9 08:50:49 2013 -0800
mount.glusterfs: Provide backward compatibility for "backup-volfile-servers"
In commit "b610f1be7cd71b8f3e51c224c8b6fe0e7366c8cf" we deprecated
"backupvolfile-server" and provided a new option for specifying
multiple backup servers. This resulted in existing `fstab` entries
invalid and leading to mount failure. Provide backward compatibility
to avoid this regression.
Change-Id: Ic20671bbe2a0df36b6110ffa928396f808eb76e5
BUG: 1039643
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6464
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e9df02646ffaf785271500f0342b8a06cd99af9e
Author: Bharata B Rao <bharata@linux.vnet.ibm.com>
Date: Mon Dec 9 11:15:02 2013 +0530
libglusterfs: Explicitly open /dev/stderr logfile
Currently if stderr is specified as logfile, /dev/stderr isn't opened but
stderr is directly used. However libgfapi closes the logfile (and hence
stderr) from glfs_fini() which results in stderr becoming unavailable for
the application that links to libgfapi. Prevent this unexpected behaviour
for the application by explicitly opening /dev/stderr like it is done for
any other logfile.
Change-Id: I76b754598a2acf40b91ff0461726c5918e278c84
BUG: 1038924
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Reviewed-on: http://review.gluster.org/6452
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5f0e45ec201709331b0f2739990660f4822114a2
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Dec 6 14:33:51 2013 -0500
build: FedoraSCM sources are not longer needed to build RPMs
Also some updates to .gitignore
Change-Id: I576af453ca7d1ec1f3db21ee4d8386927988e7db
BUG: 950083
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/6458
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a8c05770b75367b3dc70ae7f1b88a72283d80abc
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Dec 5 12:31:34 2013 +0530
libglusterfs: Free IP address string in gf_is_local_addr()
Change-Id: Ib113de269134c907aa2f35459e2764c142b94477
BUG: 1032122
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6433
Tested-by: Lukáš Bezdička <lukas.bezdicka@gooddata.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 60eb12b6495d1dd970b5d0f8565347a3ef51b024
Author: Anand Avati <avati@redhat.com>
Date: Wed Nov 27 12:54:41 2013 -0800
index: fix the order of initialization
thread spawning must be the last action. if not, failures after
thread creation can set this->private to NULL and cause index_worker
to segfault
Change-Id: I71c85c25d7d6d1ed5f8d9c951db0262b8a3f1d90
BUG: 1034085
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6426
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit dcef8fa69c8b0aca6cced008dae4264004e1ae2c
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Dec 2 11:37:55 2013 +0530
cli: Fail creation of bricks on root partition in script mode
Also added an option 'wignore' to save ourselves the trouble
of modifying test scripts in our regression test suite as well
as those that are still under review.
Change-Id: Id320c03595506e9da187e766991c19640bd000c5
BUG: 1028281
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/6409
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 09f678249e5e27b406415a2b3786befbb1c25588
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Oct 30 18:25:39 2013 +0530
glusterd: Aggregate tasks status in 'volume status [tasks]'
Previously, glusterd used to just send back the local status of a task
in a 'volume status [tasks]' command. As the rebalance operation is
distributed and asynchronus, this meant that different peers could give
different status values for a rebalance or remove-brick task.
With this patch, all the peers will send back the tasks status as a part
of the 'volume status' commit op, and the origin peer will aggregate
these to arrive at a final status for the task.
The aggregation is only done for rebalance or remove-brick tasks. The
replace-brick task will have the same status on all the peers (see
comment in glusterd_volume_status_aggregate_tasks_status() for more
information) and need not be aggregated.
The rebalance process has 5 states,
NOT_STARTED - rebalance process has not been started on this node
STARTED - rebalance process has been started and is still running
STOPPED - rebalance process was stopped by a 'rebalance/remove-brick
stop' command
COMPLETED - rebalance process completed successfully
FAILED - rebalance process failed to complete successfully
The aggregation is done using the following precedence,
STARTED > FAILED > STOPPED > COMPLETED > NOT_STARTED
The new changes make the 'volume status tasks' command a distributed
command as we need to get the task status from all peers.
The following tests were performed,
- Start a remove-brick task and do a status command on a peer which
doesn't have the brick being removed. The remove-brick status was
given correctly as 'in progress' and 'completed', instead of 'not
started'
- Start a rebalance task, run the status command. The status moved to
'completed' only after rebalance completed on all nodes.
Also, change the CLI xml output code for rebalance status to use the
same algorithm for status aggregation.
Change-Id: Ifd4aff705aa51609a612d5a9194acc73e10a82c0
BUG: 1027094
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6230
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit cfc4dc01990071f0ff5cfddef1fcf7763e8bba39
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Dec 4 12:32:59 2013 -0500
contrib/qemu: remove the CONFIG_INT128 host config option
These leads to compile failures in 32-bit build environments.
BUG: 986775
Change-Id: I0b702f616e1d0e11eda7e55666fd1a7c67bfaeab
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/6427
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit bf8389088259b566d1b632fae6a1a6f8faa890fb
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Dec 4 15:55:01 2013 +0530
glusterd: create rpc obj for rebalance only if absent
Change-Id: Iff305023577ff92a8f43f24dafcf201f86805769
BUG: 1038051
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6423
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 50dcbd3eed1b36ffd7da8624e3c3116053a688ec
Author: Anand Avati <avati@redhat.com>
Date: Wed Nov 27 05:09:57 2013 -0800
glusterd: submit RPC requests without holding big lock
If the endpoint of an RPC is not connected, the callback is called
synchronously within rpc_clnt_submit(). Since callbacks typically
hold the big lock, give up the big lock before calling rpc_clnt_submit
and acquire it freshly after the call.
Change-Id: Id89d8dd86c1a4012739ef4af7ea0935492b1a02b
BUG: 1037849
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6413
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit de7e5c4a745e05ab0c30baf3c2ea2bc260b41f52
Author: Vijaikumar M <vmallika@redhat.com>
Date: Wed Nov 6 16:41:50 2013 +0530
glusterd: Do not allow remove-brick commit if the bricks are not decommissioned
Change-Id: Ibf47ea848bbb7ae37ccf91c40e5fe0e2338438b7
BUG: 1027171
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6233
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit ea680f0f11818eed27d559bcee94def73437ed92
Author: Dawit Alemu <dalemu@redhat.com>
Date: Thu Nov 14 12:52:14 2013 -0500
cli: Add an option to fetch just incremental or cumulative I/0 information
'volume profile info' fetches both cumulative and incremental
I/O statistics. There isn't a way to fetch just cumulative or
incremental statistics.
This change introduces two optional arguments, namely "incremental"
and "cumulative", that can be tacked on to 'volume profile info'.
In other words, the new command format is
volume profile <VOLNAME> {start | info [incremental | cumulative]
| stop} [nfs]
'volume profile info incremental' - fetches incremental stats
'volume profile info cumulative' - fetches cumulative stats
'volume profile info' - fetches incremental and cumulative stats
Change-Id: I5ddb45d990542ea611d23d251efebfec46f472d0
BUG: 1030580
Signed-off-by: Dawit Alemu <dalemu@redhat.com>
Reviewed-on: http://review.gluster.org/6264
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 14e72c2e0e3c43fb7f9e7140a4e07dadcbaf689c
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Wed Nov 27 15:50:21 2013 +0530
gNFS: Inconsistent behaviour of setfacl/getfacl
The permissions returned by NFS ACL are wrong, which are rejected
by NFS client as "Invalid argument". Refactor the NFS ACL code
to return the proper permissions which would match with the
requested permissions.
Change-Id: I409a6600538a90f2c5c2e8d84657c3b508468fe6
BUG: 1035218
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6368
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 77af2959315b7572885fb657f84cc68338d7627b
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Nov 22 13:03:57 2013 +0530
cli: More checks in rebalance status output
Change-Id: Ibd2edc5608ae6d3370607bff1c626c8347c4deda
BUG: 1031887
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6337
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d73922836ed224fc2970adbb692f5aa19600b30d
Author: Poornima <pgurusid@redhat.com>
Date: Tue Dec 3 05:46:40 2013 +0000
cluster/afr: handle NULL check before strlen/strcmp in fgetxattr
xattr name can legally be NULL. Handle that case without crashing.
Change-Id: Ie214cb05ccd52565dc247a9234ad83ae799d3866
BUG: 1036879
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6412
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 982cb7d9048dc39aaf2fe803349d0244dc005023
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Dec 2 07:59:08 2013 -0500
gfapi: add __THROW [(__attribute) ((__nothrow__))] to fn decls for C++ users.
Off hand I don't know of anything written in C++ that is or could be a user
of gfapi.
Never the less, it's possible that one could exist, or be written, and
marking the library entry points is a) friendly, b) possibly allows the
C++ compiler to generate better code, and c) is a good practice when
writing APIs that might be consumed by C++ applications. Considering we
already take the first step and use __BEGIN_DECLS/__END_DECLS to be C++
friendly, we should take the extra step
Change-Id: Ib319ecaa452a46f258a9c6e8c7221454d2fefd0f
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/6393
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3c8d3dbc9c2df1404278e921c02740c82444d953
Author: Anand Avati <avati@redhat.com>
Date: Tue Nov 26 19:38:01 2013 -0800
protocol/client: handle network disconnect/reconnect properly
if client/server state versions match, we still need to notify
parent xlators of reconnection (CHILD_UP) because they were
notified of CHILD_DOWN at the time of disconnection.
Change-Id: I36c4bde6d8c3db9cb0c48eeb10663b56897c932e
BUG: 1037267
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6396
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 09270f83809a9f2e3649bcb5f3fad0d2b1fae0d1
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Dec 1 20:11:24 2013 +0530
cluster/afr: Fix description string for option 'self-heal-daemon'
Change-Id: I267b935a16a6fdc72a4e791f681289e6868baee6
BUG: 1010834
Reviewed-on: http://review.gluster.org/6385
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 11193f52780b1a1306f6b58962e4c621951c9f17
Author: Aravinda VK <avishwan@redhat.com>
Date: Mon Dec 2 15:19:17 2013 +0530
cli: xml: Rebalance status(xml) was empty when a glusterd down
When a glusterd is down in cluster rebalance/remove-brick status
--xml will fail to get status and returns null.
This patch skips collecting status if glusterd is down, and
collects status from all the other up nodes.
Change-Id: I6df0feef41b5cc817cc8d7820ee2acac95176a98
BUG: 1036564
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/6391
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 82718722d8ac6e47d1265a4fcfc7c188f497a9f0
Author: Anand Avati <avati@redhat.com>
Date: Tue Nov 26 13:30:46 2013 -0800
cluster/dht: handle NULL check before strlen/strcmp in fgetxattr
@key can legally be NULL. Handle that case without crashing.
Change-Id: Iaae293caa7eeb24afc9cd2580799173e2ce00911
BUG: 1036879
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6395
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a1d3d49f05b6b2d45704e75fdf203c6fbfcfa7f1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Oct 7 16:00:59 2013 +0530
features/marker: Filter quota xattrs on file as well
Problem:
Quota contributions of a file/directory are tracked by quota
xlator using xattrs on the file. Quota allows these xattrs to be
healed as part of metadata self-heal. This leads to
wrong quota calculations on this brick after self-heal because
quota xattrs don't represent the actual contributions on the
brick anymore.
Fix:
Don't let self-heal of this xattr happen as part of self-heal
by filtering quota xattrs on file in listxattr.
Change-Id: Iea68a116595ba271e58c6fdcc3dd21c7bb55ebb3
BUG: 1035576
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6374
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 607f3c2f65227aa09dd5be1c48e369e9ff2e3795
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Nov 25 15:16:23 2013 +0530
cli, glusterd: More quota fixes ...
... which may be grouped under the following categories:
1. Fix incorrect cli exit status for 'quota list' cmd
2. Print appropriate error message on quota parse errors in cli
Authored by: Anuradha Talur <atalur@redhat.com>
3. glusterd: Improve quota validation during stage-op
4. Fix peer probe issues resulting from quota conf checksum mismatches
5. Enhancements to CLI output in the event of quota command failures
Authored by: Kaushal Madappa <kmadappa@redhat.com>
7. Move aux mount location from /tmp to /var/run/gluster
Authored by: Krishnan Parthasarathi <kparthas@redhat.com>
8. Fix performance issues in quota limit-usage
Authored by: Krutika Dhananjay <kdhananj@redhat.com>
Note: Some functions that were used in earlier version of quota,
that aren't called anymore have been removed.
Change-Id: I9d874f839ae5fdcfbe6d4f2d727eac091f27ac57
BUG: 969461
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/6366
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4f85943501bedeaa2512572ad20817b022b77338
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Nov 26 14:23:08 2013 -0500
glusterfsd: fix small memory leaks in glusterfsd-mgmt.c
E.g. In glusterfs_volfile_fetch(), req.xdata.xdata_val is allocated
in dict_allocate_and_serialize() but not freed after mgmt_submit_request().
A survey of dict_allocate_and_serialize/_submit_request in
glusterfsd-mgmt.c shows no consistent pattern of freeing the xdata_val
and also the dict, which is a little disturbing. (Yes, clearly not
every place this occurs needs to be freed the same way.)
Change-Id: Ic306d60b157e97c822a562bfdf21896e40db632a
BUG: 1036102
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/6363
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 010610324277cde2f64fb56bc536aa657643c659
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Nov 28 14:15:29 2013 +0530
mount/fuse: Prevent release_cbk not implemented warning
Change-Id: I53f0cb30f62ee9154670debf92476a51d6156844
BUG: 1035639
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6375
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1368dd926c69e192cfba35b655660c3f9af63600
Author: Anuradha <atalur@redhat.com>
Date: Mon Nov 25 14:48:23 2013 +0530
features/index : Creation of indices directory as soon as brick is up.
Missing indices directory in the bricks leads to unwanted log messages.
Therefore, indices directory needs to be created as soon as the brick
comes up.
This patch results in creation of indices/xattrop directory as required.
Also includes a testcase to test the same.
Change-Id: Ic2aedce00c6c1fb24929ca41f6085aed28709d2c
BUG: 1034085
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/6343
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 41a0f622cfaeb8118804b0e84f8fbcb81926f608
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Nov 28 16:47:09 2013 +0530
posix-acl: Fix crash resulting from GF_FREE() done on a CALLOC'd object
The object in question was created in posix_acl_inherit () and
was being GF_FREE'd as part of data_destroy().
Change-Id: Ibdb7c3b5c10ce447f061bde68452502e5170de92
BUG: 1035751
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/6377
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4cd45d74aa298479f1b6176c2da54b2576d090a9
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Nov 22 01:26:29 2013 -0800
glusterfs.spec: Add 'python and python-ctypes' dependency
Change-Id: Icde586131bab00476abc44d8dd4e2db7e9d59b2b
BUG: 1033275
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6339
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 528464989d23c8a90c724cad6de60e087054e43e
Author: Varun Shastry <vshastry@redhat.com>
Date: Tue Oct 15 17:25:51 2013 +0530
features/quota: Add the quota config xattr to newly added brick
Issue:
Quota directory limit configuration is stored in the xattrs. When a new brick
is added these 'limit-set' xattrs have to be created to the directory in the
new brick. This is done by the dht directory healing when the directory is
created in the new brick. Since 'root' directory is already created DHT doesn't
heal the limit-set xattr root.
Solution:
When the add-brick command is issued run the below hook script to heal the
'limit-set' xattr. The hook script does the following only if limit is
configured on root.
1. Create an auxiliary mount.
2. getxattr 'limit-set' on the root
3. setxattr the same value on the root
But this script needs the volume to be started to make the auxiliary mount.
To handle the case when the add-brick is issued when the volume was stopped,
symlink is created by the 'master' script to the corresponding location and
these two are by default disabled.
So, a 'master' script is added in the add-brick/pre. When add-brick command is
issued, it enables one of the scripts mentioned above based on the condition,
if volume is started - enable add-brick/post script
else - enable start/post script
After the actual script completes its job, it disables itself.
Note:
The enabling and disabling of the script is based on the glusterd's logic, that
it only runs the scripts which starts its name with 'S'. So,
Enable - symlink the file to 'S'*
Disable - unlink the symlink.
Change-Id: I2d3947a4d686c54417ec95f530af3bdd3444f4e2
BUG: 969461
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/6104
Reviewed-by: Brian Foster <bfoster@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a0dbf35940d6b922b18ca11ba79131e51fd3ce93
Author: Bala.FA <barumuga@redhat.com>
Date: Thu Nov 21 17:16:39 2013 +0530
cli: use proper copy to set node-name
Previously node-name is set to point to node-uuid which could cause
memory leak. This is fixed by having memory copy of node-uuid.
BUG: 1012296
Change-Id: I3b638ec289d5b167c6e752ef1ba41f41efacb9da
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/6330
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2d1836c09fec3361f327cf1faa41a756306f6f82
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Nov 26 12:58:31 2013 -0500
Fix CFLAGS handling with enable_debug.
The value was getting stomped by the Python stuff (for glupy) after we
had supposedly dealt with enable_debug, so we were getting stray -O2
options that hamper debugging.
Change-Id: Iacd616071c83b92018b597b6144ab565bd5fc66f
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/6362
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 781bc27132b75700c677e2306c240d6d283cdb61
Author: Vijaykumar M <vmallika@redhat.com>
Date: Tue Nov 26 18:01:17 2013 +0530
posix: do not allow to set/get "trusted.glusterfs.volume-id" xattr
Change-Id: I2e9a2264b1fd5ebc1ed0aff30225e89acbd0bcb4
BUG: 1034716
Signed-off-by: Vijaykumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6361
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a4c3b74016c3e6a2401189cda2e340d6da84fce4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Nov 22 12:09:53 2013 +0530
cluster/dht: Handle Link-info getxattr failure in rebalance
When getxattr fails with errno other than ENODATA fail rebalance
on that file. Log the reason for error.
Change-Id: Ia519870b88e6e6dd464d1c0415411aa999f80bc9
BUG: 1032927
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6341
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dd2a296a68a7ae5e72a603f94c659c4ef8088f41
Author: Anand Avati <avati@redhat.com>
Date: Mon Nov 25 03:13:17 2013 -0800
write-behind: handle iobref_merge() error gracefully
.. by UNWINDing ENOMEM error, rather than crashing.
Change-Id: Ica2d6399eaf7e381e7ebc41155620559c139c4d3
BUG: 1034398
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6349
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
commit 8cab4baa53429ddee82fe99155107a64c42fb821
Author: Anand Avati <avati@redhat.com>
Date: Mon Nov 25 03:19:11 2013 -0800
io-cache: handle iobref_merge() error gracefully
.. by UNWINDing ENOMEM, rather than leaving pointer in vector pointing
to stale memory.
Change-Id: I7f3917ac056fae144f845c9d123233e91e278187
BUG: 1034398
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6351
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
commit 349351629bbbc69fb4347d60b924df9885567713
Author: Anand Avati <avati@redhat.com>
Date: Mon Nov 25 03:16:49 2013 -0800
read-ahead: handle iobref_merge() error gracefully
.. by UNWINDing ENOMEM rather than leaving pointers in vector which
points to unref'ed (or even worse, re-used) iobufs.
Change-Id: I849d8cbe5fc02ee992d4e28b7212c49aad4925c7
BUG: 1034398
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6350
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
commit 8ca5578a20ddabf9382520c728a3fbce1647efc1
Author: Anand Avati <avati@redhat.com>
Date: Mon Nov 25 03:08:19 2013 -0800
iobufs: make iobref container size dynamic
With gfapi we can receive read/write size beyond the natural limits
of FUSE and NFS server. iobref was hardcoded to hold iobuf refs up
to 16 in count, which imposes a natural limit of 2MB with 128KB page
sizes of read-ahead and io-cache. Fix this by making iobref's iobuf
ref container size dynamic.
Change-Id: I93d88104d6c5e7af96cc9f1bfcc870d80fa81dad
BUG: 1034398
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6348
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
commit 0c89bc973273b8a59c64cbdfcb31945d87433096
Author: Anand Avati <avati@redhat.com>
Date: Mon Nov 25 10:28:56 2013 -0800
socket: limit vector count to IOV_MAX
IOV_MAX is the maximum supported vector count on a given platform.
Limit the count to IOV_MAX if higher. As we are performing non-blocking
IO getting a smaller return value is handled naturally.
Change-Id: I94ef67a03ed0e10da67a776af2b55506bf721611
BUG: 1034398
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6354
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
commit b12926521a1e42a71a5140b04887d740c23c004a
Author: Anand Avati <avati@redhat.com>
Date: Wed Nov 20 12:46:58 2013 -0800
cluster/dht: set layout in inode ctx even if linkfile fails
Creating linkfile could have failed, but we dont care about linkfile
for setting layout in the inode ctx (could be EEXIST etc.)
So ignore @inode in cbk and pick it up from local->loc.inode
Change-Id: I2952799d7ae0d3441b84b2ca2981afd75d7576e2
BUG: 1032859
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6319
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 18f3799446e7d1a915137168b9e92139afde16de
Author: Anand Avati <avati@redhat.com>
Date: Thu Nov 21 06:48:17 2013 -0800
core: fix errno for non-existent GFID
When clients refer to a GFID which does not exist, the errno to
be returned in ESTALE (and not ENOENT). Even though ENOENT might
look "proper" most of the time, as the application eventually expects
ENOENT even if a parent directory does not exist, not returning
ESTALE results in resolvers (FUSE and GFAPI) to not retry resolution
in uncached mode. This can result in spurious ENOENTs during
concurrent path modification operations.
Change-Id: I7a06ea6d6a191739f2e9c6e333a1969615e05936
BUG: 1032894
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6318
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@gmail.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0e0746bb805dc2a523f981faecec3435a69b0950
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Nov 26 17:37:24 2013 +0530
features/quota: Add TODO file.
Change-Id: I31990f05ca1814d229026965b7675e3990a65678
BUG: 969461
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6360
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c31f37d8bc5639612bb9fe2bd625dc21969ea188
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Oct 31 06:35:47 2013 +0530
cluster/dht: instruct marker whenever it shouldn't do accounting
This is needed for two reasons:
* since dht-linkfiles are internal, they shouldn't be accounted.
* hardlink handling in marker is broken. link/unlink of hardlinks
present in same directory can break marker accounting. Hence, if src
and dst are in same directory in case of rename, dht - if it breaks
rename into link/unlink operations - should instruct marker to not to
do accounting.
Change-Id: I9c9f7384569f75a2792f6450ee7a5279bf751ae7
BUG: 1022995
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6203
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ccdb378ff3c564d29a572b5b9fedd3be6ae40816
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Oct 28 10:32:52 2013 +0530
features/marker-quota: exclude dht-linkfiles from being accounted.
Change-Id: I3239f5e8477664dcc04434e4d455ae447493a7ac
BUG: 1022995
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6153
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2bd61a70afc111ef9afa29a6d4e0b926af5cb6bb
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Nov 14 17:10:09 2013 +0530
core: add dht_is_linkfile helper procedure.
components other than distribute (like marker to exclude linkfiles
from being accounted) also need awareness of what constitutes a
linkfile. Hence its good to separate out this functionality into
core.
Change-Id: Ib944eeacc991bb1de464c9e73ee409fc7a689ff1
BUG: 1022995
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6152
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8521b00933687ec42ef78e9e279d7504ca84ba2d
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Fri Oct 4 13:37:38 2013 +0530
features/quota: make writes short when the entire write cannot fit into available space.
This patch aims to prevent creation of infinite zero byte sized files
due to amount of storage available before exceeding quota limit
being less than write sizes. Imagine x bytes of storage is available
before we exceed quota limit and quota enforcer is receiving writes of
size y and (y > x). In this scenario, if we run a shell script like:
# for i in $(seq 1 10); do dd if=/dev/zero of=$i bs=y count=1; done
Then, we would end up with 10 zero byte sized files, because we allow
only complete writes and all writes will fail because of lack of space.
However, creates succeed since a create itself will consume zero
bytes. In this pattern of creates and writes, size of volume would
never grow and x bytes of space will always be available and we can
end up with an infinite number of zero byte sized files.
Change-Id: Ice148d6a2207883e41759f7b0be73abaa3198b41
BUG: 1012216
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6035
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a23771b081a6d88d3c2dfb58820687d21e15987b
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Thu Nov 14 17:05:26 2013 +0530
cli/glusterd: Changes to quota command Quota feature re-work.
Following are the cli commands that are new/re-worked:
======================================================
volume quota <VOLNAME> {enable|disable|list [<path> ...]|remove <path>| default-soft-limit <percent>} |
volume quota <VOLNAME> {limit-usage <path> <size> [<percent>]} |
volume quota <VOLNAME> {alert-time|soft-timeout|hard-timeout} {<time>}
volume status [all | <VOLNAME> [nfs|shd|<BRICK>|quotad]] [detail|clients|mem|inode|fd|callpool]
volume statedump <VOLNAME> [nfs|quotad] [all|mem|iobuf|callpool|priv|fd|inode|history]
glusterd changes:
=================
* Quota limits are now set as extended attributes by glusterd from
the aux mount created by the cli.
* The gfids of the directories on which quota limits are set
for a given volume are stored in
/var/lib/glusterd/vols/<volname>/quota.conf file in binary format,
and whose cksum and version is stored in
/var/lib/glusterd/vols/<volname>/quota.cksum.
Original-author: Krutika Dhananjay <kdhananj@redhat.com>
Original-author: Krishnan Parthasarathi <kparthas@redhat.com>
BUG: 969461
Change-Id: If32bba36c67f9c2a30417af9c6389045b2b7c13b
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6003
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 991921a3c979aab33b05f47a1d6794c2b923b40d
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Sep 16 17:46:50 2013 +0530
features/quota: Improvements to quota
* Two stages of quota enforcement is done:
Soft and hard quota Upon reaching soft quota limit on the directory
it logs/alerts in the quota daemon log (ie DEFAULT_LOG_DIR/quotad.log)
and no more writes allowed after hard
quota limit. After reaching the soft-limit the daemon alerts the
user/admin repeatively for every 'alert-time', which is
configurable.
* Quota enforcer is moved to server-side.
It takes care of enforcing quota. Since enforcer doesn't have the
cluster view, it relies on another service called
quota-aggregator. Aggregator, on query can return the size of a
directory based on the cluster view.
Enforcer is always loaded in the server graph and is by passed if
the feature is not enabled.
Options specific to enforcer:
server-quota - Specifies whether the feature is on/off. It is used
to by pass the quota if turned off.
deem-statfs - If set to on, it takes quota limits into consideration
while estimating fs size. (df command). The algorithm followed is,
i. Adjust statvfs based on limit configured on root.
ii. If limit is set on the inode passed, use size/limits on that inode to
populate statvfs. Otherwise, use size/limits configured on root.
iii. Upon statvfs, update the ctx->size on the inode.
iv. Don't let DHT aggregate, instead take the maximum of the usages from the
subvols of the DHT, since each of it contains the complete information.
Enforcer also makes use of gfid-to-path conversion functionality to
work correctly when a client like nfs predominently relies on
nameless lookups.
* Quota Aggregator acts as a thin client to provide cluster view
Its a lightweight *gluster client* process with no mount point,
started upon enabling quota or restarting the volume. This is a
single process run on each brick, which can answer queries on all
volumes in the cluster. Its volfile stored in
GLUSTERD_DEFAULT_WORKING_DIR/quotad/quotad.vol.
Credits:
Raghavendra Bhat <rabhat@redhat.com>
Varun Shastry <vshastry@redhat.com>
Shishir Gowda <sgowda@redhat.com>
Kruthika Dhananjay <kdhananj@redhat.com>
Brian Foster <bfoster@redhat.com>
Krishnan Parthasarathi <kparthas@redhat.com>
Change-Id: Id1cb25b414951da34c665a55f77385d482e0f9de
BUG: 969461
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/5952
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4459c2b86905f99bd7b13e08b2af76b977716f68
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Sep 16 21:35:08 2013 +0530
features/marker: quota friendly changes
* handles renames on dht linkfiles correctly
* nameless lookup friendly changes. uses gfid-to-path conversion
functionality from storage/posix to build ancestry till root.
* log message cleanup.
* build inode contexts in readdirp
* Accounting still not correct with hardlinks.
Credits:
========
Vijay Bellur <vbellur@redhat.com>
Raghavendra Bhat <rabhat@redhat.com>
Change-Id: I415b6fbbc9691f5a38d9fd3c5d083a61e578bb81
BUG: 969461
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/5953
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 87b8a7c8af4649d4a23e50f218ca4fbcd38b9332
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Sep 16 17:50:25 2013 +0530
posix: placeholders for GFID to path conversion
what?
=====
The following is an attempt to generate the paths of a file when
only its gfid is known.
To find the path of a directory, the symlink handle to the
directory maintained in the ".glusterfs" backend directory is
read. The symlink handle is generated using the gfid of the
directory. It (handle) contains the directory's name and parent
gfid, which are used to recursively construct the absolute path as
seen by the user from the mount point.
A similar approach cannot be used for a regular file or a symbolic
link since its hardlink handle, generated using its gfid, doesn't
contain its parent gfid and basename. So xattrs are set to store
the parent gfids and the number of hardlinks to a file or a
symlink having the same parent gfid. When an user/application
requests for the paths of a regular file or a symlink with
multiple hardlinks, using the parent gfids stored in the xattrs,
the paths of the parent directories are generated as mentioned
earlier. The base names of the hardlinks (with the same parent
gfid) are determined by matching the actual backend inode numbers
of each entry in the parent directory with that of the hardlink
handle.
Xattr is set on a regular file, link, and symbolic link as
follows, Xattr name : trusted.pgfid.<pargfidstr> Xattr value :
<number of hardlinks to a regular file/symlink with the same
parentgfid>
If a regular file, hard link, symbolic link is created then an
xattr in the above format is set in the backend.
how to use?
===========
This functionality can be used through getxattr interface. Two
keys - glusterfs.ancestry.dentry and glusterfs.ancestry.path - enable
usage of this functionality. A successful getxattr will have the
result stored under same keys. Values will be,
glusterfs.ancestry.dentry:
--------------------------
A linked list of gf-dirent structures for all possible paths from
root to this gfid. If there are multiple paths, the linked-list
will be a series of paths one after another. Each path will be a
series of dentries representing all components of the path. This
key is primarily for internal usage within glusterfs.
glusterfs.ancestry.path:
------------------------
A string containing all possible paths from root to this gfid.
Multiple hardlinks of a file or a symlink are displayed as a colon
seperated list (this could interfere with path components
containing ':').
e.g. If there is a file "file1" in root directory with two hardlinks,
"/dir2/link2tofile1" and "/dir1/link1tofile1", then
[root@alpha gfsmntpt]# getfattr -n glusterfs.ancestry.path -e text
file1
glusterfs.ancestry.path="/file1:/dir2/link2tofile1:/dir1/link1tofile1"
Thanks Amar, Avati and Venky for the inputs.
Original Author: Ramana Raja <rraja@redhat.com>
BUG: 990028
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Change-Id: I0eaa9101e333e0c1f66ccefd9e95944dd4a27497
Reviewed-on: http://review.gluster.org/5951
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0528c91fb550a2be5cb66e332681887a8425f3da
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Nov 21 16:17:32 2013 +0530
cluster/afr: Provide HA for pathinfo getxattr
Problem:
afr_[f]getxattr_pathinfo_cbks fail the fop even when it succeeded on
one of the bricks. This can happen if the last response to pathinfo
[f]getxattr is a failure.
Fix:
Remember if any of the [f]getxattr_pathinfos are successful and send
that as the op_ret/op_errno value to the xlators above.
Note:
Winding fop to a client xlator that is not connected to server produces
an error log. Preventing that by not even winding fop when client xlator
is DOWN.
Change-Id: I846e8c47423ffcfa2eabffe8924534781a36841a
BUG: 1032927
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6332
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d6d2d947c078fcd4998633bb4dd2fdac270ff99e
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Thu Nov 21 17:13:58 2013 +0530
gNFS: More clean up for Gluster NFS
1) Fix the typo in NFS default ACL
The typo was introduced as part of the Fix to BZ 1009210 i.e.
http://review.gluster.org/5980. The user ACL xattr structure
was passed to default ACL xattr.
2) Clean up NFS code to avoid unnecessary SEGV in
rpcsvc_drc_reconfigure() which was not validating the
svc->drc. Add a routine rpcsvc_drc_deinit() to handle
the clean up of DRC specific data structures. For init(),
use rpcsvc_drc_init().
3) nfs_init_state() was returning wrong value even if the
registration with portmapper failed, causing the NFS
server process to hang around. As a result it used to
get SEGV during rpcsvc_drc_reconfigure().
4) Clean up memfactor usage across nfs.c nfs3.c.
Change-Id: I5cea26cb68dd8a822ec0ae104952f67fe63fa703
BUG: 1009210
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6329
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6a9c20c626867f9623585095c61c07c91c04d740
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Nov 12 20:27:35 2013 +0530
tests: add EXPECT_NOT macro
We needed this macro while writing test cases for quota. With quota,
a directory size is only guaranteed to be within some margin of quota
limit, but not an accurate number. With not knowing what size to
expect and EXPECT macro not complete enough to accept ranges of sizes,
we can atleast write test-cases with EXPECT_NOT macro. After copying
data to an empty file, it will be guaranteed the size will not be
zero. This is good enough for quota test cases.
Change-Id: I722ebd68044716a5eeaf0bd7e9aae61df8469017
BUG: 1022995
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/6253
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a08b7c432eba936ac8ef36b68f525d610da7a05e
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Fri Nov 22 01:37:33 2013 -0800
group-virt: To minimize 'split-brain' enable quorum under virt profile
Quorum as default is necessary when storing virtual machine images. It
would be necessary to enable both server and client quorum
Currently defaulted values are:
----------------
server-quorum-type=server
quorum-type=auto
----------------
Change-Id: Ic2adb5856ce3c2589476e872e988cae6eeb9b25e
BUG: 1032080
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6340
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ae9d06d38434c2e2ad553366d2805413e1bc0ae6
Author: Anand Avati <avati@redhat.com>
Date: Wed Nov 20 15:11:13 2013 -0800
fuse: revalidate group id cache on uid/gid change detection
- Remember the uid and gid of the pid at the time of caching
the group id list.
- Next time when referring to the cache confirm that uid and gid
of that pid has not changed since. If it has, treat it like
a timeout/cache miss.
- Solves group id caching issue caused when Samba runs on gluster
FUSE mount and changes the uid/gid on a per syscall basis.
Change-Id: I3382b037ff0b6d5eaaa36d9c898232543475aeda
BUG: 1032438
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6320
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 8fd2548dfa4e815c76be530b00fcaad48bedaadd
Author: Anand Avati <avati@redhat.com>
Date: Fri Oct 11 00:20:15 2013 -0700
syncops: expose @flags in syncop_rmdir()
Change-Id: I9b73c1db728e4cb3948fc118cceb292b21d48b96
BUG: 1021686
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6112
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8569b07ff0a3d4aed7239a8b08b0606f89e7c4d5
Author: Bala.FA <barumuga@redhat.com>
Date: Thu Nov 21 16:35:40 2013 +0530
cli: fix possible memory leaks
BUG: 955548
Change-Id: Iae410712e7e6d7a76cd537c77f1919e3b4cdf6bb
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/6328
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1c3c22f9f88da839b4c5a608057c9ded539fd5fd
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Nov 22 00:15:48 2013 +0530
Add description for git based installations.
Change-Id: I60e445539f255b3220f885bd790f800e4c1ea55a
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6333
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit cedba7c8b0cce41a2889cee537d20b47b3ad6aa7
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Nov 20 13:41:49 2013 -0500
libglusterfs: use correct check for linux falloc.h availability
We should check for HAVE_LINUX_FALLOC_H rather than HAVE_FALLOC_H
to determine whether to include linux/falloc.h.
Change-Id: I05eca4de2893a88d6b9cc5ebfce738708b9960d4
BUG: 1032378
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/6314
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit ca6b27e9a1ec3401fa6444341df2bed331132e6f
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Nov 18 17:38:03 2013 +0100
Build storage/posix xlator if fallocate() does not exists
If fallocate() does not exists, just return EOPNOTSUPP
BUG: 764655
Change-Id: I808114f733c88985519dc47fb7537e1ced1db077
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6289
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b3e596f33eb42d03fa40b69d150fd1a5791c24a4
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Fri Nov 15 14:19:11 2013 +0530
bd: Add Zerofill FOP support
BUG: 1028673
Change-Id: I9ba8e3e6cf2f888640b4d2a2eb934a27ff903c42
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/6290
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fc915d5827b17be985802516f5ef97c31c3d475d
Author: Anand Avati <avati@redhat.com>
Date: Tue Nov 19 23:45:32 2013 -0800
mount/fuse: handle --gid-timeout=0 properly
Fix the bug which was using the timeout value as a flag to indicate
if it was set (and hence would fail when timeout=0 would evaluate
as False)
Change-Id: Ie9a8f28d35603458cdac26c9a4e0343e7eda7344
BUG: 1032438
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6308
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 036f249b14b5baff028f198c8116b1e006776c53
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Wed Nov 20 11:40:10 2013 +0530
gNFS: Coverity fix for CID 1128906
Fix the Coverity issue introduced in RFE: NFS volume set/reset
commit i.e. http://review.gluster.org/6236
Change-Id: I817b9da03a3ce7f5511303faea0c50dfdad60ff4
BUG: 1027409
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6307
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1e1b03d924516c7dd4b41903f758868bee464ab7
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Nov 14 12:15:53 2013 +0530
glusterd: Start rebalance only where required
Gluster was starting rebalance processes on peers where it wasn't
required in two cases.
- For a normal rebalance command on a volume, rebalance processes were
started on all peers instead of just the peers which contain bricks of
the volume
- For rebalance process being restarted by a volume sync, caused by a
new peer being probed or a peer restarting, rebalance processes were
started on all peers, for both a normal rebalance and for remove-brick
needing rebalance.
This patch adds a new check before starting rebalance process in the
above two cases.
- For rebalance process required by a rebalance command, each peer will
check if it contains atleast one brick of the volume
- For rebalance process required by a remove-brick command, each peer
will check if it contains atleast one of the bricks being removed
Change-Id: I512da16994f0d5482889c3a009c46dc20a8a15bb
BUG: 1031887
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6301
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit de119504abbf7e03b7f3622abbf1a8893b09d8a2
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Nov 12 15:08:26 2013 +0530
cli: List only nodes which have rebalance started in rebalance status
Listing the nodes on which rebalance hasn't been started is just giving
out extraneous information.
Also, refactor the rebalance status printing code into a single function
and use it for both rebalance and remove-brick status.
BUG: 1031887
Change-Id: I47bd561347dfd6ef76c52a1587916d6a71eac369
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6300
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d3ad1b28bc414525911bad58c44a67bfc3e76d6e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Nov 19 15:38:57 2013 +0530
mgmt/glusterd: fix undefined sybmol error related to BD
Change-Id: I2210f1ac7de04c6025c0ec02d998b626d41466ae
BUG: 1028672
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6303
Reviewed-by: M. Mohan Kumar <mohan@in.ibm.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2d22c17cd3bde6bdacc2fc70f0116f2fa3297d3b
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Nov 17 15:23:41 2013 +0100
Do not build fallocate FUSE FOP if the system call does not exist
BUG: 764655
Change-Id: Ica310e75bee16741b837e658981238c1b99c254f
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6288
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e65b10f31d0b56b730ec96db451977166fcb5259
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Nov 17 01:51:48 2013 +0100
Python build flag detection
Ask python-config for proper python build flags
BUG: 764655
Change-Id: I7aede0f93637c61dbafc43580bff46af60f0f0d3
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6283
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6167db83afa03374f1565f525128bdac1b2c36c6
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Nov 17 15:05:42 2013 +0100
NetBSD missing backtrace(3) portability fix
Implement backtrace(3) and backtrace_symbols(3) which do not exist in NetBSD
While there, remove duplicate #include <stdio.h>
BUG: 764655
Change-Id: Iccd695765906e085c3f8fcb670506d4fea68fa39
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6285
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 174a58e14cc6f5ae74fb1d8095f98b5c6f59ce3e
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Nov 17 05:37:01 2013 +0100
Search gettext() in -lintl
If gettext() is not found in libc, look it up in libintl (this is where
NetBSD has it)
BUG: 764655
Change-Id: Ifba8681b8603ead5d0b8587b71457250982077e1
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6287
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2b38e5bb0617809566830e98a0b76386333f4f90
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Nov 19 13:57:30 2013 +0100
autogen.sh portability fixes
- Do not assume tar has --version, as BSD tar does not
- Allow specifying python binary through PYTHONBIN in case it is e.g. python2.7
BUG: 764655
Change-Id: I71f0f4830e10915782775de811c92db8e6ab4c55
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6281
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 2db53e7a920072f160c9658fb2bfe949ee8d0266
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Mon Nov 18 12:49:21 2013 +0530
Fix xml compilation error
Compiling GlusterFS without xml package results in following build error
cli-rpc-ops.o: In function `gf_cli_status_cbk':
/home/mohan/Work/glusterfs/cli/src/cli-rpc-ops.c:6430: undefined
reference to `cli_xml_output_vol_status_tasks_detail'
Change-Id: I49b3c46ac3340c40e372bef4690cedb41df20e8a
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/6295
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4c47fd15489fefdd441be7ca54b27a9f0cf6e555
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Fri Nov 15 18:23:29 2013 +0530
BD fixes for coverity scan
BUG: 1028672
Change-Id: I2e7889fb113cedd2d5928b210149d3fd7b8b22ab
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/6292
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 88a19a7dff785a80fdeaba4e8e8416c44d6976e1
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Fri Nov 15 17:50:34 2013 +0530
Fixes for ZF reported by coverity
BUG: 1028673
Change-Id: I7c75738cca22c81c5629d579ef5bea24000e622e
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/6291
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 71670937977126910fb97ef5dd25c6c2d7b4f6cd
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Nov 17 02:03:03 2013 +0100
Have #include <signal.h> for kill(2)
BUG: 764655
Change-Id: I4d18c9a6c00cb4696645fcb437398562f00b9d24
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6284
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ae4b8c3a6532cf59155f1194c3ccde2c61a1b88a
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Nov 17 02:17:59 2013 +0100
NetBSD missing loff_t portability fix
define loff_t as off_t, is is already long long anyway.
BUG: 764655
Change-Id: I99edda9b804475a8696c2d32ccf8eae152851e21
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6286
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 647679db8264b1938bae239f6c567be17efee11a
Author: Bala.FA <barumuga@redhat.com>
Date: Tue Oct 29 17:17:12 2013 +0530
cli: add peerid to volume status xml output
This patch adds <peerid> tag to bricks and nfs/shd like services to
volume status xml output.
BUG: 955548
Change-Id: I9aaa9266e4d56f632235eaeef565e92d757c0694
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/6162
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 7530b891b6a37ad9fa311d46414ecdb01acf2b1c
Author: Bharata B Rao <bharata@linux.vnet.ibm.com>
Date: Fri Nov 15 10:11:58 2013 +0530
zerofill: Change the type of len argument of glfs_zerofill() to off_t
glfs_zerofill() can be potentially called to zero-out entire file and
hence allow for bigger value of length parameter.
Change-Id: I75f1d11af298915049a3f3a7cb3890a2d72fca63
BUG: 1028673
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Reviewed-on: http://review.gluster.org/6266
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: M. Mohan Kumar <mohan@in.ibm.com>
Tested-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7216ce3d87a2ff853f99b81ea784c911b1123afd
Author: Vijaykumar M <vmallika@redhat.com>
Date: Thu Nov 14 13:12:09 2013 +0530
fuse: Check the return status from state->resolve_now
Change-Id: I85fc6dd393449d365bb908b38c2827b58cb08171
BUG: 1030208
Signed-off-by: Vijaykumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6262
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2cd39fb0d5c38acc50a6a500bd1dcf895d1fff49
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Mon Oct 28 12:46:37 2013 +0530
gNFS: RFE for NFS connection behavior
Implement reconfigure() for NFS xlator so that volume set/reset wont
restart the NFS server process. But few options can not be reconfigured
dynamically e.g. nfs.mem-factor, nfs.port etc which needs NFS to be
restarted.
Change-Id: Ic586fd55b7933c0a3175708d8c41ed0475d74a1c
BUG: 1027409
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6236
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 91d804d88739587f1e73e0451915919c7b15fca5
Author: Poornima <pgurusid@redhat.com>
Date: Thu Nov 14 01:29:30 2013 +0000
gfapi: Closed the logfile fd in glfs_fini
The logfile fd is not closed even after calling glfs_fini,
hence in smb mount if connection to glusterfs volume fails
at a point after the log file was opened, the fd would remain
open until the process dies.
This patch closes the logfile fd in glfs_fini.
Change-Id: I608bfac9c6833b42750b0383ad26fd33ee378ee1
BUG: 1030228
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6263
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1f6b7578c1e32fcfe6521f6a68f247696b345143
Author: Edward Shishkin <edward@redhat.com>
Date: Wed Mar 13 21:56:46 2013 +0100
Transparent data encryption and metadata authentication
.. in the systems with non-trusted server
This new functionality can be useful in various cloud technologies.
It is implemented via a special encryption/crypt translator,which
works on the client side and performs encryption and authentication;
1. Class of supported algorithms
The crypt translator can support any atomic symmetric block cipher
algorithms (which require to pad plain/cipher text before performing
encryption/decryption transform (see glossary in atom.c for
definitions). In particular, it can support algorithms with the EOF
issue (which require to pad the end of file by extra-data).
Crypt translator performs translations
user -> (offset, size) -> (aligned-offset, padded-size) ->server
(and backward), and resolves individual FOPs (write(), truncate(),
etc) to read-modify-write sequences.
A volume can contain files encrypted by different algorithms of the
mentioned class. To change some option value just reconfigure the
volume.
Currently only one algorithm is supported: AES_XTS.
Example of algorithms, which can not be supported by the crypt
translator:
1. Asymmetric block cipher algorithms, which inflate data, e.g. RSA;
2. Symmetric block cipher algorithms with inline MACs for data
authentication.
2. Implementation notes.
a) Atomic algorithms
Since any process in a stackable file system manipulates with local
data (which can be obsoleted by local data of another process), any
atomic cipher algorithm without proper support can lead to non-POSIX
behavior. To resolve the "collisions" we introduce locks: before
performing FOP->read(), FOP->write(), etc. the process should first
lock the file.
b) Algorithms with EOF issue
Such algorithms require to pad the end of file with some extra-data.
Without proper support this will result in losing information about
real file size. Keeping a track of real file size is a responsibility
of the crypt translator. A special extended attribute with the name
"trusted.glusterfs.crypt.att.size" is used for this purpose. All files
contained in bricks of encrypted volume do have "padded" sizes.
3. Non-trusted servers and
Metadata authentication
We assume that server, where user's data is stored on is non-trusted.
It means that the server can be subjected to various attacks directed
to reveal user's encrypted personal data. We provide protection
against such attacks.
Every encrypted file has specific private attributes (cipher algorithm
id, atom size, etc), which are packed to a string (so-called "format
string") and stored as a special extended attribute with the name
"trusted.glusterfs.crypt.att.cfmt". We protect the string from
tampering. This protection is mandatory, hardcoded and is always on.
Without such protection various attacks (based on extending the scope
of per-file secret keys) are possible.
Our authentication method has been developed in tight collaboration
with Red Hat security team and is implemented as "metadata loader of
version 1" (see file metadata.c). This method is NIST-compliant and is
based on checking 8-byte per-hardlink MACs created(updated) by
FOP->create(), FOP->link(), FOP->unlink(), FOP->rename() by the
following unique entities:
. file (hardlink) name;
. verified file's object id (gfid).
Every time, before manipulating with a file, we check it's MACs at
FOP->open() time. Some FOPs don't require a file to be opened (e.g.
FOP->truncate()). In such cases the crypt translator opens the file
mandatory.
4. Generating keys
Unique per-file keys are derived by NIST-compliant methods from the
a) parent key;
b) unique verified object-id of the file (gfid);
Per-volume master key, provided by user at mount time is in the root
of this "tree of keys".
Those keys are used to:
1) encrypt/decrypt file data;
2) encrypt/decrypt file metadata;
3) create per-file and per-link MACs for metadata authentication.
5. Instructions
Getting started with crypt translator
Example:
1) Create a volume "myvol" and enable encryption:
# gluster volume create myvol pepelac:/vols/xvol
# gluster volume set myvol encryption on
2) Set location (absolute pathname) of your master key:
# gluster volume set myvol encryption.master-key /home/me/mykey
3) Set other options to override default options, if needed.
Start the volume.
4) On the client side make sure that the file /home/me/mykey exists
and contains proper per-volume master key (that is 256-bit AES
key). This key has to be in hex form, i.e. should be represented
by 64 symbols from the set {'0', ..., '9', 'a', ..., 'f'}.
The key should start at the beginning of the file. All symbols at
offsets >= 64 are ignored.
5) Mount the volume "myvol" on the client side:
# glusterfs --volfile-server=pepelac --volfile-id=myvol /mnt
After successful mount the file which contains master key may be
removed. NOTE: Keeping the master key between mount sessions is in
user's competence.
**********************************************************************
WARNING! Losing the master key will make content of all regular files
inaccessible. Mount with improper master key allows to access content
of directories: file names are not encrypted.
**********************************************************************
6. Options of crypt translator
1) "master-key": specifies location (absolute pathname) of the file
which contains per-volume master key. There is no default location
for master key.
2) "data-key-size": specifies size of per-file key for data encryption
Possible values:
. "256" default value
. "512"
3) "block-size": specifies atom size. Possible values:
. "512"
. "1024"
. "2048"
. "4096" default value;
7. Test cases
Any workload, which involves the following file operations:
->create();
->open();
->readv();
->writev();
->truncate();
->ftruncate();
->link();
->unlink();
->rename();
->readdirp().
8. TODOs:
1) Currently size of IOs issued by crypt translator is restricted
by block_size (4K by default). We can use larger IOs to improve
performance.
Change-Id: I2601fe95c5c4dc5b22308a53d0cbdc071d5e5cee
BUG: 1030058
Signed-off-by: Edward Shishkin <edward@redhat.com>
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4667
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b76e0c2493f5a47f79b6f7819ca53d533a71d897
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Sep 10 15:13:54 2013 +0530
cluster/dht - rebalance: handle the rebalance @ inode level (!fd level)
* migrate all the fd's on an inode to newer subvol after rebalance
* use the migration in progress flag in inode, so all the operations
on the inode can make use of it
Change-Id: Ib807a46e927a1062688fc15119c916797c52a350
BUG: 1013456
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5891
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b7a0222f9ae1254a9f1ab4a39c07ed57176378de
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Sep 10 17:40:04 2013 +0530
libglusterfs/inode: introduce new APIs for ctx handling
* inode_ctx_reset{0,1,2}() for reseting value1, value2, and both respectively
* inode_ctx_get0() - to get the first value only
* inode_ctx_set0() - to set the first value only
* inode_ctx_get1() - to get the second value only
* inode_ctx_set1() - to set the second value only
Change-Id: I4dfbdac81d6a3f4e5784e060c76edabb1692ce03
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5890
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 1fac84ac9da5262a9c1288b75dbd51acb55efe2b
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Wed Nov 13 22:44:43 2013 +0530
bd: Add test case for bd xlator
Change-Id: I73a0bfa7085d2e71b2489687fa53f5fe7d1e8ea1
BUG: 1028672
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/6050
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d1ab915f18340a8f40c211ffb4348f5ba1c5a2bb
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Wed Nov 13 22:44:43 2013 +0530
bd: Add support to create clone, snapshot and merge of LV images.
Special xattr names "clone" & "snapshot" can be used to create full and
linked clone of the LV images. GFID of destination posix file (to be
mapped) is passed as a value to the xattr. Destination posix file must
exist before running this operation.
These operations form a basis for offloading storage related operations
from QEMU to GlusterFS.
Syntax for full clone: xattr name: "clone" value: "gfid-of-dest-file"
Syntax for linked clone: xattr name: "snapshot" value: "gfid-of-dest-file"
Syntax for merging: xattr name: "merge" value: "path-to-snapshot-file"
Example:
setfattr -n clone -v <gfid-of-dest-file> /media/source
setfattr -n snapshot -v <gfid-of-dest-file> /media/source
setfattr -n merge -v "/media/sn" /media/sn
Change-Id: Id9f984a709d4c2e52a64ae75bb12a8ecb01f8776
BUG: 1028672
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/5626
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fc49dd0843ca9e4f25a4b0628dabbc58da41ccf2
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Wed Nov 13 22:44:42 2013 +0530
bd: Add aio support to BD xlator
Volume option bd-aio controls AIO feature for BD xlator. Code taken from
posix-aio.c
Change-Id: Ib049bd59c9d3f9101d33939838322cfa808de053
BUG: 1028672
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/5748
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit eeb4119050416713117d42fdbc16a32f4c84bd27
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Wed Nov 13 22:44:42 2013 +0530
bd: Add BD support to other xlators
Make changes to distributed xlator to work with BD xlator. Unlike files,
a block device can't be removed when its opened. So some part of the
code were moved down to avoid this situation. Also before truncating a
BD file its BD_XATTR should be set otherwise truncate will result in
truncating posix file. So file is created with needed BD_XATTR and
truncate is invoked. Also enables BD xlator in stripe volume type.
Change-Id: If127516e261fac5fc5b137e7fe33e100bc92acc0
BUG: 1028672
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/5235
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3c65e1b70392b6ab94b6cfab1b250125afbefc81
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Wed Nov 13 22:44:42 2013 +0530
bd: posix/multi-brick support to BD xlator
Current BD xlator (block backend) has a few limitations such as
* Creation of directories not supported
* Supports only single brick
* Does not use extended attributes (and client gfid) like posix xlator
* Creation of special files (symbolic links, device nodes etc) not
supported
Basic limitation of not allowing directory creation is blocking
oVirt/VDSM to consume BD xlator as part of Gluster domain since VDSM
creates multi-level directories when GlusterFS is used as storage
backend for storing VM images.
To overcome these limitations a new BD xlator with following
improvements is suggested.
* New hybrid BD xlator that handles both regular files and block device
files
* The volume will have both POSIX and BD bricks. Regular files are
created on POSIX bricks, block devices are created on the BD brick (VG)
* BD xlator leverages exiting POSIX xlator for most POSIX calls and
hence sits above the POSIX xlator
* Block device file is differentiated from regular file by an extended
attribute
* The xattr 'user.glusterfs.bd' (BD_XATTR) plays a role in mapping a
posix file to Logical Volume (LV).
* When a client sends a request to set BD_XATTR on a posix file, a new
LV is created and mapped to posix file. So every block device will
have a representative file in POSIX brick with 'user.glusterfs.bd'
(BD_XATTR) set.
* Here after all operations on this file results in LV related
operations.
For example opening a file that has BD_XATTR set results in opening
the LV block device, reading results in reading the corresponding LV
block device.
When BD xlator gets request to set BD_XATTR via setxattr call, it
creates a LV and information about this LV is placed in the xattr of the
posix file. xattr "user.glusterfs.bd" used to identify that posix file
is mapped to BD.
Usage:
Server side:
[root@host1 ~]# gluster volume create bdvol host1:/storage/vg1_info?vg1 host2:/storage/vg2_info?vg2
It creates a distributed gluster volume 'bdvol' with Volume Group vg1
using posix brick /storage/vg1_info in host1 and Volume Group vg2 using
/storage/vg2_info in host2.
[root@host1 ~]# gluster volume start bdvol
Client side:
[root@node ~]# mount -t glusterfs host1:/bdvol /media
[root@node ~]# touch /media/posix
It creates regular posix file 'posix' in either host1:/vg1 or host2:/vg2 brick
[root@node ~]# mkdir /media/image
[root@node ~]# touch /media/image/lv1
It also creates regular posix file 'lv1' in either host1:/vg1 or
host2:/vg2 brick
[root@node ~]# setfattr -n "user.glusterfs.bd" -v "lv" /media/image/lv1
[root@node ~]#
Above setxattr results in creating a new LV in corresponding brick's VG
and it sets 'user.glusterfs.bd' with value 'lv:<default-extent-size'
[root@node ~]# truncate -s5G /media/image/lv1
It results in resizig LV 'lv1'to 5G
New BD xlator code is placed in xlators/storage/bd directory.
Also add volume-uuid to the VG so that same VG can't be used for other
bricks/volumes. After deleting a gluster volume, one has to manually
remove the associated tag using vgchange <vg-name> --deltag
<trusted.glusterfs.volume-id:<volume-id>>
Changes from previous version V5:
* Removed support for delayed deleting of LVs
Changes from previous version V4:
* Consolidated the patches
* Removed usage of BD_XATTR_SIZE and consolidated it in BD_XATTR.
Changes from previous version V3:
* Added support in FUSE to support full/linked clone
* Added support to merge snapshots and provide information about origin
* bd_map xlator removed
* iatt structure used in inode_ctx. iatt is cached and updated during
fsync/flush
* aio support
* Type and capabilities of volume are exported through getxattr
Changes from version 2:
* Used inode_context for caching BD size and to check if loc/fd is BD or
not.
* Added GlusterFS server offloaded copy and snapshot through setfattr
FOP. As part of this libgfapi is modified.
* BD xlator supports stripe
* During unlinking if a LV file is already opened, its added to delete
list and bd_del_thread tries to delete from this list when a last
reference to that file is closed.
Changes from previous version:
* gfid is used as name of LV
* ? is used to specify VG name for creating BD volume in volume
create, add-brick. gluster volume create volname host:/path?vg
* open-behind issue is fixed
* A replicate brick can be added dynamically and LVs from source brick
are replicated to destination brick
* A distribute brick can be added dynamically and rebalance operation
distributes existing LVs/files to the new brick
* Thin provisioning support added.
* bd_map xlator support retained
* setfattr -n user.glusterfs.bd -v "lv" creates a regular LV and
setfattr -n user.glusterfs.bd -v "thin" creates thin LV
* Capability and backend information added to gluster volume info (and
--xml) so
that management tools can exploit BD xlator.
* tracing support for bd xlator added
TODO:
* Add support to display snapshots for a given LV
* Display posix filename for list-origin instead of gfid
Change-Id: I00d32dfbab3b7c806e0841515c86c3aa519332f2
BUG: 1028672
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/4809
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4bf4c00f9431cf68cb8cb4aa52106a3a867e0567
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Wed Nov 13 22:44:42 2013 +0530
bd_map: Remove bd_map xlator
Remove bd_map xlator and CLI related changes.
Change-Id: If7086205df1907127c1a1fa4ba603f1c48421d09
BUG: 1028672
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/5747
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4d3e3d02558ad99677dcffc4dba113cc7914d2b6
Author: Anand Avati <avati@redhat.com>
Date: Wed Oct 30 14:30:26 2013 -0700
gfapi: introduce glfs_readdir() and glfs_readdirplus() APIs
Change-Id: I6b233bf647585675f233898351bf593f251716cc
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6201
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 52052a07cfb16b438e606bb1fc69edf2c9679fc2
Author: Vikhyat Umrao <vumrao@redhat.com>
Date: Tue Nov 12 18:11:23 2013 +0530
server/rpc: bricks goes offline and comes back online, with lots of "No such file or directory" log messages
Problem:
Messages were getting logged very frequently at log level INFO.
[2013-03-01 11:34:28.029222] I [server3_1-fops.c:1541:server_open_cbk] vol-server: 993888: OPEN (null) (--) ==> -1 (No such file or directory)
[2013-03-01 11:34:28.031579] I [server3_1-fops.c:252:server_inodelk_cbk] vol-server: 993896: INODELK (null) (--) ==> -1 (No such file or directory)
[2013-03-01 11:34:28.034041] I [server3_1-fops.c:252:server_inodelk_cbk] vol-server: 993914: INODELK (null) (--) ==> -1 (No such file or directory)
[2013-03-01 11:34:28.040435] I [server3_1-fops.c:1338:server_flush_cbk] vol-server: 993938: FLUSH -2 (--) ==> -1 (No such file or directory)
Solution:
Moved them to DEBUG log level if error number equlas to ENOENT else to ERROR log level.
It will help in decreasing the size of log files at INFO log level.
For server_open_cbk and for some other functions we already have a patch, below is the URL for it.
URL- http://review.gluster.org/6241
This patch solves logging problem for functions server_inodelk_cbk and server_flush_cbk.
Change-Id: I57372e851371e466f1674726015e28378b826f5f
BUG: 1029372
Signed-off-by: Vikhyat Umrao<vumrao@redhat.com>
Reviewed-on: http://review.gluster.org/6252
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1d855b4a34bec30b57a4ed99a89ea429cc76b787
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Wed Nov 13 10:45:40 2013 +0530
zerofill: Update API version version 6 adds zerofill FOP
BUG: 1028673
Change-Id: I27cfc48cd6f7f0f6daf94e1c9cfbe420a0d090af
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/6255
Reviewed-by: Bharata B Rao <bharata.rao@gmail.com>
Tested-by: Bharata B Rao <bharata.rao@gmail.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 56ef28a74364d7f077271338d105513e56b66ddb
Author: Prashanth Pai <ppai@redhat.com>
Date: Mon Mar 26 14:33:41 2012 +0530
features/compress: Compression/DeCompression translator
* When a writev call occurs, the client compresses the data before
sending it to server. On the server, compressed data is decompressed.
Similarly, when a readv call occurs, the server compresses the data
before sending it to client. On the client, the compressed data is
decompressed. Thus the amount of data sent over the wire is minimized.
* Compression/Decompression is done using Zlib library.
* During normal operation, this is the format of data sent over wire :
<compressed-data> + trailer(8)
The trailer contains the CRC32 checksum and length of original
uncompressed data. This is used for validation.
HOW TO USE
----------
Turning on compression xlator:
gluster volume set <vol_name> compress on
Configurable options:
gluster volume set <vol_name> compress.compression-level 8
gluster volume set <vol_name> compress.min-size 50
Change-Id: Ib7a66b6f1f70fe002b7c513588cdf75c69370805
BUG: 923540
Original-author : Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Prashanth Pai <nullpai@gmail.com>
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Reviewed-on: http://review.gluster.org/3251
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 42cab1c1b37d87a5df6545a89b93c8ce056032a4
Author: Vijaykumar M <vmallika@redhat.com>
Date: Mon Nov 11 12:05:55 2013 +0530
cli: Set the o/p width of hostname to 8 characters
Change-Id: I91dcb19ba4d31c17e6041155c0e59af457b87f1b
BUG: 1028871
Signed-off-by: Vijaykumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/6245
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9da0113001c136a72572ccf9bceffb23780334ca
Author: Vikhyat Umrao <vumrao@redhat.com>
Date: Mon Nov 11 14:52:54 2013 +0530
server/rpc: Numerous entries of error - "No such file or directory" in bricks log
Problem:
Messages were getting logged very frequently at log level INFO.
One of the log file snippet -
[2013-10-27 00:05:01.501355] I [server3_1-fops.c:1707:server_stat_cbk] 0-vol-server: 24846575: STAT (null) (--) ==> -1 (No such file or directory)
[2013-10-27 00:05:01.505101] I [server3_1-fops.c:1707:server_stat_cbk] 0-vol-server: 24846577: STAT (null) (--) ==> -1 (No such file or directory)
[2013-10-27 00:05:01.507299] I [server3_1-fops.c:1707:server_stat_cbk] 0-vol-server: 24846578: STAT (null) (--) ==> -1 (No such file or directory)
[2013-10-20 19:50:35.554563] I [server3_1-fops.c:1538:server_open_cbk] 0-vol-server: 18714687: OPEN <gfid:01c70ca0-1952-4e82-abee-a07205757d8e>
(01c70ca0-1952-4e82-abee-a07205757d8e) ==> -1 (No such file or directory)
[2013-10-20 19:50:35.555520] I [server3_1-fops.c:1538:server_open_cbk] 0-vol-server: 18714697: OPEN <gfid:01c70ca0-1952-4e82-abee-a07205757d8e>
(01c70ca0-1952-4e82-abee-a07205757d8e) ==> -1 (No such file or directory)
[2013-10-20 19:50:35.558292] I [server3_1-fops.c:1538:server_open_cbk] 0-vol-server: 18714712: OPEN (null) (--) ==> -1 (No such file or directory)
Solution:
Moved them to DEBUG log level if error number equlas to ENOENT else to ERROR log level.
It will help in decreasing the size of log files at INFO log level.
Change-Id: I23d74320c9c21bbce4805c20295556cc2cc0a8d8
BUG: 808073
Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
Reviewed-on: http://review.gluster.org/6241
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 40711547ff2179c9565843e17838724b3da9d4f2
Author: Dawit Alemu <dalemu@redhat.com>
Date: Fri Nov 8 13:26:52 2013 -0500
cli: write 'volume rebalance' error message in xml format when --xml is specified
When 'volume rebalance' encounters an error the cli prints the
error message in plain text independent of whether --xml is
specified. This throws off client application that expect xml
output (as mentioned in bz1026143).
Now, if the --xml flag is supplied, the cli print 'volume
rebalance' error messages in xml format.
Change-Id: I16c6a7a4cdd2819eb73422ab849125986dc299a6
BUG: 1026143
Signed-off-by: Dawit Alemu <dalemu@redhat.com>
Reviewed-on: http://review.gluster.org/6242
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3c84257a94526c0a006ce183b4906d84074513ef
Author: Brian Foster <bfoster@redhat.com>
Date: Fri Oct 18 07:36:38 2013 -0400
features/qemu-block: simplify coroutine model to use single synctask, ucontext
The current coroutine model, mapping synctasks 1-1 with qemu internal
Coroutines, has some unresolved raciness issues. This problem usually
manifests as lifecycle mismatches between top-level (gluster created)
synctasks and the subsequently created internal coroutines from that
context. Qemu's internal queueing (and locking) can cause situations
where the top-level synctask is destroyed before the internal scheduler
has released references to memory, leading to use after free crashes
and asserts.
Simplify the coroutine model to use a single synctask as a coroutine
processor and rely on the existing native ucontext coroutine
implementation. The syncenv thread is donated to qemu and ensures a
single top-level coroutine is processed at a time. Qemu now has
complete control over coroutine scheduling.
BUG: 986775
Change-Id: I38223479a608d80353128e390f243933fc946fd6
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/6110
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4ef344e149a823fd91f55c75a3ed155b0df383f0
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Sep 18 07:03:07 2013 -0400
features/qemu-block: add qemu backing image support (clone)
Add basic backing image support to the block-format mechanism. This
is a functionality checkpoint that enables the raw mechanism
required to support client driven "snapshot" and "clone" requests.
This change enhances the block-format setxattr command to support
an additional and optional backing image reference. For example:
setxattr -n trusted.glusterfs.block-format -v "qcow2:10GB:<bimg>" ./newimage
... where <bimg> refers to the backing image for unallocated blocks
in newimage. <bimg> can be provided in one of two formats:
- a gfid string in the following format (assuming a valid gfid):
<gfid:00000000-0000-0000-0000-000000000000>
- or a filename that must be resident in the same directory as the
new clone file being formatted. E.g.,
setxattr -n trusted.glusterfs.block-format -v "qcow2:10GB:baseimg" ./newimage
This latter format is more restrictive, simply provided for
convenience or until something more refined is available.
This change makes no assumptions about the backing image file and
affords no additional protection. It is up to the user/client to
recognize the relationship between the files and manage them
appropriately (i.e., no writes to the backing image, etc.).
BUG: 986775
Change-Id: I7aff7bdc59b85a6459001a6bfeae4db6bf74f703
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5967
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0794235f27253a2f76471a317b26843aaec243d7
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Sat Nov 9 14:51:53 2013 +0530
glusterfs: zerofill support
Add support for a new ZEROFILL fop. Zerofill writes zeroes to a file in
the specified range. This fop will be useful when a whole file needs to
be initialized with zero (could be useful for zero filled VM disk image
provisioning or during scrubbing of VM disk images).
Client/application can issue this FOP for zeroing out. Gluster server
will zero out required range of bytes ie server offloaded zeroing. In
the absence of this fop, client/application has to repetitively issue
write (zero) fop to the server, which is very inefficient method because
of the overheads involved in RPC calls and acknowledgements.
WRITESAME is a SCSI T10 command that takes a block of data as input and
writes the same data to other blocks and this write is handled
completely within the storage and hence is known as offload . Linux ,now
has support for SCSI WRITESAME command which is exposed to the user in
the form of BLKZEROOUT ioctl. BD Xlator can exploit BLKZEROOUT ioctl to
implement this fop. Thus zeroing out operations can be completely
offloaded to the storage device , making it highly efficient.
The fop takes two arguments offset and size. It zeroes out 'size' number
of bytes in an opened file starting from 'offset' position.
This patch adds zerofill support to the following areas:
- libglusterfs
- io-stats
- performance/md-cache,open-behind
- quota
- cluster/afr,dht,stripe
- rpc/xdr
- protocol/client,server
- io-threads
- marker
- storage/posix
- libgfapi
Client applications can exloit this fop by using glfs_zerofill introduced in
libgfapi.FUSE support to this fop has not been added as there is no system call
for this fop.
Changes from previous version 3:
* Removed redundant memory failure log messages
Changes from previous version 2:
* Rebased and fixed build error
Changes from previous version 1:
* Rebased for latest master
TODO :
* Add zerofill support to trace xlator
* Expose zerofill capability as part of gluster volume info
Here is a performance comparison of server offloaded zeofill vs zeroing
out using repeated writes.
[root@llmvm02 remote]# time ./offloaded aakash-test log 20
real 3m34.155s
user 0m0.018s
sys 0m0.040s
[root@llmvm02 remote]# time ./manually aakash-test log 20
real 4m23.043s
user 0m2.197s
sys 0m14.457s
[root@llmvm02 remote]# time ./offloaded aakash-test log 25;
real 4m28.363s
user 0m0.021s
sys 0m0.025s
[root@llmvm02 remote]# time ./manually aakash-test log 25
real 5m34.278s
user 0m2.957s
sys 0m18.808s
The argument log is a file which we want to set for logging purpose and
the third argument is size in GB .
As we can see there is a performance improvement of around 20% with this
fop.
Change-Id: I081159f5f7edde0ddb78169fb4c21c776ec91a18
BUG: 1028673
Signed-off-by: Aakash Lal Das <aakash@linux.vnet.ibm.com>
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/5327
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5c5e62ec428400f367b0e1cddc4e57f53fd7fc27
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sat Nov 9 11:56:34 2013 +0000
libglusterfs: fix bug in timespec adjustment
The argument to the timespec_adjust_delta() function introudced in
commit 6836118b21 needs to be passed by reference rather than by value
for the function to do it's job.
BUG: 1028663
Change-Id: I62a3636906e67ed35b7786e9553f6819b48f3626
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/6243
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 74aa3e6676df0ce77e3cebf7ceaa53709850d68d
Author: Anand Avati <avati@redhat.com>
Date: Mon Oct 21 20:29:07 2013 -0700
gfapi: remove unnecessary call to glfs_resolve_base()
Calling glfs_resolve_base() on the root inode for every resolver
invocation is unnecessary and wasteful.
Here are the results from running a test program which performs
path based operations (creates and deletes 1000 files):
Without patch:
[root@blackbox ~]# sync
[root@blackbox ~]# time ./a.out 1
real 0m4.314s
user 0m1.923s
sys 0m1.144s
[root@blackbox ~]# sync
[root@blackbox ~]# time ./a.out 1
real 0m4.383s
user 0m1.940s
sys 0m1.177s
[root@blackbox ~]# sync
[root@blackbox ~]# time ./a.out 1
real 0m4.339s
user 0m1.863s
sys 0m1.129s
With patch:
[root@blackbox ~]# sync
[root@blackbox ~]# time ./a.out 1
real 0m3.005s
user 0m1.162s
sys 0m0.816s
[root@blackbox ~]# sync
[root@blackbox ~]# time ./a.out 1
real 0m3.188s
user 0m1.222s
sys 0m0.867s
[root@blackbox ~]# sync
[root@blackbox ~]# time ./a.out 1
real 0m2.999s
user 0m1.131s
sys 0m0.832s
Change-Id: Id160a24f44b4dccfcfce99a6f69ddb8938523cd5
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6131
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9757ad0e625510933a3539cdd49d115683823859
Author: ravishankar@redhat.com <ravishankar@redhat.com>
Date: Wed Nov 6 18:40:25 2013 +0530
glusterd: modify remove-brick CLI message.
In the current context "replica_cnt" is used just to know whether the
specific key exists or not by calling "dict_get_int32", which we can
replace by "dict_get ()". And changing the log message as it is more
appropriate to say "migration of data" rather than "rebalance".
This patch refactors commit 51c6fa7a354826744de98 against BZ 961669
reviewed on : http://review.gluster.org/5566
Change-Id: I48eae206a28d4083975e64407ed8fe4539f9c24b
BUG: 1027270
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Original patch: Susant Palai <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/6001
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: susant palai <spalai@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6cebe60c12519f1361fb6b3b5383e8f9b70f7472
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Nov 6 17:25:22 2013 +0530
posix: Fix excessive logging resulting from get_real_filename failure from samba
Change-Id: I641d028165da7b8501bd372c62d2df89a9d4db1f
BUG: 1027174
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/6237
Reviewed-by: poornima g <pgurusid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5fd8d8bc131343b9382e82c12e74975e77b10774
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Fri Sep 20 16:58:47 2013 +0530
gNFS: NFS segfaults with nfstest_posix tool
Problem:
nfs3_stat_to_fattr3() missed a NULL check.
FIX:
(1) Added a NULL check.
(2) In all fop cbk path, if the op_ret is -1 and op_errno is 0,
then handle it as a special case. Set the NFS3 status as
NFS3ERR_SERVERFAULT instead of NFS3_OK.
(3) The other component of FIX would be in DHT module and
is on the way.
Change-Id: I6f03c9a02d794f8b807574f2755094dab1b90c92
BUG: 1010241
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6026
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4e371c9ab179ac3fcd890da6cdc9eba5233eebf4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Aug 21 14:11:38 2013 -0400
client_t: phase 2, refactor server_ctx and locks_ctx out
remove server_ctx and locks_ctx from client_ctx directly and store as
into discrete entities in the scratch_ctx
hooking up dump will be in phase 3
BUG: 849630
Change-Id: I94cea328326db236cdfdf306cb381e4d58f58d4c
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5678
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3ad3dd92f79c181dc75c65e4df61fe199c973a4f
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Oct 31 08:18:56 2013 -0400
mgmt/glusterd: add option to specify a different base-port
This is (arguably) a hack to work around a bug in libvirt which is not
well behaved wrt to using TCP ports in the unreserved space between
49152-65535. (See RFC 6335)
Normally glusterd starts and binds to the first available port in range,
usually 49152. libvirt's live migration also tries to use ports in this
range, but has no fallback to use (an)other port(s) when the one it wants
is already in use.
Change-Id: Id8fe35c08b6ce4f268d46804bbb6dddab7a6b7bb
BUG: 1018178
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/6210
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1dec376963936d450475f9681ca4f7d6ec532d83
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Oct 30 11:57:01 2013 +0530
features/gfid-access: Handle inode remap when parent inode is NULL
Change-Id: Ic3f9d30d75df0bbbdf8fe28446fabe62d90fa854
BUG: 1024666
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6194
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 749f742efc010e2da1b5d03afde00cd9fe7a7894
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Oct 22 20:18:28 2013 +0530
glusterd: Release big-lock after log-rotate handler returns
... so that subsequent volume commands don't block waiting forever,
for the lock to be released.
Change-Id: I24b5ec47f6982900ab74ff1b492d523f31ecfb7f
BUG: 1022055
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/6122
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f7e20b459ee155b782e5ce294e007803435ac86a
Author: Anuradha <atalur@redhat.com>
Date: Thu Oct 24 15:03:48 2013 +0530
glusterd : Improved quota volume reset command
Quota volume reset command without "force"
option fixed, doesn't fail anymore. It resets
unprotected fields and not the protected ones.
Also, an appropriate message is provided to the user
for the following cases :
1. only unprotected fields are reset, "force" option
should be used to reset protected fields.
2. Both protected and unprotected fields are reset.
3. No field was reset, "force" option required.
Test case for the same also added.
Change-Id: I24e8f1be87b79ccd81bf6f933e00608b861c7a16
BUG: 1022905
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/6135
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ba9c68eb187960f722698f950cca6c60a54342d1
Author: Anand Avati <avati@redhat.com>
Date: Sun Oct 20 08:45:18 2013 -0700
rpcsvc: implement per-client RPC throttling
Implement a limit on the total number of outstanding RPC requests
from a given cient. Once the limit is reached the client socket
is removed from POLL-IN event polling.
Change-Id: I8071b8c89b78d02e830e6af5a540308199d6bdcd
BUG: 1008301
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6114
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 73b19db822a86455b3de32dbde2cb34310afae6e
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Thu Oct 17 16:17:54 2013 +0530
gNFS: Make NFS I/O size to 1MB by default
For better NFS performance, make the default I/O size to 1MB, same as
kernel NFS. Also refactor the description for read-size, write-size
and readdir-size (i.e. it must be a multiple of 1KB but min value
is 4KB and max supported value is 1MB). On slower network, rsize/wsize
can be adjusted to 16/32/64-KB through nfs.read-size or nfs.write-size
respectively.
Change-Id: I142cff1c3644bb9f93188e4e890478177c9465e3
BUG: 1009223
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6103
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 14c7c673d12457eefee5f951fe7c0bb53239e82e
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Fri Oct 25 13:54:34 2013 -0400
libgfapi: fixing tabs in glfsxmp.c with whitespace
Just replacing tabs with whitespace. No code changes present
in this patch
Change-Id: Ic3f64f5a52b0ab5e5c9fe9f45113901dec751e68
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6148
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 16ba970f9a5f23ac13df896497e2b50161f8e43b
Author: Ajeet Jha <ajha@redhat.com>
Date: Thu Oct 17 13:14:02 2013 +0530
geo-rep: Increasing the buffer_size for master-salve size comparision.
The buffer size is increased to 100MB, considering the space required by slave
filesystem bookkeeping.
Change-Id: Ib296f0e03b4d7a2de6d5ff0ae9ab09a5261e3e7c
BUG: 1020154
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/6102
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a8bfb3c82d973bdccc7abb5f606f78401a09a2ba
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Oct 23 13:39:18 2013 +0000
gfapi: fix mem-types initialisation
... and also fill the body of mem_acct_init().
Change-Id: I457d0629c20f999dd2f50e710c75b1c7575b6c19
BUG: 1021904
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/6134
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f73a9db52c033f2c49b1f0c833066e2b7ef8dda4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Oct 23 10:12:08 2013 -0400
dual license: update remaining files with correct license text
Sayan Saha has previously approved changing everthing to dual license
but somehow we have missed changing these files.
I am explicitly not updating the copyright dates as nothing else that's
copyrightable has changed in these files with the license change
Change-Id: Ia965eeb7168447d69e28e939ad95ee388873b6e4
BUG: 951549
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/6128
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 07194d2899e5c365f78fcd25d6c0308503393c37
Author: Poornima <pgurusid@redhat.com>
Date: Fri Oct 18 04:51:21 2013 +0000
extras/hook-scripts: Enable per client logging for gluster shares served by SAMBA
Edited hook scrips to add a variable in the option 'log file', which will be
substituted for client IP.
Change-Id: I50f143bb3114eb00afab2e1237d749804c885ca6
BUG: 1020848
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6109
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7f21f31ebc7cc8a205f0530621901d5a813a4e7e
Author: Anand Avati <avati@redhat.com>
Date: Sun Oct 13 23:15:48 2013 -0700
gfapi: wake migration waiters after migration
Wake call threads which are waiting on migration to complete with
a cond_broadcast. Else if any call which arrives right when migration
is attempted will end up hanging indefinitely.
Change-Id: I7df5298f93998d9a54fb12c16654e62333018ece
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/6111
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
commit 0cca87bfb9e7c5f8c37fc4c52c059a3ea777d8da
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Mon Oct 21 21:36:13 2013 +0530
Rectify the guard macro name of glusterfs-acl.h
Change-Id: I13bc7626c7f852647a75e3d5e397d2cd55757932
BUG: 1009210
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/6117
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 8cf7508200012097fca3513e44775d4811c1fff8
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sun Oct 20 21:45:45 2013 -0700
libglusterfs: Propositions should be logical
Mutually exclusive tests shouldn't be
non-contradictory
-- (A is B) && (A is not B) is not valid
Change-Id: Icf97d1704fedca4b8eeeb67da8b7d4c8d4b578d5
BUG: 769692
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6115
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 490f6779fc61d89c45c72ff2ca3b876d385c226b
Author: Bala.FA <barumuga@redhat.com>
Date: Fri Oct 18 11:06:59 2013 +0530
build: disable logging framework on rhel6
As rsyslog-mmcount is not yet available in rhel6 variant, this patch
disables logging framework on rhel6 and its dependency
BUG: 1018308
Change-Id: I6b7c04640f8d38055e00c697d1017c7a530463d0
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/6108
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f8a440bcb7579a2b004c52399973bcce7529a7f9
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sat Aug 31 22:34:02 2013 +0530
mgmt/glusterd: Relax extended attribute checks for volume create and add brick force.
Expectation with force is that user is aware of the consequences of
sanity checks not being triggered.
Change-Id: I79dfeed16a23829a7217cef33ab83f9f0ffae336
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
BUG: 1007509
Reviewed-on: http://review.gluster.org/5746
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 10f9c6bdc0c31932313e832069c795564d7df069
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Oct 16 00:34:44 2013 +0530
rpc: add remote peer's hostname to call_bail log msgs
Change-Id: I982cf7619463983c04b401d70a76635991d072d2
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6091
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
commit ee1b811b550ed02563c5fea09d24a10ca875b0ca
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Oct 16 21:24:32 2013 -0700
libglusterfs: Return 'ERANGE' for ASCII string to number system
Using 'EOVERFLOW' should be limited to data structure
alignments not Number systems.
Change-Id: I7d337d414e998c0a729c95661df239e36c753a38
BUG: 1017746
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6101
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 32c57ee72ba97b479dc8d2892241cb90182cdffd
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Oct 17 14:03:21 2013 -0400
glusterfs.spec.in: bad %define _sharedstatedir for rhel5
Change-Id: If2ca7052dfce9fada42180f1d469316fcde5adcb
BUG: 1003184
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/6105
Reviewed-by: Justin Clift <jclift@redhat.com>
Tested-by: Justin Clift <jclift@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 61be4b2a121b911badad68fff41377b7b1c73f37
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Oct 16 00:56:01 2013 +0530
gfapi: fix return value of glfs_fini
Change-Id: I5b90c7602334226a978bbdae2f9516e8701b403f
BUG: 1004519
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/6092
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1ad400b8bdb377818c1900aad209a282081cc70b
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jul 3 16:31:22 2013 +0530
cli,glusterd: Changes to cli-glusterd communication
Glusterd changes:
With this patch, glusterd creates a socket file in
DATADIR/run/glusterd.socket , and listen on it for cli requests. It
listens for 2 rpc programs on the socket file,
- The glusterd cli rpc program, for all cli commands
- A reduced glusterd handshake program, just for the 'system:: getspec'
command
The location of the socket file can be changed with the glusterd option
'glusterd-sockfile'.
To retain compatibility with the '--remote-host' cli option, glusterd
also listens for the cli requests on port 24007. But, for the sake of
security, it listens using a reduced cli rpc program on the port. The
reduced rpc program only contains read-only procs used for 'volume
(info|list|status)', 'peer status' and 'system:: getwd' cli commands.
CLI changes:
The gluster cli now uses the glusterd socket file for communicating with
glusterd by default. A new option '--gluster-sock' has been added to
allow specifying the sockfile used to connect. Using the '--remote-host'
option will make cli connect to the given host & port.
Tests changes:
cluster.rc has been modified to make use of socket files and use
different log files for each glusterd.
Some of the tests using cluster.rc have been fixed.
Change-Id: Iaf24bc22f42f8014a5fa300ce37c7fc9b1b92b53
BUG: 980754
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5280
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b28176ce807fc8909bae7710dcf46b2e7f89ee28
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Fri Oct 11 17:29:10 2013 +0530
posix: Fix readv FOP
Suggested by Anand Avati in BD xlator code review.
Change-Id: I31c353a26dfdeb3d0023c3f7e03ed25461d13c16
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
BUG: 837495
Reviewed-on: http://review.gluster.org/6077
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 5478a4b443523fb5a1abfea9057b62170f803e4e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Oct 16 15:58:33 2013 +0530
cluster/afr: Remove 'max' from the log
This patch avoids giving more info to the user about the
internal heuristic employed in afr, for quota sizes.
Change-Id: Ice3a164399f09b6967500ec0c17dc340e7ae9aba
BUG: 1016683
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6098
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 0a2f23ee9d3a0630dace8f7c00cc796ce91d82ac
Author: Ravishankar N <ravishankar@redhat.com>
Date: Tue Oct 15 22:37:44 2013 +0530
afr: check for split-brain before proceeding with fops
Bail out of fops if split brain has been detected during lookup
Change-Id: Id387dbb1a25eec4a121dedceadc6069bdea24b5d
BUG: 1010834
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/5988
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b02906911854583b7d47fab23b743ef4d009ce07
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Sun Oct 13 15:08:10 2013 -0400
libgfapi: Fix to compilation failure/warnings for examples/glfsxmp.c
The comilation of glfsxmp.c i.e. "make glfsxmp" was failing
with "undefined reference to `clock_gettime'" error.
Fixed all compilation warnings for unused variables and
wrong formart specifier in printf e.g. : "format ‘%d’ expects
argument of type ‘int’, but argument 3 has type ‘__syscall_slong_t’
[-Wformat]"
Also added the compilation steps for glfsxmp.c in the
README file
Change-Id: I399ec7c9ad7b6412463c89099d63922caef6749e
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6085
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Shyamsundar Ranganathan <srangana@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3b1e4708bd00406bf4d4ecfec59ebcd26b7c32a2
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Oct 14 11:50:40 2013 +0530
storage/posix: Lower log severity for ENODATA errors in getxattr()
Change-Id: I101e329cce4c1305615c63ebcb42355f6c3e85e0
BUG: 918052
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/6084
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 49ca9a9487eb8f0b57721e4adfc8716909cf8697
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Oct 11 12:46:06 2013 +0530
dht: dht_lookup_dir_cbk should set op_errno as local->op_errno
Two glusterfs clients return inconsistent errnos when the bricks of the volume
were down. Consider two gluster mounts. Mount 1 was done when the bricks were
online. Mount 2 was done after the bricks were killed, (using the 'glusterfs'
command instead of the mount script).
For any request, mount 1 will return ENOTCONN, where as mount 2 will return
ENOENT.
This happens because for the 2nd mount, a fuse would send a lookup on '/' for
any request, as it hadn't been done yet. The client xlator returns ENOTCONN,
but the dht_lookup_dir_cbk changed this to ENOENT unconditionally when
aggregating. So, fuse returned ENOENT, even though the errno should have been
ENOTCONN.
Change-Id: I4b7a6d84ce5153045a807fccc01485afe0377117
BUG: 1019095
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6072
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 7af0054289c36f2b90c1b908aad634d7c218fac9
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Oct 10 04:19:16 2013 -0700
libglusterfs: Add monotonic clocking counter for timer thread
gettimeofday() returns the current wall clock time and timezone.
Using these functions in order to measure the passage of time
(how long an operation took) therefore seems like a no-brainer.
This time suffer's from some limitations:
a. They have a low resolution: “High-performance” timing by
definition, requires clock resolutions into the microseconds
or better.
b. They can jump forwards and backwards in time: Computer
clocks all tick at slightly different rates, which causes
the time to drift. Most systems have NTP enabled which
periodically adjusts the system clock to keep them in sync
with “actual” time. The adjustment can cause the clock to
suddenly jump forward (artificially inflating your timing
numbers) or jump backwards (causing your timing calculations
to go negative or hugely positive). In such cases timer
thread could go into an infinite loop.
From 'man gettimeofday':
----------
..
..
The time returned by gettimeofday() is affected by discontinuous
jumps in the system time (e.g., if the system administrator manually
changes the system time). If you need a monotonically increasing
clock, see clock_gettime(2).
..
..
----------
Rationale:
For calculating interval timing for Timer thread, all that’s
needed should be clock as a simple counter that increments
at a stable rate.
This is necessary to avoid the jumps which are caused by using
"wall time", this counter must be monotonic that can never
“tick” backwards, ever.
Change-Id: I701d31e71a85a73d21a6c5cd15583e7a5a645eeb
BUG: 1017993
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6070
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e1ca2a05eb08453e6bf23f6ba74e644bfd318863
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Oct 10 17:20:57 2013 +0530
libglusterfs: Account for overflow in gf_string2bytesize
gf_string2bytesize will now return an error when a value is greater than
UINT64_MAX and set errno to EOVERFLOW. This is needed because casting a
double value greater than UINT64_MAX to uint64_t will convert it to 0.
BUG: 1017746
Change-Id: I6f96efc1e3a1c236685593a6fb7f806a87e46019
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6068
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4ccc117be7b22b59af631cdba3e6644defdcdb96
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Mon Oct 7 13:47:47 2013 +0530
cluster/afr: [Feature] Command implementation to get heal-count
Currently to know the number of files to be healed, either user
has to go to backend and check the number of entries present in
indices/xattrop directory. But if a volume consists of large
number of bricks, going to each backend and counting the number
of entries is a time-taking task. Otherwise user can give
gluster volume heal vol-name info command but with this
approach if no. of entries are very hugh in the indices/
xattrop directory, it will comsume time.
So as a feature, new command is implemented.
Command 1: gluster volume heal vn statistics heal-count
This command will get the number of entries present in
every brick of a volume. The output displays only entries
count.
Command 2: gluster volume heal vn statistics heal-count
replica 192.168.122.1:/home/user/brickname
Here if we are concerned with just one replica.
So providing any one of the brick of a replica will get
the number of entries to be healed for that replica only.
Example:
Replicate volume with replica count 2.
Backend status:
--------------
[root@dhcp-0-17 xattrop]# ls -lia | wc -l
1918
NOTE: Out of 1918, 2 entries are <xattrop-gfid> dummy
entries so actual no. of entries to be healed are
1916.
[root@dhcp-0-17 xattrop]# pwd
/home/user/2ty/.glusterfs/indices/xattrop
Command output:
--------------
Gathering count of entries to be healed on volume volume3 has been successful
Brick 192.168.122.1:/home/user/22iu
Status: Brick is Not connected
Entries count is not available
Brick 192.168.122.1:/home/user/2ty
Number of entries: 1916
Change-Id: I72452f3de50502dc898076ec74d434d9e77fd290
BUG: 1015990
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/6044
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1807737aaa83d7c85db6b645d3886733c0b1e5d6
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Thu Sep 12 12:37:37 2013 +0530
cluster/afr : Implementation of command "gluster volume heal vn statistics"
"gluster volume heal volumename statistics" command gives the summary
of the afr crawl done based on the entries present in the xattrop
directory. Whenever afr crawls are attempted, the beginning time of
crawl, end time of crawl, no of files healed, heal-failed count and
number of files in split brain are shown along with the type of the
crawl. If crawl is already in progress then it will give the number
of files healed, heal failed count and number of files in split-brain
from the beginning of the crawl and instead of telling the end time of
the crawl, "CRAWL IN PROGRESS" message will be shown.
Output format:
command: "gluster volume heal volume-name statistics"
Output:
Gathering afr crawl statistics crawl statistics on volume volume-name
has been successful
------------------------------------------------
Crawl statistics for brick no 0
Hostname of brick 192.168.122.248
Starting time of crawl: Wed Jul 10 15:52:38 2013
Ending time of crawl: Wed Jul 10 15:52:38 2013
Type of crawl: INDEX
No. of entries healed: 0
No. of entries in split-brain: 0
No. of heal failed entries: 0
Starting time of crawl: Wed Jul 10 15:52:38 2013
Ending time of crawl: Wed Jul 10 15:52:38 2013
Type of crawl: INDEX
No. of entries healed: 0
No. of entries in split-brain: 0
No. of heal failed entries: 0
------------------------------------------------
Crawl statistics for brick no 1
Hostname of brick 192.168.122.1
Starting time of crawl: Wed Jul 10 15:52:42 2013
Ending time of crawl: Wed Jul 10 15:52:42 2013
Type of crawl: INDEX
No. of entries healed: 0
No. of entries in split-brain: 0
No. of heal failed entries: 0
Starting time of crawl: Wed Jul 10 15:52:42 2013
Ending time of crawl: Wed Jul 10 15:52:42 2013
Type of crawl: INDEX
No. of entries healed: 0
No. of entries in split-brain: 0
No. of heal failed entries: 0
--------------------------------------------------
Change-Id: I10bf9d10b005741db9973fb1352e0dd59ed99aa9
BUG: 949400
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4790
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0c7df3ae355991a272ef452b9e53f3d39ee5d6de
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Sep 17 11:44:34 2013 +0530
transport/socket: don't try to set TCP_DELAY on unix domain sockets
Change-Id: I290cd983bd0dff2e32e5ee90a12e888a3b31c6fd
BUG: 969461
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/5954
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e4b37b143c036f4cc5d6ea1732fe61a646fd7c4b
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Oct 8 21:30:21 2013 -0700
glusterfs.spec: Add _sharedstatedir for RHEL5
-------------------------------------------------
> # rpm --showrc | grep sharedstatedir | grep com
-14: _sharedstatedir %{_prefix}/com
> # cat /etc/redhat-release
Red Hat Enterprise Linux Server release 5.8 (Tikanga)
-------------------------------------------------
EL5 package has a missing macro _sharedstatedir which
should be pointing to `/var/lib` not `%{_prefix}/com`
Change-Id: Ida72360d73d5dffa767c69642ee395e9c82fa8c6
BUG: 1003184
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6054
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2dcd298d7d02f9934d5f2e2e9fafd28a13539f90
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Oct 9 08:29:18 2013 -0400
build: sync glusterfs.spec.in with Fedora glusterfs.spec
(this is the master branch)
sync with Fedora glusterfs.spec 3.4.1-2+
Change-Id: I8a303efb0ac8cd3e04531e2f02427e3590387493
BUG: 950083
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/6059
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4a28b4c38de12f0058d9ec33ed424f3bd165b343
Author: R.Shyamsundar <srangana@redhat.com>
Date: Mon Sep 16 16:39:24 2013 +0530
gfapi: object handle based API extensions
There is an ongoing effort to integrate NFS Ganesha (
https://github.com/nfs-ganesha/nfs-ganesha/wiki ) with GlusterFS as one of
the file system back ends.
Towards this we need extensions to gfapi that can handle object based
operations. Meaning, instead of using full paths or relative paths from
cwd, it is required that we can work with APIs, like the *at POSIX
variants, to be able to create, lookup, open etc. files and directories.
Hence the objects are the files or directories themselves and we give out
handles to these objects that can be used for further operations.
This code drop is an initial implementation of the proposed APIs.
The new APIs are implemented as glfs_h_XXX variants in the file
glfs-handleops.c to mirror glfs-fops.c style. The code leverages holding
onto inode references and doling these out as opaque/cookie type objects to
the callers, to enable them to be used as handles in other operations.
An fd based approach was considered, but due to the extra footprint that
the fd structure and its counterparts would incur, this was dropped to take
the approach of holding inode references themselves.
Tested by extending glfsxmp.c to invoke and exercise the added APIs, and
further tested with a reference integration of the same as an FSAL with NFS
Ganesha.
Change-Id: I23629c99e905b54070fa2e6565147812e5f3fa5d
BUG: 1016000
Signed-off-by: R.Shyamsundar <srangana@redhat.com>
Reviewed-on: http://review.gluster.org/5936
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7300a2e94bbf1fe3f1197f8b12080eb546e8c848
Author: Poornima <pgurusid@redhat.com>
Date: Fri Oct 11 04:06:56 2013 +0000
gfapi: Fix iobuf leaks in gfapi
In glfs_readv, if syncop_readv() fails with return value <= 0
the iobref was not being unrefd which would cause iobuf leaks.
Change-Id: I9850ae149e53cf75ba26f8b5f4c5446cce4b5991
BUG: 1018176
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/6074
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cc67c8157c266a1c47c94a5d6514a2afa707d6f4
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Oct 8 17:14:40 2013 +0530
cluster/afr: Handle quota size xattr separately in lookup
Quota size xattrs are not maintained by afr. There is a
possibility that they differ even when both the directory
changelog xattrs suggest everything is fine. So if there is at
least one 'source' check among the sources which has the maximum
quota size. Otherwise check among all the available ones for
maximum quota size. This way if there is a source and stale copies
it always votes for the 'source'.
Change-Id: Ia222379cbafa7043dd03f533c105860f2c7b8b0d
BUG: 1016683
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6052
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Varun Shastry <vshastry@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2fc1d7b44c0405283bb5b086fcb221753f8f00ef
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Oct 9 11:13:11 2013 +0200
rpm: glusterfs-api-devel requires glusterfs-devel
When installing the glusterfs-api-devel package in order to build
software that uses libgfapi, there are unmet dependencies. Installing
glusterfs-devel additionally solved these link errors:
$ echo 'int main(){}' > bar.c
$ gcc -o bar bar.c $(pkg-config --libs glusterfs-api)
/usr/bin/ld: cannot find -lglusterfs
/usr/bin/ld: cannot find -lgfrpc
/usr/bin/ld: cannot find -lgfxdr
collect2: error: ld returned 1 exit status
Change-Id: I12e922aa6609809c03ec2c9a0d8a47c5df91d0a1
BUG: 1017094
Reported-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/6056
Reviewed-by: Bala FA <barumuga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 28bf671b65cc0f1fc19311c9bb3939a1066b9d8e
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Oct 2 07:16:02 2013 -0400
contrib/qemu: disable coroutine caching in qemu
Coroutine caching in qemu is dangerous in the manner that the
qemu-block translator embeds the qemu block subsystem code. After
a graph switch, new requests can fork off and pass active graph
data structures (i.e., inodes) down into old syncenvs and old
graphs, leading to failures.
BUG: 986775
Change-Id: I7b7226ff57c7867d0e51a58a7c0e58f4d8424c31
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/6022
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 774d9ef52d8968b777c785baac758a1f0764b832
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Oct 2 07:15:44 2013 -0400
features/qemu-block: invoke bdrv_init() only once
bdrv_init() is intended to be invoked only once. If invoked again
after initialization (i.e., due to graph changes), the block driver
registration code can reinsert entries into bdrv_drivers,
effectively corrupting the NULL terminated linked list. This
manifests as an infinite loop for callers attempt to traverse the
list (to locate a driver).
BUG: 986775
Change-Id: I2f95bda3c753dece4648cdad009d0e2a2d16f644
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/6021
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 299d22459a46721458db9d3c35c0f0bd87b6cbda
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Oct 9 12:08:49 2013 +0200
tests/basic/rpm.t: fix script error introduced by commit a66bf679
The if-clause will always return false, causing each regression test to
build the rpms. The following error is listed on the Jenkins Console
Output of the regression test:
./tests/basic/rpm.t: line 42: [: argument expected
BUG: 904005
Change-Id: I343c80d8c57fa0ec8b8a531bb5f5c86209d88d7e
CC: Harshavardhana <harsha@harshavardhana.net>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/6057
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
commit 329baff8ca13d8e5d6ca98d221d59cd2329cd19c
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Sep 24 17:01:46 2013 +0530
cli,glusterd: Implement 'volume status tasks'
oVirt's Gluster Integration needs an inexpensive command that can be
executed every 10 seconds to monitor async tasks and their parameters,
for all volumes.
The solution involves adding a 'tasks' sub-command to 'volume status'
to fetch only the async task IDs, type and other relevant parameters.
Only the originator glusterd participates in this command as all the
information needed is available on all the nodes. This is to make the
command suitable for being executed every 10 seconds.
Change-Id: I1edc607baf29b001a5585079dec681d7c641b3d1
BUG: 1012346
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/6006
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 0be3d66b99973177bacbb2559effeb8b9ffdb020
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Oct 7 13:08:49 2013 +0530
extras/hookscripts: Fix the multiple entries in smb.conf problem.
Problem:
1. Force starts and user.smb sets were adding multiple entries to
the smb.conf file for the same volume.
Make a check for the entry and search with exact name.
2. Again, while deleting the share name from smb.conf search with
exact name so that volumes with names which are substrings of ones to
be deleted don't get deleted.
3. We don't need to use a tmp file while using sed -i, fixed that.
Change-Id: Ie0f7c9d4790ef9a177a043378a761c9ffe1628e5
BUG: 994727
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/6043
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Lalatendu Mohanty <lmohanty@redhat.com>
Tested-by: Lalatendu Mohanty <lmohanty@redhat.com>
commit ac2d107df81b4f661af8ed1e72565e6a2d33d077
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Thu Oct 3 15:08:34 2013 +0530
NFS: showmount timesout on fetching export list
Bug: 1015184
Issue: showmount timesout on fetching export list. Socket writev
function is failing.
Cause: XDR encoding of export list is failing. The calling function
without checking the error returned by xdr_serialize_exports
function is going ahead and writting into the socket causing
the NFS process to hang. xdr_serialize_exports function returns
-1 on error and message length on success.
Fix: Caller should check if the function is returning -1 (error) or
not before proceeding.
Change-Id: Ic3a5a9356e47b2ac938dd3e429cf2b71c0a0c715
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/6030
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0d06836cfe47e32adb82f9919723fc3b176d94f1
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Mon Sep 16 14:56:50 2013 -0400
hookscripts: Changes in hook scripts to make it work on all Linux/GNU distribution Removed the hard coded values for smb.conf, smb logfile location and smbd.pid. The current hook scripts also work for manully compiled (make, make install) instance of gluster and Samba. But we have to manually copy the hook scripts to respective locations.
Change-Id: I14056830fcd2ecb48b3c4df89265f4408c8de3e3
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/5947
Reviewed-by: poornima g <pgurusid@redhat.com>
Reviewed-by: susant palai <spalai@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 67eb000dfd01b0fb1867a233bebd5c2bd194b254
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Oct 4 10:17:09 2013 +0200
Fix build on NetBSD-current
BUG: 764655
Change-Id: I2aaec9de617b0616525ad30f82ac6f75a6446d33
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/6036
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0478fc85ea45b5bf43b08954415ba18f3978abfe
Author: Bala.FA <barumuga@redhat.com>
Date: Thu Sep 26 08:09:35 2013 +0530
cli: add node uuid in rebalance and remove brick status xml output
This patch adds node uuid in rebalance/remove-brick status xml output.
Output XML will look like
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volRebalance>
<op>3</op>
<nodeCount>1</nodeCount>
<node>
<nodeName>localhost</nodeName>
==>> <id>883626f8-4d29-4d02-8c5d-c9f48c5b2445</id>
<files>0</files>
<size>0</size>
<lookups>0</lookups>
<failures>0</failures>
<status>3</status>
<statusStr>completed</statusStr>
</node>
<aggregate>
<files>0</files>
<size>0</size>
<lookups>0</lookups>
<failures>0</failures>
<status>3</status>
<statusStr>completed</statusStr>
</aggregate>
</volRebalance>
</cliOutput>
Change-Id: I5a1d4f9043b33b9e88150647a243ddb16154e843
BUG: 1012296
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/6005
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4c66f96b2a782132e4fa197de59fe69cb5600412
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jul 25 01:14:48 2013 +0530
glusterfsd, libgfapi: destroy the temporary graphs constructed for comparison
* The new and the oldgraphs which have been constructed whenever there is
a volfile change (either reconfigure of the existing graph or creating
a new graph) for comparison should be freed. Otherwise frequent graph
changes will lead to huge memory leak
Change-Id: I4faddb1aa9393b34cd2de6732e537a60f600026a
BUG: 948178
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/5388
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 59b77113fe4338c7401a80d005b72c82c13f736f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Oct 3 11:52:53 2013 +0530
Tests: Enable fore-ground self-heal
Change-Id: Ibfca8ddb7c663d44ed447be13b2eabb7bd393bb3
BUG: 993981
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6028
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a6c51cd74d1ca2cba106c298710fed73d1fe2c81
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Oct 3 10:28:47 2013 +0530
cluster/afr: Change Self-heal domain separator to ':'
'-' can be present in a volume. This may lead to domain
collisions in future.
Tests:
Checked in gdb that domain comes with ':' separator:
Breakpoint 1, pl_common_inodelk (frame=0x7fdabcce51a4,
this=0x8bde20, volume=0x8b50d0 "r2-replicate-0:self-heal",
inode=0x7fdab822f0e8, cmd=6, flock=0x7fdabc76eee4,
loc=0x7fdabc76ede4, fd=0x0, xdata=0x7fdabc6e0ab0) at inodelk.c:597
Change-Id: I4456ae35ac8bf21e6361c34e9ad437f744a2e84b
BUG: 993981
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/6025
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f337902fd69595ca9508a3cb1223aabb64f13537
Author: Aravinda VK <avishwan@redhat.com>
Date: Thu Sep 19 14:24:35 2013 +0530
geo-rep: logrotate: Logrotate handling
In existing georep logrotate was implemented by handling SIGSTOP
and SIGCONT, gsyncd was failing to start again after SIGSTOP.
New approach uses WatchedFileHandler in logging, which tracks the
log file changes or logrotate. Reopens the log file if logrotate is
triggered or if same log file is updated from other process.
As per python doc:
http://docs.python.org/2/library/logging.handlers.html:
The WatchedFileHandler class, located in the logging.handlers module,
is a FileHandler which watches the file it is logging to. If the file
changes, it is closed and reopened using the file name.
A file change can happen because of usage of programs such as newsyslog
and logrotate which perform log file rotation. This handler, intended
for use under Unix/Linux, watches the file to see if it has changed
since the last emit. (A file is deemed to have changed if its device
or inode have changed.) If the file has changed, the old file stream
is closed, and the file opened to get a new stream.
Change-Id: I30f65eb1e9778b12943d6e43b60a50344a7885c6
BUG: 1012776
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/5968
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4a0d5c62d98e86f60db482c10b92e446a9e5620e
Author: Ajeet Jha <ajha@redhat.com>
Date: Mon Sep 23 13:42:21 2013 +0530
glusterd: Validating invalid log-level under geo-rep config options.
Change-Id: I8ff6b48ef41fd6e9ea68c42dfb9878f8a08ed627
BUG: 1010874
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/5989
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit a98b8b8db9f427d850580b7b1c1060b7e53a579d
Author: Aravinda VK <avishwan@redhat.com>
Date: Tue Sep 24 12:41:30 2013 +0530
cli: runtime in xml output of rebalance/remove-brick status
"runtime in secs" is available in the CLI output of
rebalance status and remove-brick status, but not available
in xml output when --xml is passed.
runtime in aggregate section will be max of all nodes runtimes.
Example output:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volRebalance>
<op>3</op>
<nodeCount>1</nodeCount>
<node>
<nodeName>localhost</nodeName>
<files>0</files>
<size>0</size>
<lookups>0</lookups>
<failures>0</failures>
<skipped>0</skipped>
<runtime>1.00</runtime>
<status>3</status>
<statusStr>completed</statusStr>
</node>
<aggregate>
<files>0</files>
<size>0</size>
<lookups>0</lookups>
<failures>0</failures>
<skipped>0</skipped>
<runtime>1.00</runtime>
<status>3</status>
<statusStr>completed</statusStr>
</aggregate>
</volRebalance>
</cliOutput>
BUG: 1012773
Change-Id: I8deaba08922a53cd2d3b411e097a7b3cf591b127
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/5997
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7e41a09c5686fdb9028c6ae0bf9605cbdf7eaa64
Author: Aravinda VK <avishwan@redhat.com>
Date: Wed Sep 25 12:04:11 2013 +0530
cli: skipped tag in xml output of rebalance/remove-brick status
Skipped files count is available in CLI output of rebalance status
and remove-brick status, but not available in xml output.
Example output:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>0</opErrno>
<opErrstr/>
<volRebalance>
<op>3</op>
<nodeCount>1</nodeCount>
<node>
<nodeName>localhost</nodeName>
<files>0</files>
<size>0</size>
<lookups>0</lookups>
<failures>0</failures>
<skipped>0</skipped>
<status>0</status>
<statusStr>completed</statusStr>
</node>
<aggregate>
<files>0</files>
<size>0</size>
<lookups>0</lookups>
<failures>0</failures>
<skipped>0</skipped>
<status>0</status>
<statusStr>completed</statusStr>
</aggregate>
</volRebalance>
</cliOutput>
BUG: 1012772
Change-Id: I05191293403e66e0d681f0cd0422aa3c78a2d91d
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/6000
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 46a4a9967f3d41f675dcd3defe177139781a6c90
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Oct 1 14:51:46 2013 -0400
protocol/server: eliminate an unnecessary frame create and destroy
connection_cleanup creates a frame solely so that it can be copied.
But the process of copying creates a new frame, and there's nothing
apparently magic about the one being copied; we can eliminate an
unnecessary create and destroy.
Which in the grand scheme of things probably isn't the worst thing
we do, but it's low hanging fruit.
Change-Id: I4a23b84a53e086137b7d4167ad8c20b673d1ffe5
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/6019
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b8bb1adfe7909fd0989c8289d3e787592d5eea1f
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Sep 30 09:05:14 2013 +0200
gfapi.py: support dynamic loading of versioned libraries
Currently gfapi.py only loads libraries by filename ending in ".so". On
an installed system without development packages, the <lib>.so filenames
are not available. ctypes.util.find_library() can be used to detect the
files dynamically.
In addition to this, also fixing some minor indention errors and package
the library into the Python site-packages path. Python applications and
libraries can now access libgfapi through 'from glusterfs import gfapi'.
Change-Id: I71e38dabd3ade5dcf24813bf2fc25cda91b571c6
BUG: 1005146
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5835
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9366f166e87a8e9a0a3615d05fcb342081106b67
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Sep 30 16:10:32 2013 -0700
tests: Gather only files which need to built
Previous code would rather provide a filter but never look
for newly "Added" files leading to failures in subsequent
build.
This patch fixes such issue by actually verifying pedantically
for only files which need to be tested.
Change-Id: Ia716acf82ee60f8ffe5e36257f1cc866c6062718
BUG: 904005
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/6016
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 82e9084ebbbcc24662fe43e22ab0ed0be3aea9ce
Author: Anand Avati <avati@redhat.com>
Date: Fri Sep 27 10:21:22 2013 -0700
libglusterfs: add glusterfs-acl.h to Makefile.am
Without this, glusterfs-acl.h is left out of 'make dist'
and building RPM fails.
Change-Id: I5dc9dc8eecdea4c4c0d06f0b3da23bd2df4e944e
Signed-off-by: Anand Avati <avati@redhat.com>
BUG: 1009210
Reviewed-on: http://review.gluster.org/6015
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a14ee7eafcff0a9508d8dd46b6874fd6ea0c46d8
Author: Anuradha <atalur@redhat.com>
Date: Fri Sep 27 17:42:17 2013 +0530
Logging : Improved the log message on unlock failure in afr_unlock_inodelk_cbk.
"unlock failed on 1 unlock" seems meaningless in the log message. Improved it.
Change-Id: If67d3f9d4aa5310d0b6728a6c89fa58a5cc93d12
BUG: 1012947
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/6012
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0aab067dc7d67819848189f88fea65ab8a5298f2
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Aug 12 10:43:52 2013 +0530
glusterd: Calculate volume op-versions only on set/reset
The volume op-versions are calculated during a volume set/reset, reading a
volume from disk and importing a volume during probe or volume sync. The
calculation of the volume op-version depends on the clusters op-version as some
features are enabled automatically depending on the clusters op-version. We
also don't store the volume op-versions persistently and don't export the
volume op-versions during sync. Due to this, there can occur cases which will
lead to inconsistencies in volumes in different peers. One such case is below,
Consider, a cluster made up 3 peers P1, P2 and P3, operating at op-version N.
The cluster has two volumes V1 and V2, which have volume op-versions N (since
volume op-version cannot be greater than cluster op-version). We have,
Cluster-op-version = N
V1 op-version = N
V2 op-version = N
A set operation on V1 causes the clusters op-version to be bumped up to N+1.
Assume that there exist some features that are automatically enabled on
op-version N+1. The op-version of V2 remains at N as no operation has been
performed on it. So,
Cluster op-version = N+1
V1 op-version = N+1
V2 op-version = N
Now, we probe a new peer P4. On the new peer we will have the following
op-versions,
Cluster op-version = N+1
V1 op-version = N+1
V2 op-version = N+1
This happens because we don't send volume op-versions during the sync after
probe. P4 will freshly calculate the op-version of V2 (assuming features have
been auto enabled due to the cluster op-version being N+1) as N+1.
Another case is when glusterd on a peer restarts. Assume P3 was restarted,
glusterd will recalculate the volume op-versions during the restore state.
Again, op-version of V2 will be calculated as N+1 assuming auto enabled
features. This will lead to inconsistency in the volume representation in
memory and on disk, as glusterd will assume the volume contains auto enabled
features, but the volfiles don't contain them as they were not regenrated.
These kind of issues can be solved by calculating the volume op-version only
when features are enabled and disabled (ie. during volume set/reset),
persisting the volume-op-versions and exporting/importing them.
Change-Id: I52de0668c92628622e85f4588fb28829a7231132
BUG: 1005043
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5568
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 28811b9abc38cfea5da215efaf278481a56948fb
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Sep 26 18:07:51 2013 +0530
glusterd: Fix storing volumes on setting global opts
Glusterd would not store all the volumes when a global options were set.
When setting a global option, like 'nfs.*' options, glusterd used to
modify the volinfo for all the volumes, but would store only the volinfo
for the named volume. This lead to mismatch in the persisted and the
in-memory representation of those volumes, which lead to problems like
peers being rejected because of volume mismatches.
Change-Id: I8bca10585e34b7135cb32af0055dbd462b3fb9b5
BUG: 1012400
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/6007
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 73b3601290e061e0b4c9b0a5e0cabbe6ecc47d84
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Sep 20 11:37:51 2013 +0530
glusterd: Set errstr appropriately on peer op failure
Change-Id: I27f5f7cd54115d7b236b42f6beaaa05a8b379dd7
BUG: 1010153
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/5978
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 37e5b4550ca3809ce8ecb00aaa013291aebb0b78
Author: ajha <ajha@redhat.com>
Date: Fri Aug 30 15:14:46 2013 +0530
features/changelog : Improvement in changelog "encoding-change".
change in encoding method of changelog was critical section for
"fop dispatch thread", "roll-over thread" and "reconfigure dispatch thread".
In this patch the "encoding-method" is changed by the reconfigure dispatch thread
lazily during handle_change, which solves the concurrency among the racing
threads.
BUG: 1002940
Change-Id: I78c3e8887efa46d0fcc60755cdf4243031cfa3eb
Signed-off-by: Ajeet Jha <ajha@redhat.com>
Reviewed-on: http://review.gluster.org/5844
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
commit c44b1a81753b9547ff654f4d6bbbeb6fbe004bd8
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Sep 13 15:54:52 2013 +0200
extras: add script and config for generating "Who wrote GlusterFS"
This script and configuration can be used to generate statistics similar
to the "Who wrote <linux-version>" series available on http://lwn.net.
Example usage for statistics from the initial branchpoint of 3.4 to the
current development of the release-3.4 branch:
$ extras/who-wrote-glusterfs/who-wrote-glusterfs.sh \
v3.4.0alpha...origin/release-3.4
By default the statistics will be calculated over the currently checked
out branch.
Change-Id: Ie7b8b655c50dcb14257e42599e2f89642c8b5b42
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5912
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 751852ba3283829aeef212c6b657e280a4e8bf0e
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Thu Sep 19 12:01:38 2013 +0530
gNFS: Incorrect NFS ACL encoding for XFS
Problem:
Incorrect NFS ACL encoding causes "system.posix_acl_default"
setxattr failure on bricks on XFS file system. XFS (potentially
others?) doesn't understand when the 0x10 prefix is added to the
ACL type field for default ACLs (which the Linux NFS client adds)
which causes setfacl()->setxattr() to fail silently. NFS client
adds NFS_ACL_DEFAULT(0x1000) for default ACL.
FIX:
Mask the prefix (added by NFS client) OFF, so the setfacl is not
rejected when it hits the FS.
Original patch by: "Richard Wareing"
Change-Id: I17ad27d84f030cdea8396eb667ee031f0d41b396
BUG: 1009210
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/5980
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3e813239a05bbb9df72c84ec611acc2a8c0e8986
Author: Anand Avati <avati@redhat.com>
Date: Tue Sep 24 09:45:08 2013 -0700
core: block unused signals in created threads
Block all signal except those which are set for explicit handling
in glusterfs_signals_setup(). Since thread spawning code in
libglusterfs and xlators can get called from application threads
when used through libgfapi, it is necessary to do this blocking.
Change-Id: Ia320f80521a83d2edcda50b9ad414583a0175281
BUG: 1011662
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5995
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 17ce52d5e13bc083031f6954964473bb0ae5c8bb
Author: Anand Avati <avati@redhat.com>
Date: Sun Sep 15 15:00:06 2013 -0700
posix-acl: fixup extended ACL entries properly
Typically when updating cached ACL from backend, we get both iatt and
ACL xattrs (like lookup, readdirplus etc.) However in calls like
setattr(), the mode would have updated but we receive only iatt and not
the ACL xattrs. In such case we need to "spread" the effects of the
changed mode properly into the cached ACL xattr ourselves.
Change-Id: I23a7bc9c14722ff6848e175ed4bbe863a21ce2c9
BUG: 998967
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5979
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 87d360af5c2987de4a87838d429f7bc008729cc5
Author: shishir gowda <sgowda@redhat.com>
Date: Wed Jul 31 14:45:03 2013 +0530
Revert "cluster/dht: Return success in dht_discover if layout issues"
This reverts commit a3e593f9f17cb1e68db97bb5a0d8074793a33964 which
was bought into fix dht_layout_anomalies error handling.
We still see applications error'ing out due to graph switches.
To fix the above issue -
We cannot heal in dht_discover, as it is a gfid based lookup, and not
path based. So, returning error here would lead to app's to see failure.
Also, update the layout in inode_ctx even if it has anomalies. Let
subsequent heals fix the issue.
Conflicts:
xlators/cluster/dht/src/dht-common.c
Signed-off-by: shishir gowda <sgowda@redhat.com>
Change-Id: I68c1056c3587e04a02344548546ddd06034489c5
BUG: 960348
Reviewed-on: http://review.gluster.org/5443
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f3c298b1383c32b6bafff31b2f6ec1f3c4782e57
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Sep 13 15:20:45 2013 +0530
logging: Expose set_log_file_path() in libglusterfs.
This patch also changes the behavior of glfs_set_logging().
If logfile argument is not provided to glfs_set_logging(),
libgfapi uses set_log_file_path() to create a logfile.
Change-Id: I49ec66c7f16f5604ff2f7cf7b365b08a05b5460d
BUG: 764890
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5910
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 82732a56a9f66c93bd98f031ad2f19801f7a606c
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Sep 13 11:11:41 2013 +0530
logging: Remove multiple definitions of DEFAULT_LOG_FILE_DIRECTORY
Change-Id: I8d670a228d3c1282aa7d70b151f166d04abc40e5
BUG: 764890
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5909
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 6a8d45ede3fe01661151da3825ea4ad8e2a742e2
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Sep 3 09:13:21 2013 +0000
cluster/dht: Fix anomaly check
We were wrongly detecting holes/overlaps for already accounted
errors. Additionally, sort should also handle zero'ed out layout
Change-Id: Ic3d13e1d735b914f9acc01fe919bc90656baea48
BUG: 1003851
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5762
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 31403ae8bf34d8a3f4cc3e09f344bf60cf3b2dcc
Author: Anand Avati <avati@redhat.com>
Date: Sat Aug 10 23:10:04 2013 -0700
parser: use private namespace 'graphyy' instead of 'yy'
This can cause linker errors when accessing glusterfs through
libgfapi if the caller also uses a parser with 'yy' prefix.
Change-Id: I6544333c47a1f18193741420717c989e4bdea7b1
BUG: 764890
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5643
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 6517b590c7d0b468e5ea376dba520559c8c631c7
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Sep 10 15:14:52 2013 +0530
glusterd/cli: Status detail cli parse check and vol geo status crash fix
Change-Id: I1841864273fc4242de15fbfcf76fd5de40269f28
BUG: 1006249
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5889
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a2406cff7d96853b9ad35f5a6c0f482ddf21572d
Author: Anand Avati <avati@redhat.com>
Date: Sun Sep 15 19:56:25 2013 -0700
tests: take regression tests out of autotools
make run-tests.sh "location independent" and replace 'make install'
with cpio in glusterfs.spec.in
Change-Id: I140473c7f558e1e0af93a863b79098ced516a76b
BUG: 764966
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5986
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 953547163a8b4d8a25ad469da30daf1b30466936
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 5 10:14:08 2013 -0400
glusterd.service (systemd), ensure glusterd starts before local mounts
NOTICE: this patch was accepted onto the release-3.4 branch for 3.4.1,
but this same patch for master is languishing here in review.
Try (emphasis on the try) to ensure that glusterd starts, and in turn
starts glusterfsd before init attempt to mount any gluster (or gluster
NFS) volumes in /etc/fstab.
N.B. Joe Julian says this doesn't fix the problem for him, although it
worked for me in kvm. Lennart Poettering says it should, and we should
file a BZ against systemd if it doesn't. See
https://lists.fedoraproject.org/pipermail/devel/2013-July/185870.html
Change-Id: I4d8061217d8301beb0da485dc63a1984a7c57c37
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
BUG: 1004795
Reviewed-on: http://review.gluster.org/5823
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 779f2b5d0e31a5944d7c9db1bf4afcd225455a50
Author: Avra Sengupta <asengupt@redhat.com>
Date: Sun Sep 15 17:55:31 2013 +0530
glusterd: Adding transaction checks for cluster unlock.
While a gluster command holding lock is in execution,
any other gluster command which tries to run will fail to
acquire the lock. As a result command#2 will follow the
cleanup code flow, which also includes unlocking the held
locks. As both the commands are run from the same node,
command#2 will end up releasing the locks held by command#1
even before command#1 reaches completion.
Now we call the unlock routine in the code path, of the cluster
has been locked during the same transaction.
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Change-Id: I7b7aa4d4c7e565e982b75b8ed1e550fca528c834
BUG: 1008172
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5937
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7ea8b547db6960056b4640a6eb3a9ae86c2e406a
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Sep 7 15:20:39 2013 +0530
geo-rep: pack the value of 'readlink()' while crawling symlinks
without having 'readlink()' value, symlink fails on slave mounts
Change-Id: Ib84be8db77c033029ba8ba454fd629a496fc3fe1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 847839
Reviewed-on: http://review.gluster.org/5950
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3c541305a63990c6d471887594781c005077465c
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 16 14:24:54 2013 +0530
geo-replication: treat MKNOD also as regular file create
Change-Id: Iec04f642282b554a4d1b5f5c8cdc099fd001b3f4
Original-Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 847839
Reviewed-on: http://review.gluster.org/5949
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5461aa366d6d888e5ca65da7797a3446529e7645
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 16 14:04:05 2013 +0530
geo-rep: create hardlink as hardlinks in xsync crawl
BUG: 847839
Change-Id: Ieaa754f15611392c09afcc7190b9ff9da39d7fce
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5934
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b0be8089125a911cb2504185718d9354c1dec9ba
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Wed Sep 18 14:43:40 2013 +0530
gNFS: NFS daemon is limiting IOs to 64KB
Problem:
Gluster NFS server is hard-coding the max rsize/wsize to 64KB
which is very less for NFS running over 10GE NIC. The existing
options nfs.read-size, nfs.write-size are not working as
expected.
FIX:
Make the options nfs.read-size (for rsize) and nfs.write-size
(for wsize) work to tune the NFS I/O size. Value range would
be 4KB(Min)-64KB(Default)-1MB(max).
NB: Credit to "Richard Wareing" for catching it.
Change-Id: I2754ecb0975692304308be8bcf496c713355f1c8
BUG: 1009223
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/5964
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d202dbd8e0dd17392aa7bf9feda986f0767b5863
Author: Justin Clift <jclift@redhat.com>
Date: Fri Sep 20 16:05:28 2013 +0100
Fix typo in systemd service definition file
Change-Id: Ia9dac04ad508fbaafbed24b2137b09872a1ca53c
BUG: 1010352
Signed-off-by: Justin Clift <jclift@redhat.com>
Reviewed-on: http://review.gluster.org/5981
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit f305107bb779227b89672f74c795b41c87ee36e0
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Aug 21 00:50:41 2013 -0700
tests: Create a regression-tests package for distribution
As of today regression tests are an in-house breed, by making
it a new package and distributing it ensures larger set of
people use it and contribute to it. This can also be used
by any consumer/user to build their own environment for glusterfs
regression testing which is today limited only to 'upstream'
'glusterfs' releases and build.gluster.org
Change-Id: I4f7e9fd1c49982dcf0d788ef6a83ffe895a956ac
BUG: 764966
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5674
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 28bab92411dc6e6abd55a9d707ca8a949086f24f
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Sep 17 19:16:50 2013 -0700
distribute: Rebalance should provide even disk space distribution
Earlier disk space check had an issue which didn't
provide the needed functionality to avoid migration
when the destination had lesser available space,
scenario we need to avoid is stated below :
During rebalance `migrate-data` - Destination subvol experiences
a `reduction` in 'blocks' of free space, at the same time source
subvol gains certain 'blocks' of free space. A valid check is
necessary here to avoid errorneous move to destination where
the space could be scantily available.
This patch provides a proper fix in place by subtracting
necessary file blocks from destination and adding those blocks
to source.
Change-Id: I9c7840716a4256ef614ffc0fbfd9f2b456ac28c8
BUG: 982919
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5961
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c330d8dd2f9638f698407d496991aa96e69c8dca
Author: meghana <mmadhusu@redhat.com>
Date: Tue Aug 20 15:13:42 2013 -0400
NFS : Coverity Fix.
NFS defects reported by Coverity run are fixed.
Change-Id: Ib66847e8e66fb4a06b312c80814f9eafb032eba2
BUG: 996390
Signed-off-by: meghana <mmadhusu@redhat.com>
Reviewed-on: http://review.gluster.org/5660
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Varun Shastry <vshastry@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 109792b1e2d85d52d53a4b8f6fdbbc919f3dc109
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Sep 13 18:48:38 2013 +0530
cli/glusterd: improve rebalance fix-layout status reporting
Problem:
Currenly the CLI rebalance status command output does not indicate the
'type' of rebalance, i.e. whether a full rebalance or only a fix-layout
was carried out.
Fix: After the rebalance status of all peers is received by the
originator glusterd, alter it to reflect the type of rebalance
before passing it on to the CLI process.
Change-Id: I1940ffda0d36e25e5b33c84a0ea210394cc9e1d3
BUG: 1004744
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/5826
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 944353ffabd335b1effe2253450afd14c0fc29ea
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Feb 23 13:08:37 2013 +0530
cluster/afr: Have common inode-write-fop cbk
Change-Id: Ia7b324b86d6a7051d187106d7a060155e77defc5
BUG: 910217
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5238
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d65d211ba6e98f97fb1ba60a78f8223d3bb8c32e
Author: Timothy Asir <tjeyasin@redhat.com>
Date: Wed Sep 11 13:50:40 2013 +0530
cli: add aggregate status for rebalance and remove-brick status xml output
Add aggregate status information in <aggregate> section of gluster volume
'rebalance status' and 'remove-brick status cli xml output.
The aggregate status determined based on the most critical level
and the aggregate status will have 'Complete' only when all
individual status are 'Complete'.
Change-Id: Ie805b9dd52fd82fd277c3da9ee91cc8b6dea8212
BUG: 1006813
Signed-off-by: Timothy Asir <tjeyasin@redhat.com>
Reviewed-on: http://review.gluster.org/4950
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit b6144f53222746abd16eba63585fcec0dc2ff346
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Sep 10 15:33:00 2013 +0530
glusterd: Don't reset rebalance status on add-brick
The rebalance status was being reset to 'Not started' when add-brick was
performed. This would lead to odd cases where a 'rebalance status' on a
volume would show status as 'not started' but would also include the
rebalance statistics. This also affected the showing of asynchronus task
status in 'volume status' command.
By not resetting the status prevent the above issues from happening.
Since we use the running/not-running of the rebalance process as the
check when performing other operations we can safely leave the rebalance
stats collected on an add-brick.
Change-Id: I4c69d9c789d081c6de7e7a81dd0d4eba2e83ec17
BUG: 1006247
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5895
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6faa43918f75783d3d843c40f1b5dca76bb84094
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Sep 17 19:27:57 2013 -0700
build: AM_PATH_XML2 needs proactive check
AM_PATH_XML2 needs check for its existence using
aclocal macros - to avoid problems like below when
libxml2 development libraries are not installed
--------------------------------------------------
... GlusterFS autogen ...
Generate gf-error-codes.h ...
`gf-error-codes.h' -> `libglusterfs/src/gf-error-codes.h'
Running aclocal...
configure.ac:524: warning: macro `AM_PATH_XML2' not found in library
Running autoheader...
Running libtoolize...
Running autoconf...
configure.ac:524: error: possibly undefined macro: AM_PATH_XML2
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
Running automake...
--------------------------------------------------
Change-Id: Ife463c34c45babc1c4c0ed6e8128b5c43419b9b9
BUG: 947226
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5962
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e236bdc3001fec39a97583aba5e6c03f55b603ce
Author: Anand Avati <avati@redhat.com>
Date: Tue Sep 17 16:45:03 2013 -0700
Revert "cluster/distribute: Rebalance should also verify free inodes"
This reverts commit 215fea41a96479312a5ab8783c13b30ab9fe00fa
Realized soon after merging, that this patch is actually useless.
Checking for inode utilization on dst relative to src is of no use
because dst is already storing linkfile and inode is already consumed
no matter what. We might as well perform the rebalance and save on an
inode on the src node.
Change-Id: I7b8b8d35d9063a710e1bee1c7c6c7739fcc45ad4
Reviewed-on: http://review.gluster.org/5960
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Anand Avati <avati@redhat.com>
commit 3cead0dd33b6ae9974112391b45e40d9640ef77e
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Sep 16 22:36:10 2013 -0700
cluster/distribute: Rebalance should also verify free inodes
Currently during `MIGRATE_DATA` we never verified about the total
inode usage among new and old bricks. Such checks are available for
disk space usage but it is also needed for inodes during data
migration. Such a check leads to uniform outcome of file distribution
upon rebalance.
Patch provides:
- Check dst_inodes < src_inodes, a friendly `warning` message to
indicate we have to ignore such an attempt
- Rename __dht_check_free_space() --> __dht_check_free_space_and_inodes()
Change-Id: I7bc4dd8b507883f0fb836300e99f0bb083493f5f
BUG: 982919
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5948
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit dfd144bc133ee07c4311fc7b6d3dc0fba5f03635
Author: Anand Avati <avati@redhat.com>
Date: Tue Sep 3 18:13:27 2013 -0700
fuse-bridge: enable --fopen-keep-cache based on FUSE_AUTO_INVAL_DATA.
If kernel supports FUSE_AUTO_INVAL_DATA then it is safe(r) to turn on
--fopen-keep-cache mode by default. Users report significant improvement
in perf by enabling the mode.
Change-Id: Icf9df4b7b43950d7e25302d9c2a1a7d14571a9a9
BUG: 990744
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5770
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
commit c025d936d53bbf54652034db9cabe3b4a2b57cdb
Author: Anand Avati <avati@redhat.com>
Date: Thu Sep 12 08:16:40 2013 -0700
rpcsvc: allocate large auxgid list on demand
For rpc requests having large aux group list, allocate large list
on demand. Else use small static array by default.
Without this patch, glusterfsd allocates 140+MB of resident memory
just to get started and initialized.
Change-Id: I3a07212b0076079cff67cdde18926e8f3b196258
Signed-off-by: Anand Avati <avati@redhat.com>
BUG: 953694
Reviewed-on: http://review.gluster.org/5927
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit bc695156b4a225007a6ee65f51b557be16e8656c
Author: Anand Avati <avati@redhat.com>
Date: Wed Aug 28 18:05:03 2013 -0700
gfapi: implement a minimial glfs_fini()
At the very least, we should PARENT_DOWN on the currently active
graph and disconnect ourselves from glusterd.
Further cleanups underway.
Change-Id: I9276686a84b0975b5ce272b4cbec1b80920d5c5c
BUG: 1004519
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5788
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit f69ffd4da1c33bfcd1861787b1d26c13a004aeea
Author: Anand Avati <avati@redhat.com>
Date: Wed Sep 11 00:49:57 2013 -0700
gfapi: use native STACK_WIND for read _async() calls
There is little value in using synctask wrappers for async IO
requests, as STACK_WIND is asynchronous by nature already.
Skip going through synctask for read/write async calls.
Change-Id: Ifde331d7c97e0f33426da6ef4377c5ba70dddc06
BUG: 1009134
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5897
commit f3d25e376b35469a06baab06ac96ba87b3ade297
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Sep 16 14:18:53 2013 -0400
qemu-block: support readdirp
Support the readdirp fop in qemu-block to ensure that image files
are handled correctly when readdirp is enabled. E.g., without
readdirp support, incorrect stat data for formatted files can be
reported back (and cached) via the client.
BUG: 986775
Change-Id: Ibc4bd0b42548953ebe30832f3d853bb68095f0ac
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5946
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ce2003080db9eef0e40dc07d09d166f606827815
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Aug 20 18:09:22 2013 +0530
glusterd : Blocking invalid values for geo-rep config options
Change-Id: Ia9ee44763a9c2798b26d3225bf03a974d7ece21f
BUG: 998962
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5666
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5ac73c80a1a3105a91fb13156624df7e7554fc89
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Sep 16 14:02:25 2013 +0530
geo-rep: retry in case of ENOENT errors in entry creations
Change-Id: I8961633a7371c941a3feee44c949d5c934eca998
Original-Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 847839
Reviewed-on: http://review.gluster.org/5933
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
commit 2e9f0b73412a84753aea5956fa2cf420f49fd592
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Sep 16 11:41:32 2013 +0530
mount/fuse: Implement forget in cbks for fuse.
With the introduction of inode_ctx_set in fuse as part of 2991503d014,
forget cbk gets called for fuse xlator. Though nothing needs to be done
inf forget_cbk, excessive log messages of the following kind are observed:
[2013-09-16 06:09:50.758063] W [defaults.c:1331:default_forget]
(-->/usr/local/lib/glusterfs/3git/xlator/mount/fuse.so(+0xa1f2) [0x7f51432781f2]
(-->/usr/local/lib/libglusterfs.so.0(inode_unref+0x3c) [0x7f5144e5
816c] (-->/usr/local/lib/libglusterfs.so.0(+0x2d061) [0x7f5144e58061]))) 0-fuse:
xlator does not implement forget_cbk
This patch prevents such log messages from being seen.
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
BUG: 979910
Change-Id: Ie5874138f46822b10ff4213bd1134d78330ec460
Reviewed-on: http://review.gluster.org/5932
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 0d7e2fe94ec9af6307581cc0e934d28e4cafa73f
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Sep 4 11:50:40 2013 +0530
cli,glusterd: Task parameters in xml output
This patch introduces task parameters for the asynchronus task shown in
volume status. The parameters are only given for xml output. The
parameters shown currently are,
- source and destination bricks for replace-brick tasks
......
<tasks>
<task>
<type>Replace brick</type>
<id>3d1a1005-9d2e-4ae0-bd62-577bc1d333a3</id>
<status>1</status>
<params>
<srcBrick>archm:/export/test4</srcBrick>
<dstBrick>archm:/export/test-replace1</dstBrick>
</params>
</task>
</tasks>
......
- list of bricks being removed for remove-brick tasks
......
<tasks>
<task>
<type>Remove brick</type>
<id>901c20ca-0da2-41de-8669-5f0caca6b846</id>
<status>1</status>
<params>
<brick>archm:/export/test2</brick>
<brick>archm:/export/test3</brick>
</params>
</task>
</tasks>
......
The changes for non-xml output will be done in a subsequent patch.
Change-Id: I322afe2f83ed8adeddb99f7962c25911204dc204
BUG: 916577
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5771
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 70b9adbeef5dc49fda54a35ade9c524732f8d6d8
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Sep 11 13:44:10 2013 +0200
qemu-block: fix building from distribution tarball when glib2-devel is installed
Building RPMs from a 'make dist' tarball fails when qemu-block is
enabled. Enabling is done automatically when the glib2 development files
are available (enabled by ./configure).
Manual building with:
$ ./autogen.sh && ./configure && make dist && rpmbuild -ta *.tar.gz
Building in mock works fine, glib2-devel is not installed by default so
the qemu-block xlator gets disabled. This change also adds glib2-devel
to the BuildRequires in the glusterfs.spec file, causing the qemu-block
xlator to be built by default, and included in the glusterfs RPM.
Change-Id: Ibb73628772586d9e07bbfde7a8ff2fc973489086
BUG: 986775
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5896
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 94be26aa825f286c4d2535422d20225fd016b882
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Sep 12 12:15:10 2013 +0200
tests/basic/rpm.t: run mock builds inside the current working directory
When running multiple mock builds at the same time, the space
requirements under /var/tmp increases as well. Not all systems (like
build.gluster.org) have enough free space in /var/tmp to host two
mock-roots, which causes building to fail randomly.
Change-Id: Iff1064d01893fb35ef59650d4373105068b5d3f7
BUG: 1006269
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5899
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b1dca55b400a6cdec17b30870c18fe848120655d
Author: Aravinda VK <avishwan@redhat.com>
Date: Fri Aug 30 14:37:03 2013 +0530
cli: Add statusStr xml tag to task list and rebalance/remove brick status
New xml tag statusStr added to following gluster cli commands
gluster volume status all --xml (For Task status)
gluster volume rebalance <VOLNAME> status --xml
gluster volume remove-brick <VOLNAME> <BRICK1..> status --xml
Example(volume status all):
<task>
<type>Rebalance</type>
<id>82d8d122-8738-4144-8507-d93fc98b61df</id>
<status>3</status>
<statusStr>completed</statusStr>
</task>
Example(volume rebalance <VOL> status)
<node>
<nodeName>localhost</nodeName>
<files>0</files>
<size>0</size>
<lookups>0</lookups>
<failures>0</failures>
<status>3</status>
<statusStr>completed</statusStr>
</node>
Also modified task status as string instead of showing number
in gluster volume status all
Example:
Status of volume: gv1
Gluster process Port Online Pid
------------------------------------------------------------------------------
Brick sumne.sumne:/gfs/b1 49154 Y 15489
Brick sumne.sumne:/gfs/b2 49155 Y 15493
NFS Server on localhost N/A N 15913
Task ID Status
---- -- ------
Rebalance 82d8d122-8738-4144-8507-d93fc98b61df completed
BUG: 1003521
Change-Id: Ib283016af4c18132fb13fb33d44075782d77823c
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/5739
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ee99fd935f9888e15c38798eedb3b45f51ce41eb
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Sep 11 01:26:13 2013 +0530
mgmt/glusterd: Update sub_count on remove brick
Change-Id: I7c17de39da03c6b2764790581e097936da406695
BUG: 1002556
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5893
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f5d5b0a76ba68588fafe8239b1ddaa0f37d97e0f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Sep 6 15:49:14 2013 +0530
doc: Steps to recover from split-brain
BUG: 1006776
Change-Id: I6f4bffe992758b2889df9ebfe117834dabe5c1cf
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/4216
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 34d107eb15801f71de4eb181f10b216d4a248d74
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Sep 10 19:13:47 2013 +0530
rpc/rpc-lib: rpcsvc should reply when rpc_err is set
Problem:
When requests are received on a connection before setvolume
is done, creating frame from the requests fail because there is
no association of the transport with the conn(i.e. xl_private).
xl_private is set only on set_volume. In such cases error response
is not sent from server xlator to that request because of which
operations on mount point are hanging.
Fix:
Set actor return value to RPCSVC_ACTOR_ERROR so that response is sent
even in these cases.
Change-Id: I74d7bc6849fde6c734008d67c1f4bc9d9f7a84f9
BUG: 1006367
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5892
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c03c1d1f4662397fc27809858df5d17f25859d35
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Sep 4 13:06:57 2013 +0530
cli: Fix 'status all' xml output when volumes are not started
CLI now only outputs one XML document for 'status all' only containing
those volumes which are started.
BUG: 1004218
Change-Id: Id4130fe59b3b74475d8bd1cc8134ac59a28f1b7e
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5773
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7fb4e2bea68d389a30a0ce25c5d8a08bccac5d40
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Sep 6 10:12:55 2013 -0400
tests/basic/rpm.t: run mock builds in parallel
save about six minutes per regression by building in parallel
Change-Id: Iaf6fa545e20b0322b10e9e4ab7cc3d4254a0ece5
BUG: 1006269
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5845
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 3236d011f742914b11245f6bc926f2ac21018a0d
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Aug 28 17:16:03 2013 +0530
glusterd: Allow bumping down a peer's op-version during probe
Earlier, a peer running a higher op-version couldn't be probed into a
cluster running at a lower op-version. This created issues when trying
to expand an upgraded cluster. This patch changes this behaviour.
The cluster no longer rejects a peer being probed if its op-version is
higher than the cluster op-version. The peer will reduce its op-version
if it doesn't have any volumes. If the peer contains volumes and needs
to reduce its op-version, it fails the handshake and the probe fails.
Change-Id: I12c6c873922799e1557b7184e956baea643d0dea
BUG: 1005038
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5715
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 73d75e0b9735b0c7bd32d19e9e39569c2ce87fba
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Sep 10 12:56:55 2013 +0530
glusterd: Added missing MY_UUID conversion in gsync staging
Change-Id: Ia4bf607e044d50636fb0a599a2ff91059f5b17aa
BUG: 1006177
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5887
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c99415dc0738f1c77a07c47cb85561ca2fab344a
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Mon Sep 9 03:08:08 2013 -0700
glusterfsd: use-readdirp w/o arguments should not turn off readdirp
`use-readdirp` has an optional argument in argp -
specifying just `--use-readdirp` command line should not
'turn off' readdirp, since that undermines the meaning
of such an argument.
Change-Id: I965d87e29bd0d61997d9be96fa698e270a2ee173
BUG: 983477
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5851
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 09f18eee83e51d185ff64f0614d0e32fc1e896c3
Author: Anand Avati <avati@redhat.com>
Date: Thu Aug 29 23:35:23 2013 -0700
cluster/dht: assign layout onto missing directories too
The current self-healing algorithm is ignoring missing directories
for assigning new layout. When lookup() is racing against mkdir()
or when self-healing a half-done mkdir(), the layout assignment split
must happen based on the final number of directories, and not the
currently existing number of directories (because we finish mkdir()
of missing directories before hash layout assignment).
Without this fix, concurrent mkdir() and lookup() will step on
each others feet, create a messed up layout on disk, and end up
with different in-memory layouts.
Once two clients have different in-memory layouts, creation of
subdirectory will not arbitrate on the same hashed subvolume and will
result in GFID mismatch of the sub-directory.
Change-Id: Ia47acad67c265060405984c822b4d37512b9dbb3
BUG: 907072
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5849
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Peter Portante <pportant@redhat.com>
Tested-by: Peter Portante <pportant@redhat.com>
commit 81204e734f5abab1a6e2fb67a89a473c9bdac523
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Sep 6 12:08:19 2013 +0200
rpm: fix "warning: File listed twice: .../glusterd.info"
Commit a482e422 added glusterd.info to the %files section of the
glusterfs-server package. However, this file was listed already. This
causes the following warning when building the RPMs:
warning: File listed twice: /var/lib/glusterd/glusterd.info
Merging the attributes for /var/lib/glusterd/glusterd.info into one line
prevents this warning.
Change-Id: I0d518ec186a8725dc4c5cba00b60da83fdadf103
BUG: 1005161
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5836
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5dcb7c605d171c2e8b9ee53a8d52cb5a9793ad2a
Author: Anand Avati <avati@redhat.com>
Date: Wed Aug 28 18:38:26 2013 -0700
parser: make the parser thread safe.
The volfile parser thread safe by guarding the parsing phase
in a mutex. Thread safety becomes a problem when there are multiple
glfs_t objects created by gfapi and all of them potentially parse
the respective volfiles at the same time.
Change-Id: I4376019c4956994b72397ab36e6ac3ce849797ec
BUG: 1004519
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5790
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.org>
commit a37111c446cf33bffd792458c8fc8b634ed12b00
Author: Poornima <pgurusid@redhat.com>
Date: Fri Sep 6 16:13:30 2013 +0530
gfapi: store the open/create flags in fd_t object
The flags passed on to open and create calls were not being saved
in the fd_t object, hence the fd migration was failing.
Change-Id: I486bb818477fe4c393d64a711534a082162a0e53
BUG: 1005159
Signed-off-by: Poornima <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/5837
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5115277dc6e94c072548d878389bdf43a902fea3
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Jul 24 13:16:08 2013 -0700
glusterfsd: Round robin DNS should not be relied upon with config service availability for clients.
Backupvolfile server as it stands is slow and prone to errors
with mount script and its combination with RRDNS. Instead in
theory it should use all the available nodes in 'trusted pool'
by default (Right now we don't have a mechanism in place for
this)
Nevertheless this patch provides a scenario where a list of
volfile-server can be provided on command as shown below
-----------------------------------------------------------------
$ glusterfs -s server1 .. -s serverN --volfile-id=<volname> \
<mount_point>
-----------------------------------------------------------------
OR
-----------------------------------------------------------------
$ mount -t glusterfs -obackup-volfile-servers=<server2>: \
<server3>:...:<serverN> <server1>:/<volname> <mount_point>
-----------------------------------------------------------------
Here ':' is used as a separator for mount script parsing
Now these will be remembered and recursively attempted for
fetching vol-file until exhausted. This would ensure that the
clients get 'volume' configs in a consistent manner avoiding the
need to poll through RRDNS.
Change-Id: If808bb8a52e6034c61574cdae3ac4e7e83513a40
BUG: 986429
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5400
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c649fe0bf9fbca28df457cf84a156c5899a8eb8c
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Sep 6 06:49:09 2013 -0700
Revert "tests/basic/rpm.t: run mock builds in parallel"
This reverts commit 91e8103794349ebdd578b77987a089456a59c52b
Reverting as regression tests are failing after this merge.
Change-Id: I9dcd430b2f9a431c3c01deab1a205aed297216a3
Reviewed-on: http://review.gluster.org/5842
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d0e3cc32473ce2c09b64eabd9cb087c31fd15553
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Sep 5 14:19:00 2013 -0400
tests/basic/rpm.t: run mock builds in parallel
save save about five minutes per regression
Change-Id: I75d91cfef63347ca756b9e1fedcb697e9537edc0
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5828
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 33ada507fa5f5ea0f79190d5c8aa9c150c86f110
Author: Anand Avati <avati@redhat.com>
Date: Tue Sep 3 16:01:41 2013 -0700
gfapi: apply an upper bound on nested symlink resolution
In case of nested symlink resolution, implement an upper
bound on the number of such nested levels the resolver will
descend. This limit is arbitrary, and set to 2048 nested
levels.
Change-Id: I264e5bd60d317eda97f4e6f49bd5d8694f8664a9
BUG: 1004100
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5768
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7d342aaeaa5e3c8ed5dc857d2a3d23359ba8389a
Author: Anand Avati <avati@redhat.com>
Date: Tue Sep 3 15:18:26 2013 -0700
glusterfs, gfapi: fix symbol clash
The callback structures in both protocol/client and glusterfsd,
gfapi used the same name for the actor table - gluster_cbk_actors.
CBKs are required only for the management connection, and the
actors of protocol/client are NOP functions. This supposed-to-be
NOP function dispatch tabble is actually ending up pointing to
the actor table of glusterfsd or gfapi.
These functions, even though set wrongly, are not even expected
to be called through the protocol/client callback path. Glusterd
however sends the FETCHSPEC (and other) notify callbacks to *all*
connected clients unconditionally, and there is a small period
of time when protocol/client is connected to glusterd for
PORTMAP query. If the FETCHSPEC callback notify is issued in
this window of time, we end up calling the wrong actor in the
client side resulting in a crash.
Change-Id: I605ff7df64c7faf4607369bbf275aedec28e1778
BUG: 1004091
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5767
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 446fe9cb1390ae6dd3769dbc7bc36d2bcc2fa7d3
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Aug 13 11:02:21 2013 +0530
gsyncd / geo-rep: use the correct virtual xattr to collect 'gfid'
Change-Id: Ifea32ad1b2695f1668428fae6b263014bf320b70
BUG: 996379
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5589
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit c53d8a94b8b919785bd8dd419bc706543a248d57
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Aug 26 18:14:48 2013 +0530
gfid-access: Error logs for ga_newfile_parse_args
Change-Id: I7aab98a70793bee936272f0b795f4c22c3733dd2
BUG: 1001055
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5705
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit b4653c320a055a2a9d11c3d60a6d497c7731e2bb
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Aug 29 22:57:44 2013 +0530
gsyncd / geo-rep: distributify slave
commit fbb8fd92 introduced slave distributification but had
some problems (monitor would crash upon gsyncd start). This
patch fixes the issue and makes code more pythonic ;)
Change-Id: I2cbf5669d81966046a4aeeb4a6ad11a947aa8f09
BUG: 1003807
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5761
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d07ea36dc2ed805411421f6b33a9e46410525717
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Aug 28 13:58:16 2013 +0530
gsyncd / geo-rep: Fix "regular file" overloading link()
... missing entry2pb() call before going ahead with create.
Change-Id: I48de4df3f0ea6c789c9eeb10cd332ab461f3c868
BUG: 1003805
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5760
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 977bd9547791bf55d7f392913ff6851d2d9b9034
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Aug 28 01:33:11 2013 +0530
geo-replication: fix the logic of choosing the remote node to sync
Change-Id: Ie15636357d89e94b6bfad0e168b1fcad53508c47
BUG: 1003807
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5759
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b93496bab9ecab52fa6ed671fcbace0bc113232e
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Aug 27 12:20:30 2013 +0530
gsyncd / geo-rep: maximum number of retries per changelog
With entry retries MAX_RETRIES is the threashold for the number
of times we retry a changelog. After hitting this limit, the
changelog is marked as processed after warning for incompleteness
in the log.
Change-Id: I777b71b4cdaa63335d9c936f2d64e5c0264a0f26
BUG: 1003803
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5758
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 81144b045337f9a0182328088cdd7701aaacc995
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Aug 27 13:02:00 2013 +0530
gsyncd / geo-rep: fix hardlink creation on slave
Change-Id: I20fbd518bf519cbf2362b97aeb8be7c3b105087a
BUG: 1003805
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5757
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bd7a8e60c8e9cee2bef3d71faac6aac9d3ba09a2
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Aug 27 14:02:24 2013 +0530
gsyncd / geo-rep: handle ENOENT during readlink()
Change-Id: I8611122fda63ea496ad4491473ecabe96bf19cfa
BUG: 1003803
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5756
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a54a62bbbe4ef4439799bc5027accaa9eeac6899
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Aug 21 16:33:41 2013 +0530
gsyncd / geo-rep: overload rename with an unlink
This is certainly a "hack" for cases when after a rename
the gfid is unlinked (which is now pointed by a different
pargfid/basename). This was osbserved when a file edited
(uisng vi/vim) on the glusterfs mount point which has a
geo-replication session running.
Change-Id: I0a5d9f0f549aa4403671fa1f11e95510142e5720
BUG: 1003800
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5755
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 17507f9d94a4542da888309651812dd843feb055
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Aug 21 20:38:09 2013 +0530
gsyncd / geo-rep: fix "regular file" overloading rename
entry operation on the slave was using source parent gfid
and basename when renames are overloaded to use regular file
creation. This patch fixes the issue by using the destination
parent gfid and basename for these cases.
Change-Id: I1a4e8df7f07905224ce44ef5abd6f180234285ab
BUG: 1003800
Tested-by: Amar Tumballi <amarts@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5754
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9ee51550aedadebb56f001158d7f10332e935228
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Aug 13 11:09:31 2013 +0530
gsyncd / geo-rep: "disjoint" cascading geo-replication sessions
Slave's xtime is now stored on the master itself (and that too only on
the root), which implies it cannot be propogated to the cascaded slave.
Thus the intermediate master now makes use of it's own volume information
to propogate volume-mark and xtime.
On starting Geo-Replication "geo-replication.ignore-pid-check" marker
option is enabled, which is an override for the client-pid check in
marker. This options triggers marker update only for geo-replication
auxillary mount (client-pid == -1). Since gsyncd not does setxattr()
directly on the bricks, this option won't trigger a chain of spurious
metadata updates that would need to be processed by gsyncd.
Change-Id: If50c5ef275dfb6b4ff4fd35be2565587e2fdf3e1
BUG: 996371
Original Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5592
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7618466b2afa7e4e3c6763734424c7d3e5fb9ace
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Aug 12 22:18:53 2013 +0530
features/marker: force xtime updates (configurable) for client-pid = -1
This is required by Geo-Replication that does auxillary mount
with client-pid as -1 (which has special treatment at specific
places in GlusterFS), to trigger xtime updates on the intermediate
master in a cascading setup.
Marker too had a check to "not" mark updates for geo-replication's
auxillary mounts. With the new geo-replication design, xtimes are
not set by the master on the slave for all entities. Due to this
cascading setups were broken.
This patch introduces "geo-replication.ignore-pid-check" option
as a "override" for the client-pid check for gsyncd's client-pid.
When this options is enabled, marker start "marking" even if the
updates are from the special client.
Geo-Replication on the detection of itself being an intermediate
master, enables this option.
Change-Id: I9f7140edd12fef5480595ee0f93f35b94cdb8345
BUG: 996371
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5591
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit aabefc5c8200c3f8d59adaaea4195bec66f3ddbc
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Aug 7 16:10:25 2013 +0530
gsyncd / geo-rep: introduce "recovery" mode
This mode introduces and optimized recovery of master,
used during failover-failback cases. Files are only
transferred if they are identified as changed on the slave.
A normal failback mechanism would be just to reverse the
direction of geo-replication syncing. Doing this is the
correct way but could be time consuming. "Recovery" mode
optimizes this by identifying files (as skipping them) duing
the one-shot crawl.
NOTE: Use this mode when you are _absolutely_ sure that the
namespace on the master is intact, ie. there is number of files
in master is equal to the number of files in the slave, but the
slave was written to (after a failover) when master was brought
back up.
- gluster volume geo <MV> <SLAVE>::<SV> config special_sync_mode recover
- gluster volume geo <MV> <SLAVE>::<SV> start
Change-Id: Idb698949e4e86698b15d04a35d33095562f51714
BUG: 994462
Original Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5515
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9267d261c4eaba6339ee7ad9a462e35909d6d0f8
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Aug 12 22:15:58 2013 +0530
gsyncd / geo-rep: remove deprecated code!
This includes "xtime" base crawling and syncing,
"Blind" and "Wrapup" mixins for failover/failback.
Change-Id: I9bc8695dc1c19b1261332f64621305dff2929b32
BUG: 994461
Original Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5514
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a620df8df43eecc03a882ea464a3adbd46b3cf48
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Aug 7 11:53:06 2013 +0530
gsyncd / geo-rep: fix regular file creation on rename
On creation of a regular file on the slave (this happens
when an unlink()/rmdir() operation is performed on master
after a rename() or a link().
This patch fixes the regular file creation on the slave when
the above mentioned series of operation occurs. entry_ops()
on the slave for a rename() was missing the stat() information.
Change-Id: Idb80c6b3e27c1797dade1113ac8ce920db9c740c
BUG: 994353
Original Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5509
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f44a9390e3e975b7673f51cfbbabfc87c4ce4482
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Aug 12 22:09:45 2013 +0530
glusterd/cli: Geo-Replication "status detail" cmd
Provides detailed status info in the following format
MASTER <master-vol> SLAVE <slave-vol>
NODE HEALTH UPTIME FILES SYNCD FILES PENDING BYTES PENDING DELETES PENDING
-----------------------------------------------------------------------------------
This patch introdues "status detail" command to show crawl related
information in CLI. These values are "pulled" from gsyncd when
"status detail" is executed.
Change-Id: I1fdaf7180eacce054a864d34971dc160bd7301e1
BUG: 990420
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5590
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 182ee5e7e30564abb32d9da6200ea0322c26f1e5
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jul 31 13:01:30 2013 +0530
gsyncd / geo-rep: Introduce basic crawl instrumentation
This patch extends the persistent instrumentation work done by
Aravinda (@avishwa), by introducing a handfull of instrumentation
variables for crawl. These variables are "pulled up" by glusterd
in the event of a geo-replication status cli command and looks
something like below:
"Uptime=00:21:10;FilesSyned=2982;FilesPending=0;BytesPending=0;DeletesPending=0;"
"FilesPending", "BytesPending" and "DeletesPending" are short-lived
variables that are non-zero when a changelog is being processes (ie.
when an active sync in ongoing). After a successfull changelog process
"FilesPending" is summed up into "FilesSynced". The three short-lived
variabled are then reset to zero and the data is persisted
Additionally this patch also reverts some of the changes made for
BZ #986929 (those were not needed).
Change-Id: I948f1a0884ca71bc5e5bcfdc017d16c8c54fc30b
BUG: 990420
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5441
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f89768bcdd33fd2b6e9228aafa10f1550bc68f47
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jul 31 19:40:28 2013 +0530
gsyncd / geo-rep: periodically set slave xtime on slave
setting the slave xtime on the slave (after each changelog/xsync)
crawl helps in two things:
* effective recover of master (failover/failback)
* cascading setup - instances when the session from intermediate
master session is stopped, data is put on
the master -> slave sesssion and then the
cascading session is started again.
Change-Id: Ifae10a6ac09dc0d17707c3b5a3090bcf1efec8b6
BUG: 990900
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5451
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 444662fb72733d357b57268b3f6b6efd913da28f
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jul 30 16:18:02 2013 +0530
glusterd: Added op-version checks to geo-rep commands.
Added op-version checks to all geo-rep commands. Min
op-version should be 2.
Change-Id: I942d897404e11e4d53123409731ba5cd252668fe
BUG: 847839
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5732
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bc77986a7ed5a9eba1461bce3f57e0e19f41ebf7
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Aug 21 12:53:11 2013 +0530
glusterd/gverify: Check for passwordless ssh in gverify.
Change-Id: I8c2d398114ad4534bcc052f9a5be8bbb2e7e2582
BUG: 999531
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5677
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b3ad82a78a93c7683c06ba79618a07602e630308
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Aug 20 13:36:10 2013 +0530
glusterd: Allowing root@hostname::slave georep sessions to be created.
non-root@hostname::slave-vol geo-rep sessions are not supported.
only hostname and root@hostname sessions are supported, and are
treated as the same.
Change-Id: I87551e1bd4ff4e0e6520c34eb3d944587cc65476
BUG: 998933
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5659
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 65cecef78abd8635a79e0fb8626b684122848666
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Aug 7 17:09:17 2013 +0530
glusterd/gverify.sh: Stops session being created with invalid slave details
create force will fail with proper message, if the ip is not
reachable, or is unable to fetch slave details.
Change-Id: I44a3ba777b37702ffd0e48e9cb46c51e293327d4
BUG: 988314
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5516
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fe0b3aac5ac1ead4dce4a90a4c8fb8725050efc3
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Aug 1 13:22:34 2013 +0530
gverify/glusterd : Added check to warn the user of existing files in slave volume
Change-Id: I41c9fb44613386189d9f3c090729f4ded8e4dea8
BUG: 990997
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5453
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 54a44ea61e4c4d84d9ac2f31d88a223a8783b0d5
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri Aug 2 15:34:00 2013 +0530
glusterd: Saving geo-rep session details in a more specific path
Now saving the session details in
/var/lib/glusterd/geo-replication/<mastervol>_<slaveip>_<slavevol>
repo to distinguish between two master-slave sessions where the
slavename is same across two different clusters.
Change-Id: I57c93f55cc9bd4fe2bffe579028aaf5e4335b223
BUG: 991501
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5488
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8a7e0d37bac96cdb49363aaf0aa27b8b86dfa9a9
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Aug 21 16:28:41 2013 -0700
geo-replication: Use a md5 based unique control path
A hostname fqdn can be of length 255 according to RFC1123
------------------------->
/usr/include/bits/posix1_lim.h:#define _POSIX_HOST_NAME_MAX 255
<-------------------------
On linux this length is 64
------------------------->
/usr/include/bits/local_lim.h:#define HOST_NAME_MAX 64
<-------------------------
When a given hostname is > 45 (characters) - SSH fails with
-------------------------->
"ControlPath too long for Unix domain socket".
<--------------------------
Indicating that the total length of ControlPath which is
on linux should be 108
------------------------->
/usr/include/linux/un.h:#define UNIX_PATH_MAX 108
<-------------------------
This leads to "faulty" geo-replication status.
This patch brings in a new file called manifest which carries
given a geo-rep session some unique information - with which
a unique `md5` is generated in a 32length digest, this ensures
that we don't exceed UNIX_PATH_MAX limitations instead we use
a conservative approach and still be able to provide a unique
socket path.
Change-Id: I3a6a27d605d751a86e7c82eace4561d9b0134fe1
BUG: 990330
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5681
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
commit 09939fa8ac2df03efee74a286074cd5c09332d75
Author: Brian Foster <bfoster@redhat.com>
Date: Tue Jul 2 10:47:00 2013 -0400
performance/readdir-ahead: introduce directory read-ahead translator
This is a translator to improve the performance of typical,
sequential directory reads (i.e., ls). readdir-ahead begins
preloading the contents of a directory on open and serves readdir
requests from the preloaded content. readdir-ahead is currently
implemented to only handle the single threaded directory read
case.
readdir-ahead is currently disabled by default. It can be enabled
with the following command:
gluster volume set <volname> readdir-ahead on
The following are results of a getdents test on a single brick
volume.
Test info:
- Single VM, gluster client/server.
- Volume mounted with native client using --gid-timeout=2.
- getdents on single directory with 100k 0-byte files.
Test results:
- !readdir-ahead
read 3120080 bytes from offset 0
3 MiB, 4348 ops, 0:00:07.00 (416.590 KiB/sec and 594.4737 ops/sec)
- readdir-ahead
read 3120080 bytes from offset 0
3 MiB, 4348 ops, 0:00:03.00 (820.116 KiB/sec and 1170.3043 ops/sec)
BUG: 980517
Change-Id: Ieceb9e1eb47d1d5b5af8da2bf03839537364653f
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4519
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ef476732e508ce113ebc1c49259ea94ecd6d3f31
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Sep 3 16:30:33 2013 +0530
mgmt/glusterd: Regenerate client volfiles during upgrade
Change-Id: I1442bc1d115a9c6ecf139a0ca9da74d07e0fe928
BUG: 1003855
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5764
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c2f928dc9592e1f7ae77342ea50fd07286fa5a2e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Sep 3 13:30:13 2013 +0530
cluster/afr: Set size based source only when sizes are unequal
Change-Id: I18583f14edf1011401be15744371e2a6b79d75cc
BUG: 1003842
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5763
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2ee6851b87b0dcaf0bc5e9a847250c2cad4fbc38
Author: Anand Avati <avati@redhat.com>
Date: Tue Aug 27 05:02:20 2013 -0700
afr: make NOP truncate/ftruncate efficient
If truncate/ftruncate is called with the offset as the current size
of file, then skip the durability fsync and unwind quickly.
Change-Id: I0baec68d96c6d4d8217d33bd9738f7ed0d1b40c5
BUG: 958118
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5737
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9c11718f9ff35f340358e940632d54fd780f03a6
Author: Anand Avati <avati@redhat.com>
Date: Tue Mar 5 14:48:28 2013 -0800
features/qemu-block: support for QCOW2 and QED formats
This patch adds support for internals snapshots using QCOW2 and
general framework for external snapshots (next patch) with
QCOW2 and QED.
For internal snapshots, the file must be "initialized" or
"formatted" into QCOW2 format, and specify a file size.
Snapshots can be created, deleted, and applied ("goto").
e.g:
// Format and Initialize
sh# setfattr -n trusted.glusterfs.block-format -v qcow2:10GB /mnt/imgfile
sh# ls -l /mnt/imgfile
-rw-r--r-- 1 root root 10G Jul 18 21:20 imgfile
// Create a snapshot
sh# setfattr -n trusted.glusterfs.block-snapshot-create -v name1 imgfile
// Apply a snapshot
sh# setfattr -n trusted.gluterfs.block-snapshot-goto -v name1 imgfile
Change-Id: If993e057a9455967ba3fa9dcabb7f74b8b2cf4c3
BUG: 986775
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5367
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
commit d53bb857785df94d7df3c91656b4ae07bc8cfb8e
Author: Anand Avati <avati@redhat.com>
Date: Wed Mar 6 01:11:59 2013 -0800
contrib/qemu: Import qemu block source code
This qemu block format source code and its minimal
dependency files will be used in the next patch to implement
a qemu-block format translator.
Change-Id: Ic87638972f7ea9b3df84d7a0539512a250c11c1c
BUG: 986775
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5366
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
commit 4ff9d2bf105a50bc8a00f1f55980531ac5423ccb
Author: Anuradha Talur <atalur@redhat.com>
Date: Wed Aug 28 14:29:50 2013 +0530
features/locks : Improves debuggability of inode/entry locks.
Prints, in the statedump, the information about the mount that
performed the inode/entry lk.
For the entrylks that are granted after a blocked state, the
blocked time is not printed. A patch for that will be sent
later.
Change-Id: Ib0c1ed21fa9328b435f96b590dd343f59814a08d
BUG: 915629
Signed-off-by: Anuradha Talur <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/5712
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d4741f7bc33f6d4bfd43382db119dad8ba7133dc
Author: Bala.FA <barumuga@redhat.com>
Date: Thu Aug 22 09:03:38 2013 +0530
build: handle dependencies for syslog properly
This patch conditionally enables rsyslog dependencies based on syslog
build option.
Change-Id: I2168f29a03504ec839c3048ce112e8dfb2226aa0
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/5684
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 651437e826ea0cba72aa5ed2a15a7726a34d0ea2
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Wed Aug 28 17:39:23 2013 +0530
cluster/afr: Improvement in logging of self heal completion status
Additional information for source and sinks are added.
Change-Id: I1704956ff86ac3ae36744efe7499c1d1c43faeaf
BUG: 968301
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/5638
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4e426bf98d233eb606e7d93981060b98bd665056
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Aug 29 17:17:14 2013 +0530
api: Add null check for active_subvol in glfs_close.
Problem:
In glfs_close, NULL value returned by glfs_active_subvol was not
being checked and was causing a crash.
Change-Id: I6eefa60e7b07dee251b98932b1d08a5c2981d3d7
BUG: 1002511
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/5733
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 970e22f174a719371e28a33baa39a0785bc03b79
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Aug 29 19:04:40 2013 +0530
api: Fill loc.path and loc.gfid before syncop_open.
syncop_open was crashing because of NULL dereference.
This fixes that.
Change-Id: I4bc48fac2a6c0b15c806cbbb4ae45c67891ab7ed
BUG: 1002577
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/5734
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0f1cb75569d4297b48cf7d14191a34aca38997e7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Aug 29 22:42:43 2013 +0530
cluster/afr: Reset attempted count before attempting blocking lock
Problem:
internal_lock->lk_attempted_count keeps track of the number of blocking
locks attempted. lk_expected_count keeps track of the number locks expected.
Here are the sequence of steps that happen which lead to the illution that
a full file lock is achieved, even without attempting any lock.
2 mounts are doing dd on same file. Both of them witness a brick going
down and coming back up again. Both of the mounts issue self-heal
1) Both mount-1, mount-2 attempt full file locks in self-heal domain.
lets say mount-1 got the lock, mount-2 attempts blocking lock.
2) mount-1 attempts full file lock in data domain. It goes into blocking
mode because some other writes are in progress. Eventually it gets the lock.
But this results in lk_attempted_count to be still as 2 and will not be reset.
It completes syncing the data.
3) mount-1 before unlocking final small range lock attempts full file lock in
data domain to figure out the source/sink. This will be put into blocked mode
again because some other writes are in progress. But this time seeing the
stale value of lk_attempted_count being equal to lk_expected_count, blocking_lock
phase thinks it completed locking without acquiring a single lock :-O.
4) mount-1 reads xattrs without any lock but since it does not modify the xattrs,
no harm is done by this phase. It tries to do unlocks and the unlocks will fail
because the locks are never taken in data domain. mount-1 also unlocks
self-heal domain locks.
Our beloved mount-2 now gets the chance to cause horror :-(.
5) mount-2 gets the full range blocking lock in self-heal domain.
Please note that this sets lk_attempted_count to 2.
6) mount-2 attempts full range lock in data domain, since there are still
writes on going, it switches to blocking mode. But since lk_attempted_count is 2
which is same as lk_expected_count, blocking phase locks thinks it actually got
the full range locks even though not a single lock request went out the wire.
7) mount-2 reads the change-log xattrs, which would give the number of operations
in progress (lets call this 'X'). It does the syncing and at the end of the sync
decrements the changelog by 'X'. But since that 'X' was introduced by 'X' number
of transactions that are in progress, they also decrement the changelog by 'X'.
Effectively for 'X' operations 'X' number of pre-ops are done but 2 times 'X'
number of post-ops are done resulting in -ve changelog numbers.
Fix:
Reset the lk_attempted_count and inode locks array that is used to remember locks
that are granted.
Change-Id: Ic0a79cd16f32392ea7c790511343c73592bbe6bd
BUG: 1002698
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5736
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 86285b0fb3e242d71902d62dc3e5f7fecbce3e10
Author: Anand Avati <avati@redhat.com>
Date: Mon Aug 26 21:58:26 2013 -0700
nfs: prevent NFS server crash when upgrading from 3.2.x server
After an upgrade the NFS3 filehandle size changed (became smaller),
but when doing a live ugprade the client would send the old handle
(expect ESTALE and do fresh lookup). But when reading the old
handle we were reading it into a structure which was limited to the
size of the new handle, while we should have been reading into a
buffer which is as big as the NFS3 spec permits the handle size to
be. The actor functions declare the structure on the stack. So the
overflow is resulting in a stack corruption.
Change-Id: Ie930875ac9db46b43d1cb8ad1e6d89cdaeded7ca
BUG: 1002385
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5730
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b1111e94ceca38aa3740b33de1b13de0803f5045
Author: Anand Avati <avati@redhat.com>
Date: Wed Aug 28 22:54:35 2013 -0700
cluster/afr: unlock before aborting transaction
Else this results in a missing frame causing a hang
Change-Id: Ib5f3dc6a3999449faa2853cee2944af2fb065a20
BUG: 1002399
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5731
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bc2a8a2d3dff42a45163b83fad1633b91b08c4f6
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Aug 14 07:09:52 2013 -0400
cluster/stripe: enable coalesce mode by default
It has been available for a while now and is probably the sane
default due to the more efficient layout and performance benefit.
BUG: 1001207
Change-Id: I6275f9741866c0afd6e685f8dc5867a86485fd20
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5624
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cf39f16f7a923ad3a29173e32f8a59d0e7189d10
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Aug 27 13:42:41 2013 +0530
cluster/afr: Add special handling for failure postops
Idea is to not leave the file in FOOL-FOOL scenario in case on
all the bricks data transaction failed with EDQUOT to avoid
increasing un-necessary load of self-heals in the system.
For directory transactions don't leave pending changelog in case
the failures are seen on all the subvolumes.
Change-Id: I38a5561d1d581a78347a76a4a509514e4a0c3fb7
BUG: 969461
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5709
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ea169b8af493c4de97b65f8f8cbd510b8aa9e2d2
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Aug 28 22:43:41 2013 +0530
stripe: remove unused param, handle mem alloc failure
Change-Id: I9c27b1edab111031ca8eea9cc49480ea01e39089
BUG: 1002207
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5716
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 38a51b7bf455632ad4c8208cc9ae207849223ebe
Author: Anand Avati <avati@redhat.com>
Date: Fri Mar 15 11:20:53 2013 -0700
synctask: minor enhancements
- Enhance syncenv_new() to accept scaling parameters of syncproc.
Previously the scaling parameters were hardcoded and decided at
compile time.
- New API synctask_create() which returns the created synctask. This
is similar to synctask_new which only returned the status of whether
a synctask could be created or not.
The meaning of NULL cbk in synctask_create() means the task is
"joinable". Until synctask_join() is called on such a synctask,
the task is not reaped and resources are not destroyed. The
task would be in a zombie state after synctask_fn returns and
before synctask_join() is called.
Change-Id: I368ec9037de9510d2ba951f0aad86aaf18d9a6b6
BUG: 986775
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5365
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
commit 62efd02a91386b55cb248d189404737ae80b71b7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Aug 15 22:01:20 2013 +0530
cluster/afr: Don't delay post op in cases of failures
Change-Id: Ib0c3af6babc61dc3ed45252582876e2f243d6446
BUG: 958118
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5635
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3f61646025454938d69ea4aa38e7047171b3e712
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Aug 28 13:28:29 2013 -0400
api: glusterfs-api.pc.in (and libgfchangelog.pc.in) use rpath (-Wl,-R...)
Change-Id: Icdd23f1c31421c882db106cdad1b1406569594ca
BUG: 1002220
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5717
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3d94f218cac19e3ccb9c7e1838b73d83e4bce193
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Aug 9 14:17:33 2013 +0200
nfs: persistent caching of connected NFS-clients
Introduce /var/lib/glusterfs/nfs/rmtab to contain a list of NFS-clients
which have a volume mounted. The volume option 'nfs.mount-rmtab' can be
set to an alternative filename. When the file is located on shared
storage, multiple gNFS servers can use the same file to present a single
NFS-server.
This cache is read when a system administrator calls 'showmount -a' and
updated when an NFS-client calls MNT or UMNT from the MOUNT protocol.
Usage:
- create a volume for storing the shared rmtab file
- mount the volume on all storage servers, at the same location
- make sure that the volume is mounted at boot (add to /etc/fstab)
- place the rmtab file on the volume:
# gluster volume set <VOLUME> nfs.mount-rmtab <MOUNTPOINT>/<FILENAME>
- any subsequent mount requests will add an entry to this file
- 'showmount -a' requests will return the NFS-clients using the cluster
Note:
The NFS-server does currently not support reconfigure(). When a
configuration option is set/changed, the NFS-server glusterfs process
gets restarted. This causes the active NFS-clients to be forgotten (the
entries are saved in the old rmtab, but we do not have a reference to
that file any more, so we can't re-add them). Therefor a re-mount done
by the NFS-clients is needed before they get listed in the rmtab again.
Change-Id: I58f47135d60ad112849d647bea4e1129683dd2b3
BUG: 904065
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4430
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
Tested-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit f0b8543e6b0fb05ca02723084b74b504104ea703
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Aug 25 20:51:20 2013 +0530
api: Set errno before invoking glfs_init_done()
Change-Id: I3f4d3cfaf7078e126881111eb840d854b0b6466d
BUG: 860212
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5704
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a00dcd0b9e6976c331234cef85db58e1552f0aee
Author: Anand Avati <avati@redhat.com>
Date: Mon Aug 12 09:41:06 2013 -0700
mount/fuse: perform lookup() on inodes linked through readdirplus
Some xlators still require lookup() fop to be sent for proper working.
This patch remembers inodes which have been linked through readdiprlus
and makes the resolver send lookups on them.
Change-Id: Ibe8a04a659539d90dfc794521b51bf2bda017a0b
BUG: 979910
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5267
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b8c9bf28f0899bd8989d42f1e4b6203e4044b38a
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Aug 22 16:25:58 2013 +0200
build: fix days and dates in the %changelog of the spec-file (2nd part)
This prevents more unneeded build warnings like:
warning: bogus date in %changelog: Mon Apr 22 2008 ...
Bug: 1000019
Change-Id: I1d59fb93806e25a4629ce027beec324d03702e15
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5701
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 999bc2583d86850328bca1f10033480832a2fbc3
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Aug 21 18:54:05 2013 +0530
core: remove GLUSTERFS_CREATE_MODE_KEY usage
Change-Id: I23b8cb7223b91a55af1cd4214f61bbe0e87351f6
BUG: 952029
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5683
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 204d60114c58ce65cb9a7aae899a4d0425d87f60
Author: Anand Avati <avati@redhat.com>
Date: Thu Aug 22 15:02:00 2013 -0700
gfapi: Add description of glfs_io_cbk function as a comment
No code change, just add a comment describing the callback function
type.
Change-Id: I3a5c5b3d3fe042b4f535963dd477806832c15704
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5696
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 3da3ea7584be0794045920ecbcef47b4c453128a
Author: Anand Avati <avati@redhat.com>
Date: Thu Aug 22 14:14:22 2013 -0700
rpc: fix typo which refers glibc macro
A typo which read MAX_AUTH_BYTES instead of GF_MAX_AUTH_BYTES was
picking the value 400 instead of the larger 2048. This causes
failures when number of aux group ids is a large number.
Change-Id: Idb8d59aee2690fd53e24c2e09f58a16fe387ef27
BUG: 1000131
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5695
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cbb2c27934894d9cb1de7a6569a889a61770cc48
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 08:54:59 2013 +0200
doc: Move glusterd.vol to extras/ directory
It's actually not documentation.
Change-Id: I30c84abc9a31edb2f849dd2d6ff6d3129d87392d
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5474
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3012a1d9709585dc56a09389cffc8351e2226e5b
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Aug 2 16:00:28 2013 +0530
mount/fuse: do not forget the root inode
In batch forgetting of inodes, nodeid should be checked and if it is for
root, then it should not be sent forget.
Change-Id: I99bd91ba70d8be4df88ddac005e38c449f4ed7d9
BUG: 990744
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/5471
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2fdce96259c4aaceeb41be8ce295b480d1636e71
Author: Anand Avati <avati@redhat.com>
Date: Thu Aug 22 12:34:26 2013 -0700
bug-979365.t: fix wrong expectation of encountering fsync
After the append-write detection patch, FSYNCs may or may not
be issued depeneding on the order in which writes reach the
server (in the presence of write-behind). Fix the test case
to understand this non-deterministic behavior.
Change-Id: I1dc3453a6dd4a12a66551948eb8311d789ac2ecf
BUG: 927146
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5694
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 1b622c3005bee436425f456edf31ef981ab1e75d
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Aug 22 16:25:58 2013 +0200
build: fix days and dates in the %changelog of the spec-file
This prevents unneeded build warnings like:
warning: bogus date in %changelog: Mon Apr 22 2008 ...
Bug: 1000019
Change-Id: Ie584e5faf5d04672186eada718aba7e71bd82b42
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5692
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ea69358ebfbc5fe506b6e24bb62d40ff81c80b16
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Aug 22 16:43:12 2013 +0530
extras/hookscripts: Add default logfile for glusterfs vfs plugin.
Glusterfs vfs plugin for samba makes call into gfapi which brings
up complete client process stack of gluster. Not having default
log file means not logging client process at all.
This patch adds default logfile and loglevel for vfs plugin.
Change-Id: Ie0fb6bbb445d6f3349fc35c713743094c0f08915
BUG: 999910
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/5685
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit e755f91dbd764edebac76240bc099ea0edf4a28c
Author: Anand Avati <avati@redhat.com>
Date: Wed Aug 21 17:34:02 2013 -0700
io-cache: fix unsafe typcasting of pointer to uint64
The typecast of pointer to uint64_t *, followed by setting of
64bit in inode_ctx_get() results in memory corruption on 32bit
system.
Change-Id: I32fa3bf3b853ed2690a9b9a471099a59b9d7186a
BUG: 997902
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5682
Tested-by: Morten Johansen <morten@bzzt.no>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
commit 9dc043b981ba8fb39e9116e9096818d9ed172355
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Jul 31 22:57:12 2013 +0530
gfid-access: virtual access to filesystem through gfid path
BUG: 952029
Change-Id: I7405d473d369a4a951836eceda4faccbad19ce0e
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5497
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 33e60b4aa4ddc883819ad2153a1b177dd0ef7d04
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Jul 31 23:58:04 2013 +0530
core: changes to support gfid-access
Change-Id: I38d2fdc47e4b805deafca6805e54807976ffdb7e
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 952029
Reviewed-on: http://review.gluster.org/5496
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 897734e2d17cbc6aa7cd77126bb076c0bd367f0d
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Aug 4 13:20:01 2013 +0530
Revert "fuse: auxiliary gfid mount support"
This reverts commit 4c0f4c8a89039b1fa1c9c015fb6f273268164c20.
Conflicts:
xlators/mount/fuse/src/fuse-bridge.c
For build issues added CREATE_MODE_KEY definition in:
libglusterfs/src/glusterfs.h
Change-Id: I8093c2a0b5349b01e1ee6206025edbdbee43055e
BUG: 952029
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5495
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2cf7dcfa1f02448fd941bcbc272a486e5dc5f984
Author: Ravishankar N <ravishankar@redhat.com>
Date: Fri Jul 19 14:23:32 2013 +0000
glusterd: add check in remove-brick start variant
The 'start' variant of the remove-brick command only applies at the dht
level wherein we can remove all the bricks of a sub-volume (and remove
multiple such sub-volumes) but not select bricks of it.
This patch disallows removing individual replica bricks of multiple
sub-volumes (i.e. reducing the replcia count of the volume) using
remove-brick 'start'. The preferred method for such an operation is to use
commit force.
This patch also reverts the check to prevent removal of bricks from a
replicate volume (commit 0d415f7)
BUG: 961669
Change-Id: I447ad27f73a0963b5e09fb317bf7267a7a5a6147
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/5566
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit dc377856c53647e96e23cbade78fdc01bd7b2cea
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Aug 20 18:25:09 2013 -0700
tests: Avoid another 'grep' in ps output
Previous fix at
----------------------------->
764c42813df3de9659a1ab7b7356779d2e5d64e5
<-----------------------------
Was incomplete
Change-Id: I6662168a7af078935a5cbcfae76ec40fc0c112b8
BUG: 887098
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5672
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a8efeac60b62ba06b96e865c74b0a37b6e706a81
Author: Anand Avati <avati@redhat.com>
Date: Sat Aug 10 16:10:26 2013 -0700
md-cache: invalidate attributes on xattr update
xattr update will result in at least ctime change. So invalidate
attributes in xattr callback.
Change-Id: Ie6e8f2fd9a11c56c27e78bd58c2ff1e1d6edce6e
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5641
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 324c913d473f44dc5b470da9353d4dbe633781fd
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Aug 13 19:47:01 2013 +0530
mount/fuse: save the basefd flags in the new fd
Upon graph switch, the basefd's flags were not saved in the new fd created
for the new graph upon which all the further requests for the open file
would come. Thus posix was treating the fd as a read-only fd and was
denying the write on the fds.
Change-Id: I781b62b376a85d1a938c091559270c3f242f1a2a
BUG: 998352
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/5601
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c5c1cdf562fab9413fb6ced8f0d60eb5f4bafe0a
Author: Bharata B Rao <bharata@linux.vnet.ibm.com>
Date: Fri Aug 16 11:39:01 2013 +0530
log: Fix logging to stderr
This fix enables gluster clients like QEMU using glfs_set_logging()
with "-" as logfile to see client side errors on stderr.
Change-Id: I35f7b65460d1c03f910ceb3bad0a65677317e702
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Reviewed-on: http://review.gluster.org/5637
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c28997f7993d26e445663dfa354d5dfe29f3243d
Author: Anand Avati <avati@redhat.com>
Date: Thu Aug 15 13:53:52 2013 -0700
glusterd: release big locks while doing mount
Else things can deadlock in getspec v/s glusterd_do_mount()
Change-Id: Ie70b43916e495c1c8f93e4ed0836c2fb7b0e1f1d
BUG: 997576
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5636
Tested-by: Joe Julian <joe@julianfamily.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 36b2decbe6ad78e77d8ae2cf79fbae9e493d1512
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Aug 7 12:25:07 2013 +0530
glusterd: Try to start all bricks on 'start force'
A volume would fail to start if any one of the bricks fails staging or
fails to start, even with the 'force' option. With this patch, when the
'force' option is given for a volume start, glusterd will continue and
start other bricks even if one fails staging or starting.
Also did a small fix in changelog, to prevent it crashing when it fails
to init.
Change-Id: I7efbd9ab13d12d69b0335ae54143fa17586f8f98
BUG: 994375
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5510
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 750326b68354a21cd9bb82c23b4e108076bc79e5
Author: Timothy Asir <tjeyasin@redhat.com>
Date: Tue Apr 23 12:30:35 2013 +0530
cli: Add server uuid into volume brick info xml
Add server uuid as an attribute to the existing brick details in the
volume info cli xml output.
Currently, when a node has more than one ip, the oVirt-engine fails
to map the corresponding server using the ip alone.
If we get the host uuid along with brick details in volume info
command it will be easy for ovirt-engine to find out the
server and thereby we can avoid confusion in finding the server.
Change-Id: I3c9c9acea80e10e0b2977477759d9af045e48959
BUG: 955588
Signed-off-by: Timothy Asir <tjeyasin@redhat.com>
Reviewed-on: http://review.gluster.org/4875
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 22245520334e7dd25e2b3c132501a15ba875ff84
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Aug 14 15:44:33 2013 -0700
tests: make sure to avoid 'grep' in ps output
Change-Id: I48909facd2e3a2dc52a18e44d58c0e0fa2d96ec3
BUG: 887098
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5631
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 505c8bfc39c10afb521875777b6d13b6914f0fd5
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Sat Aug 10 20:49:12 2013 -0700
glusterd: Move certain logs into 'DEBUG' level
Confusing "Error" messages in logs can cause user panic
and false positives - avoid them as necessary in future.
Change-Id: I906c64eea879b19a8db099c89d1d7f874e5530db
BUG: 995784
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5555
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2cc682a87e3bc89003b3d7facc2b8e6e4b5a13b7
Author: shishir gowda <sgowda@redhat.com>
Date: Mon Aug 12 17:25:12 2013 +0530
cluster/dht: Del GF_READDIR_SKIP_DIRS key from dict for first_up
Currently, we sent GF_READDIR_SKIP_DIRS for all subvolumes if
first_subvol != first_up_subvolume.
Also first_up_subvolume can change with-in the life of a call and
cbk. Saving the first_up_subvol in dht_local for checks.
Change-Id: I6e369e63f29c9761993f2a66ed768c424bb44d27
BUG: 996474
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5577
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 96aa2f0462f7d1381c09384a48c6fef0b791c472
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Aug 5 22:20:19 2013 +0530
protocol/server: Relax lktable finodelk del_locker check
Problem:
Client xlator issues finodelk using anon-fd when the fd is not
opened on the file. This can also happen between attempts to re-open
the file after client disconnects. It can so happen that lock is taken
using anon-fd and the file is now re-opened and unlock would come with
re-opened fd. This will lead to leak in lk-table entry, which also
holds reference to fd which leads to fd-leak on the brick.
Fix:
Don't check for fds to be equal for tracking finodelks.
Since inodelk is identified by (gfid, connection, lk-owner)
fd equality is not needed.
Change-Id: I62152d84caef0b863c973845e618076d388e6848
BUG: 993247
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5499
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6fc03a303532ff567253c4cb1c445c40b5d3ac6b
Author: Anand Avati <avati@redhat.com>
Date: Wed Aug 14 16:11:40 2013 -0700
rfc.sh: Include BUG: header even in first run
Set the commit hook before entiring editor mode. This fixes the
error where rfc.sh after first clone does not set BUG: header
Change-Id: Ic0e9f2d3f656bc81e29d35556022fbdff2f61225
BUG: 764890
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5632
commit cfd90e528d3058bef8a7defb13db837a7d96cf5d
Author: Bala.FA <barumuga@redhat.com>
Date: Tue Aug 13 11:27:50 2013 +0530
log: add logger.conf.example file
This example file can be safely renamed as logger.conf to enable
syslog logging
Change-Id: If49dd6002a046915b2eca330b7a539f4fa1f94fa
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/5622
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b371a9047ce45a6dba09777ca23c9283297b627e
Author: Bala.FA <barumuga@redhat.com>
Date: Fri Aug 9 17:21:56 2013 +0530
log: add comments to rsyslog gluster configuration file
Comments are added to rsyslog gluster configuration files to give
clear meanings and example email alerting.
Change-Id: I23577dc3b39bca89696c46ab6252dc5673d0803f
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/5621
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5038b406cf75461f32d64cae58aa72f15b9576e6
Author: Anand Avati <avati@redhat.com>
Date: Wed Aug 7 04:16:52 2013 -0700
cluster/afr: Add largest file is source policy
For Write Once Read Many times type of work-load choosing largest
file to be the source will always resolve fool-fool
scenarios correctly. In other cases we fsync() the files and
will have a reliable 'wise man'.
Change-Id: Ic4dbea8d06db6d578fbcb866fb65ee2d066ac7ba
BUG: 958118
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5519
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 7ce3095e61066b0704ebee5fa69e9d12292e703b
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Mon Jul 29 23:43:51 2013 +0530
performance/write-behind: invoke request queue processing if we find fd marked bad while trying to fulfill lies.
* flush was queued behind some unfulfilled write.
* A previously wound write returned an error and hence fd was marked
bad with corresponding error.
* wb_fulfill_head (invocation probably rooted in wb_flush), before
winding checks for failures of previous writes and since there was a
failure, calls wb_head_done without even winding one request in head.
* wb_head_done unrefs all the requests in list "head".
* since flush was last operation on fd (and most likely last operation
on inode itself), no one invokes wb_process_queue and flush is stuck
in request queue for eternity.
Change-Id: I3b5b114a1c401d477dd7ff64fb6119b43fda2d18
BUG: 988642
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/5398
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a18d63694d6e116ae5f587b3a25bbed8c63b4e35
Author: Anand Avati <avati@redhat.com>
Date: Wed Jul 24 03:53:16 2013 -0700
afr: treat appending writes as stable writes.
Durability of appending writes is implicit in the file size. Therefore
performing an explicit fsync() is unnecessary in such cases as self-heal
can check for the size of file when pending changelog is not unambiguous.
Change-Id: I05446180a91d20e0dbee5de5a7085b87d57f178a
BUG: 927146
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5501
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit c1bcbc140b5909ff381214ca634eb2255b2f9611
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Tue Aug 13 17:35:20 2013 -0700
posix: Default value for `batch-fsync-delay-usec` should be '0'
Also fixes for failing testcase `./tests/bugs/bug-888174.t`,
which has been failing sporadically for many patches.
Change-Id: Ic7d2c95da5d3126623cec403207afadd449bf950
BUG: 927146
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5620
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3793c46db6591e8b6ff751f09512be7e4ebfffa9
Author: Anand Avati <avati@redhat.com>
Date: Fri Aug 9 11:12:29 2013 -0700
libgfapi : Fix for hardlink creation on SMB mount
Previously the inode of the hard link was left uninitialised hence
glfs_loc_link() used to fail with invalid parameter.Since inode is
same for both the files in hard link creation, updated the inode
field of hard link to be same as that of the original file.
Original-author: susant palai <spalai@redhat.com>
Change-Id: Ifd6439867d982524a7b48bf3f6add6e844b3c4c1
BUG: 996063
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5576
Tested-by: susant palai <spalai@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6e1bbefcbb604f46bde34ca7fc49c6b6b62ebf1f
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu Jun 13 14:51:46 2013 +0000
glusterd: remove-brick:Allow simultaneous removal of multiple subvolumes.
Currently, remove-brick supports removal of only one distributed
stripe/ replica pair at a time. Fix it to support removal of multiple
pairs. This is consistent with add-brick behaviour which supports adding
multiple stripe/replica pairs simultaneously.
Removal is successful irrespective of the order of the bricks given at
the CLI, as long as the bricks are from the same subvolume(s).
Change-Id: I7c11c1235ce07b124155978b9d48d0ea65396103
BUG: 974007
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/5210
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 4b05842e888f9730f3851ff82f44f3707a0b5d0b
Author: Bala.FA <barumuga@redhat.com>
Date: Fri Aug 9 17:21:56 2013 +0530
log: add rsyslog gluster configuration file
This patch comes with rsyslog gluster configuration file for fedora
and rhel >= 6. It disables syslog at rpm build time if targetted
platform is rhel < 6 as there is no rsyslog support.
Change-Id: I95c076874b6891ff08dee1b35980f95529fb0f37
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/5543
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 689086232a5e3d0758653317cb9e59eec90cc223
Author: Bala.FA <barumuga@redhat.com>
Date: Fri Aug 9 17:26:48 2013 +0530
log: use /etc/glusterfs/logger.conf file for logging target
This patch fixes to use /etc/glusterfs/logger.conf file instead of
/var/lib/glusterd/logger.conf for logging target (whether to use
syslog or not) at run time.
Change-Id: Icb1de9ebfb7e529940e2aac970978ad70b34b213
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/5542
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bcd8c35726de3569b8578caaa8ef496a235e9699
Author: Bala.FA <barumuga@redhat.com>
Date: Fri Aug 9 16:51:11 2013 +0530
log: set ident to openlog
at syslog side, log message is identified by its properties like
programname, pid, etc. brick/mount processes need to be identified
uniquely as they are different process of gluterfsd/glusterfs. At
rsyslog side, log separated by programname/app-name with pid works but
bit hard to identify them in long run which process is for what
brick/mount.
This patch fixes by setting identity string at openlog() which sets
programname/app-name as similar to old style log file prefixed by
gluster, glusterd, glusterfs or glusterfsd
Change-Id: Ia05068943fa67ae1663aaded1444cf84ea648db8
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/5541
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 17edc817f2395274220bcd5b9f5069b360d6003e
Author: Anand Avati <avati@redhat.com>
Date: Wed Aug 7 16:04:23 2013 -0700
cluster/afr: skip directory inspection when entry self-heal is off
When user has explicitly configured to disable entry self-heal in the
client, it is wrong to do the healing in opendir. So skip it. This
is especially useful to reduce opendir() times after graph switches.
Change-Id: Ic6eb9ff2334a5b8417f2f35410a366a536bad5df
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5528
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5bb5e26819ec7314cc27c0aac7d42ad61f3eb386
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Aug 1 23:03:13 2013 -0700
logging: [doc] Fix a typo
/var/log/glusterd/logger.conf should be /var/lib/glusterd/logger.conf
Change-Id: I3a4b19eb59d7acf83224fed01a5856565ffe1741
BUG: 928648
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5466
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit fdb3fb9a9eacc2bbb5de3d2a938564caafa2a9ba
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Aug 8 15:22:10 2013 +0530
cluster/afr: Unwind frame on error in readdir[p]
Change-Id: I5701bf115e0aa1adb4fb52f5418534910a2268d4
BUG: 994959
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5531
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d1d11f5f51b2d0fc74cd6f0b852efb5cd8f68eca
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Aug 7 09:11:48 2013 -0400
build: sync glusterfs.spec.in with Fedora glusterfs.spec
(this is the master branch)
* add necessary requires
* add -cli subpackage
* fix other minor differences with Fedora glusterfs.spec
Change-Id: Ifd535463a68cfd0793691e37148f411b95b41867
BUG: 950083
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5522
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5d63c207fc74169b5e5b543e44a553094bf74d86
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Aug 8 03:19:43 2013 +0530
extras/hook-scripts: Don't add multiple entries in smb.conf
When volume is force started, there may be entry in smb.conf
for that volume. Always check for entry before adding one.
Change-Id: I44f893174a993abaa31c24c1a81bb38a58617808
BUG: 994727
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/5526
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit e187a3b5d0667834ee6f24ea50ad1205366dff18
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Jul 24 19:11:49 2013 +0000
afr: check for non-zero call_count before doing a stack wind
When one of the bricks of a 1x2 replicate volume is down,
writes to the volume is causing a race between afr_flush_wrapper() and
afr_flush_cbk(). The latter frees up the call_frame's local variables
in the unwind, while the former accesses them in the for loop and
sending a stack wind the second time. This causes the FUSE mount process
(glusterfs) toa receive a SIGSEGV when the corresponding unwind is hit.
This patch adds the call_count check which was removed when
afr_flush_wrapper() was introduced in commit 29619b4e
Change-Id: I87d12ef39ea61cc4c8244c7f895b7492b90a7042
BUG: 988182
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/5393
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cc9c90bacead1e87e81228f0aed00da73f7481ea
Author: Anand Avati <avati@redhat.com>
Date: Wed Aug 7 01:30:42 2013 -0700
md-cache: fix xattr caching code in getxattr
Bad condition check, fix it!
Change-Id: I6e047de70f77d7b98b2ca771a467f14a76fd62fe
BUG: 994392
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5513
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b39b0cbc5d75c1e1dfa61538ee30bb95b4dc0c90
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Aug 6 17:40:05 2013 +0530
features/locks: Convert old style metadata locks to new-style
Problem:
In 3.3, inode locks of both metadata and data are competing in same
domain called data domain (old style). This coupled with eager-lock,
delayed post-ops introduce delays for metadata operations like chmod,
chown etc. To avoid this problem, inode locks for metadata ops are
moved to different domain called metadata domain in 3.4 (new style).
But when both 3.3 clients and 3.4 clients are present, 3.4 clients
for metadata operations still need to take locks in "old style" so
that proper synchronization happens across 3.3 and 3.4 clients. Only
when all clients are >= 3.4 locks will be taken in "new style" for
metadata locks. Because of this behavior as long as at least one 3.3
client is present, delays will be perceived for doing metadata
operations on all 3.4 clients while data operations are in
progress (Ex: Untar will untar one file per sec).
Fix:
Make locks xlators translate old-style metadata locks to new-style
metadata locks. Since upgrade process suggests upgrading servers
first and then clients, this approach gives good results.
Tests:
1) Tested that old style metadata locks are converted to new style by
locks xlator using gdb
2) Tested that disconnects purge locks in meta-data domain as well
using gdb and statedumps.
3) Tested that untar performance is not hampered by meta-data and
data operations.
4) Had two mounts one with orthogonal-meta-data on and other with
orthogonal-meta-data off ran chmod 777 <file> on one mount and
chmod 555 <file> on the other mount in while loops when I took
statedumps I saw that both the transports are taking lock on
same domain with same range.
18:49:30 :) ⚡ sudo grep -B1 "ACTIVE" /usr/local/var/run/gluster/home-gfs-r2_0.324.dump.*
home-gfs-r2_0.324.dump.1375794971-lock-dump.domain.domain=r2-replicate-0:metadata
home-gfs-r2_0.324.dump.1375794971:inodelk.inodelk[0](ACTIVE)=type=WRITE, whence=0, start=9223372036854775806, len=0, pid = 7525, owner=78f9e652497f0000, transport=0x15ac9e0, , granted at Tue Aug 6 18:46:11 2013
home-gfs-r2_0.324.dump.1375795051-lock-dump.domain.domain=r2-replicate-0:metadata
home-gfs-r2_0.324.dump.1375795051:inodelk.inodelk[0](ACTIVE)=type=WRITE, whence=0, start=9223372036854775806, len=0, pid = 8879, owner=0019cc3cad7f0000, transport=0x158f580, , granted at Tue Aug 6 18:47:31 2013
Change-Id: I268df4efd93a377a0c73fbc59b739ef12a7a8bb6
BUG: 993981
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5503
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 789ec85818956efa4f88e3ac0e3c48334fc2d57c
Author: M S Vishwanath Bhat <vbhat@redhat.com>
Date: Fri Aug 2 16:15:45 2013 +0530
Correcting a log message in glusterd-geo-rep.c
Change-Id: I4352f513fc5616daa20e9a4ad51a63fb13a27dff
BUG: 847839
Signed-off-by: M S Vishwanath Bhat <vbhat@redhat.com>
Reviewed-on: http://review.gluster.org/5472
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 89001bc17f21861d4e4fe694d246242a2fabb2f5
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 18:18:19 2013 +0200
doc: Convert adding a fop howto to markdown
Change-Id: Ia0a9ad228dcf69f40befc58fff7a56fffcfe915b
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5487
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 8089ad9df8072e0c5aa29cae4345d0646721528a
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 15:37:33 2013 +0200
doc: Convert the posix translator documentation to markdown
Change-Id: I6b6c3b2063c81e8799c3273434119dd9bff1be79
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5486
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 591b2ffc49901fde4cb749aa0df9d48e58a6b91e
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 18:07:55 2013 +0200
doc: The lock-ahead translator is not in tree, drop docs
Change-Id: Idda32338af416dc085c48ff023eeacf2397b65fd
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5485
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 655061cda12425e5709ff0296e3ddfd45d450cc9
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 18:18:08 2013 +0200
doc: Convert the afr translator documentation to markdown
Change-Id: I328986812df7adc849fa11b53ae483c2cd0825e8
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5484
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit bb76185a81ea92f070c8639bcbd8468116187a44
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 17:31:07 2013 +0200
doc: Remove the bdb translator documentation
The translator was removed in ea08bf886732d9680f2d6de19f3d68908a55143b.
Change-Id: I3d124be9e3962a54f0ab0247cfd4867b815f4a17
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5483
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit e9148a551b042698adc4388dcce2648f46fa1046
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 18:17:50 2013 +0200
doc: Convert the write-behind translator documentation to markdown
Change-Id: I213e230d283cd43bd1c2b2948882ab36f9170608
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5482
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 88846b46edbc95b96b1c7aa7fdcba3467913a5de
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Thu Aug 1 15:39:00 2013 +0200
doc: Re-format the translator tutorial
Adjutst whitespace so that things don't overflow in PDF.
Change-Id: Ic75abccbe744aac327b1c6311afb4c13271a723d
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5481
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 16c927ad70caba7daee93e4ca43b778eb6a3e5f0
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Thu Aug 1 15:13:01 2013 +0200
doc: Import Jeff Darcy's translator tutorial
It's way better than what we have currently. It's the original text from Jeff's
blog [1][2][3][4], unedited aside from the title, so that the content can be
properly attributed.
[1] http://hekafs.org/index.php/2011/11/translator-101-class-1-setting-the-stage/
[2] http://hekafs.org/index.php/2011/11/translator-101-lesson-2-init-fini-and-private-context/
[3] http://hekafs.org/index.php/2011/11/translator-101-lesson-3-this-time-for-real/
[4] http://hekafs.org/index.php/2011/11/translator-101-lesson-4-debugging-a-translator/
Original-Author: Jeff Darcy <jdarcy@redhat.com>
Necessary editing will follow:
* Nicer endings/openings of the subsections, as they are no longer separate articles
* Wrap lines in terminal outputs so that they render nicely in PDF
* Remove HeksFS references
* Remove first person fear of developer wrath for manual creation of a volfile
Change-Id: Ie9bb537b5817e8fa575ec0c66a58c48e6584698e
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5480
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit aa3ffa31a0145410b85baf83ebfe051c6e573ed6
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 15:37:33 2013 +0200
doc: Convert the coding standards to markdown
Change-Id: I5f3bec7b86ce31beb7459a27dc0f4ba39c6d9610
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5479
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 0f44af73d348c09f9973ed811a399d66bb5ecb49
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 10:15:28 2013 +0200
doc: Drop corrupted and unused file
Change-Id: Ib220f9264ac941e87a9eb0998775a1b5507c510f
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5478
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d0770883edc5ea9eee3abd5751ce1bb605093b38
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 09:55:57 2013 +0200
doc: Get rid of weird quoting
pandoc: Error producing PDF from TeX source.
! Package inputenc Error: Unicode char \u8:‟ not set up for use with LaTeX.
See the inputenc package documentation for explanation.
Type H <return> for immediate help.
...
l.6216 ... the objects access rights to "public‟
Change-Id: I23428930d167064b7c5790eea09daedbef06153a
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5477
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit e2509355129048db6a153e272281316d1d3a0510
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 09:35:17 2013 +0200
doc: Rename architectural diagram
It should not be specific to old gluster version anyway and the dot in name
causes trouble to pandoc/LaTeX:
pandoc: Error producing PDF from TeX source.
! LaTeX Error: Unknown graphics extension: .2_Architecture.png.
See the LaTeX manual or LaTeX Companion for explanation.
Type H <return> for immediate help.
...
l.98 ...ages/640px-GlusterFS_3.2_Architecture.png}
Change-Id: I9d222a1628e1c14b004c059733fabd7b70c86f26
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5476
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit ba75a868901a8ef05569fad045df89bdd4bb19e8
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 08:58:41 2013 +0200
doc: Drop volfiles from documentation tree
They're mostly useless.
Change-Id: Ib5db6f4439fee16e461afc0b0cd3b71c717a19c6
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5475
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit bf9cddaf3b91fc4e1cf422ebb08935bd35bc6b50
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Jul 31 08:52:45 2013 +0200
doc: Drop the docbook admin guide
It has been converted to Markdown.
Change-Id: Idc4b2de7e79aa955d1d3cac96a9ee653ccf9fbd9
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5473
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit feac5031a755c7c0a85ed0eac49cc50696c9f445
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Wed Jul 24 14:49:58 2013 -0700
Add switch and nufa options to 'gluster cli'
Change-Id: Ic3c43291e0e1ead0d89c0436e8d70aa5dee2f543
BUG: 924488
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5391
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8dcb1631bc0b952c2a0b35285cd6db8441f71972
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Jul 18 18:43:37 2013 -0700
glusterfsd: Cleanup in set_log_file_path()
1. Remove un-necessary tmp_ptr - volfile_id is true if volfile_server
is
2. port is not '1' as default instead its GF_DEFAULT_BASE_PORT
Change-Id: I3eab3f6ccce4b84724d25421002d2f25925ca72d
BUG: 846194
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5344
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1018e0809e05461e53fd49ce6498d609cd492260
Author: Ravishankar N <ravishankar@redhat.com>
Date: Wed Jul 24 18:44:42 2013 +0000
fuse: fix memory leak in fuse_getxattr()
The fuse_getxattr() function was not freeing fuse_state_t resulting in a
memory leak. As a result, when continuous writes (run dd command in a loop)
were done from a FUSE mount point, the OOM killer killed the client
process (glusterfs).
Change-Id: I6ded1a4c25d26ceab0cb3b89ac81066cb51343ec
BUG: 988182
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/5392
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 53e1d1fc66a5b18d8dd1f6b0a37c8ec717cb1de1
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jul 10 18:10:49 2013 +0530
cli,glusterd: Fix when tasks are shown in 'volume status'
Asynchronous tasks are shown in 'volume status' only for a normal volume
status request for either all volumes or a single volume.
Change-Id: I9d47101511776a179d213598782ca0bbdf32b8c2
BUG: 888752
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5308
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9d9029fc10a516d0fe3aea9974481ab134f85762
Author: Brian Foster <bfoster@redhat.com>
Date: Fri Aug 2 13:07:33 2013 -0400
fuse: sync fuse_kernel.h from linux 3.11.0(-rc3) header
The linux 3.11 fuse kernel header supports up through version 7.22.
Gluster has incrementally supported versions up to 7.22. This is a
hard sync of the most recent kernel header to resolve various,
minor descrepencies and facilitate updates going forward. The
following changes are included:
- Re-typed data structure definitions.
- Missing comments and init flag definitions (i.e., splice).
- Code format and whitespace differences.
No functional changes are included.
BUG: 990744
Change-Id: I86921ef7be56d31bab332cf8589262c2b9348221
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5490
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e7798d41594f6ba8ed49c363bcb1760c0652998d
Author: Brian Foster <bfoster@redhat.com>
Date: Fri Aug 2 13:07:17 2013 -0400
fuse-bridge: update to protocol minor version 22
7.17
- Distinguishes between POSIX and BSD locking support via a
separate BSD locking support init flag. Older protocol versions
(since BSD support was added) export both types of locking
requests if FUSE_POSIX_LOCKS is specified. Gluster sets this
flag, so set FUSE_FLOCK_LOCKS as well on kernels that support
version 17 or newer.
7.18
- Adds ioctl() support for directories (and the associated
FUSE_IOCTL_DIR flag). Gluster does not support the ioctl
request, so no changes are required. Update the header.
- Adds support for the delete notification to allow a filesystem
to inform the kernel of a deleted inode. No gluster changes
required.
7.19
- Adds support for the fallocate request. Gluster already supports
fallocate and includes the request opcode definition and data
structure. Update the header version number.
7.20
- Adds the FUSE_AUTO_INVAL_DATA init flag to enable attribute
updates on reads and automatic cache invalidation on mtime
changes. Behavior does not change unless the init flag is
specified, no gluster changes required. Update header.
7.21
- Adds readdirplus support and updates the poll request to include
events. Gluster already supports readdirplus and includes the
relevant data structures. Poll is not supported, so no changes
are required. Update the header with some missing
READDIRPLUS_AUTO bits.
7.22
- Adds real asynchronous direct I/O support. Gluster already
supports/enables the associated bit (FUSE_ASYNC_DIO), no further
changes are required. Update the header.
BUG: 990744
Change-Id: Idf6fd75bbd48189587e548f7624626f9a75309e8
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5489
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d62893eb88db3f5c3339802f84430c9de044dfed
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Aug 3 08:27:27 2013 +0530
performance/open-behind: Fix fd-leaks in unlink, rename
Change-Id: Ia8d4bed7ccd316a83c397b53b9c1b1806024f83e
BUG: 991622
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5493
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3b7b04cd4c3def7d0ab62d79601356ff3e1695e3
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jul 30 14:00:46 2013 -0400
build: sync glusterfs.spec.in with Fedora glusterfs.spec
(this is the master branch)
* Sync with latest Fedora updates
* add glusterfs-libs RPM for RHEL6.5 oVirt/qemu-kvm, see BZ 916645
BUG: 950083
Change-Id: If5816f9b6a9478f6663c1de4d14a9f8341da9e84
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5455
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 087ff77000bf42ac2d9610d2bf5405a0b470d504
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jul 24 18:34:38 2013 +0530
glusterd: Use volume op-versions during volgen
Instead of using the cluster op-version, volume op-version is used to
enable open-behind during volgen. For doing this, the volume op-versions
are updated before regenerating the volfiles.
Change-Id: I675bb549bf7c7c0279030dca698fb530781addc6
BUG: 990830
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5385
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f79e79e7cb2174e552e8f5ddc7dd9821973d9198
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 30 18:29:15 2013 +0530
cluster/afr: Disable eager-lock if open-fd-count > 1
Lets say mount1 has eager-lock(full-lock) and after the eager-lock
is taken mount2 opened the same file, it won't be able to
perform any data operations until mount1 releases eager-lock.
To avoid such scenario do not enable eager-lock for transaction
if open-fd-count is > 1. Delaying of changelog piggybacking is
avoided in this situation.
Change-Id: I51b45d6a7c216a78860aff0265a0b8dabc6423a5
BUG: 910217
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5432
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: venkatesh somyajulu <vsomyaju@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d11f45a634e29aae4f13015a25dc8f6f7386372d
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Mar 15 10:34:45 2013 +0100
store: Add (un)locking functionality
Some configuration/cache files (like the NFS rmtab) can be stored on
a GlusterFS volume and be used by multiple storage servers. This
requires suitable locking for the gf_store_handle_t structure. Introduce
gf_store_lock() and gf_store_unlock() for this purpose. The
gf_store_locked_local() function can be used to check if the
gf_store_handle_t has been locked by the current process.
This change also includes an unrelated correction where a FILE* was
getting leaked. Krishnan Parthasarathi identified this while reviewing
the new locking functionality.
Change-Id: I431b7510801841d4bad64480b4bb99d87e2ad347
BUG: 904065
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4677
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f395b883349cdedc27befc00a86b9e0908643d22
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 30 12:28:47 2013 +0530
storage/posix: Enable Open-fd-count query in writev
Change-Id: I86bdf865730416150c10617dcbad5c037579acde
BUG: 910217
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5433
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3f16c73ad54573c8c7da822f608330654008bff2
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Jul 29 11:18:49 2013 -0400
performance/io-threads: fix potential use after free crash
do_iot_schedule() enqueues the stub and kicks the worker thread.
The stub is eventually destroyed after it has been resumed and thus
unsafe to access after being enqueued.
Though likely difficult to reproduce in a real deployment, a crash
is reproducible by running a smallfile benchmark on a replica 2
volume on a single vm. Reorder the debug log message prior to the
do_iot_schedule() call to avoid the crash.
BUG: 989579
Change-Id: Ifc6502c02ae455c959a90ff1ca62a690e31ceafb
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5418
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ea81da016b1df9fcb981e6a036415660980080ab
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Jul 31 17:55:03 2013 -0400
fuse-bridge: update to fuse protocol minor version 16 (Linux)
7.14
- Splice write support to fuse device node. No gluster changes
required besides header update.
7.15
- Store/retrieve notification support. No gluster changes
required besides header update.
7.16
- BATCH_FORGET request support. Implement a handler for
BATCH_FORGET requests and update the header.
- Updated ioctl() ABI. No gluster changes required besides
header update.
BUG: 990744
Change-Id: If3061a720ba566ee6731ad8b77cdc665d8fbf781
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5449
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fc307e2cef0c4328f2414dfce585ff4e45711f95
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Thu Aug 1 12:55:51 2013 +0530
nfs: Fix for NFS crash during blocking NLM call.
Bug 990887: During a blocking NLM call NFS server is crashing.
Cause: When nlm4_establish_callback function is called from nlm4svc_send_granted the cs->req->trans
pointer is NULL. Thus using this pointer will result in a crash. Whereas cs->trans points to a
valid transport object. NLM should use cs->trans instead of cs->req->trans.
Fix: Replaced cs->req->trans with cs->trans.
Change-Id: I425e48e0aafc9a6c130912edf2e801d8c4c9472d
BUG: 990887
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/5452
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 301f433dd36b772b4a2a8eeae1c165069b00c109
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Apr 8 16:49:34 2013 +0530
build: Better configure control & messages for xml output
Users were not given a correct indication to whether xml output was
going to be built on running configure as the only information was lost
in the checks output. This would lead to conditions where the user would
assume gluster was compiled with xml output, when it wasn't the case.
With this change, a new line is added to the end of the configure output
which indicates if xml output is being built or not. Also, a new
configure flag, '--disable-xml-output', has been introduced which can be
used to explicitly disable xml outpu from being built.
Change-Id: Ie80ba0372b4c3967a836769c61b60263c8e5e350
BUG: 947226
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4793
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8b4cc42ba461f7a67d8292f67d930a4076399e62
Author: Tiziano Müller <tiziano.mueller@stepping-stone.ch>
Date: Wed Jul 31 18:04:29 2013 +0200
Fix broken parallel install
There is an automake bug when using _LTLIBRARIES, breaking parallel
`make install` (see http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7328)
Change-Id: I06aea1dc4c3e6cb0ae9aee5a04dd61881c8b6a7e
BUG: 981888
Signed-off-by: Tiziano Müller <tiziano.mueller@stepping-stone.ch>
Reviewed-on: http://review.gluster.org/5448
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 30fd77c60e129fedda6896bf4d4d1012408f79da
Author: Anand Avati <avati@redhat.com>
Date: Mon Jul 22 01:26:43 2013 -0700
dht: make linkfile creation mode explicitly get set
Because of posix default_acl on parent directory, the mode
of linkfile can get masked with the mode in the default acl.
This breaks DHT integrity. So let the mode get explicitly reset
after mknod().
Change-Id: Ia7328e1ee7b4430bda308f9da293dba78405e081
BUG: 990410
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5440
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit 4525fa57ad5af67643f330fb9d514b7bfed9f45c
Author: Anand Avati <avati@redhat.com>
Date: Mon Jul 22 10:02:34 2013 -0700
gfapi: perform open() on pre-existing inode in glfs_creat()
Performing syncop_create() on a pre-existing file can result
in opening the linkfile if DHT has a linkfile for the file.
This is because dht_create() will perform the op on the
hashed_subvol() and overwrite the layout in dht_create_cbk.
Change-Id: I7a0db56921ec9fc3e278e0418db3b967f81e5598
BUG: 990410
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5447
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5fd417650b84619e9600ef3d04c19e812d86f345
Author: shishir gowda <sgowda@redhat.com>
Date: Wed Jul 31 19:09:52 2013 +0530
cluster/dht: Re-initialize skipped file count in glusterd
Change-Id: I42d08b3a6a7a3839f5e9953e1f83959222c080f8
Signed-off-by: shishir gowda <sgowda@redhat.com>
BUG: 989846
Reviewed-on: http://review.gluster.org/5446
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 34fc735f8ba95c5ec5b14a8aeef67995e4539f9c
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Jul 29 19:05:50 2013 +0530
glusterd : Checking session created or not in case of geo-rep stop
Performing statefile check in case of geo-rep stop, so as to provide
proper error message in case session is not created.
However in case of geo-rep stop force, we allow the command to succeed
even in case that the session is not created, because the stop command
is a failsafe command to stop running geo-rep sessions on any nodes.
Change-Id: I2b6a0253de977633606c422cbbc9e37cede9a268
BUG: 989541
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5417
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 69e69161945ffe86a0647720fecb4189deeaa52a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Jul 26 21:45:22 2013 +0530
glusterd : initiating gsyncd restart during add-brick
During add-brick, when a new brick is added in one of the
nodes that was already a part of the existing volume, and
gsyncd was already running on that node, then all gsyncd
processes running on that node, for that particular master
and any slave sessions will be restarted
If a new brick is added in a new node, then after adding the
brick, the user has to perform the following steps:
1. gluster system:: execute gsec_create
2. gluster volume geo-replication <master-vol> <slave-vol> create push-pem force
3. gluster volume geo-replication <master-vol> <slave-vol> start force
Change-Id: I4b9633e176c80e4a7cf33f42ebfa47ab8fc283f1
BUG: 989532
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5416
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit feb856252d95c13d84ab2f4601d014624501c342
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jul 29 23:27:03 2013 +0530
mount.glusterfs: remove use of LD_LIBRARY_PATH
BUG: 989858
Change-Id: Id7c3929a179e151b6d60d3382bd5310187bb2aa6
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/5423
Reviewed-by: Bala FA <barumuga@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2df8edaab48d9662546a6321d1ead2be1daa89fe
Author: Anand Avati <avati@redhat.com>
Date: Mon Jul 22 01:15:21 2013 -0700
gfapi: fix glfs_readlink()
glfs_readlink() is supposed to memcpy the buffer pointer
returned by syncop_readlink(). Fix it.
Change-Id: I5936b07abbd93cf02b354233dc60f6623e30a38b
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5439
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
commit fd49e137303c3389bded363ff71aae1c32091d50
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Jul 30 17:22:58 2013 +0530
cluster/dht: Fix non-regular file ownership during rebalance
Currently non-regular files were created as root:root, and
their ownership never healed during rebalance process.
Also, in dht_linkfile_attr_heal, we have to heal the linkfiles
as default, as currently linkfiles are created as root:root.
That check existed, as earlier linkfiles were created as
frame->root->uid/gid
Change-Id: I6cd88361b81bdd500e15bc47b623f5db8eec88e9
BUG: 990154
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5434
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 840d93c2c9dee51c5c2122e4f1badd95f7ec39a6
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Jul 30 23:22:24 2013 +0530
mgmt/glusterd: Fix a minor typo.
Thanks to Patrick Matthäi <pmatthaei@debian.org> for the patch.
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Change-Id: I59da74298894ccc2ab30967ffe44cc844aa73f82
BUG: 814534
Reviewed-on: http://review.gluster.org/5436
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 73cda651c8c5500af3701105f8e6cf36da862086
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 29 14:44:40 2013 +0530
cluster/afr: Print self-heal log when self-heal succeeds
Change-Id: I95e47e589419dc6a032cbd8ba01964b6c176c2d5
BUG: 927146
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5408
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d69f2f47d00158bbecbccd13cbdb1e9fa1f65496
Author: shishir gowda <sgowda@redhat.com>
Date: Thu Jun 20 14:06:04 2013 +0530
Revert "storage/posix: Remove the interim fix that handles the gfid race"
This reverts commit 97807e75956a2d240282bc64fab1b71762de0546.
In a distribute or distribute-replica volume, this fix is required to prevent
gfid mis-match due to race issues.
test script bug-767585-gfid.t needs a sleep of 2, cause after setting backend
gfid directly, we try to heal, and with this fix, we do not allow setxattr of
gfid within creation of 1 second if not created by itself
Change-Id: Ie3f4b385416889fd5de444638a64a7eaaf24cd60
BUG: 951195
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5240
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 5ccf0d567eff4140f9d322040d73b6ce63214a9e
Author: shishir gowda <sgowda@redhat.com>
Date: Fri Jul 26 11:59:12 2013 +0530
cluster/dht: Treat migration failures due to space constraints as skipped
Currently rebalance/remove-brick op's display migration failed count even
for files which failed due to space issues (not enough space for file, or
migration leading to cluster imbalance)
These will now be counted as skipped, and rebalance/remove-brick status
will display the additional counter
Change-Id: I674904d380b5f8300e9ca9e6af557c3d30d6cff4
BUG: 989846
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5399
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 76a50046cd46dbd125491590214acc13bdfb52ad
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jul 30 18:22:48 2013 +0200
build: use -Werror=implicit-function-declaration to detect build issues
There have been review requests that include a call to a non-existent
function. These problems should be detected as early as possible,
preferably before (automated) regression tests.
Bug: 990243
Change-Id: Idcf4d27f45a1a6177105d02a039363702eb8e3b9
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5435
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit efa2d99bb62ff309d93f697e4fe74913dc9c1c9d
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Jul 30 12:29:35 2013 +0530
api: Avoid a NULL deref in glfs_open().
Change-Id: I23e9fabcb8a430bcd44595ca31460c54d7bd4a39
BUG: 953694
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5426
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d4a8bb049aad8be64007c2334dce7f295a2da9d9
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Sep 18 14:07:40 2012 -0400
libglusterfs/client_t client_t implementation, phase 1
Implementation of client_t
The feature page for client_t is at
http://www.gluster.org/community/documentation/index.php/Planning34/client_t
In addition to adding libglusterfs/client_t.[ch] it also extracts/moves
the locktable functionality from xlators/protocol/server to libglusterfs,
where it is used; thus it may now be shared by other xlators too.
This patch is large as it is. Hooking up the state dump is left to do
in phase 2 of this patch set.
(N.B. this change/patch-set supercedes previous change 3689, which was
corrupted during a rebase. That change will be abandoned.)
BUG: 849630
Change-Id: I1433743190630a6d8119a72b81439c0c4c990340
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/3957
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 14b60497f38c988183612571a05f41f5a136b7b0
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Jul 29 15:28:44 2013 +0530
cluster/dht: Allow non-local clients to function with nufa volumes.
nufa fails to init if a local brick is not found as of today.
With this patch, if a local brick is not found, nufa switches
over to dht mode of operations.
Change-Id: I50ac1af37621b1e776c8c00a772b8e3dfb3691df
BUG: 980838
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5414
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7fa8a8667683a9552c7b51e1ccd2d6e96446cddc
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Jul 25 14:58:46 2013 +0530
glusterd: Fixing create force issues while it returned true everytime.
Now geo-rep create force will return true if a node is down, and log an
appropriate message. It will also return true with an appropriate log
message if the slave verification fails.
However it will not return true if the config file is deleted, ot corrupted,
so as not to get the state_file's path. It will also fail if the slave url
is invalid. If the push-pem option is given and
/var/lib/glusterd/geo-replication/common_secret.pem.pub is not present, then
also the create force command will fail.
Change-Id: Ie7532a0884ddf9c3008bd30832d171d5b53b540e
BUG: 988314
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5405
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 182194e068afb2b88488a877b3ea8a584ab31232
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 29 12:36:10 2013 +0530
libglusterfs: Fix compilation warning
Change-Id: Ibba7a6fd3119c85c78cb12628d85c7f9210e6b8c
BUG: 928648
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5412
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 609e8eef9fc1eaded809aedfdde1baff2d446571
Author: Anand Avati <avati@redhat.com>
Date: Sun Jul 21 00:43:18 2013 -0700
gfapi: handle failures in graph switches
A graph switch failure can potentially result in NULL returned
for glfs_active_subvol(). Handle this gracefully in glfs_subvol_done()
Change-Id: I6adbd878c354b9ed2314fc71cea4671792efa0a4
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5407
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2107dd6147c8cf901cddca1e4cf8fce9fcce215d
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Feb 27 16:55:09 2013 +0530
cli : Display error messages if virt file has been deleted or is invalid.
"gluster volume set <VOLNAME> group virt" will display error message
if virt file is deleted or is invalid.
Change-Id: Icb202b6a445597fcd9a3dcef8001891f2601a115
BUG: 916127
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4586
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6b79725ba6e27fd349ad3d514f4bb4cc3932119c
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Thu Jul 25 17:27:52 2013 +0200
glusterfsd: TRACE is a valid log level too
Change-Id: Ia17513817f8f6d7a4a8732fc0cfee21f16a75fac
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5401
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 47c98ee3ae1041e7090595664a326ed0a2bf50fd
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Apr 23 00:58:22 2013 +0530
cli, glusterd: Cleanup logging of bd op commands.
This patch prevents messages of the form "bd op: %s : SUCCESS"
from being logged in .cmd_log_history.
Change-Id: Iebeb7e26d409bf99b9c8df0a5c1c5a5d30d78a61
BUG: 823081
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4871
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: M. Mohan Kumar <mohan@in.ibm.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6f1f8d1857976b834b691ee4109532b975d19bcb
Author: Anand Avati <avati@redhat.com>
Date: Sat Jul 20 15:04:48 2013 -0700
tests: fix test script to turn on write-behind
Change-Id: I8a3ddc8183355236ff7725229441e27bbf8188e3
BUG: 927146
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5406
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e51aa01ea891c50eef117cb984e482fd5f11a31e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jun 27 02:24:36 2013 +0530
mgmt/glusterd: let each brick write the valgrind o/p to different file
Till now all the brick processes were writing the valgrind information
to the same log file.
Change-Id: I0251c943935e2901b729c71f21d0677edb9f6867
BUG: 922877
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/5394
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 81b84b7a0a9d17ae25b6ce15c98b5475c0e16ac0
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Thu Jul 25 17:16:13 2013 +0200
fuse-bridge: Cure some unhealthy format strings
Mostly sign errors:
Before:
0-glusterfs-fuse: 74: CREATE() /FILE => 0x1e9de9c (ino=-7793743383831318294)
0-glusterfs-fuse: 76: SETATTR() /FILE => -7793743383831318294
...
After:
0-glusterfs-fuse: 109: CREATE() /FILE => 0x267fe9c (ino=12597207469970374167)
0-glusterfs-fuse: 111: SETATTR() /FILE => 12597207469970374167
...
Change-Id: I422d2397fe071b0ac155b8c7e8a40a3365d6d58c
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/5402
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5e3b4303bded49235e22aa506a78a3fb4c172174
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jul 10 17:32:41 2013 +0530
glusterd/cli changes for distributed geo-rep
Commands:
gluster system:: execute gsec_create
gluster volume geo-rep <master> <slave-url> create [push-pem] [force]
gluster volume geo-rep <master> <slave-url> start [force]
gluster volume geo-rep <master> <slave-url> stop [force]
gluster volume geo-rep <master> <slave-url> delete
gluster volume geo-rep <master> <slave-url> config
gluster volume geo-rep <master> <slave-url> status
The geo-replication is distributed. The session will be created, and
gsyncd will be spawned on all relevant nodes, instead of only one
node.
geo-rep: Collecting status detail related data
Added persistent store for saving information about
TotalFilesSynced, TotalSyncTime, TotalBytesSynced
Changes in the status information in socket:
Existing(Ex):
FilesSynced=2;BytesSynced=2507;Uptime=00:26:01;
New(Ex):
FilesSynced=2;BytesSynced=2507;Uptime=00:26:01;SyncTime=0.69978;
TotalSyncTime=2.890044;TotalFilesSynced=6;TotalBytesSynced=143640;
Persistent details stored in
/var/lib/glusterd/geo-replication/${mastervol}/${eSlave}-detail.status
Change-Id: I1db7fc13ffca2e415c05200b0109b1254067f111
BUG: 847839
Original Author: Avra Sengupta <asengupt@redhat.com>
Original Author: Venky Shankar <vshankar@redhat.com>
Original Author: Aravinda VK <avishwan@redhat.com>
Original Author: Amar Tumballi <amarts@redhat.com>
Original Author: Csaba Henk <csaba@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5132
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d6b0b062e8989831361e883dad96f2469477c170
Author: Avra Sengupta <asengupt@redhat.com>
Date: Sat Jun 1 16:17:57 2013 +0530
gsyncd: distribute the crawling load
* also consume changelog for change detection.
* Status fixes
* Use new libgfchangelog done API
* process (and sync) one changelog at a time
Change-Id: I24891615bb762e0741b1819ddfdef8802326cb16
BUG: 847839
Original Author: Csaba Henk <csaba@redhat.com>
Original Author: Aravinda VK <avishwan@redhat.com>
Original Author: Venky Shankar <vshankar@redhat.com>
Original Author: Amar Tumballi <amarts@redhat.com>
Original Author: Avra Sengupta <asengupt@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5131
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit a7d1740ef900c10e491b3bc1af160e5940df08d8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Feb 26 16:12:11 2013 +0530
cluster/afr: Handle REPLICATE_TRASH_DIR from old bricks
Change-Id: Ib99f79d3fa607c818dbc62006516480f598d8add
BUG: 886998
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4640
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e7dbb395c70fb2568d15efeaec64c2d199a87237
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Jul 25 20:10:55 2013 -0700
build: Add '--without bd' to disable 'bd' xlator rpmbuild
Change-Id: I9f1774788362d8250693002318b617cd16e1a668
BUG: 950083
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5397
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Bala FA <barumuga@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 591c8e0d3699ee9f07d7400e187283cf782c31a6
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Jul 25 17:12:21 2013 +0530
doc: Create a features folder.
Moved rdma and bd documents to doc/features. Added a new
document on rebalance.
Change-Id: I04269202adc9605754fc29876433c88480b822a3
BUG: 811311
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5395
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 57bd2d46fb44d038a5efd901efc1d7db0c5c2921
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jul 24 00:01:19 2013 +0530
features/changelog: fixes when enabling changelog
Other enhancements being:
* ignore fops made by rebalance
* ignore internally triggered fops
BUG: 987734
Change-Id: I7dd164ae3c209fdb8ec43a27e67b8846f937c93b
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5380
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a25ea512a2d4be9cb60d92a9285913e22309c9f3
Author: Harshavardhana <harsha@harshavardhana.net>
Date: Thu Jul 18 20:52:36 2013 -0700
glusterfsd: is_mgmt_rpc_reconnect should not be `char` but gf_boolean_t
Change-Id: I35c4dc040ebb5e926c7f54d823d1c81b1228bd4f
BUG: 763046
Signed-off-by: Harshavardhana <harsha@harshavardhana.net>
Reviewed-on: http://review.gluster.org/5345
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4abb19bcf1d8391e0e4a23169cb9a8a075874d49
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 5 23:50:52 2013 +0530
write-behind: preserve error returned as-is
Change-Id: Ib766403774c1323e0bbddafedeaa47e7fa3a59fa
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 987415
Reviewed-on: http://review.gluster.org/5296
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1a3fd0d0a8be96d3519889a6296cb1d5313c70aa
Author: Anand Avati <avati@redhat.com>
Date: Thu May 2 23:36:01 2013 -0700
core: increase the auxillary group limit to 65536
Make the allocation of groups dynamic and increase the limit
to 65536.
Change-Id: I702364ff460e3a982e44ccbcb3e337cac9c2df51
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5111
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 04b5a5bf0fa6fcff1b9b029e69dee297015b0e78
Author: susant <spalai@redhat.com>
Date: Wed Jul 24 14:11:55 2013 +0530
cli :remove-brick process output leads to ambiguity
The output of remove-brick status as "Not started" leads to
ambiguity.We should not show the status of the Server nodes
which do not participate in the remove-brick process.
Change-Id: I85fea40deb15f3e2dd5487d881f48c9aff7221de
BUG: 986896
Signed-off-by: susant <spalai@redhat.com>
Reviewed-on: http://review.gluster.org/5383
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 00f0b1eae40acb0e51cf48ce9f117c3f61cbeb12
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jul 23 17:02:30 2013 +0530
features/marker: pass xdata in marker_unlink()
Change-Id: Ia310af96b25f29351f3adc4bbc97aea271df7673
BUG: 987747
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/5379
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 100ea413c291dafeaafec45add0a7adf99b13f47
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 24 11:25:07 2013 +0530
storage/posix: Fix conditional compiling for syncfs
Change-Id: Ief22e1c0f2b5074060752d70da41ae93f1028d62
BUG: 927146
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5381
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fb88d10fbee4ceec511aace1fbf6754da368ef35
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Thu Jul 4 16:07:59 2013 +0530
cli: gluster volume heal commands are more elaborative
1. "gluster volume heal volume-name"
output :Launching heal operation to perform index self heal on volume volume-name has been successful
2. "gluster volume heal volume-name full"
Output :Launching heal operation to perform full self heal on volume volume-name has been successful
3. "gluster volume heal volume-name info"
Output :Gathering list of entries to be healed on volume volume-name has been successful
4. "gluster volume heal volume-name info healed"
Output :Gathering list of healed entries on volume volume-name has been successful
5. "gluster volume heal volume-name info split-brain"
Output :Gathering list of split brain entries on volume volume-name has been successful
6. "gluster volume heal volume-name info heal-failed"
Output :Gathering list of heal failed entries on volume volume-name has been successful
Change-Id: I74c90e8129d23d513ddb7879358a9d21c94a5c0d
BUG: 978936
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/5286
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4e9c1c69fc643fac61d50d20262b3dbc5b1b735b
Author: shishir gowda <sgowda@redhat.com>
Date: Wed Jul 17 12:10:24 2013 +0530
cluster/dht: mark linkfile creation/deletion as internal fop
Currently dht creates/deletes linkfiles for various ops like
rename/linking and when layout changes. dht_linkfile_create
already sends a key GLUSTERFS_INTERNAL_FOP_KEY in dict to
identify this as an internal fop and not user based op.
Enhancing rename related links/unlinks to send this key too.
Marker/changelog or other xlators can now identify these as
internal fops and handle them accordingly
Change-Id: Ib1ca789e6dbce48703c55ad3f4f88f7cd2df3d06
BUG: 987428
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5335
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 132fefeffbcff171b9eb2c98068296c33f4179ad
Author: Anand Avati <avati@redhat.com>
Date: Fri Jul 19 08:31:41 2013 -0700
storage/posix: implement batched fsync in a single thread
Because of the extra fsync()s issued by AFR transaction, they
could potentially "clog" all the io-threads denying unrelated
operations from making progress.
This patch assigns a dedicated thread to issues fsyncs, as
an experimental feature to understand performance characteristics
with the approach.
As a basis, incoming individual fsync requests are grouped into
batches, falling in the same @batch-fsync-delay-usec window of
time. These windows can extend in practice, as processing of
the previous batch can take longer than @batch-fsync-delay-usec
while new requests are getting batched.
The feature support three modes (similar to the -S modes of fs_mark)
- syncfs: In this mode one syncfs() is issued per batch, instead
of N fsync()s (one per file.)
- syncfs-single-fsync: In this mode one syncfs() is issued per
batch (which, on Linux, guarantees the completion of write-out
of dirty pages in the filesystem up to that point) and one single
fsync() to synchronize or flush the controller/drive cache. This
corresponds to -S 2 of fsmark.
- syncfs-reverse-fsync: In this mode, one syncfs() is issued per
batch, and all the open files in that batch are fsync()'ed in
the reverse order of the queue. This corresponds to -S 4 of
fsmark.
- reverse-fsync: In this mode, no syncfs() is issued and all the
files in the batch are fsync()'ed in the reverse order. This
corresponds to -S 3 of fsmark.
Change-Id: Ia1e170a810c780c8d80e02cf910accc4170c4cd4
BUG: 927146
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4746
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5f3e787af9dbdc03185f2658c6bc38972b61789a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jul 23 14:06:56 2013 +0530
tests: Avoid timing delays caused by fsync
Change-Id: I2da53dd14d7352bdc878fce5a9019a955e150ce9
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5377
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 82b4b82ab3c3bdbfbdbff88f6fed1fe786197084
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Mon Jul 22 19:00:53 2013 +0530
cli: Increased timeout for gluster volume heal commnads
Problem:
If number of files are very large, then gluster volume heal
volumename info commnads take large time. So timeout of 2
minutes seems to be insufficient.
Fix:
Increased timeout to 10 minutes
Change-Id: I5f847163e01c4afbb587b726833ad80183f1a928
BUG: 986945
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/5372
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7136f1de6b1708335ddbf309d5fe1595ad6ec54b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jul 22 16:44:09 2013 +0530
cluster/afr: Handle parallel hardlinks self-heal
Change-Id: Ieda11870c65edae500140b6c061f15a7b3f264f3
BUG: 986905
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5370
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c08bb84a7721b49a30d8afcd449772d1ecbc8775
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jul 22 19:14:56 2013 +0530
glusterfsd: Use dynamic volfile buffer
Glusterfsd used a fixed buffer to store volfiles fetched via getspec.
This caused problems with large volfiles. Changining this to a dynamic
buffer allows large volfiles to be loaded in memory.
Change-Id: I40236dcb1c37b9a0136dfb5231cafabb3d4f00dc
BUG: 986100
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5373
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 458bf0540ecbbafe16f4ecf1885331da96160882
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon May 27 22:23:57 2013 +0530
move 'xlators/marker/utils/' to 'geo-replication/' directory
Change-Id: Ibd0faefecc15b6713eda28bc96794ae58aff45aa
BUG: 847839
Original Author: Amar Tumballi <amarts@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5133
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0b16509fef37ad9413305055aff3688abaefe5d8
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Jun 4 14:20:58 2013 +0530
features/changelog: changelog translator
This is the initial version of the Changelog Translator.
What is it
-----------
Goal is to capture changes performed on a GlusterFS volume.
The translator needs to be loaded on the server (bricks) and
captures changes in a plain text file inside a configured
directory path (controlled by "changelog-dir", should be
somewhere in <export>/.glusterfs/changelog by default).
Changes are classified into 3 types:
- Data: : TYPE-I
- Metadata : TYPE-II
- Entry : TYPE-III
Changelog file is rolled over after a certain time interval
(defauls to 60 seconds) after which a changelog is started.
The thing to be noted here is that for a time interval
(time slice) multiple changes for an inode are recorded only
once (ie. say for 100+ writes on an inode that happens within
the time slice has only a single corresponding entry in the
changelog file). That way we do not bloat up the changelog
and also save lots of writes.
Changelog Format
-----------------
TYPE-I and TYPE-II changes have the gfid on the entity on
which the operation happened. TYPE-III being a entry op
requires the parent gfid and the basename. Changelog format
has been kept to a minimal and it's upto the consumers to
do the heavy loading of figuring out deletes, renames etc..
A single changelog file records all three types of changes,
with each change starting with an identifier ("D": DATA,
"M": METADATA and "E": ENTRY). Option is provided for the
encoding type (See TUNABLES).
Consumers
----------
The only consumer as of today would be geo-replication, although
backup utilities, self-heal, bit-rot detection could be possible
consumers in the future.
CLI
----
By default, change-logging is disabled (the translator is present
in the server graph but does nothing). When enabled (via cli) each
brick starts to log the changes. There are a set of tunable that
can be used to change the translators behaviour:
- enable/disable changelog (disabled by default)
gluster volume set <volume> changelog {on|off}
- set the logging directory (<brick>/.glusterfs/changelogs is the
default)
gluster volume set <volume> changelog-dir /path/to/dir
- select encoding type (binary (default) or ascii)
gluster volume set <volume> encoding {binary|ascii}
- change the rollover time for the logs (60 secs by default)
gluster volume set <volume> rollover-time <secs>
- when secs > 0, changelog file is not open()'d with O_SYNC flag
- and fsync is trigerred periodically every <secs> seconds.
gluster volume set <volume> fsync-interval <secs>
features/changelog: changelog consumer library (libgfchangelog)
A shared library is provided for the consumer of the changelogs
for easy acess via APIs. Application can link against this library
and request for changelog updates. Conversion of binary logs to
human-readable ascii format is also taken care by the library which
keeps a copy of the changelog in application provided working
directory.
Change-Id: I75575fb7f1c53d2bec3dba1a329ea7bb3c628497
BUG: 847839
Original Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5127
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 97140404a2f385e32e42465c4dcc822d19d329fb
Author: Bala.FA <barumuga@redhat.com>
Date: Tue May 14 14:53:07 2013 +0530
log: send current gf_log to syslog conditionally
When compile time option GF_USE_SYSLOG is enabled (which is default),
generated logs are sent to syslog with error code ERR_DEV.
User can opt to use traditional log at run time by creating
/var/log/glusterd/logger.conf file and restarting respective gluster
services.
Change-Id: I9837d0f99da1afc2189d7ecd214c4293ec53715a
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/5002
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 75eedc4b8a8f591aa8780f4c1eec8e6be672b24c
Author: Bala.FA <barumuga@redhat.com>
Date: Tue Apr 30 17:39:30 2013 +0530
log: enhance syslog logging using CEE format
This patch enables to use syslog as log target in addition to the
default. The logs are sent in CEE format (http://cee.mitre.org/).
This logging can be disabled using compile time option by
./configure --disable-syslog
(or)
rpmbuild glusterfs.tar.gz --without syslog
The framework provides two api
void gf_openlog (const char *ident, int option, int facility);
void gf_syslog (int error_code, int facility_priority, char *format, ...);
consumers need to call gf_openlog() prior to gf_syslog() like the way
traditional syslog function calls. error_code is mandatory when using
gf_syslog(). For example,
gf_openlog (NULL, -1, -1);
gf_syslog (GF_ERR_DEV, LOG_ERR, "error reading configuration file");
Using syslog, admin is free to configure logger to
* reduce repeated log messages
* forward logs to remote logger
* execute a command on certain log pattern
* alert people for certain log pattern by email, snmp etc
* and many more
Change-Id: Ibacbcbbc547192893fc4a46b387496b622e4811f
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/4915
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e130fd15d96455820eefa465dd5e33c9c04b56e7
Author: Bala.FA <barumuga@redhat.com>
Date: Fri May 10 12:30:17 2013 +0530
log: error code generation support
error code and message are generated at compile time by reading a json
file which contains information of elements for each error code. This
framework provides error handling and ability to do more cleaner log
messages to users.
error-codes.json file contains error description is below format
{
"ERR_NAME": {"code": ERR_NUM,
"message": {"LOCALE": "ERR_MESSAGE"}}
}
At compile time autogen.sh calls gen-headers.py which produces C
header file libglusterfs/src/gf-error-codes.h. This header has a
function
const char *_gf_get_message (int code);
which returns respective ERR_MESSAGE for given ERR_NUM.
Change-Id: Ieefbf4c470e19a0175c28942e56cec98a3c94ff0
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/4977
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 41bd34f782f4326369912c2a95aa623b60044273
Author: Raghavendra G <rgowdapp@redhat.com>
Date: Tue Jul 16 11:49:20 2013 +0530
fuse: auxiliary gfid mount support
* files can be accessed directly through their gfid and not just
through their paths. For eg., if the gfid of a file is
f3142503-c75e-45b1-b92a-463cf4c01f99, that file can be accessed
using <gluster-mount>/.gfid/f3142503-c75e-45b1-b92a-463cf4c01f99
.gfid is a virtual directory used to seperate out the namespace
for accessing files through gfid. This way, we do not conflict with
filenames which can be qualified as uuids.
* A new file/directory/symlink can be created with a pre-specified
gfid. A setxattr done on parent directory with fuse_auxgfid_newfile_args_t
initialized with appropriate fields as value to key "glusterfs.gfid.newfile"
results in the entry <parent>/bname whose gfid is set to args.gfid. The
contents of the structure should be in network byte order.
struct auxfuse_symlink_in {
char linkpath[]; /* linkpath is a null terminated string */
} __attribute__ ((__packed__));
struct auxfuse_mknod_in {
unsigned int mode;
unsigned int rdev;
unsigned int umask;
} __attribute__ ((__packed__));
struct auxfuse_mkdir_in {
unsigned int mode;
unsigned int umask;
} __attribute__ ((__packed__));
typedef struct {
unsigned int uid;
unsigned int gid;
char gfid[UUID_CANONICAL_FORM_LEN + 1]; /* a null terminated gfid string
* in canonical form.
*/
unsigned int st_mode;
char bname[]; /* bname is a null terminated string */
union {
struct auxfuse_mkdir_in mkdir;
struct auxfuse_mknod_in mknod;
struct auxfuse_symlink_in symlink;
} __attribute__ ((__packed__)) args;
} __attribute__ ((__packed__)) fuse_auxgfid_newfile_args_t;
An initial consumer of this feature would be geo-replication to
create files on slave mount with same gfids as that on master.
It will also help gsyncd to access files directly through their
gfids. gsyncd in its newer version will be consuming a changelog
(of master) containing operations on gfids and sync corresponding
files to slave.
* Also, bring in support to heal gfids with a specific value.
fuse-bridge sends across a gfid during a lookup, which storage
translators assign to an inode (file/directory etc) if there is
no gfid associated it. This patch brings in support
to specify that gfid value from an application, instead of relying
on random gfid generated by fuse-bridge.
gfids can be healed through setxattr interface. setxattr should be
done on parent directory. The key used is "glusterfs.gfid.heal"
and the value should be the following structure whose contents
should be in network byte order.
typedef struct {
char gfid[UUID_CANONICAL_FORM_LEN + 1]; /* a null terminated gfid
* string in canonical form
*/
char bname[]; /* a null terminated basename */
} __attribute__((__packed__)) fuse_auxgfid_heal_args_t;
This feature can be used for upgrading older geo-rep setups where gfids
of files are different on master and slave to newer setups where they
should be same. One can delete gfids on slave using setxattr -x and
.glusterfs and issue stat on all the files with gfids from master.
Thanks to "Amar Tumballi" <amarts@redhat.com> and "Csaba Henk"
<csaba@redhat.com> for their inputs.
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Change-Id: Ie8ddc0fb3732732315c7ec49eab850c16d905e4e
BUG: 952029
Reviewed-on: http://review.gluster.com/#/c/4702
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/4702
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5093f2177ad61867b073f5c4b4c134abf31d266d
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jul 18 09:55:22 2013 -0400
core: avoid infinite mutual recursion between THIS and gf_log
This caused a stack overflow when (for some unknown reason) pthread_setspecific
was failing. Therefore __glusterfs_this_location called gf_log which used THIS
which wraps __glusterfs_this_location which . . . you get the idea. We have to
break the loop somewhere, and we can't reasonably make _gf_log stop using THIS,
so we make __glusterfs_this_location stop using _gf_log.
Change-Id: I79c3ea40dd7980bb8ac76a52cdbf5c057b2e1c3c
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/5341
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cedffcedba0a2e1b4043b07b332f8e9c9062db22
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Jul 17 11:17:04 2013 -0400
mount/fuse: unlink the inode on revalidate if entry not found
If an inode/dentry is linked via a client and removed via a
separate client, the inode/dentry mapping in the initial client
remains. A lookup of the removed name on the initial client
typically returns ENOENT once the associated caches expire. If the
initial client has multiple dentries linked to the same inode,
however, lookups on the non-removed dentry create windows of time
where lookups on the stale/removed name return successfully. This
occurs because the stale mapping resolves to the still valid inode
and tricks md-cache into returning valid lookup data.
To correct this situation, unlink the stale inode mapping on a
failed (ENOENT) revalidation lookup (i.e., when fuse has resolved
the inode but a lookup returns ENOENT). Note that with this change,
the state still occurs until an md-cache window has expired,
allowed a lookup to pass through to the server and given the fuse
translator an opportunity to clean up.
Change-Id: I47dde2f11e2ef5b8dd51e9ac8be0f36cdb5081a3
BUG: 985074
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5337
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e331e5a75ebf14ae2211c8379ebc1d87c64053e1
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Jul 18 11:13:08 2013 +0200
include <limits.h> for PATH_MAX
I need to include <limits.h> in order to use PATH_MAX, Otherwise it will
not build at mine. I believe it is standard compliant to do so:
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/limits.h.html
BUG: 764655
Change-Id: I3f124466f7f7742e94a9d1256bc9239ec16aab04
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/5340
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a0891687db751ada54b1e8699b1dc980f72a4298
Author: shishir gowda <sgowda@redhat.com>
Date: Wed Jun 5 15:56:27 2013 +0530
locks: Added an xdata-based 'cmd' for inodelk count in a given domain
Following is the semantics of the 'cmd':
1) If @domain is NULL - returns no. of locks blocked/granted in all domains
2) If @domain is non-NULL- returns no. of locks blocked/granted in that
domain
3) If @domain is non-existent - returns '0'; This is important since
locks xlator creates a domain in a lazy manner.
where @domain - a string representing the domain.
Change-Id: I5e609772343acc157ca650300618c1161efbe72d
BUG: 951195
Original-author: Krishnan Parthasarathi <kparthas@redhat.com>
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4889
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 88f3947482ccfbcb170ad27a4c6f5215cfa94fe6
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Jul 9 09:09:30 2013 +0530
dht: fix dht_discover_cbk doing a wrong layout set.
with the sequence of operations are like below, we have issues
with current code (MP == mountpoint):
T0,MP1# mkdir /abcd (Succeeds on hash_subvol)
T1,MP2# mkdir /abcd (Gets EEXIST as dir exists in hash_subvol)
T2,MP2# mkdir /.gfid/<abcd's gfid>/xyz (lookup happens on abcd's
gfid, calls dht_discover)
T3,MP1# (Completes mkdir(), goes to dir_selfheal to set the layouts).
T4,MP2# (dht_discover_cbk gets success for lookup as the entry
existed, as layout is not yet written, it says normalize
done, found holes).
T5,MP2# (as layout anomaly is not considered an issue in this patch,
dht_layout_set happens on inode, with all xlators pointing
to 0s)
T6,MP1# (completes mkdir call, inode has proper layouts)
T7,MP2# mkdir /.gfid/<abcd's gfid>/xyz fails with ENOENT
(with log saying no subvol found for hash value of xyz.
Porting Amar's fix from down-stream beta branch.
Change-Id: Ibdc37ee614c96158a1330af19cad81a39bee2651
BUG: 982913
Original-author: Amar Tumballi <amarts@redhat.com>
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5302
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cdaaf4b5a76468f7f55534ca8088ec3daf1783be
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Jul 16 15:58:03 2013 +0530
gfapi: fix for not able to rename folders
If oldname is being renamed to newname, we need to
check for type of newname only if newname exists.
Change-Id: I068a283f9ffe67fcd5e8754d6bf052a2339efbf2
BUG: 953694
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/5333
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0cafbcfaa883d8085dab8da4673699457a6ac3cf
Author: shishir gowda <sgowda@redhat.com>
Date: Thu Jul 11 13:44:51 2013 +0530
cluster/dht: Prevent dht_access from going into a loop.
If access fails with ENOTCONN, do not wind to same subvol.
We wind to first-up-subvol if access fails with ENOTCONN.
In few cases, if dht has only 1 subvolume, and access fails with
ENOTCONN, we go into a infinite loop of winding to same subvol
The fix is to check if we previously wound to same subvol, and
fail if first-up-subvol is same.
Change-Id: Ib5d3ce7d33e8ea09147905a7df1ed280874fa549
BUG: 983431
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5319
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 01a8ced811c8f0afef90a2848585a4e8fd5601c0
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jul 12 15:00:07 2013 +0200
tests: call 'cleanup' at the end of each test
Some tests do not cleanup after themselves. That is bad behaviour and
makes it difficult to run single tests and verify the state of the
system afterwards.
Change-Id: I4ac5401d790d6bc81e6975fd1384874b21d6cf8a
BUG: 983975
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5328
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit aefc060a8d7a9676793bb6c2ba410c7746690239
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Apr 29 20:30:30 2013 +0200
afr: customize client-pid=-1 xtime aggregation to tolerate a replica down
Using the new 'pluggable policies' API of libxlator.
Change-Id: Ie7528182dff8fb42c6e8287a106d3057944df775
BUG: 847839
Original Author: Csaba Henk <csaba@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4904
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6ecd1f9f747c0d1335b48bc4497b00cb72f79aca
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Mar 13 10:21:57 2013 +0100
libxlator: implement pluggable aggregation policies
The API is described in libxlator.h.
Behavior remains the same for this commit; this
is a preparatory step for per-translator customization
of aggregation.
Change-Id: I5d42923af59b2fd78e1ff59c12763875b57c5190
BUG: 847839
Original Author: Csaba Henk <csaba@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4903
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9bb9fbff61556c2cf6ed806ef1656c72612766ee
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Jun 13 19:38:57 2013 +0530
cluster/dht: node-uuid for directories winds to all subvolumes
this works similar to pathinfo now except that the request is sent
to all subvolumes of dht. Underlying replica selects it's subvolume
in a round-robin fashion till one of them returns successfully.
Change-Id: Ie46c5f7090d04d8c2e487b209916ae6791e94624
BUG: 847839
Original Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5225
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit adec05345d125f01888060d1a2dba3e8a5ffa480
Author: Justin Clift <jclift@redhat.com>
Date: Thu Jul 4 18:33:50 2013 +0100
Adjust configure.ac to honor existing CFLAGS env variable
Change-Id: I43a8defc7a8c0c2d391e7bd2c0b7bebfcc522a2a
BUG: 961892
Signed-off-by: Justin Clift <jclift@redhat.com>
Reviewed-on: http://review.gluster.org/4979
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c16ec76ca00c772e67dc61268595f0008308bc48
Author: Avra Sengupta <asengupt@redhat.com>
Date: Sat Apr 27 12:44:05 2013 +0530
cluster/*: get logic to calculate min() of the 'stime' xattr
* in both distribute and replicate (ignoring stripe for now),
add logic to calculate the min() of stime values.
* What is a 'stime' ? Why is this required:
- stime means 'slave xtime', mainly used to keep track of slave
node's sync status when distributed geo-replication is used.
Logic of calculating 'min()' for this stime is very important as
in case of crashes/reboots/shutdown, we will have to 'restart'
with crawling from stime time value from the mount point, which
gives the 'min()' of all the bricks, which means, we don't miss
syncing any files in the above cases.
Change-Id: I2be8d434326572be9d4986db665570a6181db1ee
BUG: 847839
Original Author: Amar Tumballi <amarts@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4893
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5adde62d1c3bef20b244897c303a73c3cfafd60e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jul 11 12:52:11 2013 +0530
mount/fuse: Provide option to use/not use kernel-readdirp
By default fuse kernel readdirp usage in fuse xlator is off.
When mount option use-readdirp=yes is provided it starts using
fuse-kernel's readdirp.
Change-Id: Id37edc53b1adc1638186d956c2f74c1e4e48aa59
BUG: 983477
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5322
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 1a5d349ce5eb2652d8d68aaa5a482db6e4ca3592
Author: Ravishankar N <ravishankar@redhat.com>
Date: Mon Jul 8 15:45:54 2013 +0530
cli: check for null in is_server_debug_xlator()
Command: gluster volume set <volname> diagnostics.client-log-level trace
Expected output:
"volume set: failed: option log-level trace: 'trace' is not valid
(possible options are DEBUG, WARNING, ERROR, INFO, CRITICAL, NONE,
TRACE.)"
Current output: gluster cli receives a segmentation fault
Fix: check for NULL before calling strstr
Change-Id: If4c7a85a635849a388cf122543e12349c109643c
BUG: 982174
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/5298
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 68f6734a050aa6a6372e7155494ca755be6bdafa
Author: shishir gowda <sgowda@redhat.com>
Date: Thu Jul 11 11:52:25 2013 +0530
cluster/dht: Unlink dst file after cleanup during migration
If a rename happens during migration, unlink fails. This leads
to stale xattrs, and Sticky bits still being set.
By removing the xattrs and Sticky bits from dst (through fd ops),
the stale link file would be cleaned up eventually (even if unlink
fails on src).
Change-Id: Iec537d021905438327a20e1d811aa06e74034364
BUG: 983399
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5316
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a0965e32d96fe6370ac29b09e519997f55543c6a
Author: shishir gowda <sgowda@redhat.com>
Date: Thu Jul 11 13:05:55 2013 +0530
cluster/dht: If linkfile unlink fails with ENOTCONN, do not fail
Currently if linkfile fails with ENOENT, we do not fail. We also
need to treat failures with ENOTCONN as success, as if cached subvol
is up, rm of a file should succeed. A stale linkfile will get removed
later
Change-Id: I71d136847933351ed9e2c939bda4a69bc96a3cfc
BUG: 983416
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5317
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 78a132c14cfe39435ba3b6d6d7e86278232ad447
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jul 11 14:28:41 2013 +0530
glusterd: Give up biglock before brick's rpc unref
This is to prevent the possibility of a deadlock when
rpc_connection_cleanup being called in the same thread as rpc_clnt_unref
Change-Id: Ia4dcc0a8a6e6158d4ddec68b780fccbc4cd64adb
BUG: 962619
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5321
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cb508d45094e02b97129880f03abadc28399816c
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jul 8 16:06:31 2013 +0530
glusterd: Correct op-version of some options
New options being introduced in the master branch should now have
op-version set to the GD_OP_VERSION_MAX (3). Some of the options have
been backported to release-3.3 branch and hence should have their
op-version reduced. Some other options had op-version incorrectly set as
1.
Change-Id: If40325b7b2da7aa36f90261024117cd18cf51ef0
BUG: 981278
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5318
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1d899e8ad75e169e2e2a8eca66d3fd92dee6667d
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jun 26 16:50:53 2013 +0530
mount/fuse: expose 'glusterfs.gfid*' virtual xattr key
currently two keys are exposed:
'glusterfs.gfid' : output is 16byte binary gfid
'glusterfs.gfid.string' : output is 36 byte canonical format of gfid
e.g.
[root@supernova glusterfs]# getfattr -n glusterfs.gfid -e hex f0
glusterfs.gfid=0x68305acb73e541719804fcf36a4857e8
[root@supernova glusterfs]# getfattr -n glusterfs.gfid.string f0
glusterfs.gfid.string="68305acb-73e5-4171-9804-fcf36a4857e8"
early consumers for this key would be geo-replication
(as it has being designed to do namespace operations on
gfid from the mount point, thereby needing the GFID for
entry operations on the slave).
Change-Id: I10b23dbd11628566ad6924334253f5d85d01a519
BUG: 847839
Original Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/5129
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7b4f9954888d52358f2437885e3d2f1d86e59495
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu May 23 08:30:55 2013 +0530
tests: Don't use stripe-replicate volume in bug-905864.t
Today, stripe doesn't follow a deterministic order in sending posix
locks to its subvolume. This may lead to dead locks. To avoid
intermittent test failures, we modify bug-905864.t to run on replicate
volume.
Change-Id: I38b72f30bc31576d3ca642f0029cc8749314b1dd
BUG: 905864
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5072
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 61a8798ec09ee151a336baf251c686274d295724
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Jun 20 14:04:10 2013 +0530
performance/io-cache: check for non-null gfid before calling inode_path
A new non-linked inode is added to lru list. Hence it might be possible
that gfid might be NULL when inode_dump is called. To pass asserts in
inode_path, we've to check for non-null gfid before invoking that
procedure.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: Iff14efc6d6e2faa33b9f7a81e0a66f6a947b77ed
BUG: 976189
Reviewed-on: http://review.gluster.org/5241
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8c1137f221cafbdf477df8b620fe60403ddbd9a2
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jun 27 18:05:54 2013 +0200
test-ffop: the result of (O_TRUNC|O_RDONLY) is unspecified
On RHEL-6 an open(.., O_TRUNC|O_RDONLY) fails. test-ffop expects this to
succeed, but the behaviour is unspecified according to 'man 2 open':
O_TRUNC
If the file already exists and is a regular file and the open
mode allows writing (i.e., is O_RDWR or O_WRONLY) it will be
truncated to length 0. If the file is a FIFO or terminal device
file, the O_TRUNC flag is ignored. Otherwise the effect of
O_TRUNC is unspecified.
Change-Id: I76b55419871fc758cbe82532f9b75476a0c14101
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5268
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit c7f6748e0c93332a2676de73e33b1baaf8c91fc4
Author: shishir gowda <sgowda@redhat.com>
Date: Mon Jul 8 18:48:55 2013 +0530
cluster/dht: Ignore subvols with error in min-free-disk/inodes
Currently when selecting a alternative subvolume when hashed
subvol has exceeded min-free-disk/inodes, we do not check if
layouts have errors (including decommissioning). This leads
to data being written to those subvolumes, and in case of
decommissioning, will lead to data loss.
Change-Id: Ie0c6cf4a29d7c53d8a6d8a8c1bd595cf58a0012a
BUG: 982919
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5299
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b9e2caae125cb72cc57f72204d6b352e4ae8271b
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Fri May 31 18:17:21 2013 +0530
nfs: AUTH support for exported sub-directories
Problem: NFS allows exporting subdirectories but there is not support for
providing AUTH on per directory basis.
Fix: Modified nfs.export-dir to include AUTH parameters
e.g. nfs.export-dir "/dir1(10.1.1.2),/dir2(10.1.1.0/24|host1)
During mount operation NFS will check if the IP from where the connection is made
is configured in the AUTH parameter, else the mount operation will fail with
EACCES error.
Updated admin-guide and volume set help message.
Change-Id: I5c6d22edb168b4f46376d1cd6878cd065fc081cc
BUG: 968227
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/5124
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 08e43f7a27c19a7f3559611c775894e79bd1aa19
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Jul 3 13:02:29 2013 +0530
doc: Moved non-relevant documentation files to legacy
Change-Id: I2d34e5a4e47cd03d301d9fd2525fb61ae997fcb8
BUG: 811311
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5277
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 486b7ea294aa06664f8b5f6042cfdda5803ade5b
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu May 2 15:29:56 2013 +0530
afr : change the log level in lookup path to minimize incessant logging.
Change the logging levels from WARNING to DEBUG in the lookup path to
minimize incessant logging in case of gfid mismatch errors.
Change-Id: I631b16df3249cf826606f547531f985dac696088
BUG: 959083
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/4939
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e2bd21cd6efe5aede7583335a949bb0afca22b79
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jul 4 16:49:58 2013 +0530
glusterd: Bump GD_MAX_OP_VERSION
Change-Id: I7a212435ce7e98fe01aad2c0d1f698de8ea84235
BUG: 981278
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5287
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c11adcb6d514ed86c528534f64fc6c392b0615ca
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Jul 3 10:24:50 2013 +0530
api: Bump version to 5.
version 5 adds support for fallocate & discard.
Change-Id: Ifdc226953a25e4a4eb63e55d2a7c7ec77c397215
BUG: 953694
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5276
Reviewed-by: Bharata B Rao <bharata.rao@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 276cd6b1305c381261e1d6b149ff2aa5de811351
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jun 27 17:59:43 2013 +0530
nufa: allow subvols with fanout > 1
Previously, nufa wouldn't work on volume topologies such as
distribute-replicate or distribute-stripe.
Change-Id: Ia89ed4412a00601022c1fc94f046056ce4820fe8
BUG: 980838
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5262
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 73dfe66438c29fbbd4d6fded577f70d338c2d5a6
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jun 27 14:55:59 2013 +0530
glusterd/common-utils: move hostname helper functions to common-utils
Change-Id: If47e209cb61ea0eb74ee2d6ef9e9342b2d6ee13a
BUG: 980838
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5261
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5857c1d3cad6a1e70e711041c313b1fe3b32e545
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Wed Jun 19 17:54:31 2013 +0530
cli: Fix remove brick cli out for wrong volume name
Problem: gluster volume remove-brick command, was not printing the error in
case of volume-name specified is wrong.
Fix: Fix will print error message to indicate that provided volume name is
invalid. Although patch for bug 961669
http://review.gluster.org/#/c/4975/ does print cli-output now, but
still xml is unable to use the response values
Change-Id: I2ee1df86c1e756fb8e93b4d6bbdd102b4f368f87
BUG: 961307
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4972
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 66010397302b2142917a52b8436f952c6c377559
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jun 24 14:05:58 2013 +0200
posix: add a simple health-checker
Goal of this health-checker is to detect fatal issues of the underlying
storage that is used for exporting a brick. The current implementation
requires the filesystem to detect the storage error, after which it will
notify the parent xlators and exit the glusterfsd (brick) process to
prevent further troubles.
The interval the health-check runs can be configured per volume with the
storage.health-check-interval option. The default interval is 30
seconds.
It is not trivial to write an automated test-case with the current
prove-framework. These are the manual steps that can be done to verify
the functionality:
- setup a Logical Volume (/dev/bz970960/xfs) and format is as XFS for
brick usage
- create a volume with the one brick
# gluster volume create failing_xfs glufs1:/bricks/failing_xfs/data
# gluster volume start failing_xfs
- mount the volume and verify the functionality
- make the storage fail (use device-mapper, or pull disks)
# dmsetup table
..
bz970960-xfs: 0 196608 linear 7:0 2048
# echo 0 196608 error > dmsetup-error-target
# dmsetup load bz970960-xfs dmsetup-error-target
# dmsetup resume bz970960-xfs
# dmsetup table
...
bz970960-xfs: 0 196608 error
- notice the errors caught by syslog:
Jun 24 11:31:49 vm130-32 kernel: XFS (dm-2): metadata I/O error: block 0x0 ("xfs_buf_iodone_callbacks") error 5 buf count 512
Jun 24 11:31:49 vm130-32 kernel: XFS (dm-2): I/O Error Detected. Shutting down filesystem
Jun 24 11:31:49 vm130-32 kernel: XFS (dm-2): Please umount the filesystem and rectify the problem(s)
Jun 24 11:31:49 vm130-32 kernel: VFS:Filesystem freeze failed
Jun 24 11:31:50 vm130-32 GlusterFS[1969]: [2013-06-24 10:31:50.500674] M [posix-helpers.c:1114:posix_health_check_thread_proc] 0-failing_xfs-posix: health-check failed, going down
Jun 24 11:32:09 vm130-32 kernel: XFS (dm-2): xfs_log_force: error 5 returned.
Jun 24 11:32:20 vm130-32 GlusterFS[1969]: [2013-06-24 10:32:20.508690] M [posix-helpers.c:1119:posix_health_check_thread_proc] 0-failing_xfs-posix: still alive! -> SIGTERM
- these errors are in the log of the brick as well:
[2013-06-24 10:31:50.500607] W [posix-helpers.c:1102:posix_health_check_thread_proc] 0-failing_xfs-posix: stat() on /bricks/failing_xfs/data returned: Input/output error
[2013-06-24 10:31:50.500674] M [posix-helpers.c:1114:posix_health_check_thread_proc] 0-failing_xfs-posix: health-check failed, going down
[2013-06-24 10:32:20.508690] M [posix-helpers.c:1119:posix_health_check_thread_proc] 0-failing_xfs-posix: still alive! -> SIGTERM
- the glusterfsd process has exited correctly:
# gluster volume status
Status of volume: failing_xfs
Gluster process Port Online Pid
------------------------------------------------------------------------------
Brick glufs1:/bricks/failing_xfs/data N/A N N/A
NFS Server on localhost 2049 Y 1897
Change-Id: Ic247fbefb97f7e861307a5998a9a7a3ecc80aa07
BUG: 971774
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5176
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6cffee37d0e20b43bc9088275c15964214532475
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jul 3 09:45:41 2013 +0200
fuse: pass the mountflags to older (< 2.6.21) kernels
The change for Bug 853895 fixed mounting volumes read-only for recent
kernels. Older kernels fail the first mount() syscall, and the second
mount() did not add the 'mountflags'.
Full analysis and a description for reproducing is in the bugreport. The
test included in http://review.gluster.org/4163 would have caught this
problem when the tests are executed on RHEL-5 or similar systems.
Change-Id: I440591344a6a5af7b2018e37a2a1fda9de8b5ab2
Bug: 980770
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5278
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 68f536b507f4ddc5cac59f2de2133f973edad9cd
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Thu Jun 27 15:47:01 2013 +0530
cli: Fix in letter case in volume heal output
Change-Id: I25d13444c2cbff9b26642e91677ad1e09e77aa1e
BUG: 978936
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/5259
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit df79d943e1db4d814a54de3bd6eb1a6581e4b380
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 3 21:28:25 2013 +0530
cluster/afr: Let two data-self-heals compete in new domain
Problem:
At the moment data-self-heal acquires locks in following
pattern. It takes full file lock then gets xattrs on files on both
replicas. Decides sources/sinks based on the xattrs. Now it acquires
lock from 0-128k then unlocks the full file lock. Syncs 0-128k range
from source to sink now acquires lock 128k+1 till 256k then unlocks
0-128k, syncs 128k+1 till 256k block... so on finally it takes full file
lock again then unlocks the final small range block.
It decrements pending counts and then unlocks the full file lock.
This pattern of locks is chosen to avoid more than 1 self-heal
to be in progress. BUT if another self-heal tries to take a full
file lock while a self-heal is already in progress it will be put in
blocked queue, further inodelks from writes by the application will
also be put in blocked queue because of the way locks xlator grants
inodelks. So until the self-heal is complete writes are blocked.
Here is the code:
xlators/features/locks/src/inodelk.c - line 225
if (__blocked_lock_conflict (dom, lock) && !(__owner_has_lock (dom, lock))) {
ret = -EAGAIN;
if (can_block == 0)
goto out;
gettimeofday (&lock->blkd_time, NULL);
list_add_tail (&lock->blocked_locks, &dom->blocked_inodelks);
}
This leads to hangs in applications.
Fix:
Since we want to prevent two parallel self-heals. We let them compete
in a separate "domain". Lets call the domain on which the locks have
been taken on in previous approach as "data-domain".
In the new approach When a self-heal is triggered,
it acquires a full lock in the new domain "self-heal-domain".
After this it performs data-self-heal using the locks in
"data-domain" as before.
unlock the full file lock in "self-heal-domain"
With this approach, application's writevs don't have to wait
in pending queue when more than 1 self-heal is triggered.
Change-Id: Id79aef3dfa888945977fb9758374ac41c320d0d5
BUG: 967717
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5100
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 458bc0805a575c3f9abb9af1d5f8228fd38cbfc3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 3 21:21:48 2013 +0530
cluster/afr: Refactor inodelk to handle multiple domains
- afr_local_copy should not be memduping locked nodes, that would
mean that lock is taken in self-heal on those nodes even before
it actually takes the lock. So removed memdup code. Even entry
lock related copying (lockee info) is also not necessary for
self-heal functionality, so removing that as well. Since it is
not local_copy anymore changed its name.
- My editor changed tabs to spaces.
Change-Id: I8dfb92cb8338e9a967c06907a8e29a8404782d61
BUG: 967717
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5099
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c463cbdd9439848bca08d5f347c71d29e3181823
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jun 28 16:03:52 2013 +0530
cluster/afr: Provide an option to disable afr durability
Change-Id: I40eec20ca6b3f857245a2438883822e251077ee9
BUG: 979365
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5269
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 70fd9310f03e04aa9a912477e1af1553677a9654
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Jul 3 05:23:46 2013 +0530
cluster/afr: post-op should complete before starting flush
Problem:
At the moment afr-flush makes sure that a delayed post-op
is woken up but it does not wait for it to complete the
post-op before flush unwinds.
These are the steps that are happening:
1) flush fop comes on an fd which wakes up a delayed post-op
and continues with the flush fop.
2) post-op sends fsync on the wire.
3) flush completes and unwinds to fuse.
4) graph switch happens on the fuse mount disconnecting the
old graph's client connections to bricks.
5) xattrop after fsync fails with ENOTCONN because the
connections from old graph are taken down now.
Fix:
Wait for post-op to complete before starting to flush.
We could make flush act similar to fsync (i.e.) wind
flush as is but wait for post-op to complete before unwinding
flush, but it is better to send flush as the final fop. So
wind of flush will start after post-op is complete. Had to
change fsync to accommodate this change.
Change-Id: I93aa642647751969511718b0e137afbd067b388a
BUG: 980548
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5274
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 364e5d206f13f80297b9d918fe6e85fce15a8a13
Author: Kaushal M <kaushal@redhat.com>
Date: Thu May 16 16:03:52 2013 +0530
glusterd: More checks before starting rebalance/remove-brick
Check if a previous remove-brick operation has been committed before
starting a new rebalance/remove-brick task.
Change-Id: I553e5ba64a6a352ca91032ab1a17997051a4494e
BUG: 963541
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5019
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3a3fd0bb52664ebfb5e47f9d6ef49e8f00b1287a
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Jun 19 16:07:25 2013 +0530
store: Fix resource leaks in gf_store_iter_* functions
Also, removed (redundant) member fd from gf_store_iter_t
Change-Id: I40f0469997f77fa2f578a5495ca4ce285f1a59f2
BUG: 904065
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5243
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5c717622da50c0546975706978fe96483fbbb367
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri Jun 28 19:11:47 2013 +0530
cluster/afr: Allow data/entry self heal for metadata split-brain
Problem:
Currently whenever there is metadata split-brain, a variable
sh->op_failed is set to 1 to denote that self heal got failed.
But if we proceed for data self heal, even code-path of data
self heal also relies on the sh->op_failed variable. So if will
check for sh->op_failed variable and will eventually fails to
do data self heal. So needed a mechanism to allow data self heal
even if metadata is in split brain.
Fix:
Some data structure revamp is done in
http://review.gluster.com/#/c/5106/ fix and this patch is
based on the above fix. Now we can store which particular self-heal
got failed i.e GFID_OR_MISSING_ENTRY_SELF_HEAL, METADATA, DATA,
ENTRY. And we can do two types of self heal failure check.
1. Individual type check: We can check which among all four
(Metadata, Data, Gfid or missing entry, entry self heal)
got failed.
2. In afr_self_heal_completion_cbk, we need to make check
based on the fact that if any specific self heal got failed treat
the complete self heal as failure so that it will populate
corresponding circular buffer of event history accordingly.
Change-Id: Icb91e513bcc752386fc8a78812405cfabe5cac2d
BUG: 977797
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/5253
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e0f5fc97b8d117f43e815957aaa4c1ba515f6a88
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jun 24 12:50:32 2013 +0530
libglusterfs: Fix valid_host_name for consecutive dots
The valid_host_name() function must reject addresses with consecutive
dots in them.
Change-Id: I1749de80c66e8fbad63b2e014f79e0203906030e
BUG: 977246
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5249
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 38da32040c9586271b363cac10d7b12e75138444
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Jun 24 02:57:07 2013 +0530
extras/hook-scripts: Set of changes for new samba share method.
New method of creating a share of gluster volume
through samba eliminates the requirement of fuse
mount and changes in fstab.
glusterfs vfs plugin has to be specified as required
vfs object.
Path now is relative to the root of gluster volume.
/ signifies complete volume.
Change-Id: I3d80452cd58513ef59d6a816c1ab62ebc3b76a62
BUG: 953694
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/5247
Reviewed-by: José Rivera <jrivera@redhat.com>
Tested-by: José Rivera <jrivera@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 20f0b4764da7993c65c1cf5439f379bed915f85c
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jun 27 10:44:44 2013 -0400
build: sync glusterfs.spec.in with Fedora glusterfs.spec
* fix the hardening fix for shlibs
* use %{__sed} macro
* better short ChangeLog
* fix hard-coded path in extras/systemd/glusterd.service in, use @prefix@
Change-Id: I267244b68a97cbcd6f6ab62fc322c78db45023bb
BUG: 950083
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5264
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 89bc130ca6783bee23da9b8e8274252ba6874130
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Fri Jun 21 14:58:23 2013 +0530
nfs: exit when all volumes are disabled
Instead of triggering 4-5 error logs, when nfs is
disabled for all volumes, exit the process.
Change-Id: Ib286f143c4f74ba22f502aca0e7dcd0907db6563
BUG: 976750
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/5245
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5e9d1d8cbb9dbaf86f84141d9c66ad329ce6576e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jun 27 12:59:14 2013 +0530
cluster/afr: Handle NULL fdctx in fsync
Problem:
If fdctx is NULL in afr_fsync, process crashes because
of NULL dereference.
Fix:
if fdctx is NULL, always say witnessed unstable write so
that fsyncs are done properly. Handled fdctx being null
in afr_delayed_changelog_post_op otherwise fsync stub is
never resumed and the mount was hanging.
Change-Id: Icacc900e9be63c29db3325cb0e19cc250adebaac
BUG: 978794
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5258
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e05c33ca71eb4f95c6b9aa02f8b27d1da318a2c9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jun 28 09:01:08 2013 +0530
protocol/server: Initialize connection variable
Change-Id: I46badd812e9b936911ddd2793cef7ce30ec220a6
BUG: 979237
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5266
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f4a8ed2618f1a536c3a3796a5236c632e8b313f5
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jun 24 14:34:50 2013 +0200
build: declare lvm_lv_from_name() if it is missing from lvm2app.h
The bd-xlator can not be built successfully on certain Debian
distributions due to a missing declaration of lvm_lv_from_name(). This
function is available for linking, but it does not exist in the header
file.
This change adds a detection for lvm_lv_from_name() in both the library
for linking, and the declaration in the header file. If the 1st is
missing, the bd-xlator can not be built, and if only the 2nd one is
missing, we'll declare lvm_lv_from_name() ourselves. This makes it
possible to build the bd-xlator on the affected Debian distributions
too.
Change-Id: I0c823a7861b02bb5d9c1abb76ebfff92f272f9eb
BUG: 976946
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5250
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d956604c2bac9a0e6a91d30d46b1436098b08af6
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Jun 4 17:58:34 2013 +0530
nfs/auth: reject mounts if getaddrinfo fails
When nfs.addr-namelookup is turned on, if the
getaddrinfo call fails while authenticating client's
ip/hostname, the mount request is denied
Change-Id: I744f1c6b9c7aae91b9363bba6c6987b42f7f0cc9
BUG: 947055
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/5143
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0603f0bb50eee2500ea398a3f4976dfa84ef478f
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jun 26 13:25:22 2013 +0200
rpm: move the mount/api xlator to the glusterfs-api sub-package
The main glusterfs package included the xlator/api.so file which caused
a dependency on the glusterfs-api package:
# rpm -i glusterfs-3.4.0-0.6.beta3.el6.x86_64.rpm
error: Failed dependencies:
libgfapi.so.0()(64bit) is needed by glusterfs-3.4.0-0.6.beta3.el6.x86_64
Moving the mount/api xlator to the glusterfs-api package will prevent
the automatic dependency generator to add the dependency to the main
package.
Change-Id: I4650c40cdfe610b9b69bab07d262093854aa6583
BUG: 950083
Reported-by: Vijay Bellur <vbellur@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5255
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4ca3e302745ba4bb9c526675ca89eafebc874527
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Jun 17 13:44:10 2013 -0400
build: sync glusterfs.spec.in with Fedora glusterfs.spec
* add glusterfs-api and glusterfs-api-devel sub-packages
* add extras/systemd/glusterd.service. Use it (or extras/init.d/glusterd)
instead of the Fedora versions.
* restores ability to build glusterfs RPMs from the dist tarball with
'rpmbuild {-ts,-tb,-ta} glusterfs-XXX.tar.gz'
* other minor cleanups mostly to sync with fedora .spec and to build
from the dist tarball. Any differences will be resolved in the fedora
.spec in the next release (i.e. beta4 or GA).
(still considering whether to add fedora glusterfsd.{init,service} files
to glusterfs or remove them from fedora.)
BUG: 950083
Change-Id: Ibda3cd57b24ef5c2a27446703e718e5044ec546c
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5230
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Bala FA <barumuga@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit fe8ebf2ff2ffdc420a1245f96a29d6d10662a86f
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Jun 18 11:25:39 2013 +0530
doc: Move admin-guide to markdown format.
Editing markdown is probably more easier than xml.
pandoc can then be used for conversion to html, pdf and any other necessary
formats. Note that pandoc has the following input and output formats:
Input: markdown and (subsets of) Textile, reStructuredText, HTML, LaTeX, and
DocBook XML.
Output:plain text, markdown, reStructuredText, XHTML, HTML 5, LaTeX
(including beamer slide shows), ConTeXt, RTF, DocBook XML, OpenDocument XML,
ODT, Word docx, GNU Texinfo, MediaWiki markup, EPUB, Textile, groff man pages,
Emacs Org-Mode, AsciiDoc, and Slidy, Slideous, DZSlides, or S5 HTML slide shows.
It can also pro‐ duce PDF output on systems where LaTeX is installed.
All documentation changes can be submitted as changes to markdown and we can
attempt a periodic documentation refresh on gluster.org.
Change-Id: I5dcf7f79184cd6b6d62ce7065d2faa352622f6ac
Reviewed-on: http://review.gluster.org/5232
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 7dd688a3e3b9fc54f758976e3d34257e3792f9f3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jun 17 13:06:23 2013 +0530
nfs: Remove afr split-brain handling in nfs
We added this code as an interim fix until afr can
handle split-brains even when opens are not issued.
Afr code has matured to reject fd based fops when
there are split-brains so we can remove it.
Change-Id: Ib337f78eccee86469a5eaabed1a547a2cea2bdcf
BUG: 974972
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5227
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6febcf83bfff5b075e3b8246f67d0d5c07bc0de3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jun 24 08:15:09 2013 +0530
cluster/afr: Fix fd/memory leak on fsync
Change-Id: I764883811e30ca9d9c249ad00b6762101083a2fe
BUG: 976800
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5248
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit af35bef2019cc1e52a4053052ff1bb9cd295df72
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Jun 11 14:14:53 2013 +0530
cluster/dht: In reconfig handle removed decommissioned nodes
If no decommissioned nodes options are set in the options, then
clear the conf->decommissioned_bricks.
Change-Id: I426d2bcc874aab21b2eba0b16a580b9a26672ea2
Signed-off-by: shishir gowda <sgowda@redhat.com>
BUG: 973073
Reviewed-on: http://review.gluster.org/5199
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit aeda471aa289b331db5bee2ca5227d7e691a7faa
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Fri Jun 21 11:31:11 2013 +0530
rpc: duplicate request cache for nfs
Duplicate request cache provides a mechanism for detecting
duplicate rpc requests from clients. DRC caches replies
and on duplicate requests, sends the cached reply instead of
re-processing the request.
Change-Id: I3d62a6c4aa86c92bf61f1038ca62a1a46bf1c303
BUG: 847624
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4049
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 23a4d495b5615d6efa811a2d76c8e7efa3e6bfa7
Author: Anand Avati <avati@redhat.com>
Date: Mon Jun 17 06:19:47 2013 -0700
glusterfsd: consider xlator type too in topology check
When cluster.nufa option is enabled, we only change the translator
type, but leave the translator name as-is. This results in the
topology change check to conclude that a graph switch is not needed.
Change-Id: I4f4d0cec2bd4796c95274f0328584a4e7b8b5cd3
BUG: 975599
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5244
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 7ac3c7ff9f8c75f68b373111ada5539abcb99b70
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Mar 15 10:26:53 2013 +0100
store: move glusterd_store functions from mgmt/glusterd to libglusterfs
Making the glusterd_store_* functions re-usable will help with future
changes that need to read/write lists of items.
BUG: 904065
Change-Id: I99fb8eced76d12d5a254567eccff9790b43d8da3
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4676
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5c667af663812ca1fbc9c16f94a745da28e912cf
Author: Anand Avati <avati@redhat.com>
Date: Sun Jun 16 06:19:52 2013 -0700
gfapi: fix read past EOF in glfs_preadv()
When syncop_preadv() returns 0, we are returning @size as-is
(without modifying user passed buffer). This results in
junk data being read when read offset is at or beyond EOF.
Change-Id: I8aa9c957359f9a52833b944b452f501b6f5538d3
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5236
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: José Rivera <jrivera@redhat.com>
Tested-by: José Rivera <jrivera@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a1e60f6e8ec698704654a8cd94ae78f802cd6ade
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 22 15:18:19 2013 +0530
cluster/afr: Perform delayed changelog wakeups for anon fd
Problem:
Nfs xlator never does open on a file for performing writes,
afr does not perform changelog wakeup for this fd so operations
which do metadata operations as soon as the data operations are
completed perceive a delay of 'post-op-delay-secs'.
Fix:
Perform changelog wakeup on anon-fd if the fd with same pid is
not present in inode-list.
Note:
This approach is a short-term fix. A proper fix needs a new domain
for taking metadata locks so that data/metadata locks don't compete
with each other.
Change-Id: I253afb289eadf30c7951e56fb2c4840d7132f5e4
BUG: 966018
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5066
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8c95c2658c9a8080265aabf58e34f545fc267915
Author: Michael Brown <michael@netdirect.ca>
Date: Fri May 3 14:32:23 2013 -0400
nfs/mount3: fix crash in subdir resolution
* __mnt3_resolve_export_subdir_comp: if nfs_entry_loc_fill fails,
mres->resolveloc does not contain valid data
* gf_log should use 'gfid' instead of mres->resolveloc.inode->gfid
* fixes a crash if program flow gets to this line
Change-Id: Idb0d6f97ea73eaf9056d28267ad7a42aa8cf6579
Signed-off-by: Michael Brown <michael@netdirect.ca>
Reviewed-on: http://review.gluster.org/4948
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
commit 7c33b12dc0d0206a8986e25afae0fd7f2188c7a6
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed May 15 15:54:29 2013 +0530
protocol/server: print connection-id in fop failure logs.
Currently we have tuple (server-xlator-name, callid) for identifying
a call. However it does not uniquely identify the operation when there
are multiple clients (since operations from all clients go through same
server). Adding connection-id resolves this ambiguity.
Also printing connection-id helps diagnose failures associated with
connection state (like fds, locks).
Change-Id: I13563bd06ee9b72fc1a10d239f77db5183658573
BUG: 963540
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/5011
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 04c00f0c99eaaf7d39b4149dff8881360debde5b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue May 7 15:58:45 2013 +0530
glusterd: Log peer op status at the appropriate time
Change-Id: Ia8e1af082078f2f791708ba4faa4992bf291dd6e
BUG: 961339
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/5023
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 334feae086e62de2dd972af19d691bdfaef83290
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue May 14 09:59:45 2013 +0530
glusterd: Disable transport before cleaning up rpc object
Problem:
rpc_transport object, which is part of rpc_clnt, is destroyed
prematurely. This is because, rpc_transport object is ref'd by socket
layer and rpc layer. These ref's, until the synctask'izing of
operations, were unref'd sequentially in the epoll thread.
With more threads at play, the sequential unref guarantee is off.
Fix:
Shutting down the transport before proceeding with cleaning up of
rpc_clnt object would serialize the unref's on the rpc_transport object
and thus eliminating the race.
Also, we don't store the address of brickinfo in brick's rpc notify
function, to avoid the possibility of referring a freed brickinfo.
Instead we use a string based id to 'reach' the corresponding brickinfo.
Change-Id: If2739e2eeaee1e8b071ab2b6754b7ea0f81cfceb
BUG: 962619
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5000
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 63f080a148958083301a40cbd7495d373815b821
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Jun 17 16:28:17 2013 +0530
nfs: log stale mount errors occasionally
log the state mount errors only occasionally so
as not to fill log file with too many of them.
Change-Id: Ib5a2485dc2ce3a181cff34bbb6d7aba17a2e4d4d
BUG: 804301
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/5229
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 33de89af9c5f8ff649a29fa64e22e14707ac39eb
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jun 17 10:56:55 2013 +0200
protocol/rpc: move latest added procedures to the end of the array
While looking at the newly introduced procedures FALLOCATE and DISCARD,
it seems that these were added with already existing procedure numbers.
This makes the protocol incompatible with existing roll-outs.
It is very confusing when new procedures are added somewhere in the
middle of the array. This will cause the number of existing procedures
to change. It is much preferred to add new procedures at the end of the
array. This changes not only corrects the enum that generates the
procedure numbers, but also the ordering in the client and server
fops-array for clarity.
Correcting this greatly simplifies adding support for these new
procedures in Wireshark and will prevent confusion to the people reading
network traces (with or without Wireshark).
Change-Id: Ib9e7978531d016c7230d756b855cb94cb0793b0f
BUG: 974976
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5215
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 99721a343b7bf50d3d18245cb2f609a39066f0f1
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue May 28 14:23:49 2013 +0530
rpc: Cleanup rpc object in TRANSPORT_CLEANUP event
rpc_transport object should be alive as long as the rpc_clnt object is
alive. To ensure this, on rpc_clnt's last unref, we cleanup the
corresponding rpc_transport object and complete the rpc_clnt cleanup
later, in a bottom-up fashion.
Introduced rpc_clnt_is_disabled, to allow higher layers to differentiate
between the 'final'[1] disconnect triggered from upper layers, and a
normal disconnect. This differentiation helps in cleaning up resources,
at higher layers, in a race-free manner.
[1] - 'final' here means that the rpc and the associated connection, is
not going to be used anymore. eg - glusterd_brick_disconnect on
volume-stop.
Change-Id: I2ecf891a36e3b02cd9eacca964e659525d1bbc6e
BUG: 962619
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5107
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b5e0619e0e4b82421b0ddbc00db4beed9e289b14
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Jun 3 16:44:21 2013 +0530
nfs: option to disable acl
1. Option to disable or enable acl with nfs.acl boolean
option.
2. Deregister the acl service with the portmapper service
when no longer required.
Change-Id: I6562b6b40138d040aa2bf1e5641f4c0e0e9f9d09
BUG: 970070
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/5136
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3f4f8d3f93099e7f3c7099b1ae14d72b9eebe611
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Jun 7 15:03:46 2013 +0530
glusterd: Ignore directories matching *.tmp in store
store being glusterd's persistent store under /var/lib/glusterd/
Change-Id: I1c01a09a8ce4a73ea612f05e7f14d4ab39ad1628
BUG: 971796
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5177
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0506234f25e86081eec4063930b3ea49ab0014bf
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue Jun 11 13:15:23 2013 +0530
cluster/afr: Improvement in logging of self heal completion status
Problem:
As the end of the self heal, message logged by
"afr_self_heal_completion_cbk" is inadequate to determine what exactly failed
during the course of afr self heal. It is worth to have knowledge of what all
types of self heal got triggered for an entity and whether the status is success
or failure.
Fix:
At the end of self heal, it will log information about out of 4 types of self
heal (gfid or missing entry self heal, metadata, data and entry self heal),
who all got triggered and who all got failed or successful at the end.
Change-Id: I5360762fbd7d391ac4c6af6706b4835c5801835a
BUG: 968301
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/5106
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e62c4b20800122c7b6afd8a946a772026d4453ae
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Wed Jun 12 16:59:13 2013 +0530
libglusterfs: Fix circular buffer to dump entries if count is less than 1024
Problem:
To dump the values present in the circular buffer, index always
moves from current index to used_len. But if circular buffer is not
completely filled even once then next index to be filled and used length
value are always same which means it will never dump any value.
Fix: Modified the logic of buffer traversing to dump values so that it
will still maintain FIFO and cover both the cases where buffer is either
partially filled or being used more than once.
Change-Id: If73a5e481cca1751d57aba1136c2d25d23ce073c
BUG: 972459
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/5197
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit c7a648b149a5d5442e2cad9e019459a5499f3362
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jun 12 09:55:26 2013 +0200
rpm: correct AutoRequires filtering on recent Fedora
Recent Fedora releases (F17 and newer) do not need the
__requires_exclude macro for filtering automatically generated Requires
for <xlator>.so files anymore. It is already sufficient to filter each
<xlator>.so from the Provides.
This prevents the following (harmless) warning from being printed during
build:
Ignoring invalid regex -P ^(?!lib).*.so.*$
BUG: 972465
Change-Id: Icc36f421d283ddb993c8f31e0dfdaa4f27135bb7
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5203
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 49ce8f155b1f3ff8a43e17028fcfa5b69984754a
Author: Bharata B Rao <bharata@linux.vnet.ibm.com>
Date: Tue Jun 4 11:54:43 2013 -0400
gfapi: async discard support
Add glfs_discard_async() to meet QEMU's discard requirements.
BUG: 963678
Change-Id: I97723107fca88dd96cddc08cd67a286645a37922
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5144
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e435921a82c2403b035a8a20f3e1ea4686a4d37b
Author: Brian Foster <bfoster@redhat.com>
Date: Thu May 23 12:19:42 2013 -0400
glusterfs: discard (hole punch) support
Add support for the DISCARD file operation. Discard punches a hole
in a file in the provided range. Block de-allocation is implemented
via fallocate() (as requested via fuse and passed on to the brick
fs) but a separate fop is created within gluster to emphasize the
fact that discard changes file data (the discarded region is
replaced with zeroes) and must invalidate caches where appropriate.
BUG: 963678
Change-Id: I34633a0bfff2187afeab4292a15f3cc9adf261af
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5090
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2330c760d67402d792a90e23a5d89f181cc9ad76
Author: Brian Foster <bfoster@redhat.com>
Date: Wed May 8 08:54:11 2013 -0400
gluster: add fallocate fop support
Implement support for the fallocate file operation. fallocate
allocates blocks for a particular inode such that future writes
to the associated region of the file are guaranteed not to fail
with ENOSPC.
This patch adds fallocate support to the following areas:
- libglusterfs
- mount/fuse
- io-stats
- performance/md-cache,open-behind
- quota
- cluster/afr,dht,stripe
- rpc/xdr
- protocol/client,server
- io-threads
- marker
- storage/posix
- libgfapi
BUG: 949242
Change-Id: Ice8e61351f9d6115c5df68768bc844abbf0ce8bd
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4969
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d1019c0756f30ce5e7d458594e57f77d3ca1086e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 15 14:46:57 2013 +0530
mgmt/glusterd, socket: Change logging for brick disconnects
For unix path based sockets, the socket path is
cryptic (md5sum of path) and may not be useful for
the user in debugging so log it in DEBUG.
Changed logging in brick_rpc_notify to log brickinfo
for disconnects.
Change-Id: I69174bbbbde8352d38837723e950ad8fc15232aa
BUG: 963153
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5009
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4df4125b894a306c550bbf12d0f7b38e103ac090
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jun 7 15:45:26 2013 +0530
cluster/dht: Make sure loc has gfid
Problem:
In some code paths neither loc->gfid nor loc->inode->gfid
is populated which leads to EINVAL for linkfile setattr
in dht_linkfile_attr_heal.
Fix:
Populate loc->gfid before dht_linkfile_attr_heal.
Change-Id: I062770e6f6eaead304eff1dae81f8588a3b97eed
BUG: 971805
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5178
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 63a686ec2c0257b50d0f2efded345dfc6c66b9d6
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jun 6 10:46:57 2013 +0530
glusterd: Add a cmd for getting uuid of local node
Usage: gluster system:: uuid get
This is needed since we generate uuid of a node in a lazy manner. ie, we
generate a uuid for the node only on the first volume or peer operation,
when the node needs an external identity. With this command, we can
force[1] the uuid generation, without a volume or peer operation performed.
[1]: Querying for uuid (or uuid get), forces uuid to come into
existence.
Change-Id: I62c8b6754117756aa4d773dd48af4ddeb1a1d878
BUG: 971661
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5175
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit a3e8dcf0ff2a979eb08df072d63a625d5ef8f1d2
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Mon May 27 13:13:03 2013 +0530
nfs: gluster volume set help shows null as default value
Bug(967445): The default value for all nfs options is displayed as "(null)"
Fix: Changed nfs options to show default value.
Change-Id: I3b1f27439c19a6655f7dcc7891df40706db9e474
BUG: 967445
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/5098
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c46bb9e85da26be8d8b72696e3d6754f8f5ae1e9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 31 14:30:58 2013 +0530
cluster/dht: Fix unused-but-set-variable warnings
Change-Id: Ie2b2dc54aa0d500c35752c72d3b562bcc05b1fc2
BUG: 969336
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5123
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f37c924366663f8f8bebf2b989666392aae707ea
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu May 16 18:13:10 2013 +0530
mgmt/glusterd: Set task op at the time of task-id set
Problem:
If a remove-brick start is executed on m1 with brick from m2
on local subvolume no rebalance process is launched. Because of
this volinfo->rebal.op is not set. This leads to volume status
failures.
Fix:
Set rebal.op even when the reblance process is not started.
Change-Id: I71c7e6f09353be14c1e8edca3c8685ebfdf226d6
BUG: 964059
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5030
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit eecc60581e740dc75936a80ecd270283e675d26e
Author: shishir gowda <sgowda@redhat.com>
Date: Thu May 9 11:28:58 2013 +0530
cluster/dht: Ignore ENOENT errors for unlink of linkfiles
If unlink of linkfile returns ENOENT, do not fail unlink.
Proceed with unlinking of cached file.
Change-Id: If7cec92b40c39d68dd9c3606c6c2c3a6bd67d27b
BUG: 966848
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4971
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 13d44d000398fb4532bf5ed1ad7bb090e08e4813
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Mar 1 16:18:26 2013 +0530
template: A minimal example xlator to build on
This xlator is intended to save new GlusterFS developers
from fighting it with autotools.
How to add template xl onto the xlator graph?
[..]
volname-template
type testing/features/template
subvolumes volname-dht
end-volume
[..]
Change-Id: If513284bb590be7c3b093054108dba2883064190
BUG: 916985
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4604
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 31e76e0b166e50c75fec20b8b4f722a3a37c341b
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri May 17 11:00:29 2013 +0530
cli: Remove unused port info from peer status.
Problem: "gluster peer status" on some nodes gives port info and fails to give
on other. But it is a hard coded value.
Fix: Removing the port info from command
Change-Id: I919f0349f252e658bfc13e60bb8e171da32eaf25
BUG: 964026
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/5027
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit e2fc4b49ba7f8b3de2cd1c77fb1a5f9d6bed631d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 22 11:59:27 2013 +0530
cluster/afr: Avoid order mismatch in blocking entrylks
Problem:
When taking blocking entrylks, afr orders the entrylks based on
uuid_compare of gfids of parent dirs, if they are equal then it orders
them based on the basenames. While this approach works fine, the
implementation assumes loc->gfids to be populated at the time of
the comparison, but loc may have gfid in loc->inode->gfid instead
of loc->gfid which was leading to order mismatches and dead-locks.
Fix:
Implemented loc_gfid which gives gfid by checking both loc->gfid,
loc->inode->gfid. Used this for ordering the blocking entrylks.
Change-Id: Ib0db36bbaf0df09fa87c3c3bb6a834db74fc2154
BUG: 965987
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5062
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ba1f92f129f9a0df653c9b05b65e86e54e027b57
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jun 4 15:20:45 2013 -0400
transport/socket: fix connect/disconnect races
We might receive a connect request while a disconnect is still in
progress, requiring more states and (the return of) poller generation
numbers to avoid redundant pollers. We might also get either kind of
request from within our own rpc_transport_notify upcall, so we have to
avoid locking and use the PLEASE_DIE state instead.
Change-Id: Icbaacf96c516b607a79ff62c90b74d42b241780f
BUG: 970194
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/5137
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ef98c8f05f7b5274b33fe4063e24270680ce0898
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Jun 4 16:43:35 2013 +0530
cluster/dht: Prevent crash in dht_linkfile_lookup
Assign local = frame->local before dereferencing
local->linkfile.linkfile_cbk. Additionally, fail if
op_ret is non_zero.
Change-Id: I96a2f34ba29887da9ccaae38a644431cf7c43265
BUG: 966858
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5141
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ee941e3b07b03dc6ef9b345169ee9a06191e9eac
Author: Kaushal M <kaushal@redhat.com>
Date: Thu May 23 12:19:33 2013 +0530
glusterd-syncop: Fix unlocking and collating errors
* Only those peers which were locked need to be unlocked.
* Fix location of collating errors in callbacks. The callback functions
could miss collating errors if there was an rpc error.
Change-Id: Ie27c2f1ec197da4f5077a4d6e032127954ce87cd
BUG: 948686
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5087
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit cee721ad0c4e01a5b16caef71f99cbc0ca8773e5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue May 21 14:21:31 2013 +0530
cluster/dht: Set layout when inode is present
Problem:
Lookups in discovery fail with ENOENT so local->inode
is never set. dht_layout_set logs the callstack when
the function is called in that state.
Fix:
Don't set layout when lookups fail in discovery.
Change-Id: I5d588314c89e3575fcf7796d57847e35fd20f89a
BUG: 965434
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5055
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1b8d71cd98a14b039b82a55c02810b13514fbeea
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu May 2 12:56:46 2013 +0530
system/posix-acl: check for the sticky bit of the parent directory
* While creating links, check if there is sticky bit set for the parent
directory and whether the sticky bit permits the user to create the link.
Change-Id: Ic0d09d9ed579c4eb47462c71602a3a60cc7d3bc1
BUG: 958691
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4934
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 91f6410c1555f3bd36c2d1beea1678b4366518bd
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri May 31 10:07:57 2013 -0400
cluster/dht: Return success in dht_discover if layout issues
We cannot heal in dht_discover, as it is a gfid based lookup, and not
path based. So, returning error here would lead to app's to see failure.
Also, update the layout in inode_ctx even if it has anomalies. Let
subsequent heals fix the issue.
Change-Id: I2358aadacf9a24e20a22ab0a6055c38c5eb6485c
BUG: 960348
Original-author: shishir gowda <sgowda@redhat.com>
Signed-off-by: shishir gowda <sgowda@redhat.com>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4959
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 04eb911feeaf686ff13ffa0cb4c122ed6c0f88a2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 15 12:09:28 2013 +0530
socket: Prevent extra logging in socket_rwv
Problem:
If the socket is not even connected socket_rwv fails
and the error log comes every 3 seconds for every
re-connect.
Fix:
Prevent this error log if the socket is not even
connected.
Change-Id: I963f1345c4b6779dd5491948f7f5c4357a507b67
BUG: 963088
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5008
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 008d2b8990e9df2a661d8864af1c30cf014cacc9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed May 15 18:18:24 2013 +0530
mgmt/glusterd: Make sure peerinfo->uuid_str is assigned
Change-Id: I9e2743ab61c8baee92a1dfd376ec4bb145776176
BUG: 963524
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/5016
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5a5c5846252d0af8a5038d3d574a54ec53eafbb8
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Thu May 30 12:12:40 2013 +0530
cluster/afr: Removed misleading log from afr_start_crawl
Problem: If it is fresh volume with no files created the xattrop directory is
not present. If crawl happens in that time, lookup for xattrop
directory will fail and it results in printing a misleading log.
Fix: Changed misleading log.
Change-Id: Iae5da3e8423564d64096f88abdaf8c98e4935840
BUG: 928575
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4993
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8baf36632ca28c5c96cbd7f27f20b9963ab5d887
Author: shishir gowda <sgowda@redhat.com>
Date: Wed May 22 09:58:15 2013 +0530
cluster/dht: Handle linkfile creation with EEXIST error
If linkfile create fails with EEXISTS, then check if the file
is a linkfile for the same file. If not, return the error
Change-Id: Iab42db54422dea69de0049b5196365e65edadd91
BUG: 966858
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5060
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 78becad742298f92c54a73d4a240f23685cd7714
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Apr 30 13:03:08 2013 +0530
glusterd-volgen: Improve volume op-versions calculation
Volume op-versions calculations now take into account if an option,
a. enables/disables an xlator, or
b. is a boolean option.
This prevents op-versions from being updated when a feature is disabled.
Also, correctly close the dynamically loaded xlators in
xlator_volopt_dynload() and prevent leaks.
Change-Id: I895ddeeec6f6a33e509325f0ce6f01b7aad3cf5c
BUG: 954256
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4952
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit efceb1a68c0430242be38d562eeb9d1de2f66806
Author: shishir gowda <sgowda@redhat.com>
Date: Mon Mar 18 14:44:20 2013 +0530
cluster/dht: Linkfiles creation with correct uid/gid
If renames are done with different uid/gid (non-owners), then we would
end up with incorrect uid/gid.
The fix is to create linkfiles, and heal the uid/gid as root:root. This
preserves our notion of creation as root:root and heal the uid/gid as
root:root in all paths. Additionally, we need to consider uid/gid from
only src_cached subvol, and not from linkfiles.
rename is also done as root:root if done on linkfile, as setattr of ownership
on linkfile is done after the rename
Change-Id: Icb5d431dc42da9c02dfae81980e3fe769a47a274
BUG: 884597
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4682
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 5a3f6ef28f4d6384a43bfa9da7e72e699070dbd2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Apr 12 11:06:44 2013 +0530
protocol/server: Change logs to give more info on disconnects
Change-Id: I8304a12df417be164c564e0696f72c3334f21569
BUG: 952138
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4824
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 40038032ca29a2f1dba1c1ff7f605608622c5099
Author: shishir gowda <sgowda@redhat.com>
Date: Mon May 6 19:18:21 2013 +0530
cluster/dht: Do not open fd in migration check/complete for non fd ops
if local->fd == NULL, then in dht_migration_check_complete, do not do
open call. Let the layout get updated, and proceed with invoking the
registered target_fn.
if local->fd == NULL, do not call dht_rebalance_in_progress_check for
truncate fop, but proceed with truncate2.
Change-Id: Ia5a5d40bcea7bfb320ef7096af1e035b8847d4ff
BUG: 960055
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4958
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 48bd09377b7aa85a891750bc1a63d5eeeccde084
Author: shishir gowda <sgowda@redhat.com>
Date: Fri Apr 26 15:33:42 2013 +0530
cluster/dht: getxattr linkto as root:root
In path based op's like truncate, we use getxattr instead of
fgetxattr call. These can fail with permission denied issues
as linkto file creation, and setattr of ownership is not atomic,
and in cases where setattr failed (subvols down..)
The fix is to perform getxattr as root:root as it is a internal
fop. fgetxattr, bypass the access check, as it already has a valid
open fd.
Change-Id: Ie221c9172e3c1c7ed4e50c8782d362826910756f
BUG: 957074
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4890
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c3bd0f11e5aa41c06e58acba179a43405c37036b
Author: shishir gowda <sgowda@redhat.com>
Date: Wed May 8 17:37:00 2013 +0530
statedump: Print entries in cb buffer in FIFO order
Currently cb buffer was being printed in LIFO order, which
is was against the percieved notion of logs having older
entries printed before newer entries in the state dumps.
Re-did the loop to prevent crash as when w_index == 0, we
would access cb[w_index - 1].
Change-Id: Idd085f73fa6937e506a2a1925e42fbcfd2d9bb1c
BUG: 966847
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4968
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a251ff1761d541ee2750c3e2c0f116bd30a21628
Author: shishir gowda <sgowda@redhat.com>
Date: Fri May 3 12:27:07 2013 +0530
tests/bugs: Increase timeout for rebalance completion check
Change-Id: Ic299c0d7b3996f6e85f9627430efbdf3f9ea0a8f
BUG: 884455
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4942
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 00c2878750c8a3fc151160f227cf3c5ee578d7fc
Author: shishir gowda <sgowda@redhat.com>
Date: Mon May 13 09:51:49 2013 +0530
cluster/dht: Do migration inprog/complete check only if ENOENT
Additionally, update op_errno to the lasted failure. If failures
found in complete_check, error returned would be EUCLEAN instead
of the right failure (in this case ENOENT)
Change-Id: Ib813867f4b817af651627b9ea07b0b09fa2b26ce
BUG: 966852
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4989
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6c6b11966a308c8cbed2567927d66949d40bc40b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu May 30 17:21:05 2013 -0400
cli: set min-op-version and max-op-version for getspec
Change-Id: I2185df5d6b560d9367ae404c91812048e1655180
BUG: 969193
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/5119
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6e220fc833d334a150b4036b935b9d286ad74715
Author: Anand Avati <avati@redhat.com>
Date: Fri May 3 05:44:17 2013 -0700
api: Fix api.so and libgfapi.so build time dependency
Not all versions of autoconf handle dependencies expressed
as "A: B". Use the xxx_DEPENDENCIES variable to make it
version independent
Change-Id: Ia0b13399d0bf10995d9845e04cd9eb3ef6518dbe
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5118
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e6922ff7f3530d75ba8c629aa185d590ed74b698
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon May 20 18:39:11 2013 +0530
nfs: update nfs.addr-namelookup description
replaced rpc-auth.addr.* with nfs.rpc-auth-* in
keeping with the latest option exposed to the user.
Change-Id: I418354a4d171dae28dd0befe8ba9e5ee893cd013
BUG: 965025
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/5049
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 387e5927dbc43394d91a4a5510eddb410b833204
Author: Anand Avati <avati@redhat.com>
Date: Thu May 2 20:01:18 2013 -0700
gfapi: add new API glfs_dup() to copy a file descriptor
Duplicate a glfs_fd file descriptor. Inherit the internal
fd_t with a reference.
Change-Id: Ib30e9a46b608b9f78202957f4dab6ba6265a9ec0
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5109
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit caa674d979dec9352f3547d738d7ba03c678b90b
Author: Anand Avati <avati@redhat.com>
Date: Wed May 29 03:15:19 2013 -0700
api/Makefile: link api.so against libgfapi (and dependencies)
Samba opens vfs_gluster.so with dlopen(..,RTLD_LOCAL). This makes
the symobls in the shared module and the library it exclusively
links against (specifically gfapi) not resolvable from the .so
files which are opened in turn within (like xlator .so files)
unless explicitly linked against the dependent libraries.
This is not otherwise required in case of glusterfsd as the main
executable symbols are always available for resolution from
dlopen()'ed shared objects, making Samba's vfs_glusterfs
requirement unique, but luckily not incompatible.
Change-Id: I894c521daade7d46ec5bf07793f2eea02ebc9700
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5105
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d1f14cb853a02d55921fea22290d5f91f6d9506b
Author: Anand Avati <avati@redhat.com>
Date: Wed May 29 03:12:19 2013 -0700
socket: convert socket functions to file scope (static)
The function names used in socket.c conflict with Samba's
socket functions (samba.git/source4/lib/socket/socket.h). Convert
our functions to file scope as they are anyways not called across
files.
Change-Id: If98ae557d3e2868f257c021b283ede6a5e92de02
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5104
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 01676951a3c3b00cc1aab7c499ed25912e5a0e02
Author: Ram Raja <rraja@redhat.com>
Date: Sun May 26 21:55:23 2013 +0530
configure.ac: add build option for glupy
Check whether Python.h, glupy dependency, is installed in the system.
('Python.h' part of python-devel or python-dev package.)
Allow following build options:
--enable-glupy build glupy; If dependencies are not met, abort
configure script run with error.
--disable-glupy don't build glupy even if dependencies are met.
default build glupy; If dependencies are not met, don't build
glupy and allow configure script run with warning.
glupy-specific dependencies:
python2.x, python-devel/python-dev package
Change-Id: Ia495dd00cac7d12ad76645c8576a0adc0cb5d590
BUG: 961856
Signed-off-by: Ram Raja <rraja@redhat.com>
Reviewed-on: http://review.gluster.org/5093
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fc1c84586636b546c7e30a4846a64501b4624850
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Apr 19 15:16:56 2013 +0530
glusterd-volgen: Enable open-behind based on op-version
This patch enables the open-behind by default only when the op-version
allows it. Also the volume op-version calculations take account of this
enablement.
Change-Id: Idf7a3c274ec4828aafc815cdd1df829ecb853354
BUG: 954256
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4866
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c237fcd63e26c8a5c3f0d6555941a69aca794d8b
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed Mar 20 11:06:19 2013 +0530
performance/write-behind: Enable write-behind when strict_O_DIRECT is not set.
When open() with O_DIRECT happens, write-behind was being disabled for the
fd irrespective of strict_O_DIRECT option. This commit disables write-behind
only when strict_O_DIRECT is enabled.
Change-Id: Ieef180e52910c3bf64d46b26b0e5dc3b8542f6d2
BUG: 923556
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4697
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 46d307a0d69c2c179cae83edd67cb7ad6b2d83fa
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun May 26 13:37:50 2013 +0530
doc: Move relevant files out of legacy.
Change-Id: Iff9166dd7baa3d60b70ffab5ce9a692d211fa4fb
BUG: 811311
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5091
Reviewed-by: Justin Clift <jclift@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a21cfcffeab2022f4ab938a982d6edabb6d802bd
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue May 7 13:09:05 2013 +0530
protocol/client: Prevent excessive logging of client's "disconnect" messages.
Problem: Currently when gluster volume start force is executed, client process
will talk to glusterd to get the port of the brick. But if brick's path
is not available it cannot return brick's port. So client process will
keep connecting and disconnecting from glusterd for port-query which
is ultimately responsible for execssive logging of disconnect messages.
Fix: Message will be logged just once at INFO level after the first
disconnect from glusterd. Afterwards "disconnect" messages will be
logged in DEBUG mode.
Change-Id: I2b787f3820b5da45e090c562e5698fcfe24a02cd
BUG: 959969
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4953
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ca628f2e8ba56dc773a4adb82827948ad22881ed
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri May 24 12:57:19 2013 +0530
logging: Fix to avoid excessive logging.
mem_get function: Log message related to mem_pool
calloc is removed as its been calculated in mempool
'stats'. This messgae is consuming nearly half of
the total log messages in DEBUG mode.
dht_hash_compute function: Changed log level from DEBUG
to TRACE.
client_fdctx_destroy function: Changed log level from DEBUG
to TRACE.
Change-Id: Ic948db0419e76df4e95ebd0cabaf66eadbaada6b
BUG: 966851
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/5086
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4df01bc6557ec04b6dafb7c01533c82510671cc2
Author: Anand Avati <avati@redhat.com>
Date: Tue May 21 16:27:09 2013 -0700
gfapi: handle graph switch (cwd, fds, locks)
- Migrate open fds to new graph
- Migrate locks held in open fd to new fd
- Refresh CWD, so resolution of relative paths happens on refreshed
inode (on new graph).
Change-Id: I4b18083b9b290107ebda1f917fc85b635ab72fb4
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5059
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
commit e4f58a18e0c08728e5e513e68fda44bd33027b95
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed May 15 17:30:30 2013 +0530
glusterd: Allow volume start force to succeed if brick directories are recreated
Change-Id: I4fc3c5c829adca256bb131f4a2722abc95741158
BUG: 963665
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/5020
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 80433eb81a339b2df0602e353cc54d2e5b283c3b
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu May 23 11:25:27 2013 +0200
extras: prevent "glusterd dead but subsys locked"
Commit b5bf14a6 added support for a file under /var/lock/subsys,
Hoewever, killproc does remove the $PIDFILE which cases subsequent
checks on its existence to fail. When glusterd was stopped successfully,
the $PIDFILE has been removed already, there is no need to try to remove
is again.
Upon executing '/sbin/service glusterd status', the message 'glusterd
dead but subsys locked' would be returned because the file under
/var/lock/subsys was not removed.
Bug: 960476
Change-Id: I781fe463e3c5472e42d668155cee4f63d349a568
Reported-by: Satheesaran Sundaramoorthi <sasundar@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5074
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bd0c92d99d8c657f8949a067041f1a7ba092407e
Author: Anand Avati <avati@redhat.com>
Date: Thu May 23 23:14:30 2013 -0700
gfapi: ignore NULL and -1 parameters in glfs_set_logging()
Permit changing either logfile or level by specifying the other
as -1 or NULL respectively.
Change-Id: I7df05db7b613c57e0106a5cce846ae26d2a160d4
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5085
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 834d0102a6b8c8ce9c29a9250547fbaa1f8e435e
Author: Anand Avati <avati@redhat.com>
Date: Wed Apr 24 00:51:12 2013 -0700
pkg-config: present API version and not package version
This way PKG_MODULE() autoconf test checks for required API
rather than release version (e.g required API could be in all
all of 3.4.5, 3.5.1, 3.6.4 etc.)
With the first "release" of gfapi, the current version (4) will
be frozen.
Version 3 is sufficient for QEMU's requirement. Version 4 is
necessary for Samba VFS
Change-Id: Iada3a4c88b9c67413dcd57004fd8a62926a21b42
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4932
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7a799300858deb44412d8d1894a6d3980800189c
Author: Anand Avati <avati@redhat.com>
Date: Sun May 19 23:31:38 2013 -0700
gfapi: provide stable st_dev in stat structure
Samba depends on st_dev being unique and stable for different
filesystems (it uses st_dev+st_ino as key to store metadata of
a file).
Change-Id: Ia022fabadfb5ef3fc9724c1b1ca86f1a20f98af9
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5045
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit de2666742dae35929f89a8b82917191cbbed614c
Author: Anand Avati <avati@redhat.com>
Date: Thu May 2 08:00:22 2013 -0700
dht,posix: support for case discovery
This is support for discovering a filename in a given directory
which has a case insensitive match of a given name. It is implemented
as a virtual extended attribute on the directory where the required
filename is specified in the key.
E.g:
sh# getfattr -e "text" -n user.glusterfs.get_real_filename:FiLe-B /mnt/samba/patchy
getfattr: Removing leading '/' from absolute path names
# file: mnt/samba/patchy
user.glusterfs.get_real_filename:FiLe-B="file-b"
In reality, there can be multiple "answers" as the backend filesystem is
case sensitive and there can be multiple files which can strcasecamp()
successfully. In this case we pick the first matched file from the first
responding server.
If a matching file does not exist, we return ENOENT (and NOT ENODATA).
This way the caller can differentiate between "unsupported" glusterfs
API and file not existing.
This API is used by Samba VFS to perform efficient discovery of the real
filename without doing a full scan at the Samba level.
Change-Id: I53054c4067cba69e585fd0bbce004495bc6e39e8
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4941
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 87c3a50de840f25418bb50bece6142f7c577836a
Author: Anand Avati <avati@redhat.com>
Date: Sun Apr 28 12:22:54 2013 -0700
gfapi: link inodes in relevant entry FOPs
Do not let inode linking to happen only in lookup(). While
that works, it is inefficient.
Change-Id: I51bbfb6255ec4324ab17ff00566375f49d120c06
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4931
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ff6d3a1679631c5e9b0e7eaeb79ccdb41e3e61ad
Author: Anand Avati <avati@redhat.com>
Date: Sun Apr 28 02:01:01 2013 -0700
syncop: copy inode pointer in readdirplus
Change-Id: I9ab2b8ac2da9fe13f56b8b08f715a0b603ece0cb
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4930
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b5fe434e4aa24cc710b122a04b71020341b94fec
Author: Anand Avati <avati@redhat.com>
Date: Sat Apr 27 11:40:02 2013 -0700
md-cache: support negative xattr entries
Add support for negative xattr caching. For this, we need
to fetch xattrs in every opportunity (including readdirplus)
in order to treat missing key in cached dict as negative entry.
This is crucial to detect missing ACL xattrs in Samba workload.
Change-Id: I918a2ef4ab804724256f7546b15e808332ed518d
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4929
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 85fc5a50bb66646efce35ab607452c79069ec4d1
Author: Anand Avati <avati@redhat.com>
Date: Sat Apr 27 21:40:19 2013 -0700
gfapi: optimistic resolution with ESTALE detection
Enhance the path resolver to be optimistic. Instead of performing
a wasteful ->lookup() fop for every component in every API call,
build in speculation logic to consider the previous resolution
result temporarily, and if it results in ESTALE either later in
the path resolution or in the FOP, then retry resolution with
->lookup() at every level and retry the FOP.
This is the same optimistic resolution/retry logic Linux kernel
resolver is proposing to use.
Change-Id: Iecbc25248754caf0915cd7205910563ff88ce5e7
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4928
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 86ef48562fbb539547afbd6aedb60fc3165e2d53
Author: shishir gowda <sgowda@redhat.com>
Date: Tue May 21 16:29:32 2013 +0530
cluster/dht: Ignore decommissioned subvol in overlap optimization
Change-Id: Ib727948c6e21b19fd509f258ff0aea1c5d1a84d1
BUG: 966845
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/5056
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8a725af67ac9aa6fe43622dbd656533e10fe8d4e
Author: Rajesh Joseph <rjoseph@redhat.com>
Date: Tue May 21 16:48:12 2013 +0530
nfs: Unable to resolve FH
Bug (965435): while deleting files/directory from multiple machines nfs server
logs show "Unable to resolve FH" error.
Cause: The error is shown whenever the server receives rmdir/remove call and the
file/directory is already deleted. Server always shows "Unable to resolve FH"
irrespective of what is the actual error.
Fix: The error message seems little misleading therefore changed the error
message to display the actual cause.
Change-Id: I4f9c151f737317d618278c59d9f66fe9f46350b8
BUG: 965435
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-on: http://review.gluster.org/5057
Reviewed-by: Santosh Pradhan <spradhan@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a06f9047b36a3d45e52a700fa99c69d49c0321e0
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue May 21 21:40:31 2013 +0530
glusterd: Give up biglock during rpc conn cleanup
glusterd could deadlock after a peer-detach command as follows,
1) glusterd_friend_cleanup function 'flushes' out messages in the rpc
layer's queue, that haven't received a response. At this point, glusterd
has already acquired the big lock.
2) The side-effect of flushing out the messages is that the
corresponding call backs are called.
Call backs themselves are executed after acquiring the big lock. This
results in the big lock being acquired in a nested manner (in the same
thread), which causes
a deadlock.
This can also happen during brick/NFS/SHD disconnect in volume-stop.
Change-Id: Iab3aad143cd8ebbab53ea0b69687f0e7627dc8a9
BUG: 965533
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5061
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 85246fa4254f953b2c06906b4cc8ebb461813a54
Author: John Smith <lbalbalba@gmail.com>
Date: Sun May 19 19:57:04 2013 +0200
tests: Change 'volume create' to 'volume create force'
Using 'force' when creating volumes prevents errors when creating bricks in the root partition. This fixes test bug-823081.t for bug-962226
Change-Id: I00996e1ab76713084076507d0aebdb65edc806c8
BUG: 962226
Signed-off-by: John Smith <lbalbalba@gmail.com>
Reviewed-on: http://review.gluster.org/5036
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
commit db19d735ecce3e38a32a0762c437ba372c905cb6
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed May 22 16:20:36 2013 +0200
rpm: automatically load the fuse module on EL5
The fuse module needs to be loaded before /dev/fuse can be used. On
RHEL6 and Fedora the module is loaded on demand. RHEL5 needs to load the
module manually.
This change add a script under /etc/sysconfig/modules/ that loads the
fuse module on boot and packages it in the EL5 version of
glusterfs-fuse.
One of the features of GlusterFS is to not depend on additional fuse
userspace. The conditional requires on /usr/bin/fusermount is not
needed, this command is never called in the current version (even though
is it referenced in the sources).
Change-Id: I77028dade54771cb49cea68a517100f73763dc85
BUG: 947830
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/5070
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c1a7518eddc18c1301a2cf3f9e8f9f591815e202
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Wed May 22 15:26:04 2013 +0530
xlator: NULL terminate volume_options struct
Problem:
volume_options struct for open-behind and quick-read xlators
were not NULL terminated.
Fix:
Make them NULL terminated.
Change-Id: I2615a1f15c6e5674030a219a99ddf91596bf346b
BUG: 965995
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/5064
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit abd94cb1c0bf568c75aa8d505c2547ef4f8428fe
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed May 22 00:18:04 2013 +0530
syncop: synctask shouldn't yawn, it could miss a 'wake'
Change-Id: I7731fd33ca0c925cc52f8d105275b44fc625a1e2
BUG: 948686
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5058
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2e9c329f850da1e3a08cbd3c32b6e07701a1e415
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon May 13 17:50:56 2013 +0530
md-cache: Make options structure NULL terminated.
Change-Id: I8aa4f90ba7e1eecf3f978be04f8550049275464f
BUG: 765785
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4994
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 92f886edeb5b1658c0bf2510e4e91ce6d48be6d1
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon May 20 17:17:05 2013 +0530
syncop: Remove task from syncbarrier's waitq before 'wake'
Removing task from syncbarrier's waitq after wake could result in a
subsequent syncbarrier_wake, wake'ing up the already running task. This
fix makes the removal from waitq and wake 'atomic'
The root cause and the fix are similar in spirit to what was observed
in synclock's waitq implementation.
Change-Id: I7dd9e6ad5945742bcda20eb5a06a9376bb18528e
BUG: 948686
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5047
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1e710dc6bb55340cd6ce6fe4c6d9813b6684de5d
Author: Anand Avati <avati@redhat.com>
Date: Sat May 18 20:35:30 2013 -0700
quick-read: prune cache on write/[f]truncate
Cache needs to be pruned on write and [f]truncate. The lack of this
is causing Samba ping-pong test to return wierd 'data increment' values
during startup.
Change-Id: I9cd6a839bcd02de738d78638211b78f382f58e0a
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/5033
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c4af1b01140f2b82ccb1ee28e57f4544cc01c6b3
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon May 20 18:40:52 2013 +0530
tests: Increase wait time for nfs mount.
Change-Id: I61815b502c90314ea6924e3046fb9b396ff56e8b
BUG: 927616
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5050
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cfdd757581a99192af9f4b885d531705bf0850f2
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sat May 11 14:29:29 2013 +0530
syncop: Update synctask state appropriately
* Earlier, SYNCOP macro, the only consumer of synctask_yield, would set
the task->state to SYNCTASK_SUSPEND. Today, we have glusterd having its
own wrapper macros which don't set task's state. There is also the
syncbarrier and synclock framework, which also participate in a
synctask's scheduling (and need to keep a task's state up to date). It
only makes more sense to leave a synctask's state to the synctask
library, since its an internal affair.
* Need to 'yawn' before 'yield' to avoid re-running tasks to set
task->woken appropriately.
Change-Id: Ic7a59e6ebcc46f03e53223ca237668d45a3cba40
BUG: 948686
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4985
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7e5bbdf4ea1ebf6d6391db33ff286ef7412dd5d6
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue May 14 16:07:03 2013 -0400
configure.ac: build glupy with installed python
IOW with more than just python2.6. Python2.7 is certainly what's on
the vast majority of non-RHEL systems that are out there. Also our
rpm.t regression test will build on epel-5 under mock; RHEL5 has
Python2.4.
Change-Id: I09c95c1fb6b3498e910ad239c4f0af7f786c3700
BUG: 961856
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5007
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d85e394847ac095fc9ea3d72db6614d6f32183b5
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon May 13 15:03:22 2013 -0400
configure.ac: enable-debug change breaks _hardened_build
See RHBZ 955283, and http://fedoraproject.org/wiki/Packaging:Guidelines#PIE
The previous change for BZ 851092 in
commit 058a736f9e36238c284ca80e7ed5f62434655019
breaks the ability to enable _hardened_build in release-3.4 and master
BUG: 851092
Change-Id: Ib298a492fee22dd82042af704fe8cdd34c3e100e
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4998
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d017f3be6db80fbdf222f251fea11ddc3e7ddf05
Author: John Smith <lbalbalba@gmail.com>
Date: Sat May 18 21:01:50 2013 +0200
Tests: changing calls from 'fstat' to 'fstat64' fixes these tests on 32 bit platforms: bug-858242.t, bug-808400*.t
Change-Id: Ifd85c711a8d16eb3ef17bd1c585acdc34121b12d
BUG: 962226
Signed-off-by: John Smith <lbalbalba@gmail.com>
Reviewed-on: http://review.gluster.org/5034
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6d8183d9e1ceb1fbee960daf820566f8da363c7b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Jan 7 11:05:39 2013 +0530
rpc-transport/rdma: reap async events in a dedicated thread.
* Also sets srq_limit of srq to 10, so that we'll receive an event
when we are about to empty the receive buffer list.
BUG: 765051
Change-Id: I5436166ea21fc963ee15088fc2df743ec4b96ba7
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4378
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5cd4d6a55abc30e245c58beb2e6ac7c23f38f35e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Dec 18 12:47:43 2012 +0530
rpc-transport/rdma: use rdma-cm for connection establishment.
Till now gluster used tcp/ip based communication channel with
gluster specific protocol to exchange infiniband addresses.
Change-Id: I9de4db398a0e2af51d3d2d68c2fe42168102b190
BUG: 765051
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/149
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fb2231320997a6d21d4e2b55a578e500fd486a2d
Author: Anand Avati <avati@redhat.com>
Date: Fri Apr 26 01:23:13 2013 -0700
locks: fix leaking entrylk lock structure
When entrylk lock requests are blocked and granted aysnchronously,
the entrylk lock structure was getting leaked.
Change-Id: Ie3f29f550730189f27745d991b029e50c63e63da
BUG: 962350
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4991
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bf84eedef287574697dbc2c1e219e2e72f320615
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri May 10 10:09:13 2013 +0530
cluster/dht: Don't do extra unref in dht-migration checks
Problem:
syncop_open used to perform a ref in syncop_open_cbk so the extra
unref was needed but now syncop_open_cbk does not take a ref so no
need to do extra unref.
Fix:
remove the extra fd_unref and let dht_local_wipe do the final unref.
Change-Id: Ibe8f9a678d456a0c7bff175306068b5cd297ecc4
BUG: 961615
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4974
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 11209930fbfda92009a1051e1c0eaaeb7bd9e95c
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu May 16 15:05:09 2013 +0530
glusterd: Set op_errstr to error string received from peer
... in case of volume op failure on remote host
Change-Id: I7177dc02369dffa82f217496559532d18b7c7c7a
BUG: 963628
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/5018
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8f016e4e11ed9b207196079e3406923409cabbca
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu May 9 13:16:51 2013 +0530
client: Reset remote-port on first disconnect from brick
Change-Id: I8940358788a7c4f8be81d705749f668a43422b8e
BUG: 962930
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4988
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 8e55fdaf8e55a24479c6c7793c19d217baa46c55
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Apr 18 23:46:37 2013 +0530
rpc-transport: Moved unix socket options function to rpc-transport
This change removes the asymmetry in the 'layer' (read rpc, transport
etc) in which transport options were being filled for inet and unix
sockets.
Change-Id: Iaa080691fd5e4c3baedffa97e9c3f16642c1fc12
BUG: 955919
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4850
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 03da47ed94f43ac36ffdd6f43c7f84e086d93fdf
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu May 16 10:43:54 2013 +0530
glusterd: Fix misleading log messages of the kind "Node <n> responded to <n>"
PROBLEM:
glusterd logs coming from glusterd_xfer_friend_add_resp() (wrongly)
indicate that a node responded to itself, although it actually
responded to one of its peers.
FIX:
Make glusterd_xfer_friend_add_resp() distinguish between remote host
and self and print the appropriate hostname.
Change-Id: I2a504eeb058c08a0d378443888eb6f1dc7edc76f
BUG: 963537
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/5017
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4045eeefe598747ec4078708e71170ad75c7c84f
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu May 9 18:07:59 2013 +0530
glusterd: Start bricks on glusterd startup, only once
The restarting of bricks has been deffered until the cluster 'stabilizes'
itself volumes' view. Since glusterd_spawn_daemons is executed everytime
a peer 'joins' the cluster, it may inadvertently restart bricks that
were taken offline for say, maintenance purposes. This fix avoids that.
Change-Id: Ic2a0a9657eb95c82d03cf5eb893322cf55c44eba
BUG: 960190
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4973
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 77d6ae8f4117b762fae784592aa2380e9ccc36c2
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sat May 11 14:36:38 2013 +0530
syncop: Remove task from synclock's waitq before 'wake'
Removing task from synclock's waitq after wake could result in
a subsequent unlock, wake'ing up the already running task.
This fix makes the removal from waitq and wake 'atomic'.
Change-Id: Ie51ccf9d38f2cee84471097644aab95496f488b1
BUG: 948686
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4987
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9d057627e1dc92cdd4ea2e65f1abd636e15e67e2
Author: Vijay Bellur <vbellur@redhat.com>
Date: Wed May 15 15:30:33 2013 +0530
tests: Ensure portmap registration before nfs mount.
Change-Id: I12a660a7dfbe4a2d0428910d762434043395fe02
BUG: 927616
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/5012
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 37346db20a02e7c0860b958b42dc2c50feeefd6e
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed May 15 13:02:23 2013 -0400
tests: basic/rpm.t leaves /var/tmp/rpm-tests.* directories
When the test is terminated early because nothing changed that requires
this test, the /var/tmp/rpm-tests.xxxxxx is not removed.
BUG: 963333
Change-Id: I98d44ca34f14d62da9d836c41a9015cfb520ff96
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/5015
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 442d695395a1bc897d274c0aa88b1767b435dad8
Author: Brian Foster <bfoster@redhat.com>
Date: Wed May 15 12:30:07 2013 -0400
mount/fuse: enable fuse real async dio when available
fuse has support for optimized async. direct I/O handling via the
FUSE_ASYNC_DIO init flag. Enable FUSE_ASYNC_DIO when advertised
by fuse.
performance/write-behind: fix dio hang
Also fix a hang observed during aio-stress testing due to conflicting
request handling in write-behind. Overlapping requests are skipped
in pick_winds and may never continue when the conflicting write in
progress returns. Add a wb_process_queue() call after a non-wb request
completes to keep the queue moving.
BUG: 963258
Change-Id: Ifba6e8aba7a7790b288a32067706b75f263105d4
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/5014
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 204de6efd35f9789889dba745f3cb01062d21d63
Author: Ram Raja <rraja@redhat.com>
Date: Tue Apr 30 00:47:56 2013 +0530
glupy patch by Ram, Justin: Add/Modify fops, structure types, utility fns
Extend the following fops with Python:
* open
* readv
* writev
* opendir
* readdir
* readdirp
* stat
* fstat
* statfs
* setxattr
* getxattr
* fsetxattr
* fgetxattr
* removexattr
* fremovexattr
* link
* unlink
* readlink
* symlink
* mkdir
* rmdir
Add fd_t, inode_t and iatt_t structure types.
Modify loc_t structure type; Alter the data types of the following
attributes - inode, parent, gfid, pargfid.
Modify uuid2str function, which returns a string equivalent for a ctype
object representing a gfid, to make use of python's 'uuid' module for
accurate representation of uuids.
by Justin Clift:
Adjust debug-trace.py to work with Python 2.6
Work around 'zero length field name in format' bug in
negative.py's uuid2str function
Fix indentation errors in negative.py, glupy.h,
glupy.c, gluster.py
Change-Id: If0fcfb2866e21c0380a973f8ffab9ea7b6a4cd5d
BUG: 961856
Signed-off-by: Ram Raja <rraja@redhat.com>
Reviewed-on: http://review.gluster.org/4907
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Justin Clift <jclift@redhat.com>
Tested-by: Justin Clift <jclift@redhat.com>
commit 2cf1af143688e0a30e3619082d54921a77086713
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon May 13 14:59:21 2013 +0530
glusterd: Perform NULL check on rsp.op_errstr before using it
Change-Id: Id18b215a91cf016964ea98d2f414293b82167d24
BUG: 962362
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4992
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d2c2a36aa9bb06010b210f8350420003b1cef747
Author: Anand Avati <avati@redhat.com>
Date: Thu Apr 25 22:46:50 2013 -0700
rpcsvc: fix dangerous setting of pointer on free'd structure
The current code is setting @req->hdr_iobuf = NULL _after_ calling
actor_fn() on @req. Calling actor_fn() takes away all guarantees
of whether @req is still a valid object or destroyed.
Unfortunately most of the times the object is allocated from mem-pool
an a mem_put() still keeps the arena allocated (no crash). However
once the mem-pool is full and allocation falls back to malloc()/free()
the code actually becomes dangerous. This resulted in random crashes
when the system load is high (when there were sufficient outstanding
calls that @rpc pool got full)
Change-Id: I4398c717aa0e2c5f06733212b64dd79e7b2a4136
BUG: 884452
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4990
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f7b15b83ba2d7cb029ce2ecbcbc7ce5ccabbfb91
Author: Ravishankar N <ravishankar@redhat.com>
Date: Thu May 9 16:14:33 2013 +0000
glusterd: remove-brick: prevent removal from a replicate volume.
Prevent the removal of brick(s) from a plain replicate volume and
display the error message at the CLI.
Change-Id: I8e182404564147329d8cd364b7c7931d19f14570
BUG: 961669
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/4975
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 67648c428905fde02ba140db0c503dbe82ba79d7
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Apr 23 12:11:00 2013 +0530
glusterd: Fix uuid to hostname conversion for 'volume status'
Change-Id: I46c41c29c2d11652f6d8ccd5637be0ac9774fc1d
BUG: 927648
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4873
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 884e7b81978d2a4ce94e5b1e8de3a257dbd015f2
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Apr 22 12:17:59 2013 +0530
glusterd: Set op-version on startup based on install status
If the current installation of glusterfs doesn't have a stored
op-version and is,
a. a fresh install, then set op-version to maximum
b. an upgrade from release which didn't have op-version support, set it
to minimum.
The install status is detected using the peer-uuid.
If both peer-uuid and op-version are not present in the store, the
installation is fresh.
If peer-uuid is present, but op-version is absent in the store, the
installation has been upgraded from a version which didn't support
op-versions.
By setting the initial op-version as above, we can ensure that
a. features are not enabled accidentally during upgrades
b. a fresh install starts with all possible features enabled.
Change-Id: I52aed9ebeb5d3823c81e65f739a78a924ecf7e12
BUG: 954256
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4867
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b818d0201817984b4b852e2fcd5b555794b00671
Author: Ram Raja <rraja@redhat.com>
Date: Tue Apr 30 00:38:04 2013 +0530
glupy: Importing Jeff's glupy project into glusterfs
Change-Id: I3891ef6eaf6ede7c8cbedc3298ce2501a69b2b05
BUG: 961856
Original-author: Jeff Darcy <jdarcy@redhat.com>
Signed-off-by: Ram Raja <rraja@redhat.com>
Reviewed-on: http://review.gluster.org/4906
Reviewed-by: Justin Clift <jclift@redhat.com>
Tested-by: Justin Clift <jclift@redhat.com>
commit dc9cfd2c2ff1f67a93e31e3abbbb89e2c9013ae6
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed May 8 21:51:58 2013 -0400
object-storage: final removal of ufo code
See https://git.gluster.org/gluster-swift.git for the new location of
the Gluster-Swift code.
With this patch, no OpenStack Swift related RPMs are constructed.
This patch also removes the unused code that references the
user.ufo-test xattr key in the DHT translator.
Change-Id: I2da32642cbd777737a41c5f9f6d33f059c85a2c1
BUG: 961902 (https://bugzilla.redhat.com/show_bug.cgi?id=961902)
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4970
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Luis Pabon <lpabon@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ad982811aa47b8dfc6af8de14bb4868a358b7148
Author: Santosh Kumar Pradhan <spradhan@redhat.com>
Date: Fri May 10 14:31:27 2013 +0530
gluster/CLI: crash upon executing "peer status" command
Problem:
While doing "gluster peer status", cli_cmd_peer_status_cbk() creates
the frame and passes as arg to gf_cli_list_friends() which sets
frame->local to GF_CLI_LIST_PEERS flag (value: 0x1). It expects
gf_cli_list_friends_cbk() [invoked through cli_cmd_submit()] to
reset frame->local to NULL. But if cli_cmd_submit() fails some
where before gf_cli_list_friends_cbk() gets invoked, then the
flag value remains in frame->local and causes a SEGV while
destroying the stack i.e. [CLI_STACK_DESTROY => cli_local_wipe()].
Fix:
In gf_cli_list_friends(), if cli_cmd_submit() fails, then
reset the value of frame->local to NULL.
Change-Id: Ied19f07eaf67e3bd42c75cdc2ff3729b0789e632
BUG: 961691
Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-on: http://review.gluster.org/4976
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 24858a93b232c8040f778860d9b57c1cd23dc0bd
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue May 7 15:27:08 2013 +0530
glusterd: Give up big lock before performing any RPC
Change-Id: Ib0a772dc1cb9afc8adccd8f7092f480d2b525ea0
BUG: 960580
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4964
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4666e2b5dca993dc8065ad1302d94724bba36ed2
Author: Michael Brown <michael@netdirect.ca>
Date: Fri Apr 26 15:32:03 2013 -0400
nfs3-server: call truncate fop only if necessary
* nfs3svc_setattr_cbk: only truncate if requested size != current size
Change-Id: I3d89e4d2b0710118f90cf5bf9cfdea61d8877491
BUG: 960725
Signed-off-by: Michael Brown <michael@netdirect.ca>
Reviewed-on: http://review.gluster.org/4917
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9d7fa5033f69d88617114f8bd5ba09464438f5bd
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue May 7 11:10:26 2013 +0200
extras: /etc/init.d/glusterd should create a lockfile under /var/lock/sybsys
Without a lockfile under /var/lock/subsys, the glusterd service is not
stopped on shutdown or reboot.
Change-Id: I9dc9b4204c5c39879c22191b2e8a2b81a4f3a58a
BUG: 960476
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4960
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f495936f21223beb9e25015d9d3b6752b8c4f494
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Mar 1 15:05:04 2013 +0530
cluster/afr: Club missing entry, missing gfid self-heals
Problem:
gfid-self-heal always assigns the gfid(GFID-1) it gets from lookup.
Between the time of lookup to triggering the gfid-self-heal the
entry could have changed. Now lets say there is a case where
one of the files of the replica subolumes already has a gfid
(GFID-2) and the other does not. In that case healing should
happen with GFID-2 instead of GFID-1.
Fix:
Missing-entry-self-heal already handles all these cases. So removed
separate handling of gfid-self-heal.
Change-Id: Ie96261e9036c8f3cb4cad89347f9bf7b681cdc1a
BUG: 767585
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/2670
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0e85d4fcc3a5066e472deb2ef524079305763b15
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon May 6 17:00:57 2013 +0530
nfs: avoid double fd unref in opendir
Noticed that the fd_unref was called on the fd regardless of the return
value at nfs3svc_opendir_readdir_cbk(), hence removing an extra unref in
the negative case in nfs_inode_opendir_cbk, which fixes the spurious
fd_unref().
Change-Id: I2bf68410dd86cdf9cfe8a3d43adc27497d8bb36f
BUG: 959190
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4943
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f1b3f8b9f2553306bae6be3ac197c0b7089fd20d
Author: Michael Brown <michael@netdirect.ca>
Date: Sun May 5 03:04:16 2013 -0400
rpc-lib: fix printf args when printing XID
* Prior to change, XID is sometimes logged with wrong format string
* Incorrect (0x%ux): generates output of "XID: 0x1920499352x"
* Correct (0x%x): generates output of "XID: 0x72787e98"
Change-Id: Id60b673a4356a4815cdb67303612181ac5624fe3
BUG: 960153
Signed-off-by: Michael Brown <michael@netdirect.ca>
Reviewed-on: http://review.gluster.org/4949
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 21c064e7908d8d264d7e6087c7dcc127b05d9692
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu May 2 09:11:58 2013 +0530
Revert "glusterd: Fix spurious wakeups in glusterd syncops"
This reverts commit efa154bb0a4cac34d5a9610ec25d38eebe495f22.
-- Following is Avati's analysis (edited) from gerrit --
The claim of the patch (being reverted) is that it in some cases cbkfn
is missed. This is wrong analysis. cbk_fn is _always_ called. The patch
treats ret > 0 as a "missed cbk". ret > 0 only means socket submission
was not complete, and is queued to submit asynchronously when POLLOUT is
raised. This is sufficient to guarantee that cbkfn is going to be
called (either the socket errors or submission succeeds and reply
eventually arrives).
This commit also removes spurious barrier_wake(s).
call backs are guaranteed to be called even if the transport is
disconnected. This means, a 'wake' would be called if rpc_clnt_submit is
called. Also, we count both successful and failed operations in a
particular batch of operations for the synctask_barrier_wait. So,
calling synctask_barrier_wake on failure of rpc_clnt_submit (say, due to
network failure) would result in a spurious wake.
Change-Id: I7d508c2a54b74a65b82f097742206bc777afc53a
BUG: 948686
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4922
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a0bb3ef15cbeffd03d32788a70f6895a80baae82
Author: Anand Avati <avati@redhat.com>
Date: Mon Apr 22 04:35:03 2013 -0700
synctask: implement barriers around yield, not the other way
In the current implementation, barriers are in the core of the
syncprocessors. Wake()s are treated as syncbarrier wake. This
is however delicate, as spurious wake()s of the synctask can
mess up the accounting of the barrier and waking it prematurely.
The fix is to keep yield() and wake() as the basic primitives,
and implement barriers as an object impelemented on top of these
primitives. This way, only an explicit barrier_wake() gets
counted towards the barrier accounting, and spurious wakes
will be truly safe.
Change-Id: I8087f0f446113e5b2d0853431c0354335ccda076
BUG: 948686
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4921
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 50cb8d92f57d82bf7531aa6b0015acfb7e9b9860
Author: Anand Avati <avati@redhat.com>
Date: Sat Apr 27 11:59:36 2013 -0700
gfapi: add new API glfs_set_xlator_option()
This is the equivalent of specifying --xlator-option command line
argument to glusterfsd.
Change-Id: I1171dd518a85db4bd456fa0790f450e889a956cd
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4927
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 573f6993fb8c3a248e7aa2c816d582f1f29b3d06
Author: Anand Avati <avati@redhat.com>
Date: Sat Apr 27 11:18:20 2013 -0700
posix-acl: fetch ACLs in readdirplus
Not fetching ACLs in readdirplus can potentially result in spurious
wrong ACL decisions (which magically go away on a lookup() which
populates the ACLs)
Change-Id: Ided38b4d868fab482b477ce51b4878289ef9eed0
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4926
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 41947ff81a82ff0e8b78c2834989aa1c6b020ce7
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu May 2 16:13:59 2013 +0530
glusterd: Syncop callbks should take big lock too
Change-Id: I5ae71ab98f9a336dc9bbf0e7b2ec50a6ed42b0f5
BUG: 948686
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4938
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5a334be0ab27aadb5e63f7ed65499f810ef8f44f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu May 2 17:48:51 2013 +0530
glusterd: delete "volume-name" from dict before processing the next option
Change-Id: Ib78963c1f43a66dab50b443742979c7c4e4cbc23
BUG: 958790
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4940
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 01bdc47d2521a481f9d15bfe430c75101b02b18a
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Mar 20 17:33:10 2013 +0530
glusterd: Log hostname of the peer where there is cksum/version mismatch
Change-Id: I08065aaa3c140d4b02af4ca38f5f4d00d7f0c2bb
BUG: 958739
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4937
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7206fbca40be8e741094eb84a3790eb5c21645d2
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Apr 30 19:41:34 2013 +0530
performance/io-cache: check the inode context to be NULL before accessing
Change-Id: I475af7f8ffd5e5d8adbd2a74af20e56ad7751f69
BUG: 958108
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4916
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f6d24c02f95dfa9bebeca16569fc8b7e790714b7
Author: Michael Brown <michael@netdirect.ca>
Date: Tue Apr 30 11:34:57 2013 -0400
Expand gluster's NFS FD header to 4 bytes
* https://bugzilla.redhat.com/show_bug.cgi?id=950121
* Oracle's DNFS does not properly XDR encoding on NFS FDs that
are not congruent to 0mod4 bytes long
* This patch is a workaround to support Oracle's buggy code
Change-Id: Ic621e2cd679a86aa9a06ed9ca684925e1e0ec43f
BUG: 950121
Signed-off-by: Michael Brown <michael@netdirect.ca>
Reviewed-on: http://review.gluster.org/4918
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 209cc35bb957717f9e712a63b579854104fbecb0
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Apr 30 14:33:09 2013 +0200
Fix uninitialized mutex usage in synctask_destroy
synctask_new() initialize task->mutex is task->synccbk is NULL.
synctask_done() calls synctask_destroy() if task->synccbk is not NULL.
synctask_destroy() always destroys the mutex.
Fix that by checking for task->synccbk in synctask_destroy()
BUG: 764655
Change-Id: I50bb53bc6e2738dc0aa830adc4c1ea37b24ee2a0
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/4913
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5e2713213b7faf9bc356baa9abf1a33b8c4ca63c
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Apr 30 00:20:33 2013 +0530
cluster/afr: Avoid self-healing extended attribute used by SELinux.
Since removexattr() fails to remove "security.selinux" in a system
where SELinux is enforcing, xattr self-healing fails.
As a consequence of this, user extended attributes are not being healed.
Added a check in afr to prune SELinux xattr from the dictionary
used for removing xattrs from the sink.
Minor changes in tests and md-cache as well.
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Change-Id: I854bfc0098dde812ce2afe64b125ee40c04bdeb1
BUG: 957877
Reviewed-on: http://review.gluster.org/4905
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5a99fdb71b05ae31965d37b5e01efbfd4c33add0
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Apr 22 12:27:07 2013 +0530
glusterd: Removed 'proactive' failing of volume op
Volume operations were failed 'proactively', on the first disconnect of
a peer that was participating in the transaction.
The reason behind having this kludgey code in the first place was to
'abort' an ongoing volume operation as soon as we perceive the first
disconnect. But the rpc call backs themselves are capable of injecting
appropriate state machine events, which would set things in motion for an
eventual abort of the transaction.
Change-Id: Iad7cb2bd076f22d89a793dfcd08c2d208b39c4be
BUG: 847214
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4869
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit eac581ab5fea56cf6aaf2f8b9a65aaf2e18b4baf
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Apr 25 00:28:07 2013 +0530
tests: Modified test to use remove-brick instead of 'start' variant
remove-brick start doesn't remove the brick from the volume immediately.
It would wait until migration of data to other bricks are complete. Even
when there is no data to be migrated, one can expect a finite delay from
the time of remove-brick start command's exit and removal of brick(s).
This may cause subsequent checks on brick count to fail in a
non-deterministic manner.
Also, renamed the test file name to reflect bug-id corresponding to
community release.
Change-Id: Ic43f011e251640decb68e46f4a10e0824ade0ac9
BUG: 878004
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4885
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 644f5b9a8b7e48c27f1e6a3a6b45636023c13ebe
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Apr 21 11:10:06 2013 +0200
extras: include Fedora changes in init.d/glusterd
The changes in the .spec file from Fedora have largely been merged into
the glusterfs.spec.in. It seems that some dependencies have been missed,
most importantly some additions to the init-script that are called while
(un)installing or updating RPMs.
These changes come from the downstream Fedora package that carries its
own glusterd.init script. In future, Fedora/EPEL should be able to drop
that file and use the Gluster project version.
Change-Id: Iac25854b0c559b93fa1dd452a04663bd95ea3378
BUG: 954149
URL: http://lists.nongnu.org/archive/html/gluster-devel/2013-04/msg00077.html
CC: Fedora GlusterFS Packagers <glusterfs-owner@fedoraproject.org>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4864
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0b37b7981d81899ea765c17ed673f2cce1c446ad
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Apr 29 17:05:03 2013 +0200
Fix spurious brick disconnects
Spurious disconnect were caused by a race condition inside
rpc_transport_ref()/rpc_transport_unref() that allowed the refcount
to drop to zero while the transport was still in use. The race
condition is made possible because of an uninitiaized mutex
produced when socket_server_event_handler() copies the transport
BUG: 764655
Change-Id: I34fe097a0ac21b0dbf58f5eed84880e3fd9814f2
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/4900
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fc52baa236fa18d6822adc9c188996ff3f86c5a7
Author: Ravishankar N <ravishankar@redhat.com>
Date: Sun Apr 28 11:35:52 2013 +0530
cli: Avoid storing empty lines in command history
When the console manager is run in the interactive mode, it also saves
empty lines (i.e. the Enter key is pressed without running a command) in
it's command history. Avoid this by processing the line only if
readline() returns a non-empty string. Makes it easier to navigate the
history using arrow keys.
modified: cli/src/cli-rl.c
Change-Id: I0fcce394474589bb345b7c9ef39d25849dc0c2af
BUG: 957139
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/4894
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 37bcb1d2e33e566779604de5b23798c5953b48c2
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Apr 20 16:55:15 2013 +0200
cli: add a command 'gluster pool list [--xml]'
* unlike 'gluster peer status', which lists only info about peers,
this command lists localhost also in the list, so the sorted
output from all the nodes should match.
* made the output script friendly by keeping it one output per line.
Change-Id: I853656753b35c617debbcceecbb71c8d6dd3c334
BUG: 764638
Original-review: http://review.gluster.org/4221
Original-author: Amar Tumballi <amarts@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4862
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f7b0258b240d46291f76a1f1e6429d5cc21bf01d
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Apr 23 12:57:40 2013 -0400
build: sync glusterfs.spec.in with Fedora glusterfs.spec
BUG: 950083
Change-Id: I96aeb8fbe8b79bbc058ff9a45167d822abb576ed
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4876
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
commit 9de79cdf2ba692cd347967711361f8748b113479
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Apr 1 17:55:30 2013 +0530
glusterd: Introduce volume op-versions
Each volume is now associated with two op-versions,
* op_version - the op-version of the highest op-versioned feature enabled
* client_op_version - the op-version of the highest op-versioned feature
enabled which affects the clients only.
These two op-versions are generated dynamically and kept updated during
runtime. Glusterd now uses the respective volumes' client-op-version during
getspec requests.
To achieve the above a new field in the vme table is introduced,
client_option, this boolean field tells if the option is a client side
option.
Change-Id: I12c83b1dd29ab506026efd50d448cebbcee53c27
BUG: 907311
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4584
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit eae678dc5aeeb66cb97bfeeb9c2166d188f2a443
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 24 18:05:13 2013 +0530
performance/io-cache: Avoid double mem_put in ioc_readv
On readv error io-cache frame->local is not set to NULL
so the local is mem_put in STACK_DESTROY as well. This
patch sets frame->local to NULL in all cases.
Change-Id: I00013df1377475aa5f3c0c681dcb58b32e1e8063
BUG: 955751
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4884
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 42f9efc0c01d70b4a7cb361149d200f6da3520c4
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Apr 16 17:22:41 2013 +0530
nfs: change default nfs port to 2049
This change makes it possible to mount glusterfs volumes
without specifying vers=3 option.
Change-Id: If5a974e2bdfd2adbeac3d82af774310cdf30f988
BUG: 832939
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4840
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit b83816ec66f7e7d62a19404c2864b1a6742dea72
Author: Anand Avati <avati@redhat.com>
Date: Mon Apr 15 09:52:35 2013 -0700
gfapi: POSIX locking support
Change-Id: I37d9e1fb4a715094876be6af3856c1b4cf398021
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4881
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit eb83e215b753f2f79c7bd092e19f3013e1db24e8
Author: Anand Avati <avati@redhat.com>
Date: Tue Apr 23 14:20:13 2013 -0700
gfapi: implement readdirplus_r support
This call is used by Samba VFS.
Change-Id: Ib371502ad5a71b3b0e993f6b30e3dfb1f839c020
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4879
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 53dc6964aa8268fe0d4dbdbf9d1790b81582d8e8
Author: Anand Avati <avati@redhat.com>
Date: Tue Apr 23 13:59:12 2013 -0700
syncop: set credentials of running process in @frame
Inherit the pid/euid/egid/groups of the running process in the
frame. Do this only in cases where a loaded frame was not
presented to the synctask.
This behavior is required for Samba VFS.
Change-Id: Ib181c90f47c6741197b9ce9f67a19e2914b647d2
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4878
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7c758fa0bec2fddf340f0133ab9c1445181cfbf2
Author: Anand Avati <avati@redhat.com>
Date: Mon Apr 22 21:34:05 2013 -0700
gfapi: handle root (/) resolution gracefully for realpath()
Resolving path of / is crucial for realpath() to work properly.
Change-Id: I8a1b482beba37f01afbd20446d9e6f6125f2ec34
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4872
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 757361659f8b6b400268ec6382b42cdb764fdb6f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Apr 8 13:06:39 2013 +0530
cluster/afr: Added documentation for eager-lock check
Change-Id: Ifa42762adde8b55ef1e2b51a59c93cebd983343f
BUG: 912581
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4792
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 26b69e2db7e75d5cbec6179481e1c3309e4d05b6
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Apr 12 16:35:51 2013 +0530
glusterd: volume-sync needs to work with rejected peers
Change-Id: I970a51d3f62bcf414eb9552a68d1068430b93216
BUG: 950048
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4815
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7b81770e3e5613ed9b971c8c44f0d6376e1b3f45
Author: Anand Avati <avati@redhat.com>
Date: Sun Apr 14 02:58:34 2013 -0700
gfapi: support for chdir() and family
Add support for chdir, fchdir, getcwd, realpath equivalents in
GFAPI. These are required for the Samba VFS plugin.
Change-Id: I91d2db9146994403c98961c489c7640c51d5add2
BUG: 953694
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4853
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4f0efb0f6c6ba83b0858bc26798970a658b017df
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Apr 19 13:02:39 2013 +0530
tests: Fix volume-status test script
* The functions now return the aggregated return value instead of just echoing it.
* Fixed the shd test loop to use the proper variable
* Added 'wait's for nfs and shd services to come online.
BUG: 764966
Change-Id: Iedbb5be0d5e50108ed4847d58625ccb093c22251
Original-author: Kaushal M <kaushal@redhat.com>
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4856
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5b1afc747ad1fdaff3f7a72a099d21942eb47b6c
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Apr 9 13:08:22 2013 +0530
glusterd: validate performance.nfs.* option values during volume set stage
PROBLEM:
performance.nfs.* option values (which are of type boolean) are
not validated during the stage phase of 'volume set'.
The result - nfs graph generation fails during commit phase,
AFTER the option and its (invalid) value have been placed in
volinfo->dict.
CAUSE:
nfsperfxl_option_handler() - the function that validates the values of
performance.nfs.* options - never receives the (key,value) pair that
needs to be set, for validation during 'volume set' stage.
FIX:
In build_nfs_graph(), copy the (mod_)dict containing the (option,value)
parameters into set_dict before attempting to build the client graph
for the volume on which the operation is being performed.
Of course, an easier way out would be to simply do a 'volume reset' and
pretend nothing wrong happened!
Change-Id: I56b17d0239d58a9e0b7798933a3c8451e2675b69
BUG: 949930
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4814
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3fdb1e8a3b42a350dd4e836d790b4100bc13cdeb
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Apr 15 22:07:21 2013 +0530
glusterd: Avoided deadlock in single node cluster, glusterd restart
In a single node cluster, it is possible to deadlock on the "big
lock", while restarting bricks. In glusterd_restart_bricks, we perform a
glusterd_brick_connect, where we release the big lock in anticipation
that glusterd_brick_rpc_notify could run in the same C stack (and
deadlocking). So, in the restart code path, we could unlock before we
have performed a lock on the big lock.
To fix this, we need to take the big lock in the
glusterd_launch_synctask 'thread' as well.
Change-Id: I1abea1ca82b55c784b8a810a8194f254b32b1dcc
BUG: 948686
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4837
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 0074d8ba44cad1930590577ca0258bc076cf9ebe
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Apr 15 11:02:19 2013 +0200
rpm: remove useless provides for xlator .so files and private libraries
xlator .so files and private libraries should be skipped while scanning
for provides:
- https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering
This prevents automatic generated provides like these in the glusterfs,
glustrefs-fuse and glusterfs-server packages:
- addr.so.0()(64bit)
- afr.so.0()(64bit)
- client.so.0()(64bit)
- dht.so.0()(64bit)
- ...
BUG: 952122
Change-Id: Icd08925eb1826f3593129e7c19de83528f7b6301
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4823
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5094951d27c9dcfa07c08d4453c6b2f21be4ce8a
Author: Mohammed Junaid <junaid@redhat.com>
Date: Fri Apr 12 06:41:29 2013 +0530
object-storage: provide more common cfg defaults
Provide more common configuration defaults, as seen and recommended across
many large customer installations, as well as provide some guidance on how to
set the parameters.
See BZ 904629 (https://bugzilla.redhat.com/show_bug.cgi?id=904629).
Change-Id: Id9f20aafd75f2a0b589c67654dce87534bf80c33
BUG: 904629
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4789
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d534c946bbabcd4b8c2852bca07937928a75a0e0
Author: Mohammed Junaid <junaid@redhat.com>
Date: Sun Apr 7 07:18:06 2013 +0530
object-storage: cleanup err handling in Glusterfs.
Change-Id: I4fa1a7b9214c6897459a99bedde80e84eb2b9cbc
BUG: 904370
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4788
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9313b532c3270e4f103367e43aa29d4bfb97ffaa
Author: Mohammed Junaid <junaid@redhat.com>
Date: Sun Apr 7 06:05:56 2013 +0530
object-storage: turn off stat() for container list
Turn of stat() system calls used to fetch the file size during a
container listing operation since these system calls can swamp Gluster
and the result is most often not used.
When a GET or HEAD request is made on a container, stat() system calls
are made during the Python standard library method, os.walk, to
determine if a given directory entry is another directory to recurse
into, and then utils._update_list() will stat() each file to get it
size, and finally utils.get_container_details_from_fs() will stat()
each directory encountered.
For most installations we have seen so far, we don't need the
container listing to accurately return the size of all the objects in
the container, so we can reduce the number of stat() system calls by
not fetching the size of the object.
For now, turn it off by default, and provide an /etc/swift/fs.conf
configuration parameter to turn it back on:
accurate_size_in_listing = yes
The default for the above is "no".
Change-Id: I7dde11e14bb32ecafa3eabb08852f1ffc4366b35
BUG: 903396
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4787
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4bc39a8f1875478d094c81851bad851a658c4528
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Apr 2 07:56:25 2013 +0530
glusterd: big lock - a coarse-grained locking to prevent races
There are primarily three lists that are part of glusterd process,
that are concurrently accessed. Namely, priv->volumes, priv->peers
and volinfo->bricks_list.
Big-lock approach
-----------------
WHAT IS IT?
Big lock is a coarse-grained lock which protects all three
lists, mentioned above, from racy access.
HOW DOES IT WORK?
At any given point in time, glusterd's thread(s) are in execution
_iff_ there is a preceding, inbound network event. Of course, the
sigwaiter thread and timer thread are exceptions.
A network event is an external trigger to glusterd, via the epoll
thread, in the form of POLLIN and POLLERR.
As long as we take the big-lock at all such entry points and yield
it when we are done, we are guaranteed that all the network events,
accessing the global lists, are serialised.
This amounts to holding the big lock at
- all the handlers of all the actors in glusterd. (POLLIN)
- all the cbks in glusterd. (POLLIN)
- rpc_notify (DISCONNECT event), if we access/modify
one of the three lists. (POLLERR)
In the case of synctask'ized volume operations, we must remember that,
if we held the big lock for the entire duration of the handler,
we may block other non-synctask rpc actors from executing.
For eg, volume-start would block in PMAP SIGNIN, if done incorrectly.
To prevent this, we need to yield the big lock, when we yield the
synctask, and reacquire on waking up of the synctask.
Change-Id: Ib929f9905b55fb6c3fc27fefb497a26dba058e4f
BUG: 948686
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4784
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 024808978affa8c984998970968be37d1679e625
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Apr 12 09:08:49 2013 -0400
license: xlators/protocol/server dual license GPLv2 and LGPLv3+
BUG: 951549
Change-Id: I3de5bd86d4238a60a0a85ba2e15d9c131969b210
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4816
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8c99b867073442e8ec04dbfe4b892940e9f39321
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Apr 11 09:36:35 2013 -0400
object-storage: rebase Swift to 1.8.0 (grizzly)
Two minor tweaks found while packaging 3.4.0-0.1.alpha2 for Fedora 19
BUG: 948039
Change-Id: I97175636164702cf4042bc4a18ffead76ad386cb
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4807
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 470e77fca6d87d3258eca35fef1a7bc7aa5ec378
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Apr 10 17:12:01 2013 +0530
glusterd: Fixed spurious wakeups in glusterd syncops
glusterd syncops perform a barrier_wake whenever rpc_clnt_submit returned -1.
This is based on the wrong assumption that the cbkfn wasn't called.
This would result in one more wakeup than there ought to be.
Change-Id: I591e67c267f0e26d1145bf8fb5feeb2c13a751a1
BUG: 948686
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4802
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 657f1c3adfd3444af996e63854e609d289844bc4
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Apr 10 15:08:51 2013 -0400
build: add BuildRequires librdmacm-devel
See http://review.gluster.org/149
Installed librdmacm-devel RPM on the build server.
Change-Id: Iafb30e9cf1b15272b80329cc6141c7e92b43daee
BUG: 950083
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4804
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b559a0bdc09a40436b8d7172dd4fcf0d5190c191
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Apr 10 17:51:37 2013 +0200
build: really disable fusermount if you say so
There is no logic in configure.ac that provides a $disable_fusermount
variable. So, use the $enable_fusermount variable instead.
Follow-up-for: http://review.gluster.org/4773
Change-Id: I81cdbd0045409d0036438d542ca6dc1934f784e4
BUG: 948205
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4803
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Sachidananda Urs <sacchi@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4ae685690ae6e6ba55b7242b12f7d58261f750b0
Author: Anand Avati <avati@redhat.com>
Date: Tue Apr 9 17:22:01 2013 -0700
tests: fix further issues with bug-874498.t
The failure of bug-874498.t seems to be a "bug" in glustershd.
The situation seems to be when both subvolumes of a replica are
"local" to glustershd, and in such cases glustershd is sensitive
to the order in which the subvols come up.
The core of the issue itself is that, without the patch (#4784),
self-heal daemon completes the processing of index and no entries
are left inside the xattrop index after a few seconds of volume
start force. However with the patch, the stale "backing file"
(against which index performs link()) is left. The likely reason
is that an "INDEX" based crawl is not happening against the subvol
when this patch is applied.
Before #4784 patch, the order in which subvols came up was :
[2013-04-09 22:55:35.117679] I [client-handshake.c:1456:client_setvolume_cbk] 0-patchy-client-0: Connected to 10.3.129.13:49156, attached to remote volume '/d/backends/brick1'.
...
[2013-04-09 22:55:35.118399] I [client-handshake.c:1456:client_setvolume_cbk] 0-patchy-client-1: Connected to 10.3.129.13:49157, attached to remote volume '/d/backends/brick2'.
However, with the patch, the order is reversed:
[2013-04-09 22:53:34.945370] I [client-handshake.c:1456:client_setvolume_cbk] 0-patchy-client-1: Connected to 10.3.129.13:49153, attached to remote volume '/d/backends/brick2'.
...
[2013-04-09 22:53:34.950966] I [client-handshake.c:1456:client_setvolume_cbk] 0-patchy-client-0: Connected to 10.3.129.13:49152, attached to remote volume '/d/backends/brick1'.
The index in brick2 has the list of files/gfid to heal. It appears
to be the case that when brick1 is the first subvol to be detected
as coming up, somehow an INDEX based crawl is clearing all the
index entries in brick2, but if brick2 comes up as the first subvol,
then the backing file is left stale.
Also, doing a "gluster volume heal full" seems to leave out stale
backing files too. As the crawl is performed on the namespace and
the backing file is never encountered there to get cleared out.
So the interim (possibly permanent) fix is to have the script issue
a regular self-heal command (and not a "full" one).
The failure of the script itself is non-critical. The data files are
all healed, and it is just the backing file which is left behind. The
stale backing file too gets cleared in the next index based healing,
either triggered manually or after 10mins.
Change-Id: I5deb79652ef449b7e88684311e804a8a2aa4725d
BUG: 874498
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4798
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit f2594a6a7770367624a631be7ce54f00c60b38e0
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Feb 12 17:26:35 2013 +0530
glusterd: changes in 'volume create' behaviour
This patch incorporates all the changes suggested on the behaviour of
'volume create' command in http://review.gluster.org/#change,4214
(comment #14, to be precise).
Change-Id: Iaac524a59738b177415595b18aa8a136090d3d25
BUG: 948729
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4740
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 15237df5e7201aba028ffacee1af388e19dd8a26
Author: Anand Avati <avati@redhat.com>
Date: Fri Apr 5 16:26:53 2013 -0700
tests: fix dependency on sleep in bug-874498.t
With the introduction of http://review.gluster.org/4784, there are
delays which breaks bug-874498.t which wrongly depends on healing
to finish within 2 seconds.
Fix this by using 'EXPECT_WITHIN 60' instead of sleep 2.
Change-Id: I2716d156c977614c719665a5e1f159dabf2878b5
BUG: 874498
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4796
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8e31ae084d558df38ec82b3ead7f05cc40e1fe13
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Mar 18 12:32:35 2013 +0530
mgmt/glusterd: enable valgrind usage even in non DEBUG build
* Till now running glusterfs processes were allowed to run in valgrind
mode only when built with debug mode enabled.
Change-Id: I11e07ea2a4da4f82f70cdded6258a22d65d6db64
BUG: 922877
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4688
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 1d7eaf800f9a383ad539be44f49bd4b6ea17454c
Author: shishir gowda <sgowda@redhat.com>
Date: Thu Apr 4 11:23:08 2013 +0530
cluster/distribute: Ignore non-participating subvols for layout checks
When subvols-per-directory is < available subvols, then there are layouts
which are not populated. This leads to incorrect identification of holes or
overlaps. We need to ignore layouts, which have err == 0, and start == stop.
In the current scenario (start == stop == 0).
Additionally, in layout-merge, treat missing xattrs as err = 0. In case of
missing layouts, anomalies will reset them.
For any other valid subvoles, err != 0 in case of layouts being zeroed out.
Also reverted back dht_selfheal_dir_xattr, which does layout calculation only
on subvols which have errors.
Change-Id: I9f57062722c9e8a26285e10675c31a78921115a1
BUG: 921408
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4668
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 373b833d15cc513934f777711453d70a52eebcc3
Author: Anand Avati <avati@redhat.com>
Date: Fri Apr 5 02:18:06 2013 -0700
syncenv: be robust against spurious wake()s
In the current implementation, when the callers of synctasks perform
a spurious wake() of a sleeping synctask (i.e, an extra wake() soon
after a wake() which already woke up a yielded synctask), there is
now a possibility of two sync threacs picking up the same synctask.
This can result in a crash. The fix is to change ->slept = 0|1 and
membership of synctask in runqueue atomically.
Today we dequeue a task from the runqueue in syncenv_task(), but
reset ->slept = 0 much later in synctask_switchto() in an unlocked
manner -- which is safe, when there are no spurious wake()s.
However, this opens a race window where, if a second wake() happens
after the dequeue, but before setting ->slept = 0, it results in
queueing the same synctask in the runqueue once again, and get
picked up by a different synctask.
This is has been diagnosed to be the crashes in the regression tests
of http://review.gluster.org/4784. However that patch still has a
spurious wake() [the trigger for this bug] which is yet to be fixed.
Change-Id: I9b4b9dd5115d6e62ba45162ae90dd5e917a4f83d
BUG: 948686
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4795
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3195087f9559c03f976caf4e358c4f086cde4dc0
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Apr 8 15:32:49 2013 -0400
tests: fix spurious regression test failures
Change-Id: I752aeb8e25f43281d2f5cf33d0ff5aeae49687e7
BUG: 764966
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4794
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit de8463075fb359bf712f5914f7f088e1b0050d99
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Apr 7 21:39:18 2013 +0530
cli: Address a double free with volume info.
Crash is observed when volume info is performed on a
non-exisiting volume name and the output format is xml.
Change-Id: I88aa5d9dc954b1352f5cc3b5b38742c832bc1bb8
BUG: 949298
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4785
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c2df43046b0ffee5709c79f1d50fb7d01657ce2d
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Apr 8 00:46:27 2013 +0530
glusterfsd: Cleanup temporary files from /tmp
For each gluster{d,fs,fsd} start, one or more temporary
file(s) created in /tmp were not being unlinked. This
patch cleans that up.
Modified a typo in an unrelated log message as well.
Change-Id: I3dec2a2ca40c7d6828eb238ec9cd08b6072cf0dd
BUG: 949327
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4786
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fbccb0da63bc0836f6ec2de0e0ebc4afab41cc41
Author: Anand Avati <avati@redhat.com>
Date: Thu Apr 4 19:35:11 2013 -0700
afr: let eager-locking do its own overlap checks
Today there is a non-obvious dependence of eager-locking on
write-behind. The reason is that eager-locking works as long
as the inheriting transaction has no overlaps with any of the
transactions already in progress. While write-behind provides
non-overlapping writes as a side-effect most of times (and only
guarantees it when strict-write-ordering option is enabled,
which is not on by default) eager-lock needs the behavior
as a guarantee. This is leading to complex and unwanted checks
for the presence of write-behind in the graph, for the simple
task of checking for overlaps.
This patch removes the interdependence between eager-locking
and write-behind by making eager-locking do its own overlap checks
with in-progress writes.
Change-Id: Iccba1185aeb5f1e7f060089c895a62840787133f
BUG: 912581
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4782
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit b5dacb5bba5a230976b9d46e9cfa53e393f3d30a
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Apr 4 07:49:28 2013 -0400
object-storage: rebase Swift to 1.8.0 (grizzly)
Change-Id: I24265c12a45eac4cec761748096118c9647440be
BUG: 948039
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4779
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 13c1ae0dc904183816ec5ebae8d0767d40df434f
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Feb 21 22:10:27 2013 +0530
storage/posix: introduce node-uuid-pathinfo
enabling this option has an effect on pathinfo xattr
request returning <node-uuid>:<path> instead of the
default - which is <hostname>:<path>.
Change-Id: Ice1b38abf8e5df1568bab6d79ec0d53dfa520332
BUG: 765380
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/4567
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 51a29785f53f8fa361f32f7f46e350ba9cc2db95
Author: Peter Portante <peter.portante@redhat.com>
Date: Thu Apr 4 13:08:32 2013 -0400
object-storage: use tox for unit tests; fix em too
Add the ability to use tox for unit tests, since it helps us solve the
problem of supporting multiple branches that require different
versions of dependencies, and allows us to possibly support multiple
versions of python in the future.
Also fix the code to work with pre-grizzly environments, by not
requiring the constraints backport.
Also fixed the xattr support to work with both pyxattr and xattr
modules.
And fixed the ring tests to also work without a live /etc/swift
directory.
BUG: 948657 (https://bugzilla.redhat.com/show_bug.cgi?id=948657)
Change-Id: I2be79c8ef8916bb6552ef957094f9186a963a068
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4781
Reviewed-by: Alex Wheeler <wheelear@gmail.com>
Tested-by: Alex Wheeler <wheelear@gmail.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b587e67ea988688da08c0996833afa4873e55467
Author: Mohammed Junaid <junaid@redhat.com>
Date: Wed Apr 3 05:40:17 2013 +0530
object-storage: Import missing sys and errno modules.
Import the missing modules and implemented unit test case for Glusterfs module.
Thanks to Paul Smith for pointing it out.
Change-Id: Ib04202aa0ae05c4da2ebbf11f87d6accc778f827
BUG: 905946
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4758
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a3bd57adc85646c0e32bf24494705f7371b17279
Author: sarvotham s pai <spai@redhat.com>
Date: Mon Apr 1 00:44:34 2013 +0530
gsync: Display additional information in status command
Added code to display extra information when status command
is executed.
Information shown now are
1 Number of files synced
2 crawl time
3 total sync time
4 bytes synced
bytes synced is taken from rsync output .
--stats option of rsync gives extra infor
mation about the sync.In stats output there
is a field called Total transferred file
size which states the ammount of bytes synced .
This information is parsed from stdout output
using regular expressions.Bytes synced information
can be used to calculate throughput.
Change-Id: Id9bba9fff45ee7049bb8257c6fd918e5237e05b1
BUG: 947774
Signed-off-by: sarvotham s pai <spai@redhat.com>
Reviewed-on: http://review.gluster.org/4749
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 16ae0b81d059dff31552a95fc777ac9bd91a78ef
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Apr 3 14:15:16 2013 +0530
tests: Remove grep process entries from pidgrep
Problem:
We were picking process with lowest pid from ps|grep
result. However, lowest pid need not be oldest process
as recycling of PIDs can take place.
Solution:
Removed grep process entries from ps entries using
grep -v grep.
Change-Id: I2b9687a05a34cf6358f773183770d69a3fb9eb10
BUG: 858488
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/4765
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f4ab9cef19f558f5909e3c5ccad967c5dc554ff8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Feb 28 14:50:16 2013 +0530
cluster/afr: Treat all dir fop failure as success in changelog
For example:
If a new entry creation fop fails with EEXIST or a delete entry fop
fails with ENOENT, on all the subvols the fop is wound, then no
change took place to the directory. So we can treat that case as no
change happened to the directory.
Change-Id: I3b3a7931954da2166a9cba19ff9f76f37739d751
BUG: 860210
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4626
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f668e3139d907cf22a3c618565dcac71ddde11c7
Author: Anand Avati <avati@redhat.com>
Date: Wed Apr 3 16:31:07 2013 -0700
posix: fix dangerous "sharing" of fd in readdir between two requests
posix_fill_readdir() is a multi-step function which performs many
readdir() calls, and expects the directory cursor to have not
"seeked away" elsewhere between two successive iterations. Usually
this is not a problem as each opendir() from an application has its
own backend fd, and there is nobody else to "seek away" the directory
cursor. However in case of NFS's use of anonymous fd, the same fd_t
is shared between all NFS readdir requests, and two readdir loops can
be executing in parallel on the same dir dragging away the cursor in
a chaotic manner.
The fix in this patch is to lock on the fd around the loop. Another
approach could be to reimplement posix_fill_readdir() with a single
getdents() call, but that's for another day.
Change-Id: Ia42e9c7fbcde43af4c0d08c20cc0f7419b98bd3f
BUG: 948086
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4774
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1c0a151ecc27bb2adf87aa057f2967952aca1630
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue Apr 2 15:15:52 2013 +0530
cluster/afr: Made afr_sh_purge_entry_common message log more clear.
FIX:
In missing entry self heal, once the source directories are determined
after the lookup and if file is not present on any of the brick which
contains the souce directory, the entry is removed from the directory.
So log message should give information of "Purging of entry".
Change-Id: I4d3deb602e0812dc1c9c8ba0a466716d81dede7e
BUG: 947312
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4753
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2dd682185ac4d4d6e9ff900b478a7afea409ea69
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Wed Apr 3 16:59:27 2013 +0530
dict: Put "goto out" in dict_unserialize to avoid process crash
Problem:
In the dictionary serialization function, if the
[(buf + vallen) > (orig_buf + size)], then memdup is getting failed.
Fix:
Put "goto out" whenever this condition is met.
Change-Id: I662628a936596dbb47825aad47d7dbab2879eb07
BUG: 947824
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4767
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9f62a15930d30a1e119d93b60c4f61d897dd1c53
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Apr 3 15:27:01 2013 +0530
pump: Set self-heal readdir size in pump
Problem:
In Pump entry self-heal happens for each directory during the
first opendir using conservative merge. But in entry-self-heal
readdir is issued with '0' size. So entry self-heal is not
creating any files. After pump thinks entry self-heal is complete
it proceeds to heal each of the file in the directory it just
healed. Fortunately most of the times it chooses source-brick
in pump as read-child for readdir. This happens because readchild is the
subvolume on which lookup succeeds first. In pump lookup succeeds
faster in local process than on the destination brick process most
of the times. For all the entries pump finds in readdir it does a
lookup. During this lookup the entry on the destination brick is
created and healed. This is the reason why replace-brick
succeeds whenever read-child for the directory is chosen as the
source-brick. Which is most of the times. When read-child is chosen
as the destination brick, readdir returns no entries so replace-brick
completes without syncing the whole data.
Fix:
Set readdir-size in pump so that entry self-heal happens with
64k size. This ensures that entry self-heal triggered from
opendir actually creates the files on the destination brick.
Change-Id: I65ea45d3c2735a9578f3aa34eff771b6563241ca
BUG: 909800
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4712
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b2995e076230e98361d465e076f5abbc70b310af
Author: Anand Avati <avati@redhat.com>
Date: Wed Apr 3 13:38:00 2013 -0700
build: enable fusermount by default
The fusermount available in gluster is customized to ensure
mounting with SELinux happens properly, i.e - to have a separate
thread for fuse_thread_proc which can process getxattr requests
and in parallel perform sys_mount() in a different thread, thereby
avoiding a deadlock.
However our build and packaging defaults to not including our
fusermount. This patch reverses the defaults.
Change-Id: I793af4c2f56aeac46efae3db30e7c64ee7c18850
BUG: 811217
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4773
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 980d55bce7c396d84111967df14fce7e294269a8
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 14 15:54:07 2013 +0530
protocol/client: Print valid loc identifiers
Change-Id: I45f91105862a2484b8906a7a63b98ab4aaf80d05
BUG: 924643
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4683
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7987e94eacbe4cea4708f831c6967a11d1ce031b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 21 19:11:25 2013 -0400
dht: make nufa/switch call dht's init/fini
These functions keep changing as new functionality is added, so copying
and pasting the code is not a good solution. This way ensures that all
fields get initialized properly no matter how much new stuff we throw in.
Change-Id: I9e9b043d2d305d31e80cf5689465555b70312756
BUG: 924488
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4710
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7741572496e81a0227206f4a1b035203cc3a2b2c
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 21 19:02:52 2013 -0400
core: add dispatch table for init/fini
This adds a layer of indirection so that derivative translators such as
NUFA and switch can refer to the parent's init/fini (in both cases DHT's)
without having to create stub functions.
Change-Id: I1af1fea70a9ddd2aa20485af7ae65f9660f19dd6
BUG: 924490
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4709
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d6403db62156c1a7c94e378759e5460136b1f786
Author: shishir gowda <sgowda@redhat.com>
Date: Mon Mar 4 07:17:31 2013 +0530
cluster/distribute: Start rebalance with option readdir-optimize on
With readdir-optimize set to on, we instruct the posix layer to ignore
directory entries from not first subvolume. DHT discards directories
returned from non first subvolume. By making posix itself ignore it,
we are making directory crawls faster
Change-Id: Ia1faf2dedec0c615c0632c3c063e846f5742ede6
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4613
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3317fe3987037ca17f635d11f2a63251831550b1
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Apr 3 13:17:29 2013 +0200
build: require /usr/bin/fusermount when not carrying our own version
The fuse.so from glusterfs-fuse will try to call /usr/bin/fusermount.
This obviously fails when the fuse package is not installed and
fusermount is not available.
In order to prevent this problem, the glusterfs-fuse package should
require /usr/bin/fusermount so that it gets automatically pulled in when
glusterfs-fuse is installed with yum.
BUG: 947830
Change-Id: I20fe836a1aaf751dbc04d9ec4ba5ea50573c71c5
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4768
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 65a3f3fd9aa2a503431ae60e887ce5f1d81ab890
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Wed Mar 27 12:35:49 2013 +0530
rpc-lib: Move defaulting to socket message to debug level
Problem:
For every gluster cli operation from command line
rpc init process is required. During init process we
print "no transport type set, defaulting to socket"
message at WARNING level, which is not necessary.
Solution:
Moved the log level to DEBUG.
Change-Id: I73f4644264368b0f6c11a77ef66595018784ce79
BUG: 928204
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/4727
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8a74c732b286c421df611852908b66a98b4af9d9
Author: Bala.FA <barumuga@redhat.com>
Date: Fri Mar 29 11:50:13 2013 +0530
cli: add more meaningful error messages
Change-Id: I6e88e6763fa537f4705427b4673d86e6443c2c98
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/4747
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 738bd2521a6ad908411457f1fad8d853c2219146
Author: Bala.FA <barumuga@redhat.com>
Date: Thu Mar 28 12:42:45 2013 +0530
glusterd: add more specific log messages
Change-Id: I57fbdd83f3098e64886c3dd690a1ae04fc37442d
BUG: 928648
Signed-off-by: Bala.FA <barumuga@redhat.com>
Reviewed-on: http://review.gluster.org/4739
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 43242ae5f2a302d25f6f9521cddc561ee7dfd0e5
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Mar 4 16:23:46 2013 +0530
Tests: Change rebalance status verification
According to the comment at the following URL
https://bugzilla.redhat.com/show_bug.cgi?id=916226#c2
"success:" can come even before rebalance is completed.
Changed it to check for "completed" instead.
Change-Id: Ibe9d3b75493240f30261ac2a1280f32ef32886da
BUG: 916226
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4614
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f5517f9216e5dcbae0652a8856a49e737e890ff6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Mar 3 20:41:30 2013 +0530
cluster/afr: detect in-progress creation in lookup and return ENOENT
if any subvol returned ENOENT while parent entrylk lock was held,
yield and return ENOENT for the entire lookup.
This is how the issue happens:
Multiple clients A, B and C are attempting 'mkdir -p /mnt/a/b/c'
1 Client A is in the middle of mkdir(/a). It has acquired lock.
It has performed mkdir(/a) on one subvol, and second one is still
in progress
2 Client B performs a lookup, sees directory /a on one,
ENOENT on the other, succeeds lookup.
3 Client B performs lookup on /a/b on both subvols, both return ENOENT
(one subvol because /a/b does not exist, another because /a
itself does not exist)
4 Client B proceeds to mkdir /a/b. It obtains entrylk on inode=/a with
basename=b on one subvol, but fails on other subvol as /a is yet to
be created by Client A.
5 Client A finishes mkdir of /a on other subvol
6 Client C also attempts to create /a/b, lookup returns ENOENT on
both subvols.
7 Client C tries to obtain entrylk on on inode=/a with basename=b,
obtains on one subvol (where B had failed), and waits for B to unlock
on other subvol.
8 Client B finishes mkdir() on one subvol with GFID-1 and completes
transaction and unlocks
9 Client C gets the lock on the second subvol, At this stage second
subvol already has /a/b created from Client B, but Client C does not
check that in the middle of mkdir transaction
10 Client C attempts mkdir /a/b on both subvols. It succeeds on
ONLY ONE (where Client B could not get lock because of
missing parent /a dir) with GFID-2, and gets EEXIST from ONE subvol.
This way we have /a/b in GFID mismatch. One subvol got GFID-1 because
Client B performed transaction on only one subvol (because entrylk()
could not be obtained on second subvol because of missing parent dir --
caused by premature/speculative succeeding of lookup() on /a when locks
are detected). Other subvol gets GFID-2 from Client C because while
it was waiting for entrylk() on both subvols, Client B was in the
middle of creating mkdir() on only one subvol, and Client C does not
"expect" this when it is between lock() and pre-op()/op() phase of the
transaction.
Original-author: Anand Avati <avati@redhat.com>
Change-Id: Idca475dbbc2a51e09da6fa0f9e1e37148caef208
BUG: 860210
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4625
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 82301ab35a3cd8f6441b1b7c278b7a52494858c3
Author: Alex Wheeler <wheelear@gmail.com>
Date: Fri Mar 29 10:56:17 2013 -0400
Adds missing functions to ring.py, and more thorough tests.
Situation:
The function get_part_nodes is being called by Openstack-Swift's proxy/controllers/base.py:
https://github.com/openstack/swift/blob/1.7.4/swift/proxy/controllers/base.py#L410
https://github.com/openstack/swift/blob/1.7.6/swift/proxy/controllers/base.py#L447
As this was not implemented in the current GlusterFS version of ring.py, it was calling swift's
original get_part_nodes, which would often return the incorrect node, resulting in the incorrect
drive being associated with a request.
There is another function that the original ring.py implements -- get_other_nodes, which has to
do with replication. Since GlusterFS is handling replication, this function should never be
called. However, in the interest of completeness, that function is also being replaced.
Code changes:
The two functions, get_part_nodes, and get_other_nodes have been implemented to override the
default functions, and get_nodes has been updated to store information in self vars, about the
account being operated on, as the two new functions are not called with that info, and get_nodes
appears to always be called first.
The code has be refactored to all call _get_part_nodes, much like swift has refactored their code.
Reason for implementation this way:
I didn't see a better way to do it, but am open to suggestions.
Test cases:
A mock ring is created with two different devices, test and iops
test_first_device: Ensure that the first device, test, is returned for both get_nodes, and
get_part_node, and get_more_nodes returns volume_not_in_ring.
test_invalid_device: Ensure that a request for a non-existant device returns volume_not_in_ring.
test_second_device: Same as test_first_device, but for the second device, iops instead of test.
test_second_device_with_reseller_prefix: Test that calling with the reseller prefix, AUTH_ will
still return the correct data.
Change-Id: I2f3d526934a47b01e9c065d0edf0fbf06f300369
BUG: 924792
Signed-off-by: Alex Wheeler <wheelear@gmail.com>
Reviewed-on: http://review.gluster.org/4748
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5043a514dd23552fd824c7fae2ba6b895343f1b2
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed Mar 13 17:35:25 2013 +0530
rpc/nfs: cleanup legacy code of general options
Removing the code which handles "general" options.
Since it is no longer possible to set general options which
apply for all volumes by default, this was redundant.
This cleanup of general options code also solves a bug wherein
with nfs.addr-namelookup on, nfs.rpc-auth-reject wouldn't work
on ip addresses
Change-Id: Iba066e32f9a0255287c322ef85ad1d04b325d739
BUG: 921072
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4691
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e562d63b36f96de677888a2826aff20b333bdba3
Author: Anand Avati <avati@redhat.com>
Date: Sat Mar 23 13:55:09 2013 -0700
synctask: introduce synclocks for co-operative locking
This patch introduces a synclocks - co-operative locks for synctasks.
Synctasks yield themselves when a lock cannot be acquired at the time
of the lock call, and the unlocker will wake the yielded locker at
the time of unlock.
The implementation is safe in a multi-threaded syncenv framework.
It is also safe for sharing the lock between non-synctasks. i.e, the
same lock can be used for synchronization between a synctask and
a regular thread. In such a situation, waiting synctasks will yield
themselves while non-synctasks will sleep on a cond variable. The
unlocker (which could be either a synctask or a regular thread) will
wake up any type of lock waiter (synctask or regular).
Usage:
Declaration and Initialization
------------------------------
synclock_t lock;
ret = synclock_init (&lock);
if (ret) {
/* lock could not be allocated */
}
Locking and non-blocking lock attempt
-------------------------------------
ret = synclock_trylock (&lock);
if (ret && (errno == EBUSY)) {
/* lock is held by someone else */
return;
}
synclock_lock (&lock);
{
/* critical section */
}
synclock_unlock (&lock);
Change-Id: I081873edb536ddde69a20f4a7dc6558ebf19f5b2
BUG: 763820
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4717
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e28db102a559a44fdf83cc5da72c7620655974b1
Author: Venky Shankar <vshankar@redhat.com>
Date: Sat Mar 9 16:36:56 2013 +0530
cluster/afr: sync xattrs removed on source to sink(s)
xattrs are first removed from sink followed by setting
source xattrs.
Change-Id: I181cb5b785b667bbfc6e40787a2183a8f45de06b
BUG: 906646
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/4656
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit eb7e8f938355bad7d724d2e49f3c279f4d447da1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Apr 2 00:24:45 2013 +0530
cluster/afr: prevent piggyback on stale pre_op
Here are the logs of a file on which we saw EIO because of size mismatch:
[root@lizzie ~]# grep 38f18204 /var/log/glusterfs/mnt-x-.log
Reporting Unstable write for 38f18204-2840-408e-ae65-c01f4106b8c4
for offset: 0, len: 7680
Cleared unstable write flag for 38f18204-2840-408e-ae65-c01f4106b8c4:
offset 0 length 7680
Reporting Unstable write for 38f18204-2840-408e-ae65-c01f4106b8c4 for
offset: 7680, len: 71680
Reporting Unstable write for 38f18204-2840-408e-ae65-c01f4106b8c4 for
offset: 79360, len: 15716
fsync completed on 38f18204-2840-408e-ae65-c01f4106b8c4 for
offset 0 length 7680 with changelog status: -1 -1
According to these logs fsync did not happen after writev with
offset: 79360, len: 15716. Which is the reason for this problem.
In total 3 writes came. lets call them w1, w2, w3
w1 does pre_op so pre_op_done[0], pre_op_done[1] counts become 1 and 1
then is_piggyback_post_op() is called for w1 and it returns *false*
w1's fsync is fired
Now w2 and w3 come and see that pre_op_done[0], pre_op_done[1] are both 1,
so pre_op_piggyback[0] and pre_op_piggyback[1] are both incremented twice,
once by w2, one more time by w3 and become 2, 2 ------- Step-A
Now fsync of w1 is complete and it goes ahead with post op and decrements
pre_op_done[0], pre_op_done[1] to 0, 0
Now w2, w3 writevs complete and is_piggyback_post_op will return *true* for
both w2, w3.
So fsync is not fired for both w2, w3
this patch prevents Step-A from happening.
Change-Id: I8b6af1f1875b2cf5f718caa3c16ee7ff3dc96b5c
BUG: 927146
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4752
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a5363377f970ee77b494893f3af5ff4a5c4da623
Author: Anand Avati <avati@redhat.com>
Date: Sun Mar 17 03:32:44 2013 -0700
dht: improve transform/detransform of d_off (and be ext4 safe)
The scheme to encode brick d_off and brick id into global d_off has
two approaches. Since both brick d_off and global d_off are both 64-bit
wide, we need to be careful about how the brick id is encoded.
Filesystems like XFS always give a d_off which fits within 32bits. So
we have another 32bits (actually 31, in this scheme, as seen ahead) to
encode the brick id - which is typically plenty.
Filesystems like the recent EXT4 utilize the upto 63 low bits in d_off,
as the d_off is calculated based on a hash function value. This leaves
us no "unused" bits to encode the brick id.
However both these filesystmes (EXT4 more importantly) are "tolerant" in
terms of the accuracy of the value presented back in seekdir(). i.e, a
seekdir(val) actually seeks to the entry which has the "closest" true
offset.
This "two-prong" scheme exploits this behavior - which seems to be the
best middle ground amongst various approaches and has all the advantages
of the old approach:
- Works against XFS and EXT4, the two most common filesystems out there.
(which wasn't an "advantage" of the old approach as it is borken against
EXT4)
- Probably works against most of the others as well. The ones which would
NOT work are those which return HUGE d_offs _and_ NOT tolerant to
seekdir() to "closest" true offset.
- Nothing to "remember in memory" or evict "old entries".
- Works fine across NFS server reboots and also NFS head failover.
- Tolerant to seekdir() to arbitrary locations.
Algorithm:
Each d_off can be encoded in either of the two schemes. There is no
requirement to encode all d_offs of a directory or a reply-set in
the same scheme.
The topmost bit of the 64 bits is used to specify the "type" of encoding
of this particular d_off. If the topmost bit (bit-63) is 1, it indicates
that the encoding scheme holds a HUGE d_off. If the topmost bit is is 0,
it indicates that the "small" d_off encoding scheme is used.
The goal of the "small" d_off encoding is to stay as dense as possible
towards the lower bits even in the global d_off.
The goal of the HUGE d_off encoding is to stay as accurate (close) as
possible to the "true" d_off after a round of encoding and decoding.
If DHT has N subvolumes, we need ROOF(Log2(N)) "bits" to encode the brick
ID (call it "n").
SMALL d_off
===========
Encoding
--------
If the top n + 1 bits are free in a brick offset, then we leave the
top bit as 0 and set the remaining bits based on the old formula:
hi_mask = 0xffffffffffffffff
hi_mask = ~(hi_mask >> (n + 1))
if ((hi_mask & d_off_brick) != 0)
do_large_d_off_encoding ()
d_off_global = (d_off_brick * N) + brick_id
Decoding
--------
If the top bit in the global offset is 0, it indicates that this
is the encoding formula used. So decoding such a global offset will
be like the old formula:
if ((d_off_global & 0x8000000000000000) != 0)
do_large_d_off_decoding()
d_off_brick = (d_off_global % N)
brick_id = d_off_global / N
HUGE d_off
==========
Encoding
--------
If the top n + 1 bits are NOT free in a given brick offset, then we
set the top bit as 1 in the global offset. The low n bits are replaced
by brick_id.
low_mask = 0xffffffffffffffff << n // where n is ROOF(Log2(N))
d_off_global = (0x8000000000000000 | d_off_brick & low_mask) + brick_id
if (d_off_global == 0xffffffffffffffff)
discard_entry();
Decoding
--------
If the top bit in the global offset is set 1, it indicates that
the encoding formula used is above. So decoding would look like:
hi_mask = (0xffffffffffffffff << n)
low_mask = ~(hi_mask)
d_off_brick = (global_d_off & hi_mask & 0x7fffffffffffffff)
brick_id = global_d_off & low_mask
If "losing" the low n bits in this decoding of d_off_brick looks
"scary", we need to realize that till recently EXT4 used to only
return what can now be expressed as (d_off_global >> 32). The extra
31 bits of hash added by EXT recently, only decreases the probability
of a collision, and not eliminate it completely, anyways. In a way,
the "lost" n bits are made up by decreasing the probability of
collision by sharding the files into N bricks / EXT directories
-- call it "hash hedging", if you will :-)
Thanks-to: Zach Brown <zab@redhat.com>
Change-Id: Ieba9a7071829d51860b7c131982f12e0136b9855
BUG: 838784
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4711
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 578e38abbf793580659a4e1381e38b3830068d11
Author: M S Vishwanath Bhat <vbhat@redhat.com>
Date: Thu Mar 21 18:51:57 2013 +0530
cli: Made volume top help string clear
nfs option is not applicable for read-perf and
write-perf
nfs option and brick option can not be used in
same command
Change-Id: I920ba0de011df0cc5e0adca6597aaea9372fe592
BUG: 924335
Signed-off-by: M S Vishwanath Bhat <vbhat@redhat.com>
Reviewed-on: http://review.gluster.org/4706
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 59c2313f1d6a3abd8fc7337b82ebfae65f639bde
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 27 18:56:35 2013 +0530
mgmt/glusterd: Enable write-behind in nfs
We observed that the number of write requests thus inodelks
are increasing very rapidly to thousands without write-behind
in the graph.
Change-Id: Id71c9c2b0a4c9601a4644a58a933221c62dab0c0
BUG: 928341
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4734
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b3ba82cbe6375294af4023822fd46d014d6f8d21
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Mar 26 14:15:58 2013 +0530
rpc: disable root-squash dynamically upon volume set command
Change-Id: I2ba9ca339ffbe07cb74833165a46a941225b623d
BUG: 927616
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4722
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d81809a912351309c3f0c4d45a357922f154d585
Author: Anand Avati <avati@redhat.com>
Date: Mon Mar 25 12:18:13 2013 -0700
storage/posix: honor O_SYNC and O_DSYNC sent in @flags of writev()
Historic bug - posix_writev() has been inspecting pfd->flushwrites for
performing fsync() after write, instead of @flags for O_SYNC|O_DSYNC.
pfd->flushwrites was never set anywhere and is unused completely. This
is behavior from the time before anonymous FD where open() had @wbflags
param. This is a leftover from that cleanup.
Change-Id: Id9bfe562a60db4eb3bd0a7705bdba91f2df2f3ec
BUG: 916372
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4738
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit e69bc6cdc9e0988ed4a753d1c6b0438d635a364c
Author: Anand Avati <avati@redhat.com>
Date: Mon Mar 25 20:34:43 2013 -0700
cluster/afr: fix fd leak with unsafe call_resume()
Introduce AFR_CALL_RESUME macro which cleans up frame->local, like
how AFR_STACK_UNWIND etc. do.
Therefore fix leak in afr_fsync() path.
Change-Id: I3855d8e7e84dbc44e05f507563b7f722bf9621b8
BUG: 927146
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4745
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8448bb247039385de4616ec25689151610242ee0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 28 22:26:24 2013 +0530
cluster/afr: fsync before erase xattrs in data self-heal
Added extra fsync to data self-heal code to make sure the
data reached disk before erasing the changelogs
Change-Id: I9e7e6e55cdc49de2b991705d1638946464a9d4f9
BUG: 927146
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4744
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2dc23d35b21a902accacf428cb326260d550ac77
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Mar 28 11:41:25 2013 -0400
glusterfs.spec.in: sync with fedora glusterfs.spec
add --without ufo
Change-Id: If1b77003ded537f9664fa6ad677d48d118516c64
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
BUG: 819130
Reviewed-on: http://review.gluster.org/4742
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Luis Pabon <lpabon@redhat.com>
Reviewed-by: Luis Pabon <lpabon@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fb0f1a082fc38527f2f0ad6e7182f36fbaac01b6
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Mar 28 11:29:41 2013 +0530
cluster/afr: piggyback and fsync resume changes
1) pre_op_piggyback should always be decremented.
2) Move fsync resume to just after post_op.
3) fsync stub should be created from afr's local
not from the final response.
Change-Id: I220bb532eb03bea584292f4dd2e816ad0c3e0cf7
BUG: 927146
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4741
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a614286d5e27c9aa04c235acc9865eda5ee87b87
Author: Anand Avati <avati@redhat.com>
Date: Wed Mar 27 19:55:58 2013 -0700
cluster/afr: fsync() guarantees POST-OP completion
AFR now provides a stronger guarantee that fsync() returns only
after completely finishing all the deferred/delayed POST-OP on that
open file.
To acheive this we make a stub out of the returning fsync and
register it with the "delayed" frame in afr_changelog_wake_resume().
The delayed frame, after getting woken up and finishing the POST-OP
will call_resume() the registered stub (which UNWINDs the fsync) at
the time of frame destruction.
This provides a guarantee that an application's (or FUSE) fsync()
returns only after finishing up all the previous transactions,
including delayed POST-OPs and UNLOCK.
Change-Id: Iaa955457e2f25088a144fde37ad0444277b5cf49
BUG: 927146
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4737
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 491bbb063c4c3f941c7ac4f09fde3050f1fb06e4
Author: Anand Avati <avati@redhat.com>
Date: Sun Mar 24 12:19:56 2013 -0700
cluster/afr: ensure DATA operations are made durable before POST-OP
The changelogging scheme of AFR stores information about the state
of all replicas in all replicas (in the extended attribute of the
respective files on each server) in the form of 'pending counts'
of operations (effectively "dirty flags"). These xattrs are blindly
trusted while performing self-heal, and therefore utmost care has
to be taken while updating and maintaing them.
The most critical updation is the clearing of the pending counts
corresponding to the *other* server in the changelog of a given
server. Before clearing the pending count, we need durability
guarantee of the write which was performed on the other server.
To obtain such a guarantee, it may be necessary to explicitly
introduce an fsync() phase (if the file itself wasn't already
opened with O_SYNC).
This patch introduces the detection of unstable stable writes on
a file and issues explicit fsync() on the servers before performing
the POST-OP clearing of pending flags.
Change-Id: I2171b86a74ec91e40e5877eef0a4e7379578ecf7
BUG: 927146
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4721
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3a564a9729aca145bd095bc06dfa5c9987222ebc
Author: Vijaykumar koppad <vijaykumar.koppad@gmail.com>
Date: Tue Mar 26 17:42:32 2013 +0530
libglusterfs/dict: fix infinite loop in dict_keys_join()
- missing "pairs = next" caused infinite loop
Change-Id: I9171be5bec051de6095e135d616534ab49cd4797
BUG: 905871
Signed-off-by: Vijaykumar Koppad <vijaykumar.koppad@gmail.com>
Reviewed-on: http://review.gluster.org/4723
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 46703d53887e68ee689f820230baaba8df49a425
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Feb 27 17:55:47 2013 +0530
glusterd: Removed fd leaks in glusterfs_start utility function
PROBLEM:
The FILE* associated with the pidfile was leaked if
pmap_registry_search on the brickinfo' path failed.
FIX:
Eliminates the use of the FILE* that was leaked. Uses
glusterd_is_service_running utility function in place
of the earlier attempt to check for the same.
Change-Id: I94082bd5a94b8a6340f8cc11726d3264e364efe6
BUG: 916549
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4596
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a63997d8a9aeb89d77371d7d93d8c4a7ec0d34d8
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Mar 25 08:22:16 2013 -0400
config: better (i.e. more portable) test for libxml2
Over the weekend I tried to build on MacOS X¹ and ran into the following
issues:
1) The recent change to autogen.sh to test for pkg-config falls down.
2) After removing the pkg-config test in autogen.sh, w/o pkg-config the
PKG_CHECK_MODULES macro invocation in configure[.ac] falls down. N.B.
Solaris users run into this too, even through there's a (broken)
pkg-config package that can be installed.
3) There are other problems in the code related to fuse that are beyond the
scope of this.
It seems that pkg-config is only a requirement for the definition of the
PKG_CHECK_MODULES macro used to detect libxml2. Since this seems to be
inherently unportable — at least to MacOS X and Solaris — I'd like to:
A) Change the use of the PKG_CHECK_MODULES macro to the more portable
AM_PATH_XML2 macro provided by the libxml2 package in
/usr/.../share/aclocal/libxml.m4
2) Revisit the decision to add the check for pkg-config in autogen.sh in
BZ 921817.
For now this is just an rfc. If people are agreeable I'll reenter this
change against BZ 921817.
¹Mountain Lion 10.8.3, XCode 4.6.1
Change-Id: I237b1ed8919088345b8fd943423b2a6ad289981b
BUG: 921817
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4720
Reviewed-by: Justin Clift <jclift@redhat.com>
Tested-by: Justin Clift <jclift@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b2049a4621850d6bfa513512f98f403ae7e87685
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Mar 25 00:12:52 2013 +0530
glusterd: Simplify glusterd_service_stop()
Change-Id: I396d250a3299ad1f7fce4bd14389b0c2756b6cb0
BUG: 764890
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4718
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 92c480de64f7927c1015db972ef3fbe130bfb6ed
Author: Anand Avati <avati@redhat.com>
Date: Thu Mar 21 15:09:01 2013 -0700
glusterfsd: dump the in-memory graph rather than volfile
Currently we have been printing in the logfile, the volfile
verbatim as received from the server. However we perform
pre-processing on the graph we receive from the server, like
adding ACL translator, applying --xlator-option cli params,
etc.
So print the serialized in-memory graph as the "volfile" in
the log. This can be very handy to double check if certain
--xlator-option param actually got applied or not, and in
general is showing a "truer" representation of the real graph
actually used.
Change-Id: I0221dc56e21111b48a1ee3e5fe17a5ef820dc0c6
BUG: 924504
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4708
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 9d3ecdf64ec97fd0fcc9f27692c5e2e81e0877b7
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Mar 12 17:03:53 2013 +0530
mount: Added the xlator-option to mount.glusterfs script.
Now all xlator-options can be set from the mount command as well.
Example :
mount -t glusterfs Hostname:/Volume_Name Mount_Point -o "xlator-option=xyz=123, xlator-option=abc=999"
Change-Id: If52d994986839d1c969e3e2e01b2e1a29a3140b7
BUG: 920583
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4660
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ebea1d490a559587049adb6a6211ac1f6cbf062d
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Mar 20 23:01:39 2013 +0530
glusterfsd: Fixed fd leak due to use of tmpfile()
Change-Id: I3c2dc070ebe967100170e39f3545acacc6016d61
BUG: 924075
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4703
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 61a8ec2a4f34cba0f24381636dd32d14c4dcd80e
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Mar 20 18:48:12 2013 +0100
glusterd: Improve error logging when a brick from an old volume gets re-used
The error message when creating a volume that contains a brick with
certain xatts set on a parent directory is unclear.
Users do not understand '... or a prefix of it is already part of
a volume'. Most users check the final directory that is used for
a brick, but not its parents.
It would be helpful to present the user with the actual directory that
is preventing the volume to use the brick.
BUG: 923917
Change-Id: I815ad32a992eb0e41ee8fca6ee9327400d042c45
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4701
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 33f75bcc43e27814fcb31387163e3094ed9e7d79
Author: Anand Avati <avati@redhat.com>
Date: Thu Mar 21 13:46:51 2013 -0700
nfs: ACCESS - reply only what was asked for
Set only those bits which were requested by the client. Some clients,
like AIX, do not like the fact that we are returning the EXEC bit
set in the ACCESS reply even though it only asked for LOOKUP bit.
Change-Id: I3c2fd5dce030ea5ddae0511497cafa078c4d76d6
BUG: 924481
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4707
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit cd15d74c73b502128ad3fe1c08d1d07f861c0b6e
Author: Justin Clift <jclift@redhat.com>
Date: Fri Mar 22 18:44:06 2013 +0000
Added autogen.sh check for presence of tar
Change-Id: I95313699edcf7bc2696505fcb475a4a67c1800cf
BUG: 924891
Signed-off-by: Justin Clift <jclift@redhat.com>
Reviewed-on: http://review.gluster.org/4716
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 1de4d405964baa88aa4499f52a1b16ffa2b37e98
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Mar 15 02:44:19 2013 -0400
glusterfs.spec.in: sync with fedora glusterfs.spec
remove hard-coded reference to swift version and dist tarballs
minor improvements for rpm builds for regression tests, including
adding cache on build.gluster.org to avoid random failures due to
transient network or dns failures causing curl or git to fail.
BUG: 819130
Change-Id: I4f1213056ae2987dd2202f9cfbb3ed4f16ffc7cf
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4674
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Justin Clift <jclift@redhat.com>
Tested-by: Justin Clift <jclift@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c42cecdc9daf752ce0ae21adb6e697c9290583d6
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Mar 14 09:48:08 2013 +0530
socket: Make non-ssl sockets perform non-blocking connect()
Change-Id: Icb60cf7ad3ea7ca0eeb12fd19b95a6b340857bb2
BUG: 920916
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4670
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 619185859f25fa52a75712cc2febbf999ee17c60
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Mar 19 14:06:39 2013 -0400
dht: make DHT xattr names configurable
This is necessary to support "DHT over DHT" configurations, so that the
upper and lower instances of DHT don't step all over each other. Why
would we even consider such a thing? Because it gives us the ability to
do data tiering and rack-aware placement, either by themselves or as
complements to other functionality such as erasure codes or
deduplication which save space but cost performance. By setting up the
top-level DHT to place data into one of several lower-level DHT pools
based on policy instead of pure elastic hashing, we get better
performance for 90% of accesses and better storage efficiency for 90% of
data, all for relatively low effort.
Change-Id: I72e65c29edfc80babf39f7a2a00090f4588c4070
BUG: 924265
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4694
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 04ed025a8afc48d19743080742609d17c04d284c
Author: Mohammed Junaid <junaid@redhat.com>
Date: Tue Mar 19 09:29:52 2013 +0530
object-storage: Removed the redundant REMOTE_CLUSTER option.
Gluster cli uses the remote-host option to connect to the glusterd
and by default it uses localhost to connect to glusterd. So, UFO code
will use the remote-host option everytime to connect to the glusterd.
Change-Id: I5a684d3c43fe9bdc9cc0b7c472a9d8145f9e1fd4
BUG: 878663
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4690
Reviewed-by: Peter Portante <pportant@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0f4d0fc09f07a12bbc877597b5965f9e3250562c
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Thu Mar 21 16:40:16 2013 +0530
rpc-transport: fix glusterd crash when rdma.so missing
Add checks before trying to delete vol_opt from list and free
Change-Id: I2858f58518394beb8f74fa477be81d7bdd38304f
BUG: 924215
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4704
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a07ddf90ef7daa3aef1e74e9355893b41b6683d6
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Mar 7 23:22:32 2013 +0530
features/marker: log error when unlinking timestamp file
... so it's easy to figure out errno caused it. As of now
it's only due to ENOSPC. Logging is done in the error handling
routine, so any further changes that require unlinking of the
timestamp file due to some error condition(s) are logged.
Change-Id: Ia59338e2e32b2adbbd1d56aa260018270f1abae9
BUG: 853911
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/4649
Reviewed-by: Csaba Henk <csaba@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 27140aa1ff7300c4fcc807fdae544d660828ccba
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 20 08:36:14 2013 +0530
performance/io-threads: Fix range-check for least-rate-limit
The issue could be fixed with .validate=GF_OPT_VALIDATE_MIN. But
adding max value is more robust.
Change-Id: Ia69c6f86855dbd34a26e20391e77bfa0f796a200
BUG: 923573
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4698
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit faa50f3f820a2bd670f056b22ca14fd451e10961
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Mar 18 19:18:53 2013 +0530
socket: Associated IP:port information with error logs to make debugging easier
Change-Id: I4e7268f74b392c5cee8c7b8fc4bb5ab41d74dd04
BUG: 922780
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4686
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 96c803825c8d0aa48ab04f2517c7330defd471cd
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Mar 18 19:14:24 2013 +0530
rpc: before freeing the volume options object, delete it from the list
* Suppose there is an xlator option which is considered by the xlator
only if the source was built with debug mode enabled (the only example
in the current code base is run-with-valgrind option for glusterd), then
giving that option would make the process crash if the source was not
built with debug mode enabled.
Reason:
In rpc, after getting the options symbol dynamically, it was stored in the
newly allocated volume options structure and the structure's list head was
added to the xlator's volume_options list. But while freeing the structure
the list was not deleted. Thus when the list was traversed, already freed
structure was accessed leading to segfault.
Change-Id: I3e9e51dd2099e34b206199eae7ba44d9d88a86ad
BUG: 922877
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4687
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a65693759ecb53f194b7a00c34e8cca80cb8fa8f
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Mar 20 10:52:08 2013 +0530
cli: Better message on rebalance/remove-brick stop
A better message is displayed when rebalance or remove-brick is stopped,
as migration may be still in progress.
Change-Id: I5f301cc66f349a1a85245f7d7508bf746756bdea
BUG: 923529
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4695
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit cc80a91251bd11efe5b0efa56ad59af5a45fbeef
Author: Anand Avati <avati@redhat.com>
Date: Wed Feb 27 14:30:15 2013 -0800
nfs: handle stable write with @flags rather than fsync()
stable writes can be "made stable" by simply setting O_SYNC (or
O_DSYNC, accordingly) in the write flags or fd->flags. Performing
fsync() at the end of the write is extremely inefficient and completely
messes up eager-locking logic in AFR.
Change-Id: I4d954c133641e246b2ab4df874bad0282667561f
BUG: 916372
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4591
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit da4581e2d9fedaa16ab35fcb8b727e90a2e725ab
Author: Prashanth Pai <nullpai@gmail.com>
Date: Fri Feb 22 15:52:29 2013 +0530
iobuf: Added a function iobref_clear
Original-author: Venky Shankar <vshankar@redhat.com>
Change-Id: Ibf861db6c1b084b798d210962344487a1919aad2
BUG: 921942
Signed-off-by: Prashanth Pai <nullpai@gmail.com>
Reviewed-on: http://review.gluster.org/4595
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7e33cb817c73fde5445ea7ebc3b5edf762327fec
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Mar 20 11:39:01 2013 +0530
nfs, afr: Fail lookup only on split-brain
Change-Id: Icee9772f1f1bf5336eb82a4dc13e198424cd4a65
BUG: 921996
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4699
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d141aaa8c2ae68e3cfa0833526812ecbc894d2ff
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Mon Mar 18 17:13:51 2013 +0530
rpc: For AF_UNIX sockets, do not set keepalive option.
Change-Id: I65df52e89fe7783ff00c2b7a49be571d15e8f0d0
BUG: 920009
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4684
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 74885640f1b7cea49dfe06704bfa1249d9a7444f
Author: JulesWang <w.jq0722@gmail.com>
Date: Mon Mar 18 10:06:06 2013 +0800
dht: fix a typo
Change-Id: Id6f156957e58aad06bf2602f880c7e4102b80fd1
BUG: 764890
Signed-off-by: JulesWang <w.jq0722@gmail.com>
Reviewed-on: http://review.gluster.org/4679
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0b111c080118f7de345898b4cd96270411d919cf
Author: Justin Clift <jclift@redhat.com>
Date: Fri Mar 15 02:20:42 2013 +0000
Warn on missing pkg-config, plus trivial comparator typo fix.
Change-Id: I68eef93ee70a934feb9a53cca050b81a4e66e26c
BUG: 921817
Signed-off-by: Justin Clift <jclift@redhat.com>
Reviewed-on: http://review.gluster.org/4672
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 979cf056dbe020664e65aa30b7d5a3fd4b64fbfe
Author: shishir gowda <sgowda@redhat.com>
Date: Thu Mar 14 13:02:29 2013 +0530
posix-acl: disable permission checks for fd based ops
Signed-off-by: shishir gowda <sgowda@redhat.com>
Change-Id: I9d49537c2c7b51d5598b80627d61f060aaec8549
BUG: 921437
Reviewed-on: http://review.gluster.org/4671
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5d751bb523e2ea71526e649dccd4b4947d6e280b
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Feb 28 04:18:41 2013 +0100
geo-rep: retire old style ssh setup
Users are still using geo-rep with the old, deprecated, insecure, unsupported
ssh setup. Not their fault -- the implementation of the new method had the
following charasteristics:
- old method is possible, but with default settings it's not working
- it can be made operational by fiddling with "remote-gsyncd" tunable
- with default setting, an unhelpful, actually misleading error message is
produced
- the UI gave no hint to the changes in the ssh setup
http://review.gluster.org/4392 tried to fix these; what it accomplished was
unrestricted support to the bad practice (by making the default old setup
operational).
From this on:
- we disable the old method by reserving the "remote-gsyncd" tunable
- if the old method is attempted, give a hint what to do
Change-Id: Icade94725d8d8d2d4c89cab992d4226351637b86
BUG: 895656
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/4602
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6936fdb1904f15f72426852bfe108b16b784b46b
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Mar 13 01:05:54 2013 -0400
Renamed TMP_MAX to GF_TMP_MAX to avoid namespace clash on OSX.
(Just moving things along. I don't mean to step on any toes, but wasn't
sure if I had confused things with my previous review comment.)
Change-Id: I095abf751ef952ba6e225305ec5c2afc5e62ee95
BUG: 919953
Signed-off-by: Justin Clift <jclift@redhat.com>
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4654
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit cbd7b8aee0fe0b06234060f143761a209f8b0729
Author: Justin Clift <jclift@redhat.com>
Date: Sat Mar 9 16:27:31 2013 +1100
Fix improperly quoted PKG_CHECK_MODULES parameters.
Change-Id: I11765fd1a25058b84fc32249ea745abefbade3f9
BUG: 920372
Signed-off-by: Justin Clift <jclift@redhat.com>
Reviewed-on: http://review.gluster.org/4652
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c116a537fd837ef807c2d774bdd4628d61251a24
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Mar 5 17:43:26 2013 +0530
Storage/posix: Don't log at ERROR level for failed getxattr.
Problem:
ENOATTR returned by
getxattr -n <NotAnExistingAttribute> <file>
was being logged at ERROR level.
Solution:
Moved logging to DEBUG level.
Change-Id: I982a577a4c231faa958ea71abdb272f8d5ffd70c
BUG: 918052
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/4628
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 38204990db405ab47384f0822df651dbf387f56d
Author: Justin Clift <jclift@redhat.com>
Date: Sun Mar 10 21:35:54 2013 +0000
Add missing pthread.h include to logging.h
Change-Id: I986b3e978616510ed92903e192222be513297284
BUG: 920369
Signed-off-by: Justin Clift <jclift@redhat.com>
Reviewed-on: http://review.gluster.org/4653
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 690a9f776d53a8a43f55bc7dbeebe99727ec4e94
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Mar 8 15:20:22 2013 +0530
cluster/afr: Preserve mtime in self-heal
Problem:
Data self-heal may choose sink iatt to set mtimes.
This happens because after syncing of data is done
self-heal does one more xattrops/fstat to determine
sources sinks to set the inode-ctx. Since this is done
after data syncing and erase of xattrs, old source and
old sink are now sources, but the mtimes of them differ.
Old code just takes the first source from the list and
update mtimes, which could be sink before the self-heal
started.
Fix:
Set mtime from 'sources before syncing'.
Change-Id: Id769e1b99aa4f041eaee775f64cbf2c57b799723
BUG: 918437
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4658
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 66ad9d0dc0368f9ecf852abad33b95852dc2f908
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Feb 19 12:11:57 2013 +0530
glusterd: Mark vol as deleted by renaming voldir before cleaning up the store
PROBLEM:
During 'volume delete', when glusterd fails to erase all information
about a volume from the backend store (for instance because rmdir()
failed on non-empty directories), not only does volume delete fail on
that node, but also subsequent attempts to restart glusterd fail
because the volume store is left in an inconsistent state.
FIX:
Rename the volume directory path to a new location
<working-dir>/trash/<volume-id>.deleted, and then go on to clean up its
contents. The volume is considered deleted once rename() succeeds,
irrespective of whether the cleanup succeeds or not.
Change-Id: Iaf18e1684f0b101808bd5e1cd53a5d55790541a8
BUG: 889630
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4639
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 19cf9cde48a60bbb59bc405bf4e7092d14c9c668
Author: Varun Shastry <vshastry@redhat.com>
Date: Fri Mar 8 15:27:57 2013 +0530
features/quota: regression tests on general functionality of quota
Change-Id: Ie8fd9d21f3a8644ce4d6f6cb887c101451cec10c
BUG: 919998
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/4657
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6443f295d72c4af442627988e7f6d8d46ded7808
Author: Justin Clift <jclift@redhat.com>
Date: Fri Mar 8 19:29:33 2013 +0000
Add autogen.sh dependency checks and nicer output.
Change-Id: I5c740d81765559fae022d0ab9dfe34988e46612e
BUG: 919898
Signed-off-by: Justin Clift <jclift@redhat.com>
Reviewed-on: http://review.gluster.org/4651
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b2ba95aaa66d341e45d23980e1c210ceeaf37df6
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Mar 5 14:11:02 2013 +0530
glusterd: Fixed volume-sync in synctask codepath.
Change-Id: I2911d3ac80825310f84c5ba6bd7890e65e1ee219
BUG: 865700
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4624
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a951d2c0d9e56e994d0c452de43802450e27fbd1
Author: Lalatendu Mohanty <lmohanty@redhat.com>
Date: Fri Mar 8 15:27:42 2013 +0530
tests:Adding remove-brick test to volume.t
Change-Id: Ibef0c151ef6518136cd5f4c39ec5e89f06ff4133
BUG: 764966
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/4650
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 55e0de49893dfd6419d30dc89752a2f3922dd5a7
Author: Lars Ellenberg <lars@linbit.com>
Date: Sat Mar 2 00:59:15 2013 +0100
glusterd: fix segfault on volume status detail
If for some reason glusterd_get_brick_root() fails,
it frees the gf_strdup'ed *mount_point in its own error path,
and returns -1.
Unfortunately it already had assigned that pointer value
to the output argument, the caller function
glusterd_add_brick_detail() sees a non-NULL pointer,
and free() again: segfault.
Could be fixed with a one-liner (*mount_point = NULL)
in the error path, but I think glusterd_get_brick_root()
should only assign to the output argument once all checks passed,
so I use a local temporary pointer, which increases the patch a bit.
Change-Id: I3f3035f01e80a5e9bdf2da895e4cf7baa3dfbd2f
BUG: 919352
Signed-off-by: Lars Ellenberg <lars@linbit.com>
Reviewed-on: http://review.gluster.org/4646
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b7b4a308205eee2751d509304f3b40a625f75f42
Author: shishir gowda <sgowda@redhat.com>
Date: Thu Mar 7 19:41:33 2013 +0530
cluster/distribute: Fix layout overlaps due to spread-count in selfheal path
We needed to zero out the layout range, before we re-calculate the range.
When spread-count is issued, we would end up with stale ranges in the layout.
Replaced dht_selfheal_dir_xattr with dht_fix_dir_xattr, which correctly resets
the un-used (after re-cal) layouts.
Change-Id: I1a900d15df07335f59356bd23182ccec34381ab2
BUG: 884455
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4647
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit cd98787a71e0e13cfe4159342d13bcae1b47edb0
Author: Anand Avati <avati@redhat.com>
Date: Mon Mar 4 13:22:25 2013 -0800
gfapi: dict_unref() xattr_req in fop finish instead of dict_destroy()
The current way of calling dict_destroy() at the end of an API fop assumes
that xattr_req is not stored/ref'd by any translators in the stack. However
when translators like DHT store xattr_req in dht_local_t with a dict_ref()
and perform dict_unref() in the unwind path, things get subject to a race.
The race is between the woken up thread (by syncop_wake) i.e, the gfapi
invoking thread and the thread where the FOP was unwound. As the C stack
of STACK_UNWIND unwinds back, dht_local_unref() gets invoked within the
DHT_STACK_UNWIND macro. This thread attempts dict_unref, which would
be "safe" if it wins the race against the gfapi invoking thread. However
if the gfapi invoking thread wins the race, it will perform dict_destroy()
first and therefore make dict_unref() within dht_local_unref perform
a double free.
This is the embarrassing on-screen bug which showed up in a roomful of people
during the gluster dev summit demo of qemu/libgfapi integration.
Change-Id: I284c93de87cdc128d5801f42c84aa87f753090d4
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4644
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit df5132d67a13e638cba872626465202c6021f7fa
Author: Mohammed Junaid <junaid@redhat.com>
Date: Sun Feb 10 02:10:25 2013 +0530
object-storage: Fixing the errors and warnings in unittest.
Change-Id: Id22c968aefd82c4b62445b3ecc93cbabc2b35ffc
BUG: 887301
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4394
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Peter Portante <pportant@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f168224917fa125d85e0b8802d75f9a4090316a8
Author: Mohammed Junaid <junaid@redhat.com>
Date: Thu Feb 7 07:42:34 2013 +0530
object-storage: Restoring multi volume support in UFO.
* Currently, the users of UFO are restricted to use just one volume
at any given point of time. This patch removes this limitation.
* The usage of gluster-swift-gen-builders has also changed. With this
commit the users should mention the list of volumes that they want
to expose through UFO. So, only the volumes mentioned during the
ring file generation can be accessed.
Usage: gluster-swift-gen-builders <vol-name1> [<vol-name2>]...
This is an intermediate fix until we remove the account, container and
object server processes. Once we have this frame work running, it will
completely eliminate the ring files.
Change-Id: I9ad3808519fec9c7c60ad846c4f8b653117a8337
BUG: 909053
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4485
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Peter Portante <pportant@redhat.com>
commit 7dba656541345a828ce27286ed966e98a1c2239d
Author: Mohammed Junaid <junaid@redhat.com>
Date: Wed Mar 6 14:04:51 2013 +0530
storage/posix: Remove a redundant lstat in posix_handle_hard.
Change-Id: I9129b71d5568eff3513c17e3607256783fdc42ec
BUG: 903396
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4641
Reviewed-by: Peter Portante <pportant@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 51ae6db3ca5e7fa52089724439b42f445cca4b75
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Fri Mar 1 14:49:57 2013 +0530
nlm: use appropriate open flags while locking
In case of a shared/read lock, open the file in O_RDONLY
mode, and in the case of an exclusive lock, open the file
in O_WRONLY mode to emulate the behaviour posix fcntl
implementation as given in the man pages.
Change-Id: Ib9eab6570c3bc65f8bd48a14a9d801616213b295
BUG: 916930
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4603
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 05213627cb8b6180300048b14d74862fdbaf03aa
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Mar 4 11:44:40 2013 +0100
rpm: package /var/run/gluster so that statedumps can be created
Creating statedumps fail when /var/run/gluster does not exist. This
directory should be part of the 'glusterfs' package that is installed on
storage servers and native clients.
BUG: 917561
Change-Id: Ibbc1e4016469fab3db0423337fabc4ba5a8302ab
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4616
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a2185cd9839625bb198bac3c1c0a74c19476a16d
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Mar 1 09:55:44 2013 +0100
cluster xlators: s/-1/GF_CLIENT_PID_GSYNCD/
Change-Id: I03be3cb23684de4ab36cf2953002708466edd580
BUG: 765433
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/4601
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4fbaaeca9a4a8d938be030f909b52df129bd5b05
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Feb 26 12:39:17 2013 +0530
glusterd: Added description for nfs.transport-type option in volume set help.
Change-Id: I9fe81dc1c3172158e8dd86c4fa2a04af18cb9dde
BUG: 782285
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4582
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7e0f6102598146d82eb78c0d7d1fb985f6652f05
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Feb 26 11:37:30 2013 +0530
Modified validation parameters for owner-uid and owner-gid.
owner-uid and owner-gid will not receive negative values anymore.
Change-Id: I82741d3d01b29e448294b2ec093fb70d22a5c77e
BUG: 912297
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4581
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 23d75c720f6af07691f13cd80594968bec292e8f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 27 18:36:32 2013 +0530
cluster/afr: Turn on eager-lock for fd DATA transactions
Problem:
With the present implementation, eager-lock is issued for
any fd fop. eager-lock is being transferred to metadata
transactions. But the lk-owner is set to local->fd address
only for DATA transactions, but for METADATA transactions
it is frame->root. Because of this unlock on the eager-lock fails
and rebalance hangs.
Fix:
Enable eager-lock for fd DATA transactions
Change-Id: If30df7486a0b2f5e4150d3259d1261f81473ce8a
BUG: 916226
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4588
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f4fc780ea8d41f94db7e92ef629e0d63a571bf4c
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Feb 26 18:34:53 2013 +0530
libglusterfs: avoid the logging which says the port is invalid
If the reserved ports file in proc contains just a newline, then
do not proceed with ports checking and reserving.
Change-Id: If610b0e49a97e5c22e7e2b1bb4155c9616a4612a
BUG: 762989
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4583
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 42bef35ab8ee00b38dd0d53857954a8dab9d8d56
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Feb 21 16:31:58 2013 +0530
performance/write-behind: Add test case for fd being marked bad after write failures.
Change-Id: I5a3c27be0ad77b7f2660f45977f9f1f8f34ae31c
BUG: 765473
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4560
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ccef2597ce3bdea5d7e091b62d42844d45d128ef
Author: Avra Sengupta <asengupt@redhat.com>
Date: Tue Feb 19 16:27:54 2013 +0530
glusterd: Added the validation function for subvols-per-directory
Change-Id: Ie2259023b9001311a2032792639c3093054f6750
BUG: 896431
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4552
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e9610125486cb7c23beb6b525382e0f28ddd063b
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Feb 28 10:54:36 2013 +0530
glusterd: Fix some options in vme table
Some of the options had invalid '.flags' members. In the original table
these table these were supposed to be the op-versions, but, the entries
for the below options were missing the flags field the op-version was
entered in that place.
Change-Id: I408f5a972743eb37d9a58a809e8be8cb385bced8
BUG: 903478
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4593
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 760b7b6c7db24ed1a40d198479fcd38fa5a83377
Author: shishir gowda <sgowda@redhat.com>
Date: Wed Feb 27 17:04:47 2013 +0530
cluster/distribute: Prevent spurious multiple defrag crawls
In dht_notify, we used to create a thread to start defrag
crawls after we had heard from all child subvols.
This was in-correct, as a later event, could also trigger the
crawl again(due to the fact that all subvols had responded).
The fix is to make sure, the thread is started only once after
all subvols have responded the first time
Change-Id: Ifc2978b9dc866af2395b79911eca50ab38ff9457
BUG: 916449
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4587
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a9a832de25244645c2245fd653462022cad6e495
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Feb 27 17:41:11 2013 +0100
Do not call xdr_string() with a NULL error message
It is illegal to call xdr_string() with a NULL string. Linux
just retruns false, NetBSD gets a SIGSEGV when xdr_string()
calls strlen(NULL)
BUG: 916439
Change-Id: Ia958470ada6e8e55a86d439922ec942d038f5f13
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/4589
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bbe59518df7b398994d25b778506af446ac7805a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Feb 21 15:35:18 2013 +0530
glusterd: Added validation function for stripe-block-size.
Change-Id: I050d01b01eac46550aa435da7d96a972e0393d35
BUG: 770655
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4561
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1fbb0925ea63fc15407b68a4b6103df9931c0738
Author: Anand Avati <avati@redhat.com>
Date: Wed Feb 27 12:18:59 2013 -0800
cluster/dht: print hash function munging logs in DEBUG mode
Change-Id: Ia2e6bce80710d103da9d78afdb389ea162b00686
BUG: 912564
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4590
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f0b8d344dcef21500975135e503101ab0b487bd6
Author: shishir gowda <sgowda@redhat.com>
Date: Mon Jan 7 15:50:57 2013 +0530
cluster/distribute: Add filter to support file patterns to be migrated
'gluster volume rebalance' command will be enhanced to support passing of these
options/pattern.
<pattern> is comma separated list as show below. The Precedence is from right
to left.
e.g- "*avi,*pdf:10MB,*:1KB"
The precedence is as follows:
migrate all files with size equal or greater than 1KB "*:1KB"
migrate all pdf files with size equal or greater than 10MB "*pdf:10MB"
migrate all avi files "*avi"
With this option, it is possible to choose which files to migrate.
Change-Id: I6d6d6a015bcbacf1debae2f278a2d92306fb055d
BUG: 896456
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4366
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4c90f84e1ac278d7b790d9712494b13f2098cc7a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 27 14:21:04 2013 +0530
mgmt/glusterd: Move found-brick logs to DEBUG
Change-Id: I1c311c21d7bdcad4956d3428bda39131c331cd7a
BUG: 812356
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4585
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c91452c1feb3509022c21584c14f79fb49bb1096
Author: Vijay Bellur <vbellur@redhat.com>
Date: Thu Dec 6 12:17:02 2012 +0530
nfs/server: Fix multiple crashes in acl handling code.
Change-Id: I9b39a485c8b98d9eabe6153487f4dfbd26f8af13
BUG: 915280
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4578
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5c2c780521e854a73cd91e0b81c5819a32769a8e
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Feb 24 23:45:19 2013 +0530
mgmt/glusterd: Expose error-gen options through volume set.
Change-Id: I7c696d99b43544923fb96d177229cdbac32c09fe
BUG: 915280
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4577
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2a8697d217c26a6bfc94d14f3337c3b4ebd0394c
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Feb 24 23:05:59 2013 +0530
debug/error-gen: Add support for reconfiguring options.
Change-Id: Ia10dc29e8608b02037b08e32a72766b6d43a98ba
BUG: 915280
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4576
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit c816c74209b67478cb60ec96f07acb7e738d8591
Author: Anand Avati <avati@redhat.com>
Date: Thu Feb 21 18:49:43 2013 -0800
tests/cluster.rc: support for virtual multi-server glusterd tests
Since http://review.gluster.org/4556 glusterd is capable of running
many instances of itself on a single system. This patch exploits
that feature and enhances the regression test framework to expose
handy primitives so that test cases may be written to test glusterd
in a cluster.
Usage:
1. Include "$(dirname)/../cluster.rc" to get access to the extensions
2. Call launch_cluster $N where $N is the count of virtual servers
Calling launch_cluster, starts $N glusterds which bind to $N different
IPs and dynamically defines these primitives:
- Variables $H1 .. $Hn assigned to hostnames of each "server".
- Variables $CLI_1 .. $CLI_n assigned as commands to run CLI commands
on the corresponding N'th server.
- Variables $B1 .. $Bn assigned to the backend directories on each
"server".
- Function kill_glusterd, which accepts a parameter - index number of
glusterd to be killed.
- Variables $glusterd_1 .. $glusterd_n assigned to the command lines
to restart the corresponding glusterd, if it was previously killed.
The current set of primitives and functions were implemented with the goal
of satisfying ./tests/bugs/bug-913555.t. The API will be made richer as
we add more cluster test cases
Change-Id: Ieb13ed9f4a72ac0321db0ca0844c7b294145bb32
BUG: 913555
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4566
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit f8d85503fd3627993f9288d17855bb4a59ac465c
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Feb 20 14:44:23 2013 +0530
glusterd: Increasing throughput of synctask based mgmt ops.
Change-Id: Ibd963f78707b157fc4c9729aa87206cfd5ecfe81
BUG: 913662
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4570
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ed3ef593694d4ea443cd574485ab537612a7f075
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Feb 25 17:05:49 2013 +0530
volgen: Use bind-address option for bricks when option set on glusterd
Brick processes listen on all the interfaces on a given port.
When multiple glusterds run on one machine, glusterd assumes
that it 'owns' the ports on that machine. This can lead to the
different glusterd instances to step on each other's ports.
This fix ensures that brick processes listen only on the its
host IP when glusterd has bind-address option set.
Change-Id: I4c1b05643c64d3098bf56e977e768e611ffce0f5
BUG: 913662
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4580
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 7d7ab18bde933ca4050d2c71c7f312466bf31390
Author: shishir gowda <sgowda@redhat.com>
Date: Mon Feb 25 10:02:15 2013 +0530
cluster/distribute: Preserve file size during rebalance migration
If holes are encountered, then we do not write these to the dst,
which sometimes causes file size to be lesser than src. Data is not
corrupted, as when non-zero reads are received, we do write that data.
Calling a truncrate to give file size to prevent it from being
truncated to less than src in case the file end has holes.
Thanks to Brian Foster for providing the test case
Change-Id: I3cdd143b63ec8d797273d76189dff8b05eb9e551
BUG: 915554
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4574
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e920cfbd53b57dc443861802e73bc1cb3f59c766
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Feb 25 16:38:34 2013 +0530
libglusterfs: Fixed valid_ipv4_address and valid_host_name
In valid_ipv4_address(), strtok_r was ignoring consecutive dots,
and was marking any address with consecutive dots as valid. Now
such addresses will be marked as invalid.
In valid_host_name(), any name ending with any special characters
was marked as valid. Now such hostnames will be marked as invalid.
Change-Id: If9b625d9040a14bde8c176fe36e337cb483e284a
BUG: 822830
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4579
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit da982567447a46b8fdf5a57aad3338f826046702
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 20 09:53:41 2013 +0530
cluster/afr: Don't queue transactions during open-fd fix
Before Anonymous fds are available, afr had to queue up
transactions if the file is not opened on one of its
subvolumes. This happens until the attempt to open the
file either succeeds or fails. These attempts happen
until the file is successfully opened on the subvolume.
Now client xlator uses anonymous fds to perform the fops
if the fd used for the fop is not 'opened'.
Fops will be successful even when the file is not opened
so there is no need to queue up the transactions anymore in afr.
Open is attempted on the subvolume where it is not
opened independent of the fop.
Change-Id: Id1a4b4ebe6f89f9efe8f6a8247918b91247d0819
BUG: 913051
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4568
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f58d7e6bb7ac66348fbba316adbfaba281a361a1
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Feb 21 12:37:26 2013 +0530
glusterd: Added validation function for quota-timeout.
Change-Id: I7f82f4217a41e0fe41272e6ef82925e1fe97fcd5
BUG: 765230
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4557
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7cfdc46647021408939ef411645dcb84d57a8c81
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Feb 21 16:29:43 2013 +0530
tests: move common funtion definitions to include.rc
Change-Id: I3526557d0a675692e94edb71b7d92c9202e6afa4
BUG: 765473
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4559
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 87beb5571f188f4cd514de6b4ac96ac5f5bce32a
Author: Anand Avati <avati@redhat.com>
Date: Thu Feb 21 16:42:17 2013 -0800
tests/fileio.rc: library for file descriptor based IO in tests
There are situations in test scripts where we want to keep open file
descriptors while performing other commands. Bash has abilities
to manage file descriptors by numbers, but the syntax is a little
brain damaging.
This library provides wrappers around it to abstract away bash's
syntax and also provides a helper function to pick a free file
descriptor on the fly.
The APIs are pretty self explanatory.
Change-Id: I82f1d1957646dd6c468d9e85c90ec30c978c7ad6
BUG: 764966
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4565
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 354853bf476d28f2b43e8df4f15b691d780fbfc2
Author: Anand Avati <avati@redhat.com>
Date: Thu Feb 21 00:17:26 2013 -0800
synctask: support for (assymetric) counted barriers
This patch introduces a new set of primitives:
- synctask_barrier_init (stub)
- synctask_barrier_waitfor (stub, count)
- synctask_barrier_wake (stub)
Unlike pthread_barrier_t, this barrier has an explicit notion of
"waiter" and "waker". The "waiter" waits for @count number of
"wakers" to call synctask_barrier_wake() before returning. The
wait performed by the waiter via synctask_barrier_waitfor() is
co-operative in nature and yields the thread for scheduling other
synctasks in the mean time.
Intended use case:
Eliminate excessive serialization in glusterd and allow for
concurrent RPC transactions.
Code which are currently in this format:
---old---
list_for_each_entry (peerinfo, peers, op_peers_list) {
...
GD_SYNCOP (peerinfo->rpc, stub, rpc_cbk, ...);
}
...
int rpc_cbk (rpc, stub, ...)
{
...
__wake (stub);
}
---old---
Can be restructred into the format:
---new---
synctask_barrier_init (stub);
{
list_for_each_entry (peerinfo, peers, op_peers_list) {
...
rpc_submit (peerinfo->rpc, stub, rpc_cbk, ...);
count++;
}
}
synctask_barrier_wait (stub, count);
...
int rpc_cbk (rpc, stub, ...)
{
...
synctask_barrier_wake (stub);
}
---new---
In the above structure, from the synctask's point of view, the region
between synctask_barrier_init() and synctask_barrier_wait() are spawning
off asynchronous "threads" (or RPC) and keep count of how many such
threads have been spawned. Each of those threads are expected to make
one call to synctask_barrier_wake(). The call to synctask_barrier_wait()
makes the synctask thread co-operatively wait/sleep till @count such threads
call their wake function.
This way, the synctask thread retains the "synchronous" flow in the code,
yet at the same time allows for asynchronous "threads" to acheive parallelism
over RPC.
Change-Id: Ie037f99b2d306b71e63e3a56353daec06fb0bf41
BUG: 913662
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4558
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 4319d6fd1a96168240140330de1b7203a8ab4e9b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Feb 20 14:11:36 2013 -0500
glusterd: allow multiple instances of glusterd on one machine
This is needed to support automated testing of cluster-communication
features such as probing and quorum. In order to use this, you need to
do the following preparatory steps.
* Copy /var/lib/glusterd to another directory for each virtual host
* Ensure that each virtual host has a different UUID in its glusterd.info
Now you can start each copy of glusterd with the following xlator-options.
* management.transport.socket.bind-address=$ip_address
* management.working-directory=$unique_working_directory
You can use 127.x.y.z addresses for binding without needing to assign
them to interfaces explicitly. Note that you must use addresses, not
names, because of some stuff in the socket code that's not worth fixing
just for this usage, but after that you can use names in /etc/hosts
instead.
At this point you can issue CLI commands to a specific glusterd using
the --remote-host option. So far probe, volume create/start/stop,
mount, and basic I/O all seem to work as expected with multiple
instances.
Change-Id: I1beabb44cff8763d2774bc208b2ffcda27c1a550
BUG: 913555
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4556
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 414b798b5400be385f887bb258fd7f68ebd5c8b3
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Feb 21 16:22:38 2013 +0530
glusterd: use gf_strdup() in place of strdup()
Change-Id: Idee71019dbc6eeaa0a808d671b29d6f3038a1a89
BUG: 913487
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4562
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cb2ad9b2349b1f86c28bb1058c92f90f1c69eeab
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Feb 21 18:27:10 2013 +0530
call-stub: remove fall-through in ftruncate
Change-Id: I58bf6b881ff63d627051bef1ab30bd0337ab65e2
BUG: 913544
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4564
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 3fd271e75727038d3c8b40e2ad1e20e1c2f11bd3
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Feb 20 15:26:02 2013 +0530
syncop: Fixed indentation and whitespaces.
Change-Id: I90e496b5d5027ac702ab3804ba52f26d537812a0
BUG: 764890
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4554
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4e489741a1f2cca4a8ec9381bca3a8f5c9d84310
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Feb 20 13:27:33 2013 +0530
testcase for the open-behind xlator when open fails
Test if the fops which are put into a stub and are waiting for
the open to complete should be unwound with the error if open
call itself fails.
Change-Id: I8c363d98303a7df1a0ca9ea6ef207c7123fdd388
BUG: 846240
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4553
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit f0e40473e83ba83d6302567d8f41515d865eb08e
Author: Anand Avati <avati@redhat.com>
Date: Tue Feb 19 21:14:23 2013 -0800
performance/write-behind: guarantee non-overlapping concurrent writes
Maintain a list of writes (either written behind or SYNC) which are
currently "in progress" (i.e, STACK_WIND'ed towards server) and hold
off any new STACK_WIND of write (either written behind or SYNC) which
overlaps with any of the "in progress" writes.
This is a guarantee which AFR's eager-lock depends upon (though not
strictly a write-behind requirement)
Change-Id: Icedd0b51b440366a906dc9223d62b7fd6ef2ca03
BUG: 857673
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4551
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
commit 793114a76b1cce21ac8f7c7b11b2c1d1309d17ea
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Tue Feb 19 22:56:22 2013 +0530
cli: Display option 'device vg' only when bd backend enabled
Change-Id: If61c237948f51d48305f4897b3f226eead10bae8
BUG: 912997
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/4555
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 851e7c7fda723eba82b73165c61b3b34becfede2
Author: Anand Avati <avati@redhat.com>
Date: Sun Feb 17 16:36:50 2013 -0800
read-ahead: re-enable support for variable page size
Support for variable size page-size was disabled with the introduction
of fixed size iobufs. Since the introduction of variable sized iobufs
there is no reason to not have configurable page-size in read-ahead.
This patch enables necessary changes in the translator for configurable
page-size.
Change-Id: I677d70fef50641eb041269aca92a088b9d4961cc
BUG: 764204
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4526
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
commit 6cc10463baef920c386be7d5ff00a58b6397642f
Author: Anand Avati <avati@redhat.com>
Date: Fri Feb 15 17:30:56 2013 -0800
open-behind: propagate errors from ob_wake_cbk
If opening fd in background fails, then remember the error and
fail all further calls on the fd.
Use the newly introduced call_unwind_error() function from
call-stub cleanup to fail the future calls.
Change-Id: I3b09b7969c98d915abd56590a2777ce833b81813
BUG: 846240
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4521
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit dcc194f1292a1603dc2166ba423fbf023066fefd
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Feb 7 13:50:06 2013 +0530
glusterd: log changes in volume set and volume reset codepath
Change-Id: Ieed9194768e434e54ea7d3d42b705eb600445cf4
BUG: 812356
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4543
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9b84b762c9f926c4503bda97a9ec6bc4b41df3a4
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Feb 18 16:41:46 2013 +0530
glusterd: Added validation function for performance cache max and min size.
Change-Id: I0b8dbc4b65412b8aff24873f030c03e3dcfcb988
BUG: 782095
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4541
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4883821dadc79f296e30c4092b9e225c7e7005b2
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Feb 11 11:53:36 2013 +0530
glusterd: Made gd_synctask_begin less 'monolithic' in terms of LOC.
Change-Id: I2dcaea56c2ca2c2c42c046ab7d2a39d586307868
BUG: 852147
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4507
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2af597001a5b42ece1384950dc730eae4a4e97ed
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Feb 19 15:42:28 2013 +0530
code cleanup: remove unused parameter 'dict'
Change-Id: Id5c23a0cedf695eb9c25bc793cea3cf0a13f61c4
BUG: 764890
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4544
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c1c85b8ac71dbfbe2f41b40e73711c9a39112e3f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Feb 19 16:05:45 2013 +0530
dht: Enable mem-accounting for nufa
Change-Id: I0cf8a59c81e30603aadc45393bbd49d80ae1621f
BUG: 912657
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4542
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit af1f79f05a20cb1a53ae0e44a476e4986b2fed22
Author: Varun Shastry <vshastry@redhat.com>
Date: Wed Feb 13 18:00:04 2013 +0530
features/quota: Add option to consider the quota limit in statfs estimation
Adds an option, features.quota-deem-statfs (default off) to consider the
quota limits while calculating the volume stats.
Eg: Backend is of size 10GB and limit set on / is 5GB. If the option is off
df show actual size to be 10GB and when it is on df shows 5GB.
Change-Id: Ib30733bb69afecce1dea9d0491af89d551d214cc
BUG: 905425
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/4511
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 87825b1d2157e111ead99491e415777ce1882ade
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Feb 19 15:35:17 2013 +0530
Tests: Disable open-behind
Test assumes that open on the mount point opens the files on bricks
right away.
Change-Id: I94aae857515792e9b694723d30bb085f9e703745
BUG: 821056
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4540
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit da6a35afb88a6460c95be113faa3175d935d0c1b
Author: Anand Avati <avati@redhat.com>
Date: Fri Feb 15 17:14:50 2013 -0800
call-stub: internal refactor
- re-structure members of call_stub_t with new simpler layout
- easier to inspect call_stub_t contents in gdb now
- fix a bunch of double unrefs and double frees in cbk stub
- change all STACK_UNWIND to STACK_UNWIND_STRICT and thereby fixed
a lot of bad params
- implement new API call_unwind_error() which can even be called on
fop_XXX_stub(), and not necessarily fop_XXX_cbk_stub()
Change-Id: Idf979f14d46256af0afb9658915cc79de157b2d7
BUG: 846240
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4520
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 9b7220bc5b396e7f67f1e79b3d70c0c77002d3a5
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Feb 19 12:37:04 2013 +0530
performance/open-behind: use anonymous fd for doing fstat and readv
Change-Id: I61a3c221e0a15736ab6315e2538c03dac27480a5
BUG: 846240
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4483
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6602b29323fc89480739d15d0d070a57d0bd4de1
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Feb 19 13:22:25 2013 +0530
cluster/afr: do complete split-brain check in all the fd based fops
fd based operations such as readv checked only for data split brain
instead of complete split-brain (i.e both data + metadata) assuming that
open would have done the complete split-brain check. However open-behind
would have unwound open, without winding to afr thus preventing the complete
split-brain check and some appliations will be able to read the contents
of the file even though the file has metadata split-brain. So let all
the fd based fops do a defensive check of complete split-brain.
Change-Id: Ia90b35f2b08426dfcad804b7f8105278c86fbd2d
BUG: 846240
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4548
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 96805be6325308199f17b1c4dff979ac0a2b0b14
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Feb 19 11:42:13 2013 -0500
glusterfs.spec.in: resync with Fedora glusterfs.spec
remove extraneous pwd and ls, left-overs from debugging regression
failures
BUG: 819130
Change-Id: I9bc058bbbfd78218153737751481171f21001e6e
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4547
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6cd82789167bc83d81c4702c73e008f03e4fda64
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Feb 18 14:22:07 2013 +0530
glusterd: Added option description, and validation function fields.
In volopt_map_entry table, added option description field, and
option validation function pointer.
Change-Id: I21c6bccd175970592b470ce3ef3f418cb99a5a43
BUG: 903478
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4535
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3a539d06f0c6be8830211d18acd02be0c0957be9
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Feb 19 10:55:50 2013 +0530
tests: Add spaces around '=' in a string comparision in TEST primitive
Change-Id: I0402949c8cd88cc93e073a7c8ae60b5ff4497ad2
BUG: 764966
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4538
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fbab0af0f4e85f5b3978a26b6d3ec56774230a0a
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Feb 18 13:16:39 2013 -0500
distribute: add hash-name-regex option
This is to support the common "write to temp file then rename" idiom. In our
case this causes us to create a linkfile during the rename in (N-1)/N cases,
with a significant impact on performance e.g. for UFO which uses this idiom.
This patch allows the user to specify up to two regular expressions that
separate the permanent and transient parts of a temp-file name:
rsync-hash-regex reimplements the existing RSYNC_FRIENDLY_NAME
pattern where the temporary name for EXAMPLE is .EXAMPLE.suffix
extra-hash-regex can be used for a second pattern, active concurrently,
and can include alternatives via the POSIX extended-regex syntax
Change-Id: Ic1a6ed19324bc31fefe91ee34b8478877a9c5d2c
BUG: 912564
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4116
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8cfe3ccd11ac736bec8704a0a57ceccbe2ae163d
Author: Varun Shastry <vshastry@redhat.com>
Date: Thu Jan 17 15:35:07 2013 +0530
libglusterfs: make gf_string2percent_or_bytesize to convert float numbers.
Change-Id: I0ac6588297bdb8b085c3c9b01848a098f7fd4293
BUG: 912206
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/4533
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2dd68b0ca2ead9b476f813586b081b72a4479f69
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Feb 14 12:47:54 2013 +0530
glusterd: Fix check for task-id existence in 'volume status'
This fixes the issue of task-id tests failing randomly. The condition used to
check rebalance/remove-brick was running was wrong, which could lead to the
task-id for these tasks to not be displayed even when the actual commit hadn't
occured.
Change-Id: I765daceda5b6bed1387342c15f9ea00552ac85f5
BUG: 857330
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4514
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1530a75a0745f076b9a6a9789ec13f2335804d03
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Feb 18 15:51:35 2013 +0530
rpc: change dict key for fqdn
changed the key from "client.fqdn", which could be wrongly
construed as belonging to protocol/client, to "fqdn".
Change-Id: Ib5f4a875a00b99cd903a29da19bafeb70baaab4e
BUG: 906119
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4536
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6079047572c518dd82bae4baff4334d2ef5a755e
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 15 15:34:44 2013 +0530
glusterd: Changing the volume entry table's representation.
Change-Id: Ifd3a20452cc18ec2604aa97776e705b1998be03c
BUG: 903478
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4518
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fdad28e1aca704eb3a929d0e139df91e05bdc257
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Feb 15 12:30:52 2013 +0530
performance/write-behind: mark fd bad if any written behind writes fail.
Change-Id: I515fc26c61e1ea929a3049b3001c58a64f3e6c87
BUG: 765473
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4515
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit aa5de74be1963a4385213efda0568d5e083a723a
Author: Anand Avati <avati@redhat.com>
Date: Sun Feb 17 21:46:47 2013 -0800
LinuxRPM/Makefile: fix backquote which was triggering recursive make
The following Makefile snippet:
--snip--
all:
@echo "To build RPMS run `make glusterrpms`"
--snip--
was using `backquotes` in the string, and thereby triggering a nested
make on "glusterrpms" target implicitly as part of 'make all', thus
defeating the intention.
So use single quotes instead of backquotes.
It is unexplained why this nested 'make glusterrpms' was not called on
the build server during regression test.
Change-Id: I8a8d1d4f565d03cfb27341e6183af5b09530eb60
BUG: 819130
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4532
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit fc65c630577fbbf65dd40e1c51a3de8fe1351db7
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Feb 18 10:12:30 2013 +0530
cluster/dht: improvement in rebalance logs
provide space between path and next string, so that we can grep
for the correct path in error logs.
Change-Id: Ide53e341864dce432406a58e8cbb2ff1480cfbde
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 815194
Reviewed-on: http://review.gluster.org/4531
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit ca8e1fa778034efc9a1107ec241e556dc310ca88
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Jan 30 11:29:54 2013 -0500
glusterfs.spec.in: resync with Fedora glusterfs.spec
Resync with Fedora's glusterfs.spec, being careful to preserve recent
additions to the glusterfs.spec.in such as the package-config for -devel
and the OCF sub-package
To build a set of RPMs:
% ./autogen.sh
% ./configure --enable-fusermount
% make dist
% cd extras/LinuxRPM && make glusterrpms
Updated rpm.t, hopefully build system has all the dependencies to build UFO
BUG: 819130
Change-Id: I1b1c161337ad780cf7d3ab401fa1b10648f38cbd
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4454
Reviewed-by: Peter Portante <pportant@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1e9dcbcc3b24b84c610a2e5153fc59ddb29892f1
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sat Feb 16 20:10:24 2013 +0530
libglusterfs: Fix memory leaks in fd_lk_insert_and_merge
Change-Id: I666664895fdd7c7199797796819e652557a7ac99
BUG: 834465
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4525
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fb3d23949986c89ffc5da9392d302b515ba8dbb2
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sun Feb 17 20:29:47 2013 +0530
mount.glusterfs: Introduce mem-accounting as an option
option mem-accounting enables memory accounting for the client
process.
re-factored to keep options with values and options without values
in different sections of mount.glusterfs.
Change-Id: I54ebc31a1eae6d7a5ce7b0255cd7df74d37d46c1
BUG: 834465
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4524
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ede066499b7aa0e2dd89b7fdb4bec7693f3d54dd
Author: Vijay Bellur <vbellur@redhat.com>
Date: Sat Feb 16 22:51:10 2013 +0530
Better mechanism to handle memory accounting
Memory accounting will now be enabled if:
1) Any glusterfs process is spawned with argument --mem-accounting.
2) DEBUG is defined.
Change-Id: I3345e114127a57ce61916be0e2c4e0049a4c3432
BUG: 834465
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4523
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1f6c9f396c46d7c1bf294628790a2c18d7c4746f
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Feb 7 13:57:42 2013 -0500
features: add a directory-protection translator
This is useful to find all calls that remove a file from the protected
directory, including renames and internal calls. Such calls will cause
a stack trace to be logged. There's a filter script to add the needed
translators, and then the new functionality can be invoked with one of
the following commands.
setfattr -n trusted.glusterfs.protect -v log $dir
setfattr -n trusted.glusterfs.protect -v reject $dir
setfattr -n trusted.glusterfs.protect -v anything_else $dir
The first logs calls, but still allows them. The second rejects them
with EPERM. The third turns off protection for that directory.
Change-Id: Iee4baaf8e837106be2b4099542cb7dcaae40428c
BUG: 888072
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4496
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b7e40b03831d8d0c6ad9447ad1263d0472e54e96
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Feb 8 11:44:41 2013 +0530
rpc: bring in root-squashing behavior in rpc
* requests coming in as root are converted to nfsnobody
* with open-behind some acl checks wont happen and nfsnobody
can read the file "whose owner is root and other users do not
have permission to read the file". This is becasue open-behind
does not send the open to the brick and sends success to the
application, thus the acl related tests on the file wont happen
which would have prevented the file from being opened.
Change-Id: I73afbfd904f0beb3a2ebe807b938ac2fecd4976b
BUG: 887145
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4516
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b8dfecf107b21334c6c94acb0e62e8fdcab550b4
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 8 17:20:05 2013 +0530
glusterd: Made volume-heal use synctask framework.
Change-Id: Ic6659335f18a3befcf9b8b3ca067883a2c889d03
BUG: 852147
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4493
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 54b74ff895fafa8c5e1642eae2d8e33ca05c21ca
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 8 17:31:11 2013 +0530
glusterd: Made volume-quota use synctask framework.
Change-Id: I4c275253144ed3ac11a701a56dd1116c002471ba
BUG: 852147
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4495
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e4d2f65b2e084bf9f455f1bec6be78b151a0dd30
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 15 13:04:57 2013 +0530
glusterd: Moved the volume entry table to a separate file.
Change-Id: I893f41bd505fc0e02aec1e71f7a6209759b24a89
BUG: 903478
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4517
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1c7b5a05f065c1f1619bd3051bb381384b30e9ed
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Feb 11 17:54:32 2013 +0530
glusterfsd: Remove 'top {read,write}-perf' thread
'volume top {read,write}-perf' were performed in a different thread on the brick
process, to prevent them from blocking the main polling thread. This was
essential earlier when the rpc actor functions were run in the epoll thread. Now
rpc actors can be launched on their own threads with the introduction of
synctask support for rpcsvc. The brick-op actors are now launched using this
feature, which makes the need for '{read,write}-perf' to be performed in a new
thread.
Change-Id: Idad7ab623f0bfb0c3a5cfae796c06e0fa3cff1b9
BUG: 764890
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4510
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f30cb4a87a819237e7f7d0e43e71d8d0126881b8
Author: shishir gowda <sgowda@redhat.com>
Date: Thu Feb 14 13:04:58 2013 +0530
cluster/distribute: Reopen fds in migration internally as root:root
Though linkfile_create and rebalance dst file create sent a setattr
with correct ownership, there is still a race window where the linkfile
open (client open due to migration) will fail, as its ownership will be
root:root.
Change-Id: I056092da6102319efa3bb9f1795f8c97db2a3fed
BUG: 884597
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4513
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 46e609f0281f4eb4559dc740945b0120bae0d1a9
Author: shishir gowda <sgowda@redhat.com>
Date: Wed Feb 13 13:03:10 2013 +0530
cluster/distribute: Remove suprious fd_unref call
After fix http://review.gluster.org/4282 (libglusterfsterfs/syncop: do not
hold ref on the fd in cbk) was pushed, syncop_open does not take a ref anymore.
Change-Id: I5543986a4f2d965eef42ca979b39ac75439cec49
BUG: 910661
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4509
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 50c37ba8d652aeb94bfaa583d95d005161d43ca8
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Tue Feb 12 13:10:40 2013 +0530
fuse: Change "gid-timeout" default value to 2
Originally default value was 0. Changed to 2 for
performance benefits.
Change-Id: Iaadc59cf3ef2a2eb42ff2f6624f466a544fc8074
BUG: 902348
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/4506
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9a1893f3686a295be3b03c4fc09d4170816d20eb
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Feb 6 17:04:37 2013 +0530
glusterd: Made log-rotate use synctask framework.
Change-Id: Ib305168759db6730dfa0045da99de252eb5e9469
BUG: 852147
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4478
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 91742be831c0ff05aca6ef676339186f1bae6c5b
Author: shishir gowda <sgowda@redhat.com>
Date: Mon Feb 11 22:27:29 2013 +0530
cluster/dht: Create linkfile with file uid/gid
Currently, linkfile creation happens as root.
use uid/gid returned from _cbk (link/rename) to set the correct ownership of
the link files.
Also added test/dht.rc to implement common dht functions
Change-Id: Iecdcf52d89fed8286670ce430b9d19deebd27b8c
BUG: 884597
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4304
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 26b1609134894dc88fd24b33b6a4e64340847eee
Author: Anand Avati <avati@redhat.com>
Date: Tue Dec 4 22:35:58 2012 -0800
synctask: implement setuid-like SYNCTASK_SETID()
synctasks can now call SYNCTASK_SETID(uid,gid) to set the effective
uid/gid of the frame with which the FOP will be performed.
Once called, the uid/gid is set either till the end of the synctask
or till the next call of SYNCTASK_SETID()
Change-Id: I7eb74f7c473099bcae39310d2ab353d58f8eb2ba
BUG: 884597
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4269
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
commit 8803d55cc7723f50611e5a731780446b90f01de9
Author: Mohammed Junaid <junaid@redhat.com>
Date: Sat Feb 9 04:37:28 2013 +0530
object-storage: Use the wrapper functions provided by fs_utils.py to make system calls.
The set of changes:
* Unit test cases for fs_utils.py
* Replaced os.path with os_path
* Implemented wrapper functions do_write, do_chmod, etc in fs_utils.py
* Replaced os.<sys-call> with the wrapper functions.
Change-Id: I770da878e83eda6b98e49d70193990406a2642a7
BUG: 887301
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4360
Reviewed-by: Peter Portante <pportant@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 750362f78f65afd16c06da1f073dc7bbf2e7d338
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Mon Feb 11 11:27:40 2013 +0530
Debug/io-stats: Enable INFO level in syslog
Previously we had only ERROR, WARNING and CRITICAL
levels allowed in syslog. Adding INFO level as per
user request.
Change-Id: I3276d62d12ebf4be68edf5e5b26341dc2bb4f47b
BUG: 887924
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/4499
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 829d0ff5a68ee01467a023995d6751f7117bc7ba
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 22 16:19:06 2013 +0530
Tests: Remove 'sleep' from the test case
Change-Id: Iaff2076b0ef7f69a6ba6efd4123271bde490977a
BUG: 873962
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4498
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d66aff07235cddee7afdea2086ce2b1801982158
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Feb 9 07:06:18 2013 +0530
Tests: Explicitly set eager-lock on
Change-Id: I834fd5adab6e328ed106e413fc06e4280d1d24b2
BUG: 888174
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4497
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6a310f374587d8cdd9dfde670addb9040f30da1d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Dec 27 15:57:13 2012 +0530
glusterd: harden 'volume start' staging to check for brick dirs' presence
PROBLEM:
When the brick directory of a volume is absent on any of the servers,
AND an attempt is made to start the volume, commit fails ONLY on the
node where the brick dir is absent, leading to a split-brain like
situation.
FIX:
Harden 'volume start' to check for the presence of brick directories
at the time of staging, thereby preventing commit failure.
Change-Id: I67faeb9afbd3aa76f08645924462db126bf7a977
BUG: 889996
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4365
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 95fa5019148c6a4430f542ddad468c1fff747ec0
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Sep 18 12:41:46 2012 +0530
cluster/dht: pathinfo xattr changes for directories
Since directories have presence on all subvolumes there is
no definite meaning of ->hashed_subvol or ->cached_subvol.
getxattr() code path chooses ->cached_subvol for pathinfo
extended attribute. While this makes sense of files, it makes
less sense for directories. Further if a hashed or a cached
subvolume is down, and there's a getxattr request for a
directory, we return with an errno.
This patch changes pathinfo extended attribute contents by
aggregating information from all subvolumes that are up.
Change-Id: I58adb741d63ccfd1d0239af75eb65f26f0fb384d
Signed-off-by: Venky Shankar <vshankar@redhat.com>
BUG: 856455
Reviewed-on: http://review.gluster.org/4047
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 490cf6f9fdf26d50f7d8f4ed0e8654c9fbab84e6
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jan 30 15:23:48 2013 +0530
glusterd: Made gsync set use synctask framework
Change-Id: I409fa5a9f55434ece47a8a51d4812d3eca42d269
BUG: 852147
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4473
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 35679dd9768433b3787e93caa3806c3c8572e367
Author: Avra Sengupta <asengupt@redhat.com>
Date: Mon Feb 4 16:10:57 2013 +0530
glusterd: Making volume-reset use synctask framework
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Change-Id: Ib25c8fa69d84b8132505ae3f1e67cf88d3f6f9ec
BUG: 852147
Reviewed-on: http://review.gluster.org/4474
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d293f8558665d4884f7a48a80465c603e00654d2
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 8 16:37:58 2013 +0530
glusterd : Made volume-set use synctask framework.
Change-Id: I1aa08ca843b87839180f9097bca370270a856e6d
BUG: 852147
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4488
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2f7df98451d70db0af776aeb3323abfd0a3b2b0f
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Feb 8 15:03:46 2013 +0530
tests/bugs/bug-762989.t: do not check the listening ports
Change-Id: Ifbcf28bb476ee95343beaf42fb84a1b834c9ffcb
BUG: 762989
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4486
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f775db4117dcb7fed43f33b28e1d1a8abfcb9e7d
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 8 16:46:14 2013 +0530
glusterd: Made volume-sync use synctask framework.
Change-Id: I048aac2af4d9da9ed541d3756fefefbb2a29198e
BUG: 852147
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4489
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 72f6490b3a7a46df88df9e0fd93a3515cc4a60cb
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 8 16:59:21 2013 +0530
glusterd : Made volume clear-locks use synctask framework.
Change-Id: Ia1fe3d0500d999c1f95b43c9e53947834e39d680
BUG: 852147
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4490
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8f4e67555015a4a99bd7eefec578c1d5b66f12ec
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 8 17:12:05 2013 +0530
glusterd: Made volume-stop use synctask framework.
Change-Id: I88270f70538bb89d828bb51830b54e9f59be258a
BUG: 852147
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4491
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 802d63d0bb55f1d337dde9fa325cbd6fc095a869
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 8 17:17:04 2013 +0530
glusterd: Made volume-delete use synctask framework.
Change-Id: I52573bb49946f904484e2ead483e8f6f41cbd0c8
BUG: 852147
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4492
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit dfd11f82703630a33fa0137ac1a0a603e2d6e296
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Feb 8 17:22:22 2013 +0530
glusterd: Made volume-statedump use synctask framework.
Change-Id: I230ecbd8978725070b5910ead4249f21038224a6
BUG: 852147
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4494
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cc1de6d3873bc045dffbee69a516ea6546dabc46
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Feb 8 13:05:39 2013 +0530
Tests: Fixes to state-dump gen function
Change-Id: I426e04a4e3d402639a052c6b3616157c36fefc56
BUG: 908146
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4484
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 65b3624799f7d9d20e786304b6b66eca8fad7fe2
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Thu Aug 30 11:37:24 2012 +0200
fuse: log options passed to fuse when mount fails
This is done to ease debugging.
Change-Id: I50cfca297e03f41cc47819d0700752e3d24a07d6
BUG: 852754
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/3877
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b2f28ccf4dea0b3ba50b78c8672a30a8289f4b89
Author: Joe Julian <me@joejulian.name>
Date: Fri Nov 30 14:17:31 2012 -0800
gsyncd: allow the override of the compiled-in python path
.. using the environment variable $PYTHON
Change-Id: Ieaad8be98b826c803268216826e250d9944c8190
BUG: 882127
Signed-off-by: Joe Julian <me@joejulian.name>
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4252
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 2353eca7252df3415a83b7038f59c303e82ac54e
Author: merfi <lahoucine@benlahmr.com>
Date: Sat Sep 1 20:34:09 2012 +0200
glusterfsd can't listen in a specified address
When specifying transport.socket.bind-address option,
only the glusterd daemon uses this address. But glusterfsd
still working with the default localhost address. For
instance, when we want to use an IPV6 specific address we
will want that all process use that specified address even
glusterfsd.
To handle this change we just need to replace the fixed
address “localhost” to the specified brick address
“brickinfo->hostname”
Change-Id: I540d30e6c155f71379a1cf1c0b459ac00faeb62c
BUG: 865327
Signed-off-by: Lahoucine BENLAHMR <lahoucine@benlahmr.com>
Reviewed-on: http://review.gluster.org/3889
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 70bf5893362e987dba35d44d3a7f9096ca7bfc84
Author: Kacper Kowalik (Xarthisius) <xarthisius.kk@gmail.com>
Date: Mon Sep 24 10:48:35 2012 +0200
Respect autotools docdir variable
Change-Id: If20d0806a925b880e0ba9bbc66604cae6c51ce6b
BUG: 859861
Signed-off-by: Kacper Kowalik (Xarthisius) <xarthisius.kk@gmail.com>
Reviewed-on: http://review.gluster.org/3971
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bc53942e2323eb49aac4ccfd090e322066f2ccd2
Author: Anand Avati <avati@redhat.com>
Date: Thu Feb 7 14:25:03 2013 -0800
Use proper libtool option -avoid-version instead of bogus -avoidversion
Change-Id: I1c9541058c7d07786539a3266ca125a6a15287d8
BUG: 859835
Signed-off-by: Anand Avati <avati@redhat.com>
Original-author: Kacper Kowalik (Xarthisius) <xarthisius.kk@gmail.com>
Signed-off-by: Kacper Kowalik (Xarthisius) <xarthisius.kk@gmail.com>
Reviewed-on: http://review.gluster.org/3967
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 40739459d402ebb5bdfc11b7c5822783f6bc61df
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jun 14 16:25:09 2012 -0400
Add scripts for size-weighted rebalance.
Change-Id: I04197e54fef2ff7b61fbee21ab837219354184f1
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/3573
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 09de013012aae1065afd0065f95545f1028057e5
Author: Mohammed Junaid <junaid@redhat.com>
Date: Wed Jan 23 10:03:07 2013 +0530
object-storage: Store the lock file in /var/run/swift.
* Openstack swift uses the /var/run/swift directory to store the pid files
for all the servers.
* Also, added a script that would unmount the gluster client on a volume stop.
Change-Id: Ib5b9a2964987ca7696d9a2570f1f7af8490b2168
BUG: 861497
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4417
Reviewed-by: Peter Portante <pportant@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 54506cba355afeef465db6b2679a9938ae36d199
Author: Anand Avati <avati@redhat.com>
Date: Wed Feb 6 09:03:03 2013 -0800
afr: serialize modification of {entrylk,inodelk}_lock_count
Typically this lock was not needed in practice, but with
http://review.gluster.org/3842, this code gets executed in multiple
threads for different servers and we lose a count. This results in
leaked lock and a hang for a future transaction.
Change-Id: I377ed20e44f2a45cff522289dfef181f0653eca2
BUG: 765564
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4480
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7203a62c3bdd96e879fc62cc47f3996d253bf6c8
Author: Anand Avati <avati@redhat.com>
Date: Tue Feb 5 16:04:50 2013 -0800
fuse-bridge: use READDIRPLUS support when available
This patch makes use of READDIRPLUS call when support is available
in the kernel.
Change-Id: Iac78881179567856b55af1f46594a2b2859309f0
BUG: 908128
Signed-off-by: Anand V. Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3905
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
commit 2e0d5e7e6026dcfc2abb0644b46e5134933c8a8d
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Feb 5 19:19:06 2013 -0500
dht: better layout-optimization algorithm
This method deals with the case where swapping might gain a bigger overlap
for the xlator currently under consideration, but sacrifices even more from
the xlator we're swapping with. For example:
A = 0x00000000 - 0x44444443 (new 0x00000000 - 0x55555554)
B = 0x44444444 - 0x77777776 (new 0x55555555 - 0xaaaaaaa9)
C = 0x77777777 - 0xffffffff (new 0xaaaaaaaa - 0xffffffff)
Here, the new range for B has a bigger overlap with the old C than with the
old B (0x33333333 vs. 0x22222222 to be precise) so looking only at that
might lead us to swap. However, such a swap turns the new C's overlap from
0x55555556 (vs. old C) to *zero* (vs. old B). In other words, we've gained
0x11111111 for B but lost 0x55555556 for C, so it's a bad idea.
The new algorithm accounts for all effects of the swap, so it not only avoids
bad swaps but can make some good ones that would have been missed previously.
For example, if swapping a range X with a later range Y would not increase the
overlap for X we would previously have skipped it even if the swap would
increase Y's overlap without affecting X's. This is the normal case when we're
adding a new brick (which initially has zero overlap with any old range) so
finding more good swaps is probably even more important than avoiding bad ones.
Also, the logic in dht_overlap_calc was completely broken before, causing
integer overflows instead of providing correct values, so no matter what
higher-level algorithm was in place the GIGO effect would have resulted in
bad decisions.
Change-Id: If61ed513cfcb931916c6b51da293e3efbaaf385f
BUG: 853258
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/3908
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4f939c4ff54eb5ff0c30b5249f9b175721b93b63
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Nov 19 17:21:49 2012 +0530
glusterd: synctaskize 'volume create' operation
.. and also move brickpath validation to volume create stage
Change-Id: Ia028677932ca5f6aa05dcf624f47033b62e7b212
BUG: 862834
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4213
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a4e39b10bb52af0ebde00c5131c9492b6f386f1c
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Jan 28 18:16:32 2013 +0530
rpc: get hostnames of client to allow FQDN based authentication
If FQDNs are used to authenticate clients, then from
this commit forth, the client ip(v4,6) is reverse looked up
using getnameinfo to get a hostname associated with it,
if any, thereby making FQDN-based rpc authentication possible.
Change-Id: I4c5241e7079a2560de79ca15f611e65c0b858f9b
BUG: 903553
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4439
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 97f5c33329653ef7a9fc1b10f4c208172ad6055f
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Feb 5 16:52:16 2013 +0530
nfs/nlm: use req's uid and gid for open_and_resume
Previously, NLM was setting the frame->root->{uid,gid}
to root by default. This causes permission problems with
root squashing for lock calls. Now, we obtain the uid and
gid from rpc request. And duplicate #defines are removed
from rpcsvc.h
Change-Id: I5d6c87aed8d04aab2619bb913408048c0a02d1e7
BUG: 906884
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4466
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ad4ce810eecd9f7b6227038af4802a4802bb9bb9
Author: Anand Avati <avati@redhat.com>
Date: Mon Jan 21 16:37:43 2013 -0800
open-behind: translator to perform open calls in background
This is functionality peeled out of quick-read into a separate
translator.
Fops which modify the file (where it is required to perform the
operation on the true fd) will trigger and wait for the backend
open to succeed and use that fd.
Fops like fstat() readv() etc. will use anonymous FD (configurable)
when original fd is unopened at the backend.
Change-Id: Id9847fdbfdc82c1c8e956339156b6572539c1876
BUG: 846240
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4406
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 4b78a39008dbe294f77eb42d1a868085a0a3a1fd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Feb 6 17:01:10 2013 +0530
rpcsvc/dump: return correct return value
fix e8d09b9ab9 resulted in rpcsvc_dump returning large non-zero
values to caller in case of success. This patch fixes that issue
by returning 0
Change-Id: I594703dada74da17b33c98b073627a3378d170c5
BUG: 903113
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4477
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 928bd10d31dd99b5c94c0b39ec9790a90b64c55a
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Oct 15 11:09:18 2012 +0530
libglusterfs/core: dump frame and callstack creation times in statedump
Change-Id: I3772602ac264cbca490d77a0343038297faee7df
BUG: 844688
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4087
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4a517562f95e0e90226cdcd0d58eb7edd5ddd9d2
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jan 21 12:49:44 2013 +0530
glusterd: Use client-op-versions during "volume set"
The supported op-versions of the client and the name of the requested volume,
are saved during server_getspec(). These are used during the staging of volume
set. If the option being set is not supported by any of the clients which
currently have the volume mounted, then set will fail.
Change-Id: I4e6b60b274d5200508762dc0204cfa848a6c0aa4
BUG: 907311
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4424
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 81a293e25f168672369ce7818705cb37a5e0cb15
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Nov 28 16:22:15 2012 +0530
glusterd,glusterfsd,libgfapi: Client op-version
This patch introduces op-version support for glusterfs clients.
Now, a client sends its supported op-versions during the volfile fetch request
and glusterd will return the volfile only if the client can support the current
op-version of the cluster.
Change-Id: Iab1f1f1706802962bcf27058657c44e8a344d2f6
BUG: 907311
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4247
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3a385c9960f7caac68fdf6b8417f77172590e126
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 6 08:39:59 2013 +0530
tests: Test the open-fd count for a file on brick
Change-Id: I59bc4974eff93e92c4f7041d3722ac60e88b0734
BUG: 908146
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4471
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 59a3d7044e26e612360c96d54af296089c43419c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 6 08:39:41 2013 +0530
tests: Added function to generate brick statedump
Change-Id: I5f394a028a3251ec673c8787b2c67691a8b57449
BUG: 908146
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4470
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 28f28f19e66e81880ece9e5fcb95e1846d661add
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 6 07:12:40 2013 +0530
storage/posix: Fix open-fd-count virtual xattr
Send open-fd-count maintained in inode.
Change-Id: I23db5d052bdeb4f67978ff618ed5a0bed7d1592d
BUG: 908146
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4469
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fbf81800af3673ab80cc25ef7293d430b7cf0cf0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 6 07:04:10 2013 +0530
libglusterfs: Maintain open-fd-count in inode.
Change-Id: I643d02959f92e40f68a53baf165753ed20f8b3e0
BUG: 908146
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4468
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ca6cbdf3832e6b000e9382c8c64b617a709b5362
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 6 12:34:17 2013 +0530
cluster/afr: Avoid priv->eager_lock value update race
Change-Id: I7049c0c64e36a9dfa4cc0e0b34de7ec111d2f6c1
BUG: 908302
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4076
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 18588cc08d1cfc958bac64ee0f77ba4ef64f616e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Feb 6 12:26:08 2013 +0530
cluster/afr: Perform wakeup just before fop
There is no necessity for the delayed-post-op to wait until
the next fop phase on the fd completes. Change-log,
locks are inherited by the time next fop phase is attempted
so the wakeup can happen just before the fop phase is started.
Change-Id: I0b8e591f591b0f7565eb55265ab51f476ed2b165
BUG: 908302
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4073
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 10ce1f4bf9e770ffdd661ee1ab8d66d4586de4b0
Author: Anand Avati <avati@redhat.com>
Date: Tue Feb 5 17:03:38 2013 -0800
fuse(efence): zero sized memory was being allocated.
For the last call of getdents(), gf_malloc called with 0 size, which is then
caught by efence.
BUG: 782760
Change-Id: If289029117a62ecfcecc70480e5ac8f0e050487d
Signed-off-by: Anand Avati <avati@redhat.com>
Original-author: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/3846
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 7f8c9e679b9623dd83d9bbecf515410a7513a676
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Dec 18 14:43:27 2012 +0530
rpcsvc: Fix memory corruption caused by rpcsvc_dump returning non-zero
The convention followed is that any actor should return non-zero
value only if it has not attempted to send the reply back. If an
actor returns non-zero, rpcsvc_handle_rpc_call tries to send an
error reply. Since, rpcsvc_submit_generic frees the rpc_req, its wrong
to invoke it more than once on same rpc_req. When the transport is not
connected, rpcsvc_dump used to pass the non-zero value it got from
transport to rpcsvc resulting in memory corruption. Hence this patch
makes rpcsvc_dump to return 0.
Change-Id: I1b6f28969ee546c44d193d3d33debccb65585b69
BUG: 903113
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4183
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b26adcb308d463eb2b7c6b7e19258a8ba0d262e2
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Feb 4 14:15:24 2013 +0530
protocol/client: Avoid double free of frame
When client_submit_request fails it calls cbk. The cleanups should
happen only in cbk. The code committed as part of
http://review.gluster.org/4357 violates this. Also found that
clnt_release_reopen_fd violates this as well.
This patch fixes these issue.
Change-Id: Ic02ba278724b03c65c00b686c39fd7846122618a
BUG: 821056
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4464
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b01c8769cd66b02eede50529646cec65950f838f
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Feb 4 17:38:16 2013 +0530
glusterd: remove extra call to glusterd_volume_compute_cksum()
In the commit phase of volume create, checksum on volinfo is
computed twice - once in the call to glusterd_store_volinfo() and once,
further down, in the same function glusterd_op_create_volume().
Change-Id: I36f9426943cd48937d4946b4b4ef09f19f31d888
BUG: 812356
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4463
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3a32153c3a8d397911739b373cc4d4d82bbc35e5
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Jan 16 11:19:52 2013 +0530
glusterd: log changes in volume create and delete codepath
Making log changes involving two commands as they both share sections
of code (like the part where the volume metadata is cleaned up in vol
delete in case of success; and in vol create in case of failure).
* Most of the changes are of the 's/THIS/this' kind.
* Changed some of the log messages to give as much information as
available in case of failure.
* Changed log levels in some of the log messages.
Change-Id: I10242511fe9400a07ab04717464d748d9172dd85
BUG: 812356
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4462
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2506a442e72786f4c3f66b80e47ee7f38c947d7b
Author: Vijay Bellur <vbellur@redhat.com>
Date: Mon Feb 4 10:17:01 2013 +0530
group-virt: Change profile to include remote-dio and exclude posix-aio.
remote-dio enables filtering O_DIRECT in the client xlator. This has been
found to be useful for improving performance when there are multiple VMs
talking to an image store.
Aggregated throughput results for a single thread iozone run from multiple VMs
and a single host can be seen below:
-------------------------------------------------
No. of VMs | remote-dio on | remote-dio off |
-------------------------------------------------
2 | 400 MB/s | 202 MB/s |
4 | 650 MB/s | 410 MB/s |
--------------------------------------------------
posix-aio has not been found to improve performance consistently with VM image
workload. Hence not including that in the default virt profile.
Change-Id: I592f68b95a955036f1a985352d2f4950ced1deef
BUG: 907301
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4460
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 03e09464ffc382075cf990349d080c15b54dc830
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Mon Feb 4 13:51:16 2013 +0530
glusterd: "volume heal info" doesn't report output properly
Problem: "volume heal info" doesn't reports files to be healed when gluster*
processes on one of the storage node is not running
Change-Id: Iff7d41407014624e4da9b70d710039ac14b48291
BUG: 880898
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4371
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5ec5ad4151f647865cc23ad1dfc8568821d1bf43
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jan 22 11:42:10 2013 +0530
geo-rep / gsyncd: Separate log file directory for Mountbroker sessions
... so that a mountbroker session which is initiated b/w master
and slave does not use the same log file if it's started after
a normal geo-rep session b/w master and slave. This results in
EPERM as the log file is owned by root and the geo-rep slave
process (now running as a non privileged user) does not have
access to it.
Also, having separate log file directory for mountbroker sessions
looks clean.
NOTE: geo-rep's client mount log file location remains unchanged.
Change-Id: Ic7a732e250aee5393b9c3f6ebf6dfe2c310b7fe4
BUG: 893960
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/4407
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 309461f549b247217ed8dc141227fc588008631a
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Jan 23 14:11:44 2013 +0530
glusterd: Indexed node information in dict to retain consistency.
Problem:
--------
Depending on the response time from different nodes, the response
dict for rebalance status was populated in a FIFO manner, and
hence the output for the CLI was never consistent.
Fix:
----
Irrespective of the response time of the nodes, we now index the
entries in the response dict for rebalance status, in reference
to the peerlist. So, the order of the entries and hence the CLI
output is always consistent.
Change-Id: Ica7e89e5d95aa9860a6f3c7eff58ca2052e05bd6
BUG: 888390
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4416
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2cfb59f8fadfb19aeffa6501d6fdef0d8ce9ef9a
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Feb 4 12:04:04 2013 +0530
tests: Made changes to verify if any of the bricks crashed
Change-Id: I9da3b8a490159b1090a803b74d0058be0d884c94
BUG: 905864
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4461
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 39ae1f1abef0f07e36d18396a2925afa3422c9ba
Author: Peter Portante <peter.portante@redhat.com>
Date: Sat Jan 12 22:39:24 2013 -0500
object-storage: yield during directory tree walks
Have the co-routine (greenlet) yield during long running directory
tree walks to avoid starving out other greenlets that might be
available to run.
A directory walk involves statting every file in the tree to get it
size. For large numbers of files, this can get expensive. So we yield
after every stat call, and after processing every directory.
Change-Id: I07f1dfeef6a09b5817e0c237ecc748c491d52a31
BUG: 894674
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4380
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Mohammed Junaid <junaid@redhat.com>
commit ec4414f236b11f9e617e11511e3a249ff471dec0
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Thu Jan 24 11:26:37 2013 +0530
cluster/dht: Correct min_free_disk behaviour
Problem:
Files were being created in subvol which had less than
min_free_disk available even in the cases where other
subvols with more space were available.
Solution:
Changed the logic to look for subvol which has more
space available.
In cases where all the subvols have lesser than
Min_free_disk available , the one with max space and
atleast one inode is available.
Known Issue: Cannot ensure that first file that is
created right after min-free-value is crossed on a
brick will get created in other brick because disk
usage stat takes some time to update in glusterprocess.
Will fix that as part of another bug.
Change-Id: If3ae0bf5a44f8739ce35b3ee3f191009ddd44455
BUG: 858488
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/4420
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3e5081173bcbc5d87d95ec7e87c3d49a162617bd
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Dec 17 11:20:31 2012 +0530
cluster/stripe: Mount issues with Stripe xlator
Problem:
* 'CONNECTING' is taken as CHILD_UP.
* Sending notifications (default_notify()) for all the events individually
while mounting.
Solution:
* Consider Child up only after the event CHILD_UP is received.
* Send a single notification for all the children's events only
while mounting.
Change-Id: I1b7de127e12f5bfb8f80702dbdce02019e138bc8
BUG: 885072
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/4356
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c301b3c7a402504ac7b8115ea2ebff67e50e0e20
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jan 22 14:09:25 2013 +0530
protocol/server: upon server_connection_put, set xl_private of the transport to NULL
Suppose the get_xlator_by_name returns NULL and the connection is put back
then update the xl_private of the transport by setting to NULL. Otherwise
server_connection_put would have freed the connection object and xl_private
of the transport would still be pointing to the same location which is
freed, thus leading to a segfault when the location is accessed.
Change-Id: Id47e0edde3073b09765338c730847ba3095df9e2
BUG: 901457
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4411
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d1d671d2781a4fd11c172540c7365615a000dd7a
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jan 24 16:05:36 2013 +0530
performance/write-behind: do not try to take LOCK in forget
LOCK attempt in wb_forget is unnecessary
Change-Id: Ibdedc23d0c829c34aedd6fc5bc0e0a584b832514
BUG: 903566
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4423
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c549885938f3afcbb626f01a1d248cebda27dc72
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Oct 22 15:30:49 2012 +0530
glusterd: do dict unref after sending reply to cli
This patch channelizes dict unrefs of dictionaries created from the cli
req during volume ops to one common function - glusterd_to_cli() - which
is guaranteed to be called irrespective of whether the command succeeds
or fails.
This patch also removes extra unrefs at a few places.
Change-Id: Ic8ba7166387b5dfd1f5ae860539e1b7093a94662
BUG: 861044
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4003
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 039f643ea8e4676bf712b145e677c2da67968b3d
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jan 31 10:29:20 2013 +0530
locks: Protected racy (read) access of ext_list
Change-Id: Ibf639695ebd99c11c6960c9be82c0cee71b50744
BUG: 905864
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4458
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 632c15478f26ea48da3a62da0b51e323b129f8b8
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sat Feb 2 00:14:28 2013 +0530
mount.glusterfs: Fixed regexp matcher for existing mount points
Change-Id: I58d237a3d2f4caa7f3865c2e4899c472f7457450
BUG: 906887
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4457
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2ccb78830057d29d9ca03aee18b7e21619d0a305
Author: Anand Avati <avati@redhat.com>
Date: Sat Feb 2 18:59:10 2013 -0800
cluster/dht: ignore EEXIST error in mkdir to avoid GFID mismatch
In dht_mkdir_cbk, EEXIST error is treated like a true error. Because
of this the following sequence of events can happen, eventually
resulting in GFID mismatch and (and possibly leaked locks and hang,
in the presence of replicate.)
The issue exists when many clients concurrently attempt creation of
directory and subdirectory (e.g mkdir -p /mnt/gluster/dir1/subdir)
0. First mkdir happens by one client on the hashed subvolume. Only
one client wins the race. Others racing mkdirs get EEXIST. Yet
other "laggers" in the race encounter the just-created directory
in lookup() on the hash dir.
1. At least one "lagger" lookup() notices that there are missing
directories on other subvolumes (which the "winner" mkdir is yet
to create), and starts off self-heal of the directory.
2. At least on some subvolumes, self-heal's mkdir wins the race
against the "winner" mkdir and creates the directory first. This
causes the "winner" mkdir to experience EEXIST error on those
subvolumes.
3. On other subvolumes where "winner" mkdir won the race, self-heal
experiences EEXIST error, but self-heal is properly translating
that into a success (but mkdir code path is not -- which is the
bug.)
4. Both mkdir and self-heal assign hash layouts to the just created
directory. But self-heal distributes hash range across N (total)
subvolumes, whereas mkdir distributes hash range across N - M
(where M is the number of subvolumes where mkdir lost the race).
Both the clients "cache" their respective layouts in the near
future for all future creates inside them (evidence in logs)
5. During the creation of the subdirectory, two clients race again.
Ideally winner performs mkdir() on the hashed subvolume and proceeds
to create other dirs, loser experiences EEXIST error on the hashed
subvolume and backs off. But in this case, because the two clients
have different layout views of the parent directory (because of
different hash splits and assignements), the hashed subvolumes for
the new directory can end up being different. Therefore, both clients
now win the race (they were never fighting against each other on a
common server), assigning different GFIDs to the directory on their
respective (different) subvolumes. Some of the remaining subvolumes
get GFID1, others GFID2.
Conclusion/Fix:
Making mkdir translate EEXIST error as success (just the way self-heal
is already rightly doing) will bring back truth to the design claim
that concurrent mkdir/self-heals perform deterministic + idempotent
operations. This will prevent the differing "hash views" by different
clients and thereby also avoid GFID mismatch by forcing all clients
to have a "fair race", because the hashed subvolume for all will be
the same (and thereby avoiding leaked locks and hangs.)
Change-Id: I84592fb9b8a3f739a07e2afb23b33758a0a9a157
BUG: 907072
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4459
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit bef661668ecf346ea95448c578b029445472f5ee
Author: Mohammed Junaid <junaid@redhat.com>
Date: Tue Jan 29 09:55:26 2013 +0530
gfapi: Mark fs->init status done in glfs_init_done for the case of glfs_init_async.
This seen when we call glfs_init_async. The glfs_init_done function,
calls the call-back function without assigning 1 to fs->init. The problem
occurs when we call glfs_read or a similar api next time which checks if
fs->init is 1 and will enter into an infinite wait if it is zero.
Change-Id: I34a3d1652c80e737f5b05082a3fbb6e5978b14cd
BUG: 839950
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4445
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 387f0061f45526c7574c3927fe070628ee4c89cc
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jan 31 14:23:36 2013 -0500
socket: restructure disconnect/poll-thread interactions
Change-Id: I792c28f52068e4ed666069b740739662685160bc
BUG: 906401
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4456
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fbb922f0f264acf046598f9f95813c09846d1a34
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jan 31 15:30:42 2013 -0500
glusterd: identify local address by searching network interfaces.
using bind(3) to identify local address fails when net.ipv4.ip_nonlocal_bind
(i.e, /proc/sys/net/ipv4/ip_nonlocal_bind) is set to 1.
Change-Id: I7047b6fb94ef0df10b78673fab34dbd169344fec
BUG: 890587
Original-author: JulesWang <w.jq0722@gmail.com>
Signed-off-by: JulesWang <w.jq0722@gmail.com>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4437
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit 65a1ecdf8737d61eebe580ce0203192b729916bb
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Dec 12 15:11:35 2012 +0530
glusterd: Made volume-status use synctask framework
Change-Id: Id4062799104e5831467ced65a43bfe377b6163f4
BUG: 852147
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4297
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1c77abd6333d8f0e2a7d308222c7db08b189d70f
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Dec 12 15:07:38 2012 +0530
glusterd: Added syncop version of BRICK_OP
- Made rsp dict available to all glusterd's STAGE/BRICK/COMMIT OP.
Change-Id: I5d825d0670d0f1aa8a0603f2307b3600ff6ccfe4
BUG: 852147
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4296
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 303a3b3551912be8dd61ce3c5d463bf7e8ebb1cd
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Dec 12 15:03:28 2012 +0530
glusterd: Moved node rsp functions to glusterd-utils.c
Change-Id: Ib4c4794563a5a694fab16f17c642f788399462f6
BUG: 852147
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4295
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a1cf03918df7bc5f184229610754952ac6ef4d1d
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Oct 23 08:52:55 2012 +0530
glusterd: Removed start-unlock event injection in 'synctask' codepath
Change-Id: I87e02c95d0b650dab7f9ee86c96b2e09ada50109
BUG: 862834
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4118
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 89575feee9c5db138ac3eb524395842ce620cd03
Author: Venkatesh Somyajula <vsomyaju@redhat.com>
Date: Wed Jan 23 12:07:12 2013 +0530
cluster/afr: added logging of changelog for split-brain in glustershd.log file
Change-Id: Iaf119f839cb2113b8f8efb7bf7636d471b6541bf
BUG: 866440
Signed-off-by: Venkatesh Somyajula <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4385
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c397a10b2f23d776c4be81f6adcb3c462193f6b5
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Mon Jan 28 14:09:39 2013 +0530
test: Removed "for" loop of check_xattr function.
Change-Id: I902a5f86d72df3efb45dba09eaa2e8be8b65edf6
BUG: 802417
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4435
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 501f6b1c8921a2e7f9005c35291ed3232657e28b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 29 22:58:17 2013 +0530
Tests: util to check if replace brick completed
Change-Id: I7748395395454765a35e34611d11f58dd4ef3efb
BUG: 857549
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4450
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 92ed382be631e1fe243498599ccadee1ab03159b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 29 22:58:42 2013 +0530
Tests: Basic pump test case
Change-Id: I94666debd5ec271ce5404a77efc421c12928e134
BUG: 857549
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4451
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d18a6c5002fcafda46f34898ff567d2cc01f27ee
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jan 11 17:39:20 2013 +0530
test: test re-opens of open-fds
Change-Id: Ic99c7f3cf1f6a381b0fc1b2ca1acc19f5fe75523
BUG: 821056
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4387
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 489963d29f3a5cc2f194e2233a9b5c36a5c06842
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jan 11 17:37:10 2013 +0530
tests: Added util functions
Added functions to extract gfid, gfid-str
function to check if a file is open
deleting gfid-link of a file
Change-Id: If2f39f43a6631cddb68b4ba7febcd3cf66f399ee
BUG: 821056
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4386
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 08fbc1d6c82bf0f4cee344f95d71a67b009a46d0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Dec 31 10:03:32 2012 +0530
protocol/client: Periodically attempt reopens
If the brick is taken down and the hard disk is replaced
and the brick is brought back up, the re-opens of the open-fds
will fail because the file is not present on the brick.
Re-opens are not attempted even if the files are re-created by
self-heal until the brick is brought down after the files are
re-created and brought back up. This is a problem with a VM-store
in a replica-setup. Until the fd is re-opened the writes will
never happen on the brick where the hard-disk is replaced.
To handle this situation gracefully, client xlator is enhanced
to perform finodelk, fxattrop, writev, readv using anonymous fds
if the file is yet to be re-opened. If the fop succeeds then client
xlator attempts re-open.
Change-Id: I1cc6d1bbf8227cd996868ab2ed0a57fb05e00017
BUG: 821056
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4358
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2d05986f408787ac6362339e3500e70e75b264f9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Dec 29 14:03:06 2012 +0530
protocol/client: Add fdctx back to saved-list after reopen
Change-Id: I01caa1b51570359e6e3ffe1ffb7279cbdb0b0c64
BUG: 821056
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4357
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ea394543a3173eb429e4a9d4ec52d6616eb07a4f
Author: Varun Shastry <vshastry@redhat.com>
Date: Wed Jan 16 14:28:19 2013 +0530
cluster/dht: stack wind with cookie
Default_fops uses stack_wind_tail. It winds without creating the frame leading
into wrong subvol return in the cookie. To avoid the problem caused by the
same, we're getting the subvol by passing the cookie.
Change-Id: I51ee79b22c89e4fb0b89e9a0bc3ac96c5b469f8f
BUG: 893338
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/4388
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 246d49fd326716257f88d50943a981f728a6462a
Author: Anand Avati <avati@redhat.com>
Date: Tue Jan 29 23:56:25 2013 -0800
fuse-bridge: fix some breakages from lock migration patch
- do not attempt lock migration if no locks were ever acquired on
an fd.
- fix fd_lk_ctx_t ref leak during fd migration
- remove spurious fd_unref() (probably added to compensate for
the fd_ref leak in syncop_open_cbk)
- remove @newfdptr out-param which makes fd ref management really
tricky (and currently refs were unmanaged for the out-param).
Instead acquire ref and unref within lock migration function.
Change-Id: I4cc9c451f0df4c051612bd1fa7bef11e801570e4
BUG: 808400
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4453
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit d61d28ff625dc45398e796138761889ba33f4cc4
Author: Anand Avati <avati@redhat.com>
Date: Wed Jan 30 15:46:49 2013 -0800
fd-lk: implement new method to check for empty fd_lk_ctx_t
to use this in fuse-bridge, to conditionally attempt lock migration
to new graph.
Change-Id: I9b10d5839c4ac6051c75e4c020371391cd886ac8
BUG: 808400
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4455
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
commit 8186593d761f5be7a35aeea24704a89b50621eb5
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Jan 30 13:47:31 2013 +0530
libglusterfs/syncop: do not hold ref on the fd in cbk
* Do not do fd_ref in cbks of the fops which return a fd (such as
open, opendir, create).
Change-Id: Ic2f5b234c5c09c258494f4fb5d600a64813823ad
BUG: 885008
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4282
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit dd72637543ea4fa81add134f2d6d2870b5746741
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jan 24 18:40:06 2013 +0530
762989.t: fix a typo by grepping only the blocked port number from netstat o/p
Change-Id: I14c3daa799f0936014bf8aa9fd798ecbaec6e912
BUG: 762989
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4426
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a45eb09ea217a27df1b1467b9a886ed14b9399a9
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Jan 24 11:39:48 2013 +0530
glusterfs : Moved option files, and statedumps from /tmp
Change-Id: Ibdede396c4d6859225937316b7a59a661bcaf9f5
BUG: 764890
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4422
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ceb2cf012161bebfcc5e3d9405b99d40763239a4
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jan 28 16:14:09 2013 +0530
cluster/afr: if a subvolume is down wind the lock request to next
When one of the subvolume is down, then lock request is not attempted
on that subvolume and move on to the next subvolume.
/* skip over children that are down */
while ((child_index < priv->child_count)
&& !local->child_up[child_index])
child_index++;
In the above case if there are 2 subvolumes and 2nd subvolume is down (subvolume
1 from afr's view), then after attempting lock on 1st child (i.e subvolume 0)
child index is calculated to be 1. But since the 2nd child is down child_index
is incremented to 2 as per the above logic and lock request is STACK_WINDed to
the child with child_index 2. Since there are only 2 children for afr the child
(i.e the xlator_t pointer) for child_index will be NULL. The process crashes
when it dereference the NULL xlator object.
Change-Id: Icd9b5ad28bac1b805e6e80d53c12d296526bedf5
BUG: 765564
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4438
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a0879dcb566bf784e4dddaf08e8d757b02023476
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 29 18:45:08 2013 +0530
Tests: Test functionality of flush/fsync with afr
Change-Id: I307a77e90e1852f5e43d50e347f7b52468105389
BUG: 888174
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4447
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6e9ab97faa093b1578283c817653ec49b893fe08
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 29 17:58:09 2013 +0530
cluster/afr: wakeup delayed post op on fsync
Change-Id: I5d84ef72615f9d71b4af210976e2449de6e02326
BUG: 888174
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4446
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a3bd778f589efb7836d93c3e29ef50e270cf062d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jan 25 10:58:19 2013 +0530
cluster/afr: Change order of unwind, resume for writev
Generally inode-write fops do transaction.unwind then
transaction.resume, but writev needs to make sure that
delayed post-op frame is placed in fdctx before unwind
happens. This prevents the race of flush doing the
changelog wakeup first in fuse thread and then this
writev placing its delayed post-op frame in fdctx.
This helps flush make sure all the delayed post-ops are
completed.
Change-Id: Ia78ca556f69cab3073c21172bb15f34ff8c3f4be
BUG: 888174
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4428
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b4a307b11b81da4fb13415ed44231321627ddb5c
Author: Anand Avati <avati@redhat.com>
Date: Tue Jan 29 10:05:29 2013 -0800
quick-read: various fixes
- initialize xdata in qr_lookup even if it was NULL from top. This
allows qr to do its job even if lookup originated from fuse-resolve.c
- extend test cases to include 1 second delay and retry
- fix bug while checking condition for cached unwind
qr_readv_cached() unwinds if op_ret > 0. Therefore qr_readv()
must wind to subvol only if !(op_ret > 0) (i.e, op_ret <= 0).
- qr_readv_cached() is using uninitialized @conf pointer. Thanks
to Raghavendra Bhat for catching this!
Change-Id: Ifaf2ea2685e452210ef9ba3c2d1f2ab51900650c
BUG: 846240
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4452
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6ad883f0a8d95fcb6e01103f63171648a5366662
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Nov 16 12:06:36 2012 +0530
performance/io-cache: propagate errors while unwinding frame in read path.
Change-Id: Ieb5d592a987e8681d5ec019da309f75e3b207580
BUG: 858242
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4204
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a1d62603c5880aa7f6f72263fbd6c276fc06d234
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jan 25 10:00:57 2013 +0100
tests: skip time consuming mock builds for code-only changes
tests/basic/rpm.t takes a bulk of the time for the regression tests.
Often the building of the rpm is not affected at all and therefor the
tests does not add any value.
With this change the rpmbuild/mock test will only be run when some
changes affect the build system. Changes affecting 'tests/', 'doc/',
'*.py', *.c' and '*.h' do not trigger the test anymore.
Change-Id: Ic188b9e26cde3113b2bdf9cd1fab56d9fd85a4b7
BUG: 904005
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4429
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0da8ee774565f383b0be0f379265870d5b503063
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jan 29 10:50:01 2013 -0500
socket: null out priv->ssl_ssl on disconnect
This prevents problems when a socket transport is reused for a non-SSL
connection (e.g. glusterd portmapper) after having been used for an SSL
connection (e.g. a brick). In that case, ssl_ssl will still be non-null from
the first connection, even though the structure it points to has actually been
freed.
I'm not sure why/how we would reuse a socket transport in this way (the case of
SSL after non-SSL has been common for a long time) but recent glusterd changes
seem to have had that effect.
Change-Id: I46f1ff3c409c122478bf720a7f02d92abcc32bed
BUG: 902684
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4449
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ef0b4dbed62f66484e4bc2f94838c8d14013890b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 29 11:27:58 2013 +0530
mgmt/glusterd: Expose post-op-delay through cli
Change-Id: I13e3699bd58d53896ae54e1bfafb3cd1c9580c7c
BUG: 905307
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4443
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 69e06524fff888702dd2cf6af3c7fb9241ec8b95
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Jan 25 19:23:15 2013 +0530
Tests: Fix latency calculation
Idea is to make sure that the FINODELK max latency is not
in the order of seconds.
Change-Id: Ic47dc46c3b2d24d223fe7e2212c4c035de37c9ae
BUG: 895235
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4434
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e97dbb6d24b11647097b9e92a6726ec9fb7de686
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Jan 28 13:24:03 2013 -0500
performance/md-cache: add force-readdirp flag to make readdirp configurable
md-cache currently transforms all readdir fops into readdirp fops.
This patch creates the 'force-readdirp' configuration flag to
provide control over this behavior. force-readdirp is enabled by
default to maintain current default behavior.
BUG: 903175
Change-Id: Idd70926dec7c271204bdfb11fb052e56d0a39420
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4440
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 079eabd6b3f5ac8ac406f9bff7c94a6b1ae2e44b
Author: Anand Avati <avati@redhat.com>
Date: Mon Jan 21 16:42:41 2013 -0800
fd: expose __fd_ctx_del symbol
used by open-behind for deleting context in locked critical region
Change-Id: I3380152211fed6aacbb719468b720376e6ec1e7c
BUG: 846240
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4405
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e47550e88784e8bc5625cf2a8d57d4244e13d9e8
Author: Anand Avati <avati@redhat.com>
Date: Mon Jan 21 13:12:11 2013 -0800
fd: filter anonymous FD from fd_lookup() result
Those callers whose requirements can accommodate an anonymous FD
need to call fd_anonymous(). fd_lookup() is strictly for open()ed
file descriptors only.
Change-Id: I5d8da3db0f44b2e2161d345d7a662cfd4ef87500
BUG: 846240
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4404
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 557a1d9695ea08e16de7a39a7717e05fb72730ee
Author: Anand Avati <avati@redhat.com>
Date: Mon Jan 28 12:31:16 2013 -0800
bug-765564.t: fix path for file to rename
The script assumed it was chdir'ed into the mount point while it
was not. There also happened to be (conincidentally) a directory
of name 'a' in the workspace. The first the script was run, the
rename succeeded. All future tests are failing as the directory
already exists.
Change-Id: I92ad62e7893c03bb3f2af75c51d35bc35866dafe
Signed-off-by: Anand Avati <avati@redhat.com>
BUG: 765564
Reviewed-on: http://review.gluster.org/4442
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 185d81195772e219afc36c520252e0b5176c9faf
Author: Anand Avati <avati@redhat.com>
Date: Fri Jan 18 14:04:23 2013 -0800
quick-read: refactor
- peel out 'open behind' functionality into a separate translator
- issue where, if file size had grown by revalidate, data was not flushed
- removed unnecessary acquistion of table->lock (e.g in qr_lookup())
- keep inode ctx persistent, prune only data (effectively changing the
order of lock acquisition from INODE -> TABLE)
- validation with readdirplus
- use variable size iobufs to simply cached reads
Change-Id: If1586d0298fd1697ddff9fd7008efb3d286d436a
BUG: 846240
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4403
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 0de63c15d31ba00dc146d397df0263893e851040
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jan 28 12:55:17 2013 +0530
cluster/afr: before checking lock_count of internal lock make sure its not entrylk
when the expected lock count is equal to the attempted lock count, then before
deciding that lock is failed on all the nodes, make sure the lock type is
checked properly.
Change-Id: I1f362d54320cb6ec5654c5c69915c0f61c91d8c7
BUG: 765564
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4436
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fbd6bd5da36608d4881cc2c6b33035985ec316f9
Author: Anand Avati <avati@redhat.com>
Date: Wed Jan 23 23:30:07 2013 -0800
bug-867253.t: do a clean umount at the end
On some machines, not doing a clean umount of NFS mount results
in a hang, because sometimes the next script's cleanup() kills
NFS server and the client mountpoint hangs forever.
Change-Id: I64798202180c920650272cc19bcbe07d44377ff6
BUG: 867253
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4421
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 48d9010639533558198bc57baa4e30ddb66325c2
Author: JulesWang <w.jq0722@gmail.com>
Date: Fri Jan 25 11:49:18 2013 +0800
glusterd: make 'glusterd_is_local_addr' return bool
Change-Id: Id3bd0bfc4802c166f7a32b0cc6a726aeb5617b5d
BUG: 890618
Signed-off-by: JulesWang <w.jq0722@gmail.com>
Reviewed-on: http://review.gluster.org/4427
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a0578a80bf25a4f587fe0a9d4d3540128c773f1a
Author: Brian Foster <bfoster@redhat.com>
Date: Fri Jan 25 17:16:45 2013 -0500
storage/posix: skip path construction when dentry list is empty
This is a minor latency optimization to the readdirp path in
storage/posix. During a recursive list, we hit this codepath with
an empty list once per high-level directory to read when end of
directory is reached. Skip constructing hpath, since we don't do
anything with it in this case.
BUG: 903175
Change-Id: I98d7c65505205d55575f064b1e982700f1320cc0
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4432
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a4b3ea165b8c6afff75161d10c8194dfe0e15346
Author: Anand Avati <avati@redhat.com>
Date: Fri Jan 25 19:22:55 2013 -0800
replicate: fix lock counting in blocking lock path
As of http://review.gluster.org/2828, the blocking lock code
path's condition for checking completion of locking atempt is
broken. The condition -
if ((child_index == priv->child_count) || ...)
and
if ((child_index == priv->child_count) && ...)
which is retained to check completion of blocking lock attempts
for DATA/METADATA transaction will _always_ fail because a few
lines above we have -
child_index = cookie % priv->child_count;
So child_index will never equal priv->child_count. This leaves
the correctness at the mercy of the next part of the
conditional -
.. (int_lock->lock_count == int_lock->lk_expected_count) ..
This "works" as long as no server went down during the transaction.
If a server goes down in the middle of the transaction, then this
condition also fails, and the code wraps around and starts a
blocking lock attempt loop all the way again from from the first server.
This results in double locks getting acquired on those servers, and
eventually the second condition gets hit (first condition is _never_
hit) and we come out of locking phase.
During unlock phase we perform only one unlock per server leaving the
other lock "leaked" forever.
Change-Id: I7189cdf3f70901b04647516fe1d1e189f36cc8dd
BUG: 765564
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4433
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 2d8378efbe0195bb9fd570b4e566324a6b79661e
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Jan 25 13:49:47 2013 -0500
glusterfsd: copyright message
Change-Id: I91accd69e58c90f149ff66e0bfea563a9e59e790
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
BUG: 820551
Reviewed-on: http://review.gluster.org/4431
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 13717328f9b9f8df1f90b6d80a0a88c3882a53a5
Author: shishir gowda <sgowda@redhat.com>
Date: Wed Jan 23 09:59:59 2013 +0530
cluster/distribute: get_layout should account only available subvols
The earlier logic used to check if (layout-spread-count <= subvol_cnt -
decommissioned bricks). With this if a subvol was down, and layout-spread was >
upsubvols, a mkdir ended up creating holes in the layout.
The fix is to consider only the combination of subvols which are usable (not
down or not decommissioned).
Change-Id: I61ad3bcaf4589f5a75f7887cfa595c98311ae3bb
BUG: 902610
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4412
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 32366ba268ad843f73175a9401b3d30e54e7e767
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jan 24 00:31:54 2013 +0530
debug/io-stats: Handle open failures gracefully
Change-Id: I85b22db5cc456b3e8c9f26c8254f08a796fc2b28
BUG: 903336
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4418
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c289919fd597ef402e3fefa66fe7eed88f0f3404
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Nov 14 12:23:36 2012 +0530
"gcc -pedantic": made 'inline' functions as 'static inline' functions
for passing the build with -pedantic flag
Change-Id: I80fd9528321e4c6ea5bec32bf5cdc54cc4e4f65e
BUG: 875913
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/4186
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0e3822dfeb89553f6ba22d6fcf68a58b129986bd
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Tue Feb 21 16:28:13 2012 +0530
afr: Modified book-keeping structures for entrylks
* There are upto 3 entry lockees that may be needed to perform
entrylk'ing in posix dir-write operations.
* For eg, rmdir ("/a/b") needs to acquire locks on two entities,
- entrylk ("/a", "b")
- entrylk ("/a/b", null)
* Changed existing entrylk/rename/selfheal (entrylk) transactions
to use the new book-keeping structures
* Fixed few issues in afr_trace_entry_lk{in,out} functions. Tracing is now
aware of the new entry lockee structure.
Implementation notes:
* Changed 'cookie' sent in stack_wind to encode lockee_entity_no
and subvol_no.
cookie is a non-negative integer such that 0 <= cookie < replica_count,
When more than one lock is being acquired across the subvolumes,
cookie % replica_count gives the subvol_no
cookie / replica_count gives the lockee_entity_no.
Change-Id: Idbf41803387a7d59a0f7fcb1453d91cea74da153
BUG: 765564
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.org/2828
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d1a84074bdadf388e81ff377e1cf5cb907d808ce
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Dec 14 01:05:39 2012 +0530
cluster/afr: Remove strict-readdir implementation
Leaving option frame-work un-changed for backward compatibility.
Change-Id: I40bce1ec360801307e67f09e53b0721f64efab37
BUG: 886998
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4309
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1f4d6e2dc59f77be6d7efc3d740e18d9645f0a59
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 22 14:48:38 2013 +0530
Tests: Check that stale indices are removed on heal-info
Change-Id: I1f652d0343053fb87e4979de8b94ba09b3f292f8
BUG: 861015
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4409
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 40529947d5e1e4e324cac0fb0883e9fb37d99a7e
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 22 14:46:48 2013 +0530
Tests: Add utils to get index-path, index-count
Change-Id: I6eebae4b419f92212a30ce5e0dfc889a4541a4ce
BUG: 861015
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4408
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 1691cdbb05b0267c54d7670db57f9f2104518548
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Oct 17 21:24:53 2012 +0530
self-heald: Remove stale index even in heal info
Change-Id: Ic1c9559aec59c1fb9dfede4aba8895f3b86f32f1
BUG: 861015
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4098
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b69ce354d66202bd6b2a3b63c819f7e0410892e7
Author: Mohammed Junaid <junaid@redhat.com>
Date: Tue Dec 18 10:55:24 2012 +0530
object-storage: use temp file optimization
A file name '.<FILENAME>.<RANDOM>' will hash to the same GlusterFS node
as a file named '<FILENAME>', thus avoiding creation/deletion of linkfiles on a rename.
This is part of the work needed to address BZ 876660
(https://bugzilla.redhat.com/show_bug.cgi?id=876660).
Change-Id: I6f18c14b8eaa7a35c96f7e455ef3a19bee7dbde5
BUG: 876660
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.org/4325
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Peter Portante <pportant@redhat.com>
commit 7362540abf8ea12ff3dffb8fe759b9782c179650
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Jan 17 14:46:30 2013 +0530
glusterd/cli: Updated the options descriptions for "volume set help"
Change-Id: I0db00b7334bb9707ab48bd661ac03a3ad818d6e4
BUG: 893458
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4393
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e0c54f03c788cc529643a3de6820cfa8a84dfb4e
Author: Csaba Henk <csaba@redhat.com>
Date: Sat Sep 8 00:53:52 2012 +0200
geo-rep / glusterd: do non-blocking connect to checkpoint service
glusterd should not hang if gsyncd ends up in some weird state
Change-Id: Ic141daa0cd05d515848c8b6c25702418e15b7599
BUG: 826512
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/3919
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e65a44851caaa6a9d3dd50fe02d76eb8f3889bfd
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Nov 21 14:07:05 2012 +0530
core: fixes for gcc's '-pedantic' flag build
* warnings on 'void *' arguments
* warnings on empty initializations
* warnings on empty array (array[0])
Change-Id: Iae440f54cbd59580eb69f3ecaed5a9926c0edf95
BUG: 875913
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4219
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7fbbf93280fc232a8f14f122ee15023f04958f2d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Jan 22 00:26:58 2013 +0530
Test to check if inode-link failures appear
Change-Id: I572a6361f46efc3a0fe7f89a15f3a847c31901a7
BUG: 861015
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4402
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2dc6b1602dc539aadd9bb4bcfdfc1423eb9648bb
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jan 21 23:52:21 2013 +0530
self-heald basic tests
Change-Id: I50e5c4a6712cfc0a7c544551ba1ff182d851f522
BUG: 861015
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4401
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3babac7b0d5c46a84bb19fadd116e92f415286af
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jan 21 23:32:38 2013 +0530
Tests: functions for shd statedump, child_up_status
Change-Id: Ifed91d25b7c62e79019ece336e1065fa35beddb0
BUG: 861015
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4400
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6e9be581c34703804cec673836f0fb35de9c15e1
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Jan 21 18:06:25 2013 +0530
Tests: Added function to get pending heal count from heal-info
Change-Id: I0aed0bb79e45326e3872ae187cb9addd06342a56
BUG: 861015
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4399
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e281d6cff8c3197d8810c3f6ee40699284d2ae1b
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Oct 16 10:24:30 2012 +0530
cluster/afr: Link inode only on lookup
Problem:
When "gluster volume heal <volname> info is executed, crawl's
process_entry is not going to populate iatt structure so the
iatt's gfid will be empty. So inode_links are failing.
Fix:
inode_link should be done only after lookup i.e. when heal is
performed. So moved the inode_link related code to just after
the lookup which is triggered when self-heal is done.
Tests:
The testcase that gives this issue does not give the inode-link
failures anymore. glustershd heal, info commands are working as
expected.
Wrote basic automation tests for proactive-self-heal-daemon
https://github.com/pranithk/gluster-tests/blob/master/afr/proactive-self-heal.sh
Change-Id: Ic112bf104a4d553a64d3d8559f681a25ae1a5362
BUG: 861015
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4090
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 533ad27677380357965b67b884fdcd6fdbd9e929
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Jan 15 00:35:21 2013 +0530
cluster/distribute: If cached_subvol is down, return ENOTCONN in lookup
When we follow a linkfile, and the lookup returns a ENOTCONN error, return
the error, as the cached subvol is down, and lookup_everywhere wont succeed,
but actually ends up clearing the linkfile, and clearing the namespace.
Change-Id: I772bf71531bc646e8fb62d3e8549a5fe0f3896da
BUG: 893378
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4383
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e14ff207649aa8a7b37ac2a9011e2d3bf5623bef
Author: Shireesh Anjal <sanjal@redhat.com>
Date: Mon Jan 21 18:59:50 2013 +0530
cli: fix descriptions of owner-uid and owner-gid
Change-Id: I04c0dd23bc5bc34fd9d7bddb11beeecb8e7e2a49
BUG: 853842
Signed-off-by: Shireesh Anjal <sanjal@redhat.com>
Reviewed-on: http://review.gluster.org/4398
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit e132c949ab3ce495f4722d0cb2eb1955a8793c24
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Jan 2 16:37:04 2013 +0100
build: glusterfs-server should own known files under /var/lib/glusterd
In continuation of Change-Id Ib1df8da7e8abdcd3edece45bd39fe238f28838f1
there are more files that should be owned by the glusterfs-server
package.
Note that starting glusterd, doing some peer-probes and creating volumes
will create additional run-time files under /var/lib/glusterd. The
filenames depend on the volumes that are created, and that prevents
packages from knowing (and owning) them in advance. It seems common
practice to leave files untouched under /var/lib/<app>.
It would be okay to remove files generated by the package itself, but we
should not remove files generated by other packages, or files that have
been created by users manually. I do not see a way to detect files
generated by gluster* applications and remove only these. Keeping the
runtime files under /var/lib/glusterd (which do not have predictive
names) is safe and they should not require much space anyway.
BUG: 829734
Change-Id: I2b79682b014fcf62c2a73f076cf0b11b4ba87f4a
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4361
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 265a6d05d03d5a5baf191948fbb0916c9ac845a8
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Fri Dec 21 10:50:27 2012 +0530
extras: Don't update RETVAL with invalid value.
Problem:
Start and restart functions update the value of RETVAL internally.
Assigning $? to RETVAL after function return was updating RETVAL with
invalid value.
Fix:
Removed assignment statement after start and restart functions return.
Stop function was always returning 0 as return value due to one extra echo
command. Removed echo line.
Change-Id: Iec1a83a83463f419dd45e12daf4e5ded80568a3a
BUG: 888442
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/4349
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 538a384f8032d27da86bb35847cb298bb2caa4d9
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Jan 17 21:11:28 2013 +0530
cluster/afr: Disable delayed post op when eager-lock is off
Problem:
When eager-lock is disabled, inodelks for write-fops on same
fd conflict with each other. If eager-lock is disabled but
delayed post-op is enabled then each write fop's inodelk unlock
waits for post-op-delay-secs. So the conflicting write fop
acquires inodelk after post-op-delay-secs. This results in
post-op-delay-secs delay for every write fop on the fd for
sequential writes (Ex: dd).
Fix:
Disable delayed-post-op when eager-lock is off.
Change-Id: I87ea4c8d1c7bb269b9b174388ae50f37e82629b7
BUG: 895235
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4391
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7c344efcedaa35a2f62940a21d75a448170e2b8d
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Dec 11 21:45:46 2012 +0530
glusterd: log changes in volume stop (and in op sm codepath)
This patch makes log changes mostly in the op state machine as also
in volume stop codepath of glusterd.
Changes made:
* Moved log level from INFO to DEBUG, of log messages on the various
state transitions within a transaction.
For example, messages of the following kind:
a. "Sent op req to <n> peers"
b. "Received LOCK from uuid: <peer-uuid>", etc.
* Changed some of the log messages to give as much information as
available in case of failure.
* Added logs to identify on which machine lock/stage/commit failed.
* Quite a few s/THIS/this changes.
Also, with this change, log changes in all other volume ops
should (hopefully) boil down to modifying the respective logs in
handler, stage and commit (and brick ops in some cases).
Change-Id: I2b8443042b07fb41a1d12033741f7e156aa6b3da
BUG: 812356
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4382
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e3fe48ba777c1d29444f61a9b15fc01f23b230df
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Nov 15 23:07:24 2012 +0530
cluster/afr: Fail readv on data-split-brain
Problem:
Afr prevents opens on a file in split-brian but the
fd that is already open still has the capability to perform
both reads and writes to the file.
Fix:
Fail readvs on a file with EIO.
Change-Id: I8e07f24c36fab800499b36ab374f984b743332cd
BUG: 873962
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4199
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b48bfd5946bb6d8f28ac06532a92b3595d888ea3
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Jan 17 13:54:36 2013 -0500
glusterd: replace obsolete /usr/local reference for remote ssh/gsyncd
See https://bugzilla.redhat.com/show_bug.cgi?id=895656
https://bugzilla.redhat.com/show_bug.cgi?id=764679 (GLUSTER-2947)
https://bugzilla.redhat.com/show_bug.cgi?id=764623 (GLUSTER-2891)
The comments in the bzs are a bit obtuse and/or vague. As near as I
can make out we had, for a while, a "convenience symlink" to or from
/usr/local/libexec/gsyncd, which no longer exists.
And, lacking any comments in the code, I gather this is some sort of
fallback or failsafe logic: if the first, normal attempt to invoke gsyncd
fails then an attempt is made to ssh to the box and invoke it.
In any event, there's nothing in /usr/local/... so it's unquestionably
wrong to try to invoke anything there.
BUG: 895656
Change-Id: I3b7ac7a049b91ce101b930599294830147cc60ad
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/4392
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Joe Julian <joe.julian.prime@gmail.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d55999fba2ecff65f23a921534a47fb11cfbc74f
Author: Brian Foster <bfoster@redhat.com>
Date: Thu Jan 10 10:49:17 2013 -0500
afr: conditionally prioritize EIO errors over ENOENT
The most important errno logic historically only prioritized ESTALE
over ENOENT. Commit c8c0942d added EIO prioritization over ENOENT
to ensure that split-brain was reported when it occurs in
conjunction with bricks missing the file entry. The unintended side
effect of this change is that (non split-brain) EIO errors reported
from the bricks themselves are now reported to the client when the
expectation is that afr should squash said errors in favor of
marking the file inconsistent.
The high-level problem is that EIO is overloaded with different
meanings from different contexts. This commit adds an eio parameter
to the errno priority logic to conditionally flag when EIO is of
higher priority and should be propagated to the client.
BUG: 892730
Change-Id: Ib692a8a1f1737ef190d57894f392ec53ffb33aab
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4376
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2f14aca9877aa511ea20c9ac3cd656e085a3fe35
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Dec 17 16:29:42 2012 +0530
nlm: use virtual ip of server to connect to client
In cases where the servers use virtual ip's, this commit
makes sure we use them and not the physical ip.
This change also refactors code around nlm4_establish_callback
by sending granted msg only after a connection establishment,
and removing the separate thread creation.
Change-Id: I087362c547a25aa52ef7fc6653845a3863466ee6
BUG: 888283
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4326
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 99f18fa05038975e283034ce776a1e3b0367fd6c
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Nov 14 19:25:14 2012 +0530
debug/trace: save the recent fops received in the event-history
* Make use of event-history in debug/trace xlator to dump the recent fops,
when statedump is given. trace xlator saves the fop it received along
with the time in the event-history and upon statedump signal, dumps its
history. The size of the event-history can be given as a xlator option.
* Make changes in trace to take logging into log-file or logging to
history as an option. By default both are off.
Change-Id: I12baee5805c6efb55735cead4e2093fb94d7a6a0
BUG: 797171
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4088
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 65b276ccae8db8cb41fb3e73681f7a91208bc082
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jan 17 18:01:35 2013 +0530
tests: Fix tests for bug 857330
Changed some tests to use EXPECT, which I should have done originally, instead
of using TEST. With recent changes to the EXPECT primitive we get more info for
failures, which hopefully will make debugging of the intermittent failures of
these tests easier.
Change-Id: If763dcfb7e370a3f360277c3c183b950aede5685
BUG: 857330
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4390
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 74b039534338f5da34a0b8ada737ffd3500ce519
Author: Brian Foster <bfoster@redhat.com>
Date: Thu Jan 10 10:49:08 2013 -0500
afr: replace afr_more_important_error with afr_most_important_error
afr_more_important_error() is written to return whether a new errno
should override an existing errno for high-level operations that
could span multiple sub-operations. It specifically prioritizes
ESTALE over EIO over ENOENT, and otherwise defaults to the latest
error passed having priority.
This change preserves current behavior, but rewrites the logic to
return the higher priority error of the existing and new errno. The
purpose of the change is to make the logic a bit more clear and set
the stage for future changes to make the logic flexible based on
context.
BUG: 892730
Change-Id: Id1aa48855dfb0507abc9d1ef22f2259b30472576
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4375
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c611670952f928b448ee549ab271f2f13210f927
Author: Varun Shastry <vshastry@redhat.com>
Date: Wed Dec 19 11:27:57 2012 +0530
cluster/dht: update ctx-time only if we receive the new iatt
1. Used local->postparent(contains merged iatt of all succesful calls) instead
of postparent for dht ctx time update.
2. dht_inode_ctx_time_update avoided in case of opret -1.
Change-Id: Ie04a7842a41c241f911b6a3f76267b996d27fb43
BUG: 881013
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/4338
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c56ea4e4de8c5d7461210e1eefb6d9b9b0e796b8
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Dec 19 00:01:13 2012 -0500
object-storage: add UFO unit tests
Run the UFO unit tests following the main GlusterFS unit tests. The
UFO unit tests run under the Nose unit test running harness, requiring
the python-nose package to be installed. These unit tests run fast
enough that we could even consider running them on a commit hook run
by rfc.sh.
Note that they are not functional tests, as they don't require a real
Gluster file system to run.
Change-Id: I55972890c24be16fc588a6950cb6bfd539287bbe
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4333
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit ea7d8ab41a8e6ee76aac537b6748f199f3afdf62
Author: Kaushal M <kaushal@redhat.com>
Date: Sat Dec 29 12:43:59 2012 +0530
cli: output xml in pretty format
Gluster cli now prints XML outputs in 'pretty' format. This solves the problem
of empty elements occuring as two tags instead of being collapsed into one.
Change-Id: Iab7aeadcff29c18ae388b58e446a16e937ac09ed
BUG: 849293
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4355
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1fd9246cdf456e35f3ceaad9eda7ad83df7b6e05
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 18 09:24:38 2012 +0530
cluster/afr: Pre-op should be undone for non-piggyback post-op
Problem:
When fop fails post-op is always performed
over the network irrespective of whether pre-op is piggybacked
or not. Decrementing Pre-op-done count even for the piggybacked
ones is wrong.
I have added an assert for pre_op_done to be non-zero and when
dd of=a if=/dev/urandom bs=5M count=1000 is executed and a brick
is taken down, the mount is crashing.
Fix:
Decrement pre-op-done count only when the post-op is not
piggybacked.
Change-Id: Ie837251a43bfb437f0fada191302eeee60be1601
BUG: 863939
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4310
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e972006aaca1edcbf3fe610fc607ab035eae34d6
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Oct 4 15:12:12 2012 -0400
replicate: don't clear changelog for un-healed replicas
Change-Id: Iebfa6770a688e89c051666b46977862188061738
BUG: 802417
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4034
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cf0d986f2bc497f4df92eff6f3489aff97c30d58
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Jan 8 08:53:51 2013 +0530
glusterd: Don't persist enable-pump in volinfo->dict
- enable-pump option in the pump xlator is set during a replace-brick
session. This was persisted in the volinfo->dict for volume file
generation.
It has two 'harmful' side-effects,
a) It would lead to volinfo cksum divergence among peers in
cluster (for the same version no.) during a replace-brick session.
b) "enable-pump" key would appear in "gluster volume info VOLNAME".
This key is used internally in volume file generation code to
optionally load the pump xlator in the source brick. It is _not_
an volume option.
Change-Id: I37a8e7186e2985d187e4a166a599cf69145a90f9
BUG: 886000
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4367
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d71aaaacc55abaa76a080277905984b7dddf9f85
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Dec 14 10:48:46 2012 +0100
Fix format security errors with hardening build flags
These problems were found while building with the hardening options used
by Debian. In order to prevent introducing new unsafe constructs, the
options -Wformat" and -Werror=format-security are addeded to the CFLAGS
by configure.ac if the compiler supports them.
Also, a small spelling fix in posix-aio.c is included.
Change-Id: I1034311644fa3c21bc5a7b842c41a3ca79108b3f
BUG: 887278
Original-author: Patrick Matthäi <pmatthaei@debian.org>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4311
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a142e0916bd1500326da41d99d6fbbc8f85b4125
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jan 10 13:06:21 2013 +0530
protocol/server: do server_connection_put only if bound_xl is NULL
If getting bound_xl fails, then while putting the connection back we
should also check for bound_xl pointer for NULL apart from the op_ret
and the connection object. We were checking just op_ret and conn pointer
till now and if the mount from a machine is not allowed as auth.allow
did not permit it, then also we were destroying the connection object.
Change-Id: Iac43e8dc078d905edafb44d6670f88989a8f82a3
BUG: 881062
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4373
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b89f905bd5c62766884c7f82a16a499f5c8f71dc
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Fri Jan 11 14:53:50 2013 +0530
socket: Don't log readv failures if read-fail-log is false
Change-Id: I6903d62cbc7107eb8498bcd81d07667b36890a02
BUG: 764888
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4377
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c0e34494fcab83f53434ed5f3c948a5314b5e813
Author: Raghavendra Talur <rtalur@redhat.com>
Date: Fri Dec 21 12:23:19 2012 +0530
extras: Changed the exit status in start function to 0.
Problem:
We were returning "1" when "glusterd start" was being called with service
already running. As per
http://refspecs.linuxbase.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
we should consider it to be a success case and return 0.
Fix:
Just changed the return status from 1 to 0.
Change-Id: I8d6d2014f0c32ba53834503e721e2a71df7330a8
BUG: 845653
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/4348
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8d55b51614755c7981374a67ff9754e995d9660a
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jan 8 11:20:14 2013 +0530
Changes to support automake-1.13
automake-1.13 obsoletes some macros that were being used. This patch replaces
these macros.
Change-Id: I2a24a923f284e9b54fb57ccc27eb0b5ad8dd6050
BUG: 892882
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4368
Tested-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b29a23814303a724eed3bd7cf3fa0ed37228ab79
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Dec 18 18:44:54 2012 +0530
tests: make EXPECT_WITHIN also fail on command failure
Change-Id: I051bbe2344f19e647826ee177932ae8b95747ebd
BUG: 764966
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4334
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 944aeb78bb0093baf507933f6050e30f973951b2
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Jan 9 21:51:02 2013 -0500
glusterd: fix memory corruption when probe fails
Change-Id: If161e9bebfd518b355aaf37af7805e804772dc2d
BUG: 893851
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4372
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit ca707c4a4ada798a6c1286fc3351947e9becd35b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Dec 19 18:03:42 2012 +0530
glusterd: Add GF_ASSERT check in glusterd volume op handlers
Change-Id: Iea6ac1e612812ba8ffc4b60899a9e574a3b09ea6
BUG: 873549
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4346
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 63ce65cb5b6f94e4beccb994f4a92e1951efdf4f
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Dec 24 15:17:13 2012 +0530
glusterd: Set replace-brick id in op ctx only in origin glusterd
Change-Id: I8282f911fb47f4cfb45947b2810d84105c82b5ff
BUG: 889999
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4352
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 48b20b13e35708dbf32b9234091a807d7adad0a8
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Dec 20 13:27:13 2012 +0530
cli: Fix task-id xml compilation
Change-Id: I92ada7d5ba1eb46024f47c4f32c517db27ada576
BUG: 857330
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4342
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 4280d2e1482c06f6cab6a4b9ac80c1e75cd22ec9
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu May 3 16:29:06 2012 +0530
glusterd: Made dst brick's port info available to all peers
Change-Id: I1f65743a31d95013fdf22cded91c314e9934a3a9
BUG: 816915
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.org/3275
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6ce8c44dfdeae30b5af018c269521397c7a6e472
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Dec 6 13:08:11 2012 +0530
glusterd: log enhancements for volume start
* changed some of the log messages to give as much information as
available in case of failure
* added logs to identify on which machine lock/stage/commit failed
* added macros to represent error strings to maintain uniformity
among error messages for a given kind of error
* moved error logs wherever possible, from caller to callee to avoid
code duplication
Change-Id: I0e98d5d3ba086c99240f2fbd642451f175f51942
BUG: 812356
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4353
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit d2e1444a4771122b0b2b839b710f9cfb1cecfa90
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Dec 21 14:37:29 2012 +0100
nfs: correct phrasing of nfs-mount-udp option
`gluster volume set help` shows the following typo for the nfs.mount-udp
option:
Option: nfs.mount-udp
Default Value: (null)
Description: set the option to 'on' to enable mountd on UDP. Needed by
Solaris NFS clients if NLM support isneeded
Also, AIX NFS-clients seem to need this option, hence rephrasing the
description to be more helpful.
BUG: 889500
Change-Id: I91d88d74824da13dcfe828015d7b9e18abc93ef2
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4350
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ed15b3db1a4078c67b182003b236660206de371b
Author: JulesWang <w.jq0722@gmail.com>
Date: Fri Dec 21 14:32:35 2012 +0800
glusterd: "volume status" for remote brick fails on cli.
cli fails because key "brick-index-max" is missing in rsp dict.
Change-Id: I38119bbd31b68fe3ad1152af2495dff7624d99b7
BUG: 888752
Signed-off-by: JulesWang <w.jq0722@gmail.com>
Reviewed-on: http://review.gluster.org/4347
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 475e974d8e08e96b8d4e0647c0bd39da90824942
Author: Varun Shastry <vshastry@redhat.com>
Date: Fri Dec 21 17:25:54 2012 +0530
system/posix-acl: prevent NULL pointer dereference of group_ce
Thanks Amar Tumballi.
Change-Id: I3ac9b46d4c3fcd12d1eec779317a03c47d267556
BUG: 887098
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/4351
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d8e7176a9b69b6b93368f59d2e069e694f88ebca
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Dec 20 16:48:50 2012 +0530
logging: Added fflush in _gf_log.
Change-Id: I06444b6bc3b1acc8cabd863087bd3508de3c548c
BUG: 889157
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4344
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 327d3a3598f775c48c768dd8d9b0b7de4ce60f5c
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Dec 19 17:04:33 2012 +0530
glusterd: Remove invalid free of op_errstr
Thanks to Raghavendra Bhat for pointing it out.
Change-Id: I77b0f02a71ce273c9d1ffcbb1ce7e9d5b34d9de9
BUG: 873549
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4345
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4c38bee3e79c22e6fbef8374ea7a8ae49854de3a
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Dec 20 13:22:28 2012 +0530
protocol/client: print a message regarding brick status in case of failure
that way, it would help admins to look at the corresponding brick directly.
All credit goes to Amar.
Change-Id: I959df59111864cc0574945d827f8fe5f2d919491
BUG: 839021
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4341
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 9de5c62e46959edd3cb39e54cb700bc87a8009a0
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Nov 13 01:14:43 2012 +0530
core: remove all the 'inner' functions in codebase
* move 'dict_keys_join()' from api/glfs_fops.c to libglusterfs/dict.c
- also added an argument which is treated as a filter function if
required, currently useful for fuse.
* now 'make CFLAGS="-std=gnu99 -pedantic" 2>&1 | grep nested' gives
no output.
Change-Id: I4e18496fbd93ae1d3942026ef4931889cba015e8
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 875913
Reviewed-on: http://review.gluster.org/4187
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit da0c163ae943dcc8f4e54f864d9c6d0ef2d18e0d
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Sat Dec 8 11:55:20 2012 +0000
api: update Python wrapper
This brings us back to functional parity with the C example, and also makes
things more "Pythonic" (e.g. methods on Volume/File objects instead of bare
functions).
Change-Id: I46edfee46d91881e275de2f63e15d9f0a6448e80
BUG: 839950
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4286
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Peter Portante <pportant@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit eca6e60b6418db811a52003e607036248ad7d2fd
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Sep 14 11:45:34 2012 +0530
glusterd, cli: Task id's for async tasks
This patch introduces task-id's for async tasks like rebalance, remove-brick and
replace-brick. An id is generated for each task when it is started and displayed
to the user in cli output. The status of running tasks is also included in the
output of "volume status" along with its id, so that a user can easily track the
progress of an async task.
Also,
* added tests for this feature into the regression test suite.
* added a python script for creating files, 'create-files.py', courtesy
Vijaykumar Koppad (vkoppad@redhat.com) into the test suite.
This patch reverts the revert commit 698deb33d731df6de84da8ae8ee4045e1543a168.
BUG: 857330
Change-Id: Id43d7cb629a38f47f733fbc18cb4c5f2f0327c7a
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4294
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c3182065664522274ff7af0193905bb94b9a80c3
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Nov 28 22:29:36 2012 +0530
protocol/server: Do not access key after GF_FREE in _delete_auth_opt()
PROBLEMS:
1.'key' becomes a dangling pointer after the first call to dict_del()
returns, in _delete_auth_opt(). Therefore, the second call to
fnmatch() is made with 'key' pointing to deallocated space.
2. Also, the name _delete_auth_opt seems to suggest that the function
is intended to match and delete "auth" options from the dictionary.
But it winds up deleting all the options irrespective of whether
the pattern match was successful or not. The same is true with
_copy_auth_opt().
FIX:
Changed _delete_auth_opt() to delete the key ONLY if it matches either
of the two patterns (auth.addr.*.allow and auth.addr.*.reject).
Similarly, changed _copy_auth_opt() along the same lines.
Change-Id: Ic8664e5a0a29cefe43cb59a27e32fbdbeac154b5
BUG: 881062
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4337
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9747301ce9bf3e77a05160213b3f15b57f3140d2
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Dec 19 16:40:11 2012 +0100
tests: let basic/rpm.t cleanup after itself when not in DEBUG-mode
The temporary working directory unders /var/tmp is not cleaned when
debugging of the test is disabled. The logic should be the othetr way
around.
With this correction, the output while running is reduced as well.
Nothing of the output contains useful information and clutters the
testing output for no reason.
BUG: 888743
Change-Id: Id7616ad41873f61fd5d435b380f98068f313d5a6
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4340
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5d1e42f1d0774cdbbff63ba3d299f427e16aefe7
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Dec 19 11:38:49 2012 +0530
cli: Making the op-ret check for gluster peer probe --xml more robust.
Change-Id: I75ca74a9e962ea47abbb2970e37dd182429b734b
BUG: 879490
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4335
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a63d7b6eefca599f0cf3dc40a00ba76bd3021adf
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Dec 19 11:58:15 2012 +0530
cli: Fixing the xml output in failure cases for gluster peer detach
Change-Id: I87aadec1949fccadde396b95f31eeb6832e461b4
BUG: 879494
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4336
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6a676d433bb7391c9c3bcdc0fe0da40b6c373a5d
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Dec 12 17:34:43 2012 +0530
cli: Fixing the xml output in failure cases for gluster peer probe
Change-Id: I9ebec995cbf47d9ced7140e37787e74ff9c63769
BUG: 879490
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4301
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1a5ce6d295f2b73123547fd52b4efb09b6f9f3d7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 18 19:14:58 2012 +0530
Tests: Print the actual, expected values for EXPECT
Change-Id: I394d23c0ea15bd340041550660cc5def017b5f15
BUG: 764966
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4327
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6d2e9efd99a84b28f5feb469e36dec31e0b9c5d7
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 18 20:39:21 2012 +0530
Tests: Redirect 'TEST' errors when it is expecting errors
Change-Id: Iad2535eca7a58526d1a23cea9b7cf445a3846782
BUG: 764966
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4329
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e1b3cf684ee105fcfdd0a96936c0a3ce86e71b70
Author: Avra Sengupta <asengupt@redhat.com>
Date: Wed Dec 5 16:01:24 2012 +0530
features/locks : Made changes to display brick information on clearing locks.
Change-Id: I664614677bc887ce087bfca067e6e57f0d6b659d
BUG: 824753
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4272
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit db41d7c7b77a12c293893189b085ff862a5651ef
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Dec 18 16:24:54 2012 +0530
rpc-transport/rdma: use 24008 as default listen port.
Change-Id: I021d5e2dbe3653d4303b64fe1ada0556cd4b7966
BUG: 878883
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4323
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bb26f0434a0d83ad07c5e13c433d5dca0d3b936f
Author: Anand Avati <avati@redhat.com>
Date: Tue Dec 18 15:21:20 2012 -0800
Revert "tests: Test afr mknod, create when one of the bricks is offline."
This reverts commit 29ea7b5c23571e7d2449b3ccd582d3fe70371ea9
Change-Id: I1ea8bab057fc215ef628b5762cd4958dd961830a
Reviewed-on: http://review.gluster.org/4332
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 17b46cb24f1cbc873eb020436ee147338d30f61e
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Dec 18 16:36:16 2012 +0530
glusterd: Fix initialisation of this
Change-Id: I77f9b153d23ca5de1cb098cde5951e56f04d3a1c
BUG: 873549
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4324
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d4559c1ce8ac9544ddd252b9eb3760622ae3dafa
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Dec 18 15:32:45 2012 +0100
geo-rep: do not access BaseException.message in syncdutils
http://www.python.org/dev/peps/pep-0352/ explains that the .message
property of BaseException is being removed. Most of the other exception
handlers access <Exception>.args[] which should be suitable for this
case too.
Change-Id: I1810450b78d2b3d7f8bd07f2beb02cbe9e2adecb
BUG: 888346
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4328
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0b3018b46dd85955e51d36e20d164206a8fbcd3f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 18 08:35:27 2012 +0530
Tests: Print elapsed time per test file
Change-Id: I61f7653bec357ec2b49d5b7719e564c31c2addbf
BUG: 764966
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4320
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 93a02c048a67d495d29c255b442df3d1194e9b44
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Dec 6 18:05:53 2012 +0530
Tests: Add util function to get changelog xattr
Change-Id: I3f6b79145e78b035950929e7ed8edb259525612f
BUG: 864666
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4317
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 324748a2dac1369a7b4ae663af8e16d1a7b4285f
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Dec 17 14:59:25 2012 +0530
cluster/afr: check for the -ve values returned from dict_serialized_length
Change-Id: I9fa7744b02791180ccb93adef10c363a1b38aa31
BUG: 838204
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4319
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1d8be493e65ad226a0cd4997120c09248eac04cd
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Dec 12 15:36:26 2012 +0530
tests: Added basic sanity test for all volume-status cmds
Change-Id: I482a38ca9f67a5f4b4cbc96731cb68c3b442c2d4
BUG: 764966
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4298
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1e06974ec982d09ef67c3646d913d6f5fe6f204c
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Dec 12 21:01:09 2012 -0500
object-storage: only open file when requested
Only open a file when the caller of the constructor indicates that it
expects to have a file pointer to access in the "fp" field.
Found by Junaid during review http://review.gluster.org/4284, Patch
set 6.
We also bump the version number to mark a line in the set of changes
we want to perform a mini release with to double check for performance
regressions.
Change-Id: I13cf336bb519088890192ee111f4ece85a5982c4
BUG: 886730
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4303
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 2c82531952616657b4bd907ead982e63ca6e0d72
Author: Peter Portante <peter.portante@redhat.com>
Date: Thu Dec 13 22:44:27 2012 -0500
object-storage: don't sort object list, not req'd
The REST API for listing objects in a container does not require that the list
of objects be sorted (the API for listing containers in an account does
require it). Since we can have thousands and thousands of objects in a
container, don't sort them when it is not required.
Change-Id: I6939ef3fec3ea3814a49e3a3046273304889831c
BUG: 887301
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4312
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit af68a6ba21352e76978a9eb791a1b36a93054fa8
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Dec 12 09:51:40 2012 -0500
object-storage: do not list directory for delete
Do not list the entire directory contents of the directory containing the file
before deleting it. We have already verified the files existence constructing
the Gluster_DiskFile object.
This fixes a customer issue. See 885281
(https://bugzilla.redhat.com/show_bug.cgi?id=885281).
Change-Id: I4425c42af3e03624370c779d74b7f073e6eef024
BUG: 885281
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4302
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9163098fded7ff866314f28258e74bb4d2c74eac
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Dec 10 00:41:27 2012 -0500
object-storage: apply upstream DiskFile refactor
Apply the upstream DiskFile refactoring in ahead of its use to easiliy apply
the temp file optimization.
Change-Id: I2708733eed3d87759c70eb3d9e6cd74ef91d0c7b
BUG: 876660
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4288
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7eb0aab11b2baa443407e5f1be00c3a6d574607f
Author: Peter Portante <peter.portante@redhat.com>
Date: Sun Dec 9 23:56:28 2012 -0500
object-storage: a set of cleanups to DiskFile
Here are a set of cleanups for things noticed while working on the
unit test coverage:
* Remove unused constants, adding a constant for default disk chunk
size
* Document missing logger parameter from constructor
* Add iter_hook paramater to constructor in anticipation of 1.7.4
support
* Add back meta_file field even though it is not used in our version
of the constructor for paranoid compatibility
* Remove is_valid field as it is not referenced anywhere, and it is
not a field of the super class
* Rename fields only used internally by DiskFile with leading
underscores
* Convert to using os.path.join() instead of hard coded '/'
references
* Use data_file field where possible
* Assert that put_metadata() will only work when the file exists
* Remove update_object() method since it is identical to
put_metadata() and a direct write will suffice
* Create the directory object only if it does not exist when a
marker directory is requested
Change-Id: If207fed4c0f423e6bd3232e4507f87de877057c4
BUG: 876660
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4287
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4ec8bcd1627a1bba853b9f846b679a5d91b32419
Author: Peter Portante <peter.portante@redhat.com>
Date: Fri Dec 7 16:39:37 2012 -0500
object-storage: Initial unittest of DiskFile class
If we had this ahead of time, we could have avoided the errors that
were encountered leading to the fix-account-mapping fix (see
http://review.gluster.org/4222).
This represents 100% coverage of the DiskFile module, but the coverage
report says otherwise, unfortunately. That is because the put() method
invokes eventlets during the test run, and coverage is not able to
accurately track the coverage lines properly. If one comments out the
"tpool.execute()" line in DiskFile.put() the coverage report then
reports 100% for the DiskFile module.
Additionally, we changed DiskFile.put() in four ways that should not
change its behavior:
1. Comments were added to explain various code paths and mark
potential issues / fixes
2. It no longer returns a boolean value, matching the behavior of
swift.obj.server.DiskFile.put()
3. It no longer logs a message when it detects a directory that
already exists, instead is raises an exception
We believe this is okay because we cannot find a code path that
would lead to his condition. As a result, it makes it easier to
test all the code paths in that routine.
4. It no longer logs a message when create_dir_object() fails, since
create_dir_object() raises an exception on failure only
We also modified create_dir_object() to not return a boolean as a
result of the above behavior.
Note that by implementing these tests up to this point we found three
code paths that would have failed if encountered due to missing
imports. We also made changes to the DiskFile module to make it a bit
easier to test, also eliminating an extra stat system call when
deleting directory objects.
Change-Id: I3286de83c1ec7c5e8d6cab9354e1c4397cee7497
BUG: 870589
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4284
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
commit b7b198261c082f7d98102a253f6c5c1a9e2f44c0
Author: shishir gowda <sgowda@redhat.com>
Date: Wed Dec 12 17:54:57 2012 +0530
cluster/dht: Add "afr.readdir-failover=off" option the rebalance process
By failing over readdir (default behaviour), rebalance could get duplicate
files, as readdir would re-read from offset 0. Rebalance should not attempt
to migrate these files again.
Additionally, we need to handle these cases as failure in rebalance crawl.
No test case provided, as we cannot determine the read child in afr.
Change-Id: If07508b4f92dacc17e0f695b48a866c7c66004be
BUG: 859387
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4300
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e1c6d3f754c865ff548e697ec87ee60f1eb8de66
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Dec 15 03:45:18 2012 +0100
NULL reference fix in gfid log
On callbacks, make sure loc.inode is not NULL before priting its gfid.
BUG: 815227
Change-Id: Iab22b65217b5711ad8a92c83e335d9cb1a23841c
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/4313
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7da3d30babc7ecf61d0d55b6b048a6408cb94a76
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Dec 13 12:51:03 2012 +0530
write-behind: fixes issues with iobuf length for large writes
Use of an unsigned type in some calculations of size would lead to segmentation
faults, if several large adjacent writes came in concurrently.
Also, improves buffer allocation code to take the size required into account.
Credits for the patch go to Amar.
Change-Id: I8a09c52d49909e4ee8e7d4dcfa02ec33ea36a551
BUG: 880948
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4307
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b8845ea2a561e375a3df429dd23c8acc8fa4ea0b
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Dec 12 10:39:31 2012 +0530
glusterd: fix peer probe cli response on error
A peer probe with peers with differing op-versions or with unresolvable
addresses would not reply to the cli with the error.
This regression was caused by some changes introduced into
glusterd_peer_rpc_notify(), which caused the cli reply path not to be executed.
Change-Id: I0392b61e0a1dc22fa074529bdba0e357f938d013
BUG: 885591
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4293
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cfaaf2afb9f46ffcea229527772f160c8c183045
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Dec 12 23:05:20 2012 +0530
cluster/afr: Make afr quorum options visible in volume set help
Change-Id: I705d814f63094279532806db0e1e0fc2815fc107
BUG: 884328
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4306
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6ac4f0272f5e78d1c5c22a6de0e79dcd869a7d26
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Dec 13 14:56:52 2012 +0530
Tests: Added util function for option help presence
Change-Id: Iec9816af11d5ecb743adecdf335e97267994f758
BUG: 884328
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4305
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ae6825208151c941ef798cf4066d2085de5d8473
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Dec 13 15:55:40 2012 +0100
Spurious reserved port warning fix
reserved ports is a Linux specitic concept. Make no warnings for
other systems.
BUG: 815227
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Change-Id: I40037b9e99e7fcbdd0d153865ee7c2ef3733132e
Reviewed-on: http://review.gluster.org/4308
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cf4c495fdda3b992078f5d7249ac8efef67cc97c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Dec 12 12:05:32 2012 +0100
NetBSD MS_RDONLY portability build fix
NetBSD uses MNT_RDONLY where Linux uses MS_RDONLY
BUG: 815227
Change-Id: I8d78831f07e575b215aabc46eaa66e5e277bda0e
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/4299
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0f851d4dd8a8d6c3c5d1682df22b56ac971fbf3d
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Nov 6 10:13:07 2012 +0100
build: include OCF resource agents by default and package them
This change introduces a glusterfs-resource-agents sub-package that
contains the Open Cluster Framework (OCF) Resource Agents (RA). It also
changes the build infrastructure to include the RA by default, making
them available for anyone who is interested in using them with a OCF
compatible Hight-Availability solution like Pacemaker.
Build the RPMs without RA:
$ make dist && rpmbuild -ta --without ocf *.gz
Build the RPMs with RA (default):
$ make dist && rpmbuild -ta *.gz
There is no need to run ./autogen.sh from within the .spec, the whole
autotools infrastructure is included in the 'make dist' tarball already.
This also adds a test-case which builds the rpms with mock for the
latest two EPEL releases.
Change-Id: I12ef5f30f466868825352376156fb4e56b135c58
BUG: 869559
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4130
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 484ae1856b8fc233b4e5e8a0f3d277e5b5d2581e
Author: Filip Pytloun <filip.pytloun@gooddata.com>
Date: Mon Dec 10 14:41:10 2012 +0100
RHEL init script: ability to overwrite options from sysconfig
Change-Id: I15df0aef73e097a9ccfb00e2d4cae81d3a5a82fc
BUG: 885739
Signed-off-by: Filip Pytloun <filip.pytloun@gooddata.com>
Reviewed-on: http://review.gluster.org/4290
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
commit d5423c3ca09dcb04258135de608396185375a89a
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Dec 11 18:31:40 2012 +0530
glusterd: Set op-version for quorum options
Change-Id: I693cc96c1dc7dc560c3c25698f08b846e8a48fca
BUG: 839595
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4291
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 13fb05cda466b7c7f62cfdef3102a836b783a476
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Nov 26 12:21:23 2012 +0530
Added virt group file - template for 'group' set
- This sample file contains the set of volume options
that are associated with volumes that would be used to
store VMs.
- To enable the set of options present in this file one must
do the following,
- # cp extras/group-virt.example /var/lib/glusterd/groups/<group-name>
# gluster volume set <volume-name> group <group-name>
Change-Id: I8848d3d222ce114900db885aeef2f20c83ece28c
BUG: 851237
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4232
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 262f67570890ddf2c51e3cf820ba15f5eec7a194
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Dec 11 13:31:12 2012 +0530
gsyncd / geo-rep: do not start geo-rep if replace brick is in progress
Change-Id: I9db32544ceb6f90c8231aaf40d722f6869a72614
BUG: 861945
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/4289
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2c49c3b875b1a54afb3776afe98ef6fcbf29309d
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Nov 16 07:08:30 2012 +0530
cluster/afr: Remember type of split-brain in inode-ctx
Along with this change, fixed the race of setting the
split-brain status in inode-ctx after unwinding the fop from
self-heal in case of back-ground self-heal.
Change-Id: Ifc829300df485f50f139443802e8b6dc7038b4ad
BUG: 873962
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4198
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9fc1860bef6efaa1cc6188e1e4c876c04b393d96
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Nov 9 10:48:29 2012 +0530
glusterd: log appropriate message when locking fails
PROBLEM:
When a transaction is already in progress, and the user tries to
execute another glusterd operation, the second operation fails as
glusterd fails to acquire lock. But to the user, a message like
"Operation failed" does not give ample information about why the
operation failed.
FIX:
Made glusterd_op_txn_begin use and initialise error string, which is
needed to capture failure in the "lock" phase.
Also made gd_sync_task_begin set error string appropriately when
locking fails.
In the process, I had to introduce error string in some glusterd_handle_*
functions. And because I introduced error string in these handlers, I
decided to also set them in places where these handlers could possibly
fail.
HOW I TESTED IT:
For want of a better idea, I "commented out" the call to
"glusterd_unlock", recompiled glusterd and ran two glusterd volume
operations, one after the other. The second operation fails with the
message "Another transaction is in progress. Please try again after
sometime." as expected.
The tests were performed on two volume ops : one of them
synctask'ized (volume start) and the other NOT (volume create).
Change-Id: Ia862972929872ae2f053707a544824d9cadc37be
BUG: 873549
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4197
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7d1d61b38b9ddcb790e268583068cf1ab034bb18
Author: shishir gowda <sgowda@redhat.com>
Date: Fri Dec 7 10:00:15 2012 +0530
cluster/distribute: re-set layouts to prevent overlaps
When subvols-per-directory option is used, with bricks addition/removal
the layouts might get distributed to other subvols, which were not part
of the layout before. We need to clean up layouts on old subvolumes, to
prevent overlaps.
Also, we need to make sure if layout-cnt is never less
than subvolume-cnt.
Change-Id: I00994a092ca0c99aedcc41bd9412d43460f88a04
BUG: 884455
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4281
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7ce7e9c3660279466541cc1fea5e5de57b716f4f
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 11 19:58:47 2012 +0530
Synchronize ls-loop with main-script
Change-Id: If9a15e4c272baa28eee4f2fdfdf52b2e032b3a96
BUG: 884452
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4292
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e6a748c53bb5583df9da28cdf886b1d98b3ea132
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Nov 14 15:43:56 2012 -0500
object-storage: unit tests to 100% cover utils
Change-Id: I2d540e16cc3d420b9bb88e6857e9795d56e34529
BUG: 884327
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4225
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0af5eeb4d412b7efebcbd52e8b7dc6ae2f953d79
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Nov 14 11:31:43 2012 -0500
object-storage: use temp file optimization for pkl
Override OpenStack Swift's swift.common.utils.write_pickle with our own
implementation that uses the GlusterFS temporary file operation. A file name
'.<FILENAME>.<RANDOM>' will hash to the same GlusterFS node as a file named
'<FILENAME>', those avoiding a move of the file on a rename.
This is part of the work needed to address BZ 876660
(https://bugzilla.redhat.com/show_bug.cgi?id=876660).
Change-Id: I1cb9f97f289ab2ca76ec9221366df74de08268bb
BUG: 876660
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4224
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 212f6aa40a828713d2f36caca9de9c5ff2682d69
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Nov 26 14:25:21 2012 +0530
cli: fail vol set when value = empty string/string with all whitespaces
PROBLEMS:
a. 'volume set' operation accepts empty strings and strings containing
all whitespaces for value. The result - subsequent attempts to start
glusterd fail.
b. 'volume set group' operation, when passed an empty string or string
containing all spaces as value, fopens the wrong file.
FIX:
Made volume set parser in cli check for and invalidate value if its length
is 0 after all the whitespaces have been stripped off.
Change-Id: I6792ee1fe9452d8e25e1fd1eeb1b9981be3389f1
BUG: 859927
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4246
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e0cd45a9e07af8f1be4d436493964a7af73ee8ed
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Nov 23 10:33:12 2012 +0530
glusterd: fail vol set when value = empty string/string with all whitespaces
PROBLEM:
'volume set' operation accepts empty strings and strings containing
all whitespaces for value. The result - subsequent attempts to start
glusterd fail.
FIX:
Added relevant checks in xlator_option_validate_* functions in options.c
and in conversion functions in common-utils.c to invalidate wrong option
values.
Change-Id: I33232c6b42ab4fcce85c2d0e0b0da145fc9232c3
BUG: 859927
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4033
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d2193cb0cbfab7a296e13456c29d226d0d7e7940
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Dec 10 11:56:41 2012 +0530
rpcsvc: Add an extra log message
Adds an extra log message in rpcvsc_check_and_reply_error().
Also, makes a small change in the test-script.
Change-Id: I2b686e6fa86529cc4fbf0066df64057a9784b849
BUG: 884452
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4285
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c89df7033f192460bdf8d432a85daaa482eb5f7a
Author: Peter Portante <peter.portante@redhat.com>
Date: Fri Dec 7 16:34:14 2012 -0500
object-storage: Use "-dev" in the version string
Currently, we have not solved the account mapping story entirely (we
don't have a way to support more than one account to gluster volume in
the mapping).
As such, do not declare this as the final version.
Also update the default RHS 2.0 spec file to "-3" for the release
number to refer to the fact that we now have a working account mapping
(see http://review.gluster.org/4222).
Change-Id: Ia1cd0d18c1d7a7b20f732cc0ff867fecda30a7af
BUG: 870589
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4283
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 93ce1c79fae5835340f916835c8bdba0ef6406b3
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Dec 6 16:49:04 2012 +0530
Fix xdr_to_generic success check
This patch fixes the success check for xdr_to_generic function across the
codebase.
Also, cleans up the brick_op actors table in glusterfsd-mgmt.c to make sure that
the actors are called directly by rpcsvc.
Change-Id: I3086585f30c44f69f1bc83665f89e30025f76d3a
BUG: 884452
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4278
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 480872b7d0c8ee4d14d11abf6914d80ea378c45f
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Dec 6 16:46:57 2012 +0530
rpcsvc: do a 'iobuf_ref()' on buffer while synctaskizing actor
Starting rpc actors using synctask causes rpcsvc to return before the actor
actually finishes its actions. This would cause the buffer to be unreffed by
socket and be possibly reused, before the actor used it, leading to failures
in the actor.
This patch makes rpcsvc take a ref on the buffer when synctaskizing the actor
and store it in the request structure, and then later unref it when the request
structure is destroyed. This makes sure that the buffer is not reused before the
actor has finished.
Change-Id: I8f81e1fef8f3719db220471d2d8ffb8916958956
BUG: 884452
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4277
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 097c7ac4368d9dbf9e60e061a8a62530599c0013
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Nov 27 15:13:15 2012 +0530
cli: cmd history echoes the last command string word twice with --mode=script
PROBLEM:
When a gluster command is executed with --mode=script option
enabled, the last word in the command string is echoed twice
in command history.
Example:
[2012-12-03 05:29:16.083176] : volume start dis dis : SUCCESS
FIX:
Terminate argv with NULL when the words are shifted after omitting
"--mode=script" from it.
Change-Id: I3a2623efe02e58c97c34554988938a9299425492
BUG: 823081
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4255
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d1d96b524ea2ccd21b399f9c018e4940833c2c47
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Dec 6 15:58:06 2012 +0530
cli: add print-logdir option
Change-Id: I92fe55d72aa597cbac57a51d2e15b35d2bcfef0e
BUG: 823081
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4275
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 52cf6ffa31787ca702c609e4ba8d452b72777836
Author: Peter Portante <peter.portante@redhat.com>
Date: Thu Nov 8 12:31:10 2012 -0500
object-storage: enforce RPM package dependencies
We now have access to openstack-swift-* packages that work with these sources
so we can enforce the dependencies and what gets obsoleted.
Change-Id: I83f442f3eb2424d176a2257f3498ed39eed32251
BUG: 870589
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4223
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0053cc1585753725abdb6137236fce35e5e490ab
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Nov 21 16:42:15 2012 -0500
object-storage: fix account mapping
Fix the account mapping so that we always use what is provided by the request.
With this fix, "/mnt/gluster-object/AUTH_ufo0" directory hierachies won't be
created. But this fix does not restore the one-to-one account to gluster
volume name mapping.
When the user runs the /usr/bin/gluster-swift-gen-builders script, it still
only allows one cluster volume, and that is the only volume that is used. So
the account names are effectively ignored. A future set of changes will
address that problem.
Change-Id: I2df608de2f00fd356a09c500d49fe12cc1a0a574
BUG: 870589
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4222
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
commit 7843fe377052752d618c4dbfde76390f4a202034
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Tue Dec 4 14:25:33 2012 +0530
BD backend documentation update
BUG: 805138
Change-Id: I2b4eb3fb7bad59c5dadf7f22fcc4d2b2a783984a
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/4273
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit cc3d18bc9467aa6eecf36337e0f7a22c9df37a8f
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Tue Dec 4 14:25:33 2012 +0530
man page update for BD backend xlator
BUG: 805138
Change-Id: Ifbceb329ba9039e6617d377c6b7fdb67d2383ddd
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/4274
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit dd9374e3e70a8a497b551185ae577db9583c6f3c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Dec 5 12:20:28 2012 +0530
cluster/afr: Empty string should not be default option val
Glusterd does not allow empty string as default value. Changed
afr option values to disallow empty string as value.
Change-Id: I92a2d658907dbc6101e1139dd91f548acb5506f5
BUG: 859927
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4271
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 96a9ff71b741a7c93dd2cbbffef9376df5fa655c
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Thu Nov 29 17:17:49 2012 +0530
Add util function to kill brick
Change-Id: Ic67edd7edeaab16461c0009b49d951bfb4d79929
BUG: 859927
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4270
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5075b7f8c0a4cfc605787ccb46cd8b26bf27111f
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Oct 22 16:07:29 2012 +0530
protocol/client: log ENOENT errors in debug mode.
Change-Id: I9b4ffb4a2f6be7ff5a0521f6582a9bc6f172e26c
BUG: 872490
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4153
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6183090194d51cbeb6eab6b05d7e28a0692f551f
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Nov 20 12:03:16 2012 +0530
glusterd-hooks: Made hook runtime work with synctask'ized codepath(s)
Change-Id: If66799c204483c3486a2b8ca842bb1b5f2e53997
BUG: 877992
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4210
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2ed4da39b5f09a4a92fb093b26980925952e0666
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Nov 22 18:48:40 2012 +0530
rpc: check the ctx->listener before accessing rpcsvc object
Change-Id: I3c913d1fab07deb41eec05c5adc29a3964315b43
BUG: 858487
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4230
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7cc6c81382b16c0acaa6997a75639256f3b9e45b
Author: Anand Avati <avati@redhat.com>
Date: Tue Dec 4 16:00:36 2012 -0800
Revert "glusterd: add "volume label" command"
This reverts commit dad16a51ba7e6b1c57529423c57257dbce97ee93
Test script causing "silent" failures during execution.
Change-Id: I26dbb8ed22256071cb415cc3aff572ef8372600e
Reviewed-on: http://review.gluster.org/4268
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b929180da2c1bf5a89da7669fb1b06e4d9ca0e14
Author: Anand Avati <avati@redhat.com>
Date: Tue Dec 4 15:25:34 2012 -0800
Revert "glusterd, cli: Task id's for async tasks"
This reverts commit ed15521d4e5af2b52b78fd33711e7562f5273bc6
Strangely, the test scripts are "silently" passing for failures too. Reverting patch for now.
Change-Id: I802ec1634c7863dc373cc7dc4a47bd4baa72764e
Reviewed-on: http://review.gluster.org/4267
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3176eeaa052358a3c547a3253c96ed0e48e3d759
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Nov 27 12:34:18 2012 +0530
cluster/afr: mark new entry changelog for create/mknod failures
Problem:
When create/mknod fails on some of the nodes, appropriate pending
data/metadata changelogs are not assigned. This was not considered
to be an issue because entry self-heal would do the assigning of
appropriate changelog after creating new entries. But using
the combination of rebalance and remove brick we can construct a
case where a file with same name and gfid can be created in a dir
with different data and link-to xattr without any changelog.
Fix:
When a create/mknod failure is observed mark the appropriate
changelog on the new file created.
Change-Id: I4c32cbf5594a13fb14deaf97ff30b2fff11cbfd6
BUG: 858212
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4207
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8ca98b47c9410f4b669decda3f9a38a72aef2a45
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 4 18:22:33 2012 +0530
tests: Util commands for rebalance and afr child-up, shd up
Change-Id: I175171524b750dff5b2ec0c11dc006d77123ecd5
BUG: 858212
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4237
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit be817be565553b8ed2bbb3548a8ae316ce692954
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 4 18:21:08 2012 +0530
tests: Test afr mknod, create when one of the bricks is offline.
Also tests the test case in bug 858212.
Change-Id: I00e1c3f6142e9dab6868d8fd9ef66d39a7d3fae2
BUG: 858212
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4238
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit dbf0eae9290fb6c190f06e4d85079f03d8156339
Author: Anand Avati <avati@redhat.com>
Date: Wed Sep 5 17:20:05 2012 -0700
rpc-transport/socket: implement read-ahead of RPC headers
This reduces the number of read() system calls on the socket to
complete the full RPC fragment reading.
Change-Id: I421a53af195ead4aad70e09e0172a61ad7912d83
BUG: 821087
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3855
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 8237255a0ca1854c5596f392e505a9488c3ce920
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Dec 3 10:45:04 2012 -0500
afr: use data trylock mode in read/write self-heal trigger paths
Self-heal data lock contention between clients and glustershd
instances can lead to long wait and user response times if the
client ends up pending its lock on glustershd self-heal of a large
file. We have reports of guest vm instances going completely
unresponsive during self-heal of virtual disk images.
Optimize the read/write self-heal trigger codepath
(i.e., afr_open_fd_fix()) to trylock for self-heal and skip the
self-heal otherwise to minimize the likelihood of a running/active
guest of competing with glustershd on arrival of a brick. Note that
lock contention is still possible from the client (e.g., via
lookup).
BUG: 874045
Change-Id: I406443c061ff6acd2a851179626b78352caa5c03
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4258
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 675695769ca8d46a33df18db6a0a3bf376a0ef9d
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Dec 3 10:41:49 2012 -0500
afr: support self-heal data trylock mechanism
Introduce a block flag to support an optional blocking or
non-blocking mode in the self-heal data locking mechanism. All
callers are modified to use blocking mode, which is the current
default behavior (no change in behavior is introduced by this
commit).
BUG: 874045
Change-Id: Ib7ff9984578fa11de4e3b6981508100cdddd37cd
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4257
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6c22ca3ce9bec37f87171a2a5a5bb12a4bfa1971
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Sep 14 11:45:34 2012 +0530
glusterd, cli: Task id's for async tasks
This patch introduces task-id's for async tasks like rebalance, remove-brick and
replace-brick. An id is generated for each task when it is started and displayed
to the user in cli output. The status of running tasks is also included in the
output of "volume status" along with its id, so that a user can easily track the
progress of an async task.
Also,
* added tests for this feature into the regression test suite.
* added a python script for creating files, 'create-files.py', courtesy
Vijaykumar Koppad (vkoppad@redhat.com) into the test suite.
Change-Id: Ib0c0d12e0d6c8f72ace48d303d7ff3102157e876
BUG: 857330
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/3942
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c92d5a4c0f0d6a6674e4ead7e1a2bce8234f50b7
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Dec 4 15:39:45 2012 +0530
storage/posix: if create returns EXIST, donot set gfid/xattrs
Change-Id: I9f2b75b10bde428d36d6516aa09c18e590d17ed9
BUG: 864801
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4265
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 50d82fe660132dc20ccb62aa280d2ddfeec0d96c
Author: Brian Foster <bfoster@redhat.com>
Date: Tue Dec 4 10:17:46 2012 -0500
tests/bug-830665: use the default H0
The use of 'hostname -s' leads to a failure on my VM due to
attempting to create the volume on localhost. Use the default H0
value.
BUG: 830665
Change-Id: Icf23c89d2387fe747aca6d99af12f7d4e1e3fbf0
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4266
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0a9f92c4dc19fe3da1d4404fdcf55e8ebd6676aa
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Dec 3 15:50:39 2012 -0500
afr: make flush non-transactional
Flush is historically a transaction to ensure all previous writes
were complete. This is no longer required as write-behind has
learned to make flush a barrier operation (re: conversation w/
Avati).
Flush taking a full file lock causes VMs running on afr volumes
to stall when a migration occurs and self-heal is in progress.
Make afr_flush() a non-transactional operation.
BUG: 874045
Change-Id: If2db83823e280c86b1b29b41361eed7081601632
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4261
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a2d522cb01fcdec3b0d6ba194dd45b027543d653
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Dec 3 12:16:28 2012 -0500
glusterd: add "volume label" command
This command is necessary when the local disk/filesystem containing a brick
is unexpectedly lost and then recreated. Since 961bc80c, trying to start
the brick will fail because the trusted.glusterfs.volume-id xattr is
missing, and if we can't start it then we can't replace-brick or self-heal
so we're stuck in a permanently degraded state. This command provides a
way to label the empty brick with the proper volume ID so that further
repair actions become possible.
Change-Id: I1c1e5273a018b7a6b8d0852daf111ddc3fddfdc2
BUG: 860297
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4259
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 99925001e93abd6985c32dc5b4873b01d1aa0f5e
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Nov 26 16:36:42 2012 -0500
dht: support auto-NUFA option
Many people have asked for behavior like the old NUFA, which builds and
seems to run but was previously impossible to enable/configure in a
standard way. This change allows NUFA to be enabled instead of DHT from
the command line, with automatic selection of the local subvolume on each
host.
Change-Id: I0065938db3922361fd450a6c1919a4cbbf6f202e
BUG: 882278
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4234
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7e1f0be8538218ee2b8054e274a88a4ff61659ad
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Nov 29 21:43:23 2012 +0530
fix memory leaks
* write-behind: free the inode context in wb_forget
* distribute: in readdirp callback put the allocated context to the inode
* distribute: check if the layout is NULL before accessing it in layout_unref
Change-Id: I7698f81b85b99d06bf6b01fc1a6e51e1593b5e27
BUG: 790709
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4250
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 52661cbf795417b82afb608597f55e0f7a5a2736
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Nov 29 23:05:17 2012 +0100
geo-rep / gsyncd: play nicely with peer multiplexing when setting a checkpoint
The gsyncd invocation that instruments the "geo-rep config" command is
multiplexed over peers to ensure the uniformity of configuration.
In general, that works well, but checkpoint setting is a special case,
because (unlike other instances of config-set) it is logged (as recording
of checkpoint events is part of the feature).
Problem is that the path components leading to the log file are
created only on the original node, where gsyncd was started.
Therefore the logging attempt will fail on the other nodes.
Fix: ignore if opening the logfile on behalf of checkpoint setting
fails with ENOENT.
Change-Id: I677f3f081bf4b9e3ba4d25d58979d86931e6beb4
BUG: 881997
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/4248
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Christos Triantafyllidis <ctrianta@redhat.com>
Reviewed-by: Christos Triantafyllidis <ctrianta@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 86ace9624e09c7baa3f7be6da220329f90f11e08
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Dec 4 14:38:54 2012 +0530
libglusterfs: fix unused-but-set-variable warning
Change-Id: Ie152169a70eaec9554382b39d43ae7ffa04f041c
BUG: 762989
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4264
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c1d3e11c8de2fb0cefaf9264bdab28f6fb7bff24
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Dec 4 12:44:22 2012 +0530
tests: Introduce new test primitive EXPECT_WITHIN
Introduces a new test primitive EXPECT_WITHIN with syntax,
EXPECT_WITHIN <timeout in seconds> <expected output> <command>
which runs the given command every second and compares its output with the
expected output, till the timeout occurs.
Change-Id: I91c6de157e5d33fffafe532ceba84e2a9223356f
BUG: 857330
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4263
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit f8a4865489d7f26d7b53722278dfab0d8123c2f6
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Dec 3 06:40:11 2012 -0500
nfs: do opendir for "naked" readdirp to force self-heal checks
Instead of an opendir, the first thing the Linux NFS client usually sends
us is a readdirp at offset zero, effectively bypassing our self-heal checks.
Detect this condition and issue our own opendir to compensate.
Change-Id: I69463370abd6235d705bf80b8c77fae4a61096ae
BUG: 830665
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4067
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 965843d08ddb00de9502164b7ec31b1e0735b82e
Author: JulesWang <w.jq0722@gmail.com>
Date: Tue Dec 4 10:12:30 2012 +0800
cli: fix incorrect xml output of brick tag.
Incorrect output:
<brick>
<brick>
</brick>
</brick>
Expected output:
<brick></brick>
<brick></brick>
Change-Id: I40c30feda4e6f3f1ec5da4122f8965b61c511ae6
BUG: 880993
Signed-off-by: JulesWang <w.jq0722@gmail.com>
Reviewed-on: http://review.gluster.org/4262
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Kaushal M <kaushal@redhat.com>
commit 443ef3e36933e3c9b31465da350ef4d8ed02949f
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Oct 25 17:06:31 2012 +0530
socket,rdma: before binding to any port check if it is a reserved port
* The list of ports which are reserved is obtained by reading the file
/proc/sys/net/ipv4/ip_local_reserved_ports.
Change-Id: I3a832f53efbb79dd719b34a30cbaf28269f25816
BUG: 762989
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4131
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 442a653413c120ba45527d3562c9e06a0bb1424b
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Dec 3 12:12:57 2012 +0530
cli: Fix build when libxml2 is absent
Also added a note to the top of cli-xml-output.c, explaining the style of coding
to followed when adding code to it.
Change-Id: I7f90a9c075adb49a9e071771d136b6f01ea68d11
BUG: 882780
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4256
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c0fc5b58d784da30a10351e86a6aeb0969713d71
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Dec 3 10:54:21 2012 +0530
tests: Perform self-heal in foreground
Change-Id: Ic9fa7ffe9cd704740e920b66162950f0c0322e67
BUG: 865825
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4253
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ce7262148c28c5aac40f1ffc01aad912b2f993b3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Nov 5 21:42:22 2012 +0530
cluster/afr: Provide option to disable readdir failover
In a replica pair unlike files, directories may not have their
content in same order, so readdir for same (offset, size) may
not give same entries on both the sobvolumes of replica pair.
Switching over from one subvolume to another may not be a good
idea sometimes. It may lead to duplicate entries or fewer entries
or both. This patch provides a way to disable readdir-failover
so that applications like rebalance can retry if they want to.
Change-Id: I2b23eb224a2e84016a561362932613ac824c11a0
BUG: 859387
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4159
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b4ffac1d524120f0ce556cbbd3d90a28e3059962
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Mon Dec 3 10:50:29 2012 +0530
tests: Test the exit status of touch
Change-Id: I4fd52d6b54c5bcf16298c3a9ec98a12fea8df957
BUG: 860663
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4254
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7a10af7aa3545f90abb0de95f8d65a5ba8269ba1
Author: Vijay Bellur <vbellur@redhat.com>
Date: Fri Nov 30 12:11:02 2012 +0530
encryption/rot-13: Cleanup trailing whitespaces
Change-Id: I9f5c81ca4320b6e73087023102dff6e3911b5095
BUG: 764890
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4251
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 0c15cb0fd6ce64f43f22f9762970fcda87e7a6d1
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Thu Sep 27 17:59:23 2012 +0530
core: remove ref/unref while unwinding frames
Change-Id: Ib196ffdf8122a9510cc7c5953303a6e730091302
BUG: 853373
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4062
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 148b84b70dad3411144e250b59294777b1d10495
Author: Anand Avati <avati@redhat.com>
Date: Mon Nov 26 20:02:18 2012 -0800
build: make dist to capture current build tree state
ChangeLog will now hold the 'git log' and 'git diff' against
the HEAD of the tree from which 'make dist' was issued.
Change-Id: I0b5b27de66b02d733612470a8c79d65f0b560fa1
BUG: 764890
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4235
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit ea24b4892cfb21a1ebd349ce7999534bd8c099da
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Nov 28 15:43:17 2012 +0530
cluster/afr: Added descriptions to afr options
Change-Id: I4aef1c79743ee08b62e04d7b709f3e8c6b9dc56a
BUG: 881517
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4244
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit f785ccf3262a3545514fba909e33203682286716
Author: shishir gowda <sgowda@redhat.com>
Date: Wed Sep 26 18:09:33 2012 +0530
cluster/dht: fail fix-layout if any of the subvol is down
If any subvolume is down, and a layout is re-written and hash
values change, entry names in the downed subvol can be reused
in the other subvol which got the same hash range. when the
downed subvol is brought back up, duplicate entried might appear
Also separated handling of ENOSPC and ENOTCONN error.
Change-Id: I5ed93990425a4cee70df2dab7c7c119fdc87ad56
BUG: 860663
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4000
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6c581d060bf6f71a312a0fa93bd91a7b621508a7
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Nov 30 11:28:54 2012 +0530
tests/README: add a note about usage of 'mount -t glusterfs'
Change-Id: Ic9e02c34e8d7c8eb4a18c459d2a8899d85a59189
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/4249
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit e6d4ada1293fcdd7290c467494009c80aa711cd3
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Tue Nov 27 12:33:06 2012 +0530
mgmt/glusterd: Consider nodesvc to be running after online
Definition of online in the message below is that the
RPC_CLNT_CONNECT event arrives for the nfs/self-heal-daemon process.
For automated tests, sometimes the script needs to wait until
self-heal-daemon comes online, so that the relevant
commands can be executed. Gluster volume status before this change
printed whether the self-heal-daemon is running or not based on the
lock availability on the pidfile. But there is a small window where
the lock on pid file is present but the process is still not
online. So the commands that were depending on this kept failing in
the test script.
Change-Id: I0e44e18b08d7b653d34fa170c1f187d91c888cd9
BUG: 858212
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4236
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ab1900d996ec6a6c54cba8e3149dbb10daa95d81
Author: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
Date: Sun Nov 25 22:57:06 2012 -0700
Replace "ssh foo gluster" with "gluster --remote-host=foo"
With the current lack of authentication, there is no security
improvement with passwordless ssh replaced. However, it is more
convenient to install UFO if you do not have to generate ssh
keys every time.
There is a downside the gluster-server RPM becomes required.
BUG: 880050
Change-Id: I04f4ad666ac96713055723bd432131a4db325b4f
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-on: http://review.gluster.org/4231
Reviewed-by: Peter Portante <pportant@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 333f4ac55e19e8a39c103a8d43963e38cfa787c4
Author: shishir gowda <sgowda@redhat.com>
Date: Thu Oct 18 15:40:02 2012 +0530
cluster/dht: Heal dir uid/gid
Identify mismatching uid/gid in lookup, and trigger a syncop
heal. uid/gid of subvol with latest ctime is trusted (local->prebuf).
Change-Id: Ib5c4bc438e7f4b1f33080e73593f40f400e997f0
BUG: 862967
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/3964
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4a163af050cff1aa666782d635a9aca5f16dd0b8
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Nov 29 14:06:30 2012 +0530
debug/error-gen : Added dumpops to print private values of error-gen in the statedump.
Change-Id: I4aa299bd8ecdaa82cdfdc2d97a89fcddcbb25930
BUG: 767095
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4245
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 44d50e3662735d5e639f87e1d8e0e6bcf0d91cd0
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:08 2012 +0530
BD Backend: Test Cases
BUG: 805138
Change-Id: I04c1b68cf02d55d1481137fe6bb2386c2ba958f3
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/4145
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bfda441373bc88c72be569a92bad2721e271052b
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:07 2012 +0530
BD Backend: CLI to create a full/linked clone of a image
A new CLI command added to support cloning/snapshotting of a LV device
Syntax is:
$ gluster bd clone <volname>:<vg>/<lv> <newlv>
$ gluster bd snapshot <volname>:<vg>/<lv> <snap_lv> <size>
BUG: 805138
Change-Id: Idc2ac14525a3998329c742bf85a06326cac8cd54
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3719
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 39806fe6e4ab62c397c107f49d4740fa1ff584f2
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:07 2012 +0530
BD Backend: CLI commands to create/delete image
Cli commands added to create/delete a LV device.
The following command creates lv in a given vg.
$ gluster bd create <volname>:<vgname>/<lvname> <size>
The following command deletes lv in a given vg.
$ gluster bd delete <volname>:<vgname>/<lvname>
BUG: 805138
Change-Id: Ie4e100eca14e2ee32cf2bb4dd064b17230d673bf
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3718
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5bfe8793d69c9ef3aece177d7bdf250d95b8f7ed
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:07 2012 +0530
BD Backend: Volume creation support
A new parameter type is added to volume create command. To use BD xlator
one has to specify following argument in addition to normal volume
create
device vg brick:<VG-NAME>
for example,
$ gluster volume create lv_volume device vg host:/vg1
Changes from previous version
* New type 'backend' added to volinfo structure to differentiate between
posix and bd xlator
* Most of the volume related commands are updated to handle BD xlator,
like add-brick, heal-brick etc refuse to work when volume is BD xlator
type
* Only one VG (ie brick) can be specified for BD xlator during volume
creation
* volume info shows VG info if its of type BD xlator
BUG: 805138
Change-Id: I0ff90aca04840c71f364fabb0ab43ce33f9278ce
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3717
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 1d59420e95aee3e9205c63808f1dd4e24e640ad8
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:07 2012 +0530
BD Backend: Rename LV
BUG: 805138
Change-Id: I18c64435e66ede148c58d412a0639f45554209c8
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3558
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 552bc2d3fb052d4b920f3a91940774d0f8bfa0ef
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:06 2012 +0530
BD Backend: Extend size of file (LV)
Use the truncate interface to increase the size of file (LV).
FIXME: lvm2 library does not provide any interface to extend size of LV.
So lvextend binary is forked to achieve the same
BUG: 805138
Change-Id: If4c0bd112364437b89e091b7f53764b8e6e01a28
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3557
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 182355a61d44a995feb91fed59934319c2a68f45
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:06 2012 +0530
BD Backend: Full clone and linked clone
FIXME: There is no lvm2 api to create a LV snapshot. This patch forks
lvcreate binary to achieve the same.
BUG: 805138
Change-Id: Icdbead16f797162fe6a31a672b619ce6a0391235
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3556
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2174842e0deaf5de3286ae91fc3967602dc73a46
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:06 2012 +0530
BD Backend: Unlink a file (LV)
BUG: 805138
Change-Id: I53d8a4bc09cbd9766ba937887cadd7ac475017ba
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3555
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 80970001ef8c384e60d2041904ea61725b7c17b6
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:06 2012 +0530
BD Backend: Create a new file (LV)
Add support to create a new file (LV) under a directory (VG). By
default created LV is of one logical extent size.
Also setattr/fsetattr interfaces added as part of this patch.
BUG: 805138
Change-Id: I51752b707b3766ab277d623ce574537346f376c9
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3554
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8c5afadfcf9876e141288b14870bff0fa3db8427
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:06 2012 +0530
BD Backend: Write support
BUG: 805138
Change-Id: I4a672fc58ee61dead99e0adcd46d7771f3fdd730
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3553
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3537ad2c47e3eb9fcd567e84e3a2a0463931e861
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:05 2012 +0530
BD Backend: Open,read and related calls support for LV
BUG: 805138
Change-Id: I811c179d4244342537dbedb8a24fd2ec628942ed
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3552
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c244d30deb1961c35fa1d973fe367d907e7cb04c
Author: M. Mohan Kumar <mohan@in.ibm.com>
Date: Thu Nov 29 21:46:05 2012 +0530
xlators: Add Block Device(BD) backend translator
Add a new server storage xlator 'bd mapper'. Intention of this xlator is
to add block device backend support to gluster. It exports block devices
as regular files to the gluster client.
The immediate goal of this translator is to use logical volumes to
store VM images and expose them as files to QEMU/KVM.
Given Volume group is represented as directory and its logical
volumes as files.
By exporting LUNs/LVs as regular files, it becomes possible to:
* Associate each VM to a LV/LUN
* Use file system commands like cp to take copy of VM images
* Create linked clones of VM by doing LV snapshot at server
side
* Implement thin provisioning by developing a qcow2 translator
As of now this patchset maps only logical volumes. BD Mapper volume
file specifies which Volume group to export to the client. BD xlator
exports the volume group as a directory and all logical volumes under that
as regular files.
BD xlator uses lvm2-devel APIs for getting the list of Volume Groups
and Logical Volumes in the system.
The eventual goal of this work is to support thin provisioning,
snapshot, copy etc of VM images seamlessly in glusterfs storage environment
BUG: 805138
Change-Id: I13b69d39d7fd199c101c8e9e4f2cf10772bdc3dd
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Reviewed-on: http://review.gluster.org/3551
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 9f9a0e4d16f8382ff1a79e30c36411e055934509
Author: Brian Foster <bfoster@redhat.com>
Date: Thu Nov 1 09:33:53 2012 -0400
afr: send unique dict_t instances to replicas in self-heal fxattrop
afr_sh_data_fxattrop() currently allocates and sends a single xattr
dict_t instance to each replica. The callback codepath references
the returned object in the self-heal in-memory state for the
particular replica. If storage/posix is in the same address-space
(i.e., running a single glusterfs client with a fuse->afr->posix
graph), the same object is modified and returned for each child,
causing corrupted in-memory state and afr xattrs.
Allocate and send independent xattr dict_t's for each replica. This
allows self-heal to work correctly in a single address-space
graph.
BUG: 868478
Change-Id: I42832e85b5d1abb6098c28944c717e129300109e
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4149
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 45643dae82d2b36999a50b1bdb0ed3a74629e895
Author: Brian Foster <bfoster@redhat.com>
Date: Thu Nov 1 09:46:12 2012 -0400
afr: handle short writes in afr_writev_wind and self-heal to avoid corruption
The current failure to handle short writes on writev fops leaves
us open to file corruption. A short write on a user request is
ignored and leaves replicas in an inconsistent state. A short write
during a self-heal is ignored and incorrectly marks the files as
consistent if the heal completes.
Modify user writev handling to return the best case return value
from each of the replicas. Short writes that occur relative to this
value are marked as failed and will require a heal. Modify
self-heal to set an error on a short write and abort the heal.
BUG: 853690
Change-Id: I18b30f58702326249230eeebb361b29e40b535f5
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4150
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4cbcc29157af112452d3dde10161a5c6fdcb0348
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Nov 27 12:05:28 2012 +0530
cluster/dht: send ACCESS call on dir to first_up_subvol if cached is down
Change-Id: I4f518a969bbe3a11075e7c9ae10bd21bf059d5f3
BUG: 867253
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/4240
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 54e6bc046352c1667a7c39d1a3d5bb966587cdd4
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Oct 30 15:54:05 2012 +0100
geo-rep / gsyncd,glusterd: do not hardcode socket path
... in gsyncd python code. Indeed, use the configuration
mechanism to set it suitably from glusterd.
Change-Id: I9fe2088b14d28588d1e64fe892740cc5755b8365
BUG: 868877
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/4143
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 913768504e826b458f094626b928d891c9a8e254
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Aug 23 15:32:33 2012 +0530
glusterd, cli: implement gluster system uuid reset command
A commonly faced problem among glusterfs users is: after a fresh
installation of glusterfs in a virtual machine, the VM image is
cloned to make multiple instances of the server. This breaks
glusterd because right after glusterfs installation on the first
boot glusterd would have created the node UUID and this gets
inherited into the clone. The result is wierd behavior at the time
of peer probe where glusterd does not (yet) deal with UUID
collisions in a user friendly way.
To handle it gluster peer reset command is implemented which upon
execution changes the uuid of local glusterd.
Change-Id: If207dd2ad93ab94ef1a3253f409c21c442975f87
BUG: 811493
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/3637
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c7a155f77c55e4879fbdf20635f7092cad424620
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Nov 26 13:09:44 2012 +0530
glusterd: Protected conf->xprt_list racy access.
- epoll on RPCSVC_EVENT_ACCEPT would add corresponding xprt
onto the xprt_list. Concurrently, synctask thread (volume op)
would call into glusterd_fetchspec_notify which iterates on
the xprt_list. Added a mutex to protect such a racy access of
the list.
Change-Id: Idc51b4bdb1c814dfab7790e1c899d6977f7640f2
BUG: 878873
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4241
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d5e77c232d3dee11a031e3d73f7bbbf7f82fd421
Author: Avra Sengupta <asengupt@redhat.com>
Date: Fri Nov 23 14:26:10 2012 +0530
libgfapi: "tcp" is documented as the valid transport type instead of "socket".
Change-Id: I066e9be7755a535f385c102cdd1822adeda7f319
BUG: 860203
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4226
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b2b0d031e524ed71d723ba5fd6302c9d336c39d4
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Nov 26 17:44:36 2012 +0100
geo-replication: catch select.error on select()
tailer() in resource.py does not correctly catch exceptions from
select(). select() can raise an instance of the select.error class and
the current expression only catches ValueError (and the instance will
have reference called selecterror).
The geo-rep log contains a call trace like this:
> E [syncdutils:190:log_raise_exception] <top>: FAIL:
> Traceback (most recent call last):
> File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 216, in twrap
> tf(*aa)
> File "/usr/libexec/glusterfs/python/syncdaemon/resource.py", line 123, in tailer
> poe, _ ,_ = select([po.stderr for po in errstore], [], [], 1)
> File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 276, in select
> return eintr_wrap(oselect.select, oselect.error, *a)
> File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 269, in eintr_wrap
> return func(*a)
> error: (9, 'Bad file descriptor')
BUG: 880308
Change-Id: I2babe42918950d0e9ddb3d08fa21aa3548ccf7c5
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4233
Reviewed-by: Peter Portante <pportant@redhat.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 219ad9cb870da0e732163df86bd1e1caa4c26ddc
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Nov 19 16:29:44 2012 +0530
protocol/client: add an option to filter O_DIRECT flag in open
with the option, the idea is all client-side caching will be disabled,
where as on server side process, the fd will be treated as a regular
fd, thus helping the performance better.
"gluster volume set <VOLNAME> remote-dio enable" would set
this option in client protocol volumes.
Change-Id: Id2255a167137f8fee20849513e3011274dc829b4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 845213
Reviewed-on: http://review.gluster.org/4206
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit ee18f8e9cd864d7fca6338c22b3cadebc0424135
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Oct 30 10:23:20 2012 +0530
glusterd: volume-sync shouldn't validate volume-id
- volume sync would overwrite volume information on local node
from the hostname supplied. This warning is provided to the user.
- Also fixed a double free in volume-sync handler.
Change-Id: Icc68d9d563fb50ca58d5880921f063692e1e6882
BUG: 865700
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4188
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 04edcedc08e5813e7ac8b5fc393681c22081ae2c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Oct 17 16:10:28 2012 +0530
features/locks: implement fgetxattr and fsetxattr
implement xattrs for GF_XATTR_LOCKINFO_KEY, which will be used
for posix-locks migration from old to new graph after a switch.
fgetxattr (fd, GF_XATTR_LOCKINFO_KEY) will return a dict.
This dict has a serialized dict stored for key
GF_XATTR_LOCKINFO_KEY. This serialized dict in turn has fdnum
value of locks acquired on this fd with modified pathinfo
(containing hostname and base directory components) as key.
fsetxattr (newfd, GF_XATTR_LOCKINFO_KEY, dict) has following
semantics. dict can be the result of a previous fgetxattr with
GF_XATTR_LOCKINFO_KEY. In that case, a dict_get on dict
constructed using serialized buffer is done on modified pathinfo
as key. If a value is got, that value is treated as fdnum and for
every lock l on newfd->inode we do,
if (l->fdnum == fdnum) {
l->fdnum = fd_fdnum (newfd);
l->transport = <connection identifier of connection on which fsetxattr came>;
}
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: I73a8f43aa0b6077bc19f8de52205ba748f2d8bbe
BUG: 808400
Reviewed-on: http://review.gluster.org/4120
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit e92db119f18c76f2e4dab2602db4e4fe048c6b0d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Nov 20 12:30:13 2012 +0530
mount/fuse: add test cases for lock migration
Change-Id: I1a48c63387c7803b36584070fd8f3684ccb696b1
BUG: 808400
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4209
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit afd3e9e31d45315051b9df558121928b399d7872
Author: Raghavendra <raghavendra@gluster.com>
Date: Tue Oct 23 13:16:42 2012 +0530
cluster/stripe: handle GF_XATTR_LOCKINFO_KEY in f(get)(set)xattr
Change-Id: I4463006a7f54c05e757d877c56e1330fd91aec45
BUG: 808400
Signed-off-by: Raghavendra <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4125
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 195733802e57f0fbb98e98e1787b6bd825dd0d62
Author: Raghavendra <raghavendra@gluster.com>
Date: Tue Oct 23 13:15:15 2012 +0530
libglusterfs/mem-pool: implement gf_memdup
Change-Id: I1d7a1e7418f424fe08c041d562098b947c01580f
BUG: 808400
Signed-off-by: Raghavendra <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4124
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit bcd04981393e7567f4da753a7182ad7567b807f6
Author: Raghavendra <raghavendra@gluster.com>
Date: Tue Oct 23 11:32:33 2012 +0530
cluster/distribute: send getxattr on LOCKINFO to only cached subvolumes.
lk is sent to only cached subvolume. Hence there is no point in
sending LOCKINFO to other children (even in case of directories).
Change-Id: Ia20fc358dfa84cee9a52d1f613564ff6f25aa0c9
BUG: 808400
Signed-off-by: Raghavendra <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4123
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 81f494f8cbf24c8ee0cbb63f977e3c24e274bdd7
Author: Raghavendra <raghavendra@gluster.com>
Date: Mon Oct 22 17:20:26 2012 +0530
mount/fuse: migrate posix locks after a graph-switch
Each posix-lock is associated with an fd and a transport.
After a graph switch, this lock-state has to be associated
with new fd and transport corresponding to new client graph.
Change-Id: Ia0855e15600c85ef902bf612738f7d96557145be
BUG: 808400
Signed-off-by: Raghavendra <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4122
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2287f3586187061bdaf2d6f941d867d230e5a3f1
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 18 10:20:09 2012 +0530
cluster/afr: handle GF_XATTR_LOCKINFO_KEY appropriately.
values from all children need to be aggregated into a dictionary
and serialized buffer of this aggregated dictionary has to be
the value of GF_XATTR_LOCKINFO_KEY in the dict sent as a result of
fgetxattr.
Change-Id: Ie877f7c637c07feaee4c44d7ef86aa967a17b7e7
BUG: 808400
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4121
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 210db4eff1b3fe0c2d889e3101f4cc9e825a1ea8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 28 11:50:18 2012 +0530
tests/bug-865825: turn stat-prefetch off before doing any afr self-heal related tests.
Change-Id: I5c45bb4f4d4aa59965c6dda34ab884071bef9c6f
BUG: 865825
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4242
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 434ee26af515c7921199d5bb088dd109c3703106
Author: Avra Sengupta <asengupt@redhat.com>
Date: Thu Nov 22 16:02:47 2012 +0530
cli: XML output for "gluster volume geo-replication status"
Change-Id: I1a64bd5eb9b1040a2a2d9b97bfe9cc756835596e
BUG: 864506
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/4227
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 95e4d4a60312140790f48826939701a696434bf1
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Nov 27 16:13:53 2012 +0530
tests: Replace mount -t glusterfs with glusterfs -s
Change-Id: I9aa9bd1efb9ae56caec0fee596b3f21ca496f66e
BUG: 863068
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4239
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 9452877b82834fb4e5bed09afc23b05f9d9dc6b7
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Oct 12 10:18:58 2012 -0400
replicate: don't stop checking xattrs because one was absent
The functional issue is described by the subject line. This patch also
addresses several efficiency/structure issues, such as...
* Calling dict_set_ptr once for each txn type, instead of once overall.
* Calling afr_index_for_transaction_type once per iteration instead of
once per call (or better yet zero since the conversion is unnecessary).
* Implementation of inner functions in a different file than their one
caller, creating a spurious header-file dependency.
Change-Id: I29e0df906a820533b66b9ced73e015dfe77267d2
BUG: 865825
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4070
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 41177d8539fedb7b786e1f558b315187921b8879
Author: Venkatesh Somyajula <vsomyaju@redhat.com>
Date: Fri Nov 23 18:12:52 2012 +0530
Cluster/afr: Fix output for gluster volume heal vn info healed
Problem:
Whenever gluster volume heal vol full command is executed, the entries
stored in the circual buffer for sh->healed are added in the dictionary
in the _crawl_post_sh_action function irrespective of whether actual self heal
(due to non-zero values in chage log) takes place or not.
Fix:
Value of key (actual-sh-done) will be set to 1 whenever self heal takes place
due to non-zero change log values and if for some FOP self heal daemon finds
that no self heal required after examining the pending matrix, the value will
be 0.
Change-Id: I11fd0b9ee76759af17c5bca6bfafbaf66bcaacbc
BUG: 863068
Signed-off-by: Venkatesh Somyajula <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4181
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d112f9debc3c35bab45052f7764611a56a832159
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Thu Nov 15 14:20:39 2012 +0530
nfs: avoid blocking lock calls in statedump code
This change replaces LOCK () with TRY_LOCK () in
nlm statedump code.
Change-Id: I28c558b68854cf08c3a8190a00d6e3d507317628
BUG: 843819
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4193
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6fbc53a079e331d23eda940e596063f8d574e3b0
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Nov 24 07:23:53 2012 +0530
tests: Add volume set tests for quorum
Change-Id: I83e0408d8fd01afe990ebf634a8a09ea0b8ea54d
BUG: 839595
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4229
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 523005b3d6fde08ca4a3764edb629f8ef20dc4ca
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Fri Nov 23 22:19:32 2012 +0530
tests: Add volume utils in a new file
Change-Id: Ie78d24ca466d4bddc5c0727ed8ed51707e1f2a34
BUG: 839595
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4228
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit fb202b779dc6c58930c83b7756eadc8ff9dc1c85
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Nov 6 12:18:24 2012 +0530
mgmt/glusterd: Implementation of server-side quorum
Feature-page:
http://www.gluster.org/community/documentation/index.php/Features/Server-quorum
Change-Id: I747b222519e71022462343d2c1bcd3626e1f9c86
BUG: 839595
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3811
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 8f7e6fbd8365aed7cc75bde8152dd26784009641
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Nov 6 12:19:47 2012 +0530
libglusterfs: Implement float percentage
Change-Id: Ia7ea63471f0bbd74686873f5f6f183475880f1a0
BUG: 839595
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/4162
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 83f4e5497bf969d4434c83ad2e00e133cd1dbe89
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Nov 16 13:48:58 2012 -0500
glusterd: fix use of undefined realpath(3) result
Change-Id: Ic50ae192c99cece25cd63f2277fb440fca5f0b04
BUG: 877522
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4201
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5a217ae3e7caec02fbf693adcf087fb95d3e191a
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sat Nov 17 11:59:39 2012 +0530
glusterd: brick path availability check only for local bricks
Change-Id: Ica50fb92608f5fd75f8887e0718177faf29d31c4
BUG: 877522
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4203
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 0ddaf9f1abb0d98654e58e0fc389fd77f864e014
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Nov 19 14:28:20 2012 -0500
socket: fix double-free when ssl_setup_connection fails
Change-Id: I893b166da28f4c21e582ed477399c4bc0c1d20e1
BUG: 877903
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4208
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 96da83ef8dc5b358b753695666eb78906a024f4d
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Nov 20 15:17:06 2012 +0530
cli: XML output for "geo-replication <VOL> {start|stop}"
Change-Id: I8d2213cc00deb458fb765b848d0e3452574cc98f
BUG: 864499
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4217
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4906c12dd139fa34071a00e80b4b3300a1da229d
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Nov 2 09:41:33 2012 +0100
Use more portable mkstemp() instead fo mkostemp()
mkostemp() with O_CREAT|O_EXCL|O_RDWR|O_TRUNC|O_APPEND is mkstemp()
and mkstemp() is available on more systems than mkostemp()
NULL-commit to cause jankins ro rebuild
BUG: 764655
Change-Id: I6ee0f635d3699bd70b0963b24af07bd7d5c2dc58
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/4152
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit bdb75c5b83d210adf2705a29bf06dc5894ee7f75
Author: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
Date: Wed Nov 21 17:33:04 2012 -0700
object-storage: Add a sorted list comparison to test
After the commit b0cb7aaf for bz#870589, which adds 2 tarballs
with layout patterns, Swift tests sometimes fail (depending on the
kind of filesystem they are running at and the phase of the moon).
As pattern tarball is unpacked, the underlying filesystem is free
to return directory listings in any order, and straightforward use
of '==' operator fails. As it turns out, one of the two comparisons
had set() applied to the list already. So, add it to the other one.
BUG: 874390
Change-Id: I02de99593b9567a13076113d58e242b079fde002
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-on: http://review.gluster.org/4165
Reviewed-by: Peter Portante <pportant@redhat.com>
Tested-by: Peter Portante <pportant@redhat.com>
commit 765fe684a09c99d4d6df839557928f5b017e69d5
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Nov 21 12:06:26 2012 +0530
gsyncd / geo-rep: include hostname in status cmd
Including hostname of the node where geo-rep start was
initiated from. This helps any consumers of the status
command to identify and possibly issue commands on those
node(s).
Change-Id: I005083878a3a4794da3b7f3f7d2cc9d28f004e3f
BUG: 858218
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/4218
Reviewed-by: Csaba Henk <csaba@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a97a46e5bc4e960e83a5ad1c1bb3674fec293c26
Author: Peter Portante <peter.portante@redhat.com>
Date: Thu Nov 8 12:31:10 2012 -0500
object-storage: del 1.4.8 ref from dir hierarchy
Remove the "swift/1.4.8" directory from the hierarchy, replacing it with "ufo".
Change-Id: I60ba171182d7402a2193616c1c95c90cd2ead5bc
BUG: 870589
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4200
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 87efbe4c65ce03dd4694af2decd14c6a3d0925d9
Author: Peter Portante <peter.portante@redhat.com>
Date: Thu Nov 15 17:36:13 2012 -0500
Don't ignore all files that match (*o|*la|*lo)
This has been hiding files in my tree, in particular, new directories that end
with an "o". I am guessing here that these are really trying to just ignore
.o, .la and .lo files.
Change-Id: Ic438ca5c43188a63e9840512825f9ba05c359eeb
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4195
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5de5684e5545e9da2b1e5104d2bd03f6bbde6dff
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Oct 22 19:19:50 2012 -0400
perf/io-threads: least-rate-limit least priority throttling
The 'least-rate-limit' io-threads translator option enables
throttling of least priority operations. This is initially intended
as a debug/diagnostic tool for users who might experience
overloaded servers via background activity (i.e., self-heal).
least-rate-limit defines the maximum number of least priority
operations the io-threads translator will dequeue in one second.
If the specified rate limit is met, the worker threads sleep for
the minimal amount of time before the next least priority operation
becomes available (or until a new request arrives).
The requests/second metric is generic and relative to a variety of
factors involved with a background operation (server, storage,
etc.). The most recent measured rate ("cached least rate") is added
to the io-threads state dump content (kill -USR1) to serve as a
reference point to throttle background activity under particular
conditions.
Change-Id: I80f2282992137d57b1becaa5c6ae3858c066862a
BUG: 853680
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4119
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e7ba88c7d072e3b1bd1d7d2b4d498f2f8864174a
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Nov 21 14:35:10 2012 +0530
cluster/afr: check transaction type for eager-lock after it is set
Problem:
Eager locking lk-owner decision is taken before transaction
type is set. Default transaction type is DATA so all transactions
are treated as DATA transactions at the time of eager-locking
decision.
Fix:
Move the code that takes lk-owner decision after the transaction
type is set.
Test:
Checked that the transaction type is set properly in gdb at
the time of the lk-owner decision.
Change-Id: I7607c7ff4f88c7ced5416a1cddb6586cf45d88f9
BUG: 861335
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4220
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2fc02d4f18b3e13e26b54f84c84ed23a449c0920
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Oct 29 12:41:03 2012 +0530
libglusterfs: implement gf_strndup
Change-Id: Ifb7bf22e8cf4ad1faccf7999c36919693912093f
BUG: 808400
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.org/4135
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b1b532747ae73c43c16ca62a177d3ee3499d5198
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Tue Nov 20 23:18:10 2012 +0530
Put _check_key_is_zero_filled outside _xattrop_index_action
Change-Id: Ifb89a3a911213b2816a540a104558e7c3c13e23a
BUG: 874498
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4182
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7b27e2cf9795e112a0a186453ae7442fb29f4cca
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Sat Nov 17 01:36:13 2012 +0530
posix: Fix volume will not start if brick has no volume-id attribute
Problem:
If the extended attribute (trusted.glusterfs.volume-id) of a brick is
absent and <gluster volume start volume-name> command is executed then
curretly volume-id from the volume file will be set as an extended attribute of
the brick and volume will get started.
But if setup is such that brick is used as a mount point and before
executing the <gluster volume start volume-name> command, nothing is mounted on
the brick then all the file operations will take place at the brick but actual
intention of the brick is to be used as mount point only.
FIX:
Do not start the volume if extended attribute (trusted.glusterfs.volume-id)
is set absent.
Change-Id: Id2462d87d6087e97e0b8831512fdbc3595f7078b
BUG: 860297
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4202
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a765e8826766d81582bcce370b45025cd4ff0248
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sun Oct 28 07:31:20 2012 +0530
storage/posix: Make rchecksum O_DIRECT friendly
Problem:
When posix-aio is enabled to perform aio fd is set with O_DIRECT
whenever possible in read, writev fops. Rchecksum does not take
this into account. If either offset/size/memory-buf passed to
pread in rchecksum fop is not aligned, pread fails with EINVAL.
Fix:
Before doing pread necessary O_DIRECT manipulation is done when
aio is enabled. Memory buffer passed to pread is now page-aligned.
Test:
1) Create replica volume with aio enabled.
2) dd if=/dev/urandom of=a bs=1M count=1
3) kill one of the bricks in the replica pair
4) dd if=/dev/urandom of=a bs=1M count=1
5) bring back the brick. Self-heal succeeds after the change.
The test above checks both rchecksum, writev fops that were
changed in this patch.
Change-Id: I186099a2854d4864c5b48086ab7bc5f1a7b27313
BUG: 866459
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4134
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 570413212f5e056a880d2994aba260fc9a5673a6
Author: Brian Foster <bfoster@redhat.com>
Date: Thu Nov 1 10:53:43 2012 -0400
debug/error-gen: add the short write pseudo-error
Add a separate enum for pseudo-errors in the debug/error-gen
translator and include a short write error. The short write error
causes writev requests to return with some non-error value less
than the size of the write request.
BUG: 853690
Change-Id: I50b7d328386a8b78d03ce91b4c2ec83e0d32c9aa
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/4148
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7153158c9d1faa9ff4bc249200e8bf640b81a535
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Oct 23 09:18:52 2012 -0400
tests: make _EXPECT handle more cases
First issue is that _EXPECT wasn't handling args with spaces correctly. This
was fixed by enclosing the entire expected-value expression in double quotes
with a simple backslash escape for the end-of-line dollar sign.
Second issue is that we were throwing away potentially useful debug
information. Fixed by using egrep's -q option to suppress output, and
eliminating redirections so that we can see any stderr output related to a
script error.
Change-Id: Ide3f49558dcece55bd90cad50b1ffc572592f11c
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4126
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit 58e7e8a8bb160988b76cb677e2c78edb8945c344
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jul 24 07:08:08 2012 +0530
cluster/dht: dump the layout information of directories only
testcase:
The changes are for removing gf_log from statedump related sections in dht and
using pthread_mutex_trylock in statedump sections. Changes are internal. So
tests were done by attaching gdb to the process and executing by manually
changing the values of some of the pointers.
Change-Id: I41fa76c1812b462cb76f5bbf2fd14de080e73895
BUG: 843822
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4117
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6d9fe73b5e380af6e0c5c61699678772eba7e4e0
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Nov 19 12:01:09 2012 +0530
nfs: after resolving the entry use the linked inode instead of old inode
Change-Id: I56add0c3c852d096ec70a0e35610f46c2d12980a
BUG: 877885
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4205
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 42ff8ee0acb3e1c3de9a003e52d0a4351b72438e
Author: Anand Avati <avati@redhat.com>
Date: Sat Oct 20 00:14:13 2012 -0700
fuse-bridge: fix posix-only configuration
Recent changes in fuse-resolver had broken the use case of having
a trivial configuration with only storage/posix translator. Fix
it and include a regression test to avoid breakage in the future.
Change-Id: I85cbcac4b5c2d3517dd03fd3dc6d07610697981b
BUG: 868478
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4114
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 87dfaab05d6861deea424bb2b300f26485c73745
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Oct 31 14:13:14 2012 +0530
glusterfsd: log all command line options in log file
this would help support to make sure the glusterfs process
received all the required options, as not all the options set with
'mount -t glusterfs' will be visible with 'mount' command.
also one need not bother checking 'ps ax | grep gluster' for getting
all the details of the command.
Change-Id: Idf635904074bc0892abb6b707ff91149e92a33e3
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 871063
Reviewed-on: http://review.gluster.org/4146
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 88f3ddd1d4d5f79df4af7ff69500a6c5dfe6728c
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Nov 9 14:43:38 2012 +0100
fuse: handle mountflags properly
The internal mount API had no access to the generic
mountflags used by mount(2).
Thus the "ro" mount option that needs to be passed down to mount(2) as
as a mountflag was incorrectly mangled into the fuse-specific mount
parameter string (cf. http://review.gluster.com/655).
This commit fixes the internal API and the "ro" issue. It also adds a
check for the "rw" and "ro" mount options in tests/basic/mount.t.
Thanks to Csaba Henk (csaba@) for suggestions and proposing an updated
patch.
Change-Id: I7f7bf49ae44d148f5c16f10736a0e412fb8f5e67
BUG: 853895
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4163
Reviewed-by: Csaba Henk <csaba@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 27abe7cc3a3d0dcc5ab03903f9d15a6e7e9e440f
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Oct 17 22:20:47 2012 +0530
glusterfsd-mgmt: make brick-ops work in synctask
this way, the main epoll thread is freed up to serve other requests.
Change-Id: Iecf68aceb8bd84433d0f9fcd98d96c734a4cc134
BUG: 842955
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/4096
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 78228b6b881d0b4a2a70bdf55b7904cb37c02c3c
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Nov 7 12:55:08 2012 +0530
features/locks: fcntl(3) on F_GETLK must return first conflicting lock
- Added test program, getlk_owner.c to capture the bug when regressed.
Change-Id: Ic2a0f6fa8d094c0f2e9f4a6febd278d4a2948223
BUG: 869724
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4164
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b3398ea33dd82382c25f35b62a4f9c9f8b3c0d8f
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Oct 15 23:15:18 2012 +0530
glusterd: copy peers that participate in volume xaction
- To avoid working with a mutable list of peers in
the scope of a volume xaction.
Change-Id: I228ae96bccdce127026eff8320adb37b17e2cc6a
BUG: 862834
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4113
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 561a589cab38cc34cfa6e65b8abebbc0a8fda4d0
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Fri Nov 2 16:09:13 2012 +0530
nfs: do not change root inode if enable-ino32 is set
When a user sets nfs.enable-ino32 on,
the root inode, which must be 1, is jumbled during
hashing of the gfid into 32 bits.
This patch avoids doing that, and returns inode of 1
for the root inode.
Change-Id: Ib65f2660998a95e1059be32bc298485c5cbe52df
BUG: 864222
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4154
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dbe32ba3e5eb99b5b6cae3160a9d65176ec5fb6f
Author: Peter Portante <peter.portante@redhat.com>
Date: Thu Nov 8 01:16:56 2012 -0500
object-storage: final changes to remove swift diff
Final set of changes to remove the diffs carried to make UFO work with
OpenStack Swift. The code is now a complete layering on top of OpenStack Swift
where we either "monkey patch" or subclass as necessary.
See BZ 870589 (https://bugzilla.redhat.com/show_bug.cgi?id=870589).
There are a lot of changes here due for the most part to rearranging the
directory hierarchy to have create a proper python module hierarchy under the
"gluster" namespace. Plugin references have been removed. The differences that
used to be in the swift.diff file are now replaced with server implementations
for account, container, object, and proxy that subclass the swift versions.
Additionally, the plugins/conf directory has been moved to the "etc"
directory, and the plugins/bin directory promoted a level.
Unit tests pass.
A new setup.py file is provided so that the install process can use it for
creating all the necessary python install infrastructure (eggs and paste
support).
A new RPM spec file is provided which to properly install the new code, and
the sample configuration files have been modified to reference the new python
egg.
Change-Id: I4316c1b66dca80f847fe9b0d583174689c175599
BUG: 870589
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4180
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit f8d5a8ce68e0c968532a94e334a38bdd055974c5
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Nov 7 12:37:26 2012 -0500
object-storage: refactor to use swift devices
Refactor code to use the devices configuration file setting for account,
container, and object servers, dropping mount_path from the fs.conf file, and
constructing new account, container and object server rings.
This removes the next to last set of diffs in the swift diff file. See BZ
870589 (https://bugzilla.redhat.com/show_bug.cgi?id=870589).
The key to the change is the dropping of the pre-built account, container and
object rings, instead providing a script that will generate them for the user
given the gluster volume name in use. In addition, we override the Swift
check_mount() method and replace it with Gluster's which attempts to
"auto-mount" if it is not already mounted.
The following is an enumeration of the changes contained in this refactoring:
* The refactoring to override the Swift check_mount() involved condensing
a lot of code, removing redundancies and simplifying methods across a
number of modules
* Drop checking the mount point in the low level DiskDir, DiskAccount and
DiskFile objects now that Swift's normal mount checking is used, and
enable it by default in the template configuration file
* Add missing get_container_timestamp() method for DiskAccount objects
* Fix the plugin RPM spec file to provide the new ring builders, and while
we were at it, finally fix the over-writing of the configuration files
on install
* Bug fixes
* The monkey patched version of check_object_creation was not working
correctly due to a missing import of HTTPBadRequest and a bad
reference to validate_obj_name_component()
* Only have the utils module import the plugins constraints module for
the side effect of monkey patching if gluster is enabled
* Removed the db_file.db file in the tree since it is created on the
fly
* Updated 2011 copyright notices to 2012
Change-Id: I8f4454576b1423021c9bbf3c36176f8db51e62c0
BUG: 870589
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4179
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
commit cff4e4e9b0a98dbf002c1ad0270eaa0f614aa1dd
Author: Peter Portante <peter.portante@redhat.com>
Date: Fri Nov 2 10:49:14 2012 -0400
object-storage: make proper refs to module vars
Not sure how this worked before this, but mount_ip and mount_path do not
exist, their uppercase versions do.
Change-Id: I53e9b550991d17b5541ed4ada5f1bc9b3cb1b8b1
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4178
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 26985014b8fabb1164a17e4789c7e5d99d90fdbb
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Oct 31 20:28:42 2012 -0400
object-storage: reduce diffs, bury metadata update
Further reduce the diffs we have to carry by moving the Gluster specific
metadata stored when we create an object to the DiskFile class's put() method.
Change-Id: I8cef5412627d3ddfdadbf78ef947e067db5bf620
BUG: 870589
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4177
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
commit 3400a0257347a55f23f3fb5a56f21f5b6b47c78b
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Oct 31 17:16:07 2012 -0400
object-storage: swift-diff removal: hide obj only
Towards swift-diff removal: hide object_only behavior inside DiskDir class
objects. See BZ 870589 (https://bugzilla.redhat.com/show_bug.cgi?id=870589)
One of the last few reasons for having the swift diff is the need to update
the account and container information from the file system when the
configuration is not for object-only use (meaning, other updates to the file
system can come from clients other than UFO, which means UFO currently has to
generate the necessary metadata for each request instead of caching it).
This change moves that logic into the DiskDir class methods so that the
container and account server code does not have to track that.
Change-Id: If0970c77c72245facd09c2035083e681d6d80303
BUG: 870589
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4176
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
commit c2f025bf039a03a6a5e765314f0ce6c036ed181c
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Oct 31 06:51:54 2012 -0400
object-storage: fix trailing whitespace
Change-Id: Ib3c671e693c2c332af98a593ca14c42c36f5ca76
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4175
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 2170e41287cb4dc6e7da89592c743a580685c906
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 29 20:51:12 2012 -0400
object-storage: remove the device and part params
Change-Id: I60b4b1b976ad8359ba072d5d0ed6a8dd2087a738
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4174
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 476ca3f484aec19f648a51bf127014794734161b
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 29 20:43:02 2012 -0400
object-storage: only update metadata that changes
See BZ 868120 (https://bugzilla.redhat.com/show_bug.cgi?id=868120)
Change-Id: Ia7f5562cff32eee30c5ca18652d5d9a5a2b18bf4
BUG: 868120
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4173
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit cb6fd92f703a5be3e657bbbb181438d05c78d313
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 29 20:19:07 2012 -0400
object-storage: DiskAccount subclassing of DiskDir
Changes to make DiskAccount subclass DiskDir complete. This change helps
reduce the diffs ahead of further refactoring. Note that DiskDir initializes
all the same fields as DiskAccount, plus a few more, and ends up reading the
metadata properly, while only adding a couple of fields not used for account
purposes.
This change also passes the account controller's logger for use by the
DiskAccount class.
Along the way we:
* Remove the redundant update_account() method in the DiskCommon base
class, since the update_container() method in DiskDir performs the exact
same functionality
* Remove the initialization of variables ahead of assignments in two
cases, and also move the initialization of the list variables closer to
where they are used
* Collapse the imports from swift.plugins.utils into one statement
* Use a temporary directory for the db_file.db when we find ourselves in a
unit test environment
Change-Id: I4dc59b416a66393adfe0ed32c7a62c79731d70c0
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4172
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Tested-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
commit 91e6e068cd06caa4ceaeb7660e5b5dd0bd7b63df
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 29 19:49:42 2012 -0400
object-storage: fix bad refs to check_acct_exists
Fix bad references to check_account_exists: this is a module local method, not
provided by Glusterfs. Not sure how we missed this. More unit tests would
help.
Also added the ability to run the Swift tree unit tests with gluster
artificially enabled to test as many code paths as possible ahead of full
functional tests.
Change-Id: Iaf696d34db8f841c887f03569e65321fca8894d1
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4171
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 021d9e798ee30c5b106b0069d33fb8a39708baa4
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 29 19:47:57 2012 -0400
object-storage: fix bad refs to REMOTE_CLUSTER
Change-Id: I07cd997ef9a98645a87792632f9dd612928678b7
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4170
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit ed6b0c5758b6ccd2c53ed15d2d1a3081e194ad42
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 29 15:47:09 2012 -0400
object-storage: rename self.name to self.container
Minor refactoring ahead of further diffs to add clarity to the code.
Rename the DiskDir field from "name" to "container", which is what it is.
Along the way, add a note regarding the one-to-one mapping of account name to
gluster volume name, and fix the get_info() container method documentation to
list all the dictionary keys returned.
Change-Id: I659e1a9a070c16671287f17a170f9d77198534e7
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4169
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 6292a51a4b1bf32de879d78903162d34f278a7f7
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 29 15:19:05 2012 -0400
object-storage: unused parameter cleanup & handl'n
Unsed parameter cleanup and handling changes. The device and partition
parameters are not used. The account parameter is used in place of the device
parameter. Rather than just making the device parameter reference the value of
the account parameter, we just don't use the device parameter at all and make
references to account. We also remove the device_path field from the class
since it is unused.
Additionally, we assert that we have a logger since the rest of the relies on
that fact.
Change-Id: Iea556319744ab4f729b1ce23d987650a164749db
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4168
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Tested-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
commit 85cd78c44f040bb574e364e8bd1e64b6b6aef5cc
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 29 14:56:55 2012 -0400
object-storage: add missing docs for params
Add missing documentation for constructor parameters.
Change-Id: I3a656cd22f6a2a61e0b4d563c75c2f7fe68d3c54
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4167
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit bfe72e9d38ee586732de6b039a7b6936ce65cc45
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 29 14:39:44 2012 -0400
object-storage: minor code cleanups
Apply a few minor code cleanups to help reduce future refactoring diffs.
* Remove extra lines between methods so that all methods are consistently
spaced by one line
* Remove unused field meta_file
* Add missing documentation for uid and gid parameters
Change-Id: I0a38eb06680eb0709edfaa1828d09657823f778e
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4166
Reviewed-by: Pete Zaitcev <zaitcev@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 4e27da8335572cfc00f432de4f46423237c2e66b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Nov 14 14:58:09 2012 -0500
build: fix missing include (from missing backslash)
Caused by 1c4cb5237701bb138f9cce29036773086253f839.
Change-Id: I9574b2316af6a5a0d59b5d80578016dfd5fc1ac9
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4191
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 68068fa45f954e840475a9fbe34a781e6372c114
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Mon Nov 12 09:58:02 2012 -0500
NFS is picking up geo-rep's already open (read-only) file descriptor
Add anonymous member to fd_t and use it instead of over-loading pid for
geo-rep and self heal
Change-Id: I4d6b29a044a8ed4b8f69ff6e3f35ee227739b2af
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
BUG: 874272
Reviewed-on: http://review.gluster.org/4185
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 33634432eaedaf3e02e22d62cbafa0234ef89925
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Wed Sep 12 12:36:49 2012 +0530
ACLv3 - Access Control Lists V3
Change-Id: I43e544d6cdeac5e3880141477461e7c22cbf6e91
BUG: 847622
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.org/4045
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7e8633ddbc346fb0bdaa54f93b5ead8a7dc4ce64
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Nov 5 10:43:12 2012 +0530
glusterd: Add missing options to vme table.
Change-Id: Ifa48cb2c26dbbabe619e1bfbd41d9ecdce1150aa
BUG: 814534
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/4155
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b130d8e5b920a1a0dcfb23a9bbd317c03125ee62
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Nov 5 16:39:37 2012 +0530
nfs: resolve parent inode during inode_loc_fill
This commit resolves the parent inode in nfs_inode_loc_fill
if the inode has a resolved path.
Change-Id: If407c91c246b0b9f3349cedae0baec8bd6831d10
BUG: 872923
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.org/4157
Reviewed-by: Krishna Srinivas <krishna.zresearch@gmail.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit abb8cd0861a0662b231fffa9394aba1c1c756e0c
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Nov 5 11:24:57 2012 -0500
socket: fix SSL breakage from re/connect handling changes
Change-Id: Ia1f5aeec5628b61cad8a10a9cdc6d9f1c67ec653
BUG: 873367
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4158
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b2181638b68dcafcbe507f28dca09437dedaefcd
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Oct 15 17:04:29 2012 +0530
glusterd: Fixed glusterd crash in volume add-brick
PROBLEMS:
a. glusterd crashes when add-brick operation fails on the machine other
than the originator, owing to double free done on op_errstr:
once in glusterd_op_begin_synctask and once through a dict unref on
req_dict in gd_sync_task_begin.
b. In gd_sync_task_begin, there's no need to place the error string
in the dictionary, when it is never retrieved and used elsewhere.
c. Command execution status is not logged into .cmd_log_history.
FIX:
For (a) and (b): Knocked off code that places the error string in req_dict.
That way, both the problems are solved.
For (b), passed op_ctx to glusterd_op_send_cli_response as it is needed to
extract the command string before logging.
Change-Id: I549a07ba5e31332b691a8cacd1ab32c2673810ba
BUG: 862834
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4102
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 140f31da1d99a82f273f33f3749457b9a2db0160
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Aug 9 17:09:19 2012 +0530
xlator/fuse: integrate fuse with event-history
use event-history framework for saving and dumping (on necessity)
important xlator specific information.
Tests:
Included the regression testcase.
Change-Id: I6c0532e9ffe0b624286cdc4d2637b1bd2c0579e0
BUG: 858215
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: root <root@thinkpad.(none)>
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/3925
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit f60881c092a718bfe3b92f47e7e5dc0299e2295a
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Oct 29 16:21:24 2012 +0530
features/quota: Failure of quota commands if the dir-name contains ':' in it
PROBLEM:
The first colon in the limit string is used to separate the path and the
limit-value. The ':' in the path was the source of problem.
FIX:
Search for the last colon and separate based on the same.
Added regression test.
TEST:
Create and set quota on directories with names containing ':' in start, middle
and end.
Change-Id: I363c8ad4cbfd02c23fc73974bef9aa8bc362d29c
BUG: 848251
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/4137
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit c2f3ed50cb10b0153c869c663a5a398f2dccb162
Author: Peter Portante <peter.portante@redhat.com>
Date: Sat Oct 27 00:10:47 2012 -0400
object-storage: remove glusterfs filter requirement
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=870589
Remove the Glusterfs object, transforming it into a module providing module
data fields (like swift.common.constraints) and module methods for
mounting/unmounting and access the gluster volume information. As a result, we
can then remove the glusterfs filter from the pipeline since we no longer need
to provide the Glusterfs object through all the plugin code paths.
This is one more step closer to removing our dependency on modifying the Swift
code directly with these changes. See It is also the first step to acknowledging
that we are not a plugin, but a layering on top of Swift.
The major piece of work here is based on a recognition that the
plugins/Glusterfs.py module provided a Glusterfs class that instantiated
instances of an object that always contained the same data from the
configuration file. The fields of such an object were not being changed and
were treated as read-only in all cases. Since the object's data was the same
for all instantiations there was no need to pass the data from the glusterfs
filter all the way down into the bowels of the Gluster_DiskFile and DiskDir
objects.
Taking advantage of the nature of that data, we now just have those fields
read into module variables, and change the Glusterfs object methods into
module level functions. Much of the changes result from the consequence of
making that switch from object to module.
Here are a few other changes made along the way:
* Bump the release numbers in the spec files in recognition of these changes
* Create the plugins/fs_utils.py module so that the methods in the
plugins/Glusterfs.py module don't have to include plugins/utils.py, which
would create a circular dependency
* Note that this dependency comes from methods in plugins/utils.py
depending on the module level constructs in plugins/Glusterfs.py so that
we only store those values in one place
* Changed plugins/DiskDir.py:DiskDir class to not check for, and/or
optionally create, the /etc/swift/db_file.db at run time, just create it a
module init time
* Removed the duplicate strip_obj_storage_path() from plugins/DiskDir.py and
utils.py and move it to the Glusterfs module
* Used os.path.join in plugins/DiskDir.py where possible
* Renamed the .conf files to .conf-gluster so that we don't clobber existing
config files
* This is not a complete change, as the spec file also needs to be
modified to avoid the clobbering
* See also https://bugzilla.redhat.com/show_bug.cgi?id=865867
* Removed the redundant DIR_TYPE definition in plugins/utils.py
* Removed MOUNT_PATH from plugins/utils.py replacing references with that from
Glusterfs
* This actually fixes a bug if a user every used a different mount path
from the default in fs.conf
* Added ASYNCDIR definition to plugins/utils.py until such time as another
refactoring can rely on the one from swift.obj.server
* Renamed plugins/utils.py's plugin_enabled() function to Gluster_enabled()
* The diffs we carry for Swift are now a bit smaller in that we no longer
have to add the plugin() method, we don't have to keep a fs_object field
in these objects, and we can reference the Glusterfs module directly
* Unit tests were modified appropriately, but now need to be run in the
context of a Swift tree; this is unfortunate, but further refactoring will
address this
Change-Id: Id5d2510d56364761c03b3979bc71187dbe2f82fe
BUG: 870589
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4141
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit 922cdd45ffade85613c904d4faf0e6dfd6889d88
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Nov 2 09:15:36 2012 +0100
POSIX sh uses = and not ==
BUG: 815227
Change-Id: I5a498f1b917fb658914133ee071783e7b8e0d025
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/4151
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 76e5e928b0c0d6e4fa2c46b69de6bc7868e94abe
Author: Anand Avati <avati@redhat.com>
Date: Wed Oct 3 17:48:38 2012 -0700
api/examples: updated examples to use new calls
Change-Id: I865d0c52de268b27bbdb8786d3f4af5ef3ce3d9a
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4023
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3350926c402cbca25f89d0464a45f5f0014d6271
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Oct 24 10:30:56 2012 -0400
object-storage: use constants for directory names
Change-Id: I6109ee55061eae53c4c6762ca31fb5c4b13f0071
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4140
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Vijay Bellur <vbellur@redhat.com>
commit ed0761f8e91c73f059d5114fca267530c4647e14
Author: Peter Portante <peter.portante@redhat.com>
Date: Tue Oct 23 11:47:44 2012 -0400
object-storeage: refactor to use one memcache key
Address BZ 868087: https://bugzilla.redhat.com/show_bug.cgi?id=868087
Store all of the data needed to generate the correct set of container and
account details in one object, respectively, rather than using three seperate
memcache keys.
Change-Id: I46bf60c405b37cdb22727965bfd67bc5c410e77c
BUG: 868087
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4139
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 74c003397324851fa0a85a1a0f7d84e2c24d7dcf
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Sep 3 16:51:06 2012 +0530
glusterd: 'volume set' changes for op-version support
An op-version check is performed for the given keys during stage. The commit
phase moves the cluster op-version to the required version if needed.
Change-Id: Id5c387094dbec723df736b2ecdc49ff93c179e0e
BUG: 814534
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/3780
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 224b504ec6ca3cea7e0a3a56f2fc099b80d3ef36
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Oct 22 10:18:32 2012 +0530
cli: Mark port as N/A in volume status when process is not online
Change-Id: Ie11c7331e3bc58c0f934f424dde4341cdffb9e2c
BUG: 861542
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4048
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit b72857dfef13b260c93b08be55cd005054945908
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Sep 3 15:58:26 2012 +0530
glusterd: op-version handshake implementation
Brings in a new rpc program MGMT_HANDSHAKE, which implements the op-version
handshake. This is required for bringing in the op-version feature as described
in http://www.gluster.org/community/documentation/index.php/Features/Opversion
Change-Id: I4333fd2714dbbd3a2a3fca5862cbb3c56615529e
BUG: 814534
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/3688
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 98888c7956ab578a038e68a5b127e088999a16f2
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 22 13:59:31 2012 -0400
Minor refactorings to mark an internal routine
Just a couple of changes to mark a routine as internal to this module (leading
underscore, helps understand what is part of the utils API and what is not),
and use of the positional argument for memcache for consistency and reduction
in line count (doing this ahead of another refactoring to keep changes
concise).
Change-Id: I71581ad6ac4c383b1de787b767be568fc0a87eef
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4138
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7669c0ee3974854f5e94d7695d7361cd4331eb09
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Wed Oct 17 16:45:45 2012 +0530
protocols: Suppress getxattr log when errno is ENOENT
Change-Id: I3f4fe3f382aec5fd142cc409b80bd73aebd8b39b
BUG: 861015
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4097
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 1b45bd12c4d89db1d878393862f7ce174b6f680b
Author: Peter Portante <peter.portante@redhat.com>
Date: Fri Oct 19 01:35:46 2012 -0400
Reduce the number of stat/fstat system calls made
This address BZ 868086, https://bugzilla.redhat.com/show_bug.cgi?id=868086
This refactoring consolidates the code a bit, and uses os.stat calls to get
all the information in one call when gathering the metadata for an object. The
five stat system calls (invoked via all the os.path.*() calls) have been
reduced to one.
We also added a unit test for the one new behavior where get_object_metadata()
will now throw an OSError exception if it has a problem stat'ing a file that
exists.
Change-Id: Iad5410c77938af68a47be757a3170abd201adeb0
BUG: 868086
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4112
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 5b3c5dd98066dc3c56da8169bca3bbdb55b363ca
Author: Peter Portante <peter.portante@redhat.com>
Date: Fri Oct 19 01:03:00 2012 -0400
Further reduce extended attribute reads/writes
More refactoring towards reducing the number of extended attribute
reads/writes to the file system. See BZ 868120:
http://bugzilla.redhat.com/show_bug.cgi?id=868120
Basically the redundant routines restore_object, restore_account and
restore_container have been collapsed to one routine, restore_metadata, which
will only write out metadata if the new metadata is different from what was
originally read.
Along with these changes come a set of unit tests for all the functions
related to the routines that are in this module in the call tree where
restore_metadata is invoked.
Change-Id: I957ee2f8646cbe6df4d4420d3bdfb1f6ac62bdd2
BUG: 868120
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4111
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 2eebb03aa70730d8da1b1fffb61fb55180fa968f
Author: Peter Portante <peter.portante@redhat.com>
Date: Thu Oct 18 15:39:32 2012 -0400
Move _add_timestamp() closer to where it is used
Simple refactoring to move _add_timestamp() closer to where it is used ahead
of further refactoring changes.
Change-Id: I175c5672202f2d961c72d4e2f4a441b47de1ba28
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4110
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 873671cb074c95ea83730f43d9649f4d5ef98286
Author: Peter Portante <peter.portante@redhat.com>
Date: Thu Oct 18 15:34:57 2012 -0400
object-storage: reduce the number of getxattr system calls by one
Initial step towards addressing BZ 865619.
Prior to the patch, reading metadata for a given object or container involves
at minimum three getxattr system calls for objects that use only one xattr
key/value pair:
1. (via pyxattr) getxattr() to see if key exists and get its value
length (so it can allocate memory for second call below)
2. (from pyxattr) getxattr() to get actual value data
3. (via pyxattr) getxattr() to see if following key exists
For objects and containers that only have to use one xattr key/value pair,
this patch reduces the number system calls by one. This can be significant
given that almost every Swift API operation requires reads of the object or
containers metadata.
This patch is mostly a change to plugins.utils.read_metadata() to try to
unpickle the accumulated metadata as each key/value pair is read, rather than
trying to accumulate all the key/value pairs and unpickle at the end. Once we
get enough data to form the pickle, we no longer keep trying to get more keys,
even if those keys exist.
The extra keys can exist when the size of the stored metadata shrinks below a
key threshold. See https://bugzilla.redhat.com/show_bug.cgi?id=865619 for more
details.
See also https://bugzilla.redhat.com/show_bug.cgi?id=865858.
This patch also adds a unit test infrastructure, and uses it to test with full
coverage, the read_metadata, write_metadata and clean_metadata functions. As a
result, we found that an infinite loop would occur in clean_metadata() when an
unexpected IOError would occur trying to remove a key (this patch contains a
fix).
Change-Id: Ia1838c5e73af453b65360c1c525824231aa7c5d4
BUG: 865619
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4109
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit a008a648405ec82cfe14ad3994ce650cceeff5a5
Author: Peter Portante <peter.portante@redhat.com>
Date: Thu Oct 18 15:26:43 2012 -0400
object-storage: Bump size of metadata stored per xattr key
For Gluster, since we require XFS, and XFS has a max metadata value size of 64
KB, use the increased stored size to reduce the number of system calls, and
how often we exit and enter the Python interpreter (via calls to pyxattr
module).
Today, with the hardcoded 254 byte limit per xattr key/value pair, adding a
couple hundred bytes of user specified metadata can translate to up to three
xattr key/value pairs (remember that the internal python metadata dictionary
is pickled first and then stored in chunks in the keys).
Change-Id: I6648106e8fac31f973ce207a6fecbcdab11fa271
BUG: 865493
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4108
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 3b27d4a213697011f8f6a4272fa9b80b882bd233
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Oct 16 14:21:17 2012 -0400
core: add STACK_WIND_TAIL for more efficient default_xxx.
Change-Id: Ic38e2183d1320bb17c014aca33779471c8db5d5f
BUG: 867132
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4092
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 10ca543a5b3dd014941242bd7e4be7df400ebc0c
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Oct 24 10:05:03 2012 +0530
glusterd: Remove brick from brick list on all nodes.
Change-Id: I7150691886550b80cf5de11464a36c3254c5d21b
BUG: 866916
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4128
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 40f5ce0db62fa7d0b0a2ff295cefd211ce047344
Author: Florian Haas <florian@hastexo.com>
Date: Mon Feb 20 16:25:43 2012 +0100
Add OCF compliant resource agents for glusterd and volumes
These resource agents plug glusterd into Open Cluster Framework
(OCF) compliant cluster resource managers, like Pacemaker.
The glusterd RA is fairly trivial; it simply manages the glusterd daemon
like any upstart or systemd job would, except that Pacemaker can
do it in a cluster-aware fashion.
The volume RA is a bit more involved; It starts a volume and monitors
individual brick's daemons in a cluster aware fashion, recovering bricks
when their processes fail.
Note that this does NOT imply people would deploy GlusterFS servers
in pairs, or anything of that nature. Pacemaker has the ability to
deploy cluster resources as clones, meaning glusterd and volumes would be
configured as follows in a Pacemaker cluster:
primitive p_glusterd ocf:glusterfs:glusterd \
op monitor interval="30"
primitive p_volume_demo ocf:glusterfs:volume \
params volname="demo" \
op monitor interval="10"
clone cl_glusterd p_glusterd \
meta interleave="true"
clone cl_volume_demo p_volume_demo \
meta interleave="true" ordered="true"
colocation c_volume_on_glusterd inf: cl_volume_demo cl_glusterd
order o_glusterd_before_volume 0: cl_glusterd cl_volume_demo
The cluster status then looks as follows (in a 4-node cluster; note
the configuration above could be applied, unchanged, to a cluster
of any number of nodes):
============
Last updated: Fri Mar 30 10:54:50 2012
Last change: Thu Mar 29 17:20:17 2012 via crmd on gluster02.h
Stack: openais
Current DC: gluster03.h - partition with quorum
Version: 1.1.6-3.el6-a02c0f19a00c1eb2527ad38f146ebc0834814558
4 Nodes configured, 4 expected votes
8 Resources configured.
============
Online: [ gluster02.h gluster03.h gluster04.h gluster01.h ]
Clone Set: cl_glusterd [p_glusterd]
Started: [ gluster02.h gluster03.h gluster04.h gluster01.h ]
Clone Set: cl_volume_demo [p_volume_demo]
Started: [ gluster01.h gluster02.h gluster03.h gluster04.h ]
This is also a way of providing automatic glusterd and brick recovery
in systems where neither upstart nor systemd are available.
Change-Id: Ied46657bdfd2dd72dc97cf41b0eb7adcecacd18f
BUG: 869559
Signed-off-by: Florian Haas <florian@hastexo.com>
Reviewed-on: http://review.gluster.org/3043
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1fa390db56a822bc5a0e4236d795b73b4e776c50
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Oct 23 22:41:41 2012 +0530
glusterd: fix for remove-brick on just created/stopped volumes
in a fix to avoid race between stopping the brick and deleting
it in remove-brick (15396f490d23c665d51a64a049679cb40472ab05)
we moved delete of the brick inside stop volume, which was
totally inside the 'if (volinfo->status == STARTED)' section.
thus it made remove-brick of stopped/created volume as a failure.
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 867252
Change-Id: Ie251e59a0b7ddb6965d8d48fb2a3bdb3bd11653d
Reviewed-on: http://review.gluster.org/4127
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
commit 6e786ec4e5bbe933b6bcba74dd46bf8cae1d1afc
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Oct 17 15:36:04 2012 +0530
glusterd: do not log rdma not found messages in error mode
Change-Id: Ie35b05ed2ee004bd6479ccdd3459cbcd9cf8c208
BUG: 867313
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4094
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3adf5c548cd5d0bba02e6f0348718d1107959102
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Oct 20 19:30:06 2012 +0200
NetBSD negative timeout missing support workaround
Newer and simplier version: since the default of negative_timeout is 0,
we can just avoid sending a fuse_entry in that case, and this is enough
to work around the problem.
BUG: 764655
Change-Id: Ibfc6230e3cb9871ccade7fb756e61ebc47cb6487
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/4115
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 76cad0037a6b3135d7e189c606ca60a601d1c49f
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Oct 18 18:39:34 2012 +0200
In some cases AI_ADDRCONFIG confuses NetBSD 6.0
BUG: 764655
Change-Id: I29198c94c6788f9e01f57e11798f3d3d7cd9c8de
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/4105
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 888567a345f907f9c6d504922aa01491ffdcbf1a
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Oct 10 09:12:50 2012 -0400
nfs: do lookup on getattr after brick-status change
By doing a lookup, we get a chance to do all of the self-heal checks that
would occur if we were using native protocol, and return proper status if
the self-heal fails. Best of all, we don't need to misrepresent times.
Change-Id: I76477d1e5fce4d83e4029e02fcdd71e81e23110d
BUG: 830134
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4058
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 38ec5d61cbca189aaefd39b9f209b2b99a13c744
Author: Anand Avati <avati@redhat.com>
Date: Wed Oct 17 15:51:18 2012 -0700
tests: pre-commit regression tests
Framework for writing test cases to be submitted with patches.
This framework and the test cases get exercised by Jenkins in
the pre-commit regression test. Jenkins is configured to give
a +1 verified vote only if the regression test passes without
failures (which includes test cases added/changed by the patch
being tested)
Every patch should include a test case (either extensions/changes
to existing test cases or add new ones, as appropriate). The test
case should be part of the same commit so that both code and
test case get reviewed together.
Test cases added are cumulative. Every new patch gets
tested against its own test case and every test case previously
added.
A lot of new commits in the near future will be pure test cases
(with no code change) which will get added in "catch up" mode.
The tool used for implementing test cases is 'prove', and the
framework itself is modeled similar to the POSIX compliance
filesystem test suite.
Under the top level directory, a new directory named 'tests/'
is added. This contains top level classifier directories and
framework files/scripts.
Functionality tests should be created under a classifier directory
below 'tests/'. For e.g:
tests/basic/mount.t
tests/performance/write-behind.t
Bugs which get fixed should include a test case script named
by the bug id, so that we are guaranteed any new change will
not bring the issue back. For e.g:
tests/bugs/bug-123456.t
Triggering of regression tests in Jenkins is manual at this point
as we do not want the entire test suite to run against every
revision of a patch while it is still in the review/resubmit cycle.
Signed-off-by: Anand Avati <avati@redhat.com>
Change-Id: I8078244619135ccaba38e068925f8ca85141055a
BUG: 764966
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4101
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a4bd33b191ec5596c29e0856d4757070a34f9e4e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Oct 8 11:02:55 2012 +0530
glusterfs: add gf_mkostemp api and use it instead of mkostemp of libc
Change-Id: Icc12b99e2233d22037e2c4bb2b6966e45668b7dd
BUG: 764890
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4091
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 84b44ad9815ef4584d8c80de367e63c125a2c10d
Author: Peter Portante <peter.portante@redhat.com>
Date: Wed Oct 17 15:25:34 2012 -0400
object-storage: Don't catch generic exceptions around xattr calls
We should really avoid catching generic Exception objects around any of our
system calls. This simple fix brings this code in line with the other code
wrapping xattr calls.
Change-Id: I75492a61081fbfbec34c8d91a47214858c67e405
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4099
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit ad6c119d5508525dfdd995cb4d17a4db3829f4b4
Author: Peter Portante <peter.portante@redhat.com>
Date: Tue Oct 16 23:27:21 2012 -0400
object-storage: Refactor code to reduce Swift diffs carried
The upstream Swift code base contains the following commit which adds the
ability to modify constraint values using the swift.conf file:
https://github.com/openstack/swift/commit/a2ac5efaa64f57fbbe059066c6c4636dfd0715c2
These changes rely on the above commit being back-ported to Swift 1.4.8 (see
https://github.com/portante/swift/commit/fc2421b04022ac6bbe9d5014362ec5f99f94c5e0).
As a result, a good number of differences we carry can be removed, since the
provided swift.conf file now contains the values we need.
Along with these changes, we add middleware to get constraints loaded properly
(via monkey patching) until subclassing is implemented in a future commit. We
further simplify the diffs to a minimal set by storing the timestamp in file
system metadata and moving new files to the plugins/middleware directory.
Note that the original "gluster" middleware was in the swift.diff file, and
has been renamed to "glusterfs" and moved to the new plugins/middleware
directory. The "gluster" middleware is now a temporary way to get the
constraints properly loaded (both of these middleware pieces should disappear
in future commits when we refactor further to subclass the Swift objects
instead of patching them).
Change-Id: I9dc00d6b6cdd64e277896d75c2fb06431c3e69cb
BUG: 862052
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4093
Tested-by: Peter Portante <pportant@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 49a701cc4d20a5e58bf4331c6399704311467cbf
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri Oct 5 15:44:22 2012 +0530
cluster/dht: ignore empty ->hashed_subvol during lookup
->hashed_subvol is not valid (== NULL) when the subvolume
the entity hashes to is down. For directories, we need not
rely on ->hashed_subvol as we aggregate information from all
subvolumes. So, during lookup, NULL ->hashed_subvol is ingored
but logged.
Change-Id: I306e4e274fe29d60ff028add4a6c3bcd67b2f314
Signed-off-by: Venky Shankar <vshankar@redhat.com>
BUG: 856459
Reviewed-on: http://review.gluster.org/4046
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit 560ce538c9492f83b52d703f1cbe71768b2eec94
Author: shishir gowda <sgowda@redhat.com>
Date: Thu Jul 26 15:21:38 2012 +0530
cluster/distribute: Always return the latest time in struct iatt.
save the a/c/mtime in inode_ctx, and dht_inode_ctx_update
checks the passed iatte, and updates the stat's time,
and inode_ctx's time accordingly. For preparent times, only
the iatt stat to be returned is updated, not the ctx.
With this, update, WIPE is removed, as we would always be passing
back the latest mtime, and hence cache times will be relevant.
TODO-handle rename WIPE calls
Change-Id: I8e4c738cd830f3fafeef789c9181f9c242ac96a2
BUG: 857791
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/3737
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8c76f03106fcbb827526715982843d1135090c64
Author: Anand Avati <avati@redhat.com>
Date: Sun Oct 14 12:08:25 2012 -0700
syncop: save and restore THIS from the time of context switch
The current yield() code assumes that the point of yielding
is always in the translator where the synctask was created. This
can be a problem for nested syncops and/or where syncop is issued
by a different translator.
So, save the THIS pointer just before swapcontext() and restore
it right after resuming.
Change-Id: I86aad2329ccbc3ac1f04fbec3835136ff3fa79fb
BUG: 862838
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4085
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
commit 929bc09915da7dd9095ee59768a8acd0d91808bf
Author: Pranith Kumar K <pkarampu@redhat.com>
Date: Sat Oct 13 12:06:14 2012 +0530
mgmt/glusterd: avoid directly using conf->uuid
Change-Id: I398c8741b02aa2f34d428c948e93f422e520a9ab
BUG: 862834
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4084
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
commit d1708a061590023e53ef05c9790f10c1cd7f3158
Author: Peter Portante <peter.portante@redhat.com>
Date: Mon Oct 15 11:46:12 2012 -0400
object-storage: change logging of some errors to warnings
There are a number of errors logged which should probably be warnings, given
that the code recovers on those paths.
Change-Id: Ie643bbccb71e7b84ba76d68bac473d1dde663c44
BUG: 866557
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4089
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cf860edc8ef22e3b1c9326403b3ef48ac6dc80a0
Author: Peter Portante <peter.portante@redhat.com>
Date: Fri Oct 5 16:51:42 2012 -0400
Remove the test subdirectory diffs ahead of initial refactoring.
A subsequent commit will refactor the changes required of Swift to be much
more minimal in nature, but does so by relying on an upstream Swift change to
allow constraint values specified in the swift.conf file (see
https://github.com/openstack/swift/commit/a2ac5efaa64f57fbbe059066c6c4636dfd0715c2).
As a result, we can remove the test subdirectory diffs and assume that they
will be present as a result of the upstream patch above.
Change-Id: Ic450aca235d4c9f345e480f9b761bcb2857bd689
BUG: 862052
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4082
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6a54c1d97579dc65cfa11a17b1dda85a30a6a7a6
Author: Peter Portante <peter.portante@redhat.com>
Date: Fri Oct 5 16:41:48 2012 -0400
Reduce the number of gratuitous differences in constraints.
Ahead of further refactoring to make things a bit easier to review, we have
restored some of the code formatting as it was in the original constraints.py
file from which this file as copied.
Change-Id: Icd0b42b4790bc076c54dcbf08a9745648769acfd
BUG: 862052
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4081
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 79e8295c6923291ae1e782999e6dbd80b688e2f3
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Oct 8 11:02:55 2012 +0530
glusterfs: code cleanup
Change-Id: I99bbb720d8b42c8b3899bb1353c6b73f7fcd50f1
BUG: 764890
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4042
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7159d0ed78077938b965e2c22feb2bb9dc415f64
Author: Peter Portante <peter.portante@redhat.com>
Date: Fri Oct 12 15:06:26 2012 -0400
Fix BZ 865858: remove unnecessary system calls around xattr ops
The following is a simple refactoring of the read and write metadata methods
to just make calls to get/set/remove xattr operations instead of trying to
stat/open/close the file. For a single GET operation, this brings down the
number of system calls made from 13 to 3 for a file object with no
significantly sized metadata (meaning, only 1 xattr key/value pair is needed
to store the metadata).
Change-Id: I698f5886d63d5203f130c8eac1536a3ee4b0dbfb
BUG: 865858
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4078
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit be0b8790c0c5f88738085ef59aff20a9e595d745
Author: Anand Avati <avati@redhat.com>
Date: Tue Oct 9 17:40:18 2012 -0700
write-behind: use uint64_t for overlap comparison
off_t is 'long int' (signed word) and therefore ULLONG_MAX - 1
Change-Id: I027de7a1b2ca24865d5d787f9986930e97911ca4
BUG: 857673
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4079
commit 34858079350c87e98aedfc2241cc5d535be23114
Author: Peter Portante <peter.portante@redhat.com>
Date: Fri Oct 12 13:07:24 2012 -0400
Refactor to use pyxattr's get/set/remove methods
These methods are not deprecated, the old ones with the xattr suffix are
considered deprecated starting with 0.4 of pyxattr.
Change-Id: I86ba7a44cec81a273931bf7e470de5eb04e82663
BUG: 865858
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4077
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5106de166836d88cb6c1ce0128f59e60ac69b6cc
Author: Peter Portante <peter.portante@redhat.com>
Date: Fri Oct 5 16:15:29 2012 -0400
Fix a small typ-o in the Swift README
Change-Id: I6c737bcc0d60d656df63ffe1c03ad336606ec090
BUG: 862052
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/4080
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1921fedc6b67ab9b20d71cf863e65041552027dd
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri Oct 12 18:07:04 2012 +0530
protocol/client: Conditional logging in client3_3_unlink_cbk
Change-Id: I4af398362cdb3f99782dcd3728988e4cf1fbb479
BUG: 861925
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4069
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f8f488ff8af5d09c9bd161a0eded2f738c0672e5
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri Oct 12 15:32:10 2012 +0530
cluster/afr : Edited log message in afr_sh_entry_expunge_entry_cbk
Change-Id: I9f7562d28c8bc798552c403164397f929a7bd1e7
BUG: 860246
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4052
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c06d7902422db6dc9d9266fc6569dcbaae367e0b
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sun Jul 8 10:37:49 2012 +0530
core: Add support for systemtap
- First cut (configure plumbing only)
- Intended to allow people who want to test userspace
probes for their favourite xlator(s).
Change-Id: I5bf202073a2f1cc29dc4a55714167b7f48b463a1
BUG: 865734
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/3638
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d343410ea306c62292d35352fff23643a6070075
Author: Varun Shastry <vshastry@redhat.com>
Date: Fri Oct 12 10:45:36 2012 +0530
features/quota: Accept float numbers for quota limit.
Quota limit can be given a floating value like 2.5GB or 0.5TB, which was not
possible before.
Change-Id: I2c89fd521e8b70be51252677c7986abcfa9d11a2
BUG: 819394
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/4068
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b2016f094b11c57cee1e79a410c68a8f79eeb4e1
Author: Varun Shastry <vshastry@redhat.com>
Date: Tue Oct 9 16:00:46 2012 +0530
glusterfs man page edit
Updated man page,
* Added some of the options which were not there before.
* Updated the default dirs.
Change-Id: Ia796377120dc2fb990b2591c7607a16ef93f1fe2
BUG: 825906
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/4060
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6c6e018c190f931db374891e1a6b692f4b5bc07a
Author: linbaiye <linbaiye@gmail.com>
Date: Fri Sep 28 18:56:26 2012 +0800
Preventing client crashing as the callings of GF_CALLOC has been failed.
As the callings of GF_CALLOC can seldom come to a failure, glusterfs client
will crash due to segment fault. We should have returned once the variables
of transaction's local can't be alloced.
Change-Id: Ia3798b8349d832b23c7825e64dbad93ebe29cd1b
BUG: 861335
Signed-off-by: linbaiye <linbaiye@gmail.com>
Reviewed-on: http://review.gluster.org/4005
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0219cccdea94a745024c89896cecffe608a5cb37
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Oct 4 20:55:30 2012 +0530
performance/write-behind: use try lock while taking statedumps
Change-Id: I690e8bf650d6e6e50899c2e17a79f42789e701eb
BUG: 843792
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4036
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fbd68873202225c530ef0a49a8fc62f1ed2bf98e
Author: Csaba Henk <csaba@redhat.com>
Date: Mon Oct 1 15:06:43 2012 +0200
cli: introduce "--" as option terminator
This way it becomes possible to pass option-like arguments to
cli commands.
Change-Id: I8eb1a44ce5d1bfe901d2b3e7cc7bfb84bb3012c9
BUG: 815194
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/4007
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fac9cf97181d29955177aafdd36df9fb9c1f9876
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Sep 26 11:37:31 2012 +0530
storage/posix: remove dependency on loc->path in posix_lookup()
Change-Id: I0a3bc8650d9ff83977be696aa5caf9c7570197fd
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 781318
Reviewed-on: http://review.gluster.org/3997
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b3e3c4835cc94e27be6135457de3085068b5e0a3
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Oct 3 17:15:08 2012 -0400
replicate: don't use synctask_new from within a synctask
Change-Id: Iebf821ff720c63ab6da4b219d82c7f1d00769992
BUG: 862838
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4032
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 32d88f9acf8a73ea6fbf2c19d1fbccd37b12e7fc
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Mon Oct 8 16:18:50 2012 +0530
cluster/afr: gluster volume heal $VN info sporadically reports nothing to heal
PROBLEM:
Whenever rsync is done at the mount point of a replicate volume and during the
rsycn glusterd and bricks of one of the machine gets killed then executing
gluster volume heal info gives results sporadically.Sometimes it says Number of
entries are zero and other time it gives different output. When glusterd and
brick of one of the machine gets killed then at other machine,
RPC_CLNT_DISCONNECT will get triggered periodically. So it may happen that
during the execution of gluster volume heal info command, RPC_CLNT_DISCONNECT
also gets triggered and glusterd will assume that it got a new rpc_disconnet
notification and glusterd will call the glusterd_op_ac_send_unlock_drain
function instead of calling the glusterd_op_ac_rcvd_brick_op_acc function which
is responsible for printing the entries. So because of RCP_CLNT_DISCONNECT
notification, glusterd will execute functions responsible for
RPC_CLNT_DISCONNECT(glusterd_op_ac_send_unlock_drain) rather than executing
functions responsible for gluster volume heal info
command(glusterd_op_ac_rcvd_brick_op_acc).
FIX:
Put a condition in for RPC_CLNT_DISCONNECT in the glusterd_peer_rpc_notify
function so that if RPC_DISCONNECT is triggered for the first for a peer then
glusterd mark that peer as disconnected so that if RPC_DISCONNET is triggered
again, because peer is already marked as disconnected, glusterd will not inject
EVENTR_ACK_DRAIN and prints the Number of entries.
Change-Id: I770e3175b050fd7c7beb801b611a2dff9bfcbac8
BUG: 857503
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4043
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8a57c3883dbe06e810f4edee219b80f770fd4c43
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Oct 8 14:16:21 2012 +0530
client-handshake: synchronize config.remote_port setting b/w rpc_clnt_reconnect and client_query_portmap_cbk
problem:
-------
Theoretically there is a possibility that we could complete
querying the remote brick's port number before rpc_transport_connect
can return. If rpc_clnt_reconnect happens to be the caller of
rpc_transport_connect and we've already got the remote brick's port
number by the time rpc_transport_connect returns, without synchronization,
rpc_clnt_connect resets config.remote_port to zero even before we have
attempted a connection with remote brick.
fix:
commit b927baa889233207555305fc5a7bfda0aef96b96
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Oct 11 16:42:33 2012 +0200
build: do not unconditionally restart glusterd in glusterfs-geo-replication %post
When the glusterd service is disabled and/or not running, the %post
scriptlet for the glusterfs-geo-replication sub-package should not start
glusterd.
To resolve this, an additional condition will only restart glusterd on an
update ($1 -ge 1) and only when it is running (condrestart).
Change-Id: I4c18954e979377cf7211c3a55d14896898836fe6
BUG: 766640
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4063
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 15256ee97eafcd7db8bc5839ddcbc457e0de89dc
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Sep 6 13:08:00 2012 +0530
cli: Changes and enhancements to XML output
This patch contains several xml related changes which fix some bugs and
introduce xml output for commands which were missing it. These include,
* XML output for rebalance & remove-brick status
* XML output for replace-brick
* XML output for 'volume status all' in on xml document
* proper XML output for "volume {create|start|stop|delete}"
* type & status of a volume in 'volume info' is now given as a string as well
This patch also cleans up the '#if (HAVE_LIB_XML)' sections from the code-base,
so that it is not littered around.
Change-Id: I5bb022adf0fedf7e3ead92b4b79bfa02b0b5fef5
BUG: 828131
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/3869
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e471c2cb5955487f63c35be5a53684d246e81546
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Oct 11 22:43:17 2012 +0530
glusterd: volume-start, add-brick and remove-brick to use synctask framework
- Added volume-id validation to glusterd-syncop code.
- All daemons are restarted using synctasks in init().
- glusterd_brick_start has wait/nowait variants to support
volume commands using synctask framework and those that aren't.
Change-Id: Ieec26fe1ea7e5faac88cc7798d93e4cc2b399d34
BUG: 862834
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/3969
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 443300ecb021885eeba91e7704e3c24ec1ebbfa0
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Oct 11 22:41:56 2012 +0530
glusterd: Moved peer rsp handling functions to glusterd-utils
- Moved inner functions used in conjunction with synctask, 'out'.
Change-Id: I7fbfd9881ea58645c4295a9fa7163ddd15a45d2f
BUG: 862834
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4066
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f505731fb52edd29dd61f6534a9a51eda8522de2
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Oct 10 10:23:37 2012 +0530
glusterd: add-brick failed to start bricks when more than one were given
Change-Id: I1487487a656e15e1a9a8685524ea40f0636e0e50
BUG: 864772
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4051
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2c64bcc7d74d1fa44d1b782a9c281954af68326e
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Wed Oct 10 16:30:11 2012 +0530
cluster/afr Changed the message's log level from Error to Debug
Change-Id: Ic2506561367bfec9022dc53e9b17b03dc343df95
BUG: 859411
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/4055
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 40c8accabf2a42f7774d636bf4b8c930fbc60f83
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Oct 10 15:18:06 2012 +0530
storage/posix: return -1 if lstat call returns non zero value apart from -1
* If lstat() call in posix_{pstat, istat} returns non zero return value
other than -1, then treat lstat() call to have been failed and return -1
itself. This might happen if there is some bug in the backend filesystem.
Change-Id: Ie23787f6c838f14f92edadad71b83471e3d22289
BUG: 864401
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4056
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4adc03011976f86124e774cedc747230a25b77df
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Oct 10 13:18:25 2012 +0530
cluster/afr: check transaction type for eager-lock after it is set
Problem:
Eager locking lk-owner decision is taken before transaction
type is set. Default transaction type is DATA so all transactions
are treated as DATA transactions at the time of eager-locking
decision.
Fix:
Move the code that takes lk-owner decision after the transaction
type is set.
Test:
Checked that the transaction type is set properly in gdb at
the time of the lk-owner decision.
Change-Id: Ib1c886866f28788aed67622982e86d667b2cdb80
BUG: 864786
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/4053
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0ca9d8c49d9b1e48c9e3ac896c5c5eb60cc30ac8
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Oct 10 17:57:20 2012 +0530
glusterd: glusterd_brick_stop should be race free wrt pmap
This is important for the effort to make glusterd use synctask
framework.
Change-Id: I0affb10a342df99df8daccfd6eef8fa6dd63928c
BUG: 862834
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4057
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b36cccf905a277398722f6f450dcc3f245d5ad4d
Author: Anand Avati <avati@redhat.com>
Date: Wed Sep 19 16:37:34 2012 -0700
gfapi: added more API calls
- stat
- lstat
- access
- readlink
- mknod
- mkdir
- rmdir
- symlink
- rename
- link
- opendir
- closedir
- seekdir
- telldir
- readdir_r
- statvfs
- chmod
- fchmod
- chown
- lchown
- fchown
- utimens
- lutimens
- futimens
- getxattr
- lgetxattr
- fgetxattr
- setxattr
- lsetxattr
- fsetxattr
- listxattr
- llistxattr
- flistxattr
- removexattr
- lremovexattr
- fremovexattr
Change-Id: Ic2467293ddfbcefaa9b41c82cec61a5602636833
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4022
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit bc7eb3ed6454c06fc8f54e99c6f2296feb9e669e
Author: Kacper Kowalik (Xarthisius) <xarthisius.kk@gmail.com>
Date: Mon Sep 24 10:10:29 2012 +0200
Fix docs to reflect change in GLUSTERD_DEFAULT_WORKDIR
Change-Id: I8ee98cece7a3c4ccdc4c444ff755fba37c75f169
BUG: 859849
Signed-off-by: Kacper Kowalik (Xarthisius) <xarthisius.kk@gmail.com>
Reviewed-on: http://review.gluster.org/3970
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6d64730c3e94618a09b144c64c84edfc4606565c
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Oct 1 21:10:07 2012 +0530
glusterd: bring an option to change the transport-type of the volume.
'gluster volume set <VOL> transport [<tcp>|<rdma>|<tcp,rdma>]'
is the command to change the transport type
* also moved 'memory-accounting' volume set key into VME table
* fixed a crash in 'volume set help' if the vme->type was wrong
Change-Id: Ic4f7ef62277a22b561b05e94c1b1bf19a51d2095
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 797001
Reviewed-on: http://review.gluster.org/4008
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 99319cb656d458de84082cb7ced9c1702359907e
Author: Anand Avati <avati@redhat.com>
Date: Wed Oct 3 00:26:01 2012 -0700
glfs-resolve: fix resolution of "/"
Change-Id: I78d63b39dde14a9a32ea197cf0dedeb5695b35c9
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4021
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 355a5e83841b84ba8a2374e6ec073069a25ebec6
Author: Anand Avati <avati@redhat.com>
Date: Tue Oct 2 15:07:01 2012 -0700
syncop: fix symlink param
make syncop_symlink() accept 'const char *linkname' instead of
'char *linkname'
Change-Id: I7751d552e4a4cc6e8b8e587b9e520213f4e11b45
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4020
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 1cb7a4e7ad566e710bd903e73833bd1a6dc5ad7f
Author: Anand Avati <avati@redhat.com>
Date: Tue Oct 2 02:12:30 2012 -0700
syncop: Implement some missing operations
- syncop_mkdir()
- syncop_rmdir()
- syncop_rename()
Change-Id: I177db0f9af7c99fc6645d59521c8fb82f73812ca
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4019
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 7f58724c7526d1b1d84357e0ec74058f3a21d1b9
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Oct 3 12:22:50 2012 +0530
cli: fixed cli crash during volume set operation
PROBLEM:
The cli crashes in the following case:
gluster> volume set v3 auth.allow "write-behind"
CAUSE:
The second strncat operation in the last iteration of the for loop,
in cli_to_glusterd writes off the end of the space malloc'd for "cmd",
leading to memory corruption.
FIX:
Made the last strncat operation conditional so that in the last
iteration, strncat is avoided.
Change-Id: I8f836c684f33a6328e384ab8e677b8e32bcb4e55
BUG: 862526
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/4025
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c186b1641ff03bc26ca09c1d0e50240cf4acb534
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Oct 3 16:53:23 2012 -0400
core: make sure there are processors for just-queued tasks
Change-Id: I6196ad02fab6c24ac473cda0f78f9e946f0329ce
BUG: 862838
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4031
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2f2a223e980c8aa81e42ffb0a41a6fff011def15
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Oct 3 14:56:19 2012 +0530
glusterd: rebalance should use runner_run_nowait to free up glusterd's epoll thread
Change-Id: Ia32b8c426643e1affcb02dbfb8f32b1844f34303
BUG: 861342
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/4024
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 608b662bff946edc284fea5dfd07cbabb2c7c0b0
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Oct 3 09:49:40 2012 -0400
build: libraries must be in LDADD/LIBADD
Libraries must not be listed in LDFLAGS, because _order is important_.
Details see
http://stackoverflow.com/questions/4241683/linker-flags-in-wrong-place
http://www.gentoo.org/proj/en/qa/asneeded.xml#doc_chap2_sect3
Change-Id: I0479456d6702748c555031bb20641ce430732ec7
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4030
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9e9f8b1f25916c4ad4ce474431439f99b14aecdb
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Oct 3 09:48:45 2012 -0400
build: split CPPFLAGS from CFLAGS
Automake provides a separate variable for preprocessor flags
(*_CPPFLAGS). They are already uses in a few places, so make it
consistent and use it everywhere. Note that cflags obtained from
pkg-config often are cppflags, which is why LIBXML2_CFLAGS moves with
into AM_CPPFLAGS, for example.
Change-Id: I15feed1d18b2ca497371271c4b5876d5ec6289dd
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4029
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a49ebe1fae2ed35377ce53d193b96e5b24644b65
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Oct 3 09:45:22 2012 -0400
build: move -L arguments out of CFLAGS
"-L" is a linker flag, and as such should be in LDFLAGS, not CFLAGS, to
have guaranteed effect.
Change-Id: I014db3f48823d4923b45e0695b62b124eb1a1506
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4028
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 78e70528cd66fd3c163a2c85b7ded2b2aa54836b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Oct 3 09:30:27 2012 -0400
build: remove useless explicit -fPIC -shared from CFLAGS
libtool will automatically add "-fPIC" to the compiler command line as
needed, so there is no need to specify it separately.
"-shared" is normally a linker flag and has an odd effect when used with
libtool --mode=compile, namely that it inhibits production of static
objects. For that however, using AC_DISABLE_STATIC is a lot simpler.
Change-Id: Ic4cba0fad18ffd985cf07f8d6951a976ae59a48f
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4027
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cdc941fb381be7485384408c55c1ee4972d768d7
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Sep 6 00:44:04 2012 +0530
dict: add new API 'dict_add()'
* this new API is used only when we are sure that there is no
replacing keys, ie. in dict_unserialize().
Change-Id: I383dffc65056ebdaf0ab19727f7dc14ec7017fc1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 850917
Reviewed-on: http://review.gluster.org/3844
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 33d9df7a93e60a81ced7580fd5d5826bc81f75d2
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Aug 27 16:59:13 2012 +0530
fuse: create a new fd during fd-migration.
Migration of fd to new graph involves creation of a new fd
to be used only for calls sent in that graph.
Earlier approach of using same fd across all graphs, with the
associated inode always guaranteed to be the one valid in
currently active graph, had issues because of the broken
immutability of the association of fd with an inode
(for the life of fd).
With this patch, there will be a basefd, which the kernel will be
aware of. This basefd, contains a mapping of an fd which is valid
in currently active graph.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: I2b459f05bc2690a66498be107fad6444e3158138
BUG: 802414
Reviewed-on: http://review.gluster.org/3566
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 68162674c9a7adcebf06ce97de6ef010cbd24b7c
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Oct 2 13:37:08 2012 -0400
build: remove -nostartfiles flag
The "-nostartfiles" is a discouraged option and is documented to
potentially result in undesired behavior. Since I see no reason why it
should be in glusterfs, remove it.
Change-Id: I56f2b08874516ebad91447b2583ca2fb776bb7ab
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4018
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 61218f96248d8f4b346dd563fa00e5e66ee8db4c
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Oct 2 16:17:22 2012 +0200
common-utils: valid_host_name() should allow (sub)domains starting/ending with a digit
Some (sub)domains start or end with a digit. If this is the case, it
will not be possible to 'gluster peer probe' hosts in that (sub)domain.
This is overly restrictive, and RFC 1912 contains a note that describes
the common use of start/end digits in (sub)domains:
>
> Allowable characters in a label for a host name are only ASCII
> letters, digits, and the `-' character. Labels may not be all
> numbers, but may have a leading digit (e.g., 3com.com). Labels must
> end and begin only with a letter or digit. See [RFC 1035] and [RFC
> 1123]. (Labels were initially restricted in [RFC 1035] to start with
> a letter, and some older hosts still reportedly have problems with
> the relaxation in [RFC 1123].) Note there are some Internet
> hostnames which violate this rule (411.org, 1776.com).
>
This change will also allow (sub)domains to consist out of digits only,
like the example of 411.org above. It is still not allowed to start or
and a (sub)domain with a `-' (dash) character.
Change-Id: I7236edfe80fd08f28247536bef5287f63b564a63
BUG: 862297
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4017
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8d9ebd18672f983a858f60638f349e2ca0d74c21
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Oct 2 10:42:01 2012 -0400
build: replace INCLUDES by CPPFLAGS
automake warns: "INCLUDES" is the old name for "AM_CPPFLAGS"
(or "*_CPPFLAGS")
So abolish INCLUDES, and place the flags into GF_CPPFLAGS which then
needs to be mentioned for glusterd.
Change-Id: I326f890a69724d8b7163ce726f70ca4618c53958
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4016
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 195ca880f211fd1d79b471736f1285425e6a653c
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Oct 2 10:03:34 2012 -0400
build: add missing backslash in api/src/
Seems like an accidental omission of the backslash.
Change-Id: If78efd9d985a08829ecd6307fd8209d05d0e1fbf
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4010
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 302e2efbaa9b6aba360691d8a9c418504d632a16
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Oct 2 09:45:56 2012 +0200
extras: hook scripts should not start Samba if it is not running
If the smb service was turned off by the administrator, the hook scripts
should not start the service on starting/stopping a volume.
By calling the service script with "condrestart" instead of plain
"start", the service script checks if samba actually was running.
Change-Id: I93408050a65445d98d2f9bb61992e216e04e0b04
BUG: 861506
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/4015
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 48048d890ebd07fa823289d9310d71bda8bfd2dc
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Oct 1 16:08:00 2012 -0400
init.d: implement reload action for SUSE init script
Change-Id: Ic17832b5bb33bc43faa1ff81c5221ec4e3f9294d
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4012
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8c0ff5e24b94c52694edd76047c88d30dbf187f1
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Oct 1 16:07:09 2012 -0400
init.d: use proper dependencies in SUSE init script
"/usr", the place where the binaries usually reside, requires
$remote_fs.
Change-Id: I830c45b09b78b6c3b36c1475ac3f13cf6c2df588
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4011
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d0692435e1a2611665d55b779a7832f4c895528a
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Oct 1 16:09:26 2012 -0400
build: consolidate common compilation flags into one variable
Some -D flags are present in all files, so collect them.
This adds -D${GF_HOST_OS} to some compiler command lines,
but this should not be a problem.
Change-Id: I1aeb346143d4984c9cc4f2750c465ce09af1e6ca
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4013
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit da42bd6bf555843538444886b3ec98599ad9110f
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Oct 1 15:57:41 2012 -0400
build: add missing GF_CFLAGS in api/src/
GF_CFLAGS seems missing in two spots.
In one of those, adding it to libgfapi_la_CFLAGS would make it equal
to AM_CFLAGS, so remove libgfapi_la_CFLAGS there.
Change-Id: I50c22f16210ecd40371d4abb0e418c7a4f94c12f
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4009
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ab2c13e54ffa2114ddd96e46a5eebcb3b195b856
Author: Anand Avati <avati@redhat.com>
Date: Sun Sep 30 13:26:59 2012 -0700
linux-aio: fixes while setting O_DIRECT flag
Linux AIO needs O_DIRECT to be set for effective operation. O_DIRECT
in turn has constraints on when it can work (offset, size alignment)
So use O_DIRECT (unless instructed by application) only when offset
and size alignments match. Else, io_submit() will happen over
non-O_DIRECT fd, effectively blocking till the completion of the IO.
Also fix a multithreading bug where detection/setting of O_DIRECT
for a request was not atomic with io_submit() of that request.
Change-Id: I190017e8bc78217429aff0714dca224cbe6f251d
BUG: 837495
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4006
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
commit fc110108aeb864cb50389c1449aef56502db8dc0
Author: linbaiye <linbaiye@gmail.com>
Date: Fri Sep 21 16:50:34 2012 +0800
Fix problems of mismatch type.
Checking if an uint32_t is less than zero is unnecessary, so we change
the parameter and return value to int.
Change-Id: I5c08eaf8fd4c33768a366b22f0f5db9575056a1e
BUG: 789278
Signed-off-by: linbaiye <linbaiye@gmail.com>
Reviewed-on: http://review.gluster.org/3965
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 94c2d92f227c38430595993deaaf9386621c054b
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Aug 22 23:52:03 2012 +0530
dict: no need to memdup() the XDR buffer for dict_unserialize
* current memdup() of full buffer is not required as
'dict_unserialize()' does its own memdup() of the value.
Change-Id: Iba866b68b753d060ee35bb300ee687e7d293ac82
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 850917
Reviewed-on: http://review.gluster.org/3845
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d1f746df4377027fe74ad3dbaaca6756c2f38269
Author: M S Vishwanath Bhat <vbhat@redhat.com>
Date: Wed Sep 12 06:50:11 2012 +0530
Made test-ffop.c exhaustive by making it to test all types of fops.
Change-Id: I26052d0cbf72f81a6aa0c52498e99b635d1273e9
BUG: 861380
Signed-off-by: M S Vishwanath Bhat <vbhat@redhat.com>
Reviewed-on: http://review.gluster.org/3931
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 2f0fa6b498710a6aa25b7958afad9a5ba1de423d
Author: Anand Avati <avati@redhat.com>
Date: Thu Sep 13 22:26:59 2012 -0700
write-behind: implement causal ordering and other cleanup
Rules of causal ordering implemented:
- If request A arrives after the acknowledgement (to the app,
i.e, STACK_UNWIND) of another request B, then request B is
said to have 'caused' request A.
- (corollary) Two requests, which at any point of time, are
unacknowledged simultaneously in the system can never 'cause'
each other (wb_inode->gen is based on this)
- If request A is caused by request B, AND request A's region
has an overlap with request B's region, then then the fulfillment
of request A is guaranteed to happen after the fulfillment of B.
- FD of origin is not considered for the determination of causal
ordering.
- Append operation's region is considered the whole file.
Other cleanup:
- wb_file_t not required any more.
- wb_local_t not required any more.
- O_RDONLY fd's operations now go through the queue to make sure
writes in the requested region get fulfilled before getting
processed.
- O_SYNC fd's operations now go through the queue to make sure
previously acknowledged writes on the file (via other fds) are
fulfilled before getting processed.
- Option to not honor O_SYNC is now removed.
- Option to ignore O_DIRECT is added (useful when running a VM and the
drive appears with NCQ/TCQ or WCE=1 for the guest.)
- Option to disable_first_nbytes is removed (as the cause of the
bug which required this was diagnosed to be missing TCP_NODELAY.)
- General cleanup and better conformance to coding style and convention.
Change-Id: Ib44fb72da3727246b4a85174cb568c2f0231f6de
BUG: 857673
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3947
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 1fe2413cbbc09fe166558dce5166b70b8668be9b
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 26 12:31:15 2012 +0530
cluster/afr: Provide option to set readdir-size in entry-self-heal
Problem:
Entry self-heal does lookups on all the entries that are read
in readdir. More the size of readdir more number of lookups happen
in parallel. It is observed that it leads to HUGE cpu spikes
rendering everything else on the system unusable.
Fix:
Provided the option self-heal-readdir-size to configure the size.
Default value is at 1KB.
Tests:
Checked that the readdirs are happening with the configured value
in entry-self-heal.
Change-Id: Icaa937ad88857e6f9a12375b1e7f6a49192bc8b1
BUG: 860895
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/4002
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 658ed45e4ef28d66c820c4bd7481e17e1e9fc527
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Fri Sep 21 15:38:07 2012 +0530
cli: removed extra dict unrefs and memory leaks
PROBLEMS ADDRESSED:
a. The following change
http://review.gluster.com/#change,3948
introduces extra dict unrefs in cli.
b. There are instances of memory leak in gf_cli_*_cbk functions.
FIX:
Problem (a) is fixed by ensuring the dict is ref'd (indirectly at
the time of creation) and unref'd (in CLI_STACK_DESTROY) ONLY
once. The following is the rationale behind this approach:
The number of refs and unrefs on dict varies across the different
commands that use it. The cli thread MUST wait for the
gf_cli_*_cbks to complete before the frame is destroyed. This
rules out the need to do extra refs and unrefs in the code path.
Problem (b) is fixed by doing unref on dicts that are created for
the purpose of unserializing the response but never freed in
gf_cli_*_cbk functions.
Change-Id: I5a7431543fc8e3cac4d256f5c87d1e3c62a331be
BUG: 823081
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/3966
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e63f3d769b263fec55c1ec4a0466dce0feed88df
Author: Varun Shastry <vshastry@redhat.com>
Date: Tue Sep 25 20:25:08 2012 +0530
Fixed some general typing errors.
Eg: changed recieved to received
Change-Id: I360fcb99c97c8a0222e373fee20ea2fccfb938db
BUG: 860543
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/3998
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 11a6b448749f68d177e1398f1e282201b58b5968
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Sep 27 01:32:45 2012 +0530
mgmt/glusterd: Prevent extra unref in vol start
Problem:
Volume start cli handler does dict_unref of the dict
unconditionally. It needs to be unrefed only on failure.
Fix:
Unref the dict only on failure.
Tests:
Volume start works fine after the fix.
Change-Id: I64e5ad3d48f69545dd5e1132672182732b98c466
BUG: 860833
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/4001
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b0380a0f5964cf4fc29ec7fed8564d24cfe193b2
Author: Kacper Kowalik (Xarthisius) <xarthisius.kk@gmail.com>
Date: Mon Sep 24 09:50:44 2012 +0200
Fix parallel build issues
Prevent creating symbolic links in not yet created sbindir.
Since lex creates two files, make them depend on each other to
prevent race condition.
Change-Id: I72b633b24de33407006d70571b0a40adaa99dc2b
BUG: 859843
Signed-off-by: Kacper Kowalik (Xarthisius) <xarthisius.kk@gmail.com>
Reviewed-on: http://review.gluster.org/3968
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a2b52eaab521a82c76b29e6348ba9aaf66d18631
Author: Vijay Bellur <vbellur@redhat.com>
Date: Tue Sep 25 00:17:56 2012 +0530
build: Install glusterfs-logrotate as config file
Change-Id: I8255eb4249503eac0add87444da934256faffc01
BUG: 860037
Reviewed-on: http://review.gluster.org/3973
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4e8341c3010cb481bc3f442a6b7f581bf5ab3d21
Author: Anand Avati <avati@redhat.com>
Date: Tue Sep 25 17:08:31 2012 -0700
protocol/client: quick-reconnect after portmap query
Currently the disconnect after a portmap query is treated like an
ordinary disconnect and the reconnection attempt (in this case, to
the brick) is attempted only after 3 secs. This results in a delay
which is unnecessary.
Mark the disconnection happening because of a successful portmap
query as needing a 'quick reconnect' to avoid the delay for this
special case.
Change-Id: I43c8292ff0c30858d883ff3569a3761acbf2f5eb
BUG: 860220
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3994
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 7ff5067f239a8514eac9c8529430d3c2150aeef4
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 24 13:14:56 2012 +0530
cluster/afr: Trigger heal on local subvols on any child_up
Problem:
The index in the child that comes online is generally empty
because the changes would have happened on the other child which
has been up. So the sync begins when the other child's poll
time-out happens (i.e. 10 minutes). The expectation is that the
sync must be triggered as soon as the connection with any brick
is established.
Fix:
Whenever any child_up happens trigger the index self-heal on all
local children in the replicate subvolume.
Tests:
1) Checked that the self-heal is triggered on all local children
whenever any child comes online.
2) Checked that the volume heal commands are working fine.
Change-Id: I4f64737866470a2f989349a889ea52782930e11d
BUG: 852741
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3972
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 09893b9397b723a3ed61e07fe98a87487e0bb5a2
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Sep 18 13:09:10 2012 +0530
protocol/server: put the connection back if setvolume fails
In server_setvolume, put the connection back (thus removing it
from a the list of connections that protocol/server is maintaining
if the connection object is a newly created one) if some operations
such as getting the bound_xl etc fails. Otherwise the process might
segfault upon statedump, when it tries to access NULL bound_xl of a
connection.
Change-Id: Ifa340f534cd88d5601a9219da622b323fbe98b80
BUG: 858191
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/3953
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 401498c361ef5ce6a0bfc56288effaeb0a11add2
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Sep 25 20:47:08 2012 +0530
gfapi: fix the failure in glfs_open()
* the issue is happening because the resolve_symlink() logic was
reversed
Change-Id: I10eca14d82e3ebf5a0195d5db1330f9e1a3e2dc4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 839950
Reviewed-on: http://review.gluster.org/3978
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 586dcad3cec0881ca33ef0663954bea94fae3bef
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 25 10:35:14 2012 +0530
cluster/afr: Wake up post-op on non-co-operative transaction
Problem:
The problem is observed when kernel untar is done. One file untar
happens every second. The reason for this is, setattr lock is blocked
on the prev fd data-transaction full-lock (because of eager-lock).
Because of post-op-delay the post-op (xattrop + unlock) of the prev
data-transaction happens after 1 sec.
Until this the setattr is blocked resulting in performance problems
in untar.
Fix:
Whenever an loc data, meta-data transaction comes, it should wakeup
the prev-post-op on the same process' fd.
Tests:
The performance problem in untar went away. I put a breakpoint in
client_finodelk for a 2G file dd and the inodelk is hit only 4 times.
This confirms that the change does not affect post-op-delay in a
-ve way.
Change-Id: Ice3c2a1211f4dca6520a19bc4ba6cb9efb2902ad
BUG: 845754
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3975
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 88095d099af0bb2b2cc3f8aea5f4e1940ad8a8bc
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Aug 27 19:54:20 2012 +0530
geo-rep / gsyncd: gsyncd binary wrapper context fixes
Changes to __gf_calloc (commit ed4b76ba) triggers a recursive
sequence of _gf_log() and __glusterfs_this_location() calls. This
is due to __gf_calloc() trying to access THIS which is not valid
in the context of geo replication binary wrapper. This patch fixes
the problem by introducing the relevant context in the wrapper.
Change-Id: I32b0b6927074692dbf66bad2f3e93434201aaa82
BUG: 846569
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/3859
Reviewed-by: Csaba Henk <csaba@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3723d38f3a7160e89e05d75ca1305e85f51c0ea6
Author: Anand Avati <avati@redhat.com>
Date: Mon Aug 20 10:48:16 2012 -0700
core: enable process to return the appropriate error code
Setup a pipe() in glusterfs_ctx_t to communicate with the fork'ed
child the exit status and return it to the shell.
Change-Id: Ibbaa581d45acb24d5141e43ae848cae29312d95f
BUG: 762935
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3836
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 2c0e308323fdfdb8e6ebe7387114a66c6f296756
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Sep 17 16:14:41 2012 +0530
libglusterfs/graph: pass correct translator pairs during reconfigure
when we autoload xlators like acl, worm or mac-compatibility,
they will be loaded on top of old graph.
However, corresponding ones won't be present in new graph, since
newgraph doesn't contain autoloaded translators. While
passing xlator pairs to reconfigure, this fact should be accounted
and correct xlator pairs should be passed instead of blindly passing
oldgraph->first and newgraph->first.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: I8f4fe37b7e26dc2dcae78c1fe0d4a04f8ab84ed0
BUG: 857874
Reviewed-on: http://review.gluster.org/3949
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 00e29bfa14738ab6ac88e552d326db961dabe05f
Author: Anand Avati <avati@redhat.com>
Date: Thu Sep 20 00:32:47 2012 -0700
glusterd: use runner_run_nowait() variant for starting bricks
This is a temporary change, which will be undone once glusterd is ready
for handling portmap queries in a different thread while exec'ing
brick processes.
Change-Id: I389b9c38c7444e95fe9d8d0ff20fc91f4bfaf150
BUG: 762935
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3963
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit 56fdc8f76ff91ba2faa9d8dd6e133c441311cdc3
Author: Anand Avati <avati@redhat.com>
Date: Thu Sep 20 00:30:39 2012 -0700
runner: introduce a new variant runner_run_nowait()
which makes the child blindly _exit(0) (thereby relieving
the caller quickly) and the grandchild continues to actually
do execvp().
Change-Id: I4dac0f39aaaa5b2ae5dbeb96e221b8257f8d3a22
BUG: 762935
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3962
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
commit 10f51ec6f2b24d5766fbf8ebb85d5ee116b2bcb1
Author: linbaiye <linbaiye@gmail.com>
Date: Thu Sep 20 12:37:29 2012 +0800
Prevent fuse from setting an invalid value of fd_ctx
This patch is used to prevent __fd_ctx_set() from setting an invalid value.
Change-Id: I6756d83eab20fc485b3696ae341e21324f1c885c
BUG: 789278
Signed-off-by: linbaiye <linbaiye@gmail.com>
Reviewed-on: http://review.gluster.org/3961
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit f868a4fd224f1f813d5c9846485d6faeec75c18e
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Wed Sep 12 17:16:22 2012 +0530
glusterd: Fix to log command status at the appropriate time
PROBLEM:
In the existing implementation, the success/failure of
execution of a command is decided (and logged) in glusterd
handler functions. Strictly speaking, the logging mechanism
must take into account what course the command takes within
the state machine before concluding whether it succeeded or
failed.
FIX:
This patch attempts to fix the above issue for vol commands.
The format of the log message is as follows:
for failure:
<command string> : FAILED : <cause of failure>
for success:
<command string> : SUCCESS
APPROACH (in a nutshell):
* The command string is packed into dict at cli and sent to
glusterd.
* glusterd logs the command status just before doing a
"submit_reply", which is called (either directly or
indirectly via a call to glusterd_op_cli_send_response)
at 2 places for every vol command:
i. in handler functions, and
ii. in glusterd_op_txn_complete
In short, the failure of a command in the handler implies the
command has indeed failed. However, its success in the handler
does NOT necessarily mean the command succeeded/will succeed.
Change-Id: I5a8a2ddc318ef2dc2a9699f704a6bcd2f0ab0277
BUG: 823081
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/3948
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b9cfae13d4eed964e2f9c518dd0465e3cc07e96b
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Aug 7 11:40:16 2012 +0530
glusterd: Fix compile time warning for gsyncd helper routine
Change-Id: I262cc654a3d85ed690446b3875959565600b4bcd
BUG: 846197
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.org/3784
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
commit 4e203101884bf92fba0f3dba81bc93fb31551725
Author: Anand Avati <avati@redhat.com>
Date: Mon Aug 20 10:19:15 2012 -0700
rpcsvc: framework for executing actors as synctask
An rpcsvc_program can be registered by setting .synctask field
to 1 which will make actors of that program be executed in a
synctask, thus freeing up the rpc/poll thread while the actor
executes.
Change-Id: Idacef2ad3bcae0f354fd0fc16ca06ba7094d7b98
BUG: 762935
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3833
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit f8f725e362847e92004d5cce72c33f43448f2952
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Aug 13 14:05:17 2012 +0530
performance/io-cache: provide hook for dumping inode context
Change-Id: Idcf24200ad8f0cf018ab92118f6b77cc4b9edcab
BUG: 843787
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/3816
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8226c92374b7a940bc49ad01ec864150b7171937
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Sep 18 20:45:47 2012 +0530
fuse: override 'gid-timeout' option to disable aux gid compatibility
while mounting -o gid-timeout=-1 will be treated as disabling aux-gid
Change-Id: I85c350868a8cc4a43f5e5aec9427222580da675b
BUG: 835834
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.org/3954
Reviewed-by: Brian Foster <bfoster@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0de1704133a8cc0c786b0dfc7c3e030b1ecd752e
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 19 13:36:25 2012 +0530
syncop: Implement access fop
Change-Id: I959144451790d7e47ae48564923d324451a9db23
BUG: 858602
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3958
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5812b24e1c507ec4a77d3e9a9884b63321fb2c39
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Sep 18 14:39:51 2012 +0200
mount/fuse: readdir() should return 32-bit inodes when 'enable-ino32' is used
The glusterfs mount option 'enable-ino32' does not change the behaviour
of readdir(). fuse_readdir_cbk() uses entry->d_ino directly, and this
was missed in commit c13823bd16b26bc471d3efb15f63b76fbfdf0309.
By adding the function gf_fuse_fill_dirent(), the fuse_dirent structure
is filled in a similar way as the fuse_attr structure. This helper uses
the same function to squash the 64-bit inode in a 32-bit attribute.
Change-Id: Ia20e7144613124a58691e7935cb793b6256aef79
BUG: 850352
URL: http://lists.nongnu.org/archive/html/gluster-devel/2012-09/msg00051.html
Tested-by: Steve Bakke <sbakke@netzyn.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/3955
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d25f40cf2cd66ece8f44ba3e3e14eb622e55857e
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Fri Aug 24 08:40:12 2012 -0400
dual license
rebased
BUG: 820551
Change-Id: I9c51d68e52a9252c5a43af1677380a410ca69519
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/3856
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 930e1882f59b2f36980be9dddda1a3d3f5b8e459
Author: Varun Shastry <vshastry@redhat.com>
Date: Tue Aug 28 18:11:43 2012 +0530
cli/: Filter out the loopback address for brick creation.
Don't create the volumes with brick address 0.0.0.0 to 0.255.255.255
(http://en.wikipedia.org/wiki/Reserved_IP_addresses)
Change-Id: Ic5464ec370bddf498a5220acf2d367b877e21e66
BUG: 787627
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/3865
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d6b5c0c6d5b90d7cf21389547cdcf164cbf5d8ee
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Sep 5 23:57:05 2012 +0530
logging: log ENOENT errors in DEBUG mode instead of ERROR or INFO
Change-Id: I0a43769223991e4ad5206b4382d737a0c3557bf3
BUG: 851953
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/3934
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7858c9ef3764d0632bd01fa4f7cd557e51e14f93
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Aug 27 11:53:41 2012 +0530
features/marker: if parent inode is NULL, then get it by inode_parent
* If parent inode is NULL (nameless lookups which uses gfid for looking up the
inode), then try to get it by inode_parent, instead of returning which results
in the inode's contribution not being added to the list.
* Prevent exceesive logging while adding the inode's contribution to the list
if the operation fails. (Check if the inode's gfid is null which indicates
that the inode is not yet linked to the inode table and hence addition
of its contribution to the list can fail).
Change-Id: I5300f00195ae92a5122613898ae3dabddb2d0bfe
BUG: 851953
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/3935
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4a5f65d4a77f3a5a0f1219fdf600dfda33f7991a
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Sep 10 11:08:01 2012 +0530
CLI: Displaying time as N/A when unix time is 0
Problem:
'volume top open' command was displaying '1970-01-01 00:00:00.000000' when no
file has opened yet.
Fix:
Made the fix in gf_time_fmt() to make it more generic according to patchset 1
review comment.
Change-Id: I748ed203bd0d9fbaac94b5b51ed708b34fccd434
BUG: 852000
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/3924
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit cbd9fccf215f132dfa8a498b7ee5569db7761a7f
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Sep 17 15:44:16 2012 +0530
Clean up of typepunning errors ( Strict aliasing warnings )
Change-Id: I48733967facc526fb523a8dc9bd068f8c5cc5971
BUG: 764282
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/3950
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d4e46c5d10842369a2cbc70c2d90dee9283dd1e8
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Sep 12 12:38:43 2012 +0530
glusterd: Fix remote processes not being shown in "volume status"
Also, refactor function name so it makes more sense.
Change-Id: I3bd3e1bdcacb522ddf4f39d09f73be1c53915362
BUG: 856480
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/3933
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 4e40d9d6d77233f6b6fb33b4e1d0a314e7c01c22
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Aug 22 18:05:44 2012 +0530
protocol/server: dump the ltable and fd table related inodes only
Do not dump the entire inode table in the statedump. Instead dump
those inodes only which are present in fdtable or ltable.
Change-Id: If848f9a6198927b4cc0abd47339461f3ea41d6df
BUG: 844688
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/3848
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a5ca82032ebbe5a97cb4d52aa7e6e82f2335c577
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 12 14:06:53 2012 +0530
features/quota: Avoid mem_put on null local
Problem:
QUOTA_STACK_UNWIND does not check if local is NULL before mem_put.
This leads to a callingfn log for every setxattr in quota.
Fix:
Made sure the mem_put happens only on non-null local in quota.
Additional changes:
Removed unused QUOTA_STACK_DESTROY macro.
Tests:
Peformed setfattr on the mount point and the Invalid argument
logs don't come anymore. Checked that the change does not introduce
any memory leak in quota.
Change-Id: Ie4534c7af0fff80e35d8510311055f930262594f
BUG: 856541
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3936
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3b5510c4be75af2657ecc57145ca318a0ef079d8
Author: Anand Avati <avati@redhat.com>
Date: Tue Aug 28 23:23:52 2012 -0700
gfapi: add symlink (auto resolution) support in resolver
- new internal API glfs_lresolve() for usage with APIs
like glfs_lXXXX() (e.g. glfs_lstat())
Change-Id: I61c60af6bda3072f189684ad8ac9815d59f455fc
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3866
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 70d8e8163718435d5a476422ae877de6c1110c1c
Author: Anand Avati <avati@redhat.com>
Date: Mon Sep 17 12:56:49 2012 -0700
mount/fuse: treat NULL gfid is a failure in lookup disregarding op_ret
It is not possible to inode_link() with a NULL gfid. If a lookup
(or any other "entry" op) returns a success but has a NULL gfid,
then treat it as a failure even if op_ret was 0.
Currently AFR does this when self-healing fails/aborts in certain
situations (like entrylk acquisition failure, gfid mismatch etc.)
returning a NULL gfid in struct iatt of lookup_cbk with op_ret = 0.
Fixing this is an independent patch and fuse-bridge needs to be
robust against such misformed replies in any case.
Change-Id: If5f75780c0b5b1303f466711f1992f90a77e768a
BUG: 856921
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3952
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
commit 65cc96ea4b54a2767b643bfd2e1839fa0f2fd5cf
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Sep 13 12:33:31 2012 +0530
cli: Fix double free in cli_add_key_group
Change-Id: I3c2f030ac7c53913612a3fbac5e582c47b005621
BUG: 851237
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/3943
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1c9b3e1f369fe5d7c5c1f58577c11a082f8b3e99
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sun Sep 2 15:22:34 2012 +0530
storage/posix: Option to set brick(of a volume)'s root dir's uid/gid
CLI
commit ce0459cba59ef3c87a3ea9fdcd46f7414950cc89
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Sep 12 16:08:56 2012 +0530
glusterd: Fixed _is_prefix check for two file paths
Change-Id: Iad1f7c865c4ce5092d85379257ba7a5ec95f7ebc
BUG: 764890
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/3937
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f3b4fe4352d98032101a74b646b6d48c9e15728f
Author: Varun Shastry <vshastry@redhat.com>
Date: Tue Sep 11 16:34:54 2012 +0530
All: License message change
License message changed for server-side, dual license GPLV2 and LGPLv3+.
Change-Id: Ia9e53061b9d2df3b3ef3bc9778dceff77db46a09
BUG: 852318
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/3940
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0742666e85d745022f4c442cd5488e0a7a5a8040
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Sep 12 11:47:13 2012 -0400
glusterfs SEGV on Fedora 17 from UFO fallocate(2) call
An upload of a file will cause the volume's glusterfs to SEGV
when it fields a FUSE_FALLOCATE op. Swift inspects libc to determine
if there is a symbol for fallocate(2) and if so will use it. And
while the libc in RHEL 6 does have fallocate(2), the version of
fuse in RHEL 6 does not support fallocate, and things are handled
gracefully elsewhere (the kernel perhaps?)
N.B. fallocate was added to version 7.19 of fuse. Fedora 17 and
later (and maybe earlier too) has 7.19. RHEL 6 still has 7.13.
Glusterfs uses the 7.13 version <linux/fuse.h>
(in contrib/fuse-include/fuse_kernel.h)
Thus on Fedora 17, with both fallocate(2) in libc and fallocate
support in fuse, the fallocate invocation is dispatched to glusterfs,
but the dispatch table (fuse_std_ops in
xlators/mount/fuse/src/fuse-bridge.c) is too short for one thing;
the fallocate opcode (43) indexes beyond the end of the table, and
even when that doesn't directly cause a SEGV, the NULL pointer at
that location does cause a SEGV when attempting to call the function
through the pointer.
BUG: 856704
Change-Id: I148acbf1265f01a15bd158f227c8a7cb9365606e
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/3938
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fd48d66c9b8c5d2a4ce8f66c0c09fb071bdb5f2d
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Aug 29 14:55:13 2012 +0200
fuse-bridge: Pass unknown option down to fuse
In Linux, certain "filesystem-specific" options (passed in string form in last
argument to mount(2)), such as "rootcontext" or "context" are in fact common to
all filesystems, including fuse. We should pass them down to the actual
mount(2) call untouched.
This is achieved by adding "fuse-mountopts" option to mount/fuse translator and
adjusting the mount helper to propagate it with unrecognized options as they
are encountered.
BUG: 852754
Change-Id: I309203090c02025334561be235864d8d04e4159b
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/3871
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 85ac49d608d9677da87c69296e915adf46b7551d
Author: Anand Avati <avati@redhat.com>
Date: Thu Aug 30 13:15:39 2012 -0700
dht: improve dht_fix_layout_of_directory for better re-assignment
Jeff Darcy wrote:
> AFAICT, the fix-layout code doesn't do the same rotation that the
> new-directory code does. Therefore, the new bricks always claim
> completely predictable hash ranges for every directory, leading to
> either a 0-1-2-3 pattern or a 1-0-2-3 pattern. In other words, a
> file whose hash falls into the second quarter of the range will always
> be assigned to brick 2, and a file whose hash falls into the fourth
> quarter will always be assigned to brick 3. The rest will be split
> according to the original pattern. Put still another way, instead of
> same-named files in different directories being spread across N bricks,
> they might be spread across only two bricks (bad) or totally
> concentrated on one brick (worse) regardless of N.
The current dht_fix_layout_of_directory() code, in an attempt to
maximize overlap of new layout with existing layout (to minimize
movement of data) fails to do a good job of randomizing new assignment
even when it could do a better job. In an example where we expand
from 2 nodes to 4 nodes, the current possibilities are limited in the
following way -
(theoretical hash range: 00 - 99)
OLD 1
-----
server1: 00 - 49
server2: 50 - 99
NEW 1
-----
server1: 00 - 24
server2: 50 - 74
server3: 25 - 49
server4: 75 - 99
OLD 2
-----
server1: 50 - 99
server2: 00 - 49
NEW 2
------
server1: 50 - 74
server2: 00 - 24
server3: 25 - 49
server4: 75 - 99
The above shows that when add-brick from 2 bricks to 4 bricks, server3
and server4 always get the _same_ hash range no matter what the original
hash range assignment was.
The fix in this patch is first do the standard new directory assignment
to a directory (with rotation etc.) and then do the reassignment to
maximize overlap. This way newly added servers still get random ranges
and existing servers have a probability of getting either of the quarters
which were part of its half previously. The same principles hold for
all add-brick from M to M+N.
Change-Id: I0cbbf3bfa334645728072d66aaaa80120d0b295f
BUG: 853258
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3883
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b14c661517e01d1c63a5a332d3ffae824006b080
Author: Anand Avati <avati@redhat.com>
Date: Tue Sep 11 12:28:52 2012 -0700
event: peel out poll and epoll specific code into separate files
code re-org, no change in logic.
Change-Id: Ib1cb3d3f4cf8989a916df7476479c26570d07a84
BUG: 821087
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3932
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 561abd8d20607b84a880e8dcb1b56ee87764e4c6
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Mon Aug 20 21:34:26 2012 +0530
cli: Added special key "group" for bulk volume set.
gluster volume set VOLNAME group group_name
- where group_name is a file under /var/lib/glusterd/groups containing one
key, value pair per line as below,
key1=value1
key2=value2
[...]
- the command sets key1 to value1 and so on.
Change-Id: Ic4c8dedb98d013b29a74e57f8ee7c1d3573137d2
BUG: 851237
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/3831
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ff043af12856648daa04d4facdda7911976d0a49
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Sep 2 07:15:46 2012 +0200
Detect python > 2.5, make sure MKDIR_P is substituted
gluster build machine generate configure scripts unable to detect python > 2.5
This change include a more recent python.m4 so that newer python can be
correctly detected.
Build.gluster.com also produces a configure that fails to subsitute
MKDIR_P, leading to bugs at make install. Works this around by
introducing mkdirp.m4 from aclocal-1.11, with the autoconf version test
removed because build.gluster.com also has an outdated autoconf. And
we need a bit from a recent autoconf
NB: this patchset changes nothing since the last one, I just fix title
in gerrit.
BUG: 764655
Change-Id: I3ffac50cc7a10cb9e56dd490dbc2b550bba3fabd
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/3888
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c0725a525fe61152d4a0b2132fe288f54110da12
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sat Sep 8 12:12:48 2012 +0530
glusterd: Expect setmntent(3) to return NULL
- Closed the mtab FILE * using endmntent(3)
Change-Id: I5e1ebb7f092abda638cfbb5524da693dcac6c872
BUG: 851109
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/3920
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f94d0f7959582f642df528adb009e2a11c2b9683
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Sep 7 01:05:20 2012 +0200
geo-rep/gsyncd: work around rsync argument overflow
instead of passing the files to be synced as args to rsync, have rsync
read them on stdin with '-0 --files-from=-'
Change-Id: Ic3f71a0269941ce50051af8adfad183a52a79b01
BUG: 855306
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/3917
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 53f39713aec8b1e595960a309385683dd5e4b104
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Sep 7 20:59:54 2012 +0530
cluster/dht: handle percent option for 'min-free-disk'
* with the init option cleanups, setting of 'conf->disk_unit'
was reset, which made it not set the '%' in the option.
* bring a global check, which makes the option assume its
percent, as long as value is < 100.
Change-Id: I00bd1395a309cdc596a2b2b80304c6d98696a24a
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 852889
Reviewed-on: http://review.gluster.org/3918
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0d1fde2bcd4cae7fa0ead0fe490898c158710be6
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Sep 3 12:49:21 2012 +0200
mount/fuse: add mount-option "enable-ino32" for the native client
By default the GlusterFS-native client uses 64-bit inodes. Some 32-bit
applications can not handle these correctly. Introduce a client-side
mount option "enable-ino32" which causes the FUSE-client to squash the
64-bit inodes into a 32-bit value.
Change-Id: I3296d16528bfb50457b9675f6b8701234ed82ff0
BUG: 850352
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/3885
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 00edfe207f742cdd7b19cf4e8634a37b0d60289d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 4 21:10:45 2012 +0530
storage/posix: Make posix_fremovexattr anon fd friendly.
Problem:
For anonymous fds posix_fremovexattr fails to work because the open
never happens and the fd-ctx is not set with the fd-number.
Fix:
Use posix_fd_ctx_get which opens and sets the fd-number in the fd-ctx
for anonymous fds.
Tests:
Added a syncop call in glustershd to test this change and it worked fine.
Change-Id: I9629190a87eb27a7a1578e4fe732a5eb1248f30c
BUG: 854331
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3903
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 488be989361c23aedda883d0bd51f54aaf14b2f5
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Wed Aug 29 16:51:50 2012 +0200
mount.glusterfs: Ignore noauto and _netdev options
BUG: 827121
Change-Id: Icab4ca9adecc7b9d62e3d5e7d161c442f16ad940
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Reviewed-on: http://review.gluster.org/3873
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit b16f7aa004d96ec710cf8825c5ee9e11999e2a45
Author: Jules.Wang <lancelotds@163.com>
Date: Tue Sep 4 05:42:41 2012 +0800
afr: add option description of 'open'.
Signed-off-by: Jules Wang <lancelotds@163.com>
Change-Id: I6c7dd337c758e82e9d58d4d65f53b5aa72ac5dfb
BUG: 764890
Reviewed-on: http://review.gluster.org/3895
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1f71cd69d96085d338907a3d7e07d97668e4e931
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 4 21:13:32 2012 +0530
libglusterfs: Implementation of syncop_fsyncdir
Change-Id: I832b9c0bfbe804fbca98dc9e8fbe7d3174fecc82
BUG: 854326
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3902
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f67acc500f432e5f112512d5a815ea6701a98fff
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Sep 6 22:44:15 2012 +0200
glusterd: fix mountbroker option parsing routine
Properly adjust it to the new dict API as of
http://review.gluster.org/3829.
Change-Id: I8f55d2b1d590b15000984f4862c52b3cd226cef8
BUG: 850917
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/3914
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2265c6dfc1e709bf6748eed75e6481f72d685521
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Sep 6 23:21:55 2012 +0200
posix: adjust new xattrops to new dict API
- http://review.gluster.org/3909 introduces new xattrops
- http://review.gluster.org/3829 changes the dict API
The new xattrops has been written against the old dict API,
but been committed after the dict API change, resulting in
a build error.
Change-Id: I10b9acc79927f3505b5e13116653fb9a584ffd31
BUG: 850917
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/3915
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit af1b12d9d50009a20d8eff883c81dc0688eba120
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 5 20:16:52 2012 +0530
storage/posix: Add or_array/and_array op for xattrop
Problem:
For set/reset of outcast (ALL changelog bits set per transaction
type i.e. data/mdata/entry) from afr the capability of OR/AND in
xattrop is needed in posix. Otherwise marking outcast will only
be possible in self-heals where appropriate locks are held so
that no other transaction is in progress, so exact number can be
computed with which when XATTROP_ADD happens all bits will be set
for that changelog.
Fix:
Implemented new xattrop-op OR_ARRAY, AND_ARRAY. Made checks in
__add_array to work well with __or_array.
Tests:
From Afr code made an OR_ARRAY with ALL bits set and it reflected
on the changelog xattrs. changelog incrementing did not have any
effects on the all-set changelog.
From Afr code made an AND_ARRAY with 0 and it reflected in the
changelog xattrs.
Change-Id: Ie89c78a43d05789e3a8fa03d2422b52083ae80b9
BUG: 847671
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3909
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5fc522a8109be53b3035e34deeabb7c44ffae234
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Sep 6 12:20:13 2012 +0530
cluster/distribute: remove gf_log() from statedump functions
Change-Id: I83cccab6819d6a74e96c2717ca539fa1568cac89
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 843822
Reviewed-on: http://review.gluster.org/3912
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 75abfc2f2f6f6fe13317341cf2c0b93884e952cd
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Sep 3 10:40:36 2012 +0530
mgmt/glusterd: Typo in the error message of the volume stop
Change-Id: I86e4fdb48d9b29789f3446b8c0925eb81cf220c9
BUG: 852999
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/3892
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit e4bbea09960464f512f2d73d464fe23dd8dcbb12
Author: Csaba Henk <csaba@redhat.com>
Date: Thu Sep 6 17:52:11 2012 +0200
cli: sanitize exit value
The pattern established in http://review.gluster.com/3218
as of which cli exits with negated return value of the
command instrumentation function should be uniformly
followed. (Prior to this commit whether cli exits
with 255 or 1 on failure depended on the way of invocation.)
Change-Id: Icbab1f435042b3321c689fa785109bf87195d86d
BUG: 765214
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.org/3913
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 16cef8d63bd5bec7d31471de99f6adc43ea7c919
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Aug 24 14:15:32 2012 +0530
mount/fuse: If gfid is not present assign gfid
Change-Id: I2fb8c607694eb8bbe5ec0f67d8db794066a89ca4
BUG: 821138
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3854
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b90b218fc90bfc43f9ccd18c8ebd923a79090742
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Sep 5 13:07:49 2012 +0530
core/statedump: parse the file and set the path of the statedump files
* As of now "gluster volume set statedump-path" option sets the path of
the statedump files for brick processes only. If SIGUSR1 is sent directly
to all the gluster processes instead of using gluster cli command, then
some of the statedumps will still be in /tmp (such as nfs server, glustershd).
* This patch makes glusterfs processes search for the file
/tmp/glusterdump.options and consider the options given in it. There if path
key is set, then all the processes use that path when SIGUSR1 is sent or cli
statedump command is executed. (Note that after taking statedump, if
/tmp/glusterdump.options file is removed, then the default way is resumed).
Change-Id: I2e8fbfb4823318512e03b234e90d3a3888724ddc
BUG: 851175
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/3907
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 5863cccdf84cff713089df53cf78d2bbae5fec8f
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Sep 6 00:13:04 2012 +0530
libglusterfs/dict: make 'dict_t' a opaque object
* ie, don't dereference dict_t pointer, instead use APIs everywhere
* other than dict_t only 'data_t' should be the valid export from dict.h
* added 'dict_foreach_fnmatch()' API
* changed dict_lookup() to use data_t, instead of data_pair_t
Change-Id: I400bb0dd55519a7c5d2a107e67c8e7a7207228dc
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 850917
Reviewed-on: http://review.gluster.org/3829
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b9cae76370471299a23924e118b30ae076e92270
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Sep 3 17:33:46 2012 +0530
rpc/socket: Wrong Log-File Error-Message
Problem:
The port changed in rpc-clnt.c:rpc_clnt_reconfig was not being
updated to the variable peerinfo.identifier before the logging.
Change-Id: Ic56a74738c6f7664e9719b125a014126cea69141
BUG: 847211
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/3894
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0a04bdcd7dca45eb4a1c9a6ccb5f9a11d1886fda
Author: Varun Shastry <vshastry@redhat.com>
Date: Thu Aug 30 17:23:41 2012 +0530
License change to 2 additional files.
Change-Id: I4689602cbea0e46498d10b8785bcde86d369e75d
BUG: 852318
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/3880
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 6eeeb38579eb0dfe5e00f8d318904e4682c6a8ac
Author: Niels de Vos <ndevos@redhat.com>
Date: Wed Sep 5 10:09:07 2012 +0200
build: Don't use python-ctypes on SLES
There is no python-ctypes on SLES 11, so don't require is for building
the RPM.
Change-Id: I3399318c1d2a603bb8d228ed4f1b5cbcb7a3a9c3
BUG: 854503
CC: Jörg Petersen <joerg.h.petersen@googlemail.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/3906
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 78fca0c0b7eaa7468310190a38e83d9795e47e96
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Sep 2 07:11:04 2012 +0200
Honour configure --localstatedir and --sysconfdir
Makes sure /etc/glusterd to /var/lib/glusterd migration does nonour
configure --localstatedir and --sysconfdir.
BUG: 764655
Change-Id: I65a5f96424d67531e81e75b084265bd4e6e30f29
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/3890
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 54c23f46585f38e1a4969e674b5e23b5b022076b
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Tue Sep 4 15:08:56 2012 +0530
glusterd: Made volume reset recognize options in <domain>.<specifier> format
PROBLEM:
Volume reset command does not reset options when specified in
<domain>.<specifier> format.
FIX:
Changed glusterd_options_reset to use "key" (as opposed to "key_fixed")
to fetch "value" in a way that ensures "key" ALWAYS holds the option
name in its fully qualified form, irrespective of whether the option
was specified in its fully qualified format or in short form.
Change-Id: Ibc3a87f4d29cb09e34b54c4b5ead564fefade350
BUG: 847846
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/3901
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
commit dbc11f9fdfdd28ef419164a5e176d9ac73f96fe1
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Sep 3 15:53:40 2012 +0530
glusterd: Removed pattern match lookup logic on volume options
In light of the comments received on the following patch,
http://review.gluster.com/#change,3860
this change knocks off the pattern match lookup logic that once
enabled wildcard entries to be used for volume options.
Here's a bit on the history of the macro "pattern_match_options",
coming straight from the author's(Csaba) mouth:
"So, the history of pattern_match_options is as follows:
i. In the volume option table we used to be able to have wildcard
entries like auth.addr.*.allow and there was a special lookup logic
to support that, cf.
http://github.com/gluster/glusterfs/commit/v3.1.0qa40~19
ii. However, later on we stopped using this mechanism:
http://github.com/gluster/glusterfs/commit/v3.1.0qa40~9
iii. Later on we added the code that allowed the usage of option
names both in fully qualified (<domain>.<specifier>) and short
(<specifier>)forms:
http://github.com/gluster/glusterfs/commit/v3.1.0qa41~10.
At this point, maintaining support for wildcard table entries became
more difficult (~ error prone), so that part was placed under the macro
pattern_match_options and -- given that we made no use of the feature
-- a simple direct lookup logic was introduced. I chose to keep the
pattern matching logic in the code because I was not really sure about
the future of it and thought we might want wildcarded table entries
later. ..."
Change-Id: I261735143891931e8150c36fe5b33ae74b1c663d
BUG: 847846
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/3893
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
commit 030c65f8a7a137f40769bc86f74bd66648958bf4
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Mon Sep 3 17:59:05 2012 +0530
cli: Do not print brick info for non-replicate volume
Change-Id: I5e91df64ededd78371c0cd4d900f93ab4a0298ee
BUG: 852406
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/3867
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit dbb5e4192a6d70934b8f5327010e869ff9f7857b
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Aug 29 14:43:30 2012 +0530
cli, glusterd: Changes to 'peer status' xml output
Glusterd now returns the status of a peer as both a string and a number.
The xml output for peer status has been modified, such that the <status> element
now contains the status number and a new <statusStr> element contains the status
string.
Change-Id: I0d4b74b84a991893d1029b8408d66ff078bbd254
BUG: 847760
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/3868
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 26a268619352a972446d6bdac87e71c905c0e362
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Aug 30 19:01:22 2012 +0200
Add missing contrib/libgen files to distribution
BUG: 764655
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Change-Id: I3f49eb4a1a186cb2d178539ada6a05c8c1aa8265
Reviewed-on: http://review.gluster.org/3882
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 75a898f1560fb99cc1aaf3fac521a074149a2194
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Aug 24 11:52:01 2012 +0530
cluster/afr: Don't stop entry/data self-heal on metadata split-brain
Problem:
Entry/Data self-heal is orthogonal to meta-data self-heal.
meta-data split-brain should not affect entry/data self-heal.
Fix:
Prevented aborting rest of the self-heals when metadata split-brain
happens.
Tests:
1) Simulated meta-data split-brain then checked data-self-heal
succeed on regular file, entry-self-heal succeed on dir.
2) Reset meta-data change-log on one of the subvols and checked
that meta-data self-heal also completes.
3) Executed self-heal sanity script.
Change-Id: I05ca222d855d3a6000703e3775471d0f874d35d6
BUG: 851451
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3853
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <obdurodon@gmail.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 37abf3b4cc3542890c38f08bc2b905bdcc4b73d1
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Aug 28 14:45:47 2012 +0530
dht/rebalance: set the correct ownership on the dst file.
Currently, the dst file created has root:root ownership, till
migration is completed. During this phase, open fails on the dst
file if uid/gid is non-root.
Setting the dst_file to the correct ownership fixes the issue
Change-Id: Icfec89eb10dc866cdee38dab17695fe21174ef99
BUG: 852361
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.org/3861
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6bf219c0b6eb6a2c561c47f28c544ed53991c83f
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Aug 28 17:29:53 2012 +0530
glusterd: Fixed incorrect assumptions in rpcsvc actors of glusterd
Change-Id: Iabfcb401de9d658e32433aa1e8c87b329cbd2cf7
BUG: 851109
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/3864
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 745c37474d7b9bbd21716036c307dbf645a0128a
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Aug 28 13:12:31 2012 +0530
glusterfsd: rpcsvc actors must return success after an attempt to submit reply
rpcsvc attempts to send "error reply" using the req object. If actor has
already performed rpcsvc_submit_generic, then req is destroyed. So if the
actor returned -1 (RPCSVC_ACTOR_ERROR) on failing to submit reply, then req
would be 'free'd' twice and will result in a crash eventually.
Change-Id: I5eae19570202bbe5e154e9cb03390cfeb9b5f223
BUG: 851410
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/3863
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit dd0f6b09741a30a6f5c4695830e319a0b97e75cc
Author: Varun Shastry <vshastry@redhat.com>
Date: Mon Aug 27 16:48:55 2012 +0530
All: License message change
The license message is changed to
Copyright (c) 2008-2012 Red Hat, Inc. <http://www.redhat.com>
This file is part of GlusterFS.
This file is licensed to you under your choice of the GNU Lesser
General Public License, version 3 or any later version (LGPLv3 or
later), or the GNU General Public License, version 2 (GPLv2), in all
cases as published by the Free Software Foundation.
Change-Id: I07d2b63ed5fbbbd1884f1e74f2dd56013d15b0f4
BUG: 852318
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.org/3858
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d5ee810d6ce389c6a98a7d8a0704c380846e4710
Author: Thomas Oulevey <thomas.oulevey@cern.ch>
Date: Thu Aug 23 11:50:50 2012 +0200
init.d: Fix init.d on Redhat, so it does not always return 0.
* Installing gluster with puppet, it gives an error if service "hasstatus => true" is used.
* Introduced a $RETVAL variable set to previous command return value.
Change-Id: I186ec59f892f04f25c06478315ca85183cb6232a
BUG: 836007
Signed-off-by: Thomas Oulevey <thomas.oulevey@cern.ch>
Reviewed-on: http://review.gluster.org/3847
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 795e763dbfd48a2bc0d525f3b2d9a94713e3cd38
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sun Aug 12 13:29:10 2012 +0530
afr: Avoid excessive logging in self-heal.
- (Excessive) Logging has been very useful as 'bread-crumbs' in
many a root-cause analyses. This patch aims at avoiding logging when
the information could be reconstructed using the xattrs, statedump,
and/or "volume heal" CLI commands.
Change-Id: Iebc6b10ae18f0dd9704bdc6dd03bcfe0f2a09abd
BUG: 844804
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/3805
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d9ddb5fb95b84474d3962661b28679ff0d083983
Author: Deepak C Shetty <deepakcs@linux.vnet.ibm.com>
Date: Fri Aug 3 15:46:22 2012 +0530
Add support for --enable-debug configure option
Currently default build adds -g -O2 to CFLAGS unconditionally
and there is no way to control them from configure.
This patch adds support for --enable-debug option to the
configure cmdline.
If yes, then only -g is added. If no, then -g -O2 is added.
Build defaults to --enable-debug=no.
Also fixes couple of Makefile.am's which had -g hardcoded.
v2:
Adds -O0 for debug=yes case.
v3:
Added bugID while submitting patch
Change-Id: I7505619be6fc683de463a0bd44ba5500b0bedfe1
BUG: 851092
Signed-off-by: Deepak C Shetty <deepakcs@linux.vnet.ibm.com>
Reviewed-on: http://review.gluster.org/3822
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Deepak Shetty <dpkshetty@gmail.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d29ce5960b1ae0a07c28e2d0de8df185b53bbcd4
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jul 30 13:05:52 2012 +0530
socket: code cleanup
* for more review friendly way
* reduce the level of indirections at each line.
Change-Id: I82ace7683fb281d97a64da724f054ece28215054
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 764890
Reviewed-on: http://review.gluster.org/3839
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d89d69a46e5deddb67ae77661fb35e43d63921b8
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Aug 22 22:33:24 2012 +0530
posix-acl: make use of 'umask' flag passed as argument in fop
* currently "umask" is reffered only from xdata dictionary, instead
we should utilize fop argument.
* not taking of setting of "umask" in fuse for now, considering the
backward compatibility with earlier releases.
* dict_del() the "umask" and "mode" keys from xdata dict as the fop
after reaching posix layer tries to set every entry in xdata as
xattr on file/dir.
Change-Id: I7199b05a5bde132df20e7812a99bc02ef7b988ce
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 850873
Reviewed-on: http://review.gluster.org/3843
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a196592b0233621951f3307c9dfbd8097542664a
Author: Anand Avati <avati@redhat.com>
Date: Wed Aug 22 02:10:36 2012 -0700
epoll: whitespace cleanup and remove unused variable
Change-Id: Idd7269f8b3a6dfaf931b378128eff93088b3be73
BUG: 821087
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3841
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6b3bd2681e89dd0e261457be699c0763e7a038d6
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Aug 20 23:46:03 2012 +0530
fuse: make background queue length configurable
* also make 'congestion_threshold' an option
* make 'congestion_threshold' as 75% of background queue length if
not explicitely specified
* in glusterfsd.c, moved all the fuse option dictionary setting
code to separate function
Change-Id: Ie1680eefaed9377720770a09222282321bd4132e
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 845214
Reviewed-on: http://review.gluster.org/3830
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c44078e7e17d98e61a16adce0a8a53d6366100cb
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Aug 4 12:21:42 2012 +0530
syncop: Added scaling down logic
RCA:
Whenever the self-heald tests are done with more than 16 replicates
The number of sync procs goes to > 2. These threads never die.
Fix:
Added scaling down logic in syncops so that the threads terminate
themselves whenever the extra thread is idle for ~10 minutes.
Minimum number of threads is still 2.
Tests:
Added logs for launching and terminating procs, made timeout to
6 seconds and ran volume-heal in a while loop. After logs say
max number of procs are launched, attached process to gdb and
verified that the number of syncop threads are 16. Stopped
volume-heal and observed the logs for terminating the procs.
Attached gdb to process again to check that the syncop threads
are just 2. Did this 5 times. Things worked fine. Which procs
were terminated was random. No proc structure was erroneously
re-used. Procs never exceeded 16 and were never < 2.
Change-Id: I61dd9c25cc478ac8cbda190bee841a995b93c55c
BUG: 814074
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.org/3195
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9db6a52e6f2748fdd8a8bd234909379152611397
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Tue Aug 21 05:11:07 2012 +0200
NetBSD build fix
BUG: 764655
Change-Id: I65009625dfa627e0ca3b7ff2784b778d26ec04b1
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/3837
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b350991a06de730fefbcf5f9ec293a20e115282b
Author: Anand Avati <avati@redhat.com>
Date: Mon Aug 20 09:46:33 2012 -0700
rpcsvc: remove .vector_actor and related changes
The .vector_actor method of rpcsvc_actor_desc is defunct now after
rpc unification. Remove the field and all related usage of it.
Change-Id: I53048cebeae78f50259e8c4a7fec3497691fe388
BUG: 762935
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/3832
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 21f903a244efa433551e2556e4f64afbffacb4ce
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Fri Aug 17 12:44:46 2012 +0530
Self-heald: Prevent logging of errno ENOENT
Change-Id: Ie56228dfbdc7e519a344681487164a835488a470
BUG: 835423
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/3826
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9bef0f5ebd0b44d455fbb4b8fdaa674e6696bb56
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Aug 13 18:57:20 2012 +0530
cli: Proper xml output for "gluster peer status"
Change-Id: I5d72d3844aba0417652498f4dc706b4a68d36bd8
BUG: 847760
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/3814
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <krishnan.parthasarathi@gmail.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 282bd2a37a1e143dad71cf210c832fa8cf81d449
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Aug 17 14:21:07 2012 +0530
syncop: handle 'dataonly' flag in syncop_fsync()
* and also in syncop_readv(), don't look at _cbk args if op_ret
is < 0.
Change-Id: I3ab2982bc6d186e75b6adb74c8981e4ff7058bbe
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 839950
Reviewed-on: http://review.gluster.org/3828
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9ec9e1f3d336e577a23caf82e93094f98175cb10
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Aug 9 13:12:31 2012 +0530
performance/write-behind: avoid deadlock while taking the statedump of fds
* Provide a hook for forget
Change-Id: Ide7ea6d4c6a7d0d93b81570cb544f2bbda526eeb
BUG: 846916
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/3795
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9523a83df6a9082b3af598dfaa4135f463db8a0f
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Aug 8 18:42:24 2012 +0200
cluster/dht: don't leak upon GF_REALLOC failure
Change-Id: I7dfabcc2981df5c5a1e1a54c3135400a60626cd1
BUG: 846755
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3798
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 11c678e4565dd1383a1e3bdd8f107c9755dcfcd6
Author: Jim Meyering <meyering@redhat.com>
Date: Tue Jul 31 12:27:02 2012 +0200
gsyncd: don't use void* arithmetic; don't leak upon OOM; remove cast
(duplexpand): Ignore risk of overflow in computation of the realloc
object count, since we'd need a string with 2^62 space-separated tokens
to trigger that (that's w/64-bit size_t; w/32-bit it'd be easier, but
still improbable).
Change-Id: If4521afe7b46110742991dd0ee234284ef8970df
BUG: 846755
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3793
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e7811f205aad4965b323a8077ac1246dc96a79ce
Author: Jim Meyering <meyering@redhat.com>
Date: Thu Aug 9 14:29:57 2012 +0200
utils: don't leak after failed GF_REALLOC
This is primarily to avoid a leak upon failed GF_REALLOC
when glusterd_readin_file reads a file that is too large.
Also, remove unnecessary memset-0 of PATH_MAX+256-byte buffer.
Change-Id: Id06bd5faef024e1d865f6f0f56bfbb837c9c6168
BUG: 846755
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3804
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bec35964931a3184926d4011de3fb995586524cc
Author: Varun Shastry <vshastry@redhat.com>
Date: Tue Aug 14 14:21:30 2012 +0530
cli/: Displaying the size in human readable format
rebalance status displaying the size in bytes. Converted to
human readable
Change-Id: Ie39938970f92bf7507db2a6de4d5958408f3892c
BUG: 825193
Signed-off-by: Varun Shastry <vshastry@redhat.com>
Reviewed-on: http://review.gluster.com/3781
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
commit 3e6946870d70c62d0c1230ef7eb922b9f30c07f5
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Aug 14 14:45:28 2012 +0300
fix "--client-pid"
http://review.gluster.com/3698 broke special clients by omitting the
conversion of the client_pid_set parameter to the new xlator option
framework.
Change-Id: I0dc886dffba9c4a9fe8d97e5feccfa5f95784ce1
BUG: 848034
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3820
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3f1a898e3bc7ed7a46dff77fdfa30ec86ec2222f
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Aug 15 17:27:52 2012 +0200
fuse: have setxattr on geo-rep related xattrs take effect
In http://review.gluster.com/3687 setxattr was made to a noop for
geo-rep special clients, with the exception of some special ones,
relevant to geo-rep. These exceptions were all in trusted namespace.
That's no good, because with a mountbroker (unprivileged) setup,
the relevant attributes are in system namespace. So here we
just let setxattr through for any geo-rep related xattr, regardless
of namespace.
Change-Id: I261141293b7db955a2e8b2405b4510cb10a42694
BUG: 848447
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3821
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 154316f2198087629fda357267c672d4cbb74156
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Thu Aug 16 13:27:00 2012 -0400
misleading/wrong keep-alive error message in log
Gluster NFS and brick logs contain the following log entries:
[2012-08-16 09:23:39.498998] W [socket.c:410:__socket_keepalive] 0-socket: failed to set keep idle on socket 8
[2012-08-16 09:23:39.499049] W [socket.c:1876:socket_server_event_handler] 0-socket.glusterfsd: Failed to set keep-alive: Operation not supported
[2012-08-16 09:23:42.673756] I [client-handshake.c:1636:select_server_supported_
Stepping through the code though, setting keep-alive did actually work,
it's the keep-idle that failed.
The actual problem is setting keep-idle on non-AF_INET sockets results
in the spurious error message in the log.
BUG: 848882
Change-Id: I3a54c96aea0642307f17a7945cca9f9438543243
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.com/3823
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ca6b954c677ad88170e9b42b1d68dc02727f8c8c
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Aug 9 19:29:33 2012 +0530
rpc: Reduce frame-timeout for glusterd connections
Reduce frame-timeout for glusterd connections from 30mins to 10 mins. 30mins is
too long when compared to cli timeout of 2mins. Changing to 10mins reduces the
disparity between cli and glusterd.
Also, fix glusterfs_submit_reply() so that a reply is sent even if serialize
failed.
Change-Id: Id5f68f2ff28ea7453d9a62429fe12aa0c0a66952
BUG: 843003
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3803
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 447fbb3a178dd8a02cc8da093babae304a438270
Author: Anand Avati <avati@redhat.com>
Date: Tue Aug 7 00:14:43 2012 -0700
rfc.sh: set 'Change-Id: ' header on first run
Let first run of rfc.sh include 'Change-Id:' as well
Change-Id: I7b45a00d98f8c70ca3658c223a98f412f20cbb6f
BUG: 764890
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3785
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0af65ec83587dea5e256360ab2116622a355c36e
Author: shishir gowda <sgowda@redhat.com>
Date: Tue Aug 7 12:55:31 2012 +0530
cluster/dht: Optimize readdirp calls in DHT
Bring in option which is supported by posix xlator
to filter out directory's entries from being returned.
DHT would now request non-first subvols to filter out
directory entries.
dht xlator-option readdir-optimize will enable this
optimization
Change-Id: I35224bc81c9657f54f952efac02790276c35ded5
BUG: 838199
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.com/3772
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d7bed3bed599b97da352b6b5b47e45a277b3b2c0
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon Aug 13 06:35:18 2012 +0200
NetBSD swapcontext() portability fix
Further analysis of the problem reveals some wrong conclusions I made
before. NetBSD's swapcontext() preempts no thread. It alters the
pthread private pointer, leading to multiple threads with the same
pthread pointer. That led me to the wrong conclusion that thread were
preempted. I guess this can be called a bug: NetBSD swapcontext()
is incompatible with libpthread.
Fortunately, there is a workaround, swapcontext() can be told to
let the pthread private pointer untouched. This change just does
that, fixing the crashes without sacrifying performances.
There is just one problem: not all NetBSD ports have the capability
to do that: at least ports using sh3, sparc, sparc64 and powerpc
are left broken by this change. This problem will be addressed by
upcoming fixes in NetBSD.
BUG: 764655
Change-Id: I4191cb984176fce7064730ab55bd62c9156846cd
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3794
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e44201158827eb1404b0c701909de1b36e7e10fe
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Aug 9 13:23:48 2012 +0530
performance/write-behind: store the wb_inode in local before winding
* Store the write-behind's inode context in the local structure before
winding the call so that in callback inode context is found.
* Before returning EBADFD check if the inode context (wb_inode) is NULL,
along with the inode type.
Change-Id: If5a1c667efe6882a6efef1439cee3effc32ff9a7
BUG: 846536
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3796
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 2545623e9f942d8bacfb2e9d2cbb2722280095fe
Author: Jim Meyering <meyering@redhat.com>
Date: Thu Aug 2 10:51:40 2012 +0200
fuse-bridge: fuse_thread_proc: avoid realloc-clobber induced leak upon OOM
Change-Id: I835d14b702b875bb07f41e157583592df9b72f36
BUG: 846755
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3792
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e8d18edb45134d60b9e58b6ac3e2d1b89df2bb9d
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Aug 8 17:11:52 2012 +0200
geo-rep: don't leak or segfault upon OOM
In glusterd_urltransform, a failed GF_REALLOC would clobber
the would-be-realloc'd buffer, linearr, with a NULL pointer,
(thus leaking that memory) and then control would pass to the
error-handling code that would attempt to free
(via glusterd_urltransform_free) linearr[i], which is almost
guaranteed to segfault when linearr is NULL.
Change-Id: Ia75bf70fd8ff893a18804d49688048ef96db6037
BUG: 846755
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3791
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 94ac434d913d8df4b5f2549863e25c0d369c708e
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Aug 7 13:13:24 2012 +0530
logging: do the 'right' check for loglevel
logging functions should not print anything if loglevel in argument list
is lower than what is set for the process.
Change-Id: Id61779ffe6b76724243aa222c6889dd51a8f2f9b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 846201
Reviewed-on: http://review.gluster.com/3786
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 181af364961aad32469237090d44c70521a4b484
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Aug 7 10:03:47 2012 +0530
core: moved back the pthread_key_t specific variables as global
in a patch to move all the global variables inside 'ctx', moved all
the pthread_key_t specific globals, which needed to be global, not inside
some structures.
Change-Id: I5e7107a8a64f5b80e90fd469fb084f62b2312705
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 764890
Reviewed-on: http://review.gluster.com/3783
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d3ebe18534249e5e290d63857b457d71bb0130f4
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Aug 5 20:32:53 2012 +0530
glusterd: while building graph, set xl->ctx
as glusterfs_'ctx'_t is used as reference in many places, it is
important to set it right. In many places, xl->ctx is assumed to
be present, hence it has to be set right.
Change-Id: I37d767f384edb1819277c4ecee97dd94108aedff
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 845715
Reviewed-on: http://review.gluster.com/3779
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 151a94b16e0aa954c647a62fa99f40bb75f17b64
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Aug 2 13:14:25 2012 +0530
core: reduce the usage of global variables
* move all the 'logging' related global variables into ctx
* make gf_fop_list a 'const' global array, hence no init(),
no edits.
* make sure ctx is allocated without any dependancy on
memory-accounting infrastructure, so it can be the first
one to get allocated
* globals_init() should happen with ctx as argument
not yet fixed below in this patchset:
* anything with 'THIS' related globals
* anything related to compat_errno related globals as its
one time init'd and not changed later on.
* statedump related globals
Change-Id: Iab8fc30d4bfdbded6741d66ff1ed670fdc7b7ad2
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 764890
Reviewed-on: http://review.gluster.com/3767
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2fb1d44e405b9fe3b8bfebcf1af4374c7211bb68
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon May 14 14:23:56 2012 +0530
mount/fuse: ignore any erros that might've happened while resolving entry in resolver.
One error we hit was absence of gfid on backend. While the lookup
code-path generates a new uuid and sets it on file, resolver code
doesn't do that. Since, functionally (atleast after resolving parent
inode, we would be resolving the path in new-graph) both resolver
and lookup does same work, it would be no harm in ignoring errors
during resolving the entry. This would help us to continue with
the _extra_ work (like healing gfid as of now) in fuse_lookup_resume.
Change-Id: If46d5e07c32e67b5744287a6ef55d0b0fe347689
BUG: 821138
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3344
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 230ecbd15f52ce6a3a986b0597ce6aa617a6a41a
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Aug 3 12:11:46 2012 +0530
mgmt/glusterd: Fix a compilation failure when libxml2-dev is not present
Addresses problem introduced by 1e4a2354b57a1eb
Change-Id: I7cea76410769c584af6960860260fbd061a6df8a
BUG: 844696
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/3778
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 053007508672ea8d9ef0c86e6c137c4b8adbb49d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Mar 26 18:44:14 2012 +0530
fuse-resolve: consider cases where an entry should be resolved even when parent belongs to active itable.
When parent is root, the parent inode returned will always be
active_subvol->itable->root and hence there can be cases where we
should explicitly resolve the entry in active graph.
BUG: 804592
Change-Id: I5829278e27435e06785a923ce8776616cedfb519
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3710
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6443fb01e9c52869bb442a6ded6a26a081bacd0b
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jul 31 12:02:22 2012 +0530
performance/io-cache: use pthread_mutex_trylock to hold mutex in statedumps
Do not use pthread_mutex_lock and gf_log functions while dumping information
to statedump, to avoid deadlocks.
Change-Id: I2bb4592126c5d1eacf614130815a839c4a90c59a
BUG: 843787
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3758
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f25c34adec05e95783b20c539b0eaee890ed4995
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Jul 31 11:31:16 2012 +0530
glusterd: Made volume set help/help-xml a non-cluster operation.
- Retained apparent redundant checks in stage, commit phase of set
volume for the help options for backward compatibility
Change-Id: Iaefe3805d6b5eeeced2e7e4870830edf3e61dc87
BUG: 844696
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.com/3761
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 00f2993f1a7b389e03292168a7eccc7c7f4abd1c
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Aug 1 16:28:13 2012 +0530
performance/quick-read: use pthread_mutex_trylock to hold mutex in statedumps
Do not use pthread_mutex_lock and gf_log functions while dumping information
to statedump, to avoid deadlocks.
Change-Id: I0d30b04ae322f131b7a42d277ebd4385e83769e6
BUG: 843789
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3764
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2a894640a68dbc0970fd5e5341ba1f2ed5b4097d
Author: Anand Avati <avati@redhat.com>
Date: Wed Jul 25 22:39:13 2012 -0700
glfsxmp extension
Change-Id: I3859621637025e464bc83d748bae7dff9808643f
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3735
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 849ca775ee5c89bdc085cb0f772a8c28844eb34a
Author: Anand Avati <avati@redhat.com>
Date: Wed Jul 25 23:24:11 2012 -0700
gfapi: let glfs_init() return on non-RPC errors
Change-Id: Ic3a15044434926127b8de273b1033b8ad452290c
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3732
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 921d9c240410bbcda5f4ea8d877b39a999e2e45e
Author: Anand Avati <avati@redhat.com>
Date: Wed Aug 1 23:18:40 2012 -0700
gfapi: set errno in glfs_init()
save errno from glfs_init_done and set it in glfs_init_wait()
Change-Id: I1a2f43a7e7b0f07f279c175df987ff94d642b629
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3771
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 697908c605a930f075ad99d6df4fcce697b213de
Author: Anand Avati <avati@redhat.com>
Date: Wed Jul 25 23:33:33 2012 -0700
gfapi: missed setting port option
Change-Id: I72790de10cefaae3d3307b6fbb9899907b019ccc
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3733
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Bharata B Rao <bharata.rao@gmail.com>
commit a830f4d768aeec5a78acebec028eeaada5d3db59
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Thu Aug 2 20:37:39 2012 +0530
glusterd: Fix glusterd crash resulting from uninitialised pointer
PROBLEM:
glusterd crashes during replace-brick operation as the
pointer old_brickinfo is dereferenced without being initialised.
FIX:
Have old_brickinfo initialised to point to the brick info of
the brick being replaced before dereferencing it.
TEST:
Ran glusterd in debug mode before and after the fix;
process crash ceased in the latter case.
Change-Id: I53f21b5424f534bbdba3b3fc407d4501a2c0052f
BUG: 844332
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.com/3777
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a172aa5364e6c80266e68b5c9815d80bd7c87bd1
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Jul 31 17:04:44 2012 +0530
cluster/afr: Unwind with correct pre/post parent bufs
RCA:
In case of dir fops create, mknod, mkdir, link, symlink, rename
if the fop fails on read-child then unwinds are happening with
all-zero pre/post iatt-bufs. The bug occurs because the parent
bufs are not saved if the response is not from read-child.
Fix:
Save the pre/post-bufs for the first response. If the response
comes from read-child, overwrite whatever we have cached.
Tests:
Attached the mount process to gdb.
Tested that the unwinds happen with proper pre/post iatt bufs in
the following cases:
1) All success case
2) Failure on read-child
3) Failure on non-read-child
4) Failure on all children.
Tested soft-link self-heal to test the change made in that.
Tested errno ENOTEMPTY for rmdir, rename fops.
Change-Id: I82882423d2d766b4f4a3044203bcb5dbcaee1755
BUG: 845242
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3775
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1d9fedbd287f329d18a2218439ddb823cb7078a0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jul 31 12:41:13 2012 +0530
performance/write-behind: maintain a per-inode request queue instead of maintaining per-fd
path based operations like stat etc, whose results will be affected by
writes have to be ordered with writes. With request queues maintained
in inode this can be done naturally, than when they are maintained per
open fd.
Change-Id: Ibdde3b81366f642d07531632fc9062cb44fad2e7
BUG: 765443
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/712
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ec4cdd486195ce8c08f501c1437aa4dade31d23c
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Aug 2 16:23:08 2012 +0530
protocol/server: use pthread_mutex_trylock while dumping statedumps
Change-Id: Iec6f539ee7d36c25aca3960abc6d2611707617c8
BUG: 843821
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3774
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e9fa92a2ddc9c203e0805af945e8af4fe17eb750
Author: yinyin <maillistofyinyin@gmail.com>
Date: Wed Aug 1 21:08:22 2012 +0800
rpc-lib: fix rpc_clnt_reconfig log on remote_host change
Change-Id: I5446d7fb975d4fb8105264e026fef165ae73a925
BUG: 764890
Signed-off-by: yinyin <maillistofyinyin@gmail.com>
Reviewed-on: http://review.gluster.com/3773
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 187f38bc1c258268e9f26e64291ae92366aa420c
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Jul 30 21:01:21 2012 +0530
cluster/afr: Handle child_up & fd not opened case in xaction
RCA:
When an fd is opened while a brick is down, after the brick
comes back up afr issues open on the other brick. It can
fail for a number of reasons (enoent etc). While the system
is in that state, inode/entrylks pre-op happen only on the
brick that is up and fd is opened for fd-fops. post-op should
consider only the bricks where both pre-op and fop succeeded
as success, rest of them as failures. Code now marks only the
children that are down as failures as opposed to child_down &
fd-not-opened. This makes change-log appear as success on the
subvolume where we did not do any fop leading to no change-log
but differences in data/metadata for reg-files.
Fix:
Mark non-participants of fop as failure. This is tracked in
transaction.pre_op[].
Tests:
Simulated the scenario using err-gen on top of one of the client
xlator which fails all fops always. Performed fops and the changelog
represented pending fops on the brick with err-gen loaded. Tested
the case of brick down and perform entry/metadata/data operations
to confirm they still work as expected.
Change-Id: I41905936126b19abba56ca581c0301a894507e1a
BUG: 844987
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3765
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 845ed0112b7e9512a5a8ca75a349151533e846ff
Author: Jules.Wang <lancelotds@163.com>
Date: Wed Aug 1 09:37:09 2012 +0800
mem-pool: remove 'if' by asserting condition directly.
before:
if (!condition) {
GF_ASSERT (0);
}
after:
GF_ASSERT (condition);
BUG: 764890
Change-Id: I9894fcc609579f5efd3f98dbff41ca1487ce6dd2
Signed-off-by: Jules Wang <lancelotds@163.com>
Reviewed-on: http://review.gluster.com/3762
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 08c5d8dc12b457f3445b5d814e11cbbabbe2ac7a
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jul 5 16:58:56 2012 +0530
cli: more clear separation of error messages
the intention is to make CLI output more script friendly.
use ':' as field separator per command and each field should
be meaningful.
this is phase-1 of the change, and hence RFC, once I get review
comments, will be doing more changes, if required
Change-Id: I11e70084f78a197ac50f9401dd7af312e63647ef
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 815194
Reviewed-on: http://review.gluster.com/3753
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 303e5d89e82315a2b478ef14c945549b1f33da34
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Aug 2 00:34:52 2012 +0530
supportability: print all missing frames
earlier, the statedump and backtrace were printing frames only if
it matched type GF_FOPs or GF_MGMTs (GF_MGMT is not in use now).
This made all the frames from glusterd, or any other frames which
got created outside the scope of 'fops' not getting printed.
now, made two classifications, one as FOPs (which gets logged
with the proper name), and another set is !FOPs (ie, else part),
which gets logged with only the op number.
Change-Id: Ifa18cdb75f7afefe6bb489d319b589cda8e64c1d
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 845114
Reviewed-on: http://review.gluster.com/3768
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit cf24057911515a2740b9a1ec41145e1f85a09c80
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Aug 2 01:42:38 2012 +0530
core: remove libglusterfs/src/scheduler.[ch]
* as its not part of the build
* confuses with some TAGS and 'git greps'
Change-Id: I1f97307a8ce486ba56a4a3ad0151276b0a72e096
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 764890
Reviewed-on: http://review.gluster.com/3769
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 91a1a5cb75630f97a558966219a9a15702244fc6
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Aug 1 16:38:34 2012 +0530
performance/read-ahead: use pthread_mutex_trylock to hold mutex in statedumps
Change-Id: I4491c96fc7d9879ba9040dcda3700c81d99ba184
BUG: 843796
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3766
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c8975f24d6d9225d75d93d549552a16c7058eab4
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Jun 6 17:34:03 2012 +0530
event-history: implement gf_log_eh for saving events
Change-Id: I2ddf4e7849bda91bb99423e27082c2bae6800a70
BUG: 795419
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3532
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0bcb0c77c62405f7ce87732d65b7151f7cf3759d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Aug 1 12:09:38 2012 +0530
mount/fuse: initialize entry and negative timeouts correctly.
There was a typo which resulted in updation of attribute_timeout
for both options.
Change-Id: I6e212eaf3570cadde88d2a2c3b44121c893c9427
BUG: 804592
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3763
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit b70b76cbd77ec37d0901b03326bef25784a1b310
Author: Krutika Dhananjay <kdhananj@redhat.com>
Date: Mon Jul 30 22:31:31 2012 +0530
protocol/client: Fix negative return in client_setvolume
PROBLEM:
The function dict_serialized_length could, owing to an error,
return a negative integer (-EINVAL) that gets assigned to an
unsigned int member 'dict_len' of gf_setvolume_req structure.
FIX:
Hold the value returned by dict_serialized_length in local
variable ret (which is a signed int). Test if ret is negative,
in which case the control would anyway branch to the label fail
where the function returns. Otherwise dict_len is assigned with
ret, in turn giving a more meaningful value to the attribute
length.
TEST:
Attached gdb to glusterfs mount process, set breakpoint at
client_setvolume, forced dict_serialized_length to return
-EINVAL (indirectly by forcing _dict_serialized_length to return
-EINVAL after setting count to -1 within its body) and checked
the value of ret (which is now sure to contain a negative value)
whose value will be appropriately tested to decide the next
course of action within client_setvolume: whether to simply
exit due to an error or execute the subsequent statements.
Change-Id: Ib22ad8f30d8ae04acaf2ff5bfee9c348a2c47148
BUG: 789278
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.com/3755
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cdeeea82a4446f599715713c203ef1aff88cde61
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Jul 25 20:46:53 2012 +0530
cluster/afr: Handle failures in fop_cbk gracefully
RCA:
Afr crashes when a last fop response fails and
'fop output' arguments are NULL. Afr does not handle
these gracefully.
Fix:
Changed the fops to not access the 'fop output' arguments
in case of failures.
Tests:
Changed afr wind_cbk code to fail the last response by setting
op_ret as -1 and op_errno as ENOMEM and setting all other output
variables as NULL to test the change. Removed the code to verify
success cases. No crashes or errors seen.
Change-Id: Iad9bc54db093a162f85bfb8dbeeda5b95acd21d8
BUG: 844689
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3760
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b9b142245b098082881e5d075db81db2aa19b1d8
Author: M S Vishwanath Bhat <msvbhat@gmail.com>
Date: Tue Jul 31 16:28:27 2012 +0530
Fix issues in make dist
Change-Id: I2fb3b0b35e2b5fdb08ee1857bf31ec8f65889306
BUG: 844669
Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
Reviewed-on: http://review.gluster.com/3759
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 96047fd55dc09042fa64728a723b7bc0e6cda744
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Jul 29 20:22:07 2012 +0530
cluster/afr: update loc inode after inode_link
RCA:
inode passed to inode_link is not assigned any gfid if the
inode with that gfid is already linked, so loc for opendir
does not have a valid inode
Fix:
Use the linked_inode returned by inode_link in the loc to
perform further operations on the entry.
Tests:
Checked that opendir comes with an loc with valid inode.
Checked that re-opendir happens successfully. Tested index,
full self-heal work fine with the fix.
Change-Id: Idf4ced4cc2320133744962059d363e373af0e5ec
BUG: 826580
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3748
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2d1a9e62f232f014927ab2835f76e1e2642c1c34
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jul 19 20:08:57 2012 -0400
rpc/socket: finish initialization in own thread
...if we have one, that is. This addresses Avati's review comment on
ea7759f1240b1e97684273b9369472695173a66.
Change-Id: I71a272f7eeff8279981a75241d60620ca4975c99
BUG: 764731
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3701
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d64e786ff6fd0d540538048826c5e4e5acc35431
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jul 5 14:30:38 2012 +0530
glusterd: Modifed replace-brick mount cleanup to use lazy umount
Change-Id: I83a985967cbaee4927f1b8ca4bc01c9fb0171522
BUG: 806890
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.com/3143
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit dec82534f4faf70c3d123ea776da177bd62f609c
Author: Brian Foster <bfoster@redhat.com>
Date: Thu Jul 19 15:01:13 2012 -0400
cluster/stripe: handle short writes and errors in writev callback
cluster/stripe write callback handling is broken in the event of
server side errors and short writes due to crudely summing up the
return values from each node. This can produce incorrect results
or cause an application to rewrite the wrong portions of a buffer
in an attempt to handle this condition.
Modify cluster/stripe writev handling to record the requested size
of each write and use this data to return the number of consecutive
bytes written from the original request. This allows an application
to retry a write at the point of error (and potentially consume
said error).
BUG: 809975
Change-Id: Ic35cb1e092c29545205aa32e352485c507534ce0
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3700
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8d504312474be2ee469a74bdaf4f7cd95dd7d6ae
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jul 26 12:50:05 2012 +0530
performance/io-threads: dump the io-threads specific information in statedump
Change-Id: Ib9b9eab2d2e90fce21ef32f0f884101938978859
BUG: 843377
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3736
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 053fa718e7d36f36cfad859b7f2105ced6c4c7c7
Author: Csaba Henk <csaba@redhat.com>
Date: Mon Jul 30 14:48:08 2012 +0200
geo-rep / gsycnd: restore the generic signature for sendmark_regular
Earlier fixes to 842330 changed the generic (*a, **kw) signature,
although that was not related to the issue.
We restore the generic signature as it was used for a reason
(proxy methods that do none or only algebraic transformations
on passed arguments idiomatically have generic signature, both
to serve as visual cue and agnosticism wrt. the inner API).
Change-Id: Ib609a3a58be53d78b7f1221a3c162c6aec8fd488
BUG: 842330
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3754
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7f8eb9146659276948d20a90d915650d2bcce54a
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Jul 25 06:27:57 2012 +0530
libglusterfs/statedump: add start and end markers in the statedump file
Also do not overwrite the statedump file if statedump is taken on the same
process again. Instead add the timestamp to the filename
Change-Id: I451a0decf2dad5c398631cab1fc2a69811c69af8
BUG: 843408
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3738
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7717f77768e6f90abd94712920a81ff0a7eaadcb
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Jul 27 10:51:50 2012 +0530
performance/io-threads: Provide option to turn off least-priority
RCA:
In cases when self-heal is in progress, self-heal fops are starved
because of least-priority. This affects other fops with conflicting
inode, entry locks with self-heal.
Fix:
This patch provides configuring enable/disable of least-priority.
Additional changes:
Moved RCHECKSUM fop to low instead of least because it will still
affect the performance of other fops if RCHECKSUM is in LEAST
priority.
Tests:
Tested that the enabling/disabling of fops is working fine.
Tested that RCHECKSUM fop priority is assigned LOW when
least-priority is disabled.
Change-Id: I8d72872b33e2ac7e1ad3afb27582682b0eb98a80
BUG: 843704
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3743
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 17a10c6f55b130a2d4d0a181bc228fd6224fa12f
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jul 19 13:45:25 2012 +0530
volgen: add option to add trace/error-gen in client volume file
bash# gluster volume set <VOLNAME> debug.trace client
bash# gluster volume set <VOLNAME> debug.error-gen client
would add the corresponding translator in client volume file just
below io-stats translator. (gets added even in nfs volfile)
Change-Id: I698eb9b348c59aaff9967a4e238fabfc40e69a11
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 782262
Reviewed-on: http://review.gluster.com/3699
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a985a08016d569a1b9d2e3aa2b64a65b76c4b18c
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Tue Jul 24 12:44:11 2012 +0530
glusterd: Persisted hooks friendly user.* keys
- Fixed validation of user.* keys in presence of multiple key, value
pairs in a single volume set command
Change-Id: I5b96de2d009fbc79772121308d9b4c0a552bac52
BUG: 825902
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.com/3715
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c374a2b4ad8511417db88ef3b2738333af73b0ec
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Jul 28 12:18:50 2012 +0530
features/locks: Fix statedump code
RCA:
Taking blocking mutex/spin locks lead to dead locks
because of the locking order in statedumps. Also we
were asked to remove gf_logs if possible to avoid extra
cost in signal handlers.
Fix:
changed blocking mutes/spin locks to their non-blocking variants.
Removed gf_logs in locks xlator statedump code-path.
Tests:
State-dump success cases are working fine.
Triggered try-lock failures by putting statedumps in a while loop.
In parallel did chown of the same file in a while loop.
Change-Id: I81539a62f8216f267f57bb703ef132c85bfd557d
BUG: 843781
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3747
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c2d148a4a13d064ade0e8326736f6ae1188bb4dd
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Jul 28 07:49:36 2012 +0530
cli: Prevent creation of volumes with tokens as volnames
RCA:
yyparse confuses volnames with tokens when any of the
tokens 'volume', 'type', 'subvolumes', 'option', 'end-volume'
are used as volnames. This happens because io-stats xlator
name is same as volname in fuse volfile. Both nfs, fuse volfiles
are affected by this problem.
Fix:
We could fix this also by changing io-stats xlator name to
something other than 'volname'. But I am worried of the
backward compatibility issues it may introduce. Disallowing
creation of volumes with tokens as volname seems like a safer
fix.
Tests:
All volume creation operations with tokens as volname give
invalid volume name error.
Change-Id: Ifc63a5c31375e92541b954ec133aa3c8e6a56a02
BUG: 844030
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3745
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b760d7a3f3949c41ac222be57fc07e73840bc61b
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Wed Jul 25 16:56:31 2012 +0530
glusterd: Ensured 'store' data reaches disk.
- Opened temporary file(s) with O_SYNC flag to avoid explicit fsync'ing.
- Sync'd directory entry after creation and rename of 'store' files.
- Thanks to Jeff Moyer's article on http://lwn.net/Articles/457667/
Change-Id: I68a8672dc6a0b24d128de53f3b60c74dd08d8ab8
BUG: 765434
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.com/3726
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ec9f623bef7fd1ad1e2185cdb3e9e709cf49ca87
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Jul 27 09:08:57 2012 +0530
Warnings: Fix set, unused variable warnings
Change-Id: If7ee85aa0d93f9018a76e7f60fcb7dcaf849dbdc
BUG: 839950
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3742
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit bae8e11378e976dac603fc17a1bdeb9ef75f5959
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jul 26 17:16:00 2012 +0530
acl: enable handling of FMODE_EXEC flag
on linux systems, with open(), we can get below flag as per
'linux/fs.h'.
/* File is opened for execution with sys_execve / sys_uselib */
Instead of adding '#include <linux/fs.h>, its better to copy this
absolute number into other variable because then we have to deal
with declaring fmode_t etc etc..
With the fix, we can handle the file with '0711' permissions in
the same way as backend linux filesystems.
Change-Id: Ib1097fc0d2502af89c92d561eb4123cba15713f5
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/3739
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5ec1f6ce5643f60d1c3d1672dddfbc69c1fe6737
Author: Anand Avati <avati@redhat.com>
Date: Thu Jul 26 00:37:56 2012 -0700
gfapi: unglobalize oldvol{file,len}
Multiple initialization of volumes works fine now.
Change-Id: Ibc16957b39325817bc6f9ab90ebac9cefdafabf8
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3734
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 129158d5d395d932a920549b27fee5993f4b1cca
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Jun 27 16:42:35 2012 +0530
cluster/afr: Modified split-brain handling
RCA
The bug is observed because the decision to mark
a file in split-brain is taken outside appropriate locks.
Lookup gathers xattrs outside any lock. The xattrs being
in split-brain in lookup should only be taken as a hint.
Appropriate inodelks should be taken before confirming
a split-brain. Self-heal confirms this at the moment.
If data/metadata self-heal is turned off, inspecting of
xattrs could not be performed so split-brain behavior
does not work correctly if the self-heal options are turned off.
Fix
Self-heals are launched to inspect xattrs even when the
data/metadata self-heal options are turned off. The decision
to heal data/metadata after the xattrs are inspected is based
on whether the options are turned on/off. So decision to set/reset
split-brain flag is taken inside appropriate locks.
Testcases:
tests 33-36 in
https://github.com/pranithk/gluster-tests/blob/master/afr/self-heal.sh
Change-Id: Ia8aeab08208b50c06609ad35a9d72f3d553ee343
BUG: 833727
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3626
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 12749d6976c6d9d33f811d98b61234cc1f8d764b
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Jul 20 15:49:42 2012 +0530
cluster/afr: Filter O_TRUNC in afr-fix-open
RCA:
When open was done while a brick is down, afr opens the file after
the brick comes backup. If this happens after the self-heal on the file
is completed by self-heald etc, the file will end up in truncated state.
Fix:
Filter O_TRUNC while afr-fix-open because afr_open turns O_TRUNC
into truncate transaction, so there will be pending changelog for
the subvolume on which open fails.
Testing:
Had to simulate the race by stopping fix-open until self-heald completes
self-heal on the file after brick online.
Change-Id: I32759cc37f4bb34f206d01606a279f17b246dba4
BUG: 841840
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3705
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 199fa34551acd424c7c9f85be632d5c5e3964d30
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Jul 23 09:22:35 2012 -0400
performance/write-behind: detect short writes and pend an EIO error
Write-behind returns write requests immediately and queues the request
in memory for merging, etc. If a write is incomplete, pend an EIO
error for the next fop. This ensures that write failures are not
silent and potentially ignored.
BUG: 809975
Change-Id: I0e0e6c8e710efab58ccfaf746501d00e459eb7ef
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3712
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 19ab21658325cd0bc7f47f2d14c4be8f5ae148da
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Aug 19 12:08:15 2011 +0530
performance/write-behind: preserve lk-owner while syncing writes.
- This patch also makes syncing of non-overlapping but consecutive
writes parallel. Till now only contiguous writes were synced
parallely.
Change-Id: Icf0d5ea373f30c79fcdc90ba44b7e7a1bc5f0111
BUG: 765141
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/269
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8766d1147174342af2877b4f2830bfb7e398ba85
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Jul 25 08:14:38 2012 -0400
cluster: fix crash on link of named pipe in stripe/replicate vol
A crash occurs when attempting to link a named pipe on a striped,
replicated volume. The cause for this crash is attempting to deref
a NULL inode pointer in stripe_link_cbk(). The RCA for this bug
uncovered a couple of problems:
- AFR ignores the inode pointer it receives on failure (returning
NULL).
- stripe assumes the inode pointer is valid on failure.
Either one of these changes addresses the crash, but this patch
includes both changes. AFR is modified to pass along the inode
pointer it receives (which could still be NULL). stripe is
modified to not assume the inode pointer is valid on fop failure.
BUG: 842825
Change-Id: I9cb2cc918552620929c3ecbd69bc66d4635eafdc
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3727
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 545d838180b343be22a7ef5afd80e914ed865006
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Jul 25 09:56:58 2012 +0530
cluster/afr: Perform data self-heal for non regular files
RCA:
Data self-heal for non regular files open the files
and then proceeds using that fd. This approach
does not work for symlinks because open on symlink opens
the file resolved by it.
Fix:
If the file is not a regular file then perform self-heal using
loc. It needs to get 'big' lock and then perform lookup to get
changelog then erase data part of chagelog, then unlock.
Test cases:
Automated at
https://github.com/pranithk/gluster-tests/blob/master/afr/special-file-self-heal-test.sh
Change-Id: I924a922f5135872efe2cccf2e712ada082c5689f
BUG: 811317
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3724
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ab18346d10983a1875ab3eb1cf72ac738a2a0d91
Author: Brian Foster <bfoster@redhat.com>
Date: Tue Jul 24 08:25:50 2012 -0400
cluster/stripe: don't fail if no fctx on a non-regular file
cluster/stripe broke directory rename. Only check for fctx on regular
files.
BUG: 842652
Change-Id: I8a1e7ff30d57c994082cb10471f610023713ee53
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3720
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7c929966ce31bdddf1e95a717d40602d244a3e53
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Jul 25 23:09:08 2012 +0530
features/index: make pthread_attr_t local to init()
RC & FIX:
No need to carry around pthread_attr_t in index_priv.
So made it local to init()
Tests:
stepped through init() in gdb, it succeeded.
Change-Id: I0525ac0676f9a329fccb0fd064933594ec117261
BUG: 843071
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3729
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5a9a19a2dc855ba5b41542f8aa6e7f75a78f6b6b
Author: shishir gowda <sgowda@redhat.com>
Date: Wed Jul 25 13:08:14 2012 +0530
cluster/distribute: Suppress user xattr mismatch log message
Changing the log-level to DEBUG.
Xattr mismatch can occur when parallel setxattr's race, or when
one of the bricks was down. A subsequent setxattr will fix the
condition when all the subvols are up. In this case, the 'user.swift'
xattr used by ufo was out of sync, but did not cause any other error.
Change-Id: I6fdff78869b8ff72c305bbe122033e6c1d9d3cff
BUG: 838197
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.com/3722
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 36a46d606a19b1112521744cc2831a13cdcb6f41
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Jul 25 15:08:46 2012 +0530
features/index: Fix race in this->private initialization
RCA:
In index_worker function at the time of assigning priv from
this->private, this->private may not be set in init() function
of index xlator.
Fix:
Set this->private before creating the thread.
Additional Changes:
Added code to handle error path completely.
Test cases:
Attached the process to gdb and simulated failures.
executed fini in gdb using call fini(this) after init
was successful.
Change-Id: I1874a30d009a35352173b827574cf83daf431453
BUG: 843071
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3728
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit a9e149f5b40c8d736419b80ed6ee6c0c3f75b6ec
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Jul 25 16:07:00 2012 +0530
gsyncd / geo-rep: Fix sendmark() invocation for Normal Mixin
Change-Id: I0ae81ab01418becba83e401ec36c6db5323945e8
BUG: 842330
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/3725
Tested-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit feb049e012b16fa02328c402d369693283ac5b92
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jul 24 02:31:05 2012 +0530
libglusterfs: fix creation of spurious root inodes
Suppose lookup is sent on a newly created inode (gfid is root gfid),
and in the call back inode_link is done, where if there is an inode
already present in the inode table for that gfid, then we start using
the present inode and the newly created inode supposedly gets destroyed
when refcount comes down to zero through inode_unref calls.
But inodes with root gfid are not unrefed. Now since in inode_link,
the gfid has already been copied to the new inode and later the actual
inode is found from the inode table, the new inode does not gets unrefed
if its gfid is root gfid. Thus those spurious inodes with root gfid will
be present throughout the lifetime of the filesystem.
To fix this first search the inode table for an inode, with the gfid, present
in the stat structure received as an argument. If the inode is not found,
then copy the gfid to the newly created inode. Now whenever unref is called on
on the new inode it gets unrefed and thus eventually gets destroyed
Change-Id: I0f25f0a8dca3245abda1c322c216f063b52cf842
BUG: 841188
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3716
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a13b52ff9a8b3d36a4dbff9ecbefe1028dc59d09
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jul 24 01:13:25 2012 +0530
Fixes for gsyncd / geo-rep and FUSE listxattr
This patch fixes two problems with recent changes to
Geo-Replication
First:
------
Recent changes to geo-replication relies on Rsync to tranfer
extended attributes. Essentially Rsync would invoke a listxattr()
and then getxattr() the set reutrned by listxattr() and finally
transfer it to the remote slave. Xattrs like security.selinux would
create problems as they are not allowed to be set explicitly (unless
there's a rule that allows this). So, to make Rsync behave sanely we
filter out all "*.selinux*" xattrs from listxattr() (which is getxattr()
with ->name as NULL).
Second:
-------
Python's "if {..} else {..}" shortcut ".. and .. or .." was misused here.
This is a straightforward fix by interchanging last two variables (classes
in this case). Also fix a typo in sendmark_regular() definition.
Change-Id: I097b5f5d88a36c7eef5560a78d4332948a545942
BUG: 842330
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/3714
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 4fda9c0477f15f84b8af5e8baf73f1de3710ee5c
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Jul 23 13:34:27 2012 -0400
afr: pass back xdata in create
A striped, replicated volume spits an error on file creation because
stripe requires xdata to process stripe information and AFR isn't
passing it back.
This fix was suggested by Amar Tumballi.
BUG: 842373
Change-Id: Ia7063590ca5e873d4a4e155989cf067e8a07501f
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3713
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 28a598e9fc01aa28c7dbc17169f6ea3b4bc56427
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jul 20 16:50:50 2012 +0530
libgfxdr.so: change license
Change-Id: I049441e465127195c192443ab0234548d2449e50
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/3704
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Bharata B Rao <bharata.rao@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit cd8d82463b443d9b031a012a2402fcd2a49c3603
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri Jul 20 17:39:43 2012 +0530
gsyncd / geo-rep: Fix typo in 'purge' flow
Change-Id: I6c329b895178545d16b0cb9f01ad116f5342f752
BUG: 841855
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/3706
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 11dc8df7834939829519c79e619ac7cee124cac0
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Jul 18 04:07:20 2012 +0200
geo-rep / gsyncd: convert ignore-deletes to a mixin too
Change-Id: I164a1d1dd5f15569afd6806834119a6844949df0
BUG: 841062
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3684
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit d0c91bcc8ea13f7bca94f053d8aca1aa0fc45599
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Jul 18 03:59:00 2012 +0200
geo-rep / gsyncd: add support for sending xtimes through rsync
Note that in said mode metadata synchronization is best effort:
rsync syncs metadata at last so if rsync is interrupted in between
xattr sync and metadata sync stages, then file will be considered
in sync
Change-Id: I1c75eab33b0a1000abf3ad36b2d484a89eeda1bd
BUG: 841062
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3683
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit d4fc98050d6a20dbb9b740403b21716912291711
Author: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Thu Jul 12 17:35:37 2012 +0530
glusterd: Refactored brickinfo APIs
This patch modifies the existing brickinfo function signatures
and/or names to do one thing right and call them by 'appropriate' names.
- Decoupled brickinfo_get and is_brickpath_available
- Removed dead comment about realpath(3) in canonicalize_path
- Renamed glusterd_brickinfo_from_brick to glusterd_brickinfo_new_from_brick
to make the name of the function reflect that an allocation is happening
Change-Id: I29daba6d431ca799d43c927b9dfbaeda327e83e8
BUG: 764890
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.com/3668
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit e01e64e509e045887e392972ad79be3b6d593b65
Author: Anand Avati <avati@redhat.com>
Date: Wed Jul 18 16:28:00 2012 -0700
fuse-bridge: utilize the option handle framework for double
Also make other option initialization code use GF_OPTION_INIT
framework for setting options and default values.
Change-Id: I68a5c7b674f487fef9d23195654d3a5b2f7b8811
BUG: 841417
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3698
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 496723756d2593390a39d05b3ca217c25102059e
Author: Anand Avati <avati@redhat.com>
Date: Wed Jul 18 16:12:01 2012 -0700
libglusterfs/options: enable validator macros for type 'double'
Values like 'entry-timeout' and 'attribute-timeout' in FUSE are of
C type double. Enable support in the options framework for using
this type.
Change-Id: If1a619595a5925937e88540710860df27347acd0
BUG: 841417
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3697
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 965b089c9638efd9c2e7057cf1b7ef86c994628e
Author: Anand Avati <avati@redhat.com>
Date: Wed Jul 18 15:50:35 2012 -0700
fuse-bridge: expose negative entry caching of FUSE
Fuse kernel module supports caching negative entries, enabled
by specifying a timeout while returning ENOENT to lookup. This
patch enables the functionality to be enabled with the command
line.
Also fixed a typo bug in mount.glusterfs.in.
Change-Id: I47eab2834cca9a05887266358afbf504bbb4c489
BUG: 841417
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3696
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
commit ca924271c6cafdb7e20f06c1a41f20ab8d4046e5
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Tue Oct 18 17:57:44 2011 +0530
glusterd: atomic store update.
All 'updates' to store are done in their respective tmp files and a rename to
their original copies is done in one pass. Failure to write or rename
successfully, promptly reduces the store's revision no., giving us an
opportunity to 'correct' it via peer 'detach-attach' operations, if need
be.
Change-Id: I44a33c41cb4d3d1cfbb455bc1f2f074d4f17dade
BUG: 765434
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/654
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a02f7133ac20c1aae91d26b56c83ea7a76b1bf8f
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jul 17 22:54:21 2012 +0530
FUSE: ignore setxattr for some keys from gsyncd aux mount
Context
-------
gsyncd/geo-rep plans to rely on Rsync to sync extended attributes.
When this is in place, all xattrs *visible* on the mount point would
be candidate for syncing. This set could include gluster internal
xattrs too (as xome xlators do not filter out in their cbks). Syncing
these xattrs to the slave could result in unexpected functioning of
the slave mount.
Soln.
-----
For gsyncd auxillary mounts (identified by client_pid -1), we only
allow xtime related xattrs to go through and silently ignore (w/o
propagating error back to the client) the rest of them. This provides
a future proof solution as we need not worry about what xattrs show
up on the mounts. Also, 'user' namespace xattrs are always passed
through even if it's from a gsyncd aux mount.
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Change-Id: I6fac5e03d2b25fa4cdece4b2897fb202617b3c23
BUG: 841062
Reviewed-on: http://review.gluster.com/3687
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 04fcabef8680f9cb9aa2e2740a284adee9053279
Author: shishir gowda <sgowda@redhat.com>
Date: Fri Jul 6 09:54:33 2012 +0530
cluster/distribute: cli support for setting directory-layout-spread
gluster volume set <volname> subvols-per-directory
Change-Id: I5f1420eeb2268897d9b4c70edb933ed1f07649d1
BUG: 838006
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.com/3634
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5ae388dc0d619c2c3785a31d04e11c5e98a96e18
Author: Anand Avati <avati@redhat.com>
Date: Wed Jul 18 13:53:59 2012 -0700
glusterfs-api.pc: include pkgconfig file in -devel RPM
Previous patch missed out including the .pc file in the -devel
RPM while purging the -api.rpm.
Change-Id: I895feefc62e88a962a829612aa829401fed081f8
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3693
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e6fbcb9256fe9c86a930147abd746418cdc68445
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Jul 16 13:44:08 2012 -0400
Example of using libglfs from Python.
Change-Id: I081582c457428d55db8ec1ed6d90f1e439f51f0d
BUG: 839950
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3675
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8c6c15c69f34eea28974b00ef221640d6223a2f5
Author: Anand Avati <avati@redhat.com>
Date: Thu Jul 12 15:40:43 2012 -0700
glfsxmp: libgfapi based example
This is an example application which uses libgfapi. It is
a complete autotools based build system which demonstrates the
required changes in configure.ac, Makefile.am etc to successfuly
detect for and build an application against libgfapi.
There are two approaches to building a libgfapi based application:
1. In the presence of pkg-config in your build system.
This is the recommended approach which is also used in this example.
For this approach to work, you need to build glusterfs by passing
--pkgconfigdir=/usr/lib64/pkgconfig (or the appropriate directory)
in your distro. This already happens if you build RPMs with the
glusterfs.spec provided in glusterfs.git. You will also need to
install glusterfs-api RPM.
2. In the absence of pkg-config in your build system.
Make sure your LDFLAGS includes -L/path/to/lib where libgfapi.so is
installed and -I/path/to/include/glusterfs where the 'api' directory
Change-Id: Ic4eab2df002d7e8d20593a03e643859423048848
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3666
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 4e24365405e48d36c0550a8a5ed5b2c0fbad521e
Author: Anand Avati <avati@redhat.com>
Date: Thu Jul 12 15:51:41 2012 -0700
glusterfs-api.pc: pkgconfig for API consumers
Change-Id: I08c60ff9ec5d336077c39f903720f8850d4ddc72
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3665
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
commit c1f2913409909a1ddd0e6b69abbf30270833b9ee
Author: Anand Avati <avati@redhat.com>
Date: Thu Jul 12 15:37:38 2012 -0700
gfapi: API/library for accessing gluster volumes
Change-Id: Ie4cbcf91b58218bebf23cf951c313aceeb29f311
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3664
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Bharata B Rao <bharata.rao@gmail.com>
commit d39ccb05a21e1dc3ed716707bd253cb02f4019f4
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Jul 18 13:55:39 2012 -0400
libglusterfs: remove debug log messages from gidcache
The debug log messages for every cache lookup/add pollute the debug
output.
BUG: 800892
Change-Id: I6b75fd5b7005b8c007106347de8827a0d6c2fd03
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3692
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4d5e34e7a36e70903123dcbb56d80f826bab8f64
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Jul 18 08:45:36 2012 -0400
mount/fuse: check for fuse inval notify support when fopen-keep-cache enabled
The fopen-keep-cache feature relies on the fuse notification system
to operate correctly. As Csaba has pointed out, the inode invalidation
functionality was added in FUSE version 7.12. Require that the user
have 7.12 or later to enable fopen-keep-cache. If not supported, warn
the user and disable the feature.
BUG: 833564
Change-Id: Ib9eecb56b689d8edff118b34e2dcc7dba6539b04
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3690
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d7dce13a0816c5b9709d13b31e80687ee5db507f
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Jul 17 17:46:12 2012 +0200
geo-rep / gsyncd: rsync option cleanups, fixes
- add two tunables for rsync: "rsync-options" and "rsync-ssh-options"
- always pass "--no-implied-dirs" to rsync
Change-Id: I3d67a4cba8cabd681edac80e6b1fb8ea322008bd
BUG: 841062
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3682
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 7c66e02454f60b04edc602ccad0ffb180fff0972
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jul 17 16:44:46 2012 +0530
stripe: filter coalesce key in getxattr()/listxattr()
as 'stripe-coalesce' is an internal key, no need to show it on top
of the mount-point.
Change-Id: Iab836e73d59c42774db8a2eee13fe3b0cd994bc9
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 801887
Reviewed-on: http://review.gluster.com/3680
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
commit 34e508f9acbb99eeeb89d54d20bb58917867b049
Author: Anand Avati <avati@redhat.com>
Date: Mon Jul 16 15:50:30 2012 -0700
glusterfs_ctx_t: un-globalize the filesystem context
So far there has been a global glusterfs_ctx_t object which
represents the running instance of the filesystem (client or server).
It contains the various graphs, connection to the management daemon
over which new graphs are obtained, calls stacks issued on this
filesystem, and a bunch of such things.
With the introduction of libgfapi, it is no more true that there will
be only one filesystem context in a process. Applications can
be written to use libgfapi and obtain serveral instances of different
filesystems/volumes in the same process.
This involves messy untangling of assumptions inside libglusterfs that
there would only be one global glusterfs_ctx_t and offload that
assumption to glusterfsd/ and cli/ (where it is true).
Change-Id: Ifd7d1259428c26076140a5764a2dc7361694139c
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3678
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 1f45b77aca5ab6af625a383d34f0b3f0d9e72f38
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jul 17 13:44:32 2012 +0530
storage/posix: use the size returned by getxattr to allocate memory
Change-Id: I71c234b12a1d16405e508b715932022fdce346f0
BUG: 838195
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3681
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a67dc638f90c3b952301c513a11dafb8c9c7b9ac
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jul 17 10:50:43 2012 -0400
rpc-transport/socket: Add SSL support.
Based on OpenSSL. Key/certificate management is still manual. Enabling
SSL also enables multi-threading, though multi-threading can be forced on
or off using a separate option.
Change-Id: Icd9f256bb2fd8c6266a7abefdff16936b4f8922d
BUG: 764731
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/362
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit eb3b01da9a9c427266d4499655aabcc61d2ad69f
Author: Anand Avati <avati@redhat.com>
Date: Mon Jul 16 14:03:06 2012 -0700
common-utils: implement generate_glusterfs_ctx_id()
This patch creates a common and shared version of the often copy/
pasted generate_uuid() function, which is used to create an ID string
to uniquely identify an instance of a glusterfs process/glusterfs_ctx_t.
Change-Id: Ie4e697ae28b6e954c5c261c69e37738f289d77e4
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3677
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit aa4725db775923120aa8ea6db6b9fad5bf0ec6f3
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jul 16 03:51:10 2012 +0530
storage/posix: use ssize_t variable to get the return value of getxattr
Change-Id: Ida065e108a1d2a61b134fb847e8c4981b46fc3c6
BUG: 838195
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3673
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b13149c4eba315eb8c524d3f2a431c06530c8805
Author: Niels de Vos <ndevos@redhat.com>
Date: Mon Jul 16 18:11:17 2012 +0200
build: Create directories and files that get created during runtime
This should not be needed for files marged as "ghost", but rpm-4.9 is
broken in this respect :-(
Building the packages works again:
$ make dist
$ rpmbuild -ta glusterfs-3git.tar.gz
The now created files and directories are not packaged in the RPM, but
are marked as belonging to the packages. Here a example for
glusterfs-geo-replication:
$ rpm -qlp glusterfs-geo-replication-3git-1.fc17.x86_64.rpm \
| grep /var/lib
/var/lib/glusterd/geo-replication
/var/lib/glusterd/geo-replication/gsyncd.conf
$ rpm2cpio < glusterfs-geo-replication-3git-1.fc17.x86_64.rpm \
| cpio -t --quiet '/var/lib/*'
$
Change-Id: I32019cfbf40e25d9b7ce875fa92b98bae19dabee
BUG: 839668
See-also: https://bugzilla.redhat.com/show_bug.cgi?id=839656
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.com/3674
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f3cbc97d96901a5865c5768c9b5a77b07a0bb015
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Jul 16 13:51:09 2012 -0400
libglusterfs,mount/fuse: implement gidcache mechanism in fuse-bridge
This change genericizes the cache mechanism implemented in commit
8efd2845 into libglusterfs/src/gidcache.[ch] and adds fuse-bridge as
a client. The cache mechanism is fundamentally equivalent, with some
minor changes:
- Change cache key from uid_t to uint64_t.
- Modify the cache add logic to locate and use an entry with a
matching ID, should it already exist. This addresses a bug in
the existing mechanism where an expired entry supercedes a newly
added entry in lookup, causing repeated adds and flushing of a
cache bucket.
The fuse group cache is disabled by default. It can be enabled via
the 'gid-timeout' fuse-bridge translator option and accompanying
mount option (i.e., '-o gid-timeout=1' for a 1s entry timeout).
BUG: 800892
Change-Id: I0b34a2263ca48dbb154790a4a44fc70b733e9114
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3676
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 21a9883c20c875783ac3f6367a62b7df47278366
Author: Anand Avati <avati@redhat.com>
Date: Thu Jul 12 22:48:13 2012 -0700
common-utils: implement iov_copy
Change-Id: I7ab97279dafc1211b417e1c03332572887453c66
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3663
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Shishir Gowda <sgowda@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
commit 3829200d84e56cec4391aee9ab392256ca795d97
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Jun 13 14:15:14 2012 +0530
geo-rep / gsyncd: fixes to communication with child processes
due to not using the proper Python keyword, errhandler thread
was possible to run into empty select
Signed-off-by: Csaba Henk <csaba@redhat.com>
BUG: 764678
Change-Id: I3c39e718e72545c27d50fd73aa6daf54062331b0
Reviewed-on: http://review.gluster.com/3560
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9caf06b4ae7df37fe3a035a74286447c6e852ee0
Author: Csaba Henk <csaba@redhat.com>
Date: Tue May 22 14:03:32 2012 +0530
geo-rep / gsyncd: sanitize error log of external commands
If a command invoked by gsyncd fails, gsyncd makes a log
of what comes out on its stderr. So far the log indeterministically
broke lines at random places. Now put some effort into reconstructing
original lines and having a faithful log.
BUG: 764678
Change-Id: I16fcc75d3e0f624c10c71d9b37c937ca677087cc
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3561
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cc1f3413b814dbccad9bdfca31902277d37935e4
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 30 13:29:18 2011 +0530
storage/posix: implement native linux AIO support
Configurable via cli with "storage.linux-aio" settable option
Change-Id: I9929e0d6fc1bbc2a0fe1fb67bfc8d15d8a483d3f
BUG: 837495
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3627
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 4958bde9f0437875eb80988b0bb1f2b977f6f92c
Author: Anand Avati <avati@redhat.com>
Date: Wed Jul 11 16:23:44 2012 -0700
syncop: accomodate non-syncenv calls
Use mutex/cond and support syncop_XXXXXX() calls in non-syncenv
environments. syncenv environments continue to use swapcontext
based soft context switches. In non-syncenv environments this
blocks the caller thread on the mutex. The intended use case is
in libgfapi where it is expected to block the caller thread while
performing synchronous calls.
Change-Id: Id6470c99bdc2fe4b7610372139f7fa99b2da400b
BUG: 839950
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3662
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 2701579e78b41595de8c164e37502aa685d10279
Author: Jim Meyering <meyering@redhat.com>
Date: Fri Jul 13 19:20:19 2012 +0200
cli-xml-output.c: avoid NULL-deref upon OOM
Fix typo: s/buf/*buf/ in test after *buf = xmlBufferPtr(...
Spotted by coverity.
Change-Id: I92cd317832818647009a74f2a8407b5d3ecb958c
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3670
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2cad09534811d54cf9465e1fb2e4bf05c2443d93
Author: Jim Meyering <meyering@redhat.com>
Date: Fri Jul 13 18:38:52 2012 +0200
gsyncd: don't dereference NULL upon failed realloc
Fix typo: s/buf/*buf/ in test for failed *buf = realloc...
Spotted by coverity.
Change-Id: Ie1db59956e331c3691f4ed470a3fbaf2bd2e2055
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3669
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7f60b403140a00dd38106d93a0eb67a7c4126246
Author: Jim Meyering <meyering@redhat.com>
Date: Fri Jul 13 10:29:48 2012 +0200
remove useless if-before-free (and free-like) functions
See comments in http://bugzilla.redhat.com/839925 for
the code to perform this change.
Signed-off-by: Jim Meyering <meyering@redhat.com>
BUG: 839925
Change-Id: I10e4ecff16c3749fe17c2831c516737e08a3205a
Reviewed-on: http://review.gluster.com/3661
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 22fbcac63374f18783a5767ae4eaa5283ce02b7e
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jul 11 16:45:33 2012 +0200
no semantic change: reverse condition and if/else clauses...
Reverse an if-condition and the corresponding then/else code
blocks to hide a false-positive if-before-GF_FREE from the
useless-if-before-free script.
Signed-off-by: Jim Meyering <meyering@redhat.com>
BUG: 839925
Change-Id: Ia68558218d63ae77b6c1c85e15231b66cce5bd49
Reviewed-on: http://review.gluster.com/3651
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit abe4e0656d6454f1068b2b3fcc66076eebdd5a39
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Fri Jul 13 16:23:51 2012 +0530
libglusterfs: syncop for flush ()
Change-Id: I17f925345782313c75102c4767121ba8e283028e
BUG: 764813
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3667
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e628ff98fa872a4760fc88c59656651b86ac4ea6
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Jun 13 12:08:38 2012 -0400
fuse/md-cache: add support for the 'fopen-keep-cache' mount option
fopen-keep-cache disables unconditional page-cache invalidations
on file open in fuse (via FOPEN_KEEP_CACHE) and replaces that
behavior with detection of remote changes and explicit
invalidations from mount/fuse. This option improves local caching
through the page cache and native client.
This change defines a new 'invalidate' translator callback to
identify when an inode's cache mapping has been determined to be
invalid. md-cache implements the policy to detect and invoke
inode invalidations. fuse-bridge and io-cache implement
invalidate handlers to invalidate the respective caches (page
cache in the case of fuse).
BUG: 833564
Change-Id: I99818da5777eaf06276c1c0b194669f5bab92d48
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3584
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 719b62586c5cbdfecf2d60c28fb1819249314c12
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jul 5 13:34:28 2012 +0530
protocol/server: return 'xdata' even in case of error
helps to better utilize dict for more clarity on
errors, if required.
Change-Id: I3ff90e16be946e5f60974d4bde68a729d596c9de
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 826982
Reviewed-on: http://review.gluster.com/3633
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bcdc15093389b39351e03b00bebfbef9fd0f7f61
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jul 12 22:59:04 2012 +0530
core: remove the unused files - round 2
BUG: 764890
Change-Id: I3eb626eeaa2a09f0e248444f560c2a0eaf46c642
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/3660
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 38e88baf8801e8935e81ebcf17ab764145563ed8
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Jun 30 23:55:54 2012 +0530
rpc: variable name changes
's/3_1/3_3/g' in case of glusterfs protocol
's/3_1_/_/g' in case of CLI and mgmt protocol
Change-Id: I6e6510d02c05f68f290c52ed284c04576326e12c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 764890
Reviewed-on: http://review.gluster.com/3632
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d72e1b65d783de5d2d429db8ecd6ee28f4ff9099
Author: Niels de Vos <ndevos@redhat.com>
Date: Thu Jul 12 12:39:33 2012 +0200
extras: install clear_xattrs.sh
The script was not installed by default, this breaks building the RPM
packages since Change-Id Iba695a6d19389fbc1776da5e939d67318916aadf.
Change-Id: I4fb982cb5217dc7b3ec3c7a664dd3997a2e05170
BUG: 812214
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.com/3659
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4eec605cb40e365e17cdb7be3b87bc145dba6a1f
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Tue Jul 10 09:33:02 2012 -0400
calls to dict_allocate_and_serialize() are not 64-bit clean
All calls to dict_allocate_and_serialize() pass the address of a 32-bit
type, but must cast it to the 64-bit pointer type (size_t *).
This happens to work on LE machines, but even if it's apparently benign,
it's still a bug. On BE machines it is not benign.
GF_PROTOCOL_DICT_SERIALIZE() hacks around it by creating a size_t temp
var, but that's, well, a hack, IMO when you consider that all the callers
are actually passing &<u_int>; the param should just be a u_int * and
eliminate the buggy casts and the temp var in the macro.
Nobody apparently uses the Fedora/EPEL PPC RPMs, but they might. People
are trying to build gluster.org bits on SPARC and tripping over this.
Change-Id: I92ea139f9e3e91ddbbb32a51b96fa582a9515626
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
BUG: 838928
Reviewed-on: http://review.gluster.com/3642
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 643915bd86aca1e6d26eace082e41b3fd3e5d40a
Author: Jim Meyering <meyering@redhat.com>
Date: Tue Jul 3 17:06:46 2012 +0200
geo-rep: don't let unexpected status provoke undefined behavior
glusterd_gsync_read_frm_status reads what is expected to be a NUL-
terminated status string from the specified file, but makes two
mistakes when trying to do the favor of trimming trailing spaces.
Do not let a leading NUL byte of status cause us to read buf[-1]
and possibly to clear that and any preceding "trailing" spaces.
Do not let a blen-byte input (with no NUL byte) cause our use of
strlen to access beyond the end of non-NUL-terminated buffer.
I looked at this code because coverity reported that it was
assuming a read-provided buffer to be NUL-terminated.
Change-Id: I140be0948e31196e5be08766d4e6400bf6f4dfa1
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3647
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1cf827036f636c2e0030437e97d310bc4ac0b9d3
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue Jul 10 16:47:07 2012 +0200
extras: add clear_xattrs.sh to the glusterfs-server sub-package
Change-Id: Iba695a6d19389fbc1776da5e939d67318916aadf
BUG: 812214
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.com/3644
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e97cee6aa660e5433371857854a3c710ffe448a7
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon Jul 9 01:58:30 2012 +0530
storage/posix: handle getxattr failures gracefully
Use proper variable types for getting return value of getxattr calls,
which otherwise can lead to segfaulting of processes or page allocation
failures in the kernel.
Change-Id: I62ab5d6c378447090c19846f03298c3afc8863ba
BUG: 838195
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3640
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a9eae0c7d849f6ab86e1a8faab6a78b760994b91
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Jul 5 08:45:52 2012 +0530
core: check for pre-allocated blocks in backend fs, fix it.
There is a possibility that the backend FS (like XFS) can
allocate blocks beyond EOF for better performance reasons, which
results in 'st_blocks' with higher values than what is consumed by
the file descriptor. This would break few logic inside GlusterFS,
like quota behavior etc, thus we need the exact number of blocks
which are consumed by the file to the higher layers inside GlusterFS.
Currently, this logic won't work for sparse files (ie, file with holes)
Change-Id: Ied216733a8862e84f7da8386ae0a144f3f5cd5f2
BUG: 817343
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/3631
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fcadee3f74f25b1046d83286bf3deac20a2987d5
Author: Jim Meyering <meyering@redhat.com>
Date: Tue Jul 3 16:32:25 2012 +0200
glusterfsd: don't ignore tmpfile write failure (2x)
In both glusterfs_volfile_reconfigure and mgmt_getspec_cbk,
we fwrite to a temporary file, fflush the stream, and then
rewind and read from it. However, if either the fwrite or
fflush were to fail, we would have ignored a write failure
and would then read and process corrupt or incomplete input.
In each case, add a test of ferror so that we don't ignore
the write failure.
Found by inspection.
Change-Id: I8e84deb7d020a907870c9da2dde5c7371ce6ddb7
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3648
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit abf1918d7bcce0a6d9723724ad21c9b57de975ca
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 14:13:45 2012 +0200
cli: cli_cmd_get_confirmation: don't reference answer[-1] for NUL input
Change-Id: I83baa54fc5392e92a6a451c549d356ff1ffc92cb
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3606
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 407248facffe0d62eb858b8a0430a670468983ce
Author: Jim Meyering <meyering@redhat.com>
Date: Mon Jul 9 22:50:09 2012 +0200
cli: print_brick_status: don't smash stack
For bricklen > 110 (i.e., 2 * fieldlen), the if-clause
would be executed 2 or more times, making strncpy write
past the end of "buf", clobbering the stack. Rewrite,
removing unnecessary use of strncpy, strlen and decl/use
of the temporary buffer, and instead, specifying precision
via a printf-style format directive.
Coverity identified the static buffer overrun.
Change-Id: I176386e752c397dea22265de9f3c6eb631334f4f
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3646
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 86c5950b278626cecc020fab96edb0252d9a6bcd
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 13:56:36 2012 +0200
read_conf: don't let a corrupt config file cause invalid line[-1] reference
Change-Id: Ifbc698768d9418a54c1501efa335edd4048cfd41
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3603
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8cb337bc67a6b3bf1934c6f0a9a63e90273a44b4
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 11:33:10 2012 +0200
gsyncd: don't let a bogus config file make us read/write buf[-1]
Change-Id: Ic55c28c572c1878f8a223ae2fd25d301a7ef0c12
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3596
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ffedb21479a06fa910f61c9c46674397cdf7f0dc
Author: Jim Meyering <meyering@redhat.com>
Date: Tue Jun 19 11:41:19 2012 +0200
glusterd: avoid buffer overrun for over-long volname
[in glusterd_store_is_valid_brickpath]
When strlen(volname) is no smaller than sizeof(volinfo->volname),
volinfo->volname would end up not being NUL-terminated.
Then, a use of that buffer that expects it to be NUL-terminated
(i.e., glusterd_store_brickinfopath_set's GLUSTERD_GET_BRICK_DIR)
will access beyond the end of the buffer.
Instead, diagnose the too-long volume name and fail.
Change-Id: I655d8638547bf342d33280c14ff1edacc3cdeb5a
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3591
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fe69e1312649504c0683a6d7daecc54b3b2dea98
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 10:01:08 2012 +0200
nfs-common: don't let 0-length path cause buf[-1] access
Change-Id: I5f0e93448a954aff1ff08a0980fb9bfd60e63988
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3594
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 99d887ae0b1a24e6a1d6ff6c7e2d91d44b191185
Author: Jim Meyering <meyering@redhat.com>
Date: Tue Jun 19 15:21:37 2012 +0200
xlator options: remove overwritten data-self-heal initializer
In the struct volume_options, the "data-self-heal"
.default_value = "" setting appeared before a setting of
.default_value = "on". Remove the former.
Change-Id: Ieddcc18f61581f9448d806cd8bf8eefaaf0118b9
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3589
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b29d7d6b9d7b3123e306288d071d8e6921d8156b
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Jul 11 21:59:20 2012 +0530
rpc: add extra arguments to _callback's actor function
Need to differentiate the callback functions based on which
rpc-clnt the callback is received. without it, all callback
actor handling will be like global.
BUG: 839345
Change-Id: Ide024f5585eab3c5fe6c3b33250772fb6e8ad655
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/3656
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8ee66ef7e3d937284bbc0351d3de3a5f84e6877e
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Jul 11 22:25:30 2012 +0530
core: remove unused code
BUG: 764890
Change-Id: Ia8bcaa7a4daeb706bcb0bba24b2e634e9ca20d49
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/3657
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f84c1468b52d954ae32cd375eb65a84ab1e6ea17
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Jun 30 08:28:10 2012 +0530
xlators/protocol: better filename
3_1 name was used for very first version of GlusterFS which
used RPC for its protocol, even though we changed protocol
after 3.1.x, we kept the name of few files as is. Changed
the file names to something better.
Change-Id: I297f1979e7c7e909e60674eec2e632506bc776f5
BUG: 764890
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/3628
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 280ecfab7f9de1191b807a1d1af2c3e67ea15cb9
Author: Amit Chauhan <amitchauhan.gfs@gmail.com>
Date: Wed Jul 4 18:28:48 2012 +0530
Gluster Cli:Pressing Control-d hangs gluster cli
Gluster Cli hangs on pressing CTRL+d. This happens due to
break statement was used when it reads end of stdin.
exit statement is used instead of break.
Change-Id: I2b0e00c0c5fbe8cb9182a96c06ed052d79845087
BUG: 807563
Signed-off-by: Amit Chauhan <amitchauhan.gfs@gmail.com>
Reviewed-on: http://review.gluster.com/3630
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3e6a3412f53eefd7275a1a146993be31f309bf7e
Author: Anand Avati <avati@redhat.com>
Date: Thu Jun 7 23:23:55 2012 -0700
md-cache: cache SELinux and Posix ACL xattrs only if enabled
Fetch and cache SELinux and Posix ACL extended attributes only if
they are enabled in the command line respectively. Fetching the
extra extended attributes is pointless and negatively impacts
performance
Change-Id: I1bd1dbb1abb4a6929fad5f78bbfeaab8542ab4e2
BUG: 765785
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3538
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 85fdcbbcecf8f90aa4beae8a7267cea8e0212a9e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jun 12 19:17:41 2012 +0530
glusterd: copy /etc/glusterd to /var/lib and remove /etc/glusterd instead of moving
* Change default directory from /etc/glusterd to /var/lib/glusterd
Change-Id: Iefa82e4fdb94ce5a84dfb40855c80e16e9ffcc40
BUG: 830218
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3548
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2634b2b48de779ef03899b2adf886cb5ede0f0f2
Author: Anand Avati <avati@redhat.com>
Date: Mon Jun 25 19:37:09 2012 -0700
nfs: make NFS filehandles deterministic
The NFS3 file handles now includes just the bare minimum of
(ident, exportid, gfid) and removes legacy 'variable' members
which are unnecessary since the introduction of GFID backend
Change-Id: Iff6e4435d170074b18d208742b48e79b130e2a4d
BUG: 835336
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3616
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit c815079762776f05bdced3a3e72e86999a53bbc3
Author: Anand Avati <avati@redhat.com>
Date: Tue Jun 26 21:06:39 2012 -0700
cluster/afr: post-op-delay support
post-op-delay introduces an artificial delay between the OP and
POST-OP-CHANGELOG phases of a write transaction to increase the
probability of changelog-piggyback and eager-locking to work
more efficiently.
Also enable eager-locking by default.
Change-Id: I865ca4b68512c44818719c7e388952f15d53e6c2
BUG: 836033
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3621
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit 7aedfd08af5aec13d6b9f6112498139568426786
Author: Anand Avati <avati@redhat.com>
Date: Wed Jun 27 15:04:55 2012 -0700
cluster/afr: cleanup lk_owner and PID mess
Historically PID (frame->root->pid) was used by the locks translator
to identify a locker (and make decisions about which locks contend
or cooperate/merge). Since the introduction of lock_owner parameter
the usage of PID (for locks) was deprecated and is now unused. This
patch nukes the usage of PID in AFR
The usage of lk_owner has also ended up being a mess, because of the
differentiation required between ->lk() and ->inodelk(), (->lk() needs
to be identified by the process (roughly) and ->inodelk() needs to be
identified by the transaction) and also because of optimizations like
eager locking (locks are no more identified by the transaction as they
now get inherited by the next transaction).
The scheme (and technique) now is:
- All FOPs (the third phase of the transaction) happen with the lk_owner
which is set by the topmost layer (FUSE, NFS etc.)
- All entrylks are issued with lk_owner set to the frame->root address.
- Inodelks which will not be subject to eager locking are issued with
lk_owner set to frame->root.
- Inodelks which are subject to eager locking are issued with lk_owner
set to the address of fd_t (which are the only type of frames which
get subject to the eager locking optimization)
- At the start of the transaction, the transaction frame's lk_owner is
set to the either frame->root or fd_t (and never unmodified) depending
on the type of transaction.
- Just before the third phase (FOP phase) the set lk_owner is "saved"
away and overwritten by the lk_owner submitted by the top layer (FUSE
or NFS)
- Right after the third phase, the saved lk_owner is "restored" to resume
the transaction into the POST-OP and eventually UNLOCK using the same
lk_owner which was used during the LOCK phase.
Change-Id: I6ab8e4d6b65ae4185fa85ad3fded8e9188b2f929
BUG: 836033
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3620
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit e5b3e04de90e7443383f61c2be6ca7fc6e886d1d
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Sun Jun 24 16:17:21 2012 +0200
cluster/afr: add a new option to select read-subvol by index
read subvolume is a nice option to set prefred read child if you have a
replication over 2 datacenter. if you have 2 datacenter and have a
distributed replication where one set of servers are in datacenter one
and the other (the replicated) are in the other datacenter
read-subvolume it not very handy since it goes over name and the
subvolume name is different for each replication pair. i added a new
option called read-subvolume-index which take the number of the
subvolume to choose. 0 fo first , 1 for second and so on subvolume in
every replication. this option can now be used in the --xlator-option
mount option to choose the prefered read child for all replication at
once. For Example on all clients in datacenter one you can use
--xlator-option=volumename-replication-*.read-subvolume-index=0 to
prefer read from the servers in datacenter one. when you expand or
shrink the volume no changes are needed to the client config since the
wildcard will set this option automatic on reconfigure.
Change-Id: I3b47432f77037c380ff4a6296636c6f8fc953db9
BUG: 837420
Original-author: domwo <glusterfs@wollina.de>
Signed-off-by: domwo <glusterfs@wollina.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3615
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d2bc0242d040b0e57118e822541b89c3f2e4e938
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Sun Jun 24 15:52:43 2012 +0200
cluster/afr: fix for read-subvolume option does not work
changed order of prevered read child in afr_select_read_child_from_policy
when a read child is set over config option read-subvolume it shoudl be first to return
Change-Id: I1c5a8171379bb2bad76f6653e9d68a9349d55142
BUG: 833750
Original-author: domwo <glusterfs@wollina.de>
Signed-off-by: domwo <glusterfs@wollina.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3614
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 27970e486232155dcb586d0e22e63e348dfa88fc
Author: Niels de Vos <ndevos@redhat.com>
Date: Fri Jun 8 11:59:31 2012 +0200
Mark /var/lib/glusterd as owned by glusterfs, subdirs belong to -server
Change-Id: Ib1df8da7e8abdcd3edece45bd39fe238f28838f1
BUG: 829734
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.com/3539
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0e9bfd4df0fa66c0562e1cad688212efed4c1287
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 14:06:24 2012 +0200
xdr_vector_round_up: don't let vcount <= 0 cause invalid array reference
Change-Id: I6a69f20fddb7271fe47f80acb97d2198e9998ccc
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3605
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ab80b45f373d27e94b463e31858390fc0702b3b0
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 14:03:14 2012 +0200
get_mnt_opts: don't let empty option string cause (*mpt_optsp)[-1] reference
This looks like a "can't happen" case (depending on what add_option does),
so you may prefer to add an assertion instead.
Change-Id: Ibfdd34fca045e5213de836cca252bd96408b2136
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3604
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b92ccb89c5d6f8aa1e51b770c8f53e0cf6027b7d
Author: Venkatesh Somyajulu <vsomyaju@redhat.com>
Date: Thu Jun 21 18:31:23 2012 +0530
mgmt/glusterd: Added spaces in the logs
Change-Id: Ic44e339219a845946e18c8c926fe993e09f86624
BUG: 820555
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.com/3609
Reviewed-by: Kaushal M <kaushal@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 951b342db6ecbbc85c8c8cae1195ac6d6e70ae0e
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 13:45:46 2012 +0200
valid_ipv4_address: don't access addr[-1] for 0-length input string
valid_ipv6_address: Likewise.
Change-Id: I6225873a5e323f81de5f25335aceeee571629e28
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3602
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b4f5d827819487c61f3a12127f8efc2771812ae7
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 13:34:11 2012 +0200
libgf_client_chdir: don't access path[-1] upon chdir("")
Admittedly, this code may not be reachable via
glusterfs_chdir, assuming libgf_client_path_lookup
with such a loc.path would fail.
Change-Id: I0b72ade0918da30d49bff756dcf04d1512d0177f
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3601
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 482bea7c46691867d03ae44d254d4b7537f8691e
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 13:29:38 2012 +0200
libgf_count_path_components: don't access pathdup[-1] for empty input
Change-Id: I432f8c8fac907f625d79b2c5bb626a1f7013a73e
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3600
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d61738bd46570a115476d8235607456fcd6f756a
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 13:17:49 2012 +0200
libgf_init_vmpentry: assert strlen(vmp) > 0 to guard against using vmp[-1]
Change-Id: I091e6066fd470e9e0b67a00464b5713b86d3783c
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3599
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 22e1708ca9571deac47ccf1dad635f04cf7f4589
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 11:58:07 2012 +0200
libgf_rrindex: don't return &str[-1] for an empty string input
libgf_trim_to_prev_dir: handle empty path (i.e., don't access path[-1])
libgf_alloc_fd_ctx: assert that vpath is not empty
Change-Id: I8f9d233680f78107187132889916cdcf4262af72
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3598
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8c07a4e27f9c6e76df526da828f9b12dd52e7f54
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 11:37:44 2012 +0200
pidinfo: don't let a corrupt /proc/PID/status cause buf[-1] access
Change-Id: I5d10eb92af753513eb5e5e3d7d2ad3ace57917d7
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3597
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0157e7ff78b7dacfd326f27a4f6b103e86db99fc
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 10:07:12 2012 +0200
geo-rep: handle input without trailing newline; don't reference buf[-1]
Do not truncate final byte of a line that does not end in a newline.
Do not clobber stack (resbuf[-1]) for input that starts with a NUL byte.
Likewise in glusterd_urltransform.
Change-Id: Ifdcad02d908c8dcbc1a0eee78d318dd4e7860322
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3595
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ab3b1ecba3c287bb3bc6f0787a7849a4b74eba42
Author: Jim Meyering <meyering@redhat.com>
Date: Wed Jun 20 10:00:02 2012 +0200
xlators/nfs: don't test/set dirpath[-1] for a zero-length name
Change-Id: Ic6ccfc964c9739f067ccf14a95fd0e09baf0dd51
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3593
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 847a8e7d6a3ac91e0caa022176ed67eb4c72f8d8
Author: Jim Meyering <meyering@redhat.com>
Date: Tue Jun 19 12:30:21 2012 +0200
glusterd-rpc-ops: avoid buffer overrun for over-long key
strncpy explicitly does not NUL-terminate when source string
has length >= the length specified via strncpy's 3rd argument.
Assuming strncpy is justified (i.e., that it may truncate),
be sure to NUL-terminate its destination buffer.
Change-Id: Ia67bf136cdfae6d9850f673923c01baa3cdef9d8
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3592
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fb50ea91076154cf5b3503e901a1d6a0c8aa1a82
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Jun 11 16:21:04 2012 +0530
features/worm: Allow worm option to be set throught volume set
'volume set <volname> worm on' adds the worm xlator on the bricks.
Read-only and worm cannot exist together, and a check is added.
Regular volumes can still be mounted with worm mount option.
If a volume is started before conversion to worm, the bricks need
to be restarted for the option to take force.
Updated feature.read-only option to features.read-only to keep it
consistent with other features based options.
Change-Id: I1a8fab363aaf66e6da615dcffa328332ae39fa04
BUG: 811612
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3545
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6299798a0eaf3a33121f77414bb81e78bda75b7a
Author: Jim Meyering <meyering@redhat.com>
Date: Thu May 31 11:29:29 2012 +0200
glusterd: avoid buffer overrun due to lack of NUL terminator
Assume that this use of strncpy is not spurious (i.e., that it does
sometimes truncate), and ensure that the result is NUL-terminated.
Otherwise, callers that treat ->filepath as a NUL-terminated
string could operate on a bogus file name and/or segfault.
Change-Id: I276bf8a4da330284cc0300e8da7113a48b9b9b37
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3590
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5ca3c9b67e1425f530be3433782d13fbb325bf7c
Author: Jim Meyering <meyering@redhat.com>
Date: Mon Jun 4 16:41:17 2012 +0200
bdb: fix erroneous strncpy in file name construction
Using strncpy like that fails to copy the trailing NUL byte of
dirent->d_name, which is required, since the result buffer,
entry_path is stat'ed in the code just below. Besides, there is
no need for strncpy, since we know the source buffer will fit
in the possibly-just-realloc'd destination buffer: use memcpy
and +1 to include the trailing NUL.
Change-Id: I4d4cfb5b7df3c018516919f2d67c21c07de126cb
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3588
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8ca782e60346a67f860134d8338d496de6ff9278
Author: Jim Meyering <meyering@redhat.com>
Date: Mon Jun 4 15:04:01 2012 +0200
posix: avoid unnecessary strncpy
When strlen(SRC) < LEN, using strncpy is misleading.
Use strcpy instead.
Change-Id: I76832353dc415de99f0583d085d5c2444d5fe8b0
BUG: 789278
Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-on: http://review.gluster.com/3587
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fac4b681ce09f384cb7215da21ffaa8cf5f673d0
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jun 27 11:04:48 2012 +0530
glusterd: Fix peer probe when username/password is missing
Prevent failure of building volumes dictionary during peer probe, when
username/password for a volume is missing. This situation can be caused by
migration of gluster from pre-3.3 to 3.3 and above.
Change-Id: Ib924ecd3d941ddaa5c7773e4d45b076c488b6421
BUG: 834229
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3619
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5270b8906caf25deda25472dccc06889c5b29369
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Sat Jun 23 10:28:54 2012 +0530
glusterd, cli: handle uuid conflicts in probe gracefully
A commonly faced problem among glusterfs users is: after a fresh
installation of glusterfs in a virtual machine, the VM image is
cloned to make multiple instances of the server. This breaks
glusterd because right after glusterfs installation on the first
boot glusterd would have created the node UUID and this gets
inherited into the clone. The result is wierd behavior at the time
of peer probe where glusterd does not (yet) deal with UUID
collisions in a user friendly way.
With this patch the peer which got the probe request will compare
the uuid of the machine which send the probe request with its own
uuid and send the proper error to cli if the uuids are same.
Change-Id: I091741ec863431fb6480a09a3f4c68a0906a3339
BUG: 811493
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3612
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1f94aa50634594f21662ff1b28277baf5658b6d2
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Sat Jun 30 17:04:26 2012 +0530
rpc: Fixed ping timer algo.
The purpose of the ping timer is to assert the absence of any evidence
the server is possibly alive.
The current implementation updates the 'last_sent' timer in the following
points in time,
- rpc_clnt_submit: when rpc messages are being queued at the transport
layer. (wrong!, since we have no way to determine if server actually
received the message)
- rpc_clnt_notify: when client receives pollout event on sending a message
on the 'wire'. (correct, since it indicates ACK from server)
The fix removes the 'incorrect' update of 'last_sent'.
Change-Id: I56af7b15c3672673696977a7c50ee66eafa4ec55
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3625
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 260806e340d55ec29d706d0c49b271407416cacd
Author: shishir gowda <sgowda@redhat.com>
Date: Fri Jun 22 13:28:31 2012 +0530
cluster/dht: Remove dht dependency on glusterfsd-mgmt
glusterfs_ctx->notify can be used by any xlator to talk to
glusterfsd-mgmt.
Note- This is for any rpc communication initiated by the xlator,
and not from glusterd.
Change-Id: Ic0e4af106fe1e98d797ca621facda8839b87598a
BUG: 835757
Signed-off-by: shishir gowda <sgowda@redhat.com>
Reviewed-on: http://review.gluster.com/3618
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 66b1c9c5277dcdd7f7b48fa0ec9b943bd7955e42
Author: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Date: Wed Jun 13 09:13:04 2012 -0400
localtime and ctime are not MT-SAFE
There are a number of nit-level issues throughout the source with
the use of localtime and ctime. While they apparently aren't causing
too many problems, apart from the one in bz 828058, they ought to be
fixed. Among the "real" problems that are fixed in this patch:
1) general localtime and ctime not MT-SAFE. There's a non-zero chance
that another thread calling localtime (or ctime) will over-write
the static data about to be used in another thread
2) localtime(& <64-bit-type>) or ctime(& <64-bit-type>) generally
not a problem on 64-bit or little-endian 32-bit. But even though
we probably have zero users on big-ending 32-bit platforms, it's
still incorrect.
3) multiple nested calls passed as params. Last one wins, i.e. over-
writes result of prior calls.
4) Inconsistent error handling. Most of these calls are for logging,
tracing, or dumping. I submit that if an error somehow occurs in
the call to localtime or ctime, the log/trace/dump still should
still occur.
5) Appliances should all have their clocks set to UTC, and all log
entries, traces, and dumps should use GMT.
6) fix strtok(), change to strtok_r()
Other things this patch fixes/changes (that aren't bugs per se):
1) Change "%Y-%m-%d %H:%M:%S" and similar to their equivalent shorthand,
e.g. "%F %T"
2) change sizeof(timestr) to sizeof timestr. sizeof is an operator,
not a function. You don't use i +(32), why use sizeof(<var>).
(And yes, you do use parens with sizeof(<type>).)
3) change 'char timestr[256]' to 'char timestr[32]' where appropriate.
Per-thread stack is limited. Time strings are never longer than ~20
characters, so why waste 220+ bytes on the stack?
Things this patch doesn't fix:
1) hodgepodge of %Y-%m-%d %H:%M:%S versus %Y/%m/%d-%H%M%S and other
variations. It's not clear to me whether this ever matters, not to
mention 3rd party log filtering tools may already rely on a
particular format. Still it would be nice to have a single manifest
constant and have every call to localtime/strftime consistently use
the same format.
Change-Id: I827cad7bf53e57b69c0173f67abe72884249c1a9
BUG: 832173
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.com/3568
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3c2279c6335fdd52b4d679f278d9a5b7d2fc61f0
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jun 21 04:58:04 2012 +0530
cli: improvements in the output of rebalance status
Change-Id: I14149dc0eef9236fb089cc1404166efee46ddd1b
BUG: 834263
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3608
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 00ebc328b0864a9f2048ee101f5d48d021181670
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Jun 14 11:53:48 2012 +0530
libglusterfs: Fix sizet validation for cache-size
Validation of 'cache-size' option will not fail when given value is greater than
max. Values lesser than min will cause validation to fail.
Change-Id: I9c744b5ace10604d5a814e6218ca0d83c796db80
BUG: 831568
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3570
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4bbbcbad0ab0872e8e881c7a399cad0efe647454
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Jun 15 15:13:31 2012 +0530
protocol/client: Re-open should not have O_CREAT|O_TRUNC|O_EXCL
RCA
The bug is observed in 3.2.x because posix xlator changes
the uid/gid of file as per frame->root-uid/gid if O_CREAT flag
is set in open fop. Posix does not do this in 3.3.x so that
bug does not appear anymore but this issue exposed the actual
bug in client xlator re-open. Re-open of a file on re-connection
should not perform re-open with the same flags at the time of
open/create/opendir. Imagine a case where a file is opened with
O_TRUNC|O_RDWR and some data is written to it, now if the brick
goes down and comes back the file will be truncated.
When I tested this case, the file is not truncated because locks
xlator resets O_TRUNC unconditionally.
Client xlator re-open bug and locks xlator bug cancel each other.
Fix
Reset O_CREAT|O_TRUNC|O_EXCL flags in re-open.
Locks xlator should not reset O_TRUNC.
Additional changes
Removed wbflags as it is not assigned at all.
Testcases
Automated go program is at:
://bugzilla.redhat.com/show_bug.cgi?id=807976#c2
Change-Id: I0080344fdda2e62e7c976c35a5bf5f1fa8838891
BUG: 807976
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3582
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit be95a7430e8914da585b8d4955dc65135d6aa68d
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Tue Jun 12 23:58:14 2012 +0530
features/marker: use buf->ia_gfid in all the lookup callbacks
* In general use buf->ia_gfid for gfid instead of inode's gfid
in the callbacks of the fops where new inode is created (such
as create, mkdir, mknod, symlink). In the callback path inode
would not be having the gfid within it, if it is not yet linked
to the inode table which happens in protocol/server.
Change-Id: I75b348ad152a1bcd634a4c2db34aca97956ccb21
BUG: 822067
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3567
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit afb867e1daa001513f7295b942cd49946531bdf8
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri May 25 09:49:58 2012 +0530
cluster/afr: Don't reset split-brain when data-self-heal is off
BUG: 804606
Change-Id: I8cefcb6efa687fac4ad412403c085b3767218f72
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3586
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 244e23fd02e73ecfd2be557c4cc67c689268e0ab
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Thu Jun 14 11:55:45 2012 +0530
debug/io-stats: if some dict operation fails then goto out instead of proceeding
Change-Id: I9c6d9b48c6162f6be2b405bacfc97605909c4e5e
BUG: 769826
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3569
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 037e1489158eefcaa3445d511a96511fbe54b70c
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Jun 12 19:39:49 2012 +0530
cluster/afr: Treat EEXIST as success in hardlink
BUG: 831151
Change-Id: I6ecc099cf5f3ae58b19dfb00ed0b3f9959e711e5
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3571
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit fc686505ead4ca7932f14fbfc36ea8809807c9de
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Jun 11 11:38:14 2012 +0530
cli: Change cli output for heal commands
Change-Id: I05011ba7c1fe79867e151672622e9d8669884dd2
BUG: 826406
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3544
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7448ed817f6a3dae206e5882775bc141f9adf3b2
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue May 29 10:02:52 2012 +0530
rpc-transport/rdma: decode and handle RDMA_ERROR msgs.
RDMA_ERROR msgs are resulted as part of failure to decode requests
or failure to send reply (for eg., reply being bigger than a msg
that can be sent inline, but client has not provided any write-chunks
to rdma-write into).
Change-Id: I0184cfb5ff8f49ed892767345e32e6c7b01c49e7
BUG: 822337
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3474
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 17d90ded004a509a51963804a4d1a69c2fcc977f
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Jun 13 12:12:18 2012 +0530
debug/io-stats: do not store the string allocated from stack into dict
* Unlock if some error happens after the lock is held
* White space cleanup
Change-Id: If90d9a9ae91c485bb21b1ad222af445981edb77b
BUG: 769826
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3565
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 54a63eb483948c2eecd4d3ac9c4fc60d39a76ef3
Author: Csaba Henk <csaba@redhat.com>
Date: Tue May 22 16:08:48 2012 +0530
gsyncd / geo-rep : failover/failback
This commit is based on Venky Shankar <vshankar@>'s
original implementation. Let us first quote Venky's
description, then we summarize changes to his work.
------
First version of failover/failback.
Failback mechanism uses two exclusive modes:
* blind-sync
This mode works with xtime pairs (both master and slave) to
identify candidated to sync the original master from the slave
* wrapup-sync
This mode is similar to the normal working of gsyncd except
that orphaned entities in the gluster volume are not assigned
xtimes. This prevents un-necessary transfer of data for such
entities.
Modes can be enabled via:
gluster volume geo-replication M S config special_sync_mode blind
gluster volume geo-replication M S config special_sync_mode wrapup
To turn off the special modes (i.e. to revert to normal gsyncd behaviour) use:
gluster volume geo-replication colon-d0 192.168.1.2::colon-d config \!special_sync_mode
------
Code has been refactored to meet following goals:
- make checkpointing work with special sync modes
- move out sync mode related conditionals from the crawl
loop and make all decisions to be made at startup
time
- be intrusive to the crawl loop to smallest possible degree
(we will have to change/revisit it for other reasons,
and the complexity of that should not increase)
So, xtime parsing/updating/evaluation that's specific to
the certain special modes are represented as mixin classes;
basic operation logic is in an abstract base class.
On startup, special-sync-mode tunable is dynamically dispatched
to the corresponding mixin and the actual master class is
derived from the chosen mixin and the ABS.
Change-Id: Ic9b8448f31ad4239a8200dc689f7d713662a67de
BUG: 830497
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3541
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit c03be14a4247fbb4395403b01a07decde0ddffe0
Author: Csaba Henk <csaba@redhat.com>
Date: Sun May 27 03:56:24 2012 +0530
geo-rep: checkpointing
- gluster vol geo-rep M S conf checkpoint <LABEL|now>
sets a checkpoint with LABEL (the keyword "now" is special,
it's rendered to the label "as of <timestamp of current time>")
that's used to refer to the checkpoint in the sequel.
(Technically, gsyncd makes a note of the xtime of master's root
as of setting the checkpoint, called the "checkpoint target".)
- gluster vol geo-rep M S conf \!checkpoint
deletes the checkpoint.
- gluster vol geo-rep M S stat
if status is OK, and there is a checkpoint configured, the checkpoint
info is appended to status (either "not yet reached", or
"completed at <timestamp of completion>").
(Technically, the worker runs a thread that monitors / serializes /
verifies checkpoint status, and answers checkpoint status requests
through a UNIX socket; monitoring boils down to querying the xtime
of slave's root and comparing with the target.)
- gluster vol geo-rep M S conf log-file | xargs grep checkpoint
displays the checkpoint history. Set, delete and completion events
are logged properly.
Change-Id: I4398e0819f1504e6e496b4209e91a0e156e1a0f8
BUG: 826512
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3491
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit c668bc2704f31190ca8c8aaaf73e6c3315f1043c
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed Jun 13 14:24:52 2012 +0530
mgmt/glusterd: fix the infinite loop in lazy uuid generation
* This is how the lazy uuid generation leads to infinite loop of function calls.
MY_UUID -> glusterd_uuid_init -> glusterd_retrieve_uuid -> MY_UUID
* Also while starting glusterd if valgrind option is not given in the volfile,
then reset the ret variable to 0.
Change-Id: Ief719f436d8a264a591ee6aefc6da3c0f6c75e8f
BUG: 811493
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3564
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6a56144eee57c0ef3019d6d2749702fdc31c94a8
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Jun 7 14:01:46 2012 +0530
cli: Fix time_t conversions
BUG: 828058
Change-Id: I2511a0473d9310d3a51d0994f415a5d319bfc98b
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3550
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1d7198aa0444dcf3338461e99a9e264e97c92d0c
Author: Mohammed Junaid <junaid@redhat.com>
Date: Mon Jun 11 16:39:17 2012 +0530
swift: Donot display async_pending container.
async_pending container is for internal, should not be exposed to the users on a
GET.
Change-Id: I460242667ae0cb5e96d4c63296f0bae4bb83b28e
BUG: 829137
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/3547
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a89839a56b21c60956f699a87604e6427d197494
Author: Brian Foster <bfoster@redhat.com>
Date: Mon May 7 13:53:31 2012 -0400
cluster/stripe: implement the coalesce stripe file format
The coalesce file format for cluster/stripe condenses the striped
files to a contiguous layout. The elimination of holes in striped
files eliminates space wasted via local filesystem preallocation
heuristics and significantly improves read performance.
Coalesce mode is implemented with a new 'coalesce' xlator option,
which is user-configurable and disabled by default. The format of
newly created files is marked with a new 'stripe-coalesce' xattr.
Cluster/stripe handles/preserves the format of files regardless
of the current mode of operation (i.e., a volume can
simultaneously consist of coalesced and non-coalesced files).
Files without the stripe-coalesce attribute are assumed to have
the traditional format to provide backward compatibility.
extras/stripe-merge: support traditional and coalesce stripe formats
Update the stripe-merge recovery tool to handle the traditional
and coalesced file formats. The format of the file is detected
automatically (and verified) via the stripe-coalesce attributes.
BUG: 801887
Change-Id: I682f0b4e819f496ddb68c9a01c4de4688280fdf8
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3282
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0630338ade9304a8b677a2f8652308de00a5bd27
Author: Anand Avati <avati@redhat.com>
Date: Thu Jun 7 00:45:48 2012 -0700
glusterd: generate node UUID lazily
A commonly faced problem among glusterfs users is: after a fresh
installation of glusterfs in a virtual machine, the VM image is
cloned to make multiple instances of the server. This breaks
glusterd because right after glusterfs installation on the first
boot glusterd would have created the node UUID and this gets
inherited into the clone. The result is wierd behavior at the time
of peer probe where glusterd does not (yet) deal with UUID
collisions in a user friendly way.
This patch is for the 'prevention' of the issue. The approach here
is to avoid generating a UUID on the first start of glusterd, but
instead generate a node UUID only when a node UUID is found to be
necessary. This naturally avoids the creation of node UUID on first
boot and prevents the issue to a large extent.
This issue also needs a 'cure' patch, which gives more meaningful
error messages to the user and provides CLI to recover from the
situations (gluster peer reset?)
Change-Id: Ieaaeeaf76ed35385844e98a8e23fc3dd8df5a208
BUG: 811493
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3533
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 74c5fe0a33b07dc76bd7f0519074fdcc90745c9f
Author: Anand Avati <avati@redhat.com>
Date: Thu Jun 7 17:09:45 2012 -0700
io-cache,quick-read: bring down log level
log messages were unnecessarily in INFO level. The two functions
with the same name were non-static and actually the quick-read's
call landed in the io-cache's version:
2012-06-07 17:02:29.848667] I [io-cache.c:1549:check_cache_size_ok] 0-single-master-io-cache: Max cache size is 33791991808
[2012-06-07 17:02:29.848751] I [io-cache.c:1549:check_cache_size_ok] 0-single-master-quick-read: Max cache size is 33791991808
Changed them to static declaration.
Change-Id: Id9daf9593b2832e4c261f95eac6181efea8899a5
BUG: 765227
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3536
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit b4aa48d5b1f18ab268d22ad87f2167889ed827e8
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Apr 4 12:00:30 2012 +0530
libglusterfs : Fix validation for integer volume options.
Integer volume options which specified only the min value as 0, would not be
validated during "volume set".
The range check for an option happened only if both min and max were not 0. In
the above case, even though a minium was specified, the range check did not
happen as both min and max were 0.
To allow forced validation in such cases, a new member, "validate", has been
added to volume_options_t. This member takes the values GF_OPT_VALIDATE_BOTH,
GF_OPT_VALIDATE_MIN and GF_OPT_VALIDATE_MAX (GF_OPT_VALIDATE_BOTH is the
default).
Change-Id: I351de0eedb6028120e5c0b073ee5d9c141dee717
BUG: 809847
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3084
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6331cdd224c97419e463ee6137615097cdeae4f2
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Jun 6 17:28:40 2012 +0530
mount.glusterfs: Add support for {attribute,entry}-timeout options
Change-Id: Ib41a2537ac86513a008029fca818951706a144f7
BUG: 829279
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3530
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b39799c65e0540c12f63e538be6ccc96232815ae
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Jun 6 13:46:50 2012 +0530
cluster/afr: Check for null gfid_req
gfid_req is set only by the fuse xlator. Fresh lookups
performed by self-heal-daemon, rebalance will not have
gfid at all.
Change-Id: I6712e3063067ecc5f19956e75d28c86bfc19fc65
BUG: 829203
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3529
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c5606f1d5c9c2f0cf0256577e3206576e05bb692
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Jun 4 19:13:49 2012 +0530
protocol/client: Remember the gfid of opened fd
This is needed when the fresh lookup triggers self-heal, gfid
won't be present in inode yet. Similar situation happens with
Rebalance as it does not perform inode_link.
Added similar fix for re-opendir.
Removed inode from fdctx and removed some duplication of code.
Change-Id: Ic94e5738c8585ed86801d2eed9ddab1015246710
BUG: 826080
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3517
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3d8f4d56c40910a5546abc89e7520e2cdbcf26bf
Author: Anand Avati <avati@redhat.com>
Date: Tue Jun 5 13:45:39 2012 -0700
rpc-transport/socket: fix the state machine for XDATA reading
The socket state machine was broken for reading XDATA on the server.
This code was structured such that when there was a partial read in
a particular state, some variables would remain uninitialized in the
next 'run' of the state machine. Also did some re-org of the state
machine with two more states to make the code more readable and similar
in state-breakup pattern to the other states.
Change-Id: Ia32c78d4b9567bb08c6df8dc9fd6f05749d312a4
BUG: 829062
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3524
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 1521ba53338367fc8e93f4e16e22449c9bef3d50
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Jun 6 18:06:09 2012 +0530
mount/fuse: use correct fdctx to inherit direct-io-values from.
Change-Id: Ifea178f4dbe57720c16dc3851b262952f3d81159
BUG: 762533
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3531
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 273ce17c499e46d910e727d6d61bf91c0354b99e
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jun 4 10:13:19 2012 +0530
glusterd: nfs.disable fix for "volume set help"
Fixes volgen to include "nfs.disable" in output of "volume set help".
Also fixes some incorrect entries in glusterd_volopt_map.
Change-Id: Ica5edf1ece31f9daa040fcdf559c1643ecdfd568
BUG: 828027
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3509
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3c7785dee0912b42e779b2889a3db991c8c5c954
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jun 5 21:59:47 2012 -0400
rpc: avoid an invalid free of item on a list
If we actually "consumed" vol_opt by putting it on THIS->volume_options,
it's still in use and we shouldn't free it before returning.
Change-Id: I8ef3e4ce8a8b9f2552faa3345f1686e173d1aa10
BUG: 829104
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3528
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4d83a67a8c24daf3ba82d1fdb4d137d9e72646c2
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Jun 1 00:52:43 2012 +0530
glusterfsd: further fd leak fixes for graph change
Change-Id: I8e23d6bb95cddbb3862c524d79d1a956956b7a51
BUG: 789278
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3527
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 39d0a92f6d84041d2726ccf38fc56c0d07563a6d
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jun 5 15:07:23 2012 +0530
cli: Fix error output for peer probe on address validation failure
Displays an error message and sets proper return value on failure of address
validation in peer probe.
Change-Id: I5ced5524040e19a95dc832b6f676874983d0f2a7
BUG: 817648
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3520
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2ad138290c5f95c7b735e1e2ea4c4dd9bcc13e6b
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat Jun 2 18:36:43 2012 +0200
Use linkat(2) when linking on symlink
link(2) behavior is not standardized when it comes to symlink. BSD
links to the symlink target (and fails if it does not exist),
Linux links to the symlink itself. Use linkat(2) instead of link(2)
in order to get a portable behavior.
BUG: 764655
Change-Id: If7f6f17b48a4ccf8827c3795ec147306df6b5542
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3507
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 84775d498bad1a010170fcdc13d7fe4cf57f23de
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Jun 5 14:15:54 2012 +0530
core: coverity fixes (mostly resource leak fixes)
currently working on obvious resource leak reports in coverity
Change-Id: I261f4c578987b16da399ab5a504ad0fda0b176b1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 789278
Reviewed-on: http://review.gluster.com/3265
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2f20f1a4d98cf04e8f5fbd08f9187b19101421f1
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Jun 5 15:02:49 2012 +0530
glusterd: Set errstr for duplicate add-brick
Sets op_errstr when add-brick is given a duplicate brick.
Change-Id: I7b8f8139f9f09834a71a5abc725692b145896830
BUG: 803336
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3519
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2ee3762c42cac79ffa34cf09e80cafc0bbc6bca9
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Mar 23 16:44:38 2012 -0400
replicate: default read_child to a local brick if there is one.
Controlled by the "choose-local" option (on by default).
Change-Id: I560f27c81703f2c9c62fdb51532c8eb763826df7
BUG: 806462
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3005
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 79570666c38e4f819474995d42995e16cf0a7590
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Jun 5 17:52:03 2012 +0530
fuse: be good at suicide
We get hung on the exit path if we kill only
the current thread on AUTH_FAILED. Kill indeed
the current process.
Change-Id: I36042f245a22bd2a284df37fd6d3a3e0b76f81e9
BUG: 826975
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3523
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c923069db5d7383fecc858c5817e659ff395b4f9
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Jun 4 23:23:45 2012 +0530
Self-heald: inode_link files while crawling
Change-Id: I559a3ff507b9487b1dfca7871c188a05d89ea6d6
BUG: 826580
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3515
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 50023b0fbfc47a21f57d83f1f7146b078738b401
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jun 4 10:41:50 2012 +0530
posix: fix the 'ENOENT' logs for setxattr()
from marker, setxattr() is attempted on the path even after the
unlink() happens if the fd is still active. In such cases, we should
not be logging the failures.
Change-Id: Icdd9c951f0d331cdda0bec42ae343302b2dbafde
BUG: 766611
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/3514
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4785e14ab2c7dd80d8d857cc9a45c644dacbc85a
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Jun 4 16:05:49 2012 +0530
mount.glusterfs: update the glusterd WORKDIR
Change-Id: I70d091611d314598412b5315adcbe1b5147a8773
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 824231
Reviewed-on: http://review.gluster.com/3513
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 49e20c853b7bd6f8cffcb522d621b5a12690e764
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Jun 4 09:56:33 2012 +0530
libglusterfs: valid_host_name() fix
Fix valid_host_name() to allow single character hostnames.
Change-Id: I72527ecedec52fa47336d95b0586eb18dac6273d
BUG: 827403
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3508
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8d072df3e95ed5d18cabb49c6248e625bfea7a5a
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Jun 1 11:09:07 2012 +0530
protocol/client: do not ignore the xdata received for some fops
opendir, fsetattr, fsync, lk were sending NULL xdata to the server
even though it (xdata) had values within it.
Change-Id: Ic274ab903c5c1e443409dd250ede80cd85d10b36
BUG: 826923
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3502
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0ed4911f3136827e14b275cf0feee605bcf52363
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun May 13 07:43:32 2012 +0200
Use inet as default listener
This patch was proposed by Anand Babu Periasamy on gluster-devel@
It fixes the inet/inet6 mismatch between client/glusterfsd/glusterd at mine
BUG: 764655
Change-Id: I172570aa58ea08c4c74cfd28f121d3d4e02a55e0
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3319
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Anand Babu Periasamy <abperiasamy@gmail.com>
Reviewed-by: Anand Babu Periasamy <abperiasamy@gmail.com>
commit 260974f0e794dce31da01e41d3861b958b575952
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Apr 23 16:44:25 2012 +0530
glusterd-volgen: by default include 'cluster/distribute' in volfile
include 'cluster/distribute' even if there is just one brick in the
volume, that way, the directories would have some of the required
extended attributes on it before a 'add-brick'.
this fixes the issues of applications getting errored out when a
'add-brick' is done when a volume had only one brick before.
Change-Id: Ie9d559e6b26aafd3d67908ab20a006e4e5e70d73
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 815227
Reviewed-on: http://review.gluster.com/3213
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f332d52b069e3eec200e30d3628b4c9368a6a590
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Apr 24 11:53:56 2012 +0200
cli: let commands specify the exit value in batch mode
Old behavior: when cli is ran in batch mode (sequence of commands are
fed to it in stdin), if a command returns an error (ie. -1), the cli
exits upon it with 255 (-1 on 8 bit).
New behavior: consider any non-zero return from cli commands as error
and use the negative of that return value as exit value, thus giving
control to cli commands over the exit value, while (as of the existing
command set) adhering to the convention of exiting with 1 on error.
Spotted upon stumbling upon mount/umount commands which did want
to exit with 1 on error but that was not possible as of old behavior.
Change-Id: I6f41191cdc718c3e676cfae1e404152f4cb715c5
BUG: 765214
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3218
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0f2b044e8d35d1ccac78dc832f3ac0d299c43c5c
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed May 9 16:52:53 2012 +0530
mount.glusterfs: enhance option 'transport=' for 'rdma'
Change-Id: I9e05cc8f4b73c6a83a4be956423f4e209237c215
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 798163
Reviewed-on: http://review.gluster.com/2855
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 11a3f77a7aaeb4c9ac1fc17d1aaedbdfed9291a5
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Jan 6 15:07:48 2012 +0530
features/locks: update user_flock structure before inserting
Change-Id: Idfa00e4f3263d50b327f5a2c6f13ec68ffc8fbee
BUG: 805994
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3048
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bdeac8d298765ef193f1d3d4d5bf1a14a696aa54
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon May 28 16:55:52 2012 +0530
protocol/client: provide a buffer for storing reply of readlink.
since a readlink response can be bigger than size of rdma-msges
that can be inlined, we need to provide a buffer where server
can do an rdma-write of response.
Change-Id: I6ab06c3a94702f810ab0c57b409aaaf35cc93057
BUG: 822337
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3464
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ffc9aefe4061ebf8e9e42696e5c1715cb7d93b08
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Jun 1 00:57:40 2012 +0530
glusterd: fix issues with volume reset handling
- properly resolve shortened key names
- make sure user gets decent feedback
Change-Id: I94b75f34b29cb71fb1a2edf17c3f1bf841bb552a
Signed-off-by: Csaba Henk <csaba@redhat.com>
BUG: 826958
Reviewed-on: http://review.gluster.com/3500
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ef388e6634ef03a21056a2e9e418ee9d58bfe50a
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon May 28 15:31:36 2012 +0530
glusterd: regenerate brick vol-files on upgrade
If upgrade/downgrade option is set in glusterd it terminates
after the volfiles are regenerated. No need for 'sleep 10'
hack anymore.
BUG: 825872
Change-Id: I12e666eb871aad7e7efa954b9307993952745d92
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3482
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b23b2cfe94b790f4389b5faa9ee4f62c08690c49
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Jun 1 15:39:18 2012 +0530
glusterd: makefile typo fix.
instead of /var/lib/glusterd, symlink was pointing to /var/log/glusterd
Change-Id: I485ad8d6cc8535378179621dea7539328d22454c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 824231
Reviewed-on: http://review.gluster.com/3503
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a733ee3d14777a4d7f56870b8498cb2d9589c5ae
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Jun 1 15:00:16 2012 +0530
core: xlator option framework cleanups
- Upon init/reconf, if an option is not in the opt dict,
and a default value is neither specified, null it out.
With this, the xlator config data that comes
out of init/reconf becomes deterministic in terms
of the xlator option declarations and the incoming
option value dictionary. (Needed for correct operation
of volume reset.)
- We can rely bravely on the guarantee given by init/reconf
as of which no NULL value is passed to the converter
functions. Drop the spurious null check of not_null(),
and rebaptize it to pass().
Change-Id: Ifa068bcc0275456c01ed00a3a315a985eb262e49
BUG: 765147
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3505
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 40e6530f91795904216aceb88759e4d5a8b693c9
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Wed May 23 03:37:16 2012 +0530
nfs/nlm: when setting nlmclnt->rpc_clnt, do not overwrite old rpc_clnt
Change-Id: I01a1c0c0c8d3402b8fe061258001eea2c0029e83
BUG: 819518
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/3419
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6c0f3f889eec38d334af5be83074882ba3a5adae
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Apr 27 11:36:57 2012 -0400
Add server-side aux-GID resolution.
Change-Id: I09bcbfa41c7c31894ae35f24086bef2d90035ccc
BUG: 827457
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3241
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3f224e2c689d048aa630c95922d7dadb2d82b93d
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Fri Jun 1 16:20:19 2012 +0530
protocol/server: do not wind opendir call if fd creation fails
If resolve fails in some fd based operation, then do not use fd to get
gfid (fd might be NULL). Use the gfid present in resolve structure.
Change-Id: I1058274a2f9b4e58a76e4e6019e7c5ce1906d365
BUG: 827376
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3504
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0e0b042cab42e971e16f0cde1ed861a39a631eaa
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Mar 29 12:47:49 2012 -0400
Optimize for small dicts, and avoid an overrun.
As dicts get used more and more in the I/O path (especially for xattrs and
the new xdata feature), removing some of their inherent inefficiency
becomes more important. This patch addresses some of the issues around
allocating data_pair_t structures separately. Along the way, I found that
the way we're allocating the "members" hash table was subtly wrong, and
could lead to a memory overrun. This is a latent bug because nobody uses
dict_get_new_full that way, but I added an assert to guard against that
possibility. One beneficial side effect is that we now save four pointers'
worth of space per dict, offsetting the extra space used for the new
members.
Change-Id: Ie8c3e49f1e584daec4b0d2d8ce9dafbc76fb57b2
BUG: 827448
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3040
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 547bb2c923d0a422930818e0b678293d40697244
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed May 30 19:02:29 2012 +0530
protocol/client: do not access the local object after being freed
Change-Id: I2d3aeb084168b9ed68a670b91e09126917f82968
BUG: 826588
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3494
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 818b743e5bb97ddc5d5863ba215d3ba75d60b633
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu May 24 20:45:56 2012 +0530
mgmt/glusterd: self-heals should be on in glustershd
BUG: 825740
Change-Id: I44829fb985f9c394b1e240e8ee7f8d026593add9
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3481
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fa82b9f6cd51e323af1c2e93a5c0723e586d46fa
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Wed May 30 22:34:25 2012 +0530
cluster/dht: set conf->defrag to NULL after freeing the defrag structure
Also no need to free the xlator object after rebalance is over, as the process
is about to be killed.
Change-Id: I6973e43c0353b5de61c0b39e52a22c618be361f4
BUG: 826584
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3495
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a0157954a99d463c32b1ae33d086ba4727393cf2
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 3 16:03:16 2012 +0530
cluster/distribute: set the inode layout in readdirp_cbk() for files
with this, inode-linking it in readdirp_cbk will be neater.
Change-Id: Ie2cd646438f851e1755e9b6a3fc9898059bee359
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 816140
Reviewed-on: http://review.gluster.com/2717
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cb68c45b72f30267cededdf0a9d6d911e19c3725
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Mar 12 09:32:40 2012 -0400
replicate: add hashed read-child method.
Both the first-to-respond method and the round-robin method are susceptible
to clients repeatedly choosing the same servers across a series of opens,
creating hot spots. Also, the code to handle a replica being down will
ignore both methods and just choose the first remaining (which is not an
issue for two-way but can be otherwise). The hashed method more reliably
avoids such hot spots. There are three values/modes.
0: use the old (broken) methods.
1: select a read-child based on a hash of the file's GFID, so all clients
will choose the same subvolume for a file (ensuring maximum consistency)
but will distribute load for a set of files.
2: select a read-child based on a hash of the file's GFID plus the client's
PID, so different children will distribute load even for one file.
Mode 2 will probably be optimal for most cases. Using response time when we
open the file is problematic, both because a single sample might not have
been representative even then and because load might have shifted in the
hours or days since (for long-lived files). Trying to use more current load
information can lead to "herd following" behavior which is just as bad.
Pseudo-random distribution is likely to be the best we can reasonably do,
just as it is for DHT.
Change-Id: I798c2760411eacf32e82a85f03bb7b08a4a49461
BUG: 802513
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/2926
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a7c92f88d09efb69499a5ef6ec0b511fd53d2022
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Mar 23 13:16:06 2012 -0400
distribute: support user-specified layouts.
The new type is DHT_HASH_TYPE_DM_USER=1 (on disk in network byte order) and
we treat it the same as DHT_HASH_TYPE_DM except that we don't stomp on it
during rebalance.
Change-Id: I893571a9b89577acdea2fe868915b18d3663fd77
BUG: 807312
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3004
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b6283492d2c343c6c988ecf44959211c7f485af8
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat May 19 16:07:42 2012 +0530
mgmt/glusterd: Do shd validation for replicate volumes
Staging needs to build graphs for replicate volumes in stopped
state as well.
Change-Id: I6474cd0fc43c9fa1916826d4a452f301fe7fe811
BUG: 823128
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3489
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit df52852c587c94d6ded94eedb776512d10fcb808
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Apr 16 14:42:56 2012 +0530
storage/posix: Prevent gfid handle leaks
The case which can lead to gfid handle leaks:
Self-heal removes directory '/d' with 10 files in it, in brick b1.
This dir is renamed to <landfill>/<hashval of '<brick-path>/d'>
by posix. Before the janitor thread could remove the directory,
self-heal could remove another directory with same path '/d'.
Then again the rename to same path is done by posix as before.
The gfid-handles of the old '/d', 10 files in it are not unlinked.
To prevent such problems, rename the directory to be removed to
<landfill>/<gfid-str>.
Change-Id: Iad13708e1ebcc5222b64c058aa9a2d372e1bfa5b
BUG: 811970
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3159
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c79f935abb83e3a4ba5be4de607b13cf00a57617
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Apr 14 12:21:25 2012 +0530
storage/posix: Move landfill inside .glusterfs
Change-Id: Ia2944f891dd62e72f3c79678c3a1fed389854a90
BUG: 811970
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3158
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 59a263ce599fd157e20bfab76b0514a9d50a4cca
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri May 25 16:13:41 2012 +0530
glusterd-hooks: added support for separate namespace for 'volume set' keys
The keys in the above mentioned namespace could be used by hook
scripts to peform tasks on 'special' keys as defined by the storage
admin. The choice of the key and its semantics of it are outside
the scope of glusterd. It is the responsibility of the storage admin
to keep the meaning of the key(s) consistent.
If a user gives a command like
'gluster volume set <VOLNAME> user.for-this-key do-this"
scripts would get 'user.for-this-key=do-this' as argument.
Change-Id: I5509e17d99e4ddd8bf5df968dcd51ff9a80dc3ab
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 825902
Reviewed-on: http://review.gluster.com/3443
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d0ac93af1a13a8461ce524e9e655b9ab8a2cd21e
Author: Csaba Henk <csaba@redhat.com>
Date: Tue May 29 17:21:34 2012 +0530
glusterd: cut out a standalone socket path calculation routine
Change-Id: If5f196c9154ea59e37b83d3e4cad445fee6e9d45
BUG: 826512
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3490
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit 93fe09a6aa223cc1e0818a766b0f2bdfcb89d8cd
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed May 30 19:05:06 2012 +0530
logging: change the 'logfile' value in a locked region
'logfile' is a global variable, and it can change if log-rotate
command is issued. currently 'fprintf(logfile)' happens in a
locked region where as the 'fclose(logfile)' can happen outside
the locked region causing racy behavior.
Change-Id: I40871e5c365303b7c602e2c302b085d64f6b945f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 826032
Reviewed-on: http://review.gluster.com/3493
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3dd376315e7695e558dcd8948991d5d7e1d84b80
Author: Anand Avati <avati@redhat.com>
Date: Tue May 29 22:30:53 2012 -0700
protocol: do not log getxattr/ENODATA as warning
When SELinux is enabled, most of the files do not have labels and
result is a ton of unnecessary logs
Change-Id: I0e781e2fb6bcfb3fb12298175a41f7b981af9c39
BUG: 811217
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3486
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 9edb06665f9ceed3a09e03e0d2ed849ed0e7fe58
Author: Anand Avati <avati@redhat.com>
Date: Tue May 29 22:01:42 2012 -0700
fuse: make SELinux support configurable
Make support for SELinux labels (extended attributes) configurable
and disabled by default as it can cause significant performance
penalty when enabled (it need not be enabled unless specially crafted
policies are set -- which is not by default)
Change-Id: I97bc4b1c26cf055fd520e9bf2d49e52b14fe7515
BUG: 811217
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3484
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 868183ab8e9e36edeaf00c709be75827265cbf35
Author: Amar Tumballi <amar@gluster.com>
Date: Tue May 15 22:12:53 2012 +0530
glusterd: change working-directory from /etc/glusterd to /var/lib/glusterd
as it is changed in RPM based install (using spec file), makes sense to do
it everywhere, even in source install
Change-Id: Ibe5ebd860b1529aca295b79d683a3b2e6797506c
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 824231
Reviewed-on: http://review.gluster.com/3338
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 86424f4d866dfcddacf8e4e7d1f3b8d5a664205e
Author: Raghavendra Bhat <raghavendra@redhat.com>
Date: Mon May 28 12:15:29 2012 +0530
performance/md-cache: make cache timeout reconfigurable via cli
Change-Id: I73685bf73a14435884d3489343bbe71c331eb2a5
BUG: 825638
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.com/3458
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 74a36e7516f619a80071c7a4cf5a0e84f2b1a8ba
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri May 25 00:25:05 2012 +0530
server protocol : logging and negative case logic fixes
* log 'resolve' gfid, instead of inode gfid, which fails to log
for everything which fails to resolve.
* in case of 'op_ret == -1' never look into xdata or any other
argument.
* bring uniformity in the _cbk() code.
BUG: 821139
This patch is not complete fix for above mentioned bug, but is
useful the debug it properly
Change-Id: I159becdde70720cba072e494f70951395dc6868f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/3437
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 60740c31aec4e290edd7c2fb031ec4770562e456
Author: Mohammed Junaid <junaid@redhat.com>
Date: Tue May 29 16:33:52 2012 +0530
swift: Fix for multiple mounts on the same mount point.
When swift server receives multiple requests on a volume and if the
volume is not mounted before hand, for each request swift tries to
mount the GlusterFS volume on the mount point. This process is racy
and may mount multiple times on the same mount point.
Also added a new option object_only in fs.conf which should be enabled
only if the user requires ReST interface and will have better performance.
By default it is set "off".
Change-Id: Ie1718554c5aaf577e823bbd84da8e78d803e954d
BUG: 821310
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/3477
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2118c41bc7f51693319f49cba38700e026c4e097
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri May 25 23:41:19 2012 +0530
glusterd: Run post hooks on a different thread
This change ensures post hooks can 'wait' if need be
and _not_ prevent glusterd from being able to run other operations
meanwhile.
Also ensures that post hook scripts are 'serialized'
between transactions. ie, post hook scripts of txn1 are completed
before post hook scripts of txn2 are started, where txn1 happens before
txn2.
Change-Id: Iaeb676737d8c67e7151127c8d1fd8c2891e10aee
BUG: 806996
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3450
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6f8267380fbe6d35f071b38c575e48db981c9a68
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed May 23 14:08:37 2012 +0530
nfs/nlm: statedump of locks
This change allows statedump of nlm locks
giving number of clients, number of locks
each client holds and the files on which lock(s)
is/are held.
Change-Id: I6341c12ec58005ef71b93b316b527e610ff7ee8f
BUG: 824804
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3432
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5dae105e792d944a94e623b2df1d7125e16a8c1d
Author: Anand Avati <avati@redhat.com>
Date: Sun May 27 16:52:21 2012 -0700
storage/posix: readdirp enhancements
- avoid multiple calls to posix_istat(). use cheaper posix_pstat()
- code re-org
Change-Id: I4a2e32626ade49b7d18158952849c6fe7bd6875c
BUG: 816140
Reviewed-on: http://review.gluster.com/3460
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a891d7194a2bd42e8cae2c88f8c97c0f2d422312
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue May 29 00:35:20 2012 +0530
build: Update licensing in buildspec
Change-Id: I1d3348a99dad621608eccb08a71c85766e9ae451
BUG: 820551
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/3469
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1fb2709123969cacb37274d9c40221e642228f31
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon May 28 23:53:14 2012 +0530
libglusterfs: Fix incorrect NULL check
Change-Id: I22e1bf1669e639b5097b2b56c90b47e8b733a34d
BUG: 825197
Reviewed-on: http://review.gluster.com/3467
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3c2111821af327d7cbba2cff451c9464bc3a5cc4
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Tue May 8 15:15:31 2012 +0530
nfs/mount: Support MOUNT protocol on UDP. Needed for NLM on solaris clients.
Change-Id: I3f5c35d06827fb267a7dae53d949c61567a945d0
BUG: 799287
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/3337
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4f7bca6db61d2d172f5c64094e292beaf726fe3e
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed May 23 15:15:51 2012 +0530
glusterd: Replace-brick should create dst brick path only on 'dst' node.
Change-Id: I61e6f8aa44dfef85c7cd98f40b176b796422c4b2
BUG: 824302
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3415
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ad262bc939699fb5abe49b4a2efa752e273ab3a5
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri May 25 16:41:14 2012 +0530
rpc-transport/rdma: logging enhancements
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: I07f00fb768dfdabdc04b43fdb8a0609098cd1838
BUG: 822337
Reviewed-on: http://review.gluster.com/3445
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 70e4b242ebd3e6466946d1f2d6109b7232d58728
Author: Csaba Henk <csaba@redhat.com>
Date: Sat May 26 02:24:23 2012 +0530
glusterd/geo-rep: do away with unneded function exports
Change-Id: I0c0b500bcb0b183ae445800fd334cd838b8af0d3
BUG: 764890
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3455
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 82c74a72b46886ee5c3d525ccfb45b9bc3381b7a
Author: Csaba Henk <csaba@redhat.com>
Date: Sat May 26 19:04:25 2012 +0530
glusterd/geo-rep: cleanup and fixes
- fix the hilarious fd leak of "geo-rep status"
- instead of "corrupt", which can trip up users to think their
data is in danger, use the term "defunct" to describe the
condition when gsyncd is dead/unresponsive
- don't use buffered I/O when unnecessary
- stop using PATH_MAX for sizing buffers that don't hold paths
- some cleanups wrt. memory management
Change-Id: I396aacc45dc06a002318b19c60c44041fa9fa18d
BUG: 764268
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3454
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 84f9fac901412b6274ec53e6de038ccc56ca4a32
Author: Venky Shankar <vshankar@redhat.com>
Date: Fri May 25 15:41:14 2012 +0530
glusterd / geo-rep : fix rotating slave log file
Attempt to rotate log files for slave that are local.
Remote slaves (identified by the 'ssh' scheme) are
ignored.
Change-Id: I89959278c0eefffabc6a6702d4ef661cf52644a6
BUG: 821443
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/3444
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d73868dd35eeb36a5177f1a4bd117fdc12c93012
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri May 25 06:39:48 2012 +0200
Switch to GNU basename_r() and dirname_r()
BSD basename() and dirname() return static storage, hence they are not
thread safe, while GNU flavors are. glusterfs assumes the GNU behavior.
As a fix, we added a BSD-derived, thread-safe version of basename_r()
and dirname_r() in contrib/libgen. BSD systems can use it instead of
their built in versions.
Unfortunately, there are more reliance on GNU behavior in glusterfs.
There are place where free() is called on static storage returned by
basename(), place where a second call to dirname() overwrite the
string obtained once, and so forth.
Each of these problems can be fixed, but it is likely to be a pandora
box. We need to accept that glusterfs heavily rely on GNU behavior,
and switch contrib/libgen's basename_r() and dirname_r() to the GNU
version. This change does just that.
BUG: 764655
Change-Id: Id874b9c7aacd9aa3a7a4bd6a92a9633f5b2d6ac0
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3430
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7232f8ad53365c26a61b370fd6d71cb66d80beb6
Author: Csaba Henk <csaba@redhat.com>
Date: Sat May 19 02:43:05 2012 +0530
geo-rep / gsyncd: further cleanup refinements
- Regarding issue of leftover ssh control dirs:
If master side worker is stuck in connection establishment
phase, have the monitor kill it softly (ie. first by SIGTERM,
to let it cleanup). This is trickier than sounds on first hearing,
because if worker is stuck in waiting for a RePCe answer
(in threading.Condition().wait()), then SIGTERM is ignored
(more precisely, Python holds it back for the wait and resends it to
itself when wait is over).
So instead of signalling the worker only, we send TERM to the
whole process group -- that brings down the ssh connection, which
wakes up the waiting worker, which then can cleanup. Only problem
is that monitor is also in the process group and it should not coomit
a suicide. That is taken care by setting up a one-time SIGTERM
handler in the monitor.
- Regarding slave gsyncd stuck in chdir:
Slave gsyncd is usually well behaved: if master does not send
keepalives, it takes care to exit. However, if a hang occurs
in early phase, when slave is to change to the gluster mountpoint,
no timeout is set up for that (and unlike on master side, neither
is there an external actor like the monitor to do that).
So, to manage this scenario, we do the chdir in a (supposedly)
short lived thread, and in the main thread we wait for the termination
of this thread. If that does not happen within the time limit, main
thread calls for cleanup and exit. (This logic explicitely takes the
appropriate action in the cases when chdir succeeds or when hangs;
but what about the remaining case, when chdir fails? Well in that case
the chdir thread's exception handler will put the process to
cleanup and exit route.)
Change-Id: I6ad6faa9c7b1c37084d171d1e1a756abaff9eba8
BUG: 786291
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3376
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1394de569b57eee99f769cdbaa256c3a02dfff3f
Author: Amar Tumballi <amar@gluster.com>
Date: Tue May 15 22:34:02 2012 +0530
glusterd-portmap: adhere to IANA standards while assigning brick ports
RFC 6335
Change-Id: Iafbba70d24db95807ae73d27c96288d18d7232e5
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 824233
Reviewed-on: http://review.gluster.com/3339
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 63a7e88fd61c5d7b9e15fe0d30a0a0b26bcbcc6e
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed May 23 14:44:26 2012 +0530
nfs/nlm: avoid duplicate replies for nlm procedures
The way NLM handles errors and corresponding response
messages has been simplified to avoid duplicate replies
in case of failures.
Also, unlock_cbk and unlock_fd_resume functions are moved
in with other unlock functions.
Change-Id: I94100aa3c8de95dabebed4598651bbcd49d95782
BUG: 824316
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3414
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 97beade54294adc2be1b6831d366715b215400e3
Author: shishir gowda <shishirng@gluster.com>
Date: Thu May 24 12:51:32 2012 +0530
glusterd/remove-brick: Reset decommission stats on all nodes
Decommissioning is started only on nodes where the bricks which
are being decommissioned are present. The stats were reset only
when decommission was started. Hence stale stats were being
shown on nodes where the bricks were not present.
BUG: 822778
Change-Id: I2d839f877d4e040b463bebde5ba753b7265ab633
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3425
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 75381bf8d9e2b8d3c615df6afd1a7f2f875da2dc
Author: Csaba Henk <csaba@redhat.com>
Date: Wed May 23 14:54:02 2012 +0530
geo-rep / gsyncd: add "--super" to rsync invocation
This forces rsync to perform supposedly privileged operations on
unprivileged slaves (like chown(2)).
For consistent behavior (with gsyncd's "chown" RPC call that's
being used for symlinks and directories), we also pass
"--numeric-ids" to rsync.
Also took the chance to retire gsyncd's "--rsync-extra" option
which was there for debugging purposes (related to a resolved
issue).
Change-Id: I4ee4d0d3a8c4e0f6746d34d7722c8a567a67491c
BUG: 822121
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3426
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 61c2d5a853abeec5726092e110a4bfbf1b4105e7
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu May 24 19:56:55 2012 +0530
cluster/afr: decrement changelog when fdctx is absent
Change-Id: I9d76ddbd2cf8e4e8e4ad70529ba3a70178489a68
BUG: 765194
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3435
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit beb94720335ff13c38533ef395206de797eafbf0
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu May 24 12:58:04 2012 +0530
rpc: fix the vecsizer issue
* currently, we needed 'base-address' of the header for glusterfs
writev vecsizer and 'current-address' of the buffer which is
reading the data on socket, for nfs write vecsizer.
* nfs write issues started coming after http://review.gluster.com/3182
was pushed into repo, now fixed.
* fixed by sending both as argument for vecsizer from the transport
Change-Id: I6db360ce265ce5f083f1794ebdb3867f8cfad9ec
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 824472
Reviewed-on: http://review.gluster.com/3431
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f12c55141351209e37e2ba6fa190891616f1bc18
Author: shishir gowda <shishirng@gluster.com>
Date: Tue May 8 16:21:29 2012 +0530
glusterd/rebalance: Display run-time of rebalance process
Added run-time value field to cli output of rebalance/remove-brick.
A new cluster/distribute boolean option rebalance-stats when set to
ON, time taken for migration of each file is logged.
With rebalance-stats OFF (default), rebalance logs will only have
entries showing time spent in each directory.
Change-Id: I02a8918621120068cd71ffaf2999d30b3a2d10a2
BUG: 821987
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3303
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6d722e1505e22c25debda889fdfa3ae3322f116c
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed May 23 14:48:09 2012 +0530
mount.glusterfs : multiple fixes
* made log-level and other string comparisons be case insensitive
* fixed wrong spelling, wrong command usage in case of brick inode
computation
* used 'cut' instead of 'tr' as piping the result to read was not
working fine in few cases.
Change-Id: I9caab481cfd80000b8ef9de7a44006729c88cc1b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 823403
Reviewed-on: http://review.gluster.com/3413
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b7ce9a5bd534449bfbb0ca58a563af5c9e848786
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Apr 18 14:30:16 2012 +0530
glusterd: Disconnected bricks of 'stale' volume before deleting it.
If glusterd_delete_bricks is called before glusterd got the DISCONNECT event
from the brick that was stopped, then glusterd_brick_rpc_notify would
dereference a free'd brickinfo. This can happen if the brick had not been
disconnected before.
Change-Id: I6c07ec50f6739422a14478a549edd06c4c0ce913
BUG: 802015
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3183
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 878f2975bde41abca76e2f6d99af4c2dbd71e758
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed May 23 18:09:48 2012 +0530
cluster/afr: Release inodelk on erase changelog failures
Change-Id: I58271e1ac5a116b5bc717d7cad9f03eb7dc8a1a4
BUG: 811551
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3417
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ca2f4008c929934a6a5df5f1b4bd3c16b6425d47
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed May 23 23:43:44 2012 +0530
protocol/client: use correct xlator object while creating frames during reopening files and reacquiring locks.
Change-Id: I29f42fcfa9e782ce9e323e53024e5034029914a7
BUG: 822337
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3420
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9233a131d4b7d69bfa643f5ca3108154b6327ade
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed May 23 15:49:09 2012 -0400
Fix build error from recent FUSE changes.
Change-Id: Ia878949d00b1ef188b18c853763918b83521ee34
BUG: 762389
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3423
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ab1ae371d026f67466bae23dc05545735a484952
Author: Anand Avati <avati@redhat.com>
Date: Wed May 23 12:03:51 2012 -0700
Revert "fuse-resolve: consider cases where an entry should be resolved even when parent belongs to active itable."
This reverts commit 595bc33c1d0a3a6fe3d54d3eb876ac0b336d9dea
Change-Id: I6c67404d4ff0bc83cfac83d786bc6e66d221a84a
Reviewed-on: http://review.gluster.com/3422
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a3209ca78795f1a0786e2f022000ee7446e92a7d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat May 19 14:49:21 2012 +0530
performance/quick-read: fix race-conditions in qr_unlink.
The list of fds on which open needs to be done as part of unlink,
was being modified at different places using different locks.
This resulted in a race-condition where open was marked as in-transit,
but fdctx was removed from the list of fds on which open was being
sent even before open was done. Because of this, open_in_transit would
be set forever (as an open was never actually sent, there would be no
open_cbk called and hence we could not reset the variable), blocking
all the future fd based fops on this fd.
Change-Id: Ie84a55bee578869a9a060a094ba28480e7643ae8
BUG: 819490
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3371
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 4c75830c8003a7c26e55efc9d020961c9bbe7ca7
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed May 23 12:59:02 2012 +0530
distribute: use global synctask 'env' instead of local
creating a local synctask_env can lead to creating of many more
syncop threads than required. The current syncop logic can handle
the scale-up/scale-down of threads depending on the load. Hence,
its neater to use global synctask env.
Change-Id: Id46f963a0190c0154513317ae03323db155ac15a
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 823774
Reviewed-on: http://review.gluster.com/3412
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 85e51171279345618f5ba49840bcc28340d1271a
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue May 22 17:21:20 2012 +0530
protocol/client: do not print the null gfid when symlink fails
Change-Id: I1a2748768bc30a00c4f7b2e2fda1d282bc581658
BUG: 823880
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3411
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b083ae7a285dc34050067e886ff96f8752a33ec8
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue May 22 23:41:34 2012 +0530
mount.glusterfs: use proper format specifer for getting the inode number and device type for the mount point
Change-Id: I3ca46cce61a08c8636ee9fc031a37a0a4bcb728e
BUG: 764655
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3410
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 82bce9d93ff72431277510b9432bbf70b7b1577c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Mon May 21 18:38:11 2012 +0200
Fix volume create
Improve Krishnan Parthasarathi's patch, which fixed situation where
a brick mount point did not had EA enabled. This fixes an incorrect
assumption that dirname(3) returns the same address it was given as
argument. GNU dirname(3) does it, BSD dirname(3) does not.
Also makes the code a bit easier to read.
Change-Id: I031fda5b9359a64eefb2279e640e73a416e58d90
BUG: 812214
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3380
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 308a3d956cc42706aedc97fc09c12bc58f1859e6
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Thu May 10 16:24:45 2012 +0530
core: canonicalize paths
canonicalize paths during add-brick, creation of volume,
setting nfs.export-dir in volgen
BUG: 789870
Change-Id: I1d3788ac850359b0def0457113831e825a475d58
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3315
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4addd87ede89a736202f0e85d3a5c1336c50f79c
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun May 20 21:02:55 2012 +0530
cluster/afr: Unlock higher entry locks in rename entrylk failure.
BUG: 823255
Change-Id: Ic6ad33518ea42c9518a21381518bd4f4afdd87cb
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3382
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c3b08c6d837e34ebc25b1a6a285f15c0b0140ec8
Author: Mohammed Junaid <junaid@redhat.com>
Date: Mon May 21 15:47:28 2012 +0530
swift: Passing account name in container_update.
This patch also contains fixes to bugs
* 811501
* 812498
* 821310
Also, removed the default set of users in the proxy-server.conf file.
Change-Id: Ief83905d10ff7bf7c43685ada4d7f05959cee9d1
BUG: 821310
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/3390
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2a8eaf09762eeed5601935c962b9676abccd8f60
Author: Kaushal M <kaushal@redhat.com>
Date: Sun May 13 09:32:56 2012 +0530
cli,glusterd,debug/io-stats: Clear top stats
Introduces a cli command to clear "volume top" stats. The syntax for clearing
stats is
# gluster volume top <VOLNAME> clear [nfs]
This patch also fixes io-stats xlator, to create ios_stat struct for open fop as
well, along with create and mkdir fops. This allows stats to be recorded for
files that exist already after clearing stats or restarting brick process, which
would not occur otherwise.
Change-Id: I1b87e192025be7bb8a51eaff3d09c747d05d7def
BUG: 771709
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3334
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2f39799f2af8e8167db4a6fe2b3c875a182aa5b8
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Apr 24 23:49:06 2012 +0530
nlm: do not use killall command to kill rpc.statd
killall command will kill the rpc.statd process only in normal mode.
If the process is running in valgrind mode, then killall is not able
to kill rpc.statd and several instances of rpc.statd will be running
for every restart of the nfs server (graph changes etc).
So to avoid that get the pid of rpc.statd using /var/run/rpc.statd.pid
and send SIGKILL signal to that pid to accomplish what killall command
was doing.
Change-Id: I2509bf918ddd0dcdd9a4562ee23f13488c7a5979
BUG: 815756
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3225
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3ecd0bddd39d855c997356b1c826c9d9b01a4879
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Mar 9 09:11:23 2012 +0100
geo-rep / gsyncd: fix cleanup of temporary mounts
[This is a "forward port" of fafd5c17, http://review.gluster.com/2908]
The "finally" clause that was meant to cleanup after the
temp mount has not covered the case of getting signalled
(eg. by monitor, upon worker timing out).
So here we "outsource" the cleanup to an ephemeral child process.
Child calls setsid(2) so it won't be bothered by internal process
management. We use a pipe in between worker and the cleanup child;
when child sees the worker end getting closed, it performs the cleanup.
Worker end can get closed either because worker closes it (normal case),
or because worker has terminated (faulty case) -- thus as bonus, we get
a nice uniform handling with no need to differentiate between normal and
faulty cases.
The faulty case that was seen IRL -- ie., users of maintainance mounts
hang in chdir(2) to mount point -- can be simulated for testing purposes
by applying the following patch:
diff --git a/xlators/mount/fuse/src/fuse-bridge.c b/xlators/mount/fuse/src/fuse-bridge.c
index acd3c68..1ce5dc1 100644
--- a/xlators/mount/fuse/src/fuse-bridge.c
+++ b/xlators/mount/fuse/src/fuse-bridge.c
@@ -2918,7 +2918,7 @@ fuse_init (xlator_t *this, fuse_in_header_t *finh, void *msg)
if (fini->minor < 9)
*priv->msg0_len_p = sizeof(*finh) + FUSE_COMPAT_WRITE_IN_SIZE;
#endif
- ret = send_fuse_obj (this, finh, &fino);
+ ret = priv->client_pid_set ? 0 : send_fuse_obj (this, finh, &fino);
if (ret == 0)
gf_log ("glusterfs-fuse", GF_LOG_INFO,
"FUSE inited with protocol versions:"
Change-Id: I14bad56a60a7fa82d0104fa4b9a20f4e42a7186f
BUG: 786291
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3259
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7fe646ead6856cb57ce563eade7111c9c4e4efaa
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Fri May 18 17:43:49 2012 +0530
nfs/nlm: nlm-unlock call should reply success in case it is not able to find the lock in the list.
Change-Id: I84b298702c445320082ef03de90c924931f1a1e1
BUG: 822384
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/3368
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 14c8c595a78a1e9190df8219b36d5464006741a0
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue May 1 23:30:53 2012 +0530
protocol: handle proper vector size for writev()/readv()
* fixes the offset handling issue when 'xdata' is sent in writev/readv fop
at the transport layer itself.
* client_writev() was not sending xdata on wire, fixed
Change-Id: Ib5ced64c84d415f07032662017979c65d9a1a128
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 808078
Reviewed-on: http://review.gluster.com/3182
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5e1fb488e09c2339b77d69ad5236a1fb5250734e
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sat May 19 17:14:14 2012 +0200
Thou shalt not free(3) memory dirname(3) returned
On Linux basename() and dirname() return a pointer within the string
passed as argument. On BSD flavors, basename() and dirname() return
static storage, or pthread specific storage. Both behaviour are
compliant, but calling free on the result in the second case is a bug.
BUG: 764655
Change-Id: Ic82414aff1f8db2a7544b16315761ce1c05276c4
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3377
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit 3cd359254f1da5bd0f78b1e2388f7fe3f6f5a0ca
Author: Csaba Henk <csaba@redhat.com>
Date: Tue May 15 21:24:43 2012 +0530
fuse: sync with upstream
Cherry-picked following commits from
git://fuse.git.sourceforge.net/gitroot/fuse/fuse
form 555d6b50..acc5c79d interval:
commit 1193a39c0869a3608f22472735bcffdcccb6b2a5
Author: Reuben Hawkins <reubenhwk@gmail.com>
cleaning up warnings
commit dba9185999dfa35161d4c810735df0ab3fde5104
Author: Laszlo Papp <ext-laszlo.papp@nokia.com>
Check the 'mtablock' for negative value
commit e63a9d8ee6529c9d15a87745276f45c9bdad3961
Author: Miklos Szeredi <miklos@szeredi.hu>
fusermount: clean up do_mount() function
commit 81fee822a098a3e26969401fc486f136465f96f0
Author: Laszlo Papp <ext-laszlo.papp@nokia.com>
Eliminate the unused value
commit 60eb44ee5eb2756465610b215968f176f4aaac6e
Author: Laszlo Papp <ext-laszlo.papp@nokia.com>
Fix resource leaks in fusermount
commit d6bec4020fddd4dd67248789a1af600580f2cbda
Author: Miklos Szeredi <mszeredi@suse.cz>
In case of failure to add to /etc/mtab don't umount.
commit 1e7607ff89c65b005f69e27aeb1649d624099873
Author: Miklos Szeredi <mszeredi@suse.cz>
fusermount: chdir to / before performing mount/umount
commit 2fcbc2a5a94983813c533c015134c6974f8ee636
Author: Miklos Szeredi <miklos@szeredi.hu>
fusermount: don't save/restore cwd
commit bd99f9cf24e16643752b02fb4fa7b48f2124ab4e
Author: Miklos Szeredi <miklos@szeredi.hu>
Fix check for read-only fs in mtab update
Nb.:
- not picked changes that implement and enforce mount/umount
mechanisms based on newer util-linux features (umount --fake
and --no-canonicalize)
- not picked fusermount "auto-unmount" feature
Change-Id: Ib9498516184336e77ec047e5414125332d0a4292
BUG: 762389
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3343
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 888bfc0853137c7f1a6b4d176595bbd26d9a3489
Author: Csaba Henk <csaba@redhat.com>
Date: Tue May 15 13:41:57 2012 +0530
fuse: reorganize mounting code
Macro-driven conditional compilation was a chaos.
New scheme is:
contrib/fuse-lib/mount-common.c:
libfuse routines used both by glusterfs and fusermount
contrib/fuse-lib/mount.c:
libfuse-derived but customized mounting code for glusterfs
contrib/fuse-util/mount_util.c:
libfuse routines used only by fusermount
Change-Id: I3e0ba7f74e36556b78244cd7676eb4d379939602
BUG: 762389
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3342
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fba125a5f443f324f01fa5866fc72243ec91c9e0
Author: Csaba Henk <csaba@redhat.com>
Date: Mon May 14 17:07:28 2012 +0530
fuse, glusterfsd: mount logic fixes
Commit 7d0397c2 introduced two issues:
i) broke the libfuse derived mount logic (details below)
ii) in case of a daemonized glusterfs client is ran as daemon, parent
process can return earlier than the mount is in place, which breaks
agents that programmatically do a gluster mount via a direct call to
glusterfs (ie. not via mount(8)).
This patch fixes these issues by a refactor that merges the approaches
sported by commits
7d0397c2 fuse: allow requests during mount (needed for SELinux labels)
c5d781e0 upon daemonizing, wait on mtab update to terminate in parent
Original daemonized libfuse event flow is as follows:
try:
fd = open("/dev/fuse")
mount("-oopts,fd=%s" % fd ...)
mount(8) -f # manipulate mtab
except:
sp = socketpair()
env _FUSE_COMMFD=sp fusermount -oopts
fd = receive_fd(sp)
where fusermount(1) does:
fd = open("/dev/fuse")
mount("-oopts,fd=%d" % fd ...)
sp = atoi(getenv("_FUSE_COMMFD"))
send_fd(sp, fd)
daemonize(
# in child
fuse_loop(fd)
)
# in parent
exit()
As of 013850c9 (instead of adopting FUSE's 47e61004¹), we went for async
mtab manipulation, and as of c5d781e0, still wanted keep that in sync
with termination of daemon parent, so we changed it to:
try:
fd = open("/dev/fuse")
mount("-oopts,fd=%s" % fd ...)
pid = fork(
# in child
mount(8) -f
)
except:
sp = socketpair()
env _FUSE_COMMFD=sp fusermount -oopts
fd = receive_fd(sp)
daemonize(
fuse_loop(fd)
)
waitpid(pid)
exit()
(Note the new approch came only to direct [privileged] mount, so fusermount
based mounting was already partially broken.)
As of 7d0397c2, with the purpose of facilitating async mount, the event flow
was practically reduced to:
fd = open("/dev/fuse")
fork(
mount("-oopts,fd=%s" % fd ...)
fork(
mount(8) -n
)
)
daemonize(
fuse_loop(fd)
)
exit()
Thus fusermount based mounting become defunct; however, the dead
code was still kept around. So, we should either drop it or fix
it. Also, the mtab manipulator is forked into yet another child
with no purpose, while syncing with it in daemon parent is broken.
mount(2) is neither synced with parent.
Now we are coming to the following scheme:
fd = open("/dev/fuse")
pid = fork(
try:
mount("-oopts,fd=%s" % fd ...)
mount(8) -n
except:
env _FUSE_DEVFD=fd fusermount -oopts
)
where fusermount(1) does:
fd = getenv("_FUSE_DEVFD")
mount("-oopts,fd=%s" % fd ...)
daemonize(
fuse_loop(fd)
)
waitpid(pid)
exit()
Nb.:
- We can't help losing compatibility with upstream fusermount,
as it sends back the fd only when mount(2) is completed,
thus defeating the async mount approach. The
'getenv("_FUSE_DEVFD")' mechanism is specfic to glusterfs'
fusermount (at the moment -- sure we can talk about it with
upstream)
- fusermount opens /dev/fuse at same privilege level as of
original process², so we can bravely go on with doing the open
unconditionally in original process
- Original mounting code actually tries to mount through
fusermount _twice_: if first attempt fails, then, assuming
subtype support is missing in kernel, it tries again subtype
stripped. However, this is redundant, as fusermount internally
also performs the subtype check³. Therefore we simplified the
logic to have just a single fusermount call.
- we revert the changes to mount.glusterfs as of 7d0397c2, as
now there is no issue with glusterfs to work around in that scope
¹ http://fuse.git.sourceforge.net/git/gitweb.cgi?p=fuse/fuse;a=blobdiff;f=ChangeLog;h=47e61004;hb=4c3d9b19;hpb=e61b775a
² http://fuse.git.sourceforge.net/git/gitweb.cgi?p=fuse/fuse;a=blob;f=util/fusermount.c;h=b2e87d95#l1023
³ http://fuse.git.sourceforge.net/git/gitweb.cgi?p=fuse/fuse;a=blob;f=util/fusermount.c;h=b2e87d95#l839
Change-Id: I0c4ab70e0c5ad7b27337228749b266bcd0ba941d
BUG: 811217
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3341
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ce9e42f10d471232da735b29ea47dcd059014a46
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed May 16 18:22:35 2012 +0530
common-utils: Simplified mkdir_p interface and put it to use.
- Simplified mkdir_p interface.
- Removed mkdir_if_missing from codebase
- Modified glusterd consumers of mkdir_if_missing to use mkdir_p
with allow_symlinks=_gf_true. This implicitly assumes that glusterd
is in 'control' of the brick path and glusterd's working dir in the sense
that the symlinks (if any) in any of the above mentioned paths are under
the 'storage administrator's control.
Change-Id: I7383ad5cff11b123e1e0d2fe6da0c81e03c52ed2
BUG: 823132
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3378
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a7eb0648db05b705521c447587299bb11942a1ac
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon May 21 13:34:20 2012 +0530
performance/md-cache: use mdc_fsetattr_cbk as the callback if setattr is on a fd
Change-Id: I114a16055540e0cd3317b83b329600251ffe03c3
BUG: 823886
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3386
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 99685cc3e5f2ad8f6291f46641872f238e706e1b
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Sat May 19 23:40:13 2012 +0530
locks: Fixed opt arg parsing in clear-locks
Change-Id: I470fd21d5d53e3c6f0bd2a4f84c6327532e18559
BUG: 823151
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3391
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 69d2990efd8dc64fdcb0f70fe65c83d939313b88
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri May 18 22:00:03 2012 +0530
cluster/afr: Assign gfid path if path is NULL in lookup
Change-Id: I45be4ea7f04ee79b67a83134fe8ebd18067a707f
BUG: 820355
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3373
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e005774ab26de1db9a3537f9fed4629b58ab8ccb
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon May 21 14:13:05 2012 +0530
protocol/client: free the 'loc2' variable of client_local
in common client_local_wipe(), local->loc2 was not getting freed
up, but its used in few functions for logging purpose.
Change-Id: I05715843b59aa216a79f5164a152c605dc9ad114
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 823133
Reviewed-on: http://review.gluster.com/3388
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6507f660070f7d576133a771b7ff5023b0a385b3
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon May 21 09:05:23 2012 +0530
protocol/server: fix a crash with NULL dereference
in setxattr() and fsetxattr() _cbk functions
Change-Id: I9798d182e7f68509e8e37d43cb18e4c2f4bd6fab
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 823244
Reviewed-on: http://review.gluster.com/3384
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9c11e048a4ed0973f66966c875bf2ed1c130d342
Author: Csaba Henk <csaba@redhat.com>
Date: Fri Apr 20 17:21:12 2012 +0200
geo-rep / gsyncd: fixes regarding the command invocation framework
Some of the bugs to fix were found by the following stress-test:
make "glusterfs --client-pid=-1" exit immediately on slave
side.
Also fix eintr_wrap which should not "adopt" exceptions generated
by the wrapped call, by re-raising them as GsyncdError.
Change-Id: Ia0d39e0635975ebbbf98d86e1e26f3122e1ed6ff
BUG: 764678
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3258
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit fa98e58ac419f2156420455d4c4685a4a72f4d37
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Apr 4 03:12:26 2012 +0200
geo-rep / gsyncd: recognize ECONNABORTED as termination of aux glusterfs
Don't dump stack, rather log the "glusterfs session went down" message.
If the aux glusterfs is already dead when we try to do some file
operation, we get a failure with ENOTCONN, which is already handled
as above. However, it's also possible that glusterfs dies while we
are in a syscall into it -- in that case we get ECONNABORTED, and
so far then we end up with an ugly stack strace. From now on we
take ECONNABORTAD as well into consideration.
Nb. wrt. testing: it's not easy to synthetically force the aux glusterfs
to end this way; for that we have to provoke gsyncd into intensive
synchronization. I succeeded in that with the following ruby oneliner:
ruby -rcgi -e '
Dir.chdir($*[0])
a=[]
Thread.new { loop { while a.size >= 100; File.delete a.shift; end; sleep 1 }}
loop { a<<CGI.escape(STDIN.read 10); open(a[-1], "w") {}}' MTPT < /dev/urandom
where the geo-rep master is mounted at MTPT. With this going on, deliver a
SIGKILL to the geo-rep session's aux glusterfs. (It is giving ECONNABORTED
non-deterministically, actually in the minority of cases.)
Change-Id: I24fd8d0295cdba91d8b994057a1255ca8e2d1a67
BUG: 764510
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3078
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 16f218629282e07a88a27d0b84e4f6f93ae6ccf8
Author: Csaba Henk <csaba@redhat.com>
Date: Mon May 7 16:59:43 2012 +0530
geo-rep / gsyncd: typo fix
fix topy.
Change-Id: I84df3e850dd24d9e86713dfa401c603a84a81ca6
BUG: 763302
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3375
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ba1095f43ac4decf35b1c40d31b829e531692bef
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu May 17 14:14:13 2012 +0530
glusterd: replace-brick should create dst brick path only once.
Change-Id: I51d1a5315fa7a4290a63a59c1ef14b3e82cdc929
BUG: 822338
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3354
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1bc57705bdde7232dfc178b4634cadf865912d8b
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed May 16 18:22:35 2012 +0530
common-utils: Added C wrapper to mkdir(1) -p functionality.
- Modified glusterd-rebalance to use mkdir_p C wrapper.
Change-Id: If9a00b8c0e00af644b9c3e64a5fc94cf6201827c
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3347
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 55d9d96841a715be60e5854e62aae780d68b570d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat May 19 11:14:25 2012 +0530
protocol/server: del_locker should delete one locker per unlock
Change-Id: Ie3281d693c1b6d1f631c77aece8039a08ad8f8fb
BUG: 771595
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3370
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0e884795dfc8c59d269f88a51b3f025e9ae2b3ce
Author: Csaba Henk <csaba@redhat.com>
Date: Mon Apr 16 21:37:31 2012 +0200
glusterd / mountbroker: warn if mountbroker-root permissions are suspected to be too strict
At the level of mountbroker, this is a best effort, as "too strict" depends
on the purpose it's being used for (thus we just warn, don't err). However,
it's a good guess, as it stands for existing use cases of mountbroker.
Change-Id: Ic5e7d6cb44ced5509c05e0ee8a9043252470683f
BUG: 765214
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3171
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b27de2e346f860409a669b486ef4fdc9e865c8e4
Author: Niels de Vos <ndevos@redhat.com>
Date: Tue May 1 11:40:17 2012 +0200
storage/posix,fuse-bridge: fill the d_type attribute in READDIRP replies
d_type should contain the type of the the dir-entry (man 3 readdir).
Currently the d_type is always set to DT_UNKNOWN (0). The POSIX standard
readdir() returns a 'struct dirent' on both Linux and NetBSD with the
d_type attribute.
Commit bb315cb180c3547218b5ed581d38e76aec74cf94 removed setting d_type
in xlators/mount/fuse/src/fuse-bridge.c. This was using
d_type_from_stat(). The stat() seems to have been removed for
performance reasons. Instead of removing d_type completely,
dirent->d_type could have been used. Therefore the fuse-brige can now
add "fde->type = entry->d_type" back into fuse_readdir_cbk() without
causing the previous performance impact.
Change-Id: I4514bbc0acceb33d09c3cf50bda51e34d953efca
BUG: 817785
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.com/3256
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b56fe3fcbf5ce76eb181973ce4b5c2d2afdc48e7
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Apr 14 14:33:53 2012 +0530
cluster/afr: Enforce order in pre/post op
The xattrop order in pre/post op on all the subvols
is client-0, client-1... client-n where n is (replica-count - 1).
This order can lead to invalid split-brains if the brick
dies in the middle of xattrops.
Example: transaction completed pre-op, so on all the subvolumes
xattrs have '1' changelog. Now post-op is sent to both the subvols.
On subvol-0 change-log of client-0 is decremented to 0, before
decrementing change-log of client-1 to 0 the brick dies.
This change-log status on subvol-0 gives the meaning that a
change is done on subvol-0 successfully but on subvol-1 it failed.
Which is not what happened.
Changes done when the subvol-0 was down will lead to pending
change-log on subvol-1 for subvol-0. Which is correct.
When the subvol-0 is brought back up, the change-log will be in
split-brain state even when it is not a legitimate split-brain.
If the brick dies in the middle of xattrops it should remain fool.
Pre-op should perform xattrop of the local change-log first and
post-op should perform xattrop of the local change-log last.
In case of optimistic changelogs txn_changelog should be done
last on local if it succeeds, first if it fails.
Change-Id: Ib6eeb20cdc49b0b1fd2f454f25a9c8e08388c6e7
BUG: 765194
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3226
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7d74a755f01d8dd2401209c2767a5a483a2ddd4f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Apr 2 21:46:42 2012 +0530
cluster/afr: Perform conservative merge on dir with xattr split-brain
Change-Id: I96d59ad239c2c5efee14dd4b01a10a3f565d491e
BUG: 765587
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3091
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4b89780fa8829fb914f1f5b750dbf63fee326420
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Mar 13 11:15:36 2012 +0530
cluster/afr: Handle files w.o. xattrs and size mismatch.
Change-Id: Ia27ee996bed8f5915c154718bf6e859b6a2fc335
BUG: 765587
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3090
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5314855175d68bdf10a8b6db9eccdf5b84f1d665
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Apr 5 14:26:22 2012 +0530
cluster/afr: Mark zero size file as sink in absense of xattrs.
Change-Id: I4500f39a49ee16e6e88451dcf147d9f49b1d749e
BUG: 765587
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3089
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f963ca8f325b498a4654b331f5b68d34f8074518
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Apr 5 11:31:47 2012 +0530
cluster/afr: Determining sources should do both fxattrop, fstat
Change-Id: Ifab37db2af8d489cd516e992b7423c765dcabc4f
BUG: 765587
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3088
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4fbea2336a4762d383d56ba12f0afc883367e329
Author: Kaushal M <kaushal@redhat.com>
Date: Thu May 10 16:11:17 2012 +0530
glusterd,cli: Enable errstr for peer detach
This patch adds an op_errstr member to the gf1_cli_deprobe_rsp structure to
enable return of an errstr to cli.
Change-Id: I0cbb6805b05d7cc0603c13d1c1550bb2bd062a7a
BUG: 816840
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3307
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c2c0b31a6210af901d9045ac92dd3ffe2529e726
Author: Kaushal M <kaushal@redhat.com>
Date: Thu May 3 10:43:38 2012 +0530
glusterd, cli: Enable errstr for peer probe
Presently glusterd only returns an errno to cli for peer probe command. This
patch allows glusterd to return an errstr as well to cli. An op_errstr member
has been added to gf1_cli_probe_rsp and gd1_mgmt_probe_rsp structs to allow
this.
In case of an error, cli will display the errstr if it was set. If errstr is not
set cli will display the error message based on errno.
Also, to allow for return of errstr in cases such as handshake failure, an
errstr member has been added to the glusterd_peerctx_t struct.
Change-Id: Iece2b44a7181555e960d9fe4517ec6cda4cdb385
BUG: 816840
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3262
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e4be7cd722aaa54f234c765c6ffcf054d626f96b
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri May 18 14:58:52 2012 +0530
features/quota: get the top xlator from the active graph outside the list
In quota reconfigure we were getting the top of the active graph within the
list which contains the limits set on the volume. Suppose the list is empty,
then the code inside the list traversal loop is not executed, and thus top
will be NULL which might lead to segfault when accessed later.
Change-Id: I1648d69256490878339294537e17300399ddbf2c
BUG: 822827
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3364
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bb6085f326452968c66143e6bac05b1741878ec9
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon May 14 16:41:10 2012 +0530
Self-heald: Enable configuring of heal poll timeout
Change-Id: I631e5bf4b3615b553b72e7ac7f490714b3b995f9
BUG: 821395
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3329
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 303c976c5be17c92a2bb172981c2d065ccc81cb7
Author: shishir gowda <shishirng@gluster.com>
Date: Fri May 18 08:14:07 2012 +0530
glusterfs/rebalance: Register cbk for glusterfs_rebalance_event_notify
In case of n/w failures, cbk needs to be passed to
mgmt_submit_request.
Change-Id: I519720dbdde4c8d46381144403751bf7ed6d3a51
BUG: 822086
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3359
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f8758d498668f471fbb501c7149149e64e2fe5bf
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri May 18 13:35:58 2012 +0530
cli: validate quota enable/disable arguments properly
Change-Id: I175cfd418fae52f3e82402c989b9f5da15058146
BUG: 807667
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3363
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 583096125fbaf42875915e6dd7ffea24b1ab087c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed May 16 06:36:19 2012 +0200
Provide missing basename_r and dirname_r
Some systems (e.g.: NetBSD) do not have thread-safe basename(3) and
dirname(3). This is fine with OpenGroup's Single Unix Specification
which allows these functions to use static storage. Unfortunately,
glusterfs uses them a lot and assume thread-safety.
This patch brings FreeBSD's thread-safe basename_r(3) and dirname_r(3)
in the contrib directory, and tweaks the build process so that
NetBSD builds use them instead of libc basename(3) and dirname(3)
BUG: 764655
Change-Id: Ic9a159fffdc7bacc9408f8e90854e4c2db81930c
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3320
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0f6ed1be69d8c127ef732f946b3e4b76a97ff0ed
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri May 18 09:15:47 2012 +0200
Library search order fix
Set LD_LIBRARY_PATH before starting glusterfs. This avoids loading
xlator from another glusterfs version if there are diffeent builds
installed on the system (e.g.: in /usr, /usr/local, /opt, /usr/pkg...)
BUG: 764655
Change-Id: I13bf0bea043351498b4bc885c5ac45b108229a0a
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3361
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 45521e697f5f4a71028a3a534b0402483ac63299
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri May 18 09:39:23 2012 +0200
stat(1) portability fix
stat(1) flag to specify format is not portable. This change works that
around and makes the script a bit more readable: ${getinode} instead of
stat -c %i
BUG: 764655
Change-Id: Iae3c40b03118078530c29d14d5f7180c36361c16
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3362
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1d9ef9166419b0e7dec35453d35dc2df3cb982ef
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri May 18 17:00:07 2012 +0530
features/locks: Don't delete blocked locks in pl_flush
Change-Id: I442e8d866df317b901f24cf447412179bb61a01c
BUG: 810502
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3366
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 41fbb2d97e2fd359a57390816a0144e2cc7623f4
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri May 18 11:06:52 2012 +0530
features/locks: insert_and_merge should not operate on blocked locks
Change-Id: I9417fe28d6c2907b8160cd70c2d2c755731bbe67
BUG: 810502
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3365
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9683ee2da30359a586c441e4aae93cfe802db454
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 12 17:13:09 2012 +0530
init.d: stop only 'glusterd' process on '/etc/init.d/glusterd stop'
earlier it used to stop even brick processes and gluster NFS server
process, which is not a expected behavior for command
'/etc/init.d/glusterd stop'
Change-Id: Ibc092cdf2693b3b2ae491d32ce3f0113854149c8
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 796998
Reviewed-on: http://review.gluster.com/2919
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1c0142be20eb03c22a2e5cfcaec4fded8ed67651
Author: Mohammed Junaid <junaid@redhat.com>
Date: Fri May 11 12:51:38 2012 +0530
protocol/client: Concatinate the graph uuid along with process uuid in setlk_version.
Change-Id: Idec06c5ef1d440864e465f008a38c86395b52aba
BUG: 820831
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/3314
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8b02abf9f543e4d9f630b0ef0530d3585c6b6211
Author: Csaba Henk <csaba@redhat.com>
Date: Wed May 16 15:40:47 2012 +0530
geo-rep / gsyncd.c: fix coverity fix
gsyncd wrapper was segfaulting as coverity fix freed
up pointer at wrong place (after it was reused)
Instead of the apporach of the original coverity fix
that added elaborate control flow to hunt down potential
leaks, here we move the code over to static allocations
in place of (the not really necessary) dynamic ones.
Change-Id: Ida3855ff4a4f4371b350d27f858f129ceed51785
BUG: 789278
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3345
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6cbc0c7b70835d20bbd2940ae39572c69a2cbf96
Author: Alexander Bersenev <bay@hackerdom.ru>
Date: Wed May 16 13:02:06 2012 +0600
Fixed a memory leak in stripe translator.
When iobuf is created it has reference count = 1.
After iobref_add (local->iobref, iobuf); reference count becomes 2.
After iobref_unref(local->iobref); it becomes 1 and never becomes 0.
So iobuf never deletes and this causes a memory leak.
I emulated it, creating files on brick manually.
After 5 mins of:
while true; do dd if=file of=/dev/zero bs=16384; done
top showed me this:
4618 root 20 0 1721m 1.5g 1868 S 0.0 16.2 5:41.77 glusterfs
1.5 gb of memory has leaked.
For what this if for? Can it be true in the normal conditions?
if ((local->replies[i].op_ret < local->replies[i].requested_size) &&
(local->stbuf_size > (local->offset + op_ret))) {
May be delete it entirely?
Change-Id: I17c115ab566e5bba662dd809e0c747db3c0310c8
BUG: 822378
Signed-off-by: Alexander Bersenev <bay@hackerdom.ru>
Reviewed-on: http://review.gluster.com/3340
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b1212b57582ca61c394361ce1d4450f73a8cd996
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu May 17 13:56:02 2012 +0530
protocol/client: check if the name is NULL before duping it
Change-Id: I1cefc34af6fae2e71b05179824963e06361c35a2
BUG: 822385
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3353
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
commit c463702c29ae2041a49c43c12fe69895e6edec44
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri May 11 18:11:31 2012 +0530
libglusterfs/fd: while dumping the fd_ctx use fd->xl_count
While dumping the fd_ctx when statedump is issued fd->xl_count should be
used to determine the number of xlators instead of using latest graph's count,
since while creating the fd only those many slots would have been allocated
as the number of xlators in the graph at that instant. Then the graph would have
changed, thus the xl count.
All the above things should happen before any operation is done on fd, otherwise
fd_ctx_set will allocate the extra slots for the new xlators present in the
graph.
Also added the program which can be used to reproduce the bug.
Change-Id: I11fe75d71ef5d37e29e2958d53752aa31098c313
BUG: 820887
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3335
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 05c0181f8a42f50d71c7d6cad8a01ba9efdd2342
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Thu Apr 12 14:49:44 2012 +0530
nfs/nlm: procedures for PC clients
* This change introduces four NLMv4 procedures:
NM_LOCK, SHARE, UNSHARE and FREE_ALL.
These are used by PC clients (windows/dos) to control access
to files.
1. NM_LOCK: this lock is not monitored by statd.
2. SHARE: A share reservation is a lock on the whole file
that is taken whenever a file is opened on windows clients.
This has ACCESS (N, R, W, RW) and DENY MODE (N, R, W, RW).
ACCESS: mode of access requested by the client;
DENY MODE: what the requesting client wants to
deny other clients.
3. UNSHARE: remove a share reservation obtained by SHARE.
Called while closing a file.
4. FREE_ALL: remove all share reservations and locks,
both monitored and unmonitored, of the calling client.
* lock and nm_lock use a common function with only
a flag conveying whether or not to monitor a lock.
* NOTES:
1. SHARE reservations are not STACK_WIND'd to subsequent xlators.
These are maintained in-memory in the nfs xlator.
2. Consequently, for SHARE reservations to work effectively,
all PC clients *must* mount from the same gNfs server.
Not doing so will result in different servers maintaining
separate SHARE reservations which will not be enforced
for obvious reasons.
Change-Id: Id4f22670a94ed58691a6a7f4c80aa8c11421a277
BUG: 800287
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3212
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
commit 975d73303332df1f5f592c032d8f7e520ec33253
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 20 17:22:43 2012 +0530
Self-heald: Print the time stamp of the event-history
Change-Id: I45767e26288ef6de6446ddf2ea82ed31e128d227
BUG: 796579
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3277
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 916d5fb77099f2ea72bd5034468ca4b6fd3da16e
Author: Kaushal M <kaushal@redhat.com>
Date: Tue May 15 16:31:55 2012 +0530
client/protocol : Changes in client3_1_getxattr()
Copy args->loc to local->loc in client3_1_getxattr(). This prevents logs with
"(null) (--)" in client3_1_getxattr_cbk().
Also save args->name in local->name and print it in the log as well.
Change-Id: I1bfd00c6bbbe9f617744af7acd2f07ceafaadb3a
BUG: 812199
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3336
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 13aed9283150fefddf16bd372862e792fdafb2ff
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon May 14 13:21:56 2012 +0530
cluster/replicate: check for 'loc->path' before dereferencing it
Change-Id: I4dada6fd509aa289e97fdb0b50b28300a15e6a0e
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 820355
Reviewed-on: http://review.gluster.com/3325
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 84cace5364c727e064be9ec381976d1952e7cccf
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon May 7 13:31:24 2012 +0530
glusterd: Fixed glusterd_brick_create_path algo.
- check if any prefix of the brick path has "trusted.gfid"
or "trusted.glusterfs.volume-id" set.
- set trusted.glusterfs.volume-id on the bricks as soon as
its induction into the volume is settled. Earlier, the setting of
"volume-id" used to happen during the first run of the brick process,
leaving of window for bricks part of one volume to be (ab)used by another
volume inadvertently.
- removed creation of brick directory (if missing), during start volume force.
This is to avoid directory creation as part 'force'ful starting of volume
and leave the responsibility with the user, who understands the
'availability' of the export directory (brick) better.
Change-Id: I4237ec4ea7a4e38a7501027e7de7112edd67de8c
BUG: 812214
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3280
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bfc029cb960354c56522f6108b0e02c79354f21d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Mar 13 17:33:34 2012 +0530
cluster/afr: Return EIO if read-child < 0 in inode-read fops
Change-Id: I8fb2369caffae8f295774b8b12a086c66ec714c7
BUG: 800884
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3332
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5b8074fff590b9693439c1ab9be4b31adc41e9af
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun May 13 09:11:57 2012 +0200
NetBSD build fixes
Last batch of NetBSD build fixes, makes 3.3.0qa40 operational.
Round 2: only include <sys/syslimits.h> for NetBSD
BUG: 764655
Change-Id: Icd7290f1e340675d763665a0d0c5f95bc14e0c55
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3321
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 811654ddf7e22e0bf60eafb23d77aad1b8e1ada4
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Apr 18 12:30:17 2012 +0530
fuse-resolve: Attempt fd-migration in resolver, if migration was never attempted.
Since fd is always associated with an inode, we can create an
fd only after resolver resolves an inode. So, there is a possibility
that graph-switch can happen after resolver kicks in, but before
it can complete, thereby resulting in the newly created fd not
migrated to new graph. So, instead of migrating fds only during
graph-switch, we give a second chance during fd-resolution.
As an example, consider following sequence of events during a
create call:
1. create wants to resolve parent inode, hence it starts
resolution for parent
2. graph-switch happens (it can happen since fuse-request reader
thread returns after winding lookup calls)
3. fd-migration of all the fds which are currently in fdtable is
attempted (Note that the fd corresponding to current create call
is not yet created and added to fd-table, hence it will not be
migrated as part of graph switch)
4. resolution of parent triggered as part of create, completes
5. fd is created in fuse_create_resume and this fd is not migrated
to new graph
6. Any future fops on this fd will fail with EBADF errors
(create call itself will succeed)
Change-Id: Iae06ecfaca24eaacb2e166ffefbbbb57446332ba
BUG: 804592
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3181
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d33e25677bee93e0bb1d0d2b36f7257a6b76e495
Author: Mohammed Junaid <junaid@redhat.com>
Date: Wed Apr 25 15:39:20 2012 +0530
mount/fuse: Use state->lk_lock to print lock information on EAGAIN.
Change-Id: I24a4a0b1c8dc0b8e08b380a5bc8efc111ccdb2c3
BUG: 808400
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/3227
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 945856cb03f17ae5902061d019a4223531aef106
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue May 15 16:00:52 2012 +0530
nfs/mount: avoid duplicate reply on ENOENT
Change-Id: I310e525b5bd302c0acadcc077213fbd570bf772d
BUG: 820582
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3333
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0c6fcfbcdfa63c21a9a9b2b0517c70f1fbf5ffbc
Author: Joe Julian <me@joejulian.name>
Date: Tue May 15 01:09:52 2012 -0700
Fix spelling error
"temporary" was misspelled
s/tempaory/temporary/
BUG: 818884
Change-Id: I19e28b4f0cbeeb6d7441590b0c4ddcfc49bb13d2
Signed-off-by: Joe Julian <me@joejulian.name>
Reviewed-on: http://review.gluster.com/3331
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b8b6c6cd1e0d691ef430d6099857bd4c7d89c4ab
Author: shishir gowda <shishirng@gluster.com>
Date: Mon May 14 14:50:05 2012 +0530
cluster/dht: Handle ENOENT failure in dht_rmdir_opendir_cbk
We should not treat ENOENT as a failure in rmdir.
Change-Id: I1570d2be2bbafe7fc61ca39b8f7f68ee60d2c707
BUG: 806761
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3327
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bef95fb4880702b76dba0c14bea925b4aa92af15
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sun May 13 21:56:06 2012 +0530
features/marker: use the gfid from the stat structure instead of inode
in fresh lookup, the inode would not have linked to the inode table
until the fop reaches back to protocol/server, thus it would not contain
the gfid within it (gfid would still be null). So use the stat structure
to get the gfid in lookup callback instead of inode's gfid.
Change-Id: Id70277f0228f3db64b05d613108cfb4f070197e6
BUG: 791087
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3323
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 61ef4549123fcb5f284deb2fae10a9460022bde0
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Apr 27 11:41:14 2012 +0200
NetBSD build fixes
Change-Id: Ib8183d4b585465d05a7adf3a4ceae93ae1bded15
BUG: 764655
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3238
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e4a581a3ca12759549dee402650c229535139cfa
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri May 11 11:23:58 2012 +0530
build: Include COPYING-{LGPLV3,GPLV2} and remove COPYING
Change-Id: Ib7867a79b3831b24b5f26cfee44b87e72f6be09b
BUG: 820551
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/3309
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b0686a8267f3159683f294d7a92dc49bfb00868a
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Tue May 8 07:21:17 2012 -0400
license: dual license under GPLV2 and LGPLV3+
Note that the license was not changed in any of the following:
.../argp-standalone/...
.../booster/...
.../cli/...
.../contrib/...
.../extras/...
.../glusterfsd/...
.../glusterfs-hadoop/...
.../mod_clusterfs/...
.../scheduler/...
.../swift/...
The license was not changed in any of the non-building xlators. The
license was not changed in any of the xlators that seemed — to me — to
be clearly server-side only, e.g. protocol/server
Note too that copyright was changed along with the license; I did
not change the copyright in files where the license did not change.
If you find any errors or ommissions please don't hesitate to let me know.
The complete list of files with the license change is:
libglusterfs/src/byte-order.h
libglusterfs/src/call-stub.c
libglusterfs/src/call-stub.h
libglusterfs/src/checksum.c
libglusterfs/src/checksum.h
libglusterfs/src/circ-buff.c
libglusterfs/src/circ-buff.h
libglusterfs/src/common-utils.c
libglusterfs/src/common-utils.h
libglusterfs/src/compat-errno.c
libglusterfs/src/compat-errno.h
libglusterfs/src/compat.c
libglusterfs/src/compat.h
libglusterfs/src/daemon.c
libglusterfs/src/daemon.h
libglusterfs/src/defaults.c
libglusterfs/src/defaults.h
libglusterfs/src/dict.c
libglusterfs/src/dict.h
libglusterfs/src/event-history.c
libglusterfs/src/event-history.h
libglusterfs/src/event.c
libglusterfs/src/event.h
libglusterfs/src/fd-lk.c
libglusterfs/src/fd-lk.h
libglusterfs/src/fd.c
libglusterfs/src/fd.h
libglusterfs/src/gf-dirent.c
libglusterfs/src/gf-dirent.h
libglusterfs/src/globals.c
libglusterfs/src/globals.h
libglusterfs/src/glusterfs.h
libglusterfs/src/graph-print.c
libglusterfs/src/graph-utils.h
libglusterfs/src/graph.c
libglusterfs/src/hashfn.c
libglusterfs/src/hashfn.h
libglusterfs/src/iatt.h
libglusterfs/src/inode.c
libglusterfs/src/inode.h
libglusterfs/src/iobuf.c
libglusterfs/src/iobuf.h
libglusterfs/src/latency.c
libglusterfs/src/latency.h
libglusterfs/src/list.h
libglusterfs/src/lkowner.h
libglusterfs/src/locking.h
libglusterfs/src/logging.c
libglusterfs/src/logging.h
libglusterfs/src/mem-pool.c
libglusterfs/src/mem-pool.h
libglusterfs/src/mem-types.h
libglusterfs/src/options.c
libglusterfs/src/options.h
libglusterfs/src/rbthash.c
libglusterfs/src/rbthash.h
libglusterfs/src/run.c
libglusterfs/src/run.h
libglusterfs/src/scheduler.c
libglusterfs/src/scheduler.h
libglusterfs/src/stack.c
libglusterfs/src/stack.h
libglusterfs/src/statedump.c
libglusterfs/src/statedump.h
libglusterfs/src/syncop.c
libglusterfs/src/syncop.h
libglusterfs/src/syscall.c
libglusterfs/src/syscall.h
libglusterfs/src/timer.c
libglusterfs/src/timer.h
libglusterfs/src/trie.c
libglusterfs/src/trie.h
libglusterfs/src/xlator.c
libglusterfs/src/xlator.h
libglusterfsclient/src/libglusterfsclient-dentry.c
libglusterfsclient/src/libglusterfsclient-internals.h
libglusterfsclient/src/libglusterfsclient.c
libglusterfsclient/src/libglusterfsclient.h
rpc/rpc-lib/src/auth-glusterfs.c
rpc/rpc-lib/src/auth-null.c
rpc/rpc-lib/src/auth-unix.c
rpc/rpc-lib/src/protocol-common.h
rpc/rpc-lib/src/rpc-clnt.c
rpc/rpc-lib/src/rpc-clnt.h
rpc/rpc-lib/src/rpc-transport.c
rpc/rpc-lib/src/rpc-transport.h
rpc/rpc-lib/src/rpcsvc-auth.c
rpc/rpc-lib/src/rpcsvc-common.h
rpc/rpc-lib/src/rpcsvc.c
rpc/rpc-lib/src/rpcsvc.h
rpc/rpc-lib/src/xdr-common.h
rpc/rpc-lib/src/xdr-rpc.c
rpc/rpc-lib/src/xdr-rpc.h
rpc/rpc-lib/src/xdr-rpcclnt.c
rpc/rpc-lib/src/xdr-rpcclnt.h
rpc/rpc-transport/rdma/src/name.c
rpc/rpc-transport/rdma/src/name.h
rpc/rpc-transport/rdma/src/rdma.c
rpc/rpc-transport/rdma/src/rdma.h
rpc/rpc-transport/socket/src/name.c
rpc/rpc-transport/socket/src/name.h
rpc/rpc-transport/socket/src/socket.c
rpc/rpc-transport/socket/src/socket.h
xlators/cluster/afr/src/afr-common.c
xlators/cluster/afr/src/afr-dir-read.c
xlators/cluster/afr/src/afr-dir-read.h
xlators/cluster/afr/src/afr-dir-write.c
xlators/cluster/afr/src/afr-dir-write.h
xlators/cluster/afr/src/afr-inode-read.c
xlators/cluster/afr/src/afr-inode-read.h
xlators/cluster/afr/src/afr-inode-write.c
xlators/cluster/afr/src/afr-inode-write.h
xlators/cluster/afr/src/afr-lk-common.c
xlators/cluster/afr/src/afr-mem-types.h
xlators/cluster/afr/src/afr-open.c
xlators/cluster/afr/src/afr-self-heal-algorithm.c
xlators/cluster/afr/src/afr-self-heal-algorithm.h
xlators/cluster/afr/src/afr-self-heal-common.c
xlators/cluster/afr/src/afr-self-heal-common.h
xlators/cluster/afr/src/afr-self-heal-data.c
xlators/cluster/afr/src/afr-self-heal-entry.c
xlators/cluster/afr/src/afr-self-heal-metadata.c
xlators/cluster/afr/src/afr-self-heal.h
xlators/cluster/afr/src/afr-self-heald.c
xlators/cluster/afr/src/afr-self-heald.h
xlators/cluster/afr/src/afr-transaction.c
xlators/cluster/afr/src/afr-transaction.h
xlators/cluster/afr/src/afr.c
xlators/cluster/afr/src/afr.h
xlators/cluster/afr/src/pump.c
xlators/cluster/afr/src/pump.h
xlators/cluster/dht/src/dht-common.c
xlators/cluster/dht/src/dht-common.h
xlators/cluster/dht/src/dht-diskusage.c
xlators/cluster/dht/src/dht-hashfn.c
xlators/cluster/dht/src/dht-helper.c
xlators/cluster/dht/src/dht-inode-read.c
xlators/cluster/dht/src/dht-inode-write.c
xlators/cluster/dht/src/dht-layout.c
xlators/cluster/dht/src/dht-linkfile.c
xlators/cluster/dht/src/dht-mem-types.h
xlators/cluster/dht/src/dht-rebalance.c
xlators/cluster/dht/src/dht-rename.c
xlators/cluster/dht/src/dht-selfheal.c
xlators/cluster/dht/src/dht.c
xlators/cluster/dht/src/nufa.c
xlators/cluster/dht/src/switch.c
xlators/cluster/stripe/src/stripe-helpers.c
xlators/cluster/stripe/src/stripe-mem-types.h
xlators/cluster/stripe/src/stripe.c
xlators/cluster/stripe/src/stripe.h
xlators/features/index/src/index-mem-types.h ¹
xlators/features/index/src/index.c ¹
xlators/features/index/src/index.h ¹
xlators/performance/io-cache/src/io-cache.c
xlators/performance/io-cache/src/io-cache.h
xlators/performance/io-cache/src/ioc-inode.c
xlators/performance/io-cache/src/ioc-mem-types.h
xlators/performance/io-cache/src/page.c
xlators/performance/io-threads/src/io-threads.c
xlators/performance/io-threads/src/io-threads.h
xlators/performance/io-threads/src/iot-mem-types.h
xlators/performance/md-cache/src/md-cache-mem-types.h
xlators/performance/md-cache/src/md-cache.c
xlators/performance/quick-read/src/quick-read-mem-types.h
xlators/performance/quick-read/src/quick-read.c
xlators/performance/quick-read/src/quick-read.h
xlators/performance/read-ahead/src/page.c
xlators/performance/read-ahead/src/read-ahead-mem-types.h
xlators/performance/read-ahead/src/read-ahead.c
xlators/performance/read-ahead/src/read-ahead.h
xlators/performance/symlink-cache/src/symlink-cache.c
xlators/performance/write-behind/src/write-behind-mem-types.h
xlators/performance/write-behind/src/write-behind.c
xlators/protocol/auth/addr/src/addr.c ¹
xlators/protocol/auth/login/src/login.c ¹
xlators/protocol/client/src/client-callback.c
xlators/protocol/client/src/client-handshake.c
xlators/protocol/client/src/client-helpers.c
xlators/protocol/client/src/client-lk.c
xlators/protocol/client/src/client-mem-types.h
xlators/protocol/client/src/client.c
xlators/protocol/client/src/client.h
xlators/protocol/client/src/client3_1-fops.c
¹ Copyright only, license reverted to original
Change-Id: If560e826c61b6b26f8b9af7bed6e4bcbaeba31a8
BUG: 820551
Signed-off-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.com/3304
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 306590549c844f3882bdefea6a101053a24c63e8
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Wed May 9 14:06:58 2012 -0400
glusterfs.spec.in, Add BuildRequires: libxml2-devel so that configure will DTRT on Fedora's Koji build system
Change-Id: I14a64d2e562282e4e7d1d37b526c112c9f343454
BUG: 819916
Signed-off-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.com/3305
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Joe Julian <me@joejulian.name>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 98ad30c872e6679b0dd3999854a5c5447dbc9e9b
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu May 10 15:48:22 2012 +0530
locks: Set flock.l_type on successful F_UNLCK to signal last unlock on fd.
NLM expects a successful F_UNLCK on an fd to set flock.l_type to F_UNLCK
if it were the last unlock else F_RDLCK.
Change-Id: Ib304ac6102664abbb13d1fda649b3da63f1ee97e
BUG: 800300
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3306
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit dbee9ea7c7925d47081fbdf70177a6f42e3f474c
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu May 10 22:22:45 2012 +0530
build: Include protocol/server* shared libraries in the glusterfs-server rpm
Change-Id: I46354dd8c0e9c9d81366d3e92af4a24a9d2c568a
BUG: 764702
Reviewed-on: http://review.gluster.com/3308
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit dae7900d6932346e2cfcf571c385a78f720f68c7
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu May 3 16:39:55 2012 +0530
geo-replication: coverity resource leak fixes
Change-Id: I5739e9c9ae6fe78a6defb640d630e5f918ac1295
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 789278
Reviewed-on: http://review.gluster.com/3266
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 362c1adc5c0a26555a6f8359d0878bb541090a5a
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Apr 29 23:08:42 2012 +0530
mgmt/glusterd: Avoid re-starting nfs unconditionally.
NFS server is restarted unconditionally when a volume option is
configured through the set interface. This patch prevents restart
of NFS server when operations are performed on translators that
are not part of the NFS graph.
This does not prevent re-start of a NFS server when an option
corresponding to a translator that is part of the NFS graph is
re-configured.
Change-Id: Ic4b8e48e5e7e80438f230521042c267ec3b96a25
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/3247
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d95baec5555a376933e657f0ab7914d22a94ba40
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Apr 20 18:49:40 2012 +0530
cluster/dht: rmdir should succeed last on the hashed subvol
mkdir and rename both first happen on the hashed subvol.
Rmdir should succeed, only if all non hashed subvol succeed,
and finally removal from hashed_subvol succeeds.
if hashed_subvol is unavailable, then rmdir should be sent
on all subvols
Change-Id: I1bf5d5fc25393d0e2fde13ae403cf867a01f5ec7
BUG: 773187
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3202
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 88502270864f6b6c567d2b2fd0440e080b8bfd89
Author: Kaushal M <kaushal@redhat.com>
Date: Tue May 8 13:57:31 2012 +0530
glusterfsd: Make sure mountpoint is an absolute path
If the mountpoint path given to glusterfs is not an absolute path, convert it to
an absolute path by concatenating it with the curren working directory.
This prevents cases, where in gluster cannot perform clean unmounts when mount
is done with a relative path.
Change-Id: Ie25add4e1dc59171e522c4244c79a6c148844ab3
BUG: 819466
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3302
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a09ddb5c858ea50b674b0d08478204ecd532c753
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Mar 26 18:44:14 2012 +0530
fuse-resolve: consider cases where an entry should be resolved even when parent belongs to active itable.
When parent is root, the parent inode returned will always be
active_subvol->itable->root and hence there can be cases where we
should explicitly resolve the entry in active graph.
Change-Id: I4e82df9a351ff6b5304891abc9932495bf7ea79d
BUG: 804592
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3007
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 59838c992225f40a00caf21bfec0da57610ac78a
Author: Brian Foster <bfoster@redhat.com>
Date: Thu May 3 10:09:27 2012 -0400
quick-read, md-cache: selectively cache xattr data to conserve memory
The md-cache translator can cache items for a long period of time and
thus is sensitive to memory usage associated with the items it
references. This implements two changes to help conserve memory:
- quick-read - Migrate the file content data to a local dict and
delete from the xdata dict that passes through the stack.
- md-cache - Create a local dict to selectively store the xattr
data md-cache is interested in. This includes a slight
optimization to not allocate an empty dict in the case
where we have not received any xattr's of interest.
I've tested both changes independently and together by running a
readdirp test against several compiled source trees (~340k files).
The base test results in a 7.7GB RSS on the client. The quick-read
modification cuts RSS down to 4.1GB, which is still large due
to md-cache unintelligently caching a large number of empty
dictionaries. The combined modification cuts RSS down to 462MB
on the same workload.
NOTE: Theoretically the md-cache change should supercede the
quick-read change, but practically I save an extra 150MB or so with
both. I already had the change and consider it an improvement that
quick-read clean up after itself.
BUG: 812876
Change-Id: Id59734d12dd6476b0e32480939e633448adb6884
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3268
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit ceba7a5b3efc662f31700a82530d0fbc8d2f656b
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 27 18:43:23 2012 +0530
Resolve: Assign correct path while resolving
Change-Id: Ia17ff38a60225dd2e9115aaa298bed42f9e43f56
BUG: 812277
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3248
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ad0515d1de2cc6e0ebd2375f4fb27636578cd949
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 27 16:15:12 2012 +0530
mgmt/gluster: Load index xlator on brick always
Change-Id: I56e4fce83a6bd557a3d0dc115a7dd0cd699328e0
BUG: 816941
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3239
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ee67cb7fbf896fa7d78ab1d878aafe8e31b22f73
Author: Kaushal M <kaushal@redhat.com>
Date: Fri May 4 15:13:03 2012 +0530
protocol/{client,server} : Log improvements
Make use of gfid in log messages.
Change-Id: I28548be64d19418f99ee9ccdbd3ac4ae67c6c015
BUG: 814666
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3274
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7041c5f44850c71b0574fb3ccf442a5e0f9259c9
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat May 5 09:54:22 2012 +0530
glusterd: remove-brick: add more error handling
with this, we can make sure, all wrong patterns in CLI can be
reported with proper message back to user, instead of resulting
in an wrong volume type.
Change-Id: Ib461956dd7d51f7f81c19c27112d44c2adb3a66d
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 803711
Reviewed-on: http://review.gluster.com/3278
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e06d3b4582442aa2d214b911ff9ed93ae81cc8ad
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Apr 18 17:30:39 2012 +0530
Self-heald: Dump the event history completely
Change-Id: Icf08ef1752795276f88c343d1d74af104095c6cb
BUG: 796579
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3276
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 121c3b2f8369aa703fbb0ee21244a8409efd573e
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Apr 25 14:58:31 2012 +0530
cluster/afr: Fix inodelk-trace logs to print lk-owners
Change-Id: Icc983effcf1b6283410a162f260755e97d41ee65
BUG: 810502
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3228
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a040f206e5fc45a1e283d74976c018282e0ef226
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Apr 23 19:58:41 2012 +0530
cluster/afr: Perform Flush with lk-owner given by parent xlator.
Lk-owner of posix-lk and flush should be same, flush can't clear
posix-lks without that lk-owner.
Change-Id: If775abb5741a0beb00c419b54d023fbd429e3cb7
BUG: 810502
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3221
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f7f763a64268961bca33f3de70a0ce9c0ea2a179
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue May 1 10:50:50 2012 +0530
protocol/client: hold lock when cancelling ping_timer in client_ping_cbk.
Change-Id: I2b4e723ef119c62902f8a692a8a1f424da0d08b4
BUG: 816951
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3254
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 2625ed904914586c41d3caa225792266ca477cbc
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Mon Apr 30 16:43:16 2012 +0530
libglusterfs/inode.c: do not link the inode in the dentry cache for "." and ".."
Change-Id: I18c2e090c1ca64f47ce70dc63c9f73ea7def2f86
BUG: 810828
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/3220
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 886be9ff1b50b9c0b61987569699f32804f40e63
Author: shishir gowda <shishirng@gluster.com>
Date: Thu May 3 15:56:15 2012 +0530
glusterd/store: Move remove-brick/rebalance status to node_state.info
Hence forth, all node related info, which does not need chksum or
versioning can be stored in this file. This data might not be in
sync across nodes, as it contains only information related to
local node.
Change-Id: I88a48c1b7bb7b4c29625550a9ff349442bcc5d09
BUG: 812234
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3141
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c05741b433a656f69e15ba65e59bdafde77a6466
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat May 5 16:50:18 2012 +0530
mgmt/glusterd: allow volume start force
Change-Id: If920bf0bf96b61b39bccbb10e66f5f39a55967f5
BUG: 812214
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3279
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9d3fb0785475f8af154727dd02aed9173be13a74
Author: Mohammed Junaid <junaid@redhat.com>
Date: Wed Apr 11 08:55:46 2012 +0530
swift: Gluster object storage plugin for Openstack Swift.
Change-Id: I5e07339064b1f3bb2aa5b04740ed870e114db4f9
BUG: 811430
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/3118
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ea976d0443e96c6193fbcfe260af305ef84f4061
Author: Kaushal M <kaushal@redhat.com>
Date: Fri May 4 12:27:16 2012 +0530
mount.glusterfs: Fix log-level
Change-Id: Ia5ad073ba384e1569970ada8763a8bf9bccbc9c4
BUG: 818835
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3272
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit abce79be9625770cd1f69f0d63ae970e6910863d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 6 15:19:59 2012 +0530
self-heald: loc should have gfid path for better logging
Change-Id: I31e51c8bd68a72ea2216df306a2f5c738c5d155c
BUG: 810144
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3099
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 914a45786ef4f56f1d3162591876fa7db7187f9f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 6 15:43:31 2012 +0530
self-heald: Don't trigger self-heal always.
- If self-heal is disabled, the crawl is always spawned but immediately
terminated upon realizing that the self-heal-daemon is disabled. Fixed it.
- If for some reason finding child position fails, it should still spawn timer
and should keep the timer alive until the position is found to be REMOTE.
Change-Id: I20cc6af93a1ff26f2b837bbf063bbe508b5fdc78
BUG: 810144
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3100
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9476ed416500d7ec7d8b77290a5dd540da1c4b10
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri May 4 12:00:14 2012 +0530
extras/hook-scripts: Fixed EXTRA_DIST to explicitly list *.sh files
Change-Id: I48785317b42e37a6e7768c89bdb7ca8ac41220fa
BUG: 806996
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3271
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b54a264218274e237424866d40ea024db83083bc
Author: shishir gowda <shishirng@gluster.com>
Date: Wed May 2 11:59:35 2012 +0530
stripe: don't send parent pointer in stripe_readdirp_lookup()
Change-Id: I53e28f4046c13ad13c9300990a95480a5c62f180
BUG: 808353
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3232
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3f556f2e8faae2ae4e5b36e4fa6e029232a2bd7b
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Apr 12 17:52:10 2012 +0530
iobuf: option to provide larger size of buffers
provide an option to failover to standard allocation if iobuf of
required size doesn't exists. this can be achieved by keeping an
arena dedicated for all the out of boundary allocations.
Change-Id: I41a2bd7d353dc7bcb2e1a6e4b41735afe9865975
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 812784
Reviewed-on: http://review.gluster.com/3136
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5e7fa8dce9856d7932af27ecc9477c78f11893ef
Author: shishir gowda <shishirng@gluster.com>
Date: Thu May 3 12:45:25 2012 +0530
glusterd/rebalance: Switch off afr self heal in rebalance process.
Self heal if any will be taken care of the self heal daemon.
Change-Id: I4f3c270b6fce250cbdf6f986066f64e7c4b2f29f
BUG: 808977
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3263
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 40774fbd1fb2cd8cb78fe4df3dfae842725e5c19
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed May 2 14:23:27 2012 +0530
cli: fix remove-brick output behavior in failure cases
earlier it was dependant on server sending the dict for knowing
the command. Now it preserves the dictionary in frame->local,
which is used to understand the command.
Change-Id: Ica675b497e466f77878f67792ae96b71f0704d6b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 815745
Reviewed-on: http://review.gluster.com/3235
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 2258f40f64caeea3efbfe220e661fbea4631d065
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed May 2 18:38:52 2012 +0530
glusterd: Added glusterd command specific optional args for hooks scripts.
start volume: --first=yes if the volume is the first to be started
and --first=no otherwise
stop volume: --last=yes if the volume is the last to be stopped
and --last=no otherwise
set volume: -o key=value ... for every key, value supplied in
volume set command
Change-Id: Ia8530771f8b9d7424fd1c736cb4c3622b5cabec2
BUG: 806996
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3260
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6aff173463191fc77113f21d3cce83cbdaf6e391
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed May 2 16:29:49 2012 +0530
cluster/pump: Fixed fd leaks in pump directory traversal logic
Change-Id: Ie54c8c9b19be6824445ada6bbcd4983e90a7c5c4
BUG: 818593
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3267
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6a2e0f472db9201b5898cc98bcf7157149570163
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Apr 26 15:41:10 2012 +0530
RPC: change the AUTH_GLUSTERFS_v2 value to private range
As per RFC5531, the value we were using with AUTH_GLUSTERFS_v2 (6)
is already a standard number for RPCSEC_GSS. Hence having a number
from the free pool for now, till IANA approves a standard number
for GlusterFS RPC itself.
Change-Id: I10ef6f349bccf3cf42fadfa3861c374adae2a808
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 816148
Reviewed-on: http://review.gluster.com/3230
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0b63d368b696ea723a7ca14f9cd6ea4e30ce95c4
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Apr 29 09:32:43 2012 +0530
protocol: fix memory leak of lk-owner buffer in *lk() calls
Change-Id: I7fb0e1757c5e04b1a2609c9822ac79301808f671
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 768330
Reviewed-on: http://review.gluster.com/3244
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bb6e1b7655efe8fb42cde0b7ffdaed8ee665c8ce
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Sat Apr 14 11:58:28 2012 +0530
glusterd: Disallow (re)-using bricks that were part of any volume
Change-Id: I001a67bed1cc3118174a5ddc2f2011e8e48d8ae8
BUG: 812214
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3147
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0093f9a03b160ebb78ef846d65f053707c5fa534
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri May 4 00:29:40 2012 +0530
cluster/afr: Fix race in nonblocking entrylk
Change-Id: I6d96c1aed4bf08b90b6918e3694c688eccdc2445
BUG: 818578
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3270
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 3ca2e9efa96095d8d4ff48183757b2f45c7f1b41
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Apr 30 07:29:16 2012 +0530
libgluster: Fix counting, synctask state errors
When a synctask is executed in synctask_switchto, if by the time
it goes to check the woken/sleep part a reply already comes and
__wake is called, already running task is going to be put in runq
this generates a false warning "re-running already running task".
If the reply does not come before the woken/sleep check, then the
running task is put in waitq which decrements env->runcount even
when the task is not in runq, this leads to -ve runcount everytime
a task goes from runq->switchto->waitq.
This patch fixes both of them by introducing a new state for the
task called SYNCTASK_SUSPEND just when the task is suspended before
yeild in SYNCOP.
Change-Id: Ib82182cf950f9d85b5656f6243541489a104ca3d
BUG: 816551
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3249
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3753b9244239eed0f3d031612a580d8c8977d574
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed May 2 11:38:33 2012 +0530
log cleanup: in setxattr() path
* in posix we log occassionally if errno is ENOTSUP, added a
suggestion to mount with 'user_xattr' option.
* changed server's *etxattr_cbk to log ENOTSUP in debug level.
* changed client's *etxattr_cbk to log ENOTSUP in debug level.
Change-Id: Icd604050aaa68546011f2c950ecd7883ac6ee820
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 811957
Reviewed-on: http://review.gluster.com/3140
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2a623651d84ba86bc70830a2a8d27abfcc6af66a
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Apr 18 18:16:30 2012 +0530
extras: Added hook script to help in CTDB setup
Change-Id: Ib43cd3583e791aabc8cc25fe4eea43a620f73d01
BUG: 806996
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3188
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9e6a692ef240fc8a9aa7024e6ac3a8e16f6ced53
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Apr 26 20:07:32 2012 +0530
glustershd: allow changing of log-level through cli
Change-Id: Ie33ad4f4ffcb025b22801d6beb9b87d8325021a0
BUG: 815903
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3234
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d367dbe0e6b09c0a6df9bb81d45e3df3d5e6337d
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed May 2 10:31:27 2012 +0530
rpcsvc: size check before calloc in rpcsvc_handle_disconnect
Change-Id: Ib9e9e28b4fd3d68ebd4b5dcbd0ee4576217b9d4f
BUG: 782761
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3257
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 349cb2a1116bfe1dca7f8d47080c1ce9d623c0bd
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Apr 27 14:34:07 2012 +0530
mgmt/glusterd: take the statedumps of running bricks if one of the bricks is down
Till now if one of the bricks of the volume is down, then statedump of that
volume (bricks) did not take the statedumps of running bricks.
This patch fixes that issue and cli command will take the statedumps of
running brick processes.
Change-Id: Id9b11905d3d759202e505c2ecfa6ccd5dce6a9ff
BUG: 816884
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3237
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b6175609a2dce545d635bfc87eb8bc6def9543d1
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Apr 29 09:51:06 2012 +0200
get rid of ZR_PATH_MAX
As suggested by Amar Tumballi
Change-Id: Id1cd74fd7530e8c846f3be4a88b1fa301a728cf1
BUG: 764655
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3243
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1ce8435a77b4187f0a88fe8641e8a9f660ea64c2
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Apr 30 16:18:50 2012 +0530
libglusterfs/fd: use reallocated memory for intializing new graphs contexts
While setting fd_ctx, if we have to scale the fd contexts, then we get the
xl_count of the new graph and reallocate the memory for contexts so that
it is suffecient for contexts of xlators of both new as well as old graph, and
then initialize the new graph xlator contexts. For that we are considering the
old pointer itself, instead of using newly reallocated pointer.
Change-Id: I32c18cd69c03c771b4a63e5186c65ae658e54e92
BUG: 817461
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3250
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 29ee8ba8eb90f839f282f6b75bb0df4eff81d9ac
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Mon Apr 30 09:36:38 2012 -0400
contrib/rbtree: additional license from Richard Fontana
BUG: 807724
Change-Id: I1e9a7aac7b535687b9e48bdb0e94c7f52dc6aad7
Signed-off-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.com/3252
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e14ede17398114288f11da43ed8d11a391fea230
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Apr 18 15:45:44 2012 +0530
glusterd: Fail replace-brick subcmds on bricks other src/dst.
Change-Id: I5b55d3e353e70a9d4d8b7948853cbfa5b001a447
BUG: 811956
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3184
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d8ca25121579a765b052172839f4f184c55e9010
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Apr 27 13:20:21 2012 +0530
storage/posix: fix illegal memory access in fgetxattr()
we were not checking for the return value of the fgetxattr(key), and
used to continue with the allocation even if size was -1, leading to
wrong memory access.
Change-Id: Ib5cf2e74fee95bc919b12efe89fed5cd25807efd
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 815346
Reviewed-on: http://review.gluster.com/3236
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 74731a9cea5c1b794472e3f09d54ca79da9c4f76
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Apr 27 16:19:38 2012 +0530
storage/posix: Fix leak of dict in getxattr calls.
get_new_dict does not take a ref. Ref was taken only when any data
was added to the dict.
But in the out tag: we call explicit unref, which would move the ref
count to -1, if it was a unsuccessful call. unref destroys the dict
only if ref == 0.
Change-Id: Ie08c301237c2042daf90a7ef25569e3b06e3e1e9
BUG: 816870
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3240
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 87bba3a5c56ad7e56be252f297438d6d8f666579
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Tue Mar 13 20:49:35 2012 +0530
nfs: use hostname without port numbers
Change-Id: I7c4cba84723a9ca73f1d1f1e9a2c479a2bfd14fe
BUG: 798969
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/2973
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 78b21706ab2e0c6474bd973bde476d1c777a9fa2
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Apr 20 11:41:20 2012 +0530
libglusterfs/fd.c: Dynamically scale fd->_ctx when there are no slots for new keys.
Since while migrating fds to new graph we retain the same fd object,
we might run out of slots for new keys in fd->_ctx after some graph
switches.
Change-Id: I1e3865c76f4703768f9b10b0453558877c2f5448
BUG: 811562
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3201
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7ce3191a067b774431d5fa94df0dcfcd76e0b303
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Mar 27 15:31:50 2012 +0530
features/quota: update inode ctx in reconfigure.
Till this patch, quota was relying on lookups after reconfigure, for
new limits to be effective. However, this might be restrictive for
users who don't want to change directories after resetting quota
limits.
Change-Id: I236aa31fdc7dcbc01d40d38c9b5b7b0a28a4d2ea
BUG: 802905
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3022
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Tested-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 467077dcb8066ca32b34b0f33f3539981e2498ea
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Apr 26 14:28:05 2012 +0530
cli: Make use of cli_err()
Use cli_err() in case of errors instead of cli_out().
Change-Id: Ib0766e59516a1ccd56a2133f33fac3877c4384d6
BUG: 815194
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3229
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 0bc8bd7cac4782604e09a23a179257ccacfe99c1
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Thu Apr 26 17:42:11 2012 +0530
nlm: use correct subvolume when opening the file
Change-Id: Ia0a482c89f10481184dc8f0f5b27cf6612ac114a
BUG: 816476
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/3233
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 65683ab095a33b8a1795debeb57fc8ba55d5ac34
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Apr 26 15:57:42 2012 +0530
glusterfsd: Change a free() to GF_FREE()
Change-Id: I19bad33864b67e7ac79d8c5e642efa19dbc5bd80
BUG: 816163
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3231
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 35817dcfcff7a62d9cfcefe335690abae958f7a9
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Mon Mar 26 11:16:11 2012 -0400
contrib/rbtree license GPL -> LGPL
The latest source of rb.c in the avl-2.0.3 package from GNU/FSF is
now licensed under LGPL, a better license for allowing our partners
to write translators and applications for gluster.
Resubmitting with a BZ. The real question is whether this is okay with
LGPL or whether we should go all the way to a BSD-licensed implementation.
Change-Id: Ifb9c344c84d960832671a2619d37b925e4dede2d
BUG: 807724
Signed-off-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.com/3008
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 76f04365d7a9578b744b5069656135f52b11d09b
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 6 12:49:34 2012 +0530
cluster/afr: Log enhancements
Change-Id: I12918cb0a4e85310d4463bc3e75e7c89565a3218
BUG: 810144
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3098
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1b0864325e1c58d49bab9b97e5cdb7d6c41f3031
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Tue Apr 24 19:39:40 2012 +0530
pump: Removed extra dict_unref in pump_command_reply
afr_local_cleanup is already performing the dict_unref on local->dict.
Change-Id: I07bcb100db0a0b96b3a698c444f43f96065746fb
BUG: 804905
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3223
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit e3a2332bc3ca59dd7e3dae6b4ac17cb5bba51070
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Apr 24 10:39:31 2012 +0530
glusterd/rebalance: Remove state dependency on rpc event
Status is updated by event_notify handshake by the rebalance process.
If there is disconnect, before rebalance process, only then the
state is moved to failure.
Change-Id: I334055397c3d38688dbef653826bc07ac47a1911
BUG: 813167
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3165
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 5fa09a22871654047af657a869d4475469d0757e
Author: shylesh <shmohan@redhat.com>
Date: Wed Apr 25 03:00:28 2012 -0400
cli: Show proper remove-brick usage
Change-Id: I669736b34f50caa146eea47dcd8c081f6436a585
BUG: 816051
Signed-off-by: shylesh <shmohan@redhat.com>
Reviewed-on: http://review.gluster.com/3224
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit c395e83f0481be4c213fac32c28c14e60966a113
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Apr 24 10:27:18 2012 +0530
rebalance: handshake_event_notify to make fsd talk to glusterd
Event_notify can be used by others to communicate with glusterd.
A cbk event is also added for future use.
req has a op, and dict.
rsp has op_ret, op_errno, and dict.
With this, rebalance process can update the status before
exiting.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: If5c0ec00514eb3a109a790b2ea273317611e4562
BUG: 807126
Reviewed-on: http://review.gluster.com/3013
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 189ab00086e61b4a5275843194e424af517dc0ec
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Apr 23 11:11:43 2012 +0530
cli: implement a fn 'cli_err()' to send error messages to 'stderr'
we were using 'cli_out()' to send all the possible msgs, which is not
very friendly with scripts, because if one want to get only valid
output with "<command> 2>/error.log 1>/proper-info.log"
Change-Id: I008ebcbd90935c41dbfc1bd2adeb094ed21116cb
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 815194
Reviewed-on: http://review.gluster.com/3208
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a69691ec7c5ddfe7da8ff0bb85bb912345e54b6c
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Apr 24 10:32:53 2012 +0530
glusterd: glusterd_op_build_payload() fix for geo-rep
Change-Id: I9f625022fa6d70ccda70d197e4124fa73be8e776
BUG: 815603
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3215
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 84373fcd9477f00482aab2d3d66ac2acf1bc2520
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Apr 24 16:36:52 2012 +0530
glusterd: command check failure fixes
due to the patch 29f2de478cc6a475e6ae760d9cbe7ac847e9d79c (coverity
issues fix), geo-replications assumption of anything other than -2
is valid error (ie, expected error), was broken, which resulted in
staging failure of all geo-replication commands. now fixed!!!
Change-Id: I26c3574e966dd8ba89ef423a3ad17aa863a62c13
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 815613
Reviewed-on: http://review.gluster.com/3219
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d5e9091212cb0caf15fbf9456082f2bef9787037
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Apr 24 18:40:00 2012 +0530
mount/fuse: unref the fds after they have been migrated to the new graph
In fuse upon graph changes fds were being migrated to the new graph.
It was done by taking all the fds from the fdtable in a structure and then
migrating each fd in the structure to the new graph. But after the fds
are migrated the structure which had the fds within it (that is refed fds)
was being freed without unrefing the fds, thus leading to a fd leak.
Change-Id: I7b25220a48954384a004373d378cee11c6109f7e
BUG: 811552
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3222
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ec06c76970673b60fb588c64183b5232ef735687
Author: Anand Avati <avati@redhat.com>
Date: Mon Apr 23 00:39:14 2012 -0700
statedump: fix deadlock during state dump of fds
Existing state dump of FD context tries to be extra safe by trying
to call the fd dump callback outside the inode lock. It acheives
this by taking an fd ref and unreffing it later. This exercise can
be harmful at times when the fd unref performed by state dump ends
up being the last unref and triggers fd_destroy. fd_destroy in turn
triggers inode_unref which blocks on inode table lock, while the
inode table lock was already held by the thread before it even
attempted fd ctx dump.
The fix takes away the dangerous ref/unref of the fd during state
dump and instead calls fd_ctx_dump() whiel the inode lock is held.
This is not a problem as long as the dump functions do not call any
inode function which tries to take an inode lock (none of the
existing fd dump ops do)
Change-Id: Ia4b27ba5a321285d3e64896a679a00363bb1e822
BUG: 815242
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3210
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ac02b351ceb75bab193e439c28405e6e273a5060
Author: shylesh <shmohan@redhat.com>
Date: Tue Apr 24 02:32:32 2012 -0400
cli: Return -1 if fix-layout stop is issued
Change-Id: If2e4b842029a1a720403cbec0c076f3dbf1fc6df
BUG: 803971
Signed-off-by: shylesh <shmohan@redhat.com>
Reviewed-on: http://review.gluster.com/3216
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 068c82fe21256dbabda631c79df8a852775e65ad
Author: shylesh <shmohan@redhat.com>
Date: Tue Apr 24 02:49:52 2012 -0400
dht: Log message fix gfid's to gfids
Change-Id: I9ad67b6ded05992d1b56ca843f685c4fe2b15b71
BUG: 815186
Signed-off-by: shylesh <shmohan@redhat.com>
Reviewed-on: http://review.gluster.com/3217
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 6d704d3c80595d5a23c7edc599a025ea92dc4058
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Mar 27 15:05:15 2012 +0530
libglusterfs/inode.c: add inode_resolve
inode_resolve takes an itable and path as arguments and returns either
NULL or the inode corresponding to the path
Change-Id: Id42d62cce6b04dbfec7d606120b09a1e54ab484e
BUG: 802905
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3021
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit abd5fe2222498dc2b8f1a9bef12ccffae1f17acd
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Mar 30 15:58:43 2012 +0200
NetBSD build fixes Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Change-Id: I8f9aabeadd2f842521a82e59594115bd80155d68
BUG: 2923
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.com/3053
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7a44e8e8aa1ac4e19f9045f04fdb9645297aea47
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Apr 18 16:51:35 2012 +0200
geo-rep / glusterd: update list of reserved tunables
(keeping up with http://review.gluster.com/399)
Change-Id: Iefc095a65efaa722a980315603f9ad027ee16eba
BUG: 764557
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3189
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit afc771afd647f94891e46fd41f65e7a9b345c671
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Apr 19 14:10:44 2012 +0530
glusterd,glusterfsd : Perform proper cleanup of connections and socket files
Perform proper disconnections and cleanup in glusterd on stopping nfs-server and
self-heal daemon processes to prevent glusterd from opening unneded unix domain
socket connections.
glusterfsd processes will cleanup the socket files properly in
cleanup_and_exit() to prevent junk socket files.
Also, fix rpcsvc_program_unregister() to preform the unregistering properly.
Change-Id: I1c7302c1166cf43feba1c7a813c3dc10169dc53a
BUG: 810089
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3168
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 85b3d78c69f05f32bd87a378f38eb4fa18ec2425
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Apr 21 16:20:17 2012 +0530
glusterfsd: print entire path of functions whenever serializing a reply fails
Change-Id: I72c0296e16c90ec09ecb1678b4c78e8ffd834580
BUG: 814926
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3205
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 631bb245b0e614b758ea7f0489a124fa7c7a68fc
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Apr 23 10:55:22 2012 +0530
cli: fix the output of 'gluster volume list'
make it script friendly
Change-Id: I5b196cf5cf1744090a1360eef95c9a842d7be996
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 815190
Reviewed-on: http://review.gluster.com/3207
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f8f4013a52a1cd86ccda6dca84605d76eadf7911
Author: Csaba Henk <csaba@redhat.com>
Date: Mon Apr 16 17:53:06 2012 +0200
gerrit / rfc.sh: further trim of fetch target
We _really_ don't need anything to be fetched from anywhere except for origin.
We can do away with all other tracked repos (which still can be a nuisance
eg. if they are in a VPN that we are not happen to be joined to).
Change-Id: I98b375698f999500153e5a000dc8dac5005dfaec
BUG: 764966
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3162
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1dbad81eaa82ab8ac7640626565ed8ea58f02857
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Apr 13 17:29:41 2012 +0530
core: coverity issues fixed
this is not a complete set of issues getting fixed. Will
address other issues in another patch.
Change-Id: Ib01c7b11b205078cc4d0b3f11610751e32d14b69
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 789278
Reviewed-on: http://review.gluster.com/3145
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 53bb6b678850bfcebaa9ebaa2035e5e5b0c47ab1
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Apr 23 12:51:50 2012 +0530
doc: Added admin guide
Change-Id: Ic60558dee0d20df0c2a1bf41e4bd072ae4774912
BUG: 811311
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/3209
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: divya M N <divyasetty@gmail.com>
Reviewed-by: divya M N <divyasetty@gmail.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0346ef36dd2e91cb852f6d2378b2903235cfd7c7
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Apr 17 00:19:54 2012 +0200
clean up handling of special client pids
- no need to name a lower boundary [drop GF_CLIENT_PID_MIN]
- drop utility function to decide about pid speciality [gf_pid_client_check()];
when we implement uniform policy for special pids, use just comparison with
GF_CLIENT_PID_MAX (currently such uniform policy exists in io-threads, where
special clients get lowest priority)
- io-threads: drop numeric literal, use GF_CLIENT_PID_MAX
- xattr flipping (in fuse):
- fuse_xattr_alloc_default() made static
- avoid compiler warnings wrt. partial enum traversal in the switch
by not casting the original numeric value to gf_client_pid_t (enum) type
- trim down the switch to those cases with which there is something to do
[GF_CLIENT_PID_GSYNCD, GF_CLIENT_PID_HADOOP]
- eliminate the (theoretical) chance of succesfully returning
from fuse_flip_xattr_ns() with unallocated nkey
[as was the case with pids GF_CLIENT_PID_{MIN,MAX,DEFRAG}]
Change-Id: Ic2b83b908d8e3be23a7fba1e5895869828a6194b
BUG: 765433
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3170
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cb20450521f7623356838e590de93a93f2598e14
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Apr 19 16:53:19 2012 -0400
Make option code quieter to make logs more readable.
A lot of this stuff is extremely uninformative, such as messages about
default values that can be read from the code. Having them in the logs
makes more important messages harder to find, so they're down to
GF_DEBUG_TRACE now.
Change-Id: I18921b3deac7a01ad94c50670b90342d1130837b
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3198
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 769c5a8c92cc4a95189fded415b7322ef09b6b37
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Apr 23 11:51:22 2012 -0400
fuse: allow requests during mount (needed for SELinux labels)
Change-Id: Ia1af402897e6a7290acf79617c34fdc804751729
BUG: 811217
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3199
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0e3438fae05358896a5eb2ab44195b6fc365b47e
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Apr 23 10:49:02 2012 +0530
libglusterfs: Never block syncproc
Change-Id: I64cd8a2ef37926173c19a33df0716183530e22bf
BUG: 814074
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3194
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit eb5fe40f2c9a65849fd234b274a5cb500114a70b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Apr 2 16:32:18 2012 +0530
cluster/distribute: handle dht_layout_normalize errors differently in dht_lookup_dir_cbk and dht_discover_complete.
return value from dht_layout_normalize is interpreted as follows:
ret > 0 - number of subvolumes returned ENOENT errors.
ret = 0 - no anomalies found.
ret < 0 - there are holes/overlaps.
We need to handle errors differently in dht_discover_cbk because,
if a subvolume is newly added, the directory will not be present on it
and we cannot create a directory there since a nameless lookup has
resulted execution in this code-path. Hence if directory is guaranteed
to be present in atleast one subvolume and there are no holes/overlaps
in the layout, lookup can be treated as successful.
there is no change in behaviour dht_lookup_dir_cbk caused by this
patch.
Change-Id: I9b0b510f1c7de187be95a47da6c9ec57b5e38d1d
BUG: 802233
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3069
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 85da3fcf76d743cb8c305f02896dba311daf5d89
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Apr 23 13:22:42 2012 +0530
glusterfs.spec: Added hook-scripts in server rpm
Change-Id: Idd0ed2a72ea9ec947eaf142b889730e8d4be63c1
BUG: 806996
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3211
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bdbedf8402b864ca9fff0aa916477f56f74c3c75
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Sat Apr 21 17:42:10 2012 +0530
nfs/nlm: remove /var/run/rpc.statd.pid before starting rpc.statd.
Sometimes rpc.statd fails to start if rpc.statd.pid exists.
Change-Id: Ic6feb375330fceb8dd6c35330757738fb5cbe16f
BUG: 814265
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/3206
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Saurabh Jain <saurabh@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit afec565c5443eed893f195dd09d02b78148e0bcf
Author: Anand Avati <avati@redhat.com>
Date: Sun Apr 15 22:14:38 2012 -0700
storage/posix: prefer absolute path handles over GFID handles
Change-Id: I9afefa2f8a39c5f2c77271ea64aff95249c88821
BUG: 791187
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3204
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 5c572ca2024b479ab40f489ef2743f8ea433de66
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Apr 19 13:17:49 2012 +0530
cli: Strip whitespace from "volume set" option values
Strips the whitespace from options values before sending to glusterd.
This prevents options containing whitespace to be written to the volfiles which
would cause the volfile parser to fail.
Change-Id: I46faee7b0853141fa102d06bb067c7ab499a2f6e
BUG: 813937
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3192
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9f33d3b0dad26171bf33a3aa472be214d82f7cf4
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Apr 18 16:17:51 2012 +0530
mgmt/glusterd: Make priority threads configurable
Change-Id: I7aa4c80fac3269052adb1b5516e9dd774d5f9e0a
BUG: 812515
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3187
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 122c9c69a8d0164b8bd18fcad0ed1ace8457104a
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Apr 18 14:33:01 2012 +0530
performance/io-threads: Change the thread scaling logic.
Change-Id: Idc0db1cb2c26dcb0b36a58d4d43f2da10cde62c5
BUG: 812515
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3186
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6f1fec1d8a2f01fc7b8e0f59af47ede868ac3010
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Apr 20 11:20:41 2012 +0530
storage/posix: Don't allow mkdir() on HIDDEN_DIRECTORY
Change-Id: Iecbd71d13ee8a492a99689674be99b4a451593db
BUG: 788150
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3200
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 230888daeda39b41c2899067d2ad6908e4b029c8
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Thu Apr 5 18:42:25 2012 +0530
nlm: register client name with statd for blocking, nonblocking and reclaim lock calls
Change-Id: If983f7b2f94703442e0745c5cbd2701edb2a972a
BUG: 809362
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/3097
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d96f25217d9e5075447d857d34a70633c0cdc129
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Apr 19 13:18:33 2012 +0530
stripe: make sure we have complete set of subvolumes before making fop
Change-Id: Ifc3b05183945a7ce3e25f8c777daaf3fd4aecff3
BUG: 810450
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3190
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 593dc5ade3dfcbc9a8d74f440567930fe2f30aa6
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Apr 19 17:59:21 2012 +0530
glusterd: Enable hooks for volume set.
Change-Id: I0cfa83feea719fb98c37418ad7b8dbe613ce7641
BUG: 806996
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3193
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a8e96232f893e5f008b85849351926b1a10d848f
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Apr 19 23:51:15 2012 +0530
rpc-transport/socket: Set NODELAY for connect socket
This is essentially a re-introduction of setting TCP_NODELAY
on the connect socket which was erroneously removed as part
of commit 2da18b6
Change-Id: Icc3a8faafce0e63a9dde592a48f22b90a72860d1
BUG: 795635
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/3197
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit 7b41518125f343687f2c8b9bbf47f024954b47a0
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri Apr 13 14:28:05 2012 +0530
glusterd: Moved 'hooks' interface code to glusterd-hooks.*
Change-Id: Ia7c0e37154414bddb05516e11b3cc4e6ae83ff38
BUG: 806996
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3142
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7829d16abe6f7e029a8e16a13db14145709f614c
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Apr 19 12:18:53 2012 +0530
rpc-clnt: use the correct xdr_size for getting the iobuf
earlier we used to get the size of rpc_msg from an empty msg, which
was resulting in minimum size allocated for rpc-msg. the correct way
is to fill the required fields in rpc_msg structure and then calculate
the size, and allocate the iobuf.
Change-Id: I3692831b53b8820a36e4562a1fa3d4c3dbdf4f9d
BUG: 813787
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/3191
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 4a4b054bb3eaca27476b87c65cadf9ae91d43994
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Apr 18 14:48:35 2012 +0530
cluster/afr: Set errno correctly in find_fresh_parents failures
Change-Id: I923103a03c1efe38285cd70842ec91b98a3f6bfd
BUG: 765551
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3185
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7c815ff82a6ef50fb197c3448729ba9bd0a47c83
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 17 15:45:44 2012 +0530
cluster/afr: Handle transient parent-entry xactions in lookup
This patch addresses the case when the lookup on an entry is performed
while it is being renamed. The lookup can possibly return 2 different
gfids when lookup on one subvol reached before rename and on other
after rename. In such cases the conflicting entry self-heal is
triggered to resolve the issue, but if there are lot entry transactions
going on the parent directory of the entry then the non-blocking
locks could fail resulting in EIO. To avoid this, lookup queries
locks xlator if there are any parent-entrylk on entry's basename.
If afr finds that there are such locks and gfids are differing then
it chooses the file with latest ctime as the iatt of the entry.
This solution is not foolproof, but it decreases the probability of
hitting the EIO. The correct solution is to take blocking locks on
the parent-entry to find out the correct source. Taking blocking
locks in lookup is not good. One stale entry lock can hang the whole
filesystem. So we chose to go with this for now.
Change-Id: Ibebb6c3074f56f80a96893b6bf5b77941e30d400
BUG: 765551
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3179
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 170395fe0429971cdfe8856c5555ab0ce37eeaa1
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Apr 4 23:37:58 2012 +0530
extras: Added (hook) scripts to start/stop samba on volume start and stop
These are example/helper scripts that demonstrate how one could
leverage the recently added hooks interface in glusterd.
The scripts are in 'beta'.
Change-Id: I7aaf999f3bdfb276ef64e115a57cbdb36c7a896e
BUG: 806996
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3086
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f548809b37950fc3c637e4d85c4f0c81c594359a
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Apr 16 14:50:16 2012 +0530
cli: do not put the frame->local to mempool since its a calloced structure
In cli, frame->local is not allocated from the internal mempool, rather its
calloced. So while destroying the stack, we have to set frame->local to NULL.
Otherwise if frame->local is not NULL, STACK_DESTROY will try to put it back
to the mempool and thus segfault.
Change-Id: I5bd17d099e16fb8e73f3250cc022008e26e28f50
BUG: 812735
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3167
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 5d288734acbe7eedd2bb7458271124f4ee7cda8a
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Apr 18 10:49:09 2012 +0530
cluster/dht: Remove un-used pathinfo code for link files
Currently, we do not return LINK: attributes for a file
in pathinfo requests.
Change-Id: If8667bd6af06de3d11c37dd0a09726dfe1d2e330
BUG: 795289
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3175
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit abaab9fab69c344458de9925c6120606e7698564
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Tue Apr 17 23:58:08 2012 +0530
nfs/nlm: disable NLM if rpc.statd is not found.
Change-Id: I571e1f14cefdfabecd8996b6d0ffc928464d2b51
BUG: 813258
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/3174
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ebffd004943ee83bdab62886937fe8a13726e542
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Apr 16 12:07:15 2012 +0530
glusterd: Properly validate compressed form of IPv6 addresses
Properly validate IPv6 compressed notation, when used in volume set.
Change-Id: Ia489125a45472fc0971c6b11de073aaeb9b1a123
BUG: 810442
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3152
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f2c4559e61dd7ea80efbc4a46b494356ca0999cd
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Apr 18 11:44:21 2012 +0530
cluster/afr: Build parent loc for expunge
Change-Id: Ifd1a4117924a7f9a90eb8e02dd2d655f2156fabd
BUG: 765551
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3178
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 12960c6fdac844b44e8b048d90b700365de382c9
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 17 13:20:43 2012 +0530
features/locks: Find parent-entrylk presence in lookup
Change-Id: I8fc85676827f26b07bf578ea1152d3e251adb4af
BUG: 765551
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3177
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0a18381174c362cd49540728f9a24b1bf9952a6b
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Apr 18 12:16:51 2012 +0530
glusterd/rebalance: Start process with xlator option client-pid -3
This would prevent updation of xtime by the marker.
Set frame->root->pid while creating sync-task. Removing the command
option, as it is in-effective
Change-Id: Ifaa587df67a72ec0571c7d0043de8048e2be12a8
BUG: 812287
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3180
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c5791a4bf39dbeab09d2a0c0116b859795f9ead9
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Apr 17 23:30:23 2012 +0530
glusterd (remove-brick): fix data-loss issue
* when more than one brick (more than one distribute subvolume)
was removed using single command, rebalance process used to
get started only on one node, causing data-loss when 'commit'
was done, because the brick's data was not migrated at all.
Fixed the logic of validating rebalance required in remove-
brick case.
Change-Id: I3a90ff9f9593e5215110a3a0974bb97e7271f910
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 812770
Reviewed-on: http://review.gluster.com/3173
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit c34abe7d59e68dff62e8218c61c4f4834a7a3bcf
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Apr 16 11:38:33 2012 +0530
performance/quick-read: disable reading from cache if unlink has happened after fd was opened.
If dentry being unlinked is the last one, there is a possibility that
later, a new entry with same name being created. After creation of new
file, we shouldn't be returning the contents of this new file, when
application reads using fd opened before unlink.
Change-Id: Ic98aa9cd76d24e8a37ce02a0aae6c66290043192
BUG: 811976
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3151
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b69dafea7294d9ce8c37e224004d9fc79be85a19
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Thu Apr 5 15:57:47 2012 +0530
nlm: send sm-notify to clients whenever the nfs server is restarted so that clients reclaim the locks.
Change-Id: I0a8e291ad0a78e2e68070b1d289d32a786da8da2
BUG: 802885
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/3096
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 4a5b32c8e3925c74e74580fc0e2931de7305df1f
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Apr 16 12:05:45 2012 +0530
nfs: option to disable NLM
Adding support to disable/enable nlm with the following command:
# gluster volume set <VOLNAME> nfs.nlm [on|off]
Change-Id: I1ad3e44c5d4349d0f3463bfca0995fd10def39dd
BUG: 812869
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3160
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
commit a48da7e4a160ddfb44b4e417bfefbda7f2d1062b
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Apr 16 14:39:10 2012 +0530
cluster/dht: Handle failures in getxattr_cbk
Change-Id: Ifbce2d69f0fdd0c45cba92b6fc2dffe13c60de28
BUG: 810106
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3156
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 298858e460338d901041d63df085a3a443b2f965
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Apr 16 19:31:44 2012 +0530
glusterd : Fixes for breakages caused by volume-id validation
Fixes glusterd_op_build_payload() to,
1. take account of status cmd type when building payload for "volume status" to
prevent "volume status all" from failing.
2. take account of volname being "help/help-xml" in volume set to prevent
"volume set help/help-xml" from failing
3. obtain volname using key "master" prevent "volume geo-replication" commands
from failing
Also, fails op and sets correct op_errstr if volume not found during
glusterd_dict_set_volid(), to make sure cli displays proper message.
Change-Id: I40ded15c50b54a82ee61bf6d6e9d07f571679c8c
BUG: 812801
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3157
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit c2715c90992bf3987bdbc6fce2f5f3bad99fd287
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Apr 11 17:04:15 2012 +0530
cli: Fix for "volume status all"
Fixes output of "volume status all" when some volumes are stopped and some
changes to xml output.
Change-Id: I77938422c0258bb69e32b54c23df1225474532bc
BUG: 811539
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3130
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2332cee41b70d1d023b247f88c235d39c623f694
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Apr 17 15:37:38 2012 +0530
nlm: unregister nlm v1 when gNfs is stopped
NLM v1, registered to communicate with statd
is unregistered once gNfs is stopped.
Change-Id: I165658488f4971e743736f5f77c7247590e64bd5
BUG: 786345
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3166
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
commit 0b33f8ef4a2b73cbe8b61226e6bb3873b2a848a1
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Apr 17 11:23:46 2012 +0530
protocol/server: Check if dict arg is NULL in setxattr
Change-Id: I44d199ffa5d08115cc0aa7cb0b99298a9907af60
BUG: 808067
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3164
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit e5ee018c41cdad4c565b3cc74af09f66341eaad3
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Apr 16 13:26:40 2012 +0530
features/marker: fix possible NULL access in strcmp()
for a given setxattr call, loc->path can be NULL now, handle
that case properly
Change-Id: Ic56ec81aa8eb62aafdb524bf22f6d84390ab1d4b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 812767
Reviewed-on: http://review.gluster.com/3154
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2b9848701f961d2e822846848c22a6dfc83b67c5
Author: Mohammed Junaid <junaid@redhat.com>
Date: Mon Apr 16 12:57:57 2012 +0530
protocol/client,server: Lock self healing off by default.
Also, merged the options client.grace-timeout and server.grace-timeout
into one option "features.grace-timeout".
Change-Id: Icb9f0809f89379de673f8c9f7ca4725bc113797f
BUG: 812760
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/3153
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit eb20d631c36191ca8bebe2c0d5e8ea55dbd4f111
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Apr 13 15:22:57 2012 +0530
glusterd/rebalance: Start process with xlator option client-pid -3
This would prevent updation of xtime by the marker.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: I11e287511026326271c2926e55993e48b32018f6
BUG: 812287
Reviewed-on: http://review.gluster.com/3144
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ec8d764a5c7e2a3b26f426657acead1306b30b01
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Apr 14 18:02:05 2012 +0530
cluster/afr: increment change log with correct byte order
Change-Id: Id2af3e61ad659ff6d168161673e5e1e19f36bdb5
BUG: 765194
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3149
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c6f09c9be12b933669e6627ce78e80f93bce0cba
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Apr 16 13:31:59 2012 +0530
cluster/dht: Revert to calling ftruncate
Additionally, change lookup failure error to DEBUG level.
Change-Id: I6eaf8e92a9cd34eba125a1e0e183bc3b6dc71945
BUG: 812769
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3155
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 965f1bbb28fc7ebeb2b3cd2d8de304ba3cdb8950
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Fri Apr 13 14:19:11 2012 +0530
nfs/server: hard resolve fh on restart
the filehandle passed to hard resolving code was not initialized
to it correct value (resovlefh).
Change-Id: I0a26c7b90bf3efec7fda26fed0823755c4b9e87b
BUG: 802779
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3150
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 32cc65d24b8390228e5d19f3aa9071a0b4f60b3c
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 13 18:37:55 2012 +0530
libglusterfs: Syncop procs should not exceed SYNCENV_PROC_MAX
Change-Id: I0eb2adac06eae31939c8ed6b544b4be43d1a5885
BUG: 810109
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3146
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d5c8f46e5e912ff27ccd9c3913afca6e0a9dbc7d
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Apr 12 17:32:00 2012 -0400
Fix dangling references to examples.
Change-Id: Ic90f332fb6554173a03f7a026fc3677e7cf42eae
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3139
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 02831ef57696b778cee87079641f6962d765c9a8
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Apr 11 13:40:28 2012 +0530
glusterd: IPv4 auth improvment
Check if last character of an IPv4 address is valid to prevent successful
validation of addresses with '.' as last character.
Change-Id: I0af6c288e12a47986ce3f8b02c317b99767e69e6
BUG: 811458
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3124
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2d5d1f915876f4db7252d812bacae0e8f80ca801
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Apr 12 12:39:48 2012 +0530
server: Modified logging information to ease log based analysis
Change-Id: I1bde6505346b5dda37cf88c66f9af8ff48668ed9
BUG: 811864
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3133
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 82c39641e454a19052af642619f6108a5ca376a5
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Apr 9 12:17:16 2012 +0530
xlator/server,xlator/nfs : Fix authentication for address lists
Fixes authentication problems when address lists are given for
auth.{allow,reject} and nfs.rpc-auth-{allow,reject}.
Change-Id: I9959ebfa6820aef52c883372e1085660560e1e73
BUG: 810179
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3104
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8b4fc855fcb83c7a9df16e5d4607181a2ce80ae9
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Apr 12 15:32:05 2012 +0530
dht/rebalance: Display migration failure count
Change-Id: Ib2f8be2c98eae1b4df5d2090c1f1eec8ab264a35
BUG: 811923
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3135
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8048733f5e7e317c3b95e9a5a9e198d6120175a3
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Apr 11 15:30:22 2012 +0530
glusterd/remove-brick: Replace ABORT with STOP
Remove-brick stop now invokes rebalance stop. This leads
to a graceful stop of decommissioning.
The volfile is also updated (removal of decommission)
Change-Id: I5a8f725c0f54439b810ce32d988c21c02229c703
BUG: 811513
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3126
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 31930a49e382167346f6339fd0204aa2f42031e8
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Apr 11 11:47:17 2012 +0530
dht/rebalance: Handle ASSERT_ON_CHILD_DOWN gracefully
In rebalance process, instead of terminating, send a stop
event. The migration in question will either complete or
be handled as error.
Also, handle few syncop calls as errors, instead of just
logging them.
Change-Id: If6ed54474cb0f1fe0e28a5765e6d90966740dfde
BUG: 811444
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3120
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2a2b454545cd1edecda1f6b3c9320f280d8c00d0
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Apr 11 12:11:06 2012 +0530
glusterd/remove-brick: Remove support for pause option
Decommissioning through rebalance has no pause option.
Change-Id: I90f165cdb2eccfaefc99365ae4b48d81320fb753
BUG: 811459
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3123
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 3970d87d2c0939531307fae365d23a7e94f8be29
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Apr 10 15:34:02 2012 +0200
geo-rep / gsyncd: log sync failures as warnings
Syncing of certain files can fail naturally if changes happen on
master (eg. file gets deleted). Therefore logging an error is
misleading.
Change-Id: I7b54904e5ec7c85e4e0fa1e330123d2c44c78ac5
BUG: 764510
Reported-by: Vijaykumar Koppad <vkoppad@redhat.com>
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3113
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijaykumar <vkoppad@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit fe7b48257075fe052d44f17a41a5a3cb543443a1
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Apr 9 17:20:10 2012 +0530
glusterd/rebalance: re-establish conn between rebalance process
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: Ib13b4b9beebf18632027e4dd7c68f627c311781c
BUG: 810688
Reviewed-on: http://review.gluster.com/3110
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9dd0a5f01a9a89f1503787fb1c396c5dadf0aefc
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Sun Apr 1 14:50:08 2012 +0530
mount.glusterfs: multiple fixes
* noticed that the regex to parse the options were not fool proof.
for example, 'ro' in a logfilename could have made the mount
point read-only. Now fixed.
* this issue existed for 'acl', 'worm' options.
* log-server/log-server-port options were legacy, and no more
needed in codebase.
* refactored option processing in general to avoid above issues
Change-Id: I172d24c86ece9a34420ba997fa385e304b4924ae
BUG: 806978
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3058
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e4e0dc880d41c8f078fb6d7f19d4efb90e489704
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Tue Apr 3 15:37:25 2012 +0530
glusterd: Added volume-id to 'op' dictionary
Volume-id passed in op dictionary would help detect possible split brains
among peers in a cluster. The idea is to check if the volume's id and
the vol-id that was passed are equal.
ie, same volume name, but different volume id indicate that glusterd
'metadata' of one of the participating peers is stale or there is
a split brain.
This is over and above the existing checksum based validation of peer
supplied cluster 'metadata' (ie, volume info file).
Change-Id: I1049ef249e417e540ccb4243e450f92fcd0f46f9
BUG: 797734
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3083
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 48f094a8f2837da7da427b9def1d67910277d4ec
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Apr 9 18:21:43 2012 +0530
glusterd: Removed 'unprotected' concurrent access of priv->volumes on glusterd restart
This must have been removed as part of
afe542eca18888463798747d2a95e5a9d239a4a0 (reverting to non-synctask behaviour).
Change-Id: Ic23c8bbf8f90f4c9af6e68349de63e22d7f25606
BUG: 810829
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3109
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 911cac7dc3e0322e0e4c8e33041ae46d587463f3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Apr 8 11:40:48 2012 +0530
features/quota: don't adjust statfs buffer if size used is already greater than available limit.
members f_bfree and f_bavail of struct statfs are unsigned types.
A negative value assigned to them is interpreted as some positive
number and resulting in incorrect output of df output.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: I4d3d38b9bb6f675958ee38ad4d6c71ebcf4bb9a1
BUG: 773530
Reviewed-on: http://review.gluster.com/3102
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9702c62039e810b1147c7d72038fbe544cf05d9b
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Apr 9 16:29:45 2012 +0530
glusterd/rebalance: Provide option start rebalance with valgrind
Change-Id: Ia7a836425f5dbfe07b2e46563e49aaeaaaaa4e14
BUG: 810836
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3108
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 7e47019e735195df5c856c5efe070cb64dfd6928
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Apr 11 16:14:31 2012 +0530
cluster/afr: Perform gfid-less lookup in afr
Change-Id: I78d9f0563e25047f392675ae32db38d2c94f6651
BUG: 795355
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3129
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9442e6be6d8159ac250b4ed44e989bbcfd94d571
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Apr 11 16:14:16 2012 +0530
storage/posix: Handle gfid-less lookup
Change-Id: I4605dbb1dd8bf8e26de7f253e54a7f4840c8a8be
BUG: 795355
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3128
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 05d8f65bfd1f969444e44279cbb3cdd973137c6f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Apr 12 22:03:49 2012 +0530
libglusterfs: loc_copy should set name only if src->name is set
Change-Id: If06d97dd1ff1293730e0cd4933f6ab3283f0475e
BUG: 788051
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3137
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 23b0640748ef5453d285fa51fe1bcb252580d7ea
Author: Brian Foster <bfoster@redhat.com>
Date: Thu Apr 12 15:46:37 2012 -0400
md-cache: fix dict memory leak in mdc_inode_xatt_update
We currently either dict_ref() or dict_copy() into mdc->xattr.
The double dict_ref() call path is obvious. Alternatively,
dict_copy() does not ref the dict in the situation where it
creates a new dict, but we only call dict_copy() in this
context when we already have a dict, which should mean the
extra ref is unnecessary.
BUG: 801582
Change-Id: I72e3f1a16f942f04752c033812d13d50ee7c2c2c
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3138
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6494da7e89edd0af70fbf0410a6093e1b5f6ea9b
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Thu Apr 5 10:29:18 2012 -0400
contrib/md5: prune contrib/md5/* from tree
Previous change set did not delete contrib/md5 from the tree.
BUG: 807718
Change-Id: I74eee1897fac24b83b379f2433de5e4648eb5f4c
Signed-off-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.com/3095
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d0503785ce082b9460a6d5c6ab1853bf9aa1206e
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Apr 11 23:55:58 2012 +0530
glusterfsd: mem-pool count of dict_t is adjusted
increased dict_t pool count based on test results.
Change-Id: Ia5b24940b79a1489b00cca2993241c32be94bbec
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 809034
Reviewed-on: http://review.gluster.com/3131
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 014c938e5829c6414913eebca58da7732f63f1fe
Author: Anush Shetty <ashetty@redhat.com>
Date: Wed Apr 11 11:49:46 2012 +0530
Error-gen: declare the structure for cbks
Change-Id: Iaa2e367ad225a2b24dd56c3941163f90be74e6ee
BUG: 811445
Signed-off-by: Anush Shetty <ashetty@redhat.com>
Reviewed-on: http://review.gluster.com/3121
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 58801d15bb1621b4a9587356b99bbb9a2e41507d
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Apr 9 23:11:52 2012 +0530
doc: Move outdated documentation to legacy
Change-Id: I0ceba9a993e8b1cdef4ff6a784bfd69c08107d88
BUG: 811311
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/3116
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e7920db077292703ba36850337558ec42edca442
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Apr 11 16:07:43 2012 +0530
dht/rebalance: Correct log messages
Change-Id: Ica73707922c1bf1a0975a8057d39c1441b987b0a
BUG: 808376
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3127
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 986daf70cb2b4b6aec43dfc9d36b58b28fd07c1a
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Apr 11 11:51:31 2012 +0530
protocol/client: in link_cbk() try to print valid information in case of error
currently there is a chance we don't have a source 'loc_t' path information
instead we would have gfid. Need to print destination information too.
Change-Id: I7a5edbdc9abe18fdb330fc7ed49c9946cf7fe382
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 810146
Reviewed-on: http://review.gluster.com/3122
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit bfdce65de5b9c698a6e1dd305a757fa5a9016d70
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Apr 11 14:40:44 2012 +0530
protocol/server: validate connection object before dereferencing
in 'release()' and 'releasedir()' fops the check for 'connection object'
was not done before dereferencing it. the check was in place for all
other fops. handling the missing cases now.
also removed some warnings related to 'set-but-unused'
Change-Id: I47b95318e8f2f28233179be509ce090b2fb7276d
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 801411
Reviewed-on: http://review.gluster.com/3125
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1b029207770624122177a89f7d3e3f13cfd0c060
Author: Anand Avati <avati@redhat.com>
Date: Fri Apr 6 11:17:34 2012 -0700
fuse-bridge: generate GFID as gfid-req in fresh lookup
This is necessary for self-heal to assign fresh GFID when
performing lookup on files/dirs without GFID (migration from
old version, etc.)
Change-Id: I6f070255dc6e85bf6625b704cb5fb7f831ee58e6
BUG: 795355
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.com/3101
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit f2ec74fc6b546425c07cdd0c54b376880f2b7ea3
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Apr 10 17:12:05 2012 -0400
Fix compiler warnings and typos from Debian build.
Mostly to do with "-Werror=format-security" being buggy, but while we're
here we might as well fix some typos and such. Credit goes to Patrick
Matthäi <pmatthaei@debian.org> for pointing these out.
Change-Id: Ia32d1111d7c10b1f213df85d86b17a1326248ffd
BUG: 811387
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3117
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d4ce78cc2d6dcb7a8d64e801be72cafeda572338
Author: Mohammed Junaid <junaid@redhat.com>
Date: Mon Apr 9 12:14:59 2012 +0530
storage/posix: Avoid excessive logging in posix.
When quota or gsyncd is enabled, the marker translator performs setxattr on
files/directories. If the file/directory is deleted before setxattr, posix gets
an error when it does setxattr and logs it. But its not an error for marker and
it handles the case gracefully. Hence, avoid logging for these keys.
Change-Id: Ic614777399497be92ed1c2b4718d46adfb639d96
BUG: 765498
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/3105
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3cade3c74b5c34cdf2d5fcdece8a969f9015f608
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Apr 9 21:27:40 2012 +0530
glusterd: Modified algo for creating hooks directories.
- This change will ensure that hooks directories are created
when glusterd is upgraded from a version that doesn't have
the hooks feature or the 'current' hooks version.
Change-Id: I8a0ea64eda52a15b1605b98588b9b19df209a73e
BUG: 806996
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3111
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ab0fed8dd5f371237e719f76d3cafa48d1a5c28b
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Apr 9 17:22:16 2012 +0530
rebalance: revert sending PARENT_DOWN event to xlators
reverting patch 1043dedfb54c80bdbb6e050920ced204515b226e
Change-Id: I2e919c8a5e43f3cce74a8eaf58554830fa708364
BUG: 808402
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3107
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 262b277f7fbb9e080ea8d4cef36b8af1078f8990
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Apr 4 16:04:10 2012 +0530
remove-brick: Abort should revert volume changes
Also, enhanced gluster cli output.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: I520ccfb63b3568a2e6654d8a5fbf265b9b903af1
BUG: 788524
Reviewed-on: http://review.gluster.com/3082
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bcdd89e8bd77d4ca01c0c11a291de28c5ecc702c
Author: Venky Shankar <vshankar@redhat.com>
Date: Mon Apr 2 12:47:55 2012 +0530
hadoop-glusterfs: Fix IndexOutOfBounds Exception
Fix IndexOutOfBounds Exception which is hit when one
of the replica pair is down. Problematic code existed
in assuming a uniform size for each replica in pathinfo
string.
Change-Id: I85377ba5549e0603fe86e8d787115004f50e0c6a
BUG: 808009
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/3087
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: M S Vishwanath Bhat <vishwanath@gluster.com>
Reviewed-by: M S Vishwanath Bhat <vishwanath@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 551d88f9ca51c6dd309952241b2d1c06de157e68
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Apr 5 19:00:08 2012 +0530
cluster/afr: Fix a compilation warning
Change-Id: I36dc1b53fd4a7d824fe8506a4ad83ad652f95ce5
BUG: 807718
Reviewed-on: http://review.gluster.com/3094
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 55144f6d841e3c9a7a087e7d564e5dae94b41115
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 3 15:36:55 2012 +0530
self-heald: succeed heal info always
Succeeding the mgmt op enabled the rsp_dict to be used to get the
reason for the failures.
Change-Id: I781ded31afa5aafd717543a5339dee3f316aade8
BUG: 807556
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3076
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 00cc251f82ef19ffa21b861aaea548009374cb1f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 3 15:20:44 2012 +0530
mgmt/glusterd: Use the correct status string for filtering
Change-Id: Id62bec56aeda0cede19369708242f0b92f800125
BUG: 807556
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3075
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 61e3515a376c7dd9392ee0a720b38ba4c728df36
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 3 11:13:09 2012 +0530
self-heald: Add node-uuid option for determining brick position
Change-Id: Ia60981da7473d74682d86286e4d540568c8de25b
BUG: 807556
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3074
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 5bdd2ca564831d38a0e692e7f148d94da160bee8
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Apr 4 03:42:31 2012 +0200
geo-rep / gsyncd: shuffle directory entries in crawl
In order to randomize the walk of the file tree.
Change-Id: I9fc3b83d5804914a50faae8df7dbcfed2ba6f4b4
BUG: 809675
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3079
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit ead57b316bc77cbfd8b316a14a1e433dbb43306d
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Apr 2 11:56:21 2012 +0530
nfs/nlm: dummy actor for FREE_ALL procedure
NLM4_FREE_ALL rpc procedure has been provided nlm's
null procedure as actor to facilitate windows Nfs mounts.
NOTE: windows Nfs needs several other NLM procedures to work.
As a result, this patch only makes it possible to do a working
mount of a volume with "nolock" option in windows.
*Windows mount WITHOUT "nolock" option does NOT work as expected*
Change-Id: Ie163982497871312c5bb15f8c141fef460cadc34
BUG: 800287
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3063
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
commit db458ed5f42459d0229abf805194f7eb857bd1c6
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 3 08:12:34 2012 +0530
self-heald: Find self-heal failures, split-brain
Change-Id: Ib967f0fe0b537fe60e51d7d05462b58a7f16596e
BUG: 806745
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3077
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 831ee4cb22049f38276ac8f4e097e964c2a4e427
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Apr 4 18:04:52 2012 +0530
fuse-bridge/fd-migration: document migration failures in fdctx.
Change-Id: Ib85871e586f89f88dd7bf738fbb284b5d7b70a86
BUG: 809919
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3085
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 35a101a931ac2a01b3efaf0d767c26a50e4add0a
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Apr 1 15:48:26 2012 +0530
cluster/afr: Handle self-heal of files with holes
Change-Id: I6c04fe3022f234455d52620f42b9add80fc6abe4
BUG: 765424
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3065
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ee527032ecbe81986cd1ade4c753e55baf286f7a
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Tue Mar 27 11:14:23 2012 -0400
Replace GPLV3 MD5 with OpenSSL MD5
Ric asked me to look at replacing the GPL licensed MD5 code with
something better, i.e. perhaps faster, and with a less restrictive
license, etc. So I took a couple hour holiday from working on
wrapping up the client_t and did this.
OpenSSL (nee SSLeay) is released under the OpenSSL license, a BSD/MIT
style license. OpenSSL (libcrypto.so) is used on Linux, OS X and *BSD,
Open Solaris, etc. IOW it's universally available on the platforms we
care about. It's written by Eric Young (eay), now at EMC/RSA, and I
can say from experience that the OpenSSL implementation of MD5 (at least)
is every bit as fast as RSA's proprietary implementation (primarily
because the implementations are very, very similar.) The last time I
surveyed MD5 implementations I found they're all pretty much the same
speed.
I changed the APIs (and ABIs) for the strong and weak checksums.
Strictly speaking I didn't need to do that. They're only called on
short strings of data, i.e. pathnames, so using int32_t and uint32_t
is ostensibly okay. My change is arguably a better, more general API
for this sort of thing. It's also what bit me when gerrit/jenkins
validation failed due to glusterfs segv-ing. (I didn't pay close enough
attention to the implementation of the weak checksum. But it forced me
to learn what gerrit/jenkins are doing and going forward I can do better
testing before submitting to gerrit.)
Now resubmitting with a BZ
Change-Id: I545fade1604e74fc68399894550229bd57a5e0df
BUG: 807718
Signed-off-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.com/3019
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 1dded51253ebdcf96b73741c4460d949170dd5d6
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Apr 3 15:22:45 2012 +0530
locks, stripe: check if dict is NULL before refing it
Change-Id: Ifab58504280ed92e4435f7805052745e56bef5ef
BUG: 808003
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3073
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d5691d7c65a98ed372b685f8352e65ccc948c6cc
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Apr 3 13:17:28 2012 +0530
quota: log msgs indicating NULL parent inode in DEBUG level.
with name-less lookups its common to hit situations where parent
inode is NULL.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: I980b14c3d4691e850ae15768f73cf1b7d867e930
BUG: 809032
Reviewed-on: http://review.gluster.com/3071
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0cd388968a87f4f167662a1dc5f4ca0d976cfbe8
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Apr 3 01:57:23 2012 +0200
libglusterfs/run: POSIX compatible closing of child fds on non-Linux
It just occurred to me that I realized there are POSIX features that let this be
done cleanly. However, For Linux we keep the proc based approach to get more
graceful strace logs.
Change-Id: I6b473271b2adfd85cef6612eb65d88e5d00f5943
BUG: 764294
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3068
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 91626db68b34d23c8388532e7d147fa9f51d3364
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Apr 2 16:52:10 2012 +0530
dht/rebalance: Send PARENT_DOWN event before cleanup in rebalance
To prevent any crashes, due to backend ops (e.g: afr self heal),
sending GF_EVENT_PARENT_DOWN before calling cleanup_and_exit.
Change-Id: I58c87c114bf259a69a8d081d291ca908b30ec407
BUG: 808402
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3062
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit bfa47a904cba8f54c527db14748910e2f1f2afe7
Author: Csaba Henk <csaba@redhat.com>
Date: Sat Mar 31 00:15:02 2012 +0200
libglusterfs/run: clean up properly also if program could not be spawned
Change-Id: Ie81a6e1a99c1cb002653c0175bb3c5fcff9c8a4a
BUG: 808427
Reported-by: Krishnan Parthasarathi <kparthas@redhat.com>
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3055
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 687bfdeac080d5c939f7a95386886dfcb799e642
Author: Csaba Henk <csaba@redhat.com>
Date: Sat Mar 31 00:15:02 2012 +0200
libglusterfs/run: test suite refinement
If run is compiled as a standalone self-test program
(-DRUN_STANDALONE -DRUN_DO_TESTS)
add the possibility to pass an integer which makes
the program sleep that many seconds before exit
(0 forever).
This makes it possible to investigate post-test
state (eg. if there are leftover zombies).
Change-Id: Ia8d80a74eb83615ad50db2e17bb2701dc0d69070
BUG: 808427
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3067
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 0f4ce3f4d87423dea665e6f74e48184bb3a6fcb8
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Apr 2 11:08:24 2012 +0530
cli: Limit value of bs * count in "volume top"
The maximum value of bs * count is limited to 10GB. This prevents gluster from
returning 0 throughput with large values of bs * count. If throughput for values
larger than 10GB is required, use dd.
Change-Id: Ia4ea70cb20f3f32b6cb81fd451ad56933f438452
BUG: 803322
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3059
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f0d588e6f1de2ebc298c9a35f79d2298547eab13
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Apr 2 18:32:05 2012 +0530
cli/rebalance: Fix parse error for volume rebalance cmd
gluster volume rebalance <vol> force was handled as a success.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: I4f73aa5935c7e62673d457b52a6dfea6c7197dcc
BUG: 808991
Reviewed-on: http://review.gluster.com/3064
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b8999fea3278f3ecce8ec1205b3a19915dd9e124
Author: Brian Foster <bfoster@redhat.com>
Date: Mon Apr 2 09:56:42 2012 -0400
md-cache: fix time comparison to support 0 timeout
The time comparison currently causes caching when the current
time matches the timeout. This causes caching to occur even
when the timeout parameter is set to 0. Fix the condition to
support the no caching scenario. A longer term approach is to
use gettimeofday() for more accurate granularity, but this
apparently fixes a known bug.
Change-Id: I6552c5961743edb22a1aec2e6a3a6e041d0647b2
BUG: 809193
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/3066
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 8cf8a24555fb447f4f25a0d651340863bb0ec4d3
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Mar 27 18:22:15 2012 +0530
cli: do the proper STACK_DESTORY of created frames
* fixes memory leaks
* fixes some random local mem-pool empty messages
Change-Id: Ic79f279f2acfe4722fa54d52397d0267b3918928
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 803638
Reviewed-on: http://review.gluster.com/3018
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3389684d2363acb66bf47123eca8fe1d38dd4d38
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Apr 2 14:57:20 2012 +0530
nlm: print the reason of failure when clnt_create fails to create the client object
Change-Id: Icc271e2166dbccc2cc12029e26c674fdb79fe975
BUG: 808390
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3061
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 19fe49f3171ec903f83dfa110119a31b96164a5a
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Apr 2 13:00:47 2012 +0530
glusterd: Include port in nfs status
Change-Id: I679e491e801b694e8a0f93dd87cf540441dae927
BUG: 806877
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3060
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ffc81f121ae786ca230caceddcc63a68d3c6d44a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Mar 30 10:04:45 2012 +0530
performance/quick-read: open shouldn't be worried about checking whether it is being done on a deleted dentry.
lookup would've taken care of sending ENOENT, in case the entry
was already deleted.
Change-Id: I79c51e34ae3a202eb04123a2a58d0e819b6e94fa
BUG: 808017
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3044
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6031812fd6b617e2fe089cb16f84ad49dcec80af
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Fri Mar 30 17:18:07 2012 +0530
mgmt/glusterd: unregister NLM service from portmapper
Native NLM v4 service is unregistered from portmapper
when Nfs is stopped.
Change-Id: Id74cf9a31f6b00450504a1271bb47617aa5ec1fc
BUG: 786345
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/3052
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 01a9657958d0ba1a4e6fef4b376b186b6cede53a
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Mar 27 12:50:59 2012 +0530
performance/io-cache: Enhance state-dump output
Along with weight, print uuid and path. If only the inode is
cached, only weight, path and uuid will be printed.
Change-Id: Ie7567832915319f26c6bab8a34576f6c43be7998
BUG: 806900
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3014
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 063000aab384a16a9123cdf39b886c3b0dfd2851
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Mar 31 20:43:12 2012 +0530
mgmt/glusterd: Improvements for volume heal CLI.
1) Brought in a CLI improvement for volume heal cmd when it fails
before initiating a transaction.
2) Minor improvements in UI messages related to self-heal-daemon.
Change-Id: I983c1e54b48f2efe8793fa5b00fa50df2067683b
BUG: 807261
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/3057
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit 03bb58c3b1a56e4e166e418c921498fd3c0a6f45
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Mar 31 13:30:22 2012 +0530
cluster/afr: Fix frame leak in hardlink self-heal
Change-Id: I8560fc2ba0d989eeb33226f8eb8c7fbad46dfe32
BUG: 765391
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3056
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8ea9dbe85fc9641fd3d310cec789ce08007e077a
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri Mar 30 15:42:21 2012 +0530
glusterd: remove-brick validation behavior fix
earlier one of the major validation case was missed if user provided
a 'replica N' option for remove-brick where N is already existing
replica count of the volume. This would have left the volume in
inconsistent state, eventually crashing glusterd. Now fixed.
Change-Id: I418f3bbb983d36aa51214c616a887e5a3ee98e74
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 803711
Reviewed-on: http://review.gluster.com/3050
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6a156885f0121cf4f654d9edbeb543bc4b00c38b
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Mar 30 12:03:32 2012 +0530
features/locks: INIT the list before insert_merge
Change-Id: I1612565e2bbf1811a85341016b86571bdf6e5062
BUG: 805994
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3047
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e907f1ad97e038383f9e191ebfc9a2c8fafe12c6
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Mar 29 19:45:29 2012 +0530
cluster/afr: Handle invalid inode in open_fd_fix
Change-Id: Ie009fb4b8b7745ebd5b76f7a40287998be35eef3
BUG: 804914
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3045
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d003924d5b2f84a4d44ef5f4d014410035f0668b
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Mar 26 16:11:29 2012 +0530
glusterd: Added init scripts like interface for gluster commands
Directories to hold the scripts mentioned above would be created for each
gluster command under glusterd's 'working dir' as follows:
(eg.)
<glusterd-working-dir>/hooks/version/create/pre
<glusterd-working-dir>/hooks/version/create/post
where, version corresponds to the version of hook scripts.
The scripts beginning with 'S' under the above directories would be run before
(pre) and after (post) the volume created. The scripts would receive a command
line argument as below:
--volname=<volname>
This can be optionally used by the script.
Change-Id: Ia81b4ff9dd4477d99dd59b39c805aa645521edb0
BUG: 806996
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3010
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ef8acfae79b9f23508f99b7c3cfdd6dceb102137
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Mar 29 14:00:50 2012 +0530
glusterd: Used runner's RUN_PIPE to get inode size in xfs/ext3/ext4
Change-Id: I8057fd04baf36db86fe679a1beb86f76a1085b7c
BUG: 786367
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/3033
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
commit 858cff91bf414b5ec621f66b9066a1603c1785a2
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Mar 30 13:33:10 2012 +0530
nlm: do not destroy the NULL client object
Change-Id: Ie1946b33353a91a266d2b21727d0c8eaa06af7f9
BUG: 808341
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3046
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cb49accc505fc29ae41202209a7ffc34d10b9ad3
Author: shylesh kumar <shylesh@gluster.com>
Date: Wed Mar 28 14:13:00 2012 +0530
cluster/stripe: minimum blk size log message
Change-Id: I16ba2e17796cd91e89a6216d4981c09f1bcdc5cb
BUG: 807637
Signed-off-by: shylesh kumar <shylesh@gluster.com>
Reviewed-on: http://review.gluster.com/3026
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2c3dcd7749b48b6231d740c48181ab7b5252f7aa
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Mar 29 22:43:29 2012 +0530
cluster/afr: Fix split-brain log
Change-Id: Id6869fb83bb083809a2a69227e233458e0b9e0bf
BUG: 787653
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3041
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b861bff12f86dbb581df35778a98a96135a14c1a
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Mar 29 21:07:06 2012 +0530
cluster/afr: Fix the split-brain log
Change-Id: Ia4937dee009af7c945ec590a827c982b0e6ad307
BUG: 787653
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3039
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8a297af7ad3e0c8fabcec67af4ef2c4166c2d9c5
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Mar 29 13:02:32 2012 +0530
glusterd: add-brick: give proper reason in few error cases
had missed few 'else' cases, which were needed to send the right
error message to the user regarding the reason for failure.
Change-Id: I42d92782f4dec6f6bdffd42df254b7f38a715e36
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 772544
Reviewed-on: http://review.gluster.com/3032
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 994a7d1c84fec34506bcc76a8d347a6a571c7abe
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Mar 29 18:18:50 2012 +0530
cli, glusterd : "volume status detail" fixes
Use _PATH_MOUNTED, which refers to /etc/mtab, in
glusterd_add_brick_mount_details(), instead of _PATH_MNTTAB, which refers to
/etc/fstab.
More changes to cli to show available information.
Change-Id: I9da97c0fec14b3372f281efc0be37b2799bc2d0d
BUG: 808044
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3037
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 168c6c486f6380f273fd453c14f9fbc3428bf5da
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Mar 28 00:14:29 2012 +0530
cli: give warning to user in add-brick if stripe count given
* as it is currently not so well tested, user should get notification
about possibility of problems with the volume type changes.
* added warning instead of removing the feature because with keeping
an option we can enhance what is there already.
Change-Id: I6cf3491870ac2e50e85c5dbe15c61622a47c18cb
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 787967
Reviewed-on: http://review.gluster.com/3034
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 203f1c32987487eb62e8aedf72b9294bb49fea4d
Author: Amar Tumballi <amarts@redhat.com>
Date: Sun Mar 25 22:48:09 2012 +0530
core: fix all the iobuf related refs and unrefs
reviewed the code against all the possible places where
iobuf/iobref ref unref are present, and hopefully fixed most of
the issues around memory leaks with respect to iobuf
Change-Id: I9aa30326962991f8e23acedd389a0e962e097885
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 797875
Reviewed-on: http://review.gluster.com/2994
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 5453b50320a5bc705a192a025bf98da3618642a3
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Mar 27 15:52:47 2012 +0530
cli,glusterd: more volume status improvements
The major changes are,
* "volume status" now supports getting details of the self-heal daemon processes
for replica volumes. A new cli options "shd", similar to "nfs", has been
introduced for this. "detail", "fd" and "clients" status ops are not supported
for self-heal daemons.
* The default/normal ouput of "volume status" has been enhanced to contain
information about nfs-server and self-heal daemon processes as well. Some tweaks
have been done to the cli output to show appropriate output.
Also, changes have been done to rebalance/remove-brick status, so that hostnames
are displayed instead of uuids.
Change-Id: I3972396dcf72d45e14837fa5f9c7d62410901df8
BUG: 803676
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3016
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e83bd7af04903aaf5c2c38a234ff465195d42072
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Mar 29 16:31:24 2012 +0530
features/locks: check whether dict is NULL before refing it
Change-Id: I8906b80e584466aceb5a7402e3cee6ac2a552fab
BUG: 808003
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/3036
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a325200d048a41cf74efbd3930ec8ae8d4281a79
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Mar 26 12:27:12 2012 -0400
Save old volfiles in the RPM standard way.
I just got bitten by this again. It appears that the previously merged fix
was inadvertently reverted by a subsequent change.
Change-Id: I3a2067ee891fd5b8be0cd6cee58dcbc8cb6005e9
BUG: 764702
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3009
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8f109df368ca973ef6893b74cd82b86470b34b08
Author: Kaushal M <kaushal@redhat.com>
Date: Thu Mar 29 12:41:22 2012 +0530
glusterd: Increase output_string size in glusterd_get_volopt_content
The number of volume options with docs has increased, which causes the
output_string to overflow and causes glusterd to crash. This change prevents
glusterd from crashing.
Change-Id: I79f8931f92ad55245aa547e7df15c9826537b615
BUG: 807914
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3030
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0870c003f42e82b9ee41e3bc06513acac871da1d
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Mar 29 15:17:14 2012 +0530
cluster/dht: send dict with linkto key for lookup in rmdir_readdirp
Without this, if there are any stale link files, rmdir fails with
ENOEMPTY error.
Change-Id: I7056b272122eb5540c22412856f46f638774c119
BUG: 807246
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/3035
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 63ed5aa0c322373513c0c10c23154e6db5f35ecf
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Mar 29 12:17:12 2012 +0530
cluster/afr: handle fstat failure in data-self-heal
The final fstat which makes the call_count 0 could be a failure.
In that case the buf could either be NULL or buf is all zeros.
If buf is NULL then it will crash, if it is all zeros
buf->ia_type will be IA_INVAL and it proceeds to special file fix.
sh->type is assigned with the ia_type of the file to be healed.
I modified the code to depend on that instead.
Change-Id: Icf7e19ff5908207128f2a1ee2963ad6b791c1ac5
BUG: 804645
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3031
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d10e77bd9790a433b4a750f19ea7aff82e1efdb2
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Mar 29 11:21:07 2012 +0530
performance/quick-read: fix build errors.
Change-Id: I8c4781bdd6c3cfd50cff95c31ecd6d653b916ac3
BUG: 765363
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3028
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 66ac48486c8bd552af6047f1f61d73b1dca82bbf
Author: M S Vishwanath Bhat <vishwanath@gluster.com>
Date: Tue Mar 27 17:59:15 2012 +0530
build-deploy-jar.py: Print usage message when hadoop home directory is missing.
Change-Id: I0b55b33a36a4a5e4f1b71547629d20ae6b5eba5a
BUG: 807155
Signed-off-by: M S Vishwanath Bhat <vishwanath@gluster.com>
Reviewed-on: http://review.gluster.com/3017
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 5e8846be2404f996b0d0a2ebc1ce147547455173
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Mar 28 16:18:17 2012 +0530
cli, glusterd: "volume set help" additions
"auth.allow/reject" and "server.statedump" options are included in "volume set
help" now.
Change-Id: I7f9ba89d1782c26792347ffd2cd4042c3c396934
BUG: 783390
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3025
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7e582204323791736fa509ae8c20283ce2466565
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Jan 19 12:40:34 2012 +0530
cluster/afr: Handle afr data self-heal failures gracefully
Change-Id: I5f91098111a8ca29982f3b4292e2109e4a36cce1
BUG: 765373
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2662
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit fcb65bba68f7d6dff3792d7cfbc9cc8feef82936
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 27 01:20:21 2011 +0530
performance/quick-read: make unlink aware of open-behind behaviour of quick-read.
quick-read should do an open of all the fds that are waiting for to be
opened behind before doing an unlink on a path.
Change-Id: I4c8d65c0511e8a37765ff57e30d99dd89b56c4fc
BUG: 765363
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/506
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a092811f7d65e3f6a62f5bec60756dd20a014ad8
Author: shylesh kumar <shylesh@gluster.com>
Date: Wed Mar 28 10:50:06 2012 +0530
cluster/stripe- do not ref if dict is null
Change-Id: Ifa4a5253482d837e2583de078e908b8c442f9dca
BUG: 807214
Signed-off-by: shylesh kumar <shylesh@gluster.com>
Reviewed-on: http://review.gluster.com/3024
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 427067d79dbb34308b54fa2ad7537df5bc9f6e2e
Author: Mohammed Junaid <junaid@redhat.com>
Date: Wed Mar 28 06:31:56 2012 +0530
protocol/client: Set grace_timer_needed flag to false on a disconnect.
A grace timer is registered on a disconnect, but a reconnect timer sends a
connect request after every 3sec and if the server is down, the client protocol
receives disconnect and a grace timer will be registered which on timeout will
increase the lk-version value. Its enough to register the grace timer once after
the first disconnect and later just ignore other psuedo disconnects until the
next successful reconnect.
Change-Id: I7f34a98a79fdc25370ef15a6712bfa316a9b7c7c
BUG: 807271
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/3020
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f252ed9c053929c26ada81a90500b488b43e50d1
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Mar 27 08:47:35 2012 +0530
performance/write-behind: queue setattr fop with writes always.
stat returned in setattr_cbk can be cached by the kernel. Hence it is
always necessary that we return correct stat, which implies that setattr
should not be out of order with respect to write fops.
Change-Id: I305feeb4802f8a41ffaf032100832cbd65dfc5c1
BUG: 765443
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3011
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 4677dfc9df089294918c11ff40fa30a68b6c3788
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Feb 13 19:15:17 2012 +0530
glusterd: Fixed replace-brick commit_force algo.
- commit force subcommand of replace-brick (rb) should be allowed
even if source brick is (irrecoverably) offline.
- modified rb_timer to be active only for start subcommand. This is
important since, the rb timer event relies on src_brick and dst_brick
objects to be 'alive' when it 'happens'. In the case of
abort/commit/commit force it is very likely that src_brick and/or
dst_brick objects could have been destroyed.
Change-Id: Ib8b8a4d690fbdd6f99b8aff306490eb59c54a437
BUG: 772845
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2620
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f9733d9df2d20cd2146d3de0011a7473103221f5
Author: Kaushal M <kaushal@gluster.com>
Date: Tue Nov 15 18:26:44 2011 +0530
cluster/dht : Acl fix for distribute directory selfheal
Send acl xattrs, if present in the xattrs returned during lookup, during
directory self-heal.
Change-Id: I5337bbd3f3963aeed500a8a552e5f6713089b53e
BUG: 764787
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/737
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b0c45afcc80d99b71e735d74a7e67be8f15f9877
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Mar 26 18:36:29 2012 +0530
libglusterfs/fd: ref fds while copying the fdentries.
Change-Id: I8973ec5d9858adfbdd6efc7cd596cf5d5af0e3cb
BUG: 767862
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3006
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b192f277ef9d91e96e8610496f14445383dabcd3
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed Mar 7 14:04:07 2012 +0530
mgmt/glusterd: native sort of info files
dependence on sort(1) has been removed,
sorting of the files is now done using qsort(3).
Change-Id: I90e162ba626506d01323ddfbfa594cf64b2e43c3
BUG: 790337
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2990
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 477ede3cada4c20c2bf8d26171ace7dcc192e6e7
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Mar 23 13:13:09 2012 -0400
Fix build problem with "trash" being semi-removed.
With "trash" removed from xlators/features/Makefile.am but not from
configure.ac, configure fails trying to create .../features/Makefile
from .../features/Makefile.in which was itself never created.
Change-Id: Idcba2c282c09821ae620e59748952e8d26117fdc
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3003
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 65a4f7afb7489ed92bc82474ea75d98a3ad02242
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Mar 20 17:22:24 2012 +0530
core: adding extra data for fops
with this change, the xlator APIs will have a dictionary as extra
argument, which is passed between all the layers. This can be
utilized for overloading in some of the operations.
Change-Id: I58a8186b3ef647650280e63f3e5e9b9de7827b40
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 782265
Reviewed-on: http://review.gluster.com/2960
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit c3a01c1df1bad8bbb66476c71c756837b7d9c437
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Mar 22 16:37:42 2012 +0530
glusterd: bring back the 'non-synctask' behavior
revert back to non synctask behavior
Change-Id: Icfc9cbdeaf8dd6735df8366a6121c6598c56fade
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 805802
Reviewed-on: http://review.gluster.com/3002
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 572a375b674bf9ba46c0715b3d0dd7ab165ce21e
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Mar 22 04:11:38 2012 -0700
Revert "core: enable process to return the appropriate error code"
This reverts commit 16717f4df7b0fbd3c255f5faf8a2744444231bb7
Change-Id: I65624db4d31e11e1bec66b07b352ce823ef069b9
Reviewed-on: http://review.gluster.com/3001
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a91d97dd5fd8c2188be5c032dffdffdbff28ff56
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Mar 22 13:51:23 2012 +0530
glusterd: fix bugs of syncop for operations
* free the stack created for synctask
* use different key than 'operation' in dictionary as thats being used
already by other glusterd operations
* send proper frame to 'rpc_clnt_submit()' API, as it gets used
internally
* also make sure to destroy the above frame in all _cbk()
* move everything specific to synctask into one file, so it is easy to
maintain
Change-Id: Ia1a4414fffec6f9e51700295947eea4a2104a8c2
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 805802
Reviewed-on: http://review.gluster.com/3000
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 6dfc9e26f318f12463b507da9b16db87484047df
Author: Kaushal M <kaushal@redhat.com>
Date: Tue Mar 20 18:05:18 2012 +0530
cli: Display available information in "volume status detail"
Display the available information in "volume status detail", without failing
and erroring out if some information is missing.
Change-Id: If8edc268fe91ca9c681f25135738a75eec43b8c3
BUG: 765464
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2989
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c308032cb260aad2205ddf743bbf310f7e0e504d
Author: Rahul C S <rahulcs@redhat.com>
Date: Wed Mar 21 12:15:52 2012 +0530
Add space for heal vol req log message.
Change-Id: Iadf1d6304bcae8f666f2435ffa2d71c50dd1395a
BUG: 764658
Signed-off-by: Rahul C S <rahulcs@redhat.com>
Reviewed-on: http://review.gluster.com/2991
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
commit 827c13943bb302f7708f83eb2cbe010f5a983ea3
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Mar 14 15:10:48 2012 +0530
dict: add a dict_dump() function to dump the dictionary contents
helps for debugging some functionalities where we have to understand
what we send from one end point to another is properly received on
the other endpoint without any errors.
Change-Id: I9b802f12ae542e499161a1f3b9a5602f7b93b0ee
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 782265
Reviewed-on: http://review.gluster.com/2959
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0441983703e4a0ae56917c515e0bbdd5a8cbd1a8
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Mar 21 12:39:13 2012 +0530
glusterd: Disabled self-heal on clear-locks internal mount
- Also, changed afr_get_xattr_clrlk_cbk to use dict_set_dynstr for
clear-lock summary. Earlier, it was relying on 'str' passed from
xlators below.
Change-Id: I175f4542e6ef2c859c4811eecb9d8c5a7d25a283
BUG: 800779
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2992
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 404681a026967306e5f49c2d888c8571fe23a2e8
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Oct 13 15:23:39 2011 +0530
core: enable process to return the appropriate error code
Credit of this patch goes to Avati <avati@gluster.com> as I just did a
rebase to the lastest master.
Change-Id: I53b2adf90fd9808433bdc35b57dad0682bc90860
BUG: 762935
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/579
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 7812f975e7dab5e0c571dfedc7aa4f63d81203e4
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Dec 20 14:54:35 2011 +0530
glusterd: bring in feature to use syncop for mgmt ops
* new sycnop routines added to mgmt program
* one should not use 'glusterd_op_begin()', instead can use the
synctask framework, 'glusterd_op_begin_synctask()'
* currently using for below operations:
'volume start', 'volume rebalance', 'volume quota',
'volume replace-brick' and 'volume add-brick'
Change-Id: I0bee76d06790d5c5bb5db15d443b44af0e21f1c0
BUG: 762935
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/479
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit b057296f67097ae189acb9b7565676908c20e1e1
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Mar 21 21:57:37 2012 +0530
features/locks: Avoid race in pl_inode_get
Change-Id: I6c7b878fb43863137aac6552ee66f091534a6296
BUG: 770080
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2998
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit e75933fbca478cbaa7e71d6e24810bc2c6bf29c0
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Mar 21 15:41:26 2012 +0530
features/locks: Avoid race in creating domains
Thread:1 | Thread:2
-----------------------------------------
1) Does inodelk on inode1| 1) Does inodelk on inode1
2) It tries to get the | 2) It tries to get the
dom object for the volume| dom object for the volume
volname-replicate-0. But | volname-replicate-0. But
the domain list is empty.| the domain list is empty.
3) Create the new domain |
dom1 and add it to head |
of the list of domains. |
4) inodelk happens on | 3) Create the new domain
dom1 on range r1. | dom2 and add it to head
| of the list of domains.
| 4) inodelk happens on dom2 on range r2
5) unlock for r1 comes | 5) Unlock on r2 succeeds.
on inode1. |
6) It tries to get the |
domain, of the inodelk |
for volume |
volname-replicate-0, gets|
dom2 but the lock on |
range r1 is not present |
so it fails. |
subsequent inode lock, unlocks will keep happening on the domain dom2.
The stale lock present in the dom1 on range r1 will live on.
It wont cause any hangs, but the statedump will always be scary.
Change-Id: I9adc120d33febf685b30859cc307768c2fc63ae5
BUG: 770080
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2993
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit a0fea6a4e3158a9e9e1a7593335ea8a35ab8cbf6
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 21 10:58:03 2012 +0530
protocol/client: memory leak fixes.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: I804c934d79ed13ded9d1b741cef6597bc238e476
BUG: 803675
Reviewed-on: http://review.gluster.com/2987
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 06799d2f23cacf756941a78d512b6faafb226f89
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Mar 20 17:11:04 2012 +0530
performance/read-ahead: destroy pages which survived from being flushed in flush_region because of frames waiting on them, after those frames are served.
Change-Id: Ic8402f3da32058a1a11e62124b598b0ec3befeff
BUG: 767948
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2982
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7b72b510c86b3709ad49fc921466dd0c3bcb7058
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Mar 20 16:48:18 2012 +0530
performance/io-cache: destroy the pages which survived in __ioc_page_destroy because of non NULL waitq in ioc_fault_cbk.
Change-Id: I00b83f8bf0a654b3a3a23cf0b25657fbfda17804
BUG: 767948
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2981
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0913a288938f053e6786576bdc8db2e5b44f2dbf
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 20 16:00:41 2012 +0530
protocol/server: remove the transport from the list irrespective of lock-heal is on/off
Upon getting disconnect, remove the transport from the list of transports that
protocol server maintains irrespective of whether lock-heal is on or off, since
upon reconnect a new transport would be created.
Change-Id: I18a269a93487d6e2cb11c345b6dde813d089809c
BUG: 803815
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2980
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 8aa353751b498f9203e1d595a4f0c7a8d58e63f6
Author: Mohammed Junaid <junaid@redhat.com>
Date: Mon Mar 19 12:05:09 2012 +0530
features/marker: Replacing -1 with GF_CLIENT_PID_GSYNCD as part of code cleanup.
Change-Id: Ia665060bff636b372904a726aba5249de9ade124
BUG: 769494
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/2971
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
commit 4beddda593e1a885585a7e9e3e965aa3ef9d2e63
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Mar 12 09:32:40 2012 -0400
replicate: fix a glitch in up_count/down_count updates.
Change-Id: I4919a98191bf7fe5edad9a149a129bcd177cd4a8
BUG: 802522
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/2927
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9038392e019869346eb54a5fb7e0df0905a0c0b9
Author: Mohammed Junaid <junaid@redhat.com>
Date: Mon Mar 19 21:26:56 2012 +0530
protocol/client: Handle failures in lock self healing gracefully (part2).
During reopening of fd's and reacquiring of locks on the fd (after a
reconnect), a release on a fd on which reacquiring of locks is in progress
will free up fdctx. This patch will keep fdctx valid until the reacquiring
of locks is in progress.
Change-Id: I0fae27544a7f8ddaa26def4ee4d41a8a2b322521
BUG: 795386
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/2819
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 63b6b467cb3060ce5fc3c7f71d5b9f18dc234bb5
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 19 18:10:34 2012 +0530
rpc-clnt: separate out connection_cleanup() from destroy()
noticed that there are possibilities where one would like to do a
connection_cleanup() before destroying a RPC connection itself, also
current code is such that, rpc_clnt_connection_cleanup() does
rpc_clnt_ref() and unref(), creating a race window/double unref
possibilities in the code.
by separating out the functions, this race window/double fault can be
prevented.
Change-Id: I7ebd3392efa891232857b6db9108b0b19e40fc12
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 802403
Reviewed-on: http://review.gluster.com/2979
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit dc821609c160553e8bfb681745b3659835090445
Author: Mohammed Junaid <junaid@redhat.com>
Date: Mon Mar 19 21:07:33 2012 +0530
protocol/client: Handle failures in lock self healing gracefully (part 1).
During reopening of fd's and reacquiring of locks on the fd (after a
reconnect), a release on a fd on which reacquiring of locks is in progress
will free up fdctx. This patch will keep fdctx valid until the reacquiring
of locks is in progress.
Change-Id: I0464c751a5aa986abac0b72b48b261fceeba24e8
BUG: 795386
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/2937
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7d4169ec55f3b11cda8c8062e8aa04b2411f171a
Author: Mohammed Junaid <junaid@redhat.com>
Date: Mon Mar 19 19:56:21 2012 +0530
protocol/server: Handle server send reply failure gracefully.
Server send reply failure should not call server connection cleanup because
if a reconnection happens with in the grace-timeout the connection object is
reused. We must cleanup only on grace-timeout.
Change-Id: I7d171a863382646ff392031c2b845fe4f0d3d5dc
BUG: 803365
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/2947
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 49caf8052d51d8d34bb0649ee30aa5140b5351aa
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Mar 19 18:02:57 2012 +0530
protocol/client: Avoid STACK_DESTROYing more than once in RELEASE fops.
Change-Id: I435327c6133aa6739731dabddde860b0b43c1497
BUG: 804607
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2978
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 220d774112c7cb3b07b5712663a170f4ed654c88
Author: Rahul C S <rahulcs@redhat.com>
Date: Mon Mar 19 15:03:09 2012 +0530
print bound_xl only once in server statedump
since, currently there is only one bound_xl for
all connection objects, it does not make sense
to print the bound_xl for every conn object.
Change-Id: Iaf4a170fe63fb7e80133c449a20f298f0e86364c
BUG: 765495
Signed-off-by: Rahul C S <rahulcs@redhat.com>
Reviewed-on: http://review.gluster.com/2975
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0e4014055618d2fe3e32db78ac3918165db08faf
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Mar 19 15:13:14 2012 +0530
features/quota : Fix timeout min value
Change timeout min value to 0, so that default value of 0 successfully validates
and mounts happen properly.
Change-Id: I579c6192b97ffe2678fa95c912679b514fa7d8c0
BUG: 804509
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2976
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 28a1669d583a115eaa8df03d3dc140d075ba6fcc
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Mar 19 11:56:20 2012 +0530
cluster/dht: Prevent crash in dir xattr selfheal
Change-Id: I2ca4ab2f8e8611e7b2ac9ed2edc2e304727259dc
BUG: 804280
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2970
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3a68d68cbef3f737677cbca8f3dea277b8d0c959
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Mar 19 14:07:14 2012 +0530
libglusterfs/call-stub: ref dict while storing it in readdirp stub
Change-Id: I11224f7afa2e87dc242cc2e9e865c7ab2bb88c7e
BUG: 765785
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2974
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 5addac7c59b88942df792cfbb775c1ed4964d4d5
Author: Harshavardhana <fharshav@redhat.com>
Date: Fri Jan 6 16:00:25 2012 -0800
libglusterfs/dict: Add boundary conditions
Functions modified:
1. data_to_int16()
2. data_to_uint16()
Change-Id: I6775ca5d39f519c24ca3a07ce41018472e238cdf
BUG: 769692
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/2599
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit deffa6c94b4ad1d2f51caf984d62b71b3628778a
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Mar 14 16:45:21 2012 +0530
cluster/stripe: fix {set/get}xattr query for dirs/symlink
This patch fixes the following problems:
* ENOENT returned for getxattr (xtime) on symlinks
Non-data entities are created only on the first subvolume but
getxattr fop winds to all subvols. This results in all subvols
except the first one to return ENOENT which is propogated down
the stack.
* ENODATA returned for getxattr (xtime) on directory
setxattr calls always wind to the first stripe subvolume.
xtime getxattr invocation winds to all subvolumes but the
xattr is present in only the first one, resulting in all
subvols except the first one to return ENODATA.
Fix
For symlinks getxattr now always winds to the first subvol and
for directories setxattr sets the xattr on all subvols.
NOTE
For directories the all-subvol-wind in setxattr is done
only when request is from a special client (client-pid == -1)
Change-Id: I9236345ef319506770d2034b840ee4ac04704b21
BUG: 801394
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/2948
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit edd12681bd7053ca27ffac87d265e660d91181d9
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Mar 18 14:10:08 2012 +0530
Logs: Improved logs in lock/unlock execution path
Statedump will now start showing the lk-owner of the stack.
Change-Id: I9f650ce9a8b528cd626c8bb595c1bd1050462c86
BUG: 803209
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2968
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 9018cf25a43f23e28ac99023a60b0dfdf6806334
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Mar 8 14:13:56 2012 +0530
protocol/client: replace STACK_UNWIND_STRICT macro with CLIENT_STACK_UNWIND, which does appropraite cleanup before unwinding.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: Ic49d6e21c5fc56e747afec35be2bebbbbd2a6583
BUG: 767359
Reviewed-on: http://review.gluster.com/2897
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit be9a6d87e42551f4500d96760e35d38ba139753b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Mar 8 10:59:43 2012 +0530
rpc: don't unwind the fop in caller if client_submit_request fails
client_submit_request guarantees that the cbkfn - which we pass to
it as argument - is called whenever there is a failure.
Change-Id: I0e8ce5a6b320246dc13ce4318b04739d38d183a3
BUG: 767359
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2896
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 51cca19a1f1e7482f001c68ee26e3c78cc48c729
Author: M S Vishwanath Bhat <vishwanath@gluster.com>
Date: Fri Mar 16 17:02:46 2012 +0530
Using correct path to build and find jar file in build_deploy_jar.
Change-Id: Ifeadd60370b36ab7b345c336a40a17091698ffe5
BUG: 803879
Signed-off-by: M S Vishwanath Bhat <vishwanath@gluster.com>
Reviewed-on: http://review.gluster.com/2955
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 2ecc1972bd207c42612637b6501056d1a76ed060
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Mar 18 13:49:07 2012 +0530
rpc: cancel reconnect timer in rpc_clnt_disable
When the graph is considered no longer needed, rpc_clnt_disable
is called, which disconnects the connection to server but the
reconnect timer is not cancelled in that function, so it is
reconnecting to the server before the grace-time-period.
The locks of the disabled graph are still there on the server
which are leading to hangs.
Change-Id: I8d37f1296370e37117005137a0a430e636da4d2e
BUG: 803209
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2967
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 0bdc712601ebc9d1362960197a24e4a3a57d627b
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Mar 7 08:11:57 2012 +0530
volgen: by default don't include performance xlators in nfs volfile
Change-Id: I183ff00b0c0d23cec1123c320b7444eec0f71765
BUG: 790333
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/2883
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ebbe9eb92fe9af6a9a8a63d27b38f6b75488548d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Mar 18 13:07:30 2012 +0530
protocol/server: Clear internal locks on disconnect
If there is a disconnect observed on the client when the
inode/entry unlock is issued, but the reconnection to server
happens with in the grace-time period the inode/entry lk will
live and the unlock will never come from that client.
The internal locks should be cleared on disconnect.
Change-Id: Ib45b1035cfe3b1de381ef3b331c930011e7403be
BUG: 803209
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2966
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5a558f5389b8ec347b4e759e4f1798ec6f804295
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 12 17:50:34 2012 +0530
mgmt/glusterd: don't create the brick path in 'volume start'
create the missing brick directory only on a
'gluster volume start <VOLNAME> force' command
Change-Id: Ica4fab9cefe953d73de9a30843d48f94e6ab735c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 801610
Reviewed-on: http://review.gluster.com/2921
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 5fd68344497df641e96941ce310bf98a8ff1b41d
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 6 14:35:45 2012 +0530
protocol/server: send forget on the renamed inode
If rename is given on a file "a" to "b" ("b" is already existing file),
then after rename, the inode for "b" would still be in the inode table
and would not get forget (for fuse client, the fuse kernel module would
send, but on server forget will not come on that inode), thus leading
to inode leak even when the mount point is empty.
To avoid that before doing inode rename, unlink the previous inode that
"b" is pointing to and send forget on that, if "b" is the last dentry
for that inode.
Change-Id: Ie4dcc39ea190ee8f28029b4d7661df576d9cf319
BUG: 799833
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2874
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f3878bed1faf2b1514695cd11e71b4b554c4ee6b
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Mar 7 13:06:38 2012 +0530
mgmt/glusterd : volume set validation fixes
This is the new version of the patch by Kaushik at review.gluster.com/699
The following new option types have been introduced:
* GF_OPTION_TYPE_INTERNET_ADDRESS_LIST
* GF_OPTION_TYPE_PRIORITY_LIST
* GF_OPTION_TYPE_SIZE_LIST
and option types of several options in translators have been updated to use the
new types.
valid_internet_address(), valid_ipv4_address() & valid_ipv6_address() functions
has been updated for * wildcard matching. Previously used standalone wildcard
address checking functions have been removed.
Changes have been done to stripe translator to correctly set, update and use
stripe-blocksize. Also minimum value for block-size has been set to 16KB.
Change-Id: I2aa484ff695f6a915a8fc9a9f965cf0344f41d59
BUG: 765248
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2899
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit cdbc45eba8ff29e5ff4017318945a2c38016debd
Author: Louis Zuckerman <louiszuckerman@gmail.com>
Date: Tue Feb 7 11:16:10 2012 -0500
Updated the Ubuntu upstart jobs for glusterd in extras/Ubuntu.
Using upstart jobs, instead of an initscript, solves Bug 765014.
See also: https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/876648
The new upstart jobs split the work of starting glusterd & mounting glusterfs volumes into two parts: a glusterd service runner and a glusterfs volume moung blocker which waits for the service runner.
This is the method preferred by Ubuntu developers to block a mounting event until a required service is available. These changes will be included in the Ubuntu glusterfs-server package starting with release 12.04, Precise Pangolin.
Tested on Ubuntu 12.04
Change-Id: I9bb4e8cb05a1da0997c23f2ef7fea8737f6a2eb9
BUG: 765014
Signed-off-by: Louis Zuckerman <louiszuckerman@gmail.com>
Reviewed-on: http://review.gluster.com/2727
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f86ddcddf23c6fa89d0d11b0cb8787a4d7493073
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 14 16:13:17 2012 +0530
mount/fuse-bridge: don't pass flags O_CREAT | O_EXCL during open as part of fd-migration during graph-switch
Change-Id: Ia1494941d3e3d5bebdba3483b0ea7b32c9704b8c
BUG: 802710
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2943
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 31cc2920251887cae39410b71e4188e9e81a11d5
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Mar 16 16:09:42 2012 +0530
Self-heald: Handle errors gracefully and show errors to users
Change-Id: I5424ebfadb5b2773ee6f7370cc2867a555aa48dd
BUG: 800352
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2962
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1a6a630e370635b1b5eeb6e80ed7cc889753d080
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Mar 16 22:10:02 2012 +0530
cluster/afr: set_read_child when xactions in progress in fresh lookup
Change-Id: I33e0268635ae7a1f247b0052994e027f990083da
BUG: 800755
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2963
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 078d4e7ac9e558dcf36e882b6d15f69466017508
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Mar 15 16:04:10 2012 +0530
mem-pool: more debug friendly logs by using gf_log_callingfn()
Change-Id: I4d6e53ad8660314315f2ff3aa92ffbe707d6efe9
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 803638
Reviewed-on: http://review.gluster.com/2951
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d62c6abf37b780832f41d115a205d9266df244a8
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Mar 15 11:52:07 2012 +0530
afr: Copy loc->gfid independent of lookup being fresh or otherwise
This change ensures that entry self-heal following a lookup on that entry
would have loc->gfid 'filled'.
Change-Id: If723c71ca43e1f062dcb99cbe5488342514dace0
BUG: 786087
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2950
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1be03fc5e880b4eda331b13231d777c9e8fbe940
Author: Rahul C S <rahulcs@redhat.com>
Date: Sat Mar 17 18:32:04 2012 +0530
Change option brick-with-valgrind to run-with-valgrind
brick-with-valgrind does not make much sense because all the
glusterfs/glusterfsd server processes are run with valgrind.
So changing the option from brick-with-valgrind to
run-with-valgrind.
Also fix misspelt 'valgrnd' for valgrind log file namenames.
Change-Id: I87aad6d65ffc37d8f8679be215709a9174385ecd
BUG: 804293
Signed-off-by: Rahul C S <rahulcs@redhat.com>
Reviewed-on: http://review.gluster.com/2965
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 1085516afe138cd0010a6eab94df3cbafca7fe25
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Mar 15 10:51:12 2012 +0530
cli/remove-brick: Enhance remove-brick status to display
Rebalance status now contains info from all nodes.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: I6208c9879927fb6ddc0713c1480feadcf4f3fd75
BUG: 797887
Reviewed-on: http://review.gluster.com/2949
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 161819dc36df1a0ac21b62557e4c0afff4932522
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Mar 16 09:11:58 2012 +0530
protocol/server: memory leak fixes.
Change-Id: I203832d9d52373f068f90e30dc7672329d65bbea
BUG: 803675
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2954
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 8ab1c66e673978a44a0214ec9f9065b618dd2733
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Feb 23 15:43:58 2012 +0530
cluster/afr: Enable eager-lock
Eager-lock is disabled by default.
Use cluster.eager-lock on/off to change the config.
write-behind on and eager-lock off is not supported configuration.
In afr, when eager-lock is enabled the inode lock on fd is taken
using the fd address as the lk-owner. So the lock is
interchangableale between the inode-locks on the same fd.
Change-Id: I7eef1ecd510f8028f5395dee882782da53c0de3f
BUG: 802515
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2925
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d6000d4ab0a4d6527cce850c27e1e1f8739dc675
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Fri Mar 16 16:59:45 2012 +0530
rpc-lib: memleak fix in rpcsvc_volume_allowed
Change-Id: Iaa6baa4a3e036b2b5c808ea5e79017fffeb80a24
BUG: 801754
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2956
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 910925ea455b00cbf8ff2091cf87ee278ab5fc9a
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Mar 16 16:25:07 2012 +0530
protocol/server: add and remove the transports from the list, inside the lock
Till now for graph changes, glusterfs client used to remember the old graph
also. Hence the transport object on the server corresponding the old graph
never received disconnect. But now since the graph cleanup is happening,
transport on the server side gets disconnect for the cleaned up graph.
Server maintains, all the transports in a list. But addition of the new
transport to the list, or removal of the transport from the list is not
happening within the lock. Thus if a thread is accessing a transport
(in cases of statedump, where each transprt's information is dumped),
and the server gets a disconnect on that transport, then it leads to
segfault of the process.
To avoid it do the list (of transports) manipulation inside the lock.
Change-Id: I50e8389d5ec8f1c52b8d401ef8c8ddd262e82548
BUG: 803815
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2958
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d0dc9e0686f26dc477179209c6646a38d2f351b2
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Mar 16 11:35:36 2012 +0530
glusterfsd: Handle errors in response send
Change-Id: I2d0a136fdfc4c86fb89cff5565efbf4af80e1edf
BUG: 799265
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2961
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 81d961ad4faebd1dc0a629b5ee284325c2cc7a57
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Mar 3 17:28:17 2012 +0530
protocol/server: Avoid race in add/del locker, connection_cleanup
conn->ltable address keeps changing in
server_connection_cleanup every time it is called.
i.e. New ltable is created every time it is called.
Here is the race that happened:
---------------------------------------------------
thread-1 | thread-2
add_locker is called with |
conn->ltable. lets call the |
ltable address lt1 |
| connection cleanup is called
| and do_lock_table_cleanup is
| triggered for lt1. locker
| lists are splice_inited under
| the lt1->lock
lt1 adds the locker under |
lt1->lock (lets call this l1) |
| GF_FREE(lt1) happens in
| do_lock_table_cleanup
The locker l1 that is added just before lt1 is freed will never
be cleared in the subsequent server_connection_cleanups as there
does not exist a reference to the locker. The stale lock remains
in the locks xlator even though the transport on which it was
issued is destroyed.
Change-Id: I0a02f16c703d1e7598b083aa1057cda9624eb3fe
BUG: 787601
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2957
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit f91506244786fb347cc8287edc5a74f90e9a20ed
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Mar 15 14:00:13 2012 +0530
core: bring a cmdline option to set memory-accounting
currently this is implemented as a command line option, and not
as an easier translator option. this is because as of now, before
even the volume files are parsed, we would need memory accounting
enabled. there is scope for improving this behavior, but for now,
this approach solves the problem.
Also, this feature's major consumers are the testers who are
looking for leaks, hence option is hidden from usage output.
Change-Id: I09a5b13743ae43ff42c251989f921319e94cabe3
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 799199
Reviewed-on: http://review.gluster.com/2856
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 5d37a991f9ebd27a213fd07ecb92cfae694dcd8b
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Mar 1 17:25:12 2012 +0530
core: dict allocations through mem-pool
Change-Id: I7401639060957d437808779745a1e46c3f9f4585
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 798503
Reviewed-on: http://review.gluster.com/2851
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6cba8c2fef9e22b2053b4551052149d590cfee3e
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Mar 14 15:35:51 2012 +0530
dht: Rebalance status should display status from each process
Change-Id: Id128417219bdb7146253618a5f8f31ef35013894
BUG: 801322
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2942
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 68c075ae5c2892f2f73a588b0f6a1340d656b2fe
Author: krishna <ksriniva@redhat.com>
Date: Tue Feb 28 13:28:31 2012 +0530
remove code that was part of hard resolution which is not needed anymore.
Change-Id: I9321745a40765eff048a656a7885f12847a0a318
BUG: 781318
Signed-off-by: krishna <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/2830
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 63434d6f414abcd880479247219c0fcb84441176
Author: Csaba Henk <csaba@redhat.com>
Date: Mon Feb 27 05:41:17 2012 +0100
glusterd/mountbroker: enhance mountbroker-geo-replication.* option to take multiple volumes
Comma can be used in the value of a "mountbroker-geo-replication.*" option
with semantics as of these examples:
option mountbroker-geo-replication.foolabel vol1,vol2,vol3:geouser
and
option mountbroker-geo-replication.geouser vol1,vol2,vol3
will allow geouser to mount any of the volumes vol{1,2,3} with params of a
geo-rep aux mount under label foolabel, resp. geouser
Also fix memleak in parsing of this option.
Change-Id: I5311388812f503a078a52a14f2679f5ddb33b248
BUG: 765214
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/2818
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit fa632312fb2cb868182016cdc35247d9362bbb7e
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Mar 12 17:34:32 2012 +0530
afr: Corrected getxattr 'key' matching in case of clrlk cmd
- Added local->dict cleanup into afr_local_cleanup
Change-Id: Ie1b96615735a9d2a2be1757cd016dbe225aae31c
BUG: 800412
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2922
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e716bab41469b61035972115a61b7b382547efef
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Mar 14 18:28:09 2012 +0530
glusterd: Fix brick op to prevent glusterd crashing
Was building payload only for node types GD_NODE_BRICK & GD_NODE_NFS.
Payload wasn't being built for nodes GD_NODE_SHD & GD_NODE_REBALANCE, which made
glusterd crash when those operations were performed.
Also fix a compile warning.
Change-Id: Id33e21c84901d4d112c54514b7f16add31aeb950
BUG: 803313
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2946
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit dacde60aece7bf5ebce071db4680ce8bf6e9782b
Author: krishna <ksriniva@redhat.com>
Date: Thu Mar 8 17:11:42 2012 +0530
rpc: log in DEBUG when nfs clients try to see if ACL requests are accepted by nfs server
Change-Id: I897b48a02ce2150d268a1a8b45163e9e1aee6cff
BUG: 801338
Signed-off-by: krishna <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/2901
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1426281d175bf848be36f7b088d22061735dd0a0
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Mar 13 16:58:04 2012 +0530
rpm spec file: update the 'logrotate' config file during rpm install
so there is no need for admin to worry about logrotate configs.
Change-Id: Iec6def870d0c3550f2642ade023c03de52d6d530
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 801372
Reviewed-on: http://review.gluster.com/2935
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2a155f96d720bbf339ab707e4233a759c87fcd56
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Mar 12 21:06:45 2012 +0530
nfs: do not call inode_path on the newly created inode
While resolving, for building the path into the loc, inode_find
is called with gfid as argument to get the inode from the inode
table. If the inode is not found, then a new inode is created.
Then the path is build using inode_path. But if the inode is
not linked to inode table (newly created inode), then gfid will
be null and inode_path returns null gfid as the path. Suppose the
lookup operation on that gfid fails, then we print the null gfid
in the log message.
To avoid it, build the path using the gfid only if inode_path
fails.
Change-Id: I2506fa8675761ddb0bc02980cd3583d9d068fc85
BUG: 802424
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2930
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1dab04dda6f1117681a11f4f30247eaae04908ce
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Mar 12 13:15:14 2012 +0530
locks: Fixed incorrect list ptr manipulation in clearing entrylks
Avoided unwinding blocked entry lock frames inside pl_inode->mutex.
Change-Id: I424c4a1762c889c1a567c588d4ca383a6c338886
BUG: 800412
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2878
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ae591c6fa70f4baa3ab4ec828c927878c429756d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Dec 14 16:01:20 2011 +0530
performance/io-cache: cleanup the xlator private data completely in fini.
Change-Id: Ib8859c57e89248ccaad94662f88944e79ec28d5a
BUG: 767862
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/791
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e4526fe397e9e32ba5113684e6ec6cbb2bfac7f4
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Mar 5 15:15:04 2012 +0530
fuse-bridge/graph-cleanup: don't provide a cbk for cleanup syncop task
without a cbk, syntask_new returns only after the task is complete.
Hence we don't have to wait on a conditional variable in the caller.
Change-Id: Ie83894aa6fc02cc3a973930e67ae2b35de3b7647
BUG: 767862
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2870
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8acf50b886ba296d351bb8e3025aac404fe65cec
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Mar 8 01:26:29 2012 +0530
cluster/afr: handle sending NULL dentry name for inode link in self-heal-daemon
* Without the dentry name, dentry cannot be created in inode_link, which
leads to trying to access the null dentry to check if it is cyclic and
thus segfault. So send the parent inode also NULL, which just returns
the proper inode after assigning the gfid and type to the inode without
trying to create dentry.
* Handle failures such as dentry_create returning NULL, in inode_link
properly and return NULL in such cases.
* Increase the lru limit of inode table of self-heal-daemon to 2048
Change-Id: I7ae0e0e9be279d1694b6aafb5e054585e43f03ff
BUG: 801149
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2893
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c41c3cd1527f1eb765bf1ff1d7c772be0453d1da
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Dec 14 16:06:21 2011 +0530
performance/read-ahead: cleanup xlator private data completely in fini.
Change-Id: I3bb143036557d7d3844dc825f6870140e414f85a
BUG: 767862
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/792
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6c817d7a4c40c791f312d3f0d5f0b8adbf055632
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Dec 14 15:47:01 2011 +0530
performance/quick-read: implement fini
Change-Id: I92d4e7ded470b0e97b699656a890bab8c113bf4f
BUG: 767862
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/790
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 39eacba0e6016a89d66019425c42fe72b30b989b
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 12 12:53:01 2012 +0530
mgmt/glusterd: provide an option to make a volume read-only
this can be triggered by "gluster volume set <VOLNAME> read-only on",
which adds read-only translator on server graph, thus making the
volume read-only.
Change-Id: Iee32e6b2f3022d16016534914a5198d1cd327e25
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 798877
Reviewed-on: http://review.gluster.com/2915
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2dbe4b5245b749ee5af025538bc874f434ebc0f0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 14 10:14:18 2012 +0530
performance/io-cache: store op_errno in page.
This will enable us to pass appropriate op_errno indicating EOF even
during cache-hits.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: Ib239b5de9b8fca2bd8eb5ec87c93f2cb1c11a99c
BUG: 795789
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2939
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8237f8a849e0da3d8088571080207d538becaae3
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Mar 14 14:16:08 2012 +0530
glusterd: Checked if peer is connected and 'handshaked' before sending updates
Change-Id: Ia57378d5c81b263d6fcbc9d54ccc7fb138d83d8e
BUG: 801731
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2941
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 04fc77c1535496970beb6c48cef35bef3231a2f6
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Mar 13 13:54:11 2012 +0530
distribute-rebalance: fix the logic of ENOENT handling
due to this, we were missing the entries from the last subvolume of
distribute for all the rebalance or remove-brick operations
Change-Id: I486f15c1d3d17cbf6f353f6179b2623af61f4868
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 770346
Reviewed-on: http://review.gluster.com/2933
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 66c406d3b65acd58d8058a2904001ec820982699
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Mar 13 17:26:13 2012 +0530
storage/posix: don't allow rmdir()/lookup() on HIDDEN_DIRECTORY
so that we won't even have a GFID set on the GFID dir itself.
Change-Id: I65be7d675a308f51f4c62a86499341412b20c47f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 802726
Reviewed-on: http://review.gluster.com/2936
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b4ce12940ff61f708002b635c4e6106017c81e90
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Mar 13 13:13:11 2012 +0530
rpc-lib/rpcsvc: nfs auth corrections
in comparing ip addresses during authentication,
we need to take only the ip address of the client
instead of the transport endpoint (ip:port).
Change-Id: If48eca37edea1d69deb150720fbaea0ea2443a00
BUG: 771845
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2929
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 39bf31c509c163c52a41dcb72768af4cbbefc558
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 12 18:07:09 2012 +0530
nfs: no need to recalculate the 'ino' from gfid
it is guaranteed to be sent properly from posix layer itself now
Change-Id: Ifbbf558f3bcfa609bf107a75c692003ca261ac0a
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 800831
Reviewed-on: http://review.gluster.com/2923
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f141ea61d1d3cbdf6768b38d5ccaa8838cb4dd9d
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed Mar 14 12:15:05 2012 +0530
glusterd: file perm change for glusterd.info
this is need for the vdsm gluster plugin, changing
glusterd.info file's permission to 644 from 600.
Change-Id: I9de39f1b8b31a6c2f448e2ff6601eb270d042343
BUG: 802217
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2940
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ea4461b9b783bd5ed2bf43a63c7dd391626c36a8
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Mar 9 09:38:36 2012 +0530
core, cli : Changes to statedump
This patch,
* Enables missing inodectx, fdctx dumpops for cli statedump command.
* Reintroduce changes introduced in statedump.c by 489a7a10 which were
overwritten by db20a0f8.
* Change strncasecmp() in gf_proc_dump_parse_set_option() to strcasecmp()
to properly parse similar options like fd-fdctx, inode-inodectx
Change-Id: I85ad854dce73048617b933d29cf360af9d0ed90a
BUG: 797788
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2914
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit a94e75bebca8b9111af0801492cbcb914ceae21f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 14 09:58:05 2012 +0530
features/marker: Nameless lookup related fixes
while filling a loc structure, marker should not error out if loc->name
is NULL or loc->path is just a gfid.
Change-Id: Ie3a9cffde2d17da0377f1e41de93b099a9133abe
BUG: 801364
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2938
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ed0237e875d5f64837b86efc901f230af7fb6c48
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Feb 27 12:41:24 2012 +0530
cli, glusterd, nfs: "volume status|profile|top" for nfs servers
Enables usage of volume monitoring operations "volume status", "volume top" and
"volume profile" for nfs servers. These operations can be performed on
nfs-servers by passing "nfs" as an option in cli. The output is similar to the
normal brick outputs for these commands.
The new syntaxes for the changed commands are as below,
#gluster volume profile <VOLNAME> {start|info|stop} [nfs]
#gluster volume top <VOLNAME> {[open|read|write|opendir|readdir [nfs]]
|[read-perf|write-perf [nfs|{bs <size> count <count>}]]}
[brick <brick>] [list-cnt <count>]
#gluster volume status [all | <VOLNAME> [nfs|<BRICK>]]
[detail|clients|mem|inode|fd|callpool]
Change-Id: Ia6eb50c60aecacf9b413d3ea993f4cdd90ec0e07
BUG: 795267
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2820
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit b4028450d348129ee44ee15f6be06a0097a29819
Author: Brian Foster <bfoster@redhat.com>
Date: Thu Mar 8 16:11:58 2012 -0500
system/posix-acl: fix reference counting in posix_acl_readdirp_cbk
unref. the acl pointers from posix_acl_get()
Change-Id: I1247f64ceded17bfa204d1b899ec56a27bef0cdb
Signed-off-by: Brian Foster <bfoster@redhat.com>
BUG: 801183
Reviewed-on: http://review.gluster.com/2904
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit ca93ce3f7d16448a02d4a75c2ed671fa149245f4
Author: Brian Foster <bfoster@redhat.com>
Date: Wed Mar 7 14:56:19 2012 -0500
system/posix-acl: fix acl inode assignment in posix_acl_readdirp_cbk
If an entry includes no ACL returned via dictionary, it is possible
to skip down to acl_set without updating acl_access and/or
acl_default. If either are set from the previous iteration, the
unrelated ACLs are set to the current entry. Use a single set of
pointers to ensure that valid ACLs are always set.
Change-Id: Ia94887ded91845bc39d4d5e95ef00d190681e517
BUG: 801183
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.com/2903
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit e6d887ec4ed6302f2a7dd2811bfc82f8cb46892d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Mar 10 00:54:12 2012 +0530
protocol/server: Remove connection from conf->conns w.o. race
1) Adding the connection to conf->conns used to
happen in conf->mutex, but removing happened under conn->lock.
Fixed that as below.
When the connection object is created conn's ref, bind_ref count
is set to '1'. For bind_ref ref/unref happens under conf->mutex
whenever server_connection_get, put is called.
When bind_ref goes to '0' connection object is removed from
conf->conns under conf->mutex. After it is removed from the list,
conn_unref is called outside the conf->mutex.
conn_ref/unref still happens under conn->lock.
2) Fixed races in server_connection_cleaup in grace_timer_handler
and server_setvolume.
Change-Id: Ie7b63b10f658af909a11c3327066667f5b7bd114
BUG: 801675
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2911
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 77e4c6914fb123668014fe752df8845d7cea76e4
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Tue Mar 13 16:48:58 2012 +0530
glusterd: Updates on members of cluster must include peer to-be friended
Updates about members of cluster must be sent to the peer to-be friended.
Change-Id: I56745885d75af7c609227ba8582da1bb07c1b894
BUG: 801731
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2934
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c18d7467c634d857a0213ce204b2f6c9b4ec6c8c
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Mar 5 19:04:49 2012 +0530
cli: More xml output changes
* Added xml output for "volume quota" which was missing.
* Fixed xml output for "volume info all" so that it contains only one xml
document
* Fixed no xml output for normal "volume status"
* Fixed normal output for "volume set"
Change-Id: I3d85b6800e428226f2970d669e38e4331c99a218
BUG: 799957
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2868
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 336027724eb0e61b67d24f15f066b08d00d9508e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Mar 12 14:22:01 2012 +0530
features/quota: store quota context even for the cases where loc.name is NULL
with name-less lookups, loc.name is NULL.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Change-Id: Ie3914924896c90a7fb7251cb0184c8e561ef7f4f
BUG: 801364
Reviewed-on: http://review.gluster.com/2917
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 196908d52e5e4cfa9c21eae615654302621ccb35
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri Mar 9 12:36:49 2012 +0530
core: Made lkowner_unparse use 'type-safe' format-specifier
Change-Id: Ibd39edb5fccef525f7f0929401f7329508c59ced
BUG: 767229
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2907
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8ec982a5360e6c77dc344ed48bfc5112cd6f27b7
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 12 18:28:31 2012 +0530
glusterfsd: handle a case of NULL dereference during rebalance
Change-Id: I9dbe1235f9b5eb7dd43c92bd46830ed9e5734768
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 801787
Reviewed-on: http://review.gluster.com/2924
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 89f2dd65a0b0757465819570bf5df801c18768e9
Author: Amar Tumballi <amarts@redhat.com>
Date: Sat Mar 10 19:59:07 2012 +0530
iobuf: add a counter to keep track of request misses
requests can be denied if the size of the request is higher than the
available sizes.
Change-Id: Id1bf2a56de799ccb94f3791899f2e33f68cd1e2b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 802047
Reviewed-on: http://review.gluster.com/2913
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 5ab5363d153abc1560e5176279240a869af73760
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 12 17:24:33 2012 +0530
glusterd: minor log fix in handle probe query
now prints the destination hostname instead of self.
Change-Id: If73158c36780d597a67ec9185d99083764966c04
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 802265
Reviewed-on: http://review.gluster.com/2920
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 93be1596cf7fbadd64e1b3e6b04d19b610174a95
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 12 13:00:45 2012 +0530
protocol/client: remove unused variables from 'priv/conf'
'last_sent', and 'last_recieved' variables were not used anymore
after having RPC layer. Hence removed it from the code.
Change-Id: I1ba74d47f909406ebde43476ccfed724e6c7e77f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 801721
Reviewed-on: http://review.gluster.com/2916
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3b9b9051e5c79b8e50cea9ffc1ea7b96d729ae66
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Feb 24 15:23:08 2012 +0530
cluster/afr: save the xattr obtained in the {f}xattrop_cbk in local
If the {f}xattrop operation succeeds on one of the subvolumes and fails
on another (thus the xattr dict obtained from the failed subvolume in
the callback will be NULL), then afr would be unwinding with op_ret = 0
(since the operation was successful on one subvolume), but the xattr dict
would be NULL (afr is not saving the xattr it has received in the callback
in its local structure and will send the xattr it has received in the last
callback). xlators above afr might segfault when they access the xattr since
they would have assumed that xattr would be present as op_ret is 0.
Change-Id: I50761a302150285f31dfdaa397f890c9370a989a
BUG: 797119
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2813
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a7c9cc92504a2ff6b140cca0c8b1149cbe6c0b94
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Mar 12 14:26:36 2012 +0530
glusterd: Peer(s) mustn't send updates about members not yet in cluster
Also, peerinfo is added to peers list synchoronous with the request triggering
it. This ensures that atmost one request sees that the peer (in question) is
not in peers list. Earlier, 'concurrent' handle_friend_update requests would
see that a particular peer is not in the peers list yet, as the addition of the
'peer' into the list happened asynchronously, on the 'connect' event of the
'peer'.
Change-Id: I6f017fb43079862fbe5ae7db8f9f4e4fefaa091d
BUG: 801731
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2918
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2b9868eae2affcf7604b0eee935de8c1234fbec2
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Feb 29 12:41:55 2012 +0530
cluster/stripe: Readdirp - send aggregated block_size in stat
Change-Id: Iee83a355ab767acac89b11d0a5add8527fc387a7
BUG: 797308
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2833
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit d771b89f3e7ce25ccc183f361b591a3cc718171e
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Mar 10 17:22:55 2012 +0530
Print non-zero timestamps in statedump
Change-Id: I686842bc0934128b825828066f613c2a6280ceb9
BUG: 801689
Reviewed-on: http://review.gluster.com/2912
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 5788cdddc2e242ad34176d152f98a5226a5e41a0
Author: M S Vishwanath Bhat <vishwanath@gluster.com>
Date: Sat Mar 10 15:51:22 2012 +0530
posix_fill_readdir: Using strcmp to compare GF_HIDDEN_PATH with entry->d_name instead of strncmp.
Change-Id: I29b6fc81213e52a697ed96559c3216c5512799ed
BUG: 802005
Signed-off-by: M S Vishwanath Bhat <vishwanath@gluster.com>
Reviewed-on: http://review.gluster.com/2910
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit ab770e853e4a27a89845bff1519dc36f7ca46d79
Author: krishna <ksriniva@redhat.com>
Date: Thu Mar 8 16:38:36 2012 +0530
nfs/nlm: logging NFS client IP address when FH->volume mapping fails or when resolve_and_resume fails.
Change-Id: Ia89113f46c1d7c9ed629e9dc0ff0779c41ed947f
BUG: 765259
Signed-off-by: krishna <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/2900
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f9269eb0f179fa82d005416655ca58228f81b7e9
Author: Mohammed Junaid <junaid@redhat.com>
Date: Fri Mar 9 12:44:05 2012 +0530
protocol/client: Register a timer(grace-timer) conditionally.
A grace timer is registered on a disconnect, but a reconnect timer sends a
connect request after every 3sec and if the server is down, the client protocol
receives disconnect and a grace timer will be registered which on timeout will
increase the lk-version value. Its enough to register the grace timer once after
the disconnect and later just ignore other psuedo disconnects.
Change-Id: I36a153aa86b350d87fe50d014ee0297f558a7fb6
BUG: 795386
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/2906
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e51097605ab545c88f14260d412c64f7de75ea46
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Feb 22 08:11:57 2012 +0530
glusterfsd: fix some option definitions
VOLUME_NAME used earlier in option definitions are confusing with
glusterd specific volumes. It should be translator name in volume
file.
Change-Id: Id4d86c8def65aa6ff1346ef49f8b20ea428de615
BUG: 788437
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/2789
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ee4d902dabad014e3a6141505c0d6c6d48094c81
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Mar 7 17:48:12 2012 +0530
features/locks: Make inodelk ref-counted
Ref when the object is allocated.
Unref after the response is submitted to that inodelk.
Ref when the lock is granted.
Unref when the lock is unlocked.
Change-Id: I2bfe9182b67bea7dc7b9d0ed9f99f1c7fa0b8a3c
BUG: 783449
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2891
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit aa589721db9143a96ebdb80d93e14ee606f4d609
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Mar 6 11:26:17 2012 +0530
nfs/server: allow deletion of files by default
this is needed for Micrsoft Windows-based Nfs clients
which do not ignore ACCESS3_DELETE permission not being
granted, while linux/unix systems ignore the same.
behaviour on linux/unix systems remains unchanged
Change-Id: I67f5f66a7486b93163aebedec5fbaa303173964e
BUG: 790781
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2875
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 398a03f69e48752ac33521f876d020cae41b100e
Author: krishna <ksriniva@redhat.com>
Date: Fri Mar 9 09:43:18 2012 +0530
nlm: support ipv4 only
Change-Id: I0d8381b7d4da0e961677cca63d6d2c82836c1632
BUG: 800735
Signed-off-by: krishna <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/2909
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0dffe9345b6153912d087f06da11827aea4fb041
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Mar 9 10:05:48 2012 +0530
cluster/dht: Replace ftruncate call with truncate in rebalance
ftruncate call seems to be broken as of now (marker).
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: Ib49ced0471e1b8e9ee411eb5a9ff1b83c4d82bec
BUG: 801658
Reviewed-on: http://review.gluster.com/2905
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 7d963dbcfd215273cee91cfbb1adbed998c2efb2
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Mar 8 22:17:46 2012 +0530
syncop: Make syntask scalable
At the moment, synctask uses task->frame to perform
all the syncops, this will lead to high-memory usage if the task
crawls millions of directories. i.e millions of STACK_WINDS/UNWINDS.
To prevent this, in each task a new stack is created to perform
the fops which is reset after every syncop.
Change-Id: I53c262ec348be9b1d91af73da01f1c217f31ce6e
BUG: 798907
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2850
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit b069ec63c05e1ff70ea0a2a42faad58394177920
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 7 21:02:16 2012 +0530
performance/io-cache: pass appropriate op_errno even during successful reads.
An op_errno equal to ENOENT with op_ret equal to zero is used by
storage/posix xlator to indicate EOF. NFS relies on this protocol
for correct functioning.
Change-Id: I136fbf429a829bd7bd75ce8ce236f9557a418a5d
BUG: 795789
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2894
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a19d79855affee454015701fd4ee1da5cb983843
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Mar 8 07:45:15 2012 +0530
performance/io-cache: move mem-pool initialisation to init.
mem-pool is global structure which is stored in ioc-inode-table and hence
can be initialised in init.
Change-Id: I4bc88fe3e8c729312e41f62c98f665af5fb26a62
BUG: 765340
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2895
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f8c81914224b9d31eb4b7028e9c03c5c157decde
Author: Venky Shankar <vshankar@redhat.com>
Date: Thu Mar 8 14:51:02 2012 +0530
xlator/lib: fix spurious STACK_UNWIND
Change-Id: If37eba97710fc79713f70c4117015d49f93ad137
BUG: 801285
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/2898
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 24c0eab598b558c53c15011475b01c8ff9ca1e91
Author: M S Vishwanath Bhat <vishwanath@gluster.com>
Date: Fri Feb 24 13:18:56 2012 +0530
renaming hdfs -> glusterfs-hadoop
Change-Id: Ibb937af1231f6bbed9a2d4eaeabc6e9d4000887f
BUG: 797064
Signed-off-by: M S Vishwanath Bhat <vishwanath@gluster.com>
Reviewed-on: http://review.gluster.com/2811
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 856a7ddf6bcd885b3d1769a44c85bb0144471ea4
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Mar 7 05:29:41 2012 +0100
cleanup and fix xattr namespace flip
- function of actual flipping made static
- clean out references to particular namespaces from flipping logic
- namespaces involved in flipping defined at single location
- fix fnmatch(3) invocation with reversed pattern and string arguments
- instead of "user", use "system" to flip from, because latter is
free from supervision of the VFS layer (cf. attr(5))
Change-Id: I3cc5836fadcad5b237fd5c67d0dcaea63aee9164
BUG: 798716
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/2890
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 2edd31b5f0e8e6f19ae211cd36bd77ca474f95f0
Author: shishirng <shishirng@gluster.com>
Date: Tue Mar 6 18:55:37 2012 +0530
glusterd/rebalance: Bring in support for parallel rebalance
This patch, enables rebalance processes to be started on all
nodes where the volume is spread across (1 process per node)
node-uuid xattr identifies which node takes ownership of the
task to migrate the file. The model employed is push (src pushes
to dst)
Change-Id: Ieacd46a6216cf6ded841bbaebd10cfaea51c16d6
BUG: 763844
Signed-off-by: shishirng <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2873
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 5727a7cd609bcb5de77ee6cf182fdddbe31bf054
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 7 17:34:37 2012 +0530
features/marker: GFID file handle based backend related fixes
* make sure loc->gfid is filled.
Change-Id: I5304e650d9fc181ee1f3b65be7f2ff3847d9722e
BUG: 790389
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/2888
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 273cec9b96b55053d80b960c9bd50a717af27144
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Sun Mar 4 00:01:17 2012 +0530
glusterd: Append internal mount logs of clear-locks command to a single file
To ensure logs of all clear-locks commands executed from a
'peer' (glusterd) are in one place.
Change-Id: I9f531a1e24d4502769740010da73b3d4adb5c5c9
BUG: 799267
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2861
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 75b45158a028ae813865b1982d74990ba3d72c6f
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Mar 7 15:13:04 2012 +0530
cluster/distribute: fix log level of few messages
Change-Id: Ibdeeb705e75a94bb96a1ae259be32ddd2ca5fec8
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 797715
Reviewed-on: http://review.gluster.com/2885
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 51c115e7a1c639ee0a426181f4860166df2c20c3
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Mar 7 23:45:47 2012 +0530
libglusterfs/fd: fixed fd_anonymous() leak
fd was getting leaked whenever there was a overlapping operations,
which caused memory leak, and process fd leaks, which made most of
the operations on NFS mount of a replicate volume not work. With
the fix, things are back to normal.
Change-Id: I2d2158b2972ba5dae270d6ff7b1a827403653c04
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 787368
Reviewed-on: http://review.gluster.com/2892
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b72b2bf4e28583d8aeedb9cfc41d425e444d908e
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Mar 7 00:19:29 2012 +0530
protocol/client: Added lk_ctx info in fdctx dump
- Added a brief explanation as to why we can't use gf_log
when in statedump.
- Removed gf_log messages from client_priv_dump since
it can cause a 'deadlock' - See statedump.c for explanation
- Added try-lock based accessors for fd_lk_list for dump purposes.
Change-Id: I1d755a4ef2c568acf22fb8c4ab0a33a4f5fd07b4
BUG: 789858
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2882
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8a094f1f628d67d1424c5e32ad617cf47e81c861
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 5 23:54:51 2012 +0530
cluster/distribute: send proper 'dict' in readdirp()
if we do the STACK_WIND from readdirp_cbk(), we were not sending
the right dictionary which made our linkfile determination a
failure.
Change-Id: Ie3f26748608f1a81123fe475d8a42bf2717475c3
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 799887
Reviewed-on: http://review.gluster.com/2869
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 00462feab095b23c22a8e208c868e1e6d63a1ce5
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Mar 7 16:03:32 2012 +0530
protocol/client: Free readdirp xdr leak
Change-Id: I5e46deedd93e852a483693de42e4bec0082bc08b
BUG: 796186
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2886
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 94ef9bb29f0819f3a5a60f817fd19d9f87424f20
Author: Mohammed Junaid <junaid@redhat.com>
Date: Wed Mar 7 14:16:07 2012 +0530
nfs: fcntl lock self healing.
Change-Id: Ic3e00e8ea3b873acbc3abb5155aecdaac848a3e5
BUG: 795386
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/2884
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
commit 8a9856d0cfded7640f63298ee2a0b839d6e60adb
Author: krishna <ksriniva@redhat.com>
Date: Tue Mar 6 15:52:34 2012 +0530
nlm: call nlm4_cancel_fd_resume instead of nlm4_unlock_fd_resume when CANCEL proc is called.
Change-Id: Id4c74165f24cccb46ca5de406dd7e47e4a8b99e1
BUG: 798222
Signed-off-by: krishna <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/2877
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f1ff611aa17a5b376c9f50d00bcc08e831e2b07c
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Mar 7 00:30:17 2012 +0530
xlator/lib: Drain out sent requests to avoid multiple STACK_UNWINDs
Change-Id: If28e4b6e157ac0cb9e1f325bbba39f6c3f1c2b45
BUG: 789078
Reviewed-on: http://review.gluster.com/2881
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d23336c24c48d6e288670291d007d34045abd303
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Mar 5 16:05:12 2012 +0530
glusterfsd: Don't reconfigure if process does not know volfile server
Change-Id: I09e5527bb1496e0029d73f08dd7892d74df93084
BUG: 799882
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2865
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 98934cf9f017d33dda23821972f3ade9c03a9e17
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Mar 2 13:26:36 2012 +0530
cluster/afr: handle node failures in lookup
When a transaction is in progress lookup depends on inode ctx
for read-child. If the lookup fails on the read-child while
another transaction is in progress, it should select the
read-child as the next success_child which is in fresh_children.
Change-Id: I33a04b102966b63a64bacf8d2e29f0d0119fdac6
BUG: 773225
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2858
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 071ab6a27bc1538fe98e7a192b83b8e873ace8d5
Author: Rahul C S <rahulcs@redhat.com>
Date: Thu Feb 23 16:51:59 2012 +0530
cli: Fix volume statedump cli output typo
Change-Id: I1363123d13fa4364e917344fdd928ac48b85326c
BUG: 796617
Signed-off-by: Rahul C S <rahulcs@redhat.com>
Reviewed-on: http://review.gluster.com/2807
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 606bf36de917ee539d14e02ddc143b6a4f201111
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Feb 27 16:08:56 2012 +0530
glusterd: Rename nodes in "volume set help-xml" output
Change-Id: I44bbfb6e78a459783d7d5bbccda6bbbd3ec1e391
BUG: 791054
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2823
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 20be03b31711e766ac68bde25c8af4ae5ea8b3bf
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Mar 1 12:34:56 2012 +0530
cluster/afr: Reset re-usable sh args in sh_*_done
The bug is observed due to stale value of active_sink count
set in metadata self-heal.
Change-Id: I41996999213c323c0f4d4db575d87b2d0b4b3fec
BUG: 798874
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2849
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit fbf71789fc7a4029be8b6f3646fad4a7d8a4ab4a
Author: Amar Tumballi <amarts@redhat.com>
Date: Mon Mar 5 14:17:57 2012 +0530
rpc-clnt: print xid of the saved frames getting unwind
so that one can match the corresponding submit failed errors in
brick logs
Change-Id: I4422805a20c251aeffb51d63572c251176b2620c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 799337
Reviewed-on: http://review.gluster.com/2864
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: M S Vishwanath Bhat <vishwanath@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d651b50ea858b0a26baf6a356d7312b892bf62eb
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed Feb 29 15:16:53 2012 +0530
fops/removexattr: prevent users from removing glusterfs xattrs
* Each xlator prevents the user from removing xlator-specific
xattrs like trusted.gfid by handling it in respective removexattr
functions.
* For xlators which did not define remove and fremovexattr,
the functions have been implemented with appropriate checks.
xlator | fops-added
_______________|__________________________
|
1. stripe | removexattr and fremovexattr
2. quota | removexattr and fremovexattr
Change-Id: I98e22109717978134378bc75b2eca83fefb2abba
BUG: 783525
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2836
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit e08d1a79073d4746d7d55f1f3202848aba0f9f6c
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Feb 29 10:20:54 2012 +0100
glusterd: mountbroker-geo-replication.* fix
mountbroker-geo-replication.* option's value was always
discarded due to bogus control flow
Change-Id: I5ec57dd0db9502ba088c42e07e32ac3e15317ce5
BUG: 797702
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/2835
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit ed8b92ad3948edb896a2dc094f00d04eddf9d9f9
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Feb 29 10:21:03 2012 +0100
geo-rep / syncdaemon: determine suitable xattr namespace based on privilege
Change-Id: I91fe16d7e5e4c21f138eab4ee0b9334aec40e41b
BUG: 765433
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/2838
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
commit 320d5c9ad46e3cbaaf80354bb9a57c2638126551
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Mar 4 23:45:26 2012 +0530
glusterfsd: Unref iobuf after using it
Change-Id: Ieefc08d9af2125fabc2a86e5ff3a933aec539da0
BUG: 799882
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2866
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 454d9f17bdf5060f08c6abaaa86b4fb1ad370b0f
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Mar 3 00:01:23 2012 -0800
Revert "afr: [Un]Set the 'right' lkowner for [f]{inode|entry}_lk and the 'enclosed' fop."
This reverts commit 2e80fdbeb6abbb23ff6789c2b98c82704883af0a.
Change-Id: I417fd43e4195d63e5b8b83dd3beb712887130e1e
Reviewed-on: http://review.gluster.com/2860
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7edae84060a595f35fd89fdefbf12e0b311364de
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Mar 1 00:17:21 2012 +0530
Refactor xlator/lib for better readability & maintainability.
Change-Id: I6468462ae2bbc05c1dd6c2aea66b440aa7cfdd09
BUG: 789078
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2845
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 4dc9c2ba1f200e103f98f2bbb7e52845da4bae55
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Mar 2 15:34:51 2012 +0530
cluster/afr: copy the parent's gfid from child loc while building parent loc
Suppose the process is not a fuse or nfs mounted client, and some other process
such as rebalance, then after lookups inode would not be linked to the inode
table (since the inode was created for rebalance purpose only), thus keeping
inode's gfid NULL.
And afr while building the parent loc using child loc, does not copy the
pargfid present in child'd loc structure. protocol/client will search for
the gfid either in loc or in loc->inode and assert if it cannot find the
gfid in either of them.
Change-Id: I882e449fb8b79d5c69e4a942abcd844dc4d5d30c
BUG: 799262
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2857
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit 4959a1ce343cd9a82b34115073d4f39c06a9109c
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Mar 2 00:54:12 2012 +0530
Fix memory leaks found in readdir
Change-Id: I0e221e4de9ee12586b09cd8bf7f394e9d4b88a11
BUG: 765785
Reviewed-on: http://review.gluster.com/2853
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d42f8730ec79265c2ea8cdfd455820981f8994e6
Author: Mohammed Junaid <junaid@redhat.com>
Date: Thu Mar 1 22:34:59 2012 +0530
protocol/client: Calling GF_FREE on memory allocated via GF_CALLOC.
This is a temporary fix. A clean fix would be to allocate memory using mem_get0
and free via mem_put.
Change-Id: I6351ab22c2f05ba8fa4aaad67f375027df873807
BUG: 796656
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/2852
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 7af4e813f49b896e6734a81f0b2e0c1e9b501ef5
Author: Csaba Henk <csaba@redhat.com>
Date: Wed Feb 29 10:21:09 2012 +0100
geo-rep / syncdaemon: make the timeout for establishing the connection to slave configurable
It can be set through the connection-timeout tunable but we keep it hidden,
intended as a workaround for some special scenarios not for general use.
Change-Id: I31f9fa3873afa7babc2106ee34484123a01bdc57
BUG: 789078
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/2839
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 89ca95c0a8d16e9509cc0ca839c6b7316206a503
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Feb 21 22:06:29 2012 +0530
cluster/afr: Add new option to know which process it is in
Afr xl needs to maintain inode-table inside the xl if it is in
self-heal-daemon. The code was depending on the option
self-heal-daemon to do this. This is wrong as the option can be
reconfigured to on/off. Added a new option which can't be
reconfigured for this purpose.
Change-Id: Idc42c403c4bd9b73d1f328427ae4158ff1420b3a
BUG: 795741
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2787
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 56e32aaa658622af10be2b2bead1a5177bb3733e
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Feb 23 14:46:04 2012 +0530
protocol/server: Make conn object ref-counted
Change-Id: I992a7f8a75edfe7d75afaa1abe0ad45e8f351c8b
BUG: 796581
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2806
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 67fa02e8bc0f531a5811db922e7481dc20bfe01e
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Feb 29 19:25:30 2012 +0530
hdfs/plugin: Fix regex for parsing pathinfo string
Change-Id: I3a5d78f39a15c8029cd40225013e9ac40beb9373
BUG: 797116
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/2844
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6bd071142287aa70d12b1363ec7f792d4069d568
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Feb 27 11:15:51 2012 +0530
cluster/afr: Handle errors in build_parent_loc
BUG: 787671
Change-Id: I0b01b0f9e14a26d757748413dd71909e915c7573
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2826
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 009ef9834ad9798b1a81a9826bb4d7e8011044cb
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Tue Feb 14 21:27:10 2012 +0530
afr: [Un]Set the 'right' lkowner for [f]{inode|entry}_lk and the 'enclosed' fop.
afr 'mangles' the lkowner inorder to ensure [f]inodelk/[f]entrylk fops from the
same application contend. But other fops that are 'visible' to the application
should operate with the lkowner provided by fuse for correct functioning of
posix-locks xlator.
Change-Id: I7e71f35ae7df2a070f1f46d4fc77eed26a717673
BUG: 790743
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2752
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 5f02e6b51b38521d77e75e6cc56f43a7b44b528f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Feb 29 16:31:18 2012 +0530
cluster/afr: Hardlink Self-heal
Change-Id: Iea0b38011edbc7fc9d75a95d1775139a5234e514
BUG: 765391
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2841
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9850de0a61c1d6c1c667b1ff3525a474bb729ba2
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Mar 1 12:18:48 2012 +0530
glusterd: Changed clear-locks cmd to use trusted-volfile for its internal mount
Change-Id: Iba8add1802832d4fa7082bc6a68eee966ddc508b
BUG: 798127
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2846
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 68936e8b353dac5f9cdecccb15b50e18b186c72e
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Mar 1 12:20:08 2012 +0530
cluster/rebalance: Fix expression in check_free_space
Migration should fail if available space in dst < src
The expression was evaluating otherwise
Change-Id: Ief64ad8797e405d0cdc787eef49bfbf4051dffac
BUG: 798864
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2847
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 208313fa5eddb12491d239ba7cee2dd122339617
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Feb 29 23:23:54 2012 +0530
mgmt/glusterd: do not close the same fd twice
In volfile generation part, if the close on the file stream for
the volfile fails, then we should not again close the same file
stream which may lead to undefined behavior.
Change-Id: Idec00955eea11d5b2ea74574f8d4e53fa80c220a
BUG: 798599
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2843
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 95a7fc0da112a5c71c016eb85bbd0dc66b838a74
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Mar 1 00:35:36 2012 +0530
perf/md-cache: hold lock on modification of md_cache structure
as it is possible that multiple fops can alter the content of
md-cache structure from inode-ctx, we need to safe-guard the
issue of corruption due to race conditions.
Change-Id: Iea051f8f6adff7690d6d60f3cf82eda75150b449
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 798179
Reviewed-on: http://review.gluster.com/2834
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit abd7621b92cf003b611366e957978e09006c2d48
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Feb 29 16:06:25 2012 +0530
cluster/stripe: Send xattr request in lookup even when type is INVAL
Change-Id: I6f66b5aa39eaa5eadca2a91b1d4e948490f0aa06
BUG: 798161
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2837
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit f7260e0ec606b7a24eeb94053b49d8e71c343523
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed Feb 29 16:16:12 2012 +0530
nfs: prevent crash during cthon lock test
When cthon was invoked to test nlm, the mount point
would hang, and crash nfs server, and all the brick
processes. This path fixes the crashes.
Change-Id: Ide88adb7e25ea722b143bfd62e23361ff7be4b67
BUG: 798194
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2842
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c308e8555b4a0c349dfb32f73c6d3bbac2a19ec7
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Feb 28 09:27:32 2012 +0530
libglusterfs: Handle loc_copy for nameless loc
BUG: 787671
Change-Id: I7601f482ae753ead83be16d1df33c2187e76dc5c
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2825
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2355fe8d4251949e014885785ab223183d453d07
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Feb 28 15:27:24 2012 +0530
protocol/client: send unique key to server during handshake
utilize the graph->id for making the key unique.
Change-Id: I0c1b355aa901af88e65fd12cb9e0535318856867
BUG: 783982
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/2831
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Mohammed Junaid <junaid@redhat.com>
commit 491239dd6c8c86d26043500394ec6033d7c6aab4
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Feb 28 12:57:26 2012 +0530
nfs/doc: corrections
corrections in nfs configuration helpers displayed
with "gluster volume set help".
Change-Id: Iffc0d10eacbaea647270cd875d4cbd5f80333671
BUG: 771876
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2829
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3572e8739bc40eb3f37918927fda157da05e3fd4
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed Feb 22 14:51:53 2012 +0530
transport/socket: configuring tcp window-size
Till now, send and recieve buffer window sizes for sockets
were set to a default glusterfs-specific value.
Linux's default window sizes have been found to be better
w.r.t performance, and hence, no more setting it to any
default value.
However, if one wishes, there's the new configuration option:
network.tcp-window-size <sane_size>
which takes a size value (int or human readable) and will set
the window size of sockets for both clients and servers.
Nfs clients will also be updated with the same.
Change-Id: I841479bbaea791b01086c42f58401ed297ff16ea
BUG: 795635
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2821
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 65eb76d730bfad0e2b4aaaea09aee9a7cd7737e1
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Feb 28 18:03:29 2012 +0530
storage/posix: In lookup check for buf->gfid being NULL
There are few cases where create and lookup race.
Lookup ends up getting a valid struct iatt, but with no gfid set.
We need to check for gfid being 0, and handle it as an error.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: I36ae1978b325aff964cbc3b24730c1e993666267
BUG: 797167
Reviewed-on: http://review.gluster.com/2832
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a370416eefd07117afed7066c6968e0c2e8e18db
Author: Csaba Henk <csaba@redhat.com>
Date: Mon Feb 27 05:41:11 2012 +0100
glusterd/mountbroker: fix handling of MEET mountbroker keyword
Change-Id: I5331a17a772e9ef15e132b9f335e5ff9d70735b7
BUG: 765214
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/2817
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d078d6bfe793a5b7757fe9362d2e5380830d2e4e
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri Feb 24 14:59:43 2012 +0530
locks/glusterd: Fixed clearing of posix locks from failing always.
Change-Id: Ieaf636c6f0d2aa1d001143a2d1433fce85dc8c7a
BUG: 797042
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2812
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 307f8a567dc1ebdcfd357bb2d32a8180fd6d9d96
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Feb 24 15:25:06 2012 +0530
mgmt/glusterd: pass defrag_cmd in rsp dict for volume info
glusterd_import_volinfo used to error out as it was not able
to find the rebalance key in the dict
Change-Id: Ife35a041072a8a978d7595e8381f68e624bd8da3
BUG: 797105
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2814
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a07d5558c4ad1c2cefca0b2f5777b3b69f55489d
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu Feb 23 12:53:19 2012 +0530
mempool: add more counters to understand the usage scenarios properly
current design of mempool is to fallback to standard calloc/free if
all the buffers in pool are exhausted. Understanding more about those
numbers will help us to tune mempool parameters properly over time.
Change-Id: I2c94373186f7c6a486caff2611c2d9df2c37db3c
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 797730
Reviewed-on: http://review.gluster.com/2804
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b50bb30280bce7751a3de40af405e3994e073beb
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Feb 23 22:58:44 2012 +0530
glusterfsd: unref the dict and free the memory to avoid memleak
Change-Id: Ib7a1f8cbab039fefb73dc35560a035d5688b0e32
BUG: 796186
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2808
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f0a299a5ea66952de91db03577d9cd8f3217f669
Author: Kaushal M <kaushal@redhat.com>
Date: Mon Feb 27 15:34:11 2012 +0530
cli: Fix broken "volume set help/help-xml"
Change-Id: I4e71e67f32ff37cfe23bc77c0e27645ac495a247
BUG: 796040
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2822
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 73f2f3b342e998e933a1f84b9d89bbf65d14d77b
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Feb 26 22:16:59 2012 +0530
cli: Add 'exit' command.
Based on request at:
http://community.gluster.org/i/make-cli-understand-command-exit/
Change-Id: I9116236a8c2f7767c88672b8d3d6565906bfc61f
BUG: 797551
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2815
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 09ddd21593a6554589087d4e11e29871c3b89c49
Author: Csaba Henk <csaba@redhat.com>
Date: Mon Feb 27 05:40:58 2012 +0100
libglusterfs: fix GF_FREE
Argument-taking macros should be possible to use with
same syntax that of C functions. In particular (assuming
FOO is a single-argument macro),
FOO(bar)
should break and
if (cond)
FOO(bar);
else
baz();
should compile.
Change-Id: If852c128a7317dc0dda1c669be7c6af40501e48d
BUG: 762061
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/2816
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit bdf53eaa0a6c2bdd1b7deacf27131fd2d03868a7
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Dec 15 17:38:05 2011 +0530
locks: Made dump locks formatting more 'readable'.
Also,
Added inode's path to dump locks.
Added basename to entrylk dump output.
Added whence field of range locks to dump output.
Change-Id: Ifd3f8b585a52de7ff68cd54506619ac3eaedeecc
BUG: 789858
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/798
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f5fc5cfec045de20d6eb027e038ed1ad6ac63b3b
Author: Shylesh Kumar <shylesh@gluster.com>
Date: Thu Feb 23 14:59:36 2012 +0530
Change rebalance log file name
Log file name for the rebalance process should
be <volname>-rebalance.log
Change-Id: I1ed169cdc92b11058b80360086b3c1f7618064ef
BUG: 795714
Signed-off-by: Shylesh Kumar <shylesh@gluster.com>
Reviewed-on: http://review.gluster.com/2805
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit ce9d421562b5955e0c5f468d6f0d30e36ed9be00
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Feb 22 19:38:14 2012 +0530
glusterd: Modified server graph to have index xl above pump
Index xlator needs a resolved inode in the incoming xattrop request to perform
its indexing. In the case of replace-brick pump xlator doesn't resolve the
inode in the (fop) requests it sends 'downwards', leading to null gfid sent to
index xlator.
Change-Id: I6b6e7af4354670616bf342292df1a25c219dd9e9
BUG: 796171
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2801
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit 29b4fe566f8cdf0833b56794624fbfa5381e0fc3
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Feb 21 14:23:13 2012 +0530
Introduce new extended attribute: node-uuid
Request for trusted.glusterfs.node-uuid returns pathinfo
like string but containing the UUID of glusterd instead
of the backend path for the requested file. This info
is benificial for tasks like parallel rebalance that will
make use of the UUID for data locality.
Change-Id: I766a09cc4a5f63aebd11c73107924a1b29242dcf
BUG: 772610
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/2614
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8c30e52a9d11ba73fddcae84beba7b4a75d9730a
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Feb 23 12:24:08 2012 +0530
protocol/client: Pass correct dict in client_readdirp
Also, alloc entry->dict before calling unserialize to it.
Change-Id: I8a9db93afd6e95e75307467cd654805780d7b467
BUG: 796534
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2803
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b500a6f32785f5d72c9042fd2f86e441d4c68efc
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Feb 22 16:08:26 2012 +0530
build: Changes to specfile for correctness and package relevance.
- Removes a stale dependency of glusterfs-client on glusterfs-core
- Server specific shared libraries included in glusterfs-server package.
Change-Id: I852304e6351a9a7864b2049f603e11f6a5601ffb
BUG: 764702
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2797
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 875e079d449defaef0aa657b80d8ff4d4db24ca2
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Feb 23 01:25:47 2012 +0530
features/marker: Use loc.inode to obtain parent if loc.parent isn't set.
Change-Id: I89dddb19168a3ffb269afc9f6bcb2d7e7c9a69cd
BUG: 790389
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2802
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
commit d95a9066ac55611981bf3c38253c5193ff6712f5
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Feb 22 08:30:47 2012 +0530
glusterfsd: give out the error on screen when cmd is given without options
'glusterfs' cmd would take default options when no option is given,
but sometimes default option may not work, in that case, we need
to provide usage output
Change-Id: I2ebd342890da11d2afaa0a23ee3a01d87694ff28
BUG: 791198
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/2790
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit fe2dd8a90fc9050a560156cc4d277a5883337da6
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Feb 22 18:27:15 2012 +0530
glusterfsd: unref the dict and use dict_set_dynstr to avoid memleak
Unref the new dict and use proper dict api (dict_set_dynstr) to save
data for displaying volume status information, which otherwise leads
to memory leak in the process.
Change-Id: Icb9ceb1a867c5b9759211a67027d983ab9b7e1c2
BUG: 796186
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2799
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6d138ffc2c07922a937304ed4775fc50724b0fe4
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Feb 22 14:38:42 2012 +0530
cli: print the type of the inode in gluster volume status inode output
Instead of a number print the type of the inode in the output of
gluster volume status inode. This is what the output symbols indicate.
R -----> Regular file
D -----> Directory
L -----> symbolic Link
B -----> Block special device
C -----> Character special device
F -----> FIFO
S -----> Socket
I -----> Invalid inode type
Also supress a warning message displayed at the time of build.
Change-Id: I5a2adfe044ce21d9da159652d4b6e25cd0a2fdca
BUG: 796078
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2794
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bb084bd8623de054e068525a3d7b6e407c1d7fe1
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Feb 22 18:35:07 2012 +0530
protocol/client: Print correct error message
Change-Id: Ic68626c4a205cd78b60831aa7bd838b6d8824fa1
BUG: 796195
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2800
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0e305649874540bc226d9caa3ea2b18f19d33290
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Feb 21 16:55:28 2012 +0530
mempool: adjustments in pool sizes
* while creating 'rpc_clnt', the caller knows what would be the ideal
load on it, so an extra argument to set some pool sizes
* while creating 'rpcsvc', the caller knows what would be the ideal
load of it, so an extra argument to set request pool size
* cli memory footprint is reduced
Change-Id: Ie245216525b450e3373ef55b654b4cd30741347f
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 765336
Reviewed-on: http://review.gluster.com/2784
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3a6b8b346f07700117dd44250de117d5d66731cf
Author: Amar Tumballi <amarts@redhat.com>
Date: Wed Feb 22 17:27:59 2012 +0530
mount.glusterfs: multiple fixes
* fix return value in case of proper 'backup-volfile-server' option,
and actual default server based mount failed.
* fix a syntax error (bug: 796050)
Change-Id: I6a530c9b9431e46f45ec9eeb99f6103386dd10dc
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 796101
Reviewed-on: http://review.gluster.com/2798
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bf3c3181b369762195afb3558ca0a4281d6e2532
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Feb 22 15:06:23 2012 +0530
cluster/stripe: Readdirp should call lookup on entries
We were calling stat on each entry. Also, the inode ctx
needs to be populated with the stripe_fd_ctx_t.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: Ibaafa360f22b551d1609041f13a4339e22c95645
BUG: 795669
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2795
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 3d87b5c175423575c6c92d94432ec93d91758c1f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Feb 2 19:17:12 2012 +0530
cluster/afr: Don't trust the fd returned in open_cbk
Change-Id: Id7d85a38875e3675904fc134e54e723c6a0c4de2
BUG: 786766
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2792
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b178f265c577338cc4f13f9667d2273c8c354f35
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Feb 22 13:46:37 2012 +0530
features/locks: Don't access free'd memory
Change-Id: I4e22ede84622f2c9c46cc0bc9f17bef73afa815c
BUG: 796069
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2791
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a933d32a8876a9729aff5e60dc74e48b08c7647f
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Feb 22 15:07:03 2012 +0530
pump: Fixed undefined reference to fill_loc_info fn.
Changed function to pump_fill_loc_info since its use is relevant
only in pump's context.
Change-Id: I5be1a908f88328f732dacfd7eac18f0c62f49eb8
BUG: 796066
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2796
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8d23dd28074445e7dd9e176bc222b7da45e4f58c
Author: Harshavardhana <fharshav@redhat.com>
Date: Tue Feb 21 10:45:32 2012 -0800
libglusterfs/options: Cleanup xlator percent_sizet code.
Change-Id: I1a39252d6c26f7e30b77ef682b8b3cdcde8a4a51
BUG: 769691
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/2619
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit e1ab0e91130aa48bd1125f0cec2eb14841eaccaa
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Feb 21 18:12:41 2012 +0530
features/index: Set correct ret value in index_add
Change-Id: I6314ea25ef26920593a3113eb2951d18255db34f
BUG: 763820
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2786
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 043115dfb3bc212868585a75a5d1f5538c5c5b8a
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Feb 21 23:35:05 2012 +0530
build: More rpmbuild friendly changes
Change-Id: I7dcd5c6461bbddde3bcc3d2519777e4c8889fe52
BUG: 764702
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2788
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9e02a4c90860831ccc4f83e1a2075f4a9c81ebbc
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Feb 21 17:35:31 2012 +0530
build: rpmbuild friendly changes
Change-Id: Ia1299d4404da0bd6787516924ebadcf9d6e021d1
BUG: 764702
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2785
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a37835499e758d24bb5dd5ade398c3fe6151c018
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Feb 21 13:39:29 2012 +0530
glusterd/auth: 3.2.x compatibility
volumes created with GlusterFS 3.2.x will be compatible
with GlusterFS 3.3 w.r.t auth.allow enhancements
Change-Id: I615e46d648e1270a7b856cd71fab24cfe791ddb8
BUG: 795634
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2779
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit eaa59ba63a98802536d580583e746d183b540752
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Feb 21 14:46:05 2012 +0530
features/index: Fix fd leak
Change-Id: Ib01d03999b099369674495ce500f48d492758f91
BUG: 763820
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2781
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 30952f2647f4be52c1bb11483de1bd888f9a1955
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Feb 21 11:25:07 2012 +0530
libglusterfs: Warn on missing _cbk calls in xlator
Change-Id: I44684b5eeca3674ed8d5b7b0120699bb3767e38d
BUG: 763820
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2782
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 849bf53042750e02002b50c8c8f6ab752edaedf9
Author: Kaushal M <kaushal@redhat.com>
Date: Fri Feb 17 12:32:18 2012 +0530
cli, glusterfsd: Fixes for "volume top {read,write}-perf"
Changed variables to use unsigned types, to support larger comninations of
block_size * block_count
Also increases cli time out for "volume top" ops to 600, to allow more time
for glusterd to return the results to cli.
Change-Id: I4b953799c78a5a184311f6f8c4a7a99dc9e87a07
BUG: 783980
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2761
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ab0774cbf67567ff4a8f697cadc969d0ea4765f6
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Feb 21 14:47:48 2012 +0530
core: utilize mempool for frame->local allocations
in each translator, which uses 'frame->local', we are using
GF_CALLOC/GF_FREE, which would be costly considering the
number of allocation happening in a lifetime of 'fop'. It
would be good to utilize the mem pool framework for xlator's
local structures, so there is no allocation overhead.
Change-Id: Ida6e65039a24d9c219b380aa1c3559f36046dc94
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 765336
Reviewed-on: http://review.gluster.com/2772
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit ea25c2e41c3574a5db67cea757fcdbe965e04cc2
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 17 17:22:59 2012 +0530
cluster/distribute: send the right 'dict' for check_is_linkfile()
earlier we were using 'check_is_linkfile_wo_dict()' for readdirp_cbk(),
which is no more required now.
Change-Id: I52295e08f8c494b7a081cfc684164a7f72562d0d
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 794641
Reviewed-on: http://review.gluster.com/2763
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 41ffc5ef53478b4e01f91730ede3cc4872f6c7cc
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Feb 21 11:18:32 2012 +0530
features/index: Add release, releasedir cbks
Change-Id: Ice45a0b4e953e270273aa4155a895d6ec033fda8
BUG: 763820
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2780
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 16575cdf30ce6db52d5c859d32f912096f892cb1
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Feb 21 15:50:35 2012 +0530
features/md-cache: Change strdup to gf_strdup
Change-Id: Ic96e7d38b988efab49f723c9d1d46f65037a84ed
BUG: 795682
Reviewed-on: http://review.gluster.com/2783
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0493fc6f99580d6b5f6aa463d2121a224ab2251d
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Jan 10 17:42:24 2012 -0500
Honor O_SYNC etc. properly.
Change-Id: I3dd90fe230386ad5571c5e639f27460e3d003f0e
BUG: 773100
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/2626
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 6ccad8ce563cd7db87991d95314fc1c8f002f91f
Author: Amar Tumballi <amarts@redhat.com>
Date: Tue Feb 21 15:02:39 2012 +0530
rpc/clnt: handle PARENT_DOWN event appropriately
Change-Id: I4644e944bad4d240d16de47786b9fa277333dba4
BUG: 767862
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: http://review.gluster.com/2735
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2e6eff0fd9045686f990ae0211f02f0021641895
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Feb 8 15:06:30 2012 +0530
fuse-bridge: Handle graph-switch.
The purpose of this patch is to let protocol/client know when its transports can
be disconnected, without application running on gluster mount noticing any
effects of graph switch.
In order to do this, we migrate all fds and blocked locks to new graph.
Once this migration is complete and there are no in-transit frames as viewed
by fuse-bridge, we send a PARENT_DOWN event to its children. protocol/client
on receiving this event, can disconnect up its transports.
Change-Id: Idcea4bc43e23fb077ac16538b61335ebad84ba16
BUG: 767862
Reviewed-on: http://review.gluster.com/2734
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 18a5e0a5a2b4515bcb1a0672bb30559c231ce406
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Feb 21 12:45:24 2012 +0530
performance/md-cache: Add mem_acct_init
Change-Id: I1b91ee0bde160762548c39646ceb96c3c778e06c
BUG: 795651
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2778
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 886274d0fd4a526669e9a090589f4d36c4550d4a
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Feb 16 21:30:47 2012 +0530
cluster/afr: Add commands to see self-heald ops
Change-Id: Id92d3276e65a6c0fe61ab328b58b3954ae116c74
BUG: 763820
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2775
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8caee1daafb884676612f38573768e748feee172
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Feb 14 22:40:34 2012 +0530
cluster/afr: Self-heald, Index integration
Change-Id: Ic68eb00b356a6ee3cb88fe2bde50374be7a64ba3
BUG: 763820
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2749
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit fe148ebbfc2c23b8c3e6347489daab54b4ed014f
Author: Anand Avati <avati@redhat.com>
Date: Fri Feb 3 00:16:30 2012 +0530
md-cache: replace stat-prefetch with md-cache in a backward compatible way
- preserve CLI set option key as "performance.stat-prefetch"
- create a symlink stat-prefetch.so to point to md-cache.so
Change-Id: Ib95e7c30073f13ae04c39e9466967ba1db5a0614
BUG: 765785
Reviewed-on: http://review.gluster.com/2714
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit d8e97bd80ecf0972a8af53d1f406f883d8c7912c
Author: Anand Avati <avati@gluster.com>
Date: Sat Sep 24 16:14:11 2011 +0530
md-cache: meta-data caching translator
This is a metadata caching translator which is well integrated with
glusterfs core framework and leverages some of the recent protocol
changes to do a better job at caching.
- It uses the attributes returned along callbacks of all calls to
update its attribute cache as frequently as possible without
issuing calls on its own (i.e, very low overhead)
- It caches attributes returned via readdirp into the inode contexts
corresponding to those entries (i.e, well integrated)
- It caches and updates xattrs and not just inode attributes (i.e,
eliminates the need for a separate xattr-prefetch translator)
In its current form it has a timeout based consistency model
Change-Id: I891f6225c1a4c08bb111e287571d5f6d326dbe97
BUG: 765785
Reviewed-on: http://review.gluster.com/2713
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 79facc0560c1b8c91f6da4dfcf75a8f1146bccca
Author: Anand Avati <avati@redhat.com>
Date: Tue Feb 21 09:25:14 2012 +0530
syncop: Multi-processor support in syncenv
This patch introduces:
- multithreading of syncop processors permitting synctasks to be executed
concurrently if the runqueue has many tasks.
- Auto scaling of syncop processors based on runqueue length.
- Execute a synctask (synctask_new) in a blocking way if callback function
is set NULL. The return value of the syncfn will be the return value
of synctask_new()
Change-Id: Iff369709af9adfd07be3386842876a24e1a5a9b5
BUG: 763820
Reviewed-on: http://review.gluster.com/443
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 445b4a6890f14234b923e5d0759be294a617bb78
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Feb 20 19:48:07 2012 +0530
storage/posix: Add xattr for gfid2path
Change-Id: I1fe987d255bf50e8433043749b482b67554a0ac3
BUG: 763820
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2774
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bc32aeec3289cec82aa23b378e8ffc653bd14413
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Feb 20 22:27:31 2012 +0530
nfs/server: Fix compilation warnings
Change-Id: If5c2375adb3769827cf5099cb6b2d19ba75bf238
BUG: 795421
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2776
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 6143d116490ae39d232cd917eb6cd49da0758b57
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Feb 2 19:14:28 2012 +0530
features/index: Index translator implementation
Change-Id: If8a11ecbdd010f64fb4409add5751080f4b59086
BUG: 763820
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2722
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8a896313b367e7d09cc65acadfa75de142b55d2e
Author: Krishna Srinivas <ksriniva@redhat.com>
Date: Mon Feb 20 14:34:39 2012 +0530
NLM - Network Lock Manger V4
Change-Id: Ic31b8bb10a28408da2a623f4ecc0c60af01c64af
BUG: 795421
Signed-off-by: Krishna Srinivas <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/2711
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 94c592116c4b50e5e4feeed9d9b4765013eaad7d
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Feb 20 18:42:37 2012 +0530
libglusterfs: Implement circular buffer and event history
Implement circular buffer framework, so that it can be used by other components
such as event history management. And event history is implemented which can
be used by xlator to dump some information to a file (such as information of some
structure etc).
Through statedump, history of each xlator can be dumped. An option called history
should be given to the statedump command.
Change-Id: I7c5e8f6bd1018584eaee856e933e7c4b94c6709c
BUG: 795419
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2769
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1ab3884e316385cac16bf42a70a36dd337ea6b82
Author: Mohammed Junaid <junaid@redhat.com>
Date: Wed Feb 8 18:06:39 2012 +0530
protocol/client,server: fcntl lock self healing.
Currently(with out this patch), on a disconnect the server cleans up
the transport which inturn closes the fd's and releases the locks acquired on
those fd's by that client. On a reconnect, client just reopens the fd's but
doesn't reacquire the locks. The application that had previously acquired
the locks still is under the assumption that it is the owner of those locks
which might have been granted to other clients(if they request) by the server
leading to data corruption.
This patch allows the client to reacquire the fcntl locks (held on the fd's)
during client-server handshake.
* The server identifies the client via process-uuid-xl (which is a combination
of uuid and client-protocol name, it is assumed to be unique) and lk-version
number.
* The client maintains a list of process-uuid-xl, lk-version pair for each
accepted connection. On a connect, the server traverses the list for a
matching pair, if a matching pair is not found the the server returns
lk-version with value 0, else it returns the lk-version it has in store.
* On a disconnect, the server and client enter grace period, and on the
completion of the grace period, the client bumps up its lk-version number
(which means, it will reacquire the locks the next time) and the server will
distroy the connection. If reconnection happens within the grace period, the
server will find the matching (process-uuid-xl, lk-version) pair in its list
which guarantees that the fd's and there corresponding locks are still valid
for this client.
Configurable options:
To set grace-timeout, the following options are
option server.grace-timeout value
option client.grace-timeout value
To enable or disable the lk-heal,
option lk-heal [on|off]
gluster volume set command can be used to configurable options
Change-Id: Id677ef1087b300d649f278b8b2aa0d94eae85ed2
BUG: 795386
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/2766
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a7fae938b105a8707bab6567908e716833eecef0
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Feb 20 14:34:39 2012 +0530
volgen: give an option to insert trace/error-gen
currently, these translators can be plugged in on the server
volfile. Need to enhance on client side too.
Change-Id: I8c3696f62f1de646a736d68c4c427c6fffd6bbf4
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 782262
Reviewed-on: http://review.gluster.com/776
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f1b50f468f7fae1a86b4902fea75e91acf2cbe72
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed Feb 15 14:33:19 2012 +0530
protocol/client: delete locks only for non-anonymous fds
delete_granted_lock_owners () is not called for anonymous
fds since they are not involved in locking
Change-Id: Icdc7818f98f5371232ba276ed442704ef69e6b0e
BUG: 787365
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2754
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit adecc01a1cb72aad75d13d9ce85af8a8f0832e9c
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Feb 14 15:05:19 2012 +0530
iobuf: use 'iobuf_get2()' to get variable sized buffers
added 'TODO' in places where it is missing.
Change-Id: Ia802c94e3bb76930f7c88c990f078525be5459f5
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 765264
Reviewed-on: http://review.gluster.com/388
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 87311ec102c12a5caf6fda5eec2bedbbaafca079
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Feb 20 12:31:10 2012 +0530
glusterd: auth allow enhancements
* PROBLEM:
When address-based authentication is enabled on a volume,
the gNfs server, self-heal daemon (shd), and other operations
such as quota, rebalance, replace-brick and geo-replication
either stop working or the services are not started if all
the peers' ipv{4,6} addresses or hostnames are not added in
the "set auth.allow" operation, breaking the functionality
of several operations.
E.g:
volume vol in a cluster of two peers:
/mnt/brick1 in 192.168.1.4
/mnt/brick2 in 192.168.1.5
option auth.allow 192.168.1.6
(allow connection requests only from 192.168.1.6)
This will disrupt the nfs servers on 192.168.1.{4,5}.
brick server processes reject connection requests from both
nfs servers (on 4,5), because the peer addresses are not in
the auth.allow list.
Same holds true for local mounts (on peer machines),
self-heal daemon, and other operations which perform
a glusterfs mount on one of the peers.
* SOLUTION:
Login-based authentication (username/password pairs,
henceforth referred to as "keys") for gluster services and
operations.
These *per-volume* keys can be used to by-pass the addr-based
authentication, provided none of the peers' addresses are put
in the auth.reject list, to enable gluster services like gNfs,
self-heal daemon and internal operations on volumes when
auth.allow option is exercised.
* IMPLEMENTATION:
1. Glusterd generates keys for each volume and stores it in
memory as well as in respective volfiles.
A new TRUSTED-FUSE volfile is generated which is
fuse volfile + keys in protocol/client,
and is named trusted-<volname>-fuse.vol.
This is used by all local mounts. ANY local mount (on any peer)
is granted the trusted-fuse volfile instead of fuse volfile
via getspec. non-local mounts are NOT granted the trusted fuse
volfile.
2. The keys generated for the volume is written to each server
volfile telling servers to allow users with these keys.
3. NFS, self-heal daemon and replace-brick volfiles are updated
with the volume's authentication keys.
4. The keys are NOT written to fuse volfiles for obvious reasons.
5. The ownership of volfiles and logfiles is restricted to root users.
6. Merging two identical definitions of peer_info_t in auth/addr
and rpc-lib, throwing away the one in auth/addr.
7. Code cleanup in numerous places as appropriate.
* IMPORTANT NOTES:
1. One SHOULD NOT put any of the peer addresses in the auth.reject
list if one wants any of the glusterd services and features
such as gNfs, self-heal, rebalance, geo-rep and quota.
2. If one wants to use username/password based authentication
to volumes, one shall append to the server, nfs and shd volfiles,
the keys one wants to use for authentication, *while_retaining
those_generated_by_glusterd*.
See doc/authentication.txt file for details.
Change-Id: Ie0331d625ad000d63090e2d622fe1728fbfcc453
BUG: 789942
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2733
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 31d8a9be2535c51bdbdf1fa3cbd78d44d6d85c8d
Author: Venky Shankar <vshankar@redhat.com>
Date: Wed Feb 15 12:04:24 2012 +0530
GlusterFS Hadoop Plugin
Apache Hadoop plugin to run Map/Reduce (MR) jobs on data
stored on GlusterFS. This is a drop in replacement for
HDFS requiring the plugin jar and modification to a
single conf file to enable MR jobs to process data on
GlusterFS.
Change-Id: I8862efec30708849fa7c544fed88b8e50e622fed
BUG: 790671
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/2751
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 015a042b17f505146a4d4cf49e850be8a827473f
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Feb 17 19:21:07 2012 +0530
cluster/dht: Support for hardlink rebalance when decommissioning
The support for hardlink rebalance is only available for decommissioning
of a node. this can be triggered in two ways
1. remove-brick start
2. if decommission node value is set in vol file, then a normal rebalance
command
The way we handle it is-
if (nlink > 1)
do
* if src file doesnt have linkto xattr
* mark src's linkto to the dst
* else
* perform a link on the dst
* do a look up
* if nlinks = dst.nlinks
* migrate data
* else
* continue crawling
done
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: If43b5524b872fd1413e9f7aa7f436cb244e30d8d
BUG: 763844
Reviewed-on: http://review.gluster.com/2737
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit cac19a6da5ee697cfcaa4b9b70b18192d35cd393
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Feb 16 14:47:27 2012 +0530
cluster/dht: Handle get cached/hashed subvol failures gracefully
Change-Id: I7a41c2876be04acd166b2004d9aa66af078d32ea
BUG: 790328
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2757
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 56623a7f5df2a23553c6bc60afb72b333936be7f
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Jan 20 00:01:53 2012 +0530
cluster/dht: Exit clean when assert_no_child_down is enabled
Change-Id: If90b1080edcf3792f8590492b585a6dd48fac18e
BUG: 783249
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2664
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 4880692c50bc0542474371d87ec4111ea2b95bae
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Feb 18 12:12:10 2012 +0530
cluster/distribute: send the proper 'loc_t' for statfs()
in dht-diskusage.c, which was getting used for getting free disk
space of all subvolumes
Change-Id: Ieb2bb5f2479fac1803b9af4ef1948954a026c2ee
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 290282
Reviewed-on: http://review.gluster.com/2767
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 62e49f98c300f0d50d02bcae4086f7c30b72c54b
Author: Joe Julian <me@joejulian.name>
Date: Wed Nov 9 18:27:25 2011 -0800
Merged in the fedora spec file to bring glusterfs into compliance with FSH and Redhat/Fedora requirements. Created a single spec that works for both 3.1 and 3.2 versions.
Releases will now require changing the source url in configure.ac
at the same time the release version is set.
OLDBUG: 2970
BUG: 764702
Change-Id: I1ec9d10fce6dbd72c329d04c7ad61df2ad117adb
Signed-off-by: Joe Julian <me@joejulian.name>
Reviewed-on: http://review.gluster.com/701
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9e5df2fde92daabf0aab7b7d978c9dedb0655453
Author: shishirng <shishirng@gluster.com>
Date: Wed Jan 18 15:29:15 2012 +0530
cluster/dht: Rebalance will be a new glusterfs process
rebalance will not use any maintainance clients. It is replaced by syncops,
with the volfile. Brickop (communication between glusterd<->glusterfs process)
is used for status and stop commands.
Dept-first traversal of dir is maintained, but data is migrated as and when
encounterd.
fix-layout (dir)
do
Complete migrate-data of dir
fix-layout (subdir)
done
Rebalance state is saved in the vol file, for restart-ability.
A disconnect event and pidfile state determine the defrag-status
Signed-off-by: shishirng <shishirng@gluster.com>
Change-Id: Iec6c80c84bbb2142d840242c28db3d5f5be94d01
BUG: 763844
Reviewed-on: http://review.gluster.com/2540
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit a35d1c349bd3d603d916d4b3b098a46fa5b3380c
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Feb 18 12:58:39 2012 +0530
extras/rpc-coverage.sh : behavior fix
don't treat getfattr after 'setfattr -x' (ie, removexattr())
as an error. ignore the output so the script runs for completion
Change-Id: Id7089b91e7259a39be7cb6fce627828774c4acbc
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 787956
Reviewed-on: http://review.gluster.com/2768
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ab2c7c6cc85090c712fbba66350adaed7ad9d0f5
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Jan 31 17:04:37 2012 +0530
cli/glusterd: volume status modification
* Method of getting mount details of brick has been
changed from direct reading of /etc/mtab to using
libc's <mntent.h>, providing a fairly portable
version independent of different linux distributions.
It is only supported on Linux though.
* Wrong fs type (rootfs for /) in fedora-based
distributions has been fixed.
* Allows options (detail, mem, fd, et al) to "all" volumes.
* Use of the fnmatch's GNU extension flag,
FNM_LEADING_DIR is restricted to Linux hosts only.
In case of non-Linux hosts, partial match functionality
is absent.
Change-Id: I102ce808c192ef635c2536a2167101be0aa0fc50
BUG: 786367
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2705
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit fd2f953a4fb7684b192390bd10cfb0537132e780
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Sat Dec 24 13:49:52 2011 +0530
cli, glusterd : Added support for clear-locks command.
Change-Id: I8e7cd51d6e3dd968cced1ec4115b6811f2ab5c1b
BUG: 789858
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2552
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ce8703799132ba90c5ef223e7cf4ea36e1015d97
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Feb 17 12:15:48 2012 +0530
mount/fuse: unref the fd from resolve to avoid fd leak
Change-Id: I162e07219b98669bc6e09784830ca9407518fd8b
BUG: 794618
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2760
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit fe06e7324d239cf85915c9a7269da8a5d90fb188
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Feb 1 14:44:07 2012 +0530
cli: Fix for statedump crashing gluster processes
1. Fixes the bug in statedump causing the gluster process to crash when an unknown
option was given in the 'glusterdump.*.options' file.
2. Also fixes cli, making it send full statedump option strings even when only
partial option strings are given in 'volume statedump' command.
3. Minor change to order of operations during statedump to allow option parsing
errors to be written to the dump file.
Change-Id: Ic878cbca4dbf46b83fba0fd88fcb3c03f05ae46d
BUG: 772586
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2706
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3f3941b3544e35572771f13aece6b5e1595761f5
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Feb 15 19:48:50 2012 +0530
protocol: remove the 'path<>' from rename() and link()
missed it in the previous round of cleanup, path is completely
useless in resolve function.
Change-Id: I1aef0f5276afb77dfacfcc0c337ac80b4fcacc55
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 790298
Reviewed-on: http://review.gluster.com/2756
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit fabf07c7228fb1b02b2b3c615283aad99feb7b47
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Feb 15 17:20:40 2012 +0530
posix: handle some internal behavior in posix_mknod()
assume a case of link() systemcall, which is handled in distribute by
creating a 'linkfile' in hashed subvolume, if the 'oldloc' is present
in different subvolume. we have same 'gfid' for the linkfile as that
of file for consistency. Now, a file with multiple hardlinks, we may
end up with 'hardlinked' linkfiles. dht create linkfile using 'mknod()'
fop, and as now posix_mknod() is not equipped to handle this situation.
this patch fixes the situation by looking at the 'internal' key set in
the dictionary to differentiate the call which originates from inside
with regular system calls.
Change-Id: Ibff7c31f8e0c8bdae035c705c93a295f080ff985
BUG: 763844
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/2755
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 43ff8cc9fe48f5c6a432e766c25fb64498ef8c88
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Feb 16 17:48:44 2012 +0530
storage/posix: reset op_ret to -1 after call to MAKE_INODE_HANDLE
MAKE_INODE_HANDLE uses op_ret. We do not reset it to -1, and in few
instances we jump to label out, where we unwind with op_ret.
Change-Id: Iac4d9f250f5253b3ce0cd91cc385168247efd4a8
BUG: 788998
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2759
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 46de391353c3248e7a48c0d55a32c3161210c8fa
Author: Shylesh Kumar <shylesh@gluster.com>
Date: Thu Feb 16 11:06:08 2012 +0530
filter stripe internal xattrs from getxattr call
Change-Id: Ia0e9662644494c61033e7a7853353294598984af
BUG: 787964
Signed-off-by: Shylesh Kumar <shylesh@gluster.com>
Reviewed-on: http://review.gluster.com/2758
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit cb1d390efb0231b29df0da4a108c8d8873f9277a
Author: Kaushal M <kaushal@redhat.com>
Date: Wed Feb 15 16:18:25 2012 +0530
cli: Enable output in XML
This patch enables gluster cli to output data in xml format. XML output can be
obtained by passing "--xml" as an argument.
A new "volume list" command, which lists the volumes present in a cluster, has
been added. This can be used for obtaining a quick list of volumes.
Several commands, including "volume top", "volume profile", "volume status" and
"volume info", "volume list", have custom XML output routines. Other commands
use either one of the 2 generic output routines, cli_xml_output_str() &
cli_xml_output_dict().
NOTE: When using "all" for "volume status" and "volume info" the XML output will
have multiple roots.
Change-Id: I6117baa02ec06fda116177dbd401f66521263ac6
BUG: 790713
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2753
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c79566d6acf501809434f11eeed6c6527f4ba66a
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Feb 15 11:22:00 2012 +0530
features/marker: copy the gfid to loc from oplocal->loc.inode
Change-Id: I8cfb70c163a3c4a0bd682678f71b38b5bae20ab4
BUG: 790393
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2750
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ecbd098b0c9c629dfbcd13f1e98a6268491da535
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Jan 12 12:53:48 2012 +0530
mgmt/glusterd: changes to run nfs server and self-heal daemon with valgrind
Currently glusterd can start only the brick processes in the valgrind mode.
This patch ensures that nfs server and self-heal daemon are also started
with valgrind along with the bricks.
Change-Id: I3136deb58d54075627cdd204002eb26fdfdde462
BUG: 773600
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2638
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f9c820d10c8a22b902f3864ab1fb296c64aa9edf
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Feb 14 16:28:44 2012 +0530
nfs: avoid logging invalid fdctx in case of anonymous fds
if get_fd_ctx fails (as in case of anonymous fds), overwhelming
amount of entries are seen in the nfs log, causing dd and other
heavy i/o operations to become unresponsive. this patch logs an
invalid fdctx only if it is not an anonymous fd.
Change-Id: I4e917d150d6a053af77d47a94a2f1c2633acadb5
BUG: 787365
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2747
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 8f8b71edf4c4fafadbcdf499f22a6bca952a959f
Author: Rahul C S <rahulcs@redhat.com>
Date: Tue Feb 14 17:09:21 2012 +0530
Allows Successful log rotation when no bricks are specified.
log rotate must happen for all the bricks if no specific
brick path is given as an argument for the command.
Change-Id: I39e55883fd301bedffae996384a8284119011951
BUG: 765578
Signed-off-by: Rahul C S <rahulcs@redhat.com>
Reviewed-on: http://review.gluster.com/2748
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 297d361290263508e43a9ec472e433c7fd60d88f
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Feb 13 16:33:32 2012 +0530
glusterd: Fail volume 'modify' operations when rb is ongoing
* add-brick, stop-volume, remove-brick are the operations that are explicitly
'failed' when attempted while replace-brick is in progress.
* we attach the volume-id to the dst_brick volfile ensuring that the replace-brick
operation holds 'claim' on it.
Change-Id: If60b2af566ca940b2add600b473c99730e06ab47
BUG: 765470
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2740
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 51ff6dcdaf8648f0ec2e05b5566dd0cc8d63c8e7
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Feb 14 15:27:49 2012 +0530
protocol xdr: remove 'path<>'
client was sending 'path' on wire, which gets ignored on server
side, and also doesn't get freed up, which causes memory leak.
also with not having path on wire, the xdr size on wire most of the
time can remain constant, which helps in allocating RDMA buffers.
Change-Id: Ie0d36a670be60b02fd1e925c6f977b1a71def5cd
BUG: 790298
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/2744
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit babc683ae35b2d4905b6f01cabe733d05fa14a7d
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Feb 14 15:50:40 2012 +0530
rpc : fix the leak with glusterfs v2 auth structure conversion
both 'groups' and 'lkowner' were getting leaked after the conversion
Change-Id: Iab7cc1cf5afdad18ead9f33e6ccf98e0a934a09a
BUG: 790298
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/2746
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 86330bfcab83320353b7702923e55d110f05ff7a
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Nov 16 16:23:48 2011 +0530
locks: Added a getxattr interface to clear locks on a given inode.
getxattr returns a summary of no. of inodelks/entrylks cleared.
cmd_structure: trusted.glusterfs.clrlk.t<type>.k<kind>[.{range|basename}]
where,
type = "inode"| "entry"| "posix"
kind = "granted"| "blocked" | "all"
range = off,a-b, where a, b = 'start', 'len' from offset 'off'
Change-Id: I8a771530531030a9d4268643bc6823786ccb51f2
BUG: 789858
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2551
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e2d1c8a6c4853aac29b24d51678e42c4bb38ba4d
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Feb 14 12:26:29 2012 +0530
features/quota: fix a crash in fgetxattr() by checking for NULL arg
'name' can be NULL in getxattr() as it is overloaded in glusterfs
code to support listxattr() too.
Change-Id: I70ccee027828e9b2b08da770f513c4edc5c7a46b
BUG: 772601
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/2743
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f83c2689acd15a0468ef8668a7cc8d8cf279140b
Author: shishir gowda <shishirng@gluster.com>
Date: Sat Feb 11 18:46:10 2012 +0530
cluster/stripe: Support for NFS anonymous fd's
Moving storing of all ctx info to inode ctx. anonymous fd's do not
have the ctx stored in them, hence readv/writev can fail.
Open call does not need the additional lookup calls, as all the
required fctx info will be available in the inode ctx populated
any one of the following create/mknod/lookup
Change-Id: I94ca69ff821d46ac8ed3ba1b87b97a3d1c736566
BUG: 786095
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2726
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit a50005b3f9ac2c6a10855020e628f028f86d4a22
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Feb 11 22:25:09 2012 +0530
features/marker: set loc->gfid in setxattr initiated from marker.
Change-Id: I7abb62272b7c8bb25ad37cbc13da7b4713924b7a
BUG: 787151
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2736
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
commit 2d84107d4a27abe3ded26b68da46456ff733eff0
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Feb 6 17:49:14 2012 +0530
core: add an extra flag to readv()/writev() API
needed to implement a proper handling of open flag alterations
using fcntl() on fd.
Change-Id: Ic280d5db6f1dc0418d5c439abb8db1d3ac21ced0
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 782265
Reviewed-on: http://review.gluster.com/2723
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 200950039829358b4ee67ba384b83b9f531f9047
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Feb 13 13:00:26 2012 +0530
protocol: code cleanup
make dict serialize and unserialization code a macro
Change-Id: I459c77c6c1f54118c6c94390162670f4159b9690
BUG: 764890
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/2742
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
commit 90304255be5102b883d182ebf8c60ad24bab4b2b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Feb 9 15:57:51 2012 -0500
Fix case where we free a definitely-NULL iobuf
Change-Id: I7097386b41c8881f875c9cc3e41354df5c904dea
BUG: 789118
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/2732
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <fharshav@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit f75554d26de1fbab1b3540794a2ce2f46a98c492
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Jan 16 14:04:10 2012 +0530
core: log xlator options in init
* The options (default as well as explicitly set)
for each xlator are logged at DEBUG log-level
Change-Id: I757e206bf06ef5dc60a3255e2377a821c284b6f1
BUG: 767087
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2647
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d1030eb4467ae086f187f15a47fdddb41d36276a
Author: krishna <ksriniva@redhat.com>
Date: Thu Feb 9 12:08:07 2012 +0530
support for nano second resolution for mtime,ctime,atime attributes.
Change-Id: Id5078f270d0fec280b53d4aa7b16bbaf42a2df05
BUG: 784095
Signed-off-by: krishna <ksriniva@redhat.com>
Reviewed-on: http://review.gluster.com/2730
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a23325ccae03d3b957f051a5f793af8fb81230f9
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Feb 8 16:36:22 2012 -0500
Use /dev/zero instead of /dev/urandom to get realistic numbers.
Change-Id: I460a03759b3e450765758e456f0b4f514ca934ae
BUG: 788716
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/2728
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 7303e70a73710e306b4f53f0c0a6f2569040c66f
Author: Anand Avati <avati@redhat.com>
Date: Mon Jan 30 15:03:56 2012 +0530
fuse: fix resolver to handle graph switches properly
perform resolution on the latest graph by caching it in state->itable
and use fuse_nodeid as just a hint to the possible final resolved inode
(in case it was resolved off the latest graph). GFID is the primary key
for resolving inodes on the latest graph.
Change-Id: I3921c6f59c9ff80e4ff076bec3bd334423fc36cc
BUG: 785675
Reviewed-on: http://review.gluster.com/2703
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 08133b19814e84bf783589b7f7d0c4543cd95d15
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jan 5 02:01:00 2012 +0100
geo-rep: gsyncd: fix up fallback xtime for orphans on master side
Change-Id: I2fa543b4bd317e06ea621ae968300ffb7223a68a
BUG: 771787
Signed-off-by: Csaba Henk <csaba@gluster.com>
Reviewed-on: http://review.gluster.com/2580
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushik BV <kaushikbv@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 42915efb3b74ebc7f6551130a206bd7f03fbdb17
Author: Kaushik BV <kbudiger@redhat.com>
Date: Fri Jan 20 11:47:54 2012 +0530
nfs: export-dir option changed to type GF_OPTION_TYPE_PATH
Change-Id: Ica47482cfed794d6923047db859191462919d6fe
BUG: 782424
Signed-off-by: Kaushik BV <kbudiger@redhat.com>
Reviewed-on: http://review.gluster.com/2667
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 75f40d5b1693b50a24dbc65ed851911a452b8ee2
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Feb 6 15:12:51 2012 +0530
glusterd: Initialised op_sm/friend_sm before cluster restore.
Cleaned up peerinfo/rpc association.
Change-Id: I11bcaa3ea1f2b86c6b4e235873a60bb5bf76a892
BUG: 786006
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2725
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2c3e0ace8c2a708961ed59b37a523530f11c37a5
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 3 13:54:02 2012 +0530
protocol/client: assign the right value to 'conf' before de-refing it
variable assignment was done after it was actually getting de-referenced.
moved the assignment few lines up.
Change-Id: Id65e3e2d3dfe071e1c5b14c32488647070398ae4
BUG: 787117
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/2712
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit a8f2525b9088a2110fb2eb04cd328198ebe6e912
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed Feb 1 15:52:36 2012 +0530
mount/fuse: check for existence of volfiles
If glusterd is not running in the client host and/or
if there are no volume created yet, this patch ensures
that appropriate error message is displayed
Change-Id: I15d23a45d70aa27bbdd42f435fe705b14c779e3f
BUG: 786077
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2708
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 18b17f9b08e16fe618d26c909eea7688099e3d92
Author: Kaushal M <kaushal@gluster.com>
Date: Tue Aug 23 12:23:53 2011 +0530
cli, protocol/server : improve validation for the option auth.(allow/reject)
cli now checks validity of address list given for 'volume set auth.*'
Server xlator checks addresses supplied to auth.(allow/reject) option
including wildcards for correctness in case volfile is manually edited.
Original patch done by shylesh@gluster.com
Original patch is at http://patches.gluster.com/patch/7566/
Change-Id: Icf52d6eeef64d6632b15aa90a379fadacdf74fef
BUG: 764197
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/306
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 260b4b52f9ae9eae76494ee6fd1ea9b4c3f61581
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Jan 9 15:43:10 2012 +0530
glusterd/quota: inform the user if some quota command is executed without enabling it
Change-Id: I676e52b0e0a9a6868eaa56d0309faa264e6e73be
BUG: 771639
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2609
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 5e2d814895ec2b7bab4b0cbbdf6f92d7959ba737
Author: Kaushik BV <kbudiger@redhat.com>
Date: Mon Jan 30 19:17:12 2012 +0530
read-ahead: add performance.read-ahead--page-count option to 'volume set' framework
Change-Id: I727be1ae2e3da1816afa52fc9555269aa07c39c1
BUG: 783379
Signed-off-by: Kaushik BV <kbudiger@redhat.com>
Reviewed-on: http://review.gluster.com/2700
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9b9604b205b8c9c83413732950d69cd3082d90de
Author: Kaushik BV <kbudiger@redhat.com>
Date: Fri Jan 20 11:54:21 2012 +0530
extras: create PID file for glusterd when started from init scripts
thanks to Jaroslav Pulchart (jaroslav.pulchart@centrum.cz) for the patch
Change-Id: Id07bf50536c8638f790f06e6e5994f85555c3978
BUG: 771221
Signed-off-by: Kaushik BV <kbudiger@redhat.com>
Reviewed-on: http://review.gluster.com/2668
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 82134b3173e0acce5d3d9443e701adf54833729c
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Jan 21 20:05:55 2012 +0530
extras/test: add a test file to test 'f-fops'.
mainly to test f*xattr(), fchown()/fchmod()/ftruncate() on fuse
mounts.
Change-Id: I59edbe172f307a2ba94f11c650ac0176fd35564f
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 766571
Reviewed-on: http://review.gluster.com/2692
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 82078d62dbb4de825d4b59e307f672fe45b817c8
Author: Kaushal M <kaushal@gluster.com>
Date: Mon Sep 12 15:14:26 2011 +0530
protocol/client : prevent client from reconnecting when server authentication fails
This prevents the client from trying to reconnect on server
authentication failure. Reconnecting on authentcation failure causes hung
mounts on unauthorised clients. This patch fixes this problem.
Also, mount.glusterfs script unmounts mount-point on mount failure to
prevent hung mounts.
Change-Id: I5615074d27948077bad491a38cecae1b7f5159fb
BUG: 765240
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/398
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 48f0d010b86273fa0e298a2564da4fe53e6ed2fa
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Jan 11 15:39:38 2012 +0530
glusterd: Changed op_sm_queue locking mechanism to accomodate nested calls to op_sm
Today if an rpc call made inside an op_sm can fail due to a disconnected peer,
resulting in the rpc callback to be called in the same stack with appropriate
status set. All glusterd rpc cbks move the state machine based on the status
returned by the rpc layer, which would result in a nested call to op_sm. With
the current scheme of locking, glusterd would end up in a deadlock situation
The new scheme will fail the nested glusterd_op_sm (). This prevents the
deadlock. It would work without any change in overall behaviour, as the
current op_sm () call in execution wouldn't return until all events in the
queue are processed.
Change-Id: I6a7ba16d3810b699bcd06dc28a5ff3205a25476f
BUG: 772142
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2625
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit aca97762954abdbfbe2d29b3eb586318795980a4
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri Jan 6 12:18:35 2012 +0530
glusterd: Improved err msgs for add_brick
Change-Id: I4b97d7e26b8c81ed52657467981be0c4adc291ae
BUG: 772145
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2589
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit da8a59abbe2f79e2a5b03616e9be73353af72aaa
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Dec 16 18:27:52 2011 +0530
distribute: utilize new 'fremovexattr()' fop for rebalance
instead of existing 'syncop_removexattr()' which is not rename proof
for now.
Change-Id: Ib171710645a6ee35c86d851a057b68461ecbab27
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 766571
Reviewed-on: http://review.gluster.com/2691
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 34a13243d5ad69ed25b6247538e6dcd8ad44aab0
Author: M S Vishwanath Bhat <vishwanath@gluster.com>
Date: Tue Jan 31 01:32:50 2012 +0530
removing the dead code in cli-rpc-ops.c
Change-Id: Ie80b7938944a5984e4d9cd0a5f52b7976030ea73
BUG: 783972
Signed-off-by: M S Vishwanath Bhat <vishwanath@gluster.com>
Reviewed-on: http://review.gluster.com/2701
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e74656cb6e6d78c9c58e871f2bfe6ef0029d2473
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Feb 1 22:35:55 2012 +0530
performanc/stat-prefetch: check if loc->gfid is present before checking loc->name
After gfid based backend changes loc will either contain the gfid of the inode
or it will contain the parent gfid and the name of the entry. So before unwinding
when loc->name is not there we have to check if loc->gfid is present or not.
If loc->gfid is null and loc->name is also NULL, then unwind with the error.
Change-Id: If88b9462bde09a80e79f27899c995605697ce453
BUG: 785675
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2710
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b3c1bab35a2994c6134696bb734d7a5d06686d25
Author: Csaba Henk <csaba@redhat.com>
Date: Tue Jan 24 18:28:22 2012 +0100
Revert "mgmt/glusterd: Allow insecure ports by default"
This reverts commit f6e0e614fbd07a57de44f0d16c304d01d1a5b269.
Conflicts:
xlators/mgmt/glusterd/src/glusterd.c
Change-Id: I1da429e4b8c3f8c67367b173aa11dbe2b0435046
BUG: 781256
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/2695
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a8176d30c3f465b306137abee3e509afe3896a37
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Jan 30 19:34:03 2012 +0530
features/marker,quota: Incorporate changes to support nameless lookup
Change-Id: Ic5f00a9891bd835ebee5a3e103ef0f75d0b7fc25
BUG: 783925
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2702
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 49c02f8d0e271f7e649135be927f0cd60aceed9f
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Jan 19 17:49:42 2012 -0500
Fix race between read-ahead and write.
Change-Id: I0ed1aca585733302b5e3840f392849e12f0b0f0d
BUG: 783313
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/2666
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 3ea4d1dd6f177da41af1c546557c8d6e51da24b2
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Jan 29 16:17:21 2012 +0530
storage/posix: Fix rename gfid handle unset
Change-Id: I365ef264056691914ad5bd620d8150f8b71ec887
BUG: 785524
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2698
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit d36689f640246b5bca4f2fdf06f09a2d1fb20915
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Jan 29 16:09:29 2012 +0530
storage/posix: janitor should unset gfid handles
Change-Id: I449b6a55122dfc27035569e6eb1d74ddcea68a69
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
BUG: 785522
Reviewed-on: http://review.gluster.com/2697
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit cfb38af888494f9b4f3933c3d10f45219e525a0b
Author: Mohammed Junaid <junaid@redhat.com>
Date: Tue Jan 24 17:12:59 2012 +0530
features/quota: Check for error in statfs fop call back.
Change-Id: Ia73d2b77dcb0507a7b8362c336c71301526aaf82
BUG: 783927
Signed-off-by: Mohammed Junaid <junaid@redhat.com>
Reviewed-on: http://review.gluster.com/2685
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bd3a6e90c14f92dd3a03c22e692aaf1772a5c5fc
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Jan 4 00:08:14 2012 +0530
glusterd: provide option to take statedump of the nfs server
Currently the cli command for taking statedump is for glusterfs servers
only. Statedump of nfs server cannot be taken. With this patch if one
gives nfs as an option to the statedump command, then the nfs-server's
statedump is taken.
Change-Id: I4ef7a68e608da4aa2f17541d7b42cd78ce2624b6
BUG: 771587
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2579
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ebbd31b99c222ab7fc441bbc437d222286e20a5d
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Nov 3 15:16:18 2011 +0530
glusterd: Refactored rb subcmds code and fixed some minor issues.
Change-Id: I680a1c8f01883433d4cd1ed51723acebd8fe9245
BUG: 765441
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2689
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 87f1d185c8c0017c354c47e2bbfb82e592b5343a
Author: Kaushal M <kaushal@redhat.com>
Date: Sun Jan 1 15:59:28 2012 +0530
cli: Extend "volume status" with statedump info
This patch enhances and extends the "volume status" command with information
obtained from the statedump of the bricks of volumes.
Adds new status types : clients, inode, fd, mem, callpool
The new syntax of "volume status" is,
#gluster volume status [all|{<volname> [<brickname>]
[misc-details|clients|inode|fd|mem|callpool]}]
Change-Id: I8d019718465bbc3de727653a839de7238f45da5c
BUG: 765495
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/2637
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 5f515e79d64cbf3e876e56c8a504bf887d4643d0
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Nov 29 18:30:39 2011 +0530
cluster/afr: Perform xattrop with all afr-keys
Self-heal does not happen if the file has change log xattr
only for one of the subvol keys. This patch makes sure that
xattrop is done for all the afr subvol keys after a new entry
is created in entry-self-heal.
1) Added matrix create/cleanup functions
2) Impunging a new file does multiple xattrops on the source
subvol, one per sink. The code can do a single xattrop after
the entry is created on all the sinks.
3) Missing entry self-heal uses one frame per sink to heal
the file. This leads to multiple xattrops on the source subvol.
That code is changed now to use one frame which will
create the file on all subvols.
Change-Id: I65a42f9779b03f7efae283479f8653fb2cb8046b
BUG: 762680
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2503
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 0bcf6036b957c4452f12b80baacd9ee944024ebe
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Jan 24 18:47:35 2012 +0530
cluster/afr: Stack wind with correct frame
*) Found possible races in _cbk fixed them as well.
Change-Id: Id9a9f3cbf71f55827addb24ba2cbddecb8326b5b
BUG: 784279
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2687
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3385d2a128499bb0d2c62f817b5b9d92a62ea477
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Dec 14 13:37:36 2011 -0500
Make volfile-save scriptlet follow .rpmsave convention.
Change-Id: I7a106defcc441679cf7c48f78eea2c04feb2853e
BUG: 764702
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/788
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 4eaa1a58950604802f2e101e4d7774874b392ec6
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Jan 26 16:11:02 2012 +0530
protocol/client: Pass the right arguments to CLIENT_GET_REMOTE_FD
Change-Id: I04f984f20964650a38009bba7711d2757151ade5
BUG: 762935
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2694
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 282b4ca0af9b3011b327c6ea320ec3f3c24ec0b3
Author: Harshavardhana <fharshav@redhat.com>
Date: Mon Jan 9 17:15:23 2012 -0800
common-utils: Add support for solaris, bsd and mac os/x
get_mem_size() is more standardized now.
Change-Id: I8e3dc29df0a64a5eb8eea4fd3965b268cb1a85c2
BUG: 772808
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/2618
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e0ba908756e8bcec954fd2bcd3a7534f5558e6ab
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Wed Jan 25 07:01:48 2012 -0500
Add format/printf/attribute to log decls
This enables compile-time checking of printf-style format checking
Reason for doing it this way: N/A
Description of test cases: N/A
Change-Id: I9e26a5dceef5b545b9434b1d418c3d1193b4ef9a
Signed-off-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.com/2693
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 05e63b5b7f0ec6e7b120445c07385ff3d4ab64f8
Author: Venky Shankar <vshankar@redhat.com>
Date: Tue Jan 24 10:52:00 2012 +0530
geo-rep: gsyncd: Python3 compat fixes
Change-Id: I2eef82faab3eed1189e3786a5dca296773e1caa0
BUG: 784498
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/2690
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
commit d81f208a68e40b0631f4c2089625a601166ea310
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Jan 24 15:53:52 2012 +0530
protocol/client: if the remote_fd is -1, then unwind instead of sending the call to server
For calls with remote_fd set to -1, client xlator is sending the call to the
server which results in server not resolving it and thus fd being NULL. Locks
xlator when tries to get the inode context using the fd it segfaults. To avoid
it unwind the call in the client xlator if the remote_fd is -1.
Change-Id: Ic34a49fdf1012dd371f4b194703c0be74f29bda2
BUG: 784187
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2684
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 3d92b02ee56a9afce7e285a5601b8111cf73559e
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Dec 23 10:00:28 2011 +0530
protocol: allow extra data in all the 'fops' over wire
Change-Id: I3920c68b5b317fc4a4acfd26d64d900bf7bd59d1
BUG: 782265
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/2511
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 11a7e87cdcb029a60375f17688625eaecf939b2d
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Jan 21 20:05:55 2012 +0530
complete the implementation of missing 'f**xattr()' fops
in debug/* and cluster/* translators and a syncop_fsetxattr()
added a test case for testing the working of 'f-fop()' on
fuse mount.
Change-Id: I0c2aeeb30a0fb382ef2495cca1e66b00abaffd35
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 766571
Reviewed-on: http://review.gluster.com/802
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 5e51b31916fba70755d8ef929adf4d178d8317ff
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jan 17 05:57:24 2012 +0530
core: add 'fremovexattr()' fop
so operations can be done on fd for extended attribute removal
Change-Id: Ie026f1b53793aeb4ae33e96ea5408c7a97f34bf6
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 766571
Reviewed-on: http://review.gluster.com/778
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 0b5d93228d88083ca6cc5de481821d441263d86b
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Jan 5 15:38:32 2012 +0530
cluster/dht: handle ENOENT err in rename fop
A ENOENT should not be a error propogated for rename failures.
As, ENOENT can arise only due to internal unlink call of rename.
Change-Id: I925622da8ef370d0385bc5b30cf8dc9b8e852beb
BUG: 768879
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/2583
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 0b8a098f7acd6d651439c25b23d56b809fb6da75
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jan 18 18:06:44 2012 +0530
core: get xattrs also as part of readdirp
readdirp_req() call sends a dict_t * as an argument, which
contains all the xattr keys for which the entries got in
readdirp_rsp() are having xattr value filled dictionary.
Change-Id: I8b7e1290740ea3e884e67d19156ce849227167c0
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 765785
Reviewed-on: http://review.gluster.com/771
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 0ea283c631ebe12bf9fc5d8a82b19f6ba93ae12a
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jan 17 05:28:51 2012 +0530
core: change lk-owner as a 1k buffer
so, NLM can send the lk-owner field directly to the locks translators,
while doing the same effort, also enabled sending maximum of 500 aux gid
over protocol.
Change-Id: I87c2514392748416f7ffe21d5154faad2e413969
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 767229
Reviewed-on: http://review.gluster.com/779
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit a5f1dcc58b855a54a16da798b25fff4b58294edc
Author: Shylesh Kumar <shylesh@gluster.com>
Date: Tue Jan 24 12:14:36 2012 +0530
cluster/afr: set loc->gfid for building root loc
Change-Id: Icb902846d243df0502f664bfd187280cecd4397c
BUG: 784176
Signed-off-by: Shylesh Kumar <shylesh@gluster.com>
Reviewed-on: http://review.gluster.com/2681
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e4e81879bd864a66eca0132b5f45d3f2ee05edc4
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Jan 24 12:03:56 2012 +0530
glusterd: fix transpose of memset arguments
a fix for transposed arguments to memset in glusterd_get_all_volnames
function introduced in volume status enhancement.
Change-Id: Iaea60c7d19b23992684f91b016b0841e2153b0a9
BUG: 765464
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2680
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 31c7252bb6fe60acedc2e00c250abd2a4f92e357
Author: Harshavardhana <fharshav@redhat.com>
Date: Mon Jan 23 13:20:04 2012 -0800
Revert "distribute: utilize new 'fremovexattr()' fop for rebalance"
This reverts commit c4e4be31ec2783b984e7dbb9ecbc1eea84044ad0 ..
There is a problem here. syncop_fremovexattr doesn't exist in the codebase yet. Have a dependency merge for this. No other patches can be uploaded without a build failure now.
Change-Id: Ic2c6194d905ffcfa7cbdc29c9bc8739f628d404e
Reviewed-on: http://review.gluster.com/2679
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 84c496da588e40fe30098b865bead57a219d4436
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Thu Jan 19 18:09:34 2012 +0530
pump: move internal pump xattrs out of trusted domain
* the trusted.glusterfs.pump.{start|pause|commit|status|abort} xattrs
have been moved out of trusted domain. This enables separation of
xattrs used as gluster-internal commands (handled by pump) for
replace-brick, which are not set in the back-end, from xattrs set
on the replace-brick source and destinations bricks.
* macros definitions from pump.h and glusterd.h, #defining these xattrs
have been merged and put into libglusterfs/src/glusterfs.h
Change-Id: I87b8bfbf045aa140f5d3f0c9baa9b2e79f87b67b
BUG: 783049
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2663
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9f5c8525abd2a62d3794bfd00e7671a926482cbf
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Dec 16 18:27:52 2011 +0530
distribute: utilize new 'fremovexattr()' fop for rebalance
instead of existing 'syncop_removexattr()' which is not rename proof
for now.
Change-Id: I3b2afbe58ce90658100cc56b01e23bed672854e8
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 766571
Reviewed-on: http://review.gluster.com/803
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 0977fccd66e811ac4f345cb9d986cda7517bd787
Author: root <shishirng@gluster.com>
Date: Mon Jan 23 14:32:31 2012 +0530
storage/posix: Pass correct size to sys_lgetxattr
We were passing op_ret (0), instead of size variable obtained by previous
sys_lgetxattr to determine the size
Signed-off-by: root <shishirng@gluster.com>
Change-Id: I886dedc2ab752ac1feabe7a79725ea5f069d6865
BUG: 783916
Reviewed-on: http://review.gluster.com/2676
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rahul C S <rahulcs@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 2ede535f3143befe2c87e38f241a52ec12bb3b39
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Jan 13 06:12:11 2012 +0100
rpc: extend actors with flag signing if privilege is required
Currently we allow the following RPC messages for unprivileged users:
GLUSTER_CLI_GETWD, GLUSTER_CLI_MOUNT, GLUSTER_CLI_UMOUNT
Change-Id: I05414f3ca7cbe47de45c5e5cfba1537efc774e6c
BUG: 781256
Signed-off-by: Csaba Henk <csaba@gluster.com>
Reviewed-on: http://review.gluster.com/2641
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 45970cf75b3ff22b71fe20c0f46a297b0729777c
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Jan 13 06:05:34 2012 +0100
cli: exit with error if connection problem occurs
Change-Id: I97fc4d0a260120810b71dd5d9957a269d4550a3b
BUG: 781256
Signed-off-by: Csaba Henk <csaba@gluster.com>
Reviewed-on: http://review.gluster.com/2640
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit fa4d82247e39daa5dd212bc2b0ab43245ba83f5d
Author: Anand Avati <avati@gluster.com>
Date: Fri Jan 13 23:17:07 2012 +0530
nfs: changes for using nameless lookup and anonymous FDs
- Use gfid to create filehandle instead of encoding path components
- Utilize nameless lookups of GFID for deep resolution instead of
crawling the namespace with component hints
- Use anonymous FDs for file based operations
- Do away with fdcaching code for files and dirs
Change-Id: Ic48fb23370b25d183f7e1fc1cc5dffa9d5bab3fb
BUG: 781318
Reviewed-on: http://review.gluster.com/2645
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit a4127d3141b1ff9db262d78eb78d88f0ae6afda1
Author: Anand Avati <avati@gluster.com>
Date: Fri Jan 13 13:27:15 2012 +0530
core: GFID filehandle based backend and anonymous FDs
1. What
--------
This change introduces an infrastructure change in the filesystem
which lets filesystem operation address objects (inodes) just by its
GFID. Thus far GFID has been a unique identifier of a user-visible
inode. But in terms of addressability the only mechanism thus far has
been the backend filesystem path, which could be derived from the
GFID only if it was cached in the inode table along with the entire set
of dentry ancestry leading up to the root.
This change essentially decouples addressability from the namespace. It
is no more necessary to be aware of the parent directory to address a
file or directory.
2. Why
-------
The biggest use case for such a feature is NFS for generating
persistent filehandles. So far the technique for generating filehandles
in NFS has been to encode path components so that the appropriate
inode_t can be repopulated into the inode table by means of a recursive
lookup of each component top-down.
Another use case is the ability to perform more intelligent self-healing
and rebalancing of inodes with hardlinks and also to detect renames.
A derived feature from GFID filehandles is anonymous FDs. An anonymous FD
is an internal USABLE "fd_t" which does not map to a user opened file
descriptor or to an internal ->open()'d fd. The ability to address a file
by the GFID eliminates the need to have a persistent ->open()'d fd for the
purpose of avoiding the namespace. This improves NFS read/write performance
significantly eliminating open/close calls and also fixes some of today's
limitations (like keeping an FD open longer than necessary resulting
in disk space leakage)
3. How
-------
At each storage/posix translator level, every file is hardlinked inside
a hidden .glusterfs directory (under the top level export) with the name
as the ascii-encoded standard UUID format string. For reasons of performance
and scalability there is a two-tier classification of those hardlinks
under directories with the initial parts of the UUID string as the directory
names.
For directories (which cannot be hardlinked), the approach is to use a symlink
which dereferences the parent GFID path along with basename of the directory.
The parent GFID dereference will in turn be a dereference of the grandparent
with the parent's basename, and so on recursively up to the root export.
4. Development
---------------
4a. To leverage the ability to address an inode by its GFID, the technique is
to perform a "nameless lookup". This means, to populate a loc_t structure as:
loc_t {
pargfid: NULL
parent: NULL
name: NULL
path: NULL
gfid: GFID to be looked up [out parameter]
inode: inode_new () result [in parameter]
}
and performing such lookup will return in its callback an inode_t
populated with the right contexts and a struct iatt which can be
used to perform an inode_link () on the inode (without a parent and
basename). The inode will now be hashed and linked in the inode table
and findable via inode_find().
A fundamental change moving forward is that the primary fields in a
loc_t structure are now going to be (pargfid, name) and (gfid) depending
on the kind of FOP. So far path had been the primary field for operations.
The remaining fields only serve as hints/helpers.
4b. If read/write is to be performed on an inode_t, the approach so far
has been to: fd_create(), STACK_WIND(open, fd), fd_bind (in callback) and
then perform STACK_WIND(read, fd) etc. With anonymous fds now you can do
fd_anonymous (inode), STACK_WIND (read, fd). This results in great boost
in performance in the inbuilt NFS server.
5. Misc
-------
The inode_ctx_put[2] has been renamed to inode_ctx_set[2] to be consistent
with the rest of the codebase.
Change-Id: Ie4629edf6bd32a595f4d7f01e90c0a01f16fb12f
BUG: 781318
Reviewed-on: http://review.gluster.com/669
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 22046d4903235d5edfc2dbef6481f8859efcb8e3
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Jan 18 13:59:32 2012 +0530
glusterd: Fixed crash in stop volume found using efence.
Change-Id: I84d38b8af248920a1559d05f0e4f43d3eda0f43e
BUG: 782710
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2651
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6dd507e279e3a6ebf69eeab056acfa63408f3473
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Jan 19 11:41:55 2012 +0530
cluster/afr: do not unlock without holding the lock on the fd
In afr_open_fd_fix we were unlocking the local->fd->lock, without
holding the lock on it if we were not able to get the fd context.
Now we are directly going to out and returning, instead of going
to unlock without holding the lock.
Change-Id: I0da638bbd2c269127cf111b3aac707e4a95d20c6
BUG: 783036
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2658
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6a763a0752fffc8eda9b4c8cab26d7ee4f623613
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Jan 17 11:54:20 2012 +0530
cli: trivial changes in cli-rpc-ops.c
* the get_volume_cbk has been cleaned up(w.r.t whitespace) and a memset
used where appropriate. some other functions have been
affected(in a good way) by the whitespace-dealing commands in emacs.
Change-Id: Iba473290e87747f8bb06d335db06c872a241d7cd
BUG: 781333
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2653
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0e576d3ca5db828095f81736ddba89240f968746
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Jan 18 15:16:48 2012 +0530
glusterd: Fixed crash in peer probe found using efence
Change-Id: Ie09d1e4eb9a8d338f8e5cf6360b398b196141a81
BUG: 782718
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2655
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit f843edcb2b58986ad2e8c730a632afc957395e57
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Dec 6 11:35:33 2011 +0530
core/setxattr: prevent users from setting glusterfs xattrs
* Each xlator prevents the user from setting glusterfs-internal
xattrs like trusted.gfid by handling it in respective setxattr
functions. The speacial case of trusted.gfid is handled in
fuse (Not in posix because posix_setxattr is used to set gfid).
* For xlators which did not define setxattr and/or fsetxattr,
the functions have been implemented with appropriate checks.
xlator | fops-added
_______________|__________________________
|
1. afr | fsetxattr
2. stripe | setxatrr and fsetxattr
3. quota | setxattr and fsetxattr
Change-Id: Ib62abb7067415b23a708002f884d30e8866fbf48
BUG: 765487
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/685
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 312e1fed1cc25d524175baf04878583c41456ece
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Jan 7 16:10:06 2012 +0000
trivial: gluster_pmap_actors should only use GF_PMAP_* procedures
GF_HNDSK_NULL is not suitable for gluster_pmap_actors, instead use
GF_PMAP_NULL. The actual value (0) is not different for these, so there
is no fuctional change.
Change-Id: Ibb998ebae88b457c57a42ce63dad095d2d4a22c5
BUG: 772468
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.com/2603
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit b95f7d7a471eea2c02fbfc0faf2534f98e0de41f
Author: Kaleb KEITHLEY <kkeithle@redhat.com>
Date: Mon Jan 9 12:32:46 2012 -0500
don't try to get ngroups from /proc on non-Linux systems
Emmanual Dreyfus abandoned his changes, seemingly because he couldn't
get rfc.sh to correctly generate his changed patch set. Since Mac OS
is an important port, I suggest we keep this change alive. (This
change also works on the other BSDs too)
Now with added Solaris support
BUG: 764655
Change-Id: I6a9ab7383777f9a09ab5c9a6914f45eee43461fb
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.com/2617
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit b46d04813e47d04e929784ae52ecdb160b01e87a
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Jan 13 18:21:39 2012 +0530
cli,glusterd: Display volume UUID in the output of 'volume info'
Cleaned up some leaks along the way.
Change-Id: Ibc76c539eee935c0630f9580d0d914814b1a6fe1
BUG: 781445
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2643
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit a557baa0a5ea229165e8c3462241e8df53980d7c
Author: Harshavardhana <fharshav@redhat.com>
Date: Tue Jan 3 16:05:51 2012 -0800
cluster/distribute: dht_aggregate() fix a logic error before xattr comparisons
Change-Id: I20f015263bed9851225005d5f41a5d518bd22592
BUG: 769691
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/2557
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit f3d5cebbfe270d764f9100d1e2f2ec94494abce6
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Jan 7 22:05:11 2012 +0000
trivial: correctly document that GLUSTER_CLI_VERSION=2 matches version 0.0.2
Change-Id: I0d7eb0ac67ad83e5f21b60cc2acc514ac602ea42
BUG: 772469
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.com/2604
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit a4ee50aa9664c12a52f448ea64c0c8cf4df3863b
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Fri Jan 6 16:02:55 2012 +0530
glusterd: prevent adding bricks already in use
The add-brick command now checks if the brick provided for
add-brick is used in any volumes, even if the volume was
never started by looping through the brick lists of all
volumes.
Change-Id: I15035d41d91386448a3e3d4063d909b880288681
BUG: 771831
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2607
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 8aec399ca537d9564ee89f236631fb71a50520de
Author: Harshavardhana <fharshav@redhat.com>
Date: Wed Jan 11 12:24:38 2012 -0800
common-utils: Cleanup old stuff and standardize
Change-Id: If15058c3a1cc4070d1ebbabe37e012a70353310e
BUG: 769691
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/2635
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit beb868866917903529c875a0f0083400bf0018de
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Dec 27 15:09:39 2011 +0530
glusterd: improve replace brick status message
when replace-brick status is invoked without starting
replace brick on the specified bricks, appropriate error
message is displayed
Change-Id: I57230db84314caf807f1ff54f74307d85bdc1633
BUG: 769926
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2531
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit fb1ef5aec0b67fa782f5221cffb76c3bd8002b79
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Mon Dec 19 23:40:11 2011 +0100
posix-acl: properly process umask in case client sent it
FUSE used to interpret the umask itself. That was a bad idea, since
there are cases where umask is not applied, such as when extended POSIX
ACLs are present and default ACLs are set on parent directory.
The FUSE bridge was changed to send original mode with umask (alongside
masked mode, for compatibility). If that is the case, we decide whether
to apply the umask or not in the posix-acl translator depending on
whether a default umask is set, or not.
The original, broken, behavior is preserved in following cases:
* Unpatched client (not sending umask with original mode)
* Unpatched server (not understanding umask with original mode)
* Old FUSE on client side (FUSE < 7.12 or linux < 2.6.31)
(can not find out the umask and original mode)
Change-Id: I2e3bfc4c7c9611bc51119ca5c8e28f6582677516
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Tested-by: Lubomir Rintel <lubo.rintel@gooddata.com>
BUG: 765508
Reviewed-on: http://review.gluster.com/668
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 934cf73beca959181cb9de7d87e0ab4a754b799e
Author: Lubomir Rintel <lubo.rintel@gooddata.com>
Date: Thu Nov 3 08:51:50 2011 +0100
fuse-bridge: preserve original mode and umask
FUSE used to interpret the umask itself. That was a bad idea, since
there are cases where umask is not applied, such as when extended POSIX
ACLs are present and default ACLs are set on parent directory.
Thus, FUSE was changed to pass umask to operation handler itself in case
the fuse server is initialized with FUSE_DONT_MASK. In case FUSE
supports it, gluster client sends mode unmasked and umask separately (
masked mode is still sent, for compatibility with old servers).
the mode as-is for compatibility with older clients.
Change-Id: I55862b39a25261446f18ba0b3c03f85b41c4d722
Signed-off-by: Lubomir Rintel <lubo.rintel@gooddata.com>
Tested-by: Lubomir Rintel <lubo.rintel@gooddata.com>
BUG: 765508
Reviewed-on: http://review.gluster.com/667
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit bd431ddd93baabe2da556f022aa8eaa66f95908a
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed Dec 7 20:51:03 2011 +0530
cli: volume status enhancement
* Support "gluster volume status (all)" option to display all
volumes' status.
* On option "detail" appended to "gluster volume status *",
amount of storage free, total storage, and backend filesystem
details like inode size, inode count, free inodes, fs type,
device name of each brick is displayed.
* One can also obtain [detailed]status of only one brick.
* Format of the enhanced volume status command is:
"gluster volume status [all|<vol>] [<brick>] [detail]"
* Some generic functions have been added to common-utils:
skipword
get_nth_word
These functions enable parsing and fetching
of words in a sentence.
glusterd_get_brick_root (in glusterd)
These are self explanatory.
Change-Id: I6f40c1e19810f8504cd3b1786207364053d82e28
BUG: 765464
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/777
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 0229bc4b731576f4587e186835f0cd10d3b02fa5
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Jan 11 10:38:45 2012 +0530
mount/fuse: Fix memory leaks
Change-Id: Iff10650dc8234f9d8ca0472f2e1ea9c60fbd6d4e
BUG: 773211
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2630
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 5357f79ff9a4c347d828e6fadf95ea8ff3eaf17c
Author: Anand Avati <avati@gluster.com>
Date: Thu Dec 8 11:08:48 2011 +0530
core/stack: perform locked winds
In configurations like pump, where there is a cluster translator on
top of io-threads, there are situations where two concurrent stack-winds
can be performed on the same call stack in multiple threads. This patch
holds locks during the call frame list manipulation
Change-Id: I51539210dc8101f7a80cf9bc103b5eff0c86dc9f
BUG: 765522
Reviewed-on: http://review.gluster.com/774
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 9727cdbf41cdf910ed09691150b97dc008a28239
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Jan 9 17:03:21 2012 +0530
cli: Corrected replace-brick error messages and usage string.
Change-Id: I2739529ca572fd762fbbed27de9e433e8c5b1f81
BUG: 772583
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2613
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c1ef6b38bda2d0704008bd57bbcda214003583d0
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Jan 9 19:48:44 2012 +0530
cluster/afr: Remove dead code
Change-Id: I239128c51b728fbb7814fd6a41020b76c88fbd93
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
BUG: 772876
Reviewed-on: http://review.gluster.com/2623
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 75ac54026a2b6c394de2520f98100fbae6909863
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Mon Dec 26 14:39:24 2011 +0530
extras: add check for brick path existence
Adding a couple of checks to validate brick path(s)
Change-Id: I2d8538add21407d9457542373b528c2a02cd7eb6
BUG: 765572
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2514
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b7bb15003e26d31d49a18c831b5e944b7bcc403f
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Wed Jan 4 13:06:29 2012 +0530
lib/mount-broker: move utility functions to common-utils
functions skipwhite and nwstrtail have been moved from
mount-broker to common-utils library for general use.
Change-Id: I9cfefb28bbfcf5d0bd37e35865ff3f3b7923fc53
BUG: 765464
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2560
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Reviewed-by: Csaba Henk <csaba@gluster.com>
commit 08c9ee5603ad278b5d8d77967af292095d26dc85
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Jan 5 11:21:25 2012 +0530
glusterd: Fixed add-brick error message.
Change-Id: I9260d5a0203ae2990d37b30bcc7c94c81c1e168e
BUG: 770678
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2581
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit d12adc31393c7536eb3816bfb6b3bbe2b177fed2
Author: Junaid <junaid@gluster.com>
Date: Wed Jan 4 12:46:53 2012 +0530
features/marker: xtime should not be updated for modifications done by special client.
Change-Id: Ia577422dedb94a1febeceb2a50cabf61d48cb714
BUG: 769494
Signed-off-by: Junaid <junaid@gluster.com>
Reviewed-on: http://review.gluster.com/2559
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushik BV <kaushikbv@gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Csaba Henk <csaba@gluster.com>
commit 16df6dc77cf5dbfde995912fd21a99c3c37abd8d
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Jan 4 19:05:18 2012 +0530
glusterd: Added checks for remove-brick handler.
Removing bricks in a plain stripe-replicate is failed
if replica count is not reduced explicitly.
Change-Id: I6d0de4862595744d1d1998b9a287c34c53d7fe5f
BUG: 770561
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2577
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e10cd5c06db5a7a481fe21ade3424b4b2aa094b2
Author: Harshavardhana <fharshav@redhat.com>
Date: Tue Jan 3 11:07:00 2012 -0800
libglusterfs: Add boundary conditions to data_to_int8() function.
Change-Id: Iff50d44568895a75fc8743a10346990f764cf8fa
BUG: 769692
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/2556
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1e7f45403e5f2e93dba69dd2be52a8a7fb2e2d77
Author: Rahul C S <rahulcs@redhat.com>
Date: Tue Jan 3 22:24:22 2012 +0530
Avoid setting dict when size is -1
when lgetxattr fails and returns size as -1, we
still try to set the dict. Instead it should set
proper errno & exit.
Change-Id: I282dc0765e562bd9bbcf852453cd3b72d918b269
BUG: 771313
Signed-off-by: Rahul C S <rahulcs@redhat.com>
Reviewed-on: http://review.gluster.com/2555
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 74342f11e114d54b61c7f69df121b8ea98d91399
Author: Venky Shankar <vshankar@redhat.com>
Date: Sun Jan 1 23:48:15 2012 +0530
cluster/stripe: Fix block size reported in pathinfo xattr
Block size (or stripe size) is reported when request is made
for pathinfo xattr (trusted.glusterfs.pathinfo) for a striped
volume. When the block size is changed, the new block size is
reported for files created with older block size. This can be
confusing ( or even erroneous ) for applications relying on
pathinfo xattr to find chunks in backend.
Change-Id: I79cb6721bbd33f44c3fada4dd52e459d2c128e24
BUG: 766530
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Reviewed-on: http://review.gluster.com/2545
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8c509eaae8a0c9db61db47334a3e461fcd96dee3
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Jan 2 18:40:31 2012 +0530
glusterd: Fixed add-brick handler algorithm.
In the fix for 765774, setting the op dictionary with modified stripe
and replica count was (accidentally) removed affecting the correctness.
The stage and op functions of add-brick rely on the fact that stripe/replica
count are zero if there is no change in them during the add-brick operation.
Change-Id: I55a23878e618b355009ffd0fce8c4904dbb70691
BUG: 770914
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/2548
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a5b29bc9138ced261ee8742b12126376e90512a1
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Dec 15 16:51:02 2011 +0530
cluster/afr: Handle fini for afr,pump
Change-Id: Idc0a05a8a25f278a7ab05e242263e0a5001bde18
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
BUG: 767862
Reviewed-on: http://review.gluster.com/800
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ec5dd8ba126d4f776b4c488d3501a9b5c299aa24
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Dec 29 11:58:21 2011 +0530
cluster/afr: EIO should overwrite ENOENT in lookup
In case if lookup decides there is a gfid-mismatch,
some enoents and self-heal cant remove the stale entry,
it tells lookup to unwind with EIO but since ENOENT
has more priority it is not over-written, this patch
fixes that case.
Change-Id: Icd68c4a5cf05dd97c568964ab647a34fdb6e26f4
BUG: 765528
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2541
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit cb64de4d07feec5cc796888b5ed44077d72e5194
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Dec 23 14:57:37 2011 +0530
mgmt/glusterd: log the rebalance command received properly in the log file
Change-Id: If18d9a49f5a3442755440e08ee7a63f6c6e54c5d
BUG: 770058
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/2500
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit d6bafa007feba9ce5246edd554575507596f2622
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Dec 23 11:49:02 2011 +0530
debug/io-stats: Handle fini for io-stats xlator
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: I0b36a2f4836fa84ced7414fdba4d68e0cb6cac7b
BUG: 767862
Reviewed-on: http://review.gluster.com/2499
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 6522a03eab9e5476fd0aaacfe453ab117c060b67
Author: Rahul C S <rahulcs@redhat.com>
Date: Fri Dec 23 03:28:13 2011 +0530
Added/Removed white spaces wherever necessary in replace-brick
Change-Id: Ic11d04813109bc6252e4dfe754c7b4c5c74014cd
BUG: 769985
Signed-off-by: Rahul C S <rahulcs@redhat.com>
Reviewed-on: http://review.gluster.com/2498
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 4541f5802ef80e37adf76d1961e52d0bb14766c3
Author: Harshavardhana <fharshav@redhat.com>
Date: Fri Dec 2 16:57:22 2011 -0800
mount/fuse: Cleanup / remove unnecessary comments
Change-Id: If236e82c2e89d2ab4a0e3278319976aeb9fc05a6
BUG: 769691
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/2491
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@gluster.com>
commit b1f81fba57ea174cee9ed6807a0bbde16790feef
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Dec 28 12:09:08 2011 +0530
cluster/afr: Handle error cases in local init
- Fop should unwind with appropriate errno
- Local is de-allocated on errors
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Change-Id: I4db40342ae184fe1cc29e51072e8fea72ef2cb15
BUG: 770513
Reviewed-on: http://review.gluster.com/2539
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c75dc484382df40f230dc22c79be8b75fac08862
Author: Rajesh Amaravathi <rajesh@gluster.com>
Date: Wed Nov 23 12:52:04 2011 +0530
rebalance: remove the *.fix.layout xattr from trusted domain.
moving trusted.distribute.fix.layout from trusted domain.
Change-Id: If4317e4320998bbd739a8472b8814d75c425d341
BUG: 765487
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/747
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 46cd86e906ae6163504d8e6a8135c498ab46852c
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Dec 25 22:17:08 2011 +0530
build: Change dependency of rsync version for geo-replication
Change-Id: Iaf49121ef04bb02114f74cdc2fd2985a564d5407
BUG: 764476
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Reviewed-on: http://review.gluster.com/2505
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit aba5b0a838cf195e1b1e7c74140304529b2180fe
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Dec 26 10:10:13 2011 +0530
cluster/afr: Handle split-brain/all-fool xattrs for directory
In case of split-brain/all-fool xattrs perform conservative merge.
Don't treat ignorant subvol as fool.
Change-Id: I6ddf89949cd5793c2abbead7c47f091e8461f1d4
BUG: 765528
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2521
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7c87a1e9baa7416affe38ae463565f3be3e86852
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Dec 21 10:43:28 2011 +0530
features/posix-acl: handle fini for features/posix-acl
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: I6cd3a9c3a513cc2a998b82610613bbfa0622eec4
BUG: 767862
Reviewed-on: http://review.gluster.com/811
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit df64fc17725e236387e0ea3b5f885c6baba2aeaf
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Dec 13 12:58:25 2011 +0530
extras: clean up a brick's gfid xattr
* extras/clear_xattrs.sh: This script enables a brick from a
deleted volume(stale brick) to be used in a new volume by
clearing all the trusted.gfid xattr from the brick tree.
* One should run this script on all machines which have
stale bricks if one wants to re-use the same bricks
for a new volume.
NOTE: This script *SHOULD BE RUN ONLY AFTER STOPPING A VOLUME*,
thereby ensuring that no replace-brick or rebalance operations
are on-going.
Change-Id: I35a4a2784fe502749184b87299b1a043b8e48e90
BUG: 765572
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/781
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6f9b7bcaa2196afb77e0084915adefda756e8441
Author: Rahul C S <rahulcs@redhat.com>
Date: Thu Dec 22 13:17:21 2011 +0530
Improve cli output of gluster volume heal command.
Improving cli outputs according to the type of the volume,
the "heal" action can be performed on the volume.
Also checks if the volume is started & then if the
"self-heal" daemon is not started, prints appropriate
message.
Change-Id: I25b0822e4d518c50e2f1173aa8c7c11ae6b76d3f
BUG: 769774
Signed-off-by: Rahul C S <rahulcs@redhat.com>
Reviewed-on: http://review.gluster.com/2496
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 942faaf8de14ac7704732f63a274d199038b2aaf
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Dec 20 10:05:12 2011 +0530
cluster/afr: Set pargfid when missing
client asserts for missing pargfid in case of unlink. So
Afr needs to make sure it is present in that fop.
Change-Id: Iea0ad65e1e7254c8df412942c52d5870e853aa51
BUG: 769055
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2495
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 4de84bc49ea5576aa404534181c67a33f50cc8fb
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Dec 19 22:10:38 2011 +0530
libglusterfs: set inode path to be NULL in case of errors
Some of the functions calling inode_path, __inode_path
are assuming the path to be set to NULL in case of errors.
Instead of fixing it in the calling functions, fixing it in
the __inode_path function.
Change-Id: I77736a2700d3c2c9732a536bcf2a398fe626d54e
BUG: 765430
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/810
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f34c49b2ce6dedf053b1904561b31cef2e06fd46
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Dec 19 18:35:19 2011 +0530
protocol/server: Do connection cleanup if reply fails
We observed that after the first connection cleanup happens on
DISCONNECT the lock calls in transit are granted or added in
blocked locks queue. These locks were never cleaned up after that
because no unlock would come up on that connection. This would
leave references on that transport so it would never be destroyed.
Now, the connection cleanup happens whenever the reply
submission fails.
Also cleaned up the old code which is not used any more.
Change-Id: Ie4fe6f388ed18d9c907cf8ae06b0b7fd0601a660
BUG: 765430
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/809
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b9bb7b72065540bb09330bd9acd6ad4446efef99
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Dec 19 12:45:34 2011 +0530
features/locks: Fix release of locks on disconnect
When a disconnect comes on a transport, all the locks on that
transport should be cleared irrespective of entry presence.
Change-Id: I1c432ec1ddc8fe3f7bf236992f47437d0dacd6ae
BUG: 765430
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/808
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 75a2a002372fff51aca65cb0d5ed66c3789ea5c4
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Dec 16 21:47:14 2011 +0530
cluster/afr: Fix meta data lock range
Change-Id: I7615f31309c6c8f5373e1ff0535d84396dfa1455
BUG: 765430
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/807
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 83899319c4a3cfefb836843095481cf76445741b
Author: Harshavardhana <fharshav@redhat.com>
Date: Fri Dec 2 16:58:14 2011 -0800
transport/rdma: Add attr_timeout, attr_retry_cnt, attr_rnr_retry as configurable options
Change-Id: Ifc4710f149be35979746ddfbfb4181638601bc64
BUG: 766040
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/766
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a6a3a544e745e91cbbd0cf41c9d2b641cf7b867d
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Dec 19 12:42:31 2011 +0530
glusterd: Fixed spurious checks in add_brick.
Previous algo,
- didn't allow volume type change from plain distribute
to distribute-[stripe][-][replicate].
- performed 'add-brick' on temporary volinfo without correct
initialisations. This was superflous.
Change-Id: If5d5d78e59bd04685df9c27974f715df5f0b43f3
BUG: 765774
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/804
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 226da1a85706ee195d8986e48357ee6112229c44
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Dec 13 17:13:59 2011 -0500
Fix local==NULL crash in wb_sync_cbk during disconnect.
Change-Id: I26dc48a85756e189b1ef5cfef1658f9c2aed2157
BUG: 767359
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/784
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1c457c91cd1569b344c13c066138aa6b6ffdc7ec
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Dec 15 22:16:13 2011 +0530
cli: validate the volume set command properly
For volume set command if after the volume name the key and the
value of the option are not given, then gracefully exit by
showing the proper usage of volume set, instead of sending the
request to glusterd, which makes glusterd crash.
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Change-Id: I2f0d189a55663c7f47dddff35d4dc68fae16b755
BUG: 767591
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/797
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 57c47f137472c10b17f47d55c590267a2643b7dd
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Dec 19 16:36:33 2011 +0530
cluster/stripe: copy the gfid from the dentry structure to loc
In stripe_readdirp_cbk we used to send stat call on each of the entry
we have got from readdirp, by creating a new inode (but without
setting the gfid in loc). Protocol/client asserts if it cannot find
gfid in either loc or loc->inode. This patch copies the gfid of the
entry from the stat structure to loc.
Change-Id: I35228227e943f3b01fac720d6c587764c47e6869
BUG: 768840
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/806
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit 2b90347352b385f13edbeb8e93f9bf6414a813ba
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Dec 15 15:13:14 2011 +0530
rpc-transport/socket: Donot fail reconnect if error is ENOENT
A AF_UNIX family socket should retry connect if error is ENOENT.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Change-Id: I23b1da12faadc8043d370862bfe29c0c5c223364
BUG: 767932
Reviewed-on: http://review.gluster.com/795
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit de63a721d2725dbeea6c5b23683d1a02eca4ae24
Author: Rahul C S <rahulcs@redhat.com>
Date: Thu Dec 15 18:16:29 2011 +0530
Default option to be set to "all" if no option is given to volume statedump cli command.
Change-Id: Ia167e9d0fd1f9a50f79554d40e6fa7d292896aa4
BUG: 767545
Signed-off-by: Rahul C S <rahulcs@redhat.com>
Reviewed-on: http://review.gluster.com/799
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit c5a295566d71eb77c98e570e580ee46d58a4a537
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Dec 14 14:46:09 2011 +0530
glusterd: Fail 'requests' from non-peers.
glusterd should not honour "volume op requests" from peers who are not
part of the cluster.
Change-Id: I6cb6d630a9da02ab060650f21edb46db8deb70e8
BUG: 767559
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/787
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7b04d75768e122f84c31b3aa4f410acd9a4e2909
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Dec 14 10:36:27 2011 +0530
debug/error-gen: add option to generate errors at random percentage
Currently error-gen has a option where the percentage of the errors generated
can be specified. This patch adds a new option, which if given errors
are generated at random percentage. If both the random failure option and
the specific percentage of the errors are provided, then random error
generation is given preference.
Change-Id: I43fffcd7da8935761ed7d30e2a9677895d6a31fb
BUG: 767192
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/786
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit db613a52d0e85eff20e5bb1fd1a3e9b46c4f9921
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Dec 6 14:00:40 2011 +0530
protocol/client: Be strict about gfids in fop req
Change-Id: I7508ab3a93329bb6a679801fddfcd0e5b0c7c134
BUG: 765198
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/770
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0b8af8182eada439b5ed1b9620a3890226cc6b73
Author: Rajesh Amaravathi <rajesh@redhat.com>
Date: Tue Dec 13 15:26:55 2011 +0530
mount/fuse: export PATH for which in mount script
exporting PATH environment variable for mount.glusterfs.in
to correct the "which: no getfattr in ((null))" error
during fuse mount.
Change-Id: Id7d024c0d1cf3d265489557897e9e1f8e7ce4ce4
BUG: 765561
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/782
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 82fc119fa623d747e56e55d3bcdad804944ac273
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Dec 13 15:54:49 2011 +0530
cluster/afr: Double the call count if transaction is for rename
In rename the changelog modification needs to happen both on
old parent-dir and new parent-dir, so 2 stack winds are
done per brick.
Change-Id: I43f34661e397c4288162213944529e18b7724b1d
BUG: 766603
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/783
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 59cbd11c7ffc447e32353de12272411a1cb33a7d
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Nov 24 15:42:55 2011 +0530
fuse: bring in the reverse invalidation
Thanks to Csaba Henk <csaba@gluster.com> for the patch
Currently one can invalidate the inodes using 'setxattr()' with
key 'inode-invalidate' (and any value). This can be further
extended to do a purge of inode table itself.
Change-Id: I165d5d585ed808b9e463ac0aad859ec64568c7a2
BUG: 762277
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/324
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit be58b35189c28b39e24ec47fe3afb707831aab54
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Dec 8 11:42:50 2011 +0530
iobuf: fix a crash in iobuf when statedump is taken
With the previous patch this change was missed.
Change-Id: If536cef3fa423415eaa4104e6c3e5e72c5d0a22d
BUG: 3854
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-on: http://review.gluster.com/775
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 85a3e6356f5fc83e40b3c1b9f336bc375c2fbb52
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 27 18:01:29 2011 +0530
libglusterfs/iobuf: have fixed number of arenas
* so overall memory usage will be in limit.
* the array is hard-coded, need to improve upon this.
* need more benchmarking to tune the proper values to the array
* fixed the issue of pruning of arenas.
Change-Id: I38a8ffab37378c25d78f77a2d412b1b8935c67d3
BUG: 3474
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/543
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 5f27981373ae8606cd195e46e9cf6d5a0a72b4d8
Author: Harshavardhana <fharshav@redhat.com>
Date: Mon Nov 21 16:28:47 2011 -0800
cluster/distribute: Assert checks at known locations and new function dict_get_ptr_and_len().
Change-Id: I653a1cc8123baa36d750250d02721aa98b196f38
BUG: 3158
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/744
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a2d8c728f0bc9e1173e718c98cdd2be179e80aaa
Author: Anand Avati <avati@gluster.com>
Date: Mon Dec 5 14:18:22 2011 +0530
CONTRIBUTING: add a DCO
The new CONTRIBUTING file has a Developer Certificate of Origin with
instructions for contributors to ensure 'Signed-off-by:' line in the
commit log (git commit -s). Corresponding changes also done in Gerrit
to reject patches which do not have Signed-off-by: line.
Change-Id: Ia3e1e8d3cfd4b32e4cfd4d2df91c6dbd57e2f60e
BUG: 3234
Signed-off-by: Anand Avati <avati@gluster.com>
Reviewed-on: http://review.gluster.com/767
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 2d5776cc2d2df238451d9d14a3933fdd2b016f26
Author: Rahul C S <rahulcssjce@gmail.com>
Date: Fri Nov 25 17:21:46 2011 +0530
Changes all parent values for quota_check_limit and quota_update_size from 0x0 to NULL to make sure uuid_copy happens between pointers
Change-Id: I73ef5f9054f972fce00b8f42125dc49c9d86c3f2
BUG: 3830
Reviewed-on: http://review.gluster.com/756
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Mohammed Junaid <junaid@gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 03bb9c8a5eefe02ba3628b0ec2665a0b66b05cdd
Author: Kaleb KEITHLEY <kkeithle@f16node1.kkeithle.usersys.redhat.com>
Date: Thu Dec 1 12:44:38 2011 -0500
bz 3826, fix for parallel make in fedora build system
builds of glusterfs in the fedora build system often fail due to a
race condition between running yacc and starting to compile the y.tab.c
produced by yacc
We found that the previous fix would still occasionally trip the race
condition. This revised patch changes the automake Makefile.am to generate
the parser files without incurring the race condition. An extra dimension
of the problem is that the tarball from
http://download.gluster.com/pub/gluster/glusterfs/3.2/3.2.5/glusterfs-3.2.5.tar.gz
contains files that you don't get when you clone from the git repo (e.g.
libgluster/src/{graph.lex.c,y.tab.c}, and all the Makefile.in files) so
build issues on fedora build systems do not manifest themselves on jenkins
and vice versa.
This works on jenkins, the fedora build system, and my f16 vm/guest
machines. (Finding the right combination that works on all three was an
exercise to say the least. I'm open to other suggestions for avoiding
the race condition.)
Run autogen.sh to (re)generate the Makefile.ins. Then run configure to
produce all Makefiles, followed by `make -j X` where X>1
see also https://bugzilla.redhat.com/show_bug.cgi?id=756510
BUG: 3826
Change-Id: Iaeecb59c61a77bf3927da18253c83cf5ffed4254
Reviewed-on: http://review.gluster.com/765
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 2f725feb03d0c311c1ff2746be0727ce440584dd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Nov 24 13:50:23 2011 +0530
mount/fuse: Inherit direct-io-mode values from fds already opened, for a new fd being opened.
When an fd is being opened, it inherits direct-io-mode characterstics
(either enabled or disabled) from the fds already opened on inode. If none
are opened and user has not specified the mode through cmdline options,
default mode is used.
Change-Id: I0c9e959100e9130e46bbd16d63eca278260635b4
BUG: 801
Reviewed-on: http://review.gluster.com/55
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 1f0c7940779a4c9c8714725fd85a93fc572e4b3f
Author: Harshavardhana <fharshav@redhat.com>
Date: Tue Nov 29 15:20:48 2011 -0800
contrib/uuid: Make sure that uuid_types.h are generated per system specific. Just the same way e2fsprogs maintains. This avoids unnecessary problems for different architectures.
Change-Id: I3911998373756707996afb7b926ec0780ea18b81
BUG: 3833
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/764
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit fc4c5e3b0ab5d50074661ba7e7bd25062a5ab48f
Author: Kaleb KEITHLEY <kkeithle@f16node1.kkeithle.usersys.redhat.com>
Date: Tue Nov 29 09:36:50 2011 -0500
bz 3826, fix for parallel make in fedora build system
builds of glusterfs in the fedora build system often fail due to a
race condition between running yacc and starting to compile the y.tab.c
produced by yacc
This patch changes the automake Makefile.am to generate the parser files
without incurring the race condition
This works on jenkins, the fedora build system, and my f16 vm/guest
machines. (Finding the right combination that works on all three was an
exercise to say the least. I'm open to other suggestions for avoiding
the race condition.)
Run autogen.sh to (re)generate the Makefile.ins. Then run configure to
produce all Makefiles, followed by `make -j X` where X>1
see also https://bugzilla.redhat.com/show_bug.cgi?id=756510
BUG: 3826
Change-Id: I06ba0d0a1d59f0f44c0dd2cd9d227ca08d99e205
Reviewed-on: http://review.gluster.com/763
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 903dd6293739cdeb7c3f6371856e2a10be29202c
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Nov 21 12:35:34 2011 -0500
Add command-line support (but no doc) for enforce-quorum option.
Change-Id: Ia52ddb551e24c27969f7f5fa0f94c1044789731f
BUG: 3823
Reviewed-on: http://review.gluster.com/743
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 13cb8e783acd9a8dcf7f6e3e20c8ee3a1439a99f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Nov 20 09:13:14 2011 +0530
cluster/afr: Update read-child if it becomes stale
Change-Id: I00c714a89575023f6dbdd3430dcbf191e5d08019
BUG: 3650
Reviewed-on: http://review.gluster.com/740
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6ab62c1b865c9c6b62b3a3156a1e216c51b3ddcd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Nov 15 12:14:56 2011 +0530
rpc-transport/rdma: add gf_ prefix to all procedure, variable names
Change-Id: I251be23d2c60b88589f71e7a8c3b1f2b7e3eb3e6
BUG: 3319
Reviewed-on: http://review.gluster.com/148
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit b6f3c7d6063b618917b6a855a27fe8d10693b52b
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 16:29:28 2011 +0200
NetBSD build tweak to use linkat(2)
linkat()é is guarded by -D_INCOMPLETE_XOPEN_C063 for now since support
for OpenGroup extended API set 2 is not yet complete.
Change-Id: If1038dac61b6945c73a208c6e05f1154ff913098
BUG: 2923
Reviewed-on: http://review.gluster.com/232
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 13c1f2e7408618215a96c10a80fec657e268283c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Nov 24 09:15:29 2011 +0100
case to uint64_t when convering gfid to inode, otherwise it can get garbled on 32 bit machines.
Change-Id: Id2acc1f9ae98194d541f5468616be441896c4239
BUG: 2923
Reviewed-on: http://review.gluster.com/753
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 948f73c8be47477840717c027c0bc3aba7018de8
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 16:23:23 2011 +0200
Let NetBSD use its recently added Linux xattr API
Change-Id: Ibd365e8d83c6faf631df7cb99ec62440496fcbdf
BUG: 2923
Reviewed-on: http://review.gluster.com/230
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit be0af3e2d41221a5c91821e0824b437e7d1bfb1c
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Mon Oct 3 13:56:23 2011 -0400
Add volfile-generation hook facility.
Change-Id: I958c393ce5cfffcde8d120499a43dbe6105a082c
BUG: 3688
Reviewed-on: http://review.gluster.com/558
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 2ae584067f6bcd0e5d8fe231aaf56219bab48617
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Oct 16 08:06:18 2011 +0200
We must #include <signal.h> for sigprocmask(2). Failure to do so will break on NetBSD kernel without COMPAT_13 option.
Change-Id: Ia710bbe31ed48e4df4cd47f99e335d7226b99173
BUG: 2923
Reviewed-on: http://review.gluster.com/594
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 7b6645bcecf143c96a65ccb7baa3e4bed9d2f080
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Sun Oct 16 08:09:11 2011 +0200
usleep(3) shall not be called with argument higher than 1s
Change-Id: Ied0a2fedb3b7604f6abbf0a4aa7f71e43a5ea568
BUG: 2923
Reviewed-on: http://review.gluster.com/595
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 987b180a430003f5e1d3fa197ce1267d54739455
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Thu Nov 24 06:32:36 2011 +0100
Use /bin/mount on Linux, /sbin/mount on other systems
Change-Id: I8d2e518d29cedb1fbfa77d0189a2d4a24957e662
BUG: 2923
Reviewed-on: http://review.gluster.com/752
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit b432848c6259db085529739abd32cf9849c844f6
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Nov 10 11:09:56 2011 +0530
afr: Fixed backgroundness detection in self-heal algo.
Change-Id: I9888d8a0b86fdaf6589885766f2de7222d8c8ba2
BUG: 3802
Reviewed-on: http://review.gluster.com/705
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/745
Reviewed-by: Anand Avati <avati@gluster.com>
commit b901ca233c84360486abee6974f075bdc616489a
Author: Niels de Vos <ndevos@redhat.com>
Date: Sun Nov 13 17:45:54 2011 +0000
rpc-transport: fix some indentions
Some lines are indented with spaces, others with tabs. When Tabs are not
disaplayd as 8 spaces, the indention is completely messed-up.
Change-Id: I31ddf44c5b7f5fe1c5493adca98e95514f2920bd
BUG: 3822
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.com/742
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 61d7eaa3b54f8a652dd75acaa789dbdbceeb1051
Author: Harshavardhana <fharshav@redhat.com>
Date: Tue Nov 15 13:49:18 2011 -0800
rpm: rpmbuild fix for opensuse
Change-Id: I4ccf75288aad6d5f210bd7c51c0ce9924bb0efad
BUG: 2925
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/729
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 5aa3dc95de14bed102bbf685cdb128350d451730
Author: Sachidananda Urs <sac@gluster.com>
Date: Wed Nov 23 00:02:33 2011 +0530
Change the start/stop order of glusterd script at boot time.
In cases of client and server sharing the same machine, mounting GlusterFS at
boot time failed due to the start and stop order we use for glusterd. And people
had to resort to the idea of adding mount command in rc.local.
Currently the start and stop order at the boot time were 90 and 12, and netfs
started before `glusterd' and failed to mount GlusterFS. By changing
the rc order to 20 80 glusterd is started earlier than netfs, thus enabling
netfs to mount GlusterFS during boot process.
Thanks to: alex@net13.info for the suggestion in bug 2484.
Change-Id: I482f4dac5e5dd8bc5b8f5034c394f5dbe6c1fd3e
BUG: 2484
Reviewed-on: http://review.gluster.com/746
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Harshavardhana <fharshav@redhat.com>
Tested-by: Harshavardhana <fharshav@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit de3b3995bfc715f38fb35a6e62a067d7a34e72d2
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Oct 26 12:30:29 2011 +0530
cluster/afr: Remove treating sh_frame as special loop_frame
Change-Id: I0d87f06f989b2d4b971967c52d4898331693a801
BUG: 3675
Reviewed-on: http://review.gluster.com/735
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b9c472feb6044001d2365eb9c94e085f146afeab
Author: Anand Avati <avati@gluster.com>
Date: Wed Nov 23 18:10:51 2011 +0530
gerrit: auto-rebase test
Change-Id: I4bd0c2ad1ef5880e2de94d3bcc17158f18e114ab
BUG: 3234
Reviewed-on: http://review.gluster.com/750
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 837d6b78d46a593d513ed807a0f59eff0e3b1ed9
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Nov 23 17:49:59 2011 +0530
Whitespace cleanup
Change-Id: I6126e22694c177d3e2b0b4e98551a9038d5cdacd
BUG: 3158
Reviewed-on: http://review.gluster.com/748
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 357b1a589f5304cc49eae8fa01d72215435eb3c5
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Nov 14 10:10:27 2011 +0530
cluster/afr: Open fd fix should perform opendir for dirs
Change-Id: Iee12828ca515d44ed71d9cf97dcb8627c85f0593
BUG: 3740
Reviewed-on: http://review.gluster.com/725
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7eb786d70dc7fb4799a0c499e96b42c915e41772
Author: Harshavardhana <fharshav@redhat.com>
Date: Tue Nov 15 13:44:43 2011 -0800
cluster/distribute: Add support for 'min-free-inodes' on each distribute subvolume.
This change is required as increasingly large number of small files
would cause inodes to run out before they run out on available disk space.
It is highly necessary to support algorithmic checking of inodes too
just as we do for disk space.
Change-Id: I9b87405328d443825e239ee80ab664aceb50ee68
BUG: 3799
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/730
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 63494be34ecd65b7cd731aaa648058e9994678e7
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Nov 18 17:53:53 2011 +0530
cli: remove reference to 'RAID01' for stripe-replicate volume
Change-Id: I3a9b3059fd9b918cb32bbe724ae1125fb1f5642a
BUG: 3158
Reviewed-on: http://review.gluster.com/738
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 529cf1f3617df41ce8b56efe7cf51e5b6af67fb3
Author: Niels de Vos <ndevos@redhat.com>
Date: Sat Nov 12 17:58:44 2011 -0500
cli-cmd: call cli_cmd_unlock in the same function as cli_cmd_lock
cli_cmd_submit calls cli_cmd_lock, but cli_cmd_unlock is done in
cli_cmd_await_response. It is clearer to do the locking and unlocking in
the same function.
Only cli_cmd_submit seems to call cli_cmd_await_response, therefore
moving the cli_cmd_unlock to cli_cmd_submit should be safe.
Change-Id: I015ae0e2a404005c43606ef5258e3cfad41a88d4
BUG: 3821
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.com/721
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit caa8caabc132bd74b31dca266e481433eaba9d3c
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Nov 13 11:56:46 2011 +0530
cluster/afr: Fix memory leaks
Change-Id: I79a1c70c47649fbcf236191f174d766d5806545c
BUG: 3805
Reviewed-on: http://review.gluster.com/719
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1b43ad96271ea468f509f749144cc0a58e462628
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Nov 2 13:09:41 2011 +0530
cluster/dht: set gfid in lookup loc
Change-Id: I59599cc88be1d973c955600fdd54e6c49c77b4a2
BUG: 3770
Reviewed-on: http://review.gluster.com/681
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 39801c719582d0831fefd654cb2a30025c0cce5d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Nov 5 14:54:28 2011 +0530
cluster/afr: Handle absence of gfid in lookup
Change-Id: I6295245a7f40ba4f786f1f9f35b337f3f711128d
BUG: 3783
Reviewed-on: http://review.gluster.com/739
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8fd37232353f1f19c081a2d6ec5cfe199c7ded64
Author: Kaushal M <kaushal@gluster.com>
Date: Wed Nov 2 11:27:30 2011 +0530
fuse: enable kernel read-only mode
Enables kernel read-only mode on mounting with '-oro' and disables the gluster
read-only translator from being loaded. As a result, '-oro' is reported
correctly in the mount options.
Change-Id: If94d97836b13668974cfac61b6e5d52e19880e10
BUG: 3742
Reviewed-on: http://review.gluster.com/655
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Csaba Henk <csaba@gluster.com>
commit ad6dc55268f5c103c4a78d522987c0bacabc23cd
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Oct 5 11:47:14 2011 +0200
log to stderr if "-" is given as log-file
This works around broken /dev/stderr on some systems.
Change-Id: I017b03082ff630c4a713ae74990e88b3fa20d0e1
BUG: 3686
Reviewed-on: http://review.gluster.com/560
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit daaa5568edd5117fe44d70ab49bf703652496ed3
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Tue Sep 20 09:49:57 2011 -0400
Add quorum checks to avoid split-brain.
Change-Id: I2f123ef93989862aa796903a45682981d5d7fc3c
BUG: 3533
Reviewed-on: http://review.gluster.com/473
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e3d1e9d33fe771e3d8ebc2f4267aae701ef56196
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Nov 17 15:12:32 2011 +0530
mgmt/glusterd volume delete - Unref dict only in case of an error
Change-Id: I6edee785c69864bf42d869ed9cccb52cabc1523d
BUG: 3817
Reviewed-on: http://review.gluster.com/736
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e8c3586742bcbb0f6332773baf1823599ffba168
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Tue Sep 27 18:16:12 2011 +0530
rpc: Need to update conn->last_recieved.
This is important for protocol/client's ping_timer to function correctly.
Change-Id: I9f45d701126bb739535d9c5ec280833362bef9ed
BUG: 3816
Reviewed-on: http://review.gluster.com/512
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
commit d15fb2af1cf1d0013e8b5d13635ee8c64c161cea
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Oct 31 18:05:23 2011 +0530
glusterd:replace-brick subcmds should detect src_brick offline.
Change-Id: I686494c9c2d01fd027d333b267334842cb1dc875
BUG: 3043
Reviewed-on: http://review.gluster.com/651
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f38b2ca9143c070ea0a041403dc4f72185aa544a
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Oct 31 15:54:52 2011 +0530
glusterd: Extended glusterd_is_service_running to get svcs's pid.
Also, volume status cmd would print "N/A" if pid couldn't be
retrieved from pidfile.
Change-Id: Ie83d228b1cf86397d181885b325e337a403e6ed2
BUG: 3043
Reviewed-on: http://review.gluster.com/650
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3a8f80652f2e2626bea8179515601b45fb403e97
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Nov 7 16:13:42 2011 +0530
cluster/afr: lookup should honor gfid present in loc
Change-Id: I2319258743e478cc3a932d8ff0b2204a97cd4f8e
BUG: 3760
Reviewed-on: http://review.gluster.com/680
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d104de8a4ef1ba007270526987857342670f4ab3
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Nov 4 19:10:11 2011 +0530
dht,afr: Fixed gfid problems
*) removed uuid_generate usage in pump and afr, self-heald
*) filled the gfids for the fops which were sending no gfid in loc
Change-Id: I85da3c10f5ee2006248b0123155a60867870d202
BUG: 3760
Reviewed-on: http://review.gluster.com/679
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f9eec58b1951d31e0af93349e62675dcbc8852a5
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Nov 17 14:17:46 2011 +0530
glusterd: Fixed volume profile's "are all bricks down?" algo.
"count" key is not set if no brick in the volume (located across peers) is
running. Sending "count" even when zero bricks are running from originator
glusterd to client, simplifies "are all bricks down?" algo.
Change-Id: I2b1da13ed4b1b9276917908223c9b2c45ca024b3
BUG: 3553
Reviewed-on: http://review.gluster.com/642
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 05d1208e30544de2a74a15f1b62cfdbb9672016c
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 31 12:23:21 2011 +0530
xlator: prevent a crash in xlator_destroy due to uninitialized list
was happening when any of the dlopen() fails for xlator loading, and
xlator_destroy() was called as it was using a uninitialized list for
traversal.
now, the list gets initialized at the begining of the xl-init(), so
xlator_destroy() works smoothly.
Change-Id: I320f6fe922e6d351e6d7c0a3e8da1f6b414d3c47
BUG: 3731
Reviewed-on: http://review.gluster.com/606
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f214f6dd24cf0a3d929b43d69fb7f968cb12b97d
Author: Harshavardhana <fharshav@redhat.com>
Date: Tue Nov 15 18:58:59 2011 -0800
cluster/dht: Fix a typo
Change-Id: I6bcdc7d600ebb9ef68c60319f96cd9e28d12c861
BUG: 3809
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/732
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 09f3a5cd906c2cc1a35d7ced90d143ff9c55ce7f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Nov 7 14:42:37 2011 +0530
libglusterfs: copy the stat structure in entry_copy
Change-Id: I7a8bd3b3f9600ced4a945f07447698876933ade0
BUG: 3760
Reviewed-on: http://review.gluster.com/678
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 223b2e7000177b5b2b23ea8a723e3be3947afc31
Author: Harshavardhana <fharshav@redhat.com>
Date: Tue Nov 15 14:44:24 2011 -0800
glusterfs: An effort to fix all the spell mistakes and typo in the entire glusterfs codebase.
This patch fixes many of spell mistakes and typo in the entire
glusterfs codebase and all supported modules.
Change-Id: I83238a41aa08118df3cf4d1d605505dd3cda35a1
BUG: 3809
Signed-off-by: Harshavardhana <fharshav@redhat.com>
Reviewed-on: http://review.gluster.com/731
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 35ad1f893846f2d370ae71d3e9b18b93f851d2b3
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 28 15:41:47 2011 +0530
core: remove 'ino' variable from 'loc_t' structure
Change-Id: I53b007fbdb42313d207d5d63fbfaaa6aaf033f95
BUG: 3518
Reviewed-on: http://review.gluster.com/523
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3916d8dacce27df6440adccf82fa256f912cef32
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Nov 16 15:39:29 2011 +0530
core: remove 'ino' variable from 'inode_t' structure
Change-Id: I0f078d1753db65d2f2e0380d1b0450c114cf40dd
BUG: 3518
Reviewed-on: http://review.gluster.com/522
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d3756cd5b0cd422a3fe5f2d2ab339c1f2fb96a9f
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Nov 16 12:25:28 2011 +0530
mgmt/glusterd: more cleanup
* 'GD_OP_RENAME_VOLUME' removed
* unused handler function for rebalance is removed.
Change-Id: Id081cb02a6445c09347bacc0fdf9cd600ff94e5d
BUG: 3158
Reviewed-on: http://review.gluster.com/734
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1f3e51ed5fd611bd539376a31fa2479892b7d86f
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Nov 11 13:41:01 2011 +0530
cluster/distribute: Trigger selfheal only if rmdir succeeded once
A EACCES error also should not trigger a selfheal.
Only if rmdir succeeded on any subvol, a selfheal should be triggered
Change-Id: Ifebb980f0ebd1548adfd3be975ca52ca44c3f3ab
BUG: 3786
Reviewed-on: http://review.gluster.com/716
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a914e8acf94d6e97e4ed40125506ebaf0e097f5a
Author: Gaurav <gaurav@gluster.com>
Date: Tue Oct 11 11:15:30 2011 +0530
NFS: logging enhancement.
Change-Id: Ie1731a6b2b63e07bc49a84c2f9dd87c5b50a9f53
BUG: 3527
Reviewed-on: http://review.gluster.com/573
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ed074f053d4e513fec5ff14b688a1d67d7934052
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Nov 14 15:53:27 2011 +0530
Cluster/stripe setattr: Wind only to first_child for special files
Change-Id: Ib055578477461a24562d5da139809cf0965b931e
BUG: 3807
Reviewed-on: http://review.gluster.com/724
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit a568e20024604297f25b1cf4e31d8ff8a5599913
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Nov 10 16:39:31 2011 +0530
cluster/distribute: Use local call_cnt while winding
layout->cnt might be modified in cbk's or different threads, which
will lead to corruptions
Change-Id: Icfdab01ac583cb3d27d62f878b79e0098b597952
BUG: 3730
Reviewed-on: http://review.gluster.com/694
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 337a8fdd2ba255fa044993b600f422a639a193ab
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Nov 14 15:57:49 2011 +0530
glusterd: remove some of the stale 'log <CMD>' functions
Change-Id: Ibda7e9d7425ecea8c7c673b42bc9fd3489a3a042
BUG: 3158
Reviewed-on: http://review.gluster.com/726
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 0d1034d792b67ea7bb0798047edf780ac8433af8
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Nov 12 22:02:37 2011 +0530
mgmt/glusterd: delete volume to have dictionary as context
earlier only DELETE_VOLUME was having volume name as context, where
as all other OPs used to have dictionary
Change-Id: I5bfcc458bff3295374eb4f0b0a31f6134745debd
BUG: 3158
Reviewed-on: http://review.gluster.com/718
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit f97001908ca9f8247fd234460bbec5c8ff414491
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Nov 13 00:18:32 2011 +0530
glusterd/cli: rpc cleanup
no more backward compatibility between glusterd <-> glusterd
Change-Id: Ibfcca1c7e315a90b2639c4cba8da19b11875051a
BUG: 3158
Reviewed-on: http://review.gluster.com/610
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit cd76f9556e6ddff8579b79ab093dac17df29820e
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Nov 2 18:38:50 2011 +0530
XDR: cli-glusterd xdr consolidation
By using only 1 xdr struct for request and 1 xdr struct for response,
we will be able scale better and also be able to parse the o/p better
For request use-
gf1_cli_req - contains dict
For response use-
gf1_cli_rsp - conains op_ret, op_errno, op_errstr, dict
Change-Id: I94b034e1d8fa82dfd0cf96e7602d4039bc43fef3
BUG: 3720
Reviewed-on: http://review.gluster.com/662
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit a6da442655707498e9426a8268be77bdf1a7779b
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Fri Nov 4 21:46:08 2011 -0400
Reflect quota-adjusted values in statfs.
Change-Id: I7a2a0b1ad0aa2a972aad9712658083c61052bef2
BUG: 3813
Reviewed-on: http://review.gluster.com/675
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Mohammed Junaid <junaid@gluster.com>
commit 4822730ec3aa4c504fe28a9703d19eee6bf80b71
Author: Junaid <junaid@gluster.com>
Date: Fri Nov 11 17:05:43 2011 +0530
features/marker-quota: Use stack_wind_cookie in place of stack_wind to preserve the cookie value.
In marker_rename, some of the call back functions make use of cookies sent by the calling functions. In case of stack_wind the
frame->cookie is over written with the address of new frame.
Change-Id: I8ec98f3305700e2c3295a10dff159ca6a19a380a
BUG: 3808
Reviewed-on: http://review.gluster.com/722
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 4703180e654265a5fdcdeb5e9ddd538a23fcbceb
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Nov 7 14:09:36 2011 +0530
storage/posix: assign ino as -1 if gfid is missing
Change-Id: I422c87f977b5da083f9fcfaf20f0ca9a872da0a4
BUG: 3767
Reviewed-on: http://review.gluster.com/677
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 88da2e59d908800434664dc5ef94a03fe1f4f3a2
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Nov 9 14:20:10 2011 +0530
cluster/distribute lookup: send revalidate calls to all subvols for directories
If mkdir fails on a subvolume, layout is set taking into account
only the subvols where it was successful. stat does not trigger
selfheal, as its layout based.
Revalidate on directories needs to be sent to all subvols, to fix
the error, and not just on the layout.
Change-Id: If17055508ffcf268806258ed49e7d7500a89d0f2
BUG: 3793
Reviewed-on: http://review.gluster.com/693
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit a8771a3d952d4c3c44ef3542110c6dcab19e0ba4
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 9 14:40:02 2011 +0530
rpc-transport/rdma: send correct vector count when both rpc-header and program-header are received through rdma-reads.
Change-Id: I1b0b91eb7216f32a5748325d6dda37f3998302c7
BUG: 3754
Reviewed-on: http://review.gluster.com/697
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 529b3ed8c300d41321dece27cd1290ef3bbcaf31
Author: Sachidananda Urs <sac@gluster.com>
Date: Sat Oct 29 14:20:02 2011 +0530
Move some of the messages to log level `TRACE'.
Change-Id: I46133b5e2218b9d810251b3dadadd8f157ab07d7
BUG: 3761
Reviewed-on: http://review.gluster.com/643
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit d5e6942f75c6460e9605fd76e6d4f58aa45c9955
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Oct 17 11:04:35 2011 +0530
rdd: create the file and do rdd if the file does not exist.
rdd takes input file and copies the its data to the specified output
file ( by creating it) by selecting random offset. If the input file
does not exist it will not work. This patch will create the input file
if it does not exist and then does the copy. File size is given as an
argument. If the file exists it truncates the file and then does the copy.
Change-Id: Ia09451e9e80e13f27320f1edc12c73c0dcf663a9
BUG: 3724
Reviewed-on: http://review.gluster.com/596
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 53c2e5479fea9f2e492dee6d1e028cf494203474
Author: krishna <krishna@gluster.com>
Date: Thu Sep 29 17:44:55 2011 +0530
Fix memleaks in NFS
Change-Id: I522d4bad71d1e914fa88367f70f5e8c28d64fbbe
BUG: 3542
Reviewed-on: http://review.gluster.com/533
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Shehjar Tikoo <shehjart@gluster.com>
commit 5b6e2b8c24cd32766d3a4a26af48146cbc2339aa
Author: Rajesh Amaravathi <rajesh@gluster.com>
Date: Wed Nov 2 15:26:53 2011 +0530
debug/io-stats: prevent setfattr crash when no value given
Check for whether the dump file is given, and proceed
on success. If dump file is not given, unwind with ENOENT.
Change-Id: If524a2b20d643e0e75d81daebe59560a78000524
BUG: 3716
Reviewed-on: http://review.gluster.com/663
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit bacae26ca38b95dbd9e71a8d91cce01472912445
Author: Rajesh <rajesh@gluster.com>
Date: Wed Aug 24 12:47:24 2011 +0530
mount/fuse: check for recursive mounts
Adding check_recursive_mount() in mount.glusterfs.in
to check if mount point is in the lineage of any
brick path. Gracefully fails if mount point leads
to recursive mount.
Change-Id: Iedc4cd767d241c8e256181e472c0815f3831a316
BUG: 2003
Reviewed-on: http://review.gluster.com/314
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 823337f0d566be0613902c4eb4adbacefabdb17e
Author: Harshavardhana <fharshav@redhat.com>
Date: Tue Nov 8 16:58:44 2011 -0800
fusermount: Build problem fixed with new glibc
Change-Id: Id25e688d3dbecb74d820388faec5ee5041f21630
BUG: 3797
Reviewed-on: http://review.gluster.com/714
Reviewed-by: Anand Avati <avati@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 25b68094c8d6b6af16b419c312aa949428453e3e
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Nov 3 14:47:01 2011 +0530
stripe readv_cbk: Fix stat return values
Workaround -
If the read request, does not fall to the subvolume with the largest
file size set, then we never return the correct size. This leads to
clients seeing a truncated file error.
The work around is to wipe stat being returned as part of read call.
Problem -
We were passing the stbuf returned by the first child/index, which
can be different to the size/blocks returned by stat. This led to
applications viewing the file as being truncated.
The stbuf size needs to be the largest of all results, and blocks
the aggregation from all subvolumes. (similar to stat)
BUG: 3774
Change-Id: I46c53c18b2b42b1f5b86b05555bbab73bf993476
Reviewed-on: http://review.gluster.com/666
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 890a4a66f1bbf82ff6fe52ffc286257eb4a19209
Author: Kaushal M <kaushal@gluster.com>
Date: Mon Oct 31 10:02:16 2011 +0530
cli : Modify "top read-perf/write-perf" output
Improves alignment and width of columns in the output of "top
read-perf/write-perf".
Change-Id: I9a4ec3a121f40e099c96952e2388b27ed90b6fe6
BUG: 3719
Reviewed-on: http://review.gluster.com/645
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 561760d903e9355506eeb69e478dc7b2b045f586
Author: Kaushal M <kaushal@gluster.com>
Date: Thu Oct 20 10:53:58 2011 +0530
cluster/afr : Fix self-heal of special files
Fixes self-heal of special files like device files, fifo files, socket files
etc. Does it by doing the following:
* Prevent setting of pending data xattr on a special file during entry self-heal
when a new fils is created.
* Allow data self-heal to be started on all file types other than directories.
During data self-heal, for special files just erase pending xattrs, if those
xattrs were set by previous releases of glusterfs.
Change-Id: I34d8121e23ad00e85371ae2a36ef30cf3bd5db7a
BUG: 3525
Reviewed-on: http://review.gluster.com/618
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit 842410662466fd54c21ff290d3408ac8aa4af470
Author: Venky Shankar <venky@gluster.com>
Date: Wed Oct 5 16:56:30 2011 +0530
fuse: flip xattr key from user to trusted namespace for certain clients.
This is needed for gsyncd/hadoop-plugin running as non-super
user to be able to request extended attributes under trusted
namespace. Request for a key is made under 'user.' namespace
and is flipped by fuse xlator for specific xattr name to the
corresponding 'trusted.' extended attribute.
Both applications set a identifier (client-pid) while doing a
FUSE mount, which is checked by get/set/remove interfaces in
FUSE translator.
Change-Id: I72f77a5dd1ee1d69c8b0e09209449348dbcf879a
BUG: 3701
Reviewed-on: http://review.gluster.com/563
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 66a4c0fd9ec02b753fac04f4ceaab05e8a6192ec
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Oct 25 11:45:10 2011 +0530
cluster/afr: Remove unused 'ino' code
Change-Id: I425e2d23e9e45f10ddeff2eacf918dd90f8baee7
BUG: 3744
Reviewed-on: http://review.gluster.com/639
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 82192b36edd846d0c688758a7e8788067d96f31e
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Oct 11 16:33:24 2011 +0530
changing of the volume types after volume is created.
with this patch, one can do all the below operations:
on a simple distribute volume 'test' with bricks A,B, add bricks C and D:
bash# gluster volume add-brick test replica 2 C D
now the volume 'test' becomes distribute-replicate, with pairs A-C, B-D.
same holds good for stripe.
and now, one can change the replica count 2 on volume 'test' to 4 like below:
bash# gluster volume add-brick test replica 4 E F G H
now, volume has 'replica' count 4, with pairs being 'A-C-E-F' and 'B-D-G-H'.
after this, if user wants to reduce the replica count, he can do
bash# gluster volume remove-brick test replica 3 C H # (one from each pair)
This should work to reduce the replica count
Change-Id: I4f109141a9ba7be4a92a5f5810a4163baeb92973
BUG: 3305
Reviewed-on: http://review.gluster.com/158
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7daed494ef130237439aa619d4e18d39a0aab9de
Author: Junaid <junaid@gluster.com>
Date: Mon Oct 17 12:38:14 2011 +0530
features/marker-quota: Donot log when inode or inode-ctx is NULL.
When running rm -rf from mount point, quota-updation process may endup in a state where the
inode is already removed from the gluster inode table, but the updation has process is still in
progress. This is not a error condition because the updation is done asynchronously.
Change-Id: I739bff466d23f55f842c16dd4fa2808df188ddf8
BUG: 3609
Reviewed-on: http://review.gluster.com/597
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0d3909f883b87ca345ef988eb7c15ca8bb050f0f
Author: Rajesh Amaravathi <rajesh@gluster.com>
Date: Tue Oct 11 16:09:52 2011 +0530
io-stats: improve io-stats dump output
* Cumulative statistics' output has been formatted
to match #gluster volume profile <vol> info
* Fop count, latency measurements have been tabulated
for better readability.
* Minor formatting of individual fop call counts
and throughput info dumps.
Change-Id: I0fa524f773018be2f73077d107e34170d19fc420
BUG: 3544
Reviewed-on: http://review.gluster.com/581
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 2c23be8833550a7cf448861b8fc4bdf19243c4ff
Author: Kaushal M <kaushal@gluster.com>
Date: Fri Oct 14 10:33:18 2011 +0530
glusterd: fix '.cmd_log_history'file handle leak on SIGHUP
Closes the .cmd_log_history file and reopens it to prevent leakage of file
handles.
Change-Id: I1c846ccf9a0c1c90c9209f26a1c5332d3dd94ffd
BUG: 3678
Reviewed-on: http://review.gluster.com/584
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 04ba98637bc5ee16897e1aa68bcd8f2fb4360578
Author: Rajesh Amaravathi <rajesh@gluster.com>
Date: Fri Sep 30 18:05:38 2011 +0530
glusterd: allow non-related directories with same prefix
Earlier, using two directories with names like /test and /test1
failed volume creation. This patch sees that the next character is
checked to be '/' to conclude that they are recursive.
Eg: /test and /test2 succeed, while /test and /test/alpha does not.
BUG: 3645
Change-Id: Idc90211a7a572200ed983c87c4344271f53b0132
Reviewed-on: http://review.gluster.com/544
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 079912a3f01f16c62270af7214bb28d19d917696
Author: Anand Avati <avati@gluster.com>
Date: Sat Oct 22 09:48:17 2011 +0530
locks: perform inode_ref of pl_update_refkeeper outside locked region
Performing inode_ref inside the critical section of pl_update_refkeeper
(around pl_inode_t->mutex) causes a deadlock with inode_table_t->lock.
The other thread (process state dump) holds the inode_table_t->lock first
to loop over inodes and then while dumping an inode's lock context, tries
to acquire pl_inode_t->mutex thereby completing the deadlock.
The fix is to perform inode_ref outside the critical section in
pl_update_refkeeper
Change-Id: I689ab4a9b46b36287740279fdec6159182c86119
BUG: 3753
Reviewed-on: http://review.gluster.com/628
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 75d934321d8e6f6162097000eeb8f589bf42795f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Oct 24 08:27:40 2011 +0530
pump: Change crawl to accommodate afr_lookup changes
Change-Id: I600120252445c06d9cc3e7aa24022c2559b6abe2
BUG: 3747
Reviewed-on: http://review.gluster.com/638
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1f7c9127c7723c4e2e00b2aaac12afb5b0e51f55
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Oct 21 14:45:08 2011 +0530
cluster/afr: Take gfid-req from xattr_req only if inode->gfid is null
Change-Id: Iddf5b59d3534c517dcd3c0d7b819e3768f6e915a
BUG: 3747
Reviewed-on: http://review.gluster.com/637
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 342ba3783d697fe2b396b174669197c187b9f11a
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Oct 22 11:32:40 2011 +0530
mount/fuse: set gfid in lookup after a failed revalidate lookup
Change-Id: I1904aa63d9365ebda3e979449454ac08db85d93d
BUG: 3747
Reviewed-on: http://review.gluster.com/636
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 3ac7e3fb5077089a04f013e57bdc178a77f4940b
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Oct 21 12:17:04 2011 +0530
Stripe mknod: Always call mknod if REGULAR file on first child.
This prevents a possible race between mknod(REGULUAR files) and remove.
mknod first creates on the first_child, and only if successful, on other
subvolumes.
Change-Id: I0ddaeb92c1884c771c966bb151db052ab5735367
BUG: 3727
Reviewed-on: http://review.gluster.com/608
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 16a23a652253a43e0af1379e4d19a01f7457d794
Author: Venky Shankar <venky@gluster.com>
Date: Wed Sep 28 16:38:00 2011 +0530
cli: add geo-replication log-rotate command
Rotating geo-replication master/monitor log files from cli.
On invocation, the log file for a given master-slave session
is backed up with the current timestamp suffixed to the file
name and signal is sent to gsyncd to start logging to a new
log file.
Sample commands:
* Rotate log file for this <master>:<slave> session:
gluster volume geo-replication <master> <slave> log-rotate
* Rotate log files for all session for master volume <master>
gluster volume geo-replication <master> log-rotate
* Rotate log files for all sessions:
gluster volume geo-replication log-rotate
Change-Id: I75f641b4e082a04d5373c18583ca4a1d9651d27a
BUG: 3519
Reviewed-on: http://review.gluster.com/529
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@gluster.com>
commit 56e2b0e47d011973aa005ca48ca2a9216f368fe0
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Oct 18 10:30:42 2011 +0530
build: warning suppression (round n)
with this patch, there are no more warnings with gcc (GCC) 4.6.1 20110908
Change-Id: Ice0d52d304b9846395f8a4a191c98eb53125f792
BUG: 2550
Reviewed-on: http://review.gluster.com/607
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit c02977a0d9327e9d5674c53cf2c17a96dea39efc
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Oct 2 11:34:41 2011 +0530
libglusterfs/syncop: fix minor memory leaks
* most of the leaks can happen in syncop_lookup(), if rsp_dict is
not provided by user
Change-Id: I5a887c45f1a46a91502147e44f7ed9d41f50dbc6
BUG: 3715
Reviewed-on: http://review.gluster.com/550
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit f2a225d0ec80b58d41a94f50f475931d4c9ca9d3
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Oct 13 12:59:41 2011 +0530
distribute: handle migration of symlink and special files
TODO: currently, wrt. rebalance/decommissioning, only pending thing
is hardlink migration.
Change-Id: I30cd06802e84c95601a5a081198f1f09c6d6bc01
BUG: 3714
Reviewed-on: http://review.gluster.com/578
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c862443b19d4b51e64fd9c1e58471540ad5dee5d
Author: Kaushal M <kaushal@gluster.com>
Date: Wed Oct 19 13:44:32 2011 +0530
Remove EXCEPTIONS file.
Change-Id: I79fe05102a954ee1c831ceca229f6dbc1997113d
BUG: 3737
Reviewed-on: http://review.gluster.com/617
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3eb8f1c17429fcf2f968e0c79cae625f25bc8bce
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Oct 13 17:52:44 2011 +0530
pump: status shouldn't be cleared until migration is complete during commit.
Clearing pump status on migration complete is futile because we would be
'replacing' src brick with destination brick in the volume anyway.
Change-Id: Ib12fee84bd5445c4a20dac1cf10555331d7b8ebd
BUG: 3653
Reviewed-on: http://review.gluster.com/585
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 51e4b843b6d1b817396350297573ef8fad7686fb
Author: Pete Zaitcev <zaitcev@yahoo.com>
Date: Tue Aug 16 14:42:49 2011 -0600
Print microseconds as a fraction.
Change-Id: I35cdf2c771974b9c51db47f24cd044ae014e52ce
BUG: 3426
Reviewed-on: http://review.gluster.com/244
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 02933eff1813406e6e33e66370268e6a437df120
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Oct 14 18:28:27 2011 +0530
cluster/afr: Prevent truncation of mask uint64_t->gf_boolean_t
Change-Id: If67f726f21b713fa9312dc499a1aca4cb00f71de
BUG: 3682
Reviewed-on: http://review.gluster.com/589
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit cb2c3cfbed6fde91a2f91a54d7598cc2c099db13
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Oct 10 18:44:41 2011 +0530
glusterd: Removing delayed moving of op sm for stop vol/remove brick op.
Earlier we waited for brick disconnect or 5s whichever is smaller, before we
move op sm from brick op stage to commit stage. This involves a race where both
the above mentioned events can happen 'concurrently' and result in double free.
Change-Id: I8b1524afded84c20d55e29cfe2579ca872d2ac26
BUG: 3700
Reviewed-on: http://review.gluster.com/575
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit e80f781ae17bd8c39b74a475ac5cd4ee9b362c1d
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Oct 2 13:20:25 2011 +0530
glusterd: take off 'auto-commit' behavior of decommissioning
currently if 'remove-brick <BRICKS> start' is given, after all
the data is migrated, in the _cbk() function from rebalance
complete we used to re-write the volume file without the bricks.
But the flaw of this method is that, currently the _cbk() function
is called on only the node on which rebalance actually happens,
hence other nodes are not aware of this behavior. So, had to remove
the 'auto-commit', instead we want the user to issue a command
'remove-brick <Bricks> commit' (or 'force') explicitely to remove
the bricks
Change-Id: Ifdac1292095029429da502aa6e4c0cf4ee124990
BUG: 1952
Reviewed-on: http://review.gluster.com/551
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit eaffe322f46723af7738c818f0cf1fd5d659eae0
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 3 15:41:04 2011 +0530
libglusterfs/iobuf: increase the iobref's iobuf array size
earlier it was hardcoded to 8, now increased the size to 16.
also return the exact error code in client_submit_vec_request(),
so there will be no missing frames in case of errors.
Change-Id: I82a6ee681a543b673a7cf1a0b9c5ade2a7175ebe
BUG: 3679
Reviewed-on: http://review.gluster.com/555
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 67f83840305e30f6d4b9457dbbf147db6cf7a340
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Oct 7 12:29:29 2011 +0530
smoke.sh: Avoid running extended attribute tests with dbench
Change-Id: I6d58e387e2bf9d5616ec3950abdb0680801523db
BUG: 3234
Reviewed-on: http://review.gluster.com/564
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
commit 154cc3d86b7a81afd397b410f8a85765c4d633ee
Author: Sachidananda Urs <sac@gluster.com>
Date: Thu Oct 6 23:34:50 2011 +0530
Fix a typo in log message.
Change-Id: I5c2b170977f21c9a83d36f60d9a145c6cc221358
BUG: 2346
Reviewed-on: http://review.gluster.com/562
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 4c70cb648838a7d5a1fe5903e1ecc58637361d22
Author: Junaid <junaid@gluster.com>
Date: Fri Sep 30 15:41:33 2011 +0530
cluster/dht: Handle 'user.ufo-test' sent by ufo in dht setxattr.
In this case, send setxattr to all the bricks to test user xattr support and return error if setxattr fails on even one of the bricks.
Change-Id: I9a9b27312a650d25bbc1f57e1ab8899d63d0593d
BUG: 3185
Reviewed-on: http://review.gluster.com/542
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 66b193b0a5e93e9bc15b73a23daf229a6b1fe67a
Author: Junaid <junaid@gluster.com>
Date: Fri Sep 30 12:15:17 2011 +0530
features/marker-quota: Return error when inode-contribution is not present in inode_ctx.
Also, create the inode_contribution node even before checking for dirty and xattr not present in mq_inspect_directory_xattr function.
Change-Id: Ie5b6e6ba8d5abcfc6aeb9b192720ac10aac1319e
BUG: 3624
Reviewed-on: http://review.gluster.com/539
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 01395264a6ff4e83769d1a42b7a4a4d1debbc225
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri Sep 30 17:40:26 2011 +0530
locks: Avoid printing blocked times for locks that were never blocked.
Change-Id: Ieedbfbe3ce2d4a87a8fe0e1a4322a1bb0549a2bf
BUG: 3662
Reviewed-on: http://review.gluster.com/545
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit eafcbc938e22d4da63d3cc8f74ca44c612847a47
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Oct 6 10:33:52 2011 +0530
glusterd: pending_node type missed in profile volume op.
Change-Id: Ib3c73a8432fdd2559422577a2f0c91d50b5a098c
BUG: 3704
Reviewed-on: http://review.gluster.com/561
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d370e14b7affdf1616db89ec681fdcd9d8296fde
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Oct 3 17:21:19 2011 +0530
Stripe: Prevent dir gfid mismatch and ENOTEMPTY errors
gfid mismatch issue-
rmdir- first remove from non first child (FC), and then last from FC. If one
fails, FC entry is not removed and op is failed.
mkdir- first create dir from FC, followed by other childs. If FC is success
then, we succeed, banking on entry self heal
ENOTEMPTY issue-
unlink: remove from non FC and then on success remove from FC. If non FC remove
fails, fail unlink
create- Create first on FC, and on success create on non FC.
Change-Id: Ia8b9e92cd2aba891d249d1995e383fea0581ffca
BUG: 3663
Reviewed-on: http://review.gluster.com/557
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 757a6b411a2c84f505425b846e3aad10a97dda2d
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Oct 3 15:25:12 2011 +0530
glusterd: Handle restoring of volumes created in older versions.
Change-Id: Idd9cb9d05122750ac78410b8f5a080104d6c1e0a
BUG: 3685
Reviewed-on: http://review.gluster.com/554
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit e87f270a34f40a752df1ebd32c664a3c0e445050
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Oct 3 14:53:04 2011 +0530
glusterd: Shouldn't inject COMMIT_ACC event before receiving ACC from all peers.
Change-Id: I88b9935f93d9a06e46c3351c2fd37c969396bb0a
BUG: 3683
Reviewed-on: http://review.gluster.com/553
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 06fc095cfd74e3bebb595476fe9f7582363001e8
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Oct 3 16:01:25 2011 +0530
cluster/afr: set the read child ctx only if the self-heal source is valid
Change-Id: Ifdf0db71594ce526ad85c21103726798d9aceef4
BUG: 3639
Reviewed-on: http://review.gluster.com/556
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 5f158151397d9b97eaef376b265dd7180482eb37
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Oct 2 08:46:46 2011 +0530
core: made changes to return value of __is_root_gfid()
now returns 'true(1)' is gfid is root, 'false(0)' if not.
earlier it was the inverse, which was bit confusing
Change-Id: Id103f444ace048cbb0fccdc72c6646da06631584
BUG: 3518
Reviewed-on: http://review.gluster.com/549
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 47154c95037e0e080945ce687163daffe43b3f12
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Oct 1 19:20:28 2011 +0530
libglusterfs/syncop: do not rely on synctask set in makecontext
Across glibc implementations, interpretation of argc/argv passed
to makecontext() is different. This patch does away with dependence
on such arguments passed to makecontext(). Instead,synctask reference
is retrieved from pthread_getspecific().
Change-Id: Ie01feaa0b7d430f8782c2f6805ccdf8026e401f4
BUG: 3636
Reviewed-on: http://review.gluster.com/547
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9769c9b4d59793c8ba742cabd292175b68f2d42f
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Sep 29 12:11:44 2011 +0530
statedump: do not print the inode number in the statedump
Since gfid is used to uniquely identify a inode, in the statedump
printing inode number is not necessary. Its suffecient if the gfid
of the inode is printed. And do not print the the inodelks, entrylks
and posixlks if the lock count is 0.
Change-Id: Idac115fbce3a5684a0f02f8f5f20b194df8fb27f
BUG: 3476
Reviewed-on: http://review.gluster.com/530
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 8f1a918c9674ef152a6f3f57194c848fd8b1ea9b
Author: Kaushal M <kaushal@gluster.com>
Date: Mon Sep 26 10:24:46 2011 +0530
glusterd: cleanup unneeded volumes after peer detach
Performs cleanup on the detached peer and in the cluster after a
peer detach, and also adds a new check before starting detach.
Cleanup -
On the detached peer, cleanup removes the entries of those volumes
on the peer that do not have all their bricks on it. This prevents
these stale volumes from being added to a new cluster when peer is
attached to one.
In the cluster, all those volumes which have all their bricks on the
detached peer are removed.
Checks-
Checks if all the peers in the cluster are online and connected,
except the peer being detached, before starting detach. Using force
will bypass this check and do detach.
Change-Id: I4fef9ea3cc72ce8c4ce0a82b4ee8a1663a502061
BUG: 1926
Reviewed-on: http://review.gluster.com/431
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit bb9f786060a2a2503e5fde9296c06c53e50faed0
Author: Kaushal M <kaushal@gluster.com>
Date: Wed Sep 14 18:29:18 2011 +0530
glusterd, cli: adds 'force' for 'peer detach'
Adds add a 'force' option to 'peer detach' to forcefully detach a peer from a
cluster, even when the cluster contains volumes with bricks on the peer.
Change-Id: I134df51c16a07345c8869b318141d427b572eba5
BUG: 3549
Reviewed-on: http://review.gluster.com/429
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit e4b263ed57b5d1e657bab0e109119cd0141435f7
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 30 12:53:16 2011 +0530
distribute rebalance: preserve proper mode in destination
* don't set 'sticky' and 'sgid' bits to 0 without checking if the
source had those bits prior to rebalance.
Change-Id: Ia826cb3cfb55312cdbf00d3421f2bd06b3103ce6
BUG: 3656
Reviewed-on: http://review.gluster.com/541
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 12b6a41cd61f602f219a2619fa4ec5ac2130013a
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 30 12:22:34 2011 +0530
rebalance process: propagate proper errors to user
* cluster/distribute: while rebalance, differentiate between valid
errors, validation check failures (may not be migrate failure),
and success.
* mgmt/glusterd: differentiate the errors based on errno. If a valid
error has happened, mark the rebalance status as failure, and
stop the rebalnace crawl.
Change-Id: I2d7bd7b73d2b79bfaf892ad4364bc89830a0d5bb
BUG: 3656
Reviewed-on: http://review.gluster.com/540
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 43f034546e7542c41b593bed7315f5517c8123ad
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Sep 29 16:44:40 2011 +0530
locks: dump client pid and time of blocking/granting.
Change-Id: Icaa919f3009fb70f6af9b95fceaf800f3beca447
BUG: 3662
Reviewed-on: http://review.gluster.com/532
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 829ba510b003dad9c961b1741c6f162731f412eb
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Sep 29 08:12:22 2011 +0530
cluster/afr: Don't unlock sh_frame on failure in algo
Change-Id: I0ef541c1f387c397c345e3f2bc9a57f1eff282a1
BUG: 3647
Reviewed-on: http://review.gluster.com/527
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 90a971f968896e91456178de228234d37d6196e5
Author: Rajesh Amaravathi <rajesh@gluster.com>
Date: Mon Sep 26 11:08:48 2011 +0530
gnfs/server: allow 255-char file names
* Posix requires 255 character filenames(NAME_MAX), so
buffer to store a filename should be 256(+1 for
terminating '\0' character).
BUG: 3572
Change-Id: I9d3dbb49d96b3da946cbab97f927209d71ece620
Reviewed-on: http://review.gluster.com/531
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Krishna Srinivas <krishna@gluster.com>
commit 04815565e47608d0ea263dc83ce9b8d0cb8ac7a4
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 30 10:51:54 2011 +0530
glusterd rebalance: allow 'status' and 'stop' from all the peers
* the check to see which command is issued to do the source node
check had an error.
Change-Id: I5cebe6e263c416d859af4f413d47c7b643815f6f
BUG: 3655
Reviewed-on: http://review.gluster.com/537
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 498ca2011608163cf7a0325843b8fd7b0fd6e99e
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Sep 30 07:07:59 2011 +0530
cluster/afr: set fd ctx on opendir
Change-Id: Ica845035781f47de990e9dcfefdeb37bed99d515
BUG: 3637
Reviewed-on: http://review.gluster.com/536
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1b3c1cd3da78f56c90d9b3b1f799549ac0ed7e41
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Thu Sep 8 11:07:10 2011 -0400
Second round of warning suppression.
Used a #pragma to kill ~170 in rpcgen code. Added GF_UNUSED to deal with
a few more from macros elsewhere. The remainder are function return values
(mostly context and dict calls) that really should be checked. Those would
be harder to fix without real understanding of the code where they occur,
so they remain as reminders.
(Patchset 2: deal with older gcc that doesn't handle #pragma GCC diagnostic)
(Patchset 3: fix include paths in generated files)
(Patchset 4: keep up with trunk, squash 9 new warnings)
(Patchset 5: six more, all in AFR)
Change-Id: I29760c8c81be4d7e6489312c5d0e92cc24814b7b
BUG: 2550
Reviewed-on: http://review.gluster.com/378
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 1d638bef99525a0212f753ed76f6b3bc1a8baa35
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Sep 29 19:37:18 2011 +0530
mgmt/glusterd: skip shd graph generation for non-replicate vols
Change-Id: I1bb83342bc0fa883ede527527ec8fd6ee470f781
BUG: 3666
Reviewed-on: http://review.gluster.com/535
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 2f25c532308abcd12d9c603361933c23eeb6166e
Author: Kaushal M <kaushal@gluster.com>
Date: Wed Sep 14 09:50:45 2011 +0530
performance/io-cache,quick-read: increase cache-size limit
Does the following:
1. Increases cache-size limit from 6GB to 32GB.
2. Prevents 'volume set'from failing when cache-size is set over the
limit. Just issues a warning.
3. Performs check on cache-size by comparing with total system memory
available in init () and reconfigure () methods.
Change-Id: I7dd4d8c53051b89a293696abf1ee8dc237e39a20
BUG: 3495
Reviewed-on: http://review.gluster.com/409
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 83d4b91c61c1dfc603ac21365c15dd75fb60b64b
Author: Rajesh Amaravathi <rajesh@gluster.com>
Date: Tue Sep 27 16:25:58 2011 +0530
glusterd: allow non-related directories with same prefix
Earlier, using two directories with names like /test and /test1
failed volume creation. This patch sees that the next character is
checked to be '/' to conclude that they are recursive.
Eg: /test and /test2 succeed, while /test and /test/alpha does not.
Change-Id: Idee1e15b7e0a0d0965d1aea910b52f1da286d64b
BUG: 3645
Reviewed-on: http://review.gluster.com/511
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit b749807777bd36b47f08386d61dffa7867e8d5ec
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Sep 29 18:04:01 2011 +0530
glusterd: prevent rebalance being called in volume status execution
Change-Id: I70e7d38a5cb3f6b0033ab9cabd7dfed0c68b77b8
BUG: 3668
Reviewed-on: http://review.gluster.com/534
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 22367a134ccdb2d30bfecd33456d42a1bb079ab2
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Sep 29 11:04:35 2011 +0530
protocol/server: check for the fd being NULL and unwind
Change-Id: I400e515431cf739fe0b2f90840359496a2b529d2
BUG: 3158
Reviewed-on: http://review.gluster.com/528
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 657b276d3a6a40b7b3de7087026dede64864d23d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 27 14:44:01 2011 +0530
cluster/afr: Handle files without gfid in self-heal
Change-Id: Ibcaaa9c928195939ff1e31b28b592e524e63a423
BUG: 3557
Reviewed-on: http://review.gluster.com/519
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d10c9800590fb4f930ed49063ba64b9f21ec68f5
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 27 14:42:28 2011 +0530
libglusterfs: wipe other variabes in loc
Change-Id: I0553bb7f64d69f5684c3d21f3809da4e9e3529c1
BUG: 3557
Reviewed-on: http://review.gluster.com/515
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 50f468e2a67320a094698fd536be994a18a7980d
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 27 15:52:31 2011 +0530
glusterd : 'volume stop' to check if other ops are in progress
* handles the case of 'rebalance' in progress
* inturn it will also handle the case of decommissioning in progress
* also now checks if a replace-brick is in progress
Change-Id: I0266483089515d16fe8167afe06a07696328a8e3
BUG: 3358
Reviewed-on: http://review.gluster.com/518
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 4299fb0a744ae22693f79f454adf2ca0a843787d
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 27 23:10:58 2011 +0530
glusterd rebalance: minor enhancements
* honor 'stop' command as early as possible
* don't send a setxattr() call if file doesn't have dht linkfile
Change-Id: I159641d03cd15e5818b811ad113d298f7f0112db
BUG: 3584
Reviewed-on: http://review.gluster.com/520
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 2ec46a350bcafbf6dc588663693f89eff12679bb
Author: krishna <krishna@gluster.com>
Date: Wed Aug 10 13:00:16 2011 +0530
by default make option rpc-auth.addr.namelookup off.
Change-Id: I11c1d55bebfc86c634cf446c50585f6c56c02665
BUG: 3345
Reviewed-on: http://review.gluster.com/204
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3891e39a3fb83e5b8bc464b7b2420a416c27e4b6
Author: Kaushal M <kaushal@gluster.com>
Date: Mon Sep 5 14:33:43 2011 +0530
cli : new volume statedump command
Changes:
1. Add a new 'volume statedump' command, that performs statedumps of
all the bricks in the volume and saves them in a specified location.
2. Add new server option 'server.statedump-path'.
3. Remove multiple function definitions in glusterd.h
Statedump Information:
The 'volume statedump' command performs statedumps on all the bricks in
a given volume. The syntax of the command is,
gluster volume statedump <VOLNAME> [type]......
Types include,
* all
* mem
* iobuf
* callpool
* priv
* fd
* inode
Defaults to 'all' when no type is specified.
The statedump files are created by default in /tmp directory of the
server on which the bricks are present.
This path can be changed by setting the 'server.statedump-path' option.
The statedump files will be named as,
<brick-name>.<pid of brick process>.dump
Change-Id: I01c0e1a8aad490da818e086d89f292bd2ed06fd4
BUG: 1964
Reviewed-on: http://review.gluster.com/321
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit b08bcdebd06b01824b584cd878270287a88692b9
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Sep 26 14:38:58 2011 +0530
build: Solaris build fixes
Change-Id: Ic47d07a199ecbc42a141e391bbc75096e270e404
BUG: 3446
Reviewed-on: http://review.gluster.com/503
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 44162d1967eab5608aa179869a4ae94bd2ffb343
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Tue Sep 27 14:18:38 2011 +0530
glusterd: Should not cleanup peerinfo too soon.
friend_remove_cbk cleans up peerinfo and the unrefs the associated rpc_clnt
obj. When the cbk is run inside call_bail or saved_frames_unwind, we might end
up destroying the rpc_clnt and associated saved_frames_pool while we are still
using saved_frames to iterate through the frames.
Change-Id: Idf7768478a6d07a87c7faeac5b70e13bcacd2641
BUG: 3511
Reviewed-on: http://review.gluster.com/510
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e7dcd3b97c624194c047c2c2ae1e2ad372214724
Author: Kaushal M <kaushal@gluster.com>
Date: Tue Sep 27 12:37:22 2011 +0530
storage/posix : prevent unmount of underlying fs
posix xlator now performs opendir () on the brick directory during init ().
This will prevent the underlying filesystem mounted to that directory from being
unmounted.
Change-Id: I02c190ab8a91abc4ab06959b36f50e0a3fa527ae
BUG: 3578
Reviewed-on: http://review.gluster.com/509
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 104f57675c54d0d5e8f16aecfa9f7c5992e4ed2f
Author: Kaushal M <kaushal@gluster.com>
Date: Mon Sep 26 10:33:56 2011 +0530
glusterd: support for resetting single option
Allows resetting of only single options using 'volume reset' command.
New syntax of volume reset is: 'volume reset [option] [force]'.
Giving "all" as options or not specifying an option, causes all options
to be reset.
Change-Id: Ib9e220f326adeb1be1a774737a0b12c910012cea
BUG: 2980
Reviewed-on: http://review.gluster.com/450
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit e4d80a83d8c4c5efae0d6dcc369bf864c306c4e7
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 26 17:42:40 2011 +0530
cluster/distribute: fixed a spurious inode ref
While bringing in support to open-fd migration, dht_local_init()
itself started doing 'loc_copy()'. I had left one case in dht_lookup()
where there is a extra loc_copy() on existing copied 'local->loc',
which would cause 2 inode_refs on a given inode, and only one
inode_unref() happens in dht_local_wipe().
Change-Id: Idd0375bdf9a6408db1e97e80389249ef8d802adb
BUG: 3590
Reviewed-on: http://review.gluster.com/504
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 825319d6eb2f5ff7303440ba0cd8ff77ba857743
Author: Kaushal M <kaushal@gluster.com>
Date: Mon Sep 26 11:19:24 2011 +0530
glusterd: more checks before starting rebalance
Checks if specified volume is of a distribute type and has more than one
brick before attempting to start rebalance.
Change-Id: I9a3405019e7af4a7d7e162b0dc054bf9a99364e7
BUG: 3561
Reviewed-on: http://review.gluster.com/501
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit aabfbd5a85eac092ab05a80884e7478d3dfe2c87
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 26 20:43:17 2011 +0530
glusted: while doing add-brick, handle distribute volume separately
so the logic of different type of counts etc won't come into action,
which would fail the add-brick operation.
Change-Id: I5c8769d6d1c2433ffb084e5dce9c1e01678cff40
BUG: 3630
Reviewed-on: http://review.gluster.com/505
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 4111a65cecdc13681aafe94870ab0c2194f0d7a9
Author: Anand Avati <avati@gluster.com>
Date: Sun Sep 25 18:34:14 2011 +0530
rpc: fix wrong wiping of state machine's state
The macro __socket_proto_read() is used to read one sub-header in a fragment
after another. It also has to 'get out' of the state machine's
switch/case construct in two situations -
a) finished reading the full header
b) after a partial read, (and return in the same state at next pollin)
The 'reset' of the state should happen only after a full read of the header
and not if there was a partial read of the header.
Change-Id: I3650a83e1fae0f317cfd1b549835c72e39dc5253
commit 5050835f3d9fc58778a8b2ab7cf695740612d36b
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 15 12:57:44 2011 +0530
glusterd: cleanup of volinfo '*_count' definitions
earlier, sub_count was having different meaning depending on the
volume type.
now, for replica and stripe count, one can directly access the
'replica_count' or 'stripe_count' to get the corresponding
value from the volume info. 'sub_count' is preserved as is for backward
compatibility. there is a new variable 'dist_leaf_count' to get
info about how many bricks are present in one distribute sub volume.
Change-Id: I5ea1c8f9ae08f584cca63b91ba69035c7e4350ca
BUG: 3158
Reviewed-on: http://review.gluster.com/435
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 3500740671fcd944cee564ecba28470e6ea2092e
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 23 16:19:20 2011 +0530
glusterd-volgen: prevent a crash when volume type is stripe-replicate
when volgen tries to check for decommissioned nodes, a check for
stripe replicate volume was missed
Change-Id: Ie3aa97da2ec0d94fcf65f96bb4006b3fb54f59dc
BUG: 3616
Reviewed-on: http://review.gluster.com/494
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit b4abde617ab563d9ab9bd0aa5df9579c933b7ef6
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Sep 21 11:53:45 2011 +0530
rpc: No timeouts for lock fops.
As of today, all fops bail out after 30 mins by default. This is not desirable
with lock fops since it could be 'rightfully blocked' for a really long time.
But the client would assume that the lock fop has 'expired' after 30 mins and
clean up its references to the locks. Later when the locks xlator decides to
grant it, we are left with an orphan (stale) lock .
This fix exempts lock fops from timeouts. Only on network disruptions both
client and server decide to 'clean up' the locks held.
Change-Id: If1d74ba21113650b976728e9b764c551a0a49e59
BUG: 3617
Reviewed-on: http://review.gluster.com/478
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 253e7abe10c1475014ec8b70e92df6cfaa1cf4dc
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 21 14:16:46 2011 +0530
statedump: dump important details of oldgraph also
* with this, it helps to find out most of the leaks in the process
Change-Id: I70b476e4d63d74843d6664cfe407164f2b79b781
BUG: 3567
Reviewed-on: http://review.gluster.com/491
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bb9036471e386166a1d1d66b88f8c9c25df68ce0
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri Sep 23 11:49:29 2011 +0530
libglusterfs: Adding missing event strings for events.
Change-Id: Idf55abfa77712d32b27798fedcfddb65599b562b
Reviewed-on: http://review.gluster.com/493
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a95e062d5a624184ddf36f00a5ee5f19fcefef72
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri Sep 16 10:40:32 2011 +0530
glusterd: Implemented cmd to trigger self-heal on a replicate volume.
This cmd is used in the context of proactive self-heal for replicated
volumes. User invokes the following cmd when (s)he suspects that self-heal
needs to be done on a particular volume,
gluster volume heal <VOLNAME>.
Change-Id: I3954353b53488c28b70406e261808239b44997f3
BUG: 3602
Reviewed-on: http://review.gluster.com/454
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 098b717aa1319418bb352f8e7c0150023f1f1573
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Sep 22 12:53:55 2011 +0530
posix-getxattr: Honor xattr name if specified
Currently, getxattr works like listxattr, and does not honor a call
with a name (key) being specified. The fix handles such scenarios when
a name is passed. If the name param is NULL, then it behaves like a listxattr.
Changing key size to 4096, as 1024 might not be sufficient length for keys.
Change-Id: I317b2e6372e97048e3166d91145c19c9e92e647e
BUG: 3599
Reviewed-on: http://review.gluster.com/486
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit f27a9049788e3d1117656ecc264955e3e24b4d17
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Sep 22 10:26:02 2011 +0200
geo-rep: disallow some special characters in url syntax
- space is disallowed to make rsync target unambigous for gsyncd wrapper
- *, ?, [ is disallowed so that we can tell away globs from urls
Nothing too bad would happen without these restrictions, but this way
gluster errs out early instead of producing some mystical error
further down on the way.
Change-Id: Idd4e68f7d91598a7a8e30ccbc6d395da570cdf2e
BUG: 3610
Reviewed-on: http://review.gluster.com/490
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e0ade34d3a3a84136e7df5b3ad531fde2d837ffb
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Sep 22 10:12:24 2011 +0200
geo-rep: add support to glob patterns with "geo-rep config"
Change-Id: I0d54cea72e4363eab85ade774cc918081d8036e9
BUG: 3610
Reviewed-on: http://review.gluster.com/489
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9db8a6a2eb284bd50384711913d1f5276a737ec5
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Sep 20 16:20:18 2011 +0200
geo-rep: implement IP address based access control
- gsyncd gets allow-network tunable which is expected to
hold a comma-separated list of IP network addresses
- for IP addess matching, bring in ipaddr module from Google
(http://code.google.com/p/ipaddr-py/, rev. trunk@225)
This will let users control master's access to slave's volumes
until we implement unprivileged geo-rep (delayed due to some
technical issues). It's also needed for the completeness of
our hardening efforts, as plain file slaves won't be able
to work with an unprivileged gsyncd.
Change-Id: I58431cba6592f8672e93ea89a5eef478905b00b9
BUG: 2825
Reviewed-on: http://review.gluster.com/488
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 82c2f65ac40f8e479549305b58236c647b6483f3
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Sep 19 15:47:46 2011 +0200
geo-rep: gsyncd: make sure path operations do not act outside the volume
Change-Id: I2da62b34aa833b9a28728fa1db23951f28b7e538
BUG: 2825
Reviewed-on: http://review.gluster.com/462
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 222be1112fcb41d336d807237ef0db4e8eb46758
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Sep 13 13:12:38 2011 +0200
gsyncd: control rsync target
- require/perform rsync invocation with unprotected args
(so that target is revealed to gateway program)
- make use of some procfs wizardry to find gsyncd sibling
and match rsync target against its working directory
Change-Id: Iae1e39b0e61f22563c0f2a2e0605567e0d1902df
BUG: 2825
Reviewed-on: http://review.gluster.com/461
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b59471ab2906477548cd8eaa812cb976a3621e0d
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Sep 11 19:45:57 2011 +0200
gsyncd: implement restricted mode and utility dispatch
With this change, the suggested way of setting up a geo-sync
slave is to use an ssh key with gsyncd as a forced command
(see sshd(8)), or set gsyncd as shell. This prevents the master
in executing arbitrary commands on slave (a major security hole).
Detailed list the changes:
- All gsyncd invocations that are not done by glusterd are
considered unsafe and then we operate in so-called "restricted mode"
(see below)
- if we are invoked on purpose (ie. it's not the case that sshd forced
us to run as frontend of a remote-invoked command), we execute gsyncd.py
- if invoked by sshd as frontend command, we check the remote command
line and call the required utility if it's among the allowed ones
(rsyncd and gsyncd)
- with rsync, we check if invocation is server mode and some other
sanity measures
- with gsyncd, in restricted mode we enforce the usage of the glusterd
provided config file, and in python, we enforce operation in
server mode and some other sanity checks
Impact on using geo-rep the old way: remote file slave now also
requires a running glusterd (to pick up config from).
Missing: we not implemented check of the rsync target path.
The issue of master being able to modify arbitrary locations
is planned to be mitigated by using geo-rep with an unprivileged
user.
Change-Id: I9b5825bfe282a9ca777429aadd554d78708f1638
BUG: 2825
Reviewed-on: http://review.gluster.com/460
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 6da4c1a98737c4acfc530d4dff450bcff983d46f
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Sep 2 19:03:33 2011 +0200
geo-rep: rewrite gsyncd wrapper in C
This rewrite does not change functionality;
it's purpose is to prepare followup modifications which will let
all slave side helper programs being dispatched to through
gsyncd. The string processing that's required for that task would
be too much cumbersome in shell.
Change-Id: Ia7858aba5efeb5dcff16a918ea1c02253f0e49ab
BUG: 2825
Reviewed-on: http://review.gluster.com/459
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 84866379a3ce0219d712b9a1256f634fbbb93ce6
Author: shishir <shishirng@gluster.com>
Date: Mon Sep 19 18:23:04 2011 +0530
Peer probe: Handle probe of friend with multiple hostname
Currently, when a peer is probed with a different hostname already belonging
to a cluster, a duplicate entry is created with uuid to set to 0.
This leaves the peerinfo in a inconsistent state, and when a detach of
this peer is issued, the correct entry gets removed.
The fix is to identify a peer with a hostname not matching to the probed
hostname and remove the incorrect entry.
Change-Id: I2f6c02f505f4426871623a4a8b45a12996095098
BUG: 3200
Reviewed-on: http://review.gluster.com/456
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 85fed17caccd717fa94bc9313af2960890cddea0
Author: Gaurav <gaurav@gluster.com>
Date: Thu Sep 22 12:48:41 2011 +0530
NFS : Posix compliance fixes.
Change-Id: I4f1d8883a3eedee20557e306815674a6dc062bfe
BUG: 1337
Reviewed-on: http://review.gluster.com/487
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ef703771baca5446870c105d9f66afff9bf975f7
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 19 13:01:26 2011 +0530
statedump: add more memory accounting related stats
* iobuf: add variable to keep count of total number of allocations
* iobuf: include 'purged' and 'filled' arenas also in dump
* mempool: more details added (with a name to tell why mem-pool
is created)
* memory-accounting: print number of allocs in each type
this would give us much better understanding of the memory
allocation pattern
Change-Id: I117ac0c1da943a4cc91543a01963ba7940db2b5f
BUG: 3567
Reviewed-on: http://review.gluster.com/376
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 22041197e37f2add9b5ef0061c1ef1e3cff48c7e
Author: Kaushal M <kaushal@gluster.com>
Date: Wed Sep 21 12:06:14 2011 +0530
glusterd: fix 'volume status' showing incorrect online status
glusterd now checks if a brick process is running to set online status,
instead of using brickinfo->signed_in. The earlier method used to show
incorrect online status as brickinfo->signed_in was not updated when
brick process was killed with SIGKILL
Change-Id: Id5589ea8abbcffebe5c794e5a4adf4f0e6e489f0
BUG: 3573
Reviewed-on: http://review.gluster.com/476
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0e006cbfad624d245fa1c7ae90554019d07d1c4f
Author: Rahul C S <rahulcssjce@gmail.com>
Date: Tue Sep 20 17:44:07 2011 +0530
cluster/distribute: validate buf before accessing.
The macro to check & reset rebalance flags was accessing the iatt
structure even in case of failures leading to null dereference.
Change-Id: I518f4cc9086cecbe6cf791c8a351287fe3613650
BUG: 3594
Reviewed-on: http://review.gluster.com/472
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit c5bca442bcb9c33c4e195d63741d809f3595ef82
Author: krishna <krishna@gluster.com>
Date: Wed Sep 14 16:09:16 2011 +0530
nfs: enhance NFS log messages.
Change-Id: I6c2eaa2795756f515b5fb2ea5098d3dcb4ef77c4
BUG: 3527
Reviewed-on: http://review.gluster.com/433
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 48de66e1f65a53be379566e56cef9c0fc1290de1
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Sep 21 17:11:49 2011 +0530
Rebalance: Mount rebalance client with assert-on-child-down set to on
This will prevent rebalance to be started when a brick is down, or
stop rebalance if a brick goes down during a rebalance op.
On restarting the rebalance once all the bricks are up, rebalance proceeds
as usual.
Change-Id: I196ae658c3a3856cce5314eca194e62d42171b9d
BUG: 3574
Reviewed-on: http://review.gluster.com/481
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 7885cbe326553612365c876c80ebf17ddf83bba1
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 20 13:23:08 2011 +0530
glusterfs protocol: handshake to log the version of the peer
* As RPC program's name is just used for logging, we now have
'PACKAGE_VERSION' part of the string, which gets logged in client
side.
* From client, we send the PACKAGE_VERSION in handshake dictionary,
which gets logged on serverside handshake.
The change doesn't break any compatibility between client or server
as it would only enhance the logging part of handshake.
Change-Id: Ie7f498af2f5d3f97be37c8d982061cb6021883ce
BUG: 3589
Reviewed-on: http://review.gluster.com/467
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 265b0b1cdc3e503655d950e0e847961a2870e9ad
Author: Lakshmipathi <lakshmipathi@gluster.com>
Date: Tue Sep 20 13:06:11 2011 +0530
build : rpm spec file changes
Thanks to
Scott Zahn <Scott@zahna.com> - Fixed spec file to add the correct
ldconfig path addition for i386 and
x86_64.(BUG:2279)
Persson <Persson@katamail.com> - Fixed without_georeplication macro
(BUG:3541)
JoeJulian <Joe@julianfamily.org> - Minor rpm cleanups.(BUG:3546)
Patch create the library references for both 64bit and 32bit rpms
Change-Id: Ia281fa0d3d8b32ff19b74f379cda7ca9315a4beb
BUG: 2279
Reviewed-on: http://review.gluster.com/466
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bf646776ad7c9d7ead5bb4fceaa1dcc6e203d0e1
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 20 18:30:42 2011 +0530
cluster/afr: Make local->child_up immutable
Afr transaction performs lock, pre-op, op, post-op and unlock steps in that
order. The child_up[] is overloaded with the information of where all
the first two steps succeeded. This works perfectly fine for
Transaction, but the locking/unlocking part of the code is re-used by
data self-heal. In that each loop_frame does lock, rchecksum,
read-from-source and write-to-sinks, unlock steps.
Rchecksum fop assumes that the fop needs to happen on one source + all
sinks and sets the call_count to that number. But if the lock step fails
on any of the sinks it will mark the child_up of that child to 0, which
will result in call_count mismatch and the frame will hang thinking that
some more cbks need to come. When this happens loop_frame will never go
to unlock step leading to hangs on that file.
Change-Id: I3dd0449cc6193a980bacf637d935881f4b22210a
BUG: 3597
Reviewed-on: http://review.gluster.com/474
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b3158ba416e32729a30d57f8a3fa567033097b03
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 21 12:20:34 2011 +0530
glusterd rebalance: set the proper status as per command given
for both 'migrate-data start' or 'migrate-data start force' commands
the defrag status should start with 'migrate-data-started' state.
Change-Id: Ic645bc764c4d24ab438187fb139c4a1c3ade8949
BUG: 3593
Reviewed-on: http://review.gluster.com/477
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit a3f8343bb3b5512be0ca03de440900fda6ed7e60
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 21 08:12:32 2011 +0530
mgmt/glusterd: Create volfile in correct path
Change-Id: Ie52e4b1a338282f2697e2ce374dd566d2c5cf5d1
BUG: 3586
Reviewed-on: http://review.gluster.com/475
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit e9dc70e387d2565a08c5181aaeb0ba41b5ec17fd
Author: Venky Shankar <venky@gluster.com>
Date: Tue Sep 13 22:11:33 2011 +0530
geo-rep: gsyncd: add --ignore-deletes option
When this option is set, a file deleted on master will not trigger
a delete operation on the slave. Hence, the slave will remain as a
superset of the master and can be used to recover the master in case
of crash and/or accidental deletes.
This options is not enabled by default.
Change-Id: I9244d9dfa4f38f19436036f36bec0d9c3a1f7993
BUG: 3552
Reviewed-on: http://review.gluster.com/426
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@gluster.com>
commit 563d1075ec316aa9843b12e7f7a0aa0bda668091
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Aug 29 16:54:50 2011 +0530
storage/posix: Filter custom getxattrs in lookup
Change-Id: If948ff1b355ea4fd92036bcc43e7b32325aeb3e4
BUG: 3470
Reviewed-on: http://review.gluster.com/325
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 25ac4b26ab513d6daa146dca998c14caa95168b8
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 14 09:02:01 2011 +0530
cluster/distribute: minor fixes in open file migration
* incorporated Avati's comments on the first patch.
* send proper stat information while unwinding
Change-Id: I36982cec610753c241c372272620ab2bd581fd9f
BUG: 3071
Reviewed-on: http://review.gluster.com/408
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c4f1bc7c475f252bab2369a8faf094fd9fc674f8
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Sep 20 11:03:32 2011 +0530
features/locks: free the string allocated by inode_path
Change-Id: I1b7d4059610713b92c4bb78676c3b48335e3a0fe
BUG: 3468
Reviewed-on: http://review.gluster.com/465
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b5faec808807ad19adae5d2a4be6fc5c87f7b989
Author: Kaushal M <kaushal@gluster.com>
Date: Tue Sep 6 17:18:20 2011 +0530
glusterd: run 'volume top read-perf/write-perf' in different thread
Runs the 'volume top read-perf/write-perf' operations in a different
thread without blocking glusterd. Prvents glusterd from being
unresponsive when large values of 'bs' and 'count' are given.
Also increase cli timeout for top/profile commands , from 120s to 300s
to allow large i/o top read-perf and write-perf to return result.
Change-Id: I4b7de1d735f33643d836772db7f25133f112b75a
BUG: 2720
Reviewed-on: http://review.gluster.com/375
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit a82d4d8e660b6d72044797639a4d1f21231a3685
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Sep 19 22:01:13 2011 +0530
rpc:memcpy data of right size to auth params
Change-Id: I6999e0a1463ee3475f7607990337326b3f008538
BUG: 3587
Reviewed-on: http://review.gluster.com/464
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 597d957c11179174f0e264bfe0ec87859cb2d4d8
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Aug 31 16:03:28 2011 +0200
s@GFS_PREFIX"/sbin@SBIN_DIR@
$sbindir is the install path for gluster* binaries,
so this is what should be used in their invocation
Change-Id: Ie748b4cbf59c3ee77f721ff6e0ab7151742ce0ab
BUG: 2825
Reviewed-on: http://review.gluster.com/458
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit d097c972e802b960d6ae6c4919e7cdbd49accf08
Author: Rajesh Amaravathi <rajesh.amaravathi@gmail.com>
Date: Mon Sep 12 17:29:47 2011 +0530
glusterd: provide a option to start processes with valgrind
By enabling the brick-with-valgrind option in glusterd,
one can automatically start all bricks with valgrind monitoring
them.
Change-Id: Ib0a97a83c4461c0878454e96bc84462f6cad6bc8
BUG: 3461
Reviewed-on: http://review.gluster.com/311
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e7958ee8b840a58f4c5596bc6cfff4bbd8ab7cd9
Author: Rajesh Amaravathi <rajesh.amaravathi@gmail.com>
Date: Mon Sep 19 16:43:50 2011 +0530
glusterd/top: volume top succeeds on partial brickpath
Rewrite of glusterd_volume_brickinfo_get in glusterd-utils.c
An additional argument to glusterd_volume_brick_info_get_by_brick
and glusterd_volume_brickinfo_get enables matching brick path in
two ways: Complete or partial(ancestor and descendent paths matched).
Change-Id: Ia87833a6f0c139599c3e40b59d60c64281b4084b
BUG: 3271
Reviewed-on: http://review.gluster.com/162
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit dce8a682beab6e41f7000bcf07cefafbeacb237d
Author: Kaushal M <kaushal@gluster.com>
Date: Mon Sep 19 15:13:43 2011 +0530
cli: enable order checking stripe-replicate volumes
This is a followup patch to e378778686fca24934e76c41e6496b12162a5420
Enables brick order checking for volumes of type stripe replicate.
Change-Id: Ib9b090a3514d05bb7602c423de7d3123f107a3b5
BUG: 2441
Reviewed-on: http://review.gluster.com/455
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e219d66b4d4e3aeac883a7766dc3523a8d822e2a
Author: Rajesh Amaravathi <rajesh.amaravathi@gmail.com>
Date: Mon Sep 19 14:25:47 2011 +0530
glusterd: make sort portable
fixed for fd leaking. reopening of file was not needed
BUG: 3491
Change-Id: I1351bdcaa41a5901574f5e779c33bf6f80a938f9
Reviewed-on: http://review.gluster.com/453
Reviewed-by: Csaba Henk <csaba@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit ae886b82636a9e6ba651f1da11bc608893dc96e0
Author: Rajesh Amaravathi <rajesh.amaravathi@gmail.com>
Date: Mon Sep 19 13:22:54 2011 +0530
protocol/client: minor log enhancements
minor changes to the log enhancements of bug 3473.
Change-Id: Id38d29db5a744e0ab7342d10ead6d16866228062
BUG: 3473
Reviewed-on: http://review.gluster.com/452
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 46aad22eed0ac9cde6417cbcf786e47a551ef699
Author: Sachidananda Urs <sac@gluster.com>
Date: Mon Sep 19 12:32:33 2011 +0530
Fix typo in log message.
Change-Id: Ia51ffe03c8b94ddfe21c6609bc0d54b5bd29eca7
BUG: 3158
Reviewed-on: http://review.gluster.com/392
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 87288acbdd541ad9a0d3093cf956f9c577abfcae
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Sep 10 15:22:37 2011 +0530
features/marker: Use appropriate loc struct to do removexattr on newpath after rename.
Change-Id: I060e62c1fbb288179063a6d64d73bad1a6572661
BUG: 3493
Reviewed-on: http://review.gluster.com/390
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 58c26f8ab71aa89238da93c021bc1cb2aa59190a
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Fri Sep 16 14:03:40 2011 +0530
cli: check wordcount to validate volume set help
Change-Id: I93650af9fb29cffc48733d9bba5fd2fb580c44a1
BUG: 3543
Reviewed-on: http://review.gluster.com/436
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e87f20c8dbd8b2b84712ca8a68de2b5fb86e77eb
Author: Rajesh Amaravathi <rajesh.amaravathi@gmail.com>
Date: Mon Sep 12 11:11:56 2011 +0530
glusterd: make sort portable
The result of sorting the volume info file has
been programmatically redirected, instead of using
the -o option.
Change-Id: Id789fab8dc92b254571a4fc7239e4872f3ac055f
BUG: 3491
Reviewed-on: http://review.gluster.com/395
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8c24321642da10aa2350afdcab615e55d597ac2b
Author: Kaushal M <kaushal@gluster.com>
Date: Wed Aug 3 18:12:21 2011 +0530
cli : check for bad brick order while creating replicate volume
gluster cli now checks the brick order when creating
a replicate or distributed-replicate volume.
If a non-optimal order is found the user is given a
warning and asked if the volume creation can proceed.
Change-Id: I38c4cb65bffb40ccf95319cf3f4f3423a4cdebe9
BUG: 2407
Reviewed-on: http://review.gluster.com/151
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 832e330c6fc71b3e04b60c16fa3b1d387572d7aa
Author: Kaushal M <kaushal@gluster.com>
Date: Tue Aug 16 13:17:38 2011 +0530
glusterfsd: enable max fetch attempts
Enables usage of 'volfile-max-fetch-attempts' option of glusterfsd.
Also, adds an option to 'mount.glusterfs' for setting the max fetch attempts.
For a server with multiple ips, each call to gf_resolve_ip6() returns a
different ip. Since gf_resolve_ip6() is called for each fetch attempt,
this change also enables rrdns support for gluster.
Change-Id: I3edadbf0ff43ff414b30eb50dd9ca4a6fd6b1089
BUG: 2441
Reviewed-on: http://review.gluster.com/239
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 61c8c97cbc4ac27573664b9d7fd9cfa15f62cbd9
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 16 15:17:24 2011 +0530
performance/quick-read: fix memory corruption.
- macro QR_STACK_UNWIND destroys the stub present in local and hence no need
of explicitly calling call_stub_destroy on it.
Change-Id: Ib81c9a0d382765e783722b14fdbd7877086b1bec
BUG: 3562
Reviewed-on: http://review.gluster.com/439
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit b193d1e8bf65c15401e961595131af6bb3dec7e6
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Sep 15 02:29:54 2011 +0200
libglusterfs: run: fix closing of redirection fd in child
When run was doing a program invocation like "echo foo > foof",
the file descriptor to foof was closed before stdout could be
reopened to it.
To fix this, we change the order of actions: first do redirections,
then do the fd cleanup. This also simplifies code (as there are less
fds which are exempt of the cleanup).
Change-Id: I5f74e41f2999e59916a40c8a89d7fb730d808c27
BUG: 2562
Reported-by: Rajesh Amaravathi <rajesh@gluster.com>
Reviewed-on: http://review.gluster.com/428
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Rajesh Amaravathi <rajesh@gluster.com>
Reviewed-by: Rajesh Amaravathi <rajesh@gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit cd9d5d5b6e1525d80dc539b3a08a4f4d553cfa80
Author: Rajesh Amaravathi <rajesh.amaravathi@gmail.com>
Date: Fri Sep 2 15:10:30 2011 +0530
protocol/client: log enhancements
* print paths wherever it is possible to log, to help debugging.
* bring uniformity in log level.
Change-Id: I2fa85b629de5dd0f0057ed96cba08ecb0ff1a798
BUG: 3473
Reviewed-on: http://review.gluster.com/328
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 90b27213dc05583ec3c783ea64126fa5ec3203d8
Author: krishna <krishna@gluster.com>
Date: Wed Sep 14 16:13:27 2011 +0530
rpc: Use correct variable for volume-specific insecure ports check
Change-Id: Ica59a3154c4e7d980d3477dd3879c7cebe92ad87
BUG: 3515
Reviewed-on: http://review.gluster.com/418
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e8511756deebf1a3caf6035f84975e3b7b920ec6
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Sep 16 15:03:32 2011 +0530
cli: if the create volume command does not contain bricks, exit gracefully
Change-Id: I41f896d5a9c514994874b6e4e956d38fed742d4b
BUG: 3571
Reviewed-on: http://review.gluster.com/438
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 3ec42ad2e1f29ecdeb41b50e826d1f3105be3e1d
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Sep 15 17:09:00 2011 +0530
glusterd: profile cmd incorrectly reports all bricks down.
If there are no bricks of a volume running 'local' to glusterd
where the 'profile info' command is issued, glusterd incorrectly
reports that all bricks of the volume are down.
Change-Id: Idd703c991f0bcf59b76b9ef8f4ad8cd71960a55b
BUG: 3553
Reviewed-on: http://review.gluster.com/430
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 857ba8a24c50c48828127a7fa37a676335ca1fdd
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Sep 15 18:14:53 2011 +0200
rpc: fix up mountbroker xdr defs and regenerate headers
Change-Id: I8a88d2b9228c3614ee7cbaf48782a419e6aee0f6
BUG: 3482
Reported-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-on: http://review.gluster.com/432
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ef6370d4a901e4d8fe1b386f333391edc3e94f4d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Sep 8 14:06:32 2011 +0530
Proactive self heal process implementation
Change-Id: I96db0d94566ceabf1649f890318363f738c06553
BUG: 2458
Reviewed-on: http://review.gluster.com/403
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0b56277b5cc726d3268fb8b0ae3d1cdec2eb2778
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 7 21:26:41 2011 +0530
dict: add reset function which empties the dict
Change-Id: I267c81a129197534fb318671eafb76e144a15c8c
BUG: 2458
Reviewed-on: http://review.gluster.com/402
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 78279094de9234eb7fe61a3d5d48fc946e87b94e
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 6 13:56:03 2011 +0530
debug/io-stats: Allow multiple children in graph
Change-Id: Ie4fb75d8000ff95daa8bf9f6757926822de28a65
BUG: 2458
Reviewed-on: http://review.gluster.com/401
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 6fa7719c553dad009199093f733d517b01ffb55f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 13 15:15:10 2011 +0530
features/quota: explicitly create xattrs in marker_create_cbk
- the earlier approach of creating quota related xattrs through
side-effect of updating size and contribution values won't work,
since when no contribution xattr is present, the updation process
treats contribution value as zero and hence will be equal to size
of freshly created files
Change-Id: If9b2063b1ac3a4cf50d3fe2c81e907bc8eccb677
BUG: 3531
Reviewed-on: http://review.gluster.com/385
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Mohammed Junaid <junaid@gluster.com>
commit 736aafa8ce9aad2c54745d38d0efcf1cc926aeeb
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 9 17:14:41 2011 +0530
features/quota: implement mknod fop.
Change-Id: If8f2a0bb635160ee78f35787ee9f8a4db87ae8ac
BUG: 3531
Reviewed-on: http://review.gluster.com/384
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Mohammed Junaid <junaid@gluster.com>
commit 34f7bb714f58a144515108d9610b3c1cd8aef5c3
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 14 15:59:21 2011 +0530
glusterfsd: log the package version just after log init
helps getting output of 'glusterfs --version' from the users while
debugging any issues/bugs.
Change-Id: I4f15aca143c1e403c70409378afc9ed7a678b286
BUG: 2346
Reviewed-on: http://review.gluster.com/415
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 232a62a37574b1da2b38eba216e9cfde563674cc
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 14 13:51:40 2011 +0530
libglusterfs/common-utils: resolve_ip6() to take AI_ADDRCONFIG
AI_ADDRCONFIG flag is needed for 'getaddrinfo()' call as hint so
that while resolving a hostname, ip list will be taken from proper
configured address family
Change-Id: Iad6067ad64444d3930d5be593ca819a8de5fc0c1
BUG: 3548
Reviewed-on: http://review.gluster.com/414
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7f0c88ecdae6faa674b9700ea3261d55cbb91572
Author: Venky Shankar <venky@gluster.com>
Date: Tue Sep 13 11:36:55 2011 +0530
GlusterFS Hadoop specific DSL for mountbroker
Change-Id: Ie379992bdea0974c8c5e1a4d7bc3e87cefe0d256
BUG: 3539
Reviewed-on: http://review.gluster.com/404
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 79b6fc3d708ea3c8da986f68461ef8953a7f1b75
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 13 16:54:24 2011 +0530
glusterd rebalance: fix minor issues
there were bugs introduced due to parallelizing rebalance op.
* argument to dict_set_str () should be static as for the life of dict
* uuid_utoa() output should not be considered as static
* overloading 'volinfo->defrag' in other nodes is a overkill, just KISS
Change-Id: I43d00c8e22beb2dd5c5f9824552f7337543b2255
BUG: 2112
Reviewed-on: http://review.gluster.com/407
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e47faeb0b5e0fe4dc2206b80f05eae40957ddc42
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 9 09:42:51 2011 +0530
support for de-commissioning a node using 'remove-brick'
to achieve this, we now create volume-file with
'decommissioned-nodes' option in distribute volume, then just
perform the rebalance set of operations (with 'force' flag set).
now onwards, the 'remove-brick' (with 'start' option) operation tries
to migrate data from removed bricks to existing bricks.
'remove-brick' also supports similar options as of replace-brick.
* (no options) -> works as 'force', will have the current behavior
of remove-brick, ie., no data-migration, volume changes.
* start (starts remove-brick with data-migration/draining process,
which takes care of migrating data and once complete, will
commit the changes to volume file)
* pause (stop data migration, but keep the volume file intact with
extra options whatever is set)
* abort (stop data-migration, and fall back to old configuration)
* commit (if volume is stopped, commits the changes to volumefile)
* force (stops the data-migration and commits the changes to
volume file)
Change-Id: I3952bcfbe604a0952e68b6accace7014d5e401d3
BUG: 1952
Reviewed-on: http://review.gluster.com/118
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a94174b0733706d2b7697cf84ac0f281da43d28d
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Sep 12 15:51:42 2011 +0530
mgmt/glusterd: check the availability of fuse for few glusterd operations
Change-Id: I410cc6a86c32637566e5498f69f46cb40322e7fb
BUG: 2715
Reviewed-on: http://review.gluster.com/364
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a20db812f111523acaba130886258e499228e09b
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Aug 31 18:04:19 2011 +0530
mgmt/glusterd: fail glusterd if gsyncd does not behave as expected
Change-Id: Ic54220328f15c579dcf441de2aad8620751a97ef
BUG: 2744
Reviewed-on: http://review.gluster.com/331
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@gluster.com>
commit 5e43151ef8d895ca0dfab91aeadf59182a3828b3
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 13 12:11:52 2011 +0530
socket: provide proper arguments to getaddrinfo
-----
from 'man getaddrinfo' :
If hints.ai_flags includes the AI_ADDRCONFIG flag, then IPv4 addresses
are returned in the list pointed to by res only if the local system has
at least one IPv4 address configured, and IPv6 addresses are only
returned if the local system has at least one IPv6 address configured.
-----
Change-Id: Ie30344daf1bb9d41ac58741b38e83af35cd8b5e9
BUG: 2456
Reviewed-on: http://review.gluster.com/405
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit dd46448f1083eaa9a8ad3c5deb46b54cb6fd094b
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 7 12:53:09 2011 +0530
distribute rebalance: handle the open file migration
Complexity involved: To migrate a file with open fd, we have to
notify the other client process which has the open fd, and make
sure the write()s happening on that fd is properly synced to the
migrated file. Once the migration is complete, the client
process which has open-fd should get notified and it should
start performing all the operations on the new subvolume,
instead of earlier cached volume.
How to solve the notification part:
We can overload the 'postbuf' attribute in the _cbk() function to
understand if a file is 'under-migration' or 'migration-complete'
state. (This will be something similar to deciding whether a file
is DHT-linkfile by its 'mode').
Overall change includes below mentioned major changes:
1. dht_linkfile is decided by only 2 factors (mode(01000),
xattr(trusted.glusterfs.dht.linkto)), instead of earlier
3 factors (size==0)
2. in linkfile self-heal part (in 'dht_lookup_everywhere_cbk()'),
don't delete a linkfile if there is a open-fd on it. It means,
there may be a migration in progress.
3. if a file's revalidate fails with ENOENT, it may be due to file
migration, and hence need a lookup_everywhere()
4. There will be 2 phases of file-migration.
-> Phase 1: Migration in progress
* The source data file will have SGID and STICKY bit set in its mode.
* The source data file will have a 'linkto' xattr pointing the
destination.
* Destination file will have mode set to '01000', and 'linkto' xattr
set to itself.
-> Phase 2: File migration Complete
* The source data file will have mode '01000', and will be 'truncated'
to size 0.
* The destination file will have inherited mode from the source. (without
sgid and sticky bit) and its 'linkto' attribute will be removed.
4. Changes in distribute to work smoothly with a file which is in migration /
got migrated.
The 'fops' are divided into 3 categories, inode-read, inode-write and others.
inode-read fops need to handle only 'phase 2' notification, where as, the
inode-write fops need to handle both 'phase 1' and phase2. The inode-write
operations will be done on source file, and if any of 'file-migration' procedures
are detected in _cbk(), then the operations should be performed on the destination
too.
when a phase-2 is detected, then the inode-ctx itself should be changed to represent
a new layout.
With these changes, the open file migration will work smoothly with multiple clients.
Change-Id: I512408463814e650f34c62ed009bf2101d016fd6
BUG: 3071
Reviewed-on: http://review.gluster.com/209
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 00b577afc31d76164189f86ae5dc834ea622f43d
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Aug 24 23:01:31 2011 +0200
geo-rep: partial support for unprivileged gsyncd via mountbroker
gsyncd:
- mounting code is split to a direct and a mountbroker based backend
- option gluster-command gone
- new options: gluster-params, gluster-cli-options, mountbroker
- mountbroker mount backend is used if either a mountbroker label
is given through the mountbroker option, or if gsyncd is
unprivileged; in this case the username is used as label
- have gluster cli invocations log to stderr so that we don't
hit a permission issue with the logfiles
glusterd:
- do gsyncd pre-config with new options
- add option geo-replication-log-group, so if that specified
geo-rep logfile directories are given to that group (and
thus members of the given group can do logging there)
This is just WIP as geo-rep relies on trusted extended attributes
and those are not accessible for unprivileged users. Even if we
solved this issue, glusterd security settings are too coarse,
so that if we made it possible for an unprivileged gsyncd
to operate, we would open up too far.
Change-Id: Icd520b58cbadccea3fad7c0f437b99de1e22db14
BUG: 2825
Reviewed-on: http://review.gluster.com/399
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 435e76a4d4437ac4291069a68f71ddeb68252a19
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Jul 30 17:50:22 2011 +0200
glusterd / cli: mount-broker service
Mountbroker is configured in glusterd volfile through a DSL
which is restriced enough to be able to appear in the role
of the value of a volfile knob.
Basically the DSL describes set-theorical requirements
against the option set which is sent by the cli (in the
hope of getting a mount with these options).
If the requirements meet and the volume id and the uid
who is to "own" the mount can be unambigously deduced from
the given request, glusterd does the mount with the given
parameters.
The use case of geo-replication is sugared by means of volume
options which then generate a complete mount-broker option set.
Demo:
- add the following option to your glusterd volfile:
option mountbroker-root /tmp/mbr
option mountbroker.fool EQL(volfile-id=pop*|user-map-root=*|volfile-server=localhost)&MEET(user-map-root=john|user-map-root=jane)
- before starting glusterd, create /tmp/mbr owned by root with mode 0755
- with cli, do
$ gluster system:: mount fool volfile-id=pop33 user-map-root=jane volfile-server=localhost
- on succesful completion (volume pop33 exists and is started, jane is a valid username),
the mount path will be echoed to you
- you can get rid of the mount by
$ gluster system:: umount <mount-path>
Change-Id: I629cf64add0a45500d05becc3316f67cdb5b42ff
BUG: 3482
Reviewed-on: http://review.gluster.com/128
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8c021c7c2813785945b0b6be8d65e8aa76f4d313
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Jul 30 16:45:50 2011 +0300
add --user-map-root option
This makes client fake that given user is a superuser,
by changing FUSE requests coming with uid of user so that uid
is set to 0.
User can be given in numeric form, in which case it's treated
as an uid directly, or else it's tried to be resolved to an
uid with getpwnam(3).
Implies --acl.
Change-Id: I2d5a3d3e178be7ffdf22b46a56f33a7eeaaa7fe1
BUG: 3242
Reviewed-on: http://review.gluster.com/127
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f666b3f2f6800d190ab9636302a6965184d0eac1
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Jul 23 12:16:07 2011 +0200
cli: add --log-{file,level} options
Apart from diagnostic purposes, it's needed when cli is ran by
unprivileged user who most likely has no write access to the
canonical log file.
Change-Id: Ib9d1a31711966ff1efe2592fbc0a911820cf8ee3
BUG: 3242
Reviewed-on: http://review.gluster.com/95
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 70ef06179bf32b8148eae457706b66efcfb7bd3d
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Jul 23 12:14:48 2011 +0200
cli: fix option parsing bug which implied that only a single option can be used
Change-Id: I89467d00030f4714568ef63650ecef0aef1bf753
BUG: 3242
Reviewed-on: http://review.gluster.com/94
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d10fcd93d9a0f0c757ee5ec43983fa851fa9f13a
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Jul 15 11:44:56 2011 +0200
cli: reimplement "--version" without excess bloat
Change-Id: I787d241e72b6a6c43db96c220d68fe369bb700a4
BUG: 3242
Reviewed-on: http://review.gluster.com/93
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3908d5741902c7d54655d005be1845a8375e5ec1
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Jul 15 11:34:35 2011 +0200
Revert "cli: Only admin should run gluster CLI"
This reverts commit 8d64ca70b4c2467d4ed8c76a9eae385abdebd7a7.
Change-Id: Id2c6b491c7dd133510380f576ad59655a01d6121
BUG: 3242
Reviewed-on: http://review.gluster.com/92
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit da314432a6c17c1048d2b85efbe687865f677351
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Jul 15 11:34:25 2011 +0200
Revert "cli: gluster --version implementation"
This reverts commit e93b270e8d09fc9d36a39b22987d3a172197e73b.
Conflicts:
cli/src/cli.c
Change-Id: Ibc0f6f752f713b15afc8b5458be5045ecb21235e
BUG: 3242
Reviewed-on: http://review.gluster.com/91
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 5122fd95e2ee50b8d0d233d773f96c97ff299ca1
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Aug 10 20:04:20 2011 +0300
gsyncd: python3 compat fixes
Also add __codecheck script which can verify if source is OK at the
syntactical level with a given Python interpreter.
Change-Id: Ieff34bcd3efd1cdc0e8f9a510c05488f35897bbe
BUG: 1570
Reviewed-on: http://review.gluster.com/320
Reviewed-by: Kaushik BV <kaushikbv@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit c6877d24f014bac1ff19edd84b8b50db9f2731dd
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Aug 15 03:17:18 2011 +0300
glusterd: fix cleaning up of runner object
in lack of that, if geo-rep component is not installed, glusterd got a zombie child
Change-Id: Ic4a2a4ffc943de68dd02db76a32b1618821ddf56
BUG: 2744
Reviewed-on: http://review.gluster.com/317
Reviewed-by: Kaushik BV <kaushikbv@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7e7f40c5db0b073a79c7249cab2fabd7be24fcf2
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Sep 5 20:14:21 2011 +0530
rpc: Need to keep ref when handling cbk in call_bail.
Change-Id: Ic944599cfa2696a0ae77105185d49fb510ce6fec
BUG: 3511
Reviewed-on: http://review.gluster.com/361
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 195111ba385fc230a93d0f11780407421a5e91f9
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Sep 12 11:45:37 2011 +0530
glusterd: free the allocated string to avoid memory leak
Change-Id: I520abf3c57a15be8bb7dd1e92ad0b049ef5c8970
BUG: 3341
Reviewed-on: http://review.gluster.com/394
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit dd4c026b94ca884f12f5aad00221299916e86ee3
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Aug 31 13:02:21 2011 +0530
protocol/client: avoid code duplication in fd based operations
Change-Id: I012f78bac8ba82333628c59ef51d5e5f43d05ac7
BUG: 3158
Reviewed-on: http://review.gluster.com/329
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7edb46fd0e3bc572c47dbc445017a92cf9b1ac42
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Aug 22 22:37:43 2011 +0530
features/marker: unref the local incase of errors before unwinding
Change-Id: I4dcad7ddf84bf98b4b7f4a0e407a418426674280
BUG: 2784
Reviewed-on: http://review.gluster.com/299
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 956a1fe0df5d0c8081e513c75cc347be516e5bb1
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Sep 9 13:17:10 2011 +0530
mgmt/glusterd: volume set help-xml format change
Change-Id: I503364c855d52605e301f4d3c205af6c9fc0e1df
BUG: 3366
Reviewed-on: http://review.gluster.com/380
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit d331946d9440ab1b93d2680989b0bb333f8c1d2f
Author: Junaid <junaid@gluster.com>
Date: Fri Sep 9 14:35:57 2011 +0530
features/marker-quota: Prefix the function names with mq (marker-quota).
This is to fix to bug marker translator and quota translator cannot co-exist in same process.
Change-Id: I9f132b663f03641f4f2c7e168df8400adbc5570f
BUG: 3020
Reviewed-on: http://review.gluster.com/381
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit dc13855ac9edc1ee5041b1eeb73af5a2b378d0b6
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 7 13:50:19 2011 +0530
cluster/afr: perform self-heal with least priority
Change-Id: Id8a1dffa3c3200234ad154d1749278a2d7c7021b
BUG: 3502
Reviewed-on: http://review.gluster.com/336
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 25f757debd6e6b27b5f30a545e3e63a7a7bbdaf4
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 7 12:46:30 2011 +0530
glusterd rebalance: make co-operate with all other 'op'
that way, we can share the rebalance state with other peers
and can prevent confusion/conflicts when multiple rebalances
are done by different peers.
Change-Id: I24159e69332644718df7314f6f1da7fce9ff740e
BUG: 2112
Reviewed-on: http://review.gluster.com/343
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 346f032e3b77a0bca331696ee4b7cf09579b8f57
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 8 00:34:32 2011 +0530
cli: 'gluster create volume' - improve option parsing
now 'replica' 'stripe' and 'transport' options can be given in any order
Change-Id: Ied992ae55e86028bd4f2d662ebd246db138d4548
BUG: 3521
Reviewed-on: http://review.gluster.com/370
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 9ea4334294bf7cffd2254b9ec920cf2c238f0eae
Author: Junaid <junaid@gluster.com>
Date: Wed Sep 7 17:36:09 2011 +0530
features/marker-quota: Perform xattr related operations with root permissions in rename fop.
Change-Id: Id9ac1ecdd9753377c9eb24464f51dcbdc0cd2821
BUG: 3194
Reviewed-on: http://review.gluster.com/367
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f35a768f94629ad87d82d2fbcf6ab23eb20359d1
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Sep 2 15:59:40 2011 +0530
performance/io-threads: treat -ve pid as request for fop with least priority
Change-Id: Ib6730a708f008054fbd379889a0f6dd3b051b6ad
BUG: 3502
Reviewed-on: http://review.gluster.com/335
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 05fb259fa9fc67822d762ecd85ddddb2502b47b1
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Sep 2 08:50:48 2011 +0530
cluster/afr: Make data selfheal trigger to be configurable.
By default, lookup triggers data self-heal but that is not the preferred way
of operating replicated volumes. We would like the data self heals to be
triggered in open instead.
Number of back-ground self-heals allowed is 16 and lookups block until
self-heal is completed. We want to prevent blocking in fops. We can not make
lookups independent of self-heal frames because when there are gfid conflicts
the decision of which file is correct is determined in self-heal phase.
So in afr, lookup self-heal is going to guarantee name space consistency
and open/fd fops will take responsibility for data consistency, these
are non blocking. The user needs to set the option cluster.data-self-heal
"open" for this behavior.
Change-Id: If9463cdb9ebac114708558ec13bbca0270acd659
BUG: 3503
Reviewed-on: http://review.gluster.com/334
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit da9cf0d448c87affbf8b052db81fedbab27a93b5
Author: Anand Avati <avati@gluster.com>
Date: Wed Aug 31 22:57:34 2011 +0530
posix-acl: configurable super user ID
In configurations with a uid mapper, super user ID could be mapped
to a non-zero value. Hence making it configurable in access control
would be necessary for proper super-user semantics.
Change-Id: I51e8e0395680e9b96a99657a0af547659bd9affe
BUG: 2815
Reviewed-on: http://review.gluster.com/332
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit a4d831da76ab2c0dd221ab83758b696124743c49
Author: Anand Avati <avati@gluster.com>
Date: Tue Aug 16 12:56:21 2011 +0530
cluster/afr: eager locking of FD writes
This patch is a change in the way write transactions hold a lock
which optimizes the case of sequential writes from a single writer.
Lock phase of a transaction has two sub-phases. First is an attempt
to acquire locks in parallel by broadcasting non-blocking lock
requests. If lock aquistion fails on any server, then the held locks
are unlocked and revert to a blocking locked mode sequentially on
one server after another.
The change in this patch is to make the initial broadcasting lock
request attempt to acquire lock on the entire file. If this fails,
we revert back to the sequential "regional" blocking lock as before.
In the case where such an "eager" lock is granted in the non-blocking
phase, it gives rise to an opportunity for optimization. i.e, if
the next write transaction on the same FD arrives before the unlock
phase of the first transaction, it "takes over" the full file lock.
Similarly if yet another transaction arrives before the unlock phase
of the "optimized" transaction, that in turn "takes over" the lock
as well. The actual unlock now happens at the end of the last
"optimzed" transaction.
Any operation which arrives before the unlock phase of the previous
transaction is a potential candidate to become an "optimized"
transaction. In cases where the previous transaction had aquired
lock as a "regional" blocking lock, and the next transaction comes
in before its unlock phase, then it would not be an "optimized"
transaction.
Implied assumption
------------------
Since two or more transactions can now operate within the same
large lock, there is a possibility that overlapping transactions
can arrive at oppoosite orders on the servers. However in the
larger picture this is not possible as write-behind already
ensures that no two overlapping writes on an inode are in transit
at the same time. Overlapping writes across clients are not a
problem as they compete at locks anyways.
Theoretical benefits and potential harms
----------------------------------------
In case of a single writer: The benefits are large for sequential
writes. In the best case the entire file write can happen with just
one lock and unlock per server, provided writes are coming in fast
enough and getting pipelined by write-behind soon enough (which is
usually the case). If the writes are not coming in fast enough, then
the optimization "kicks in" for only those subsets of writes which
are close enough to get "piggybacked". For random writes the benefits
are the same as well. In any case the overall performance is better
than or equal to the performance without this optimization for a single
writer.
In case of multiple writers: When multiple writers are not writing
concurrently, there is no negative performance impact. When multiple
writers are writing concurrently to the same region, there is no
negative impact either, as they were previously getting arbitrated
at the locks translator too. In the case of multiple writers writing
to different regions concurrently, there will be an increased number
of "failovers" from failed parallel non-blocking to sequential blocking
regional locks. This above "worst case" has a simple workaround that
as soon as we detect > 1 open-fd-count in lookup xattr, we can disable
this optimization on those fds.
Beneficial side-effects
-----------------------
There is another similar optimization in AFR for changelogs which goes
by the name of "changelog-piggybacking". That works in a similar way where
pending flags get 'taken over' or 'piggybacked' by the next transaction
if its 'pre-op' phase kicks in before the 'post-op' phase of the
previous transaction. It has been observed that this changelog-piggybacking
optimization gives a saving of about ~55% savings of xattr calls hitting
the wire, measured across various types of network interfaces. The side
effect of this eager-lock optimization is that it gives an almost 100%
saving of xattr calls by making the optimistic-changelog work much more
efficiently as it gives a wider overlap of the xattr phases of two
consecutive transactions.
Change-Id: I41c02eb3b64c14c68ef66a344610ec3f024cd59d
BUG: 3409
Reviewed-on: http://review.gluster.com/240
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 3a66b46cc2c3e2598273b5cc35671196d7b7b692
Author: Rajesh Amaravathi <rajesh.amaravathi@gmail.com>
Date: Tue Sep 6 17:29:31 2011 +0530
storage/posix: posix getxattr log enhancement
Now the key is logged with getxattr failure.
Change-Id: I96a9234cf138ae0922dc403e2fddcd4df0d89df8
BUG: 3283
Reviewed-on: http://review.gluster.com/373
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 359da71cad95f20f6b9017a143284b6ee7732d64
Author: Rajesh Amaravathi <rajesh.amaravathi@gmail.com>
Date: Mon Aug 29 10:30:56 2011 +0530
mount/nfs: Gluster nfs crashes with subdirectory mount
Glusterfs used to crash trying to dereference a NULL
pointer. Also, in mnt3_resolve_export_subdir, volume
name was prefixed to sub directory exported, resulting in
mount fail of sub directory. Fixed both issues.
Change-Id: I746f0c244b4cbf03033d73ac3e40518762d76385
BUG: 3481
Reviewed-on: http://review.gluster.com/323
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit e582a8d974b92a235d940ed6688006113c65221f
Author: Pavan T C <tcp@gluster.com>
Date: Wed Sep 7 18:05:57 2011 +0530
Save the mode flags set by the application when ACLs are in use
While inheriting the ACLs from a directory that has default ACLs, make sure
that the mode flags set by the application are saved. It is required to
inherit only the Read, Write and Execute permissions while leaving the others
viz. setuid, setgid and sticky bit untouched hence honouring the requests made
by the application during create operations (mknod, mkdir et al).
For a description of the problem, root cause and evaluation, refer:
http://bugs.gluster.com/show_bug.cgi?id=3522
Change-Id: I994077fb321a35d8254f0cc5a7de99a17ec40c47
BUG: 3522
Reviewed-on: http://review.gluster.com/368
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 6506903e73674bb24dabd8d1630eafa54e572c80
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Aug 10 05:02:43 2011 +0300
gsyncd: do the homework, document _everything_
Change-Id: I559e6a0709b8064cfd54c693e289c741f9c4c4ab
BUG: 1570
Reviewed-on: http://review.gluster.com/319
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushik BV <kaushikbv@gluster.com>
commit edf4fd9a0758b5feb22ebd1499ee543a47b66be3
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Sat Sep 3 14:51:45 2011 +0530
nfs3: Resolve entry vs. hash conflict at same dir depth
Intro Note
==========
The current code in hard fh resolution takes the first-match approach, i.e.
which ever dirent either matches the hash or matches the gfid first
is the one chosen as the result for the next step of fh resolution. In
the latter case, i.e., dirent matches the gfid, we the next step is to
conclude the fh resolution by returning the entry whose gfid matched.
In the former, i.e., the hash matches the dirent, we choose the hash-matching
dirent as the next directory to descend into, for searching the file to be
operated upon.
Problem
=======
When performing hard fh resolution, there can be a situation where:
o the hash of the primary entry,i.e. the entry we're looking for and the hash
of another sibling directory, match. Note the use of "sibling", meaning both
the primary entry and the hash matching one are in the same directory, i.e.,
their filehandle.hashcount will be same.
o the sibling directory is encountered first during the dir search.
Because of the current code described in "Intro", we'll end up descending into
the sibling directory even though the correct behaviour is to ignore this and
wait till we encounter the primary entry in the same parent directory.
Once we end up descending into this sibling directory, the directory depth
validation check fails. The check fails because it notices that the resolution
is attempting to open a directory that is deeper in the fs tree than the file
we're looking for. When this check fails, we return an ESTALE. So basically, a
false-positive results in an estale to Specsfs.
This is not a theoretical situation. Me and Avati saw this on specsfs test
where sfs created terabytes-sized file system for its tests. The number of
files was so huge in a single directory that the hashes of two entries ended up
colliding.
Change-Id: I4a6df11d326a67a507b1cd716c2c8e00b5a858a4
BUG: 3510
Reviewed-on: http://review.gluster.com/357
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shehjar Tikoo <shehjart@gluster.com>
commit d6819d2c56ef90ef159888b7d702bff7adcbd121
Author: Jeff Darcy <jdarcy@redhat.com>
Date: Wed Sep 7 20:03:24 2011 -0400
Eliminate many "var set but not used" warnings with newer gcc.
This fixes ~200 such warnings, but leaves three categories untouched.
(1) Rpcgen code.
(2) Macros which set variables in the outer (calling function) scope.
(3) Variables which are set via function calls which may have side effects.
Change-Id: I6554555f78ed26134251504b038da7e94adacbcd
BUG: 2550
Reviewed-on: http://review.gluster.com/371
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit d2d93103979fd73a28f0c1abda34529312da24a3
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 7 20:46:20 2011 +0530
glusterd: send the 'stripe-count' value to peer during handshake
without which, if a peer is added after volume of type 'stripe-replica'
is created, it won't be reflected in the newly added peer.
Change-Id: I77ee6aa3f33994bd4c6dbfefd853cc7e7491c1db
BUG: 3523
Reviewed-on: http://review.gluster.com/369
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 0382da9e001f9744409fcc7bd8df33614932d21f
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 25 17:51:18 2011 +0530
glusterd: fail the 'peer probe' if the first connect attempt fails
so 'gluster peer probe' command doesn't hang till timeout (120s),
instead it will send the proper error msg to client.
Change-Id: I398fa16d526f869f1d27eeb57aeb7ee4451fbecd
BUG: 1852
Reviewed-on: http://review.gluster.com/342
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit c148c27dd5389c25f045de26897fc3dff25c5d26
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Aug 29 17:53:24 2011 +0530
modify to the way we used XDR definitions files (.x files)
Earlier:
step 1: copy the existing <xdr>.x files to /tmp
step 2: generate '.[ch]' files using 'rpcgen <xdr>.x'
step 3: check diff with the to the existing files, add only your part
of changes back to the original file. (ignore other changes).
step 4: there is another file to write wrapper functions to convert
structures to/from XDR buffers, update it with your new structure.
step 5: use these wrapper functions in the newly written procedures.
step 6: commit :-|
Now:
step 1: update (mostly adding only) the <xdr>.x file
step 2: run '<path-to-src>/extras/generate-xdr-files.sh <xdr>.x' command
step 3: implement rpc procedure to handle the request/response.
step 4: commit :-)
Change-Id: I219f9159fc980438c86e847c6b030be96e595ea2
BUG: 3488
Reviewed-on: http://review.gluster.com/341
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit dbbf14a5df5955fed5f2e67e0682ecfd73077af9
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Aug 28 12:53:12 2011 +0530
glusterfs protocol: bring in variable sized iobuf support
is a step towards reducing glusterfs memory footprint. should also
help a bit in overall performance.
Change-Id: I074d5813602b2c960d59562e792b3dc6e43d2f42
BUG: 3475
Reviewed-on: http://review.gluster.com/322
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 0207b7dfd9611845f1ee94658d1767bf035687ea
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Sep 3 14:13:06 2011 +0530
cluster/afr: Prevent double big lock when data self-heal loops are not spawned
The steps in normal data self heal:
1) take big lock by self-heal frame. Get the xattrs/stat to decide
source, sink information.
2) spawn loop frames which perform self-heal by taking small locks on
the file. Every time a new lock is taken and the old lock is released.
3) Before releasing the final small lock a big lock is taken by the
self-heal frame, and unlock on small-lock. Erasing of the pending xattrs
happen then the big unlock happen and that is the end of the data self-heal.
When a data self-heal is needed for a file and the fop
that triggers the self-heal is open with O_TRUNC. Fuse sends open then
an explicit truncate for this. Open triggers the self-heal but by the
time it tries to spawn the loops the file size is truncated to 0, so
no loops are formed.
These are the steps:
1) Take big lock by self-heal frame. Get the xattrs/stat to decide
source, sink information.
2) loop frames are not spawned. The big lock is not released.
3) One more big lock is taken by the same self-heal frame, Erasing of
the pending xattrs etc happen, now it does two big unlocks, but after
the first unlock, the information on which the locks were performed is
forgotten, so the next unlock becomes a no-op. So there is a stale big
lock on that file preventing further writes.
As a fix, if the loops are not spawned, use the previous big lock to
perform the rest of the operations needed in completing the data
self-heal. No need to have one more big lock.
Change-Id: Id03171269594e447b2b6d1331e362d83bd1e3430
BUG: 3506
Reviewed-on: http://review.gluster.com/339
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit ff80f0cde7d2730b37b3e1fc59f74a3646277101
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Aug 31 10:06:45 2011 +0530
cluster/afr: Bring down the self-heal window size to 1
This is brought in an effort to be nice to the system resources when
self-heal is in progress.
Change-Id: I123f1eb4d8000613a35c0117f0aa27f926f3a921
BUG: 3503
Reviewed-on: http://review.gluster.com/333
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit a81c610168302af1b4271f20dcec61101f92195e
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 23 10:25:35 2011 +0530
mgmt/glusterd: code re-structuring
created new files per operations, (or group of operations)
Change-Id: Iccb2a6a0cd9661bf940118344b2f7f723e23ab8b
BUG: 3158
Reviewed-on: http://review.gluster.com/281
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 7dee3b0ef3cdb25381607deb8e9a8a074fa3ad21
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Aug 3 11:30:20 2011 +0530
glusterd: Removed local cli lock
This change contains,
- removal of the local cli lock used to serialize
cli ops to a glusterd.
- glusterd's state-machine can handle competing 'lockers' with
guaranteed progress.
- flush cluster lock on 'owner' disconnecting and as 'owner',
send unlock to all on first peer disconnect.
Change-Id: I25961436b0790b4196f2b3438b105c37279399ad
BUG: 3320
Reviewed-on: http://review.gluster.com/123
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit a5e15254fbe215eae26f2d8576a6d88b6201e668
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Aug 25 14:46:52 2011 +0530
performance/io-threads: Introduce new priority and priority-thread-limits
Change-Id: I7b4e7c467b833bc5896808e6e1d1b1a0322c4fdb
BUG: 3483
Reviewed-on: http://review.gluster.com/318
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ebc6c4e3b0a5b0cea5787150f78b15cc793052d8
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Aug 10 16:58:38 2011 +0530
mem-pool: Make mem-pool ptr avialable in ptr
The header of the ptr returned from mem-pool will now store the
mem-pool ptr it belongs to. mem_put will now take only the pointer
to be freed.
Also, changing MALLOC call to GF_CALLOC in mem_get when we run out
of entries in mem-pool. This also will have the header information
saved.
Change-Id: I3de182663a7f5b49c9e9425e9531775b70bdff67
BUG: 3390
Reviewed-on: http://review.gluster.com/205
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit f974c8fabcc2dee1013a5ed63174e152e8807c46
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Aug 24 12:57:18 2011 +0530
rdd: changes in rdd.c and whitespace cleanup
Change-Id: Ic117c6a3f9234a0181db1a106ef8a6574248f010
Reviewed-on: http://review.gluster.com/313
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit fb1fd334440a50d276651d733e1d6f054017f02a
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Jul 15 02:45:18 2011 +0200
gsyncd: refine command invocation
Use subprocess module instead of os.spawn* / ad-hoc fork/exec.
With this, we do now:
- close uneeded files in children
- watch childrens' stderr:
- have a thread which collects childrens' stderr into a ring buffer
(so that stderr pipe doesn't get stuffed)
- on command failure show stderr
- distinguish between rsync exit values, tolerate only partial errors
- if connection is broken to slave, show ssh/slave gsycd's stderr
Change-Id: Ia92f57b5bdfa47f8c44375c50cf279006a0bf69b
BUG: 2946
Reviewed-on: http://review.gluster.com/85
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Kaushik BV <kaushikbv@gluster.com>
Reviewed-by: Kaushik BV <kaushikbv@gluster.com>
commit eacb51331a5ea2b3442d3c14a405850ab09c07f7
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Jul 25 11:53:55 2011 +0300
glusterd: do preparative gsyncd invocations with proper logging
Change-Id: I28de4cce140faf1b35ecdc5cbd408f21c9926341
BUG: 3231
Reviewed-on: http://review.gluster.com/96
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0b962421efcec1c687931a25a5c3a9551b60b9e7
Author: Kaushal M <kaushal@gluster.com>
Date: Fri Aug 19 15:07:36 2011 +0530
cli: "profile info" output improvements
Some changes to profile info output.
Change-Id: I94a4bec1ca1c0670b3d9643f8321683b59c665aa
BUG: 3028
Reviewed-on: http://review.gluster.com/260
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 40f1b70d8e09c678dffb717b97794a2ddc380ad1
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Aug 24 12:49:48 2011 +0530
features/locks: avoid using reqlock to prevent race
Change-Id: Id8613f9641f748f996062342878070ba8fb27339
BUG: 2473
Reviewed-on: http://review.gluster.com/312
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pranithk@gluster.com>
commit 7cb95004762c94365c07ea57b84d5a09e05d0374
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jul 7 02:02:50 2011 +0200
glusterd / geo-rep: in status, display slave URLs in simpler normalized form
Ie. instead of writing out the fully expanded canonical URL like
ssh://root@192.168.3.4:gluster://127.0.0.1:bar
we just display
ssh://root@starship::bar
Change-Id: I2bd70650cbc9973d925f652bccb163d391e406c9
BUG: 2536
Reviewed-on: http://review.gluster.com/79
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushik BV <kaushikbv@gluster.com>
commit f426796d48d33192d87047068bbfee670f936216
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Aug 23 13:47:41 2011 +0530
xlator: fix for the volume set help crash
Change-Id: I1649ed61b13b935d714ca024e6883f3903c5edeb
BUG: 3460
Reviewed-on: http://review.gluster.com/310
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 0e2085120c18c4ee79dc31f9524f7bc6fcb673a1
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Aug 23 12:32:36 2011 +0530
performance/stat-prefetch: fix memory leak
Change-Id: I84580e297ba93a9a093c2e3432ea52e3c0db4a1a
BUG: 3467
Reviewed-on: http://review.gluster.com/307
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 27f76f36958bd190fe5364d783ba189c238105f6
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 23 11:44:05 2011 +0530
cluster/distribute: unwind the proper dict in getxattr_cbk
without which, quota would get confused about the total size
Change-Id: I0fb822ee67e3c1585f783ae35292fe71c47ee249
BUG: 3421
Reviewed-on: http://review.gluster.com/304
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 0babc5dc4b4147e4a721db614b7d9c2ffaab14ff
Author: Junaid <junaid@gluster.com>
Date: Mon Aug 22 17:32:08 2011 +0530
features/marker-quota: Fix invalid reads in readdir_cbk.
Change-Id: Icc1e9dc039f1f2d7ee94c689779a715a69d373fa
BUG: 3389
Reviewed-on: http://review.gluster.com/296
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bbc63062067d68a4f29b1f48490d3e135e43503b
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Aug 22 14:55:09 2011 +0530
mgmt/glusterd: Initialize local variable in volgen
Change-Id: I84b4f7c9c2787334ce67e5c3e0534953b691c8e0
BUG: 3460
Reviewed-on: http://review.gluster.com/295
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
commit fa87327d086e6460d2a8ca3424160c5ee8add620
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Aug 22 13:54:15 2011 +0530
cluster/afr: Perform flush on all the children involved in self-heal
Change-Id: I66362a3087a635fb7b759d7836a1f6564a6a7fc9
BUG: 3456
Reviewed-on: http://review.gluster.com/294
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 997ed6daff96cecf70708955322e888fbe9dc2a6
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Aug 22 12:14:22 2011 +0530
cluster/afr: Change definition of stale child
The code is checking for priv->child_up[i], which can change while the fop
is in progress. Since pending[child][id-of-transaction] alone is enough
to tell if the child became stale or not, use just that.
Change-Id: I494bf02cca66f4fd41526195fafce86a202c6bd1
BUG: 3455
Reviewed-on: http://review.gluster.com/293
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 70fb605deb9aa56f3eac73a67e6d6b8f66616833
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Aug 22 11:59:11 2011 +0530
cluster/afr: Paused fop should not continue with fop
Change-Id: Idce22a6266c354e327d5d717715d2e62533eec58
BUG: 3448
Reviewed-on: http://review.gluster.com/292
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 46ee01c4f10afb86ca9b8fad5a12240046eec459
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sun Aug 21 18:53:04 2011 +0530
features/marker: changes in marker to avoid race conditions and corruptions
Change-Id: I38ddfab200d59dd4c8e9f9dd964a98f3d7aa7ab7
BUG: 3389
Reviewed-on: http://review.gluster.com/289
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit d9c802de10455df3dd38bf378166124a528581f6
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Aug 21 18:21:21 2011 +0530
protocol/client: Changes to be benign to replace-brick
Change-Id: Ic227781760a5f6dbf8aad69a19f90e45d4aaec13
BUG: 3415
Reviewed-on: http://review.gluster.com/288
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8792e735663afd349435bf70fe26dfaadddb66ff
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Aug 21 17:46:57 2011 +0530
debug/io-stats: Handle loglevel in init
Change-Id: I5aa6ee7509a8f730ca64e2f7bada56d502785a6c
BUG: 3415
Reviewed-on: http://review.gluster.com/287
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 74311d3105c7807734d90d5fcdd666084ee5581a
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Thu Aug 18 18:20:24 2011 +0530
glusterd: replace-brick status was not 'shared' with peer.
Change-Id: Ia2d89fd919b077232a37debc2aebe1bc72150856
BUG: 3432
Reviewed-on: http://review.gluster.com/285
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit bc4f1ce5f46e445b43669bcd6c60d5aa7f497580
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Aug 21 16:58:15 2011 +0530
cluster/afr: fop should not continue if it is paused, until resumes
Change-Id: Ie026ebed98cf5ff75ae1a13437d29f67d0e0254a
BUG: 3448
Reviewed-on: http://review.gluster.com/286
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit e70beee0b95275538963c0544c1dede84556ca90
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Aug 21 16:34:19 2011 +0530
debug/io-stats: Handle log-level properly.
Change-Id: I8e5b8841705b161068bdb2ccd2ac119d6b250c88
BUG: 3415
Reviewed-on: http://review.gluster.com/284
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit e5b04e75748be4c08a81ffc1df9e5c023531bd7b
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sun Aug 21 15:56:33 2011 +0530
cluster/afr: set frame local
Change-Id: I861b3c4494735b0ba6e038cdc39c50b9866747a8
BUG: 3448
Reviewed-on: http://review.gluster.com/283
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c593ec5d10779823620573dc8867d4905218d386
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Aug 20 19:26:05 2011 +0530
rpc/xdr: Fix for Solaris build failure
Change-Id: I4704dfad655a79afb87ab275ba09413f785a97a4
BUG: 3446
Reviewed-on: http://review.gluster.com/280
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
commit 5a7664097a4340203990c3da85ce17f55956fbc8
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Aug 20 15:48:27 2011 +0530
cluster/afr: Perform self-heal without locking the whole file
Change-Id: I206571c77f2d7b3c9f9d7bb82a936366fd99ce5c
BUG: 3182
Reviewed-on: http://review.gluster.com/141
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 46ebca658149f7f616ffc919739093bbdcbdd9f0
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Aug 20 18:26:08 2011 +0530
mgmt/glusterd: Correct generation of nfs options in volfile
Change-Id: If3db4f81215271072030d7119081de5d8b1b3d78
BUG: 3414
Reviewed-on: http://review.gluster.com/279
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 26e9bf791d5a4f80983b04490533bce1e170cd49
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Aug 20 16:11:02 2011 +0530
while validating options, make sure memory accounting is init()ed.
Change-Id: Ifad5827c6b022de7d84e081ce77effda0c245a13
BUG: 3415
Reviewed-on: http://review.gluster.com/277
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit c2deebd8b2c66c470727ecdad736faae5b929001
Author: krishna <krishna@gluster.com>
Date: Sat Aug 20 14:32:35 2011 +0530
if nfs.port is not configured init the transport.socket.listen-port to GF_NFS3_PORT
Change-Id: I6c0db600ba2010b0a0272f58b16c4955b4b570f2
BUG: 3308
Reviewed-on: http://review.gluster.com/273
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 9faa8803e08fb9bdaad557a3422b231d93859b70
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Aug 20 15:52:27 2011 +0530
xlators/nfs: Fix a typo in option description
Change-Id: I626893fd16094742869d4abfa488b66924c2796e
BUG: 3445
Reviewed-on: http://review.gluster.com/276
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 803162c7eb14e25bcc2194e1339f3c4cc94da401
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Aug 20 15:18:09 2011 +0530
libglusterfs: Fix a crash in gluster volume set help
Change-Id: I585e8e685f5c23b6fa632ef708adf2e349ba6704
BUG: 3415
Reviewed-on: http://review.gluster.com/274
Reviewed-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 0e9f331ad6bbe7c28cc9141ae3b527fdcdcd922c
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Aug 19 13:51:14 2011 +0200
cli: remove bogus assertion
Since 86c818a9 (cli: taking my revenge ...) we cannot assert
an exact match for the op/subop keywords in the followup parser
functions. That is,
# gluster vol stat foo
is a valid invocation.
Change-Id: I3f7f410f64f440744141f458886e4bba8ceeca17
BUG: 3439
Reviewed-on: http://review.gluster.com/268
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 91fa49a7c5f8411a65a74d4ce6748e4e776f2daa
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Aug 19 15:56:49 2011 +0530
cluster/afr: Update fresh_children in lookup if no other ops in progress
If write/truncate fails we should remove the child that failed the fop
from the fresh children. The previous code assumes that the children
that succeeded the fop are fresh children, which is wrong. Fixed that
in this patch.
Change-Id: I1e6e21e20faea00516a0fdd2e95f2d7e9cf9076d
BUG: 3411
Reviewed-on: http://review.gluster.com/263
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8d8afafa6b2a86fa8823a55d7c868bc8f7eaf890
Author: Anand Avati <avati@gluster.com>
Date: Fri Aug 19 22:49:41 2011 +0530
options handling: remove missing options check in reconfigure
last minute change broke things. undo'ing damage.
Change-Id: I330cf819b03e09f80d609d580d8b4c3497a98bbf
BUG: 3415
Reviewed-on: http://review.gluster.com/271
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d8c599e783a64271006b5854946da8d9b2b1bd65
Author: Anand Avati <avati@gluster.com>
Date: Fri Aug 19 15:19:44 2011 +0530
smoke-test.sh: script used by gerrit as part of pre-commit test
Change-Id: Idc3be3e22cca5fc623b27c2f500f59785cbd332b
BUG: 3234
Reviewed-on: http://review.gluster.com/262
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit d2327ae4b55846d81fc6a63a0b2cc5ff26b46b66
Author: Anand Avati <avati@gluster.com>
Date: Fri Aug 19 14:56:13 2011 +0530
option validation: further fixes
fixes in option handling changes
Change-Id: I0a44cdb088e3f08cd43d583a580736d0903fa88c
BUG: 3415
Reviewed-on: http://review.gluster.com/261
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 8e3920168cf1650485e568d552312d3b8ba398db
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Aug 18 23:19:22 2011 +0530
mgmt/glusterd, cli: Introduce gluster volume status <volname>
Change-Id: Iea835b9e448e736016da2e44e3c9bfff93f2fa78
BUG: 3439
Reviewed-on: http://review.gluster.com/259
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit f4bea9932726ad4b1db5248765aa5aac5bfa2422
Author: Anand Avati <avati@gluster.com>
Date: Thu Aug 11 16:08:36 2011 +0530
xlator options: revamp xlator option validation/reconfigure code
- move option handling to options.c (new file)
- remove duplication of option validation code
- remove duplication of gf_log / sprintf
- get rid of xlator_t->validate_options
- get rid of option validation in rpc-transport
- get rid of validate_options() in every xlator
- use xlator_volume_option_get to clean up many functions
- introduce primitives to init/reconfigure option types
Change-Id: I51798af72c8dc0a2b9e017424036eb3667dfc7ff
BUG: 3415
Reviewed-on: http://review.gluster.com/235
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 6314704bb8f5794393372dc60eca4b39d6d2cf8f
Author: krishna <krishna@gluster.com>
Date: Wed Aug 17 12:22:49 2011 +0530
do rpcsvc_init() after we fill nfs_state structure and add to nfsx->options keys for allowing insecure client ports.
Change-Id: Iae755d1460f2c7296fc7980b5257afcf778e7767
BUG: 3296
Reviewed-on: http://review.gluster.com/247
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 037716c6ad4d6dc510b7954c676227e5bd4fdb3c
Author: Anand Avati <avati@gluster.com>
Date: Thu Aug 18 11:27:06 2011 +0530
rpc-clnt: fix merge error of http://review.gluster.com/248
cherrypicked patch did not have the logic to reset port number to
reconnect to glusterd.
Change-Id: I78c903d5a28626f83b5024bd323e77b5f159e374
BUG: 3409
Reviewed-on: http://review.gluster.com/254
Reviewed-by: Amar Tumballi <amar@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 04545d20020bc1c89c1d2196842f3bef53a70489
Author: Kaushal M <kaushal@gluster.com>
Date: Wed Aug 10 17:57:04 2011 +0530
glusterd: fix for volume stop causing inconsistent volume status
This fixes problem caused by race between glusterd and glusterfsd
occuring when they try to unlink pidfile during volume stop, which led
to the volume being stopped, but the status of the volume remained in
started state.
Change-Id: Ia99bb1a1fc6c78db138211538dfd10c577e82917
BUG: 3147
Reviewed-on: http://review.gluster.com/206
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit ad67aae05f4f7d948af75dd7eb588190e8d76eae
Author: Anand Avati <avati@gluster.com>
Date: Fri Aug 12 00:46:50 2011 +0530
rpc-clnt: perform XDR encoding in unlocked region
Change-Id: Ia11c3ced4bec5959a5f0d8fcd4c6070b2ead220a
BUG: 3409
Reviewed-on: http://review.gluster.com/248
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 263a40243b2cee584c1b48cafbd2ddc3c9351434
Author: Venky Shankar <venky@gluster.com>
Date: Wed Aug 17 15:19:05 2011 +0530
allocate extra bytes (for \0) when calling realloc
We use strcat to concat pathinfo strings. strcat appends a \0 at
the end. Therefore allocate extra bytes for the same to avoid
asserts being hit during gf_free call
Change-Id: I582f5858e7375a5bacfc5c702c612ee09c3bb355
BUG: 3413
Reviewed-on: http://review.gluster.com/249
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 04b5451eba0fa22b36c9a0104e1382f58156eac1
Author: Anand Avati <avati@gluster.com>
Date: Wed Aug 17 04:18:48 2011 -0700
Revert "Make sure glusterd and glusterfsd use the same address family"
This reverts commit 1dade36a6dfc6cae5559d5139f6b733e1b6fded1
This commit breaks glusterd. The insertion of --xlator-option=<transport family> in between --brick-port and <port> fails command line validation during glusterfsd start.
Change-Id: I40186ca89d1d16cf798404747771353b1f1a3e1d
Reviewed-on: http://review.gluster.com/251
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit f5af7566c1e220a7e4dbfef2e8a47f5b7b3f3029
Author: Anand Avati <avati@gluster.com>
Date: Wed Aug 17 04:16:59 2011 -0700
Revert "Remove white spaces"
This reverts commit 6ab425e4f3d34b1467f694ada9a36eacfac9bf3c
Dependency revert for http://review.gluster.com/229
Change-Id: I7c4fcc45a6c25aedf4f06cbdeedc1fecbe424f45
Reviewed-on: http://review.gluster.com/250
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 17b2f33430beb6b1e87524b32de73082efd6f9f5
Author: krishna <krishna@gluster.com>
Date: Wed Aug 17 12:48:46 2011 +0530
do not init nfs->override_portnum to GF_NFS3_PORT
Change-Id: I7dc26b64a177ce5d30352cf7c531f38517c0368a
BUG: 3308
Reviewed-on: http://review.gluster.com/155
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shehjar Tikoo <shehjart@gluster.com>
commit e92cbb0e65112f8da5cecfa4276e0c17b4ab26f9
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Wed Aug 17 06:19:05 2011 +0200
Remove white spaces
Change-Id: I646c0c8e70268de6a20bb23dc3834ac6f5d2bbf2
BUG: 3422
Reviewed-on: http://review.gluster.com/245
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 9b11d29501e83baa7e56f90ed77c66f379f0a145
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 16:20:14 2011 +0200
Make sure glusterd and glusterfsd use the same address family
NB: This was heavily tested on 3.2.2, but code has changed a lot
in the area. This patch itself is untested.
Change-Id: Ie472f04b0804276c2d8a9efc5c96106c33029498
BUG: 3422
Reviewed-on: http://review.gluster.com/229
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 126e0ceb928e39bc42b6ced7b9f6c25bf8da1e59
Author: Venky Shankar <venky@gluster.com>
Date: Tue Aug 16 11:32:35 2011 +0530
adjust allocated length to memory overrun fix
size of the allocated length is incorrectly calculated which could
cause memory overrun while filling the buffer
Change-Id: I4fbdbd1fff937ca15bae9f634ef5757dda52caa8
BUG: 3413
Reviewed-on: http://review.gluster.com/236
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit f766f87fef80a865710452a649e3b38ce1143b30
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Aug 13 21:52:35 2011 +0530
cluster/afr: read_child should be >= 0
Change-Id: I447fb6a93cdd77de322cd5ded30673411c4cf79e
BUG: 3251
Reviewed-on: http://review.gluster.com/233
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit d635361777c114c3209d08bd16f79c4e0bfcc6b1
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 09:12:27 2011 +0200
- Use linkat(2) instead of link(2) so that linking to symlink work on non Linux systems - Also use mkfifo to create FIFO on NetBSD: it does not wotk with mknod
Change-Id: I19ffd22b4d79009ef5f9d4a50fc6dd556c3c3ff4
BUG: 2923
Reviewed-on: http://review.gluster.com/226
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 1d1631a182880227b16cf86c0d9d554df1c9083f
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 12:00:49 2011 +0200
POSIXly correct: \n replacement is GNU sed specific
Change-Id: I5e4ca551b60477d454964e568209ad06f21cc64e
Reviewed-on: http://review.gluster.com/227
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 9967bfce126ab7ca79d23e5879c72906a791d512
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 09:17:44 2011 +0200
Allow georeplication for NetBSD
Change-Id: Id8d62f4f83255c67a5aa615aed23ba44c182290e
BUG: 2923
Reviewed-on: http://review.gluster.com/220
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 74b126b89005d6c614e1f9d2407e8e34f45ef52c
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 06:46:15 2011 +0200
Build fix for NetBSD
Change-Id: Icb0163d61bfbd3bad520c06a655f80ec05fc3fb2
BUG: 2923
Reviewed-on: http://review.gluster.com/214
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 49087b68f7e13b31d3ee40617cd8d443cffdb794
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 06:48:07 2011 +0200
Build fix
Change-Id: I10dca7aee73df31f8b279591852d6ac19eab8ccc
BUG: 2923
Reviewed-on: http://review.gluster.com/228
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 0d8eb546db8032fdaade22098bfbdf42f4fa4d76
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 06:34:54 2011 +0200
For systems where O_DIRECTORY does not exist, we defined it as 0, therefore ((flags & O_DIRECTORY) == O_DIRECTORY) is always true even if the flag is not set.
Change-Id: Ie7837d521ea20b36ed70cf93c1763c226ff0e9f0
BUG: 2923
Reviewed-on: http://review.gluster.com/213
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 262248be7100045c6e68318b4d2335f4fd8da601
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 09:23:15 2011 +0200
Do not distribute UFS1 extended attribute backing store
Change-Id: Ie05751aa8d96a2f7996843a914e1a66df2777eba
BUG: 2923
Reviewed-on: http://review.gluster.com/222
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 03af2fbe23ad885758bfe30e27dc7c2937ff592d
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 10:26:47 2011 +0200
One more missing change :-/
Change-Id: I6eeaee73e7c9124a1959acb2fe47d5cad3a3baac
Reviewed-on: http://review.gluster.com/225
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 2a8387dd2d1eef0b95730f02111d5f78b133ee6a
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 09:51:28 2011 +0200
Use bourne shell, fix error in previous commit
Change-Id: Id2a304d5090eb2564c5d56ea260fa53b9b17d0d5
Reviewed-on: http://review.gluster.com/223
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 48fb89d60ad8cbf9cf6572ea5c0f7a4e112d8a2a
Author: Emmanuel Dreyfus <manu@netbsd.org>
Date: Fri Aug 12 06:43:07 2011 +0200
sed -i is available from GNU sed, but is not portable. Output to a new file and move it to the original one on success instead.
Change-Id: Ib23dd9becd035054e6490dcb4d64b3f9eff89bf4
Reviewed-on: http://review.gluster.com/212
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 4b3cf3fc8a522f87a74b6f6995e639206269b0a4
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 11 14:59:19 2011 +0530
RO: fix read-only xlator support broken due to worm xlator fix
Change-Id: I7234909eecdc6af1b8482465f19d0490fcba94ad
BUG: 3166
Reviewed-on: http://review.gluster.com/210
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 970f4471a0123af7d6feca3d6e97799961064ef2
Author: shishir <shishirng@gluster.com>
Date: Tue Jul 19 16:02:12 2011 +0530
WORM: Write Once Read Many times xlator support
This xlator will allow files to be opened for write in append mode
only. Mount with --worm(glusterfs) or -o worm (mount) option to
enable worm xlator
Change-Id: I1be02fcf2aee2182ea2c66b514357918136fabeb
BUG: 3166
Reviewed-on: http://review.gluster.com/23
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit f584666f0a0dcf88290f23459b6767bc02b22e3d
Author: Anand Avati <avati@gluster.com>
Date: Wed Aug 10 23:11:36 2011 +0530
posix-acl: disable permission checks for fd based ops
If write calls are coming in through an fd with O_RDWR or O_WRONLY
flag then a permission check is unnecessary. However writes from
NFS ideally need a "stateless" check in each call and this results
in a permission failure due to the read-only mode (disregarding the
FD's writeability).
For now it is acceptable to disable write checks as almost always
the NFS client would already be doing such basic access control.
Also because the previous access-control translator (prior to
posix ACL introduction) too was permitting writes and reads
unconditionally.
In fact the Linux KNFS server too assumes the NFS client would have
done the permission check.
Change-Id: I33e5de8911a87881f9341b8b92574780c2dfbeba
BUG: 3388
Reviewed-on: http://review.gluster.com/208
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 1f6e2ffc4bf4b12d55def09cfdc1459942e267e0
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Aug 9 12:30:19 2011 +0530
Change Copyright current year
Change-Id: I2d10f2be44f518f496427f257988f1858e888084
BUG: 3348
Reviewed-on: http://review.gluster.com/200
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 30428eabef85c7ada43b4f08f6f8494a697eee47
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 9 11:37:38 2011 +0530
fix build issues in Mac OS X (10.6)
Change-Id: Ifc6f156441f6545d579c3fac2fffca36fb395951
BUG: 3354
Reviewed-on: http://review.gluster.com/196
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit fd3c234901c1ca21e6ca2913db26639cf38e275e
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Aug 8 16:54:12 2011 +0530
fuse-resolve: prevent linking of inodes of different inode-table
This can happen in deep_resolve_cbk, which happens after a graph
switch. Root cause was because the graph change happened while
a FOP was in transit and by the time the call came back, the active
translator of fuse is now changed.
Fix is to make sure the resolve operation happens on a given
inode table, instead of taking the latest graph of fuse for
each operation
Change-Id: Idd6e2d5c2d5fc5d571f7a1fbc174e210babf8a2b
BUG: 3355
Reviewed-on: http://review.gluster.com/195
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 2fa13ddea7e7e426ac1d8826a7553b5f5be5ae38
Author: krishna <krishna@gluster.com>
Date: Thu Aug 4 15:51:28 2011 +0530
pass xlator pointer to rpcsvc_init() so that it can init svc->mydata to xlator
Change-Id: Icfd95cc67400c16a951d6a9f922fbdc07f40c5b6
BUG: 3314
Reviewed-on: http://review.gluster.com/180
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 3714843a30ec91f169aa21417eec5c8ae51e7090
Author: krishna <krishna@gluster.com>
Date: Fri Aug 5 15:25:16 2011 +0530
NFS server: allow clients to connect from insecure (>1024) ports and support for both rpc-auth-allow-insecure and rpc-auth.ports.insecure
Change-Id: I4e3fbfe37d6d3e8443d5b7b79faf6e364fdb87be
BUG: 3296
Reviewed-on: http://review.gluster.com/178
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 9211ea7ae65918b6fbcf526af37f939da32be04b
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Aug 8 10:47:53 2011 +0530
Changes to EXCEPTIONS and included EXCEPTIONS in packaging
Change-Id: I6c5c1536016489bf6b981356942901f69862393a
Reviewed-on: http://review.gluster.com/188
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 7559dc046d78914aef36ff10b72006a63066cba7
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Aug 6 14:00:03 2011 +0530
LICENSE: s/GNU Affero General Public/GNU General Public/
Change-Id: I3914467611e573cccee0d22df93920cf1b2eb79f
BUG: 3348
Reviewed-on: http://review.gluster.com/182
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 97dbded5e4f32b72ad7369d68828d6cce4972c24
Author: Anand Avati <avati@gluster.com>
Date: Sat Aug 6 18:00:49 2011 +0530
cluster/dht: clear local->cached_subvol when switching to do_fresh_lookup
The presence of local->cached_subvol makes dht_lookup_everywhere_done behave
as though it was a lookup on a file where linkfile needs to be recreated. In
a fresh lookup, local->cached_subvol should be NULL.
Change-Id: Ie6bd6ad536def03d970526d51e20c6daeb00922b
BUG: 3317
Reviewed-on: http://review.gluster.com/187
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 72b6feb71253d64c72b11f932b10089b94f8e056
Author: Sachidananda Urs <sac@gluster.com>
Date: Thu Aug 4 16:59:52 2011 +0530
Replace mktemp(3) with mkstemp(3).
Man page states:
Some implementations follow 4.3BSD and replace XXXXXX by the current process ID
and a single letter, so that at most 26 different names can be returned. Since
on the one hand the names are easy to guess, and on the other hand there is a
race between testing whether the name exists and opening the file, every use of
mktemp() is a security risk. The race is avoided by mkstemp(3).
Change-Id: Ida95403b55024ecd07ef811a0835e01a9a7f092b
BUG: 3331
Reviewed-on: http://review.gluster.com/163
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 81a67c46d27d60919d1b199db1d2c9f6fb9772c0
Author: Junaid <junaid@gluster.com>
Date: Thu Aug 4 15:47:15 2011 +0530
features/marker-quota: Performance improvement.
With this patch new transactions will not be triggered if an updation is
already in progress on that inode.
Change-Id: I587385498c4b2af8bd9624ca41c60742c5ef2485
BUG: 2988
Reviewed-on: http://review.gluster.com/76
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
commit 75313b0f11b8be3992ea5e9086326d19ed7efc70
Author: Anand Avati <avati@gluster.com>
Date: Fri Aug 5 14:52:01 2011 +0530
save even more trees
make the build even more quiet.
make anush even more happy by saving even more trees.
Change-Id: I301aba34e4470805114989650a13f9fe35f42d35
BUG: 3255
Reviewed-on: http://review.gluster.com/176
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit fa94d59cb1039513b383c677bf00616e18556124
Author: Anand Avati <avati@gluster.com>
Date: Fri Aug 5 14:04:43 2011 +0530
save more trees
make the build more silent
Change-Id: Ied4c87c40af4b1f1034af4a13c1153d82883751b
BUG: 3255
Reviewed-on: http://review.gluster.com/171
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit c57c199d51fa2e5e71114cd97c541032a5ce5d14
Author: Louis Zuckerman <me@louiszuckerman.com>
Date: Fri Jul 29 18:03:41 2011 -0400
Provides an upstart job for glusterd on Ubuntu, solving Bug 3282
Mounting from localhost in fstab fails at boot on ubuntu when glusterd is started by debian initscript.
A new directory, extras/Ubuntu, contains the new upstart job (glusterd.conf) and a brief README.Ubuntu file.
This makes the upstart job available to package maintainers like the SysV initscripts are in extras/init.d.
This has been tested on Ubuntu 10.10 Maverick.
Change-Id: I6ccd06054e920cd6dc45dba4eb8ab89aa30f8b47
BUG: 3282
Reviewed-on: http://review.gluster.com/126
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit dfe6566258da36bfc15121977e4d35aa390be74f
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Aug 1 16:20:12 2011 +0530
storage/posix: handle dictionary being NULL in a function
also print a warning message if dictionary is NULL, while sending a
mkdir request in distribute self-heal.
Change-Id: Ib9cac6ed1635203802f089986f8acb1ce416265d
BUG: 3215
Reviewed-on: http://review.gluster.com/136
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit 4627b5ed74840d98c9c2e0ff7ca977415736e2e3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Jul 14 01:41:48 2011 +0000
features/marker: log failures due to file not being present during quota updation transaction in DEBUG.
Change-Id: I6733586ba56ed4fdc2abbef63c38b8c491f89819
BUG: 3143
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/32
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Mohammed Junaid <junaid@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 167be4454ae9e7b6b14c7119bcae706a3901e89f
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Aug 1 17:11:59 2011 +0530
glusterd rebalance: handle a race condition while starting a rebalance
due to the race, there was a possibility of having two (or more) threads doing
glusterd_defrag_start(), which would cause different thread to access same
pointer, and at some point making it NULL, causing other threads to crash with
SEGV.
Change-Id: Id05b99dd6f33329027b8a07f1c8da5a65fd6dae9
BUG: 3295
Reviewed-on: http://review.gluster.com/138
Reviewed-by: Anand Avati <avati@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit afb179f3986ba062508325e9fdc1fa86cda948f6
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Aug 2 15:30:06 2011 +0530
DHT rename: Recreate linkfile after unlink
This is done, so that there is no gfid mismatch. Unlink the older
linkfile if it exists, and recreate it with the correct gfid.
Also removed unused rename related code.
Change-Id: Ice0cdff51db786dafb1a019f7642c7d000e8c5f3
BUG: 2522
Reviewed-on: http://review.gluster.com/142
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 7cd679bd067bc23a60f366e822d659e817270225
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Aug 3 14:09:17 2011 +0530
mgmt/glusterd: Ignore case in friend find by hostname
Change-Id: I8dabf07ebb30ec500d847c11d5c72c2d87d10239
BUG: 3309
Reviewed-on: http://review.gluster.com/145
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
commit 8fc7c940fac95b869e156c1b8209f85d88e7d9b3
Author: Sachidananda Urs <sac@gluster.com>
Date: Fri Jul 29 16:26:03 2011 +0530
Remove redundant function `cli_path_strip_trailing_slashes'.
Use cli_canonicalize_path instead, to remove trailing/duplicate slashes.
Change-Id: Ie76267a4fa9ee9986cb36039afad4dfff830d5f8
BUG: 3183
Reviewed-on: http://review.gluster.com/124
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit be10d8ad6ffa9a109a63e6f4543867b941647d67
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Jul 29 16:36:27 2011 +0530
Variable IOBUF: Use variable iobuf for cli/glusterd/glusterfsd(mgmt)
By using variable iobufs, xfer data size is no more limited to
128K (default). This helps in scaling.
Change-Id: Iab453db9223d887306d150cd6fe0b1eae9c422cc
BUG: 2472
Reviewed-on: http://review.gluster.com/13
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 81313062045c493eb3c54b61b4fdb7ee2fcc41fd
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Jul 29 16:30:36 2011 +0530
IOBUF: Bring in variable iobuf support
Rebasing Raghavendra's patch to master
Change-Id: Ie7a0c9a7b8e73cfe48c4573a5153460d5126208e
BUG: 2472
Reviewed-on: http://review.gluster.com/12
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 6ab9bcf7f539b62df41c4bf016d8707ec1728ad5
Author: Anand Avati <avati@gluster.com>
Date: Mon Aug 1 11:24:35 2011 +0530
glusterfsd: initialize sigset_t in sigwaiter
Thanks to kkeithle@redhat.com for pointing out.
Change-Id: I8167ffffddbdbc3dc09f7474bd834dbf4a49db9b
BUG: 3280
Reviewed-on: http://review.gluster.com/129
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 02ab8a859cf99fd75375bce20fa4b23c9c16563e
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Jul 13 00:52:14 2011 +0200
gsyncd: do some basic sanitization on logs
- exceptions raised by us will be logged as single-line error messages
(full stack strace is shown only at DEBUG loglevel)
- common/well understood exceptions are mapped to "user-parsable" error logs
Change-Id: I75f1fb848483372364b2093878d9cfed576c9739
BUG: 2778
Reviewed-on: http://review.gluster.com/125
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 837016c0cf0161322a7951ae53498749ab0b9e8a
Author: krishna <krishna@gluster.com>
Date: Wed Jul 27 18:16:59 2011 +0530
RPC unify code change
Change-Id: Ibe18a2a63fd023ac57652c4dfc8ac8a69d983b83
BUG: 3112
Signed-off-by: krishna <krishna@gluster.com>
Reviewed-on: http://review.gluster.com/116
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit e173b2214b3ec9654035d3b2855d734df157a54b
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jul 12 03:38:01 2011 +0200
geo-rep: minor fixes
Change-Id: I5c5211858bdb2bd28324818362d95edd97f94207
BUG: 2778
Reviewed-on: http://review.gluster.com/81
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushik BV <kaushikbv@gluster.com>
commit 91c39ab8f0622ae44f6c0f9479717c2632a3a8de
Author: Rajesh <rajesh@gluster.com>
Date: Fri Jul 29 13:18:20 2011 +0530
cli: Improve message in gluster top
Removed "volume top successful" message.
If top fails,"volume top unsuccessful" is displayed.
If errstr is set, it is displayed.
"No entries in list" messages deleted.
Change-Id: I8ed35ea7db365b7af6b10833672fcab0e4e8751d
BUG: 2722
Reviewed-on: http://review.gluster.com/121
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit dfba0deb3636c7dea26f21f41cc596fc3145dc4a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jul 19 15:09:13 2011 +0530
performance/io-cache: hold lock on ioc_inode whereever a page is being accessed/modified
Change-Id: Ifc435c2e289b2a8ceeed2a091e555953af179936
BUG: 2939
Reviewed-on: http://review.gluster.com/21
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 984773ccc484fe86c943faacbe19a56000b8c853
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Jul 15 01:54:31 2011 +0000
performance/quick-read: Handle unwinding of frame corresponding to read fop properly, while validating cache.
- there was a possibility of double unwind in case of errors.
- use a new frame to do open in fd-based fops.
In case of errors, qr_resume_pending_ops will be called to resume all the
fops waiting on open. Hence if we use frame corresponding to fop (without
creating a new one), there is a possibility of frame being freed by the
time open would've returned to quick-read.
Change-Id: Ie4cc19907f9d6362860bdb984779c8f4cf822332
BUG: 3168
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/34
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 6684e9f8634fe7223fe39ec5fc7d0b36bdcd82d5
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Jul 26 16:35:10 2011 +0530
IO-threads: Support for loading io-threads xlator on client side
New set option performance.client-io-threads added to enable/disable it.
Default behavior is io-threads is off on client side
Loaded only on fuse volume below io-stats.
Change-Id: I13aea9a564d5270901c3c356fa6bede836c6a66d
BUG: 3122
Reviewed-on: http://review.gluster.com/105
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 8c28abf42ff4a78433621fada8b680f67a5c94c6
Author: Junaid <junaid@gluster.com>
Date: Mon Jul 25 14:59:25 2011 +0530
features/marker-quota: Perform removexattr with frame uid and gid set to root.
Change-Id: Iabd8ff835c76d828e4af50ce4941d2ff86797eee
BUG: 3194
Reviewed-on: http://review.gluster.com/98
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
commit d327942c7ac8f94231a15d7eafc8464936dbff9f
Author: Junaid <junaid@gluster.com>
Date: Tue Jul 19 11:26:43 2011 +0530
mgmt/glusterd: Read the contents of vol-info file into a dynamically alloced string.
Change-Id: I06173a4cf22e12bc543f8ff2d151078333b500e1
BUG: 3154
Reviewed-on: http://review.gluster.com/8
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pavan T C <tcp@gluster.com>
commit 506e5889c3509ae4a6a69014a733e5e028a22bb7
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 22 15:23:32 2011 +0530
glusterfsd-mgmt: initialize ctx->mgmt before calling rpc_clnt_start()
this is required because if 'CONNECT' event comes before the clnt_start()
function ends, we may loose the event if it is not initialized.
Thanks to Jeff Darcy <jdarcy@redhat.com> for pointing it out
Change-Id: Iebbd651b7563265800f41922367ca133fbbf4fc3
BUG: 3207
Reviewed-on: http://review.gluster.com/77
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 6e73beae171816107c11d653cba092576e517d7d
Author: shishir <shishirng@gluster.com>
Date: Wed Jul 27 15:03:40 2011 +0530
Stripe_readdirp: Fix race in wind/unwind which led to crash
Scenario - The race window exists when before we wind to a stat call
in readdirp_cbk, whereas stats have returned to cbk. We would free up
local, which leads to a crash.
Fix - We assume all entries to be regular files, and set the wind_count
as a multiple of entries * subvol (stat calls). When we encounter a non
regular file, we decrement the windcount accordingly (subvol times). If
the last entry happens to be a non-regular file, and all stat calls have
wound back, we unwind from here itself.
Change-Id: Ia8e225ef557cbe1fedb9b72de9bd9fa61f371a24
BUG: 3257
Reviewed-on: http://review.gluster.com/115
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 7b5d48b3fa0e2468bcb85ffb73a0e00d7ec3618f
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jul 12 22:18:58 2011 +0200
gsyncd: exit in slave when RePCe session came to an end
Change-Id: I4317e60fce3280c45dbcc4a5f233a4344aba9500
BUG: 2778
Reviewed-on: http://review.gluster.com/83
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit bf9e184408bc01f5ef7a3658b6557708022961f3
Author: shishir <shishirng@gluster.com>
Date: Tue Jul 26 12:56:54 2011 +0530
NFS: Implement nfs_forget call
Make sure the inode_ctx is deleted
nfs_release is not needed, as __nfs3_fdcache_remove_entry cleans up
the ctx
Change-Id: I690efa1eb1d4cd39cee258bb29692cc58ab9c380
BUG: 3250
Reviewed-on: http://review.gluster.com/103
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shehjar Tikoo <shehjart@gluster.com>
commit bc49f31bddfe867c30a7ff7558533eeb574a3da0
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jul 12 21:59:24 2011 +0200
gsyncd: log exit properly
Change-Id: Iedd8c0ce9dec2d8dcb01e0e5b409cb53185b1716
BUG: 2778
Reviewed-on: http://review.gluster.com/82
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushik BV <kaushikbv@gluster.com>
commit 1a14165316e42d3567f3f087457df4ff7715fc2a
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Jul 11 14:57:18 2011 +0200
geo-rep: compactify logging
Change-Id: I19f6cf539289062b39e3c0f73fa88f4ff9488349
BUG: 2778
Reviewed-on: http://review.gluster.com/80
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushik BV <kaushikbv@gluster.com>
commit 9bbf82c31c94bf28e6d82da424bad1e106f1bd6e
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Jul 25 15:31:21 2011 +0530
libglusterfs: Bring in os_daemon_* routines to replace modified FreeBSD code
Change-Id: I41f4635b1b75adb6d22e2e325b99941f8d7a0b42
BUG: 3206
Reviewed-on: http://review.gluster.com/100
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 2313283a706a3464abe666f8772bc8de09b478d1
Author: Junaid <junaid@gluster.com>
Date: Thu Jul 21 23:51:45 2011 +0530
features/marker-quota: Fix some random memory leaks.
Change-Id: I1b01adf1d0ecf494f960d125f2bdcc9c10137115
BUG: 3169
Reviewed-on: http://review.gluster.com/75
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-by: Raghavendra G <raghavendra@gluster.com>
commit 9ffc3f6aba11f0a083aeb422a5eec2954b301101
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jul 26 17:23:27 2011 +0300
save the trees
Change-Id: I394621c76a95ed596aedcd45030d80a79de30acf
BUG: 3255
Reviewed-on: http://review.gluster.com/108
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit e4ea220cd346a100cad1abe088fe801f7a1968be
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 27 14:36:56 2011 +0530
rpc: in client connection init(), return the proper error code
without the proper error code, rpc won't know if transport is successfully
loaded or not.
Change-Id: Idc3ad56d2f47cf1e81ba39f90a7f7b47305d7d9a
BUG: 3260
Reviewed-on: http://review.gluster.com/112
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 851120ff270b74631d36d602e3d29dc531610c07
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Jul 6 14:10:25 2011 +0530
glusterd: handle replace-brick in paused state.
This change ensures that glusterd retains 'state' information
of an ongoing replace brick operation even if it went down midway.
Change-Id: I697c2f27a96b3200c7865bd1d3a1de9692ce0da1
BUG: 3252
Reviewed-on: http://review.gluster.com/6
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 54ad10b314582aec978cbecf4b285e0284058a5b
Author: Gaurav <gaurav@gluster.com>
Date: Tue Jul 26 11:34:10 2011 +0530
Glusterd: Remove dependency on AI_ADDRCONFIG for AF_UNSPEC
Change-Id: I0a22b2cc5a0ea1a57633fddabad54aca7b3d4e86
BUG: 2456
Reviewed-on: http://review.gluster.com/102
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
commit 06705324252ebc10dc610989f44c744c1f72c1bc
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jul 14 16:17:57 2011 +0530
cluster/distribute: while fixing layout, consider ENOSPC errors
in case of layout 'creation', layout->err == ENOSPC should be ignored
where as, while layout 'fixing' we should consider what was already
present in the layout.
Change-Id: Ifb613b41065813c9f1202e65e94b4b0282766d11
BUG: 2258
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/15
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit f33f8fb070bce03bcc594484e720cc4e81f42203
Author: Rajesh <rajesh@gluster.com>
Date: Tue Jul 19 15:57:30 2011 +0530
rpc-transport/socket: avoid logging socket read fails
An option, transport.socket.read-fail-log was added in glusterd.
This can also be added to any translator which uses socket.c.
A gf_boolean_t flag(read_fail_log) is added in socket_private_t.
Using this, logging of socket read failures can be controlled.
The options is set to 'off' in glusterd.vol by default.
Change-Id: I85cf4afc1f534f5f51018449d5d84baef18fce23
BUG: 3156
Reviewed-on: http://review.gluster.com/22
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 2be31529529e16142bc15cad3ce58a0d2c377d40
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 22 03:45:34 2011 +0530
cluster/dht: dht_rename() - handle GFID situations
In the pre-GFID era, the linkfile of the destination file could be reused
the linkfile for the renamed file when dst_cached == src_cached.
This patch handles this situation and reverts the previous (wrong) fix.
Change-Id: Iba57b5eb91cf8b1fb40e74f6399cdf99b8b00410
BUG: 2464
Reviewed-on: http://review.gluster.com/90
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
commit 6c34396bb5c4898710aae3de394ade34b0306ea0
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Jul 13 09:21:55 2011 +0000
glusterd: Add bind-insecure xlator-option for glusterd
This is required if the number of connections from the glusterd
increases.
Change-Id: Iff78773f593a8bfae13ec9eec52c5a67ea936ef2
BUG: 3142
Signed-off-by: shishir gowda <shishirng@gluster.com>
Reviewed-on: http://review.gluster.com/11
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pavan T C <tcp@gluster.com>
commit 763703f6eed57436ef92136a4130b0791b4713dc
Author: Vishwanath S Bhat <vishwanath@gluster.com>
Date: Thu Jul 21 15:19:14 2011 +0530
glusterd - Removed hardcoding of transport type in replace-brick.
Replace-brick didn't support transport types other than tcp.
Test case: replace-brick should work with tcp and rdma.
Change-Id: If33f108b70247d81791d25a1a05247f49847b4d7
BUG: 3092
Reviewed-on: http://review.gluster.com/72
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krishnan Parthasarathi <kp@gluster.com>
commit 33bcaf41c6da90aa213fcd061c81d1df5924832b
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Jul 23 06:03:18 2011 +0200
gerrit: add a dry-run mode to rfc script
With DRY_RUN=1, rfc.sh will not perform the git push just display
the push command. This can be useful if one wants to give a final
review for the submitted change list (check for typos, misplaced bug
id-s) or if one is offline.
Change-Id: I90e2016ba78e2a0ecf37044b3db0277a25914f77
BUG: 3234
Reviewed-on: http://review.gluster.com/87
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 2bb4e0b2f62df1d0759f52a7595dee1f24eb6d16
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Jul 23 05:50:53 2011 +0200
gerrit: some fixes for the rfc script
In rebase_changes():
- Using "--all" for git fetch is bogus: the scope of this quantification is not
over the tracked refs of the upsteam repo (which we do want, but that kind
of universal quantification is already implied by the notion of "tracking"),
but over the set of all the registered remotes, which is an annoying side effect.
- $EDITOR is weaker than the git configuration settings. For the purpose of the
script, we need to override any kind of setting, and that can be done
via $GIT_EDITOR.
Cf. git-fetch(1), git-commit(1).
Change-Id: Ia91ee5c4d42dce9248f26f7697528e3c97355871
BUG: 3234
Reviewed-on: http://review.gluster.com/86
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 06c361e2757eb233bac79f4a5fd2cc8debfbaa82
Author: Kaushal M <kaushal@gluster.com>
Date: Tue Jul 19 09:05:54 2011 +0530
glusterfsd: check for process mode before performing mount
create_fuse_mount() now checks if it is a client process before performing
mount. If not a client process, it returns an error.
Added changes suggested
Change-Id: If8548ad60d345bb8cd09686ceed0d83522799761
BUG: 2469
Reviewed-on: http://review.gluster.com/5
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 3b15b6b6d90f819af4488a21590e6c497502a114
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Jul 20 12:21:12 2011 +0530
debug/io-stats: allow log-level to be set to INFO
Change-Id: Ieba6591b0641dcb7dad724c1d8199dc5e91b6bfd
BUG: 3198
Reviewed-on: http://review.gluster.com/43
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 6b0c5082b920679f1c774cd6affe3f9c1d7f2fc1
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Jul 20 12:35:14 2011 +0530
debug/io-stats: print the time at which maximum fds were open in gluster top
Change-Id: I257bc29945d5acf8fb316f396fb011a2ab652d7a
BUG: 3076
Reviewed-on: http://review.gluster.com/54
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shishir Gowda <shishirng@gluster.com>
commit f9129e25d669bd7e64d48ac1e7ffc956604a40ab
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Jul 20 14:53:04 2011 +0530
Top/Profile: Report error when all bricks are down on volume
Profile - If all bricks are down, report errror.
Top - If all bricks or the specified brick is down, report error.
Change-Id: I39d4acd631b481233ab2e9f66c8f4160caef5762
BUG: 2600
Reviewed-on: http://review.gluster.com/63
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 5f8ee5c31d71aeeac0606230b6235c146b9c69aa
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 19 21:08:14 2011 +0530
glusterd rebalance: use lstat() instead of stat()
so the symlinks pointing to directories are not considered
as directories themself and the control flows outside
gluster's scope
Change-Id: Iae910ce6c68886d34ae6e5efe46062481b40cd25
BUG: 3191
Reviewed-on: http://review.gluster.com/30
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
commit 3904f29ee69f4c7d81c7b4bfae613267f26fc9be
Author: Kaushal M <kaushal@gluster.com>
Date: Tue Jul 19 14:36:13 2011 +0530
cli: modifications to "profile info" output
Units are now shown for the latencies and duration
Changed some text to be more meaningful
Change-Id: I1891d6ac541421606dda30ed10f9b40b21e2fa52
BUG: 3028
Reviewed-on: http://review.gluster.com/18
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vikas Gorur <vikas.gluster@gmail.com>
commit 3204a6851b35e4cec8019727b900da1f11782497
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jul 18 17:13:54 2011 +0530
news: note the move to gerrit
Review changes incorporated
Change-Id: I3d19a68ea22873a5fdd1a3cacea1ba37bf8dbd0f
BUG: 1
commit a955a622f58e9c99f5383c62f101ee71530e60ad
Author: Anand Avati <avati@gluster.com>
Date: Mon Jul 18 16:06:59 2011 +0530
s/Patchwork/Gerrit/
Change-Id: I3d2e0c081cce5c69a6a168ddd0d850cdba84f53e
commit 527ebcbd9d5f98f706a1f23199b506aff5b15fda
Author: Anand Avati <avati@gluster.com>
Date: Mon Jul 18 15:47:05 2011 +0530
fixed URL in README
Change-Id: I2ce02b67ee844119f854a0a2e83b5ebeb036801a
BUG: 1
commit 74d125429db4238affb0517844690aacfcc704ca
Author: Anand Avati <avati@gluster.com>
Date: Mon Jul 18 14:54:25 2011 +0530
Fixed URL in README
Change-Id: I134e8d57b188025a115fcfc363009bb3893676a1
BUG: 1
commit 8479d2d03caf502eefc2964ac8e1216ba0df6514
Author: Sachidananda <sac@gluster.com>
Date: Sun Jul 17 08:10:29 2011 +0000
Strip extra `/' from filenames.
While peforming replace-brick, delete-brick, remove-brick... and related
operations resolve extra slashes as single path separator. i.e treat /foo//bar//
as /foo/bar.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3183 (When creating volumes brick paths are not handled properly.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3183
commit c30f097118914f9fe4863592e3a166382e8d437e
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Apr 11 03:13:34 2011 +0000
mgmt/glusterd: allow add brick in pure replicate setup
Currently in pure replicate if the replica count is 4 and there are
4 bricks, then suppose 3 bricks are removed then add brick works only
if 3 bricks are provided. Providing lesser bricks fails.
This patch fixes that scenario.
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1574 ([glusterfs-3.1.0qa18]: add-brick to a replicate volume fails if a brick is removed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1574
commit aef691792ac20276593a6013e07eaf95f057d9f9
Author: Sachidananda <sac@gluster.com>
Date: Sat Jul 16 12:54:00 2011 +0000
Canonicalize path names while creating volumes.
When a volume is created resolve symbolic links, delete duplicate slashes in the
path name.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3183 (When creating volumes brick paths are not handled properly.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3183
commit c2eff19605fb9f7095b03997080efb9a0be49745
Author: Pranith K <pranithk@gluster.com>
Date: Sat Jul 16 08:20:11 2011 +0000
PUMP: set pump lk_owner,pid to frame->root
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3182 (Afr self-heal should happen with out big lock)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3182
commit e73b3d85ad4db905e27195e8ddacb6b132b21c23
Author: Pranith K <pranithk@gluster.com>
Date: Sat Jul 16 08:19:47 2011 +0000
cluster/afr: Don't depend on fuse lk_owner for inodelks
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3182 (Afr self-heal should happen with out big lock)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3182
commit 60046dbfc78d46ecda3ebf670e24f6cfa5dc4f4a
Author: Pranith K <pranithk@gluster.com>
Date: Thu Jul 14 06:31:47 2011 +0000
storage/posix: Remove the interim fix that handles the gfid race
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2745 (failure to detect split brain)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2745
commit 5edcba7a746ef76e2f00a0e0f50eb824216c8fcc
Author: Pranith K <pranithk@gluster.com>
Date: Thu Jul 14 06:31:33 2011 +0000
storage/posix: Succeed lookup even if there is no gfid on the file
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2745 (failure to detect split brain)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2745
commit a23ec7e8f237b7f445d9d0573843c1031a9137c7
Author: Pranith K <pranithk@gluster.com>
Date: Thu Jul 14 06:31:08 2011 +0000
cluster/afr: Fix conflict files and gfid self-heal
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2745 (failure to detect split brain)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2745
commit 8b7602b93d4fad769bbff2278deabf7116b8a8b3
Author: Pranith K <pranithk@gluster.com>
Date: Thu Jul 14 06:30:40 2011 +0000
cluster/afr: Detect conflict/gfid self-heals
Added some helper functions that can be reused
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2745 (failure to detect split brain)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2745
commit 2d16fae39395ce7842aa733402c194646f099c8c
Author: Pranith K <pranithk@gluster.com>
Date: Thu Jul 14 06:30:20 2011 +0000
cluster/afr: make expunge/impunge re-usable
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2745 (failure to detect split brain)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2745
commit 33c8705394d5dde7309d3a75bb950f8e36ed82ca
Author: Pranith K <pranithk@gluster.com>
Date: Thu Jul 14 08:07:46 2011 +0000
cluster/afr: Choose next call child from fresh-children for inode-read-fops
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2840 (files not getting self-healed when the first child goes down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2840
commit 9292aa0fd3203f153e203e66f67e456073545da9
Author: Pranith K <pranithk@gluster.com>
Date: Thu Jul 14 08:07:04 2011 +0000
cluster/afr: Add fresh children along with read-child to inode context
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2840 (files not getting self-healed when the first child goes down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2840
commit a027194370229e37975982fdbd416cdb9a602640
Author: Pranith K <pranithk@gluster.com>
Date: Mon Jun 27 03:10:23 2011 +0000
cluster/afr: Move afr local alloc functions from header files to sources
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2840 (files not getting self-healed when the first child goes down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2840
commit 5024f38dc589feffcc6705a45003a6ef48399189
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Jul 15 01:22:51 2011 +0000
io-threads: Initialize mutex and cond
Thanks to Emmanuel Dreyfus for sending out the fix.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3170 (Uninitialized mutex and cond in io-threads)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3170
commit 0b49d46a7d3d899233cae379aaa869927ebf5afe
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 15 01:05:16 2011 +0000
posix: perform readdir filling in locked region
When two application threads share an open dir fd (DIR *) and issue
readdirs, storage/posix will receive separate readdir fops in separate
threads in parallel. This has two-fold issues
1. In the following pair of operations -
entry = readdir(dir)
and
strcpy (gf_dirent->name, entry->d_name)
@entry is a static buffer in libc which can get reused by another thread
to get filled with a longer name. This can cause the second operation
to overflow the buffer as the allocation was for the smaller name.
2. In the following pair of operations -
seekdir (dir, offset)
and
entry = readdir(dir)
If two threads are executing these sequence in parallel in separate
threads, then one of them will end up reading wrong/unexpected entries.
It would be sufficient to fix 1. by using readdir_r but that still keeps
the second race open. Hence the patch moves all the set of operations to a
locked region which solves both races.
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3171 (Crash in server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3171
commit 1aefb51071c879368ec644cdf73598663bb579ba
Author: Gaurav <gaurav@gluster.com>
Date: Mon Jun 20 07:59:27 2011 +0000
Glusterd: IPV6 support for glusterfs.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2456 (IPv6 support for glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2456
commit 0009d976b4cc60fd5fe071ea5d6c0276973f36ea
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 13 02:08:05 2011 +0000
cluster/stripe: send the xattr keys with create/mknod itself.
so stripe is more acl friendly
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3160 ([818f8c87d56bc46d0d0903275699351b66f17e57] Posix compliance test hangs during link tests in distributed-stripe.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3160
commit ae38cce16afa547af35ff30208b1f402233347ff
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 12 05:20:10 2011 +0000
storage/posix: make sure we are starting on a genuine backend
also do the check in 'glusterd' to let the user know of the
problems (if any) during the volume create/start time itself.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3065 (make sure the export directories are not re-used as part of another volume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3065
commit 484dbb58c1ace51c4a3c8b021214bbaae20e6c86
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 1 04:42:14 2011 +0000
glusterd-rebalance: utilize distribute's internal rebalance feature
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3070 (After 'rebalance', the gfid of the file gets changed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3070
commit 2025618e4c9037c4151a942d77a7c0ab225477fd
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 1 04:41:54 2011 +0000
distribute: bring in feature to do rebalance from inside
do the 'rebalance' on a file with 'setxattr()' with
'distribute.migrate-data' key. the valid 'value' is "force" or
anything else.
current implementation of 'rebalance' is same as 'glusterd-rebalance',
and hence comes with limitation of not rebalancing hardlinks, non-regular
files, and files with open-fds.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3070 (After 'rebalance', the gfid of the file gets changed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3070
commit dd532c8870117a57275258c75b55f3af4ed0045c
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 1 04:40:05 2011 +0000
cluster/distribute: bring in directory-spread-count option
global spread count option is given through volume file
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2257 (enhance distribute to control the spread count (ie, control the hashing range))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2257
commit 35a6e48a64ae64d76216212c832cc6a9822b3f2f
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 1 04:39:41 2011 +0000
cluster/distribute: handle layout overlaps while giving a new fix
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2258 (enhance gluster volume rebalance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2258
commit 2ad7fbc43a59a907c71fc454d107cc53f28e9a6a
Author: Junaid <junaid@gluster.com>
Date: Sun Jun 26 09:35:21 2011 +0000
Revert "features/marker-quota: hold lock on dirty inode's parent while healing a dirty inode."
This reverts commit cd2518b4ab627471db74d7f4a473416f318754db.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit d814357089bc2e6c178db42c5cabfff8ea0d3ff5
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Jul 13 04:33:43 2011 +0000
mgmt/Glusterd: Fix build warning
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit 4e1b1040bedfd4215999597dc7817a40f9a7d8ba
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Jul 13 04:33:42 2011 +0000
io-stats: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit 94f0652858b14adb6bde28e4f61f86e38aee4e3a
Author: Kaushal M <kaushal@gluster.com>
Date: Wed Jul 13 04:11:53 2011 +0000
Changed error message displayed and logged, on rebalance failure
Signed-off-by: Kaushal M <kaushal@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3106 (Rebalance start failure message is not appropriate)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3106
commit a14492889d1995a134ebbedbc3afe1cf3750cf24
Author: Pavan <tcp@gluster.com>
Date: Wed Jul 13 03:34:18 2011 +0000
nfsrpc: Re-order NFS auth array contents
Some NFS client implementations can default to AUTH_NULL given a certain order
of auth_array in MOUNT reply. We re-order it here to make sure that such
clients (Example - 2.6.26), do not have such security loop holes.
Signed-off-by: Pavan T C <tcp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3144 (permissions given in fuse mount don't have effect in nfs mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3144
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3144 (permissions given in fuse mount don't have effect in nfs mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3144
commit 615fd0392c14995279597cf35cda68b9395f8e1e
Author: Anand Avati <avati@gluster.com>
Date: Wed Jul 13 03:34:02 2011 +0000
posix-acl: perform access checks on read/write/truncate for NFS calls
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
commit 176944e69e5afdfee20ea74b080b4821b65f8a4e
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Jul 13 03:33:47 2011 +0000
access-control: Handle F_OK in perm check, and O_APPEND, O_TRUNC in open
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3057 (acl permissions don't work on nfs mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
BUG: 3057 (acl permissions don't work on nfs mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
commit 47b5bd4f05f2ace2fce5efe774dd90c490f0b3f1
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Jul 13 03:33:26 2011 +0000
DHT access: For nfs calls, op_ret is always 0, and mode is op_errno
Return the values received from the subvol
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3057 (acl permissions don't work on nfs mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
BUG: 3057 (acl permissions don't work on nfs mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
commit cf18f093463bb7ed147cccfe82c128f84de2911f
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Jul 13 03:32:53 2011 +0000
NFS access control list: Decode the NFS requests into mode format
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 3057 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3057 (acl permissions don't work on nfs mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
commit 165ff6c76da0d5f2c2f24acbf571dd80652f7e5f
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Jul 13 03:32:41 2011 +0000
access-control: NFS access control expects a return of valid mode
The permission check is same as that of posix. We break the requests
into single checks, aggregate all the valid modes and return in reply.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 3057 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3057 (acl permissions don't work on nfs mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
commit 5fe2d850c84699c3a3791b08a5d4fbcd8f554599
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Jul 13 03:32:02 2011 +0000
access-control: Save group permissions returned from backend
The backend permissions returned in stat for group is already masked
value. Use the xattr value
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 3102 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3102
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3102 (Read calls go ahead even when the group has no permissions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3102
commit 02991ee7ad2e347b407ef01bfe8e795cd22c0d48
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Jul 13 03:31:47 2011 +0000
access-control: Return mode part of NFS access control request
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 3057 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3057 (acl permissions don't work on nfs mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
commit 324a0ca93e703aaeb8e297161e17c1ad6bf24b81
Author: Rahul <rahul@gluster.com>
Date: Tue Jul 12 13:47:51 2011 +0000
Check type for a value greater than Distribute and not for stripe
Signed-off-by: Rahul <rahul@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3161 ([818f8c87d56bc46d0d0903275699351b66f17e57] Volume type incorrect.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3161
commit be473a9d490e4527029e109ae03d7832e2e0da1e
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 13 00:37:25 2011 +0000
storage/posix: set all keys present in 'params' dict while creating an entry
so, there is no need to do a 'setxattr()' after entry creation, which could now
fail due to ACL on server side.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3164 (set xattr keys while entry creation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3164
commit cd78f392c387d01d45c5a19245deab82004c4942
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jul 12 05:33:39 2011 +0000
protocol/client: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit 4bffff12902b3e8a55247cf58740ea8785fa309c
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jul 12 05:33:38 2011 +0000
write-behind: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit 9be250a52cc6fd6fcfa51da1532e22f7b402236a
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jul 12 05:33:37 2011 +0000
quick-read: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit 72eb1a3972be2c93e9f582f1679ed6c37c8c82fc
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jul 12 05:33:36 2011 +0000
io-threads: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit 8a93ceaf826aafe3e8b237ce36d77a8ba60c21c4
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jul 12 05:33:35 2011 +0000
io-cache: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit 90664f4d50eba107f983b425daf1c3f350e617e5
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jul 12 05:33:34 2011 +0000
quota: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit a67116abb9e9a9f65658a10a2d8173e53fa3cece
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jul 12 05:33:32 2011 +0000
stripe: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit e9af1cbeffb5847625c52aaa78031fd7f4cc1b7f
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jul 12 05:33:31 2011 +0000
dht: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit 22e7c418fdc09ca765b25583087da4c4ef37e297
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jul 12 05:33:30 2011 +0000
afr: changes in volume_options to assist volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit 9d0b0db0eaef90c9fe8b78b3da657d453473a5f9
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jul 12 05:33:29 2011 +0000
mgmt/Glusterd: Implementation volume set help/help-xml
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2041 (volume set help option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2041
commit fa4d0fafe9ddadf9022df656b1b927b71ba7b965
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Jul 4 06:32:32 2011 +0000
nfs: Change NFS3 access op to use access fop
This change is needed so that we have a uniform dependence on
posix-acl for permission checks as well as ACL checks.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3057 (acl permissions don't work on nfs mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3057
commit 24cbdbdaa1663ba7ee274f6b94bf5ba25b5042eb
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Jul 7 03:03:40 2011 +0000
features/locks: Do not block UNLOCKs
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 38182a7cfe50f540c142ab3bf2fb088a0cb461d0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Jul 6 08:35:14 2011 +0000
mnt/fuse: generate uuids in fuse_lookup, not in fuse_lookup_resume.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3041 ([glusterfs-3.1.5qa2]: stat gives EINVAL)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3041
commit db18a1db4fc9523df56bccd6c6770912e1f2ffed
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Jul 4 02:27:06 2011 +0000
glusterd: check replica_count for 0 before using it for volume creation in stripe replicate volume
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3123 ([a7cdaf3de307c96cb55219a0743962ee1e1fc955]: glusterd crashed when started)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3123
commit bf4f501fd0e5949f2efa49a71ffd93ec35b641a0
Author: Venky Shankar <venky@gluster.com>
Date: Fri Jul 1 00:18:53 2011 +0000
afr/stripe: collect pathinfo xattrs from all childs
Signed-off-by: Venky Shankar <venky@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3046 (getxattr for afr should returns realpath from all childs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3046
commit ade5d41b58660224d923b23e8927936e2c864db6
Author: Pranith K <pranithk@gluster.com>
Date: Fri Jun 17 07:20:08 2011 +0000
cluster/afr: Handle lookups when self-heal is off
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2586 (read child is set without checking the xattr)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2586
commit 287323928ea8c6387053a31b8bef9813727bc7e0
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 8 02:56:03 2011 +0000
mount.glusterfs: fix to handle the error cases better
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3085 (backupvolfile-server option doesn't work)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3085
commit a94391f0a300851f4746b9eb31e6cd54796d1d91
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 8 02:55:40 2011 +0000
cluster/stripe: quick-read friendly behavior in lookup
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3140 (contents of files are invalid after apply patch 7573)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3140
commit 000ad96b1e44b42e7e3b30eb4d136d131b9daba9
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 8 02:55:20 2011 +0000
cluster/stripe: cleanup and memory leak fixes
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3140 (contents of files are invalid after apply patch 7573)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3140
commit aad85a1c4c02c2ec3b78da36553df81a8071176a
Author: Krishnan P <kp@gluster.com>
Date: Tue Jul 12 02:31:05 2011 +0000
server: Reassociating 'old' conn can lead to chaos.
Since we moved to a single socket connection b/w client and server,
inherting connection state is unnecessary and can sometimes be
dangerous when clients reconnect even before the server detects
a socket error on the old connection.
Dirty detail: This reassociation results in 'ref count' not decreasing
in tandem with the connection disconnects. This results in a resource
leak.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3104 (Self-heal does not work in dis-rep!)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3104
commit 46b4e78b85be27882c49d3015003b519cc7c07b8
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 12 05:29:25 2011 +0000
cluster/distribute: send proper 'params' dictionary during linkfile creation
when the code path enters the 'subvol_filled()' case, local->params is set,
which contains the 'gfid-req' value, but the linkfile creation was not
checking for its existance.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3159 (mknod (linkfile creation) with no 'gfid-req' key)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3159
commit ba758870c7a3414d9110cf101b7518adef806f4e
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 12 05:16:46 2011 +0000
storage/posix: move the helper functions to separate file
helper functions were more than 800 lines
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3158 (Keep code more readable and clean)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3158
commit fd222c8ff187c2e3318f76d8b64160e219aa077c
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 12 05:16:32 2011 +0000
storage/posix: call 'gfid_heal()' instead of 'gfid_set()' in lookup()
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2994 ([glusterfs-3.2.1qa2]: untar and rm in parallel hangs untar)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2994
commit 2b1cd584c9849896e48d2d794be09594fd718bcb
Author: Sachidananda <sac@gluster.com>
Date: Mon Jul 11 05:37:39 2011 +0000
Fail volume creation on existing directories of a read-only file system.
Thanks to kp@ for the fix.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2609 (Error message not properly provided when trying to create a volume from a read-only source)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2609
commit b58ba957fca40dd68528273ab8abc6bc6c1cb726
Author: Krishnan P <kp@gluster.com>
Date: Tue Jul 12 01:51:17 2011 +0000
pump, afr: dict related memory fixes.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2489 (GlusterFS crashing with replace-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2489
commit 1f1abe595933f21bcd09b96273e106f79765283e
Author: Anand Avati <avati@gluster.com>
Date: Tue Jul 12 02:11:59 2011 +0000
cluster/dht: fix race between two directory renames
let the race get arbitrated at the dst_hashed subvolume.
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2522 ([glusterfs-3.1.3qa8]: rm -rf shows invalid argument)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2522
commit 70d5523f4bf5638c59a5975dbd628e95c77a46fc
Author: Anand Avati <avati@gluster.com>
Date: Tue Jul 12 02:11:42 2011 +0000
storage/posix: detect race in posix_rename()
detect a race in rename between two clients by checking for
reassigned gfid or presence of dir when not expecting.
checks not necessary for rename of files.
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2522 ([glusterfs-3.1.3qa8]: rm -rf shows invalid argument)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2522
commit ff16e1ab02ab4469fe73b8228e82010d57de4062
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Jul 7 01:33:05 2011 +0000
client-handshake: skip CHILD_DOWN notifications when client is querying port using different volume names in the presence of rdma.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3091 (rebalance fails with "transport endpoint not connected" in 3.2.1 rdma set-up)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3091
commit 3f22d87a231648eb28760e0c0b4132af3f2f4fec
Author: Junaid <junaid@gluster.com>
Date: Thu Jun 23 03:20:09 2011 +0000
debug/io-stats: Added sys-log-level option.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3044 (provide option to set syslog loglevel through CLI)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3044
commit c51dc141a6da4940b0df3f12b246554e73474238
Author: Junaid <junaid@gluster.com>
Date: Thu Jun 23 03:19:15 2011 +0000
mgmt/glusterd: Make glusterd aware of sys-log-level options.
There are two options:
* brick-sys-log-level
* client-sys-log-level
Which set the log-level on brick and client respectively. Uset
gluster volume set <volname> <brick|client>-sys-log-level value
to set the option.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3044 (provide option to set syslog loglevel through CLI)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3044
commit 0181190664c711acbcb98c7719e2f7eba6290c12
Author: Junaid <junaid@gluster.com>
Date: Wed Jun 29 03:13:56 2011 +0000
libglusterfs/logging: Added functions to set sys-log-level.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3044 (provide option to set syslog loglevel through CLI)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3044
commit ba395bdd2813360eeb18941b19c86eaa9b3603b9
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Jun 1 08:00:03 2011 +0000
quota: update limit stored in inode-ctx when limit is removed on a directory.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2971 (quota remove command doesn't remove quota on directories.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2971
commit f2d06a1cc087171b434e086d32b3f9ad69ea8fdc
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Jun 22 02:35:58 2011 +0000
fuse: fix inode-leaks in fuse_lookup_and_resume codepath.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2525 ([glusterfs-3.1.3qa8]: inode leak in rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2525
commit ee5110d417113dec92e6b41855133da51bb50584
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Jul 6 02:18:49 2011 +0000
fd: put the fd back to fd_mem_pool of inode table instead of freeing in case of failure
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3103 (memleak in inode table creation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3103
commit b16e6f846ffc4d9519f0cfe386d3ff8c5d4788d9
Author: Vishwanath <vishwanath@gluster.com>
Date: Fri Jul 1 07:39:21 2011 +0000
remove hardcoding of transport type to "tcp" while generating vol files in replace-brick
Please ingore previous patch for this. Please consider this one.
Signed-off-by: Vishwanath S Bhat <vishwanath@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
commit f9f540da8bfd5ace3a8b4a58bc50db5f434dd759
Author: Rahul <rahul@gluster.com>
Date: Fri Jul 1 05:53:10 2011 +0000
Fixes missing ".." entry in the mount point
Signed-off-by: Rahul <rahul@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3097 ([b7aeaa619b82509fbe8d187bbc1618cb319d6877] ".." entry in mount point missing.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3097
commit a5f719cadc6d042c448774fa4d26e265f9f926a8
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jun 27 07:59:52 2011 +0000
libglusterfs/syncop: add more functions
do proper 'ref's and implement 'write()' and 'ftruncate()'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3081 (synchronous operations should be enhanced)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3081
commit 83c36daccd2a499e7a60dd27cf5b77a0f00a4b3f
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Jul 5 23:08:40 2011 +0000
cli: Exit if glusterd is not operational in non-prompt modes
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3120 (Provide connection timeout between cli and glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3120
commit 912278ff62d34434b4b056896b0ead1c409f8810
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 1 17:19:39 2011 +0000
mount.glusterfs: support -o acl parameter
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
commit 8bd906bf2f7fbf3b213a78a71fa2156a541a5204
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 1 17:19:29 2011 +0000
glusterfs: add --acl command line option to load ACLs on the client side
also set the turn off filtering of ACL keys in FUSE xattr FOPs.
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
commit e95b38563a129a1fe7af2ea38065d57fb2a6025c
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 1 17:19:15 2011 +0000
access-control: superseded by posix-acl translator
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
commit 839e37628c1904db060201a8a3d303ad3b65507f
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 1 17:18:10 2011 +0000
posix-acl: implementation of POSIX ACL as a translator
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
commit 9cf2de2d42a1bf465b7e918a1615a2a1564b2efb
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 1 17:18:04 2011 +0000
storage/posix: set ACL keys during new entry/inode creations
honor "system.posix_acl_access" and "system.posix_acl_default" keys in
params dict to setxattr into the backend while creating new entry/inodes
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
commit 7be410fe744222d620d577037b86d1ee9eae5c46
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 8 03:23:08 2011 +0000
fuse: introduce "noacl" option to disable ACL checks
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
commit 94d0b6128a640b4bbb4384423743e4337e7a0cbf
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 1 17:17:11 2011 +0000
fuse: fill frame->root->groups with aux gids of the process
Pick the groups in /proc/<pid>/status from the line starting
with "Groups: " by parsing the list of integers which follow
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
commit c2bea7222d227eb3f045d871c0553143a2c2c5f6
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 1 17:17:04 2011 +0000
dht: set linkto xattr with linkfile create (mknod)
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
commit dd2e955a0d454cb525781b173091ff7a510dfb2f
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 1 17:16:50 2011 +0000
byte-order: htole*/letoh* and htobe*/betoh* for forced endian conversions
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815
commit 315ff5dfa449cc5554b1af2666640658bd1f69c3
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Jul 6 03:10:05 2011 +0000
dht disk usage: Correct free blk calculation
Use f_bavial instead of f_bfree for %free calculation
This fixes mismatch of df output wrt backend and glusterfs
where: f_bfree = /* # free blocks */
f_bavail; /* free blocks avail to non-superuser */
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3084 (Correcting percent calculation of disk space)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3084
commit 509a5b565feb38667450a3a1127e74ddd054ebe1
Author: Junaid <junaid@gluster.com>
Date: Fri Jul 1 05:17:42 2011 +0000
features/marker-quota: call stack destroy when hardlink count is not greater 1.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit a48eb57c4359592e7c7e23721810a987676a1f46
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Jul 1 00:12:35 2011 +0000
mnt/fuse: Do a pthread_cond_broadcast for both CHILD_UP and CHILD_DOWN events.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3091 (rebalance fails with "transport endpoint not connected" in 3.2.1 rdma set-up)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3091
commit eb1dc55566a78f30a2176008d58484c27f4eea9d
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Jun 30 06:59:12 2011 +0000
inode table: avoid memleak by freeing the allocated structures incase of failure
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3103 (memleak in inode table creation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3103
commit ac4290268d26598880bad5f27782c38c074e59ac
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Jun 30 03:20:31 2011 +0000
rpc-transport/rdma: call ibv_fork_init to make rdma work with fork.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3091 (rebalance fails with "transport endpoint not connected" in 3.2.1 rdma set-up)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3091
commit 16b36b0e8c25eacfb2b947bef3c389a715afb442
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Jun 30 03:20:50 2011 +0000
mount/fuse: wait till CHILD_UP event is recieved to do the first lookup.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3091 (rebalance fails with "transport endpoint not connected" in 3.2.1 rdma set-up)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3091
commit b95c9addaba018f972440588509c0a626cfd2e8e
Author: Pranith K <pranithk@gluster.com>
Date: Thu Jun 23 01:12:48 2011 +0000
cluster/afr: fix the range of the lock taken in [f]truncate
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3077 (afr [f]truncate locks wrong region in transaction)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3077
commit 2eaff35a6b079f8e5175b39f213a491f826272e9
Author: Junaid <junaid@gluster.com>
Date: Tue Jun 28 03:01:12 2011 +0000
mgmt/glusterd: return 0 when glusterd_op_get_ctx fails on other glusterd's.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3078 (Quota: list comamnd fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3078
commit 0b82158b8a2316799b506d55fce212e3b5118068
Author: Junaid <junaid@gluster.com>
Date: Thu Jun 30 00:46:20 2011 +0000
features/marker-quota: Change the log-level of gf_log to debug in quota_inodelk_cbk().
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 5cfb343c93aea243a03c086ecdd619aa2e5ba500
Author: Junaid <junaid@gluster.com>
Date: Wed Jun 29 20:41:27 2011 +0000
mgmt/glusterd: 'Quota' use quota-crawl.log to store logs of maintainence mount.
Allow to set limits even when quota is disabled.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2620 (CLI improvements in quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2620
commit 0c290ed63b0e70d5aedde51aa13e7dc55489c238
Author: Junaid <junaid@gluster.com>
Date: Wed Jun 29 20:41:17 2011 +0000
cli: 'Quota' use quota-list.log to store logs of maintainance mount.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2620 (CLI improvements in quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2620
commit 9a66fba115487731c62c0efdecb4f6c772456b0e
Author: Junaid <junaid@gluster.com>
Date: Mon Jun 20 07:11:47 2011 +0000
features/marker-quota: Skip contribution creation on root.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit 919afdc40a76e3dd5c46ec0a8c995c793aa20696
Author: Vishwanath <vishwanath@gluster.com>
Date: Thu Jun 23 05:41:39 2011 +0000
spelling corrections in glusterfs code
Signed-off-by: Vishwanath S Bhat <vishwanath@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2903 (Last spelling errors in source code)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2903
commit 7782978a43debf1716aeb9229ebfa8a0e6d3f888
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 22 23:23:06 2011 +0000
distribute: handle 'fix.layout' key in setxattr() instead of getxattr()
as 'fix.layout' command does changes to directory layout, its not a
'read/get' type of operation, and hence as per the symantics, it suits
setxattr() better
also fix a memory leak in getxattr(), where 'local' was allocated twice
in few cases
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3075 (the 'fix.layout' command should happen through 'setxattr', not getxattr().)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3075
commit 0699e41af661ca1fe31ebcd8805f9c33d12be6f7
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 23 08:07:23 2011 +0000
libglusterfs: added syncop_* functions
* implemented open,close,readv,writev,listxattr,create,unlink
* also fixed a dictionary ref issue with lookup_cbk
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3081 (synchronous operations should be enhanced)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3081
commit 2e7216a4a91664d4a2d40323b0b721a5b3baba0b
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 23 01:51:47 2011 +0000
bring in strict check on export directory being re-used for different volume
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3065 (make sure the export directories are not re-used as part of another volume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3065
commit 2e52678d48c66fe892e0cabc4b766eaf731ea2c5
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 16 23:42:53 2011 +0000
gluster volume info: fix the output of 'stripe-replicated' volumes
also fix the glusterd-store to preserve the required information
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3040 (need a way to create volumes with 'stripe+replicate' setup..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3040
commit 1e5b5a111fa9dc9fc990972160c4f5e1e88d1d43
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jun 21 04:56:41 2011 +0000
gluster volume create: option for stripe + replicate volume
So RAID01 like option is a possibility
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3040 (need a way to create volumes with 'stripe+replicate' setup..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3040
commit 4dd839117839e0fa38894bc359f14b5518526659
Author: Sachidananda <sac@gluster.com>
Date: Wed Jun 22 05:57:06 2011 +0000
Fix typos in manpages.
Thanks to: Patrick Matth?i <pmatthaei@debian.org> for patches.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2902 (Errors in manpages)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2902
commit 38a84e294b800f415e83603d505c3ea71d31a108
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Jun 22 04:24:58 2011 +0000
Stripe selfheal: Prevent spurious STACK_DESTROY call
The stack is destroyed in the cbk
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3056 ([4597929cc527f8abaf9ef9e1d5499ea416e5c7ff] Crash in client at client3_1_mknod_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3056
commit 1f909c418d9ac3bef65ea94b5f6b7fe3b479dd14
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Jun 22 02:51:50 2011 +0000
fuse: consider a lookup as revalidate even if the inode is present in new graph.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3041 ([glusterfs-3.1.5qa2]: stat gives EINVAL)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3041
commit 8e38e7d76775be4c734423d90673611578c5f90a
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Jun 21 05:07:04 2011 +0000
performance/quick-read: Perform error handling only when GF_CALLOC fails
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3011 (Uninterruptible processes writing(reading ? ) to/from glusterfs share)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3011
commit 7f488d9f57c072e26f394d52943d883600ee85e4
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Jun 21 03:22:09 2011 +0000
Stripe lookup: aggregate xattrs
stripe default setxattr works on first child. If the first cbk is
not the first child, then we were loosing the xattrs.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3066 (aggregate xattrs in stripe lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3066
commit e36016847df7f4cd87b8c742162608a076d62f54
Author: Junaid <junaid@gluster.com>
Date: Tue Jun 21 00:51:25 2011 +0000
mgmt/glusterd: Enable quota only when volume is started.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2620 (CLI improvements in quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2620
commit b7be278d5179af35e47d0d5161fe50baa5e4a9b1
Author: Gaurav <gaurav@gluster.com>
Date: Mon Jun 20 08:32:59 2011 +0000
NFS : Pass valid argument in mnt3svc_dump.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2692 (NFS server crashes on showmount -a)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2692
commit 9fbea1564fefd75df606a5481ab37c280d56c728
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Jun 20 01:46:07 2011 +0000
performance/quick-read: reset open_in_transit to zero in case of an error.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3011 (Uninterruptible processes writing(reading ? ) to/from glusterfs share)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3011
commit 5c3373841cfac6a75f2063536ce07a21706b3b47
Author: Krishnan P <kp@gluster.com>
Date: Mon Jun 20 01:01:20 2011 +0000
pump: mark pending before notify to children to avoid race in single CPU.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3050 ('replace-brick' hangs on vm's)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3050
commit abab3992b96aafe447558b3c3241421920097fd7
Author: Junaid <junaid@gluster.com>
Date: Sun Jun 19 23:41:25 2011 +0000
features/quota: Print a log when reconfigure fails.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2775 (crash in reconfigure)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2775
commit dcc1b6e8d62662a10f1b2edee4a18fbc14bd104d
Author: Krishnan P <kp@gluster.com>
Date: Mon Jun 20 00:56:10 2011 +0000
afr: bg self-heal must be off if self-heal-count=0.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3036 (self-heal problem in replace-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3036
commit 135fcb2b090c8c3e13a76258516deb5619dbc5cb
Author: Sachidananda <sac@gluster.com>
Date: Sun Jun 19 12:51:45 2011 +0000
Fix the command line log to display correct error message.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3054 (Typo in cli message)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3054
commit 310dc6b7891cccb572453f23875793a407d4ebb1
Author: Sachidananda <sac@gluster.com>
Date: Sun Jun 19 11:07:31 2011 +0000
Print error message to report missing mount point.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3053 (No proper error is shown when the mount point is not present)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3053
commit df15749a90cac03645db8a96bc4692429c001238
Author: Gaurav <gaurav@gluster.com>
Date: Thu Apr 7 01:42:33 2011 +0000
CLI : Display possible options in proper format.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2598 (Volume access option suceeds with any string value)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2598
commit 3967de464473d4aaca8082b07877dca46f748b9c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed May 11 02:42:21 2011 +0000
extras: Add quota-related debugging scripts.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit cc9c12029348b8ab6a9dea178bfe66583db4addd
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri May 27 01:17:12 2011 +0000
print the owner and the transport for the blocked locks in server statedump
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2949 (self-heal hangs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2949
commit 87bd26c072bf30bcdb1b123c811e6c622de82edc
Author: Anand Avati <avati@gluster.com>
Date: Sat Jun 18 03:53:46 2011 +0000
stack: make process state dump more debug friendly
store points of stack wind and unwind (function names) for each
frame and dump them in process state dump
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 40fdd58dc0d7fa60ee615916a4cb6fa9a462de29
Author: Junaid <junaid@gluster.com>
Date: Wed Jun 15 02:41:36 2011 +0000
cli: Print the error message sent by glusterd when quota list cmd fails.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2856 ([glusterfs-3.2]: Misleading 'quota remove' output.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2856
commit 82e0c63a988bfb659f888649ace5d2a67cec7059
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 16 07:48:22 2011 +0000
core: fill 'ia_ino' from 'ia_gfid' in 'storage/posix' to preserve same ino number
take the least significant 64bit from gfid and assign it to 'ia_ino',
hence for a given file (or directory), the 'ia_ino' number is always
same, and we need not worry about the 'itransform' in 'cluster/*'
translators.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3042 (inode number should be constant on storage)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3042
commit a6f6f11b6b965b39274d80957b0421f82c43b2c3
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Jun 10 00:34:10 2011 +0000
cluster/afr: Give proper device id for mknod
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2840 (files not getting self-healed when the first child goes down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2840
commit a2aa9e54fd2619fc9601f09175895627dbf8caa8
Author: Junaid <junaid@gluster.com>
Date: Thu Jun 16 21:57:40 2011 +0000
mgmt/glusterd: chdir into mount in second child process while crawling the fs in quota enable.
Because the management mount is waiting for glusterd's response and glusterd is
doing waitpid on the child which is trying to do chdir into mount, thus causing
a deadlock situation.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2560 (Lazy umount should be done for the maintainance mode mountpoint)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2560
commit bf2e1767d2067d96991502913f0079e3dbb203b0
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 16 06:43:12 2011 +0000
logging: fill proper domain names at places where it is missing
also changed some error messages where it was not explicit
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 58ff1ffc90fb5255777996968fd1bdd29e43400f
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 16 05:30:05 2011 +0000
gluster rebalance: handle the migration of files with 'holes'.
treat a block (512bytes) of '0' as hole too (something like 'rsync')
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2258 (enhance gluster volume rebalance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2258
commit 6072aef5214f0ba1891cebe643caf5ff95356d4e
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 16 07:39:43 2011 +0000
gluster rebalance: bring in a 'force' option
* also correct the free space available logic to check the size
without the file in migration (this considers the sparse files too)
* 'force' option will bypass the free-space check logic, hence will
cleanup all the linkfile
* 'force' option is valid only with 'migrate-data' option
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2258 (enhance gluster volume rebalance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2258
commit b7834c228083d94ae03ba6bceee3a38f7ad9ad85
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 16 04:36:46 2011 +0000
build: fixes to work on solaris
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3002 (build issues on solaris)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3002
commit 4255e03737b4ee6071004b5ab65fa22a266421e0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 23:56:01 2011 +0000
features/marker-quota: use contribution value to reduce parent's size, if the value to be subtracted is not passed as argument to reduce_parent_size.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit 487e0ab5744cef397b545c436315de5450720dcb
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 23:55:51 2011 +0000
features/marker-quota: hold lock on dirty inode's parent while healing a dirty inode.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit e1c977a2c729d20633fad7d37554083f2841d24f
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Jun 14 23:55:40 2011 +0000
features/marker-quota: hold parent inodelk during creation of xattrs on directory.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit 8865d6a4c9bb2d2061209cead812129373ee25a8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 23:55:30 2011 +0000
features/marker-quota: check for refcount being zero holding lock in quota_local_unref.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit 39e781db36b536ebe4368b75bf15158632e262b8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 23:55:21 2011 +0000
features/marker-quota: wipe parent_loc in marker_local_unref.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit 94a92fd11dfa965f7ceae75259d375de8c9ee524
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 23:55:09 2011 +0000
marker-quota/rename: use contribution values from backend instead of in-memory while reducing parent sizes during rename
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit 27db25b6024ab6f2cdc6bbea1751e1e7188845ab
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 23:55:00 2011 +0000
features/marker-quota: use mutexes while accessing contribution values.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit acfc905f8e80ddecbf5e8a28b71846da852bb196
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 23:54:47 2011 +0000
features/marker: fixes in dirty inode self-heal codepath.
- fix fd-leak of fd opened on the directory.
- don't add (instead just assign) next offset at which readdir has to be sent
to local->d_off.
- assign to local->d_off before winding lookup call to get child contribution.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit 376a90ca3ddfe5b49b6b6a407b32186ad9177960
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 23:54:36 2011 +0000
libglusterfs/call-stub: Allow unwinding of frames for rename during call_resume_unwind.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit ac7001e07e03e26dd31f6e752ac0a184476e766e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 23:54:27 2011 +0000
features/marker-quota: performance optimization.
- abort updation process if delta is zero.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit 2952ae6164b603c879ecbd7c20af83355d8d6053
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 23:54:16 2011 +0000
features/marker-quota: fixes in rename path.
- remove xattrs from newpath after rename is complete.
- hold inodelk on both parents (if they are different) before doing rename and
gather contribution values of oldpath and newpath to their parents while still
holding the locks. Use these contribution values to reduce parent sizes.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit d26cef4fce6d6e83d40db86cb1ecc3fda98a3eea
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Jun 9 00:00:10 2011 +0000
features/quota: after validation on a path, reset variable just_validated to zero before checking the size of parent.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2741 (Quota: new files not getting created even if space is available)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2741
commit d57269c69e77dd48795524d07ba8031e3575ab84
Author: Pranith K <pranithk@gluster.com>
Date: Wed Jun 15 06:17:44 2011 +0000
PUMP: perform opendir on pump xlator instead of its child
When replace-brick is performed, there is a high probability for the
directories on the source brick to not have any pending entry xattrs.
So for proper self-heal we need the force merge to kick in.
If the opendir is performed on pump xlator directory is examined and
if the entries on its children do not match then force merge is
triggered, so missing entries will be created on the sink.
Pending xattrs are set from source to sink on the files present on
source in this process. So when the lookup happens the self-heal
is triggered.
Before this fix, the code is working because the self-heal source is
decided based on what file is biggest in size which is a wrong and
removed.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2586 (read child is set without checking the xattr)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2586
commit c98061651bc6d8382e0502bd756ec432da6337a4
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jun 10 06:56:49 2011 +0000
cluster/distribute: remove the unused variable from 'conf'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3013 (error in the log file upon taking the statedump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3013
commit c0cc76a5054f3dceea488529a8a1775cd7c69c2f
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 9 00:15:59 2011 +0000
rdma: fix the excessive logs
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 6238ebbc77c797535227e399f003f290eaa65222
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 8 23:37:46 2011 +0000
build warning fixes
mainly fixes all the sockaddr related 'strict aliasing' warnings
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2550 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2550
commit 767e3b2e333470d5e60c7e44341fd243de4ec1e5
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 8 23:37:22 2011 +0000
fixing some build issues in Mac OS X
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2966 (MacOSX compile failure: duplicate symbol _k)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2966
commit 46232f1ed0564d1f1cefc3e024d8cda9d8b43bea
Author: Sachidananda <sac@gluster.com>
Date: Thu Jun 16 07:56:33 2011 +0000
Update man pages to include newer options.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2444 (keep man pages upto date with new codebase.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2444
commit 628fd1e87888eaa10177683e9a5dac96b9e6e36d
Author: Krishnan P <kp@gluster.com>
Date: Thu Jun 16 01:28:28 2011 +0000
pump: cleanup xattrs on both commit and abort path.
This change makes glusterd to send a setxattr command
for replace-brick commit operation similar to abort.
Earlier we could commit even before the 'migration'
of data was complete, with this change we fail that
operation.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3033 (Changes to replace-brick and syntask interface.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3033
commit a21014beaf5b75146e50b4e530e67b7c24d1d4b4
Author: Krishnan P <kp@gluster.com>
Date: Thu Jun 16 01:27:42 2011 +0000
glusterd: do_operation_abort and then kill dst_brick.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3033 (Changes to replace-brick and syntask interface.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3033
commit 07ac66f744a8285c275994f378bb8df2b4c91547
Author: Krishnan P <kp@gluster.com>
Date: Thu Jun 16 01:26:55 2011 +0000
afr: holding stack var via dict_set_static_bin corrupts.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3033 (Changes to replace-brick and syntask interface.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3033
commit 7db1118a57a37c1795e238db8c17f73854a4b719
Author: Krishnan P <kp@gluster.com>
Date: Thu Jun 16 01:26:00 2011 +0000
syncop: Modified to accept one 'non-frame' arg.
Earlier syncops used to accept one argument which
was a call frame to carry out the fops synchronously.
Now we have two args passed to synctask function, one
call frame and another void pointer.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3033 (Changes to replace-brick and syntask interface.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3033
commit 68261894eb1c620ba72ff57176a4affc24b67c6c
Author: Sachidananda <sac@gluster.com>
Date: Thu Jun 16 01:21:25 2011 +0000
Delete/correct deprecated options in sample vol files.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3031 (Fix share/{doc,man} directory)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3031
commit ee4599d440fc47b230c3896f3cbce44ded97ca05
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Jun 15 23:52:48 2011 +0000
features/locks: check for inodelk lists and blocked inodelks instead of entrylk in inodelk.c
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3032 (entrylks are checked instead of inodelks while checking the blocked inodelks conflict)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3032
commit 296c80d50cf1b96f1efdfa0864cbc08d7993f6a8
Author: Sachidananda <sac@gluster.com>
Date: Wed Jun 15 06:54:22 2011 +0000
Bring `examples' directory upto date.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3031 (Fix share/{doc,man} directory)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3031
commit e9b822b02f7b69212b2fc03e063b3f11aff06ff0
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Jun 14 12:31:07 2011 +0000
features/locks:update the refcount while releasing a lock
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3025 (open lock and close leads to memleak)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3025
commit c405325f24663e8a0d47d0d985c53e568d60d1a8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 01:42:10 2011 +0000
performance-translators: print path to file while dumping fdctx.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 6aae59567586285abaddb2da1d4ab9543625fc07
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 01:41:56 2011 +0000
performance/read-ahead: dump pages in read-ahead cache.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 893c3224939f2652047fa09eae773240c68a1a8f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 01:41:36 2011 +0000
performance/stat-prefetch: dump cache and list of ops waiting for lookup completion.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 095964a560e32fdd882853825eac5ea4387a7c86
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 01:41:24 2011 +0000
rbthashtable: implement traverser procedure.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 73bbe624a71f557377caf64a7e0225b195f62b79
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 01:41:11 2011 +0000
libglusterfs/inode.c: Add version of inode_path which can be called holding inode->lock.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 2d3b64b9d95335c0ab620a3479dc6130dc46d7ba
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 01:40:58 2011 +0000
performance/quick-read: dump inode and fdctx during statedump.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 07872f508f8bed733042057797cf31df92e5c432
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 14 01:40:45 2011 +0000
performance/io-cache: print cache information during state dump.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 37fe517079bbee9f279a767c887cc59644bdd285
Author: Junaid <junaid@gluster.com>
Date: Tue Jun 14 03:28:59 2011 +0000
cli: 'QUOTA' Display the limit-set and size of the directory in KB, MB, etc
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2829 (Display the quota limit as it is configured)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2829
commit adfe0a5e02c03d78abf3bc9bf3ec22e85604f088
Author: Junaid <junaid@gluster.com>
Date: Tue Jun 14 03:28:40 2011 +0000
libglusterfs/common-utils: Added gf_uint64_2human_readable function.
This function converts the given number to its corresponding representation in
KB, MB, etc.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2829 (Display the quota limit as it is configured)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2829
commit 35e8bd03d781fe170762218bcdd5256321a382fa
Author: Junaid <junaid@gluster.com>
Date: Tue Jun 14 03:44:30 2011 +0000
mgmt/glusterd: Set the generic options in the graph before merging it with the parent graph while building nfs-server volfile.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 3003 (Modification of one of the options of volume is reflected in all the volumes in the nfs-server-volfile)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3003
commit 32585757f83661d380725cfe418777331f0b1b47
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Mar 21 05:35:06 2011 +0000
Prevent spurious getxattr for gfid-req in posix_lookup
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2570 (getxattr failed msgs seen in log when log-level is DEBUG)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2570
commit 4167dc5df2eab2d445b4a9d4b40d50d4e9216a09
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Apr 12 05:19:22 2011 +0000
DHT: check for mis-matching user xattrs
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2717 (Detect user_xattr mismatches for dir's)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2717
commit daf10b4246df2736a534d4ba86ee952f31cad49e
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 1 04:51:08 2011 +0000
gluster rebalance: fix the mount command string
error creeped in while bringing in 'runner' options
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2258 (enhance gluster volume rebalance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2258
commit f796dc26546a10259088b0fec6114d6039d25573
Author: Lakshmipathi <lakshmipathi@gluster.com>
Date: Mon Mar 21 04:32:26 2011 +0000
removed unused old sample files
Signed-off-by: Lakshmipathi.G <lakshmipathi@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2552 (remove old sample vol.files)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2552
commit 2996a49e12a0f0132718301bfefde36089d4cf6a
Author: Junaid <junaid@gluster.com>
Date: Mon May 30 09:18:23 2011 +0000
cli: Display a warning upon disabling quota.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2912 (Display warning upon disable quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2912
commit 5acc9dcbd74ede3b671f37d8ea5972278f1664ba
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Jun 10 05:11:51 2011 +0000
DHT selheal dir: Recreate dirs with correct gfid.
When selfheal of dir is triggered, make sure the dirs are recreated
with the correct gfid, to prevent mismatch of gfids in the backend.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2994 ([glusterfs-3.2.1qa2]: untar and rm in parallel hangs untar)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2994
commit 61b7c5d69065217cf3a00626bbefbcd045c5a006
Author: Anand Avati <avati@gluster.com>
Date: Fri Jun 10 04:37:14 2011 +0000
cluster/afr: propagate proper errno returned by lock fops
If locks could not be held on any of the servers, then propagate the
errno returned by the lock FOPs instead of hardcoding EAGAIN/EINVAL.
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2993 ([glusterfs-3.2.0qa2]: hang while doing the selfheal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2993
commit 84087da0dcd718a73f2d5ddad235b5fad1429349
Author: Anand Avati <avati@gluster.com>
Date: Thu Jun 9 02:32:01 2011 +0000
cluster/dht: use GFID returned from hashed subvolume
.. to perform lookups on remaining subvolumes. This way, if there is a
race between two clients to 'fix' GFIDs with gfid-req, then the hashed
subvolume will arbitrate and return the winner in stbuf->ia_gfid. This
patch uses the returned gfid as the new gfid-req thereby preventing
mismatching GFIDs on other servers due to further races.
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2522 ([glusterfs-3.1.3qa8]: rm -rf shows invalid argument)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2522
commit 79687c6d2f03573b3bb83cc94f381eeed5eba72a
Author: Lakshmipathi <lakshmipathi@gluster.com>
Date: Tue Jun 7 03:47:11 2011 +0000
build : use pid file to kill nfs process
Signed-off-by: Lakshmipathi.G <lakshmipathi@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2969 (add --pidfile option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2969
commit ae7d910203444d8ff7cda878378e7881e603f4f0
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 8 09:29:21 2011 +0000
rpc-transport/rdma: don't return '0' in case of un-initiated rdma_connect()
needed to handle the re-configuration of the port in client protocol. If
there is a successful 'connect()' after the query port, the remote-port
value gets reset to '0'. In this case, if the connect() return 0 for
already connected socket, the query_portmap will keep happening in a loop.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2294 (Currently there is no way through cli to make a volume listen on both the transports (socket/rdma))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2294
commit e0bcec184bf906420c6c5d4c40e5bf84497d6d6c
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Jun 8 09:29:06 2011 +0000
nfs:command to change the transport type of nfs server for volumes of transport tcp, rdma
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2294 (Currently there is no way through cli to make a volume listen on both the transports (socket/rdma))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2294
commit 0d9961aafb92b3abbb80167cc212baf7ccbbda58
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 8 09:28:49 2011 +0000
fix multiple transport portmap issues in client handshake
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2294 (Currently there is no way through cli to make a volume listen on both the transports (socket/rdma))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2294
commit dbb3fc21461603cfb3d10ed5d92b6cc4752b4cf8
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 8 09:28:23 2011 +0000
glusterd-volgen: fix rdma volume file path in case of 'tcp, rdma' transport.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2294 (Currently there is no way through cli to make a volume listen on both the transports (socket/rdma))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2294
commit d41ecb8b9e88adf271185831b980606623060652
Author: Gaurav <gaurav@gluster.com>
Date: Wed Jun 8 05:59:03 2011 +0000
NFS : Don't set setattr_valid for exclusive create call.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2553 (NFS file create with Mac client and UNCHECKED mode returns "Operation not permitted")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2553
commit 32d5d470c50f6073b46634bd2b7511f71caa109a
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Jun 2 04:39:27 2011 +0000
cluster/stripe: check if key is a valid ptr. before dereferncing
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2978 (Geo-replication fails on stripe(Master) setup.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2978
commit 39082a07e4f491c8fd848b1fa2f48bd46abeccad
Author: Lakshmipathi <lakshmipathi@gluster.com>
Date: Mon Jun 6 04:11:19 2011 +0000
rpmbuild : restart glusterd after installing geo-replication rpm
Signed-off-by: Lakshmipathi.G <lakshmipathi@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2901 (Cannot start geo-replication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2901
commit 49d89913de175f5459ac14e0622ab570fa61cf03
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Jun 3 01:05:32 2011 +0000
protocol/server: logging changes
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2982 ([glusterfs-3.2.1qa2]: logging changes is server protocol)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2982
commit 661944eaf462d252d27616499051397f44efe3bc
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 2 02:59:07 2011 +0000
performance/io-cache: fix the check of min and max file size.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2974 (volume set for 'cache-min-file-size' succeeds even if 'min-file size' is greater than 'max-file-size')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2974
commit cceabfb7b2ccb5d213db6be3ce3cbb9221654050
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Jun 6 04:22:47 2011 +0000
glusterd: replace brick status grows with dir tree.
replace-brick status message's size can grow long with
deep directory trees.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2489 (GlusterFS crashing with replace-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2489
commit 8f197c07036663ee405c8eb1cc9aa20976b972c4
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Mon Jun 6 04:22:46 2011 +0000
syncop: Increase stack size for deep call stack.
pump performs a depth-first traversal of directories using the
syncop stack and this necessitates a larger stack when handling
deeper directory trees.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2489 (GlusterFS crashing with replace-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2489
commit ad64e22d8a43b8b8e6bff806e1637f1d77004301
Author: Junaid <junaid@gluster.com>
Date: Mon Jun 6 22:36:43 2011 +0000
mgmt/glusterd: Updated the error messages sent on cli quota command failure.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2856 ([glusterfs-3.2]: Misleading 'quota remove' output.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2856
commit 1946b83ea735094c706785d8cb1aa9ff18de2393
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Jun 6 03:10:39 2011 +0000
cluster/afr: Log errors in afr self-heal with GF_LOG_ERROR
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2986 (Failed operations should should be logged `E' or `W')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2986
commit c24a3b7bb5d96b9153e9a193c649a80b8fb267ad
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Jun 6 03:10:38 2011 +0000
protocol/client: Change log level of error to GF_LOG_ERROR
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2986 (Failed operations should should be logged `E' or `W')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2986
commit efd79ee884e4b391fe3cbe3be51a74d59cfb5bf0
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Jun 1 00:31:07 2011 +0000
cli: fix the build warning message
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2944 (warnings in cli_out)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2944
commit 502269494b61498974aa2078d658c0141567c12d
Author: Gaurav <gaurav@gluster.com>
Date: Tue May 31 23:40:27 2011 +0000
NFS : Handle buffer overflow in nfs3_create_exclusive.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2972 (Buffer overflow in nfs3_create_exclusive.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2972
commit 84d2fc2a26bd7c005d02c8f3090d2b03d03c196b
Author: shishir gowda <shishirng@gluster.com>
Date: Fri May 27 04:28:15 2011 +0000
glusterd: add upgrade/downgrade xlator options
If started with upgrade-option, the current behavior is to recreate
brick volfiles, as from 3.2 marker xlator is default.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2904 (glusterd should have upgrade/downgrade xlator options)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2904
commit 1df89d0906ab28c65d7ae4fa36e678d5e331df39
Author: Amar Tumballi <amar@gluster.com>
Date: Tue May 31 01:01:01 2011 +0000
gluster rebalance: prevent data migration from higher disk space to lower
this is done using the 'statfs()' on inode feature.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2258 (enhance gluster volume rebalance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2258
commit b1c425f7c4b8c53757aee07d9ddf824413fbcd81
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Apr 14 05:11:33 2011 +0000
DHT:first_up_subvol should be the one up the longest
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2684 (Dir missing from mount point)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2684
commit 6e7bc99434aab0ab266226b03dee5a076c42e69a
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon May 30 03:42:50 2011 +0000
stripe: changes to print stripe information in statedump
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2958 (stripe information is not printed in statedump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2958
commit 99a420b4399c1ddd7e390344a50ab3b7a9a8e83f
Author: Lakshmipathi <lakshmipathi@gluster.com>
Date: Mon May 30 04:45:19 2011 +0000
build : with rpm install invoke glusterd upgrade option to modify vol files and start
Signed-off-by: Lakshmipathi.G <lakshmipathi@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2904 (glusterd should have upgrade/downgrade xlator options)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2904
commit 8849897576ec6974fbf207793a05f06f41ffc7e6
Author: Amar Tumballi <amar@gluster.com>
Date: Wed May 25 05:14:25 2011 +0000
cli: bring in format checking option for 'cli_out()'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2944 (warnings in cli_out)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2944
commit 0aa6c4771b2fcea9e417fff1ffb25effcaa37c25
Author: Amar Tumballi <amar@gluster.com>
Date: Wed May 25 05:14:04 2011 +0000
cli: fix format string build warnings
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2944 (warnings in cli_out)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2944
commit 2fae781233961a0e3af84c6b4f2e13f680bd45ba
Author: shishir gowda <shishirng@gluster.com>
Date: Tue May 31 06:40:27 2011 +0000
client_bind: When allow-insecure xlator option is set, donot bind.
There is no need to bind a client, as connect will assign a port.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2868 (Add xlator-option to support insecure-bind for clients)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2868
commit 3c9cd04cf42db478d8969eec4577b69b929549e5
Author: Amar Tumballi <amar@gluster.com>
Date: Tue May 31 06:39:41 2011 +0000
glusterfsd: prevent giving '-s' option without '--volfile-id' option
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2934 (for glusterfs binary, -s option without --volfile-id will fail without any notice to user)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2934
commit c8d9cec646a356fcd09c4b3eb3d21afb762300d2
Author: shishir gowda <shishirng@gluster.com>
Date: Fri May 27 00:41:55 2011 +0000
dht-rename: Unlink older link files before creating new one
If a older link file exists, unlink it and then create the linkfile.
This will prevent mis-match of gfid's.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2464 ([7b07d444a77526f27f860210930bf1d4c7fbea9b]: rm -rf gives Invalid argumenrt error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2464
commit a5f545f3903f6f703ed4c005c25c3b6a938bb384
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue May 31 06:08:12 2011 +0000
pump: init last_event array to be used in afr_notify
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2870 (Inconsistent xattr values when creating bricks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2870
commit 6673218ac52651950463ca358cbaa2effcedb4df
Author: Sachidananda <sac@gluster.com>
Date: Mon May 23 12:23:11 2011 +0000
Fix typo in log message related to io-threads.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2926 (Typo in log message)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2926
commit ba1f0081c7cadc2525d5c2887b6c5893d1ea2049
Author: Gaurav <gaurav@gluster.com>
Date: Mon May 30 05:00:50 2011 +0000
RPC : Valid typecasting for ipv4 and ipv6 in rpcsvc_get_listener_port.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2956 (Invalid typecating for ipv4 and ipv6 in rpcsvc_get_listener_port.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2956
commit 099a087030ebf2aa66ee24074e0e660f3a680a8d
Author: Amar Tumballi <amar@gluster.com>
Date: Thu May 26 07:45:49 2011 +0000
statfs(): honor the 'inode' on which the statfs() call is made
fuse-bridge : fill the 'loc' properly with correct 'inode'.
dht : if directory, send statfs() to all subvol, else send it to only
cached subvol.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2258 (enhance gluster volume rebalance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2258
commit 654e97b2ce439f003c93a3ef8da2f6eaf87c4378
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed May 25 04:26:00 2011 +0000
performance/stat-prefetch: return ESTALE if inode's gfid is not the same as cached gfid for a path.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2927 (Mismatched link/target gfid and ESTALE/ENOENT)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2927
commit ce7e7ab81e28ef73c9e027b73f7aeed41d501ba8
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon May 30 07:55:00 2011 +0000
features/locks: Unwind with SUCCESS on non-blocking entrylk success
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2949 (self-heal hangs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2949
commit 806af6d44eab060902ed8bc1573df88501776ad3
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon May 30 07:54:59 2011 +0000
cluster/afr: Send Non-blocking lock in non-blocking entrylk
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2949 (self-heal hangs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2949
commit 1d9fafe78acda6d37327cee6798b6f419b291d92
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri May 27 01:13:39 2011 +0000
cluster/afr: Send the first child up/down after all its children notify
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2870 (Inconsistent xattr values when creating bricks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2870
commit 2653fe8011f32007dd8c5cce8666e5441c6a2d1f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri May 27 01:13:40 2011 +0000
cluster/dht: notify should succeed when waiting for all subvols first event
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2870 (Inconsistent xattr values when creating bricks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2870
commit b3eb8994a2487dba54a0cd5d2308416fa14fef02
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 16:56:32 2011 +0000
glusterfsd-mgmt: include signal.h
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit f24929b9980bcaeb496ce5c4ef0b05657610f13c
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 16:56:31 2011 +0000
rpc: NetBSD portability fixes
NetBSD's <dirent.h> does a #defiine d_ino d_fileno. Since glusterfs
declares structs with d_ino members, we must include <dirent.h> early
so that d_ino get preprocessed into d_fileno conssitently.
Also define proper xdr types for NetBSD.
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit 4621843eb5f5bf6ba13359fd35bfee7bf46ea076
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 16:56:30 2011 +0000
fuse: NetBSD portability fixes
Make sure NetBSD pulls proper FUSE header
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit c626c2afd0925798abfcda31fbbfba3df614a1ba
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 16:56:29 2011 +0000
quick-read: Fix dirname(3) usage
glibc dirname() modify the string it is given and returns it.
glusterfs takes this behavior for granted, and assume that if it
gives a malloc'ed string to dirname(), then it can free()) the
return value.
Here is what SUSv2 says:
http://opengroup.org/onlinepubs/007908799/xsh/dirname.html
"The dirname() function may modify the string pointed to by path,
and may return a pointer to static storage"
At least NetBSD returns a static storage. glusterfs will return it to
a calling function that has the responsability to free it, causing
a SIGSEGV.
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit 4de3e3803a27ddf8babe990a587e78eed09244c7
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 16:56:28 2011 +0000
stat-prefetch: fix dirname(3) usage
glibc dirname() modify the string it is given and returns it.
glusterfs takes this behavior for granted, and assume that if it
gives a malloc'ed string to dirname(), then it can free()) the
return value.
Here is what SUSv2 says:
http://opengroup.org/onlinepubs/007908799/xsh/dirname.html
"The dirname() function may modify the string pointed to by path,
and may return a pointer to static storage"
At least NetBSD returns a static storage. glusterfs will return it to
a calling function that has the responsability to free it, causing
a SIGSEGV.
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit 3b78ee9c47a7bfa3efce3d91804a130c7283784a
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 16:56:27 2011 +0000
fuse: NetBSD portability fixes
- NetBSD uses libperfuse(3).
- Add @GF_FUSE_LDADD@ to fuse.so library dependecies so that -lperfuse is
added at configure time for NetBSD.
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit e75ccd1ce85ddb9a28236da6b115f677a9ce8767
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 16:56:26 2011 +0000
rpc: TCP_KEEPALIVE undeclared in NetBSD
Works around "error: 'TCP_KEEPALIVE' undeclared" on NetBSD
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit f529081372bb9dc9c8a889dca16d0deba15b7b65
Author: Anand Avati <avati@gluster.com>
Date: Mon May 30 04:18:00 2011 +0000
fuse: NetBSD portability fixes
On NetBSD use libperfuse(3), rename umount2(2) as unmount(2), and skip
inexistant /etc/mtab management.
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit 730f6419ff0c2c470d3d0697a30d1372f4ee9756
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 16:56:24 2011 +0000
errno: NetBSD does not have EDOOFUS
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
[avati@gluster.com: check for EDOOFUS instead of !NetBSD]
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit afaf5ddc73d774a0c239a0a34bceac0bcdb882a5
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 16:56:23 2011 +0000
rpc: use AI_ADDRCONFIG selectively
NetBSD does not have AI_ADDRCONFIG. This patch has a side effect: glusterfsd
listens on IPv6 adresses only by default. Option transport.socket.bind-address
in volume server-tcp must be used to listen on an IPv4 address.
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit 9d494128c04c5485d6c0ecc19f0c99f8e387a088
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 16:56:22 2011 +0000
mount.glusterfs: The == operator is a non-standard bash extension. = should be used instead
Thanks to: Emmanuel Dreyfus <manu@netbsd.org>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2923 (NetBSD port)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2923
commit be18d0d06c20a994b0fb935dcc9ec7e465bb7c5e
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Apr 13 00:27:02 2011 +0000
rpc-clnt: consider the (re-)configured port for only one connect() call
this way, if remote_port is set due to queryport, that can fall back
to default port (or 'option remote-port' value) when it disconnects.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2709 (issues with port (re-)configuration in client protocol)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2709
commit 7f54c52762bde989d18c03b6da2f0aafc781478f
Author: Junaid <junaid@gluster.com>
Date: Tue May 17 06:29:22 2011 +0000
cluster/stripe: Fix a typo in strncmp.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2760 (Quota: stripe volume not showing the quota size properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2760
commit 1895b31507cacb4ab232a5b0e0f91d754418517b
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sun May 15 04:59:53 2011 +0000
mgmt/glusterd: Display a warning message to CLI in case of a corrupt geo-rep session
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2828 (gluster geo-rep stop should not show unsuccessful when the status is corrupt)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2828
commit 4923237102492e33d4ea8e3c2f9c20bd25f52c0f
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri May 27 00:29:10 2011 +0000
pump: Detect 'empty' brick and finish migration.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2909 (replace brick of empty brick never says migration completed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2909
commit 65aadb78392d13d8cf15425f31bb4389746a092f
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun May 29 08:11:22 2011 +0000
mgmt/glusterd: Set option listen-backlog to 128
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2941 (glusterd breaks when starting ~100 volumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2941
commit 2281c262ce9463f4c4f1de0bdf0af357e224d1e9
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun May 29 08:10:48 2011 +0000
rpc: Introduce option for listen()'s backlog
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2941 (glusterd breaks when starting ~100 volumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2941
commit 4c6dd548b0036ecac2e5abc3582a0258f2029fab
Author: shishir gowda <shishirng@gluster.com>
Date: Thu May 26 05:45:07 2011 +0000
TOP: exit status should be non-zero for success
The fault was incorrect loop. An extra iteration was being performed,
and dict_get failed due to non-existant data leading to status being
set to non-zero
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2882 (Make volume top command exit status as zero on success)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2882
commit 4974c7812e128369393a34d71f95b7092dd021d5
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu May 26 04:17:15 2011 +0000
mgmt/glusterd: Start nfs after all bricks are started on glusterd re-start
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2941 (glusterd breaks when starting ~100 volumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2941
commit 200f183e8174be34740693d3bd140b94e7c8e2a3
Author: Amar Tumballi <amar@gluster.com>
Date: Wed May 25 07:30:15 2011 +0000
performance/io-cache: fix annoying logs during reconfigure
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2945 (disturbing logs in io-cache reconfigure())
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2945
commit 726bc439e3a97f74c43cced71ae15cb27ba5f1c7
Author: Anand Avati <avati@gluster.com>
Date: Fri May 20 15:32:27 2011 +0000
cluster/dht: detect linkfiles mismatching gfids and delete+recreate
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2522 ([glusterfs-3.1.3qa8]: rm -rf shows invalid argument)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2522
commit 943bba9baf117efd65503d64cedf18e5c4e9e501
Author: Csaba Henk <csaba@gluster.com>
Date: Thu May 26 03:32:27 2011 +0000
reimplement invocation of external programs with run API
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2562 (invoke external commands precisely with fork + exec)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2562
commit 3c92f85822f910cd169d089c8728f4c903a3fa9e
Author: Csaba Henk <csaba@gluster.com>
Date: Thu May 26 03:32:26 2011 +0000
libglusterfs: add 'run' sub-lib for safe and convenient invocation of external programs
Summary:
- arguments first collected, then the invocation happens with fork + exec
- flexible specification of arguments (besides si{mp,ng}le argument
addition, support for adding multiple of them at a time / specifying one with
printf style formatting) [ ==> goodbye printf percentage soup when composing
commands ]
- single point of error check
- simple command runs are done in just one line
- support for redirection, popen(3) like functionality
API is documented in details in libglusterfs/src/run.h
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2562 (invoke external commands precisely with fork + exec)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2562
commit 33e51ff3253303b68f4843d3dfaa59843f358ef5
Author: Csaba Henk <csaba@gluster.com>
Date: Thu May 26 03:32:25 2011 +0000
libglusterfs: clean up memory types
Unify them in one header, weed out overlap.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2562 (invoke external commands precisely with fork + exec)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2562
commit 5e3c25f364caa620a9a53902048e4f27ed939c4b
Author: Csaba Henk <csaba@gluster.com>
Date: Thu May 26 03:32:24 2011 +0000
Revert "temporary workaround for mtab update race thingy"
This reverts commit 59b9ab45a01d52e197ab6f76fd71e64910396d57.
[c5d781e0 made this temporary workaround unnecessary]
Conflicts:
xlators/features/marker/utils/syncdaemon/resource.py
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2690 (race between mtab updates of mount and umount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2690
commit e55edc2477e35cbde1df06caa88cac7613104d30
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Apr 13 02:24:49 2011 +0000
replicate: print favorite child as an int instead of unsigned int
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2668 ([glusterfs-3.2.9qa7]: createbench error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2668
commit 9c60c162ee4d2241de81d4d594a9b9507ab0b5e3
Author: Venky Shankar <venky@gluster.com>
Date: Mon Apr 25 03:10:01 2011 +0000
cli log level command and per translator log level
Signed-off-by: Venky Shankar <venky@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2714 (implement cli log level command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2714
commit 890affc414660998d9d55da69f423ba0a345155e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed May 18 23:21:02 2011 +0000
debug/error-gen: include error-gen-mem-types.h in distribution tarball.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2915 (error-gen-mem-types.h is not included in distribution tarball generated by doing 'make dist')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2915
commit 3ff140f728764105706e4c55e2785932860c017a
Author: Csaba Henk <csaba@gluster.com>
Date: Sun May 15 04:52:33 2011 +0000
upon daemonizing, wait on mtab update to terminate in parent
This fixes the race in between the mtab update attempts of mount and umount
when we do a lazy umount right after mounting, in order to hide the given fs
instance; yet this way we still avoid the deadlock of the fs and mount which
we can hit if we wait unconditionally for the mtab update to terminate (cf.
bz #511).
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2690 (race between mtab updates of mount and umount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2690
commit 8771e107cd11e42b37bae46be894a94012530490
Author: shishir gowda <shishirng@gluster.com>
Date: Mon May 2 03:47:39 2011 +0000
Introduce client-allow-insecure xlator-option.
Allows glusterfs clients to bind to any port and does not restrict it
to 1024.
This is a xlator-option only, and is not supported in volume set cmd.
The reason is, few clients may choose this, and few may not. Hence
only supported as a xlator-option during mount time.
For this to work with glusterfs, server.allow-insecure should be set
to on
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2868 (Add xlator-option to support insecure-bind for clients)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2868
commit 59b7757fc24c5abda79a3638728157b350a5446b
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Apr 20 23:46:05 2011 +0000
cluster/stripe: make sure gfid is checked with valid data
earlier logic of determining if different subvolumes have different
gfid for same file had a flaw. It could have checked with a empty
gfid field in case a reply comes from other subvolumes before first
subvolume
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2773 ([glusterfs-3.2.0qa12]: stripe lookup says gfid different)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2773
commit b56d13de63314dac0502e260d6b5dae5557da917
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Apr 18 00:58:49 2011 +0000
gnfs-loganalyse: Track fh & entry operations given filename
Introduces support for outputting only those NFS operations
that operate on a given filename and all the filehandles that
are seen in the log file for that filename.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 913 (NFS-specific log analyzer tool)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=913
commit 79374780b73f39e70fa1f893dcb8291a5209e4a6
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon May 2 05:36:17 2011 +0000
glusterd: send the duplicate brick info to the cli
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2803 ([glusterfs-3.2.0qa14]: volume create succeeds even though there is a volume with an export directory in the path of current volume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2803
commit 58dbc8698ce5adfb86906b2061d334be9e97e9fe
Author: shishir gowda <shishirng@gluster.com>
Date: Mon May 2 05:08:39 2011 +0000
Validate stripe-block-size option
Minimum size is 512 bytes and should be a multiple of 512 bytes.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2861 (Stripe block-size has no check for valid option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2861
commit 1b26d25e02c82583d70ef5955f297d8c4acceced
Author: Sachidananda <sac@gluster.com>
Date: Mon May 2 03:32:31 2011 +0000
Move `self-heal completed' message to log level INFO.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2867 (Move self-heal completed message to INFO level)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2867
commit efd22746081dbc33401119cc0dac2eaf75d7d9bf
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun May 8 23:41:23 2011 +0000
features/marker: whitespace cleanup
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit 9517d9908262a94f360463f6174bcb52180310ea
Author: Csaba Henk <csaba@gluster.com>
Date: Wed May 11 02:39:14 2011 +0000
cli: taking my revenge for forcing "geo-replication" into commandline
Accept unambigous initial fragments of keywords, eg.
gluster vol geo stat
is recognized. Compared to readline integration:
- no external dependency
- works in shell too
- works for inner keywords of operations
(as in above example, or "vol crea <vol> repl 3 ...")
- you save pressing tabs :)
If not desired in customer builds, can be disabled by an #ifdef
(not integrated into build system as of now); however, I think
folks in house could like it.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2757 (refactory gsync/gsyncd/syncdaemon/whatever to geo-replication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2757
commit de55d766db11be43dd9132b2b4f6271f6cf0b565
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 29 12:25:36 2011 +0000
syncdaemon: fix listing xattrs when there is none and failure handling
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2859 (gsyncd crashes if master vol root has no xattrs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2859
commit ab6bff99eedafbea0bf1f31ea2c413f0a7c20fd7
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 29 06:24:45 2011 +0000
syncdaemon: some refactor on monitor
- detect faulty state early
- keep the feedback fd in gsyncd module
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2537 (gsync autorestart)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2537
commit ef2fa04e5c65716e43119c5723ad64116f3600a2
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 29 06:24:43 2011 +0000
marker: fill out the volume-mark properly in case of marking corruption
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2858 (volume-mark corruption swallowed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2858
commit 7a8de7dd818dfc048e4a21c5e225aeba7eef0840
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 29 06:24:42 2011 +0000
syncdaemon: add --normalize-url option
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2828 (gluster geo-rep stop should not show unsuccessful when the status is corrupt)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2828
commit 60f84f46b3f9321740075ed3ecf79a1312e90646
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 29 06:24:41 2011 +0000
glusterd / geo-rep: set session owner to the uuid of the master vol instead of that of glusterd
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit 14810372b9e7b51050aa076359003a04b6e392f2
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 29 06:24:40 2011 +0000
glusterd / cli / rpc: move geo-replication reply parameters into dict
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit 874b8acd98db472d073b6ad30a2c1fba56b05bc3
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Apr 27 04:46:24 2011 +0000
posix: glusterfs.test should be removed xattr immediately after use.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2609 (Error message not properly provided when trying to create a volume from a read-only source)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2609
commit 3ba747994acf344148a29cc71e48b1fcca7e70a8
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Wed Apr 27 04:46:23 2011 +0000
Detect read-only filesystem and fail the brick creation operation.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2609 (Error message not properly provided when trying to create a volume from a read-only source)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2609
commit 0c748d4e9a6994ecab03b55cc1b2ecdf6d92d113
Author: shishir gowda <shishirng@gluster.com>
Date: Mon May 2 01:38:09 2011 +0000
set: Fix incorrect nfs.rpc-auth strings in nfs_option_handler
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2866 (volume set for nfs rpc-auth.addr* option succeeds, but vol file not updated)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2866
commit 175a98a1cee845a543ae143e259416787ee994b8
Author: Anand Avati <avati@gluster.com>
Date: Wed May 4 06:02:02 2011 -0700
configure.ac: set default version to 3git
commit 23436384d9181abbf0364fb3d68fce0e8314fca9
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Apr 15 01:27:25 2011 +0000
add 'logrotate' config file to the package
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2053 (We need to support the standard *nix 'logrotate' for server and client log files.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2053
commit c51ee251873a4792821fbbd995fbafbcac19a8a7
Author: shishir gowda <shishirng@gluster.com>
Date: Mon May 2 03:47:19 2011 +0000
gf_auth also needs to handle server.allow-insecure
When server.allow-insecure option is set, the connection from client
can be from any port. gf_auth also needs to check for this option
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2868 (Add xlator-option to support insecure-bind for clients)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2868
commit dae5df03a7cfcc83d7fe7c5cf783756b9748b9a8
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Tue May 3 05:04:57 2011 +0000
glusterd: Checked brick path length in 'staging'.
Added checks for brick path length in 'staging' of add/replace
brick and create_volume subcommands.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2847 (volume creation fails if brick path is long)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2847
commit 40dd681d8df65f1910dc530cce6b9e1c17cccd41
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Tue May 3 02:05:38 2011 +0000
glusterd: Cleaned up 'store' if vol create fails.
glusterd's internal 'store' needs to be cleaned up if
volume creation operation fails.
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2847 (volume creation fails if brick path is long)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2847
commit aad27a6ef63efa6747784393583dce3e3b0be192
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed May 4 04:14:02 2011 +0000
cluster/afr: set loc gfids for fresh lookup
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit d5db365a425e2c2f419f6521797a3175d5b64d82
Author: Gaurav <gaurav@gluster.com>
Date: Thu Apr 21 03:58:48 2011 +0000
NFS : Use proper exit point in nfs_init_state.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2695 (Mac host showmount -a not working.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2695
commit 142a86c322e6621a8f9368bf936b62176e23555d
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Apr 21 03:43:20 2011 +0000
cluster/distribute: corrected layout mismatch handling logic
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2281 (I/O operations exit when add-brick is done)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2281
commit 69932393e2ce3453b9eb256e31b9667f78e01130
Author: Gaurav <gaurav@gluster.com>
Date: Wed Apr 27 03:20:11 2011 +0000
NFS : Maintain common state for MOUNT1 and MOUNT3.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2695 (Mac host showmount -a not working.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2695
commit b3bcfc82e17437c8906b35891420481144914948
Author: Sachidananda <sac@gluster.com>
Date: Mon May 2 02:56:40 2011 +0000
Move the log `self-heal pending' message to INFO level.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2867 (Move self-heal completed message to INFO level)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2867
commit 5d4a253e556112a4f68c99f8cef373601e5fae24
Author: Sachidananda <sac@gluster.com>
Date: Mon May 2 02:47:53 2011 +0000
Move self-heal completed log message to INFO level.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2867 (Move self-heal completed message to INFO level)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2867
commit 3169a33cde0b763e5a18707fe22910ebb9cc754a
Author: Amar Tumballi <amar@gluster.com>
Date: Mon May 2 03:11:54 2011 +0000
loc_t: add 'gfid' and 'pargfid' fields
these fields are used mainly in case of selfheal path, where
'inode->gfid'||'parent->gfid' is not yet set.
These fields in 'loc' will have lower precedence than 'inode->gfid'
in client protocol.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit af38e898ee6373efb3b593918175f6654974e6a3
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Apr 9 01:54:19 2011 +0000
enable memory accounting for error-gen xlator
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit af814ecf8b74d00c88563e56d08020524238b295
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Apr 24 22:45:31 2011 +0000
performance/write-behind: initialize lock in wb-file before wb-file is set in fd-ctx.
- Consider a combination of fuse->quick-read->read-ahead->wb->client.
quick-read can do open-behind (open is returned as success even
before it is issued to backend) and hence the fd can already be
in the list of open fds of the inode. A flush call on some other
fd opened on the same inode, will result in ra_flush issuing flush
calls to all the fds opened on the same inode. This can result in
wb_flush trying to hold a lock on non-initialized lock there by causing
memory corruption.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2679 (Crash in GlusterFS 3.0.5 in GSP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2679
commit 3576ac0e82c8f6907fff0cd5a7381fa440c36027
Author: Anand Avati <avati@gluster.com>
Date: Thu Apr 28 01:08:32 2011 +0000
marker: fix NULL deref in logging
Fix bad gf_log argument
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2852 (Glusterfsd crashes on AMI)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2852
commit 93b26d5eb9794ed57e3811a054363b162266293c
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 22 11:55:58 2011 +0000
mgmt/glusterd: Fix ret value in importing of options/gsync slaves
In case the volume options or gsync slaves are absent the import should
succeed.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2832 (peer probe hangs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2832
commit 000a88ad0309d52f62a24d6b3cb7f9efbd893fdc
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Apr 21 17:38:10 2011 +0000
cli: fix up parsing of geo-replication status
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit 224721459f4927d5372716a10ea1f477f52421ec
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Apr 21 16:43:49 2011 +0000
syncdaemon: have the monitor kill the worker if it does not connect in 60 sec
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2736 (gsyncd hangs if crash occurs in the non-main thread)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2736
commit ddc620ebe31b6a1d9cf436c336b5256d58164850
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Apr 21 16:43:48 2011 +0000
cli: adhere to timeouts properly
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit 6d7209d1369862684691a0285012387492422f2e
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Apr 21 06:55:46 2011 +0000
mgmt/glusterd: fix up the buffer sizes to accomodate a correct estimate of sizes of the snprintf invocations, and errout if not feasible
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2561 (gsyncd command's must be preconfigured)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2561
commit 7f8ea77bfd9d7c4f1a00eb79ec5d838ae9fe4eef
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Apr 21 06:55:45 2011 +0000
cli: check if gsyncd is present in the configured place, enable geo-replication if present
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2744 (make geo-replication package friendly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2744
commit 1117253a6856da64883a71299f8192dca9d33c8a
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Apr 21 06:55:44 2011 +0000
cli: changes in struct cli_cmd to disable gluster command at run-time
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2744 (make geo-replication package friendly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2744
commit b703b18fff9d5f9945f1c94c28f1dc1771d77145
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Apr 21 08:56:09 2011 +0000
syncdaemon: handle errors in glusterfs mount more carefully
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2826 (stale auxiliary mounts are left over)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2826
commit 25d5b7f8121658ed3bedfc6aec9355bdc9df76c5
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Apr 15 01:10:48 2011 +0000
gluster volume create: fix help message with transport option 'tcp, rdma'
used to create a volume which listens on both sockets and ibverbs
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2742 (cli help for volume create is not upto date)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2742
commit 5963bc368e4cf8df16b6084205b02ee05b9c0dc3
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Apr 21 07:08:28 2011 +0000
prevent few excessive logs
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 0de9ac649391139043f5dcae1b5a9c656aa63c2f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Apr 21 05:03:56 2011 +0000
features/marker-quota: handle creation of regular files using mknod.
- Add the disk-used to parents' size.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2649 (Quota: size field is not getting updated properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2649
commit 7577fb394003ef4ec992cd022f42ab2496cdd16d
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Apr 21 05:22:23 2011 +0000
glusterd / cli: make the needed changes to let a masterless geo-rep config request get thru
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit f57606e926f28849cad6739989b4cff9a46abb5f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Apr 21 04:16:44 2011 +0000
features/marker-quota: handle overflow of counter used to set frame->root->lk_owner.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2804 (Occasional log messages seen indicating failure of inodelk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2804
commit 958d8efcb525364bb146b5d0a34fcf861b2994a0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Apr 21 04:10:17 2011 +0000
features/marker-quota: Add the disk space used to parent sizes during creation of new-files or symlinks.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2649 (Quota: size field is not getting updated properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2649
commit d52d8a112d9561fabc406b0e30b0fcbc6cbeb2bc
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Apr 18 14:23:17 2011 +0000
do not allow create volume or add-brick if given path or any brick is a part of either
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2803 ([glusterfs-3.2.0qa14]: volume create succeeds even though there is a volume with an export directory in the path of current volume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2803
commit 78ffaac515936f911afa69bbaf3c2ba35cfb9b23
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Apr 19 08:59:26 2011 +0000
cli: change geo-replication syntax to support slave-only invocation
(for sake of slave side configurability).
Also pulled out sub-op, now we have
volume geo-replication [<VOLNAME>] [<SLAVE-URL>] {start|stop|config|status} [options...]
-- more convenient to use when working on a given session (ie. we just change the
geo-rep subcommands), and aligns better with other volume commands, cf. eg.
volume replace-brick <VOLNAME> <BRICK> <NEW-BRICK> {start|pause|abort|status|commit}
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit ceac00aa3a557891c90fb51ea6c8741e76c4a896
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Apr 19 07:19:17 2011 +0000
geo-replication: revamp CONFIG command
Drop the config_type RPC req field, use just a "subop" key in the param dict.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit 5e5f4f7a53a37e66e31e1c84ac3f7b28ad9be808
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Apr 19 09:35:45 2011 +0000
syncdaemon: fix double wait in monitor
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2816 ([glusterfs-3.2.0qa14]: gsyncd monitor crashed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2816
commit 4101499cc031d93769c6c4bb27d14b5d1653368b
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Apr 20 00:59:26 2011 +0000
glusterd: log the error immedietly after the syscall failure
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 43873fa2a980b8521f1197e0b6743471fbe89e11
Author: Gaurav <gaurav@gluster.com>
Date: Wed Apr 20 05:12:58 2011 +0000
NFS : Check proper permissions in access control for setattr.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2818 (Permission problems with gluster NFS works with native FUSE)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2818
commit 0be1a82a79b2a02d0198f5a6e4ebc898238eba80
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Apr 20 12:47:12 2011 +0000
features/marker: reduce the size corresponding to destination file if it is already present from parent directories.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2697 (Quota: add-brick creates the size go awkward, though it was perfect earlier)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2697
commit 7c1f000159a609af8d283a8a093c8a4cebb61448
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Apr 19 04:56:58 2011 +0000
features/marker-quota: initialize dentry_child_count to total number of children a directory has in a single go.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2809 ([e89f2a1f5daf1513c533a47b90aec8f90702d09f]: glusterfsd crashed in quota_dirty_inode_readdir)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2809
commit 183fedda3ff7738918be6df54e932d35fe8d6151
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Apr 18 21:53:45 2011 +0000
marker: fixes to bypass marker fops in case features are enabled
mainly in unlink and rename
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2801 (glusterfsd process crash while running rebalance on simple volume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2801
commit 60119ad27c5f78e3cc9f3eabe44cda2d53182bf4
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:25:31 2011 +0000
glusterd / geo-rep: harvesting further benefits of static gsyncd pre-config
- log-file does not need to be a reserved option anymore as we
wouldn't overwrite the user setting
- reimplement glusterd_gsync_get_param_file(): all use cases
have now pre-configured values, so instead of putting together
the needed pathname by ourselves, we can just get it from
gsyncd config
- refactor it to a common backend with glusterd_get_canon_url()
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit dea03fc7559a2d0a658bd8b73d43df4156f670c4
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:25:30 2011 +0000
glusterd / geo-rep: do all gsyncd pre-configuration in glusterd init
This is made possible by gsyncd config templating, by which
session specific settings can be expressed in a generic form.
Benefits:
- in glusterd we use only generic (rx pattern based) config settings
so we don't violate users' freedom to make settigs for their sessions
- don't have to invoke gsyncd in excess to prepare a session
- we can pre-configure slave side too (relying on the templates and
gsyncd service auto-discovery)
- much leaner, much more expressive code
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit bab1fbe6a2d48a14b31a11e62dd064a4f542e5f9
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:25:29 2011 +0000
syncdaemon: add session-owner option
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit 636ea80029f8c9804ba043c689f160b9f867dfa4
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:25:28 2011 +0000
syncdaemon: implement template substitutions for config values
So, for example, a log file setting of
/var/log/${mastervol}/${eSlave}.log
will be substituted with the volume name of the master and the
canonicalized-escaped name of the slave for each master-slave pair.
As template expanders, beyond the various forms and derivatives
of master and slave, the following are also available:
- gsyncd tunables (set in command line or in config)
- for regexp sections, regexp group captures can be accessed
via "match<i>_<n>", where i=1,2 corresponds to the i-th peer-rx
in the section title and n=1,... to the n-th capture.
This will enable us to have a static configuration (not having to
add new entries on each gsyncd start).
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit a4f068f39d80011881db902f5e1dd1cd9489f934
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:25:27 2011 +0000
gsyncd service auto-discovery
If glusterd is running, gsyncd will find it out and adopt related settings
automagically (even if started from not by glusterd)
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit b34d41b62bb2869e58ec8a9e6788b07a27ea0233
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:25:26 2011 +0000
cli: make it possible to set per-command timeouts for connection
Also make getwd command impatient, having it to time out in 1 sec
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit 4978709832bbe3cae1f9566329272e3804cb9fb3
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:25:25 2011 +0000
cli: implement "system:: getwd" command
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit 74733997da5af11b37da3c8934b98496fcf4dd37
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:25:24 2011 +0000
cli: preliminary cleanup for system:: commands
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2785 (gsyncd logs on slave side go to /dev/null)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2785
commit cb57f6ded497133ae62c8684cf38ca1aef117032
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:21:24 2011 +0000
mgmt/glusterd: geo-rep: restart-upon-reconfig: don't bail out if the gsync session we adjust does not exist
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2777 (geo-replication config setting should have effect on already running sessions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2777
commit dd4a3d07ff8a1ba9f5e12b3e72cca2f02184d1d5
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:21:23 2011 +0000
syncdaemon: fix swallowing of exit value
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2736 (gsyncd hangs if crash occurs in the non-main thread)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2736
commit aa7132319110c5f176b56ac134b612c83edf2b49
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:21:22 2011 +0000
syncdaemon: pythonize accidentally copied ruby line in code
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2791 (trying to set up geo-replication with a gluster slave on the LAN screws up geo-rep irrecoverably)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2791
commit 6a159ffb000c48f4bd461096fc133ed46687d3a9
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 18 17:21:21 2011 +0000
syncdaemon: don't accept simple identifiers anymore as sugared urls
- we want to enforce the separation of the volume name and the url namespaces
- resolving simple ids as relative paths was lame anyway
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2786 (Having to prepend geo-replication master vol with colon spoils the UI)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2786
commit 6f6a4dc48e1769d38b33f2dcb8ac0b54895adb8c
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Apr 18 12:29:51 2011 +0000
mgmt/glusterd: Fix compiler warning
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2797 ([glusterfs-3.2.0qa13]: peer probe fails with gsync running)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2797
commit 30baa3adf19021d3f38fc0cc6dfa6ce83badb077
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Apr 18 10:42:03 2011 +0000
mgmt/glusterd: Send the gsync sessions that are running to the new peer.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2797 ([glusterfs-3.2.0qa13]: peer probe fails with gsync running)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2797
commit b2468ecce10d347b1b2605aed7fdd2a53a22c0db
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Apr 18 08:49:54 2011 +0000
mgmt/glusterd: do not allow replace-brick operations when geo-rep sessions are active on this volume.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2765 (geo-replication should have mercy on brick failure)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2765
commit 8cfea538b3d64f99e096f305d9ce5d25ed5081a9
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Apr 18 08:30:54 2011 +0000
features/marker-quota: reduce contributions to parents during unlink only if it is the last link.
- since we are not having different contributions for different (parent, name)
pairs, but only for different parents, links present in the same directory
will have only one contribution representing all of them. Hence parents will
not be updated for each link call and parents account for just file-size
instead of (numlinks * filesize). However this patch will cause issues
for links present accross directories, as only one of their contributions
is subtracted when all of them removed (Here all the links are accounted
in their parents, thereby total size accounted is [numlinks * filesize]).
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2689 (Quota: xattrs getting corrupted)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2689
commit cd989e59126e473445ca6d0208abd383c3819179
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Apr 18 08:30:35 2011 +0000
features/marker-quota: remove contribution xattrs from oldloc in rename.
- Though we are setting in memory contribution to zero, during updation
process contribution is actually fetched from backend. If they are not
deleted and if newpath did not exist before doing rename, contributions
from oldloc->inode will be retained even for newloc->inode, there by
preventing addition of file-size to parents in newpath.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2689 (Quota: xattrs getting corrupted)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2689
commit 158260900fb9805734c5fa86e73256277ba5106d
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Apr 18 07:34:54 2011 +0000
mgmt/glusterd: geo-rep config set/del restarts the geo-rep process so that it takes up the new configuration values
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2777 (geo-replication config setting should have effect on already running sessions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2777
commit 9be5023227fba4be8bf50bd34091fddb43e0a275
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Apr 18 05:03:00 2011 +0000
cli: Fix profile info alignment
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2794 (Alignment is not proper in profile volume info)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2794
commit ef6be54d6cae0de7ecaf94dfb886e7ffff73e042
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Apr 18 02:09:00 2011 +0000
mgmt/glusterd: change the cli output of geo-rep start/stop to resemble the output of volume start/stop
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit cd2e11ad681fbf87bb5d4ae83929888738b3bb12
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Apr 7 04:45:40 2011 +0000
DHT: Propogate error if dht_rmdir_opendir_cbk
Earlier rmdir would succeed on all up subvols, but fuse would get an
error if one of the subvol was down. In follow up lookup, self heal
would be triggered, and since st_mode would be 0, the permissions
would be bad. The behaviour now is to fail rmdir if subvol is down
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2591 (Directories changing to d--------- permission after trying to delete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2591
commit 6f9f0e532b7fa9496023aac8aa4f502ea6e0fcce
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sun Apr 17 11:21:51 2011 +0000
cli: UI cleanup for geo-replication command
* provide a unified output in case of failure of geo-replication session
* provide a better formatting of the output geo-replication status command
* update the help option of geo-replication command
* fix few typos
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2536 (gsync service introspection)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2536
commit 06ad5e45e03b156a4c21a81fef184e1b71acfaad
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sun Apr 17 10:46:08 2011 +0000
cli: removal of dead code due to the code movement of geo-rep start from cli to glusterd.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2676 ([glusterfs-3.2.0qa7]: glusterfs server crashed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2676
commit 341538b6243513dd057242df9ee123fe8a974735
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sun Apr 17 10:46:07 2011 +0000
mgmt/glusterd : change of syntax of geo-replication command
master is referred as a volume name rather than a URL scheme.
old syntax:
> volume geo-replication start :vol-foo /bar/boo
new syntax:
> volume geo-replication start vol-foo /bar/boo
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2786 (Having to prepend geo-replication master vol with colon spoils the UI)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2786
commit 4b719892edf9522e22dcbd298e082405b49e29e6
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sun Apr 17 10:46:06 2011 +0000
mgmt/glusterd: unify the geo-replication status rpc messages.
the intelligence of determining the type of status command is now at glusterd,
rather then explicitly setting it while parsing at cli.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2536 (gsync service introspection)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2536
commit d130955c937a79e6828275d76be9ce1c4c8d0305
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Apr 17 04:45:59 2011 +0000
syncdaemon: minor cleanups on termination
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2736 (gsyncd hangs if crash occurs in the non-main thread)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2736
commit 0e5e376f509540ee0454b7a255646adf695a006e
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Apr 16 16:04:27 2011 +0000
glusterd/volgen: make it possible for builders to set the op_errstr during graph validation
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2559 (provide two options in CLI for gluster volume gsync indexing <volname> <enable|disable>)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2559
commit 3bc74ae1a5b21c718769bd06e84df8670b5d11ef
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Apr 16 13:36:04 2011 +0000
glusterd: some cleanups needed for 70adbe7b [refactor gsync_status() ...]
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2780 (geo-replication operations take too much time to complete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2780
commit 46c25c9ec665940555da09f368ccb7f110509a74
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Apr 16 04:13:35 2011 +0000
cli: check for connectivity before doing mount
in quota limit list.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2732 (Quota: the local mount on server fails while using quota list command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2732
commit 31942252bd29d70c01db56274d27b3823bab6781
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Apr 16 09:31:24 2011 +0000
marker/quota: use correct byte ordering when updating parent's size.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2649 (Quota: size field is not getting updated properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2649
commit 081d35eb060db8fc3a09d547012f904e7d5028c5
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Apr 16 09:45:49 2011 +0000
marker: avoid memleak by unrefing dict, fd and local
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2784 ([glusterfs-3.2.0qa13]: memleak in marker)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2784
commit 9a38e49910a7e19ec612cfbf5de864e0355d8a0c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Apr 16 10:03:53 2011 +0000
features/marker-quota: fixes in self-healing of dirty inode code path.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2649 (Quota: size field is not getting updated properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2649
commit d0c16635cb62795a94a208406d19a83b5ebe605c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Apr 16 10:07:29 2011 +0000
extras/quota-xattr-cleanup: don't follow symbolic links.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2664 (Quota: recreating the volume on same bricks shows similar info as for earlier one using "list")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2664
commit 5f4b4c82f9971108b57017db437202d8a62b2ea8
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Apr 16 10:32:54 2011 +0000
glusterd: refactor gsync_status() so that we can get at the pidfile
This is useful for iterated polling of gsyncd's status, without having to
incoke gsyncd to find out about the pidfile.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2780 (geo-replication operations take too much time to complete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2780
commit 030b613bb33bc5fb91eb65109239be4481456ebd
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Apr 16 10:32:53 2011 +0000
syncdaemon: load xattrs from libc on-demand
This reduces startup time for invocations other than master / slave role
(kind of which now proliferates glusterd)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2780 (geo-replication operations take too much time to complete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2780
commit ad354aa7860e6525be617e1a4a88832942efa081
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Apr 16 06:05:31 2011 +0000
quota: do not assign frame->local to NULL which leads to memleak
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2772 ([glusterfs-3.2.0qa12]: excessive quota local NULL errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2772
commit 4014610f852b8f9b50a715ff48e6def505f06c57
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Apr 16 05:23:58 2011 +0000
quota: assign local to frame local to prevent memleak
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2772 ([glusterfs-3.2.0qa12]: excessive quota local NULL errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2772
commit 826a8d66606238f70d2e7a9f625d1bf83113a31c
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Apr 16 00:48:46 2011 +0000
mgmt/glusterd: Fix percentage latency formula
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2783 (Fix percentage latency and precisions of profile info)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2783
commit 5d0f522ebee33b8c8c1e8749ce4d97f256b4c504
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 15 22:58:12 2011 +0000
mgmt/glusterd: Send the error msg to user if gsync start fails
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2781 (geo-replication start error message)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2781
commit 3cf104006edeb24d5d7152acf6d33266d5cb2883
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Apr 15 22:05:21 2011 +0000
features/quota: set 'frame->local' to local in fsync
so fsync call can succeed
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2772 ([glusterfs-3.2.0qa12]: excessive quota local NULL errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2772
commit 50ff77228ad17a1f4dd9082267d8f8af293528cb
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 15 09:10:03 2011 +0000
syncdaemon: yet another try to exit properly
The final cleanup sequence + call to _exit, which was just done in the main
thread, now is called for in each thread when the thread crashes. Seems we
aren't left there hanging this way.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2736 (gsyncd hangs if crash occurs in the non-main thread)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2736
commit 7ca2d2da1eb3e99b892784c446ff13d3e4c45683
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 15 09:10:02 2011 +0000
syncdaemon: when getting a single config option, don't display the option name, just the value
This intends to ease scripting (you can just pass on the value to xargs etc.)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 794510a95cfcdff7146e525e09d7a88ea7f68fa1
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Fri Apr 15 09:15:23 2011 +0000
mgmt/glusterd: does not allow disabling of indexing (xtime marking), if a gsync session is active.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2559 (provide two options in CLI for gluster volume gsync indexing <volname> <enable|disable>)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2559
commit 6ea0bc864911d121ecba33d0c18c8dccdd4fc3f4
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 15 07:00:42 2011 +0000
mgmt/glusterd: handle error condition in quota fs crawl
Quota enable starts a crawl on the maintenance mount point, but if the chdir to
the mount point fails it will start the crawl on '/'. So the child should exit
with EXIT_FAILURE when the chdir fails.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2770 (Handle error cases in quota fs crawl)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2770
commit 5696c56e0511acd3142b827714f7704e39e814c0
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Apr 15 07:56:47 2011 +0000
TOP: validate bs/count pair for write/read-perf measurement
If either one the above args are supplied, the other arg should be
supplied too.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2771 (bs or count tag missing with volume top write-perf/read-perf command blocks glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2771
commit 6984ab24c2bd068b8b557514574574dd71857de5
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Apr 15 07:05:38 2011 +0000
cluster/stripe: aggregate xattrs holding quota-size in lookup and getxattr calls.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2760 (Quota: stripe volume not showing the quota size properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2760
commit 4679485645c9451cea2dd64638866e4b79418af8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Apr 15 07:05:24 2011 +0000
features/quota: use disk usage instead of file-sizes.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2760 (Quota: stripe volume not showing the quota size properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2760
commit 4041fa469ab4ee5a8f65f2f9a35307c895d26246
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Apr 15 07:05:10 2011 +0000
features/marker-quota: Use the actual disk-space consumed instead of ia_size returned in iatt for calculation of sizes.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2760 (Quota: stripe volume not showing the quota size properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2760
commit e9b3c32111152817e53661acdc36e49beb911d50
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Apr 15 14:02:39 2011 +0000
mgmt/glusterd: fix double free.
- the limit-usage string should be stored as static, since remove-limits will
be modifying it and probably freeing it.
- this static string should also be explicitly freed in glusterd_quota_disable
since dict_del won't free it.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2776 (gluster quota remove crashed glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2776
commit 36a82d6b23ff2b5919da4d090b6856786310f512
Author: Krishnan Parthasarathi <kp@gluster.com>
Date: Fri Apr 15 01:00:56 2011 +0000
top: Modified integer bounds check for count/bs
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2721 (Incorrect validation message in gluster top CLI)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2721
commit d2e183f0e7b1e18b173324e81fcf2b12d72c96f6
Author: Lakshmipathi <lakshmipathi@gluster.com>
Date: Fri Apr 15 05:08:47 2011 +0000
rpm : create new package for geo-replication and preserve symlinks
Signed-off-by: Lakshmipathi.G <lakshmipathi@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2744 (make geo-replication package friendly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2744
commit 38151dfa297ab9b133e62fff63c0624fb4237c8d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 15 02:55:46 2011 +0000
mgmt/glusterd: Memory leak and message cleanup
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2764 (Cleanup memory leaks seen in quota and gsync code paths)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2764
commit 23c2847e088273fd5655ea1bdcceaff7ec6c9559
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Apr 15 02:49:51 2011 +0000
DHT: Make assert-no-child-down a boolean option
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2765 (geo-replication should have mercy on brick failure)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2765
commit 7e18d5974ee772edda4f8812a45e8e42320bfc5b
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 15 02:26:24 2011 +0000
syncdaemon: name tempdirs used by gsyncd more characteristically to ease debugging
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 477f0c93ef62534ced16badd277a1cc71d344028
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 15 01:48:36 2011 +0000
glusterd / geo-replication: have gsync's glusterfs client use assert-no-child-down for dht volume
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2765 (geo-replication should have mercy on brick failure)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2765
commit 625bf9c8fc7e74c6f0479cb7fb883d75fb021e23
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 15 01:09:01 2011 +0000
glusterd / geo-replication: set location of ssh keyfile for gsyncd
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2756 (support for providing custom ssh private key)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2756
commit b9c1e0ef061b88d52207acf613453aca5c700564
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Apr 14 16:35:02 2011 +0000
glusterd/volgen: partially revert 50ab0ad4
Moving the adjustment of marker's timestamp file to generation
phase was not correct, as generation should be side effect free.
Moved it back to the point where volfiles are written.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2529 (Starting Gsync causes ENOTCONN to glusterfs client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2529
commit eb525f30b80e94248f21a4c4a150df109dbb7e92
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Apr 15 00:58:00 2011 +0000
use "geo-replication" all over as the official name of this feature
Use GEOREP macro if you want to refer to the feature in code.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2757 (refactory gsync/gsyncd/syncdaemon/whatever to geo-replication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2757
commit f87b902bb330c0d20b3cd97b5b2ea44be67c8498
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Apr 14 16:35:00 2011 +0000
glusterd/volgen: refactor some things
- use macros for exported volume tunables
- introduce glusterd_volinfo_get_boolean as retrieval of boolean
optuions was a recurring pattern and became somewhat cumbersome
Also fixed illegal access to volinfo dict.
@pranith: use always the glusterd_volinfo_get* API for that purpose
so that defaults are taken to consideration.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2757 (refactory gsync/gsyncd/syncdaemon/whatever to geo-replication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2757
commit 2333ac3b0cc59ed9b2203a466c83b1847e731a79
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Apr 14 16:34:59 2011 +0000
syncdaemon: split gluster_command to make it possible to set options for glusterfs
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 7600182e529e7f395d17959da71358e6af32c8ea
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Apr 14 16:34:58 2011 +0000
syncdaemon: work around python feature of allowing double leading slashes in canonicalized paths
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit f0eb30e92affafda505cc96949bfad61a3f1089a
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Apr 14 11:53:12 2011 +0000
mgmt/glusterd: restart gsyncd on glusterd restart
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2761 (Restart gsyncd processes on glusterd restart)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2761
commit a230805a495c7d353461e33b29a7c2a349504fcf
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Apr 14 07:04:20 2011 +0000
features/marker: fix the excessive logs in marker
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2754 ([glusterfs-3.2.0qa11]: excessive logging in marker)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2754
commit ca2cd96edd67fab0cf2371391bce7d9bd089989c
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Apr 13 00:29:16 2011 +0000
cli: add log file for cli instead of '/dev/null'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2737 (there is no log file for gluster cli)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2737
commit b109e103a67a31735d1c4aef0c42186f67b0584b
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Apr 14 04:31:22 2011 +0000
mgmt/glusterd: Prevent dict unserialize for buf with 0 length
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2753 (perf-test failed with "buf is null!" message)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2753
commit e32a4345396730cdd1d526e3f4e08f17c92b45a6
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Apr 14 05:10:34 2011 +0000
quota: resume the stub when its not NULL
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2758 ([glusterfs-3.2.0qa11]: symlink hangs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2758
commit 37929b421abb95fc43c661b28bd3b3f244a3d364
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Apr 14 04:21:48 2011 +0000
DHT: Add xlator-option assert_no_child_down
If this is set, when CHILD_DOWN event is received, call exit
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2536 (gsync service introspection)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2536
commit b5dbec6b161ec8ce3e183e5105cd4e16ececd483
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Apr 14 03:45:20 2011 +0000
cluster/afr: Avoid null dereference
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2750 ([glusterfs-3.2.0qa11]: nfs server crashed in afr_sh_entry_expunge_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2750
commit 202ad0ac19cb04a9edbea5a8b17afdff0ad360e4
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Apr 13 10:23:03 2011 +0000
marker: pass cookie properly while filtering quota xattrs.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit bef5414d8ec4a42599bb331f496dcd3f9bea0f17
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Apr 13 23:30:22 2011 +0000
mgmt/glusterd: fail the volume stop opeeration if Gsync sessions are active.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2751 (Volme stop must not be proceeded if gsync sessions are active for the volume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2751
commit a63388278115a1ee949c8baa0dbf3f8e6388f67a
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Apr 13 22:14:37 2011 +0000
mgmt/glusterd: Implementation of volume gsync status [master [slave]]
Changes made in the path of gsync start/stop as well, where we
maintain a list of active gsync sessions, hence gsync stop could be
executed at all nodes.
A new dict in glusterd_volinfo_t added to maintain an active list
of gsync slaves running on each master.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2536 (gsync service introspection)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2536
commit 332f349f433834d14b398587d8fc67b7ccc581ae
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Apr 13 10:37:31 2011 +0000
quota/(f)truncate: pass correct delta for updating parent sizes after successful completion.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2741 (Quota: new files not getting created even if space is available)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2741
commit 5a35011813dfd8941ce538f9ae751326bd13302b
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Apr 13 01:13:56 2011 +0000
mgmt/glusterd: check for 'peerinfo->mgmt' before accessing it
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2728 ([glusterfs-3.2.0qa11]: glusterd crashed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2728
commit 9a04720905b82ba9653b2272cd0656b62eb0c7b8
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Apr 14 00:05:39 2011 +0000
glusterd: Respond to cli with empty iobref is serialize fails.
This usually happens if the size exceeds 128k. Earlier the cli used
to hang if the response exceeded 128k size.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2725 (volume top displays "error" for path max)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2725
commit 646ec89d5cfeb1315b3b8d40e17d2739fad941c8
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Apr 14 01:08:22 2011 +0000
mgmt/glusterd: Handle the features/quota for quota
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2540 (quota enablement yields bogus client volfile)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2540
commit 1d49c18eedc41fc558905bdb3e94d5480aaeafa6
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Apr 13 05:13:19 2011 +0000
glusterd: report the user if disable quota is given on already disabled quota
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2620 (CLI improvements in quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2620
commit 775fc5347499276a481f2df478e95f9d88f66ee6
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Apr 13 07:36:14 2011 +0000
PUMP: initialize loc at declaration
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2726 ([glusterfs-3.2.0qa11]: glusterfs server crashed due to stack overflow)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2726
commit d49a313d1cf842f5e849f8a9a221ee32517dba16
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Apr 13 07:36:13 2011 +0000
mgmt/glusterd: server graph should have io-threads below pump
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2726 ([glusterfs-3.2.0qa11]: glusterfs server crashed due to stack overflow)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2726
commit ae32bdba83d011fda521029d71b7616a151ee1cd
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 13 01:46:10 2011 +0000
cli: simplfy gsysnc configuration command
New syntax is
volume gsync config <master> <slave> [[!]opt [val]]
In details:
- instead of "volume gsyncd configure M S config-get-all" :
"volume gsyncd config M S"
- instead of "volume gsyncd configure M S config-get O" :
"volume gsyncd config M S O"
- instead of "volume gsyncd configure M S config-del O" :
"volume gsyncd config M S !O"
- instead of "volume gsyncd configure M S config-set O V" :
"volume gsyncd config M S O V"
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2738 ("volume gsync configure <master> <slave> config-<subop> ..." is overly verbose)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2738
commit 25377460ed317a52e8e2de2e9328449481de92c4
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Apr 13 01:46:09 2011 +0000
cli: join value arguments of "gsync config-set" with spaces
When a given gsync tunable is supposed to hold a command (which
can take options), it's quite possible that it spaces in its value.
Try to approximate this situation by joining the leftover arguments.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2713 ([glusterfs-3.2.0qa10]: config-set works only for one value)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2713
commit 5bb1cc4e7160740e1b10930afa3d2e90daeb8c8f
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 13 01:46:08 2011 +0000
glusterd: sanitize gsyncd config option validation
- rely on --config-check functionality of gsyncd to find out if option exists
- maintain a list of those options with which we don't want the user to fiddle with
(glusterd internals imply these so it' just the proper component for it)
- fail if user does a set/del on these
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2659 (gsync config-del option is not working properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2659
commit 60acbe2c43d86cb26aa5915faeae88b9bb168094
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 13 01:46:07 2011 +0000
syncdaemon: ensure -/_ invariance in tunables, in all components
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2659 (gsync config-del option is not working properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2659
commit fa175a091e063be6f44432c3e1e120cf75136dbe
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 13 01:46:06 2011 +0000
syncdaemon: refactor gsyncd.py cmdline interface to configuration
- existence of given tunable is checked
- add --config-check option to just do a check for existence of tunable
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2659 (gsync config-del option is not working properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2659
commit e9c07243897642e6763ecc1cdf79085080b56911
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 13 01:46:05 2011 +0000
syncdaemon: force termination for unhandled exception in any thread
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2736 (gsyncd hangs if crash occurs in the non-main thread)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2736
commit d39b29be8672dda516fa8a3d1750ae341a7fb9c9
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 13 01:46:04 2011 +0000
syncdaemon: streamline user-visible messages (and control flow a bit, too)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2644 (no volume-mark, if the behaviour persists have to check if master gsyncd is running.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2644
commit 92697cc7d1367ce50ea2d7c03d01ec4152c69532
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 13 01:46:03 2011 +0000
syncdaemon: fix parsing of the volume-mark structure
The parsing error implied that all xtimes were considered to be valid,
regardless of the volume mark.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2535 (gsync cascading)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2535
commit b2c37b291687e738054b53e9c351bdbd1caa3121
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 13 01:46:02 2011 +0000
syncdaemon: return exit code properly
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit e13e3afc1d07f96470c7498c672e4749b56f86f0
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 13 01:46:01 2011 +0000
syncdaemon: fix pidfile deletion on failed pidfile acquisition
(not triggered in glusterd instrumentation of gsyncd as glusterd does pidfile
probing by itself)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 51712ace6a7c0b93ed8f00d3c7ee2221d7cf7788
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 13 01:46:00 2011 +0000
syncdaemon: minor fixes
- whitespace fix
- remove superfluous imports
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 298a24f7733bf1198aa8ba81716ef218533d3c30
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 12 01:21:57 2011 +0000
mgmt/glusterd: Remove excessive INFO logs
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 94a1db2aa2598cc84b84a60e115d991db9a46442
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 12 22:40:14 2011 +0000
mgmt/glusterd: log stats commands to cmd log
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2735 (log stats commands (top/profile) to cmd log)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2735
commit c2fea001f44b9595868a50b40bbf8828b1e8a047
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 12 07:17:44 2011 +0000
mgmt/glusterd: volume reset force implementation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2729 (Implement force option for volume reset)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2729
commit f5bd24e54f188bd8a3b286a6ca10b0e2b36492fc
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Apr 12 09:00:02 2011 +0000
features/quota: update quota-limit stored in directory contexts after reconfigure.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2604 (Quota: crossing the set limit)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
commit 3950938895db4d4bf93b60678615a885d196b0b5
Author: Junaid <junaid@gluster.com>
Date: Tue Apr 12 10:01:28 2011 +0000
features/marker: Filter the quota xattr's on getxattr with NULL name argument.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit c8ccc7cadfe95b115fc3ec70af130f9a3568bb46
Author: Junaid <junaid@gluster.com>
Date: Tue Apr 12 12:03:06 2011 +0000
features/marker: Call update txn when the directory size and its contribution are not same.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 6667178833ed7b0b9bc37e0460880967d73b557a
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Apr 12 10:30:24 2011 +0000
remove excessive logs due to log enhancement
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 1a48ca5575c1e77159bb673b90e84ba322145800
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Apr 12 04:00:35 2011 +0000
script: fix the typo while doing replace brick
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1436 (script for running basic gluster commands)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
commit 4d1f07ff7ed070940e63b7ea9baa354147ba0a18
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Apr 4 14:50:11 2011 +0000
declare favorite child as int instead of unsigned int
In afr_private_t structure favorite child is declared as unsigned int.
In init function of afr we set favorite child to -1, if that option is
not found in volfile. But favorite child value will be set to a huge
value instead of -1 since it is an unsigned int and in statedump file
favorite child value is displayed as a huge value instead of -1.
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2668 ([glusterfs-3.2.9qa7]: createbench error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2668
commit 3809b90fcc561ac7acecb1c6e43c08c7fa5a4076
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Apr 12 14:22:15 2011 +0000
libglusterfs: Check for null dereference in statedump
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2731 (coredump when process state dump command is issued immediately after mounting fuse client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2731
commit e8c34285e016f4e3b55ee4feaed0f85f3629553f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 12 10:03:52 2011 +0000
cli: Fix typo in top help string
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2719 (Incorrect help string for volume top)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2719
commit 8f34e039beacb6a2f5564a021d0bea79fb5fb802
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Apr 12 09:20:53 2011 +0000
features/quota: check for proper return value in case failure of dict_get_bin
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2723 ([glusterfs-3.2.0qa11]: glusterfs client crashed in quota_validate_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2723
commit 4db48109c9d14f76a6cbc3b6019afcaf4fc65b1c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Apr 12 09:17:55 2011 +0000
features/quota: add error checks for failure of quota_inode_loc_fill.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2727 ([glusterfs-3.2.0qa11]: nfs server crashed in quota_check_limit)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2727
commit 8ec0bf87df88a25ac93cebdc65dc8b29091dd40f
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Apr 12 09:07:57 2011 +0000
quota: assign frame->local to local before checking op_ret
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2733 ([glusterfs-3.2.0qa11]: nfs server crashed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2733
commit cf57c761533c8c640aef520b7ad5782a36ecd1be
Author: Junaid <junaid@gluster.com>
Date: Tue Apr 12 08:19:27 2011 +0000
features/quota: Validate the quota options. and donot include into the client volfile.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2541 (insufficient option validation in quota translator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2541
commit c1b80f45b048651d84260a17bfce7ad9a5dd170a
Author: Junaid <junaid@gluster.com>
Date: Tue Apr 12 05:06:03 2011 +0000
features/marker: Adding NULL checks.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 02c666c053f3ca20e372058fb4e53a5176a748dc
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Apr 12 05:02:00 2011 +0000
protocol/client: convert to errno before checking for EAGAIN
in *lk_cbk() functions. Network error code may be different than
what is actual errno code.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 2184f51bbca28c03b16c6bd007d228140ed609a8
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Apr 12 05:00:18 2011 +0000
protocol/client: fix the fd_count decrement logic
the error creeped in during some code cleanup and logging enhancement
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1761 (incorrect self-heal behaviour when files are deleted)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1761
commit cb578e5ec91bafa0e0de18d3b822ad19bd699a27
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Apr 12 02:47:45 2011 +0000
temporary workaround for mtab update race thingy
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2690 (race between mtab updates of mount and umount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2690
commit 781db7bc52d5b497b4b41e104c40ac1e4c4ddd81
Author: Junaid <junaid@gluster.com>
Date: Tue Apr 12 08:11:32 2011 +0000
libglusterfs/dict: Donot perform NULL check on data in dict_foreach
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1816 (send volume options in friend add)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1816
commit 0881c3f6b18942fca0e3e9eddc895e6a6a8a7f24
Author: Junaid <junaid@gluster.com>
Date: Tue Apr 12 04:37:16 2011 +0000
mgmt/glusterd: Mount a maintainance client only on the glusterd which received quota enable through cli.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit f22de07fefd169672bf0ceaf8c31b9695af6e831
Author: Venky Shankar <venky@gluster.com>
Date: Mon Apr 11 05:48:36 2011 +0000
build fixes
Signed-off-by: Venky Shankar <venky@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2550 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2550
commit 6a26d544d312f28a4d74126a1cd487f89afbf3fa
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Apr 12 00:26:25 2011 +0000
mgmt/glusterd: Fix warning in glusterd build
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2718 (Fix warning in glusterd build)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2718
commit b9a50f76c7d807be544dd33ac6803ed7bfcb76c4
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Apr 11 03:19:25 2011 +0000
libglusterfs/src: bring in VALIDATE_OR_GOTO to args
so we can capture places which are calling these function with
invalid arguments
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit fe4b5f75868b54a504bdfd425899c204ae976902
Author: Junaid <junaid@gluster.com>
Date: Mon Apr 11 11:32:39 2011 +0000
mgmt/glusterd: Quota client lazy umount.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2560 (Lazy umount should be done for the maintainance mode mountpoint)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2560
commit f8745f90dd462ab74547a4817c76023d13abbc30
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Apr 11 08:38:40 2011 +0000
mgmt/Glusterd: Do not disable marker on gsync stop.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2559 (provide two options in CLI for gluster volume gsync indexing <volname> <enable|disable>)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2559
commit 0d62c7c6171f63bd0635f9c86f43a610a2eeefb6
Author: Junaid <junaid@gluster.com>
Date: Mon Apr 11 07:13:40 2011 +0000
features/quota: Adding the option "timeout" to quota.
This option tells the quota translator when to perform the next aggregation.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit c54630b4aa229c05b25143bdd1e5faa75786b353
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 11 05:42:20 2011 +0000
syncdaemon: do not use os.getlogin() for getting the name of the current user
This function relies on the terminal (cf. getlogin(3)), which is not available if we run as daemon
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2712 (username resolution in gsyncd fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2712
commit f53d55d4caf44ca6d1203ab30ffdf53a4f2685d7
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Apr 11 02:25:18 2011 +0000
mgmt/Glusterd: logging of few commands in cmd_log_history
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2449 ([glusterfs-3.2.0-cisco1]: gsync commands are not logged in the cmd_log_history)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2449
commit a43499fa33de14a911c234ad31ae77d8df498811
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Apr 11 05:00:31 2011 +0000
marker: check the return value being less than zero instead of -1
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2711 ([glusterfs-3.2.0qa10]: glusterfs server crashed in marker_setxattr operations)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2711
commit 462b69fd10622734292af4344a36569d09e61888
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Apr 11 01:13:58 2011 +0000
features/quota: handle failed fops gracefully.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2701 ([6db2b422f05d0553d0a83af603ae4d176b41cbdf]: crash in quota_readlink_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2701
commit 8188cb652994040676bd8fea75e3ed738810ffbc
Author: Junaid <junaid@gluster.com>
Date: Mon Apr 11 01:15:53 2011 +0000
cli: Validating the cli quota options.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2612 (quota limit-set not in line with help)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2612
commit 535f2d05e521c7514887456d0d44f466f5a4f8fd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Apr 10 22:38:03 2011 +0000
features/quota: Add checks for any of the parents of file being NULL while checking limits.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2685 (nfs server crashed in quota_check_limit)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2685
commit ed84c0f248a9f4b316e0dacdacea1c99dcf71a64
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Apr 10 10:53:36 2011 +0000
features/quota: use signed type to store delta.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2604 (Quota: crossing the set limit)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
commit fbaf05904e8c8c090164bb880333c75c1ba850c9
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Apr 8 14:46:54 2011 +0000
buf and statpost should be checked for NULL before accessing it
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2701 ([6db2b422f05d0553d0a83af603ae4d176b41cbdf]: crash in quota_readlink_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2701
commit 0a131b13f5be5ad6b88df9971abd9755a2847506
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 11 04:09:17 2011 +0000
syncdaemon: fix transaction code
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2659 (gsync config-del option is not working properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2659
commit 09fcd75d01a8df716de0cd810c4cd60fe8df3b55
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 11 04:09:16 2011 +0000
syncdaemon: minor fixes
- fix yet another instance of calling exit (instead of {sys.,os._}exit)
- fix logging to stderr with "-" as logfile
- whitespace fix
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 9afffc8f8db0671bb108fbd71178e87cbcc22c9d
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Apr 11 04:09:15 2011 +0000
syncdaemon: fix setting None as new master
We checked for the event of a new master being adopted by:
- checking for state change in list of masters
- checking if our chosen master is a foreign one
and if these held, then wrote out the actually available master to config
However this was flaky: if
(1) native master changed
(2) there was already a foreign master adopted
(3) actually the master was not available
then we wrote out the None to config.
This could occur if:
- on syncd startup, native master just changes from None to the volume native
[implies (1)]
- foreign master adopted from earlier run via config [implies (2)]
- actually foreign master was not available [implies (3)]
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2670 (strange behaviour with intermediate-master and slave)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2670
commit b9234fa052a4e8704eded71b9d47732b3e84954a
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Apr 10 05:30:45 2011 +0000
protocol/server: prevent unnessary logs in INFO level
'op_ret == 0' in readdir() is a valid return code.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 7308a38ebbcc4cf0726448c5b44168226015c5b9
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Apr 10 05:06:04 2011 +0000
cluster/distribute: Account for the first lookup sent to check whether the path is a directory while aggregating quota-xattrs.
- The total number of lookups sent for a directory is equal to
(no of children + 1). Hence we should not aggregate the xattrs
from the first lookup.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2604 (Quota: crossing the set limit)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
commit cd001a0b47fc030016764e9ba136a8a7bd8cb2a1
Author: Junaid <junaid@gluster.com>
Date: Sat Apr 9 05:34:23 2011 +0000
cli: Cleanup the maintainence mount points used by quota.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2704 (Stale mount-points seen after execting quota list command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2704
commit 1bd078fc9e439f22dae2434a76d18c2f8f281af3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Apr 10 05:11:29 2011 +0000
marker/quota: use correct byte order while storing xattr values in backend.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2604 (Quota: crossing the set limit)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
commit 80b5413fcf4cb5e38feb55c7be1c35e1d37ea66b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Apr 10 10:55:08 2011 +0000
features/quota: Fix race-condition while resuming stub.
- call-stub is resumed in fops calling quota_check_limit and quota_check_limit
when validate_count is zero, indicating no pending validates. During
validates, validate_count was decremented in quota_validate_cbk, but check
for validate_count being zero was done in quota_check_limit (which is
called by quota_validate_cbk). Hence there is a time window b/w decrementing
validate_count in quota_validate_cbk and checking whether
validate_count is zero in quota_check_limit, during which if the
control is passed to code in fop checking for validate_count being zero,
same stub will be resumed twice - once in fop and once in quota_check_limit.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2686 ([glusterfs-3.2.0qa8]: nfs server crashed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2686
commit 54d95edd0fa2095292b80b590fd4edf00951bf82
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Apr 7 17:06:25 2011 +0000
DHT: send revalidate to all subvols and not just first subvol
Reverting commit 23d9783a192669b638d42b8dd127ad69ea36f950.
When first subvolume is down, mount point becomes inaccessible.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2532 ([glusterfs-3.1.3qa8]: bringing first subvolume down makes mount point inaccessible)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2532
commit 57b693ae88689722c83d400ddad7d1dc42c5f0e0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Apr 10 10:43:05 2011 +0000
libglusterfs/xlator: set THIS properly whenever some operation is done iteratively on more than one xlator in the graph.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand Vishweshwaran Avati <avati@shell.gluster.com>
BUG: 2683 ([glusterfs-3.2.0qa8]: glusterfs client crashed in reconfigure)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2683
commit 382f63392f5bf4d952c131590a941e7a56fee72e
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 8 02:50:03 2011 +0000
mgmt/glusterd: Fix op_ctx issue with replace brick
Replace brick recognizes command originator by the presence of op_ctx.
Brick op uses the op_ctx to collect the brick response on all the
machines in cluster. This patch satisfies both these assumptions to
make glusterd functional in replace-brick.
This is a hack for 3.2.0. Need to Fix the assumptions in later release.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2691 ([glusterfs-3.2.0qa9]: glusterd error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2691
commit 870755fd6b26c6984a9286a0b368d721730affeb
Author: Gaurav <gaurav@gluster.com>
Date: Fri Apr 8 00:54:33 2011 +0000
NFS : Exclusive create storing verifier.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2553 (NFS file create with Mac client and UNCHECKED mode returns "Operation not permitted")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2553
commit 6186f256bf1ff10b66d490f10986cc8f280962f1
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Apr 7 23:57:58 2011 +0000
features/quota: Add checks for any of the parents of file being NULL while checking limits.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2685 (nfs server crashed in quota_check_limit)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2685
commit 1b4c85837fa9ac8c35ba2f2ab5fd0383edacf931
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Apr 7 00:22:23 2011 +0000
gluster rebalance: don't move a hardlinked file.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2258 (enhance gluster volume rebalance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2258
commit 5768ee83efc4271095e80254b45c1f53b3b399b9
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Apr 6 05:46:44 2011 +0000
gluster rebalance: don't depend on the sticky bit for validating link file.
do the getxattr() with 'trusted.distribute.linkinfo' key, which
returns success only if the file has a link. With this we can preserve
the exact same permission as old file.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2530 (Rebalance not working properly (file permission issues))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2530
commit 5290d68908452db5952010dae7209e0d389ccc3a
Author: Junaid <junaid@gluster.com>
Date: Fri Apr 8 01:12:40 2011 +0000
features/marker: Synchronise the read and write of marker_local_ref.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2663 (glusterfsd crash with bonnie++ when marker is enabled)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2663
commit 41dee6de59895fe3461c351564c44d53f0fd7b66
Author: Junaid <junaid@gluster.com>
Date: Thu Apr 7 15:38:25 2011 +0000
mgmt/glusterd: Quota cli message improvements.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2620 (CLI improvements in quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2620
commit dae7c50cea763bb479943be04502d2d96f59939b
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Apr 7 21:11:15 2011 +0000
mgmt/glusterd: serialize the dict only if its not NULL
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2691 ([glusterfs-3.2.0qa9]: glusterd error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2691
commit 8883903917792494c863a62fc8a01a0c5ef1ceae
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Apr 7 09:41:47 2011 +0000
do not access the empty loc inode
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2611 ([glusterfs-3.1.0-qa5]: crash in quota_rename)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2611
commit c6ae1db0f73ae8ac38f942b190e8c36bafe69ab5
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Apr 7 07:44:51 2011 +0000
removed reference to GF_LOG_NORMAL
instead used GF_LOG_INFO, which is more standard log level.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2669 (RuntimeError: cannot recognize log level "normal")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2669
commit b864678808555e76b6c9cd579def0d00aa4a94d6
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Apr 7 07:10:42 2011 +0000
do not change the arguments of a function
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2685 (nfs server crashed in quota_check_limit)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2685
commit 5a7e83732427adf0c08af2da9e8392688f517bca
Author: Junaid <junaid@gluster.com>
Date: Thu Apr 7 06:53:27 2011 +0000
features/marker: Perform quota updation on rmdir and unlink by holding inodelk on parent.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2664 (Quota: recreating the volume on same bricks shows similar info as for earlier one using "list")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2664
commit d5801d746acbae452e507e912789c2fe41a78709
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Apr 7 06:40:47 2011 +0000
debug/io-stats: Fix races and performance issues in profile
Fix the race in update_latency and memset of interval stats.
Update fop hits and latencies only when both the options are set.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2636 ("profile info" lists 'nan' in latency when heavy i/o is running)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2636
commit a3f8c60b4028f89ccb6e582769a3fd0dcce002a6
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Apr 7 06:40:46 2011 +0000
mgmt/glusterd: Fix gluster-profile performance issues
Add count-fop-hits option to io-stats
use count-fop-hits instead of dump-fd-stats for profile
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2636 ("profile info" lists 'nan' in latency when heavy i/o is running)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2636
commit 014508ed15caba48a6638eb48ab1f93ba06ee61e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Apr 7 02:51:50 2011 +0000
extras: scripts to cleanup xattrs stored by quota.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2664 (Quota: recreating the volume on same bricks shows similar info as for earlier one using "list")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2664
commit c74d8383b955b3c84206bee9c72fc0eebde96345
Author: Junaid <junaid@gluster.com>
Date: Mon Apr 4 12:03:04 2011 +0000
features/marker: Check for NULL before dereferencing pointers stored in local.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2607 (Fileop fails when quota is enabled)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2607
commit ff9fa7264d92542b37e2f96a2cb456e0f64dd2f5
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sun Apr 3 12:01:41 2011 +0000
print the gfid of the inode for which dentry is not found
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2652 ([glusterfs-3.2.0qa6]: dbench keeps on running)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2652
commit 845a12b723794072b75e337ca386cafdfd5354b9
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Apr 6 12:41:12 2011 +0000
mgmt/glusterd: Reset context upon operation completion
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2650 (replace brick failed in distributed-replicated setup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2650
commit dfb8969cc6a69b958cd085728ca07c207142055d
Author: Junaid <junaid@gluster.com>
Date: Wed Apr 6 23:57:24 2011 +0000
features/marker: Check if gsync is enabled in getxattr fop before performing gsync related operations.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2681 (marker returns dummy data for volume-mark attribute if xtime is switched off)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2681
commit 818e8c916b7a15487cb3dd919b28dbd3698cf85f
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Apr 5 14:24:59 2011 +0000
check buf for NULL before accessing it
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2675 ([glusterfs-3.2.0qa7]: glusterfs client crashed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2675
commit 6540eb255691d8fc9e66dedef99d39e32e967283
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Mar 31 06:05:41 2011 +0000
check dict before unrefing it
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2642 ([glusterfs-3.2.0qa5]: invalid reads in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2642
commit 27016d73e578be472df1dd1595499bec5d97c528
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Apr 6 05:37:05 2011 +0000
nfs: convert errno EDQUOT into appropriate nfs-errno.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2607 (Fileop fails when quota is enabled)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2607
commit 32db99ccd1144623edf01ef8e31ad5e9e7ba697d
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Apr 6 00:59:04 2011 +0000
protocol/client: Avoid logging when EAGAIN is received for *lk requests
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 1887 (logging mess)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1887
commit 65516b5d9b43f5d2261972dd2fcc146513322d93
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Apr 5 10:22:57 2011 +0000
change occurrences of marker_gsync to marker-gsync
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit adf4be8be53f0357ddd24ab831827b7b7b545d27
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Apr 5 09:02:53 2011 +0000
features/marker, cli: use appropriate conversion specifiers.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2649 (Quota: size field is not getting updated properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2649
commit 9769b580ff8b93013c008c40f9a35be30312e94b
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Apr 5 04:00:26 2011 +0000
protocol/client: make sure to send only genuine events up to parent
that way parent notify logic is fine.
also, remove 'xlator_notify()' call in code, instead use 'default_notify()'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2584 (Inode number changes on a directory when one of subvolumes is down in replicate)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2584
commit 0fca08ce0e0ce7d057794677cf11fce443db2b91
Author: Gaurav <gaurav@gluster.com>
Date: Thu Mar 31 05:42:47 2011 +0000
NFS : Store verifier for exlusive mode craete.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2553 (NFS file create with Mac client and UNCHECKED mode returns "Operation not permitted")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2553
commit 296e4941539aa02c542c62c4f75d3e3957cf6015
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 30 00:03:59 2011 +0000
cluster/dht: send back the proper inode number in the cbk functions
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2584 (Inode number changes on a directory when one of subvolumes is down in replicate)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2584
commit b6b4dffb1d21df39c5788424c1910b2e97f52954
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 30 00:03:43 2011 +0000
cluster/dht: log level fixes in lookup* functions
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 91c0677180096c7693f7e242c0c93f4587a3054f
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 30 00:03:20 2011 +0000
log gfid mismatches for the same file in cluster xlator lookup
This can help in pin pointing some of the issues resulted in gfid
mismatch for the same file, which is harder to find through basic
debugging/logging of current codebase.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
BUG: 2346 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 770cda210547cb8f4e3717c6fecad8ec94826afa
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Mar 24 07:28:00 2011 +0000
cluster/afr: log enhancements - part 1
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@shell.gluster.com>
BUG: 2346 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 705c87256e4980469688f41e0c605b8653d84721
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Apr 1 03:00:04 2011 +0000
features/quota: use a double pointer to uint64_t as an argument to dict_get_bin while getting size.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2604 (Quota: crossing the set limit)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
commit b862b61aca82fcbeedadab6090932449514d43f5
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Apr 1 02:56:18 2011 +0000
features/quota: add NULL check before doing strcasecmp
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2646 (glusterfs-client crashes during getxattr)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2646
commit f3c7e5fa1b907e013fd1a25d433d1396a12f55ce
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Apr 3 15:44:17 2011 +0000
syncdaemon: refine intermal configuration of gsyncd
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2561 (gsyncd command's must be preconfigured)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2561
commit c7a93f063e833aed6df85f616da96424a5874dcc
Author: Csaba Henk <csaba@lowlife.hu>
Date: Sat Apr 2 19:40:49 2011 +0000
syncdaemon: add monitor mode to support autorestart
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2537 (gsync autorestart)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2537
commit 443c9ba6a00e0f3bb4069904accd614ae8d97436
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Apr 2 19:40:48 2011 +0000
syncdaemon: provide transactional semantics to config file writing
So updating the config file from multiple contexts won't mess it up.
This prepares the next commit where we'll set options internaly (which lacks
the serial nature of user actions).
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2537 (gsync autorestart)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2537
commit 09797a066e70f12646318c4bcf2cabd2a7742ac1
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Apr 2 19:40:47 2011 +0000
syncdaemon: give some refactoring to cascading code
- expiry check of foreign volinfo moved back to GLUSTERServer,
so that under the hood we can removexattr the expired ones;
a nice side-effect is that we can use the same dict layout
for foreign and native volinfo (ie., foreign needs no
timeout field)
- get_volinfo() is renamed to get_sys_volinfo() and most of the logic
is stripped off of it (what remained there is the check
against foreign master ambiguity)
- volinfo transition logic is cut out to an almost purely functional
static method (only impurity is the exeption raised upon
forbidden volinfo change)
- ping renamed to keep-alive, as something called "ping" is
not supposed to have payload (yeah, keep-alive is a bit fishy
on this front too, but could not come up with better...)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2535 (gsync cascading)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2535
commit 79f8aa09cfd0323d0d5126390bf11f6f3f8331a7
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 31 11:59:52 2011 +0000
syncdaemon; adding corresponding pcloses to gsyncd invocation via popen
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2427 (set a proper default for remote syncdaemon)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2427
commit d7fcdcb77fb866a2989ecf3b631658e9dff1faed
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 31 05:58:58 2011 +0000
syncdaemon: fix up fallback xtime value for slave
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2535 (gsync cascading)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2535
commit afa15c341f7a48c156323438641e2727207f7521
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Apr 1 03:44:02 2011 +0000
debug/io-stats: Fix bugs in re-configure options
If the options are not present in vol file reset the option values.
If there is an invalid option log an error and continue,
no need to exit
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2638 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2638
commit bffde83665be5ce50e9c8bed8c4ffd411c14942f
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Apr 1 03:24:12 2011 +0000
Replace strdup call to gf_strdup as GF_FREE is being called
Also, fix validation of bs and count to <= 0.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2645 (volume top write-perf results in memory corruption)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2645
commit 85c7ba185abc9781b9c8dd78a5ba986edee8ce6c
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 29 07:07:05 2011 +0000
cluster/afr: log enhancement - part 3
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 2bcf3b055e329aa66246f89602ada889b6ec66d6
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 29 07:06:45 2011 +0000
cluster/afr: log enhancement - part 2
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit c3e088817fe1e21145b987146132ed286e2bc8f9
Author: Anand Avati <avati@gluster.com>
Date: Mon Mar 28 09:30:38 2011 +0000
nfs: capture attrs of create request in cs->stbuf for later use
when attrs coming in as part of create request contain modes other
than mode, they were getting discarded previously and a setattr
was getting performed on a 0-filled iatt structure. This would
result in EPERM at the access control translator as non-root users
cannot chown a file to uid 0.
Not seen with Linux NFS client as it (very likely) relies upon
auth-unix to set the ownership of the file or sends an explicit
setattr after the create.
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2553 (NFS file create with Mac client and UNCHECKED mode returns "Operation not permitted")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2553
commit 8c68c038a38944b7e7e096aa8642dea927a7597c
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 31 11:59:51 2011 +0000
syncdaemon: fix gsyncd invocation for config-set
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2555 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2555
commit ef272b2f35c105c03dd33c5443457bed6972d658
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 31 08:13:31 2011 +0000
syncdaemon: minor cleanups in cascading code
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2535 (gsync cascading)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2535
commit e4a9ba80396450bea07acf587623396e99df6a27
Author: Vijay Bellur <vijay@dev.gluster.com>
Date: Thu Mar 31 22:11:00 2011 -0700
Revert "Process dir/link from other subvol if error in dht_readdir"
This reverts commit cd3d977b10e24c4b46e55f9831113aba3a241583.
commit 655d4f3db9fe6736ef1065bc5676a6e68b61517a
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Mar 31 04:57:22 2011 +0000
TOP: Improve output format
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2614 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2614
commit b9e543bab15fc2f18bee2fa7d479cb4fccb5bbc2
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Mar 31 04:57:05 2011 +0000
TOP: Validate command options
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2628 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2628
commit 30b06ef1453db9e6e1272729180af760d95f15ad
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Mar 31 04:56:10 2011 +0000
TOP: handle list-cnt behaviour uniformly.
Valid range is 0-100. if list-cnt is 0 or there are no files in the list,
handle it uniformly.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2622 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2622
commit 88592a49f505c51765edb4398a9926d1ec36a21e
Author: Junaid <junaid@gluster.com>
Date: Thu Mar 31 04:28:43 2011 +0000
features/quota: Use appropriate inodes while logging and create contexts in inode for files.
- It also fixes limit checks if limit set in the directory.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2604 (Quota: crossing the set limit)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2604
commit 25eaffafeb946539d2d8e9f85ff9cf4d929af760
Author: Junaid <junaid@gluster.com>
Date: Thu Mar 31 04:28:26 2011 +0000
features/marker: Fix memory corruption.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2629 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2629
commit 7cf1d0924d467e1f86c9cbdfc4353786e3a76ce1
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Mar 31 04:27:22 2011 +0000
mgmt/glusterd: Delete volume profile options on profile stop
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2638 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2638
commit 16802f074194356fcbaa75802b5fce72516abda3
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Mar 31 03:31:01 2011 +0000
mgmt/glusterd: Improve profile output messages
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2616 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2616
commit 2d084d4b4a5f3160fe823bb13a64dd5cff497504
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Mar 31 03:31:00 2011 +0000
cli: Improve profile output messages
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2616 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2616
commit 3fcaab270f050b52f326f8cd724cc4ce1059fa03
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 31 03:29:35 2011 +0000
syncdaemon: fix "--debug" option of gsyncd.py
also be explicit about logging to a stream (ie. don't rely on the feature of accessing
stdin through /dev/stdin)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2637 (gsyncd --debug broken)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2637
commit af98235a3d02186d4e297d5af6697df99faaf2c9
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Mar 30 23:47:59 2011 +0000
mgmt/glusterd: Fix space in error message
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2623 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2623
commit b686953288584d223c7fdfc38e8f32ee25aeaed1
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Mar 30 23:43:41 2011 +0000
mgmt/glusterd: Mark the brick stopped when kill -SIGTERM is done
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2621 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2621
commit cfe920bb6ae8550fd9594134eace9ee47ab9ad1d
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 29 07:06:26 2011 +0000
cluster/afr: white-space cleanup - part 2
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit d5873c73015339f277c268de067194bde71ddf49
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Mar 15 01:57:15 2011 +0000
nfs-rpc: Append replies to end of connection's txlist
..instead of prepending.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2491 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2491
commit 99623c3bcacff5e6ca84230f913f972a836e03a5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Mar 15 01:57:14 2011 +0000
core: Add list_append_init
To append to end of list, as compared to list_splice_init which prepends.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2491 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2491
commit 22662a4bb04bf4907d79ba14b90621baaac22b1b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Mar 15 01:57:13 2011 +0000
nfs-rpc: Exit txbuf transmission loop on EAGAIN
..instead of looping till the buffer is completely transmitted.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2491 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2491
commit d711d0eab4abb38621b281f24261fe5a0bb21a03
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Wed Mar 30 07:54:41 2011 +0000
return after stack winding instead of destroying the frame
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2624 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2624
commit ec92c6609f20ee232d3962fd7f19ce5bca44e40c
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Mar 30 06:03:06 2011 +0000
mgmt/Glusterd: prevent memory overflow
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2632 (possible memory overflow in one of the code paths in volume gsync stop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2632
commit c984f13e2bf2dbde2bdc74a350e81ea61814380f
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Mar 30 06:03:05 2011 +0000
mgmt/Glusterd: add pid extension to the pid file of the gsyncd
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2538 (pidfile naming)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2538
commit 55b29cc1801fd89c2a95ca10c66b275d8aa0ab9f
Author: Anand Avati <avati@gluster.com>
Date: Wed Mar 30 01:18:46 2011 +0000
nfs: more fixes to capture sattr for further usage
in
- mkdir
- mknod
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2553 (NFS file create with Mac client and UNCHECKED mode returns "Operation not permitted")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2553
commit 800aab95e4ad6c0d14df097636f642289a26666a
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 29 14:08:04 2011 +0000
assign local to frame->local before checking for error conditions
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2617 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2617
commit 811faaefd76c55b69d709eb5acd8644bb6845628
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 29 13:37:26 2011 +0000
access the proper loc structure when inode ctx get fails in quota
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2611 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2611
commit 313252259dcfb62ea6ba28023164985efad72b5b
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Mar 30 00:28:29 2011 +0000
io-stats list: init counter to 0 for counting members
By setting init the counter cnt to -1, we were loosing 1 entry when
displaying the list on the cli.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2606 (gluster volume top open lists only 99 entries)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2606
commit 60cf9df661efe05618b72d37fefc05e3dddb498d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Mar 29 14:15:32 2011 +0000
debug/io-stats: fix memory corruption.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2619 (Memory corruption in io-stats)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2619
commit 62f7f92007be4a0e314586588513f8328f6be474
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Mar 29 09:10:07 2011 +0000
Gsyncd: Cascading of gsync daemons
This patch allows the slave of a gsyncd to be started as the master of another slave gsyncd.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2535 (gsync cascading)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2535
commit cb07c38c8bde05e7c50ddfb6ef8a62b0dbaa285c
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Mon Mar 28 07:21:51 2011 +0000
mgmt/glusterd: Fix double free on quota limit-usage.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2595 (Quota: re-setting the space-limit crashes the glusterd on the same node)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2595
commit 83e1d8c5c6f796e01e51ec56ebd2ff7ac4d7a5d9
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Mar 28 04:32:32 2011 +0000
mgmt/glusterd: Add rpc-auth-allow-insecure option
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2582 (allow option to accept messages from insecure ports)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2582
commit c5bad48208ec69a0c86517731152dc6f09ca455a
Author: Gaurav <gaurav@gluster.com>
Date: Mon Mar 28 04:30:28 2011 +0000
NFS : Volume access option accepts only valid values.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2598 (Volume access option suceeds with any string value)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2598
commit 0a8419af877db341849931d8c3b028036a1bd326
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Mon Mar 28 04:04:55 2011 +0000
features/marker: check for op_ret before doing any operations in lookup callback
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2497 (client crashes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2497
commit a38f60578bd39acf572b4a58ddf7d91f29a8e816
Author: Pavan T C <tcp@gluster.com>
Date: Mon Mar 28 03:50:29 2011 +0000
Loosen restrictions on hostnames
Signed-off-by: Pavan T C <tcp@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2249 (Problems with hostname validation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2249
commit 47afa4c0cfdf7606f66f824a0cff40be2e874b14
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Mar 24 07:27:26 2011 +0000
cluster/afr: whitespace cleanup
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit d74cffbdffad31bfeb0c4df6f9cde5d3f821bf0b
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sun Mar 27 14:03:10 2011 +0000
check the local for NULL before accessing it
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2592 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2592
commit df630feca1b597bd884e0f3e9b9acd72bac7c2a2
Author: Pranith K <pranithk@gluster.com>
Date: Sun Mar 27 08:51:29 2011 +0000
mgmt/glusterd: Add the new volume only after all ops succeed
- Print errors to the user when any of the op fails in create volume
- Add the volume to the list only after all the ops succeed
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1888 (volfile generation error ignored)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1888
commit 51d9c53578d8c15bf55b731646bc350098cb3cc3
Author: Pranith K <pranithk@gluster.com>
Date: Fri Mar 25 21:43:44 2011 +0000
protocol/server: change allow_insecure option in reconfigure
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2582 (allow option to accept messages from insecure ports)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2582
commit 7ea9ec35b4643e908050ff38a694bcae4060c2d8
Author: Pranith K <pranithk@gluster.com>
Date: Fri Mar 25 21:43:31 2011 +0000
mgmt/glusterd: Provide volume option to allow insecure ports for server
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2582 (allow option to accept messages from insecure ports)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2582
commit ecd76f39cebb9cd5d62e09594f8d47f70d8f63c7
Author: Pranith K <pranithk@gluster.com>
Date: Fri Mar 25 21:43:17 2011 +0000
mgmt/glusterd: Allow insecure ports by default
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2582 (allow option to accept messages from insecure ports)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2582
commit 8730ffe1efaeddb524f775db870fecd15f781460
Author: Pranith K <pranithk@gluster.com>
Date: Fri Mar 25 21:43:03 2011 +0000
rpc: Don't warn on failure to bind to privileged port
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2582 (allow option to accept messages from insecure ports)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2582
commit 21a1c7e467c8d938237a55b3aa24f3e67a8b770b
Author: Pranith K <pranithk@gluster.com>
Date: Fri Mar 25 21:42:49 2011 +0000
rpc: Provide an option to allow insecure ports
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2582 (allow option to accept messages from insecure ports)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2582
commit 9582215584d8ca31b876f0427d2c6f02b3819e70
Author: Junaid <junaid@gluster.com>
Date: Fri Mar 25 01:49:07 2011 +0000
cluster/dht: Fix double freeing in quota aggregate.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit aaa0519dc404805d6c4374f3986060e22b65b963
Author: Junaid <junaid@gluster.com>
Date: Fri Mar 25 01:48:52 2011 +0000
features/quota: Return dynamically allocated address of local.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 53c5aa1a641e0b1da789b4e0a9fa45973489fef1
Author: Junaid <junaid@gluster.com>
Date: Fri Mar 25 01:44:20 2011 +0000
mgmt/glusterd: Fix double memory free.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit ba47a1707b75623484662aca8c6b95c8e494f411
Author: Junaid <junaid@gluster.com>
Date: Fri Mar 25 01:39:12 2011 +0000
features/marker: Handle fop's gracefully when none of the feaures are enabled.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2529 (Starting Gsync causes ENOTCONN to glusterfs client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2529
commit dfdf7a090e08889cfcdb649b24c566fc7af088f1
Author: Pranith K <pranithk@gluster.com>
Date: Wed Mar 23 21:44:13 2011 +0000
mgmt/glusterd: Avoid printing no-error message to user when op fails
- Prints the peer hostname/uuid where the error happened in case the
peer does not return an error string.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2585 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2585
commit e46a3d921b4f427acf9495e0df567273d70e924e
Author: Pranith K <pranithk@gluster.com>
Date: Fri Mar 25 05:58:35 2011 +0000
mgmt/glusterd: Fix import friend volumes
- Sync transport type of the volume
- Stop stale bricks
- start new bricks if the volume is started
- Restart/Stop nfs server based on the new information
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2549 (Quota[glusterfs-3.2.1qa3]: enable/disable crashes the glusterd on other node)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2549
commit 13e1fa868d0bd1a27eaeff25f7842a4514538232
Author: Pranith K <pranithk@gluster.com>
Date: Wed Mar 23 05:25:26 2011 +0000
mgmt/glusterd: fail create volume on create-volfiles failure
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1888 (volfile generation error ignored)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1888
commit c0be2bae6eeaf3008b8850aa934a2574ccda5007
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Mar 23 00:52:22 2011 +0000
Gsyncd: fix a typo for the command-line arg of gluster process
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 6fd55ab1b1ed28580cf0e86e3a5bfd842e6b5c6e
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 22 05:01:56 2011 +0000
send proper device id to posix while self healing device file entry
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2567 (self heal on device files changes the major and minor number)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2567
commit 544f533da9c2192541fce4f29e028038f7748d77
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Mar 22 04:43:56 2011 +0000
Process dir/link from other subvol if error in dht_readdir
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2137 (dhtafr - self heal after renaming directory)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2137
commit 9ef0362c63d076cebf8f398ef0ef06d9ceaa5fb9
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Mar 22 04:43:20 2011 +0000
Implement stripe readdirp fops
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2159
commit 645296dc7f391120144bac91920a244e0a3660c5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Mar 21 02:00:19 2011 +0000
nfs3: Flush file I/O call states on open failure
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2566 (NFS read hangs when arequal-checksum script is run)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2566
commit 8928f9664f73b79e686c51478b5762570b52060d
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Mar 17 19:08:49 2011 +0000
nfs: Remove redundant and erroneous check for create mode EXCLUSIVE.
nfs3.c/nfs3_create_common:
The if condition checks for create mode being EXCLUSIVE. However, when
create mode is EXCLUSIVE, this function never gets called (nfs3_create_exclusive is
called). Also, instead of checking, it actually sets the value of createmode (= instead of ==).
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2553 (NFS file create with Mac client and UNCHECKED mode returns "Operation not permitted")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2553
commit 9736e9e31adc864332d8a71565a304424306d444
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Mar 23 03:53:28 2011 +0000
Prevent deadlock in io-stats list management of top.
Senario: thread t1 has lock on the queue, and waits on the element lock to remove
it and unref it. Thread t2 has a lock on the element being removed from the queue,
but waiting on the queue on the list to update it.
The fix is to move list management to outside of the lock. Additonal to this change
is adding locks to ios_stat_ref
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2578 (Mountpoint hung while running the dbench)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2578
commit bc595b9be8bf887b632c38e6d7937b4c68a7f303
Author: Gaurav <gaurav@gluster.com>
Date: Wed Mar 23 00:50:17 2011 +0000
CLI : Validate options farmework.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2064 (NFS options are removed upon glusterd restart)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2064
commit 28a44f53ee6f9339344949111cd412d9904f340f
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 22 07:08:24 2011 +0000
do not check loc and fd since they can be passed as NULL only
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 5dfe65c754f88f70bfb99f5ed38cadb05d8c6eae
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Mar 22 06:30:44 2011 +0000
TOP: remove trailing '/' from brick path
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2573 (trailing '/' with brick name says "volume top unsuccessful" while running 'top' command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2573
commit ec5460979eb98b66d601d5d7e1650adaafd5a102
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Mar 22 05:20:01 2011 +0000
Moved stats cleanup to forget from unlink and rmdir
Additionally, replace inode_ctx_get with inode_ctx_del in cleanup
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2575 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2575
commit 5c5cf316447688bfe2cda6c177f8635e01508a4f
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 22 04:50:07 2011 +0000
free priv structure if something fails in init for locks
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 1295b685cec44840db41e75f962ce00397ffd63a
Author: Pranith K <pranithk@gluster.com>
Date: Fri Mar 11 05:02:15 2011 +0000
cluster/afr: skip openfd flush when the file is already deleted
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2497 (client crashes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2497
commit 27016d936a8c5487f6a89b9a99fd2e2bcfa61c92
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Mar 22 04:36:39 2011 +0000
features/marker: Donot fail init when both gsync and quota are not enabled.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2529 (Starting Gsync causes ENOTCONN to glusterfs client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2529
commit cb64deb7073b5e042f2993321ab0481ea048db01
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Mar 17 19:01:02 2011 +0000
libglusterfs/compat.h: Fix build warning in dirent_size().
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2550 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2550
commit 3e1ecae0b87faf6071badcef73de95c7a266b4e8
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 22 03:01:03 2011 +0000
remove the names from the log files
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2573 (trailing '/' with brick name says "volume top unsuccessful" while running 'top' command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2573
commit c694bac18e7635dd83fe8a6d284302f0ad763ada
Author: Pranith K <pranithk@gluster.com>
Date: Mon Mar 21 07:26:30 2011 +0000
cli: Fix memory leak in gluster profile
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2571 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2571
commit bf157dabadfc9c1c01d1faebb701f4ec4b6eec62
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Mar 18 00:41:08 2011 +0000
spelling errors fixed across the code base
recieve -> receive
maintainence -> maintenance
verison -> version
commited -> committed
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2262 (Spelling errors in source)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2262
commit d87c441d6aabf3cbdffe99332fbf26a350d6e124
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Mar 17 08:00:49 2011 +0000
man pages updated
Thanks to Divya MN <divya@gluster.com> for all the effort
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2444 (keep man pages upto date with new codebase.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2444
commit 0778d8ca4d043a6e4fa298ffa5fa31556988a81f
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Mon Mar 21 07:16:17 2011 +0000
mgmt/glusterd: Glusterfsd not restarted on changes to marker option.
Bricks are not restarted when some marker options are changed and the Marker
translator is included statically in the server volfile.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2529 (Starting Gsync causes ENOTCONN to glusterfs client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2529
commit 4ac625d36c952aabf036e846b582a4b571b4d786
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Mar 21 01:54:42 2011 +0000
cluster/distribute: aggregate quota-sizes in lookup and getxattr.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 320b898f1e5a033e7f57ff2da7f0801681e5d1a1
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Mar 21 01:54:26 2011 +0000
features/quota: Client side quota.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 7477c82c6bd20c783e3832924107fdb17804f745
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Mar 21 01:53:58 2011 +0000
features/quota: removed quota.c and quota-mem-types.h files.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit c0cd4e7511c737d8a7353b51eec64cd375c47d9e
Author: Pranith K <pranithk@gluster.com>
Date: Sun Mar 20 03:25:50 2011 +0000
mgmt/glusterd: Dont reset the port on brick stop
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2564 (replace brick fails on master)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2564
commit 7010d3b50ebd1ca41be68b5febedf5ea233d8541
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Mar 18 05:37:24 2011 +0000
Change NFS_PATH_MAX value to 4096
This is tmp fix for crash seen on solaris gnfs server is received path is
longer than PATH_MAX. On solaris default PATH_MAX is 1024, and linux default
PATH_MAX is 4096.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2476 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2476
commit d92e87ac0dedba6c26376af5364a79d0ce4000ce
Author: Gaurav <gaurav@gluster.com>
Date: Fri Mar 18 03:52:08 2011 +0000
CLI : Fix memory free for key_fixed.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2554 (Invalid memory access in glusterd.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2554
commit 25faeeb5f00bfe38b91b97dd6d2ea71ea0357eae
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Mar 18 00:56:14 2011 +0000
fuse: set 'graph->used' after graph change
Because in the current way, we have chances of changing the graph
to old one too. with this, we can control this.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2503 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2503
commit ec7596fc6a34429cccfbcc788e557d6a98d4bd0a
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Mar 18 00:38:36 2011 +0000
debug/io-stats: don't log the dangling volume message
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 2186a06c025355d02eae5b3482a03bd0fb15f465
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Mar 18 00:38:13 2011 +0000
libglusterfs: added graph id in logging
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit e713b61d13aac37159598bf8921b3a84ce5dc8b6
Author: Rahul <rahul@gluster.com>
Date: Thu Mar 17 01:55:43 2011 +0000
Added checks for fix-layout & migrate-data usage.
Signed-off-by: Rahul <rahul@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2547 (rebalance command usage and help mis-match)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2547
commit ccde1f302c4e5b29f796719873d7e09a43c74ef1
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 17 11:44:25 2011 +0000
Revert "syncdaemon: make /usr/libexec/gsyncd the default remote gsyncd (incomplete hacky quickfix)"
This reverts commit 8c801cfd05eb533ae64ea9f06e49e632955cf0c0.
The commit in question was just a temporary fix (which violated
component boundaries).
Since 9043b0f8 we don't rely on this fix.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2427 (set a proper default for remote syncdaemon)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2427
commit f705c77fd5a9a3fd222783e37cbc7a612be150a9
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 17 00:46:38 2011 +0000
syncdaemon: fix up exit value
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2380 (TypeError: 'str' object is not callable)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2380
commit 599cd6227d5226f06f67b32d3ba07df921bb12c8
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 17 00:46:37 2011 +0000
syncdaemon: don't try to set log level to None
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 2f72771afbffb8c4e634f3066f4eeed5e6b15cd9
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:38:49 2011 +0000
libglusterfs/src/*.c: log enhancement
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit dec62193c2e7ddf9b2f2b44804526ec969eba50d
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:43:33 2011 +0000
protocol/client: log enhancement
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 7fbb77579bad4ad1866c50cee3543c7b9450196c
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:43:27 2011 +0000
protocol/server: log enhancements
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 4726cf5d0d2bbe7ced0fb01e686d4da5a76554be
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Wed Mar 16 09:43:21 2011 +0000
protocol/server: White space cleanup and NULL check validations.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit c4a9dd2f2713b128aba9ae221c01ba5d1ce25f64
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:43:13 2011 +0000
protocol/auth directory updated with whitespace cleanup and proper logs
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 35da9e66dc900d688601225ab9fe3718efab481e
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:43:04 2011 +0000
cluster/dht: log enhancements
Signed-off-by: Shishir Gowda <shishirng@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit e981aa58c30334df0897066dbbd532fa64c6a3a6
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:42:29 2011 +0000
cluster/dht: whitespace cleanup
also fill tabs by spaces (untabify), and indent the code
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 0453d32648824be9bf9f5f4c409f3104453228f4
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:42:19 2011 +0000
features/locks: logging enhancement
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit ea762cbbfdc594dfadbee3e4f06b22f223f62159
Author: Pranith K <pranithk@gluster.com>
Date: Wed Mar 16 09:42:12 2011 +0000
features/locks: White space related changes to adhere to coding guidelines.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 697352ce1e35485216e9fac361aa87032cee0086
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:42:06 2011 +0000
features/access-control: logging enhancement
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 69dd2367e0d785902026e326fa737341c97d9b1e
Author: Pranith K <pranithk@gluster.com>
Date: Wed Mar 16 09:41:58 2011 +0000
features/access-control: White space related changes to adhere to coding guidelines.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit d718869d79622dd78f554e772fd3f5a4277c9bed
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:41:52 2011 +0000
performance/stat-prefetch: logging enhancements
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit ce9498035f6dbc6d75844111042cae6a22a9cfcc
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 16 09:41:44 2011 +0000
performance/stat-prefetch: whitespace related changes to adhere to coding guidelines.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 94481a2a3f9be49535bf32dfec80cfc2c529fde0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 16 09:41:31 2011 +0000
performance/write-behind: logging enhancements
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 3d89b5126dc23c2d4bcfb81c31bdf59a45e3df6f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 16 09:41:25 2011 +0000
performance/write-behind: whitespace cleanup.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 422751633872f08ad1a4ee884e0596110b2a0e52
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 16 09:41:16 2011 +0000
performance/read-ahead: logging enhancements.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 85298bd0627813b9342f617289dad44245165e89
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 16 09:41:09 2011 +0000
performance/read-ahead: white space related changes to adhere to coding guidelines.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 4627f748b5de502f76e3f275a364e7811baf7ba1
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:40:50 2011 +0000
performance/quick-read: logging enhancements
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 6a186f687ad479d19f3b8e0958720eba14276b0a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 16 09:40:43 2011 +0000
performance/quick-read: propagate errors during open back to actual fops.
- If open fails and there are any other fops waiting on that open, those fops
should also unwind with appropriate errors. Before this patch, irrespective
of success/failure of open, fops waiting on it were stack_wound and since
fd was invalid, they would fail with EBADFD errors. Due to this
actual error would've got masked by EBADFD.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit e95ec560229f23cab3291c71ebf1b24895ede5a2
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 16 09:40:35 2011 +0000
performance/quick-read: whitespace related changes to adhere to coding guidelines.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 8fc7c35545adce174464dce147630e7de0e5e6d3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 16 09:40:22 2011 +0000
performance/io-cache: logging enhancements
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit fc770f16a83e4da188b340de84cd96fd825a8e27
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 16 09:40:14 2011 +0000
performance/io-cache: whitespace related changes to adhere to coding guidelines.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit c868d6615fb68916c22e6f17f4a63c7580b89392
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:40:06 2011 +0000
rpc-transport: log enhancement
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit bf0ac8b3a3ea3396119d6cb51d0678e1babc5c2b
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:39:57 2011 +0000
rpc-transport: whitespace cleanup
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 2ccbbd9d9c0e52145c4759c734226a7dcb5c6c61
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:39:46 2011 +0000
rpc/rpc-lib : log enhancements
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 4937d7ab46cdd8178efc245ddb16980a77ac56e4
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:39:21 2011 +0000
glusterfsd: log enhancement
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 01d06b22c406acbbdfb222cd9d9c8596adadd66c
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:39:15 2011 +0000
glusterfsd: whitespace cleanup
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit af320202e943a6f00c9bb836b6bcd8b7ea9244a5
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:39:07 2011 +0000
storage/posix: log enhancements
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 087a70708c506415e62c788d87a853c4c2c66c0b
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:38:35 2011 +0000
libglusterfs/src/*.c: whitespace cleanup
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit d5ad5c1d5f0fe320b2d12d4f730ac4572d9824a0
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:38:56 2011 +0000
storage/posix: whitespace cleanup
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 5b1760a820a701f77047cba690a7022a5a559b28
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:38:28 2011 +0000
libglusterfs: all header files updated
* whitespace cleanup (M-x whitespace-cleanup)
* indentation fixes (M-x indent-region)
* replaced tab with spaces (M-x untabify)
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 50f675080e9a96f2c8f521fe6563bb03ef0bfe46
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:38:21 2011 +0000
libglusterfs: gf_log_nomem() and other minor updates
log will be done when the memory allocation fails, hence in code,
no explicit logs required for memory allocation failures.
also, if there are logs before actually doing a log_init(), they will
be logged in 'stderr'.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit cf4795231a78979cbd30f5d854cfed147569c384
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 16 09:37:55 2011 +0000
libglusterfs: logging/mem-pool section white-space cleanup
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit f24c76d0bdfd5a37c9fe756bcb0e35e665d0148e
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Wed Mar 16 13:11:45 2011 +0000
mgmt/glusterd: Use PATH_MAX for pid_file.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2534 (Glusterd crashes on gsync stop.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2534
commit e8dc0436a8169ca234c759251ff97741ec48bc89
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Wed Mar 16 12:59:54 2011 +0000
features/marker: Invalid option "marker", use "gsync" instead.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 0240a69ed1e75bf78c2e618fcadeb17832de270d
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Wed Mar 16 05:58:09 2011 +0000
mgmt/glusterd: Use dict_set_dynstr in place of dict_set_str.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 4d5e225196b342e1bc3769f7a7e81f450c4c7d1a
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Mar 16 03:35:46 2011 +0000
TOP: glusterd/mgmt related changes
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2516 (Implement gluster volume top command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2516
commit eff4f149b1be8dafc0aa4a60403b51aa316beee1
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Mar 16 03:35:16 2011 +0000
TOP: cli, rpc/xdr related changes
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2516 (Implement gluster volume top command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2516
commit 8afe12c23ff3d18023598133a0e9ce0f897223e1
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Mar 16 03:34:53 2011 +0000
TOP: io-stats related changes
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2516 (Implement gluster volume top command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2516
commit 438187bf46ae89904c5fb37675c26f75662ec6ef
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Mar 15 22:25:55 2011 +0000
features/marker: QUOTA related changes in marker translator.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit ecda7340c19e0effffb1db76e6975fb35b403249
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Mon Mar 14 22:22:04 2011 +0000
storage/posix: Added GF_XATTROP_ADD_LONG_ARRAY flag to perform 64bit xattrop operations.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 315c221c4ec3f1333816c032107fbf6b7b687889
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Mar 15 05:35:45 2011 +0000
mgmt/glusterd: QUOTA Glusterd related changes.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit f1a102ae346273efa99abfcde2fd9f3477c73511
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Mar 15 05:36:18 2011 +0000
cli: QUOTA cli related changes.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit 0e5265a1b672eac744a0b50dc652047ce84db154
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Mar 15 05:36:33 2011 +0000
rpc: QUOTA rpc related changes.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2473 (Support for volume and directory level quota)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
commit cf59431f1fb73b8b5dd98a2caec3638f4fab8851
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Feb 15 03:08:17 2011 +0000
features/marker: open the timestamp file with O_TRUNC to update the ctime
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2354 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2354
commit 2e60782f840d0bd42bef8258c3edbf3e86fa6a17
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Feb 15 03:09:02 2011 +0000
Revert "features/marker: Use touch TimeStamp file instead of futimens, to avoid the dependency of newer libc"
This reverts commit e045741f2bb75344a557cd618e1c7b1691238703.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2354 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2354
commit 7ccc967c2dcfc9d86e537f76a0fded92789b65fc
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Mar 14 05:36:16 2011 +0000
used S_ISVTX instead of 01000 in code for sticky bit check
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2369 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2369
commit a39840628b9b38bc6e1a1ebc0146f89f9787b873
Author: Pranith K <pranithk@gluster.com>
Date: Mon Mar 14 04:20:51 2011 +0000
cluster/afr: Fix wrong memory allocation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2517 (the size of allocated memory may be wrong)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2517
commit 562824f0ea480d0a6e14c5eb122b5b577efd9e87
Author: Vijay Bellur <vijay@dev.gluster.com>
Date: Mon Mar 14 10:13:36 2011 -0700
Revert "Eliminate syscall tight loop when handling EAGAIN in NFS."
This reverts commit 689c1b5044e701e1b695a6e6c80647b9471ba454.
commit ea32e9c322078d081e4e9be025494a473ed8673a
Author: Vijay Bellur <vijay@dev.gluster.com>
Date: Mon Mar 14 10:13:08 2011 -0700
Revert "Make sure we are looking at the right errno in the fix for bug 2452."
This reverts commit dae57d72a58ff61fe6eda800d386bf83574ef5c2.
commit c72d3486cf6b96290908ec8675be43284d3acb24
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Mar 14 05:01:31 2011 +0000
mgmt/Glusterd: Make use of regexp pattern-matching sections to set a sane value for remote-gsyncd
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2427 (set a proper default for remote syncdaemon)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2427
commit cca398ac63bf7aaeac47505829a8d0f6a33b0a5f
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Fri Mar 11 07:57:52 2011 +0000
Gsyncd: Explicitly mention the path for the gsyncd.py script
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2437 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2437
commit a24b6be271cda115b33f3b2d0bd6effbcd84d019
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sun Mar 13 23:10:14 2011 +0000
Gsyncd: Include a directory glusterfs in the libexecdir, so that it is not cumbersome with other scripts
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2477 (Cleanup up the installation of geo-replication scripts.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2477
commit 39c4ffb6fea826eaac96c0be2839904998f2f45f
Author: Anand Avati <avati@gluster.com>
Date: Thu Mar 10 03:21:21 2011 +0000
afr-entry-self-heal: fixes to detected renames (gfid based)
- perform expunge first (before impunge) to be able to delete renamed away files
- perform readdirp instead of readdir to get gfid along with entry names
- if gfid mismatch is found, expunge the entry
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2500 (Self Healing not working)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2500
commit e47fd78ec2b56f24850d25b968a0345106a42425
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sun Mar 13 23:33:13 2011 +0000
mgmt/Glusterd: remove the checks performed for all ops in brick_op
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2427 (set a proper default for remote syncdaemon)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2427
commit 4cc60f5b6071a39d553bbc3844e528c4eb4307b6
Author: Pranith K <pranithk@gluster.com>
Date: Thu Mar 10 21:49:04 2011 +0000
mgmt/glusterd: remodel glusterd store
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1754 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1754
commit 955459e019793a294e7dbd4e54a3deec082f12aa
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Mar 12 01:08:34 2011 +0000
rpc-transport/rdma: handle cases where peer is NULL in send_completion.
- There can be valid cases where peer is NULL - For eg., race b/w pollin
received on handshake socket and as a result transport getting disconnected
and handling of a send/recv completion on the same qp for some previous
read/write - in send/recv_completion_process. Hence we should be checking
for a valid peer pointer before accessing it.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2514 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2514
commit 860932717a8bf0ade2f050f90cf2735ca1538d0e
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Mar 11 01:48:57 2011 +0000
nfs-rpc: Fix order of freeing request and connection objects
..to prevent segfaults due to double frees and dereferencing of freed
up memory.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2504 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2504
commit f28fbeecadca75849c4ac69148eeddd39370c6b6
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Mar 11 04:32:20 2011 +0000
posix: Set op_errno to ENOMEM on failed iobuf_get
This prevents a situation where op_ret for the read fop is
-1 but the op_errno is still 0.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1977 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1977
commit d4dcee12f5c2dbd7228d2ea58df2b92386a71d4f
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Mar 11 02:21:10 2011 +0000
posix: Handle offset greater than file size of EOF determination
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1977 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1977
commit 96933e682bc6296a59e09a3db298ca5e5ef63ce5
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Mar 1 03:59:48 2011 +0000
syncdaemon: fortify handling of failed xtime queries
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit dd67c1d9b0400d2fec9e2d1b0ed9c3cfa0f04f9c
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Mar 9 07:14:54 2011 +0000
do not access the inode while doing statfs in trace
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2502 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2502
commit 489fc76ad59637bf523c6fea31e1edd2312c8cae
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Mar 9 06:16:45 2011 +0000
mgmt/glusterd: mem-factor added as an option
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2501 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2501
commit 7b418c85674533abbb8299eb25433555083ce3b1
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Mar 8 02:06:22 2011 +0000
Fix solaris build failure in latest git
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2440 (Fix solaris build issues seen on latest git)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2440
commit 1cb2210da11c831d6ed498e837f8e02ba69364e6
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 8 01:07:26 2011 +0000
gluster rebalance: set the proper permission of the file
remove the sticky bit from the mode.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2369 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2369
commit e544d3835c52d3e6d17655cd71932960f96e78a0
Author: Pranith K <pranithk@gluster.com>
Date: Thu Mar 10 02:20:39 2011 +0000
cli: gluster profile CLI
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1965 (need a cmd to get io-stat details)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1965
commit 2c9eca1edae1347d2008668326f1a7f911361f51
Author: Pranith K <pranithk@gluster.com>
Date: Thu Mar 10 02:20:20 2011 +0000
libglusterfs: Add sort routine
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1965 (need a cmd to get io-stat details)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1965
commit b313a143fbf4ac5f695c7df7359a1a77d203a45f
Author: Pranith K <pranithk@gluster.com>
Date: Thu Mar 10 02:20:00 2011 +0000
glusterfsd: translator info event handling implementation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1965 (need a cmd to get io-stat details)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1965
commit e060d3744a218456ddd05121f8862d30bebbded2
Author: Pranith K <pranithk@gluster.com>
Date: Thu Mar 10 02:19:39 2011 +0000
mgmt/glusterd: gluster profile implementation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1965 (need a cmd to get io-stat details)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1965
commit ae105b834bcd903f4192c9204d4178bff10f0d32
Author: Pranith K <pranithk@gluster.com>
Date: Thu Mar 10 02:19:20 2011 +0000
rpc/xdr: Add gluster profile and brick op structures
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1965 (need a cmd to get io-stat details)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1965
commit e6d602e211d71cdc964bbcb0476b663b0b819db8
Author: Pranith K <pranithk@gluster.com>
Date: Thu Mar 10 02:18:44 2011 +0000
debug/io-stats: Changes for handling gluster profile
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1965 (need a cmd to get io-stat details)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1965
commit cc248eeaf950a5773fd30d4f59b29e4d8907c740
Author: Pranith K <pranithk@gluster.com>
Date: Thu Mar 10 02:18:22 2011 +0000
rpc: Changes for handling unix domain sockets avoid race
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1965 (need a cmd to get io-stat details)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1965
commit 558f7ba8dc2e3bd0c83ce69c6fdfbd7796ce39d1
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:43:03 2011 +0000
syncdaemon: don't follow symlinks on entries query
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 026618ebabc09f250e42936557598dccc4765086
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:42:48 2011 +0000
syncdaemon: fortify purge implementation to not do silly things like following symlinks
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2377 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2377
commit 74647fa651732e45e48e273b02fee4e29e34be76
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:42:33 2011 +0000
syncademon: fortify handling of failed entries queries
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 44c2d27b657f5cc861d318552a52e3bba473efad
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:41:29 2011 +0000
Revert "syncdaemon: Syncdaemon should not crash on ENOENT while performing setxattr()"
This reverts commit d6407c59a4fd262749edd11ecb457b1e5be7a77a.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2342 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2342
commit f5f29bda8e5238da98914553e2cd978403780a67
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:41:10 2011 +0000
Revert "syncdaemon: Handling of deleted symlinks (of directories). When a symlink of a directory of master is deleted. The corresponding delete in slave is handled as rmdir() of the symlink assuming the file to be directory"
This reverts commit bee672e5f70b3c6712280130aeb61da0674add11.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2377 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2377
commit c87fab742c34d85f4c7c19e693e1d800a4205d12
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:40:52 2011 +0000
Revert "syncdaemon: Create conf directory if not preset"
This reverts commit 38ae1720be39b62a4f199aa5be4ac85948bc23f0.
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 55a7bcddfeb3993076689496dab5bd659048e34d
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:40:38 2011 +0000
syncdaemon: improve loglevel handling
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit e39e20bc1326d6887751a49eae38cf7572580e0d
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:40:21 2011 +0000
syncdaemon: ensure stdio is flushed before exit
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2427 (set a proper default for remote syncdaemon)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2427
commit 7b91c30bdd9746d6a0fa920c3f60745df2e2243d
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:40:05 2011 +0000
syncdaemon: add support from dumping urls in canonical and escaped canonical form
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit a6c3eed6a407885facdd212e0890d98a68ee3895
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:39:47 2011 +0000
syncdaemon: add versioning to config file
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2427 (set a proper default for remote syncdaemon)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2427
commit aa9d68e87de107422baf30670e5e70b8922b18ee
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 10 00:39:27 2011 +0000
syncdaemon: configinterface: add support for regexp based pattern-matching sections
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2427 (set a proper default for remote syncdaemon)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2427
commit a6646b4b898713f7131b6a9484ed63fee49a4988
Author: shishir gowda <shishirng@gluster.com>
Date: Sun Mar 6 22:14:32 2011 +0000
build fixes in mac os x
Looks good.
----- Original Message -----
From: "Amar Tumballi" <amar@gluster.com>
To: rfc@dev.gluster.com
Sent: Thursday, March 3, 2011 6:30:52 PM
Subject: [PATCH BUG:625] build fixes in mac os x
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 625 (Gluster Fails to build on OS X 10.6.2)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=625
commit f37298b8db4e566d39dbb4e2e78e4ee2e33e60f9
Author: Pranith K <pranithk@gluster.com>
Date: Mon Mar 7 07:23:51 2011 +0000
mgmt/glusterd: preserve delete volume payload structure for backward compatibility
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2494 ([glusterfs-3.1.3qa4]: replace brick and delete volume fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2494
commit 08884262c49eb16f2a57311ed2558f29ae511a17
Author: Pranith K <pranithk@gluster.com>
Date: Mon Mar 7 04:38:35 2011 +0000
mgmt/glusterd: reset pending count before sending the op
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2493 ([glusterfs-3.1.3qa4]: glusterd not reaching default state on errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2493
commit c9ccb1fdf18ff88ce2034126e14a495db84fc9d6
Author: Pranith K <pranithk@gluster.com>
Date: Mon Mar 7 04:38:15 2011 +0000
mgmt/glusterd: fix payload errors
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2492 ([glusterfs-3.1.3qa4]: gluster operations fail)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2492
commit ea151855e2d8b0d2da441cd1f75eb8ea180b6647
Author: Pranith K <pranithk@gluster.com>
Date: Fri Mar 4 02:41:35 2011 +0000
mgmt/glusterd: Handle race in peer connect and reverse probe
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2486 ([glusterfs-3.1.3qa2]: Core generated due to SegFault in glusterd_sm.c)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2486
commit 511ef5c619b82cf92c05dcc960fc7d69484be872
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Mar 4 02:22:37 2011 +0000
Solaris xattr support for symlink and special files.
Since glusterfs uses xattr for storing gfid, and xattr support for
symlinks and special files does not exist in solaris. The work around
is provided by creating hidden files under export directory on solaris
hosts only. the hidden files ares maintained in .glusterfs_xattr_inode directory,
and all xattr ops on symlink and special files are redirected to respective
inodes.
All dir entries with name starting as .glusterfs (GF_HIDDEN_PATH) will
not be shown in readdir ops.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2213 (Symlink fails with ENODATA)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2213
commit 35ad6da66b00dd02da892d3f36ba6692a91ee170
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Mar 3 06:22:59 2011 +0000
debug/trace: add logs for 'forget', 'release' and 'releasedir'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2332 (update 'debug/trace' to log gfid instead of 'ia_ino')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2332
commit 60346c524bd8b57dc6912c85b343d60b81f298c0
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Mar 3 05:47:33 2011 +0000
glusterd: check for the variable before dereferencing it
check if 'peerinfo->mgmt' is set (ie, handshake is completed), before
sending any request to that peer.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2486 ([glusterfs-3.1.3qa2]: Core generated due to SegFault in glusterd_sm.c)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2486
commit 01c32d55bbba1e37db47c1029a9bcaca38c64951
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Mar 3 03:43:06 2011 +0000
glusterd: handle a crash in dump_version_cbk (in handshake)
reset 'frame->local' to NULL before STACK_DESTROY(), which prevents
freeing of valid 'peerctx' pointer.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2485 ([glusterfs-3.1.3qa2]: Core generated due to SegFault in glusterd_rpc_notify)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2485
commit 4680b7448ec9e294b42222e4b6a30c27dd79b395
Author: Pavan T C <tcp@gluster.com>
Date: Fri Mar 4 01:44:22 2011 +0000
Make sure we are looking at the right errno in the fix for bug 2452.
Signed-off-by: Pavan T C <tcp@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2452 (Excessive CPU usage /very low throughput while using NFS mounts)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2452
commit 41625afb1e3d3b47cbcf27ea68bee638868b5503
Author: Pavan T C <tcp@gluster.com>
Date: Wed Feb 23 06:23:26 2011 +0000
Eliminate syscall tight loop when handling EAGAIN in NFS.
Signed-off-by: Pavan T C <tcp@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2452 (Excessive CPU usage /very low throughput while using NFS mounts)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2452
commit 71810b4e72f783e5d2566d323367cc2b4320d10d
Author: Gaurav <gaurav@gluster.com>
Date: Thu Mar 3 02:04:51 2011 +0000
NFS : Check for duplicate entries while filling up child_up array.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2483 (Showmount output is not consistent with exported volumes.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2483
commit 8cc094bec0bafd4d779b7bb7902002fdd445762a
Author: Rahul <rahul@gluster.com>
Date: Tue Feb 22 04:13:14 2011 +0000
Display correct usage of rebalance command when it is wrongly entered.
Signed-off-by: Rahul <rahul@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1922 (Volume not present wrong message displayed on command line)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1922
commit 9eb8ed2b48cf399cadaaa847ac166d62c0eb8b6f
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 1 06:55:03 2011 +0000
gluster rebalance: send the proper 'procnum' to glusterd
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2333 (make glusterd more rpc friendly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2333
commit a6eb86ab541f5e9747a8c4698c0daf70f32d616c
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 1 03:37:12 2011 +0000
gluster rebalance: give option to split the command
the 'gluster volume rebalance <VOLNAME> start' is enhanced with two more options:
* 'gluster volume rebalance <VOLNAME> fix-layout start' (for fixing layout only)
* 'gluster volume rebalance <VOLNAME> migrate-data start' (for migrating data only)
Also the old way of running rebalance in one shot will still work fine
* 'gluster volume rebalance <VOLNAME> start'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2258 (enhance gluster volume rebalance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2258
commit 61c1377cafe350ad382c1bb6b97ed0906d60a38d
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 1 03:36:45 2011 +0000
gluster rebalance: get the proper/exact error msg to cli
introduce a new field in XDR structure, and hence change the version
of program.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1922 (Volume not present wrong message displayed on command line)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1922
commit 69a4a19ec0bda3a9a90f247753784ec0f6b2db69
Author: Gaurav <gaurav@gluster.com>
Date: Tue Mar 1 06:02:52 2011 +0000
CLI : NFS disable option through volume set.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2094 (Need option to turn off NFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2094
commit 6145cb5788bfa96636029467e0e1d0e3341e1e93
Author: Gaurav <gaurav@gluster.com>
Date: Tue Mar 1 06:02:39 2011 +0000
CLI : NFS persistent local/global options.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2064 (NFS options are removed upon glusterd restart)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2064
commit 4a5e3c4f16ed355969a0614c18fa45208a32b34d
Author: Anand Avati <avati@gluster.com>
Date: Tue Mar 1 14:49:59 2011 +0000
rpcsvc: safe mem_put of req in nfs_rpcsvc_submit_vectors
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2481 (Crash in NFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2481
commit feb01dd5d760154aebf49653463b7c3652a54ffb
Author: Anand Avati <avati@gluster.com>
Date: Tue Mar 1 14:40:27 2011 +0000
rpcsvc: perform mem_put at the very end for safe unrefs
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2481 (Crash in NFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2481
commit 570e2b7e9b6e7d4d13a96d2bdef06df11755a832
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Feb 24 00:08:46 2011 +0000
Gsync : Do not expose volume gsync, when geo-replication is disabled
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit edd8aea211cfed07b747aa3222b8ee0239eee6cb
Author: Gaurav <gaurav@gluster.com>
Date: Mon Feb 28 22:40:46 2011 +0000
NFS : Send error reply on rpc decoding failure.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2436 (Not able to send error reply in nfs_rpcsvc)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2436
commit 2ba0da4eeef94c52e5be5c95a6eb7718f99183d2
Author: Gaurav <gaurav@gluster.com>
Date: Mon Feb 28 22:40:30 2011 +0000
RPC : Sending error reply on decodong failure.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2435 (Not able to send error reply in rpcsvc.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2435
commit 329bb0291a0e9c970e3c093ba1016c8c1a57ab85
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 1 02:10:15 2011 +0000
glusterd: remove rpc code from internals of glusterd
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2333 (make glusterd more rpc friendly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2333
commit 02b53fc2d3090502678daa2f5bcf6cecb1f30b06
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 25 08:38:44 2011 +0000
glusterd: separate out cli specific programs and mgmt specific programs
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2333 (make glusterd more rpc friendly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2333
commit 1fa082cdeb18f81e09319b9bddb76e9d18d9f569
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 25 08:37:21 2011 +0000
glusterd: dependency on 'priv->mgmt' completely removed
using 'peerinfo->mgmt' instead.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2333 (make glusterd more rpc friendly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2333
commit 2d666fbe41a8ef04a5ea6d80a616b1b6946d8641
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 25 08:35:36 2011 +0000
glusterd: keep mgmt program peerinfo specific
With different version of glusterd in different machines, its not
possible to support using just one mgmt program. Instead each
peerinfo structure should have its own mgmt programs, so one glusterd
can support multiple versions
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2333 (make glusterd more rpc friendly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2333
commit e37c762663e71975f83e3c52cf55424c5eb398ee
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Mar 1 03:16:29 2011 +0000
v2 Prevent removal of trusted.gfid xattr
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2461 (remove xattr of trusted.gfid succeeds)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2461
commit 834dc0e5f8e9e7c938ce5c3c1084a79030e8f1f8
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Feb 23 03:38:36 2011 +0000
mgmt/Glusterd: while resetting the volume options, the previous data structures w.r.t auth. must be deleted
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2374 ([glusterfs 3.1.2] gluster volume set auth.reject command failure on nfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2374
commit 9a5873325a4f6e111c5bd6ff6212bd13c0427d4b
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 1 00:49:19 2011 +0000
check for inode and path being NULL before copying them
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2463 ([7b07d444a77526f27f860210930bf1d4c7fbea9b]: ./autogen.sh crashes glusterfs in fuse_getattr or fuse_setattr)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2463
commit f7c102f57c3f12d4556bf50ca7ec72ce8c192dcb
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Feb 28 06:07:40 2011 +0000
Stop building uuid test program
Building tst_uuid.c results in a compilation error with -DDEBUG
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2447 (Enable assert () and memory accounting with DEBUG)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2447
commit 93070c8d848564b6b6e52677437acb222d5a2d25
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Feb 23 09:34:30 2011 +0000
rpcsvc: Handle more than one payload vectors.
- fops like write can recieve payload data in more than one vector. This can
happen with write-behind being loaded on client side.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2454 (rdma data corruption)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2454
commit 127b98059f66f63093a00ac160644a540d1ce2a3
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Feb 23 02:12:50 2011 +0000
if volume created is both of tcp and rdma type show it in volume info
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2294 (Currently there is no way through cli to make a volume listen on both the transports (socket/rdma))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2294
commit 0914d74fbd7f1e3ee2c335844ace65328c8100f4
Author: Pranith K <pranithk@gluster.com>
Date: Thu Feb 24 06:16:36 2011 +0000
mgmt/glusterd: prevent spurious cmd unlocks
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2460 ([glusterfs-3.2.0-gsync1]: gluserd crashed trying to access freed request)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2460
commit d25754e6e7c111721d3daea45ca3efe4b9f9feed
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Feb 28 00:25:05 2011 +0000
performance/io-cache: Whitespace cleanup
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 248269ec68323686ddbb44bb81dc3d7f183c47a4
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Feb 28 00:24:47 2011 +0000
libglusterfs/dict.c: Whitespace cleanup
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit f91131ccfc8f393c1388d62e9d54be551b3c009f
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Feb 28 00:24:27 2011 +0000
cluster/afr: Re-factoring code for alignment
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit b6a1117df0ab0e6a021c626beb354366d3628999
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Feb 28 00:24:00 2011 +0000
cluster/afr: Whitespace cleanup
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 374a11c10f2cd57e35ab6bf0a0e76f86df6f075d
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Feb 28 00:23:36 2011 +0000
libglusterfs/xlator.c: whitespace cleanup
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit d64f7e4e0ec9819753c872784ca0d5b448ea81a8
Author: Anand Avati <avati@gluster.com>
Date: Fri Feb 25 13:23:56 2011 +0000
dht: log filename on failed reavalidate
The previous log message is pretty much useless without the path
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346
commit 1d60e90b7af0e347a80068d977496a780c9104b2
Author: Lakshmipathi G <lakshmipathi@gluster.com>
Date: Tue Feb 22 08:29:07 2011 +0000
install gluster binaries under /opt/glusterfs/version with sym.link at /usr/bin
Signed-off-by: Lakshmipathi G <lakshmipathi@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2279 (rpm spec file changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2279
commit 20bc5b9806562d7d23ea0e483f20f0a66046fb9a
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Feb 22 06:40:18 2011 +0000
Solaris build fixes.
Including compat.h for definitions of IXDR_PUT_U_../IXDR_GET_U..
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2440 (Fix solaris build issues seen on latest git)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2440
commit b183d0dbf44b304b3b78bcf9d0cf25a54ae0d4f1
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 18 03:10:29 2011 +0000
man pages updated
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2444 (keep man pages upto date with new codebase.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2444
commit acddd64f60a0ad7cee88f1f77e56a18bd8b875a2
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Feb 22 05:25:30 2011 +0000
check the op_ret for less than zero in sp_create_cbk since posix can send negative values other than -1
posix can send -ve values other than -1 in create:
op_ret = setgid_override (this, real_path, &gid);
if (op_ret < 0) {
goto out;
}
In stat-prefetch we check op_ret only for -1 which results in function
proceeding and op_ret may become 0 due to other function calls in
sp_create_cbk, hence crashes in fuse.
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2409 (crash in stat prefetch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2409
commit 5102377aca8ddfdcc66080aa03d0c83660170c15
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Feb 22 05:25:11 2011 +0000
storage/posix: set op_ret to -1 when setgid_override fails.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2409 (crash in stat prefetch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2409
commit 81a0d14b35a0ce7f8c6824fe6f041bb74bb7e8a4
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Feb 18 03:37:50 2011 +0000
Solaris: disable cli support rebalance and replace brick
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2440 (Fix solaris build issues seen on latest git)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2440
commit 2b8be51df12f87fb61c5adb976578018f53a5fb9
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Feb 22 05:00:37 2011 +0000
send the CHILD_DOWN event also to fuse
and start the fuse thread in CHILD_DOWN event too.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2005 (Mounting Gluster volume with RO bricks hangs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2005
commit 0dd534ab87927b8fa426ea7aa2066f9801c94e27
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Feb 21 06:48:23 2011 +0000
log the total replace brick command received
Log the full replace brick command which says whether the command is
start/pause/status/abort/commit.
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1404 (need a dump of all the op/mgmt commands)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1404
commit 3b88608cf5b6585e809516888a28d69b50bd18e6
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 18 03:34:23 2011 +0000
glusterd/cli: option added to create volume with both transports
to avail the option, enter the volume create command with arguments
'transport tcp,rdma'
and while mounting, on the mountpoints which works on rdma,
do, mount -t glusterfs <IP>:/<VOLNAME>-rdma <MOUNT-POINT>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2294 (Currently there is no way through cli to make a volume listen on both the transports (socket/rdma))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2294
commit b8c2da9122e1668cba65146f1838617142a7deb5
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 18 05:18:20 2011 +0000
debug/trace: updated the logs to print gfid instead of 'ino' values
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2332 (update 'debug/trace' to log gfid instead of 'ia_ino')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2332
commit c369a97d6f55df9f3e294c0304094bab245bbf7b
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Feb 19 01:52:22 2011 +0000
glusterd: make it more RPC friendly
make sure each procedure has a actor associated with it.
that way proper versioning can be implemented in modules
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2333 (make glusterd more rpc friendly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2333
commit f1ba9933030b283fcb8cc54af33ae8471954c406
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jan 13 06:55:37 2011 +0000
fuse-resolve: correction in resolve logic
* bring in soft (gfid based) and hard (path based) resolving
* 'fd' resolving to new graph is not yet done.
* fuse-resolve works similar to server-resolve
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2281 (I/O operations exit when add-brick is done)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2281
commit a3f5ac60e3fa2b04a2704f8c12567937abd7141f
Author: Anand Avati <avati@gluster.com>
Date: Fri Feb 4 21:43:49 2011 +0000
dht: do not send revalidates to all subvols
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2450 (scalability enhancements)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2450
commit daea5b0dbd166f843edeaba46a7f5dbaba373580
Author: Anand Avati <avati@gluster.com>
Date: Fri Feb 4 21:43:19 2011 +0000
core: have framework for GF_EVENT_CHILD_MODIFIED notifcation event
If anything changes anywhere in the graph, all xlators know that
something has changed. Previously dht and afr would mask certain
events from propagating up. Now they forward GF_EVENT_CHILD_MODIFIED
event in those situations
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2450 (scalability enhancements)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2450
commit 1934ea8bdd5191a9573ab8c2c509a832f606ac0d
Author: Pranith K <pranithk@gluster.com>
Date: Mon Feb 21 04:02:24 2011 +0000
mgmt/glusterd: In store-retrieve exit with error message instead of crashing.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2066 (glusterd crashed while trying to restore volumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2066
commit 558508836409ce5402519b8101a9db9140a60511
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Feb 21 08:45:41 2011 +0000
rpc/rpc-clnt: don't use iobref passed from caller to hold iobufs required for building program and rpc headers.
- clustering translators like replicate assume iobrefs will be used as
read-only by lower layers and there by use the same iobref while
winding calls to multiple children. Since iobrefs can hold only limited
number of iobufs, this limits the number of children these translators
can have without overflowing iobrefs.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2157 (glusterfsd crash)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2157
commit e94fcbca7a21beec58963917a9e5d855c93b8878
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Feb 22 01:38:30 2011 +0000
free the tokens obtained from the cli
The cli command which is tokenized is not freed leading to a memory
leak.
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2113 (cli: memory corruption in add-brick and create volume parsing functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2113
commit ea990e4e30eb610e3f09e7dcf3fe5df4b07f87f6
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Feb 18 00:06:26 2011 +0000
Fix getcwd size arg to make it work in solaris.
glusterfs/d -f path failed if the path was not absolute.
If the BUF argument is NULL, then on solaris the size argument has to be passed.
On linux, if the size argument passed is 0, then it dynmically allocates a buffer
of the required size. The fix is to pass PATH_MAX as the size for consistency.
Signed-off-by: Shishir Gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2443 (starting glusterfs/d -f with relative path crashes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2443
commit 0dbc5cdb2acd6b6f2ee46c7d0a61950b00925b95
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Feb 17 07:31:18 2011 +0000
Solaris build fixes
Disable geosync build for non-linux platforms.
And fix solaris related build failures.The symbol getxattr was not
available on solaris. The build on linux passed as getxattr symbol was
available in the library. The argument was not being used, hence
removed it.
Make 64 bit build default in CFLAGS option by passing -m64 option
Signed-off-by: Shishir Gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2440 (Fix solaris build issues seen on latest git)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2440
commit 45687aef2bbdde06a61fd15caac94c6c2d877951
Author: Anand Avati <avati@gluster.com>
Date: Wed Jan 26 13:28:04 2011 +0000
replicate: set read-child to the subvolume which replied first (fastest)
In the old logic read-child was set to the last subvolume which replied.
Now it is updated to the first subvolume. This way we can ensure that local
servers are preferred for reads _most_ of the times.
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1172 (ls -lh on NFS mount of 2-mirror replicate gives incorrect file size)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1172
commit bffad3f8e4aa28ccd967331fa5d56e8c793ca2b6
Author: Anand Avati <avati@gluster.com>
Date: Tue Jan 25 15:03:52 2011 +0000
io-threads: use slow/normal/fast classification of fops
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2241 (GlusterFs Stat Actions Degrade During I/O)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2241
commit a1fcd4cddcfe9afcc6e95c168c1251ebb5276251
Author: Anand Avati <avati@gluster.com>
Date: Tue Jan 25 15:03:51 2011 +0000
io-threads: implement bulk and priority queues
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2241 (GlusterFs Stat Actions Degrade During I/O)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2241
commit 09f5a9a7b868483d116c6060a6ac952d54af6218
Author: Anand Avati <avati@gluster.com>
Date: Tue Jan 25 15:03:50 2011 +0000
io-threads: whitespace cleanup
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2241 (GlusterFs Stat Actions Degrade During I/O)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2241
commit 99b7fb58db979167254dba2af44995e328dbf80e
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Feb 18 01:27:31 2011 +0000
Validate peer probe command's hostname/ip address.
Note, if an ip octet range exceeds 255, though this fails as a valid
ipv4 address, it is still a valid hostname.
valid chars are: 'a'-'z', '0' - '9', '-', '.' with a max of 255 chars.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2194 (gluster peer probe on a ip octet value bigger than 255 has no validation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2194
commit 852094c21bdcb3e824bed12ec0f1b331adc0e202
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Feb 21 12:11:59 2011 +0000
libglusterfs: Enable assert() and memory accounting with DEBUG
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2447 (Enable assert () and memory accounting with DEBUG)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2447
commit 5af2e3619dc32b45d70c6fd5cecb31ca9ef5959d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Feb 3 01:56:28 2011 +0000
performance/quick-read: disable caching for fds opened with GF_OPEN_NOWB flags.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2240 (Solaris client hangs on file read operations)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2240
commit 37f052e9176144cd12c8fbd28b8df9277e09ce49
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 18 02:55:38 2011 +0000
cluster/dht : implement a fsetxattr() command
Thanks to Jeff Darcy <jdarcy(at)redhat.com> for the patch
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2319 (DHT uses wrong subvolume for fsetxattr)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2319
commit f402b688001e6da6d9a8748509a9419ad3031732
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 18 02:54:49 2011 +0000
rpc/xdr: update .x files
* now, 'rpcgen $filename-xdr.x' file will result in $filename-xdr.h
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2153 (glusterfs3.x does not match "generated" source)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2153
commit 0cf55514f4f5b0fbd6b14aa7b3bd9221f72efbc0
Author: Pranith K <pranithk@gluster.com>
Date: Tue Feb 8 02:22:52 2011 +0000
cluster/afr: stop spawning self-heal loops when the self-heal fails
With the current model of self-heal, any loop wont resume if a
self-heal failure happens. I have added the fix to stop spawning the
initial loops on self-heal failure.
Fixed the invalid read shown in valgrind in diff-self-heal.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1174 (Replicate spawns read loops even after destination fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1174
commit 7c811ee7abc3a78fc23ada9b9c0b8c0269102f8b
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Feb 17 19:18:12 2011 +0000
libglusterfs/dict: memcpy() data_t in unserialize.
This fixes a race in dht_getxattr() where the xattr dictionary
returned by one of the subvolumes can get free'd before STACK_UNWIND,
leading to applications seeing junk values.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2442 (getxattr() on a directory sometimes returns junk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2442
commit ac10a46732700a7405ec1d7802ff523fbb49e5a6
Author: Sachidananda <sac@gluster.com>
Date: Fri Feb 11 02:08:55 2011 +0000
Check correct variable after function call.
And some white space cleanups.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2410 (Wrong variable checked after a function call)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2410
commit d313a6b72877c9c6a3986074903ae4f696b00af1
Author: Sachidananda <sac@gluster.com>
Date: Thu Jan 27 00:29:21 2011 +0000
Typo fixes in log and cli messages.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2321 (Typo in logs and cli messages)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2321
commit 72a39a63cae8b197258c76ba3b952b3efc12178b
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Feb 16 01:48:03 2011 +0000
glusterd-volgen: fix a issue of wrongly closing '0' fd.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2421 ([glusterfs-3.1.2gsync10]: epoll_create returning 0)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2421
commit 7c87ff00a802a4b2b33ca7d6d20869d5f3a6443b
Author: Anand Avati <avati@gluster.com>
Date: Wed Feb 16 01:41:44 2011 +0000
volgen: avoid fclose() on cosed FILE *
It can so happen that a previously freed up FILE * structure has 0'ed
out memory and a second fclose() on it can result in close(0). This
results in bad bad things happening.
Signed-off-by: Anand Avati <avati@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2421 ([glusterfs-3.1.2gsync10]: epoll_create returning 0)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2421
commit a497d159aae08f74b780035591116a51a467049a
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Feb 15 18:01:54 2011 +0000
syncdaemon: fix RePCe version query
RepceClient.repce_version fetched its own RePCe version, instead of
querying peer, so lame.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2381 (RePCe versioning)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2381
commit c1e87bfe7877951ed3cdeb26d5242d70808f53ea
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Feb 15 11:34:51 2011 +0000
syncdaemon: Checking for the existence of gsyncd by trying to aquire a lock on the pidfile.
If the locking succeeds then gsyncd is not running and if it fails then it means
that gsyncd is running.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 220f0eeaccf300e62786344350d4fcfec7438c18
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Feb 15 10:52:32 2011 +0000
syncdaemon: change pidfile handling approach
Signal handling of the python interpreter is a bit messy, so we cannot
rely on executing a final clause upon termination. Switch over fcntl
lock based pidfile handling which can provide reliable info about status
of the process. (Due to aforementioned reason, pidfile as such is not
guaranteed to be cleaned up, but lock acquisition is a reliable measure.)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 770e6bede1f4b8c9ed32f50b43b9422cf02249f8
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Feb 15 08:58:05 2011 +0000
syncdaemon: Check for ctx context in the glusterd_op_stage_gsyc_set().
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 1e763ec25ab97a363783bb4d723abaff97eb1822
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Feb 15 03:08:44 2011 +0000
syncdaemon: set the default value of timeout to 120sec
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 8712872578d48676569f39c02cd313da6f794997
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Mon Feb 14 19:27:34 2011 +0000
syncdaemon: Moved the gsync start code to cli.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 1e94dce31827c9825bafb6c6dec5443e08bdd2d3
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Feb 14 16:43:36 2011 +0000
Changes to include geo-sync in spec
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 907789b394fd41aa31a3cc7a40cfceb1114c29bd
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 14 16:42:05 2011 +0000
syncdaemon: fix some pidfile issues
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 7b6719cfb28c6e108617e1e4fe584771cb453063
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 14 16:42:04 2011 +0000
syncdaemon: make /usr/libexec/gsyncd the default remote gsyncd (incomplete hacky quickfix)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2427 (set a proper default for remote syncdaemon)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2427
commit 3a7eea7b27af0cb52cf3d97f909f8160b80bf8d1
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 14 16:42:03 2011 +0000
syncdaemon: use "ping" message instead of "__version__" to wait for remote to come up
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2424 (Starting gsyncd with --debug : AttributeError: type object 'FILEServer' has no attribute '__version__')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2424
commit 6c1f8a08200f563092b02aae5ed19e6aa6bc61df
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Feb 14 13:33:00 2011 +0000
cluster/dht: Send removexattr() to all subvolumes.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2426 (removexattr is not sent to all subvolumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2426
commit c9805f14a0046ec343b610ac6007fdc47b4db5ec
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Mon Feb 14 01:01:19 2011 +0000
syncdaemon: config-get-all option add to gsync cli.
Signed-off-by: Mohammed Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 60c8b90002535303e527ef89e3b9b064721e663b
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 14 11:19:25 2011 +0000
syncdaemon: fix KeyError
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit e0b2514615da226a52fca3aa679dd2b0baa550a4
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 14 10:57:59 2011 +0000
syncdaemon: make configparser code work with all supported python versions
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit bb7275b340ae3565e0f047bbcd5701ad4c5c3d2d
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Sun Feb 13 03:46:56 2011 +0000
syncdaemon: Using /usr/local/libexec/python/syncdaemon as the default directory where the python scripts are installed.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 8c01e312c534809108e70aa48bc93eb604ad4434
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sun Feb 13 02:01:30 2011 +0000
syncdaemon: conf file to be read properly
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit e45ace0dcdfbfe9d418a6dc0d75459b6fa58b1cc
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sun Feb 13 01:58:09 2011 +0000
syncdaemon: Create conf directory if not preset
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 25212b4a1effdc82db97f2fecca545ba31a38ea9
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Feb 11 07:19:05 2011 +0000
fix a typo in xdr_gf1_cli_gsync_set_req function
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2418 ([glusterfs-3.1.2qa7]: crash in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2418
commit d48f9ea324e4165d55ae837ca372391735615b34
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Feb 11 07:06:52 2011 +0000
initialize the cli_req structure before sending it to xdr
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2418 ([glusterfs-3.1.2qa7]: crash in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2418
commit e28484ac9fc4c5fed1d4b4181e46eca91902709b
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Feb 9 08:15:59 2011 +0000
syncdaemon: Handling of deleted symlinks (of directories). When a symlink of a directory of master is deleted. The corresponding delete in slave is handled as rmdir() of the symlink assuming the file to be directory
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2377 (gsyncd.py RepceClient: call (symlink) failed on peer with instance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2377
commit 4ce47972cb396f6b3cf8e70a058721a6bb950fd5
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Fri Feb 11 01:06:55 2011 +0000
syncdaemon: configinterface.py file moved under xlators/features/marker/utils/syncdaemon/ directory.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 0155033a1502f860740403b9c37ac74b58334991
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Feb 9 02:12:59 2011 +0000
syncdaemon: Syncdaemon should not crash on ENOENT while performing setxattr()
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2342 ([glusterfs-3.1.2geosyncqa4]: crash in gsyncd script)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2342
commit 1634c48a4eef40d693caa2550d69cb6e59e5c604
Author: Gaurav <gaurav@gluster.com>
Date: Wed Feb 9 00:39:55 2011 +0000
NFS : Fail Nfs init if volume-id not found.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2124 (NFS crashes when volume-id option is not given with dynamic-volume option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2124
commit 907e2bd42b0977ee30e55ef2950065ed3a9f65db
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Thu Feb 10 05:29:34 2011 +0000
gsync: cli support for gsyncd.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 914e3bdaf07a11e186e2ccc5122e8328fb76b165
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Feb 9 06:11:02 2011 +0000
removed some of the stale scripts
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2393 ('gluster-volgen' and 'gluster-defrag' scripts are stale, but present in AMI)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2393
commit bb790ad26395a1d1f7a987eb025f817d1bd4ce7a
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 7 20:42:24 2011 +0000
syncdaemon: config revamp #3: implement command line get/set/del interface to configuration
The INI style config file has following type of sections:
- [global]
- [peers <local>]
- [peers <local> <remote>]
Option dispatch to sections is derived from command line (ie., [global]
if no arg given, [peers <local>] with <local> being the only arg,
[peers <local> <remote>] if <local> and <remote> args are provided).
So this all happens under the hood, gsyncd users need not to specify
sections.
New command line options:
- query options:
--config-get-all
--config-get OPT
- modify options:
--config-set OPT VAL
--config-del OPT
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 30869f3122b3c4c18ded7e871a340331473b0e8e
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 7 20:42:23 2011 +0000
syncdaemon: config revamp #2: implement canonicalized urls, use them in config file sections
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 2562223dcc6507de49f1a50f3b1da43e1c19e93b
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 7 20:42:22 2011 +0000
syncdaemon: config revamp #1: drop simplecfg, switch to stdlib's ConfigParser
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 49ebb4efcc6dcf8227c5b33c8467576075ae79da
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Feb 8 06:33:38 2011 +0000
syncdaemon: Removing the simplecfg.py entry from the Makefile.am, since it is removed.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 8e5d174fe3f242ee500c5271ccc830511436482b
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Feb 8 04:05:21 2011 +0000
features/marker: Use touch TimeStamp file instead of futimens, to avoid the dependency of newer libc
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2354 (handling futimens with older glibc)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2354
commit 07167a4cbdf5b72fd16faf1c90441aa84e543892
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 7 20:28:48 2011 +0000
syncdaemon: refine RePCe version check to tolerate difference in minor
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2381 (RePCe versioning)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2381
commit 3c612e1bf455222b19a706f87d687d8ad617f668
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Jan 28 03:34:05 2011 +0000
volgen: specify a mode argument for open(2)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2310 (georeplication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
commit 2214966da9df86a9f4463f8ca597e128ef07fd3c
Author: Pranith K <pranithk@gluster.com>
Date: Thu Feb 3 21:23:15 2011 +0000
cluster/dht: Perform self-heal as root
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2370 (cluster/afr: Perform self-heal as root)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2370
commit fda7b8cfdfbcc87f77a6cb7499b38c8c362408e6
Author: Pranith K <pranithk@gluster.com>
Date: Thu Feb 3 21:22:44 2011 +0000
cluster/afr: Perform self-heal as root
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2370 (cluster/afr: Perform self-heal as root)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2370
commit cdeeb825284d7fe0988cf5a963be66688e947b1d
Author: Pranith K <pranithk@gluster.com>
Date: Mon Feb 7 05:42:18 2011 +0000
protocol/client: decrement reopen fd count in cases of re-open errors
In post-client-handshake client tries to re-open files, dirs, but if those
files/dirs are already deleted when the brick is down the reopens
won't even get triggered. In those cases the re-open fd count needs to
be decremented to make sure the child up is triggered.
I have also made similar changes in all the error cases of re-open/re-open-dir
cbks. Lock recovery is already handling all these errors.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1761 (incorrect self-heal behaviour when files are deleted)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1761
commit 521d696470c90464b242336f65777c81a7d778d6
Author: Pranith K <pranithk@gluster.com>
Date: Fri Feb 4 01:12:31 2011 +0000
cluster/dht: restore attrs of dirs in self-heal
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2371 (dht: Set owners of directories after performing self-heal as root)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2371
commit 3fad4bbaeeb708837a58b4511dfb490cf2e71e5a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Jan 31 03:29:13 2011 +0000
rpc/rpc-clnt: don't access rpcreq after putting the struct back into mem-pool.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2335 (Segmentation fault in saved_frames_unwind)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2335
commit 3cab923e230aa7b3696f5759ae6eeca1379bc97b
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 4 01:29:08 2011 +0000
gluster rebalance: fix the permission issue of rebalanced files
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2369 (Rebalanced files written as root:root on any brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2369
commit c03bc394bee2643f5bdd83a3d00351c7c0ea7739
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 7 01:32:57 2011 +0000
syncdaemon: add "setattr" server method, needed to synchronize metadata of links/dirs
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2318 (gsyncd.py :chmod on directory not working)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2318
commit a87bd1f3c5f79ebe6830a06f2c50b9a415a4389c
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 7 01:32:56 2011 +0000
syncdaemon: fix broken symlink handling in "purge" call
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2340 ([glusterfs-3.1.2geosyncqa4]: crash in gsyncd script while posix compliance test was running)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2340
commit f37601aca4da69bedceaff9b41a2d588c5658c25
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 7 01:32:55 2011 +0000
syncdaemon: version the rpc
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2381 (RePCe versioning)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2381
commit 4db2ef7dbbcdc34f56532a674a1253021ed90735
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 7 01:32:54 2011 +0000
syncdaemon: improve program termination
- get rid of annoying "TypeError: 'str' object is not callable" message with python 2.4
- don't leave program hanging dead when failure is hit
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2380 (TypeError: 'str' object is not callable)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2380
commit f50e98660853ff07501fa7c34c7ab196ff2c91c1
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Feb 7 01:32:53 2011 +0000
syncdaemon: display slave role in log output
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2379 (master and slave log should be easier to distinguish)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2379
commit 2738584e60b2732214f5d0d8cee5923de4854570
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Fri Feb 4 11:22:55 2011 -0800
Revert "distribute: Return ESTALE when dir selfheal finds no fix"
This reverts commit a4c948aca6058049523e31acf33ce5770f8693ad.
commit 2b3c69b55da56f69fdf2fa6ea2eaea7788882cc5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Feb 4 03:14:37 2011 +0000
mount3: Do not return error when mount list is empty
An exports list can be empty when no subvolumes have come up.
No point returning error and confusing the user.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2345 (Taking distribute brick down returns 10006 error on mount command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2345
commit a3d44d74cf2a10a04bd7b919fb337334bbe9b692
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Feb 4 02:04:08 2011 +0000
nfs: Set volume started after root lookup succeeds
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2345 (Taking distribute brick down returns 10006 error on mount command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2345
commit af33ebe3be5ea78217a11e70cc10d2ea77ad420f
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Fri Feb 4 02:12:19 2011 +0000
marker: Updating the xtime marks on both the paths in rename fop.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2372 (marker: time stamp not updated with rename)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2372
commit ce40a777e01c078cc08ddb8024a3dca06531d6c5
Author: Gaurav <gaurav@gluster.com>
Date: Mon Jan 31 04:25:38 2011 +0000
Logging : Use of uuid_utoa and uuid_utoa_r.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2308 (Threadsafe uuid to string conversion function)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2308
commit e4841fbddc2ef07445549be44b26d78a0bc0ac0c
Author: Gaurav <gaurav@gluster.com>
Date: Mon Jan 31 04:25:23 2011 +0000
Logging : New uuid to string conversion functions.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2308 (Threadsafe uuid to string conversion function)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2308
commit b1bd5bb9c1a22b1f2bf4563ea007977ed5c350a5
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Feb 3 23:16:03 2011 +0000
libxlator: New policy for aggregation of xtime:
-Try to salvage errors like ENOENT/ENOTCONN/ENODATA,
-Propogate back any other error from any brick
-EINVAL if some assertion of the aggregation logic is broken
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2341 ([glusterfs-3.1.2gsyncqa4]: crash in gsyncd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2341
commit 5363a77f1d0297bd800d3e954dc07387c00b8a45
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Feb 3 23:15:17 2011 +0000
libxlator: memdup the data that is required for aggregation of attributes
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2339 ([glusterfs-3.1.2geosyncqa4]: crash in gsyncd script)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2339
commit c6fc353c24d61abe1f3e8b667971678b68d97f3e
Author: Pranith K <pranithk@gluster.com>
Date: Wed Feb 2 01:46:15 2011 +0000
cluster/afr: fix races in self-heal
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1188 (3.0.5 client crash - afr_set_split_brain)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1188
commit 5eac4889b7e46559b826d543b32adb198d370ba5
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Jan 27 02:50:38 2011 +0000
performance/io-cache: disable caching if indicated by NFS.
- wbflags - which contain flags to disable caching - passed by NFS were not
stored in local by ioc_open, there by causing failure of io-cache to
honour these flags.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2289 ([3.1.2qa3] EIO while reading & writing from a file concurrently)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2289
commit 1b88119173c0432590324fb4b5dc7acfe406086f
Author: Sachidananda <sac@gluster.com>
Date: Tue Jan 25 05:32:01 2011 +0000
Move hostname, ip address validating functions to libglusterfs.
hostname and ip address validation functions are duplicated in several
source files. Move them to libglusterfs.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2249 (Problems with hostname validation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2249
commit 9fd9ab19977031d4934b2f3f0a3631af3a3ab8ed
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jan 24 22:55:07 2011 +0000
use rpc_clnt_{new,start} (), instead of rpc_clnt_init();
to prevent a race between getting a CONNECT/DISCONNECT event before
registering a notify function
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2314 (notify function registration in CLI)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2314
commit d8ae6a40b74a5c17d8c8171a15743c8003b00d42
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Jan 19 02:08:48 2011 +0000
free GF_CALLOCed memory by GF_FREE instead of FREE
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit e296d7f6f0e8708ef2ad1abe106e0883ec0cf9e9
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jan 17 10:51:17 2011 +0000
glusterfsd-mgmt: handle the RPC_DISCONNECT event properly
This patch solves the issue of hanging mount point in case of wrong server name
is given during mount command
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1453 (mount command didn't give error message)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1453
commit 96cdac74985983451a9b38daf68a6f766956a373
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Jan 17 00:44:39 2011 +0000
remove op_errstr from glusterd_handle_rpc_msg as op_errstr is not used in that function
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1598 ([glusterfs-3.1.0qa22]: crash in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1598
commit a3da5440beec9c29b8e7359b813f71073a4bc307
Author: Gaurav <gaurav@gluster.com>
Date: Thu Jan 13 07:29:08 2011 +0000
cli: Show 'commit' option in replace-brick.
Signed-off-by: Gaurav <gaurav@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2273 (replace-brick help does not show commit option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2273
commit 4fbc446117d34f140bceaa975f4240173c3fefcd
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jan 27 05:23:35 2011 +0000
adding syncdaemon
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2310 (georeplication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
commit b23e55e7aedbbbd82c9d70c1909c166bb27681dc
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Jan 27 05:23:34 2011 +0000
mgmt/glusterd: restart bricks when syncdaemon is enabled
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2310 (georeplication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
commit 407dac9e90fe84931a92c4935be81a8f7aad6326
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jan 27 05:23:33 2011 +0000
volgen: add marker to brick volfiles
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2310 (georeplication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
commit 81dfa976e8deabcb3b02e515a19f39596f518599
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jan 27 05:23:32 2011 +0000
implement "--client-pid" option which can forcibly set the pid value in messages to a predefined value
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2310 (georeplication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
commit f5293deb6a1b0d8c37fc0c3943629ba3b66b9515
Author: Junaid <junaid@gluster.com>
Date: Thu Jan 27 05:23:31 2011 +0000
adding marker translator
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2310 (georeplication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
commit 9f8db6bcf684a6450dd183c81fee2a149c6b1fdb
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Jan 27 05:23:30 2011 +0000
adding libxlator, to ensure proper client side aggregation of marks by clustering translators
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2310 (georeplication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2310
commit 6e038782f8b84d0d8039f8fef26e4c9d7e47a102
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jan 24 20:35:44 2011 +0000
rpc: handle proper 'ref', 'unref' of transport from rpc-clnt
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2250 ([glusterfs-3.1.2qa2]: SegFault in rpc-clnt.c)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2250
commit 485c7c3163d3c61931f021d0b3e22525e233f3c8
Author: Pranith K <pranithk@gluster.com>
Date: Mon Jan 24 01:49:23 2011 +0000
features/access-control: skip access-tests if the call is from fuse
Fuse cant send aux gids. So access-control checks treat
non-primary-group membership of user as "other". So skip
access-control checks if the call is from fuse. We added a hack to
treat all calls with pid set to 1 as calls from nfs. So for calls with pid
not 1 we skip the access-control checks on all fops.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2296 (svn / subversion fails on gluster volume (replicated and non-replicated))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2296
commit d5a89fb63d1e7e3f9eded2fa89b65689f089c9fa
Author: Pranith K <pranithk@gluster.com>
Date: Wed Jan 19 01:49:05 2011 +0000
mgmt/glusterd: error out if remove-brick comes for final bricks
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2298 (removing the last pair of bricks from a volume results in inconsistency)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2298
commit e662d5c9f659dffb5c2a6f1438dfa4acfc5c46f6
Author: Pranith K <pranithk@gluster.com>
Date: Thu Jan 13 01:25:09 2011 +0000
cli: return error when cmd execution fails
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2287 (Gluster CLI returns wrong return code.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2287
commit 02c67b3b6deca914fd10f004f207c7df4e4cd54a
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Mon Jan 3 00:37:22 2011 +0000
protocol/server: Distinguishing the locks based on the type of fop like inodelk and entrylk.
Currently, the protocol server considers entrylk to be held only on directories
and inodelk on files and thus when a client unmounts itself while holding locks,
it fails to free entrylk locks held on files and inodelk locks held on directories.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2221 (Failed to free Inodlk locks on directories when the client holding the locks was unmounted before releasing the locks held.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2221
commit 6e5c586ef4f37f5b81569a12bb6f6b3918f6b29a
Author: Pranith K <pranithk@gluster.com>
Date: Fri Dec 17 02:53:15 2010 +0000
glusterd: de-register nfs rpcs when it is stopped
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1783 (kill glusterd and stop the cluster and start again - check nfs process)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1783
commit 105451f40adc79626ea911afe79b4927eef2576b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jan 13 03:38:51 2011 +0000
nfs3: Handle root resolution failures
..to prevent a second reply to the client which results in accessing
a call state structure that gets freed on the first reply.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2286 ([glusterfs 3.1.2qa3]: Crash due to corruption in gf_dirent_free)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2286
commit 5e3f7f9761f516a3ce92eeb70c5aba8889d45a7c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jan 11 23:31:40 2011 +0000
performance/quick-read: Fix unwinding of same frame twice when qr_loc_fill fails.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2274 (crash in fd_unref)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2274
commit aa49e28582409aa890d0e39476a1956390b9b431
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Jan 11 04:47:00 2011 +0000
mgmt/Glusterd: make nfs.mem-factor settable through CLI
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2277 (Regression in Gluster NFS re-read performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2277
commit aaecc5797facc06c247953a651c95c127303e6f8
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Jan 11 01:40:16 2011 +0000
nfs: Introduce tunable for memory consumption
NFS has used a common define called the mem-factor to determine
how much memory is allocated for the following items:
o inode table
o local structures used by nfs for storing fop state
o local structures used by nfs3 for storing nfs op state
These are all allocated through the mem-pool. The factor is multiplied by
a multiple that is specific to each data structure. For eg.
define GF_NFS_CONCURRENT_OPS_MULT 15
define GF_NFS_INODE_LRU_MULT 6000
The first value is used for allocating a mem-pool for storing
state for each fop or nfs op that is currently being handled. Knowing that linux
allows at most 128 in-flight requests, this multiple combined with the default
mem-factor of 15 gives us 225 slots in the mem-pool for the local structures.
Similarly, 6000*15 gives us a space of 90k inodes in the lru.
That means, increasing the common mem-factor will allow increasing the perf
under some conditions. This patch introduces the mem-factor as a configurable
option.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2277 (Regression in Gluster NFS re-read performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2277
commit d40b07702538b9bd96612cb09bec4f5540211b05
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Jan 11 01:24:02 2011 +0000
exit if the key or the value is null while retrieving the peer information in glusterd_restore
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2271 ([glusterfs-3.1.2qa3]: entry->hostname in glusterd_friend_find_by_hostname is 0x0)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2271
commit a3c04265ce3da4749c6b6655288d89c1dbac01b8
Author: Sachidananda <sac@gluster.com>
Date: Fri Jan 7 06:11:34 2011 +0000
Add corresponding va_end.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2247 (Add corresponding va_end)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2247
commit b4538e99b8ba35bbc6a52c76cff56e8ba3e8411a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Jan 7 00:45:48 2011 +0000
cluster/replicate: update st_nlink count of stat sent to application after completion of entry-self-heal.
- certain applications like 'find' use st_nlink count to optimize searches.
Hence an incorrect hard link count can result in non-healing of some of
the newly created subdirectories.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2187 (Self heal errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2187
commit 3a66de57bf66e6f983dace30c4841b9dbda2ab04
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Jan 5 07:02:14 2011 +0000
nfs3: Ignore requests for volumes without a single CHILD-UP
NFS ignores the requests for subvolumes on which child-up has never been
received.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2200 (cp dies with "Invalid argument" after failover)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2200
commit 469ab01774665f9cb4e5075dab8aa5716c2d771e
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Jan 4 03:15:35 2011 +0000
check the value of op_ret pointer not the address
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 762ebe9af8bd720004e1945d995efef37b75620e
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jan 7 03:49:24 2011 +0000
storage/posix: in opendir, allocate proper size for fd ctx pointer
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2280 (wrong size allocated for posix_fd in posix.c:posix_opendir())
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2280
commit 91c829bbcefe72be8e7235a272bc91f13cf10a7e
Author: Anand Avati <avati@gluster.com>
Date: Tue Jan 4 14:00:28 2011 +0000
logging: reintroduce build warning for mismatching format strings and parameters
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit db45260725296f618b960fbb8a658e719d4cc7b1
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jan 4 13:59:52 2011 +0000
logging: fix format warnings
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit fdc84ff7d424400ea6869f1cd7a2b637a3fec11b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Dec 29 05:42:02 2010 +0000
nfs3: Force root lookup before starting fh resolution
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2200 (cp dies with "Invalid argument" after failover)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2200
commit 3a40660cfa569e2b9b5f41c23c26633456b0fa6f
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Dec 28 01:14:19 2010 +0000
nfs/server: unrefing inodes on error in nfs_loc_copy ().
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2252 (unreffing of inodes not done when memory allocation fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2252
commit ea64e3f32bbde7fccdda3b96dafb662a6ccae195
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Dec 28 01:13:45 2010 +0000
xlator.c: Unrefing inode's on error in loc_copy.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2252 (unreffing of inodes not done when memory allocation fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2252
commit d90a09b3328f571243906a1797dc3588f2e1f852
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Dec 23 04:28:26 2010 +0000
nfs: Support subdirectory exports
Enable exporting directories as separate exports. Even though the directories
wont show up in showmount output, they'll still be mount'able.
The new option:
nfs.export-dirs <on|off>
is enabled by default so that users dont have to wait till this option
is incorporated into the gluster command line.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1743 (XenServer is not compatible with GlusterNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1743
commit 83b48dc4a83db620a0ebd27374b7d713ae75db24
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Dec 23 04:08:43 2010 +0000
afr_lookup_done: Propogate the same inode number as sent in first lookup
If only one subvolume was up, we used to unwind, without updating the ino
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2144 (errors removing directories when one subvolume is down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2144
commit e9a4d1c1cf1f20f8acfcc6747062723373febbde
Author: Anand Avati <avati@gluster.com>
Date: Wed Dec 29 12:23:08 2010 +0000
stripe: fix memory leak
destroy the frame copied and clean the local structure in stripe to avoid memory leak
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2253 (Memory leak in glusterfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2253
commit a204c72a85a3dc77d189eecb31ec35fb9807b7e3
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Nov 8 03:43:20 2010 +0000
quiesce: bring in feature to re-transmit the frames
there was a corner case of 'fops' failing if they were in transit
during a disconnection, if the failure is due to 'ENOTCONN'
re-transmit the frame.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1500 (Mount point should not be in-accessible between reconnect to server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1500
commit b0d684acf74c8d502bb9f31ebc9e5401288f866e
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Dec 22 04:56:37 2010 +0000
change the log level from warning to debug while getting pending matrix
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1080 (clang errors in the file afr-self-heal-common.c)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1080
commit 3bead769a9149d761069c2f20c6a3979ef00cd79
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Dec 22 04:35:10 2010 +0000
send_fuse_iov: check args to prevent possible NULL dereferencing
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2223 (Crash in send_fuse_err)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2223
commit b7cbe5cf1e6812352b4e102e407010ce4f64a4af
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Dec 20 03:59:02 2010 +0000
rdma : prevent confusing logs when both 'poll_in' and 'poll_err' are received.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 6d4f1dcec8c0647f553eb5c20c0da13f0e08414d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Dec 20 00:24:33 2010 +0000
nfs3: Access cbk must account for auxgids on group access checks
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2045 (Write permission denied for non-primary group membership)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2045
commit f5ac7b81e72840bee580f1d1ad61917edbe96ee2
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Dec 20 00:24:32 2010 +0000
nfs: Do not touch iatt on failed fops
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2169 (NFS crash in nfs-fops due to failed fop from subvolume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2169
commit 53a7d3856f9c8e18114072542739958ab641e9dc
Author: Pranith K <pranithk@gluster.com>
Date: Thu Dec 16 01:24:33 2010 +0000
glusterd,cli: print single error message on failure
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1922 (Volume not present wrong message displayed on command line)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1922
commit 3f51f01a05404798c961623fddced17b017f2fd2
Author: Harshavardhana <harsha@gluster.com>
Date: Wed Dec 15 19:46:49 2010 +0000
Add volume key to select data-self-heal-algorithm
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2218 (Replicate self-heal causes servers to go 100% cpu and unresponsive.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2218
commit bba10c1991eb79eb685f8be6b57f22f8c1c66e88
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Dec 15 06:00:28 2010 +0000
log the total rebalance command recieved into the logfile
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2231 (log the total rebalance command recieved, in the logfile to avoid confusion)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2231
commit 7a66197b0da6836904d6ab578f16588728db936a
Author: Pranith K <pranithk@gluster.com>
Date: Wed Dec 15 00:37:22 2010 +0000
libglusterfs: data_copy needs to init the lock
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2226 (data_copy needs to init the data lock)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2226
commit 8504c591dac179b0120d96c6ad9a2956cdc57a9d
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Dec 13 05:53:54 2010 +0000
Make STRIPE_STACK_UNWIND and STRIPE_STACK_DESTROY default calls in stripe
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2134 (inode leaks on stripe)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2134
commit 6ccf5df1e858f004439d1064d15cfd0e4bdbe7bb
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Dec 13 13:40:34 2010 +0000
Implement STRIPE_STACK_UNWIND and STRIPE_STACK_DESTROY
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2134 (inode leaks on stripe)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2134
commit d4a7151a1f7641feddff2e836e418450d9a7602e
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Dec 13 05:31:28 2010 +0000
Remove check for path in stripe_local_wipe
The check for path is done in loc_wipe. During loc_copy, inode ref is taken
before path set succeeds or fails.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2134 (inode leaks on stripe)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2134
commit a8ba56bf71e734531bd1483511b3a8cc6c12cdbf
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 23:03:37 2010 +0000
performance/io-threads: implement rchecksum fop.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2220 (Implement rchecksum fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2220
commit 44c7659fdfb25dc122df84232b8277f1107674ef
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Dec 14 01:03:38 2010 +0000
setsockopt should be called with solaris specific arguments for solaris server
----- Original Message -----
From: "Raghavendra Bhat" <raghavendrabhat@gluster.com>
To: glusterfs@dev.gluster.com
Sent: Tuesday, December 14, 2010 11:56:43 AM
Subject: [PATCH BUG:2205 v4] setsockopt should be called with solaris specific arguments for solaris server
Looks fine to me.
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2205 ([glusterfs-3.1.2qa1]: error while setting the keepalive time interval)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2205
commit 718890876cf921201cc040637e15e4615bb600b4
Author: Pranith K <pranithk@gluster.com>
Date: Mon Dec 13 06:06:20 2010 +0000
cli: remove duplication of cmd help
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2089 (Documentation bug in replace-brick options)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2089
commit 759b1f0238207344a505b8e67c16059a1e5aa195
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 03:34:21 2010 +0000
mgmt: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit ddd289db7db1ea7eafe637d9160e6185ee91b975
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 03:34:05 2010 +0000
nfs: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit 6bc39654b7838490c131cf2e10cf3ead1a857cce
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 03:33:52 2010 +0000
features/quota: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit fa5ef1ac66b5e123507d871ccfac9abbcdf6cb32
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 03:33:38 2010 +0000
cluster/distribute: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit 25bff99443bb798412a514e94e53555f97633a2f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 03:33:21 2010 +0000
cluster/replicate: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit 1868839ee4baff32eb7967c9f14258f1f6422e69
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 00:14:25 2010 +0000
libglusterfs: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit f8abdfa9ed26a83527d72b03a18225299cd87b78
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 00:14:12 2010 +0000
performance/quick-read: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit 5d72b5d30dfd9e29fb4a4ff176e43ceff250dc25
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 00:13:59 2010 +0000
performance/io-cache: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit 9cb0cd6aca0c944f8390fed1ce19260a7d835dc3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 00:13:41 2010 +0000
performance/io-threads: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit 198fc53e233f11770116c79ed42b05faafda6a64
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 00:13:28 2010 +0000
performance/write-behind: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit 8aeb076894ae2fb4528af9c627319d93c74e3775
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 00:13:15 2010 +0000
protocol: fix warnings due to format string mismatches during invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit 3fa3857cf5cd9e22f199eb8904a4cac7e2dbc006
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Dec 13 00:12:54 2010 +0000
rpc: fix format string mismatches in invocation of gf_log.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2211 ((re)introduce warnings for format string/parameter mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2211
commit d52dc3b3b52ef4c62efa164f6a8a070fb7bfa69e
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Dec 10 12:24:16 2010 +0000
client-reopen-cbk: fix a gf_log() crash due to wrong argument list
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit faabdbcb06a6511191179fd40572cf279535ba42
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Dec 9 01:03:57 2010 +0000
rpc-transport/rdma: QP configuration changes.
- set send and recv count to 4K.
- set max_send_sge of QP to 2 since for msgs of type RDMA_NOMSG, there
can be two vectors - rpc header and message from program.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2197 (applications running on large number of clients simultaneously result in ibv_post_send errors on server.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2197
commit 8a2284a9764a2a0164d76a752848780dacdce77c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Dec 9 01:03:39 2010 +0000
rpc-transport/rdma: add informative debug messages when posting of send requests fail.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2197 (applications running on large number of clients simultaneously result in ibv_post_send errors on server.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2197
commit 02d3de674f12ecc48c3ce148ccb80c999f59cb1d
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Dec 8 23:20:14 2010 +0000
set the return value to -1 intitially which may be returned as success in validate_or_goto
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit c6a8b3aaf72e9d8e33882109ffc44d6a44103423
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Dec 8 23:14:04 2010 +0000
check the return value after setting the fd context in afr
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 865 (Add locks recovery support in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=865
commit 5f6dddb2670f695940448fc6ed9a2b252c4869de
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Dec 8 22:55:24 2010 +0000
check the return value properly after calling inode_path
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2203 ([glusterfs 3.1.1]: Core generated with Segmentation fault in afr-open.c)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2203
commit b4bab2693c136026f7ecd2a7be2e2385159e7f6c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Dec 10 04:48:49 2010 +0000
rpcsvc: while handling transport-cleanup event look for listener with transport trans->listener instead of trans.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2208 (transport cleanup event is not sent to programs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2208
commit 315fa7352f1cede6f113da38555fd054c8863a7b
Author: Anand Avati <avati@gluster.com>
Date: Thu Dec 9 02:06:52 2010 +0000
protocol: avoid repetitive disconnect logs
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 40ce6b49b48828db6a8e52a193dc0f558af4002b
Author: Anand Avati <avati@gluster.com>
Date: Wed Dec 8 09:58:27 2010 +0000
replicate: propagate CHILD_DOWN upwards properly
During initialization if one subvolume returns CHILD_DOWN, then
do not consider the other subvolume as down if we still haven't
heard from it yet
This causes DHT (on top) to prematurely (and wrongly) send
CHILD_UP/DOWN upwards
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2200 (cp dies with "Invalid argument" after failover)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2200
commit dee1ab27f34da177c9dd7a18e0acffe8aae5fd8b
Author: Anand Avati <avati@gluster.com>
Date: Tue Dec 7 05:36:54 2010 +0000
nfs: cleanup inode_ref/inode_unref to fix inode leaks and extra unrefs
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2195 (Crash in __inode_retire on NFS failover)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2195
commit 286ea7d250f75b13c14ac53ef44550e3408ac4b1
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Dec 7 06:53:49 2010 +0000
mgmt/glusterd: Use a static buffer to perform ioctl with SIOCGIFCONF
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2163 (Can't create volume using 3.1.1qa11 on OpenSolaris 2009.6)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2163
commit 9b66f9306b893c60f76066b46116ba3c1312c51b
Author: Anand Avati <avati@gluster.com>
Date: Tue Dec 7 00:19:30 2010 +0000
gfid: disable setting/getting of gfid from higher level translators
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2196 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2196
commit 313d97fb6fd35555d8bdbba607e2cb02f6b63599
Author: Anand Avati <avati@gluster.com>
Date: Tue Dec 7 00:02:10 2010 +0000
rpc-clnt: show disconnect messages in log file by default
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 0c7f8186071ed089498f38154a265e5c0b5acedc
Author: Anand Avati <avati@gluster.com>
Date: Mon Dec 6 23:28:19 2010 +0000
inode: fix crash in logging during cyclic loop detection
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2196 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2196
commit 49f5475399b316943e17f6aa8996bfcdf1a90872
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Dec 6 07:55:56 2010 +0000
check whether the file is a symlink while doing utimes
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 881 (GlusterFS daemon hangs on replication of symlink (3.0.4))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=881
commit f3c9930c1af77b9d6e3f8b766007d7478cecb0e3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Dec 2 00:34:09 2010 +0000
mount.glusterfs: use option --direct-io-mode instead of --disable-direct-io-mode
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2173 (enabling/disabling direct-io mode is not possible when glusterfs is mounted using mount command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2173
commit ba652f98d02154c2ec8885a3eeb629603586dd1b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Nov 26 00:45:50 2010 +0000
nfs: Start nfs process even if portmap registration fails
It helps to have the process be listed in ps ax|grep output
so that user can get the path to the log from the listed
command line and check what the problem is.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2093 (volumes cannot start when one node in a replicated setup is down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2093
commit 4fedf6f0274fdfa90e0f2b3e130fcc06d331063a
Author: Anand Avati <avati@gluster.com>
Date: Mon Nov 29 06:24:15 2010 +0000
fuse-bridge: construct fa->rdev properly
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2145 ([3.1.1qa9] mknod does not work properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2145
commit 5236471bd7581e4ada05b09f6f3e5008e05e8806
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Mon Nov 29 09:01:41 2010 -0800
rpm: glusterfs.spec.in fixes for upgrade via rpm -Uvh
commit dcf85f00507c032cb249318c63b468cae33a4325
Author: Anand Avati <avati@gluster.com>
Date: Thu Nov 25 23:35:18 2010 +0000
stat-prefetch: changes to incorporate gfid
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2136 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2136
commit 8a828d33b4508969a025bcb73351f4b4495ff199
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Nov 24 12:42:56 2010 +0000
mgmt/glusterd: Enable stat-prefetch for fuse
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2136 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2136
commit d91d16eec5e4e7055cb921a1433da60ef32c2f0d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Nov 25 04:11:11 2010 +0000
nfs3: Prevent second lookup on a fresh entry lookup
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit 3f745abff5353528b0649ff95104b493f33d5146
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Nov 25 04:11:10 2010 +0000
nfsrpc: Add new macro nfs_rpcsvc_request_procnum
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit 3e3040fb222d344716857b2b4f685ca71b574c97
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Nov 25 04:11:09 2010 +0000
nfs: Export subvolumes on per-subvolume CHILD-UP
..so that nfs clients can mount an UP subvolume even if other subvolumes
havent come up yet.
This was a problem because nfs was waiting for all children to receive
CHILD-UP before exporting any subvolume.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2093 (volumes cannot start when one node in a replicated setup is down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2093
commit cd4958e661edd2a5c95a8feba187884e7aa30145
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Nov 25 00:17:08 2010 +0000
nfs3: Fresh inode lookup on failed revalidation
Brings in changes that were earlier introduced in commit:
f5afcc47f9f00472d6c2b3f48127e02332cd457a
but reverted because the patch was buggy and caused a seg-fault
due to extra inode_unrefs.
It fixes that extra inode_unref and cleans up the revalidation logic.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit 7adf158727e5360e5effcd124922f480a0ea145c
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Nov 25 00:17:07 2010 +0000
nfs: Undo selective changes in inode revalidation
Those changes were brought in by commit 161850285ff06e90f2c990989bab9513dd4a4289:
"nfs: re-implement logic to perform fresh lookups when lookup revalidates fail"
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit c7782bc7aeeea93f24c41e486582b2d96d3df8ed
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Nov 25 02:26:26 2010 +0000
mgmt/glusterd: Move .cmd_log_history to log directory
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2154 (Move .cmd_log_history to log directory)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2154
commit d42fc20c64bc4c21ca47a5c60baef7b9b09f09ea
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 24 07:35:26 2010 +0000
rpc-transport: don't merge payload iobuf and iobuf which holds program header into single iobref.
- io-cache holds a reference on iobref passed from transport layer. Hence,
two iobufs are accounted instead of one in calculated used cache size.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2135 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2135
commit 2f3d3862e515af578e5664f7e09604bcb7fe61a0
Author: Sachidananda <sac@gluster.com>
Date: Thu Nov 25 01:05:08 2010 +0000
rpc-coverage.sh: Make error messages explicit.
Make failure explicit, with `set -e' script exits silently and we have
no way to know where it failed unless run by set -x.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit fe7e71fb90e2e2c67e3c8a4feb37510c320c02a4
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Nov 25 02:04:43 2010 +0000
mgmt/glusterd: Temporary fix for a crash seen in replace-brick
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2084 ([3.1.1qa5] : replace-brick fails to migrate data when migration from same hostname)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2084
commit f7d343faa0022936e60fd3a32de97be44e6a766d
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Nov 25 02:11:45 2010 +0000
cli: Enhance message shown upon successful volume creation
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2034 (Why not start a volume after it has been created?)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2034
commit b1edc5973012d7214ffe63a2db6f4dcb05a59979
Author: Anand Avati <avati@gluster.com>
Date: Wed Nov 24 07:24:33 2010 +0000
resolver: include par_idx access within the conditional section
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 7034ab665a83781010f4f1cf0c507dd673acc036
Author: Anand Avati <avati@gluster.com>
Date: Wed Nov 24 07:15:19 2010 +0000
iatt: fix bug in ia_makedev
the wrong binary operator was resulting in lookup/stat showing wrong
major/minor numbers for device files
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2145 ([3.1.1qa9] mknod does not work properly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2145
commit 26c7bfd60fb4501826f2641aa98b5ab70ff82196
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Nov 20 05:52:24 2010 +0000
volgen: put back an amended form of check erased in 96f44835 ("do not error out if brick count is less than sub count...")
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2054 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2054
commit 2f146244f867c783adfad847d06471fe26966097
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Nov 16 19:35:12 2010 +0000
volgen: clean up 0fbf226c (... add nfs.enable-ino32 as an option ...)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1972 (xcs get doesn't work with gNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1972
commit af9f6f6c68f8b8716d4bb604d6dd073a28b2b913
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Nov 23 07:13:27 2010 +0000
display the error to the user if volume stop is given on a volume which does not exist
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2140 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2140
commit 56dc5f0f2f683117e04f7ac5bdf7f9861b58d4d0
Author: Anand Avati <avati@gluster.com>
Date: Tue Nov 23 10:35:56 2010 +0000
inode: catch loop formation during inode_link() and fail linking
- explores all parent branches
- performs loop formation check only if the operation is resulting in relinking
of an inode already existing in the table
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 246e64333a96a75021a9c0ccec0205a516e53b27
Author: Anand Avati <avati@gluster.com>
Date: Mon Nov 22 10:52:51 2010 +0000
resolver: handle corner cases of handling root inode better
- changes in deep resolution and simple resolution of pure paths
to handle resolution of "/"
- warn on pure path resolution
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 52e41722968c6d8ba9cb63110205c3639208a6c1
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Nov 22 00:55:44 2010 +0000
display the error message to the user if a volume with the name is tried to be created
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1209 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1209
commit 841449006ef46ec02be75f5e63155c3de0b99d97
Author: Anand Avati <avati@gluster.com>
Date: Fri Nov 19 06:25:40 2010 +0000
rpc-coverage.sh: enhancements for more extensive testing
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 3ee9640b95ee4b37bd1b5d48f6ceb7d2a583df85
Author: Anand Avati <avati@gluster.com>
Date: Thu Nov 18 08:35:24 2010 +0000
nfs: treat GF_EVENT_CHILD_CONNECTING as subvolume up status
GF_EVENT_CHILD_CONNECTING is sent as a status from underlying subvolumes
after a sufficient margin of time (tcp connect() timeout) if the subvolumes
are not reachable.
This should avoid the problem of NFS not being reachable if any volume
is down
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2093 (volumes cannot start when one node in a replicated setup is down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2093
commit d950e142a51db3db62b757b5d956e3d5a30b049b
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Nov 18 05:38:59 2010 +0000
features/locks: Send prelock unlock only if it is not grantable and is a blocking lock call.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1017 (Locking deadlock when upgrading lock)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1017
commit 82e97a434f02457784af9f85d968529773b3c1d8
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Nov 17 23:36:06 2010 +0000
Remove spurious inode_ref call on parent dir in fuse_create_cbk
The additional ref caused leaks. The ref is taken in __dentry_create
called from inode_link
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2117 ([glusterfs-3.1.1qa7]: memleak in glusterfsd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2117
commit e6e1f6d49bcc6161defa0286ee6df37136d8e998
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Nov 18 02:32:38 2010 +0000
error out if the data-self-heal-window-size is less than 1
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2120 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2120
commit 011363a48fffc6b64b7c0b37425cc9b595f5a260
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Nov 18 06:26:26 2010 +0000
mgmt/glusterd: Avoid creating multiple destination brickinfo during replace-brick
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2084 ([3.1.1qa5] : replace-brick fails to migrate data when migration from same hostname)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2084
commit b96bb9d1f84f30c75c93f5dfd3fe8f9242ee54ad
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Nov 18 06:31:01 2010 +0000
cluster/pump: send PARENT_UP to dst_child after init is successful
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2122 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2122
commit ae51b3854cb595447a21c2ee371f717bb071570f
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Nov 18 06:21:55 2010 +0000
rpc-clnt: add check for NULL argument for rpc_clnt_start
prevents crash when rpc_clnt_start is called before init
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2122 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2122
commit 12f95752ae8613aae4e72b80504e238e4ca90ca6
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Nov 16 03:52:17 2010 +0000
protocol/client: skip notify if query portmap is successful
Mount point does not hang, though stale handle error on / till the downed brick is
online again
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1905 (Mounting volume is not working when any one server is down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1905
commit 825a6a901ee32a088c4d4274071d18d6736de7f1
Author: Anand Avati <avati@gluster.com>
Date: Tue Nov 16 08:17:07 2010 +0000
protocol/client: use the new rpc_clnt initialization methods
This way of initializing an rpc_clnt object by splitting into a
passive rpc_clnt_new and a delayed rpc_clnt_start between which
registration of callback programs and notify methods are performed
provides a race-free way to avoid the missing of connect notifications
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2078 (Volume Migration is not working)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2078
commit 355b1f06064acfbe3276d6dc66a5e5c6ed789802
Author: Anand Avati <avati@gluster.com>
Date: Tue Nov 16 08:16:42 2010 +0000
rpc-clnt: introduce new way of creating rpc-clnt objects
rpc_clnt_new() creates a new passive rpc clnt object.
rpc_clnt_start() triggers the connection/reconnection from the object.
rpc_clnt_init() - the old way - still works.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2078 (Volume Migration is not working)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2078
commit b8d0bb44461ebc7b85665382b3f644c05d8debd2
Author: Anand Avati <avati@gluster.com>
Date: Tue Nov 16 08:15:48 2010 +0000
rpc-clnt: move rpc_clnt_reconnect() call to rpc_clnt_init
Previously rpc_clnt_reconnect() was called inside rpc_clnt_connection_init
which in turn was called from rpc_clnt_init. This change makes
rpc_clnt_connection_init re-usable for the next patch
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2078 (Volume Migration is not working)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2078
commit be35fb5c48b00c9c47d912dcefea69bb5bd18f12
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Nov 16 04:56:38 2010 +0000
nfsrpc: Fail auth-unix if more than 16 gids found
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2045 (Write permission denied for non-primary group membership)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2045
commit 2ffe5f888f6adea47132494d857265b22b5d2b6e
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Nov 16 04:56:37 2010 +0000
rpc-lib: Fail auth-unix if more than 16 gids found
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2045 (Write permission denied for non-primary group membership)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2045
commit 28a6730dea5bd41c70c874e3db62de49de7e4d60
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Nov 16 03:44:37 2010 +0000
rpc-lib: Copy auxiliary GIDs into request from de-XDRed buffer
Fixes a problem where secondary groups are not accounted for in
permission checks.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2045 (Write permission denied for non-primary group membership)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2045
commit 7f290777f8d186ce0b5e28e36bf62eaa30dea2e2
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Nov 16 01:07:20 2010 +0000
Stripe I/O exits when graph changes
Adding event CONNECTING to be handled like CHILDUP in notify.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2111 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2111
commit 90e98a0528b410594faea33c14db7a9c9a0baabe
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Nov 16 01:21:54 2010 +0000
protocol/client: fix ping timeout checks in reconfigure()
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2104 ([3.1.1qa5]: network.ping-timeout set failed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2104
commit 201203d74c88f1a86724986ff895e553ccb17528
Author: Pranith K <pranithk@gluster.com>
Date: Tue Nov 16 01:26:00 2010 +0000
cli: fix memory corruption in create volume and add-brick
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2113 (cli: memory corruption in add-brick and create volume parsing functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2113
commit 80f87546476265d92dc8acd5079d2a54040d3ed9
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Nov 16 01:26:45 2010 +0000
fuse: dentry create time inode resolution fixes
treat successful 'inode' resolution as stale entries in case of
entry creation fops, instead of continueing with an error log with
old entry.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1240 (DVM: after graph change, inodes should resolve to new inode-table)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1240
commit 432bd20939dbebd8094ed8010011dfe7c828bd0a
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Nov 16 00:12:58 2010 +0000
Solaris: df -h returned invalid size
The reason seems to have been multiplying fields with f_bsize, while
they are in f_frsize units. On linux both f_bize and f_frbsize seems to
have been the same
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1021 (NFS: df -h shows incorrect out put)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1021
commit 5075cafa9301c6afc46e080e04d6561d41a12205
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Nov 15 06:44:44 2010 +0000
Remove symlnk of log dir to /etc/glusterd
Hence forth the default log dir will be /usr/local/var/log/glusterfs
Missed out on log locate changes
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2109 (Remove symbolic link of log directory from /etc/glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2109
commit ee2470273f81eb7886786a0d3fecdb4bead45cbe
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Nov 15 02:55:38 2010 +0000
Remove symlnk of default log dir to /etc/glusterd
Hence forth the default log dir will be /usr/local/var/log/glusterfs
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2109 (Remove symbolic link of log directory from /etc/glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2109
commit 825dd1b8a315b355a3bac832246784d62faf2873
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Nov 15 03:46:30 2010 +0000
glusterd rebalance: update the status in failure cases
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1999 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1999
commit 222f0f27b8d2e432cf34fbc83268caf8d7233bf5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Nov 15 05:57:46 2010 +0000
Revert "nfs: Use only 38467 as default port instead of 3846[567]"
This reverts commit be5c02a81c19336a6b922b1e1f28293c90955e7f.
By default, continue to register the three original port numbers
so that an upgrade to future version from 3.1 release does not
break mount requests against portmap, which may have old port
numbers registered.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1743 (XenServer is not compatible with GlusterNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1743
commit eeeeb8202a52a0c81c77134fadefa52476d270dc
Author: Anand Avati <avati@gluster.com>
Date: Mon Nov 15 05:34:00 2010 +0000
nfs: opendir/closedir for every readdir
Revert "nfs3: Unref & unbind dir fd with inode lock on EOF"
This reverts commit 4e6fb304ce41acbaf7c9ba67c06bf443e65082e8.
The above commit (which unbinds fds at EOF) does not fix the original
bug (1619) because a readdir from a second app could have already
started before the readdir_cbk of the first app's readdir reaches
NFS code. Hence the race still exists.
Performing extra unrefs when EOF is received is not a reliable way
of detecting that a client has performed a closedir (and to close
the fd ourselves). Neither is interpreting a 0 cookies a new opendir.
Clients can always use telldir/seekdir and hit EOFs twice.
Due to the way NFS3 protocol is designed, it is just not possible
for the server to reliably detect opendirs/closedirs performed by
the client and map the corresponding readdirs to the same dir fd
on the server side.
The only reliable way of fixing this is to perform opendir/closedir
at the cost of performance. Any optimization towards keeping dir fds
open attempting to map them with application's opendir/closedir will
either result in fd leaks or extra fd unrefs.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2061 (NFS server crashes in readdir_fstat_cbk due to extra fd unref)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2061
commit eb55dc5966e1a0d03abd735afd52912afbbee84f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 15 04:02:45 2010 +0000
cluster/replicate: Fix memory leak in afr_fd_ctx_cleanup.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1438 (memory leaks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1438
commit 1a79b1a3fe71fbff0e62eebcdcbc5b71f5990d11
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Nov 13 02:06:12 2010 +0000
check for dict also while setting the port for source brick while doing replace brick
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2084 ([3.1.1qa5] : replace-brick fails to migrate data when migration from same hostname)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2084
commit aebfef27c326d1a36b8a3820500850a8e6efbf2c
Author: Pranith K <pranithk@gluster.com>
Date: Sun Nov 14 00:13:25 2010 +0000
cli: remove special behavior for help commands without readline
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2091 (Gluster CLI exits after issuing volume help)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2091
commit 6b1385b7dc88b68be382cd9adf703437d13eef34
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Nov 14 12:08:23 2010 +0000
mgmt/glusterd: fixes for uninterrupted replace-brick with nfs
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2084 ([3.1.1qa5] : replace-brick fails to migrate data when migration from same hostname)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2084
commit 74913f1bf97de454d3f7b2d56ff152dfd62c93cc
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Nov 14 12:07:30 2010 +0000
cluster/pump: Reset saved path upon pump completion
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2084 ([3.1.1qa5] : replace-brick fails to migrate data when migration from same hostname)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2084
commit 38bdabcdfb2526102c897155d2e84d8870ce9997
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Nov 11 23:00:19 2010 +0000
performance/quick-read: handle the errors in qr_loc_fill properly when an fop needs to do open before continuing.
- without need_unwind set, 'goto out' will result in infinite loop.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2075 (inode_from_path silently consumes 99% CPU causing nfs client disconnects)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2075
commit afd6dfcf3ef6572d6021760b21003890b438ff86
Author: Pranith K <pranithk@gluster.com>
Date: Fri Nov 12 04:01:01 2010 +0000
mgmt/glusterd: "peer probe new-hostname" should replace old-hostname of friend
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1995 (Gluster Peer probe command keeps ip address instead of server name in the destination server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1995
commit c3507bc93aaf9e66eefd164598710c988ee5da47
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Nov 12 05:23:42 2010 +0000
stripe: allow lookup on an entry if other than first subvolume is down
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2099 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2099
commit 6375562ac4062956164d320cff637d9a130205e5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Nov 11 00:19:54 2010 +0000
nfsrpc: Change log levels for RPC program search messages
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2072 (NFS server crash in __nfs_rpcsvc_program_actor)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2072
commit b89c9f553d38b8b2158419abbd208032cbb35337
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Nov 11 01:54:50 2010 +0000
cli: fix issues with running command over ssh
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2081 (gluster CLI does not work over ssh)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2081
commit 37022e23fd349e98193a6cf742c332df9286fb56
Author: Pranith K <pranithk@gluster.com>
Date: Fri Nov 12 00:55:02 2010 +0000
mgmt/glusterd: set the transport type correctly in create volume
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2095 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2095
commit ac672a9bf93962486482a976cad9c806e0ffd7d1
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Nov 12 04:05:22 2010 +0000
distribute: handle a case of 'local->key' being free'd twice.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2097 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2097
commit 20cc9a6238ed86d317678b0731e2f801fc2e9751
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Nov 12 04:15:08 2010 +0000
Solaris: vasprint fix for %llu crash
vasprint now inturn call gf_vasprintf, which calls vsnprintf.
vsnprintf allocates buffer of required size, and hence prevents
the sigsegv seen in vasprintf w.r.t %llu
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1058 (vasprintf dumps core when %llu is involved)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1058
commit 117ae5fafe280878cffc9b5696924e2a429e2cc5
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Nov 12 04:15:38 2010 +0000
Solaris: Fix crash seen in rpc_clnt_reconnect
rpc_clnt_set_connected was being called from mgmt_rpc_notify with
incorrect argument. The crash was only seen on solaris.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2013 (Gluster 3.1 should be supported on the current versions of Solaris and OpenSolaris)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2013
commit 0882ac4c7c3283e0e6c05b64e8ecbf86f8cdc235
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Nov 10 07:56:45 2010 +0000
rpcsvc: Fix crash in program search after portmap registration failure
Failure to register with portmap was leaving the registered programs list in
inconsistent state. This was causing a crash.
portmap registration can fail if there is an NFS server already running.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2072 (NFS server crash in __nfs_rpcsvc_program_actor)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2072
commit 87f4cbec0a080025dc59ecce1920f0890f403abc
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 10 02:59:10 2010 +0000
rpc/rpc-lib: don't build libgfrpc as a module.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1427 (libgfrpc.so is not portable)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1427
commit 97b4dc1161a76b081c3f1ec9e14c2125ddcc7d94
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Nov 9 06:51:31 2010 +0000
rpmspec: add glusterfs-core dependency for glusterfs-fuse package
also add dependency for rdma package
Thanks to Bernard Li <bernard@vanhpc.org> for the patch
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2019 (glusterfs-fuse should require glusterfs-core (RPM spec file))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2019
commit c233ef0dc222c7ef161d7222a173f661ed9e9509
Author: Anand Avati <avati@gluster.com>
Date: Tue Nov 9 05:38:12 2010 +0000
protocol/server: fix log level of message in server-resolver.c
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1092 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1092
commit c6dee07ca5b72187aa3833bbf3c08bddfa8c540a
Author: Anand Avati <avati@gluster.com>
Date: Tue Nov 9 05:27:02 2010 +0000
replicate: optimistic changelog
The standard way of maintaining changelog in replicate has been to
write out pending flags and to unset the pending flag post the
actual operation.
This new optimization kicks in only when all subvolumes are up.
The optimization is that, during pre-op, no changelog is written for
METADATA and ENTRY/RENAME operations. If during the operation nothing
failed, no changelog is updated in post-op either. If however,
something does fail during an operation, then, pending flags get
written during post op pointing only towards the failed nodes.
DATA transactions continue to work the way they are.
If one subvolume is down, pending flags are written in pre-op changelog
itself as before.
The impact of this optimization is only in the case when both servers
die or the client dies while the 'FOP' stage of the transaction is
in progress. By nature of METADATA and ENTRY operations, detecting a
mismatch later is not dependent on the presence of changelog. Changelog
only determines the direction in which self-heal happens for these types
of transactions. For the direction too this optimization does not have
a major impact because in the cases of failure (both servers dieing or
client dieing) the final state (direction of self-heal) would be
arbitrary anyways as the syscall wouldn't have completed.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2068 (performance enhancements)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2068
commit d82204fffa43a5a9445ba00191b25e984639493b
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Nov 9 05:14:22 2010 +0000
libglusterfs: Memory accounting changes
This patch disables memory accounting by default and provides better
alignemnt for faster fetch.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2068 (performance enhancements)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2068
commit 63ed9a0aeb4a9a756d55e9f55af050ba132c9541
Author: Pranith K <pranithk@gluster.com>
Date: Tue Nov 9 04:08:33 2010 +0000
glusterd test-script change in add/remove-brick syntax
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1436 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
commit 88c5c184b8793212af67f701aca1d322acfa0be6
Author: Pranith K <pranithk@gluster.com>
Date: Tue Nov 9 03:17:31 2010 +0000
cli: remove volume type from add-brick and remove-brick cmds
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1983 ("type" in add-brick is completely redundant)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1983
commit 30e8b20475b5a0bbee3848091ac945f986042d29
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Nov 9 02:48:31 2010 +0000
client: Return correct pre/post iatt for dst during rename
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2050 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2050
commit 253db62d9d716185792f79ff0469048fdefbef09
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Nov 9 00:36:24 2010 +0000
mnt3: Fail mount requests for disallowed clients
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1385 (showmount says no access though it can be mounted.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1385
commit 656f47570ab12d0d800ff5f2789ca95d956871e5
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Nov 9 00:05:31 2010 +0000
rpc-transport/rdma: set the default quota of recv buffers to 128.
- since quota is returned once the reply is recieved, 32 is too less value.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2060 (Infiniteband errors on large file find)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2060
commit 453989f34de7939c26096ff1409a384427a7bcba
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Nov 8 06:40:21 2010 +0000
check if the brick being added is the destination brick of replace brick
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2033 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2033
commit 938acd0823d662676bd26a009893923d9cd303ae
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Nov 8 06:25:18 2010 +0000
nfs: Support nfs.port to allow changing nfs port numbers
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1743 (XenServer is not compatible with GlusterNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1743
commit de603174ff3d86578a4475d2a6608cf7fea21b93
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Nov 8 06:25:17 2010 +0000
nfs: Use only 38467 as default port instead of 3846[567]
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1743 (XenServer is not compatible with GlusterNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1743
commit 5a21277ac05663c173502bb54705d8b971b3dcb8
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Nov 8 06:25:16 2010 +0000
nfsrpc: Decouple TCP connections from programs
..so that multiple programs can be served from the same connection
or multiple ports can be bound to the same port number.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1743 (XenServer is not compatible with GlusterNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1743
commit 6b7f32c04a47bf45a8519b358dbd78c30496d0b8
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Nov 8 05:02:06 2010 +0000
glusterfsd.c: cleanup_and_exit() doesn't call all the 'fini()'
calling 'fini()' of each xlator needs more synchronization work to
be done. We will be doing a direct 'exit()' as of now.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1879 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1879
commit 956caa4f9026f4bde6948ca7538f29d90b6598e8
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Nov 8 02:53:16 2010 +0000
protocol/server: array declarations changed to alloca()
This is to make sure we don't spend CPU cycles in memset(0) on the
array, instead do a 'alloca()' on size of the request.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 2bde93080433f90b4e52fa26cd74b40cd2cde043
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Nov 8 00:54:27 2010 +0000
access-control: Allow Writes/Reads to proceed without perm checks
a. We expect that when the fds are opened through FUSE, thats when the
perm checks happen, depending on the read/write mode used.
b. In case of nfs clients, we expect the nfs clients to perform the checks
based on getattr/access nfs requests.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2058 (posix permission compliance error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2058
commit e847e8c902ac0a33894d42690aa06f2cdca5c6b0
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Nov 4 02:44:02 2010 +0000
do not error out if brick count is less than sub count which is valid in the case of replicate
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2054 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2054
commit e00e360a7c69a32b14a23cc5e119e345ab094027
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Nov 5 03:54:39 2010 +0000
fuse: init entry timeout
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2059 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2059
commit 6c7a49e8b52ac839270e7b1e9079523ffa52243c
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Nov 4 05:11:50 2010 +0000
Remove the hard-coded thread-count option in volgen
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
commit 098a56dae527e4e65ff9a447c28484d40ad7a65b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Nov 4 02:34:26 2010 +0000
rpc-transport/rdma: create request_context only if message contains read chunks or write chunks.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1992 (glusterd crashed while submitting a callback.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1992
commit 87c45335d684dad205978854b176d7a9e1a36b90
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Nov 4 02:33:19 2010 +0000
rpc-transport/rdma: Fix 2KB as threshold size for msgs that can be transferred inline.
- Any fop/mop that can result a reply whose size is greater than this threshold
allocates and submits a buffer along with the request to receive reply.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit bc529a04218a69b7a292476ee90c5066a300d6fc
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 1 01:25:03 2010 +0000
rpc-transport/rdma: increment post->ctx.count in a loop doint rdma_read.
- incrementing by the number of read chunks even before doing rdma read will
cause issues since post->ctx.count is used while posting rdma read.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1877 (data corruption while running arequal.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1877
commit 77b31e53fb2b0df700d2b2a17563f5860cd9cae2
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Nov 3 06:35:29 2010 +0000
nfs: Introduce rpc.register-with-portmap to disable portmap registration
For systems that need to run multiple nfs servers, we need to prevent
more than one from registering with portmap service. Use this option
to turn off portmap registration for Gluster NFS.
Portmap registration is on by default.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1743 (XenServer is not compatible with GlusterNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1743
commit 7c16b699c74d74b2f8e1c0194d7835e55386c5fa
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Nov 3 06:35:28 2010 +0000
nfs: Remove conn_destroy/init callbacks
NFS is transport-independent, so no point emulating knowledge
of transportin software.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1743 (XenServer is not compatible with GlusterNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1743
commit 776d12dcc528e9a071f124cce6038da7e1c2359a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Nov 3 06:35:27 2010 +0000
nfs3: More robust root gfid checks
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2051 (find fails with loop detected error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2051
commit 998fb7d587bff37d4e85d32447092d99512a68d0
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Nov 3 00:34:10 2010 +0000
mnt3: Fix UMNTALL crash with Windows clients
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1666 (GlustNFS is incompatible with Windows 7 NFS client.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1666
commit 5d7cd56f193543a2a401f102cf48f00a89a32981
Author: Mohammed Junaid Ahmed <junaid@gluster.com>
Date: Tue Nov 2 05:29:05 2010 +0000
Throwing an error while mounting glusterfs when fuse is not installed.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2002 (Mount fails, but gives no error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2002
commit f437faba1c6d5a2731b01e1f58316bbac918f2a5
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Nov 3 05:29:49 2010 +0000
mgmt/Glusterd: add nfs.enable-ino32 as an option to set from CLI
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1972 (xcs get doesn't work with gNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1972
commit 93edc66df65e6c1d6af0e4adb0cebd8e899cedcf
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Nov 3 02:13:31 2010 +0000
Fix DHT getxattr for directories
When a heal on the directory or layout changes, the user xattrs
do not get healed in dht. The current fix sends the getxattr call
n all the subvolumes, aggregates it and sends the response
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1991 (distribute directory self-heal does not copy user extended attributes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1991
commit f9d7042c3b4cea3d00f56acc312b1b2ef2219a35
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Nov 2 04:05:07 2010 +0000
Cli memory leak fix for tmp_list in cli_cmd_volume_add_brick_parse
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2047 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2047
commit 629e37577cc12c77c9ab3801dd15cf4ae3ce9cf1
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Nov 2 00:45:27 2010 +0000
use uuid_copy instead of memcpy
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 3c372ba4f027328e2fc929e318e0fde8ff1ccd8e
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Nov 2 01:39:00 2010 +0000
Fix crash while freeing tmp_list in cli_cmd_volume_create_parse
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2047 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2047
commit daa9d2e372d314efc7e1706a2e59dcacdb3180cc
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Nov 2 01:27:56 2010 +0000
socket: avoid check on lowlat for enabling nodelay
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2040 (Using 'du' and 'ls' command, it got slow performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2040
commit 85dd0966ad2a34252fff9c64e5b42d18fa8d3aff
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Oct 30 13:09:08 2010 +0000
cli: Fix memory leaks
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1198 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1198
commit 9dd49fd87690f0a12a627f50cca114f7ed7ac67f
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Oct 30 12:11:36 2010 +0000
mgmt/glusterd: Honor log filename set during add-brick
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2042 (No volume log files found in the specified directory for the newly added bricks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2042
commit 73590135648a22f7af5a6b654eea188d05c5dadd
Author: Pavan Sondur <pavan@gluster.com>
Date: Fri Oct 29 07:03:38 2010 +0000
mgmt/glusterd: Start nfs before killing source brick in replace brick commit.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 8647cc939e252f48f2104dd43ec6a5de9ca64eba
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Oct 29 07:23:54 2010 +0000
copy the gfid of root to the iatt structure of root
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit f307efb24b169f59657f078af0658196e2c3e9cd
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 29 05:38:13 2010 +0000
nfs: Introduce nfs.enable-ino32 to support legacy 32-bit only apps
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1972 (xcs get doesn't work with gNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1972
commit d93198a40184c7dff460d743f1b2a363abedd171
Author: Anand Avati <avati@gluster.com>
Date: Fri Oct 29 04:32:18 2010 +0000
protocol/client: add check for changed gfids to fail revalidates
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit b25c512e55c0ff216a81a326806f924e4c1249ad
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Oct 29 03:13:22 2010 +0000
rpc-transport: fix race-condition between rdma-read completion and updating the count of number of vectors to be passed to rpc.
- If rdma read completes before incrementing the vector count, the count
value sent to rpc will be improper. For fops like write, this may result
in missing out a vector to be written, thereby causing data corruption.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1877 (data corruption while running arequal.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1877
commit f64a098638d9b61e219f4c5e04267eab8f3dcb1e
Author: Pranith K <pranithk@gluster.com>
Date: Fri Oct 29 03:39:56 2010 +0000
cli,mgmt/glusterd: fsm log implementation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1966 (Unnecessarily verbose logs at the default log level)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1966
commit 3732dcb509dfb7f94b9f69451f76efcb9f412c31
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Fri Oct 29 03:32:44 2010 -0700
Revert "rpc-transport/rdma: create request_context only if message contains read chunks or write chunks."
This reverts commit b66f4598f4dafb6479232b20c5c521ab0da4e84a.
commit 19ce4e5fda2033727cd94a80dca6bcd406e21a7a
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Oct 28 07:02:44 2010 +0000
script for testing glusterd sanity
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1436 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
commit 5e1dd79e7b48a96e8a7abc34111a4a073e6b3ec0
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Oct 28 13:15:54 2010 +0000
performance/quick-read: white space cleanup
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2027 (Updates not happening with replication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2027
commit e9d4d635df997aa3d4f9ecb8fd9284253ebc0797
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Oct 28 13:15:26 2010 +0000
performance/quick-read: set right validation checks
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2027 (Updates not happening with replication)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2027
commit c2f5f97a9a30f35ae0e373ecb0dd3aab29af469a
Author: Anand Avati <avati@gluster.com>
Date: Thu Oct 28 00:52:50 2010 +0000
replicate: attempt re-open of files before performing openfd selfheal
in cases where subvolume state gets swapped between open and write
opening file on the remaining subvolumes is necessary before attempting
a self-heal. previously files were opened after self heal.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 918 (AFR write fails when subvolumes' state is swapped)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=918
commit c19d7b9c0f1d413e95dc3f01a556277792cac6f7
Author: Anand Avati <avati@gluster.com>
Date: Thu Oct 28 00:52:30 2010 +0000
replicate: fix hang/missing frame during locking
nonblocking style locking would result in a missing frame when all
subvolumes are down or when no subvolume on which fd was opened
is up. Check for this condition and unlock gracefully
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 918 (AFR write fails when subvolumes' state is swapped)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=918
commit 2d5a138c68f85d5a3ed3dcbc5061f0ae78f21332
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Oct 27 23:57:55 2010 +0000
Solaris build fixes: Patch for 64bit build
This will fix build failures when -m64 option is used to build
gluster
Signed-off-by: Super-User <root@Solaris-10.(none)>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1990 (Gluster mainline build on solaris fails with errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1990
commit 2f98183a5f99078cb8ee7ef443c18c52ccbf7359
Author: Pranith K <pranithk@gluster.com>
Date: Wed Oct 27 10:33:23 2010 +0000
cli: gluster --version implementation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2006 (Add gluster version command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2006
commit 0fa55db1660e14f8490b19aad96ce01d232f33f8
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Oct 27 05:36:32 2010 +0000
socket: Reduce keepalive idle and interval time
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1956 (NFS client hangs after failover)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1956
commit 86801269cf47e593919d93d8adebbe2e487768c4
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Oct 8 01:49:25 2010 +0000
Remove libglusterfsclient option from gld-dm benchmarking tool
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 968 (gluster client encountered out of memory very quickly when running glfs-bm)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=968
commit 1736aa7cec3d5256ed82ce3b0e6d03b983e02db6
Author: Pranith K <pranithk@gluster.com>
Date: Wed Oct 27 05:10:19 2010 +0000
mgmt/glusterd: update brick-count as soon as it is added in add-brick
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2023 (add-brick fails in regression)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2023
commit c0d4f30261b641eb7de875ea3eae3ebd81a8ecc0
Author: Pranith K <pranithk@gluster.com>
Date: Wed Oct 27 04:55:03 2010 +0000
mgmt/glusterd: glusterd_is_local_addr implementation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1855 (Initial server in a cluster not a friend)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1855
commit b670d822a3a54f95ef39a2937878c6a76d38766c
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Oct 21 04:51:47 2010 +0000
added a test script to test rpc procedures
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 6820b71e901ec9920138a4e5bd78e935f6b6eeb2
Author: Csaba Henk <csaba@lowlife.hu>
Date: Wed Oct 27 04:33:15 2010 +0000
libglusterfs: fix buffer overflow in gf_string2int()
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2022 (gf_string2int() overflows target pointer)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2022
commit 963094138efef9da5b12f4fb453a5b00c3c0bef8
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Oct 27 03:07:29 2010 +0000
mgmt/glusterd: Unlock upon a cli request failure
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1873 (Stop volume gluster command execution failed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1873
commit cc56940d91e292c9b16e583f16ee9b213a2feabb
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Oct 6 05:23:44 2010 +0000
distribute: bring in statfs normalization
We had normalization of statvfs structure in 'cluster/unify' translator,
with distribute, we had this section as 'TODO:'. Now, the same code is
migrated to distribute.
Thanks to <marty.rosenberg@gmail.com> for sending the patches
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1035 (The distribute translator does not handle differently sized block sizes and/or fragment sizes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1035
commit b567790c2f5a0cd9708fedb305116a9c0670ac85
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Oct 9 07:34:52 2010 +0000
log locate should check if the export directory is valid
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1871 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1871
commit 5d0f2f220e685bc03248861f2f97bd244fb6e87e
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Oct 8 07:36:55 2010 +0000
fuse: retire the faked-FLUSH-upon-RELEASE hack
Now the code has lived up to the glorious state of not relying
on getting the FLUSH whenever a file is released. So we don't need
to forge one in release for the cases when the kernel doesn't send
it.
Undo commits:
- 155ffe5c
- c50bc710
- b8779318 (partly, just release related parts)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 223 (flush not sent)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=223
commit a567866ab7a8afb67f81ed617afddee2f7298b98
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Oct 26 05:20:34 2010 +0000
report the error if a volume not in the started state is tried to be stopped
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 2010 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2010
commit 3b4d7f5bed2844ccb91dcc9879fdbe337a9090a4
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Oct 26 04:00:30 2010 +0000
volgen: macro cleanup
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit d385865b5f1fe579b5b6b95e8f0043f0d0eca354
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Oct 26 04:00:29 2010 +0000
libglusterfs, glusterfsd: add shortname resolution + optname hinting support to VOLUME SET
Trie code used for hinting is contributed by Avati.
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit 01427ee44f5b90eef6e65a0c30659ab40d216206
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Oct 26 04:00:28 2010 +0000
libglusterfs: fix graph mem types
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit f5d597379863b4e5c7a4182d1e43133c305c5c06
Author: Pavan Vilas Sondur <pavan@gluster.com>
Date: Tue Oct 26 03:58:59 2010 +0000
glusterd-volgen: Fix division by zero clang warning.
Also clean up surrounding calculations a little bit.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1089 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1089
commit b619808f7fe99d74b3a994435364aaa85eb43dbd
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Oct 26 06:39:08 2010 +0000
nfs3: Translate ENOTCONN into IO error for client
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1923 (Unknown error 526 when one of the subvolumes for distribute is down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1923
commit f3bf01d83855d5a82456e098c6a9b199411e7625
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Oct 26 06:39:07 2010 +0000
nfs-rpc: Fix log message for unsupported program
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1973 (Unnecessary log message "RPC program not available")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1973
commit ed42f525d4c7a5119329e9e752cde1b9a049ed2a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Oct 26 06:39:06 2010 +0000
core: Use lru_limit as count for inode and dentry mempool
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1948 (For each subvolume started, glusterfs process takes up around 30-35MB more memory)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1948
commit 23d8315e91e41f94b8668f6f88606fc0901b55e2
Author: noah williamsson <noah.williamsson@gmail.com>
Date: Mon Sep 27 07:47:11 2010 +0000
OS X: fnctl() flag FNM_EXTMATCH is not supported under Mac OS X
Signed-off-by: Noah Williamsson <noah.williamsson@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit ec029de5de6a73649f4b51eb80bbb9a1f860649c
Author: noah williamsson <noah.williamsson@gmail.com>
Date: Mon Sep 27 07:47:10 2010 +0000
OS X: Include rpc/types.h
Signed-off-by: Noah Williamsson <noah.williamsson@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 643cda81235d01126dc5c27fdf8916b3e2f62828
Author: noah williamsson <noah.williamsson@gmail.com>
Date: Mon Sep 27 07:43:49 2010 +0000
Correct enum declaration of gf_dump_procnum, fixing duplicate symbol error when linking on Mac OS X
Signed-off-by: Noah Williamsson <noah.williamsson@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 5d6b6819b03d6600b69133eeaa628b41997ab9db
Author: Csaba Henk <csaba@lowlife.hu>
Date: Tue Oct 26 03:56:32 2010 +0000
fuse: "terminating upon EBADF" log message is confusing, set its level to DEBUG
Signed-off-by: Csaba Henk <csaba@lowlife.hu>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1887 (logging mess)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1887
commit ee638c1dc118a30ca53f8e437f333a113e3d0117
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Oct 9 15:46:40 2010 +0000
server: parse more precisely when validating auth options
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1885 (auth validator in server parses too sloppily)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1885
commit f1d83a46922d987772a3f4456914e07e76b1f973
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Oct 24 23:44:34 2010 +0000
rpc-transport/rdma: create request_context only if message contains read chunks or write chunks.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1992 (glusterd crashed while submitting a callback.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1992
commit eaccbf9822a5a2bbdc2ff991b7e7fa89ecf38ed8
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Oct 21 02:25:49 2010 +0000
rpcsvc: handle NULL deref in case of program mismatch
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1982 (rpc: crash on progver mismatch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1982
commit 89030788166299897eee7e5531bfe75ef11a0385
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Oct 14 05:56:53 2010 +0000
NULL checks in the fops of io-cache
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1757 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1757
commit 356c6f47c39211de07fda29a3c940bb7c21f35e9
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Oct 14 05:12:12 2010 +0000
io-stats: handle the case of 'cleanup_and_exit()' properly
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1933 (Segfault while expansion of volume from distributed mirror)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1933
commit b5e8908bc0cdea54ba849a3ca2d8f2805cf48068
Author: Mohammed Junaid <junaid@gluster.com>
Date: Thu Oct 14 04:14:47 2010 +0000
takes either 'y' or 'yes' and 'n' or 'no' for stop volume, delete volume and remove-brick
Signed-off-by: Mohammed Junaid <junaid@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1942 (cli: loose parsing of confirmation answer)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1942
commit 02c8ff3a5e5816ab354b53cdab7548ba63c71aea
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Oct 13 04:09:15 2010 +0000
extras: Do not check_config() for glusterd in Debian init
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 789176a45e2e7679b0fc5dbb9ead93e1c10af572
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Oct 13 01:38:20 2010 +0000
server: Don't free conf in fini.
- This will fix race condition between handling DISCONNECT event and doing
fini. Though conf need to be freed, this will be done in future where
finis of all translators are properly implemented to make sure no
corruptions.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1758 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1758
commit b577235afc04a998d9490885788400dbef06e55d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Oct 12 04:13:19 2010 +0000
rpc-transport/rdma: associate mem-pools with device instead of transport.
- this will help to reduce memory usage of glusterfs process.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit a197a1e0523df6e56b1fbc5a5e48b4423459bac0
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Oct 13 03:05:09 2010 +0000
Correct location of git repository
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1941 (wrong git url)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1941
commit d8dabceab2681b69c90b0f46e3ddd75d4c0376c4
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Oct 19 03:02:10 2010 +0000
Propogate rebalance already started error to cli
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1882 (starting rebalance while previous rebalance is still running)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1882
commit f7f3f4aae2bfd9be6bf099225a5d8216c6870c32
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Oct 25 00:11:51 2010 +0000
xlator.c/option-validation: change the log level to warning when given value is out of range.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1214 (When cache-size is given out of range, error is logged but GlusterFS starts)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1214
commit c6eecd563dc1db84ff919883baf8ad4045a74037
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Oct 14 02:34:31 2010 +0000
client: move reopen{,dir} code to handshake file
and minor log level changes
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 4e9ab4eac9aed13a87931c528a474023bad5a938
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Oct 14 02:34:01 2010 +0000
client: decrement the 'openfd' count in case of opendir_cbk too
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 922b20affd41f0a6a4bf8a2932e69f647274ed59
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 18 04:22:47 2010 +0000
server: print information about disconnected client
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 3d089e9530f966b8ff6f1efbbff3cfcca360f955
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Oct 18 05:02:11 2010 +0000
debug/io-stats: init() should also set loglevel
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
commit 7c8e541b29835276bcf6f16108199cc1ac633fbe
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Oct 18 08:15:30 2010 +0000
Log level mess clean up
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1886 (log-level mess)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1886
commit d52e12cae632bd9a136d91129e4eb294e93364cc
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Oct 19 07:50:05 2010 +0000
Remove additional failure cli msg for peer detach
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1955 (Redundant log messages when "peer detach" fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1955
commit 1e2ed1c7df45e4e594d8a00db0a8fe702624ca40
Author: Pranith K <pranithk@gluster.com>
Date: Wed Oct 20 01:20:59 2010 +0000
mgmt/glusterd: resolve the bricks before comparing uuid
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1985 (peer detach fails if bricks are not resolved)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1985
commit 9e9c83848c69ea1eb3016ca69286e629756ba28d
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Oct 21 03:38:30 2010 +0000
Solaris build: Fix linux only features
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1990 (Gluster mainline build on solaris fails with errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1990
commit 6930c3a9dfa021f7ce5889f706dc66a7c530c50a
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Oct 21 03:37:52 2010 +0000
Solaris build: Handle namespace clash for rpc-clnt.h
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1990 (Gluster mainline build on solaris fails with errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1990
commit 539ccbfc164688c6c4a112f8d04aa3bbd5a1b141
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Oct 21 03:37:27 2010 +0000
Solaris build: Remove sigtimewaitd
This part of code was stale as a result of fixes for volume start force
changes. Removing the unwanted code
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1990 (Gluster mainline build on solaris fails with errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1990
commit 09737466c49fadac1cb81578834ed8c495e68f24
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 21 04:06:49 2010 +0000
nfs3: Correctly funge solaris root lookup FH for DVM
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1997 (Solaris mount fails with "RPC program not registered")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1997
commit 7032bf9f3e931b25337f8d3fc6c737f3f7217c1d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 21 04:06:48 2010 +0000
nfs: Fix volume-id option declaration
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1972 (xcs get doesn't work with gNFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1972
commit 9ee68c0b28ab34519c83e98906018b02a8fad6a6
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Oct 21 04:33:44 2010 +0000
do not hardcode the replace brick remote port to 34034
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1998 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1998
commit cd9b1abb63fea2287725d5604c02d3e884103949
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Oct 13 00:12:49 2010 +0000
glusterd-rebalance: if file is open, don't do rebalance
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1934 (Server segfault with 3.1 platform ISO during volume expansion)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1934
commit 4cf69e4386148bcc81f8a13019b15de91d458d65
Author: Vijay Bellur <vijay@dev.gluster.com>
Date: Tue Oct 19 06:20:24 2010 -0700
Revert "glusterd-rebalance: if file is open, don't do rebalance"
This reverts commit 6e6b4b4fd002347ca08691f73e10b961f693d754.
commit a6579dcea7c8385ada1fb452353d84cf547e1ea6
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Oct 12 04:09:35 2010 +0000
glusterd-rebalance: if file is open, don't do rebalance
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 046d5717869c881cd6f35c3e66fa74a17c83c68d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Oct 12 03:54:31 2010 +0000
rpc-transport/socket: initialize fragcurrent pointer in correct state while reading vectored replies.
- If fragcurrent is initialized in the same state which reads payload data,
there is a possibility of it getting reset during partial reads from socket.
Hence it should be initialized just before entering the state which reads
payload data.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1929 (different value is logged for read header size for multiple reads)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1929
commit 77440babdaaa607d83e0187893d29e259e027be6
Author: Pranith K <pranithk@gluster.com>
Date: Tue Oct 12 03:08:46 2010 +0000
mgmt/glusterd: create brick path if does not exist
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 4b9e78b11ee95b8bd54fd541120a597f464fc47b
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Oct 12 03:06:30 2010 +0000
Change assert to GF_ASSERT
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 0bb709d764eb3de9c870e2b7a7f2ee71e52b80a8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Oct 12 02:21:16 2010 +0000
rpcsvc: calculate dump response length instead of hard coding it.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 37151ce6f48b3fe9f6dff5a076aff32680533889
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Oct 12 02:26:34 2010 +0000
rpc-transport/rdma: by default use infiniband port 1
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit d1d237d929f6d17e3d9e6b58dc65301b9b10035d
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 12 02:25:46 2010 +0000
nfs: avoid assignment of structure pointer into serialized buffer
With the introduction of variable sized file handle feature in NFS,
on-wire lengths of file handles can be lesser than file handle structure
of code. Direct pointer assignment into the offsetted buffer and
dereference and result in reads beyond the end of buffer and crashes.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 999 (Crash in nfs3_fh_resolve_and_resume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=999
commit b1d729f8e1e703a2d1ae65450a469bdf8368dfe8
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Oct 8 00:25:30 2010 +0000
check if fd is NULL before accessing it in fuse_open_resume
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1858 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1858
commit a227f69312d930145ecea565fe16540e2151b04c
Author: Harshavardhana <harsha@gluster.com>
Date: Fri Oct 8 17:43:36 2010 +0000
Add mount.glusterfs to fuse since its only needed for native client
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1770 (Cleanup rpmbuild)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1770
commit ccbcb653ff77050d773813f463626663b9ed8504
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 12 01:22:28 2010 +0000
nfs: re-implement logic to perform fresh lookups when lookup revalidates fail
- implement lookup to pass via inode layer so that looked up entries make it to inode cache
- implement lookup revalidation failure check in the fop layer
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit 0b06c4148d8fa1487a81e5071934e679594ed410
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 12 01:22:11 2010 +0000
Revert "nfs3: Revalidate inode on receiving ESTALE on lookup"
This reverts commit f5afcc47f9f00472d6c2b3f48127e02332cd457a.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit c05e3d969c2219f93c811ad9c1dfcba6f6d06122
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 12 01:21:51 2010 +0000
protocol/client: prevent propagation of CHILD_DOWN after pmap query
pmap query results in a new port to which the rpc client reconnects.
This involves disconnection of current connection to pmap which was
propagating CHILD_DOWN upwards prematurely
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit a04c4bfa5529fb4ca32702506ed16407e290b71d
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 12 01:21:32 2010 +0000
protocol/server: be consistent in setting rsp.dict_len and rsp.dict
in cases where op_ret was -1 and dict was not NULL, the code was
setting a dictionary length but not the serialized dictionary. This
would cause crashes in the xdr serialization function
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit b40db86a31af70ace2a852691bd9bae79c24416a
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Oct 11 15:17:18 2010 +0000
unwind if layout is NULL in getxattr for dht
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1917 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1917
commit 06bd397c0faf83d1b8c600c3115d2b1f5c335483
Author: Vijay Bellur <vijay@dev.gluster.com>
Date: Mon Oct 11 12:32:04 2010 -0700
Revert "nfs: re-implement logic to perform fresh lookups when lookup revalidates fail"
This reverts commit 563ef3d12f8d7a927b403d04c279d9fc702faad0.
commit 06c9f118243a623bdd4a0f2dcedeb1fae72cf753
Author: Vijay Bellur <vijay@dev.gluster.com>
Date: Mon Oct 11 12:31:26 2010 -0700
Revert "Revert "nfs3: Revalidate inode on receiving ESTALE on lookup""
This reverts commit 6dd3b7fa3bc7acf9281cc17f08010675e2297089.
commit f2932c4ae1d734149442ab8b7166228e7b8044ba
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Oct 11 12:13:51 2010 +0000
mgmt/Glusterd: fixes in volume reset
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
commit 856b7e840b9415140cd2105b2a6ad85cafbcbda6
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Oct 11 09:13:27 2010 +0000
Remove references to COPYING.* files
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 3705cfc325f21d8ffc7595986e3eea1291e46296
Author: Anand Avati <avati@gluster.com>
Date: Mon Oct 11 07:30:55 2010 +0000
dht: change behaviour CHILD_UP/DOWN/CONNECTING event propagation
The first CHILD_UP/DOWN/CONNECTING event to pass dht upwards should be only after
all subvols have reported their status atleast once.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1643 (Initial requests after mount ESTALE if DHT subvolumes connect after nfs startup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1643
commit d29419c4fe9f92794984ea4faf5d3bc623ac9cf5
Author: Anand Avati <avati@gluster.com>
Date: Mon Oct 11 07:30:30 2010 +0000
Revert "distribute: Propagate CHILD-UP when all subvols are up"
This reverts commit 6b2e2fb0903fc56105c267881f202a4865a8b6c7.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1643 (Initial requests after mount ESTALE if DHT subvolumes connect after nfs startup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1643
commit 44d5338a7b9f0e2bf3adca9a510d078d261dc4e9
Author: Anand Avati <avati@gluster.com>
Date: Mon Oct 11 06:43:35 2010 +0000
nfs: re-implement logic to perform fresh lookups when lookup revalidates fail
- implement lookup to pass via inode layer so that looked up entries make it to inode cache
- implement lookup revalidation failure check in the fop layer
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit 7b36c1b5762e86b8be3b87cac46bf305cb6ec7cc
Author: Anand Avati <avati@gluster.com>
Date: Mon Oct 11 06:42:39 2010 +0000
Revert "nfs3: Revalidate inode on receiving ESTALE on lookup"
This reverts commit f5afcc47f9f00472d6c2b3f48127e02332cd457a.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit 7d60ec8e062a1064378bd0bc75f73817762c7dda
Author: Pranith K <pranithk@gluster.com>
Date: Mon Oct 11 06:42:32 2010 +0000
Set correct logging level for log messages
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1887 (logging mess)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1887
commit 1582f7d33f5802080ad10371ed155f557d73e01d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Oct 11 06:03:40 2010 +0000
features/locks: free fdctx in release.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1438 (memory leaks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1438
commit 3700365503d203931016e3895334f3728b3f9995
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Oct 11 08:38:19 2010 +0000
Copyright changes
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit a525cf254a578bf309bd2a5cc2dbc04dc8890748
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Oct 11 06:18:07 2010 +0000
Do graph init after topology change
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 7cdd28884868393b04eb0aab5968ea5532117dd4
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 11 00:04:57 2010 +0000
fuse_loc_fill(): handle a case of NULL dereference
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1889 (gluster FUSE client crashes on irregularity)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1889
commit a6b9166a8362b59432436e237b3ece6a649a92c8
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Oct 11 04:28:30 2010 +0000
get the remote-host option from the dictionary in reconfigure
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1898 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1898
commit 9aadb1a87af26714ee9027707848a23aa70e9be5
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Oct 11 03:49:45 2010 +0000
Add log-level validation for volume set command
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1886 (log-level mess)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1886
commit 66c4e305ffba9cd001aa6eb28f1e6258450b1515
Author: Pranith K <pranithk@gluster.com>
Date: Mon Oct 11 03:26:00 2010 +0000
mgmt/glusterd: handle reqs from unknown peers for friend sm
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1838 (handle peer detach gracefully in case of lost frames)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1838
commit 45d4e896c1023fa82f0260f6f3f55d9365c75232
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Oct 11 02:23:18 2010 +0000
Add confirmation to volume delete command
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 62f29e7b90d08010c9342157225603d3e0579f17
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sat Oct 9 06:58:00 2010 +0000
mgmt/Glusterd: Memory leak fixes, minor CLI changes
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1852 (Usage message of volume set printed twice)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1852
commit 22419e85a820b9811df9afcf9a93c851e55b5ffa
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Oct 8 09:52:52 2010 +0000
io-stats, volgen: make the distinction between client and brick loglevel in volgen's scope
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1789 (add log-level options to volume set)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1789
commit 12808c0da09f66b186fea3b4633ceca1fc3c80b3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Oct 8 20:21:59 2010 +0000
rpc-transport/rdma: fix the bug which was causing an ioq-entry being mem_put twice.
- in case of failure to send message, ioq-entry would be freed, but it used to
get added to the ioq-list. Failure in sending a message (for reasons
other than insufficient quota), would result in transport being
disconnected. In the process of handling pollerr, when ioq-list is flushed,
the same ioq-entry which would've already been freed, would be freed for
second time.
- this patch also fixes spurious disconnects happening when quota was not
available while sending a request.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1854 (GlusterFS 3.1 beta crashes over Infiniband with rdma issue)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1854
commit 0bf021c5331b5d0e0f6e94aa0714e9bc2568d02c
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Oct 9 07:41:14 2010 +0000
set keepalive for client connections
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1802 (Gluster volume creation failed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1802
commit d02c5934a228b1a802add5dff9f693eb1a5bde7e
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Fri Oct 8 10:34:18 2010 +0000
mgmt/Glusterd : Volume info fixes
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1872 (gluster volume info is not working with qa42-)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1872
commit 461b715e451a8744be6c1c0b229984e7f9162716
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Oct 8 10:17:55 2010 +0000
rpc-clnt: do rpc_transport_destroy() in rpc_clnt_destroy()
handles the case of peer detach properly
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 8d8781c547625e51dbff125a8988b72aef6c3ba1
Author: Pavan Sondur <pavan@gluster.com>
Date: Fri Oct 8 07:06:57 2010 +0000
mgmt/glusterd: Fix replace brick to pass src-brick and dst-brick port nos properly.
Fix also contains patch from shishir ng for maintaining replace-brick
states in glusterd.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit e49761dd683b132e1f40bb72bb8ac4e7e723ef27
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Oct 8 07:01:42 2010 +0000
rpc/clnt: allocate a new cbk_program before registering it.
- Refer Bug 1836 for more details.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1862 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1862
commit 7e25a44ff538b4fd416f7885d7cf8e3944fbb808
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Oct 8 06:58:51 2010 +0000
migrate from port 69* to 24007
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1870 (Change the port from 69* to some other ports.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1870
commit 3c26b1b6278fcc9eaca259189ea794bd0adb0419
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Oct 7 03:20:59 2010 +0000
Possible race condition between cleanup and dereferencing
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1760 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1760
commit f9ea68502acd940f75838f91ca55d9e34f2095ab
Author: Pranith K <pranithk@gluster.com>
Date: Fri Oct 8 01:37:54 2010 +0000
mgmt/glusterd: memory leak fixes
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1726 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1726
commit 27248e53d699c34532abadf71eac1fbcced5aa2e
Author: Pranith K <pranithk@gluster.com>
Date: Fri Oct 8 00:19:17 2010 +0000
mgmt/glusterd: print state, event names for numbers in friend sm
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1847 (print event names, state names instead of numbers for FSMs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1847
commit b2865921278d5d6c16f8518321b312bb51d8b0d8
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Oct 8 04:54:36 2010 +0000
support for configuring keepalive idle time
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1802 (Gluster volume creation failed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1802
commit 644785d435a1bf0638246d908395321fe6783c10
Author: Pranith K <pranithk@gluster.com>
Date: Thu Oct 7 10:15:18 2010 +0000
mgmt/glusterd: Always kill nfs with SIGKILL
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1853 (kill nfs process with SIGKILL while restarting)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1853
commit 4ccc864d95c08a5dd5feda3b4b3b13d9757dcfb4
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Oct 7 07:26:14 2010 +0000
Glusterfsd Crash in server_link_cbk
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
commit 0b819e907daa497c08c758e385588019a921eecf
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Oct 7 06:37:12 2010 +0000
mgmt/Glusterd: Volume set enhancements
- performance.flush-behind, transport.keepalive added
- volume info to display the options reconfigured
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
commit add83d894a40c18184e7fdf13194deaf0f5e46de
Author: Pranith K <pranithk@gluster.com>
Date: Thu Oct 7 04:41:28 2010 +0000
mgmt/glusterd: Change event, state numbers to names for op-sm
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1847 (print event names, state names instead of numbers for FSMs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1847
commit 964359251f2b98a77d17a90610bc3d73395eba1d
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Oct 7 05:56:22 2010 +0000
protocol/rpc/transport: bring in one more event for 'TRANSPORT-DESTROY'
needed because, a RPC disconnect doesn't mean that a RPC transport/listener
is dead. With this, the race in server protocol cleaning up the lock table /
fd table when some frames are in transit will be handled properly.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1843 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1843
commit b193f1ba9dd5770f9d175a25c0dea086dac0d61d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 7 05:50:53 2010 +0000
nfs3: Fix gfid to ino conversion
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1724 (kernel untar fails during add-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1724
commit ffb6f4082cc63c3bf48ef19795315a7f70daa8b8
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 7 05:23:59 2010 +0000
nfs: Revert downed-subvolume changes
For the record these are the patches committed as:
1. "nfs, nfs3: Base volume access on CHILD-UP-DOWN event"
http://git.gluster.com/?p=glusterfs.git;a=commit;h=f47b0c55de9941823fbefe4b3a7e37179d6d4329
2. "nfs: Fix multiple subvolume CHILD-UP support"
http://git.gluster.com/?p=glusterfs.git;a=commit;h=336e2df7b74be7ad4c9ed403ca10b9f7f7ef9a58
3. "nfs,nfs3: Disable subvolume on ENOTCONN"
http://git.gluster.com/?p=glusterfs.git;a=commit;h=8c6e27cdaf895e3031c3256efb9472a6c0bf61f3
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1724 (kernel untar fails during add-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1724
commit 273a99239135f763d50471b9726b3225c12d36f9
Author: Anand Avati <avati@gluster.com>
Date: Thu Oct 7 05:58:06 2010 +0000
lock recovery: temporarily disable lock healing
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 865 (Add locks recovery support in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=865
commit 0b6c767ba48061e2c987b3fb4383a034bd60cb28
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Oct 6 08:00:18 2010 +0000
rpcsvc: allocate a new program structure before registering it.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1836 (server is hung in infinite loop while trying to search for an actor during request processing)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1836
commit 31e5598cc87488dea003cb3f4b5004943dec4640
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Oct 6 04:44:14 2010 +0000
transport: set 'trans->options' before calling 'trans->init()'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 47c680c0c8588114c2bb3f336609db1f84ba5166
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Oct 6 07:32:07 2010 +0000
changes for the sanity script
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1436 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
commit 5e4484f7985b1248f95b028c5de6aa3de7d1944c
Author: Pranith K <pranithk@gluster.com>
Date: Wed Oct 6 02:04:01 2010 +0000
mgmt/glusterd: set the return value in case of failure
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1823 (add-brick fails first time but works in next attempt)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1823
commit b25d5e76b8b680cf32b4c79c17c7a09e8472cb0f
Author: Pranith K <pranithk@gluster.com>
Date: Tue Oct 5 08:02:41 2010 +0000
mgmt/glusterd: dont access req after reply
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1726 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1726
commit af72ab495ffa3546188683df700fcd3556c2d35e
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Oct 5 07:48:21 2010 +0000
cli: fix Number of bricks output
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1815 (gluster volume info - Number of Bricks field)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1815
commit 7983fded923df8ea21d514ff6cea151375f48492
Author: Pranith K <pranithk@gluster.com>
Date: Tue Oct 5 07:34:45 2010 +0000
mgmt/glusterd: send volume options to friend
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1816 (send volume options in friend add)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1816
commit a25eec2f982025d8b5ba1734d3586ca17ee67f9b
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Oct 5 07:02:07 2010 +0000
Reply back to CLI on error, by validating each xlator's opts
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
commit 73121861a9f7bfe4c76c245a2a79d67e589954b4
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Tue Oct 5 07:01:52 2010 +0000
mgmt/Glusterd : Reply to CLI error: graph construction
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
commit 9089f488ece522901ec1df1105cbe648bcf8038e
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Oct 5 06:40:32 2010 +0000
features/locks: Handle lock upgrade and downgrade properly in locks.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Pavan Vilas Sondur <pavan@dev.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1017 (Locking deadlock when upgrading lock)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1017
commit 6f583fadcddaafd862dc42dc0208ed5d83cffeb3
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 5 05:07:37 2010 +0000
replicate: use the new rmdir prototype for cleaner entry self-healing
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1761 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1761
commit 19d85b89c52924d95ecc0b9fd260e4f0397f7b50
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Oct 5 04:48:27 2010 +0000
features/locks: cluster/afr: Misc fixes for lock recovery.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 865 (Add locks recovery support in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=865
commit 1ff7eccba1717e7400d2b8a75f81e486ad991ec7
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Oct 5 03:50:06 2010 +0000
glusterfsd: '-f' option help update
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1809 (glusterd help text for -f is wrong)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1809
commit 9f120e18573bae15f8be4106051e72b4b3a3c963
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Oct 5 03:49:39 2010 +0000
rpm spec file: add proper Obselete keys
Thanks to Bernard Li <bernard@vanhpc.org>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1808 (Allow RPM upgrade from glusterfs 3.0.x to 3.1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1808
commit b3c3e3360bc65ffc4652b9c64aecd79527eea7aa
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Oct 5 01:58:46 2010 +0000
nfs3: Convert gfid to ino only for non-root
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1724 (kernel untar fails during add-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1724
commit a6ccc5f9f2675abd1ae13542f2155b4aefb33504
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Oct 5 00:24:40 2010 +0000
Do not exit to shell after gluster help if readline mode is not enabled
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1709 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1709
commit 771a35d49987cca57bb95ef173bb406c6541c27b
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Oct 4 17:57:59 2010 +0000
volgen: add interface to complete option names from specifier (after-dot) part
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit 0cb3a6246600317b01ebf7a5e185e9a5071602c4
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 4 22:15:57 2010 +0000
distribute: check for 'conf' before dereferencing it
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1806 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1806
commit 4ae6b08035c14b7025d92c0a5381b1975c579545
Author: Harshavardhana <harsha@gluster.com>
Date: Mon Oct 4 17:54:12 2010 +0000
init.d: Path not resolved during compilation to actual prefix
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1810 (qa 40 glusterd path is hardcoded, won't start by default.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1810
commit 4cbb0c584e9954938c5648f57ae191e678f71f0f
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 4 13:51:29 2010 +0000
glusterd: more sanity checks during restart
* check for validity of pid file before doing pmap search, as in
few cases, pmap_signin() may take more time.
* remove stale code from 'init()'
* update pmap->last_alloc during restore itself to handle glusterd
restarts more agnostics to port collisions
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 276d5966fa0cff594397b57925b45bd09b91b53a
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 4 13:28:00 2010 +0000
fuse: handle the case of NULL dereference
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1798 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1798
commit 66bf9780097870ec6f3cf2e42e60255503a15353
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 4 13:27:43 2010 +0000
glusterd-volgen: fix the auth.allow/auth.reject keys
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1798 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1798
commit c35607fa09fcb5a8a4b120f8ca1d8eaa23a0ed52
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Oct 4 12:15:34 2010 +0000
cli: mgmt/glusterd: Add commit force op to replace-brick
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit ffd0d1c37d2c51b684cb490af62b08ffb47246e1
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Oct 4 11:24:43 2010 +0000
volgen: revise option list for VOLUME SET
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit d15a034730388bf0cfb63e1829fbd915259527e7
Author: Pranith K <pranithk@gluster.com>
Date: Mon Oct 4 11:20:38 2010 +0000
mgmt/glusterd: dont change ret val in cmd handlers if fails
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1726 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1726
commit 0c823d5112d27abae9d6308092ebf75d6c23aed8
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Oct 4 11:19:23 2010 +0000
mgmt/glusterd: cleanup during detach
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1765 (peer probe on removed-detached bricks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1765
commit 5adbe9d6d201b976309c0d68373bfc8d4b4c9372
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 4 11:01:14 2010 +0000
rpc: don't refer to 'req' after calling 'prog->actor()'
there are chances that a error reply is sent to client from actor,
in which case, 'req' would be free'd and accessing it would result
in error.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1790 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1790
commit f0d1b26f6e25abb50aec77df137c0c96232dbed4
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Oct 4 10:59:08 2010 +0000
initialize the list earlier while handling create volume and add brick
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1726 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1726
commit 2079a203b8379861d96492d4b9b6b5653d60702a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Oct 4 10:06:08 2010 +0000
nfs3: Convert gfid into inode number
..avoids stale file handle errors at the client when client detects
changing inode numbers from the server.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1724 (kernel untar fails during add-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1724
commit 5fb6b0ff0a5063a447b0a9f5aacf2d64c234ba75
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Oct 4 10:06:07 2010 +0000
nfs,nfs3: Disable subvolume on ENOTCONN
..so that nfs does not return an error to the client, instead
the subvolume gets disabled till it comes back up again.
The client is expected to keep retransmitting requests in the mean time.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1724 (kernel untar fails during add-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1724
commit f3a3c3629c20ce11130ceece29bbae524a5c9f37
Author: Pranith K <pranithk@gluster.com>
Date: Mon Oct 4 08:54:55 2010 +0000
mgmt/glusterd: added new brick validation functionality
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1726 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1726
commit 83e3aa092e3c50e74ef23bfdbe1df0dc31b4db18
Author: Pranith K <pranithk@gluster.com>
Date: Mon Oct 4 08:44:11 2010 +0000
Change GNU GPL to GNU AGPL
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1388 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1388
commit 7961211abf7f999beaa4f0df5d8927ede834089f
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Oct 4 08:18:19 2010 +0000
cluster/pump: mgmt/glusterd: Misc fixes for replace-brick
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 4bdca0801bd94b44f13af67f223f3d54d2864137
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Oct 4 08:11:27 2010 +0000
implement volume level address allow/reject setting
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit 55e8142c1cdabed23dd8492806dea0dc7e7c0166
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 4 08:02:29 2010 +0000
stat-prefetch: reduce the stat-prefetch mem-pool size
because we are not calling 'fini()' on old graph, after every graph
change, we are leaking lot of memory. Hence reduce the foot-print for
now, bring in changes to call 'fini()' later.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 9891f9df329fd02d37be2f5da4a273829dd1ed84
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Oct 4 07:45:08 2010 +0000
Additional status check for rebalance in progress
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1791 (remove-brick during rebalance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1791
commit 24b4ee3f942ebafe8d8fa96fcfefaa6d76f603f0
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 4 07:38:11 2010 +0000
/etc/init.d/glusterd (for RPM based distros), fix output format
Thanks to Bernard Li <bernard@vanhpc.org> for the patch
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1677 (Fix output formatting for Red Hat init script)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1677
commit e6de949b760dc780e0316a01b88fcc24b253ff29
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Oct 4 06:47:35 2010 +0000
Add log-level option to command volume set
log-level option to set brick's log-level
client-log-level to set client's log-level
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1789 (add log-level options to volume set)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1789
commit d880570dc86cfe07aecd1ff12e1fbedf5a8b9164
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Oct 4 06:32:47 2010 +0000
cli: add more type for volumes
Added 'Distributed-Replicate', 'Distributed-Stripe' as types
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 245a19a6403f9cab77be5330b512fef95e8442d5
Author: Harshavardhana <harsha@gluster.com>
Date: Mon Oct 4 04:50:53 2010 +0000
Some cleanup in rpm specification file
Thanks to Bernard Li <bernard@vanhpc.org> for rdma 'BuildRequires' fix
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1770 (Cleanup rpmbuild)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1770
commit 9495a5ded9a1e3a7f6cba6f578b4f55141a2f626
Author: Pranith K <pranithk@gluster.com>
Date: Mon Oct 4 02:50:55 2010 +0000
mgmt/glusterd: update volumes on friend update
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit b24a0aaac0d6b0cb1ab4e3fa6df6a2f31e6cd159
Author: Pranith K <pranithk@gluster.com>
Date: Mon Oct 4 02:17:09 2010 +0000
mgmt/glusterd: update volumes from friend
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1784 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1784
commit afd46ff3dcb4814ac4950fa9b23211ff8c2ea022
Author: Anand Avati <avati@gluster.com>
Date: Mon Oct 4 00:29:17 2010 +0000
rpcsvc: bump log level of message for missing transport type
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit e8a471de2c21245c44a3ea734fd2527396170df4
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Oct 3 14:57:11 2010 +0000
volgen: impemlent dynamic (pattern-based) option matching
So now auth.addr.*.allow can be a basic option, without any specific support code!
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit 91b5d3d3583cc95059b8057d877b1fac2db829eb
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sun Oct 3 02:41:29 2010 +0000
mgmt/Glusterd: new command volume reset <volname>, volume set enhancements
- Write the reconfigured options in 'info' file to make it persistant
- Implementation of volume set <volname> history
- Implementation of volume reset <volname>
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
commit 61fe4d6b5b5b009fae998175899d0f30aedba6c7
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Oct 3 04:14:19 2010 +0000
mgmt/glusterd: changes for detach everywhere
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1765 (peer probe on removed-detached bricks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1765
commit 30d889ea2fa6ef33b2d4f5cb1c768149a3a22f6a
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Oct 2 18:44:16 2010 +0000
volgen: add a precise getter function which considers default values as well
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit 87e74d254b653a1cf92b88a052e3cd6991042686
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Oct 2 18:44:15 2010 +0000
volgen: add support for auth.addr.%s.{allow, reject} options
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit d00d03849daca935434e29b18d77dfcb17d71557
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Oct 2 18:44:14 2010 +0000
volgen: fix up replace-brick + pump generation
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit 6551078c2c50fff3e70992d707b5b018f4d3fdad
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Oct 2 18:44:13 2010 +0000
volgen: some refactor to make frequent invocations more handy
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit 10e8e652e6ede0a010c0b9206febf8247c1e5c74
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Oct 2 11:25:05 2010 +0000
rmdir: introduce extra flags parameter in FOP prototype
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 6e99a1eef088288e354226a93ab5f02229f34368
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Oct 2 11:25:04 2010 +0000
xdr: introduce extra flag in rmdir request
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 6576f96ea837669ac799ebd68a37c031d08f8d90
Author: Pavan Sondur <pavan@gluster.com>
Date: Sat Oct 2 08:29:38 2010 +0000
Set the lock owner properly for lock self heal.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 865 (Add locks recovery support in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=865
commit 1e96f6920f22474d3e67a713a420798e76e7f608
Author: Pavan Sondur <pavan@gluster.com>
Date: Sat Oct 2 08:03:44 2010 +0000
cluster/pump: Do not do lookup if it is "." and ".." in pump.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 28286d93ea963685101e435513cb2a7c320e911a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Oct 2 07:36:33 2010 +0000
rpc-transport/rdma: send disconnect event only if the transport is already connected.
- A disconnect event can be sent before a connect event to rpc, if some error
happens during rdma handshake.
- Also call rdma_quota_put only if peer is not NULL.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit 9f305ec03c826ae1ccaacb30403a326fc626aa61
Author: Pranith K <pranithk@gluster.com>
Date: Sat Oct 2 04:12:51 2010 +0000
mgmt/glusterd: print peer state names instead of state numbers
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1779 (print peer state names instead of state numbers)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1779
commit 95e6c406f0eeee7613b921e0d7181c6089aae32d
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Oct 2 07:30:39 2010 +0000
volgen: reimplement volgen
Generating a volfile occurs in two steps:
- Build a graph (ie, glusterfs_graph_t instance) by graph manipulation
primitives
- Write out the graph to a file by the the graph printing API.
Graph builder routines can optionally make use of a "modifier dict",
which can contain overrides wrt. volume options. This can be used
for a "dry-run" graph generation.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit aac839dcab060f404f77d2618f6c25909b7e1197
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Oct 2 07:30:38 2010 +0000
implemented graph printing
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit 839f4c3cd04ef90a40ba0e28dde7e0267b554412
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Oct 2 07:30:37 2010 +0000
xlator: make it possible to do type setting and dynamic loading separately
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1750 (clean up volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1750
commit 111295d91e752e90bcbadff17f4333d753a5db19
Author: Pavan Sondur <pavan@gluster.com>
Date: Sat Oct 2 06:14:33 2010 +0000
protocol/client: Fix dumping of locks in client.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 865 (Add locks recovery support in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=865
commit b391eb47b675f3b54d511709c903062b376785c7
Author: Pranith K <pranithk@gluster.com>
Date: Sat Oct 2 05:31:55 2010 +0000
mgmt/glusterd: destroy frames in callback
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1726 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1726
commit bc69f4f1cf1b8103121bff500acf77c2e98e2952
Author: shishir gowda <shishirng@gluster.com>
Date: Sat Oct 2 02:14:07 2010 +0000
Replace assert in mem_put with gf_log_callingfn
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1759 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1759
commit c80afcbd021d7417f17a0ece0261ebd9f908ee4e
Author: Pranith K <pranithk@gluster.com>
Date: Sat Oct 2 01:36:16 2010 +0000
mgmt/glusterd: handle peer not connected in peer detach
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1762 (peer detach/peer status ,created glusterd crash)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1762
commit fa71d77ce90de52cd28659581c9e69aa5f4ff5fe
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Oct 2 00:23:31 2010 +0000
debug/trace: print more information while logging inodelk and finodelk.
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit b1a6b1a53aa633f375f9fa8d50d585f7301e5332
Author: shishir gowda <shishirng@gluster.com>
Date: Sat Oct 2 01:21:35 2010 +0000
get server xattr only if name is not NULL
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1701 (better statistics gathering in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1701
commit dc28f21c04861d650ed54c9b821b307210c4744e
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Oct 1 13:04:57 2010 +0000
rebalance: bring in two stages
step 1: fix layout (quick pass, so the newly added brick can
participate in distribute's entry creations)
step 2: migrate data (do the actual rebalance)
Its advised to run rebalance after add-brick, and let it complete
at-least 'step 1', so things will be smooth with distribute.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 3a0c8b007e4da22bf87a9b5e1ace1abe4eb818f1
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Oct 1 13:03:58 2010 +0000
glusterd: put all the code related to 'rebalance' in new file
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit bec3b34c57f0cd711e7ddd3a2a0b33317f87069d
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Oct 1 09:23:40 2010 +0000
changes for replace-brick status message
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1767 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1767
commit f068f6e3aee3ac8af85d1d0850dec522a5f2d3ff
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Oct 1 08:01:14 2010 +0000
stat enhancements
* dht to send 'setxattr' to all subvolumes in the layout
* server dumps info on total bytes read/written for 'trusted.io.stat.dump' key
* server dumps all the mount point IP for 'trusted.list.mount.point' key.
* io-stats dumps latency information only if measured
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1701 (better statistics gathering in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1701
commit 193a4381001d048c23062625c5728c801995ae0c
Author: Pranith K <pranithk@gluster.com>
Date: Fri Oct 1 08:00:12 2010 +0000
mgmt/glusterd: handle glusterfs crashes for start/stop of bricks
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1741 (gluster volume stop after one process crashed.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1741
commit 1910ecfc890f23f3f2092ee8c99861dcc0449065
Author: Pavan Sondur <pavan@gluster.com>
Date: Fri Oct 1 05:45:12 2010 +0000
Changes to replace flock with gf_flock across GlusterFS.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 865 (Add locks recovery support in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=865
commit b0f79a6f8e4278ac82e7280a1e4803b32a73009f
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Sep 30 12:44:26 2010 +0000
contrib/fuse: update from upstream [555d6b50 in git://fuse.git.sourceforge.net/fuse/fuse]
"""
commit 555d6b504308eac6b976321ce938ee4bec62c354
Author: Miklos Szeredi <mszeredi@suse.cz>
Date: Tue Sep 28 10:13:24 2010 +0200
Fix option escaping for fusermount.
If the "fsname=" option contained a comma then the option parser in
fusermount was confused (Novell bugzilla #641480). Fix by escaping
commas when passing them over to fusermount.
Reported by Jan Engelhardt
"""
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1752 (sync with upstream for "Fix option escaping for fusermount.")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1752
commit 3092bbe694fa946a55a33c4a65b16b43165e38e1
Author: Pavan Sondur <pavan@gluster.com>
Date: Fri Oct 1 04:33:49 2010 +0000
cluster/pump: Initiailize pthread mutex and saved fds list.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 865 (Add locks recovery support in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=865
commit 046e24291c6d5dfc8aff9b58ce4c628c17a36651
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Oct 1 04:21:17 2010 +0000
remove 'gfs_id' field from all protocol xdr structures
It was kept as a debugging requirement/placeholder. Because RPC is
mostly bug free with regard to basic xdr structures, it doesn't
make sense to carry this forward in release. Saves 8bytes in each
request.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit ed8a180ad22e3a0c083b22b7e9bcc5c905269aad
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Oct 1 02:22:08 2010 +0000
check if the table is NULL before accessing it
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1757 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1757
commit 915b003ecbb9fe30b61a97f15130fd48849dfd07
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 1 01:58:05 2010 +0000
nfs3: Revalidate inode on receiving ESTALE on lookup
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1756 (NFS must revalidate inode on first ESTALE on lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1756
commit a7ff7faaa0f0aa8fe58db12c8654771c3aa3c3f8
Author: Pavan Sondur <pavan@gluster.com>
Date: Fri Oct 1 01:42:46 2010 +0000
cluster/afr: Recover locks on child_up from source to sink.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 865 (Add locks recovery support in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=865
commit 73767018221839ef38218d2566e362a7213cf652
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Oct 1 01:41:46 2010 +0000
mgmt/glusterd: Make replace-brick atomic
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit cc24b69f7976021e7dd42c19d76bc93cd237562b
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Oct 1 01:35:22 2010 +0000
changes for the gluster sanity script
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1436 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
commit b3de39cd93325ec4a9bf586a6d32603a085a99b8
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Oct 1 01:12:39 2010 +0000
Allow graph processing even if reconfigure fails
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1730 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1730
commit 02e4f63e240607e081a4e25723e3851adaf268d1
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Sep 30 11:41:07 2010 +0000
glusterfsd: perform init new graph if re-configure fails
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit bb7cc1cfd1ad31ede748f5cc893c871544e03c16
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Sep 30 02:25:31 2010 +0000
protocol/client: cluster/afr: Support lock recovery and self heal.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 865 (Add locks recovery support in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=865
commit 0791a578b4319aeab32381129ea75de1dc2162b2
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 30 09:00:14 2010 +0000
glusterd: fix in log filename and log rotate
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1731 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1731
commit 7f4dff48a424cab4a041385979b7cfdb32b9be69
Author: Pranith K <pranithk@gluster.com>
Date: Thu Sep 30 08:46:03 2010 +0000
mgmt/glusterd: memory leak fixes
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1726 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1726
commit c9cacbf8633b085687c8bb2439862179f3868473
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Sep 30 03:41:04 2010 +0000
Block add, remove and replace brick ops when rebalance is in progress
Also fixing msg, changing defrag to rebalance
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit c17b49b1152674653cb4a72c34665abf8ff6fe65
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 30 02:18:11 2010 +0000
start the per brick process with 'glusterfsd' instead of 'glusterfs'
for users, it becomes easy to differenciate which process is exporting
bricks, and which is used as a client process.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 61e905a0e670ffc9ea76d1e60ce084fa2761d032
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 30 01:49:52 2010 +0000
rpc: in rpc_clnt_destroy(), destroy the memory pool also
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1727 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1727
commit 3a2db565857244b3fae09315fe16fb4e135e0e77
Author: Pranith K <pranithk@gluster.com>
Date: Thu Sep 30 02:22:52 2010 +0000
mgmt/glusterd: remove debug messages in cleanup_and_exit
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1746 (volume delete fails after volume stop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1746
commit b707c3e078bf8f5ccdfe5b8b9a9864a84a4298bf
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 30 02:31:47 2010 +0000
protocol/client: handle more NULL dereference
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1745 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1745
commit f7acd794d605934ff87afdeb7bb54258ef9b0ccf
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 29 10:47:58 2010 +0000
protocol/server: set 'this->private' only if 'init()' is successful
If volume file is fetched (due to HUP or volume file changes) and
server init is called again, server protocol init fails with 'bind
to port failed' error. If 'this->private' is set to new 'conf'
before successful init, the whole process goes to corrupted state.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 2990b4817df72b3fd2fbfe6be2509b735f013fa7
Author: Anand Avati <avati@gluster.com>
Date: Wed Sep 29 06:53:35 2010 +0000
replicate: remove checks which prevented self-heal when open fds were present
this check is not needed anymore since the introduction of changelog piggybacking
as the optimization technique instead of first-write-to-flush technique
some of the self-healing issues with NFS mounts should be resolved
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 5d8c3d0d7ae58038c01cdfaca1514864b9a9d828
Author: Anand Avati <avati@gluster.com>
Date: Wed Sep 29 06:53:03 2010 +0000
replicate: keep read_child in inode ctx as up-to-date as possible
In every transaction check if the currently set read child in the
inode context failed in the fop and set it to another subvol on
which the latest fop has passed. This will prevent read fops landing
on subvols which have witnessed a failure.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1172 (ls -lh on NFS mount of 2-mirror replicate gives incorrect file size)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1172
commit 89212b86a18e90346b6d2a40d48d7aefa257dad9
Author: Anand Avati <avati@gluster.com>
Date: Wed Sep 29 05:41:34 2010 +0000
pump: skip "." and ".." entries while traversing dir tree
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit e9cafb88c750ab40835d12dcfd8b646405dab366
Author: Pranith K <pranithk@gluster.com>
Date: Wed Sep 29 05:08:34 2010 +0000
mgmt/glusterd: resolve uuid if null
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1734 (replace brick should accept both ipaddress and hostname for bricks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1734
commit 145e653cda4505e22bea4ea60c24ddd659f11aea
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Sep 29 04:49:53 2010 +0000
glusterd: make sure init is not called when there is no topology change
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
commit 99f75c3044d3e5852460920040d66766586a823e
Author: Pranith K <pranithk@gluster.com>
Date: Wed Sep 29 04:48:18 2010 +0000
mgmt/glusterd: set the error before starting checks
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1734 (replace brick should accept both ipaddress and hostname for bricks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1734
commit c42d1f1c275fd3b2d5f176819989aff49cd8856b
Author: Pranith K <pranithk@gluster.com>
Date: Wed Sep 29 03:59:19 2010 +0000
mgmt/glusterd: volume start force
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1736 (implement volume start force)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1736
commit 0955a730318f65d1177425cbfa8e88e1daac8b6d
Author: Anand Avati <avati@gluster.com>
Date: Wed Sep 29 03:22:24 2010 +0000
storage/posix: prevent chmod() from getting called on symlinks
symlinks, if at all their mode can be changed (on non-linux platforms)
can only be done via lchmod(). Attempting chmod on a symlink can be
disastrous.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 881 (GlusterFS daemon hangs on replication of symlink (3.0.4))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=881
commit d2767f17f786401940104751809c722556084f9a
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 28 06:11:07 2010 +0000
features/quiesce: new translator
'Quiesce' is used to describe pausing or altering the state of running
processes on a computer
In GlusterFS context, this translator looks for CHILD_DOWN/CHILD_UP
events, and will hold the requests for some time if the child node
is in disconnected state
current timeout is 20seconds, will be made tunable soon
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1500 (Mount point should not be in-accessible between reconnect to server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1500
commit 995e2f1a9092ba265ecd785678ec58a7e9223203
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 28 02:58:20 2010 +0000
defaults.{c,h}: _resume functions added
* cleaned up whitespace
* untabify
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1500 (Mount point should not be in-accessible between reconnect to server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1500
commit 896177cb4bfc766705e1e5233951df669e8ef894
Author: Anand Avati <avati@gluster.com>
Date: Wed Sep 29 01:11:07 2010 +0000
replicate: clear pre_op_done/piggyback values after open fd self-heal
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 18e3083d20f3ad91c87b2f3a67ebd0e1d442e8c0
Author: Anand Avati <avati@gluster.com>
Date: Wed Sep 29 01:08:05 2010 +0000
replicate: use new style (un)locking in self heal of missing entries
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 960 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=960
commit 309441f21e83a3fe94864bdfb6c4407f95eb6374
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Wed Sep 29 00:28:07 2010 +0000
replicate: replace first-write-to-flush optimization
use a changelog piggybacking optimization instead of first-write-to-flush
optimization and do other cleanups (removal of post-post-op hook etc.)
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 0e0bb2c77f04b611b0e74472f87d24705a99c015
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Wed Sep 29 00:28:06 2010 +0000
whitespace cleanup
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 5d21b3aee244f9f78a0db32571d992eb01c6eb14
Author: Pranith K <pranithk@gluster.com>
Date: Tue Sep 28 23:28:28 2010 +0000
mgmt/glusterd: brick info get should compare uuid instead of hostname
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1734 (replace brick should accept both ipaddress and hostname for bricks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1734
commit e46ceb54029c1e89219fde0cfb9a81f3f858850b
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 28 11:01:38 2010 +0000
rpc-clnt: handle NULL dereferences
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1723 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1723
commit 64d276da32f328649b9547806afcc34c976bfbf6
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 28 11:01:10 2010 +0000
client-handshake: prevent NULL dereference
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1720 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1720
commit 27b98834e2ad3efc18deb8642c52c45e0f14daaf
Author: Anand Avati <avati@gluster.com>
Date: Tue Sep 28 23:04:24 2010 +0000
resolver: set safer conditionals during path creation
when client would send just the path as part of a transaction, path
reconstruction would create parent directory's path instead of actual
path at the time of resolution.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 935 (Directories change mode from 0755 to 0644 automatically)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=935
commit ed8b321a4e1172aa2f0654b4ee534d66c0bbeba4
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Sep 28 09:30:27 2010 +0000
mgmt/glusterd: Fix incorrect state machine transition
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 2f5e59a941727ff87eadd30c3feabb8829d69201
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Sep 28 09:29:52 2010 +0000
mgmt/glusterd: compute cksum upon volume retrieval
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit a04bec43977c6964cc34c625566484af088f0034
Author: Pranith K <pranithk@gluster.com>
Date: Tue Sep 28 09:27:23 2010 +0000
mgmt/glusterd: prevent cleanup_and_exit if its already started
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1706 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1706
commit b962fd3d0fd6f2c0743a61b3da20c2871baa8132
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Sep 28 06:21:44 2010 +0000
Changing readdir calls to readdirp calls in DHT
Changing readdir calls to readdirp calls to handle layout issues
seen in dht.
Also, changing posix readdir call to do stat after dir read for readdirp.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1690 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1690
commit fcda7657973cb82c2181094acd751b1f4d8296d9
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 28 05:37:02 2010 +0000
more proper error returns in case of graph topology validation
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit b9bce12bc76694e640179bae3d8de8c47c12e96a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Sep 28 04:30:39 2010 +0000
nfs: Free inodes layer fop locals to fix memory leak
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1259 (Memory leaks to 5.7g usage in gnfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1259
commit 166f330e2349b7ac13c018b09bf5bc0aec94a3d5
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Sep 28 06:03:59 2010 +0000
change the loglevel from error to debug while reconfiguring
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1729 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1729
commit d5e25011b7dd63de516246b754471130627a7e64
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Sep 28 04:30:38 2010 +0000
distribute: Propagate -1 op_ret on failed fop
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1717 (dht_attr_cbk does not propagate op_ret on failed fop causing nfs crash)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1717
commit 30c774e38aa6a2a70ee33746b085504b0baad72c
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Sep 27 08:13:19 2010 +0000
do not allow remove brick if the total bricks given is less than the sub_count
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1713 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1713
commit 12dbe7ec772e3435a2dfc063f81fc48de419eb62
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 27 01:57:15 2010 +0000
access-control: report possible errors in graph during 'init()'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1712 (Error is not logged for a dangling volume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1712
commit e2eaab6ef55c2c6e96ecb43446a274ac5e49f8a7
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 28 05:17:27 2010 +0000
glusterd: logs is a symlink to default var log dir
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1728 (glusterd log file location)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1728
commit d25754e884e4f99fa268a00db92273ab50520708
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Sep 28 04:31:51 2010 +0000
unref the dict allocated in set_volume, remove_brick
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1726 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1726
commit 80a23f61980ec0941b2f2a26f1eccbd1a2f10743
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Sep 28 03:47:40 2010 +0000
Starting/stoppin glusterd changes brick pairs
the problem was the pair information was not maintained anywhere.
When glusterd re-starts, it reads the brick dir entries and
populates the brick list. adding brick info to volume info file
to fix this issue
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1714 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1714
commit 93d844ed6b73e9b5134abd033811f2b9527efd0a
Author: Pranith K <pranithk@gluster.com>
Date: Tue Sep 28 02:47:08 2010 +0000
mgmt/glusterd: prevent detach of peer with its bricks existing in cluster
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1681 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1681
commit af1d3f2f26594615b113857aad934a29b7db9466
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 27 09:26:17 2010 +0000
distribute: don't check for inode's gfid in _cbk
* in dht_lookup_dir_cbk(), at the entry itself we are dereferencing
local->inode, which can be NULL in many cases. Hence no need to
check/dereference that variable. Just check 'local->gfid'.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1696 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1696
commit 0007efb1183ed2432651d0c38f86af333161e6e8
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Sep 27 16:20:19 2010 +0000
replace brick fixes
Reviewed ok.
Just like commit, maybe we can move 'pause' also to the commit op of replace brick since it can be performed only when replace brick has been started. I'll send in a patch for that soon.
----- Original Message -----
From: "Vijay Bellur" <vijay@gluster.com>
To: glusterfs@dev.gluster.com
Sent: Monday, September 27, 2010 7:59:25 PM
Subject: [PATCH BUG:1235] replace brick fixes
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit cb4c35e6cdaa3607fa6e0d0263e6738cca2588e8
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 27 08:57:05 2010 +0000
glusterfsd: after volume fetch, return proper values from functions
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit d31360d22e123a13acf9c199d774c94478cdf9c2
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 27 08:55:55 2010 +0000
io-threads: fix NULL dereference in 'reconfigure()'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1715 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1715
commit e19b59c66401c0fb0558b440fb11a04d9b3bff58
Author: Pranith K <pranithk@gluster.com>
Date: Mon Sep 27 05:57:51 2010 +0000
mgmt/glusterd: delay probe till connection happens
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1607 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1607
commit 3b7c8dad2dd2dd6f5d41b87d1926bea548e905f9
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 27 02:06:26 2010 +0000
access-control: handle a case of wrong error handling
in rename_src_stat_cbk(), we were checking the return value as '-1',
but the function can return '-EFAULT' (ie, -14 in few cases).
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1691 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1691
commit 7b8a7f6da31110f2a03b8fb2b5a7fbf293c01232
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 27 01:22:57 2010 +0000
fix a build warning about stack overflow
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1710 (build warning)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1710
commit 8593e3076e3242989291b16f55e0c3c9972565c7
Author: Pranith K <pranithk@gluster.com>
Date: Sun Sep 26 23:55:41 2010 +0000
mgmt/glusterd: perform post operations of volume set
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1708 (update store, re-compute checksum, restart nfs for volume set)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1708
commit a668cba18daec8639897557e69a19a50a84956a7
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Sep 25 07:52:18 2010 +0000
protocol/server: Check before de-referencing conf
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1698 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1698
commit a6a518f3c550ccf79975aad3eb920b42e6653076
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Sat Sep 25 04:42:30 2010 +0000
nfs: Fix multiple subvolume CHILD-UP support
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1643 (Initial requests after mount ESTALE if DHT subvolumes connect after nfs startup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1643
commit 90b470f6b070870c37d863c14e111c0d0a20c3d4
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Sep 25 04:40:33 2010 +0000
mgmt/glusterd: Do not look into brick when logfile is being set for volume
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 5822cfb34ca94c365a330ea4eaa45f6911a3ce4e
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Sep 24 13:37:32 2010 +0000
mgmt/glusterd: resolve brick before doing uuid compare
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit cae7079294fa06788cf6bf181b7a91c8b797f4b1
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 24 10:16:23 2010 +0000
glusterd: add new stats related options for 'volume set'
* 'gluster volume set <VOLNAME> latency-measurement <yes|no>'
* 'gluster volume set <VOLNAME> dump-fd-stats <yes|no>'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1701 (better statistics gathering in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1701
commit 662f613ab0d5f5e8c99ae490442b6359017f1f87
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 24 10:18:31 2010 +0000
glusterd-volgen: add 'io-stats' xlator on server volfile too
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1701 (better statistics gathering in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1701
commit 32f35972afcdebc19b459ee7ef1a14fda379d8a4
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 24 10:14:37 2010 +0000
io-stats: bring in latency measurement feature
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1701 (better statistics gathering in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1701
commit 2e34a423dc889d6827ec62852f0837007b37fbaf
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 24 10:14:23 2010 +0000
stack.h: remove the time/latency measurement code
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1701 (better statistics gathering in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1701
commit 552bb268477ea8136631524a4930d6401bdc0190
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Sep 24 08:50:24 2010 +0000
check if the bricks provided are the same and are alredy being used
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1682 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1682
commit 6c53ed4e01f960b0a2a4cdfddb9873942a77db62
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 24 07:51:53 2010 +0000
rpc/rpc-transport: fix frame-loss during rdma-reads.
- total no of rdma reads in progress was tracked using refcount of post
(refcount = total rdma reads + 1). However doing rdma_post_unref _after_
rdma_do_reads, can result in race condition between execution of
rdma_post_unref and procedure handling rdma read completion. This makes
it impossible to find out whether the current rdma read was the last
rdma-read being done in procedure handling rdma read-completion.
The fix to this should either do rdma_post_unref before posting an rdma
read or use another variable to track the number of rdma-reads.
This patch implements second method.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1700 (write fops are bailing out on a distribute setup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1700
commit 79ab2daa6a704e2734286c1ec870854f9da53f35
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Sep 24 04:38:36 2010 +0000
mgmt/glusterd: add option to force kill gnfs process
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1517 (gluster volume stop - starts a new nfs server.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1517
commit 4b5b72d54254d733e31e8aafc2c3bda0186a6327
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Sep 24 04:09:03 2010 +0000
mgmt/glusterd: initialize addrinfo variables
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1695 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1695
commit 3cf4cf147d72052bdf76bbd4e3e25be604ccc153
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 24 03:17:36 2010 +0000
glusterd: fetch-spec now allows NFS like '/<volume-name>'
To make mount options similar, so less confusion
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit cbe93ff1864267e8d7bd0489872a47441bd164b8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 24 01:40:34 2010 +0000
rpc-clnt: print frame-sent time till microsecond resolution in call_bail.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 1197ecb05879ed09e0343a63af13be28b8a21eb3
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 24 00:29:29 2010 +0000
glusterfsd: handle relative path for '--volfile/-f' option
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 638dd5ae12898e031d1159fe78b3964884446742
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Sep 23 08:29:15 2010 +0000
mgmt/glusterd: cleanup generate_perf_xlator_list ()
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1670 (Volume set enable disable support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1670
commit accfcf4b0055a0dc0158073cad4c9a12ec28c7eb
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Sep 23 08:29:14 2010 +0000
dict: add dict_get_str_boolean() function handily query string-boolean values
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1670 (Volume set enable disable support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1670
commit ac0af2d644dc963fbd005e2cf8bdedddaa0e9478
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Sep 23 02:09:25 2010 +0000
Check for possible fd/ctx NULL in afr
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1636 (Replicate crashed in afr_nonblocking_inodelk on deref of NULL fd_ctx)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1636
commit cf2c43767ebc0b1f97b9e8b814e2ee417f1c9c63
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Sep 23 09:18:37 2010 +0000
mgmt/glusterd: Misc fixes to pump / cli / glusterd wrt replace brick.
Patches from Vijay and Shishir have been pulled in into this one big patch.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit d8aaa51774ca0c4dd3626cd66f8f6057243c4bb4
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 23 06:30:43 2010 +0000
distribute: don't update the inode's gfid directly
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1680 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1680
commit abfbea113cf75a4835e092c55b1dec0dd0901936
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 23 05:14:05 2010 +0000
distribute: bring in feature to fix the layout of root inode
* If the errno is ESTALE for root, fuse doesn't send fresh lookup on
the path (it does for all other inodes). Earlier layout mismatch for
root never used to happen inside codebase, and if noticed, it was
serious issue.
Now with DVM, after a add-brick or a remove-brick, layout can be
changed even for 'root' inode. Needed to fix this issue inside
distribute itself, instead of fuse sending 'fresh' lookup on root.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1630 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1630
commit e072aa48d404a059943c406eea6d73cf2181cb94
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 23 03:52:57 2010 +0000
fuse-resolve: remove stale code
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1240 (DVM: after graph change, inodes should resolve to new inode-table)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1240
commit 29dc6c7a72b814578e934b7f498d08d3c991351c
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 23 00:45:53 2010 +0000
gluster cli: handle case of no brick given in log locate/rotate
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1679 (gluster volume log locate/rotate segfault)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1679
commit 7d69fc35704a912660193555ed0a3ddfefd39ad2
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Sep 22 23:42:11 2010 +0000
cli: Make volume rename hidden
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 9f25096c1c7d7f569b2dfadbbbc80657e472528e
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 22 22:42:51 2010 +0000
glusterfsd: destroy mgmt in cleanup
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1517 (gluster volume stop - starts a new nfs server.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1517
commit 4a656f1025d2f81e94c1041cbeb2a3044e2d4ebd
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Sep 22 15:05:22 2010 +0000
mgmt/glusterd: Always use io-stats as the topmost xlator with appropriate volname to be nfs friendly.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1670 (Volume set enable disable support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1670
commit ae71650b603e5120f8aff9c8a09845432e90d945
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Sep 22 13:27:04 2010 +0000
cli: Avoid exposing volume set-transport
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit a7ea5afb3ba002b0af268d3522619e221503fe9c
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Sep 22 13:26:41 2010 +0000
mount/fuse: generate gfid only in case of a fresh lookup
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit cfbbb9f850d4b83c2d1a4706b56edeceb6401ae2
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 22 10:03:17 2010 +0000
fuse-resolve: don't resolve fd to new graph for now
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1674 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1674
commit 195d95e6c32e0be92e27269137d0631bacb86283
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 22 09:43:45 2010 +0000
distribute: in linkfile creation check for valid gfid in inode
* if inode->gfid is not valid (ie, null), take the gfid from the
parameter dictionary passed from higher layer
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1565 (deleting files after dht rebalance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1565
commit 795050b156a7454ac3046006b91861c39f531b40
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 22 08:50:23 2010 +0000
distribute: while selfhealing directory, send proper gfid in dict
* this was the root cause for having layout mismatches in case of
add-brick, because the gfid of directories on newly added brick
was always mismatching, which caused many operation on that
particular brick fail.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1629 (files missing during add-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1629
commit 5d5bc7295358247c72e9ae8cddd5ce577b3d6d7c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 22 08:14:02 2010 +0000
rpc/rpcsvc: add debug messages when rpc-messages are handed over to/from transport.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 5047d79ceb8de8a971a28a7c116b4f8e907354cd
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 22 06:17:32 2010 +0000
mgmt/glusterd: skip sending req to disconnected peers
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1673 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1673
commit c65a8b296a768d4087a6cd79e3a2aad8f3f0aa80
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Sep 22 05:21:28 2010 +0000
Restart all bricks which are down when glusterd comes up
This is only done is the volume is started.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1562 (insufficient consistency check on start of glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1562
commit a5286a43dadfe50749fde1d32de8ff19f875563c
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 22 04:23:45 2010 +0000
rpmspec file: add option for '--without rdma'
Thanks to Bernard Li <bernard@vanhpc.org> for the patch
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1650 (Add '--without rdma' rpmbuild argument)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1650
commit e51f92bbd9b97a7225574269c0d7b3f8baf1081f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 22 04:21:02 2010 +0000
mgmt/glusterd: replace-brick validations
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1657 (validations for replace-brick while stage op)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1657
commit 72032a1b004288255201fec561b5296b95e72083
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 22 03:32:17 2010 +0000
nfs, nfs3: Base volume access on CHILD-UP-DOWN event
Overall, the aim of this patch is to change the result of an nfs
op depending on whether the underlying volume is up or down
as notified by CHILD_UP and CHILD_DOWN events.
This patch contains three intertwined changes:
o Only when the lookup on the root of a volume is successful does gnfs now
export the subvolume. Till now the result of the lookup was not used to
determine whether we should export that volume. Not accounting for root lookup
failure resulted in ESTALEs on first access because some children of distribute
were down at the time of the root lookup.
o Only when lookups on all the subvolumes have succeeded are
these exports enabled through NFS.
o When a child of say distribute goes down, on CHILD_DOWN event nfs will
ignore all incoming requests from the client because ignoring these
will prevent ESTALEs for those requests and in the hope that ignoring the
requests will make the client retransmit. There are risks in this approach
absent the DRC but we're willing to live with that for now.
When a child goes down, the mount exports list will continue to show it
but mount requests will be denied.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1643 (Initial requests after mount ESTALE if DHT subvolumes connect after nfs startup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1643
commit 5dea6ebd7a063ca4f2edc512dbd6c6307af60e02
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 22 03:32:16 2010 +0000
distribute: Propagate CHILD-UP when all subvols are up
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1643 (Initial requests after mount ESTALE if DHT subvolumes connect after nfs startup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1643
commit 1802cd23dbbee7b148f7bb043cd0b085e2171335
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 22 03:32:15 2010 +0000
distribute: Return ESTALE when dir selfheal finds no fix
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1641 (Distribute must return error when dir selfheal has no fix)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1641
commit cdc4cc93ccae70cbce05574dc97e0e01b67494d5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 22 03:32:14 2010 +0000
core: Introduce string representation of GF_EVENTS
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1643 (Initial requests after mount ESTALE if DHT subvolumes connect after nfs startup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1643
commit 5dfcfef7960c92fdc69fe640fe460e03c2c1a35f
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 22 02:29:12 2010 +0000
mgmt/glusterd: opinfo unlock should be done in txn_complete
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1664 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1664
commit 0f7b3355e5d955fd2b7b7ccd789f261dbe2107bb
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Sep 22 02:01:36 2010 +0000
mgmt/glusterd: Restart src brick and add pump when replace brick cmds are given.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1669 (pump xlator should be excluded by default)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1669
commit bf1944ae8c0d5c8b8ef2ebb7440ea2bac2607f13
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Sep 22 02:01:10 2010 +0000
mgmt/glusterd: Enable/disable xlator options support added.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1670 (Volume set enable disable support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1670
commit ebe872e10005229814c597314326ab26cb26b05a
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Sep 22 01:40:45 2010 +0000
Remove brick for stripe should check for pairs/subvolumes
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1658 (removing single brick works)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1658
commit e1dbac27c9ce4218f3b0a5e3a9ebc4f4b80bbdc6
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 22 00:10:28 2010 +0000
performance/quick-read: fix memory leaks.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1438 (memory leaks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1438
commit 07230cf40573f0ec8fa890bff13e9ca4a64ab28f
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 21 22:22:45 2010 +0000
server-helper: check for conf before dereferencing
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1667 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1667
commit 8c2be724967102df53936674b20dd466a81939f3
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Sep 21 08:12:36 2010 +0000
unmount the replace brick client irrespective of whether the previous commands succeeded or not after the mount
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1661 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1661
commit 6a0f71846f5fdb72c94342c7d60132c3115c1674
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Sep 21 09:12:31 2010 +0000
libglusterfs: handle failure properly in gf_system()
- Child must be terminated if execve(2) fails, otherwise it will deadlock
parent
- Status, as of given by waitpid(2), is aggregated data, should not be
returned as is. In fact, there is not much point in threading up the
exitvalue: callers usually return gf_system result as is, and according
to glusterfs conventions, they should return -1 on failure. Therefore
now we check only for success/fail, and return 0/-1.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1665 (glusterd hangs if spawning a child is failed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1665
commit 6cda9a3e58dae19285b88bd0b54e75931701fdcb
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 21 10:49:49 2010 +0000
cli: remove trailing slashes from brick paths
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1659 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1659
commit 3599e4e101591adb352c64b42f407a141dbd7288
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 21 05:37:10 2010 +0000
mgmt/glusterd: print critical log for responses from unknown peers
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1490 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1490
commit d4f7a67de058cae9d0659e0eed7579b62be422b8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Aug 25 04:37:44 2010 +0000
mount/fuse: By default enable direct-io only for fds not openened with O_RDONLY.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 801 (Direct io-mode support and related changes in caching translators.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=801
commit 1122e1b6eed2a0f72b8300374e38dd5d5332c41f
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Sep 21 05:12:08 2010 +0000
fix the typo in the getxattr of replace-brick
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 1d3b61db0ed8cb1a9c06500d4f78b55da55c18d2
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Sep 21 03:51:57 2010 +0000
check the private structure of the xlator before accessing it
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1651 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1651
commit 14fe02015ef59f507432582d253247548ea642c6
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 21 02:02:48 2010 +0000
cli, mgmt/glusterd: send errno in case of Peer reject
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1653 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1653
commit 63d9143986e5f95fe3ec4842ca432f713d3954d1
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Sep 20 23:55:55 2010 +0000
Friend find should handle hostname/ip
Regardless of friend being added(probe) using hostname or ip address,
friend find should succeed if any of the above pair is provided.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 4dcd6dcb3d2e4db3c729ff3b1adf656a06e0bc99
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 20 09:54:12 2010 +0000
cli, mgmt/glusterd: volume sync command
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1310 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1310
commit 7e62ac0f48113cc0e000443801b15e1a45ec1d87
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Sep 20 08:09:09 2010 +0000
rpc-transport/socket: set keepalive socket option.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit c398b0e621120c90d93eec18a2711eda188c9aeb
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Sep 20 07:28:30 2010 +0000
cluster/afr: print correct offset in debug message during diff self-heal.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 960 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=960
commit 71f059705ada2e7027d94dcdbe7e24f4cd9fdf88
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 20 02:29:14 2010 +0000
build glusterfs with '-O0' flag by default
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1599 (can we build glusterfs with -O0 -g by default)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1599
commit 0d4391b111171806eef50b8d696a4a1b6de1bc80
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Sat Sep 18 03:31:56 2010 +0000
Glusterd: gluster volume set <volume> <option> <value>
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1159 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
commit 55171f786bb571635c00b8f85304d973d882cc26
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Sep 18 06:31:33 2010 +0000
mgmt/glusterd: detach peer properly when msg submission fails
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 93bf68cc599d1412cd2ce50e77b03863f7d9eed0
Author: Anush Shetty <anush@gluster.com>
Date: Sat Sep 18 06:21:33 2010 +0000
change stat structure to iatt
Signed-off-by: Anush Shetty <anush@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1642 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1642
commit f6618939004a62b5aae6f6db3b2a1bee2d713bb6
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Sep 18 03:21:56 2010 +0000
cluster/afr: allocate memory big enough to hold iatt structures.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 927 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=927
commit 49a13ea0e938a6da77042bffb60ce50e464e4f84
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Sep 18 03:20:58 2010 +0000
cluster/replicate: stack_wind into read_child only if it is up.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1637 (replicate should wind reads into read-child only if it is up)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1637
commit f7c8ac3f991aad2e5b866887658839d177bb8c17
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Sep 18 01:54:09 2010 +0000
check for 'link_inode' in server protocol
* also log and return in case of 'fd_bind' getting fd with NULL inode.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1635 (running mixed tests glusterfs crashed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1635
commit 4c49565b14809616563297cb7f0225de34a556aa
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Sep 18 01:30:35 2010 +0000
mgmt/glusterd: Proceed state machine when cli response fails
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1530 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1530
commit 507d16c70c7e266ba28dab60d2bce808325adc5d
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 17 23:21:55 2010 +0000
rdma: do event_unregister() in fini() too.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1611 (crash in gf_free)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1611
commit d9288a403f17486f32607f085f94c6f49d26f6c6
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 17 22:52:11 2010 +0000
server-resolve: check for variables before dereferencing
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1628 (glusterfs crash)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1628
commit c366d892d464a613f669cbb0937d2010620900bf
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Sep 17 13:36:12 2010 +0000
glusterd: refactor service termination
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 9142a6faa4a67fe33893367503acb15eea45419c
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Sep 17 06:41:13 2010 +0000
reorganize /etc/glusterd/logs, add nfs log too
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1319 (gnfs support in gluster command line)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1319
commit d4ce43b69c3e4a1cb97432e89e52c53990386e3b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Sep 17 06:32:01 2010 +0000
nfs3: Unref & unbind dir fd with inode lock on EOF
..so that when EOF is reached on this fd, any further
requests on the same inode do not get handled through this
fd but result in a new fd being opened.
Unbinding results in the fd getting deleted from the inode's fd list.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1619 (glusterfs nfs server crashed on dht+replica(2x2))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1619
commit 5dc599919ed8662baff48547c9ca85b6220c4ce3
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Sep 17 06:14:24 2010 +0000
mount/fuse: Perform malloc for appropriate length
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1631 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1631
commit f1662312c8c10047510d9d290ca8939c3f013943
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Sep 17 05:47:20 2010 +0000
free the dict_val to avoid memory leak
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1621 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1621
commit 1164555101f2029d8f0b5894db1f101c4be905b5
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Sep 17 04:12:51 2010 +0000
Fix crash in dht_pathinfo_getxattr_cbk
The crash happened due to NULL dereferencing.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1626 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1626
commit 4a349053e92b828be282bb296cefbf9ff1c870ba
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Sep 17 04:12:18 2010 +0000
Fix transalator indent for option
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1626 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1626
commit 756ca06777baf1631ab5fe0f966d783dfc583bd3
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Sep 17 01:27:04 2010 +0000
cli: fix incorrect return value for system:: getspec
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 626654ec7e5ac4618a62324cd93e4596fe71c6f8
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Sep 15 08:11:22 2010 +0000
portmap: add support for registering multiple bricks on one port
Rationale: if a brick serves multiple volumes, all of them need
to be registered for the port the brick server listens on.
Implementation: to register volumes "foo" and "bar" for port 6543,
you have to send a SIGNUP for brick: "foo bar", port: 6543.
Upon a pmap lookup, we match the search term to
whitespace tokenized bricknames on server side.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 06deac6d0fbc8908494ef66c8c680a112491984a
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Sep 15 08:11:21 2010 +0000
portmap: make grounds for typed service mapping
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit ccfca469d673f3f87d296cee5eb8b15ea23ae0f5
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Sep 15 08:11:20 2010 +0000
cli: added system:: portmap brick2port
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit d6cd383ba2ef157d90bb4923d96673b9dad79de7
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Sep 15 08:11:19 2010 +0000
cli: added system:: getspec
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 30c4b03b89554a55bb19159873fe549e28584f0d
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Sep 15 08:11:18 2010 +0000
cli: add system namespace
See "gluster system:: help" to get the feel of it.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit b4326d388c63b3715b5364178faeb7662fdcdec4
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Sep 15 08:11:17 2010 +0000
cli: make cli behave nicely with batch commands piped in in stdin
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 496a3147a051be913197bf75573bfb446ccf0597
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Sep 15 08:11:16 2010 +0000
cli: add "--remote-host=<hostname>" option
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit ba14ada00649a1182720afb3cc8d266b25f18623
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Sep 15 08:11:15 2010 +0000
cli: add a simplistic option parser, convert "mode script" to "--mode=script"
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1570 (geosync related changes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
commit 8d9d00a02d94dbc91a7277e4396fd78f08780ed6
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 15 10:53:00 2010 +0000
server: Check gfid presence using uuid_is_null
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1608 (stat fop on dir returns ENOENT from server-resolution path)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1608
commit bc5ae35b14c1d54aa9e8f03db9b4c5a6226ff57c
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 16 07:41:42 2010 +0000
logging: fix a crash in gf_log_callingfn()
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1623 (crash in logging callingfn())
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1623
commit 5fb82586f7f97831d7c166a586da80e440f50ef1
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 16 07:01:53 2010 +0000
distribute: send proper 'gfid' in calls originated from lookup/mkdir
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1608 (stat fop on dir returns ENOENT from server-resolution path)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1608
commit 1c538a6ddfb9bb972398d20d25b1af5a3bcc0f6e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Sep 16 04:04:58 2010 +0000
performance/write-behind: dump contents of wb-file
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 8e7a8f654c3308388e77427a40427bb55c866220
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 16 01:27:39 2010 +0000
cluster/pump: introduce another flag to enable pump functionality
* by default pump will act as a pass through xlator, only when
replace-brick start command is issued, it will set the flag,
and then pump features (ie, afr) will come in to picture.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1590 (Stack overflow during self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1590
commit de9af40c8a3ad73afcfdcfa75c86dfbc6310df8c
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 16 01:08:15 2010 +0000
protocol/client: prevent a crash while taking process state dump
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1616 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1616
commit 55f2804c7173c200f80d6ff5b31ed1ca6841c596
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Sep 16 00:13:46 2010 +0000
avoid code duplication while freeing respnse hostname
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1614 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1614
commit c23fda626a0d225a7f635b1c30670a825ff0a433
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Sep 15 23:53:57 2010 +0000
check if the brick to be added is online
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1603 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1603
commit a7db7554aa7682c29b97ed6e4cc5beec07a46004
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Sep 15 09:41:40 2010 +0000
check req structure in the ctx before transferring probe response
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1614 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1614
commit 9632133237189740c722a3342dec33dd06733128
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 15 08:35:42 2010 +0000
mgmt/glusterd: gf_strdup the rsp msg and free xdr memory
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1613 (glusterd crash in create volume failure)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1613
commit 953d530e2b0300c2c38eabb40e1a7788c1255f98
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Sep 15 08:14:07 2010 +0000
free the handle and pmap structure in fini for glusterd
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1580 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1580
commit 16b7ab062dbdaacaef6d3b29dc50075cde906445
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 15 06:49:56 2010 +0000
cli, mgmt/glusterd: disallow probe to a cluster
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1594 (make probe oneway)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1594
commit bf5dc823eae69b4585efa4873ff6be2a2ef4b3d9
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 15 06:46:48 2010 +0000
rpc: add ref/unref for rpc clnt
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1594 (make probe oneway)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1594
commit 89ad92f74c74957c101d512191fe2017cdfe8e7f
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Sep 6 03:28:06 2010 +0000
Deadlock in state dumping while holding the logging lock
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 976 (Deadlock in state dumping while holding the logging lock)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=976
commit f1bf339768ffe3fbb1a1b82fd1e9719ecd6e1a3d
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Sep 6 01:36:57 2010 +0000
Leak in Locks
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 996 (leak in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=996
commit ee8b48c12eeb50b454c28e6cb90d838f7892e51e
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 15 05:16:48 2010 +0000
socket.c: suppress spurious 'dict_get' logs in glusterd debug mode
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1606 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1606
commit 3ea9752f85d28800526c13d197a9e51055403891
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 15 04:34:08 2010 +0000
nfs3: Copy deviceid from correct gfid start octet
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1600 (showmount works but unable to mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1600
commit 199d8ceaf24c84776500bf7958f171e5b68b47ac
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 15 04:53:34 2010 +0000
rpc-transport.c: handle a double free
* 'this->name' was getting freed in '(transport)->fini()'.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1605 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1605
commit cf015d65ded6ae08c81c7c3cf1ed453b6e5f54e7
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Sep 15 03:28:48 2010 +0000
error out if a peer is not connected or not in befriended state
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1603 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1603
commit f77f01c2da0d7d5a073fd22da099536483bb154f
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 15 03:18:57 2010 +0000
nfs3: Set gfid[15] to 1 for root
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1600 (showmount works but unable to mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1600
commit a5732175e8c981c634cff6e3027a828c8e7392d7
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Sep 15 02:02:05 2010 +0000
Volume stop/start fails sometimes
If the pid file is not present, do not fail the volume stop.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1602 (Volume start/stop sometime fails.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1602
commit b9b597fbf00b4d3b3214ea7c6c2413771a03f405
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Sep 15 01:25:51 2010 +0000
check if the peer is connected before updating friend and send response once befriended
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1601 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1601
commit d0718ecd5798709523cac10ab0df2db7fea8c9c1
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 15 00:27:10 2010 +0000
memory leak fixes.
- free memory allocated by libc when decoding request arguments in server and
reply in client.
- free memory allocated to saved_frames during connection cleanup.
- free memory allocated for transport name while creating listeners.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1438 (memory leaks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1438
commit c30137e20df6d3b87cb097484d06caa63d2a5df3
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Sep 14 23:43:39 2010 +0000
Cleaning up mem_get0.
mem_get0 is exactly the same as mem_get, but with the addition of a call
to memset(0). hence, making mem_get0 to call mem_get
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1520 (gnfs crashes on start-up in mem_get0)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1520
commit 4ddf3ad20b8c0d6e7048d316ce3605d37644998f
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 14 07:40:39 2010 +0000
remove 'ino' from protocol structures
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 5fbaaf7ebfb0613df78448139dd0f89ada5b8930
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 14 07:40:26 2010 +0000
posix: remove variables used for maintaining generation numbers
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit e2136ad32fdc1ba4911d313de8650e9e24f54651
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 14 07:40:11 2010 +0000
remove 'gen' from iatt/protocol structures
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 9b1a6922ce795bcb5f1766ab978987c6f8c4ba5c
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Sep 14 09:27:14 2010 +0000
compare op_errstr before freeing
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1598 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1598
commit 9621b727f56e6134eb2417f21ae2b9c06f14d2d8
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 14 06:31:10 2010 +0000
posix: fix an issue with existing data in case of readdir
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1597 (readdirp fails if there is old data in the subvolumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1597
commit 77cfcc1f0d1d02bc658f5d9a0a6ff28d2a4db0cd
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Sep 14 06:21:20 2010 +0000
compare rsp.spec before freeing it
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1596 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1596
commit bbcd4deaf4b689a11d2e00d897a3501ac96301db
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Sep 14 05:23:35 2010 +0000
check if the export directory is present while starting volume and send the response to cli
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1593 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1593
commit cccf03dee3dabaf20d1e0b8a4b0da7d6f3c9759c
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 14 03:54:39 2010 +0000
socket: add xfer data counts
* keeping track of data transfered over wire helps to identify the
protocol overhead, and also can help us in debugging more on server
loads
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit c4eecb0a89ba67f0a49bec75163883a8a6c2560a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 14 04:31:02 2010 +0000
performance/io-cache: fix memory leak in ioc_mknod.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1438 (memory leaks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1438
commit 743a3c83c8e6f8ddff9bf4e671c9976eb624c40c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 14 04:09:52 2010 +0000
rpc: print xid of the rpcreq corresponding to frame being bailed out.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit f9471078beb2407cabe344a7996b317dfce83e09
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 14 03:56:00 2010 +0000
glusterfs3.x: change gfid type to opaque
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit de78deb52319752e7870d1c0e3e82c0498e179c7
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 14 03:55:24 2010 +0000
glusterfs3.x file is updated with changes done to xdr.{h, c} files
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 552081272513747e1fa82b1c4d3acbf7d477c1ad
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Sep 14 02:39:11 2010 +0000
nfs,nfs3,mnt3: Transition fh resolution to gfid
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit aa3e0e255dfe12a9c621aa402165ef7411464c3b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Sep 14 02:39:10 2010 +0000
posix: Copy gfid from stat to dirent for readdirp
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit d5209c95563dbd81b0a47627ffb13d7e48d08e46
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 14 02:23:32 2010 +0000
mgmt/glusterd: make probe one way
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1594 (make probe oneway)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1594
commit 3e949078bc2ac880046437d641db23a11a9e3814
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Sep 14 01:27:22 2010 +0000
Add checks in mem_pool to catch possible double frees
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1520 (gnfs crashes on start-up in mem_get0)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1520
commit 8e96295cc8e0e7b6638fc8c155c3aef4f15ffe32
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 14 00:54:22 2010 +0000
mgmt/glusterd: free xdr allocations
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1186 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1186
commit 20eb19cb6d6c8d6b91399fa97687e6d995acb527
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 13 08:32:37 2010 +0000
rpc: in rpc_clnt_destroy(), cleanup the transport too
* if we don't cleanup the transport, it will trigger false
events on the free'd transport which causes crash
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1423 (Crash in gf_timer_call_cancel)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1423
commit c0c687cee58c4a0989d79ed972720e7d09a6e6bc
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Sep 13 07:54:50 2010 +0000
Volume create propogate error msg to cli if invalid export
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1180 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1180
commit aa59ab0939fd62965f6f89d67cf530d4825dcdf1
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Sep 13 07:54:30 2010 +0000
Print error msg to the CLI from glusterd
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1180 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1180
commit b98c3e4dac3d962bd1c3188e7a213cdf09f2bac2
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 13 06:59:55 2010 +0000
gluster log {rotate,filename} : uuid check for bricks
Thanks to Raghavendra Bhat <raghavendrabhat@gluster.com> for
pointing out the fix.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1550 (volume log rotate failed.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1550
commit 86789f57bdec6a0b5d44b98d4eea00d029fa7339
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 13 03:41:08 2010 +0000
io-threads: return -1 in case of 'init()' failures
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1591 (glusterfs server crashes with another translator inserted into volume chain)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1591
commit 5733e985198726b8376cdeac02634db42dc4d505
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 13 02:48:45 2010 +0000
afr: reduce the size of readdir request during entry-self-heal
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1585 (Errors during self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1585
commit b5a0c32b6bfe912432e4f38fda651321acee9968
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Sep 13 02:00:36 2010 +0000
No space left on device error
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1588 (No space left on device error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1588
commit 286cb6aacfbabed4c345959830f14406a846a08e
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 10 20:24:07 2010 +0000
logging: provide a API to print calling functions
* logs 3 calling functions
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1493 (log enhancement to print calling function..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1493
commit bc49b148dc5f47bc83059b3947285021c8a14c76
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 9 07:40:41 2010 +0000
posix: remove gen related xattr usage
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 200e5eaee1a263ae38fe2ea0b665c40722c442b8
Author: Sachidananda <sac@gluster.com>
Date: Tue Sep 7 10:01:20 2010 +0000
cluster/afr: Clean up dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1083 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1083
commit dc45cd038518a0bd8a552eaa09d4b09fa044998d
Author: Sachidananda <sac@gluster.com>
Date: Tue Sep 7 09:46:41 2010 +0000
performance/io-cache: Fix clang errors.
Clang error fixes plus some whitespace cleanup.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1111 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1111
commit 2b4641b7bfcbea2ec6107cc5f771283a296d9b3e
Author: Sachidananda <sac@gluster.com>
Date: Mon Sep 6 10:06:03 2010 +0000
features/trash: Fix clang errors.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1127 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1127
commit 1cf5dce9f0494ba03486c2e354d86018efde6158
Author: Sachidananda <sac@gluster.com>
Date: Mon Sep 6 09:58:46 2010 +0000
features/quota remove dead variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1128 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1128
commit b6830f5fdedae3552e45b240881fd5c0d1c787e3
Author: Balamurugan Arumugam <bala@gluster.com>
Date: Mon Sep 13 03:40:16 2010 +0000
extras: modify run level scripts to support glusterd.
Signed-off-by: Bala.JA <bala@gluster.com>
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1589 (Change init.d scripts to include glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1589
commit 381a3066986c172e6cf7737a3a815028929dfa6a
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Sep 10 08:15:26 2010 +0000
mgmt/glusterd: set req in opinfo
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit ffedf8a8a699c636ecde19e7e9051eeb328b4447
Author: Pavan Sondur <pavan@gluster.com>
Date: Fri Sep 10 07:32:29 2010 +0000
mgmt/glusterd: add a dict to glusterd commit response.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1582 (replace-brick data missing added brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1582
commit 199a68ba0cd564b4e1c0e38a8b867ee99cd2efab
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 10 05:53:59 2010 +0000
glusterfsd: exit process instead of starting fuse in case of failures
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1586 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1586
commit 62b21fa36ffb3d69dbe09267631d08a4ac3e1159
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 9 07:18:50 2010 +0000
rpc/rpcsvc: fix invalid free in rpcsvc_create_listeners.
Sending on behalf of Raghavendra G
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit 3fb4c5ea11348e3dced31a4f4537e395c4880110
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Sep 9 05:55:53 2010 +0000
Fix incorrect logmsg about disk space in dht
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1573 (Incorrect information about disk space in dht)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1573
commit 70dd682a12010546b25dd2aa0b4bda707f4b1df6
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Sep 9 05:56:59 2010 +0000
free the tmp string allocated while getting brick information
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1580 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1580
commit d165c72fed23502fb0acb12f6b04aa1e5a16adb0
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Sep 9 05:44:49 2010 +0000
mgmt/glusterd: Do not check for src/dst while issuing replace brick cmds.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1582 (replace-brick data missing added brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1582
commit be9cd982e4093bce08e831e1f1df89af117b07fd
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 9 05:06:55 2010 +0000
glusterd: fix init time warnings
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1584 (starting glusterd for the first time gives warning logs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1584
commit aec90da1b8f1e5f0328bc2db160b656f89efef6a
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Sep 9 05:56:02 2010 +0000
mgmt/glusterd: Use appropriate length while doing strncpy
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1583 (glusterd crash)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1583
commit 1fdf1525d32777a729c9bb9185a7c8ad451a6f70
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 9 02:43:10 2010 +0000
stripe: fixed create issues after gfid changes
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1581 (stripe create is broken)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1581
commit 396a089ddc62be537bb4fb629277460d259bf3e5
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Sep 9 02:40:37 2010 +0000
do not use pmap_registry_get function, instead use this to get pmap while removing
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1580 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1580
commit e35c1936404f44e2f06905761023a7c4501e574f
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Sep 9 02:23:37 2010 +0000
rpmspec: Include manpages of glusterd and glusterfs-volgen.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1275 (Fix rpm glusterfs spec file for 3.1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1275
commit 155221630673f43eb3ddf4a6ec8f7eea75893297
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Sep 9 02:23:17 2010 +0000
rpmspec: Rename ibverbs as rdma package and include the relevant files.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1275 (Fix rpm glusterfs spec file for 3.1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1275
commit 1c9da846897df61d08bb5afc5c796828ffe82b4d
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 9 02:03:15 2010 +0000
dict.c: fix a redundant log in DEBUG level
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1493 (log enhancement to print calling function..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1493
commit 6a602a347300703215246dc28265c266c5166fbb
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 9 02:02:54 2010 +0000
glusterfsd: first time errors in volume file should exit the process
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1551 (glusterfs process doesn't exit when init fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1551
commit 1cfd81ebde1f3fd09514593dd006f3df1eef0b1d
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Sep 9 01:16:44 2010 +0000
features/locks: Dump transport pointer also while dumping locks.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1577 (dump transport pointer as part of dumping locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1577
commit 1c849a3a0a80a23494d45d63b31cb00538f92a71
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Sep 9 01:01:04 2010 +0000
mgmt/glusterd: op mem leak fixes
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1186 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1186
commit 529abac4fbec3e49ec0f6c5412b5ee30149120f2
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Sep 8 13:37:52 2010 +0000
mgmt/glusterd: Send volume-id during volume exchange
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1480 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1480
commit 85566c5e6b345bebc3056347bbeb866461c76b48
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 8 10:40:19 2010 +0000
gluster cli: don't print port in peer status
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1566 (gluster peer status port number)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1566
commit a03a430aecc3db50761141b6f6a96127f5abbc51
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Sep 8 08:53:21 2010 +0000
allow brick to be added in a plain replicate volume if a brick is removed
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1574 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1574
commit 8d59c4a94fd58636e3b067b93fc0d4ff3ccc503a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 8 07:32:54 2010 +0000
rpc-transport/rdma: while notifying a reply, pickup the correct iobref from request context.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1567 ([rdma] data corruption due to read-ahead)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1567
commit 29ae48e8c95661af6adde15415bc3b91b822fb4e
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 8 06:14:23 2010 +0000
mgmt/glusterd: send response in case of friend not found
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1512 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1512
commit 7fa8abd3fad693dcd4ff7304f726056839b494ab
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Sep 8 05:18:24 2010 +0000
mgmt/glusterd: Various replace brick changes.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 52185539dd716b79a850c951c9bb437cb346fd2d
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 8 03:59:50 2010 +0000
protocol/client: send CHILD_UP directly fuse if parent is NULL
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1568 (Fuse init doesn't happen when vol file is changed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1568
commit ff6449dd75b43efce1ac414dab0fd49e895ea86d
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 8 03:29:41 2010 +0000
glusterd: preserve brick's port, retrive it while starting glusterd
* this solves the problem of having brickinfo->port as 0 when
when glusterd is restarted while glusterfsd processes are
running
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1569 (data not available in client when glusterd killed and restarted.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1569
commit ba3bacba75449d743a355b22df6db03c54a6818a
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Sep 8 03:32:45 2010 +0000
fuse: suppress wrong/confusing log message about graph setup failure
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1527 (mount time defunct window with remote volumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1527
commit e1d21253a65a0296637ead9d90ae9cb4849545ea
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 8 01:22:22 2010 +0000
mgmt/glusterd: make glusterd to listen on default ports of both socket and rdma transports.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1555 (rdma remote port defaults to 6997)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1555
commit b7eac9307672111e2be989bb55867dc678e4defd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 8 01:20:43 2010 +0000
rpc-transport/rdma: change the default listening port to 6968.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit 975e47a4fd051fc383a05cefefa587e5c551d63b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 7 13:14:40 2010 +0000
rpc-transport/rdma: honour port argument sent in rdma_connect.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1555 (rdma remote port defaults to 6997)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1555
commit a3ba425d57657befbce32e20413eeb1c7b07e2d7
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 7 13:02:27 2010 +0000
rpc-transport/rdma: fix memory corruptions caused by rdma.
- disconnect notification should be sent before unrefing transport,
since transport might be freed when unrefed.
- set trans->listener. This member is used by rpcsvc to decide whether
a listener or a new connection is dead.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1558 (glusterd hung)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1558
commit 4f114b8ee575df6f68a825bff3ec94a6a8406d1b
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 7 12:59:07 2010 +0000
in case of failures, don't hang fuse mount
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1527 (mount time defunct window with remote volumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1527
commit 6cc8d141026e5e1a30d3e36bd79bf347b6323d16
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Sep 7 10:40:57 2010 +0000
cluster/afr: Various self heal fixes wrt gfid.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 7edfd79d674e0d5b2385797ff44d3d9a2d39fa54
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 7 10:13:29 2010 +0000
fuse resolve to return if resolve not successful
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1406 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1406
commit 67388b07c6b6a7b60588c99832edf58d39efaba0
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 7 09:30:29 2010 +0000
glusterd: rebalance fixes
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1481 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1481
commit 01d6705a971a34a284986d55b97966241e8d3f63
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 7 09:12:38 2010 +0000
socket.c: more detailed info about mismatched msg type
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 5548a11ffeb49f714008a21ceacc8f90ea30767e
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Sep 7 09:12:22 2010 +0000
cli: fixed a minor log rotate failure msg
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1550 (volume log rotate failed.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1550
commit 9c38e819f2ee955e0001dfb9e4e6200d62f81db5
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 7 08:53:08 2010 +0000
mgmt/glusterd: resolve bricks upon restart
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1286 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1286
commit 8a4187183940e097f1abe9c12ac201c8fdf908d7
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Sep 7 07:35:56 2010 +0000
Volume info should display transport-type
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1230 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1230
commit 8e3831a100829f0bfac5037c62da8e4a18565700
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 7 06:14:02 2010 +0000
mgmt/glusterd: Disallow final brick remove of a volume
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1547 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1547
commit f8da32037f4c9a9f4dc2274b4278b456315af4ae
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Sep 7 05:40:00 2010 +0000
Add gf_cmd_log msg for volume start
Also fix existing gf_cmd_log msgs
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1556 (Add cmd log msg to volume start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1556
commit 45ce617c73f1145bd424a812447ff94478caf4f0
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 7 05:29:36 2010 +0000
mgmt/glusterd: create store handle in store create brick
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1372 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1372
commit facd0e4ca6a4eb35c12a8b8c6fb9943241c423d2
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Sep 7 04:29:55 2010 +0000
Change cli volume/peer cmd's --help option to help
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1529 (need man pages for 'gluster' and 'glusterd')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1529
commit ce24f5b79e667c839746d017ab1e4ee81b35e34d
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Sep 7 04:29:34 2010 +0000
Man page updates
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1529 (need man pages for 'gluster' and 'glusterd')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1529
commit 679476e1f0d58037d571df2d56c4db4407607337
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 7 04:08:59 2010 +0000
test: changes for the gluster cli
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1436 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
commit f8e8f33b1fe3707d7aeadada5954f6f0b9990d9a
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Sep 7 04:03:31 2010 +0000
cli: add script mode for gluster
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1554 (add script mode for gluster)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1554
commit 9c35649be782b6732b2f8350d5b939cc49c25036
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Sep 7 00:38:22 2010 +0000
DHT mount fails with parsing of subvolumes
following error msg is seen in the log
E [graph.y:296:volume_sub] parser: Volume 'new-dht', line 38: subvolume 'new-client-0new-client-1new-client-2new-client-3' is not defined prior to usage
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1536 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1536
commit eae6c7b517b98d598637af59dc329fb806c9f3aa
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Sep 6 23:59:48 2010 +0000
Typo in log msg for volume create localhost
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1539 (Typo in error message)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1539
commit e910b150e685df8907cb0cdc76928090f26637c7
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 6 12:40:32 2010 +0000
glusterfsd-mgmt.c: suppress a confusing log during rpc_clnt_init()
* it complains about 'transport-type' not being given. fixed.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1545 (transport type rdma fails in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1545
commit 9bd92be7a5825f286c54233d7c2e71ef881f4fe9
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 6 11:46:01 2010 +0000
glusterd-volgen: write new nfs options in nfs.vol
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1548 (nfs should be able to get different uuid for different subvolumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1548
commit 1bd20c6f63f99fbe3a8ddc788babc68618f45c7b
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 6 11:45:31 2010 +0000
mgmt/glusterd: volume to have 'uuid'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1548 (nfs should be able to get different uuid for different subvolumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1548
commit 5d952f01ca04ff62d8e5b46f31a2ab17a4dd32cf
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Sep 6 09:01:24 2010 +0000
cluster/afr: Fix hang in create when one subvol is down.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1544 (Create fails when 1 server is down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1544
commit 058469e04fae375afc470675b9c3aac08d1ab032
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 6 08:32:25 2010 +0000
cli: change volume create help string
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1542 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1542
commit a116960c2428c2a2192c05bbefc6d7a46759e491
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 6 08:27:20 2010 +0000
cli: check for argument presence before accessing
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1543 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1543
commit fe96f12aa95eb155e8b3d83f626eb79312fd9dab
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 6 08:18:45 2010 +0000
cli: prompt user before remove-brick and stop volume
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1538 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1538
commit 7f9892944aab5463396c0ef5a554c02d6af5986c
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 6 08:12:36 2010 +0000
cli: Only admin should run gluster CLI
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1546 (gluster commandline should be available only for super user)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1546
commit 2f4df5da695511cc6b10e20cff9434d0e45b4802
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 6 08:05:58 2010 +0000
cli: Print volume type None as Distribute
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1535 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1535
commit 5352f95bccacfee2c25dacd0478953b7e08332d6
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 6 08:05:21 2010 +0000
cli: stripe/replica count should be greater than 1
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1534 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1534
commit dba58fb1dad4cbefe8eb04a5ab2d8a0d609a48b1
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 6 08:04:16 2010 +0000
cli: In volume create check for presence of bricks
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1532 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1532
commit 0292861335062e48657fcfbf276bbdcd9818f7dd
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 6 08:02:08 2010 +0000
cli: print volume info cmd usage in case of parse errors
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1533 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1533
commit efa8a7800dd96f3c65cfadc3b5e79c1cc36af93a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Sep 6 06:02:23 2010 +0000
nfsrpc: Set THIS before vector sizing upcall
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1499 (GNFS from mainline Glusterfs-3.1-qa13 crashes while initiating SFS2008)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1499
commit 9ec8d34397ab602b864ca7ccc7535b2facec674c
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Sep 6 05:53:16 2010 +0000
do not restrict the size of the subvolume string as it may corrupt the stack for large number of bricks
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1536 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1536
commit 8409bd686cd04ad3c6529f6c785cd495ca544e33
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Sep 6 05:50:06 2010 +0000
Man page entries for glusterd
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1529 (need man pages for 'gluster' and 'glusterd')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1529
commit 23f2d27c58d39ecbb4656021433d699cda409b0c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Sep 6 05:44:14 2010 +0000
rpc-clnt: fix memory corruption happening while encoding auth data.
- buffer containing authdata pointed by rpc-request was allocated on stack of
procedure rpc_clnt_fill_request, but was being used as source for xdr-encoding
in rpc_clnt_record_build_record. Hence by the time auth-data is being copied
during encoding of request, it might've been freed and hence contain garbage.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 8244b5078d054f477cdc2fc4c1e8a7cb83df302d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Sep 6 05:41:51 2010 +0000
debug/trace: use uint64_t variable while using localtime.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 737 (uint32_t ia_atime crashes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=737
commit cab20244bc19196eca177283f75cf19b28b56a88
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Sep 6 04:18:09 2010 +0000
exit from the test for the first failure itself
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1436 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
commit b5e34d6915a7c4da919b64a7649e63e42555b5bd
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Sep 6 04:22:02 2010 +0000
protocol/client: ignore rpc_clnt_destroy as temp fix for sigterm handling
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1517 (gluster volume stop - starts a new nfs server.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1517
commit 75fbf1f0e443c112facfb7dcac69ee9b3c71b95a
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Sep 6 01:40:18 2010 +0000
changes in fuse proc thread initialization
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1527 (mount time defunct window with remote volumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1527
commit b36b4c6d90fae32242fd099dc8f42efd8775f233
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Sep 6 04:07:33 2010 +0000
doc: Fix make dist failure for gluster.8
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1529 (need man pages for 'gluster' and 'glusterd')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1529
commit 876088e57d8bf2fc34e95af12e125bd248045035
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Sep 6 03:35:02 2010 +0000
misc replace-brick fixes
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 53ac6b236a130b4fe48cafac7057b1dfc62eb880
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Sep 6 01:58:48 2010 +0000
Man pages for gluster
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1529 (need man pages for 'gluster' and 'glusterd')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1529
commit 7c4e229c853b425b0baac761739964a517e5fab8
Author: shishir gowda <shishirng@gluster.com>
Date: Sat Sep 4 01:12:58 2010 +0000
Create volume adding transport type option rdma
Adding transport type option to cli volume create command.
This is optional, and defaults to TCP. The other transport
supported is rdma
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1507 (need to add 'transport <type>' options to create brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1507
commit fc9dcf2ab7d686628afdcf823a48e823f4bdff02
Author: shishir gowda <shishirng@gluster.com>
Date: Sat Sep 4 01:12:09 2010 +0000
Add brick hostname should not be localhost
Add brick hostname should not be localhost or 127.0.0.1, but valid
nodeid or ip. This will prevent volfiles being generated at
respective glusterd's as hostname would be localhost
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1505 (volume create/add-brick requires ip or hostname for localhost)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1505
commit c429cbf721c6c4fcaa6cd4c9f565c93585435b84
Author: shishir gowda <shishirng@gluster.com>
Date: Sat Sep 4 01:11:34 2010 +0000
Volume create hostname should not be localhost
volume create hostname should not be localhost or 127.0.0.1. It
should be a valid nodeid or ip. This will prevent invalid vol
files being created on glusterd's when localhost or 127.0.0.1 is
specified
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1505 (volume create/add-brick requires ip or hostname for localhost)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1505
commit c10fe12430442913a6fa44fcef5a5f134aae5a13
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Sep 5 13:04:50 2010 +0000
mgmt/glusterd: misc fixes in replace-brick and get volumes
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 327e3b6aeaa8a8713bacf68de348396ba5e090ad
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Sep 5 13:04:14 2010 +0000
cli: Display proper message when no volumes are present
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 28d152b0bcddc8e2624119a9676b1c7d8e82df8a
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Sep 4 12:49:37 2010 +0000
mgmt/glusterd: Add GET volume support
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 039d1123a64f907d9a48da6b09eda33c979c4a94
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Sep 4 12:49:16 2010 +0000
cli: Add support for GET volume
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 855274b79b2fa76d77b5c4a9ab763758302cabe6
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Sep 4 12:48:55 2010 +0000
protocol/server: set trans in frame->root
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1477 (server crash at afr_unlock_common_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1477
commit 372e12bc159ad709411543088afd4dad1d6b450f
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Sep 4 05:37:16 2010 +0000
dont destroy the mempools in cleanup and exit as some other thread may be refering to it
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1523 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1523
commit 3b02454db091156b1a17e40a54e439e93673938f
Author: shishir gowda <shishirng@gluster.com>
Date: Sat Sep 4 04:58:17 2010 +0000
Hiding add-brick/remove-brick type option
Currently add-brick and remove-brick type option of replica/stripe
along with count does not change the behaviour. Hiding the usage
options.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1528 (Hide type option for add-brick and remove brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1528
commit c232a633809eb67e067a12525f710b3404318019
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Sep 4 04:07:58 2010 +0000
rpc-transport/socket: fix memory leaks.
- In the course of reading a single rpc-msg, socket_proto_state_machine may be
executed multiple times (since sockets are non-blocking), hence wherever
memory is allocated or referenced, checks should be added whether the memory
is already allocated or referenced.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1438 (memory leaks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1438
commit aaae6071064a1223a55201b98090051feffccc32
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 3 14:10:03 2010 +0000
remove legacy/protocol from the build
* as its no more valid after gfid changes
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit bc6fb1da7f11add562a876e0041c336a87b27bc4
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 3 14:01:29 2010 +0000
gfid: server resolver changes to use gfid instead of ino/gen
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 83c8d5724e7ea82b4b03563d4a83984739a68c81
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Sep 3 11:46:21 2010 +0000
gfid: protocol/xdr changes to handle gfid based fops.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 9d1903ceea4eec488d4f0fc4671b3bc7624ebfc0
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 3 14:01:08 2010 +0000
gfid: changes in distribute to handle uuids in iatt structure
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 58048079c1ccb6dedbb404527183c483526ed376
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 3 14:00:51 2010 +0000
gfid: handling of gfids in storage/posix
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit d0d8030c46a78e98b5ac4eaba76f1ac4fec19309
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 3 14:00:32 2010 +0000
gfid: set request gfids for new entries in fuse
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 4712db816a012b1dbb26c5524434fd1dcc658b65
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 3 14:00:05 2010 +0000
gfid: changes in symlink() prototype to have params dictionary with uuid in it
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 724d7b09fd29425cdccd2e915c8d995fcdae4288
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 3 13:59:48 2010 +0000
gfid: changes in mkdir() prototype to have params dictionary with uuid in it
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 0dc89f53583b92703c291b46c14c6434defd4345
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 3 13:59:30 2010 +0000
gfid: changes in mknod() prototype to have params dictionary with uuid in it
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit c978e8da9362bdcae93e67d0a6b867106893afd0
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 3 13:59:06 2010 +0000
gfid: change in create() prototype to have params dictionary with uuid in it
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit dada22d17f20ed0618ed4cd68e55a709a6d84f5a
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 3 13:58:48 2010 +0000
gfid: changes in inode management
- incorporate usage of uuid (gfid) as the key for finding inodes
- deprecate inode number/generation number based inode_get
- undo code specific to generation numbers (attic list etc.)
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 930de0768a2c05ee7dcb4da32db63b29092b9036
Author: Anand Avati <avati@gluster.com>
Date: Fri Sep 3 13:58:11 2010 +0000
gfid: introduce uuid based handles for inodes
gfid represents a gluter file id. This is a universally unique id
assigned to a logical inode, independent of the inode numbers
assigned by the various backend filesystems to that file/directory.
The gfid of a file/directory will be the same on servers depending
on the cluster translator in picture.
The same gfid can be used as a handle across layers of various
translators and across servers and clients. This was not the case
previously as the cluster translators would pick the backend inode
number from one of the servers and convert that into a logical
inode number by performing some mathematical transforms.
This new technique of addressing inodes also makes dynamic volume
management have a more robust implementation as the file handles
remain the same on all versions of the graphs, and allows for
seamless NFS daemon restarts as well.
This change makes way for server originating communication which
was not possible earlier as the servers did not have any reliable
way of addressing client side inodes at all. gfid solves this problem
by preserving the same uuid as the handle on all the servers and
across all clients
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 76f322038b56a2bf2c042e2b5cf34133e9542244
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 3 06:28:36 2010 +0000
rpc-transport/rdma: notify rpc when pollerr happens, so that client side can try to reconnect.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit c24b00c67bb6a9864546e9ebec63af040ce8e597
Author: Sachidananda <sac@gluster.com>
Date: Fri Sep 3 06:25:54 2010 +0000
cli: Fix clang errors.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1145 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1145
commit bf9f592b6de1e9e4992a088a708f81f9d5620e47
Author: Sachidananda <sac@gluster.com>
Date: Fri Sep 3 05:49:51 2010 +0000
cluster/afr: Remove dead variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1081 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1081
commit 924820e26e75a09d3c532a104cd082de59f4a8b4
Author: Vijay Bellur <vijay@dev.gluster.com>
Date: Fri Sep 3 02:49:30 2010 -0700
Revert "fuse: introduce pre-test micro-framework, check for execve-over-direct-IO"
This reverts commit 588d807bdcbf5ed4df4d903428ab701479e9f8ac.
commit 33044bef65a0e476a3a3172659ceff690f1a0555
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Sep 3 04:01:02 2010 +0000
mgmt/glusterd: clear op ctx after cli response
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1513 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1513
commit 7e46f5ac7e43c60f1b700f0ffed48ca0170df1ca
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 3 02:10:45 2010 +0000
mgmt/glusterd: fix warnings during build.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1307 (gluster volume defrag <VOLNAME> status)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1307
commit a0c6a6dad78f01f4b1bff3c4c7ffd9f1d97c41e5
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 3 02:05:52 2010 +0000
cluster/replicate: fix warnings during build.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 960 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=960
commit 44f51d006d6d835543d2cd3bd8cc4860bf1e9463
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Sep 3 00:49:07 2010 +0000
do not free the hostname from the response
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1511 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1511
commit d7490fd166d3ce958bf2d94840ad6f6b505c72e8
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Sep 2 08:05:36 2010 +0000
mgmt/glusterd: retrieve version upon restart
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1265 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1265
commit ff5261de0c7bd299812588abccc608e58d41bd4b
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Sep 2 07:57:45 2010 +0000
check if the export directory is present only on the brick being added
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1510 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1510
commit d0718cba36b0bc8fa1e7927985e0b75215ba84eb
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Aug 27 09:39:33 2010 +0000
fuse: introduce pre-test micro-framework, check for execve-over-direct-IO
The presence of some potential FUSE features in the actual kernel-side FUSE
implementation we run on is not always straightforward. More precisely, it is
straightforward only if there is a dedicated feature flag or protocol revision
number. In the other cases we are left to clumsy and platform specific hacks
which wire in 3rd-party software revision numbers into our source... at least,
if we insist on sticking to (the otherwise venerable) KISS principle.
However, here we go for another route, loosely inspired by the way autotools
provide an abstraction layer for our build system over the gory details of
platform specific build environments.
At start time, we use a preliminary set of FUSE operations which overlay the
standard ones such that apart from the "usual stuff", they also present some
synthetic files to the FUSE client (kernel). Then we spawn some test programs
which perform the needed tests on these synthetic files to evaulate the FUSE
implementation in terms of the features in question. According to the result
of the test programs, we set the respective parameters of the fuse xlator;
when the testing phase is over, the FUSE operation set is replaced by the
standard one.
As of now, we use this approach to test whether execve(2) works with
direct I/O. If yes, and if glusterfs is used with --enable-direct-io-mode,
then we let direct I/O for files opened for reading; if no, then we restrict
direct I/O only to writing files.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 801 (Direct io-mode support and related changes in caching translators.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=801
commit fd1ef988f1a021dedcb9500b5db7b88c611faedb
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Sep 2 07:04:48 2010 +0000
rpc-transport/rdma: when rdma msg of type RDMA_ERROR is recieved, disconnect transport.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1462 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1462
commit 0e461fe4577116d8f052914e153f42916e5574f9
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 2 07:27:18 2010 +0000
mgmt/glusterd: fix rebalance with new option use-readdirp
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1508 (add-brick works but files are not distributed to newly added server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1508
commit 8e4c6dc37baf7aa745389d430aee9a4e230990c4
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 2 07:26:54 2010 +0000
cluster/distribute: add option 'use-readdirp' to force readdirp
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1508 (add-brick works but files are not distributed to newly added server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1508
commit 69f7614b1b5697c933fb4224ac75565fa8fcb3e0
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Sep 2 07:06:47 2010 +0000
mgmt/glusterd: memory leak fixes
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1186 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1186
commit 0d3f7d66628ce91df7319ed239122bb1b3b474d8
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Sep 2 03:08:55 2010 +0000
cluster/dht: check for op_ret in dht_selfheal_dir_mkdir_cbk ()
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1503 (segfault in distribute during failover testing)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1503
commit 14a47064891dd140fe0831dc630a6e3d308dca37
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Sep 2 05:04:32 2010 +0000
dump total entries cached in stat-prefetch to state-dump file
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit bcf89783c80224991510b186690c7af66ed579e5
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 2 06:36:49 2010 +0000
cluster/dht: fixes to handle 'fix.layout' attribute properly.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1508 (add-brick works but files are not distributed to newly added server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1508
commit bb2395b3bb31442e77adef16da36b51486910807
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Sep 2 05:05:57 2010 +0000
nfs3: Do not unref dst inode on rename cbk
This gets done when the call state gets wiped. Doing it here results
an extra unref causing a segfault.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1464 (fd leak after rename)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1464
commit 4da5dad4a9009030d5bcccfdaa15353d793483c0
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Sep 2 05:03:26 2010 +0000
update the volume information first before checksum
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1504 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1504
commit 2eb54e93cd52b2fecdce83f5c7f6442e601d49fd
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Sep 2 05:24:48 2010 +0000
cli, mgmt/glusterd: Added replace brick cli response
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1322 (Replace brick should show status of paused and abort states)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1322
commit acf400f5e6a5fbcde830e2eabfc358bd8bd5370f
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Sep 2 06:10:11 2010 +0000
nfs3: Free vectored write args using FREE not GF_FREE
..because the file handle in write3args is allocated inside
libc using malloc not memory accounting code in glusterfs.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1499 (GNFS from mainline Glusterfs-3.1-qa13 crashes while initiating SFS2008)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1499
commit fe790f409eee91620d5ee1cae5e8775c141b590a
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Sep 2 04:02:52 2010 +0000
mgmt/glusterd: support for GET_NEXT volume info
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1255 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1255
commit 89cff4de095d9f08b6d7f335606d858bb6a5f91e
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Sep 2 04:03:12 2010 +0000
cli: Changes for GET_NEXT volume info
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1255 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1255
commit eac0c2d67d713586b4d97c5ff4d30ff664f4f9a4
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Sep 2 01:56:02 2010 +0000
mgmt/glusterd: multi subvol support for nfs xlator
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1319 (gnfs support in gluster command line)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1319
commit 17b000d7fb7b7275cbdcbaf973f8cc57021cf70f
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Sep 2 01:22:15 2010 +0000
crash fixed in 'gluster volume log locate'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1506 (crash in log locate..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1506
commit 98e3c11ffb20cae433ecc57133d09813a6d00cfb
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Sep 1 23:44:54 2010 +0000
Remove brick validation
Added checks for duplicate bricks in cli arguments, valid bricks
for the volume, valid volume name, and prevent removing of incorrect
pairs for replica.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1486 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1486
commit 3f5a61acfce00382506fdcf2d6bbf7ffaf90437b
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Sep 1 13:01:23 2010 +0000
mgmt/glusterd: gnfs support in gluster command line
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1319 (gnfs support in gluster command line)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1319
commit eb5a43d147f0438edb078914fe29475306b4d3fb
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Sep 1 05:18:39 2010 +0000
mgmt/glusterd: Fix replicate/stripe subvolume count in volgen.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1497 (gluster volume create creates incorrect volume file)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1497
commit ba83aa6af89de63dd2d3b9a4cb0b99a9d383cf25
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Sep 1 05:13:29 2010 +0000
peer status returns duplicate peer info on restart
removing the peerinfo file for hostname once peerinfo is stored
in the uuid file name.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1498 (Peer status duplicate entries on restart of glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1498
commit 7f2adc9b36a84ed2f63bbfdf80b13bfd7e37ea20
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 1 03:44:12 2010 +0000
rpc-transport/rdma: set whether pollin data is for request/reply.
- with implementation of call backs client and server can both recieve
request/reply.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1488 (rdma client fails to connect to the servers)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1488
commit 6221ea4b055546aeb236d998d1fecf99d446e96a
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Sep 1 03:12:56 2010 +0000
check if the volume is already started before starting
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1496 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1496
commit a97ff09cb2d428fec8f31a252ffa21970cb1df78
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Sep 1 00:01:17 2010 +0000
mgmt/glusterd: send unlock upon commit failure
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1476 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1476
commit fe7553768c911406b43c87655f2db912931ea9c8
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Aug 31 10:25:51 2010 +0000
cluster/afr: Break STACK_WIND loop when the call count is reached.
Fix also has a check for self heal relevant to pump.
Tested with dbench with AFR client and pump on server.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1443 (Crash in afr_nonblocking_entrylk_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1443
commit 465e097e5ed2cc6ccc24c5c51e2dec8bd8f69083
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Aug 31 12:52:34 2010 +0000
mgmt/glusterd: memory leak fixes
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1186 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1186
commit d21284480ed3aaaa0f264364f6e029329efc8ca3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Aug 31 10:02:54 2010 +0000
rpc-transport/socket: use xdr_sizeof instead of sizeof when trying to read vectored request/reply
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 5070643838657b87f195791b8c4779203d9749f0
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 31 11:15:27 2010 +0000
mgmt/glusterd: prevent a double reply for the same request.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1401 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1401
commit 4f52a6eaa0e251a5abd8f41e2ef09e765bf71b9e
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 31 07:45:20 2010 +0000
fixes in 'gluster volume rebalance'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1481 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1481
commit 56ddd00cd3df109edd80c0ef225fab9e36e1048e
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Aug 31 08:57:19 2010 +0000
check if the export directory is present only on the correct host
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1489 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1489
commit e0b68cde86a81799b6d3245e850e32dfaaf0158e
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 31 07:51:14 2010 +0000
'gluster volume log' feature added
* 'gluster volume log filename <VOLNAME> [BRICK] <path>'
* 'gluster volume log locate <VOLNAME> [BRICK]'
* 'gluster volume log rotate <VOLUME> [BRICK]'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit 00ffeadc8f3025e8a1a1b90748f871ef748d6ea9
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:37 2010 +0000
nfs, mount3: Fix assumptions of this being child xl
This is plain wrong. this must always be the xlator that receives the callback.
Use cookie to access the child subvolume on which the fop was issued.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1410 (nfs uses this for child translator during frame creation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1410
commit abe3718c4aa565618a17a4c69fea41d7a3b72189
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:36 2010 +0000
nfs: Create frames with frame->root as nfsx
frame root was being set to the subvol on which the fop was to be performed.
Apart from just being totally wrong behaviour, this also messes up
mem-accouting because there THIS points to the wrong xlator resulting in crap
addresses being dereferenced through the mem type index.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1410 (nfs uses this for child translator during frame creation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1410
commit a93a79bf1e86723b9c762b0cadf1c08d42719254
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:35 2010 +0000
nfs: Set actorxl to enable setting THIS to nfsx
..for fixing mem-accounting for NFS in mainline.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1280 (gf_mem_set_acct_info goes into spinlock busyloop, never returns)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1280
commit 2883c61ecca68ea35f7145c9febec1cbb212fddc
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:34 2010 +0000
nfsrpc: Introduce THIS-setting support to fix mem-accounting
Not setting THIS in nfs/rpc has been a blocker for NFS on mainline because
without THIS set correctly to nfsx, mem-accounting goes looking into
translators other than nfsx for nfs memory allocations, resulting in
dereferencing bad addresses.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1280 (gf_mem_set_acct_info goes into spinlock busyloop, never returns)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1280
commit 94243210b20a7b937c7de07239dc0178f4f7a78c
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:33 2010 +0000
nfs3: Close dst cached fd & unref inode on rename
If the src file is over-writing an existing file and if the
destination file is open, then close the cached fd on the
destination file and unref the inode for it.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1464 (fd leak after rename)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1464
commit fe27920dfeab4b458812ac6361c29b316e9b60da
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:32 2010 +0000
nfs: Free fop local only after inode checks
Fixes a crash that occurs because the nfs-fops code accesses
a fop local after it has been returned to the mem pool.
Generally seen when nfs load is so high that the mem-pool runs out
of memory and starts CALLOCing.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1449 (NFS crash in nfs_fop_fsync_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1449
commit b0c230daad0292785e127b3af3bef2ba504c204f
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:31 2010 +0000
nfs3: Return ESTALE when going beyond fh-hashcount or max-hashes
During fh resolution, if we go beyond the max hashes support by
gnfs or if we go beyond the dir depth specified in the filehandle,
then return ESTALE.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1378 (Deep directory creation crashes gnfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1378
commit 77d8061ce4d9635876970458d986147f1fe57a7b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:30 2010 +0000
nfs3: Logging and comments made more accurate
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1378 (Deep directory creation crashes gnfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1378
commit de79ed51fae3a42e1e0115b8ca9490e6a132d766
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:29 2010 +0000
nfs3: Support hashcounts larger than hash array size
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1378 (Deep directory creation crashes gnfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1378
commit 9ea84b510fad22ce3e0c0162a17b44f994191edd
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:28 2010 +0000
nfs3: Unref dir fd once usage ends in hard fh resolution
There are three conditions when a dir fd_t needs to be unrefed
when:
a. the inode being searched is found as the candidate entry,
b. we have exhausted all the entries in the current dir,
c. we decide to step into a child directory because of a hash
match.
This decision is made in nfs3_fh_resolve_check_response.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1397 (Cached dir fd_ts are a leakin')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1397
commit 60b21bf4c52663ad14518321cd7fc82c864a9868
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:27 2010 +0000
nfs3: Dont ref dir fd_t used in hard fh resolution
..because the extra ref was under the mistaken assumption that
directory fd_t will be cached even during hard fh resolution and
that is not the case.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1397 (Cached dir fd_ts are a leakin')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1397
commit 1e7b7fc176ca659a678353a383b5b10ce9bdda29
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 31 06:50:26 2010 +0000
nfs3: Dont ref cached fd after fd_lookup
..because fd_lookup returns a ref'd fd_t.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1397 (Cached dir fd_ts are a leakin')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1397
commit e5962f3cf5b8bd38bffd1000b8d201e136605c1f
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 31 06:17:44 2010 +0000
Add fuse.glusterfs to PRUNEFS variable in updatedb.conf(5)
Append fuse.glusterfs to PRUNEFS variable in updatedb.conf(5).
updatedb(8) should not index files under GlusterFS, indexing will slow down
GlusteFS if the filesystem is several TB in size.
Plus some whitespace cleanup.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 538 (disable glusterfs mount from updatedb.conf)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=538
commit cce14b3e15acde5b7a67f5540a77ba3db87fa251
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Aug 31 04:10:46 2010 +0000
Log all commands from glusterd
Logging all commands processed by glusterd which causes some
change. the log file is @ /etc/glusterd/.cmd_log_history.
gf_cmd_log() is used to write to this log
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1404 (need a dump of all the op/mgmt commands)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1404
commit d0ec11edcb736e4f815cf1456fdfb6dada2a3d7e
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Aug 31 04:10:17 2010 +0000
Add command logging facility for glusterd
Added new command logging facility to gf_cmd_log() which can be used
to log all commands to a .cmd_log_history file situated in the
glusterd working directory.
Accepts 1 st argument a domain string (e.g: volume, peer..) followed
by msg string (similar to gf_log)
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1404 (need a dump of all the op/mgmt commands)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1404
commit 6ac61748b94aa4a434028775d22da0f1a59c924b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Aug 31 03:20:29 2010 +0000
rpc-transport/rdma: By default, enable building of rdma only if libibverbs is installed.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit d790ea3b8081998fa54c916c349be7db34ca4a3c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Aug 31 03:09:36 2010 +0000
rpc-transport/rdma: free ioq entry even when churning of message fails.
- An ioq entry is added to ioq-list only when it is not processed due to lack
of quota. For all other cases, it should be freed to avoid memory leak.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit 044088fc91d3a1a654f154b49da771d36153b20a
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 31 01:17:56 2010 +0000
fix a crash in cleanup_and_exit ()
* fini() was being called without proper 'THIS' being set.
* in protocol/client, a frame was getting created after frame
pool was destroyed
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1030 (mount directory is not unmounted after killing glusterfs process)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1030
commit b34fc5f26c2b14dab7890ec064d86250b2719bef
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Aug 31 01:12:56 2010 +0000
fix typo in commandline help message
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1482 (typo in help message)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1482
commit b3b45370badb9064561a0425cfddcf44e2fa9309
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Aug 31 00:59:47 2010 +0000
mgmt/glusterd: Update store on start/stop volume
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1480 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1480
commit b8fec2aacba3f0c20c6fd3c4b4df74637c91375e
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Aug 30 08:24:50 2010 +0000
fuse: have the fsname passed to mount(2) include the volfile id
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1478 (show volfile id in mount(8) output)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1478
commit 33f9dfa38b0b16b49ab5b3d464bf8af748144df4
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Aug 30 16:05:16 2010 +0000
mgmt/glusterd: Return replace-brick status
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1322 (Replace brick should show status of paused and abort states)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1322
commit 698dd075eda34258a3632983f1eb1fc651d14c37
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Aug 30 05:52:27 2010 +0000
mgmt/glusterd: fixed volgen creation problems
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1454 (Remove brick unsuccessful - wrong volume info)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1454
commit 315312709afad31006b380ed344c197803e42a08
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Aug 30 08:04:24 2010 +0000
Add rdma as valid transport type for client and server protocol.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit 2de690d469f026b115dd3e164382398629fed24d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Aug 30 08:04:07 2010 +0000
changes to client to make use of the rdma functionality.
- preallocate buffers in client and pass them to transport layer whenever a
large response is expected.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit 0175316548a33f83c154ea8ff96e4c10680bfb21
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Aug 30 08:03:52 2010 +0000
Bring in new transport rdma.
- rdma is new transport and improvement over current ib-verbs. It uses
rdma-read and rdma-write for efficiently transferring large buffers.
For more details please refer to rfc-5666 and rfc-5667.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit 63b49fd533d9278ed5a73ac9b68643bed965d24c
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Aug 30 03:54:32 2010 +0000
Only admin should be able to run gluster command
Checking for port number to fail any requests coming in
from client. if port is >1024, then fail the requests
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1403 (only admin (uid 0) should be able to run 'gluster' command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1403
commit 097303b980970052cc4e635ad88f4e15bd66f11e
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Aug 30 01:44:00 2010 +0000
glusterfsd: call fini of fuse and all active xlators in cleanup_and_exit()
* handles the case of stale mount point in case of killing glusterfs process
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1030 (mount directory is not unmounted after killing glusterfs process)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1030
commit 22c669c880a1899a7cd0b1e3bb35895fab04a0ef
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Aug 30 01:36:33 2010 +0000
Volume Add-brick validation for exports
Added checks for export already in use, duplicate exports in command,
and check whether exports are valid.
Also, cleaned up error handling in glusterd_handle_add_bricks
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1457 (volume add brick validation for export)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1457
commit 4fd51969fd45299fbea81ab62dbfd71078389880
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Aug 30 01:16:05 2010 +0000
mgmt/glusterd: remove volfile, brick file upon remove-brick
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1475 (glusterd should delete brick related files upon remove brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1475
commit 1a9f4c94910f9baf75c13f30b261f01b33da34e4
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Mon Aug 30 01:33:14 2010 +0000
Provides the ability to filter the output of state dump
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 828 (glusterdump filled up the /)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=828
commit 6edc2355aba6f779c9eea5df0e1c5a2cd3fcc7a3
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Aug 29 07:08:37 2010 +0000
mgmt/glusterd: handle port allocation so ports are reused for same brick
* if 'brickinfo->port' exists use it instead of pmap_registry_alloc(),
hence a brick after stop/start starts on same port
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1473 (reuse the ports while starting 'glusterfsd')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1473
commit 5046c079db94de0c7d8c66a2f848e257c93bcdd4
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Aug 29 06:43:58 2010 +0000
gluster{d,fs,fsd}: add logrorate functionality to SIGHUP
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1472 (SIGHUP should do 'logrotate')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1472
commit c5eab8ccecf4385e0552d19997a8d3c31ea612b0
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Sat Aug 28 06:02:54 2010 +0000
cli, mgmt/glusterd: added volume stop <VOLNAME> force functionality
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1361 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1361
commit 95a58be33ca8d35e42abcfa56c8c6960f7a8beec
Author: Pavan Sondur <pavan@gluster.com>
Date: Sat Aug 28 05:23:28 2010 +0000
mgmt/glusterd: Fix some more options in volgen.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1455 (df command hangs before showing the gluster mount)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1455
commit 7a495c570db9f529697666033e902e5cb4632c03
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Aug 28 02:18:47 2010 +0000
dump the volume file details in log file if graph init succeeds
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1468 (after dvm changes, volfile info is not dumped in logfile)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1468
commit 0844df130d89099bb724582a98973a9c7bf0102b
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Aug 28 02:02:51 2010 +0000
afr: enable metadata self-heal by default
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1467 (enable the metadata-change-log by default)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1467
commit 2fb258506690b1fe112e81b32be3f254e1e64a55
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Aug 28 01:50:37 2010 +0000
change the path to brickpath while creating the pidfile
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1409 (Gluster add brick fails if all the bricks are local)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1409
commit 821d996fed96f9f764cbd0438582fb9436c77466
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Aug 28 01:10:02 2010 +0000
performance/stat-prefetch: while removing an entry from cache, remove it from caches stored in all opened fds.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1414 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1414
commit 941e9537feaec293609ae8caf32f1a8b0147ad14
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Aug 27 11:55:29 2010 +0000
mgmt/glusterd: look for local hostname in is_local_addr()
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit 8b728b9a72b5209513cc74615110f76c6ae4a8d8
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Aug 27 09:06:13 2010 +0000
check for ENOENT after unlink system call in stop volume function
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit b7738ff331d8fd82df0b3e7c35ad3fcae6af6580
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Aug 27 09:30:46 2010 +0000
change the shell to bash form sh
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit 5f01884ab5da0ad5c176e7da0658c1875815e6da
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Aug 27 09:28:37 2010 +0000
fix notify mechanism to send CHILD_UP to fuse
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit c7b1d7d10edc381178591d9128f3bdd1d6bd5ad3
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Aug 27 09:06:29 2010 +0000
protocol/server: fix a static buffer free.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit dd8ac7ce967e5c147ac5ae2edf37fd81dc333c20
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Aug 27 07:22:24 2010 +0000
volume create should not succeed on invalid export
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit d234301776d9a91e508c1d01126dce3ff00ab543
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Aug 27 07:19:02 2010 +0000
mgmt/glusterd: allocate hostname before dict_set_str for transport
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit c220e7088a781e4c47ca3683903a792fd24cc02b
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Aug 27 06:45:38 2010 +0000
rpc: server to client callback mechanism
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit a24a367dc9a9e20ee7b4798a21342d881f877ff0
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Aug 27 05:55:02 2010 +0000
Volume create checks for used bricks
Added check for create volume from using bricks already in use.
Also cleaned up the error handling fixes in glusterd_handle_create_volume
Volume create should now fail if a brick is specified that is already in use.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit 60ca88b8a75afb9ddd856106df318510dc095377
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Aug 27 04:49:34 2010 +0000
mgmt/glusterd: fixes in volgen file paths
* fixed argument to few xlator options generated by volgen
* commented out many options which we want to be default
* pid file and volume file name to contain export path info in them
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit c9a84c6c07a98ba48d362867496117674f029d5d
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Aug 27 03:57:53 2010 +0000
Misleading probe message for friend
Progress with probe if host already is present in the list and
state is not default or request received.
To test, probe from on host, on the other host, do a probe back to
host1. This should now continue with probe for the first time. Second
probe should return already friend msg.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit 20ae6a213da10e33bab78c8c5605b321ca14ab02
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Aug 26 12:17:37 2010 +0000
cli, mgmt/glusterd: validate brick
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit 8dadf3db81e88b3b20058bad0e40fe7a2502b906
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Aug 27 00:33:31 2010 +0000
cli: command parse validation
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1431 (cli: check if arguments exist before the accessing them)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1431
commit e5c4e8c3a749b63417b6e8f099e518ca44b58b33
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Aug 26 13:31:23 2010 +0000
cluster/afr: Hold ref on the right fd
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1365 ([3.1.0qa5-15] Self-heal doesn't happen from 1st subvolume to others)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1365
commit f488fe744ef433b0db6352e914c26b8c39f3bd3b
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Aug 26 11:42:24 2010 +0000
mgmt/glusterd: free op ctx only if it is allocated
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1236 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1236
commit 918ed61e625437d3af92376582e608a02caac108
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 26 09:09:59 2010 +0000
glusterd-pmap: trigger signout by RPC_DISCONNECT event
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1314 (portmapper functionality)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1314
commit 91be394cb1ebebbb0a7a9e1a402f2d28fab84eb2
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 26 08:13:06 2010 +0000
glusterfsd: don't call pmap-signout in 'cleanup_and_exit()'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1434 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1434
commit c0c391761d64d30ee5eb5cbd77b4204c6e951cf8
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Aug 26 07:55:38 2010 +0000
mgmt/glusterd: Use a C based volgen and support various xlator options.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1429 (Use a C based volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1429
commit 97d4f96d7d51689c116a7d5d165860746bc545d4
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 26 07:42:30 2010 +0000
fix glusterfsd to glusterfs getspec
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1445 (getspec doesn't work from glusterfsd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1445
commit 37c357f01c5c8ab46efcdc51481175978ca631f5
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 26 07:40:07 2010 +0000
rpcsvc: handle the case of null dereferencing
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1446 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1446
commit 7773ebd368c95db331423b894f10cdc35fa017b8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Aug 26 05:57:25 2010 +0000
rpcsvc: fix double free happening when listener creation fails.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit 2549f2a851b63b19ebcb846582ebbb958546afef
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 26 05:53:41 2010 +0000
glusterd: handle failure of 'getspec' in case of '-' in volume name
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1433 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1433
commit 2196b959a4f652fea07b854276af3dbb437cb2d4
Author: Sachidananda <sac@gluster.com>
Date: Thu Aug 26 05:44:07 2010 +0000
cluster/dht: Fix clang errors.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1069 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1069
commit d2e6cb67e03870ee537bb8728279767852da0d5e
Author: Sachidananda <sac@gluster.com>
Date: Thu Aug 26 04:45:46 2010 +0000
glusterfsd: Clang error fixes.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1077 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1077
commit db48945977cc10bcc9b5ccba0ced403cd9fa2447
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 26 04:10:19 2010 +0000
Cli volume create detect dup bricks
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1184 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1184
commit 088b96c8cb0b3e8b238e2b9d0afecb2af1781d73
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Aug 26 03:53:31 2010 +0000
script for testing basic gluster commands
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1436 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1436
commit 26e3c17a1dae613bc3f327425eb62c52239402a2
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 26 03:32:21 2010 +0000
Cli volume add-brick validation
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1440 (volume add brick validation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1440
commit 9a41c125b169179fcfe95787822654a2f36f4db6
Author: Sachidananda <sac@gluster.com>
Date: Wed Aug 25 03:39:03 2010 +0000
cluster/afr: Remove dead assignments.
Signed-off-by: Sachidananda <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1075 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1075
commit 9b17765c650d1cc4636b21fbb5c88ec76049f1f5
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 24 12:30:57 2010 +0000
cluster/afr: Remove dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1078 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1078
commit 153b93863ed1591491a2a95e09bc278846f35047
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 24 11:07:18 2010 +0000
cluster/afr: Clang fixes.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1079 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1079
commit 0d47cd9b24f10436b442e93fe03c8266242313e7
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 24 06:43:54 2010 +0000
cluster/afr: Clean up dead variables.
Clang error fixes.
Plus some white space cleanup.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1080 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1080
commit 5bad7a37399d82439d64493a28720db24c4c2657
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Aug 26 00:39:59 2010 +0000
replace struct stat by stuct iatt
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1441 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1441
commit 12906ef7347e91671704d4ef7ae181a549dcc6a8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Aug 26 00:30:03 2010 +0000
transport/socket: free priv->incoming.request_info if not already freed after reading each message.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1438 (memory leaks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1438
commit a4621bca1cc5b2c88cf3ff68823bb7b2e997e740
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Aug 26 00:29:21 2010 +0000
rpcsvc: handle the return value of rpcsvc_create_listeners properly.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit bc780b3d87f98b4d465dae73c1d1639db2e21a66
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Aug 25 06:16:46 2010 +0000
Cli volume create validation
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1185 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1185
commit 1f376d055b4bb691757d6a8909a89d6378275a9b
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Aug 25 06:07:14 2010 +0000
cluster/afr: Do not issue blocking locks in self-heal.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 960 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=960
commit 2e707b2020940aefb256acf04bdf745a4ce86b08
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Aug 25 02:09:06 2010 +0000
cli: print usage message when parsing of cmd fails
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1432 (print usage string in case of command parse errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1432
commit 2833d41d68beaba7a2807c18cd3d0b5f243d35a6
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Aug 25 01:59:15 2010 +0000
cli: check if the arguments are present before accessing
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1431 (cli: check if arguments exist before the accessing them)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1431
commit d0fcc78dd52a58e040565e1babb002c8841daca6
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Wed Aug 25 01:58:23 2010 +0000
Help Added to the Gluster-CLI for all sub commands (some deletions in the old patch)
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1156 (gluster --help should display all the options)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1156
commit a09819c7b114e2ac0462685e2cd2472f03282c85
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Aug 25 01:40:56 2010 +0000
mgmt/glusterd: check if the brick already exists in stage add-brick
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1289 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1289
commit 6ef258e12f1dafe4d40f470eb950a5b98d452c27
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Aug 25 01:40:00 2010 +0000
storage/posix: calculate the correct size of each dirent in readdir/readdirp.
- In addition to posix, protocol/server also adds a check to make sure that
iobuf allocated to hold readdir/readdirp response can hold all the dentries,
rpc and proc (readdir/readdirp) header.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1430 (encoding of readdirp response fails occasionally)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1430
commit 4e4b73fd30757daea9fb455cc1c25308dac79532
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Aug 25 01:32:52 2010 +0000
cli: print volume create command usage in-case of parse errors
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1263 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1263
commit 9d86e01a304f37a3dfbd84244b790bdbd7470cb2
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Aug 25 01:29:07 2010 +0000
cli: validating if the arguments exist before accessing in volume create
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1202 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1202
commit 42bec152f481128a91ac15de3336a1c3705e3809
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Aug 25 01:18:38 2010 +0000
legacy/protocol/client: fix namespace collisions.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1418 (Crash in saved_frames_put)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1418
commit 1df583f4f897f787cc8151d056698bf59ebcd0da
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 24 03:59:05 2010 +0000
cluster/afr: Clean up dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1084 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1084
commit 210627a1b8dac4fc72b6429068d4e847f8bba92e
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 24 02:53:01 2010 +0000
cluster/afr: Clean up dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1086 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1086
commit 3b1cd63e488553d7084665631457bc495da952ab
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Aug 24 02:15:56 2010 +0000
fix the typo present in sh_missing_entries_create function
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 905 (Typo in log message in sh_missing_entries_create of afr-self-heal-common.c)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=905
commit 9a978c258ddab89d4ea53f61da82ba430adb0f6f
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Aug 24 01:16:10 2010 +0000
glusterd: avoid cleaning up rpc during peer detach
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1423 (Crash in gf_timer_call_cancel)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1423
commit 9e89ef1e903ed1d732f9d3420b4c28cd5091d566
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 24 00:49:49 2010 +0000
cluster/afr: Remove dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1087 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1087
commit e9d40fa91b6609697a825fba9ba7760853c61e85
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 24 00:42:39 2010 +0000
fuse graph initialization related changes
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1406 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1406
commit cd10badce08e36269055372a9d702cb72ee787f1
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Aug 23 13:04:21 2010 +0000
doc: Include transport-type in glusterd.vol
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1377 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1377
commit 72a8a443b021638cb8ee446f24762796fd8acace
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Aug 23 12:56:07 2010 +0000
glusterd: Inject right event during peer detach
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1215 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1215
commit 5c1441ee958f0a9748795622a2ae3f2d831b4359
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Aug 23 03:51:21 2010 +0000
glusterd: support for volume version and cksum
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1310 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1310
commit 3a952928aeb1a68756dabd12382bded483ab36ac
Author: Sachidananda <sac@gluster.com>
Date: Mon Aug 23 00:08:37 2010 +0000
performance/io-cache: Remove dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1112 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1112
commit 3abbf517261fcfdc811efdb5c8b550fee2ad482f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Aug 23 01:42:47 2010 +0000
rpcsvc: allow creation of both rdma and socket for a single server transport.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 513 (Introduce 0 copy rdma)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
commit f2d43042306c860deea9e5f0ada6a6da9484aa39
Author: Pavan Sondur <pavan@gluster.com>
Date: Sun Aug 22 14:09:48 2010 +0000
protocol/server: features/locks: Fix nonblocking entrylks, inodelks in locks and server.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 960 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=960
commit 269f8978e81d5901efaf6a891bc353972c87ac17
Author: Pavan Sondur <pavan@gluster.com>
Date: Sun Aug 22 14:08:43 2010 +0000
cluster/afr: Use 2 phase locking for transactions and self heal.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 960 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=960
commit 9c50168e1dc41cbc51c77e7970b1071fbddb3ce5
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 17 05:19:04 2010 +0000
xlators/nfs: nfs3-helpers.c remove dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1115 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1115
commit 68a5cf143ed89559cc5886c8e1917800de178b5c
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 17 04:59:49 2010 +0000
xlators/nfs: nfs3.c - remove dead assignments.
Removed dead assignments and unused variables reported by clang.
One of the reports uncovers a minor bug in gnfs.
> Dead store Dead assignment xlators/nfs/server/src/nfs3.c 2860 1
A separate bug is logged for the above report and assigned to Shehjar.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1114 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1114
commit ab0e1a37bf13f54d9ca4df94e504c899acae852d
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Aug 21 01:54:30 2010 +0000
gf_system: fork/exec instead of system
* most of the glusterd 'system()' are replaced with 'gf_system()'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1292 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1292
commit 08725473d06d72f8784709257b55085b288a35f3
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Aug 21 01:53:42 2010 +0000
glusterd: prefix added to gluster commands
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1283 ([3.1.0qa3] gluster volume create and volume start fail on when glusterfs is installed on prefixed path)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1283
commit fc87f91674fd30041d2ce0cc1c20209dc2d0d421
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Aug 21 01:50:31 2010 +0000
portmapper program added to glusterfsd mgmt rpc
* some bug fixes glusterd-pmap.c
* also renamed 'fetch-spec.c' -> 'glusterfsd-mgmt.c'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1314 (portmapper functionality)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1314
commit 5e61bad2967d2d851fe6666f731dfd25e7da95b7
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Aug 20 23:44:52 2010 +0000
fix the wrong log message displayed by glusterd in remove brick
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1411 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1411
commit 8bb102267a6a82c895a5c7b48910df18dc8e7cca
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Aug 20 07:50:39 2010 +0000
generate separate volume files for nfs in case of 'portmapper' mode
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1319 (gnfs support in gluster command line)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1319
commit a2c145ff3e28f0dc291b1f9c6aae408e5c1abbd2
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Aug 20 07:23:15 2010 +0000
check whether xlator is NULL in FUSE_FOP macro
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1407 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1407
commit 956bd46c1db69a1ae122875e3b1056f1ceb887b6
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Aug 20 05:37:31 2010 +0000
performance/stat-prefetch: use SP_STACK_UNWIND instead of STACK_UNWIND_STRICT.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 993 (memory leak-in stat-prefetch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=993
commit 591baa546e4ecf920d9f67a6038fb315f13fd962
Author: Sachidananda <sac@gluster.com>
Date: Fri Aug 20 01:28:32 2010 +0000
xlators/mgmt: exit if directory creation fails.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1408 (glusterd continues despite directory creation fails.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1408
commit 2bcfc30251716148c7d4a1464f8c9c5fa14eaa16
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Aug 20 01:16:21 2010 +0000
Hide cli peer command port option
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1261 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1261
commit aa3d3137eec168e9339ca9d842ccc9f61f48cea1
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Aug 19 11:50:08 2010 +0000
cli: Fix issues in non readline mode
Signed-off by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1300 (gluster core dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1300
commit cb8b46ad814581fdaf6cabbe544d74c67cfbcc24
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Aug 19 10:42:33 2010 +0000
rpcsvc: decouple creation of listener from rpcsvc_program_register and rpcsvc_init.
- with this patch every program that wants to register itself with rpcsvc should
also create one or more listener(s) and register with portmap (if necessary).
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit d055cb389fc5fb12982d579f92bbf11b990c6fc4
Author: Sachidananda <sac@gluster.com>
Date: Thu Aug 19 09:42:09 2010 +0000
libglusterfs: Fix warnings reported by clang.
Fix errors reported by clang.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1088 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1088
commit 2c59cf9bf4f22404b77397ae301fad739343c8ab
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 19 07:22:15 2010 +0000
Probe should not probe for existing friend
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1331 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1331
commit 78e0a0379aa8c521f8c893378189b18c131f9f70
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 19 07:21:42 2010 +0000
Probe on localhost not needed
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1216 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1216
commit e772981954cf099508ef6247ba8106e82386dcad
Author: Sachidananda <sac@gluster.com>
Date: Thu Aug 19 04:48:06 2010 +0000
xlators/storage: posix.c - remove dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1089 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1089
commit f73b7d1a57c5143097502a86d52b34a275044d20
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 19 04:33:07 2010 +0000
protocol/client: fix ESTALE in statfs on root inode
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1397 (Cached dir fd_ts are a leakin')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1397
commit 37f42f7d615bbd8bae528cebb4ad47c0b026e9fd
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 19 02:42:18 2010 +0000
protocol/server: remove default progport from the fop program definition
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1396 ([3.1prealpha3] Multiple glusterfs processes fail to start with different port nos)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1396
commit db379d52e9e1f108d91c1abba3e6b4acd17ab4a3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Aug 19 02:06:03 2010 +0000
rpcsvc: change in port selection criteria for program to listen on.
- give preference to port specified in options over the port in program
structure when both are specified. This will enable us to run multiple
glusterfs server instances on the same machine.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1396 ([3.1prealpha3] Multiple glusterfs processes fail to start with different port nos)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1396
commit f3e5eb98622451c6e0165fb9ecbf529a82f463fa
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Aug 18 14:23:02 2010 +0000
rpcsvc: check for listener on default port used by mgmt (6969) while registering programs.
- If programs have not provided a default port, rpcsvc tries to allocate a
listener bound to default port. While registering programs, if programs
have not given any port information, programs will be associated with
either default listener or the one provided in options provided during
rpcsvc_init, with latter given more precedence.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit fb20a87e217122386843cb0fa2bb3c78895da44c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Aug 18 09:11:12 2010 +0000
rpcsvc: unref transport stored in request before putting request structure back to mem-pool.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit e21841c112873b3caad12e7a640267460185582f
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Aug 18 08:56:56 2010 +0000
fuse: prevent NULL dereference in case resolve on path failed.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1391 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1391
commit 5c88a25b0b59c9abdeaa9b2e0637dfffcc7d65f8
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Aug 18 08:57:22 2010 +0000
rpc-transport/socket: proper cleanup and NULL deref checks.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1326 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1326
commit 0fbf388c9370a9d1c5ed654772dc5d0479e31329
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Aug 18 07:39:52 2010 +0000
Modify the help message for volume create
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1229 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1229
commit e8ef734ce4a3489858e96a7e644b21b65f5a10d5
Author: shishir gowda <shishirng@gluster.com>
Date: Wed Aug 18 07:49:15 2010 +0000
Fix memory corruption in mem pool
Added new interface mem_get0, which calls memset on the
mem pool entries being returned.
Gluster and Kernel compile should now succeed.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1393 (Gluster and kernel compile fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1393
commit 9f8febd2ee9e38a697d58700c112cf18cd3c1f53
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Aug 17 23:58:37 2010 +0000
rpc: add rpc_req structure to request_info structure, used by transport layer to get corresponding request to reply received.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit dbfd669df4d71d4886b6a7ac5fdc07393d1d194f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Aug 17 05:35:42 2010 +0000
rpc - cleanup and changes related to rdma
- remove rpc_conn_state structure.
- add a member to point struct rpc_req in rpc_transport_req structure.
This is needed for rdma to store rdma specific per request data.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 16bda937cebdd7419d76e7917e2d9587b2ee8ffc
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Aug 17 22:23:25 2010 +0000
cluster/afr: rename should not consider ENOTEMPTY as failure
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1352 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1352
commit 14698718b68f0f90ec096cbece1cd78719db114c
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Aug 17 14:52:34 2010 +0000
rpmspec: include copying.gpl and copying.agpl
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1275 (Fix rpm glusterfs spec file for 3.1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1275
commit d354a3c95027ed2ca673759fbaeaa2f6646c9692
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Tue Aug 17 12:59:57 2010 -0700
Makefile.am fix for COPYING changes
commit 83c924a9cbe37f45fa7734b5c0efafbf94434741
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Aug 17 10:37:21 2010 +0000
rpm spec: rename glusterfs-main to glusterfs-core
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1275 (Fix rpm glusterfs spec file for 3.1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1275
commit a2daeeea38928fd3ce46c92be5aeeada044a8fca
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Aug 17 09:44:20 2010 +0000
client: Do reconfig upon failure
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1341 (glusterfs-volgen should behave differently for flag '--internal')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1341
commit 073376209cc5476b060dbef8fae5ebb5da4f6933
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Aug 17 09:19:20 2010 +0000
changed GNU General Public License to GNU Affero General Public License
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1388 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1388
commit bacbc5dba368b2d4c388e2d1aefd32516d1ecdec
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Aug 17 06:07:17 2010 +0000
cluster/afr: truncate should not treat EFBIG as failure
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1351 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1351
commit dc3b87805ca0c298778bec313cdf46fff22ba1e4
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Aug 17 06:06:30 2010 +0000
cli: block command hang
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1370 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1370
commit 9ef1e3da176212d75cd45b78aee5edb49c41f3f5
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 17 05:38:25 2010 +0000
xlators/performance: quick-read.c remove dead assignments
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1109 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1109
commit e145e289a69c36dbf164a615940231f510932861
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Aug 17 05:06:58 2010 +0000
cluster/afr: Return correct flock structures correctly in lk fops
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1042 (Use correct flock structures in lk fops)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1042
commit d1dbc658bda0bd2054f23ac078e4ec3a308a0674
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Aug 17 04:50:59 2010 +0000
glusterd: fix for a crash in add-brick
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1380 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1380
commit 76b0fc58da91797cd6c46855f8a1d08fb42416d5
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Aug 17 03:31:36 2010 +0000
volume creation validation
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1267 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1267
commit bf8bc438814f021440f7a52e236431c3ddbada8f
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Aug 17 03:26:51 2010 +0000
Do not allow all to be a volume name while creating volume
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1209 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1209
commit e89fec60916547f29ffad0426e39800673a0c088
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Aug 17 03:37:46 2010 +0000
cli: Implement help command
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1229 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1229
commit e07a379bf64eeb48a022da0bd73d66d9c60262f8
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 17 01:46:43 2010 +0000
xlators/nfs: rpcsvc-auth.c - clean up dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1119 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1119
commit 56afa4c99f9336728bb5714bf28a445e93f0c52d
Author: Anand Avati <avati@gluster.com>
Date: Tue Aug 17 02:53:51 2010 +0000
protocol/client: fix reconnection to happen on portmapper first
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1341 (glusterfs-volgen should behave differently for flag '--internal')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1341
commit 9c4d14229c8a55dbbe062d4b9409eabf809c1781
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Aug 16 11:47:04 2010 +0000
glusterd: Fixes for add brick
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1374 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1374
commit 12fc31d6a1e9371b12db78b77209380d4a373df3
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Aug 16 07:26:33 2010 +0000
rpm spec: Use only 3 rpms for GlusterFS
Generates the following 3 rpms:
1. glusterfs-fuse
2. glusterfs-main
3. glusterfs-ibverbs
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1275 (Fix rpm glusterfs spec file for 3.1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1275
commit 52b8c7f18fc4c28aaa4508ee4e0579eaa9dea100
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Aug 16 05:18:19 2010 +0000
volgen: generate listen port in server for portmap mode
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1375 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1375
commit 6bbcbcb1ba195d152c551d93ce850128bc1be02f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Aug 16 03:19:32 2010 +0000
rpc: move handling of fragment headers to socket.
- fragment headers are only specific to tcp and hence should be handled in
transport-socket instead of by rpc layer.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 61951bc2ce88842b6dbc9feae37e86251788b13c
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Aug 16 02:37:34 2010 +0000
mgmt/glusterd: cli: Various fixes for replace brick.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1304 (Free state info for replace brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1304
commit aa2f7631e8ad7b72aee9d0fecadcfe9c5b9effdc
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Aug 16 02:35:40 2010 +0000
cli: Cleanup replace brick operations.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1304 (Free state info for replace brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1304
commit 1c757582634a5af29e614c471b4bde5217b37437
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Aug 16 02:35:00 2010 +0000
mgmt/glusterd: Cleanup replace brick.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1303 (Cleanup replace-brick state info)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1303
commit 0ffdc6a1bfce210ead28c4aa6957cf5b5c1fb79b
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Aug 16 02:34:32 2010 +0000
cli: Cleanup replace-brick cli call.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1303 (Cleanup replace-brick state info)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1303
commit ddfc6fa3fb91d95d5a8e1a018e74845d2aa3cf80
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Aug 16 02:10:15 2010 +0000
glusterd: Fix for a crash during restart
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1369 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1369
commit 4d7735169d64bea016c7785035804ba99a2a5ebe
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Aug 15 13:03:10 2010 +0000
glusterd: Set appropriate directory permissions
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1291 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1291
commit a7c318fd726b48fc2125b47b8b5ad89d63c818f1
Author: Pavan Sondur <pavan@gluster.com>
Date: Sun Aug 15 12:39:05 2010 +0000
cluster/pump: Save path (/) when abort is received in pump.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit 089c3941c83d3d93afdfc3b91b6bc55b1610a6c9
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Aug 14 05:10:49 2010 +0000
'gluster peer *' enhancement
now 'gluster probe' will be 'gluster peer probe' and
'gluster detach' will be 'gluster peer detach'.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1291 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1291
commit e64f4bad65b330f979cadbf694b88858d3f3c4b8
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Aug 14 04:36:47 2010 +0000
new option to volgen '--portmapper-mode'
* without which, it generates volume files in old fashioned way.
* with portmapper mode, no port option is taken, and there will be
one process per one export.
* corresponding changes in 'mgmt/glusterd' is made
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1341 (glusterfs-volgen should behave differently for flag '--internal')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1341
commit 50035ceb744663e177b80ea4ae4b08064921465c
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Aug 14 03:36:29 2010 +0000
volume-id fix in mount.glusterfs
* now user can give numrical volume names if needed.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1364 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1364
commit ead625a97d972defabfe88195036cd755810e492
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Aug 14 04:31:38 2010 +0000
portmapper: minor fixes
* in bind, initialize the array index to port
* in search, check if brickname is NULL
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1363 (crash is pmap_registry_search())
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1363
commit e1311a86b23e7c94778e032c67471dcc6a01309b
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Aug 13 07:10:25 2010 +0000
gluster create volume: cli validation added
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1267 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1267
commit 363dece2cbb23fae53023a67852657159a468075
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Aug 13 07:03:47 2010 +0000
glusterd: Check for DIR before readdir
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1323 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1323
commit 5daefe9b4769f9c1da149656870ba72c09d394fd
Author: Anand Avati <avati@gluster.com>
Date: Fri Aug 13 06:04:35 2010 +0000
portmap: crash fix while getting registry pointer
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1346 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1346
commit 39aed95985987637cf53e09a4f712c706f000b41
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Aug 13 05:58:51 2010 +0000
cli cmd validation
* check buffer/stack overwrite if there is large number of argument to
gluster command
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1265 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1265
commit 685da7f481db3aafdcec09455327f8eea0d8915d
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Aug 13 02:33:37 2010 +0000
if frame is NULL, don't continue to destroy it.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1272 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1272
commit 19eeb9895710d75cdba54f55ece069bf6c6e445e
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Aug 13 01:56:33 2010 +0000
protocol/client: send proper errno when op_ret is -1
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1353 (gnfs crash on nfs3_fill_create3res)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1353
commit 5e72fd8d8408d5846c39e04cb6619d5c35be6e11
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Aug 13 02:08:31 2010 +0000
fixes read data corruption seen by patch b04d963e91f8b3c72343e1043d6ed8c68699c4fe
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1333 ([3.1.0qa4]md5sum mismatch of files on client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1333
commit d025d90b370848ad27623e6a576ba8e02c9ba595
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 12 13:08:38 2010 +0000
fix the 'no logfile set' log during gluster process start.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1348 ('no logfile set' displayed when glusterfs is started)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1348
commit ab5ba59ac43e6e49657879d924975de324e99d04
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Aug 12 12:27:35 2010 +0000
cluster/afr: Remove dead pump code in afr_lookup
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1347 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1347
commit fa847310ffcc643ccb456ca8bb09532981d96e5f
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 12 08:09:43 2010 +0000
fix in cli notify
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1345 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1345
commit d718592563885d5849b0d020b096b04a2f0abd16
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Aug 12 06:19:40 2010 +0000
cluster/afr: Avoid Null de-reference when post parent is NULL
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 857 (Crash in afr_sh_entry_expunge_entry_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=857
commit bb47bd1c4323075075e319d2590bebe03950bdce
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Thu Aug 12 04:12:44 2010 -0700
added glusterd-pmap.h to noinst_HEADERS in Makefile.am
commit 81c841fef2f40fb6fe855a1cce4007c6b0865702
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Thu Aug 12 05:05:03 2010 +0000
protocol/client: query portmap and reconnect on new port
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1314 (portmapper functionality)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1314
commit 42ea025be361933ccae27dfc47955e18e85e5b75
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Thu Aug 12 05:05:02 2010 +0000
rpc-clnt/socket: rpc_clnt_reconfig() API to support overriding of port numbers
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1314 (portmapper functionality)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1314
commit c1084b45fef86d31f7aa9b8f447a33e43cc6cd51
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Thu Aug 12 05:05:01 2010 +0000
portmap functionality in glusterd
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1314 (portmapper functionality)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1314
commit 738db5d7d096f6e0f0e065c58ccf7f785b923412
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Aug 12 04:43:20 2010 +0000
minor assignement errors reported by clang fixed
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1117 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1117
commit 87e9dd38be3e4596a1000fc9d367fc8fa7bdf945
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 12 03:58:20 2010 +0000
argument sanity checks added in inode.c
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1311 (crash during nfs alpha test)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1311
commit 7411f31e9d0586bebe223572a818aa34dd4c6084
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 12 04:49:50 2010 +0000
client changes for 'gluster volume migration' to work
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1303 (Cleanup replace-brick state info)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1303
commit 41770360c3ba3483449adc270c1b10616f688f6d
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Aug 12 04:49:15 2010 +0000
cluster/pump: Dynamically control sink connect and disconnect.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1303 (Cleanup replace-brick state info)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1303
commit c15e351b45d8b59cdda788cbeb03db14de3bb9a9
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Aug 12 03:26:39 2010 +0000
glusterd: Fixes for detach
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1215 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1215
commit 363f419294c0034e02ff65779c58e8bb8e509bdb
Author: Kaushik BV <kaushikbv@gluster.com>
Date: Thu Aug 12 01:57:04 2010 +0000
log added in case of invalid options provided for the io-threads volume
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1033 (io-threads doesn't log its options)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1033
commit cb4baf27e5711357d779afa6a426f0ffb6eb4f4a
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 12 01:54:38 2010 +0000
logging enhancements
* per translator loglevel introduced, if set, it will override process
wide log level.
* with extended attribute 'trusted.glusterfs.<xlator-name>.set-log-level'
with the value being '<LOGLEVEL>', one can change log level of particular
translator.
* with extended attribute 'trusted.glusterfs.syslog' with the value
'<BOOLEAN>', one can enable disable syslog for gluster
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 601 (Enable changing 'log-level' of GlusterFS process at runtime)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=601
commit 242e12fa554ebb603910759779187aa5bb417343
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 12 01:54:10 2010 +0000
fixed some backward compatibility issues
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit aa78fe8fd8b214723793401531fee5b9b81ae4ba
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Aug 12 01:47:38 2010 +0000
rpc: Cleanup reconnect timer while destroying rpc_clnt
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1334 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1334
commit bf141fcce10f0949450a9edcc7f1c4f1f1572dde
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Aug 11 05:58:31 2010 +0000
rpc fixes
* set THIS properly so memory accounting works fine.
* also check for few pointers before dereferencing them.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1317 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1317
commit 9259ca4ae1a21e84305e0be8bc927dbb5fda8ecc
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Aug 11 07:45:29 2010 +0000
cli: Use appropriate conversion for deprobe resp
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1215 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1215
commit 8d431225f0275488850b8150921e7b7df8badad1
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Aug 11 00:33:03 2010 +0000
cli: Do not await connection for miscellaneous cmds
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1262 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1262
commit db047fcf41b7760b3f4f960d7a2bd7e94c38135f
Author: Sachidananda <sac@gluster.com>
Date: Tue Aug 10 11:16:59 2010 +0000
Cleanup dead variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1085 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1085
commit 9ff4b965bbee30267eadb89a21c015ac7640e57a
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Aug 10 08:18:47 2010 +0000
glusterd: Remove dependency on existence of peers directory
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1310 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1310
commit 08fceffbba2958a657d9b43e9295c90c08b1e377
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Aug 10 05:55:49 2010 +0000
glusterd: Remove incorrect check for open fd during store ops.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1321 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1321
commit 0370a976dc09f4ad13720fc7f823f0ae63cfeae3
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Aug 10 01:57:45 2010 +0000
cli: Introduce timeouts for command response and connection
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1262 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1262
commit 08e0bb293800ef91edc2ae9cbc6649af7cbe70b6
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Aug 9 07:42:02 2010 +0000
glusterd: restore peer information upon restart
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1310 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1310
commit 3bbfd87530e922a83c1b858d5e40d415f2ba7f73
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Aug 9 05:43:01 2010 +0000
fuse resolve related changes
Now fuse is fully complaint with DVM, as even if there is a fop
request on inode belonging to old graph, it will be resolved
corresponding to new graph and operations will be performed wrt.
new graph, which makes DVM truely spontaneous.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1240 (DVM: after graph change, inodes should resolve to new inode-table)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1240
commit 103b02f1e7ab4eb77b00469cc9886d489c867048
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Aug 9 05:38:46 2010 +0000
'gluster volume rebalance' related fixes
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1307 (gluster volume defrag <VOLNAME> status)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1307
commit 674d6c092e6dd96e706aca5cfefdd3fcc6ab813f
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Tue Aug 10 03:28:50 2010 -0700
fix build of nfs (cleanup of configure.ac)
commit d2394181d582f3430ab086ae56cdf7bf134d079b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 10 02:42:01 2010 +0000
core,glusterd: Solaris getxattr build fix
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1178 (Gluster mainline build fails on Solaris)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1178
commit 2fddc7359e81e5504fbfe63c25c6df8605e4e126
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 10 02:42:00 2010 +0000
build: ucontext on Darwin needs _XOPEN_SOURCE
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 55cebcc701cfb049537a8dd2d605f0a25bc32d6d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 10 02:41:59 2010 +0000
build: Solaris sigwait needs _POSIX_PTHREAD_SEMANTICS
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1178 (Gluster mainline build fails on Solaris)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1178
commit 918e01539c37ba2d225d6bb4cfaba28ee61a3b33
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 10 02:41:58 2010 +0000
glusterd: Solaris build fixes
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1178 (Gluster mainline build fails on Solaris)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1178
commit 801b446c619612fdbea7b3c3c136456af119f4d5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 10 02:41:57 2010 +0000
rpc-lib: Solaris build fixes
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1178 (Gluster mainline build fails on Solaris)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1178
commit c3d0817440cce0a38609c8cbe0fd486ba1043bc6
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 10 02:41:56 2010 +0000
nfs/rpc: Solaris build fixes
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1178 (Gluster mainline build fails on Solaris)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1178
commit 6d12ba0067617632250fbce352cb29c8e0bf35bb
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 10 02:41:55 2010 +0000
nfs: Do not build nfs/rpc as shared library
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1274 (nfs fails to start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1274
commit 4ea749941cce87299ba5d97aad94138a065f175d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Aug 10 02:41:54 2010 +0000
nfs, nfs/rpc: Rename functions to prevent gfrpcsvc conflict
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1274 (nfs fails to start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1274
commit 86d94791c00811d79140440c27eb2c62f6f2b818
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Aug 6 07:49:36 2010 +0000
glusterd: Set right return value during delete volume
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1191 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1191
commit af0c93b0cf86c9d79ba684d5df673e87feea2fde
Author: Pavan Sondur <pavan@gluster.com>
Date: Fri Aug 6 05:38:41 2010 +0000
fix rpm spec file to build rpms for 3.1
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1251 (ping_pong tests make client go segfault after bailout)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1251
commit 6498ba2c1ae1152f7483e398d3dfd62c7fc81a16
Author: Pavan Sondur <pavan@gluster.com>
Date: Fri Aug 6 05:31:45 2010 +0000
add pump xlator and changes for replace-brick
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
commit bcebefa5cfcb34b4df2d6e98a34593d99d8f9a45
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Aug 6 05:25:16 2010 +0000
v2[PATCH BUG:1286] glusterd: Regain volume state upon re-start
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1286 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1286
commit 7e431a1df195f8d711eb9f72ca3cce5c256f4e44
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Aug 4 22:24:51 2010 +0000
performance/io-cache: Disable caching when files are opened with GF_OPEN_NOWB
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1168 (Disable caching when files are opened with GF_OPEN_NOWB)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1168
commit b5475cd1e29a9b4755f71546d1ed2b024f5f5a7e
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 5 04:00:59 2010 +0000
mem pool for call_stub_t
Ran posix compliance test and sanity test
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit 29036fee657ac17c9f5ac4af1ff1c324bf263451
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 5 04:00:14 2010 +0000
mem pool for fd_t
Ran posix compliance test and sanity test
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit 6a14a698baab08c0386eb627a8c5ecfe4e99b242
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 5 03:59:38 2010 +0000
Implement mem pool for inode dentry
Ran posix compliance test and sanity test
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit 3c9e3be98cefaba3e09e2fff3d3411c52de7d08d
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 5 03:58:37 2010 +0000
Implement mem pool for frame and stack
Ran posix compliance test and sanity test
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit 986ee4271437ed41602dd95d25f15332ef896768
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 5 01:58:46 2010 +0000
Fix for seg fault in dict_unserialize if undersized buffers are passed
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1031 (dict_unserialize crash if undersized buffers passed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1031
commit 314576eb06f9814e4242accce811592d9bc3544d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Aug 4 04:45:25 2010 +0000
rpc: changes to glusterfs programs that can take an optional payload argument.
- The existing interface required the transport to separate the procedure
header and procedure payload into two different buffers. Making this
separation can prove cumbersome for transports like rdma wherein the header
and payload can be received in a single buffer (For eg., header and payload
of write fop sent as inline msg using rdma-send). This patch delegates the
responsiblity of separating out header and payload to programs.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 2e1d6816c403a9c8550b17adc3b72d4802bad860
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Aug 4 05:27:55 2010 +0000
remove same process transport shortcutting mechanism in rpc
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1223 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1223
commit c75dafa2e1f1a06548b80e1997a75a9c1f59f266
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Aug 4 05:47:31 2010 +0000
cli: fix a stack buffer overflow error
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1279 (Buffer overflow build error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1279
commit 0fde990785d2a881cb08a1ad5c2ddfe2f3db4f8d
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 5 01:53:37 2010 +0000
if rpc->status is not SUCCESS, don't decode the msg
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1753 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1753
commit 0d797868216e9232417bffb104e7bfe76ddc5301
Author: shishir gowda <shishirng@gluster.com>
Date: Thu Aug 5 04:44:20 2010 +0000
Fix cli volume defrag command hang
gluster volume defrag <volname> hang is being fixed. Also, if a invalid
volname was specified, it used to create mount point and call gluster
client mount on it. This is also being fixed
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1247 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1247
commit 4bd33f34aaef165dab00aebd743d561c084ff06d
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 5 10:15:25 2010 +0000
fix memory-leak in case of disconnections in RPC server
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1227 (memory leak in rpcsvc_conn_alloc)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1227
commit ac12888239a2da9a82a11ae8298f8e78bf6a3209
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 3 08:06:43 2010 +0000
make some not implemented commands return success
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1264 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1264
commit 5700887ca27c200b7e56442f2d1f558a9583b08f
Author: Sachidananda <sac@gluster.com>
Date: Sat Jul 31 11:15:41 2010 +0000
Remove dead variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1065 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1065
commit eeb0fbcd843adf486188a21261cd6ee7abd2b67e
Author: Sachidananda <sac@gluster.com>
Date: Sat Jul 31 09:11:21 2010 +0000
Remove dead variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1067 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1067
commit d4a428f9e131e887f00b73ba5b7a1e1654ae7fe3
Author: Sachidananda <sac@gluster.com>
Date: Sat Jul 31 09:03:49 2010 +0000
Remove dead variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1066 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1066
commit 537ffd820c02d2a94d3f861a8c65281480399872
Author: Sachidananda <sac@gluster.com>
Date: Sat Jul 31 08:56:10 2010 +0000
Remove dead variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1068 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1068
commit 4373462702fce838ee15b97b7cba337383d83880
Author: Sachidananda <sac@gluster.com>
Date: Sat Jul 31 08:43:51 2010 +0000
Remove dead variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1070 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1070
commit a3a5f6440632b6d74c021c316098a71c5b47828c
Author: Sachidananda <sac@gluster.com>
Date: Fri Jul 30 23:28:05 2010 +0000
Remove dead variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1106 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1106
commit 62fe4e4382c950e3f05cbba2286ad24135e662de
Author: Sachidananda <sac@gluster.com>
Date: Fri Jul 30 23:25:06 2010 +0000
Remove unused variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1090 (clang errors in the file features/locks/posix.c)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1090
commit 82f2d0e28c7847c22be847430a17bd499b8f4c71
Author: Sachidananda <sac@gluster.com>
Date: Fri Jul 30 22:31:20 2010 +0000
Remove unused variables.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1107 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1107
commit 18fa5187418942cbdf4eb9728a6884bb2ca0980b
Author: Sachidananda <sac@gluster.com>
Date: Fri Jul 30 22:07:50 2010 +0000
Remove unused variables
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1105 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1105
commit ffbd090e98990737d525e877d5c39bdbdc9d7b19
Author: Sachidananda <sac@gluster.com>
Date: Fri Jul 30 10:05:14 2010 +0000
Remove dead variables reported by clang.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1108 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1108
commit 353e62b51efd06e361cb7cffe8e2e16ee20b2970
Author: Sachidananda <sac@gluster.com>
Date: Fri Jul 30 09:22:51 2010 +0000
Remove dead variables reported by clang.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1110 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1110
commit bdf69ad1cdb17ee7f516a268cd081b386ef1ada3
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Jul 29 03:09:38 2010 +0000
libglusterfs: Prevent multiple timer threads from being spawned
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1246 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1246
commit 2e83218c37452e28f5221ca5fb3015b546002185
Author: Pavan Sondur <pavan@gluster.com>
Date: Sun Jul 25 18:13:08 2010 +0000
syncop: initial implementation
Resending Avati's syncop patch with a few bug fixes.
(please do not skip the IMPORTANT NOTES section)
* Framework for SYNChronous OPerations
--------------------------------------
This patch provides a framework for performing synchronous operations
over the underlying actual asynchronous GlusterFS FOPS.
* Use cases
-----------
1. Convenient implementation of crawler thread in replicate/pump
2. Convenient implementation of high level control flow in DVM
* Background
------------
All (almost) threads in GlusterFS are hosts for executing aysnchronous
file operations using the STACK_WIND and STACK_UNWIND primitives - as calls
and callbacks.
While the STACK_WIND and STACK_UNWIND macros provide high control for
efficiently implementing file operations in a clustered/parallel environment,
there are tasks where the nature of the task itself is sequential and
the execution performance of the task is not critical. In these cases the
complexity to implement the task with STACK_WIND/STACK_UNWIND based operations
as calls and callbacks is an overkill.
* Introduction
---------------
syncop: are wrappers around the STACK_WIND/STACK_UNWIND based asynchronous fops.
synctask: a sequential task (a C function) which uses syncops.
syncenv: an environement to schedule and execute synctasks.
The synchronicity is implemented via ucontext.h based continuations.
Execution of synchronous tasks is possible only in a synchronous environment.
Therefore, the first step is to create such an environment -
struct syncenv *env = syncenv_new (0);
This creates a synchronous environment, with a thread (scheduler) to host the
synchronous tasks. Creation of this environment is generally to be done at the
time of process initialization. Next is to spawn a synchronous task in this
environment -
int slow_self_heal (void *data);
int completion_func (int ret, void *data);
ret = synctask_new (env, slow_self_heal, completion_func, data);
Here slow_self_heal is a task which is implemented using synchronous operations.
When slow_self_heal() completes, completion_func() is called with the first
parameter as the return value of slow_self_heal(). Both these functions get
the @data argument as the same value passed to synctask_new().
int
slow_self_heal (void *data)
{
xlator_t *child = FIRST_CHILD (THIS);
fd_t *dir = NULL;
...
dir = syncop_opendir (child, loc);
entry = syncop_readdir (dir);
...
return ret;
}
* IMPORTANT NOTES
-----------------
- calling syncops in code executing outside the synchronous environment will
very likely cause and undesired blocking of the executing thread leading to
deadlocks!!
The synchronous environment is a special thread where such sleeps are safe,
and these sleeps result in the scheduler to 'swap in' other synctasks.
- syncops can put the task to sleep. DO NOT issue syncops while holding mutexes.
This is very similar to the blunder of holding a mutex and doing STACK_WIND.
- It works best when synctasks use only syncops. If a call_frame is created and
STACK_WIND'ed, the callback would very likely happen in a thread outside the
synchronous enviroment, at an undefined time - as expected. So note that the
synchronous environment does not tame the notorious behaviour of STACK_WIND.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 672b2fa1babaa3d4c470fe1fc374514428fda109
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Jul 29 00:46:08 2010 +0000
fixes for spurious entry self-heal in afr
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 974 (Spurious self-heal?)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=974
commit ae7990ace50e48989010132a40bccfb37a15bab2
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Jul 28 12:17:47 2010 +0000
glusterd: Bug fixes in add/remove brick.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1239 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1239
commit e4233eb2723a30b74ee3a60fd02ae68e2b2d74ab
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Jul 28 06:23:31 2010 +0000
changes to rpc
- use mem-pool for requests and saved_frames.
- preserve the rpc_req structure till rpc invokes program's reply.
This will enable us to store transport specific data that has to
last till reply has come (eg., memory regions of chunk lists in
case of rdma).
- change signature of rpc_clnt_submit to accept rsphdr_vector and
rsppayload_vector. The buffers pointed by these vectors will be
from iobufs and these iobufs are added to an iobref which should
also be passed as an arguement to rpc_clnt_submit.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 059514425d33ba3a207a1928d017fbe5a0dbbc29
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Jul 28 05:03:43 2010 +0000
glusterd: Fix a crash when get volume fails
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1239 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1239
commit 8c103fa11d223e9399e2a004545ea7131cdccf59
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 28 04:23:57 2010 +0000
fix all clang errors in xlator/protocol
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1092 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1092
commit 2200997571472b0a9f2cb9ba7f7143d3e25fc641
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 28 03:31:10 2010 +0000
removed last few remaining 'ERR_ABORT's from codebase
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 966 (NULL check for avoiding NULL dereferencing of pointers..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=966
commit afe46741ca24c7781880bc80e8838eb3979e92b2
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 27 11:13:32 2010 +0000
some check added to the variables after GF_CALLOC
handles some NULL dereference problems
(reported by clang when ran with code where '#define GF_CALLOC NULL').
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 966 (NULL check for avoiding NULL dereferencing of pointers..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=966
commit 20631883019640dca14ed875e91e60b6512fd665
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 27 11:12:51 2010 +0000
fix all the clang errors in 'rpc/*'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1133 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1133
commit 1215802a23f898d003cc66896fcbf9820957e86c
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Jul 28 03:51:18 2010 +0000
nfs3: NULL fdentry check before removing from fdcache
Suppose a file name 1 is created and some data is written to it. After this
another 512 files are newly created and written to. When the the 513th file is
created and an fd_t opened for it, it results in 1's fd_t being replaced in the
fd-lru with 513th file's fd_t. This is the correct behaviour resulting in all
refs getting unref from the fd_t of 1 and the fd and all related state being
freed.
But, in some workloads, some refs are still pending even after the fd_t is
removed from LRU, resulting in the fd still being bound to the inode. In
nfs3svc_remove_cbk, while removing the inode state, we also ensure that any
fd_ts in the cache for this inode are also removed. While removing the fd_t,
this situation where the fd_t has replaced with another, even while a ref
remains on the fd_t, results in a crash in the fdcache_remove path in
nfs3svc_remove_cbk. This happens because the fd_ctx_get results in a NULL value
because the ctx was already deleted when this fd_t was removed from fd-lru
earlier. This patch fixes the crash by introducing a NULL check.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 885 ([NFS Xlator] Crash in nfs3_fdcache_update)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=885
commit 80f1125389cd12ff7f94fedaba8c3912b43a4d26
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Jul 27 06:16:52 2010 +0000
access-control: Fix O_CREATE determination check
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1167 (gnfs crash with fio)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1167
commit 7cd18770778f3daf4bf88b0fb5d692da453a7cd7
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Jul 27 06:16:53 2010 +0000
replicate: Set setxattr wait-count to child-count to avoid race
A race is seen during a compilebench load against NFS where a NFSv3 MKDIR is
immediately followed by a LOOKUP on the new directory. By the time this lookup
comes in, the setxattr issued by distribute for the mkdir has not returned yet
from all the replicas. Since replicate returns a reply for setxattr after
receiving reply only from one subvol, the MKDIR is unwound from distribute.
When the LOOKUP is received at distribute, the setxattr has still not completed
at the second replica, whereas that is where the lookup is sent by replicate.
Finding that the xattr is missing from the dir, distribute returns ESTALE to
NFS, which return NFS3ERR_STALE to nfs client.
This patch changes replicate setxattr behaviour by forcing replicate to wait for all
children rather than one to call back before unwinding the stack.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 937 (compilebench fails on NFS+dist+repl+all perf xlators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=937
commit e67121de9e2da1fd0538371286500daa7fc4aa75
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Jul 27 06:16:51 2010 +0000
nfs3: Error returns must check for <0, not == -1
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 854 (nfs server didn't start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=854
commit f0b900881fa2c6f0f75a0ad002c75b5ba42b17d6
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Jul 27 06:16:50 2010 +0000
nfs3: Return ESTALE when fh resolver exhausts dirents
During hard fh resolution, if a directory traversal goes right
through to end-of-dir without finding a hash match, we need to return
an ESTALE, not ENOENT.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 854 (nfs server didn't start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=854
commit 840b62f4600cf22c9e8763ffa4a6bdd5868f59dd
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Jul 27 06:16:49 2010 +0000
nfs3: Stop ESTALE from falling into SERVERFAULT
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 854 (nfs server didn't start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=854
commit c7b4ab3be546906f39710933619eba101503d3ca
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Jul 28 01:57:44 2010 +0000
cli: Init conditional mutex at the right place
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1205 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1205
commit bfe2a1dbfccc838f856165a4379bee60471d12c3
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Jul 27 14:49:07 2010 +0000
DVM: Changes in CLI output
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1220 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1220
commit b2e74031207f034ef0963fcb034d14487ab7b8a9
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Jul 27 08:48:49 2010 +0000
DVM: Changes for remove brick
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1220 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1220
commit 439d43f5edd9dfac5a044ab4227d5e5d657b090d
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Tue Jul 27 03:13:55 2010 +0000
cluster/afr: Logging improvement for self-heal
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1037 (selfheal information in normal logging mode)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1037
commit da0ec022ab598fb2d08ac79b1666d22bf86a0b28
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Jul 27 02:06:45 2010 +0000
fix volume creation errors in replicate and stripe
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1228 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1228
commit 239720d7417a5b83506b8006cc81def808179578
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Jul 27 01:54:39 2010 +0000
Cancel ping timer if socket or ib error
If the there is an socket or ib error, fail the ping request
to prevent retries. Which would cause active connections
to be disconnected
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 907 (cancel ping timer in case of socket fd error or iberror)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=907
commit 24e807bb415845dfbefa2efbd4ae77ec56becd34
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Jul 26 12:10:08 2010 +0000
cli: Changes to provide proper exit status for gluster commandline
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1205 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1205
commit d55f11b6030a664c43a34513808aa3a97c1ffa55
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Jul 26 07:07:24 2010 +0000
cli: Fixes related to get brick-replace to work.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1187 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1187
commit 217691b241fd224a2295a253b647b343053f2606
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jul 26 06:13:57 2010 +0000
dht enhancements
* create(filename@<distribute-volume-name>-<subvol-name>), will
create the file in corresponding subvol of dht.
* same for unlink()
same logic can be extended to other fops if there is a need
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1200 (enhance distribute with hooks so lot of debugging can be done online)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1200
commit 7091a720c2798380d1b62f8ff23688a38b0746f1
Author: Anush Shetty <anush@gluster.com>
Date: Mon Jul 26 05:07:18 2010 +0000
Set fdctx only if op_ret is not -1
Signed-off-by: Anush Shetty <anush@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1218 (Crash in client_fdctx_destroy)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1218
commit ec5fe0296acd070ae9bcb6c7d880269ac36a588a
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Jul 26 02:25:09 2010 +0000
Changes in pidfile format for start and stop volumes
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1217 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1217
commit 53e0168eb8ea4d641bafb0d48ade792886a0f72e
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Fri Jul 23 06:51:05 2010 +0000
cluster/afr: ignore errno from offline nodes during self-heal
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 904 (Error while self-healing directories)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=904
commit db99ab2e510360321f2ad49f0d8e716e58a163df
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Jul 25 00:38:01 2010 +0000
DVM: bug fixes in cli and glusterd for probe, start volume
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1187 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1187
commit 0702e1b1f14c58076797c6655daff2a814d036d9
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 23 03:36:01 2010 +0000
glusterfs-volgen changed to create one volume per brick
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1208 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1208
commit 3ac810e61bac85a3439960f113049356cd6c0051
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Thu Jul 22 05:51:16 2010 +0000
custer/afr added self-heal logging in normal mode
Changes are made such that self heal
messages are printed (filename, type of selfheal such as data/meatadata/entry
selfheal and the cause which triggered the selfheal) in the log file
when run in normal mode.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1037 (selfheal information in normal logging mode)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1037
commit cc0ea500de7f41fb88f62a20d188645ff60b657c
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 23 03:13:48 2010 +0000
client protocol should send the fops only after handshake
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1195 (crash in protocol server due to unauthenticated fop request..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1195
commit 219e74fefd1711fafaca404c596e04f66b045ddd
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 23 03:13:19 2010 +0000
handle some NULL dereference in server protocol
which can happen due to un authenticated clients sending requests.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1195 (crash in protocol server due to unauthenticated fop request..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1195
commit 21f255b52dbdc699e558c874b8b8108478bdd851
Author: Anand Avati <avati@gluster.com>
Date: Fri Jul 23 01:02:01 2010 +0000
glusterfsd: fix bug in GETSPEC which would result in loading of -f volfile
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 84084ec099e79af5327095a8fc2dfa4cbe6fb68d
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Jul 22 04:17:35 2010 +0000
Changes for Dynamic Volume Management
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1196 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1196
commit 3cf0b78f7ae68e89a68fd5074c3692eda01d9338
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Jul 22 01:25:44 2010 +0000
free sh_priv->loops[i] in afr-self-heal-algorithm.c to avoid memory leak
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 992 (memory leak in afr_sh_algo_diff)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=992
commit 860b9508c6f79e74ca42b60c23b856a47fd74bc5
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Jul 21 17:17:09 2010 +0000
glusterfsd: ban specifying fuse in volfile
"fuse-in-volfile" was defunct anyway -- it resulted in a broken mount which
had all calls hang on it.
So the challenge was either to fix it or remove it. It got thumbs down.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit e5965c2cd2936c2b1fb969cc6e9bd1778d721b67
Author: Anand Avati <avati@gluster.com>
Date: Wed Jul 21 07:52:17 2010 +0000
glusterfsd: move mgmt_init() to happen post deamonize()
else results in loss of timer thread
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 6498fc01a90ca815fa964b1d21e25feb7f1d0c39
Author: Anand Avati <avati@gluster.com>
Date: Wed Jul 21 04:23:15 2010 +0000
cli: fix consistent behaviour with newlines in cli_out()
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit d762598ce482e4149e49e6b96f2c2cc0ae736337
Author: Anand Avati <avati@gluster.com>
Date: Wed Jul 21 04:00:27 2010 +0000
cli: fix 'unrecognized command' error on empty command
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit ac3586aef2ed7591275434a3c5c1e2b76ef9b427
Author: Anand Avati <avati@gluster.com>
Date: Wed Jul 21 03:54:16 2010 +0000
glusterd: implement GETSPEC
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit fe2d62ab0be274fe14f03f6e8d12ce74ba3c132d
Author: Anand Avati <avati@gluster.com>
Date: Wed Jul 21 03:53:53 2010 +0000
mount/fuse: disable fuse support from volfile
glusterfsd: implement GETSPEC functionality to fetch volfiles from server
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 5fe5e5e88e8d5a98034daab7488b89ce7776f2e7
Author: Anand Avati <avati@gluster.com>
Date: Wed Jul 21 02:00:33 2010 +0000
glusterfsd: make SIGINT gdb friendly
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 82a4010acf363eccb1461fc1efedf63e2d277ffa
Author: Sachidananda <sac@gluster.com>
Date: Mon Jul 19 06:17:58 2010 +0000
Dead assignment cleanup.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1138 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1138
commit 10a8439e6a91bd9f9647ac2b0972055643f8d561
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 20 02:40:58 2010 +0000
add port as an optional argument to 'probe' command
* there will be just 'one' glusterd per machine, but in case if its
run on different port, then this option is useful to probe.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1074 (port related issues in 'gluster probe' command)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1074
commit 510d22fd1e3848befb5baaa7c3c1e1b7b866d8fb
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 20 01:23:17 2010 +0000
'glusterd' command
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit f3917ce4a80f04ecaf965b97a71d84f7b1cf0bd5
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 20 00:23:23 2010 +0000
fix mount.gluster so there is no fixed default port
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1171 (mount.glusterfs has old/stale port values as default..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1171
commit 59cfe0169e4e101cbb67d00957d40dd9eb3d786c
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Mon Jul 19 07:37:06 2010 +0000
rpc/rpc-lib added saved frame's call timestamp
it will be good to have the time stamp at which the calls were sent to the
server in the gf_log of saved_frames_unwind
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 908 (saved_frames_unwind() : print time stamp of when call was sent to server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=908
commit 61f0697314f0a56dc49c3a30350619e7bff4fe7b
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Jul 19 07:43:08 2010 +0000
encryption/ features/quota change STACK_UNWIND to STACK_UNWIND_STRICT
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 0c745d3707c46c8b1c156ba5e45be9086f7a9ed6
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 20 00:23:04 2010 +0000
'gluster volume defrag' related bug fixes
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1073 ('gluster defrag <VOLNAME>' fails in mainline)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1073
commit db887fc068f33c9846a798e128961824cf6718f9
Author: Sachidananda <sac@gluster.com>
Date: Tue Jul 20 05:15:56 2010 +0000
Delete dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1113 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1113
commit 2165094ba46512c14f133f487a4780872f7f2487
Author: Sachidananda <sac@gluster.com>
Date: Tue Jul 20 05:03:59 2010 +0000
Remove dead assignment.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1131 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1131
commit a66cbb5c6cb81d7f44aa36c1063a6cd695000c28
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Jul 20 04:25:49 2010 +0000
performance/symlink-cache convert STACK_UNWIND to STACK_UNWIND_STRICT
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 6f8f6eee0b1525ff2aa8bcbd94b9fd21ffc4daf7
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Jul 20 04:25:17 2010 +0000
performance/stat-prefetch convert STACK_UNWIND TO STACK_UNWIND_STRICT
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 70b78da393728c2b4a793b3298a20614e871c9a7
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Jul 20 04:24:40 2010 +0000
features/locks convert STACK_UNWIND to STACK_UNWIND_STRICT
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 41f9471f7902dd6ebfba48cd6f4af9e168026e23
Author: shishir gowda <shishirng@gluster.com>
Date: Tue Jul 20 04:24:08 2010 +0000
features/trash convert STACK_UNWIND TO STACK_UNWIND STRICT
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 0e9fda1b1d2a9b2cb241a6e175938a433edc7c3e
Author: shishir gowda <shishirng@gluster.com>
Date: Mon Jul 19 06:15:34 2010 +0000
debug/* Change STACK_UNWIND TO STACK_UNWIND_STRICT
Also fixed log msg typo found in bug 1031
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 756b2ee1aff86c8163bf6728e406233b2a018697
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jul 19 06:10:34 2010 +0000
dht: set 'lookup-unhashed' to ON by default (instead of 'auto').
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 826 (distribute option lookup-unhashed should be on by default)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=826
commit ff41f7081a8dec221db30fbc6c6539eaa7ac6bc8
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jul 19 06:09:57 2010 +0000
volgen now takes 'num-replica' and 'num-stripe' options
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1155 (currently volgen doesn't take num-replica and num-stripe options)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1155
commit d0d5636d82194453cfd1a19d8df3ed7ca64ea5bb
Author: Sachidananda <sac@gluster.com>
Date: Mon Jul 19 06:08:29 2010 +0000
Remove dead assignments.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1140 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1140
commit 8e25d87f61d386af9eda74fe9f02849f62a8ee66
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Jul 19 05:54:25 2010 +0000
Changes for volume commands
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1161 (gluster volume start command segfaults glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1161
commit 4393c2a51dc5da27459df50d7474e70f36edf203
Author: Sachidananda <sac@gluster.com>
Date: Mon Jul 19 05:51:46 2010 +0000
Dead variables cleanup.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1140 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1140
commit 294e902fa32d0b8780ecc0648421f0210e8d1e42
Author: Sachidananda <sac@gluster.com>
Date: Mon Jul 19 05:12:53 2010 +0000
Remove dead assignment reported by clang.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1130 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1130
commit 0bf0daab355e5d48d9307a343e38f0dd97868c6d
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Jul 19 03:25:31 2010 +0000
fuse: fix clang spotted C abuses
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1120 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1120
commit 15e8dee146f0d633813ac24adb8e3b7274b21649
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Jul 19 00:33:22 2010 +0000
fix the errors reported by clang in io-stats xlator
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1132 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1132
commit 3c72522ddb3d6d50b9376cff0146d91ae0a384e0
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Jul 16 08:54:15 2010 +0000
fix the clang errors reported in trace.c
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1072 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1072
commit 201c8368dcc25498ad570ddbd9f6385089d41338
Author: shishir gowda <shishirng@gluster.com>
Date: Fri Jul 16 08:37:29 2010 +0000
return ENOENT instead of ESTALE for links in client for stripe
Instead of returning a ESTALE for links and symlink return
a ENOENT, as they only exist on the FIRSTCHILD, and any
lookup fails in the other bricks.
Signed-off-by: shishir gowda <shishirng@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1152 (ln on symlink returns NFS STALE error even on success)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1152
commit edd885f4a1ed097877f5aae067692a121d98d5fc
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Fri Jul 16 00:23:31 2010 +0000
dump total cache used in quickread in the statedump information
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 79eefe2edb2dfd9bde8964146e0e2eb781c7b3e5
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Jul 15 06:05:52 2010 +0000
Fix compilation issues when uuid/uuid.h is not present
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 426300b1967cd75c41ba7a67ce903844bd4d3759
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Thu Jul 15 03:50:12 2010 -0700
Revert "dht: perform revalidate on one subvolume"
This reverts commit 97e060d04b6b86225264644ff8fef0459577a031.
commit 2c73bf12ca02fc071d15e22838933744e95cae3a
Author: Anand Avati <avati@gluster.com>
Date: Wed Jul 14 16:26:17 2010 +0000
protocol/lib: rename files to standardized names and places
- move xlators/protocol/lib/* to rpc/xdr/
- rename CLI and glusterd XDR filenames
- remove xlators/protocol/lib (libgfproto1.so)
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit bb96d260d058c7a12d6189957d8fd82bd05022c8
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 14 14:27:54 2010 +0000
remove dead assignments in stripe.c
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1071 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1071
commit 20c04af6ac55d8c9f719594bc8da331ae31940bb
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 14 13:58:20 2010 +0000
proper way to do defrag of a mountpoint
Usage: "glusterfs-defrag <MOUNTPOINT>"
there are new features added to distribute with this patch:
* bash# getfattr -n trusted.distribute.linkinfo <file>
Gives output in the format "<hostname>:<directory>", if there is a
linkfile present, where hostname is server, directory is backend
directory where the actual linkfile is present.
* bash# getfattr -n trusted.glusterfs.pathinfo <path>
Gives layout information if directory, and info about actual
location of file in backend servers, in the form of
'hostname:directory'. (TODO: should extend it to all xlators)
* bash# getfattr -n trusted.distribute.fix.layout <path>
scales out the directory layout in distribute, so when new
servers are added, layouts are fixed to include them.
* removed 'scale-n-defrag.sh' as its no more required.
* changed 'defrag.sh' to have a feature to specify target bricks,
so defrag happens to only those nodes. moved the file to
'glusterfs-defrag', which now gets installed to '${prefix}/bin'
* storage/posix:
takes new option 'hostname' so it can resolve to same hostname
given during 'gluster volume create'.
with 'trusted.glusterfs.pathinfo' posix returns the value in
'hostname:real_path' format.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1073 ('gluster defrag <VOLNAME>' fails in mainline)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1073
commit 88aeefddb6616e77845b4eb4998d419d0f055b77
Author: Pranith Kumar K <pranithk@gluster.com>
Date: Wed Jul 14 07:11:28 2010 +0000
v2 [PATCH BUG:1050] protocol/server Convert-OS-specific-lock-value-to-Glusterfs-lock
server/protocol's getlk implementation needs to convert the flock on the system
to glfs own flock before returning it to the client to prevent
misinterpretation of the flock structure.
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1050 (fcntl F_GETLK lock calls do not return correct flock on non-linux systems)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1050
commit 0088c02f5537ca9b13cbe4791a66e47c2b5095bb
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Jul 14 00:20:28 2010 +0000
Fixes a crash seen in create volume
Also includes some re-factoring changes.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1063 (gluster volume create command segfaults)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1063
commit 5b0c79ce7c292a690ab98936990c5fdb2bfb9963
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Mon Jul 12 09:03:04 2010 +0000
typo error: should check for less than instead of greater than
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit dd1db835025ba7c77882d97773f7cb2adb71b189
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Jul 12 08:19:44 2010 +0000
Changes in CLI and glusterd
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit c3fbe11e9ab98c03b2143384322fe1d765edbace
Author: Anand Avati <avati@gluster.com>
Date: Mon Jul 12 08:13:08 2010 +0000
cli: move readline to separate thread
move readline handling to a synchronous input thread to avoid deadlocks
with poll loop
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 913681dcabfc67d22f4580a3ad4051afc2145603
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 9 03:14:13 2010 +0000
provide a port option for gluster command line
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 030caf477c5bcdc2ec33b4e5f8406ac3c56aac13
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sun Jul 11 06:33:17 2010 +0000
dump total files cached in quick-read in statedump information
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059
commit 8b96c033164506bd9645d57b97cfb52776be75d5
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jul 8 08:16:13 2010 +0000
gluster-CLI-and-mgmt-glusterd-added-to-codebase
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 79991242ec4f37f0befbbea3543a7a745c5935c9
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jul 8 05:47:52 2010 +0000
fix up OS X after dynamic volume changes
Note that contrib is not needed to be in toplevel Makefile as
its not a separate target, rather stuff is "pulled in" from there.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit caa45fd3340790d1b683568c077f79ae0e476635
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jul 8 05:46:50 2010 +0000
minor option handling refactorizations
- clean up ZR_* internal option defines
- make argument order of glusterfs_graph_activate() aligned with
other graph ops
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit cc12cae31408321f4bd1232d1a36b029b5071311
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jul 8 05:45:58 2010 +0000
fix fuse volume creation from volfile
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 5b1f54243f749836588c15b93d203ac97a6e3e53
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jul 8 05:44:05 2010 +0000
fix up option handling
After 79241696, the following anomalies came up:
- --mac-compat and --read-only was rejected originally
on server side, 79241696 cancelled this check
- direct I/O option handling was interfered by 79241696
- --mac-compat had no effect on Linux and does not compile on Mac
Restore original behaviors.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit 69f8ee4826735cda4792140216ae6a4505fcc0fe
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Jul 7 08:15:12 2010 +0000
performance/io-cache: implement mknod fop.
- mknod_cbk has to initialize ioc_inode context, since there is a possibility
that open following immediately after mknod may not result in lookup before
open fop.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1054 (Crash in ioc_open_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1054
commit 297ca754a94c36ef49ff0d51e5af4de09ea45dae
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 7 08:05:58 2010 +0000
make DUMP as another program
* on server side, make it a rpc program.
* on client its another program at protocol
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 409975b3fe49a869973389556d559e8203eebe33
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 6 10:05:01 2010 +0000
assign proper 'fop' number to 'frame->root->op' on server side
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 179bcd4efa6791f6e9df8f72da500cb785f6505b
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 6 08:47:25 2010 +0000
Handle a crash in inode.c on 32 bit, big endian platform
Thanks to <tlisiecki@proximetry.pl> for reporting the bug and
sending the patch.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 985 (Crash with SEGV in libglusterfs on 32 bit, big endian platform)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=985
commit 1e4c9ffc685e1e1977129f284c78106b22e85c7d
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 6 07:12:11 2010 +0000
removed 'fop->checksum' from codebase as its not required anymore
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 734 (keep only the working/usable code in build tree to focus more on development)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=734
commit 63cdd12ef413e6a7ac0b7fb433ca49d519220897
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Sun Jul 4 06:20:07 2010 +0000
nfs3: Fix race updating op queue on uncached fd open
The order of locking while performing async fd opens was resulting in
a deadlock when a particular pattern of operations was generated by
compilebench. This patch improves handling of those situations while
locking the fd-cache, inode and inode queue.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1047 (Compilebench hangs nfs server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1047
commit 5bf970d8dcc0bca7978fdccfc379a79aedbfcfbf
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 6 01:42:27 2010 +0000
improvement to error-gen
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1051 (Use proper 'fop' indexing)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1051
commit a68b53b71f45255d1208d4dc2e22eea1c491fac9
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 6 06:15:46 2010 +0000
avoid repeating code
'frame->local = NULL' is done in submit_reply, instead of doing in
every _cbk (), of server3_1-fops.c
also fixes bug=1052
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 1cd0616a5b16ff9cba3a144a73d25705eb6c7fa3
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Jul 6 01:26:38 2010 +0000
glusterfsd: Handle setting entry-timeout to 0
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1034 (rename() is not atomic)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1034
commit 8c305876b772a532d53e52d7a43116ae7fa3f1b0
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 2 12:48:10 2010 +0000
allocate space for '\0' in string, while adding xlator-option
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1044 ('--xlator-option' is not working)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1044
commit 0faebb6987742083ce9784ee83b5cec37853ef6e
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Jul 5 11:24:27 2010 +0000
mount/fuse: Handle setting entry-timeout to 0.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1034 (rename() is not atomic)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1034
commit 6f17761b0450a35b43f01b97a940d1d851092761
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Jun 15 00:39:26 2010 +0000
nfs: Assign incremental lk owner to frames
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 960 (Disk space leakage and fs corruption after VMs are vmotion'ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=960
commit 52781a08e80d59f3105264405f27cb7b9eaa4e1c
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Jun 15 00:39:25 2010 +0000
nfs: Support directory level exports
nfsx has followed traditional approach of exporting whole volumes
as NFS exports. The Platform requires and some users have approached us for
introducing exports of only specific directories instead of full Gluster
volumes. This commit introduces this support through two nfsx options:
Option 1:
=========
option nfs3.<volume-name>.export-dir <subdir1-in-vol>,<subdir2-in-vol>,..<subdirN-in-vol>
export-dir will allow the export of a particular dir as a single export
by itself. For eg.:
volume posix
type storage/posix
option directory /export/
end-volume
volume posix-ac
type features/access-control
subvolumes posix
end-volume
volume nfs
type nfs/server
subvolumes posix-ac
option rpc-auth.addr.allow *
option nfs3.posix-ac.export-dir /homes/shehjart
end-volume
A comma separate list of sub-directories will set up those dirs as separated exports.
At the nfs client, the mount command will be:
$ mount <nfsserver>:/posix-ac/homes/shehjart /mnt
Option 2:
=========
option nfs3.<volume-name>.export-volumes <on|off>
There can be situations where users only want the directory level
exports and require that volume exports be completely disabled. The
above option allows us to do this. By default, volume exports are
enabled. From the earlier example, replacing <volume-name> with
posix-ac, will disable mounting of the posix-ac volume as a whole.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 989 (Support directory exports in nfsx)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=989
commit cc943943036dd72e85f7b5fda7b41472e17ce86e
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 2 04:55:28 2010 +0000
NULL dereference fixes in code base after running with 'clang'
* 212 logical (NULL deref/divide by zero) errors reduced to 28
(27 of them in contrib/ and lex part of codebase, 1 is invalid)
* 11 API errors reduced to 0
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 966 (NULL check for avoiding NULL dereferencing of pointers..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=966
commit deb51034e34ebd2b1a49241d6149eaa9053660a4
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Jun 18 02:18:02 2010 +0000
performance/write-behind: explicitly enforce ordering of overlapping writes.
- If there are non-contiguous offsets (offsets which do not start where
previous write ended), wait for completion of previous writes to server,
before sending new ones.
- Send flush call to server only when all writes are completed.
- If a file is opened with O_APPEND, at any point of time a maximum only one
write call to server should be in transit. This is to avoid reordering of
writes in the presence of afr which can result in data corruption.
See bug #934 for more details.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 970 (extracting kernel tarball hangs midway.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=970
commit 77295d596f3f7ab3d1ce9dba90dec8e3c09a65b0
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jun 29 05:36:30 2010 +0000
minor fixes in rpc + protocol
* proper use of mem_acct_init in client.c/server.c
* fentrylk_resume to be called instead of finodelk_resume in
server_fentrylk().
* handle the case of xdr decoding failure on server by sending the
proper error reply to client, so there is no missing frame.
* removed unwanted functions from server-helpers.c
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 850def27f27d944edaf3cee50ba61f764b9ec680
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jun 29 03:39:16 2010 +0000
backward compatibility of protocol
* made most of the 'legacy' server and transport functions as
'static' as they were getting cross linked with newer functions.
* changed the name of few functions with prefix 'gf_'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 2d1cd7343a41aabd19567e2fa6056fa10c42839b
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Jun 28 02:49:46 2010 +0000
Move rpc to top-level
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 83ebf21b3af0099235937506fb5dd04c8fddbdee
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jun 24 12:41:03 2010 +0000
OS X: fix up rpc protocol
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit d3390a9aa371937aff4e34e4e7a214d0fffe17e6
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 24 07:58:51 2010 +0000
added proper mem-types to GF_CALLOC in protocol
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 5fe30bda73e4967a16cd0b1766ef7fe7ea6b3d25
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 23 04:01:24 2010 +0000
change volume file options back to 'transport' from 'rpc-transport'
This helps to keep the backword compatibility with old volume files.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 86597a27bfbb13966488e534fda2de63c839cd4f
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 23 02:55:21 2010 +0000
minor improvements in protocol
* rpc_clnt_submit() now takes 'cbkfn' as an argument.
* readdir xdr now uses dirent structure directly instead of
using 'opaque' buffer through which it was serializing /
unserializing the dirent structure.
* 'gfs_id' field (currently used for debugging) is properly updated
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit cf5f36bbbc1901675dbeaf7720a59beb9a7bd1f8
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jun 22 11:30:23 2010 +0000
moved 'auth_glusterfs' xdr definitions to rpc-lib
as authentication is part of RPC header and GlusterFS payload
comes at later stages
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 90803d493e8a9d6d11a5147821f29c40a79408a4
Author: Anand Avati <avati@gluster.com>
Date: Mon Jun 21 02:17:49 2010 +0000
io-threads: initialize conf->w_attr
Uninitialized value was causing pthread_create() to fail on solaris
resulting in hung calls
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1001 (unclean termination upon getting signalled)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1001
commit e110a1c23c949bc1225688451ac1cc94d182f0ac
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Jun 16 21:48:03 2010 +0000
performance/io-cache: destroy table->mem_pool in fini.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 995 (memory leak in io-cache)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=995
commit 47de0470b4484ef0e5f77af0b0f161f90529e3f2
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jun 21 04:26:14 2010 +0000
misc updates in mainline
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 7c15eb1f709fce7bb31566d50fe5c038e7b690b8
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jun 21 04:26:00 2010 +0000
make rpc protocol as default, and move the old one to legacy
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit ff10a686865aa90eda13dff31e986013d67d2849
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jun 21 07:00:04 2010 +0000
rpc protocol
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 82ae8d38e1f37da13055156233f77661f7792cf6
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jun 21 04:24:40 2010 +0000
renamed xlator/protocol to xlator/protocol/legacy
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 9b6869e30328f77cd0d9f70b2407d62183bd2dc8
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Tue Jun 15 22:07:57 2010 -0700
Revert "performance/write-behind: explicitly enforce ordering of overlapping writes."
This reverts commit e46c613364cd90f9c277db8b0733a99fc1d255de.
commit 6710fe0b00f5d8dcc5b147f5a4c86a50ca6e1758
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed Jun 9 00:00:23 2010 +0000
Changes to volgen such that it does not error out in python2.4
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 988 (volgen in master generates error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=988
commit deb623a3267fa922e1f4ecbf9c326f0ad431a79c
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 10 01:14:56 2010 +0000
changed the order of gf_log in xlator.c to prevent hang
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit b0766a33e697c3e697861d66263e12c13bceb757
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Jun 8 06:14:30 2010 +0000
Fix compilation failure on Solaris in __socket_keepalive()
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 987 (Solaris compilation fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=987
commit a0dbde7670b27491875713f037b184e2eed5c9be
Author: Anand Avati <avati@gluster.com>
Date: Tue Jun 8 06:03:41 2010 +0000
mem-types: include *-mem-types.h in noinst_HEADERS variables in all Makefile.am
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit b803ff1360010030e5ad4527659ffcbf75d51121
Author: Anand Avati <avati@gluster.com>
Date: Mon Jun 7 13:19:11 2010 +0000
quick-read: fix size parameter to GF_CALLOC of priv to fix mem corruption
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 723 (enhancements to quick read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=723
commit 5ed580e8e30865511ba404ced211283690b989a9
Author: Anand Avati <avati@gluster.com>
Date: Mon Jun 7 12:37:34 2010 +0000
dynamic volume changes for graph replacement
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
commit b9e0176ab777a96b1c69cdaa95e5b99b2ae45b6c
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jun 1 17:27:18 2010 +0000
fuse: add a built-in fuse traffic dumper mechanism
It makes fuse dumping possible on platforms where strace is not available (eg. OS X),
moreover it makes reporting of fuse related bugs more convenient.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 972 (Metabug for misc. fuse features)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=972
commit b20e1379784fda6f083d01465188d4a920ce5fe6
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Jun 3 04:39:44 2010 +0000
performance/quick-read: fix the size-to-be pruned.
- size-to-be pruned used to be a negative number because of cache-used being
subtracted from configured cache-limit (with cache-used > cache-limit).
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 980 (quick read - fetching from backend issue)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=980
commit 6c2daf9e1cde1508e38504dd6b4d0ff4809c5e77
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jun 1 05:07:58 2010 +0000
performance/quick-read: set default cache-size value to 128MB.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 723 (enhancements to quick read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=723
commit e3b122e685d3179b825ca8fc350ffd75dbd2c193
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon May 31 22:43:57 2010 +0000
cluster/afr: Check before accessing xattrs in data self heal.
The lookup xattrs might be null, because a lookup might not have been issued during self heal,
especially if only data self heal is required.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 815 (quick-read and replicate self-heal interaction result in empty reads)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=815
BUG: 815 (quick-read and replicate self-heal interaction result in empty reads)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=815
commit 1903afb3416a675da28aaac3b47e5d286a8ddebf
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon May 31 22:43:56 2010 +0000
extras/gnfs-lognalyzer: Delete class instance to release mem early
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 913 (NFS-specific log analyzer tool)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=913
commit 903e9d90c6f5be547b44dd3a813db687fc0f6729
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon May 31 22:43:55 2010 +0000
mount3: Handle unmount for unknown volume names
In case the nfs client sends an unmount request for a volume
that does not exist anymore.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 961 (Unmount with invalid export crashes nfsx)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=961
commit 83be12884f9c86c4289c84fb45d2a5e258640a2f
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon May 31 22:43:54 2010 +0000
mount3: Handle <volname> as well for unmount dirpath
Till now nfsx would crash if the export was mounted simply as
<volname> as compared to the traditional method of /<volname>.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 944 (vmware unmount crashes nfsx)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=944
commit 879d78407f8b76d3dbfe2ec182c5830cb90ead39
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon May 31 22:43:53 2010 +0000
nfs3: Special-case the lookup for parent dir of root
When a lookup request comes in for (rootfh, ".."), we need to handle
it in a way that returns the attributes and handle of the root dir.
Not doing so crashes nfsx because the inode table is not able to
find a inode for the root's parent. This inode was being referenced in
nfs3_lookup_parentdir_resume when filling a loc for the lookup fop.
For the record, such a lookup request is sent by vmkernel.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 942 (NFS crashes as a vmware ESX data store)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=942
commit 674b7b675c216f6312000c7a23fc1f3e645599bb
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon May 31 22:43:52 2010 +0000
nfs3: Funge . and .. ino/gen in readdir of root
In the readdir reply for the root of the export, replace the ino
and gen number for the . and .. entries with 1 and 0 respectively.
On clients which inspect this field, the client will error out due
to the change in inode number of the root directory when see for "."
.. also needs to be replaced because we do not have a concept of
the parent directory of root. The return of 1 and 0 is the same as
the behaviour of: stat /.. command.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 942 (NFS crashes as a vmware ESX data store)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=942
commit 38aa8effa37aa5cac805c9921ba879e360bfafa8
Author: Csaba Henk <csaba@gluster.com>
Date: Fri May 28 07:00:42 2010 +0000
OS X: make location of launchd service configurable
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 268201ec7f7515e1466cb837050d8d42841d76b4
Author: Csaba Henk <csaba@gluster.com>
Date: Fri May 28 06:05:48 2010 +0000
OS X: salvage signal handling from mount routine
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 5857bd6c883af6d6b96abc94a6da849607273820
Author: Pavan Sondur <pavan@gluster.com>
Date: Sat May 29 16:09:24 2010 +0000
protocol/client: Add missing argument to readlink unwind call.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 967 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=967
commit b59b81f8219879e9421dc8d434909fa7b22d80a9
Author: Amar Tumballi <amar@gluster.com>
Date: Fri May 28 04:17:30 2010 +0000
cluster/stripe: NULL pointer dereference checks added
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 966 (NULL check for avoiding NULL dereferencing of pointers..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=966
commit ba3a4a65210f1c8b62bae97e2c9fe945a265566d
Author: Amar Tumballi <amar@gluster.com>
Date: Fri May 28 04:17:02 2010 +0000
cluster/stripe: added STACK_UNWIND_STRICT macro
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 966 (NULL check for avoiding NULL dereferencing of pointers..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=966
commit 9b86762a5ce853a926154d1d753636d6ee48589e
Author: Csaba Henk <csaba@gluster.com>
Date: Thu May 27 12:35:12 2010 +0000
catch up with 4911659 on OS X
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 952 (EBADF returned by server-protocol confuses AFR)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=952
commit 1b8057bba172cce7f43e101d0d5c8f5a6c87910f
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu May 27 04:38:45 2010 +0000
protocol/server: Use EBADFD instead of EBADF in the case of a failed fd resolution.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 952 (EBADF returned by server-protocol confuses AFR)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=952
commit 0f55f382d7385141d38d925d283f263e6de04cbd
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu May 27 04:27:59 2010 +0000
protocol/client: Unwind with error if getting remote inode number fails.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 951 (Unwind if inode_ctx fails in all FOPS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=951
commit 0bd79b09ad7e8e6626c7e1c05891399ac23f8c33
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed May 26 18:50:27 2010 +0000
nfs/lib: Remove "-module" from LDFLAGS
libglrpcsvc is a library and not a module according to Mac OS X.
Hence "-module" needs to be removed for linking to work.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 91474acd90ba3f120155b237242f6744e6ad1696
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue May 25 04:20:45 2010 +0000
stat information of postparent stored in preparentstr insteadof postparentstr in trace
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 945 (stat information of postparent stored in preparentstr instead of postparentstr in trace)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=945
commit 759775dbb0330532ca6ebf15e99b2469f77b23d2
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue May 25 05:16:47 2010 +0000
take the return value of trace_stat_to_str for preparent and postparent in corresponding variables
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 945 (stat information of postparent stored in preparentstr instead of postparentstr in trace)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=945
commit 1c1ce2443bd2a3c28da1fa94255a904e53c41b35
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue May 25 09:00:38 2010 +0000
Check whether NULL is returned after GF_CALLOC in the init function of io-stats
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 946 (Null check in init function of io-stats)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=946
commit 666c9342f7ac651178bdcd58ab8f37ae4bce0948
Author: Anand Avati <avati@gluster.com>
Date: Wed May 26 09:28:39 2010 +0000
resolver: set safer conditionals during path creation
when client would send just the path as part of a transaction, path
reconstruction would create parent directory's path instead of actual
path at the time of resolution.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 935 (Directories change mode from 0755 to 0644 automatically)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=935
commit 3a2bf59f57ae674cd558858b59688cfb3fc089d5
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed May 26 04:11:22 2010 +0000
performance/write-behind: explicitly enforce ordering of overlapping writes.
- If there are non-contiguous offsets (offsets which do not start where
previous write ended), wait for completion of previous writes to server
before sending new ones.
- Send flush call to server only when all writes are completed.
- If a file is opened with O_APPEND, at any point of time a maximum only one
write call to server should be in transit. This is to avoid reordering of
writes in the presence of afr which can result in data corruption.
See bug #934 for more details.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 934 (md5sum mismatch when files are transferred using vsftpd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=934
commit 22c8e17c2d975895750ca7e0307809d116757d0a
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon May 24 14:16:17 2010 +0000
features/locks: Use fuse supplied lock owner even for internal locks.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 934 (md5sum mismatch when files are transferred using vsftpd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=934
commit 2f665aa068ef929aa2cc7f0bc8e2cd9f06bd2e31
Author: Csaba Henk <csaba@gluster.com>
Date: Mon May 24 09:32:56 2010 +0000
socket: make tcp keepalive work on OS X
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 754 (enable tcp keepalive)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=754
commit d1b8001cc15e90ddc7c86c8da9507d12186c1ee9
Author: Csaba Henk <csaba@gluster.com>
Date: Mon May 24 09:30:42 2010 +0000
fix format string warning on OS X
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 936 (Provide microsecond timestamp in logfile)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=936
commit 604894aa24eedb1a067c0e0de255097075026dd8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon May 17 07:22:16 2010 +0000
performance/quick-read: implement an upper size limit for the cache.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 723 (enhancements to quick read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=723
commit 68c14b4b8dcddaaa23b734145d8d6c0d37385650
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu May 20 07:24:28 2010 +0000
libglusterfs: Use usecond resolution for logging
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 936 (Provide microsecond timestamp in logfile)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=936
commit 52199886cf0201eb098ede91ff236de32c15e513
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue May 18 03:41:38 2010 +0000
free this->private in fini in io-stats
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 930 (conf not freed in io-stats fini)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=930
commit cbd06b83dee46857e507cb142b083ffc2746ce21
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 18 01:38:17 2010 +0000
socket: Support TCP-KEEPALIVE
Introduces two new socket options:
1. transport.socket.keepalive: bool
Sets keepalive on a transport. On by default.
2. transport.socket.keepalive-interval: integer
Number of seconds between each keepalive message on the socket.
Default in linux is 2 hours. To change that value for a given
transport, use this option. Integer value is interval in seconds.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 754 (enable tcp keepalive)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=754
commit dee85b7593c4be770219d978a6a6091fe2c6f89d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 18 01:37:42 2010 +0000
nfs: Introduce trusted-write and trusted-sync options
Introduces two new options:
1. nfs3.*.trusted-write: Forces UNSTABLE writes to return STABLE to NFS
clients to prevent the clients from sending a COMMIT. STABLE writes
are still handled in a sync manner and so are COMMITs if they're sent
at all.
2. nfs3.*.trusted-sync: Forces all WRITEs and COMMITs to return STABLE
return flags to NFS clients to avoid the overhead of STABLE writes, and
COMMITs that follow UNSTABLE writes. This includes the trusted-write
functionality. In addition to the trusted-write, it also writes
STABLE writes in an UNSTABLE manner.
Both violate the NFS protocol but allow better write perf in most
configurations. Use with caution.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 924 (Slow NFS synchronous writes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=924
commit 6c437df7575b8effec7006e843ff95b51e57df5a
Author: Sachidananda <sac@gluster.com>
Date: Tue May 18 00:20:24 2010 +0000
Log proper error message when hostname or ip does not conform to standards.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 923 (Hostnames with underscores fail)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=923
commit 64c5e377409669f17985363c7d9fb518af41b061
Author: Csaba Henk <csaba@gluster.com>
Date: Mon May 17 07:10:22 2010 +0000
OS X: enable mac-compat for OS X clients.
Injecting volumes at startup this way is pretty hacky but it will do for now.
Refactoring that part will come as separate commit.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 1d334e02a1eb31370d1de0ce260d7f7b9137ca10
Author: Csaba Henk <csaba@gluster.com>
Date: Mon May 17 07:09:13 2010 +0000
OS X: adjustments, minor fixes to eliminate warnings
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 9efa796c4f30b9016b4826ef45df4cf8e01cab83
Author: Csaba Henk <csaba@gluster.com>
Date: Mon May 17 07:07:57 2010 +0000
OS X: NFS adjustments needed for OS X
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit a11fda65c4664e22729f008e36e2655d11f08729
Author: Csaba Henk <csaba@gluster.com>
Date: Mon May 17 07:06:58 2010 +0000
OS X: basic additions for OS X client support
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit c449cde7a059ce198845cddd56769c33b1e0c74a
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon May 17 04:42:46 2010 +0000
cluster/afr: Don't dereference fd ptr - it might be NULL due to a failed call.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 914 ([3.0.4] Crash in afr_opendir_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=914
commit eeb580be95e37b1f14da251f6c5a5a4730a04b51
Author: Lakshmipathi <lakshmipathi@gluster.com>
Date: Fri May 14 02:01:36 2010 +0000
Bug 799: dht prints 100% full when subvolume is not connected to remote host
Signed-off-by: lakshmipathi <lakshmipathi@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 799 (dht prints 100% full when subvolume is not connected to remote host)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=799
commit 5416f00250d5429ee3d454e63aa71adc4fc5e622
Author: Anand Avati <avati@gluster.com>
Date: Thu May 13 12:53:25 2010 +0000
fuse, dht: use readdir by default.
dht - switch over to readdirp based algo if one subvolume is down
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 898 (small file performance enhancements)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=898
commit b0e010a0aaa274aff0f9f1264bb85381524d1bd9
Author: Anand Avati <avati@gluster.com>
Date: Thu May 13 13:16:48 2010 +0000
dht: perform revalidate on one subvolume
generation numbers should detect recreations and no need to rely on
layout changes anymore
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 898 (small file performance enhancements)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=898
commit 44d0c95f457318335f335998d5f49d28a01c252e
Author: Anand Avati <avati@gluster.com>
Date: Thu May 13 12:53:05 2010 +0000
write-behind: update default values for better small file performance
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 898 (small file performance enhancements)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=898
commit 4730800ad1839d5e4c0eda064abbc396962a8d56
Author: Csaba Henk <csaba@gluster.com>
Date: Wed May 12 19:10:47 2010 +0000
added features/mac-compat
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 800 (Problem on OSX with NFS and CIFS exports)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=800
commit 14db11358e5677f113a925b23c2c2e23e302fdfc
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu May 13 06:59:19 2010 +0000
nfs3: Final unref only on successful remove
The final unref on the inode during a file removal
should take place only if the file removal was successful.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 857 (Crash in afr_sh_entry_expunge_entry_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=857
commit 77c2e43478700334d398bc9cc70c6b37d34bd6e6
Author: Csaba Henk <csaba@gluster.com>
Date: Mon May 10 09:30:37 2010 +0000
nfs: fix warning on 32 bit
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 902 (iozone hangs during random read throughput test)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=902
commit fff032ae0c5e652b9f277f603df01dd3505a5960
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon May 10 17:35:41 2010 +0000
glusterfs-profiler: Add text mode support.
glusterfs-profiler works in text mode by default now. This allows it to run on systems which don't have matplotlib installed.
Modes can be selected using:
-m graph - Graphical mode
-m text - Text mode (default)
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 268 (Add timing instrumentation code)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=268
commit 8408594491600d03583da405322b07e98495f58a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Sun May 9 23:13:55 2010 +0000
extras: Add NFS-specific log analyzer tool
Most of the time, a NFS request and the reply are separated by hundreds
of lines of other debugging output most of which is not always relevant
for NFS debugging. This script synthesizes the full glusterfs log into
the parts relevant for NFS while bringing together the NFS requests with
there replies on one line.
Min log-level required for this script to be useful is DEBUG. Only
works for NFS translator.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 913 (NFS-specific log analyzer tool)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=913
commit 6f044a29e4e8b1bf8b2758c5f9397604e4f39959
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Sun May 9 23:13:54 2010 +0000
nfs3: Round-up read reply bytes of multi-vector reply
A previos commit brought in support for returning read replies
when subvolumes return reads in multiple iovecs. This did
not completely fix the problem since the bytes in iovecs
all together could be unaligned with the 4 byte
boundary as needed by XDR for the opaque data. This resulted
in read requests being either retransmitted or rejected with
an error message in syslog on the NFS client.
Signed-off-by: Shehjar Tikoo <shehjart@dev.gluster.com>
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 902 (iozone hangs during random read throughput test)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=902
commit ce8425f9480d9dcee151da53e785636834e13a20
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Sun May 9 23:13:53 2010 +0000
rpcsvc: Move xdr round up functions to rpc code
Signed-off-by: Shehjar Tikoo <shehjart@dev.gluster.com>
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 902 (iozone hangs during random read throughput test)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=902
commit a47b19a2032081beaaa283cf37b20ea8acd95d37
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Sun May 9 23:13:52 2010 +0000
nfs: Fine tune nfs_entry_loc_fill return values
A previous change to this function introduced a regression
for exclusive creates. This patch fixes the regression by
bringing the return values in line with what the callers
expect in different situations of loc filling.
Signed-off-by: Shehjar Tikoo <shehjart@dev.gluster.com>
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 857 (Crash in afr_sh_entry_expunge_entry_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=857
commit 39b1c8717d25a930e0a9b647d5af431763911fd9
Author: Anush Shetty <anush@gluster.com>
Date: Fri May 7 04:25:28 2010 +0000
Adding GF_LOG_OCCASIONALLY to prevent repeated log messages
Signed-off-by: Anush Shetty <anush@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 10 ([ glusterfs 2.0.0 ] - Repeated Log messages with invalid remote-host in protocol/client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=10
commit 03878b7fa1cb6bffda3ab8595579bebcf88eaa38
Author: Simone Gotti <simone.gotti@gmail.com>
Date: Tue May 4 16:48:55 2010 +0000
Unset split-brain flags in afr_self_heal_completion_cbk if self heal completes successfully.
Signed-off-by: Simone Gotti <simone.gotti@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 884 (I/O errors after fixed split brain and successfully completed self heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=884
commit aca8b64cc80c72eff317b4b16d7455fbd504180e
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri May 7 01:53:11 2010 +0000
nfs3: Submit multiple vectors received in read callback
There is a possibility of io-cache or read-ahead returning
a read buffer that straddles two separate pages in ioc or ra,
through two struct iovecs. Current nfs3 read reply does not
return as many vectors as received from a subvolume leading to
a short read for the NFS client.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 902 (iozone hangs during random read throughput test)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=902
commit e3083dc614e67f13cc2aacafbf02bbaf9b136261
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri May 7 01:53:10 2010 +0000
rpcsvc: Support multiple vectors during reply submission
RPC reply path allows attaching a single iovec to a reply. This limits
the replies for certain program ops which need to return multiple vectors
for eg, the NFSv3 read reply.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 902 (iozone hangs during random read throughput test)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=902
commit 82fde12e5f7c24d80e90392418ef56faba912743
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu May 6 08:36:16 2010 +0000
nfs3: Use standard macro to return ESTALE
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 857 (Crash in afr_sh_entry_expunge_entry_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=857
commit 31ceda941c4741d0035e7beada49d41d9235a6c0
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu May 6 08:36:15 2010 +0000
nfs: Handle failed parent loc filling
Just because an inode_get for parent (ino, gen) returns a valid
inode_t does not meant that the inode_path(..in nfs_parent_inode_loc_fill..)
will return successfully. The failure of nfs_parent_inode_loc_fill was
not handled resulting in a NULL path being passed for the fop.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 857 (Crash in afr_sh_entry_expunge_entry_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=857
commit 78f61ff5b4ed6900d43a4796a870c3523df2eae7
Author: Anush Shetty <anush@gluster.com>
Date: Thu May 6 05:52:40 2010 +0000
Fix for crash in stripe_entry_self_heal
Signed-off-by: Anush Shetty <anush@gluster.com>
Signed-off-by: Anush Shetty <anush@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 887 (Crash in stripe_entry_self_heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=887
commit 446a53ecf65ce97ca33e995e9f1d2a32ce2a8d4f
Author: Sachidananda <sac@gluster.com>
Date: Wed May 5 01:15:09 2010 +0000
Add key/type pair to volume_options.
This avoids warning message to be logged for internal option
`transport.socket.lowlat' as not being recognized, when transport/ib-verbs is
used.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 818 (transport.socket.lowlat option is not given as can be seen from the vol-file still the warning shows up in the logs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=818
commit ac49eccb689d1a7fe1df4d6e076b765e10a4b2be
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Wed May 5 01:14:02 2010 +0000
Check whether a server is down before calling rename on the directory
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 820 (distribute directory rename problem when one subvol is down)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=820
commit 6d48318d2fda2464e4daa748b1d18ebde06018a9
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed May 5 00:27:45 2010 +0000
posix: Support thread-safe vectored writes/reads
..by maintaining internal offsets and using pwrite/pread
instead of writev/read.
The recent io-threads change is causing concurrent writes to
a file from different io-threads. This results in a race between
two threads both of which are trying to call lseek-writev. The
lseek-writev sequence should be a critical section. This is where
pwrite syscall helps. pwrite also requires an offset to be given so
for supporting pwrites for multiple iovecs we maintain an offset
within posix for the duration of the write fop and pass this internal
offset to pwrite.
The same logic also applies to read, only difference is that we do
not need to read multiple iovecs but only provide an atomic
lseek-read sequence.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 883 (Data corruption due to thread unsafe reads and writes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=883
commit ac3a970342a3ea60fde9f2161f0c9d647e07b098
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 4 04:01:30 2010 +0000
nfs3: Fix NFSv3 string error for EISDIR
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 858 (Crash with afr_local_cleanup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=858
commit 32cb1b65b8ea810fd85b01552e90162fd7ed3d49
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue May 4 02:29:22 2010 +0000
performance/read-ahead: don't set ra_file in fd->ctx unless all memebers of ra_file is initialized
- If ptr to ra_file is set in fd->ctx even before initializing all its
members, A race condition may occur b/w a thread executing ra_fstat,
ra_readv etc (where all files open on the same inode are flushed) and
the thread doing initialization of ra_file (in ra_open_cbk or
ra_create_cbk). Because of this race-condition, flush_region might be
called on an uninitialized ra_file, thereby causing crash.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 868 (crash in ra_fstat)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=868
commit bfb354b98c3cb181ae683bebef22c6c87b3b8959
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon May 3 18:10:46 2010 +0000
cluster/afr: Unwind lk using struct flock from a successful server
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 882 (directory traversing problem (client crash))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=882
commit 6c9e8160cae908436a7e2ef1fc41a36d93203df4
Author: Pradeep Patil <pradeep@gluster.com>
Date: Sun May 2 23:55:43 2010 +0000
crash fixed in stat-prefetch.c
Signed-off-by: Pradeep Patil <pradeep@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 876 (crash in stat-prefetch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=876
commit 406ea0b9945e81ea9a523cd25c7dd18a3a99839f
Author: Amar Tumballi <amar@gluster.com>
Date: Tue May 4 00:37:01 2010 +0000
frame's 'op', 'type' restructured
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 984ecb643d339584a8381393821f66e27320693c
Author: Amar Tumballi <amar@gluster.com>
Date: Tue May 4 00:36:24 2010 +0000
structuring of protocol - 2
* 'transports/' and 'auth/' moved to xlators/protocol/
* transport.{c,h}, authenticate.{c,h}, protocol.h moved to
xlators/protocol/lib/src/
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 14ef4113171c6c55a6b2c5e5ef4411c28fb16481
Author: Amar Tumballi <amar@gluster.com>
Date: Tue May 4 00:35:59 2010 +0000
structuring of protocol
* isolated 'protocol.h' and transport.h from libglusterfs/* and
glusterfsd/*
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit 69e31a2883b5861caf16c4c9c6e03e23bb84940e
Author: Amar Tumballi <amar@gluster.com>
Date: Tue May 4 00:35:36 2010 +0000
'features/locks': remove all reference to 'transport_t'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
commit dc077daa59bd388fa5d0797e9fdeb4d525aedaac
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Apr 27 09:56:00 2010 +0000
dht: don't overwrite the layout after the subvolume expansion
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 864 (dht self-heal overwrites layout causing 'missing' files.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=864
commit 7b086db94826a674b1878a47aca6199f96c33c30
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 28 01:37:39 2010 +0000
fusermount: bring in updates from upstream
* Fix checking for symlinks in umount from /tmp. Reported by Al
Viro
* Fix umounting if /tmp is a symlink. Reported by Franco Broi
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 657 (Metabug for tracking fuse upstream)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=657
commit 14848fd85ec31078034594550bcb5d64198c884a
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Apr 29 00:27:57 2010 +0000
performance/io-cache: Dump private information
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 828 (glusterdump filled up the /)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=828
commit 6b0470798c3065146830dd79e86883ce5c782ea6
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Apr 27 09:11:51 2010 +0000
cluster/stripe: Memory accounting changes
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit e0f645e3a5c2b78f3b4e3e0fcca89994ec4f2aa6
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Apr 27 09:11:17 2010 +0000
nfs/server: Memory accounting changes
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit 0f0b284d5e01adcf8bc352df46bb19a3655b4591
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Apr 27 08:47:40 2010 +0000
features/access-control: Memory accounting changes
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit b36cb5a8b7bbc673686f5d13c0aca1abc9c14ccf
Author: Anand Avati <avati@gluster.com>
Date: Tue Apr 27 07:44:45 2010 +0000
cluster/dht: perform inode number overwrite in readv_cbk iatt with checks
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 862 (Crash in dht_readv_cbk with error-gen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=862
commit 8acc2f7a31519fef17a453d0e9d56f17600f3ce0
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Apr 27 03:46:39 2010 +0000
Set op_ret to -1 when open fails in posix_create
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 825 (when create() races both return success)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=825
commit ff8859beea09ae1d6cd97616594e419a7997e543
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Apr 26 07:48:29 2010 +0000
performance/quick-read: don't try to validate again if qr_readv is called just after validation.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 852 (QR cache-timeout 0 causes high CPU usage and app hangs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=852
commit 9ceddf21d7c3f5996c13b724f1a374ce75ea6a9a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Apr 22 06:12:00 2010 +0000
stat-prefetch: Remove checks for loc->parent
..because loc->parent can be NULL for the root inode.
Having this check makes sp return EINVAL on perfectly valid
fops.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 845 (NFS BETA Test - Test Case 1: 4dist-repl-chown1m)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=845
commit d6a33671612fefa65b8885a9f62818525def5f7d
Author: Sachidananda <sac@gluster.com>
Date: Thu Apr 22 04:13:36 2010 +0000
Filter out extended attribute visibility on the mount point.
Filter out extended attribute visibility on the mount point.
This causes rsync -X to remove the extended attributes and `Stale NFS file
handle' error on mount point, resulting in making the mount point inaccessible.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 797 (DHT layout and posix generation number xattr's should be filtered)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=797
commit bdbbbf40d9256337a1da60b37a08f988722e3169
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Apr 22 13:33:09 2010 +0000
Memory accounting changes
Memory accounting Changes. Thanks to Vinayak Hegde and Csaba Henk for their
contributions.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 329 (Replacing memory allocation functions with mem-type functions)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=329
commit 476396db9ac0b37128cb7da3b8d2e6f8dc9f20a2
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Apr 22 20:38:42 2010 +0000
debug/io-stats: Call readdirp in readdirp instead of readdir
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 268 (Add timing instrumentation code)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=268
commit a8c375ff11dddea3f9e820a6bebc44613ff76db2
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Apr 23 06:45:34 2010 +0000
mount/fuse: Destroy STACK when truncate and other op are part of same SETATTR
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 829 (SETATTR stack leak?)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=829
commit 8ffda3f197cc76de5d96c71a2a8d8a8abe1bca8a
Author: Harshavardhana <harsha@gluster.com>
Date: Wed Apr 14 20:20:38 2010 +0000
extras/volgen: Volgen patchset
-- Supports NFS Translator.
-- Consolidated common API's into Common.py.
-- Removed unused CreateBooster.py.
-- Added code for "--add-server" for dynamic volumes.
Currently its commented out we will use it when needed.
-- No more options hiding in background anymore. All options
specified for each translator are commented and exposed.
Only necessary values are enabled. This is done due to
necessary cleanup of unwanted options by exposing them.
PENDING: "replicate" translator
-- Quota is disabled for native NFS on client side.
Only server side quota can be used as of now.
-- Additional code cleanup.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 822 (Volgen changes supporting NFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=822
commit 6b80d07cdf6ca097c63305d79a1e2fa1a4fd2995
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Apr 20 09:08:26 2010 +0000
Do not hardcode the lru_limit on inodes to 1 Million while creating the inode table
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 834 (lru_limit on inodes is hardcoded to 1 million)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=834
commit 85595151484e3ecccb30edcf99e9743396bac551
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Apr 22 00:47:19 2010 +0000
core: Set ctx in global_xlator to prevent NULL ptr reference
This results in a crash in STACK_UNWIND after a call bail out.
Since the call bail does not occur in the context of an xlator,
the old_THIS in STACK_UNWIND is handed a global_xlator which did
not have its ctx set, resulting in a NULL de-reference.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 844 (mixed testing with 35 clients)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=844
commit 7cebceadeb0bc41097be8496f48af57e165ccb5d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Apr 20 02:43:08 2010 +0000
nfs: Remove reference to top
This is not needed anymore and also conflicts with changes being
made for DVM.
Should have been removed with the bug fix for bz 770.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 770 (NFS Xlator - Crash when both GlusterFS server/NFS Server are in the same file)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=770
commit af1d4a82a3b6f7c277abb756b86e88a98c17cf95
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Apr 15 12:30:37 2010 +0000
cluster/afr: Check for call_count in ENTRY_RENAME_TRANSACTION
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 824 (Crash in afr rename transaction)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=824
commit 0f0baf7fbc839a0bf0509a5080b251bf9cce1dff
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 13 12:47:14 2010 +0000
cluster/afr: Send xattr in lookup from the source subvolume.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 815 (quick-read and replicate self-heal interaction result in empty reads)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=815
commit 1dff436f449cb06e1ea106351073e9fa681a7f6b
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 13 18:39:34 2010 +0000
cluster/afr: Fix possible NULL dereference in readdirp_cbk
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 722 (Segfault in glusterfs 3.0.3 replicate/afr_readdirp_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=722
commit 5fd92e25fe89e91d1ba8f7dec7c9fa708173a915
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Apr 12 21:57:35 2010 +0000
nfs3: Use nfs3state in call_state to avoid getting from rpc request
This change avoids having the nfs translator depend on the sanity
of the rpcsvc_request_t type after NFS reply has been sent. This
was a problem because the request structure is guaranteed to be
invalid after the reply for the request has been submitted by the
RPC program. NFS3 handler was ignoring this behaviour and accessing
the private in request after reply submission resulting in access to
corrupted data.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 757 ([NFS-Alpha] Crash in nfs3_call_state_wipe)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=757
commit 513cb506b61cb89e37dbd02d4ddd9789e73d0391
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Apr 11 19:08:48 2010 +0000
fuse: fix too early freeing
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 755 (Fuse loc error when files are created and deleted simultaneously)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=755
commit 2090cf9c425f2e61ec783fc9b160f08646303f21
Author: Anand Avati <avati@gluster.com>
Date: Thu Apr 8 14:07:00 2010 +0000
protocol: fix endianness for nanosecond field in stat structure
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 801 (Direct io-mode support and related changes in caching translators.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=801
commit 217626d116ace978e517b4dea6ab2c96c27572da
Author: Anand Avati <avati@gluster.com>
Date: Thu Apr 8 13:15:32 2010 +0000
afr: afr_fsetattr - send proper inode pointer to afr_read_child()
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 814 (replicate complains of invalid inode in afr_read_child())
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=814
commit 770eb2ba18e686679cab2b6d8835c6d270e59b9e
Author: Anand Avati <avati@gluster.com>
Date: Thu Apr 8 12:24:31 2010 +0000
iatt: change S_IF macros with IA_IF macros in missing places
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 730 (unknown filetypes and inode conflicts in afr)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=730
commit 26f4d3e3a1f76df008667d870cae7e5dc2e56e04
Author: Anand Avati <avati@gluster.com>
Date: Thu Apr 8 12:23:10 2010 +0000
afr: fix inode ref leak in lookup
first success lookup sets local->cont.lookup with inode_ref and second
setting leaks
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 813 (inode ref leak)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=813
commit 0aaaf8fc8396a2226fc0942c2aec7ed52b826a27
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Apr 5 05:59:17 2010 +0000
performance/quick-read: read directly from backend for fds opened with O_DIRECT flag.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 723 (enhancements to quick read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=723
commit 174490fd9d13458779e9c68f5f91dc5aa1d0c2e0
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 7 10:07:29 2010 +0000
NFS: type fixes: some portability cleanup
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 399 (NFS translator with Mount v3 and NFS v3 support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=399
commit 25452d77d22d8b9998208fb38a79db4ba8561097
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Apr 7 10:05:29 2010 +0000
NFS: type fixes: sanitize rpcgen generated typedefs
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 399 (NFS translator with Mount v3 and NFS v3 support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=399
commit 78cb8f5191f185b83230f38b29c15a05c802bf45
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Apr 7 11:49:00 2010 +0000
cluster/afr: Cleanup fd ctx in releasedir cbk
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 805 (memory leak in afr)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=805
commit d6ce954d61bb72bdad3bb899612e5af718c72b7d
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Apr 6 21:18:15 2010 +0000
initialization fixes
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit b008258b73eaecdcde76bfd0413a0fe0c48208dc
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Apr 7 07:25:39 2010 +0000
nfs3: Allow all access to superuser except execute at all times
During building glusterfs from source, the make phase fails because the
access test by super user actually returns the access test bits using
only the user, group and other, without accounting for the special
status of super-user.
This results in a permission denied for the super-user.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 807 (GlusterFS compilation fails on NFS Client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=807
commit 10804fdbe34f2c292e3d30f24c2a156429a91e8c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Apr 5 13:36:36 2010 +0000
performance/quick-read: make use of nanosecond resolution of mtime to decide whether to keep cache or not.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 801 (Direct io-mode support and related changes in caching translators.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=801
commit 98bf09f89458c0cf083553f7bf98ef45d3298eaa
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Apr 5 13:36:07 2010 +0000
performance/io-cache: make use of nano second resolution of mtime during cache validation.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 801 (Direct io-mode support and related changes in caching translators.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=801
commit 359414f39c548312337c2915cad397875fa7bc61
Author: Anand Avati <avati@gluster.com>
Date: Mon Apr 5 13:35:45 2010 +0000
fuse: change behavior of direct io mode.
If bigwrites are available, then disable direct io mode only by default
(previously direct io mode was disabled in any case).
Added new command line option to force enabling of direct io mode
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 801 (Direct io-mode support and related changes in caching translators.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=801
commit 8ce37d92f862fe45985d2df14fea9c3f0e5baf9a
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Apr 7 04:19:48 2010 +0000
backword compatibility with 3.0.x releases - restored
* glusterfs.h - added back the removed 'fop' types in same order
* call-stub.c - enhanced logging in case of failure
* server-protocol.c - added a ENOSYS function for these fops, so
there will be no crash if a old client
connects to mainline server.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 734 (keep only the working/usable code in build tree to focus more on development)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=734
commit a0e1e739781b3ac1b4d3354639f0509f982344d7
Author: Vikas Gorur <vikas@gluster.com>
Date: Sun Apr 4 14:11:26 2010 +0000
core: Do internal latency measurement of FOPs.
This patch adds a facility by which each translator
keeps track of the average latency of a FOP from
its point of view. That is, the duration between
the translator handing over the call to a lower-level
translator and the reply coming back.
The latency measurement is off by default, and can
be toggled by sending SIGUSR2 to the GlusterFS process.
Latency data is printed as part of the process state dump.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 268 (Add timing instrumentation code)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=268
commit e5cf591166fc7e4d7fffdcd7719e62aada1fb533
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Apr 2 18:03:33 2010 +0000
extras/profiler/glusterfs-profiler: Add graphing tool.
glusterfs-profiler is a Python tool that can graphically display
the profiling information printed in the process state dump.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 268 (Add timing instrumentation code)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=268
commit 89d67b58b32fd7a3f51262f0d5825a2c930a8305
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Apr 2 04:32:30 2010 +0000
nfs: Redesign fop argument passing to support single volfile use
The current design of the interaction between the generic NFS layer and the
protocol handlers like mount3 and nfs3 is such that it does not allow using a
single volume file which contains the nfs/server and the protocol/server.
This is because the common nfs-fops layer assumes that ctx->top is always the
nfs/server. This is wrong. The fops layer needs access to top because top or
rather the generic NFS xlator's private state has a mem-pool. The fops layer
needs this mem-pool to get memory for storing per-fop state. Since the fops
layer cannot anymore take ctx->top be the nfs/server, all layers need to start
passing the nfs/server xlator_t right down to the fops layer.
I am also taking this chance to remove the synchronous equivalents of the fops
and also remove the dirent caching directory operations.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 770 (NFS Xlator - Crash when both GlusterFS server/NFS Server are in the same file)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=770
commit d71d051efabc8bf7ad13a3a3f7fbceb32e206f0d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Mar 31 23:52:33 2010 +0000
nfs: Fix RPC library name to avoid conflict with system librpcsvc
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 399 (NFS translator with Mount v3 and NFS v3 support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=399
commit a02c6d51c99c64086d0cac02e96579ca107b35c3
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Mar 24 14:01:36 2010 +0000
Fix further cppcheck reported issues.
Reported-by: Patrick Matthäi <pmatthaei@debian.org>
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 420 (fix leaks pointed out by cppcheck static analyzer)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=420
commit 5f8cf83e97a04f6bbc0fa28bc4e14b7172c158cb
Author: Harshavardhana <harsha@gluster.com>
Date: Wed Mar 31 08:29:54 2010 +0000
Hardcoded infiniband port is now handled dynamically by searching for active ports.
* If user specifies a port then that port will be used regardless of which port is active.
* If user doesn't specify any port then any one of the active ports is used.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 793 (Infiniband port handling should be dynamic by picking up from active ports)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=793
commit dc8581d074300caa18ac81cf6177694df7652e34
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Mar 31 07:27:05 2010 +0000
nfs: Add NFSv3 protocol support
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 399 (NFS translator with Mount v3 and NFS v3 support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=399
commit cbcc09aeb501368f5fb2f39506025c3a15eea42f
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Mar 31 07:27:04 2010 +0000
nfs: Add MOUNTv3 protocol support
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 399 (NFS translator with Mount v3 and NFS v3 support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=399
commit 32bef2bcaca6e30479be4ca1d5379bf690cf1651
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Mar 31 07:27:03 2010 +0000
nfs: Add generic nfs translator
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 399 (NFS translator with Mount v3 and NFS v3 support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=399
commit b472df64fc7854a3dbfe05fa8000e3386a6cf219
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Mar 31 07:27:02 2010 +0000
nfs: Add RPCv2 service
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 399 (NFS translator with Mount v3 and NFS v3 support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=399
commit ecaaafffe9589540ad01ebd83ee31ea0ad8b5416
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Mar 31 07:27:01 2010 +0000
nfs: Add RPC and NFS XDR translation routines
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 399 (NFS translator with Mount v3 and NFS v3 support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=399
commit 13dd6ed9aa489d840e2714c0d4becbe1508de42d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Mar 31 07:27:00 2010 +0000
access-control: Introduce new translator
The access control translator is required for performing permission
checks on files and directories in line with posix conformance.
This is required to be kept separate from storage/posix so that
ACL support can also be later integrated into this translator.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 400 (Support auxiliary gids in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=400
commit 69032a86ccf74b9f3ef02b57db09082d44d72060
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Mar 31 07:26:59 2010 +0000
core: Expose default callbacks
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 400 (Support auxiliary gids in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=400
commit eefa0fc153922d67d106d3fcb9d4c94205e51315
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Mar 31 07:26:58 2010 +0000
core: Add iatt protection bit testing macros
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 400 (Support auxiliary gids in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=400
commit deb044bdf93f0ccf62a4f2a7efa076a204ff1040
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Mar 28 23:53:17 2010 +0000
fop namespace cleanup.
removed 'lock_notify', 'lock_fnotify', 'setdents', 'getdents' from
'fop' list, and removed 'stats' from mop list, as they are no more
used in the codebase, and had made code bulky/buggy.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 734 (keep only the working/usable code in build tree to focus more on development)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=734
commit bd05d8eb53ba82def8851958daeceeb0b86addbd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Mar 29 00:35:52 2010 +0000
libglusterfs/transport: no need to set address-family if one is not set in the configuration family.
- if not set, address family defaults to AF_UNSPEC and getaddrinfo will fill
appropriate address family for transport types tcp/socket.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 693 (glusterfs 3.0.2 will not listen on IPv6 address)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=693
commit 77993e34951e295ab92884e11fe27ee5221ded58
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Mar 29 02:08:54 2010 +0000
stripe readv: proper validation of 'op_ret'.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 536 (fsx tool fails over stripe)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=536
commit 532ee946d0583a2eb47ca9ed97af7d278e534ca0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Mar 26 02:41:58 2010 +0000
performance/write-behind: Resume all the consecutive non-write operations in the request queue in a single go.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 740 (read-ahead does not work to its full potential when loaded on top of write-behind)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=740
commit f8dd193a4c0ede83709aa5d4d916d64222267d41
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Mar 29 00:16:52 2010 +0000
libglusterfs: Remove passive iobufs from statedump
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 782 (Remove passive iobufs from statedump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=782
commit a55098a4fb4717a78e5052d1360efe3fb9714c7b
Author: Harshavardhana <harsha@gluster.com>
Date: Fri Mar 26 06:51:12 2010 +0000
Fix backtick evaluation bug in cache-size
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 768 (cache-size might be wrong in glusterfs.vol)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=768
commit 4504e100a63a11f5a91199c710bbde52790b44ba
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Mar 25 01:50:58 2010 +0000
cluster/afr: UNWIND if opendir returns an error.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 756 (simaltaneous rm -rf hangs the clients)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=756
commit d14fe9f8899df850f914e1aa7f725635badb1023
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 24 13:27:14 2010 +0000
stripe: proper fix for reading 'holes'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 713 (fsx tool segfaults in readahead and iocache)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=713
commit 39649e03a078307a7ec42c20ddb5a1c26899f8c8
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Thu Mar 25 02:14:42 2010 +0000
fix utimes
Change utimes to lutimes to prevent errors from symbolic links for linux. For non-linux systems keep utimes.
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 34 (No such file or directory on du)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=34
commit 126692a4756bdf462aadf05ff171cf4e505739a2
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Mar 24 04:22:33 2010 +0000
Remove glusterfs-guts from the repository.
Goodbye, glusterfs-guts/!
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 734 (keep only the working/usable code in build tree to focus more on development)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=734
commit f11cecb78ad3d135001696ffb541cbd11c3c92b2
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 24 04:05:16 2010 +0000
mount script has new option '-o ro'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 712 (mount.glusterfs script doesn't handle 'ro' option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=712
commit 51a1e8765a1e31a53dc4894c16786ce73684d6e4
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 24 04:04:51 2010 +0000
added '--read-only' command line option for glusterfs
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 712 (mount.glusterfs script doesn't handle 'ro' option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=712
commit b915d11a4cf1e8cfb48c5b27157cf8d230b71c88
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 24 04:04:02 2010 +0000
new 'features/read-only' module added
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 712 (mount.glusterfs script doesn't handle 'ro' option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=712
commit d3e12d37fe71795245861c12f31b49e1fa5ba461
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Mar 23 17:02:29 2010 +0000
extras/volgen: Add copyright headers.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 751 (Copyright headers missing)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=751
commit a85750173abfc3331b73dd6d354a786d427b8814
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 23 08:25:57 2010 +0000
man pages updated
man 8 glusterfs
man 8 mount.glusterfs
man 8 glusterfs-volgen
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 734 (keep only the working/usable code in build tree to focus more on development)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=734
commit e34a17bfc61f2896d9a05c9eb577072be76f609a
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 23 08:16:59 2010 +0000
updated the build tree.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 734 (keep only the working/usable code in build tree to focus more on development)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=734
commit f4c34a32e7662c52ae1200eab397162168b3707e
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 23 01:32:20 2010 +0000
Replace struct stat by struct iatt
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 749 (crash in stripe_readv_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=749
commit 935ad99abd941f835a4fcff2afcda1775fc44748
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Mar 18 17:23:15 2010 +0000
fix warnings on 32 bit
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 6ce155d4a87b101827f9d48f9a9c429bad8e5f81
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Tue Mar 16 09:46:33 2010 +0000
iatt: changes across the codebase
- libglusterfs
-- call-stub
-- inode
-- protocol
- libglusterfsclient
- cluster/replicate
- cluster/{dht,nufa,switch}
- cluster/unify
- cluster/HA
- cluster/map
- cluster/stripe
- debug/error-gen
- debug/trace
- debug/io-stats
- encryption/rot-13
- features/filter
- features/locks
- features/path-converter
- features/quota
- features/trash
- mount/fuse
- performance/io-threads
- performance/io-cache
- performance/quick-read
- performance/read-ahead
- performance/stat-prefetch
- performance/symlink-cache
- performance/write-behind
- protocol/client
- protocol/server
- storage-posix
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit b3380aa474fc0850b156b92bafa77f159fe34ff3
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Tue Mar 16 09:46:32 2010 +0000
introduce iatt.h for inode attributes (to replace 'struct stat')
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 61073523da626f7545ed7b4f976f59912f8ea275
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Tue Mar 16 09:46:31 2010 +0000
iatt: configure.ac not to build filter
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 2e6792ce1a83dbb45ec4cb39960ef59a21263468
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Tue Mar 16 09:46:30 2010 +0000
xlator.h: whitespace cleanup
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 95193aab8c98b1bb335970fc8178dcf8d332ccf1
Author: Harshavardhana <harsha@gluster.com>
Date: Mon Mar 15 04:14:14 2010 +0000
Fixed "." delimiter for cache-size calculation which would fail on different locale.
Thanks to Filip Valder < valder (a) netdevelo.cz > for suggestions.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 720 (Default . decimal delimiter will not work for other locale)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=720
commit 4d35452c3e3965ce44f7943057217114ccf0f96e
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 10 02:14:55 2010 +0000
stripe: logic fixes
* for setting 'local->failed'
Earlier, stripe was not handling different errors from subvolumes,
and hence failure testcases using 'debug/error-gen' were failing.
With this fix, tests pass fine.
* proper event handling in notify.
Send CHILD_UP and CHILD_DOWN events properly.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 691 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=691
commit 03bd77164e157de7a3f1972535f3e9f96b7525c2
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 10 00:30:56 2010 +0000
stripe: whitespace cleanup
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 691 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=691
commit a6e6de1deb71e27d24dd37a8afc1db300bc56f74
Author: Sachidananda <sac@gluster.com>
Date: Tue Mar 9 03:18:56 2010 +0000
When option mandatory is given, print warning messages instead of Error.
Change the log level to Warning instead of Error.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 704 (GlusterFS starts despite error is logged in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=704
commit 927ce7d953bb6f9345a6baf79774856c40dd97bf
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 9 07:57:14 2010 +0000
send lookup on every subvolume if local->hashed_subvol is NULL in nufa/switch
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 114 (Creating files or directories gives "Invalid argument")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=114
commit 5dd3adfe06a9776d108fdf3bdde4537ea0cfadcb
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 9 06:34:17 2010 +0000
cleaned up some outdated files
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 491 (Outdated files in glusterfs source (Broken links in them))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=491
commit e7be16ec155f5b55769f597cde7d2849af0a7fcc
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Mar 11 04:11:17 2010 +0000
protocol/server: Do gf_flock to flock conversion at the right place
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 708 (solaris : ping pong test hangs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=708
commit 6aac4dc0ca5ce1040fca7a66d650186af49a9b6c
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Mar 9 02:37:30 2010 +0000
extras: Add script to be used before using quota translator.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 569 (Memory leak in quota translator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=569
commit 8500f2e1fb72763a4b41c606c924d87cd083b09e
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Mar 8 05:31:11 2010 +0000
handle SIGINT in glusterfsd
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 703 (SIGINT not handled in glusterfsd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=703
commit 9249b9079797c1cc28dae8f022cf2af404e06c1b
Author: Anand Avati <avati@gluster.com>
Date: Thu Mar 4 06:52:49 2010 +0000
dht: preserve and return proper pre/postparent structures during unlink
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 689 (Segfault (11) on op UNLINK)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=689
commit 6fed108498f2b0c711e3202be7cbfbd796832866
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:10 2010 +0000
quick-read: Store and propagate wbflags argument in open fop
..this is needed to ensure underlying translators like
write-behind, ioc, etc, do not return zero-filled stats
to NFSx.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit e5d4a40b5cdaba37e024a39ec2681cb545d42d2b
Author: Anand Avati <avati@gluster.com>
Date: Wed Mar 3 11:51:30 2010 +0000
distribute: cleanup intermediate hardlink and linkfile on failed rename
implement a generic cleanup function which handles cleanup of
temporary linkfiles and hardlinks created as part of the rename
transaction, and callable from any stage of failure.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit 049e986fbee9bf07cd979855aacd2006a380f8d4
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:08 2010 +0000
distribute: perform self-heal as root
prerserve original frame uid and gid and perform self-heal by changing
uid/gid to root (0) temporarily.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit 92b229f7c03576aff0dbeb0ff26a0e174f9dbbc1
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:07 2010 +0000
distribute, nufa: return 0 mtimes in preparent/postparent
Returning 0 times means the values are unreliable and not to be
trusted for the purposes of caching.
This is a temporary fix till we bring in proper times handling in
DHT to return consistant values for parent inodes.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit 8e4e6e69bd00b378f00968f5cfb5aafe1c11e6f9
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:06 2010 +0000
distribute: Save ino/dev from first subvolume during mkdir
A self-heal on directory creation results in the subsequent
call to dht_selfheal_new_directory to happen only for the last subvolume.
But when this function is called for the last subvol it is possible
that the st_ino returned in this function's callback is the st_ino
from the hashed subvolume(assigned in dht_mkdir_hashed_cbk).
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit ef4debb0aabf3d0a9ff8e4de82b1d32423152a5d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:05 2010 +0000
distribute: Restore parent ino from local in symlink
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit a4a2c37a724abb10348d4227c53bb6d890be77f5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:04 2010 +0000
distribute: Restore inode from saved ino on readv
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit aa813004a448fde1fca2d682a6361b639c4204b9
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:03 2010 +0000
distribute: Respect end-of-dir on readdir only for last subvol
We need to ensure that only the last subvolume's end-of-directory
notification is respected so that directory reading does not stop
before all subvolumes have been read. That could happen because the
posix for each subvolume sends a ENOENT on end-of-directory but in
distribute we're not concerned only with a posix's view of the
directory but the aggregated namespace' view of the directory,
which is maintained by distribute.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit 59211ae4161fd7360c379f0eeccb59fc541f7a36
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:02 2010 +0000
distribute: Return pre/post-parent on successful unlink
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit 44d8a4a2b10c8357a084f3e8b6cbc73ec56626a2
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:01 2010 +0000
distribute: Return ino from the first-up subvolume in lookup
Not returning this from the first-up subvolume results in
different inode numbers being returned for a directory
when the same directory is read again through the NFS
readdir request.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit e1baa1b4c77170238187a9badfdf66856d17e5b6
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:00 2010 +0000
replicate: Use link's parent ino for post/pre-parent not target dir's
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit c7a29510e542da62a92dda1646061882f798de45
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:59 2010 +0000
replicate: Restore parent ino from saved inode number
Not doing this was resulting in a 0 inode number being returned
in postparent on lookup, which in turn results in a ESTALE at
the NFS client since an inode number change was observed.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit 5e935da9d32b0c04eb0cc5b8185f01a752ddf8df
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:58 2010 +0000
trace: Display op_errno even on successful readv
..this helps to show an op_errno that might contain
an ENOENT sent from posix. Remember posix now sends
and ENOENT even with an op_ret == 0 when reading
encountered an end-of-file.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 473 (Trace misreporting pre/post attributes for setattr.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=473
commit 12b6af1a432b30ccc0ed1162f3adc3cce1f8e117
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:57 2010 +0000
trace: Do not print results on failed readlink
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 473 (Trace misreporting pre/post attributes for setattr.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=473
commit 9d0792527e6dfb8a62107fd60581169158bbd854
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:56 2010 +0000
trace: Print st_dev for struct stat
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 473 (Trace misreporting pre/post attributes for setattr.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=473
commit b22c44281855a335ac0a3a66c309b7c8c0fca872
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:55 2010 +0000
trace: Support new option: force-log-level
trace has till now forced the log level to be set to
NORMAL. This masks other log output that we might need
to observed in combination with the trace output. This
new option allows us to force the log-level to something
other than NORMAL.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 168 (trace does not output debug messages)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=168
commit f7e2ef940c30fbabdaf3dcab7381f990cf052a45
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:54 2010 +0000
trace: Print correct variable in lookup_cbk
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 473 (Trace misreporting pre/post attributes for setattr.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=473
commit 745eb8de945d96f6adb4456310ab02b74d3e7ef5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:53 2010 +0000
trace: Do not clobber own itable
.. as it could've been assigned by our parent such as server or nfs.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 473 (Trace misreporting pre/post attributes for setattr.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=473
commit 75d7ca2dbd45480132efa2478b8e2dd202cb7cd3
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Mar 3 11:50:23 2010 +0000
core: Provide helper macro to set [ug]id in frame
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 400 (Support auxiliary gids in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=400
commit de809f8295dd6b18f60e0ee1c1c06ee3d04aa561
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:51 2010 +0000
core: Add NULL check for inode in fd_lookup
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit 2e7ad2b9e368017d665ec1f62014fe87b4b384b1
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:49 2010 +0000
core: Add setattr mode test macros
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit b2ecc9a72c81d0438e6c9c7879acb3462392b4c7
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:48 2010 +0000
core: New function: gf_dirent_for_namelen
Given the length of a name that needs to be stored in d_name, the
new function allocates enough space for a gf_dirent_t and
returns a ref.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit 865446575b6cb705fd38a4e60937b42d9a3ea423
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:47 2010 +0000
posix: Support EOF for file reading
This is a small hack to notify higher translators that an end-of-file
was encountered at the end of the readv operation. This is helpful
in determining end-of-file without sending another readv fop.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit 6a4f55db2afccb75da3a38f54405babe3860fbbe
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:46 2010 +0000
posix: Support end-of-stream determination
state, higher translators do not need to perform another readdir
to determine end of stream. Instead, if a successful directory
read operation is accompanied with an op_errno=ENOENT, it means
end-of-stream on the directory fd_t.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit a7ac00170137ed3c933d17d2d37f37f2ebe82137
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:37:45 2010 +0000
iobuf: Expose macros and create new ones
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 597 (miscellaneous fixes for xlators to work well with NFS xlator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=597
commit bbeef3a1f28a339ee0cdf94ac99fb3474322ae7e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Mar 3 02:14:37 2010 +0000
transport/socket: fix to valid_ipv6_address.
- while checking for hexadecimal numbers, strtol on valid strings of
hexadecimal numbers will return a NULL string in endptr (but not a
NULL endptr). Thanks to Donald Neal <dmneal@wand.net.nz>, for pointing
this out.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 693 (glusterfs 3.0.2 will not listen on IPv6 address)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=693
commit 26240b5e79ee280eb12d40e2d0abeda10829660b
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Mar 1 17:47:06 2010 +0000
cluster/afr: Failover readdir calls.
This patch makes the replicate readdir call fail over to the next
subvolume if the first call fails. It takes care to ensure that
entries are not duplicated.
The failover behavior of readdir only comes into effect if
the option 'strict-readdir' is on.
Signed-off-by: Vikas Gorur <vikas@dev.gluster.com>
Signed-off-by: root <root@client02.(none)>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 453 (afr_readdir does not fail over)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=453
commit 594fd23327ef1afac2cb5e0c42d5cc3163905c75
Author: Anand Avati <avati@gluster.com>
Date: Thu Mar 4 04:00:53 2010 +0000
io-stats: new counters
Add new counters and statistics for:
a) total read data - since process start, last interval and per fd
b) total write data - since process start, last interval and per fd
c) counts of read IO block size - since process start, last interval and per fd
d) counts of write IO block size - since process start, last interval and per fd
e) counts of all FOP types passing through it
Usage:
1. For dumping global stats
sh# setfattr -n io-stats-dump /tmp/filename /mnt/gluster
2. For enabling per-fd stats
option dump-fd-stats on
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 268 (Add timing instrumentation code)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=268
commit 5a58ae2c336e03bfba642ce4bd5c798c3c0c2d27
Author: Anand Avati <avati@gluster.com>
Date: Thu Mar 4 03:59:55 2010 +0000
io-stats: indentation fixes
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 268 (Add timing instrumentation code)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=268
commit 6932a32b3ee53de520c63d58e800c609d6562bed
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Mar 3 12:52:01 2010 +0000
libglusterfs: Copy va_list types using va_copy instead of memcpy.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 621 (3.0.2 GlusterFS fails on Solaris 10)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=621
commit 0a18543c43129edf43501e86a6c05dd8fa119b83
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Mar 2 07:20:31 2010 +0000
posix: gen number fixes on non-Linux systems
Most non-Linux platforms do not support extended attributes on special
files and symlinks. Use the mtime as the generation number for these
files on such systems
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 621 (3.0.2 GlusterFS fails on Solaris 10)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=621
commit d907c67901231a3c57ec670d08b4745db2b07792
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Mar 2 03:45:26 2010 +0000
features/quota: Remember '/' loc_t to initiate xattr calls.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 685 (writing to a file fails complaining of "Transport endpoint not being connected")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=685
commit 99abaec98f06d045aacde866db099413b1f75007
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Feb 25 15:38:11 2010 +0000
socket: Add NULL check for failed ioq entry allocation
This is seen in OOM situations.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 679 (Crash in socket_ioq_new)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=679
commit 26a7b439e410fa7945818d4d1f3bcd0b724be99a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Feb 25 05:17:02 2010 +0000
features/quota: store the entire vector in local instead of just a pointer to it in writev.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 685 (writing to a file fails complaining of "Transport endpoint not being connected")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=685
commit d9f0f33907196902f7c1c1710175f70b647c8fe4
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Tue Mar 2 03:46:34 2010 +0000
local->failed set to one twice
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 690 (local->failed set twice)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=690
commit 90bf843c5a7f4effcdc329dcc8ae28adbc06c2f5
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Mar 1 03:14:39 2010 +0000
stripe read fix (when read() is done on a sparse file over glusterfs)
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 536 (fsx tool fails over stripe)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=536
commit 03949f4fb7406b2c1ac47bf9572b8f7054158414
Author: Anand Avati <avati@gluster.com>
Date: Sat Feb 27 07:00:10 2010 +0000
io-threads: more fixes
* conditional for scaling up threads was wrong
* ETIMEDOUT check was performed wrongly
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 583 (filesystem access hangs while deleting large files)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=583
commit f50f2e3df9833c53b1d835ba8d7122d3b98011a7
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Feb 23 13:50:25 2010 +0000
storage/posix: Don't use FTW_CONTINUE
FTW_CONTINUE is not defined on Mac, and POSIX only specifies
that the walker function must return 0. So just return 0.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 625 (Gluster Fails to build on OS X 10.6.2)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=625
commit d180f3ec6c641b9708085ffe65fa4d93500bee84
Author: Anand Avati <avati@gluster.com>
Date: Tue Feb 23 02:52:46 2010 +0000
dht: fix READDIR semantics which got broken in 512dcad823feb199d78f5b66a09bc404ccb899e8
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 584 (automatically configure 'lookup-unhashed' option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=584
commit 2c2b465be2eb57b10b7d06efffdb764038e007b0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Feb 22 23:59:05 2010 +0000
performance/write-behind: fix data corruption while aggregating the adjacent contiguous iobufs into a single iobuf
- while aggregating, we should make sure that the destination has enough
memory. __wb_collapse_write_bufs assumed that destination vector's iov_base
was aligned to the start of an iobuf and hence memory of page_size is
available for aggregation. This assumption is not always true, like in the
configuration consisting afr->write->io-cache (afr is on top). Refer to the
bug url for more details.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 542 (write-behind crashes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=542
commit 2b2d4b1cf19f05492bdb4e5cc54b7b4e61789839
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Feb 22 23:58:35 2010 +0000
performance/write-behind: refactor __wb_collapse_write_bufs
- refactor done to remove duplicated code.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 542 (write-behind crashes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=542
commit 7f72a3c0a8444bf62bc045256fcefad3e3340619
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Feb 23 01:27:21 2010 +0000
performance/io-cache: set path in local during lookup.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 570 (Cache only those files whose sizes falls under a configured window size)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=570
commit a878349cae7345a617c4c3656f43bf05f7630543
Author: Anand Avati <avati@gluster.com>
Date: Mon Feb 22 11:00:20 2010 +0000
io-threads: single queue/multi-thread model
This patch lets io-threads work with a single queue and multiple
threads work on picking the next request from the queue and process
it.
Whenever the number of pending requests in the queue double, a new
worker thread is spawned.
Workers expire after a (configurable) timeout of inactivity
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 583 (filesystem access hangs while deleting large files)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=583
commit eb54146363643f77fb0031f406e2c5d70eef44a4
Author: Anand Avati <avati@gluster.com>
Date: Mon Feb 22 10:59:40 2010 +0000
common-utils: gf_log2 handles 0 input
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 583 (filesystem access hangs while deleting large files)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=583
commit ccf2222dcf47ef53936aefd6aa06ffa34b5ee573
Author: Anand Avati <avati@gluster.com>
Date: Mon Feb 22 09:23:13 2010 +0000
dht: fix leak introduced in 137f94ed123b1c7c7ada541aaa599679e19888f6
dht_layout_t was getting leaked in dht_readdirp_cbk when dht_layout_get
was called but was not unref'ed
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 584 (automatically configure 'lookup-unhashed' option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=584
commit dea63fb550e4bea8bcf1e9aac5cef24e8c232b33
Author: Anand Avati <avati@gluster.com>
Date: Mon Feb 22 08:59:10 2010 +0000
dht: unlink stale linkfiles in rmdir to prevent ENOTEMPTY
Thanks to He Xaobing <allreol@gmail.com>, this patch is inspired by
http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=188#c2
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 188 ([ glusterfs 2.0.6rc2 ] - "Directory not empty" on rm -rf)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=188
commit cf63d7567cf08938bba915ee89b39cc0d56d823a
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Feb 22 05:17:28 2010 +0000
storage/posix: Check for path before logging it in case of an error in xattrop FOP.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 614 (GlusterFS crashes while printing error if fsetxattr call fails in posix)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=614
commit e5e8fb6c9a034458b756970db0cb440050b26371
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Feb 22 05:01:00 2010 +0000
features/quota: Changes in arguments in STACK_UNWINDs for most FOPs.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 569 (Memory leak in quota translator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=569
commit 4b6e5e71a48c6f1ba8728b86840d672c2c2301d9
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Feb 22 05:00:01 2010 +0000
features/quota: Fix memory leak while syncing disk usage.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 569 (Memory leak in quota translator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=569
commit 660c3e34093e11d2c41a725f39e02573e94151d0
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Mon Feb 22 04:39:26 2010 +0000
Add new gf_strstr dropin replacement for "strstr"
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 609 (Add new "conf-dir" option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=609
commit 2ea667593e3f6c5a2f8e0cb0d67f2e19760cd12a
Author: Anand Avati <avati@gluster.com>
Date: Mon Feb 22 04:28:07 2010 +0000
inode: guard against possible infinite loops
Check to prevent accidental linkage of inodes with inode number 1.
Such links will result in loop formation in the inode table.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 537 (infinite loop in inode_path ())
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=537
commit b8cf754955c306cffb388dcc976656012a0f14af
Author: Anand Avati <avati@gluster.com>
Date: Mon Feb 22 03:42:04 2010 +0000
protocol/client: better pointer check on saved_frames mapping in ping timer
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 434 (Crash with 3.0.0pre2 on client01 with "metarates" parallel MPI metadata benchmark)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=434
commit 07f2cf6b092b73f1b674e11a46ac7d8c1d958097
Author: Anand Avati <avati@gluster.com>
Date: Mon Feb 22 02:52:31 2010 +0000
protocol/client: add memory allocation checks
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 431 (segfault in timer thread :O)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=431
commit 2e865c47375d92490b23edacbf6191d221069e8f
Author: Csaba Henk <csaba@gluster.com>
Date: Sat Feb 20 18:53:38 2010 +0000
fuse: bring over recent mounting code changes from libfuse upstream
Following commits were ported (commit ids as of
http://git.gluster.com/?p=users/csaba/fuse.git
repo):
commit 06fe3eb9c864b69bea98600c0a7eab7b63834735
Author: mszeredi <mszeredi>
Date: Thu Feb 18 11:05:12 2010 +0000
* Fix stack alignment for clone()
ChangeLog | 4 ++++
include/fuse_lowlevel.h | 1 +
util/fusermount.c | 9 ++++-----
3 files changed, 9 insertions(+), 5 deletions(-)
commit dfe1aab6520d70d72d36edf0508fef9a865daa5f
Author: mszeredi <mszeredi>
Date: Tue Jan 26 18:20:12 2010 +0000
* Fix race if two "fusermount -u" instances are run in parallel.
Reported by Dan Rosenberg
* Make sure that the path to be unmounted doesn't refer to a
symlink
ChangeLog | 8 +
lib/mount.c | 2 +-
lib/mount_util.c | 31 +++--
lib/mount_util.h | 3 +-
util/fusermount.c | 380 +++++++++++++++++++++++++++++++++++++++++++++--------
5 files changed, 351 insertions(+), 73 deletions(-)
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 657 (Metabug for tracking fuse upstream)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=657
commit 96b1785d990b24964c28eaf087ed46a713179e84
Author: Raghavendra Bhat <raghavendrabhat@gluster.com>
Date: Sat Feb 20 06:06:19 2010 +0000
fuse: check the return value of pthread_cond_timedwait before logging in fuse_thread_proc
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 650 (log message says "pthread_cond_timedout returned nonzero value" even when the return value is zero)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=650
commit 8a4393e92255c8f9aa31331c72d8d9de761ba143
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Thu Feb 11 10:29:11 2010 +0000
Support new option "conf-dir"
Addresses fetching volume files from a non standard directory right
now it is hardcoded to "CONFDIR" which is build time constant.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 609 (Add new "conf-dir" option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=609
commit ff6385a0eae344b304bae2c9c45cb2521fca5338
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Feb 14 09:28:34 2010 +0000
cluster/stripe: Set op_ret as failure if inode is not being set in lookup cbk
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 560 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=560
commit 90d965813cf9747ccc78211e7d74da8c90df076a
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Thu Feb 18 09:41:17 2010 +0000
Add quota support to volgen
New options on command line
1. --volume-size-server - Volume sizes for server side posix exports
2. --volume-size-client - Volume sizes for client side exports
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 611 (Add quota support to volgen)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=611
commit ed4f9cb84d20556297decbb84f4a94ab0fa264a2
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Wed Feb 17 06:36:28 2010 +0000
Remove dns lookup issued for each hostnames.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 563 (glusterfs-volgen: can't handle multiple network interfaces)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=563
commit 2eb1bff2eef00522a8366f93017750b0aad2cf9e
Author: Anand Avati <avati@gluster.com>
Date: Thu Feb 18 10:28:06 2010 +0000
server_writev: add proper iobuf into iobref
this typo results in corruption when write-behind is loaded on server side
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 639 (Data corruption with write-behind on server side)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=639
commit 5b31053b23de8a65950f7624a5d648159bb271de
Author: Pavan Sondur <pavan@gluster.com>
Date: Fri Feb 12 04:08:03 2010 +0000
features/locks: Set dummy fd ctx in all relevant places so that release callback in locks is always called.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 449 (Handle flock calls in a different domain from fcntl calls)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=449
commit e32ba6e6914bea8b47f89acca6ab9a295b15a6ce
Author: Anand Avati <avati@gluster.com>
Date: Sun Feb 7 04:30:20 2010 +0000
dht: Remove pointer casting in layout handling
Small changes by Anand Avati <avati@gluster.com> over original submission:
Remove pointer casting (copy data to proper memory before using it). Fixes bug #493.
Hello,
See bug #493 for more information on this patch.
http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=493#c2
This patch assumes that the scope of disk_layout is local wherever it is
used. Seems correct, not really checked, though.
Greetings,
Hraban Luyat
Signed-off-by: Hraban Luyat <hraban@0brg.net>
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 493 (tcp + dht + armv5tel: ???brick: disk layout has invalid count 29696???)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=493
commit 22dcb1f50e299bf6df10920d0a13652557b7b9f3
Author: Hraban Luyat <hraban@0brg.net>
Date: Mon Dec 21 01:29:46 2009 +0000
Fix memory access in afr's self-heal code (replace pointer casts by memcpy).
The previous patch I submitted for this file (afr's self-heal code)
introduced a terrible error. I overlooked the error checking in the
original code and misplaced the memcpy (too early).
So, please disregard the last one, this one is better :) hopefully.
Apologies.
Signed-off-by: Hraban Luyat <hraban@0brg.net>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 493 (tcp + dht + armv5tel: “brick: disk layout has invalid count 29696”)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=493
commit 8d354f8b9183bc4b1e7a2296b5043e73534eb6ef
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Feb 5 01:38:29 2010 +0000
'lookup-unhashed' option of distribute should be 'auto' by default.
* Added 'auto' option, older boolean options works as they used to.
* This option should make 'create' rate faster, also handles
self-healing of linkfile properly in case of scaling to
more servers or filesystem is getting full.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 584 (automatically configure 'lookup-unhashed' option)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=584
commit df784e929ac30549ee90f9c7690b85234bb2e45a
Author: Anand Avati <avati@gluster.com>
Date: Fri Feb 5 05:00:20 2010 +0000
Fixes for MacOSX and Solaris build
Fixes for Solaris and MacOSX build errors.
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 481 (Fix compilation failures in Solaris)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=481
commit 1fc8ff9a80def383a908fd38c564036225ce104c
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Feb 1 07:31:40 2010 +0000
cluster/dht: Remove linkfile before unlinking the datafile.
dht_unlink: If a linkfile exists, remove it first before attempting
to remove the datafile. This eliminates the case where dht would
end up with the linkfile intact and the datafile gone, and the user
not being able to remove the linkfile.
Thanks to He Xiaobin <allreol@gmail.com> for debugging this
issue.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 188 ([ glusterfs 2.0.6rc2 ] - "Directory not empty" on rm -rf)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=188
commit 1ea6486087cf1601fc2f2de396e803d33a81f105
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Feb 2 06:51:15 2010 +0000
storage/posix: Set op_ret to -1 when open fails.
Thanks to Jeff Darcy <jdarcy@redhat.com> for
the bug report and the patch.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 581 (posix_open does not report open(2) failures correctly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=581
commit 0bf15b27e7ed7d7015a51a8c6829875e5676dd72
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Jan 29 03:26:12 2010 +0000
performance/write-behind: Set right an incorrect message displayed in log
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 579 (write-behind cache-size less than 128KB leads to error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=579
commit e1abc2befe33e10f3789014c48a15628c37f131d
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Jan 28 08:24:23 2010 +0000
cluster/dht: Check for size 0 in check_is_linkfile()
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 574 (Sticky bit files are not listed in the output of ls on a dht volume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=574
commit 191096db3a6f48c9b6dfd80137164aad94715633
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Jan 27 07:19:43 2010 +0000
transport/socket: guess an appropriate address family when it is not specified in configuration.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 561 (with address family set to 'inet-sdp', transport/socket doesn't work correctly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=561
commit 533b97befebc3e5ad04ea027e6c4130db00792b7
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jan 28 06:55:05 2010 +0000
storage/posix: Fix device number handling.
There are two fixes in this patch:
1) If the device number has changed, do a fresh stat on the export
directory and if it matches the device number of the file,
assume a remount happened and remember the new device number
as official (this helps automounted export volumes).
2) Don't log the "device number changed" message if it is due
to a stat on ".." (in posix_readdirp), as it could be because
".." leads us out of the exported volume.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 576 (crossing device (2056) + fuse LOOKUP error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=576
commit 4c3333471d6005c61372a8718ba41f4f84b89e57
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Tue Jan 26 09:06:18 2010 +0000
Revert "Server backend storage hang should not cause the mount point to hang."
This reverts commit a0b148ea4e2a0163548eeb89b7580be4adbb8070.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 272 (Server backend storage hang should not cause the mount point to hang)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=272
commit d8cfdea71622ea0dd2657472c591bd462f313116
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Tue Jan 26 03:43:15 2010 +0000
Fix fetching volume file from the server, by sending parent up through the xlator graph.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 573 (3.0.1 doesn't fetch volfume files from the server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=573
commit 2b1033553c4f4929c3f242082fa9f18f35a4d150
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Jan 25 07:02:45 2010 +0000
mount/fuse: Fix file type checking.
This patch fixes two things:
- Check for symlinks and set d_type appropriately
- Use S_IS* macros for checking.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 571 (find -type l ignores symlinks on GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=571
commit a11fb3074e73b913f6171d64d2b8dbcff1e65c45
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Jan 25 05:59:28 2010 +0000
storage/posix: Fix an access-after-free bug in release() and releasedir().
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 533 (close() should not block main loop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=533
commit e5135109f0eac55d20385ab079b34f3e35b5b021
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Jan 25 05:43:24 2010 +0000
performance/io-cache: cache only those files whose size falls under configured window.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 570 (Cache only those files whose sizes falls under a configured window size)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=570
commit 01928269b5edc0ff1e3db1e4a5b38faa40f1e979
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Mon Jan 25 05:09:40 2010 +0000
Fix occurence of cache-size being floating point
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 516 (cache-size should not be hard-coded to 1GB)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=516
commit b13b4773b0c357ebbb85d0f0adf72a64c293a05e
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 17:37:38 2010 +0000
protocol/client: timeout tweaks
* option frame-timeout 0 now means no frame timeout
* option ping-timeout 0 now means no ping timeout
* extended frame-timeout range from 0 to 1 day
* extended ping-timeout range from 1
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 450 (frame-timeout range should be higher)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=450
BUG: 423 (Disable protocol timeout)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=423
commit a7611b185ef6c2b83f8943d198347da179e5b135
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 16:52:48 2010 +0000
trace: multiple fixes
Jeff Darcy <jdarcy@redhat.com>
Jeff Darcy <jdarcy@redhat.com>
- whitespace and indentation cleanup
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 168 (trace does not output debug messages)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=168
BUG: 473 (Trace misreporting pre/post attributes for setattr.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=473
BUG: 519 (Possible SEGV when tracing readlink)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=519
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 6cefa6172a44b019fb4c44a7673aa4927d58b3b8
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 15:18:21 2010 +0000
protocol/server: unlink dentry only for non-root inodes
in server_lookup_cbk, unlink dentry from the crash on receiving
ENOENT from subvolume only for non-root inode. ENOENT can be returned
for root inode if export directory is deleted
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 526 (glusterfsd crash when export dir is deleted and revalidate happens on /)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=526
commit df4a2a4378becf7f651de7991152cf173c61310b
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 14:49:05 2010 +0000
write-behind: fix 'option enable-trickling-writes'
fix logic in __wb_mark_winds to properly initialize incomplete_writes
and conditionally check based on enable_trickling_writes flag
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 547 (write-behind enable-trickling-writes working?)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=547
commit 9865156c960686e86d6a61fc4b6f7b452197ccbe
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Dec 23 15:06:38 2009 +0000
booster/fcntl: implement F_GETFD and F_SETFD.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 446 (apache does not start in daemon mode on fedora core 11.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=446
commit 4cd70246045e0c01f91fd263ca780831192b326a
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 13:26:39 2010 +0000
dht: initialize layout type
Instead of relying on CALLOC's zero initialization which happens
to be the value of DHT_HASH_TYPE_DM, explicitly set the value
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 523 (Hash type is not initialized in dht_layout_new)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=523
commit 44dd485ffb8e267a04fae4aaa3beb6ead4e9fbe0
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Jan 23 12:53:56 2010 +0000
protocol/client: Look only for op_ret while handling a setvolume response.
op_errno should not be looked up to stop processing setvolume_cbk().
This fixes the problem of 3.0.x clients crashing if they attempt to
connect to 2.0.x servers.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 564 (3.0.1rc3 server daemon crashes when any of the 2.0.x version client connects)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=564
commit 2720fa72c62f92d8c434f2c85e5565440ed27aa4
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 07:03:08 2010 +0000
error-gen: change all STACK_UNWIND calls to STACK_UNWIND_STRICT
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit a625433415073e16bd2ca1e070ecb4a2315d5869
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 07:02:35 2010 +0000
error-gen: unwind fsync with proper parameters
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 553 (server crashed in server_fsync_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=553
commit 80aa75751118bba66c6fe32b47e8299649bbdead
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 05:14:49 2010 +0000
protocol/server: cleanup whitespaces
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 272 (Server backend storage hang should not cause the mount point to hang)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=272
commit 3c6dc8fde2fbec3743c3a21f7670fc4f8e526f05
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 05:14:31 2010 +0000
Server backend storage hang should not cause the mount point to hang.
Submitted-by: Krishna Srinivas <krishna@gluster.com>
NOTE: fixed compilation issues in posix.c introduced while merging
storage/posix polls for FS/kernel being functional by issuing
statvfs() call. In case statvfs expires the timer, storage/posix will
send CHILD_DOWN to upper translator. Ultimately this will cause
protocol/server to disconnect all clients connected and also cleans up
the data structures. Hence if soft lockup or other kernel bug causes
backend FS to hang, the clients will not be hung.
Signed-off-by: Krishna Srinivas <krishna@gluster.com>
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 272 (Server backend storage hang should not cause the mount point to hang)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=272
commit e62d371c339d6c3b48d0c2c577bcd0acacc1db45
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 05:13:24 2010 +0000
core: fix initialization of disjoint xlator graph
if graph has disjoint subgraphs, send GF_EVENT_PARENT_UP to every top node
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 272 (Server backend storage hang should not cause the mount point to hang)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=272
commit 6bb5a4459b824abcc150dbebf21a6f5924d1ca0b
Author: Anand Avati <avati@gluster.com>
Date: Sat Jan 23 00:46:16 2010 +0000
protocol/server: handle group id decoding in a stricter way
This causes crash between 3.0.x servers and 2.0.x clients
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 564 (3.0.1rc3 server daemon crashes when any of the 2.0.x version client connects)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=564
commit 2ba85d24fac2e445681f4cd1ccd19c8b898b5674
Author: Anand Avati <avati@gluster.com>
Date: Fri Jan 22 08:53:49 2010 +0000
transport: set proper reference counts on peer_trans for local connections
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 562 (crash resulting from bad refs in transport_setpeer)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=562
commit 63bccb013b66f6e79674f50de69dc83953b86495
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Jan 22 03:02:32 2010 +0000
transport/socket: use appropriate address family macro when address family is inet-sdp.
- sa_family should be set to AF_INET_SDP only during call to socket system
call. For all other calls, sa_family should be AF_INET.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 561 (with address family set to 'inet-sdp', transport/socket doesn't work correctly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=561
commit 72324ede029499c4f965929ace7c2898a8389aaa
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Thu Jan 21 05:36:42 2010 +0000
Cache size is now dynamic and is 20% of the total memory on the client side.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 516 (cache-size should not be hard-coded to 1GB)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=516
commit d327fcc8873f0eec90b4d1345fec93980641b2bf
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jan 21 07:28:59 2010 +0000
cluster/afr: Send the struct flock returned by the server to the user.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 521 (SPECFS validation fails over distribute + replicate)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=521
commit 7dd19328ebbf5977e5406e1f069c33bce2e7ebb9
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jan 21 06:46:25 2010 +0000
storage/posix: Make the janitor sleep duration configurable.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 533 (close() should not block main loop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=533
commit 421f3e0f79455af41401cacbf511d9c80e817605
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Jan 19 08:11:05 2010 +0000
extras: Add defrag scripts to the repository
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 478 (Add defrag scripts into glusterfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=478
commit 990b7e35624fe7243f81ace5773475751602fdf0
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Jan 15 06:59:00 2010 +0000
storage/posix: Hand off calling close() and closedir() to the janitor thread.
Let the janitor thread handle calling close() and closedir() on fd's and DIR *
when posix_release is called. This avoids blocking the main server loop
due to close().
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 533 (close() should not block main loop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=533
commit 9ddff37dfdb18cf1e62153942351fddae259e861
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jan 12 13:21:59 2010 +0000
stripe entry self heal
Create the entry (either regular file or directory), when its
missing in some of the subvolumes and available on some.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 535 (stripe entry self-heal..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=535
commit f19dc7e68833d9ad9567aa22c0fbd172107b12e6
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Dec 30 21:45:20 2009 +0000
default log file now doesn't start with '-'
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 490 (Default log file path should not begin with '-')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=490
commit 676250fdea4455c31c91f2c0832c448fb971261a
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Jan 12 04:14:25 2010 +0000
cluster/afr: Pick a source for metadata self-heal even if all nodes are innocent.
If metadata changelog has been disabled, all subvolumes
will be innocent. In that case, simply pick the subvolume
on which the file has the lowest uid as the source and
sync other subvolumes to it.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 451 (metadata self-heal does not a pick a source if mode/times have been changed at the backend)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=451
commit 86a37b79d01cbc79ec7da86254a26b0327a84c17
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Jan 12 17:47:25 2010 +0000
libglusterfsclient/readv: fix data corruption.
- libgf_client_readv should return the total number of bytes read by
multiple invocations of libgf_client_iobuf_readv, instead of return value
of last invocation.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 531 (accessing a file through apache results in Permission denied errors.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=531
commit f80403f9e8d16fc9dfe900d1fb13068c72b5d199
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Jan 6 20:18:47 2010 +0000
cluster/unify: don't call xl_init_tree on namespace node.
- just before xl_init_tree call on namespace, unify node is set as parent of
namespace node and since xl->ready of unify node is set only after return
from init call, calling xl_init_tree on namespace node will result in
execution of init of unify node for the second time. This results in
following bugs:
* since during second execution, parent of namespace node is unify, init of
unify xlator fails.
* even if init did not fail, re-execution of init in itself is bad, since it
results in memory leaks etc. Worse, it can result in infinite recursive
calls into init of unify node.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 518 (unify does not start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=518
commit 2f77b494bc7ba807defa9424d3e1afb2932ea6d6
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Jan 11 01:20:21 2010 +0000
features/locks: Fix broken interface grant_blocked_inode_locks
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 496 (deadlock in pl_inode_setlk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=496
commit 631238e89a0f2145e54433bd1fda4a35cfa1ed9a
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Jan 11 01:19:05 2010 +0000
features/locks: Do not call grant blocked locks in pl_forget
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 496 (deadlock in pl_inode_setlk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=496
commit ef59125452b284f440c320478147c2de7c48d498
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jan 12 03:57:42 2010 +0000
fuse: treat DESTROY message as proto requires, ie. don't leave it unanswered
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 1ea75f0f5eb991dad2c21665cca33792804d119b
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Jan 8 12:22:45 2010 +0000
transport/socket: Enable NODELAY even if no option is set.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 524 (TCP_NODELAY not set when expected on client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=524
commit 36398385dd3e7dce45f4630935da4ea8335c33ab
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Dec 24 12:10:09 2009 +0000
libglusterfs/inode: add NULL checks.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 510 (crash in inode_ref)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=510
commit 23c482eb5ea5584f1f2cb0b51b4357863c173138
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jan 7 05:17:17 2010 +0000
cluster/afr: Use dict_ref instead of dict_copy_with_ref.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 509 (Crash in afr_local_cleanup ())
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=509
commit 8d2cc9b7a299db76243a98ff73dddb1a099788cb
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jan 5 07:19:40 2010 +0000
fuse: fix memleak
continuing the work of d281971e
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 438 (Memory leak)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=438
commit 61be74de8edc997cc39a174b9ba9770bda879868
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Dec 24 06:59:44 2009 +0000
fuse: add mtab entry asynchronously
Instead of taking libfuse's approach to the bug referred
-- making use of an ad-hoc mount option --, we get over
the issue by not waiting for mtab manipulation to complete.
If mtab manipulation happens to fail for some reason, just
log an error message (instead of aborting the mount).
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 511 (mount hangs with some audit configurations)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=511
commit 8fa5e866a3e16a0e5163a7b0fa280505d59a637e
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Dec 24 05:30:42 2009 +0000
storage/posix: Zero out the checksum array in rchecksum.
Set the checksum bytes to zero to ensure random junk
is not returned as the checksum.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit 2ffe6ece9db54f5cf54b679e5a41d777039a19f0
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Dec 28 06:07:48 2009 +0000
cluster/afr: Allocate diff algorithm loop_state structures only once.
Instead of CALLOC'ing a loop_state structure at the beginning
of every loop, keep a table of allocated structures and reuse
them.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit 337af803acffb64f9fad392f0709353a6d5ccc36
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Dec 24 05:30:40 2009 +0000
cluster/afr: Report number of blocks healed during diff self-heal.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit bc08cf86988791e98e3282f997fd4e667c5e923f
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Dec 24 05:11:40 2009 +0000
protocol/client: Fail revalidate with ESTALE.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 90ac453f24d9da951e1a1a1e55ab40ad3f78e4a3
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Dec 22 01:53:33 2009 +0000
properly ref/unref fd in stripe_opendir_cbk
fixes the crash due to dereferencing NULL fd pointer
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 497 (Client crashes in fuse_fd_cbk while running ltp tests)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=497
commit 939155d7825a063b50a3586f5b2921aba3608da9
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Dec 21 04:30:04 2009 +0000
features/locks: Unwind if inode is NULL to prevent 'lost' frame.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 222 (Enhance Internal locks to support multilple domains and rewrite inodelks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=222
commit 2ad485a2b8db22073470e8a58a1e55016317be88
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Dec 18 12:38:04 2009 +0000
Support for Compilation on Solaris
This is based on patch at:
http://node3.rnode.ru/glusterfs-3.0.0-p1.patch
Thanks to Petrunin Egor <shellcode@mail.ru> for this patch.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 481 (Fix compilation failures in Solaris)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=481
commit 97e2c07729e28c2f6498a2f210935343d8c99cf2
Author: Hraban Luyat <hraban@0brg.net>
Date: Sat Dec 19 15:47:25 2009 +0000
More robust dictionary (un)serialization (fixes bug #397).
Hello,
This patch fixes bug 397: dictionary (de)serialization used pointer
casting which forced word-alignment on (at least) armv5tel, causing
corruption while writing and reading buffers into memory. It also adds
some debugging (more information in case of errors).
I tried to send this a few times already but I think it got bounced from
the list.
Greetings,
Hraban Luyat
Signed-off-by: Hraban Luyat <hraban@0brg.net>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 397 (dictionary serialization / deserialization fails on armv5tel)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=397
commit 1cbfc54c5efd00153f10dfa11ee057a10b453830
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Dec 18 07:51:12 2009 +0000
fuse-bridge: Don't try to fill a loc in setattr when we can proceed on with an fd.
This fixes broken ftruncate on unlinked files.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 472 (OpenOffice fails on GlusterFS $HOME due to fuse_loc_fill error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=472
commit c6dc7649f0de9fd806ffe12a79962a9cec734935
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Dec 18 07:49:43 2009 +0000
fix typo in configure.ac
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit afa3d6537ae9c9857079e36b970ea14dd9ff5e85
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Dec 18 07:06:27 2009 +0000
distribute: Dont dereference sbuf on failed readlink_cbk
This fixes a crash that was caused due to a NULL pointer deref
because a NULL sbuf is returned if the readlink fop fails.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 492 (distribute crashes in readlink)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=492
commit 9d802e7a3455775b8037f4fe1bc900fbcba45cd3
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Thu Dec 17 15:41:21 2009 +0000
Added null checks in "fini"
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 364 (Segfault in io-cache)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=364
commit 03e8a6583d5f6c96b3f682d4101ac3742ae81209
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Dec 16 19:09:16 2009 +0000
bug fixes in call-stub creation for {fsetattr, fxattrop}_cbk()
'wind' flag was set in case of 'unwind' stubs, causing wrong variables
to get free'd, causing process to segfault.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 483 (booster unfsd segfault)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=483
commit 228a96a571cfc5febb4bba3830597c303233d484
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Dec 16 00:48:16 2009 +0000
cluster/dht: Check for pointers before de-referencing in dht_stat_merge()
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 463 (Crash in dht_stat_merge ())
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=463
commit 4b379f30710e2f7971c44697b0196a8835474015
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Dec 14 17:59:15 2009 +0000
more cleanup in stripe stat structures
Removed few more 'fops' from stripe. More cleaner stat structure return.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 340 (Kernel Compilation fail in stripe)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=340
commit 88ffba98fa182fbedf5c1d0cf8d0dbb6cba494d5
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Dec 11 08:50:34 2009 +0000
fix typo in posix
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
commit 9ee803b6f07d7786ea5f686826f327d6351bbe19
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Dec 7 09:43:23 2009 +0000
Disable fusermount by default in the rpm spec file and remove bdb references.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 349 (FreeBSD compilation error (alloca.h).)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=349
commit 2a00d39d41a71381b50c9403cbf8dd51c4a4283c
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Dec 7 02:07:39 2009 +0000
Changed occurrences of Z Research to Gluster
Signed-off-by: Vijay Bellur <vijay@gluster.com>
commit c69ef617c72398b977866a40dc9b6011a1664e36
Author: Anand Avati <avati@gluster.com>
Date: Mon Dec 7 07:33:49 2009 +0000
resolver: include RESOLVE_EXACT type for failure case when inode not found
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 99c479297745ad644724d3eb329d2bb40b5ad283
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Dec 7 05:44:31 2009 +0000
cluster/afr: Sync the parent directory's mtime during missing entries self-heal.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 137 (Parent directory mtime not reset after a create in self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=137
commit 83e4236266b01b8f057e245da32ff55fb87755e5
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Dec 7 04:52:47 2009 +0000
cluster/afr: Don't do entry self-heal in the background.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 326 ([2.0.8rc9] Spurious self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=326
commit 81886f3107f728fe5b9aa0917625b0e53d55b999
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Dec 7 04:40:57 2009 +0000
cluster/afr: Hold inode lock on 0-infinity for a flush transaction.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 326 ([2.0.8rc9] Spurious self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=326
commit 5d4b26e59f82519b566df1d0bd655a0f1d7c3447
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Dec 6 21:18:53 2009 +0000
fix typo in 76d6f3fbe
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit 0ebf855663de305e87f6d15e6afa58cc21d3ae2a
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Sun Dec 6 21:16:12 2009 +0000
Save st_dev properly in stbuf.st_dev from the same subvolume.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 433 (Posix conformance test failed on 3.0.0pre2 (Dec 3) release)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=433
commit 899f2a2568723f7f3ab9ae4054925de7f228cb9c
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Dec 6 16:38:06 2009 +0000
removed every reference to BDB from configure.ac
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 343 (Placeholder bug for adding volgen into rpm, bdb makefile changes, etc)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=343
commit 319be517ba25e79af37dfa92c82bcf092b5eee72
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Sun Dec 6 13:51:03 2009 -0800
Revert "performance/write-behind: Changed default value of option disable-till to 0"
This reverts commit e6c35f74ff4a204cf016ebf201a2630b331f9434.
This commit is found to trigger spurious self heal by causing flush and writev to get
reordered. Reverting as a workaround.
commit 750194bdd97f67e02aaf6d197b6d7e8d08f37be1
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Dec 6 14:29:04 2009 +0000
fuse-bridge: set lk_owner to -1 for release forged flush.
Server would interpret 0 as a sign of us getting disconnected.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit 9e00ffd6b1a7db5668fa0e0d13624043678af3d3
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Dec 6 14:27:57 2009 +0000
fuse-bridge: make use of lock owner data in a protocol adherent way.
No need for pid fallback, for those cases where we use it,
it's always available.
It appears conditionally in read/write/truncate (related to mandatory
locking). There just get it for demonstrative purposes.
Discard it from release, there locking data exists only as a
portability hack, no use of it on Linux.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit d15cf31a55891281a05e6ad0d7f73c0deef21a4e
Author: Anand Avati <avati@gluster.com>
Date: Sun Dec 6 13:48:43 2009 +0000
resolver: handle resolutions of paths
support a new type of resolution where only the path is sent from the
client over the wire without inode/parent/generation numbers. this can
happen when cluster translators could not look up inodes on a server
and later when the server comes up applications issues operations on
the inode without a lookup (since they could be cd'ed inside). In these
cases the server makes the best attempt to resolve the path and perform
the fop on it
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 369774c2a2d13bbe11c18f16332ff33a18681ae2
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Sun Dec 6 11:34:07 2009 -0800
Revert "protocol/client: return ENOENT if inode context is missing"
This reverts commit 4439876a34f2e5d19db0d8b05ce7d7722c1c466f.
This revert is necessary for path handle resolution to work over the
protocol where client/server talk only with the path, without inode
or parent inode and generation numbers
commit 7c224c78daf64c49c089b9d53e7e64b341baa32c
Author: Pavan Sondur <pavan@gluster.com>
Date: Sun Dec 6 13:29:08 2009 +0000
features/locks: Implement release xlator callback.
This patch solves the lock bailout problem seen recently when autoconf tools were run. This is a workaround,
where 'flock' locks are removed in pl_release, if an explicit UNLCK call does not come. The complete fix would
be to allow 'fcntl' and 'flock' locks to operate in different domains.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 449 (Handle flock calls in a different domain from fcntl calls)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=449
commit 71ebe707664731ecc4e53b301d70339334e93079
Author: Anand Avati <avati@gluster.com>
Date: Sun Dec 6 13:06:18 2009 +0000
distribute: more cases of st_dev setting
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 433 (Posix conformance test failed on 3.0.0pre2 (Dec 3) release)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=433
commit 011631f29f41d736fed6f76b0906f20b50dd445d
Author: Anand Avati <avati@gluster.com>
Date: Sun Dec 6 12:47:25 2009 +0000
distribute: return st_dev from the same subvol from where itransform is performed
distribute should return st_dev from the same subvolume it itransforms the inode
number. this is to ensure that there will not be false replacements of inodes in
inode management
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 433 (Posix conformance test failed on 3.0.0pre2 (Dec 3) release)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=433
commit 91466f989b038aee8d2265f4e910ba22592325cc
Author: Anand Avati <avati@gluster.com>
Date: Sun Dec 6 12:46:14 2009 +0000
fuse-bridge: log cases where newer generation is found in table
This is usually the case when there is a bug a cluster xlator and returns
generation number from the wrong subvolume
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 433 (Posix conformance test failed on 3.0.0pre2 (Dec 3) release)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=433
commit 47d5105aea05cfbef2e3cffcc0bd47f722d141fd
Author: Pavan Sondur <pavan@gluster.com>
Date: Sun Dec 6 10:50:18 2009 +0000
features/locks: Disable mandatory locks, until we can use lock-owner field without problems in mandatory locking.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit fc3af7e0af3443d873c0b0d6242d40502b892351
Author: Pavan Sondur <pavan@gluster.com>
Date: Sun Dec 6 10:34:39 2009 +0000
features/locks: Correct the order of arguments and print a log message in pl_flush.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 306 (Enhance locks to aid debugging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=306
commit 652e54be852d3de9a1f307cb84e305b78f2d33de
Author: Anand Avati <avati@gluster.com>
Date: Sun Dec 6 07:42:30 2009 +0000
protocol/server: more fixes in server_link_cbk
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 448 (server_link_cbk refers to @inode when op_ret is -1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=448
commit 090d4c665e387cf989bfd675aec3c0fc2c0294f5
Author: Anand Avati <avati@gluster.com>
Date: Sun Dec 6 05:31:44 2009 +0000
THIS: set THIS pointers before forget/release/releasedir callbacks
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f073b383f95327d0b2cd07bb5097fb2ad741846e
Author: Anand Avati <avati@gluster.com>
Date: Sun Dec 6 04:45:17 2009 +0000
afr: fix fd ref leak in self-heal
sh->healing_fd should be ref'ed only when healing_fd_opened is not set
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit fedd03a0cee1c32bc63ab280be743d8b1cf39f42
Author: Anand Avati <avati@gluster.com>
Date: Sun Dec 6 04:44:59 2009 +0000
libglusterfsclient: fix libgf_client_read to handle short reads
Fixes two issues in the current code
-short reads (reading larger than file size) result in failure of full read
-reads which span multiple iterations return with the op_ret of only
the last read
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 334 (glusterfs_read/readv should break large-reads into 128Kb block sizes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=334
commit 3d4b2bcc12ba636a53977d2fb501eaff7751d0f2
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Dec 6 04:42:01 2009 +0000
performance/stat-prefetch: remove the usage of THIS.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 80f442b6ef87ef9bce7b677684456ce245f33baf
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Dec 6 04:39:13 2009 +0000
performance/stat-prefetch: fix memory leak.
- rbt_hash_remove only removes entry from the hash table. It does not free
the data.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 438 (Memory leak)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=438
commit 6c9161786bb91e7a900e0a1d3558dbab127b28cd
Author: Anand Avati <avati@gluster.com>
Date: Sun Dec 6 04:41:02 2009 +0000
protocol/server: fix bad reference to @inode in server_link_cbk
when op_ret is -1, gf_log refers to @inode which can be NULL. fix
this to refer to state->loc2.inode instead
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 448 (server_link_cbk refers to @inode when op_ret is -1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=448
commit 14ad01b5e0c71336bc6d76c38cb264b61bc5870c
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Fri Dec 4 20:43:01 2009 +0000
Fix critical argument validation bug found during initial testing.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 437 (Fix critical argument validation check on Fedora11 systems)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=437
commit 6170d60d3af51818e3e00782d90f2e637dcbb195
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Fri Dec 4 20:42:55 2009 +0000
glusterfs-volgen honours now build level prefix.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 437 (Fix critical argument validation check on Fedora11 systems)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=437
commit 303c9d09228ba661d1e056ffb4db6d4dd0d0044b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Dec 5 16:35:14 2009 +0000
libglusterfsclient/chdir: assign op_ret the return value of libgf_client_chdir.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 446 (apache does not start in daemon mode on fedora core 11.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=446
commit dd731cdfc94047909483fe678bf6ab7274fca987
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Dec 5 22:04:32 2009 +0000
corrected the stripe's stat structure return logic.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 340 (Kernel Compilation fail in stripe)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=340
commit 5c4f55f114a694dc07ad806ed6b94547566a954a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Dec 4 15:16:05 2009 +0000
performance/stat-prefetch: don't check whether previous lookups have been failed in sp_process_inode_ctx.
We need this patch for following reasons:
1. The inode used in the successful lookup call may not be the one passed to
fops operating on path. This may happen, if revalidate of inode is failed,
but the lookup itself succeeds (in case of reavalidate failures, fuse
sends a fresh lookup using new inode) and since inode_link, if there is an
inode already associated with a path retains it.
2. Only fops that "wait" in stat-prefetch for a lookup which is already in
progress, need to check for the result of the lookup they are waiting on,
before resuming and sp_process_inode_ctx is _not_ used in such contexts.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 428 (looks like stat cache not upto date..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=428
commit 868af2c2139933e55f64d2a992bace43ef4e2ff0
Author: Anand Avati <avati@gluster.com>
Date: Sat Dec 5 06:03:04 2009 +0000
fuse: fix leak in fuse_getxattr and fuse_getattr
In fuse_getxattr, @finh was leaked in the case of posix ACL getxattr
request
In fuse_getattr, @state was leaked when fuse_loc_fill() failed
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 438 (Memory leak)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=438
commit 920083a95daae90c6726c49d84575bd3237f0f64
Author: Vikas Gorur <vikas@gluster.com>
Date: Sat Dec 5 03:06:40 2009 +0000
cluster/afr: Fix inode_ref's for local->cont.lookup.inode
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit 42e2f4c1bb67fd0a9bc698369937b3a209d8f5fb
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Dec 4 21:27:15 2009 +0000
fix crash in server protocol server-connection-destroy
a variable allocated inside a condition was getting reffered outside
the block. If the condition fails, there used to be a crash.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 439 (crash in server protocol, while destroying connection)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=439
commit 569afc4f2ab61b260d015fda804bdb891be197e7
Author: Anand Avati <avati@gluster.com>
Date: Fri Dec 4 09:28:23 2009 +0000
posix_rchecksum() - fix leak of read buffer
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit 8b8629d3361382976fa2a957e72597e475ed08e1
Author: Anand Avati <avati@gluster.com>
Date: Fri Dec 4 08:12:43 2009 +0000
protocol/client: return ENOENT if inode context is missing
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit e144f882441696259dd74546bfee521cd26ca067
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Dec 4 06:04:37 2009 +0000
mount/fuse: Refactored fuse_setattr.
If both truncate & setattr need to be sent from fuse_setattr,
they are now sent one after the other (setattr first, and then truncate)
instead of being sent parallelly. The earlier code that sent them parallelly
had a couple of problems:
1) A bug in the logic that would sometimes cause the setattr call
to never return, making the application hang.
2) A possibility that truncate and setattr would race at the server/io-threads/posix
end, thus returning the wrong stat structure to the application.
This patch also removes an unneccessary "can_fuse_return" call in
fuse_attr_cbk, which would cause a call to hang if STAT or FSTAT failed.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit c5fa1a06c0ac9f92812375fcb70287393b8f028d
Author: Anand Avati <avati@gluster.com>
Date: Fri Dec 4 04:52:33 2009 +0000
afr: fix memory leaks
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit fd4ee071e6af911e6aa6517d455831ea4c074897
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Dec 3 21:47:23 2009 +0000
performance/stat-prefetch: add "caller" arguement to sp_process_inode_ctx.
- since sp_process_inode_ctx is called by many fops, if the context is not
set "caller" argument can be logged in log msgs to identify caller.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit e4d21cc6ec0a6b521101dd745ddbc3434c3968e3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Dec 3 21:47:11 2009 +0000
performance/stat-prefetch: implement sp_check_and_create_inode_ctx.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 51d86c81244d42a4638ddad051638d7ef7d809d3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Dec 3 21:46:52 2009 +0000
performance/stat-prefetch: refactor sp_lookup_cbk to use sp_update_inode_ctx.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 17a970ecc166f218b7057e84714e58f57bed0f88
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Dec 3 21:46:40 2009 +0000
performance/stat-prefetch: dont check for inode context in fops like create, mkdir.
- context will not be set as a fresh inode is passed in each of these calls.
instead create a new context.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 7fb09a77431c2671d068645d208a16e415f03ca4
Author: Anand Avati <avati@gluster.com>
Date: Fri Dec 4 03:50:47 2009 +0000
protcol/server: server_connection_destroy - destroy frame after issuing flush
frame was getting destroyed after unlocking, but before issuing flush. This
could result in corruption if an fd was opened between server_connection_cleanup
and server_connection_destroy because of pending open calls in io-threads at the
time of POLLERR disconnection
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 430 (Server crash when client is killed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=430
commit 8c8e3140255e2ce5b765caf775ff55f03c315ee4
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Dec 2 18:18:35 2009 +0000
features/locks: Process State Dump support for locks.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 306 (Enhance locks to aid debugging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=306
commit 02c4fafb93627ff92729bb96a6e1407b2eb04992
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Dec 3 16:10:17 2009 +0000
fixing some warnings on 64bit machine.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 408 (warning while building on 64bit machine..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=408
commit 640cd75683ca389b4e11f25f6d2b39e2d72ae552
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Dec 3 16:10:16 2009 +0000
features/locks: Fix inodelk leak when issued an UNLOCK.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 222 (Enhance Internal locks to support multilple domains and rewrite inodelks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=222
commit e95dccb083c4b418e3b695792273befcaa8741f5
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Dec 3 16:09:22 2009 +0000
storage/posix: Fix Leak in posix_getxattr while filtering gen-number xattr.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 1673a1a64065ddeae547a27a67893db4778bc7d3
Author: Pavan Vilas Sondur <pavan@gluster.com>
Date: Thu Dec 3 14:51:12 2009 +0000
mount/fuse: Print correct log message if encountered with errno - EAGAIN.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit ee5768bc33541f8eaedadc5a321b8178416659ec
Author: Pavan Vilas Sondur <pavan@gluster.com>
Date: Thu Dec 3 14:51:11 2009 +0000
features/locks: Release all locks of an fd when a client disconnects.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit bf30304aaf5a5d7149ad19b11555d8ee8cab3be0
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Dec 3 14:51:10 2009 +0000
features/locks: Changes in log messages reflecting lk-owner.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit eba6389c3c450feffd0258da58636362ff345aa0
Author: Pavan Vilas Sondur <pavan@gluster.com>
Date: Thu Dec 3 14:51:09 2009 +0000
protocol/server: Changes in protocol client to include lk_owner in protocol header.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit ab517380912002b3c0ec561ff8360b6e7f03880f
Author: Pavan Vilas Sondur <pavan@gluster.com>
Date: Thu Dec 3 14:51:08 2009 +0000
features/locks: Use owner field in inodelks.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit 7a142c52983d5609d63abe7ded0d6ecf87f87b5a
Author: Pavan Vilas Sondur <pavan@gluster.com>
Date: Thu Dec 3 14:51:07 2009 +0000
features/locks: Use owner field for entrylks.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit 0a2df3016dab65eb2f45d1240a263279185bd24d
Author: Pavan Vilas Sondur <pavan@gluster.com>
Date: Thu Dec 3 14:51:06 2009 +0000
features/locks: Use lock_owner from fuse in posix locks.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit 21d24c425a454b3426f42d8b6d370427759582e1
Author: Pavan Vilas Sondur <pavan@gluster.com>
Date: Thu Dec 3 14:51:05 2009 +0000
mount/fuse: Use fuse lock_owner field in posix locks.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 336 (Use lock owner field from fuse in locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=336
commit 15c3d6ae89f6e9ab945766909b4df9ed355aab31
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Dec 3 08:11:36 2009 +0000
mount/fuse: Handle the case when attribute_timeout is set to 0 in dictionary.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 252 (client coherence problem with locks and truncate)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=252
commit eaa65942053938b3e401fe37a45558c237823606
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Dec 3 08:10:57 2009 +0000
glusterfsd: Handle argument attribute-timeout when set to 0
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 252 (client coherence problem with locks and truncate)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=252
commit 0b6c2bc1600142c6745b228bea9a360ee906f993
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Dec 3 05:37:05 2009 +0000
core: Change replicate trash directory name to ".landfill".
The earlier name ".trash" conflicts with the name used by
the trash translator.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 227 (replicate selfheal does not remove directory with contents in it)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=227
commit ee393d5b217ae6a1e668d14af723f2da71c71d97
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Dec 3 05:15:09 2009 +0000
core, client, server: Support auxiliary group ids
Support for auxiliary group ids is needed for transmission
of more than one group id right through the xlator tree
so that posix can use these group ids to perform
in-house permission tests. The in-house permission checks are
needed so that we do not have to depend on non-POSIX calls
like setfs[ug]id for changing the user for each fop.
The setfs[ug]id are also limited since they do not allow setting
multiple group id as required for operation with NFS, which sends
us all the group ids for a process issuing file system requests.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 400 (Support auxiliary gids in GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=400
commit 36a0929277976ca094b7c10c5c2ccc2e993bcdf4
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Dec 3 03:57:15 2009 +0000
cluster/afr: Don't mark the fop as failed if rmdir returns ENOTEMPTY.
Marking the fop as failed in the ENOTEMPTY case led to spurious
entry self-heals.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 326 ([2.0.8rc9] Spurious self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=326
commit e7840ceebbecbe1483009555ac0bef2406d87043
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Dec 3 03:43:12 2009 +0000
libglusterfsclient: Separate order of path compaction and VMP search for abs and rel paths
The previous set of changes for relative paths in libglusterfsclient
break the absolute path operation. The fix involves differentiating
between absolute and relative paths in terms of the order
in which the 2 operations are performed:
- path compaction
- VMP search
For absolute paths, since we assume that VMP is already perfixed to the
path, we need the following order of operation:
1. VMP search
2. path compaction on the path components beyond the VMP.
For relative paths, the operations are reversed because there
we do not have a VMP pre-fixed in order to perform a VMP search.
This means that a path compaction combined with prepending of the
CWD is needed to get an absolute path before the VMP is searched for.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 65228123432a4bd77f7a2a22ba4567d4a7289bbf
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Dec 3 03:16:34 2009 +0000
performance/stat-prefetch: don't access stat if lookup has been failed.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 429 (crash in lookup_cbk when lookup returns with error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=429
commit 1f541785e9e684aec14e2dcb53f71f87e627e1a3
Author: Erick Tryzelaar <idadesub@users.sourceforge.net>
Date: Wed Dec 2 17:32:05 2009 +0000
Hopefully fix rpm building for everyone by rm-ing *.a and *.la
My Fedora 11 machine doesn't seem to make the .a files, so it errors out,
but it appears someone else's machine does, so try to fix it by explicitly
removing the .a and .la files, rather than excluding them from the %files
section.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 61155de99330d1df4600c0cf004ba675fb132fae
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Dec 2 18:19:53 2009 +0000
Disable fusermount by default in configure.ac.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 343 (Placeholder bug for adding volgen into rpm, bdb makefile changes, etc)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=343
commit 05da2139d23e437e288818a0cfd7d619e21d63cf
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Dec 2 14:28:59 2009 +0000
posix-compliance test now passes over stripe
* needed to have ctime in the statbuffer from first subvolume.
* unlink should be sent to all subvolumes no matter what.
(earlier it was sent to all nodes only in case of regular files,
causing directory not empty type of errors in 'rm -rf' cases)
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 321 (over distributed-stripe set-up, annihilate.sh fails.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=321
commit b3f766084d60f778f86dd387517fa9b5d382f4d7
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Dec 2 14:17:18 2009 +0000
storage/posix: Change janitor sleep duration to 10 minutes.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 227 (replicate selfheal does not remove directory with contents in it)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=227
commit cc897382aa61db32fb4e643949349eb684e0f91b
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Dec 2 14:02:44 2009 +0000
cluster/afr: Don't do transactional flush if pre-op has been nowhere done.
If a pre-op has not been done on any subvolume at all, there
is no reason to make flush a transaction call.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 427 (flush on a file opened read-only should not hold locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=427
commit 7a4ab3649e78ca67d256263cb8b822e3a1526294
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Dec 2 13:29:34 2009 +0000
storage/posix: Filter out generation number xattr.
Don't return the generation number xattr "trusted.<volname>.gen"
in getxattr, since this can cause replicate self-heal to copy
it over to another subvolume.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 05217f6dc63c5a74c83c280801b2d1ae527c8346
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Dec 2 12:17:32 2009 +0000
performance/write-behind: Changed default value of option disable-till to 0
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 425 (Change disable-till default to 0)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=425
commit b4ef9bb1e1e5f36f6238e5b0546bd764d7fd85e4
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Dec 2 08:34:25 2009 +0000
features/locks: Release blocked locks also when server requests to release all locks of a 'transport'.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 222 (Enhance Internal locks to support multilple domains and rewrite inodelks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=222
commit 9677f3bd885b7e53a8eeece03550fa384d0d4e91
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Dec 2 12:20:10 2009 +0000
cluster/afr: Add log messages when setattr fails in self-heal.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit cb4040ca7d2b1969fd029171647036571b55bc34
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Dec 2 12:29:56 2009 +0000
performance/stat-prefetch: get inode context from local->loc.inode instead of inode passed as arguement in sp_lookup_cbk.
- @inode in sp_lookup_cbk may be NULL in case of failure of lookup.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 426 (stat on mount point hangs.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=426
commit e9fc58a49950e2e263f5884669b5ffb317866ea9
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Dec 2 10:28:34 2009 +0000
cluster/afr: Fix conditional typo.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit 18a110fe1acb47cc77ca450a3cbc6db4098c5f6b
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Dec 2 07:48:45 2009 +0000
storage/posix: Added janitor thread.
The janitor thread deletes all files and directories in
the "/" GF_REPLICATE_TRASH_DIR directory. This directory
is used by replicate self-heal to dump files and
directories it deletes.
This is needed because letting replicate walk the directory
tree and delete a directory and all its children is too racy.
Instead, replicate self-heal only does an atomic rename(),
and the janitor thread takes care of actually deleting them.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 227 (replicate selfheal does not remove directory with contents in it)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=227
commit 64409e32632853e7a4c246eec9c20f56cf459e74
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Dec 2 01:00:44 2009 +0000
performance/stat-prefetch: fix access to inode table.
- Access the inode table from one of fd->inode->table, inode->table or
parent->table instead of from root xlators itable.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit a42d587000b6d0fc10d7d223ddbf7dcb2929fbe3
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Dec 1 20:28:28 2009 +0000
fixes to compile on MacOSX (no fuse client)
These changes are required to make GlusterFS compile on MacOSX (10.5).
Currently glusterfs server component alone will work over Mac, and it has
to be built with following options to ./configure.
"bash$ ./configure --disable-fuse-client --disable-fusermount "
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 361 (GlusterFS 3.0 should work on Mac OS/X)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=361
commit 574c672b0979cc7c847cab010219b0a3caa421fc
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Nov 28 03:09:02 2009 +0000
bring new MOP called NOTIFY.
which can be used as a bridge between client and server processes,
when needed.
This mop is needed now, so that many features in 3.0.0 can come in
with this without bumping protocol version.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 201 (server should get notified about client 'umount')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=201
commit 85beee8399b8da76bfa1a13cfbe7550e30ed4a14
Author: Anand Avati <avati@gluster.com>
Date: Tue Dec 1 20:06:18 2009 +0000
afr: remove memcpy of @local contents in afr_local_copy
copy out members which are needed. memcpy of full local causes
a copy of pointers without references and results in various corruption
errors
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit f8333b47dd4e055e6841f077c46379a276bf7ffb
Author: Anand Avati <avati@gluster.com>
Date: Tue Dec 1 19:58:02 2009 +0000
afr: fix fd reference leak
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit e06e476a4bdd2f92488d41de3dedd7a66a367ffc
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Dec 1 12:03:08 2009 +0000
performance/io-cache: Hold locks on inode before creating rbt tree.
Lock is held before creating a RBT in inode. Also, did some re-factoring.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 335 (Io-cache optimization)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=335
commit 7d52e2513475cd16e0ee0d7a26abf91da8c3dc1a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Dec 1 14:39:45 2009 +0000
libglusterfsclient/read: break reads bigger than the iobuffer size into smaller ones.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 334 (glusterfs_read/readv should break large-reads into 128Kb block sizes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=334
commit 7d669c30f26899768740f61b8d9210528e22e895
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Dec 1 14:39:31 2009 +0000
libglusterfsclient/readv: break reads bigger than the iobuffer size into smaller ones.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 334 (glusterfs_read/readv should break large-reads into 128Kb block sizes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=334
commit ae3d9f93218e1df80d2215cccfa4654e4c61d7a0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Dec 1 14:46:21 2009 +0000
extras/benchmarking: port glfs-bm.c to master.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 422 (port glfs-bm to latest code-base)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=422
commit 0054c9e5a93a6347a457f6ce4d970dda0e959217
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Dec 1 14:51:15 2009 +0000
changed the version of glusterfs from 2.1.0 to 3.0.0
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit a044de5b6ddc4bb2558384ad7bea2eaa2c5d56f4
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Nov 30 01:20:20 2009 +0000
trash_ftruncate fop added
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 142 (enhance features/trash translator so it can work on client side too..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=142
commit 623179c3273faed4ae6aa052fed126d7379b5656
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Nov 30 01:19:10 2009 +0000
trash_truncate fop added
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 142 (enhance features/trash translator so it can work on client side too..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=142
commit acd66463a0a70bcbf4f9127f37671b50d64045fe
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Nov 30 01:18:41 2009 +0000
trash_rename fop added
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 142 (enhance features/trash translator so it can work on client side too..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=142
commit 80bf2378a6b36749f5ff32643541d1b438f2eb33
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Nov 30 01:18:09 2009 +0000
trash_unlink fop added
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 142 (enhance features/trash translator so it can work on client side too..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=142
commit adc2103d3597c5f26bc2bfcee2eb839c471de535
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Nov 30 01:16:35 2009 +0000
features/trash initial cleanup commit
* support O_TRUNC flag in open (call comes to FS as 'truncate'
or 'ftruncate' fop)
* option to provide 'eliminate-pattern' so those files matching
won't be kept in trash. Eg:
option eliminate-pattern *.out|*~
* option to give 'maximum' file size to keep in trash, ie, when a
20GB file is deleted, it won't be kept in trash if max file size
given is 1GB. Eg:
option max-trashable-file-size 1GB
These particular features are developped as a part of college project
by following team:
Sunil bhagwath <sunilkbhagwat@gmail.com>
Yashaswi Kumar <yashaswikumar@gmail.com>
Rashmi B K <rashmibk17@gmail.com>
Sandeep M <astrophyster@gmail.com>
Submitting after minor coding standard edits and memoryleak fixes.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 142 (enhance features/trash translator so it can work on client side too..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=142
commit b4e1c81e2b8aa6868cbc18cdd623c53ed9aed7a1
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Mon Nov 30 01:17:22 2009 +0000
Booster configuration fixed for per transport type and honours conf-dir option.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 421 (Make booster configuration honour conf-dir and transport type)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=421
commit 15796897aae63c1c09d6148f38b79ea8b87f70c2
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Dec 1 06:11:06 2009 +0000
cluster/afr: Don't do memcpy of afr_local_t in afr_local_copy.
For the background self-heal frame's local_t, copy only
required members --- not a wholesale memcpy. The memcpy
lead to pointers being copied and then double free'd.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit bfbe497d30803db94f5f4527f59f353370948d93
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Dec 1 06:11:05 2009 +0000
cluster/afr: Set file size properly before unwinding from self-heal.
Set the buf.st_size of the original frame's afr_local_t, and
not the copy_frame'd one.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit 816442fecd447805ff04b670a6759936856f5684
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Dec 1 06:11:04 2009 +0000
cluster/afr: Set the self-heal "source" as read subvolume even when not doing self-heal.
This patch sets the read-subvolume equal to the self-heal "source"
even if we're not doing self-heal (because some one else is already
doing it).
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit d99836a67154fb523d9f2a133306bbce12949ca0
Author: Anand Avati <avati@gluster.com>
Date: Tue Dec 1 07:02:02 2009 +0000
stat-prefetch: fix unsafe reference to @local in sp_lookup_cbk
stat-prefetch uses the main syscall frame for performing lookup on
demand. this causes a potential reference to a freed local in
sp_lookup_cbk after resuming the main syscall frame (which could
have unwound and destroyed)
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 242 (If any of the writes fail, write-behind should not wait till the fd is closed for reporting errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=242
commit 831fb2a90e901d552685a057bf6dfac9b9d27ae3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 30 15:48:38 2009 +0000
performance/stat-prefetch: make lookup to wait for the completion of another lookup on same path if one is in progress.
- If current lookup (2) does not wait for completion of the lookup (1) which
is in progress, there can be a race condition where (2) completes ahead of
(1) and resuming all the waiting operations in the queue. When (1) returns,
the original operation (eg., stat, chmod etc) might've already unwound and
hence the frame would've been destroyed.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit ce34d34ead2e5ef5ce1160ec4d218bddd022eb1e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 30 15:48:21 2009 +0000
performance/stat-prefetch: don't use same variable for getting inode context of an inode and its parent.
- this bug results in updation of flags in inode context of the parent
instead of that of inode.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 59a07ab772ab8690facbec4962bab5e918cbd7eb
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 30 15:48:08 2009 +0000
performance/stat-prefetch: fix errors in handling memory allocation failures in sp_inode_ctx_process.
- the variables that are used for making decisions are assigned before
memory allocations and these variables were not reset to
correct values in case of memory allocation failures.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit b81bbe72710579d8277e8a1b79f123695368f8d8
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Nov 29 19:26:57 2009 +0000
fix leaks pointed out by cppcheck static analyzer
See http://cppcheck.sf.net
[./build/libglusterfs/src/y.tab.c:2104]: (error) Memory leak: cmd
[./libglusterfs/src/md5.c:306]: (error) Resource leak: f
[./xlators/debug/io-stats/src/io-stats.c:1396]: (error) Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 1402
[./xlators/cluster/stripe/src/stripe.c:3597]: (error) Memory leak: dup_str
[./xlators/debug/trace/src/trace.c:2426]: (error) Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 2429
These appear in rarely hit error cases or test/demo code so nothing
serious, in fact.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 420 (fix leaks pointed out by cppcheck static analyzer)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=420
commit 6f405d210c8fb74b9b4d3865649f506cc7fe6f2c
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Nov 30 04:35:09 2009 +0000
cluster/afr: Preserve generation number along with inode in lookup and creation fops.
This fixes fuse_create_cbk conflict warnings and random errors while
running dbench (typically open handle failure with ENOENT).
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 29b11c12e907911a160fa63ccd701e0c44b81bfd
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Nov 30 02:27:12 2009 +0000
cluster/afr: Refactored lookup_cbk and introduce precedence of errors.
Error handling in afr_lookup_cbk was faulty because it
did not give priority to errors such as ESTALE over ENOENT,
and ENOENT over other errors. This patch fixes that, and
also breaks up afr_lookup_cbk into multiple logical functions.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 205 ([ glusterfs 2.0.6rc4 ] - Hard disk failure not handled correctly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=205
commit 6bcb5679e04242f27f9209412e3884470276c352
Author: Anand Avati <avati@gluster.com>
Date: Sun Nov 29 09:27:54 2009 +0000
afr: fix crash in afr_sh_data_close
when active_sink count is 0, the code proceeded into a dangerous loop
resulting in a crash while issuing the call or in the callback
afr_sh_data_setattr_cbk or afr_sh_data_flush_cbk
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit cfacc1bd30b669219872736f08b873b3148a66a8
Author: Anand Avati <avati@gluster.com>
Date: Sun Nov 29 07:45:20 2009 +0000
protocol/server: enhance trace logging
add logging of fop name, callid number and make logging more friendly
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 7ba38cca0ef0eebe34facdd2d830a70d02ba78fe
Author: Anand Avati <avati@gluster.com>
Date: Sun Nov 29 07:37:32 2009 +0000
afr: handle fdctx->pre_op_done handling
reset pre_op_done[i] to 0 after issuing a postop in flush. this was
missed during the introduction of pre_op_done[] array and was resulting
in a lot of spurious self heals when spurious flushes were received
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit 31d9a71c0584190b3226b92fadaa5522bc84d65c
Author: Anand Avati <avati@gluster.com>
Date: Sat Nov 28 05:34:41 2009 +0000
afr: fix logic to break out of diff/checksum loop
When checksum fop returns error, mark for terminating the loop at the end
of the iteration (when all checksum calls of that iteration return) and
not immediately
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit fe0a40019e1005493ff739d0bd22b8a46f5dcc58
Author: Anand Avati <avati@gluster.com>
Date: Sat Nov 28 05:34:11 2009 +0000
protocol/server: fix improper validation of fd in server_rchecksum
state->fd validation should be done _after_ resolve_and_resume()
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit cccfb2eeaa5ea3d31652ff54f52135b52c14abf7
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Nov 28 11:04:19 2009 +0000
performance/quick-read: add options to doc/translator-options.txt.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 419 (Issues with writing files of size >= 1MB)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=419
commit 083f4221262d1de6bcaa803d996a1c81fed05649
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sat Nov 28 10:52:37 2009 +0000
performance/quick-read: change the maximum value of max-file-size to 1000KB from 1MB.
- protocol restricts the maximum buffer size that can be received over network
to 1MB. Since the buffer holding reply of lookup should also contain the
lookup header and other key/value pairs of xattr_reply dict, the maximum
file size that can be fetched through dictionary cannot be equal to 1MB.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 419 (Issues with writing files of size >= 1MB)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=419
commit 2a6453fa441b2416aa659e23936f7b8b7f3b0a9b
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Thu Nov 26 15:47:28 2009 +0000
Excluding static libraries.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 413 (rpmbuild fails with unpackaged files)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=413
commit 8a4759fe0a42633cc3f1d9a8a8579cc422bc5592
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Thu Nov 26 15:42:26 2009 +0000
Removed deprecated export_dir in print string.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 412 (Remove deprecated export_dir in print string)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=412
commit 97e3ebe64893538c0fbf2f3c1438f69319978166
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Nov 26 14:55:03 2009 +0000
moved unify from 'cluster/unify' to 'legacy/cluster/unify'
maintaining unify is not feasible, and its design of namespace is
not scalable too. hence moving it to 'legacy/' directory..
Thanks to unify, we learnt something about rename(). 'cluster/unify' has
served GlusterFS well for more than 2years, and its the time to say
goodbye :-(
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit c0e356e15443307d0d75e551eaaf9317a021b652
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Nov 26 13:36:34 2009 +0000
performance/stat-prefetch: Changed rbthash to make use of 1 bucket
rbthash makes use of 1 bucket and a common mem-pool is being used for all rbt entries.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit e2fd2fec6fc2c07bbcbf1726d1b2cce6ed36bf12
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Thu Nov 26 12:08:44 2009 +0000
Volgen rewritten using option parser and added proper support for booster.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 411 (Rewrite volgen using option parser and extend cifs/nfs support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=411
commit 25a8de4097d659dd290c54564f902ea7a058d02d
Author: Anand Avati <avati@gluster.com>
Date: Thu Nov 26 07:22:08 2009 +0000
THIS: transport to use xlator_notify() for proper setting of @THIS
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 8b8fdf40a33336e031dc5d4644d793f354da8de1
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Nov 26 07:51:26 2009 +0000
protocol/server: Introduce option trace to log requests and replies in normal log.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 398c4c768f4057540deba0a2fa5c8a226a286df8
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Nov 26 07:50:49 2009 +0000
protocol/server: Get all fops to use the new 'resolve_and_resume' path in server/protocol.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 492eeb877e5c468045b32d88ade73c0b3db94b08
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Nov 26 06:37:30 2009 +0000
Changed rbthash_table_init() to take a mem-pool argument.
Changes in libglusterfs/rbthash:
rbthash_table_init() now takes a mem-pool argument.
The mem-pool argument would be mutually exclusive to expected_entries.
If expected_entries is provided, mem-pool would be ignored and vice-versa.
Changes in io-cache:
1) Moved rbthash creation to readv.
2) rbthash makes use of 1 rbt instead of 4096
3) A global mem-pool is being used in place of a mem-pool per rbt.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 335 (Io-cache optimization)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=335
commit da518a697f5646b1abba4dd025025509057ab9e1
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Nov 25 21:29:25 2009 +0000
fixes in nufa
Now nufa uses dht_conf->private variable to store its
contents, and doesn't pollute distribute's structures.
It used to hang earlier as layout_lock was not INIT()'d.
whitespace-cleanup done on the code too.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 409 (implement a switch scheduler)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=409
commit e51e16352f7b3369931076a3bf558b63010430c8
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Nov 25 21:26:24 2009 +0000
switch translator added
switch translator is a wrapper around distribute to work for a
pattern based scheduling.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 409 (implement a switch scheduler)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=409
commit 48f96417489038e34a180db24afe7d7c60a487b6
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Wed Nov 25 14:40:55 2009 +0000
Volgen supporting multidisks and booster configuration for nfs and cifs
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 396 (Volgen multiple export directory support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=396
commit 71b0c8f99abb2b408d7539bb2e65f42357c4074b
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Nov 25 15:13:37 2009 +0000
add an extra check for loc->parent when loc->ino is not 1
This extra check is needed only in case where setup is
"server -> chain -> client", where for the root inode, inode->ino
is not updated in the first lookup call, hence used to crash.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 377 (segfault in protocol/client with chaining)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=377
commit 00593c4d0419d35b0f70f64ec670776748231e8b
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Thu Nov 26 04:16:27 2009 +0000
Fixed typo in gf_proc_dump for attribute_timeout.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 410 (Typo in gf_proc_dump for attribute_timeout)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=410
commit db3812a27a878b364452f5caa2e8d87c07a40b40
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Nov 26 03:29:46 2009 +0000
don't allow stripe with just one subvolume
stripe code assumes in many places that it will have more than one subvolume,
but the strict check was not there in init, hence, if somebody configures stripe
with just one subvolume, it will cause many fops with frame loss.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 340 (Kernel Compilation fail in stripe)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=340
commit cdaa7046edb0877afc5cd3adbe3d80ff6fa4dca2
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Nov 26 00:53:49 2009 +0000
protocol/server: Changed logging level of message on deep resolution
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 3a0d8f4bd165146d56df5dbf0697f10d265a52ad
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Nov 26 00:38:28 2009 +0000
changed the log level of failure case in client_setvolume_cbk
It *should* be an error when a handshake fails. Its hard to debug
it otherwise
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 26 (Version mismatch not handled correctly)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=26
commit 1a8de07185979db70acb8a33d8972ce5c381004f
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Wed Nov 25 13:15:36 2009 +0000
Added boundaries for each fops, mops and cbks.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 366 (Infinite loop with centralized logging.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=366
commit 8b686ffbb444edc583c50ab30efe2f3deb3f7a0b
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 24 10:08:54 2009 +0000
cluster/afr: Include "common-utils.h" instead of alloca.h
alloca.h should be included on a platform-specific basis.
Lets common-utils.h handle that.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 349 (FreeBSD compilation error (alloca.h).)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=349
commit 778af7c2e8d44c9b6749b86306825eeff6f87a79
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Nov 25 02:19:31 2009 +0000
protocol/client: Make log message print both generation number and inode number.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 4a29eaeaea5d89e127fd427a7d494646cfe4af8c
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Nov 25 07:51:23 2009 +0000
cluster/afr: Do self-heal on unopened fds.
This patch completes the previous patch for self-heal of
open fds in replicate.
If an fd was never opened on a subvolume, we remember that
and do the open after we've done self-heal on that fd.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit 416055e25fe77fd109b6adcbcf6b3ee9bcbb2519
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Nov 24 20:47:00 2009 +0000
performance/stat-prefetch: Add refcounting to cache objects
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 405 (Segmentation fault in stat-prefetch.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=405
commit a83819c9770d5d1a5437a0e79a90e90d1aaa058a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Nov 24 20:46:48 2009 +0000
performance/stat-prefetch: remove lock member in sp_fd_ctx_t.
- since the lifetime of fd context can be no longer than the fd, we can use
lock in fd.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 405 (Segmentation fault in stat-prefetch.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=405
commit 3fae0907772c17724a03306e42d0c73282ffe427
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Nov 24 20:46:34 2009 +0000
performance/stat-prefetch: don't free the cache in readdir if the offset is not the expected one.
- cache creation is expensive operation. Also, cache will be freed in
releasedir. Hence, just remove all entries from cache without freeing
the cache. However this is not entirely true, since sp_cache_remove_entry
frees the old table and reinitializes a new table if all entries are being
removed. When rbtree based hash table provides an interface to remove all
the entries, sp_cache_remove_entry should be modified not to destroy the
table.
- this patch also fixes a race condition wherein the cache being used in
lookup getting freed in readdir if the offset is not equal to expected
offset.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 405 (Segmentation fault in stat-prefetch.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=405
commit ffb0a0ae0d0b06a620b91e47584a7ae3b04425ac
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 24 08:45:10 2009 +0000
cluster/afr: Refactored the self-heal interface.
Cleaned up the self-heal interface to callers.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit 335658d4c4a098d5cb26212ef0425c9749c32c8d
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 24 08:45:09 2009 +0000
cluster/afr: Do self-heal on reopened fds.
This patch brings in partial support for self-heal of open
fds. The precondition is that the fd should have been opened
successfully during the initial open() (or create()), and we
assume that protocol/client has successfully reopened the fd
when the subvolume comes back up.
It works by doing an "up/down flush" (a dummy flush transaction
to do post-op wherever necessary) and then triggering
data self-heal on the file in the post-post-op hook of the
dummy flush transaction. This ensures that any writes
that come in during self-heal will wait until self-heal completes.
The up/down flush is also done when a subvolume goes down,
so that post-op is done on all subvolumes where pre-op was done.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit 3346d2699b821e72692b203eee1b0f5f3dccf4f6
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 24 08:45:08 2009 +0000
cluster/afr: Provide a post-post_op hook in the transaction.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit 3d4f5f008460fa7f0bf1365479e6dc3ab941d259
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 24 08:45:07 2009 +0000
cluster/afr: Refactored the data self-heal algorithm.
Refactored the operation of the data self-heal algorithm
as:
* open all fd's (if fd not supplied by caller)
* lock 0-0 (if lock not supplied by caller)
* fxattrop, fstat (instead of lookup)
... self heal ...
* unlock (if lock not supplied by caller)
* close (if fd not supplied by caller).
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit fd0da2b2953ba9157b94babcac24968e89140940
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 24 08:45:06 2009 +0000
cluster/afr: Hold blocking locks for data self-heal.
Data self-heal now holds blocking locks, and instead of locking
on all subvolumes, it only locks on {data-lock-server-count} subvolumes.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit 1c3c78f9dd22837323be2c91dbf8e51edaf243df
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 24 08:45:05 2009 +0000
cluster/afr: Set read-child = source regardless of foreground/background self-heal
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit d324d14589860e0988a940fcf283d1385b94b1d9
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 24 07:41:36 2009 +0000
cluster/afr: Fix inode context bitmasks.
Set opendir_done and split_brain flags correctly
in the inode context.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 249 (Self heal of a file that does not exist on the first subvolume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=249
commit 2d1b1a429aa4fb361da1d37d8d8687cfe185a87b
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 24 06:07:16 2009 +0000
cluster/afr: Fix double-free in opendir self-heal callback.
local->cont.opendir.checksum was being free'd both in the
self-heal completion function and self-heal unwind.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 249 (Self heal of a file that does not exist on the first subvolume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=249
commit eda5f0f195cd4a9ab30b337b8b268fb9937ffc81
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 23 18:57:40 2009 +0000
performance/quick-read: use STACK_UNWIND_STRICT for unwinding.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 207ef864768a2e96548ab74ecf348eb52e49ae8b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 23 18:57:33 2009 +0000
performance/write-behind: use STACK_UNWIND_STRICT for unwinding.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit a2f7dd63a598b093ddf973ffe8022c92cd0905ff
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 23 18:57:27 2009 +0000
performance/read-ahead: use STACK_UNWIND_STRICT for unwinding.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 37906190040db44d1ebd08f892da9313f352cf30
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 23 18:57:21 2009 +0000
performance/io-threads: use STACK_UNWIND_STRICT for unwinding.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 6bf737f1c557be8ad8f863547028f01a2d525f61
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 23 18:57:13 2009 +0000
performance/io-cache: use STACK_UNWIND_STRICT for unwinding.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 3447d133594aaa1149252be6fd2d22d3e814b983
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Nov 23 18:56:22 2009 +0000
performance/stat-prefetch: use STACK_UNWIND_STRICT for unwinding.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 30da255d0ef912c7a7be7f2050e4e6af8328b9b5
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Oct 14 14:07:51 2009 +0000
cluster/afr: Unlock only those paths which have been locked during rename.
For ENTRY_RENAME_TRANSACTIONs, keep track separately whether the
lower_path and the higher_path have been locked, and unlock only
those which have been.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 112 (parallel deletion of files mounted by different clients on the same back-end hangs and/or does not completely delete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=112
commit 4686b4003a26a1c5a4444cef367a84bf5949bfac
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 24 04:46:35 2009 +0000
cluster/afr: Fix handling of revalidate lookups.
This patch does two things related to revalidate:
1) If a revalidate fails on any subvolume, the entire lookup
call is failed.
2) Self-heal is not triggered on a revalidate if revalidate
has failed on any subvolume.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 389 (auto-heal fails randomly and causes "Stale NFS file handle" errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=389
commit b0ea0dbb0a6260d938acab8430544d4e131c6a38
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Tue Nov 24 03:40:53 2009 -0800
Revert "libglusterfs/src/gf-dirent.c: In gf_dirent_nb structure d_name should be char array of size 1."
This reverts commit e151ab3ed4718606767146f18b416f8900552fbc.
commit f86f7eee2463e1b21a8ccf61a4b80d5d22bbcb22
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Nov 20 07:35:45 2009 +0000
storage/posix: Fix condition typo.
Do comparision instead of assignment in if-condition
in posix_link.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 254 (storage/posix has to do inode number transformation wherever it unwinds with a stat structure)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=254
commit 3857904e7117c12c6772e47d085030d73840aa97
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Nov 19 17:28:00 2009 +0000
performance/io-cache: don't use stat got in read_cbk if it is zero-filled.
- translators like io-cache, read-ahead return a zero-filled stbuf in
readv_cbk and usage of zero filled stat for cache validation is not
correct.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 376 (server-side io-cache is preventing client-side io-cache from working)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=376
commit c45ef93fe7806031fc39fd3882e3fe59e2726736
Author: Paul Rawson <plrca2@gmail.com>
Date: Tue Nov 17 00:13:24 2009 +0000
Fix Redhat init file so that it knows the correct binary location
Signed-off-by: Paul Rawson <plrca2@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 388 (Redhat initfile fix)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=388
commit e54132bd65b9f7c5a66b7d1cf67485ef44180098
Author: Erick Tryzelaar <idadesub@users.sourceforge.net>
Date: Mon Nov 16 13:27:30 2009 +0000
Fix rpm building for Fedora 11.
I was running into a problem compiling glusterfs on Fedora 11, rpmbuild was
complaining that it couldn't find any .a files. Since it doesn't look like
gluster's creating archive libraries anymore, I removed this line from the
spec file, and gluster started to compile again.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 56c76abaf73049d3f67a354fadc07cee1039c7fb
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 15:07:22 2009 +0000
transport/ib-verbs: assign to qpreg before accessing it in __ib_verbs_lookup_peer.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 381 (glusterfs crash in ib-verbs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=381
commit 2b5c93b307b1899332fe512d396578117def90d3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 00:29:17 2009 +0000
performance/stat-prefetch: don't cache dentries corresponding to directory.
- distribute picks up the inode number from hashed subvolume. But readdir
is done from different subvolumes based on the offset. Hence there is a
possibility of inode number and device number for directories being
inconsistent between two stat calls.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 371 (rm -rf fails on stat-prefetch.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=371
commit 5540ae4d84fdedf08240ee8b76704118a6f82319
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 00:29:05 2009 +0000
performance/stat-prefetch: don't use pre-allocated dirent structure in sp_get_cache_entry.
- since we don't know the size of dentry before calling sp_get_cache_entry,
we must dynamically allocate the dentry in sp_cache_get_entry and copy the
contents from cache.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 371 (rm -rf fails on stat-prefetch.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=371
commit afc29fcf6bd9681651f4a9b605ca88cdf587bd2c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 00:28:49 2009 +0000
cluster/distribute: copy the stat structure while copying dentries in readdirp_cbk.
- only the transformed inode number was being copied, leaving other fields of
stat 0.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 371 (rm -rf fails on stat-prefetch.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=371
commit 551a2e22ad5c3e8d62d7b4544edeafc80f3fc690
Author: vinayak hegde <vinayak@gluster.com>
Date: Thu Nov 19 01:39:39 2009 +0000
debug/error-gen: Correct log messages in init function.
Signed-off-by: Vinayak Hegde <vinayak@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 291 (feature enhancement of error-gen translator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=291
commit df7b141e0543c4d2e6dfc8f3f1dced5434fd181d
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Nov 18 01:11:11 2009 +0000
Check for other return values as well from call to inode_path.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit e0aaff08e34b8bd9bdc533c33c6f37be143680b7
Author: vinayak hegde <vinayak@gluster.com>
Date: Tue Nov 17 06:17:04 2009 +0000
cluster/stripe: Wrong variable is checked after calloc.
Signed-off-by: Vinayak Hegde <vinayak@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 368 (setattr on a non-regular file makes glusterfs crash)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=368
commit bdb76c4b2415572ac1ae946dfcbc35c75d83b3c5
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Nov 16 13:08:31 2009 +0000
protocol/client: Changed default ping-timeout to 42
This change is necessary to avoid frequent disconnections between client and server under load.
A disconnect-connect sequence is costly in terms of clean up and re-building of context,
self-heals etc. This value should be optimal for most use cases. Users requiring a lower
ping-timeout value need to configure it explicitly.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 384 (Increase default timeout in client protocol)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=384
commit a105c3b56d56b59d850f27ad495814bc239dd762
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Nov 17 05:24:03 2009 +0000
Do not access a free'd lock while releasing all inodelks of transport.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 222 (Enhance Internal locks to support multilple domains and rewrite inodelks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=222
commit 41fa3e9a19d6d164bf9697682213eefb1903df40
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Nov 18 07:02:25 2009 +0000
cluster/afr: Handle op_ret properly in opendir_cbk
Change the success condition to op_ret >= 0 instead
of op_ret == 0.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 249 (Self heal of a file that does not exist on the first subvolume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=249
commit 9c5f011916d998cd04345ac3ec203b92812e4007
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:20:41 2009 +0000
libglusterfsclient/umount: fix double free.
- calling glusterfs_fini results in double free.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 2f4b0e855e6ec87a31e93565efdb0f2ec8a48967
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:20:30 2009 +0000
libglusterfsclient: don't change the st_dev in stat-structure before doing inode_link.
- st_dev is used for storing generation number of the inode in
inode_link and libgf_iattr_transform changes the st_dev to fake_fsid.
If inode_link is done after libgf_iattr_transform, the generation number
stored will be wrong and will result in ESTALE errors from server.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit c4ef2121c13fa279f20a2b2fb91c925064018752
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:20:15 2009 +0000
libglusterfsclient/open: don't send create call if the file is already present, instead send open.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit b064cdefa0398a621f83c13cd42aba8da00db7c4
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:20:02 2009 +0000
protocol/server: add debug messages.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit b33ef40d14bac7739bd930471c92d6ebe1881098
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:19:50 2009 +0000
libglusterfsclient: update iattr cache only if operation was successful.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit fe675db06a53f9973536c0f299e46a9eecc4803c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:19:37 2009 +0000
libglusterfsclient: fix memory leak.
- glusterfs_glh_getxattr was implemented using libgf_client_lookup. Hence the
inode corresponding to the path on which getxattr was done was refed twice
- one during path_lookup and the other in libgf_client_lookup - but unrefed
only once.
- with inode generation number changes the inode returned by inode_link may
not be the same as the input argument. Hence the inode returned by
inode_link should be used, not the one returned in libgf_client_lookup_cbk.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 48629c203d2e509b75fc31cfac43c713e29bad1b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:19:22 2009 +0000
booster: implement xattr related apis.
- implement setxattr, fsetxattr, lsetxattr.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 527b0c470cdcdc4389c3f024fac219b3efa67034
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:17:49 2009 +0000
libglusterfsclient: change the prototype of glusterfs_lsetxattr.
- it no longer needs handle to be passed as arguement. handle is searched
in the vmp table based on the path.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit d473337bb18c69eaa95a0c652ce4b89bf3dcc618
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:17:36 2009 +0000
libglusterfsclient: fix __do_path_resolve to return zero if the path happens to be resolved in path_to_parenti.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 8f6e476d62e72c3f6f25e67e27e35ab735abd01e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:17:25 2009 +0000
libglusterfsclient: getxattr should return the length of the xattr when size is zero
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit f2b0f7a6bbc3c2dfe68b03ebfde5c858c459d75c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:17:14 2009 +0000
libglusterfsclient/ftruncate: add braces to ensure proper evaluation of if conditional.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 861f7a4c361df80bcc00eb32c774dc45e18da11c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:16:57 2009 +0000
booster: implement creat64.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 5bd2cfd4a71bba7016454cdc933b88209329b459
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:16:45 2009 +0000
booster: implement truncate and truncate64.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 468a66153eeafd80924136bbcd4c85cb70d8ac51
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:16:33 2009 +0000
libglusterfsclient: implement glusterfs_truncate.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit fbb4141252b6beb6996f441679d104bcd86f095d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:16:12 2009 +0000
booster: implement ftruncate64.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 2a71455c79442843b8c690b387663f4c34874bb6
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:16:01 2009 +0000
libglusterfsclient: fix libgf_vmp_virtual_path. - This procedure used to return garbage as virtual path if the path happens to be exact mount point but without the trailing slash and the vmp had a trailing slash.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 3b97294430fc55c2f7786ecc31ae270bbf67bde7
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:15:46 2009 +0000
booster: implement getcwd.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit e0677a016b1a15bd9efb1a930b66be85c5044ab5
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:15:30 2009 +0000
booster: implement fchdir.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit c07db9604ca1cac38840de6169d6bcc2cda2b6a3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:15:11 2009 +0000
booster: implement chdir.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 897290744be51902b49247e74e8b3b6eb68f6f20
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:14:58 2009 +0000
libglusterfsclient: implement glusterfs_getcwd.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 570ea5b0a1ecd8a0ceb2b38461b2d8494c6c703a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:14:42 2009 +0000
libglusterfsclient: implement glusterfs_fchdir.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 1a0133992b5321dba9cb45809c2ad26c7dfd267a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:14:24 2009 +0000
libglusterfsclient: implement glusterfs_chdir.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 9f8dabdc77643d8a1cd2703b17e51f73dd9bf690
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:14:04 2009 +0000
libglusterfsclient: Support relative paths.
- This patch is a port of the patch with same title on 2.0 branch.
The original patch was sent by Shehjar <shehjart@gluster.com>.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit b625daffb9edbdcbdbae6c876c23bbe89fd61edf
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 18 01:13:38 2009 +0000
Revert "booster, libglusterfsclient: Support samba specific relative paths"
This reverts commit e6fc0cbe716a18f02891d3911481fdcb121d8840.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 369 (Samba does not work with booster.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=369
commit 0a070c7c29948158f519679d3331eb285c32b3b4
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Nov 18 05:20:08 2009 +0000
libglusterfs: Fix error handling in _gf_log.
Unlock the mutex when an error occurs instead of jumping
straight to "out".
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 394 (Possible deadlock in _gf_log)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=394
commit 75f9446651ca62ad5cc5eb552612264b23fbccbd
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Nov 16 02:59:04 2009 +0000
Upgrade FUSE protocol to rev. 7.13
2.6.32 will feature FUSE proto 7.13 which lets us tune the maximal number of
in-kernel backgrounded requests via INIT.
Hereby we live up to this enhancement.
Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 385 (Upgrade FUSE protocol to rev. 7.13)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=385
commit 9f345d12432d288a0b7c9e4ef3d70a53d36cd1c1
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Nov 13 16:08:15 2009 +0000
transport/ib-verbs: fix race-condition resulting in freeing of transport while it was still being used.
- while handling a failed work completion status, the transport is
disconnected. But further down in the code, the transport is still
used. There can be a possibility that transport might've been freed
by the time control reaches this point. More detailed description of
events leading to this situation can be found at
http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=381
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 381 (glusterfs crash in ib-verbs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=381
commit ff92d1fadb73d07ab7b6b4b20c6a48c91dfda9c2
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Nov 13 16:07:50 2009 +0000
transport/ib-verbs: synchronize ib_verbs_recv_completion_proc with ib_verbs_receive so that the former doesn't overwrite the pointer from which latter reads.
- There can be a condition wherein,
1. the thread executing ib_verbs_recv_completion_proc (thr 1) stores the
buffer pointer and notifies the upper translators about a POLLIN event.
2. the thread waiting for events on socket (thr 2) calls transport_receive,
but in ib_verbs_receive it has not still read the data.
3. thr 1 receives work completion event for another work request and
overwrites the buffer pointer.
4. thr 2 reads from the new pointer there by missing the data stored in
buffer pointed by pointer which got overwritten.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 382 (Data can be lost before it is read in ib_verbs_receive.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=382
commit a03a2b0d25b881de70c7677ae9baaea54c4d9626
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Nov 15 21:39:20 2009 +0000
fixing a crash in posix (on 32bit)
fd_ctx_get () was getting passed with type punned argument, now
corrected by passing the right argument, and doing the typecasting
later
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 383 (glusterfs server crash on 2.0.8)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=383
commit 07a1c8759cd82d77d00a027be4ae38352d04cc9d
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Nov 13 14:00:40 2009 +0000
fixes in stripe
* fix in stripe readv, so that a read request which falls in
two (or more) subvolumes, depending on stripe-size works fine.
* fix in stripe_setattr_cbk, where 'postop' stat structure was
returning wrong 'st_size'.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 368 (setattr on a non-regular file makes glusterfs crash)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=368
commit f74747b09e3674b873f4bde0725eb07913dfaf0d
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Nov 13 13:13:09 2009 +0000
mount/fuse: Assign the right inode to fuse_entry_out in fuse_create_cbk().
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 380 ([3.0.0 pre1] Crash in fuse_create_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=380
commit db0e1c012e26633c14f11fc40c27e929b4c89f6e
Author: Anand Avati <avati@gluster.com>
Date: Fri Nov 13 07:53:06 2009 +0000
protocol/client: preserve open/create flags in fdctx for reopening
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit 03c67eeb375f6c818883fa6154042d91316cc44e
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Thu Nov 12 04:06:04 2009 +0000
Disabled centralized logging by default.
Signed-off-by: Harshavardhana <harsha@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 366 (Infinite loop with centralized logging.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=366
commit ed04168a197620d1013e416674d8fd99f1f36f05
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Nov 11 14:26:10 2009 +0000
performance/quick-read: set return value to zero after successful init.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 374 (quick read fails to initialize if no options are given)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=374
commit 32ce543107ebad0b0b06ff5a058ef9f0e77e9120
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Nov 12 03:23:27 2009 +0000
mount/fuse: Prevent a hang on the mount point if no server is up when the client is started.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 373 (Spawn fuse thread after a parent_up and wait and block until child_up)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=373
commit 745063c0491cfb015ee53cdcf76f1d745ecb2980
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Nov 12 06:27:05 2009 +0000
extras/glusterfs-volgen: Make the script more user-friendly.
Error messages now print more detail.
Details of export/mount files written is also printed.
Also adds a new option '--version'.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 343 (Placeholder bug for adding volgen into rpm, bdb makefile changes, etc)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=343
commit 9ccdde679fe31095187dd1e9cfff4c37756b8109
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Nov 12 08:40:37 2009 +0000
cluster/afr: Fix self-heal loop driver termination logic.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit 123b3b8842181a3a60f7ee9c68c290eb74914892
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Nov 12 08:44:16 2009 +0000
cluster/afr: Ensure directory contents are in sync during opendir.
The problem: If some files on the first subvolume disappeared
without leaving a trace in the entry changelog (this can happen,
for example, when an fsck has deleted files or when a hard drive
is replaced), those files would never be self-healed even though
they would be present on the second subvolume. This is because
readdir is sent only to the first subvolume, and since the files
don't appear in the directory listing, no lookup would ever be
sent on them.
This patch fixes this problem by doing a readdir on all the subvolumes
during the first opendir on a directory inode. If a discrepancy in the
contents is detected, entry self-heal in a special "force merge" mode
is triggered on that directory.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 249 (Self heal of a file that does not exist on the first subvolume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=249
commit e3bf3b895764868af7b431f4066f15d796933424
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Nov 12 08:44:15 2009 +0000
cluster/afr: Refactored inode context bitmasks.
Defined symbolic constants for the bit masks and
made 'split-brain' a single bit field in the ctx.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 249 (Self heal of a file that does not exist on the first subvolume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=249
commit fee78f6753c1a7e8bdf8664c8a7bc112f23af9d9
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Nov 12 08:44:14 2009 +0000
mount/fuse: Do readdirp in fuse_readdir.
Do the readdirp FOP in fuse_readdir. This is needed because
dht_readdir is not "reliable", whereas dht_readdirp is.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 249 (Self heal of a file that does not exist on the first subvolume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=249
commit 20ea92d7860e57b2396ef11029039e1906e5bcac
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Nov 12 08:44:13 2009 +0000
cluster/dht: Do readdir in dht_readdir instead of readdirp
The readdir call will not be used by applications (fuse will
only ever send readdirp), but it will be used by
afr to do directory self-heal at the time of opendir.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 249 (Self heal of a file that does not exist on the first subvolume)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=249
commit 713067c9fe130847678fdb56456899e9eedba5ba
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Nov 12 19:48:54 2009 +0000
fix a crash in debug/trace
stat structure (which is an argument to function) was getting freed
instead of string which actually should have freed.
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 378 (trace segfault in trace_create_cbk)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=378
commit f8965cd3dcf32af834cb5e4a01b555d7480bad54
Author: Anand Avati <avati@gluster.com>
Date: Fri Nov 13 02:58:58 2009 +0000
protoocl/client: file directory reopen support
reopen files and directories which were open before a disconnection after
reconnecting. operations on files/directories which could not be opened
continue to return EBADFD
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit 879da1859efc02bde9a7fcbee5198205cd9cae48
Author: Anand Avati <avati@gluster.com>
Date: Fri Nov 13 02:58:25 2009 +0000
protocol/client: whitespace cleanup
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 170 (Auto-heal fails on files that are open()-ed/mmap()-ed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=170
commit 7c1e9f460c3077da5b37c02ce9e0774c162bf637
Author: vinayak hegde <vinayak@gluster.com>
Date: Wed Nov 11 22:52:01 2009 +0000
cluster/stripe: Initialize frame->local before checking for directory or regular files.
Signed-off-by: Vinayak Hegde <vinayak@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 368 (setattr on a non-regular file makes glusterfs crash)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=368
commit 4c7092199006e85383af60b52ff9136f85510742
Author: vinayak hegde <vinayak@gluster.com>
Date: Wed Nov 11 07:13:06 2009 +0000
cluster/stripe: Set local->inode value before referring it.
Signed-off-by: Vinayak Hegde <vinayak@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 362 (GlusterFS crash while doing mkdir in stripe setup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=362
commit 64a08db61cda2e223b709f97921a24d514244d8c
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Nov 10 02:32:50 2009 +0000
cluster/stripe: local was not being set in stripe_mknod_ifreg_setxattr_cbk()
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 367 (GlusterFS crash while doing mknod in stripe setup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=367
commit 1a3b03567be7a006553e24746019be87130f8c82
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Nov 9 14:17:34 2009 +0000
core: Replace inode_search with inode_grep in inode_from_path
This fixes a situation where the inode_from_path fails to
return an inode even though the inode exists in the table.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit f1bf7bb5cdf304fcc334e3d4b54c8e8669951110
Author: Sachidananda <sac@gluster.com>
Date: Mon Nov 9 08:33:25 2009 +0000
Add unhashed-sticky-bit option to volume_options structure
Signed-off-by: Sachidananda <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 365 (unhashed-sticky-bit is not recognized)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=365
commit a92e340b9ccf18ccd51c4a8a8eb973ad96465c1b
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Nov 4 01:23:18 2009 +0000
Add glusterfs-volgen to master, change fusermount options and other changes to rpm spec file.
The patch has the following changes:
* Rename glusterfs-volgen.py and include it in the rpm spec file
* Enable fusermount by default. Change fusermount configure option from disable to enable.
* Remove BDB from configure.ac, essentially removing it from the normal build.
* Remove all dependencies on fuse in the rpm spec file.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 343 (Placeholder bug for adding volgen into rpm, bdb makefile changes, etc)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=343
commit 2ec05f651d0033f37cea817f56876dd0ca78d72e
Author: vinayak hegde <vinayak@gluster.com>
Date: Wed Nov 4 23:36:35 2009 +0000
performance/stat-prefetch: In lookup_cbk do not set error no to EINVAL, when inode_ctx_get returns -1.
Signed-off-by: vinayak <vinayak@laptop.(none)>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 360 (All fop fails when stat-prefetch is loaded on afr.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=360
commit b11cb7f7ff66826ba07f31306879243aa3254a59
Author: vinayak hegde <vinayak@gluster.com>
Date: Thu Nov 5 02:54:27 2009 +0000
cluster/afr: In fop structure afr_readdirp is not correctly registered.
Signed-off-by: Vinayak Hegde <vinayak@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 360 (All fop fails when stat-prefetch is loaded on afr.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=360
commit cef492c772e7efaced41ac42069164e786eb2f44
Author: vinayak hegde <vinayak@gluster.com>
Date: Thu Nov 5 02:53:48 2009 +0000
performance/stat-prefetch: In sp_readdir_cbk op_ret value is not handled.
Signed-off-by: Vinayak Hegde <vinayak@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 360 (All fop fails when stat-prefetch is loaded on afr.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=360
commit 542f457c99cc385d564175faac570707a1bb148c
Author: vinayak hegde <vinayak@gluster.com>
Date: Thu Nov 5 02:53:03 2009 +0000
libglusterfs/src/gf-dirent.c: In gf_dirent_nb structure d_name should be char array of size 1.
Signed-off-by: Vinayak Hegde <vinayak@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 360 (All fop fails when stat-prefetch is loaded on afr.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=360
commit 36f6837a76426f22b63a061593b96ceff428809a
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Nov 4 02:03:05 2009 +0000
Do not abort make install if a chown on the fuser-mount script does not succeed.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 343 (Placeholder bug for adding volgen into rpm, bdb makefile changes, etc)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=343
commit 410ef443bf6450f08031db3396e1ecc25778636e
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Nov 3 11:08:32 2009 +0000
Remove fuse_lowlevel.h from xlator.h in libglusterfs.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 343 (Placeholder bug for adding volgen into rpm, bdb makefile changes, etc)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=343
commit af412848c9687ae94d5c0c18bbd9076f73142cbf
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Nov 4 00:15:20 2009 +0000
libglusterfsclient: Dont alloc root inode context
....because the lookup on root inode done a few lines before this
call already allocates an inode context. This one just over-writes
that context, results in invalidation of the cached iattrs.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 354 (Stale file handle on unfs3 booster)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=354
commit c6a036e6f45ec98e30ba0ca88b0dd98147f6494e
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Nov 4 00:15:19 2009 +0000
libglusterfsclient: Prevent root inode number clobbering
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 354 (Stale file handle on unfs3 booster)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=354
commit 95e0c62f68a2832b9b17e416cad3d0123d8ae904
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Nov 3 10:17:07 2009 +0000
cluster/afr: Bail out of the self-heal driver loops as soon as possible
Don't wait for the next recursive call to sh_{full,diff}_loop_driver
to decide that we've reached the end of file, as the frame could
have been destroyed by that time (if subvolumes are posix).
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit 5882e7486878fa69a7f22f5b99c2952668c0d34f
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Nov 3 09:23:03 2009 +0000
Remove unnecessary log message. It also accesses a freed lock after an 'unlock'.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 222 (Enhance Internal locks to support multilple domains and rewrite inodelks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=222
commit 6aeb2768f25fcde5463610e31ab4f23bea6d778c
Author: Corentin Chary <corentin.chary@gmail.com>
Date: Tue Oct 27 12:57:35 2009 +0000
transport/name.c: refine the address resolution logic when listen-host is not specified.
- when listen-host is not specified and there are are no interfaces having
adresses belonging to the address-family specified, listen at 0.0.0.0/::0.
- this patch is necessary since with AI_ADDRCONFIG, getaddrinfo fails if there
are no active interfaces for the address family specified and when
listen-host is specified we still want the functionality provided with
usage of AI_ADDRCONFIG.
Signed-off-by: Corentin Chary <corentin.chary@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 339 (glusterfsd fails to start when there are no active interfaces having address in the address family configured.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=339
commit c00d9318a4dbce3a9001379f94491c4401b24678
Author: Sachidananda <sac@gluster.com>
Date: Tue Nov 3 08:38:25 2009 +0000
Wrong variable is checked after stat call.
Signed-off-by: Sachidananda <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 355 (Wrong variable checked after a stat call)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=355
commit ad2066f9a84fb827c99a43576704b1c507ecdb92
Author: vinayak hegde <vinayak@gluster.com>
Date: Mon Nov 2 23:41:26 2009 +0000
configure.ac: Before checking for libglusterfsclient BUILD_LIBGLUSTERFSCLIENT should be initialized to no.
Signed-off-by: Vinayak <vinayak@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 353 (./configure adds libglusterfsclient when it shouldn't)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=353
commit c4e0a4d16b80ec0733aaee2248a0f8af113716c0
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Nov 2 03:24:10 2009 +0000
storage/posix: Changed error message displayed for option background-unlink.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 352 (Wrong message logged for option `background-unlink')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=352
commit f97aa5f724214e1ed1e3000cfd97f5bc5279d87a
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Nov 2 00:34:10 2009 +0000
features/locks: Do not try to set value in dict when lookup has failed.
lock-count was being set without checking for op_ret from lookup. This would
cause a lot of Critical messages in the log as dict would be NULL in case
of a lookup failure.
Also, removed some trailing white spaces and did some minor re-factoring.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 306 (Enhance locks to aid debugging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=306
commit a987ea47d51caaa4251ad883a9fa52adcc707787
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Oct 30 05:27:50 2009 +0000
cluster/afr: Don't try to self-heal if there are locks held
If the inodelk_count or entrylk_count is positive on a
file/directory, don't try to do self-heal on it.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 326 ([2.0.8rc9] Spurious self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=326
commit 170d49a909a73141a111208bbeb3ab5b127a858e
Author: Corentin Chary <corentin.chary@gmail.com>
Date: Thu Oct 15 06:32:41 2009 +0000
volgen: remove trailing whitespace
Signed-off-by: Corentin Chary <corentin.chary@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 8f657cfe3de69586a9a21045f100f0444cf8fe28
Author: Corentin Chary <corentin.chary@gmail.com>
Date: Thu Oct 15 06:32:40 2009 +0000
volgen: Add conf-dir option
Add a conf-dir option to change the output directory for
generated files.
Signed-off-by: Corentin Chary <corentin.chary@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 8ffe052655d079ccea825c9ff3c595a259ea21ba
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 30 03:43:54 2009 +0000
core: Use parent for condition to create dentry not name
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 348 (touch on booster segfaults)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=348
commit c46c1064888784c16d95b2221c2b684cb330b883
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 30 03:28:40 2009 +0000
booster: Must check errno for error number not return value
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 346 (booster returns success on failed getxattr and lgetxattr)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=346
commit 08a8f415f8f9470a01f5f052eacb2e8f0bf905c5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 30 03:28:39 2009 +0000
core: Check for NULL to avoid segfault
A segfault as a result of this was observed during tests.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 348 (touch on booster segfaults)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=348
commit ffe113bfba5429ba4f6dfda799cd6b4d04223131
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 30 03:28:38 2009 +0000
booster, libglusterfsclient: Support samba specific relative paths
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 158 (libglusterfsclient: Applications are restricted to using absolute paths)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=158
commit 2b89b0c015e1757e3e0c31d3211bf29971200a87
Author: Anand Avati <avati@gluster.com>
Date: Fri Oct 30 03:15:19 2009 +0000
iobuf: initialize size without 4KB padding
since new fuse bridge takes care of landing write buffers to aligned iobufs
and the 4KB header padding is no more necessary
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 04e90a4ddd73158f352f69df59ac633df49c750e
Author: Anand Avati <avati@gluster.com>
Date: Fri Oct 30 03:15:02 2009 +0000
glusterfsd: whitespace cleanup
Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 63d8a1a22096b5f097794d110205338e2771a5f3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Oct 30 01:26:19 2009 +0000
libglusterfsclient: don't do inode_link on root inode.
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 348 (touch on booster segfaults)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=348
commit faa47d7ac593d2b5b400bb2655fac1f038e12816
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Oct 30 00:10:20 2009 +0000
performance/io-cache: change the data-types to be big enough to hold size of data flushed.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 335 (Io-cache optimization)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=335
commit 01466cff66c6e6b30b1609271147c341f401fa97
Author: Pavan Sondur <pavan@gluster.com>
Date: Fri Oct 30 01:45:20 2009 +0000
Fix logic while granting blocked entrylks, which could run into an infinite loop.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 222 (Enhance Internal locks to support multilple domains and rewrite inodelks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=222
commit e19c619965e4490185ea7c61afa57fe7d2e959d4
Author: Anand Avati <avati@gluster.com>
Date: Thu Oct 29 22:53:57 2009 +0000
call-stub: fix leak of fxattrop dictionary
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 63a5de6d86703e31c8364a69365dd692ea2eada1
Author: Anand Avati <avati@gluster.com>
Date: Thu Oct 29 22:53:28 2009 +0000
protocol/server: fix leak of xattrop dictionary
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit decffb26516a8e86da802d8f416521762013ab73
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Oct 29 05:08:34 2009 +0000
cluster/afr: Move deleted files to /.trash in entry self-heal.
If entry self-heal determines that a file/directory should
be deleted from a subvolume, move that entry to a directory
called "/.trash" on that subvolume. This is for two reasons:
1) It limits the damage that can be done by a "wrong" entry
self-heal.
2) It solves the problem of a to-be-deleted directory not
being empty.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 227 (replicate selfheal does not remove directory with contents in it)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=227
commit a583f5e3849a10e16c73294b3f7d8e8fb5dd5506
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Oct 28 04:46:25 2009 +0000
performance/io-cache: change the hash function used for rbtree based hash table.
- the earlier hash function does not distribute pages uniformly for offsets that
fit into 32 bits. The reason is that the hash function just xors the contents of
the key 4 bytes at a time with the current value of hash. Hence for keys that
fit into 32 bits, the hash will be the key itself. Since we are using the
rounded_offset (which is a multiple of 128KB) as the key, the key will
be exactly divisible by the number of buckets configured (4096) resolving all
the pages into the first bucket.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 335 (Io-cache optimization)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=335
commit b3c43694640aace4b803695a800f0a36970dae04
Author: Pavan Sondur <pavan@gluster.com>
Date: Thu Oct 29 05:06:58 2009 +0000
Remove unnecessary check of xattr_req in lookup.
Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 306 (Enhance locks to aid debugging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=306
commit eb9a483448a32f8386d5238ef0041ad191fef71f
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Oct 29 07:32:46 2009 +0000
storage/posix: Serialize do_xattrop.
Hold a lock on the inode for the getxattr/add-array/setxattr
section since multiple threads can enter into it causing
wrong values to be written and triggering spurious replicate
self-heal later.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 326 ([2.0.8rc9] Spurious self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=326
commit 7bde0bf0c7322134c85ce2a57912476532537e46
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Oct 29 07:32:26 2009 +0000
storage/posix: Refactor xattrop
Move common code into do_xattrop.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 326 ([2.0.8rc9] Spurious self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=326
commit 1a9738feb0a3e195d5adc8902a32670940bb01fb
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Oct 29 09:09:15 2009 +0000
protocol/server, mount/fuse: Handle returned inode in create properly
Check if linked_inode is different from returned inode in create,
and if so, make the fd point to the correct inode.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 347 (Assertion failed: inode->ref)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=347
commit 6b5da1fcb6d9716294d4ffdd55890372ef69a2b5
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Oct 29 05:59:44 2009 +0000
transport/socket:Enable NODELAY by default for lowlat client and server sockets
TCP_NODELAY is enabled by default for lowlat client and server sockets.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 344 (Add support for TCP NODELAY in master)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=344
commit b4de3639225311a575408dd26b30146f84372080
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Oct 29 05:58:37 2009 +0000
protocol/client: Support for TCP_NODELAY
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 344 (Add support for TCP NODELAY in master)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=344
commit 4a434a97f0af7ef244e8f2799657b602bd9a5f50
Author: Vijay Bellur <vijay@gluster.com>
Date: Thu Oct 29 05:58:07 2009 +0000
transport/socket: Support for TCP_NODELAY
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 344 (Add support for TCP NODELAY in master)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=344
commit eff51cba7b548b8145415cfaa7f55e32c5c03581
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Oct 28 17:04:33 2009 +0000
Print inodelks in and out if option trace is on.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 306 (Enhance locks to aid debugging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=306
commit df488cafe841c7a903d27b7aa2792335eb7fb54c
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Oct 28 17:04:05 2009 +0000
Print entrylks in and out if option trace is on.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 306 (Enhance locks to aid debugging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=306
commit b96db1031da14b8c91250dcc95b6edd6b41aa0b1
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Oct 28 17:03:37 2009 +0000
Trace locks in and out with an option in normal log mode.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 306 (Enhance locks to aid debugging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=306
commit dae4c20dd88cb07b3905815a2418aacbb9df433e
Author: Anand Avati <avati@gluster.com>
Date: Thu Oct 29 01:03:09 2009 +0000
posix: posix_[f]setattr() handle valid=0 case by performing {f, l}chown (-1, -1)
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit fd3ebf4b51d8d1a65e40c2bd30a0872b3edfd1b0
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Oct 28 12:27:54 2009 +0000
Implement lookup in locks to return lock count in a dict value.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 306 (Enhance locks to aid debugging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=306
commit 4e1461a4653e16c9a8926c00739e1059b129ac78
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Oct 28 18:42:35 2009 +0000
libglusterfs/rbtree: change rbthash_init_table to take no of expected entries in the hash table as argument.
- the expected number of entries is used to create the memory pool of the hash
table. Having constant macro for this purpose is not suitable since different
users of rbtree based hash table store different number of entries in the
table.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 335 (Io-cache optimization)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=335
commit ff0ff663a8ea566d0787d4e2cf0b719b6a421541
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Oct 28 16:15:37 2009 +0000
performance/io-cache: fix memory leak.
- page table of cache was not being destroyed in ioc_forget.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 335 (Io-cache optimization)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=335
commit dbe9cd14d89ad0e8e2e49d8c2b3a86833519e644
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Oct 28 16:15:03 2009 +0000
performance/io-cache: fix double free.
- the destroyer function passed to rbthash_table_init is used to free the data.
The data being inserted is page and it is destroyed in ioc_page_destroy. Hence
no destroyer function needs to be passed to rbthash_table_init.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 335 (Io-cache optimization)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=335
commit 15761b951d8a502aba892cfd0f28c4b8b0902e4c
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Wed Oct 28 07:15:55 2009 -0700
Add -s (signoff) to format-patch.sh
commit 59522b82ba1fc4172db4fdfbf35f71eb051f9d79
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Oct 28 06:22:44 2009 +0000
Add glusterfs-volgen to master
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 343 (GlusterFS volume generator - 'volgen')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=343
commit 8523ebfa8d46148590d513eff6f643874a25531b
Author: Anand Avati <avati@gluster.com>
Date: Wed Oct 28 05:40:12 2009 +0000
fuse: use postbuf in truncate_cbk for attributes to return
this causes a problem where inodes even after truncate show old
file size for a short time (till attributes are expired in fuse kernel module)
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit d383e6a9a90aaa849164c357c2bc071cfdebeb33
Author: Anand Avati <avati@gluster.com>
Date: Wed Oct 28 04:20:14 2009 +0000
xlator: initialize all xlators in a loop instead of top down initialization
top-down initialization will miss out on xlators from disconnected subgraphs
and notify can go prematurely to these xlators
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 341 (mountpoint first access failure in single address space mode client/server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=341
commit 8c0cb7c261db64ec00aada355c39446d7adb3726
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Oct 27 08:47:28 2009 +0000
mount/fuse: Derive fd from the file handle for setattr
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 32fdb2dd2c435ed19294bf040cd7af751e334ded
Author: Anand Avati <avati@gluster.com>
Date: Wed Oct 28 02:36:31 2009 +0000
protocol/server: resolver fixes
1. do not set ENOENT for RESOLVE_MAY case
2. set op_ret to -1 and op_errno to EINVAL when request has neither of entry, inode or fd handles
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit b4eb7d34d760aee5f8da3691aa40278c65aebc34
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Oct 26 03:01:33 2009 +0000
performance/io-cache: change data structure used to store page-cache.
- io-cache uses rbtree based hash tables to store page-cache instead of lists.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 335 (Io-cache optimization)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=335
commit 5b802ac0a1fec4a58eb56405add59066989baeed
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Oct 27 06:09:46 2009 +0000
cluster/afr: Set local->fd in fsync.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 5a0b6adaa4e393785ab07d4de4c9e3af5a91db2a
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Tue Oct 27 05:52:16 2009 -0700
extras/init.d: make install directory configurable with --with-initdir
commit 3c3b79f9ac1e9d4e02f32c7597638986d2ccc0ac
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Oct 27 05:13:05 2009 +0000
mount/fuse: Use correct offset for name in fuse_getxattr
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 694518628d69a5d258a3b019fa857260ed8f9b18
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Mon Oct 26 19:53:33 2009 +0000
Don't stop an already running glusterfsd upon upgrade or install.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 338 (rpm post uninstall kills glusterfsd process)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=338
commit bec53711ee3b6f41d2f235e6c8bde9235361303d
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 26 11:57:28 2009 +0000
cluster/afr: Remove struct's for [f]chown, [f]chmod, utimens from afr_local_t.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 3958973ef2534e58f95ed312b58a170f32925a36
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 26 09:15:13 2009 +0000
cluster/afr: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 44172596eb492b392a75b5d8c1b284c05734c23e
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 26 05:24:19 2009 +0000
cluster/afr: Pick the data self-heal algorithm dynamically.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit 6a2fff62be18ead0728ca1b4d5322782eab4a673
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 26 05:07:31 2009 +0000
cluster/afr: Check the target of symlink's in entry self-heal.
During entry self-heal, make sure not only that a symlink
exists on all subvolumes, but also that their targets match.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 193 (symlink contents not self-healed by replicate)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=193
commit 4dd71ee812f1da3964923dc0f8e3822d91223436
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 26 05:34:21 2009 +0000
storage/posix: Ensure time(2) is stored in a 64-bit variable.
Before multiplying the time_t value by 2^32, store it in a
64-bit variable. This is necessary on 32-bit systems, where
time_t is only 32-bits, and left-shifting by 32 results in 0.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 17eb26c673c7c55ac414d91d126303ab834a9c16
Author: Anand Avati <avati@gluster.com>
Date: Mon Oct 26 05:45:59 2009 +0000
protocol/server: touchup loc only if inode/entry resolution was successful
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 3737626791dd7636605f66cb1358962b0da9694a
Author: Anand Avati <avati@gluster.com>
Date: Mon Oct 26 05:43:59 2009 +0000
protocol/server: fix assignment of inode number in server_readlink
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 8254d71cbaaae9c84494960600dbe997da84cf14
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Oct 23 13:02:01 2009 +0000
booster: seperate out the implementations of readdir and readdir64.
- readdir and readdir64 should not call same procedure booster_readdir
in their implementation, since the layout of dirent structures returned by
libc implementations of readdir and readdir64 is different (readdir returns
struct dirent *, where as readdir64 returns struct dirent64 *).
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 333 (ls on paths not on virtual mounts report wrong directory contents)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=333
commit 9ffc207383f10fcf3e097b8d568e4c077c1d0ac3
Author: Vikas Gorur <vikas@gluster.com>
Date: Sat Oct 24 08:17:36 2009 +0000
cluster/afr: Set read-subvolume to the source while self-heal is in progress.
Just before the lookup is unwound during background data self-heal,
the read subvolume is set to the self-heal source subvol so that
read operations on the file work correctly, and don't have to
wait for the self-heal to complete.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit bb74452c6d488cbd73bd78c3b4e5e730f0e2465b
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Oct 23 10:11:47 2009 +0000
cluster/afr: Do self-heal in the background.
This patch introduces a new option "background-self-heal-count", with a
default value of 16.
This means that upto {background-self-heal-count} number of files/directories
will be healed in the background at any given time. If such number of self-heals
are already in progress, further self-heals take place in the foreground.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit 25d1c236df5cb025fb185564c666491bf828453e
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Oct 23 09:31:52 2009 +0000
cluster/afr: Pipeline the "diff" data self-heal read-write loop.
Start upto "data-self-heal-window-size" instances of the read-write loop
of the "diff" data self-heal algorithm simultaneously.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit b290eb8de850ceb7bd95826cda1edd59a7a7d80e
Author: Vijay Bellur <vijay@gluster.com>
Date: Fri Oct 23 08:37:29 2009 +0000
mount/fuse: Don't use fsi if it is already cleaned up
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit bfe27e0c3dddf43d4ca45e29ea7189815c373234
Author: Anand Avati <avati@gluster.com>
Date: Fri Oct 23 08:23:20 2009 +0000
protocol/server: deep resolution support
when requested ino/gen is not available in the inode table cache,
then use the path presented by the client to lookup entries with
the hope that the requested ino/gen gets populated into the cache.
re-perform regular search after finishing the deep component
lookup
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 365e1db85edee93fd42a84e1f1123fbbb6cd26e4
Author: Anand Avati <avati@gluster.com>
Date: Fri Oct 23 08:22:49 2009 +0000
protocol/server: send fresh lookups on revalidate failures
also unlink non existent dentries in lookup_cbk
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit c43b1546ff4d0b7c5375aef9370460e140ca747b
Author: Anand Avati <avati@gluster.com>
Date: Fri Oct 23 08:22:20 2009 +0000
whitespace fixes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 0b8188c322ad916a216f706a455be73da0aebebe
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Oct 15 04:48:09 2009 +0000
cluster/afr: Pipeline the "full" data self-heal read-write loop.
Start upto "data-self-heal-window-size" instances of the read-write loop
of the "full" data self-heal algorithm simultaneously.
Add a new option "data-self-heal-window-size" with range [1-1024],
and a default value of 16.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 320 (Improve self-heal performance)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=320
commit 34589bd6bffb1e9827e600fe5955a3601d185c05
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Oct 23 06:44:46 2009 +0000
cluster/afr: Prevent spurious entry self-heal.
If the initial lookup shows that 'pending' is positive, then
self-heal will hold a lock and do a lookup again. This lookup
might show that 'pending' is zero everywhere. However, entry
self-heal used to consider this as a case of 'no sources' and
try to merge the directories. This patch checks for that case
and does not do the merge.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 326 ([2.0.8rc9] Spurious self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=326
commit 69edcf1884238044ca669031e8ebb7333078338b
Author: Anand Avati <avati@gluster.com>
Date: Thu Oct 22 02:04:39 2009 +0000
fuse-bridge: send fresh lookup on failed revalidate to return new nodeid
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit a8e866733969ff3a7ad10f8237e50e871d9627c5
Author: Anand Avati <avati@gluster.com>
Date: Thu Oct 22 02:04:21 2009 +0000
inode.c: whitespace fixes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 4dc9457306197fe92a35e149704946cb8da07ef7
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Oct 22 06:36:22 2009 +0000
cluster/afr: entry self-heal: Store parent_loc on the heap for impunge_parent_setattr.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 137 (Parent directory mtime not reset after a create in self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=137
commit 2e22779435e3d0d6847ba2906762998b656fe434
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Oct 22 05:37:36 2009 +0000
cluster/afr: entry self-heal: Set parent directory's attributes using a new frame.
There was a race condition in assuming that afr_sh_entry_impunge_parent_setattr_cbk will
always return before impunge_xattrop_cbk and impunge_setattr_cbk.
This patch fixes two additional problems:
1) Building the parent_loc from impunge_local->loc after STACK_WIND to
impunge_xattrop_cbk has happened. In a simple afr-posix configuration
the stack will have been destroyed by the time building of parent_loc is
attempted.
2) parent_loc built in impunge_newfile_cbk was not being loc_wipe'd.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 137 (Parent directory mtime not reset after a create in self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=137
commit 00972af5e9cb306fb683869a854f4041e4c49750
Author: vinayak hegde <vinayak@gluster.com>
Date: Tue Oct 20 23:56:28 2009 +0000
glusterfsd.c: Unnecessary writing of strerror of errorno on pipe
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 4 (mount --bind fails if run immediately after mounting GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=4
commit 2631239efb7c74a591090e8b0145f392d9ba7ee3
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 20 11:53:24 2009 +0000
protocol/server: generation number and dentry resolution
- handle generation number in protocol
- rewrite server dentry resolution code for inode cache miss
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 9304e0a949ed589873a6c3ffdfc8a2cf79fafd9d
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 20 10:54:24 2009 +0000
inode: fix internal refs and minor fixes
* also fix trailing whitespaces in a couple of places
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 644f080c127df792573d0d370d89d987f100bf69
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Oct 20 03:43:43 2009 +0000
performance/write-behind: fix to bug in setattr which was causing frames to be missed.
- local->file was being assigned even before file pointer was got from any of
the fds opened on the inode, thus making local->file to be NULL. In
wb_setattr_cbk, since local->file is NULL (and hence file passed to
wb_process_queue), wb_process_queue does not resume the pending operations
queued for the file.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 327 (dbench does not complete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=327
commit e6b0764b686c53ae2c9b898fb3030d370f711361
Author: vinayak hegde <vinayak@gluster.com>
Date: Tue Oct 20 07:18:16 2009 +0000
performance/read-ahead: Process state dump operations are added.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit 613e9ae2ff6c92d52062309c6dd88da740b85c4a
Author: vinayak hegde <vinayak@gluster.com>
Date: Tue Oct 20 07:17:42 2009 +0000
performance/quick-read: Process state dump operations are added.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit 65e1fdddd9ebb40014db48af83a778b8f13abe78
Author: vinayak hegde <vinayak@gluster.com>
Date: Tue Oct 20 07:17:06 2009 +0000
performance/write-behind: Process state dump operations are added.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit aa102d83c5ecebf74cfb0e35ee70a23a6f4e9467
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Oct 20 01:35:17 2009 +0000
cluster/afr: Attempt to set fd ctx in create only if the call has succeeded.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 325 (crash in afr_fd_ctx_set)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=325
commit 2b4c030f6dcad7c355c9bd59f6caba211776cb7c
Author: Anand Avati <avati@gluster.com>
Date: Sun Oct 18 15:02:02 2009 +0000
protocol/client: incoroporate generation numbers
protocol/client uses the new inode_ctx_{get,put}2 API to store both inode and
generation number in context
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 2c1f6783ced684eb3ce00b2f50016f6681aa5a68
Author: Anand Avati <avati@gluster.com>
Date: Sun Oct 18 15:01:07 2009 +0000
protocol: format changes to incorporate generation numbers
incorporate 64bit generation field in all protocol headers to accompany an inode
number
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 628a5118b774f638b69f52298182b11967dd4b08
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Oct 18 14:05:40 2009 +0000
inode_ctx_{get,put,del}2 API support
support for storing multiple values for a key in inode context - used for storing
inode and generation number pairs on the server in protocol/client inode ctx
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit bdb3b2ff2f2545669bff69bbda223908427097fa
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Sun Oct 18 13:35:15 2009 +0000
fuse: use inode_t address as nodeid and use new inode API
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit a77ae2b8fa16e28a549ff69271f10ffbf47c4a9b
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Sun Oct 18 13:35:14 2009 +0000
inode: API changes for generation number support
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit d1807b03430d229eb0601b16729e25e5120a929d
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Sun Oct 18 13:35:13 2009 +0000
inode: fix indentation and spacings
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 22cb522139f7164518541ac4902bb98cf5be10fc
Author: Anand Avati <avati@gluster.com>
Date: Sun Oct 18 11:42:30 2009 +0000
locks: fix leak in inodelk
unlock was resulting in leak of lock structure if it was unlocking the last existing lock
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 306 (Enhance locks to aid debugging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=306
commit 36f44886ff6fe294c17f06f401230f3dac6c5e27
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Oct 18 09:58:18 2009 +0000
storage/posix: Set right the op_ret value from posix_readlink()
Since op_ret was being returned as 0, fuse would regard the readlink () as a failure.
Also, set right the buffer size of gen_key in posix_{f, l}stat_with_gen.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit aaba494601a695d0bcdf58ef1294742ff153236b
Author: Anand Avati <avati@gluster.com>
Date: Fri Oct 16 09:13:22 2009 +0000
indentation fixes to conform to coding standards in locks
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 6cffef1d5f34993a682a75a8a9987a87af359579
Author: Anand Avati <avati@gluster.com>
Date: Fri Oct 16 09:12:57 2009 +0000
locks: keep ref on the inode while locks are held
keeping refs on the inode while there are held locks prevents the
inode from getting pruned away
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit a3b410bbd73dd256600ed83feb0e1aadb26e6582
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Fri Oct 16 08:48:42 2009 +0000
posix: posix_{f, l}stat_with_gen to return 0 on success (instead of >= 0)
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit e07bca4189bcf313693c94c26f63c562f86911a7
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Fri Oct 16 07:30:26 2009 +0000
posix - generation number support
- use sequential gen counter
- move span_devices handling and generation assignment to common functions
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit e42bcbd6b59c1b168c1ffb7c6df0f4fd5428fd72
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Fri Oct 16 07:30:25 2009 +0000
posix - use lchown and lchmod in setattr
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 1668d8abf9d0ad0c4f315fb3dfd888a9c6b17c4b
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Fri Oct 16 07:30:24 2009 +0000
distribute - more NULL check
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 74955ff7c7040b8df24fc11ae7c5f8d4eb12c0e2
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Fri Oct 16 07:30:23 2009 +0000
distribute,nufa: layout handling changes
changes to make revalidate not fail but instead perform fresh lookup
and swap inode context (layout) safely
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 03481c57fe2fc7d30589d60c13b7c1fd485136f3
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Fri Oct 16 07:30:22 2009 +0000
fix double initialization of dht_local_t
This was causing leak of the first initialized frame->local in
every create call
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit f849148691a596d2bc0f4129a0a7c0eb7c4a7d3c
Author: Anand V. Avati <avati@blackhole.gluster.com>
Date: Fri Oct 16 07:30:21 2009 +0000
NULL checks on local->loc.parent
check for presence of local->loc.parent != NULL before defering to
pick ino for post/preparent parameters. local->loc.parent can be NULL
legally when loc is describing "/"
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 315 (generation number support)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
commit 5dd31ef18bd95316d5151992d861360c236bc7f8
Author: vinayak hegde <vinayak@gluster.com>
Date: Fri Oct 16 00:38:25 2009 +0000
performance/write-behind: initialize frame->local before goto out label
if mtime,atime are not changed,
frame->local will not be initialized.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 310 (While trying to create a file on replicate with write behind set-up, client crashes.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=310
commit c4250c1b6f8073f181b7e90a34d54804fec6136b
Author: Anand Avati <avati@gluster.com>
Date: Thu Oct 15 11:28:00 2009 +0000
shuffle hash layouts on directories
allow for hash layouts to be written differently for different
directories to give a better spread for same filenames across
directories
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 324 (distribute does not spread files of the same name among all servers)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=324
commit 209b1189559f0b8de0feb2b4ee756f2548eff8ba
Author: vinayak hegde <vinayak@gluster.com>
Date: Thu Oct 15 00:27:14 2009 +0000
performance/write-behind: In wb_setattr, inode is checked twice
1. check for is it a directory,
2. otherwise check for inode and continue.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 310 (While trying to create a file on replicate with write behind set-up, client crashes.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=310
commit 9ab9f1f738de09b33eb04f08b3eab3cc26ebf186
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 15 01:47:54 2009 +0000
performance/io-cache: remove caching in lookup.
- caching file contents in io-cache during lookup is obsolete since quick-read
does the same work.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 314 (Hang in quick-read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=314
commit ee2b9bf021555479f4481101a3dc1473b536667b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 15 08:39:01 2009 +0000
performance/quick-read: frame->local need not be set in qr_open_cbk.
- local is used only by certain operations and hence it need not be set by
all the operations invoking open.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 323 (fd leak with quick-read loaded in translator tree)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=323
commit 15554bb1cd5c02d948fbe2e26b9b972ccffa1c11
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Oct 14 21:14:36 2009 +0000
performance/quick-read: flush should proceed with winding if fd-context is not found.
- if the fd-context is not set, quick-read has no role to play other than
just passing down the call to underlying translators.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 317 (Data corruption with write-behind loaded in translator tree.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=317
commit d87f4b236f222ec2d3b439343667186bcc1a324c
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Oct 14 14:00:58 2009 +0000
storage/posix: Use the right macro to set nsec of mtime in posix_do_utimes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 296 (handle futimes correctly in FUSE)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=296
commit b1184cbefcaadb39fa6f69a73564abdd94ffd537
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Oct 14 14:00:07 2009 +0000
mount/fuse: Initialize attr and set nsec values for atime and mtime.
attr was not being initialized and NSEC values were not being set in attr.
These were being referenced in posix_do_utimes which could cause a failure of
utimes ().
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 296 (handle futimes correctly in FUSE)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=296
commit bc2f6437c5a078179ae3a7f3729a6f97721d2dce
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Oct 14 13:48:23 2009 +0000
performance/write-behind:STACK_UNWIND happens only in failure path of wb_stat()
Only in case of errors STACK_UNWIND happens in wb_stat().
Also, fixed an incorrect check which would fail all writes.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 309 (In replicate set-up when exnihilate.sh is run , client crashes.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=309
commit f3fd53f6e6ac657a83d6b145ea2fdf617c75a541
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Oct 14 07:32:37 2009 +0000
storage/posix: Initialize op_errno to 0 in posix_create.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 309 (In replicate set-up when exnihilate.sh is run , client crashes.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=309
commit 8803952f12ec25bd9ca3cabce690229e5884e459
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Oct 14 05:50:59 2009 +0000
io-cache: NFS-friendly changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 2169bcdb4628f2b6efa8d2605b15abbdb03aa920
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Oct 14 02:07:25 2009 +0000
performance/write-behind: return from wb_open after STACK_WIND
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 312 (iozone crash in Distribute-Replicate)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=312
commit 1aa971466fbef17820fb3922fb77a79e124c3d48
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 13 07:32:46 2009 +0000
afr transaction: fix op_ret check during locking
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 112 (parallel deletion of files mounted by different clients on the same back-end hangs and/or does not completely delete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=112
commit 64bd5068320542a97653f0905e15acdbf3b9cad1
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Oct 13 06:42:28 2009 +0000
cluster/afr: Set mtime of parent directory in self-heal properly.
While creating/deleting an entry as part of entry self-heal,
set the parent directory's mtime to match that on the source
subvolume.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 137 (Parent directory mtime not reset after a create in self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=137
commit 457fb67710270bbb581a8b8533803266d41169e1
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Oct 13 06:42:13 2009 +0000
posix/client/server: Send postparent in lookup even if lookup fails on the entry itself.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 137 (Parent directory mtime not reset after a create in self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=137
commit 2bf882f817721fa07e880929412d10d0a3620565
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 13 06:42:15 2009 +0000
prevent spurious unlocks from afr selfheal
afr selfheal now remembers all the nodes on which locks were successfully
held and sends unlocks only to those nodes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 112 (parallel deletion of files mounted by different clients on the same back-end hangs and/or does not completely delete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=112
commit 67d7cb6937f3a7d286263cc90ccf353f204d0cb0
Author: Anand Avati <avati@gluster.com>
Date: Tue Oct 13 06:22:37 2009 +0000
afr transaction prevent spurious unlocks
mark a subvol with held lock only if op_ret == 0
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 112 (parallel deletion of files mounted by different clients on the same back-end hangs and/or does not completely delete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=112
commit ffb9c20c701c48d523d73af53bdd0beeee71143f
Author: vinayak hegde <vinayak@gluster.com>
Date: Mon Oct 12 23:38:41 2009 +0000
performance/write-behind: In wb_setattr file is used before getting fd context
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 310 (While trying to create a file on replicate with write behind set-up, client crashes.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=310
commit 72dc74a583c1da8314783ed842703885b5e650df
Author: vinayak hegde <vinayak@gluster.com>
Date: Mon Oct 12 09:09:33 2009 +0000
performance/write-behind: file is referenced, without checking for NULL
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 310 (While trying to create a file on replicate with write behind set-up, client crashes.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=310
commit 5c33a2e33d34762ec9d22e2aa68ac74960e79af0
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 12 07:01:13 2009 +0000
cluster/afr: Hold second lock after first lock has been granted for rename transactions.
Hold the lock on the {higher_path} only after the lock on the
{lower_path} has been granted successfully.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 112 (parallel deletion of files mounted by different clients on the same back-end hangs and/or does not completely delete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=112
commit c659b84f2279f6d74c8532c7f916e69f8c97dae3
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 12 09:12:45 2009 +0000
protocol/server: Set preparent and postparent in the response struct.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 30b9ad1aeed641e5a32fc1838f0206c79182635a
Author: Anand Avati <avati@gluster.com>
Date: Mon Oct 12 11:26:59 2009 +0000
replicate: fix missing frame in entry-self-heal
when files on all backend nodes are missing, the logic in afr_sh_entry_erase_pending
is broken and results in missing lookup frame. this causes processes to enter into
uninterruptible sleep state.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 311 (missing frame (lookup) when entry-selfheal finds missing files in all backend nodes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=311
commit b2f4e1794bc8acbb553b63f26989cb60a5a4eae8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Oct 9 12:40:19 2009 +0000
performance/quick-read: change the default option values in quick-read.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 273 (Code review and optimize quick-read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=273
commit a8baad24b61b8aed3355f166c23ae99886a1f37e
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 9 09:15:36 2009 +0000
posix: Ensure ENOTEMPTY return on rmdir
Since we added an extra step after rmdir, i.e.
the lstat on parent dir as part of the NFS-friendly
changes, the successful return from postparent lstat
clobbers the -1 error return from rmdir.
This prevents this particularly ENOTEMPTY error from
being propagated to higher translators.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit e7a9f5225d90cb16e8016f99553f75fc490175bd
Author: Anand Avati <avati@dev.gluster.com>
Date: Fri Oct 9 08:00:23 2009 +0000
Add INIT_LIST_HEAD which was left out in the previous commit
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 297 (Posix locks cannot handle a single unlock over multiple held locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=297
commit 2f2a81fa2251fa9210491d3e8d22e29f52073e51
Author: Corentin Chary <corentin.chary@gmail.com>
Date: Tue Oct 6 06:36:31 2009 +0000
Add all generated files to .gitignore
Signed-off-by: Corentin Chary <corentin.chary@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 35420909e1b458133dc45187dca6ce257abfb357
Author: Corentin Chary <corentin.chary@gmail.com>
Date: Fri Oct 9 06:25:11 2009 +0000
features/locks: Fix insert_and_merge
Init the list structure, because it will be used later,
and subtract_lock does not do it.
Also remove the special handling for unlocks, which was
probably introduced as a workaround for this bug.
Signed-off-by: Corentin Chary <corentin.chary@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 297 (Posix locks cannot handle a single unlock over multiple held locks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=297
commit 6186151d5e975e4705377909cc8dedb79c48a064
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Oct 9 02:40:10 2009 +0000
performance/write-behind: Add enable-trickling-writes to volume_options.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 276 (write behind needs to be optimized.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=276
commit f174b909df657ffb9cbf5052f3f43d7b0d39a13d
Author: vinayak hegde <vinayak@gluster.com>
Date: Fri Oct 9 02:38:13 2009 +0000
debug/trace: Check asprintf return value to avoid warning, while build
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 308 (Warning in debug/trace.c, during build)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=308
commit 3cc24f1650f9620d5db9d0e6fdc2ed892d4e08b7
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:56 2009 +0000
performance/stat-prefetch: checking for cache and creation if not present is made atomic.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 005250a69df6b1bc9a34628a9f09d95130eff30b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:54 2009 +0000
performance/stat-prefetch: lookup path in xattrop if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit d305bd71b0fc88cb98f0cd43b44d94bf5c3fecd5
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:53 2009 +0000
performance/stat-prefetch: implement sp_entrylk.
- lookup on path should be sent in entrylk if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit b497f47722d10cad56299170b5b9644f28a2f358
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:52 2009 +0000
performance/stat-prefetch: implement sp_inodelk.
- path has to be looked up in inodelk if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit ae8bd1b910fbac35418a817c922f9eb7522696d6
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:50 2009 +0000
performance/stat-prefetch: lookup path in removexattr if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 1f75810f1bb13a90b03f9d609d96687d334ce95e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:49 2009 +0000
performance/stat-prefetch: implement sp_getxattr.
- path should be looked up in getxattr if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 96ea84227ef7ff58a5a5d54a698a310e66ab5c8b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:48 2009 +0000
performance/stat-prefetch: lookup path in setxattr if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit f45e75f372def702c12f9cba686d0d95d3d39979
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:46 2009 +0000
performance/stat-prefetch: lookup path in opendir if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 9ac756bd38db9b6766721807cf50d81120f0b048
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:45 2009 +0000
performance/stat-prefetch: lookup path in create if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 841ca06f1e2a27bde5f77c9dc03db344c8cdceb3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:43 2009 +0000
performance/stat-prefetch: remove stat corresponding to oldloc->path from cache in sp_link.
- ctime of oldloc->path will be changed on completion of link fop.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 57ab9f02587c6a19e081a905c8e871a1f24ab945
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:42 2009 +0000
performance/stat-prefetch: lookup oldloc->path in link if it has not already been looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 7c14a104b5927822746ae5db1564834a10dcd81f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:40 2009 +0000
performance/stat-prefetch: lookup oldpath and newpath in rename if they've not already been looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit e874f8d4ef16eea6181d5a50bb8723532afd3687
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:38 2009 +0000
performance/stat-prefetch: lookup path in symlink if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit d587a563d6c4bf10549fab1d5e544d9b58c12552
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:36 2009 +0000
performance/stat-prefetch: lookup path in rmdir if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 610aede22b38dca9b295c1a5f951fc7f39e7c4db
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:35 2009 +0000
performance/stat-prefetch: lookup path in unlink if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit e55969ecc1ffef3286ca3fc5623dde05cc4f23ea
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:33 2009 +0000
performance/stat-prefetch: fix mkdir to unwind with proper number of arguments.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit dd5e622be1dc6450c66ebca991081304f6254889
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:31 2009 +0000
performance/stat-prefetch: lookup path in mkdir if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit e3d67548d76c2481b60090ebf92314a1e6d3ac10
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:30 2009 +0000
performance/stat-prefetch: lookup path in mknod if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit db8622f4aa38200717e27834787ba134dbb80fd9
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:29 2009 +0000
peformance/stat-prefetch: lookup path in readlink if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 516e25b20a6f28c49007bda82eeabadd295616a0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:27 2009 +0000
performance/stat-prefetch: implement sp_access
- sp_access should send lookup on the path if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 2589474ef60c11b8fb55184096ad1ef28fc10b4d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:26 2009 +0000
performance/stat-prefetch: lookup path in truncate if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit d08fd2445bdbaeb561db2a7a4b8c32f9e9d043cd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:16 2009 +0000
performance/stat-prefetch: lookup path in setattr if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit fd4b69834d7f28075b1afef6386f2b4153ca768a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:14 2009 +0000
performance/stat-prefetch: implement sp_stat.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 6463634dea251aa82b6911a95cf87940a270426f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:12 2009 +0000
performance/stat-prefetch: lookup path in checksum if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit e4c50e4449f3477218db0cc3ae38ef9d9b717b07
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:11 2009 +0000
performance/stat-prefetch: lookup the path in open if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 292ec8684dab465f1485e15d7713dcb4212f92f0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:10 2009 +0000
performance/stat-prefetch: implement procedure sp_process_inode_ctx.
- this procedure processes inode_ctx to make decisions like whether the
current procedure can continue (i.e., inode is already looked up),
or the procedure has to initiate/wait for lookup on the path. It also
sets up the frame->local and adds the stub corresponding to current fop
if needed.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit ff95c2de2f88e4ef244a95be6a751046298823b2
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:08 2009 +0000
performance/stat-prefetch: use op_errno instead of errno to store error code.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit d50a98cc4ef19d8c699830ccef6af2e256d32aba
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:07 2009 +0000
performance/stat-prefetch: Add support code to implement lookup-behind.
- change sp_lookup and sp_lookup_cbk to support sending lookups when needed.
lookups might need to be sent in fops like open, chmod, chown etc which
operate on a path, since the actual lookup sent to stat-prefetch by its
parent xlators is not propagated down the xlator tree if the path is
cached.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 7655359c9fd644e7517c192067b9d33c80973e7e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:05 2009 +0000
performance/stat-prefetch: remove lookup-behind in sp_lookup.
- lookup-behind should be done on-demand basis, in fops like open
instead of in sp_lookup itself. This would reduce network traffic
between client and server related to lookup, if the only use of
lookup was to fetch stat structure.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit d14e03903392d939a220d93589c2ff4fb73b7cb8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:04 2009 +0000
performance/stat-prefetch: optimizations to sp_lookup.
- if stat cache cannot be found for a path in its parent inode and the path
is a directory, we can get the cache from the inode corresponding to path
and look for "." in that cache.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit cff0d4e45138d8508f7d31669cc0af72f7233c87
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:02 2009 +0000
performance/stat-prefetch: Add accounting of cache hits and misses.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit ceed1c5a533fa90cf8fb0fe580b71f9c1c0cafcf
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:21:01 2009 +0000
performance/stat-prefetch: change behaviour of sp_lookup when xattr_req is not NULL.
- if the xattr_req is empty (fuse just creates an empty dictionary and
sends along lookup) we can still use the cache prefetched during readdir,
since we need not fill the reply dictionary.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 0c82e80a98f3bdb1482230e6795bdbda94d77ac8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:20:59 2009 +0000
performance/stat-prefetch: change the cache to use rbtree based hashtable instead of list for caching dentries.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 2fdcb3b56282b505ea492d63db59614e7e5da419
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 06:20:50 2009 +0000
performance/stat-prefetch: fix memory leaks
- sp_cache_get_inode uses fd_lookup which internally increases the refcount of
fd by 1. This needs to be unrefed once we get the cache.
- for directories, stat is stored in the inode context in sp_lookup_cbk.
but, while doing so, no check was being done for the presence of context
in inode, resulting in leak of memory equal to sizeof (struct stat) when
multiple lookups happened on the directory.
- path constructed in sp_readdir was not freed.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 628909426f678e970b1688a4f469fdb40b243f37
Author: vinayak hegde <vinayak@gluster.com>
Date: Thu Oct 8 23:35:57 2009 +0000
debug/error-gen: Feature enhancement of error-gen translator
In debug/error-gen translator 3-options are provided.
failure - specifies the percentage failure in fops.
error-no - specifies which error-no to be returned.
enable - specifies which are the fops to be enabled for this translator.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 291 (feature enhancement of error-gen translator)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=291
commit 6d83eb6ed6cd3b401c5c3b7f198caec4e08e02f8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Oct 9 00:05:43 2009 +0000
performance/write-behind: Refining the check for fd_ctx in fds
- An fd opened on a directory should not be considered bad if the fd context
is not set since the context is set only for fds opened on files.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 260 (ls on booster VMP results in error: "File descriptor in bad state")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=260
commit ab16ae1ff64049b905f13dea48906f026e4c367e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Oct 8 05:59:49 2009 +0000
libglusterfs/defaults: default_readdirp should call fops->readdirp instead of fops->readdir.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 88cdbc46dbbb1f10c51dd0486b68240e306b491a
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Oct 8 06:31:33 2009 +0000
performance/write-behind: Change STACK_UNWIND to STACK_UNWIND_STRICT.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 3846f1fdab2002e5f97bdebe0b3b5a921352f0c3
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Oct 8 05:48:21 2009 +0000
cluster/dht: Change STACK_UNWIND to STACK_UNWIND_STRICT.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 0a48c42b5e304939802c42c1b77ffe74d5631bc4
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Oct 7 13:12:36 2009 +0000
Initialize local before any call to STACK_WIND to prevent a crash
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 304 (Write behind crashes when a chmod is issued)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=304
commit 2c6dae6523ef929bcb9d03345a2b4937863043c9
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Oct 7 12:55:54 2009 +0000
assign client_readdirp to .readdirp in protocol/client & fix 2 other bugs in call_stub
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 305 (Readdirp crashes in client protocol)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=305
commit 351bc5e011974565df88b6e68b77cc92a6c3bfb6
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Oct 7 06:43:44 2009 +0000
mount/fuse: Handle FATTR_MODE flag properly.
Handle the FATTR_MODE flag in fattr_to_gf_set_attr.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit d02b9245c4c5d5b770500efdd1819efebdbf9233
Author: Vijay Bellur <vijay@gluster.com>
Date: Mon Oct 5 23:59:13 2009 +0000
Changed occurrences of Z Research to Gluster.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 69ce57492ad3dfea52fe7dc3438e46e0a4f17c04
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Oct 7 04:38:49 2009 +0000
cluster/afr: Change STACK_UNWIND to STACK_UNWIND_STRICT.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 8421d69fb153a8b5ebcf5f39105ea5cfa6b95894
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 5 09:25:33 2009 +0000
mount/fuse: Don't send fsetattr if ATIME or MTIME needs to be changed.
There is no "futimes" call. Hence, if either the FATTR_MTIME or FATTR_ATIME
flag is set, don't send fsetattr.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 296 (handle futimes correctly in FUSE)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=296
commit 7baab57705fc820a78f709b1438c175c01f49798
Author: Pavan Sondur <pavan@gluster.com>
Date: Mon Oct 5 09:45:52 2009 +0000
Removed remaining references to chmod, chown and utimens as part of setattr changes.
Removed references to chmod, chown and utimes. Removed utimes references in AFR and writebehind.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit e5835d77277b56d4421b0de555fc5d6e8b188b50
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Oct 5 07:42:02 2009 +0000
core: Add rbtree based hash table
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit d80ca9b40770786c5bc4d6fa2d0799904177f5cf
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Oct 5 07:42:01 2009 +0000
mem-pool: Include stdlib for calloc()
Doing so removes build warnings about calloc and free
for files that use mem-pool but do not by themselves
include stdlib.h, for eg., rbthash.c
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 0ba388c1a720de215704f73562732f45f31c9f46
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:08:07 2009 +0000
libglusterfsclient: Port directory reading to readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 12d9d9dab5711f88d0d329c231e8a9bf3c1925b1
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:08:06 2009 +0000
client: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit ead810cc341fa5c342d2684bbfd6cac15b38af3b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:08:05 2009 +0000
server: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 2673a33eaed188cbfbe557db46b316dae857b8e7
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:08:04 2009 +0000
stat-prefetch: Port stat-prefetching to readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit e45a14e9ce15b59e30692c0f9b389e3438a823e0
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:08:03 2009 +0000
io-threads: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 9e8f9972b7ecbc11f3592c1393b162a0a6fd0e56
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:08:02 2009 +0000
trace: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit d0fdbd09ff58ca1da073f73f4a6223dc77505f37
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:08:01 2009 +0000
io-stats: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 171cab1a59253e125e08fec86dd3c9f793cca7e9
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:08:00 2009 +0000
error-gen: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 3675e6ecdf344a68e333de3f1a6aeb6db5f115f0
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:07:59 2009 +0000
unify: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 218090f0df5fec11c743ecdd412ae84759f5fa2e
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:07:58 2009 +0000
map: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit aa9f7c2dbf05a16e2535727133cae74691fbfb8b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:07:57 2009 +0000
ha: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 4ef8e787b21cf7d4556a70ebd0caea7e71d78ad9
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:07:56 2009 +0000
distribute: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 0a2ba0647f4eedaebdf572e3220438d9a125bc24
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:07:55 2009 +0000
afr: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit ac4e7218d7c56df2dc3ce11ccf066f9bce5ca041
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:07:54 2009 +0000
posix: Support readdirp fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 82024946c8957beb6713de9a2e42b26e3aba8477
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Oct 2 03:07:53 2009 +0000
core: Separate readdirp and readdir fops
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 292 (Separate readdirp functionality from readdir fop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=292
commit 4beb704322ef0f8b2472f0d44a98c3b9e265c762
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Oct 6 06:45:04 2009 +0000
storage/posix: Process "glusterfs.content" key in lookup only for regular files.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 301 (lookup should ignore ISDIR error when trying to get content)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=301
commit b86092e6be399cdcc8cd6f54b52d9949ac8f62a5
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 5 05:38:09 2009 +0000
features/locks: Change STACK_UNWIND to STACK_UNWIND_STRICT.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 1577eba728c5a07aa9b7db01b68f2b40b881dace
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 5 05:37:51 2009 +0000
storage/posix: Change STACK_UNWIND to STACK_UNWIND_STRICT.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit d1d9e489c88fcb0dc7f7168bc41d514d8ddde28a
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 5 05:37:31 2009 +0000
libglusterfs: Add STACK_UNWIND_STRICT macro.
STACK_UNWIND_STRICT (op, frame, this, op_ret, op_errno, ...)
The "op" argument is the name of the fop (lookup, open, etc.).
This macro makes sure that the number and type of arguments
passed match those of the callback function for the fop.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 269 (Add a specialized STACK_UNWIND macro for each FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=269
commit 0eafa3f5d0dbddfea9327c109c7d6fe471c2c300
Author: vinayak hegde <vinayak@gluster.com>
Date: Mon Oct 5 05:21:58 2009 +0000
glusterfsd.c: Pipe is used during daemonization as ipc.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 117 (Wrong command line does not throw error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=117
commit 52b000f75b7dbdf73fc37acaf4a7f7ea7bc691f6
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Oct 5 04:01:36 2009 +0000
cluster/afr: Initialize local->first_up_child in AFR_LOCAL_INIT.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 285 ("first up child" can change during a transaction)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=285
commit 03f4e66088128e82880e24c1b11473db4b359762
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:16 2009 +0000
libglusterfsclient: Remove redundant fchown and fchmod
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit ff30034fac0defa8e266bf96acacd567c9e50d5f
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:15 2009 +0000
libglusterfsclient: Use fsetattr for fchown
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit babd32c3e1ef3f1371db6c4577cbe0161d298ab7
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:14 2009 +0000
libglusterfsclient: Use fsetattr for fchmod
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 2176c372ab46e6eadfa09b00a67a68bb263d87cc
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:13 2009 +0000
libglusterfsclient: Support fsetattr fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 752a4787702c0de771ee5c7250994ebd98025747
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:12 2009 +0000
libglusterfsclient: Remove redundant chown code
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 137a61cb6678c03d9d3093385aa9c3a48da85b21
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:11 2009 +0000
libglusterfsclient: Remove redundant chmod code
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 3c8996c1616d66773fe206d9747846222207d525
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:10 2009 +0000
libglusterfsclient: Remove redundant utimens code
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 13e429b625e9832329df7bc8fcee1435f3625c52
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:09 2009 +0000
libglusterfsclient: Use setattr for utime
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 47a32e34d391e5510a827d5a0645aafd02d94bbe
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:08 2009 +0000
libglusterfsclient: Use setattr for utimes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 74f07cdd568806b1762ec78c10aa00fc4e7d582a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:07 2009 +0000
libglusterfsclient: Use setattr for chown
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 5cf77a389a97ed124da5748e29186c50197d3f6c
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:06 2009 +0000
libglusterfsclient: Use setattr for chmod
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 5bd15af0c336c4742ecb87050ffab57ab0c0519a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:05 2009 +0000
libglusterfsclient: Support setattr fop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit 12b54c1728de74cd184e467b75fe2aacbff1eddf
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:04 2009 +0000
distribute: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit b6b4e60b68f4441dfb5f8cf249452abb51c907aa
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:03 2009 +0000
ha: Handle memory allocation failures
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit c30c8878bb4c9ceca867749fb2b8fee13d1f03d2
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:02 2009 +0000
ha: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 910a8540babe6142eb912c6309af3dd525983085
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:01 2009 +0000
symlink-cache: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 20475b26852439d5c6bcd5acc8314c4d04d8ef87
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:59:00 2009 +0000
io-threads: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit e76ad357b21f23a29068e37aacc5fbd001ae9560
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:59 2009 +0000
read-ahead: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit b8542e6ffd5a7f302eee0b7a5806a5a6e697d1fd
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:58 2009 +0000
write-behind: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 35bbe2b93c55051c47b08d93b041fdca30fac609
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:57 2009 +0000
filter: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 53e9d07f9b03045ee169979bb188b9cfc85b6d35
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:56 2009 +0000
stripe: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit fb8b60ce2971a020fd68526e15ce1b21e2f07d8e
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:55 2009 +0000
error-gen: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 8450d7aa5a9cc7d0c09e399c63e8e629845ef00d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:54 2009 +0000
locks: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit e8bacf085456c6efeb828973c2d4c5312e14ac4e
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:53 2009 +0000
io-stats: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit d29316a35c5c49377c73385f4ff0ff096b8d99ae
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:52 2009 +0000
trace: NFs-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 02f760977ae5fa22db1e1dc0a1555faf20f061a9
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:51 2009 +0000
client: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 958774e6acabbf6b3cb6b0ec9a88a4d3d4b2b088
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:50 2009 +0000
server: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 78f613c930ad7950b295d79c8341df47847cd5b4
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:49 2009 +0000
posix: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit b3dde5d62925720fea49ce7b8c40f5e7f9521fef
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:48 2009 +0000
unify: NFS-friendly logic changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 69e8010ce6771a46ef21facc0694c89b17c71f66
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:47 2009 +0000
Global: NFS-friendly prototype changes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 145 (NFSv3 related additions to 2.1 task list)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=145
commit 4772c35866c1a8d1fd611e053720327d1408261d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Oct 1 06:58:46 2009 +0000
Global: Introduce setattr and fsetattr fops
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 146 (Add setattr FOP)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=146
commit a39498b7eec430e4503a9d812d922bb66df41086
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Sep 30 05:48:22 2009 +0000
Changes to use this->name while using logging instead of explicitly mentioning posix-locks.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 290 (Clean up a calls to gf_log in locks' code)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=290
commit 83b050a6fd13811df2c68c374d6ea689f93efdbf
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Sep 30 05:47:49 2009 +0000
Make changes such that glusterfs builds with Werror and fix LONG_LONG_MAX definition.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 289 (glusterfs does not build with Werror)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=289
commit 14809ce4a4a7bc7bc1992fb9c6ed5acc95d9eea8
Author: Pavan Sondur <pavan@gluster.com>
Date: Tue Sep 29 11:03:54 2009 +0000
Check if path is valid after call to inode_path before accessing it.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 287 (call to inode_path can result in a segfault)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=287
commit cb9143494db0b4df817300223f7aaa942af2be3c
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Sep 28 20:58:26 2009 +0000
cluster/afr: dir-write: Fix inode number handling.
create, mkdir, symlink, mknod: Prefer to return itransform'd inode number
from the first_up_child. If not, fall back on any other child that returned
succcess.
link, rename: Return the same inode number that
was passed as part of loc_t.
Also adds a new member to afr_local_t, local->first_up_child
which is initialized at the start of the transaction. This
fixes the race where a subvolume might go down during the transaction
and thus have the first_up_child change.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 285 ("first up child" can change during a transaction)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=285
commit 544e63fd9ddc9a55f7e03902db4d0a43e87dbb6b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 25 02:55:12 2009 +0000
libglusterfsclient: don't destroy the iobuf pool during fini.
- some of the iobufs in pool will be cached by io-cache and hence refcount
will not be zero. Hence the assertion of ref being zero in
__iobuf_arena_destroy fails. Commenting out iobuf_pool_destroy during fini, till
we introduce proper cleanup in all translators, thereby allowing io-cache
to release the buffers it has held.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 283 (booster aborts complaining the refcount of iobuf is not zero during glusterfs_umount_all.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=283
commit 914ba8c3d4d86cd4a60ee2a4c47c0fb71bd57360
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 25 02:55:44 2009 +0000
libglusterfsclient: traverse the vmplist during fini only if any entries are mounted.
- the vmplist.list is inited only during mounting of first entry. Hence doing
a list traversal when no vmpentries are present, results in a segfault.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 282 (segfault of applications using booster observed when the application does not mount any vmps.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=282
commit 0b097e591c51681a657cb0146f2ed93f514caaf7
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 24 04:18:18 2009 +0000
cluster/afr: Fix memory leak in "diff" self-heal algorithm.
FREE sh->private after diff self-heal is done.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 281 (memory leak in "diff" self heal algorithm)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=281
commit ca1e9f998a47f5a21406bc556c20152629336176
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 24 04:30:06 2009 +0000
glusterfsd/main: Do a sem_post only if running in daemon mode.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 4 (mount --bind fails if run immediately after mounting GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=4
commit 4bc2a2599cd1015fed5c91860bddb19141a654d1
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Sep 24 00:49:52 2009 +0000
booster: Cleanup booster_cleanup and register for atexit
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 279 (File written with booster results in self-heal after dd exits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=279
commit f21f1b8b165ce34ff62a799f06bcfd87f65f4670
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Sep 24 00:49:51 2009 +0000
libglusterfsclient: Support TRACE loglevel
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 210 (libglusterfsclient: Enhance logging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=210
commit f64c57bbbd858d2e8e6a7a34293d112733f1b391
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Sep 24 00:49:50 2009 +0000
libglusterfsclient: Wait for all call pools to be destroyed
This ensures that the process using libglusterfsclient does
not exit before all the fops and calls have been replied to.
It helps to ensure that the backends are in a sane state when
the program exits.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 279 (File written with booster results in self-heal after dd exits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=279
commit 516d5e9d20bde84c44df1eb3cf6273bc7421d110
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Sep 24 00:49:49 2009 +0000
libglusterfsclient: Clean up fini and umount code paths
This patch cleans up the umount and fini paths in preparation
to support waiting for unwind of all pending call frames.
Two misc fixes are:
1. Fix to avoid deadlock in _libgf_umount by
using _libgf_vmp_search_entry instead of
libgf_vmp_search_exact_entry since the latter tries to take a
lock already help by _libgf_umount.
2. Avoid a crash in _libgf_umount by deleting the vmp
entry from the list before it gets freed.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 279 (File written with booster results in self-heal after dd exits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=279
commit ce455ffe075784cf5e06f316e1957dd6e31ffe43
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Sep 24 00:49:48 2009 +0000
iobuf, logging: Expose existing functions as required
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 279 (File written with booster results in self-heal after dd exits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=279
commit 7fa3dd19e4a14feb7f5b7a10d2b05eb2f6df2e5d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Sep 24 00:49:47 2009 +0000
libglusterfsclient: Reduce logging aggressiveness to TRACE
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 210 (libglusterfsclient: Enhance logging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=210
commit 3d3003383beef00cb8908ce0ed284ce6f97fb2ce
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Sep 24 00:49:46 2009 +0000
booster: Reduce logging aggressiveness to TRACE
Internal users feel the amount of logging brought in
due to a previous logging enhancement patch is a bit too
aggressive for DEBUG, so this changes it to TRACE.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 210 (libglusterfsclient: Enhance logging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=210
commit 44b5305a39e14cd30703f2e20a82458b52428487
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Sep 24 01:01:00 2009 +0000
libglusterfsclient: Re-validate root inode on every path resolution
If the root inode's is outdated, send a revalidate on it.
A revalidate on root inode also reduces the window in which an
op will fail over distribute because the layout of the root
directory did not get constructed when we sent the lookup on
root in glusterfs_init. That can happen when not all children of a
distribute volume were up at the time of glusterfs_init.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 256 (revalidates should be sent on '/' in libglusterfsclient.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=256
commit 3593e85a6cb73c48d52c5e5fc914aee489e2785d
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Sep 24 00:59:04 2009 +0000
performance/write-behind: Add a NULL check for request->stub before checking request->stub->fop.
- for non-write wind requests, the request structure outlives the stub.
The call stub is destroyed when stack is wound but request is destroyed
only when the reply has come.
(for writes, both stub and request are destroyed when refcount becomes 0,
which happens only when the write operation is stack unwound and a reply
for the write operation has come from underlying translators, for non-write
unwind requests the request is first destroyed before resuming the stub).
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 280 (simple stripe, with write-behind set up, when dbench is run client crashes.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=280
commit 41707342b66dbc421bb90af27d57bfa9fb36dc16
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Sep 22 07:53:14 2009 +0000
fuse: emit a flush from release if we didn't get an adjacent FLUSH message from the kernel
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 223 (flush not sent)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=223
commit 571e95d65e23777ce707bae4d113831b9f4ec944
Author: Pavan Vilas Sondur <pavan@dev.gluster.com>
Date: Wed Sep 23 06:03:25 2009 +0000
Implemented inodelks with support for domains.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 222 (Enhance Internal locks to support multilple domains and rewrite inodelks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=222
commit 3643f8afb40e7f9095a8613a765fad4ea698d349
Author: Pavan Vilas Sondur <pavan@dev.gluster.com>
Date: Wed Sep 23 06:02:55 2009 +0000
Implemented entry locks and support for domains.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 222 (Enhance Internal locks to support multilple domains and rewrite inodelks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=222
commit 558405096e9e16f8601f3d71400338809037d570
Author: Pavan Vilas Sondur <pavan@dev.gluster.com>
Date: Wed Sep 23 06:01:10 2009 +0000
Removed internal.c and old domain definition in locks.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 222 (Enhance Internal locks to support multilple domains and rewrite inodelks)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=222
commit 7a7789488a7af846bd2d342940736c0b4efea1a5
Author: vinayak hegde <vinayak@gluster.com>
Date: Wed Sep 23 06:19:21 2009 +0000
Changes for custom daemon function.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 4 (mount --bind fails if run immediately after mounting GlusterFS)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=4
commit 1ce5b3bd2f9a1de32de3699e0f7f0e2835f6bef1
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Tue Aug 11 13:21:11 2009 +0000
mount.glusterfs had a problem understanding when "volfile" was given as one of the mount arguments.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 204 (mount.glusterfs mounts to incorrect mount point)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=204
commit 6f7571b8ecbc7ba0ef20d7b923eddbac92464808
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 23 00:22:17 2009 +0000
performance/write-behind: store currently aggregated data size in wb_file
- this helps us to not traverse the request list whenever we need currently
aggregated data in the queue
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 276 (write behind needs to be optimized.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=276
commit a7fdbe4dff5947a4ba26e74b6786f3ab72e08ae0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 23 00:21:51 2009 +0000
performance/write-behind: store the current window size in wb_file.
- this would increase the performance since we don't have to traverse the
request list every time we need the current window size.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 276 (write behind needs to be optimized.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=276
commit 9b7410b60984ec99226f435135de5da3cf0698fc
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 23 00:21:31 2009 +0000
performance/write-behind: reduce usage of iov_length.
- request structure now holds a member write_size which is initialised at the
time of request creation and used later.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 276 (write behind needs to be optimized.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=276
commit 5e72aea5062ab56bec7ceddf49494ca6653f3331
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 17 05:56:32 2009 +0000
cluster/afr: Add new option "data-self-heal-algorithm"
option: data-self-heal-algorithm type: string default: "full"
This option allows the user to specify the algorithm to
be used for data self-heal. Currently supported values
are "full" and "diff".
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit c56eef93bc8f07a538f461b0c13d2b1ce93ae082
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 17 05:56:31 2009 +0000
cluster/afr: Add the "diff" self-heal algorithm.
The "diff" self-heal algorithm works as follows:
For each block:
Compute MD5 checksum on source and all sinks
If checksum on a sink differs from source:
Read block from source and write to sinks
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit d85c187d1391b69da36f3852a66e66517023d254
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 17 05:56:30 2009 +0000
cluster/afr: Make the self-heal algorithm pluggable.
Abstract the read/write loop part of data self-heal. This
patch has support for the "full" (i.e., read and write entire
file) algorithm.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f29973b63fbd63ff7b733cea0e10e71f055f5032
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 17 05:56:29 2009 +0000
cluster/afr: Open source and sinks in read/write mode during self-heal.
Since a self-heal algorithm (e.g., rsync) might want to both read
and write from both the source and sink files, open them as O_RDWR.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 3221b48e1ceeed6af17143b6c7395af4fc665e0c
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 17 05:56:28 2009 +0000
protocol/server: Implement rchecksum.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b79e6028615bdfac50a876fef48949857e947198
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 17 05:56:27 2009 +0000
protocol/client: Implement rchecksum.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 2a51754ca4d07034bb3db3398380c31c2b6167fc
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 17 05:56:26 2009 +0000
storage/posix: Implement rchecksum.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit dc1adad787a4e0c92291d15b8b4aa18e4996403b
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 17 05:56:25 2009 +0000
libglusterfs: Add RCHECKSUM fop.
rchecksum (fd, offset, len): Calculates both the weak and strong
checksums for a block of {len} bytes at {offset} in {fd}.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e2eb45426e81d78fc41d348da9622411677dbfba
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 17 05:56:24 2009 +0000
libglusterfs: Add checksum functions.
gf_rsync_weak_checksum: Calculates a simple 32-bit checksum.
gf_rsync_strong_checksum: Calculates the MD5 checksum.
The strong checksum function makes use of Christophe Devine's
MD5 implementation (adapted from the rsync source code,
version 3.0.6. <http://www.samba.org/ftp/rsync/>).
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b572bca2578dc9a14fa6d7b6a62546f6e5c1abe2
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 22 00:22:12 2009 +0000
booster: implement F_DUPFD command in fcntl.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 277 (running dd on booster returns EINVAL)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=277
commit 44f8ec978f05a2b1908d6ede9d3d2c7c4fa70dde
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 22 01:39:10 2009 +0000
performance/write-behind: add option "enable-trickling-writes".
- With this option enabled, writes are stack-wound even though not enough
data is aggregated, provided there are no write-requests which are
stack-wound but reply is yet to come. The reason behind this option
is to make use of the network, which is relatively free (with no writes
or replies in transit). However, with non-standard block-sizes of writes
the performance can actually degrade. Hence making this configurable.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 276 (write behind needs to be optimized.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=276
commit 50a3ddc07b15516ce64e8f084efb3c912c81a2b6
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 22 01:38:37 2009 +0000
performance/write-behind: reduce traversal of request list during wb_mark_winds.
- move all the decision making code to __wb_can_wind.
- don't continue traversing the request list, once we know any of the
following conditions are true:
* requests other than write are present in queue.
* writes are happening at non-contiguous offsets.
* there are no write requests, which are wound to server but not yet
received the reply.
* enough data is aggregated for writing.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 276 (write behind needs to be optimized.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=276
commit 298ab821a367ab2f330cfb0f8461ab01b214aefd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 22 01:38:50 2009 +0000
performance/write-behind: reduce list-traversal during wb_mark_unwinds
- don't traverse entire request list to get the window-size, instead break when current
window size becomes greater than configured limit.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 276 (write behind needs to be optimized.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=276
commit 8dd26979a8e7ae3d4cc5fb513bdbcef238785491
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 22 01:38:25 2009 +0000
performance/write-behind: remove redundant traversal of write-requests in the wind list in wb_ sync.
- no need of getting the total_count of number of requests in the list.
Even if there is a single request, we need to sync it.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 276 (write behind needs to be optimized.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=276
commit c91cfabe48055d9757ee2b7db9607d86c6624535
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 22 01:38:12 2009 +0000
performance/write-behind: Aggregate adjacent contiguous write-buffers into single iobuf.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 276 (write behind needs to be optimized.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=276
commit 17c9f610cd188e7cd3951f8a5ee52e8fdf7cdaad
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 22 01:37:59 2009 +0000
performance/write-behind: fine-tune logic of wb_mark_winds
- remove wb_mark_wind_aggregegate_size_aware, since wb_mark_wind_all does
the same work (with check for whether current aggregated data size is
greater than the configured limit before calling it). Moreover,
wb_mark_wind_aggregate_size_aware called __wb_get_aggregate_size
redundantly, thereby reducing the performance, since for small
sized large number of writes, traversing the list of requests takes
significant amount of time.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 276 (write behind needs to be optimized.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=276
commit 251204d59a0e48bf184535c2d025d700163bd561
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Sep 21 05:32:42 2009 +0000
libglusterfsclient: Fix build warnings
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 275 (libglusterfsclient: Generic build failure bug for libglusterfsclient and booster)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=275
commit 1252c671dbcc4424bcb91b55be08af62aefad597
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Sep 21 05:32:32 2009 +0000
booster: Fix build warnings
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 275 (libglusterfsclient: Generic build failure bug for libglusterfsclient and booster)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=275
commit 651212557fb3dbbe32a11fa64bb2b4ac8196e8c4
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Sep 21 05:19:47 2009 +0000
storage/posix: Update nr_files after system call succeeds.
In posix_open(), posix_create(), and posix_close(), update
stats->nr_files only after the FOP has succeeded.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 248 (Updating stats in posix is incorrect)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=248
commit 0492678d2d974758fbe8850faf2a96759ed45daf
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 18 05:53:52 2009 +0000
performance/quick-read: refine logic of qr_readv.
- An extra vector was being allocated when the number of bytes being read
from cache were equal to the iobuf size.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 274 (Memory corruption in Apache running on booster)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=274
commit d4596fd9969bdad8cc51747cab1dc106456cdfff
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 18 05:48:04 2009 +0000
performance/quick-read: optimizations to lookup
- qr_lookup not to send request for file-content if the cache is already
present during revalidates.
- flush the cache in qr_lookup_cbk if the cache is not in sync with the file.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 273 (Code review and optimize quick-read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=273
commit 3126a57f3776b5fe66845f93263e0fb5ec738933
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 18 05:48:13 2009 +0000
performance/quick-read: make a comment more explicit.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 273 (Code review and optimize quick-read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=273
commit f7fbc9a56a1cc18c0244bd82b79c318a1ac43ebb
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 18 05:47:56 2009 +0000
performance/quick-read: checking for qr_file in inode-context and creating if not present should be atomic.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 273 (Code review and optimize quick-read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=273
commit 1344b3717903d904019c8843f160a4cd5474e29e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 18 05:47:43 2009 +0000
performance/quick-read: refine the logic in qr_lookup.
- a new size has to be set in xattr_req only
if (quick-read is configured with a maximum file size limit
&& ((xattr_req does not have a request key for getting content)
|| (the size requested in xattr_req is not equal to configured
size in quick-read)))
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 273 (Code review and optimize quick-read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=273
commit 8cbf01f20f5fc66fbf8535e1e2be8988d5f84915
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Sep 17 15:08:21 2009 +0000
protocol/client: access glusterfs context from the ctx member of xlator object
- A global context pointer cannot be used with libglusterfsclient, since
there can be many contexts in a single process.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 271 (applications using booster protocol/client crash in client_setvolume_cbk.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=271
commit f58f10d6cec7df2897e200b9c82410b3b771de74
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Sep 17 00:08:26 2009 +0000
performance/write-behind: check for the presence of context only in fds not opened on directories.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 260 (ls on booster VMP results in error: "File descriptor in bad state")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=260
commit 54d63015ea9fb60faa9dd756085f531c577b0664
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 16 12:33:21 2009 +0000
client-protocol: fix race-condition encountered while accessing fdctx
- In protocol/client, fdctx is accessed by two sets of procedures,
protocol_client_mark_fd_bad falls in one set whereas the other set consists of
all fops which receive fd as an argument. The way these fdctxs are got is
different in these two sets. While in the former set, fdctx is accessed
through conf->saved_fds, which is a list of fdctxs of fds representing
opened/created files. In the latter set, fdctxs are got directly from fd
through fd_ctx_get(). Now there can be race conditions between two threads
executing one procedure from these two sets. As an example let us consider
following scenario:
A flush operation is timed out and polling thread executing
protocol_client_mark_fd_bad, fuse thread executing client_release. This can
happen because, immediately a reply for flush is written to fuse, a release on
the same fd can be sent to glusterfs and the polling thread still might be
doing cleanup. Consider following set of events:
1. fuse thread does fd_ctx_get (fd).
2. polling thread gets the same fdctx but through conf->saved_fds.
3. Now both threads go ahead and does list_del (fdctx) and eventually free
fdctx.
In other situations the same set events might occur and the threads
executing fops other than flush in the second set might be accessing a
fdctx freed in protocol_client_mark_fd_bad.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 127 (race-condition in accessing fdctx in protocol/client)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=127
commit 71340b3dc2db35932d468891414635721e80545b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Fri Sep 11 07:42:44 2009 +0000
performance/quick-read: access glusterfs_ctx from xlator instead of using glusterfs_get_ctx
- since glusterfs_get_ctx gets the global context pointer, there can be
problems in a multithreaded application running on libglusterfsclient
doing multiple glusterfs_inits. Hence use context specific to the
current xlator tree stored in each xlator object.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 240 (segmentation fault in qr_readv)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=240
commit 4c3ffe37bb53f14a3e5a0166e6610df9b10493d9
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed Sep 16 08:53:33 2009 +0000
Add iot_fxattrop to io-threads
It was already implemented but not set to .fxattrop
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 267 (Add fxattrop to iothreads)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=267
commit e7cffd7b3bc55a86ff7d13d87525549078c721ba
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Sep 15 04:47:50 2009 +0000
Dumop inodectx added
Added dumpop inodectx.
Support for dumop inodectx added in dht, locks and client-protocol.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit 6b78207af42eb26aee990eaacd77fe9f5d05df65
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Sep 15 04:46:44 2009 +0000
Changed prototype for inode_table_dump() and inode_dump().
Changed prototype for inode_table_dump() and inode_dump()
Added support for dumpop inode in mount/fuse and protocol/server
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit e9e8a9a8c719773bae5c6364ec998b2466facf47
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Sep 15 04:45:08 2009 +0000
protocol/client: Support for dumpop priv.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit 17537df8a9d7c2941e063b6bf0ddb797a298e009
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Sep 15 04:44:41 2009 +0000
mount/fuse: Support for dumpop priv.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit b4dfcaa3a3fa26d0136ff03cd754abab437d1d02
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Sep 15 04:43:48 2009 +0000
cluster/dht: Support for dumpop priv.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit b5a6000c051f90ac49fe0e407bad45c8f9ce7cf7
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Sep 15 04:43:29 2009 +0000
libglusterfs:Acquire lock before accessing fdtable contents during statedump.
Hold lock while dumping fdtable.
Dump only inode ino instead of the complete inode.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit 0019f3cf0348f01893ff036052002bb9c4567d5c
Author: Vijay Bellur <vijay@gluster.com>
Date: Tue Sep 15 04:42:09 2009 +0000
glusterfsd: Removing conditional compilation for SIGUSR1 handler.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit bed25db57be4c263ff00b2070ea05e6a27d02673
Author: Anand Avati <avati@gluster.com>
Date: Wed Sep 16 05:43:01 2009 +0000
io-cache: fix table->max_pri to 1 as the lowest priority
patch http://patches.gluster.com/patch/1319/ breaks when no priority
is mentioned in the config. the patch makes ioc_get_priority() return
1 as the value when no priority is given, but ioc_get_priority_list()
was still returning 0 as the max_pri (maximum priority) which would
result in lru list heads not getting initialized
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 261 (support for disabling caching of certain files)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=261
commit e31b73f826ef711616e358a7d9ab06bd399c3172
Author: Vinayak Hegde <vinayak@gluster.com>
Date: Wed Sep 16 02:37:19 2009 +0000
cluster/stripe, when dbench is run, client crashes because in stripe.c priv is dreferenced without initialising.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 266 (In stripe client crashes after some time when disk space is full)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=266
commit 071950443a7c4798edda4508aac4c7f8288f6546
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 15 08:06:56 2009 +0000
booster: use __REDIRECT macro to prevent creat being renamed to creat64.
- nm on libglusterfs-booster.so shows only creat64 defined but not creat. This
behavior is observed due to following reasons.
1. Booster is compiled with _FILE_OFFSET_BITS=64.
2. fcntl.h when included with _FILE_OFFSET_BITS=64 defined, renames all
occurences of creat to creat64 in the source code from the point of
#include <fcntl.h>.
fcntl.h should be included since booster.c uses many of the macros defined in
that header and glusterfs (booster in turn) has to be compiled with
_FILE_OFFSET_BITS=64 since glusterfs uses datatypes (off_t, stat etc) whose
sizes vary depending on whether this macro is defined or not. Basically, this
macro should be defined to provide portability across 32 and 64 bit
architectures.
The correct fix is to make glusterfs to use datatypes big enough to hold 64 bit
variants as well as 32 bit variants (like int64_t replacing off_t) and not to
define _FILE_OFFSET_BITS=64 at all.
As a temporary work around,
1. we can implement creat functionality in a function with different name, say
booster_false_creat
2. rename this function to creat using __REDIRECT macro. since this renaming
happens after renaming of creat to creat64 (from the first __REDIRECT macro
in fcntl.h), we will end up with creat symbol being defined in
libglusterfs-booster.so
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 264 (creat is not resolved properly to the symbol defined in booster)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=264
commit a763f8d628c118d41676c31742136431a7d25530
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 15 08:07:30 2009 +0000
libglusterfsclient: NULL terminate the vmp entry during vmp_entry_init.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 263 (files are not resolved to glusterfs when vmp is not terminated with a '/'.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=263
commit a0317cd5b6f9c488a20de6dbf7bc12fae74d1d2e
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 15 08:07:15 2009 +0000
booster: use appropriate conversion specifier during logging in close.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 262 (crash in booster close due to invalid conversion specifier during logging.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=262
commit afb354f5c49745eb178aab2200256a147098fd52
Author: Stephan von Krawczynski <skraw@ithnet.com>
Date: Mon Sep 14 05:59:55 2009 +0000
2.0.6 patch for io-cache pattern-matched non-caching
Hello all,
here is a small feature patch. Its intention is to give the user more control
over the files performance/io-cache really caches. If the user knows exactly
which files should be cached and which shouldn't there is currently no way to
tell glusterfs _not_ to cache certain pattern. This patch allows you to
disable caching by setting the priority of a pattern to "0". If you do not
give any priority option it works just like before and caches everything.
Honestly I am not totally sure that disabling caching works the way we did it,
please comment.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 261 (support for disabling caching of certain files)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=261
commit 68a39928905fcc55c69eb0f7be5013cb44078597
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 15 01:15:14 2009 +0000
storage/posix: transform inode number in stat structure
- when export directory is configured to span across multiple mountpoints,
the inode number has to be transformed in order to make it unique.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 254 (storage/posix has to do inode number transformation wherever it unwinds with a stat structure)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=254
commit 9d2025f5ca33906b4b476cd7ddd2defda1f24254
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Sep 15 01:03:56 2009 +0000
extras: Add LD_PRELOAD test tool
This tool allows us to check the sanity of the LD_PRELOAD
mechanism so that we can be sure that an application's syscalls
will be redirected into booster when that library is LD_PRELOADed.
In case of failed syscalls, this tool should be run first
to see if the calls are redirected as required.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 251 (Improve booster debugging through ld-preload testing tool)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=251
commit 7ef2e383549f36fb272059fd72669ff8e3fab3d8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 15 00:33:30 2009 +0000
transport/ib-verbs: initialize fini member of new-transports created during accepting client connections.
- This bug used to cause a memory leak of 2 * sizeof(ib_verbs_private_t) for each new client connection.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 259 (Memory leak on server side when there are large number of disconnections from clients)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=259
commit 70dcb12da82db7d24436ee9c309ab472fb9be3d4
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Sep 10 07:18:10 2009 +0000
libglusterfsclient: Wait for time ample enough for all the children of distribute to initialize before sending lookup on '/'.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 255 (libglusterfsclient should wait till all the children of distribute are initialized before sending first lookup on '/')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=255
commit 1fdd64aefe90116d2a1607699fab1c3487633de1
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 9 12:15:11 2009 +0000
protocol/server: server_stub_resume should check for failure of lookup when oldloc.parent is NULL.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 215 (crash on ib-verbs in 2.0.6-rc4)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=215
commit 9af8804fc26f61553c781e2fada18f4e8b837fc0
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 9 00:39:13 2009 +0000
booster: Fix fd_t leak in pread64
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 174 (booster: fd_ts, they are a leakin)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=174
commit ce965fd81935bf6634716ccc05f64dae096bb8b6
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 9 00:39:12 2009 +0000
libglusterfsclient: Fix incorrect NULL check for fd
We should check fdctx instead.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 253 (Global bug for libglusterfsclient NULL checks and CALLOC handling fixes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=253
commit 432ffed443d0ec2a4fa27224c9fccd0896e9a87f
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 9 00:39:11 2009 +0000
libglusterfsclient: Handle CALLOC failure in libgf_client_lookup
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 253 (Global bug for libglusterfsclient NULL checks and CALLOC handling fixes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=253
commit 553026b7edbd3d44c0ae6c79f84b9341b8d3b18d
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 9 00:39:10 2009 +0000
libglusterfsclient: Handle CALLOC failure in libgf_init_vmpentry
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 253 (Global bug for libglusterfsclient NULL checks and CALLOC handling fixes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=253
commit d568768370a45252716dc8d28df252df4bc573f1
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Sep 9 00:39:09 2009 +0000
libglusterfsclient: Add inode_ctx NULL check during iattr cache validation
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 253 (Global bug for libglusterfsclient NULL checks and CALLOC handling fixes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=253
commit 7089d4cbaf040ef2ae1acc25e57c1e524ca1307e
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Sep 8 23:39:35 2009 +0000
libglusterfsclient: Enhance logging
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 210 (libglusterfsclient: Enhance logging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=210
commit 095dcb1e4739d7a690d266002f4fe068eaa602b7
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Sep 8 23:39:13 2009 +0000
booster: Enhance booster logging
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 210 (libglusterfsclient: Enhance logging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=210
commit da3ca365669ec4c1cae987a44cf101ed0329e8ff
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Sep 8 06:08:00 2009 +0000
mount/fuse: Set d_type in readdir_cbk using the stat buf for the entry.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 207 ([ glusterfs 2.0.6rc4 ] - "ls --color" takes time)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=207
commit 2bc04d4482a8b7220d6469fb31ef9f1840e4c967
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Sep 8 05:06:22 2009 +0000
cluster/afr: Check op_ret in afr_getxattr_cbk before accessing dict
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 250 (Crash in replicate getxattr)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=250
commit b05cdee6b8d27d699ab6bcb3133463bb94698137
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Sep 3 09:44:34 2009 +0000
cluster/afr: Do not try to self-heal "/"
If the root directory does not exist on a subvolume,
don't try to create it.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 28 (Deleting a backend export directory in an AFR setup can cause a segfault while trying to self heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=28
commit d3f36b1017fb9ffe6ce1e18cb1341421d76c1e53
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Sep 3 04:48:14 2009 +0000
performance/write-behind: hold locks when accessing members of wb_file.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 243 (Hold locks when accessing members of wb_file_t.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=243
commit 0b16d5a3ddb5fb4ca83225350d144cabe9c6acc9
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 2 04:54:23 2009 +0000
performance/write-behind: communicate back the errors in writes to servers, in the next immediate writes from application.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 242 (If any of the writes fail, write-behind should not wait till the fd is closed for reporting errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=242
commit 25139379cd0ac79e9cf0cb7a7871fd9c3822e92a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Sep 2 01:12:39 2009 +0000
libglusterfsclient: handle intermediate path components which are symlinks properly in glusterfs_glh_realpath.
- while building the realpath, if the intermediate path happens to be a
symbolic link, the content of link was being appended at dirname (path),
instead of appending to intermediate path.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 237 (If any of the path component other than the last one, happens to be a symbolic link glusterfs_glh_realpath does not construct correct path.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=237
commit c3edba4deea70efeb891e183b684456fdfc00d75
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 1 00:34:02 2009 +0000
libglusterfsclient: handle paths terminating with '/' properly in libgf_trim_to_prev_dir.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 236 (Stack overflow due to infinite recursion in glusterfs_glh_realpath)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=236
commit 10197f2991b9f8e495a39d0ea2b83145dc2e67b0
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Sep 3 13:42:04 2009 +0000
libglusterfsclient: handle failures in glusterfs_glh_realpath.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 235 (Handle failures in glusterfs_glh_realpath appropriately)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=235
commit 35b61c5c5f8284c0e730f166c14849607cffa62f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 1 00:19:57 2009 +0000
libglusterfsclient: check for memory allocation failure in glusterfs_glh_realpath.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 235 (Handle failures in glusterfs_glh_realpath appropriately)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=235
commit cf34f8d2454cd4417c92bfb0467188108cbd2296
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 1 03:52:20 2009 +0000
libglusterfsclient: handle symlinks properly in glusterfs_glh_opendir.
- exclude symbolic links from set of filetypes to which ENOTDIR is returned,
since a symbolic link can point to a directory.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 234 (Apache-2.2 on booster returns HTTP_FORBIDDEN for a directory which is present)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=234
commit 6fe75029d269008e1a91f5dc3303a04d39304fc2
Author: Raghavendra G <raghavendra@gluster.com>
Date: Tue Sep 1 00:00:44 2009 +0000
libglusterfsclient: fix to the way symbolic links are handled in glusterfs_glh_realpath.
- don't assume the content returned by readlink while constructing realpath
of a symbolic link to contain vmp as part of the path. This is necessary in
case of symbolic links which contain relative paths as targets.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 233 (Crash in Apache running on booster when a client tries to access a symbolic link)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=233
commit 1f40121f2ffb82601e0e5d10b1f7ec222af60dac
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Aug 31 22:53:33 2009 +0000
performance/quick-read: if open fails during cache validation, don't continue validation process.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 232 (Quick-read: if open fails during cache validation, don't continue validation process.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=232
commit 3bf73158d8d0df87133e6b41f31cfd63a9e730ea
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Aug 31 22:52:34 2009 +0000
performance/quick-read: Fix access of freed memory in qr_open_cbk.
- It may so happen that current frame might be unwound and
local might be freed when waiting operations are resumed.
Hence store the information of whether this frame belongs
to an open call in a local variable, instead accessing the
flag from local at the end of qr_open_cbk.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 231 (Quick-read: Fix access of freed memory in qr_open_cbk.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=231
commit a3f9dcedcd0515086021694d9e41237b190449d7
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Sep 4 01:43:43 2009 +0000
storage/posix: Synchronize access to this->private.
Hold lock on priv while updating variables inside it.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 175 (Statistics for number of open files in Posix incorrect)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=175
commit 2796aa6ae1bbe96eab6bd7f8362f2479592b6248
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Sep 7 03:13:50 2009 +0000
storage/posix: Handle setgid bit on directories correctly
If a directory has the setgid bit set, then any entry
created under it must have group ownership same as
the directory.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 241 (Gluster not honouring SETGID flag)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=241
commit c264706fb0368baf55a9d73863a67e47ee2934d5
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:37:37 2009 +0000
performance/stat-prefetch: don't check for a non-null parent and inode in newloc during rename.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 29e1b2adcda80c38c5c490a3f74d8277dd621b73
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:37:26 2009 +0000
performance/stat-prefetch: minor bug-fixes.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 90cb422c21befb8f6aed2d9e01f32ab1e02ca812
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:37:16 2009 +0000
performance/stat-prefetch: update design document.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 16fb318120febfb44d774c4c7cece0660a16665c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:37:10 2009 +0000
storage/posix: handle dentries from different mount points in readdir
- If posix translator is configured to have export directories to span accross
different mount points, inode number is transformed in the dentry returned.
Otherwise, the entry is not added to list of entries returned in readdir
callback.
- storage/posix returns ENOENT if the file is on different mount point other
than that of exported directory and is not configured for export directory
spanning across multiple mountpoints during lookup. But, since stat-prefetch
shortcuts lookup calls, its necessary that readdir return only valid
dentries.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit d3814c2d1be658a932635c5e94a04e5b9ce87e01
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:37:02 2009 +0000
performance/stat-prefetch: implement release callbacks.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit f31995ee511380cb56d44a826e35f57b57f2c849
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:36:57 2009 +0000
performance/stat-prefetch: implement sp_fxattrop.
.../performance/stat-prefetch/src/stat-prefetch.c | 37 ++++++++++++++++++++
1 files changed, 37 insertions(+), 0 deletions(-)
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit d2587d0d542d0291acf12ed2f38391dc73c09e90
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:36:47 2009 +0000
performance/stat-prefetch: implement sp_xattrop.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 672ad35c43849db2baee270553fc1490d27c685f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:36:37 2009 +0000
performance/stat-prefetch: implement sp_checksum.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 5bf702b1d858048b1cf56aab2e3ff00ad5dc47ed
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:36:28 2009 +0000
performance/stat-prefetch: implement sp_getdents.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 71bcc0a9853b01db5dcc4cc049595479bc1c402b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:36:17 2009 +0000
performance/stat-prefetch: flush stat corresponding to directory being read in readdir
- delete the entry corresponding to basename of path on which fd is opened
from cache stored in parent. This is necessary because readdir changes
st_atime.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 46cf67b7fe1923baed51bf2be63ff27a3a86048a
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:36:08 2009 +0000
performance/stat-prefetch: implement sp_setdents.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 39b1a8e04a33b6d6fb265726057393a3d7190823
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:36:02 2009 +0000
performance/stat-prefetch: implement sp_removexattr.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 27cab8ba3bee1d58435b24f027684dc60e032185
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:35:52 2009 +0000
performance/stat-prefetch: implement sp_setxattr.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 7cb19cd44a27fe767f087990497c6696e603b3d8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:35:36 2009 +0000
performance/stat-prefetch: implement sp_rename.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 15b5d2798cbc18b84d328a932effdda648baba55
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:35:02 2009 +0000
performance/stat-prefetch: implement sp_fsync.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 2cff89a300b94cb6cfec6454bb0e8be156a0c632
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:32:06 2009 +0000
performance/stat-prefetch: implement sp_writev.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 3e11ff2b694cf001c44ce28089c3018e923044df
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:32:00 2009 +0000
performance/stat-prefetch: implement sp_readv.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit ecb2f16a04c5382800b4ca9901abae40b6caa4a3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:31:53 2009 +0000
performance/stat-prefetch: implement sp_rmdir.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 95fc94758b6cfbae2a185f968bb4cab42685646f
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:31:45 2009 +0000
performance/stat-prefetch: implement sp_unlink.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 24355ea8580e7b93b41bb60cd5da3bccc7f25991
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:31:37 2009 +0000
performance/stat-prefetch: implement sp_readlink.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 8b979f898f1d562e695d26b8f11e57958a6f1ce3
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:31:28 2009 +0000
performance/stat-prefetch: implement sp_utimens.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 8031a6dfcf84e38816c082ca6a07b41198b973d4
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:31:19 2009 +0000
performance/stat-prefetch: implement sp_ftruncate.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 96c367a48bd59d85a9ba81c28267ea30877e2cdd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:31:12 2009 +0000
performance/stat-prefetch: implement sp_truncate.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 5c4c5b5808d6d30b2d0a10a9e711acaec1a18d57
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:31:04 2009 +0000
performance/stat-prefetch: implement sp_fchown.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit a3862331ac5c4c8f9df68a1907aa2f5ae7681877
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:30:58 2009 +0000
performance/stat-prefetch: implement sp_chown.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 75c24708c099fe1b87c372b14601f892c1319f01
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:30:47 2009 +0000
performance/stat-prefetch: implement sp_fchmod.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit da44d88db69a868833f66d04781cec5fb96976ce
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:30:39 2009 +0000
performance/stat-prefetch: implement sp_link.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 3067d3d96747422994586067fca45e081bd60e50
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:30:32 2009 +0000
performance/stat-prefetch: implement sp_symlink.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit edff8014a49f4cd87dd841ee642531a56f3dd287
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:30:25 2009 +0000
performance/stat-prefetch: implement sp_mknod.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 105d4d186896d50c011af57716e30ea2999265bd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:30:15 2009 +0000
performance/stat-prefetch: implement sp_mkdir.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit fd341a570188ea761dfacb9e400525450247c8f7
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:30:06 2009 +0000
performance/stat-prefetch: implement sp_opendir.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit aee52c25fffd3e35441df71e89c1f0de98a3b815
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:29:54 2009 +0000
performance/stat-prefetch: implement sp_create.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 0c84dd9e610b70741c09a762a8ac537aca08a956
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:29:41 2009 +0000
performance/stat-prefetch: implement sp_open.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 55a27f236e8f1eff945dea79c0a753969bb09162
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:29:29 2009 +0000
common-utils: introduce new macro GF_VALIDATE_OR_GOTO_WITH_ERROR
- the existing macro GF_VALIDATE_OR_GOTO sets errno to EINVAL
which may not be appropriate in all cases.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 41fcccf9cbe5b3c8954a34473ed0004c6ce2b49c
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:29:19 2009 +0000
stat/prefetch: free cache if it cannot be put into context of fd
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 1f834cce81ab2363066744336832fe8d413a21fb
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Aug 26 01:36:53 2009 +0000
performance/stat-prefetch: introduce sp_fd_ctx_t to hold context of fds
- we need following extra members along with cache
1. basename of path on which fd is opened. This is necessary to search
for cached entry in fd based fops.
2. inode corresponding to dirname of path on which fd is opened. This
is necessary to get cache where entry corresponding to file on which
fd is opened.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 4bcb2f66d4fb493e5ba6fa64522759d51cefdbcd
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:28:55 2009 +0000
performance/stat-prefetch: implement sp_chmod.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit 94f2a9a6b724a99d7b9d78553e42e3c33cb2e49b
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:28:42 2009 +0000
performance/stat-prefetch: implement sp_readdir.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit c28906c91fe4aba86aaf80c7425a9354a5130550
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Aug 26 01:36:11 2009 +0000
performance/stat-prefetch: implement sp_lookup.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit bc1eeddd1dbd603d4e8a8ce0d134813db2c841e8
Author: Raghavendra G <raghavendra@gluster.com>
Date: Sun Aug 23 22:28:18 2009 +0000
rewriting stat-prefetch translator
- stat-prefetch aims to optimize operations like 'ls -l' where a readdir
is immediately followed by stat calls on each of the directory entry read.
More details on design can be found in doc/stat-prefetch-design.txt
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 221 (stat prefetch implementation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=221
commit c3c9c831ac9082b147b968ea8a216a70bbeb0c1c
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Sep 2 05:13:21 2009 +0000
mount/fuse: Include missing header files in Makefile.am
Compilation fails in a new glusterfs tarball due to missing fuse headers.
Including them in Makefile.am.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 244 (compilation after make dist fails because of missing headers)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=244
commit 7981a95301eea0f535b891e736bb170f4e18fc75
Author: Raghavendra G <raghavendra@gluster.com>
Date: Mon Aug 31 22:35:28 2009 +0000
ib-verbs: handle failure of ibv_create_qp gracefully.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 217 (crash in ib_verbs_create_qp)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=217
commit 40a387017dc44b431d5ea9d2a7471ca3cc8ef619
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Aug 28 00:17:01 2009 +0000
libglusterfsclient: Compare compcount with path not maxentry
When searching for an exact entry we need to compare the
component counts in the candidate VMP and the count in the
path being searched. This is opposite to the current
situation where we compare the component count in VMP
and the component count in maxentry, which will always
be same.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 209 (VMP parsing through fstab has issues)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=209
commit c9100394ffbe30747a562918d319a44252eefa0a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Aug 28 00:16:50 2009 +0000
libglusterfsclient: Enhance VMP searching logic
Another attempt to enhance searching for VMP entries.
There was a problem of returning the longest prefix match
from all the VMPs without checking whether the number of
matched components were same as the number of components
in the candidate VMP.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 209 (VMP parsing through fstab has issues)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=209
commit cc8e4cf29ae0f0fc2e9d47194189582517b251bb
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Aug 28 00:16:42 2009 +0000
booster: Support backward compatible options
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 209 (VMP parsing through fstab has issues)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=209
commit 96879cfa6a039457f4fb2e3315b2e7f67d93aa7c
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Aug 27 01:53:32 2009 +0000
core: Fix build failure on non-Linux systems
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 230 (Bulid fails on Solaris and Mac OS due to Linux specific flags)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=230
commit 3defddc8c8a7bca66ff0d7e24a4e3203d504eb11
Author: Raghavendra G <raghavendra@gluster.com>
Date: Wed Aug 26 05:08:18 2009 +0000
libglusterfsclient: don't use pointer returned by basename while freeing allocated memory.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 228 (Segmentation fault in glusterfs_getxattr)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=228
commit bf54843a4eb88a757367ca661ffc8b8554a1d4a5
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Aug 25 05:09:28 2009 +0000
fuse: protocol fix: fix bogus parsing of MKDIR message
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 226 (mkdir after rm of regular file of same name fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=226
commit 3a0f658b32e2d519e177d140dbfda45ab380c6c8
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 20 13:49:03 2009 +0000
changed booster fstab to parse the arguments same as mount.glusterfs
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 209 (VMP parsing through fstab has issues)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=209
commit 3c2a58f05602dca3c61e8c5ae1cec2dcde87b861
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Aug 20 18:51:10 2009 +0000
protocol/client: 'connecting' event is properly notified.
when there are no servers available to client, and transport init is
not successful, send 'connecting' event once to parent so it doesn't
hand in there.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 224 (Client hangs if none of the servers are up)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=224
commit 13294a4255d8ac907866ff147f739b49b1e1b6dc
Author: Krishna Srinivas <krishna@gluster.com>
Date: Sun Aug 16 14:34:08 2009 +0000
in server_rename if we do_path_lookup on the newloc and parent directory is not found, the server crashes.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit dfa70bf8faa76244c58df07f1fd910ba45d8e695
Author: Vijay Bellur <vijay@gluster.com>
Date: Sat Aug 15 12:58:08 2009 +0000
TAKE2[PATCH BUG:213 1/1] Support for Process State Dump
Support for process state dump.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 213 (Support for process state dump)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=213
commit 5fc12fd50ec201910ba89be830bb6033d7848f38
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 4 19:43:31 2009 +0000
added log message when server fails to send the reply frame
As of now, if a frame submit fails on server, there are no logs,
and clients will have missing frames (which leads to 'hangs').
Supporting situation like this very tricky without proper log
messages. As a step to make our log message lean and meaningful,
this log is important.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 190 (missing frames due to larger reply message size.. (ib-verbs))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=190
commit 4cb19cac218f3389c512fbc2dc8ee8f04488df79
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Aug 13 02:57:18 2009 +0000
libglusterfsclient: Sync access to VMP list on new entry addition
Some weeks back, I'd separated the big lock into vmplock and mountlock.
See commit 304e4274ca9b0339539581c5413e3339078c1182 in mainline.
At that time, we did not have a solution to the problem
of when to init the vmplist in a thread-safe manner, since
there was no lock to protect the vmplock specifically, and that
when libgf_vmp_map_ghandle was called inside glusterfs_mount
so the "lock" was already being held.
Now that we have separate mount and vmp locks, the
accesses can be synced correctly.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 211 (libglusterfsclient: Race condition against vmplist in libgf_vmp_map_ghandle)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=211
commit 83115d41a0defdc6ccba401bfa4a1956388fd2ef
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Aug 13 02:57:17 2009 +0000
libglusterfsclient: Enhance VMP search logging
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 210 (libglusterfsclient: Enhance logging)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=210
commit 2588e10954c499f1f323e0840a63685468c5f122
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Aug 13 02:57:16 2009 +0000
libglusterfsclient: Use components for VMP searches
Till now, we've been doing a character by character comparison
between a given path and the VMP, to search for the glusterfs
handle for the given path.
This does not work for all cases and has been a known bug.
This commit changes the byte-by-byte comparison into a more
accurate component based comparison to fix search
failures.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 209 (VMP parsing through fstab has issues)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=209
commit 4408ead8af4613c3278b0f76bc5b58d6f5384ef3
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Aug 11 04:59:29 2009 +0000
features/locks: Fix reverse logic in posix_lock_to_flock
if the lock's end point is LLONG_MAX, the corresponding
struct flock's len must be 0.
Previous code had LLONG_MAX and 0 reversed.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit db079844ff3553d9ec4e7f2af8a652bc5c30ac8f
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Aug 11 01:43:33 2009 +0000
mount/fuse: Don't log setlk returning EAGAIN as a GF_LOG_ERROR.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 3a6a95883511196197b175c30557c178e852aece
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Aug 11 01:42:14 2009 +0000
features/locks: Set the right log level in a few places.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 766b4bc147cd4c52946e6568e485195509ab407b
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Mon Aug 10 02:17:43 2009 +0000
glusterfs log prints "TLA Revision" tag, remove it and reflect git instead
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit ba5f2c7a01550d53da59b1661d5e4c5c58d29f3a
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Aug 16 15:51:23 2009 -0700
fuse: a compat fix for older protocol revisions
commit 5f70648fa40f4db37f51eb8f8212c92f0b328acd
Author: Csaba Henk <csaba@gluster.com>
Date: Sun Aug 16 07:02:27 2009 -0700
fuse: optimize request iov aligment for writes
Idea by Avati.
commit 5aed22a6599fb8dc76ddc389e0714868b08788f5
Author: Csaba Henk <csaba@gluster.com>
Date: Fri Aug 14 15:51:37 2009 -0700
fuse: switch off direct I/O mode if big writes are supported
commit 9eff7a52b1c9237c0b75863d9139ec4501062ddb
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Aug 12 04:17:59 2009 -0700
update user guide wrt. FUSE requirements
commit 6989bb8a7f37c3fb43a301349f38e087abcdda72
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Aug 11 18:26:11 2009 -0700
bring in fusermount
commit 3341fe02245695559f4ca168a5cdd3ce0029d495
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Aug 11 06:24:40 2009 -0700
fuse: add proper mounting support, based on libfuse routines
commit d0816886dfea76c0798da016c636489400837359
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Aug 10 19:46:45 2009 -0700
fuse: move libfuse derived code over under contrib/
commit 4c8809f203fecf68ebc8ef288ed9347f941b4c4c
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jul 14 17:10:38 2009 -0700
upgrade FUSE protocol to 7.12 and add support for older versions of the protocol
commit ef82efe7a3e80a1452f7f76470399880da97bf0c
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Jul 13 22:28:07 2009 +0200
basic version of direct FUSE interface (ie. not relying on libfuse)
commit 97427166ea77a2ea791dc25f772b8c3fa8f496f9
Author: Anand Avati <avati@dev.gluster.com>
Date: Thu Aug 6 21:51:33 2009 +0000
protocol/client: fixed registration of saved_fds
In client_open_cbk, client_opendir_cbk the list_add_tail macros were invoked with wrong
ordered arguments, causing the existing registered fd list to get unlinked from the
saved_fds list. The effects of this is far fetched - when transport disconnects, open
fds are no more marked bad as they are not reachable from the saved_fds list. After
reconnection, resumed access on this fd causes reference to invalid fds on the server.
It could appear in the form of 'unresolved fd' error, readdir happening on a file fd,
files reading from other files, etc.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 192 (sefault in posix-readdir)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=192
BUG: 126 (Immediate segfault when used for rootfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=126
BUG: 173 ([ glusterfs 2.0.6rc1 ] - "server SEG fault")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=173
BUG: 194 (Apache+Booster results in inconsistent download size using wget)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=194
commit 9e3140788ce29cca37210ab4bae6e9ac62908dd8
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Thu Aug 6 00:55:53 2009 -0700
Removed BRANCH: tag
commit 92d0c3d6b8a7110dd0e1461956d15098c7104be2
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 4 18:56:52 2009 +0000
server-lookup: added path info from header to log message
in the previous commit, the path info was removed to prevent the
segfault, which instead could have been provided from request
header directly. More specific information is required for debugging,
and hence adding the path log.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 189 (segfault in server-lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=189
commit f1ac600397b11613300d437d3785ea58eac0920d
Author: Anand Avati <avati@dev.gluster.com>
Date: Tue Aug 4 18:15:23 2009 +0000
dht_stat_merge - use the highest uid when ambiguous
When directories on different subvolumes have different ownerships, use the highest uid/gid till self-heal resolves the inconsistency
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 191 (random Permission denied errors)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=191
commit 318c6305378e641a38e8f49a681d3e7d5792d299
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 4 18:15:45 2009 +0000
add check for making sure 'fd' belongs to directory in posix-readdir
The root cause of this error is not found yet. But this check will
make sure that there is no crash when the situation happens.
Segfault can happen when a readdir() call comes over file's fd.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 192 (sefault in posix-readdir)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=192
commit 9d40144e04e84a2327d5f4b371162cdea0462c48
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 4 17:51:58 2009 +0000
logging related bug fix in server_lookup()
When 'dict_unserialize' failed, the log message was trying to
print 'state->loc.path' and 'state->ino', which gets filled in
later stages in flow. Caused segmentation fault when there was
a failure.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 189 (segfault in server-lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=189
commit b47b22b30ad06ce9f980472a081b30a90ab2a9a6
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 4 17:51:44 2009 +0000
increased ib-verbs buffer size
Noticed that in few cases, where ib-verbs doesn't handle a bigger
sized buffer to be sent across, which happens without problem in
tcp. Caused frame losses in the case where server's reply msg was
bigger, hence the msg got dropped at the server end. With this patch
ib-verbs buffer size is fixed to 512KB. (4 x page-size)
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 190 (missing frames due to larger reply message size.. (ib-verbs))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=190
commit 4d52c8f7a7ddae15fdca31a8168dc83e0b31da04
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Aug 4 17:51:31 2009 +0000
adding an option to mount.glusterfs for server failover to fetch volume files.
With this option, 'single point of failure', in case of volfile server can be
avoided
Thanks to Cory Meyer <cory.meyer@gmail.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 185 (Request to support secondary volfile-server option in mount.glusterfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=185
commit 335610a2ac9db4dfb6d23995c1e11f24c96617f0
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Aug 4 04:39:34 2009 +0000
cluster/afr: inode-read: Check stat buf for NULL before attempting to set inode number.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 184 ([ glusterfs 2.0.6rc2 ] - Client Segfault while running fs-perf-test)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=184
commit 2009910d19f471955bf0276dc662d91e704d7c42
Author: Raghavendra G <raghavendra@gluster.com>
Date: Thu Jul 30 23:08:42 2009 +0000
client-protocol: log messages at WARNING loglevel when client_bind on privileged port fails.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 140 (use appropriate loglevel to log in case of failure to bind to privileged socket)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=140
commit 1029d55489df1f869a2162768282ee007e69e08b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Jul 31 12:38:36 2009 +0000
libglusterfsclient: Bind fd on fd creation code paths
When an fd_t is fd_create'd, we need to call fd_bind on it to
ensure that any fd_lookup on the inode gets us this fd. We're not
doing this so translators like write-behind were not able to order
path-based requests at all resulting in some fops like stat, which
could be issued after a writev, overtaking a previous writev which
is still being written-behind.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 179 (fileop reports miscompares on read tests)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=179
commit 0c321ef840d14cefa524076937772742a97c561a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Jul 31 04:14:48 2009 +0000
libglusterfsclient: Invalidate iattr cache on reads
Earlier we have invalidated the iattr cache on writes. Now
we need to do so for reads also, so that we are not updating
the iattr cache with 0-filled stat received from io-cache.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 180 (fileop fails at chmod with stale file handle error over unfs3)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=180
commit 4f00df3e575cceadfc9b27482601e79f0b75defb
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jul 30 12:05:11 2009 +0000
replicate: Return ino from first subvolume on inode creation fops
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 177 (replicate: On file/dir creation, replicate returns inode from random subvolumes)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=177
commit df22b58c024c56776ae5c278f38a6d4a006995cf
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jul 30 12:04:05 2009 +0000
libglusterfsclient: Use iobufs for storing application write data
Till now we've been creating an iovec, storing references in it
to the application data and simply passing it on to the translator
tree. This means that the buffer being passed to the translators is
not at all associated with the memory ref'd by the iobref argument
to write fop. This is a problem when write-behind is a translator in
the tree since it assumes that the memory in the iovecs passed to
write fops is already refcounted by the iobref and so it simply copies
the address of the application data. The problem is that the application
can continue using this buffer, free it or over-write it destroying the
data that write-behind may write at a later time.
The solution involves copying the application's write buffer into
an iobuf which will be referred to by the iobref.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 178 (libglusterfsclient: Data corruption on using write-behind in translator tree)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=178
commit b07dc699010425832c4e140c0880c37a50866e00
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Jul 29 08:02:57 2009 +0000
booster: Fix fd leak due to incorrect NULL check
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 174 (booster: fd_ts, they are a leakin)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=174
commit 65a308b6c1f825f4e9462392298c1f3b847d61ab
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Tue Jul 28 00:52:56 2009 +0000
glusterfsd: handle logfile path specification appropriately.
when logfile path is not specified as absolute path, the symbolic
link created to the logfile (only in invocation of glusterfs with
--run-id) might end up as a broken symbolic link.
for example, command-line invocation like below will result in
broken symbolic link:
glusterfsd -f /home/glusterfs/volfiles/nufa/nufa.vol
-l ../home/glusterfs/logs/nufa.f1.log --run-id nufatest /mnt/nufa/
symbolic link will be created at $PWD/../home/glusterfs/logs/nufa.f1.log
will have a value of ../home/glusterfs/logs/nufa.f1.log.<date>.<time>.<pid>.
this symlink might be broken.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 156 (Broken symbolic link when relative path is given for a log file)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=156
commit 74c5685975316d87f31db40a30088bd6a93a22ba
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jul 27 16:48:37 2009 +0000
server-protocol: fix in server-loc-fill()
to continue with 'hashed' inode, even if inode_path() on the inode
fails. This will is needed for few lock operations, to unlock the
lock held on inode. (ie, it fixes 'rm -rf *' hang issue, seen from
multiple clients).
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 112 (parallel deletion of files mounted by different clients on the same back-end hangs and/or does not completely delete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=112
commit ee8ffe53832a9c16d91db068c8f7cf068c378f04
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Jul 28 04:51:35 2009 +0000
libglusterfsclient: Fix solaris build error
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 115 (./configure adds libglusterfsclient when it shouldn't)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=115
commit dfd0b0f78cab5767a7edb383c08e3bc0231952ae
Author: smyczek <smyczek@simplito.com>
Date: Mon Jul 20 18:44:00 2009 +0000
libglusterfs: fix SuperFastHash function used in dicitionaries in fact it always returned the value of second parameter (len) as a result.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 155 (The SuperFastHash function used in dictionaries is broken.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=155
commit 8026c5f06e74b9f8c5d9e38acc9199216283db68
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jul 23 11:25:01 2009 +0000
cluster/afr: Use user-supplied struct flock to STACK_WIND
afr_lk_cbk:
Use the original struct flock supplied by the
user to do further STACK_WIND's, and not the flock returned
by the previous STACK_WIND.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 159 (Client hangs when coherent byte range locks is attempted in replicate setup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=159
commit 4f059a8d826daf50363181ee68abf2a095d745ab
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Sat Jul 25 12:59:14 2009 +0000
libglusterfsclient: Workaround for local memory corruption
There seems to a reproduceable corruption specifically of
the libglusterfs_client_local_t that is allocated for
the read call. Therefore, the subsequent access to fd inside
local leads to a segfault. This is a temporary fix.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 164 (libglusterfsclient: Segfault due to memory corruption of frame local in libgf_client_read)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=164
commit 625fecbac09c3d6a856a19025187220788db2d95
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Jul 27 09:30:48 2009 +0000
cluster/afr: Return same inode number in stat buf for readv_cbk
Remember the inode number that had been returned in lookup_cbk
and set the stat buf->ino to the same.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 166 (libglusterfsclient: Cached stat buf inode is different from ino in inode_t)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=166
commit 59cf0031940a9b7fcb2c7ee2f469eb9aa9a90019
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Jul 27 04:29:26 2009 +0000
cluster/afr: Set inode number in unwind_buf in the inode-write calls.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 166 (libglusterfsclient: Cached stat buf inode is different from ino in inode_t)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=166
commit 290b499ae9c497100d6f2f072d2ebb57b145e31a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jul 23 16:19:26 2009 +0000
libglusterfsclient: Avoid overwrite of inode found through ino number
In libgf_client_loc_fill, there is a possibility that all
the ino, par and name are specified as non-NULL,non-zero args.
So if an inode is located in the itable using the ino and the
subsequent search for the inode using the par-ino and the file
name does not result in an inode being found, the current
code over-writes the inode that was found through the ino. The
correct behaviour is to stop further searches if inode
was already found using ino.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 161 (unfs3 crashes on link system call by fileop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=161
commit 961f8a273a74336dd0a438b6bf704b76670768e9
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jul 23 16:18:43 2009 +0000
libglusterfsclient: Fill new loc with target's ino on link
In the loc_t of the link being created, we must fill in the inode
of the old/target loc since this is a link operation. The
inode_link to the new parent is called in libgf_client_link.
This fixes a crash while running fileop over a fully-loaded
dist-repl vol file.
Ref: Bugzilla 161
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 161 (unfs3 crashes on link system call by fileop)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=161
commit 680a598e1d86cfa651566ceb8f9567c76870aada
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Thu Jul 23 15:38:32 2009 -0700
enable libglusterfsclient build by default
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 3381cd7cad52ff1bbd4e10094640664b948e4815
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Jul 20 01:25:12 2009 +0000
libglusterfsclient: Fake a fsid for every VMP
This is needed to work around the replicate behaviour of
possibly returning device number for the same file from
different subvolumes.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 148 (replicate: Returns st_dev from different subvols resulting in ESTALE thru unfs3booster)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=148
commit 0ae0ce820d65feb311f35195f977cc253e1dc064
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Sun Jul 19 03:26:13 2009 +0000
libglusterfsclient: Move DHT root-lookup workaround to init
The workaround for the DHT requirement for a lookup on /
needs to be done only once when the xlator graph is inited.
Doing it on every path's lookup results in a major performance
penalty when using distribute subvolumes upwards of 16, as reported
by Avati.
Ref: bug 152
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 152 (libglusterfsclient: DHT workaround is a major performance bottleneck)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=152
commit d6688eb5466d49bf9e205cd60af09a52e7a235ce
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Jul 18 00:37:51 2009 +0000
added timestamp to crash dump log.
also did some minor enhancements in formating
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 151 (crash dump log should be in 'logviewer' friendly format)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=151
commit af7325e8abd90f1a59f359ba3a16b638e7363796
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 17 22:44:24 2009 +0000
fix build warnings in 'libglusterfsclient'
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 130 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=130
commit c95b278988f32a8dced7cdb4e97442b082952fee
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 17 22:44:11 2009 +0000
fix build warnings in 'afr'
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 130 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=130
commit 5a82633dc3350f79d3f223b5d0b940cd7ffdeea1
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 17 22:43:56 2009 +0000
fix build warnings in 'server-protocol'
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 130 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=130
commit da771ee66f825b900ab22f445cc8b9c99f002621
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 17 22:43:19 2009 +0000
fix build warnings in 'client-protocol'
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 130 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=130
commit bb38e1e05dff02606a8db4336c3975ddd0208360
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 17 22:42:55 2009 +0000
fix build warnings in 'io-cache'
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 130 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=130
commit a60fcdbdb9add35802b9da9960f6c652211068f0
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 17 22:42:33 2009 +0000
fix build warnings in 'auth' module
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 130 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=130
commit 02b4fe73ee4105b7fbe216a9d892d6c87e97296c
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 17 22:42:10 2009 +0000
fix build warnings in glusterfsd
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 130 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=130
commit 9e8c27212caeb4cef7b3b3321603a045eb1ae288
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 17 22:41:44 2009 +0000
fix build warnings in 'libglusterfs/'
return value of 'asprintf' was not checked, and the flow was
continuing without returning error, which could cause potential
segfaults in code (mostly possible during ENOMEM case).
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 130 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=130
commit 5e479e1b2e6eddd209cbc71a9eaade60673bbfb5
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 17 22:09:17 2009 +0000
posix getxattr supports new key 'trusted.glusterfs.location'
which can be used to get the file location by 'hostname' of the
machine where file resides.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 131 (provide a way to get the file location in clustered storage)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=131
commit 60ab23424a9f9e574c5ad15f774c95c1e37d7368
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 15 20:06:02 2009 +0000
removed mod_glusterfs from the build
future plan is to have httpd use booster and libglusterfsclient
instead.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit c6b1850060e1a9cb42c75f3f8cc48d3def7f53aa
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Jul 17 08:48:10 2009 +0000
libglusterfsclient: Invalidate not update iattr cache on writev
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 149 (libglusterfsclient interacts incorrectly with write-behind on writev)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=149
commit 8dd95844b0a923b5e120aea25a8c770faba2c491
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 14 17:38:42 2009 +0000
server: don't check for 'loc->parent' in entrylk and inodelk calls
the lock operation on entry or inode is going to happen on only one
inode, and it doesn't need dentry (with info on parent) for the
lock operation to complete. Hence, in server_{inode,entry}lk() calls
after server_loc_fill, we -should not- be checking for parent inode.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 112 (parallel deletion of files mounted by different clients on the same back-end hangs and/or does not completely delete)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=112
commit cad932da6d3690007111bc841af9c3ae64c4216d
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jul 14 17:38:08 2009 +0000
change mount.glusterfs.in to work with non-bash shells too.
removed 'fuction ' prefix to function definitions which was very
much /bin/bash specific.
Thanks to Brent A. Nelson <brent@phys.ufl.edu> for the patch.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 139 (tiny glitch in mount.glusterfs in 2.0.4)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=139
commit caac8cc7ceaaf84b7037f737ddaf7d732a25cdcb
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jun 23 19:08:46 2009 +0000
iostat to have more io details
classified stat for write/read fops based on their block size.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f4b11753f7af89a1106136031ab3af0b5c5475cb
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:29:06 2009 +0000
quick-read: implement release and forget cbks.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 4c63c61d0e5742974f1620d8d43deeeb013ae8bc
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:28:45 2009 +0000
quick-read: implement qr_lk.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit c501a1dd0d7f3392e97cba7eb4695847890b381a
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:28:34 2009 +0000
quick-read: implement qr_ftruncate.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit d84511b9d047f9af85c0c36d316869c1c9505f50
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:28:22 2009 +0000
quick-read: implement qr_fsync.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 563ee7485790c601eef5fde9d055940353033b7d
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:28:08 2009 +0000
quick-read: implement qr_finodelk.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit fe0e01d4d63dc0a3bac9514c158f44b31dc42321
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:27:57 2009 +0000
quick-read: implement qr_fentrylk.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit c769a41a03a31bdcc75023e3e145dbcce741cc0d
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:27:46 2009 +0000
quick-read: implement qr_flush.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 34ec4cfbe829401457ffd2220d9ebf3e1a1e4964
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:27:34 2009 +0000
quick-read: implement qr_fgetxattr.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f346801e9946825005577a7d776a1839a2e6b536
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:27:23 2009 +0000
quick-read: implement qr_fsetxattr.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 8516f4a8df90aa3edfcb1e2db245f3f53fe53344
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:27:11 2009 +0000
quick-read: implement lc_fchmod
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 7a388d22248c71924f4c3042d967c7a99d06bbd3
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:26:58 2009 +0000
quick-read: implement qr_fchown
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 7363c7baf2fd386666c770e3076882755d7a9f3a
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:26:47 2009 +0000
quick-read: implement qr_fstat.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 0e4e9e26e596c8ea776e407bf2dca6cc580a9aad
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:26:35 2009 +0000
quick-read: implement qr_writev
- writev on any fd opened on a file invalidates the cache stored during lookup
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b7ab65f377fd5c2e61ed38bbaaab080d75faf80b
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:26:14 2009 +0000
quick-read: implement qr_readv
- pseudo-code of the algorithm is given below
if (content is cached) {
validate-contents ();
if (content cached is valid) {
stack unwind with cached content;
} else {
goto read-from-storage;
}
} else {
goto read-from-storage;
}
return;
read-from-storage:
if (open is already done on fd) {
stack-wind read;
} else {
add the current readv to list of operations waiting on completion of
open;
if (open on the fd is in transit) {
do nothing;
} else {
stack-wind open;
}
}
return;
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b1e51327a41c87ff22176bb7f5164ab67814ef9f
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:26:00 2009 +0000
quick-read: implement qr_open
- The file is opened actually only if it is not cached already in lookup.
This adds responsibility for fops operating on fds to make sure that a
valid fd actually opened on a file is used to complete the fop.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e94eb82e22e94bb8436160d7bcfb81c810e77c11
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:25:45 2009 +0000
quick-read: add qr_lookup.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e2ac8cb5fbb73d071a79bef10d3c337393119b07
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 00:25:28 2009 +0000
Implementing quick-read translator.
lookup can fetch the entire file in xattr dictionary using the key
"glusterfs.content". We set the maximum size of the file that can
be fetched so in the xattr_req dictionary using the same key. If file-size
is less than or equal to the value set in dictionary, the content is stored
in the dictionary using same key in lookup_cbk.
For small files, we can do an optimization wherein we do not really send the
calls open, read and close to the storage translators. Instead there can be
an xlator which fakes open, read and close calls. For reads, it sends the data
it has cached during lookup and hence saving the time for open, read and close
calls to reach storage translators (this time can be significant if calls have
to go through network to reach storage translator).
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 1ed48f0eb1d4792fe60fda6bc93e8a4acfbdddf1
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Jul 15 09:36:36 2009 +0000
Return stat from read subvolume in dir-write ops.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 138 (create family calls do not return stat buf from read child)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=138
commit 039f5a78d16ccb63a6b90c43d7b2c0b36bef7e88
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Jul 14 08:05:14 2009 +0000
Return stat info from read-child in all the inode-write ops
Also modifies the inode-write ops to wait for the call
to read-child to return (whether success or failure)
before unwinding.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 125 (stat information not returned from the same subvolume always)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=125
commit 47ef393aed47fa52753cb464df381a9e911edf5b
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 15 01:38:33 2009 +0000
add strict validatation of GF_OPTION_TYPE_PATH option type.
Make sure that users don't provide "../" in the path value in volume file,
which should be considered security issue.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 141 (GF_OPTION_TYPE_PATH should check for presence of ".." in path)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=141
commit f61fba2256f6939a83c549ed4ed14967642850cf
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue Jul 14 09:43:23 2009 +0000
fuse-bridge: Export user.glusterfs-booster-mount xattr
This needs to be exported in order to have the booster
Mount Point Bypass technique work through libglusterfsclient.
Booster uses the mount point to register with libglusterfsclient as
a VMP. Subsequently, all file operations on the mounted GlusterFS
mount point get redirected to libglusterfsclient.
This fixes bug 136.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 136 (booster does not redirect ops on GlusterFS mount point into libglusterfsclient)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=136
commit caacd4d9a6ba7eefd1bff013fc6be5ce3fd77fc5
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jul 13 16:59:18 2009 +0000
break inode_path if the length of the path crosses PATH_MAX
a given search for path can't exceed the length of PATH_MAX in any case.
Hence, its best to make sure by adding a check inside the for loop of
inode_path, so that it won't enter an infinite loop.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 134 (infinite loop in inode_path ())
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=134
commit c5607071ab7ea253f71f74a1c12e1524e3e8d4bd
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jul 10 13:39:10 2009 +0000
cleanup 'ctx' from inode and fd
Removing unused 'dict_t *ctx' from both inode and fd structures.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 128 (cleanup unwanted ctx dictionary in 'inode' and 'fd' structures.)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=128
commit c3612f4cc12eab3f9bf83e1f2d31e893fb3dab52
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jul 9 23:59:26 2009 +0000
ib-verbs: don't append ioq_entry to pending_list if first attempt of writing to network fails
* fix to bug #101 - When a buffer bigger than ib-verbs-work-request-send-size
was attempted to write to network, ib-verbs returns ENOTCONN. Neverthless,
the ioq_entry corresponding to the write was appended to the pending lists
of ioq_entries waiting to be written to network. This resulted in double
free of header, once in protocol_client_xfer and again during cleanup of
transport. The transport cleanup happened due to the timeouts of
subsequent operations, since ioq_entry corresponding to writev
was blocking any other operations from reaching server.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 101 (ib-verbs config crashing while dd'ing with a big mtu size)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=101
commit 7a3136923d282fa686f52af21c7f17231670a02b
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jul 14 06:41:33 2009 +0000
fuse_bridge: handle failures in init() more gracefully
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 132 (fuse-bridge could do with some cleanups)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=132
commit 8e1362bfc5830da366c1beb3e49dfd7754ae80ca
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jul 14 06:40:09 2009 +0000
fuse-bridge: formatting cleanups
- use PRIu64 for printing "unique"
- use fcntl defines instead of explicit numeric values for querying open flags
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 132 (fuse-bridge could do with some cleanups)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=132
commit 661a829ce9f151c0cc7327f9768a243c29df41a6
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jul 14 06:38:34 2009 +0000
fuse-bridge: further allocation failure handling fixes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 132 (fuse-bridge could do with some cleanups)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=132
commit bf9f44a477c85d60065ebe10bc19abe4677a09b9
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jul 9 12:17:54 2009 +0000
fuse-bridge: handle state allocation failure
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 124 (state allocation failure not handled)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=124
commit c8ea63fb1cfd9413a78c4b6872f4c517ae59ec7c
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jul 9 06:47:14 2009 +0000
Added NULL checks in a few places.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 119 (filter + replicate crash..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=119
commit 6059353de67d1cf8f29efad880f13780e18f99b7
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jul 9 05:33:54 2009 +0000
Return inode number always from the first up subvolume in AFR.
Also fixes a bug in the "KLUDGE" part. It was setting lookup_buf
when it should have been setting local->cont.lookup.buf
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 116 (Replicate: Need inode number from first subvolume on fresh lookup)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=116
commit 8f581efc7c16b5a1497a04505a734fa2ac4235d0
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Wed Jul 8 23:54:48 2009 -0700
Added format-patch.sh. This script is to be used as a replacement of "git format-patch" with similar arguments for submitting patches to the GlusterFS project
commit 41793c79697314e5c881d327997793054ad15c6a
Author: Csaba Henk <csaba@gluster.com>
Date: Wed Jul 8 06:55:09 2009 +0000
detabify fuse-bridge.c (and other whitespace fixes)
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 1abc3fd0ad75351e7cac07184b867e397e5ee096
Author: Anand Avati <avati@gluster.com>
Date: Tue Jul 7 20:42:42 2009 +0000
protocol/server: use translated flags in protocol/server open and create fops
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 06696dce3d10965c2ced35764ae8f3965b6de33c
Author: Anand Avati <avati@gluster.com>
Date: Tue Jul 7 20:42:21 2009 +0000
protocol/client: use translated flags in protocol/client open and create fops
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 257be9643091eeaf6bd7fb3a75674167ce78bda1
Author: Anand Avati <avati@gluster.com>
Date: Tue Jul 7 20:41:59 2009 +0000
protocol: add functions gf_flags_from_flags and gf_flags_to_flags
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 4b4dad830f6a440e5941c987c7514dcbd4194e4d
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Jun 30 01:14:44 2009 +0000
write-behind: set default window-size to 1MB.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 43017ac71d7b90a2740f9ba3a31a9f665292d541
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Tue Jul 7 07:58:05 2009 +0000
use fuse_reply_iov() in fuse_readv_cbk
changes come in two places.
configure.ac - define HAVE_FUSE_REPLY_IOV if fuse_reply_iov is
available in libfuse.
mount/fuse - use fuse_reply_iov() in place of fuse_reply_vec(), if
HAVE_FUSE_REPLY_IOV is defined.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit bbbb2b67440716c36ad45b1c9d339920071106e4
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Jul 7 02:33:43 2009 +0000
filter: use O_ACCMODE for checking file access modes.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e7bf75f94f5eebc914ce6cdb8e69fb63ecda1868
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Jul 7 02:33:31 2009 +0000
read-ahead: use O_ACCMODE for checking file access modes.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit aa2450e59f4fa8cdb5def352dede5cbb204d7bec
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Jul 7 02:33:15 2009 +0000
write-behind: Use O_ACCMODE while checking for access modes.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 5679c0d1f42ed8c1eb3029de0e5d7e9314d903a8
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jul 2 06:20:21 2009 +0000
libglusterfsclient: Update attr cache on read/write
We werent updating the attr AKA stat cache on read and write
on files so every stat on the file before the timeout was returning
stale attr from the cache. Yuck!
This fixes it. Turns out there is a good aspect of unfs3's notoriety
when it comes to doing stat()s for every operation.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 6204c057bd4c9e2456e691d5e4e95e88d0974238
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jul 6 22:08:21 2009 +0000
libglusterfs/defaults - send CHILD_UP notify only to the parent which has been init()ed.
fixes bz# 12
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 9072693f61dc2a279456174954c6b0a9b0592bcc
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jul 6 04:27:10 2009 +0000
libglusterfs/logging - fix memory leak
in _gf_log(), free 'msg' before returning.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 57fad850f6cfa22824d5758498896e2902a9b3c3
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Jul 6 05:59:47 2009 +0000
Set timestamps properly when creating missing entries.
In AFR self-heal set timestamp of a freshly created missing entry
to that of the source entry.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit a9bd5fc09a5ec878f68f562d1e54022a554aca45
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jul 6 05:47:25 2009 +0000
libglusterfs - remove definition of ZR_FILENAME_MAX
to maintain uniformity of maximum length of file name, through out
glusterfs, use NAME_MAX.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f13ac2bcb80aaca7758f961eaca45f1f9825d13b
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jul 6 05:47:32 2009 +0000
cluster/afr - replace ZR_FILENAME_MAX by NAME_MAX
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 680df2ac20399d5756140a0dd7d35ee1ef067794
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jul 6 05:47:31 2009 +0000
cluster/unify - replace ZR_FILENAME_MAX by NAME_MAX
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 73d7ce20aeb1057effff2b21c1c699467fd5b422
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jul 6 05:47:30 2009 +0000
protocol/server - replace ZR_FILENAME_MAX by NAME_MAX
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 3daca12226084b427f1d9050e767c1f4bd700517
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jul 6 05:47:29 2009 +0000
protocol/client - replace ZR_FILENAME_MAX by NAME_MAX
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 740ce3bbd5d69814e7e95cb9089acfadf6dfcb12
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jul 6 05:47:28 2009 +0000
storage/bdb - replace ZR_FILENAME_MAX by NAME_MAX
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 7f0b7ca41dabcf7190ef72ca08ce92599a6e2c91
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jul 6 05:47:27 2009 +0000
storage/posix - replace ZR_FILENAME_MAX by NAME_MAX
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 4d6bef12ea7062e4f52a8d3f1c46a90dd5254156
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jul 6 05:47:26 2009 +0000
libglusterfs/call-stub - replace ZR_FILENAME_MAX by NAME_MAX
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit cead45a0c70e0358e128eeeabf88c9d1b83dfc93
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Mon Jul 6 03:39:19 2009 +0000
Updated man page with log-server options
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 4dd02578dd9ee74fd9427c454a8e6362e641a4b3
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Mon Jul 6 03:39:11 2009 +0000
Added new man page for mount.glusterfs
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 6102be7ac89ace52dc13c7d5f3c72683fe54ae5b
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Mon Jul 6 03:39:03 2009 +0000
Modified mount.glusterfs to print usage in case of no mountpoint provided and "-o" options to be agnostic of their position.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit cff848d7b5925c06f579c9cd85e6e767c3888ed3
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Sat Jul 4 05:10:28 2009 +0000
mem-pool: Do not perform chunkhead2ptr on MALLOCed memory
Memory allocated from the heap instead of the mem-pool
need not under go the chunkhead to ptr conversion when returning
to a mem-pool user since this address can be use directly.
This fixes a crash in io-threads.
Ref: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=102
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 1f12a3fffc3d14ed0e9248f8c3e97d33dcbf9a21
Author: Csaba Henk <csaba@gluster.com>
Date: Thu Jul 2 11:03:57 2009 +0000
booster: automake 1.11 compatibility fix
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 454b568d4a5993cd38bdc1df7ed57163bd2a53a4
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jul 2 00:52:28 2009 +0000
libglusterfsclient: Use O_ACCMODE for access mode checks
Ref: http://www.gnu.org/s/libc/manual/html_node/Access-Modes.html
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 738345ce24ac3d9f96c4a8d84dfe61e1a6bb0f71
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jul 2 07:08:47 2009 +0000
Print volume file after printing other details.
This makes the log format compatible with earlier
versions. Fixes bug #105.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit c6d662322943e2172d82f48e26a539c78a32216e
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Jul 2 01:55:29 2009 +0000
performance/write-behind - bug fix in open() and create().
open() & create() calls should reset frame->local to NULL.
bz# 104
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 61d3c07ebe2bdc9e8e7848a24a45eedd71e1b26d
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 1 00:49:54 2009 +0000
server protocol forget cleanup
as client now doesn't send forget at all to server, it should take care
of forgetting the inode when there is a successful unlink and rmdir fops.
also cleaned up unwanted forget fop's code.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 9e43bafdc2757c69992fa09a25f9267c6b6b3a81
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jul 1 00:47:29 2009 +0000
cleanup client_forget
upon detailed inspection of 'forget' behavior, it became evident that
forgets from client should not goto server side, as server keeps its
own purging mechanism to forget its inodes.
if client sends all forget to server, many highly used required inodes
may get freed up (it will surely effect io-cache buffers on server side)
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e5d069acdcf8a70b42cd9781bf9000a2dceca31e
Author: Harshavardhana <harsha@zresearch.com>
Date: Wed Jul 1 04:13:09 2009 +0000
rpm spec file updates (removed mod_glusterfs and respective dependencies)
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 8f86e8647286f64c317189da657ec75809101c6e
Author: Harshavardhana <harsha@zresearch.com>
Date: Wed Jul 1 04:13:29 2009 +0000
fuse 2.8 support for xlator/fuse
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 18ca6d94e5b06b8d09db4f8095e6d4ee0437f837
Author: Harshavardhana <harsha@zresearch.com>
Date: Wed Jul 1 04:13:23 2009 +0000
fuse 2.8 version check at configure level
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 8777b1b45b4867deb32d241e6f5f664ba32d7bb2
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jun 30 17:48:59 2009 +0000
build warning fixes
integer typecast warnings fixed
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 9d7c6421fae7b75169f00630ce5447175666fce0
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jun 30 13:50:54 2009 +0000
enhancement in write-behind
Write calls should not be pushed to background only when the
mandatory locking is enabled, in all other cases (eg: O_SYNC,
O_DIRECT etc), we should not be 'caching' any data, but the
calls can be pushed to the background.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit bb77418cdad5829ce0649cea73a89cbb87e32b90
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jun 30 17:08:50 2009 +0000
version changes in GIT repo to differentiate between branches
package-version: because master is undergoing changes for 2.1.x release,
protocol-version: because of addition of mops 'log'
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 8ee87687ec18f1df5ec94f8e5c11e1d12230a033
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Jun 30 00:15:34 2009 +0000
client_xattrop: use dict_allocate_and_serialize during serializing xattr
- though the previous commit fixes bug #29, this patch fixes bugs
arising in similar situations where xattrop is initiated by
xlators other than afr.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit ab25b6c62cea1f61cada3272cd5f1f96da567a6a
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Tue Jun 30 00:43:56 2009 +0000
cluster/afr - use different dictionaries for sending xattrop requests to each of the subvolume
- This patch fixes bug #29.
- Using separate copies of dictionaries also eliminates a potential bug in a
setup consisting of afr with a posix and client, each having io-threads on
top as children. Since posix_xattrop after performing required operations
on the xattr array passed in dictionary, sets the result at the same key
and in the same dictionary passed as input argument,
there can be race conditions where in the results of the operation on
posix-child can be sent to the other child as input argument for xattrop,
which ofcourse is wrong.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 6bacd9c3cf18c36c7ab79b22333e7693b7dcff92
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Jun 29 09:38:29 2009 +0000
booster: Fix build problems with various libtool versions
We've been facing a problem on some test systems where the
booster.so is built by libtool as an executable rather than
a dynamically loadable library.
This problem is probably caused by it seeing a _init function in
the source. This is the name of the libc initiliazation
function so it could be the source of the problem.
In any case, ld-preloadable libraries must not have a function
called _init, instead they need to have __attribute ((constructor))
as the attribute for any and all functions the library wants
executed before the program's main(). Our earlier approach was
inherently problematic.
This commit also cleans up the booster Makefile for better
build behaviour. Credit: Harsha.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e3bff2efb3265c9a4fb12c4aef407a2a452c26ef
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Jun 26 13:05:00 2009 +0000
libglusterfsclient: Fix glusterfs_mount-vmp search deadlock
It is possible that the only translator in the libglusterfsclient
tree is the posix. In that case, inside gluster_init, the graph
init routines will need to call lstat on the posix subdirectory.
Since even the glusterfs stack is running over booster, those
calls will also first require vmp searching. BUT, the vmp lock
is the same as the mount lock that was already taken when we entered
glusterfs_mount, so a deadlock occurs.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 09da37a7315e325579ce300c16753bcee1af3725
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jun 25 14:31:30 2009 +0000
booster: Another attempt to fix 32 and 64 bit interoperability
With this patch, we might have finally arrived at a solution
to the problem of function definition conflicts between
our functions and those of libc while over-riding the libc versions.
This commit defines functions which do not conflict with libc,
then it uses libc's own macro to redirect/rename these functions
to the actual sys call names in the binary.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b36490ffa6cb12afbf8b00abea8a03100913c9de
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jun 25 14:31:29 2009 +0000
libglusterfs-fd: Simplify gf_roundup_power_of_two
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 929558581659d32a21b054ac812b7a11437b76cc
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jun 25 14:31:28 2009 +0000
booster: Remove gf_fd_unused_get2
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 7bf81eef8940728def765d99fda64f8e0c54371b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jun 25 14:31:27 2009 +0000
booster: Add new booster-specific fd-table
The reason we need a booster specific fd-table is because
the libglusterfs fd-table has come to a point where it is
optimized for libglusterfs-style of fd allocations.
This conflicts with the way booster requires fds to be allocated
so this commit brings in a re-based version of a booster-specific
fd-table written by Raghu.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit c08ff447c93bc0e86f5be1c1963ca61a765e7b05
Author: Erick Tryzelaar <idadesub@users.sourceforge.net>
Date: Fri Jun 26 13:36:00 2009 +0000
Fix some trivial typos.
I noticed that there were some minor spelling mistakes/typos in some
of the source files. This patch fixes the ones I've found.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f6f5f07937bd4490ec82594623fc3fb9a4972e73
Author: Harshavardhana Ranganath <harsha@gluster.com>
Date: Thu Jun 25 23:12:00 2009 +0000
Added new options for log-server and log-server-port
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 8b169ae9ab0aa6d12a9ff1adc078d8f8860107da
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 25 16:11:44 2009 +0000
version check between client/server made more specific to protocol only.
This patch is a step towards giving compatibility between the versions of
GlusterFS. Now onwards, the protocol-version won't depend on release
versions. In general, multiple glusterfs versions can have common
protocol-version.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 46cc0f677d7216d0c472634c4dcd623165ff67ef
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Jun 24 18:31:10 2009 +0000
dht_readdir_cbk: use stat attributes in the READDIRPLUS dirents to
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 0fe1b3b9ce513d2ce28e7c2fca22a5f045bd8a82
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Jun 24 18:31:09 2009 +0000
rename dht_first_up_child to dht_first_up_subvol
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 7d01f47d7be7e47d797d1a08aa160aa9dd5c8844
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Jun 24 18:31:07 2009 +0000
posix_readdir: fill stat structure into dir entry
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f405987b73b546e2a41c9ea5ea58725b42d2a4a1
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Jun 24 18:31:06 2009 +0000
gf-dirent: add support for stat attribute in dir entry (to work like
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit eaafd343cd59be76e6b11032f45d8e5e4190f1db
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 24 13:31:11 2009 +0000
mount script to take arguments like nfs
Ref: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=37
earlier instead of path, it used to take port number, which is an
option (-o server-port=<port>), now.
new syntax is
bash# mount -t glusterfs <hostname>:<path/key> [mountpoint]
[This patch is backward compatible with earlier syntax]
bash# mount -t glusterfs <hostname>:<port> [mountpoint]
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 7c81e9ae73c89e95c4c4631f6712fa6ff2f85983
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jun 23 13:41:26 2009 +0000
server-protocol: interpret the 'op' value properly when a packet is received.
Ref: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=35
The check done earlier was not handling the case when a 'op' is == MAX_VALUE (which
is not defined), and used to skip to the next array (like gf_mops[MAX] == gf_cbks[0])
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 155f4195949bf0bee7f05512b859ed049a5a3e1c
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Jun 23 10:13:04 2009 +0000
check if the 'key' is the volume file name itself.
With this patch, one can fetch any volumefile which is not pre-defined in
volume file with 'option' in server protocol volume, instead clients can
fetch the volume files based on the key name itself [From the confdir only]
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 2fda6ad0877b4237796ed2991285a70eeef4803b
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jun 22 19:26:06 2009 +0000
mount.glusterfs.in correctness in case of duplicate mount
mount.<fstype> script/program should return success in case when it finds
duplicate mounts. It was returning failure earlier. Someversions of
automount programs had issues with this behavior.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit d3689334e8e8a0efd5cdb538cc1186102c1976cd
Author: Csaba Henk <csaba@gluster.com>
Date: Tue Jun 23 04:25:22 2009 +0000
Fix typos in my previous commit 6010e2a4e
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit abb7e7ba7eeefc3908bcd86c2ade1d847cd7de61
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Jun 22 07:53:03 2009 +0000
glusterfsd - build proper mount/fuse structure.
while appending mount/fuse to a translator tree, make sure
that <xlator_t-of-fuse>->next points to the first xlator in
the list of xlators and not the subvolume of mount/fuse.
NOTE: tree traversal should always happen through <xlator_t>->children
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e23f827ce9643f498078dfb8d346b82115149448
Author: Csaba Henk <csaba@gluster.com>
Date: Mon Jun 22 00:56:13 2009 +0000
fuse: instead of having a fixed option list, assemble it using "fuse_opt_add_arg"
This makes it easier to adjust the option list, and also reduces redundancy.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 2c7f51cd6a80c0916f37f726f36b0c9ce9b3e1ce
Author: Vijay Bellur <vijay@gluster.com>
Date: Sun Jun 21 01:28:51 2009 +0000
Avoid accessing local unconditionally in trash_common_*_cbk functions.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 00f1a6bf60d986f63970b7d9b568727d77c4fc27
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 18 15:58:22 2009 +0000
local->loc should be filled in dht-mknod()
local->loc should be properly filled while creating a linkfile. otherwise
this causes the segfault in underlying volume layer (mostly client-protocol).
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 301a20a62d1d8a56a8bb85cdb282bb6b3ad6ed36
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Jun 16 05:25:17 2009 +0000
Add command line option to specify central log server.
Added two command line options:
--log-server SERVER
--log-server-port PORT
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 62858193ca6a7ba2e6847a3d4ba8b667f102ebc3
Author: Harshavardhana <harsha@zresearch.com>
Date: Tue Jun 16 10:34:44 2009 +0000
Remove the trailing "/" which fails build with new version of automake
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f4a826e22d5a7bc92a001dc6cb8b3fc2b9a24758
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Jun 18 14:21:15 2009 +0000
making dht and nufa's 'min-free-disk' option to take both percent and disk-size
Originally from Paul Rawson <plrca2@gmail.com>
http://patches.gluster.com/patch/391/ : patch re-submitted with patching guidelines.
cluster/distribute, and cluster/nufa uses new option PERCENT_OR_SIZET for its
option 'min-free-disk'.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f19fe6e30fefeb71a8a9b2f7edeeec6ad5a1d3bf
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 17 20:58:20 2009 +0000
adding an extra xlator option type, GF_OPTION_PERCENT_OR_SIZET.
Originally from Paul Rawson <plrca2@gmail.com>
http://patches.gluster.com/patch/391/ : patch re-submitted with patching guidelines.
with this patch, the xlator volume options get another type which can take
arguments either in 'percent' or in 'bytes', which is useful in many cases.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit ade423c50b5d522d5c0750d4a70fecca0ed90be4
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jun 18 05:33:27 2009 +0000
libglusterfs: Prevent gf_fd_put'ing of unallocated fd
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 780b8cda24307a08945c2c8bb924364ce134da07
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jun 18 05:33:20 2009 +0000
libglusterfs: Chain newly allocated fdentries.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit d2f6aad73351be10ff016af507d9118fc418dcbd
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu Jun 18 05:33:13 2009 +0000
libglusterfs: Change GF_FDENTRY_ALLOCATED constant
This change is being brought in so that we can
differentiate between fdentry_ts when debugging using
gdb.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 67b6f3511bc5b09ecd1a8621433a722e841c3878
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Jun 17 20:56:52 2009 +0000
change the log level of disk full message in dht-diskusage
the current msg is getting printed in warning level. Instead changed
it to debug, as the msg specific each node being full is already getting
printed in higher priority, hence this msg looks excessive.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit a5c48d993ba6a8e22d65032bc714e3c64db289b1
Author: Harshavardhana Ranganath <harsha@zresearch.com>
Date: Tue Jun 16 11:04:10 2009 +0000
Booster build should not depend on if mod_glusterfs is disabled
Thanks to Erick Tryzelaar
Sending this patch on behalf of Erick Tryzelaar <idadesub@users.sourceforge.net>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f1812c4361ec7006ba528e983efafa65d6a228c0
Author: Vijay Bellur <vijay@gluster.com>
Date: Wed Jun 17 11:52:13 2009 +0000
Removed the swap being done for __noswap functions.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 838e0d8ef02d937d8eb46a72986e8745370ecf02
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Jun 5 17:51:59 2009 +0000
change ha-statfs() to handle the case of loc->inode being NULL
This fix is needed in ha_statfs(), as the current code doesn't handle
the case of loc->inode being NULL, which is a valid case in statfs()
[Remember its stateless call]. This was causing 100% disk full logs in
distribute or nufa as the logic of checking whether the subvolumes have
enough disk space on them used to fail.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b53515563e312fd1cd667e4bda5839e2f9da4b14
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Jun 15 13:05:52 2009 +0000
client: Replace saved_fds dict with list
Thhie change removes a huge inefficiency in file open
path where every open resulted in dictionary operations
in order to let the client maintain a list of fd_t's being
used over a particular client context.
Resolves: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=16
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 0524dec74306459dae609cc0ccde20ac0dbd4004
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Mon Jun 15 13:05:39 2009 +0000
libglusterfs: Turn fd-table O(1)
This commit reduces CPU usage of gf_fd_unused_get drastically by
making it O(1) instead of O(n).
Related to: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=16
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit c7ed142f24b3da8430c8fc366043d803c4040894
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Jun 15 04:12:42 2009 +0000
write-behind: fix memory corruption
- wb_sync did not set local = NULL after stack_wind. It also used to free
local if its not NULL as part of cleanup process. Hence there was a double
free in STACK_DESTROY done in wb_sync_cbk.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit aae502eb89450589c8236fe5a4241ff8237e9f65
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Jun 15 04:12:21 2009 +0000
write-behind: check for memory allocation failures and take appropriate action
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 362a0be46ae9d36909ba6adc72dbb91043dd6764
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Jun 15 07:16:31 2009 +0000
Do stat to check mode of the export directory in storage/posix.
Doing an lstat means init fails if the export directory
is a symlink pointing to a directory.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 970a3e9563e6ce575dc24496787b38805031a8fa
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Jun 15 00:02:57 2009 +0000
booster: fix build error in fcntl implementation.
- F_DUPFD_CLOEXEC is defined only in linux kernel versions >= 2.6.24
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit a26b689d2910cfca3a1d7536613ce11b8d88373c
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Mon Jun 15 02:58:36 2009 -0700
io-cache: fix warning by initializing conf = NULL
commit 51bde3c0674234e77a7d629d171135cc821763e8
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Mon Jun 15 02:57:25 2009 -0700
read-ahead: fix warning by initializing conf = NULL
commit 6f58f40484120328128e4dc5eb8d33382ca540a4
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Fri Jun 12 05:11:53 2009 +0000
libglusterfsclient: Call inode_lookup to prevent pruning
This bug shows up while using unfs3 with replicate. The absence
of an inode_lookup on a looked-up/created inode results in it
getting pruned from the inode table. Consequently, a subsequent
lookup for the inode results in a different inode number being
returned by replicate. This breaks unfs3 because it tries to remember
the inode numbers returned by two different stat-family calls.
Resolves: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=11
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit a0f2b204a67e9c01f04cca4a9ce35df53e90ea20
Author: Amar Tumballi <amar@gluster.com>
Date: Wed May 27 17:50:32 2009 +0000
strict check of extended attribute flags while opening a striped file
Added a fd_ctx structure for stripe, which takes care of understanding the
extended attribute flags, and opening the right blocks in order (to make
sure the read/write operations happen in order).
Helps to handle situations like accidentally adding subvolumes to stripe, etc
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 3b1e954c6603b8181eb16784e64ae030c1c39e88
Author: Amar Tumballi <amar@gluster.com>
Date: Wed May 27 17:49:10 2009 +0000
stripe: don't allow entry modification operations when any node is down
if entry modification operations (like create/mknod/rename) happen when there is
a node down, there will be inconsistency in striped fs. rather than curing it,
prevent the issue from happening
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit dfdc8258d0bc022a82f500349c9aaf3e28a08ad6
Author: Amar Tumballi <amar@del.gluster.com>
Date: Wed May 27 17:46:29 2009 +0000
stripe cleanup
stripe.c:
indentation cleanup
log messages cleanup
coding standard guidelines
removed ERR_ABORTs
stripe.h
moved the structure definitions here
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 80dc1036218d3ea99f40d06f2454d38998ecd564
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jun 11 01:46:04 2009 +0000
io-cache: handle memory allocation failures
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 329c4c2bc94d1b31f5d75dacdd09d1ea47eb33f3
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Jun 9 05:08:59 2009 +0000
Initialize central logging in glusterfs main().
Modified from patch 522 (made a function extern) -- Avati
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e76c3999e0e366b9659ca777ac743d3ac9fc45d2
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Jun 9 05:09:01 2009 +0000
Implemented LOG MOP in server-protocol.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 5d3617d55a9861175e06015a0a87d5c3aa9e1be0
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Jun 9 05:09:00 2009 +0000
Log to a central server.
Several functions to support centralized logging:
- create a logging thread upon init
- gf_log submits log messages to the logging thread which
in turn sends it to the server using the MOP log
- on the server side, log messages from a client are written
to the filename <log file name>.client-<transport-identifier>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit d160cb9ed6b094ce51590c7ac311150b99b64d8a
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Jun 9 05:08:59 2009 +0000
Functions to store a central log flag in TLS.
The flag is set in TLS so that a re-entry into
gf_central_log does not deadlock.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 303784eafc3095f92d750d296b941c01dfd7ee30
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Jun 9 05:08:59 2009 +0000
Include glusterfs.h in dict.c
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 300368bdfe309fbc2ef85a517013be74d9e47f94
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Jun 9 05:08:58 2009 +0000
Implemented LOG MOP in client-protocol.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b83862c306643d583a7cd61cb627f36c890e18f5
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Jun 9 05:08:58 2009 +0000
Added MOP log to libglusterfs/*
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 04acf4a41cf0a83c7cae94496bb8d45ee0372e3c
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jun 11 08:47:06 2009 +0000
Do not fail over readdir in replicate.
If readdir fails on a subvolume, do not
fail-over to the next subvolume, since the
order of entries and offsets won't be same
on all subvolumes.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f79eae408f52cf458855a820f25e723130edcf0b
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jun 11 08:46:40 2009 +0000
Do itransform on every entry in readdir_cbk.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 892c0379dd4fa5f7d5ced5f826257bd461fdeaf3
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 07:02:27 2009 +0000
booster: fix memory corruption in booster_cleanup
- calling glusterfs_umount_all leads to memory corruption.
hence commenting out for timebeing.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 00dc50e368e99472646578ce9662a29dda711e51
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 07:02:15 2009 +0000
libglusterfsclient: reset the vmplist and vmpentries to 0 in glusterfs_reset
- Generally glusterfs_reset is called after fork in child to empty out
vmplist.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 427949dd088c20f5e5d57a0387465afb55784c97
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 07:01:59 2009 +0000
booster: implement fcntl.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 404c39c2ee8245bf4b46e6211c1505d9ce5c1517
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 07:01:45 2009 +0000
libglusterfsclient: implement glusterfs_fcntl.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e7e0fc694b6c57773ad73acf905b7e014c46929e
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jun 11 04:59:00 2009 +0000
booster: implement readdir_r and readdir64_r.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 40d2f283a05e3db7217c1c10923ea178d9188f38
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 07:01:16 2009 +0000
libglusterfsclient: implement glusterfs_readdir_r
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 55db16926c02873e91b2dbd9a0f27cf0696798f4
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 07:00:59 2009 +0000
libglusterfsclient: update offset in glusterfs_read_async_cbk only if offset stored in fd_ctx is used.
- this helps in implementing sendfile(2). manpage says that
"If offset is not NULL, then sendfile() does not modify the current
file offset of in_fd"
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 407fffc560e0d5d5bdd01e14b3eb886543b69aa5
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 07:00:44 2009 +0000
booster: call glusterfs_umount_all during cleanup
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit c8a86dfde31413917f62c1a8b7a67d73064c98df
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 07:00:26 2009 +0000
booster: implement sendfile.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit cc53bbd819d30795dc68087141cccb817915143f
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jun 11 04:58:30 2009 +0000
libglusterfsclient: implement glusterfs_sendfile.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 3d1c77895f44a539952eda64c513d98e1957d632
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 06:59:50 2009 +0000
libglusterfsclient: add glusterfs_umount_all.
- unmounts all the entries in the vmplist.
- this api helps booster to cleanup all the mounts in a single call.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit d49153f1ea0c16d72e7e6cbf768d342f62cc1f42
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 06:59:34 2009 +0000
libglusterfsclient: make glusterfs_umount thread safe
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 4489ab2e1471f17c1e2e0c08721a31a732fe0e75
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 06:59:14 2009 +0000
libglusterfsclient: make glusterfs_mount thread safe.
- this patch also checks for the presence of vmp before adding
an vmpentry.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b7d4aea643d34bf2bdfa05516ad0de82807d772a
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 10 06:55:32 2009 +0000
booster: remove mount table which maps a path to glusterfs handler.
- if there are any glusterfs mounts(real, not virtual) which are not specified
through booster-fstab those mounts are also added to the virtual mountpoint
list of libglusterfsclient. This also removes the mount table in booster and
all the mounts whether they are real or virtual are handled by
libglusterfsclient.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b3989e80db9df9add4a1a6d1d42de2eaf760f912
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Jun 11 04:36:14 2009 +0000
Filter out changelog xattrs in replicate.
The AFR changelog xattrs, "trusted.afr.*" are now
filtered and prevented from being visible on the
mountpoint.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 781624ae010cf08b5567f22e02683f247ee686f3
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Jun 10 01:25:38 2009 +0000
io-threads: Fix missed notification in sem_timedwait
We're performing a calculation for skewing idle time
that resulted in a timespec.tv_nsec value becoming larger than
1000 million or less than 0, forcing sem_timedwait to return
with an EINVAL instead of waiting for a request notification
from sem_post in iot_notify_worker(). This resulted in a missed
notification that resulted in a hang followed by a timeout
on the protocol/client side.
This commit avoids the over- and under-flow in tv_nsec by
skewing the tv_sec value instead.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f88cce4c853129e47f7d5bdafadcccb3af906663
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jun 11 01:45:45 2009 +0000
read-ahead: handle memory allocation failures
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e132d0aab0fb5ceb34277339a740022791bd7900
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jun 4 06:14:31 2009 +0000
read-ahead: return with error code EBADF for fops on fds without file set in their context.
- since a successful open/create will _always_ set a pointer to ra_file_t in
context of fd, this fix makes sense.
- an example of operations on bad fd can be afr sending read on the child
which was down during open.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 9cb6f4a7bc1046ce9eb00b21a30a07cbf22ff222
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Jun 4 06:13:58 2009 +0000
read-ahead: unwind with a return value of -1 and error code of ENOMEM on memory allocation for ra_file in open/create
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 3f0d09baa484d5a194b603e38ce93d568f8ea171
Author: Amar Tumballi <amar@gluster.com>
Date: Fri May 29 16:08:04 2009 +0000
removed unused option 'page-size' in io-cache
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit da111bdbc0cabe52acf5f1904305c49e27122fa7
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Jun 8 07:18:18 2009 +0000
Print PID after daemonizing glusterfs.
PID used to be printed before glusterfs became a daemon,
which is incorrect since becoming a daemon involves
forking and thus the PID changes.
Fixes bug #8.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 4938d00cb9136f1c05635f6e7a9ee9e41eacc169
Author: Anand V. Avati <avati@dev.gluster.com>
Date: Tue Jun 9 06:17:37 2009 -0700
configure.ac: print summary to stdout
commit 365ec53d41b56065358f3798f2169b3067443988
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Jun 3 00:38:26 2009 +0000
server-helpers: cleanup connection only if there are no active transports.
- thanks to Ioannis Aslanidis <iaslanidis@flumotion.com> for reporting.
- breakup the server_connection_cleanup into smaller procedures.
- do following operations in a single atomic operation.
1. conn->active_transports--
2. collecting pointer to lock table and all fds if there are no active transports
this will avoid any race conditions.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit bbedfade92257c5c3a211cfac95074582bdb67f8
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Jun 3 02:17:19 2009 +0000
Fix crash in afr data self heal. Bugzilla ID: 3
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 3cad7c963cc5000b2b38db857548b87aa1107174
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Jun 3 01:05:42 2009 +0000
libglusterfsclient: Avoid dirent copies in readdir cbk
We can avoid memory allocation, de-allocation and
data copies by just using the entries passed to us from
a lower layer and by de-linking the entries from the original
list.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 3365abb9d9147fa978f4f9151d97636781948980
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Jun 3 01:05:34 2009 +0000
libglusterfs: Add empty and NULL dirents list checks
These checks are needed in case a higher layer intends to
delink the dirent list and passes a NULL pointer to
fop_readdir_cbk_stub for the entries parameter.
Consequently, the gf_dirent_free must guard against an empty list
because the stub that is passed to it mgiht have an empty
dirent list.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e2e022dc80a5cc5f74112b3e2a1708c27cda103a
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Jun 1 17:58:41 2009 +0000
ib-verbs error log enhancement
Earlier it was thought that only not having 'opensm' running will cause
handshake errors in ib-verbs.
Recently understood that even having a wrong 'ib-verbs.port' option can
also cause the same behavior, and it took more than 5-6 e-mail iterations
with the user and lot of brain cycle in support team to understand the
problem. Made the log message more descriptive, so user can be find the
cause, or can send us email without wasting time.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 4cea0904372d1ff6e03e8296b577990b0f4d9814
Author: Anand Avati <avati@gluster.com>
Date: Fri May 29 13:52:07 2009 +0000
io-cache: prevent frames from getting woken up while page is getting validated
1. A page will be put on the inode waitq if the 'freshness' has to be verified with an fstat()
2. while the fstat is in transit, other calls (like lookup) can update ioc_inode->tv, resetting the freshness (page still on inode waitq)
3. Another read request on the same page, after the updated freshness, will wake up the page frames neglecting the fact that the page is also waiting on the inode (waiting for the fstat completion)
4. once the page's frames are woken, the page becomes elegible for purging and can get destroyed for various reasons, leaving a destroyed page pointer in the inode's waitq
5. fstat returns and hits the destroyed page pointer causing a crash
The fix is to all together disable cache hits when any page of the same inode is under validation. The otherwise cache hit will now be subjected to the ongoing validation by getting queued to the inode waitq.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 8375402e362bbd46316fd4398c71be363f6acde4
Author: Amar Tumballi <amar@gluster.com>
Date: Fri May 29 16:09:05 2009 +0000
unify getdents count reduced to 512 (from 1024)
Thanks to Krishna <krishna (at) gluster.com> for pointing this out.
When a unify self-heal of large directory (directory with lot of entries)
is done, the getdents_cbk used to fail because of new limit of buffer size
(128KB). Noticed that earlier it used to streach upto 4MB, hence the value
1024 worked fine. By reducing it to 512, noticed, we can fit in well within
128KB limit, and hence unify self-heal goes through.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 5a6d67b464f3e17d8263c3488f36a0d57037ced5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu May 28 04:43:05 2009 +0000
libglusterfsclient: Increase readdir block size
This improves the potential for pre-fetching a larger
number of dirents. Consider that, with 255 chars as the max
name length for each dirent, in the worst case scenario, where
we actually have files with such large names, we're not getting
more than 4 entries with the current block size of 1024.
Generally also, increasing the size to 4k provides us
with a higher chance that directories with low to medium
number of dirents will be pre-fetched in a single readdir fop.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit dae832f869f4cbea10588122b0af74d7b3653463
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu May 28 04:42:58 2009 +0000
libglusterfsclient: Add dirent pre-fetching and caching
The fop interface is such that we're able to extract more than
1 dirent in a readdir fop. This commit now enables libglusterfsclient
to read multiple entries on a glusterfs_readdir call. Once these
have been pre-fetched, they're cached till either glusterfs_closedir
,glusterfs_rewinddir or glusterfs_seekdir are called.
The current implementation is beneficial for sequential directory
reading and probably indifferent to applications that do a lot of seekdir
and rewinddir after opening the directory. This is because
both these calls result in dirent cache invalidation.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit e778ca70f1ddae0584e8a7cd17206c33513fd846
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu May 28 04:42:51 2009 +0000
booster: attr_timeout: Read timeout from booster fstab
In order to expose the timeout values for stat and inode
caching, this commit introduces a new fstab option "attr_timeout"
that defines the number of seconds for which a looked up inode
or a stat()'ed structure is valid in the cache.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 711ef3e49aaf76c284a9e9e9d9a810aaa34bf711
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed Jun 3 01:31:37 2009 +0000
libglusterfsclient: Simplify inode and stat caching
There is a mechanism for caching the inode numbers got from a lookup
and a struct stat got from a stat or fstat but I wasnt sure if it worked.
This commit simplifies cache updates and checks and the accompanying
tests have made sure that the cache does work.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 828c7381a9b6a3fc62eb2f7ba915bd982150fee4
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu May 28 04:42:37 2009 +0000
libglusterfsclient: Allocate right sized structure
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f155cfd7756c5c83040f82388e0d128fe0bae31a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Sun May 24 23:05:26 2009 +0000
booster: Clean-up handling of log/fstab env variables
Handle two cases when deciding log/fstab file:
1. It turns out that that strdup or strlen doesnt actually
check for NULL before trying to do its thing with the string
so it seg-faults on seeing a NULL char pointer.
2. getenv can return an empty string if the
env var was exported as:
$ export GLUSTEFS_BOOSTER_LOG=
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 2a9a6508a147542a85001bf47826e4414058018a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Sun May 24 23:05:18 2009 +0000
booster: Eliminate gluster context creation race
When multiple threads try to create a glusterfs context using the
glusterfs_init function, those threads end up using the global
vairables in the vol file parser in an non-synchronized manner,
resulting in a seg-fault.
There is now a big lock around searches and additions from the mount
table in do_open. This lock granularity could be reduced.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 8656b481664e20f204a5bcb7e1a2867733b21a43
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Sun May 24 23:05:11 2009 +0000
booster: Clear up env var usage
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit eb8f7d308cce16134f929454617a4f670d67f716
Author: Amar Tumballi <amar@gluster.com>
Date: Thu May 28 20:12:05 2009 +0000
bug fix in dht-diskusage when statvfs->f_blocks is 0
This can happen when 'option export-statfs-size off' is given in
posix volume. Caused divide by 0 error.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit fc831621466a525a889f6b71fea87255316fc8eb
Author: Harshavardhana <harsha@zresearch.com>
Date: Thu May 28 02:46:45 2009 +0000
Remove absolute path for init scripts.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 52d39ec04e6d0e1f70947469c7cd711f990b0768
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 26 09:02:29 2009 +0000
socket: New option: Set receive and send buffer size
..and hope for a chance to improve performance on
high speed links like 10GigE.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 32652fe826d2d09d38b3f7dad4710761faa0284a
Author: Pavan Sondur <pavan@gluster.com>
Date: Wed May 27 10:39:38 2009 +0000
Fix mismatch in size of used buffer to prevent an infinite loop
A mismatch in the size of the used buffer, between reading and then further writing caused an infinite loop and big files(1Mb, 10Mb etc) could not be downloaded through the lighttpd web service using mod_glusterfs. This is because the big file which is broken up into chunks, has a read and a subsequent write.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 62d760f8e1163c674b6b4e749ac186eeee6042b8
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue May 26 05:02:27 2009 +0000
Do itransform in AFR readdir.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 23fb4da5db002124d171012361f7e8f0916eec6e
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue May 26 05:01:35 2009 +0000
Always do itransform of the inode number from the first up child.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 98d81e56eb0166e518b7025dabbc78af19f8da5b
Author: Anand Avati <avati@gluster.com>
Date: Tue May 26 04:31:28 2009 +0000
add booster_fstab.h in noinst_HEADERS to fix build breakage after 'make dist'
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit d812afac630ea6eaf549fd8aa533b7934082256c
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon May 25 05:02:25 2009 +0000
Preserve atime/mtime during data self heal.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 568f6248cc33e3fba27a08250b5faefe16d4489e
Author: Anand Avati <avati@gluster.com>
Date: Fri May 22 03:33:41 2009 +0000
fix crash in __socket_reset. Previously iobuf_p was an allocated pointer, but since introduction of IObuf it is no more. Now iobuf has to be unref'ed instead.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 1c0706902c166d26881dc3b755d4f335d089d900
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:32 2009 +0000
THIS: use xlator_init() for initializing xlators
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 9e2a5b340faf422964e707a0e43dafd50191928e
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:31 2009 +0000
THIS: add xlator_init() API to set @THIS
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 4960a882ee57f9eefcc9ada63eaef40d03dee1de
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:30 2009 +0000
THIS: bootstrap @THIS in fuse thread
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit dbec8297193d9a0b5250a94ef51a61b56a45f856
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:29 2009 +0000
THIS: unify now uses xlator_notify for setting THIS
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit ca42e03b423d94a42e8d909acc65d585af0b8570
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:28 2009 +0000
THIS: protocol/client now uses xlator_notify for setting THIS
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit ba23f09f4b12908a6adb28eb405d88eedf2d577d
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:27 2009 +0000
THIS: ib-verbs now uses xlator_notify for setting THIS
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 6d16b65957395fcd9982cd8baed515c9fdfa71e2
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:26 2009 +0000
THIS: socket now uses xlator_notify for setting THIS
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 7735e5d5d84507e30d44709aeced00f1a697e360
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:25 2009 +0000
THIS: default_notify to use xlator_notify for THIS compatibility
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f2ff3f1a3ee726121d87afd0b2daccf03cad9cfb
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:24 2009 +0000
THIS: xlator_notify API to be used for propagating notifications with proper THIS setting
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 9fafa51c56217742ab3c725dc3ad8e8dfb2ad965
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:23 2009 +0000
THIS: set appropriately in call stub resumes
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit cc8313a65dc8a7ba82d1a0562c57121c479384b8
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:22 2009 +0000
THIS: set appropriately in STACK_* macros
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 12c7622b15cd272af61515adccdb37817b908353
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri May 22 02:10:21 2009 +0000
globals: add globals.h/c THIS: macro to access thread specific current xlator CTX: macro to access glusterfs global context (glusterfs_ctx_t)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 02a9c464ddbc0e8d8f9c30f3838453423ccd6101
Author: Harshavardhana <harsha@zresearch.com>
Date: Thu May 21 02:20:26 2009 +0000
Check for returns when apxs fails and disable mod_glusterfs
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 452aefc0f8fb19fc733e4e0052c528fb41f350bf
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Thu May 21 01:37:05 2009 +0000
mem-pool,io-threads: Destroy mem-pool on deallocation
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 003c3a4ef3640ea949c85fb8893ba33a147af482
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Wed May 20 22:50:10 2009 +0000
booster: Move fstab parsing into booster from libglusterfs
This is another attempt at fixing build problems on Solaris.
I am told that booster build is disabled on Solaris and I know
that it is disabled on Mac OS X also. Getting it to work
on both these systems is now on my TODO list, mainly
because on both these systems, we can have a glusterfs client
running without requiring FUSE.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b2403dd1474949bd925dc256cb12b53165425d45
Author: Csaba Henk <csaba@zresearch.com>
Date: Tue Apr 28 10:22:03 2009 +0000
add xlator debug/io-stats
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 5ac424ba29e7589674d26fb1bc572b00eea59bd4
Author: Amar Tumballi <amar@gluster.com>
Date: Wed May 20 13:36:01 2009 +0000
add 'non-blocking-io' to the options array in sockets.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit a4492167fc7000f0c2103a53f0b851e081f23a63
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 12:42:31 2009 +0000
io-threads: Use boolean enums instead of integer 1
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 924299747697f4017a2cb39a2344ddb90fbc5212
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 12:42:22 2009 +0000
io-threads: Change mutexes/condvars to spinlocks/semaphores
It seems that use of mutexes is resulting in pretty high thread
sleep and wake-up cost. What is worse, if a worker thread has
acquired a lock, there is a possibility of the main glusterfs thread
being put to sleep. We change the use of mutexes into spinlock.
At the same time, we cannot anymore use condvars for notification since
the condvar interface depends on mutexes itself. Semaphores come to
out rescue. Luckily, even the pthread semaphores have a timedwait
interface to allow our idle worker threads to make an exit decision.
Further, it is possible that spinlocks are not available on all systems
so all this is curtained behind #defines so we can fall back to
mutexes and condvars implementation.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit f08af345bbbfd41bdebfffc482515760486fded6
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 12:42:14 2009 +0000
io-threads: Reduce default max for threads to 64
We've had complaints from users who've used
autoscaling option with default settings for min and
max threads, about high memory consumption because of
the large default value for max-threads.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit b959cbaf7637f5e508e33d492e7bcff06819452a
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 12:42:06 2009 +0000
io-threads: Support mem-pool allocator for iot_request_t
This commit brings in support for allocation of iot_request_t's
in io-threads through the use of the mem-pool. We're hoping
that the overheads of hundreds and thousands of small allocations
can be avoided through this.
The important point to note is that the memory pool is not
for the translator as a whole but there is one small memory
pool for each worker thread. Not only does that help us
avoid malloc overheads for small allocations like iot_request_t
but also avoid contention on the heap data structures when multiple
threads want an iot_request_t from the pool.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 6e2241d18b7edc600e079134ce4b15744d964f3e
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Fri May 15 05:50:09 2009 +0000
io-threads: Add graceful shutdown of worker threads
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 85e1eb189d4731cc93f9361611a6183eab6a49c7
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu May 7 00:51:39 2009 +0000
io-threads: handle memory allocation failures
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 0ae98b8954b838ec10dbab13d9acdc999fcf1e4b
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon May 18 08:19:10 2009 +0000
Change errno to EAGAIN in readv/writev
When mandatory locks are enabled and a read/write
would block due to a lock and if the fd is opened
with O_NONBLOCK, return EAGAIN (previously EWOULDBLOCK).
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6c29e21af52899e7bb445c311848e2da470a62d8
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 04:34:11 2009 +0000
mem-pool: Restructure mem-pool behaviour
This commit changes mem-pool behaviour to return a directly usable
address by performing the required adjustment on the address
being returned.
This is different from the previous behaviour where we're trying to fit
into the requested size, the list_head*2 also. This is not efficient
enough in terms of space but hopefully works better than not having any
mem-pool at all. Besides, I am not comfortable with mem-pool meta-data
and caller-useable memory area being the same because of the potential for
mem-pool's data structure corruption.
PS:
Please do read the comments in the code for more info during review.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d38c51ec8e7a2a7f3265018a278ac893823ff403
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 04:33:58 2009 +0000
mem-pool: Fix #define spelling
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1bbcdf6225029a6f9ca5f7d38703e46eb2ee046b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 04:33:48 2009 +0000
mem-pool: Remove hard coded value for pad boundary
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b19cd95331caf9c3d35ab0f94e481ac0bb8e40b5
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 04:33:37 2009 +0000
mem-pool: Fix memory leak in mem-pool init phase
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 51af6a001385de8443630116dab8a086bc246bec
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 17:57:02 2009 +0530
booster: Fall back to remaining real_* functors
It is possible that some of the real_* functors for stat
family of syscalls are NULL. I've seen this on libc. In that
case, this commit attempts to use any available function that
performs an equivalent operation.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9949d5e80f0b8a2a1bf434e407976cd04b1f180f
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 17:56:54 2009 +0530
booster: Dont de-init fd tables on VMP-init failure
In case the init procedure for VMP fails, we want to
continue using booster through the old approach, which means
leaving the fd-table intact.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f5b93c507aae0ab935c5ef3078a3584b9c5dca4b
Author: Shehjar Tikoo <shehjart@gluster.com>
Date: Tue May 19 17:56:47 2009 +0530
booster: Do not read info for non-glusterfs mount points
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 616e0046135ea370515ddac25080c6da6e8aff21
Author: Harshavardhana Ranganath <harsha@dev.gluster.com>
Date: Tue May 19 06:39:42 2009 -0700
Appropriate changes to statvfs struct for Solaris host.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit cf4b013764bc7429af321ef740df731208838548
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:24:43 2009 +0530
libglusterfsclient: Comply with EEXIST rule on rename
During a rename, if the new file exists, the old name needs to
over-write the new name. We're returning EEXIST, which is wrong
behaviour.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0bde66198dc55ee249bfd121f2d663880278ed69
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:24:34 2009 +0530
libglusterfsclient: __do_path_resolve: Fix pathname resolution bug
In __do_path_resolve, we need to use the new_loc.path as the input
for resolution rather than the resolved variable, simply because we're
not interested in resolving the names that have been resolved, as
pointed out by the variable name 'resolved'. Instead, we need to resolve
new_loc, which stores the next component in the path to
be looked up.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 14e0c60b3db11429553ac8cf133a97c12c79589d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:24:21 2009 +0530
libglusterfsclient: Wipe loc->ino in libgf_client_loc_wipe
Not cleaning up the ino member of a loc_t results in SIGABRT
in __inode_link because in some cases, the loc->ino is
different from loc->inode->ino. This happens especially in code
blocks which re-use a loc_t structure for pointing at different
inodes/files. For eg, if a loc_t has been assigned an inode and
an ino, and followed by a libgf_client_loc_wipe, then re-use of this
loc in say libgf_client_lookup results the SIGABRT because
libgf_client_lookup calls inode_link with the same loc_t. However,
this loc_t has just been assigned a new inode pointer but the ino
member still contains a previous inode's inode number. This difference
in inode numbers results in an assertion failure, so the SIGABRT.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a4db264fc651a5b283cddabdd410ce9ca69be253
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:24:08 2009 +0530
booster: Add telldir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2f880c97cb0253e52b38c0d91c90764a82242c41
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:23:58 2009 +0530
booster: Add seekdir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 65cbc56712e564fb9fc34b98067ac8c5b52941f5
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:23:38 2009 +0530
booster: Add rewinddir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5e3adf637aedcddca7b7d87fd7bd33cd545973e0
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:23:24 2009 +0530
libglusterfsclient: Refine readdir entry parsing logic
Here I am only refining the entry parsing code in order
to clarify the exit conditions from the loop. There were
a few workloads where this loop went infinite.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9c59777bcb26f440c18f99b9ff6dc6d9e156f691
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:23:14 2009 +0530
libglusterfsclient: Add telldir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 598e4a0dd6ea09d3a49931b08e6265b0274c9e28
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:22:57 2009 +0530
libglusterfsclient: Add seekdir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6417ca0c564fba2aa22b248dc9205fbc95998dc2
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:22:42 2009 +0530
libglusterfsclient: Add rewinddir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 48d8bd8edfcb452ea2950246a6d8c9395404908e
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:22:29 2009 +0530
libglusterfsclient: Revert and re-do readdir conformance
This commit basically reverts the previous readdir conformance
patch I sent a few days back. That commit had a completely retarded
and broken way of maintaining per-directory dirent.
It was broken for two reasons:
1. Creating a wrapper structure around the directory's fd_t
only for storing a struct dirent is not clean enough. This commit
takes a better approach by storing the dirent in fd_t context.
This dirent is valid only if the fd_t refers to a directory.
2. That commit was made and tested under the assumption (..stupidity
is a better word..) that only opendir call is used for opening a
directory. That is not correct. Directories are also opened using the
open syscall. The point is, glusterfs_open returns an fd_t and so did
glusterfs_opendir. The previous patch actually changed opendir to
return a new wrapper structure. That is fine, if we go by the POSIX
definition of open and opendir because, they're both supposed to
return different types, an int and a DIR*. However, in
libglusterfsclient, all other code assumes that directory handles
corresponding to DIR* and file descriptors corresponding to int types
are the same type, resulting in use of the same locking and fd context
addition/extraction code. So a directory opened using opendir returned
a wrapper structure which went down into the libglusterfsclient stack
where some function called a lock on the handle assuming it was an
fd_t, since it is not and dereferencing of the supposed fd->inode->lock
results in a seg fault.
Obviously, this didnt show up till unfs3 used open() to open a
directory and not opendir.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7e8cd4a452be85fe8bddae3d383ed01975129db9
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 18:22:19 2009 +0530
booster: Supplement fstab option parsing
Previous fstab option parsing logic was completely
retarded and did not handle all cases. This fixes the situation
so we now work without any problems.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 17ac6225460a5c4e7d290f46b774341b2c9a5fdf
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Mon May 18 17:24:16 2009 +0530
workaround for not including sys/cdefs.h -- including sys/cdefs.h breaks build on solaris and other platforms
commit 5cbde3c30f1d49c19ec98f6f70b46c8a07088356
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon May 18 03:02:54 2009 -0700
Bug fix in pl_readv/writev to handle the mandatory lock case properly.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9077a9e12d9c0949c318aa6d718b1eb12970cbbc
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Fri May 15 03:56:22 2009 -0700
client-protocol: Fix memory corruption in client_lookup
- memory corruption was due to new members being added between allocation
of buffer for serializing xattr_req dictionary and dict_serialize of
xattr_req.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2579fb705e15933acb845ef8ee63d126cd7edbb0
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Fri May 15 03:55:50 2009 -0700
dict.c: make dict_serialized_length and dict_serialize to hold locks.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9c85d7e28b4463e96c656afffb1a8b4a2545b6bf
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Fri May 15 03:55:20 2009 -0700
dict.c: Add dict_allocate_and_serialize
- this procedure atomically allocates a buffer and serializes dict into it.
- this procedure helps avoid memory corruptions due to race conditions where
in new members are added into dict between allocating a buffer for
serializing and actually serializing buffer into it.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 80c46b407c95945872f30bea10bc3934c251d07b
Author: Csaba Henk <csaba@gluster.com>
Date: Sat May 16 04:28:40 2009 +0200
make getxattr fail with ERANGE if reply is bigger than what was requested
Edited by avati: make the function signature of fuse_xattr_reply_buf() use 'const char *value' instead of 'char *value'
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a52bbd4d6a51bdfec6f45f6ea5c134831a3890fa
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu May 14 00:21:02 2009 -0700
apache/2.2/mod_glusterfs: port to use new glusterfs_readdir interface.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 909c3de77f29f88563a1c3013bf814e11cad98ac
Author: Amar Tumballi <amar@del.gluster.com>
Date: Wed May 13 12:46:29 2009 -0700
avoid duplicate mounts while using mount.glusterfs
This change is needed as the format of how the /etc/mtab entry of glusterfs
mount looks is now changed.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 59dbd193fa2fc3ef3c1fd3cd8b112e6fb7d51b01
Author: Harshavardhana <harsha@zresearch.com>
Date: Fri May 15 02:39:15 2009 -0700
modified init scripts to honour @prefix@
fixes http://savannah.nongnu.org/bugs/?26581
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 41335bbfcbe5d56f515aac4dec4595038fe4bc07
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu May 14 02:12:20 2009 -0700
Edited log message for --volfile-check
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 690c0dc7c5079548329db0abff25dbaa728d6598
Author: Amar Tumballi <amar@del.gluster.com>
Date: Wed May 13 01:26:24 2009 -0700
minor log enhancement in 'ib-verbs' transport.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit fb185e550429946d01deb92b4cfe7eff34accd1a
Author: Amar Tumballi <amar@del.gluster.com>
Date: Mon May 11 13:19:49 2009 -0700
replace BIG_FUSE_CHANNEL_SIZE with 'this->ctx->page_size'
Send the struct stat's 'blksize' variable same as GlusterFS's page-size,
instead of BIG_FUSE_CHANNEL_SIZE.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 740668c216d6bea57daf9491edb0374266a0086b
Author: Amar Tumballi <amar@del.gluster.com>
Date: Fri May 8 01:33:02 2009 -0700
default log file different per mount (or if server, per volumefile)
This feature is required becuase when more than one glusterfs process
is started with default log file, all logs will be going to same file,
which after a while gets more confusing.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit abce8b28708400f5a5ca89fc888d9502b8f88b80
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon May 11 11:25:40 2009 +0530
posix: Fix build warning on incorrect type
This fixes a build warning due to use of incorrect
type for size_t, for Core 2 Duo.
Extra fix from avati: change %ld to GF_PRI_SIZET
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 074827c5fd6b84869e4062951d4b8d6864c209d3
Author: Amar Tumballi <amar@del.gluster.com>
Date: Thu May 7 17:21:21 2009 -0700
stripe init 'block-size' pattern parsing bug fixed.
ref: http://savannah.nongnu.org/bugs/?26416
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit cce08ec42bda250b92014e86076884c4535d2fe4
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu May 7 04:16:28 2009 -0700
scheduler-nufa: fix initialization of refresh-interval
- refresh-interval was being reported as not provided in the options
even when configured.
- fixes bug reported in rt #1007
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e5de833c4413e0c035abc4ce9e6200a545f408d9
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu May 7 05:05:03 2009 -0700
Set op_errno properly in afr_flush.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 584e6da02100b49441a716ee1ac552ef8d250004
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Fri May 8 15:45:24 2009 +0530
booster: Add fstab parsing support
This commit changes the booster.conf format from a
simple custom format to that of the /etc/fstab.c
See booster_mount(..) for the mount options supported/required
for LD_PRELOADing booster. I'll write a small help doc soon.
This commit also brings in fstab parsing code into libglusterfs
because Darwin libc only supports reading the hardcoded /etc/fstab.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b50fd03e84d3bad20256df4692c84d36105a61dd
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Fri May 8 15:45:09 2009 +0530
booster: Standardize conf file and env variable
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 47fdae9a6dbef24feca14c221a9f72acad3267cd
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu May 7 15:02:09 2009 +0530
backend-xattr-sanitize.sh: script added to extras/
Run the script as:
sh$ ./backend-xattr-sanitize.sh /data/export0
and it will remove all the known stale xattrs on the backend files and dirs
commit b467d4e5a772198009666d8939f4e8e8d892dc9c
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu May 7 13:28:21 2009 +0530
valid_host_name(): accept string lengths upto 75 chars (the limit accepted by glibc resolver)
commit e279719bda801bad24247f4a2bb289c08edf6619
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed May 6 05:40:15 2009 -0700
symlink-cache: fix return value of readlink
- sc_readlink wrongly returned strlen (link) + 1 when link was present in
cache.
- this fixes rt #828. Since fuse_readlink_cbk does link[op_ret] = '\0', there
was a memory corruption.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6e9ac0682d4916089bb8b97848dc410030c286fd
Author: Amar Tumballi <amar@gluster.com>
Date: Wed May 6 08:59:21 2009 -0700
fix in mount.glusterfs for proper direct io mode option.
fixes the bug which causes GlusterFS not to have valid 'direct-io'
option through mount command or /etc/fstab entries.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e662cec8dd383754e053e63bf6e143bebbb44223
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu May 7 11:59:23 2009 +0530
protocol/client: indentation fixes
commit 8cafdaa20df74ad14df85d559a47f6787ac56dda
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu May 7 11:06:34 2009 +0530
protocol/client: removed conf->child
commit 3892789c2b19e009a946d312c35088d00226828c
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu May 7 01:24:41 2009 +0530
transport shortcut b/w client and server
This patch makes the server pass back the transport pointer of the client. If the UUID matches, the client makes the local transport 'shortcut' with the remote transport (pointer received from server)
The shortcut simulates a socket queue. Instead of serialized messages going over the network and getting queued in the tcp socket queue, the messages get queued in a transport specific queue picked by a polling thread.
commit 4ffc39043b85adcef1981b9e1ec1600d3c00d33e
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed May 6 14:40:45 2009 +0530
fix log message from transport-timeout to frame-timeout
commit b9635d4d13e0ccc8bdce72bf378597b2e4ace24d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed May 6 12:23:54 2009 +0530
libglusterfsclient: Improve readdir conformance on re-entrancy
readdir is supposed to be non-re-entrant only with respect to the
given dir stream, not the whole process.
What that means is the static struct dirent that we maintain in
libglusterfsclient should be per-directory handle and not
process-wide.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 756c8e0696cfa98760bd754dacc13d9b8239a637
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed May 6 12:23:14 2009 +0530
libglusterfsclient: Fix large directory reading bug
As of now, we use 1024 bytes as the buffer for reading directory
entries. If a directory as many files, then its possible that it does
not fit into this buffer, thereby requiring more than one call to
readdir. Now suppose the last bunch of directories fit more or less
exactly int the 1024 byte buffer. If this happens, the offset
extracted by the current logic(in libgf_client_readdir) never gets
updated beyond the first entry in this last block, because the last
block's first entry always remains same. This explanation is
convoluted, I know, but I too found out the hard way.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 32fc49a03b64147f97622d6d8cc78b14c67b3565
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 20:45:48 2009 +0530
booster: Use CONFDIR as booster.conf default location
This commit changes the default location of the booster.conf
file from /etc/booster.conf to a directory defined
during the build process.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit bc34763bb23b3ac771921dbf888520396d18477e
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 20:45:26 2009 +0530
booster: Change booster conf env var name
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 271f06173f1a78f5b7eefe852928d0674b12c2c0
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed May 6 11:43:33 2009 +0530
afr self-heal: update file size of the returning stat buf with source file's size
commit 103ac231da112b9ce3badfd36ef159d1774c71ae
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue May 5 20:04:50 2009 +0530
log level fixes in read-ahead
commit 816d89081efd784ec27ba0e4d0654e8531963970
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue May 5 20:03:36 2009 +0530
log level fix in storage/posix
commit b2caf03ffebb34edbab4f37b9fa9e291c53fb0d7
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue May 5 19:19:30 2009 +0530
io-cache logging level fixes
commit d6c81bc0825e454d40b4fd536cebd1b39bb7cbed
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:04:57 2009 +0530
libglusterfsclient: Add 0-byte size/count guards
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 53dfc9a9ccd8e58e20255d88851c65c0fc309363
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:04:50 2009 +0530
booster: Add lchown API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3fb52a73cd087b87edf9fdfa7168c8a410fea814
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:04:43 2009 +0530
booster: Add remove API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8290258412a02dbe3e2aa2031f74e41cbc54eba4
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:04:37 2009 +0530
booster: Add getxattr,lgetxattr API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 657f83a6694944b0e4b3f2dbd1773e7a22f19a5e
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:04:29 2009 +0530
booster: Add readdir64 API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 50c5404e9cdd3c2140cddbacaaa5557a3988c8f9
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:04:23 2009 +0530
booster: Add statvfs API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit bcc215b301f498a3179dc8cd75328fdaa4fdd5c2
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:04:15 2009 +0530
booster: Add statfs API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 794d33fc829b1f030af6c74f10a3b02c6a94c512
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:04:08 2009 +0530
booster: Add lstat API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7369bffefb6ea13bc2e2e127beeff5c524ee57e9
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:04:00 2009 +0530
booster: Add fstat API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a2b563c32b27399784b4467cfecb596fc4546f6f
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:03:52 2009 +0530
booster: Add stat API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2a89f6bc38d0a365d9a3e1b2774178cd799f9748
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:03:42 2009 +0530
booster: Add closedir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b1735ad3bab8d79d6b616bd2789f98637bad9ade
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:03:32 2009 +0530
booster: Add readdir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b43446f4d7628c5abe642a48365f8c979e817f11
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:03:24 2009 +0530
booster: Add opendir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e0a6edb2004fdfd05d929fe945a7ed8799745815
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:03:16 2009 +0530
booster: Add realpath API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c7737b8b5df391235e3fbd15098e5ec7ca6cb571
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:03:09 2009 +0530
booster: Add readlink API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d45e17c8f01715aa120b04a3c913a6d179ec3dae
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:03:02 2009 +0530
booster: Add symlink API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 30bb3afb9620ce3e74174bcf1817bbd9a17fdd3c
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:02:55 2009 +0530
booster: Add unlink API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0dc16199870a6f0749f4792b990b52a42e090290
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:02:48 2009 +0530
booster: Add mkfifo API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit fd321cf9d61270e8d88e66a19b086ac507ad3304
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:02:38 2009 +0530
booster: Add mknod API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9ca11fe85e3f360beeb92787885c45cccc032da0
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:02:31 2009 +0530
booster: Add utime API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8d9d1e57bf8713a031854d51a3f6da17515384ca
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:02:24 2009 +0530
booster: Add utimes API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e626118d0d2f6ed9bba81df1f2e7f94785996c10
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:02:17 2009 +0530
booster: Add rename API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 976bae26d405625de3837fe8cfd2f15519c41c32
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:02:10 2009 +0530
booster: Add link API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d06348c618a099b7cdb1d91c3f9f90a3c4432f8f
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:02:02 2009 +0530
booster: Add ftruncate API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7604a04f97ae4946e29f88e17176d18e30fc392d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:01:54 2009 +0530
booster: Add fsync API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit fe392579c7c8bec2f99b5d75472204cdadc8c712
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:01:47 2009 +0530
booster: Add fchown API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit af8c968fb30c464db8dd3eea6b87846283f9e412
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:01:40 2009 +0530
booster: Add fchmod API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f4346faabeb36b0ef5d405a7a4d0c46140d29eb3
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:01:32 2009 +0530
booster: Add chown API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d5ff34db534c6c2b2dd0d7312f1ecc50491f8e81
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:01:24 2009 +0530
booster: Add chmod API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c9d35265d00f5ce7a39289860d0fd09075b4a1d0
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:01:16 2009 +0530
booster: Add rmdir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit cfca16ded333624099ef1f965608139b231034f1
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:01:09 2009 +0530
booster: Add mkdir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b6ee89d10ce6a8148b4bd9bf0d41b6240d7bfc31
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:01:02 2009 +0530
booster: Add log message
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 04322bb95d5c076c891f113ce32ee4993cf23f64
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:00:56 2009 +0530
booster: Clean-up pwrite64
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d180b615b6acdbcaf32fd6eceb286c3d64e6d930
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:00:49 2009 +0530
booster: Clean-up pwrite
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3df1cdcca1cafe7a88e095b12b6e1f722f76c094
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:00:41 2009 +0530
booster: Clean-up lseek64
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 30313c3bd29413abbc66003c74dc05d7984f93f2
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:00:34 2009 +0530
booster: Clean-up lseek
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3a227dd399ce0371835db02b79130c362c89ff1f
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:00:27 2009 +0530
booster: Clean-up write
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 90b09310fb6fbc861d7095ebdebadd12fdab56de
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:00:20 2009 +0530
booster: Clean-up writev
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 26e83ba1252ffd6ce3e700e50ada35139f675f4d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:00:12 2009 +0530
booster: Clean-up pread64
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0ca4f9e9e2ef72fa96b897584d2b63149b677998
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 16:00:04 2009 +0530
booster: Clean-up pread
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0b95d90f448ba5656b91abc25e14240dd9eddf20
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:59:55 2009 +0530
booster: Clean-up readv
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5763530184a816ecf8d495b82f9b03bca640735b
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:59:47 2009 +0530
booster: Clean up read
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ed2f359e1bed18925ce90fecbc91daf369146660
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:59:40 2009 +0530
booster: Support VMP-based creat
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e1bf04f637b14096817dc60180c5045ecf0bc251
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:59:32 2009 +0530
booster: Add VMP-based open support
In brief, when an open is called the VMP-based open is called first.
If that fails, the fallback is the Mount-Point Bypass(MBP) technique
which uses entended attributes to determine if the given
path is a gluster mount. If it is, it goes ahead to create a
glusterfsclient handle. All subsequent calls to this real mount point
get redirected to the glusterfsclient handle. The other fallback is
the actual open syscall on the local file system itself. This happens
when the absence of an extended attribute tells us that the path is
not even a glusterfs mount point.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3811b273c382c61dd1f22e366a8eb71cef8c269c
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:59:25 2009 +0530
booster: Remove fcntl.h from include path
We define the O_CREAT, etc. flags so that we can remove fcntl.h from the
include path. fcntl.h has certain defines and other lines of
code that redirect application's open and open64 calls to the
syscalls defined by libc.
For us, thats not a Good Thing (TM).
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit dba59c3f7f6a7c95146e4c63bb46529b58f4dd06
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:59:18 2009 +0530
booster: Integrate VMP-based mounting
This commit brings into booster the use of VMP based operations
which will allow users of booster to specifiy a VMP and use it
for transparently operating on a glusterfs client context.
Since applications are oblivious to booster's presence, because it is
LD_PRELOAD'ed, we need to specify the VMPs and the corresponding
options like volfile, logfile, loglevel, through a conf file.
By default, this conf file is the /etc/booster.conf. This can be
over-ridden through the GLFS_BOOSTER_CONF environment variable
for the application.
The format of the conf file is very simple for now. Each VMP is
described on a single line with space separated fields.
Format: <Virtual Mount Point> <volfile-path> <log-file> <log-level>
<log-level> takes the string representation of the usual glusterfs
log levels.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 269d4d7a7e4453d3fcf4a235ace5c257e222bfbd
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:59:11 2009 +0530
libglusterfsclient: A Fix deadlock in ftruncate
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit cdabbbd2e23b3eef2adf8390eb90f10f1cad63c8
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:59:03 2009 +0530
libglusterfsclient: Conform'ify glusterfs_readdir
This commit does two things:
1. Changes glusterfs_readdir prototype to conform to the POSIX
readdir().
2. Uses a 1024-byte value instead of sizeof(struct dirent) for the
@size for libgf_client_readdir. This allows even larger names to fit
into a single readdir request to the server.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ff4ab9654acc6c0b4f53bcf77009c2c499a2758c
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:58:56 2009 +0530
libglusterfsclient: Add VMP-based lchown
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2f7b75bc9edca05261bdc9342ccce0b7c1be57d2
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:58:48 2009 +0530
libglusterfsclient: Add remove API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3a76453a72f82f6025cf33ba52acd6e0fa9c60d4
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:58:38 2009 +0530
libglusterfsclient: Add lightweight path resolution
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 4c4046f50e6116f54c7ad0d47c63e4ec804d3277
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:58:30 2009 +0530
libglusterfsclient: Add lgetxattr API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a770a4a13066423b00440ef19f78d52deb798be7
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:58:23 2009 +0530
libglusterfsclient: Add setxattr,lsetxattr API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c4638054705bc2d38576a63671ddb3377da4302a
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:58:16 2009 +0530
libglusterfsclient: Make stat resolve all symlinks
We want to resolve even nested symlinks when calling stat,
therefore, we need to depend on realpath-like functionality
and not just a readlink.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0b2218f4d4a13632a9410a99bcabb1a344f44653
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:58:09 2009 +0530
libglusterfsclient: Fix realpath operation
This commit does two things:
1. Ensures we go on to traverse nested symlinks by calling realpath
recursively on the symlink.
2. Makes glusterfs_realpath, a VMP-based operation, return a resolved
/real path that actually has the VMP pre-fixed to the resolved path.
If this is not done, we'll be returning a path that is valid only
within the glusterfs context, i.e. the path will point to a real
file/dir only if a glusterfs handle identifies which glusterfs context
the file is in.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ba9ab94bbb5e46ca20491d93355b829f23c362e8
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:58:03 2009 +0530
libglusterfsclient: Dont lookup oldpath on symlink
The target of the symlink does not have to be interpreted in
any way. It should be sent across as it is.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 392042e4e76d847f0260cc0533c24c7dd99b5228
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:57:56 2009 +0530
libglusterfsclient: Improve path matching heuristic
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d1a53c1987a2c44a4ac577e434408f8e97b5ced2
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:57:49 2009 +0530
libglusterfsclient: Guard against un-inited VMP searches
On my system, an selinux module gets inited before
booster even though the FS calls from the selinux module
get routed through our LD_PRELOAD'ed wrappers. In this
scenario, the VMP list is un-inited, resulting in a seg-fault
if it is dereferenced. The list_empty check does not help
because the pointers in the list have non-NULL values.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b1cdbc35f70997cd8ba2e7693a48d9116b1c9459
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:57:42 2009 +0530
libglusterfsclient: Add comments to API
Some of the functions have also been moved within
the header to reflect the order in which users will
read through and try to understand how to use the lib.
For eg. the init, mount and umount functions have been moved to
the beginning to clarify how to start by init and de-initing.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 4e8dbbb2df92b82789d7d8c1c60f0d9d77f961fc
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:57:34 2009 +0530
libglusterfsclient: Expose a few remaining APIs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a214a6451d05e57c40dd691648be08697879c0d9
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue May 5 15:57:27 2009 +0530
libglusterfsclient: Add VMP-based rename
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5e951e90c0a6f982ee761f809d015843de0dcc21
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon May 4 10:59:18 2009 -0700
Do not lock entire file for metadata operations.
Metadata operations now lock only a single byte at offset
(LLONG_MAX - 1) instead of the whole file, to avoid contention
with writev().
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 46756f0e88d6d487454dc8f2e8a02b11eb4da845
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon May 4 10:50:48 2009 -0700
Made afr_flush a 'quick-unwind' transaction.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 67c258e25093825f162a7f469c2c850d555e0b85
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Sat May 2 14:37:04 2009 +0530
io-threads: Clarify thread count range
This patch cleans up io-threads behaviour regarding the
range values that can be specified for min-threads
and max-threads. THe major change is that the min threads
have been reduced to 2 to signify that io-threads needs minimum
two threads for its operation, while keeping the default number of
threads at 16. The idea is to decouple the default thread count
from the minimum thread count.
Note to Avati:
This applies over Raghu's indentation and logging take-3 patch.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 775f969b12b9cd80c031fdf5bbb138f46e6685e8
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon May 4 10:33:11 2009 -0700
io-cache: indentation and logging fixes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9ab98ca9073d2cbba0fab568a6ac84bb3874a1e3
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Apr 30 07:09:42 2009 -0700
io-threads: indentation and logging fixes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 854b4e9571b4a1e331dc5acc307eab3319329678
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Apr 30 10:42:14 2009 -0700
Cleaned up log messages in storage/posix.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6e4ffa37ff9c87e962b36c3dd412b2fa4cc2e2ce
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 29 05:23:17 2009 -0700
write-behind: indentation and logging fixes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0b2f21ef43ff00923353b9a4ad04731cf8ff0c1c
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 29 04:21:59 2009 -0700
read-ahead: indentation and logging fixes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c03898647c8e6ee8ae6a9b5512076ddd455b0758
Author: Harshavardhana <harsha@zresearch.com>
Date: Fri Apr 24 05:47:39 2009 -0700
Fix a conditional during dependency check
Conditional was wrong and dependency check would fail.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 698c72e6bd54479ba6cfe513110fd31995570bf3
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Apr 29 08:51:41 2009 -0700
bug fix in server protocol segfault when the volume file key is NULL
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e3462fa8d78c2b4aa48a19eb20e1ae2ff65e5574
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Apr 29 03:23:55 2009 -0700
Cleaned up log messages in features/locks.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0c66b2df940b7e1bbadfb97a9b24e557d65e4d7a
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Wed Apr 29 02:16:51 2009 +0530
cluster/unify - unify_forget() should not try to access inode->ctx, if inode->st_mode is not set.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit df5a1a691da19e0440200ec1f904c27d7f0d1db6
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Sun Apr 26 22:51:18 2009 -0700
mod_glusterfs/apache/2.2: fix segmentation fault
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1540f1cb02ee13ad06dea60db0d37286384bb1a4
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Sun Apr 26 21:36:33 2009 -0700
memory leak fix in auth/login.c
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c20305a0ef41b215b7631844efadf4702bd04680
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 28 19:29:50 2009 +0530
protocol/server indentation fixes
commit 5195d7e1bb9ab08db5a1b2ebc7e1dab1d356ce96
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 28 16:02:22 2009 +0530
protocol/server log level fixes
commit a323a1aea9711a768b50e092efc5a03b79301545
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 28 15:11:21 2009 +0530
protocol client log cleanup
commit ca73ca4511835e8330aeb95ecf0aec3ab711dd75
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 28 15:11:05 2009 +0530
fuse-bridge log cleanup
commit f18c4504681d7913fb6ab331125dce54d719fe21
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 28 15:10:38 2009 +0530
socket transport logging cleanup
commit ffbf124fda0bb01e12cf6722b0ef38a9179c3d97
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 28 15:10:16 2009 +0530
dht logging cleanup
commit 5bfedcc40e00f76bdf8ff9a76b8cee39e2c26e57
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 28 15:09:57 2009 +0530
afr logging cleanup
commit 2627403b98c5d26214680dc4ed5e6d7a2af3ab82
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 28 15:09:22 2009 +0530
libglusterfs log cleanup
commit 750b61af5e530499665bcb6081ba259004bf4b76
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 21 19:39:24 2009 +0530
log message cleanup in distribute
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 82b15ed20e6a5a86f747707c698a49893f96d91f
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 21 21:36:27 2009 +0530
log message supressing in DNS resolution
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 24a38390a450ed3575774fe4d62ca724b1b75741
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Apr 21 21:34:38 2009 +0530
cleanup of logs in socket and ib-verbs transports
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9b4fc3d5cbbbfe3a49889fe1dae4f0c88ed8649c
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 21 02:34:08 2009 -0700
Cleaned up log messages in replicate.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 32e258b0623423b7d91458a73b451352418d528b
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 21 02:34:07 2009 -0700
Cleaned up log messages in client-protocol.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 4869ac0418364a2918c44a572b247301ef1b9038
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 21 02:34:06 2009 -0700
Cleaned up log messages in mount/fuse.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 79f2c58995812ac010017e66398720104cecf6c7
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 21 02:34:05 2009 -0700
Cleaned up log messages in xlator.c
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 14adc656c40333e438dcf4dbc910ca59d8cb71fe
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 21 02:34:04 2009 -0700
Cleaned up log messages in spec.y
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e9c81a3600915071b2741ea0149a061dc2214191
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 21 02:34:03 2009 -0700
Cleaned up log messages in inode.c
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f04cb6b79eb9dc7d093e22f298b4f1585e8de666
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 21 02:34:02 2009 -0700
Changed logging format to remove line number & function name from NORMAL and higher levels.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9a6f5885efecbc6810a83acd3423927f18e9eb2b
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 21 02:34:01 2009 -0700
Introduce new log level GF_LOG_TRACE.
TRACE is the most verbose log level, meant to have a
full trace of operation.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 20d69c105f83c33b839a739ec4bff95e77cbb9dd
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 21 02:18:38 2009 -0700
Remove log level TRACE and the macro GF_TRACE.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 875eb6a273336c29a9fadcd7dbd6308d6f1e18be
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Fri Apr 24 15:28:40 2009 +0530
iobuf: Define MAP_ANONYMOUS
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f5979e1a9a3631535b3a1c82644e18b9b05612ae
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri Apr 24 15:18:15 2009 +0530
rename transport-timeout to frame-timeout, and set default to 30mins
commit b4ec2eb98be736c12e5d7f1925e8a4f33c9b82e4
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Apr 24 00:57:42 2009 -0700
Revised README
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e90766e94873fa3e637f43f9ccde98c586819e6f
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Apr 23 06:53:02 2009 -0700
Do not fail lookup() in case of split-brain.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7af4e0d888761a11e96d4dbc869f0dfaa0174c38
Author: krishna <krishna@gluster.com>
Date: Wed Apr 22 23:43:58 2009 -0700
"option unhashed-sticky-bit on/off"
"option unhashed-sticky-bit on/off" will configure distribute to set or not
the S_ISVTX bit in the stat.st_mode of the actual file in case it is
pointed to by the link file. This can be enabled during migration.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7b0fea84d904d422bd0b1b14c6fb423fc9426547
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu Apr 23 11:20:17 2009 +0530
fix build warning in locks translator
commit 6262789426b6d97203a8eef469d53f465d3ba0f2
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu Apr 23 11:09:37 2009 +0530
minor build fix - set EXTRA_DIST to point to MacOSX/Portfile instead of Portfile
commit 30c3ec83863287ca0b3fa94a56e84528632f9db5
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Apr 23 04:05:00 2009 +0530
fix bdb_db_get() to return exactly read bytes and to copy the read data to given buffer only when needed.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6d579b07c1497d94e70eda914b43d147e74594f5
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 22 07:33:59 2009 -0700
mod_glusterfs/lighttpd/1.4: port to use virtual mountpoints.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 525d4c013ed90240faa60ce5e48522e4b0500db8
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 22 07:34:10 2009 -0700
mod_glusterfs/lighttpd/1.4: ensure each line is no more than 80 characters
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e3f6ce8eff6121fdab4f7d30f75953fbc7ae51ef
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 22 07:32:30 2009 -0700
mod_glusterfs: port apache/1.3/mod_glusterfs to use virtual mount points
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 525f9fdc8749d8f8858d549fa0cbe12b2c3bd5f4
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 22 07:32:42 2009 -0700
apache/1.3/mod_glusterfs: ensure each line is of maximum 80 characters.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d2fc581384b3cf15b6ba87efc4c6c423e530799d
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 22 07:32:53 2009 -0700
libglusterfsclient: implement glusterfs_umount
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1ddae4c9eb7ba96575dbbb8831d3a891d20e9c93
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 22 07:33:03 2009 -0700
mod_glusterfs: port apache/2.2/mod_glusterfs to use virtual mount points
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e67e97ae1587af2f8f3074df4bcc912ab8843b2f
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 22 07:33:15 2009 -0700
mod_glusterfs: coding guidelines related changes
- make sure code fits into 80 character lines.
- proper indentation of declarations.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1fddaed671b7580b1107cc8a2dd91971070fd499
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu Apr 23 10:20:06 2009 +0530
replicate dir self-heal - when creating a missing dir/file, set pending xattrs on source subvolume for that dir/file
commit c91dc9a9abac801df6b2a4ed97389c8aa191eae0
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu Apr 23 02:18:52 2009 +0530
fix in afr directory self-heal (partial healing)
impunge loop was 'continued' on a different subvolume in certain cases, resulting in healing of partial files
commit 1d0537aefe922016f01baa417b12427999423f02
Author: Harshavardhana <harsha@zresearch.com>
Date: Tue Apr 21 02:24:22 2009 -0700
Add MacOSX based packaging file into repo
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 4f5af1bf05c252c98e52c1041b8dc9199958cb4e
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Apr 22 04:31:36 2009 -0700
Bug fix in releasing inode locks when transport gets disconnected.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0eff93285fa336994f8fae833c7690dfc6e9c549
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Apr 22 01:02:09 2009 -0700
Release all pending locks in pl_forget().
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0b34a27d285c56601125fbac96078eea27725bab
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Apr 22 12:55:47 2009 +0530
iobuf_pool->arenas_cnt should be incremented in iobuf_arena_alloc, and not iobuf_pool_add_arena (to avoid counting of unpruned arenas)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 67ad3e80fc0c8ce4124a59659561d250bfd66a95
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Apr 22 04:01:06 2009 +0530
0-byte write guard
guard server_writev from 0-byte writes from client where iobuf will be NULL. This is possible only via libglusterfsclient (not fuse)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0329e1fac4792a41f2cd9c53a5255cbb8745cef3
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Apr 22 03:59:30 2009 +0530
handle iobuf NULL return case in fuse-bridge, by waiting 10 seconds and trying again
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 791a095761f78c2ce4e9552a30bf77112f593ba1
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Apr 22 03:44:01 2009 +0530
fd leak fix
steps:
- server_finodelk uses req->volume pointer into state->volume
- finodelk is queued by locks translator
- c call returns from server_pollin and hdr is FREE'd
- now state->volname is pointing to FREE'ed region (junk)
- server_finodelk_cbk calls gf_add_locker
- gf_add_locker remembers lock with junked path along with fd_ref
- gf_del_locker from new server_finodelk cannot string match with junked volume thus
lock is not deleted, hence fd_ref remains as a leak
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9afb74754f76b60c04b083acc2fe3d767ef57388
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Apr 22 02:21:46 2009 +0530
afr_lookup_cbk - self-heal getting missed
compare for mismatching sizes and attributes before overwriting local->stbuf for read-child subvolume. This causes files with differing sizes on backed not to get self-healed if xattrs were missing.
Also add the ESTALE check for compulsorily failing revalidates in case of 2nd unwind and beyond
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ba0fb99d816773919058acb641238f7e7b6ac68d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:50:33 2009 -0700
posix: Ensure EINVAL return on NULL args
Initing op_errno to EINVAL ensures that this is the value
that gets returned on STACK_UNWIND, in case any of the VALIDATE macros
result in exit from "out" due to a NULL argument. If this is not done
, we get op_ret as -1 with errno set to 0 in the application's
syscall.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5ffce45e3a56ff11cd90a58be9091fa73a46bd8a
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:50:20 2009 -0700
call-stub: Check for NULL in the correct variable
It looks like the argument fd was meant to be checked here instead
of the fd in the call stub. This fixes a NULL fd bug that results in
an EINVAL on opendir.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 009ab9bd19802663c0821943bd7db1868f03f081
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:50:08 2009 -0700
io-threads: Add fxattrop fop
-- added some indentation fixes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f81b30d0aec470069d7d082b1666cd5a861c00cc
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:49:55 2009 -0700
io-threads: Add xattrop fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 72cda988941de2fd7bdcf28e60c97f3a5c6a7a3d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:49:45 2009 -0700
io-threads: Add readdir fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a26385a4289df3b05cfdeccc519b5e0642568c0f
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:49:24 2009 -0700
io-threads: Add removexattr fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0b926d07c2286a3e8a5ba8aa6049b6f6bd03ccc3
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:49:10 2009 -0700
io-threads: Add fsetxattr fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2c7b1111f3b0b0d6a5cd99919eb7a9a7b3939e6a
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:48:56 2009 -0700
io-threads: Add fgetxattr fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e37bcaff342ea539da911743edfcf1d5615d80c8
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:48:45 2009 -0700
io-threads: Add getxattr fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 4c080cc8bdf45bbbcc5c757c9360bba9a7764ff1
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:48:33 2009 -0700
io-threads: Add setxattr fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 79009343e2c4f23f777dec52707df902880be932
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:48:21 2009 -0700
io-threads: Add statfs fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8b82583ad93b72eed705eedef6032b94313ab63a
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:48:08 2009 -0700
io-threads: Add fsyncdir fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1162cff9137e3f1aefffb29b28de17edbb2b3ac2
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:47:56 2009 -0700
io-threads: Add opendir fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f53ee822e6c41fe7ea93596e85f58665c7082503
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 21 04:47:42 2009 -0700
io-threads: Add link fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 228f0e4fc096abbe3abdf2c4372e6eb8ebd24013
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:36:44 2009 -0700
libglusterfsclient: Add VMP-based realpath
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b9107f2194346c8f4aa9fbba1c7ca6a7951cec15
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:36:21 2009 -0700
libglusterfsclient: Add VMP-based readlink
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5d526d51409def4e79c49df10a6e2cccd75ec2fb
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:36:05 2009 -0700
libglusterfsclient: Add VMP-based symlink
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e90eaf0dfade2db68441a4115e74a84e2e526512
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:35:50 2009 -0700
libglusterfsclient: Add VMP-based unlink
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8ce800143cfbae7203210d52e972a9ab9fea493d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:35:32 2009 -0700
libglusterfsclient: Add VMP-based mkfifo
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d59ff4301c1e1db4b11eb7adc4a5d7d8c27ea82a
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:35:17 2009 -0700
libglusterfsclient: Add VMP-based mknod
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5cd39640afdd9b97ea500d77a427b31bfdea0dc5
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:34:58 2009 -0700
libglusterfsclient: Add VMP-based utime
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5700e7133769f09232ecf2d350d2fbe69559c204
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:34:41 2009 -0700
libglusterfsclient: Add VMP-based utimes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 935e171c52730ef49758777d579a69289caa68e2
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:34:20 2009 -0700
libglusterfsclient: Add VMP-based statvfs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c536ba6cfcbc8663f205d895fc764646bde6afbb
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:34:02 2009 -0700
libglusterfsclient: Add VMP-based statfs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8c775d272c75cb1f1eabcfb873b0eb5ae8714b56
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:33:43 2009 -0700
libglusterfsclient: Add VMP-based link
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d4647dbb23745481eb14400271c6f74b5d555f1d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:33:26 2009 -0700
libglusterfsclient: Add VMP-based opendir
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f792d974acff0e097b0d9f5e5020a77360d3ecf3
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:33:06 2009 -0700
libglusterfsclient: Add VMP-based chown
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit cef85134ecb06dcf76bc7d6be461f032be6043a8
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:32:46 2009 -0700
libglusterfsclient: Add VMP-based chmod
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 555221a1d782851c4d1b5121c8934637d933f133
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:32:29 2009 -0700
libglusterfsclient: Add VMP-based rmdir
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0d155585eebda2dbe76732f21758e93082b3a8cb
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:32:06 2009 -0700
libglusterfsclient: Add VMP-based mkdir
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 704ad67ab042f31c0f5a2e9e239fcf7e694f3e39
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:31:49 2009 -0700
libglusterfsclient: Add VMP-based lstat
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit dd87e32b8fd865a458b442258b0b7d7901ace0d6
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:31:31 2009 -0700
libglusterfsclient: Add VMP-based stat
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8e92650d531858207b96a62ecf8864fb1112c237
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:31:09 2009 -0700
libglusterfsclient: Fix stat cache bug
The way stat cache gets updated was not consistent across
all syscalls. Consequently, I was running into a bug that
returned a 0 st_ino. The fix actually resides in the hunk
that changes the lines in libgf_client_lookup but similar
changes were also required in other users of stat cache.
This commit fixes the bug and also cleans up the way stat
cache is updated.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 54da39f2d9a5c2f936ef8604e9f65e925780a0b9
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:30:51 2009 -0700
libglusterfsclient: Add VMP-based setxattr
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c00c97ec6574697781d07e2538a2268ed382c26c
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:30:36 2009 -0700
libglusterfsclient: Add VMP-based creat
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0a9d544fc3b977145298283f637084187c30c7bd
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:30:15 2009 -0700
libglusterfsclient: Add VMP-based open
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 02f399875e0e3877c4eca8146b98c84c16b53e38
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:29:57 2009 -0700
libglusterfsclient: Add VMP-based getxattr
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e4ed8f9d8d5095f3d98c56353a6fab939672d954
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:29:40 2009 -0700
libglusterfsclient: Add VMP-based get
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ae573327b8e7ccd7679dcd94f7ee951bda7b277e
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:29:21 2009 -0700
libglusterfsclient: Add virtual mount point support
One part of the glusterfsclient library requires users
to use a handle to address a particular glusterfs context.
This can become cumbersome for applications that need to use multiple
such context. For such applications, we make it easy by letting them
define virtual mount points(VMPs), which are just paths that identify
a particular glusterfs context. This is done through a new
glusterfs_mount(..) interface.
Subsequenly, any path based operations, that pre-pend a VMP before
the files and directories inside the glusterfsd export, get internally
routed to the correct glusterfs context. This helps users do away
with the need to maintain their own path-to-glusterfs_handle_t
mapping.
The old handle-based interface still exists for whoever wishes to use
it.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b218636686ec4dcce524e560b436dc279827be48
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:29:00 2009 -0700
libglusterfsclient: Must return size from readv
The line being removed made libgf_client_readv return
a 0 on successfull return when the return should really
be the size of data read.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 58566a762b29416b559af6041fc7e80285ebf9b6
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 20 12:28:40 2009 -0700
libglusterfsclient: Expose glusterfs_realpath
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3cd9c82d7aa9e96c1a1bc5e1efa3b27bc4d529d2
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Apr 20 03:54:04 2009 -0700
Check return value of afr_sh_select_source.
If select_source returns -1, abort self-heal.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 89ea37e03b0f24bf1c9bf40249190fd41af60443
Author: Harshavardhana <harsha@zresearch.com>
Date: Mon Apr 20 04:59:54 2009 -0700
change errno EINVAL to ENOENT in case of all fuse_* calls for fuse_reply_err ()
Seen "rm -rf" returns EINVAL in case fuse_loc_fill fails when there is a race condition which can happen when multiple "rm -rf" are done on a same directory listing from multiple terminals.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ffe868952dd347a7f4c729be73b319c41e0fc357
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Apr 20 03:38:15 2009 -0700
Minor fix in afr_sh_build_pending_matrix.
Remove incorrect check for xattr[i] being NULL.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 44c7e8e15c3ce1400a85fa16738ad7cc74cc0677
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Mon Apr 20 13:15:12 2009 +0530
inode.c - NULL check for the extra __inode_search performed, when presented inode is not hashed.
This bug fixes #967
commit a430e173434d2e6528011565a8ffae45a8881b80
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Mon Apr 20 12:00:50 2009 +0530
afr-transaction: handle double flushes
__if_fd_pre_op_done - reset fd_ctx->pre_op_done to 0 so that double flushes do not result in two xattrop() calls
commit 8144bdf3c0a27c9e82e08e5824325eafd2a03b5c
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Mon Apr 20 08:08:26 2009 +0530
client_protocol_reconnect - do not send notify of CHILD_DOWN event if errno from transport_connect() was EINPROGRES
This bug was racing between a CHILD_UP from poll thread resulting from the event_register() of the new socket called in fuse thread. CHILD_UP would sometimes overtake the CHILD_DOWN for EINPROGRESS. So replicate would receive CHILD_DOWN as the latest event. This resulted in self-heal not happening etc.
commit 00e0d8b05ce987d0546d027d4479652b580aff0f
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 18 13:27:21 2009 +0530
keep ctx->page_size fixed at 128KB but only add the margin for iobufs which are created
commit 600d2a9a51cae1b5d8d1013088d3b1bf6cc11d70
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 18 11:19:34 2009 +0530
enhancement to migrate-unify-to-distribute.sh
commit 75184867c3933a2ebeeccec1e0a361d641099fea
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Apr 17 16:07:00 2009 -0700
added migration script from unify based setup to distribute based setup
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3fabe2a14012d602eeb9167082f9f564eb13281f
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 18 02:49:03 2009 +0530
pruning buffer margin - do not destroy if no other non-filled arenas are in the pool
commit 3b978db55945fae1049a743d4c0246930828c1e9
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 18 01:09:31 2009 +0530
disconnect transport peer if system is out of memory while allocating iobuf
commit ac7b8e675b92bdb0b9de33330381e8fe4121b6ef
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri Apr 17 23:35:43 2009 +0530
iobuf - account with iobref_size() instead of iov_length (vector)
commit 1c253aa6df0360b461e840b73cd94d9f3a0ac91e
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri Apr 17 23:12:37 2009 +0530
added 2 APIs iobuf_size and iobref_size to return the system memory usage by an iobuf, and by all iobufs in an iobref respectively
commit f288efad6e4ed850a980c13a7c9162e71c13a215
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Apr 17 06:15:16 2009 -0700
Destroy old ping timer before setting new one.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 20601cdec570dc4ab25a6e800e75b5c39ef01335
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Apr 17 05:42:23 2009 -0700
Fix two memory leaks in afr self heal code.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 43406882c1100e1f2f15695c05e24998b164a016
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri Apr 17 17:52:07 2009 +0530
add 4KB margin in iobuf to accommodate fuse header
commit 45f1c5941f6824787c5967639b09c14577fc7cc7
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Apr 17 04:23:58 2009 -0700
Fixed parameter to finodelk in STACK_WIND in dht
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit daa2430bf2d929e95b0d220552d523f8fb9f5347
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Fri Apr 17 02:33:01 2009 -0700
libglusterfsclient: Fix typecast to fix build warning
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9384b08d18701c4df18aa6fd80d81c528dd0bc4a
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Fri Apr 17 14:19:18 2009 +0530
protocol/client - set remote inode number in inode context for root inode also, during lookup_cbk().
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2fa4c958b149407a03bf2458883ead1aea5b08c9
Author: Harshavardhana <harsha@zresearch.com>
Date: Fri Apr 17 01:08:00 2009 -0700
Renamed abs_top_srcdir to top_srcdir for older versions of autotool
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit df1b822d78737f75696e05b6daefe624507f5cc3
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:59:02 2009 -0700
libglusterfsclient: Remove unused variables
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b0811e479e8fcb3081838c01fc92c6a68b57e480
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:58:50 2009 -0700
libglusterfsclient: Add realpath API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1691e09cd2652bd319e63f5db2be2a54a4f0c44a
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:58:39 2009 -0700
libglusterfsclient: Add lstat API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a2c8ce46447a0c9440a6ab44ba33bdac653184a8
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:58:26 2009 -0700
libglusterfsclient: Add readlink API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 99e7e89ac2ef9f50285d6ea6541487c2969651b1
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:58:13 2009 -0700
libglusterfsclient: Add symlink API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 73bc0e6ae8220904dda10e17c94649a286130408
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:58:00 2009 -0700
libglusterfsclient: Add unlink API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8ef91133a87d448051a2acf54481f01bc0d161b7
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:57:40 2009 -0700
libglusterfsclient: Add mkfifo API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a6e2c24469f2fb334f0086fc99740e30f27dd239
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:57:24 2009 -0700
libglusterfsclient: Add mknod API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 756efc4e6d3212fdd9235caecea6649e8fb43df5
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:57:13 2009 -0700
libglusterfsclient: Add utime API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7ec318ae45cbb14b4eff9013e1fbaecc5631760d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:57:01 2009 -0700
libglusterfsclient: Add utimes API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a68a96298d876a90fdd87128c0fc019a3aa51aed
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:56:51 2009 -0700
libglusterfsclient: Add rename API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5cb1ccfeb5fcb4d58c04f7a85ad41ce3f574ebaf
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:56:40 2009 -0700
libglusterfsclient: Add statvfs API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 4f87b2d380f6623d688750bd46e0ebeff3bac51a
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:56:29 2009 -0700
libglusterfsclient: Add statfs API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 4068faba1326cac8eb2ff617155a5c4ba5a35900
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:56:08 2009 -0700
libglusterfsclient: Add link API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 30cf1d91451cbdb12a894392d83e817d701d98be
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:55:55 2009 -0700
libglusterfsclient: Add ftruncate API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 60a840f45d4f9b48bab3eafd9f64d926bbb44765
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:55:40 2009 -0700
linglusterfsclient: Add fsync API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8f4e7c7297770786a38b5175d34d16a81d916e2d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:55:26 2009 -0700
libglusterfsclient: Add fchown API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f879c02a6e46b521ebccfe50c23bb9651b73ce23
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:55:12 2009 -0700
libglusterfsclient: Add fchmod API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d11ecec61d19ce29120bb3613209df9b0d4d80f7
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:54:58 2009 -0700
libglusterfsclient: Add closedir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c337ed6330f9bbba1973728431cbbd1cab55c297
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:54:42 2009 -0700
libglusterfsclient: Add opendir API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ef2dcc4a5885435350861a78470a2510f25e5c0e
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:54:27 2009 -0700
libglusterfsclient: Add chown API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 002592cf75ae23be4a67ba9ba692e89c860c510d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:54:14 2009 -0700
libglusterfsclient: Add chmod API
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ae4e2b32b2e1deb265ff87d466fed3989473a8c8
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:54:00 2009 -0700
libglusterfsclient: Abstract away inode attr cache updates
This commit creates a separate function that allows users of
the inode attribute cache to update the cache when required.
Major users are lookup, stat and fstat functions.
The function libgf_update_iattr_cache(..) allows updating the lookup
and stat caches separately using flags.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1b256f9a07775eef8e08e0a70e91d9ca4b84a105
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:53:51 2009 -0700
libglusterfsclient: Replace dict based inode ctx with array based one
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 42f3eccee20c351f520bc08d40f092f115f101e4
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:53:39 2009 -0700
libglusterfsclient: Fix fd_ctx leak on release cbks
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 078298fcff22ea5983370adbd75f16637ad0e5f4
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:53:24 2009 -0700
libglusterfsclient: Replace dict-based fd ctx with array-based one
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 26705312ab9d9532cd7ca760686bf3c4ef875649
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:53:12 2009 -0700
libglusterfsclient: Generalize [RW] checks on dirs
This patch moves the read-write permission check on directory
inode into libgf_client_opendir, so that when I am next adding support
for the opendir syscall, I dont have to perform similar checks again,
outside this function.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 145d6c6f0fc33ef60a0e2c94b4d6cebe2864149f
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:52:54 2009 -0700
libglusterfsclient: Check for directory on O_CREAT
If we have received an O_CREAT for a name where that basename is a
directory, and if we have successfully looked up the inode for this directory,
then we can check for S_ISDIR in libglusterfsclient and prevent sending a message
to the server through libgf_client_creat. See also the comment inline.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8ea7f8367f6f42d1b56b0ea9b95208134a19f279
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:52:43 2009 -0700
libglusterfsclient: Create and use LIBGF_REPLY_NOTIFY macro
All reply notifications can now be abstracted away through
this macro and all cbk functions should now call this.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit bcb21aa428299b6fcb3e5e64e79733e00e10c349
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:52:27 2009 -0700
libglusterfsclient: Fix segfault on non-NULL loc->name
The gf_log message actually assumes that loc->name will have a valid
non-NULL name in it, whereas if the loc_t being passed to it was
actually created on a function stack, i.e. a local function variable
and was then passed down the code path to do_path_resolve without ever
initing it or zeroing the structure, its possible that the name member
has a non-NULL but corrupted address. This leads to a segfault.
Whereas, we know loc->path will always have the full path.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a3502cf77fe0e956d255e4c6c8b453d009ffbd01
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:52:04 2009 -0700
libglusterfsclient: Use macros for argument checks
Having those if {} blocks to check for argument
validity hurts the eye so this patch replaces those checks
with macros. One macro already exists in libglusterfs. The second
macro is introduced by this commit for libglusterfsclient-specific
check for paths.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d58e3e5b68a8f95514cd73bd33ad14437014b532
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 16 23:51:45 2009 -0700
libglusterfsclient: Rename XLATOR_NAME define
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 29db710dc794908342cee699bc0fb1dd23e6021b
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Fri Apr 17 00:32:17 2009 +0530
protocol/client - NULL check for loc->inode added in statfs(), before trying to retrieve remote inode number from loc->inode's context.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 04a516d1c228778b20e4b4840c8dfd0c50cb3b7c
Author: Harshavardhana <harsha@zresearch.com>
Date: Thu Apr 16 06:15:48 2009 -0700
RPM spec file updates for RHEL,CentOS,Fedora,SLES and OpenSUSE for upcoming 2.0.0 stable release
* Updates to ahere to RPM standards hugely driven by Fedora dist-f11.
* RPM spec file portable across RHEL, Fedora, CentOS, SLES, OpenSUSE.
* RPM spec build options made compact and removed unnecessary.
* %changelog old entries removed as they were giving many warnings
during rpmlint.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ab4bb5cd3bc9521f76e6a589a0913fea89124621
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu Apr 16 17:32:05 2009 +0530
add NULL check in iobuf_arena_destroy
commit 04c7dccdad6e59b2ad7d1dad0e03932f7eb9ca06
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Apr 16 03:41:54 2009 -0700
logging enhances to commit d77279ef04ca75ab9715864274567d1ce0ce66a6
- logging made more relevent.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 59d84676d9a4df40ef4e132decbc1e217dd9f6a9
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Apr 15 06:02:22 2009 -0700
Use original pid when calling the FOP in afr transaction.
Save the original pid while locking and restore it
after the FOP is done. This ensures posix-locks can
release locks (fcntl) properly.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c2c9e90fc6f4e80e4d8c5b850f5a5b67046c1f79
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 15 03:11:21 2009 -0700
write-behind aggregate-size related changes
This patch brings in following changes:
1. make aggregate-size as non-configurable and make it to be equal to
maximum iobuf size.
2. best effort to write data in chunks of length as close to aggregate-size
as possible but not greater than aggregate-size, since aggregate-size is
made equal to Maximum size of iobuf.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ba1da4d699852b1f172f4a8e7034a1bfba8b7b52
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Apr 15 03:12:17 2009 -0700
write-behind: adhere to coding guidelines.
- make sure lines are not greater than 80 characters in length
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit aa4c8800eabfcdfc2ac71f7ce0e3d46b8ce900a4
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Apr 16 14:38:02 2009 +0530
cluster/distribute bug fix - try to create linkfile in dht_lookup_everywhere_cbk(), only if hashed subvolume can be determined, else error out with ENOENT.
-- with local fixes (avati)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 28586aa04ed35d78036ab3fba962c4b6030af836
Author: Harshavardhana <harsha@zresearch.com>
Date: Wed Apr 15 01:00:01 2009 -0700
Fixed the build problems observed
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 15cd6305b334d66a24ab34aff3b2f921da4c26d1
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Tue Apr 14 15:28:34 2009 +0530
eliminate this_ino_get(), this_ino_set(). handle inode_ctx_{get,set}() at the fop level itself.
they used to log ambiguously
and was of no use. logging is now more precise and will help in debugging,
in case of errors.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 962e75ff4ee3b9733019c7020073086f26899e40
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 14 08:15:50 2009 -0700
Changed xattr format of afr changelog to support adding and removing of subvolumes while keeping existing data.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit dc09f2541635466f1e95fd0e549192fcbfacd0b0
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Apr 14 02:53:09 2009 -0700
server-helpers: Add check for NULL connection arguement being passed in helpers.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit af22de8ed7cee99cb0c54b0224d69be76cc4727c
Author: Anand V. Avati <avati@gluster.com>
Date: Tue Apr 14 15:09:37 2009 +0530
remove unused variable @ret in ib_verbs_options_init
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 679db11a44acf437b0ef670e487d317f3a1bd4cc
Author: Anand V. Avati <avati@gluster.com>
Date: Tue Apr 14 14:51:26 2009 +0530
use MAP_FAILED macro to free mem_base in arena_destroy
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 572961ef6edf7fd120b28b82a3d6c444c6a6cf1b
Author: Anand V. Avati <avati@gluster.com>
Date: Tue Apr 14 14:51:16 2009 +0530
FREE arena->iobufs in iobuf_arena_destory
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ff832b423f0ed5933b7d21c9718503854b78507a
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Tue Apr 14 14:20:04 2009 +0530
cluster/unify link() should be sent to only one subvolume.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 84aaedf350432e93b8e9c541eaddc9f73cc046c5
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Apr 14 00:41:43 2009 -0700
minor bug fix in posix_create() when 'o-direct enable' option is given.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5680d5e6fbad7413f7eb3af44ac27d135f3a0a97
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Apr 13 23:40:22 2009 -0700
bug fixes in dht-disk-usage feature.
fixes bugs seen with dht's disk usage.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 32320c5b4a32e58a4b7a16f2c5ab8c4abf3d67c7
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Apr 13 07:23:59 2009 -0700
Send statbuf from the same subvolume, even across revalidates.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit fbc21bc2970e0abf9663c49788bb77929b188f92
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Mon Apr 13 18:42:36 2009 +0530
use ctx->page_size in all translators and transports instead of having their own configurations
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b1c78068444a9eea3cf7135178b946d0f950e91e
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Mon Apr 13 17:50:21 2009 +0530
introduce page_size in glusterfs_ctx_t to be used by all translators set it to 128KB in main()
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1a0d1c63bd9ed9abfe54d67c02920a602c5857e0
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Mon Apr 13 15:41:01 2009 +0530
client_readv_cbk - when op_ret is 0, iobuf comes NULL from transport, handles this case
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e85fc69d3ac91beb738bed9899cf18befa05def1
Author: Anand V. Avati <avati@gluster.com>
Date: Mon Apr 13 14:03:43 2009 +0530
bug fix in iobuf_select_arena - call __iobuf_pool_add_arena (unlocked version)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ce90c981316ec5984405eed5a1f12af0c1489ab4
Author: Anand V. Avati <avati@gluster.com>
Date: Mon Apr 13 14:03:35 2009 +0530
bug fix - arena destruction now calls munmap and not FREE
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 56b0dac525026663899e6473e6291b9d115fe6cc
Author: Anand V. Avati <avati@gluster.com>
Date: Mon Apr 13 14:03:28 2009 +0530
add purge list support to make iobuf_pool_purge() in expensive, and actually call it in iobuf_put :-)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 357eb32fe981969be8e4f52974bd59aaee8119ca
Author: Anand V. Avati <avati@gluster.com>
Date: Mon Apr 13 14:03:21 2009 +0530
bug fix in iobuf_select_arena - never created a new arena
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e81cafd7ee77f43fa27cb5dec709f0a263cb42b7
Author: Anand V. Avati <avati@gluster.com>
Date: Mon Apr 13 14:03:13 2009 +0530
add @filled list in iobuf_pool to keep away filled list from getting searched in iobuf_select_arena
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c79d2f357f0a390db7dc03a0818230b01bb42c1e
Author: Anand V. Avati <avati@gluster.com>
Date: Mon Apr 13 14:03:02 2009 +0530
change arena size to 8MB
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2441ca1ca8bb1333c8bf32b8502f4d73168506e4
Author: Anand V. Avati <avati@gluster.com>
Date: Mon Apr 13 14:02:57 2009 +0530
use MAP_FAILED macro to check for mmap failure instead of (void *) -1
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 790be0e19696b21d8652bbd99b85a98365570180
Author: Anand V. Avati <avati@gluster.com>
Date: Mon Apr 13 14:02:47 2009 +0530
fixed sizeof parameter in CALLOC of a new arena
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit aec4382429e8663979e1f4ab38c27b54e752c63a
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Apr 13 11:21:20 2009 +0530
switch scheduler to validate the subvolume specified for a pattern, against the given subvolumes of cluster/unify.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 674ac008e62b1c5404bb86d131307b6683092dc3
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Apr 13 04:47:39 2009 +0530
changes to database read interface, to make use of a given buffer instead of allocating internally.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b3f57c0416df7e3ec5eb395df93b352a0533adf7
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Mon Apr 13 02:09:25 2009 +0530
log formatting fixes. use GF_PRI_SIZET for size_t.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 98578effc7d0f148d39703cc484245dc2c3e2fa5
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Apr 12 04:16:09 2009 -0700
minor initialization bug fix in quota's build_loc
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9913f22628d9597a211507ab04b0bdfe1808b992
Author: Amar Tumballi <amar@gluster.com>
Date: Sun Apr 12 04:12:00 2009 -0700
in dht, initialize the free available space properly, so the first few creates are not confused.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 922936e93a83ca8b9ffee42159475782792523e7
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 8 02:28:16 2009 -0700
Coding Style: Add a few points
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b34a54729bb6c233e0aad7232622b07541be86bf
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Apr 10 00:34:34 2009 -0700
feature to disable volumefile's checksum
in server volume define, "option verify-volfile-checksum no" to disable
the checksum feature.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7c6e621c99a6c4a91cbd49df43650c9030306398
Author: Anand V. Avati <avati@gluster.com>
Date: Fri Apr 10 09:22:18 2009 +0530
reset errno to 0 before calling first fuse_lowlevel_new() to reliably detect for unsupported params
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6d3597f9b61926dd945a297df0254151b7078d61
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Fri Apr 10 07:09:49 2009 -0700
io-threads: Remove unnecessary call to pthread_attr_setstacksize
We do not need to explicitly set the stack size to its default
value.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f6943f3e80c449e7788eaf3f8bb3e0d4a0f74fd2
Author: Anand V. Avati <avati@gluster.com>
Date: Sat Apr 11 00:54:29 2009 +0530
prefix ULL to large constants (to fix bdb build warning)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b0bcff9cf09f74924291d00c37a569b1f5db4c9d
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 23:32:24 2009 +0530
updated glusterfsd to create iobuf pool at initialization
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0bc230fd8b550c6d13c77ad9ed84c427ec467efe
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 23:22:26 2009 +0530
updated libglusterfsclient with IOBUF/IOBREFs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 11061928139849d1a1923e371d0c90a50842e7d3
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 23:09:15 2009 +0530
updated transport/ib-verbs to use IOBUF/IOBREFs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7232a2e7b2d03c5a8a3a8698eb77995764feedbe
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 23:00:59 2009 +0530
updated transport/socket to use IOBUF/IOBREFs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 345704b5669ce425ffc71cff558636ac8065d353
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 22:04:44 2009 +0530
updated mount/fuse with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d81a3711120842c6811166eb4c0107b22794c4f6
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 21:53:57 2009 +0530
updated encryption/rot-13 with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 327cf2d6c348dc7366a94458c6941f2c266be365
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 21:52:08 2009 +0530
update features/quota with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b1068eb1a59e95ace2854da1de10971511ac8482
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 21:48:35 2009 +0530
updated features/filter with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit aae338cab93a89ea5b01ecea9046e44eac6bce56
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 21:46:54 2009 +0530
updated features/locks with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 083ef2db768a172a8b7ac4704839f3aa3a6cc539
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 21:43:51 2009 +0530
updated debug/error-gen with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 26e6327a2e9cd7b9ca38acbc70017e96acde761d
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 21:42:45 2009 +0530
updated debug/trace with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1d6f14bfa4f634f8e006f0613a23812160c0c028
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 21:40:19 2009 +0530
updated performance/io-cache with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0be3c016f686bbae688474dc6c930d615af3d75a
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 21:23:00 2009 +0530
updated performance/io-threads with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d85afd3107583a317d54f689a232de14f8130768
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 19:00:45 2009 +0530
update performance/read-ahead with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5afbbbf7e7b3785473cb5e21b20a879db6a142bd
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 18:51:39 2009 +0530
update performance/write-behind with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6dc09d7921f1bb8e1cff3aba8acec9dfb8e8c200
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 18:43:35 2009 +0530
update protocol/server with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 612f7072c3bb3590b6a3da6f2444727e24c11f6a
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 18:15:11 2009 +0530
updated protocol/client with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3819b160ae9128030d9130cc1092619af2dd5ad4
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 18:14:10 2009 +0530
updated transport interface functions to accommodate IOBUF/IOBREF
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9377c719aebea0cd18adb876f4c134a3e7ae925a
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 02:33:49 2009 +0530
update storage/bdb with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9acd56fb0926be1930a16a1ffa80c97861f52d2c
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 02:17:25 2009 +0530
update storage/posix with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ad836f49cd6e24e20ad96b1e3507ade1605c3218
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 02:02:52 2009 +0530
update cluster/map with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 63badef6bb8935e75cc31a48b2dbb0988c15a9af
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 01:59:56 2009 +0530
update cluster/ha with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 931d5ce48e010b2af34b20472290054850240510
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 01:57:14 2009 +0530
update cluster/dht with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f134be44644b7dfec9f2a11795ccd300a3ddb7f9
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 01:52:08 2009 +0530
update cluster/afr with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9dfc7d16ed9ae61a3d01109fc2cc52c2ccd5da3e
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 01:39:34 2009 +0530
update cluster/stripe with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit dd6fbb9fbc238540e1239ebc80eed908d4a07203
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 01:25:26 2009 +0530
update cluster/unify with new readv writev prototypes
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7603482503fa5f107969b0534aa75f91e8335234
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 01:21:57 2009 +0530
do away with frame->root->{req,rsp}_refs members
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3c50f36f48d58e90988597c9d2be4c4a6b09b888
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 01:12:10 2009 +0530
update prototype of writev and readv_cbk to use IOBREF in parameter (step towards elmination of frame->root->{req,rsp}_refs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ef07cb3f716d2efa0d5ad61555ee274328051b07
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Apr 11 00:09:08 2009 +0530
IOBREF support for holding iobuf refs along with fops (replacement for frame->root->{req,rsp}_refs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8495f73b3890495d30bd6ec54fcc6ed5d1fb0dac
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri Apr 10 23:11:33 2009 +0530
use 128Kbyte as the channel transfer size in fuse-bridge
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 172dc6a47a6fc4543810f91176d88f43dc1fa2ab
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri Apr 3 15:17:04 2009 +0530
IOBUF support (to be used by transports and fuse)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f51cff05f18e9a549462b6022d11b6b4264feeda
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Fri Apr 10 04:22:37 2009 -0700
io-threads: Reduce default min and max threads
Going by the memory usage for each threads, it is prudent to
have lower number of threads by default and let users who understand
the memory consequences increase the thread count for themselves.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1eaec8550a65e9d3586b1492467e0fb20443014c
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Fri Apr 10 04:21:53 2009 -0700
io-threads: Use non-default thread stack size
The default stack size on Linux is around 8 MiB for each
thread. This is clearly too high for our purpose. This commit reduces
the stack size down to 1 MiB.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2a7bb08ccbf787c9ae20b63aeec55b6aacce21cf
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Apr 9 07:59:21 2009 -0700
posix_unlink: make unlinking in background configurable through volume spec file
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d86473d02632904d33f6415ce519c3dd2a8fe992
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Apr 9 03:54:51 2009 -0700
Compulsorily do self heal if file sizes differ.
If file sizes differ, then compulsorily do self-heal. If no 'wise'
sources are found, then pick a 'fool' with the biggest file size.
If even 'fools' aren't found, pick the 'innocent' source with the
biggest file size.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit eaf53c4b964214a80f7a4f05bf27324ae820fef7
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Apr 9 03:53:59 2009 -0700
Handle files which have no pending xattrs at all.
If a pending xattr key is non-existent on a file (call such
files 'ignorant'), make all other non-ignorant subvolumes point
towards the ignorant one.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 71f9f5ec399daaf1b1382697f9533f38c891cf76
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Apr 9 03:53:26 2009 -0700
Erase xattr during self-heal based on original dict.
Decrement xattr during self-heal based on the original dict instead
of pending_matrix, as the pending_matrix might have been
altered later.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 39b68a14c2db0d61c5518eba1078e8cf251c962c
Author: Csaba Henk <csaba@zresearch.com>
Date: Tue Apr 7 02:14:20 2009 +0200
niftify mount(8) output for glusterfs mounts
Originally, mount(8) shows a glusterfs mount like this:
glusterfs on <mp> type fuse
With this patch, mount(8) will show a glusterfs mount like this:
<volfile> on <mp> type fuse.glusterfs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2753c7ed377424a29633cf2a2e657c793b99a2c6
Author: Harshavardhana <harsha@zresearch.com>
Date: Tue Apr 7 00:43:23 2009 -0700
Commit package making files for FreeBSD and Solaris platform.
Commit for package making related files for FreeBSD and Solaris. These files
are supposed to be in repository to not loose track and update them as needed.
I will update them soon for upcoming release where we support Solaris on
ib fabric also.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit bf70d1da169d2286115e0d160aac77d441542641
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 7 05:43:31 2009 -0700
libglusterfsclient: Complete support for rmdir fop
glusterfs_rmdir code path wasnt implemented completely. Here is an
attempt to complete it.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5ffa856fcaadfda393770b326636ace3ff481ce4
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 7 05:42:14 2009 -0700
libglusterfsclient: Create new directory inode
Make sure we give an allocated inode in the loc so that the underlying
callbacks are able to fill it with the relevant information about the
directory being created.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e7ea14e31afd9e2a3436602a44a4543b9fc65a00
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 7 05:41:50 2009 -0700
libglusterfsclient: Return ENOENT on missing ancestor component
If any of the path's components, except the basename, are missing
from the dentry cache and the corresponding lookup from the server
also fails, return an ENOENT.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 67f8480f7e9dc3a6db6b4b69442863994c584218
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 7 05:40:12 2009 -0700
libglusterfsclient: Return EEXIST on lookup success in glusterfs_mkdir
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ce16b48f76675bcc7fc1cf78b774d27283201cec
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 7 05:36:57 2009 -0700
libglusterfsclient: Perform explicit create
We must create the file based on the O_CREATE in the flags
instead of depending on the return status of the lookup.
This works because we've already handled O_EXCL earlier and
also handled a missing file(ENOENT)
in case this was actually an open and not create.
Adapted from Raghu's original patch.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 75b23f263960561eed1518d107157f05b1d03e32
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 7 05:35:32 2009 -0700
libglusterfsclient: Handle O_CREAT on lookup failure
On lookup failure, if O_CREAT is required, then we must:
1. explicitly lookup the parent directory.
2. create a new inode for the new file being opened.
This special case is required for file creation because:
1. We cannot depend on the previous lookup to have reliably looked up
the parent inode.
2. inode for the new file does not exist in the itable.
Patch adapted from Raghu's original fix.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 722b7ec50c8de279cd65fe70d969a6d2e62ff6e4
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 7 05:34:56 2009 -0700
libglusterfsclient: Dont depend on ENOENT
Dont depend on the dentry and explicit lookup function, i.e.
libgf_client_path_lookup(..), to return ENOENT on not
finding a dentry. Just use op_ret = -1 as a lookup failure
status.
Patch adapted from Raghu's original fix.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 975a4319e8045efa07cb96c7359de6496d523aad
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 7 05:34:24 2009 -0700
libglusterfsclient: Remove spurious strcmp
This strcmp existed because of assumptions that do
not hold true since the change in libglusterfsclient
internals recently.
This is another step in fixing the seg-fault on glusterfs_create.
Patch adapted from Raghu's original fix to the problem.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5f213f12740eb6ea75f5a7cd24a177181c38cb89
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 7 05:33:56 2009 -0700
libglusterfsclient: Resolve path on empty caches
The earlier case was that the explicit lookups to the server
were being sent only when the parent inode was NULL. This situation
breaks when the parent inode is available in the i- or d-cache
but the child dirent is not. In such a case, no explicit lookups
were being sent to get the missing child dirent.
Now, explicit path lookup happens even if the inode for parent or basename
is not found in the caches.
This also fixes a seg-fault occuring during glusterfs_open, in my test
case, but one that could occur almost anywhere lookup code is used.
Patch adapted from Raghu's original patch.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 73bbc640d99fe50f6f204162b661b426915d340b
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Apr 7 05:32:47 2009 -0700
libglusterfsclient: Fix segfault in glusterfs_open
libgf_client_loc_fill gets passed a name=NULL argument.
So when this function returns the filled loc argument, this loc
is actually missing the inode structure that was to be filled.
The segfault actually occurs a few lines later when
we try to access fd->flags but fd returned by fd_create is NULL
because we'd passed a NULL inode to it, i.e. the loc->inode.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit eb10f49e70941b503a970e82748654393bfbcd6e
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Wed Apr 8 04:24:22 2009 +0530
introduction of secondary index database in storage/bdb
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 02aeff9980fbdbc6cdc3a93184e9f8845b85fe2c
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Wed Apr 8 04:24:00 2009 +0530
link() & rename() on storage/bdb will always return EXDEV.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 47c9192b0a24f1d0eaa6b0f504cbcecedb448c09
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Wed Apr 8 04:23:30 2009 +0530
storage/bdb untabify, code alignment to limit to 80 characters per line.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0dc23db3399dcba75ec9b55a688fb5e636fd2471
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Apr 7 17:38:07 2009 -0700
map translator cleanup.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 289a95b745d125256f0981ebcbe9ed98f296dd8b
Author: Vikas Gorur <vikas@gluster.com>
Date: Wed Apr 8 02:30:18 2009 -0700
Fix minor bug in afr_open_cbk.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b862b880e0f5e194a9bf86f45a1328e81363db2c
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Fri Apr 3 02:06:52 2009 -0700
io-threads: Refactor un-ordered worker exit path
This is being done for the same reason as the
previous refactoring for ordered threads.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9658469f16c5ba8087ff311b49f3c2dfbd52b0da
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Fri Apr 3 02:06:25 2009 -0700
io-threads: Refactor ordered worker exit path
This patch re-factors the exit path of an ordered worker
on a time-out. Earlier we're checking for exit permission
in such a way that required us to release and acquire
the worker lock a second time in the worker loop opening
a window wherein a new request could've been appended to the
request queue.
This patch makes the decision to exit while still holding on to the
worker lock.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5f6f8034523df5b9ce28eb6e25d27182312dceaa
Author: Csaba Henk <csaba@zresearch.com>
Date: Mon Apr 6 21:25:12 2009 +0200
add .gitignore
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1ac9b9bc01256e892de9b016d1c9e301830494c3
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 7 06:55:43 2009 -0700
Fix in changelog logic.
If a writev fails, remember it by marking it in the fd context.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 06a160d508cc244044bb078ba40122b662aa46e6
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 7 06:55:15 2009 -0700
Consider a subvolume dead if an fop fails on it
Transaction fops earlier called afr_transaction_child_died only
if an fop failed due to ENOTCONN or EBADFD. Now they consider a child
dead regardless of the reason for failure. This handles cases such
as ENOSPC.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 742e7c6cf1e2734ebd8b3110f21162e7ec0319b6
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Apr 7 03:27:24 2009 -0700
Add lock-less versions of fd_ctx_*
Added __fd_ctx_get
__fd_ctx_set
__fd_ctx_del which do not hold any lock.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6f02d917064c9ae4664f1f2245446b77c7ce83cf
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Apr 6 10:27:45 2009 -0700
Enabling booster after port to work with changed libglusterfsclient interface.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 349936a907740dc5bad907db39b544e2d3736901
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Apr 6 10:56:52 2009 -0700
fix to fd leak in posix_create() in case of some failures.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 37a194042d75c183e6a34acadcb71d6537d05c6e
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Apr 2 19:45:04 2009 -0700
nufa to take care of free disk-space while creating files.
nufa gets awareness about the available free-disk-space in subvolumes.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a4b232b635c2c48106a84575076df13443e39736
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Apr 6 05:21:29 2009 -0700
Fix in return value of afr_sh_mark_sources
afr_sh_mark_sources now returns:
-1 if two wise subvols conflict (split-brain)
0 if all subvols are innocent (no self-heal needed)
>0 if sources found
Also, changes to callers of afr_sh_mark_sources to handle return
value properly.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit be51678a9723875e2fec74096cdd402dd2bac0e9
Author: Csaba Henk <csaba@zresearch.com>
Date: Mon Apr 6 14:03:21 2009 +0200
bitrot-13 fix
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 83db08be4ae0cdd5462a5cfbf93efc7ad7bf6299
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Apr 6 04:00:59 2009 -0700
Fix an incorrect type-cast in libglusterfsclient.c
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b43074f3a1e8ece2f32f265aa10cde5a06fa488b
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 6 00:37:54 2009 -0700
io-threads: Cleaner stub destruction
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d26b6e42cda661062b344a5662ff58b71069bcc1
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Apr 6 00:25:51 2009 -0700
io-threads: Sanity check worker thread idx
This patch adds sanity check for the ordered worker thread index
returned from the inode's context. If the index is corrupted we
STACK_UNWIND with ECANCELED.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9668324271781563ca10c93ae873c78e8bf90a8d
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri Apr 3 22:13:53 2009 +0530
disabling booster
commit 14ee898eb3808c4dee3564190218ae0eb0c789e0
Author: Amar Tumballi <amar@gluster.com>
Date: Fri Apr 3 08:27:44 2009 -0700
distribute to take care of available disk space while creating new dirs, and files.
distribute gets awareness about disk-space while creating the files
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit be52ff512f48a872649913694ccc44d4a0a60553
Author: Rommer <rommer@active.by>
Date: Wed Mar 18 14:32:50 2009 +0200
fix broken transport-type unix
fix broken transport-type "unix"
however unix transport not working with defined transport.socket.bind-path
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 15426e5c90bb38ee9ed65687ed45ac723d4a549b
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Mar 30 07:25:32 2009 -0700
libglusterfsclient - reimplement glusterfs_fgetxattr and glusterfs_fsetxattr
- glusterfs_fgetxattr and glusterfs_fsetxattr earlier used lookup and setxattr
fops for implementation. Change it to use fgetxattr and fsetxattr fops
instead.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 4f95140acf3a5e28d7faf350b32c2eda22abbbfe
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Mar 30 07:20:35 2009 -0700
libglusterfsclient - fix bug in __do_path_resolve
- add argument lookup_basename to __do_path_resolve which indicates whether to
lookup basename(path). This is necessary for apis like glusterfs_get, which
dont want basename(path) to be looked up by libgf_client_lookup_path.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9c1de928268f3aab567aad366f0700805b174272
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Mar 30 06:33:06 2009 -0700
libglusterfsclient - move lookup timeout related code to libgf_client_path_lookup
- this simplifies the resolution of path to inode, the apis which receive
path as argument just need to call libgf_client_path_lookup for
path->inode translation.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 169b8da4ec928486205c7302639f3f2886be8572
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Mar 30 04:21:59 2009 -0700
libglusterfsclient - fix indentation
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ed7737f87f0132261bc436ceccd52e96b13aa2d1
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Mar 30 03:57:20 2009 -0700
libglusterfsclient - change implementation of glusterfs_get
- remove redundent lookups happening in glusterfs_get.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a2d7b114703d3528cbca095177c04d1febabdf65
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Mar 25 23:22:55 2009 -0700
mod_glusterfs/lighttpd/1.4 port and memory leak fixes
- port owing to changes in interface of libglusterfsclient.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8b1873d10c66a8ac8d8918f3dab5bdb97cb1e2f9
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Mar 25 23:22:28 2009 -0700
mod_glusterfs/apache/1.3 port
- port owing to changes in interface of libglusterfsclient.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 71720828f92e40c064dfff23c17eff5f83405f03
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Mar 25 23:22:03 2009 -0700
mod_glusterfs/apache/2.2 port
- port owing to changes in interface of libglusterfsclient.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit fc26856a9dad9356f5aa1b239d44409776bd112f
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Mar 25 06:52:05 2009 -0700
libglusterfsclient code changes
- add dentry support to libglusterfsclient.
- changes related to using array, to store context in inode instead of
dictionary.
- code changes related to cleanup of libglusterfsclient interface.
- added glusterfs_mkdir and glusterfs_rmdir
- other changes in libglusterfsclient to make it work with code changes
in other parts of glusterfs.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit dc560f195a617a7fb480905fa7d461d2442782c1
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Fri Apr 3 06:30:54 2009 -0700
server-protocol - reimplement connection cleanup to happen in 2 phases
- first phase, which happens when POLLERR is received on transport,
releases all locks, flushes all open fds.
- second phase, which happens when both the transports of connection destroyed,
destroys the containers like lock table, fd table along with the connection.
- the first phase, clears up any references to transport held by translators
like posix-locks(in the form of blocked locks) paving way for the second phase.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6b2d42cfc5b795832635ca0ed707564d9e4ca94a
Author: Vikas Gorur <vikas@gluster.com>
Date: Fri Apr 3 05:34:10 2009 -0700
Made afr inode context a 64-bit packed value instead of a structure.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 686f29b0f78da7961639501e434465b6f74d5496
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Apr 2 08:31:23 2009 -0700
Load balance read operations among subvolumes in afr
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a70589a44cdbefa4dabd31664af9eb530f623d99
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Apr 2 08:30:32 2009 -0700
Defined afr_inode_ctx_t structure.
Notification of a split-brain situation, which was earlier signalled
by the mere presence of inode context is now signalled by
the 'split_brain' member in the structure.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2c4bfbd47d60a9e02d9d74ce4abb3ccac8d03671
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 14:01:05 2009 -0700
io-threads: Support autoscaling volfile options
This commit finally makes the autoscaling feature visible to the user.
Know that we're now using two separate thread-pools, one for data
requests, called ordered thread-pool in io-threads, and the other
for meta-data requests, called un-ordered thread-pool.
We do not expose this information to the user to keep io-threads
simple. Consequently, when the user specifies a min-threads and
max-threads value, the number of threads assigned to each pool
is equal, i.e. both pools start with their min threads set to half of
the option "min-threads" and both scale up their threads at most up to
half of option "max-threads".
Volfile options will be added to the wiki and user-guide.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c5f0ae346f4eb0250e822c0c3edd722fc83df2ed
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 14:00:36 2009 -0700
io-threads: Cleanup request queueing,thread firing
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f05e7caf8ebfe762ccf873405cf5812937f29fe1
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 14:00:06 2009 -0700
io-threads: Allow scaling to be switched off
The default is also to provide no scaling. For both, ordered and
unordered request pools, when scaling is off, we maintain atleast the
minimum number of threads specified in the volfile.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7453fbe0eb4422241382d828f97c6ec798503054
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:59:43 2009 -0700
io-threads: Add ordered threadpool state and code
Now we have the remaining fops going through the ordered
thread-pool.
To route a request through ordered thread, we use
iot_schedule_ordered(..) and the worker thread for
ordered requests is iot_worker_ordered(..)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 13adaf8145d336017f2f9c7e91fa34e7da6bdc78
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:59:24 2009 -0700
io-threads: Add un-ordered thread-pool.
This commit adds everything needed to:
a. Get un-ordered request going through the un-ordered
thread-pool. This happens through, the
iot_schedule_unordered(..). The unordered thread-pool
consists of thread running the iot_worker_unordered(..)
function.
b. Make threads in the un-ordered thread pool start-up
and exit depending on the thread state.
Note that at this point the requests that need
ordering are still going through iot_schedule(..).
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8165e93d7f00e0b6cc80c0e0e64e6fd56ef30c5c
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:58:49 2009 -0700
io-threads: Classify requests for threadpool type
New io-threads will serve requests through two separate
threadpools.
One thread pool for requests that must be ordered
on a file that is open. so that the server can process the requests
in the order they were entered in the requests queue, and not in the order
the io-thread is able to send a request, which in turn is determined
by how the thread gets scheduled. This can also be called the
data-intensive ops thread pool.
Second thread-pool for requests that dont care about ordering, i.e.
requests like lookup, open, create, mkdir, etc.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 689009de5f8e4139e0a2e6d867b4396fbca32a3f
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:58:30 2009 -0700
io-threads: Wire in support for rename fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6f72db403cf96bc9dbb05a479097055b8800d0d9
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:58:11 2009 -0700
io-threads: Wire in support for symlink fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a7f68d6dbd62b4a0f06ff25962f84b33d4856803
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:57:51 2009 -0700
io-threads: Wire in support for rmdir fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f4f4ebdb6a4b0dbb3da89001bad8439c11cc9f33
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:57:34 2009 -0700
io-threads: Wire in support for mkdir fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2f0734348c36274d2947bbdfc1e9c3e2451341b3
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:57:18 2009 -0700
io-threads: Wire in support for mknod fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d4e9df46ad38f60a20b79c5e73f85eb55870b620
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:56:50 2009 -0700
io-threads: Wire in support for readlink fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f234ead5b6e4e900f6758cce7a356acc9469b7a6
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:56:27 2009 -0700
io-threads: Wire in support for access fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 435c005aa08258243fc4055cc288571201effda6
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:56:04 2009 -0700
io-threads: Wire in support for fchown fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0631e52b9d0aef32582b5f48e0f604607ec9bd40
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:55:44 2009 -0700
io-threads: Wire in support for chown
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a42c25980a3dfc7c728bf6bc7d1ceb762c055c2f
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:55:19 2009 -0700
io-threads: Wire in support for fchmod fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9b3f507973ecbc8465b29c8d6c580bfea8267323
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:54:52 2009 -0700
io-threads: Wire in support for chmod fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit fe3f21029668170f261914abbb0fe4c5b44baf48
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Wed Apr 1 13:54:33 2009 -0700
io-threads: Wire in support for lookup fop
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit bfd13517ca512fa3e4ca70bf4057fd74e2f88686
Author: Anand V. Avati <avati@gluster.com>
Date: Thu Apr 2 16:37:37 2009 +0530
wb_flush - keep reference on fd for process_frame to perform STACK_WIND of flush.
This patch fixes bug report by Greg <greg@easyflirt.com> on gluster-users@ with subject 'glusterfsd crash'
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ddfb81025695321f1fa39b9ba88209ed4501008e
Author: Anand V. Avati <avati@gluster.com>
Date: Thu Apr 2 16:49:37 2009 +0530
change char to int in execute_cmd (based on comment on #26006 from Giorgio Marinelli <gio@reversiva.net>
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 23d758c437a28eb3f2a975e1df76eec5b69f3560
Author: Bharat Shetty Barkur <bharat.shetty@gmail.com>
Date: Thu Apr 2 01:41:55 2009 -0400
Changed few lines to ensure Optimization (lesser code).
Changed few lines to ensure lesser code optimization while checking the EOF for the file pointed to by specfp.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 28d6b4c5a2d1fea68fdfe3ba0c727eab565fb3f3
Author: Harshavardhana <harsha@zresearch.com>
Date: Thu Apr 2 02:49:42 2009 -0700
Build fixes for ib-verbs compilation on solaris
Build fixes for solaris on ib-verbs with recent OFUV Update 3 release.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0b60a78070abdcf6cc77e908221440d446bc2c56
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Apr 2 04:05:50 2009 -0700
unify-self-heal: Fix un-ref'ing of incorrect dict
dict_unref'ing of the dict in local
results in a crash due to de-referencing a NULL spinlock.
That is because after a STACK_UNWIND(..), we cannot expect
the frame->local to be allocated still.
Fix by using the other available reference to local->dict.
Ref: https://savannah.nongnu.org/bugs/?26058
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1f12d2c219b12cd72deba1d68aafd6f603a823e7
Author: Vikas Gorur <vikas@gluster.com>
Date: Thu Apr 2 03:39:24 2009 -0700
Print log message when AFR receives CHILD_UP/DOWN notification
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ef3cfabce70428b8df13bb0594fe233212ffaf2e
Author: Anand V. Avati <avati@gluster.com>
Date: Thu Apr 2 15:51:34 2009 +0530
socket_connect() - if socket is already created, do not fail transport_connect() -- causes spurious CHILD_DOWN events to be sent up when reconnect() thread misinterprets the failure of transport_connect() to be an actual teardown of the transport
the spurious CHILD_DOWN events cause self-heal in replicate to not heal files in that subvolume, writev to not modify that subvolume etc, accounting for a lot of discrepencies in replicate which are being in the mailing lists recently.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b480439083819bc793f7df6513dff5ddc3393d74
Author: Harshavardhana <harsha@zresearch.com>
Date: Thu Apr 2 02:50:33 2009 -0700
Fixes server goes into infinite loop on Solaris when poll_err is not set.
Server goes into infinite loop when poll_err is not set.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e094db539987eb5988a6f4134abb608e3556152d
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Apr 2 06:09:56 2009 +0530
mount/fuse to silently send fresh lookup for ESTALEd revalidates. log only in DEBUG level.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit cee63f0858e57f1c84eb4c5e4b103a4868468cfd
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Apr 2 06:09:26 2009 +0530
cluster/stripe to propogate ESTALE to parent.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 97b08fd74a4ba0eacd7df031aba679f97d72a8fd
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Apr 2 06:08:57 2009 +0530
cluster/unify propogates ESTALE to parent translator, if any subvolume returns ESTALE during revalidate.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8c2eb6c617809c1537dfae500b0e97b2b5806053
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Apr 2 06:08:17 2009 +0530
cluster/replicate should propogate the ESTALE error to parent, when at least one subvolume returns ESTALE.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8009044cad299052161dbdcee08a31210b0af509
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Apr 2 06:07:25 2009 +0530
cluster/{dht,nufa} propogate ESTALE (when at least one subvolume returns ESTALE for revalidate) to parent translator.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5fad6c3e0fbdafdef3781d17b9a261d5c12555ee
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Apr 2 06:07:04 2009 +0530
cluster/{nufa,dht} fail revalidates with ESTALE, in case a stale layout is found in inode->ctx.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 43f1731772330a05fcd83c027ad097c7a78a2093
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu Apr 2 01:10:03 2009 +0530
Review comment from Krishna was missed out in previous commit of fix for sending first_lookup in 2nd call
commit 4389dc49cf9a1b0c49483021e799055110a29cea
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Apr 1 21:54:43 2009 +0530
use (fgetc() != EOF) instaed of feof() in parser
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit bdc49a8734c831d84bdbeb5de47e3422466a13ac
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Mar 30 23:36:41 2009 -0700
Bug fix in posix-init(), when span-devices is set above 1
removed the extra '!' in if statement, which was a typo earlier.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1c606d0dacc853000cb98a4e9a82ae028a5499de
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 31 15:49:57 2009 -0700
fix a segfault with io-threads when iot-schedule is called with NULL inode
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 719d076877f4fe0a83f53666d76152b65f4be0c3
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Mar 31 10:56:10 2009 -0700
Enable glusterfs client to exit after a configured number of failed connects \ while fetching volume specification file from server
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c9b521c30102b975de8f2bc76e6d32a1bb5231b5
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Mar 31 11:18:55 2009 -0700
Avoid infinite loop while parsing volume specification files on Linux/ARM.
- patch submitted by anonymous user (ref: bug #26006 on savannah).
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7f3616bb09b43b1f31fdc85ce6c980c29089b1ac
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Mar 31 06:22:16 2009 -0700
Add new type of option type INTERNET_ADDRESS for validation
- used to validate options like remote-host, bind-address.
- Also validate options of translators created during fetch of volume
specification file from remote server.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 36bd985e1c3dfbc0c7549b980d5201619ee75e89
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Tue Mar 31 12:25:58 2009 +0530
log message changes in mount/fuse for SETLK, GETLK, GETXATTR, SETXATTR fops
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a3fe35919ef2487208f6ff83be99372e33be1fc0
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Mar 30 21:14:45 2009 -0700
Add support for log-level NORMAL in fuse mount helper script.
- patch submitted by John Feuerstein <john@feurix.com>.
- copying changes in the patch verbatim to
xlators/mount/fuse/utils/mount.glusterfs.in and
xlators/mount/fuse/utils/mount_glusterfs.in
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 682dea8b9b885dd579dab42cc9584cf015fbf30f
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Mar 28 14:17:55 2009 +0530
first call of fuse is INIT internal call, and not first system call. 2nd call is the system call where first_lookup() has to be done.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0b7abc6d50bf97a46589dde5eef25fbcc86e3cce
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sat Mar 28 00:32:34 2009 +0530
memory leak (of header) when frame is attempted to be xfer'ed when transport is disconnected
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3347f75ba7e3fa97666249632e81c7fd2ade9b5c
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri Mar 27 22:11:31 2009 +0530
ping-pong timer: - share last_sent and last_received between channels so that any activity ensures the remote host being alive (useful under heavy loads) - timer expiry disconnects both transports
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d41d9764289c3db20bc7d5fa924afdeaa8836a71
Author: Anand V. Avati <avati@gluster.com>
Date: Thu Mar 26 17:29:52 2009 +0530
fix duplicate setting of values in inode->ctx and fd->ctx
this patch avoids setting of duplicate key/value pairs in the context.
note that consumers have to explicitly check for previous existance of key
to avoid any kind of resource leak resulting from this overwrite.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 250f15892135e18727c73ec036c7a8e8c25b821d
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Mar 26 08:47:13 2009 -0700
libglusterfsclient: Fix NULL argument bug
inode_ctx_get was being passed a xlator_t type
that was initialized to NULL resulting in a
EINVAL return from glusterfs_fstat.
Reported on gluster-devel
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6f3a4033ad9e3584494375eff80cbb50cc234b18
Author: Anand V. Avati <avati@gluster.com>
Date: Thu Mar 26 16:26:21 2009 +0530
posix_unlink - open/unlink/close only regular files
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a67165643c400cd5d441a1b37c74a7ba1eeffd02
Author: Anand V. Avati <avati@gluster.com>
Date: Wed Mar 25 18:08:43 2009 +0530
Enhancements to distribute selfheal
- create missing directories instead of creating linkfiles when
entry missing on hashed subvol
- detect cases where there are dirs and linkfiles for a name and
make them all dirs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e5cc8be138f40c54cfa4005180e0e0c3447163d2
Author: Csaba Henk <csaba@zresearch.com>
Date: Wed Mar 25 02:19:14 2009 +0100
make the location of the mount utility tunable at configure time
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 38546e9341034f4e46aa1d7d76b63736630a32f8
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Mar 23 05:16:16 2009 -0700
Fixed typo in warning string in afr.c
Fixed typo.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 4beaf753160772c4340bc092fbb1b85266c3dbd9
Author: Bharat Shetty Barkur <bharat.shetty@gmail.com>
Date: Sun Mar 22 13:57:37 2009 -0400
Changed the gf_log warning for return of null via CALLOC from 'old' to 'newdata'
Fixed the warning message to be more clearer for return of the null by CALLOC, by changing old to newdata.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 534874cc14163bd8894427f3e92e44211265d7dc
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Mar 24 03:46:08 2009 -0700
fix to rm of large file blocking other operations on the same directory containing file (ref: rt #779)
posix_unlink follows the below procedure to avoid client noticing delay during
unlink of large file
1. open file
2. unlink file
3. stack_unwind
4. close file
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit be46e9664afe223e7c9f8af0cd9937bec1b4116a
Author: Vikas Gorur <vikas@gluster.com>
Date: Tue Mar 24 05:44:59 2009 -0700
Made self heal logic more precise.
Discard earlier patch sent for the same error. This patch fixes
it more comprehensively.
This solves the spurious split-brain seen by many users.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d75b68362840f0e73ddf56dcabdc0f8826292476
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Mon Mar 23 23:45:53 2009 -0700
dht memory leak fix
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8618b5bee43b5b98a587da76af3c639a6bd70434
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Mar 21 19:04:15 2009 -0700
fixes crash in write-behind
in wb_flush, there was a chance that wb_process_queue()
was called with NULL frame, which causes crash.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c3fcff244b5c9d9532af76f85a0bfa73f69e6ca4
Author: Amar Tumballi <amar@del.gluster.com>
Date: Fri Mar 20 12:50:51 2009 -0700
when the both channels in client protocol is disconnected, fd's are marked as bad
patch solves the problem of fds being valid even in the case of server
disconnection, which causes operations on wrong fd when server comes back up.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 68636698a9e0b7d1a2131a92474605b84ecb17eb
Author: Amar Tumballi <amar@del.gluster.com>
Date: Fri Mar 20 12:49:12 2009 -0700
fixes issue of hashing to wrong subvolumes in case when a subvolume is down
When a hashed subvolume is down, variable 'subvol' was NULL, but was sent to itransform.
This patch solves this, and readdir is sent to proper subvolume now.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6fc2c492c2aed7998aad4eb648fdb53fc37c420c
Author: Amar Tumballi <amar@gluster.com>
Date: Wed Mar 18 18:31:30 2009 -0700
fixed sys_<fops> related warnings. (on mac os x and opensolaris)
The fix in posix will fix 'unresolved' symbol errors in Mac/Solaris/FreeBSD
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2f7b5271038691b19102fafefde5e996c328b369
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Wed Mar 18 17:10:51 2009 +0530
dht_layout_dir_cmp - if xattr is missing, it is an error only if cached layout has entry for that subvolume.
commit 0849752513ac9fdfb1802ce37ffd0ffd3067435f
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Tue Mar 17 21:59:30 2009 -0700
Add return after STACK_UNWIND
We must add a 'return' after a STACK_UNWIND due to a stub creation
failure, because if we dont, we'll end up adding a NULL stub to the
worker thread request queue.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e31647a4613a1d0153c258c75f742d7b4cdb8a2a
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 17 19:05:43 2009 -0700
Moving few translators which are not well tested, are in beta stage to 'testing/' directory.
This way, users will be aware which are in 'beta' stage, and we can keep on
adding new translators (if any) seemlessly to stable codebase and once tested
can move them to proper places.
To use these translators, everyone will have to prefix 'testing/' to existing
type of translator (in volumefile)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9b106cc7798e9abef6017cca5b4138e965e02992
Author: Amar Tumballi <amar@del.gluster.com>
Date: Tue Mar 17 18:15:19 2009 -0700
ib-verbs recv-size and send-size argument takes SIZET arguments now.
With this patch, to specify recv-size and send-size of ib-verbs to <n>KB, we need not give
the option as integer value of 'n * 1024' value. This is neater to do deployments.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit af5d18f5cde9f11f5b20de91dbcd6d01f358c8cc
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 17 16:08:10 2009 -0700
afr data self heal bug fix
fixes the issue of corrupting self-healed copy in AFR
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e441b1b916971e6c30de1be7e0c6e5915f31e5ec
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Mar 16 07:05:33 2009 -0700
IO-threads Cleanup: Remove useless data structures.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 38eed27ec61908560a0298d4f0e09a2c22e61529
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Mar 16 07:04:21 2009 -0700
IO-threads Cleanup: Clean-up request scheduling and queueing interface.
This patch does two things:
1. Cleans up the request scheduling and queueing interface so that all
fops only need to call iot_schedule and not iot_queue and in some
cases iot_schedule.
2. Till now, we've had open and create calls go through the main
glusterfsd thread when sending open and create fops. This patch makes
them also go through the worker threads. But since the open and
creates requests would not be called with a valid inode number in the
loc_t, these requests will get assigned to the worker at index 0.
This will be fixed RSN, when we introduce various techniques of
distributing the inodes(..not requests..) over the worker threads.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c66db810fcdaecd9b9148c5b84cbc0a68ef8a3ff
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Mar 16 07:03:02 2009 -0700
IO-threads Cleanup: Change workers list to dynamically allocated array
Worker threads were represented as a list in iot_conf_t
which made us traverse the list of workers in order to
decide which thread gets the request. Now we represent the
workers as a dynamically allocated array so that we can just index
into the array to schedule the file.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit e114fa76385802684592c5053b3dcaa5151c02cd
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Mar 16 07:01:33 2009 -0700
IO-threads Cleanup: Change request queue into a struct list_head
This patch changes the per-thread request queue from a custom circular
linked list, into the standard list.h list which is easier to
understand and has a cleaner interface.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 03cca33cf1f1d3e353cdeddd8c02521546e5367c
Author: Vikas Gorur <vikas@gluster.com>
Date: Mon Mar 16 04:03:55 2009 -0700
Add system call abstraction layer
- syscall.c provides platform-independent system calls
- previous code for this from compat.c removed
- posix xlator uses new functions from syscall.c
- solaris_flistxattr added to compat.c
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ad54ecc3eb47d0bf5fb902fca32c0006f0f4e127
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Fri Mar 13 01:12:20 2009 +0530
implement forget for cluster/unify
inode_ctx_put() would set a list allocated on heap and would not be free()ed anywhere.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 18e682c3f320c72abe1ee8c711a5ab5d9cb1cc3d
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Mar 12 20:29:56 2009 +0530
unify revalidate should propogate the error from any of the subvolume upto the parent, so that parent sends a fresh lookup.
unify revalidate fails if one of the subvolume returns error.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ca314a212a3fdd1bb3a73dc1aea2083b6cd562e0
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Mar 12 04:41:23 2009 -0700
write behind preserves order of fops with respect to writes
- the execution order of fops like read, stat, fsync, truncate etc whose results
are affected by writes, are preserved.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a35f3d5ebb2116ace12b21cc3fe44aba043bdb00
Author: Vikas Gorur <vikas@zresearch.com>
Date: Thu Mar 12 16:21:51 2009 +0530
Add extra 'volume' parameter to inodelk/entrylk calls
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit dfb9d2ddabfe9c1318a93d46c50b3bc90b1b164c
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Wed Mar 11 18:57:17 2009 +0530
xlator.c option validation should check for empty valid options list (for strings).
'if (!opt->value)' always fails as 'value' member is an array of size ZR_OPTION_MAX_ARRAY_SIZE and is always non-null. it should have been 'if (opt->value[0] == NULL)' instead.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0acf460d94f063b3dde8d56e49f124a2cdb1bcc2
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Mar 9 22:37:57 2009 -0700
feature to span the export directory across different mountpoints
This feature enables exported directory containing different mountpoints.
With, 'option span-devices <n>' where n is number of different mountpoints
export directories can have, one can enable this feature. By default the
number will be 1, and the inode scaling won't come into picture.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d8dbdaf3f73b6dd24a0e7b566889c4c93bdfd2cc
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Mar 10 00:00:58 2009 -0700
ping timer will not timeout if we recently got POLLOUT on the socket i.e if ((cur - (sent|received)) < timeout)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d0358adf5ff52e3ff4580d3d025c5fd5c1498155
Author: Bharat Shetty Barkur <bharat.shetty@gmail.com>
Date: Sun Mar 8 12:54:25 2009 -0400
Fixed two more occurrences of poll_out variables used for logging.
Changed the poll_in variable to poll_out variable at two more places in the code.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 2afe18da7fa906392359796032786f93d4468def
Author: Harshavardhana <harsha@zresearch.com>
Date: Mon Mar 9 10:31:53 2009 -0700
removed word "tla" from last of the remaining files
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5448e845fc47059c69b8670008422c05a51f6f0d
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Mar 10 00:27:52 2009 +0530
failover to any active transport when requested channel is not connected
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 19aaeb08e587bf9814676ae9fcd499a2ca2d06f1
Author: Harshavardhana <harsha@zresearch.com>
Date: Mon Mar 9 03:19:31 2009 -0700
Fixed build problems for init script installation.
Fixed build problem for init scripts (Reported by Krishna and Vikas).
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8d4ce43e2c95b95a8be727757a968d7851ed7773
Author: Anand V. Avati <avati@gluster.com>
Date: Mon Mar 9 16:16:02 2009 +0530
dht_readdir_cbk - retry on same subvol if no entries match the hash
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1d9f8eae1bf8d68712a9fae422d0588fcc561d87
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Thu Mar 5 07:55:43 2009 -0800
changing the conversion specifier from 'd' to 'o' while printing st_mode
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit afd383b2dbdf972b7fff3fc3687dc13a4e9ac4e8
Author: Vikas Gorur <vikas@zresearch.com>
Date: Tue Mar 3 16:00:58 2009 +0530
added fgetxattr and fsetxattr FOPs
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7f3fb700f57a165d685ff6f03697d2c0217e1a49
Author: Vikas Gorur <vikas@zresearch.com>
Date: Thu Mar 5 17:05:35 2009 +0530
fixed deadlock in io-cache
ioc_create_cbk was holding inode->lock and calling inode_ctx_put,
which also holds the same lock.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 1aafb2fb214b03cc974ff1d0a73c4222c9c53820
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Mar 3 02:54:20 2009 -0800
Changed the default transport-timeout to 600
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit df5109795545bebe4b66ccd5e418b88c7d6aa147
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu Mar 5 02:04:28 2009 +0530
disable building of user-guide
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a9c70cef57340d4a47a274e17c6a2e652296f18b
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Mar 4 04:00:24 2009 -0800
code changes in the usage of inode_ctx_get and inode_ctx_put after their implementation is changed to hold inode->lock.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f58ec8bdd5d2465a94ee430107611195af1becd8
Author: Amar Tumballi <amar@gluster.com>
Date: Tue Mar 3 20:13:45 2009 -0800
Change to fix the build problems with bison 1.28 (in RHEL 4.6)
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b899a81322268e0df800124c9b5eaca6f2e6ebbe
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Tue Mar 3 20:10:47 2009 +0530
inode_ctx_t locks added
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 0df57db501a040a6ff82fa6d3dfe890263d10007
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Mar 2 15:47:37 2009 -0800
create fuse thread after setvolume cbk happens, not only in case of success
This patch fixes the 'hang' effect when client protocol fails to authenticate
to servers (it may be problem with volume file, or server process would have
not started yet).
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d16f89850d798c73825892bcb3d356df6c7d8c79
Author: Amar Tumballi <amar@gluster.com>
Date: Mon Mar 2 09:16:45 2009 -0800
changes in patchset and repo version
noticed that if anyone pulls from git repo, the version says 'tla' and
patchset also shows tla's patch.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 537b845544d70afe241506f6c67afb6f0cfedd79
Author: Harshavardhana <harsha@zresearch.com>
Date: Sun Mar 1 05:35:18 2009 -0800
Added proper handling for the init scripts for (Debian, Ubuntu, SuSE, Redhat), SuSE init script also added.
* Init scripts added for Debian, Redhat, SuSE distribution, each are installed
by checking each distribution specific.
Tested on
1. Debian, Ubuntu.
2. Redhat, CentOS.
3. OpenSUSE.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 21f69a21d3888eb8368ff3686fcc3cc821d5b1bd
Author: Harshavardhana <harsha@zresearch.com>
Date: Fri Feb 27 05:03:50 2009 -0800
now user-guide.info is built only when "makeinfo" found
user-guide info is built only when "makeinfo" found
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 82e1a0e143530d69c3318ca773b628aea82575c0
Author: Bharat Shetty Barkur <bharat.shetty@gmail.com>
Date: Mon Mar 2 14:31:39 2009 -0500
Fixed small error regarding the poll_out variable
Changed the poll_in variable to poll_out variable, so that the logging is relevant to the case of invalid poll_out value.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 685d149c3a8e9f92503f015e5e7b294ae855c70d
Author: Harshavardhana <harsha@zresearch.com>
Date: Sat Feb 28 01:49:40 2009 -0800
Fix solaris server segfault in recent "rc3" release.
typecasting from uint64_t directly over pl_inode structure segfaults
are all the calls from posix-locks.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3b516759428243e239ef29c451006e1913b89224
Author: Harshavardhana <harsha@zresearch.com>
Date: Fri Feb 27 10:23:45 2009 -0800
CALLOC changed to calloc in rdd.c and several other cleanup and moved rdd.c into more appropriate "benchmarking" directory.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit a2dbe2e2acb8f7d5f5d327aee153df4b0efe0fb4
Author: Harshavardhana <harsha@zresearch.com>
Date: Fri Feb 27 10:23:29 2009 -0800
Removed unncessary EXTRA_DIST entries and updated benchmarking directory
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8bc6179b08f01e5265b5997abb76c1830210955e
Author: Harshavardhana <harsha@zresearch.com>
Date: Fri Feb 27 10:23:08 2009 -0800
Added /etc/init.d/glusterfsd for rpmbuilds
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit fb4ed912fc949f70b8d8bda8e3a8d473a44b1760
Author: Vikas Gorur <vikas@zresearch.com>
Date: Fri Feb 27 22:35:25 2009 +0530
check for fd ctx set in changelog_needed_post_op for flush() in afr
Earlier the check was in afr_flush(), which caused race conditions
with writev()
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 281e7d05139c63f00a0b36582290c8ab50a0f865
Author: krishna <krishna@guest-laptop>
Date: Fri Feb 27 03:31:13 2009 -0800
send a lookup on root as soon as we get CHILD_UP to fuse.
send a lookup on root as soon as we get CHILD_UP to fuse. This fixes the
case where some of the fuse versions do not send a lookup on the root
directory when one of the "sub-dir" or "sub-file" is accessed just after mount.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 6f4603001017031f192911bef326517a1cae7c15
Author: Amar Tumballi <amar@gluster.com>
Date: Thu Feb 26 08:09:25 2009 -0800
volumefile modification awareness to make sure there are no inconsistencies.
Complete (including feature to properly umount) in my sense.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8a20b1aee034fcbad9dfc26b6427f90ff98e102d
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri Feb 27 10:34:03 2009 +0530
Skip self-heal when subvolumes are down
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d4440932cc33d0f050cf36f70dba181e7bccfc8b
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Fri Feb 27 02:50:48 2009 +0530
fixing warnings in previous patch (typecasting pointer to long)
commit b481b95d1c673e352d402d3212419eccdebf714a
Author: Vikas Gorur <vikas@zresearch.com>
Date: Fri Feb 27 02:14:15 2009 +0530
reverting nested locks in posix-locks for inodelk
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5fbacbc9fb04b1ef09dee92ecf72f26b57915613
Author: Vikas Gorur <vikas@zresearch.com>
Date: Fri Feb 27 02:14:15 2009 +0530
reverting nested locks in posix-locks for inodelk
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit fa77e8d9f9a202b25002d11bfccd0f83afda1e1c
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Fri Feb 27 00:36:23 2009 +0530
moved dht_hashfn_tea() to libglusterfs/hashfn.c as gf_dm_hashfn() (dm - davies-meyer).
moved dht_hashfn_tea() to libglusterfs/src/hashfn.c as gf_dm_hashfn().
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 67a68cacc812b0df55a1413fb8251041e46781b8
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Feb 26 21:14:23 2009 +0530
updated copyright header to extend copyright upto 2009
updated copyright header to include 2009.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 99ba9d6c427e5a454883e5a520bd0a37951a82b0
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Feb 26 20:47:16 2009 +0530
removed unnecessary README.git file
removed README.git file
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 913c831b7ac7be05b63704bb0669f3ace5bb13e9
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Feb 26 20:36:50 2009 +0530
fd->lock added to protect transactions for accessing and modifying fd->_ctx.
fd->_ctx access and modifications are now protected by fd->lock.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit eebfeb75d7d5079ff95825912400dd47ae7648aa
Author: krishna <krishna@guest-laptop>
Date: Thu Feb 26 06:11:48 2009 -0800
Layout is sorted on volume names before forming the layout ranges. But when anomalies are to be detected layout is sorted based on "start" of the range (done in the selfheal during lookup).
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 5b709b8557fcabc449ed1a2a5479ccce348f3b91
Author: Vikas Gorur <vikas@zresearch.com>
Date: Thu Feb 26 17:51:47 2009 +0530
protect fd_ctx get/set in afr_transaction and afr.c with locks
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8728374412141c92a06653d743e91825d15feabb
Author: Vikas Gorur <vikas@zresearch.com>
Date: Thu Feb 26 17:13:25 2009 +0530
Unset fd_ctx in afr_flush if it is set
If fd_ctx is set, it means pending array needs to be decremented.
However, flush might be called many times and it used to lead
to multiple decrements. Fix is to unset fd_ctx on the first flush
received
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit b0b57b3abc5ac0cde62f5de6b7053f70aae2383f
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Feb 26 13:38:33 2009 +0530
__inode_unlink() should not be sent a NULL inode.
unlink_inode might be NULL in inode_unlink() under the following circumstances:
1. 'inode' got forget() and was unhashed.
2. 'inode' was replaced by a new inode object and the new object got forget() or was pruned out of the inode table.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit fb5ad4a365bc2b8f2592aa15fa48376321b4ff0b
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Feb 19 12:39:04 2009 -0800
DHT clean up. Lot of selfheal code is not applicable to newly created directory. Newly created directory will use only relavant part of DHT selfheal code - only for xattr application.
DHT clean up. Lot of selfheal code is not applicable to newly created directory. Newly created directory will use only relavant part of DHT selfheal
code - only for xattr application.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 26f43e0fff5583f9a1de0973556be84c6c84cb2b
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Wed Feb 25 00:47:43 2009 -0800
change MALLOC to malloc
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 4faff5380373faab0084ea333e28f9fca7f26f07
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Feb 24 06:55:39 2009 -0800
DHT selfheal fix during lookup - create missing directories.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 744f62c40cfe293dcf541b1ef521335da2f00568
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Feb 24 06:53:21 2009 -0800
Ping timer does not timeout in case there is any activity (cbks) from the server side.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 276b6e9dae161f6852c759e1c72e45c74d53ce11
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Feb 24 06:52:55 2009 -0800
per frame time out - i.e individual frames are unwound instead of the transport point itself being disconnected. timeout is configured using "transport-timeout".
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 9898572b868f6783af0da9841403de5478a21d96
Author: Raghavendra G <raghavendra@zresearch.com>
Date: Tue Feb 24 02:42:41 2009 -0800
backtick support enhancement
- text within backtick can span multiple lines
- check exit status of command after execution
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 3f256b5ea02e8bd58e924a4e144a3d211b9d0bcf
Author: Anand V. Avati <avati@gluster.com>
Date: Mon Feb 23 17:18:53 2009 +0530
DHT TEA hashfn bugfix
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit f00f57bf170fb26cb592170133943878a443697c
Author: Vikas Gorur <vikas@zresearch.com>
Date: Mon Feb 23 19:36:26 2009 +0530
Deleted xattr caching code from posix in anticipation of the xattr-cache translator.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 549b3a0d4ab1af71c48e99277a7e54d453af1840
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Mon Feb 23 05:48:14 2009 -0800
RE-SEND: Add braces around critical sections.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c311ef9ccc963fd78161156e965fd6ae174e628e
Author: Vikas Gorur <vikas@zresearch.com>
Date: Mon Feb 23 02:33:11 2009 -0800
added lock_notify and lock_fnotify FOPs to everywhere necessary in libglusterfs/*
fixed indentation and resubmitting
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 8bbd86bcf47148f826b1b44b46d30286d18cae91
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Sun Feb 22 11:29:05 2009 +0530
posix_releasedir flush fds from xattrcache.
It would have entered cache in setdents.
Proposed fix for: http://zresearch.com/pipermail/gluster-users/2009-February/001621.html
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 7f1f1b49815cdc920dd074a7886e8bee97c18917
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Sat Feb 21 15:27:03 2009 +0530
removed to 'option cache-size <size>' in example volfiles for io-threads.
io-threads translator does not take 'cache-size' option now. so removed all
references to 'cache-size' option for performance/io-threads.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 14fa8f742c192c0c0147c5669b60949c382fc7b4
Author: Amar Tumballi <amar@del.gluster.com>
Date: Fri Feb 20 18:09:02 2009 -0800
default volume file option enhanced in server-protocolg
Noticed that with current codebase, there is no proper method to have a default volume filename to choose in getspec() without printing a *lot* of warning messages. This patch tries to have a proper 'default' behavior.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 42bae99e110cdfa28b24450495408c44a70a5e42
Author: Amar Tumballi <amar@gluster.com>
Date: Sat Feb 21 13:50:01 2009 -0800
change to make round robin dns work for getspec()
Noticed that if I have just 'socket' and not the address-family, the
round robin dns for '-s' option doesn't work. Changing it to 'tcp'
works.
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit ae826ea284823212a80dea16283f8e419e581d16
Author: Harshavardhana <harsha@zresearch.com>
Date: Thu Feb 19 04:59:29 2009 -0800
command line and mount/fuse now use float attr/entry timeouts
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 63ac3df56dac7276f9319d9ed1959c753c8daeb6
Author: Harshavardhana <harsha@zresearch.com>
Date: Thu Feb 19 04:59:06 2009 -0800
attritbute and entry timeout values under volume now support float/double values
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit 41a2af15aa89bc7b957692bedb3db59b6a564a71
Author: Harshavardhana <harsha@zresearch.com>
Date: Thu Feb 19 10:34:28 2009 -0800
new function gf_string2double for float/double values
fixed warning
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit d349f0b80204f0d8485ed01b195cb821a84feaf4
Author: Harshavardhana <harsha@zresearch.com>
Date: Thu Feb 19 10:26:17 2009 -0800
new functions dict_{get,set}_double for float/double value
fixed warning
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
commit c57beeb74cc08c47c18164112eaf54e8d3ed145b
Author: Amar Tumballi <amar@del.gluster.com>
Date: Fri Feb 20 09:37:13 2009 -0800
fix to remove ''input' defined but not used' warning in building glusterfs
needed to complete the build scripts without warnings
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit fb05942c2112667c5d2b193f96d38c3ce424914c
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Feb 19 05:21:47 2009 -0800
Reduce iothreads requests queue lock granularity.
iot_queue() and iot_dequeue() functions were using a io-threads
translator-wide lock which would be contended for by every worker
thread waiting for IO requests.
This patch reduces the granularity by turning the
lock into a per-worker lock.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 01a45fce4d38b836458ca20babc54d3732862180
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Feb 19 05:20:41 2009 -0800
Remove conf->cache_size checks
Since we're not dependent on this io-thread internal state(i.e.
cache_size and current_size) to rate limit requests, we can remove
these two data members and code that checks for these.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 1b73aa7b55f0609aea2168ea87c6a04c0daa1edb
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Feb 19 05:25:44 2009 -0800
Remove dead code.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 945310c85eb4be3bd980a5d6441f8b99b66d7034
Author: Basavanagowda Kanur <gowda@gluster.com>
Date: Thu Feb 19 19:38:57 2009 +0530
cluster/ha to handle EBADFD for fd based operations as transport disconnected.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 9ca544312c9f3b114fa40a3cf6af0f74944c547c
Author: Vikas Gorur <vikas@zresearch.com>
Date: Thu Feb 19 04:26:47 2009 -0800
warn on ERANGE error for lgetxattr in posix
(amended to fit in 80 columns)
ERANGE is usually caused by the user reducing the number of AFR's
children but continues to use the old backend.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit cfac6316f8eb124c06cbedba01355ed02764d4c1
Author: Shehjar Tikoo <shehjart@zresearch.com>
Date: Thu Feb 19 02:26:40 2009 -0800
Fix the order of CALLOC() args
Fix the order of CALLOC arguments.
Signed-off-by: Shehjar Tikoo <shehjart@zresearch.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit fbf6a48f53eec99cc1e24dc67c0cffabd1662080
Author: Anand V. Avati <avati@amp.gluster.com>
Date: Thu Feb 19 02:04:17 2009 -0800
updated commit.sh
changed commit.sh for git usage
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 9b474ad14e90d6c469c7e533dcf8454380d850e9
Author: Vikas Gorur <vikas@zresearch.com>
Date: Thu Feb 19 00:18:28 2009 -0800
added lock-ahead translator design document
Design document for the lock-ahead translator
Vikas
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
commit 1d9a1e4f68e0de96bdb91cbcc2dc55817f2fb1b1
Author: Vikas Gorur <vikas@zresearch.com>
Date: Wed Feb 18 17:36:07 2009 +0530
Added all files
commit f18629bfa76cc216d6927d792ac1baec0b1d38a1
Author: Vikas Gorur <vikas@zresearch.com>
Date: Wed Feb 18 17:01:30 2009 +0530
Initial import
commit 250af877c1eb1edff2b80ac94b335cc23500fb94
Author: Amar Tumballi <amarts@redhat.com>
Date: Fri May 5 13:22:49 2017 +0530
Rebase to git, initial import
commit 1abc7dda47e3b7e88a2630f4ac2ad7a1e7019f16
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Feb 18 09:07:14 2009 +0000
* minor error fix in previous commit (patch-926)
commit 24549f05870107afa9b38f9aba92f26db9884005
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Wed Feb 18 07:42:18 2009 +0000
fixes server segfault when dentry is NULL for corrupted backend
* Issue seen at IGCAR, when an application installation on a corrupted backend
failed resulting in server segfault during unlink,rmdir.
commit 8f8710bab95f6e1516e47fdc5bc1971ba00142ec
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Feb 18 07:33:22 2009 +0000
* posix fixes.
Thanks to Fred Hucht <fred@thp.uni-due.de>, and Filipe Maia <filipe@xray.bmc.uu.se>
Fixes write in case of O_DIRECT.
handles 'mandate-attribute' option properly.
commit 2264c330210d6ae7d830051cd00d44ad0f623f2b
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 17 11:04:36 2009 +0000
commit on behalf of krishna
commit 42d02196e2f62dacc1773ac7f58387722c6c011a
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Feb 17 09:49:25 2009 +0000
cluster/distribute bug fix
* cluster/distribute:
- store transformed inode number in local->st_ino (for directory lookups) and
return the same inode number during STACK_UNWIND().
commit 0f74827f41039b169b1bd818be9cc1aed61e0c75
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Feb 14 20:18:33 2009 +0000
send the file content through xattr dictionary during lookup only
if (req_size >= file_size);
commit 84e656cedd5bf5d5011c8f7581576916b9f3b0f7
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Feb 14 20:06:59 2009 +0000
bug fix in glusterfsd.c, changes in libglusterfsclient.c
related to change of inode->[_]ctx from dict to array
* glusterfsd.c: assign glusterfs_ctx to fuse_xl->ctx when the
volume specification file contains fuse translator.
commit 0dd1dd205cb11f91dd0d93a3031825fc91f6fac5
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Feb 14 19:49:58 2009 +0000
fixes in libglusterfsclient.c and glfs-bm.c
* libglusterfsclient.c: set_global_ctx_ptr in glusterfs_init
set ctx->process_uuid in glusterfs_init
* glfs-bm.c: use absolute pathnames for files used for benchmarking.
commit 0dc4a9bca958f6c082d8f650a7d7ea66fe81d377
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Feb 14 14:50:01 2009 +0000
mem leak fixes in posix-locks
- destroy the reqlock of inodelk F_UNLCK
- free pl_inode in pl_forget() (previously dict based ctx used to destroy implicitly)
- 0-byte req_size fixes in _posix_xattr_get_set (used to result in calloc of 0 byte etc)
commit 1eeea630c82eb054137da12ad3f4fb5ca73f97b7
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Feb 14 16:07:11 2009 +0000
libglusterfsclient build warning fixes.
* fixed build warnings surfaced due to change of need_xattr argument
of lookup from integer to dict.
commit b560ae40d271da568970d68aaec4cf7c37c0e1fd
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Feb 14 14:07:40 2009 +0000
open-fd-count support in posix and afr to skip self-heal on open files
commit 2eb553e81988906b03abdfdac7e71908edbe638e
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Feb 14 13:36:23 2009 +0000
added ftruncate fop in afr data transaction
commit fffff856283b9d5c0cc046c08ae1996964f6d389
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Feb 14 02:48:01 2009 +0000
fixes in afr and xattr-cache
- use local->op instead of transaction type to decide whether post/pre op is needed
- few fixes in xattr-cache.c (posix) which was otherwise segfaulting
- flush all xattr cache in flush()
commit d6cf1e4564f2d9cb72b2ffd4c1b212e4020f1c2e
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Feb 13 17:58:28 2009 +0000
fixed typos in client protocol
commit 8f0b12a0fffa854db4a059c3c8a722a518b9ad83
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Feb 12 17:10:28 2009 +0000
* Added 'fd_ctx_set()' and 'fd_ctx_get()' APIs (similar to inode's get/put)
fd->ctx still exists (but not used by any xlators) as its used by
libglusterfsclient.
commit 8a93162be6e70088bd0dbd769e735c8fbe7a99b6
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Feb 12 15:04:15 2009 +0000
multichannel support in protocol
commit 804eb88f743eb9b823acc74449333daa3c2fa407
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Feb 12 07:44:23 2009 +0000
flush xattr cache in some places
flush xattr cache in:
rename()
unlink()
rmdir()
setdents()
commit 2788cbe8b1fb489aff6963e93ae16843b119f2e9
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Feb 11 21:54:16 2009 +0000
* lookup API changes done in cluster/map
commit e14295510980df75feb1d058e7e3424e0e036e75
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Feb 11 10:12:50 2009 +0000
rewrote xattr cache
xattr cache is now of a fixed size, and entries are flushed as new ones
arrive
afr: erase changelog in afr_flush only if fd->ctx is set (which means a
previous write has written changelog)
commit 299ca17ea74f0a65a9e7013cfdc20fce689b79ee
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Feb 11 05:43:49 2009 +0000
replaced need_xattr argument of lookup() by xattr_req dictionary
* changed int32_t fop_lookup(call_frame_t *frame, xlator_t *this,
loc_t *loc, int32_t need_xattr);
to
int32_t fop_lookup(call_frame_t *frame, xlator_t *this,
loc_t *loc, dict_t *xattr_req);
* made relevent changes in all the translators as well as libglusterfs to work
with changed lookup() call.
commit aa9eef9e1fa65055497969a76ec5ac412dafa292
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Feb 10 07:33:35 2009 +0000
mount/fuse bug fix
* mount/fuse:
- fuse_create_cbk() should do fuse_create_reply() only after doing inode_lookup().
previously fuse_create_cbk() was doing fuse_create_reply() before doing inode_lookup(),
this resulted in fuse (kernel) sending a forget() on an inode which was not looked up
by mount/fuse. (because of race)
commit d41e33d1db32de41365b46d8571525347cb04958
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Feb 9 23:10:12 2009 +0000
* fix for ptr corruption in inode_ctx_get() in case of 32bit machines.
* possible memory corruption fix in ioc_lk() (in io-cache.c)
commit 1aebab89d414d71b5f8dfa08120d1d70c5e94860
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Feb 9 14:28:12 2009 +0000
cluster/distribute mkdir returns inode number from hashed subvolume.
* storage/posix:
- warning fix for inode_ctx_get.
commit 9ebd1867e83cbad9ba4524592c62752bf49fe539
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Feb 9 09:57:29 2009 +0000
performance enhancement in afr
write changelog only on first writev() on an fd and erase it
on close()
posix: flush the xattrop cache on revalidate
commit dfcee80b090c0f519d984ba078f91e00bcc2b912
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Feb 9 06:59:14 2009 +0000
* changed 'void **' in inode_ctx_get() API to 'uint64_t *' to make sure
things work fine on 32bit machines too.
commit 9b8f3663efaeba8d0230d66cf90133adfe7d058c
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Feb 9 06:30:40 2009 +0000
rewrite of backtick support - shell commands enclosed in backtick can be present in any part of
configuration file, fixes in booster
* earlier backtick support permitted shell commands only in the value field of "option key value".
This patch adds pre-processing stage before the actual parsing where the commands are executed and
their output replaces the commands in volume specification file.
* changed the key "user.glusterfs-booster-specfile" to "user.gluster-booster-volfile" which was used to
get the volume specfication file in booster.c
commit 8e0e86f3df9ef57f963cff102c76436e0bd04289
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Feb 8 17:23:16 2009 +0000
* inode_ctx_get () and inode_ctx_put () APIs for translators to set and
get translator specific information in inodes. its no more a 'dict_t *'
so the performance is increased a lot.
commit f3f996651758afa9474161b6a47579760170c48c
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Feb 7 10:21:10 2009 +0000
* fixed a warning in client-protocol (in 64bit machine)
commit fe8bc278c08b0a298b289b3e4481d6f011a8ab72
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Feb 7 03:25:40 2009 +0000
* Default log level set to NORMAL
* Upon successful starting of GlusterFS, a msg is logged about the same in NORMAL level.
commit 05c086a1d7786327374fa6334cff7e19a2efbc7c
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Feb 6 20:02:04 2009 +0000
* fixes the Savannah bug #25506
commit 2b0d34ef01d518c3653086bb45debad43c5a294c
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Feb 6 12:21:30 2009 +0000
fixed corruption in posix
xattrop was setting the return value in the dict which would
later be freed by server-protocol. Now it copies and sets it.
commit 825191ceba27c4d321be6680ac328a99ddcba885
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Feb 6 08:44:40 2009 +0000
reverting back setting of cprivate->ping_started = 0, in client_ping_cbk
* no need of setting it to 0, since a timer would've been registered, which on
expiry executes client_ping_start, which in turn sets it to 0, if there are
no saved frames. Also, changes related to ping in patch-896 affects proper
working of ping as discussed with krishna. Hence reverting back those changes.
commit cbbcbad7ee880232cdca8e87aa5ab22f5c0e4e81
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Feb 6 05:56:56 2009 +0000
reapply patch-890, fix deadlock in pl_inode_get, bug fix in client-protocol.c
* due to misplaced label "out", pl_inode_get used to return with inode->lock held,
whenever there was already a pl_inode set in inode->ctx.
* reset cprivate->ping_started to 0, in client_ping_cbk.
commit b939981eff075ecfc4ff2b0032f699f5e8e35f1a
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Feb 5 14:21:51 2009 +0000
fixed typo in posix.c
commit e87205b6430781d76610564f9ce5cd39dc53ab09
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Feb 5 13:53:52 2009 +0000
implemented xattrop caching in posix
xattrop's are done mostly in memory now, with the
final flush only happening on close()
informal testing shows nearly 2x improvement in write
performance (dd)
dict.c: fixed a deadlock in dict_get_with_ref
(was calling data_ref with lock held)
commit 4d934ea7eb076ca646642919f6d7539f44a4fba0
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Feb 5 09:24:38 2009 +0000
previous fix was spurious, reverting 890 until cause of deadlock is found
deadlock happening between fd_* functions and pl_inode_get. Reverting
patch-890 until cause is found.
commit 78239591ce43844daae647b58026dcb173497df6
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Feb 5 06:37:19 2009 +0000
fixed deadlock in locks
pl_inodelk_common was holding lock and calling
delete_locks_for_transport which was also trying
to hold the same lock
commit bcd2af68d18e111fc17c583a9cea54529c118b07
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Feb 5 00:16:34 2009 +0000
* added map to the code base.
commit 390916dc90c00c1f4b2f12b2bb717eff4683d7bd
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Feb 4 07:31:11 2009 +0000
fixed race in posix-locks
pl_inode_get was doing get & set on inode->ctx w/o holding lock
commit 44cea081335a2fa77ecd5e15c0661928bfb78cf4
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Feb 4 06:52:15 2009 +0000
fix typo in transport/ib-verbs/src/name.c and transport/socket/src/name.c,
define macro NO_CONTENT_TYPE if it is not defined in mod_glusterfs/apache/2.2/src/mod_glusterfs.c
* ceiling was misspelled as cieling.
* only httpd >= 2.2.8 has NO_CONTENT_TYPE defined in httpd.h
commit e1c41b58c6e731229746e2c77460fd9b70631b0e
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Feb 2 23:44:35 2009 +0000
* changed tmp_loc to local->loc, and used loc_copy()/loc_wipe() in trash.c
* write-behind option fixes. in init(), it was looking for old options,
where as the dictionary would have contained new option string.
(savannah bug #25470)
commit c6c44a4d7db068fa78f850895287adf2b003bb6a
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Feb 2 13:32:40 2009 +0000
logging aesthetics enhancements in glusterfsd & libglusterfs/common-utils.h
commit e4219cd2dd85b4f1c2f5eede94aa0e5d909b3b85
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Feb 2 09:28:51 2009 +0000
made [f]inodelk locks nested
[f]inodelk locks have 'nested' semantics, instead of the earlier
POSIX semantics. This means overlapping locks are not merged, and
have to be released separately
commit 0c0c46d76fef7dc3ac4e1a36f1995476260fef80
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jan 31 05:09:58 2009 +0000
fix to set atime/mtime in setdents -- Filipe Maia <filipe@xray.bmc.uu.se>
commit bc029d9e0be6467521b6b4bd205f15446e9474cf
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Jan 30 15:40:02 2009 +0000
ping timer cleanup.
commit ecd87c5802b4698ac724ccd66dd4f9bf354b0d30
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jan 28 16:09:31 2009 +0000
Removed slow op related code. ping timer uses saved_frames->count to decide if timer has to be stopped. slow ops and regular ops use the same transport timeout which will be a huge number. network disconnect is taken care by ping timeout.
commit aae8175d2f4f6b53db0e52992d197df274d38222
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jan 28 14:54:16 2009 +0000
ping timer changes to client/server protocol. Client ping server every 'x' seconds. This cehckin does not remove slow_op changes and uses cprivate->op_count. Next checkin will remove slow_op changes and use saved_frames->count to see if there are any frames in transit requiring ping timer setup.
commit 0b7362ead0582db6154d5ab0da1d66f729e6f07a
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jan 27 01:47:15 2009 +0000
truncate fixes in quota calculation
commit 3104d047e684c67ba091dc785e1bf5a40d90cc7d
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jan 26 23:51:35 2009 +0000
quota to sync xattrs to backend on every release()
commit 283d352222b5a566f1cd0c8082beca7d58396b4e
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jan 26 20:49:39 2009 +0000
minor quota fixes
commit de159bdc110227033c924f85c0b998c2eb8c5e42
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jan 26 18:16:59 2009 +0000
afr self heal files with holes (of 64K)
use case is for healing files properly when afr is used below stripe. hardcoded 64KB hole check should usually work fine for this use case. 512byte hole size support (without sacrificing large block IO) will be done in the future.
commit 96aa9d5c0dc7d4c00ff0477c9f14b8319599097d
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Jan 25 05:34:59 2009 +0000
cluster/distribute fix
* cluster/distribute:
- fresh lookup() to return transformed inode from hashed subvolume.
commit e3c06f2dca56ea685491dadc075d697e8fe388d7
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Jan 23 22:14:12 2009 +0000
HA warning fixes for 64 bit.
commit 3a72166338ec418f5413679ae939215fc51d45dd
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Jan 23 21:51:06 2009 +0000
HA bugfixes and cleanup. Remaining issues mentioned in TODO in ha.c
commit d8f570f8a9a4e6ad833165f6535e7df9063c1f91
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jan 23 20:15:43 2009 +0000
uncomment fini calls in cleanup_and_exit (for sake of quota xlator)
commit e0ff528f608a013f2a246b3759856da39e8f9f3c
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jan 23 11:32:57 2009 +0000
documentation update for mod_glusterfs
* added mod_glusterfs/apache/2.2/src/README.txt
* proper spacing and indentation to mod_glusterfs/apache/2.2/src/mod_glusterfs.c
* update mod_glusterfs/apache/1.3/src/README.txt
commit 73cc81e0cf7b048a93c5425c544c2c7c5b601ed1
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jan 23 05:51:50 2009 +0000
On lookup dht returns ENOENT for those files whose hash value does not fit in the layout.
* one of the reasons for hash value not falling in the ranges defined
in layout is incomplete layout in the parent directory.
* mod_glusterfs.c: change CALLOC to calloc.
commit f792514a90f6b169e3478bb8008fec6881c6d755
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jan 22 20:53:54 2009 +0000
quota, posix logging and fuse logging enhancements
commit 5732aee55fe8c9413377fe6fbbd55c93f5178e90
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jan 22 18:07:18 2009 +0000
Fixes in ensure_file_type and same_file_type() in posix, found by Filipe Maia
commit 67c7a1c45832c774248ead0155c183492ceda8fc
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jan 22 17:19:38 2009 +0000
dht_selfheal_dir_xattr: condition to count call_count and condition to do stack_wind were different
dht_rename: fixed unused variable warning (layout)
dht: indentation fixes
commit 12ae886deeb4cff8b98c2388605ebd52c7de1bdf
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jan 22 16:41:22 2009 +0000
revert dht_rename() fix from previous commit, dht_revalidate_cbk() fix
* cluster/distribute:
- reverted dht_rename() fix from previous commit as it is useless. reason: newloc->inode
is discarded after inode_rename().
- dht_revalidate_cbk() will fail revalidate with ESTALE, if it encounters a linkfile.
commit 6d05469b87a2b40182c72a2242151aa6f372b4e4
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jan 22 15:26:29 2009 +0000
cluster/distribute bug fixes
* cluster/distribute:
- dht_rename() should change layout stored in inode->ctx, after rename across
subvolumes.
- renamed dht_layout_mismatch() to dht_layout_dir_mismatch() as it only checks for
directory layout mismatch.
- changed non-serious log messages to GF_LOG_DEBUG.
commit ac3d396bf7610c2f8543c92b2fae852362e64991
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jan 22 08:43:13 2009 +0000
fix in dht_layout_mismatch() - added missing goto for error check of dict_get
commit 13060cc132c67851ebe458b587def4490823c299
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jan 21 14:27:05 2009 +0000
multiple fixes (dht, nufa, glusterfs-mode.el)
* glusterfs-mode.el:
- added transport-timeout into list of valid options.
* cluster/{dht,nufa}:
- set need_xattr = 1, while sending revalidate.
commit 28d727d69940690b9498a75833f41839a1725596
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jan 20 19:52:10 2009 +0000
dht_revalidate_cbk - was passing local->layout to dht_layout_mismatch which would be NULL
io-cache - fix race in cache revalidate (previous commit)
commit 7b9ec9077e8ec10c725d3afc6d398b474a83bb1e
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jan 20 18:43:32 2009 +0000
NUFA - use hostname of the runtime machine as the default local volumename
commit 160c923667f7370462d5a20abea95de315c317f5
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jan 20 13:18:42 2009 +0000
protocol/client memory leak fix (introduced during logging enhancements)
commit 680143ee597fdbac33c512a8e4d00736e20a1f43
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jan 20 11:54:10 2009 +0000
bug fix in libglusterfs/xlator.c
* libglusterfs/xlator.c:
- _volume_option_value_validate() used to accessed beyond the opt->value array
limit for GF_OPTION_TYPE_STR case. changed appropriately to fix the bug.
commit 39909922452533713d47b182a69026ca481dc302
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jan 20 11:21:44 2009 +0000
modified glusterfs.spec.in to include user-guide.info
commit c49c4ad5e5a620339121e313150522c14e77938f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jan 20 10:20:09 2009 +0000
protocol/server logging enhancements
commit 14b3157954a6aefbbf40ea70c194d3f659f363e4
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jan 20 11:19:13 2009 +0000
fix to segfault in fuse notify due to improper volume specification file.
* If the namespace node has a parent, unify does not store the
pointer to it in the private structure. This results in the
propagation of GF_EVENT_CHILD_CONNECTING from the ns brick
to fuse through unify even before fuse init has been called
resulting in segmentation fault. As a fix, unify init exits
returning error if ns has any parent.
commit 859fdf26a5a1b35b566b377c92f7f8d2405168ab
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Jan 19 14:04:40 2009 +0000
logging enhancements in protocol/client
commit bb8cdd9f5c321f706abceab66416fd425a6dce0d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jan 19 12:49:36 2009 +0000
updating documetation of write-behind.
* updated volume spec file examples and translator-options.txt to
contain enable_O_SYNC and disable-for-first-nbytes.
commit 688fa229a3a64048b0e84dd5e948f97e5bff2fc6
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jan 19 06:47:10 2009 +0000
nothing was committed in patch-853. committing the changes explained in 853 in this patch
commit c1c60c8bd9d7480bb3ecd2f82e40f0668721cb0f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Jan 19 04:59:21 2009 +0000
cluster/distribute bug fix & storage/posix build warning fix.
* cluster/distribute:
- return -1 if in-memory layout mismatch with the on-disk layout during revalidate.
* storage/posix:
- changed S_ISLINK() to S_ISLNK().
commit 47c1acdc094b3993296af4f8f9f7045be476ef00
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jan 19 06:19:20 2009 +0000
removing the dependency of flush-behind on aggregate-sizes.
* flush-behind was being disabled if the aggregate-size was positive.
This was done to avoid race conditions b/w close and last write in afr.
with fd_ref/unref mechanism this is no longer necessary.
commit 0f6925b01a09e5550f2e7c6ff2df2cf597408c7e
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jan 18 19:30:36 2009 +0000
posix_setdents fix (do not chmod for symlinks) by Filipe Maia <filipe@xray.bmc.uu.se>
commit 5686894adc911c1167d16ebfcae9f1ed233fabc7
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sun Jan 18 18:36:38 2009 +0000
added options "disable-for-first-nbytes" and "enable_O_SYNC" to write-behind.
* disable-for-first-nbytes - this option disables write-behind for the first
configured number of bytes. This is expected to
boost performance for small-files.
* enable_O_SYNC - this option when enabled, honours O_SYNC flag to open/creat
and disables write-behind for the fd.
commit 19bce1b5fd6a4827c17eed093ec1b1696b2881dd
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Jan 17 15:46:04 2009 +0000
updation of documents in doc/ directory
* renamed all afr.<extension> files to replicate.<extension>. also changed reference
to cluster/afr to cluster/replicate.
* configured the build system to include user-guide.texi into texinfo. now 'info glusterfs'
gives the user-guide.
* updated all the example volfiles to use only valid translators, transports, schedulers
options.
* updated translator-options.txt file to list all the options in the form of a simple table.
commit 4174c13ba8ea81f3b3c7523b85c0b4810139ab7e
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Thu Jan 15 12:36:45 2009 +0000
Fix in configure.ac for FreeBSD related builds
commit cd72ac9cb6eafb23cf5f0daa805b4b008d9addb3
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jan 15 07:18:16 2009 +0000
build booster only if libglusterfsclient is enabled.
commit e2fe63f4f512677cb0e5a5dcf23cf6cd2ededc18
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jan 14 19:59:17 2009 +0000
log messages to indicate successful connection and disconnection, based on patch from Corin Langosch
commit 4bd6ba263eed5b9ee960651dd0d6e38ac191eaaf
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jan 13 07:10:58 2009 +0000
name procedures in socket/src/name.[ch] and ibverbs/src/name.[ch] appropriately
to reflect the transport they are dealing with.
* with both files having procedures with same names, there were conflicts
in resolving remote/local socket addresses.
commit 3ba72c7290d02a365df114ec1f6a81ce0763177c
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jan 13 04:48:56 2009 +0000
* removed warning in dht, nufa about different type of argument
commit ec964ab7e35ef9e1cd5252bcd639212da593d607
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jan 12 19:01:23 2009 +0000
- option name changes in write-behind (block-size/aggregate-size and cache-size/window-size)
- changed some logs to DEBUG level
commit fc72ef0d56ab1e4fa526cefbb7a407d759fe546b
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Mon Jan 12 18:03:34 2009 +0000
tv_nsec related proper checks and cross platform fixes
* Added new macros ST_{A,C,M}TIM_NSEC,ST_{A,C,M}TIM_NSEC_SET. This removes
unnecessary #ifdefs at some locations.
* configure.ac updated to properly check for struct stat using AC_CHECK_MEMBERS
macro from autoconf itself.
commit b7108055111e19df59d5a91fe10c782f0addafa4
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jan 9 05:03:09 2009 +0000
* updated 'trash' translator to keep deleted files with 'timestamp'.
so there will be no overwrite of deleted files.
commit 2bb74bd1978aadea3b35d2282dc19e0a0cb5ba4f
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Jan 8 12:09:18 2009 +0000
ha statfs was returning ENOTCONN if lookup was not done on /. i.e "df" done as soon as glusterfs was mounted.
commit 5769794ed1cbb4938db1aad41d7bc8152515af0f
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jan 7 10:53:52 2009 +0000
reimplemented hash function in dht
+ indentation fix in event.c
commit 44bacec7b0819b6bb377b9d6d438f0870d272615
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Wed Jan 7 08:13:08 2009 +0000
Proper checks for st_atimespec at configure level and respective modifications under the source files.
* HAVE_BSD_NSEC a new #define used in case for tv_nsec on BSD platforms.
* Also backtrace contains the "tv_nsec bsd 1" to make us understand that
it was BSD machine with st_atimespec struct.
commit 39813bb4cb9756f991de5439d598d2ea57d05bbb
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jan 7 07:47:47 2009 +0000
DHT mkdir is tried first on hashed subvol. if succeeds we create mkdir everywhere else return error. This avoids race between multiple clients issuing mkdirs. This also avoids a serious condition that can arise during split brain situation and same directory is created.
commit cfb2ad1cad9990118f82f399d162f6776822f68a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jan 6 19:59:28 2009 +0000
When lookup failes with ENOTCONN or when hashed subvol is down, the entry has to be looked up on other subvols to see if it is a directory.
commit 03c9c1bdd1d0b33432a2793314495b0484cb1cb1
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jan 6 18:21:27 2009 +0000
fuse_getattr reorg
permit fstat to happen even when fuse_loc_fill fails (tail -f on deleted file)
change inode_path internal gf_log to DEBUG
commit bb1e1d6fb48ccebf7dfe78a24fbd01a59afc82c2
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jan 6 16:12:41 2009 +0000
afr self-heal files in 128k block size
commit 11d987de83d27a9379225e7ac3555242035c7539
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jan 6 16:04:09 2009 +0000
list.h reimplement
commit fdb79f1dfe66cc55d29b6b801e5b13676937c415
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jan 6 06:33:03 2009 +0000
introduced support for replicate & distribute.
* cluster/afr:
- cluster/afr can also be used as cluster/replicate in volfiles.
* cluster/distribute:
- cluster/dht can also be used as cluster/distribute in volfiles.
commit 5c20515f31f4ac6550d8bebb1925bbc210c0a021
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jan 6 04:25:31 2009 +0000
bugfix in afr_lookup_cbk introduced in patch-795
overwrite the local->stbuf _after_ doing the self-heal checks
commit 84736cd22984c1820c4031ce592bf6ccb22ba110
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jan 6 03:15:44 2009 +0000
fixes in afr self heal
make sure self heal does not source 0byte files created by dir self heal of parent dir
enable metadata selfheal by default
disable metadata changelog by default
commit 3e00d6f839dd89abe3efa8b3d2e2e383b17be56c
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Jan 5 12:11:51 2009 +0000
glusterfs looks for CONFDIR/glusterfs.vol or CONFDIR/glusterfsd.vol based on how it is invoked, instead of hard-coded CONFDIR/glusterfs.vol.
commit ab533d37bccc7a86cbb5e7dbe8360e131cc3cf83
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jan 5 08:38:41 2009 +0000
* moved strnlen outside SOLARIS part, and included it inside
#ifndef HAVE_STRNLEN part in compat.{c,h}
* added extra check in posix_lookup () to return ENOENT if stat's
'st_dev' value differs from that of exported directory. This is
helpful in stoping duplicate inodes from same volume.
commit eaac2f8eb31dfef8b2eb9fdcab42b336bb11b0f3
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jan 4 23:41:55 2009 +0000
* xlators/cluster/map:
- map_readdir now copies lot from dht readdir
- all helper functions moved to map-helper.c
commit 1e3e1f06700827472a00ff897dd65c434df6f0f1
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jan 4 08:57:07 2009 +0000
* removed 'xlators/cluster/nufa' from tla
* added 'dht-common.c' which was missed in my earlier commit.
commit 969a7d322412494ebc595db6b33bccaf7390906b
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jan 4 07:46:05 2009 +0000
map translator
* moved define VOID() to common-utils.h, because there were multiple
definitions of VOID() (in dht, afr).
* minor log msg change in glusterfsd.c, earlier for any translator
init failure, it used to log 'fuse'.
* xlators/cluster/map:
doesn't get included in the build (not to be included in the release)
- to test, add entries in configure.ac to generate makefiles.
xlators/cluster/map/Makefile
xlators/cluster/map/src/Makefile
and remove the '#' in xlators/cluster/Makefile.am to include
'map' in the build
- snippet of the volume looks like below:
volume map
type cluster/map
option map-directory /dir1/:client1;/dir2:client2;*:dht
subvolumes client1 client2 dht
end-volume
'map' takes the top level directories as value, and one of the
subvolume as corresponding map. In the above example, all calls
on '/dir1/*' will be fwd to volume client1, '/dir2/*' to client2
and all other calls will be fwd to dht.
This is very helpful if one wants to export already existing dataset,
and doesn't want to use unify, which creates uniform directory
structure on all volumes. here, directory structure may not be
similar on subvolumes.
commit ea58b44be2aa820d3527f166986090398c1887fb
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Jan 3 20:13:07 2009 +0000
* nufa translator moved to dht source dir (where it actually belongs). so all the common code is stripped off.
commit 445530c903a3a9711ad909eb2b828023fbb602a2
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jan 2 07:06:39 2009 +0000
* added patchset string to be printed when glusterfs segfaults.
* the patchset is added in configure.ac (which will be changed by ./commit.sh everytime one commits code), which helps while reporting bugs.
commit 9a9da80950d4b87fa088ca07a13802b37cf23a2b
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Dec 31 19:38:30 2008 +0000
* conflicts in compat.c/h due to extra declaration of strnlen.
removed ifdef HAVE_STRNLEN part
commit 777eea7caf68a8a80400742281ecefbc7ef40613
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Dec 31 05:54:20 2008 +0000
afr init() cleanup
* cluster/afr:
- cleaned up afr init() to honour all the allowed strings for boolean options,
instead of previously supported 'off' only.
commit 71f7eca3d739870fed7b073fbcaf6e9f65e016d4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Dec 30 14:05:59 2008 +0000
mkdir() fixes RT-677
commit 86d1df4de7d5d07b58284ab741e556e235eb1532
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Dec 30 13:10:19 2008 +0000
bug fix in unify-self-heal
* during self-heal, unify_sh_setdents_cbk did not wait for completion of setdents on all
the children. Instead, on completion on first child, it used to do getdents for the
next set of dentries. This can result in overwriting of the dentries read in
previous call to getdents even before they are setdents on other children.
The problem can be best visualized when first child of unify is posix. Also, this
resulted in segfault since the memory used to hold dentries was freed on completion
of setdents of whole ns on first child.
commit 8f79506fc3e959961d6d62f83c5d75db33beb3e6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Dec 29 16:22:26 2008 +0000
unify bug fix
* cluster/unify:
- unify's create() used to return EIO, even in case of success when O_EXCL was not set.
modified unify_create_open_cbk() to properly unset the error flags in case of success.
commit 568e3b994cf6504d13de04f08f56fdb6779353a7
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Dec 29 10:42:28 2008 +0000
changed logs from ERROR to DEBUG in notify()
commit 63c692cca602079f25f90fa07d2a9b170bc25a36
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Dec 29 06:22:54 2008 +0000
write-behind partial code-cleanup
* performance/write-behind:
- cleaned up init() to remove references to deprecated dict_get(), data_to_<type>()
functions.
commit 1dfa0a3673f7ef822d5113ea62f81cbe74707030
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Dec 28 23:58:27 2008 +0000
minor fixes
* server_setdents() validates 'buf' before parsing the msg.
* afr.c:init(): metadata_selfheal was always on, and changelog was always off. changed to behave as expected, metadata selfheal to be off, and changelog to be on.
commit 870ee04078c5a53a1d542189401deff77eb5f0a6
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Dec 27 18:35:30 2008 +0000
segfault fix in protocol/client
* check for op type from argument 'type' passed to protocol_client_xfer
instead of from frame->root->type, since it may not be set for frames
obtained from copy_frame.
commit 8b4fd6dc103795011aa5db78cfbb3464b0f682ac
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Dec 24 22:15:24 2008 +0000
* fixes the bugs where unify is used as subvolume of AFR
commit 42591a3bf4f30d0538b28dd47e9d2ae624ab61d6
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 24 22:10:04 2008 +0000
set st_mode of inode in impunge_newfile_cbk for unify to not get confused
commit 33dfecb8ee358db6088f156a7fe012af0b8083a2
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 24 22:01:20 2008 +0000
more warning fixes in HA
commit 76fd6023910efc28b51f290e3b68abd58fee6d6b
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Wed Dec 24 21:25:14 2008 +0000
Solaris related warning fixes
* Makefile.am updates for portability using $(MAKE) instead of 'make'
* argp-standalone/* fixed warnings related to alloca.h
* xlators/* some warning fixes.
commit 612cf0a061dc5fb5002a6900fc050739c0776623
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 24 20:26:56 2008 +0000
warning fixes in HA
changed (int32_t) cookie to (long) cookie
commit fb42f87a40f2ceaffa5062a063c4544d390df11b
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 24 19:35:40 2008 +0000
server_loc_fill - if inode_path() cannot be constructed, unset loc->inode so that full absolute path is resolved. otherwise leads to crash in server_link_resume() etc
commit 182e883c595751bb16d7d3965a8c1f7a50be738a
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Dec 24 15:32:46 2008 +0000
cluster/ha code cleanup
* cluster/ha:
- currently lk(), entrylk(), inodelk() are not supported by HA.
commit 978c8ea0e5a306b8f4f5518b1c732af3cb6abeb2
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Dec 24 15:00:00 2008 +0000
protocol/client forget() bug fix
* protocol/client:
- resolved locking issues in protocol/client forget().
- replaced client_send_forgets() with client_get_forgets(), which will just
aggregate the forgets and return. the caller has to decide after return whether
to do protocol_client_xfer() or not.
commit 647e460798552e3aa35d30cc78a4ba1607eb3d78
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Dec 24 14:16:15 2008 +0000
afr_[f]truncate_wind() was checking (local->call_count == 0) which was always being true - instead of checking (call_count == 0)
commit 4963638cd8260ca38ea6bd839f661b4602a320c7
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Dec 24 12:42:27 2008 +0000
memory leak fix in read-ahead
* If the file is not read at continuous increasing offsets, flush the read-ahead buffers.
The pages were not flushed if the file is read from the end causing read-ahead
consuming memory equal to the size of the file.
commit 301bba571dd63fff3feda33c9b145326ed62e388
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Dec 24 08:03:42 2008 +0000
patch-795 related and RT id 673. AFR lookup revalidate should return stat info from the same subvol unless that subvol goes down.
commit eca5c45bf6e61364d090732a9de90337e86e09e2
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 24 00:35:08 2008 +0000
bug fix in struct saved_frames->count
commit c3997538d32c1fc18cde43837679f89bed673137
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 23 20:05:31 2008 +0000
fix in afr_truncate_wind and afr_ftruncate_wind
local variable call_count was not initialized hence early breaks from wind loop (when one of the subvolumes is down) would not happen resulting in the loop continuing after the frame was destroyed
commit 0e56e18bb55f622e6b71bb0bee6c8eb6568d554e
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Dec 23 10:10:22 2008 +0000
* pending frame's 'op' is printed as string when pending frames is logged.
* improvement in bulk forget logic, not to hold back forgets if there is no activity.
* proper log message if 'len >= options->send_size' happens in ib-verbs
commit c7eb5b831c4087c17a8b7feb432ad2c97f70e515
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Dec 23 04:03:31 2008 +0000
* forgets get pooled and sent in an array at client protocol. This
increases performance when kernel sends bulk forgets.
commit 6b596e333caf87f4bc6330c43c4c60dd945e63c5
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 23 03:53:10 2008 +0000
logging fixes in saved_frames_destroy()
commit 0936889dbab73629b176eedc3b850babbbbf8ce4
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 23 02:53:13 2008 +0000
moved frame->{op,type} to frame->root->{op,type} with necessary changes
added custom data structure for saved_frames instead of dictionary in protocol/client
commit ccb8407d798381408e9931c92f886da5f07b29c8
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Dec 22 20:23:11 2008 +0000
multiple commits
* ib-verbs: now returns -1 if the message size is bigger than what it can send.
* server-protocol:
- changed valid option for 'transport-type' from 'tcp/client' to
'tcp/server' in options structure.
- minor leak fix
* unify: reduced the number of self-heal entries in one transaction to fit in
the minimum 128KB buffer
commit 610c9b9904e5731103f6bbae0db25ee0ebf4d326
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 22 18:38:46 2008 +0000
event_unregister_poll() bug
typo bug caused segfault.
was: if (idx != -1) { error handle }
now: if (idx == -1) { error handle }
commit e1c9127d4a158809f89c7ac2ae667716219c87c4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Dec 22 16:16:27 2008 +0000
afr_lookup_cbk should return stat info from same child everytime, so that time stamps don't change over each revalidate. In case that child is down, the stat of first success is returned. Also inode number should be maintained across lookups/revalidates.
commit 0d8607ace9a4d93a06ccb51c438df1e25f0bd3c9
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Dec 22 07:42:27 2008 +0000
renamed server_get_local_sockaddr() in both transport/ib-verbs & transport/socket.
* transport:
- renamed server_get_local_sockaddr() to ibverbs_server_get_local_sockaddr() &
socket_server_get_local_sockaddr() in transport/ibverbs & transport/socket
respectively.
commit ffb9f7646d9baa84a04b82b444abb98860627e6f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Dec 19 10:45:39 2008 +0000
check for self turned on before healing.
commit 1f714e3f02fbb20db3812f365731e40db96856a6
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 19 06:43:31 2008 +0000
multiple fixes
rollback option-prefix to 'yy' in parser (from glusterfs_)
grammar fixes in log messages
commit 9e2882d932162f2cdfaceca9c98e484f78f925a4
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 18 23:42:59 2008 +0000
* proper options added in transport/* and scheduler/* files.
commit 10a3d0c550be85a1260eb1a474c76649af978387
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 18 20:13:37 2008 +0000
suppressed spurious self-heal logs in AFR
commit 5910066a280b710e220de179746371aec166ec73
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 18 19:06:01 2008 +0000
dht - do not set sticky bit for unhashed files which have hardlinks
commit fcd2cb61b0af9104f34357115aee0fea4396acad
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 18 18:59:51 2008 +0000
new option validation framework
* each module has to specify its own options instead of just translators
defining options.
* added FSYNC to slow call
* handled 'dangling volume' error for namespace volume
commit 70bcbdc8a04186060f35233e93125ea627061efa
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 18 18:32:57 2008 +0000
afr default change-log for metadata disabled
commit 965d021bd4195557b298e651cc0fa272cfb204b4
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 18 09:12:09 2008 +0000
log messages suppressed
changed log message level to GF_LOG_DEBUG for EBADFD cases and this_ino_set
commit c5a89e9e1bd4215c9eeec92edb5d34c3d0dc01e4
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 18 08:55:43 2008 +0000
fd leak fix
afr_lk_cbk was STACK_UNWIND'ing instead of AFR_STACK_UNWIND (this missing fd_unref of local->fd)
commit 59e3624897ff81a712fe2730d00ce4096f7dd57c
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Dec 18 06:34:33 2008 +0000
added afr.pdf to EXTRA_DIST
commit 01c85909be2176c84d7790f54a2d5cdafc1d0db4
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 17 00:34:00 2008 +0000
op_ret check in afr_stat_cbk afr_fstat_cbk
afr_stat_cbk and afr_fstat_cbk was not checking for op_ret != -1
while modifying @buf
commit c7d53af10c9d332f1e55454065a03e79bb6204ed
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 16 23:51:24 2008 +0000
fix for #648
revalidate of / was not using new inode_t
ra_create_cbk - fix error check from if (op_ret != -1) to if (op_ret == -1)
commit bedd660747aef84f4348dff8cc10e07e62259806
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Dec 16 20:39:38 2008 +0000
* configure.ac changes to include BACKTRACE
* minor correction in posix's options. (typo error)
commit 802d3243c74ed3839ba82912ea131a7f851a7ff7
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 16 09:18:10 2008 +0000
cleanup
logging: - if opening new file files, keep the old logfile and log error to it
- removed unused macros
glusterfs: - renamed to glusterfsd
mem-pool: - indentation and coding standards
- added CALLOC/MALLOC/FREE macros (to be enhanced later)
common-utils: - indentation and coding standards
- removed gf_full_{read,write,rw,rwv} and renamed its
- references with read/write
commit 6acbb96f54dc930716b2166bcfaa21ae771cb97a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Dec 16 06:08:50 2008 +0000
fixing glusterfs crash in read-ahead.
* fixing typo in ra_waitq_return:
for (trav = waitq; trav; trav = next) {
next = trav->next;
- frame = waitq->data;
+ frame = trav->data;
commit 207b9cb7ffed4e6dba56d768890843f6e341a3a8
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Dec 16 04:21:12 2008 +0000
pattern based block-size support in stripe
* stripe now supports pattern based block-size (again)
commit ca22ced778b27313ae053a2cedcb2a0951adc202
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Dec 15 15:38:24 2008 +0000
implemented ha_xattrop & ha_fxattrop
commit e2fad4843f656f4a021638c7626843873b3611c7
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Dec 15 09:36:08 2008 +0000
fixed 'unused variable' compile-time warning in AFR
commit 2d70f2b3954f8335fc9b8374e52d59fbb11ce4cc
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 15 07:32:03 2008 +0000
implemented non-blocking entry locks and afr self-heal uses non blocking locks
commit b5f214835ea2dcea4122497494e762654c93c058
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 15 06:30:54 2008 +0000
afr_open_cbk - referring to local->child_errno (was not necessary). after moving allocation functions to afr_local_transaction_init() this access caused segfault.
commit fee8ab9df22cf333d781561abf750c47adcc2a00
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 15 04:56:53 2008 +0000
fixed typo in afr_create causing segfault
afr_create was STACK_DESTROY'ing @frame instead of @transaction_frame
commit 34484f45d192810e29b2fb20078ad1c6b27a830f
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 15 03:40:09 2008 +0000
implemented unify_[f]{entrylk,inodelk,xattrop} fops
commit cf6e1771f92a27a158fe8cbc509f9db22b66094b
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Dec 14 20:20:49 2008 +0000
fix for #629
afr fakes an inode_link() by setting inode->st_mode before entering lookup.
this prevents confusion in self-heal during a fresh lookup where
other translators interpret the inode->ctx differently based on inode->st_mode
commit b8961a72d8d03fcc3df99863f6d96c7f0ef11db0
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Dec 13 03:19:29 2008 +0000
* dangling volumes in volfile will throw a warning now. (check added in
init()) of each translator.
* removed ugly strcmp ("protocol/server") from glusterfs.c
commit 8f8d44b4ff641c546d041d6f980a1cd2192a3cc5
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Dec 13 02:44:13 2008 +0000
fixed fredlock
commit 3d966c77759d8a01b2a08ffba1a42c7952e32ab0
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Dec 12 23:56:34 2008 +0000
* fixes error's caused by missing st_ino in buf_cbk by properly sending
inode->ino in st_ino.
* log message fixes, now, buf_cbk prints FOP too.
commit 8069b102c2d763ac0150cf22cef04b3e4dba687d
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 12 22:32:59 2008 +0000
afr_local_init - move allocations for transaction to afr_transaction_local_init and call it only in afr_transaction()
commit 4e82dafa4c429b469ee8d3de0b68d2dc902330ea
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 12 21:55:53 2008 +0000
fredlock diff from gowda with review comments
commit 1d779a7f77c43be3f8fbacb2a44636a408557786
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Dec 12 14:26:44 2008 +0000
protocol/client return value fix
* protocol/client:
- all fops now return EBADFD, when client-protocol fails to extract remote_fd from
fd structure.
commit df724c8cf239fd07e9e123f46bd46b30c64ddb3d
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Dec 12 12:16:18 2008 +0000
rewrote afr_lk fop for correctness
commit d255929fc76eea396fefb06c80cf355ce8da49bc
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Dec 12 10:51:09 2008 +0000
bug fix in afr_checksum
send the first successful checksum
commit cab58ff18ca011b3d06cbac9e0495d970be8577a
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Dec 12 10:41:01 2008 +0000
stripe bug fix (resulted in #615)
* cluster/stripe:
- stripe_link() checked for newloc->inode, which does not necessarily be set.
commit 8d392f552f0d25c827d0f79053f63e3edb211067
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Dec 12 09:56:51 2008 +0000
afr bug fix (which resulted in rt #611)
* cluster/afr:
- afr_getdents() was not assigning the allocated local to frame->local. this resulted
in afr_getdents_cbk() segfault while trying to access frame->local.
commit c25dca66b8770f95fb212a85c8f139ab2ea13322
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Dec 12 08:59:46 2008 +0000
changed log level in protocol/server for a log message
* protocol/server:
- changed log level from WARNING to DEBUG for a log message which logs about re-lookup
of a path.
commit def5c6f5109b606b4fef532b4d06c87b5a103a97
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Dec 12 08:51:31 2008 +0000
* fix for bailout logic in slow_op_count is set.
* in unify_lookup_cbk loglevel is corrected
* unify_buf_cbk now fails if stat structure is null..
commit cfd394d8f16b67a2383926d21d2d9a8230f3fd53
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Fri Dec 12 06:50:06 2008 +0000
Fixed configure.ac and rpm spec file updates
* rpm spec file updates for new options in ./configure
* configure.ac fixes a failure condition in manual apxs/
apache path.
commit e7a8ab9bb5b322333f236dbc788b09a0dbd848a2
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Fri Dec 12 06:02:40 2008 +0000
typo fixes
* INSTALL
* doc/booster.txt 'specfile' to 'volfile'
commit 9360587a84228491a79cc3ac1d1a538b3f5be4f3
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Dec 12 03:12:26 2008 +0000
* correction in doc/* files (including man page)
* nufa linkfile self-heal added
* checksum added to the slower timeout option in client protocol
commit 6b9d7333a63ae7f410d4dd8fb6af74a4a6eeacea
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 11 22:58:53 2008 +0000
server_mop_setvolume() - fixed the conditional to serialize error string dictionary. fix for #602
commit 3e1c94a0b971afb7c839d1b9bb2c418928f51985
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Thu Dec 11 21:04:36 2008 +0000
'-o nonempty' mount arg removed
* fuse args '-o nonempty' not supported on FreeBSD, checked with
0.3.9-pre1 [fuse4bsd] version. Removed it from fuse-bridge.c
under BSD ifdef section.
commit ba329346eba519013e2758454c5d68190500892f
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 11 20:03:47 2008 +0000
* ha should not log lookup fail with ENOENT in error mode. corrected
commit 9a00e61d1dc42f308fadb32ab43b033f1494299d
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 11 19:53:23 2008 +0000
event.c ufds in poll NULL bug
commit 5158188e8a889892f92558322bff55a59be0bc38
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Thu Dec 11 18:21:03 2008 +0000
Fix in configure.ac
* BSD related build failure fixes.
commit e0b497220d2bd5708d833e40c6b9e5ef775ffa40
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Dec 11 17:26:43 2008 +0000
xlator/features/locks/Makefile.am fix
commit d2a1d401e5c2795b8e688d0b682b6efcf450b8fa
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Dec 11 17:21:58 2008 +0000
fix for rpmbuild
minor fix in locks/src/Makefile.am to create posix-locks.so symlink properly
commit 8480596c62c2342fcd91a0e9a0d56ea2c3af3be6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Dec 11 15:54:37 2008 +0000
nufa bug fix
* cluster/nufa:
- nufa_newfile_cbk() was not unsetting local->linkfile.xattr after doing
dict_unref(local->linkfile.xattr). this resulted in deferencing a free()ed dictionary
local->linkfile.xattr in nufa_local_wipe(), during NUFA_STACK_UNWIND().
commit 0b6ec68035eb2b1a428d8159aba5bc2436413531
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Dec 11 14:03:18 2008 +0000
bug fix in AFR (#581)
do a fresh dict_set before each STACK_WIND in write_pending_{pre,post}_op
since previous STACK_WIND might have already returned (think of case
where subvolume is posix) and would have used the dict as placeholder for
return value and changed it.
commit 54b8e28230cfc17b159095e2e4d3c2b7efd0755c
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Dec 11 13:15:20 2008 +0000
bug fix to cluster/nufa. changed part of dht_rename_cbk() to make it more readable.
* cluster/nufa:
- nufa_rename_cbk() _should_ not send unlink() to the subvolume on which rename() happened.
previously it was missed out and unlink() was sent to the subvolume on which rename() just
happened.
* cluster/dht:
- added a new identifier 'rename_subvol' in dht_rename_cbk() and using 'rename_subvol' to
prevent unlink() being sent to previously renam()ed subvol. NOTE: bug was fixed in dht
previously only, this commit just brings in more readability.
commit 06ba0f37e43f148b7ae3f469977286c01992cdbd
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Thu Dec 11 13:01:19 2008 +0000
Fixes for FreeBSD build and locks.so symbolic link.
* FreeBSD some build issues with "execinfo" present.
Changed certain configure variables inside *bsd* section.
* locks.so symbolic link issue install-data-local to
install-data-hook
commit 2374ef10dd6babe2f83ba973ec316de54391a604
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Dec 11 11:06:40 2008 +0000
some minor changes to afr document
commit 157c5e0038d77261b112415b67f4848090b80631
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 11 10:54:04 2008 +0000
* fix for the bug where SETVOLUME was failing for volumes which were
authenticated with auth.ip, instead of auth.addr
commit fe87de560d562210765434dbcb2ea04742560319
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Dec 11 10:16:12 2008 +0000
io-cache bug fix
* performance/io-cache:
- removed reference to page outside of ioc_inode->lock
commit c0b2de01d077ce1ffb15c28d6d7606dfd7b96f22
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 11 09:21:14 2008 +0000
mem leak fixes in protocol/server
server_protocol_cleanup() - free server_state_t of the unlock frame
inode_path: free previously allocated buf before second alloc for the case of "/"
commit 2062947dbfea1105afc5e4ff20c28232e4976342
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Dec 11 07:12:57 2008 +0000
renamed posix-locks to locks
added symlink posix-locks.so for backward compatibility
commit b538501a7f3a130a90c5eac2b3ce7ef8c3df690d
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 11 03:30:35 2008 +0000
* correction in mount.glusterfs.in scripts
commit 14b3f72f96ca199819c96c07711deb0876b1ab07
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Dec 10 21:00:34 2008 +0000
* changed reference to 'specfile' as 'volfile'
commit 5b4ef401b64103430ecaac91a91a64f70c791dc8
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Dec 10 12:50:54 2008 +0000
added afr documentation
commit 3879f3a9e831f8f76dcfc12f45cdb2f7c9eab8af
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Dec 10 11:58:37 2008 +0000
repair work on previous afr commit
commit e3abd00cc4322558c06c9816e6dba3f4582cca01
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 10 11:17:52 2008 +0000
cleanup of event.c
updated code to follow coding standards
fixed benign error msg "epoll: failed to modify fd(=-1) index from N to N"
commit f3d170a0bb2d083a9a0f760617460b415f479c3e
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Dec 10 11:10:01 2008 +0000
* changes done to dht after patch-665 (including bug fixes) merged to nufa.
commit ec994eb7efa11cd55c6c5746e38f5020f0ee5488
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Dec 10 10:29:31 2008 +0000
added new options to afr
added options: default
data-change-log on
metadata-change-log on
entry-change-log on
if any of these options is "off", it disables
xattrop for that class of fops
commit cbfcb8879cfedd7cbdfe6f9acc91d8e395c91ec2
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 10 07:07:46 2008 +0000
change in dht to set sticky bit for linkfile'd files -- necessary for unify-migration script
commit d4ee3057d10dfd1c9872c4dfca94b2fda0db43c7
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 10 06:00:28 2008 +0000
build_parent_loc() - perform loc_copy when child is root loc
commit 453952c5448259e652d0cda1badfa1b0e6882e42
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 10 02:48:17 2008 +0000
renamed first_up_child to dht_first_up_child() since symbol name was conflicting with afr's first_up_child() and causing corruption of xlator_t
dht_first_up_child: set indentation right for variables
commit 52eab6bdd88bbc79a855e5ac6f6aa5003df7e96c
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 9 18:27:32 2008 +0000
dht_readdir_cbk - do not return error when last subvolume is down
commit f65eeb1eadfa0069fe9eb211f10cc12ca7808030
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Dec 9 14:58:18 2008 +0000
dht_subvolume_get_hashed() bug fix when first child is down.
* cluster/dht:
- dht_subvolume_get_hashed() used to return first child of dht irrespective of whether
the child was UP or DOWN. changed dht_subvolume_get_hashed() to return the first
child which is UP.
commit 3c24c73b9b42c2bf9611180fb62abcfee2478058
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 9 07:20:44 2008 +0000
bug fix for #568
client_setvolume_cbk was accessing rsp->buf (dict_unserialize()) for protocol_client_cleanup() callback
commit 9c6ade69f57b5c65df50dc52d05fde1c0e4cc1b7
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Tue Dec 9 06:40:10 2008 +0000
Solaris xattr related notes and updated some documents inside doc/*
* Added file solaris-related-xattrs.txt
* Updated porting_guide.txt
commit 954ad85881a77074eb2e7f3dafd248d93b3bd5cb
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 9 04:57:52 2008 +0000
fixed unused variable warning in server_loc_fill()
commit 90bbb5de98164ea6527b7e85dc196579c93e3fdb
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 9 04:01:38 2008 +0000
fixes in posix-locks
release_entry_locks_for_transport: was not granting pending locks which were blocked on the lock to be deleted, fixed. could cause deadlocks.
commit f136c0fb34051be4800c5fdf192df56d66494362
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Dec 8 23:56:48 2008 +0000
* compilation fixes in MacOS X
commit 4404a91407a11a39357095ed403ef3de8700e3fb
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 8 23:56:16 2008 +0000
fixes in posix-locks
__unlock_name() return lock only if list_del() is made. fixes bugs 565 and 567.
commit 315c9f568a9c996a77edc7d60d70048427fad04d
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Dec 8 21:56:03 2008 +0000
changed inode_path() API and added corresponding changes to fuse, server, libglusterfsclient
* libglusterfs/inode:
- changed inode_path() API to 'int32_t inode_path (inode_t *name,
const char *name,
char **bufp)'.
* protocol/server:
* mount/fuse:
* libglusterfsclient:
- changed usage of inode_path() to use the new API.
commit 8ca531527653f21f5dd269be2addf2e8dcd8ff7d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Dec 8 20:05:48 2008 +0000
ha code-review fixes
* send the fops like mknod, mkdir, link, symlink, create etc, to the first
up child instead of child specified in pvt->active. This fixes the bug where
in if currently active child is down, only the children which fall in the index
range starting from pvt->active to end of the array are considered for sending the
fop instead of all the children.
* fix memory leak in ha_link. both newloc->inode and oldloc->inode are same, hence
allocating a new stateino and setting in the dictionary (inode->ctx) results in leak
of the previous pointer stored over there.
* in macro HA_CALL_CBK_CODE_FD if the current cbk returns ENOTCONN, local->active is reassigned.
while checking for active child nodes only local->tries child nodes are examined instead of all
the children (or local->tries number of children which are up). fixed the same
commit d38ae010c51624ef942c66df7e9fe5d2521bf2a5
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Dec 8 15:48:39 2008 +0000
client protocol bug fix
* protocol/client:
- fixed definition of CLIENT_CONNECTION_PRIVATE() in client-protocol.h.
CLIENT_CONNECTION_PRIVATE() should derive the per connection private from the
xlator_t. transport correpsonding to the xlator_t can be found by using CLIENT_TRANSPORT()
macro.
commit ba3f99d32b52d6a49e8d41a61344c29f43fe974d
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Dec 8 13:15:20 2008 +0000
CLIENT_CONNECTION_PRIVATE was not properly defined. it was giving this->private->xl_private instead of this->private->transport->xl_private
commit 6b5cc7485f80ff61c92ab043930d9a9610e73d8f
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Sun Dec 7 17:31:26 2008 +0000
Updated manpage
* Manpage updated with respect to new updated options
commit 699b9ca32e155cf846f4db5ad04a7a8a27e67284
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Dec 6 23:17:37 2008 +0000
* added extra check in timeout logic for slow calls.
(currently added 'unlink', 'rmdir', '*lk' calls)
commit 46a56514dc0cce9ea412fe27ecdd40923daa2b44
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Dec 6 11:28:59 2008 +0000
afr-transaction:
afr_lock_cbk and afr_transaction_pre_op_cbk: set local->op_errno for any op_errno when op_ret = -1 (avoids EUCLEAN being returned when all subvols fail)
commit 7c87369b0912245625cfa11cc01a5312cdf88129
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Dec 6 08:52:11 2008 +0000
* added feature to support linking of client protocol to another volume
if 'option remote-subvolume' is in same process.
* cleanup of few more files.
commit 04016ef73a35e609a2a78bb49cf18aa9ae72b8fd
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Dec 6 04:28:05 2008 +0000
cleanup drive
* 'REALLY_LONG_MACRO_DEFINITIONS to ZR_SML_MCRO' cleanup
* added 'TODO' where log messages doesn't make sense
* restricted usage to '79' columns in all the files committed now (other than fuse-bridge.c)
* removed fuse-options.{c,h} as most of the checking is properly handled during parsing.
commit f1bd224172d3c2f946c5c5f80972d62d4c41ec33
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Dec 6 00:48:20 2008 +0000
dht logs made 'less scary' for first time lookup of pre-existing directory (/)
commit 0e806386077a57db4bd73a06cc18f559c0c77992
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 21:47:16 2008 +0000
fixes in protocol/client
this_fd_get was returning -ENOENT (from dict_get_int32) but fops were checking for (ret == -1) and forwarding 0 as fd to server, resulting in 'unresolved fd' errors in server
client_lookup - forward the lookup to server even if par is not resolved. else results in spurious 'EINVAL' errors to the mountpoint when using AFR and server failsover.
commit 1e602ef89230e56d92cad8544f5464fcff59a5f2
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 09:27:36 2008 +0000
fuse_rename_cbk - overwrite stbuf->st_mode with inode->st_mode. previously dht_rename_cbk was returnin 0'd stbuf and hence causing EINVAL in lookup()
commit e14e43b6f6176c6cf463451395db927e4a8aad32
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 09:00:13 2008 +0000
afr-self-heal-data - add fix to make sure empty new file is not treated as source (which was causing data loss)
commit 8bd5a5a49cadb89bb05ae58721489e79ed12adcb
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 08:06:57 2008 +0000
afr_mknod_wind_cbk - call afr_transaction_child_died() when child_went_down() == 1
commit ac2702e56d3f7dc65a7829dcc7dd2562a80e73d8
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 07:38:22 2008 +0000
afr-inode-read: retry to further subvolumes even for non child_went_down() cases (i.e if op_ret == -1 with any op_errno)
commit 60873870d9db30713c96e254059d2f2dcac4a08d
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 07:01:56 2008 +0000
fuse-bridge log error in case of inode number is 0 in successful callbacks
commit cf8be1bcdc30a01e07dabb894a9db9ff82466fda
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 06:39:24 2008 +0000
dht_revalidate_cbk - retain inode num of directories always
commit 0fb91a0a56bda7b82624e624b312277ab6848bf4
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 06:21:57 2008 +0000
fixes in afr to return first looked'up inode number even when subvolumes go down/up
commit d84d431f87b06ba01190ddaf7f89c41ed62ddcbd
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 05:03:56 2008 +0000
changed gf_log status of error messages in fuse-bridge
commit 7d149dce1e6c4bf9477af0cbb2228d5d32c86005
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 03:51:07 2008 +0000
reconnect interval set to 10seconds (intead of fibonacci series)
commit 72c96c92dcd15fa9407500b145e1d17fa67baa46
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 02:32:58 2008 +0000
dht directory selfheal -- handle more cases
protocol/server -- prefer path built by dentry tree to client sent path (fixes rsync errors)
commit fe785fa2fb6505c3c010bd1cec342bbf0865041f
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 5 00:13:45 2008 +0000
log cleanup in fuse-bridge and disable acl calls in fuse-bridge
commit a07a6c648f8b9c72fbc0dcc307bf9bf202c05919
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Dec 4 12:06:52 2008 +0000
wb_writev honours disabled and disable_till flags in file structure.
* data is not written behind if the file is disabled or for the first disable_till number of bytes.
commit b248fb0998e7fd045974a933e3a18210bd08df18
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 4 10:23:57 2008 +0000
race fix in afr
wrapper function afr_frame_return() to lock and decrement call_count. this wrapper is called just before 'if (call_count == 0)' checks. fixes bugs #545 and #546
commit 70e791545a7bd63c389d69658e751d03c38b536c
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 4 07:38:24 2008 +0000
fix for off-by-1 string length bug in inode_path()
commit 318dbd5b27d57e7bed1cf150ea13ee094fde7449
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 4 07:19:45 2008 +0000
* removed '-o dev' option for fuse options in case of BSD (or Solaris). With this client seemed to work fine on FreeBSD 7.0 or later.
commit 3241fc618821d4f078d46ed26ae747e25b262cff
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 4 03:37:28 2008 +0000
dht linkfile self-heal
stat'ing on the filename fixes any linkfile related issues present for that file
'option lookup-unhashed on|off' controls whether to search for file/linkfile on unhashed node (useful during migration from unify to dht)
commit cd50e25f1e266d205b46a7bc829a982f39cdcb20
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 4 03:12:09 2008 +0000
minor changes in afr
afr-self-heal-data: hold SETLK and not SETLKW and if lock is not granted immediately do not performn self-heal (as someone is obviously still writing to the file)
afr.c/h: change child_errno[1024] to *child_errno with calloc/free
commit 85335815972e6da1b5cb9382310f7d97987fe3f1
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 4 03:03:51 2008 +0000
fix for entrylk deadlock for #543 in posix-locks (it was holding mutex and stack_unwind'ing)
commit 4278e7e0833eedeb8332011eb193e976dbe47ada
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 4 02:26:46 2008 +0000
* '--debug' was not properly handled earlier. Corrected.
* removed 'icon-name' option (was introduced for macfuse)
* corrected the behavior of specfile option validation.
commit 2a0396ebdcb8a8af0828a2d86f06b99033d11255
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Dec 3 23:37:53 2008 +0000
* changed the '--xlator-option' behavior to 'add' instead of 'override' options.
* changed option '--directory-entry-timeout' to '--entry-timeout', as 'entry' doesn't mean directory,
* added a minor check in unify so it can warn admin about using the backend used by DHT.
commit 09fb4340b497938c33e1d8c3e5a4c50b916d1fc5
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Dec 3 07:54:13 2008 +0000
build configuration fixes.
* moved xlator/performance/write-behind/test to extras/test.
* extras/test doesn't build by default. to build extras/test, user need to seperately
run make on extras/test directory.
commit 364228e264e4aa22283c71740d50ef346a847a4d
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 2 18:37:49 2008 +0000
make afr_writev unwind after write returns from all subvolumes. Pipelining will be done by write-behind
commit 196fe015f22a959cf9883203f7da3775165a3d8a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Dec 2 15:41:28 2008 +0000
libglusterfsclient code cleanup, bug fixes in call-stub.c, Added GPL header to rdd.c
* libglusterfsclient.c:
* clean the glusterfs graph during fini and in case of glusterfs_init failure.
* libgf_client_loc_fill constructs path if not provided, using inode number.
* error messages contain file, line numbers in glusterfs_init.
* added libgf_client_loc_wipe.
* glusterfs_getxattr uses libgf_client_lookup with need_xattr to get extended attributes.
* glusterfs_open/glusterfs_creat properly interpret flags.
* implement glusterfs_fsetxattr, glusterfs_fgetxattr.
* complete implementation of glusterfs_lseek.
* implement glusterfs_creat using glusterfs_open with flags O_CREAT | O_TRUNC | O_WRONLY.
* write-behind.c:
* disable writing behind if file is opened with O_SYNC
* call-stub.c:
* fix validation of input arguments in fop_create_cbk_stub.
* xlator.c:
* implement xlator_tree_fini and xlator_tree_free to enable cleaning up of glusterfs graph.
commit 9dff622106ed639fa052936baf5c1eba12893221
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Dec 2 11:39:00 2008 +0000
bug fix in afr-transaction
handle case where number of up subvolumes is less than number of
lock-servers
commit eecbcdf47f884e696c415f1bb1ae639723fe7d51
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Dec 2 09:36:06 2008 +0000
split lock-server-count option into three
data-lock-server-count: for writev, truncate default = 1
metadata-lock-server-count: for chmod, chown, ... default = 0
entry-lock-server-count: for create, mknod, .... default = 1
commit 4788e58b792c6349b0aaac6598b5ff12724d01d0
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Dec 2 08:12:12 2008 +0000
committing rdd
* rdd (random dd) is a tool to do sequence of random block-sized continuous
read writes starting at a random offset
commit 9a45e6c4a40f0ecfdd37af304b061662763322f0
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Dec 1 21:11:37 2008 +0000
* increased the range of 'window-size' in write-behind to 16GB from 16MB
commit 594c17c67f15c530070629d6d0558c64f2371803
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Dec 1 13:11:34 2008 +0000
fixed a bug in afr-transaction.c
afr_write_pending_post_op: do a fresh dict_set for each child,
because otherwise the dict will contain the "return" value of
the previous xattrop.
commit 2f474c3417cd72df402cd6e4ac83f73b70d3ce04
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Dec 1 11:53:44 2008 +0000
added checksum fop to afr
commit 85269ed3141ab35b2b07c963b699aaad0a121528
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Dec 1 11:49:20 2008 +0000
added inodelk, finodelk, entrylk, fentrylk to afr
commit a9569f600c045958cfdb543fa90995adc3d56438
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Dec 1 10:33:38 2008 +0000
added fsyncdir, xattrop, fxattrop to afr
commit 68fb441665f3973802b809fbf137c76a03e56b84
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Dec 1 09:37:42 2008 +0000
implemented fsync in afr
commit 8b3e71287357e07044ce654c036854335ad1c048
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Nov 28 14:58:36 2008 +0000
fixes to libglusterfs/inode, mount/fuse-bridge and protocol/client
* libglusterfs/inode:
- inode_path() now returns -1, if path construction fails.
* mount/fuse-bridge:
- changed fuse_loc_fill() to return int from void. fuse_loc_fill fails when
inode_path() fails or parent inode cannot be searched.
- made changes to all fops to check return value of fuse_loc_fill().
* protocol/client:
- bug fix in client_setvolume_cbk(). client_setvolume_cbk() tried to do dict_unserialize()
in all error cases. but correct way is to do dict_unserialize() only when op_errno != ENOTCONN.
commit e97cb3632a3e7bf8af8179eee442ff57487fdfdb
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 26 23:56:40 2008 +0000
disabled cache-size limiting in io-threads
commit c29515a58cdd6189ce15e9322fcac7a36374bb1e
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 26 20:33:25 2008 +0000
changed log messages in posix-locks to DEBUG level
commit a9ab423d4ec6288da1e7eebaf63c667fd19e6feb
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 26 20:29:43 2008 +0000
afr-transaction, afr-self-heal: set frame->root->pid to frame->root->unique as a quick-fix for getting the effect of 'nested locks' in posix internal locks.
protocol-client: fixed leak in client_xattrop_cbk (xattr dict)
commit c0256c108295dfc15d15e999a0453d4970a17422
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 26 10:05:51 2008 +0000
posix-locks cleanup
commit 1048bca5795ef6722968dbb22e115fff74440c52
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Nov 26 08:01:35 2008 +0000
moved option overriding logic to glusterfs.c from spec.y
commit 14559aadeb30f6491da37758d0be8df48dbfa918
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Nov 26 08:43:38 2008 +0000
memory leak fixes in libglusterfsclient.
* glusterfs_lookup missed inode_unref (loc->inode). Now libgf_client_loc_wipe does
inode_unref (loc->inode), which fixes the leak. Also changes in other procedures
to accomodate change in libgf_client_loc_wipe.
* inode_ctx was calloced even for revalidates in libgf_client_lookup_cbk.
commit bf3477804e3d43f7e28b5272ba925c4b2c68da1a
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 26 04:06:02 2008 +0000
* proper log msg when there is 'transport-type' mismatch between client and
server volumes.
commit b5493335def5c17a56b510c132d295c10639aa39
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 26 03:01:31 2008 +0000
* From now, transport-type socket will use default port 6996, and
'transport-type ib-verbs' will use port 6997, so there is no problem
with starting another glusterfs process to listen with different interface.
commit 7b1feb4b01846900bedec6df8b51bbec557f9363
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 26 02:14:24 2008 +0000
* added support for multiple specfile to be fetched from a single server using a key from glusterfs command line
commit a93529fc8a072c5cf78b74a27f0b2d49944fba57
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 25 23:19:36 2008 +0000
* removed remaining warnings
* removed '\n' from gf_log messages
commit a910c30c438f6a04d74e37c5f2a0a719c4015a7a
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 25 22:35:47 2008 +0000
afr - changed EIO 'permanent' error during conflict to 'temporary' (next lookup re-evaluates)
commit 47ffc00ac430cce478f82dee9a0ecd9d6979300d
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Nov 25 21:28:04 2008 +0000
Fix for misbehavior when AFR's subvol goes down. Ref RT 524 for details.
commit 031c7b44c902bff058cb77b8ca0f09ff79af4201
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 25 19:29:54 2008 +0000
* removed some 'return value not checked' warnings
commit e02b49ebc42e0a6213ac2debd388aa8405445487
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 25 17:15:36 2008 +0000
check for hashed inode in inode_* functions of inode.c
commit a398a10ebd025b39bd1fa78e17ae0907dae266a9
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 25 12:01:13 2008 +0000
fixed warn_unused_result warnings in AFR
commit eb5562e1b66b36ea2726ed86a6b258994be4f715
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Nov 25 11:55:02 2008 +0000
logging enhancements to trace
* debug/trace:
- call id is logged for every call now. this will be helpful in relating a call and its
callback when a multi-threaded application is using glusterfs.
* configure.ac:
- updated version to 1.4.0pre12
commit 46e50e761ebc4ea789a1b1fc3745abad137bdef6
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 25 11:40:18 2008 +0000
defined GF_MUST_CHECK
defining a function with GF_MUST_CHECK tells the compiler that
its return value is meant to be checked. If the return value
is not checked somewhere, the compiler issues a warning.
All functions in dict.h have been declared with this attribute.
Please find more functions that deserve this and give them the
attribute.
commit 3710d3b1fc916cd4da2446a50d99e38a2da9312b
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Nov 25 13:00:35 2008 +0000
booster gets the path to logfile from environment variable GLFS_BOOSTER_LOGFILE.
* If GLFS_BOOSTER_LOGFILE is not set, logging is done to /dev/stderr.
commit 6b37a9babf6a4f58cfd4d2296b69be1653194f9b
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 25 03:10:46 2008 +0000
* more validation for authentication modules in server protocol.
commit f5656c70178093538d209a2fb34dda2bc989f427
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Nov 24 20:19:27 2008 +0000
nufa update to latest dht changes
* changes in linkfile creation imported from dht to nufa.
commit 135ab77562e5417b5c243cf076b3cf2757aea671
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Nov 24 17:50:16 2008 +0000
inode_unlink() bug fix.
* libglusterfs/inode:
- inode_unlink() is supposed to eliminate all dentries that resolve par/name pair.
current inode_unlink() only looked for dentry_t derived from the inode that it was
referring to. this introduced in a race condition where an inode replacement would
leave stale dentries for a par/name pair, even after inode_unlink().
fixed inode_unlink() to do __dentry_unset() on the dentry that is hashed, not just the
dentry derived from inode.
commit c78d7ff901b43117d37d3e5eeb7b88f690fc11b5
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Nov 23 18:32:38 2008 +0000
implemented command line option --xlator-option
The command line option --xlator-option allows you to override
any translator option in the spec file.
Syntax:
--xlator-option volume-name.option-name=value
E.g.:
--xlator-option wb.aggregate-size=4M
sets the aggregate-size of the 'wb' volume to 4M, regardless
of what it is set to in the spec file.
If the option is not present in the spec file, --xlator-option
has no effect.
commit 634a3bdbe539e164382b41cc4bc92801d055944a
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 22 20:29:51 2008 +0000
changed linkfile to use regular files with mode 01000 (no rwx for anyone and only sticky bit set)
commit a87361195ff3e89e39c13bc07fd08cfa96c2f167
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 21 22:02:47 2008 +0000
* added function to handle gf_string2uint properly
commit be9c4e54a83e4e32adeb1fea58e49e48de42e4c1
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 21 17:55:42 2008 +0000
fixed warning in protocol/client
commit 8b7da24c718513425dc6a030035ce09c0a76adc5
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 21 17:46:36 2008 +0000
protocol/client: this_ino_get - check for inode->ino only for logging. this is to support the case where self-heal happens in afr before the lookup completes and inode->ino is set.
libglusterfsclient: fixed warning
commit d7618a6e6260f4b50ce1b52a68926303b910026f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Nov 21 16:47:33 2008 +0000
inode_from_path() and __server_path_to_parenti() rewrite.
* libglusterfs/inode:
- inode_from_path() rewrite.
* protocol/server:
- __server_path_to_parenti() rewrite.
- bug fix in server_xattrop_cbk() error handling.
commit 1d110a60af740ac6998c4d8981fcb406a76024d5
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Nov 21 13:36:00 2008 +0000
booster documentation, updated apache/1.3/mod_glusterfs documentation,
libglusterfsclient cleanup.
* renamed booster/src/entry.c to booster/src/booster.c
* Added docs/booster.txt
* when used with ib-verbs, mod_glusterfs fails to initialize at ib_verbs_init. The reason for
this is that apache runs as non-privileged user (nobody by default) and the default amount of memory
that can be locked by a process is not sufficient for ib-verbs to initialize. As a fix change the limit
to unlimited.
#ulimit -l unlimited
Added this to mod_glusterfs documentation.
* libglusterfsclient uses call_stub_destroy instead of manually cleaning up individual members of call-stub
commit f359391047636c405da86f6b64272be0dc0013de
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Nov 20 20:50:08 2008 +0000
memory leak fix for apache/2.2/mod_glusterfs, change return value of auth/addr
in case of client not binding to privilaged port, typo fixes in auth/addr
* buffer allocated during glusterfs_lookup to hold file contents is stored in dir_config.
but mod_glfs_merge_dir_config never used to copy this pointer to new dir_config, resulting
in creation of new dir_config without the buf pointer. Hence the leak.
* auth/addr used to return AUTH_REJECT for clients which are not bound to privilaged ports.
Changing it to AUTH_DONT_CARE.
commit 2e141b25a0d29bc075b5a48fda599b695e72bebc
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Thu Nov 20 19:08:34 2008 +0000
added new options --with-apxspath and --with-apachepath to specify new apxs and apache at not standard or with non standard names
* Compiled and tested with apache 2.2.8 on Ubuntu 8.04 where "apxs" is "apxs2"
and "httpd" is "apache2"
commit 575b4513253c37ae74aaadff730712ed03e2bc26
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Thu Nov 20 12:52:37 2008 +0000
MODGLUSTERFS and LIBGLUSTERFSCLIENT for solaris compiling properly so removing them from "no" list.
* configure.ac modified for solaris case section to check for apxs and
build accordingly mod_glusterfs.
* Observed a discrepancy in Debian based distros that apache2.x forward under
debian httpd is called as "apache2" and apxs as "apxs2" this might effect
us at the configure level we can have an option called --with-apxs-bin
which will directly specify a apxs and also --with-apache-bin so that
hardcoding values to "httpd" will work definitely on other distros, but
in case of debian people might need to specify above overriding options.
commit c929fd721c55d53bb7f3e402a04dafec2e77403e
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Nov 20 08:19:34 2008 +0000
missed out to add apache/1.3/src/Makefile.in to EXTRA_DIST in previous commit.
commit 158f4b75a6ba762e4030f3cd28be23c5df9b403a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Nov 20 08:04:56 2008 +0000
build error fixes for mod_glusterfs
* renamed mod_glusterfs/apache subdirectories from 1.3.9, 2.2.10 to 1.3, 2.2 respectively
* make dist packages both apache/1.3 and apache/2.2
commit f17423f8cf7f42e80dd0704536671116334c8ad9
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Nov 20 05:14:24 2008 +0000
libglusterfs/transport cleanup
* libglusterfs/transport:
- cleanup to confirm with coding standards.
commit 620cd1658fae740956307df811f04fdc48450384
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Nov 20 04:51:40 2008 +0000
server bug fix
* protocol/server:
- previous commit had re-introduced __server_path_to_parenti() bug into server-dentry.c.
committing the re-fix.
commit e92e3035b3feea90cae0f2fdb68a16d7a93b0247
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 19 22:11:16 2008 +0000
minor change in dht_rename_cbk
changed (src_hashed != prev->this) to (src_hashed != dst_hashed)
commit 5a7318a7814e5109c80823c9d6f28ea942d0d9b1
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Nov 19 18:45:41 2008 +0000
* httpd header files were assumed to be present in <INCLUDE-DIR>/httpd. Changed it to <INCLUDE-DIR>.
commit fb0a21a46c04c7036c215a5a5b6d61a9c1540651
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Nov 19 17:44:49 2008 +0000
committing mod_glusterfs/apache/2.2.10/Makefile.am
commit b020f00a8b2afc559dddb7c345cbf2d8b52eb9ad
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Nov 19 14:57:12 2008 +0000
dht-rename bug fix
* cluster/dht:
- dht_rename_cbk() should not send unlink() to the subvolume on which it has just done
rename(). but dht_rename_cbk() missed to check for the case. added a check to verify
against cookie->this before sending unlink() to any subvolume.
commit 2e64ed7a885f0aafc85e25191e9e4579963e6dfc
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Nov 19 10:35:55 2008 +0000
* mod_glusterfs porting to httpd-2.2.10, bug fixes in call-stub.c,
glusterfs_readdir, glfs-bm.
* call-stub.[ch]:
- call_stub_destroy() now destroys stubs created for the
purpose of winding as well as unwinding.
- fop_readdir_cbk_stub used just copy the pointers in the dirent
list there by leaving a list of dangling pointers. Copy the whole
list including entries (instead of just pointers).
* libglusterfsclient.[ch]:
- implement glusterfs_getdents.
* glfs-bm.c:
- glusterfs_open() returns 0 on failure not -1.
- don't run in libglusterfsclient mode if specfile is not provided.
* mod_glusterfs.[ch]:
- porting to httpd-2.2.10 complete. Also implements mod_dir
and mod_autoindex functionality.
commit 08b250cdbb9459d6c8d7ddfb5aea5c55c8dc280e
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Nov 19 06:23:30 2008 +0000
added support for lock-server-count=0
also: changed errno for self heal failure to EIO from
ENOTRECOVERABLE.
commit 5ad72fe40a5ed6e3e579617dbbb2c840268de658
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Nov 19 05:52:41 2008 +0000
bug fix in protocol/server
* protocol/server:
- __server_path_to_parenti() is supposed to return the immediate parent of a path, even
if complete path can be looked up in inode table. bug was that when complete path can be
looked up __server_path_to_parenti() returned inode itself, instead of its parent. this
led to loc->parent being the inode itself and a new inode for the same inode being linked
to loc->parent as a child. this led to a bug where a path like '/path/to/this/file' would
show up as '/path/to/this/file/file'.
- __server_path_to_parenti() now returns immediate parent only, if complete path can be looked up.
commit 7e9332618464132d7c8921ce17a4af9cb8d303ff
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 18 10:26:38 2008 +0000
prevent opening of a file if self-heal has failed on it
if self heal has reached the govinda_g0vinda case:
(differing file types, etc.) then it sets inode->ctx
and open forbids opening of that file and gives
out ENOTRECOVERABLE (State not recoverable).
commit 7de32b117cbf1da6b02b993ba82c7c6e61eaff41
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 18 09:49:45 2008 +0000
implemented fchown and fchmod fops in AFR
commit 822ca881e8595f3681c52de9a2cded793a16baad
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 18 07:35:35 2008 +0000
split option self heal into three
there are three self-heal options now in AFR:
option: default: fops affected:
data-self-heal on write, truncate
metadata-self-heal off chmod, chown, ...
entry-self-heal on mkdir, create, ...
commit bfcdefadceb2f17f6973e5afd39dab7c0c558c4e
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 18 02:10:49 2008 +0000
* bug fixes in nufa.
commit 97ab0f53c5adbc15d5a8626ef73d3512bdff90d9
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Nov 17 19:25:32 2008 +0000
protocol/server bug fix.
* protocol/server:
- __server_path_to_parenti() used to return resolved path as null, when basename lookup
failed.
commit 5a2809473938fff2dc7d62216c510d65c60da4b1
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Nov 17 19:16:02 2008 +0000
* conversion of 'auth.ip' to 'auth.addr' internally
commit 714b734a372fbe66d6d3eddb715592dd7f4cc8ef
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 17 18:30:43 2008 +0000
changed the self-heal log message in metadata self-heal to manually fix permission/ownership instead of deleting files
commit a2d7c8d06b7e3bcd9027465c094e777bfe3642ca
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 17 18:18:10 2008 +0000
bug fix in self heal of symlinks
afr-self-heal-common.c: sh_missing_entries_readlink_cbk was checking for 'op_ret == 0' as success of readlink (should have been > 0)
commit 0c0d32c418a906bcdd31d21dbb5357c822b66cbb
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 17 17:56:15 2008 +0000
include glusterfs-mode.el in glusterfs.spec.in
commit f0d91aa86fc493896fbc46d2f4483fc40c19566a
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Nov 17 14:25:51 2008 +0000
minor change in nufa
changed names gf_dir_lk_{type,cmd} --> entrylk_{type,cmd}
commit bbd23ff258f85980cbbfc08043445d762252ace5
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Nov 17 14:13:54 2008 +0000
made entrylk locks blocking
many files: changed gf_dir_lk_{type,cmd,LOCK,UNLOCK} to entrylk_*
commit c6462ca882e2db3285c065a3428e097830dde3c5
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Nov 17 11:02:04 2008 +0000
nufa translator
* nufa translator which currently is almost same code of dht, but with
local node preffered creates, and lookups.
* removed nufa.h from nufa scheduler
* transport.c; changed 'ib-sdp' to 'inet-sdp' in address-family
commit 6a8271786c187ffc45c5698f33c7d8e246fc2cd4
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 17 06:35:19 2008 +0000
multiple bug fixes
protocol/server: mem leak fix in protocol_server_cleanup() - STACK_DESTROY the unlock frame
posix-locks: deadlock in release_entry_locks_for_transport - was holding mutex lock and returning when list was empty
fuse-bridge: need_fresh_lookup gf_log() was dereferring NULL inode when op_ret was -1
commit 4e00d974f2af83c939ddb96677fc958cc8755bce
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 17 00:22:01 2008 +0000
unlink/rmdir to be unwound after success from all nodes (instead of after first success) to eliminate races
commit c20c59e6e2e22b0e3bf63feefe780e3c9ab2a452
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 17 00:12:24 2008 +0000
quick-unwind for afr-dir-write transactions
commit a747b2a9bd89020d92d74531b15a0da399767e1e
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 16 22:06:18 2008 +0000
afr-inode-write transactions work with quick-unwind technique
commit 16d5ac633cf75fef53c374631b23e979e6982139
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Nov 15 05:32:05 2008 +0000
protocol cleanup
* libglusterfs/protocol.h:
- added 'int32_t dict_len' member to setvolume request and response structures.
* protocol/server:
- cleanup.
- removed unwanted dict entry of "__@@protocol_client@@__key" key. as
dict_serialize/unserialize now support zero key dictionaries.
commit 2eaaad70fa54505a86b2073643efd266290a42f0
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Nov 15 05:24:05 2008 +0000
added dict_new() and dict_copy_with_ref() functions to dict APIs
* libglusterfs/dict.c:
- added 'dict_t *dict_new(void)' API to dict. returns a new dictionary with reference.
- added 'dict_t *dict_copy_with_ref(dict_t *, dict_t *)' API to dict.
commit b478a3e9cab1a4da2fec54fa46a2ad46e454bc51
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 15 00:29:56 2008 +0000
fixed warning in server-protocol.c:3623 (size_t printed as %d)
commit 261377129208bf3f9fce6fd6d176b45412a00b70
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 15 00:23:37 2008 +0000
temporary fix for double inode transform (afr hardcodedly uses first subvolume as read-childe)
commit b61c437f70f00fa7eaffc0da87acb8407d90680f
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Fri Nov 14 09:52:19 2008 +0000
Build fixes on FreeBSD
* ino64_t not present on FreeBSD
* EUCLEAN definition added.
commit a1fdb8561c65325088c35848ed591973c8ca9d37
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 14 00:50:51 2008 +0000
* in fuse_setxattr(), doing a 'tmp_value = memdup(value), data_from_dynptr(tmp_value)', instead of doing directly bin_to_data (value)
* updated glusterfs-mode.el
commit a68afdee913bb617f27b61fcfa2bd24ee90b5948
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Nov 13 21:37:07 2008 +0000
when xattrop fails on all subvols, child up count is 0 which causes fops to hang. refer to ticket 480 on RT for details.
commit 9437e97d6bccfd05007aeed198a439a12134fbfe
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Nov 13 21:31:03 2008 +0000
protocol/server cleanup...
commit 22dc7e1d2419371732e990db0db357e9ef87f4b6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Nov 13 21:25:33 2008 +0000
restructed client_getdents_cbk()
commit 9ee13fec6e83458d26ba1dbcdf81a568afa6c9d2
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Thu Nov 13 18:05:15 2008 +0000
fixed a typo
commit 88e9197a66331e4586d9eea266438bb6713b8c67
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Nov 13 15:56:33 2008 +0000
added dict_set_dynptr()
* libglusterfs/dict.c:
- added 'dict_set_dynptr (dict_t *, char *key, void *, size_t)' to dict APIs.
commit 4c0ee658e4dfd52795d364fbff9bdf42f6ce6963
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Nov 13 15:52:56 2008 +0000
log message enhancements in fuse-bridge.c, dht.c, libglusterfs/inode.c
commit 50d949fe2bd474c2c85a1e39712fb092bb6434b2
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Nov 13 14:10:09 2008 +0000
afr_sh_metadata_sync() the loop which STACK_WINDs should break after the last valid iteration - the "if(--cnt == 0) break" logic. In error-gen including inodelk finodelk entrylk fentrylk in the struct_fops.
commit 64668f11258c775d0aedccc6a61866b6c94596a4
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Nov 13 11:00:11 2008 +0000
changes to option self-heal in afr
option self-heal off now does two things:
- does not do self heal on lookup()
- does not write/erase 'pending' entries on each transaction
commit 700f0ae792dbfce5fb062a2b25ef29c0d5b209ac
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Nov 13 10:16:23 2008 +0000
set local->op_errno properly in afr_lookup_cbk
local->op_errno used to be simply set to op_errno.
If one child returned ENOENT and the other returned ENOTCONN,
result would depend on order of arrival. Fixed it to
return ENOTCONN only if all children are down.
commit a200e337ef91f68b7430fc59c3644462eb9f9561
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Nov 13 02:14:12 2008 +0000
* posix:
handle ENOATTR in xattrop
handle failure of mknod with EINVAL if S_IFREG flag is set, with create.
* compat.h:
correction in lsetxattr code.
commit ee2f4f62be93e034943516792be34f436906ca9a
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 12 20:14:30 2008 +0000
* Added portfile in 'dist' tarball
* removed option 'volname=' for fuse mount in case of darwin
commit 9078ac77469013886c2d15204d3dc119a320e4a9
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Nov 12 14:02:53 2008 +0000
bug fix in afr
decrement call_count twice in ENTRY_RENAME transaction case
in afr_unlock
commit 6b417831a1ee1c8f06dbc26fc826395d9c464e98
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Nov 12 12:39:27 2008 +0000
added option lock-server-count to afr
commit 7beb1c129bd755af7be6fe6a9e342ec93a5350c9
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Nov 12 11:00:15 2008 +0000
io-cache was limiting cache size to 120% of what was configured in "option cache-size" giving 20% buffer. Users were getting confused this extra 20% to be mem leak. Fixing it - io-cache will limit mem usage to what is configured.
commit 7adabb04d055ce3d2d4b4436fbfe6e535254c93f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Nov 11 20:44:26 2008 +0000
protocol/client cleanup continues...
commit e99506486bf17d789cb0f4c7db5a7cfce90eda52
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Nov 11 20:41:08 2008 +0000
xlator.h cleanup
* libglustrerfs/xlator.h:
- removed definition of 'cbk_fop_lookup_t', as it is not used.
commit 6fb50193356badfb8f3e3fd1b28f87718452ae5c
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Nov 11 19:48:36 2008 +0000
bug fixes to features/posix-locks
* features/posix-locks:
- STACK_UNWIND() for fop->lk() was done with 'struct flock' at few places instead of
'struct flock *'. this patch fixes those STACK_UNWIND()s.
commit 942dcf7076c712be95d48c1e13d11f545f8e26fd
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 11 17:17:16 2008 +0000
runtime endianness computation in byte-order.h for cross platform compatibility
commit 0def9b1083ea865983553015f76bcaf66099c757
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 11 14:44:31 2008 +0000
symlink-cache translator - caches symlinks data on symlink/readlink calls and returns cache in readlink() calls
commit 9dab6e4cfc18a71f0eef515a18166a28393b9110
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Nov 11 13:45:57 2008 +0000
read balance implementation. "option wrie-load-balance" is removed instead "option load-balance" should be used (it covers both read/writes).
commit 4bed98defe8de813374a9776326dffbe4a633638
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Nov 11 12:14:13 2008 +0000
"option write-load-balance on" will load balance the write operations. The subvol which will be used is based on (ino % child_count). hence for a given inode same subvol will be used.
commit d196a02fb00264950c40e0bac8c8936bd80e41bb
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Nov 11 11:49:16 2008 +0000
removed mops->{lock,unlock,listlocks,fsck}() ops.
* removed lock(), unlock(), listlocks(), fsck() members from 'xlator_mops' structure.
* removed all the references to lock, unlock, listlocks, fsck members of 'xlator_mops'
structure in every translator.
* removed all the implementations of lock, unlock, listlocks, fsck functions (including
defaults.c).
commit e3885a64a7d47b3fa03358c0c2c596781061c37c
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Nov 11 10:01:30 2008 +0000
protocol/client cleanup continued...
commit 1566d6971cb67c4a32cf7fd9225f5af92bf423f8
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 11 08:35:36 2008 +0000
added option self-heal to afr
commit 08a98c47b707c563b9461bc852c3eb0028c69161
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 11 06:55:21 2008 +0000
added option self-heal to afr
commit aeac06f6dc8685185c21674de245294e2500521d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Nov 10 19:50:25 2008 +0000
* updated mod_glusterfs/apache-1.3/src/Makefile.am so that mod_glusterfs.so is linked to the
appropriate version of libglusterfsclient.so in the presence of multiple installations.
commit 903207cf19c4f434dec865bdeff3d3f7db0666b9
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Nov 10 15:47:17 2008 +0000
bug fix in server_loc_fill()
* protocol/server:
- loc->name was being derived from req->path, which would be free()ed as soon as
server_protocol_interpret() returns. bad effect can be seen when protocol/server is
loaded over protocol/client or performance/io-threads.
- loc->name is not derived from loc->path, which is a duplicated string and will be
valid as long as loc is valid
commit be6fa7a8902feb694f9ea2c75bc80107073bdf4b
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Nov 10 16:04:01 2008 +0000
* fixed typos in fuse-bridge.c and posix.c
commit 6943ad87ea263e9448f74f39e01fe355e2846b9f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Nov 10 10:39:35 2008 +0000
handle ENOTSUP in afr_write_pending_pre_op_cbk().
* cluster/afr:
- afr did not handle errno = ENOTSUP, for afr_write_pending_pre_op(). added errno = ENOTSUP
handling. afr_write_pending_pre_op_cbk() calls afr_transaction_resume() which in turn
fails the fop with errno = ENOTSUP.
commit d80fe5eeea50c5b54c0aff0269b9419a1efff5c8
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Nov 10 09:40:10 2008 +0000
handle O_TRUNC in afr_open
If open has O_TRUNC set, open the fd w/o O_TRUNC and
then do an ftruncate on it.
commit 4e440547e989a6f0255e8ab9bc3fb12b79ad4ed0
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Mon Nov 10 08:58:42 2008 +0000
dht_removexattr bug missed in last commit
* local->call_cnt = 1 was not set so removexattr call made glusterfs
hung.
commit e8931b89064fdba0280f8e20a2c341d4bfda30d8
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Mon Nov 10 08:40:01 2008 +0000
"ls -l" segfault and hang fix for solaris and linux, also various other porting fixes
* MAKEDEV removed from compat.h as "makedev" found on solaris with header
<sys/mkdev.h>
* call-stub.c (getxattr fop) didn't to strdup of xattr name so in case
server segfaulted on solaris with "ls -l" on glusterfs directory.
Even it was not working for linux :(
* ENOENT is generated in solaris_*attr, so needed to set errno=ENODATA
in all such cases.
* Found few more bugs still pending like
cp -avi /etc/ /mnt/glusterfs (hangs with posix_xattrop returning ENOENT)
with afr, several EPERMS are sent for some files. Improper error handling
suspected.
* extended attribute support for device files on solaris might not be present.
investigation still pending i.e dbench fails for "rename" when "DHT" is used.
* dbench 10 tested on AFR working fine with solaris server.
commit bd9570a2777052b14becbe615f76d5e5c767de38
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Nov 10 08:17:41 2008 +0000
changes in rename transaction
Two changes:
- for AFR_ENTRY_RENAME_TRANSACTION, hold locks on both the
source path and destination path.
Hold the lock on the "lower" (determined by strcmp) path
first to avoid deadlocks.
- write "pending" entries on both source and destination
directories
commit 7acbe330748d867dc78ce2046994348d8ddac8fb
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Nov 10 03:15:25 2008 +0000
cleanup, log message changes
* libglusterfs/inode:
- added a log message to log when inode_link is called without a parent.
* protocol/server:
- added few debug log messages.
- minor code cleanups.
commit fd03943b87a39532d8773321052178f56be1b80c
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 9 09:05:26 2008 +0000
added call_cnt guarding break logic in dht revalidate
commit 7aadc12c1af12eac42c6f46bff51f485e14fb938
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Nov 9 00:52:24 2008 +0000
* ha.c: fixed a memory leak
* stripe.c: moved the warning log saying 'option block-size' not given to debug, as now default block-size is taken as 128KB
commit ed51e795d512ef562efb8f34299f5c5d04ac0296
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Nov 8 23:05:28 2008 +0000
* fixes a bug in unify's rename, which was causing the unify's file map to get changed.
* warning fix in dht
* changed -lfuse to '-lfuse_ino64' in case of Darwin, as GlusterFS strictly needs a 64bit inodenumber to work now.
commit ce9389117ddacca7d7310d2f234e176d0dab59c8
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 8 22:32:37 2008 +0000
afr_open was returning -1 when subvolumes returned 0 as op_ret in their open callbacks -- fixed
commit 307cb64ae9894c2fffae3c312b5064f2fe2c9a0b
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Nov 7 10:26:27 2008 +0000
do list_empty after holding lock
commit d32a6a489d2d71290a8e0937b1f17dc241d9b490
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Nov 7 10:07:45 2008 +0000
bug fix in dht_revalidate_cbk().
* cluster/dht:
- dht_revalidate_cbk() used to return op_ret = -1, op_errno = EUCLEAN for 'root'
inode revalidation. reason: local->op_ret = -1, local->op_errno = EUCLEAN were set
during local initialization. dht_revalidate_cbk() sets local->op_ret = -1, only when
stbuf->st_ino == local->st_ino (from loc->inode->ino, in dht_lookup()). but
dht_stat_merge() transforms stbuf->st_ino.
- dht_revalidate_cbk() now properly sets local->op_ret = 0, when local->st_ino = 1.
commit 44719b0618698f4f5fe861e2a17135b3eab59994
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 7 09:26:10 2008 +0000
warning fixes on OSX
* fixed 'type-punned' warnings
* fixed warning issues on Mac OSX,
* in glusterfs.c, specfilefp is closed in cleanup_and_exit().
* added __DARWIN_64_BIT_INO_T flag for compilation over darwin os, as GlusterFS now doesn't support 32bit ino_t.
commit 2bc03d66c3439d45a8b015e57da704a42f637f2e
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 7 09:23:45 2008 +0000
warning fixes on OSX
* fixed 'type-punned' warnings
* fixed warning issues on Mac OSX,
* in glusterfs.c, specfilefp is closed in cleanup_and_exit().
* added __DARWIN_64_BIT_INO_T flag for compilation over darwin os, as GlusterFS now doesn't support 32bit ino_t.
commit 68e2be2997a2a325165b2c6cf1b6c98fc3aa4749
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Nov 7 08:28:17 2008 +0000
'pending' logic changes in afr
erase pending entries only for those nodes on which the
operation succeeded
commit a9354269489938dce103b3f11faeaab65ca06dbd
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Nov 7 05:03:37 2008 +0000
gf_log() related fixes to protocol/server.
commit 1dda211ffaff8104734b64adccb936e1ca4f1808
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Nov 7 04:47:24 2008 +0000
minor cleanup of protocol/server and protocol/client
commit a64049d148ec80795da492b180892484b6678597
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 7 02:13:25 2008 +0000
* warning fixes on 64bit GNU/Linux (Seen warnings on MAC OS X still)
commit b95061523bd6dc2b4ac9727d8e850a739f54b679
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Nov 6 23:14:32 2008 +0000
* minor bug fix in unify, (got added in my last two commits)
commit c33ee8cc15fd5727bf3eb0140252b9d2c9655834
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Nov 6 22:29:36 2008 +0000
* warning fixes in gf_log format
* some cleanup in trace
commit 1aa303978fd3a027583074b23cdd5a51c21b20d8
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 6 21:58:35 2008 +0000
afr self heal - use 'need_entry_self_heal' flag for entry self heal
commit 090546cfded8b432bad7df94c8c4154c41568a09
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 6 21:43:37 2008 +0000
server_protocol_cleanup() cleanup of entrylk locks was not doing server_copy_frame() hence transport pointer was not set and locks were not released
commit 1ede242b35c7d1e1524f82e5df82e874bcff033d
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 6 21:04:04 2008 +0000
dht_rename and dht_rmdir ensures directory is empty before proceeding
commit 89a8d4037e611fcaff1e9a26704a79a164dde270
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 6 19:43:53 2008 +0000
afr directory self-heal -- delete undeleted files when subvolume comes back
commit 3f168044c34a0e8758335d72ef5c555ae653d7aa
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Nov 6 11:22:31 2008 +0000
release entrylk/fentrylk locks when client dies
commit e60abbdcea905f3b7b140bfd494d93066c25fb13
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 6 10:40:26 2008 +0000
afr-self-heal -- recreate missing entries
commit 11d646ca6bab44e60856adbca95ddace65cf92bc
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Nov 6 08:09:12 2008 +0000
* minor corrections in glusterfs man page
* some minor changes in unify.c, also corrected the case of truncate
posix complaince test failure.
* minor correction in quota xlator's init.
* path:
new way of handling loc_t to support newer APIs.
commit 48a331e70b8695f21964845c2631e56ff0772b2a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Nov 6 08:28:09 2008 +0000
* implemented fork in booster, fixed build issues related to including fcntl.h, bug fix related to
change of prototypes in fd.c to take 64 bit fd.
Keywords:
* fork has to reinitialize the booster_mount_table and booster_glfs_fdtable in the child process
to enforce creation of a fresh glusterfs context. This is needed since the mutexes and other
thread related datastructures will be in the same state as in parent just before fork is called,
but only the thread calling fork is replicated in child but not others.
* fcntl.h declares open as receiving variable number of arguments. open was declared in booster to
take fixed number (3) of arguments. Changed open to be variadic function.
commit dabcae2a4d2c4d753202d5376b0058629431eebd
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 5 19:27:24 2008 +0000
* cleanup of PARENT_UP notify flow
commit 2f5aa4f13272cbc2cfbe3a4374af4b94d15cf1b6
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Wed Nov 5 12:53:45 2008 +0000
GlusterFS manpage updated for upcoming 1.4 release
* Closes RT ticket #367
commit 39b74e2dab733673338f6bc9a8a47dd879d462b3
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Nov 5 10:16:25 2008 +0000
release all locks from transport when client dies
server-protocol: send unlock with client_pid = 0 when a transport dies
posix-locks: release all locks of a particular transport if client_pid = 0
trace: added trace_finodelk
commit 4a7aef25a208bfa401ceb4e91c40e893d59c7520
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 5 08:23:40 2008 +0000
print bound_xl and path while logging ENOENT cases in server_stub_resume
commit f72d3a1c691692c05a1fc981bb9f4ce7229d14a3
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 5 05:12:26 2008 +0000
* stripe.c:
send seperate dictionary to each subvolumes when doing setxattr
after mknod and create.
* afr*:
check local->cont.getxattr.name for NULL before free()'ing it.
commit e76f8d1f1a4edeb84b4980bd6d1713614798c1ab
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 5 04:54:39 2008 +0000
added input validation in afr_getxattr()
getxattr() can have NULLL as a key. AFR was strdup()'ing the key without NULL check
commit 25cfdcd5ca69850c6c6f69350b87b15f79d2ec71
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Tue Nov 4 16:12:25 2008 +0000
Solaris 11 Build fixes
* Fixes certain issues seen at hi5.com Solaris servers.
* mod_glusterfs/libglusterfsclient now builds properly
on Solaris 11 with apache 1.3.37
commit 2629a0a1985087f3f0a204c038160a3ce764751e
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 4 16:08:17 2008 +0000
bug fix in stripe
stripe_mknod and stripe_create sends a setxattr() call to the newly created file. the xattr dictionary was not ref/unrefed before and after the call.
commit 534db5435f4d5c87fe59448389f864a428e2a546
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 4 13:57:19 2008 +0000
fixed warning in ib-verbs.c (unused static function ib_verbs_destroy_post made non-static)
commit cfd7c4bd4417cce94c7fbe7ddb5b80375f7133de
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 4 13:22:12 2008 +0000
release mutex when blocking a lock
in pl_finodelk and pl_inodelk,
priv->mutex wasn't being released when a lock request was blocked
commit 4b5c1a7bacfff9f69cbf48d8a522ac0077151b9e
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 4 13:18:30 2008 +0000
handle op_ret = -1 in afr_open, flush, opendir
commit 29688113128149cb070f67b370bb8130fa09f781
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Nov 4 14:02:22 2008 +0000
* booster - implemented fork, to make sure that the child process doesn't inherit booster_fdtable
and booster_mount_table. This ensures that a fresh glusterfs context is created for the child.
* client-protocol.c - fixed a race condition where the timer thread during reconnect
could've sent the GF_CBK_REQUESTs even before SETVOLUME could succeed.
priv->connected was set to 0 after registering for reconnect, creating a window where
in the above mentioned race-condition could've occured.
Hence set priv->connected = 0 before registering the reconnect request.
* ib-verbs.c - Add validation in ib_verbs_receive for headers and size of the data read.
Also removed priv->recv_cond.
* server-protocol.c - Add check for (bound_xl != NULL) in server_protocol_interpret for cbks.
* fuse-bridge.c - fixed typo (EAGAIN was EGAIN).
Keywords:
commit 86f303d05f0ccce567e762215ac2095600a337e4
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Nov 4 10:40:11 2008 +0000
bug fix in do_path_lookup().
* protocol/server:
- ideally do_path_lookup() should lookup in the dentry cache, based on path when
server_loc_fill() fails. previously do_path_lookup() was not doing dentry cache lookup.
- added dentry cache lookup for a path (inode_from_path() call) to do_path_lookup().
commit 07d537fe6d95e00eb953a6fdfb500cb96f6844e4
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 4 10:07:58 2008 +0000
change loglevel of EAGAIN entries to GF_LOG_DEBUG in afr and posix-locks
commit 64040aa1080bea08dafb588fcd6ce1b0eeb7f2b1
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Nov 4 09:15:35 2008 +0000
bug fix in cluster/afr.
* cluster/afr:
- afr_unlock() in afr-transaction.c used to send entrylk() to child xlator, in all
situations. correcty way is to send fentrylk() to unlock when local->fd is set and
entrylk() when local->fd is NULL.
commit 6d7e7f5e0741b1018faf8216d8a45bf46c60a447
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Nov 4 09:05:42 2008 +0000
disabled afr initiating glusterfs shutdown.
* cluster/afr:
- removed 'option readonly <on/off>' for afr.
- afr returns op_ret = -1, op_errno = ENOSYS for all write (directory, inode) operations
if features/posix-locks xlator is not loaded.
- previously added behaviour of afr to initiate glusterfs shutdown is now removed.
commit 7e9a52cafd8f18dc436239ef65ffd4e2ca53f9df
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Nov 4 05:51:43 2008 +0000
* fix build errors in apache-1.3/mod_glusterfs. Also removed declaration of core_server_config
from mod_glusterfs.c. Instead #define CORE_PRIVATE to enable the declaration of http_core.h
commit 97fb8276bff1270c0fd6715ca48fb01ba5c7cc2b
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 4 04:03:20 2008 +0000
* bug fixes in unify selfheal part (caused by previous commit)
commit ec0362886b78c151ef2b9e60528579a59a47fcd6
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 4 02:33:02 2008 +0000
* posix.c and bdb.c:
removed 'mkdir (directory->data);' which was creating directory if the
export dir was not specified. From now on user needs to specify the
existing directory only for glusterfs to work fine.
* dht.c:
added entrylk, fentrylk, inodelk, finodelk, xattrop, and fxattrop fops,
so that AFR can work above hash.
* unify*:
- changes in self-heal code to support afr as subvolumes, which holds the
'entry' pointer of setdents for long, whereas it was free'd as soon as
setdents was called in unify. Now the freeing of entry happens in
setdents_cbk.
- coding standards. (did indent-region with new mode's tabs and spaces)
* client-protocol:
minor changes in getdents_cbk to support 'entry' being NULL after
STACK_UNWIND.
commit 1871110d38e01c01236b67ab4f4b1402bf877f18
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Nov 3 21:10:55 2008 +0000
minor change to afr to identify absence of features/posix-locks.
* cluster/afr:
- afr_lock() calls local->transaction.done() with op_ret = -1, op_errno = ENOSYS
if child xlator returns op_errno = ENOSYS (which indicates absence of features/posix-locks).
- afr optionally triggers shutdown of glusterfs or continues as a read-only xlator based on
'option read-only <on/off>'. if 'option read-only on' is specified in spec file, then afr
continues to operate as a read-only translator, else triggers glusterfs shutdown (by raising
SIGTERM).
commit 3d4981487c257312ce58a8bdd976d207bbfd5c28
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 3 14:22:29 2008 +0000
dict cleanup
commit 3150fac46f017fd12c491c8e9cb8cbda758ff775
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Nov 3 14:19:07 2008 +0000
* fixing the return values of glusterfs_open and glusterfs_create in case of failures.
since they are supposed to return the ptr of fd structure, a NULL has to be returned in case
of failures. Earlier a value of -1 was being returned.
* fixing logs in gf_fd_fdptr_get. changed the loglevels and do an fd_ref iff fdptr is not NULL.
Keywords:
commit 1602173fe2038cf61e1af6eb09dd1c45d0b8293c
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Nov 3 11:54:08 2008 +0000
fixed protocol/server/src/Makefile.am
* protocol/server:
- added server-helps.h to noinstall headers list in Makefile.am
commit 4cea1912a11df3c53e0fdc3fa759acb536621bf5
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Nov 3 11:32:10 2008 +0000
bug fix and minor changes to protocol/server.
* bug fix:
- server_loc_fill() always (when ino = 0), returned without searching inode and this led
to duplicate inode creation, even though one already exists in inode table. the same
bug led to the log message 'paths differ', which was very frequently seen while using
protocol/server.
- server_{entrylk,fentrylk}_cbk() calls never called gf_del_locker() to delete accounted
locks. reason: server_{entrylk,fentrylk}() set state->cmd and never touch
state->flock.l_type. server_{entrylk,fentrylk}_cbk() were supposed to check state->cmd,
to decide whether to do gf_add_locker() or gf_del_locker(). but server_{entrylk,fentrylk}_cbk()
used to check state->flock.l_type.
* other changes:
- moved all the helper functions to server-helper.c. also added prototypes and macros in
server-protocol.h.
commit 91444b705ab363d119dcc1630ca5ba987e662a2a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Nov 3 08:48:49 2008 +0000
commit e924949b0f7dcdfb2b6576561f3ff486657e6ad0
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 2 16:24:07 2008 +0000
mem leak fixes in posix-locks
- lock type F_UNLCK was never destroyed
- destroy temporary locks in insert_and_merge
- loop with temporary variable in delete_unlck_locks()
commit b19e8983850a0337f191739fc8332259b9873287
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 2 14:23:37 2008 +0000
fixed leak in call-stbuf for entrlk and inodelk (loc_wipe)
made user_flock embedded member of posix_lock_t (previously was pointer and allocated)
commit 75812de2890d47ecee18fa171f6885d05e3068b8
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Nov 2 09:33:09 2008 +0000
removed rmelem() fop.
commit 1c039192bc848c8e7ad25d704a4d18213413518c
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Nov 2 08:54:40 2008 +0000
removed error-gen.h
* error-gen.h is not needed. moved definition of eg_t structure to error-gen.c.
commit 7be816e28b1d61b3b8969184fce4fba9983475e9
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Nov 2 08:44:45 2008 +0000
fixed memory leak in protocol/server. split xattarop() to xattrop() and fxattrop().
* protocol/server:
- server_{entrylk,fentrylk}_cbk()s were expected to do server_loc_wipe() before calling
protocol_server_reply() and were missing. added server_loc_wipe().
* xattrop() ==> xattrop(),fxattrop():
- previsously xattrop() optionally took fd or loc_t parameters. now xattrop() only takes
loc_t and fxattrop() is added to handle fd based xattrop().
commit 9b659fea51c3085147961ee0d49df15722e41744
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sun Nov 2 07:34:03 2008 +0000
STACK_UNWIND was not returning NULL whenever extra args had to be returned.
commit 543209d5afd3807291b4bc59c78cbd3a8d924070
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Nov 2 02:31:56 2008 +0000
bug fix in protocol/server
* protocol/server:
- dictionary lengths of the dictionaries passed from client were interpreted wrongly.
<server_state_t>->dict_len was used for doing memdup(), dict_unseriaze(). but
<server_state_t>->dict_len was never set, instead a local 'size_t dict_len' was set.
- removed 'dict_len' member from 'server_state_t' structure. dict_len is passed correctly
in memdup(), dict_unserialize() in server_xattrop(), server_setxattr().
commit ea2f8dfaf3a27ad2d023543e67a4f285f26cc83f
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Nov 2 00:34:21 2008 +0000
* minor correction in xattop path.
* corrected header years in error-gen.{c,h}
commit 2a708311ad187218f361dfdd4533b1dc4811f7a3
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Nov 1 18:54:56 2008 +0000
changed libglusterfs/protocol.h to pass only the (file/inode related) parameters which
fuse-bridge passes.
commit 682b8932d12cb047019800de290ae4d70c7f3145
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 1 14:57:18 2008 +0000
removed data_t->is_locked. all dict operations are always locked now
commit debbe21b9f6ee7b049da7d7c8bc5f3f43671bd83
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 1 11:27:28 2008 +0000
fix in client_xattrop to properly check for NULL fd
commit 674910eb37671f8a33b9e084beeba013fcf25419
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 1 10:36:54 2008 +0000
warning fix in error-gen (xattrop prototype changed)
commit 353a35bf684e1a07f414ed9fc3e89e66cf441528
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 1 10:26:51 2008 +0000
warning fix in error-gen (xattrop prototype changed)
commit c1b55e5a550b26b336442a50496970def785caee
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 1 10:17:36 2008 +0000
added error-gen.h in noinst_HEADERS in Makefile.am
commit f48d1d4cdc1b1420c8f2b52feb515d3c40f46217
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 1 10:06:17 2008 +0000
loc_copy() now copies loc->ino too. Was causing warnings in protocol/client used with hash
commit 32e277a029d3c4d02c4bc91adb20d7ad148b7a68
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 1 08:03:02 2008 +0000
fix last_tried logic in afr-{dir,inode}-read and bugfix of #412
commit 91eb69a598fda1409c9e87980c5a78d9e733b648
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Nov 1 04:27:04 2008 +0000
changed 'const char *path' parameter of xattrop() to 'loc_t *loc'
* xattrop takes 'loc_t *' as a parameter in place of 'char *' (path) as used earlier.
* made changes to all translators, defaults.c to implement 'loc_t *' parameter to xattrop.
commit 02882c8dfadc9cd83f3df37f109d5e85c3ca287c
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Oct 31 18:31:42 2008 +0000
error generating xlator (named it error-gen with avati's approval). Two bugs were exposed by this xlator in HA. Fixing those too.
commit 5a75caeca2fb75c3c1c41b1769563c7f63c4a6b7
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Oct 31 16:16:50 2008 +0000
fixed race in pl_flush() where lock was not held, which resulted in segfault (double free) of locks
commit 1e6f6347f497e5543895444e52c009c4deeb1a26
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Oct 31 08:30:26 2008 +0000
bug fix in protocol/server
* server_loc_fill() is supposed to fill all the fields in loc_t. but <loc_t>->ino was
never set and was always zero. changed server_loc_fill() to update <loc_t>->ino also.
commit b9c941dbee77184ba32785ce4fb6b10973905abd
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Oct 31 06:52:39 2008 +0000
writev leak fix in afr
dht_link_cbk - use inode number from request in reply stat buf
commit bfc77fdb1106ec90c1a4d71a510969a4e577320c
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Oct 31 06:07:46 2008 +0000
minor fixes to call-stub and protocol/{server,client}
* call-stub:
- changed 'basename' to 'name' member for entrylk, fentrylk.
- added NULL checks for fd, before doing fd_{ref,unref}()
* protocol/client:
- this_ino_get() now returns '1' for root inode.
- client_entrylk() was missing to set parent inode number, in request structure.
fixed it.
* protocol/server:
- minor cleanup.
* mount/fuse:
- changed log level of a success message in fuse_forget() from GF_LOG_ERROR to GF_LOG_DEBUG.
commit bb43fda1bf34d0611570ffa7a95c53b93bc81047
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Oct 30 21:20:59 2008 +0000
* call-stub.c: handled case where basename can be null for 'entrylk'
* posix.c: path can be null in case of xattrop(), when its called by a fd based function. (like writev from afr). added if (path) check..
* inode.c: added a assert in __inode_link(), also changed printing of pointer in inode_replace, from printing both the inodes only.
* afr-inode-write.c: added dict_unref (frame->root->req_refs) (Thanks to avati), to free the held write buffers.
* fuse-bridge.c: added checks in fuse_loc_fill, also added logs for printing inode numbers everywhere possible.
commit e467aa7a2d223e7e393f2070c91cd7c2c44f8710
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Oct 30 15:37:18 2008 +0000
changes in libglusterfs/{protocol.h,common-utils.h} and protocol/{server,client}
* libglusterfs/common-utils.h:
- added STRLEN_0() macro, to get length of a string along with terminating NULL character.
* libglusterfs/protocol.h:
- added par (parent inode number) and basename (basename of path) members to
gf_fop_<fopname>_req_t structures, wherever loc_t is used.
* protocol/client:
- minor cleanup.
- send parent inode number and basename to server, wherever loc_t is used.
* protocol/server:
- added new parameters to server_loc_fill(). server_loc_fill() now takes inode number,
parent inode number, basename also parameters.
- server_loc_fill() searches inode table for parent and the inode using respective
inode numbers, replacing previously used inode_from_path().
- server_state_fill() updates parent inode number, basename of path in server_state_t,
by using newly added par, basename members of gf_fop_<fopname>_req_t structures.
- minor cleanup.
commit 76e682b32d1d2b3260bed5602567be094999046b
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 30 14:40:14 2008 +0000
changes in DHT to return mtime/ctime/atime properly in all fop cbks
commit 99f385858e91b3c681fa5e310fbdc41ac44f23a3
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Oct 30 07:53:47 2008 +0000
leak fixes
* unify: removed unify_forget(), as it was doing nothing.
* posix-locks: changed all the code where 'pl_inode_t *inode' to 'pl_inode_t *pl_inode' as use of 'inode' for something which is not inode was a bad naming convention.
* posix-locks: fixed a leak which was happening with each inode, as pl_inode was set as 'bin_to_data' which sets 'is_static', ie, it won't be freed by default in forget. Changed it to 'data_from_ptr()', now the leak is gone.
* io-threads: same as above, the entry in fd->ctx was static, so was not getting freed. now added iot_release(), to handle that.
commit f2ee24f863d69a18d9dcda9990f13de9bdced93e
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 30 06:10:40 2008 +0000
fd leak in fuse_create (introduced in my previous commit) fixed
commit 53ce7df84445f6946f8fa6e8e1daec6a751f65f2
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 30 05:39:28 2008 +0000
mem leak fixes in afr
extra dict_ref was happening in afr_transaction_pre_op()
transaction.basename and new_basename was leaking in all ops. AFR_BASENAME was returning allocated string
dict_unref of cont.lookup.xattr added
commit d11978cd7ef7d402b8389ab1c1ff6b70012c7425
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Oct 30 00:57:30 2008 +0000
* in client_protocol_xfer(), if server is not connected, the reply was not properly handled for '_OP_TYPE_CBK_' hence was causing segfault when 'RELEASEDIR' cbk was calling 'client_stats_cbk'. Fixed the bug by handling this case too.
* in glusterfs.c, in cleanup_and_exit(), there was a possible race. from this function, xlator->fini() was called, and in fuse:fini(), raise SIGTERM is done to make sure the fini() of all the translators are called. This was leading to multiple signal_handler invoke, and because variables were not reset, it was causing segfault by trying to do 'fclose()' on already closed FILE *fp.
commit 7cbcc606e51e88b30359b8bbb055ca732b15ada8
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Oct 29 19:44:10 2008 +0000
changes to incorporate the coding standards. This also fixes bug "392" (RT). In call-stub GF_FOP_READDIR was not being handled - fixed that.
commit ec46da45077473bddf69a6424a99ed9eca2ada99
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 29 18:22:00 2008 +0000
afr_mknod_done: was setting buf.st_ino to 0
posix-locks names_equal(): NULL check added which was causing segfault
commit 5364a58bbd121ea2e8534aacd7f116b271aca643
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 29 17:55:45 2008 +0000
fix in protocol/server cleanup
dirlk unlocks were sent from file_lockers list
commit 372f8641ea176b3f49968ae27a92ebe5eaa5c2a8
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 29 14:51:06 2008 +0000
fix call_count race in many places
afr_cleanup: FREE parent_loc & new_parent_loc
commit fdf90349c8c6c58644e56c223be788c168f2f6d4
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 29 13:58:39 2008 +0000
fix in truncate call count in file self heal
commit cae99df46f4b0cc7b4dee1382f314086ae5e1248
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 29 13:32:30 2008 +0000
fixed recursion bug in afr_lock (transaction)
commit b6a9349319ca09bb35e3e8ad17a460178167a619
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 29 13:24:00 2008 +0000
guarding breaks in afr_open and afr_flush
commit 06259c677c28937dcba79aed4a662f654617f751
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 29 12:56:39 2008 +0000
multiple fixes
fuse_fd_cbk, fuse_create_cbk: fd_unref was happening on NULL fd in failure
afr_create: fd was stored in local->fd. moved it to local->cont.create.fd
afr data self-heal: fixed races and correctness
commit e43cd820ededd4558216331d2d996220f55b8631
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 29 12:14:02 2008 +0000
implemented setdents
commit cae0848b1d8105211b8dad8ac0317571459ca8c5
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 29 11:43:22 2008 +0000
try locks serially instead of parallel in transaction
commit 101b6256a01fe983fb7defab22e3ff47724a9321
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 29 10:14:49 2008 +0000
intermediate commit to sync changes
commit 7f88df2e69b37f8afacdcab9d1f730f0167ad2c2
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 29 04:52:28 2008 +0000
fixed symlink bug #404 in AFR
commit 585bf07c8492adda47962cdd9106f52b1b26acd2
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 29 04:43:20 2008 +0000
added checks against AFR keys getting self-healed during xattr sync
commit a7f6afbd6f95637d0d5a9b94d1d50f071b058423
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 29 02:28:18 2008 +0000
* removed 'loc_t tmp_loc' in unify and used 'local->loc1' or 'local->loc2' whereever requried.
* in server protocol changed fd_unref (fd) in case of open/opendir/create failure case to 'if (state->fd) fd_unref (state->fd)' as in case of 'op_ret == -1' fd returned in cbk may be NULL.
* changed all the logging of 'state->fd_no' from '%d' to '%"PRId64"', which matters for portability reasons.
* an infinite loop initialization bug fix in xlator_tree_init (), which can happen if server side unify is defined. Fix is to comment out 'getting the top xlator' in xlator_tree_init(), instead initialize the graph from the given translator level only.
commit 5c590d0f85d929a3a2b014032949fff74f0af0ae
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Oct 28 18:55:32 2008 +0000
added 'guarding breaks' in loops of afr transaction for preventing race on local->child_up
commit 0d1da359818045e86f15acb3341889ac18eb1b79
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Oct 28 18:21:13 2008 +0000
- afr metadata selfheal completed
- added tool to merge stripe file components offline
commit 7d1c61f52ce74cbd5583f5756e531d55a38c8c14
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 28 12:35:39 2008 +0000
some transaction related fixes
commit 97d76b6fae1e1b7a6c948adefe508e466cf7bb4a
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 28 12:13:20 2008 +0000
renamed dir_transaction to entry_transaction and dir_link to entry_rename
commit d2f8e978e34a3901497f22b9e0a05d9208a6d10c
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 28 11:58:40 2008 +0000
handle case of child_count 0 in AFR_LOCAL_INIT and return error
commit 3f0af6288bab3f957de1ad4089cc4540bafefe5f
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 28 11:40:13 2008 +0000
copy priv->child_up to local before starting an fop
commit f490ce9c814b3fa3e3d6e18a7d00c4dba9d4eefb
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 28 10:50:54 2008 +0000
two fixes
- afr_rename: hold the lock on the proper loc_t
- transaction xattrop: write it on parent directory for create
commit fe405f3a79752921b1d200ad901b95c088234aa1
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 28 09:32:59 2008 +0000
fixed minor bug in client_inodelk
commit 92387e1cd164906fa5d3a541e8519e1c641c0f39
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 28 08:14:22 2008 +0000
lk changes
- gf_file_lk is now called inodelk
- a new fop finodelk added which takes fd instead of loc_t
- gf_dir_lk is now called entrylk
- a new fop fentrylk added
- added document about adding new FOPs.
commit e5d9bbf607acb73fb8453a4bff6df521dfc58cf8
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Oct 28 04:30:50 2008 +0000
* minor bug/leak fixes in unify.
commit e081048beb406699208b9cdbd3d7a831d093ed8e
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Oct 27 20:50:55 2008 +0000
afr self heal now creates missing entries
commit 29a028493d5d74486651fcadb1d14d189d0daab7
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Oct 27 15:02:52 2008 +0000
intermediate commit to sync with lk changes
commit f8494b61b7cfefdbdb0d4991c89809dc55097701
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Oct 27 13:11:56 2008 +0000
merged transaction.success and transaction.error into transaction.done
commit 72db50ac809d537dd79033f29a6dd38572d07845
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Oct 27 12:01:15 2008 +0000
implemented setxattr and removexattr in afr
commit 8a694dcf4b492544e32c699d179c76c39ae45a83
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Oct 27 11:31:08 2008 +0000
added AFR_BASENAME helper function
commit c5c9dae5c3ee4bff17b1766d95906fea5850c263
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Oct 27 11:12:40 2008 +0000
added null checks etc. in afr
commit 03b8c693d82f8175d87dfcb0d921511c5f2fe383
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Oct 27 10:02:20 2008 +0000
fixes in protocol/client and afr
commit 9a5291348275a630e64e2f61246489db8ed1abfe
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Oct 25 18:24:39 2008 +0000
set fd->flags properly in creat
commit e1aa278fb3657f317faee46a20d4e73ef1a2dadd
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Oct 25 16:22:50 2008 +0000
print a big scary warning message when option 'favorite child' is used in AFR
commit 52fc57dbb9e3aac2fd5c428ee8367bfcb5ab2036
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Oct 25 15:52:20 2008 +0000
added ->flags to fd_t
commit 6bcadd1ee5e7caf448e7e3af7a81bd701e08d668
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Oct 25 14:04:58 2008 +0000
two changes in AFR
- added option 'favorite-child' to help split-brain resolution
- if an fd is opened in O_APPEND mode, lock the entire file during writes
commit 44c03499228e76c8a26a4bf49e0ca5203bc38cc8
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Oct 25 11:11:01 2008 +0000
fix selfheal case where NULL layout was returned to caller
commit ff6210520980e7ff1f6506288bda626dc821d5c5
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Oct 25 06:28:41 2008 +0000
dht_mkdir_cbk was skipping merging of failed callbcks -- fixed
commit b3ddefa4ab7a1b04bb8b0b887db38d09b02f34a8
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Oct 24 16:06:04 2008 +0000
moved common code to afr-self-heal-common.c
posix-locks: moved unit test to tests/ directory
commit fe8dbaeaa42a71b486dc59e3fdfd42a28c0d1719
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Oct 24 13:46:14 2008 +0000
print configure summary output to stderr
commit f14a51927f651feeed7793a7b3ba66c59cad60c9
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Oct 24 13:32:20 2008 +0000
fixed warning in ALU scheduler about unused function declaration
commit bac6ff6e15709da1b99c97bcfbf64652f0a5b2c3
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Oct 24 12:31:14 2008 +0000
fixed race condition in pl_gf_dir_lk (ticket #400)
commit f2285f2ed00ce87c38cfe4d6cc02bdb24c6d72bd
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Oct 24 11:50:11 2008 +0000
cast to (long) before casting to (void *) when passing cookie
commit 43890045423acfd5ea7333a26f147cbba497dc4a
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Oct 24 11:38:42 2008 +0000
warning fixes necessary to enforce -Werror in gluster-qa-release script
commit 118ed81b9c01cc28a14c98f514ce145395210f65
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Oct 24 11:27:23 2008 +0000
use server_copy_frame instead of copy_frame when releasing held locks
commit c56acab258b67c682ea730a0d58b20764c47b036
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Oct 24 10:53:36 2008 +0000
typecast cookie to (long) instead of (int) to avoid warnings on 64-bit
commit b60752c66818f054b8323f7d637f61440a80aeb4
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Oct 24 08:50:28 2008 +0000
partial cleanup of client-protocol
commit bb37557b2e7e5149a119e82823c5b068a1387bcc
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Oct 24 08:34:03 2008 +0000
* uses gf_string2boolean in init() while parsing options instead of strcmps.
* in fuse, added check for fuse_forget's inode_get, if NULL, now logs an error and returns.
commit 913b544ab303f8a5f752a6fbd4ac2a1ed0a66902
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Oct 24 07:35:00 2008 +0000
- fix bug in inode_adopt_children()
- fix bug in dht_hash_compute
commit c8508df651c97caba3fb5eb64de2b844062898f7
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Oct 23 21:26:09 2008 +0000
fixed bug in server_gf_{file,dir}_lk_cbk() to handle op_ret = -1
commit acbea57cd3b22f744cab162d67baceb9bb58d72e
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Oct 23 21:21:31 2008 +0000
updating state->loc in server_gf_{dir,file}_lk_resume added
commit db7aedca36a80af2a996d22d8827181063c63726
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Oct 23 19:48:10 2008 +0000
changed type of all instances of fd in protocol.h to int64_t.
* changed type of fd to int64_t from uint64_t
- fd = -1 is used as indication of not passing a valid fd, for xattrop and gf_file_lk calls.
* made relevant changes in protocol/{client,server} and fd.{c,h}
commit 9064849f5c6b02ea61d74d0386a09c8abd7bec18
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Oct 23 15:33:22 2008 +0000
inode data self heal fixes in afr
commit b25163437a704c0edb09141a2b94f61162eb7924
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Oct 23 07:58:10 2008 +0000
* added #ifndef HAVE_STRNLEN part of code if strnlen is not found in std libs.
* added ha.h in make dist, so make dist works fine
* minor chages in fuse-getxattr in case of darwin
commit d69791d152a9c22330c31b30edb7de1600759ee0
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Oct 23 07:48:08 2008 +0000
fixed afr warnings to appease gowda
commit 89bbfc3b007d4c4c28df4c12bcb663d9b2449b52
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Oct 23 07:11:26 2008 +0000
minor fixes to libglusterfs/defaults, afr and protocol/server.
* libglusterfs/defaults:
- changed one of the arguments of defaults_xattrop() from int32_t to
gf_xattrop_flags_t.
* afr:
- fixed prototype of afr_link()
- added prototype of afr_inode_data_self_heal() to afr-self-heal.h
* protocol/server:
- swapped loop counter (locker) and temporary identifier (tmp) in all usages
of list_for_each_entry_safe() macro, for correct usage.
commit 9fcf7c372bdc45656121d4b2ff6a8f0cad0770af
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 23 04:46:05 2008 +0000
protocol/server was doing ntoh32 instead of ntoh64 for fysncdir fd
commit 94bf370f5875e109af759dbe66bfc3bcf8eb4f78
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Oct 22 19:08:50 2008 +0000
added glusterfs internal lock accounting to server protocol. minor changes to fd.c
* internal lock accounting:
- protocol-server now keeps track of all the locks held by clients on
per connection basis. (using gf_add_locker, gf_del_locker procedures)
- protocol-server releases all the locks held by a client, on client disconnect
* fd.c:
- changed gf_fd_fdtable_destroy() to do fd_unref() on each of the fd remaining in the
fdtable.
* trace.c:
- changed argument type of fifth argument of trace_xattrop.
(from int32_t to gf_xattrop_flags_t)
commit dfbb5f056384d42ef2685fcd0c9a5a3f25481d57
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 22 16:05:16 2008 +0000
MAKE_RSYNC_FRIENDLY() macro to make rsync's renames less expensive
- also fixed Makefile.am build break in afr
commit ce3da2f863cd2097c18dd1384ab9b9cc2d4a4021
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 22 15:00:49 2008 +0000
renamed afr-self-heal.c to afr-inode-self-heal.c
commit f9b635cb2b2c79590215f3e27ea8d85871e460ff
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Oct 22 13:07:35 2008 +0000
moved #defines typedefs etc to ha.h, minor changes to lk code.
commit 11145bb0ebfd14741999656bfde97eea6b0d31d1
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 22 12:12:50 2008 +0000
fixed a bug in afr fstat, commit for qa41
commit 0f33180bc3c8421c256c954d88b4b4b8d7d82c3d
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Oct 21 23:05:24 2008 +0000
* bug fix in stripe to show proper block size for the file.
* extended attribute in stripe is now optional (so one can do stripe volume on tmpfs too)
* minor bug fix in darwin part of compat.c
* added volume specfile options array in bdb.c
* added some scripts to do i/o benchmarking
commit 380a0e82e39a950b4f732acd9bd3227289d313fc
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Oct 21 11:05:54 2008 +0000
added dict_{get,set}_(u)int{8,16,32,64}() procedures to dict.{c,h}
commit bbd3b4e12320b00c0e12f64b452be2adcd74e568
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Oct 21 02:53:23 2008 +0000
fixed memory leak in protocol/server and mount/fuse
* fd_unref() was not called to destroy a created fd, in case of a failed
open/create/opendir in both mount/fuse and protocol/server.
commit d1fdd85dbe772f4a1958583454389c2674684d2a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Oct 20 13:53:39 2008 +0000
introduced hafd_t fd structure for HA xlator. LOCK & UNLOCK of this structure is done whenever hafdp->fdstate is accessed. hafdp->fdstate is used to maintain the subvols where fops can be tried.
commit 61bfecc1cd43b3a0c95fa836c0f211b09b9d7120
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Oct 17 01:37:06 2008 +0000
* Mac OSX extended attribute changes for proper working over Finder (final round :p)
* Strict checking disabled for few parameters of 1.3.x release options in specfile (where you get warning instead of error)
commit 4aecc142239a092cfe9b90cd81e29bf229703132
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Oct 15 14:45:11 2008 +0000
fixed server-protocol's mop_setvolume to handle error case gracefully.
* at multiple places in server-protocol's mop_setvolume, dict_set(,,data_from_dynstr())
was followed by free()ing of the string memory. this causes a segfault during
dict_destroy() which again tries to free() the string memory.
commit e4c44dd0996b8d00d02b7904d0cd503802e1fee0
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 15 12:16:09 2008 +0000
locking fixes in AFR
commit cb3acbc3aba2aea3346f0b7d64a6fdf1857693ba
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 15 11:38:59 2008 +0000
fixed couple of leaks in afr-transaction.c
commit d572617a5257155a2778b14393045e126b9304a4
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 15 11:26:06 2008 +0000
fixed bugs in server/client protocol gf_file_lk
commit 91d0ab9fbbc5845d7d63d5e487e6cfd3cfcb8ecd
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Oct 15 11:24:01 2008 +0000
HA xlator checkin ... ooops commit.
commit 099984ab47ddf63e5294992bf147c062fc648ca5
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Oct 15 11:18:19 2008 +0000
fixed inode leak in protocol/server
* __do_path_resolve() procedure missed to inode_unref() the 'parent'.
commit bb039c4f0d1281b271cdab93310eaf7967a7d390
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 15 10:11:52 2008 +0000
renamed afr files
commit 37a4aec3077cc168b1a321d8a6f10af793bcab53
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 15 03:29:44 2008 +0000
* now posix init() fails if extended attributes are not supported. this feature can be overridden by an option, if required.
* xattr support check in notify of stripe is removed.
* OS X extended attribute support order is changed now. added a doc/mac-extended-attrs.txt file to explain it.
* some renaming and addition of document files.
commit eb1d6c52df9e9da59d6442f69d9ec60ab350bafd
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Oct 14 16:23:56 2008 +0000
addition of new op_type, moved close/closedir/forget from xlator_fops to xlator_cbks, removed incver fop
* libglusterfs/xlator:
- removed declarations for close,closedir,forget fops.
- all xlatos are now supposed to define close,closedir,forget ops for xlator_cbks members only.
- removed incver fop.
* libglusterfs/inode:
- removed the case of calling <xlator_t>->fops->forget.
* libglusterfs/glusterfs:
- added new set of op_types (GF_OP_TYPE_CBK_REQUEST, GF_OP_TYPE_CBK_REPLY).
- added new set of ops (glusterfs_cbk_t).
* protocol:
- changed <server/client>_protocol_interpret to recognise new op_types and new ops.
(as added to libglusterfs/glusterfs)
* libglusterfs/call-stub:
- removed stub creation procedures for close and closedir fops.
- removed procedures related to incver
* scheduler/rr:
- replaced reference to incver with xattrop.
* also fixed few minor log messages and build warnings.
commit 5b57150259b527d022e5a26ab3b983878a0d1acf
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Oct 14 17:21:08 2008 +0000
* fix to dd returning EIO with write-behind.
write-behind was returning the size of aggregated writes of more than one request as the return value
for each of the request, if the request was not already stack_unwound. Since
op_ret != sizeof (write_buffer), fuse used to send EIO.
commit 9ec8439075595e4439c81bbd66010b22ff320b66
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Oct 14 15:41:43 2008 +0000
fixed bug in stack.h
commit f855b0c0ecdde514e14f19b92d14ef7d984f6a58
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Oct 14 14:54:29 2008 +0000
rename call_ctx_t to call_stack_t
commit 8c669a71bf80c2e06dc975a369b7c997196bab6d
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Oct 14 12:19:59 2008 +0000
fixes in dht selfheal
commit 96183ab6fea76fb4c5045271220a4bb65fa21f9a
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Oct 14 09:39:44 2008 +0000
send fd in fsyncdir
commit 33d4ff492871d121feb09b517d2cdb9182281f3b
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Oct 14 09:35:36 2008 +0000
send fd in fsyncdir
commit 600f856adbb4ab4ff0495c5f4bcb9a02e2ba9146
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 14 08:10:40 2008 +0000
added stub for xattrop
commit f6df117a61a2f2c67a3bf777a46809ce342782de
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Oct 14 06:41:45 2008 +0000
Makefile.am fix for mount/fuse/utils
* removed ugly shell tricks from mount/fuse/utils/Makefile.am
* added AM_CONDITIONAL() in configure.ac for setting GF_DARWIN_HOST_OS
for use by automake
* added automake primary SCRIPTS to install mount.gluster (mount_glusterfs for darwin).
commit 90ff730d185d4d137683a628a5a2c61f520c7be6
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Oct 13 16:20:57 2008 +0000
* fixed a segmentation fault in apache/mod_glusterfs. If request->per_dir_config was NULL, for files not
on glusterfs mount, mod_glusterfs_dir_config used to segfault.
* Changed posix-locks/src/Makefile.am to include common.h in tarball built for distribution.
* Changed afr/src/Makefile.am to include self-heal.h in tarball built for distribution.
* Updated documentation in apache/mod_glusterfs, lighttpd/mod_glusterfs.
commit 8e48e4754ba493f9dc13cf6ad1fe5e96359afdc9
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Oct 13 09:33:59 2008 +0000
added "afr-" prefix to all afr source files
commit 47fbbdd8a10c57c8ee5bfa6d9de6e25adf11b1c8
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Oct 13 08:10:59 2008 +0000
bug fix in dht_layout_entry_cmp()
* layout->list[].start is of type uint32_t and dht_layout_entry_cmp() used to
implicitly cast layout->list[].start to int. this causes a value larger than
int max, to be treated as a negative integer.
- this wrong treatment in turn misleads dht_layout_sort() to return unsorted
layout list to the caller.
- now, layout->list[].start is typecasted to int64_t before using in dht_layout_entry_cmp()
to ensure that large values are not treated as negative values.
commit 493389d486eb90fbc7c701cc49880afcef6cd097
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Oct 13 02:39:21 2008 +0000
added fd argument to gf_file_lk
commit d224a2c2f3a4bb9b16e5449961629e74a1188bb4
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Oct 12 18:13:05 2008 +0000
added self-heal.h
commit 49fcfeb6520b3d719f61e7c7771dbee3f5fdf877
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Oct 12 17:51:21 2008 +0000
added afr design document
commit bc727c3e7dac22747ffcb5f360c690794cd0a762
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Oct 12 06:56:13 2008 +0000
committing due to fear of hard drive failure
commit a4923ba72bf032b3b741ba4e3b9f8fd2beee4f0f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Oct 12 06:05:09 2008 +0000
minor bug fixes to protocol/server and libglusterfs/inode
libglusterfs/inode:
* changed inode_table_prune() to a static function.
protocol/server:
* removed reference to inode_table_prune() from protocol_server_reply().
* changed loc_t usage for newloc in server_link() and server_rename().
* fixed SERVER_DENTRY_STATE_PREPARE() macro to set state->loc.path to
immediate path to be looked up.
- earlier it used to re-lookup resolved path.
commit 5f32127778397c85290baef0368170157e7eacb4
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Oct 11 18:45:29 2008 +0000
bug fix: enable all calls by default in trace
commit 6043cd79d070542d98d14e713b785064984ea9d1
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Oct 11 08:18:38 2008 +0000
fixed bug in dht_rename (EEXIST)
commit 646aff6f7e9426d44d43df6f359833f6ce862608
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Oct 11 05:21:03 2008 +0000
* added gf_file_lk, gf_dir_lk, xattrop fops to trace
* added proper op_errno in case of gf_file_lk gets other cmds than F_SETLK
commit 47a9ab5490406d889e79705507d58d464252d288
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Oct 11 00:16:43 2008 +0000
* bug fixes in server-protocol, which were causing segfaults due to wrong inode linking.
* changing of &tmp_loc to loc_copy and loc_wipe in stripe
* minor changes in spec.y
commit e8760e01d99b3f0e4755a444bc24e2d7d1f47da8
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Oct 10 12:45:58 2008 +0000
self heal enhancements in DHT
commit 31bc4e22e43d68bf7857919ff0a5faa9aadabebb
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Oct 10 09:36:53 2008 +0000
minor changes to unify and scheduler/
* scheduler -
1. schedule() op's second argument has been changed from 'void *'
to 'const void *' as it is not supposed to be modified by schedule.
2. corresponding changes made in all the schedulers.
* unify -
1. removed 'inode', 'new_inode', 'path' members from unify_local_t.
2. unify uses loc_copy() to copy loc_t, wherever required. loc1, loc2
in unify_local_t by any unify fop for storing loc_t.
commit 1d5ab095850dc109931ed692e1b02d208a82b18c
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 8 20:55:05 2008 +0000
* bug fixes in server protocol, so link() works fine.
* bug fix in stripe_chown()
commit f88fd6e9e24f2399698e346682966d7f1a6af892
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Oct 8 11:09:15 2008 +0000
bug fix in client_gf_file_lk()
* client_gf_file_lk() was missing to send path to server.
commit f62465544aef0d06985ee402b4d170587c08ee40
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Oct 8 07:55:21 2008 +0000
fixed server_gf_file_lk() and server_gf_dir_lk() bugs.
* server_gf_file_lk() and server_gf_dir_lk() were incomplete previously.
- current commit fixes both _lk() calls to work in server protocol.
commit 4bb264aea3a8b5ea1f7850b09fba469aeef933ee
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Oct 7 16:51:17 2008 +0000
* bug fix in dict.c: which used to return 0, even though key was not found.
commit d0495710909b6efa20480ebc7d530323464612b3
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Oct 7 14:47:54 2008 +0000
proper return value check in posix_flush for dict_get_ptr()
commit 5c53cc04cfd027ebd9641142ebf6e261623ae124
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Oct 7 14:40:19 2008 +0000
return proper value in dict_get_with_ref
* earlier used to return -ENOENT always.
commit dc53a0515af976b4718200b40ad95295041f69f5
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Oct 7 13:17:57 2008 +0000
fixed compiler warnings from features/path, features/filter, debug/trace, features/quoata
commit 4bacc64d4a3e4534537b3beca91ce880c4b3801c
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 7 13:13:34 2008 +0000
added gf_file_lk and gf_dir_lk fops
dht: removed gf_lk
bdb: removed gf_lk and wrote gf_file_lk and gf_dir_lk
io-threads: removed gf_lk
posix: added XATTROP_ADD_ARRAY in xattrop
commit cb8309e4a2be39f5d0438d2e4233de05db717b5c
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Oct 7 12:29:59 2008 +0000
changed bottom-up approach to top-down approach for dentry lookup in server protocol
commit 74196fff40fc462fac3fd8fe5ad8f432cbf5fb66
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Oct 6 12:20:58 2008 +0000
fixed leaks
- fuse_readdir_cbk to free buffer after reply
- inode_destroy() to call forget cbk
- dht_local_wipe to loc_wipe() loc2
commit 0aee65eaebd3bb06ab44980945849481f799f065
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Oct 6 07:37:20 2008 +0000
dht - fixed "changed dev/ino" error in rm -rf. fixed segfault in rename
commit c7c9e6b19029a817641e5d62e50f4d6971d47551
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Oct 5 06:16:51 2008 +0000
* removed options.h, as all these options are included in "gf_string2boolean()" now.
* minor cleanups
* added 'options[]' in fuse xlator.
commit 89c51378a6c3829cc9400c0919a838f05103cb64
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 1 20:09:08 2008 +0000
* updated Portfile to install mount_glusterfs too
* compilation fixes on mac os x, now booster not included on os x.
commit 3a2e0d37f1192bbded87879593c9c9750f15bfb2
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 1 17:32:23 2008 +0000
* added a launchd script for mac os x,
* as mount.glusterfs needs to be mount_glusterfs over mac machines, and there are bit of differences in argument parsing added another file to handle it over mac.
* minor cleanup in glusterfs.c and posix.c
commit 055a5f56837ae8a41eed51dfadd2a1ddca3deeb4
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Oct 1 15:27:43 2008 +0000
* booster rewrite to use libglusterfsclient
commit 8c1bdc31fb1914cfe7dfe78625917589bf817ed8
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 1 06:12:25 2008 +0000
scheduler/*.c to use create_frame() API (for maintaining pool->cnt)
commit d17f5091b415e0c38928cd9dd18faef95374152e
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Sep 30 11:12:19 2008 +0000
working dht_rename()
commit 523953c8780bed64b4ca2ec6bebdce26dcad466e
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Sep 30 08:22:03 2008 +0000
fixed off-by-one bug in gf_dirent_unserialize causing one less entry to be listed if last entry was 1 byte long
commit 77eab6ec118549f94597b42a65d44ea6f0208b52
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Sep 29 10:23:26 2008 +0000
fixed bug in loc_copy()
commit eaa1ee64dc47ed57017ea6ceb00d269e4f1169b6
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Sep 28 20:40:02 2008 +0000
fixed bug in dht_link and linkfile (xattr not returned from posix)
commit 48b043530c2a3e2f2836dfb26baf74ed78d93705
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Sep 28 19:55:20 2008 +0000
dht_readdir fixed
commit 240a17b3910cd5dd8960cbdf5e050ab91528a881
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Sep 28 17:02:13 2008 +0000
readdir_cbk to return list instead of binary blob
commit fd8793a40823a228affa187441761103f2ab70bd
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 27 08:17:29 2008 +0000
glusterfs.c, fuse-bridge.c:
* cleaned up global variables definition
mount.glusterfs
* changed the default log level to WARNING, instead of ERROR
io-threads.c
* added unlink in threads, as it is noticed that on ext3, the time taken for unlink calls is quite a lot, and hence observed some call-bails
commit 05cb763fcbfafdbf033b301b3b9313ec2a371dff
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Sep 26 16:10:08 2008 +0000
create_frame() used to create frames everywhere
commit 5dc7cbff66758b7c7349c37125633ae401468c95
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Sep 24 05:03:17 2008 +0000
DHT (distributed hash table) initial commit
Patches applied:
* avati@zresearch.com/glusterfs--dht--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-349
* avati@zresearch.com/glusterfs--dht--1.0--patch-1
intermediate commit
commit 8dcde0c22322cd8c32dcf13d8caa05eec4d07208
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 20 00:57:38 2008 +0000
* cleanup of glusterfs_ctx from fuse, now, whenever umount is called, raise (SIGTERM) will happen, and xlator->fini() is called for every xlator in the graph.
* gf_string2bytesize takes uint64_t instead of size_t, which is 32bit on 32bit machine, and hence fails to take more than 4GB as input.
* added quota translator. Currently is designed to sit atop the posix translator, and takes 'min-free-disk-limit' (in %), or 'disk-usage-limit' in (bytes) as options.
commit f147df810f129e8c37838b218d43ea73136966af
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Fri Sep 19 13:14:06 2008 +0000
* Putting proper checks for configure.ac for checking Berkeley DB version
function DB->stat, DBC->get etc.
* Makefile.am updated with $GF_CFLAGS
commit cb0518affa9d538ebb031f30be64673a34b5a07c
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 19 06:40:23 2008 +0000
* memory leak fix in unify's self-heal, which got introduced by fd-destory mechanism,
instead of closedir(). STACK_DESTROY() and free'ing few local->* variables should have
done after fd-destroy(), which earlier used to happen in closedir().
commit 06f6572656bf0734c72bb06ab099dbef1f99e5cc
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Sep 18 02:13:20 2008 +0000
* minor fix in setxattr path of darwin, which was causing random popup windows saying path is too long as 'com.apple.FinderInfo' was not supported as extended atribute.
* fix in stripe to handle properly the drop subvolumes option, also some log msg enhancements
commit 301eef5f4d9a48fdeb3d684344b5a41544287b55
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Sep 17 03:41:13 2008 +0000
memory leak fixes to server protocol and write-behind.
* wb_file_destroy() never destroyed wb_file_t, since it checked for
<wb_file_t>->refcount after decrementing it. <wb_file_t>->refcount
was always zero and if(!<wb_file_t>->refcount) would fail, after
decrementing.
* server_symlink() now updates dentry upto parent, before initiating symlink()
fop.
commit fc412c246092821d22369ebca27219d4ac30e0f4
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Sep 16 16:46:30 2008 +0000
* warning fixes
* bug fix in unify init(), for drop-hostname-from-subvolumes option
commit 5a62eea45b896a7812eb154fe188d18afe92c87e
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Sep 16 05:16:48 2008 +0000
* bug: in protocol_cleanup(), if bound_xl is NULL (possible only in case of getspec (ie, --specfile-server option is used)), get_frame_for_transport used to segfault.
fix: check if bound_xl is NULL, and handle the case properly.
commit 5597e839c03e6b29c8b4f074c58a26920ce36acb
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Sep 15 09:20:50 2008 +0000
* fix to segfault when bind-address is specified in the form "ip:port" ("127.0.0.1:6996")
ref: rt #331.
commit af8b47940e88dd4461b4bf6474686a2528526640
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 15 06:19:37 2008 +0000
* stripe cleanup: now one stripe instance will support only one stripe block-size.
* unify-rename: cleanup and bug fix
* filter: now all permission checks are complete as parent mode is checked while a new entry is getting created (like mknod, mkdir, create, symlink).
* bought back 0xeeeee, helps to debug double free's faster
* changed the default min-disk value to 15% from 5%
commit b01193b863d0b1f4e2ef06bcc11f4ed1d2e57330
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 12 20:55:56 2008 +0000
* squash, fixed-id, filter translator merged into 'filter'
commit aa7c0ad32eff1f93d8bd39bcf79776123576feec
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 12 11:57:32 2008 +0000
* fixes a bug introduced in patch-365, mkdir/mknod () was sent to first child instead of bound_xl
commit 7ac602783a7899b062393b47a57ee3e3f3ed6866
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Sep 12 08:04:34 2008 +0000
cleanup of call-stub.h
commit 8693ce5378c8642d06cbc6a54fe66c76c3bf16fd
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Sep 12 07:56:48 2008 +0000
libglusterfs/call-stub.c code cleanup, addition of documentations. minor bdb change.
* cleaned up call-stub.c to follow coding guidelines.
* call-stub.c reviewed to check for proper loc_t copy, while creating stub.
* call-stub.txt - call-stub API documentation.
NOTE: please refer to call-stub.txt before using stub APIs.
* write-behing.txt - write-behind design document.
* bdb.txt - bdb design document.
* added bdb_gf_lk() fop to bdb.
commit ff70caca1005201346b2629dead5314ea394ecac
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Sep 11 17:18:27 2008 +0000
* updating mount.glusterfs.in to take new arguments instead of --server
commit adee36810e0aa9cb958332b5c65bf969ef8a629b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Sep 11 12:41:59 2008 +0000
implemented server side dentry tree support
* Known issue:
memory leak
Patches applied:
* gowda@zresearch.com/glusterfs--server-dcache--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-362
* gowda@zresearch.com/glusterfs--server-dcache--1.0--patch-1
server side dentry tree support implemented
* gowda@zresearch.com/glusterfs--server-dcache--1.0--patch-2
merged with mainline-3.0
commit 29516b3318fd6e13f39ed0b8031fcf323ae5b97a
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Sep 11 05:09:34 2008 +0000
* brought in changes in fuse-bridge.c to make '-o dev, -o suid' by default, and provided --nodev --nosuid option in glusterfs override these options if required.
commit 123ce0185d1983d05f260e27930dfedf4366cfa6
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Sep 10 14:24:54 2008 +0000
* restructure of loop in wb_sync which does STACK_WINDs
* fix to segfault in get_file_contents of posix.c. Bug was similar to the following snippet.
{
char **ptr = NULL;
*ptr = calloc (count, size);
.
.
.
.
err:
FREE (ptr); /* should've been FREE (*ptr);
}
Keywords:
commit dc2a027c454562195db5ec6bf7ac9ec0fb4f68bc
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Sep 9 13:03:59 2008 +0000
merging fd_ref/fd_unref implementation
Patches applied:
* gowda@zresearch.com/glusterfs--fd--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-321
* gowda@zresearch.com/glusterfs--fd--1.0--patch-1
implemented fd_ref/fd_ref - phase 1
* gowda@zresearch.com/glusterfs--fd--1.0--patch-2
fd_ref/fd_unref migration in unify
* gowda@zresearch.com/glusterfs--fd--1.0--patch-3
fd_ref/fd_unref support added in afr and stripe
* gowda@zresearch.com/glusterfs--fd--1.0--patch-4
completed fd_ref/fd_unref migration
* gowda@zresearch.com/glusterfs--fd--1.0--patch-5
bug-fixes to fuse-bridge, write-behind in initial testing.
* gowda@zresearch.com/glusterfs--fd--1.0--patch-6
server-protocol changes to use server_state_fill()
* gowda@zresearch.com/glusterfs--fd--1.0--patch-7
fd_ref/fd_unref migration final commit.
* gowda@zresearch.com/glusterfs--fd--1.0--patch-8
merged with mainline-3.0 and resolved conflicts.
commit d684d830942817128c1712bf77bdfbf1916417a4
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Sep 9 06:14:32 2008 +0000
* more types added to options
-> GF_OPTION_TYPE_{PATH,XLATOR,PERCENT,TIME,BOOL}.
-> an option is provided to give possible options for type GF_OPTION_TYPE_STR.
-> refer unify.c for more some ideas of options[]
* added string2percent, and string2time functions
commit d904fe14da3d0f7680afad0e437a727291e9f425
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Sep 8 11:33:07 2008 +0000
* fix to hang when 'rm -rf' is done with ib-verbs as transport. ib_verbs_quota_get always used to return
a positive quota, receiving more number of post_sends than the number of post_receives by the peer.
Hence some frames never used to reach server resulting in call_bail
commit 759121fa44edaf6538a64c695e53700f87c4116e
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 6 02:27:52 2008 +0000
* Trace xlator cleanup/fixes.
* added check for "option key value value ... " check.. now gives the exact error saying there are more than one value
* added fop_list string, which is printed in fuse-bridge, clientprotocol (in case of bailout) instead of op number.
commit 67b8a7676b396cad2022d12b42bfefa0111cbcfd
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Sep 4 18:36:20 2008 +0000
implemeted device file support in storage/bdb
commit f34d97ea49ff725864c5ee563743e570e75e0eaa
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Sep 4 17:39:56 2008 +0000
* hold locks in ib_verbs_writev. Fix to segfault (rt #295).
* add validation of transport-timeout option to client-protocol.
* change break to continue in ibv_send_completion_proc and ibv_recv_completion_proc if any of the
ib_verbs apis return error.
* update last_sent timeout in protocol_client_xfer. It used to happen in pollout. But pollouts do not
happen in ib-verbs.
* fixed race b/w handshake request and any fop while submitting on an connecting transport.
commit 5c421e5129de6285aeee0af2b907f27cfc63eecc
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Sep 4 14:31:13 2008 +0000
bdb cleanup to confirm with coding standards
Patches applied:
* gowda@zresearch.com/glusterfs--bdb-cleanup--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-264
* gowda@zresearch.com/glusterfs--bdb-cleanup--1.0--patch-1
partial cleanup
* gowda@zresearch.com/glusterfs--bdb-cleanup--1.0--patch-2
bdb cleanup intermediate commit
* gowda@zresearch.com/glusterfs--bdb-cleanup--1.0--patch-3
bdb cleanup final
* gowda@zresearch.com/glusterfs--bdb-cleanup--1.0--patch-4
bdb cleanup phase 2
* gowda@zresearch.com/glusterfs--bdb-cleanup--1.0--patch-5
bdb cleanup final phase
* gowda@zresearch.com/glusterfs--bdb-cleanup--1.0--patch-6
bdb cleanup phase 5
* gowda@zresearch.com/glusterfs--bdb-cleanup--1.0--patch-7
bdb cleanup final commit
* gowda@zresearch.com/glusterfs--bdb-cleanup--1.0--patch-8
one more last commit for bdb cleanup
* gowda@zresearch.com/glusterfs--bdb-cleanup--1.0--patch-9
bdb cleanup final commit - merged and resolved conflicts with mainline
commit 2310b94e7fd8dee286c1669efe7cc4c6757850ef
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Sep 3 08:21:12 2008 +0000
Thread 1. ib_verbs_writev:
1a. ib_verbs_quota_get()
1b. ib_verbs_get_post()
Thread 2. ib_verbs_send_completion_proc:
2a. ib_verbs_quota_put()
2b. ib_verbs_put_post()
the quota_get/quota_put are the synchronization points. this clearly has a race where events happen in the order - 1a 2a 1b 2b. 1b would return a NULL post in this case
commit 93d05a3c88758f44570d3f389f22112127ef9809
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Sep 2 12:28:12 2008 +0000
mod_glusterfs/apache-1.3 documentation.
commit c956f03c39171c61bd63c4672c965b3e2d14ab8c
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Sep 2 08:33:33 2008 +0000
unix options added to validation. Thanks to Tomas Seigl <tomas.seigl@gmail.com>
commit 8b7a37a737341f399fa143bedc5887bd16c3b31d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Sep 2 05:37:58 2008 +0000
* log when connect on tcp socket fails in ib-verbs.
* log and transport_disconnect when notification to protocol returns -1 in ib-verbs.
commit 913f67c350fd5a6e9747506523262ce021cbf88f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Sep 1 19:04:19 2008 +0000
* apache-1.3/mod_glusterfs cleanup.
commit 1314e7134ce94e106b6a7195d84247bcfb40ae9a
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Sun Aug 31 19:29:03 2008 +0000
* Fixed the issue in rr-options.c regarding option parsing, as the control
flow was always returning "-1" even for valid cases. This fixes the rr
scheduler initialization issues even with proper values.
* Fixed qa-client.spec changed 'min-disk-free' to 'min-free-disk'
commit f12b93c996c989bb1d5955cb3e3fcc04151b6fa0
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Aug 30 09:37:06 2008 +0000
- fix build warnings in unify (typecast pointer to long instead of int)
- temporary backport of afr
- fixed frame leak in protocol/client in setvolume_cbk
- changed min/max of io-cache and io-threads option limits
commit 97306f8822a955fc08a1097e3244bef6b52d3853
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Sat Aug 30 03:54:51 2008 +0000
* $ac_pwd removed and added a verbatim ${top_builddir} and $(top_srcdir) for ARGP_STANDALONE_LDADD and ARGP_STANDALONE_CPPFLAGS respectively. This change was done as $ac_pwd is not present on older autoconf versions.
commit 76134aa326e7028c8c490b1634fa83284d4ac46d
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 29 16:25:21 2008 +0000
server_fchmod_cbk was setting op type as GF_FOP_LK instead of GF_FOP_FCHMOD
commit e0ae3aa00a3b351d835ffff48ca6877f2f9e09f0
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 29 14:21:58 2008 +0000
fixed typo in ib-verbs
commit 7dcb96200e09266018eb26f4515e81334265fc8a
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 29 13:45:54 2008 +0000
change op_errno to ENOTEMPTY when rmdir() returns EEXIST
commit aac8969c6292f80c4df2d700501e0b6c81b9a12c
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 29 13:39:04 2008 +0000
ib_verbs_event_pollerr - event_unregister was called only when priv->connected == 1. This used to cause a busy loop when disconnection happened before connection succeeded. changed the conditional to priv->sock != -1 for event_unregister to be called.
commit 86e05bbedd50dabfd61bee361070ce840a9948bf
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 29 12:06:17 2008 +0000
changed GF_LOG_WARNING to GF_LOG_DEBUG for less important messages in transport
added EEXIST to 'safe' errno in posix_rmdir
xlator.c changed GF_LOG_WARNING to GF_LOG_DEBUG for missing 'options' specification
commit 8f81e8a8e1422260d6b91149be243da05eb91b5f
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 29 10:40:43 2008 +0000
added size != 0 check in dict_unserialize to avoid warnings
commit 51ca9f0686bce58b3f647cbb045ee0363b8b1047
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Aug 29 09:06:49 2008 +0000
* check for the range was (value <= min) || (value >= max) , changed to (value < min) || (value > max)
commit b82f92acb6b52b21921312545f0b8c05cc1fc4f8
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Aug 29 07:48:04 2008 +0000
* corrected options of server protocol and client protocol
* duplicate options are not allowed in spec files any more.
* when a non-registered key is given as option, all the registered options are logged, hence will be easier to find out at that time, instead of going through code or wiki after getting error.
commit ed38659804c2afd602883d293a447089e45e6d93
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Aug 29 06:01:20 2008 +0000
* 'struct xlator_options options[]' added all translatos other than
- fuse-bridge.c, bdb.c, afr.c
commit 1925cf5d1238bdc7f3fa8f290cf9053c848982e8
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Aug 29 05:02:12 2008 +0000
option validation code
* code to validate translator specific options while parsing. this will also check for range of given option (if any). Currently code added as optional to have validation.
* strict option validation structure added in posix and io-threads.
* stripe.c: whenever possible, keep the modified time of the file as modified time of first server (similar to st_ino). Should solve the problem of io-cache getting used above the stripe.
commit 2fd956abcc0536bb126af92f0173aefbb7a40800
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 28 21:02:26 2008 +0000
* warning fixes and mac-os-x related changes
commit 7db9b4e45659345192aeab2dd2c584e0aec9ea7c
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Aug 28 15:09:51 2008 +0000
ref(frame->root->req_refs) is done only in the writev() call and not ftruncate(). option self-heal off will make writev() not to lock/inc-dec version. fuse_readv_cbk will not print error msg if op_ret==0.
commit d8857e1f687428ac53b408aae1c26fed03c9d96a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Aug 28 14:29:03 2008 +0000
* ib_verbs_handshake_pollerr made idempotent, so that an extra invocation doesnt cause hang of glusterfs.
commit 02f321d7765c2a9094c38c0ccadd5e8b7a595325
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Aug 28 11:33:39 2008 +0000
* another segmentation fault related to the scenario dealt with patch-329. Fix to the same
commit 5df437433befd921a1d85f260e40daa72334636e
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 28 09:20:17 2008 +0000
changed dict serialization format to binary
commit 2615663cd086d0d92690739f50a434aefbd237a6
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Thu Aug 28 07:19:56 2008 +0000
* renamed boolean_t to gf_boolean_t also 'true'/'false' enum changed to
_gf_true/_gf_false. This will fix the cross platform compatibility issues
as boolean_t are define on MacOSX/Solaris/FreeBSD.
commit 0735cbb4187442750a9c45796016529d6d4a6a2e
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 28 05:38:49 2008 +0000
* ib-verbs: earlier way of handling pollerr in case of pollin in handler function had side effects, which could cause double free's. The current patch has the right fix for the same. It currently changes pollin to pollerr only in case of handshake complete.
* unify: cleanup in init(). removed check for scheduler type to handle the option 'drop-hostname-from-subvolumes'.
commit 133aa28d775170d8cf863ed9a3c927e8e8bd47ef
Author: Bala A <balugi@gmail.com>
Date: Thu Aug 28 04:16:32 2008 +0000
Another code cleanup in glusterfs main and fuse. separated option parsing file in fuse module
commit 11fc35bddf5207fa344fd536e9e28a94913d22b1
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Aug 27 15:57:40 2008 +0000
* port glusterfs--mainline--2.5--patch-796
* Since the above port also allows creation of fuse thread even before SETVOLUME on server is succeeded,
reintroduced CONNECTING state in notify of fuse-bridge.c
* proper fix to bug explained in glusterfs--mainline--3.0--patch-322
* wb_sync_cbk won't do stack_unwind of frames which are not written_behind, instead all unwinds
are done only in wb_stack_unwind to avoid races.
* wb_cleanup_queue does cleanup of a request only if a request is stack_unwound to application
and stack_wound to network
commit ac9b070424d8e00f4c93891d64b739044b9a8db9
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 27 08:33:54 2008 +0000
* bug fix in unify for option 'drop-hostname-from-subvolumes' used in case of single process NUFA type setting.
* added features/squash to doc/translator-options.txt
* added support to log Version, Mainling Branch, Starting Time and command line in logfile.(as earlier)
commit a059640baf57656c7a357b1fef4327da0efbceac
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Wed Aug 27 07:40:10 2008 +0000
* Fixed warnings in argp-standalone/argp-help.c
* Fixed acinclude.m4 (please rerun the ./autogen.sh)
commit a44dfcd11d7a0e70c0aa415a96f98ce701eed266
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Aug 27 06:52:28 2008 +0000
make --pid-file optional
commit 35046175df4ad803ce5304c444c37a6043e8e3b8
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Aug 27 06:41:16 2008 +0000
afr bug fix
local was being used before initialization in afr_open_readv_writev_cbk
commit 7df9cc2f7b3d7faca210b27267d607ae4c202aed
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Wed Aug 27 05:55:08 2008 +0000
* Minor fix to suppress the warning messages from argp-standalone
commit b37aebd7d6902d9ed9356a26efff911570888e42
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 27 05:49:39 2008 +0000
* cleanup of trash translator, coding standard following
* squash translator is implemented.
-> supports the following options.
'option root-squashing enable',
'option uidmap 100=1000,101=1001,...',
'option gidmap 100=1000,101=1001,...'
commit 8f40cd86213a6ae7eaf8a06ee13e5b702298b7af
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Aug 27 06:46:27 2008 +0000
* bug: segmentation fault in wb_stack_unwind due to cleanup of request
cause: following is the sequence of the states of the request that might've led to bug.
1. (fuse-thread) stack_wound = 1, got_reply = 0, written_behind = 0.
2. (reply-thread) stack_wound = 1, got_reply = 1, written_behind = 0. (unwind the stack,
but it was not recorded in written_behind)
3. (fuse-thread) since written_behind = 0, mark for unwind.
4. (reply-thread) cleanup the request-queue. The request gets freed since got_reply = 1.
5. (fuse-thread) do_ops->wb_stack_unwind->segmentation fault.
fix: in wb_sync_cbk,
if (!request->write_behind) {
request->write_behind = 1;
stack_unwind ();
}
Keywords:
commit e78b3ef50dd0db8dffb7cb6dad0cbd0853c2f6d7
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Aug 27 04:56:17 2008 +0000
bdb bug fix
* bug: bdb database corruption after glusterfs restart.
* fix: bdb fini() does a final checkpoint before shutting down glusterfs,
to avoid checkpointing errors.
commit b69611ed0354ef8f50a59a8a9ad12b9a5e5bf06a
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Tue Aug 26 15:57:19 2008 +0000
* Added new directory argp-standalone which is shipped with GlusterFS
itself now, as argp related compatibility code became unmaintainable.
* Removed all unnecessary argp compatibility code in compat.h,compat.c
* Added support for new libtool (tested on MacOSX, FreeBSD, Solaris)
* replaced --spec-file option as hidden which was removed in Bala's
commit
commit 312c98b8b622357b7b6de97113eb8e5a3933d40f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Aug 26 15:00:48 2008 +0000
* memory leak fixes in ib-verbs.
commit cdaa2d2a0379eb6f59494c5309b709cd9b488b56
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Aug 26 12:52:21 2008 +0000
added posix_gf_lk
commit 40a24db7949a89da5aae0132beaf053ed113b980
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Aug 26 08:36:32 2008 +0000
* Fixed a bug in fuse_setattr(), which can lead to missing frame (and hence a mountpoint hang) in case of only FUSE_SET_ATTR_ATIME flag comes to the function instead of MTIME and ATIME both. This was causing hang on MacOSX (with macfuse).
* Removed -o noexec in case of DARWIN OS, which is not needed now with the above bug fix. With this executables will work fine over GlusterFS (on MacOSX).
commit b51a14447d1416e59983898d36bce572a1a7f28f
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Aug 26 06:57:54 2008 +0000
when op_ret=-1 local-> was being accessed before it was assigned to frame->local.
commit ae38fb50f7541a8699a381e518a50a6a240b0d81
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Aug 25 19:54:47 2008 +0000
* Mac OS X : extended attribute (com.apple.FinderInfo, com.apple.ResourceFork) are supported inside GlusterFS itself now, hence removing -oauto_xattr, which caused some hang issues with xattr usage earlier.
* minor improvement to parsing logs.
commit 1ed962d6adbd69d419866a125f0f6b919618188c
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Aug 25 14:23:02 2008 +0000
op_ret has to be init'ed to 0. (xattrop was returning -1 all the time)
commit ae325b3d2d31e4d81e73e2356e5f151624ce8e21
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Aug 25 13:57:33 2008 +0000
local->locked[i] == 0 indicates lock was success there. It was being checked for 1 before unlocking. Correcting it.
commit 67ef347bf7f0de1a0790ac6e03559123efd3ac3e
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Aug 25 09:05:52 2008 +0000
posix_xattrop cleanup
cleaned posix_xattrop to follow coding standards
log message cleanup in rr, write-behind
commit 5e265037b14e91da88a30bdb58f4f3ae6d4b76eb
Author: Bala A <balugi@gmail.com>
Date: Mon Aug 25 07:46:57 2008 +0000
spec.y prints error messages in console too
commit a1ddd5fe38dd9bfdb1ca3198ac09890688256007
Author: Bala A <balugi@gmail.com>
Date: Sat Aug 23 08:01:48 2008 +0000
major code cleanup
commit 3760b351e8fbca60ac64cf76f58cf0852351fadc
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Aug 22 21:39:19 2008 +0000
Code change to use the new algorithm during write to take care of splitbrain (also makes write-commit reliable). Code change to hold locks during write. Code change in selfheal on open (which has to be done to take care of the previous two changes.
commit 6d3ea4fde32189daf8bcbc22429cd451624c1792
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Fri Aug 22 19:46:34 2008 +0000
* Solaris fixes
BUG: getxattr/setxattr failing over Solaris.
FIX: use of 'O_XATTR' additional flag for openat()
under solaris_setxattr/solaris_getxattr
BUG: setxattr failing with ENOENT in cases when
file is unlinked (observed in case of dbench)
FIX: ignore the ENOENT in posix_incver. Valid fd
shouldn't return ENOENT even if the corresponding
file is deleted but in case of Solaris both fd and
key (attribute) are counted for i.e key (attribute)
is a file in case of solaris, so the associated
file being absent openat() sets ENOENT.
* Solaris tested with 'dbench 10' without issues.
commit 7a229c4a6795e25f0910f789b98c7d22ff3f2ba1
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 22 19:43:25 2008 +0000
read-ahead - disable initial read-ahead
used to cause race with initial write and caused dbench to return 'read handle failure'
commit 9bdfdd5b906bb7bec646d1d5ba65e60ce911c285
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Aug 22 19:14:20 2008 +0000
* bug: unify's change of keeping inode-generation in dictionary caused segfault.
* reason: when a lookup succeeds on a completely corrupt path (say given path is directory on namespace and file on backend, or vica-versa), there is a possibility for the same.
* fix: This case is clearly handled in unify_lookup_cbk(), and logging explicity saying 'self-heal' can't fix it, and returning EIO for the path.
* bug fix in stripe related to wrong pointers in gf_log().
commit 2fe5b08130230f0290b1e161a03138aa1be44dd9
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Aug 22 18:40:11 2008 +0000
* bug: server process uses 100% cpu when ib-verbs transport is used.
* reason: when a client disconnects, the handshake notify gets POLLIN and the case was just neglected (after handshake complete), hence the POLLIN event was never acknowledged, which caused the event_poll() loop to break always.
* fix: consider any activity over tcp socket after handshake as a error, and close the transport.
commit 876374a18b3691edc86403e9b0f4b738360cc8f4
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 22 15:23:24 2008 +0000
posix_rmdir was returning errno = 0 for ENOTEMPTY causing fuse to trigger 'EBUSY' on those directories
commit 8c089e0cf54efb8499300ef03ba431e82a3c4e45
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Aug 22 15:33:05 2008 +0000
* bug: dbench runs into EBADFD errors with write-behind (flush-behind on and non-zero aggregate size).
cause: the poll thread and the fuse thread race to send write and close fops to server respectively.
Whenever close is sent ahead of write request, EBADFD errors are resulted.
fix: disable flush-behind when there is non-zero aggregate-size. This forces any requests marked by
the reply thread for wind but not yet actually written to be sent to server before flush
returns application and hence eliminating race condition (close is sent only after flush returns
to application)
commit adf85246e33f84bc1af0b86f838e2ab553f9143a
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Aug 22 09:53:41 2008 +0000
save a copy of loc_t in posix-locks
copy loc_t in truncate in posix-locks and save it.
closes RT ticket #245.
minor fix in posix
commit 74251d4f0ad1031bfe5e542c0a4dcb1d57df47c6
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 21 17:59:26 2008 +0000
fix for transport/socket on solaris
commit cc5f2b0e1d8c3cd3eb0151452f56f37e324a3238
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 21 17:18:25 2008 +0000
moved log message from fuse_entry_cbk to need_fresh_lookup (right place)
commit 5fdeb638542c6d9b9ade7e1ecf43534e843971d7
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 21 10:40:01 2008 +0000
* Fixes the logging related to specfile parsing.
* All logs related to specfile parsing changed to userfriendly msg (in error case).
* using lineno in logging error.
* Some changes in parsing way of the same grammer.
commit d9e2905c21d074707ea9fea08e8290a2d3d3090d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Aug 21 11:56:44 2008 +0000
* removed lock in write_request_t. All synchronisation is done using only lock in wb_file_t.
* A window_size of 0 implies one frame to be written behind. Earlier 0 window_size implied no frames to
be written-behind. In general, a request is written behind even if the current window-size equals to
configured window-size. So, the maximum window size can be (configured window size + maximum size of
a write buffer in a request).
* sync transport/ib-verbs/src/name.c with transport/socket/src/name.c
commit 77e1971f3393f31bf4c4ef6e7f4184ff0a047bae
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 21 09:42:11 2008 +0000
set transport pointer to cleanup frames
commit 916060b955bfad2576677ae9c5eec12cbaf13596
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Thu Aug 21 06:07:44 2008 +0000
* Renamed __S_IFDIR to S_IFDIR for portability
commit 6d699029897693fa06c11688bd3f67769bed10e2
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 21 02:11:57 2008 +0000
fix in posix_rmdir
removed unnecessary op_ret = 0 which was breaking things horribly
commit d312aaf6923e999ab23e3fc68caffe46df653512
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 21 01:33:36 2008 +0000
changes to prevent inode->ctx from being swapped ever - improves correctness and removes race conditions which were present in the previous code
* warning fixes (data_to_str NULL)
* posix_rmdir was wrongly checking op_errno instead of errno
commit 6c74351a7ca488e41d866466a23a593d8a4f12b4
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Wed Aug 20 16:15:25 2008 +0000
* Tested Dual stack support on various platforms
a. Solaris - works
b. FreeBSD - doesn't (need to specify exact address family to be used)
c. MacOSX - works
Fixes include build errors due to 'NAME_MAX' not present
and in6_addr (ipv6) structure being different.
commit e1fa958529e97afb960754ae43346844921ef045
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Aug 20 14:02:45 2008 +0000
bug fix in server-protocol
bug: server protocol was STACK_WINDing into _lk for both
lk and gf_lk
commit ccd919ae6f525c7f51b2732dc5b500ec657b928c
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Aug 20 09:10:11 2008 +0000
added posix developer doc
commit 11767445e2fc96a7b5f4804ba9372280b4372409
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Aug 20 08:05:30 2008 +0000
bdb bug fix
* bug: checkpointing thread used to cry with error 'ENOSPC'. every operation on db used to fail, due to lack of space on disk.
* reason: while using different mount-points for db's logdir and db's storage dir, db does not cross-verify, before accepting a transaction to logdir, if storage dir has enough space on disk.
also, other operations on db used to fail with 'ENOMEM', reason for that error is also lack of disk space. libdb uses disk to store information about locking details, transaction details. when disk runs out of space, it fails to update these informations and returns ENOMEM.
* fix: bdb_writev() does a check to see if enough disk space is available, before doing DB->put().
commit c753a0f31d2f84682475c24761df46940ba7c536
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Aug 20 07:53:19 2008 +0000
op_ret value was always zero on success in posix_readv, changed to number of bytes written
commit cd7906928231a807094e90d7acc05eb1e95521eb
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Aug 20 07:21:57 2008 +0000
fuse fini() bug-fix
* bug: fuse_session_exited() (in fuse_thread_proc thread) continued to return even after fuse_umount was called by fini() of mount/fuse.
* reason: clean way of shutting down fuse mount is to close the session using fuse_session_exit() before doing fuse_umount(). fuse_session_exit() was not called before fuse_umount().
* fix: fuse_session_exit() is called before doing fuse_umount() in fini() of mount/fuse.
commit 19b5233e4f3b1310acd5fe4ffc56c139848eb85f
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 20 07:00:35 2008 +0000
* a segfault fix in unify_ns_rename_cbk()
commit c64be5f6e5cf2b8ed67a8dd2c6e735ccd6f6ee5d
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Aug 20 05:02:23 2008 +0000
io-cache & read-ahead bug fix
* bug: read over mount-point fails when mounted through io-cache or read-ahead.
* reason: io-cache and read-ahead use page->size of every page to determine if data is to be copied to the reply vector of calling frame or not. page->size is set in fault_cbk(). op_ret was being used as per read() manual page semantics. due to a change in storage/posix's readv() (line: 1537 of posix.c in patch-285), op_ret is always 0 (zero).
* fix: io-cache and read-ahead now rely on vector[<index>].iov_len to find out page->size.
commit 4fc515047c3a5d8cf7b1a7dbeff9ebde8f8432dd
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 20 03:16:25 2008 +0000
* Major change in unify's 'inode->ctx' structure. now the list is maintained only in file inode ctx, where as in directory inode, the generation number is stored. This way, the inode->generation variable is free'd up.
* Also, this reduces the number of ESTALE return's for fuse.
commit d95624f35549cfa5c89230851289b23dec9593b4
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Aug 19 22:20:24 2008 +0000
* added error log in ib-verbs.c when the thread gets exited.
* few correction in argp compatibility code, and ipv6 part in case of BSD.
- Thanks to Paul Arch for patch, and Harshavardhana for reviewing it.
commit 041f5dd16c64043118b0cf0f138c7c8d65c6868d
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Aug 19 03:34:29 2008 +0000
* Fix in authenticate.c to return the error (-1) when the authentication module fails to initialize.
* Check in rr-options.c so that the log of dict_get NULL doesn't come.
* Fix for the ib-verbs hang issue seen with qa34 release. (During initialize). This is fixed by falling back to old method of starting fuse thread only after handshake has happened.
commit 632a5047f4c44e379d5f5bcfa1e1dc67764230e6
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Aug 18 06:51:24 2008 +0000
* Fix to RT ticket #221 (don't check the offset in posix when o-direct is used, let the error be returned from VFS layer).
commit 8b73f4508f56bc25121f80dbac3fcef3976c0806
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Aug 14 09:10:26 2008 +0000
* bug: authentication failure of ipv4 clients on server running on ipv6 enabled systems.
cause: get_transport_identifiers fills ipv4 mapped ipv6 address strings (::ffff:a.b.c.d) instead of ipv4 address strings (a.b.c.d).
fix: get_transport_identifiers fills ipv4 address strings for ipv4 mapped ipv6 addresses.
* print proper error strings in case of SETVOLUME failure due to call_bail.
Keywords:
commit 983b34c7db64405533a33d9eb00d81e948387c22
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 13 20:57:44 2008 +0000
* changed the default unify self-heal method to 'foreground' from 'background' as its tested well.
* added check in server_lookup_cbk to not free root inode in case of ESTALE.
* added user friendly log in fuse-bridge, where fuse_mount fails with module not present.
commit baa0e32dccd93f52b0b6213e0b3cc339f73c397f
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 13 14:52:50 2008 +0000
* added code to get 'option self-heal background|foreground' in unify. by default its background.
commit 416694fe859cd51d53874d36d5d68b80f6359d44
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Aug 13 12:00:02 2008 +0000
added some points to the coding standard
added stuff about:
- brace placement/tab size
- lock
- {
- /*...*/
- }
- commenting style
commit 35babc2eb622b7cc8b54520aa9584ca66e69fa8b
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Aug 13 11:29:34 2008 +0000
release locks held by current process on close() in posix-locks
This is needed for AFR's gf_lk to work properly
commit 3a5bdfe7790217d649b0ab53d226b954ad273415
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Aug 13 11:01:14 2008 +0000
fixed leak in posix_close
- added declaration of dict_set_bin
- cleaned up MAKE_REAL_PATH
commit e64f75e0675c70d5e001b3729526f875e7a61a49
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Aug 12 14:06:35 2008 +0000
fixed a couple more bugs in posix.c
commit daa361bba13130214b67fd802b7580145afc6224
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Aug 12 08:29:32 2008 +0000
* typo fix in unify_mkdir_cbk ()
commit bb083888d1b0031c107744364dcf70b2f0fea270
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Aug 11 10:12:50 2008 +0000
* Added *so_LDADD = libglusterfs.la in most of the Makefile.am
* small fix in unify_mkdir_cbk (to consider EEXIST as valid case)
* small fix in server_lookup() to handle the case of ESTALE.
commit 3bc5dbc22985503ffd29bd390c4000aebd255e63
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Aug 6 11:41:07 2008 +0000
fixes segfault in posix_getxattr
Fixes a couple of bugs in posix_setxattr and posix_getxattr
that were introduced during cleanup, as reported in
RT ticket #167.
Thanks to Brent Nelson for reporting this.
commit 885f2d5b3f040a5da94ff1af7dc1dfea1932668e
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Aug 5 08:29:38 2008 +0000
* fix for RT ticket #182
-> Message with log level "T" observed in "WARNING" mode
* temporary fix for GlusterFS volume not showing up on Desktop in case of Mac OSX. added "-o auto_xattr" flag.
/* TODO: fix the proper xattr (com.apple.FinderInfo), and remove this flag */
commit 1ac45e77fe7ee45a207201fb6e39889cf712963c
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Aug 5 09:40:37 2008 +0000
* wb_sync writes a maximum of 8 vectors in a single STACK_WIND.
* fix segfault in wb_flush.
frame was being used after STACK_UNWIND.
* transport/socket used to initialize ops as,
this->ops = &tops;
this may result in ops structure being initialized to some other transport (ib-verbs) in case of multiple transports being used.
Keywords:
commit 12505a5a784b0169a0a51bc5df7aabd6cefd0ba3
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 31 20:47:46 2008 +0000
* Changed GF_DARWIN_CFLAGS to just GF_CFLAGS and some variable cleanups in configure.
* added -D_REENTRANT in case of Solaris for GF_CFLAGS.
commit db6f5f523398ee3a8895fde0f96c4403ede8bd80
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 31 10:50:21 2008 +0000
minor bug fixes
* allocate proper size for struct dnscache in gf_resolve_ip6(),
* proper handling of optarg_index in argp_parse, so single arguments are taken into consideration.
* removed ipv6 as a option in transport-type, it will be decided by address-family, by default, transport-type tcp will have 'address-family inet/inet6'
Thanks to Jean-Jacques Sarton <jj.sarton (at) t-online (d0t> de> for all the above bug reports and fixes
commit bddf2410a29ff3fdf9b629ec071bce7dfb4681da
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jul 31 08:48:17 2008 +0000
bdb configuration changes
* removed 'option log-remove on|off', log-remove is activated all the time.
commit ff945253d0e44fc3b071f88e3380015681bad6a1
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jul 31 07:34:53 2008 +0000
bdb options specification changes
* 'option transaction on|off' changed to 'option mode persistant|cache' (respectively).
* 'option cache on|off' removed and cache is on by default.
commit f07186633ad15cca7e47ed132e5e59622ec446a6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jul 30 06:34:54 2008 +0000
removed CODING-GUIDELINES.txt as the contents are included in doc/coding-standard.pdf
commit 3b0cd48cbbce9c286027b4559686c7dcc672fef6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jul 30 05:59:35 2008 +0000
removed assert on unopened DB in bdb_open_db_cursor().
* failing to open a DB for which cursor open has come is a serious case. Ideally storage/bdb should be terminated when this case hits. Currently, bdb_open_db_cursor() returns -1 on failure to open DB for which cursor open is requested.
commit 9e4636dc52c2574e1478ea0b50790d85c9834570
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 29 23:06:39 2008 +0000
* updates in doc/* files (like adding window-size, o-direct options.. )
* libglusterfs/src/spec.y - removed a extra semicolon (;)
* cluster/unify.c: if init() is not done, no notify will pass through the translator.
* fixes in stripe translator to handle the notify properly (similar to afr model)
commit 798334f04645b95315f68b5803996a7aef700d8e
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Jul 29 14:58:50 2008 +0000
added coding standard document
commit 5fbea87673842e4b57f3732f11be12b83d5516f7
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jul 29 10:34:32 2008 +0000
lighttpd/mod_glusterfs documentation update.
commit 0f1bdd44e8e425dd9521bab4ee9151456ab43ebf
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jul 28 16:28:39 2008 +0000
Adding documentation related to transport/socket.
commit c5337f2e520beb5ae9d32aaa5a691897ca1dafbe
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Jul 28 14:28:35 2008 +0000
cleaned up posix xlator to make it more robust and conform to the coding standard
dict.c: New cleaned up versions of functions
common-utils.h: VALIDATE_OR_GOTO macro added
Patches applied:
* vikas@zresearch.com/glusterfs--posix-cleanup--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-223
* vikas@zresearch.com/glusterfs--posix-cleanup--1.0--patch-1
cleaned up posix code for robustness and conformity with coding std
* vikas@zresearch.com/glusterfs--posix-cleanup--1.0--patch-2
misc fixes
* vikas@zresearch.com/glusterfs--posix-cleanup--1.0--patch-3
posix cleanup done, iozone and dbench work fine
* vikas@zresearch.com/glusterfs--posix-cleanup--1.0--patch-4
migrated changes made to mainline posix after this branch was created
commit 807d8ac46d6d98c0c3a437fce5155c04df759c3c
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Fri Jul 25 18:34:38 2008 +0000
* extras/glfs-bm.c - removed too many extra lines in the License header.
* CODING-GUIDELINES.txt - updated
commit 4d2ad87a450e9eb3ce3aafcc2b20f3d5d54953c3
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Fri Jul 25 18:19:04 2008 +0000
'auth.ip' changed to 'auth.addr' under the following directories
* doc/*/*
* extras/*
commit 1b93051bcc9967676a8f4367aba9973a597bef56
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jul 25 02:29:49 2008 +0000
* fixes one segfault in unify_open_readlink_cbk(), happens when open() comes on a symlink
commit 68420ee877dca1a9c3568f5f200d9e21a2338d64
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 24 23:50:15 2008 +0000
* added GF_FILENAME_MAX (256) to the code, which reduces the array size of checksum, and getdents entry size, hence becomes more faster.
* This change doesn't work with earlier patchset (due to change in the size of arrays), hence changed the version to qa31.
commit 2bac788e053c0206f42bfb5aa28aadf1be8c07e1
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 24 23:41:38 2008 +0000
* Fix for 'Device not confgired' error over MacOS X (Darwin).
* Added 'Portfile' and 'glfs-bm.c' to the code base.
* Fixed a issue with glusterfs.spec.in when modglfs was disabled.
commit dec63ceb1915961cf226f9a65b10a60ed05128a8
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 24 17:19:55 2008 +0000
* checksum made as fop.
* checksum fop added in io-threads
commit 84151deed689eb0f1f9fbdba79633d13d5d62fe4
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jul 23 17:37:59 2008 +0000
* ib-verbs uses apis exported by name.c to get sockaddresses during ib-verbs-handshake.
* fixed segfault in server when a client disconnects.
commit 9bbd5cfe01a1a0f28f7fd108e8f7dd80ed9bbcd3
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 23 06:37:44 2008 +0000
* "option o-direct <enable|on>" support in posix translator
commit a57a9265676d755f06fea12134cad88cd612231c
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 23 06:31:45 2008 +0000
* "option o-direct <enable|on>" support in posix translator
commit 87c39a5a92e0c73fe55fea1af1283239fb198aa0
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 22 14:12:09 2008 +0000
* Proper log msgs with peer info logged in socket transport
* Backward compatibility for new transport
* adder return value check for transport_listen().
* Changed the behavior of blocking client, when server is not connected to function properly and return ENOTCONN till server comes back online.
commit 45a7d9ea903ed307f9bd678b0aaeefdb96fc1ae5
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 21 20:15:11 2008 +0000
* removed gf_boolean_t as 'true' and 'false' were already declared in Darwin, and it was leading to namespace corruption.
* added 'mode' argument to open where ever O_CREAT flag is used.
* support in posix to handle lchmod (similar to lutimes)
* added support to unify's open over symlink
commit e12f3a3bfb142a87b9b8f61c1b5be251480064a4
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Mon Jul 21 18:53:08 2008 +0000
Build Fixes on FreeBSD and Solaris.
* Fixes in transport/socket regarding a variable "*sun" was causing issues
on solaris.
* Renamed boolean_t to gf_boolean_t which actually corrupted the namespace
on platforms other than Linux.
* strsep function added for solaris.
* Various other build fixes.
commit 69a403df987b05ce588f04fc75c8faa744a4e8cf
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Jul 21 08:03:21 2008 +0000
in server_incver, req->fd can be 0 and gf_fd_fdptr_get() can return valid fd when passed 0. Making suitable changes.
commit 75d5e7ab310b795c8ddb000fadcaae8437035290
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jul 20 07:41:28 2008 +0000
* added support for lchmod for symlink (according to latest standards, over symlink chmod should always succeed, as its not checked at all by VFS.
* changed the protocol for setdents/getdents.. now the buffer is sent in seperate buffer.
* fixed a bug in unify-self-heal, which was causing a frameloss in case of posix namespace, and also another bug fix to handle case when the return value is 0, and array is NULL.
commit 236a87d43f4a2435bfe49097a0752d8c41e21d55
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 20 06:22:35 2008 +0000
added Makefile for transport/socket
commit 4b1bb81462ab5f37f9c70499d3cf52dedb0b3a12
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jul 18 01:06:16 2008 +0000
fixing build errors from my last commit.
commit 2addb02c81d0b0bdaab2eaa4a6ecd6342fc80412
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jul 17 23:11:51 2008 +0000
* transport/socket, which combines functionalities of tcp, unix and ib-sdp.
commit b88281aa19ae4a57628a3667bad32e2ab156151e
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jul 17 23:00:00 2008 +0000
* ib-verbs port to binary protocol.
* ib_verbs_hanshake is implemented nbio mode.
commit bea20bce721d3e1978da7ce77d8ae8c4b64a2a97
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jul 18 09:32:17 2008 +0000
* removed warnings
commit d166b073f6942b2424d6942070507c476fcbe45d
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 17 19:25:45 2008 +0000
* compilation of bdb on FreeBSD works fine with proper compat-errno
* reduced the setdents/getdents count in unify self heal
commit 40cafd7db024bfa1f0eea5456b3b0bc4f4cb59dc
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 16 02:33:58 2008 +0000
fuse-bridge.c:
* added 'daemon_timeout' option to fuse-mount, in case of darwin osx.
posix.c:
* handling lchmod to fall back to chmod if lchmod is not present.
commit abd1184c34b6451a350c0d58fe68101bd45da553
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 15 23:20:00 2008 +0000
* uses proper option for xattr functions so that symlinks are handled properly on DARWIN. It used to give lot of warnings over Mac OS, cp -Rp.
* small correction in posix_setxattr, so all the items in dictionary is tried before returning error.
commit c34d09d4d70fa6bc94d6281fd46f5847b2756e98
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 15 19:34:53 2008 +0000
fix for bug #23861
* rr notify changed to use the seeding using namespace node.
* posix chmod uses lchmod instead of chmod (it was changed in inbetween patches, which should always be 'lchmod').
commit 560b5f3937cfd3519e1697cb502de60448e70a9a
Author: Bala A <balugi@gmail.com>
Date: Tue Jul 15 12:26:07 2008 +0000
gf_strsplit() uses strdup() instead of strdupa() and added tlaclean in Makefile.am
commit 616b35a5692ac606752af9c72de7de30214e8339
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Jul 15 07:30:41 2008 +0000
fop initialization fixes in server & client protocol
use [GF_FOP_FOO] = server_foo style initialization to eliminate
errors due to mismatched numbers.
commit f413180295a80d3e9773753f098b95c58da60419
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 14 22:26:36 2008 +0000
* fixes a segfault in client-protocol, (bug introduced in previous commit).
commit b69479da32e021cb647e5d704faf5c133f7663a6
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Jul 14 13:14:05 2008 +0000
added gf_lk fop
commit d7a7976cda7842b37c23818a8ce78a187446e0e7
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Jul 14 13:06:36 2008 +0000
added new fop gf_lk
Patches applied:
* vikas@zresearch.com/glusterfs--gf-lock--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-217
* vikas@zresearch.com/glusterfs--gf-lock--1.0--patch-1
added gf_lk fop to posix-locks for internal locks
* vikas@zresearch.com/glusterfs--gf-lock--1.0--patch-2
added gf_lk fop
* vikas@zresearch.com/glusterfs--gf-lock--1.0--patch-3
added gf_lk in xlator.c
* vikas@zresearch.com/glusterfs--gf-lock--1.0--patch-4
handle gf_lk in io-threads
commit ca9b9d66b158ee0f4ef1f32609cf464fb1dc1625
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 14 06:13:11 2008 +0000
* Backquote support added to spec file.
* extra option in unify to drop the volume name in case of nufa.
commit 9377b28d5283b4940f4d13958782a47e92577640
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jul 13 19:19:39 2008 +0000
* moved 'dirent_size()' to compat.h, as on each OS it was seperate.
* a compilation fix in fuse-bridge.c over BSD.
* a segfault fix, which used to be called when -LDEBUG is used. (caused by patch-224).
* now 'ls -l' over BSD works fine.
commit 2d419ec62641dcff57e30a7f1fe362ca07ed340e
Author: Harshavardhana (y4m4) <harsha@gluster.com>
Date: Sat Jul 12 14:23:08 2008 +0000
RPM spec file update
Commit towards changes done for rpm spec file for 1.4.x
releases
commit 4905336a39201a1974c50a1c167d35ea6ecd3352
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jul 11 14:15:53 2008 +0000
* handling serving of zero-byte file properly in ioc_lookup_cbk and libglusterfsclient.
commit d20c66203cf2b8b62620f1770186f0316f273c42
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jul 11 07:13:27 2008 +0000
* License header update on few files
commit 0245b57c0c3ea214a683e217faae4bbfa61cc312
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 10 20:10:15 2008 +0000
* enhanced porting patch from Harsha <harsha@zresearch.com>
* definition to strdupa(), if not defined.
* using req->ino in server_statfs(), hence reduced a leak in server side.
commit 84c0903044b508a690c2c0ccab1677546e204d1f
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Jul 10 19:28:13 2008 +0000
Fix to trace the code flow.
commit fc866959b20cf4e9ad8739e035c30ee1e444e224
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 9 23:15:48 2008 +0000
* a extra check in glusterfs.c to make sure, mountpoint is given if the spec file doesn't contain protocol/server.
* added code in configure.ac to disable libglusterfsclient and modglusterfs over BSD and solaris for now, as libglusterfs was failing to compile on bsd/darwin etc. It can be removed when the testing is complete.
commit 20b013d1960bc882300d4bc2f7de4eda8519c7f6
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 9 17:50:45 2008 +0000
BSD porting
* BSD porting done. (Credits to Harshavardhana <harsha@zresearch.com>)
* minor warning fixes.
* Added fsetxattr and fgetxattr for solaris part.
commit 7201cd11a66da1f4c867de17792a7dffe91d4a6c
Author: Bala A <balugi@gmail.com>
Date: Wed Jul 9 10:44:52 2008 +0000
fix in gf_volume_name_validate(). make distclean removes all Makefile.in too
commit 577e1341989ae225024a469982af658ab3c16b54
Author: Bala A <balugi@gmail.com>
Date: Wed Jul 9 08:32:07 2008 +0000
added missing gf_strsplit() and gf_volume_name_validate(), and using strerror()
commit 1a8886c7f6a9b67867e8abf2e6bab3943a480bdf
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jul 9 06:20:19 2008 +0000
* memory leak fix in io-cache (ioc_lookup_cbk)
* STACK_UNWINDs in unify_lookup in case of error conditions were short of one more argument.
commit 45ad44d98d1e9017a94e91e0bacda9ef2ceee716
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Jul 8 13:02:13 2008 +0000
fixed bug in server_lk_cbk
server_lk_cbk had GF_FOP_FCHMOD instead of GF_FOP_LK
Thanks to electricitylikesme@hotmail.com for reporting this.
commit 02e202be256b20057525015a4dfd43688f82f96b
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 8 05:16:04 2008 +0000
* qa automation.. minor changes
commit eccc3ffaff98e0bb08217dec735f735460d930df
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jul 7 14:22:48 2008 +0000
lighttpd-1.5/mod_glusterfs fixes
* proper logging into lighttpd logfile.
* supports glusterfs.document-root. All the files served by mod_glusterfs are served relative to glusterfs.document-root.
* fix to mod_glusterfs returning 404 for files not on glusterfs.
* README.txt documents glusterfs.document-root.
commit fae17352394812a9ff17826644cbab97c7c0a8f4
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jul 7 12:48:45 2008 +0000
commit d86a2f0bc9e160b39ec5c7d8f248b35a5b46b0b2
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jul 7 12:45:54 2008 +0000
* bug: mod_glusterfs returning corrupted file with bdb as backend.
cause: bdb returns NULL pointer for dictionary if file-content need not be returned. Hence for files cached by io-cache, the dictionary was NULL. With io-cache not checking for a possibility of NULL dictionary, libglusterfsclient would'nt have returned the file-content in the buffer passed by mod_glusterfs.
fix: create a new dictionary in ioc_lookup_cbk if required.
* proper cleaning of per connection plugin-context in lighttpd-1.4/mod_glusterfs.
commit a19e4df77300b6014f019d9778df25ca454c149f
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 7 07:48:02 2008 +0000
* Changes required for QA automation:
- logfile will be uniq for each run/process,
- ps will show full command line
- extra option, '--run-id'
- print information at the begining of log file.
commit c42fe4c63272dbcc22d069c99ff28fa18eda3d11
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 3 20:34:18 2008 +0000
* cosmetic changes in glusterfs (like logmsg changes in spec.y, etc)
* added little more comments in unify.c
* afr setxattr fix (to work below stripe, for having no inode in loc)
commit 211c0b3a9f814edff2427c51332104492557ccfd
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 2 23:41:39 2008 +0000
* fixes the segfault issues seen with rr scheduler
* fixes in unify, to handle if scheduler return NULL due to some reason.
commit 4e9883401446c9af6d26699b319e0d5f68bc0d94
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 1 14:31:26 2008 +0000
* leak fix in posix checksum, buffer never free'd
* Changed hardcoded 4096 path length to GF_PATH_MAX
* made checksum buffers of unify local an pointer, which is allocated only during checksum calls.
commit 32372992d3cd418919fe9b61515e512d3d8baa96
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jul 1 14:44:10 2008 +0000
lighttpd-1.4/mod_glusterfs fixes
* proper logging into lighttpd logfile.
* supports glusterfs.document-root. All the files served by mod_glusterfs are served relative to glusterfs.document-root.
* fix to mod_glusterfs returning 404 for files not on glusterfs.
commit 6a19cb6979b537aefba206da28507a4955cd60d7
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jul 1 08:52:08 2008 +0000
* fix to access of files which are not on glusterfs resulting in 404 error. These files were being percieved by mod_glusterfs as present on glusterfs causing the bug.
commit d58f82a2e903e08f1c90ac2cb19ba875295b6300
Author: Bala A <balugi@gmail.com>
Date: Mon Jun 30 12:26:35 2008 +0000
updated Makefile.am
commit 82f882e24dfb5fca25dae4cb64130c1f593fa478
Author: Bala A <balugi@gmail.com>
Date: Sat Jun 28 06:20:05 2008 +0000
rewritten rr scheduler
commit 5c4284079ad72ad7b06fc42b0215c5efcf6eac44
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jun 27 08:44:13 2008 +0000
* fix to setuid/gid getting cleared during creation of hardlink. An lchown at the end of posix_link was causing the bug. Hence removed it.
Reviewer: Avati
commit 5259346cc14f7b65ed9e38c75ec7fc4c9f6c14f5
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jun 26 10:32:03 2008 +0000
* mac porting issues all fixed.
- Works fine on '10.5' Leopard, XCode Version 3, gcc-4.0.1
Follow wiki page for complete build instructions.
commit 8e1f93b78cd999bc966dd7797413c6fdfc8031c2
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jun 26 09:23:02 2008 +0000
fixes a issue with protocol's utimens
commit 503fe0abf2feab8e1bc56393034db148cf89ddb5
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jun 26 09:18:42 2008 +0000
fix warnings in input validation
commit 5bbeb98a9e9fe60d3398cdb73d9fee8c5ee7d12f
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jun 26 08:27:10 2008 +0000
fixed typo in write-behind
commit 784cd422b7f72df03431964dfbd56b3a0ba89c40
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jun 26 06:27:24 2008 +0000
write-behind coding style cleanup and prithu's patch for input validation of aggregate-size and window-size
commit f860444b875d6ebb9ad9d7b7740c03a431a70331
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jun 25 14:09:47 2008 +0000
write-behind patch from prithu and coding style fixes
commit 0183d083862b22984161c253465e8c78cfd3ad7c
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jun 23 07:13:23 2008 +0000
* porting pathname-prefix calculation from lighttpd-1.5. Fixes any bugs introduced due to trailing slashses in document-root.
commit 4447af02c650110fc74071d1805c3a4b8a2fb05a
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jun 18 04:29:43 2008 +0000
* unify now sends opendir to only namespace. Hence solving the issue of returning ENOTCONN even when just one node is down.
commit aff85012da4c082c14cc5da8d50fd4f98b490bb0
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jun 18 03:55:58 2008 +0000
* added <signal.h> in stripe.
* changed version to 1.4.0qa22 from 1.4.0qa19, (qa20 and qa21 were done inbetween already).
commit 4696ed544d83d72cf27c91137b860623bdf207f6
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jun 17 19:48:15 2008 +0000
Fixing du's previous fix. Minor fixes regarding setting of local->op_errno, unrefing frame->rsp_refs
commit de8bb9e54f80a3a01cff76bbe415cc791ee0e221
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 17 15:14:06 2008 +0000
* libglusterfsclient fills loc->ino for lookup revalidates.
* bug: glusterfs memory usage will be high during multiple dd's of large files with afr and nbio transport
cause: afr_writev_cbk does a STACK_UNWIND just after first successful write to one of its children, but write buffer is freed only when all the children have replied; thereby causing a scenario of infinite write-behind.
fix: afr does STACK_UNWIND only when it recieves replies from all the children.
commit b58dbba9d594b7a072892dc2e04973450adfc330
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 17 13:31:01 2008 +0000
* a bug fix in server-protocol create.
* changes in init to check setxattr support (of afr, stripe and posix).
* changes in posix-locks to see if its loaded on posix volume
* changes in code to handle SIGTERM to umount too.
commit 6b38df2f49f673a4fd83e60d26407baa23b515f1
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jun 15 07:47:16 2008 +0000
self-heal fix
* client getdents used to return empty array always as (op_ret > 0) was compared instead of (op_ret >= 0)
* posix: added path in the log of incver
commit 6332e678464ebe3e5a2f351fde4bc686adac8990
Author: Bala A <balugi@gmail.com>
Date: Sat Jun 14 08:25:58 2008 +0000
added more conversion functions and updated gf_str_to_long_long() removal
commit db9f51e583ee8231f86cb7aec9d1492fc2d263c2
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jun 13 19:37:55 2008 +0000
a quick fix for missing symbol
* Also Added THANKS file with _most_ of the people who supported us. May be incomplete.
commit 114ea9f4415e03095aa97bc13105bb9d7316b199
Author: Bala A <balugi@gmail.com>
Date: Thu Jun 12 11:26:15 2008 +0000
added string to number conversion functions and added input validation.
commit e0ed7861531e81718f453876d09e7badcbe1ba51
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jun 11 08:44:24 2008 +0000
* fix to glusterfs consuming lot of memory io-threads loaded on server side.
buffer length was not being set in req_refs.
commit f15bf7c6c68bc3e4b69bee73da7e4e8f77c8eef7
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jun 10 11:44:56 2008 +0000
Added more error logging.
commit 4fed3d0d62a5cb4079b4d3747ac15e2169aa9872
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jun 10 10:54:41 2008 +0000
Checking for local->call_count for 0, in which case frames should not go missing, STACK_UNWIND() should be done properly. Porting avati's fix that went into 2.5's 776. Also made frame->root->uid/gid 0 for lookup's selfheal.
commit 7980365f181320927bfd35a5e528dbdda9eebbfd
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 10 06:34:19 2008 +0000
fix for mtime/atime overwrite in protocol -- thanks to Brent Nelson
commit d3c2ab75f1f3e1b91f6fa4cb99190a0d97e7f602
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 10 06:23:25 2008 +0000
added missing server_inode->st_mode in server_create_cbk
commit f2b46bba88c0fd7aa342246d3847a7c6655a86c5
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 10 05:17:16 2008 +0000
removexattr bug fix in protocol
* order of path and key was changed in client_removexattr()
- reviewed by avati
* just changed the pattern of error msgs in unify from
"child(%s) file(%s) error(%s)" -> "child(%d): path(%s): %s"
commit 4d4a48dd50599d780e7d175eee7d1bb6dd6f4c38
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jun 9 08:00:07 2008 +0000
* enhancement round - N in unify logging
commit 9874965ea9ee915e5eead93c3a7fdea3022239b6
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jun 9 09:08:31 2008 +0000
* libglusterfsclient code-cleanup.
commit ba07c24a0d4b2c2b6287e49ba5d8b1beafcbbd15
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jun 9 06:58:00 2008 +0000
BDB options
* "page-size" option
* "log_auto_remove" option
commit 8a49652adf29005ed4faa6a2a9461fe09526dcff
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jun 8 12:38:05 2008 +0000
locks around dict_del
Reviewed by: Amar
commit 868774d45ea19616d699cccb24959cc66d5ec4ab
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Jun 8 09:24:22 2008 +0000
* fixed a dict_t leak in bdb_getxattr().
commit efd1a76151e2d932796e7990559c74cd1493f1ee
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Jun 8 09:20:18 2008 +0000
* bctx->dbp check against NULL value in bctx_rename() added.
commit b2bd2b8e9c240bfede74c3560ff36414f5ed53fd
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Jun 7 21:02:53 2008 +0000
* directory rename works in bdb. directories with any subdirectory cannot be renamed (EPERM is returned).
commit 802b18a3a6bc60e067a7a638e99964466fffaa7d
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Jun 7 17:47:32 2008 +0000
logging enhancements + minor bug fixes
* unify.c: enhancement in logging. now each fop_cbk prints "(child: file errno)" if a call fails, errno is made as a string, so no need for extra lookup.
* unify.c: fix of a corruption case (could happen in corner cases), where after a STACK_UNWIND(), there was no return 0;
* unify.c: unify rmdir() didn't set the errno's properly. fixed
* posix/bdb/fuse: logging enhancements for lk(), xattr() calls.
* fix in gf_error_to_errno to return actual errno in case its out of bound.
* bdb.c: changed return value of lk () from EPERM to ENOSYS
commit 84e82112de74b5bffe40aa1eab754c88a14eb4fb
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Jun 7 11:07:36 2008 +0000
* bdb now handles DB_LOCK_DEADLOCK error from DB->put/get/del operations.
* bdb now uses DB->stat to check if a db is empty, instead of cursors as used in earlier versions.
* bdb does DB_ENV->set_flags (DB_AUTO_COMMIT) during DB_ENV init.
commit a8c239feb51b59b8ee8b60f271b3fb22d16ec0ed
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Jun 7 06:29:05 2008 +0000
getxattr API interface bug fix in path-converter.
commit a531436cbf93635d34caf56f7517aa103805eaab
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jun 6 15:31:22 2008 +0000
* handle inode_ref/unref properly in lookup of libglusterfsclient
* change mod_glusterfs/apache-1.3/src/Makefile.am so that, it does not modify httpd.conf. To install mod_glusterfs to apache/libexec directory, user has to manually use apxs
commit 5a9d3406727997ba919db1a25b76af5fe881a47c
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 6 03:14:22 2008 +0000
close fds properly when EINTR is received
commit c56460c68d5b44dedc0e43bd95457e9e2a4710ca
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 6 00:26:57 2008 +0000
minor logging enhancement in inode
commit c9c365e540c9d80016e454ab9f7f77302b1c0ec6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jun 6 00:16:49 2008 +0000
* bdb_lookup() bug fix: bdb earlier was checking for loc->inode->ino, to differentiate between fresh lookup and revalidate. now properly using loc->ino.
* added DB_ENV->log_set_config(), in place for DB_ENV->set_flags for DB_LOG_AUTOREMOVE for compatibility with DB-4.7
commit 6d222e16a2fa5c6ee6752139e00d73a32fbb6cf8
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 5 19:37:59 2008 +0000
* added description about certain procedures.
* added DB_ENV->set_errfile() ('option errfile <errfile-path>' in spec file, if not specified, errfile will be
/dev/null)
commit db658a315a93896ab156cc55ee4c2d668434d0e8
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jun 5 14:00:37 2008 +0000
log all instances of forced name unhashes
commit de051e9bf3d455bbdc9c5f746e09823c4637249f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 5 13:21:11 2008 +0000
* fixed dbenv leak in bdb_checkpoint()
commit 7a36bc42f45116f99710202c7224dc4b2cd7bc46
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 5 12:55:40 2008 +0000
* return value check added for dbp->close() calls.
commit a91ddaa339d89ba7735ba4bfea9cfd911a93cc20
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jun 5 12:32:34 2008 +0000
lru_size fix in bdb
commit b5a27c30ea396bbb6920fca28c082012e1272a8e
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 5 01:12:28 2008 +0000
* bdb_checkpoint thread now uses the same db-environment handle as the db-execution thread.
* bdb log directory can be set with option 'option logdir <dirname>' in spec file.
commit 59dca55783c3556664102a6da9d9ceb164c7960f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jun 4 22:05:42 2008 +0000
* bdb_checksum() frame loss bug-fix.
commit a615bf7ffea2a9838bdc32694d4d7807c3a429ce
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jun 4 21:03:57 2008 +0000
* bdb_readdir() and bdb_getdents() fix: both do not return d_ino, instead -1 is returned for d_ino.
commit 0d5977252bd9c4262719ac741221a26245c6832a
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jun 4 20:44:16 2008 +0000
* bdb_readdir returns d_ino = -1 for entries inside db.
commit 8789e8bbcbc6fd151bbd98cac6f835bc8a303136
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jun 4 20:10:04 2008 +0000
* bdb spin lock fix in bdb_storage_del()
commit 758a34065d1532f0668249a415b6001e941819bd
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jun 4 19:02:12 2008 +0000
bdb bctx locking changes
commit a71aefd4a290686add4e4b1c7f00cec7375d46f8
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jun 4 18:32:35 2008 +0000
Fixes in epoll code to use EPOLL[IN|OUT|PRI] instead of POLL[IN|OUT|PRI]. fix in event_register_epoll to inc event_pool->used count only if idx_cache is not used. Fix in event_unregister_epoll to handle epoll_ctl failure properly and enabled used of idx_cache.
commit 49e9853a465850656d4e1c9cfac0e792878de7f4
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jun 4 17:02:54 2008 +0000
fix in server_setdents_cbk (strcpy only if op_ret = 0), allocate inode in sequence
commit cc2ea32cf2f2d330436901b1088d6d9d025226fd
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 3 22:26:52 2008 +0000
bdb - fail bdb_rmdir at entry.
- bdb_inode_transform() was not using priv->inode_bit_shift - fixed
commit 149220cfb132b4b21199ea0d31b7339f353696d9
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 3 21:51:08 2008 +0000
bdb_rename works for regular file and symlinks. directory rename not yet working.
commit 1e42db95cc8fc869446db0ae26236fdd4c215b64
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 3 19:07:08 2008 +0000
bdb checkpointing and log file deletion added
commit f80d17e5abdeab6398dbe55747dcd212f2768276
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 3 18:07:45 2008 +0000
handle EINTR on open/create/opendir
commit ffccebcc3a2470137f6558a54603b87715223b93
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 3 15:35:03 2008 +0000
* implementing window for write-behind.
commit 22cbd088f22e478e3bc106cb41197d4e8e3d17ca
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 3 12:56:06 2008 +0000
* fixed the extra unref being done by libgf_client_lookup for revalidates.
commit 4cb07d5ec388a7ed39940c0bb683748b7215956b
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 3 11:48:46 2008 +0000
* xlator_init_rec sends GF_PARENT_UP event to all children instead of parents.
* glusterfs_init waits till the connection is established with server before returning.
commit 3662525057b0c68645c27d3af83da9eacf2f093b
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 3 07:54:13 2008 +0000
* mod_glusterfs fixes.
-- reverted the changes done by input validation.
commit 955fbe86157dbcb481880f54350ec4c05d5718a2
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 3 05:17:59 2008 +0000
bdb bug fix
* added TRY_LOCK() pthread_spin/mutex_trylock() to common-utils.h
* checkpointing is done only if none of the thread is already doing checkpointing.
commit 2ccc8669e4bb1f1ce38fe6c3e58ae8f9d95f72e3
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 3 01:00:03 2008 +0000
bdb bug fixes and log message level change from GF_LOG_ERROR to GF_LOG_DEBUG for fuse_attr_cbk getting -1.
* bdb bug fixes:
- 'struct bdb_ctx *' handling re-architected. (see source file xlator/bdb/src/bctx.c for details)
commit 6b7d1e11893d081cc7594c2469c0d4fbf424f6a5
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jun 2 18:18:34 2008 +0000
compat-errno added in protocol
* Now, the protocol handles errno -> errorcode -> errno, which gives a solution for cross OS compatibilitity
commit 199e11eae42a96ba8cac14d0cbd6aed1ca210164
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 2 14:20:16 2008 +0000
reverting FREE changes to mod_glusterfs
libglusterfsclient users do not get common-utils.h - hence reverting
commit 4350256700773100cdba6adcc4a40dbef01d38ff
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Jun 2 07:17:09 2008 +0000
xlator->parent is replaced by xlator->parents (i.e a list of pointers to parent xlators.
commit 1dc503457d0129705efb16fb589d380822a1cf67
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 2 04:45:15 2008 +0000
commit 8c2200a7fa53ba548f89d4196230facb926dbd2d
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jun 1 19:41:42 2008 +0000
* Reverting chown changes in posix to as it was. None of these changes helped to fix the chown bug, rather my previous fix increased the number of failures.
commit 29449488ae8ffc5322aa1c8b18a4b8852a8f26ca
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Jun 1 18:18:13 2008 +0000
bdb bug-fix
* this patch fixes 'rm -rf' bug.
commit 675829fc27c11d5b3a5a8bdab65230702c9481ee
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jun 1 17:18:44 2008 +0000
* chown issue fixes over posix
commit 3cc8569671d90353de583a7570564d4a7da6eb41
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jun 1 08:40:24 2008 +0000
posix complaint test passed
* minor type FS_ID (should be FSID) in posix fixed. Fixes all the known chown problems with earlier tests.
* stripe rmdir and rename changed to handle mkfifo and symlink calls properly
commit 30906fcecc941e865564f5fabbf3bb6b908ccd4e
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jun 1 06:53:13 2008 +0000
fix for #23449
Reviewed by: amar
commit 16a69df7964e03603a20bb71305eb387dd3a7538
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat May 31 19:09:12 2008 +0000
bdb is now compatible with Berkeley DB 4.3 fully.
commit d640a47e736e6a65ad49fd0aa6ffdcd4ed3437f6
Author: Amar Tumballi <amar@80x25.org>
Date: Sat May 31 09:35:58 2008 +0000
segfault fix in link() path of protocol
* client-protocol.c:
- in link_cbk() UNWIND'd 'inode' was always NULL. fixed by setting frame->local = inode in link ()
- stbuf was returned instead of &stbuf, which led to corruption in higher layers. (cause for segfault).
* cluster/unify.c
- unify truncate never used to return the proper result. (mostly always it used to return success, even for the failure cases, because, the return value of stat() call over namespace node was used rather than the return value of truncate call from storagenode.
* storage/bdb.c
- return 'stbuf.st_nlink = 1' from create() and lookup() [for regular files], solves the issue of tons of revalidation msgs.
commit 47d5bf36cc3500f2086bbe74738ade417e76d874
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri May 30 13:08:50 2008 +0000
bdb_storage_get() bug fix
* bdb_storage_get() does partial get properly.
commit d445702f77d1124259385edb3704e6a098909777
Author: Anand V. Avati <avati@80x25.org>
Date: Fri May 30 09:11:39 2008 +0000
fix in server_getxattr_cbk
commit 0964808b4babc72a17ac6c39788272ed6b7cfe32
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri May 30 08:46:36 2008 +0000
* bdb->b_lru list-add is protected against double add.
commit 3458c58ee8d912c1c26b1105977b84e11ac78cbc
Author: Bala A <balugi@gmail.com>
Date: Fri May 30 07:10:04 2008 +0000
Input validation fix
commit 658a04bfa3812f60f31a261b07f7b2665d673c13
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri May 30 07:10:07 2008 +0000
bdb bugfix
* 'struct bdb_ctx' is removed from b_hash hash-table before cleaning up.
commit 297943899223f86d0cffc9154da952c0dd4a28cb
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri May 30 06:13:13 2008 +0000
merging bdb bug fixes
Patches applied:
* gowda@zresearch.com/glusterfs--bdb--1.3--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-124
* gowda@zresearch.com/glusterfs--bdb--1.3--patch-1
bdb - missing bdb_ctx bug fix
* gowda@zresearch.com/glusterfs--bdb--1.3--patch-2
bdb bug fix
commit 4740492b2dcdb24a7fc12b40cd8ec9e7faca6e76
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 29 23:26:20 2008 +0000
fetch_spec fix
* Fixes the problems with fetch spec.
- handle 'non-blocking-connect off' option in transport
- rsp = gf_param (hdr) in client_getspec()
* Memory leak fix in tcp transport,
- when a client disconnect, the trans->priv was not free'd up in fini ().
* Updated client and server protocol xlator to use ERR_ABORT and FREE macros.
commit 5c64ea8079e7dc68ef47f810f47073063638b761
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 29 18:34:24 2008 +0000
backward compatibility code for transport-type <trans>/{client,server}
commit 63baf9613b3a6a6d277459b659dec1b244deebc2
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 29 18:19:00 2008 +0000
put mount.glusterfs in $(DESTDIR)/sbin and fix in mount.glusterfs.in for --transport
commit 0467d3e04e234cf29c0d3b5b196d61a19e11f987
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 29 17:28:37 2008 +0000
* fix in call bail logic in protocol/client
* fixed warnings in timer - caused by argument checks
* fixed improper argument check in ns locks
* fixed warnings in fdtable - caused by argument checks
commit acffdf70d7b1c3572a3b6a83f9bdf8316a676d67
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu May 29 14:45:24 2008 +0000
fixed bdb_incver definition warning error.
commit 9e08c021b34a86630b6e584a11d1a44fd1644cad
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 29 07:53:45 2008 +0000
added missing op_ret/op_errno in server_create_cbk
commit 56a2849b888cf67671f96f3de187d56837b105f0
Author: Bala A <balugi@gmail.com>
Date: Thu May 29 05:56:06 2008 +0000
Added input validation
commit c4a851123f78f3d62c6d0ef6ce1d7db9e74da088
Author: Amar Tumballi <amar@80x25.org>
Date: Wed May 28 21:09:28 2008 +0000
* fixes in fuse-bridge (to create fuse thread in notify() rather than init())
- gowda fixed it in glusterfs--mainline--3.0 branch, patch-105
* fixes in mount.glusterfs.in to handle different transport options
commit 777c66edd8e5e1926441c512b320fbf62a0b2d89
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed May 28 13:53:23 2008 +0000
bdb_rename() has issues, directory rename is not complete yet.
Patches applied:
* gowda@zresearch.com/glusterfs--bdb--1.2--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-117
* gowda@zresearch.com/glusterfs--bdb--1.2--patch-1
bdb_readv() return value fix
* gowda@zresearch.com/glusterfs--bdb--1.2--patch-2
bdb bug fixes
* gowda@zresearch.com/glusterfs--bdb--1.2--patch-3
commit 90b0dff1594391664e130a3c100bb48469eb24dd
Author: Anand V. Avati <avati@80x25.org>
Date: Wed May 28 12:38:07 2008 +0000
fix hang caused by epoll unregister
commit 842a013261ce3d8106fb160b5462a32d289b14e1
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed May 28 12:27:44 2008 +0000
incver fop now carries "fd" in addition to path. When it is not NULL "increment version" is done on fd instead of the path. incver interface is now used to bump version in close, ftruncate, truncate, and all fops which change directory contents.
commit b52a700f653df6bf19ff11ba58655b0db17eca13
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 27 18:32:31 2008 +0000
fix against double unref of transport when connect() takes long time
commit 4e291625ac3b3962e9096f9aea3850bab8d53d0a
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 27 17:30:15 2008 +0000
nbio - fix corner case hangs and leaks
commit 8a331f8720a86112c471fdd103c65fa189eec915
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue May 27 13:59:18 2008 +0000
server_setxattr bug fix
commit 2957bd26a7a365c2f748acf4548f8c1f6d266a42
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue May 27 10:45:06 2008 +0000
bdb_getdents bug fix and bdb_checksum mem-leak fix
* bdb_getdents: added cursor_open.
* bdb_checksum: cursor_get() now gets only key, no value.
commit b12a4fbda35c931d6ce9dd98153290d32978b8b7
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 27 07:34:12 2008 +0000
fixes in bdb
- memory leak fix in bdb_checksum (free value.data)
- cursor was not opened in bdb_getdents
commit 2f0a1fb32affa81f207950cb6a147276bdbb4a07
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon May 26 14:53:28 2008 +0000
io-cache bug fix
* io-cache bug:
- if a frame is waiting on a page, at the time of calling ioc_inode_flush(), then the page is not destroyed. this leads to io-cache returning stale data, for the frame which actually went for re-validation.
* fix:
- re-validate call-back now generates a page fault for the pages which have waiting frames, when re-validation fails.
commit 460aefadc828b53bae5133d1cb1a9b69a82668d1
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon May 26 14:30:18 2008 +0000
fixing merge conflicts.
commit d75def2a3643d1252ba27f3d278f2dff32f05654
Author: Anand V. Avati <avati@80x25.org>
Date: Mon May 26 11:33:33 2008 +0000
merge from glusterfs--nbio--1.0
Patches applied:
* avati@zresearch.com/glusterfs--nbio--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-66
* avati@zresearch.com/glusterfs--nbio--1.0--patch-1
migrated to event.c/h from poll_* and epoll_*
* avati@zresearch.com/glusterfs--nbio--1.0--patch-2
* avati@zresearch.com/glusterfs--nbio--1.0--patch-3
byte-order.h and protocol.h changes
* avati@zresearch.com/glusterfs--nbio--1.0--patch-4
merge from mainline + intermediate commit
* avati@zresearch.com/glusterfs--nbio--1.0--patch-5
tcp proto state machine working
* avati@zresearch.com/glusterfs--nbio--1.0--patch-6
handshake successful
* avati@zresearch.com/glusterfs--nbio--1.0--patch-7
lookup works
* avati@zresearch.com/glusterfs--nbio--1.0--patch-8
leak fix in protocol client
* avati@zresearch.com/glusterfs--nbio--1.0--patch-9
tla added protocol files
* avati@zresearch.com/glusterfs--nbio--1.0--patch-10
tla added event.c
* avati@zresearch.com/glusterfs--nbio--1.0--patch-11
ntoh/hton in protocol_client_cleanup ()
* avati@zresearch.com/glusterfs--nbio--1.0--patch-12
ls working
* avati@zresearch.com/glusterfs--nbio--1.0--patch-13
file read works (does not close :p)
* avati@zresearch.com/glusterfs--nbio--1.0--patch-14
merge from amar - 1
* avati@zresearch.com/glusterfs--nbio--1.0--patch-15
read/write working
* avati@zresearch.com/glusterfs--nbio--1.0--patch-16
lot of small fixes to work stable
* avati@zresearch.com/glusterfs--nbio--1.0--patch-17
readlink, create and some stability enhancements
* avati@zresearch.com/glusterfs--nbio--1.0--patch-18
more fops converted
* avati@zresearch.com/glusterfs--nbio--1.0--patch-19
some more fops
* avati@zresearch.com/glusterfs--nbio--1.0--patch-20
build break fix
* avati@zresearch.com/glusterfs--nbio--1.0--patch-21
merge from amar - 3
* avati@zresearch.com/glusterfs--nbio--1.0--patch-22
attempt re connection in protocol/client xfer
* avati@zresearch.com/glusterfs--nbio--1.0--patch-23
fix segfault in df
* avati@zresearch.com/glusterfs--nbio--1.0--patch-24
handle random disconnections on large write
* avati@zresearch.com/glusterfs--nbio--1.0--patch-25
mop patch from amar
* avati@zresearch.com/glusterfs--nbio--1.0--patch-26
default remote-port to 6996
* avati@zresearch.com/glusterfs--nbio--1.0--patch-27
fix infinite loop caused by iov_len == 0
* avati@zresearch.com/glusterfs--nbio--1.0--patch-28
dents patch from amar
* avati@zresearch.com/glusterfs--nbio--1.0--patch-29
fix in tcp_submit
* avati@zresearch.com/glusterfs--nbio--1.0--patch-30
*dents fix from amar
* avati@zresearch.com/glusterfs--nbio--1.0--patch-31
merge from mainlin--3.0
* avati@zresearch.com/glusterfs--nbio--1.0--patch-32
merge fixes
commit 2c7241867196ea0d4da57a8e4dde33c6cfa04284
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon May 26 12:35:41 2008 +0000
introducing caching of files in ioc_lookup
commit 24af48320ead2b1dc815838ffef1034d6876d03e
Author: Amar Tumballi <amar@80x25.org>
Date: Fri May 23 20:32:45 2008 +0000
* minor bug fix in access () path - should help to make solaris fuse work fine.
commit c9090043cc6052fdfd33a63ae68c6a7ce023fc49
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 22 03:49:28 2008 +0000
Working path-convertor
Patches applied:
* amar@zresearch.com/glusterfs--path--1.0--patch-6
* amar@zresearch.com/glusterfs--path--1.0--patch-7
* amar@zresearch.com/glusterfs--path--1.0--patch-8
* amar@zresearch.com/glusterfs--path--1.0--patch-9
Working path-convertor
commit 87bd760b4aa00316082ae924061c1bb3ff559648
Author: Bala A <balugi@gmail.com>
Date: Wed May 21 11:06:47 2008 +0000
FREE() macro compilation warnings and other warnings fix
commit b6ed88e0349e5a6b2bf62691e368ad9b4d9ca1dc
Author: Bala A <balugi@gmail.com>
Date: Wed May 21 10:13:24 2008 +0000
Added ERR_ABORT() macro which aborts when memory allocation failure
commit 1d6f8e95ba3d2144a0785a8aa414c777d32aeb15
Author: Bala A <balugi@gmail.com>
Date: Tue May 20 09:58:10 2008 +0000
Added FREE() macro and removed freee() macro.
commit e4d2ef02b5a44169b6719d3380567f3877f59c49
Author: Amar Tumballi <amar@80x25.org>
Date: Tue May 20 08:47:58 2008 +0000
Path Convertor added
Patches applied:
* amar@zresearch.com/glusterfs--path--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-103
* amar@zresearch.com/glusterfs--path--1.0--patch-1
bare minimum conversion - working
* amar@zresearch.com/glusterfs--path--1.0--patch-2
* amar@zresearch.com/glusterfs--path--1.0--patch-3
* amar@zresearch.com/glusterfs--path--1.0--patch-4
* amar@zresearch.com/glusterfs--path--1.0--patch-5
commit 9e513871f4b697c1178c8260ffd92d2ec0422095
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue May 20 07:53:41 2008 +0000
bug fix in mount/fuse and block count fix in bdb.
* mount/fuse fix:
- since glusterfs.c:main() calls fuse's init() before doing tree_init(), creating fuse-thread in fuse's init() is wrong. fuse-thread is created only after fuse recieves CHILD_UP notify.
* storage/bdb:
- bdb now returns st_blocks, based on size of file. earlier st_blocks was corresponding to database file.
commit 42115f27b1f382dcf6ae25e10a5cae043b53f64f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon May 19 14:28:22 2008 +0000
bdb bug fix
* bdb notifies parent with CHILD_UP only if bdb's init() has finished job.
commit 9c49196968eb260a26e1bfd9ecc1085b18b55eb0
Author: Bala A <balugi@gmail.com>
Date: Fri May 16 06:11:03 2008 +0000
Help comment fix glusterfs.spec.in
commit 50261ac49e8c33f0c4dd9fcf7ed5e1f111a116e7
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 15 22:24:14 2008 +0000
* Fixes in server_setdents () - fixes the segfault issue when unify is used.
* posix_checksum will be using calloc'd array instead of stack, which was causing checksum to fail always, as the reply buffer was freed before it gets written to network.
commit 07eded7f09eb59634c26de0a4b7e8c1f0b34ef5e
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 15 09:34:20 2008 +0000
* Fixes in Binary protocol
- dict->extra_free = buf is not needed in client lookup_cbk() as buf is pointing to data received.
- readv_cbk() in server now gets the vector itself as argument instead of CHAR type of vector[0] (removed the #if/else)
- fix in interpretation of fields in setdents () of server protocol.
commit f8dfe9f9827cc1fdd9beeb899c5028cbe5f2eff1
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu May 15 05:10:25 2008 +0000
merging enhance storage/bdb
Patches applied:
* gowda@zresearch.com/glusterfs--bdb--1.1--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-70
* gowda@zresearch.com/glusterfs--bdb--1.1--patch-1
added new options to bdb
* gowda@zresearch.com/glusterfs--bdb--1.1--patch-2
* gowda@zresearch.com/glusterfs--bdb--1.1--patch-3
symlink support added
* gowda@zresearch.com/glusterfs--bdb--1.1--patch-4
bdb supports transactions now
* gowda@zresearch.com/glusterfs--bdb--1.1--patch-5
* gowda@zresearch.com/glusterfs--bdb--1.1--patch-6
fixed memory leaks in bdb_lookup, bdb_close
* gowda@zresearch.com/glusterfs--bdb--1.1--patch-7
added root (/) inode creation in init() of storage/bdb xlator
* gowda@zresearch.com/glusterfs--bdb--1.1--patch-8
removed unnecessary warning message from configure.ac
* gowda@zresearch.com/glusterfs--bdb--1.1--patch-9
file, directory, symlink permissions fix to bdb
commit 7c6da1a773e49eaf7cdf01be14f05f5ce8cac8ba
Author: Amar Tumballi <amar@80x25.org>
Date: Wed May 14 20:51:31 2008 +0000
INTERNAL CHANGE: Binary protocol will be used by default from now on.
* moved xlators/protocol to xlators/protocol-ascii
* Changed makefiles so that binary protocol will be installed in xlator/protocol,
and ascii protocol in xlator/protocol-ascii in libdir, hence all the earlier
spec files will seemlessly use binary protocol without any changes.
* All response and request refs are handled properly now, hence no corruption
in case if any performance translators are used.
* minor logging fixes in:
- cluster/stripe : lookup_cbk was printing logs for -1/ENOENT, which was
unnecessary.
- dict_copy on empty dict used to print lot of error logs (dict should not
be empty in first case), now it checks for dict, then does dict_copy.
commit ffac80a66a2737bc2280afdd4732f858d729bf5a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed May 14 13:06:12 2008 +0000
In lookup_cbk, we return the stat info based on ctime/version rather than mtime of stat. We should move away from using stat's info towards glusterfs's xattrs.
commit dd9cf331c82604258924628a9df95d2c9d747877
Author: Amar Tumballi <amar@80x25.org>
Date: Tue May 13 20:50:53 2008 +0000
BSD compilation fixes.
* Fixed BSD compilation issues. Thanks to Harshavardhana <harsh@zresearch.com> for patch.
* Now posix_readdir() has telldir() for d_off, hence no ifdefs in posix.
* Removed setrlimit for DARWIN OS, as it was always failing on Darwin machines.
commit e58feb3ef350dd37149e44735670eedee15e8660
Author: Amar Tumballi <amar@80x25.org>
Date: Tue May 13 00:39:43 2008 +0000
* Few minor fixes, reported by Jean-Jacques Sarton <jj.sarton (at) t-online.de>
* initialize pidfd to 0.
* errno fix in connect() case of all the transports, helps on Solaris.
* compatibility in client and server protocol for access ().
commit 04b3afd04d67bae24f49caba4579b16d5c35c0ff
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 12 22:28:41 2008 +0000
* Support of io-vector in argument fields.
* Tested binary protocol with stripe,unify,afr. with wb,ra, iot.
* Currently on server side, binary protocol is not compatible with iot as buffer gets freed up in case of write. Need some mechanism to protect it, evaluating refs, this is not good with binary protocol though.
commit af0ee1534b7e4dadc7af326541ebdc9ee42cf05d
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 12 21:54:43 2008 +0000
* Fixes the server hang in case of client disconnects.
commit 16b219aa6c01cb4d71d39fc4b50391aa49901159
Author: Anand V. Avati <avati@80x25.org>
Date: Mon May 12 19:40:53 2008 +0000
afr_lk was storing pointer on the stack to lock structure. now copies structure.
Reviewed by: amar
commit 41a08f8ba67b9347258fac82941085a1e9b32b63
Author: Anand V. Avati <avati@80x25.org>
Date: Mon May 12 18:53:21 2008 +0000
default timeout to 42 seconds. check timeout every 10 seconds instead of every timeout interval
commit 8c2fc9317149d7619637393c190dab06307cc465
Author: Anand V. Avati <avati@80x25.org>
Date: Mon May 12 18:48:02 2008 +0000
setting SO_SNDTIMEO and SO_RCVTIMEO in tcp/server to 15 seconds
commit 9f9389bfc20117dfe743aa2995a68e3e0c459410
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri May 9 10:59:16 2008 +0000
setdents/getdents now supports symlinks. Hence in AFR selfheal, healing of symlinks is supported.
commit 0934b74c07233eb9893b94eab6bc983a42bf4bd1
Author: Amar Tumballi <amar@80x25.org>
Date: Fri May 9 02:42:32 2008 +0000
* applied changes in setdents/getdents made to support symlink in binary protocol too.
* changed block_to_iovec(), so there is no memcpy of any buffer involved.
* no leak observed. need more testing.
commit 8a3bbf8a041f0f34754328c8315ceea470850d2a
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu May 8 12:48:54 2008 +0000
fixed typo in io-cache/page.c
commit 6716961f1bdf2d1caf64a66bea1ef59e3d5ecb5f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu May 8 10:01:32 2008 +0000
io-cache bug fix
* bug details: io-cache searches for a page in cache, finds it and sends a revaildate requests. some more pages
from the same inode are requested for and io-cache appends all the pages to the inode's waiting
list. while appending to waiting list, io-cache never checked for duplicate entries, i.e, same
page waiting more than once for revalidate.
the situation when same page is waiting more than once for revalidate to return, first
wakeup_page() on that page clears all the pending frames on that page. since the page doesn't
have any waiting frames, page may get destroyed any time. if the page gets destroyed before,
wakeup_page() is called for all waiting instances on revalidate, then we have a danglinglin page
pointer in inode's waiting list.
fix:
* once a page decides that it is going for revalidate, it changes its state to 'in-transit', instead of
'ready', this step makes sure that revalidate is done only once per page at a given instance.
commit 9be955ed8f3ca54b3aa8510b57ecf6ca537e2d98
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 8 09:44:34 2008 +0000
check for st_mode in posix_lookup for glusterfs.content xattr
commit a8dea621e5b00cd64068d74d5fd0f7b8bfbd91b7
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 8 03:28:15 2008 +0000
* Kernel compile on 64 bit machine works fine without _leaks_ (on binary protocol)
commit b5c4a13f31e9c763ca9d3e52ac42ffd232504976
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed May 7 12:52:53 2008 +0000
* fixed indentation in mod_glusterfs
* made lighttpd-1.5/mod_glusterfs resistant to any bugs due to extra slashes at the end of server.document-root
Eg., server.documentroot = "/lighttpd-document-root" or server.documentroot = "/lighttpd-documentroot/" both should work without any bugs
* fixed memory leak in glusterfs_lookup_async. STACK_DESTROY (frame->root) was not being done.
commit 24e244cca1b620b39d1ac3e3352dd253070c1c20
Author: Amar Tumballi <amar@80x25.org>
Date: Wed May 7 08:57:50 2008 +0000
linking issues in MAC OS X port fixed.
commit bc53fd8e787ab7635aef289bed9964a615616de3
Author: Amar Tumballi <amar@80x25.org>
Date: Wed May 7 08:45:47 2008 +0000
* memory leak fixes in binary protocol. Its working quite stable now, and no memory leaks seen.
commit 631dcdbf6dd1829f533986b5074955cc782a4386
Author: Amar Tumballi <amar@80x25.org>
Date: Wed May 7 03:04:06 2008 +0000
* committing 'errno' portability code. This helps to work fine on cross OS.
commit 8b4a14851ffcd0f27595f61ec3b24c376ac39d82
Author: Amar Tumballi <amar@80x25.org>
Date: Wed May 7 01:29:49 2008 +0000
Now, the fuse error logs contains strerror (errno) instead of error()
Patches applied:
* amar@zresearch.com/glusterfs--log--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-71
* amar@zresearch.com/glusterfs--log--1.0--patch-1
log enhancements.
* amar@zresearch.com/glusterfs--log--1.0--patch-2
more log enhancements.
commit 2b1d9e7858521b4b8b2c741a5c3a24d95d96e8a2
Author: Amar Tumballi <amar@80x25.org>
Date: Wed May 7 00:52:41 2008 +0000
* tested over 64 bit, and its working fine, there are some memory leak.
commit dffe808718a5cd37a3d5f46e6f7534c21141ed5a
Author: Amar Tumballi <amar@80x25.org>
Date: Tue May 6 23:35:42 2008 +0000
Version 0.3 of Binary Protocol.
Its in usable state, but more testing on 64bit machines, and bigendian machines needed.
commit 5b48c60d0a90b40ab15b063d44f41864edc45c68
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue May 6 16:37:32 2008 +0000
mod_glusterfs port to lighttpd-1.5.0
commit b052f3d5ed40ce17b2b9fc21dfa0fbf688f1033e
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue May 6 16:30:39 2008 +0000
adding glusterfs_lookup_async to libglusterfsclient
commit 4923297c9f5e8a6be75db9a46aed0cd99880c835
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 1 16:51:04 2008 +0000
Patches applied:
* gluster@sv.gnu.org/glusterfs--mainline--2.5--patch-734
(handling ESTALE when "option self-heal off" is given in unify)
* gluster@sv.gnu.org/glusterfs--mainline--2.5--patch-743
(Enhancement in server-protocol getspec() to look for the vol.<clientIP> before looking at vol itself)
commit 40c248fad98bf4de9ba9be92bfc78ac145bf63ed
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 1 07:52:13 2008 +0000
* build fixes from previous commit (also removed warnings)
commit 4cb56130dfffe05c2d16e0e95317d26d425d1aed
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 1 07:27:41 2008 +0000
* BUG ID #23026 (in savannah) fixed.
AFR now returns the statvfs of the subvolume which has minimum free disk.
commit 83ad55c9f824e911fd96e780bf23fffc0896fb98
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 1 07:23:54 2008 +0000
* unify open will succeed now if file is present on more than one data subvolume, but will send EIO only if its present on Namespace.
commit 5629158d9e5a2fcf114214e6c654a3f988cdf1ea
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Apr 30 07:01:48 2008 +0000
fixing warnings due to not including sys/stat.h in libglusterfsclient.h
commit 830017b081a9170f1664da94eafab6bcc79b1199
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Apr 29 09:57:20 2008 +0000
* fixed mem-leak in unify. dict_unref was not being done on the dictionary passed in unify_lookup_cbk.
Keywords:
commit a63169c88b7818909670146c14bc1237f72464bd
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Apr 26 03:57:04 2008 +0000
* a small fix in Makefile.am of booster to compile over MAC OS X
commit a7f0e5959235333cae2ae620ddd00669c5bfd779
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Apr 25 15:00:49 2008 +0000
build scripts enhancement
Patches applied:
* gowda@zresearch.com/glusterfs--qa--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-61
* gowda@zresearch.com/glusterfs--qa--1.0--patch-1
fixed build scripts for mod_glusterfs, fixed build warnings
* earlier 'make install' of mod_glusterfs used to alter /etc/apache/httpd.conf, it has been changed and make install of glusterfs doesn't touch any system files. Instead a new httpd.conf file will be generated based on /etc/apache/httpd.conf and installed in glusterfs install directory.
commit cbb5e45e0e59b7327e178e96b107a51c6224fd62
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Apr 25 08:45:43 2008 +0000
fixing build error in libglusterfsclient (defaults.h was not included)
commit 8c61091508ff3bc0718cfda0a5192ad76abb95f9
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Apr 25 06:39:29 2008 +0000
* mount.glusterfs.in: Copyright changes (added 2008)
* posix: posix_setxattr(), added key in the log when the call fails.
commit aba9975c78fce90ff1a32124337bbc7f55138388
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Apr 25 06:18:18 2008 +0000
changed the configuration key glusterfs.xattr-file-size to glusterfs.xattr-interface-size-limit
commit ef5d953e9eca2127e940a43b2129e2bdfd99c01c
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Apr 25 05:34:11 2008 +0000
* changes are only in Copyright part of the code. (updated to 2008 copyright)
* Added copyright information to Makefile.am
commit fa3d3ec6eb6a03b0f8a5be87110373d108b885cb
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Apr 25 03:18:41 2008 +0000
* changes in notify structure of PARENT_UP event, as FUSE->init() is done before other translators.
commit 5d3b8e3b4524bd6244a7501f90c321fcbe631e86
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Apr 24 21:46:02 2008 +0000
* Enhancement in setrlimit (), now its called in init of posix, serverprotocol and client protocol.
* Removed from glusterfs.c
commit a8892194c0c7e0715e20f80cf9d304c5006b78e5
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Apr 24 16:58:30 2008 +0000
* Bug fix for getting wrong checksum of file content while running benchmarking tool on edgecast setup. After the first access of a file from lighttpd, any subsequent access would result the stat being fetched from the stat-cache of lighttpd. But stat-cache dont store file-content resulting in lighttpd sending zeroed content to client. Note that this happens only if the file is being read through the extended attribute interface.
* Updated mod_glusterfs/lighttpd-1.4/README.txt.
* Fixed build warnings.
* Fixed memory leaks in lighttpd/mod_glusterfs.
* intialized poll type to epoll, lack of which was causing connection timeouts in edgecast setup.
commit 99e74e7bb6dd856c6c967ae3fc84ec185f0b194b
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Apr 24 06:32:57 2008 +0000
Fixed a few FIXMEs.
commit b55c697016f3148b415244039ec166d13cfec12b
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Apr 23 21:33:31 2008 +0000
* Log changes in unify*.c
* Fixes wrong entries seen in log file, (high entry count for files) in unify_lookup
commit 1364d8e291c2ff9d1b2053613b408b656abb9b97
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Apr 23 19:58:11 2008 +0000
* Warning messages added when setrlimit() fails.
* Because on few nodes setrlimit (INIFINITY) fails, limit for openfd will be retried for 1M.
commit 836d37c4ea9fd5e4f56efd1f1c3cf9ca5d4b36de
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Apr 23 01:59:16 2008 +0000
AFR lookup_cbk will pass on the xattr of the latest subvol to the upper xlators.
commit 10e6e8732407956fbe897c3bd042a82185eb0cf2
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Apr 22 13:36:35 2008 +0000
* lighttpd/mod_glusterfs: initialize buf to NULL in mod_glusterfs_handle_physical
* posix.c: check for successful completion of lstat in posix_lookup before trying to open the file in case of non-zero need_xattr.
commit 8a3863ec6709f449416609535787f9cdb86cc612
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Apr 21 18:54:08 2008 +0000
bug fix to bdb lookup need_xattr
commit beec7595d9d0b990bc70e075554b41387f63a3d6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Apr 21 14:22:27 2008 +0000
bug fixes to unify setxattr and change in cache-layout for bdb.
* unify
- unify setxattr bug fixes.
* bdb
- bdb now has per directory cache, instead of global cache of key/value pair.
commit cf756b20efe8026a44aa3d186b5ab36372ab0660
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Apr 21 11:40:16 2008 +0000
lighttpd/mod_glusterfs sets proper http_status codes in case of errors
commit 3f64b14989189f1e958853774e17fbf7ecbbc82a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Apr 21 09:37:17 2008 +0000
* introduced reading of files through xattr interface in apache/mod_glusterfs
* fixed build error that was introduced due to lighttpd/mod_glusterfs
* auth/ip returns AUTH_DONT_CARE instead of AUTH_REJECT if a client is not bound to a privileged port, so that other modules can take care of authentication.
commit c6d002b20334cce8f2f96f636251858777aa2334
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Apr 21 03:36:20 2008 +0000
* changed log level of bdb_getxattr() op_ret == -1, logs, from ERROR to DEBUG. Otherwise, in case of usage of bdb with unify, it will be flooded in the log files.
* Fixed issue in write-behind init(), to properly initiate the flush-behind on/off flag.
commit 3c6bdaaf10826d4c717e844802f21bb830952531
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Apr 21 01:27:22 2008 +0000
* critical bug fix.
- Fail to setup GlusterFS over ib-verbs transport, when connected, server recieves the log,
"header corrupted".
- Reason: Change in the order of FUSE initialization.
- Fix: Initialize the FUSE before any other translator (matters for client side only).
commit 4ece8f44613d88d61049c14f02807efbfbb9340d
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Apr 21 01:14:12 2008 +0000
* A critical error in case of using IB-verbs is fixed.
- The problem was seen randomly on few configurations, when ib-verbs transport protocol is used, and always 'header-corrupted' error used to come. And system always used to give 'Transport Endpoint not connected'
- Reason: The changing in the order of FUSE's init() has caused it, because the ibv_reg_mr() used to fail.
commit 8a2bb9c89c5b38560399b4dd0fbf9407f1972dee
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Apr 20 20:52:47 2008 +0000
local->path reset :)
commit 24fec6ce8b790e961a0fcc0e8fbfb8f6fe1a6efc
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Apr 20 20:50:14 2008 +0000
path leak fix in unify_setxattr_file_cbk
commit 1fe6c49a2bad2a39254aa6c16c343f962309ba22
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Apr 20 20:25:07 2008 +0000
strdup path in unify_setxattr
commit 0bc28592c5fb1cf7fc3cc038a164927924bd1062
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Apr 20 20:15:50 2008 +0000
leak fix in unify_setxattr
commit 58a61aa3c90d2055a645ef598790550d0fd51c45
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Apr 20 19:59:11 2008 +0000
bug fix to libglusterfsclient and server protocol to handle inode->generation.
commit 0b9a852bd91cdea6a164e30bb6744c59efdbadec
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Apr 20 19:08:35 2008 +0000
* Fixes for compilation on Solaris
- removed d_type from dirent structure.
- added #include <alloca.h> in common_utils.h
- removed signalhandler_t variable from glusterfs.c
commit 57902f5e3ec0aa4c935db6cf3cd13944afe6d499
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Apr 20 18:51:16 2008 +0000
logging changes
commit 73d43861b2e2ab3d0c79b99828187d12fbf13cbc
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Apr 20 18:20:56 2008 +0000
bug fixes to ib-verbs, server-protocol, bdb and posix.
* ib-verbs
- handle ib_verbs_get_device() returning null, by returning -1 to the caller in ibverbs_init.
* server-protocol
- set inode->st_mode = stbuf->st_mode in server_stub_cbk().
* bdb
- bdb_transform_inode() allows for 2^24 inodes under a directory now.
- added new procedure bdb_delete_from_cache(), to delete a key/value pair from cache
during bdb_storage_put().
- bdb_storage_get() copies data to an additional buffer and returns, unlike earlier version
where pointer to data in cache was returned.
- stbuf->st_size = 0 in bdb_mknod.
- directory revalidate is properly identified now by dict_get (inode->ctx, this->name).
* posix
- changed strcat() to sprintf() to form the full path to a file, in getxattr and setxattr.
- data lenght, as set in dict in getxattr was off-by-one earlier. fixed the error.
commit 2e0a0c6c17b18041ad7ef875a58977a89bb65387
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Apr 20 00:31:51 2008 +0000
* Changes in glusterfs.spec.in for Building single package RPM instead of
multiple common, client and server rpms.
* Added support for --without-bdb, --withought-libglusterfsclient and
--without-mod_glusterfs
commit 4bfe32e948545945fddd9590640b8e7a9c0f9709
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Apr 19 23:58:17 2008 +0000
* Enhancement to glusterfs.spec.in so that there will be only single rpm
instead of common, client and server.
commit 59658417a7aaaf5ba869f8899fb4db493c9ae851
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Apr 19 21:49:40 2008 +0000
fixed make dist
commit df963419e381863a5a82885e6d3723dc817c4686
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Apr 19 21:35:27 2008 +0000
mod_glusterfs for lighttpd-1.4.19
commit 4d8aea7f2c884fa6551ab9e3323c18aea2bcb29c
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Apr 19 21:13:31 2008 +0000
bug-fixes in libglusterfsclient
commit 62b2197421afd5f68155ae75ac1af9dbcb86965f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Apr 19 13:18:00 2008 +0000
changed typecasts from int to long while returning fd in libglusterfsclient
commit 7e1fd424d752ddfc82701ebc3e3d286f1663d556
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Apr 19 12:48:27 2008 +0000
memory leak fixes in libglusterfsclient
commit d680623160494c2116f3db00cd0ed54ba14773ab
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Apr 19 09:44:43 2008 +0000
fix in posix_getxattr to construct real_path correctly
commit 34e03ab5231863120965f32d6daf5a494a6be0bf
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Apr 19 09:31:51 2008 +0000
fix unify_lookup_cbk to return xattr dictionary from storage node
commit bb2cf3f979b4dbf92d3de5502516ad357c9a4b65
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Apr 19 06:06:02 2008 +0000
prune table at the end of inode_unref
commit a9eae5a07ecdecdbd4b4f12ed4ab53aaf48895c2
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Apr 19 06:03:03 2008 +0000
added feature in lookup to return content in xattr if size < need_xattr
commit 2cfbd2799e7c2d2fd58f45bcd7664ad6a905a764
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Apr 19 06:00:48 2008 +0000
fix in configure.ac to pick proper path for apxs
commit afe5575bb7f7b718305afcd6d92f7140ba2b57ab
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Apr 18 22:30:55 2008 +0000
Build fixes. Even 'rpmbuild -ta <tarball>' works now.
Patches applied:
* gluster@sv.gnu.org/glusterfs--mainline--2.5--patch-739
- Removed Python from build.
* gluster@sv.gnu.org/glusterfs--mainline--2.5--patch-740
- RPM Spec file patch from Harsha.
* gluster@sv.gnu.org/glusterfs--mainline--2.5--patch-742
- Porting Fixes
commit d69f49a5b9c089314365df3d635b4c5f95866880
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Apr 18 16:54:56 2008 +0000
pruning in inode table
Patches applied:
* avati@zresearch.com/glusterfs--dirent--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-24
* avati@zresearch.com/glusterfs--dirent--1.0--patch-1
* avati@zresearch.com/glusterfs--dirent--1.0--patch-2
added parent in loc_t, changes in fuse-bridge for the same and bugfixes in inode.c
commit 44e43f38d582a39d0a009504f55019d28eb3ab4b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Apr 18 16:49:56 2008 +0000
bug fixes to unify, posix and bdb getxattr/setxattr
commit a42fe3536ccf7d1db4cf171f80444d0ab0ca853d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Apr 18 17:33:50 2008 +0000
Added glusterfs_lookup api
commit c490f1b30642558bf0e6ce443528999f2cf0459f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Apr 18 15:02:04 2008 +0000
memory leak fixes in libglusterfsclient
commit f026c59663e3c842d1ecd5198c7fccec72106465
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Apr 17 18:22:00 2008 +0000
* Fixed a conflict error in write-behind, due to which, "option flush-behind" was always 'off', hence not giving desired output for small file performances.
commit abfedb0ca97adcf389d6fd300db51027a14b802f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Apr 17 14:10:28 2008 +0000
Type of fd changed from int to long to accommodate the fact that libglusterfsclient returns a pointer as an fd.
commit ff0c8b7fb18b2e43c9977eba8f47a858af2f7eb2
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Apr 16 14:54:21 2008 +0000
adding declarations to libglusterfsclient.h which were supposed to be in it but not present
commit 773ffe4594350461838b6a6d95bf282b205a1992
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Apr 16 09:14:00 2008 +0000
making first and latest 0 incase it is -1, so that statptr[-1] is not accessed.
commit 3e3e12aaca8f488294b2aea7c6063bb6f464fedb
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Apr 16 08:33:49 2008 +0000
memory was referenced after STACK_UNWIND() use "cnt" counter to break out of the loop.
commit 1a62b9fa3895297588c7258e7ae2b0fdb0c186c5
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Apr 16 08:29:47 2008 +0000
Changes for not creating missing files and directories. This will be taken care by the selfheal during directory lookup when it detects version mismatch.
commit 8ae3159e237816fce8b6a9a3f18d38050d75d1a5
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Apr 15 15:51:15 2008 +0000
minor fixes
* removed the warning of unsed variables in client-protocol.c
* added io-threads translator to the example client vol spec file.
commit 6d1a6ee92ef9152a4e6fd1efccaa4f4cfe5537c1
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Apr 15 15:41:39 2008 +0000
* Added feature to fetch spec files from server based on IP addr extension. If this file doesn't exists, fetch will fall back to older method of common spec files.
commit 16dea1d92d86fa490e0eeb697cbd98ff1d033638
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Apr 15 15:34:21 2008 +0000
* fixes for other OS porting. Compiled over freebsd, Mac OS X
* need to compile over Open Solaris.
commit aca0ab79f664fcc970f3aad3f8adfb7a78f6acb5
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Apr 15 11:26:34 2008 +0000
lock read ahead conf while adding new ra_file_t in ra_open_cbk and ra_create_cbk - caused random memory corruption
Reviewed by: krishna
commit a73706d51aa59e2ad8e063863a7c5de058d5a3d9
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Apr 11 18:26:59 2008 +0000
* patch for 'glusterfs.spec.in' (RPM spec file) from Harshavardhana (harsha@zresearch.com)
commit 5b56748ef9a0ffedb39807dda584b4a7416e1f1b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Apr 11 07:32:32 2008 +0000
getxattr/setxattr changes to bdb, posix, unify
Patches applied:
* gowda@zresearch.com/glusterfs--xattr--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-11
* gowda@zresearch.com/glusterfs--xattr--1.0--patch-1
get/set xattr refinements
* gowda@zresearch.com/glusterfs--xattr--1.0--patch-2
* gowda@zresearch.com/glusterfs--xattr--1.0--patch-3
* gowda@zresearch.com/glusterfs--xattr--1.0--patch-4
bug fix to client/server protocol. unify and posix getxattr/setxattr changes.
commit 0c67ddca30d652adb6873f7b063385ea87e7eac9
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Apr 10 21:02:28 2008 +0000
* removed bindings/python from the build, as more work needs to be done in that. It will be part of archive, but not part of releases for 1.3.x anymore.
commit 9defc839e235eb13bccc79567680bd4689f23402
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Apr 10 11:48:45 2008 +0000
off-by-one error in posix-locks fixed
posix-locks.c: off-by-one error in subtract_locks
Reviewed by: avati
commit f93dacdc37c9b9b17d2cea25cc0ad3d30928e724
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Apr 10 10:33:38 2008 +0000
fixes insert_and_merge infinite loop bug reported by Andrea Barisani
posix-locks.c: off-by-one error in subtract_locks fixed
Reviewed by: avati
commit 5da7c47214aab365f03e32292bdccdfde9839cb6
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Apr 9 07:35:59 2008 +0000
log level of disconnection messages changed to DEBUG
commit 7cfb84c906b3dd00cfcc1b88cdd39b198b406afe
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Apr 9 07:32:30 2008 +0000
libglusterfsclient - add init function
commit 310c4d3542c8a0085ea6c00e809ae94d87d7545b
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Apr 8 12:10:05 2008 +0000
fixed fd leak in booster ldpreload client
Reviewed by: vikas
commit 2d1af63cce60f5ea51f1a516fa0598d54059686e
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Apr 6 03:06:22 2008 +0000
* Removed bdb from configure.ac and Makefile.
NOTE: The BDB translator will be supported only in 'glusterfs--mainline--3.0' branch. And this branch will be freezed for any new features/translators, but will continue to get bug fixes.
commit 1ad4f738fb30346f0fc2e0ad76e6f50ddd4fbef8
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Apr 6 03:00:35 2008 +0000
* memleak fix in stripe_readv_cbk().
* change in stripe_setxattr () for enabling init() time check from above layers.
commit 54712fc39c84c766046b60fe500aba0b59012fca
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Apr 5 05:54:35 2008 +0000
renamed mod-glusterfs to mod_glusterfs and apache-1.3.9 to apache-1.3
commit de6a6fd4a85be2444427e2a0884434c94ac5a45b
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Apr 4 10:40:24 2008 +0000
Serving of directory indexes works fine even with directories on glusterfs mount
commit dda0c7591bf6d94a0e4f7dd2731cb858a43706c2
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Apr 3 19:01:28 2008 +0000
* small fix in unify for not returning ESTALE based on inode generation numbers when 'option self-heal off' is given.
commit 805e6a07839219f786b3fbd3bf6f86281e713773
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Apr 3 18:57:49 2008 +0000
* Fix for the Segfault which is seen when glusterfs is built with no fuse module. But glusterfs command is given with a mountpoint.
commit 0235e5c35e2c7e813994161a416df3b815e125ee
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Apr 3 18:00:16 2008 +0000
* fix in schedulers to error out when the value of min-free-disk is more than 100% :O
commit c177c70e36fc3f89ff17111d9010f21afb4e827f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Apr 3 11:31:47 2008 +0000
Changed Makefile.ams so that the dependencies are built first if they are not present.
commit 648969692c6e5ad40eafb0f184a3fc525e31c25e
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Apr 3 08:27:35 2008 +0000
removed debug functions added to mod_glusterfs
commit 978ef26cba14bcdb093ba10f3a10c0f6b4451ccd
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Apr 3 08:14:00 2008 +0000
Documentation related to auth
commit 52a8a4dfd165f10f13ae052c7db0e99e4ef16647
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Apr 2 16:47:08 2008 +0000
* Added man page
* transport/ib-verbs: changed the logging priority in ib-verbs-disconnect().
commit 2a4a0675f738c68a93f675a63fb9bc50db4cab7b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Apr 2 15:37:47 2008 +0000
merging glusterfs--bdb--1.0
Patches applied:
* gowda@zresearch.com/glusterfs--bdb--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-3
* gowda@zresearch.com/glusterfs--bdb--1.0--patch-1
first commit
* gowda@zresearch.com/glusterfs--bdb--1.0--patch-2
cleaned by wrapping up all dict_get/dict_set operations
* gowda@zresearch.com/glusterfs--bdb--1.0--patch-3
major changes to bdb
* gowda@zresearch.com/glusterfs--bdb--1.0--patch-4
further cleaning and updates to bdb.
commit 409f182ea529dad53898918f651a2217052b5353
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Apr 2 10:58:46 2008 +0000
* authentication of client port in auth/ip
* copy options dict to request dict in client before sending SETVOLUME to server
commit 484a3f5971b821478b98417a7d2ad10236e8dc10
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Apr 1 17:04:43 2008 +0000
* Logging improvements.
commit 5db2cc3ddee100ba9d69938d3afcde6dce6c1513
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Apr 1 13:44:05 2008 +0000
merging raghavendra@zresearch.com/glusterfs--mod-glusterfs--1.0
- implemented libglusterfsclient
- implemented mod_glusterfs for apache-1.3.9
reviewed by: avati
Patches applied:
* raghavendra@zresearch.com/glusterfs--mod-glusterfs--1.0--base-0
tag of gluster@sv.gnu.org/glusterfs--mainline--3.0--patch-6
* raghavendra@zresearch.com/glusterfs--mod-glusterfs--1.0--patch-1
libglusterfsclient import
* raghavendra@zresearch.com/glusterfs--mod-glusterfs--1.0--patch-2
added --(enable/disable)-libglusterfsclient option to configure script
* raghavendra@zresearch.com/glusterfs--mod-glusterfs--1.0--patch-3
* glusterfs module for apache-1.3.9
* libglusterfsclient - use /dev/stderr as default logfile
* raghavendra@zresearch.com/glusterfs--mod-glusterfs--1.0--patch-4
added check for libglusterfsclient while building mod_glusterfs
* raghavendra@zresearch.com/glusterfs--mod-glusterfs--1.0--patch-5
merge from glusterfs--mainline--3.0--patch-7
commit f922da6ace24e353d893664940d95ad394828156
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Apr 1 13:32:04 2008 +0000
added support in transport clients to fall back to default ports if it cannot bind to ports < 1024
reviewd by: avati
commit c2975642911c3d42d54e931272244447774e059e
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Mar 29 20:30:07 2008 +0000
* a fix in checksum_cbk, which had a typo bug which used to STACK_UNWIND with INVAL for the proper result
commit e36b8e1e8f8fb8de69f7a9c1baf9e391be39ec92
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Mar 28 14:51:43 2008 +0000
ref/unref io buffers during afr sync file (self heal)
reviewed by: krishna
commit 9c635851e37af7916ed33995402012bc7f5d4c77
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Mar 28 11:55:02 2008 +0000
fixed logging bug in unify_create_cbk
commit 3979878865034a02604e56903581145a64b8d57a
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Mar 28 11:43:36 2008 +0000
fix in afr_writev to handle refs
commit 1354bd1120184200a0bef9baf929ec57f9479111
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Mar 28 09:03:43 2008 +0000
added mutexes around namespace locks
reviewed by: bulde
commit 760bf78d464dbf7ca8ca467c1fc0729bf17a5620
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Mar 27 06:45:21 2008 +0000
* unify returns ENODATA instead of EIO for getxattr call if file is present only in namespace.
* stripe: minor correction in logging.
* afr_writev_cbk: small fix.
commit b9135c32a443f3a252690bd3eb56a77204fd472d
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Mar 26 19:12:49 2008 +0000
Fixed infinite loop bug in lk() code of afr and also a bug in unify:unif_opendir_cbk which was accessing *cookie as prev_frame while cookie was the xlator ptr as STACK_WIND_COOKIE call was being used to make stack wind.
commit e511e7221923aa7224c81e928b397483ea094fd6
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Mar 26 07:05:20 2008 +0000
revision.h update
commit 85eb156b53a86eeff7d2178e26488719b73067d8
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Mar 26 03:38:34 2008 +0000
* error checks and logging added in client protocol.
* set 'type' and 'op' fields in server protocol too.
* removed log in posix_setxattr() when errno is ENOENT (FileNotFound).
* added more check and logging in libglusterfs/src/lock.c
commit 1dc4805b80a9aefcd78e507961ebb1a08a6a02a2
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Mar 25 08:32:13 2008 +0000
Correcting a race condition in afr selfheal. main selfheal function was looping on asp->entries while it was being modified in the lookup cbk.
commit 9c6a1349001a3cb3978eb70ff440868aad2d8cdf
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Mar 25 05:40:53 2008 +0000
* Fixes a bug (which causes segfaults of afr or stripe volumes) which was introduced by me in patch 714 (handling extended attribute support).
commit 86df9b0ce4846b9707e3644ad5fa5b6bfc7efb6f
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Mar 24 20:08:59 2008 +0000
* more logging added.
commit 7b2a19e1b1cd0bfa62cdcd47f646bbdeb248859a
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Mar 24 19:57:50 2008 +0000
* more logging added.
commit 7f1f8120b8c3d5de160734619c62ece6e28918d1
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Mar 24 07:19:01 2008 +0000
* cluster/afr:
cluster/stripe:
- Added msgs when the subvolume is not supporting Extended Attribute suport of exported filesystem.
commit 940eefb5d398637b9487bded76f8d68dfdbe82df
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Mar 24 07:06:04 2008 +0000
* scheduler/alu.c:
- Removed a exit(1), and made it return -1;
* libglusterfs/*:
xlators/protocol/*:
xlators/storage/posix.c:
- Added more argument checking and logging in case of failures.
commit 5860e10755772bc0e6bbcacce2585962bfb9f42c
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Mar 20 22:32:26 2008 +0000
Directory selfheal, now this is not done in one shot wrt getdents/setents. It is done in batches, hence scales well.
commit 5cfe765f5d0e2d0194444e25dd2ed1a2b361c042
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Mar 20 21:14:44 2008 +0000
* fixes in argp_parse, to get the proper options in case long option not given. Tested over MAC OS X. works. (over GNU/Linux, if it has argp.h, its not required). some testing on Open Solaris and FreeBSD is required.
* Fixes in MAC_OS_X part of posix_readdir().
-- with this patchset, tested over MAC OS X for iozone, dbench, and bonnie++ (with '-n 0'). Bonnie++ fails when -n 1 or other option (other than 0) is given. Still investigating. No problems seen with any i/o operatins.
commit 56e48a7000e0ec445029000634b9168f6430d12c
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Mar 19 00:57:00 2008 +0000
* small check added in fuse-bridge, so the '/' path is handled.
commit b9dde11e462ec933eb1a8d720fb335508a0480a9
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Mar 18 19:31:34 2008 +0000
inode revalidation failure does not cause dentry unlink
commit 0a13432b1dc4f076dbe1d18fb467646440886cd7
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Mar 18 17:34:08 2008 +0000
* transport/ib-verbs.c: reverted back a small logging change. It caused the hang effect while using ib-verbs transport.
* xlators/cluster/unify.c: added extensive logging. That is all the places where error is returned, Unify logs it.
* {*.c,*.h}: changed _STACK_WIND() to STACK_WIND_COOKIE()
commit 672b4126fb91edbcf2a92fcc57991ca238d077e5
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Mar 18 17:28:12 2008 +0000
fuse_thread_proc - break out on errno = ENODEV (compatibility with fuse 2.6.x)
commit 8f84d5e54fb8ccfcd320eb60d427f6c97e628b19
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Mar 15 18:18:08 2008 +0000
* glusterfs/src/glusterfs.c: Minor changes to handle relative path for mountpoint.
* fuse-bridge.c, configure.ac, compat.h: Darwin (MAC OS X) porting related changes.
- configure.ac: removed 'ib-sdp' from transport list
- compat.h: #define'd 'sighandler_t' to 'sig_t'
- fuse_bridge.c: sending "-o noexec" as macfuse mount_fusefs option.
removed check for ENOEMPTY in unlink_cbk()'s gf_log.
commit 22b25de26d02aa38078c7c885a455171f7d661c9
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Mar 14 00:24:56 2008 +0000
* xlators/cluster/unify: Added a warning message when unify has only one subvolume
* xlators/protocol/server: Fixed issues with missing handshake message in case of handshake failure.
* libglusterfs/{glusterfs.h,common_utils.c}, glusterfs/src/glusterfs.c:
- Added dumping spec file for SIGUSR2 and SIGSEGV signal
* INSTALL: minor update.
commit e6966ee1e1e4eed108b2c15b0ccf16520d937ffd
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Mar 12 06:51:18 2008 +0000
* storage/posix.c: added extra "option export-statfs-size no" which
can solve the wrong 'df' output issue when the same disk
partition exported two times.
* scheduler/nufa: Added feature to support multiple "local-volume-name"s
to nufa scheduler.
Also changed the default minimum size from 5% to 15%.
* updated doc/translator-option.txt with new options added.
* cluster/stripe, transport/ib-verbs: minor changes
-> cluster/stripe: initializing op_errno to ENOTCONN in statfs().
-> transport/ib-verbs: log added even when ibv_poll_cq returns 0.
* scheduler/switch: Added a TODO
"option switch.nufa.local-volume-name <volume>"
commit c4b8b0625e96bce37013651c7a2c861974faac1d
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Mar 11 17:11:07 2008 +0000
Added Berkeley-DB version check in configure.ac
* configure checks for Berkeley-DB version and disables storage/bdb if version < 4.6.21
commit 56c3164a2b91a6aa6b4219c683b14a860ca170a2
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Mar 11 11:34:44 2008 +0000
build scripts fixed to disable building fuse with --disable-fuse-client
* changed 'FUSE_CLIENT_SUBDIR=glusterfs-fuse' to 'FUSE_CLIENT_SUBDIR=fuse'
* changed 'SUBDIRS = fuse' to 'SUBDIRS = @FUSE_CLIENT_SUBDIR@' in xlator/mount/Makefile.am
commit fdb04b259190319cb4b465d775f13954827022c2
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Mar 11 05:30:06 2008 +0000
minor bdb changes
* removed all depencies on (loc_t *)->parent in bdb.
commit e4003f73453c355bff2a17fcb092b5345c21d4ba
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Mar 11 04:49:43 2008 +0000
fuse-bridge changes reverted.
* changes to fuse bridge are reverted.
- now fuse_loc_fill() takes only doesn't take 'ino_t par'.
commit bad92b3dccca9b8a5a610ec9cb2df6a36a614ac1
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Mar 10 21:03:05 2008 +0000
* bdb feature upgrades. * minor changes to inode.c. * addition of new member to loc_t. * added review comments to afr. * minor changes to fuse-bridge.
* bdb feature upgrades
- bdb now supports multiple directories with all directory related fop support, except for rmdir.
- bdb supports open, read, write, close on regular files. read and write also support seek on regular files.
- unlink, link, symlink, readlink are not supported. unlink support will be added soon.
* minor changes to inode.c
- inode_parent() call returns parent inode of a given inode_t, even when ino_t of parent is unknown. inode_parent() procedure arbitrarily choses a parent inode from dir-cache and returns the parent inode_t pointer to caller.
* addition of new member to loc_t
- loc_t now also has 'inode_t *parent' member to accomodate for parent inode pointer.
* minor changes to fuse-bridge
- fuse_loc_fill() procedure takes an extra parameter 'ino_t par', parent inode number.
- all calls to fuse_loc_fill() are now changed to explicitly specify parent inode number. earlier practice was to identify the single ino_t parameter as parent inode number, when 'name' of the entry was specified.
commit d7340953d60f06a3e04acbcc775fafbf3eb24daa
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Mar 10 19:57:53 2008 +0000
selfheal code is not executed if none of child_errno[] is 0.
commit d49901a92b41a12c39c18e90241b5d1ed95c9115
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Mar 7 17:40:34 2008 +0000
* Closing Bug #22503. (missing --pidfile)
* Enhancing backtrace to print missing frames and command line arguments in log file.
* Also added a signal handler to SIGUSR2 to print TLA version, command line arguments, missing frames.
commit c330f9094df83ed62fb0843c6fe136529c9aa71f
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Mar 5 15:43:56 2008 +0000
* enables switch scheduler to send multiple patterns to one volume.
commit 12623d359a5c5a9684abb1781efd8584f19a6f94
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Mar 5 10:17:40 2008 +0000
fixed bug #22484. Return EAGAIN when lock cannot be set
Thanks to Li Daobing for spotting this.
commit a85e1c892c75a3d42b7e2a108614ac90e4e4abec
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Mar 5 03:12:33 2008 +0000
* fixed issues seen in MAC OS X ('df', 'vim', 'emacs' not working)
commit 8008811f8f2ade04ce5dc9a5862896b57a1051c6
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Mar 4 13:56:02 2008 +0000
minor fix in posix-locks
Changed the check
op_ret == 0
to
op_ret >= 0
in pl_open_cbk in posix-locks.c
Thanks to LI Daobing for reporting this.
commit 018d9445e5b6ec5d308b5876a3c61c9eebd3ae7b
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Mar 4 04:41:27 2008 +0000
Use higher-order bits for random number in rr
From rand(3):
``However, on older rand() implementations, and on current
implementations on different systems, the lower-order bits are
much less random than the higher- order bits.''
``If you want to generate a random integer between 1 and 10, you
should always do it by using high-order bits, as in
j = 1 + (int) (10.0 * (rand() / (RAND_MAX + 1.0)));
and never by anything resembling
j = 1 + (rand() % 10);''
commit a96f0d84d3a1f325d0ebff85c34571ed739a753b
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Feb 29 06:36:32 2008 +0000
* disabling direct_io mode in case of MAC OS X by default.
* removed warnings in unify,posix,client-protocol.
* added header files in glusterfs-guts/Makefile.am
commit bd56a034eeca36ba816f037fbf9ca7e189161e55
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Feb 28 08:31:47 2008 +0000
added porting.txt
commit 612249e3eec93d8ffb866ae0bce20a7912c16185
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Feb 27 15:48:29 2008 +0000
* fixes for MAC OS X compilation.
* generation number fix in fuse-bridge.c to handle ESTALE in MacFUSE.
commit ee03337406166b874f6ba68a7bed2dbea333b576
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 26 16:42:53 2008 +0000
fixed copyright in mount.glusterfs.in
commit 403a8374e1af191504d96fead0b0726293542d89
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Feb 26 15:23:49 2008 +0000
* cluster/afr: a fix in rename() to return the same inode number in stbuf.
* storage/posix: added O_DIRECT option handling in writev(). It was already added to readv().
commit cd747d2c2d148ca6046b0eab3b25b256cd046d36
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 26 14:19:18 2008 +0000
fuse xlator, single glusterfs/fsd binary
merge from glusterfs--fuse-xlator--1.0
commit 5b19a3cb3aee0ec9bf2529da6fdc98fc0d6dfc8d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Feb 26 14:32:53 2008 +0000
fixed compiler warnings in afr resulted from my previous commit
commit 5d4d87a230da7cdf0a40d5a97f243520783fb30e
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Feb 26 10:52:50 2008 +0000
Defined constants for POSIX lock types
glusterfs.h: define constants for F_RDLCK, etc.
server-protocol.c, client-protocol.c: change _lk calls to use the above
constants, and avoid passing system-dependant numbers on the network.
commit ff5cefa505b950c74a1b519f1da3f3617f50829c
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Feb 26 10:58:27 2008 +0000
* fixed deadlock caused in a setup with afr on top of afr (second afr is mirrored namespace of unify). Bug was due to both afrs trying to heal the same file.
commit a95d64d04b2af49c9af35ab5f20845c4a1f693ad
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Feb 26 05:48:26 2008 +0000
Forgot to append path with a trailing '/' in mop_unlock_impl in patch-679
commit d9fcb799a90f5e346835ca2f23c2eb7d4ab108ce
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Feb 25 23:52:32 2008 +0000
* added '--disable-bdb' option to configure.
commit 3b4430a8dfefdb02aabf2228d6f177716e0bce6a
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Feb 25 12:26:53 2008 +0000
Mac OS X fixes
posix.c: Use d_seekoff on Mac OS X.
libglusterfs/src/authenticate.c: Made nested functions un-nested.
commit d24a526c67ffc11c6ac17055c234d1abbe8839e9
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Feb 25 11:17:03 2008 +0000
* comment out frame->root->trans = NULL in server_protocol_cleanup, since mop_unlock_impl needs ptr to transport for clearing locks held by it
* Add a trailing / to pathnames, so that locking mechanism works for files also.
commit 214b00ac94dbbc0de20bc2d31e22cd2dd712ade3
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Feb 21 22:26:54 2008 +0000
glusterfs-guts version-0.0.0.009 committed for first time.
* glusterfs-guts is a unit testing suite for glusterfs. glusterfs-guts can be run in two modes:
1. trace mode - in this mode guts mounts glusterfs to a mount-point provided as command line argument. user can perform usual filesystem operations on the mount-point. difference from the normal glusterfs mount will be that guts logs each of the fop onto the tio (read trace-input-output) file, whose path should be specified on command-line while starting guts.
command-line for starting guts in trace mode:
glusterfs-guts -f <spec-file> -T <mount-point> -o <tio-file-path>
2. replay mode - in this mode guts replays the filesystem operations onto unmounted glusterfs tree, by reading from the tio file specified on command-line.
command-line for starting a single-threaded guts in replay mode:
glusterfs-guts -f <spec-file> -t 1 -i <tio-file-path>
* glusterfs-guts is not tested as of now. please do not use glusterfs-guts, unless you are testing glusterfs-guts itself. :O
commit 8c5f9f6c1f13d4e139d60ec22bde42ba1150cb04
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Feb 19 18:42:16 2008 +0000
* Added 'strorage/bdb' translator. === Not usable yet ===
commit 0c6a0145c6c06e493a24cd7825d9c56ab3d281c6
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 19 16:16:24 2008 +0000
notify event fixes in ib_verbs_tcp_notify
commit 226f72574dea4079d2160ceec348f9b51120081d
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 19 15:43:57 2008 +0000
forward the right event from ib_verbs_tcp_notify to xlator
commit 60d2a9d6409f401b4772cdb19f8d54ecaed33b75
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Feb 19 07:34:55 2008 +0000
* extras/glusterfs-mode.el :
Now more options are highlighted.
Supports indentation.
* protocol/client, protocol/server, libglusterfs/authenticate.c:
Change in log level of few log messages.
commit 8520f63b750fd7bd7bac970377c257f1eebaa9c9
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Feb 19 05:10:40 2008 +0000
fixed build error introduced in my last commit
commit 83d055332430899ec37662b560f80c19c3b7f7e5
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Feb 18 12:27:25 2008 +0000
Introducing reference counting of transports. A notification is sent and transport is destroyed when the refernce count reaches 0.
commit 1ecdd5709de052fd14d58040afe4638d8d5deb0a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Feb 18 11:02:00 2008 +0000
Fixed memory corruption due to writing beyond allocated memory in posix_readdir.
commit cb3e4c033f2efc7c680a57e186042f25af2b3998
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Feb 18 03:12:10 2008 +0000
reverted d_off changes
commit 3ebf1207677d88da5691f5806988c426064149ba
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Feb 18 02:46:22 2008 +0000
typo in posix-locks (endf)
commit 65636b8e60338c491b5bc7e8827a146fadc30799
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Feb 17 07:38:24 2008 +0000
define LLONG_MAX for old gcc
commit 96e0b01af1a5fdd63f3d38609b69b95291590aed
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Feb 16 19:09:36 2008 +0000
Ported GlusterFS to Mac OS X
configure.ac:
libtool is glibtool
various Mac OS X specific variables
libglusterfs: CFLAGS='-fnested-functions'
common-utils.h: use mutexes if spinlocks not available.
xlators/*; scheduler/*; auth/*: CFLAGS changes
server-protocol.c, trace.c: converted nested functions to non-nested functions
compat.h: prototypes for extended attribute functions
fuse-bridge.c: option -o nonempty is not present on Mac OS X.
compat.h: fixed argp_parse_ to handle non-option arguments as well.
wrote function argp_help to print --help message.
commit bc0106f6877703bba4adb440433413feab86850c
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Feb 15 18:54:10 2008 +0000
changed ULONG_MAX to LLONG_MAX in posix-locks.c
From LI Daobing:
> if (flock->l_len == 0)
> lock->fl_end = ULONG_MAX;
> fl_end is "signed long long" type pretty much everywhere. The main bug
> here is that with 64bit systems ULONG_MAX gets converted to -1, and
> l_len=0 locks break completely.
> So, this should work better:
> lock->fl_end = LLONG_MAX;
Thanks to LI Daobing for this observation.
commit 93ce501682e06907dc9eb096179a1a650e57ca83
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Feb 15 06:50:32 2008 +0000
stat on proper path in checksum
commit 959d8ac286ebaad6e0718080c19fceefcb40568f
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Feb 15 06:54:37 2008 +0000
* debug/trace: added mops->checksum call to the trace list
* cluster/unify: handled a case where return value of getdents is -1.
commit 1415dbdcde052dc087cd30d05b625eadf7ad24c8
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 12 16:41:57 2008 +0000
include build time with date in --version output
commit 001e519c4a4631bcb33ffa6add4c06175854a945
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Feb 12 12:36:56 2008 +0000
* gf_print_bracktrace(): enhanced the function to print the revision id.
* misc:
- client-protocol.c : removed warning 'gf_cmd uninitialised'
- compat.c : changed order of definition of header files. (<dirent.h> before "compat.h")
- translator-options.txt : updated with current options
commit 2a192c9e65bf9cbb193f31ef48f2e8bf53545d8d
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 12 12:12:43 2008 +0000
updated glusterfs.spec (rpm build) from Matt Paine
commit 1ebf960ccbecd5f3cfb137547f8142bd631847a9
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 12 10:23:42 2008 +0000
tla add'ed commit.sh :)
commit bd77d56cf5ffc5c7e1d71b11c38dcba71a222e24
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 12 10:15:23 2008 +0000
moved revision.h to libglusterfs/src/revision.h
commit 626a90ae34400447702fc52f88ada57899c6fcc7
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 12 10:04:44 2008 +0000
added repository revision to --version output. all developers should run ./commit.sh instead of 'tla commit'.
commit c938a07fe8fe797ac7921114c3a80fe99e79bdaf
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 12 07:48:00 2008 +0000
updated copyright to 2008, updated configure script to not fail, but print configure summary at the end
commit 13bfa4df5a3f16947b9cbbd546031e9c4525dec6
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Feb 11 13:35:58 2008 +0000
* libglusterfs/src/compat.{h,c}:
- added dirfd patch by Harshavardhana R <harsha@zresearch.com>
- corrected the return value of setxattr wrapper function.
* xlators/cluster/unify:
- unify rename rewrite.
commit 6e51522c26b1096123859405859333a544ce16e3
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Feb 11 14:37:53 2008 +0000
changed the dates in the copyright headers of previous commit to 2007, 2008 instead of 2008
commit 324cb491b3c6f7f29fa064a1487bae5f27c4bb7f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Feb 11 14:25:29 2008 +0000
Added copyright headers
commit 8b73586f6aa346feed934e5d8909a4e4c46ddde5
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Feb 9 21:59:12 2008 +0000
* libglusterfs/src/spec.y:
Proper handling of errors in spec file.
* libglusterfs/src/scheduler.c:
Initialization errors while loading scheduler was causing 'exit(1)' changed it to 'return NULL', hence, proper umount happens in case of errors.
* xlators/cluster/afr.c:
Minor changes in output of init()'s error log messages.
* xlators/protocol/server-protocol.c:
Added code to keep generation number, and st_mode of the newly created inode, incase of lookup_cbk. This avoids lots of ESTALE errors, which are seen if unify is loaded on server side.
* xlators/cluster/unify.c:
Review for missing frames. And removed unnecessary if statements, and complex nestings.
commit dd3792b700a3a5897c224a7f66490a4c57dfc65e
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Feb 8 12:17:53 2008 +0000
removed static modifier for fops in translators
commit 450ce1991c916af73d9f73bbb759d7ee6fa288f3
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Feb 8 10:41:43 2008 +0000
make window-size optional on tcp/client too
commit 49b7cbf0ff9e07fa7300999393827f027f9c45bf
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Feb 7 13:12:34 2008 +0000
dict.c: make _copy a standalone static function
transport/tcp: make window size setting optional
unify: getxattr return -1/EIO when files not reachable other than NS
commit 19ccd616c1a162854dc8244a8f3f7b3dc091e33f
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Feb 7 11:47:07 2008 +0000
* Fixes in unify/self-heal:
- issues of missing frame in lookup, and missing closedir() call to NS node is fixed.
* Unify:
- fixed a issue with lookup, when it was returning ENOENT if the file is in only NS.
commit 9a05dbc3920c1d2e46cbce21f4487d2b7099adae
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Feb 5 18:05:05 2008 +0000
* xlators/cluster/unify:
-> unify.c:
Fixes in all the places where 'need_break' logic was not appropriate. Thanks to 'Du', ie, Raghavendra G <raghavendra@zresearch.com>
-> unify-self-heal.c:
Fixed the hanging frame issue, in case of unify self-heal.
There was a corner case issue where, frame used to get destroyed because of wrong calculation of call_count. Fixed.
commit 9e98d11959a71f85fa763fff60ece7444bd167c5
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Feb 4 12:58:09 2008 +0000
* cluster/afr:
- undid the change done in previous commit (memset 0, instead of ENOTCONN in create()
* protocol/server:
- Bug : When AFR is on server side, ENOTCONN was not handled properly. Also seen missing unlink() calls in the same scenario.
Fix : (ref: patch-640) Code similar to the one added in fuse-bridge.c:fuse_create(), is added in server_create().
* cluster/unify:
- Bug : Missing chmod/chown/utimes/truncate calls
- Fix : (ref: patch-640) While changing from background frames to the current frame, missing frame case was not handled. Added STACK_UNWIND() in place of commented STACK_DESTROY.
commit 175ba25654293901c992ede67ddb58b9a3f60987
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Feb 1 10:28:45 2008 +0000
* libglusterfs/src/logging*:
xlators/debug/trace :
- Added another log level 'GF_LOG_NORMAL' which is used by only trace translator right now. So, all DEBUG logs doesn't showup when someone enables trace translator.
* xlators/cluster/afr:
- One small fix in afr_create_cbk(), setting child_errno to 0, instead of ENOTCONN.
commit 266ded1b096630831b06f8ce48a6a3933bf7fd88
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jan 31 18:24:55 2008 +0000
* cluster/afr: Made 'fd->ctx' to 'local->fd->ctx' in afr_selfheal_open_cbk().
* cluster/unify: 'Bug #22187'
Fix: Unify sends 'stat' and 'fstat' instead of truncate and ftruncate to NS brick. This will fix the issue of file sizes more than 0byte in Namespace brick.
* cluster/unify-self-heal: Changed the #define'd macro name.
commit d31b1b13ba1e803c7557a42e7f341fc0f4c3c2e9
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jan 30 11:14:50 2008 +0000
* debug/trace:
- implemented readdir ().
* storage/posix:
- Fixed BugID # 22175 (Savannah)
Now, posix translator fails to initialize if the specified directory doesn't exists, with an error message in the log file.
commit bacb0acb391af045f49b04317edf698f7865b328
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Jan 26 05:17:18 2008 +0000
missed commenting out stack destroy of background frames in ns_chmod_cbk, ns_chown_cbk, ns_utimens_cbk (ref: patch-640)
commit 69d554f09b65bb475bce11bb6edd75c02db52b2f
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jan 25 22:56:23 2008 +0000
CRITICAL BUG FIX IN UNIFY_SELF_HEAL
* Bug #21884 : fix typo in log -- patch applied
* storage/posix:
readdir(): if offset is not zero, do a seekdir() to get the proper offset. Fixes a bug of hanging of 'ls' due to 100% cpu usage in case of NFS re-export.
getdents(): There was a bug in the case when GF_GET_DIR_ONLY flag is set. the condition to check whether the direntry is directory or file was never satisfied, hence even when that flag is set, all the content in the directory used to be returned, causing unify self heal to fail.
fix: get the stat of the proper path (absolute path) to decide if its directory or not.
* cluster/unify/src/unify-self-heal.c:
libglusterfs/src/glusterfs.h:
-> added another extra flag to setdents fop. GF_SET_DIR_ONLY, if set only mkdir() is done in posix level, even if there are other entries.
------------
This patch fixes the critical bug of creating 0 bytes files in the glusterfs backend, which makes glusterfs to fail by returning ESTALE/EIO for further operation on the file.
This behavior is seen only if the NS is built freshly from the patches above 636.
commit 3176ddf99f701412bd799cc730afd598c2a13e39
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jan 24 08:26:38 2008 +0000
* write-behind: disable write-behind for 1st 1MB of file writes (small size perf workaround)
* transport/tcp: set window size to 640KByte
* stroage/posix: do not depend on dentry->d_type
commit 78e0a8f200a85b21fc5efd24eaef6c596bc2cd96
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jan 24 09:11:42 2008 +0000
Bug-2:
description: segfault in chmod, chown of unify children.
configuration: same as that of Bug-1.
cause: Unify used to STACK_UNWIND even before the fop is sent to its children. But, the inode ptr held in loc structers was not inode_refed, causing it to be freed in fuse.
fix: Unwind at the end of the call.
Keywords:
commit f106026b8722bc0016a152bab240b23bac0d51ca
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Jan 21 13:44:00 2008 +0000
added some defensive programming for posix locks
There are two versions of constants, F_*LK and F_*LK64. On 32-bit
systems they are equal, on 64-bit systems they are not. Or something.
The whole thing is a mess. To deal with it, we have two defensive pieces
of code:
client-protocol.c:
server-protocol.c:
a) Instead of blindly passing the values across the network, we
convert them to GF_LK_* in client-protocol.c.
E.g., F_GETLK/F_GETLK64 --> GF_LK_GETLK
We convert them back in server-protocol.c
posix-locks.c:
b) In case a F_GETLK64 sneaks through to posix-locks, we handle it
there too.
glusterfs.h:
Added a new enum for GF_LK_*.
This fixes Samba re-export issue.
commit 9cffebe08b584c2a268e0becf350f98decbb6d7d
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Jan 21 11:19:50 2008 +0000
reversed previous fix
commit af75a337ccef1c6369a86cb77c8690a9185b98d4
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Jan 19 12:23:54 2008 +0000
handle F_*64 in pl_lk
Samba re-exporting a GlusterFS mount encounters locking problems. They
seem to be due to it using F_GETLK64, etc. This patch treats F_GETLK64
as F_GETLK.
commit c602bf51c8091342f58d31fcf60f97449c44efa2
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jan 14 08:17:33 2008 +0000
* Corrected unify's stat return scheme:
- Reviews from LI Daobing <lidaobing@gmail> is considered.
[ From the mail "unify's return 'struct stat' scheme" in Mailing-list]
commit 668d0f04f59dddb02cda2d0ad14ccdbb5fab8d57
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jan 14 07:07:29 2008 +0000
Bug fix in unify-self-heal
* Bug Description: Segfault in setdents() when used unify/afr combination during self-healing process.
Cause: The 'entry' variable was NULL, and was de-referenced without check.
Fix: Not sending setdents call if there is nothing to fix. (ie, if entry is NULL)
commit 803c07829ea28ebcc361bc95c2bd69eebe0dca86
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jan 7 20:03:50 2008 +0000
stripe: support pattern matched block sizes, but not mixing with non-striped files
glusterfs.spec.in: fixes for including new path of glusterfs-booster.so
commit ead34a2760c98dadd072fe846471a0db302f8751
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jan 6 02:59:58 2008 +0000
typo in storage/posix
commit 296712c40b4ce56d9692138c97e946c4e735e3ed
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jan 5 06:54:37 2008 +0000
booster ldpreload library directory changed to $(libdir)/glusterfs
commit f94f2b50d693c6724766c5174e3d1c7ad5c80574
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jan 5 06:47:26 2008 +0000
reset read-ahead aggressiveness on writev()
support page-aligned reads on o_direct files in storage/posix
commit 735ef346c8aaf43492a40c7d98238cdc1dcdd8e3
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jan 4 04:10:03 2008 +0000
* Added another argument 'flag' to getdents() fop.
* Unify self-heal updated.
- No permission checks between namespace and storage nodes.
- No sorting/uniq operation @ client. Unification @ namespace node.
- All entries are written to namespace first, then only directories from NS is read, and written to all the storage nodes.
commit 951d5bd502ae6a7e5691d9ccea5bee14ff6747e5
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jan 2 08:57:04 2008 +0000
Noted that stat-prefetch is disabled in translator-option.txt
commit 09c3394216fea4d4a7ff1c28b32af7094cf5e6c9
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Dec 27 14:20:34 2007 +0000
undoing patch-623 since it does not fix the issue
commit 9085b04234ea933962d803eacad67060ba75c8d9
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 27 12:23:24 2007 +0000
* Now, cluster/stripe xlator doesn't support any pattern matching. It only takes block-size as option.
From now on, stripe will stripe all the files which gets created by it. Pattern based striping should be done through 'switch' scheduler.
commit e29a5bfab4c43175e006e7a4abd94863a2c3a52f
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 27 11:06:45 2007 +0000
* typo fix in log msgs of random and nufa schedulers.
* a fix in unify->init(), where there was a bug in calling the initialization of the namespace translator. Now, a flag (ns_xl->ready) is checked before its initialization.
commit f4a1687d244376d14d3ae12c2deb127f877cba24
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Dec 26 10:32:57 2007 +0000
* xlators/performance/booster/src/*.c: Updated code to work with ib-verbs transport.
commit 6f1f1f301658431e939cb51554eede8146157e3d
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Dec 20 19:53:47 2007 +0000
Summary: migrations, name change from readdir->getdents writedir->setdents getdents->readdir
commit de327d682fe353481f7c8fde34faab31ea2b91ef
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Dec 20 15:03:00 2007 +0000
bug: glusterfs segfault
configuration: client->read-ahead->write-behind
posix->server
steps to reproduce: kill glusterfsd when some write requests are still pending
cause: close call is not sent to server due to client_protocol_cleanup does dict_del (fd->ctx, this->name) before forced unwinding for frames causing close to complete even though write requests are pending
fix: cleanup saved_fds after forced unwinding of saved_frames
commit afb66eb8ec5e1d6933097a83f67094507614ce7b
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Dec 19 13:51:51 2007 +0000
Added checks for fuse_loc_fill returning NULL inode instead of a valid inode (eg., in fops like fuse_open, fuse_chown etc.,)
commit c3406e06c4e632980263c76a8c1cc2c113950b6e
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 19 02:14:53 2007 +0000
fix in booster
commit f596f63d1939de68d071b7214eb8661626c977e0
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 19 02:08:02 2007 +0000
* protocol/client: handle cases of not having a parent xlator
* write-behind: make fops non static to get listed in mini bt in the logs
* booster: cond waiters after recv/notify for ib-verbs
commit 76dcaf2ddbc26e72913abd6222fb7f4daf05417e
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Dec 18 19:13:59 2007 +0000
glusterfs exits gracefully when 'type' is not specified, instead of segfaulting.
* section_end() returns -1 on finding that 'type' is not specified for a xlator.
* grammer definition checks for return value from section_end() and aborts with YYABORT, if return value is -1.
* YYABORT is a yacc macro to abort parsing with yyparse() return 1.
commit b18a64cb6ca7ab85bb20528c7a13508ba8dd71a7
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Dec 18 12:19:10 2007 +0000
Fixed a bug in spec file parser
* Earlier versions of glusterfs used to segfault if 'type' was not specified for a translator.
* Now glusterfs exits with error 'translator tree cut' when 'type' is not specified for a translator.
commit af534cc46ffb75c784c88ca23854aa579b6e8395
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Dec 18 11:42:33 2007 +0000
* glusterfsd: break even if one volume initialization fails.
* client-protocol: fixed a issue with client_checksum(), where it used to segfault when inode was NULL
* unify: send close() to NS in the close_cbk() of child node. This fixes the problem of inode getting reused in fuse layer before close.
* stripe: send close() to first node in the call back of close sent to other nodes. Also fixed the issue of returning wrong op_errno in case of ENOTCONN
commit e513b4a1bd14abbc976f7e04dabfc48160a6b8cc
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Dec 16 21:20:06 2007 +0000
handle ESTALE on "/" correctly
fix segfault in protocol/server
commit 22c64e04d81e606762ad2693f4c768ba1ec39f5a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Dec 14 19:09:17 2007 +0000
Bug fix, when we recompare directory versions after locking we should have initialised local->op_ret = -1 before calling re-lookup.
commit 180c4c01189473d5c09a29cb5e6f4b43a7f69ab5
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 13 14:04:41 2007 +0000
fix in server_getxattr leak fix
commit 27c029c2f4ad74cfa36bed37bec244527cbcf4b9
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 13 12:12:01 2007 +0000
* server_protocol: leak fixes in mknod(), getxattr() and symlink()
* client_protocol: cleanup in init(). removed code to check inode-lru-limit option.
* scheduler/{rr,nufa}: removed strcmp() as it was redundant. should increase the create() rate.
* storage/posix: added missing NULL in STACK_UNWIND() in case of failure in getdents()
commit 3257c962402736f37bc13c71ad3aa92747005825
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 13 09:04:32 2007 +0000
support for accepting -n via fstab (glusterfs client), thanks to Matthias Saou
support for direct io mode by Michael Finchman
split readdir call into chunked getdents call
commit 9b2616cdf298720393a96d24e768df7f46b93cc1
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Dec 13 08:50:27 2007 +0000
AFR bug fix : unlock namespace if versions dont actually differ when we check it after locking the namespace.
commit acb9923b14506bdb4e5e53223326c0d6ff20aa66
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Dec 12 13:37:46 2007 +0000
following operations work serially instead of parallel-calls : mknod, mkdir, create, link, symlink, lk
commit 260dc841d41c3428ec80f56d8a2198d48e89020d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Dec 12 09:23:30 2007 +0000
Added --disable-epoll option to configure
commit f4cdd21e27e9f231b8a796158336984a2e3f5eda
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Dec 12 08:02:39 2007 +0000
backporting python bindings
commit 941ae4655ffe84bc9a569a038f773a184c3e907b
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Dec 11 11:52:08 2007 +0000
Rename afr_fop_incver to afr_incver; afr_incver to afr_incver_internal. Lock namespace when incrementing directory versions, also lock namespace in lookup when we access version info and compare them.
commit f0b174f5cabe04533e9a28bea8fd24fb2185889a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Dec 11 08:54:09 2007 +0000
Fixed segfault in auth, which used to happen when an authentication module (a .so) is not found or dlopen on that module is failed.
commit cc68e052e41955261e4e335b3ecfe869d73cdf81
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Dec 10 11:35:05 2007 +0000
* bug: segfault on systems with epoll.h but no sys_epoll_* system calls implemented
* fix: check for NULL epoll_ctx in sys_epoll_iteration and return ENOSYS accordingly.
commit 53a6886e887ad8f4ff7cbfd683a04eeab168fc0b
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 7 20:02:40 2007 +0000
fixed typo in protocol/server
commit 537fa86a8b4550b08e6ef4e6ead6cfef3da30eb9
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Dec 7 12:01:08 2007 +0000
version check between client and server
commit 33925f2cf67888ceb269477b004102bbc1a2839e
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Dec 7 11:49:27 2007 +0000
logrotate
commit 73d1b0f09e28192e93064fa8f7647570439ea929
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 7 06:48:00 2007 +0000
removed extra semicolons - reported by LI Daobing <lidaobing@gmail.com>
commit 1da07f1d689fb8d36ca6789fccee68f521e34f37
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Dec 6 12:49:24 2007 +0000
* fix for the [bug #21736] reported @ BTS, savannah/projects/gluster.
commit d8c30a779cde37d2c65a9cf543bd72d27d40a679
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 6 06:26:08 2007 +0000
Typo reported by LI Daobing <lidaobing@gmail.com> in compatibility
Compatibility for DOS mode for spec files (CR-LF ending)
commit 74b2ca28080aa04028528b0c530499cbdd3bfae0
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 5 08:48:55 2007 +0000
commit 2d24ed019430b3bed0b4313d1c217c626fdbbfc0
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 5 07:50:57 2007 +0000
fixes in fuse-bridge and unify to fix the ESTALE error
commit f4d1e86529314dee2ac642278da54b54cc6eb8fc
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 5 03:49:04 2007 +0000
ib-verbs - propagate notification of socket upto protocol
commit 5869ceb44849c049c6072ed8f6f2c6eb067d35ea
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 5 03:03:50 2007 +0000
fix for spurious ESTALE errors
commit 4f181b7c07ba65af2ed8ffef989bd05f6692d567
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 3 22:29:15 2007 +0000
locks around dict_get/dict_set
commit e6161851b43eb8dd7a3446f1b16cace80ab2d626
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 3 20:59:26 2007 +0000
mark fd's context dict 'locked'
commit b65941babf1fadb0129122e2510f67c347cccdbb
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Dec 2 21:07:30 2007 +0000
fuse_statfs_cbk - set ->f_frsize to ->f_bsize and scale ->f_blocks ->f_bavail and ->f_bfree to provide compatibility for old coreutils agains filesystem which report differing ->f_frsize and ->f_bsize (e.g ZFS on solaris)
commit 0fd6e0e3e93ff95e58177c2d09729c0eb0afaea8
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 30 06:47:55 2007 +0000
* solaris warning and build fixes.
commit 5c9577b2b803cd6331ee68a864096a6a83476f45
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 30 00:47:49 2007 +0000
conditionally define INADDR_NONE
commit 93e172f62a0ca6fa1444e49c64277c6115d1b5c6
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 29 23:05:13 2007 +0000
added log when frame size exceeds transport limit
commit cfd9e3415ec71310c85a0b722987fd4c5c1463bb
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 29 20:48:17 2007 +0000
added log messages in protocol/server to report fd table misses
commit dd5e47ddacdf4a46a576d523e076773f8d3ce617
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Nov 29 12:43:29 2007 +0000
Added authentication related and max_block_size options to translator-option.txt
commit a8cacbd176c49fa32caf09dfeb0c6d61871a89bc
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Nov 29 12:22:39 2007 +0000
removed debug logs
commit 9d2f3e5402c4bd909a959b1f0b315f2f1118820f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Nov 29 12:08:39 2007 +0000
backported protocol changes to add upperlimit to the block size recieved by client/server
commit c8ba01f5eb96f3fcc908c08ba6a34389c3a341ad
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Nov 29 06:57:12 2007 +0000
Fix to group permissions bug. Commented out setfsgid.
commit 512f17153e4498a484e9a4dc6d049c14c261e8b5
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 28 21:25:32 2007 +0000
unify.c - change lookup to check for "/" instead of "" after the inode_path() fix
commit 0d89caf1e3e41f890ed1c4cf570299a7dc3dc67d
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 28 19:22:33 2007 +0000
fuse-bridge - re-use ctime as generation number
commit 18da1902eac1fb5ffeab3f523fc2cba98a7aedd0
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 28 19:20:04 2007 +0000
protocol/server cleanup - fd_destroy in nop_cbk
commit 50e3d06a28393edb9bb4b2d3b73a36853c94a286
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 27 22:53:53 2007 +0000
fix in epoll failover to poll
commit 672faafd77197d2aa4542ee8547ab7ef5f6269b8
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Nov 27 14:14:03 2007 +0000
* switching b/w poll and epoll had problems on systems having epoll.h but sys_calls not implemented. As a result glusterfs had unpredictable behaviour due to race conditions. Fixed the same.
* Added cond_wait to sys_poll_iteration to block till atleast one fd is registered for polling before continuing to poll.
commit 81e4cd9c7a32390e7b957a7cca417fad88362322
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 26 19:01:44 2007 +0000
server_protocol_cleanup()
copy_frame per close/closedir in cleanup and destroy each frame in callback
commit 65af093a22df05e271527ee92f09634d2739872d
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Nov 26 11:32:43 2007 +0000
solaris fixes
* compat.c: made few changes to log msgs.
* posix.c: fixes to remove 'd_type' variables in posix_checksum(). instead calling stat().
* unify: added 'need_break' in all the loops which was based on 'mapping list' of inode context.
* fixed a bug in server-protocol.c, which used to segfault when a client disconnects while its doing some file IO.
commit ae9b547a2e8ad54c77f63532084ba4166f1dcf7e
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 22 23:22:13 2007 +0000
fix to avoid busyloop in fuse-bridge.c:fuse_thread_proc()
commit 1d4c03e852d54fc0abb0dac0be4564e38841436e
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Nov 22 08:44:21 2007 +0000
* a fix in unify_lookup, to break the loop based on list.
commit b410b51836da637676af9e541bbdab208fbdd5ff
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 22 01:47:17 2007 +0000
unify - unwind with ESTALE to force fresh lookup on files with non-2 count in context
commit 90ce53710a0cec5d1a4c1dbcc6848d5c268307b6
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 21 00:07:45 2007 +0000
copy inode pointers across src and dst for linking in fuse
commit 5b14a5f94ec06d14df8cbf5c8a35912ab0db09be
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 20 23:46:07 2007 +0000
log message fix
commit 8d02b21ba064b1792bca1e24e7c01c3182215944
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 20 23:44:03 2007 +0000
swap loc and loc2 for dst and src in link()
commit 12c90c8c5205ccdae8d6d6530544bb274c7cc1e7
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 20 23:24:18 2007 +0000
re-lookup to happen only for lookup calls in entry_cbk
commit cf684630aba47d86247d729d65236dd38156a094
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 20 22:21:30 2007 +0000
fuse_entry_cbk - update mode in cleanup check to avoid infinite loop
commit 080931491c7fbf1aa008fdf14b5f6d19e023036b
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 20 21:48:27 2007 +0000
multiple fixes
* glusterfs-fuse more rules flush stale dentries in fuse_entry_cbk
* glusterfs-fuse - run fuse request loop in a seperate thread to improve read performance
* protocol - disable buffer reuse
* transport/epoll - block on cond till first fd is registered instead of breaking out
* protocol/client - lk_cbk - fix wrongly returned ENOTCONN
* protocol/server - bring back reply thread
commit e8f779a59ee8efdfb07d3b5002625c7f00c7f1a6
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 20 11:12:32 2007 +0000
rr scheduler seeding
* Feature: While using 'rr' scheduler in unify, it used to start creating files from the first child only. Now, each client starts creating files from different child nodes.
* Changed AFR_VERSION to GLUSTERFS_VERSION, and similarly AFR_CREATETIME to GLUSTERFS_CREATETIME
commit 5b705c4ec1904287841b8505ef51bb0389dd3a2b
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sat Nov 17 04:03:49 2007 +0000
changing option read-node to option read-subvolume in afr.
commit ffa1c05b67a6623d03e47c9f1390c15061cae215
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 17 00:10:49 2007 +0000
ib-verbs - fetch back post on error
commit e4cbdeba4bb45e7001b010dd15d5af58fb6faa81
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 17 00:03:51 2007 +0000
booster/ib-verbs - booster pwritev in single transport->writev()
commit 5fbb4de0688b79fed4c701bec0f3851a4383170b
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Nov 16 11:31:27 2007 +0000
read-node should be used instead of read-schedule, "option read-node */<subvol>" can be defined. * specifies that all the child nodes should be used for scheduling.
commit 34c6b65ce701ac5172fabae2a8d31160bd0c463b
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Nov 14 12:43:26 2007 +0000
"option read-schedule on/off" is supported now. readv() operations are scheduled amongst the children of afr. if a file is re-read, it will be scheduled to the same node from where it was previously read from (to take advantage of the kernel caching on the servers)
commit 9d465852c68b56b7748772b4718a704688efcfd8
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 14 11:47:23 2007 +0000
* A temporary fix in xlators/protocol/server code to remove reply thread, which was causing memory leak.
commit 81d920c02132b166783204a48eb88862471ac740
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 14 05:08:33 2007 +0000
fix in server_create_cbk
commit d8e8ff7663d46dd3f363e00e5ba4228d705f1d6b
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Nov 13 14:05:00 2007 +0000
Backported fdtable maintanence from 2.6
commit ce62ccf3bcd64c8a14cebf3408ed1f9f1ba1cc6f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Nov 13 11:43:01 2007 +0000
missed out authenticate.[ch] in previous commmit
commit 3b611bb415230199dd266582fdec30b77adc3569
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Nov 13 11:33:57 2007 +0000
Added Authentication module
commit 656d9b994736db2b482492b0189a3f70c6adce01
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Nov 13 11:11:38 2007 +0000
Added Authentication module
commit 29ab20ba1f497efa60abfbb9cdcd5415ae15bd32
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Nov 13 07:14:07 2007 +0000
modified parser to accept double quotes (") (for eg., option directory "/home/export\"quoted)
commit bc0490dae6103ed6240149ce08c2647646028439
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Nov 13 04:56:42 2007 +0000
create pidfile iff -p option is given
commit b4c76b81911cc66d6c4c1e7124dd55ec5de0a434
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 12 00:57:55 2007 +0000
- trace backported from 2.6
- cond wrappers around recv buffer in ib-verbs
- glusterfs.spec.in minor changes
commit 8083ae1ac1951a2c17eafe95118a96679a7808ea
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Nov 10 14:57:31 2007 +0000
* fixing glusterfs.spec.in to build RPMs. Patch from Harshavardhana R <harsha@zresearch.com>
commit ab5f5493c4a028ac3efab81a9e20a0e266a9bc90
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Nov 8 15:04:34 2007 +0000
Need to do null check on entry->next even if op_ret is 0. Which can happen as detailed by bug 21541 http://savannah.nongnu.org/bugs/?21541
commit 6ee30417533860f42295705923b09e17f8ae6058
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Nov 8 08:04:59 2007 +0000
`backported' user guide from 2.6 branch
commit 9ca354c8d502ce101e18fb02cf23608052e045dc
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 8 04:56:38 2007 +0000
booster direct to server - fixes (use data_from_dynstr instead of data_from_ptr)
commit cbf6410ba082e1a2c4bbb260b1afe0788cae2305
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 8 04:22:50 2007 +0000
booster support to be loadable on server
commit b3b13684b214166c7cc116957f540a6cb464017d
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Nov 7 15:08:10 2007 +0000
notify should not propogate notify() from NS to unify's parents. And a NULL check for trav in glusterfsd.
commit e33ef3c587dbdd2fd4714d7c9424eed91ccc76db
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Nov 5 11:57:32 2007 +0000
* added 'incver' and 'rmelem' fops to unify.
commit 1e6e13c0ff5287ceaeae87e15fd08a338e0b18d3
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sun Nov 4 06:29:22 2007 +0000
in posix_utimens() if lutimes() fails, try utimes()
commit 9cb4cfad8549610e0688a8877bbee91192b49df1
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Nov 3 16:33:25 2007 +0000
bug fixes
* corrected checksum() to return directory and file checksum seperately.
* bug fix in gf_unify_self_heal(), where inode was refered after STACK_WIND, which was free'd and wrong values were used instead.
* a fix in libglusterfs/src/inode.c to return "/" if its root inode.
* few fixes in solaris part of code based on reviews from Harshavardhana R <harsha@zresearch.com>
commit 0f02f843f4abb2db3787a56ffa6b9fa2b14ad7dc
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 2 13:00:44 2007 +0000
* fix in unify_lookup.
if when a revalidate is sent, generation numbers differ, we mark the inode STALE and send a fresh lookup to get the fresh mapping list. Hence the hack to return -1 if a file is present in only on namespace is gone.
commit 1d72570be719505c8f2aad350a46957943cddd16
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 2 11:29:44 2007 +0000
* small fix in unify-self-heal.
commit fb3916cc0505acdfb04c861c05fd29d0885187bf
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Nov 2 10:33:16 2007 +0000
implemented afr_fchmod afr_fchown in afr. client protocol used GF_FOP_FCHMOD instead of GF_FOP_FCHOWN for client_fchown(). posix_utimens() used utimes instead of lutimes().
commit 694f37b8d5307b6aa912498ef33429dfff7a61d5
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 2 06:46:20 2007 +0000
* added missing booster.h to the makefile.
* changed log level of bailing out frame info from WARNING to ERROR.
commit a5ed967894a01953371b82ade59219f7e12462c7
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 1 19:12:49 2007 +0000
compilation fix, transport/unix backport, fix in fuse/unify
fuse/unify - if revalidate fails, send fresh lookup
commit 88a087bcb7da24a662924cdf0a12b708f47fb748
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 31 16:32:21 2007 +0000
* had forgot to tla add the switch scheduler
commit 777899c955cd6d6dffbf1938a7a30ed37332e91b
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 31 16:20:25 2007 +0000
switch scheduler
* back ported switch scheduler from 2.6 branch.
commit 59bd9b55530a42bd373980390b652ae74cc23d26
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 31 15:54:20 2007 +0000
booster
* booster backported from 2.6 branch to 2.5 branch.
commit 9cd1b703066282aeed4ecc668d2456691cda823f
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 31 15:42:35 2007 +0000
checksum FOP
* added checksum() call for MOPS. This is added with regard to enhance the self-heal speed of unify.
commit 5166128bd11dd20f18aa45b4ef40d4ca8e795253
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Oct 30 14:19:35 2007 +0000
Changes not to allow "option replicate" in AFR. http://www.mail-archive.com/gluster-devel@nongnu.org/msg02201.html for more details. changes to xlator.c - top->notify() is not called if xlator init fails.
commit 0ee233bd0f976fcbd4383fd4a8e078367e107476
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Oct 29 11:28:33 2007 +0000
Cosmetic changes to the afr code by bulde. Basic tests passed.
commit 3e5819cb2463ad294f9b888f804aa5022d45da2e
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Oct 29 10:04:27 2007 +0000
Added signal handler for SIGFPE
* Added gf_print_trace as signal handler for SIGFPE
commit b517de0166f7aba79a680feef11b32c8a83ee071
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Oct 26 08:46:31 2007 +0000
* small fix in fuse_create_cbk:
- reverted back if (!fuse_inode->ctx) to
if (fuse_inode->ctx != inode->ctx)
commit ccf0f0b0e8be9f6b7631f27b953182c2f0e204a2
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 25 20:57:24 2007 +0000
fuse-bridge logging enhancements, unify_create send close to NS when fail to create on DS
commit f45f57aaa7ab6504aae79692245177c6dea9935d
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Oct 25 09:40:59 2007 +0000
fuse-bridge bug fix
* adding fd to inode->fd list was happening even if op_ret from open/create was -1. Now fd is added to inode->fd list only if op_ret >=0.
commit 22948f3bd24dc4aa0da116c145d7b016107d511c
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 24 08:21:21 2007 +0000
* typo fixes in unify.
- changed local->entry_count to local->index in unify_create_lookup_cbk()
- changed list[index] == 1 to list[index+1] == 1 in unify_closedir ()
- moved fd_destroy from sh_readdir_cbk () to sh_closedir_cbk() in unify_self_heal.c
commit e4ef0a3769ef96061fbe37acc4e16871e51eda46
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Oct 23 07:48:36 2007 +0000
Bug fixes to client protocol and dictionary.
* dict_set () used a static variable static_hashval, which caused dict_set() to insert dictionary members to wrong indexes in members array. Now the static variable is removed.
* client_lookup_cbk() does dict_set() on inode->ctx for a lookup only if,
- lookup is fresh.
or
- inode number (ino) of the entry has changed.
* client_link_cbk() used to do dict_set() on inode->ctx. It was not necessary as the inode number (ino) is not changed in link() call.
commit 93b16fabcae653038e9312c5b133ec496a760efb
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Oct 22 13:15:51 2007 +0000
Fix for a bug where a memory is referenced after it has been freed.
Reference: mail from "Kamil Srot" Subj "Self Heal/Recovery Problem"
commit 3e8620daf4ac0975336c32db9011ce4b84f9b245
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Oct 19 09:44:26 2007 +0000
GlusterFS server Solaris porting - _almost_ complete
* removed extattr.h and moved its content to compat.h
* added solaris_*xattr() functions in compat.c
* added check in configure.ac to get AC_CONONICAL_HOST flag.
* removed warning related to mtrace in glusterfs.c and glusterfsd.c
commit 85be9f981709886311742ee983588704492e55ac
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 18 11:21:14 2007 +0000
swap inode context only for fresh lookup in fuse_entry_cbk
commit 8f946d872b40c8f64971ad0350f590ce4568655c
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Oct 17 13:54:51 2007 +0000
making a check in afr_open if child_errno[] array has atleast one element which is 0.
commit 9d93aa2bcf65327ecc59f015a631f3c38fa2ebf4
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Oct 16 16:43:38 2007 +0000
* unify:
- enhanced notify() to behave as desired (ie, send CHILD_DOWN when all the child is down, and send CHILD_UP, when one of the child is up).
- fixes in unify self heal, which caused corruption when used over posix, or with ib-verbs.
commit 3981a3ba6b8111244c34c613c9697bd0eb28f5db
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Oct 16 07:43:06 2007 +0000
* protocol/server: changed the log level of error msg in getspec().
* cluster/unify: a fix in unify_lookup_cbk().
- bug: when any of the node goes down (storage node), 'ls' on top directory was giving ENOENT error.
- fix: check for ENOTCONN in cbk.
commit 7929e7851412bde554359f1705ee936a459227bc
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Oct 16 07:15:34 2007 +0000
initialising ts[].tv_nsec to 0 before calling utimens() in afr selfheal code.
commit 8e928278586811dcb2a750cf3ad0b6e68dc3448e
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Oct 15 21:32:16 2007 +0000
afr - unwind when inode state is down for all subvolumes
commit 17b30dc901fb1846baa8ad4cf58fad186b64b88b
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Oct 12 12:33:58 2007 +0000
removing "static" for functions so that the name appears in the backtrace log.
commit 1f75f43e63d59c22b762a013cd9476d66234a702
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Oct 12 12:18:38 2007 +0000
frame pool from main() instead of global variable
commit 665eba9955efe2e35ffac3cdc2d111dc5e22bdf7
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Oct 10 15:40:43 2007 +0000
bug description: file creation was failing with striping enabled.
xlators configuration: stripe over unify
cause: unify was propagating CHILD_UP event to stripe for _each_ of its _own children_ causing stripe recieving more CHILD_UP events than it should've recieved.
Fix: make unify to propagate only one CHILD_UP event to its parent.
commit d895a9028da54fd21f8d69ba6e0b06e913059a5b
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Oct 5 15:13:36 2007 +0000
propagate CHILD_UP notification upwards in unify
commit 5509bd7d494ec26da99c3c55464247b5cd7ca7d0
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Oct 5 11:35:43 2007 +0000
Making the default version to start off with a file to be "2" instead of 1. This will fix a rare bug - when creating & writing to a file for the first time and killing the 1st child of afr. When the child is brought back the contents of the first child are taken to be the latest.
commit cf150dc04dbca5fa84bb3158bcccc32b8ad686c3
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Oct 5 07:05:02 2007 +0000
glusterfs-server init.d script update from Matthias Albert
commit 9a7607e3750ed5dc0fc36398ab5e9274f4004f46
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Oct 5 05:32:19 2007 +0000
* BugFix: Bug-ID #21256 - Schedulers segfault, if scheduler config is wrong. Fixed.
* BugFix: Bug-ID #21259 - Applied the patch to show the correct value when block sizes of the subvolumes are different in unify. (statfs())
* Corrected 'min-free-disk 5GB' to 'min-free-disk 5%' in user-guide.*
commit c064cb7874e739786bd36e92f9c5c489ac056cd6
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 4 21:35:05 2007 +0000
check for self-looping subvolumes
commit fa72de879ccd9b34e77bf42fffd5a34763db4ad2
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 4 09:25:34 2007 +0000
mark data_t holding reference with locked attribute in posix_readv
commit 5ae67137e70ea8500383306e5884d2d72e432d46
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Oct 3 18:50:53 2007 +0000
to make sure that we handle the case when "for (i = 0; i < child_count; i++)" loop fails, we STACK_UNWIND with error instead of segfaulting.
commit 121cceb251079d0e3361d845fdbae8b2c2ea4cb1
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 3 17:19:10 2007 +0000
reply references dictionary marked 'locked' in posix_readv - caused unpredictable double free's and heap corruption
commit 468d50ded6e4fcfff490d4911ba7cd389b58769f
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Oct 3 06:52:25 2007 +0000
fix in storage/posix to calculate to usec from nsec
commit 406e958851cb7f410af97ac684af9a8a491d227e
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Oct 2 17:54:02 2007 +0000
accept special characters in parser
commit c866391167641403ba19db7837f747bc6b4441c9
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Oct 2 09:33:47 2007 +0000
* xlatotrs/cluster/unify: fix for dict_ref (dict) bug, there is a possibility that, dict may be NULL.
commit 724bc5d1c27d0cbca63c0f9b8204994c384542c2
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Sep 30 19:19:39 2007 +0000
* fixed an issue unify rename, where there was a chance for creating duplicate entries, when re-mounted.
* added SIGUSR1 to print malloc_stats, in glusterfsd.
commit c54c7146c4a550ef9fd8958d366db82b0af1bd25
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Sep 29 06:39:56 2007 +0000
handle case in afr_getxattr when nodes go down after lookup before getxattr from another client having a succeeded lookup
commit 14d73bad2aab3893ea6fd77d19e2292508ebee3b
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Sep 28 13:05:27 2007 +0000
AFR readdir will give precedence for contents of the first child.
commit d485210c441d83dcb81f6b5ae4b94b1bd5ac2a22
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Sep 27 17:56:17 2007 +0000
1.3.3
* candidate for 1.3.3 release
* fixed an issue with afr_writev_cbk. store the stat of successful write.
* fixed an warning in trash.
commit 4d0c684346ffbe647df62eaddb4ede50d1fae687
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Sep 27 10:31:29 2007 +0000
call_count was not being initialsed to 0. Bug fix.
commit 808a18be004bc63fd7344895adc450b1e962eb88
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Sep 27 09:38:10 2007 +0000
handle case when rename happens on a path, which has got a new inode number by an unlink/create by another client.
commit 9acf7be5d2bbb9b25a62f035cf9fa8c76688454b
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Sep 26 18:45:31 2007 +0000
striping support in stripe_mknod()
* Added support of striping in stripe_mknod() fop, as in older FUSE, creat() fop is split as mknod() + open().
commit 71a2170ed81d10d8cc1e1b365fbe0c5fd008f475
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Sep 26 18:14:26 2007 +0000
posix_rmelem was doing system("rm -rf <path>") which is bad! now using nftw() call to do the same.
commit 735da49d7f5ef963e5fced59fcfde80f418758d7
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Sep 26 13:17:35 2007 +0000
if write fails on a child, no further operations shall be done on it (also version should not be incremented on it)
commit a8a06a85a38a305c187fe1cae757bb953f598c45
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Sep 26 08:27:16 2007 +0000
commit for glusterfs-1.3.2 release
* removed one unneccessary log in stripe.c
commit 68c18ecf2180de31e46c1cc421589dfad1999e27
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Sep 25 20:49:30 2007 +0000
* fixed a typo in stripe.c
commit e4da10701fc6b881a1251033f6d0eec5780fa582
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Sep 25 12:24:21 2007 +0000
overflow of wind_count in stripe_local was causing the stripe_writev to STACK_WIND even before the whole buffer is written. Changed it from int8_t to int32_t - Amar
commit 933fdacf831c68d4d0a198b1bd0d00b7a16121b1
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Sep 25 05:42:02 2007 +0000
replace inode ctx in server_lookup_cbk only if not already existing
commit 4c5068590735cc86e68e06671fc41ced1d5364ac
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Sep 24 10:29:47 2007 +0000
inode number is preserved even when one of the children go down (we remember it before calling and restore before returning.
commit c25cac2e6e1f28a24044798d2e7d8bb43eb53456
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 22 20:24:07 2007 +0000
* change in xlators/features/Makefile.am:
- '#trash' changed to 'trash'
commit 4ab18051d736c85d2c5e9c0a7638afff2b5b8e82
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Sep 21 13:46:39 2007 +0000
patch-488 was causing build_fail. fixed it.
commit 1ee4a7ab3c7c4ead32de05d8a82cb0ef5964c8c4
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Sep 21 13:36:40 2007 +0000
bug description:
* client configuration: afr mirroring two bricks over client protocol
* server configuration: posix over server protocol
* bug: run two clients and
1. client1: lockfile file
2. client2: rm -rf file
3. client1: lockfile file (hangs)
Keywords:
commit cb4ec56fec0b9cc5d043501b3187fad6cb877a05
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Sep 20 08:47:46 2007 +0000
graceful cleanup of protocol private on unestablished connection
commit fa1eedfa2639a74710dc41e444dd6d86bf1e69c3
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Sep 17 11:39:54 2007 +0000
invalidate dentry when lookup fails with ENOENT
commit bab878772b9f77976f9ba4a50e458297ae017a40
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Sep 14 09:56:08 2007 +0000
lookup now carries extra argument need_xattr which tells posix if xattr dictionary needs to be returned back in the cbk.
commit a7542946cc98ba0de7e5694f3862d7482d217982
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Sep 13 08:47:42 2007 +0000
* bug fix in 'xlators/features/filter' (removed flush() fop from filter).
* backported trash translator from 2.6 branch. Working. few more updates pending.
commit f680c4045d560b65bba9ba4c49a9a8cde78949c7
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Sep 13 07:56:58 2007 +0000
glusterfs-server init.d script for Debian
commit 0c66c351e9ec6ff9e8e0d1e082af2aa5313abee8
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Sep 13 05:42:28 2007 +0000
there was a small bug in afr_readv_cbk due to which read failover was not happening.
commit 424c0874f7712b7a7c29dd9fde6f8cf0c456e43a
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Sep 12 21:22:41 2007 +0000
fix in parser - #define yylval's type to char * in spec.l - fixes parsiing problem in 64bit systems
commit f842b03dace035f2f452dc33a928b6ae4debcee1
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Sep 12 20:41:25 2007 +0000
there was algo error in afr_lookup_readdir_cbk in the way entries for rmelem were decided.
commit f014ca218e820d9e1a4e357bb6a9ba76f013b0ca
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Sep 12 09:18:28 2007 +0000
* fixes in client protocol to return correct number of argument in STACK_UNWIND, during ENOTCONN error. (back ported from 2.6 branch)
commit 7fdc836f29c46bdb342c66096e3b4f035a336d99
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Sep 12 08:11:02 2007 +0000
* unify's 'struct stat' return storage nodes' mtime.
* correction in unify for lookup_cbk(). (Now returns dict in lookup_cbk)
* correction in stripe for lookup_cbk().
* changed xlators/protocol/client's "transport-timeout" to 13 from 120.
commit cf5eade2ced278f88ff33f981932c0b6fa280508
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Sep 12 07:12:19 2007 +0000
STACK_UNWIND of lookup_cbk should pass xattr dict also. Similar fix needs to be done in unify, stripe.
commit cfe438f049f1f96df55bb9da136d710cea54a3b7
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Sep 11 19:54:45 2007 +0000
Changes for directory versioning.
* new fops incver, rmelem
* lookup_cbk gets dict having version info of file/dir
* changes to all xlators considering lookup_cbk change
* rmelem is doing rm -rf, needs a better way of handling this (move?)
* incver is just incrementing AFR_VERSION, shouldnt be hardcoded.
* lookup should be configurable regarding if the cbk should give the dict.
* lookup selfheal should touch nonexisting files and give ino num from first child
* readdir should give contents from first child (no merge needed)
* Needs lot of code cleanup, mem leak check.
commit 3000470f5fe95da19b6b65083e8276f59ecbb641
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Sep 11 15:37:24 2007 +0000
Fix for read failover, there was a bug in previous fix.
commit 4fa7ed39b2be137d8279d2497eac9f9fb5335ffd
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Sep 11 13:34:15 2007 +0000
afr_readv now implements failover if read on currently active child node fails
commit 825e850a9ffbf346ba4b5cfe373141cfde79cbc7
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Sep 6 18:12:28 2007 +0000
* fix for 'divide by 0' error in ALU.
- if total_disk_size is 0, neglect the call and return 0.
commit 530ccb6cf49f4c40b641dee081f3238dd8bb6a9d
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 31 12:24:13 2007 +0000
ib-verbs/client - make default blocking connect
commit 8df99ea816bbf75d6da0e7935686a3b2ba2b23b9
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 30 13:34:20 2007 +0000
Release 1.3.1
* a fix in io-cache:
- by gowda, committed to 2.6 branch by him.
* a fix in io-threads:
- now can get the values in MB, KB, GB.
commit 699d74eed0ab024cbf7af043c01613c324bbdd47
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Aug 30 12:40:54 2007 +0000
update trans->buf->len after malloc ing trans->buf. Due to the length not being updated, write-behind on io-threads used to give I/O error when large files are copied b/w two different machines.
commit 1ab142c29334a7a1957dc8a00e123b6332ae10f6
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 29 12:27:26 2007 +0000
* typo bug :O (classic example of how easy it to put a bug is glusterfs)
----
callcnt = local->call_count--; should have been
callcnt = --local->call_count;
commit bb035d8cb908c70fd5e2761186502fcee7e5d475
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Aug 29 12:13:49 2007 +0000
tune read-ahead page-count with page_count rather tha page_size
commit 4d2b4d1090524a6aa4fb6d73fd9be8f8573fed67
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 29 10:46:47 2007 +0000
* minor fixes in unify_rename_unlink_cbk().
commit fc1c7053337367713899b4bfab801f662185d0ab
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 29 09:33:12 2007 +0000
* order mistake in unify_ns_rename_cbk().
- callcount was calculated wrongly.
commit 8a1d3c6a9e5880dd7a044cfde2aaaa789c3270da
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 29 08:54:29 2007 +0000
* fixes in unify. Now, no unlink happens in background (copy_frame). hence unify_bg_cbk() is removed.
commit 5490dd49a223d7cd55554281bb21ad7e3eebf996
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Aug 29 06:22:33 2007 +0000
fix in inode replacement logic
commit 65a9ad2556a705e7e50b9305796fcdc49e6de06c
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Aug 28 20:46:08 2007 +0000
* a fix in unify, which caused problems when afr is used below unify. (mostly segfaults in afr_close_cbk()).
- Unify was doing the close() in background if open fails in one of the nodes. This caused fd_destroy to happen before the close in below layer is completed. Fixed the issue now.
commit aa7b087ffc3d589740ec6cea5e547b38cc5f80b5
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Aug 27 11:29:20 2007 +0000
handle clashing inodes gracefully in fuse-bridge
commit c0534723e3f2a71957ce4a28e5ec778e7cce4561
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Aug 27 11:31:34 2007 +0000
* fixed a bug in ib-verbs:init(), which caused segfaults when 'ib_uverbs' module was not insterted.
commit 4802bc4b3ba333f4789f09ace269cb821637c3fb
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Aug 20 08:50:53 2007 +0000
* changes in libglusterfs/src/extattr.h:
- changes done for freeBSD compilation showed up errors, when compiled on Linux machines with old glibc (without 'llistxattr()'). Correction to make it work smoothly.
* transport/ib-verbs/server:
- .bail is set to ib_verbs_bail(), which was causing segfaults.
commit 46855869a339f4b817ca5c63db2a64885ec88800
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Aug 16 12:02:57 2007 +0000
bug fix in io-cache
* op_ret = -1 case was not handled properly in cache revalidate path, in ioc_cache_revalidate_cbk().
- when op_ret = -1, ioc_cache_revalidate_cbk() used to set struct stat *stbuf = NULL and pass it on to
ioc_inode_wakeup().
- ioc_inode_wakeup() was not verifying the case of op_ret = -1.
- now ioc_inode_wakeup() considers op_ret = -1 as revalidate failed and flushed the cache.
commit 7a3d96b7a58a6c2a345b33b33c3c2e275d0287de
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 16 08:19:17 2007 +0000
* updated 'doc/examples/' directory with spec files containing details of each translators.
- more explaination need to be added by maintainers of each translator.
commit 0b115578797be493730262724a46c87b30ac9c85
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Aug 13 20:10:14 2007 +0000
set this->private in rot-13/init() (it had mysteriously disappeared :O)
commit daed344012797044ed3ae760f4530bbcd108e177
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Aug 13 15:20:54 2007 +0000
break statement missing for direct-io DISABLE option.
commit c0a4d15ddc5fb7ddeeb612b04fef1e4944c2c08b
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Aug 13 12:12:48 2007 +0000
altered configure.ac to pick glusterfs.spec.in from topdir
commit 70cfd6808cd5087f731bb3b2f70444bdb1480b2d
Author: Anand Babu <ab@zresearch.com>
Date: Sun Aug 12 20:29:54 2007 +0000
glusterfs.spec.in moved to topdir
commit fb6ded3a57df79fcbdc48a250c623dd2d1672915
Author: Anand Babu <ab@zresearch.com>
Date: Sun Aug 12 20:26:46 2007 +0000
moved glusterfs.spec.in to top level. its the right place
commit 743f3722625a5d47ea82ec837eb259659b16633b
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Aug 11 17:47:28 2007 +0000
* correction in configure.ac file.
- patch sent by Harshavardana Ranganath <harsha@zresearch.com>
commit d28537bf06dea5224ea282b62ef1743a1f930ec4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Aug 9 19:30:54 2007 +0000
fixing a compile warning.
commit f3cbd05975916d73c87721b5f6ca3553a1c49ef2
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Aug 9 17:35:57 2007 +0000
fixing a bug in afr_readdir()
commit 74d0efde0927084af94b67a814f7302bc8135bba
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 9 12:34:58 2007 +0000
do not decrement frame's refcount in stack destroy
commit d41c736850577ff1e375ef47221d7150ec219872
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Aug 9 12:09:06 2007 +0000
fixing a memleak in afr_readdir_cbk
commit 61b850f946d9220d644580147553b733ca222d24
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 9 11:46:23 2007 +0000
converted user guide from LyX to Texinfo format (work in progress)
commit 10e455c48d05905c87e42fe4f22f7508eb9d1fe9
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 9 11:35:54 2007 +0000
* a bug fix (which was introduced in patch-444), in unify-self-heal.
commit 775aa283f0a7c75dbbfa012884b35c233d40edc0
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 9 09:37:41 2007 +0000
avoid swapping contexts in revalidate mismatch of server_lookup_cbk
commit bd03f86a68a68ff035d882dd2a95a51e04684140
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 8 18:45:03 2007 +0000
* fixed warnings in glusterfs.c
* some more data consistency checks in unify's self-heal code.
commit 6b8fd2193febd26c35be9c901d081e004acb5320
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 8 16:17:59 2007 +0000
* Added Christopher's name in THANKS file for giving 'init.d' script for glusterfsd.
commit 1035af2eced8050a3b191b4af810a3ce5d31ce00
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 8 14:00:16 2007 +0000
* minor changes in stripe (changed variable name from 'hint' to 'striped')
commit 083ef0639c2d09b0ab0a0ef7f78161c8e1571eb7
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Aug 8 11:52:54 2007 +0000
added --entry-timeout and --attr-timeout command line options for fuse binding
commit c2d50f0077e48913dcd7a58f3aef8387549fca9a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Aug 7 21:24:50 2007 +0000
mkdir was not beeing done as root/root in lookup selfheal. correcting it. doing mkdir as root and then doing chown.
commit 8e99e1fd77e186780467417fdf4ee8b6aae14992
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Aug 7 09:52:54 2007 +0000
reorganization of files between doc/ and extras/
added init.d script, thanks to Christopher Hawkins <chawkins@veracitynetworks.com>
commit 15cc2b94dd4f555d8a4ebddba81f85e132e2be76
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Aug 7 09:13:27 2007 +0000
was doing data_to_ptr(dict_get()) which was printing error msg when dict_get was NULL. changing this behavior, i.e data_to_ptr is called only if dict_get is not NULL. also not printing error msg in afr_selfheal_getxattr_cbk in case the errno is ENODATA.
commit 3f426ee072e39c0959c00612a28b95c31c548a03
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Aug 7 07:21:45 2007 +0000
preserve refs across server reply thread only for readv
commit c8eed82dfb17eeb133bbc279dfe019307138697a
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Aug 6 18:57:57 2007 +0000
protocol/client - fixed leaking reference dictionary in cleanup
commit 43b152a085d8fbddfc3c773d0231bf22c35cb015
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Aug 6 18:33:03 2007 +0000
multiple corruption fixes
protocol/client:
* client_protocol_cleanup () - unwind frames in the order in which they were saved (reverse order of saved_frames->members_list) - caused undefined behaviour when server connection died
* client_protocol_cleanup () - fixed typo of setting refs to req_refs instead of rsp_refs - caused corruption when server connection died
commit c63c150fa4d224afb9784bc60f1e6c9c9a61bee7
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Aug 6 15:36:21 2007 +0000
protocol/client changes
* changed reply dict as locked.
* fixed leak in client_protocol_xfer(), by doing dict_unref in all cases.
commit 6a4948f5396af2f4aedcef8ce78b5b241dd1fc7a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Aug 6 15:21:16 2007 +0000
in lookup/selfheal, using array of stat and removing use of "gic" completely. This should speeden up lookups.
in close, incrementing the version count using array of ashptr instead of linked list. again this should avoid malloc/frees.
not putting createtime/version info during create, but during close. optimization.
removing gic structure from afr.h (not used anymore)
introducing afrfd->write which will be used at close to see if createtime has setxattr'ed.
commit b9b398f9e74be73c60754887c3312850bb6b5e44
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Aug 6 13:02:00 2007 +0000
glusterfs-fuse: two direct-io-modes 'enable' and 'disable' - default to 'enable'.
protocol/client: changed few logs to 'DEBUG' level from 'WARNING'
commit e8ddb94cf788dfe3a9989517e2515b65dfbfd47d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Aug 6 13:49:08 2007 +0000
Bug: Kernel build fail stating invalid file-format of a .o file with read-ahead on io-cache.
Fix: flush the read-ahead data in the ra_writev_cbk. A part of the fix i.e., flush the cached data in ioc_writev_cbk has been committed in a previous commit.
commit 5a5bfb750f4717f4821a45daa42aa97a3dd7a6fc
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Aug 5 09:15:57 2007 +0000
dict - fixed validation from data_from_*() functions.
inode - maintain references to parent inode via dentry and unref when unsetting
protocol/client - fix number of arguments for stack_unwind in case of EBADFD
commit 813348d6b7b31a7db7e1a1e042b15d80112284b2
Author: Anand Babu <ab@zresearch.com>
Date: Sat Aug 4 19:42:41 2007 +0000
Matt's ib-verbs disable patch to rpm spec file
commit 3d8f85b2b63e144f5dbfa48900bc348c4c4e099c
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Aug 4 07:43:54 2007 +0000
fixed typo in input validation
commit 3f34915774d46571041d59b05d65b1a88b8294d8
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Aug 4 07:32:35 2007 +0000
input validation in dict
commit 4a8edc483b89e2b866b87ec0ce59c0b7a404aa14
Author: Anand Babu <ab@zresearch.com>
Date: Sat Aug 4 05:54:12 2007 +0000
added copyright line to configure.ac
commit a92e546a7f14430e744343c8e868c0c7865c8dda
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Aug 3 11:22:09 2007 +0000
return lock; in insert_lock in posix-locks
commit b844f4bd8bb1e678fbd8aede6495ff82cf5e3de6
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Aug 3 11:10:27 2007 +0000
changed posix-locks to use frame->root->trans instead of frame->root->state
commit a4588e52e5bc2459b094eb3ec1cbf976b7f58856
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Aug 3 10:01:24 2007 +0000
* more fixes in stripe:
- now if create fails in one node, close and unlink is sent to all the child nodes.
commit 3f0ba9695ce971b757fe3d8d53a894c1a084f813
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 3 09:49:44 2007 +0000
make refs dictionary 'is_locked'
commit c72132fa90de30210b1993371b0e3ac5f7eb1df8
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 3 08:41:44 2007 +0000
dict_ref in call stub checking for refs, and not for count
commit 9d9de7661822c8dbba5a743e1caa0bb52c5ed2d5
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 3 08:27:21 2007 +0000
iot_writev - failover to iov_length() when req_refs is NULL
commit 7b565676607445e0323de3538c02d135afd88a9d
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 3 07:39:05 2007 +0000
protocol - keep only the buffer data_t in the refs dictionary and not the unserialized parameter dictionary.
commit b5336bfcda93ad3a34707e2784fa013a683d9c0b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Aug 3 05:55:00 2007 +0000
io-cache bug fix
* io-cache used to flush cache pages for an inode during ioc_writev(). But that led to a race condition when
read-ahead xlator resides on top of io-cache.
* io-cache now flushes cache pages for an inode during ioc_writev_cbk() also.
commit 7d68e226665b71e4e51c9954b951a7242ebf8438
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 2 20:59:58 2007 +0000
fix logging in protocol.c to display the translator name as domain
commit 119daa750cda428314b702d55b81f6fe53304759
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 2 20:36:12 2007 +0000
fixed missing stat buf to STACK_UNWIND in protocol/client when server is disconnected
commit 77c7ae5bcf3a3a51282e1472883ea729b99557f4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Aug 2 19:58:14 2007 +0000
doint dict_set of afrfdp to fd->ctx as a static ptr and not as dynptr data. This avoids a race condition memory corruption bug.
commit e1d2b204c213a8c185328427d101e25f6bf46215
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 2 19:27:26 2007 +0000
reset rsp_refs when synchronously unwinding from protocol/client
commit cc6ed339a1e338188e1c94f0cde0fa279eb0efa6
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 2 18:56:34 2007 +0000
unmount mountpoint before exiting in case of initialization failure
commit 80187b4b180027cca58862278a60a5d49d141234
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 2 18:30:10 2007 +0000
* correction in mount.glusterfs: if port is not given, it didn't use to take default port. Fixed.
* bug fix in stripe. If open fails, send close to nodes, and return.
commit 5a5d7bcaee26b948c725072000f2e25781634326
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 2 18:10:04 2007 +0000
reset rsp_refs pointer in posix to NULL
commit 98040a41147c3cca92c616b5da99b782f83f24e5
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 2 15:22:46 2007 +0000
* doc/*: minor updates
* stripe.c: bug fixes. Send closedir after sending opendir.
commit 8485fbaf8d44462044315f4299c6f43a8abb46c4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Aug 2 14:12:11 2007 +0000
not using afrctx anymore, instead using afrfd_t. this should improve performance.
commit b942f07238cb7d9e20ed55879c6c34a9a004e6a0
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 2 11:20:05 2007 +0000
use ->trans pointer from call root in namespace lock instead of ->state
commit fa582e4f088697a11cd4cf973a32cb710516102e
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 2 11:15:11 2007 +0000
add new field in call context for transport pointer
commit bf9d649a90f8cb6cc730ec9020923876a1f455e4
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 2 11:10:37 2007 +0000
fixes in posix-locks
posix-locks.c:
- changed delete_locks_of_pid to delete_locks_of_owner
(check for both client_pid and transport)
- added debugging statements (controlled via _POSIX_LOCKS_DEBUG)
commit 9c2a0e65bd98f1299e7efa07eeb203891d9f3ddd
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 2 10:33:09 2007 +0000
glusterfs-fuse - use fd passed to call in the callback and not the fd passed back in the callback
commit 20f412b42d09e7875675e5702726f92f420c1b54
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 2 10:03:05 2007 +0000
typo fixes in doc/ and cleanup in read-ahead
commit 7b28f68fc0aebd9bfe104194fdc413a0b67e7e79
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Aug 1 20:13:39 2007 +0000
transport/*/server - do not use transport_ops directly
doc/Makefile.am - define docdir relative to $(datadir) instead of $(prefix)/share
commit 0939d2982e9a94cdf8bf9c012d8b801f3051ba0b
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Aug 1 16:43:59 2007 +0000
dict + related
mark dictionaries/data elements which need to be accessed with lock explicitly instead of locking for every get/set
commit 3c6e369ee59f117e33ac8faf0b6ea7fb21e4d154
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Aug 1 15:57:06 2007 +0000
stripe, trace & io-cache changes
* io-cache:
- removed unwanted debug messages from io-cache.
* stripe:
- stripe_open() and stripe_create() filter out the O_APPEND option from flag given to open() system call.
- stripe_lookup() stores hint in a local variable on stack instead of frame->local.
* trace:
- trace_write_cbk() now also logs 'struct stat'.
commit 5d29b5de7d47ee7f97040d213f21ddec755ba782
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Aug 1 14:55:33 2007 +0000
made changes in selfheal code, stat call is made after getxattr only on the selfheal source file. This is an optimization.
commit 1e60b958219f6304b17387d0f25e7a48da51539f
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Aug 1 11:25:58 2007 +0000
in afr_mknod_cbk, need to return success even if one of the mknods were successful. Also fixing minor debug messages.
commit 8243b3690cadf45aa28f45fbb33779de856bf3b2
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Aug 1 10:48:12 2007 +0000
in afr_mknod_cbk, need to return success even if one of the mknods were successful.
commit 68af8c4d16a3461859423f7542d19c65241ad74f
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 1 09:57:36 2007 +0000
* doc/qa/qa-high-avail-server/client.spec:
- updated with io-threads.
* unify.c:
fixed a bug (in case of opendir failure, it sends closedir, but callcount was not resetted).
commit bf4791652aa67132b881d2d5e59837b399e13f82
Author: Anand Babu <ab@zresearch.com>
Date: Wed Aug 1 00:11:36 2007 +0000
guru's glusterfs.vim added
* glusterfs.vim: Guru's glusterfs.vim mode file for glusterfs vol spec file
* configure.ac: Changed version to 1.3.0 and addeded license preamble
commit 537a1b82a480cde70de409d1031d4e16f8aabb7b
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 31 22:09:27 2007 +0000
license upgrade
upgraded all source code license headers to use GPLv3 notice
COPYING - text from http://www.gnu.org/licenses/gpl-3.0.txt
commit 3ce147ee94f8eb0ad1f8c4d8c344c18d1753bc33
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 31 21:31:20 2007 +0000
mop_stats
mop_stats - check for bound_xl and unwind with EINVAL if not bound
doc/specgen.scm - cosmetic changes
commit 6217ad63c5736de920fa8f0b00e78e0a27646429
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 31 19:49:05 2007 +0000
newer specgen.scm :p
commit 4b291e872a090944711c546b08ba9ec2903c1cf2
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jul 31 16:34:01 2007 +0000
io-cache
* ioc_need_prune(), gives a margin of 20% before triggering a ioc_prune().
commit 8f2d9ad406df16f6c6a81622c6b886b423d98640
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jul 31 16:19:32 2007 +0000
checking for afrctx=NULL and STACK_UNWIND'ing. locking/unlocking on first alive child. Fix getxattr_cbk which was printing ERROR even when there was success.
commit dab3d9cef7786669e1bf9045afd3ec64f49faace
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jul 31 15:58:40 2007 +0000
io-cache changes
* io-cache now provides an interface for all the fops to get ioc_inode from inode->ctx dictionary.
- ioc_get_inode(dict_t *dict, char *name_of_xlator)
+ checks if the ioc_inode is present in the table->inodes list.
> reupdates the ioc_inode by adding to table->inodes & table->inode_lru[weight] list.
+ simply returns ioc_inode, if ioc_inode is already present in table->inodes list.
* ioc_prune now deletes all relationships of a ioc_inode from the table, if ioc_inode has no pages in cache.
commit 1c29bf1e5c9c797839457530076ef64d53497011
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 31 15:06:23 2007 +0000
fix for spec fetch segfault
commit 8e6e84fb4d12c8eb3e7726b639a6d892208edc23
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Jul 31 14:54:23 2007 +0000
store locks in the order they were created, not reverse.
commit a800c69ed502bb7f33890a8fc3c8c70c6970e5c1
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jul 31 12:12:40 2007 +0000
a NULL check in dict_get. afr_statfs will send statfs on all children. It cant rely on inode->ctx data as lookup might not have happned.
commit d71d320923931eb8a04236c8f9f4ecec1248f1f7
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 31 10:42:54 2007 +0000
make lock an embedded member of dict instead of malloc/free'ing it
commit 9edf4fe59247bb8f797c974f9e80a374d8ffabf8
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jul 31 11:40:44 2007 +0000
added check for (op_ret == 0) in read-ahead before checking whether the file has been modified on disk in fchown_cbk and fstat_cbk
commit 17d085dbcab7ebe3e2e9b83c4e73c2fd59d47f7c
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 31 08:54:27 2007 +0000
fix inode_parent () to neglect unlinked primary dentry
commit e2d2c5bc86a3b6bbaa933271e46331c302a0ce93
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 31 08:30:51 2007 +0000
libglusterfs/inode - disassociate inode during __passive_inode (with lock) and not in __destroy_inode()
libglusterfs/common-utils: use a dns cache to use round-robin multiple A replies
commit 734789144fee28f294dfa93a7768dc55be466e1d
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 30 19:49:10 2007 +0000
* commented out .statfs in afr's struct fops
* added a server and client spec file to test cluster translators on server side. (Same setup as http://gluster.org/docs/index.php/GlusterFS_High_Availability_Storage_with_GlusterFS)
commit 21958909157b0a958d3b4cc49901fdf0571c0309
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Jul 30 18:30:44 2007 +0000
bugfix in genspec.scm :P
commit 7b33ff42c5c232b66934cbe6bca80da1c839ba16
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Jul 30 18:15:33 2007 +0000
added genspec.scm, a simple script to convert a spec tree in scheme to spec file.
commit f0363ef2faf6730218721ae2e29746a83e80635e
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 30 18:20:19 2007 +0000
* stripe: removed .readdir from struct fops. (as its enough to read entries from first dir).
* unify: small bug fix in unify. (unify_lookup_cbk was refering to 'inode' instead of 'local->inode')
*unify-self-heal: now sends closedir to all childs if the opendir fails.
commit 136f515404d5718092ba31501551b9c7b1e2f706
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Jul 30 15:57:57 2007 +0000
during selfheal, missing files are created as root and later chmod() to the user. This is to take care of the case where the user has lost permission to create files in that directory.
commit 8c60079d8fa0edffa6e2935b422483ce3efddc91
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 30 13:47:27 2007 +0000
libglusterfs/inode - fix inode_parent() function
afr - set local->op_ret = 0 when success
commit 1cf9cbfb6d65187d3a6dc3b64dfee8ea3132c9c1
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jul 30 12:35:55 2007 +0000
poll_iteration doesnot complain about invalid poll_type when glusterfsd is run with server protocol removed
commit c1871e0f1b5be2ec4fd8aa243cba6c29f7fc1868
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 30 09:59:57 2007 +0000
io-cache - fix in io-cache's _lk to do extra str_to_ptr ()
protocol/client - log cases when inode's ctx is null
storage/posix - initialize glusterfsd_stats_nr_client
commit 1d16879546b4309a7dde291a4d82aa7b11d05e29
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Jul 30 07:42:48 2007 +0000
changes to afr to use a simple array storing errnos instead of linkedlist of gic. changes to data_to_[int|uint] functions to take into account the data whose strings are not NULL terminated. change to posix to use calloc instead of alloca in getxattr (as it should be preserved when it is dict_ref'ed.
commit d4e7a656ba8db75a9f1753b13063578a8fdd986e
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 30 07:33:33 2007 +0000
* removed warnings in transport.c
* check for dict_get == NULL, in case of write-behind, io-cache, io-threads.
commit 43d26ee864894009edc13ad14739ce1610f1b7bc
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jul 27 16:21:32 2007 +0000
Use poll in case epoll system call is not implemented but library wrapper is present(HAVE_SYS_EPOLL_H will defined since wrapper is present)
commit 9e66c77d6128ccde705d5648c4d523afb80a6e93
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 26 19:32:21 2007 +0000
fixes in fuse-bridge related to hardlink handling
fuse-bridge - update dcache with new parent/name instead of letting next lookup update it
inode - do not list_del_init on embedded dentry member of inode in dentry_unset ()
commit 840dfcaf92c497d3ea53297f298dcbd845f15780
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 26 19:26:46 2007 +0000
* minor bug fix in unify (refering inode in case of op_ret == -1, used to work earlier.. changed now)
* stripe translator migration to 'no lists'. Now saw the improved performance in case of dbench. but still has some bugs, as glusterfs compilation over glusterfs has some errors.
doubt read/write order etc. need some more testing.
commit 8e2761750a2a72187270712e41c752a7ff78926b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jul 26 16:43:55 2007 +0000
io-cache minor change
* changed ioc_prune() prototype to accept only ioc_table.
commit 1777e47eadd18925bd7466c5820ad4495b728d2a
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 26 15:02:23 2007 +0000
* added data_from_int8, data_to_int8 in dict.c/h
* removed openfd list in unify.
* some minor bug fixes.
commit d8450942a5b2af0a98dd4ba0ff5b6c022dd46529
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jul 26 05:43:11 2007 +0000
io-cache pruning changes
* cache pruning changed.
- suppose N bytes is the excess usage in cache above table->cache_size.
- ioc_prune() traverses the ioc_inode lru list, starting from the lowest priority ioc_inodes.
- pruned_size is considered to be the size of all the pages traversed.
- pruning breaks when pruned_size >= N.
* this way we make sure that a lower priority ioc_inode does not prune out pages from ioc_inode of higher priority.
commit 753da64e97090ce1115eae74bb00e5ec091a5fc3
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 25 21:07:08 2007 +0000
* changes in client-protocol.c to send inode/fd instead of NULL in case of failure. (in _cbk().)
* now unify has checks for all the arguments it gets. Most of the variables are validated, before using them.
commit 3bd5657ea0042db3b9fdcb9d231ac170c6953d25
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 25 19:27:02 2007 +0000
minor fixes in io-cache
io-cache - hold table lock before moving ioc-inode up the lru list in
io-cache - re-use calculated weight in open_cbk
commit d09722598b9d419c466335e83394c59667e3ac92
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 25 18:27:18 2007 +0000
libglusterfs - print backtrace to log fd directly without going via f*/gf* functions
io-cache - fix segfault when no priorities are listed
- make number of lru lists dynamic (from static 5)
commit 2da663f2d80a2c6ded5349e5478a8eef386f1581
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jul 25 17:03:14 2007 +0000
io-cache offers user configurable priority based pruning
* user can now provide priority for certain files to be cached.
- spec file option will be "option priority <pattern-1>:<priority-1>,<pattern-2>:<priority-2>,..."
* io-cache maintains different lru lists of ioc_inode for different priority levels.
* ioc_prune() prunes the pages of lower or same priority inode's pages to accomodate for a inode's cache space.
commit cf000ef82981b38f19d3f8bd3261445ab6b5cde7
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 25 13:52:26 2007 +0000
* bug fix in unify_lookup_cbk (local->list was getting double free'd)
commit 7e68beb21b44b7ab356655ef9e999e4a8350df61
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 25 11:36:23 2007 +0000
unify and fixes
unify_lookup_cbk - off by one allocation error caused heap corruption
- free local->list when op_ret = -1
afr_close_cbk - destroy afrctx dictionary
fuse_loc_fill - get parent inode directly from inode instead of second search
commit bc29a3baab7e44ace9642a53a6279c4e27af84a0
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Jul 25 10:09:56 2007 +0000
removed superfluous fuse-internals.c; added user-guide.lyx
commit 3f28326f95aa52b8716e8858fcbff5cd5123b506
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jul 25 10:51:36 2007 +0000
deadlocks are fixed now (And I've tested it this time :)).
commit 2987e72904075c01b28e0daf5881343f035805ac
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jul 25 10:29:36 2007 +0000
Previous commit was causing deadlocks. Hence undoing it
commit 30ad9549784af62dd41d2d2e92a0cda629e0a711
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jul 25 08:05:54 2007 +0000
fixing a compile error in client-protocol.c
commit 746c68f53fa29470018f64eb84464076b7cacbe8
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 25 08:03:34 2007 +0000
* changes in unify's rename (completed a left out todo, which was causing segv)
* changed unify's notify. Sends notify to schedulers instead of calling update.
* added notify feature to schedulers.
commit 6c9b40063f224845d459086bf1938cb70e138c88
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jul 25 08:00:14 2007 +0000
addition of bailout timer and related initializations in client_protocol_handshake are done holding locks.
commit 8bdf8bbc518e893ccfa5b1d63923b9841aec4e03
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 24 18:39:39 2007 +0000
* xlators/storage/posix:
- posix_writedir(): added support for char/block devices and also to fifo files.
* xlator/cluster/unify:
- changed list head to int array.
- added checks for failure in every possible place.
commit 268209bdb0a41038f9c388d371f6af6f2d812047
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 24 09:17:24 2007 +0000
changed mutexes to spinlocks in inode and call frame
commit 77cd8d872c1bee27a46d810bf98c78598c0db794
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 24 04:46:42 2007 +0000
unify_open_cbk - use local->fd to preserve fd pointer to be used in open_cbk when op_ret = -1
commit 5bf04eaaa7401fa3d52bdfcdbde30603fb576b83
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 23 20:03:32 2007 +0000
ra_truncate - convert value to string before converting to pointer
commit ad19f84e94f40fff2a5ed4e25a0f9698547eeaa9
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 23 19:49:46 2007 +0000
unify_open_cbk close 'tmpfd' from local->openfd instead of 'fd' when op_ret = -1
commit ec4d4c83e4f635883b4ac108029b41414f44a742
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 23 19:08:48 2007 +0000
ra_truncate - fixed sprintf'd string used as direct address
commit bdcad90b1f32e26d504ea9f57fba2b94e3ced4f1
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Jul 23 15:19:32 2007 +0000
bug fixes in AFR, inode.c changes (by avati) to build path from latest dentry that was updated.
commit fe5af04a841cd00f04887b9b46b9789b1660b3d3
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 23 11:57:30 2007 +0000
stripe_lookup - first lookup used to stack_wind only to first_child, hence reporting wrong file size (cuased md5sum mismatch)
commit 23360f305bb39b3dfc060867c4bcf6dfa1f034b8
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 23 07:44:07 2007 +0000
protocol/server: server_reply_proc(): get bound_xl before replying to client since transport could be destroyed by then
performanc/read-ahead: for truncate flush within locks
commit 80561c1064912ecef8d4bafa95a05c75c2ade598
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 22 09:55:08 2007 +0000
glusterfs-fuse: add fd->inode_list to fd->inode->fds in fuse_fd_cbk
commit b7e21dd47bc882e313c767592c88cfe223954873
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jul 21 21:04:32 2007 +0000
io-cache: force cache revalidation on lk() calls
make forced revalidation timeout configurable in spec file
commit 274e8762c1ba1b5f3b4564a0c2d03a10c0e4d345
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jul 21 20:18:44 2007 +0000
logging enhancement
logging - make gf_log extremely cheap for cases where loglevel is > than set value (excessive usage of GF_LOG_DEBUG messages in code will be cheap when loglevel is set higher)
commit 11780f9efde60e5519e3d0a816ccd460615028f3
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jul 21 20:10:12 2007 +0000
io-cache fixes
* ioc_frame_fill - wrong calculation of 'count' used to cause heap corruption
* fixed locking in multiple places
* changed lock static inlines to macros for easier logging output
commit 4de882d1017dc58686e941b53aa02ded6e866941
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jul 21 00:56:34 2007 +0000
force flush-behind off in write-behind
commit d01b48e1a6f9eab3d88d7344345b8cc4a42acb55
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jul 21 00:21:07 2007 +0000
write-behind: delete context from fd before wb_sync
commit a19eaf574eff088181284c3dde52e083761f6374
Author: Anand Babu <ab@zresearch.com>
Date: Sat Jul 21 00:07:11 2007 +0000
removed unsed variable warnings
commit 96e9c6e2c5e161ab0a4b813a62ecd15a82b6d364
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 20 23:56:52 2007 +0000
handle GF_EVENT_CHILD_UP event correctly in transport
commit 14673ff11271ba9098933ceded690f148860b191
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 20 22:39:44 2007 +0000
fuse_xattr_cbk -use fuse_reply_err instead of fuse_reply_xattr to return ENODATA
commit d41bcf5534e6c9157fc895d096c08e3ea8a1db83
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 20 22:11:19 2007 +0000
removed the -1 in fuse_xattr_cbk as well
commit 38c018441dd58633378390c582446d3d043eaa3d
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 20 21:39:19 2007 +0000
fix in getxattr to treat binary data correctly
commit c1c26497292d283c26f0bcd29665e347657953e1
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 20 20:45:40 2007 +0000
unify - fixed bug in setting st_size and st_blocks in unify_buf_cbk when namespace stat returns the last
fuse - getattr: if inode has open file and is not directory, prefer an fstat
commit 6cd02efe4103dd9db7d0aac415f2e6c9781ccf3b
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 20 18:14:05 2007 +0000
read-ahead: added new 'option force-atime-update on' which defaults to off
posix: removed 'len - 1' during lsetxattr (complementary fix went into fuse_setxattr by changing data_from_dynstr to bin_to_data)
dict: removed couple of warnings
commit 95b40a78c2f98ff92a8e57f6012c6db6f8f741f0
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jul 20 13:12:58 2007 +0000
* is_cache_still_valid() now handles the case of empty 'struct stat'
* dispatch_request() differentiates between in-transit and cache-hit while doing ioc_page_wakeup() for case
when revalidation is not required.
commit 640c5565eb4d350a2f787720d152930dbbf149ac
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jul 20 11:24:00 2007 +0000
* fix for statfs failing case when 'df' is the first call after mount:
- now no one should use inode reference in statfs call.
commit 3f6e7883cfcfa95e27d762a29a732397fb1740e9
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jul 20 11:14:40 2007 +0000
disable read-ahead on random reads
commit c991afb7153b2d321caf0e7acd78149e049fda2d
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Jul 20 08:38:43 2007 +0000
handle SIGTERM in glusterfsd
glustefsd.c: handle SIGTERM. Delete PID file and exit(0) in the handler.
commit 1e72418ca5166ff61b14386ebaa14ea12785661f
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Jul 20 07:25:00 2007 +0000
Ported GlusterFS server to FreeBSD
configure.ac: Check for dlopen first in libc, and then check for libdl
FreeBSD provides dlopen in libc itself.
configure.ac: Don't abort if libexecinfo is not found.
libglusterfs/src/common-utils.c: check for HAVE_BACKTRACE before including
execinfo.h
xlators/.../afr.c: don't include malloc.h. It is nonstandard.
xlators/.../posix.c: Fix no. of args in SET_FS_UID_GID macro.
libglusterfs/src/glusterfs.h: provide definition for O_DIRECTORY.
configure.ac: Check if struct stat has atim, mtim, and ctim
(HAVE_TV_NSEC).
xlators/.../server-protocol.c:
xlators/.../client-protocol.c:
xlators/.../io-cache.c: use *tim.tv_nsec only if HAVE_TV_NSEC is defined.
xlators/.../posix-locks.h: Removed unwanted include of asm/types.h
[ADD] libglusterfs/.../compat.[ch]: Files to provide argp related functions.
--help does not work, however.
[ADD] libglusterfs/.../extattr.h: Alias {llist,set,get}xattr to their FreeBSD
equivalents.
configure.ac: check for fdatasync()
xlators/.../posix.c: Do fdatasync() only if it is available.
commit 7b833bc3743276cbb12db2959c926b4681d684c5
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 19 20:48:40 2007 +0000
warning fixes
use format string macros from stdint/inttype for cross platform compatiblity in dict
commit ef04f59a78ead880f71d567eac779126e0b4272a
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 19 20:25:24 2007 +0000
* added server-ns.vol and glusterfs-mode.el in Makefile.am
commit a57b07879d88b5b2c568be0da6eb2401eac76714
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 19 20:03:53 2007 +0000
fuse_setxattr - use bin_to_data instead of data_from_dynstr for value
commit 6edcb6bce59ac98f174e7ff74d08679f7574e865
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 19 19:27:35 2007 +0000
io-cache: lookup_cbk - fix to check for failure before doing dict_get on inode
protocol/client: send inode in callback even for op_ret = -1
commit 988400dd85c5eabb4919eace80c25ce9d7e3944e
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 19 19:13:36 2007 +0000
multiple bug fixes
afr: use 'afrctx' instead of fd->ctx in closedir
stripe_readv_cbk: update from *stbuf only if op_ret >= 0
stripe notify: propagate notification messages up
read-ahead fault_cbk: remove loop when op_ret = -1
read-ahead create_cbk: do not attempt read-ahead
io-cache fault_cbk: remove loop when op_ret = -1
check for op_ret -1 around ioc_inode__still_valid
check for page == NULL before increasing cache_used
protocol-client: return FD even when op_ret = -1
commit 83245470a03f8996fe4c910a2a8591325210b702
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 19 16:36:14 2007 +0000
merged from glusterfs--tmp--2.5
commit 36c602c196c77a8ab2cbb105957a9a4602fe0d26
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jul 18 07:26:11 2007 +0000
* Added checks in posix.c for successful return of stat/lstat/fstat calls before updating the inode->buf
* Return from the init (with return value of -1) of protocol/server if transport_load fails
commit fbfe8cb43453b7385877784c611ec45585a15087
Author: Anand Babu <ab@zresearch.com>
Date: Tue Jul 17 09:40:36 2007 +0000
fixed ib-sdp connection refused bug
* Packet family should be AF_INET_SDP
* Propagated connection retry mechanism from tcp-client transport driver.
commit f4fd756f092c686aa8da9d6c55b6f97b885aa07d
Author: Anand Babu <ab@zresearch.com>
Date: Tue Jul 17 04:06:37 2007 +0000
added THANKS file to Makefile.am and glusterfs.spec extra dist
commit 16709145c79d3d9cc5f3d857270658d3de7c3453
Author: Anand Babu <ab@zresearch.com>
Date: Mon Jul 16 13:17:20 2007 +0000
added glusterfs.spec.in RPM spec and THANKS file.
Thanks to Matt Paine <matt@mattsoftware.com>
commit 400a024e76476744801c01ce6937c6982a109d6e
Author: Anand Babu <ab@zresearch.com>
Date: Mon Jul 16 12:04:52 2007 +0000
version number to 1.3.pre6
commit 540bde4161e18c6c2d4ac41c097daede0cfc40eb
Author: Anand Babu <ab@zresearch.com>
Date: Mon Jul 16 09:09:32 2007 +0000
lex and fuse build fixes
* AC_PROG_LEX sets LEXLIB and it should be explicitly referenced in Makefile.am
* FUSE_CLIENT_LIB should only be used by LDADD and not CFLAGS
commit e1c11758cf3c532e73863d2c999369697fa107d2
Author: Anand Babu <ab@zresearch.com>
Date: Sat Jul 14 21:12:56 2007 +0000
remove glusterfsd fuse dependency
commit e4f0402460242c890d8037f5004fc729f1f1d0e7
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jul 13 10:12:35 2007 +0000
* fix in client_protocol_handshake_reply() (if parent is null, don't call notify)
* fix in unify_buf_cbk(), for the case of -1.
* minor fixes in unify and unify-self-heal for return value.
* cleanup in write-behind.
* changed configure.ac's version to 5.4 from 5.2
commit 04bd838a34e75fc9f9ffcaf890f08ae08cc8846e
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 13 09:05:29 2007 +0000
fix in posix-locks - pl_create_cbk used to dict_set inode_t to inode_t->ctx
which caused random memory corruption
commit 0c1b031217913c3e186ac9a43bbec1538bd90af7
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jul 13 10:36:03 2007 +0000
call wb_sync before STACK_WINDING in fops like stat.
commit 29626d8b1a891502ead09d941c3ff274bb1b7d5b
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jul 13 05:37:34 2007 +0000
fixed a typo in macro definition of freee. Was assert (free != EEEEKS) instead of assert (ptr != EEEEKS).
commit d749dc54e9982443f69653c6c7d9479d01261564
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jul 12 21:11:56 2007 +0000
* pages_used bug removed from ioc_need_prune()
commit 620c449e0c9353031ab078e58f31bc828d65f079
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Jul 12 15:24:02 2007 +0000
fixing a bug in fuse_xattr_cbk, getfattr command used to print junk when we tried to get value for an invalid key because op_ret was 43 though value is nt valid. But still there is a problem, op_errno by posix is being returned as "4" which is "Sys call interrupted". Needs investigation.
commit 2d0df2d71c0adcdb6b64b8658cf6ced91207e6a2
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 12 14:35:19 2007 +0000
added freee() macro to catch possible double free
commit 739fdd5d1801a4190a1d0dec32702350742ea10c
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 12 13:02:07 2007 +0000
handled pruning for MOP returning proc when bound_xl is not set
commit 8f22e492dc33f608ad62b73b3bedd4d58d6b56e4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Jul 12 12:57:56 2007 +0000
fixed a lot of FIXMEs. Also handling case gracefully when the child nodes die when self heal is happening.
commit d9659f945e9dc74e50a2cdce128eea96339e9b76
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 12 10:44:42 2007 +0000
setxattr/getxattr dictionaries are now unserialized from a memdup()'ed buffer
commit 4562cec69e25997ad5f069a984dc365766a7705b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jul 12 10:17:47 2007 +0000
* fixed io-cache to decrement pages_used during ioc_prune()
commit 8c89e928cad862601f04c0bf527420227f00ae3e
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 12 08:18:18 2007 +0000
keep inode refs until _cbk in protocol/server
commit a70c59541b89053af1530fafae5af4b854c0e192
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jul 12 09:30:57 2007 +0000
update inode->buf in client-protocol only if call is suceeded
commit 957952572c7e1e028cbe9381a8e9f199599a46a2
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 12 03:33:53 2007 +0000
* bug fixes in stripe. (handling op_ret == -1)
* added inode's stat buf update in both unify and stripe xlators.
commit af91081a9fc71030110369d4e1629f7b08ec799d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jul 11 17:31:28 2007 +0000
tail -f now works properly. added mtime awareness to read-ahead.c. Also modified posix and client xlators to update inode->buf whenever its possible in _cbks
commit 688f8cfe7ce1301e9a7aa00fb5cf140ca8e66be4
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 11 12:47:01 2007 +0000
* warning fix in fuse-bridge.c
* fix in unify_mkdir_cbk for setting the inode's generation number.
* fix in 'transports/ib-verbs/*'.
After the recent notify() changes and moving handshake to protocol translator, it never worked. It works from this patch.
commit 1e6326ed9ef62b19d553ff538976aadd6a202696
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jul 11 12:54:39 2007 +0000
fixed a type in io-threads
commit 80d707789015f27bc0007f4b376ded34c4ae299a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jul 11 10:22:48 2007 +0000
acquire locks before doing list_empty on loc->inode->fd list
commit 5eff3e8fe982237aa0b330d70e75a085a446984c
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 11 06:49:16 2007 +0000
fixed afr_forget bug introduced due to new forget semantics
commit 2cd74470cc76c6cb1db65789ca30e7cefde4da5c
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jul 11 07:17:22 2007 +0000
removed reply, meta threads from io-threads. Also retained only those fops that are needed by io-threads.
commit 3139cc5b28ab952b767fabaab82f6a23e1e8435a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jul 10 15:56:50 2007 +0000
minor fix in posix-lock (STACK_UNWIND should happen when open fails) and added GF_BUG_ON code to afr.
commit 9c9adbcd35e1026b15dbd640f95fb0137226d841
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 10 15:04:55 2007 +0000
* df -h output fix
* unify_lookup_cbk now doesn't return -1 if it sees file inconsistency, so rm -rf never fails. But while opening in a file it return's error.
* posix_lk returns ENOSYS instead of -ENOSYS.
commit e6a79fc6fa84de04d5166e905d8cc8911fcf65a2
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 10 14:03:09 2007 +0000
* some minor fixes in unify_mkdir_cbk()
* changed readdir code to return just the entries from namespace.
commit 7fa8b4c1ddfd08782fd6140e38ca1c5dedb9957d
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 10 12:25:35 2007 +0000
inode forget is put as a callback to avoid race conditions
commit 1edd47bc18ead560e5297969712f6d270d6c06b8
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jul 10 09:20:21 2007 +0000
fixed a bug in trace
commit 8cf2e1e2ea1235cc3d851902745421c1efb0994b
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jul 10 07:35:18 2007 +0000
* initialized the .mknod member of fops in stripe
* fixed segfault in unify_rmdir and unify_ns_rmdir_cbk with the xlator configuration of unify, stripe and posix.
commit fe2161d9b58d47fa475e6f90b57ff238b12dfbd0
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 9 15:56:16 2007 +0000
create call pool during glusterfsd initiaization and not on-demand
commit 5d175f4c0a248b81a73777353bba6296a9bcd4b8
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 9 06:57:53 2007 +0000
fixed issue when first client to server is not a valid client (e.g telnet)
commit 8f61b0fcb49f1ed551c9f9320b65d654b35eeed6
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 8 11:27:22 2007 +0000
avoid duplicate reconnection threads in protocol/client
commit ade9f0d227f1791f8ccc233d06998bcf88fbff28
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Jul 7 01:23:07 2007 +0000
* corrected some typos in doc/example/cluster-client.vol
* changed unify_unlink to send request to unlink to both namespace and storage node in one function rather than waiting to get return value of namespace.
* changed unify_rmdir to handle forgets, to avoid race condition arises due to using io-theads with unify.
commit 7cc60e1609feaea2ba053a2e9ca10a8fb55ffd4b
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 6 15:28:31 2007 +0000
fixes
* fuse_lookup - fixed per-lookup to happen on fuse_inode instead of child
* unify_ns_{rmdir,unlink}_cbk - break based on break count insted of list
commit 9c93fda83987a986153d8b0fa274071ec3989991
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jul 6 12:59:24 2007 +0000
* added writedir() in stripe translator. Without this, stripe couldn't be used under unify. Now, works fine.
* small correction in unify and posix translators.
* changed doc/qa/qa*spec files to work with the latest release.
commit 360c608f26f32e6302a7e84f749d68075dcb5dd4
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 6 12:28:31 2007 +0000
client_writedir - check for NULL fd_data and return EBADFD
commit 7839e2fb0b1aa66c326637e29da6910f8aa92d5f
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jul 6 13:48:02 2007 +0000
* Added SETFSID related macros to posix.c
* Added check for setfsuid/setfsgid in configure.ac
* Fixed some mem leaks in unify.c
commit 1e8aaed453b19a155eff9b9db3272598d32faeb4
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jul 6 09:00:18 2007 +0000
* io-cache deadlock issue solved
commit 376f19580af32fe0ccec80d9a9013fe8b8807ab7
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 6 07:50:58 2007 +0000
added extra logs to report frame type and op during unwinding from cleanup
commit 67ce378d69ee1763823102cefa4b0d2d98846e09
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jul 6 03:30:43 2007 +0000
* leak fixes in unify. (LOCK_DESTROY() was not done in some places)
* inode_unref(local->inode) in unify_ns_create() moved to unify_create_cbk()
* in unify_rmdir(), rmdir was sent twice to namespace, which was leading to fd leak.
* leak fix in posix_writedir().
commit e0a3cd335e32d9d99c9637b31c6ca229658dca87
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Jul 6 11:18:09 2007 +0000
commit 9b1148b05039338f33235dd0dc98848650add7ca
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Jul 6 04:50:55 2007 +0000
Propogating PARENT_UP event to the children of AFR. type/posix will send me back CHILD_UP event. So this fixes the problem where type/posix is used as child for afr and create fails.
commit 784547dd7c9676383b6449705be824ba72c9ecf4
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jul 5 11:49:38 2007 +0000
* ioc_frame_fill() SIGSEGV bug fixed. ioc_page_get() used to return offsetted address off ioc_inode_t to which the page belongs.
commit f8d43166ac5133c2cfbfd88311163fa637b60738
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Jul 6 02:41:18 2007 +0000
local->op_ret was initialized to ENOENT instead of local->op_errno :-(
commit fbf3ed66ab2e30cfa827693b08eff498c70a8c63
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jul 5 06:55:15 2007 +0000
never turn on direct_io in fuse bridge
commit 1fd88c042d50415c6426776f77d08f95c674cef1
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 5 03:30:52 2007 +0000
* bug fixes related to '-s' option of glusterfs.
* updated client spec file in doc/glusterfs-client.vol.example
commit dd55cad335d4daa0a510528a740c36c0e6800ace
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 5 01:25:43 2007 +0000
* xlators/performance/io-threads:
- removed iot_writedir(). This fop is not required to be queued, and this solves the problem of using io-threads below unify.
* xlators/cluster/unify:
- fixed bugs with unify_opendir_cbk() segfault in case of local->fd being null and local->failed is true.
- fixed a memory leak in unify_lookup_cbk. (This used to happen only in case of inconsistancy in file count is seen).
commit bfbf6a23ba2ff6e863ccab46c3bd92b1784557de
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 4 15:50:37 2007 +0000
fixed f_blocks/f_bfree/f_bavail calculation based on f_bsize scaled to BIG_FUSE_CHAN_SIZE
commit 70a24276a782826407be8ab6d27f43793211b0c6
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 4 11:15:10 2007 +0000
fix for rogue 'valid' flag sent from NFS re-export
fixed TRAP_ON warnings in dict.c
added frame->root->callid to be equal to fuse's callid, eases debugging
change 'int32_t op' to 'glusterfs_fop_t op' in parameters of client_protocol_xfer to display name of fop from the enum instead of number
commit 3f1f11398f635b040f0871f0f2edfb8e2621a1dd
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Jul 3 15:31:38 2007 +0000
check for op_ret value in truncate_stat_cbk in posix-locks
commit 913000c555200743878f613dbab56984a5244697
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 3 15:14:33 2007 +0000
added code in schedulers/* to update the framelist when new frames are created.
commit c74cf1674b3b18392c66f1fec36345c456cef06a
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 3 14:56:28 2007 +0000
list of all created frames in a pool for tracking lost frames
commit e5c55df65796397631739b31db676232410afdfa
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jul 4 06:56:14 2007 +0000
While selfhealing the permission/ownership, do it as root and later restore the permission of the frame. So that we dont get any EPERM error. Also check for (op_ret = 0) :O
commit e0e8885d357bde792e9fc2e62f7a69651f4f347f
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 3 14:18:20 2007 +0000
* a bug fix in unify_lookup_cbk(), during revalidate, when namespace lookup fails, inode_unref used to fail in assert().
commit 3524089a67e00f08ecf3405ee8f5c3638903a912
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 3 10:25:04 2007 +0000
* fix for reported bug in unify_sh_readdir_cbk, when op_ret is = -1,
* fixes in xlators/performance/* translators to take arguments as 1MB, 128kB etc.
commit 36454e1dc1080d4e732c2c291239b45636afd923
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jul 3 12:30:54 2007 +0000
Fix to sync permissions and ownership (is done during lookup)
commit 608212217e4c8a90b295c219f9a6d8a3d2df72b5
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 2 18:21:12 2007 +0000
proper fixes in server_inode_pruning (by Avati)
commit d28a9b4ffa991c859669e77e8b4386b5a82c32dc
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Jul 2 17:26:01 2007 +0000
fixed a bug in io-threads
io-threads.c: iot_ftruncate: allocate frame->local before calling stub
commit 3c21e6e1901efe7a2b96fae1fa2d1235b0c08f79
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 2 15:01:34 2007 +0000
fixed typo in fuse_readdir :(
commit 0ef2dcbe04bc4af6112545c8c80a3ad7e9d84ca6
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 2 13:16:43 2007 +0000
* removed 'inode_unref' in server_protocol_inode_prune().
* added check for op_ret != -1 in case of lookup_cbk of call_stub.
* changed EINVAL to ENOTCONN in unify for identifying child down status.
commit 8464cccadff5542eab999717317dfcb983010dce
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 2 13:00:36 2007 +0000
flush dentry data on rewinddir in fuse
commit 7d30260efb6a9bc782fa36762c84a323d7d55e46
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 2 12:22:12 2007 +0000
pre-lookup fix++, fixed $(docdir) in examples/Makefile.am
commit b6bd5d3e390ab976ac491f8f281b5ac774b6815c
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 2 12:03:11 2007 +0000
pre-lookup fix
commit d194e61308247f741a20d2959e96f0b20b391e5f
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 2 11:38:32 2007 +0000
pre-lookup for revalidate to avoid forget+revalidate bugs
commit b3ee6bb45cd6af1fa894dc75bfdbdd4795c96c0e
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 2 09:51:22 2007 +0000
fixed dict_destroy in setxattr's stub resume
commit 1a67d3f2f188cf0952d54f98492d8975975a2d85
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 2 07:24:06 2007 +0000
protocol/server - add locks around open_files, open_dirs
protocol/client - handle proper unref of inodes in case of server discon
commit 800d3d9aa49cfa6731f42cd6569ad768530c568d
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 2 00:00:33 2007 +0000
* fixed a bug related to local becoming NULL in unify_bg_cbk(). Wrong frame was sent to unlink in case of lookup finds inconsistencies.
* storage nodes' rmdir/unlink is moved to foreground. Earlier after the rmdir/unlink of namespace, it was returning and continuing the call in background. This caused bugs.
commit d3488b1bef968ed8a419d73a99f4c5d7dde3acdb
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sun Jul 1 09:24:36 2007 +0000
setfsuid/setfsgid works per thread context. Hence removed locks which were used while performing setfsuid/setfsgid operations. Also added #ifdef linux macros.
commit 69c0a3a47f05d61cedc3c8f43bd6830c4d84eaf1
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sun Jul 1 23:01:26 2007 +0000
* Bugfix for the case when create fails during selfheal.
* Selfhealing of symlinks.
* Bugfix for creating of replicas with proper mode during selfheal.
* Bugfix in posix-locks in pl_create_cbk (NULL pointer check)
commit e9a21ad7a7da34b82ce937385fc186ebe1bc15d3
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jun 30 11:10:25 2007 +0000
fixed server pruning not to screw lru_size
commit ab205e9c7c6e135c87e16c082047b2b12bc79358
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Jun 30 02:01:44 2007 +0000
* committing fixes for reported bugs in savannah.
bug id #20049, #20050, #20052, #20053.
commit 84a9e797a5d752aa536b12e226a0acea8fcfa8bf
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sat Jun 30 12:53:53 2007 +0000
When mknod gets called to create a file, during close it will now increment version to 1, previously it was getting set to 0 because of which it was not getting replicated when the other server was brought up and the file was opened. Also fixed a bug in fuse-bridge.c related to setxattr. setxattr logic is not correct (related to the way "len" of the dictionary is interpreted) in posix's setxattr it assumes that value is a null terminated string.
commit 56ec297f9efb97f3d60b3cd482bc13a08050d069
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jun 29 17:40:18 2007 +0000
* libglusterfs/src/call_stub:
- removed comments of inode_unref in lookup_cbk.
* few small bug fixes in server inode pruning to run smoothly with io-threads.
* bug fix in unify's self heal [fd_destroy (fd) -> fd_destroy (local->fd)]
* more enhancement in unify's self-heal, now it removes stale namespace entries.
* small fixes in nufa scheduler, and changes in unify's init to look for
the return value of scheduler's init.
* correction in unify's statfs. (used to send *loc directly to child nodes,
now sends proper loc_t value to client nodes.)
commit 26c34dd12e1b6dff62df5b64f88f61ecc247177f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jun 29 13:31:23 2007 +0000
* added dict_ref() and dict_unref() in posix_getxattr() for case having no xattr
commit 58a08eeedbdc0be79a6bb81c9e6a59f932c52b3d
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 29 09:21:57 2007 +0000
dict_destroy - leave it for call_resume's dict_unref in protocol/server
commit 273d59f11bc276677bf68c5d4551ec88af89948f
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 29 08:17:46 2007 +0000
makefile fixes
commit bce7d55f2e59192582e80b1cf54912abb4fb2a63
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jun 27 10:59:02 2007 +0000
fixed open-fail-cleanup code to handle 0-success case
commit 0236407908923ddc4fcd3804f7e5cccc2308a210
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jun 27 00:56:05 2007 +0000
* fixed ioc_table_lock() issue in page destroy in io-cache
commit af71b8e7615fb4413c01c631fa14ee2db57fb0ac
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jun 27 15:35:00 2007 +0000
One minor fix.
commit 0b7b12e1e85ddc24f4e16c92aeb35720c8433339
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 26 22:57:45 2007 +0000
dict ref/unref fixes for setxattr
commit cd823e63d17d2d75ede2dd6a60134dcc455c7bf8
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 26 23:01:56 2007 +0000
* fixes in writedir()
- in unify-self-heal.c,
client-protocol.c,
server-protocol.c,
posix.c,
call-stub.c,
* fix in unify's lookup_cbk ().. :(
- a silly comment put in my earlier patch removed.
commit 8ebdd381107596feab2b222f8374fc24eab2cd83
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jun 27 15:09:07 2007 +0000
Another bug fix :D
commit 02a685fc242108f636c26ac3894597ad08f05b9b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 26 22:30:42 2007 +0000
* added ioc_inode_lock/unlock() during pruning of pages in io-cache
commit bc999ab5cf41f4705b4c55fd0e78f8c8864da724
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 26 22:08:05 2007 +0000
fixed NULL check of dict
commit 2a39e02d051fb8d8498c292bd8fb1be1bfd446ba
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 26 21:49:46 2007 +0000
getxattr_cbk - correctly ref and unref dictionaries
commit cb88c0f5ec797769973df3e2a74add1f5522e9b5
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jun 27 13:38:17 2007 +0000
Removed a few debugs. last change for pre 1.3 release
commit c7d048b0a07e5ddce8aee439c04bb32e1f2ef299
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 26 20:49:17 2007 +0000
* call_stub: in stub_writedir(), call_stub_new () was called with argument
used for lk()( GF_FOP_LK should be GF_FOP_WRITEDIR)
* in unify_lookup_cbk () check for inode change if its revalidate.
* fixed a bug in posix create(). inode_unref was called even if inode is 0.
commit a5804440ccaef084f94345db594f182965b58a0b
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 26 18:38:16 2007 +0000
* mkdir() in unify is not done in background now, to work with io-threads
* enhancements for readdir_cbk. (if namespace entry is not there, it should return error)
* fix in server-protocol, in case bound_xl is NULL
commit a18b30ec98bc75d862d8db2de326b353d3977e91
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jun 27 10:47:17 2007 +0000
bug fixes.
commit afa5866d35bf6270a207eb1adaf5cd53b5575a90
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 26 16:45:28 2007 +0000
* fixed all build warnings
* fixed a minor string leak in io-cache
commit f8649be9dc72002ee27f94d465c303e06c8bacff
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 26 18:10:32 2007 +0000
fixed memory leak in call-stub. thread scheduling added to lookup in io-threads
commit 94da75cb2c5ceeef0af26755585e56be90fa30d3
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 26 15:36:26 2007 +0000
* removed all refereces to ioc_inode_ref() in io-cache
commit eb07c17d59d8de1b16a007e649fc620ac84d8b71
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 26 16:19:25 2007 +0000
uncommenting inode_unref in call_resume of forget
commit f0ccf47f1c1e087f033713a2dfef7db5bf15ab73
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 26 11:30:40 2007 +0000
* added inode_unref () in create(), which was causing memory leaks.
commit 9b2ff8c0eb8e690b7ca2d28fe742b33dbaca2c36
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 26 12:40:42 2007 +0000
added the transport name to gf_log in bail_transport
commit f52f74929a993335faa8152af1d8d14b858a8432
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 26 10:56:05 2007 +0000
any fop with a valid inode passed to it as argument gets scheduled to an I/O thread. Also fixed some tabbing issues in list.h
commit a8eb1be1a76a9ebab86aa3d9abc6070b7a637d95
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 26 06:35:19 2007 +0000
* leak fixes in client-protocol.
* sending stat only in case of op_ret >= 0 in server, and checking for stat only in op_ret >=0 in client.
* removed trash from build, as its not yet ready.
commit b5f11b77ca119fff14890207fd62b72f9f59dea2
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 26 04:57:16 2007 +0000
* fd_destroy() changed to lock and unlock properly for deleting from list.
* read-ahead changed to handle the case of dict_get () returning NULL.
commit 2c1c79d1be0cb3ba9d4dad72fe4364f484e58b28
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 26 03:35:35 2007 +0000
* unify_stat_cbk (): fixed a bug with entry_count
* stripe's fd list updates.
commit 9f73e161ae7cf327cc9b82566b007f590e98000e
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 26 00:54:47 2007 +0000
* moved unify's self-heal to foreground, which fixes the bugs related to partial namespace creation.
commit f7a7f28847ef3f174ad3a5901a4e1e09548687fd
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jun 25 23:43:41 2007 +0000
* schedulers/alu:
- a fix for the case of alu.limits.min-free-disk, which used to cause divide
by 0 error.
* xlators/cluster/unify:
- fixed issues with lookup(), in case of inconsistency in case of files.
Even open in case of create works fine. (this happens when EEXIST is
returned from create over namespace).
commit c24327f5075c1f1c1b631511a9da742396e56fcb
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 25 21:40:18 2007 +0000
check in posix_forget for (inode->private != NULL)
commit 35f63510a876be731b407d5fdbb8ab0d4dc621f2
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 25 21:35:53 2007 +0000
* removed fd looping in read-ahead truncate
* trick to ensure inode number not recycled by keeping fd open on unlinked file between unlink/rmdir and forget
commit acbba2a0a1ccef0f6db92d0038ff2caf7bfd2c3d
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 25 17:32:17 2007 +0000
fixes in call-stub
commit 5b8c04b51fb02dfbbd244841f07e07ba1d0843d6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Jun 25 17:29:01 2007 +0000
* missing frame found
commit 5ebaca09044a217cb5a3eebbe14cc948533221e9
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jun 25 17:30:44 2007 +0000
correction/bug fixes
* added 'doc/translator-option.txt' file, which lists all the options given in glusterfs.
* changed 'xl' to 'this' in afr's init() and fini().
* added 'option inode-lru-limit' to posix, unify, stripe, afr.
* correcting of indexes in write-behind & io-threads.
* added cleanup code in fini() of client-protocol, posix-locks.
commit 48e8d660780275f38b586a1015ae12d90b98259a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jun 25 14:50:06 2007 +0000
io-threads and call-stub now implements all the fops. Currently works with posix. bugs are surfaced when loaded on the server side along with posix
commit 26b34c41c08721d9ca99fc8d12f23bbf922132dc
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jun 25 13:10:39 2007 +0000
* enhanced unify's self-heal. Now its done only if inconsistancy is seen.
* corrected op_errno==EEXIST in case of create. Need to send open, but now
corrected it to do a lookup before sending open.
commit 0d7a2a37ea9a8769eacdc535a766ef365ad48e08
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 25 12:33:57 2007 +0000
fd_create/fd_destroy wrapper functions
modified posix, client-protocol, unify to use them, afr and stripe pending
commit c9423feacab8558ab7717e3342c56a1ea64cf2be
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jun 26 04:34:53 2007 +0000
changing user.trusted.afr.* to trusted.afr.* "attr" command misguided me :-(
commit 7f39584c0c2a1870b820994ca2c89610f44ebb78
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jun 26 04:04:18 2007 +0000
making inode->private 0xffffffff in afr_forget. also we should not delete inode->private in case lookup_cbk fails in case of relookup.
commit 6e1d54d2509b1d6ec39c06b8479e4e35ca406718
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jun 24 21:57:55 2007 +0000
* xlators/cluster/unify:
- enhanced self-heal code.
- fixed a segfault bug caused due to fd->inode_list list.
commit 6faced886f27f94cea7362f0f3d611c82129f889
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jun 24 21:16:11 2007 +0000
fixed typo in fuse-bridge.c
commit 5c50e747a312f32d28a7f620775cbb39061037b2
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jun 24 19:54:52 2007 +0000
* disable flush-behind in write-behind by default
* send 1MB as blksize in stat replies to fuse kernel module
commit c0ef1a19dff9d0d2d478477ebecb63d68d6a2f7f
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jun 24 13:03:14 2007 +0000
* xlators/storage/posix:
- writedir () : removed setfsuid code. It needs to be done as only 'root', and need to do chmod and chown according to each entry.
* xlators/cluster/unify:
- enhanced opendir_cbk ().
* xlators/debug/trace:
- printing loc->path where ever there is 'loc'
commit 69ec7c381e7feea7ad84df2460b316191c659c49
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Jun 24 02:12:10 2007 +0000
* added ioc_cache_still_valid() to compare ioc_inode->stbuf against stbuf given.
- used by ioc_fault_cbk() and ioc_validate_cbk()
commit 5bbb4bb49faaf238b84c24ed8e2a34826c05fe2a
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jun 24 01:12:00 2007 +0000
protocol/client: look for 'marked' dir fd in case of server disconnection
commit 9389602a811ff39e74a8d87f3884006871ff36e9
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Jun 23 14:02:49 2007 +0000
* page wakeup was being done outside inode lock in validate_cbk()
- caused call frame leak on the page queue
commit 947f6b85aa1a153292f8f764d69f0b478366d17a
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sat Jun 23 10:26:21 2007 +0000
buffer ovverrun fixes in posix.c, poll.c and some cleanup in write-behind.c
commit 873ea9a5cd573b4ae4fbfc72570638f3e2ba6ed1
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jun 23 00:35:05 2007 +0000
fixed local allocation in truncate() in io-trheads
commit db0a5a487388b6a77360eb77904f0926546f1345
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Jun 23 00:29:45 2007 +0000
* removed readv_continue in io-cache.
* cache validation is done per page now, earlier done per frame.
commit 991565f32e93465812ca28e3d19acb9a11b3669e
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 22 20:17:00 2007 +0000
locking fixes in io-cache, delayed marking of waitq to avoid pruning races
commit 1cebe05ba228e22f078c585122c92c29c58c68fc
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jun 22 06:39:19 2007 +0000
* locking bugs fixed in io-cache
commit 17e8e2746732723e905ba071519dce2bb9379dad
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jun 22 03:32:08 2007 +0000
* fixing mistake number n, where n is huge.
commit 70235d9eb51177c39bb5ce0994636a53e4c7ee73
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 22 03:08:54 2007 +0000
fixed minor memory leaks in
- io-cache
- read-ahead
fixed log messages formatting in transport/tcp
commit aa7317c7c952595cb472f5f34bd5d853613dbd8e
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jun 22 02:48:26 2007 +0000
* removed the debug log file creation in io-cache
commit c597686f7c6a268d28a0bb3eb30aa230a4813131
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jun 22 02:29:21 2007 +0000
* removed refcount for ioc_inode_t
commit 1393929e08853462204b9929836374256d9033c2
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 22 01:03:11 2007 +0000
fix in fuse_fd_cbk
correctly sends close() and closedir() according to st_mode in stbuf when EINTR is received to application
commit 0a337f6315fd8e60a996845a8b350faabc318c83
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jun 22 01:00:11 2007 +0000
* waitq frame cleanup in validate_cbk() of io-cache
commit 90156eddb9e41f4ab1f1846a8bcc103f779eb471
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jun 21 23:00:20 2007 +0000
* fix in fuse-bridge to handle xattr_cbk correctly
* temporarily disassociated inode->fd relations
* removed unnecessary error message about notify() missing (changed to warning)
commit 05bf14b63e01f115a5ef7f95dc2b3824c8f58340
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 21 21:30:17 2007 +0000
* read-ahead over io-cache works now
commit dcd3992ce04883c638b11e20d74b1db094f0bfc2
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 21 17:39:34 2007 +0000
* correcting the tla commit problem
commit c96026c41ea264bf0bfb7f8f4d9593cf3d1a927f
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 21 17:10:01 2007 +0000
* changed io-cache internals
commit 5ffdb0e534b9340105a1d0badba8f33ae9e4fb77
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 21 17:00:41 2007 +0000
* changed io-cache internals
commit bbf6c7371c3c44b817f12d814bfb741d918c8156
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jun 21 17:00:50 2007 +0000
added cleanup of open directories in server_protocol_cleanup
commit e23949c3364c599df9b9de7541db787be0946dcc
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Jun 22 07:46:31 2007 +0000
Fixed inode mem leaks
commit 1a187182129c42121e714626226b1aac5710f996
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jun 21 16:08:43 2007 +0000
buffer is unrefed in call_resume_unwind of writev only if count > 0
commit 075fb290b89f3ae9cd6590bf6035b9d30ec2d795
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jun 21 10:43:31 2007 +0000
readv_cbk in call_frame_unwind is made to dict_unref the response only if read is succeeded
commit abac5407fa3a7dbae4382a0849ab4c98e83e76e6
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Jun 21 08:55:01 2007 +0000
fix inode_unlink call to be called only if op_ret == 0 in fuse-bridge
commit a95f05a0b85f022a96aedd9c49fbecb7b0a7c3e6
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jun 21 07:12:08 2007 +0000
* xlators/protocol/client-protocol:
- a leak fix in open/close (made remote_fd str to dynstr)
* xlators/cluster/unify:
- enhancement to correction in open and close.
commit 9c8be28aaf651bc70b24031b8b78a2f48b8478cb
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jun 21 05:10:46 2007 +0000
* leak fix in writedir () of server protocol.
* updated doc/examples/* with the information about changes in unify translator.
commit bfc9e55d7d29de46a2352e5ac6af7d697ebb58b2
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu Jun 21 18:10:34 2007 +0000
bugfixes for setup where we use posix directly under afr.
commit fef49d8a77f362bf8c28ee094526a47214828bac
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 21 01:23:08 2007 +0000
* io-cache now validates only if cache hit happens.
commit 1ecb11daa770fa850eb1e4615c87199527590372
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jun 20 21:04:47 2007 +0000
memory leak fixes in protocol/server
commit 7d446cbccab6d25c71cf87a50def0ef66c462ec3
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jun 20 14:44:02 2007 +0000
fixed mem leak in call-stub for writev and readv_cbk
commit 5143c2d0ccd46551210af36b6d6d834805d9fe75
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Jun 20 11:16:54 2007 +0000
* scattered inode pruning into callbacks which get inode_t as one of the argument in protocol/server
commit 66554850cefcce2615eb90c686b11cac1cfddf85
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jun 20 10:38:51 2007 +0000
bug fixes.
* many small bug fixes related to handling op_errno in case of op_ret == -1
commit ec9f7568a593bfb12412da91632dae567b0f27a4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jun 20 23:49:02 2007 +0000
afr changes (bug fixes, clean up). call-stub call_resume() implemantation for readlink
commit e1ee0cb2c6b8dbc5418a7585b154ebf25844a836
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jun 20 01:44:52 2007 +0000
fixed frame->local = NULL for server_rename when both inodes are found
commit bf8fa7da4234afe7891c07c541d1b3b770a2a819
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 19 22:18:58 2007 +0000
* fixed ghostly disappearance bug in protocol/server (return 0)
commit 379f5cc6d20f13d73d5ebcfcd598d1b55c51040a
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 19 21:40:10 2007 +0000
io-threads - fixed missing stub creation in flush
- fixed logging format
commit dc9f14334cccf3f7240f5243b8bea7bcbb6f5ccb
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Jun 20 12:52:48 2007 +0000
commit 2f9dfc56fbe7e349336596a8d4441f6077d008fe
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 19 21:14:42 2007 +0000
bug-fixes in io-threads/call-stub
commit d4d6a89594937a3874b79ed195e4dfe2a8c8bba2
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 19 19:31:54 2007 +0000
* used call_resume in place of STACK_WIND, whenever calll_stub is created in
protocol/server
commit 06bc0e97a1918ebfd6a76c4b77f76d2b77abf57b
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 19 18:45:50 2007 +0000
fixed lru_size getting -ve in protocol-server
commit 166eb53a7165a2c0e4f45479c4616c72a539da67
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 19 19:59:25 2007 +0000
added lock_wipe, inode_unref
commit e88cf398fae78a3b404dfe9b96ae91c8715efc9d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 19 18:39:51 2007 +0000
call-stub
commit 6aee75748bc0c50af40f1b098325f9501b745920
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 19 16:23:22 2007 +0000
protocol/client: avoid creating two reconnect threads in race condittion when handshake fails
commit e97bb2e87ae21595b33ba05a4ae2d806ab2d4d46
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 19 15:14:25 2007 +0000
fix in client_close and client_closedir on 'stale' fds
fix in client_protocol_xfer to call the callback instead of STACK_UNWIND in case of transfer failure
commit 51400797439c3c2e2d106bdbee92d751c792a57a
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 19 12:36:32 2007 +0000
* lot of inode_ref() & inode_unref () balancing
* memory leak fixes
commit 8689a02f5719c4110360a3bde26330b74130007b
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jun 19 06:43:20 2007 +0000
fixed notification event type (from 'default' to GF_EVENT_CHILD_UP)
commit cff6cb9c4dacb9f29df7a6af0f018e0c3d07509a
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 19 04:10:11 2007 +0000
* procotol/client
- fixed issue of missing inode_ref() for inode kept in frame->local
commit 0e1c28a9ef8d146973684e730d32ce2e4555b072
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 19 00:01:35 2007 +0000
* protocol/server
- fixed leaks due to control flow path change at call_stub.
- fixed rename bug
commit 59da7c44a9d2cdd25e13accbb32b82f52fcfdeaf
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jun 18 22:38:43 2007 +0000
* fixed a leak in client_protocol_writedir ()
* moved LOCK(), UNLOCK(), LOCK_INIT(), LOCK_DESTROY() macros to common-utils.h
* fixed memory leak bugs in unify and stripe xlators. Works without memory leak now.
* fixed 'trace' xlator to handle the case of 'op_ret == -1' when de-referencing struct stat *stbuf.
commit c97361a890ea3c6238e4aa1f4263f2ee81c93101
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 21:25:40 2007 +0000
fix in inode pruning
commit 631d0e0bc6d1ad50315089647261fea571cb663e
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 20:32:46 2007 +0000
fix in posix for setfsuid in readdir
commit 2730315bb800c9253e5ea38bc6f0c4b834853ae2
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 20:23:41 2007 +0000
fix in default_link
commit 14cabd82fdda46823ca52d1c972755dff885ecd9
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 20:11:10 2007 +0000
typo fix :(
commit 32a52071e32429dec53e02a90732773e5ff06d49
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 20:03:50 2007 +0000
minor fixes in protocol/server
commit 4093606a3f036839e210a820f069186edf59cf5d
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Jun 18 19:32:08 2007 +0000
* server protocol call_resume restructured
commit a7b21a04f6762470feb357d029aaa38c82c9a259
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 17:18:49 2007 +0000
fix in posix to create lock in global context
commit 32edf3e1fdf34aa76891f1f15878c39e24f634a3
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 16:53:00 2007 +0000
typo in glusterfs-fuse fixed
commit 914a380950e23c240856cc0574f3c5af54711706
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jun 18 18:23:47 2007 +0000
fsuid/fsgid related chages
commit 83eadb0c55a75cccbd8586aede9474895e9dcd39
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 16:39:59 2007 +0000
call inode_unlink for unlnk and rmdir cases in fuse
commit db15f51cf96f299994467979b27240654e299d26
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jun 18 17:41:48 2007 +0000
posix uses locks while performing setfsuid/setfsgid
commit 0e62ba5d9fa61b1444131f8c519549b6dcc62a8e
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 15:41:12 2007 +0000
fix in rename in inode.c and fuse-bridge.c
commit bb35546f437d30a9da5b7a758937f146305d2ea3
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jun 18 16:56:58 2007 +0000
undoing patch-138 and 139 which were causing build breaks
Keywords:
commit b7a2eb0ae631f395937869c686c80b962f9a9d09
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jun 18 13:56:02 2007 +0000
moved mutex initializations to posix
commit a30dfc9da8adde3ed9d9f44efb0fb730a55e3563
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jun 18 13:20:46 2007 +0000
perform fssetuid/fssetgid operations while holding locks. fssetuid/fssetgid are not needed while performing fops on fds
commit e75f53ca17ac08001efee392294465c09f8da2c7
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 10:45:18 2007 +0000
inode.c fixes in forget
commit 326bda3ed0ad4bff5dfa61a793075169dcdce8a3
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Mon Jun 18 09:35:16 2007 +0000
setfsuid/setfsgid related changes to posix
commit 5517e3735ea5109938127ccd33f6fd787afbed9f
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jun 18 01:06:47 2007 +0000
write-behind: fixed data_from_ptr to data_from_static_ptr
commit c6af2dc63562561c43c098833ad0708e0e00ad35
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jun 17 23:49:19 2007 +0000
fixes in write-behind about looping on inode's fds
commit 708ff8ce8dd8b221c234b41afa813d5668f549a1
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jun 17 21:04:10 2007 +0000
mem leak fixes in protocol/server - opendir_cbk, open_cbk, create_cbk
commit 0deec798d6fb29feb5f77505ea636756ad1f781b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Jun 17 20:46:58 2007 +0000
* saakashTu bEdi nittide
commit 2b7fbc61276071e70b5a568c6a3ff0c9c678a58a
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jun 17 20:40:17 2007 +0000
mem leak fixes
commit c7cc62c2e08ea4775222c0cdc3d8142bc2a39623
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Jun 17 20:02:08 2007 +0000
* client mattu server eraDu sikkapaTTe hEltive.
commit c2ef6746e25d1c7e6b1889f44cb196201545a7ee
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jun 17 17:45:35 2007 +0000
removed queue limit for reply queue in io-threads
commit 067991cbb4bb49659b0b1e0e29b21d0f1a8822af
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Jun 17 17:34:18 2007 +0000
disabled building of user-guide and hacker-guide
commit 9097e903403c18a0a4e2a1debe5ea466563930e7
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jun 17 16:58:31 2007 +0000
* stripe_create() and stripe_open() uses 'xattr' feature for maintaining
information about stripe-size, stripe-count, stripe-index.
* uncommented 'afr' from xlators/cluster/Makefile.am
* little more enhancement in getxattr() of client/server protocol.
* minor bug fixes.
commit cf89447d4b828fe8881555388b7d9bbc48059e07
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jun 17 15:21:54 2007 +0000
proactive reconnection
attempts reconnect after every time T where Ti = Fib(i), i is the reconnection attempt since latest disconnection.
commit 351b0727f5c44417f83f998815a64ea1ff9ca54c
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Sun Jun 17 13:53:44 2007 +0000
Fine tuning of client Bailing out logic
commit 74f0ca1def9a01194021068cf13f8e6f627d7f12
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sun Jun 17 16:08:23 2007 +0000
afr self-heal works somewhat. But still needs loads of testing. I see few segfaults here and there.
commit 3406038d256a9b90c4db72b0ee93c7b3d741ce8a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sun Jun 17 14:32:27 2007 +0000
fuse-bridge.c - release() should do FUSE_FOP, not FUSE_FOP_NOREPLY | afr.c - chages for selfheal | client-protocol.c - bug fix in client_create_cbk | posix.c - bug fix in posix_getxattr() it had a race condition problem
commit eb9bb30ccf9c041b38f6a5ee9f500406c868e38c
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Jun 16 18:05:05 2007 +0000
fixed doc/user-guide/Makefile.am
commit eb47b0500f9844d01fc16761f481bfce9e258d88
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Jun 16 17:19:39 2007 +0000
commit 9b62b813bd57c576a6525d9ad717dafc2f344ef6
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jun 16 14:17:02 2007 +0000
reconnection logic fixes
commit 822fab62313200a1326e9e42727ac1e9929d2a86
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Jun 16 13:40:19 2007 +0000
* libglusterfs/src/dict:
- added free(*fill) in dict_unserialize.
* xlators/storage/posix:
- fixed getxattr in case of return -1, 0.
* xlators/cluster/stripe:
- fixed a bug in write.
- small fixes
* xlators/cluster/unify:
- changed return value to 0 from -1, in case of EBADFD.
commit 5db24d6b1b78f9d8f4588c6c80b78c308620a020
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sun Jun 17 05:38:27 2007 +0000
Intermediate checkin. also a small fix in client_getxattr_cbk
commit 0355e089e99648bade755ac2883dff68b7523289
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Jun 16 04:20:04 2007 +0000
added user-guide/ and hacker-guide/ to doc/
commit 9177446be8d9b4042035c18bb7a6a3add64e3a11
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Jun 16 00:56:05 2007 +0000
* cache_validate quequeing implemented
commit 70cac2a92c802ca251b384f909fcff7a2ec030eb
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 15 23:00:59 2007 +0000
reconnection logic fixes in progress, handshake moved to transport
commit cbddf1428b96d07b8f4c23791003cf7742b1b6ff
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jun 15 22:31:44 2007 +0000
* fixed memory leak in io-cache
* fixed memory leak in protocol/server
commit d28391fc93688a18c9e5e3a1ab264fd0d31f87ea
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jun 15 22:13:45 2007 +0000
notify ()
* xlators/cluster/unify:
* xlators/cluster/stripe:
* xlators/storage/posix:
- added 'notify()'
* ----
- some changes in inode structuring
> removed 's_h_required' flag from inode_t, added 'generation'.
> using 'generation' flag in unify for self-heal instead of s_h_required.
* xlators/cluster/stripe:
- added code to return 'UNWIND(-1, EIO)' if first child is down in many cases.
commit a07fa4f68005a22a2d4666cc70cf661f7980b742
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jun 15 19:04:48 2007 +0000
* fixed bug in xlators/protocol/*, setxattr() and getxattr (). Works smoothly.
commit 4c7555d9b144dea0ca8d961296cba989fae892fc
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Jun 15 17:34:09 2007 +0000
fixed a couple of bugs in posix-locks
commit fe746d7437f5450c93289f82a180c0a36bcac20c
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jun 15 17:16:20 2007 +0000
* libglusterfs/src/*:
* xlators/cluster/stripe:
* xlators/cluster/unify:
* xlators/protocol:
* xlators/storage/posix:
* xlators/debug/trace:
- changes related to xattr.
> Removed fops->listxattr().
> Changed argument to 'dict_t' for key:value.
* xlators/cluster/unify:
- Enhanced self_heal.
- Bug fixes in readdir_cbk(). Added code to get inode number from namespace.
- corrected lookup() for revalidate.
commit 9a111b17a5df8ecb6ed065188dfad261232e6e8e
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 15 03:23:40 2007 +0000
inode_update api update
commit 24009b1d4162cc78ce62da1af45290ab5cc19f0f
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 15 02:48:39 2007 +0000
writev/readv changes
commit 9e5aaf138b7cb419179d8c0368046b8c96a0f2b0
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jun 15 01:55:19 2007 +0000
* added struct stat * as last argument of writev_cbk
commit f2a65a369e4a3e07ea63667750cdbaf285af0b9e
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jun 15 00:25:44 2007 +0000
event notify framework
commit 97f4e525fa52e3ac1a06a86433f00b2de77510ad
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 14 22:22:00 2007 +0000
* FIXED FIXMEs, sometimes required, sometimes not required in read-ahead
commit 4c75ffaad5971955e110f5604220d216d04afb16
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Jun 14 18:30:30 2007 +0000
ported posix-locks from the inode_t to loc_t interface
commit b3923cbf8e22e6574087a9c60dede9591d01faa6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 14 18:21:49 2007 +0000
* fixed io-cache build errors
commit 05fd50afd14aea4bbf0cfc3ca6ccc791f0ad6603
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 14 17:05:48 2007 +0000
* added io-cache translator source
commit e83cf11463415b5c9f2c2ca808024b5ac886db9a
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 14 16:48:17 2007 +0000
* changed API of readv_cbk
commit 41138877813c097bf3dc5f040931b7a9e0aba283
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jun 14 07:44:38 2007 +0000
struct timespec related changes to defaults.h posix.c filter.c which were missed in my previous commit
commit 6f75a7c7771f1839a25b20d8f481a5ba04f074bc
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jun 14 06:30:51 2007 +0000
Undoing struct timespec related changes to fop_writev, fop_truncate and fop_ftruncate
commit 65e13b3adc8ef3034d48e238cd61b4c0d15ca0e7
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Thu Jun 14 05:24:12 2007 +0000
undoing patch-95
commit 1699ed579679714a4b2a5d6866f63dd6b4f10a83
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jun 13 21:02:57 2007 +0000
* libglusterfs/src/*:
- edited the licence.. added year 2007 in (C)
* xlators/cluster/unify:
- more correctness.
- added O_EXCL feature for create.
commit 3851526adc0be346a610d28ae7b6494c0669d924
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jun 13 15:45:49 2007 +0000
* libglusterfs/src/*:
- fixes in output of 'gf_log'
* xlators/cluster/unify:
* xlators/storage/posix:
- bug fix with new changes done for 'struct timespec' in truncate,
ftruncate, writev as arguments.
commit b287fc68f53b637dec4b00941a4a530431450613
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jun 13 13:44:12 2007 +0000
added data_from_int64 to dict_set in writev, truncate and ftruncate in client-protocol.c
commit abdc2ae176ffebb4b2a46bd767f9dfdec1c1251d
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed Jun 13 12:37:24 2007 +0000
Check for timespec parameter being NULL is added to client and server protocol and some tabbing issues resolved
commit 8456abee3fd98afa841fe7abeda19c8946c6c15c
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jun 13 09:31:28 2007 +0000
client-protocol
* xlators/protocol/client-protocol:
- fixed a bug in client-protocol-cleanup.
commit 96953f84d461a98dade417d0b87c6f80bb4b5bd6
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 12 14:06:08 2007 +0000
* xlators/debug/trace:
* xlators/protocol/client:
* xlators/protocol/server:
- added 'writedir' fop.
* xlators/src/posix:
- enhancement to 'writedir' fop.
* xlators/cluster/unify:
- self-heal working properly.
- yet to implement 'notify ()', waiting for the patch from kr1s/avati.
* schedulers/*:
- changed 'min-free-disk' option from free space to free-space percent.
-> ie, it got changed from 'option x.limits.min-free-disk 5GB' to
'option x.limits.min-free-disk 5 #%'
* libglusterfs/src/:
- changes done to remove the warning.
commit 1c8378ea053d97fc3b7f7d1e68dd22ca0f50d0d6
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Tue Jun 12 13:21:14 2007 +0000
Added "struct timespec tv[2]" parameter to fop_writev, fop_truncate, fop_ftruncate
commit 9260ab3bac6e1ca7c9babeb326409e74ae21d94b
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jun 12 01:14:06 2007 +0000
An intermediate checkin. Just in case I lose my local repository. Also fixing a bug in client-protocol, inode_update should not happen when lookup_cbk returns -1
commit dec17e7c669ef19fdc89bc02e877174ea2bf3b49
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Fri Jun 8 14:15:16 2007 +0000
commit f8041cc0954780d201001065f02ab0c6121672a4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sat Jun 9 02:17:36 2007 +0000
Intermediate checking, incase i lose my local copy.
commit 407c0fa85216bb2f0dc59539f36561b9a50f76da
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jun 8 04:15:13 2007 +0000
* xlators/features/trash:
- not yet ready for usage.
- basic changes for new API changes done.
* xlators/cluster/stripe:
- Bug fixes.
- Code cleanup.
* libglusterfs/src/common-utils.h:
- changed 'roof' and 'floor' macros to handle divide by 0 error.
* configure.ac:
- changed version from 1.3-STABLE to 1.3.0-pre5
commit 6520c544fa75ddaf38d60a184a2bfb0c7782b6f9
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Jun 7 15:52:01 2007 +0000
* changed call_resume (call_stub_t *, void *) to call_resume (call_stub_t *)
commit 823fcd0d9f4c8a54226f6f17b1da56dfa2523a49
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jun 6 16:14:11 2007 +0000
* libglusterfs/src/defaults.{c,h}:
* libglusterfs/src/xlator.{c,h}:
* libglusterfs/src/glusterfs.h:
* xlators/storage/posix:
- added fop 'writedir'
* xlators/cluster/stripe:
- removed warnings.
* xlators/cluster/unify:
- added self-heal functionality.
- clean up and more comments.
commit 99ef903f5cca64dd2ab3a21bfeb63a2fa83010ec
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Jun 5 20:03:41 2007 +0000
* protocol inode_ref & inode_unref fixed
* server memory leak fixed
commit 4c4711a2f752040bb8c983d672af71dc7e4b1ca9
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jun 5 13:59:37 2007 +0000
* libglusterfs/src/timer.c:
- patch by Anand V. Avati
commit 1ac3f876bcd802f263cee3e13b8b3274d0e68836
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Jun 4 13:15:33 2007 +0000
* during initialisation, return value was not handled
commit 178f15c82214af0c48132d2a9dcecd2a30156b6a
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Jun 4 10:31:40 2007 +0000
* protocol
commit dfccd78115ed0e1425f062bd9075230b9125b622
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jun 3 06:28:43 2007 +0000
unify
* xlators/cluster/unify:
- changed code according to review.
- readdir* code changes pending.
commit db8881d71c8af2800fcc0733a98d32a0fe3e6767
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Jun 2 13:42:00 2007 +0000
* cleaned up protocol source code
commit dd651f3cfc017ab74bdd8803249e500794240b1f
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Jun 1 23:34:48 2007 +0000
Another intermediate check in, comments have to be added, FIXMEs have to be fixed, and inode_unrefs should be done at correct places (inode_unref is not at all being done now)
commit 9f3d2da4a38c326b54ed981907eeb7e0d64e116c
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 31 20:46:38 2007 +0000
unify _almost_ complete.
* libglusterfs/src/dict:
- added a function 'data_from_static_ptr ()'
* xlators/cluster/unify:
- removed warnings.
- rename fixed.
- all inode_ref/unref related errors fixed.
- memory leaks fixed.
commit 961a4d96c428e254264e58a80152a17308a81a15
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 31 15:16:39 2007 +0000
* xlators/cluster/unify:
- minor bug fixes.
* xlators/debug/trace:
- changed to '%lld' type for all the offset variables.
* xlators/performance/Makefile.am && xlators/features/Makefile.am:
- removed compilation of trash, io-threads, posix-locks, stat-prefetch,
so just 'make ' will work fine on glusterfs tree :D
- once these xlators are ready, enable them.
commit 927c5190b681d64c821e96db595a118f9166451e
Author: Raghavendra G <raghavendra@sv.gnu.org>
Date: Wed May 30 14:40:21 2007 +0000
inode related changes to read-ahead, write-behind, filter, fixed-id
commit de7b05a38b907df3813edd1a9add9ca16d749e04
Author: Anand V. Avati <avati@80x25.org>
Date: Wed May 30 08:44:12 2007 +0000
fixed rot-13 xlator to use new API
commit d9e4aa3f49b01922e5aa6c94ce4ac962fa5be84e
Author: Amar Tumballi <amar@80x25.org>
Date: Wed May 30 05:59:32 2007 +0000
stripe
* xlators/cluster/stripe:
- fixed issues with inode-ref/unref. Now follows how its done in posix.
commit a684d2f8f3823ca6cacee22636bf39a8fa4fa5f0
Author: Amar Tumballi <amar@80x25.org>
Date: Tue May 29 18:56:32 2007 +0000
unify works :-)
* xlators/cluster/unify:
- other than 'rename' all calls work.
- followed posix to ref, unref inodes.
- observing some memory leaks.. need to fix.
* xlators/cluster/stripe:
- if there is pattern miss match, file will be created only in FIRST_CHILD.
- more testing needed.
- yet to complete setxattr/getxattr feature for block-size, order of creation etc.
* xlators/debug/trace:
- removed 'option debug on' option.
* xlators/storage/posix:
- added 'inode_unref ()' in case of fops->link.
commit 290258cad3fe3b1fc3071e85c476d8b50a3e03e2
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 29 15:13:03 2007 +0000
fixes in fuse
commit 28776491a673360188fcee62cbc305a506619269
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 28 16:02:16 2007 +0000
* xlators/cluster/stripe:
- Still need to finish tasks related to un-striped file.
commit 3056fabec388e1bb2fee3a475184efe08a0c8e49
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue May 29 07:45:18 2007 +0000
* client protocol does not use frame->local
commit 1173a804d71a3ca5217f4f0987fee9747ef60ede
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue May 29 03:42:33 2007 +0000
* read/write works through protocol
commit f545f11ca9a2d25a21c04c2f870791461ebf3119
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue May 29 01:03:27 2007 +0000
* protocol
* client protocol segfaults. REASON: frame->local points to a local structure and the local structure contents are gettting corrupted.
commit d2084b5d3d11f2fe56644b3f03534ca36c994f8a
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 28 07:41:19 2007 +0000
coding complete for unify/stripe. Testing pending.
* libglusterfs/src/inode.h:
- added a field 'isdir' which is used by UNIFY.
* xlators/cluster/stripe:
- basic commands 'ls' open, writev works.
- more comments to be added.
* xlators/cluster/unify:
- using 'isdir' whereever required.
- testing pending.
commit a27355c43d5e5a738d4d8a1ac74cf3b610596770
Author: Amar Tumballi <amar@80x25.org>
Date: Sat May 26 21:13:32 2007 +0000
* xlators/cluster/unify:
- fops complete. more comments needed.
- testing in progress... some segfaults has to be fixed.
commit 27bed61e27d25eec41c0926002b4a0a65c23433e
Author: Amar Tumballi <amar@80x25.org>
Date: Sat May 26 20:12:19 2007 +0000
* xlators/cluster/unify:
- most of the fops complete. Testing in progress.
commit 686fcd8dcc656ef9e103848e080881ba12834df1
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun May 27 05:35:19 2007 +0000
* Server procotol changes to comply with loc_t based fops
* directory related fops work
commit 6836c557bd42833cf014bee72c6d713691c18022
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sat May 26 03:09:49 2007 +0000
AFR with inode changes, the file compiles. Need to make code pretty, need to test, fix bugs and checkin again. This checkin is being done just in case i delete my loca copy :P
commit c971636c5e5b2f3882563d3abde01d18d6f7ebaa
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 24 22:19:19 2007 +0000
unify - intermediate commit.
* xlators/cluster/unify:
- lot of _cbk functions are pending.
- NOT TESTED - NO WARRANTY TO WORK :|
commit 280632a125ad99651094c7c1e05b40d1ad1e5294
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu May 24 20:54:58 2007 +0000
* Added call-stub.h
* Added call-stub implementation to server protocol
commit 6e348f23498701e2ec76de5165fb501f5b29bcd7
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 24 13:29:52 2007 +0000
fixes in inode.c to update lru_size correctly
commit 0265cba31d3f90c9b68974f8da3b3cb3a037cb7b
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 24 12:56:14 2007 +0000
fuse + posix really working :)
commit 9bf6443fc1db7e3559c560d7d30ff89ba39d073c
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu May 24 12:05:01 2007 +0000
* syntactical changes to protocol-server.c
commit 60aa277c571c8de7c3153137d39496fd3993d369
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 24 11:14:53 2007 +0000
stripe - basic functionalities complete.
* xlators/cluster/stripe:
- completed all the FOPS.
- testing pending.
- few TODOs left. discuss and fix them.
commit 28ad608836ee8fa6601768e3afa632edde02db4d
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed May 23 10:07:14 2007 +0000
* Renamed protocol server souce files to server-protocol.[ch].
* Removed ns.[ch] from protocol server source directory.
commit 178a60d6cfc6f9f9f71ebd541b61ef17d0e268f0
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed May 23 07:49:31 2007 +0000
Added lookup and forget calls to client protocol
commit 836ea180b0ce863ff7a4e6a375d938ed696d5bbd
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed May 23 06:29:40 2007 +0000
inode migration changes to client protocol
commit cb643741aa5fa138bcd1d1eec781436a2ee13ab5
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 22 13:07:58 2007 +0000
call-stub.c - apis to create a stub for a call which can be later resumed with
stack.h - typechecking for return function during STACK_WIND
common-utils.h - moved memdup() from dict.c
glusterfs-fuse - rewrite to loc_t based api
commit 1520c66dbeff684188c1749a305cf517318ceb73
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 21 20:39:10 2007 +0000
intermediate commit
* libglusterfs/src/defaults.c:
* xlators/debug/trace:
- changed to latest API. Complete.
* xlators/cluster/stripe:
- changed to latest API. Few functions implemented.
* xlators/cluster/unify:
- changed to latest API.
commit 113328f84c025e9a8ab1cf5d782b26a06b525b92
Author: Anand V. Avati <avati@80x25.org>
Date: Mon May 21 14:43:43 2007 +0000
defined types for fops
commit 3afe1be392f59d3c41366bd548919595963f77a4
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 21 09:13:10 2007 +0000
* libglusterfs/src:
- xlator.h : removed extra definition of 'struct _loc'
- xlator.c : modified default functions to 'stat', 'fstat', 'close' and 'closedir'
- defaults.{h,c} : changes according to new xlator API.
-- libglusterfs compiles without errors --
commit ccca4dff654d4d77c942c690fff94c0cfc8cd13d
Author: Anand V. Avati <avati@80x25.org>
Date: Mon May 21 07:13:12 2007 +0000
futher api changes in xlator.h
inode.c/h commments and enhancements
commit 0a59636dc8e88f0432192280cd1a3276527d9954
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 21 01:15:29 2007 +0000
* libglusterfs/src/xlator.h:
- minor change (from inode_t * to struct _inode *, for compiling reasons)
* xlators/debug/trace:
- All functions complete. Compiles. Review needed.
* xlators/cluster/unify:
- fops/mops APIs changed to new xlator API. No body yet :|
commit 764a460a00f406d89b62c7f7a59ed215c57e7c3f
Author: Anand V. Avati <avati@80x25.org>
Date: Sun May 20 13:58:38 2007 +0000
updated location based xlator.h APIs
commit d4b22f4cf817764668b49e7f3504e76c0f16db07
Author: Anand V. Avati <avati@80x25.org>
Date: Sat May 19 23:04:02 2007 +0000
fixes in glusterfs-fuse (mem leaks and segfaults)
commit 7562e51f6225fe2ffe603256e196f1cfa55cfae1
Author: Amar Tumballi <amar@80x25.org>
Date: Sat May 19 18:12:50 2007 +0000
unify 'stat' 'mkdir' working.
* xlators/cluster/unify:
- some improvements. lookup, forget, getattr, mkdir, chmod working fine.
* xlators/debug/trace:
- more enhance to the trace.
commit 91b977d971e8c77776a4cc0b706def99cadb7c78
Author: Amar Tumballi <amar@80x25.org>
Date: Sat May 19 13:43:47 2007 +0000
* scheduler/*:
- minor changes to all the scheduler to compile with new changes.
* xlators/cluster/stripe:
- started fop changes
* xlators/cluster/unify:
- few more functions added. lookup, forget, mkdir, getattr, chmod etc are completed.
* xlators/debug/trace:
- formatting, and few more compile error fixes.
commit c2c9a0586bf47717cf3cf5fc2ca332dea19b6b50
Author: Anand V. Avati <avati@80x25.org>
Date: Sat May 19 10:57:41 2007 +0000
glusterfs-fuse all fops implemented, bug fixes in storage/posix
commit c19b202368e78418b74584d0101f8bb61d8d0af2
Author: Anand V. Avati <avati@80x25.org>
Date: Sat May 19 07:43:25 2007 +0000
xlator.c: set default fops - lookup, missing, fchown, fchmod
glusterfs-fuse: implemented chmod/fchmod chown/fchown truncate/ftruncate utimens
commit e3317176a813ff9cb1c242324e38d72a21f9a37a
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat May 19 07:18:16 2007 +0000
modified posix-locks to use the new inode api
configure.ac: changed version string to 1.3-STABLE
posix-locks.[ch]: use the new inode api
commit 572746c2cb840bf152a01d58ddd1c795e2f90d3b
Author: Amar Tumballi <amar@80x25.org>
Date: Sat May 19 06:41:50 2007 +0000
intermediate commit
* libglusterfs/src/glusterfs.h:
- corrected GF_FOP* and GF_MOP* enums
* xlators/debug/trace:
- changed first argument to gf_log () from "trace" to 'this->name'
* xlators/cluster/unify:
- code not usable yet. lot more rewrite needed.
commit 49b150e72c5cf4ac58cb7c273e17247ffade95f9
Author: Anand V. Avati <avati@80x25.org>
Date: Sat May 19 06:27:54 2007 +0000
storage/posix - all fops implemented
glusterfs-fuse - added fuse-extra.h
commit f88d22b05713bb30dfcd6c49b0b344a0751c7f03
Author: Anand V. Avati <avati@80x25.org>
Date: Fri May 18 17:33:20 2007 +0000
glusterfs-fuse: initialize tree bottom up
libglusterfs: add 'itable' to each xlator and automatically set to lowest itable manager
lookup/getattr/forget/opendir/readdir/releasedir working with fuse+posix
commit d44941e283dcc201e1eee84ce7f3a1628e976aef
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri May 18 12:07:00 2007 +0000
Added GF_FOPS_<new-fops> for lookup, forget, fchown, fchmod in glusterfs.h
commit 26f525ddce81b95bc439248b55c6382a72c698e9
Author: Anand V. Avati <avati@80x25.org>
Date: Fri May 18 07:42:52 2007 +0000
updates in inode api
commit a54c64cc2e6535cefb11b0f17d25358a3b057102
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 17 16:26:47 2007 +0000
adding fops to fuse
commit b1dd0cd2351240680b1e585e57bcce367e31cfc7
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 17 12:31:45 2007 +0000
libglusterfs and glusterfs-fuse compilable
commit 3f071beb0be563ae683cff0a52414fe74f035ece
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri May 18 04:32:16 2007 +0000
path -> inode related chances. comlete change for trace.c one minor change in defaults.c
commit 72db44413ce4686b465c29ea8383fa4f09f53a76
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 17 07:11:37 2007 +0000
inode.c and initial fuse-bridge.c commit
commit 30f7cfdf757e7f9e3c23bf7f0e381d19ea0e0cc9
Author: Amar Tumballi <amar@80x25.org>
Date: Wed May 16 12:23:10 2007 +0000
* libglusterfs/src/xlator.h:
- corrected the definition of readlink.
* libglusterfs/src/defaults.c/h:
- changed the prototype to match new APIs.
commit 7b3acbf43107f21bfa7376e96a5d54872dc7c011
Author: Anand V. Avati <avati@80x25.org>
Date: Wed May 16 11:32:57 2007 +0000
fixed open() flags in xlator.h
commit 77ab2041dc5952482dab7b8b7391fd53fe70aefc
Author: Anand V. Avati <avati@80x25.org>
Date: Wed May 16 10:14:55 2007 +0000
change in rename_cbk prototype
commit 02bf8138f0d934a4b437cd23571a43784c903fb8
Author: Anand V. Avati <avati@80x25.org>
Date: Wed May 16 10:04:05 2007 +0000
furhter changes to fop prototypes
commit a31fcb1fab4e307672098f1a4d1f873e39dd8f58
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 15 15:39:44 2007 +0000
change in fop callback prototype to use stat instead of inode
commit fd6d5ad9b1dffb32832a27562ac31ea056f0e701
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 15 12:04:25 2007 +0000
added prototypes in inode.h and list management in list.h
commit 58d2570d400b846b3018e8d0160b65434797abcd
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 15 11:50:04 2007 +0000
build br34k4g3 :D
commit 23bb325f34bc254d087e7d50ef359adc20c1c1f7
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 10 17:11:49 2007 +0000
commit 4e6837aaf406543a46f98b608f4a03cc212e41db
Author: Basavanagowda Kanur <gowda@freeshell.in>
Date: Thu May 10 04:16:56 2007 +0000
* Added data_to_uint<size> to replace data_to_int previously used.
* Added data_from_<integer-types> to replace int_to_data.
* Added data_from_ptr to replace previously used type-casted int_to_data usage.
commit 32563031a47151f179b1a0b58fdd4faed7f0cb15
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 10 12:44:32 2007 +0000
fwd port of patch-171 from mainline--2.4
commit 35d7ba1d7603a44836c5a77bab32c0d12af86fee
Author: Basavanagowda Kanur <gowda@freeshell.in>
Date: Wed May 9 23:04:13 2007 +0000
* Added data_to_int64, data_to_int32, data_to_int16 in place of data_to_int
* Changed all usage of data_to_int to relevant data_to_<integer-type>
commit 31e31e65e2799b8ab357e596c127e4f07e56cc97
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu May 10 06:30:04 2007 +0000
do inode_dec_ref *after* everything else in posix_locks_release
commit e3e36d4442313f1b38c53100bc732536b19c72c9
Author: Anand V. Avati <avati@80x25.org>
Date: Wed May 9 18:10:53 2007 +0000
bug fix in read-ahead for read with offsets beyond end of file
commit 320f88b460933819fe717c2eddf1b5e0169010c1
Author: Anand V. Avati <avati@80x25.org>
Date: Wed May 9 04:29:08 2007 +0000
glusterfs-fuse: fix --volume-name logic to make it optional (use top node by default) and fix --help string
commit 55dbe18a108ec4bd07950fd1367b0bafd645023c
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed May 9 00:02:45 2007 +0000
read/write works for views in meta
commit 1dd1d1ab037f14db5b9f4427383ce04a6292de44
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue May 8 23:00:05 2007 +0000
meta xlator views partially working
meta:
- added xlators and view, etc.
- readdir and getattr work on views
xlator.h: added 'type' field
commit 12de2aefe085e41548876b69a19726eeed9909a8
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue May 8 19:41:25 2007 +0000
first commit of meta (/me w Lord Murphy profusely)
* Only thing that works is /.meta/version
configure.ac: changed version to 1.4.0
commit 9da49f6f33c3c01d0f64349b1bd2e3253e44e6cd
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 8 15:36:25 2007 +0000
fwd porting patch-167 from mainline--2.4
commit 22663dbcad61031a73fafc6bfcf1a6eedf65660d
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 8 15:09:54 2007 +0000
front-porting fixes from mainline--2.4 (patch-166)
commit 242e60ec256978fe5ccb7f445552ec89bf925aa9
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 8 11:58:31 2007 +0000
non-blocking-connect on/off for -s over slow links
commit 2034418a3b457ce539397a29bf828cb823fb5cf2
Author: Basavanagowda Kanur <gowda@freeshell.in>
Date: Mon May 7 23:27:09 2007 +0000
commit 3d1e3658066ca65e600a2838c9cf3a5b2d349393
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 8 10:04:52 2007 +0000
added 'flags' to create fop prototype in defaults.h
commit 7c963789eb22c5f8198f684915c9c85169e0a57f
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue May 8 06:24:22 2007 +0000
minor fixes in posix-locks
commit 65a7404d689427815228eeb544d5f5604300ae37
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 7 21:25:42 2007 +0000
* xlators/cluster/afr:
- cleanup regarding LOCK (x) and UNLOCK (x);
commit bdae0cf527acdd417cea82a9e211e1aade98670c
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 7 20:42:43 2007 +0000
* xlators/cluster/unify:
- changed unify to do STACK_UNWIND to fops before calling
mops->unlock on namespace lock.
- rmdir checks the directory to have no entries, and only
then it does rmdir on all nodes.
- opendir and releasedir on all the nodes.
commit 511c5a87618dfef0868ff36fd5b47ccd5ef132a1
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon May 7 18:48:57 2007 +0000
posix-locks final commit (patch 162) copied to this tree
commit b70fe402c27e473b9f7b86d7d55c2d1ccf50a802
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 7 18:15:06 2007 +0000
Exclusive create
* xlators/*:
- all the fops->create () calls are added with 'int32_t flags' now.
* xlators/cluster/unify:
- support for Exclusive create is done.
commit 38231984e351c6290bdf765ecdd2328eb99a984c
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon May 7 16:46:32 2007 +0000
changed 'cooky' to correct spelling 'cookie' :P
commit 97ca871992901577f75e155e600f5f7ba2bb3d3e
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 7 15:27:34 2007 +0000
* libglusterfs/src/stack.h:
- added _STACK_WIND with another argument 'cooky' which will be
returned in STACK_UNWIND.
* xlators/*:
- changed the argument of all the '*_cbk ()' to have 'void *cooky'
instead of 'call_frame_t *prev_frame'
* schedulers/*:
- added another function hook 'update ()', which can be called from
outside to update the stat info.
* xlators/cluster/*:
- changed place of incrementing 'local->call_count'. moved just before
checking it
commit 9c2e2ee091bb37b059b41b06976c15acd4e995e1
Author: Amar Tumballi <amar@80x25.org>
Date: Mon May 7 07:52:29 2007 +0000
Initial import for release 1.4.x
commit eff2e3abd314f66693e94ca20a07914139064f25
Author: Anand V. Avati <avati@80x25.org>
Date: Sun May 6 10:30:33 2007 +0000
logging fix
clients log with critical status when disconnected from server along with volume name
commit 14ca05be38b5bcdf13149acb1a887eddfa67ac38
Author: Anand V. Avati <avati@80x25.org>
Date: Sun May 6 06:30:34 2007 +0000
io-threads: allot fd to threads based on inode number
glusterfs-fuse: revert seperate thread for /dev/fuse
commit 6de0f84cea8fbb07c556fa06461548b910e56e3e
Author: Amar Tumballi <amar@80x25.org>
Date: Sat May 5 18:18:47 2007 +0000
more bug fixes
* xlators/cluster/stripe:
- stripe_getattr_cbk was not sending the proper stbuf to the parent. fixed.
* xlators/features/trash:
- there was a bug which shown up when used with unify, related to
ENOENT op_errno. fixed.
commit 6212ec362742ef6888fed19c5af5f6f8d20f1b56
Author: Amar Tumballi <amar@80x25.org>
Date: Sat May 5 16:52:00 2007 +0000
bug fixes
* xlators/cluster/unify:
- used another pointer for 'path' in case of getattr and open as successful
call used to get UNWIND'ed before other calls are made.
* xlators/cluster/stripe:
- stripe_readv_cbk had a bug in case of multi threads. fixed. (re-coding
required in next version)
* glusterfs-fuse/src/fuse-internals:
- fixed issues with fuse_readdir_cbk, where it used to segfault in case of
op_ret == -1
* libglusterfs/src/common-utils:
- added a void function to use while debugging, mainly for breakpoint
purpose. 'trap ()'
commit 0f5e425da36cc69d89e2b6a4b3d2ee9b8a7ab248
Author: Anand V. Avati <avati@80x25.org>
Date: Sat May 5 15:36:54 2007 +0000
timer thread start after daemon
commit 8e2148ae391c8d26466345fb501eb89769683944
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Sat May 5 13:17:59 2007 +0000
changed alu and random schedulers. alu didnt handle op_ret = -1 and random had a bug in the way it was checking for free_disk
commit 86b540ba61ebf7104287a6909e60c2118bb8a3bf
Author: Anand V. Avati <avati@80x25.org>
Date: Sat May 5 11:15:36 2007 +0000
io-threads queue condition fix to avoid deadlock
commit 5cd459d51cb21857d99f05f8723189b8aef8c554
Author: Anand V. Avati <avati@80x25.org>
Date: Sat May 5 10:34:05 2007 +0000
glusterfs-fuse - seperate thread to poll on /dev/fuse to avoid the 'big' deadlocks
commit 66dc232a33270457da7cfde28d8aa74ad0193996
Author: Amar Tumballi <amar@80x25.org>
Date: Sat May 5 08:12:20 2007 +0000
bug fix
* xlators/cluster/stripe:
- bug fix in stripe_readv_cbk regarding frame->root->rsp_refs
* scheduler/nufa:
- setting of eligible for op_ret == -1;
* Added QA spec files:
- Includes all the necessary xlators on both server and client side.
commit 03f9eeb8dcbf0916481c504af80da51ff8049d46
Author: Anand V. Avati <avati@80x25.org>
Date: Sat May 5 06:31:10 2007 +0000
multiple bug fixes
write-behind: flush-behind uses file->op_ret as return values instead of 0
ib-verbs: fix mtu warning, tune completion queue size
io-threads: do cache-size based queing rather than queue count limit
dict_ref/unref for readv_cbk only if op_ret != -1
posix-locks: readv(), writev() - WIND _after_ unlock to prevent deadlock
glusterfs-fuse: process with appropriate size buffer
read-ahead: disable read ahead if file is opened with O_WRONLY
transport/{tcp,ib-verbs,ib-sdp}: reset signal handler of SIGCONT after bail to avoid spurious bailing because of other SIGCONT (gdb)
commit 0bbe3cf2b72ba5126fe0d13a6dfe61c190092628
Author: Amar Tumballi <amar@80x25.org>
Date: Fri May 4 10:20:01 2007 +0000
bug fixes
* xlators/cluster/stripe:
- when open fails in any one of the child nodes, release is sent to
the nodes which return SUCCESS, and error is sent to the top layer.
* scheduler/random:
- added support of threads
* scheduler/rr & scheduler/nufa:
- update_stat was not happening to all the child nodes if one of the
node was not eligible, which was causing these scheduler to not
consider min-free-disk option. Fixed.
commit 7ef10538aca8f4d916392813f02be63ec369c589
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri May 4 06:37:29 2007 +0000
posix_flush returns 0
commit 97eaf80da06e1612082b8081e6d2ba9165f764f8
Author: Anand V. Avati <avati@80x25.org>
Date: Fri May 4 05:52:53 2007 +0000
deadlock bug in client-protocol.c fixed
a 'cleanup' unwind triggering a new wind in a _cbk function (unify) caused a deadlock on priv->lock (in client_proto_cleanup vs generic_xfer)
commit 2b32f449a46ef0f490c11ed3e265e55f37680186
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 3 16:43:35 2007 +0000
bug fixes
* xlators/protocol/client:
- fixed a bug in client_release, where frame->* was getting
reffered after STACK_WIND, which used to get free'd if
io-threads was used on client side.
- corrected the argument for client_getspec
* xlators/performance/stat-prefetch:
- fixed similar bug of reffering to frame->root.pid after STACK_UNWIND.
commit 11a624c61d725d146c81b6dfb31f326c9b412984
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu May 3 08:32:19 2007 +0000
using callcnt local stack var for comparing with child_count, to avoid a race condition.
commit dc9f0df03ec75f2a7871163908bead968a2d00e8
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Thu May 3 08:17:03 2007 +0000
storing local->call_count in callcnt variable and using it to compare with private->child_count to unwind
commit 83be1bad2fd55f40085257749bac22cf31b88e5c
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 3 06:35:26 2007 +0000
* glusterfs-fuse/src/fetch-spec.c:
- fflush and fclose of spec_fp in fetch_cbk
- exit with the return value in child process.
* xlators/cluster/stripe:
- added locking in case of readv_cbk (it was missing).
commit a84a60efe5400efff7d672e9a3a7504e65947350
Author: Amar Tumballi <amar@80x25.org>
Date: Thu May 3 05:50:05 2007 +0000
completed '-s' for non-tcp transport
commit 78251b39aaaa11da5391487185373964e2f2f750
Author: Anand V. Avati <avati@80x25.org>
Date: Thu May 3 05:27:29 2007 +0000
iot_lk/_cbk fixes in io-threads
- pass 'struct flock *' in the _cbk
- convert local->flock to structure from pointer to structure (was leaking)
commit 779a822f7e6e8e183f90f09d3cf76dbaeeb1c09d
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed May 2 16:55:01 2007 +0000
LOCK macros were empty; LOCK_DESTROY should be done before STACK_UNWIND; if one of the children return error, stripe should return error
commit 16d969c4c9586edc201fddbf52759580395aa3bb
Author: Anand V. Avati <avati@80x25.org>
Date: Wed May 2 15:29:35 2007 +0000
added flush-behind option to write-behind
added flush-behind option rather than setting direct_io flag in fuse-internals.c
commit a2e802c6546ac0d25e27f990e59db65b4b7532bb
Author: Anand V. Avati <avati@80x25.org>
Date: Wed May 2 08:47:13 2007 +0000
half-commit of -s for non tcp
commit fa04b61021c70b779ee46716bb8bea0b6555d462
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed May 2 06:48:02 2007 +0000
fixes in posix-locks
posix-locks.c:
- merging of locks can happen multiple times
- off-by-1 bug in subtract_locks
- implement _flush; release all locks belonging to current process
when a file is closed
commit def966b9950d0eb765fc3e791c234cd346dbaeab
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue May 1 18:14:19 2007 +0000
make _lk calls go through separate thread in io-threads
commit 202bd9f350905d55fc1cbe77bd184595a54a2f7e
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 1 10:38:16 2007 +0000
check for bison in confiure.ac
patch by Harshavardhana Ranganath <harsha@zresearch.com> to insist on bison as grammar check
commit ffffea6f642f4a2ef390ad1aa14c57ff5f405c02
Author: Anand V. Avati <avati@80x25.org>
Date: Tue May 1 10:16:03 2007 +0000
new xlator fixed-id
features/fixed-id: make all files and dirs list under common uid/gid
libglusterfs/defaults.c: fixed prototypes of rename
commit a982f0a333a115ca35e6f1a806420a9937d1db30
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Apr 30 20:14:33 2007 +0000
ib-verbs minor cleanups
commit d106f07a62a11aea3c05a0ce1a8cf77400a1fb86
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Apr 30 07:47:31 2007 +0000
fix in afr_opendir_cbk - opendir does not have a struct stat in the callback
commit 8af50b90c6a51e042d0d8b8adb666e843a8576d2
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Apr 30 07:38:58 2007 +0000
- fix in fuse-internals.c (listxattr)
- ib-verbs fixes
- make gf_print_trace print backtrace _and_ generate coredump
commit d5aed2fbe44f27aa41eacf9386d09b23f90d6dc4
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Apr 27 18:40:54 2007 +0000
xlators/features/trash enhancements
* xlators/features/trash:
- added an option for specifying 'trash-dir' (option trash-dir /.trash)
- if a file from trash-dir is deleted through glusterfs, then another copy of it is not created.
commit 8d020e6b8afb266366b683c1167087ab0dec64da
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Apr 27 10:56:29 2007 +0000
fixing a minor bug, wb_open_cbk is cbk for both open and create
commit 427b110fbf79319dc9fb332d5f332c116808e13b
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Apr 27 08:27:21 2007 +0000
disabling caching in read-ahead and write-behind when file opened with O_DIRECT flag.
commit d51b7354a72f4df725e7d824126efc3ded62b127
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Apr 27 06:23:08 2007 +0000
mount.glusterfs.in - fix log-level string
commit e4dbfca12fd970c12375f6ac46ca78ef9270fbee
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Apr 26 18:58:13 2007 +0000
io-threads enhancements
use pthread_cond_t instead of wrong tricks using pthread_mutex_t.
use reply thread for replies of readv and writev
commit 89e70a9916c7014dd20f66ae5b7592f8afd1a2bf
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Apr 26 17:53:58 2007 +0000
ib-verbs redesign
ib-verbs redesign commit, highlights:
* completion polling is done in seperate thread
* recv buffers are shared using shared queues
* send buffers are global per device
commit d4d25f1b7197b4566be6c3f3577be28c2fcb6051
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Apr 26 16:37:22 2007 +0000
fix in posix-locks to strdup and save path for truncate + mandatory
commit 2ef4f98c776d0873534dba3ccf957f5c750f6821
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Apr 26 09:49:07 2007 +0000
multiple fixes
* write-behind: slightly intelligent write
* unify: temporarily made opendir to succeed always for ls to work
when lock-server is down
commit 8792d6b3a2e6412c61fddc3be0b108ca726e96c4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Apr 25 19:18:37 2007 +0000
handling ENOTCONN, fixing the bug which happens when 1st child dies.
commit 8bd54938dc2a6659ea2e947b434e7a62bea13f9e
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Apr 24 17:50:34 2007 +0000
make posix_lk return error with ENOSYS
commit a7a3ad803491e97e5be344fca0eff1b1bcfd4404
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Apr 24 11:18:35 2007 +0000
bug fix in stripe (gettattr)
* xlators/cluster/stripe:
- bug fix in getattr_cbk, where one of the return value was not handled.
* glusterfs-fuse/src/glusterfs.c:
- changed log file from glusterfsd.log to glusterfs.log :)
commit 089f599d64fa6264a0e42961e9f36eeeecf3c3a0
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Apr 24 10:29:43 2007 +0000
modified write-behind and read-ahead to work with posix-locks
xlators/features/posix-locks/src/posix-locks.c: misc fixes
xlators/performance/read-ahead/src/read-ahead.c:
xlators/performance/write-behind/src/write-behind.c:
disable caching on files which have the mandatory bits set (+setgid,
-group exec)
commit 58d4454fcd8797a59be6a3f8f0e2bd8ff87508f6
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Apr 23 19:21:49 2007 +0000
client mops were doing STACK_UNWIND when ret was -1, but this is already done in client_protocol_xfer, hence it was causing problems.
commit fb8c1d23faf7ac09ecb76802d48b6025faec4267
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Apr 20 20:31:04 2007 +0000
Changes to afr and stripe so that it works in glusterfsd, above storage/posix type.
commit 87e9412ebb81c616a72446c980f226c3e5523a7d
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Apr 20 20:02:02 2007 +0000
configure check for flex and bison, also for backtrace in glibc
* configure.ac:
- checks added for flex and bison (exit on not finding)
- Thanks to Harshavardana Ranganath <harsha@zresearch.com> for sending the patch.
commit d75034992ee36091c9fb071c8a5790d6662f2f09
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Apr 19 06:00:20 2007 +0000
ib-verbs minor cleanups
commit 5284136759992a93bee688bab7b89d8f7d2a9b22
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Apr 18 07:42:36 2007 +0000
transport/ib-verbs: changes to use single complection que per IB device.
rename structures to follow naming convention.
commit 986a45cf1d663a6af9fb07b2286d031b02590d09
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Apr 18 07:24:28 2007 +0000
'features/trash' working
* xlators/features/trash:
- completed all the TODOs.
* xlators/cluster/unify:
- changed the return value of releasedir to SUCCESS, from ENOSYS.
* glusterfs && glusterfsd:
- changed the default log level to ERROR.
* Makefile.am:
- moved 'doc' subdir to be compiled last.
* doc/examples/*:
- added 'option block-size *' in the stripe volume's options
- added entry for volume 'features/trash'
commit 181977f62fe5cd3bdf0221c51a6fc30225139a27
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Apr 16 17:38:43 2007 +0000
added mandatory locking support
xlators/features/posix-locks/src/posix-locks.c: added mandatory locks
xlators/storage/posix/src/posix.c: do an fcntl() in posix_lk
commit 4b15540f5231365be32f04b9388af913072fa4e7
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Apr 15 11:18:27 2007 +0000
revised posix-locks substantially, everything except mandatory works now
commit 028ec0a27820384abbc04f6c0eb40b9688221954
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Apr 13 12:47:46 2007 +0000
stripe pattern based working.
commit fbc0decebee02e78f4e9b5ae7e123f852f2f67a0
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Apr 13 10:49:27 2007 +0000
bug fixes in stripe
* xlators/cluster/stripe:
- fixed bugs reported by Krishna Srinivas after primary review.
commit 7771f53f989db9b53484a51b09146f244ec57c2b
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Apr 12 11:40:05 2007 +0000
file ref and unref with locks in write-behind
commit 0d99eba80ee36d11af6056e6f1e093a78d3b9cfd
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Apr 12 10:35:13 2007 +0000
stripe pattern based
* xlators/cluster/stripe:
- stripe is pattern based now
* xlators/encryption/Makefile.am:
- added header info to be needed in 'make dist'
* libglusterfs/src/common-utils:
- changed the log level of trace output to CRITICAL from DEBUG
commit dd26a6bf20df5de02fa7f26867b2b09db964b139
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Apr 12 10:30:56 2007 +0000
glusterfsd exit during initialization if xlator's init returns non 0
commit 3bf50d7e238e161261441a0620a4b50ad6068003
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Apr 12 06:08:01 2007 +0000
handle ->create in posix-locks to avoid fd leak during release()
commit a006169f1f5f09fcb9dadf3cef1cdb12e7ab704b
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Apr 11 12:43:47 2007 +0000
added missing Makefile.am
commit a24a781bf4199d00ed68447490d97a38494c9338
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Apr 11 10:48:52 2007 +0000
rewriting posix-locks, much cleaner code now
commit db25c3171b0d6fe777ca51cdeb0df5f99c145f17
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Apr 11 10:31:12 2007 +0000
commit 4510944e37d6a36ccd1425bd95549be18003191c
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Apr 11 10:23:50 2007 +0000
added missing locks in fuse-bridge and write-behind
do not turn on direct_io explicitily for any situation
commit 5562822a329e2d4db8076d9fb4125075acd0dfd3
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Apr 11 08:19:24 2007 +0000
Changes to make unify work with storage/posix as its children. lock.* moved to libglusterfs.
commit 7994a6153b2cf4a77135f47de5754c9b01b7c98b
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Apr 11 05:11:19 2007 +0000
fix on ib_verbs_readv missing symbol
* fixed
commit 5c8fb5031eef4a102ae36f75e9b25706f7514a65
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Apr 10 22:45:29 2007 +0000
renamed bailout-seconds to transport-timeout
commit 7fa1a96ecd13ce16dca8196f23f0e228f3d80ed9
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Apr 10 21:20:00 2007 +0000
made the bailout duration configurable
xlators/protocol/client/src/client-protocol.c: added new option
"bailout-seconds" to specify the duration after which we bail out when
a response from the server is not received
commit 0c884d32adb4a7350a3b5c9a00b6765de0a9dd52
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Apr 10 07:38:17 2007 +0000
schedulers threadsafe and using min-disk-space
* schedulers/nufa:
- earlier it was scheduling to only local-volume. now checks
for min-disk-space and schedules to others if the local-disk
is full. Made thread safe too.
* schedulers/alu:
- made thread safe
commit 656388cbc8f32998f798ab1614209c55316f7126
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Apr 10 05:11:20 2007 +0000
transport_t pointers handled gracefully for deferred calls
commit 53238ba90c30ac8f168d72417147bd21e8ce6e31
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Apr 9 11:40:44 2007 +0000
dummy change to test ib-sdp.h commit
commit 41de138330be309ab9f099f29a81fb79c780127d
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Apr 9 08:38:50 2007 +0000
bail and dummy bail function for ib-sdp and ib-verbsx
commit 662304e3a66caab78e7a4be9fc85da805a23004a
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Apr 9 07:48:25 2007 +0000
added missing timer.[ch] in libglusterfs
commit 4702aa3918201692087803b0c18a2fc7e77b832a
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Apr 9 07:45:55 2007 +0000
timers and transport timeout
commit 2cd645ca2612234b4ca1fe2b6e324123dfb68fa9
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Apr 6 20:31:26 2007 +0000
glusterfs-fuse, glusterfsd: default -l argp option
xlators/encrption/Makefile: added
commit a5946bfddea8022c957eb7b1855666f9d4dd7a41
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Apr 6 10:12:42 2007 +0000
libglusterfs:
- neater poll/epoll abstraction
- added 'context' support, needed for timer/transport timeout.
glusterfsd:
- added pidfile support. can specify custom path with --pidfile
- minor cleanup (remove static variables etc)
glusterfs-fuse:
- minor cleanup
transport/*:
- use cleaned up transport api
rot13:
- moved features/rot13 to encryption/rot-13
- fixed rot-13 algo
cluster/afr:
- implement releasedir to avoid fd leak in glusterfsd
commit 107964c7273a9e35d09439f5270bf389ca3b6d8c
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Apr 6 06:40:18 2007 +0000
added posix-locks to example spec file
commit 901312148daf06de4c10b968817e7b3888dd187d
Author: Anand Babu <ab@zresearch.com>
Date: Thu Apr 5 20:33:46 2007 +0000
arguments validation
Fixes for the following:
* error out on incorrect log-level value
* --port requires --server option
* invalidate combination --server and --spec-file options
* renamed struct f to static struct arguments
Bumped version to 1.3-pre3.
commit 5017970effea3fdd381a1f7bdee1058420a99343
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Apr 5 19:35:15 2007 +0000
added rot13 xlator
features/rot13: simple xlator intended to demonstrate how to write an
xlator. It ``encrypts'' all text written by passing it through rot13
and ``decrypts'' it upon read. Only works on text. Not for production
use (obviously) :P
commit 539e72d3aaf7c95eb23eb7c801a18767cbec0a3e
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Apr 5 16:43:23 2007 +0000
xlators/performance/io-threads:
iot_handle_frame(): make copy of vector from local to pass to STACK_WIND
commit c1a9d148a2482c4a70a7e409a6a6c7b28d40ece8
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Apr 5 11:10:28 2007 +0000
xlators/performance/stat-prefetch:
access shared data with locks
fixed memory leak
xlators/storage/posix:
allocate readdir data on heap for stat-prefetch to be loadable on server side
commit 7330092272c15af3773c38dd731e28b436e2b540
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Apr 4 13:55:51 2007 +0000
xlators/protocol/client:
hold lock and atomically deal with submit and callid
commit 511763d9024604d283f8038082a1d241498c188b
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Apr 4 07:26:54 2007 +0000
glusterfsd/src/glusterfsd.c:
support relative paths even for daemon mode
transport/tcp/server/src/tcp-server.c:
ntohs() on port number while logging
xlators/performance/read-ahead:
redesigned code to work like 'page faults'
acquire locks to be thread safe
xlators/protocol/client:
access private members with lock
atomically increment callid and save to saved_frames - 'missing frame' error
use strtoul instead of strtol in cleanup for addresses
xlators/protocol/server:
use strtoul instead of strtol in cleanup for addresses
commit 3081c68f920a8f89af4a24317c462693199deb4a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Apr 4 07:15:10 2007 +0000
commit 5c874054e6346f451efcbc3abfe9c95c64acd529
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Apr 3 15:42:03 2007 +0000
fixed a bug in posix-locks
release_locks should release all locks that are covered by the given lock
commit a4278c88e9715ccbedd634184d91221e30230d5e
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Apr 3 12:18:36 2007 +0000
* transport/ib-verbs:
- corrected reconnection logic.
- fixed bugs related to corner case segmentation faults.
(like if a tcp client connects ib-verbs server visa-versa)
- client doesn't fail if server is not present.
commit bfcb05c3fdd76eaa0310e4f2825523d04f72982a
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Apr 3 11:35:13 2007 +0000
converted posix-locks into an xlator of its own
Added:
xlators/features/posix-locks/*
mandatory locking support TODO
commit 011e72071389543880ab9c7eef4358d78dac92de
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Apr 3 05:43:09 2007 +0000
read-ahead bug fix (kernel compile issue)
* xlators/performance/read-ahead/src/page.c:
- fixed the bug related bad offset. (Anand V. Avati)
* schedulers/rr/src/rr.c:
- memory leak fixed (Anand V. Avati)
commit c611c6f0c97f156ec4869124402e495e15b1eb1a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Mar 28 21:36:04 2007 +0000
commit f81cd935bff54c56c29870fe49453f55b9a83471
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Mar 26 07:06:25 2007 +0000
io-threads enhancements
iot_queue/dequeue - seperate locks for queuer and dequeuer
do not use return queue for file i/o
commit 71df16193a7d0d04991b6c067482a16fdc30da24
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Mar 18 19:35:47 2007 +0000
fixed leak in read-ahead
read-ahead now works smooth for files > 4GB
commit e23a7d9765a558c1e090b7d9dc2d808e90e15891
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Mar 16 17:28:43 2007 +0000
* added 'signal (SIGSEGV, gf_print_trace);' in both server and client
* xlators/cluster/stripe:
- in stripe_release, fops->flush was called, which never used to close (fd); fixed.
* scheduler/alu:
- fixes in case of min-free-disk. and when no nodes available.
* scheduler/rr:
- fix in case of no min-free-disk.
commit f6aba839c081394241c19d317bae004edfa6d624
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Fri Mar 16 04:41:05 2007 +0000
commit dcac4cdc85d19b979c832ae14d70b37e49a51e79
Author: Anand Babu <ab@zresearch.com>
Date: Sun Mar 11 08:42:44 2007 +0000
Paul's fix - respect DESTDIR for staged install
Paul rawson <plrca2@gmail.com> found this bug during ebuild for gentoo.
commit 75ee847a03d62465bd55dfebf6181fa9b48bd995
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Mar 9 05:11:42 2007 +0000
fix in memory leak of server
* xlators/protocol/server:
- found the issue of memory leak in protocol/server
* scheduler/random:
- added min-free-disk support
* libglusterfs/src/common-utils:
- added gf_print_trace, which does the backtrace.
* xlators/performance/read-ahead:
- added a while loop which was optimized during readv changes.
commit 94f1a7e5d5b5389fd86bf8aae88a3851d9e78c05
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Mar 7 05:34:01 2007 +0000
added trash xlator
* Added xlators/features/trash:
- check TODO : only one problem pending.
* other files
- removed debug option from all the volumes.
- by default debug is enabled in trace xlator
commit 394cb7047cc490a571d16176b8b5fe061c216b33
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Mar 2 20:18:30 2007 +0000
stripe working
* fixed issues with stripe xlator's readv and writev.
commit 77898fc4115e29ca8b4c64dd401d0767cd47ee46
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Mar 2 13:07:36 2007 +0000
* fixes in rr: now it takes limits and refresh interval as options.
stats call will be made to only next node.
commit ee1ec98f0cbf36b1d9b3b7ece7f79d05212fd757
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Mar 1 21:37:13 2007 +0000
rr bug fix
* scheduler/rr:
- bug fix related to free-disk size.
* libglusterfs/src/common-utils:
- moved str-to-long-long () (from alu,rr) to here (with prefix gf_)
commit ffc4307c5588cbee50374a8df7eca8f7405d2f96
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Mar 1 00:31:01 2007 +0000
release patch (1.3.0-pre2)
commit dee4d4b2595c93d031bebeba853bdde612be2952
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Mar 1 00:14:37 2007 +0000
* scheduler/rr:
- added support to min-free-disk option
* xlators/cluster/stripe:
- added LOCK ing macros
commit 6898c101c3ac73ebbae9aeff09a821b012153c9a
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Mar 1 00:07:17 2007 +0000
namespace cleanup of common-utils (prefix gf_)
commit 374678f51322fee80c527075ab45138d4f645742
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Feb 28 23:35:04 2007 +0000
logging format now includes file/function/line
commit 49d2d517b14fd5dfe8bf6c2da5603e9f7773a52f
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Feb 28 21:37:31 2007 +0000
* doc/example/cluster-client.vol:
- added example of cluster/afr (patch by krishna) and cluster/stripe
* xlators/cluster/stripe:
- added mops_stats call
commit 780d0870d781fac58f20c5ac2fb0818827fb5520
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Feb 28 21:38:07 2007 +0000
parser now displays the bad text which caused syntax error
commit 493f4ad5a665b0a344029b6063fe1d5ceaf89b22
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Feb 28 21:33:07 2007 +0000
fuse mount problem fixed
- relative path of spec file problem fixed as well
commit 9f1ab3c08e6428a7b02186ce4d41176ad0b14117
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Feb 28 20:03:16 2007 +0000
fixed warnings in posix-locks.c and posix.c
commit 0705e6429ad631f59dee908256b139b46d32b5ed
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Feb 28 19:38:17 2007 +0000
* transport/ib-verbs:
- cleanup, fixes, done.
- one more serious review required.
* xlators/cluster/stripe:
- readv implementation done.
- pattern matching support not done yet.
- Review pending.
commit b2fc9d36a076eedd32049428d19193d582eef9f4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Wed Feb 28 11:30:59 2007 +0000
commit 7acecc46fe64e451761f18f42144500a1f8be833
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Feb 27 20:26:23 2007 +0000
POSIX locking support done
commit e41297cea91957dc103f57f38d23b3817c187585
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Feb 27 13:54:28 2007 +0000
AFR changes
commit 96da5940b68c141586f98298c84742f70ed29ec4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Feb 27 10:56:26 2007 +0000
commit d75986faac561bc4e2f4317c3f1227be61ca4848
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Feb 25 16:00:05 2007 +0000
added POSIX file locking support (work in progress)
xlators/storage/posix/src/posix-locks.{c,h}: POSIX file locking support
commit 4c07d0e3e2920222d80964673496d402d7bcd8c0
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Feb 25 01:02:55 2007 +0000
commit on behalf of Krishna Srinivas <krishna@zresearch.com>
- afr.c and h
commit af5edf4a0814c29ff47bf61336491d38a032fccc
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Feb 23 15:37:44 2007 +0000
tree is no more cut :D
commit f9caf0a80b44f2044f8b54c8d4f5145d07fbde3a
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Feb 23 03:55:09 2007 +0000
* bug fix in case of changing init/fini to gf_transport_init/gf_transport_fini in ib-verbs.
commit 57d36d600392869294fb3a2a0909229b59db14c5
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Feb 23 03:56:33 2007 +0000
fixes to init/fini renaming of transport interface
commit 6d1e8321d9a8eb89157c30bda29209374d471393
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Feb 23 03:28:44 2007 +0000
ib-verbs fix
* transport/ib-verbs/
- locking support fixed
- further enhancement for handling disconnect is required.
commit e083abe02f609605ff449a1823a6d7efa11a3351
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Feb 22 21:53:31 2007 +0000
renamed init and fini of transport interfaces to
'gf_transport_init' and 'gf_transport_fini'
commit d2377c602574f12fe6d85e8f9c24bb333f272e3b
Author: Anand Babu <ab@zresearch.com>
Date: Thu Feb 22 18:20:07 2007 +0000
Harsha's libtool patch, argp fixes, module versioning
commit 6ecd0770ecb9b6ab3615c7c8cf35521d7b7daff6
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Feb 22 16:03:02 2007 +0000
* Fixed warning in transports (getpeername)
* Fixed a typo bug in mount.glusterfs.in
commit def2459f89538bafaae707dfd55416aa527743a4
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Feb 22 14:32:56 2007 +0000
changed default log level to ERROR from DEBUG
* also removed warning in schedulers while doing autoconf.
commit c8abaf280c8ed1edb6eba33573bf8054f4b9ff4a
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Feb 22 13:59:05 2007 +0000
bug fix in case of logging
commit 45a547881ce832ac3411f1d38fef7004d0d13825
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Feb 22 01:39:55 2007 +0000
logging and locale changes
* added another log level GF_LOG_NONE
* corrected help string in both glusterfsd and glusterfs.
* changed GF_LOG_NORMAL -> GF_LOG_WARNING
* removed locale support from trace and logging.
commit 91469bd9e3a648198e6025965d4ef9cd4d660756
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Feb 21 01:47:48 2007 +0000
lot of enhancements and bug fixes
* xlators/cluster/stripe:
- Basic code added.
- write done.. read pending :(
- more testing required and also, locking support pending.
* xlators/cluster/unify:
- Added locking support (just defined, INIT_LOCK, LOCK, UNLOCK)
* xlators/debug/trace:
- Removed setlocale ()
* glusterfs & glusterfsd:
- Fixed msg with DEBUG option '-L'
* transport/ib-verbs:
- Handled remote disconnection logic using the tcp itself.
- Changed the default values of wr-count to 64
* doc/*
- added options of ib-verbs properly.
commit 3ce83fb5b6c189ab2dcaa1cdf9740f090efa33e4
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Feb 20 10:19:53 2007 +0000
commit 3c251355f6146a200adfcca0aad9da5f833fe5d7
Author: Anand Babu <ab@zresearch.com>
Date: Mon Feb 19 19:22:19 2007 +0000
COPYING added
commit 22dedda59d901f8642730ede9c60e874e333822a
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Feb 15 18:00:31 2007 +0000
* bug fixes in proto-srv.c (protocol/server)
commit 05f25abf7903b88ca28d196fb67bb632ffac9bc1
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Feb 14 17:50:33 2007 +0000
* removed 'getpeername' from protocol/server and moved it to
transport, where its saved as peerinfo and referred in
protocol.
* this solves the problem authentication in case of ib-verbs.
commit 6e85514551f833794282c9c73765c5bcd2c3a617
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Feb 14 16:31:52 2007 +0000
create node graph after becoming daemon
commit b6e685b8ccea85576c367c16432739b0aa084e2a
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Feb 13 08:22:57 2007 +0000
commit e025c01670c10f661a019b6e9945d4b7c6f4dbcf
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Feb 13 07:43:54 2007 +0000
commit f870f26b6f307651094db61a25af3260529f7195
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Feb 12 22:35:26 2007 +0000
glusterfs-1.3.0-pre0 release tla source
* tcp-client.c:
timeout = 0 (from timeout =10);
* xlators/cluster/unify:
bug fixes related to ENOTCONN
commit 8ad88736318d8aa7e38352afeda786b47af60f21
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Feb 12 18:12:05 2007 +0000
bug fix
* glusterfs-fuse/src/glusterfs.c:
- changed (!glusterfs_mount) to (glusterfs_mount)
commit 2464e8e747b73856654b90d1296d00900525d2de
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Feb 12 16:26:15 2007 +0000
non-blocking connect implementation by Patrick Negri <patricknegri@yahoo.com.br>
commit 18e1ab6794d6a35ce237d570fa2a1797a8a54f97
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Feb 12 15:34:57 2007 +0000
* added check in glusterfs-fuse main for status of glusterfs_mount and get_xlator_tree.
* added 2007 in the licence.
commit 1e6b3e61264f262c2c3862d2b778bc4a8dfeb7ca
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Feb 11 02:46:02 2007 +0000
* transport/ib-verbs:
- increased maximum post entries per cq to 5000 (need a revisit).
- different disconnect functions for server and client.
- added locking
* configure.ac:
changed from 1.2.3 -> 1.3.0-pre0
commit 4ca80bbd059435641b318b5ac1529448f00990cc
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Feb 9 00:59:01 2007 +0000
configure.ac check for epoll
commit 069a4f2cfc1156396a4101fcc9c6717a2155227d
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Feb 7 18:30:53 2007 +0000
1.3-pre0 commit
* Removed warnings
* ib-verbs/disconnect (all ibv_* calls implemented)
* in setvolume sending one more dictionary argument "ERROR" with proper error string
* made default aggregate-size in 'write-behind' xlator as 128k from 1M. (to get more performance in case of ib-verbs).
commit 5a9eaea71a0fccb29570cfcc81b3f56265be386d
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Feb 6 20:52:59 2007 +0000
readv changes
commit bf39f6b7648bece34a57863c167c1a4db4d5ae6e
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Feb 2 03:41:59 2007 +0000
ib-verbs _working_
* Added different CQs for Send and Recv (and also for different
for send and receive CQ of Misc QP).
* Changed the behaviour of notify function to process as much
as it can when gets chance.
* With write-behind and read-ahead, performance is crossing
400MB/s mark for both read and write in basic testing.
commit 37986e62245b58ad9648285bff285c4ede3ff7d6
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Feb 1 06:48:10 2007 +0000
save a memory copy in write-behind
commit 78ff08af2ed920a24ea24d4bd52b4a6936769c21
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Feb 1 04:51:56 2007 +0000
renamed translators
write-back to write-behind
aio to io-threads
commit 45908d159c47066cc548be6a039f2852d38aaa0e
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Feb 1 04:30:26 2007 +0000
client/protocol corner case bug fixed
commit 2e9c0d7b4d9ab83b91922acdac16e7aba6a5f32d
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Feb 1 03:52:40 2007 +0000
epoll support
commit 0a5db8e1f3cbf466e3eebb2329593e59c3ca66e1
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jan 31 01:00:39 2007 +0000
ib-verbs working condition, SIGPIPE complete
* glusterfsd/src/glusterfsd.c, glusterfs-fuse/src/glusterfs.c:
- handling SIGPIPE (signal (SIGPIPE, SIG_IGN);)
* transport/ib-verbs/*:
- basic working condition.
commit 17e3f19169a24a21188a9b41a877228c688e30b4
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jan 31 00:41:24 2007 +0000
bug fix in aio, background retry to server on mount option
xlators/performance/aio: bug fix during file release
transport/{tcp,ib-sdp}/client: support "option background-retry off" to
fail mount if server is unreachable at
mount time. default now is to succeed and
retry connection later
commit a6772558f593996de705d8323742e3d12abd6544
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Tue Jan 30 13:56:20 2007 +0000
commit 8d911bce2d5ab991c41701eb42b58b58fed5aad3
Author: Krishna Srinivas <krishna@zresearch.com>
Date: Mon Jan 29 13:21:27 2007 +0000
Changes to allow configuration of the lockserver in the unify translator.
commit ba6e16a5c6c1dca42f6cbcd104d0ddef18d96239
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jan 29 03:17:17 2007 +0000
ib-verbs bug fix + code cleanup.
* Fixed issues with changing wr_size.
* Buffer linking in case of higher buffer size is fixed.
commit 16c8498df733d079f96367f2b2baf5123d0604e1
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jan 27 23:43:28 2007 +0000
locked dictionary support
commit b1fe6b5b2640c4b93f96bb95277cb2aabf2bfc2c
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Jan 27 20:56:28 2007 +0000
ib-verbs transport _partially_ working
* all syscalls, file I/O with less than 128k block size are working.
* Need to fix few issues with buffer management.
* With lot of load, need to increase the 'work queue size'.
commit f21902d3da6e7b25693c4e5bdd851a990f1a351e
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Jan 27 16:59:00 2007 +0000
transport/*: made read/write to sockets locked for threaded environment
xlators/performance/aio: got it working
commit 49644cafe924882496a280d71ecd9c29548de306
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jan 26 21:59:53 2007 +0000
ib-verbs enhancements
* Basic Queue-ing implementation complete.
* Flow of the system ibv_* calls, embedding each with transport exports is pending.
* Test pending (No power as of now :|)
commit ac238f805a265184c37824b4fd0167877f95f419
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jan 26 18:15:52 2007 +0000
bug fix in fuse-internals
removed reference to frame after STACK_WIND since write-back would'v unwound before STACK_WIND returns
commit 31aa54d59a56de8eb262dac24f3f5b377294d4cc
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jan 26 17:44:57 2007 +0000
build break fixes :-)
commit 5e373ee1fea4a57ba10059c42750c6953968e1c1
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jan 26 07:40:34 2007 +0000
ib-verbs _almost_ complete code
commit 84d613cb17d5dbad5cef4335d6c5c29a4f71a442
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jan 26 04:54:31 2007 +0000
0-copy enhancements in protocol and fuse
commit c32a6835e1ed3dff1e58be2e3cc609a8415d8b2d
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jan 25 15:11:04 2007 +0000
ibverbs intermediatory commit
* Added .writev. (.readv pending)
commit d38247e141c312ef65e91f1b29c40e281fc9430c
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jan 25 07:44:02 2007 +0000
ib-verbs intermediate commit
* Added basic queue structure (ie, creating two QP per connx) in the design.
commit ab356e442bbac03f542830c7a161deb4204b18f6
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jan 24 21:31:39 2007 +0000
ib-verbs intermediate commit.
* configure.ac :
- added '--disable-ibverbs' option. (looks for libibverbs)
* transport/ib-verbs
- basic functions changed to work with ibverbs. --NOT FOR USE--
- testing in progress.
commit 805768b4b63fe478613951645448ebed4b7ba771
Author: Anand Babu <ab@zresearch.com>
Date: Wed Jan 24 03:23:34 2007 +0000
1.2.3 updates with install-server and install-client support. Also missing standard files added.
commit 337bb4ab4b3e446e1f6e9c992c12bd0d57463a2b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Jan 19 10:53:55 2007 +0000
Added xlator/features/Makefile.am, which was missing.
commit 78d456b83ac5588c5bfa6c581f040c13eade0d60
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jan 18 03:29:42 2007 +0000
* Added 'features/' directory to xlators dir.
Moved filter into it.
Mirror should also get created here.
commit 144ebcf1014f823aecd2646f70877fe9fe8af954
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jan 18 01:46:41 2007 +0000
* transport/ib-sdp/client:
- changed dict_get (remote-subvolume) to data_from_dynstr ()
* xlators/storage/posix:
- UNWIND with ENOSYS in posix_lk
commit c2b939132c8a183cc880acf1e9957f19154e7176
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jan 16 16:06:21 2007 +0000
* Added code to support forward/backward compatiblity in
protocol/server (for the opcode).
* Added check for "type" in the volume spec.
commit 80daa0cc8aa34ce01db8a33ada4f58548dd08ddd
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jan 11 13:58:58 2007 +0000
Version 1.2.1
* xlators/protocol/server:
- Added subvolume option.
commit 6b9d13041216ed95aa1eadbccd2999ea52956ad6
Author: Anand Babu <ab@zresearch.com>
Date: Wed Jan 10 21:06:34 2007 +0000
Made volume specification files and its examples more understandabe
commit f9b028e02924278955ecefb4e295343781afb45d
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 18 11:30:52 2006 +0000
fixes in write-back and common-utils
commit d725a867f086aa7a3bc8feb029ab3d33afc25386
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 18 07:57:36 2006 +0000
write->writev conversion fixes
fuse-internals.c: fixed iov_len to 'size' rather than 1
dict.c: fixed dict_serialized_length and dict_iovec_len
commit 5143ee72a88c27dd10f76332e0aa721f06ed00c3
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Dec 17 14:59:05 2006 +0000
write->writev transition
libglusterfs/src/dict - added support for dictionary to hold vectors
libglusterfs/src/default - added default functions for vector based write
xlators/* - transition from write to writev
commit 822d9cf7e7fe792440e581cca9bc60d55adbf6b0
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 15 08:19:59 2006 +0000
fixed another typo in unify_getattr :O
commit a3cdf271909216bc3e2b8808cefae58e55d65996
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 15 08:10:32 2006 +0000
fixed typo in unify
commit c9f1d9ac95997f0e12b9d2c0a6ff514210277530
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 15 08:06:17 2006 +0000
unify_getattr optimize
after first success do not wait for remaining misses from servers
commit 618fc16176d66f8b85e95465116c6c95adeeea4d
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 15 07:57:42 2006 +0000
unify_open() enhancement
unify open returns on first successful reply and ignores remaining replies
commit 4dc9658cd102f7bdd39a6a6c2082a57536acaa7d
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Dec 15 06:43:16 2006 +0000
locks in unify_open are removed.
* xlators/cluster/unify:
- removed locking of the path while opening a file are removed.
commit 1488c0c9e863282314e41b003ccdd1fc56ce5a18
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Dec 15 05:44:22 2006 +0000
unify_rename return value updates
* xlators/cluster/unify:
- updated return value of the unify_rename, in case newpath is a directory.
commit a389cf8469f850b246206c98683f71be6ceff65c
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 15 05:26:17 2006 +0000
fix in lock
typo fixed in lock
commit f487632cf0e38fc6abc48d2c340ab727b9c640d5
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Dec 15 05:19:28 2006 +0000
updates in unify_readdir
* xlators/cluster/unify:
- unify_readdir_cbk updated to pick the directory list from the first non-error returns.
this solves the dependency on any server for showing directories.
commit 424f8e0d50f9a63133e4cf04cdb77ea4c18bfde1
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 14 14:42:14 2006 +0000
code cleanup
cleanup of naming conventions
commit bf330761f9929e2f20b721a6d1421a6648fbf252
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Dec 14 04:03:56 2006 +0000
protocol.txt and irc-log.txt removed
commit ecff39f22caa53a34b1cd8161f13cee8871bb1fd
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 13 21:51:53 2006 +0000
xlators/protocol/server/src/lock.c:
fixed bug while unlocking (typing mistake)
commit 5ed0e6a41299be44efc601d4b435ce8c101bb926
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 13 18:20:07 2006 +0000
read-ahead: fix referring to file after unrefing it
commit 8be2e4cc8739bfc36d1bfdd632d310dac0696722
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 13 17:38:19 2006 +0000
commit ce7fc77d53742611a8bf40bc9d95b6267d92ef9b
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 13 17:04:04 2006 +0000
fixed leak in write-back
commit 1a5b55d2789ad3d205e7b8fec2b216d316ba0ae3
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 13 14:40:20 2006 +0000
removed debug messages in stat-prefetch, makefile fixes for make dist over doc
commit d1db7c1c7c49c31a877d3ff28f98cad0998f3b35
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 13 14:17:17 2006 +0000
glusterfs-fuse: use -s and -f instead of -f alone
commit c74f907131732d3194cc64d5009322edf4736512
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Dec 13 13:21:09 2006 +0000
unify_rename for directories solved.
* added doc/examples/Makefile.am
* added feature of rename of directories in unify.
commit 51a1051276fd6eaaad5a3b2b53aa05f42aa97ea6
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 13 07:20:21 2006 +0000
xlators/protocol/client:
handle corner case when server dies and previous reply already arrived
at socket
libglusterfs/src/defults.c:
fix default_write parameter to 'off_t' from 'mode_t'
commit 0506d5c49adde66f9fe1adcc5ef49c839594c349
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 13 05:29:29 2006 +0000
glusterfs-fuse: getspec works. use IP or IP:PORT instead of filename
proto-srv: getspec fixed to work, option client-volume-filename in
protocol xlator support
commit 1c8e072ca2f7288cd48d6692f0ca1c42cab08e2a
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 12 23:13:01 2006 +0000
libglusterfs/src/xlator.c: double linked list of xlators instead of single
xlators/protocol/server: auth (allow-ip) is now part of protocol/server in
a new syntax
commit 2005cb4abd8765b91dc0704456feffd1c2d9c579
Author: Anand Babu <ab@zresearch.com>
Date: Tue Dec 12 22:05:45 2006 +0000
volume spec changes, more examples and new server default
commit 4ef5a2cf75c0bc3d4caf91d0a92f8b87a175953f
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Dec 12 09:57:46 2006 +0000
mem leak fix in stat-prefetch.
* xlators/performance/stat-prefetch:
- memory leak in stat_prefetch_lookup got fixed.
* configure.ac:
reverted back changes as the version itself was 1.1, not 1.0.
commit f5607e3136ff42e1024e79b8ff1348a6d96f358a
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Dec 12 08:57:03 2006 +0000
bug fixes in stat-prefetch and unify
* xlators/performance/stat-prefetch:
- added unlink, utimes, chmod, chown, truncate, rename.
all these functions flush the cache. (this solved the issue with kernel compile).
* xlators/clusters/unify:
- bugs with referring to 'frame->local' after getting free'd are fixed.
* configure.ac:
- changed subversion from 'rc1' -> 'rc3'
commit 8a2247961292f566e2a8f958a5f48acea6a300b7
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Dec 12 07:10:10 2006 +0000
configure.ac: release name set to 1.1-rc1
read-ahead: correct flushing offsets
commit 83f27e5e3b5ae33cb573d81095fb0cb2949cc8de
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 11 22:44:39 2006 +0000
default page size changed to 128kb in read-ahead
commit 6827d9eece4f1cbc62e6b3d8a0beaf4d3021e000
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 11 21:52:12 2006 +0000
read-ahead optimize
estimate file size end and do not read-ahead beyond the limit
commit fcc923032b91ec73d2dacccc01fc68ba5e37d59f
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 11 21:38:34 2006 +0000
fix looping logic in stat-prefetch
commit 12a8fe97c3f0aedbdb3710836724f0a53b70b33c
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 11 21:16:37 2006 +0000
fixed another refernece to 'local' after STACK_UNWIND
commit 8e771e853fe6f0f339dd6b28435ae8fa465abdaf
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 11 21:13:21 2006 +0000
readdir fix in unify.c
unify: after STACK_UNWIND code was referring to frame-local which will
be free'd at the peak of UNWIND
commit a372c00c9f538736a4b55f3c2f0d9a075763290a
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 11 19:55:11 2006 +0000
deadlock bug in fuse-internals.c fixed
deadlock when glusterfs creates file and user has interupted creation in the mean time - fuse_create_cbk holds lock and calls forget_node which again holds same lock and goes into deadlock
commit ee632ab6ab1d0605be0c6e8a881dfcc0abb4497e
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 11 19:28:30 2006 +0000
fix in client-protocol
fix opcode for releaedir to OP_RELEASEDIR
doc/server-volume.spec.sample: update with filter for readonly
commit 8764f2e2f2f52c65d7eb5e6e5f01f97ba5a35423
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Dec 11 18:15:44 2006 +0000
corrected sample 'client.spec' file.
* doc/client-volume.spec.sample:
- corrected options of write-back and readahead translators.
- commented stat-prefetch translator (saw some issues with LARGEFILES while using this).
commit 4bb3ace014fa1b6dc015522ebb343de9a71c6d72
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Dec 11 12:05:01 2006 +0000
bugfix and minor enhancement
stat-prefetch: fixed looping condition during flush
read-ahead: reply and then read-ahead
commit b32c6108bdb4f7fc959173c010f7d4c1b234d946
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Dec 10 23:30:33 2006 +0000
bugfix in protocol.c
libglusterfs/src/protocol.c:
do not destroy dict if protocol unserialize failed (it will be NULL)
configure.ac:
enable --disable-client to disable building of client
commit cb533e1fbd75e1abe55b66f00d94616cad46357b
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Dec 10 16:56:24 2006 +0000
stat-prefetch ported
xlators/performance/stat-prefetch:
* ported to new xlator framework
doc/client-volume.spec.sample:
* updated examples with supported options and to load all performance
xlators by default
commit ebe89e5f28d36cd83d21d8cd63444dd5a9578008
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Dec 9 20:01:31 2006 +0000
translator renames
optimizer/* -> performance/*
optimizer/io-cache -> performance/read-ahead
commit 624225872441406c17d85a4bc19288015e697ecc
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Dec 9 15:05:43 2006 +0000
write-aggregator
write-back enhanced to write-aggregator.
"option aggregate-size <bytes>"
setting <bytes> to 0 makes it work like old write-aggregator
commit 174f7f143c71063b729b257a6148c8948c40398a
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 8 23:16:17 2006 +0000
filter ported
filter xlator ported to new model
commit 7778a13e2f3566b971a7fcd38c1b7c9d862396c2
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 8 22:35:01 2006 +0000
remove write-aggregate
write-back will be enhanced to aggregation functionality
commit 25b296362988af88604feaab115fe6d730265403
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 8 22:22:55 2006 +0000
io-cache bugfixes
xlators/optimizer/io-cache:
* io_cache_fill_frame - fixed bug in calculating offset
* read_ahead - floor the begin offset
commit f1bde91d4578a4384fdb94071c480e7be64bf084
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Dec 8 15:31:59 2006 +0000
io-cache enhancements
xlators/optimizer/io-cache:
* 0-copy for incoming data
* _LOT_ of bugfixes
xlators/protocol/client:
* changes to enable 0-copy in io-cache (use dict_ref and dict_unref)
removed transport/vapi directory
commit b623ce09d3c3a0b378b96c2d2c0bb12169ec4519
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Dec 8 11:50:48 2006 +0000
changed transport/vapi to transport/ib-verbs
commit 4ab24cb245eb1669f12064f6f256a0fabd2f23d1
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 6 20:04:15 2006 +0000
added missing io-cache.h
commit 266054c0b1c766b5a98d813eea7c7a98a8b72a1c
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Dec 6 19:46:42 2006 +0000
io-cache - partial commit
xlators/optimizer/io-cache:
* implements read-ahead functionality
commit 210c69d32641a706c50d52dde04ed368313a985f
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Dec 6 17:18:56 2006 +0000
* transport/vapi:
- moved device lookup into vapi_ibv_init ().
commit ad0df0a6161253a61f4e2963014bb83da6e50a53
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Dec 5 20:15:33 2006 +0000
vapi transport in compiling state
* basic functions required for ibverbs added. both vapi/client, vapi/server compiles.
- it needs libibverbs as prerequisit.
* the check for library is not added yet to configure.ac. Need to add the check.
commit f570bd23c5139e42a879efcd4d7da8fffee3ae45
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Dec 5 11:27:40 2006 +0000
vapi transport layout added.
* transport/vapi/ added.
commit 1ee37d8fb68a1968261797f2ff65362686a2dd42
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Dec 2 03:44:29 2006 +0000
0-copy - more stuff
libglusterfs/src/dict.c:
* dict_unserialize does not copy data
libglusterfs/src/protocol.c:
* gf_block_unserialize[_trans] - use dict_unserialize
xlators/protocol/client/src/client-protocol.c:
* client_protocol_interpret() - changes to use 0-copy
xlators/protocol/server/src/proto-srv.c:
* proto_srv_interpret() - changes to use 0-copy
commit 0ac4ba5a91b11b04a8abd7f7a63db8c60dc46124
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Dec 2 00:46:13 2006 +0000
0-copy implementation
libglusterfs/src/common-utils.[ch]:
* full_readv()/full_writev() - ensures readv and writev completely write
libglusterfs/src/dict.[ch]:
* dict_ref()/dict_unref() - ref and unref functions to dict object
* dict_t->extra_free - hacky pointer to implement 0-copy
* dict_iovec_len() - calculate length of vector needed to serialize dict
* dict_to_iovec() - fill iovec to serialize dict
libglusterfs/src/protocol.[ch]:
* gf_block_iovec_len() - calculate lenght of vecotr needed to serialize
* gf_block_to_iovec() - fill iovec to serialize protocol block
transport/tcp:
transport/ib-sdp:
* implemented _readv and _writev
xlators/protocol/server/src/proto-srv.c:
* generic_reply() - use vector based 0-copy writev
xlators/protocol/client/src/client-protocol.c:
* client_protocol_xfer() - use vector based 0-copy writev
commit 7e460a4f4e86d4f16bb29500aa48deccb5225b80
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Nov 30 09:34:12 2006 +0000
Initial Import for 2.3 branch
commit 8c02213bcc901f1666fe7ebd013266b4839d5d35
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 29 00:59:27 2006 +0000
supress forced debug messages
glusterfs-fuse/src/fuse-internals.c:
* forced debug messages removed
commit 6f61d6ca2ec32c691709576d82b707bea2e8032a
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 28 20:29:20 2006 +0000
'make dist' bug fixes
* configure.ac:
- removed Makefile definitions for incomplete xlators and glusterfs-shell.
* doc/Makefile.am:
- updated with new document names.
* */Makefile.am:
- updated noinst_HEADERS section.
commit 23f6b6ac0c74c50487d24d679c0141521133e6ce
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Nov 26 06:41:14 2006 +0000
* xlators/storage/posix/src/posix.c:
- in posix_stats () changed "stats->disk_usage = (f_bfree - f_bavail) *f_bsize;" to
"stats->disk_usage = (f_blocks - f_bavail) *f_bsize;"
* schedulers/alu/src/alu.c:
- new frame was created for each mop->stats call, and in _cbk, only the last frame was getting destroyed. Fixed.
commit 644886b5fc2bd4699e056ef111d1597c691f8033
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 26 02:51:21 2006 +0000
opendir is fd based
glusterfs-fuse/src/fuse-internals.c:
* fuse_opendir, fuse_releasedir - use fd for context
* comment out locking code
xlators/storage/posix/src/posix.c:
* use dict with fd in posix_opendir and posix_releasedir
xlators/protocol/client/src/client-protocol.c:
* create dict and destroy it in client_opendir and client_releasedir
commit 67e5b8a3143851db9a89e8d9a4d08a3bc7523a7e
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Nov 25 16:16:58 2006 +0000
reverted previous patch
xlators/storage/posix/src/posix.c: Revert previous patch.
lchown does not make sense; symlink is always 777.
glusterfs-fuse/src/glusterfs.c: main: blank out argv[1-] completely
commit e488f5b38ec893c5cd6df19aac1b83cb77b3e595
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 22 22:00:05 2006 +0000
chmod to lchmod
xlators/storage/posix/src/posix.c:
* change chmod to lchmod
commit c72f311f18c2e2b61b7d31a5f466b423c59fb27b
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 22 20:43:55 2006 +0000
posix fix
changed chown to lchown
commit 9fde0b006a607d5de5ab7d08e8b9ea0fdced059e
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 22 15:20:08 2006 +0000
Unify and alu updates
* schedulers/alu/src/alu.{c,h}:
- removed 'random ()' call in case of scheduling many nodes, added RR method.
* xlators/cluster/unify/src/unify.c:
- fixed a bug with unify_newpath_lookup_rename_cbk (), which was causing the kernel compile to fail with unify.
----
if (op_ret == 0) {
local->found_xl = prev_frame->this;
local->op_ret = 0; <--- this line was the killer. removed.
}
----
commit 35ac10235d809dfb1f9fce140c8c27f9e73c31af
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 21 21:45:45 2006 +0000
* client-protocol.c:
mop_stats () was setting "LEN" whereas server/protocol was checking for "FLAGS".
Changed to "FLAGS".
commit 7007d0d9a6a854940819e0e280a6580d3854ba57
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 21 06:19:11 2006 +0000
direct_io and argc
* hardcode argc=13 for fuse_mount
* turn on direct_io for files which 'write' and open with O_LARGEFILE
commit 90b5d1e97dd722b31ea7cb969f19c4153d54f6ba
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 21 05:08:35 2006 +0000
file/record locking support
glusterfs-fuse/src/fuse-internals.c:
* fuse_getlk(), fuse_setlk(), fuse_lk_cbk() - locking handlers from
fuse_lowlevel
libglusterfs/src/xlator.h:
* add lk() member to fops and rsps
libglusterfs/src/glusterfs.c:
* add OP_LK to enum of opcodes
libglusterfs/src/defaults.[ch]:
* add default_lk(_cbk) implmentation
libglusterfs/src/xlator.c
* add SET_DEFAULT_FOP(lk)
xlators/cluster/unify/src/unify.c:
* unify_lk and unify_lk_cbk implementation
xlators/debug/trace/src/trace.c:
* trace_lk and trace_lk_cbk implementation
xlators/protocol/client/src/client-protocol.c:
* client_lk(_cbk) implementation
xlators/protocol/server/src/proto-srv.c:
* fop_lk(_cbk) implementation
xlators/storage/posix/src/posix.c:
* posix_lk(), lk_thread_fn(), struct lk_pass - locking implmenetation
commit 45de0cb3f9e3cbd83fc5255f4dafe924d8968254
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 19 18:26:48 2006 +0000
utimes fixes
libglusterfs/src/libglusterfs.h:
* updated OP_UTIMES name
libglusterfs/src/xlator.h:
* updated utimes prototype to use 'struct timespec *' instead of
'struct timeval *' as argument
glusterfs-fuse/src/fuse-internals.c:
* do_utimes() - typecast tv[2] to (struct timepsec *) to disable warning
libglusterfs/src/defaults.[ch]:
* default_utimes() - change 'struct timeval *' to 'struct timespec *'
in parameter
xlators/storage/posix/src/posix.c:
* posix_utimes() - change 'struct timeval *' to 'struct timespec *' in
parameter
xlators/cluster/unify/src/unify.c:
* unify_utimes() - change 'struct timeval *' to 'struct timespec *' in
parameter
xlators/debug/trace/src/trace.c:
* trace_utimes()
- buf in strftime() call was still used as utimbuf causing compile error.
- change- change function argument to 'struct timespec *' from 'stmeval *'
xlators/protocol/client/src/client-protocol.c:
* client_utimes() - change parameter from 'struct utimbuf *' to
'struct timespec *', caused compile error.
xlators/protocol/server/src/proto-srv.c:
* fop_utimes()
- change struct timeval to struct timespec, caused compile error.
- rename atime_data and mtime_data in if() to atime_sec_data and
mtime_sec_data, caused compile error.
- change call to fop_utime_cbk to fop_utimes_cbk, warning->link error
- STACK_WIND change fops->utime to fops->utimes, compile error
commit 2760bfeab05ba869e9b5bb5faeb9629a44e25d20
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Nov 19 17:47:37 2006 +0000
changes in fuse-internals to handle utimes function call.
* glusterfs-fuse/src/fuse-internals.c:
libglusterfs/src/defaults.c/h:
libglusterfs/src/xlators.c/h:
xlators/cluster/unify/src/unify.c:
xlators/storage/posix/src/posix.c:
xlators/debug/trace/src/trace.c:
xlators/protocol/server/src/proto-srv.c:
xlators/protocol/client/src/client-protocol.c:
- Changed utime to utimes in all the above files. Also changed the argument from 'struct utimbuf' to 'struct timeval'
commit 8bc5eb7a5d1db38ef0bb85f529b65f23cb1a7bf8
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 19 01:43:34 2006 +0000
reconnection logic leak fixed
xlators/protocol/client/src/tcp-client.c:
* do_handshake() - copy remote-subvolume string to prevent double free
commit 4916eb73c2d45e2ef65c79f3ee99039232f35f91
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Nov 19 00:08:55 2006 +0000
disable client-side caching of attributes
glusterfs-fuse/src/fuse-internals.c: glusterfs_fuse_new_common: make all timeouts zero.
commit 09b95278da4f578905cda568fb6ac90148d57590
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Nov 18 18:35:25 2006 +0000
do umask(000) in posix xlator
Files and directories on the server should be created using the umask on the client side
(client-side kernel appropriately modifies creation modes). Therefore, use a 000 umask
on the server side.
xlators/storage/posix/src/posix.c: init: umask(000);
commit d255f4b2d68b471800f45c02cd127a580b34f84f
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 17 23:43:20 2006 +0000
port to fuse 2.6
glusterfs-fuse/src/fuse-bridge.c:
glusterfs-fuse/src/fuse-internals.c:
* changes to incorporate fuse-2.6
configure.ac:
* check for fuse-2.6 (function 'fuse_req_interrupt_func')
* comment guile check as shell is not built
commit a5ab7896ae01297694b45692a1a4f83e7496c92b
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 17 12:40:00 2006 +0000
"alu" updates
* scheduler/alu/src/alu.c:
- Creating the frame for mops->stats call was incomplete.
- Prototype of _cbk () was missing call_frame_t *prev_frame.
- Create command works in basic case. Extensive testing required.
commit e54cc1f9ff382e8625bc3291d235a3fe1723b78f
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Nov 17 10:40:51 2006 +0000
change ownership to that of caller during file creation
xlators/transport/posix/src/posix.c:
posix_create & posix_open: do a chown() to CALLER_UID and CALLER_GID after creating a
file
commit 66130a83a3c9336607605f8e1f82c33ccf4a1ff9
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 15 00:25:22 2006 +0000
mount/df and ps output
glusterfs-fuse/src/glusterfs.c:
* sprintf argv[0] to "[glusterfs]" so that it appears so in 'ps'
glusterfs-fuse/src/fuse-bridge.c:
* set option "-o fsname=glusterfs:<pid>" so that it appears so in
'mount' and 'df' output
commit 41fc29c615e77556589f61e5d417ca37a5e2feaf
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 14 09:48:52 2006 +0000
Bug fixes in unify
* xlators/cluster/unify/src/unify.c:
- rename and link _cbk were checking for if (op_ret == 0) in side
(call_count == child_count) segment, changed it to
if (local->op_ret == 0).
- tested and working fine. Kernel compilation happening.
commit 71fc356a05ae7867cf9cef5fca93ef8bb8f1c6af
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 14 06:47:08 2006 +0000
unify bug fixes
* xlators/cluster/unify/src/unify.c:
- in chown_cbk () and chmod_cbk () local->op_ret was always -1;
commit 04663979eab298ddbc9e5d679e22d9132c649751
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 14 06:36:58 2006 +0000
reverting back if logic changes as earlier logic was faultless.
* xlators/cluster/unify/src/unify.c:
- reverted back the if logic chages.
commit 65999ae70c355f7dbb0df0cb22a07b3ec1058e89
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 14 02:57:41 2006 +0000
* xlators/cluster/unify/src/unify.c:
- in unify_open_cbk () local->op_ret was always = -1;
commit 835c4a4a49d7d978d9e99fb2c35f5c4e571dfc32
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 14 02:43:54 2006 +0000
unify bug fixes
* xlators/cluster/unify/src/unify.c:
- changed the if statement from
if (op_ret == -1 && op_errno != ENOENT && op_errno != ENOTCONN) {
to ->
if (op_ret == -1 && (op_errno != ENOENT || op_errno != ENOTCONN)) {
commit 2b118fc7353a3c702a19ab6660bb9bd31e2406a7
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 14 01:53:47 2006 +0000
typo in unify.c
commit 054cf3912e73777fa7fa1da2e7aefcd375c4e086
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Nov 14 01:26:36 2006 +0000
code review fixes for unify
xlators/cluster/unify/src/unify.c:
* macro LOCK_DESTROY to destroy locks after STACK_UNWIND in all _cbk
* handle ENOTCONN gracefully in all fops
* use EBADFD instead of ENOENT in case of missing file_ctx_t everywhere
* use 'struct stat' and 'struct statvfs' instead of pointers in local->
to avoid unnecessary calloc and free
* unify_{getxattr,listxattr}_cbk
- free (local->buf) if not null (in case of unify corruption)
* unify_ftruncate_cbk
- pass 'stbuf' argument to STACK_UNWIND
* unify_{ftruncate,fgetattr}
- pass dummy stat to STACK_UNWIND in case of EBADFD errno
* unify_{read,write,fgetattr,ftruncate,fsync,release,open,create}
- use file_ctx dict with child node pointer as value
* unify_truncate/unify_utime/unify_setattr - missing allocation of buf
* unify_readlink_cbk
- fix unconditional free of local->buf
* unify_mkdir_lock_cbk
- free local->path if lock failed
* unify_unlink_lock_cbk
- free local->path if lock failed
* unify_unlink_unlock_cbk
- free (local->path) and local
* unify_create_cbk
- code assumed file creation is always succssful for setting file_ctx.
* unify_mknod_cbk
- set errno 'EEXIST' in case path was already existing
* unify_mknod_lock_cbk
- free local->path if lock failed
* unify_rename_oldpath_lookup_cbk
- reset call_count to 0 before calling unify_rename_newpath_lookup
- remove LOCK_INIT on already initialized lock
* unify_rename_unlink_newpath_cbk
- new cbk for unlinking existing newpath in rename
* unify_rename_newpath_lookup_cbk
- if new path exists on some node, unlink it
- wrong logic checking for existing newpath (should be || instead of &&)
* unify_rename_lock_cbk
- free local->buf, local->path, local->new_path if lock failed
* unify_link_lock_cbk
- free local->buf, local->path, local->new_path if lock failed
* unify_link_oldpath_lookup_cbk
- reset local->call_count to 0 before probing for newpath
* unify_link_newpath_lookup_cbk
- wrong logic checking for existing newpath (should be || instead of &&)
* unify_link_unlock_cbk
- pass 'stbuf' to its STACK_UNWIND
* unify_{chmod,chown,mkdir,open,create,mknod,symlink}_lock_cbk
- pass null stat buffer to STACK_UNWIND if lock fails
* unify_create_getattr_cbk
- less error prone logic with op_ret/errno to find existing file on
corrupted unify volumes
commit 1956e1eeb89af7ae36ddaeb863a1e820f13e7db7
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Nov 13 09:00:41 2006 +0000
* xlators/cluster/unify/src/unify.c:
- corrected the behaviour of 'symlink', 'rename', and 'link'.
commit b34ffbce5d062c7abceb29322e7ea7be083fb2da
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Nov 12 19:58:48 2006 +0000
* xlators/cluster/unify/src/unify.c:
- Fixed a bug in mknod_cbk (it was not setting proper op_ret value)
- Fixed issue of symlink on all nodes by fixing unify_readdir_cbk ()
commit e4ce5c6191ad060afd381d346edf02c8e9f6e417
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Nov 12 19:05:25 2006 +0000
* glusterfs-fuse/src/fuse-internals.c:
- Commented /* if (state->flags) fi.direct_io = 1; */
* transport/ib-sdp/client/src/ib-sdp-client.c:
- sin_family = AF_INET from AF_INET_SDP (only during socket creation its AF_INET_SDP)
(with this fix, it works on ib nodes)
commit e062d412341fbd989e8b90a258b4bdffbd3a80c2
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Nov 12 16:58:09 2006 +0000
ib-sdp updates
* transport/ib-sdp/* :
- Updated all the source according to the changes done in transport/tcp.
commit ef431d51d4ba3a37f4768b117b146a22771495eb
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 12 11:21:13 2006 +0000
readdir fix in unify
xlators/cluster/unify/src/unify.c:
* readdir_cbk - bug in calculation of local->last. bug hits only
if more than two child nodes exist
commit d390ecdd954aaf3e891c7d54e02f16d23eaa9131
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 12 05:56:32 2006 +0000
bug fix in lock.c
xlators/protocol/server/src/lock.c:
* unlock_impl() - move STACK_UNWIND from end of function to end of
if (path) { .. } else { .. STACK_UNWIND() } to prevent double
UNWINDing
commit f232eac68b8ba4a8188c6352d25e63fc285435b7
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 12 00:06:03 2006 +0000
mem leak fixes
xlators/protocol/server/lock.c:
* unlock_impl() - frame was getting leaked. now STACK_UNWIND'ed
xlators/posix/src/posix.c:
* posix_create and posix_open was leaking asprintf'd fd string
commit aab9e84b996a679f0939c0ce8268fa53cec05943
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 10 07:46:16 2006 +0000
leak in reconnection logic
transport/tcp/client/src/tcp-client.c:
* tcp_connect () - dict_copy avoided for second call of tcp_connect
for reconnection logic
commit 202aadf9198deb182f29e53b7b8740974c49f781
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 10 05:48:01 2006 +0000
corner case bugfixes
xlators/protocol/server/src/proto-srv.c:
* transport_disconnect if submit of reply failed
glusterfsd/src/glusterfsd.c:
glusterfs/src/glusterfs.c:
* realloc callback data region too along with pollfd region
commit 705ac722162ace411b83716830d325a86485777c
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 10 04:20:54 2006 +0000
some more memory leak fixes
transport/tcp/server/src/tcp-server.c:
* pthread_locks were getting leaked
* 'this' was getting leaked in fini() :P
commit 07721b5a8a7243ae69f4b56c5cb074b81a8701ed
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 10 03:23:11 2006 +0000
notify functions enhancements, some memory leak fixes
xlators/protocol/server/src/proto-srv.c:
* renamed priv->fctxl to priv->open_files
* proto_srv_notify() - call cleanup when proto_srv_interpret returns -1
* proto_srv_cleanup() - close all open files, not just destroy dictionary,
open file_ctx was getting leaked
- free ->priv which was getting leaked
* setvolume () - frame was getting leaked. calling STACK_DESTROY
xlators/protocol/client/src/client-protocol.c:
* client_protocol_notify() - call cleanup when client_protocol_interpret returns -1
libglusterfs/src/dict.c:
* dict_unserialize() - every 'key' was getting leaked
* data_from_dynstr() - new primitive
libglusterfs/src/protocol.c:
* leak in gf_block_unserialize_trans - allocated header was leaked if peer
had died.
commit ff7a75cb9edb3900591168c6af2f6da8fad331aa
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 10 01:16:40 2006 +0000
umount exits glusterfs-fuse
glusterfs-fuse/src/fuse-bridge.c:
* exit in fuse_disconnect. need to implement graceful umount on translator
commit 32519768c5d9f05640c6706c066e8bf62bdef1ac
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 9 23:02:37 2006 +0000
subvolume count in spec file
all xlators now check for appropriate number of subvolumes in init()
commit 4bc6c40e6d914b3fd1a71399c11b4bd5726edcc2
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 9 22:44:20 2006 +0000
write-back and minor cleanups
xlators/protocol/client/src/client-protocol.c:
* dict_destroy (request) in error cases before STACK_UNWIND
xlators/optimizers/write-back:
* new optimizer for implmenting write-back functionality
libglusterfs/src/stack.h:
* new static inline - copy_frame to create a new frame instance
identical to the passed frame
libglusterfs/src/xlator.c:
* added SET_DEFAULT_FOP for create (was missing)
doc/client-volume.spec.sample:
* add write-back in default spec
commit 77fae67a88be9bb62f7c5ee00a96d1a32bcb6c37
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 9 03:50:32 2006 +0000
xlators/protocol/client/src/client-protocol.c:
* call client_protocol_cleanup() if transport_submit fails in
client_protocol_xfer()
commit 0d4efc883557d8ebd286911732d542d6771f57cf
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 9 00:55:09 2006 +0000
libglusterfs/src/common-utils.c:
* full_rw() - break when ret == 0 (indicates EOF and need not inspect
errno for EINTR)
transport/tcp/client/src/tcp-client.c:
* transport_submit () - call transport_register to register with main
loop to pick replies after reconnecting with tcp_connect
commit 01ac7fa1eff4a60abaf6cf333bf51b66b5049052
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 8 20:14:37 2006 +0000
* xlator/protocol/server/srv/proto-srv.c:
"BUF" was not sent in reply. which was checked in client protocol, and was always returning EINVAL. Corrected.
commit f2eb7850cfa0878915698ce6fe46ae158bd1b15c
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 8 19:09:07 2006 +0000
* xlator/cluster/unify/src/unify.c:
- setxattr_cbk, listxattr_cbk were using direct pointer to _cbk's argument. Changed it to copy it and keep the new buffer pointer.
* doc/*
- removed glusterfsd.conf
- added glusterfs-design.txt
commit 917b1218d985c2473d691a3154d36e9373ae971a
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 8 17:11:23 2006 +0000
glusterfs-fuse/src/fuse-internals.c:
* turn on direct_io only for non-executing files (executing files
open() with flags=0)
commit 821299bfa2fe83acfe751642a8353e3446c8a54d
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 8 15:55:37 2006 +0000
xlators/protocol/server/src/proto-srv.c:
* CALLER_UID was getting set as root->gid. fixed.
glusterfs-fuse/src/fuse-internals.c:
* fixed deadlock condittion in fuse-internals (held lock
was getting unlocked in callback, and next process trying
to unlink would block the client and hence callback would
never be called) leading to hanging of client
commit db948d8d66c249dbbfeaf6ef406772f676bdedfc
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Nov 8 06:11:28 2006 +0000
kernel compile over unify works :O
* libglusterfs/src/spec.y: removed duplicate token ID.
* xlator/cluster/unify/src/unify.c:
readlink_cbk was assuming op_ret == 0 for success, which indeed was strlen (value).
corrected.
commit a383ff858fd6ac975a8ab9b24300a4074866306a
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 8 04:38:28 2006 +0000
xlators/debug/trace/src/trace.c:
* make all fops static
xlators/storage/posix/src/posix.c:
* removed ugly log messages used for debugging
commit 6babc7b7393beaef889d9e96def51223701bd6b3
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 8 03:59:55 2006 +0000
xlators/storage/posix/src/posix.c:
* fixed proper op_errno in all fops
* made all fops static
* use open(O_CREAT) instead of creat() - caused EBADF on read()
glusterfs-fuse/src/fuse-internals.c:
* state->name is strdup'd everywhere - caused bad corrypted filenames
to get registered in _cbk for the inode::path db.
commit b956bf9067a48a44088ae5e623b19aeec925c818
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 7 12:59:59 2006 +0000
* xlator/cluster/.../unify.c : corrected directory duplication in unify_readdir_cbk ()
commit a476f9b85a11a09da4ef4093a37a02b8c4b88b15
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 7 11:36:39 2006 +0000
corrected lock.c in protocol/server.
* xlator/protocol/server/src/lock.c :
- removed #if 0's.
- there was a problem with 'int32_t ret = 0;'. It used to create problem for first lock, which used to hang.
commit d20d4d2982a06d3d8a104262ca71a5b5c45b3590
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 7 10:42:52 2006 +0000
free the hash table of dict when destroying (:P)
libglusterfs/src/dict.c: dict_destroy: free (this->members)
commit 62fcdcf56703b388dae1c8786696ee80984f9551
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Nov 7 09:24:49 2006 +0000
do STACK_DESTROY after every _cbk in protocol-server
commit fdae28359d6b9fa6d2558ce64a96cb629801c936
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 7 07:42:42 2006 +0000
* Applied Harshavardhana's (<harsha@zresearch.com>) patches to remove warnings in 64bit.
* In unify, buffers are copied (memcpy) instead of just keeping pointers.
This helps to reduce the memory leak as buffers allocated in
protocol/client can be free'd there itself.
commit 568ad8f0dcec0ccd9659e1ecc9277b7a363c2a00
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Nov 7 01:30:10 2006 +0000
* Tested unify with two child nodes.
-> Found that free ()ing memory in client protocol after doing UNWIND is causing problem,
as in (dir_entry_t *) was stored in unify, but when it was written to fuse, it had got
free'd. Need to think of ways for freeing it.
-> Same problems holds good for all struct stat *stbuf s. Need to decide where to free them.
* In unify_readdir_cbk, last argument to STACK_UNWIND was missing.
commit be44359dab37762fc7a92e450c784b571b12c039
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Nov 6 20:01:17 2006 +0000
fixed bug in client-protocol.c
xlators/protocol/client/src/client-protocol.c:
client_protocol_xfer: return value of transport_submit is zero, not len of data
commit ac1922eb1d655a6e93376f7241e50bdff8077340
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Nov 6 18:40:49 2006 +0000
minor bug fixes
commit 44cf03961dd3f5eaf9c1115e6171b38c695f72ac
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 6 15:52:07 2006 +0000
libglusterfs/src/transport.c:
* minor cleanup of transport_event_handler
commit 65841e2436f040d63af027412eda16aa950225ee
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Nov 6 15:40:56 2006 +0000
transport changes done
commit e08714564f0ea4f140f171b62c17870509a682e8
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Nov 6 12:57:13 2006 +0000
* Tested unify with only one client for open/read/write/release.. getattr/readdir.
commit 3555dc5601760536e725c27b16ace5a057b7fc85
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Nov 6 10:45:14 2006 +0000
* Updated callback API, with an extra argument (call_frame_t *prev_frame).
Changed all the xlator, and other modules which uses this.
* Updated Trace. Tested.
commit e275079afc46912556e9a2a4127b9edc892625c6
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 6 05:48:22 2006 +0000
glusterfs-fuse/src/fuse-internals.c:
* do not refer fuse_file_info from request in _cbk as it is on stack
xlators/server/src/proto-srv.c:
* fop_read_cbk() - check for op_ret before using it for buffer length
xlators/protocol/client/src/client-protocl.c:
* open_cbk/create_cbk - avoid memory leak of file_ctx when open had
failed
commit 0fbc9a1f5ec3b9dfcda279c41590f51ce5f53e1d
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 6 03:52:45 2006 +0000
xlators/protocol/client/src/client-protocol.c:
* client_releaes() - free (key) after dict_del (dict, key);
* client_readlink_cbk () - send back 'buf' as char *, without converting
to struct stat.
commit 5420b0f751bc88bc4e1b0da100dca016b110661e
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Nov 6 00:37:53 2006 +0000
xlators/storage/posix/src/posix.c:
* consistant usage of file context
xlators/protocol/client/src/client-protocol.c:
* consistant usage of file context
* set CALLER_UID and CALLER_GID for all calls
in client_protocol_xfer
glusterfs-fuse/src/fuse-internals.c:
* FUSE_FOP_NOREPLY will now not refer to fuse_req_t
commit 56d874eaa9c39fc882dbc29f54f4d87f23974f03
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 5 21:13:02 2006 +0000
xlators/protocol/server/src/proto-srv.c:
* mkdir returns stat info
xlators/protocol/client/src/client-protocol.c:
* mkdir returns stat info
* fd_list is from frame->this->private->xl_private
* cleanup refers to correct pointer for cleaning frames
* open/create/releaes - use file_ctx as a dict
glusterfs-fuse/src/fuse-internals.c:
* fuse_getattr_cbk() - return negated errno as fuse expects
commit 50ae3df590c7057ae7708ca894f1cb64cccd24af
Author: Anand Babu <ab@zresearch.com>
Date: Sun Nov 5 01:11:05 2006 +0000
version update
commit 76bd1d20b776d53fdc7d9a3d3a5ee5b39a542733
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Nov 5 00:54:21 2006 +0000
updated copyright messages
commit d17cb44df84d1d0a13e94f646dfb6ba32db7abaa
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Nov 4 19:47:42 2006 +0000
* finished review and code cleanup of client-protocol
commit 0149029dd61d458cfd3c727e37be06497969df26
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Nov 4 15:55:43 2006 +0000
* Client- Protocol updates.
commit b80e4020c64ea61e9f4888fbc1f0581b82f2bca8
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Nov 4 02:13:16 2006 +0000
* Changes in client-protocol:
- moved all OP_* in switch case to individual functions.
- all functions check the parameters before calling STACK_UNWIND.
commit bf2ab0bb077b2dc57c27ca2adae8a1c2a4955e5c
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Nov 4 00:44:05 2006 +0000
xlators/protocol/server/src/proto-srv.c:
* changed static array to dynamic allocated memory
commit 7caaa248d2283b6851a07df6c826176c504ee439
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Nov 4 00:27:42 2006 +0000
* changed file_ctx_t -> dict_t in xlator APIs.
commit 4e849a11a0fd66a710bb7785c3c869fef9a68612
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 3 22:46:25 2006 +0000
xlators/protocol/client/src/client-protocol.c:
* added 'break;' after 'case OP_CREATE:' which
was flowing into OP_OPEN and sending fake replies to fuse
commit 878eab686e01560644ce5f614c321356640a9b7c
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Nov 3 16:28:56 2006 +0000
cleanup frames when transport is destroyed
client-protocol.c: client_protocol_cleanup: destroy priv->saved_frames
commit f75b18b28c916525ec69f08d4647ce9731f7a75d
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 3 15:51:41 2006 +0000
* Changed uint8_t -> unsigned char and int8_t -> char
* Added Patch by Harshavardhana R <harsha@zresearch.com>
commit 813a8e7fc56eb744abbf5576de7b1933de386b53
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Nov 3 14:41:30 2006 +0000
wrong opcode in client-protocol
xlators/protocol/client/src/client-protocol.c:
* use OP_RELEASE in client_release instead of OP_UNLINK
commit c52275a2ad51bc981dddef6122324f0719575e12
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 3 10:26:13 2006 +0000
* tested for open/read.
commit 100a89743597b28188927b43468bc62c7176b183
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Nov 3 08:40:19 2006 +0000
* Changed Makefile to exclude glusterfs-shell, xlator/filter, xlator/optimizer.
* Changed xlator/filter translators function's API. Still some work needed.
* Added 'blk->op = op' in generic_reply () of proto_srv.c (server-protocol).
* Tested with client-protocol for getattr, readdir, statfs.
Still to check 'open/create/read/write' etc.
* Few corrections in fuse-internals (readdir_cbk).
commit 4508c50db49a6a0163c1f6f54276878ec2c65237
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Nov 2 15:55:17 2006 +0000
fixed bug in proto-srv.c
xlator/protocol/server/src/proto-srv.c: do the free()'ing of stat_buf *after* fop_reply
commit 8dc8c56b2dcfcaf585161d9d56d396c901e89248
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Nov 2 15:35:14 2006 +0000
* Fixed issues with alu (mops->stat was assumed to be single call earlier)
commit d5a4cc2e16a63f3c4aa73e1a54933611b9af9bed
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 2 12:51:16 2006 +0000
xlators/protocol/client:
* client_protocol_interpret - fix switch/case to case on
*_REPLY instead of *_REQUEST
commit 68b513ee8ae9155a006fbd4c77a990f421c24fec
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Nov 2 00:57:32 2006 +0000
xlators/protocol/client:
* check for 'option remote-subvolume' in init()
xlators/protocol/server;
* flush after subumit to transport as POLLOUT is no more
polled in main loop
transport/tcp/client:
* check for mandatory option 'remote-host' in init()
* check for optional option 'remote-port' in init()
* implemeted missing full_write_transport()
* trans->xl_private initialized by xl
transport/tcp/server:
* register initial listening socket with main poll loop
* accept() from main socket in transport_notify, not on priv->sock
* fini() - conditionally close priv->sock if ->connected is true
* set ->ops for new transport object
* set ->fini for new transport object
libglusterfs/src/protocol.c:
* added missing OP_LEN in '\n' checks in unserialize
* append '\n' at last byte of name field, not at end of name
configure.ac:
* remove 'dummy' xlator related lines
commit e804ae72186994e2667eea7cef36019a26d16b81
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 1 16:01:05 2006 +0000
xlators/protocol/server/src/proto-srv.c:
* mop_stats_cbk - removed 'extern' of glusterfsd_nr_clients.
needs a solution!
xlators/protocol/*/src/Makefile.am:
* fixed installation paths and names
xlators/protocol/client/src/client-protocol.c:
* make 'tcp/client' as default transport if not specified
* init() return -1 if transport_load() returned NULL
* tcp_connect() check for priv->connected instead of priv->sock for
calling socket()
libglusterfs/src/transport.c:
* transport_load - return NULL instead of exit (1)
transport/tcp/server:
* check if 'listen-port' and 'bind-address' has been specified before
doing data_to_* and use default values if not given
transport/tcp/client:
* renamed mgmt_ops to mops (dlopen error)
commit 13a0419d19f78405973797c4942c055411982da9
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Nov 1 13:27:12 2006 +0000
* commented out alu's update_stats function - should be made asynchronous
* removed 'dummy' and 'transport/*' translators. (trace is a better example,
and lesser overall maintainance)
commit 9ad20dd1ee8b965209cc7f403d88f642d21990c4
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Nov 1 05:30:12 2006 +0000
added client-protocol
commit 724fc8436d323a22d54f2ac7c51d7dfb84b0ac5e
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Nov 1 05:07:47 2006 +0000
added client-protocol
commit c4d248a18b500a73e864623c71961ec9f2f9f1f8
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Oct 31 23:00:28 2006 +0000
asynchronous lock server
xlators/protocol/server/src/lock.c:
* implemented asynchronous lock server
xlators/protocol/server/src/proto-srv.c:
* implemented lock server as a regluar mop within xlator_t *
* call unlock in cleanup function
commit 7a5b5940e23c0ae2d269f315fd32d7eb6080bd4e
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Oct 31 10:56:43 2006 +0000
* added code to maintain locks, and maintain list of open file contexts in server-protocol xlator.
commit 1e9cad95b9d348def09604c38809726f9e0f9c83
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Oct 31 02:55:40 2006 +0000
mop_setvolume implemented
proto-srv.c:
* implemented mop_setvolume
dict.c:
* added data pointer to dict_foreach
xlator.c:
* added data pointer to xlator_foreach
commit 238c4a250352c6712a95cddcc859797b87b3e4bd
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Oct 30 18:26:29 2006 +0000
modified transport/* to conform to new changes
transport/*.c: conform to changed prototype of notify functions to include event
rename send to flush
commit 84d4f742d1602f2d4639a3b255ad4b8b0d4d75e9
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Oct 30 09:06:41 2006 +0000
* Updated xlator/protocol/server/src/proto-srv.c
- Need to verify the regions marked with TODO.
commit b939269c18e5be6a8e85d1294b873ffbaa2958b6
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Oct 30 01:30:07 2006 +0000
libglusterfs/src/dict.c:
* removed dict_dump
xlators/protocol/server/src/proto-srv.c:
* all code in #if 0/#endif for reference to implement fops using
new transport layer. implemented
- fop_getattr
- fop_readlink
xlators/storage/posix/src/posix.c:
* posix_readlink - allocate extra byte for dest and NUL terminate it
commit 2d2df20de7dfcd3def754988536a4148326dfe10
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Oct 29 21:07:58 2006 +0000
libglusterfs/src/protocol.h:
* enhanced protocol to have 64bit call id in header
* typdef'd struct _gf_block to gf_block_t for consistancy
* 'callid' to be given as argument for gf_block_new ()
libglusterfs/src/protocol.c:
* fixed full_read call in unserialize_transport
* free header_buf and buf in error conditions before returning
* check for protocol limits first before unserializing
* accomodate 'callid' in unserializing/serializing
* changed serializing numbers to hex to prevent truncating
of 32bit numbers in 8byte char strings with octal
* use the more reliable strtol/strtoll rather than sscanf.
libglusterfs/src/transport.h;
* chnaged notify function of transport to include notify event in
parameters.
* renamed transport_t->send() to transport_t->flush()
libglusterfs/src/transport.c:
* call ->notify () for input and exception events
glusterfs-fuse/src/fuse-bridge.c:
* renamed s/send/flush/
xlators/protocol/server/proto-srv.c:
* use the new transport interface
libglusterfs/src/commont-utils.c:
* minor warning fix
libglusterfs/src/dict.c:
* minor warning fix
commit 4accd6de3782bd488fcfe99d0baf573f3c5851ce
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Oct 29 17:22:01 2006 +0000
seperated glusterfsd and protocol/server
* moved glusterfsd/src/{ns.c,ns.h,lock.c,lock.h,server-protocol.c,glusterfsd.h} to xlators/protocol/server/src/{ns.c,ns.h,lock.c,lock.h,proto-srv.c,proto-srv.h}
* added strerror() in gf_log_init failure message
commit 8f9a3351063647063ce9b0d17fedfef4710c70a8
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Oct 29 13:41:02 2006 +0000
* added create in unify. * trace complete.
commit 9b4fa5242b1eefddca0ccdfca1fa67ed6c4b40e9
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Oct 29 07:09:30 2006 +0000
debug/trace translator converted to use the new API set.
commit de137dd4b3111a08a5a62e6a3ed08a8e94e6c56f
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Oct 29 05:11:00 2006 +0000
memory leak fix and disabled debug messages
memory leak fix in posix_release
commit 3af0afd93221db89b3b60c7123a5a2eccd69331d
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Oct 29 02:28:18 2006 +0000
completed fuse changes
all fuse ops are now migrated to new asynchronous translator model.
commit 99d035e2fdf07a0fa91a4f39f3f83f7e471f0217
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Oct 29 01:32:52 2006 +0000
libglusterfs/src/stack.h:
* made STACK_DESTROY and FRAME_DESTROY as static inlines
(previously were macros which caused problems)
xlators/storage/posix/src/posix.c:
* fixed bug in posix_truncate () where stat was not being returned
fuse-internals.c: implemented and tested -
* fuse_mknod
* fuse_mkdir
* fuse_unlink
* fuse_rmdir
* fuse_symlink
* fuse_rename
* fuse_link
* fuse_create
* fuse_open
* fuse_read
* fuse_write
* fuse_flush
* fuse_statfs
* fuse_setxattr
commit 3b945c1c122944d2699223387f77c9ccc7532514
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Oct 28 18:06:21 2006 +0000
changed dict_t *local -> void *local in call_frame_t
* in unify and server_protocol changed local to void * from dict_t *.
commit 4cd2d1c553026173ab970b52d805475c131c5008
Author: Anand V. Avati <avati@80x25.org>
Date: Sat Oct 28 01:24:34 2006 +0000
libglusterfs/src/stack.h:
* added new file for all transaction stack related definitions
fuse-internals.c: finished and tested with posix xlator -
* fuse_lookup
* fuse_getattr
* fuse_setattr (chmod, chown, truncate/ftruncate, utime)
* fuse_readdir
* fuse_fsyncdir
* fuse_readlink
* fuse_access
commit fca5286d3d8d12425f6a3258a1d36365d22a399c
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Oct 27 19:00:40 2006 +0000
unify basic functions are complete
commit ea9d7f51e3316a1ff8a4aab217d338d4f9dfe500
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Oct 27 10:48:46 2006 +0000
* Unify changes done partially (ie, open, mknod, readdir pending)
* Bug fixes in server-protocol.
commit 41d1845619ca9971c2b4b25967059df179ccebbd
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 26 19:28:54 2006 +0000
fuse bridging with transport completed
glusterfs.c:
* main loops terminates gracefully when there are 0 fds to poll
* removed POLLOUT by default in poll flags since it causes busy loop.
see NOTE below.
fuse-bridge.c:
* fuse now works via transport interface
transport.c:
* transport_event_notify() - check for ret values of receive callback
before calling send on transport obj and
same with except as the previous callbacks
may have destroyed the transport object
-- NOTE --
For non blocking write, a poll () should be done with POLLOUT before
doing the write(). The original model proposed was that ->submit() will
append the buffer to a queue and main loop when finds POLLOUT poll to
be successful, will call ->send() which will dequeue and do the actual
write()
By keeping POLLOUT flag always set for the fd, the advantage is that
POLLIN notify is called first, which will result in read from network,
STACK_WIND down upto posix, which synchronously STACK_UNWIND's the way
back up till transport and ->submit(). Next, the POLLOUT flag is checked
and ->send() is called, which immediately finds entry in the queue and
flushes it down the socket.
* advantage - reply packets go back immediately
* disadvantage - HUGE cpu %age utilization as poll becomes busy loop
during idle time (POLLOUT always succeeds immediately)
Another approach is to set POLLOUT flag for the socket during ->submit()
so that the next poll will call ->send() which will dequeue and clear
the flag.
* advantage - optimum cpu utilization
* disadvantage - when large number of clients are connected, each poll
cycle implies iterating over 1000s of clients. The
->submit()ed data is only written after the 1000 client
iteration since setting the POLLOUT now only results in
->send() being called in next loop. This increases overall
transaction latency even though socket is ready for being
written we are getting poll's approval only in next big
loop.
proposed model
--------------
* Set the socketopt with O_NONBLOCK for that socket.
* Do not poll with POLLOUT in the main loop
* In the ->submit() try the write() straight away.
If it returns -1 with errno=EAGAIN, now append to queue and set POLLOUT
only for that socket in the main loop. Now whenever the socket becomes
free for write() main loop will call ->send() which will dequeue
and flush to network.
commit dfe6285bf368a0ff23dda9f6a05291587bd99f2e
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 26 03:13:00 2006 +0000
glusterfs-fuse changes
* restructured code in glusterfs.c and glusterfs-fops.c
* remove '-o' option from argp. all options to fuse_setup go hardcoded.
* remove fuse_operations usage from everywhere.
* moved fuse structure into fuse-internals.h
* renamed files
glusterfs-fops.c -> fuse-bridge.c
glusterfs-fops.h -> glusterfs.h
defuse-hookup.c -> fuse-internals.c
* glusterfs.c: implment main polling loop
* fuse-bridge.c: use transport interface to bridge with main loop
* fuse-internals.c: moving fuse_setup and fuse_new_common into
fuse-bridge.c (init of fuse_transport)
*BATTERY DIEING COMMITTING INCOMPLETE WORK*
commit d352fc1541a50889f4db045a5aed849eead72c8d
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Oct 26 00:02:50 2006 +0000
filled transport.c register_transport and main loop in glusterfsd
glusterfsd now has mainloop poll over registered fd's from
register_transport.
-- IMPORTANT --
when any of transport_t->ops->{notify,send,except} returns -1, the
main loop unregisters that fd (transport_t object) from its polling
list
commit e93bf7c97a7cac76a86884714943e7be7b2c4655
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 25 07:40:48 2006 +0000
added tcp/ and ib-sdp/ client and server transports
commit d45e7d05cb78c19d7806d2b8e3893664de6b1d49
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 25 03:30:05 2006 +0000
bug fix: ctx was over written. which was causing EIO in read/write.
commit fe732ca8c51a6306a4b3e961c516249ba3e8509a
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 24 17:52:02 2006 +0000
transport API modified, now have different .so's for client and server
commit b2c893982129f5bca90749a904f7e46c0dcad110
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 24 11:05:20 2006 +0000
transport API final
commit 186c32b1bb70ad3d5432810eb1cc52f9a545ffe7
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Oct 24 10:45:14 2006 +0000
new transport API
commit cc6fe0777d7daca4ecdbe0b46c61f378a557ce26
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Oct 24 08:16:48 2006 +0000
updated mops in server-protocol.c, can be tested with client of tla arch 2.1 branch.
commit e9684977932b6cca6f4d83bc4e4b5674564393c6
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Oct 24 03:24:55 2006 +0000
changed glusterfsd to use new APIs. Added server-protocol xlator.
commit 176163e57f24955c2d69d51dfe5dc062f1195bb2
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Oct 23 15:04:40 2006 +0000
commit 833637d9df1867af8cf5e8e47fb636fafddc4b40
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Oct 22 21:38:51 2006 +0000
THIS COMMIT BREAKS GLUSTERFS BUILD
libglusterfs/src/xlator.h:
* fixes in STACK_ macros to use ref_count
* removed old fops from xlator struct - BREAKS XLATORS BUILD
libglusterfs/src/defaults.[ch]:
* replaced all default functions for new model
commit f61357375033a74dd6d65fb1325c748c4802a7c4
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Oct 22 02:03:30 2006 +0000
miscellaneous changes
libglusterfs/src/dict.c:
* fixed bug of count being incremented for dict_set of existing key
glusterfs-fuse/src/defuse-hookup.c:
* removed unwanted functions
libglusterfs/src/xlator.h:
* updated function prototypes
* defined call_ctx_t and call_frame_t
* defined STACK_WIND and STACK_UNWIND macros for
making inter-xlator calls for requests and
responses
libglusterfs/src/defaults.c:
* updated for new xlators
commit 58ae0520de2a2149a72e2a797242199d89217de9
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Oct 20 05:26:02 2006 +0000
added transport.c
commit 5b4345ecc952ce595f2e9980a66fb2c1d3cf5ece
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 18 23:04:10 2006 +0000
added transport.h
commit 4859f8b8a3f69ba9d1abced9512e24e96c711d66
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 18 21:25:42 2006 +0000
added new transport API
transport mechanisms are now isolated from the protocol code, in the transport/ directory.
Each transport provides methods to connect, send, and recieve, and also handles reconnection.
commit 8ef8054145a69bc80352ebd756b089335c38e919
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 18 21:09:54 2006 +0000
API changes - all response functions have same prototypes now.
commit 4c0e0551ca73266396fccf4674da966a9fb37acd
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 18 09:54:41 2006 +0000
fixed the stat I/O error.
commit f9b3671c78c1516a0236f14db03530e8482c27e8
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Oct 18 07:41:31 2006 +0000
committed the correct dict version
commit 385f0f10c3f499d906232140e1e7eb1420530574
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Oct 16 10:34:07 2006 +0000
fixed compile errors in glusterfs-fuse
commit 5c8413342ae830fde2a610cb078329138ef74341
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Oct 16 07:52:05 2006 +0000
changed dict_t to use hash table internally
commit 3a9dc6611019fe193935641e0bf7a46af0d132c9
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Oct 15 23:32:07 2006 +0000
broken fops and mgmtops protypes put in xlator.h
commit e532788dc558ae4b123e55800e00afefb1ed9e4b
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Oct 15 22:19:19 2006 +0000
main loop into glusterfs-fuse
defuse-hookup.c uses libfuse at lower level and main loop is now in glusterfs-fuse (my_fuse_loop) which later will become a select over fuse_channel and all transports
commit f141a16eba94f1572e1772674ad0b1894a8f5372
Author: Anand Babu <ab@zresearch.com>
Date: Thu Oct 12 00:11:02 2006 +0000
test commit
commit bf98fae859301fa1b7a01c300126f8d4d91824ec
Author: Anand Babu <ab@zresearch.com>
Date: Thu Oct 12 00:01:30 2006 +0000
Initial import
commit e3745abd1a2a01c916a4f83561583e9e0ce2ed89
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Oct 11 09:24:29 2006 +0000
changed "%llx" to PRIx64/SCNx64 in the code.
commit 99fa1db0cc11f90781e7755f1824d9d08bef35c5
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Oct 10 22:24:09 2006 +0000
on 32bit stdint conversion is done. works fine.
TODO:
* compile on 64bit machine and update the 64bit stdint.
commit 4e3c833e86f05b8262ee6dbb65126fc92df3db33
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Sep 27 17:21:54 2006 +0000
fixed problems with 'tla get' (fix in unify)
commit d0ab2453d9ccc739abc5a6847f1885d5c5db18b6
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 25 20:30:03 2006 +0000
memory leak fixes.
commit f9bf457e3ba866cde9c6889ccc4e242c5fddb6c5
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 25 14:16:07 2006 +0000
added check for return of FILL_MY_CTX ()
commit e80911a1804b17f2843b198056122714da02911f
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 25 13:43:51 2006 +0000
removed 'type punning' warning.
commit 86441ada13f43e265440fd1593e4198741082571
Author: Amar Tumballi <amarts@redhat.com>
Date: Thu May 4 23:34:36 2017 +0530
rebase-fix: done to fix the rebase issues
commit 7b196ef2b4c071e59f5e88afe0bc469aa1e99624
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 25 05:21:23 2006 +0000
fixed warnings in case of 64bit machine
commit aed517c890f371ab8a00a3e9127724b31520e9da
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 25 04:58:39 2006 +0000
used "stdint.h" for variable declaration. build for 32bit machine without warnings.
commit eb1ff7f2f8b3817d4b30a4a5b00a4e489d10ff22
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 22 15:38:01 2006 +0000
Fixed memory leak in glusterfs (fctxl->path)
commit e15041a1123533c3e7e5e680f0f432c4e0500209
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 22 11:40:18 2006 +0000
removed warnings related context in transport/*
commit 52fdaf86301a6f005a913baa3df99e2c1dc5b30a
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 22 11:27:54 2006 +0000
memory leak fixes in posix_bulk_getattr
commit 2a1bb03dd73a386407b3d0c91dc981635f27b805
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Sep 22 11:16:00 2006 +0000
format fixes in dict_serialize/unserialize
commit b0ec2731a1d3f207c8c31d0b4e72ff7a54ece4eb
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 22 06:57:05 2006 +0000
changed child->next to child->next_sibling in unify_readdir
commit d28dce61569e76a6b349233e7bf3d4a46bd3ab1d
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Sep 22 01:00:19 2006 +0000
fixed behaviour of unify_rename
unify_rename does not return EEXIST if newpath is already existing, instead tries to overwrite
commit 611b6f6937fe6cd55658d2b935a900f6a66aebe0
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Sep 21 20:11:19 2006 +0000
fixed warnings in case of 64bit for (storage/posix)
commit 1dd1862bd83ec7f9dbf8e26df01b7f7f77e8dd4d
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Sep 21 20:07:16 2006 +0000
fixed format related warnings
commit 40d2a193c72aa7f10a363bbb836ad2e4f090e87b
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Sep 21 19:21:00 2006 +0000
warning fixes (few of them)
commit b465862490be077b647d6d9b2e86187f0995e25a
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Sep 21 18:05:38 2006 +0000
unify_readdir cleanup
memory allocation is done in one shot after calculating total length in prior.
removed namespace related code
commit c055cd427712ea5d10b71646ac572a5d4afb5d9c
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Sep 21 03:39:55 2006 +0000
code cleanup in unify
name space code has been completely removed. locking needs enhancements (read-write lock support) to imporve performance. readdir cleanup pending. tested with 8 parallel cp -a of /etc. need to test with dbench and iozone.
commit 06602a3ed0383bfddad15fd7fd907a25df765dd4
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Sep 19 12:27:32 2006 +0000
changed the return value of glusterfs_open.
commit 3a305293e8374cf7129962735c9384be12114057
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 18 17:20:14 2006 +0000
added 'return -1' to transport/ib-sdp's nslookup and nsupdate
commit 87bb2448c7b67c1e6b7b8eae31cde1a764a76558
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 18 00:50:21 2006 +0000
removed warnings from 'cluster/unify'.
commit fd50b7c0d7bf2ffb555581071c8b78f4397a7b17
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Sep 17 12:17:26 2006 +0000
fixed format string for statvfs
commit 360b991649c1b2c67213eee8f8a78d6ef66f2d8e
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 16 12:11:09 2006 +0000
commit c1d6aa0cf7d2e401a53a6b6e2aa9ec2c8ca6334c
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Sep 16 09:23:30 2006 +0000
fixed format string bug in statfs calls
commit b1ac5516c4693d34b7f5fd8a5b6f2009519e50b5
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 16 08:53:52 2006 +0000
almost working 'unify' and ofcourse GlusterFS :)
commit b917247cd60f9c5cd77a612d3daf03998b2e1168
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 16 07:29:08 2006 +0000
fixed some errors in unify
commit f44833ee20e422c35ea22985e037d0a25dd183ac
Author: Anand Babu <ab@zresearch.com>
Date: Sat Sep 16 06:08:19 2006 +0000
changes to unify and glusterfsd for new locking convention
commit 0c1929d844f45b1354b2a503059c8f7dc900251c
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Sep 15 23:51:19 2006 +0000
changed ibsdp to ib-sdp
commit f4dfff5f4d3c0bd59b9adfea2bac09f425610b9d
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 15 23:41:12 2006 +0000
commit 04f5029a9a8db96a4d4efbcc7dd938e4479b009f
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 15 23:21:22 2006 +0000
commit ae419e5e14b5001a1b16832c568809f81dfad446
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 15 23:05:41 2006 +0000
fixed the problem of 'errno' update problem
commit 7335b8060715becbc3b3d98c91e22bb693334989
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Sep 15 22:42:10 2006 +0000
commit efb23da86cb13b270e858c0f5be137d7b5d37f9d
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 15 22:34:08 2006 +0000
commit 0214d122f3d973699790a8bff7ce5e8d54d2c931
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 15 22:25:01 2006 +0000
fixed bug with unify 'link'
commit 02b2f114b5e76539119de8595776badfe5f7cd68
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Sep 15 22:01:14 2006 +0000
changed configure.ac to make lib check for guile to work with guile-1.8
commit 858017d515fc279343f7c3c811ec840f64316ace
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Sep 15 21:47:46 2006 +0000
fixed minor bug in trace
commit 20f5da15164eb71f26e8c253ee03209ef9eca0ef
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 15 21:10:41 2006 +0000
removed double free in layout.c (layout_destroy)
commit 85e3f8ff9171b00b88ea35f9a916dcdc50ce5294
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Sep 15 21:04:20 2006 +0000
changed trace xlator to never return on invalid arguments, only log
commit 045dfd35ca5ad9e8e8c981f1d3c886e110f66436
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Sep 15 20:20:37 2006 +0000
bug fix in glusterfsd, removed double freeing bug
commit cd56dbc03352aee73d1a901d86f68af7c0c2088b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Sep 15 20:07:19 2006 +0000
commit 96f85ab4847c2806ff7d74357cff041aeaa12d05
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Sep 15 19:00:37 2006 +0000
fixed bug in glsuterfsd which was setting wrong fd to poll on
commit 1323fb26f43660e5fc8dd68e1bdcb8862883bc0d
Author: Balamurugan A <bala@zresearch.com>
Date: Fri Sep 15 13:53:45 2006 +0000
When invalid function arguments, xlators/debug/trace/src/trace.c functions do not return with error, instead it gives control to next child
commit 1388ec23e9baf0c04f5f920b828c870f0d4ea75e
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 15 13:28:47 2006 +0000
* Bug fixes in unify.
* Removed FUNCTION_CALLED macro, which reduces the logging size.
* enhanced layout_destroy ()
commit 60b5d3bed86be565d8e0aa71eabd23d80862872d
Author: Anand Babu <ab@zresearch.com>
Date: Fri Sep 15 12:10:30 2006 +0000
added prototype defn for layout_destroy
commit a6c2fe095180a89b0751cef556398e82e8fbac05
Author: Balamurugan A <bala@zresearch.com>
Date: Thu Sep 14 21:52:47 2006 +0000
improvement in random number initialization in scheduler/random/src/random.c
commit 99b485608a25ed1cfac0b7bc9187bb56fb1132da
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Sep 14 21:05:01 2006 +0000
fixed bad getxattr arg validation (value CAN be NULL)
commit 9abc44399a3e42fda3b9abf366682721a5ac54a3
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Sep 14 19:58:01 2006 +0000
destroying layouts which are allocated (which had memory leaks)
commit 5785c3ed9a42bcd3d1f68967dbb95fdf476a4da3
Author: Anand Babu <ab@zresearch.com>
Date: Thu Sep 14 19:19:07 2006 +0000
conditional glusterfs-shell compilation
commit 8823df0c6b73dd76a2e4d2f10ee95ebf6267867e
Author: Anand Babu <ab@zresearch.com>
Date: Thu Sep 14 18:35:03 2006 +0000
check for guile-config tool
commit 115f30472a08fec8574e63bd5581e13148d53ecf
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Sep 14 17:08:17 2006 +0000
* added 'srandom ()' in scheduler (random, alu) to get more random values.
* changed 'int' to 'unsigned int' for the hash_value in unify.
commit 7adc8ffe00c8ff83986478163eb2fd8a11093751
Author: Anand Babu <ab@zresearch.com>
Date: Thu Sep 14 14:53:02 2006 +0000
fixed compiler warnings
commit 3d7d536518da87b794a8771eed689666e0debda1
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Sep 14 13:44:02 2006 +0000
fixed memory leak in cement_unlink
commit f24110b4f4df0cdebcef39ea27537bc0fbce8a23
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Sep 14 13:22:48 2006 +0000
held locks are kept in socket's private data and free'd on unlock or forcefully unlocked when client connection dies
commit 0175822a45d9698f63602069646406fde9aa00d0
Author: Balamurugan A <bala@zresearch.com>
Date: Thu Sep 14 12:10:52 2006 +0000
fixed argp bug in glusterfs-fuse/src/glusterfs.c and glusterfsd/src/glusterfsd.c
commit 3558fb742360d723e2719a667f307d942ef3544e
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Sep 14 09:19:50 2006 +0000
memory leak fixes
commit b87df821142b7f030db41c41728745bc3e2f4b26
Author: Vikas Gorur <vikas@80x25.org>
Date: Wed Sep 13 20:22:06 2006 +0000
fixed a couple of memory leaks
commit 812b9eb5401c071dddee19e7811345ed56c1b124
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Sep 13 14:42:29 2006 +0000
changes in command line options
commit df5cd25eb618ed7111a66a519e59b351aa3521fd
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Sep 13 14:26:13 2006 +0000
commit 52657e32d697e4e9550626c603a791b9210c6d85
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Sep 13 07:56:35 2006 +0000
commit 2453c79cb805b22373c286787d29b0a928969908
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Sep 12 23:26:54 2006 +0000
minor edits
commit ca870809cab06b9677c8dd3c78a5c82e886f1199
Author: Balamurugan A <bala@zresearch.com>
Date: Tue Sep 12 23:21:25 2006 +0000
major code review fixes on glusterfs-fuse/src/glusterfs-fops.c
commit bf4a6de1f3fc8e30199713fa30aef2c28d91f861
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Sep 12 22:58:09 2006 +0000
fixed command-line option for glusterfs-fuse to make it daemon by default, doing input validation in glusterfsd
commit d3f05c0a617c318237fe1c23f906c24aab3fe9f5
Author: Anand Babu <ab@zresearch.com>
Date: Tue Sep 12 21:42:56 2006 +0000
changed int to socklen_t type
commit abf33a70b66580c2d78de8aa98beac41d6791882
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Sep 12 21:23:52 2006 +0000
misc cleanup
commit ec782c51da9300d074a5ff9f93719d14c8d4b821
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Sep 12 20:39:28 2006 +0000
commit 3259dddba181caef58658058bbaa24cc0d2a41ec
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Sep 12 20:19:50 2006 +0000
added log messages in many places
commit 06e7849bbdb8456360cbd0cf746d3d93c56f8e66
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Sep 12 19:49:56 2006 +0000
commit 0a0bb3dc6e04bf8bedc5371a00a0b940fcd0d7ac
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Sep 12 18:11:30 2006 +0000
misc cleanup, added gpl notices to all files
commit cbe611ac97a1aa02145134b23e955a2c7e27932b
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Sep 12 17:24:52 2006 +0000
commit e94c7b3eebe5740581d23dee0d36db1b9f7080bd
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Sep 12 11:06:36 2006 +0000
commit 0f4e1623e7ffd191de72ae8768eadf85dfb031d3
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Sep 12 11:13:35 2006 +0000
fixed warnings from lex source
commit 0c543c88ce7012d53516c67b29387973dfd4e6d6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Tue Sep 12 10:38:33 2006 +0000
tested glusterfs-fuse with latest argp changes
commit 408442c5f7094e5be7669dcc8684e7de847efc80
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Sep 12 03:48:45 2006 +0000
* Changes in glusterfs_mount to properly do strcpy
* Updated 'cluster/unify' to work fine.
Keywords:
commit 71a3ff635169fe67d831e66b4f7ff81cd049b212
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 11 22:05:49 2006 +0000
* Working 'cluster/unify'
* Few more function to be implemented.
Keywords:
commit 632b3a71371123cf9718fc73c720593a611ee13d
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Sep 11 21:16:42 2006 +0000
commit 33343c9d624acc3870414b319194ddccfbca475d
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Sep 11 21:10:51 2006 +0000
changed glusterfsd to be consistent with glusterfs-fuse in terms of command-line args
commit 73839f0dc50555fda1791c5423b142e427cef081
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Sep 11 19:59:10 2006 +0000
write-aggregate done
commit 5e241652c6a411b86e193e9cb0e3f5c29ff65078
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 11 18:51:49 2006 +0000
* updated 'cluster/unify'.
* required changes done in relative functions of layout, ns, locking, glusterfsd.
Keywords:
commit d706e483c32a9989535450a68bc308bc88bc6c2a
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Sep 11 14:08:30 2006 +0000
misc cleanup
commit 7006ecc71ac70db7708e70e1edd34f0bb6220d5c
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Sep 11 13:47:28 2006 +0000
changed LOG_* to GF_LOG_*
commit c7c5ba75c0d551a078d193821eb8df93dc420340
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Sep 11 13:16:12 2006 +0000
added GF_ERROR_IF_NULL
commit 477bbb1ef58325c610b80ff10b0c7abb81bf79e6
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Sep 11 12:49:26 2006 +0000
* Updated 'cluster/unify' to use locking while creating the file.
* Removed few more warnings.
commit 3da369ee88b7d4bf3bf53be640ea851782dc92cb
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 9 20:42:35 2006 +0000
* Updated 'cluster/unify' to show only one directory entry from the subvolumes.
* Currently it doesn't use any lock and nameserver.
commit 4ea9f0d088c437d58ebfbf3609f82ccfe9f58baa
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 9 19:19:01 2006 +0000
* Removed most of the warnings.
commit 04fd98f731bc1e6c45714a3202973c7ac01c9d7d
Author: Anand Babu <ab@zresearch.com>
Date: Fri Sep 8 14:19:03 2006 +0000
build fixes
commit 8cd2e44fdc3c50d10822048452ea4f01bf929224
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Sep 8 10:14:55 2006 +0000
Imported into 2.0 version
commit 33484ce04eea0d0a31154acb373cf8a5035c169f
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Sep 5 09:36:46 2006 +0000
messed up trying to add GPL notice, recommitting previous patch level
commit 1dbe743ef27ee803cb56ac023c2799e04f328758
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Sep 4 13:43:20 2006 +0000
added gpl notices (correctly)
commit 9af27d4ea2f2612fd83a660e246787a025c87afb
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Sep 4 12:12:25 2006 +0000
added GPL notice to all files
commit fa1a09959ebacaada6bf3ecbc4d537699014d34c
Author: Balamurugan A <bala@zresearch.com>
Date: Mon Sep 4 10:56:02 2006 +0000
fixed compiler errors in xlators/dummy and xlators/debug/trace Makefiles
commit 67b750335a765efb9198d0bd7f7cfeb5287c7fb9
Author: Vikas Gorur <vikas@80x25.org>
Date: Mon Sep 4 07:23:35 2006 +0000
added headers to dist target
commit fc14e53b031a150170f71c7c7b92220619881642
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Sep 3 21:49:00 2006 +0000
changed stat-prefetch related calls to remove '\n' delimiter and use '/' as delimiter
commit ae07c809384f11d10b1f6c14eb52d3336e7bf8bc
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Sep 3 21:39:11 2006 +0000
* added code to check POLLERR case in glusterfsd.
* added code to check for the export directory's existance in posix, if not there, create the directory.
commit c0412684505225c8cd4eb25bf62803a3ee749834
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Sep 3 20:41:16 2006 +0000
nasty bug in full_rw fixed
commit 9da78b553fe7460afc206321c7790932fc58a1a6
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Sep 3 19:49:24 2006 +0000
added full_write and full_read; changed dict_unserialize signature
commit 3a221e2582ca6b8add96c01673b98e53073b82b1
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Sep 3 18:39:40 2006 +0000
changed protocol.c to check for return values and errnos properly
commit 4ee37878174634c429836778d1eff39b768ccf73
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Sep 3 18:02:01 2006 +0000
namespace server and mgmt ops in brick and default ops
bugfixes for lockserver
commit 9539811a2aed65ab068a76ecf7131c94a9120b7d
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Sep 3 16:19:58 2006 +0000
increased field widths in dict serialization format
Changed key length and value length fields to be 8 digits instead of 4.
commit 1807ac0ddad41f3da739ffc6c2b8fd0863933590
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Sep 3 05:32:07 2006 +0000
fixed minor bugs in stat-prefetch due to lack of validation of input parameters
commit b90574129fb076f04d33b5d21e68a6d48847fa3b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Sep 3 05:27:15 2006 +0000
commit 1c3ee43c9a9cdb766b4129ce29791c43cb6c7508
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Sep 2 10:23:32 2006 +0000
build fixes
commit 2ad469a1b105998445af14e4ce1ccb7d1014fd0b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Sep 2 02:49:51 2006 +0000
build fixes
commit de48692900caacf597f56f96f2299153ea90fb73
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 2 02:32:02 2006 +0000
updated unify to handle 'getattr'
commit aabf935a03a2e1e727db75d230ef4f3c7c6724cf
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Sep 2 01:51:34 2006 +0000
changed libglusterfs to a shared object
commit 66321ede403ead596e024e4281976742c288fe41
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Sep 2 01:04:31 2006 +0000
fixed -o options bug for glusterfs, fixed default log directory
commit f15b87d78fac18e89dac0b5923c3e49c58667555
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Sep 2 01:04:18 2006 +0000
made 'errno = 0;' for all return value >= 0; in glusterfs-fops.c
commit 5fd03311c0241309140b1d2115a81ba1ec4a26c5
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Sep 1 23:32:49 2006 +0000
changed all usage of printfs to gf_log, fixed mount.glusterfs to provide correct log_level
commit 533c0f163dc816027c3dc2491367c108d6a40eef
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 1 23:32:35 2006 +0000
* bug fixes
* updated 'ipsdp' with mgmt fns implemented in 'tcp'
commit ab5d2ca2a6400b307847727ff59a6ffbf70ba698
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 1 21:05:29 2006 +0000
* Bug fixes for wrong time values in stat call
commit 3b4b90aef2cfe30629fee00bb6c8829c1ec9fcc4
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Sep 1 19:18:04 2006 +0000
change AC_PROG_LD to AC_CHECK_TOOL
commit 97c71be4a1f659b58f487e5b2ad4fd55ecec1144
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 1 17:53:02 2006 +0000
* Added 'nufa' (NUFA stands for Non-Uniform Filesystem scheduler) scheduler
* Added 'rr' (RR- RoundRobin) Scheduler
* Bug fixes over previous commit
commit d9485fc976ec2b7cf223a97928134e4125870283
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Sep 1 17:27:26 2006 +0000
commit b8f8deb630da51fa0ff5be04691df1c882d36030
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 1 11:29:08 2006 +0000
* Implemented read_usage and write_usage required for alu in posix translator
commit 5294f05f10ab9ce74d8fc1f505782b8e34eec012
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Sep 1 01:27:23 2006 +0000
commit c5deae3f43d852c27139b01902c7d33306c3335e
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Sep 1 01:37:34 2006 +0000
previous commit conflicts resolved
commit ece1c144ae9f6d89ab9f3a94696dffaa8c4bc8b0
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Sep 1 01:14:07 2006 +0000
added util/mount.glusterfs - mount utility for mounting glusterfs
commit 4baa313a2954d76c455e1b15a1b858dc06cf6b21
Author: Balamurugan A <bala@zresearch.com>
Date: Fri Sep 1 01:15:38 2006 +0000
socket/inetibsdp are renamed to tcp/ibsdp. updated docs accordingly
commit 16d314c100f2ef9a583f516a9343a8dbc0a03cb9
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Sep 1 01:15:54 2006 +0000
locking server for glusterfs, bugfixes/memleaks in glusterfsd
commit b8f5a9c951106dd80268a86d5b5eacaa1e2a88ef
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Sep 1 01:01:26 2006 +0000
added protocol documentation
commit 97114aed4254ea295a30773e51d1422737172c32
Author: Balamurugan A <bala@zresearch.com>
Date: Fri Sep 1 00:50:57 2006 +0000
xlator debug trace is majorly improved
commit 4f221a996fc8ff1c565901a0e8b1395aa7f85fe6
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Sep 1 00:40:36 2006 +0000
glusterfsd <-> transport protocol changed substantially
The protocol between transport xlators and the server is now isolated in protocol.c
serialization for dictionaries added
changed from using FILE to plain file descriptors
Refer: bug #17354
commit 5fa7089512eb177a17612d064848446f940bf7d7
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Sep 1 00:07:35 2006 +0000
* Fixed a bug which was seen with 'st_ctime' change.
* Updated 'alu' scheduler to work.
commit 45af087f8708c288605241d8e374fc5d9134c886
Author: Anand Babu <ab@zresearch.com>
Date: Thu Aug 31 23:42:44 2006 +0000
logging.c to use locale based date-time formatting and some warning fixes.
commit fa1ebfddb2cbaae7b1711f8811da993480a5e6b1
Author: Balamurugan A <bala@zresearch.com>
Date: Thu Aug 31 23:09:30 2006 +0000
compiler warning fixes wrt formats
commit 0135279517b7831bed4e67990dc234144ad7e260
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Aug 31 23:00:59 2006 +0000
Changed command line arguments to glusterfs-fuse.
commit 10517f505e83628c2cfbbe2332712d8736e74c60
Author: Anand Babu <ab@zresearch.com>
Date: Thu Aug 31 22:32:10 2006 +0000
trace translator enhancement and renamed xlator_mgmt to xlator_mgmt_ops
* started decoding of args during entry and return for each trace call.
* renamed xlator_mgmt -> xlator_mgmt_ops.
commit 77bf891ca7b8939eb474c36e9ca465ab61f3366d
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 31 20:20:05 2006 +0000
commit fc648faf78349a5140c858838b161ac62f57329b
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 31 17:59:32 2006 +0000
fixed a small bug in logging
commit 9aa7f39e753dfa0a88b15ee6291d5c445a374633
Author: Balamurugan A <bala@zresearch.com>
Date: Thu Aug 31 17:46:29 2006 +0000
updated allowed charlist in conf.l according to conf file changes
commit 15f9944e7b03da27dc717ef1a3329860d6627391
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 31 15:31:35 2006 +0000
dict and protocol block serialize/unserialize
commit e7478ed43b6740883cd562293bdb473b596f03be
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Aug 31 15:07:47 2006 +0000
fixed memory leak and buffer expansion logic in update_buffer in unify.c
commit e8ae44a852bd2e667072245aa33de4848aa393f6
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 31 09:52:30 2006 +0000
* enhanced alu. Now the config file parsing is complete and the proper algorithm prototype is complete.
commit 37642d830e689af541000637e153df39fb04eadc
Author: Anand Babu <ab@zresearch.com>
Date: Thu Aug 31 09:29:31 2006 +0000
new trace translator. logger APIs renamed, dummy face lift
commit ea165384a2e9ce2d1646b7fb04bda68a44d61a16
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 31 07:18:07 2006 +0000
default fops
default fops implemented
commit 3da08a79378e9acbc68cc205d35b0fdbc5c1a447
Author: Anand Babu <ab@zresearch.com>
Date: Thu Aug 31 06:23:46 2006 +0000
revamped sample translator into dummy translator.
Dummy translator is supposed to do nothing, but works. How ever it
will check for proper input validation. Dummy is the best example for
beginners.
commit b2aef1b0cce111dce50cc835c7a47a1ff8be2635
Author: Anand Babu <ab@zresearch.com>
Date: Thu Aug 31 02:00:02 2006 +0000
sched moved to cluster, fixed some warnings, input validation for data_to_int
commit 946dcb6092c7a91d8217bb0e80f2d18b89aafe3c
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 30 23:04:25 2006 +0000
* alu scheduler config parsing is done. It schedules file to only the minimum usage of each criteria
commit cbe9a728b1584ebd20ef33ecbc8fb39b9d8fa364
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Aug 30 22:44:26 2006 +0000
commit 8739e1554108d195e2f66a1a60a8154f0532995d
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Wed Aug 30 22:26:35 2006 +0000
fixed port scan on client side to look for port-number<1024.
fixed logical bug in bulk getattr.
commit cac68b15176bf9f9c9b3c1e3eea9e7cef503a817
Author: Balamurugan A <bala@zresearch.com>
Date: Wed Aug 30 21:29:54 2006 +0000
glusterfsd listens/binds to given port/ip address
glusterfsd.conf 'listening_port' is renamed to 'listen' and glusterfsd
listens/binds to given port/ip address. 'listen' can be a port or
ipaddress:port.
commit 97d3f60e7c3089bcb74adc134eebdf96874b2acf
Author: Balamurugan A <bala@zresearch.com>
Date: Wed Aug 30 18:43:30 2006 +0000
added ibsdp address family support
now glusterfsd supports ibsdp by reading interconnect_protocol key
from configuration file. inetibsdp is new transport, which supports
ibsdp.
commit 938c15ede99c972a4063b155e23f87376cc76520
Author: Anand Babu <ab@zresearch.com>
Date: Wed Aug 30 08:43:50 2006 +0000
config and volume spec files updated
* Config file rules added.
* New syntax for ALU options.
commit 299b3151c054441da6355fd3784473f6cbd69ba5
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Aug 29 16:10:40 2006 +0000
Made changes in the code to change all the spec file to lower case (as changed by AB)
commit 90a56561e85aeabf9afcb33dfd9b0886301e7959
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Aug 29 09:50:00 2006 +0000
changes for namespace, lock and unlock in xlator
commit fa8bd5b50803a474a9c02c9be0089a62a3dae1ce
Author: Anand Babu <ab@zresearch.com>
Date: Mon Aug 28 23:13:47 2006 +0000
moved xport to transport, steroids to optimizer
commit fe42edfdaecba00e4c10f708eeb05e5d631f365f
Author: Anand Babu <ab@zresearch.com>
Date: Mon Aug 28 21:15:33 2006 +0000
added new sample volume spec file and updated server conf file
commit 15853e2856e4a480149de21e60dceddad6708bc5
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Aug 28 21:00:27 2006 +0000
commit 71aee151f99250301e385615318551f6f91ab4be
Author: Anand Babu <ab@zresearch.com>
Date: Mon Aug 28 20:43:40 2006 +0000
added new sample volume spec file and updated server conf file
commit bffde67a0447f346689b7fda263d1ab1768c1881
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Aug 28 18:42:59 2006 +0000
Added missing file alu.h
commit 5e0624977cc893d41d3aea9fdb1c117fbf8ee415
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Aug 28 18:32:47 2006 +0000
configure.ac does checks for guile
commit daa7beebb9f25713ee9498eaa5e6c2855c3beddc
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Aug 28 18:23:20 2006 +0000
* Added random schedular (works)
* alu schedular in progress
commit 8d01311da807f1f20b45e316b0ae8d157e99be8b
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Aug 26 01:01:24 2006 +0000
correction: 'schedular' to 'scheduler'
commit 1f3745647a5e1ee21b908c605a83f57cbf63492b
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Aug 25 18:36:57 2006 +0000
bug fix with allow_ip problem.
commit 3c6770214c33fc18c667531b2474e304a87155e5
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Aug 25 17:56:34 2006 +0000
* Added schedular frame work
* Changed xlator *.so to enter $(libdir)/glusterfs/xlator/*.so
commit a823f256aa9f836ffaf87e77a6832b3c8df81bb3
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 24 18:50:41 2006 +0000
two default ops and layout alloc/free
commit ce149588ed9bf19da99bf8c7e81b2de6ac8cd68f
Author: Anand V. Avati <avati@80x25.org>
Date: Thu Aug 24 18:44:11 2006 +0000
two default ops and layout alloc/free
commit 2cc3e67014fd639d405473cda10310818a244577
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Aug 22 18:15:50 2006 +0000
Added file
* doc/glusterfsd.conf - used for configuring glusterfsd.
Updated file
* doc/volume.spec.sample - used by both glusterfs client and server. Few options are shown how to write a specification file.
* glusterfsd/src/conf.* - updated to parse the glusterfsd.conf file properly.
bugs fixes
#17294 - added config file for glusterfsd
#17291 - added option of checking ip and port for authentication
commit 0c3b9b5d8cf08747a9da7367b6bf193aa8c35bc2
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Aug 14 20:54:55 2006 +0000
added bulk_getattr and changed getattr xlator to use bulk_getattr
commit 39094d41dba00a66060fb718381bf26ea2ace639
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Aug 14 19:49:46 2006 +0000
modified steroid/stat-prefetch xlator to use bulk_getattr
commit f31bf2ee4e8ebca5775cf015508b92b707a3c5c1
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Aug 14 08:08:32 2006 +0000
Fixed bug #17406. (conf.l fails to build in flex)
dict.c changed to behave case independently.
added dict_case_get (), dict_case_set (), dict_case_del () functions.
commit 7ee851cb96dbeb44bdd7fcc65a4c984459c90010
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Aug 11 20:52:44 2006 +0000
changed hashfn.h to hashfn.c, fixed a few bugs
commit 079b4209406675ff966b68483d158d00ff7f0f1c
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Aug 11 20:44:37 2006 +0000
changed hashfn.h to hashfn.c, fixed a few bugs
commit 707e658121523ccf749ca59c0d5fb8da178c560b
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Aug 11 20:29:54 2006 +0000
fixed some bugs in the location hint module
commit 066bd1fb989435e35fd89f6f7c15ba370ba9957e
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Aug 11 20:06:19 2006 +0000
location hint module done
commit 42022b00251550edcf43d1e93d3cfac548079429
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 11 19:47:44 2006 +0000
updated doc/sample.spec according to new xlator names
commit dfb1b7cd41a536b67dc6ba3916e2ca64b01be527
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Aug 11 19:42:35 2006 +0000
translators renamed
brick -> xport/socket
getattr -> steroid/stat-prefetch
cement -> sched/unify
posix -> storage/posix
files and makefiles have been renamed.
inner variables to be renamed by xlator authors
commit 743f5259da4212d026642b915f02fb7fb3ad1c88
Author: Vikas Gorur <vikas@80x25.org>
Date: Fri Aug 11 19:09:42 2006 +0000
set max. no of file descriptors to infinity in all programs
commit e622a1895c74f2d919f9286135a426b5e73dbbe7
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Aug 12 07:02:46 2006 +0000
added some testing code to loc_hint.c
commit 83b2f3e0582bbb7d6d29de497d8a6fb72a3dcacd
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 10 23:34:03 2006 +0000
* Bug #17398: Converted the dict_t to use 'key' as string.
* Changed 'ExpVolume' -> 'RemoteSubVolume', used for export point option.
* glusterfs-fuse/src/glusterfs.c: commented '-o' option part (added a FIXME comment)
commit fcfab0ce77067ed3f0633ff6be961613cdc75a87
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 10 02:08:31 2006 +0000
#17294 - Config file for glusterfsd (In Progress)
#17284 - file_context structure's list to enable graceful socket close. (Fixed)
commit 764e80e429cca0dbfd74e0f2cb4a26466800d69e
Author: Vikas Gorur <vikas@80x25.org>
Date: Tue Aug 8 23:48:17 2006 +0000
added location hints module to libglusterfs (bug #17353)
commit 7f085b87aeba8d7e0de125dae3057eebd8363c86
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Mon Aug 7 12:10:43 2006 +0000
commit e0d7729c6e585c5f65c9402eab21be57f806050c
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Aug 6 23:58:30 2006 +0000
partially fixed build warnings
commit d429a8e1409fa6278506027bc72f80c41a8b3b2b
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sun Aug 6 22:38:06 2006 +0000
argp support to glusterfs tools
commit 441acbf97673f4e93739a9730eba8ff0049cd70e
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Aug 6 07:55:16 2006 +0000
fixed leak in generic_xfer (bug #17290)
commit 1220987bfe72cec5eb6be18b7ca84c0ca8688fb4
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Aug 6 01:03:26 2006 +0000
changed fprintf's in many places to use logging module
commit 6a0afb65b240a804c5c00d90322c52107030d890
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Aug 6 00:32:18 2006 +0000
bug #17330
no longer necessary to specify absolute pathname of specfile to glusterfs-fuse
commit fdad54721eadd33f9eef9876187564f96a2297b7
Author: Vikas Gorur <vikas@80x25.org>
Date: Sun Aug 6 00:22:20 2006 +0000
added logging module (bug #17324)
commit 61597dfffd1f04baa1e3220fc5c08809b85ff2c6
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Sat Aug 5 02:21:59 2006 +0000
getattr lock fixes
commit 645353c50a49ba3d71789a9d45a590b11abd26c5
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Aug 5 09:28:38 2006 +0000
make all binaries dump core (bug #17292)
commit f5d39e17a681bc12baea99b8fe9ded726df86fdb
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Aug 5 09:19:24 2006 +0000
stats added to protocol (bug #17281)
* added new OP OP_STATS
* use the OP for transaction with glusterfsd (add handler for that OP in glusterfsd)
* populate structure with members like # of files
commit 5abfc9924e6bf3b0fd7bed04a0b5336694de9dae
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Aug 4 20:24:49 2006 +0000
* Protocol changed.
-> brick.c/h updated by Avati.
-> glusterfsd part of the code is changed to receive the new protocol
-> added glusterfsd-mgmt.c for handling volume exports
commit 10c67d1913726faf881b274c9c7cfa85b389d41f
Author: Vikas Gorur <vikas@80x25.org>
Date: Sat Aug 5 07:56:48 2006 +0000
populated posix xlator stats, added stats primitive to shell
commit 83e8b2f1316449c313c28f885034bb3af0dc0e24
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Aug 4 16:00:33 2006 +0000
mutex locking added to getattr xlator
commit ab36e4b8814977466a3f46c7b79982a5eaef84aa
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Fri Aug 4 01:16:32 2006 +0000
added getattr xlator - BugID - #17280
commit 9dded0dece66ae3668b0849612bc090129eab2aa
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 3 23:40:10 2006 +0000
fixed a few warnings
commit 8d87d111cca10c2862db4eb65620c11cc760cabd
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 3 23:23:03 2006 +0000
changed xlator init () to return int, also check for return value in glusterfs_init ()
commit 9f1dc2bd4cd73dc6804ca8b5761b5836b1baca54
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 3 23:12:34 2006 +0000
added stats to fops, and dummy implementation in all the xlators (bug #17281)
commit 18ec77e58b33500907ffdd6a5fe513585bf6f69b
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 3 22:55:35 2006 +0000
added support for other address families in brick (bug #17282)
commit 07fd47e44fcfb9df4ac419ddeab7ee3b3204efff
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 3 22:07:35 2006 +0000
fixed problem with the RELATIVE macro (bug #17285)
commit a7944a052b1f00cc91cf9f5cec674418da57f6f0
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Aug 3 20:03:47 2006 +0000
primitive.c added
commit d5472a66f6c489420d2984b13f86fb8bd2cacfed
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 3 19:44:18 2006 +0000
added read-only filter xlator
commit 04c813f9ff437618c7b207ebd9f7e8c2f79738ab
Author: Basavanagowda Kanur <gowda@zresearch.com>
Date: Thu Aug 3 19:29:52 2006 +0000
glusterfs-shell initial import
commit e29061907d118507ddf5f530af173ae1ba11cabd
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 3 18:09:54 2006 +0000
changed "cxt" to "ctx" everywhere
commit c460b1f9fbfbdedccabc7ce7cdfbfa09917d25a1
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 3 14:51:09 2006 +0000
* tested 'cement' for basic functionalities.. statfs works.
commit a0c96ee3c786cd0d4b6cc630b022ebeb4e08f571
Author: Vikas Gorur <vikas@80x25.org>
Date: Thu Aug 3 12:41:33 2006 +0000
added check for fuse>=2.5.3 in configure.ac
commit 462562d2505ff5b0432b661db51b018901a51096
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 3 03:31:36 2006 +0000
* 'cement' xlator, used to aggregate the directory is now working :)
commit 4240d2f752f880a07b77371abec5f5f6729d865c
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Aug 3 00:24:22 2006 +0000
* fs gateway working (posix --> glusterfsd --> brick --> glusterfsd --> brick --> glusterfs-fuse)
* brick and posix tested for all the basic functions
* updated all the structure to send data as ASCII in the protocol.
commit f3dcd47c227aeeb8d7d9140c7ca37fd1fa54108a
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 2 20:24:00 2006 +0000
* added 'is_debug' field in all the xlator, which can be set using config file.
* updated few pending functions.
* updated glusterfsd to call xlator calls.
* updated 'sample' xlator.
commit 6678aa88bbcd8ff5969d8a6900716571628a3762
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Aug 2 15:54:26 2006 +0000
filled missing calls in posix xlator
commit 3539a535c30bc9874c34689be8a765000fb18a33
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Aug 2 02:04:29 2006 +0000
dict_fill: re-use prefilled value placeholders
commit 4a2980572848615c37c807e9baa5218fc984bb7d
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Aug 2 01:32:34 2006 +0000
* 'posix' xlator working.
* abstracted fuse specific changes in 'glusterfs-fuse/'
commit 85a652daae95dedd732fc1cb3b3443bb899de403
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Aug 1 19:37:41 2006 +0000
Added
* 'cement', 'posix' and 'sample' translators
* updated glusterfsd to validate input filedescriptor contents
commit fb483aa80c46092cd4af6200ef30c37b840a705b
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Aug 1 07:38:20 2006 +0000
Code cleanup.
Removed few compilation warnings.
commit e237ca2e5e29ab91bfada04c3e3ed309e48d9a55
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 30 18:00:17 2006 +0000
commit 220fe541a4865dbeadf76c88717929abcfb1bd04
Author: Amar Tumballi <amar@80x25.org>
Date: Sat Jul 29 00:00:25 2006 +0000
glussterfs in working condition.
some of bug fixes and hacks in the code.. need to clean them all
commit c21866e51e2420ddcd5e75ef1d97cae4d0d1aaa6
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 28 19:36:29 2006 +0000
commit 3b4245eac7c05d3d841d007d6d9b7f30d55fd50d
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 28 18:24:27 2006 +0000
commit d734201ac78a6a48d09020416bb285bf160bbfdf
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 28 08:56:57 2006 +0000
commit 3134e8593ff13f9d4452b3522c67f90bbe3874c5
Author: Anand V. Avati <avati@80x25.org>
Date: Fri Jul 28 00:26:22 2006 +0000
commit fc09f6afc6ac36c0ab7e9b8e516a1dc69a6a3c95
Author: Amar Tumballi <amar@80x25.org>
Date: Thu Jul 27 19:03:58 2006 +0000
updated brick and glusterfs-fops
commit 69bad2ee7c0dca99362cf78222ca99f5470d14b6
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 26 23:31:28 2006 +0000
makefile changes for dynamic libraries (-ldl)
commit 98ccb1b67bad5f5c0c8c31af263202131aa304f6
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 26 23:24:04 2006 +0000
updated brick.c to match with glusterfsd-fops.c
commit 2074674c788b5d6bd8d4b5c0c6f52ae8d276cc59
Author: Amar Tumballi <amar@80x25.org>
Date: Wed Jul 26 15:36:17 2006 +0000
updated brick.c/h
commit afbd3f014214d850a5d80fc6c4bb078fa245596f
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 26 07:13:30 2006 +0000
commit 5ca157e79f4dd34eb4c815e5a265893f19753dae
Author: Amar Tumballi <amar@80x25.org>
Date: Tue Jul 25 22:24:54 2006 +0000
updated glusterfsd/ with the changes in the spec.
commit b966266ac2bfa658859cae9fdc2df329f2a9567b
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 25 20:57:23 2006 +0000
commit ec4b90dc9dcd64a781b8ad7b96d037c9099a255b
Author: Anand V. Avati <avati@80x25.org>
Date: Tue Jul 25 18:14:13 2006 +0000
commit 6b9831bf3aabfd6169dab8a9b54096bc662e25c0
Author: Amar Tumballi <amar@80x25.org>
Date: Sun Jul 23 21:48:20 2006 +0000
* converted glusterfs-fuse/src/glusterfs-fops.c functions to call xlator functions.
* updated xlator-fops structure with the function prototypes.
commit 2a803f49f3e05f533ce1f7980079a63fe6034e14
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 23 21:31:10 2006 +0000
moved data_t bodies to dict.c
commit 60ea0cc3d35db3e70471772b358759736bff9fe4
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 23 19:44:36 2006 +0000
added xlato.c
commit ed64356985d0211a1a268f5370f0e6bb1eeba6d3
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 23 19:34:09 2006 +0000
added missing files spec.l spec.y xlator.c
commit 0c7e8f90a2dfe3792adc20ec5760d00c80e8a00d
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 23 19:28:36 2006 +0000
fixes for xlator/brick/src/Makefile.am (temporarily made it a .a library, should be dlopen'able .so)
commit a95b14d3d2e2ecdbea762d6d8d6186b495ab7e73
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 23 19:16:56 2006 +0000
commited for sync
this commit will break the build and will not even compile
commit eb6deb076229c164a2af6068c18a20d71206c9f5
Author: Amar Tumballi <amar@80x25.org>
Date: Fri Jul 21 14:03:00 2006 +0000
Converted structure transfer to key:value style transfer.
Works, but more optimization required in dictionary handling.
commit b9ddb3eb078e3bf71ac58bed77405ebd525e4098
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 19 19:32:21 2006 +0000
commit a0bb609cf4f9a5702644e688abb7285823f3b7c3
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 19 19:10:38 2006 +0000
fixed bug in glusterfsd/src/Makefile.am
commit b7f3d814de0fe5f6af216376a64e51dd7f6206ca
Author: Anand V. Avati <avati@80x25.org>
Date: Wed Jul 19 19:00:57 2006 +0000
* directory restructuring
* libglusterfs has common code
commit c90a6937324b35ab4fcc897999f9d4962e876de2
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 17 21:23:54 2006 +0000
commit acdcbc6448325de0cbfdb72c50c588fe7e101fe6
Author: Anand V. Avati <avati@80x25.org>
Date: Mon Jul 17 20:56:52 2006 +0000
Added synchornization for multithreaded clients
commit d598394448bb941601a457ea5f94a7b61a2e9b51
Author: Amar Tumballi <amar@80x25.org>
Date: Mon Jul 17 17:56:37 2006 +0000
* Added feature to listen for multiple clients.
* Moved few code from glusterfsd.c to glusterfsd-fops.c
commit 5e98bbda609620054c8f8c16d77604b684fb4474
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 16 18:35:16 2006 +0000
Initial commit
commit 25565e50074e27449d85498f859f8d81f93cd60b
Author: Anand V. Avati <avati@80x25.org>
Date: Sun Jul 16 16:46:08 2006 +0000
tag of gluster@sv.gnu.org/gluster--mainline--1.0--base-0
commit 29b238aa1ce48ce5adb0a308693e24ffe5108ed7
Author: Anand Babu <ab@gnu.org.in>
Date: Sat Feb 18 01:08:13 2006 +0000
Generated by dwww version 1.15 on Sat May 18 06:42:47 CEST 2024.